Timeline


and

01/26/12:

23:52 Changeset [106097] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

Remove FIXME: ColorProfile encapsulation as a Vector<char> works well
https://bugs.webkit.org/show_bug.cgi?id=77176

Reviewed by Adam Barth.

No new tests. No change in behavior.

  • platform/image-decoders/ImageDecoder.h:
23:33 Changeset [106096] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectation change.
fast/canvas/gradient-add-second-start-end-stop.html fails on MAC GPU.

  • platform/chromium/test_expectations.txt:
23:23 Changeset [106095] by mdelaney@apple.com
  • 2 edits in trunk/Source/WebCore

ImageBuffer::draw should deep copy if drawing to an accelerated context
https://bugs.webkit.org/show_bug.cgi?id=77185

Reviewed by Simon Fraser.

No new tests since any test for this issue would be flaky at best.

  • platform/graphics/cg/ImageBufferCG.cpp: Deep copy when drawing ourself into

an accelerated context for both draw and drawPattern.

(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):

23:19 Changeset [106094] by kevino@webkit.org
  • 2 edits in trunk

[wx] Unreviewed. Build fix, don't build some sources
which appear to no longer be needed.

23:13 Changeset [106093] by kevino@webkit.org
  • 2 edits in trunk/Tools

[wx] Unreviewed. Build fix, add WebCore/testing/js
to the list of source directories we build.

23:10 Changeset [106092] by kevino@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[wx] Unreviewed. Build fix, wx uses the Mac ICU headers so we must match Mac behavior.

23:05 Changeset [106091] by kevino@webkit.org
  • 7 edits
    2 adds in trunk/Source/WebCore

[wx] Unreviewed. Build fixes.

  • Remove some constructors not generated by CPP bindings from being added to CPP binding headers
  • Keyboard event fixes after modifier changes
  • Add stubs for Language and RunLoop platform methods
23:02 Changeset [106090] by kevino@webkit.org
  • 7 edits in trunk/Source/WebKit/wx

[wx] Unreviewed. Build fixes after UndoStep and ChromeClient changes.

22:28 Changeset [106089] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectation change.
fast/canvas/quadraticCurveTo.xml fails for WIN GPU

  • platform/chromium/test_expectations.txt:
21:17 Changeset [106088] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectation change.
fast/js/dfg-double-vote-fuzz.html is slow on Mac 10.6 (dbg).

  • platform/chromium/test_expectations.txt:
21:07 Changeset [106087] by commit-queue@webkit.org
  • 11 edits
    2 deletes in trunk

Unreviewed, rolling out r105486.
http://trac.webkit.org/changeset/105486
https://bugs.webkit.org/show_bug.cgi?id=77182

This patch doesn't take web workers into account. (Requested
by dave_levin on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-26

Source/WebCore:

  • html/DOMURL.cpp:

(WebCore::DOMURL::DOMURL):
(WebCore::DOMURL::~DOMURL):
(WebCore::DOMURL::contextDestroyed):
(WebCore):
(WebCore::DOMURL::createObjectURL):
(WebCore::DOMURL::revokeObjectURL):

  • html/DOMURL.h:

(WebCore::DOMURL::create):
(DOMURL):

  • html/DOMURL.idl:
  • page/DOMWindow.cpp:

(WebCore):
(WebCore::DOMWindow::webkitURL):

  • page/DOMWindow.h:

(DOMWindow):
():

  • page/DOMWindow.idl:
  • workers/WorkerContext.cpp:

(WebCore):
(WebCore::WorkerContext::webkitURL):
(WebCore::WorkerContext::webkitRequestFileSystem):

  • workers/WorkerContext.h:

(WorkerContext):
():

  • workers/WorkerContext.idl:

LayoutTests:

  • fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt: Removed.
  • fast/dom/DOMURL/check-instanceof-domurl-functions.html: Removed.
21:03 Changeset [106086] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

Cleanup JPEGImageDecoder includes
https://bugs.webkit.org/show_bug.cgi?id=77171

Reviewed by Adam Barth.

No new tests. Refactoring cleanup only.

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
21:02 Changeset [106085] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed test expectation change.
svg/as-object/nested-embedded-svg-size-changes.html times out or passes.

  • platform/chromium/test_expectations.txt:
20:48 Changeset [106084] by tkent@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

[Chromium] Cleanup of WebPopupMenuImpl
https://bugs.webkit.org/show_bug.cgi?id=76441

Reviewed by Kentaro Hara.

Removed WebPopupMenuImpl::invalidateContents() and scrollRectIntoView()
because they were removed from HostWindow in r58445 and r55864. They
were found by OVERRIDE.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::popupOpened): Rename WebPopupMenuImpl::Init().

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::WebPopupMenuImpl): Update a comment.
(WebKit::WebPopupMenuImpl::init): Renamed from Init(). Update a comment.
(WebKit::WebPopupMenuImpl::handleMouseMove): Prepend "handle" to the name.
(WebKit::WebPopupMenuImpl::handleMouseLeave): ditto.
(WebKit::WebPopupMenuImpl::handleMouseDown): ditto.
(WebKit::WebPopupMenuImpl::handleMouseUp): ditto.
(WebKit::WebPopupMenuImpl::handleMouseWheel): ditto.
(WebKit::WebPopupMenuImpl::handleGestureEvent): ditto.
(WebKit::WebPopupMenuImpl::handleTouchEvent): ditto.
(WebKit::WebPopupMenuImpl::handleKeyEvent): ditto.
(WebKit::WebPopupMenuImpl::close): Update a comment.
(WebKit::WebPopupMenuImpl::composite): Remove a unused argument name.
(WebKit::WebPopupMenuImpl::handleInputEvent): Update a comment. Update callsites for handle*().
(WebKit::WebPopupMenuImpl::setFocus): Remove a unused argument name.
(WebKit::WebPopupMenuImpl::setComposition): ditto.
(WebKit::WebPopupMenuImpl::confirmComposition): ditto.
(WebKit::WebPopupMenuImpl::setTextDirection): ditto.
(WebKit::WebPopupMenuImpl::scroll): Unfold folded lines.

  • src/WebPopupMenuImpl.h:
    • Remove useless argument names.
    • Add OVERRIDE.
20:43 Changeset [106083] by timothy_horton@apple.com
  • 8 edits in trunk/Source

3D transformed elements hide when showing the print dialog
https://bugs.webkit.org/show_bug.cgi?id=45894
<rdar://problem/7441593>

Reviewed by Andy Estes.

Suspend updates of the compositing layer tree while printing is taking place,
preventing on-screen layers from moving to their print-mode positions.

No new tests, as WebKitTestRunner doesn't support putting the document
into printing mode.

  • page/FrameView.cpp:

(WebCore::FrameView::syncCompositingStateForThisFrame):
(WebCore::FrameView::paintContents):

  • platform/graphics/ca/LayerFlushScheduler.h:

(WebCore::LayerFlushScheduler::isSuspended): Added.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::beginPrinting):
(WebKit::WebPage::endPrinting):

  • WebProcess/WebPage/ca/LayerTreeHostCA.h:
  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h:
  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:

(WebKit::LayerTreeHostCAMac::forceRepaint):
(WebKit::LayerTreeHostCAMac::flushPendingLayerChanges):

20:10 Changeset [106082] by fpizlo@apple.com
  • 2 edits in trunk/Tools

Tools/Scripts/commit-log-editor is broken due to $_ getting clobbered
https://bugs.webkit.org/show_bug.cgi?id=77177

Reviewed by Jon Honeycutt.

  • Scripts/commit-log-editor:
19:45 Changeset [106081] by fpizlo@apple.com
  • 3 edits in trunk/LayoutTests

fast/js/dfg-byte-array-put.html should assert the array size
https://bugs.webkit.org/show_bug.cgi?id=77173

Reviewed by Andy Estes.

  • fast/js/dfg-byte-array-put-expected.txt:
  • fast/js/script-tests/dfg-byte-array-put.js:
19:34 Changeset [106080] by yuzo@google.com
  • 1 edit
    1 add in trunk/LayoutTests

[Chromium] Unreviewed test expectation change.

  • platform/chromium/fast/js/dfg-inline-arguments-use-from-all-the-places-broken-expected.txt: Added.
18:48 Changeset [106079] by ojan@chromium.org
  • 2 edits in trunk/Tools

Decrease sleep time when killing server_process on Mac.
https://bugs.webkit.org/show_bug.cgi?id=77169

Reviewed by Eric Seidel.

This shaves another ~70ms off single test runtime.

  • Scripts/webkitpy/layout_tests/port/server_process.py:

(ServerProcess.stop):

18:30 Changeset [106078] by mhahnenberg@apple.com
  • 14 edits
    2 deletes in trunk/Source/JavaScriptCore

Merge AllocationSpace into MarkedSpace
https://bugs.webkit.org/show_bug.cgi?id=77116

Reviewed by Geoffrey Garen.

Merging AllocationSpace and MarkedSpace in preparation for future refactoring/enhancement to
MarkedSpace allocation.

(BumpSpace):

  • heap/Heap.h:

(JSC::Heap::objectSpace):
(Heap):
():

  • heap/HeapBlock.h:

():

  • heap/MarkedSpace.cpp:

(JSC::MarkedSpace::tryAllocateHelper):
(JSC):
(JSC::MarkedSpace::tryAllocate):
(JSC::MarkedSpace::allocateSlowCase):
(JSC::MarkedSpace::allocateBlock):
(JSC::MarkedSpace::freeBlocks):
(TakeIfUnmarked):
(JSC::TakeIfUnmarked::TakeIfUnmarked):
(JSC::TakeIfUnmarked::operator()):
(JSC::TakeIfUnmarked::returnValue):
(JSC::MarkedSpace::shrink):
(GatherDirtyCells):
(JSC::GatherDirtyCells::returnValue):
(JSC::GatherDirtyCells::GatherDirtyCells):
(JSC::GatherDirtyCells::operator()):
(JSC::MarkedSpace::gatherDirtyCells):

  • heap/MarkedSpace.h:

(MarkedSpace):
(JSC::MarkedSpace::blocks):
(JSC::MarkedSpace::forEachCell):
(JSC):
(JSC::MarkedSpace::allocate):

18:25 Changeset [106077] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Fix bad code generated by the JSC idl code generator for [CachedAttribute] attributes
https://bugs.webkit.org/show_bug.cgi?id=77165

Patch by Pablo Flouret <pablof@motorola.com> on 2012-01-26
Reviewed by Oliver Hunt.

Missing parameter in a call to deserialize() and using 'this' in the
attribute accessor functions (which are static).

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
(NativeToJSValue):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjCachedAttribute1):
(WebCore::jsTestObjCachedAttribute2):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::jsTestSerializedScriptValueInterfaceValue):

18:11 Changeset [106076] by wjmaclean@chromium.org
  • 7 edits in trunk/Source

Source/WebCore: [chromium] Allow modification of size of partially occluded quads during culling to reduce pixel overdraw.
https://bugs.webkit.org/show_bug.cgi?id=76349

Reviewed by James Robinson.

Prior to this patch, draw culling either rejects a DrawQuad because it is completely
occluded, or draws the entire quad (even if it is largely occluded). This patch
attempts to reduce the number of pixels drawn by determining if a partially
occluded DrawQuad can be resized to a smaller quad, based on what portion of the
DrawQuad is actually visible, and performing that resizing where possible.

Added cases to existing unit tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawTileQuad):

  • platform/graphics/chromium/cc/CCDrawQuad.cpp:

(WebCore::CCDrawQuad::CCDrawQuad):

  • platform/graphics/chromium/cc/CCDrawQuad.h:

(WebCore::CCDrawQuad::setQuadVisibleRect):
(WebCore::CCDrawQuad::quadVisibleRect):

  • platform/graphics/chromium/cc/CCQuadCuller.cpp:

(WebCore::rectSubtractRegion):
(WebCore::CCQuadCuller::cullOccludedQuads):

Source/WebKit/chromium: [chromium] Allow modification of size of partially occluded quads.
https://bugs.webkit.org/show_bug.cgi?id=76349

Reviewed by James Robinson.

  • tests/CCQuadCullerTest.cpp:

(WebCore::makeTileQuads)
(WebCore::setQuads):
(WebCore::TEST):

18:10 Changeset [106075] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2012-01-26 Oliver Hunt <oliver@apple.com>

MSVC bug fix.
<rdar://problem/10703671> MSVC generates bad code for enum compare.

RS=Geoff

Make bitfield large enough to work around MSVC's desire to make enums
signed types.

  • bytecode/CallLinkInfo.h: (CallLinkInfo):
18:09 Changeset [106074] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Revert changes which added setResourceUsageCHROMIUM gl extension since feature changed directions
https://bugs.webkit.org/show_bug.cgi?id=77120

Patch by Michal Mocny <mmocny@google.com> on 2012-01-26
Reviewed by Kenneth Russell.

  • public/platform/WebGraphicsContext3D.h:

(WebGraphicsContext3D):

  • src/GraphicsContext3DChromium.cpp:

(WebCore):

  • tests/FakeWebGraphicsContext3D.h:

(WebKit::FakeWebGraphicsContext3D::setVisibilityCHROMIUM):

18:01 Changeset [106073] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Scrollbars disappear when switching from legacy to overlay scrollbars
https://bugs.webkit.org/show_bug.cgi?id=77166

Reviewed by Dan Bernstein.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::scrollbarStyleChanged):
Call positionScrollbarLayers to make sure that the new scrollbar layers are positioned correctly.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::updateScrollerStyle):
Call ScrollbarThemeMac::setNewPainterForScrollbar after making the call to the scrollbar painter controller
to set the horizontal or vertical imp, since setting the imp will reset the knob style.

17:55 Changeset [106072] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

NULL ptr in WebCore::ContainerNode::parserAddChild
https://bugs.webkit.org/show_bug.cgi?id=76258

Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/parser/nested-fragment-parser-crash.html

We always need a parent element to attach to. In crazy cases, we can
have elements in the stack of open elements that are already detached
from the DOM. In those cases, they don't have a parent, so we aren't
able to enforce the maximum DOM depth. (Fortunately, they're not
attached to the DOM anymore so we don't need to enforce the maximum DOM
depth!)

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::attachLater):
(WebCore::HTMLConstructionSite::fosterParent):

LayoutTests:

This crazy test case causes the parser to do all manner of crazy
things, which is good times for testing.

  • fast/parser/nested-fragment-parser-crash-expected.txt: Added.
  • fast/parser/nested-fragment-parser-crash.html: Added.
17:35 Changeset [106071] by mhahnenberg@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/JavaScriptCore

2012-01-26 Mark Hahnenberg <mhahnenberg@apple.com>

Hang in parallel GC caused by incorrect GCC asm codegen
Reviewed by Filip Pizlo.

<rdar://problem/10742649>

  • wtf/Atomics.h: (WTF::weakCompareAndSwap): Mark the argument volatile to force GCC to do the right thing.
17:30 Changeset [106070] by mrowe@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebKit2

Merge r102507.

17:30 Changeset [106069] by mrowe@apple.com
  • 4 edits in branches/safari-534.54-branch/Source/WebKit2

Merge r102504.

17:30 Changeset [106068] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-534.54-branch/Source/WebKit2

Merge r102497.

17:15 Changeset [106067] by fpizlo@apple.com
  • 24 edits
    14 adds in trunk

All DFG helpers that may call out to arbitrary JS code must know where they
were called from due to inlining and call stack walking
https://bugs.webkit.org/show_bug.cgi?id=77070
<rdar://problem/10750834>

Source/JavaScriptCore:

Reviewed by Geoff Garen.

Changed the DFG to always record a code origin index in the tag of the argument
count (which we previously left blank for the benefit of LLInt, but is still
otherwise unused by the DFG), so that if we ever need to walk the stack accurately
we know where to start. In particular, if the current ExecState* points several
semantic call frames away from the true semantic call frame because we had
performed inlining, having the code origin index recorded means that we can reify
those call frames as necessary to give runtime/library code an accurate view of
the current JS state.

This required several large but mechanical changes:

  • Calling a function from the DFG now plants a store32 instruction to store the code origin index. But the indices of code origins were previously picked by the DFG::JITCompiler after code generation completed. I changed this somewhat; even though the code origins are put into the CodeBlock after code gen, the code gen now knows a priori what their indices will be. Extensive assertions are in place to ensure that the two don't get out of sync, in the form of the DFG::CallBeginToken. Note that this mechanism has almost no effect on JS calls; those don't need the code origin index set in the call frame because we can get it by doing a binary search on the return PC.
  • Stack walking now always calls trueCallFrame() first before beginning the walk, since even the top call frame may be wrong. It still calls trueCallerFrame() as before to get to the next frame, though trueCallerFrame() is now mostly a wrapper around callerFrame()->trueCallFrame().


  • Because the mechanism for getting the code origin of a call frame is bimodal (either the call frame knows its code origin because the code origin index was set, or it's necessary to use the callee frame's return PC), I put in extra mechanisms to determine whether your caller, or your callee, corresponds to a call out of C++ code. Previously we just had the host call flag, but this is insufficient as it does not cover the case of someone calling JSC::call(). But luckily we can determine this just by looking at the return PC: if the return PC is in range of the ctiTrampiline, then two things are true: this call frame's PC will tell you nothing about where you came from in your caller, and the caller already knows where it's at because it must have set the code origin index (unless it's not DFG code, in which case we don't care because there is no inlining to worry about).


  • During testing this revealed a simple off-by-one goof in DFG::ByteCodeParser's inlining code, so I fixed it.
  • Finally because I was tired of doing random #if's for checking if I should be passing around an Instruction* or a ReturnAddressPtr, I created a class called AbstractPC that holds whatever notion of a PC is appropriate for the current execution environment. It's designed to work gracefully even if both the interpreter and the JIT are compiled in, and should integrate nicely with the LLInt.


This is neutral on all benchmarks and fixes some nasty corner-case regressions of
evil code that uses combinations of getters/setters and function.arguments.

(JSC::CodeBlock::codeOrigin):
(CodeBlock):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleInlining):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • dfg/DFGJITCompiler.h:

(CallBeginToken):
(JSC::DFG::CallBeginToken::CallBeginToken):
(JSC::DFG::CallBeginToken::assertCodeOriginIndex):
(JSC::DFG::CallBeginToken::assertNoCodeOriginIndex):
(DFG):
(JSC::DFG::CallExceptionRecord::CallExceptionRecord):
(CallExceptionRecord):
(JSC::DFG::JITCompiler::JITCompiler):
(JITCompiler):
(JSC::DFG::JITCompiler::nextCallBeginToken):
(JSC::DFG::JITCompiler::beginCall):
(JSC::DFG::JITCompiler::notifyCall):
(JSC::DFG::JITCompiler::addExceptionCheck):
(JSC::DFG::JITCompiler::addFastExceptionCheck):

  • dfg/DFGOperations.cpp:

():

  • dfg/DFGRepatch.cpp:

(JSC::DFG::tryBuildGetByIDList):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheck):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

  • interpreter/AbstractPC.cpp: Added.

(JSC):
(JSC::AbstractPC::AbstractPC):

  • interpreter/AbstractPC.h: Added.

(JSC):
(AbstractPC):
(JSC::AbstractPC::AbstractPC):
(JSC::AbstractPC::hasJITReturnAddress):
(JSC::AbstractPC::jitReturnAddress):
(JSC::AbstractPC::hasInterpreterReturnAddress):
(JSC::AbstractPC::interpreterReturnAddress):
(JSC::AbstractPC::isSet):
(JSC::AbstractPC::operator!):
():

  • interpreter/CallFrame.cpp:

(JSC):
(JSC::CallFrame::trueCallFrame):
(JSC::CallFrame::trueCallerFrame):

  • interpreter/CallFrame.h:

(JSC::ExecState::abstractReturnPC):
(JSC::ExecState::codeOriginIndexForDFGWithInlining):
(ExecState):
(JSC::ExecState::trueCallFrame):
(JSC::ExecState::trueCallFrameFromVMCode):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::retrieveArgumentsFromVMCode):
(JSC::Interpreter::retrieveCallerFromVMCode):
(JSC::Interpreter::findFunctionCallFrameFromVMCode):

  • interpreter/Interpreter.h:

(Interpreter):
():

  • jit/JITStubs.cpp:

(JSC):
():

  • jit/JITStubs.h:

(JSC):
(JSC::returnAddressIsInCtiTrampoline):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::argumentsGetter):
(JSC::JSFunction::callerGetter):
(JSC::JSFunction::getOwnPropertyDescriptor):

LayoutTests:

Reviewed by Geoff Garen.

  • fast/js/dfg-inline-arguments-use-directly-from-inlined-code-expected.txt: Added.
  • fast/js/dfg-inline-arguments-use-directly-from-inlined-code.html: Added.
  • fast/js/dfg-inline-arguments-use-from-all-the-places-broken-expected.txt: Added.
  • fast/js/dfg-inline-arguments-use-from-all-the-places-broken.html: Added.
  • fast/js/dfg-inline-arguments-use-from-all-the-places-expected.txt: Added.
  • fast/js/dfg-inline-arguments-use-from-all-the-places.html: Added.
  • fast/js/dfg-inline-arguments-use-from-getter-expected.txt: Added.
  • fast/js/dfg-inline-arguments-use-from-getter.html: Added.
  • fast/js/script-tests/dfg-inline-arguments-use-directly-from-inlined-code.js: Added.

(foo):
(bar):
(argsToStr):

  • fast/js/script-tests/dfg-inline-arguments-use-from-all-the-places-broken.js: Added.

(foo):
(fuzz):
(getter):
(bar):
(argsToStr):

  • fast/js/script-tests/dfg-inline-arguments-use-from-all-the-places.js: Added.

(foo):
(fuzz):
(getter):
(bar):
(argsToStr):

  • fast/js/script-tests/dfg-inline-arguments-use-from-getter.js: Added.

(foo):
(bar):
(argsToStr):

17:14 Changeset [106066] by ojan@chromium.org
  • 2 edits in trunk/Tools

Remove builder name so http://trac.webkit.org/changeset/106035 actually works.
https://bugs.webkit.org/show_bug.cgi?id=77164

Reviewed by Dirk Pranke.

http://trac.webkit.org/changeset/106035 depends on builder_name being
falsey by default. There's other code that requires it to be iterable
by default. So, make it be the empty string.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

17:08 Changeset [106065] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Chromium]: svg/W3C-SVG-1.1/text-text-03-b.svg is marked as flakey, when it isn't
https://bugs.webkit.org/show_bug.cgi?id=77157

Unreviewed Chromium expectations update to remove a no-longer-flakey test.

Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-26

  • platform/chromium/test_expectations.txt: Removed svg/W3C-SVG-1.1/text-text-03-b.svg
16:54 Changeset [106064] by cdn@chromium.org
  • 2 edits in trunk/Source/WebCore

The registration of schemes is currently racey as they are not registered from the main thread.
Getting rid of the assert that ensures that we are registering from the main thread until we can fix this.

Thank you ap@webkit for helping us identify this.

https://bugs.webkit.org/show_bug.cgi?id=77160

Reviewed by Adam Barth.

  • platform/SchemeRegistry.cpp:

(WebCore::CORSEnabledSchemes):

16:42 Changeset [106063] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

Add GestureTapDown and GestureDoubleTap gesture types to WebGestureEvent.
https://bugs.webkit.org/show_bug.cgi?id=77140

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-01-26
Reviewed by Darin Fisher.

  • public/WebInputEvent.h:

():

  • src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleInputEvent):

16:37 Changeset [106062] by rniwa@webkit.org
  • 3 edits in trunk/Tools

run-perf-test should include relative file paths in test names
https://bugs.webkit.org/show_bug.cgi?id=77144

Reviewed by Adam Birth.

Include all directory names in the test name separated by "/".
e.g. Bindings/event-target-wrapper.html translates to Bindings/event-target-wrapper

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner):
(PerfTestsRunner._process_parser_test_result):

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(test_run_test_set_with_json_output):
(test_run_test_set_with_json_source):

16:31 Changeset [106061] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

We don't need to always repaint overlay scrollbars if they're in layers
https://bugs.webkit.org/show_bug.cgi?id=77159

Reviewed by Beth Dakin.

If a scrollable area has overlay scrollbars we'll always invalidate both scrollbars, regardless of
whether both scroll offsets actually change since they're translucent and we want to draw the new page
contents underneath.

However, if the scrollbars are painted into GraphicsLayers they'll be composited by the GPU, and so we don't
need to repaint them unless the corresponding scroll offset actually changes (which is handled in Scrollbar::updateThumb).

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::setScrollOffsetFromAnimation):

16:16 Changeset [106060] by dpranke@chromium.org
  • 3 edits
    5 deletes in trunk/Tools

webkitpy: re-land cleanup of test scaffolding
https://bugs.webkit.org/show_bug.cgi?id=77153

Reviewed by Eric Seidel.

This is an attempt to reland the change in bug 76973 /
r105935. My earlier attempt to manipulate PYTHONPATH
seems to only work some of the time, for reasons that
elude me. Directly adding Tools/Scripts to sys.path from
inside the test script appears to work (more?) reliably.

Also, it seemed like the files didn't actually get deleted
the last time; I don't know why.

  • Scripts/test-webkitpy:
  • Scripts/webkitpy/common/system/executive_unittest.py:

(command_line):
(ExecutiveTest):
(ExecutiveTest.test_run_command_args_type):
(ExecutiveTest.test_run_command_with_unicode):
(ExecutiveTest.test_running_pids):
(main):

  • Scripts/webkitpy/common/system/fileutils.py: Removed.
  • Scripts/webkitpy/test/cat.py: Removed.
  • Scripts/webkitpy/test/cat_unittest.py: Removed.
  • Scripts/webkitpy/test/echo.py: Removed.
  • Scripts/webkitpy/test/echo_unittest.py: Removed.
16:07 Changeset [106059] by jsbell@chromium.org
  • 2 edits in trunk/Source/WebCore

IndexedDB: WebCore::IDBKey objects are leaked
https://bugs.webkit.org/show_bug.cgi?id=77114

Reviewed by Tony Chang.

Fixing memory leaks, no new tests.

  • storage/IDBKey.h:

(WebCore::IDBKey::createInvalid):
(WebCore::IDBKey::createNumber):
(WebCore::IDBKey::createString):
(WebCore::IDBKey::createDate):
(WebCore::IDBKey::createArray):

16:03 Changeset [106058] by ojan@chromium.org
  • 5 edits in trunk/Tools

run-webkit-tests calls "nm" when it doesn't need to
https://bugs.webkit.org/show_bug.cgi?id=77143

Reviewed by Dirk Pranke.

If we are not running any test that can be skipped by checking
the DRT feature list or looking at the list of symbols, avoid calling
out to DRT or calling "nm".

This saves ~700ms on my Mac Pro. In cases where you still have to call out
to "nm" it's only a couple ms slower.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations.init):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.skipped_tests):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._should_check_for_missing_features):
(WebKitPort):
(WebKitPort._should_check_for_missing_symbols):
(WebKitPort._skipped_tests_for_unsupported_features):
(WebKitPort.skipped_layout_tests):
(WebKitPort.skipped_tests):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(WebKitPortTest.test_skipped_directories_for_symbols):
(test_skipped_directories_for_features):
(test_skipped_directories_for_features_no_matching_tests_in_test_list):
(test_skipped_layout_tests):

15:50 Changeset [106057] by cdn@chromium.org
  • 7 edits in trunk/Source

Source/WebCore: Add a scheme registry for CORS requests. Allow simple CORS requests to be made to registered schemes.
https://bugs.webkit.org/show_bug.cgi?id=77041

Reviewed by Alexey Proskuryakov.

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):

  • platform/SchemeRegistry.cpp:

(WebCore::CORSEnabledSchemes):
(WebCore):
(WebCore::SchemeRegistry::registerCORSEnabledScheme):
(WebCore::SchemeRegistry::isCORSEnabledScheme):

  • platform/SchemeRegistry.h:

(SchemeRegistry):

Source/WebKit/chromium: Add API to register schemes which can be sent simple CORS requests.
https://bugs.webkit.org/show_bug.cgi?id=77041

Reviewed by Alexey Proskuryakov.

  • public/WebSecurityPolicy.h:

(WebSecurityPolicy):

  • src/WebSecurityPolicy.cpp:

(WebKit::WebSecurityPolicy::registerCORSEnabledScheme):
(WebKit):

15:48 Changeset [106056] by leviw@chromium.org
  • 4 edits
    5 adds
    1 delete in trunk/LayoutTests

compositing/shadows/shadow-drawing.html and svg/css/group-with-shadow.svg are failing on Chromium Win
https://bugs.webkit.org/show_bug.cgi?id=77151

Unreviewed gardening. Rebaselining expectations for the above tests on Chromium-Windows and re-enabling them.

  • platform/chromium-win-vista/compositing/shadows: Added.
  • platform/chromium-win-vista/compositing/shadows/shadow-drawing-expected.png: Added.
  • platform/chromium-win-vista/svg/css/group-with-shadow-expected.png: Added.
  • platform/chromium-win-xp/compositing/shadows: Added.
  • platform/chromium-win-xp/compositing/shadows/shadow-drawing-expected.png: Added.
  • platform/chromium-win-xp/svg/css: Removed.
  • platform/chromium-win/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-win/svg/css/group-with-shadow-expected.png:
  • platform/chromium/test_expectations.txt:
15:44 Changeset [106055] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

File extension for webp files is .webp
https://bugs.webkit.org/show_bug.cgi?id=76982

Reviewed by Adam Barth.

No new tests. No change in behavior.

  • platform/image-decoders/webp/WEBPImageDecoder.h:

(WebCore::WEBPImageDecoder::filenameExtension):

15:29 Changeset [106054] by commit-queue@webkit.org
  • 5 edits in trunk/Tools

Support a suffix on ChangeLog filenames based on a configuration file
https://bugs.webkit.org/show_bug.cgi?id=76956

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-01-26
Reviewed by Kentaro Hara.

Modify the tools used to generate, edit and resolve ChangeLogs to support
the addition of a suffix to the ChangeLog filename.

This patch makes it easier to support alternate ChangeLog files in branches.

  • Scripts/VCSUtils.pm:

(changeLogSuffix):
(changeLogFileName):

  • Scripts/commit-log-editor:
  • Scripts/prepare-ChangeLog:

(getLatestChangeLogs):
(generateNewChangeLogs):
(generateFileList):

  • Scripts/resolve-ChangeLogs:

(findChangeLog):

15:25 Changeset [106053] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

compositing/shadows/shadow-drawing.html and svg/css/group-with-shadow.svg are failing on Chromium Win
https://bugs.webkit.org/show_bug.cgi?id=77151

Unreviewed gardening. Marking the above 2 tests as flaky on Chromium Windows until
I can root cause the change.

  • platform/chromium/test_expectations.txt:
15:13 Changeset [106052] by alokp@chromium.org
  • 4 edits in trunk/Source/WebCore

[chromium] Remove dead and unnecessary code related to LayerChromium::cleanupResources
https://bugs.webkit.org/show_bug.cgi?id=77137

Reviewed by James Robinson.

No new test needed. Only removing dead code.

  • platform/graphics/chromium/LayerChromium.cpp:
  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::layerTreeHost):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::setLayerTreeHost):

15:06 Changeset [106051] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

Move horizontal rubber-band checks to ScrollElasticityController::handleWheelEvent
https://bugs.webkit.org/show_bug.cgi?id=77147

Reviewed by Adam Roben.

  • platform/mac/ScrollAnimatorMac.h:

(ScrollAnimatorMac):

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::handleWheelEvent):
Always call ScrollElasticityController::handleWheelEvent, and only call didBeginScrollGesture and
didEndScrollGesture if the event was actually handled.

(WebCore::ScrollAnimatorMac::shouldRubberBandInDirection):
Implement this.

  • platform/mac/ScrollElasticityController.h:
  • platform/mac/ScrollElasticityController.mm:

(WebCore::ScrollElasticityController::handleWheelEvent):
Check if we should rubber-band and return false if we shouldn't.

(WebCore::ScrollElasticityController::shouldRubberBandInHorizontalDirection):
Ask the client if we should rubber-band.

14:58 Changeset [106050] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Unreviewed, rolling out r106038.
http://trac.webkit.org/changeset/106038
https://bugs.webkit.org/show_bug.cgi?id=77142

Caused a bunch of skipped tests to not be skipped. (Requested
by ojan on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-26

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationParser):
(TestExpectationParser.parse):
(TestExpectationParser._parse_line):
(TestExpectationParser._collect_matching_tests):
(TestExpectations.init):
(TestExpectations._add_skipped_tests):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.test_dirs):
(Port.normalize_test_name):
(Port.update_baseline):
(Port.layout_tests_dir):
(Port.relative_perf_test_filename):
(Port.abspath_for_test):

14:55 Changeset [106049] by pvarga@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix build when VERBOSE_SPECULATION_FAILURE is enabled in DFG
https://bugs.webkit.org/show_bug.cgi?id=77104

Reviewed by Filip Pizlo.

  • dfg/DFGOperations.cpp:

():

14:46 Changeset [106048] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] Remove setLayerTreeHost nonsense on lost context
https://bugs.webkit.org/show_bug.cgi?id=76675

Reviewed by Kenneth Russell.

This code isn't needed any more. On a lost context event, we drop all TextureManager-managed textures through
the proxy and no layer types need special lost context handling.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::didRecreateGraphicsContext):

14:33 Changeset [106047] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test fast/workers/storage/interrupt-database.html is a flaky crasher on Debug Chromium Bots
https://bugs.webkit.org/show_bug.cgi?id=77136

Unreviewed gardening. Marking fast/workers/storage/interrupt-database.html as a flaky
crasher on debug Chromium bots.

  • platform/chromium/test_expectations.txt:
14:33 Changeset [106046] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Simplify checking of whether we should rubberband horizontally
https://bugs.webkit.org/show_bug.cgi?id=77141

Reviewed by Adam Roben.

Have a single check for horizontal rubber-banding in both directions. This is in preparation
for moving this code into ScrollElasticityController.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::shouldRubberBandInHorizontalDirection):
(WebCore::ScrollAnimatorMac::handleWheelEvent):

14:26 Changeset [106045] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix include path in gyp file for V8InternalSettings.h
https://bugs.webkit.org/show_bug.cgi?id=77128

Patch by Scott Graham <scottmg@chomium.org> on 2012-01-26
Reviewed by Kent Tamura.

  • WebCore.gyp/WebCore.gyp:
14:26 Changeset [106044] by jamesr@google.com
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Add enter/exitRunLoop to WebThread API
https://bugs.webkit.org/show_bug.cgi?id=76012

Reviewed by Darin Fisher.

This adds those two APIs to WebKit::WebThread and converts CCLayerTreeHostTest over to use these APIs instead
of webkit_support. The immediate motivation is that we can't use webkit_support in webkit_unit_tests in the
component build.

  • WebKit.gyp:
  • public/platform/WebThread.h:
  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::onEndTest):
(WTF::CCLayerTreeHostTest::TimeoutTask::run):
(WTF::CCLayerTreeHostTest::BeginTask::BeginTask):
(WTF::CCLayerTreeHostTest::BeginTask::~BeginTask):
(WTF::CCLayerTreeHostTest::BeginTask::run):
(WTF::CCLayerTreeHostTest::runTest):

14:24 Changeset [106043] by jamesr@google.com
  • 34 edits
    1 delete in trunk

We shouldn't synchronously update styles on all documents after running script
https://bugs.webkit.org/show_bug.cgi?id=46761

Reviewed by Simon Fraser.

Currently we call Document::updateStyleForAllDocuments() after invoking any event or timeout handler. This is
slow since it iterates over the entire document tree and defeats our recalcStyle timer batching. It is
unnecessary as any code that depends on styles or the render tree being up to date must call
updateStyleIfNeeded() on the document it is accessing.

The first reference I can find to this code is in r798 in the file WebCore/khtml/xml/domnode_impl.cpp. It's been
cargo culted forward ever since.

  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::executeScript):

  • bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::ScriptController):
(WebCore::ScriptController::executeScriptInWorld):

  • bindings/js/ScriptController.h:
  • bindings/v8/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::ScriptController):

  • bindings/v8/ScriptController.h:
  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::executeScript):

  • inspector/InspectorClient.cpp:

(WebCore::InspectorClient::doDispatchMessageOnFrontendPage):

14:21 Changeset [106042] by inferno@chromium.org
  • 1 edit in branches/chromium/963/Source/WebCore/rendering/svg/RenderSVGResource.cpp

Merge 105985 - 2012-01-26 Nikolas Zimmermann <nzimmermann@rim.com>
BUG=99615
Review URL: https://chromiumcodereview.appspot.com/9288080

14:18 Changeset [106041] by inferno@chromium.org
  • 4 edits in branches/chromium/963/Source/WebCore/rendering/svg

Merge 105986 - 2012-01-26 Nikolas Zimmermann <nzimmermann@rim.com>
Needed to fix windows builds.
BUG=99615
Review URL: https://chromiumcodereview.appspot.com/9235073

14:10 Changeset [106040] by commit-queue@webkit.org
  • 5 edits in trunk/LayoutTests

Unreviewed, rolling out r106027.
http://trac.webkit.org/changeset/106027
https://bugs.webkit.org/show_bug.cgi?id=77139

"It messed up Qt5 buildbots." (Requested by jeez_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-26

  • platform/qt-4.8/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/qt/Skipped:
14:10 Changeset [106039] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Get rid of ScrollElasticityController::beginScrollGesture()
https://bugs.webkit.org/show_bug.cgi?id=77138

Reviewed by Adam Roben.

ScrollElasticityController::handleWheelEvent now checks if the wheel event phase is
PlatformWheelEventPhaseBegan and sets up the gesture state if it is.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::handleWheelEvent):

  • platform/mac/ScrollElasticityController.h:

(ScrollElasticityController):

  • platform/mac/ScrollElasticityController.mm:

(WebCore::ScrollElasticityController::handleWheelEvent):

13:46 Changeset [106038] by ojan@chromium.org
  • 3 edits in trunk/Tools

Parsing test_expecations.txt + Skipped lists takes too long
https://bugs.webkit.org/show_bug.cgi?id=77059

Reviewed by Dirk Pranke.

This saves ~100ms on the Apple Mac port.
-memoize a bunch of path methods.
-Avoid doing multiple disk accesses per line.
-Parse the skipped list directly instead of turning it into a test_expecations.txt
formatting string and parsing that.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationParser):
(TestExpectationParser.parse_skipped_tests):
(TestExpectationParser._parse_line):
(TestExpectationParser._collect_matching_tests):
(TestExpectations.init):
(TestExpectations._add_skipped_tests):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port):
(Port.test_isfile):
(Port.normalize_test_name):
(Port.layout_tests_dir):
(Port.abspath_for_test):

13:38 Changeset [106037] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Get rid of ScrollElasticityController::endScrollGesture()
https://bugs.webkit.org/show_bug.cgi?id=77134

Reviewed by Adam Roben.

Just make ScrollElasticityController::handleWheelEvent call snapRubberBand if the wheel
event phase is PlatformWheelEventPhaseEnded.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::handleWheelEvent):

  • platform/mac/ScrollElasticityController.h:

(ScrollElasticityController):

  • platform/mac/ScrollElasticityController.mm:

(WebCore::ScrollElasticityController::handleWheelEvent):

13:35 Changeset [106036] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash in SVGSVGElement::currentViewBoxRect.
https://bugs.webkit.org/show_bug.cgi?id=77121

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Symbols shouldn't be rendered. Revert the ASSERT
from r105513 into a hard check.

Test: svg/custom/symbol-viewport-element-crash.svg

  • svg/SVGLengthContext.cpp:

(WebCore::SVGLengthContext::determineViewport):

LayoutTests:

  • svg/custom/symbol-viewport-element-crash-expected.txt: Added.
  • svg/custom/symbol-viewport-element-crash.svg: Added.
13:26 Changeset [106035] by ojan@chromium.org
  • 3 edits in trunk/Tools

Only store the SVN revision in the summarized results if we're on a builder
https://bugs.webkit.org/show_bug.cgi?id=76976

Reviewed by Dirk Pranke.

This shaves another ~130ms off the single test run-webkit-tests runtime.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(summarize_results):

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ResultSummaryTest.get_result):
(ResultSummaryTest):
(ResultSummaryTest.get_result_summary):
(ResultSummaryTest.get_unexpected_results):
(ResultSummaryTest.test_no_svn_revision):
(ResultSummaryTest.test_svn_revision):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.use_trac_links_in_results_html):

13:17 Changeset [106034] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll chromium_rev to 119248
https://bugs.webkit.org/show_bug.cgi?id=77124

Patch by John Bates <jbates@google.com> on 2012-01-26
Reviewed by James Robinson.

  • DEPS:
13:08 Changeset [106033] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Inline beginScrollGesture/endScrollGesture in handleWheelEvent
https://bugs.webkit.org/show_bug.cgi?id=77133

Reviewed by Andreas Kling.

  • platform/mac/ScrollAnimatorMac.h:

(ScrollAnimatorMac):

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::handleWheelEvent):

12:56 Changeset [106032] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

No need to set m_haveScrolledSincePageLoad in beginScrollGesture
https://bugs.webkit.org/show_bug.cgi?id=77132

Reviewed by Andreas Kling.

m_haveScrolledSincePageLoad is already set to true in handleWheelEvent so we don't need
to set it to true again.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::beginScrollGesture):

12:46 Changeset [106031] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Simplify checking for whether we should rubberband or not when at the edge
https://bugs.webkit.org/show_bug.cgi?id=77131

Reviewed by Beth Dakin.

We only need to check once if we're pinned at either edge whether we should rubber-band
or not. Do this when the wheel event phase is PlatformWheelEventPhaseBegan. This lets us
remove a bunch of code that would keep track of the current horizontal scroll direction.

  • platform/mac/ScrollAnimatorMac.h:

(ScrollAnimatorMac):

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::handleWheelEvent):
(WebCore::ScrollAnimatorMac::beginScrollGesture):

12:39 Changeset [106030] by efidler@rim.com
  • 8 edits
    2 deletes in trunk

[JSC] Inspector instrumentation for JavaScript calls.
https://bugs.webkit.org/show_bug.cgi?id=40119

Reviewed by Geoffrey Garen.

Source/WebCore:

Covered by existing Chromium inspector tests

  • bindings/js/JSCallbackData.cpp:

(WebCore::JSCallbackData::invokeCallback):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

  • bindings/js/JSMainThreadExecState.h:

(WebCore::JSMainThreadExecState::instrumentedCall):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willCallFunctionImpl):

LayoutTests:

  • inspector/timeline/timeline-injected-script-eval-expected.txt: expectation is now valid cross-platform
  • inspector/timeline/timeline-receive-response-event-expected.txt: ditto
  • platform/chromium/inspector/timeline/timeline-injected-script-eval-expected.txt: Removed.
  • platform/chromium/inspector/timeline/timeline-receive-response-event-expected.txt: Removed.
12:30 Changeset [106029] by vangelis@chromium.org
  • 2 edits in trunk/Source/WebCore

Signal to skia to force A8 text from LCD output, but only when we have to disable LCD because we're in a layer
https://bugs.webkit.org/show_bug.cgi?id=76547

Patch by Mike Reed <reed@google.com> on 2012-01-26
Reviewed by Stephen White.

Existing tests should confirm nothing is broken. Antialiased text
is disabled in layouttests, so they should be unaffected by the
difference in antialiasing quality.

  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::setupPaintForFont):

12:19 Changeset [106028] by commit-queue@webkit.org
  • 4 edits in trunk

[Qt][WK2] fast/loader tests failed after r94178
https://bugs.webkit.org/show_bug.cgi?id=67388

Patch by Luciano Wolf <luciano.wolf@openbossa.org> on 2012-01-26
Reviewed by Simon Hausmann.

Tools:

Applying the same fix used for Qt-WebKit1 from bug #67254 -
[Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
https://bugs.webkit.org/show_bug.cgi?id=67254
Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
derived from the running location of DumpRenderTree binary.

  • WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:

(WTR::LayoutTestController::pathToLocalResource):

LayoutTests:

Removing the following tests from skipped list:
fast/loader/local-CSS-from-local.html
fast/loader/local-JavaScript-from-local.html
fast/loader/local-image-from-local.html

  • platform/qt-wk2/Skipped:
12:15 Changeset [106027] by jesus@webkit.org
  • 5 edits in trunk/LayoutTests

Updating skipped tests after r105997.

Unreviewed gardening.

  • platform/qt-4.8/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/qt/Skipped:
12:13 Changeset [106026] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Use PlatformWheelEvent::phase() to determine if a scroll gesture begins or ends
https://bugs.webkit.org/show_bug.cgi?id=77127

Reviewed by Beth Dakin.

  • platform/mac/ScrollAnimatorMac.h:

(ScrollAnimatorMac):
Remove handleGestureEvent.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::handleWheelEvent):
Look at the event phase to determine when to call didBeginGesture and didEndGesture.

12:09 Changeset [106025] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Using strncmp() for comparing scheme and port numbers is inefficient
https://bugs.webkit.org/show_bug.cgi?id=75821

Reviewed by Darin Adler.

Replace the equal() function comparing 2 arbitrary strings by a template
comparing the string to an array, character by character.

This is only used for small strings: the schemes and the ports.

  • platform/KURL.cpp:

(WebCore::equal):
(WebCore::isDefaultPortForScheme):
(WebCore::isNonFileHierarchicalScheme):
(WebCore::isCanonicalHostnameLowercaseForScheme):

12:02 Changeset [106024] by knorton@google.com
  • 2 edits
    6 adds in trunk/LayoutTests

[chromium] Unreviewed, rebaseline after http://trac.webkit.org/changeset/105613.

  • platform/chromium-linux/svg/custom/relative-sized-image-expected.png: Added.
  • platform/chromium-linux/svg/repaint/image-with-clip-path-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/repaint/image-with-clip-path-expected.png: Added.
  • platform/chromium-win/svg/custom/relative-sized-image-expected.png: Added.
  • platform/chromium-win/svg/custom/relative-sized-image-expected.txt: Added.
  • platform/chromium-win/svg/repaint/image-with-clip-path-expected.png: Added.
  • platform/chromium/test_expectations.txt:
11:56 Changeset [106023] by caio.oliveira@openbossa.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] REGRESSION(102228): lot of test failures after enabled page cache
https://bugs.webkit.org/show_bug.cgi?id=73999

Reviewed by Kenneth Rohde Christiansen.

Those tests were failing because PageCache was enabled for WTR and they depend on
it being disable: they rely on onload being called after navigating back to a page.

WTR should run without PageCache enabled. This was fixed in r106005, so we can
unskip these now.

  • platform/qt-wk2/Skipped:
11:47 Changeset [106022] by abecsi@webkit.org
  • 4 edits in trunk/Source/WebKit2

[Qt][WK2] Add the componentComplete method to WebView
https://bugs.webkit.org/show_bug.cgi?id=77111

Reviewed by Kenneth Rohde Christiansen.

Move the touch/desktop initialization to componentComplete.
Also return valid default values in the viewport info functions
if the interaction engine is not yet initialized because the
viewport info component could finish initialization earlier
than the WebView, which results in QML warnings during MiniBrowser
startup.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::setUseTraditionalDesktopBehaviour):
(QQuickWebView::geometryChanged):
(QQuickWebView::componentComplete):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qwebviewportinfo.cpp:

(QWebViewportInfo::currentScale):
(QWebViewportInfo::devicePixelRatio):
(QWebViewportInfo::initialScale):
(QWebViewportInfo::minimumScale):
(QWebViewportInfo::maximumScale):
(QWebViewportInfo::isScalable):
(QWebViewportInfo::layoutSize):

11:28 Changeset [106021] by andersca@apple.com
  • 6 edits in trunk/Source

WebWheelEvent::Phase and PlatformWheelEvent::Phase declarations should match AppKit
https://bugs.webkit.org/show_bug.cgi?id=77123

Reviewed by Beth Dakin.

Source/WebCore:

  • platform/PlatformWheelEvent.h:

():

  • platform/mac/PlatformEventFactoryMac.mm:

(WebCore::phaseForEvent):

Source/WebKit2:

  • Shared/WebEvent.h:

():

  • Shared/mac/WebEventFactory.mm:

(WebKit::phaseForEvent):

11:26 Changeset [106020] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

String::latin1() should take advantage of 8 bit strings
https://bugs.webkit.org/show_bug.cgi?id=76646

Reviewed by Geoffrey Garen.

  • wtf/text/WTFString.cpp:

(WTF::String::latin1): For 8 bit strings, use existing buffer
without conversion.

11:23 Changeset [106019] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Dromaeo tests usage of StringImpl find routines cause 8->16 bit conversions
https://bugs.webkit.org/show_bug.cgi?id=76645

Reviewed by Geoffrey Garen.

  • wtf/text/StringImpl.cpp:

(WTF::equalIgnoringCase): New LChar version.
(WTF::findInner): New helper function.
(WTF::StringImpl::find): Added 8 bit path.
(WTF::reverseFindInner): New helper funciton.
(WTF::StringImpl::reverseFind): Added 8 bit path.
(WTF::StringImpl::reverseFindIgnoringCase): Added 8 bit path.

  • wtf/text/StringImpl.h:

(WTF):

11:23 Changeset [106018] by dcheng@chromium.org
  • 2 edits in trunk/Source/WebCore

Revert code changes from r105800
https://bugs.webkit.org/show_bug.cgi?id=77071

The strings are already lowercased in EventHandler.cpp:findDropZone() so there's
no need to call lower() again.

Reviewed by Tony Chang.

Covered by existing tests.

  • dom/Clipboard.cpp:

(WebCore::Clipboard::hasDropZoneType):

11:20 Changeset [106017] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

[Chromium]: rebaseline after r105878
https://bugs.webkit.org/show_bug.cgi?id=77017

Unreviewed Chromium expectations update.

Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-26

  • platform/chromium/svg/stroke/zero-length-path-linecap-rendering-expected.txt: Added.
  • platform/chromium/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:18 Changeset [106016] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

REGRESSION (r91125): Polyline tool in google docs is broken
https://bugs.webkit.org/show_bug.cgi?id=65796

Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-26
Reviewed by Nikolas Zimmermann.

It turns out that the CG problem is a design decision. The bounding code
returns CGRectNull for cases where a bound is ill-defined, rather than the
empty bound as expected.

I'm also removing the workaround for isEmpty to get correct zero length paths.
It is no longer necessary.

Tested by existing layout tests.

  • platform/graphics/cg/PathCG.cpp: Removed path empty and path bound testing classes.

(WebCore::Path::boundingRect): Added check for CGRectNull
(WebCore::Path::fastBoundingRect): Added check for CGRectNull
(WebCore::Path::strokeBoundingRect): Added check for CGRectNull
(WebCore::Path::isEmpty): Reverted to former behavior, just using CGPathIsEmpty.
(WebCore::Path::hasCurrentPoint): Reverted to former behavior, using isEmpty.
(WebCore::Path::transform): Reverted to former behavior, using isEmpty.

11:02 Changeset [106015] by kling@webkit.org
  • 13 edits in trunk/Source/WebCore

Refactor application of additional style attributes for table elements.
<http://webkit.org/b/77095>

Reviewed by Darin Adler.

The primary purpose of this change is to reduce usage of CSSMappedAttributeDeclaration.
Instead of using the mapped attribute decl table for additional table style, just use
regular CSSMutableStyleDeclarations. We cache them all globally, except for the style
that's shared between a table's cells. That one is cached per-table since it depends
on the table's border and padding.

  • dom/CSSMappedAttributeDeclaration.cpp:

(WebCore::CSSMappedAttributeDeclaration::~CSSMappedAttributeDeclaration):

  • dom/MappedAttributeEntry.h:

Remove the concept of persistent CSSMappedAttributeDeclarations. The hunk in
~CSSMappedAttributeDeclaration was wildly wrong since it would leave stale pointers
in the decl table, but unreachable since we always leaked one ref to those decls.

  • dom/StyledElement.h:

(WebCore::StyledElement::additionalAttributeStyle):

  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::additionalAttributeStyle):

  • html/HTMLTableCellElement.h:

(HTMLTableCellElement):

  • html/HTMLTableColElement.cpp:

(WebCore::HTMLTableColElement::additionalAttributeStyle):

  • html/HTMLTableColElement.h:

(HTMLTableColElement):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::parseMappedAttribute):
(WebCore::leakBorderStyle):
(WebCore::HTMLTableElement::additionalAttributeStyle):
(WebCore::HTMLTableElement::createSharedCellStyle):
(WebCore::HTMLTableElement::additionalCellStyle):
(WebCore::leakGroupBorderStyle):
(WebCore::HTMLTableElement::additionalGroupStyle):

  • html/HTMLTableElement.h:

(HTMLTableElement):

  • html/HTMLTableSectionElement.cpp:

(WebCore::HTMLTableSectionElement::additionalAttributeStyle):

  • html/HTMLTableSectionElement.h:

(HTMLTableSectionElement):

Instead of collecting additional style decls into a vector, switch over to a
"PassRefPtr<CSSMutableStyleDeclaration> additionalAttributeStyle()".
All style declarations that can be reused for all elements are cached at the return
sites, leaving only the shared table cell style which we cache on HTMLTableElement.
Also removed the canHaveAdditionalAttributeStyleDecls() virtual since the default
additionalAttributeStyle() will just return 0.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::matchAllRules):

Updated for the new additional style conventions.

10:52 Changeset [106014] by mrowe@apple.com
  • 5 edits in branches/safari-534.54-branch/Source

Versioning.

10:51 Changeset [106013] by mrowe@apple.com
  • 1 copy in tags/Safari-534.54.10

New tag.

10:46 Changeset [106012] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebKit2

ASSERT(!m_overlay) reached in TapHighlightController.cpp:73
https://bugs.webkit.org/show_bug.cgi?id=77117

Reviewed by Tor Arne Vestbø.

The PageOverlay does only get uninstalled after the fade-out animation finishes,
so do not assert on !m_overlay after the uninstallPageOverlay call.

  • WebProcess/WebPage/TapHighlightController.cpp:

(WebKit::TapHighlightController::hideHighlight):

10:45 Changeset [106011] by vsevik@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Scripts panel editor container should be based on UISourceCode objects, not SourceFrames.
https://bugs.webkit.org/show_bug.cgi?id=77098

Reviewed by Pavel Feldman.

  • inspector/front-end/ScriptsNavigator.js:
  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.setScriptSourceIsBeingEdited):
(WebInspector.ScriptsPanel.prototype.get visibleView):
(WebInspector.ScriptsPanel.prototype.viewForFile):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):
(WebInspector.EditorContainer):
(WebInspector.EditorContainer.prototype.get visibleView):
(WebInspector.EditorContainer.prototype.showFile):
(WebInspector.EditorContainer.prototype.setFileIsDirty):
(WebInspector.EditorContainer.prototype.replaceFiles):
(WebInspector.EditorContainer.prototype.reset):
(WebInspector.EditorContainerDelegate):
(WebInspector.EditorContainerDelegate.prototype.viewForFile):
(WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.replaceUISourceCodes):
(WebInspector.ScriptsPanel.SingleFileEditorContainer):
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.get visibleView):
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.showFile):
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.setFileIsDirty):
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.replaceFiles):
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.reset):

  • inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer):
(WebInspector.TabbedEditorContainer.prototype.get visibleView):
(WebInspector.TabbedEditorContainer.prototype._titleForFile):
(WebInspector.TabbedEditorContainer.prototype._tooltipForFile):
(WebInspector.TabbedEditorContainer.prototype._appendFileTab):
(WebInspector.TabbedEditorContainer.prototype._tabClosed):
(WebInspector.TabbedEditorContainer.prototype._tabSelected):
(WebInspector.TabbedEditorContainer.prototype.replaceFiles.get if):
(WebInspector.TabbedEditorContainer.prototype.replaceFiles):
(WebInspector.TabbedEditorContainer.prototype.setFileIsDirty.get if):
(WebInspector.TabbedEditorContainer.prototype.setFileIsDirty):
(WebInspector.TabbedEditorContainer.prototype.reset):

10:42 Changeset [106010] by inferno@chromium.org
  • 1 edit in branches/chromium/963/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp

Merge 105983 - 2012-01-26 Nikolas Zimmermann <nzimmermann@rim.com>
BUG=99615
Review URL: https://chromiumcodereview.appspot.com/9288069

10:41 Changeset [106009] by inferno@chromium.org
  • 12 edits
    5 copies in branches/chromium/963

Merge 105978 - crash in WebCore::RenderSVGContainer::paint
BUG=99615
Review URL: https://chromiumcodereview.appspot.com/9235065

09:54 Changeset [106008] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebKit2

WebPreferencesStore: use DEFINE_STATIC_LOCAL for overrides HashMap
https://bugs.webkit.org/show_bug.cgi?id=77109

Reviewed by Andreas Kling.

Fix build for Clang.

  • Shared/WebPreferencesStore.cpp:

(WebKit):
(WebKit::boolTestRunnerOverridesMap):
(WebKit::WebPreferencesStore::overrideBoolValueForKey):
(WebKit::WebPreferencesStore::removeTestRunnerOverrides):
(WebKit::WebPreferencesStore::getBoolValueForKey):

09:52 Changeset [106007] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test accessibility/loading-iframe-sends-notification.html occasionally exceeds the Chromium Windows callstack
https://bugs.webkit.org/show_bug.cgi?id=77110

Unreviewed gardening. Marking accessibility/loading-iframe-sends-notification.html as flaky on the Chromium
Windows Debug bot.

  • platform/chromium/test_expectations.txt:
09:42 Changeset [106006] by leviw@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

Adding platform expectations after r105978.

Unreviewed gardening.

  • platform/chromium-linux/svg/wicd/sizing-flakiness-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/wicd/sizing-flakiness-expected.png: Added.
  • platform/chromium-win/svg/wicd/sizing-flakiness-expected.png: Added.
09:10 Changeset [106005] by caio.oliveira@openbossa.org
  • 17 edits in trunk

Implement overridePreference for boolean preferences in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=77033

Reviewed by Alexey Proskuryakov.

Source/WebKit2:

Implement a way to WebKitTestRunner override preferences for the pages
loaded. Follows the same approach taken by
overrideXSSAuditorEnabledForTestRunner() from r66551, but generalizing to many
preferences.

Preferences are stored in the UI process using WebPreferencesStore, and when
there's a change, this data is sent to Web process, triggering
WebPage::preferencesDidChange(), which take a WebPreferencesStore and apply it's
data to the WebCore::Settings object.

The overridePreference() is executed on the Web process, and set the preferences
without communicating to the UI process. The overriden preferences are stored in
a static map and WebPreferencesStore query this map before returning the values
of each preference. This static map is used only on the Web process.

To clear the overrides we need to clear the map. Since WTR only sets preferences
when resetting the page, we hook the clearing at WebPage::preferencesDidChange().
A WKPreferences private function was exposed to WTR force the update, in case
there's no effective change at UI process (all the properties remains the same).

This clearing could be improved by creating a proper message instead of hooking
at WebPage::preferencesDidChange().

  • Shared/WebPreferencesStore.cpp:

(WebKit::WebPreferencesStore::decode):
(WebKit::WebPreferencesStore::overrideBoolValueForKey):
(WebKit::WebPreferencesStore::removeTestRunnerOverrides):
(WebKit::WebPreferencesStore::getBoolValueForKey):

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesResetTestRunnerOverrides):

  • UIProcess/API/C/WKPreferencesPrivate.h:
  • UIProcess/WebPreferences.h:

(WebKit::WebPreferences::forceUpdate):

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleOverrideBoolPreferenceForTestRunner):

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
(WebKit::InjectedBundle::overrideXSSAuditorEnabledForTestRunner):

  • WebProcess/InjectedBundle/InjectedBundle.h:

Tools:

For now overridePreference supports boolean values.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::setXSSAuditorEnabled):
(WTR::LayoutTestController::overridePreference):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues): Reset the overrides
explicitly and properly disable the use of PageCache when resetting the
state. Tests that use PageCache can now enable it via overridePreference.

LayoutTests:

  • platform/wk2/Skipped:
08:07 Changeset [106004] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt] Support opening multiple URL's from the command line in the Qt MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=77100

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2012-01-26
Reviewed by Simon Hausmann.

This patch makes the MiniBrowser read multiple URL's from the command
line such that there will be one browser window opened for each URL.

  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::handleUserOptions):

07:44 SettingUpDevelopmentEnvironmentForN9 edited by zarvai@inf.u-szeged.hu
(diff)
07:28 Changeset [106003] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[Qt] The Qt MiniBrowser crashes when given multiple URL's
https://bugs.webkit.org/show_bug.cgi?id=77009

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2012-01-26
Reviewed by Simon Hausmann.

This patch fixes a crash in BrowserWindow::newWindow() where a
BrowserWindow-object is constructed with a 0 pointer as the
WindowOptions parameter which leads to a crash.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::newWindow):

  • MiniBrowser/qt/BrowserWindow.h:
07:22 SettingUpDevelopmentEnvironmentForN9 created by zarvai@inf.u-szeged.hu
07:20 Changeset [106002] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Still failing tests after moving to ICU
https://bugs.webkit.org/show_bug.cgi?id=77102

Unreviewed gardening.

  • platform/qt-wk2/Skipped: Skip failing tests for now.
07:04 Changeset [106001] by zimmermann@webkit.org
  • 6 edits
    3 adds in trunk

SVG + <object> tests are flakey
https://bugs.webkit.org/show_bug.cgi?id=77099

Reviewed by Andreas Kling.

Source/WebCore:

Bug 76447 changed the way RenderSVGRoot figures out its size. Previously RenderSVGRoot directly called out to the
ownerRenderer (RenderEmbeddedObject) to compute its replaced size when embedded through eg. <object> element,
which was quite hacky. It now relies on the ownerRenderers availableLogicalWidth/Height to be correctly set,
which requires that the ownerRenderer is always laid out before the RenderSVGRoot and not the other way round.

This is the source of current flakiness bugs.

In trunk FrameView contains several special hacks, to layout the ownerRenderers view, after the RenderSVGRoots view
finished layout. This worked without flakiness as RenderSVGRoot used to directly call computeReplacedLogicalWidth/Height
on the ownerRenderer, which is now gone. Fortunately we can keep the new design, and can remove all hacks out of
RenderSVGRoot/FrameView, if we can guarantee that the ownerRenderer FrameView is laid out before the RenderSVGRoot FrameView.

This is a much less error-prone approach as the previous one. This lets us run nrwt --tolerance 0 -p svg -g again,
without 100% reproducable failing svg/wicd tests. (There's still one unrelated error, before guard malloc mode passes fully).

Test: svg/wicd/sizing-flakiness.html (Adjusted version of the rightsizing test, made to fail with trunk w/o this patch.)

  • page/FrameView.cpp: Remove m_inLayoutParentView.

(WebCore::FrameView::FrameView): Remove no longer needed m_inLayoutParentView.
(WebCore::FrameView::forceLayoutParentViewIfNeeded): Simplify, no need to call updateWidgetPositions anymore, nor to clear/query flags in RenderSVGRoot.
(WebCore::FrameView::layout): Call forceLayoutParentViewIfNeeded() before laying out the embedded document, to guarantee the correct order.

  • page/FrameView.h:

(FrameView): Remove m_inLayoutParentView.

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::RenderSVGRoot): Remove m_needsSizeNegotiationWithHostDocument.
(WebCore::resolveLengthAttributeForSVG): Remove outcommented code, that went in by accident.
(WebCore::RenderSVGRoot::layout): Remove m_needsSizeNegotiationWithHostDocument handling which is now incorrect and no longer needed.

  • rendering/svg/RenderSVGRoot.h:

(RenderSVGRoot): Remove m_needsSizeNegotiationWithHostDocument + accessors.

LayoutTests:

Introduce a testcase that fails reproducibly w/o needed guard malloc, if we ever regress <object> sizing again.

  • platform/mac/svg/wicd/sizing-flakiness-expected.png:
  • platform/mac/svg/wicd/sizing-flakiness-expected.txt:
  • svg/wicd/sizing-flakiness.html: Adjusted version of the rightsizing test, made to fail with trunk w/o this patch.
07:03 Changeset [106000] by carlosgc@webkit.org
  • 4 edits in trunk/Source/WebKit2

[GTK][WK2] Primary clipboard should be updated with the current selection in X11 platforms
https://bugs.webkit.org/show_bug.cgi?id=77097

Reviewed by Martin Robinson.

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::respondToChangedSelection): Call
setSelectionPrimaryClipboardIfNeeded() to update primary clipboard
in X11 platforms.

  • WebProcess/WebCoreSupport/WebEditorClient.h:
  • WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:

(WebKit::collapseSelection): Callback called when clearing
clipboard contents.
(WebKit::WebEditorClient::setSelectionPrimaryClipboardIfNeeded):
Updaye primary clipboard with the current selection.

06:56 Changeset [105999] by kling@webkit.org
  • 5 edits in trunk/Source/WebCore

Make elements that don't have attributes smaller.
<http://webkit.org/b/76876>

Reviewed by Antti Koivisto.

Move the inline style declaration from StyledElement to NamedNodeMap, since having
an inline style declaration also implies having a style attribute on the element.
This saves one CPU word per element that has no attributes.

This reduces memory consumption by 412 kB (on 64-bit) when viewing the full
HTML5 spec at <http://whatwg.org/c>.

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::ensureInlineStyleDecl):
(WebCore::NamedNodeMap::destroyInlineStyleDecl):
(WebCore::NamedNodeMap::createInlineStyleDecl):

  • dom/NamedNodeMap.h:

(WebCore::NamedNodeMap::inlineStyleDecl):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::updateStyleAttribute):
(WebCore::StyledElement::addSubresourceAttributeURLs):

  • dom/StyledElement.h:

(WebCore::StyledElement::inlineStyleDecl):
(WebCore::StyledElement::ensureInlineStyleDecl):
(WebCore::StyledElement::destroyInlineStyleDecl):

06:14 Changeset [105998] by antonm@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Another unreviewed rebaseline.

  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-tspan-and-stroke-expected.png: Added.
06:07 Changeset [105997] by commit-queue@webkit.org
  • 11 edits in trunk

[Qt] Use ICU if available
https://bugs.webkit.org/show_bug.cgi?id=76821

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2012-01-26
Reviewed by Simon Hausmann.

Source/WebCore:

Adding correct sources to a Qt 5 based build.

No new tests, it's just a build dependency change.

  • Target.pri:

Source/WTF:

Adding libicu dependencies for a Qt5 based build.

  • WTF.pri:

Tools:

Adding unicode defines for a Qt 5 based build.

  • qmake/mkspecs/features/features.prf:

LayoutTests:

Unskipping ICU related tests for Qt 5 and skipping for
Qt 4.

  • platform/qt-4.8/Skipped:
  • platform/qt-arm/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/qt/Skipped:
05:53 Changeset [105996] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Added missing NETSCAPE_PLUGIN_API macro.
https://bugs.webkit.org/show_bug.cgi?id=77093

Patch by Tomasz Morawski <t.morawski@samsung.com> on 2012-01-26
Reviewed by Andreas Kling.

The ewk_view_js_window_object_clear function should be inside ENABLE(NETSCAPE_PLUGIN_API) macro.

  • ewk/ewk_view.cpp:
05:43 Changeset [105995] by ossy@webkit.org
  • 4 edits in trunk/Source

[Qt][Win] One more speculative buildfix after r105970.

Source/JavaScriptCore:

Source/WTF:

  • WTF.pri:
04:58 Changeset [105994] by zimmermann@webkit.org
  • 2 edits in trunk/Source/WebCore

2012-01-26 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix mac build after r105988.

  • WebCore.exp.in:
04:46 Changeset [105993] by ossy@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[Qt][Win] Speculative buildfix after r105970.

04:42 Changeset [105992] by zimmermann@webkit.org
  • 5 edits in trunk/LayoutTests

svg/webarchive tests are flakey under guard malloc
https://bugs.webkit.org/show_bug.cgi?id=77092

Reviewed by Zoltan Herczeg.

Fix flakey tests, by moving the <script> that dumps the test as webarchive, after the actual content.

  • svg/webarchive/svg-cursor-subresources-expected.webarchive:
  • svg/webarchive/svg-cursor-subresources.svg:
  • svg/webarchive/svg-feimage-subresources-expected.webarchive:
  • svg/webarchive/svg-feimage-subresources.svg:
04:28 Changeset [105991] by zeno.albisser@nokia.com
  • 10 edits
    2 adds in trunk/Source/WebKit2

[Qt][WK2] Use QVariant for payload data in application URL schemes.
https://bugs.webkit.org/show_bug.cgi?id=77007

Make application schemes use QVariant for payload data.
This allows passing QByteArrays as well as simple String data.

Remove unneeded http header parts that were exposed in
QQuickNetworkReply.

Add ByteArrayTestData class to allow injecting QByteArray
data into an application scheme handler for testing.

Reviewed by Simon Hausmann.

  • Shared/qt/QtNetworkReplyData.cpp:

(WebKit::QtNetworkReplyData::QtNetworkReplyData):
(WebKit::QtNetworkReplyData::encode):
(WebKit::QtNetworkReplyData::decode):

  • Shared/qt/QtNetworkReplyData.h:
  • UIProcess/API/qt/qquicknetworkreply.cpp:

(QQuickNetworkReply::QQuickNetworkReply):
(QQuickNetworkReply::data):
(QQuickNetworkReply::setData):
(QQuickNetworkReply::send):

  • UIProcess/API/qt/qquicknetworkreply_p.h:
  • UIProcess/API/qt/tests/bytearraytestdata.cpp: Added.

(ByteArrayTestData::ByteArrayTestData):
(ByteArrayTestData::latin1Data):
(ByteArrayTestData::utf8Data):

  • UIProcess/API/qt/tests/bytearraytestdata.h: Added.
  • UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml:
  • UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp:

(main):

  • UIProcess/API/qt/tests/tests.pri:
  • WebProcess/qt/QtNetworkReply.cpp:

(WebKit::QtNetworkReply::setReplyData):

  • WebProcess/qt/QtNetworkReply.h:
04:18 Changeset [105990] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Fixed build when using force_static_libs_as_shared
https://bugs.webkit.org/attachment.cgi?bugid=77082

Patch by Thiago Marcos P. Santos <tmpsantos@gmail.com> on 2012-01-26
Reviewed by Simon Hausmann.

  • Target.pri:
04:17 Changeset [105989] by antonm@chromium.org
  • 1 edit
    9 adds
    5 deletes in trunk/LayoutTests

Unreviewed rebaseline after http://trac.webkit.org/changeset/105977.

  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Removed.
  • platform/chromium/svg/W3C-SVG-1.1-SE: Added.
  • platform/chromium/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Added.
  • platform/chromium/svg/stroke: Added.
  • platform/chromium/svg/stroke/zero-length-arc-linecaps-rendering-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Removed.
  • platform/gtk/svg/stroke: Removed.
  • platform/gtk/svg/stroke/zero-length-arc-linecaps-rendering-expected.txt: Removed.
  • platform/qt/svg/stroke/zero-length-arc-linecaps-rendering-expected.txt: Removed.
  • svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Added.
  • svg/stroke/zero-length-arc-linecaps-rendering-expected.txt: Added.
04:16 Changeset [105988] by commit-queue@webkit.org
  • 13 edits in trunk

[WK2] WebKitTestRunner needs layoutTestController.setGeolocationPermission
https://bugs.webkit.org/show_bug.cgi?id=42545

Patch by Nándor Huszka <huszka.nandor@stud.u-szeged.hu> on 2012-01-26
Reviewed by Zoltan Herczeg.

Source/WebCore:

No need for new tests, there is no behavior change.

Added a line to file which copies the forwarding headers.

  • WebCore.vcproj/copyForwardingHeaders.cmd:

Source/WebKit2:

Implement the setGeolocationPermission method.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetGeolocationPermission):

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setGeoLocationPermission):
(WebKit):

  • WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

Tools:

Implement the setGeolocationPermission method.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::setGeolocationPermission):
(WTR):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(LayoutTestController):

LayoutTests:

Unskip a test which does not fail now and move tests to the appropriate label.

  • platform/wk2/Skipped:
03:58 Changeset [105987] by zimmermann@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r105982.
http://trac.webkit.org/changeset/105982
https://bugs.webkit.org/show_bug.cgi?id=77090

breaks the world (Requested by WildFox on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-26

  • wtf/MainThread.cpp:

(WTF):

  • wtf/Platform.h:
  • wtf/mac/MainThreadMac.mm:

(WTF):
(WTF::registerGCThread):
(WTF::isMainThreadOrGCThread):

03:08 Changeset [105986] by zimmermann@webkit.org
  • 5 edits in trunk/Source/WebCore

2012-01-26 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix Qt build after r105978.

  • rendering/svg/RenderSVGResourceClipper.cpp: Add missing Frame/FrameView includes.
  • rendering/svg/RenderSVGResourceSolidColor.cpp: Ditto.
  • rendering/svg/SVGInlineTextBox.cpp: Ditto.
  • rendering/svg/SVGRenderSupport.cpp: Ditto.
02:41 Changeset [105985] by zimmermann@webkit.org
  • 2 edits in trunk/Source/WebCore

2012-01-26 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix non-AllInOne builds after r105978.

  • rendering/svg/RenderSVGResource.cpp:
02:29 Changeset [105984] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed inspector closure compilation fix.

  • inspector/front-end/externs.js:

(WebInspector.closeDrawerView):

02:26 Changeset [105983] by zimmermann@webkit.org
  • 2 edits in trunk/Source/WebCore

2012-01-26 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix release builds after r105978.

  • rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::paintSelectionBackground): Remove unused variable.
02:22 Changeset [105982] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

[Qt] GC should be parallel on Qt platform
https://bugs.webkit.org/show_bug.cgi?id=73309

Patch by Roland Takacs <takacs.roland@stud.u-szeged.hu> on 2012-01-26
Reviewed by Zoltan Herczeg.

These changes made the parallel gc feature available for Qt port.
The implementation of "registerGCThread" and "isMainThreadOrGCThread"
is moved from MainThreadMac.mm to the common MainThread.cpp to make
them available for other platforms.

Measurement results:
V8 speed-up: 1.071x as fast [From: 746.1ms To: 696.4ms ]
WindScorpion speed-up: 1.082x as fast [From: 3490.4ms To: 3226.7ms]
V8 Splay speed-up: 1.158x as fast [From: 145.8ms To: 125.9ms ]

Tested on Intel(R) Core(TM) i5-2320 CPU @ 3.00GHz with 4-core.

  • wtf/MainThread.cpp:

(WTF):
(WTF::registerGCThread):
(WTF::isMainThreadOrGCThread):

  • wtf/Platform.h:
  • wtf/mac/MainThreadMac.mm:
02:10 Changeset [105981] by kbalazs@webkit.org
  • 5 edits in trunk/Tools

[NRWT] Support --ignore-metrics
https://bugs.webkit.org/show_bug.cgi?id=76278

Reviewed by Tony Chang.

Port the feature from ORWT.

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner._run_compare_test):

  • Scripts/webkitpy/layout_tests/port/driver.py:

(DriverOutput):
(DriverOutput.strip_metrics):

  • Scripts/webkitpy/layout_tests/port/driver_unittest.py:

(DriverOutputTest):
(DriverOutputTest.test_strip_metrics):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(_set_up_derived_options):
(parse_args):

02:07 Changeset [105980] by tkent@chromium.org
  • 5 edits in trunk

Unreviewed, rolling out r105968.
http://trac.webkit.org/changeset/105968
https://bugs.webkit.org/show_bug.cgi?id=76995

Incorrect behavior change

Source/WebCore:

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setIndeterminate):

LayoutTests:

  • fast/forms/indeterminate-radio.html:
  • fast/forms/radio-checkbox-restore-indeterminate.html:
01:51 Changeset [105979] by commit-queue@webkit.org
  • 8 edits in trunk/Tools

Unreviewed, rolling out r105935 and r105954.
http://trac.webkit.org/changeset/105935
http://trac.webkit.org/changeset/105954
https://bugs.webkit.org/show_bug.cgi?id=77080

test-webkitpy is still broken (Requested by abarth on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-26

  • Scripts/test-webkitpy:
  • Scripts/webkitpy/common/system/executive_unittest.py:

(never_ending_command):
(ExecutiveTest.test_run_command_args_type):
(ExecutiveTest.test_run_command_with_unicode):
(ExecutiveTest.test_running_pids):

  • Scripts/webkitpy/common/system/fileutils.py:

(make_stdout_binary):

  • Scripts/webkitpy/test/cat.py:

(command_arguments):
(main):

  • Scripts/webkitpy/test/cat_unittest.py:

(CatTest):
(CatTest.assert_cat):
(CatTest.test_basic):
(CatTest.test_no_newline):
(CatTest.test_unicode):
(CatTest.test_as_command):

  • Scripts/webkitpy/test/echo.py:

(command_arguments):
(main):

  • Scripts/webkitpy/test/echo_unittest.py:

(EchoTest):
(EchoTest.test_basic):
(EchoTest.test_no_newline):
(EchoTest.test_unicode):
(EchoTest.test_argument_order):
(EchoTest.test_empty_arguments):
(EchoTest.test_no_arguments):
(EchoTest.test_as_command):

01:50 Changeset [105978] by zimmermann@webkit.org
  • 14 edits
    5 adds in trunk

crash in WebCore::RenderSVGContainer::paint
https://bugs.webkit.org/show_bug.cgi?id=69714

Reviewed by Dirk Schulze.

Source/WebCore:

When RenderSVGResourceClipper draws its children to a mask, it requires some special constraints:

  • fill-opacity/stroke-opacity/opacity forced to 1
  • masker/filter resources shouldn't be applied to the children
  • fill must be set to the initial fill paint server for all children (solid black)
  • stroke must be set to the initial stroke paint server for all children (none)

This was achieved before by mutating the style of the children, which made them need a relayout.
SVGImageBufferTools:renderSubtreeToImageBuffer thus needed to layout the children, if needed, before painting.

This can be completly avoided, when changing RenderSVGResourceClipper to avoid style mutations.
Introduce a new "PaintBehaviorRenderingSVGMask", and set the current FrameViews paintBehaviour to this
state, before painting the subtree. This way we can detect that we're rendering a clip mask, without
having to mutate the style of the children and without having to relayout.

We can now ASSERT(!item->needsLayout()) in renderSubtreeToImageBuffer.

Tests: svg/clip-path/clip-path-tspan-and-stroke.svg

svg/custom/layout-loop.svg

  • rendering/PaintPhase.h:
  • rendering/svg/RenderSVGResource.cpp:

(WebCore::requestPaintingResource):

  • rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::RenderSVGResourceClipper):
(WebCore::RenderSVGResourceClipper::removeAllClientsFromCache):
(WebCore::RenderSVGResourceClipper::removeClientFromCache):
(WebCore::RenderSVGResourceClipper::applyClippingToContext):
(WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage):

  • rendering/svg/RenderSVGResourceClipper.h:
  • rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::applyResource):
(WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):

  • rendering/svg/RenderSVGResourceMasker.h:
  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::createTileImage):

  • rendering/svg/RenderSVGResourceSolidColor.cpp:

(WebCore::RenderSVGResourceSolidColor::applyResource):

  • rendering/svg/SVGImageBufferTools.cpp:

(WebCore::SVGImageBufferTools::renderSubtreeToImageBuffer):

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::paintSelectionBackground):
(WebCore::SVGInlineTextBox::paint):

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::prepareToRenderSVGContent):

LayoutTests:

Added a new test covering the clipper specific demands when rendering its children to a mask.
(fill/stroke-opacity=1, opacity=1, don't apply masker/filter to children)

All cases are covered by existing tests, I'm adding a new combination of <tspan> within a <text>,
that tries to apply a stroke paint server, which is supposed to be ignored.

  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/clip-path/clip-path-tspan-and-stroke-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-tspan-and-stroke-expected.txt: Added.
  • svg/clip-path/clip-path-tspan-and-stroke.svg: Added.
  • svg/custom/layout-loop-expected.txt: Added.
  • svg/custom/layout-loop.svg: Added.
01:40 Changeset [105977] by zimmermann@webkit.org
  • 13 edits in trunk/LayoutTests

2012-01-26 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Regenerated some new SVG results using a Lion machine, to make the baseline pass with --tolerance 0 -p on a vanilla iMac again.

  • platform/mac/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
  • platform/mac/svg/custom/subpaths-moveto-only-rendering-expected.png:
  • platform/mac/svg/stroke/zero-length-arc-linecaps-rendering-expected.png:
  • platform/mac/svg/stroke/zero-length-arc-linecaps-rendering-expected.txt:
  • platform/mac/svg/stroke/zero-length-path-linecap-rendering-expected.png:
  • platform/mac/svg/stroke/zero-length-path-linecap-rendering-expected.txt:
  • platform/mac/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png:
  • platform/mac/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt:
  • platform/mac/test_expectations.txt
01:28 Changeset [105976] by zimmermann@webkit.org
  • 3 edits in trunk/WebKitLibraries

2012-01-26 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix win build, by disabling ENABLE_SHADOW_DOM by default.

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
01:09 Changeset [105975] by zimmermann@webkit.org
  • 4 edits in trunk/Source

2012-01-26 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Try to fix Qt/Win build by building OwnPtrWin.cpp into the WTF library.

  • WTF.pro:

2012-01-26 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Try to fix Gtk build - JSShadowRoot.cpp can't be found, fix by looking for it in the derived sources.

  • GNUmakefile.list.am:
01:01 Changeset [105974] by rgabor@webkit.org
  • 2 edits in trunk/Tools

[GTK] Detect cross-compilation in webkitdirs.pm to not generate gtkdoc
https://bugs.webkit.org/show_bug.cgi?id=76138

Reviewed by Martin Robinson.

  • Scripts/webkitdirs.pm:

(isCrossCompilation):
(buildAutotoolsProject):

00:56 Changeset [105973] by ossy@webkit.org
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r105917.

  • platform/qt/Skipped:
  • platform/qt/test_expectations.txt:
00:55 Changeset [105972] by mrowe@apple.com
  • 12 edits in branches/safari-534.54-branch/Source

Merge r105942.

00:28 Changeset [105971] by rniwa@webkit.org
  • 1 edit
    15 adds in trunk

Port Mozilla's Graph Server
https://bugs.webkit.org/show_bug.cgi?id=76312

Reviewed by Adam Barth.

Add the app engine backend for the Mozilla's graph server used on perf-webkit.appspot.com.

To deploy webkit-perf.appspot.com, you also need to pull index.html, embed.html, graph.html, jq,
js (except config.js), and css (except title.png) from https://github.com/mozilla/graphs.

  • Websites/perf-webkit.appspot.com: Added.
  • Websites/perf-webkit.appspot.com/app.yaml: Added.
  • Websites/perf-webkit.appspot.com/create_handler.py: Added.

(CreateHandler):
(CreateHandler.post):
(CreateHandler._createBuilder):
(CreateHandler._createBuilder.execute):
(CreateHandler._createBranch):
(CreateHandler._createBranch.execute):
(CreateHandler._createPlatform):
(CreateHandler._createPlatform.execute):

  • Websites/perf-webkit.appspot.com/dashboard_handler.py: Added.

(DashboardHandler):
(DashboardHandler.get):

  • Websites/perf-webkit.appspot.com/index.yaml: Added.
  • Websites/perf-webkit.appspot.com/main.py: Added.

(main):

  • Websites/perf-webkit.appspot.com/manifest_handler.py: Added.

(ManifestHandler):
(ManifestHandler.get):

  • Websites/perf-webkit.appspot.com/models.py: Added.

(NumericIdHolder):
(NumericIdHolder.whose):
(createInTransactionWithNumericIdHolder):
(modelFromNumericId):
(Branch):
(Platform):
(Builder):
(Builder.authenticate):
(Builder.hashedPassword):
(Build):
(Test):
(TestResult):
(ReportLog):

  • Websites/perf-webkit.appspot.com/report_handler.py: Added.

(ReportHandler):
(ReportHandler.post):
(ReportHandler._modelByKeyNameInBodyOrError):
(ReportHandler._integerInBody):
(ReportHandler._timestampInBody):
(ReportHandler._output):
(ReportHandler._resultsAreValid):
(ReportHandler._createBuildIfPossible):
(ReportHandler._createBuildIfPossible.execute):
(ReportHandler._addTestIfNeeded):
(ReportHandler._addTestIfNeeded.execute):

  • Websites/perf-webkit.appspot.com/runs_handler.py: Added.

(RunsHandler):
(RunsHandler.get):

  • Websites/perf-webkit.appspot.com/static: Added.
  • Websites/perf-webkit.appspot.com/static/create-models.html: Added.
  • Websites/perf-webkit.appspot.com/static/manual-submit.html: Added.
00:17 Changeset [105970] by aestes@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION (r105555): Incorrect use of OS() macro breaks OwnPtr when used with Win32 data types
https://bugs.webkit.org/show_bug.cgi?id=77073

Reviewed by Ryosuke Niwa.

r105555 changed PLATFORM(WIN) to OS(WIN), but WTF_OS_WIN isn't defined.
This should have been changed to OS(WINDOWS). This causes the
preprocessor to strip out Win32 data type overrides for deleteOwnedPtr,
causing allocations made by Win32 to be deleted by fastmalloc.

  • wtf/OwnPtrCommon.h:

(WTF): Use OS(WINDOWS) instead of OS(WIN).

00:16 Changeset [105969] by vsevik@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Improve user experience of advanced search panel closing.
https://bugs.webkit.org/show_bug.cgi?id=76983

Reviewed by Pavel Feldman.

Added close button to search panel.
Esc now closes the panel even when search filed has focus.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/AdvancedSearchController.js:

(WebInspector.AdvancedSearchController.prototype.close):
(WebInspector.SearchView):
(WebInspector.SearchView.prototype._onKeyDown):
(WebInspector.SearchView.prototype._closeButtonPressed):

  • inspector/front-end/inspector.css:

(.search-view .search-panel):
(.search-view .search-panel button.search-close-button):

  • inspector/front-end/inspector.js:

(WebInspector._escPressed):
(WebInspector.closeDrawerView):

00:06 Changeset [105968] by commit-queue@webkit.org
  • 5 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=76995.
WebKit fails IETC :indeterminate and input type=radio test.

As per the HTML spec http://www.whatwg.org/specs/web-apps/current-work/multipage/the-input-element.html#dom-input-indeterminate,
only checkbox input type should respect the indeterminate state.
Removed the support for indeterminate state for radio input types.

Source/WebCore:

Patch by Joe Thomas <joethomas@motorola.com> on 2012-01-26
Reviewed by Eric Seidel.

Modified the existing test cases.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setIndeterminate): Indeterminate state is supported only for checkbox input type.

LayoutTests:

Modified the existing test cases.

Patch by Joe Thomas <joethomas@motorola.com> on 2012-01-26
Reviewed by Eric Seidel.

  • fast/forms/indeterminate-radio.html:
  • fast/forms/radio-checkbox-restore-indeterminate.html:

01/25/12:

23:50 Changeset [105967] by abarth@webkit.org
  • 2 edits in trunk/Tools

Kentaro is a reviewer now. Yay!

  • Scripts/webkitpy/common/config/committers.py:
22:15 Changeset [105966] by lforschler@apple.com
  • 5 edits in branches/safari-534.54-branch/Source

Versioning.

22:12 Changeset [105965] by lforschler@apple.com
  • 1 copy in tags/Safari-534.54.9

New tag.

21:56 Changeset [105964] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Add IntentRequest include for FrameLoaderClientImpl.
https://bugs.webkit.org/show_bug.cgi?id=77039

Patch by Greg Billock <gbillock@google.com> on 2012-01-25
Reviewed by Darin Fisher.

  • src/FrameLoaderClientImpl.cpp:
21:12 Changeset [105963] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test fast/js/dfg-uint32array-overflow-values.html is slow on Chromium Debug bots
https://bugs.webkit.org/show_bug.cgi?id=77069

Marking fast/js/dfg-uint32array-overflow-values.html slow for Debug Chromium bots.

  • platform/chromium/test_expectations.txt:
21:02 Changeset [105962] by dcheng@chromium.org
  • 7 edits
    1 move
    1 add
    1 delete in trunk/Source

[chromium] Fix ClipboardChromium::validateFilename to actually operate on extensions
https://bugs.webkit.org/show_bug.cgi?id=76996

Source/WebCore:

As it turns out, we were always calling validateFilename on a data object with an empty
extension. Now we call it on an actual extension so that it's sanitized.

Reviewed by Tony Chang.

Unit test: webkit_unit_tests --gtest_filter=ClipboardChromium.*

  • WebCore.gypi:
  • platform/chromium/ClipboardChromium.cpp:

(WebCore::writeImageToDataObject):

  • platform/chromium/ClipboardChromium.h:

(ClipboardChromium):

  • platform/chromium/ClipboardChromiumLinux.cpp: Removed.
  • platform/chromium/ClipboardChromiumPosix.cpp: Renamed from Source/WebCore/platform/chromium/ClipboardChromiumMac.cpp.

(WebCore):
(WebCore::isInvalidFileCharacter):
(WebCore::ClipboardChromium::validateFilename):

  • platform/chromium/ClipboardChromiumWin.cpp:

(WebCore):
(WebCore::ClipboardChromium::validateFilename):

Source/WebKit/chromium:

Reviewed by Tony Chang.

  • WebKit.gypi:
  • tests/ClipboardChromiumTest.cpp: Added.

(WebCore):
(WebCore::TEST):

19:08 Changeset [105961] by commit-queue@webkit.org
  • 10 edits in trunk/Source

[chromium] Rollout r100751, this mechanism does not work and is very slow
https://bugs.webkit.org/show_bug.cgi?id=77055

Unreviewed rollout of http://trac.webkit.org/changeset/100751. The refresh rate mechanism is not implemented,
but it still triggers a very slow codepath and triggers races on some platforms.

Patch by James Robinson <jamesr@chromium.org> on 2012-01-25

Source/WebCore:

  • platform/PlatformScreen.h:

(WebCore):

  • platform/chromium/PlatformScreenChromium.cpp:
  • platform/chromium/PlatformSupport.h:

(PlatformSupport):
():

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):
(CCSettings):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::initializeImplOnImplThread):

Source/WebKit/chromium:

  • public/WebScreenInfo.h:

(WebScreenInfo):
(WebKit::WebScreenInfo::WebScreenInfo):

  • src/PlatformSupport.cpp:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::runTest):

18:27 Changeset [105960] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Reverting the addition of storage/indexeddb/prefetch-bugfix-108071.html
to Chromium's test_expectations. The proper place for this test to be disabled was
in Chromium, since it failed in test_shell.

  • platform/chromium/test_expectations.txt:
18:10 Changeset [105959] by lforschler@apple.com
  • 4 edits
    3 copies in branches/safari-534.54-branch

Merged r105894.

18:01 Changeset [105958] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebKit2

Merged r102819.

17:59 Changeset [105957] by dpranke@chromium.org
  • 2 edits in trunk/Tools

nrwt: running w/ no arguments fails
https://bugs.webkit.org/show_bug.cgi?id=77064

Unreviewed, build fix.

This change fixes a regression introduced in r105944
where running without --platform <foo> or one of the other
platform switches would cause a null deref :(.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(main):

17:56 Changeset [105956] by eric@webkit.org
  • 2 edits in trunk/Tools

Automatically CC someone from Apple on any changes to Obj-C public API
https://bugs.webkit.org/show_bug.cgi?id=77053

Reviewed by Timothy Hatcher.

This has long been de-facto practice, seems now that we have
fancy watchlist support, we should just make the tools
do this automatically.

  • Scripts/webkitpy/common/config/watchlist:
17:53 Changeset [105955] by piman@chromium.org
  • 2 edits in trunk/Tools

Updating status in committers.py.

Unreviewed.

  • Scripts/webkitpy/common/config/committers.py:
17:47 Changeset [105954] by dpranke@chromium.org
  • 3 edits in trunk/Tools

test-webkitpy: executive_unittest fails if PYTHONPATH isn't set
https://bugs.webkit.org/show_bug.cgi?id=77058

Reviewed by Eric Seidel.

r105935 broke executive_unittest by changing which script we
were running and not ensuring that the PYTHONPATH was set up
properly.

This change also fixes a regression introduced recently where
test-webkitpy wasn't figuring out the path to Tools/Scripts
right, either (so running ./test-webkitpy would fail).

  • Scripts/test-webkitpy:
  • Scripts/webkitpy/common/system/executive_unittest.py:

(script_dir):
(ExecutiveTest.setUp):
(ExecutiveTest):
(ExecutiveTest.tearDown):

17:34 Changeset [105953] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/LayoutTests/platform/mac-snowleopard/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png

Fixing one incorrect test expectation.

17:30 Changeset [105952] by abarth@webkit.org
  • 2 edits in trunk/Tools

Disable tests on the mac-ews while we sort out hte stability issues.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(MacEWS):

17:29 Changeset [105951] by dpranke@chromium.org
  • 8 edits in trunk/Tools

investigate use of 'mac' and 'win' as fully-specified port names for the apple ports
https://bugs.webkit.org/show_bug.cgi?id=76475

Reviewed by Eric Seidel.

This patch cleans up the internal usage of port names for the
Apple mac and Apple win ports so that 'mac' and 'win are never
considered "fully specified" port names: they are still legal
input to the PortFactory.get() routine, but only if run on the given
platform (i.e. trying to PortFactory.get('mac') on windows or
linux will return an error, since we don't know which version of
the port is desired.

This also cleans up handling of the webkit2 variants, so that
the full port names consistently follow the
<operating_system>-<version>[-<wk2>] convention.

Lastly this patch adds some assertions and removes some
try/catch logic to catch more programming and usage errors;
previously mac-tiger might've been allowed -- and it would've
translated into using just the baselines in platform/mac -- but
now it should fail.

  • Scripts/webkitpy/layout_tests/port/apple.py:

(ApplePort.determine_full_port_name):
(ApplePort.init):
(ApplePort):
(ApplePort._port_name_with_version):

  • Scripts/webkitpy/layout_tests/port/builders.py:
  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:

(FactoryTest.test_mac):
(FactoryTest.test_win):

  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.baseline_search_path):

  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:

(MacTest.test_versions):

  • Scripts/webkitpy/layout_tests/port/win.py:

(WinPort.baseline_search_path):

  • Scripts/webkitpy/layout_tests/port/win_unittest.py:

(WinTest.test_versions):

17:24 Changeset [105950] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Reapply Daniel Bates's build fix from r105847 after the exact same issue was reintroduced in r105930.

Attempt to fix Mac build after changeset <http://trac.webkit.org/changeset/105930>.
(https://bugs.webkit.org/show_bug.cgi?id=75049)

Don't include NotImplemented.h in KURL.h since NotImplemented.h includes Logging.h, which defines
LOG_CHANNEL_PREFIX to be "Log". And this conflicts with the inclusion of WebKitLogging.h in
WebHTMLView.mm (which would have defined LOG_CHANNEL_PREFIX to be "WebKitLog").

  • platform/KURL.h:

(WebCore::KURL::innerURL):

17:15 Changeset [105949] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Marking svg/custom/object-sizing-explicit-width.xhtml and
storage/indexeddb/prefetch-bugfix-108071.html as flaky on Chromium.

  • platform/chromium/test_expectations.txt:
17:11 Changeset [105948] by dpranke@chromium.org
  • 5 edits in trunk/Tools

webkitpy: print nicer errors while linting expectations files, remove redundant tests
https://bugs.webkit.org/show_bug.cgi?id=76955

Reviewed by Adam Barth.

This change cleans up the errors that are printed so that the
are more "quickfix" compatible (path:lineno).

Also, there were a bunch of redundant tests between
layout_tests.models.test_expectations_unittest and
style.checkers.test_expectations_unittest. The latter should
just expect the former to do most of the testing.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationParser._parse_modifiers):
(TestExpectations._report_errors):
(TestExpectations._add_skipped_tests):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(test_parse_error_nonfatal):
(SemanticTests.test_bad_bugid):

  • Scripts/webkitpy/style/checkers/test_expectations.py:

(TestExpectationsChecker.init):

  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py:

(TestExpectationsTestCase.assert_lines_lint):
(TestExpectationsTestCase.test_valid_expectations):
(TestExpectationsTestCase.test_invalid_expectations):
(TestExpectationsTestCase.test_tab):

17:09 Changeset [105947] by eric@webkit.org
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r105940.
http://trac.webkit.org/changeset/105940
https://bugs.webkit.org/show_bug.cgi?id=76095

Only half this change landed

  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
17:00 Changeset [105946] by leviw@chromium.org
  • 273 edits
    7 adds in branches/subpixellayout/LayoutTests

Updating test expectations.

16:54 Changeset [105945] by eric@webkit.org
  • 7 edits in trunk/Tools

webkit-patch apply-* should always continue after failures
https://bugs.webkit.org/show_bug.cgi?id=77057

Reviewed by Adam Barth.

As far as I can tell there is only one potential drawback to always
forcing: that if you're somehow in the wrong directory it will create new
directories for new files. Since webkit-patch always cd's to the root
it seems that's not a drawback. The drawback of not using --force for
svn-apply, is that it will stop after the first failure, which is rarely
(if ever) the desired behavior. This just removes the force option
(which was strangely hidden behind --non-interactive). This should
make for a better user experiance.

  • Scripts/webkitpy/common/checkout/checkout.py:

(Checkout.apply_patch):

  • Scripts/webkitpy/common/checkout/checkout_mock.py:

(MockCheckout.apply_patch):

  • Scripts/webkitpy/common/checkout/checkout_unittest.py:

(CheckoutTest.test_chromium_deps):
(CheckoutTest):
(CheckoutTest.test_apply_patch):

  • Scripts/webkitpy/tool/commands/download_unittest.py:

(DownloadCommandsTest._default_options):

  • Scripts/webkitpy/tool/steps/applypatch.py:

(ApplyPatch.options):
(ApplyPatch.run):

  • Scripts/webkitpy/tool/steps/options.py:

(Options):

16:52 Changeset [105944] by dpranke@chromium.org
  • 2 edits in trunk/Tools

nrwt: should be able to run --platform test interactively
https://bugs.webkit.org/show_bug.cgi?id=76959

Reviewed by Adam Barth.

As part of refactoring the Port interfaces, in r103254 I made
passing a Host object to the Port mandatory; previously TestPort
objects would create their own (mock) hosts. However,
new-run-webkit-tests always passed a real Host, not a MockHost,
and so you couldn't run new-run-webkit-tests --platform test
interactively to debug test failures.

This change fixes that by creating a MockHost instead of a real
host if you say --platform test*.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(main):

16:48 Changeset [105943] by mrowe@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Attempted Mac build fix after r105939.

  • runtime/DatePrototype.cpp: Don't #include unicode/udat.h on Mac or iOS.

It isn't used on these platforms and isn't available in the ICU headers
for Mac.

16:34 Changeset [105942] by mrowe@apple.com
  • 14 edits in trunk/Source

Build in to an alternate location when USE_STAGING_INSTALL_PATH is set.

<rdar://problem/10609417> Adopt USE_STAGING_INSTALL_PATH

Reviewed by David Kilzer.

Source/JavaScriptCore:

  • Configurations/Base.xcconfig: Define NORMAL_JAVASCRIPTCORE_FRAMEWORKS_DIR, which contains

the path where JavaScriptCore is normally installed. Update JAVASCRIPTCORE_FRAMEWORKS_DIR
to point to the staged frameworks directory when USE_STAGING_INSTALL_PATH is set.

  • Configurations/JavaScriptCore.xcconfig: Always set the framework's install name based on

the normal framework location. This prevents an incorrect install name from being used when
installing in to the staged frameworks directory.

Source/ThirdParty:

  • gtest/xcode/Config/ProductionProject.xcconfig: Ensure that the staged frameworks path

is in the framework search path when USE_STAGING_INSTALL_PATH is set. Look for the WebCore
framework in the staged frameworks directory when USE_STAGING_INSTALL_PATH is set.

Source/WebCore:

  • Configurations/WebCore.xcconfig: Define NORMAL_WEBCORE_FRAMEWORKS_DIR, which contains

the path where WebCore is normally installed. Update WEBCORE_FRAMEWORKS_DIR to point to
the staged frameworks directory when USE_STAGING_INSTALL_PATH is set. Define
NORMAL_PRODUCTION_FRAMEWORKS_DIR, which contains the path where our public frameworks
are normally installed. Update PRODUCTION_FRAMEWORKS_DIR to point to the staged frameworks
directory when USE_STAGING_INSTALL_PATH is set. Always set the framework's install name
based on the normal framework location. This prevents an incorrect install name from being
used when installing in to the staged frameworks directory. Look for our other frameworks
in the staged frameworks directory when USE_STAGING_INSTALL_PATH is set.

Source/WebKit/mac:

  • Configurations/WebKit.xcconfig: Define NORMAL_WEBKIT_FRAMEWORKS_DIR, which contains

the path where WebKit is normally installed. Update WEBKIT_FRAMEWORKS_DIR to point to
the staged frameworks directory when USE_STAGING_INSTALL_PATH is set. Define
NORMAL_PRODUCTION_FRAMEWORKS_DIR, which contains the path where our public frameworks
are normally installed. Update PRODUCTION_FRAMEWORKS_DIR to point to the staged frameworks
directory when USE_STAGING_INSTALL_PATH is set. Always set the framework's install name
based on the normal framework location. This prevents an incorrect install name from being
used when installing in to the staged frameworks directory. Look for our other frameworks
in the staged frameworks directory when USE_STAGING_INSTALL_PATH is set. Update
WEBCORE_PRIVATE_HEADERS_DIR to find WebCore at the top level of the staged frameworks
directory when USE_STAGING_INSTALL_PATH is set, rather than finding it embedded inside of
WebKit.framework.

Source/WebKit2:

  • Configurations/BaseTarget.xcconfig: Define NORMAL_WEBKIT2_FRAMEWORKS_DIR, which contains

the path where WebKit is normally installed. Update WEBKIT2_FRAMEWORKS_DIR to point to
the staged frameworks directory when USE_STAGING_INSTALL_PATH is set. Update
UMBRELLA_FRAMEWORKS_DIR so we can find WebCore at the top level of the staged frameworks
directory when USE_STAGING_INSTALL_PATH is set, rather than finding it embedded inside of
WebKit.framework.

  • Configurations/PluginProcess.xcconfig: Set our install path based on WEBKIT2_FRAMEWORKS_DIR.
  • Configurations/WebKit2.xcconfig: Set our install path based on WEBKIT2_FRAMEWORKS_DIR.

Always set the framework's install name based on the normal framework location. This prevents
an incorrect install name from being used when installing in to the staged frameworks directory.

  • Configurations/WebProcess.xcconfig: Set our install path based on WEBKIT2_FRAMEWORKS_DIR.
16:27 Changeset [105941] by eric@webkit.org
  • 5 edits
    1 copy in trunk

"text" and "URL" legacy clipboard types should not be case sensitive
https://bugs.webkit.org/show_bug.cgi?id=76947

Reviewed by Adam Barth.

Source/WebCore:

This matches the HTML5 spec which says the first thing to do is to lowercase
the type before comparing.
I also removed the stripping of whitespace since that is not part of the modern spec (and no tests failed as a result of removal).
Turns out we already had a test for case sensitivity, but it was disabled on Mac
so I just re-enabled it and have added failing expectations for the parts
of the test we still fail.

  • platform/mac/ClipboardMac.mm:

(WebCore::cocoaTypeFromHTMLClipboardType):
(WebCore::ClipboardMac::getData):

LayoutTests:

This test has been disabled on Mac since it was added 2 years ago.
But we actually need to fix at least one of the bugs covered by this
test, so I'm unskipping it and adding failing expectations for the
parts Mac doens't yet pass.

  • platform/mac/Skipped:
  • platform/mac/editing/pasteboard/dataTransfer-setData-getData-expected.txt: Added.
16:17 Changeset [105940] by eric@webkit.org
  • 5 edits in trunk/Source

HTMLIsIndexElement should not expose HTMLInputElement properties
https://bugs.webkit.org/show_bug.cgi?id=76095

Reviewed by Adam Barth.

Source/WebCore:

document.createElement("isindex") should produce an HTMLUnknownElement
per the HTML5 spec. The parser automagically translates <isindex> into
a whole dom tree roughly representing what <isindex> used to do 15 years ago. :)

This patch just removes our support for HTMLIsIndexElement. The parser
support was already in. Having support for HTMLIsIndexElement was causing
one of the IE TestCenter tests to fail.

Test: fast/dom/HTMLIsIndexElement/prototype-chain.html

  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/gobject/GNUmakefile.am:
  • bindings/gobject/WebKitHTMLElementWrapperFactory.cpp:

(WebKit::createHTMLElementWrapper):

  • bindings/objc/DOM.mm:

(WebCore::createElementClassMap):

  • bindings/objc/DOMHTML.h:
  • bindings/objc/PublicDOMInterfaces.h:
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLIsIndexElement.cpp: Removed.
  • html/HTMLIsIndexElement.h: Removed.
  • html/HTMLIsIndexElement.idl: Removed.
  • html/HTMLTagNames.in:
  • page/DOMWindow.idl:

Source/WebKit/mac:

  • MigrateHeaders.make:
16:11 Changeset [105939] by efidler@rim.com
  • 2 edits in trunk/Source/JavaScriptCore

Implement Date.toLocaleString() using ICU
https://bugs.webkit.org/show_bug.cgi?id=76714

Reviewed by Darin Adler.

  • runtime/DatePrototype.cpp:

(JSC::formatLocaleDate):

16:00 Changeset [105938] by eric@webkit.org
  • 5 edits in trunk

HTMLEmbedObject should match HTMLObjectElement by stopping any load when it is removed from beforeload
https://bugs.webkit.org/show_bug.cgi?id=74360

Reviewed by Adam Barth.

Source/WebCore:

Neither of these !renderer() checks is strictly necessary since requestObject()
makes the same check. However requestObject() asserts before it makes that
check, so it makes sense to add the check to HTMLEmebedObject instead of
removing the check from HTMLObjectElement.
I also moved the protect RefPtr to before the beforeload dispatch since
beforeload can remove the whole DOM element (as this test does) and
thus I beleive the renderer() check could be checking free'd memory.

Updated fast/dom/beforeload/remove-flash-in-beforeload-listener.html to test
<embed> as well as <object>.

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::updateWidget):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateWidget):

LayoutTests:

Test <embed> as well as <object> in this test.

  • fast/dom/beforeload/remove-flash-in-beforeload-listener.html:
15:56 Changeset [105937] by tkent@chromium.org
  • 8 edits in trunk/Source/WebCore

Move focus/blur handling code of HTMLInputElement to InputType
https://bugs.webkit.org/show_bug.cgi?id=76984

Reviewed by Dimitri Glazkov.

No new tests. Just a refactoring.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::handleFocusEvent):
Move the code to PasswordInputType::handleFocusEvent().
(WebCore::HTMLInputElement::handleBlurEvent):
Move the code to TextFieldInputType::handleBlurEvent() and
PasswordInputType::handleBlurEvent().

  • html/InputType.cpp:

(WebCore::InputType::handleFocusEvent):

  • html/InputType.h:

(InputType): Add handleFocusEvent().

  • html/PasswordInputType.cpp:

(WebCore::PasswordInputType::handleFocusEvent):
Move the code for type=password from HTMLInputElement::handleFocusEvent().
(WebCore::PasswordInputType::handleBlurEvent):
Move the code for tyep=password from HTMLInputElement::handleBlurEvent().

  • html/PasswordInputType.h:

(PasswordInputType): Add handleFocusEvent() and handleBlurEvent().

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::handleBlurEvent):
Move the code for text field types from HTMLInputElement::handleBlurEvent().

  • html/TextFieldInputType.h:

(TextFieldInputType): Add handleBlurEvent().

15:52 Changeset [105936] by dpranke@chromium.org
  • 4 edits in trunk/Tools

run-webkit-tests --lint-test-files should lint all the ports by default
https://bugs.webkit.org/show_bug.cgi?id=76749

Reviewed by Ojan Vafai.

Currently run-webkit-tests --lint-test-files will only lint the
test_expectations for the single port determined by the command
line options. This is not obvious and can produce unintended results
if you want to lint the chromium port (probably the normal case
for using --lint-test-files) but don't specify a port name or
--chromium.

I think we should probably lint *all* of the ports if no port
name is supplied. This change implements that, and also moves
the linting logic out of the Manager class, since this really
has nothing to do with Managers. It has little to do with
run-webkit-tests, but splitting it into a different script would
introduce compatibility issues. It might make sense to do that
anyway, in a separate patch and combining that with cleaning up
the style checker to share more code.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._strip_test_dir_prefix):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(lint):
(run):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(LintTest.test_all_configurations): added.
(LintTest.test_lint_test_files): added.
(LintTest.test_lint_test_fileserrors): added.
(MainTest.test_lint_test_files): removed.
(MainTest.test_lint_test_files
errors): removed.

15:46 Changeset [105935] by dpranke@chromium.org
  • 7 edits in trunk/Tools

webkitpy: clean up a bunch of test scaffolding
https://bugs.webkit.org/show_bug.cgi?id=76973

Reviewed by Eric Seidel.

There were several helper modules in the webkitpy.test package
that appear to only be used by executive_unittest.py. I am
rolling them all into that file to make that clearer.

  • Scripts/webkitpy/common/system/executive_unittest.py:

(ExecutiveTest.test_run_command_args_type):
(ExecutiveTest.test_run_command_with_unicode):
(ExecutiveTest.test_running_pids):
(command_line):
(main):

  • Scripts/webkitpy/common/system/fileutils.py: Removed.
  • Scripts/webkitpy/test/cat.py: Removed.
  • Scripts/webkitpy/test/cat_unittest.py: Removed.
  • Scripts/webkitpy/test/echo.py: Removed.
  • Scripts/webkitpy/test/echo_unittest.py: Removed.
15:40 Changeset [105934] by noam.rosenthal@nokia.com
  • 3 edits in trunk/Source/WebKit2

[WK2][Qt] REGRESSION: Pages with transform animations sometimes omit some of the layers since r105413
https://bugs.webkit.org/show_bug.cgi?id=76886

Reviewed by Kenneth Rohde Christiansen.

We now render the whole layer if it or one if its ancestors has an active transform
animations. It's possible to optimize further in the future, but not currently necessary.
Also, we make sure that when a WebGraphicsLayer's property that affects transformation is
changed, all its descandants layers are marked as modified so that we re-adjust their
visible rect in the next pass.

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::notifyChangeRecursively):
(WebCore):
(WebCore::WebGraphicsLayer::setPosition):
(WebCore::WebGraphicsLayer::setAnchorPoint):
(WebCore::WebGraphicsLayer::setSize):
(WebCore::WebGraphicsLayer::setTransform):
(WebCore::WebGraphicsLayer::setChildrenTransform):
(WebCore::WebGraphicsLayer::setPreserves3D):
(WebCore::WebGraphicsLayer::setMasksToBounds):
(WebCore::WebGraphicsLayer::addAnimation):
(WebCore::WebGraphicsLayer::removeAnimation):
(WebCore::WebGraphicsLayer::tiledBackingStoreVisibleRect):
(WebCore::WebGraphicsLayer::selfOrAncestorHasActiveTransformAnimations):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:

(WebGraphicsLayer):

15:31 Changeset [105933] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Node.cpp shouldn't duplicate QualifiedName parsing logic
https://bugs.webkit.org/show_bug.cgi?id=76672

Reviewed by Eric Seidel.

I added this code out of ignorance that this logic already existed in
Document.cpp. In a future patch, we should consider moving it to
QualifiedName.cpp.

  • dom/Node.cpp:

(WebCore):
(WebCore::Node::checkSetPrefix):

15:29 Changeset [105932] by eric@webkit.org
  • 5 edits in trunk/Source/WebCore

Share more code between updateWidget implementations in HTMLEmbedElement and HTMLObjectElement
https://bugs.webkit.org/show_bug.cgi?id=74340

Reviewed by Adam Barth.

I'm preparing to unify these two methods, and starting by sharing more code between them.

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::updateWidget):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateWidget):

  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::guardedDispatchBeforeLoadEvent):

  • html/HTMLPlugInElement.h:
15:11 Changeset [105931] by eric@webkit.org
  • 2 edits in trunk/Tools

Remove Python 2.5 support from WebKit
https://bugs.webkit.org/show_bug.cgi?id=71593

Reviewed by Adam Barth.

Just removing support from this one core file.
I'll commit the rest of the (large) change once we've
gone 24 hours and seen that no bots have exploded.
We can roll out this one change if we break bots
and then roll in the rest once those bots are fixed.

  • Scripts/webkitpy/common/system/executive.py:

(Executive.cpu_count):

14:43 Changeset [105930] by ericu@chromium.org
  • 8 edits in trunk/Source

Add full support for filesystem URLs.
https://bugs.webkit.org/show_bug.cgi?id=75049

Reviewed by Adam Barth.

No new tests; existing layout tests cover the basic functionality, and
the new functionality won't be there until Chromium adds it. This patch
merely enables that, without changing behavior.

Source/WebCore:

  • fileapi/EntryBase.cpp:

(WebCore::EntryBase::toURL): Add missing escaping of URL path.

  • page/SecurityOrigin.cpp:

(WebCore::extractInnerURL): Use innerURL member, if it's populated.

  • platform/KURL.h:

(WebCore::KURL::innerURL): Add innerURL member.

  • platform/KURLGoogle.cpp:

(WebCore::KURLGooglePrivate::KURLGooglePrivate):
(WebCore::KURLGooglePrivate::operator=):
Add copy constructor and operator=, which are now needed since
m_innerURL needs special handling.
(WebCore::KURLGooglePrivate::setUtf8):
(WebCore::KURLGooglePrivate::setAscii):
Add calls to initInnerURL.
(WebCore::KURLGooglePrivate::initInnerURL):
Add method to init/copy m_innerURL.
(WebCore::KURLGooglePrivate::copyTo):
Handle m_innerURL during copies.
(WebCore::encodeWithURLEscapeSequences):
Unescape %2F / in paths; it's much more readable, and it's safe.

  • platform/KURLGooglePrivate.h:

(WebCore::KURLGooglePrivate::innerURL): Add accessor for new m_innerURL.

Source/WebKit/chromium:

  • tests/KURLTest.cpp:

TEST(KURLTest, Encode): Update expectation that '/' sails through unescaped.

14:40 Changeset [105929] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[Chromium] Layout Test fast/canvas/webgl/invalid-passed-params.html is failing
https://bugs.webkit.org/show_bug.cgi?id=75784

Reviewed by Kenneth Russell.

Passing on ToT chromium.org, webkit.org (GPU and non-GPU), rebaseline this test.

  • platform/chromium/test_expectations.txt:
14:33 Changeset [105928] by dcheng@chromium.org
  • 4 edits in trunk/Source/WebCore

[chromium] Refactor Clipboard invalidate for DataTransferItem/DataTransferItemList into a wrapper
https://bugs.webkit.org/show_bug.cgi?id=76993

We want to unify the backing data store for ClipboardChromium and DataTransferItems. For
that, we want use a similar representation to DataTransferItem list inside
ChromiumDataObject. However, since ChromiumDataObject should be valid in scopes where
Clipboard is not (e.g. default drag processing), we need to separate the clipboard
invalidation logic into a wrapper class.

Reviewed by Tony Chang.

Covered by existing tests.

  • platform/chromium/ClipboardChromium.cpp:

():
(WebCore::ClipboardChromium::items):

  • platform/chromium/DataTransferItemChromium.cpp:

(WebCore::DataTransferItemChromium::getAsString):

  • platform/chromium/DataTransferItemListChromium.cpp:

(WebCore::DataTransferItemListChromium::length):
(WebCore::DataTransferItemListChromium::item):
(WebCore::DataTransferItemListChromium::deleteItem):
(WebCore::DataTransferItemListChromium::clear):
(WebCore::DataTransferItemListChromium::add):

14:29 Changeset [105927] by eae@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/platform/graphics/qt/GraphicsContextQt.cpp

Build fix for qt

14:25 Changeset [105926] by rniwa@webkit.org
  • 3 edits in trunk/PerformanceTests

html5-full-render.html fails due to a log
https://bugs.webkit.org/show_bug.cgi?id=77046

Reviewed by Adam Barth.

Replace the call to log() in html5-full-render.html by a call to newly added logInfo(),
which doesn't print anything inside DRT.

  • Parser/html5-full-render.html:
  • resources/runner.js:

(logInfo):

14:13 Changeset [105925] by noam.rosenthal@nokia.com
  • 8 edits
    2 adds in trunk/Source/WebCore

[Texmap] Divide TextureMapperNode.cpp to 3 files.
https://bugs.webkit.org/show_bug.cgi?id=76660

Reviewed by Kenneth Rohde Christiansen.

Split the animation part of TextureMapperNode out to a separate file, called
TextureMapperAnimation.
Provide a clean interface for that class, that allows separating the internals of the scene
painting from the internals of the animation interpolation.

No new tests. Existing animation tests cover this.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::addAnimation):
(WebCore::GraphicsLayerTextureMapper::pauseAnimation):
(WebCore::GraphicsLayerTextureMapper::removeAnimation):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:

(GraphicsLayerTextureMapper):

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::syncCompositingStateSelf):
(WebCore::TextureMapperNode::descendantsOrSelfHaveRunningAnimations):
(WebCore::TextureMapperNode::syncAnimations):
(WebCore::TextureMapperNode::syncAnimationsRecursively):
(WebCore::TextureMapperNode::syncCompositingState):

  • platform/graphics/texmap/TextureMapperNode.h:

(TextureMapperNode):

14:11 Changeset [105924] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test http/tests/workers/terminate-during-sync-operation.html times out frequently on Win DBG
https://bugs.webkit.org/show_bug.cgi?id=77047

Unreviewed. Marking http/tests/workers/terminate-during-sync-operation.html as flaky (timeout) on Chromium Win DBG

  • platform/chromium/test_expectations.txt:
14:00 Changeset [105923] by knorton@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed expectation update after r105613.

  • platform/chromium-mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.png:
13:46 Changeset [105922] by commit-queue@webkit.org
  • 27 edits in trunk

ENABLE_SHADOW_DOM should be available via build-webkit --shadow-dom
https://bugs.webkit.org/show_bug.cgi?id=76863

.:

Patch by Hajime Morita <morrita@google.com>> on 2012-01-25
Reviewed by Dimitri Glazkov.

Added a feature flag.

  • Source/cmake/OptionsBlackBerry.cmake:
  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsWinCE.cmake:
  • configure.ac:

Source/JavaScriptCore:

Patch by Hajime Morita <morrita@google.com> on 2012-01-25
Reviewed by Dimitri Glazkov.

Added a feature flag.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Patch by Hajime Morita <morrita@google.com> on 2012-01-25
Reviewed by Dimitri Glazkov.

Added a feature flag.

No tests, it's a behid flag configuration change.

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit/mac:

Patch by Hajime Morita <morrita@google.com> on 2012-01-25
Reviewed by Dimitri Glazkov.

Added a feature flag.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Patch by Hajime Morita <morrita@google.com> on 2012-01-25
Reviewed by Dimitri Glazkov.

Added a feature flag.

  • Configurations/FeatureDefines.xcconfig:

Tools:

Patch by Hajime Morita <morrita@google.com> on 2012-01-25
Reviewed by Dimitri Glazkov.

Added a feature flag.

  • Scripts/build-webkit:
  • qmake/mkspecs/features/features.prf:

WebKitLibraries:

Patch by Hajime Morita <morrita@google.com>> on 2012-01-25
Reviewed by Dimitri Glazkov.

Added a feature flag.

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
13:09 Changeset [105921] by leviw@chromium.org
  • 1 edit
    7 adds
    2 deletes in trunk/LayoutTests

[Chromium]: rebaseline after r105878
https://bugs.webkit.org/show_bug.cgi?id=77017

Unreviewed Chromium image expectations update.

Not updating test_expectations because I am not sure that the rebaselining tool did
the right thing.

Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-25

  • platform/chromium-linux-x86/svg/custom/zero-path-square-cap-rendering-expected.txt: Added.
  • platform/chromium-linux/svg/custom/zero-path-square-cap-rendering-expected.txt: Added.
  • platform/chromium-linux/svg/stroke/zero-length-path-linecap-rendering-expected.png: Added.
  • platform/chromium-linux/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/zero-path-square-cap-rendering-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/custom/zero-path-square-cap-rendering-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/zero-path-square-cap-rendering-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/stroke/zero-length-path-linecap-rendering-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Added.
  • platform/chromium-mac/svg/custom/zero-path-square-cap-rendering-expected.png: Removed.
  • platform/chromium-win-vista/svg/custom/zero-path-square-cap-rendering-expected.txt: Added.
  • platform/chromium-win-xp/svg/custom/zero-path-square-cap-rendering-expected.txt: Added.
  • platform/chromium-win/svg/custom/zero-path-square-cap-rendering-expected.png: Added.
  • platform/chromium-win/svg/custom/zero-path-square-cap-rendering-expected.txt: Added.
  • platform/chromium-win/svg/stroke/zero-length-path-linecap-rendering-expected.png: Added.
  • platform/chromium-win/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Added.
  • platform/chromium/svg/custom/subpaths-moveto-only-rendering-expected.txt: Added.
13:06 Changeset [105920] by leviw@chromium.org
  • 6 edits in trunk

Unreviewed, rolling out r105906.
http://trac.webkit.org/changeset/105906
https://bugs.webkit.org/show_bug.cgi?id=77038

Breaks compositing/visibility/layer-visible-content.html and
compositing/visibility/visibility-image-layers-dynamic.html
(Requested by leviw|gardening on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-25

Source/WebCore:

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

LayoutTests:

  • compositing/visibility/layer-visible-content-expected.txt:
  • compositing/visibility/visibility-image-layers-dynamic-expected.txt:
  • platform/chromium/test_expectations.txt:
12:57 Changeset [105919] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Page Up and Page Down mappings are backwards on BlackBerry port.
https://bugs.webkit.org/show_bug.cgi?id=77021

Fix Page Up and Page Down mappings as they are reversed.

Patch by Mike Fenton <mifenton@rim.com> on 2012-01-25
Reviewed by Antonio Gomes.

  • platform/blackberry/PlatformKeyboardEventBlackBerry.cpp:

(WebCore::keyIdentifierForBlackBerryCharacter):
(WebCore::windowsKeyCodeForBlackBerryCharacter):

12:52 Changeset [105918] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[BlackBerry] Implement OSAllocator::commit/decommit.
BlackBerry port should support virtual memory decommiting.
https://bugs.webkit.org/show_bug.cgi?id=77013

Patch by Yong Li <yoli@rim.com> on 2012-01-25
Reviewed by Rob Buis.

  • wtf/OSAllocatorPosix.cpp:

(WTF::OSAllocator::reserveUncommitted):
(WTF::OSAllocator::commit):
(WTF::OSAllocator::decommit):

  • wtf/Platform.h:
12:47 Changeset [105917] by morrita@google.com
  • 19 edits
    5 adds in trunk

<content> should create HTMLContentElement object
https://bugs.webkit.org/show_bug.cgi?id=76439

Reviewed by Dimitri Glazkov.

Source/WebCore:

  • Added HTMLContentElement.idl which has @select attribute.
  • Added "content" element.

Both are behind ENABLE_SHADOW_DOM.

Tests: fast/dom/shadow/content-element-api.html

fast/dom/shadow/content-element-outside-shadow.html

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLTagNames.in:
  • html/shadow/HTMLContentElement.cpp:

(WebCore::contentTagName):
(WebCore):
(WebCore::HTMLContentElement::create):

  • html/shadow/HTMLContentElement.h:

(HTMLContentElement):

  • html/shadow/HTMLContentElement.idl: Added.

LayoutTests:

Ensure that contnet elements are renderered not only inside the shadow tree
but also the outside that.

  • fast/dom/shadow/content-element-api-expected.txt: Added.
  • fast/dom/shadow/content-element-api.html: Added.
  • fast/dom/shadow/content-element-outside-shadow-expected.txt: Added.
  • fast/dom/shadow/content-element-outside-shadow.html: Added.
  • platform/efl/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
  • platform/win/Skipped:
12:37 Changeset [105916] by mrobinson@webkit.org
  • 4 edits in trunk

[WK2] Navigation events not triggered by a mouse event claim to be triggered by the left mouse button during policy decisions
https://bugs.webkit.org/show_bug.cgi?id=76344

Reviewed by Sam Weinig.

Source/WebKit2:

When creating InjectedBundleNavigationActions, initialize the mouse button to NoButton.
This ensures that when there is no mouse event associated with the action, when the event
hits the client-API layer, the button is still NoButton.

  • WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp:

(WebKit::InjectedBundleNavigationAction::InjectedBundleNavigationAction): Initialize m_mouseButton
to WebMouseEvent::NoButton.

Tools:

Add a test verifying that the mouse button during policy decisions for
events not triggered by mouse events is NoButton.

  • TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:

(TestWebKitAPI::decidePolicyForNavigationAction): Added test.
(TestWebKitAPI::decidePolicyForNewWindowAction): Added test.

12:29 Changeset [105915] by rniwa@webkit.org
  • 3 edits in trunk/Tools

run-perf-tests should timeout sooner
https://bugs.webkit.org/show_bug.cgi?id=77026

Reviewed by Adam Barth.

Bump off the timeout from 10 minutes to 4 minutes.

Also use float instead of str in test result values to compress the size of json files bots upload.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._parse_args):
(PerfTestsRunner._process_chromium_style_test_result):
(PerfTestsRunner._process_parser_test_result):

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(test_run_test_set_for_parser_tests):
(test_run_test_set_with_json_output):
(test_run_test_set_with_json_source):

12:28 Changeset [105914] by eae@chromium.org
  • 20 edits
    1 delete in branches/subpixellayout/Source

Revert unwanted changes against trunk caused by incorrect merge conflict resolution.

12:27 Changeset [105913] by kareng@chromium.org
  • 1 add in branches/chromium/1018/codereview.settings

adding codereview.settings

12:22 Changeset [105912] by kareng@chromium.org
  • 1 copy in branches/chromium/1018

testing branching for chrome.

12:21 Changeset [105911] by rniwa@webkit.org
  • 4 edits
    2 deletes in trunk

Unreviewed, rolling out r105828.
http://trac.webkit.org/changeset/105828
https://bugs.webkit.org/show_bug.cgi?id=77036

Caused many crashes in ClusterFuzz and PerformanceTests
(Requested by inferno-sec on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-25

Source/WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeChild):

  • rendering/RenderBlock.h:

(RenderBlock):

LayoutTests:

  • fast/css-generated-content/float-first-letter-siblings-convert-to-inline-expected.txt: Removed.
  • fast/css-generated-content/float-first-letter-siblings-convert-to-inline.html: Removed.
12:21 Changeset [105910] by kareng@chromium.org
  • 1 copy in branches/1018

testing ability to branch for chrome

12:13 Changeset [105909] by kerz@chromium.org
  • 376 edits
    454 copies in branches/chromium/963/LayoutTests/platform

Merge 103884 - [Chromium] Unreviewed test expectations update after r103875.
https://bugs.webkit.org/show_bug.cgi?id=74888

  • platform/chromium-cg-mac-leopard/fast/dom/HTMLTableElement/colSpan-expected.png: Added.
  • platform/chromium-cg-mac-leopard/fast/dom/HTMLTableElement/createCaption-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug1163-1-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug119786-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug1302-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug222846-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug29058-3-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug48028-1-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug48028-2-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug5838-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug6304-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug8381-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/core/captions-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/backgr_layers-opacity-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/backgr_position-table-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/backgr_simple-table-cell-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/backgr_simple-table-column-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/backgr_simple-table-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/backgr_simple-table-row-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/table_frame_border-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/table_frame_box-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/table_rules_all-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/table_rules_none-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/tables_caption_align_bot-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/tables_caption_align_top-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/x_caption_align_bottom-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/x_caption_align_top-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/x_caption_class-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/x_caption_id-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla/marvin/x_caption_style-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug10140-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug10216-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug104898-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug106966-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug29058-2-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-11-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-12-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-13-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-14-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-16-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-17-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-3-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-4-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-5-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug91057-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/core/captions3-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.png: Added.
  • platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-cg-mac-snowleopard/fast/css/bidi-override-in-anonymous-block-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/fast/css/caption-width-absolute-position-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/css/caption-width-absolute-position-offset-top-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/css/caption-width-fixed-position-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/css/caption-width-fixed-position-offset-top-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/css/caption-width-relative-position-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/css/caption-width-relative-position-offset-top-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/dom/HTMLTableElement/colSpan-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/dom/HTMLTableElement/colSpan-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/fast/dom/HTMLTableElement/createCaption-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/fast/dom/HTMLTableElement/createCaption-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/fast/table/frame-and-rules-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug1163-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug1163-1-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug119786-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug119786-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug1302-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug1302-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug222846-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug222846-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug29058-3-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug29058-3-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug29157-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug48028-1-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug48028-1-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug48028-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug48028-2-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug5838-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug5838-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug6304-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug6304-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug8381-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug8381-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/core/captions-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/core/captions-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_layers-opacity-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_layers-opacity-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_position-table-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_position-table-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-cell-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-column-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-column-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-row-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-row-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/table_frame_border-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/table_frame_border-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/table_frame_box-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/table_frame_box-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/table_rules_all-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/table_rules_all-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/table_rules_none-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/table_rules_none-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/tables_caption_align_bot-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/tables_caption_align_bot-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/tables_caption_align_top-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/tables_caption_align_top-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/x_caption_align_bottom-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/x_caption_align_bottom-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/x_caption_align_top-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/x_caption_align_top-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/x_caption_class-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/x_caption_class-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/x_caption_id-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/x_caption_id-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/x_caption_style-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/marvin/x_caption_style-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla/other/wa_table_tr_align-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug10140-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug10140-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug10216-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug10216-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug104898-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug104898-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug106966-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug106966-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug29058-2-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-11-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-11-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-12-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-12-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-13-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-13-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-14-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-14-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-16-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-16-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-17-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-17-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-3-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-3-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-4-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-4-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-5-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-5-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-6-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-9-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug91057-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug91057-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/core/captions3-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/core/captions3-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.png: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.txt: Added.
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.txt: Added.
  • platform/chromium-linux/fast/dom/HTMLTableElement/colSpan-expected.png:
  • platform/chromium-linux/fast/dom/HTMLTableElement/createCaption-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1163-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug119786-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1302-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug222846-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug29058-3-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug48028-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug48028-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug5838-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug6304-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug8381-expected.png:
  • platform/chromium-linux/tables/mozilla/core/captions-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_position-table-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-cell-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/table_frame_border-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/table_frame_box-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/table_rules_all-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/table_rules_none-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_caption_align_bot-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/tables_caption_align_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_caption_align_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_caption_align_top-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_caption_class-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_caption_id-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_caption_style-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug10140-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug10216-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug104898-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug106966-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug29058-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3166-11-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3166-12-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3166-13-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3166-14-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3166-16-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3166-17-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3166-3-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3166-4-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3166-5-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug91057-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions3-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-mac-leopard/fast/dom/HTMLTableElement/colSpan-expected.png:
  • platform/chromium-mac-leopard/fast/dom/HTMLTableElement/createCaption-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1163-1-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug119786-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1302-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug222846-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug29058-3-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug48028-1-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug48028-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug5838-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug6304-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug8381-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/core/captions-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/backgr_position-table-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/backgr_simple-table-cell-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/backgr_simple-table-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/table_frame_border-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/table_frame_box-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/table_rules_all-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/table_rules_none-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tables_caption_align_bot-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/tables_caption_align_top-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_caption_align_bottom-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_caption_align_top-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_caption_class-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_caption_id-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_caption_style-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug10140-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug10216-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug104898-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug106966-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug29058-2-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-11-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-12-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-13-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-14-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-16-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-17-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-3-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-4-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-5-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug91057-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/core/captions3-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/bidi-override-in-anonymous-block-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/caption-width-absolute-position-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/caption-width-absolute-position-offset-top-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/caption-width-fixed-position-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/caption-width-fixed-position-offset-top-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/caption-width-relative-position-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/caption-width-relative-position-offset-top-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLTableElement/colSpan-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLTableElement/colSpan-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLTableElement/createCaption-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLTableElement/createCaption-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/table/frame-and-rules-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1163-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1163-1-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug119786-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug119786-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1302-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1302-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug222846-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug222846-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug29058-3-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug29058-3-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug29157-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug48028-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug48028-1-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug48028-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug48028-2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug5838-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug5838-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug6304-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug6304-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug8381-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug8381-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/core/captions-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/core/captions-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_layers-opacity-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_layers-opacity-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_position-table-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_position-table-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-cell-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-column-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-column-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-row-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-row-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/table_frame_border-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/table_frame_border-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/table_frame_box-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/table_frame_box-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/table_rules_all-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/table_rules_all-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/table_rules_none-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/table_rules_none-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tables_caption_align_bot-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tables_caption_align_bot-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tables_caption_align_top-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/tables_caption_align_top-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_caption_align_bottom-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_caption_align_bottom-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_caption_align_top-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_caption_align_top-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_caption_class-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_caption_class-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_caption_id-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_caption_id-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_caption_style-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_caption_style-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/other/wa_table_tr_align-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug10140-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug10140-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug10216-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug10216-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug104898-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug104898-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug106966-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug106966-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug29058-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-11-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-11-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-12-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-12-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-13-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-13-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-14-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-14-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-16-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-16-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-17-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-17-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-3-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-3-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-4-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-4-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-5-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-5-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-6-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug3166-9-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug91057-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug91057-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/core/captions3-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/core/captions3-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.txt: Added.
  • platform/chromium-win/fast/css/bidi-override-in-anonymous-block-expected.txt:
  • platform/chromium-win/fast/css/caption-width-absolute-position-expected.png: Added.
  • platform/chromium-win/fast/css/caption-width-absolute-position-offset-top-expected.png: Added.
  • platform/chromium-win/fast/css/caption-width-fixed-position-expected.png: Added.
  • platform/chromium-win/fast/css/caption-width-fixed-position-offset-top-expected.png: Added.
  • platform/chromium-win/fast/css/caption-width-relative-position-expected.png: Added.
  • platform/chromium-win/fast/css/caption-width-relative-position-offset-top-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLTableElement/colSpan-expected.png:
  • platform/chromium-win/fast/dom/HTMLTableElement/colSpan-expected.txt:
  • platform/chromium-win/fast/dom/HTMLTableElement/createCaption-expected.png:
  • platform/chromium-win/fast/dom/HTMLTableElement/createCaption-expected.txt:
  • platform/chromium-win/fast/repaint/table-section-repaint-expected.txt: Added.
  • platform/chromium-win/fast/table/frame-and-rules-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug1163-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1163-1-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug119786-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug119786-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug1302-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1302-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug222846-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug222846-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug29058-3-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug29058-3-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug29157-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug48028-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug48028-1-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug48028-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug48028-2-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug5838-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug5838-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug6304-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug6304-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug8381-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug8381-expected.txt:
  • platform/chromium-win/tables/mozilla/core/captions-expected.png:
  • platform/chromium-win/tables/mozilla/core/captions-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/backgr_position-table-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_position-table-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-cell-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/table_frame_border-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/table_frame_border-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/table_frame_box-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/table_frame_box-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/table_rules_all-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/table_rules_all-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/table_rules_none-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/table_rules_none-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/tables_caption_align_bot-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_caption_align_bot-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/tables_caption_align_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tables_caption_align_top-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_align_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_align_bottom-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_align_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_align_top-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_class-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_class-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_id-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_id-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_style-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_caption_style-expected.txt:
  • platform/chromium-win/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
  • platform/chromium-win/tables/mozilla/other/wa_table_tr_align-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug10140-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug10216-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug10216-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug104898-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug104898-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug106966-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug29058-2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-11-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-11-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-12-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-12-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-13-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-13-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-14-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-14-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-16-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-16-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-17-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-17-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-3-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-3-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-4-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-4-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-5-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-5-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-6-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3166-9-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug91057-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/core/captions1-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/core/captions1-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/core/captions2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/core/captions2-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/core/captions3-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/core/captions3-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/other/test4-expected.txt:
  • platform/chromium/test_expectations.txt:

TBR=mnaganov@chromium.org

12:07 Changeset [105908] by enrica@apple.com
  • 5 edits in trunk

WebView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
https://bugs.webkit.org/show_bug.cgi?id=76951
<rdar://problem/9325158>

Reviewed by Alexey Proskuryakov.

Source/WebKit/mac:

  • WebView/WebHTMLView.mm: Removed typingAttributes implementation.
  • WebView/WebView.mm:

(-[WebView typingAttributes]): Added.

Tools:

  • TestWebKitAPI/Tests/mac/InspectorBar.mm: Modified to reflect the changes to WebView

and WebHTMLView.
(TestWebKitAPI::TEST):

12:03 Changeset [105907] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

This test is actually flaky by timing out, not by failing.

  • platform/chromium/test_expectations.txt:
11:53 Changeset [105906] by shawnsingh@chromium.org
  • 6 edits in trunk

Fix the semantics of passing contentsVisible flag to GraphicsLayers
https://bugs.webkit.org/show_bug.cgi?id=76975

Reviewed by Simon Fraser.

Source/WebCore:

This patch is covered by existing tests, in particular
compositing/visibility/layer-visible-content.html; its
expectations are rebaselined.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

LayoutTests:

  • compositing/visibility/layer-visible-content-expected.txt: rebaselined expectations.
  • compositing/visibility/visibility-image-layers-dynamic-expected.txt: rebaselined expectations.
  • platform/chromium/test_expectations.txt: removed the expectation that the test fails on chromium, it should pass now.
11:43 Changeset [105905] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Make DFG update topCallFrame
https://bugs.webkit.org/show_bug.cgi?id=76969

Reviewed by Filip Pizlo.

Add NativeCallFrameTracer to manage topCallFrame assignment
in the DFG operations, and make use of it.

  • dfg/DFGOperations.cpp:

(JSC::DFG::operationPutByValInternal):
():

  • interpreter/Interpreter.h:

(JSC):
(NativeCallFrameTracer):
(JSC::NativeCallFrameTracer::NativeCallFrameTracer):

11:42 Changeset [105904] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed test fix to followup r105900.

  • compositing/overflow/overflow-scaled-descendant-overlapping.html:
11:27 Changeset [105903] by tony@chromium.org
  • 6 edits
    2 adds in trunk

support overflow:auto and overflow:scroll in new flexbox
https://bugs.webkit.org/show_bug.cgi?id=76953

Reviewed by David Hyatt.

Source/WebCore:

Tests: css3/flexbox/flexbox-overflow-auto-expected.html

css3/flexbox/flexbox-overflow-auto.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::addLayoutOverflow): In the case of reverse flexboxen, we can overflow up or to the left (like horizontal-bt or rtl content).

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock): Call updateScrollInfoAfterLayout() to add overflow scrollbars.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): In row-reverse, offset the start of the content by the scrollbar.
(WebCore::RenderFlexibleBox::layoutColumnReverse): In column-reverse, offset the start of the content by the scrollbar.

  • rendering/RenderFlexibleBox.h:

(RenderFlexibleBox): Make isHorizontalFlow public.

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyleBitfields::isReverseFlexDirection): Convenience method.

LayoutTests:

  • css3/flexbox/flexbox-overflow-auto-expected.html: Added.
  • css3/flexbox/flexbox-overflow-auto.html: Added.
11:13 Changeset [105902] by leviw@chromium.org
  • 6 edits
    2 deletes in trunk

Unreviewed, rolling out r105885.
http://trac.webkit.org/changeset/105885
https://bugs.webkit.org/show_bug.cgi?id=77027

Causes assertions in Position. (Requested by leviw|gardening
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-25

Source/WebCore:

  • dom/Position.cpp:

(WebCore::Position::upstream):
(WebCore::Position::downstream):

  • dom/PositionIterator.cpp:
  • dom/PositionIterator.h:

(PositionIterator):

  • editing/htmlediting.cpp:

(WebCore::nextCandidate):
(WebCore::nextVisuallyDistinctCandidate):
(WebCore::previousCandidate):
(WebCore::previousVisuallyDistinctCandidate):

LayoutTests:

  • perf/selection-skip-hidden-node-expected.txt: Removed.
  • perf/selection-skip-hidden-node.html: Removed.
11:11 Changeset [105901] by alexis.menard@openbossa.org
  • 9 edits
    2 adds in trunk

border-image should be implemented like a shorthand.
https://bugs.webkit.org/show_bug.cgi?id=76697

Reviewed by Tony Chang.

Source/WebCore:

Make sure that border-image is implemented like a shorthand : when we parse
it we set the correct value to its longhands. The code was not doing it
previously as we inherited the old implementation of -webkit-border-image which
is not a shorthand but a regular property. It will then increase
style.length for a given element as we now expand the longhands.
The behavior stays the same for -webkit-border-image.

Test: fast/css/border-image-style-length.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::BorderImageParseContext::BorderImageParseContext):
(WebCore::BorderImageParseContext::commitWebKitBorderImage):
(WebCore::BorderImageParseContext::commitBorderImage):
(BorderImageParseContext):
(WebCore::BorderImageParseContext::commitBorderImageProperty):
(WebCore::CSSParser::parseBorderImage):

  • css/CSSParser.h:

():

  • css/CSSPropertyLonghand.cpp:

(WebCore::initShorthandMap):

  • css/CSSStyleApplyProperty.cpp:

():
(WebCore::ApplyPropertyExpanding::applyInheritValue):
(WebCore::ApplyPropertyExpanding::applyInitialValue):
(WebCore::ApplyPropertyExpanding::applyValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInitialValue):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::mapNinePieceImage):

  • page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::ensurePropertyMap):
(WebCore::addShorthandProperties):

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyleBitfields::borderImageSlices):
(WebCore::RenderStyleBitfields::borderImageWidth):
(WebCore::RenderStyleBitfields::borderImageOutset):
(RenderStyleBitfields):
(WebCore::RenderStyleBitfields::setBorderImageSlices):
(WebCore::RenderStyleBitfields::setBorderImageWidth):
(WebCore::RenderStyleBitfields::setBorderImageOutset):

LayoutTests:

Make sure we cover that border-image correctly expands its longhands.

  • fast/css/border-image-style-length-expected.txt: Added.
  • fast/css/border-image-style-length.html: Added.
11:04 Changeset [105900] by morrita@google.com
  • 66 edits
    3 adds in trunk

[Refactoring][Internals] Should have InternalSettings
https://bugs.webkit.org/show_bug.cgi?id=76424

Source/WebCore:

Reviewed by Kent Tamura.

This change extracted setting related method from window.internals
to window.internals.settings object.

  • Invoked Internals::reset() in the constructor to employ Document object.
  • Moved setting and configuration related Internals methods to newly introduced InternalSettings object.

No new tests, covered by existing tests.

  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.vcproj/WebCoreTestSupport.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • testing/InternalSettings.cpp: Added.

(WebCore::InternalSettings::create):
(WebCore::InternalSettings::~InternalSettings):
(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::settings):
(WebCore::InternalSettings::document):
(WebCore::InternalSettings::page):
(WebCore::InternalSettings::setInspectorResourcesDataSizeLimits):
(WebCore::InternalSettings::setForceCompositingMode):
(WebCore::InternalSettings::setAcceleratedFiltersEnabled):
(WebCore::InternalSettings::setEnableCompositingForFixedPosition):
(WebCore::InternalSettings::setEnableCompositingForScrollableFrames):
(WebCore::InternalSettings::setAcceleratedDrawingEnabled):
(WebCore::InternalSettings::setEnableScrollAnimator):
(WebCore::InternalSettings::setZoomAnimatorTransform):
(WebCore::InternalSettings::setZoomParameters):
(WebCore::InternalSettings::setMockScrollbarsEnabled):
(WebCore::InternalSettings::setPasswordEchoEnabled):
(WebCore::InternalSettings::setPasswordEchoDurationInSeconds):
(WebCore::InternalSettings::setShouldLayoutFixedElementsRelativeToFrame):
(WebCore::InternalSettings::setUnifiedTextCheckingEnabled):
(WebCore::InternalSettings::unifiedTextCheckingEnabled):
(WebCore::InternalSettings::pageScaleFactor):
(WebCore::InternalSettings::setPageScaleFactor):
(WebCore::InternalSettings::setPerTileDrawingEnabled):

  • testing/InternalSettings.h: Added.
  • testing/InternalSettings.idl: Added.
  • testing/Internals.cpp:

(WebCore::Internals::create):
(WebCore::Internals::Internals):
(WebCore::Internals::reset):

  • testing/Internals.h:

(WebCore::Internals::settings):

  • testing/Internals.idl:
  • testing/js/WebCoreTestSupport.cpp:

(WebCoreTestSupport::injectInternalsObject):

  • testing/v8/WebCoreTestSupport.cpp:

(WebCoreTestSupport::injectInternalsObject):

Tools:

Reviewed by Kent Tamura.

  • GNUmakefile.am: Added so new files.

LayoutTests:

Updated to follow API receiver change.

Reviewed by Kent Tamura.

  • compositing/geometry/fixed-position-composited-page-scale-down.html:
  • compositing/geometry/fixed-position-composited-page-scale.html:
  • compositing/geometry/fixed-position-composited-switch.html:
  • compositing/geometry/fixed-position-iframe-composited-page-scale-down.html:
  • compositing/geometry/fixed-position-iframe-composited-page-scale.html:
  • compositing/geometry/fixed-position-transform-composited-page-scale-down.html:
  • compositing/geometry/fixed-position-transform-composited-page-scale.html:
  • compositing/iframes/resources/scrollgrandchild-inner.html:
  • compositing/resources/mock_scrollbars.js:
  • compositing/scaling/tiled-layer-recursion.html:
  • editing/input/resources/password-echo.js:

(init):

  • editing/spelling/spellcheck-async-mutation.html:
  • editing/spelling/spellcheck-async.html:
  • editing/spelling/spelling-unified-emulation.html:
  • fast/dom/Element/scale-page-bounding-client-rect.html:
  • fast/dom/Element/scale-page-client-rects.html:
  • fast/dom/Range/scale-page-bounding-client-rect.html:
  • fast/dom/Range/scale-page-client-rects.html:
  • fast/dom/iframe-inner-size-scaling.html:
  • fast/dom/window-inner-size-scaling.html:
  • fast/events/scale-and-scroll-body.html:
  • fast/events/scale-and-scroll-iframe-body.html:
  • fast/events/scale-and-scroll-iframe-window.html:
  • fast/events/scale-and-scroll-window.html:
  • fast/events/script-tests/page-scaled-mouse-click-iframe.js:

(iframeLoaded):

  • fast/events/script-tests/page-scaled-mouse-click.js:
  • fast/events/scroll-in-scaled-page-with-overflow-hidden.html:
  • fast/events/touch/page-scaled-touch-gesture-click.html:
  • fast/frames/frame-set-rotation-hit.html:
  • fast/frames/frame-set-scaling-hit.html:
  • fast/frames/iframe-double-scale-contents.html:
  • fast/repaint/background-scaling.html:
  • fast/repaint/fixed-in-page-scale.html:
  • fast/repaint/fixed-right-bottom-in-page-scale.html:
  • fast/repaint/fixed-right-in-page-scale.html:
  • fast/repaint/scale-page-shrink.html:
  • fast/transforms/selection-bounds-in-transformed-view.html:
  • http/tests/inspector/network-test.js:

(resetInspectorResourcesData):

  • http/tests/inspector/network/network-content-replacement-embed.html:
  • http/tests/inspector/network/network-content-replacement-xhr.html:
  • platform/chromium/compositing/accelerated-drawing/alpha.html:
  • platform/chromium/compositing/accelerated-drawing/svg-filters.html:
  • platform/chromium/compositing/force-compositing-mode/force-composite-empty.html:
  • platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer.html:
  • platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html:
  • platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing.html:
  • platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer.html:
  • platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing.html:
10:55 Changeset [105899] by toyoshim@chromium.org
  • 2 edits in trunk/Tools

webkitpy: new-run-webkit-websocket is broken
https://bugs.webkit.org/show_bug.cgi?id=76999

Reviewed by Dirk Pranke.

r105674 broke new-run-webkit-websocket, since options.chromium
doesn't exist any more. new-run-webkit-httpd was also broken
and already fixed at r105835.

  • Scripts/new-run-webkit-websocketserver:

(main):

10:54 Changeset [105898] by alexis.menard@openbossa.org
  • 4 edits
    2 adds in trunk

border-image should not crash when the source is not specified.
https://bugs.webkit.org/show_bug.cgi?id=77001

Reviewed by Andreas Kling.

Source/WebCore:

This bug was introduced by r105502 but was exposed by r105738.
The image-source of a border-image is not mandatory therefore it
may happen that you have no value set for it. WebCore::createBorderImageValue
was wrongly assuming that the image is always set. This problem also required a bit
of refactoring in CSSStyleSelector::mapNinePieceImage to take into account that
the image could be optional (just like other properties).

Test: fast/css/border-image-null-image-crash.html

  • css/CSSBorderImage.cpp:

(WebCore::createBorderImageValue):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::mapNinePieceImage):

LayoutTests:

Add a new test to cover this crash specifically.

  • fast/css/border-image-null-image-crash-expected.txt: Added.
  • fast/css/border-image-null-image-crash.html: Added.
10:38 Changeset [105897] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/qt

[Qt] public.pri is missing dependency to quick module.
https://bugs.webkit.org/show_bug.cgi?id=77016

Patch by Zeno Albisser <zeno@webkit.org> on 2012-01-25
Reviewed by Tor Arne Vestbø.

  • declarative/public.pri:
10:34 Changeset [105896] by tony@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, only skip scrollbars/scroll-rtl-or-bt-layer.html on qt-wk2.
eventSender.mouseScrollBy is implemented on GTK+ and Mac.

  • platform/qt-wk2/Skipped:
  • platform/wk2/Skipped:
10:31 Changeset [105895] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium]: rebaseline after r105878
https://bugs.webkit.org/show_bug.cgi?id=77017

Unreviewed Chromium test expectations update to allow more failure modes.

Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-25

  • platform/chromium/test_expectations.txt:
10:27 Changeset [105894] by fpizlo@apple.com
  • 4 edits
    3 adds in trunk

Inlining breaks call frame walking when the walking is done from outside the inlinee,
but inside a code block that had inlining
https://bugs.webkit.org/show_bug.cgi?id=76978
<rdar://problem/10720904>

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::codeOriginForReturn):

  • interpreter/CallFrame.cpp:

(JSC::CallFrame::trueCallerFrame):

LayoutTests:

  • fast/js/dfg-inline-arguments-use-from-uninlined-code-expected.txt: Added.
  • fast/js/dfg-inline-arguments-use-from-uninlined-code.html: Added.
  • fast/js/script-tests/dfg-inline-arguments-use-from-uninlined-code.js: Added.

(foo):
(fuzz):
(bar):
(baz):

10:18 Changeset [105893] by kenneth@webkit.org
  • 13 edits
    5 adds in trunk

[Qt] Implement tap feedback respecting -webkit-tap-highlight-color
https://bugs.webkit.org/show_bug.cgi?id=76914

Reviewed by Simon Hausmann.

.:

Add a manual test.

  • ManualTests/qt/tap-highlighting.html: Added.

Source/WebCore:

Implement highlighting of dom nodes with a rounded rect, respecting
the color of -webkit-tap-highlight-color and any transform applied
to the element.

Tested with manual test.

  • Target.pri:
  • page/GestureTapHighlighter.cpp: Added.

(WebCore::GestureTapHighlighter::pathForNodeHighlight):

  • page/GestureTapHighlighter.h: Added.

Source/WebKit2:

Implement tap highlighting for Qt. When a touch press is issued,
which is not handled by the web page, then we highlight any
activatable node below. In all otehr cases, we hide any highlights.

The highlighting itself is painted on an accelerated PageOverlay,
on the web process side.

  • Target.pri:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::handlePotentialActivation):

  • UIProcess/WebPageProxy.h:
  • UIProcess/qt/QtTapGestureRecognizer.cpp:

(WebKit::QtTapGestureRecognizer::recognize):

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::handlePotentialSingleTapEvent):

  • UIProcess/qt/QtWebPageEventHandler.h:
  • WebProcess/WebPage/TapHighlightController.cpp: Added.

(WebKit::TapHighlightController::TapHighlightController):
(WebKit::TapHighlightController::~TapHighlightController):
(WebKit::TapHighlightController::highlight):
(WebKit::TapHighlightController::hideHighlight):
(WebKit::TapHighlightController::pageOverlayDestroyed):
(WebKit::TapHighlightController::willMoveToWebPage):
(WebKit::TapHighlightController::didMoveToWebPage):
(WebKit::highlightColor):
(WebKit::TapHighlightController::drawRect):
(WebKit::TapHighlightController::mouseEvent):

  • WebProcess/WebPage/TapHighlightController.h: Added.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::highlightPotentialActivation):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::tapHighlightController):

  • WebProcess/WebPage/WebPage.messages.in:
10:12 Changeset [105892] by leviw@chromium.org
  • 1 edit
    7 deletes in trunk/LayoutTests

Unreviewed, rolling out r105887.
http://trac.webkit.org/changeset/105887
https://bugs.webkit.org/show_bug.cgi?id=77023

Rolling out incorrect chromium expectations for zero length
svg stroke. (Requested by leviw on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-25

  • platform/chromium-mac-leopard/svg/stroke/zero-length-path-linecap-rendering-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/stroke/zero-length-path-linecap-rendering-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Removed.
  • platform/chromium-win-vista/svg/stroke/zero-length-path-linecap-rendering-expected.png: Removed.
  • platform/chromium-win-vista/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Removed.
  • platform/chromium-win-xp/svg/stroke/zero-length-path-linecap-rendering-expected.png: Removed.
  • platform/chromium-win-xp/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Removed.
  • platform/chromium-win/svg/stroke/zero-length-path-linecap-rendering-expected.png: Removed.
  • platform/chromium-win/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Removed.
10:01 Changeset [105891] by jsbell@chromium.org
  • 8 edits
    2 adds in trunk

IndexedDB: Need to distinguish key paths that don't yield value vs. yield invalid key
https://bugs.webkit.org/show_bug.cgi?id=76487

Source/WebCore:

Implement the precondition checks for IDBObjectStore.add/put operations: raise an error
if there is a key generator (autoIncrement) and the path yields a value and the value
is not a valid key; raise an error if any of the index key paths yield a value which
is not a valid key.

Reviewed by Tony Chang.

Tests: storage/indexeddb/keypath-edges.html

storage/indexeddb/objectstore-basics.html

  • storage/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::put):

Source/WebKit/chromium:

Added a NullType to represent a null IDBKey pointer. This is needed to distinguish the
cases in the spec where the key resolution algorithm returns no value (null) versus
returns a value but that value is not a valid key (invalid).

Reviewed by Tony Chang.

  • public/WebIDBKey.h:
  • src/WebIDBKey.cpp:

(WebKit::WebIDBKey::createNull): Added.
(WebKit::WebIDBKey::createFromValueAndKeyPath): Now returns null if value is null.
(WebKit::convertFromWebIDBKeyArray): Null keys should never exist within arrays.
(WebKit::WebIDBKey::assignInvalid):
(WebKit::WebIDBKey::assignNull):
(WebKit::WebIDBKey::type):

LayoutTests:

Reviewed by Tony Chang.

  • storage/indexeddb/keypath-edges-expected.txt: Added.
  • storage/indexeddb/keypath-edges.html: Added.
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
09:59 Changeset [105890] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, skip scrollbars/scroll-rtl-or-bt-layer.html on WebKit2
because eventSender.mouseScrollBy isn't implemented.

  • platform/wk2/Skipped:
09:56 Changeset [105889] by rgabor@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed Qt gardening.

Temporally skip failing tests after r105878.

Patch by Balazs Kelemen <kbalazs@webkit.org> on 2012-01-25

  • platform/qt/Skipped:
09:51 Changeset [105888] by leviw@chromium.org
  • 1 edit
    16 adds in trunk/LayoutTests

Unreviewed. Adding platform expectations after 105879

  • platform/chromium-linux-x86/compositing: Added.
  • platform/chromium-linux-x86/compositing/overflow: Added.
  • platform/chromium-linux-x86/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Added.
  • platform/chromium-linux/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Added.
  • platform/chromium-mac-snowleopard/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Added.
  • platform/chromium-win-vista/compositing: Added.
  • platform/chromium-win-vista/compositing/overflow: Added.
  • platform/chromium-win-vista/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Added.
  • platform/chromium-win-vista/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Added.
  • platform/chromium-win-xp/compositing: Added.
  • platform/chromium-win-xp/compositing/overflow: Added.
  • platform/chromium-win-xp/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Added.
  • platform/chromium-win-xp/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Added.
  • platform/chromium-win/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Added.
  • platform/chromium-win/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Added.
09:48 Changeset [105887] by leviw@chromium.org
  • 1 edit
    13 adds in trunk/LayoutTests

Unreviewed. Adding platform test expectations after r105878.

  • platform/chromium-mac-leopard/svg/stroke: Added.
  • platform/chromium-mac-leopard/svg/stroke/zero-length-path-linecap-rendering-expected.png: Added.
  • platform/chromium-mac-leopard/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/stroke/zero-length-path-linecap-rendering-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Added.
  • platform/chromium-win-vista/svg/stroke: Added.
  • platform/chromium-win-vista/svg/stroke/zero-length-path-linecap-rendering-expected.png: Added.
  • platform/chromium-win-vista/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Added.
  • platform/chromium-win-xp/svg/stroke: Added.
  • platform/chromium-win-xp/svg/stroke/zero-length-path-linecap-rendering-expected.png: Added.
  • platform/chromium-win-xp/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Added.
  • platform/chromium-win/svg/stroke/zero-length-path-linecap-rendering-expected.png: Added.
  • platform/chromium-win/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Added.
09:45 Changeset [105886] by philn@webkit.org
  • 2 edits
    3 adds in trunk/LayoutTests

Unreviewed, GTK rebaseline and skip new timing-out media test.

  • platform/gtk/Skipped:
  • platform/gtk/css3/calc/getComputedStyle-margin-percentage-expected.txt: Added.
  • platform/gtk/fast/multicol/span/generated-child-split-flow-crash-expected.txt: Added.
09:23 Changeset [105885] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=65377
Skip the entire node when it is right to do so, instead of stepping
through every character, so we save CPU time on checking every position
unnecessarily.

Patch by Yong Li <yoli@rim.com> on 2012-01-25
Reviewed by Darin Adler.

Source/WebCore:

Test: perf/selection-skip-hidden-node.html

  • dom/Position.cpp:

(WebCore::Position::upstream):
(WebCore::Position::downstream):

  • dom/PositionIterator.cpp:

(WebCore::PositionIterator::moveToLeafNodeStart):
(WebCore::PositionIterator::moveToLeafNodeEnd):

  • dom/PositionIterator.h:
  • editing/htmlediting.cpp:

(WebCore::nextCandidate):
(WebCore::nextVisuallyDistinctCandidate):
(WebCore::previousCandidate):
(WebCore::previousVisuallyDistinctCandidate):

LayoutTests:

  • perf/selection-skip-hidden-node-expected.txt: Added.
  • perf/selection-skip-hidden-node.html: Added.
09:21 Changeset [105884] by commit-queue@webkit.org
  • 11 edits in trunk

[WK2] WebKitTestRunner needs layoutTestController.setPopupBlockingEnabled
https://bugs.webkit.org/show_bug.cgi?id=63458

Patch by Nándor Huszka <huszka.nandor@stud.u-szeged.hu> on 2012-01-25
Reviewed by Adam Roben.

Source/WebKit2:

Implement the setPopupBlockingEnabled method.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetPrivateBrowsingEnabled):
(WKBundleSetPopupBlockingEnabled):

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setPopupBlockingEnabled):

  • WebProcess/InjectedBundle/InjectedBundle.h:

Tools:

Implement the setPopupBlockingEnabled method.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::setPopupBlockingEnabled):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

LayoutTests:

Unskip tests which do not fail now.

  • platform/wk2/Skipped:
09:18 Changeset [105883] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove unnecessary member variable from PluginView.
https://bugs.webkit.org/show_bug.cgi?id=76909

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2012-01-25
Reviewed by Adam Roben.

No new tests needed.

  • plugins/PluginView.cpp:

(WebCore::PluginView::getURLNotify):
(WebCore::PluginView::getURL):
(WebCore::PluginView::PluginView):
(WebCore::PluginView::handlePost):
(WebCore::PluginView::getValueForURL):
(WebCore::PluginView::setValueForURL):

  • plugins/PluginView.h:
09:17 Changeset [105882] by philn@webkit.org
  • 5 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline and skipping 2 new test failures.

  • platform/gtk/Skipped:
  • platform/gtk/svg/custom/path-moveto-only-rendering-expected.txt:
  • platform/gtk/svg/custom/subpaths-moveto-only-rendering-expected.txt:
  • platform/gtk/svg/custom/zero-path-square-cap-rendering-expected.txt:
09:09 Changeset [105881] by yael.aharon@nokia.com
  • 4 edits in trunk/Source

[Qt] Build fix when using force_static_libs_as_shared
https://bugs.webkit.org/show_bug.cgi?id=76832

Reviewed by Simon Hausmann.

Source/WebCore:

Add a dependency on QtWidgets, when compiling against Qt5.

No new tests. This is a build fix.

  • Target.pri:

Source/WebKit2:

Add a dependency on QtWidgets.

  • Target.pri:
08:19 Changeset [105880] by philn@webkit.org
  • 13 edits in trunk/LayoutTests

[Gtk] Update expected layout test results after r105686
https://bugs.webkit.org/show_bug.cgi?id=77008

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-01-25
Reviewed by Philippe Normand.

After r105686, missing image icons are properly loaded and
shown, causing failures because of incorrect expected results.
These changes properly fix the expectations and subsequently
remove failures.

  • platform/gtk/editing/execCommand/insertImage-expected.txt:
  • platform/gtk/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
  • platform/gtk/fast/block/float/015-expected.txt:
  • platform/gtk/fast/borders/rtl-border-05-expected.txt:
  • platform/gtk/fast/dom/34176-expected.txt:
  • platform/gtk/fast/dom/inner-text-expected.txt:
  • platform/gtk/fast/encoding/utf-16-big-endian-expected.txt:
  • platform/gtk/fast/encoding/utf-16-little-endian-expected.txt:
  • platform/gtk/fast/hidpi/broken-image-icon-hidpi-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2962-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug56201-expected.txt:
  • platform/gtk/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
07:50 Changeset [105879] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Clipping of render layer boundaries does not take page scale into account
https://bugs.webkit.org/show_bug.cgi?id=76850

Source/WebCore:

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-01-25
Reviewed by Simon Fraser.

When inserting render layers into the compositor's overlap map, the
layer boundaries are clipped against any potential parent clip rects.
The clip rects are given in CSS coordinates, while the render layer
boundaries are in scaled CSS coordinates, so the result is incorrect.
This patch scales the clip rects before calculating the intersection.

Test: compositing/overflow/overflow-scaled-descendant-overlapping.html

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::addToOverlapMap):

LayoutTests:

Added new test to make sure render layers inside clipped containers
are correctly tested for overlap with other layers.

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-01-25
Reviewed by Simon Fraser.

  • compositing/overflow/overflow-scaled-descendant-overlapping.html: Added.
  • platform/chromium-linux/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Added.
07:31 Changeset [105878] by commit-queue@webkit.org
  • 10 edits
    7 adds in trunk

Linecaps wrong for zero length lines
https://bugs.webkit.org/show_bug.cgi?id=71820

Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-25
Reviewed by Nikolas Zimmermann.

Total reworking of the method used to draw zero-length linecaps for
SVG. This patch works for all zero length sub-paths.

Source/WebCore:

Tests: svg/stroke/zero-length-path-linecap-rendering.svg

svg/stroke/zero-length-subpaths-linecap-rendering.svg

  • rendering/svg/RenderSVGShape.cpp: Significant refactoring to enable new implementation and clarify code.

(WebCore::RenderSVGShape::createShape):
(WebCore::RenderSVGShape::strokeContains):
(WebCore::RenderSVGShape::shouldStrokeZeroLengthSubpath):
(WebCore::RenderSVGShape::zeroLengthSubpathRect):
(WebCore::RenderSVGShape::zeroLengthLinecapPath):
(WebCore::RenderSVGShape::nonScalingStrokePath):
(WebCore::RenderSVGShape::setupNonScalingStrokeTransform):
(WebCore::RenderSVGShape::fillShape):
(WebCore::RenderSVGShape::strokePath):
(WebCore::RenderSVGShape::fillAndStrokePath):
(WebCore::RenderSVGShape::updateCachedBoundaries):
(WebCore::RenderSVGShape::processZeroLengthSubpaths):

  • rendering/svg/RenderSVGShape.h: Declarations for new methods.
  • rendering/svg/SVGSubpathData.h: Class for finding zero length subpaths.
  • svg/SVGPathBuilder.h: Fix typos
  • svg/SVGPathConsumer.h: Fix typos
  • svg/SVGPathSegListBuilder.h: Fix typos
  • svg/SVGPathTraversalStateBuilder.h: Fix typos

LayoutTests:

  • platform/chromium/test_expectations.txt: Chromium test expectations

pending new expected images and text.

  • platform/mac/svg/stroke/zero-length-path-linecap-rendering-expected.png: Added.
  • platform/mac/svg/stroke/zero-length-path-linecap-rendering-expected.txt: Added.
  • platform/mac/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Added.
  • platform/mac/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Added.
  • platform/mac/test_expectations.txt: Chromium test expectations

pending new expected images and text.

  • svg/stroke/zero-length-path-linecap-rendering.svg: Added.
  • svg/stroke/zero-length-subpaths-linecap-rendering.svg: Added.
07:10 Changeset [105877] by yurys@chromium.org
  • 14 edits
    1 add in trunk/Source/WebCore

Web Inspector: show memory counter graphs in timeline panel
https://bugs.webkit.org/show_bug.cgi?id=76843

Timeline panel is extended with several graphs depicting total node count,
number of DOM groups and event listeners. This feature is hidden behind
experimental setting.

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::setDomCountersEnabled):
(WebCore::InspectorTimelineAgent::didCallFunction):
(WebCore::InspectorTimelineAgent::didDispatchEvent):
(WebCore::InspectorTimelineAgent::didWriteHTML):
(WebCore::InspectorTimelineAgent::didFireTimer):
(WebCore::InspectorTimelineAgent::didEvaluateScript):
(WebCore::InspectorTimelineAgent::setHeapSizeStatistic):
(WebCore::InspectorTimelineAgent::collectDomCounters):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):

  • inspector/InspectorTimelineAgent.h:

(WebCore::InspectorTimelineAgent::create):

  • inspector/TimelineRecordFactory.cpp:
  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.MemoryStatistics):
(WebInspector.MemoryStatistics.prototype.setTopPosition):
(WebInspector.MemoryStatistics.prototype.setSidebarWidth):
(WebInspector.MemoryStatistics.prototype._sidebarResized):
(WebInspector.MemoryStatistics.prototype._updateSize):
(WebInspector.MemoryStatistics.prototype._updateSidebarSize):
(WebInspector.MemoryStatistics.prototype._createCounterSidebarElement):
(WebInspector.MemoryStatistics.prototype.addTimlineEvent):
(WebInspector.MemoryStatistics.prototype._draw.getGroupCount):
(WebInspector.MemoryStatistics.prototype._draw.getNodeCount):
(WebInspector.MemoryStatistics.prototype._draw.getListenerCount):
(WebInspector.MemoryStatistics.prototype._draw):
(WebInspector.MemoryStatistics.prototype._calculateVisibleIndexes):
(WebInspector.MemoryStatistics.prototype._onMouseOver):
(WebInspector.MemoryStatistics.prototype._refreshCurrentValues):
(WebInspector.MemoryStatistics.prototype.visible):
(WebInspector.MemoryStatistics.prototype.show):
(WebInspector.MemoryStatistics.prototype.refresh):
(WebInspector.MemoryStatistics.prototype.hide):
(WebInspector.MemoryStatistics.prototype._setVerticalClip):
(WebInspector.MemoryStatistics.prototype._calculateXValues):
(WebInspector.MemoryStatistics.prototype._drawPolyline):
(WebInspector.MemoryStatistics.prototype._drawBottomBound):
(WebInspector.MemoryStatistics.prototype._clear):
(WebInspector.TimelinePanel.prototype._startSplitterDragging):
(WebInspector.TimelinePanel.prototype._splitterDragging):
(WebInspector.TimelinePanel.prototype._endSplitterDragging):
(WebInspector.TimelinePanel.prototype._setSplitterPosition):
(WebInspector.TimelinePanel.prototype.get statusBarItems):
(WebInspector.TimelinePanel.prototype._createStatusbarButtons):
(WebInspector.TimelinePanel.prototype._toggleMemoryStatistics):
(WebInspector.TimelinePanel.prototype._onTimelineEventRecorded):
(WebInspector.TimelinePanel.prototype.sidebarResized):
(WebInspector.TimelinePanel.prototype._refresh):

  • inspector/front-end/timelinePanel.css:

(#timeline-memory-splitter):
(#memory-counters-graph):
(#memory-graphs-container):
(#memory-graphs-container .split-view-contents):
(.timeline-marker):
(.memory-counter-sidebar-info):
(.memory-counter-sidebar-info.bottom-border-visible):

07:03 Changeset [105876] by kbalazs@webkit.org
  • 10 edits
    1 copy
    1 add
    1 delete in trunk/Tools

[Qt] Cleanup testfonts handling
https://bugs.webkit.org/show_bug.cgi?id=76068

Reviewed by Simon Hausmann.

Factor test font initialization into it's own file so test
font users can share the implementation by adding the file
to their build.
Use fonts.conf from the test font directory to not require the
current directory to be the WebKit root.
Fix the -use-test-fonts option of QtTestBrowser by initializing
the fonts earlier, before it is too late (namely before calling
show on the main window).

  • DumpRenderTree/qt/DumpRenderTree.pro:
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::open):

  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • DumpRenderTree/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.

(WebKit::initializeTestFonts):

  • DumpRenderTree/qt/QtInitializeTestFonts.h: Added.
  • DumpRenderTree/qt/fonts.conf: Removed. No need for this since

we will use the one from the test fonts directory.

  • DumpRenderTree/qt/main.cpp:

(main): Fix the ifdefs to make it clear that the code to
set up the Dpi has not been ported to Qt5 yet.

  • QtTestBrowser/QtTestBrowser.pro:
  • QtTestBrowser/launcherwindow.h:

(WindowOptions::WindowOptions):

  • QtTestBrowser/main.cpp:

(launcherMain):
(LauncherApplication::handleUserOptions):

  • WebKitTestRunner/InjectedBundle/Target.pri:
  • WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:

(WTR::activateFonts): Remove the code to set up the Dpi
because it does not work with Qt5.

06:32 Changeset [105875] by hausmann@webkit.org
  • 2 edits in trunk/Tools

[Qt] build-webkit --qt requires a git-svn or SVN checkout.

Reviewed by Tor Arne Vestø.

Don't require it by making svnRevisionForDirectory return "unknown"
instead of bailing out with an error.

  • Scripts/VCSUtils.pm:

(svnRevisionForDirectory):

06:30 Changeset [105874] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed single line test fix after r105865.

  • inspector/profiler/detailed-heapshots-test.js:

(initialize_DetailedHeapshotTest.):
(initialize_DetailedHeapshotTest):

06:13 Changeset [105873] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

<http://webkit.org/b/76941> Web Inspector: Remove Unused InspectorFrontendHost.search Stub

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-01-25
Reviewed by Pavel Feldman.

  • inspector/front-end/InspectorFrontendHostStub.js:
05:27 Changeset [105872] by ossy@webkit.org
  • 3 edits
    7 adds in trunk/LayoutTests

[Qt][ARM] Unreviewed gardening.

Skip failing tests, update/add platform specific expected files for passing tests.

  • platform/qt-arm/Skipped:
  • platform/qt-arm/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt-arm/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt: Added.
  • platform/qt-arm/svg/W3C-SVG-1.1/paths-data-09-t-expected.txt: Added.
  • platform/qt-arm/svg/batik/text/textOnPath3-expected.txt: Added.
05:20 Changeset [105871] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed inspector style fix.

  • inspector/front-end/tabbedPane.css:

(.tabbed-pane-header-tab-close-button):
(select.tabbed-pane-header-tabs-drop-down-select):

05:04 Changeset [105870] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Fix incorrect behavior in HTMLCollection.prototype.item().
https://bugs.webkit.org/show_bug.cgi?id=74468

Patch by Pablo Flouret <pablof@motorola.com> on 2012-01-25
Reviewed by Adam Barth.

HTMLCollection.prototype.item("someString") was falling back to
.namedItem("someString"), which is wrong per spec. Also align the
handling of various other types of objects passed as the argument with
the spec and the rest of the browsers.

Source/WebCore:

Test: fast/dom/collection-item.html

  • bindings/js/JSHTMLCollectionCustom.cpp: Remove custom implementation of item().
  • bindings/v8/custom/V8HTMLCollectionCustom.cpp: Ditto.
  • html/HTMLCollection.idl: Remove [Custom] in item(), it's not needed.

LayoutTests:

  • fast/dom/collection-item-expected.txt: Added.
  • fast/dom/collection-item.html: Added.
04:39 Changeset [105869] by mikelawther@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

table border spacing test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=76226

Reviewed by Julien Chaffraix.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

  • css3/calc/table-border-spacing-expected.txt: Added.
  • css3/calc/table-border-spacing.html: Added.
04:36 Changeset [105868] by commit-queue@webkit.org
  • 8 edits
    2 deletes in trunk/Source/WebCore

Unreviewed, rolling out r105858.
http://trac.webkit.org/changeset/105858
https://bugs.webkit.org/show_bug.cgi?id=77004

It made many tests crash on Qt (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-25

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::addAnimation):
(WebCore::GraphicsLayerTextureMapper::pauseAnimation):
(WebCore::GraphicsLayerTextureMapper::removeAnimation):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:

(GraphicsLayerTextureMapper):

  • platform/graphics/texmap/TextureMapperAnimation.cpp: Removed.
  • platform/graphics/texmap/TextureMapperAnimation.h: Removed.
  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::syncCompositingStateSelf):
(WebCore::TextureMapperNode::descendantsOrSelfHaveRunningAnimations):
(WebCore::normalizedAnimationValue):
(WebCore):
(WebCore::TextureMapperNode::applyOpacityAnimation):
(WebCore::solveEpsilon):
(WebCore::solveCubicBezierFunction):
(WebCore::solveStepsFunction):
(WebCore::applyTimingFunction):
(WebCore::TextureMapperNode::applyTransformAnimation):
(WebCore::TextureMapperNode::applyAnimationFrame):
(WebCore::TextureMapperNode::applyAnimation):
(WebCore::TextureMapperNode::hasOpacityAnimation):
(WebCore::TextureMapperNode::hasTransformAnimation):
(WebCore::TextureMapperNode::syncAnimations):
(WebCore::TextureMapperNode::syncAnimationsRecursively):
(WebCore::TextureMapperNode::syncCompositingState):
(WebCore::TextureMapperAnimation::TextureMapperAnimation):

  • platform/graphics/texmap/TextureMapperNode.h:

(TextureMapperAnimation):
(WebCore::TextureMapperAnimation::create):
(WebCore):
(TextureMapperNode):

04:35 Changeset [105867] by ossy@webkit.org
  • 21 edits
    2 adds
    2 deletes in trunk/LayoutTests

Unreviewed gardening, Skipped list cleanup.

  • platform/chromium-mac-leopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Removed.
  • platform/chromium-mac-leopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Removed.
  • platform/mac/Skipped: Remove non-existent files.
  • platform/qt/Skipped: Group new skipped tests.
  • platform/qt/editing/deleting/delete-line-011-expected.png:
  • platform/qt/editing/deleting/delete-line-011-expected.txt:
  • platform/qt/editing/pasteboard/paste-4039777-fix-expected.png: Added.
  • platform/qt/editing/pasteboard/paste-4039777-fix-expected.txt: Added.
  • platform/qt/fast/block/float/floats-and-text-indent-expected.png:
  • platform/qt/fast/block/float/floats-and-text-indent-expected.txt:
  • platform/qt/fast/block/float/floats-and-text-indent-rl-expected.png:
  • platform/qt/fast/block/float/floats-and-text-indent-rl-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
04:32 Changeset [105866] by bashi@chromium.org
  • 4 edits in trunk

fast/text/unicode-variation-selector.html doesn't pass on Lion
https://bugs.webkit.org/show_bug.cgi?id=76041

Source/WebCore:

Reviewed by Dan Bernstein.

Consumes non-BMP marks in advanceByCombiningCharacterSequence() to take into
account Ideographic variation selectors (these are non-BMP marks).

No new tests. fast/text/unicode-variation-selector.html should pass on Lion.

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::advanceByCombiningCharacterSequence): Use Unicode code point
to iterate the loop which consumes marks.

LayoutTests:

Update the UVS test font to be CoreText-friendly. This updated font is provided by Apple.

Reviewed by Dan Bernstein.

  • fast/text/resources/gw432047.ttf:
04:25 Changeset [105865] by loislo@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: DetailedHeapSnapshot: adjust node name cell format for the retainers tree.
https://bugs.webkit.org/show_bug.cgi?id=76989

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotGenericObjectNode.prototype._createObjectCell):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
(WebInspector.HeapSnapshotObjectNode):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):
(WebInspector.HeapSnapshotObjectNode.prototype._postfixObjectCell):

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotEdgesProvider.prototype._serialize):

04:01 Changeset [105864] by vsevik@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: [InspectorIndexedDB] Pass Database, object stores and indexes meta information to frontend.
https://bugs.webkit.org/show_bug.cgi?id=76711

Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):
(WebCore::assertDocument):
(WebCore::assertIDBFactory):
(WebCore::InspectorIndexedDBAgent::requestDatabaseNamesForFrame):
(WebCore::InspectorIndexedDBAgent::requestDatabase):

  • inspector/InspectorIndexedDBAgent.h:

(InspectorIndexedDBAgent):

  • inspector/front-end/IndexedDBModel.js:

(WebInspector.IndexedDBModel):
(WebInspector.IndexedDBModel.prototype._frameDetached):
(WebInspector.IndexedDBModel.prototype._reset):
(WebInspector.IndexedDBModel.prototype._originAddedToFrame):
(WebInspector.IndexedDBModel.prototype._originRemovedFromFrame):
(WebInspector.IndexedDBModel.prototype._originRemoved):
(WebInspector.IndexedDBModel.prototype._updateOriginDatabaseNames):
(WebInspector.IndexedDBModel.prototype._databaseRemoved):
(WebInspector.IndexedDBModel.prototype._loadDatabaseNamesForFrame):
(WebInspector.IndexedDBModel.prototype._loadDatabase):
(WebInspector.IndexedDBModel.Frame):
(WebInspector.IndexedDBModel.Database):
(WebInspector.IndexedDBModel.ObjectStore):
(WebInspector.IndexedDBModel.ObjectStoreIndex):
(WebInspector.IndexedDBRequestManager.prototype._databaseNamesLoaded):
(WebInspector.IndexedDBRequestManager.prototype.requestDatabase.innerCallback):
(WebInspector.IndexedDBRequestManager.prototype.requestDatabase):
(WebInspector.IndexedDBRequestManager.prototype._databaseLoaded):
(WebInspector.IndexedDBRequestManager.prototype._frameDetached):
(WebInspector.IndexedDBRequestManager.prototype._databaseRemoved):
(WebInspector.IndexedDBRequestManager.prototype._reset):
(WebInspector.IndexedDBRequestManager.DatabaseRequest):
(WebInspector.IndexedDBDispatcher.prototype.databaseNamesLoaded):
(WebInspector.IndexedDBDispatcher.prototype.databaseLoaded):

03:54 Changeset [105863] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: add optional runtime validator
https://bugs.webkit.org/show_bug.cgi?id=76676

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-01-25
Reviewed by Yury Semikhatsky.

Generator algorithm is redone significantly.

  • inspector/CodeGeneratorInspector.py:

(RawTypes.BaseType):
(RawTypes.BaseType.request_raw_internal_runtime_cast):
(RawTypes.BaseType.generate_validate_method_impl):
(RawTypes):
(RawTypes.generate_validate_methods):
(RawTypes.String):
(RawTypes.String.generate_validate_method):
(RawTypes.String.get_raw_validator_call_text):
(RawTypes.Int):
(RawTypes.Int.generate_validate_method):
(RawTypes.Int.get_raw_validator_call_text):
(RawTypes.Number):
(RawTypes.Number.generate_validate_method):
(RawTypes.Number.get_raw_validator_call_text):
(RawTypes.Bool):
(RawTypes.Bool.generate_validate_method):
(RawTypes.Bool.get_raw_validator_call_text):
(RawTypes.Object):
(RawTypes.Object.generate_validate_method):
(RawTypes.Object.get_raw_validator_call_text):
(RawTypes.Any):
(RawTypes.Any.generate_validate_method):
(RawTypes.Any.get_raw_validator_call_text):
(RawTypes.Array):
(RawTypes.Array.generate_validate_method):
(RawTypes.Array.get_raw_validator_call_text):
(TypeBindings.create_named_type_declaration.Helper):
(TypeBindings.create_ad_hoc_type_declaration.Helper):
(TypeBindings.create_type_declaration_.EnumBinding):
(TypeBindings.create_type_declaration_.EnumBinding.resolve_inner):
(TypeBindings.create_type_declaration_.EnumBinding.request_user_runtime_cast):
(TypeBindings.create_type_declaration_.EnumBinding.request_internal_runtime_cast):
(TypeBindings.create_type_declaration_.EnumBinding.get_code_generator):
(TypeBindings.create_type_declaration_.EnumBinding.get_code_generator.CodeGenerator.generate_type_builder):
(TypeBindings.create_type_declaration_.EnumBinding.get_validator_call_text):
(TypeBindings.create_type_declaration_.EnumBinding.get_in_c_type_text):
(TypeBindings.create_type_declaration_.PlainString):
(TypeBindings.create_type_declaration_.PlainString.resolve_inner):
(TypeBindings.create_type_declaration_.PlainString.request_user_runtime_cast):
(TypeBindings.create_type_declaration_.PlainString.request_internal_runtime_cast):
(TypeBindings.create_type_declaration_.PlainString.get_validator_call_text):
(TypeBindings.create_type_declaration_.TypedefString):
(TypeBindings.create_type_declaration_.TypedefString.resolve_inner):
(TypeBindings.create_type_declaration_.TypedefString.request_user_runtime_cast):
(TypeBindings.create_type_declaration_.TypedefString.request_internal_runtime_cast):
(TypeBindings.create_type_declaration_.TypedefString.get_code_generator.CodeGenerator.generate_type_builder):
(TypeBindings.create_type_declaration_.TypedefString.get_validator_call_text):
(TypeBindings.create_type_declaration_.TypedefString.get_in_c_type_text):
(TypeBindings.create_type_declaration_.ClassBinding):
(TypeBindings.create_type_declaration_.ClassBinding.resolve_inner):
(TypeBindings.create_type_declaration_.ClassBinding.resolve_inner.PropertyData):
(TypeBindings.create_type_declaration_.ClassBinding.resolve_inner.ResolveData):
(TypeBindings.create_type_declaration_.ClassBinding.request_user_runtime_cast):
(TypeBindings.create_type_declaration_.ClassBinding.request_internal_runtime_cast):
(TypeBindings.create_type_declaration_.ClassBinding.get_code_generator):
(TypeBindings.create_type_declaration_.ClassBinding.get_code_generator.CodeGenerator.generate_type_builder):
(get_validator_call_text):
(get_in_c_type_text):
(AdHocTypeContextImpl):
(AdHocTypeContextImpl.init):
(AdHocTypeContextImpl.get_type_name_fix):
(AdHocTypeContextImpl.get_type_name_fix.NameFix):
(AdHocTypeContextImpl.get_type_name_fix.NameFix.output_comment):
(AdHocTypeContextImpl.add_type):
(PlainObjectBinding):
(PlainObjectBinding.resolve_inner):
(PlainObjectBinding.request_user_runtime_cast):
(PlainObjectBinding.request_internal_runtime_cast):
(PlainObjectBinding.get_validator_call_text):
(ArrayBinding):
(ArrayBinding.resolve_inner):
(ArrayBinding.resolve_inner.AdHocTypeContext):
(ArrayBinding.resolve_inner.AdHocTypeContext.get_type_name_fix):
(ArrayBinding.resolve_inner.AdHocTypeContext.get_type_name_fix.NameFix):
(ArrayBinding.resolve_inner.AdHocTypeContext.get_type_name_fix.NameFix.output_comment):
(ArrayBinding.resolve_inner.AdHocTypeContext.add_type):
(ArrayBinding.resolve_inner.ResolveData):
(ArrayBinding.request_user_runtime_cast):
(ArrayBinding.request_internal_runtime_cast):
(ArrayBinding.get_code_generator):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder):
(ArrayBinding.get_validator_call_text):
(ArrayBinding.get_in_c_type_text):
(RawTypeBinding.resolve_inner):
(RawTypeBinding):
(RawTypeBinding.request_user_runtime_cast):
(RawTypeBinding.request_internal_runtime_cast):
(RawTypeBinding.get_validator_call_text):
(TypeData.get_name):
(TypeData):
(TypeData.get_domain_name):
(resolve_param_type):
(NeedRuntimeCastRequest):
(NeedRuntimeCastRequest.init):
(NeedRuntimeCastRequest.acknowledge):
(NeedRuntimeCastRequest.is_acknowledged):
(resolve_all_types):
(resolve_all_types.ForwardListener):
(resolve_all_types.ForwardListener.add_type_data):
(resolve_all_types.ResolveContext):
(Generator):
(Generator.go):
(Generator.process_event):
(Generator.process_event.AdHocTypeContext):
(Generator.process_event.AdHocTypeContext.add_type):
(Generator.process_event.EventForwardListener):
(Generator.process_event.EventForwardListener.add_type_data):
(Generator.process_event.EventResolveContext):
(Generator.process_event.EventGenerateContext):
(Generator.process_types.GenerateContext):
(Generator.process_types.create_type_builder_caller.call_type_builder):
(Generator.process_types.generate_forward_callback):

  • inspector/InspectorValues.h:

(WebCore::InspectorObject::size):

03:44 Changeset [105862] by antonm@chromium.org
  • 6 edits in trunk/Source/WebCore

Unreview manual revert of r105843.

  • fileapi/EntryBase.cpp:

(WebCore::EntryBase::toURL):

  • page/SecurityOrigin.cpp:

(WebCore::extractInnerURL):

  • platform/KURL.h:

(KURL):

  • platform/KURLGoogle.cpp:

(WebCore):
(WebCore::KURLGooglePrivate::setUtf8):
(WebCore::KURLGooglePrivate::setAscii):
(WebCore::KURLGooglePrivate::initProtocolIsInHTTPFamily):
(WebCore::KURLGooglePrivate::copyTo):
(WebCore::encodeWithURLEscapeSequences):

  • platform/KURLGooglePrivate.h:

(KURLGooglePrivate):

03:44 Changeset [105861] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[chromium] fast/css/text-overflow-input.html rebaseline
https://bugs.webkit.org/show_bug.cgi?id=76981

Reviewed by Kent Tamura.

Fixed in r105451

  • platform/chromium/test_expectations.txt:
03:37 Changeset [105860] by noel.gordon@gmail.com
  • 3 edits in trunk/Source/WebCore

Use maximum image dimension definition from libwebp
https://bugs.webkit.org/show_bug.cgi?id=76980

Reviewed by Kent Tamura.

No new tests, no change in behavior.

  • platform/image-encoders/skia/WEBPImageEncoder.cpp:

(WebCore::encodePixels): s/WEBP_MAX_DIMENSION/WEBPImageEncoder::MaximumImageDimension/

  • platform/image-encoders/skia/WEBPImageEncoder.h:

(): Remove local definition of the maximum webp image dimension

03:24 Changeset [105859] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

JPEGDecoder should use imageDecoder colorProfile helpers
https://bugs.webkit.org/show_bug.cgi?id=76968

Reviewed by Adam Barth.

No new tests. Cover by existing tests, in particular:

fast/images/ycbcr-with-cmyk-color-profile.html
fast/images/gray-scale-jpeg-with-color-profile.html
fast/images/cmyk-jpeg-with-color-profile.html
fast/images/color-jpeg-with-color-profile.html

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: white-space removals via Xcode.

(WebCore::readColorProfile): Use ImageDecoder.h color profile helper routines.
(WebCore::JPEGImageReader::JPEGImageReader):
(WebCore::JPEGImageReader::decode):

03:09 Changeset [105858] by noam.rosenthal@nokia.com
  • 8 edits
    2 adds in trunk/Source/WebCore

[Texmap] Divide TextureMapperNode.cpp to 3 files.
https://bugs.webkit.org/show_bug.cgi?id=76660

Reviewed by Kenneth Rohde Christiansen.

Split the animation part of TextureMapperNode out to a separate file, called
TextureMapperAnimation.
Provide a clean interface for that class, that allows separating the internals of the scene
painting from the internals of the animation interpolation.

No new tests. Existing animation tests cover this.

  • GNUmakefile.list.am: Added new TextureMapper-related files.
  • Target.pri: Added new TextureMapper-related files.
  • WebCore.gypi: Added new TextureMapper-related files.
  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::addAnimation):
(WebCore::GraphicsLayerTextureMapper::pauseAnimation):
(WebCore::GraphicsLayerTextureMapper::removeAnimation):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:
  • platform/graphics/texmap/TextureMapperAnimation.cpp: Added.
  • platform/graphics/texmap/TextureMapperAnimation.h: Added.
  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::syncCompositingStateSelf):
(WebCore::TextureMapperNode::descendantsOrSelfHaveRunningAnimations):
(WebCore::TextureMapperNode::syncAnimations):
(WebCore::TextureMapperNode::syncAnimationsRecursively):
(WebCore::TextureMapperNode::syncCompositingState):

  • platform/graphics/texmap/TextureMapperNode.h:
02:18 Changeset [105857] by abarth@webkit.org
  • 2 edits in trunk/Tools

Temporarily disable running the unit tests on the Chromium EWS. These
tests don't work properly (see
https://bugs.webkit.org/show_bug.cgi?id=76979) and are currently
blocking the EWS.

  • Scripts/webkitpy/common/config/ports.py:

(ChromiumPort):

01:57 Changeset [105856] by abarth@webkit.org
  • 4 edits in trunk

Update results.html version of PixelZoomer
https://bugs.webkit.org/show_bug.cgi?id=76965

Reviewed by Ojan Vafai.

Tools:

Improve readability as suggested by Ojan.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:

LayoutTests:

Update result.html with changes from PixelZoomer.js.

  • fast/harness/results.html:
00:54 Changeset [105855] by sergio@webkit.org
  • 5 edits in trunk/Source/WebKit2

[WK2] FindController should not assume that ports do not want to highlight text matches
https://bugs.webkit.org/show_bug.cgi?id=76921

Reviewed by Darin Adler.

FindController must obey the FindOptionsShowHighlight flag instead
of assuming that ports do not want to highlight search matches.

  • Shared/API/c/WKFindOptions.h: added kWKFindOptionsShowHighlight.
  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toFindOptions): Ditto.

  • Shared/WebFindOptions.h: added FindOptionsShowHighlight.
  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::findString):

00:37 Changeset [105854] by carlosgc@webkit.org
  • 8 edits
    2 moves
    1 add
    1 delete in trunk

[GTK] Page clients don't need to be GObjects anymore in WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=76899

Reviewed by Martin Robinson.

Source/WebKit2:

  • UIProcess/API/gtk/WebKitLoaderClient.cpp: Renamed from

Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp.
(didStartProvisionalLoadForFrame): Use clientInfo instead fo
getting the view from the page.
(didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
(didFailProvisionalLoadWithErrorForFrame): Ditto.
(didCommitLoadForFrame): Ditto.
(didFinishLoadForFrame): Ditto.
(didFailLoadWithErrorForFrame): Ditto.
(didSameDocumentNavigationForFrame): Ditto.
(didReceiveTitleForFrame): Ditto.
(didChangeProgress): Ditto.
(didChangeBackForwardList): Ditto.
(attachLoaderClientToView): Pass WebKitWebView as clientInfo to
callbacks.

  • UIProcess/API/gtk/WebKitLoaderClient.h: Added.
  • UIProcess/API/gtk/WebKitUIClient.cpp:

(createNewPage): Use clientInfo instead fo getting the view from
the page.
(showPage): Ditto.
(closePage): Ditto.
(runJavaScriptAlert): Ditto.
(runJavaScriptConfirm): Ditto.
(runJavaScriptPrompt): Ditto.
(toolbarsAreVisible): Ditto.
(setToolbarsAreVisible): Ditto.
(menuBarIsVisible): Ditto.
(setMenuBarIsVisible): Ditto.
(statusBarIsVisible): Ditto.
(setStatusBarIsVisible): Ditto.
(isResizable): Ditto.
(setIsResizable): Ditto.
(getWindowFrame): Ditto.
(setWindowFrame): Ditto.
(attachUIClientToView): Pass WebKitWebView as clientInfo to
callbacks.

  • UIProcess/API/gtk/WebKitUIClient.h: Remove GObject boilerplate.
  • UIProcess/API/gtk/WebKitWebLoaderClient.h: Removed.
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewConstructed): Remove UIClient and LoaderClient
objects and call attachUIClientToView() and attachLoaderClientToView().

  • UIProcess/API/gtk/tests/GNUmakefile.am: Rename

WebKitWebLoaderClient to WebKitLoaderClient.

  • UIProcess/API/gtk/tests/TestLoaderClient.cpp: Renamed from

Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp.

Tools:

  • gtk/generate-gtkdoc:

(get_webkit2_options): WebKitWebLoaderClient has been renamed to
WebKitLoaderClient.

00:04 Changeset [105853] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unskip now passing tests after r105813.

  • platform/qt/Skipped:

01/24/12:

23:58 Changeset [105852] by ossy@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed gardening. Skip failing tests.

  • platform/qt-wk2/Skipped:
  • platform/wk2/Skipped:
23:49 Changeset [105851] by ossy@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Add Qt specific expected results after r105769.

  • platform/qt/fast/multicol/span/generated-child-split-flow-crash-expected.png: Added.
  • platform/qt/fast/multicol/span/generated-child-split-flow-crash-expected.txt: Added.
23:01 Changeset [105850] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Build fix. Trigger Chromium Mac Release (Perf) on new commits.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
22:48 Changeset [105849] by rolandsteiner@chromium.org
  • 16 edits
    2 adds in trunk

<style scoped>: Implement registering of <style scoped> with the scoping element
https://bugs.webkit.org/show_bug.cgi?id=67790

.:

windows.internals updates

Reviewed by Dimitri Glazkov.

  • Source/autotools/symbols.filter:

Source/WebCore:

Implement registering of a <style> element with its parent element if the 'scoped' attribute is set.
Update the registration whenever the 'scoped' attribute is changed,
or the <style> element eneters or leaves the tree.

Also, extend windows.internals to allow for testing of the registration ref-counting.

Reviewed by Dimitri Glazkov.

Test: fast/css/style-scoped/registering.html

  • WebCore.exp.in:
  • dom/Element.cpp:

(WebCore::Element::hasScopedHTMLStyleChild):
(WebCore::Element::numberOfScopedHTMLStyleChildren):
(WebCore::Element::registerScopedHTMLStyleChild):
(WebCore::Element::unregisterScopedHTMLStyleChild):

  • dom/Element.h:
  • dom/ElementRareData.h:

(WebCore::ElementRareData::ElementRareData):
(WebCore::ElementRareData::registerScopedHTMLStyleChild):
(WebCore::ElementRareData::unregisterScopedHTMLStyleChild):
(WebCore::ElementRareData::hasScopedHTMLStyleChild):
(WebCore::ElementRareData::numberOfScopedHTMLStyleChildren):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::HTMLStyleElement):
(WebCore::HTMLStyleElement::~HTMLStyleElement):
(WebCore::HTMLStyleElement::parseMappedAttribute):
(WebCore::HTMLStyleElement::registerWithScopingNode):
(WebCore::HTMLStyleElement::unregisterWithScopingNode):
(WebCore::HTMLStyleElement::insertedIntoDocument):
(WebCore::HTMLStyleElement::removedFromDocument):
(WebCore::HTMLStyleElement::willRemove):

  • html/HTMLStyleElement.h:
  • testing/Internals.cpp:

(WebCore::Internals::numberOfScopedHTMLStyleChildren):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

Add symbols for windows.internals.numberOfScopedHTMLStyleChildren

Reviewed by Dimitri Glazkov.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

Tests that registration of <style scoped> with its parent is performed correctly
in various circumstances.

Reviewed by Dimitri Glazkov.

  • fast/css/style-scoped/registering-expected.txt: Added.
  • fast/css/style-scoped/registering.html: Added.
22:08 Changeset [105848] by rniwa@webkit.org
  • 3 edits in trunk/Tools

WebKit needs public performance tests running on public bots
https://bugs.webkit.org/show_bug.cgi?id=10266

Reviewed by Adam Barth.

Completes the initial implementation of WebKit Perf bots. Add a build step for run-perf-test
and make google-mac-4 run it, and upload the results to webkit-perf.webkit.org.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunAndUploadPerfTests):
(RunAndUploadPerfTests.start):
(UploadPerfTestResults):
(BuildAndPerfTestFactory):
(BuildAndPerfTestFactory.init):

21:27 Changeset [105847] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Attempt to fix Mac build after changeset <http://trac.webkit.org/changeset/105843>
(https://bugs.webkit.org/show_bug.cgi?id=75049)

Don't include NotImplemented.h in KURL.h since NotImplemented.h includes Logging.h, which defines
LOG_CHANNEL_PREFIX to be "Log". And this conflicts with the inclusion of WebKitLogging.h in
WebHTMLView.mm (which would have defined LOG_CHANNEL_PREFIX to be "WebKitLog").

  • platform/KURL.h:

(WebCore::KURL::innerURL):

21:17 Changeset [105846] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed chromium test fix.

  • src/js/Tests.js:

(.TestSuite.prototype._waitUntilScriptsAreParsed.waitForAllScripts):
(.TestSuite.prototype._waitUntilScriptsAreParsed):

19:28 Changeset [105845] by vangelis@chromium.org
  • 7 edits
    1 add in trunk/Source

Source/WebCore: [chromium] Ignore m_skipsDraw in TiledLayerChromium::drawsContent()
https://bugs.webkit.org/show_bug.cgi?id=76735

This is to add skipped layers to their RenderSurface's layer list so that they
are considered in the next update. Without this change, m_skipsDraw = false sticks
with the layer for the remainder of its lifetime.

Reviewed by James Robinson.

Tests: Unit test (TiledLayerChromiumTest.cpp)

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::drawsContent):

  • platform/graphics/chromium/TiledLayerChromium.h:

(WebCore::TiledLayerChromium::skipsDraw):

Source/WebKit/chromium: Adding a test to verify that m_skipsDraw gets reset between frames for
tiled layers.
https://bugs.webkit.org/show_bug.cgi?id=76735

Reviewed by James Robinson.

  • WebKit.gypi:
  • tests/FakeCCLayerTreeHostClient.h: Added.

(WebCore::FakeCCLayerTreeHostClient::updateAnimations):
(WebCore::FakeCCLayerTreeHostClient::layout):
(WebCore::FakeCCLayerTreeHostClient::applyScrollAndScale):
(WebCore::FakeCCLayerTreeHostClient::createLayerTreeHostContext3D):
(WebCore::FakeCCLayerTreeHostClient::didRecreateGraphicsContext):
(WebCore::FakeCCLayerTreeHostClient::didCommitAndDrawFrame):
(WebCore::FakeCCLayerTreeHostClient::didCompleteSwapBuffers):
(WebCore::FakeCCLayerTreeHostClient::scheduleComposite):

  • tests/LayerChromiumTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:

(WTF::FakeTiledLayerChromium::skipsDraw):
(WTF::FakeTiledLayerChromium::paintContentsIfDirty):
(WTF::TEST):

18:47 Changeset [105844] by haraken@chromium.org
  • 6 edits in trunk/Source/WebCore

Invalidate r105697, r105766, r105809 and r105805
https://bugs.webkit.org/show_bug.cgi?id=76970

Reviewed by Adam Barth.

I've been trying to stop rebuilding .h/.cpp files generated by
unchanged IDLs (bug 76836), but the approach was wrong.
This patch invalidates patches committed in r105697, r105766,
r105809 and r105805.

In r105697, r105766, r105809 and r105805, I modified CodeGenerator*.pm
so that they overwrite .h/.cpp files only when the bytes differ.
By this fix, we were able to stop rebuilding .h/.cpp files that are not
changed. However, the fix has made generate-bindings.pl run for almost
all IDLs every time. The reason is as follows:

(0) Assume that there are A.idl, B.idl and C.idl.

(1) Modify A.idl.
(2) First build.
(3) supplemental_dependency.tmp is updated.
(4) generate-bindings.pl runs for A.idl, B.idl and C.idl.
(5) A.h and A.cpp are updated. B.h, B.cpp, C.h and C.cpp are not updated.

(6) Second build.
(7) Since B.h, B.cpp, C.h and C.cpp are older than supplemental_dependency.tmp, generate-bindings.pl runs for B.idl and C.idl.
(8) B.h, B.cpp, C.h and C.cpp are not updated.

(9) Third build.
(10) Since B.h, B.cpp, C.h and C.cpp are older than supplemental_dependency.tmp, generate-bindings.pl runs for B.idl and C.idl.
(11) B.h, B.cpp, C.h and C.cpp are not updated.
...

We should fix the bug somehow, but how to fix it is not obvious.
For the time being, this patch invalidates r105697, r105766, r105809
and r105805.

No tests. No change in behavior.

  • bindings/scripts/CodeGenerator.pm:

(UpdateFile):

  • bindings/scripts/CodeGeneratorCPP.pm:

(WriteData):

  • bindings/scripts/CodeGeneratorJS.pm:

(WriteData):

  • bindings/scripts/CodeGeneratorObjC.pm:

(WriteData):

  • bindings/scripts/CodeGeneratorV8.pm:

(WriteData):

18:20 Changeset [105843] by ericu@chromium.org
  • 6 edits in trunk/Source/WebCore

Add full support for filesystem URLs.
https://bugs.webkit.org/show_bug.cgi?id=75049

Reviewed by Adam Barth.

No new tests; existing layout tests cover the basic functionality, and
the new functionality won't be there until Chromium adds it. This patch
merely enables that, without changing behavior.

  • fileapi/EntryBase.cpp:

(WebCore::EntryBase::toURL): Add missing escaping of URL path.

  • page/SecurityOrigin.cpp:

(WebCore::extractInnerURL): Use innerURL member, if it's populated.

  • platform/KURL.h:

(WebCore::KURL::innerURL): Add innerURL member.

  • platform/KURLGoogle.cpp:

(WebCore::KURLGooglePrivate::KURLGooglePrivate):
(WebCore::KURLGooglePrivate::operator=):
Add copy constructor and operator=, which are now needed since
m_innerURL needs special handling.
(WebCore::KURLGooglePrivate::setUtf8):
(WebCore::KURLGooglePrivate::setAscii):
Add calls to initInnerURL.
(WebCore::KURLGooglePrivate::initInnerURL):
Add method to init/copy m_innerURL.
(WebCore::KURLGooglePrivate::copyTo):
Handle m_innerURL during copies.
(WebCore::encodeWithURLEscapeSequences):
Unescape %2F / in paths; it's much more readable, and it's safe.

  • platform/KURLGooglePrivate.h:

(WebCore::KURLGooglePrivate::innerURL): Add accessor for new m_innerURL.

18:13 Changeset [105842] by ojan@chromium.org
  • 2 edits in trunk/Tools

Initializing the browser property of the Bugzilla class takes too long
https://bugs.webkit.org/show_bug.cgi?id=76960

Reviewed by Adam Barth.

Lazily initialize it. This saves ~150ms on a no-op run-webkit-tests call
on my Mac Pro.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(Bugzilla.init):
(Bugzilla._get_browser):
(Bugzilla):
(Bugzilla._set_browser):

18:02 Changeset [105841] by barraclough@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=76855
Implement a JIT-code aware sampling profiler for JSC

Reviewed by Oliver Hunt.

Add support to MetaAllocator.cpp to track all live handles in a map,
allowing lookup based on any address within the allocation.

  • wtf/MetaAllocator.cpp:

(WTF::MetaAllocatorTracker::notify):
(WTF::MetaAllocatorTracker::release):

  • Track live handle objects in a map.

(WTF::MetaAllocator::release):

  • Removed support for handles with null m_allocator (no longer used).
  • Notify the tracker of handles being released.

(WTF::MetaAllocatorHandle::~MetaAllocatorHandle):

  • Moved functionality out into MetaAllocator::release.

(WTF::MetaAllocatorHandle::shrink):

  • Removed support for handles with null m_allocator (no longer used).

(WTF::MetaAllocator::MetaAllocator):

  • Initialize m_tracker.

(WTF::MetaAllocator::allocate):

  • Notify the tracker of new allocations.
  • wtf/MetaAllocator.h:

(WTF::MetaAllocatorTracker::find):

  • Lookup a MetaAllocatorHandle based on an address inside the allocation.

(WTF::MetaAllocator::trackAllocations):

  • Register a callback object to track allocation state.
  • wtf/MetaAllocatorHandle.h:
    • Remove unused createSelfManagedHandle/constructor.

(WTF::MetaAllocatorHandle::key):

  • Added, for use in RedBlackTree.
17:44 Changeset [105840] by mrowe@apple.com
  • 9 edits
    1 delete in trunk

Death to JavaScriptGlue.

Rubber-stamped by Geoffrey Garen.

.:

  • Source/JavaScriptGlue: Removed.
  • Source/Makefile: Stop building JavaScriptGlue.

Tools:

  • BuildSlaveSupport/build-launcher-app:

(copyNightlyLauncher):

  • Scripts/build-webkit:
  • Scripts/do-file-rename:
  • Scripts/do-webcore-rename:
  • Scripts/webkitpy/common/config/build.py:

(_should_file_trigger_build):

  • Scripts/webkitpy/common/config/build_unittest.py: Update the test to use another Mac-specific

path in conjunction with a cross-platform path.
(ShouldBuildTest):

17:40 Changeset [105839] by lforschler@apple.com
  • 5 edits in tags/Safari-535.18.3/Source

Versioning.

17:38 Changeset [105838] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Mark test as flaky.

  • platform/chromium/test_expectations.txt:
17:19 Changeset [105837] by haraken@chromium.org
  • 8 edits
    2 adds in trunk/Tools

webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl should test stdout and stderr
https://bugs.webkit.org/show_bug.cgi?id=75836

Reviewed by David Kilzer.

Previously parser_unittests.pl can just test the returned value of
get_function_line_ranges() in prepare-ChangeLog. This patch fixes
parser_unittests.pl so that it also tests the stdout and stderr of
get_function_line_ranges().

This patch adds css_unittests_warning.css, which contains test cases
for warning messages of the CSS parser of prepare-ChangeLog.

  • Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:

(captureOutput): Captures the stdout and stderr of a given method.
(convertAbsolutepathToWebKitPath): Converts absolute paths in a given
string to relative paths.

  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt: Added.
  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css: Added.

(element1):
(element2):
(element3):
(element4):
():
(element5):
(element6):

  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:

Just updated the test results, i.e. added stdout and stderr results.
No essential changes in the test results.

  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Ditto.
  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests-expected.txt: Ditto.
  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Ditto.
  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt: Ditto.
  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt: Ditto.
17:14 Changeset [105836] by lforschler@apple.com
  • 9 edits in tags/Safari-535.18.3/Source/WebKit2

Merged 105517 and 105806.

17:03 Changeset [105835] by dpranke@chromium.org
  • 2 edits in trunk/Tools

webkitpy: new-run-webkit-httpd is broken
https://bugs.webkit.org/show_bug.cgi?id=76963

Reviewed by Adam Barth.

r105674 broke new-run-webkit-httpd, since options.chromium
doesn't exist any more. We didn't catch this because we don't
run the integration tests by default anywhere :(.

  • Scripts/new-run-webkit-httpd:

(run):
(main):

16:56 Changeset [105834] by abarth@webkit.org
  • 2 edits in trunk/Tools

garden-o-matic pixel zoomer should let you look at every pixel of the image
https://bugs.webkit.org/show_bug.cgi?id=76962

Reviewed by Ojan Vafai.

Previously, you couldn't get up to the right and bottom pixels.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:
16:48 Changeset [105833] by lforschler@apple.com
  • 1 copy in tags/Safari-535.18.3

New Tag.

16:27 Changeset [105832] by mrowe@apple.com
  • 5 edits in trunk

Clear some bogus executable bits that r105828 set.

16:22 Changeset [105831] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add Linux-specific overrides.

  • platform/chromium-linux/fast/css/min-width-with-spanned-cell-expected.png: Added.
  • platform/chromium-linux/fast/css/min-width-with-spanned-cell-fixed-expected.png: Added.
16:16 Changeset [105830] by eae@chromium.org
  • 1520 edits
    981 copies
    87 deletes in branches/subpixellayout

Merging trunk changes up until 105803 into subpixel branch.

15:58 Changeset [105829] by enrica@apple.com
  • 4 edits in trunk

WebHTMLView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
https://bugs.webkit.org/show_bug.cgi?id=76951
<rdar://problem/9325158>

Source/WebKit/mac:

The Inspector bar calls the typingAttributes methods on the clients that support it
to retrieve the set of attributes representing the style at the selection and uses
this information to update the state of the B, I and U buttons.
If this method is not supported, it defaults to the attributes of the previous
character position, reporting an incorrect state.
This occurs only when we have a caret selection.

Reviewed by Alexey Proskuryakov.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _styleForAttributeChange:]): Removed dead code.
(-[WebHTMLView _updateFontPanel]): Removed comment that doesn't apply anymore.
(-[WebHTMLView typingAttributes]): Added.

Tools:

Added test to verify that WebHTMLView supports the typingAttributes method and that it
works as expected.

Reviewed by Alexey Proskuryakov.

  • TestWebKitAPI/Tests/mac/InspectorBar.mm:

(TestWebKitAPI::TEST):

15:53 Changeset [105828] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Crash in updateFirstLetter() from unnecessary anonymous block
https://bugs.webkit.org/show_bug.cgi?id=72675

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-01-24
Reviewed by David Hyatt.

Source/WebCore:

There was a problem with anonymous blocks not getting removed when
their only block flow siblings are removed if they also have non-block
flow first-letter siblings (i.e. floats). This patch modifies
RenderBlock::removeChild() to look for this situation and strip out
unnecessary anonymous container blocks if it occurs.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeChild):
(WebCore::RenderBlock::collapseAnonymousBoxChild): Added

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::collapseAnonymousBoxChild): Added

LayoutTests:

Adding a test that cause a div to be removed from between a floating
first-letter block and its remaining text. If the anonymous block is
removed as an immediate consequence of the div removal, this shouldn't
crash.

  • fast/css-generated-content/float-first-letter-siblings-convert-to-inline-expected.txt: Added
  • fast/css-generated-content/float-first-letter-siblings-convert-to-inline.html: Added
15:51 Changeset [105827] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Mark these tests as flaky.

  • platform/chromium/test_expectations.txt:
15:48 Changeset [105826] by dcheng@chromium.org
  • 11 edits
    1 copy
    1 add in trunk

[chromium] event.dataTransfer.types should not return "Text" or "URL"
https://bugs.webkit.org/show_bug.cgi?id=76218

Source/WebCore:

Per the spec, "Text" and "URL" are special values handled for IE compatibility reasons in
dataTransfer.setData() and dataTransfer.getData(). These values should not be exposed
elsewhere.

Reviewed by Tony Chang.

Test: fast/events/dropzone-005.html

  • platform/chromium/ChromiumDataObject.cpp:

(WebCore::ChromiumDataObject::types):
(WebCore::ChromiumDataObject::getData):

  • platform/chromium/DragDataChromium.cpp:

(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::canSmartReplace):

LayoutTests:

Reviewed by Tony Chang.

  • editing/pasteboard/dataTransfer-setData-getData-expected.txt:
  • fast/events/dropzone-002.html:
  • fast/events/dropzone-005-expected.txt: Added.
  • fast/events/dropzone-005.html: Modified from LayoutTests/fast/events/dropzone-002.html.
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt/Skipped:
  • platform/win-wk2/Skipped:
15:46 Changeset [105825] by dcheng@chromium.org
  • 6 edits in trunk/Source/WebCore

Make DataTransferItemList::length() const.
https://bugs.webkit.org/show_bug.cgi?id=76946

Just a const-correctness change.

Reviewed by Tony Chang.

No new tests since no functionality changed.

  • dom/DataTransferItemList.h:

(DataTransferItemList):

  • platform/chromium/DataTransferItemListChromium.cpp:

(WebCore::DataTransferItemListChromium::length):

  • platform/chromium/DataTransferItemListChromium.h:

(DataTransferItemListChromium):

  • platform/qt/DataTransferItemListQt.cpp:

(WebCore::DataTransferItemListQt::length):

  • platform/qt/DataTransferItemListQt.h:

(DataTransferItemListQt):

15:37 Changeset [105824] by inferno@chromium.org
  • 1 edit
    2 deletes in branches/chromium/963

Revert 105795 - Merge 105685 - Crash in WebCore::RenderTableSection::rowLogicalHeightChanged
BUG=108918
Review URL: https://chromiumcodereview.appspot.com/9214019

TBR=tsepez@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9271032

15:34 Changeset [105823] by abarth@webkit.org
  • 5 edits
    7 adds in trunk/LayoutTests

Update table image baselines after http://trac.webkit.org/changeset/105775.

  • platform/chromium-mac-leopard/fast/table/027-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/min-width-with-spanned-cell-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/min-width-with-spanned-cell-fixed-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/table/027-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/table/027-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/table/027-vertical-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/027-vertical-expected.txt: Added.
  • platform/chromium-win/fast/css/min-width-with-spanned-cell-expected.png: Added.
  • platform/chromium-win/fast/css/min-width-with-spanned-cell-fixed-expected.png: Added.
  • platform/chromium-win/fast/table/027-expected.png:
  • platform/chromium-win/fast/table/027-vertical-expected.png:
15:30 Changeset [105822] by abarth@webkit.org
  • 1 edit
    5 adds
    2 deletes in trunk/LayoutTests

More tweaks after leviw's updating of Mac baselines.

  • platform/chromium-linux-x86/fast/multicol: Removed.
  • platform/chromium-linux/fast/multicol/span/generated-child-split-flow-crash-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/geometry/rtl-composited-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/visibility/visibility-simple-canvas2d-layer-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/visibility/visibility-simple-webgl-layer-expected.png: Added.
  • platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Added.
  • platform/mac-snowleopard/fast/multicol/span/generated-child-split-flow-crash-expected.txt: Removed.
15:27 WebKit Team edited by haraken@chromium.org
(diff)
15:26 Changeset [105821] by kerz@chromium.org
  • 1 edit in branches/chromium/963/LayoutTests/platform/chromium/test_expectations.txt

fix branch test expectations

15:21 Changeset [105820] by tony@chromium.org
  • 4 edits
    2 adds in trunk

REGRESSION(r103245): can't scroll left/up using scrollbar controls of overflowing elements
https://bugs.webkit.org/show_bug.cgi?id=76317

Reviewed by Darin Adler.

Source/WebCore:

Test: scrollbars/scroll-rtl-or-bt-layer.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateScrollInfoAfterLayout): Call scrollToOffsetWithoutAnimation since we're always
scrolling to the just computed offset.

LayoutTests:

  • platform/win/Skipped:
  • scrollbars/scroll-rtl-or-bt-layer-expected.txt: Added.
  • scrollbars/scroll-rtl-or-bt-layer.html: Added.
15:14 Changeset [105819] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Fix all of the builds after r105812.

  • loader/EmptyClients.h: Move the #include in to the correct #if.
15:07 Changeset [105818] by inferno@chromium.org
  • 4 edits
    2 copies in branches/chromium/963

Merge 104121 - Source/WebCore: Crash in RenderRegion::getRegionRangeForBox.
clearRenderRegionRangeMap breakage fixed by replacing statements from https://trac.webkit.org/changeset/102234
BUG=107758
Review URL: https://chromiumcodereview.appspot.com/9113038

15:00 Changeset [105817] by inferno@chromium.org
  • 4 edits
    2 deletes in branches/chromium/963

Revert 105784 - Merge 104121 - Source/WebCore: Crash in RenderRegion::getRegionRangeForBox.
BUG=107758
Review URL: https://chromiumcodereview.appspot.com/9129033

TBR=inferno@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9290001

14:54 Changeset [105816] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Use copying collector for out-of-line JSObject property storage
https://bugs.webkit.org/show_bug.cgi?id=76665

Reviewed by Geoffrey Garen.

  • runtime/JSObject.cpp:

(JSC::JSObject::visitChildren): Changed to use copyAndAppend whenever the property storage is out-of-line.
Also added a temporary variable to avoid warnings from GCC.
(JSC::JSObject::allocatePropertyStorage): Changed to use tryAllocateStorage/tryReallocateStorage as opposed to
operator new. Also added a temporary variable to avoid warnings from GCC.

  • runtime/JSObject.h:
14:52 Changeset [105815] by dslomov@google.com
  • 4 edits in trunk/Source/WebCore

[Chromium][V8] DOMWindow::postMessage crashes if window disassociated with frame.
https://bugs.webkit.org/show_bug.cgi?id=76944.

Reviewed by David Levin.

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::retrieveWindowForCallingContext):

  • bindings/v8/V8Proxy.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::handlePostMessageCallback):

14:39 Changeset [105814] by levin@chromium.org
  • 3 edits in trunk/LayoutTests

Change reference of revokeObjectURL in worker-apply-blob-url-to-xhr.html to use webkitURL.
https://bugs.webkit.org/show_bug.cgi?id=76942

Reviewed by Jian Li.

  • fast/files/workers/resources/worker-apply-blob-url-to-xhr.js:

(onmessage):

  • platform/chromium/test_expectations.txt:
14:36 Changeset [105813] by ggaren@apple.com
  • 9 edits in trunk/Source/WebCore

Updated bindings test expectations after my last patch.

Not reviewed.

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::jsTestActiveDOMObjectPrototypeFunctionPostMessage):

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructorConstructor::constructJSTestEventConstructor):

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::jsTestEventTargetPrototypeFunctionAddEventListener):
(WebCore::jsTestEventTargetPrototypeFunctionRemoveEventListener):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::constructJSTestInterface):
(WebCore::setJSTestInterfaceSupplementalStr2):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::setJSTestObjStringAttr):
(WebCore::setJSTestObjStringAttrWithGetterException):
(WebCore::setJSTestObjStringAttrWithSetterException):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionAddEventListener):
(WebCore::jsTestObjPrototypeFunctionRemoveEventListener):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod12):
(WebCore::jsTestObjPrototypeFunctionStrictFunction):

  • bindings/scripts/test/JS/JSTestOverridingNameGetter.cpp:

(WebCore::jsTestOverridingNameGetterPrototypeFunctionAnotherFunction):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):

14:36 Changeset [105812] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Change dispatchIntent API to pure virtual in FrameLoaderClient.

The Windows compiler needs this to deal with the forward declaration
of WebCore::IntentRequest.
https://bugs.webkit.org/show_bug.cgi?id=76940

Patch by Greg Billock <gbillock@google.com> on 2012-01-24
Reviewed by Adam Barth.

  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::dispatchIntent):

  • loader/FrameLoaderClient.h:
14:31 Changeset [105811] by ggaren@apple.com
  • 3 edits
    2 adds in trunk

JSValue::toString() should return a JSString* instead of a UString
https://bugs.webkit.org/show_bug.cgi?id=76861

Source/JavaScriptCore:

Fixed two failing layout tests after my last patch.

Reviewed by Gavin Barraclough.

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncSort): Call value() after calling toString(), as
in all other cases.

I missed this case because the JSString* type has a valid operator<,
so the compiler didn't complain.

LayoutTests:

Reviewed by Gavin Barraclough.

Added a unit test for something I got wrong while writing this patch.

  • fast/js/add-to-primitive-expected.txt: Added.
  • fast/js/add-to-primitive.html: Added.
14:25 Changeset [105810] by inferno@chromium.org
  • 3 edits
    2 copies in branches/chromium/963

Merge 105768 - Incorrect positioning of floating pseudo-elements in table captions
BUG=105133
Review URL: https://chromiumcodereview.appspot.com/9271030

14:24 Changeset [105809] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

CodeGeneratorJS.pm should overwrite the output .h/.cpp
only if the bytes differ
https://bugs.webkit.org/show_bug.cgi?id=76922

Reviewed by Darin Adler.

This is one of steps to stop rebuilding .h/.cpp files
generated by unchanged IDLs (bug 76836).
This patch makes a change on CodeGeneratorJS.pm so that
it overwrites the output .h/.cpp only if the bytes differ.

No tests. No change in behavior.
I manually confirmed that when I add a new attribute to Element.idl,
the time-stamps of unrelated JS*.h and JS*.cpp do not change.

  • bindings/scripts/CodeGeneratorJS.pm:

(WriteData): Used UpdateFileIfChanged().

14:23 Changeset [105808] by inferno@chromium.org
  • 15 edits
    5 copies in branches/chromium/963

Merge 100473 - CSS 2.1 failure: border-collapse-offset-002.htm fails
BUG=109094

14:17 Changeset [105807] by tsepez@chromium.org
  • 3 edits
    2 deletes in branches/chromium/963

Revert 105788 - Merge 105768 - Incorrect positioning of floating pseudo-elements in table captions
BUG=105133
Review URL: https://chromiumcodereview.appspot.com/9117049

TBR=inferno@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9271029

14:10 Changeset [105806] by bdakin@apple.com
  • 2 edits in trunk/Source/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=76928
Accelerated drawing should force compositing mode
-and corresponding-
<rdar://problem/10697417>

Reviewed by Simon Fraser.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

14:09 Changeset [105805] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

CodeGeneratorCPP.pm should overwrite the output .h/.cpp
only if the bytes differ
https://bugs.webkit.org/show_bug.cgi?id=76926

Reviewed by Adam Barth.

This is one of steps to stop rebuilding .h/.cpp files
generated by unchanged IDLs (bug 76836).
This patch makes a change on CodeGeneratorCPP.pm so that
it overwrites the output .h/.cpp only if the bytes differ.

No tests. No change in behavior.
Manually confirm that when you add a new attribute to Element.idl,
the time-stamps of unrelated WebDOM*.h and WebDOM*.cpp do not change.

  • bindings/scripts/CodeGeneratorCPP.pm:

(WriteData): Used UpdateFileIfChanged().

14:04 Changeset [105804] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r105238.
http://trac.webkit.org/changeset/105238
https://bugs.webkit.org/show_bug.cgi?id=76943

Remove the assert text hack as it served its purpose.
(Requested by dave_levin on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-24

  • dom/ActiveDOMObject.cpp:

(WebCore::ContextDestructionObserver::ContextDestructionObserver):
(WebCore::ContextDestructionObserver::~ContextDestructionObserver):
(WebCore::ActiveDOMObject::ActiveDOMObject):
(WebCore::ActiveDOMObject::~ActiveDOMObject):

  • storage/DatabaseSync.cpp:

(WebCore::DatabaseSync::openDatabaseSync):
(WebCore::DatabaseSync::~DatabaseSync):
(WebCore::DatabaseSync::changeVersion):
(WebCore::DatabaseSync::runTransaction):

13:43 Changeset [105803] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[Refactoring] In CodeGeneratorGObject.pm, merge
GeneratePrivateHeader() into WriteData()
https://bugs.webkit.org/show_bug.cgi?id=76923

Reviewed by Adam Barth.

This patch merges GeneratePrivateHeader() into WriteData(),
so that all code to output .h/.cpp is managed by WriteData(),
just like other CodeGenerator*.pm does.

No tests. No change in behavior.
Confirm that GTK/GObject build passes.

  • bindings/scripts/CodeGeneratorGObject.pm:

(Generate):
(WriteData): Copied GeneratePrivateHeader() to here.
Removed $hasLegacyParen, $hasRealParent and $hasParent
since they are not used.
(GenerateInterface):

13:38 Changeset [105802] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add expected results for test introduced in http://trac.webkit.org/changeset/105769

  • fast/multicol/span/generated-child-split-flow-crash-expected.png: Added.
  • fast/multicol/span/generated-child-split-flow-crash-expected.txt: Added.
13:38 Changeset [105801] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Put a space between the trac link and ellipsis in sheriffbot rollout message so it linkifies better in some IRC clients
https://bugs.webkit.org/show_bug.cgi?id=76884

Patch by James Robinson <jamesr@chromium.org> on 2012-01-24
Reviewed by Adam Barth.

  • Scripts/webkitpy/tool/bot/irc_command.py:

(Rollout.execute):

  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:

(SheriffIRCBotTest.test_rollout):
(SheriffIRCBotTest.test_revert):
(SheriffIRCBotTest.test_multi_rollout):
(SheriffIRCBotTest.test_rollout_with_r_in_svn_revision):
(SheriffIRCBotTest.test_multi_rollout_with_r_in_svn_revision):
(SheriffIRCBotTest.test_rollout_invalidate_reason):
(test_multi_rollout_invalidate_reason):

13:32 Changeset [105800] by dcheng@chromium.org
  • 4 edits in trunk

dropzone does not normalize type strings
https://bugs.webkit.org/show_bug.cgi?id=76925

Source/WebCore:

Per the HTML spec, we are supposed to normalize types during dropzone processing by
lowercasing them.

Reviewed by Tony Chang.

Tests: fast/events/dropzone-002.html

  • dom/Clipboard.cpp:

(WebCore::Clipboard::hasDropZoneType):

LayoutTests:

Reviewed by Tony Chang.

  • fast/events/dropzone-002.html: Update layout test to check case normalization as well.
13:31 Changeset [105799] by robert@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

Qt and Gtk results for tests added in r105775

Unreviewed.

  • platform/gtk/fast/css/min-width-with-spanned-cell-expected.txt: Added.
  • platform/gtk/fast/css/min-width-with-spanned-cell-fixed-expected.txt: Added.
  • platform/qt/fast/css/min-width-with-spanned-cell-expected.txt: Added.
  • platform/qt/fast/css/min-width-with-spanned-cell-fixed-expected.txt: Added.
13:27 Changeset [105798] by tsepez@chromium.org
  • 5 edits in branches/chromium/963/Source/WebCore/loader

Merge 105226 - Ensure we don't cancel revalidation of a CachedResource
in the middle of successful revalidation.
It's more reliable to enforce this in CachedResource than in
SubresourceLoader.
BUG=108544
Review URL: https://chromiumcodereview.appspot.com/9283038

13:27 Changeset [105797] by haraken@chromium.org
  • 4 edits in trunk/Tools

The cpp parser of prepare-ChangeLog cannot detect a change in classes and namespaces
https://bugs.webkit.org/show_bug.cgi?id=75531

Reviewed by David Kilzer.

Previously, the cpp parser of prepare-ChangeLog could not detect a change
outside methods. Consider the following cpp file.

namespace N {
int a; this change does not appear on ChangeLog.
class C {

int b; this change does not appear on ChangeLog.
void f()
{

int c; this change appears on ChangeLog.

}
int d; this change does not appear on ChangeLog.

};
int e; this change does not appear on ChangeLog.
};

The previous prepare-ChangeLog outputs just methods in which a change is found:

(N::C::f):

This patch fixes prepare-ChangeLog so that it outputs namespaces, classes
and methods in which a change is found:

(N):
(N::C):
(N::C::f):

  • Scripts/prepare-ChangeLog:

(get_function_line_ranges_for_cpp): Modified as described above.

  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.

(Class104):
(Class105):
(Class106):
(Class106::func32):
(Class106::func33):
(NameSpace3):
(NameSpace4):
(NameSpace5):
(NameSpace6):
(Class107):
(NameSpace5::NameSpace6::Class107::func34):

  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
13:24 Changeset [105796] by haraken@chromium.org
  • 3 edits in trunk/Tools

prepare-ChangeLog outputs warnings for top-level { ... } blocks
https://bugs.webkit.org/show_bug.cgi?id=75943

Reviewed by David Kilzer.

Currently, prepare-ChangeLog outputs warnings for top-level { ... } blocks,
because it does not distinguish '}' at the end of a subroutine
with '}' at the end of a if or for statement.

foo.pl:

if (1) {
}
for (@v) {
}

output:

nested functions found at top-level at foo.pl:2
nested functions found at top-level at foo.pl:4

This patch fixes the bug.

  • Scripts/prepare-ChangeLog:

(get_function_line_ranges_for_perl):

  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:

Added test cases. No change in the test results.

13:23 Changeset [105795] by tsepez@chromium.org
  • 1 edit
    2 copies in branches/chromium/963

Merge 105685 - Crash in WebCore::RenderTableSection::rowLogicalHeightChanged
BUG=108918
Review URL: https://chromiumcodereview.appspot.com/9214019

13:22 Changeset [105794] by dslomov@google.com
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed: removing WebWorker.h again after r105684.

  • WebKit.gyp:
13:20 Changeset [105793] by dpranke@chromium.org
  • 2 edits in trunk/Tools

r105674 broke check-webkit-style for chromium's test_expectations.

Unreviewed, build fix.

We now need to pass in a platform name of 'chromium' if we want
the chromium port; options.chromium is no longer recognized. I
will follow this patch up with a separate patch that has a test,
but this at least fixes the build.

  • Scripts/webkitpy/style/checkers/test_expectations.py:

(TestExpectationsChecker._determine_port_from_exepectations_path):

13:18 Changeset [105792] by inferno@chromium.org
  • 1 edit
    3 copies in branches/chromium/963

Merge 105769 - Crash when rendering -webkit-column-span.
BUG=105459
Review URL: https://chromiumcodereview.appspot.com/9129034

13:18 Changeset [105791] by mario@webkit.org
  • 24 edits in trunk/Source/WebCore

[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

Don't expose functions for the ATK interfaces in header files.

Expose only the initialization function for each interface, and
use the generic functions from ATK interfaces where needed.

  • accessibility/gtk/WebKitAccessibleInterfaceAction.cpp:

(webkitAccessibleActionDoAction): Made this function static.
(webkitAccessibleActionGetNActions): Ditto.
(webkitAccessibleActionGetDescription): Ditto.
(webkitAccessibleActionGetKeybinding): Ditto.
(webkitAccessibleActionGetName): Ditto.
(webkitAccessibleActionInterfaceInit): Moved to the bottom.

  • accessibility/gtk/WebKitAccessibleInterfaceAction.h: Removed all

functions but the one for initializing the interface from here.

  • accessibility/gtk/WebKitAccessibleInterfaceComponent.cpp:

(webkitAccessibleComponentRefAccessibleAtPoint): Made this function static.
(webkitAccessibleComponentGetExtents): Ditto.
(webkitAccessibleComponentGrabFocus): Ditto.
(webkitAccessibleComponentInterfaceInit): Moved to the bottom.

  • accessibility/gtk/WebKitAccessibleInterfaceComponent.h: Removed all

functions but the one for initializing the interface from here.

  • accessibility/gtk/WebKitAccessibleInterfaceDocument.cpp:

(webkitAccessibleDocumentGetAttributeValue): Made this function static.
(webkitAccessibleDocumentGetAttributes): Ditto.
(webkitAccessibleDocumentGetLocale): Ditto.
(webkitAccessibleDocumentInterfaceInit): Moved to the bottom.

  • accessibility/gtk/WebKitAccessibleInterfaceDocument.h: Removed all

functions but the one for initializing the interface from here.

  • accessibility/gtk/WebKitAccessibleInterfaceEditableText.cpp:

(webkitAccessibleEditableTextSetRunAttributes): Made this function static.
(webkitAccessibleEditableTextSetTextContents): Ditto.
(webkitAccessibleEditableTextInsertText): Ditto.
(webkitAccessibleEditableTextCopyText): Ditto.
(webkitAccessibleEditableTextCutText): Ditto.
(webkitAccessibleEditableTextDeleteText): Ditto.
(webkitAccessibleEditableTextPasteText): Ditto.
(webkitAccessibleEditableTextInterfaceInit): Moved to the bottom.

  • accessibility/gtk/WebKitAccessibleInterfaceEditableText.h: Removed all

functions but the one for initializing the interface from here.

  • accessibility/gtk/WebKitAccessibleInterfaceHyperlinkImpl.cpp:

(webkitAccessibleHyperlinkImplGetHyperlink): Made this function static.
(webkitAccessibleHyperlinkImplInterfaceInit): Moved to the bottom.

  • accessibility/gtk/WebKitAccessibleInterfaceHyperlinkImpl.h: Removed all

functions but the one for initializing the interface from here.

  • accessibility/gtk/WebKitAccessibleInterfaceHypertext.cpp:

(webkitAccessibleHypertextGetLink): Made this function static.
(webkitAccessibleHypertextGetNLinks): Ditto.
(webkitAccessibleHypertextGetLinkIndex): Ditto.
(webkitAccessibleHypertextInterfaceInit): Moved to the bottom.

  • accessibility/gtk/WebKitAccessibleInterfaceHypertext.h: Removed all

functions but the one for initializing the interface from here.

  • accessibility/gtk/WebKitAccessibleInterfaceImage.cpp:

(webkitAccessibleImageGetImagePosition): Made this function static.
(webkitAccessibleImageGetImageDescription): Ditto.
(webkitAccessibleImageGetImageSize): Ditto.
(webkitAccessibleImageInterfaceInit): Moved to the bottom.

  • accessibility/gtk/WebKitAccessibleInterfaceImage.h: Removed all

functions but the one for initializing the interface from here.

  • accessibility/gtk/WebKitAccessibleInterfaceSelection.cpp:

(webkitAccessibleSelectionAddSelection): Made this function static.
(webkitAccessibleSelectionClearSelection): Ditto.
(webkitAccessibleSelectionRefSelection): Ditto.
(webkitAccessibleSelectionGetSelectionCount): Ditto.
(webkitAccessibleSelectionIsChildSelected): Ditto.
(webkitAccessibleSelectionRemoveSelection): Ditto.
(webkitAccessibleSelectionSelectAllSelection): Ditto.
(webkitAccessibleSelectionInterfaceInit): Moved to the bottom.

  • accessibility/gtk/WebKitAccessibleInterfaceSelection.h: Removed all

functions but the one for initializing the interface from here.

  • accessibility/gtk/WebKitAccessibleInterfaceTable.cpp:

(webkitAccessibleTableRefAt): Made this function static.
(webkitAccessibleTableGetIndexAt): Ditto.
(webkitAccessibleTableGetColumnAtIndex): Ditto.
(webkitAccessibleTableGetRowAtIndex): Ditto.
(webkitAccessibleTableGetNColumns): Ditto.
(webkitAccessibleTableGetNRows): Ditto.
(webkitAccessibleTableGetColumnExtentAt): Ditto.
(webkitAccessibleTableGetRowExtentAt): Ditto.
(webkitAccessibleTableGetColumnHeader): Ditto.
(webkitAccessibleTableGetRowHeader): Ditto.
(webkitAccessibleTableGetCaption): Ditto.
(webkitAccessibleTableGetColumnDescription): Ditto.
(webkitAccessibleTableGetRowDescription): Ditto.
(webkitAccessibleTableInterfaceInit): Moved to the bottom.

  • accessibility/gtk/WebKitAccessibleInterfaceTable.h: Removed all

functions but the one for initializing the interface from here.

  • accessibility/gtk/WebKitAccessibleInterfaceText.cpp:

(textForRenderer): Made this function static.
(textForObject): Ditto.
(webkitAccessibleTextGetText): Ditto.
(webkitAccessibleTextGetTextAfterOffset): Ditto.
(webkitAccessibleTextGetTextAtOffset): Ditto.
(webkitAccessibleTextGetTextBeforeOffset): Ditto.
(webkitAccessibleTextGetCharacterAtOffset): Ditto.
(webkitAccessibleTextGetCaretOffset): Ditto.
(webkitAccessibleTextGetRunAttributes): Ditto.
(webkitAccessibleTextGetDefaultAttributes): Ditto.
(webkitAccessibleTextGetCharacterExtents): Ditto.
(webkitAccessibleTextGetRangeExtents): Ditto.
(webkitAccessibleTextGetCharacterCount): Ditto.
(webkitAccessibleTextGetOffsetAtPoint): Ditto.
(webkitAccessibleTextGetNSelections): Ditto.
(webkitAccessibleTextGetSelection): Ditto.
(webkitAccessibleTextAddSelection): Ditto.
(webkitAccessibleTextSetSelection): Ditto.
(webkitAccessibleTextRemoveSelection): Ditto.
(webkitAccessibleTextSetCaretOffset): Ditto.
(webkitAccessibleTextInterfaceInit): Moved to the bottom.

  • accessibility/gtk/WebKitAccessibleInterfaceText.h: Removed all

functions but the one for initializing the interface from here.

  • accessibility/gtk/WebKitAccessibleInterfaceValue.cpp:

(webkitAccessibleValueGetCurrentValue): Made this function static.
(webkitAccessibleValueGetMaximumValue): Ditto.
(webkitAccessibleValueGetMinimumValue): Ditto.
(webkitAccessibleValueSetCurrentValue): Ditto.
(webkitAccessibleValueGetMinimumIncrement): Ditto.
(webkitAccessibleValueInterfaceInit): Moved to the bottom.

  • accessibility/gtk/WebKitAccessibleInterfaceValue.h: Removed all

functions but the one for initializing the interface from here.

  • accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetName): Replace call to
webkitAccessibleTextGetText with atk_text_get_text.

13:12 Changeset [105790] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/963

Merge 105750 - Crash when accessing removed parent in InlineTextBox.
BUG=105157
Review URL: https://chromiumcodereview.appspot.com/9160034

13:09 Changeset [105789] by scheib@chromium.org
  • 5 edits in trunk/Tools

check-webkit-style of the chromium test_expectations.txt file takes too long
https://bugs.webkit.org/show_bug.cgi?id=76745

Patch by Ojan Vafai <ojan@chromium.org> on 2012-01-20
Reviewed by Dimitri Glazkov.

When in lint mode, have TestExpectations test all configurations instead
of looping over each configuration. This also has the benefit of making
the error output considerably more concise.

Also, got rid of the double-printing of errors when linting through check-webkit-style.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.lint):

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations._report_errors):
(TestExpectations._add_expectations):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(test_parse_error_nonfatal):
(test_error_on_different_platform):

  • Scripts/webkitpy/style/checkers/test_expectations.py:

(TestExpectationsChecker.check_test_expectations):
(TestExpectationsChecker.check):

  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py:

(TestExpectationsTestCase.test_determine_port_from_exepectations_path):
(TestExpectationsTestCase.assert_lines_lint):

13:08 Changeset [105788] by inferno@chromium.org
  • 3 edits
    2 copies in branches/chromium/963

Merge 105768 - Incorrect positioning of floating pseudo-elements in table captions
BUG=105133
Review URL: https://chromiumcodereview.appspot.com/9117049

13:07 Changeset [105787] by tsepez@chromium.org
  • 1 edit
    2 copies in branches/chromium/963

Merge 105524 - Crash in xsltParseGlobalVariable.
BUG=109716
Review URL: https://chromiumcodereview.appspot.com/9285028

13:00 Changeset [105786] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/963

Merge 104845 - REGRESSION(r104060): Setting user stylesheet may leave CSSStyleSelector with stale rule pointers
BUG=109743
Review URL: https://chromiumcodereview.appspot.com/9212063

12:57 Changeset [105785] by tsepez@chromium.org
  • 1 edit
    3 copies in branches/chromium/963

Merge 105250 - Source/WebCore: Crash in FrameView::forceLayoutParentViewIfNeeded.
BUG=110112
Review URL: https://chromiumcodereview.appspot.com/9146052

12:55 Changeset [105784] by inferno@chromium.org
  • 4 edits
    2 copies in branches/chromium/963

Merge 104121 - Source/WebCore: Crash in RenderRegion::getRegionRangeForBox.
BUG=107758
Review URL: https://chromiumcodereview.appspot.com/9129033

12:51 Changeset [105783] by jamesr@google.com
  • 3 edits in trunk/Source/WebCore

[chromium] Add null check for ContentLayerChromium::m_delegate back to ContentLayerChromium::drawsContent()
https://bugs.webkit.org/show_bug.cgi?id=76887

Reviewed by Dimitri Glazkov.

A ContentLayerChromium's m_delegate pointer is nulled out when its owning GraphicsLayerChromium is destroyed.
It's possible in some circumstances for this to happen during painting. The null check for this pointer was
erroneously removed from the base class TiledLayerChromium in r105460.

No new tests since we don't know how to reproduce this sort of layer mutation during paint (not for lack of
trying!). Fix based on crash reports from the field.

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::drawsContent):

  • platform/graphics/chromium/ContentLayerChromium.h:
12:51 Changeset [105782] by inferno@chromium.org
  • 2 edits
    2 copies in branches/chromium/963

Merge 105542 - Crash in RenderTable::borderBefore
BUG=108207
Review URL: https://chromiumcodereview.appspot.com/9212061

12:48 Changeset [105781] by tsepez@chromium.org
  • 9 edits in branches/chromium/963

Merge 105612 - <feImage> has problems referencing local elements
BUG=110360
Review URL: https://chromiumcodereview.appspot.com/9117045

12:47 Changeset [105780] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/963

Merge 103650 - Fix crash when adding paragraph in contenteditable with role=textbox.
BUG=106671
Review URL: https://chromiumcodereview.appspot.com/9285027

12:43 Changeset [105779] by inferno@chromium.org
  • 1 edit in branches/chromium/963/Source/WebCore/rendering/RenderBlockLineLayout.cpp

Merge 105423 - Layout Test fast/text/international/spaces-combined-in-vertical-text.html is failing
BUG=90105
Review URL: https://chromiumcodereview.appspot.com/9212060

12:42 Changeset [105778] by abarth@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

Chromium Mac Lepoard overrides following the Chromium Mac Snow Leopard baselines.

  • platform/chromium-mac-leopard/css2.1/20110323/border-collapse-offset-002-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-collapse-offset-002-expected.txt: Added.
  • platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.png:
12:42 Changeset [105777] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/963

Merge 104322 - ASSERT failure due to combine-text with preceding spaces
BUG=90105
Review URL: https://chromiumcodereview.appspot.com/9284036

12:40 Changeset [105776] by tsepez@chromium.org
  • 1 edit
    3 copies in branches/chromium/963

Merge 105212 - Crash in in WebCore::EventHandler::mouseMoved.
BUG=110374
Review URL: https://chromiumcodereview.appspot.com/9160033

12:32 Changeset [105775] by robert@webkit.org
  • 9 edits
    6 adds in trunk

REGRESSION (r102040): Wrong column widths when row has colspan and unwrappable text
https://bugs.webkit.org/show_bug.cgi?id=74874

Reviewed by Julien Chaffraix.

Source/WebCore:

Tests: fast/css/min-width-with-spanned-cell-fixed.html

fast/css/min-width-with-spanned-cell.html

A cell with unwrappable text must be as wide as the text is long. If it is a colspan in a table whose
columns are all percent and the width of the span cell is wider than the cells it spans in any other
row then it will squeeze those cells beyond the width required to display their contents.

To fix this ensure that the squeezing of cells within a span respects the minimum width determined by
their contents. The squeezing remains for fixed layout tables as per FF and Opera.

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):

LayoutTests:

  • fast/css/min-width-with-spanned-cell-expected.png: Added.
  • fast/css/min-width-with-spanned-cell-expected.txt: Added.
  • fast/css/min-width-with-spanned-cell-fixed-expected.png: Added.
  • fast/css/min-width-with-spanned-cell-fixed-expected.txt: Added.
  • fast/css/min-width-with-spanned-cell-fixed.html: Added.
  • fast/css/min-width-with-spanned-cell.html: Added.
  • platform/chromium-linux/fast/table/027-expected.png:

1 px difference - benign

  • platform/chromium-linux/fast/table/027-vertical-expected.png:

This is a progression - previously the image in the last cell was
extruding from the table in a 800x600 view.

  • platform/chromium-win/fast/table/027-expected.txt:
  • platform/chromium-win/fast/table/027-vertical-expected.txt:
  • platform/mac/test_expectations.txt: Suppress 027* tests for rebaseline.
  • platform/win/test_expectations.txt: ditto

The 2 tests are skipped on gtk and qt.

12:29 Changeset [105774] by tommyw@google.com
  • 22 edits in trunk/Source

MediaStream API: Split the MediaStream track list into audio/video specific ones.
https://bugs.webkit.org/show_bug.cgi?id=76614

Source/WebCore:

The latest draft of the WebRTC standard have split the MediaStream combined track list
into audio/video specific ones.

Reviewed by Darin Fisher.

Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.

  • mediastream/LocalMediaStream.cpp:

(WebCore::LocalMediaStream::create):
(WebCore::LocalMediaStream::LocalMediaStream):

  • mediastream/LocalMediaStream.h:
  • mediastream/MediaStream.cpp:

(WebCore::processTrackList):
(WebCore::MediaStream::create):
(WebCore::MediaStream::MediaStream):

  • mediastream/MediaStream.h:

(WebCore::MediaStream::audioTracks):
(WebCore::MediaStream::videoTracks):

  • mediastream/MediaStream.idl:
  • mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::create):
(WebCore::MediaStreamTrack::MediaStreamTrack):
(WebCore::MediaStreamTrack::kind):
(WebCore::MediaStreamTrack::label):
(WebCore::MediaStreamTrack::enabled):
(WebCore::MediaStreamTrack::setEnabled):
(WebCore::MediaStreamTrack::component):

  • mediastream/MediaStreamTrack.h:
  • mediastream/UserMediaClient.h:
  • mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::mediaStreamSourcesQueryCompleted):
(WebCore::UserMediaRequest::succeed):

  • mediastream/UserMediaRequest.h:
  • platform/mediastream/MediaStreamCenter.cpp:

(WebCore::MediaStreamCenter::queryMediaStreamSources):
(WebCore::MediaStreamCenter::didSetMediaStreamTrackEnabled):

  • platform/mediastream/MediaStreamCenter.h:
  • platform/mediastream/MediaStreamDescriptor.h:

(WebCore::MediaStreamDescriptor::create):
(WebCore::MediaStreamDescriptor::numberOfAudioComponents):
(WebCore::MediaStreamDescriptor::audioComponent):
(WebCore::MediaStreamDescriptor::numberOfVideoComponents):
(WebCore::MediaStreamDescriptor::videoComponent):
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor):

Source/WebKit/chromium:

Reviewed by Darin Fisher.

  • public/WebUserMediaClient.h:

(WebKit::WebUserMediaClient::requestUserMedia):

  • public/WebUserMediaRequest.h:
  • public/platform/WebMediaStreamDescriptor.h:
  • src/UserMediaClientImpl.cpp:

(WebKit::UserMediaClientImpl::requestUserMedia):

  • src/UserMediaClientImpl.h:
  • src/WebMediaStreamDescriptor.cpp:

(WebKit::WebMediaStreamDescriptor::sources):
(WebKit::WebMediaStreamDescriptor::audioSources):
(WebKit::WebMediaStreamDescriptor::videoSources):
(WebKit::WebMediaStreamDescriptor::initialize):

  • src/WebUserMediaRequest.cpp:

(WebKit::WebUserMediaRequest::requestSucceeded):

12:27 Changeset [105773] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Unreviewed, rolling out r105738.
http://trac.webkit.org/changeset/105738
https://bugs.webkit.org/show_bug.cgi?id=76930

caused fast/css/getComputedStyle/computed-style-border-
image.html to crash (Requested by kling on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-24

  • dom/NamedNodeMap.cpp:
  • dom/NamedNodeMap.h:
  • dom/StyledElement.cpp:

(WebCore::StyledElement::updateStyleAttribute):
(WebCore::StyledElement::createInlineStyleDecl):
(WebCore::StyledElement::destroyInlineStyleDecl):
(WebCore::StyledElement::ensureInlineStyleDecl):
(WebCore::StyledElement::style):
(WebCore::StyledElement::addSubresourceAttributeURLs):

  • dom/StyledElement.h:

(WebCore::StyledElement::inlineStyleDecl):

12:24 Changeset [105772] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

REGRESSION (r73385): Marquee with behavior="alternate" is not working
https://bugs.webkit.org/show_bug.cgi?id=64230

Patch by Parag Radke <nrqv63@motorola.com> on 2012-01-24
Reviewed by Simon Fraser.

Source/WebCore:

This patch gives correct content width for marquee, which computes
correct start position to scroll marquee.

Test: fast/html/marquee-alternate.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computePreferredLogicalWidths):
We need(style()->marqueeBehavior() != MALTERNATE) check as we always need the marquee's
actual content width to compute the initial/end position in case of 'MALTERNATE'.
So we need to calculate the logical width in Alternate case even if fixed width is specified
as content has to animate between renderBox().right().x() - contentWidth() and
renderBox().left().x() + contentWidth().

  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::computePosition):
Using PreferredLogicalWidth in place of LayoutOverflow for calculating correct content width.

LayoutTests:

Added a test case to check marquee alternate behavior with fixed width.

  • fast/html/marquee-alternate-expected.txt: Added.
  • fast/html/marquee-alternate.html: Added.
12:22 Changeset [105771] by kling@webkit.org
  • 4 edits in trunk/Source/WebCore

RenderInline: Skip caching the computed line height.
<http://webkit.org/b/76929>

Reviewed by David Hyatt.

Stop caching the computed line height on RenderInline and make retrieving it from
RenderStyle slightly cheaper, freeing up 4 bytes per RenderInline instance.
This appears to be mostly performance neutral, I don't get more than the occasional
sample hit when instrumenting heavier web pages.

This reduces memory consumption by 228 kB (both 32/64-bit) when viewing the full
HTML5 spec at <http://whatwg.org/c>.

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::RenderInline):
(WebCore::RenderInline::styleDidChange):
(WebCore::RenderInline::lineHeight):

  • rendering/RenderInline.h:
  • rendering/style/RenderStyle.h:

(WebCore::RenderStyle::computedLineHeight):

Optimize computedLineHeight() to mitigate some of the damage of calling
it more often.

12:10 Changeset [105770] by ojan@chromium.org
  • 6 edits in trunk/Tools

check-webkit-style of the chromium test_expectations.txt file takes too long
https://bugs.webkit.org/show_bug.cgi?id=76745

Reviewed by Dimitri Glazkov.

When in lint mode, have TestExpectations test all configurations instead
of looping over each configuration. This also has the benefit of making
the error output considerably more concise.

Also, got rid of the double-printing of errors when linting through check-webkit-style.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.lint):

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations._report_errors):
(TestExpectations._add_expectations):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(test_parse_error_nonfatal):
(test_error_on_different_platform):

  • Scripts/webkitpy/style/checkers/test_expectations.py:

(TestExpectationsChecker.check_test_expectations):
(TestExpectationsChecker.check):

  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py:

(TestExpectationsTestCase.test_determine_port_from_exepectations_path):
(TestExpectationsTestCase.assert_lines_lint):

12:04 Changeset [105769] by inferno@chromium.org
  • 3 edits
    5 adds in trunk

Crash when rendering -webkit-column-span.
https://bugs.webkit.org/show_bug.cgi?id=73265

Reviewed by David Hyatt.

Source/WebCore:

This patch addresses 2 problems causing crashes in multi-column layout

  1. Trying to render -webkit-column-span for :before, :after caused re-entrancy in updateBeforeAfterContent while working on splitFlow.
  2. Cloning a block which has its :before, :after content not added yet, caused issues because cloneBlock will definitely have its :before, :after content created when setStyle() is called. So, we would overwrite cloneBlock with a wrong childrenInline value.

Tests: fast/multicol/clone-block-children-inline-mismatch-crash.html

fast/multicol/span/generated-child-split-flow-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::clone):
(WebCore::RenderBlock::columnsBlockForSpanningElement):

LayoutTests:

  • fast/multicol/clone-block-children-inline-mismatch-crash-expected.txt: Added.
  • fast/multicol/clone-block-children-inline-mismatch-crash.html: Added.
  • fast/multicol/span/generated-child-split-flow-crash.html: Added.
  • platform/mac-snowleopard/fast/multicol/span: Added.
  • platform/mac-snowleopard/fast/multicol/span/generated-child-split-flow-crash-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/span/generated-child-split-flow-crash-expected.txt: Added.
11:52 Changeset [105768] by robert@webkit.org
  • 5 edits
    2 adds in trunk

Incorrect positioning of floating pseudo-elements in table captions
https://bugs.webkit.org/show_bug.cgi?id=76664

Reviewed by Julien Chaffraix.

Source/WebCore:

Tests: fast/table/caption-encloses-overhanging-float-expected.html

fast/table/caption-encloses-overhanging-float.html

Allow table captions to expand and enclose overhanging floats. When performing
layout on a caption ensure that its logical top is set so that it does not mistakenly
conclude that floats in a previous sibling are intruding into it when they're not.

Mostly diagnosed by Abhishek Arya.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::expandsToEncloseOverhangingFloats): add table captions to the list

that can enclosed overhanging floats.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layoutCaption): use the best available approximation of the caption's logical

top offset before laying it out.

(WebCore::RenderTable::layout):

  • rendering/RenderTable.h:

LayoutTests:

  • fast/table/caption-encloses-overhanging-float-expected.html: Added.
  • fast/table/caption-encloses-overhanging-float.html: Added.
11:43 Changeset [105767] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merged r105556.

11:40 Changeset [105766] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

In CodeGeneratorV8.pm, overwrite the output .h/.cpp
only if the bytes differ
https://bugs.webkit.org/show_bug.cgi?id=76920

Reviewed by Darin Adler.

This is one of steps to stop rebuilding .h/.cpp files
generated by unchanged IDLs (bug 76836).
This patch makes a change on CodeGeneratorV8.pm so that
it overwrites the output .h/.cpp only if the bytes differ.

No tests. No change in behavior.
I manually confirmed that when I add a new attribute to Element.idl,
the time-stamps of unrelated V8*.h and V8*.cpp do not change.

  • bindings/scripts/CodeGeneratorV8.pm:

(WriteData): Used UpdateFileIfChanged().

11:39 Changeset [105765] by abarth@webkit.org
  • 2 edits
    7 adds
    6 deletes in trunk/LayoutTests

Similar to the change below, this patch creates Chromium Mac specific
baselines after the Apple Mac changes in
http://trac.webkit.org/changeset/105753.

  • fast/block/positioning/028-expected.txt: Added.
  • fast/block/positioning/031-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/images/cross-fade-tiled-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/positioning/028-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/positioning/031-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/table/height-percent-test-vertical-expected.png: Added.
  • platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug650-expected.png: Added.
  • platform/gtk/fast/block/positioning/028-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/031-expected.txt: Removed.
  • platform/mac/fast/block/positioning/028-expected.txt: Removed.
  • platform/mac/fast/block/positioning/031-expected.txt: Removed.
  • platform/qt/fast/block/positioning/028-expected.txt: Removed.
  • platform/qt/fast/block/positioning/031-expected.txt: Removed.
11:35 Changeset [105764] by lforschler@apple.com
  • 6 edits in branches/safari-534.54-branch/Source/JavaScriptCore

Merged r105638.

11:28 Changeset [105763] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebKit2

Merged r105558.

11:26 Changeset [105762] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix for Qt.

  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::showDebugBorders):
(WebKit::LayerTreeHostQt::showRepaintCounter):

11:25 Changeset [105761] by haraken@chromium.org
  • 7 edits in trunk/Source/WebCore

[Refactoring] Remove finish() from all CodeGenerator*.pm
https://bugs.webkit.org/show_bug.cgi?id=76918

Reviewed by Darin Adler.

Now finish() is empty in all CodeGenerator*.pm. This patch removes them.

No tests. No change in behavior.

  • bindings/scripts/CodeGenerator.pm:

(ProcessDocument):

  • bindings/scripts/CodeGeneratorCPP.pm:
  • bindings/scripts/CodeGeneratorGObject.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
11:07 Changeset [105760] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit/mac

pageCacheSupportsPlugins should default to true on WebKit1
https://bugs.webkit.org/show_bug.cgi?id=76891

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-01-24
Reviewed by Joseph Pecoraro.

The default was left out of r102619 by accident.

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

11:01 Changeset [105759] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Another build fix attempt after r105543.

  • Scripts/webkitpy/common/net/file_uploader.py:

(FileUploader.upload_as_multipart_form_data):

10:55 Changeset [105758] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: incorrect highlight position when searching in console
https://bugs.webkit.org/show_bug.cgi?id=76837

Reviewed by Yury Semikhatsky.

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._formatMessage):
(WebInspector.ConsoleMessageImpl.prototype.clearHighlight):
(WebInspector.ConsoleMessageImpl.prototype.highlightSearchResults):
(WebInspector.ConsoleMessageImpl.prototype._highlightSearchResultsInElement):
(WebInspector.ConsoleMessageImpl.prototype.matchesRegex):

10:54 Changeset [105757] by simon.fraser@apple.com
  • 20 edits in trunk/Source

Show layer borders for scrollbar layers
https://bugs.webkit.org/show_bug.cgi?id=76888

Source/WebCore:

Reviewed by Beth Dakin.

When compositing layer borders are showing, show the borders
for scrollbars layers. This reduces confusion about whether scrollbars
are rendering into their own layers.

Requires a new parameter to two GraphicsLayerClient methods.

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::showDebugBorders):
(WebCore::GraphicsLayer::showRepaintCounter):

  • platform/graphics/GraphicsLayerClient.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::showDebugBorders):
(WebCore::RenderLayerBacking::showRepaintCounter):

  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::showDebugBorders):
(WebCore::RenderLayerCompositor::showRepaintCounter):

  • rendering/RenderLayerCompositor.h:

Source/WebKit/chromium:

Reviewed by Beth Dakin.

Update for new signature of GraphicsLayerClient::showDebugBorders()
and GraphicsLayerClient::showRepaintCounter().

  • src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::showDebugBorders):
(WebKit::NonCompositedContentHost::showRepaintCounter):

  • src/NonCompositedContentHost.h:
  • src/PageOverlay.cpp:

(WebKit::OverlayGraphicsLayerClientImpl::showDebugBorders):
(WebKit::OverlayGraphicsLayerClientImpl::showRepaintCounter):

  • tests/ImageLayerChromiumTest.cpp:

(WebCore::MockGraphicsLayerClient::showDebugBorders):
(WebCore::MockGraphicsLayerClient::showRepaintCounter):

Source/WebKit/win:

Reviewed by Beth Dakin.

Update for new signature of GraphicsLayerClient::showDebugBorders()
and GraphicsLayerClient::showRepaintCounter().

  • WebView.cpp:

(WebView::showDebugBorders):
(WebView::showRepaintCounter):

  • WebView.h:

Source/WebKit2:

Reviewed by Beth Dakin.

Update for new signatures of GraphicsLayerClient::showDebugBorders()
and GraphicsLayerClient::showRepaintCounter().

  • UIProcess/LayerTreeHostProxy.h:

(WebKit::LayerTreeHostProxy::showDebugBorders):
(WebKit::LayerTreeHostProxy::showRepaintCounter):

  • WebProcess/WebPage/ca/LayerTreeHostCA.cpp:

(WebKit::LayerTreeHostCA::showDebugBorders):
(WebKit::LayerTreeHostCA::showRepaintCounter):

  • WebProcess/WebPage/ca/LayerTreeHostCA.h:
  • WebProcess/WebPage/qt/LayerTreeHostQt.h:
10:51 Changeset [105756] by levin@chromium.org
  • 5 edits in trunk/Source

[windows] Convert usage of GetDC to HWndDC Part 3.
https://bugs.webkit.org/show_bug.cgi?id=76889

Reviewed by Adam Roben.

Source/WebCore:

No new functionality so no new tests.

  • platform/graphics/win/UniscribeController.cpp:

(WebCore::UniscribeController::shapeAndPlaceItem): Simple replacement.
(WebCore::UniscribeController::shape): Use the delayed allocation.

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::paint): Fix a dc leak and use the dellayed allocation.

Source/WebKit2:

  • UIProcess/win/WebPopupMenuProxyWin.cpp:

(WebKit::WebPopupMenuProxyWin::paint): Fix a dc leak and use the dellayed allocation.

10:49 Changeset [105755] by abarth@webkit.org
  • 1 edit
    4 adds
    1 delete in trunk/LayoutTests

Update Chromium-specific baselines that used to use Apple Mac results
before http://trac.webkit.org/changeset/105744.

  • platform/chromium-mac-snowleopard/compositing/reflections/become-simple-composited-reflection-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/scrollbar-painting-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/visibility/visibility-composited-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t1202-counters-09-b-expected.png: Added.
  • platform/chromium-win-xp/css2.1/t1202-counters-09-b-expected.png: Removed.
10:48 Changeset [105754] by mario@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

Fix coding style in the ATK AccessibilityObject wrapper.

  • accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetName):
(webkitAccessibleGetDescription):
(webkitAccessibleGetParent):
(webkitAccessibleGetNChildren):
(webkitAccessibleRefChild):
(webkitAccessibleGetIndexInParent):
(webkitAccessibleGetAttributes):
(atkRole):
(webkitAccessibleGetRole):
(setAtkStateSetFromCoreObject):
(webkitAccessibleRefStateSet):
(webkitAccessibleRefRelationSet):
(webkitAccessibleInit):
(webkitAccessibleFinalize):
(webkit_accessible_class_init):

10:41 Changeset [105753] by leviw@chromium.org
  • 16 edits
    365 adds in trunk/LayoutTests

Update Snow Leopard image test expectations
https://bugs.webkit.org/show_bug.cgi?id=76869

Rubber stamped by Simon Fraser.

Addingmore SnowLeopard image expectations for tests failing due to subtle differences in rendering
between SnowLeopard and Lion. Also fixing those that hadn't been updated to the new mock scrollbars.

  • platform/mac-snowleopard/css3/filters: Added.
  • platform/mac-snowleopard/css3/filters/add-filter-rendering-expected.png: Added.
  • platform/mac-snowleopard/css3/filters/crash-filter-change-expected.png: Added.
  • platform/mac-snowleopard/css3/filters/crash-hw-sw-switch-expected.png: Added.
  • platform/mac-snowleopard/css3/filters/effect-blur-expected.png: Added.
  • platform/mac-snowleopard/css3/filters/effect-blur-hw-expected.png: Added.
  • platform/mac-snowleopard/css3/filters/effect-brightness-expected.png: Added.
  • platform/mac-snowleopard/css3/filters/effect-brightness-hw-expected.png: Added.
  • platform/mac-snowleopard/css3/filters/effect-combined-expected.png: Added.
  • platform/mac-snowleopard/css3/filters/effect-combined-hw-expected.png: Added.
  • platform/mac-snowleopard/css3/filters/effect-contrast-expected.png: Added.
  • platform/mac-snowleopard/css3/filters/effect-contrast-hw-expected.png: Added.
  • platform/mac-snowleopard/css3/filters/effect-custom-expected.png: Added.
  • platform/mac-snowleopard/css3/filters/effect-custom-parameters-expected.png: Added.
  • platform/mac-snowleopard/css3/filters/effect-drop-shadow-expected.png: Added.
  • platform/mac-snowleopard/css3/filters/effect-drop-shadow-hw-expected.png: Added.
  • platform/mac-snowleopard/css3/filters/effect-grayscale-expected.png: Added.
  • platform/mac-snowleopard/css3/filters/effect-grayscale-hw-expected.png: Added.
  • platform/mac-snowleopard/css3/filters/effect-hue-rotate-expected.png: Added.
  • platform/mac-snowleopard/css3/filters/effect-hue-rotate-hw-expected.png: Added.
  • platform/mac-snowleopard/css3/filters/effect-invert-expected.png: Added.
  • platform/mac-snowleopard/css3/filters/effect-invert-hw-expected.png: Added.
  • platform/mac-snowleopard/css3/filters/effect-opacity-expected.png: Added.
  • platform/mac-snowleopard/css3/filters/effect-opacity-hw-expected.png: Added.
  • platform/mac-snowleopard/css3/filters/effect-saturate-expected.png: Added.
  • platform/mac-snowleopard/css3/filters/effect-saturate-hw-expected.png: Added.
  • platform/mac-snowleopard/css3/filters/effect-sepia-expected.png: Added.
  • platform/mac-snowleopard/css3/filters/effect-sepia-hw-expected.png: Added.
  • platform/mac-snowleopard/css3/filters/filter-empty-element-crash-expected.png: Added.
  • platform/mac-snowleopard/css3/filters/filter-region-expected.png: Added.
  • platform/mac-snowleopard/css3/filters/filter-repaint-expected.png: Added.
  • platform/mac-snowleopard/css3/filters/filter-with-transform-expected.png: Added.
  • platform/mac-snowleopard/css3/filters/filtered-compositing-descendant-expected.png: Added.
  • platform/mac-snowleopard/css3/filters/nested-filter-expected.png: Added.
  • platform/mac-snowleopard/css3/filters/regions-expanding-expected.png: Added.
  • platform/mac-snowleopard/css3/filters/simple-filter-rendering-expected.png: Added.
  • platform/mac-snowleopard/css3/images: Added.
  • platform/mac-snowleopard/css3/images/cross-fade-background-size-expected.png: Added.
  • platform/mac-snowleopard/css3/images/cross-fade-blending-expected.png: Added.
  • platform/mac-snowleopard/css3/images/cross-fade-invalidation-expected.png: Added.
  • platform/mac-snowleopard/css3/images/cross-fade-simple-expected.png: Added.
  • platform/mac-snowleopard/css3/images/cross-fade-sizing-expected.png: Added.
  • platform/mac-snowleopard/css3/images/cross-fade-tiled-expected.png: Added.
  • platform/mac-snowleopard/css3/selectors3: Added.
  • platform/mac-snowleopard/css3/selectors3/html: Added.
  • platform/mac-snowleopard/css3/selectors3/html/css3-modsel-19b-expected.png: Added.
  • platform/mac-snowleopard/css3/selectors3/html/css3-modsel-39-expected.png: Added.
  • platform/mac-snowleopard/css3/selectors3/html/css3-modsel-39b-expected.png: Added.
  • platform/mac-snowleopard/css3/selectors3/html/css3-modsel-39c-expected.png: Added.
  • platform/mac-snowleopard/css3/selectors3/xhtml: Added.
  • platform/mac-snowleopard/css3/selectors3/xhtml/css3-modsel-19b-expected.png: Added.
  • platform/mac-snowleopard/css3/selectors3/xhtml/css3-modsel-39-expected.png: Added.
  • platform/mac-snowleopard/css3/selectors3/xhtml/css3-modsel-39a-expected.png: Added.
  • platform/mac-snowleopard/css3/selectors3/xhtml/css3-modsel-39b-expected.png: Added.
  • platform/mac-snowleopard/css3/selectors3/xhtml/css3-modsel-39c-expected.png: Added.
  • platform/mac-snowleopard/css3/selectors3/xml: Added.
  • platform/mac-snowleopard/css3/selectors3/xml/css3-modsel-19b-expected.png: Added.
  • platform/mac-snowleopard/css3/selectors3/xml/css3-modsel-39-expected.png: Added.
  • platform/mac-snowleopard/css3/selectors3/xml/css3-modsel-39a-expected.png: Added.
  • platform/mac-snowleopard/css3/selectors3/xml/css3-modsel-39b-expected.png: Added.
  • platform/mac-snowleopard/css3/selectors3/xml/css3-modsel-39c-expected.png: Added.
  • platform/mac-snowleopard/editing/inserting: Added.
  • platform/mac-snowleopard/editing/inserting/typing-at-end-of-line-expected.png: Added.
  • platform/mac-snowleopard/editing/pasteboard: Added.
  • platform/mac-snowleopard/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png: Added.
  • platform/mac-snowleopard/editing/pasteboard/paste-TIFF-expected.png: Added.
  • platform/mac-snowleopard/editing/selection: Added.
  • platform/mac-snowleopard/editing/selection/drag-to-contenteditable-iframe-expected.png: Added.
  • platform/mac-snowleopard/editing/selection/unrendered-002-expected.png: Added.
  • platform/mac-snowleopard/editing/unsupported-content: Added.
  • platform/mac-snowleopard/editing/unsupported-content/list-delete-001-expected.png: Added.
  • platform/mac-snowleopard/editing/unsupported-content/list-delete-003-expected.png: Added.
  • platform/mac-snowleopard/editing/unsupported-content/list-type-after-expected.png: Added.
  • platform/mac-snowleopard/editing/unsupported-content/list-type-before-expected.png: Added.
  • platform/mac-snowleopard/editing/unsupported-content/table-delete-001-expected.png: Added.
  • platform/mac-snowleopard/editing/unsupported-content/table-delete-002-expected.png: Added.
  • platform/mac-snowleopard/editing/unsupported-content/table-delete-003-expected.png: Added.
  • platform/mac-snowleopard/editing/unsupported-content/table-type-after-expected.png: Added.
  • platform/mac-snowleopard/editing/unsupported-content/table-type-before-expected.png: Added.
  • platform/mac-snowleopard/fast/backgrounds: Added.
  • platform/mac-snowleopard/fast/backgrounds/repeat: Added.
  • platform/mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-expected.png: Added.
  • platform/mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: Added.
  • platform/mac-snowleopard/fast/backgrounds/size: Added.
  • platform/mac-snowleopard/fast/backgrounds/size/backgroundSize18-expected.png: Added.
  • platform/mac-snowleopard/fast/backgrounds/size/backgroundSize19-expected.png: Added.
  • platform/mac-snowleopard/fast/backgrounds/size/backgroundSize21-expected.png: Added.
  • platform/mac-snowleopard/fast/backgrounds/size/backgroundSize22-expected.png: Added.
  • platform/mac-snowleopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
  • platform/mac-snowleopard/fast/block/basic: Added.
  • platform/mac-snowleopard/fast/block/basic/truncation-rtl-expected.png: Added.
  • platform/mac-snowleopard/fast/block/float: Added.
  • platform/mac-snowleopard/fast/block/float/020-expected.png: Added.
  • platform/mac-snowleopard/fast/block/float/float-avoidance-expected.png: Added.
  • platform/mac-snowleopard/fast/block/margin-collapse/103-expected.png:
  • platform/mac-snowleopard/fast/block/positioning: Added.
  • platform/mac-snowleopard/fast/block/positioning/028-expected.png: Added.
  • platform/mac-snowleopard/fast/block/positioning/031-expected.png: Added.
  • platform/mac-snowleopard/fast/borders: Added.
  • platform/mac-snowleopard/fast/borders/border-image-massive-scale-expected.png: Added.
  • platform/mac-snowleopard/fast/borders/border-image-outset-expected.png: Added.
  • platform/mac-snowleopard/fast/borders/border-image-outset-in-shorthand-expected.png: Added.
  • platform/mac-snowleopard/fast/borders/border-image-outset-split-inline-vertical-lr-expected.png: Added.
  • platform/mac-snowleopard/fast/borders/border-image-rotate-transform-expected.png: Added.
  • platform/mac-snowleopard/fast/borders/border-image-scale-transform-expected.png: Added.
  • platform/mac-snowleopard/fast/borders/border-image-scaled-expected.png: Added.
  • platform/mac-snowleopard/fast/borders/border-image-slice-constrained-expected.png: Added.
  • platform/mac-snowleopard/fast/borders/inline-mask-overlay-image-expected.png: Added.
  • platform/mac-snowleopard/fast/borders/rtl-border-01-expected.png: Added.
  • platform/mac-snowleopard/fast/borders/rtl-border-02-expected.png: Added.
  • platform/mac-snowleopard/fast/borders/rtl-border-03-expected.png: Added.
  • platform/mac-snowleopard/fast/canvas: Added.
  • platform/mac-snowleopard/fast/canvas/canvas-composite-fill-repaint-expected.png: Added.
  • platform/mac-snowleopard/fast/canvas/canvas-incremental-repaint-expected.png: Added.
  • platform/mac-snowleopard/fast/canvas/shadow-offset-7-expected.png: Added.
  • platform/mac-snowleopard/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Added.
  • platform/mac-snowleopard/fast/css/background-shorthand-invalid-url-expected.png: Added.
  • platform/mac-snowleopard/fast/css/child-style-can-override-visited-style-expected.png: Added.
  • platform/mac-snowleopard/fast/css/color-correction-backgrounds-and-text-expected.png: Added.
  • platform/mac-snowleopard/fast/css/color-correction-on-background-image-expected.png: Added.
  • platform/mac-snowleopard/fast/css/continuationCrash-expected.png: Added.
  • platform/mac-snowleopard/fast/css/font-family-pictograph-expected.png: Added.
  • platform/mac-snowleopard/fast/css/margin-top-bottom-dynamic-expected.png: Added.
  • platform/mac-snowleopard/fast/css/outline-narrowLine-expected.png: Added.
  • platform/mac-snowleopard/fast/css/text-overflow-input-expected.png: Added.
  • platform/mac-snowleopard/fast/css/text-transform-select-expected.png: Added.
  • platform/mac-snowleopard/fast/css/transform-default-parameter-expected.png: Added.
  • platform/mac-snowleopard/fast/css/value-list-out-of-bounds-crash-expected.png: Added.
  • platform/mac-snowleopard/fast/dom/52776-expected.png:
  • platform/mac-snowleopard/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png:
  • platform/mac-snowleopard/fast/encoding: Added.
  • platform/mac-snowleopard/fast/encoding/utf-16-big-endian-expected.png: Added.
  • platform/mac-snowleopard/fast/encoding/utf-16-little-endian-expected.png: Added.
  • platform/mac-snowleopard/fast/forms/basic-textareas-expected.png:
  • platform/mac-snowleopard/fast/forms/basic-textareas-quirks-expected.png:
  • platform/mac-snowleopard/fast/forms/fieldset-align-expected.png:
  • platform/mac-snowleopard/fast/forms/form-element-geometry-expected.png:
  • platform/mac-snowleopard/fast/forms/form-hides-table-expected.png:
  • platform/mac-snowleopard/fast/forms/input-table-expected.png:
  • platform/mac-snowleopard/fast/forms/listbox-bidi-align-expected.png: Added.
  • platform/mac-snowleopard/fast/forms/textAreaLineHeight-expected.png:
  • platform/mac-snowleopard/fast/forms/textarea-scroll-height-expected.png:
  • platform/mac-snowleopard/fast/gradients: Added.
  • platform/mac-snowleopard/fast/gradients/crash-on-zero-radius-expected.png: Added.
  • platform/mac-snowleopard/fast/gradients/css3-radial-gradients-expected.png: Added.
  • platform/mac-snowleopard/fast/gradients/generated-gradients-expected.png: Added.
  • platform/mac-snowleopard/fast/gradients/gradient-after-transparent-border-expected.png: Added.
  • platform/mac-snowleopard/fast/gradients/simple-gradients-expected.png: Added.
  • platform/mac-snowleopard/fast/images: Added.
  • platform/mac-snowleopard/fast/images/color-jpeg-with-color-profile-expected.png: Added.
  • platform/mac-snowleopard/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Added.
  • platform/mac-snowleopard/fast/images/gray-scale-png-with-color-profile-expected.png: Added.
  • platform/mac-snowleopard/fast/images/image-css3-content-data-expected.png: Added.
  • platform/mac-snowleopard/fast/images/pdf-as-background-expected.png: Added.
  • platform/mac-snowleopard/fast/images/pdf-as-image-expected.png: Added.
  • platform/mac-snowleopard/fast/images/ycbcr-with-cmyk-color-profile-expected.png: Added.
  • platform/mac-snowleopard/fast/inline: Added.
  • platform/mac-snowleopard/fast/inline/inline-borders-with-bidi-override-expected.png: Added.
  • platform/mac-snowleopard/fast/inline/inline-box-background-long-image-expected.png: Added.
  • platform/mac-snowleopard/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.png: Added.
  • platform/mac-snowleopard/fast/lists: Added.
  • platform/mac-snowleopard/fast/lists/003-expected.png: Added.
  • platform/mac-snowleopard/fast/media: Added.
  • platform/mac-snowleopard/fast/media/mq-min-pixel-ratio-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/block-axis-horizontal-bt-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/column-rules-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/column-rules-stacking-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/columns-shorthand-parsing-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/flipped-blocks-border-after-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/float-avoidance-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/float-multicol-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/float-paginate-complex-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/layers-in-multicol-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/nested-columns-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/overflow-across-columns-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/overflow-across-columns-percent-height-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/positioned-with-constrained-height-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/positive-leading-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/scrolling-overflow-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/shadow-breaking-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/single-line-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/span: Added.
  • platform/mac-snowleopard/fast/multicol/span/anonymous-style-inheritance-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/span/span-as-immediate-child-generated-content-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/span/span-as-immediate-child-property-removal-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/span/span-as-immediate-columns-child-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/span/span-as-nested-columns-child-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/span/span-as-nested-inline-block-child-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/span/span-margin-collapsing-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/vertical-lr/rules-with-border-before-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/vertical-rl/rule-style-expected.png: Added.
  • platform/mac-snowleopard/fast/multicol/vertical-rl/rules-with-border-before-expected.png: Added.
  • platform/mac-snowleopard/fast/overflow/006-expected.png: Added.
  • platform/mac-snowleopard/fast/overflow/overflow-focus-ring-expected.png: Added.
  • platform/mac-snowleopard/fast/overflow/overflow-x-y-expected.png:
  • platform/mac-snowleopard/fast/parser: Added.
  • platform/mac-snowleopard/fast/parser/document-write-option-expected.png: Added.
  • platform/mac-snowleopard/fast/reflections: Added.
  • platform/mac-snowleopard/fast/reflections/reflection-direction-expected.png: Added.
  • platform/mac-snowleopard/fast/reflections/reflection-masks-expected.png: Added.
  • platform/mac-snowleopard/fast/reflections/reflection-masks-opacity-expected.png: Added.
  • platform/mac-snowleopard/fast/reflections/reflection-masks-outset-expected.png: Added.
  • platform/mac-snowleopard/fast/repaint/line-flow-with-floats-2-expected.png: Added.
  • platform/mac-snowleopard/fast/repaint/line-flow-with-floats-8-expected.png: Added.
  • platform/mac-snowleopard/fast/repaint/line-flow-with-floats-9-expected.png: Added.
  • platform/mac-snowleopard/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
  • platform/mac-snowleopard/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
  • platform/mac-snowleopard/fast/repaint/scale-page-shrink-expected.png: Added.
  • platform/mac-snowleopard/fast/repaint/scroll-inside-table-cell-expected.png: Added.
  • platform/mac-snowleopard/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Added.
  • platform/mac-snowleopard/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
  • platform/mac-snowleopard/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
  • platform/mac-snowleopard/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
  • platform/mac-snowleopard/fast/repaint/text-shadow-expected.png: Added.
  • platform/mac-snowleopard/fast/repaint/text-shadow-horizontal-expected.png: Added.
  • platform/mac-snowleopard/fast/replaced: Added.
  • platform/mac-snowleopard/fast/replaced/replaced-breaking-expected.png: Added.
  • platform/mac-snowleopard/fast/replaced/width100percent-button-expected.png: Added.
  • platform/mac-snowleopard/fast/ruby: Added.
  • platform/mac-snowleopard/fast/ruby/ruby-base-merge-block-children-crash-expected.png: Added.
  • platform/mac-snowleopard/fast/selectors: Added.
  • platform/mac-snowleopard/fast/selectors/166-expected.png: Added.
  • platform/mac-snowleopard/fast/selectors/visited-descendant-expected.png: Added.
  • platform/mac-snowleopard/fast/table: Added.
  • platform/mac-snowleopard/fast/table/auto-100-percent-width-expected.png: Added.
  • platform/mac-snowleopard/fast/table/dynamic-caption-add-before-child-expected.png: Added.
  • platform/mac-snowleopard/fast/table/frame-and-rules-expected.png: Added.
  • platform/mac-snowleopard/fast/table/height-percent-test-vertical-expected.png: Added.
  • platform/mac-snowleopard/fast/table/multiple-captions-display-expected.png: Added.
  • platform/mac-snowleopard/fast/text/backslash-to-yen-sign-euc-expected.png: Added.
  • platform/mac-snowleopard/fast/text/capitalize-boundaries-expected.png:
  • platform/mac-snowleopard/fast/text/fallback-traits-fixup-expected.png: Added.
  • platform/mac-snowleopard/fast/text/hyphenate-character-expected.png: Added.
  • platform/mac-snowleopard/fast/text/hyphenate-limit-lines-expected.png: Added.
  • platform/mac-snowleopard/fast/text/hyphens-expected.png: Added.
  • platform/mac-snowleopard/fast/text/international/bidi-menulist-expected.png: Added.
  • platform/mac-snowleopard/fast/text/international/bidi-neutral-run-expected.png:
  • platform/mac-snowleopard/fast/text/international/hebrew-vowels-expected.png: Added.
  • platform/mac-snowleopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
  • platform/mac-snowleopard/fast/text/justify-ideograph-leading-expansion-expected.png: Added.
  • platform/mac-snowleopard/fast/text/midword-break-after-breakable-char-expected.png: Added.
  • platform/mac-snowleopard/fast/text/midword-break-before-surrogate-pair-2-expected.png: Added.
  • platform/mac-snowleopard/fast/text/stroking-decorations-expected.png: Added.
  • platform/mac-snowleopard/fast/text/stroking-expected.png: Added.
  • platform/mac-snowleopard/fast/text/text-letter-spacing-expected.png: Added.
  • platform/mac-snowleopard/fast/text/unicode-variation-selector-expected.png: Added.
  • platform/mac-snowleopard/fast/text/wbr-expected.png: Added.
  • platform/mac-snowleopard/fast/text/whitespace: Added.
  • platform/mac-snowleopard/fast/text/whitespace/normal-after-nowrap-breaking-expected.png: Added.
  • platform/mac-snowleopard/fast/writing-mode: Added.
  • platform/mac-snowleopard/fast/writing-mode/border-image-horizontal-bt-expected.png: Added.
  • platform/mac-snowleopard/fast/writing-mode/border-image-vertical-lr-expected.png: Added.
  • platform/mac-snowleopard/fast/writing-mode/border-image-vertical-rl-expected.png: Added.
  • platform/mac-snowleopard/fast/writing-mode/fallback-orientation-expected.png: Added.
  • platform/mac-snowleopard/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png: Added.
  • platform/mac-snowleopard/fonts: Added.
  • platform/mac-snowleopard/fonts/cursive-expected.png: Added.
  • platform/mac-snowleopard/fonts/default-expected.png: Added.
  • platform/mac-snowleopard/fonts/fantasy-expected.png: Added.
  • platform/mac-snowleopard/fonts/monospace-expected.png: Added.
  • platform/mac-snowleopard/fonts/sans-serif-expected.png: Added.
  • platform/mac-snowleopard/fonts/serif-expected.png: Added.
  • platform/mac-snowleopard/fullscreen: Added.
  • platform/mac-snowleopard/fullscreen/full-screen-stacking-context-expected.png: Added.
  • platform/mac-snowleopard/http/tests/media: Added.
  • platform/mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png: Added.
  • platform/mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Added.
  • platform/mac-snowleopard/http/tests/security: Added.
  • platform/mac-snowleopard/http/tests/security/contentSecurityPolicy: Added.
  • platform/mac-snowleopard/http/tests/security/contentSecurityPolicy/xsl-blocked-expected.png: Added.
  • platform/mac-snowleopard/media/controls-layout-direction-expected.png: Added.
  • platform/mac-snowleopard/media/controls-without-preload-expected.txt: Added.
  • platform/mac-snowleopard/media/media-document-audio-repaint-expected.png: Added.
  • platform/mac-snowleopard/media/video-aspect-ratio-expected.png: Added.
  • platform/mac-snowleopard/media/video-canvas-alpha-expected.png: Added.
  • platform/mac-snowleopard/media/video-colorspace-yuv420-expected.png: Added.
  • platform/mac-snowleopard/media/video-colorspace-yuv422-expected.png: Added.
  • platform/mac-snowleopard/media/video-frame-accurate-seek-expected.png: Added.
  • platform/mac-snowleopard/media/video-layer-crash-expected.png:
  • platform/mac-snowleopard/media/video-playing-and-pause-expected.png: Added.
  • platform/mac-snowleopard/media/video-zoom-expected.png: Added.
  • platform/mac-snowleopard/platform/mac/editing: Added.
  • platform/mac-snowleopard/platform/mac/editing/selection: Added.
  • platform/mac-snowleopard/platform/mac/editing/selection/25228-expected.png: Added.
  • platform/mac-snowleopard/platform/mac/fast/text/combining-character-sequence-fallback-expected.png: Added.
  • platform/mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
  • platform/mac-snowleopard/platform/mac/fast/text/line-break-locale-expected.png: Added.
  • platform/mac-snowleopard/platform/mac/scrollbars: Added.
  • platform/mac-snowleopard/platform/mac/scrollbars/key-window-not-first-responder-expected.png: Added.
  • platform/mac-snowleopard/plugins: Added.
  • platform/mac-snowleopard/plugins/application-plugin-plugins-disabled-expected.png: Added.
  • platform/mac-snowleopard/plugins/mouse-click-plugin-clears-selection-expected.png: Added.
  • platform/mac-snowleopard/printing: Added.
  • platform/mac-snowleopard/printing/compositing-layer-printing-expected.png: Added.
  • platform/mac-snowleopard/printing/media-queries-print-expected.png: Added.
  • platform/mac-snowleopard/printing/page-rule-in-media-query-expected.png: Added.
  • platform/mac-snowleopard/printing/return-from-printing-mode-expected.png: Added.
  • platform/mac-snowleopard/scrollbars: Added.
  • platform/mac-snowleopard/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
  • platform/mac-snowleopard/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
  • platform/mac-snowleopard/svg/text/non-bmp-positioning-lists-expected.png: Added.
  • platform/mac-snowleopard/tables: Added.
  • platform/mac-snowleopard/tables/mozilla: Added.
  • platform/mac-snowleopard/tables/mozilla/bugs: Added.
  • platform/mac-snowleopard/tables/mozilla/bugs/bug10269-2-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/bugs/bug1055-1-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/bugs/bug1163-1-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/bugs/bug119786-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/bugs/bug1302-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/bugs/bug222846-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/bugs/bug2479-1-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/bugs/bug2479-4-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/bugs/bug29058-3-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/bugs/bug2947-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/bugs/bug3977-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/bugs/bug5797-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/bugs/bug5835-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/bugs/bug5838-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/bugs/bug625-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/bugs/bug6304-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/bugs/bug650-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/bugs/bug7112-1-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/bugs/bug7112-2-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/collapsing_borders: Added.
  • platform/mac-snowleopard/tables/mozilla/collapsing_borders/bug41262-3-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/core: Added.
  • platform/mac-snowleopard/tables/mozilla/core/bloomberg-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/core/captions-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/core/cell_heights-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/core/col_widths_auto_fix-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/core/col_widths_fix_fixPer-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/core/nested1-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/core/one_row-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/core/row_span-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/marvin: Added.
  • platform/mac-snowleopard/tables/mozilla/marvin/backgr_index-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/marvin/backgr_layers-opacity-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/marvin/backgr_position-table-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-cell-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-column-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-row-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/marvin/table_frame_border-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/marvin/table_frame_box-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/marvin/table_rules_all-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/marvin/table_rules_none-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/marvin/x_caption_class-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/marvin/x_caption_id-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/marvin/x_caption_style-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/other: Added.
  • platform/mac-snowleopard/tables/mozilla/other/cell_widths-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/other/nestedTables-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/other/test3-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/other/test6-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/other/wa_table_thtd_rowspan-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/other/wa_table_tr_align-expected.png: Added.
  • platform/mac-snowleopard/transforms: Added.
  • platform/mac-snowleopard/transforms/2d: Added.
  • platform/mac-snowleopard/transforms/2d/hindi-rotated-expected.png: Added.
  • platform/mac-snowleopard/transforms/2d/transform-fixed-container-expected.png: Added.
  • platform/mac-snowleopard/transforms/3d: Added.
  • platform/mac-snowleopard/transforms/3d/general: Added.
  • platform/mac-snowleopard/transforms/3d/general/perspective-units-expected.png: Added.
  • platform/mac-snowleopard/transforms/3d/point-mapping: Added.
  • platform/mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Added.
  • platform/mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-expected.png: Added.
  • platform/mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png: Added.
  • platform/mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png: Added.
  • platform/mac-snowleopard/webarchive: Added.
  • platform/mac-snowleopard/webarchive/adopt-attribute-styled-body-webarchive-expected.png: Added.
  • platform/mac-snowleopard/webarchive/test-css-url-resources-in-stylesheets-expected.png: Added.
  • platform/mac-snowleopard/webarchive/test-link-rel-icon-beforeload-expected.png: Added.
10:37 Changeset [105752] by mario@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

Cleanup the list of includes in WebKitAccessibleWrapperAtk.cpp.

  • accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Removes

'include' lines that are no longer needed after the refactor.

10:34 Changeset [105751] by kubo@profusion.mobi
  • 2 edits
    1 delete in trunk/Source/WebCore

[EFL] Remove CookieJarEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=76916

Reviewed by Gustavo Noronha Silva.

CookieJarEfl.cpp has not been used for years -- we either need
CookieJarCurl or CookieJarSoup depending on the chosen network
backend.

No new tests, just an unused file being removed.

  • WebCore.gypi: Remove reference to CookieJarEfl.cpp.
  • platform/efl/CookieJarEfl.cpp: Removed.
10:33 Changeset [105750] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash when accessing removed parent in InlineTextBox.
https://bugs.webkit.org/show_bug.cgi?id=72982

Reviewed by James Robinson.

Source/WebCore:

The crash happens because:

  1. We add heading element(h1) before the span element(span1), causing splitflow on the anonymous block containing BeforeText, span1(and SpanText) and AfterText.
  2. span1 moves to the cloneBlock (continuation).
  3. Our anonymous block and cloneBlock are both marked for layout, however we still have a copy of our lineboxes with its childs as the textboxes belonging to SpanText.
  4. Our anonymous block only child BeforeText is getting removed, so we dont have any children anymore and we delete our lineboxes, leaving behind the children textboxes belonging to SpanText.
  5. SpanText is getting destroyed, so it tries to inform removed parent lineboxes causing the crash.

Test: fast/block/block-remove-child-delete-line-box-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeChild):

LayoutTests:

Tests passes if it does not crash on ASSERT(!m_hasBadParent)
in InlineBox::parent().

  • fast/block/block-remove-child-delete-line-box-crash-expected.txt: Added.
  • fast/block/block-remove-child-delete-line-box-crash.html: Added.
10:28 Changeset [105749] by mario@webkit.org
  • 4 edits
    2 adds in trunk/Source/WebCore

[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

New files for the implementation of the AtkTable interface,
containing the related code from WebKitAccessibleWrapperAtk.cpp.

  • accessibility/gtk/WebKitAccessibleInterfaceTable.cpp: Added.

(core):
(cell):
(cellIndex):
(cellAtIndex):
(webkitAccessibleTableInterfaceInit):
(webkitAccessibleTableRefAt):
(webkitAccessibleTableGetIndexAt):
(webkitAccessibleTableGetColumnAtIndex):
(webkitAccessibleTableGetRowAtIndex):
(webkitAccessibleTableGetNColumns):
(webkitAccessibleTableGetNRows):
(webkitAccessibleTableGetColumnExtentAt):
(webkitAccessibleTableGetRowExtentAt):
(webkitAccessibleTableGetColumnHeader):
(webkitAccessibleTableGetRowHeader):
(webkitAccessibleTableGetCaption):
(webkitAccessibleTableGetColumnDescription):
(webkitAccessibleTableGetRowDescription):

  • accessibility/gtk/WebKitAccessibleInterfaceTable.h: Added.
  • accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Remove code

related to the implementation of the AtkTable interface.

Add new files to build files.

  • GNUmakefile.list.am: Add WebKitAccessibleInterfaceTable.[h|cpp].
  • WebCore.gypi: Ditto.
10:25 Changeset [105748] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Scripts panel tabbed editor container should have gray background when there are no open tabs.
https://bugs.webkit.org/show_bug.cgi?id=76903

Reviewed by Yury Semikhatsky.

  • inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPane.prototype._updateTabElements):

  • inspector/front-end/tabbedPane.css:

(.tabbed-pane-content.has-no-tabs):

10:22 Changeset [105747] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: OpenResourceDialog should work when there are no open tabs in scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=76907

Reviewed by Yury Semikhatsky.

  • inspector/front-end/FilteredItemSelectionDialog.js:

(WebInspector.OpenResourceDialog.install):

  • inspector/front-end/ScriptsPanel.js:
10:03 Changeset [105746] by sergio@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] [GTK] TestDownloads hitting an assertion in Debug builds
https://bugs.webkit.org/show_bug.cgi?id=76915

Reviewed by Martin Robinson.

No new tests required as it fixes some assertions in a unit test.

  • WebProcess/Downloads/soup/DownloadSoup.cpp:

(WebKit::Download::start):
(WebKit::Download::startWithHandle):

10:02 Changeset [105745] by mario@webkit.org
  • 6 edits
    2 adds in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: put TypeBuilder namespace in a separate sources
https://bugs.webkit.org/show_bug.cgi?id=76868

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-01-24
Reviewed by Yury Semikhatsky.

Configurations of (hopefully) all build systems are fixed.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/CodeGeneratorInspector.py:

(dash_to_camelcase):
(InspectorFrontend_h):
(InspectorBackendDispatcher_h):

09:57 Changeset [105744] by leviw@chromium.org
  • 3 edits
    203 adds in trunk/LayoutTests

Update Snow Leopard image test expectations
https://bugs.webkit.org/show_bug.cgi?id=76869

Reviewed by Simon Fraser.

Adding SnowLeopard image expectations for tests failing due to subtle differences in rendering
between SnowLeopard and Lion. Also fixing those that hadn't been updated to the new mock scrollbars.

  • platform/mac-snowleopard/animations: Added.
  • platform/mac-snowleopard/animations/missing-values-first-keyframe-expected.png: Added.
  • platform/mac-snowleopard/animations/missing-values-last-keyframe-expected.png: Added.
  • platform/mac-snowleopard/animations/suspend-transform-animation-expected.png: Added.
  • platform/mac-snowleopard/compositing/color-matching: Added.
  • platform/mac-snowleopard/compositing/color-matching/image-color-matching-expected.png: Added.
  • platform/mac-snowleopard/compositing/direct-image-compositing-expected.png: Added.
  • platform/mac-snowleopard/compositing/flat-with-transformed-child-expected.png: Added.
  • platform/mac-snowleopard/compositing/framesets: Added.
  • platform/mac-snowleopard/compositing/framesets/composited-frame-alignment-expected.png: Added.
  • platform/mac-snowleopard/compositing/geometry: Added.
  • platform/mac-snowleopard/compositing/geometry/clipping-foreground-expected.png: Added.
  • platform/mac-snowleopard/compositing/geometry/composited-html-size-expected.png: Added.
  • platform/mac-snowleopard/compositing/geometry/fixed-in-composited-expected.png: Added.
  • platform/mac-snowleopard/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png: Added.
  • platform/mac-snowleopard/compositing/geometry/foreground-layer-expected.png: Added.
  • platform/mac-snowleopard/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
  • platform/mac-snowleopard/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
  • platform/mac-snowleopard/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png: Added.
  • platform/mac-snowleopard/compositing/geometry/repaint-foreground-layer-expected.png: Added.
  • platform/mac-snowleopard/compositing/geometry/root-layer-update-expected.png: Added.
  • platform/mac-snowleopard/compositing/geometry/rtl-composited-expected.png: Added.
  • platform/mac-snowleopard/compositing/geometry/video-fixed-scrolling-expected.png: Added.
  • platform/mac-snowleopard/compositing/geometry/video-opacity-overlay-expected.png: Added.
  • platform/mac-snowleopard/compositing/iframes: Added.
  • platform/mac-snowleopard/compositing/iframes/composited-iframe-scroll-expected.png: Added.
  • platform/mac-snowleopard/compositing/iframes/iframe-content-flipping-expected.png: Added.
  • platform/mac-snowleopard/compositing/images: Added.
  • platform/mac-snowleopard/compositing/images/content-image-change-expected.png: Added.
  • platform/mac-snowleopard/compositing/images/direct-image-background-color-expected.png: Added.
  • platform/mac-snowleopard/compositing/images/direct-pdf-image-expected.png: Added.
  • platform/mac-snowleopard/compositing/images/direct-svg-image-expected.png: Added.
  • platform/mac-snowleopard/compositing/layers-inside-overflow-scroll-expected.png: Added.
  • platform/mac-snowleopard/compositing/masks: Added.
  • platform/mac-snowleopard/compositing/masks/layer-mask-placement-expected.png: Added.
  • platform/mac-snowleopard/compositing/masks/masked-ancestor-expected.png: Added.
  • platform/mac-snowleopard/compositing/masks/simple-composited-mask-expected.png: Added.
  • platform/mac-snowleopard/compositing/overflow: Added.
  • platform/mac-snowleopard/compositing/overflow/fixed-position-ancestor-clip-expected.png: Added.
  • platform/mac-snowleopard/compositing/overflow/overflow-compositing-descendant-expected.png: Added.
  • platform/mac-snowleopard/compositing/overflow/overflow-positioning-expected.png: Added.
  • platform/mac-snowleopard/compositing/overflow/overflow-scroll-expected.png: Added.
  • platform/mac-snowleopard/compositing/overflow/repaint-after-losing-scrollbars-expected.png: Added.
  • platform/mac-snowleopard/compositing/overflow/scroll-ancestor-update-expected.png: Added.
  • platform/mac-snowleopard/compositing/reflections: Added.
  • platform/mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.png: Added.
  • platform/mac-snowleopard/compositing/reflections/become-simple-composited-reflection-expected.png: Added.
  • platform/mac-snowleopard/compositing/reflections/compositing-change-inside-reflection-expected.png: Added.
  • platform/mac-snowleopard/compositing/reflections/deeply-nested-reflections-expected.png: Added.
  • platform/mac-snowleopard/compositing/reflections/load-video-in-reflection-expected.png: Added.
  • platform/mac-snowleopard/compositing/reflections/masked-reflection-on-composited-expected.png: Added.
  • platform/mac-snowleopard/compositing/reflections/nested-reflection-anchor-point-expected.png: Added.
  • platform/mac-snowleopard/compositing/reflections/nested-reflection-animated-expected.png: Added.
  • platform/mac-snowleopard/compositing/reflections/nested-reflection-expected.png: Added.
  • platform/mac-snowleopard/compositing/reflections/nested-reflection-mask-change-expected.png: Added.
  • platform/mac-snowleopard/compositing/reflections/nested-reflection-on-overflow-expected.png: Added.
  • platform/mac-snowleopard/compositing/reflections/nested-reflection-opacity-expected.png: Added.
  • platform/mac-snowleopard/compositing/reflections/nested-reflection-size-change-expected.png: Added.
  • platform/mac-snowleopard/compositing/reflections/nested-reflection-transformed-expected.png: Added.
  • platform/mac-snowleopard/compositing/reflections/nested-reflection-transformed2-expected.png: Added.
  • platform/mac-snowleopard/compositing/reflections/nested-reflection-transition-expected.png: Added.
  • platform/mac-snowleopard/compositing/reflections/reflection-opacity-expected.png: Added.
  • platform/mac-snowleopard/compositing/reflections/reflection-positioning-expected.png: Added.
  • platform/mac-snowleopard/compositing/reflections/reflection-positioning2-expected.png: Added.
  • platform/mac-snowleopard/compositing/reflections/remove-add-reflection-expected.png: Added.
  • platform/mac-snowleopard/compositing/reflections/transform-inside-reflection-expected.png: Added.
  • platform/mac-snowleopard/compositing/repaint: Added.
  • platform/mac-snowleopard/compositing/repaint/same-size-invalidation-expected.png: Added.
  • platform/mac-snowleopard/compositing/scaling: Added.
  • platform/mac-snowleopard/compositing/scaling/tiled-layer-recursion-expected.png: Added.
  • platform/mac-snowleopard/compositing/scrollbar-painting-expected.png: Added.
  • platform/mac-snowleopard/compositing/self-painting-layers-expected.png: Added.
  • platform/mac-snowleopard/compositing/shadows: Added.
  • platform/mac-snowleopard/compositing/shadows/shadow-drawing-expected.png: Added.
  • platform/mac-snowleopard/compositing/tiling: Added.
  • platform/mac-snowleopard/compositing/tiling/constrained-layer-size-expected.png: Added.
  • platform/mac-snowleopard/compositing/transitions: Added.
  • platform/mac-snowleopard/compositing/transitions/scale-transition-no-start-expected.png: Added.
  • platform/mac-snowleopard/compositing/video: Added.
  • platform/mac-snowleopard/compositing/video/video-background-color-expected.png: Added.
  • platform/mac-snowleopard/compositing/visibility: Added.
  • platform/mac-snowleopard/compositing/visibility/visibility-composited-expected.png: Added.
  • platform/mac-snowleopard/compositing/visibility/visibility-simple-canvas2d-layer-expected.png: Added.
  • platform/mac-snowleopard/compositing/visibility/visibility-simple-video-layer-expected.png: Added.
  • platform/mac-snowleopard/compositing/visibility/visibility-simple-webgl-layer-expected.png: Added.
  • platform/mac-snowleopard/compositing/webgl: Added.
  • platform/mac-snowleopard/compositing/webgl/webgl-background-color-expected.png: Added.
  • platform/mac-snowleopard/compositing/webgl/webgl-no-alpha-expected.png: Added.
  • platform/mac-snowleopard/css1/box_properties: Added.
  • platform/mac-snowleopard/css1/box_properties/border_bottom-expected.png: Added.
  • platform/mac-snowleopard/css1/box_properties/border_left-expected.png: Added.
  • platform/mac-snowleopard/css1/box_properties/border_right_inline-expected.png: Added.
  • platform/mac-snowleopard/css1/box_properties/float_on_text_elements-expected.png: Added.
  • platform/mac-snowleopard/css1/box_properties/margin_inline-expected.png: Added.
  • platform/mac-snowleopard/css1/box_properties/margin_left-expected.png: Added.
  • platform/mac-snowleopard/css1/box_properties/margin_right-expected.png: Added.
  • platform/mac-snowleopard/css1/box_properties/padding_bottom_inline-expected.png: Added.
  • platform/mac-snowleopard/css1/box_properties/padding_inline-expected.png: Added.
  • platform/mac-snowleopard/css1/box_properties/padding_left-expected.png: Added.
  • platform/mac-snowleopard/css1/box_properties/padding_right-expected.png: Added.
  • platform/mac-snowleopard/css1/cascade: Added.
  • platform/mac-snowleopard/css1/cascade/important-expected.png: Added.
  • platform/mac-snowleopard/css1/classification: Added.
  • platform/mac-snowleopard/css1/classification/display-expected.png: Added.
  • platform/mac-snowleopard/css1/color_and_background: Added.
  • platform/mac-snowleopard/css1/color_and_background/background_image-expected.png: Added.
  • platform/mac-snowleopard/css1/color_and_background/background_position-expected.png: Added.
  • platform/mac-snowleopard/css1/color_and_background/background_repeat-expected.png: Added.
  • platform/mac-snowleopard/css1/font_properties/font-expected.png:
  • platform/mac-snowleopard/css1/font_properties/font_family-expected.png: Added.
  • platform/mac-snowleopard/css1/formatting_model: Added.
  • platform/mac-snowleopard/css1/formatting_model/inline_elements-expected.png: Added.
  • platform/mac-snowleopard/css1/pseudo: Added.
  • platform/mac-snowleopard/css1/pseudo/firstletter-expected.png: Added.
  • platform/mac-snowleopard/css1/pseudo/firstline-expected.png: Added.
  • platform/mac-snowleopard/css1/pseudo/multiple_pseudo_elements-expected.png: Added.
  • platform/mac-snowleopard/css1/pseudo/pseudo_elements_in_selectors-expected.png: Added.
  • platform/mac-snowleopard/css1/text_properties: Added.
  • platform/mac-snowleopard/css1/text_properties/text_decoration-expected.png: Added.
  • platform/mac-snowleopard/css1/text_properties/text_transform-expected.png: Added.
  • platform/mac-snowleopard/css1/units: Added.
  • platform/mac-snowleopard/css1/units/urls-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323: Added.
  • platform/mac-snowleopard/css2.1/20110323/absolute-replaced-height-003-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/absolute-replaced-height-010-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/absolute-replaced-height-017-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/absolute-replaced-height-024-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/absolute-replaced-height-031-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-006-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-013-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-020-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-022-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-027-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-029-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-034-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-036-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-041-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-043-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-048-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-050-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-055-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-057-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-062-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-064-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-069-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-071-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/absolute-replaced-width-076-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/abspos-containing-block-initial-001-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/block-replaced-height-003-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/block-replaced-width-006-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/border-collapse-offset-002-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/border-collapse-offset-002-expected.txt: Added.
  • platform/mac-snowleopard/css2.1/20110323/border-conflict-style-079-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/border-conflict-style-088-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/dynamic-top-change-001-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/dynamic-top-change-002-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/dynamic-top-change-003-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/dynamic-top-change-004-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/float-replaced-height-003-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/float-replaced-width-001-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/float-replaced-width-002-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/float-replaced-width-003-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/float-replaced-width-004-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/float-replaced-width-005-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/float-replaced-width-011-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/floating-replaced-height-008-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/height-width-inline-table-001-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/height-width-table-001-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/inline-block-replaced-height-003-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/inline-block-replaced-height-008-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/inline-block-replaced-width-006-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/inline-replaced-height-003-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/inline-replaced-height-008-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/inline-replaced-width-001-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/inline-replaced-width-006-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/margin-applies-to-001-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/margin-applies-to-002-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/margin-applies-to-003-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/margin-applies-to-004-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/margin-applies-to-005-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/margin-applies-to-006-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/margin-applies-to-007-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/margin-applies-to-008-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/margin-applies-to-009-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/margin-applies-to-010-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/margin-applies-to-012-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/margin-applies-to-013-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/margin-applies-to-014-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/margin-applies-to-015-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/outline-color-applies-to-008-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/outline-color-applies-to-008-expected.txt: Added.
  • platform/mac-snowleopard/css2.1/20110323/table-caption-001-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/table-caption-002-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/table-caption-margins-001-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/table-caption-optional-001-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/table-caption-optional-002-expected.png: Added.
  • platform/mac-snowleopard/css2.1/20110323/width-replaced-element-001-expected.png: Added.
  • platform/mac-snowleopard/css2.1/t051201-c23-first-line-00-b-expected.png: Added.
  • platform/mac-snowleopard/css2.1/t1002-c5523-width-02-b-g-expected.png: Added.
  • platform/mac-snowleopard/css2.1/t1202-counters-09-b-expected.png:
  • platform/mac-snowleopard/css2.1/t1508-c527-font-01-b-expected.png: Added.
09:46 Changeset [105743] by vsevik@chromium.org
  • 11 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: put TypeBuilder namespace in a separate sources
https://bugs.webkit.org/show_bug.cgi?id=76868

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-01-24
Reviewed by Yury Semikhatsky.

Configurations of (hopefully) all build systems are fixed.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/CodeGeneratorInspector.py:

(dash_to_camelcase):
(InspectorFrontend_h):
(InspectorBackendDispatcher_h):

08:59 Changeset [105742] by ossy@webkit.org
  • 23 edits
    1 copy
    25 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Unskip now passing tests and add/update platform specific expected files for them.

  • platform/qt/Skipped:
  • platform/qt/dom/xhtml/level3/core/canonicalform08-expected.png: Added.
  • platform/qt/dom/xhtml/level3/core/canonicalform08-expected.txt:
  • platform/qt/dom/xhtml/level3/core/canonicalform09-expected.png: Added.
  • platform/qt/dom/xhtml/level3/core/canonicalform09-expected.txt:
  • platform/qt/dom/xhtml/level3/core/documentgetinputencoding03-expected.png: Added.
  • platform/qt/dom/xhtml/level3/core/documentgetinputencoding03-expected.txt:
  • platform/qt/dom/xhtml/level3/core/entitygetinputencoding02-expected.png: Added.
  • platform/qt/dom/xhtml/level3/core/entitygetinputencoding02-expected.txt:
  • platform/qt/dom/xhtml/level3/core/entitygetxmlversion02-expected.png: Added.
  • platform/qt/dom/xhtml/level3/core/entitygetxmlversion02-expected.txt:
  • platform/qt/dom/xhtml/level3/core/nodegetbaseuri05-expected.png: Added.
  • platform/qt/dom/xhtml/level3/core/nodegetbaseuri05-expected.txt:
  • platform/qt/dom/xhtml/level3/core/nodegetbaseuri07-expected.png: Added.
  • platform/qt/dom/xhtml/level3/core/nodegetbaseuri07-expected.txt:
  • platform/qt/dom/xhtml/level3/core/nodegetbaseuri09-expected.png: Added.
  • platform/qt/dom/xhtml/level3/core/nodegetbaseuri09-expected.txt:
  • platform/qt/dom/xhtml/level3/core/nodegetbaseuri10-expected.png: Added.
  • platform/qt/dom/xhtml/level3/core/nodegetbaseuri10-expected.txt:
  • platform/qt/dom/xhtml/level3/core/nodegetbaseuri11-expected.png: Added.
  • platform/qt/dom/xhtml/level3/core/nodegetbaseuri11-expected.txt:
  • platform/qt/dom/xhtml/level3/core/nodegetbaseuri15-expected.png: Added.
  • platform/qt/dom/xhtml/level3/core/nodegetbaseuri15-expected.txt:
  • platform/qt/dom/xhtml/level3/core/nodegetbaseuri17-expected.png: Added.
  • platform/qt/dom/xhtml/level3/core/nodegetbaseuri17-expected.txt:
  • platform/qt/dom/xhtml/level3/core/nodegetbaseuri18-expected.png: Added.
  • platform/qt/dom/xhtml/level3/core/nodegetbaseuri18-expected.txt:
  • platform/qt/dom/xhtml/level3/core/nodelookupnamespaceuri01-expected.png: Added.
  • platform/qt/dom/xhtml/level3/core/nodelookupnamespaceuri01-expected.txt:
  • platform/qt/dom/xhtml/level3/core/nodelookupprefix19-expected.png: Added.
  • platform/qt/dom/xhtml/level3/core/nodelookupprefix19-expected.txt:
  • platform/qt/editing/pasteboard/paste-noscript-expected.png: Added.
  • platform/qt/editing/pasteboard/paste-noscript-expected.txt: Added.
  • platform/qt/editing/style/style-3681552-fix-001-expected.png: Added.
  • platform/qt/editing/style/style-3681552-fix-001-expected.txt:
  • platform/qt/editing/style/style-3681552-fix-002-expected.png: Added.
  • platform/qt/editing/style/style-3681552-fix-002-expected.txt: Copied from LayoutTests/platform/qt/editing/style/typing-style-002-expected.txt.
  • platform/qt/editing/style/style-boundary-002-expected.png: Added.
  • platform/qt/editing/style/style-boundary-002-expected.txt:
  • platform/qt/editing/style/style-boundary-003-expected.png: Added.
  • platform/qt/editing/style/style-boundary-003-expected.txt:
  • platform/qt/editing/style/style-boundary-005-expected.png: Added.
  • platform/qt/editing/style/style-boundary-005-expected.txt:
  • platform/qt/editing/style/typing-style-001-expected.png: Added.
  • platform/qt/editing/style/typing-style-001-expected.txt:
  • platform/qt/editing/style/typing-style-002-expected.png: Added.
  • platform/qt/editing/style/typing-style-002-expected.txt:
  • platform/qt/fast/css/text-overflow-input-expected.png: Added.
08:58 Changeset [105741] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Build fix attempt after r105543.

  • Scripts/webkitpy/common/net/file_uploader.py:

(FileUploader.upload_as_multipart_form_data):

08:22 Changeset [105740] by mario@webkit.org
  • 4 edits
    2 adds in trunk/Source/WebCore

[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

New files for the implementation of the AtkValue interface,
containing the related code from WebKitAccessibleWrapperAtk.cpp.

  • accessibility/gtk/WebKitAccessibleInterfaceValue.cpp: Added.

(core):
(webkitAccessibleValueInterfaceInit):
(webkitAccessibleValueGetCurrentValue):
(webkitAccessibleValueGetMaximumValue):
(webkitAccessibleValueGetMinimumValue):
(webkitAccessibleValueSetCurrentValue):
(webkitAccessibleValueGetMinimumIncrement):

  • accessibility/gtk/WebKitAccessibleInterfaceValue.h: Added.
  • accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Remove code

related to the implementation of the AtkValue interface.

Add new files to build files.

  • GNUmakefile.list.am: Add WebKitAccessibleInterfaceValue.[h|cpp].
  • WebCore.gypi: Ditto.
08:09 Changeset [105739] by antti@apple.com
  • 13 edits in trunk/Source/WebCore

Reduce internal use of CSSStyleDeclaration base class
https://bugs.webkit.org/show_bug.cgi?id=76904

Reviewed by Andreas Kling.

Internally WebCore should use the more specific CSSMutableStyleDeclaration and CSSComputedStyleDeclaration types.
The CSSStyleDeclaration base should be used in the DOM API functions only. This will make it easier to separate
internal style sheet implementation from the DOM in the future.

  • Switch CSSStyleDeclaration -> CSSMutableStyleDeclaration where feasible
  • Use StyledElement::ensureInlineStyleDecl() instead of Element::style() (which is a DOM API function)
  • Remove Attribute::style() which looks like a DOM API function but is not exposed.
  • css/CSSMutableStyleDeclaration.h:

(WebCore::CSSMutableStyleDeclaration::getPropertyCSSValue):

  • dom/Attr.h:

(WebCore::Attr::style):

  • dom/Attribute.h:
  • editing/EditingStyle.cpp:

(WebCore::HTMLElementEquivalent::propertyExistsInStyle):
(WebCore::HTMLElementEquivalent::valueIsPresentInStyle):
(WebCore::HTMLTextDecorationEquivalent::propertyExistsInStyle):
(WebCore::HTMLTextDecorationEquivalent::valueIsPresentInStyle):
(WebCore::HTMLAttributeEquivalent::valueIsPresentInStyle):

  • editing/Editor.cpp:

(WebCore::Editor::applyEditingStyleToElement):

  • editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::wrapWithStyleNode):
(WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag):
(WebCore::propertyMissingOrEqualToNone):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::buildArrayForAttributeStyles):

  • page/DragController.cpp:

(WebCore::DragController::concludeEditDrag):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeFrame):
(WebCore::PageSerializer::retrieveResourcesForCSSDeclaration):

  • page/PageSerializer.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::resize):

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::getPresentationAttribute):

07:42 Changeset [105738] by kling@webkit.org
  • 5 edits in trunk/Source/WebCore

Make elements that don't have attributes smaller.
<http://webkit.org/b/76876>

Reviewed by Antti Koivisto.

Move the inline style declaration from StyledElement to NamedNodeMap, since having
an inline style declaration also implies having a style attribute on the element.
This saves one CPU word per element that has no attributes.

This reduces memory consumption by 412 kB (on 64-bit) when viewing the full
HTML5 spec at <http://whatwg.org/c>.

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::ensureInlineStyleDecl):
(WebCore::NamedNodeMap::destroyInlineStyleDecl):
(WebCore::NamedNodeMap::createInlineStyleDecl):

  • dom/NamedNodeMap.h:

(WebCore::NamedNodeMap::inlineStyleDecl):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::updateStyleAttribute):
(WebCore::StyledElement::addSubresourceAttributeURLs):

  • dom/StyledElement.h:

(WebCore::StyledElement::inlineStyleDecl):
(WebCore::StyledElement::ensureInlineStyleDecl):
(WebCore::StyledElement::destroyInlineStyleDecl):

07:17 Changeset [105737] by noam.rosenthal@nokia.com
  • 13 edits in trunk/Source

[Qt][WK2] Qt's cross-process AC copies images excessively when updating tiles.
https://bugs.webkit.org/show_bug.cgi?id=76877

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Add BitmapTexture::updateRawContents(), which allows uploading image data to a texture
without changing its format or swizzling RGB. The data has to be in the texture's native
format.

No new tests, this affects performance on all existing tests.

  • platform/graphics/opengl/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::updateRawContents):

  • platform/graphics/qt/TextureMapperQt.cpp:
  • platform/graphics/texmap/TextureMapper.h:

(WebCore::BitmapTexture::updateRawContents):

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::setContentsTileBackBuffer):

  • platform/graphics/texmap/TextureMapperNode.h:

Source/WebKit2:

Instead of copying QImages, pass a reference to the ShareableBitmap that was originally
created by the web process. Also, swizzle the image's RGB in the web process, before it's
transferred to the UI process.

Data flow before change:
(Web Process) Render to image -> IPC -> (UI Process) Copy (render queue) -> Copy Swizzled RGB -> Upload

Data flow after change:
(Web Process) Render to image -> swizzle RGB -> IPC -> (UI Process) -> Upload

  • Shared/ShareableBitmap.h:
  • Shared/qt/ShareableBitmapQt.cpp:

(WebKit::ShareableBitmap::swizzleRGB):

  • UIProcess/LayerTreeHostProxy.h:
  • UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::updateTile):
(WebKit::LayerTreeHostProxy::createImage):
(WebKit::LayerTreeHostProxy::syncRemoteContent):
(WebKit::LayerTreeHostProxy::updateTileForLayer):
(WebKit::LayerTreeHostProxy::createDirectlyCompositedImage):
(WebKit::LayerTreeHostProxy::purgeGLResources):

  • WebProcess/WebPage/TiledBackingStoreRemoteTile.cpp:

(WebKit::TiledBackingStoreRemoteTile::updateBackBuffer):

  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::adoptImageBackingStore):

06:53 Changeset [105736] by mario@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, skip WK2 API test timing out on some GTK bots.

WebKit2APITests/TestDownloads is consistently timing out on the
32bit release and 64bit debug bots.

  • Scripts/run-gtk-tests:

(TestRunner): Skip WebKit2APITests/TestDownloads.

06:35 Changeset [105735] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: inspector/debugger/dom-breakpoints.html started to fail after r105642
https://bugs.webkit.org/show_bug.cgi?id=76908

Reviewed by Yury Semikhatsky.

  • css/CSSMutableStyleDeclaration.cpp:
05:58 Changeset [105734] by ossy@webkit.org
  • 2 edits in trunk/Source/WebCore

[Refactoring] Make finish() of CodeGeneratorJS.pm empty
https://bugs.webkit.org/show_bug.cgi?id=76846

Reviewed by Tor Arne Vestbø.

  • bindings/scripts/CodeGeneratorJS.pm: Warning fix after r105683.

(WriteData):

05:32 Changeset [105733] by ossy@webkit.org
  • 4 edits in trunk

[Qt] Fix the build with the newes Qt5 hashes
https://bugs.webkit.org/show_bug.cgi?id=76657

Patch by Andras Becsi <andras.becsi@nokia.com> on 2012-01-24
Reviewed by Simon Hausmann.

Source/WebCore:

No new tests needed.

  • platform/graphics/cairo/OpenGLShims.cpp:

(WebCore::getProcAddress): Adopt API changes.

Tools:

  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::MiniBrowserApplication): Disable the automatic touch->mouse event synthesis
for now to prevent an infinite loop where Qt always creates mouse events out of our touch mock events.

05:30 Changeset [105732] by ossy@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] QtWebIconDatabaseClient leaves a dangling pointer on WebIconDatabase after its destruction
https://bugs.webkit.org/show_bug.cgi?id=76399

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-01-24
Reviewed by Simon Hausmann.

Due a circular dependency between WebContext and WebProcessProxy, WebContext it not
being destroyed, neither WebIconDatabase. As QtWebIconDatabaseClient's life time is the same
as QtWebContext and this one is being destroyed, the remaining reference to our client
on WebIconDatabase should be cleaned upon its destruction.

  • UIProcess/qt/QtWebIconDatabaseClient.cpp:

(QtWebIconDatabaseClient::QtWebIconDatabaseClient):
(QtWebIconDatabaseClient::~QtWebIconDatabaseClient): Clear client pointer on WebIconDatabase.

  • UIProcess/qt/QtWebIconDatabaseClient.h: Make this client hold a reference to WebIconDatabase.
05:28 Changeset [105731] by ossy@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Incremental build problem.
https://bugs.webkit.org/show_bug.cgi?id=74687

It is necessary to set mathattrs.in dependency for generating MathMLNames.cpp file.

Patch by Ádám Kallai <Kallai.Adam@stud.u-szeged.hu> on 2012-01-24
Reviewed by Csaba Osztrogonác.

  • DerivedSources.pri:

I added missing depend.

04:55 Changeset [105730] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update test expectation

  • platform/chromium/test_expectations.txt:

perf/adding-radio-buttons.html is TEXT on Mac.

04:31 Changeset [105729] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Distinguish between Cygwin and cmd.exe in the way we set env variables

We can't use win32-msvc* to decide whether or not to use (set FOO=bar), as
building with MinGW inside cmd.exe will require the same construct. Instead
we assume that when the first character in PWD is a '/' we're running under
Cygwin, and use the normal unix way of setting environment variables.

Reviewed by Simon Hausmann.

04:28 Changeset [105728] by zeno.albisser@nokia.com
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Add test for application URL schemes.
https://bugs.webkit.org/show_bug.cgi?id=74933

Add a test that checks handling of url strings.
Add a test that verifies replies in case of multiple
available application url schemes.

Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml:
04:25 Changeset [105727] by mario@webkit.org
  • 4 edits
    2 adds in trunk/Source/WebCore

[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

New files for the implementation of the AtkSelection interface,
containing the related code from WebKitAccessibleWrapperAtk.cpp.

  • accessibility/gtk/WebKitAccessibleInterfaceSelection.cpp: Added.

(core):
(listObjectForSelection):
(optionFromList):
(optionFromSelection):
(webkitAccessibleSelectionInterfaceInit):
(webkitAccessibleSelectionAddSelection):
(webkitAccessibleSelectionClearSelection):
(webkitAccessibleSelectionRefSelection):
(webkitAccessibleSelectionGetSelectionCount):
(webkitAccessibleSelectionIsChildSelected):
(webkitAccessibleSelectionRemoveSelection):
(webkitAccessibleSelectionSelectAllSelection):

  • accessibility/gtk/WebKitAccessibleInterfaceSelection.h: Added.
  • accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Remove code

related to the implementation of the AtkSelection interface.

Add new files to build files.

  • GNUmakefile.list.am: Add WebKitAccessibleInterfaceSelection.[h|cpp].
  • WebCore.gypi: Ditto.
04:04 Changeset [105726] by mario@webkit.org
  • 4 edits
    2 adds in trunk/Source/WebCore

[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

New files for the implementation of the AtkImage interface,
containing the related code from WebKitAccessibleWrapperAtk.cpp.

  • accessibility/gtk/WebKitAccessibleInterfaceImage.cpp: Added.

(core):
(webkitAccessibleImageInterfaceInit):
(webkitAccessibleImageGetImagePosition):
(webkitAccessibleImageGetImageDescription):
(webkitAccessibleImageGetImageSize):

  • accessibility/gtk/WebKitAccessibleInterfaceImage.h: Added.
  • accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Remove code

related to the implementation of the AtkImage interface.

Add new files to build files.

  • GNUmakefile.list.am: Add WebKitAccessibleInterfaceImage.[h|cpp].
  • WebCore.gypi: Ditto.
03:58 Changeset [105725] by mario@webkit.org
  • 4 edits
    2 adds in trunk/Source/WebCore

[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

New files for the implementation of the AtkHypertext interface,
containing the related code from WebKitAccessibleWrapperAtk.cpp.

  • accessibility/gtk/WebKitAccessibleInterfaceHypertext.cpp: Added.

(core):
(webkitAccessibleHypertextInterfaceInit):
(webkitAccessibleHypertextGetLink):
(webkitAccessibleHypertextGetNLinks):
(webkitAccessibleHypertextGetLinkIndex):

  • accessibility/gtk/WebKitAccessibleInterfaceHypertext.h: Added.
  • accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Remove code

related to the implementation of the AtkHypertext interface.

Add new files to build files.

  • GNUmakefile.list.am: Add WebKitAccessibleInterfaceHypertext.[h|cpp].
  • WebCore.gypi: Ditto.
03:55 Changeset [105724] by mario@webkit.org
  • 4 edits
    2 adds in trunk/Source/WebCore

[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

New files for the implementation of the AtkHyperlinkImpl interface,
containing the related code from WebKitAccessibleWrapperAtk.cpp.

  • accessibility/gtk/WebKitAccessibleInterfaceHyperlinkImpl.cpp: Added.

(webkitAccessibleHyperlinkImplInterfaceInit):
(webkitAccessibleHyperlinkImplGetHyperlink):

  • accessibility/gtk/WebKitAccessibleInterfaceHyperlinkImpl.h: Added.
  • accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Remove code

related to the implementation of the AtkHyperlinkImpl interface.
(webkit_accessible_class_init):

Add new files to build files.

  • GNUmakefile.list.am: Add WebKitAccessibleInterfaceHyperlinkImpl.[h|cpp].
  • WebCore.gypi: Ditto.
03:49 Changeset [105723] by carlosgc@webkit.org
  • 4 edits in trunk/Source/WebKit2

[GTK] Fix /webkit2/WebKitWebView/reload after r105688
https://bugs.webkit.org/show_bug.cgi?id=76898

Reviewed by Alejandro G. Castro.

  • UIProcess/API/gtk/tests/LoadTrackingTest.cpp:

(LoadTrackingTest::reload): Add reload method that clears events
and initializes progress.

  • UIProcess/API/gtk/tests/LoadTrackingTest.h:
  • UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp:

(testWebViewReload): Use LoadTrackingTest::reload() instead of
webkit_web_view_reload().

03:47 Changeset [105722] by mario@webkit.org
  • 4 edits
    2 adds in trunk/Source/WebCore

[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

New files for the implementation of the AtkEditableText interface,
containing the related code from WebKitAccessibleWrapperAtk.cpp.

  • accessibility/gtk/WebKitAccessibleInterfaceEditableText.cpp: Added.

(core):
(webkitAccessibleEditableTextInterfaceInit):
(webkitAccessibleEditableTextSetRunAttributes):
(webkitAccessibleEditableTextSetTextContents):
(webkitAccessibleEditableTextInsertText):
(webkitAccessibleEditableTextCopyText):
(webkitAccessibleEditableTextCutText):
(webkitAccessibleEditableTextDeleteText):
(webkitAccessibleEditableTextPasteText):

  • accessibility/gtk/WebKitAccessibleInterfaceEditableText.h: Added.
  • accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Remove code

related to the implementation of the AtkEditableText interface.

Add new files to build files.

  • GNUmakefile.list.am: Add WebKitAccessibleInterfaceEditableText.[h|cpp].
  • WebCore.gypi: Ditto.
03:40 Changeset [105721] by mario@webkit.org
  • 6 edits
    1 copy
    1 add in trunk/Source/WebCore

[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

New files for the implementation of the AtkDocument interface,
containing the related code from WebKitAccessibleWrapperAtk.cpp.

  • accessibility/gtk/WebKitAccessibleInterfaceDocument.cpp: Added.

(core):
(documentAttributeValue):
(webkitAccessibleDocumentInterfaceInit):
(webkitAccessibleDocumentGetAttributeValue):
(webkitAccessibleDocumentGetAttributes):
(webkitAccessibleDocumentGetLocale):

  • accessibility/gtk/WebKitAccessibleInterfaceDocument.h: Added.

Move common function addAttributeToSet() out from the wrapper to
the utility file, used from WebKitAccessibleInterfaceDocument.cpp.

  • accessibility/gtk/WebKitAccessibleUtil.cpp:

(addToAtkAttributeSet): Taken from WebKitAccessibleWrapperAtk.cpp.

  • accessibility/gtk/WebKitAccessibleUtil.h:
  • accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Remove local

implementation of addAttributeToSet, as well as all the code related
to the implementation of the AtkDocument interface.

Add new files to build files.

  • GNUmakefile.list.am: Add WebKitAccessibleInterfaceDocument.[h|cpp].
  • WebCore.gypi: Ditto.
03:29 Changeset [105720] by scheib@chromium.org
  • 7 edits in trunk/Source/WebKit/chromium

[Chromium] Add WebKit API for Pointer Lock
https://bugs.webkit.org/show_bug.cgi?id=76410

Reviewed by Darin Fisher.

Breaking up https://bugs.webkit.org/show_bug.cgi?id=75762
into a series of patches, this stubs out the API.

  • public/WebWidget.h:

(WebKit::WebWidget::didCompletePointerLock):
(WebKit::WebWidget::didNotCompletePointerLock):
(WebKit::WebWidget::didLosePointerLock):

  • public/WebWidgetClient.h:

(WebKit::WebWidgetClient::requestPointerLock):
(WebKit::WebWidgetClient::requestPointerUnlock):
(WebKit::WebWidgetClient::isPointerLocked):

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::requestPointerLock):
(WebKit::ChromeClientImpl::requestPointerUnlock):
(WebKit::ChromeClientImpl::isPointerLocked):

  • src/ChromeClientImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleInputEvent):
(WebKit::WebViewImpl::didCompletePointerLock):
(WebKit::WebViewImpl::didNotCompletePointerLock):
(WebKit::WebViewImpl::didLosePointerLock):
(WebKit::WebViewImpl::requestPointerLock):
(WebKit::WebViewImpl::requestPointerUnlock):
(WebKit::WebViewImpl::isPointerLocked):
(WebKit::WebViewImpl::pointerLockMouseEvent):

  • src/WebViewImpl.h:
03:22 Changeset [105719] by hausmann@webkit.org
  • 7 edits in trunk

Some qmake build files must include Qt5's "quick" module.
https://bugs.webkit.org/show_bug.cgi?id=76671

Unreviewed build fix.

.:

  • Source/api.pri:

Source/WebKit2:

  • UIProcess/API/qt/tests/tests.pri:

Tools:

  • MiniBrowser/qt/MiniBrowser.pro:
  • WebKitTestRunner/Target.pri:
03:19 Changeset [105718] by abecsi@webkit.org
  • 2 edits in trunk/Tools

[Qt] Fix the event timestamps for touch mocking

Reviewed by Simon Hausmann.

  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::sendTouchEvent): We should not set QEvent::None as the
timestamp argument in the QWindowSystemInterface::handleTouchEvent call.

03:05 Changeset [105717] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update test expectation

  • platform/chromium/test_expectations.txt:

perf/adding-radio-buttons.html is MISSING on buildbots.

03:03 Changeset [105716] by mario@webkit.org
  • 6 edits
    1 copy
    1 add in trunk/Source/WebCore

[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

New files for the implementation of the AtkComponent interface,
containing the related code from WebKitAccessibleWrapperAtk.cpp.

  • accessibility/gtk/WebKitAccessibleInterfaceComponent.cpp: Added.

(core):
(atkToContents):
(webkitAccessibleComponentInterfaceInit):
(webkitAccessibleComponentRefAccessibleAtPoint):
(webkitAccessibleComponentGetExtents):
(webkitAccessibleComponentGrabFocus):

  • accessibility/gtk/WebKitAccessibleInterfaceComponent.h: Added.

Move common function contentsToAtk() out from the wrapper to the
utility file, used from WebKitAccessibleInterfaceComponent.cpp.

  • accessibility/gtk/WebKitAccessibleUtil.cpp:

(contentsRelativeToAtkCoordinateType): Taken from WebKitAccessibleWrapperAtk.cpp.

  • accessibility/gtk/WebKitAccessibleUtil.h:
  • accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Remove local

implementation of contentsToAtk, as well as all the code related
to the implementation of the AtkComponent interface.

Add new files to build files.

  • GNUmakefile.list.am: Add WebKitAccessibleInterfaceComponent.[h|cpp].
  • WebCore.gypi: Ditto.
02:51 Changeset [105715] by ossy@webkit.org
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip new failing tests to paint the bots green.

  • platform/qt-5.0/Skipped:
  • platform/qt/Skipped:
02:32 Changeset [105714] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[Refactoring] Makes finish() of CodeGeneratorV8.pm empty
https://bugs.webkit.org/show_bug.cgi?id=76841

Reviewed by Adam Barth.

This is one of steps to stop rebuilding .h/.cpp files
generated by unchanged IDLs (bug 76836).

As refactoring, we are planning to remove finish() from
all CodeGenerators. This patch makes finish() of
CodeGeneratorV8.pm empty.

No new tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(finish): Made it empty. We will remove finish() after
making finish() of all CodeGenerators empty.
(GenerateInterface): Modified to call WriteData().
(WriteData): Simple code refactoring.
Removed if(defined $IMPL).
Removed if(defined $HEADER).
$IMPL -> IMPL.
$HEADER -> HEADER.

02:17 Changeset [105713] by mario@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for GTK after r105698.

  • bindings/js/JSPeerConnectionCustom.cpp:

(WebCore::JSPeerConnectionConstructor::constructJSPeerConnection):

02:12 Changeset [105712] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix build erros on Mac by r105706.
https://bugs.webkit.org/show_bug.cgi?id=76763

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::compressedTexImage2D): Removed unused argument names.
(WebCore::WebGLRenderingContext::compressedTexSubImage2D): ditto.

02:03 Changeset [105711] by zeno.albisser@nokia.com
  • 15 edits
    1 copy in trunk/Source/WebKit2

[Qt][WK2] Application URL schemes cause asserts when using debug.
https://bugs.webkit.org/show_bug.cgi?id=76700

Instances of QtNetworkRequestData / QtNetworkReplyData are meant
to be used for transfering data over IPC. To allow transferring
instances of these classes over IPC they need to be copyable,
and it must be possible to create such instances on the stack.
Because classes that inherit from RefCounted always need to be
used in connection with RefPtr, QtNetworkRequestData and
QtNetworkReplyData cannot inherit directly from RefCounted.

Deleting an object that inherits from RefCounted, without
the proper sequence of ref()/deref() being called by it's
RefPtr, causes asserts when running a debug version.

Reviewed by Simon Hausmann.

  • Shared/qt/QtNetworkReplyData.h:

(WebKit::QtRefCountedNetworkReplyData::data):

  • Shared/qt/QtNetworkRequestData.cpp:

(WebKit::QtRefCountedNetworkRequestData::QtRefCountedNetworkRequestData):

  • Shared/qt/QtNetworkRequestData.h:

(WebKit::QtRefCountedNetworkRequestData::data):

  • Target.pri:
  • UIProcess/API/qt/qquicknetworkreply.cpp:

(QQuickNetworkReply::QQuickNetworkReply):
(QQuickNetworkReply::contentType):
(QQuickNetworkReply::setContentType):
(QQuickNetworkReply::operation):
(QQuickNetworkReply::setOperation):
(QQuickNetworkReply::contentDisposition):
(QQuickNetworkReply::setContentDisposition):
(QQuickNetworkReply::location):
(QQuickNetworkReply::setLocation):
(QQuickNetworkReply::lastModified):
(QQuickNetworkReply::setLastModified):
(QQuickNetworkReply::cookie):
(QQuickNetworkReply::setCookie):
(QQuickNetworkReply::userAgent):
(QQuickNetworkReply::setUserAgent):
(QQuickNetworkReply::server):
(QQuickNetworkReply::setServer):
(QQuickNetworkReply::data):
(QQuickNetworkReply::setData):
(QQuickNetworkReply::send):
(QQuickNetworkReply::networkRequestData):
(QQuickNetworkReply::setNetworkRequestData):
(QQuickNetworkReply::networkReplyData):

  • UIProcess/API/qt/qquicknetworkreply_p.h:
  • UIProcess/API/qt/qquicknetworkrequest.cpp:

(QQuickNetworkRequest::QQuickNetworkRequest):
(QQuickNetworkRequest::setNetworkRequestData):
(QQuickNetworkRequest::url):

  • UIProcess/API/qt/qquicknetworkrequest_p.h:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewExperimental::invokeApplicationSchemeHandler):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/qt/QtPageClient.cpp:

(QtPageClient::handleApplicationSchemeRequest):

  • UIProcess/qt/QtPageClient.h:
  • UIProcess/qt/WebPageProxyQt.cpp:

(WebKit::WebPageProxy::resolveApplicationSchemeRequest):
(WebKit::WebPageProxy::sendApplicationSchemeReply):

  • WebProcess/qt/QtNetworkReply.cpp:

(WebKit::QtNetworkReply::setData):
(WebKit::QtNetworkReply::readData):

02:02 Changeset [105710] by tkent@chromium.org
  • 15 edits
    4 adds in trunk

Introduce RadioButtonGroup class to keep track of the group members and required state
https://bugs.webkit.org/show_bug.cgi?id=74909

Reviewed by Darin Adler.

Source/WebCore:

RadioButtonGroup contains a set of member radio buttons in the group,
and "required" status of the group. This helps implementing correct
radio button validity, and improving performance of updating validity
status of radio buttons.

This change fixes the following bugs:

Tests: fast/forms/radio/radio-live-validation-style.html

perf/adding-radio-buttons.html

  • dom/CheckedRadioButtons.cpp:

(WebCore::RadioButtonGroup::isEmpty):
(WebCore::RadioButtonGroup::isRequired):
(WebCore::RadioButtonGroup::checkedButton):
(WebCore::RadioButtonGroup::RadioButtonGroup):
(WebCore::RadioButtonGroup::create):
(WebCore::RadioButtonGroup::isValid):
(WebCore::RadioButtonGroup::setCheckedButton):
(WebCore::RadioButtonGroup::add):
(WebCore::RadioButtonGroup::updateCheckedState):
(WebCore::RadioButtonGroup::requiredAttributeChanged):
(WebCore::RadioButtonGroup::remove):
(WebCore::RadioButtonGroup::setNeedsValidityCheckForAllButtons):
Add RadioButtonGroup class. It keeps track of pointers to member radio
buttons and required status of the group in addition to the checked
radio button pointer.

(WebCore::CheckedRadioButtons::CheckedRadioButtons):
(WebCore::CheckedRadioButtons::~CheckedRadioButtons):
Define empty constructor and destructor in order to avoid exposing
RadioButtonGroup class.

(WebCore::CheckedRadioButtons::addButton):
(WebCore::CheckedRadioButtons::updateCheckedState):
(WebCore::CheckedRadioButtons::requiredAttributeChanged):
(WebCore::CheckedRadioButtons::checkedButtonForGroup):
(WebCore::CheckedRadioButtons::isInRequiredGroup):
(WebCore::CheckedRadioButtons::removeButton):
Change the HashMap member of this class so that it maps a group name to
a RadioButtonGroup object. These functions just get a RadioButtonGroup
object and call a corresponding member function of RadioButtonGroup.

  • dom/CheckedRadioButtons.h: Update declarations.
  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::parseMappedAttribute):
(WebCore::HTMLFormControlElement::requiredAttributeChanged):
Move a part of parseMappedAttribute() into requiredAttributeChanged().

  • html/HTMLFormControlElement.h: Add requiredAttributeChanged().
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::valueMissing):
Move required check code to InputType::valueMissing implementations.
RadioInputType needs special handling for checking required state.
readOnly() and disabled() are unnecessary because willValidate() checks them.
(WebCore::HTMLInputElement::setChecked):
Call new function CheckedRadioButtons::updateCheckedState() instead of
removeButton() and updateCheckedRadioButtons().
(WebCore::HTMLInputElement::requiredAttributeChanged):
Override this to call CheckedRadioButtons::requiredAttributeChanged().

  • html/HTMLInputElement.h: Add requiredAttributeChanged().
  • html/RadioInputType.cpp:

(WebCore::RadioInputType::valueMissing):
Check required state by CheckedRadioButtons::isInRequiredGroup().

  • html/RadioInputType.h: Remove attach().
  • html/CheckboxInputType.cpp:

(WebCore::CheckboxInputType::valueMissing):

Move required check from HTMLInputElement::valueMissing().

  • html/FileInputType.cpp:

(WebCore::FileInputType::valueMissing): ditto.

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::valueMissing): ditto.

LayoutTests:

  • fast/forms/radio/radio-live-validation-style-expected.txt: Added.
  • fast/forms/radio/radio-live-validation-style.html: Added.
  • fast/forms/script-tests/ValidityState-valueMissing-radio.js:
  • Update the expectation for the behavior change of https://bugs.webkit.org/show_bug.cgi?id=76365
  • Add test cases for radio buttons not in a radio button group.
  • fast/forms/ValidityState-valueMissing-radio-expected.txt: ditto.
  • perf/adding-radio-buttons-expected.txt: Added.
  • perf/adding-radio-buttons.html: Added.
01:56 Changeset [105709] by noel.gordon@gmail.com
  • 4 edits
    4 adds in trunk

[chromium] PNG image with CMYK ICC color profile renders color-inverted and squashed
https://bugs.webkit.org/show_bug.cgi?id=76804

Reviewed by Adam Barth.

Source/WebCore:

Use color profiles for PNG images only if their embedded color profile is from an RGB
color space input device.

Test: fast/images/rgb-png-with-cmyk-color-profile.html

  • platform/image-decoders/ImageDecoder.h:

(WebCore::ImageDecoder::rgbColorProfile): Return true if the profile has an RGB color space.
(WebCore::ImageDecoder::inputDeviceColorProfile): Return true if the profile is from an input device.

  • platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::readColorProfile): Ignore PNG image embedded color profile unless the profile
comes from an RGB color space input device.
(WebCore::PNGImageDecoder::headerAvailable): Minor white-space removals courtesy Xcode.

LayoutTests:

  • fast/images/resources/rgb-png-with-cmyk-color-profile.png: Added.
  • fast/images/rgb-png-with-cmyk-color-profile-expected.txt: Added.
  • fast/images/rgb-png-with-cmyk-color-profile.html: Added.
  • platform/mac/fast/images/rgb-png-with-cmyk-color-profile-expected.png: Added.
01:45 Changeset [105708] by carlosgc@webkit.org
  • 11 edits
    3 adds in trunk

[GTK] Implement DownloadClient in WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=72952

Reviewed by Martin Robinson.

Source/WebKit2:

  • GNUmakefile.am: Add new files to compilation.
  • UIProcess/API/gtk/WebKitDownloadClient.cpp: Added.

(didStart): Call webkitWebContextDownloadStarted().
(didReceiveResponse): Call webkitDownloadSetResponse() with the
received response.
(didReceiveData): Call webkitDownloadNotifyProgress().
(decideDestinationWithSuggestedFilename): Call
webkitDownloadDecideDestinationWithSuggestedFilename().
(didCreateDestination): Call webkitDownloadDestinationCreated().
(didFail): Call webkitDownloadFailed() or
webkitDownloadCancelled() if the download was cancelled before
failing.
(didCancel): Call webkitDownloadCancelled().
(didFinish): Call webkitDownloadFinished().
(attachDownloadClientToContext): Add
implementation for download client callbacks.

  • UIProcess/API/gtk/WebKitDownloadClient.h: Added.
  • UIProcess/API/gtk/WebKitError.cpp:

(webkit_download_error_quark): Add quark for download errors.

  • UIProcess/API/gtk/WebKitError.h:
  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkit_web_context_class_init): Add download-started signal.
(createDefaultWebContext): Initialize the download client.
(downloadsMap): HashMap containing download objects for all
ongoing download operations.
(webkit_web_context_download_uri): Start a new download for the
given URI.
(webkitWebContextGetOrCreateDownload): Helper function to create a
new download object or return the existing one from the downloads map.
(webkitWebContextRemoveDownload): Remove the download object from
the downloads map.
(webkitWebContextDownloadStarted): Emit
WebKitWebContext::download-started for the given download object.

  • UIProcess/API/gtk/WebKitWebContext.h:
  • UIProcess/API/gtk/WebKitWebContextPrivate.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
  • UIProcess/API/gtk/tests/GNUmakefile.am: Add new test for downloads.
  • UIProcess/API/gtk/tests/TestDownloads.cpp: Added.

(getWebKit1TestResoucesDir):
(testDownloadLocalFile):
(testDownloadLocalFileError):
(serverCallback):
(testDownloadRemoteFile):
(testDownloadRemoteFileError):
(beforeAll):
(afterAll):

Tools:

  • gtk/generate-gtkdoc:

(get_webkit2_options): Ignore WebKitDownloadClient.

01:25 Changeset [105707] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: fix sticky DOM breakpoints.
https://bugs.webkit.org/show_bug.cgi?id=64437

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DOMBreakpointsSidebarPane.js:

(WebInspector.DOMBreakpointsSidebarPane.prototype._inspectedURLChanged):

01:19 Changeset [105706] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Expose WebGL texture compression methods on WebGLRenderingContext
https://bugs.webkit.org/show_bug.cgi?id=76763

Patch by Gregg Tavares <gman@google.com> on 2012-01-24
Reviewed by Kenneth Russell.

Source/WebCore:

Test: fast/canvas/webgl/compressed-tex-image.html

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::compressedTexImage2D):
(WebCore::WebGLRenderingContext::compressedTexSubImage2D):

  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLRenderingContext.idl:

LayoutTests:

  • fast/canvas/webgl/compressed-tex-image-expected.txt: Added.
  • fast/canvas/webgl/compressed-tex-image.html: Added.
00:54 Changeset [105705] by bashi@chromium.org
  • 13 edits
    1 add
    1 delete in trunk

[V8] Add Uint8ClampedArray support
https://bugs.webkit.org/show_bug.cgi?id=76803

Reviewed by Kenneth Russell.

Source/JavaScriptCore:

  • wtf/ArrayBufferView.h:

(WTF::ArrayBufferView::isUnsignedByteClampedArray): Added.

  • wtf/Uint8ClampedArray.h:

(WTF::Uint8ClampedArray::isUnsignedByteClampedArray): Overridden to return true.

Source/WebCore:

No new tests. fast/js/script-tests/dfg-uint8clampedarray.js should pass on chromium port.

  • WebCore.gypi: Added required files.
  • bindings/scripts/CodeGeneratorV8.pm:

(IsTypedArrayType): Added Uint8ClampedArray.

  • bindings/v8/SerializedScriptValue.cpp: Added the tag for Uint8ClampedArray.

(WebCore::V8ObjectMap::Writer::writeArrayBufferView): Appends the tag when buffer is Uint8ClampedArray.
(WebCore::V8ObjectMap::Reader::readArrayBufferView): Creates Uint8ClampedArray instance when the tag represents Uint8ClampedArray.

  • bindings/v8/custom/V8ArrayBufferViewCustomScript.js:
  • bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp: Added.

(WebCore::V8Uint8ClampedArray::constructorCallback):
(WebCore::V8Uint8ClampedArray::setCallback):
(WebCore::toV8):

  • page/Crypto.cpp: Added isUnsignedByteClampedArray() call to isIntegerArray().
  • page/DOMWindow.idl: Removed ifdefs.
  • workers/WorkerContext.idl: Added Uint8ArrayConstructor.

LayoutTests:

  • platform/chromium/fast/canvas/webgl/array-unit-tests-expected.txt: Removed.
  • platform/chromium/test_expectations.txt: Removed fast/js/dfg-uint8clampedarray.html.
00:49 Changeset [105704] by carlosgc@webkit.org
  • 13 edits
    3 adds in trunk/Source

[GTK] Add WebKitDownload to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=72949

Reviewed by Martin Robinson.

Source/JavaScriptCore:

  • wtf/gobject/GOwnPtr.cpp:

(WTF::GTimer): Use g_timer_destroy() to free a GTimer.

  • wtf/gobject/GOwnPtr.h: Add GTimer template.
  • wtf/gobject/GTypedefs.h: Add GTimer forward declaration.

Source/WebKit2:

  • GNUmakefile.am: Add new files to compilation.
  • UIProcess/API/gtk/WebKitDownload.cpp: Added.

(webkitDownloadFinalize):
(webkitDownloadGetProperty):
(webkitDownloadDecideDestination):
(webkit_download_init):
(webkit_download_class_init):
(webkitDownloadCreate): Create a new WebKitDownload for a given
WKDownloadRef.
(webkitDownloadSetResponse): Set the network response of the
download.
(webkitDownloadIsCancelled): Whether the download has been
cancelled by the user.
(webkitDownloadNotifyProgress): Emit notify::estimated-progress if
needed.
(webkitDownloadFailed): Emit WebKitDownload::failed with the given
error.
(webkitDownloadCancelled): Emit WebKitDownload::failed with
cancelled error.
(webkitDownloadFinished): Emit WebKitDownload::finished.
(webkitDownloadDecideDestinationWithSuggestedFilename): Emit
WebKitDownload::decide-destination.
(webkitDownloadDestinationCreated): Emit
WebKitDownload::created-destination.
(webkit_download_get_destination): Return the destination URI of
the download.
(webkit_download_set_destination): Set the destination URI of the
download.
(webkit_download_get_response): Return the response received by
the server.
(webkit_download_cancel): Cancel the download.
(webkit_download_get_estimated_progress): Return the estimated
progress.
(webkit_download_get_elapsed_time): Return the time elapsed since
the download started.

  • UIProcess/API/gtk/WebKitDownload.h: Added.
  • UIProcess/API/gtk/WebKitDownloadPrivate.h: Added.
  • UIProcess/API/gtk/WebKitPrivate.h:
  • UIProcess/API/gtk/WebKitURIResponse.cpp:

(webkitURIResponseGetResourceResponse):

  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
  • UIProcess/API/gtk/docs/webkit2gtk.types: Add

webkit_download_get_type().

  • UIProcess/API/gtk/webkit2.h: Include WebKitDownload.h.
  • UIProcess/API/gtk/webkit2marshal.list:
00:35 Changeset [105703] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for GTK Debug build after r105698.

  • bindings/js/JSNavigatorCustom.cpp:

(WebCore::JSNavigator::webkitGetUserMedia):

00:26 Changeset [105702] by loislo@chromium.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix for Qt LinuxSH4 build after r105698.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

01/23/12:

23:47 Changeset [105701] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] http/tests/navigation/anchor-frames-gbk.html fails
https://bugs.webkit.org/show_bug.cgi?id=76896

  • platform/qt-wk2/Skipped: Skip the failing test.
23:38 Changeset [105700] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Avoid spurious rebuilds on vs2010 due to DerivedSources not existing
https://bugs.webkit.org/show_bug.cgi?id=76873

Patch by Scott Graham <scottmg@chromium.org> on 2012-01-23
Reviewed by Adam Barth.

  • WebCore.gyp/WebCore.gyp:
23:37 Changeset [105699] by ossy@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

[Qt] Unreviewed gardening after r105647.

  • platform/qt/css3/calc/getComputedStyle-margin-percentage-expected.png: Added.
  • platform/qt/css3/calc/getComputedStyle-margin-percentage-expected.txt: Added.
23:34 Changeset [105698] by ggaren@apple.com
  • 93 edits in trunk/Source

JSValue::toString() should return a JSString* instead of a UString
https://bugs.webkit.org/show_bug.cgi?id=76861

../JavaScriptCore:

Reviewed by Gavin Barraclough.

This makes the common case -- toString() on a string -- faster and
inline-able. (Not a measureable speedup, but we can now remove a bunch
of duplicate hand-rolled code for this optimization.)

This also clarifies the boundary between "C++ strings" and "JS strings".

In all cases other than true, false, null, undefined, and multi-digit
numbers, the JS runtime was just retrieving a UString from a JSString,
so returning a JSString* is strictly better. In the other cases, we can
optimize to avoid creating a new JSString if we care to, but it doesn't
seem to be a big deal.


  • jsc.cpp:

(functionPrint):
(functionDebug):
(functionRun):
(functionLoad):
(functionCheckSyntax):
(runWithScripts):
(runInteractive):

  • API/JSValueRef.cpp:

(JSValueToStringCopy):

  • bytecode/CodeBlock.cpp:

(JSC::valueToSourceString): Call value() after calling toString(), to
convert from "JS string" (JSString*) to "C++ string" (UString), since
toString() no longer returns a "C++ string".

  • dfg/DFGOperations.cpp:

(JSC::DFG::operationValueAddNotNumber):

  • jit/JITStubs.cpp:

(op_add): Updated for removal of toPrimitiveString():
all '+' operands can use toString(), except for object operands, which
need to take a slow path to call toPrimitive().

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncPush):

  • runtime/CommonSlowPaths.h:

(JSC::CommonSlowPaths::opIn):

  • runtime/DateConstructor.cpp:

(JSC::dateParse):

  • runtime/DatePrototype.cpp:

(JSC::formatLocaleDate): Call value() after calling toString(), as above.

  • runtime/ErrorInstance.h:

(JSC::ErrorInstance::create): Simplified down to one canonical create()
function, to make string handling easier.

  • runtime/ErrorPrototype.cpp:

(JSC::errorProtoFuncToString):

  • runtime/ExceptionHelpers.cpp:

(JSC::createInvalidParamError):
(JSC::createNotAConstructorError):
(JSC::createNotAFunctionError):
(JSC::createNotAnObjectError):

  • runtime/FunctionConstructor.cpp:

(JSC::constructFunctionSkippingEvalEnabledCheck):

  • runtime/FunctionPrototype.cpp:

(JSC::functionProtoFuncBind):

  • runtime/JSArray.cpp:

(JSC::JSArray::sort): Call value() after calling toString(), as above.

  • runtime/JSCell.cpp:
  • runtime/JSCell.h: Removed JSCell::toString() because JSValue does this

job now. Doing it in JSCell is slower (requires extra type checking), and
creates the misimpression that language-defined toString() behavior is
an implementation detail of JSCell.

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::encode):
(JSC::decode):
(JSC::globalFuncEval):
(JSC::globalFuncParseInt):
(JSC::globalFuncParseFloat):
(JSC::globalFuncEscape):
(JSC::globalFuncUnescape): Call value() after calling toString(), as above.

  • runtime/JSONObject.cpp:

(JSC::unwrapBoxedPrimitive):
(JSC::Stringifier::Stringifier):
(JSC::JSONProtoFuncParse): Removed some manual optimization that toString()
takes care of.

  • runtime/JSObject.cpp:

(JSC::JSObject::toString):

  • runtime/JSObject.h: Updated to return JSString*.
  • runtime/JSString.cpp:
  • runtime/JSString.h:

(JSC::JSValue::toString): Removed, since I removed JSCell::toString().

  • runtime/JSValue.cpp:

(JSC::JSValue::toStringSlowCase): Removed toPrimitiveString(), and re-
spawned toStringSlowCase() from its zombie corpse, since toPrimitiveString()
basically did what we want all the time. (Note that the toPrimitive()
preference changes from NoPreference to PreferString, because that's
how ToString is defined in the language. op_add does not want this behavior.)

  • runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncToString):
(JSC::numberProtoFuncToLocaleString): A little simpler, now that toString()
returns a JSString*.

  • runtime/ObjectConstructor.cpp:

(JSC::objectConstructorGetOwnPropertyDescriptor):
(JSC::objectConstructorDefineProperty):

  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncHasOwnProperty):
(JSC::objectProtoFuncDefineGetter):
(JSC::objectProtoFuncDefineSetter):
(JSC::objectProtoFuncLookupGetter):
(JSC::objectProtoFuncLookupSetter):
(JSC::objectProtoFuncPropertyIsEnumerable): More calls to value(), as above.

  • runtime/Operations.cpp:

(JSC::jsAddSlowCase): Need to check for object before taking the toString()
fast path becuase adding an object to a string requires calling toPrimitive()
on the object, not toString(). (They differ in their preferred conversion
type.)

  • runtime/Operations.h:

(JSC::jsString):
(JSC::jsStringFromArguments): This code gets simpler, now that toString()
does the right thing.

(JSC::jsAdd): Now checks for object, just like jsAddSlowCase().

  • runtime/RegExpConstructor.cpp:

(JSC::setRegExpConstructorInput):
(JSC::constructRegExp):

  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::match):

  • runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncCompile):
(JSC::regExpProtoFuncToString): More calls to value(), as above.

  • runtime/StringConstructor.cpp:

(JSC::constructWithStringConstructor):
(JSC::callStringConstructor): This code gets simpler, now that toString()
does the right thing.

  • runtime/StringPrototype.cpp:

(JSC::replaceUsingRegExpSearch):
(JSC::replaceUsingStringSearch):
(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncCharAt):
(JSC::stringProtoFuncCharCodeAt):
(JSC::stringProtoFuncConcat):
(JSC::stringProtoFuncIndexOf):
(JSC::stringProtoFuncLastIndexOf):
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):
(JSC::stringProtoFuncSlice):
(JSC::stringProtoFuncSplit):
(JSC::stringProtoFuncSubstr):
(JSC::stringProtoFuncSubstring):
(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):
(JSC::stringProtoFuncLocaleCompare):
(JSC::stringProtoFuncBig):
(JSC::stringProtoFuncSmall):
(JSC::stringProtoFuncBlink):
(JSC::stringProtoFuncBold):
(JSC::stringProtoFuncFixed):
(JSC::stringProtoFuncItalics):
(JSC::stringProtoFuncStrike):
(JSC::stringProtoFuncSub):
(JSC::stringProtoFuncSup):
(JSC::stringProtoFuncFontcolor):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncAnchor):
(JSC::stringProtoFuncLink):
(JSC::trimString): Some of this code gets simpler, now that toString()
does the right thing. More calls to value(), as above.

../JavaScriptGlue:

Reviewed by Gavin Barraclough.

  • JSUtils.cpp:

(KJSValueToCFTypeInternal):

../WebCore:

Reviewed by Gavin Barraclough.

Mechanical changes to call value() after calling toString(), to
convert from "JS string" (JSString*) to "C++ string" (UString), since
toString() no longer returns a "C++ string".

  • bindings/js/IDBBindingUtilities.cpp:

(WebCore::createIDBKeyFromValue):

  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::JSCSSStyleDeclaration::getPropertyCSSValue):

  • bindings/js/JSClipboardCustom.cpp:

(WebCore::JSClipboard::clearData):
(WebCore::JSClipboard::getData):

  • bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):

  • bindings/js/JSDOMBinding.cpp:

(WebCore::valueToStringWithNullCheck):
(WebCore::valueToStringWithUndefinedOrNullCheck):
(WebCore::reportException):

  • bindings/js/JSDOMFormDataCustom.cpp:

(WebCore::JSDOMFormData::append):

  • bindings/js/JSDOMStringMapCustom.cpp:

(WebCore::JSDOMStringMap::putDelegate):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::setLocation):
(WebCore::JSDOMWindow::open):
(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener):

  • bindings/js/JSDeviceMotionEventCustom.cpp:

(WebCore::JSDeviceMotionEvent::initDeviceMotionEvent):

  • bindings/js/JSDeviceOrientationEventCustom.cpp:

(WebCore::JSDeviceOrientationEvent::initDeviceOrientationEvent):

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue):

  • bindings/js/JSDocumentCustom.cpp:

(WebCore::JSDocument::setLocation):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

  • bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::item):
(WebCore::JSHTMLAllCollection::namedItem):

  • bindings/js/JSHTMLCanvasElementCustom.cpp:

(WebCore::JSHTMLCanvasElement::getContext):

  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::JSHTMLCollection::item):
(WebCore::JSHTMLCollection::namedItem):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::documentWrite):

  • bindings/js/JSHTMLInputElementCustom.cpp:

(WebCore::JSHTMLInputElement::setSelectionDirection):
(WebCore::JSHTMLInputElement::setSelectionRange):

  • bindings/js/JSInspectorFrontendHostCustom.cpp:

(WebCore::JSInspectorFrontendHost::showContextMenu):

  • bindings/js/JSJavaScriptCallFrameCustom.cpp:

(WebCore::JSJavaScriptCallFrame::evaluate):

  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::setHref):
(WebCore::JSLocation::setProtocol):
(WebCore::JSLocation::setHost):
(WebCore::JSLocation::setHostname):
(WebCore::JSLocation::setPort):
(WebCore::JSLocation::setPathname):
(WebCore::JSLocation::setSearch):
(WebCore::JSLocation::setHash):
(WebCore::JSLocation::replace):
(WebCore::JSLocation::assign):

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::handleInitMessageEvent):

  • bindings/js/JSSQLTransactionCustom.cpp:

(WebCore::JSSQLTransaction::executeSql):

  • bindings/js/JSSQLTransactionSyncCustom.cpp:

(WebCore::JSSQLTransactionSync::executeSql):

  • bindings/js/JSSharedWorkerCustom.cpp:

(WebCore::JSSharedWorkerConstructor::constructJSSharedWorker):

  • bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::putDelegate):

  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::JSWebGLRenderingContext::getExtension):

  • bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocketConstructor::constructJSWebSocket):
(WebCore::JSWebSocket::send):
(WebCore::JSWebSocket::close):

  • bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::importScripts):

  • bindings/js/JSWorkerCustom.cpp:

(WebCore::JSWorkerConstructor::constructJSWorker):

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::open):
(WebCore::JSXMLHttpRequest::send):

  • bindings/js/JSXSLTProcessorCustom.cpp:

(WebCore::JSXSLTProcessor::setParameter):
(WebCore::JSXSLTProcessor::getParameter):
(WebCore::JSXSLTProcessor::removeParameter):

  • bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::create):

  • bindings/js/ScriptEventListener.cpp:

(WebCore::eventListenerHandlerBody):

  • bindings/js/ScriptValue.cpp:

(WebCore::ScriptValue::toString):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateEventListenerCall):
(JSValueToNative):
(GenerateConstructorDefinition):

  • bridge/c/c_utility.cpp:

(JSC::Bindings::convertValueToNPVariant):

  • bridge/jni/jni_jsobject.mm:

(JavaJSObject::convertValueToJObject):

  • bridge/jni/jsc/JNIUtilityPrivate.cpp:

(JSC::Bindings::convertArrayInstanceToJavaArray):
(JSC::Bindings::convertValueToJValue):

  • bridge/jni/jsc/JavaFieldJSC.cpp:

(JavaField::dispatchValueFromInstance):
(JavaField::valueFromInstance):
(JavaField::dispatchSetValueToInstance):
(JavaField::setValueToInstance):

  • bridge/jni/jsc/JavaInstanceJSC.cpp:

(JavaInstance::invokeMethod):

  • testing/js/JSInternalsCustom.cpp:

(WebCore::JSInternals::setUserPreferredLanguages):

../WebKit/mac:

Reviewed by Gavin Barraclough.

Mechanical changes to call value() after calling toString(), to
convert from "JS string" (JSString*) to "C++ string" (UString), since
toString() no longer returns a "C++ string".

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::addValueToArray):

  • WebView/WebFrame.mm:

(-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
(-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):

../WebKit2:

Reviewed by Gavin Barraclough.

Mechanical changes to call value() after calling toString(), to
convert from "JS string" (JSString*) to "C++ string" (UString), since
toString() no longer returns a "C++ string".

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant):

23:09 Changeset [105697] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

In CodeGeneratorObjC.pm, overwrite the output .h/.mm
only if the bytes differ
https://bugs.webkit.org/show_bug.cgi?id=76874

Reviewed by Adam Barth.

This is one of steps to stop rebuilding .h/.cpp/.mm files
generated by unchanged IDLs (bug 76836).
This patch makes a change on CodeGeneratorObjC.pm so that
it overwrites the output .h/.mm only if the bytes differ.

No tests. No change in behavior.
I manually confirmed that when I add a new attribute to Element.idl,
the time-stamps of unrelated DOM*.h and DOM*.mm do not change.

  • bindings/scripts/CodeGenerator.pm:

(UpdateFileIfChanged): Added. This method writes data to a file
only if the data is different from the data in the current file.

  • bindings/scripts/CodeGeneratorObjC.pm:

(WriteData): Used UpdateFileIfChanged().

22:46 Changeset [105696] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-23

  • DEPS:
22:43 Changeset [105695] by ap@apple.com
  • 7 edits
    10 adds in trunk

REGRESSION: Downloaded file name fallback encodings are not set correctly
https://bugs.webkit.org/show_bug.cgi?id=76862

Reviewed by Adam Barth.

Source/WebCore:

Tests: http/tests/download/default-encoding.html

http/tests/download/form-submission-result.html
http/tests/download/inherited-encoding.html
http/tests/download/literal-utf-8.html

  • loader/DocumentWriter.cpp:
  • loader/DocumentWriter.h:

Removed deprecatedFrameEncoding. Due to changes in Document::encoding behavior, it can now
be used in its place.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest): Instead of hunting

down a correct loader (and active one is not always correct any more), just use opening document's
encoding.

LayoutTests:

  • http/tests/download/default-encoding-expected.txt: Added.
  • http/tests/download/default-encoding.html: Added.
  • http/tests/download/inherited-encoding-expected.txt: Added.
  • http/tests/download/inherited-encoding.html: Added.
  • http/tests/download/literal-utf-8-expected.txt: Added.
  • http/tests/download/literal-utf-8.html: Added.
  • http/tests/download/resources/literal-koi8-r.php: Added.
  • http/tests/download/resources/literal-utf-8.php: Added.
  • http/tests/download/inherited-encoding-form-submission-result-expected.txt: Added.
  • http/tests/download/inherited-encoding-form-submission-result.html: Added.
22:26 Changeset [105694] by ojan@chromium.org
  • 10 edits in trunk

Implement flex-pack:distribute
https://bugs.webkit.org/show_bug.cgi?id=76864

Reviewed by Tony Chang.

Source/WebCore:

See http://dev.w3.org/csswg/css3-flexbox/#flex-pack.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexPack):

  • css/CSSValueKeywords.in:
  • rendering/RenderFlexibleBox.cpp:

(WebCore::initialPackingOffset):
(WebCore::packingSpaceBetweenChildren):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::layoutColumnReverse):

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleFlexibleBoxData.h:

LayoutTests:

  • css3/flexbox/004-expected.txt:
  • css3/flexbox/004.html:
21:44 Changeset [105693] by macpherson@chromium.org
  • 5 edits in trunk/Source/WebCore

Implement CSS clip property in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=74913

Reviewed by Andreas Kling.

No new tests / refactoring only.

  • css/CSSPrimitiveValue.h:
  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::convertToLength):
This new function aims to provide a single call for converting many CSSPrimitiveValue
values to Lengths. It is templated to allow the caller to specify which conversions
are appropriate depending on the context in which the value is used.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyClip::convertToLength):
(WebCore::ApplyPropertyClip::applyInheritValue):
(WebCore::ApplyPropertyClip::applyInitialValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyClip::createHandler):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

21:19 Changeset [105692] by tkent@chromium.org
  • 2 edits
    2 copies in branches/chromium/963

Merge 105386 - REGRESSION(r100111): A 'change' event does not fire when a mouse drag
occurs to switch elements in a listbox <select>
https://bugs.webkit.org/show_bug.cgi?id=76244

Reviewed by Hajime Morita.

Source/WebCore:

Test: fast/forms/select/listbox-drag-in-non-multiple.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::updateSelectedState):
Do not update m_activeSelectionState for non-multiple <select>.
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
Use setActiveSelection*Index() and updateListBoxSelection(true) instead
of updateSelectedState() because updateSelectedState() updates
m_lastOnChangeSelection and will prevent the mouseup handler from
dispatching 'change' event.
We should not call listBoxOnChange() in the mousemove handler in order
to align the behavior of IE and Firefox.

LayoutTests:

  • fast/forms/resources/common.js:

(mouseMoveToIndexInListbox): Added.

  • fast/forms/select/listbox-drag-in-non-multiple-expected.txt: Added.
  • fast/forms/select/listbox-drag-in-non-multiple.html: Added.

TBR=tkent@chromium.org
BUG=crbug.com/110068
Review URL: https://chromiumcodereview.appspot.com/9285007

21:08 Changeset [105691] by tsepez@chromium.org
  • 5 edits
    15 adds in trunk

decodeEscapeSequences() not correct for some encodings (GBK, Big5, ...).
https://bugs.webkit.org/show_bug.cgi?id=71316

Reviewed by Daniel Bates.

Source/WebCore:

Pass trailing unescaped bytes into the character set decoder to get correct
results in the presence of encodings which re-use ASCII values in sequences.

Tests: http/tests/navigation/anchor-frames-gbk.html

http/tests/security/xssAuditor/iframe-onload-GBK-char.html
http/tests/security/xssAuditor/img-onerror-GBK-char.html
http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-16bit-unicode.html
http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode.html
http/tests/security/xssAuditor/script-tag-Big5-char.html
http/tests/security/xssAuditor/script-tag-Big5-char2.html

  • platform/text/DecodeEscapeSequences.h:

(WebCore::Unicode16BitEscapeSequence::findInString):
(WebCore::Unicode16BitEscapeSequence::findEndOfRun):
(WebCore::Unicode16BitEscapeSequence::decodeRun):
(WebCore::URLEscapeSequence::findInString):
(WebCore::URLEscapeSequence::findEndOfRun):
(WebCore::URLEscapeSequence::decodeRun):
(WebCore::decodeEscapeSequences):

LayoutTests:

  • http/tests/navigation/anchor-frames-gbk-expected.txt: Added.
  • http/tests/navigation/anchor-frames-gbk.html: Added.
  • http/tests/navigation/resources/frame-with-anchor-gbk.html: Added.
  • http/tests/security/xssAuditor/iframe-onload-GBK-char-expected.txt: Added.
  • http/tests/security/xssAuditor/iframe-onload-GBK-char.html: Added.
  • http/tests/security/xssAuditor/img-onerror-GBK-char-expected.txt: Added.
  • http/tests/security/xssAuditor/img-onerror-GBK-char.html: Added.
  • http/tests/security/xssAuditor/resources/echo-intertag-decode-16bit-unicode.pl:
  • http/tests/security/xssAuditor/script-tag-Big5-char-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-16bit-unicode-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-16bit-unicode.html: Added.
  • http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode.html: Added.
  • http/tests/security/xssAuditor/script-tag-Big5-char.html: Added.
  • http/tests/security/xssAuditor/script-tag-Big5-char2-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-Big5-char2.html: Added.
  • platform/chromium/test_expectations.txt:
21:04 Changeset [105690] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix a build break in a clean compile of the Chromium port (at least
reported by tbreisacher).

  • css/CSSStyleDeclaration.cpp:
20:53 Changeset [105689] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] QQuickWebView is initializing touch mode twice while being constructed
https://bugs.webkit.org/show_bug.cgi?id=76859

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2012-01-23
Reviewed by Kenneth Rohde Christiansen.

Removing d->initializeTouch() from QQuickWebView::QQuickWebView()
since in QQuickWebViewPrivate::initialize() there is a call for
setUseTraditionalDesktopBehaviour(false), which will call initializeTouch.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebView::QQuickWebView):

20:40 Changeset [105688] by mrobinson@webkit.org
  • 6 edits in trunk/Source/WebKit2

[GTK][WK2] Make the LoadTracking and WebView test fixtures more flexible
https://bugs.webkit.org/show_bug.cgi?id=76755

Reviewed by Alejandro G. Castro.

Always clear the loading events when loading new content in the load tracking
test. In the WebView test correctly handle loading HTML with a URL that isn't
"about:blank."

  • UIProcess/API/gtk/tests/LoadTrackingTest.cpp:

(LoadTrackingTest::loadURI): Reset the class state when starting a new load.
(LoadTrackingTest::loadHtml): Ditto.
(LoadTrackingTest::loadPlainText): Ditto.
(LoadTrackingTest::loadRequest): Ditto.

  • UIProcess/API/gtk/tests/LoadTrackingTest.h: Added new method definitions.
  • UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp:

(assertNormalLoadHappened): No longer clear loading events. The fixture handles that now.
(testLoadHtml): Update to reflect new method name.
(testLoadPlainText): Ditto.
(testLoadRequest): Ditto.
(testWebViewReload): Ditto.

  • UIProcess/API/gtk/tests/WebViewTest.cpp:

(WebViewTest::loadHtml): Properly interpret the baseURL parameter.

  • UIProcess/API/gtk/tests/WebViewTest.h: Make loading methods virtual.
20:38 Changeset [105687] by tsepez@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Clean up old WebSharedWorker::startWorkerContext() method.
https://bugs.webkit.org/show_bug.cgi?id=76853

Reviewed by Darin Fisher.

  • public/WebSharedWorker.h:
  • src/WebSharedWorkerImpl.cpp:
  • src/WebSharedWorkerImpl.h:
20:23 Changeset [105686] by commit-queue@webkit.org
  • 10 edits in trunk

[GTK] editing/deleting/5408255.html results are incorrect
https://bugs.webkit.org/show_bug.cgi?id=53644

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-01-23
Reviewed by Martin Robinson.

Source/WebCore:

When the WEBKIT_TOP_LEVEL environment variable is set, resources
should be loaded from the source tree to which the variable is
pointing. This approach is used when performing testing on the
Gtk port.

No new tests, changes cause one test to pass.

  • platform/graphics/gtk/ImageGtk.cpp:

(getPathToImageResource): Also make changes to the resource path
construction code on Windows.
(WebCore::Image::loadPlatformResource):

Tools:

WEBKIT_TOP_LEVEL environment variable is now set directly in either
WebKitTestRunner or DumpRenderTree through usage of a compilation-time
macro. This way both tools can be run outside the test harness without
the need to manually set the environment variable.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(getTopLevelPath):

  • GNUmakefile.am:
  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort.setup_environ_for_server):

  • WebKitTestRunner/GNUmakefile.am:
  • WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:

(WTR::InjectedBundle::platformInitialize):

LayoutTests:

Unskip newly-passing editing test.

  • platform/gtk/Skipped:
20:15 Changeset [105685] by jchaffraix@webkit.org
  • 3 edits
    2 adds in trunk

Crash in WebCore::RenderTableSection::rowLogicalHeightChanged
https://webkit.org/b/76842

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/table/crash-section-logical-height-changed-needsCellRecalc.html

The issue was that we would access our section's structure when it was dirty.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::rowLogicalHeightChanged):
Bail out if we need cells recalculation as our internal structure is not up-to-date
and we will recompute all the rows' heights as part of the recomputation anyway.

LayoutTests:

  • fast/table/crash-section-logical-height-changed-needsCellRecalc-expected.txt: Added.
  • fast/table/crash-section-logical-height-changed-needsCellRecalc.html: Added.
20:07 Changeset [105684] by dslomov@google.com
  • 7 edits
    2 adds in trunk

Source/WebKit/chromium: [Chromium] Implement layoutTestController.workerThreadCount in DRT
https://bugs.webkit.org/show_bug.cgi?id=74653.
Expose WebCore::WorkerThread::workerThreadCount() in API layer
for DumpRenderTree.

Reviewed by Darin Fisher.

  • WebKit.gyp:
  • public/WebWorkerInfo.h: Copied from Source/WebKit/chromium/public/WebCommonWorkerClient.h.
  • src/WebWorkerInfo.cpp: Copied from Source/WebKit/chromium/public/WebCommonWorkerClient.h.

(WebKit::WebWorkerInfo::dedicatedWorkerCount):

Tools: [Chromium] Implement layoutTestController.workerThreadCount in DRT
https://bugs.webkit.org/show_bug.cgi?id=74653.

Reviewed by Darin Fisher.

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::workerThreadCount):

  • DumpRenderTree/chromium/LayoutTestController.h:

LayoutTests: [Chromium] Implement layoutTestController.workerThreadCount in DRT
https://bugs.webkit.org/show_bug.cgi?id=74653.

Reviewed by Darin Fisher.

  • platform/chromium/test_expectations.txt:
19:59 Changeset [105683] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[Refactoring] Make finish() of CodeGeneratorJS.pm empty
https://bugs.webkit.org/show_bug.cgi?id=76846

Reviewed by Adam Barth.

This is one of steps to stop rebuilding .h/.cpp files generated
by unchanged IDLs (bug 76836).

As a refactoring, we are planning to remove finish() from all
CodeGenerators. In this bug, we make finish() of CodeGeneratorJS.pm
empty.

No new tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(finish): Made it empty. We will remove finish() after
making finish() of all CodeGenerators empty.
(GenerateInterface): Modified to call WriteData().
(WriteData): Simple code refactoring.
Removed if(defined $IMPL).
Removed if(defined $HEADER).
Removed if(defined $DEPS).
$IMPL -> IMPL.
$HEADER -> HEADER.
$DEPS -> DEPS.

19:55 Changeset [105682] by macpherson@chromium.org
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r105676.
http://trac.webkit.org/changeset/105676
https://bugs.webkit.org/show_bug.cgi?id=76665

Breaks build on max due to compile warnings.

  • runtime/JSObject.cpp:

(JSC::JSObject::finalize):
(JSC::JSObject::visitChildren):
(JSC::JSObject::allocatePropertyStorage):

  • runtime/JSObject.h:
19:20 Changeset [105681] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

Fine tune Web Intents Chromium API
https://bugs.webkit.org/show_bug.cgi?id=76754

Patch by Greg Billock <gbillock@google.com> on 2012-01-23
Reviewed by Darin Fisher.

  • public/WebIntent.h:
  • public/WebIntentServiceInfo.h:
  • src/WebIntent.cpp:
  • src/WebIntentServiceInfo.cpp:

(WebKit::WebIntentServiceInfo::WebIntentServiceInfo):

18:45 Changeset [105680] by shawnsingh@chromium.org
  • 5 edits in trunk/Source

[chromium] updateRect is incorrect when contentBounds != bounds
https://bugs.webkit.org/show_bug.cgi?id=72919

Reviewed by James Robinson.

Source/WebCore:

Unit test added to TiledLayerChromiumTest.cpp

The m_updateRect member in LayerChromium types is used to track
what was painted for that layer. For tiled layers (especially
image layers), the updateRect was being given with respect to the
size of the content, rather than the size of the layer. This patch
adds a conversion so that updateRect is always with respect to the
layer size, so that damage tracking will work correctly in those
cases.

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateCompositorResources):

Source/WebKit/chromium:

  • tests/TiledLayerChromiumTest.cpp:

(WTF::FakeTiledLayerWithScaledBounds::FakeTiledLayerWithScaledBounds):
(WTF::FakeTiledLayerWithScaledBounds::setContentBounds):
(WTF::FakeTiledLayerWithScaledBounds::contentBounds):
(WTF::FakeTiledLayerWithScaledBounds::updateRect):
(WTF::TEST):

18:39 Changeset [105679] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Make "Copy as HTML" use the same copy functions as other copy methods.
https://bugs.webkit.org/show_bug.cgi?id=76706

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-01-23
Reviewed by Pavel Feldman.

Changed DOMAgent.copyNode to call getOuterHTML and use the callback function to
return the text to InspectorFrontendHost.copyText. This will make all copy
functions use the same code path.

Not testable.

  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode.prototype.copyNode.copy):
(WebInspector.DOMNode.prototype.copyNode):

18:36 Changeset [105678] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Make zoom multiplier float instead of double to match RenderStyle::effectiveZoom etc. and thus avoid unnecessary precision conversions.
https://bugs.webkit.org/show_bug.cgi?id=69490

Reviewed by Andreas Kling.

Covered by existing tests.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::computeLength):
Use float multiplier instead of double.
(WebCore::CSSPrimitiveValue::computeLengthDouble):
Use float multiplier instead of double.

  • css/CSSPrimitiveValue.h:

Change type signatures of computeLength template prototype.

18:33 Changeset [105677] by eae@chromium.org
  • 66 adds in branches/subpixellayout/Source

Add missing files

18:29 Changeset [105676] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Use copying collector for out-of-line JSObject property storage
https://bugs.webkit.org/show_bug.cgi?id=76665

Reviewed by Geoffrey Garen.

  • runtime/JSObject.cpp:

(JSC::JSObject::visitChildren): Changed to use copyAndAppend whenever the property storage is out-of-line.
(JSC::JSObject::allocatePropertyStorage): Changed to use tryAllocateStorage/tryReallocateStorage as opposed to
operator new.

  • runtime/JSObject.h:
18:18 Changeset [105675] by toyoshim@chromium.org
  • 5 edits in trunk/Source/WebKit/chromium

[Chromium][WebSocket] Remove binary communication using WebData in WebKit API
https://bugs.webkit.org/show_bug.cgi?id=76608

Reviewed by Darin Fisher.

  • public/WebSocket.h: Remove BinaryTypeData definition and sendBinary(const WebData&).
  • public/WebSocketClient.h: Remove didReceiveBinaryData(const WebData&).
  • src/WebSocketImpl.cpp: Remove WebData related code and set default binary type as BinaryTypeBlob.

(WebKit::WebSocketImpl::WebSocketImpl): Remove sendBinary(const WebData&).
(WebKit::WebSocketImpl::didReceiveBinaryData): Remove WebData supporting code.

  • src/WebSocketImpl.h: Remove sendBinary(const WebData&).
18:09 Changeset [105674] by dpranke@chromium.org
  • 4 edits in trunk/Tools

nrwt: make --chromium work like --qt
https://bugs.webkit.org/show_bug.cgi?id=76875

Reviewed by Adam Barth.

--chromium used to have to be handled differently from --qt
due to the way the PortFactory was implemented; there's not
really a good reason for that any more so this patch makes
things slightly more consistent and eliminates the
options.chromium flag (--chromium is now truly a synonym for
--platform chromium).

  • Scripts/webkitpy/layout_tests/port/factory.py:

(PortFactory._default_port):
(PortFactory.get):

  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:

(FactoryTest.setUp):
(FactoryTest.test_chromium_mac):
(FactoryTest.test_chromium_linux):
(FactoryTest.test_chromium_win):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

18:05 Changeset [105673] by dpranke@chromium.org
  • 2 edits in trunk/Tools

run-webkit-tests needs to propagate --chromium
https://bugs.webkit.org/show_bug.cgi?id=76870

Reviewed by Eric Seidel.

run-webkit-tests removes '--chromium' argument from @ARGV when
determining which port to run, which means that that doesn't
propagate to new-run-webkit-tests. That's bad (and is handled
for the other ports by re-adding the flag, but apparently we're
just now noticing for Chromium).

  • Scripts/run-webkit-tests:
18:00 Changeset [105672] by eae@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed test expectations fixes for a couple of window/frame tests.

  • http/tests/security/cross-frame-access-put-expected.txt:

Updated expectations to reflect that window.frameElement now has the type
HTMLIFrameElement. The test itself has already been updated.

  • platform/mac/fast/dom/Window/window-properties-expected.txt:

Added window.applicationCache.abort method.

  • platform/mac/fast/dom/prototype-inheritance-2-expected.txt:

Added DOMURL class.

17:59 Changeset [105671] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK][PATCH] More build silencing with (AM_V_...)
https://bugs.webkit.org/show_bug.cgi?id=76791

Patch by Priit Laes <plaes@plaes.org> on 2012-01-23
Reviewed by Gustavo Noronha Silva.

  • GNUmakefile.am: Silence is golden...
17:54 Changeset [105670] by commit-queue@webkit.org
  • 14 edits in trunk/Source/WebKit2

[Qt] Implement SSL error handling QML API.
https://bugs.webkit.org/show_bug.cgi?id=76793

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2012-01-23
Reviewed by Simon Hausmann.

This patch implements support for accepting or rejecting invalid SSL
certificates from the QML API.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::handleCertificateVerificationRequest):
(QQuickWebViewExperimental::certificateVerificationDialog):
(QQuickWebViewExperimental::setCertificateVerificationDialog):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::certificateVerificationRequest):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/qt/QtDialogRunner.cpp:

(CertificateVerificationDialogContextObject::CertificateVerificationDialogContextObject):
(CertificateVerificationDialogContextObject::hostname):
(CertificateVerificationDialogContextObject::accept):
(CertificateVerificationDialogContextObject::reject):
(QtDialogRunner::initForCertificateVerification):

  • UIProcess/qt/QtDialogRunner.h:
  • UIProcess/qt/QtPageClient.cpp:

(QtPageClient::handleCertificateVerificationRequest):

  • UIProcess/qt/QtPageClient.h:
  • WebProcess/qt/QtNetworkAccessManager.cpp:

(WebKit::QtNetworkAccessManager::QtNetworkAccessManager):
(WebKit::QtNetworkAccessManager::onSslErrors):

  • WebProcess/qt/QtNetworkAccessManager.h:
17:47 Changeset [105669] by bweinstein@apple.com
  • 4 edits in trunk

More build fixing after r105646.

Source/JavaScriptCore:

Tools:

  • TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:

(TestWebKitAPI::TestNode::key):

17:36 Changeset [105668] by commit-queue@webkit.org
  • 12 edits in trunk/Source/WebCore

MicroData: Remove ExceptionCode& from setAttribute() call.
https://bugs.webkit.org/show_bug.cgi?id=76695

Patch by Arko Saha <nghq36@motorola.com> on 2012-01-23
Reviewed by Hajime Morita.

Changeset http://trac.webkit.org/changeset/103296 removed unused
ExceptionCode& argument from Element::setAttribute(QualifiedName).
Hence updating all calls to setAttribute() method in MicroData code.

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::setItemValueText):

  • html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::setItemValueText):

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::setItemValueText):

  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::setItemValueText):

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::setItemValueText):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::setItemValueText):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setItemValueText):

  • html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::setItemValueText):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::setItemValueText):

  • html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::setItemValueText):

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::setItemValueText):

17:31 Changeset [105667] by levin@chromium.org
  • 6 edits in trunk/Source

[windows] Convert usages of GetDC to HWndDC Part 2.
https://bugs.webkit.org/show_bug.cgi?id=76750

Reviewed by Adam Roben.

Source/WebKit/win:

  • FullscreenVideoController.cpp:

(createCompatibleDCForWindow): Moved out the code which creates a DC for a window
to keep the same scope for the DC lifetime.
(FullscreenVideoController::draw): Switch to using OwnPtr<HDC>
since createCompatibleDCForWindow returns a PassOwnPtr.

  • WebNodeHighlight.cpp:

(WebNodeHighlight::update):

Cleaned up leaks from calling GetDC without release.
Note that there is a potential leak of hdc that previously existed
and still does in an early exit scenario. (This could be easily fixed
by using OwnPtr<HDC> but I was trying to keep this patch focused.)

  • WebView.cpp:

(WebView::scrollBackingStore): Typical conversion.
(WebView::updateBackingStore): Reduced the scope of windowDC to be
right where it is being used.
(WebView::performLayeredWindowUpdate): Typical conversion.
(WebView::paintIntoBackingStore): Ditto.

Source/WebKit2:

  • Shared/win/ShareableBitmapWin.cpp:

(WebKit::ShareableBitmap::windowsContext): Fix incorrect usage of OwnPtr<HDC> which
would do a DeleteDC instead of a ReleaseDC.

17:21 Changeset [105666] by barraclough@apple.com
  • 2 edits in trunk/Tools

Unreviewed build fix - r105646 broke this.

  • TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:

(TestWebKitAPI::TestNode::TestNode):
(TestWebKitAPI::TestNode::key):
(TestWebKitAPI::RedBlackTreeTest::assertEqual):
(TestWebKitAPI::RedBlackTreeTest::assertSameValuesForKey):
(TestWebKitAPI::RedBlackTreeTest::testDriver):

17:21 Changeset [105665] by hayato@chromium.org
  • 3 edits
    2 adds in trunk

Fix crash when a focused node is removed while in processing focusin event.
https://bugs.webkit.org/show_bug.cgi?id=76656

Reviewed by Dimitri Glazkov.

Source/WebCore:

Test: fast/events/focus-remove-focuesed-node.html

  • dom/Document.cpp:

(WebCore::Document::setFocusedNode):

LayoutTests:

  • fast/events/focus-remove-focuesed-node-expected.txt: Added.
  • fast/events/focus-remove-focuesed-node.html: Added.
17:16 Changeset [105664] by scherkus@chromium.org
  • 4 edits in trunk/LayoutTests

Switch media/audio-data-url.html layout test to base64-encoded WAV data.
https://bugs.webkit.org/show_bug.cgi?id=76759

Reviewed by Eric Carlson.

  • media/audio-data-url-expected.txt:
  • media/audio-data-url.html:
  • platform/chromium/test_expectations.txt:
17:10 Changeset [105663] by abarth@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r105658.
http://trac.webkit.org/changeset/105658
https://bugs.webkit.org/show_bug.cgi?id=76883

We want this eventually, but not right at this moment
(Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-23

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
17:09 Changeset [105662] by jamesr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Add <(SHARED_INTERMEDIATE_DIR)/webkit to include path of targets that depend on WebKit API so they pick up the copied headers in an onion build
https://bugs.webkit.org/show_bug.cgi?id=76879

Reviewed by Dirk Pranke.

  • WebKit.gyp:
17:07 Changeset [105661] by levin@chromium.org
  • 13 edits in trunk/Source

[windows] Convert usages of GetDC to HWndDC Part 1.
https://bugs.webkit.org/show_bug.cgi?id=76744

Reviewed by Adam Roben.

Source/WebCore:

No new functionality so no new tests.

  • platform/graphics/win/FontCacheWin.cpp:

(WebCore::FontCache::getFontDataForCharacters): Changed GetDC to HWndDC
and removed ReleaseDC.
(WebCore::createGDIFont): Ditto.
(WebCore::FontCache::getTraitsInFamily): Ditto.

  • platform/graphics/win/FontPlatformDataWin.cpp:

(WebCore::FontPlatformData::FontPlatformData): Ditto.

  • platform/graphics/win/SimpleFontDataCGWin.cpp:

(WebCore::SimpleFontData::platformInit): Ditto.

  • platform/graphics/win/SimpleFontDataWin.cpp:

(WebCore::SimpleFontData::initGDIFont): Ditto.
(WebCore::SimpleFontData::containsCharacters): Ditto.
(WebCore::SimpleFontData::determinePitch): Ditto.
(WebCore::SimpleFontData::boundsForGDIGlyph): Ditto.
(WebCore::SimpleFontData::widthForGDIGlyph): Ditto.
(WebCore::SimpleFontData::scriptFontProperties): Ditto.

  • platform/win/CursorWin.cpp:

(WebCore::createSharedCursor): Ditto.

  • platform/win/DragImageCGWin.cpp:

(WebCore::scaleDragImage): Ditto.
(WebCore::createDragImageFromImage): Ditto.

  • platform/win/DragImageWin.cpp:

(WebCore::createDragImageForLink): Ditto.

  • platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::writeImage): Ditto.

Source/WebKit/win:

  • WebIconDatabase.cpp:

(createDIB): Changed GetDC to HWndDC and removed ReleaseDC.

Source/WebKit2:

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::flashBackingStoreUpdates): Typical conversion.

16:54 Changeset [105660] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[GTK] Scrollbars do not respect the has-backward-stepper and has-forward-stepper properties
https://bugs.webkit.org/show_bug.cgi?id=76747

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-01-23
Reviewed by Gustavo Noronha Silva.

No new tests. Regressions are covered by existing tests, but testing
different GTK+ theme configurations is not possible yet.

  • platform/gtk/ScrollbarThemeGtk.cpp:

(WebCore::ScrollbarThemeGtk::backButtonRect): If there is no back stepper, return an empty rect.
(WebCore::ScrollbarThemeGtk::forwardButtonRect): If there is no forward stepper, return an empty rect.
(WebCore::ScrollbarThemeGtk::trackRect): Adjust track rect calculation to account for when there is
no steppers.

  • platform/gtk/ScrollbarThemeGtk.h: New members describing whether there are primary steppers.
  • platform/gtk/ScrollbarThemeGtk2.cpp:

(WebCore::ScrollbarThemeGtk::updateThemeProperties): Look at the theme to determine if there
are primary foward and back steppers.

  • platform/gtk/ScrollbarThemeGtk3.cpp:

(WebCore::ScrollbarThemeGtk::updateThemeProperties): Ditto.

16:47 Changeset [105659] by rniwa@webkit.org
  • 3 edits
    4 adds in trunk

REGRESSION(r105396): drag state is not cleared after each drag
https://bugs.webkit.org/show_bug.cgi?id=76878

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Revert a part of r105396 that made performDragAndDrop not call clearDragState
when the default action was not prevented since it caused a regression.

I'm pretty certain always calling clearDragState in performDragAndDrop is wrong
but I can't think of a test case where this becomes a problem at the moment.
Since this area is not well tested, revert the change instead of making further
changes to the code base.

Tests: fast/events/clear-drag-state.html

fast/events/clear-edit-drag-state.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::performDragAndDrop):

LayoutTests:

Add a regression test to ensure we don't fire extra dragenter event
on the second drag at an element that contains the dragged content.

  • fast/events/clear-drag-state-expected.txt: Added.
  • fast/events/clear-drag-state.html: Added.
  • fast/events/clear-edit-drag-state-expected.txt: Added.
  • fast/events/clear-edit-drag-state.html: Added.
16:41 Changeset [105658] by abarth@webkit.org
  • 2 edits in trunk/Tools

garden-o-matic should support Chromium Mac Lion
https://bugs.webkit.org/show_bug.cgi?id=76880

Reviewed by Eric Seidel.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
16:40 Changeset [105657] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Fixed typo in exception messages
https://bugs.webkit.org/show_bug.cgi?id=76710

Patch by Thiago Marcos P. Santos <tmpsantos@gmail.com> on 2012-01-23
Reviewed by Alexey Proskuryakov.

  • dom/DOMCoreException.cpp:
  • fileapi/FileException.cpp:
  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::openTransactionAndPreflight):
(WebCore::SQLTransaction::postflightAndCommit):

  • xml/XMLHttpRequestException.cpp:
16:35 Changeset [105656] by levin@chromium.org
  • 2 edits in trunk/Source/WebCore

Allow delayed DC allocation in HWndDC.
https://bugs.webkit.org/show_bug.cgi?id=76737

Reviewed by Adam Roben.

No new functionality exposed so no new tests.

  • platform/win/HWndDC.h: Changed this slightly to allow

for allocating a window DC after the initial creation since
this pattern occurrs in several places so this makes it easy to
replace them in an upcoming change.
(WebCore::HWndDC::HWndDC):
(WebCore::HWndDC::~HWndDC):
(WebCore::HWndDC::setHWnd):
(WebCore::HWndDC::clear):

16:26 Changeset [105655] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

MicroData: Compilation error while building Webkit with --microdata.
https://bugs.webkit.org/show_bug.cgi?id=76703

Patch by Arko Saha <nghq36@motorola.com> on 2012-01-23
Reviewed by Hajime Morita.

  • dom/MicroDataItemList.cpp:

(WebCore::MicroDataItemList::MicroDataItemList):
(WebCore::MicroDataItemList::~MicroDataItemList):

  • dom/MicroDataItemList.h:
  • dom/NodeRareData.h:

(WebCore::NodeRareData::properties):

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::create):
(WebCore::HTMLPropertiesCollection::HTMLPropertiesCollection):

  • html/HTMLPropertiesCollection.h:
16:22 Changeset [105654] by levin@chromium.org
  • 8 edits in trunk/Source/WebCore

[chromium] Convert uses of GetDC to HWndDC.
https://bugs.webkit.org/show_bug.cgi?id=76290

Reviewed by Dmitry Titov.

  • platform/graphics/chromium/FontCacheChromiumWin.cpp:

(WebCore::createFontIndirectAndGetWinName):
(WebCore::fontContainsCharacter):
(WebCore::FontCache::getLastResortFallbackFont):
(WebCore::FontCache::getTraitsInFamily):

  • platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:

(WebCore::FontPlatformData::scriptFontProperties):

  • platform/graphics/chromium/FontUtilsChromiumWin.cpp:

(WebCore::FontMap::getAscent):
(WebCore::FontMap::getSpaceGlyph):

  • platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:

(WebCore::fillBMPGlyphs):

  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:

(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::determinePitch):
(WebCore::SimpleFontData::platformWidthForGlyph):

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::EnsureCachedDCCreated):

  • rendering/RenderThemeChromiumWin.cpp:

(WebCore::systemFontSize):
(WebCore::pointsToPixels):

16:13 Changeset [105653] by commit-queue@webkit.org
  • 2 edits in trunk/Websites/webkit.org

website: Reword WEBKITOUTPUTDIR documentation on Building WebKit page
https://bugs.webkit.org/show_bug.cgi?id=76544

Patch by Seo Sanghyeon <sh4.seo@samsung.com> on 2012-01-23
Reviewed by Darin Adler.

WEBKITOUTPUTDIR is not only for Windows.

  • building/build.html:
16:01 Changeset [105652] by eae@chromium.org
  • 3 edits in trunk/Tools

check-webkit-style whitespace/operators triggers on overloaded division operator
https://bugs.webkit.org/show_bug.cgi?id=76650

Reviewed by Darin Adler.

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_spacing):

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(CppStyleTest.test_operator_methods):

16:00 Changeset [105651] by commit-queue@webkit.org
  • 4 edits
    1 add
    3 deletes in trunk/LayoutTests

Reduce throttling on video-buffering-repaints-controls test to prevent timeout.
https://bugs.webkit.org/show_bug.cgi?id=76113

Also reduces flakiness by checking for a repaint between progress and
suspend events versus just between progress events.

Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-01-23
Reviewed by Adam Barth.

  • http/tests/media/video-buffering-repaints-controls-expected.txt: Added.
  • http/tests/media/video-buffering-repaints-controls.html:
  • platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.png:
  • platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
  • platform/chromium-win/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
15:49 Changeset [105650] by rniwa@webkit.org
  • 4 edits in trunk/Tools

run-perf-tests should report server-side errors
https://bugs.webkit.org/show_bug.cgi?id=76802

Reviewed by Tony Chang.

Report errors whenever server's response doesn't match "OK".

  • Scripts/webkitpy/common/net/file_uploader.py:

(FileUploader.upload_single_text_file):
(FileUploader.upload_as_multipart_form_data):
(FileUploader._upload_data.callback):
(FileUploader):
(FileUploader._upload_data):

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._upload_json):

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(test_upload_json):
(test_upload_json.MockFileUploader.upload_single_text_file):

15:46 Changeset [105649] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=75799
Calling intersectsNode on a detached range should throw.

Source/WebCore:

INVALID_STATE_ERR exception should be thrown if intersectsNode is called on a detached Range.

Patch by Joe Thomas <joethomas@motorola.com> on 2012-01-23
Reviewed by Darin Adler.

Test: fast/dom/Range/range-intersectsNode-exception.html

  • dom/Range.cpp:

(WebCore::Range::intersectsNode): Throwing INVALID_STATE_ERR exception if the range is detached.

LayoutTests:

Added test case to verify the exception thrown while calling intersectsNode on a detached range.

Patch by Joe Thomas <joethomas@motorola.com> on 2012-01-23
Reviewed by Darin Adler.

  • fast/dom/Range/range-intersectsNode-exception-expected.txt: Added.
  • fast/dom/Range/range-intersectsNode-exception.html: Added.
  • fast/dom/Range/range-intersectsNode-expected.txt:
  • fast/dom/Range/resources/intersectsNode.js: Modified the test case to catch the exception.
15:35 Changeset [105648] by dcheng@chromium.org
  • 19 edits
    1 delete in trunk/Source/WebCore

Convert DataTransferItem/DataTransferItemList back into an interface class
https://bugs.webkit.org/show_bug.cgi?id=76856

When Qt implemented the DataTransferItemList, a lot of logic was moved into the shared
classes since Chromium/Qt happened to implement it the same way. Now that I want to do some
refactoring/cleanup work to better implement DataTransferItemList in Chromium, we won't
share the same data anymore so it doesn't make sense to keep that code in a common location.

Reviewed by David Levin.

Covered by existing tests.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DataTransferItem.cpp:
  • dom/DataTransferItem.h:
  • dom/DataTransferItemList.cpp: Removed.
  • dom/DataTransferItemList.h:
  • platform/chromium/ClipboardChromium.cpp:

(WebCore::ClipboardChromium::mayUpdateItems):

  • platform/chromium/DataTransferItemChromium.cpp:

(WebCore::DataTransferItemChromium::create):
(WebCore::DataTransferItemChromium::DataTransferItemChromium):
(WebCore::DataTransferItemChromium::getAsString):
(WebCore::DataTransferItemChromium::getAsFile):
(WebCore::DataTransferItemChromium::clipboardChromium):

  • platform/chromium/DataTransferItemChromium.h:

(WebCore::DataTransferItemChromium::kind):
(WebCore::DataTransferItemChromium::type):

  • platform/chromium/DataTransferItemListChromium.cpp:

(WebCore::DataTransferItemListChromium::DataTransferItemListChromium):

  • platform/chromium/DataTransferItemListChromium.h:
  • platform/qt/DataTransferItemListQt.cpp:

(WebCore::DataTransferItemListQt::DataTransferItemListQt):
(WebCore::DataTransferItemListQt::length):
(WebCore::DataTransferItemListQt::item):
(WebCore::DataTransferItemListQt::deleteItem):
(WebCore::DataTransferItemListQt::clear):
(WebCore::DataTransferItemListQt::add):

  • platform/qt/DataTransferItemListQt.h:
  • platform/qt/DataTransferItemQt.cpp:

(WebCore::DataTransferItemQt::create):
(WebCore::DataTransferItemQt::DataTransferItemQt):
(WebCore::DataTransferItemQt::getAsString):
(WebCore::DataTransferItemQt::getAsFile):

  • platform/qt/DataTransferItemQt.h:

(WebCore::DataTransferItemQt::kind):
(WebCore::DataTransferItemQt::type):

15:32 Changeset [105647] by mikelawther@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

getComputedStyle margin percentage test for CSS calc
https://bugs.webkit.org/show_bug.cgi?id=76130

Reviewed by Darin Adler.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

  • css3/calc/getComputedStyle-margin-percentage-expected.txt: Added.
  • css3/calc/getComputedStyle-margin-percentage.html: Added.
15:30 Changeset [105646] by barraclough@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=76855
Implement a JIT-code aware sampling profiler for JSC

Reviewed by Geoff Garen.

Step 2: generalize RedBlackTree. The profiler is going to want tio use
a RedBlackTree, allow this class to work with subclasses of
RedBlackTree::Node, Node should not need to know the names of the m_key
and m_value fields (the subclass can provide a key() accessor), and
RedBlackTree does not need to know anything about ValueType.

(WTF::MetaAllocator::findAndRemoveFreeSpace):
(WTF::MetaAllocator::debugFreeSpaceSize):
(WTF::MetaAllocator::addFreeSpace):

  • wtf/MetaAllocator.h:

(WTF::MetaAllocator::FreeSpaceNode::FreeSpaceNode):
(WTF::MetaAllocator::FreeSpaceNode::key):

  • wtf/MetaAllocatorHandle.h:

(WTF::MetaAllocatorHandle::key):

  • wtf/RedBlackTree.h:

(WTF::RedBlackTree::Node::successor):
(WTF::RedBlackTree::Node::predecessor):
(WTF::RedBlackTree::Node::parent):
(WTF::RedBlackTree::Node::setParent):
(WTF::RedBlackTree::Node::left):
(WTF::RedBlackTree::Node::setLeft):
(WTF::RedBlackTree::Node::right):
(WTF::RedBlackTree::Node::setRight):
(WTF::RedBlackTree::insert):
(WTF::RedBlackTree::remove):
(WTF::RedBlackTree::findExact):
(WTF::RedBlackTree::findLeastGreaterThanOrEqual):
(WTF::RedBlackTree::findGreatestLessThanOrEqual):
(WTF::RedBlackTree::first):
(WTF::RedBlackTree::last):
(WTF::RedBlackTree::size):
(WTF::RedBlackTree::treeMinimum):
(WTF::RedBlackTree::treeMaximum):
(WTF::RedBlackTree::treeInsert):
(WTF::RedBlackTree::leftRotate):
(WTF::RedBlackTree::rightRotate):
(WTF::RedBlackTree::removeFixup):

15:01 Changeset [105645] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed buildfix for ENABLE(MUTATION_OBSERVERS) following r105642.

  • css/CSSMutableStyleDeclaration.cpp:
14:42 Changeset [105644] by rniwa@webkit.org
  • 4 edits in trunk/Tools

run-perf-tests ignore Skipped list on chromium
https://bugs.webkit.org/show_bug.cgi?id=76764

Reviewed by Dirk Pranke.

Move skipped_perf_tests from WebKit port to Base port so that Chromium port
can also find skipped list. Chromium port only uses test_expectations.txt for
layout tests but performacne tests don't use test_expectations.txt so Chromium port
also needs to use Skipped list.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port._tests_from_skipped_file_contents):
(Port):
(Port._expectations_from_skipped_files):
(Port.skipped_perf_tests):

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_skipped_perf_tests):
(PortTest.test_skipped_perf_tests.add_text_file):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._skipped_tests_for_unsupported_features):
(WebKitPort._skipped_file_search_paths):
(WebKitPort.skipped_layout_tests):

14:37 Changeset [105643] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Update uniteIfNonZero to use isZero.
https://bugs.webkit.org/show_bug.cgi?id=76637

Patch by Philip Rogers <pdr@google.com> on 2012-01-23
Reviewed by Darin Adler.

No new tests. (I found no existing codepath that would be affected by
this change but I think this change is still valuable in preventing
future bugs.)

  • platform/graphics/FloatRect.cpp:

(WebCore::FloatRect::uniteIfNonZero):

The following change is a minor followup to
https://bugs.webkit.org/show_bug.cgi?id=76177#c12 and is not directly
related to the rest of this patch.

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::computeContainerBoundingBoxes):

14:26 Changeset [105642] by antti@apple.com
  • 24 edits
    2 deletes in trunk/Source/WebCore

Eliminate CSSElementStyleDeclaration
https://bugs.webkit.org/show_bug.cgi?id=76848

Reviewed by Andreas Kling.

CSSElementStyleDeclaration has little functionality. It can merge with CSSMutableStyleDeclaration simplifying the code.

Having an element parent is mutually exclusive with having a css rule parent. We can keep them in a union. This also
shrinks all inline style declarations by one pointer.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMBinding.h:

(WebCore::root):

  • css/CSSAllInOne.cpp:
  • css/CSSElementStyleDeclaration.cpp: Removed.
  • css/CSSElementStyleDeclaration.h: Removed.
  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):

  • css/CSSMutableStyleDeclaration.h:

(WebCore::CSSMutableStyleDeclaration::createInline):
(WebCore::CSSMutableStyleDeclaration::createForSVGFontFaceElement):
(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):

  • css/CSSStyleDeclaration.cpp:

(WebCore::CSSStyleDeclaration::CSSStyleDeclaration):
(WebCore::CSSStyleDeclaration::parentStyleSheet):

Merge the CSSElementStyleDeclaration::styleSheet() logic here.


  • css/CSSStyleDeclaration.h:

(WebCore::CSSStyleDeclaration::parentRule):
(WebCore::CSSStyleDeclaration::clearParentRule):
(WebCore::CSSStyleDeclaration::parentElement):
(WebCore::CSSStyleDeclaration::clearParentElement):

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::setSelectorText):

CSSStyleRule's style declaration can't have isElementStyleDeclaration set, the dead code can be removed.
This is asserted in setDeclaration() and again implicitly in the destructor (by clearParentRule()).


  • dom/StyledElement.cpp:

(WebCore::StyledElement::createInlineStyleDecl):
(WebCore::StyledElement::destroyInlineStyleDecl):
(WebCore::StyledElement::ensureInlineStyleDecl):
(WebCore::StyledElement::copyNonAttributeProperties):

  • dom/StyledElement.h:

(WebCore::StyledElement::inlineStyleDecl):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):

  • editing/DeleteButtonController.cpp:

(WebCore::DeleteButtonController::createDeletionUI):

  • html/ValidationMessage.cpp:

(WebCore::adjustBubblePosition):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::setPosition):
(WebCore::MediaControlPanelElement::resetPosition):
(WebCore::MediaControlPanelElement::makeOpaque):
(WebCore::MediaControlPanelElement::makeTransparent):

  • html/shadow/SliderThumbElement.cpp:

(WebCore::TrackLimiterElement::create):

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::SVGFontFaceElement):

14:07 Changeset [105641] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r105640.
http://trac.webkit.org/changeset/105640
https://bugs.webkit.org/show_bug.cgi?id=76849

Broke the chromium build.

  • DEPS:
13:41 Changeset [105640] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

rolling chromium DEPS to r118713
https://bugs.webkit.org/show_bug.cgi?id=76849

Patch by Justin Novosad <junov@chromium.org> on 2012-01-23
Reviewed by Stephen White.

This is to pick up a change to skia build configuration

  • DEPS:
13:39 Changeset [105639] by aestes@apple.com
  • 4 edits in trunk

Fix the build after r105635.

Source/JavaScriptCore:

Tools:

  • TestWebKitAPI/Tests/WTF/StringBuilder.cpp:

(TestWebKitAPI::TEST):

13:36 Changeset [105638] by mhahnenberg@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Remove StackBounds from JSGlobalData
https://bugs.webkit.org/show_bug.cgi?id=76310

Reviewed by Sam Weinig.

Removed StackBounds and the stack() function from JSGlobalData since it no
longer accessed any members of JSGlobalData.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

  • heap/MachineStackMarker.cpp:

(JSC::MachineThreads::addCurrentThread):
(JSC::MachineThreads::gatherFromCurrentThread):

  • parser/Parser.cpp:

(JSC::::Parser):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:
13:35 Changeset [105637] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

Use OVERRIDE for PopupMenuClient's implementations
https://bugs.webkit.org/show_bug.cgi?id=76774

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-01-23
Reviewed by Darin Adler.

  • rendering/RenderMenuList.h: Also sort the methods to the same

order as PopupMenuClient.

  • rendering/RenderTextControlSingleLine.h:
13:08 Changeset [105636] by barraclough@apple.com
  • 24 edits in trunk/Source/JavaScriptCore

Implement a JIT-code aware sampling profiler for JSC
https://bugs.webkit.org/show_bug.cgi?id=76855

Rubber stanmped by Geoff Garen.

Mechanical change - pass CodeBlock through to the executable allocator,
such that we will be able to map ranges of JIT code back to their owner.

  • assembler/ARMAssembler.cpp:

(JSC::ARMAssembler::executableCopy):

  • assembler/ARMAssembler.h:
  • assembler/AssemblerBuffer.h:

(JSC::AssemblerBuffer::executableCopy):

  • assembler/AssemblerBufferWithConstantPool.h:

(JSC::AssemblerBufferWithConstantPool::executableCopy):

  • assembler/LinkBuffer.h:

(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::linkCode):

  • assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::executableCopy):

  • assembler/SH4Assembler.h:

(JSC::SH4Assembler::executableCopy):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::executableCopy):
(JSC::X86Assembler::X86InstructionFormatter::executableCopy):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):

  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGRepatch.cpp:

(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::tryCachePutByID):

  • dfg/DFGThunks.cpp:

(JSC::DFG::osrExitGenerationThunkGenerator):

  • jit/ExecutableAllocator.cpp:

(JSC::ExecutableAllocator::allocate):

  • jit/ExecutableAllocator.h:
  • jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::ExecutableAllocator::allocate):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):

  • jit/JITStubs.cpp:
  • jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::finalize):

  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::compile):

12:42 Changeset [105635] by wangxianzhu@chromium.org
  • 16 edits in trunk

Basic enhancements to StringBuilder
https://bugs.webkit.org/show_bug.cgi?id=67081

Source/JavaScriptCore:

This change contains the following enhancements to StringBuilder,
for convenience, performance, testability, etc.:

  • Change toStringPreserveCapacity() to const
  • new public methods: capacity(), swap(), toAtomicString(), canShrink() and append(const StringBuilder&)
  • == and != opearators to compare StringBuilders and a StringBuilder/String

Unit tests: Tools/TestWebKitAPI/Tests/WTF/StringBuilder.cpp

Reviewed by Darin Adler.

(WTF::SubstringTranslator::hash):
(WTF::SubstringTranslator::equal):
(WTF::SubstringTranslator::translate):
(WTF::AtomicString::add):
(WTF::AtomicString::addSlowCase):

  • wtf/text/AtomicString.h:

(WTF::AtomicString::AtomicString):
(WTF::AtomicString::add):

  • wtf/text/StringBuilder.cpp:

(WTF::StringBuilder::reifyString):
(WTF::StringBuilder::resize):
(WTF::StringBuilder::canShrink):
(WTF::StringBuilder::shrinkToFit):

  • wtf/text/StringBuilder.h:

(WTF::StringBuilder::append):
(WTF::StringBuilder::toString):
(WTF::StringBuilder::toStringPreserveCapacity):
(WTF::StringBuilder::toAtomicString):
(WTF::StringBuilder::isEmpty):
(WTF::StringBuilder::capacity):
(WTF::StringBuilder::is8Bit):
(WTF::StringBuilder::swap):
(WTF::equal):
(WTF::operator==):
(WTF::operator!=):

  • wtf/text/StringImpl.h:

Source/WebCore:

These changes are because we explicitly disallowed StringBuilder's
copy constructor and assignment operator, and the change of return
type of StringBuilder::toString().

Reviewed by Darin Adler.

No new tests. All layout tests and unit tests should run as before.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::setUpCookiesForQuickTime):

  • svg/SVGPathStringBuilder.h:

(WebCore::SVGPathStringBuilder::cleanup):

Source/WebKit/chromium:

This change is because we explicitly disallowed StringBuilder's
copy constructor and assignment operator.

Reviewed by Darin Adler.

No new tests. All layout tests and unit tests should run as before.

  • src/WebPageSerializerImpl.cpp:

(WebKit::WebPageSerializerImpl::encodeAndFlushBuffer):

Tools:

Reviewed by Darin Adler.

  • TestWebKitAPI/Tests/WTF/StringBuilder.cpp:

(TestWebKitAPI::TEST):

12:00 Changeset [105634] by wjmaclean@chromium.org
  • 6 edits
    11 adds in trunk/Source

[chromium] Add WebSolidColorLayer interface to draw non-textured color layers from Aura.
https://bugs.webkit.org/show_bug.cgi?id=75732

Reviewed by James Robinson.

Source/WebCore:

Add WebSolidColorLayer to paint solid-color layers without a backing texture.

Test: unit test for CCSolidColorLayerImpl.

  • WebCore.gypi:
  • platform/graphics/chromium/SolidColorLayerChromium.cpp: Added.

(WebCore::SolidColorLayerChromium::createCCLayerImpl):
(WebCore::SolidColorLayerChromium::create):
(WebCore::SolidColorLayerChromium::SolidColorLayerChromium):
(WebCore::SolidColorLayerChromium::~SolidColorLayerChromium):

  • platform/graphics/chromium/SolidColorLayerChromium.h: Added.
  • platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp: Added.

(WebCore::CCSolidColorLayerImpl::CCSolidColorLayerImpl):
(WebCore::CCSolidColorLayerImpl::~CCSolidColorLayerImpl):
(WebCore::CCSolidColorLayerImpl::quadTransform):
(WebCore::CCSolidColorLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCSolidColorLayerImpl.h: Added.

(WebCore::CCSolidColorLayerImpl::create):
(WebCore::CCSolidColorLayerImpl::layerTypeAsString):

Source/WebKit/chromium:

  • WebKit.gyp:
  • WebKit.gypi:
  • public/platform/WebSolidColorLayer.h: Added.
  • src/WebSolidColorLayer.cpp: Added.

(WebKit::WebSolidColorLayer::create):
(WebKit::WebSolidColorLayer::WebSolidColorLayer):
(WebKit::WebSolidColorLayer::setBackgroundColor):

  • src/WebSolidColorLayerImpl.cpp: Added.

(WebKit::WebSolidColorLayerImpl::create):
(WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl):
(WebKit::WebSolidColorLayerImpl::~WebSolidColorLayerImpl):

  • src/WebSolidColorLayerImpl.h: Added.
  • tests/CCLayerTestCommon.cpp: Added.

(CCLayerTestCommon::completelyContains):
(CCLayerTestCommon::verifyQuadsExactlyCoverRect):

  • tests/CCLayerTestCommon.h: Added.
  • tests/CCSolidColorLayerImplTest.cpp: Added.

(CCLayerTestCommon::TEST):

  • tests/CCTiledLayerImplTest.cpp:
11:39 Changeset [105633] by abarth@webkit.org
  • 32 edits
    15 adds
    24 deletes in trunk/LayoutTests

Update the baselines for a number of tests that use gradients. The new
results are just slightly different than the old results.

  • fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
  • fast/gradients/border-image-gradient-expected.txt: Added.
  • fast/gradients/border-image-gradient-sides-and-corners-expected.txt: Added.
  • platform/chromium-linux-x86/fast/gradients: Removed.
  • platform/chromium-linux/fast/canvas/fillrect_gradient-expected.png:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/chromium-linux/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Removed.
  • platform/chromium-linux/fast/gradients/css3-color-stops-expected.png: Removed.
  • platform/chromium-linux/fast/gradients/css3-repeating-linear-gradients-expected.png:
  • platform/chromium-linux/fast/gradients/generated-gradients-expected.png:
  • platform/chromium-linux/fast/gradients/simple-gradients-expected.png:
  • platform/chromium-linux/svg/as-background-image/svg-as-background-2-expected.png: Removed.
  • platform/chromium-linux/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/chromium-mac-leopard/fast/canvas/fillrect_gradient-expected.png:
  • platform/chromium-mac-leopard/fast/gradients/generated-gradients-expected.png:
  • platform/chromium-mac-leopard/fast/reflections/reflection-masks-expected.png:
  • platform/chromium-mac-snowleopard/fast/canvas/fillrect_gradient-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/canvas/gradient-add-second-start-end-stop-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement: Added.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/gradients/border-image-gradient-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/gradients/css3-color-stops-expected.png:
  • platform/chromium-mac-snowleopard/fast/gradients/css3-repeating-linear-gradients-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/gradients/generated-gradients-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/gradients/simple-gradients-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/reflections/reflection-masks-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-2-expected.png:
  • platform/chromium-mac-snowleopard/svg/filters/big-sized-filter-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/chromium-mac/fast/canvas/fillrect_gradient-expected.png: Removed.
  • platform/chromium-mac/fast/canvas/gradient-add-second-start-end-stop-expected.png: Removed.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Removed.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
  • platform/chromium-mac/fast/gradients/border-image-gradient-expected.png: Removed.
  • platform/chromium-mac/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Removed.
  • platform/chromium-mac/fast/gradients/css3-repeating-linear-gradients-expected.png: Removed.
  • platform/chromium-mac/fast/gradients/generated-gradients-expected.png: Removed.
  • platform/chromium-mac/fast/gradients/simple-gradients-expected.png: Removed.
  • platform/chromium-mac/fast/reflections/reflection-masks-expected.png: Removed.
  • platform/chromium-mac/svg/filters/big-sized-filter-expected.png: Removed.
  • platform/chromium-win-vista/fast/gradients: Removed.
  • platform/chromium-win-xp/svg/as-background-image: Removed.
  • platform/chromium-win/fast/canvas/fillrect_gradient-expected.png:
  • platform/chromium-win/fast/canvas/gradient-add-second-start-end-stop-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png:
  • platform/chromium-win/fast/gradients/border-image-gradient-expected.png:
  • platform/chromium-win/fast/gradients/border-image-gradient-sides-and-corners-expected.png:
  • platform/chromium-win/fast/gradients/css3-color-stops-expected.png:
  • platform/chromium-win/fast/gradients/css3-repeating-linear-gradients-expected.png:
  • platform/chromium-win/fast/gradients/generated-gradients-expected.png:
  • platform/chromium-win/fast/gradients/simple-gradients-expected.png:
  • platform/chromium-win/fast/reflections/reflection-masks-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-as-background-2-expected.png:
  • platform/chromium-win/svg/filters/big-sized-filter-expected.png:
  • platform/chromium-win/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt: Removed.
  • platform/gtk/fast/gradients/border-image-gradient-expected.txt: Removed.
  • platform/gtk/fast/gradients/border-image-gradient-sides-and-corners-expected.txt: Removed.
  • platform/mac/fast/gradients/border-image-gradient-expected.txt: Removed.
  • platform/mac/fast/gradients/border-image-gradient-sides-and-corners-expected.txt: Removed.
  • platform/qt/fast/gradients/border-image-gradient-expected.txt: Removed.
  • platform/qt/fast/gradients/border-image-gradient-sides-and-corners-expected.txt: Removed.
09:20 Changeset [105632] by antti@apple.com
  • 3 edits in trunk/Source/WebCore

Attempt to fix Qt build.

Not reviewed.

  • css/CSSElementStyleDeclaration.cpp:
  • css/CSSElementStyleDeclaration.h:

(WebCore::CSSElementStyleDeclaration::createForSVGFontFaceElement):

09:00 Changeset [105631] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

Move m_rootEditableElementForSelectionOnMouseDown off of HTMLAnchorElement.
<http://webkit.org/b/76833>

Reviewed by Antti Koivisto.

Move HTMLAnchorElement::m_rootEditableElementForSelectionOnMouseDown to a rare
data-style hashmap, effectively shrinking HTMLAnchorElement by one CPU word.

The pointer is only used during interactive event handling, so it shouldn't have
any noticeable effects on web performance.

This reduces memory consumption by 256 kB (on 64-bit) when viewing the full
HTML5 spec at <http://whatwg.org/c>.

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::HTMLAnchorElement):
(WebCore::HTMLAnchorElement::~HTMLAnchorElement):
(WebCore::HTMLAnchorElement::defaultEventHandler):
(WebCore::HTMLAnchorElement::treatLinkAsLiveForEventType):
(WebCore::rootEditableElementMap):
(WebCore::HTMLAnchorElement::rootEditableElementForSelectionOnMouseDown):
(WebCore::HTMLAnchorElement::setRootEditableElementForSelectionOnMouseDown):

  • html/HTMLAnchorElement.h:
08:49 Changeset [105630] by antti@apple.com
  • 17 edits
    1 delete in trunk/Source/WebCore

Eliminate CSSElementStyleDeclaration subclasses
https://bugs.webkit.org/show_bug.cgi?id=76827

Reviewed by Andreas Kling.

CSSInlineStyleDeclaration and FontFaceStyleDeclaration serve no real purpose.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSElementStyleDeclaration.cpp:

(WebCore::CSSElementStyleDeclaration::createForSVGFontFaceElement):
(WebCore::CSSElementStyleDeclaration::styleSheet):

  • css/CSSElementStyleDeclaration.h:

(WebCore::CSSElementStyleDeclaration::createInline):
(WebCore::toCSSElementStyleDeclaration):

  • css/CSSInlineStyleDeclaration.h: Removed.
  • css/CSSMutableStyleDeclaration.cpp:
  • dom/StyledElement.cpp:

(WebCore::StyledElement::createInlineStyleDecl):
(WebCore::StyledElement::ensureInlineStyleDecl):
(WebCore::StyledElement::copyNonAttributeProperties):

  • dom/StyledElement.h:

(WebCore::StyledElement::inlineStyleDecl):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):

  • editing/DeleteButtonController.cpp:

(WebCore::DeleteButtonController::createDeletionUI):

  • html/ValidationMessage.cpp:

(WebCore::adjustBubblePosition):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::setPosition):
(WebCore::MediaControlPanelElement::resetPosition):
(WebCore::MediaControlPanelElement::makeOpaque):
(WebCore::MediaControlPanelElement::makeTransparent):

  • html/shadow/SliderThumbElement.cpp:

(WebCore::TrackLimiterElement::create):

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::SVGFontFaceElement):

08:45 Changeset [105629] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, unskip now passing tests on GTK. Spotted by Zan Dobersek.

  • platform/gtk/Skipped: Unskip tests 5 tests using ArrayBuffer

which is no longer tied to 3D_CANVAS.

08:37 Changeset [105628] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Not reviewed: annotate inspector's js so that it compiled.

  • inspector/front-end/ElementsTreeOutline.js:
  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.SuggestBox.prototype.upKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.downKeyPressed):

08:32 Changeset [105627] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, mark another test as flaky crash.

  • platform/gtk/test_expectations.txt:

editing/execCommand/19455.html is flaky, sometimes hitting an ASSERT.

08:24 Changeset [105626] by philn@webkit.org
  • 3 edits in trunk/Source/WebCore

[GStreamer] fix WebAudio build after r105431
https://bugs.webkit.org/show_bug.cgi?id=76819

Reviewed by Martin Robinson.

  • platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::copyGstreamerBuffersToAudioChannel): Use mutableData()
when copying.

  • platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(webKitWebAudioSrcLoop): Drop constness when setting the buffer
data pointer.

08:20 Changeset [105625] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: add touch events to the event listeners list.
https://bugs.webkit.org/show_bug.cgi?id=76830

Reviewed by Yury Semikhatsky.

  • English.lproj/localizedStrings.js:
  • inspector/InjectedScriptSource.js:

(.):

  • inspector/front-end/BreakpointsSidebarPane.js:

(WebInspector.EventListenerBreakpointsSidebarPane):

07:52 Changeset [105624] by philn@webkit.org
  • 3 edits
    16 adds in trunk/LayoutTests

Unreviewed, GTK gardening. Rebaseline after r105613, marked 3 svg
flaky tests and added baselines for 15 tests.

  • platform/gtk/css3/images/cross-fade-background-size-expected.txt: Added.
  • platform/gtk/fast/backgrounds/mask-box-image-expected.txt: Added.
  • platform/gtk/fast/borders/scaled-border-image-expected.txt: Added.
  • platform/gtk/fast/css/text-overflow-input-expected.txt: Added.
  • platform/gtk/fast/line-grid/line-grid-floating-expected.txt: Added.
  • platform/gtk/fast/line-grid/line-grid-inside-columns-expected.txt: Added.
  • platform/gtk/fast/line-grid/line-grid-into-floats-expected.txt: Added.
  • platform/gtk/fast/line-grid/line-grid-positioned-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
  • platform/gtk/svg/custom/relative-sized-image-expected.txt: Added.
  • platform/gtk/svg/custom/transform-with-shadow-and-gradient-expected.txt: Added.
  • platform/gtk/svg/filters/feImage-preserveAspectratio-expected.txt: Added.
  • platform/gtk/svg/text/append-text-node-to-tspan-expected.txt: Added.
  • platform/gtk/svg/text/modify-text-node-in-tspan-expected.txt: Added.
  • platform/gtk/svg/text/remove-text-node-from-tspan-expected.txt: Added.
  • platform/gtk/svg/text/remove-tspan-from-text-expected.txt: Added.
  • platform/gtk/test_expectations.txt:
07:47 Changeset [105623] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: inspector close button is missing in the dock-to-right mode.
https://bugs.webkit.org/show_bug.cgi?id=76829

Reviewed by Timothy Hatcher.

  • inspector/front-end/inspector.js:

(WebInspector.set attached):
(WebInspector.get _setCompactMode):

07:25 BuildingGtk edited by philn@webkit.org
added gst modules in example moduleset (diff)
07:24 Changeset [105622] by ossy@webkit.org
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r105613.

  • platform/qt/svg/W3C-SVG-1.1/masking-path-04-b-expected.png: Updated.
  • platform/qt/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt: Updated.
07:17 Changeset [105621] by vsevik@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: IndexedDBModel should keep track of requests sent to the backend.
https://bugs.webkit.org/show_bug.cgi?id=76705

Reviewed by Pavel Feldman.

  • inspector/Inspector.json:
  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore::InspectorIndexedDBAgent::requestDatabaseNamesForFrame):

  • inspector/InspectorIndexedDBAgent.h:
  • inspector/front-end/IndexedDBModel.js:

(WebInspector.IndexedDBModel):
(WebInspector.IndexedDBModel.prototype._frameDetached):
(WebInspector.IndexedDBModel.prototype._reset):
(WebInspector.IndexedDBModel.prototype._loadDatabaseNamesForFrame):
(WebInspector.IndexedDBRequestManager):
(WebInspector.IndexedDBRequestManager.prototype.requestDatabaseNamesForFrame.innerCallback):
(WebInspector.IndexedDBRequestManager.prototype.requestDatabaseNamesForFrame):
(WebInspector.IndexedDBRequestManager.prototype._databaseNamesLoaded):
(WebInspector.IndexedDBRequestManager.prototype._requestId):
(WebInspector.IndexedDBRequestManager.prototype._frameDetached):
(WebInspector.IndexedDBRequestManager.prototype._reset):
(WebInspector.IndexedDBRequestManager.DatabasesForFrameRequest):
(WebInspector.IndexedDBDispatcher):
(WebInspector.IndexedDBDispatcher.prototype.databaseNamesLoaded):

07:10 Changeset [105620] by pfeldman@chromium.org
  • 5 edits
    3 adds in trunk

Web Inspector: Inspecting an element inside an iframe no longer works
https://bugs.webkit.org/show_bug.cgi?id=76808

Reviewed by Timothy Hatcher.

Source/WebCore:

Test: http/tests/inspector/inspect-element.html

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::innerParentNode):

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode.prototype.getChildNodes.mycallback):
(WebInspector.DOMNode.prototype.getChildNodes):
(WebInspector.DOMNode.prototype._setChildrenPayload):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype._selectedNodeChanged):

LayoutTests:

  • http/tests/inspector/inspect-element-expected.txt: Added.
  • http/tests/inspector/inspect-element.html: Added.
  • http/tests/inspector/resources/inspect-element-iframe.html: Added.
06:52 Changeset [105619] by caseq@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: response.bodySize in HAR is invalid (negative) for cached resources
https://bugs.webkit.org/show_bug.cgi?id=76823

Reviewed by Yury Semikhatsky.

  • fix response.bodySize for cached resources;

Also some drive-by fixes:

  • pretty-print HAR when exported
  • proper annotation for JSON.stringify()
  • de-obfuscate a piece of code in TimelinePanel
  • inspector/front-end/HAREntry.js:

(WebInspector.HAREntry.prototype.get responseBodySize):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._exportAll):
(WebInspector.NetworkLogView.prototype._exportResource):

06:45 Changeset [105618] by mario@webkit.org
  • 4 edits
    2 adds in trunk/Source/WebCore

[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

New files for the implementation of the AtkAction interface,
containing the related code from WebKitAccessibleWrapperAtk.cpp.

  • accessibility/gtk/WebKitAccessibleInterfaceAction.cpp: Added.

(core):
(webkitAccessibleActionInterfaceInit):
(webkitAccessibleActionDoAction):
(webkitAccessibleActionGetNActions):
(webkitAccessibleActionGetDescription):
(webkitAccessibleActionGetKeybinding):
(webkitAccessibleActionGetName):

  • accessibility/gtk/WebKitAccessibleInterfaceAction.h: Added.
  • accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Remove code

related to the implementation of the AtkAction interface.

Add new files to build files.

  • GNUmakefile.list.am: Add WebKitAccessibleInterfaceAction.[h|cpp].
  • WebCore.gypi: Ditto.
06:36 Changeset [105617] by mario@webkit.org
  • 2 edits in trunk/Tools

[GTK] run-gtk-tests randomly fails while running the xprop comand
https://bugs.webkit.org/show_bug.cgi?id=76817

Reviewed by Gustavo Noronha Silva.

No need to use xprop to remove the AT_SPI_BUS property since
run-gtk-tests will always run new instances of Xvfb.

  • Scripts/run-gtk-tests:

(TestRunner): Unskip TestWebKitAccessibility.
(TestRunner.run): Uncomment lines for launching the accessibility
bus and registry daemon, and remove lines for running xprop.

06:32 Changeset [105616] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Don't warn about override and final being C++11 extensions

Clang will emit a warning when these extensions are used without passing
--std=c++11, but we use feature checking to decide if we have the right
extensions, so we can safely ignore these warnings. The XCode and Windows
project files have the same workaround.

The reason for adding the flag to QMAKE_OBJECTIVE_CFLAGS as well is that
we only have one extra compiler for Objective-C, which is also used for
Objective-C++ sources, so we have to pass the flag, even if it doesn't
make sense for Objective-C.

Reviewed by Simon Hausmann.

06:12 Changeset [105615] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed tweaking of test expectations: it should be IMAGE instead of IMAGE+TEXT.

  • platform/chromium/test_expectations.txt:
06:03 Changeset [105614] by antonm@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed rebaseline after r105613 (SVG animation repaint issue...).

  • platform/chromium-mac-leopard/svg/custom/relative-sized-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/relative-sized-image-expected.png: Added.
05:05 BuildingGtk edited by kov@webkit.org
(diff)
05:01 BuildingGtk edited by kov@webkit.org
(diff)
05:00 BuildingGtk edited by kov@webkit.org
(diff)
04:59 BuildingGtk edited by kov@webkit.org
Add info on WEBKIT_EXTRA_MODULE{S,SETS} (diff)
04:48 Changeset [105613] by zimmermann@webkit.org
  • 9 edits
    6 adds in trunk

SVG animation repaint issue with image and dynamic clipPath
https://bugs.webkit.org/show_bug.cgi?id=76559

Reviewed by Zoltan Herczeg.

Source/WebCore:

Based on patch by Kelly Norton <knorton@google.com>. I extended the patch
to correctly handle relative length resolution as well.

RenderSVGImage doesn't react on setNeedsBoundariesUpdate() calls
and thus fails to update its boundaries in some cases.

The logic is also inconsistent, compared to the other renderers.
Fix that properly, by reusing the method used in RenderSVGViewportContainer.
Call calculateImageViewport() immediately, after initializing the LayoutRepainter.
Previously we resolved the image viewport in RenderSVGImage::updateFromElement. This is
wrong, as it queries the frameRect() of the RenderSVGRoot in a state, where the renderer
still needs layout, leading to wrong results.

I turned Kellys manual testcase into a predictable test, see svg/repaint/image-with-clip-path.svg
Relative sized image handling is tested in svg/custom/relative-sized-image.xhtml now.

Tests: svg/custom/relative-sized-image.xhtml

svg/repaint/image-with-clip-path.svg

  • rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::RenderSVGImage):
(WebCore::RenderSVGImage::updateImageViewport):
(WebCore::RenderSVGImage::layout):

  • rendering/svg/RenderSVGImage.h:

(WebCore::RenderSVGImage::setNeedsBoundariesUpdate):

  • svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::svgAttributeChanged):

LayoutTests:

Update results after fixing RenderSVGImage repainting.

  • platform/chromium-win/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
  • platform/mac/svg/custom/relative-sized-image-expected.png: Added.
  • platform/mac/svg/custom/relative-sized-image-expected.txt: Added.
  • platform/mac/svg/repaint/image-with-clip-path-expected.png: Added.
  • svg/custom/relative-sized-image.xhtml: Added.
  • svg/repaint/image-with-clip-path-expected.txt: Added.
  • svg/repaint/image-with-clip-path.svg: Added.
04:42 Changeset [105612] by zimmermann@webkit.org
  • 11 edits in trunk

<feImage> has problems referencing local elements
https://bugs.webkit.org/show_bug.cgi?id=76800

Reviewed by Zoltan Herczeg.

Source/WebCore:

<feImage> referencing local elements are currently rendered into an ImageBuffer
by SVGFEImageElement, using the local coordinates of the referenced renderer.

This approach is buggy and should be avoided, by moving the rendering fully
into SVGFEImage, which takes care of respecting the correct transformations.

This fixes <feImage> + local references, which currently breaks two tests in trunk.
Covered by existing tests.

  • rendering/svg/RenderSVGResourceFilterPrimitive.cpp:

(WebCore::RenderSVGResourceFilterPrimitive::determineFilterPrimitiveSubregion):

  • svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::build):

  • svg/graphics/filters/SVGFEImage.cpp:

(WebCore::FEImage::FEImage):
(WebCore::FEImage::createWithImage):
(WebCore::FEImage::createWithIRIReference):
(WebCore::FEImage::determineAbsolutePaintRect):
(WebCore::FEImage::referencedRenderer):
(WebCore::FEImage::platformApplySoftware):
(WebCore::FEImage::externalRepresentation):

  • svg/graphics/filters/SVGFEImage.h:

(WebCore::FEImage::~FEImage):

  • svg/graphics/filters/SVGFilter.h:

(WebCore::SVGFilter::absoluteTransform):

LayoutTests:

Update svg/filters/feImage-reference-* results, which are fixed now.

  • platform/chromium/test_expectations.txt : Updated.
  • platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png: Update for marginal change.
  • svg/filters/feImage-reference-invalidation-expected.png:
  • svg/filters/feImage-reference-svg-primitive-expected.png:
04:39 Changeset [105611] by zimmermann@webkit.org
  • 2 edits in trunk/Source/WebCore

2012-01-23 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix Mac build, by exporting a new symbol.

  • WebCore.exp.in:
03:55 Changeset [105610] by mario@webkit.org
  • 5 edits
    2 adds in trunk/Source/WebCore

[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

Move common function returnString() from the wrapper and
hyperlink implementations to a new utility file.

  • accessibility/gtk/WebKitAccessibleUtil.cpp: Added.

(returnString): Taken from WebKitAccessibleWrapperAtk.cpp and
WebKitAccessibleHyperlink.cpp

  • accessibility/gtk/WebKitAccessibleUtil.h: Added.
  • accessibility/gtk/WebKitAccessibleHyperlink.cpp: Remove local

implementation of returnString.

  • accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Ditto.

Add new files to build files.

  • GNUmakefile.list.am: Add WebKitAccessibleUtil.[h|cpp].
  • WebCore.gypi: Ditto.
03:51 Changeset [105609] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

WebKit fails IETC composition event types
https://bugs.webkit.org/show_bug.cgi?id=76690

Unreviewed gardening after r105605.

  • fast/events/ime-composition-events-001-expected.txt: Updated.
03:46 Changeset [105608] by mario@webkit.org
  • 3 edits in trunk/Source/WebCore

[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

Fix typo in class struct (parent class field had the wrong type),
fix coding style issues and update date in headers.

  • accessibility/gtk/WebKitAccessibleHyperlink.cpp:
  • accessibility/gtk/WebKitAccessibleHyperlink.h:
03:43 Changeset [105607] by mario@webkit.org
  • 7 edits in trunk/Source

[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

Source/WebCore:

Rename WebKitAccessible's public functions to follow WebKit's
coding style and update callers.

  • accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleNew): Renamed from webkit_accessible_new.
(webkitAccessibleGetAccessibilityObject): Likewise.
(webkitAccessibleDetach):Likewise.
(webkitAccessibleGetFocusedElement): Likewise.

  • accessibility/gtk/WebKitAccessibleWrapperAtk.h:

Update calls to WebKitAccessible's public functions.

  • accessibility/gtk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::detachWrapper): Update call.
(WebCore::AXObjectCache::attachWrapper): Ditto.

  • accessibility/gtk/WebKitAccessibleHyperlink.cpp:

(core): Update call.

Source/WebKit/gtk:

Update callers to WebKitAccessible's public functions.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::getFocusedAccessibleElement):
(modifyAccessibilityValue):
(DumpRenderTreeSupportGtk::accessibilityHelpText):

03:17 Changeset [105606] by carlosgc@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Fix make distcheck.

  • GNUmakefile.list.am: Add missing files, remove deleted files and

fix indentation.

02:41 Changeset [105605] by bashi@chromium.org
  • 4 edits in trunk

WebKit fails IETC composition event types
https://bugs.webkit.org/show_bug.cgi?id=76690

02:21 Changeset [105604] by mario@webkit.org
  • 10 edits
    2 moves in trunk/Source

[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

Source/WebCore:

Rename the file for the ATK AccessibilityObject wrapper to be more
coherent with the rest of the files in the same directory.

  • accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Renamed from

Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp.
(fallbackObject):
(returnString):
(core):
(webkit_accessible_get_name):
(webkit_accessible_get_description):
(setAtkRelationSetFromCoreObject):
(isRootObject):
(atkParentOfRootObject):
(webkit_accessible_get_parent):
(getNChildrenForTable):
(webkit_accessible_get_n_children):
(getChildForTable):
(webkit_accessible_ref_child):
(getIndexInParentForCellInRow):
(webkit_accessible_get_index_in_parent):
(addAttributeToSet):
(webkit_accessible_get_attributes):
(atkRole):
(webkit_accessible_get_role):
(selectionBelongsToObject):
(isTextWithCaret):
(setAtkStateSetFromCoreObject):
(webkit_accessible_ref_state_set):
(webkit_accessible_ref_relation_set):
(webkit_accessible_init):
(webkit_accessible_finalize):
(webkit_accessible_class_init):
(webkit_accessible_get_type):
(webkit_accessible_action_do_action):
(webkit_accessible_action_get_n_actions):
(webkit_accessible_action_get_description):
(webkit_accessible_action_get_keybinding):
(webkit_accessible_action_get_name):
(atk_action_interface_init):
(listObjectForSelection):
(optionFromList):
(optionFromSelection):
(webkit_accessible_selection_add_selection):
(webkit_accessible_selection_clear_selection):
(webkit_accessible_selection_ref_selection):
(webkit_accessible_selection_get_selection_count):
(webkit_accessible_selection_is_child_selected):
(webkit_accessible_selection_remove_selection):
(webkit_accessible_selection_select_all_selection):
(atk_selection_interface_init):
(utf8Substr):
(convertUniCharToUTF8):
(textForRenderer):
(textForObject):
(webkit_accessible_text_get_text):
(getGailTextUtilForAtk):
(getPangoLayoutForAtk):
(webkit_accessible_text_get_text_after_offset):
(webkit_accessible_text_get_text_at_offset):
(webkit_accessible_text_get_text_before_offset):
(webkit_accessible_text_get_character_at_offset):
(webkit_accessible_text_get_caret_offset):
(baselinePositionForRenderObject):
(getAttributeSetForAccessibilityObject):
(compareAttribute):
(attributeSetDifference):
(accessibilityObjectLength):
(getAccessibilityObjectForOffset):
(getRunAttributesFromAccesibilityObject):
(webkit_accessible_text_get_run_attributes):
(webkit_accessible_text_get_default_attributes):
(textExtents):
(webkit_accessible_text_get_character_extents):
(webkit_accessible_text_get_range_extents):
(webkit_accessible_text_get_character_count):
(webkit_accessible_text_get_offset_at_point):
(getSelectionOffsetsForObject):
(webkit_accessible_text_get_n_selections):
(webkit_accessible_text_get_selection):
(webkit_accessible_text_add_selection):
(webkit_accessible_text_set_selection):
(webkit_accessible_text_remove_selection):
(webkit_accessible_text_set_caret_offset):
(atk_text_interface_init):
(webkit_accessible_editable_text_set_run_attributes):
(webkit_accessible_editable_text_set_text_contents):
(webkit_accessible_editable_text_insert_text):
(webkit_accessible_editable_text_copy_text):
(webkit_accessible_editable_text_cut_text):
(webkit_accessible_editable_text_delete_text):
(webkit_accessible_editable_text_paste_text):
(atk_editable_text_interface_init):
(contentsToAtk):
(atkToContents):
(webkit_accessible_component_ref_accessible_at_point):
(webkit_accessible_component_get_extents):
(webkit_accessible_component_grab_focus):
(atk_component_interface_init):
(webkit_accessible_image_get_image_position):
(webkit_accessible_image_get_image_description):
(webkit_accessible_image_get_image_size):
(atk_image_interface_init):
(cell):
(cellIndex):
(cellAtIndex):
(webkit_accessible_table_ref_at):
(webkit_accessible_table_get_index_at):
(webkit_accessible_table_get_column_at_index):
(webkit_accessible_table_get_row_at_index):
(webkit_accessible_table_get_n_columns):
(webkit_accessible_table_get_n_rows):
(webkit_accessible_table_get_column_extent_at):
(webkit_accessible_table_get_row_extent_at):
(webkit_accessible_table_get_column_header):
(webkit_accessible_table_get_row_header):
(webkit_accessible_table_get_caption):
(webkit_accessible_table_get_column_description):
(webkit_accessible_table_get_row_description):
(atk_table_interface_init):
(webkitAccessibleHypertextGetLink):
(webkitAccessibleHypertextGetNLinks):
(webkitAccessibleHypertextGetLinkIndex):
(atkHypertextInterfaceInit):
(webkitAccessibleHyperlinkImplGetHyperlink):
(atkHyperlinkImplInterfaceInit):
(documentAttributeValue):
(webkit_accessible_document_get_attribute_value):
(webkit_accessible_document_get_attributes):
(webkit_accessible_document_get_locale):
(atk_document_interface_init):
(webkitAccessibleValueGetCurrentValue):
(webkitAccessibleValueGetMaximumValue):
(webkitAccessibleValueGetMinimumValue):
(webkitAccessibleValueSetCurrentValue):
(webkitAccessibleValueGetMinimumIncrement):
(atkValueInterfaceInit):
(GetAtkInterfaceTypeFromWAIType):
(getInterfaceMaskFromObject):
(getUniqueAccessibilityTypeName):
(getAccessibilityTypeFromObject):
(webkit_accessible_new):
(webkit_accessible_get_accessibility_object):
(webkit_accessible_detach):
(webkit_accessible_get_focused_element):
(objectFocusedAndCaretOffsetUnignored):

  • accessibility/gtk/WebKitAccessibleWrapperAtk.h: Renamed from

Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.h.

Update the include for the AccessibilityObject wrapper header.

  • accessibility/gtk/AXObjectCacheAtk.cpp: Update include.
  • accessibility/gtk/WebKitAccessibleHyperlink.cpp: Ditto.
  • accessibility/gtk/WebKitAccessibleHyperlink.h: Ditto.
  • editing/gtk/FrameSelectionGtk.cpp:

Update filename for the ATK wrapper in build files.

  • GNUmakefile.list.am: Updated.
  • WebCore.gypi: Updated.

Source/WebKit/gtk:

Update the include for the AccessibilityObject wrapper header.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Update include.
  • webkit/webkitwebframe.cpp: Ditto.
02:14 Changeset [105603] by vestbo@webkit.org
  • 3 edits in trunk/Tools

[Qt] Change how build-webkit decides when to do full incremental builds

Instead of relying on update-webkit (which isn't run on the bots) to
decide when to do a full incremental build (make qmake), we let the
build-webkit script itself check the current SVN revision against the
previous build (by storing it in .webkit.config).

If the two differ we assume a full incremental build is needed, since
the new revisions might have introduced problematic things like new
Q_OBJECT macros. If not, we assume the developer is doing changes
locally, and revert to doing a plain 'make'.

In addition, when the build fails in the latter case, we inform the
developer of possible pitfalls and how to manually run 'make qmake'.

Reviewed by Ossy.

02:09 Changeset [105602] by caseq@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed follow-up to r105596, added missing test resources.

  • http/tests/inspector/resources/har-pages-iframe.html: Added.
  • http/tests/inspector/resources/har-pages-navigation-target.html: Added.
02:05 Changeset [105601] by mario@webkit.org
  • 2 edits in trunk/Tools

[GTK] run-gtk-tests randomly fails while running the xprop comand
https://bugs.webkit.org/show_bug.cgi?id=76817

Reviewed by Philippe Normand.

Temporarily comment the lines related to launching the ATSPI bus
and registry daemon, which are making the bots to fail randomly.

  • Scripts/run-gtk-tests:

(TestRunner): Skip TestWebKitAccessibility, as it won't run
properly if the ATSPI infrastructure is not properly initialized.
(TestRunner.run): Comment lines related to initialization of ATSPI.

02:04 Changeset [105600] by pfeldman@chromium.org
  • 18 edits in trunk/Source

Web Inspector: PageAgent.open() dosen't belong to the protocol.
https://bugs.webkit.org/show_bug.cgi?id=74790

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/Inspector.json:
  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::openInNewTab):

  • inspector/InspectorFrontendClientLocal.h:
  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::openInNewTab):

  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::navigate):

  • inspector/InspectorPageAgent.h:
  • inspector/front-end/ImageView.js:

(WebInspector.ImageView.prototype._openInNewTab):

  • inspector/front-end/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.openInNewTab):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkDataGridNode.prototype._openInNewTab):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameResourceTreeElement.prototype.ondblclick):

  • inspector/front-end/inspector.js:

(WebInspector.openResource):

Source/WebKit/chromium:

  • public/WebDevToolsFrontendClient.h:

(WebKit::WebDevToolsFrontendClient::openInNewTab):

  • src/InspectorFrontendClientImpl.cpp:

(WebKit::InspectorFrontendClientImpl::openInNewTab):
(WebKit::InspectorFrontendClientImpl::saveAs):

  • src/InspectorFrontendClientImpl.h:
01:59 Changeset [105599] by philn@webkit.org
  • 9 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r101742.

  • platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/gtk/fast/forms/placeholder-position-expected.txt:
  • platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/search-styled-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.txt:
01:23 Changeset [105598] by loislo@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: DetailedHeapSnapshot: Replace the list of retainers with the expandable tree (to get rid of cycles)
https://bugs.webkit.org/show_bug.cgi?id=76813

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotObjectNode):

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.HeapSnapshotContainmentDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotRetainmentDataGrid):
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype.reset):
(WebInspector.DetailedHeapshotView.prototype._startRetainersHeaderDragging):

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype.createRetainingEdgesProvider):
(WebInspector.HeapSnapshotEdgesProvider):

  • inspector/front-end/HeapSnapshotProxy.js:

(WebInspector.HeapSnapshotProxy.prototype.createEdgesProvider):
(WebInspector.HeapSnapshotProxy.prototype.createRetainingEdgesProvider):

01:13 Changeset [105597] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK gardening, marked 2 tests as flaky on Debug and
unskipped another needing new baselines.

  • platform/gtk/test_expectations.txt:
01:02 Changeset [105596] by caseq@chromium.org
  • 9 edits
    2 adds in trunk

Web Inspector: HAR pageref attributes are wrong and inconsistent with pages array
https://bugs.webkit.org/show_bug.cgi?id=76398

Reviewed by Pavel Feldman.

Source/WebCore:

  • introduce a notion of LoadPage;
  • move page load times to LoadPage;
  • associate network resources with LoadPage;
  • export pages for all available resoruces to HAR, not just the last page;
  • use page ids, not document URLs in HAR entries to refer to pages;
  • use page URL as a title field of a HAR page;
  • inspector/front-end/AuditsPanel.js:

(WebInspector.AuditsPanel):

  • inspector/front-end/HAREntry.js:

(WebInspector.HAREntry.prototype.build):
(WebInspector.HAREntry.prototype.get responseCompression):
(WebInspector.HARLog.prototype._buildPages):
(WebInspector.HARLog.prototype._convertPage):
(WebInspector.HARLog.prototype._pageEventTime):

  • inspector/front-end/NetworkLog.js:

(WebInspector.NetworkLog):
(WebInspector.NetworkLog.prototype._mainFrameNavigated):
(WebInspector.NetworkLog.prototype._onResourceStarted):
(WebInspector.Page):
(WebInspector.Page.prototype.get id):
(WebInspector.Page.prototype.get url):
(WebInspector.Page.prototype.get contentLoadTime):
(WebInspector.Page.prototype.set contentLoadTime):
(WebInspector.Page.prototype.get loadTime):
(WebInspector.Page.prototype.set loadTime):
(WebInspector.Page.prototype.get startTime):
(WebInspector.Page.prototype._bindResource):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkDispatcher.prototype.requestServedFromMemoryCache):

  • inspector/front-end/Resource.js:

(WebInspector.Resource.prototype.get page):
(WebInspector.Resource.prototype.set page):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeFrame):
(WebInspector.ResourceTreeFrame.prototype.get page):
(WebInspector.PageDispatcher.prototype.domContentEventFired):
(WebInspector.PageDispatcher.prototype.loadEventFired):

LayoutTests:

  • http/tests/inspector/resource-har-headers-expected.txt:
  • http/tests/inspector/resource-parameters-expected.txt:
  • platform/chromium/http/tests/inspector/resource-har-conversion-expected.txt:
00:58 Changeset [105595] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK gardening, marked a test as flaky and unskipped
several needing new baselines.

  • platform/gtk/test_expectations.txt:

01/22/12:

23:08 Changeset [105594] by caseq@chromium.org
  • 1 edit in branches/chromium/963/Source/WebCore/inspector/front-end/JavaScriptSourceFrame.js

Merge 105261 - Web Inspector: Popover does not disappear, causes debugger failure.
https://bugs.webkit.org/show_bug.cgi?id=71363

Reviewed by Pavel Feldman.

This is a work-around simple enough for a merge. The real fix would
be to get TextViewer to manage the highlight on its own, so it's not
accidently removed while re-building DOM for the text chunk.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype._onHidePopover):

TBR=pfeldman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9279002

21:36 Changeset [105593] by bashi@chromium.org
  • 1 edit in branches/chromium/963/Source/WebCore/platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp

Merge 105393 - [Chromium] Random characters got rendered as empty boxes or with incorrect glyphs even when a font is present
https://bugs.webkit.org/show_bug.cgi?id=76508

Patch by Kazuhiro Inaba <kinaba@chromium.org> on 2012-01-19
Reviewed by Kent Tamura.

Wrapped GetGlyphIndices() API calls so that when they failed we trigger font
loading outside the sandbox and retry the call.

No new auto tests since the bug involves the system's occasional cache behavior
and thus there's no reliable way to reproduce and test the situation.

  • platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:

(WebCore::getGlyphIndices):
GDI call wrapper ensuring fonts to be loaded.
(WebCore::initSpaceGlyph):
Changed to use the wrapper function.
(WebCore::fillBMPGlyphs):
Changed to use the wrapper function.
Introduced scoped HDC management by HWndDC.
(WebCore::GlyphPage::fill):

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9280004

18:13 Changeset [105592] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Windows python test build fix.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner.init):

11:51 Changeset [105591] by zimmermann@webkit.org
  • 2 edits in trunk/LayoutTests

2012-01-22 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix typo, which makes the style bot warn on every patch.

  • platform/chromium/test_expectations.txt:
11:29 Changeset [105590] by mario@webkit.org
  • 7 edits in trunk/Source

[GTK] ATK text-caret-moved and text-selection-changed events not being emitted
https://bugs.webkit.org/show_bug.cgi?id=76069

Reviewed by Martin Robinson.

Source/WebCore:

Fix bug introduced with patch for Bug 72830.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::isDescendantOfObject): New function,
to check if an accessibility object is a descendant of other object.
(WebCore::AccessibilityObject::isAncestorOfObject): New function,
to check if an accessibility object is an ancestor of other object.

  • accessibility/AccessibilityObject.h:
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(webkit_accessible_text_get_caret_offset): Make sure to pass the
right reference object to objectFocusedAndCaretOffsetUnignored.
(objectFocusedAndCaretOffsetUnignored): Use positionBeforeNode
instead of firstPositionInNode for calculating the begining of the
range used to calculate the offsets. Ensure that the reference
object is never a descendant of the actual object being returned.

  • editing/gtk/FrameSelectionGtk.cpp:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
Pass the right accessibility object associated with the current
selection to objectFocusedAndCaretOffsetUnignored.

Source/WebKit/gtk:

Update caret browsing related unit tests to check emissions of
'text-caret-moved' and 'text-selection-changed' signals.

  • tests/testatk.c:

(textCaretMovedCallback): New callback for 'text-caret-moved'.
(testWebkitAtkCaretOffsets): Check emissions of 'text-caret-moved'.
(textSelectionChangedCallback): New callback for 'text-selection-changed'.
(testWebkitAtkTextSelections): Check emissions of 'text-selection-changed'.

04:50 Changeset [105589] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] Unreviewed, unskipping passing test.

  • platform/gtk/Skipped: unskipped

http/tests/security/mixedContent/empty-url-plugin-in-frame.html

03:52 Changeset [105588] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] Unreviewed, unskipping test passing after r79655.

  • platform/gtk/Skipped: unskipped http/tests/incremental/slow-utf8-html.pl
02:12 Changeset [105587] by sergio@webkit.org
  • 4 edits in trunk

[GTK] DumpRenderTree converts "file:///" to a path differently
https://bugs.webkit.org/show_bug.cgi?id=76631

Reviewed by Martin Robinson.

Tools:

DumpRenderTree should print "/" as the last path component if the
path is a lone slash instead of empty output.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(webViewConsoleMessage):

LayoutTests:

Unskipped a couple of tests after fix.

  • platform/gtk/Skipped:
01:11 Changeset [105586] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Build fix for non-DFG platforms that error out on warn-unused-parameter.

  • bytecode/CallLinkStatus.cpp:

(JSC::CallLinkStatus::computeFor):

  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFor):

  • bytecode/MethodCallLinkStatus.cpp:

(JSC::MethodCallLinkStatus::computeFor):

  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFor):

00:47 Changeset [105585] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Build fix for non-DFG platforms.

  • bytecode/CallLinkStatus.cpp:

(JSC::CallLinkStatus::computeFor):

  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFor):

  • bytecode/MethodCallLinkStatus.cpp:

(JSC::MethodCallLinkStatus::computeFor):

  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFor):

Note: See TracTimeline for information about the timeline view.