Timeline


and

02/06/12:

23:25 Changeset [106909] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

Stop calling Element::ensureShadowRoot() if it is used in construction phase.
https://bugs.webkit.org/show_bug.cgi?id=77929

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-06
Reviewed by Hajime Morita.

ShadowRoot's life cycle can be consufing If Element::ensureShadowRoot() is used.
So we want to remove Element::ensureShadowRoot().
This patch replaces Element::ensureShadowRoot() if it is used in object construction phase.

No new tests, no change in behavior.

  • html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::createShadowSubtree):

  • html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::HTMLKeygenElement):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::createShadowSubtree):

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::createShadowSubtree):

  • html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::createShadowSubtree):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::createShadowSubtree):

23:22 Changeset [106908] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/efl

[EFL] Define to prevent a single backing-store application from calling the tiled view function.
https://bugs.webkit.org/show_bug.cgi?id=77842

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2012-02-06
Reviewed by Andreas Kling.

The define prevents an application using single backing store from calling tiled cache function.
The tiled APIs opened to outer should check the view type before being called.

  • ewk/ewk_private.h:
  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(ewk_view_frame_view_creation_notify):

  • ewk/ewk_view_tiled.cpp:

(ewk_view_tiled_unused_cache_get):
(ewk_view_tiled_unused_cache_set):

23:09 Changeset [106907] by commit-queue@webkit.org
  • 7 edits in trunk

Remove Element::ensureShadowRoot export.
https://bugs.webkit.org/show_bug.cgi?id=77932

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-06
Reviewed by Hajime Morita.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

Removes Element::ensureShadowRoot export.

No new tests, no change in behavior.

  • WebCore.exp.in:

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
22:33 Changeset [106906] by abarth@webkit.org
  • 5 edits in trunk/LayoutTests

http/tests/security/xssAuditor/cookie-injection.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=77908

Reviewed by Eric Seidel.

Before this patch, the output of this test depended on the state of the
global cookie store. When running tests in parallel, the cookie store
is shared by multiple tests, and so its state varies from run to run.

This patch changes this test to look only for the specific cookie used
by this test, which should make the test more reliable when run in
parallel with other tests.

  • http/tests/security/xssAuditor/cookie-injection-expected.txt:
  • http/tests/security/xssAuditor/resources/echo-intertag.pl:
  • platform/chromium/test_expectations.txt:
21:45 Changeset [106905] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed. Web Inspector: rename Artificial to Synthetic according to v8 patch r10614.

  • inspector/front-end/DetailedHeapshotGridNodes.js:
  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.get isSynthetic):
(WebInspector.HeapSnapshot.prototype._init):

21:44 Changeset [106904] by commit-queue@webkit.org
  • 17 edits in trunk/Source/WebKit/efl

[EFL] Adopt C++ style using camelCase and full variable names.
https://bugs.webkit.org/show_bug.cgi?id=76378

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2012-02-06
Reviewed by Andreas Kling.

Modify the code to use camelCase and spell out variable names instead of using abbreviations.
Modify the comments which do not match with actual parameters and correct misspelled words.
Adopt EFL Coding style in header files.
The logic of the code is not changed.

  • ewk/ewk_cookies.h:
  • ewk/ewk_frame.cpp:

(ewk_frame_selection_get):
(ewk_frame_feed_focus_in):
(EWKPrivate::coreFrame):

  • ewk/ewk_frame.h:
  • ewk/ewk_history.cpp:

(ewk_history_item_new):
(ewk_history_item_title_get):
(ewk_history_item_title_alternate_get):
(ewk_history_item_uri_get):
(ewk_history_item_uri_original_get):

  • ewk/ewk_network.h:
  • ewk/ewk_tiled_backing_store.cpp:

(_Ewk_Tiled_Backing_Store_Item):
(_Ewk_Tiled_Backing_Store_Data):
(_ewk_tiled_backing_store_tile_associate):
(_ewk_tiled_backing_store_tile_dissociate):
(_ewk_tiled_backing_store_pre_render_request_clear):
(_ewk_tiled_backing_store_pre_render_request_process_single):
(_ewk_tiled_backing_store_item_fill):
(_ewk_tiled_backing_store_item_add):
(_ewk_tiled_backing_store_item_smooth_scale_set):
(_ewk_tiled_backing_store_view_cols_end_add):
(_ewk_tiled_backing_store_view_rows_all_del):
(_ewk_tiled_backing_store_render):
(_ewk_tiled_backing_store_mem_dbg):
(_ewk_tiled_backing_store_sig_usr):
(_ewk_tiled_backing_store_smart_add):
(_ewk_tiled_backing_store_smart_del):
(_ewk_tiled_backing_store_smart_move):
(_ewk_tiled_backing_store_smart_resize):
(_ewk_tiled_backing_store_recalc_renderers):
(_ewk_tiled_backing_store_view_dbg):
(_ewk_tiled_backing_store_view_wrap_up):
(_ewk_tiled_backing_store_view_wrap_down):
(_ewk_tiled_backing_store_view_wrap_left):
(_ewk_tiled_backing_store_view_refill):
(_ewk_tiled_backing_store_view_pos_apply):
(_ewk_tiled_backing_store_smart_calculate_offset_force):
(_ewk_tiled_backing_store_smart_calculate_offset):
(_ewk_tiled_backing_store_smart_calculate_pos):
(_ewk_tiled_backing_store_smart_calculate):
(_ewk_tiled_backing_store_scroll_full_offset_set_internal):
(ewk_tiled_backing_store_scroll_full_offset_set):
(ewk_tiled_backing_store_scroll_full_offset_add):
(_ewk_tiled_backing_store_zoom_set_internal):
(ewk_tiled_backing_store_zoom_set):
(ewk_tiled_backing_store_zoom_weak_set):
(ewk_tiled_backing_store_fix_offsets):
(ewk_tiled_backing_store_flush):
(ewk_tiled_backing_store_pre_render_region):
(ewk_tiled_backing_store_pre_render_relative_radius):

  • ewk/ewk_tiled_backing_store.h:

(_Ewk_Tile):

  • ewk/ewk_tiled_matrix.cpp:

(_Ewk_Tile_Matrix):
(_ewk_tile_matrix_cell_free):
(_ewk_tile_matrix_tile_free):
(ewk_tile_matrix_new):
(ewk_tile_matrix_free):
(ewk_tile_matrix_unused_cache_get):
(ewk_tile_matrix_tile_exact_get):
(ewk_tile_matrix_tile_new):
(ewk_tile_matrix_tile_put):
(ewk_tile_matrix_dbg):
(ewk_tile_matrix_freeze):
(ewk_tile_matrix_thaw):

  • ewk/ewk_tiled_matrix.h:
  • ewk/ewk_tiled_model.cpp:

(tile_account):
(ewk_tile_updates_process):
(ewk_tile_unused_cache_tile_put):
(ewk_tile_unused_cache_dbg):

  • ewk/ewk_tiled_model.h:
  • ewk/ewk_util.h:
  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_smart_focus_in):
(_ewk_view_smart_pre_render_region):
(ewk_view_pre_render_region):
(ewk_view_toolbars_visible_get):
(ewk_view_statusbar_visible_get):
(ewk_view_scrollbars_visible_get):
(ewk_view_menubar_visible_get):
(ewk_view_zoom_range_set):

  • ewk/ewk_view.h:
  • ewk/ewk_view_single.cpp:

(_ewk_view_single_smart_repaints_process):

  • ewk/ewk_view_tiled.cpp:

(_ewk_view_tiled_smart_backing_store_add):
(_ewk_view_tiled_smart_add):
(ewk_view_tiled_unused_cache_get):
(ewk_view_tiled_unused_cache_set):

21:09 Changeset [106903] by leo.yang@torchmobile.com.cn
  • 3 edits in trunk/Source/WebKit

[BlackBerry] Use WebPagePrivate instead of WebPage in GeolocationControllerClientBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=77927

Reviewed by Antonio Gomes.

WebKit/blackberry/Api/WebPage which has a d pointer is designed for public API.
GeolocationControllerClientBlackBerry in WebKit/blackberry/WebCoreSupport should
use the d pointer directly because the client is internal implementation.

No functionalities changed, no new tests.

  • blackberry/WebCoreSupport/GeolocationControllerClientBlackBerry.cpp:

(GeolocationControllerClientBlackBerry::GeolocationControllerClientBlackBerry):
(GeolocationControllerClientBlackBerry::requestPermission):
(GeolocationControllerClientBlackBerry::cancelPermissionRequest):
(GeolocationControllerClientBlackBerry::onLocationUpdate):
(GeolocationControllerClientBlackBerry::onLocationError):

  • blackberry/WebCoreSupport/GeolocationControllerClientBlackBerry.h:

(WebKit):
(GeolocationControllerClientBlackBerry):

20:47 Changeset [106902] by hayato@chromium.org
  • 5 edits in trunk

Implement querySelector on ShadowRoot.
https://bugs.webkit.org/show_bug.cgi?id=77714

Reviewed by Dimitri Glazkov.

Source/WebCore:

  • dom/SelectorQuery.cpp:

(WebCore::nodeIsRootNodeOfTreeScope):
(WebCore):
(WebCore::SelectorDataList::execute):

LayoutTests:

  • fast/dom/shadow/shadow-root-js-api-expected.txt:
  • fast/dom/shadow/shadow-root-js-api.html:
20:41 Changeset [106901] by mrobinson@webkit.org
  • 24 edits
    3 adds
    2 deletes in trunk

[GTK] Add TextureMapperGL implementation
https://bugs.webkit.org/show_bug.cgi?id=75308

.:

Patch by Martin Robinson <mrobinson@igalia.com> and Nayan Kumar K <nayankk@motorola.com> on 2012-02-06
Reviewed by Alejandro G. Castro.

  • GNUmakefile.am: TextureMapperGL implies USE(TEXTURE_MAPPER)
  • configure.ac: Only allow enabling the GL version of TextureMapper on X11.

Source/WebCore:

Patch by Martin Robinson <mrobinson@igalia.com> and Nayan Kumar K <nayankk@motorola.com> on 2012-02-06
Reviewed by Alejandro G. Castro.

No new tests. This will be covered by accelerated compositing and
3D CSS transform tests eventually.

  • GNUmakefile.list.am: Added some files necessary to build TextureMapperGL.
  • platform/graphics/cairo/TextureMapperGLCairo.cpp: Added implementations.
  • platform/graphics/cairo/TextureMapperGLCairo.h: Updated member list.
  • platform/graphics/gtk/WindowGLContext.h: Added.
  • platform/graphics/gtk/WindowGLContextGLX.cpp: Added.
  • platform/graphics/opengl/TextureMapperGL.cpp: Use the GL shims on GTK.

Source/WebKit/gtk:

Patch by Martin Robinson <mrobinson@igalia.com> and Nayan Kumar K <nayankk@motorola.com> on 2012-02-06
Reviewed by Alejandro G. Castro.

  • GNUmakefile.am: Add AcceleratedCompositingContextGL to the list.
  • WebCoreSupport/AcceleratedCompositingContext.h:

(AcceleratedCompositingContext): Added some members for AcceleratedCompositingContextGL.

  • WebCoreSupport/AcceleratedCompositingContextClutter.cpp: Added empty implementations

for GraphicsLayerClient. This is only used for the GL variant.

  • WebCoreSupport/AcceleratedCompositingContextGL.cpp: Added.
  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::performAllPendingScrolls): Update the root layer while scrolling.
(WebKit::ChromeClient::paint): Update the root layer after painting.

  • webkit/webkitwebsettings.cpp: Added an enable-accelerated-compositing setting.
  • webkit/webkitwebsettingsprivate.h: Ditto.
  • webkit/webkitwebview.cpp:

(webkit_web_view_draw): Call into TextureMapper now.
(webkit_web_view_realize): Use gdk_window_ensure_native here.
(webkit_web_view_update_settings): Support the new enable-accelerated-compositing setting.
(webkit_web_view_settings_notify): Ditto.

Source/WebKit2:

Reviewed by Alejandro G. Castro.

Fix the WebKit2 + AC build for GTK+.

  • GNUmakefile.am: Add some missing source files.
  • UIProcess/DrawingAreaProxy.cpp:

(WebKit): Add USE(TILED_BACKING_STORE) to the guard.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage): Ditto.

  • WebProcess/WebPage/DrawingArea.h:

(DrawingArea): Ditto.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit): Ditto.

  • WebProcess/WebPage/DrawingAreaImpl.h:

(DrawingAreaImpl): Ditto.

20:26 Changeset [106900] by eae@chromium.org
  • 22 edits in trunk/Source/WebCore

Change baselinePosition and lineHeight to LayoutUnit
https://bugs.webkit.org/show_bug.cgi?id=77905

Reviewed by Eric Seidel.

Change the virtual baselinePosition and lineHeight methods to return
LayoutUnits as they are both computed from the height and top/bottom
margins (or width and left/right margins for vertical text), all of
which are LayoutUnits.

No new tests.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::baselinePosition):

  • platform/efl/RenderThemeEfl.h:

(RenderThemeEfl):

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::baselinePosition):

  • platform/gtk/RenderThemeGtk.h:

(RenderThemeGtk):

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::baselinePosition):

  • platform/qt/RenderThemeQt.h:

(RenderThemeQt):

  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::lineHeight):
(WebCore::RenderListMarker::baselinePosition):

  • rendering/RenderListMarker.h:

(RenderListMarker):

  • rendering/RenderSlider.cpp:

(WebCore::RenderSlider::baselinePosition):

  • rendering/RenderSlider.h:

(RenderSlider):

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::baselinePosition):
(WebCore::RootInlineBox::lineHeight):

  • rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::baselinePosition):

  • rendering/mathml/RenderMathMLFraction.h:

(RenderMathMLFraction):

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::baselinePosition):

  • rendering/mathml/RenderMathMLOperator.h:

(RenderMathMLOperator):

  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::baselinePosition):

  • rendering/mathml/RenderMathMLRow.h:

(RenderMathMLRow):

  • rendering/mathml/RenderMathMLSubSup.cpp:

(WebCore::RenderMathMLSubSup::baselinePosition):

  • rendering/mathml/RenderMathMLSubSup.h:

(RenderMathMLSubSup):

  • rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore::RenderMathMLUnderOver::baselinePosition):

  • rendering/mathml/RenderMathMLUnderOver.h:

(RenderMathMLUnderOver):

20:16 Changeset [106899] by wangxianzhu@chromium.org
  • 7 edits in trunk/Source/WebCore

Avoid Page::updateViewportArguments() if the causing frame is not the main frame
https://bugs.webkit.org/show_bug.cgi?id=77387

Reviewed by Kenneth Rohde Christiansen.

  • dom/Document.cpp:

(WebCore::Document::processViewport):
(WebCore::Document::updateViewportArguments):
(WebCore::Document::setInPageCache):

  • dom/Document.h:

(Document):

  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::insertedIntoDocument):

  • page/Frame.cpp:

(WebCore::Frame::setDocument):

  • page/Page.cpp:

(WebCore::Page::viewportArguments):
(WebCore):

  • page/Page.h:

(Page):

20:05 Changeset [106898] by dgrogan@chromium.org
  • 49 edits
    2 deletes in trunk/LayoutTests

js-test-pre.js: relay calls to testPassed, testFailed, debug, etc from
worker to document.
https://bugs.webkit.org/show_bug.cgi?id=76762

Reviewed by Ojan Vafai.

  • fast/filesystem/resources/async-operations.js:
  • fast/filesystem/resources/directory-entry-to-uri.js:
  • fast/filesystem/resources/file-entry-to-uri-sync.js:
  • fast/filesystem/resources/file-entry-to-uri.js:
  • fast/filesystem/resources/file-from-file-entry-sync.js:
  • fast/filesystem/resources/file-from-file-entry.js:
  • fast/filesystem/resources/file-writer-abort-continue.js:
  • fast/filesystem/resources/file-writer-abort-depth.js:
  • fast/filesystem/resources/file-writer-abort.js:
  • fast/filesystem/resources/file-writer-events.js:
  • fast/filesystem/resources/file-writer-gc-blob.js:
  • fast/filesystem/resources/file-writer-sync-truncate-extend.js:
  • fast/filesystem/resources/file-writer-sync-write-overlapped.js:
  • fast/filesystem/resources/file-writer-truncate-extend.js:
  • fast/filesystem/resources/file-writer-write-overlapped.js:
  • fast/filesystem/resources/fs-worker-common.js:
  • fast/filesystem/resources/fs-worker-test-util.js: Removed.
  • fast/filesystem/resources/simple-persistent-sync.js:
  • fast/filesystem/resources/simple-persistent.js:
  • fast/filesystem/resources/simple-readonly.js:
  • fast/filesystem/resources/simple-required-arguments-getdirectory.js:
  • fast/filesystem/resources/simple-required-arguments-getfile.js:
  • fast/filesystem/resources/simple-required-arguments-getmetadata.js:
  • fast/filesystem/resources/simple-required-arguments-remove.js:
  • fast/filesystem/resources/simple-temporary-sync.js:
  • fast/filesystem/resources/simple-temporary.js:
  • fast/filesystem/resources/sync-operations.js:
  • fast/filesystem/workers/async-operations.html:
  • fast/filesystem/workers/file-entry-to-uri-sync.html:
  • fast/filesystem/workers/file-from-file-entry-sync.html:
  • fast/filesystem/workers/file-from-file-entry.html:
  • fast/filesystem/workers/file-writer-events.html:
  • fast/filesystem/workers/file-writer-gc-blob.html:
  • fast/filesystem/workers/file-writer-sync-truncate-extend.html:
  • fast/filesystem/workers/file-writer-sync-write-overlapped.html:
  • fast/filesystem/workers/file-writer-truncate-extend.html:
  • fast/filesystem/workers/file-writer-write-overlapped.html:
  • fast/filesystem/workers/simple-persistent-sync.html:
  • fast/filesystem/workers/simple-persistent.html:
  • fast/filesystem/workers/simple-temporary-sync.html:
  • fast/filesystem/workers/simple-temporary.html:
  • fast/filesystem/workers/sync-operations.html:
  • fast/js/resources/js-test-pre.js:

(testPassed):
(testFailed):
(finishJSTest):
(startWorker.worker.onmessage):
(startWorker.worker.onerror):
(startWorker):

  • storage/indexeddb/basics-workers.html:
  • storage/indexeddb/resources/basics.js:
20:01 Changeset [106897] by jchaffraix@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium-mac-snowleopard/fast/canvas/check-stale-putImageData-expected.png: Added.

Yet another font difference.

  • platform/chromium/test_expectations.txt: Added LEOPARD to the list of flaky platforms.
19:52 Changeset [106896] by abarth@webkit.org
  • 5 edits in trunk/LayoutTests

http/tests/security/mixedContent/insecure-script-in-iframe.html flaky in chromium debug
https://bugs.webkit.org/show_bug.cgi?id=65567

Reviewed by Eric Seidel.

My theory is that the extra log message is caused by the preload
scanner requesting the script, which might occur if the test is running
extremely slowly (as it might on a debug bot).

This patch simplifies the test in the hopes of removing the flakiness.

  • http/tests/security/mixedContent/insecure-script-in-iframe-expected.txt:
  • http/tests/security/mixedContent/insecure-script-in-iframe.html:
  • http/tests/security/mixedContent/resources/frame-with-insecure-script.html:
  • platform/chromium/test_expectations.txt:
19:20 Changeset [106895] by mrobinson@webkit.org
  • 6 edits in trunk

Fix some miscellaneous 'make dist' error for WebKitGTK+.

Source/WebCore:

  • GNUmakefile.list.am: Add some missing Shadow DOM files to the

source list.

Source/WebKit2:

  • GNUmakefile.am: Do not distribute generated files.

Tools:

  • MiniBrowser/gtk/GNUmakefile.am: The MiniBrowser generated

files should not be distributed.

19:11 Changeset [106894] by abarth@webkit.org
  • 5 edits in trunk/LayoutTests

http/tests/security/mixedContent/insecure-image-in-main-frame.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=77904

Reviewed by Darin Adler.

My theory is that the extra log message is caused by the preload
scanner requesting the image, which might occur if the test is running
extremely slowly (as it might on a debug bot).

This patch simplifies the test in the hopes of removing the flakiness.

  • http/tests/security/mixedContent/insecure-image-in-main-frame-expected.txt:
  • http/tests/security/mixedContent/insecure-image-in-main-frame.html:
  • http/tests/security/mixedContent/resources/frame-with-insecure-image.html:
  • platform/chromium/test_expectations.txt:
18:55 Changeset [106893] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Add contains() test to Region
https://bugs.webkit.org/show_bug.cgi?id=72294

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-06
Reviewed by Anders Carlsson.

  • platform/graphics/Region.cpp:

(WebCore::Region::contains):
(WebCore):

  • platform/graphics/Region.h:

(Region):
(Shape):
(WebCore::operator==):
(WebCore):

18:43 Changeset [106892] by haraken@chromium.org
  • 54 edits in trunk/Source/WebCore

Rename [DontCheckEnums], [ReturnsNew], [DoNotCheckDomainSecurityOnGet],
[DoNotCheckDomainSecurityOnSet] and [ImplementationFunction] IDLs
https://bugs.webkit.org/show_bug.cgi?id=77852

Reviewed by Adam Barth.

This patch renames [DontCheckEnums], [ReturnsNew], [DoNotCheckDomainSecurityOnGet],
[DoNotCheckDomainSecurityOnSet] and [ImplementationFunction] IDLs for clarification.

[DontCheckEnums] => [DoNotCheckConstants] (This IDL inserts assertions to check if a
constant value is equal to the expected constant value)
[ReturnsNew] => [ReturnNewObject] (For clarification)
[DoNotCheckDomainSecurityOnGet] => [DoNotCheckDomainSecurityOnGetter] (For naming consistency
with other [*Getter] IDLs)
[DoNotCheckDomainSecurityOnSet] => [DoNotCheckDomainSecurityOnSetter] (For naming consistency
with other [*Setter] IDLs)
[ImplementationFunction=] => [ImplementedAs=] (For clarification. This IDL specifies a method
name in implementation)

No tests. No change in behavior.

  • bindings/scripts/CodeGenerator.pm:

(ShouldCheckEnums):
(GenerateCompileTimeCheckForEnumsIfNeeded):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
(NativeToJSValue):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateSingleBatchedAttribute):
(GenerateFunctionCallString):
(NativeToJSValue):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/TestTypedArray.idl:
  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

  • css/WebKitCSSFilterValue.idl:
  • css/WebKitCSSTransformValue.idl:
  • dom/DOMCoreException.idl:
  • dom/Document.idl:
  • dom/EventException.idl:
  • dom/RangeException.idl:
  • fileapi/FileException.idl:
  • fileapi/OperationNotAllowedException.idl:
  • html/HTMLFormElement.idl:
  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/OESStandardDerivatives.idl:
  • html/canvas/OESVertexArrayObject.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • html/canvas/Uint8ClampedArray.idl:
  • html/canvas/WebGLCompressedTextures.idl:
  • html/canvas/WebGLDebugRendererInfo.idl:
  • html/canvas/WebGLRenderingContext.idl:
  • inspector/JavaScriptCallFrame.idl:
  • loader/appcache/DOMApplicationCache.idl:
  • page/Console.idl:
  • page/DOMWindow.idl:
  • page/Location.idl:
  • storage/IDBCursor.idl:
  • storage/IDBDatabaseException.idl:
  • storage/IDBObjectStore.idl:
  • storage/SQLException.idl:
  • svg/SVGComponentTransferFunctionElement.idl:
  • svg/SVGException.idl:
  • svg/SVGFEBlendElement.idl:
  • svg/SVGFEColorMatrixElement.idl:
  • svg/SVGFECompositeElement.idl:
  • svg/SVGFEConvolveMatrixElement.idl:
  • svg/SVGFEDisplacementMapElement.idl:
  • svg/SVGFEMorphologyElement.idl:
  • svg/SVGFETurbulenceElement.idl:
  • svg/SVGGradientElement.idl:
  • xml/XMLHttpRequestException.idl:
  • xml/XPathException.idl:
18:24 Changeset [106891] by jamesr@google.com
  • 14 edits in trunk/Source

[chromium] canvas demo is slow due to unnecessary resource cleanups
https://bugs.webkit.org/show_bug.cgi?id=77135

Reviewed by Kenneth Russell.

Source/WebCore:

This defers dropping a ManagedTexture until it is evicted by the manager, the layer is destroyed, the
TextureManager is destroyed, or the layer is added to a CCLayerTreeHost that has a different texture manager. In
particular, removing a layer from a CCLayerTreeHost and then adding it back to the same host does not drop any
ManagedTextures unless the manager has to evict it for other reasons. This provides a big speedup on sites that
rebuild the compositing tree frequently.

New unit test added for ManagedTexture / TextureManager interaction.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::setLayerTreeHost):
(WebCore::Canvas2DLayerChromium::setTextureManager):

  • platform/graphics/chromium/Canvas2DLayerChromium.h:

(Canvas2DLayerChromium):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setLayerTreeHost):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):

  • platform/graphics/chromium/ManagedTexture.cpp:

(WebCore::ManagedTexture::setTextureManager):
(WebCore):
(WebCore::ManagedTexture::steal):
(WebCore::ManagedTexture::clear):

  • platform/graphics/chromium/ManagedTexture.h:

(ManagedTexture):

  • platform/graphics/chromium/RenderSurfaceChromium.h:

(RenderSurfaceChromium):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::setLayerTreeHost):
(WebCore):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):

  • platform/graphics/chromium/TiledLayerChromium.h:

Source/WebKit/chromium:

  • tests/Canvas2DLayerChromiumTest.cpp:

(WebCore::Canvas2DLayerChromiumTest::fullLifecycleTest):

  • tests/TextureManagerTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:
18:21 Changeset [106890] by rniwa@webkit.org
  • 4 edits in trunk

Perf-o-matic should show min/max/stdev on graphs
https://bugs.webkit.org/show_bug.cgi?id=77702

Reviewed by Andreas Kling.

Include min/max/stdev in test runs when available to be shown on the perf-o-matic.

Also merge a change to config.js and increment the version number by 1 (unreviewed).

  • Websites/webkit-perf.appspot.com/app.yaml:
  • Websites/webkit-perf.appspot.com/js/config.js:
  • Websites/webkit-perf.appspot.com/runs_handler.py:

(RunsHandler.get):

18:04 Changeset [106889] by haraken@chromium.org
  • 54 edits in trunk/Source/WebCore

Unreviewed, rolling out r106883.
http://trac.webkit.org/changeset/106883
https://bugs.webkit.org/show_bug.cgi?id=77852

build failure around Chromium V8 bindings

  • bindings/scripts/CodeGenerator.pm:

(ShouldCheckEnums):
(GenerateCompileTimeCheckForEnumsIfNeeded):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
(NativeToJSValue):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateSingleBatchedAttribute):
(GenerateFunctionCallString):
(NativeToJSValue):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/TestTypedArray.idl:
  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

  • css/WebKitCSSFilterValue.idl:
  • css/WebKitCSSTransformValue.idl:
  • dom/DOMCoreException.idl:
  • dom/Document.idl:
  • dom/EventException.idl:
  • dom/RangeException.idl:
  • fileapi/FileException.idl:
  • fileapi/OperationNotAllowedException.idl:
  • html/HTMLFormElement.idl:
  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/OESStandardDerivatives.idl:
  • html/canvas/OESVertexArrayObject.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • html/canvas/Uint8ClampedArray.idl:
  • html/canvas/WebGLCompressedTextures.idl:
  • html/canvas/WebGLDebugRendererInfo.idl:
  • html/canvas/WebGLRenderingContext.idl:
  • inspector/JavaScriptCallFrame.idl:
  • loader/appcache/DOMApplicationCache.idl:
  • page/Console.idl:
  • page/DOMWindow.idl:
  • page/Location.idl:
  • storage/IDBCursor.idl:
  • storage/IDBDatabaseException.idl:
  • storage/IDBObjectStore.idl:
  • storage/SQLException.idl:
  • svg/SVGComponentTransferFunctionElement.idl:
  • svg/SVGException.idl:
  • svg/SVGFEBlendElement.idl:
  • svg/SVGFEColorMatrixElement.idl:
  • svg/SVGFECompositeElement.idl:
  • svg/SVGFEConvolveMatrixElement.idl:
  • svg/SVGFEDisplacementMapElement.idl:
  • svg/SVGFEMorphologyElement.idl:
  • svg/SVGFETurbulenceElement.idl:
  • svg/SVGGradientElement.idl:
  • xml/XMLHttpRequestException.idl:
  • xml/XPathException.idl:
17:58 Changeset [106888] by commit-queue@webkit.org
  • 3 edits in trunk

WebGL must allocate smaller drawing buffer when the allocation fails.
https://bugs.webkit.org/show_bug.cgi?id=76654

Patch by Yongsheng Zhu <yongsheng.zhu@intel.com> on 2012-02-06
Reviewed by Kenneth Russell.

Test: fast/canvas/webgl/drawingbuffer-test.html

  • platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore):
(WebCore::DrawingBuffer::create):
(WebCore::DrawingBuffer::reset):

17:42 Changeset [106887] by jchaffraix@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed gardening.

  • DEPS: Rolling the DEPS to get the apple_webkit update

and fix the Chromium build.

17:39 Changeset [106886] by dgrogan@chromium.org
  • 4 edits
    2 copies
    4 adds in trunk/LayoutTests

Port some indexeddb layout tests to workers.
https://bugs.webkit.org/show_bug.cgi?id=77805

Reviewed by Tony Chang.

  • storage/indexeddb/index-basics-workers-expected.txt: Added.
  • storage/indexeddb/index-basics-workers.html: Added.
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics-workers-expected.txt: Added.
  • storage/indexeddb/objectstore-basics-workers.html: Added.
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/resources/index-basics.js: Copied from LayoutTests/storage/indexeddb/index-basics.html.

(test):
(setVersion):
(deleteExisting):
(addData):
(addData2):
(addData3):
(getData):
(getObjectData):
(getObjectData2):
(getObjectData3):
(getDataFail):
(getObjectDataFail):
(getObjectData4):
(openKeyCursor):
(cursor1Continue):
(cursor1Continue2):
(cursor1Continue3):
(openObjectCursor):
(cursor2Continue):
(cursor2Continue2):
(cursor2Continue3):
(last.try.get testFailed):
(last):

  • storage/indexeddb/resources/objectstore-basics.js: Copied from LayoutTests/storage/indexeddb/objectstore-basics.html.

(test):
(openSuccess):
(setVersionSuccess):
(createIndex):
(testSetVersionAbort):
(createAnotherIndex):
(checkMetadata):
(addData):
(addDateSuccess):
(addSuccess):
(addAgainFailure):
(getSuccess):
(getSuccessDateKey):
(removeSuccess):
(removeSuccessButFalse):
(testPreConditions.request.onsuccess):
(testPreConditions):

17:37 Changeset [106885] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed. Rebaselined run-bindings-tests results.

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::optionsObjectCallback):

17:36 Changeset [106884] by leviw@chromium.org
  • 23 edits in trunk/Source/WebCore

Correct usage of LayoutUnits in dom, editing, page, accessibility, inspector, and loader
https://bugs.webkit.org/show_bug.cgi?id=77891

Reviewed by Darin Adler.

Updating the usage of LayoutUnits in the dom, editing, page, accessibility, inspector, and loader
directories to properly use LayoutUnits vs ints.

No new tests. No new behavior.

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::boundsForVisiblePositionRange):
(WebCore::AccessibilityObject::doAXBoundsForRange):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isOffScreen):
(WebCore::AccessibilityRenderObject::clickPoint):
(WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange):
(WebCore::AccessibilityRenderObject::doAXBoundsForRange):
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::elementAccessibilityHitTest):

  • accessibility/AccessibilitySlider.h:

(AccessibilitySlider):

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityShowContextMenu]):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::computedTransform):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • dom/Clipboard.h:

(WebCore::Clipboard::dragLocation):
(Clipboard):

  • dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::renderedRectsForMarkers):

  • dom/DocumentMarkerController.h:
  • dom/Element.cpp:

(WebCore::Element::screenRect):

  • dom/Element.h:

(Element):

  • editing/Editor.cpp:

(WebCore::Editor::rangeForPoint):
(WebCore::Editor::firstRectForRange):

  • editing/RenderedPosition.cpp:

(WebCore::RenderedPosition::absoluteRect):

  • editing/RenderedPosition.h:

(WebCore::RenderedPosition::absoluteRect):
(RenderedPosition):

  • editing/VisiblePosition.h:

(VisiblePosition):

  • inspector/DOMNodeHighlighter.cpp:
  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::createJavaAppletWidget):

  • loader/SubframeLoader.h:

(SubframeLoader):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEvent):

  • page/Frame.cpp:

(WebCore::Frame::nodeImage):

  • page/win/FrameCGWin.cpp:

(WebCore::Frame::nodeImage):

17:33 Changeset [106883] by haraken@chromium.org
  • 54 edits in trunk/Source/WebCore

Rename [DontCheckEnums], [ReturnsNew], [DoNotCheckDomainSecurityOnGet],
[DoNotCheckDomainSecurityOnSet] and [ImplementationFunction] IDLs
https://bugs.webkit.org/show_bug.cgi?id=77852

Reviewed by Adam Barth.

This patch renames [DontCheckEnums], [ReturnsNew], [DoNotCheckDomainSecurityOnGet],
[DoNotCheckDomainSecurityOnSet] and [ImplementationFunction] IDLs for clarification.

[DontCheckEnums] => [DoNotCheckConstants] (This IDL inserts assertions to check if a
constant value is equal to the expected constant value)
[ReturnsNew] => [ReturnNewObject] (For clarification)
[DoNotCheckDomainSecurityOnGet] => [DoNotCheckDomainSecurityOnGetter] (For naming consistency
with other [*Getter] IDLs)
[DoNotCheckDomainSecurityOnSet] => [DoNotCheckDomainSecurityOnSetter] (For naming consistency
with other [*Setter] IDLs)
[ImplementationFunction=] => [ImplementedAs=] (For clarification. This IDL specifies a method
name in implementation)

No tests. No change in behavior.

  • bindings/scripts/CodeGenerator.pm:

(ShouldCheckEnums):
(GenerateCompileTimeCheckForEnumsIfNeeded):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
(NativeToJSValue):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateSingleBatchedAttribute):
(GenerateFunctionCallString):
(NativeToJSValue):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/TestTypedArray.idl:
  • bindings/scripts/test/JS/JSTestInterface.cpp: Updated run-bindings-tests results.

(WebCore):

  • bindings/scripts/test/JS/JSTestObj.cpp: Ditto.

(WebCore):

  • bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.

(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp: Ditto.

(WebCore):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/TestTypedArray.idl:
  • css/WebKitCSSFilterValue.idl:
  • css/WebKitCSSTransformValue.idl:
  • dom/DOMCoreException.idl:
  • dom/Document.idl:
  • dom/EventException.idl:
  • dom/RangeException.idl:
  • fileapi/FileException.idl:
  • fileapi/OperationNotAllowedException.idl:
  • html/HTMLFormElement.idl:
  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/OESStandardDerivatives.idl:
  • html/canvas/OESVertexArrayObject.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • html/canvas/Uint8ClampedArray.idl:
  • html/canvas/WebGLCompressedTextures.idl:
  • html/canvas/WebGLDebugRendererInfo.idl:
  • html/canvas/WebGLRenderingContext.idl:
  • inspector/JavaScriptCallFrame.idl:
  • loader/appcache/DOMApplicationCache.idl:
  • page/Console.idl:
  • page/DOMWindow.idl:
  • page/Location.idl:
  • storage/IDBCursor.idl:
  • storage/IDBDatabaseException.idl:
  • storage/IDBObjectStore.idl:
  • storage/SQLException.idl:
  • svg/SVGComponentTransferFunctionElement.idl:
  • svg/SVGException.idl:
  • svg/SVGFEBlendElement.idl:
  • svg/SVGFEColorMatrixElement.idl:
  • svg/SVGFECompositeElement.idl:
  • svg/SVGFEConvolveMatrixElement.idl:
  • svg/SVGFEDisplacementMapElement.idl:
  • svg/SVGFEMorphologyElement.idl:
  • svg/SVGFETurbulenceElement.idl:
  • svg/SVGGradientElement.idl:
  • xml/XMLHttpRequestException.idl:
17:30 Changeset [106882] by commit-queue@webkit.org
  • 3 edits
    6 adds in trunk

RenderSVGShape::strokeContains will fail for some strokes
https://bugs.webkit.org/show_bug.cgi?id=76931

Patch by Stephen Chenney <schenney@chromium.org> on 2012-02-06
Reviewed by Darin Adler.

Source/WebCore:

Adding support for rounded zero-length endcaps for SVG path hit
testing.

Tests: svg/hittest/zero-length-butt-cap-path.xhtml

svg/hittest/zero-length-round-cap-path.xhtml
svg/hittest/zero-length-square-cap-path.xhtml

  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::strokeContains):

LayoutTests:

New tests for hit testing against an SVG path of zero length with
endcaps.

  • svg/hittest/zero-length-butt-cap-path-expected.txt: Added.
  • svg/hittest/zero-length-butt-cap-path.xhtml: Added.
  • svg/hittest/zero-length-round-cap-path-expected.txt: Added.
  • svg/hittest/zero-length-round-cap-path.xhtml: Added.
  • svg/hittest/zero-length-square-cap-path-expected.txt: Added.
  • svg/hittest/zero-length-square-cap-path.xhtml: Added.
17:20 WebKit Team edited by igor.oliveira@openbossa.org
(diff)
17:14 WebKitGTK/1.6.x edited by mrobinson@webkit.org
(diff)
17:09 Changeset [106881] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Add webGLErrorsToConsoleEnabled Settings flag
https://bugs.webkit.org/show_bug.cgi?id=77696

Patch by Gregg Tavares <gman@google.com> on 2012-02-06
Reviewed by Kenneth Russell.

No new tests as there is no change in behavior.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::setupFlags):

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(Settings):
(WebCore::Settings::webGLErrorsToConsoleEnabled):

17:07 Changeset [106880] by eae@chromium.org
  • 9 edits in trunk/Source

Convert PopupMenuClient::clientPadding over to new layout abstraction
https://bugs.webkit.org/show_bug.cgi?id=77798

Reviewed by Eric Seidel.

Change PopupMenuClient and all classes inheriting from it to use the new
layout types for padding.

Source/WebCore:

No new tests.

  • platform/PopupMenuClient.h:

(PopupMenuClient):

  • rendering/RenderMenuList.h:
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::clientPaddingLeft):
(WebCore::RenderTextControlSingleLine::clientPaddingRight):

  • rendering/RenderTextControlSingleLine.h:

Source/WebKit/chromium:

  • src/AutofillPopupMenuClient.cpp:

(WebKit::AutofillPopupMenuClient::clientPaddingLeft):
(WebKit::AutofillPopupMenuClient::clientPaddingRight):

  • src/AutofillPopupMenuClient.h:

(AutofillPopupMenuClient):

  • tests/PopupMenuTest.cpp:

(WebKit::TestPopupMenuClient::clientPaddingLeft):
(WebKit::TestPopupMenuClient::clientPaddingRight):

17:07 Changeset [106879] by fpizlo@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

ValueToNumber and ValueToDouble nodes don't do anything and should be removed
https://bugs.webkit.org/show_bug.cgi?id=77855
<rdar://problem/10811325>

Reviewed by Gavin Barraclough.

Removed ValueToNumber and ValueToDouble, because the only thing they were doing
was wasting registers.

This looks like a 1% win on V8 (with a 5% win on crypto) and a 2-3% win on Kraken,
mostly due to a >10% win on gaussian-blur. No win anywhere else.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getToInt32):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGNode.h:

(DFG):
(JSC::DFG::Node::hasArithNodeFlags):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::vote):
(JSC::DFG::Propagator::doRoundOfDoubleVoting):
(Propagator):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::canonicalize):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

16:55 Changeset [106878] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Fix color animations by value
https://bugs.webkit.org/show_bug.cgi?id=77812

Patch by Philip Rogers <pdr@google.com> on 2012-02-06
Reviewed by Darin Adler.

Source/WebCore:

Test: svg/animations/animate-color-fill-from-by.html

  • svg/SVGAnimatedColor.cpp:

(WebCore::SVGAnimatedColorAnimator::calculateFromAndByValues):

LayoutTests:

  • svg/animations/animate-color-fill-from-by-expected.txt: Added.
  • svg/animations/animate-color-fill-from-by.html: Added.
  • svg/animations/script-tests/animate-color-fill-from-by.js: Added.

(checkFillColor):
(sample1):
(sample2):
(sample3):
(executeTest):

16:53 Changeset [106877] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

Do not try to chdir to the directory where the executable is in
only if the path is absolute. This makes tests runnable from
anywhere.

Reviewed by Martin Robinson.

  • tests/test_utils.c:

(testutils_relative_chdir):

16:52 Changeset [106876] by jer.noble@apple.com
  • 4 edits
    2 adds in trunk

REGRESSION (r104303): Clicking inline video controls gives the video a focus ring
https://bugs.webkit.org/show_bug.cgi?id=77288

Reviewed by Darin Adler.

Source/WebCore:

Test: media/video-mouse-focus.html

Do not allow media elements to be focused by mouse click by overriding isMouseFocusable
and returning false.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::isMouseFocusable):

  • html/HTMLMediaElement.h:

LayoutTests:

  • media/video-mouse-focus-expected.txt: Added.
  • media/video-mouse-focus.html: Added.
16:43 Changeset [106875] by andersca@apple.com
  • 10 edits in trunk/Source

Source/WebCore: Overlay scrollbars flash when window is simply activated
https://bugs.webkit.org/show_bug.cgi?id=77911
<rdar://problem/10211995>

Reviewed by Kenneth Russell.

Add a new member function, FocusController::setContainingWindowIsVisible, and move the code
that calls ScrollableArea::contentAreaDidShow/ScrollableArea::contentAreaDidHide there, since
we only want to flash scrollers when the window becomes visible.

  • WebCore.exp.in:
  • page/FocusController.cpp:

(WebCore::FocusController::FocusController):
(WebCore::FocusController::setActive):
(WebCore::FocusController::setContainingWindowIsVisible):
(WebCore):

  • page/FocusController.h:

(FocusController):
(WebCore::FocusController::containingWindowIsVisible):

  • platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollbarPainterControllerDelegate scrollerImpPair:setContentAreaNeedsDisplayInRect:]):
Call ScrollAnimatorMac::contentAreaWillPaint here, since that will trigger AppKit to flash the scrollers.

Source/WebKit/mac: Overlay scrollbars flash when window is simply activated
https://bugs.webkit.org/show_bug.cgi?id=77911
<rdar://problem/10211995>

Reviewed by Kenneth Russell.

  • WebView/WebView.mm:

(-[WebView _windowWillOrderOnScreen:]):
(-[WebView _windowWillOrderOffScreen:]):
Call FocusController::setContainingWindowIsVisible.

Source/WebKit2: Overlay scrollbars flash when window is simply activated
https://bugs.webkit.org/show_bug.cgi?id=77911

Reviewed by Kenneth Russell.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _updateWindowVisibility]):
Use -[NSWindow isVisible] here, since we also want to consider the window hidden if the application itself is hidden.

(-[WKView _windowDidOrderOffScreen:]):
(-[WKView _windowDidOrderOnScreen:]):
Call -[WKView updateWindowVisibility].

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setWindowIsVisible):
Call FocusController::setContainingWindowIsVisible.

16:41 Changeset [106874] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

postMessage leaks MemoryEvent object
https://bugs.webkit.org/show_bug.cgi?id=77893

Patch by Greg Simon <gregsimon@chromium.org> on 2012-02-06
Reviewed by Adam Barth.

Changed from PassRefPtr().leakRef() to RefPtr.get() when
calling into FrameLoaderClient to stop +1 extra ref.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessageTimerFired):

16:38 Changeset [106873] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

WebGL conformance test misc/functions-returning-strings.html fails
https://bugs.webkit.org/show_bug.cgi?id=77149

Source/WebCore:

Make sure that WebGL methods returning strings don't return null when
they run successfully.

Patch by Ehsan Akhgari <ehsan.akhgari@gmail.com> on 2012-02-06
Reviewed by Kenneth Russell.

Test: fast/canvas/webgl/functions-returning-strings.html

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::getProgramInfoLog):
(WebCore::WebGLRenderingContext::getShaderInfoLog):
(WebCore::WebGLRenderingContext::getShaderSource):
(WebCore::WebGLRenderingContext::ensureNotNull):

  • html/canvas/WebGLRenderingContext.h:

(WebGLRenderingContext):

LayoutTests:

Imported the WebGL conformance test related to this.

Patch by Ehsan Akhgari <ehsan.akhgari@gmail.com> on 2012-02-06
Reviewed by Kenneth Russell.

  • fast/canvas/webgl/functions-returning-strings-expected.txt: Added.
  • fast/canvas/webgl/functions-returning-strings.html: Added.
16:34 Changeset [106872] by enrica@apple.com
  • 5 edits in trunk/Source/WebCore

Refactor Mac platform implementation of the Pasteboard class.
https://bugs.webkit.org/show_bug.cgi?id=77567

The goal of this change is to remove the majority of the methods in
the class interface that are Mac specific.
writeSelectionForTypes has been left to support OS X services.
Some of the methods have been turned into static functions.
The method asURL was being used only by the DragData class and its
implementation has been moved there.
This is a first step in the direction of removing NSPasteboard access from
the WebProcess for WebKit2 (https://bugs.webkit.org/show_bug.cgi?id=77259)
leaving the WebKit1 behavior unchanged.

Reviewed by Alexey Proskuryakov.

No new tests. No changes in behavior.

  • platform/Pasteboard.h: Removed most of the Mac specific methods.
  • platform/mac/ClipboardMac.mm:

(WebCore::ClipboardMac::writeRange):
(WebCore::ClipboardMac::writeURL):

  • platform/mac/DragDataMac.mm:

(WebCore::DragData::asURL): Moved code from PasteboardMac.mm. Removed FIXME
because we only want to handle the case of single file, otherwise the user
doesn't know which of the files has been chosen.

  • platform/mac/PasteboardMac.mm:

(WebCore::writeURLForTypes):
(WebCore::Pasteboard::writeURL):
(WebCore::writeFileWrapperAsRTFDAttachment): Now a static function.
(WebCore::Pasteboard::writeImage):
(WebCore::documentFragmentWithImageResource): Ditto.
(WebCore::documentFragmentWithRTF): Ditto.
(WebCore::Pasteboard::documentFragment):

16:30 Changeset [106871] by crogers@google.com
  • 2 edits in branches/chromium/1025

Merge 106864 - zvmul incorrectly multiplies complex arrays on Windows.
https://bugs.webkit.org/show_bug.cgi?id=77900

TBR=crogers@google.com
Review URL: https://chromiumcodereview.appspot.com/9350003

16:25 Changeset [106870] by jamesr@google.com
  • 5 edits in trunk/Source

[chromium] Drop tiles completely outside of layer bounds when resizing to a smaller size
https://bugs.webkit.org/show_bug.cgi?id=77910

Reviewed by Kenneth Russell.

Source/WebCore:

When resizing a tiled layer to a smaller size, drop all tiles that lie completely outside the new layer bounds.
This avoids attempting to access out-of-bounds tiles when iterating over all tiles in the tiler, which triggers
ASSERT()s, as well as saves some memory.

New unit test added to TiledLayerChromiumTest.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::invalidateRect):

  • platform/graphics/chromium/cc/CCLayerTilingData.cpp:

(WebCore::CCLayerTilingData::setBounds):

Source/WebKit/chromium:

Adds test for resizing a layer to cover fewer tiles. Test hits ASSERT()s without any code changes.

  • tests/TiledLayerChromiumTest.cpp:

(::TEST):

16:14 Changeset [106869] by leviw@chromium.org
  • 2 edits in branches/subpixellayout/Source/WebCore/rendering

Reverting RenderFrameSet's canResizeRow/Column to operate on IntPoints.

16:09 Changeset [106868] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderFrameSet.cpp

Call intValue on grid lengths instead of explicitly operating on floats when we only use integer precision for FrameSets.

16:08 Changeset [106867] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Revert r106859. It was completely bogus.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::doPixelReadbackToCanvas):

16:00 Changeset [106866] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderFrameSet.cpp

Fix pixel snapping logic for FrameSets. This is for code correctness, but would never actually lead to incorrect renderings.

15:44 Changeset [106865] by morrita@google.com
  • 18 edits
    54 adds
    5 deletes in trunk

[PerformanceTests] Each Dromaeo test needs its landing html.
https://bugs.webkit.org/show_bug.cgi?id=77504

Reviewed by Ryosuke Niwa.

PerformanceTests:

  • Added landing pages for each test which are listed in MANIFEST.json
  • Removed some tests which depends on the library whose license is incompatible to WebKit.
  • Added local copy of corresponding library. And replace the references to the remote sources to the local copies.
  • Removed old library files under Dromaeo/resources/dromaeo/web/lib/.
  • Skipped Sunsupier and v8 test. Such JS centric test should have its own test instead of running as a part of Dromaeo.
  • Dromaeo/cssquery-dojo.html: Added.
  • Dromaeo/cssquery-jquery.html: Added.
  • Dromaeo/cssquery-prototype.html: Added.
  • Dromaeo/dom-attr.html: Added.
  • Dromaeo/dom-modify.html: Added.
  • Dromaeo/dom-traverse.html: Added.
  • Dromaeo/dromaeo-3d-cube.html: Added.
  • Dromaeo/dromaeo-core-eval.html: Added.
  • Dromaeo/dromaeo-object-array.html: Added.
  • Dromaeo/dromaeo-object-regexp.html: Added.
  • Dromaeo/dromaeo-object-string.html: Added.
  • Dromaeo/dromaeo-string-base64.html: Added.
  • Dromaeo/jslib-attr-jquery.html: Added.
  • Dromaeo/jslib-attr-prototype.html: Added.
  • Dromaeo/jslib-event-jquery.html: Added.
  • Dromaeo/jslib-event-prototype.html: Added.
  • Dromaeo/jslib-modify-jquery.html: Added.
  • Dromaeo/jslib-modify-prototype.html: Added.
  • Dromaeo/jslib-style-jquery.html: Added.
  • Dromaeo/jslib-style-prototype.html: Added.
  • Dromaeo/jslib-traverse-jquery.html: Added.
  • Dromaeo/jslib-traverse-prototype.html: Added.
  • Dromaeo/resources/dromaeo/web/lib/dojo.js: Removed.
  • Dromaeo/resources/dromaeo/web/lib/dojo-1.6.1.js: Added.
  • Dromaeo/resources/dromaeo/web/lib/jquery.js: Removed.
  • Dromaeo/resources/dromaeo/web/lib/jquery-1.6.4.js: Added.
  • Dromaeo/resources/dromaeo/web/lib/mootools.js: Removed.
  • Dromaeo/resources/dromaeo/web/lib/prototype.js: Removed.
  • Dromaeo/resources/dromaeo/web/lib/prototype-1.7.js: Added.
  • Dromaeo/resources/dromaeo/web/tests/cssquery-dojo.html:
  • Dromaeo/resources/dromaeo/web/tests/cssquery-jquery.html:
  • Dromaeo/resources/dromaeo/web/tests/cssquery-mootools.html: Removed.
  • Dromaeo/resources/dromaeo/web/tests/cssquery-prototype.html:
  • Dromaeo/resources/dromaeo/web/tests/jslib-attr-jquery.html:
  • Dromaeo/resources/dromaeo/web/tests/jslib-attr-prototype.html:
  • Dromaeo/resources/dromaeo/web/tests/jslib-event-jquery.html:
  • Dromaeo/resources/dromaeo/web/tests/jslib-event-prototype.html:
  • Dromaeo/resources/dromaeo/web/tests/jslib-modify-jquery.html:
  • Dromaeo/resources/dromaeo/web/tests/jslib-modify-prototype.html:
  • Dromaeo/resources/dromaeo/web/tests/jslib-style-jquery.html:
  • Dromaeo/resources/dromaeo/web/tests/jslib-style-prototype.html:
  • Dromaeo/resources/dromaeo/web/tests/jslib-traverse-jquery.html:
  • Dromaeo/resources/dromaeo/web/tests/jslib-traverse-prototype.html:
  • Dromaeo/sunspider-3d-morph.html: Added.
  • Dromaeo/sunspider-3d-raytrace.html: Added.
  • Dromaeo/sunspider-access-binary-trees.html: Added.
  • Dromaeo/sunspider-access-fannkuch.html: Added.
  • Dromaeo/sunspider-access-nbody.html: Added.
  • Dromaeo/sunspider-access-nsieve.html: Added.
  • Dromaeo/sunspider-bitops-3bit-bits-in-byte.html: Added.
  • Dromaeo/sunspider-bitops-bits-in-byte.html: Added.
  • Dromaeo/sunspider-bitops-bitwise-and.html: Added.
  • Dromaeo/sunspider-bitops-nsieve-bits.html: Added.
  • Dromaeo/sunspider-controlflow-recursive.html: Added.
  • Dromaeo/sunspider-crypto-aes.html: Added.
  • Dromaeo/sunspider-crypto-md5.html: Added.
  • Dromaeo/sunspider-crypto-sha1.html: Added.
  • Dromaeo/sunspider-date-format-tofte.html: Added.
  • Dromaeo/sunspider-date-format-xparb.html: Added.
  • Dromaeo/sunspider-math-cordic.html: Added.
  • Dromaeo/sunspider-math-partial-sums.html: Added.
  • Dromaeo/sunspider-math-spectral-norm.html: Added.
  • Dromaeo/sunspider-regexp-dna.html: Added.
  • Dromaeo/sunspider-string-fasta.html: Added.
  • Dromaeo/sunspider-string-tagcloud.html: Added.
  • Dromaeo/sunspider-string-unpack-code.html: Added.
  • Dromaeo/sunspider-string-validate-input.html: Added.
  • Dromaeo/v8-crypto.html: Added.
  • Dromaeo/v8-deltablue.html: Added.
  • Dromaeo/v8-earley-boyer.html: Added.
  • Dromaeo/v8-raytrace.html: Added.
  • Dromaeo/v8-richards.html: Added.
  • Skipped:

Tools:

Added an ignorable pattern which happens in some Dromaeo tests.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner):

15:23 Changeset [106864] by crogers@google.com
  • 4 edits in trunk

zvmul incorrectly multiplies complex arrays on Windows.
https://bugs.webkit.org/show_bug.cgi?id=77900

Reviewed by Kenneth Russell.

Source/WebCore:

  • platform/audio/VectorMath.cpp:

(WebCore::VectorMath::zvmul):

LayoutTests:

  • platform/chromium/test_expectations.txt:
15:14 Changeset [106863] by kling@webkit.org
  • 7 edits in trunk/Source/WebCore

REGRESSION(r106756): 10% performance hit on DOM/Template.
<http://webkit.org/b/77831>

Reviewed by Ryosuke Niwa.

Let the StylePropertySet used for element attribute style have the element as its parent.
This is accomplished by adding an m_parentIsElement bit to StylePropertySet and sharing
some of the internal logic with inline styles.

In the end, this means that CSSParser will now pick up the document's CSSValuePool when
parsing properties for attribute styles, which fixes the perf regression from r106756.

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::contextStyleSheet):

Find contextStyleSheet via the parentElement() when there is one.

(WebCore::StylePropertySet::setNeedsStyleRecalc):

Always set FullStyleChange for attribute style mutations. We can probably use the
same lighter invalidation as inline styles, but that's a topic for another patch.

  • css/StylePropertySet.h:

(WebCore::StylePropertySet::createInline):
(WebCore::StylePropertySet::createAttributeStyle):
(WebCore::StylePropertySet::parentRuleInternal):
(WebCore::StylePropertySet::clearParentRule):
(StylePropertySet):
(WebCore::StylePropertySet::parentElement):
(WebCore::StylePropertySet::clearParentElement):

Added m_parentIsElement bit and update assertions as appropriate to not just
cover the inline style case. Added a createAttributeStyle() helper to create
a StylePropertySet for use as Element::attributeStyle().

  • dom/StyledElement.h:
  • dom/ElementAttributeData.h:
  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::ensureAttributeStyle):

Use StylePropertySet::createAttributeStyle().

  • dom/StyledElement.cpp:

(WebCore::StyledElement::removeCSSProperties):
(WebCore::StyledElement::addCSSProperty):
(WebCore::StyledElement::addCSSImageProperty):

Remove setNeedsStyleRecalc() calls since that is now handled automatically by
StylePropertySet's mutation methods.

15:10 Changeset [106862] by haraken@chromium.org
  • 4 edits
    1 add in trunk/Source/WebCore

In AppleWebKit, stop rebuilding IDLs that need not to be rebuilt
https://bugs.webkit.org/show_bug.cgi?id=77510

Reviewed by Adam Barth.

Currently, if any IDL file is updated, all IDL files are rebuilt.
This patch stops rebuilding IDL files which are not modified nor
whose supplemental dependencies are not changed.

The new build flow is as follows:

supplemental.dep : $(ALL_IDLS)

perl resolve-supplemental.pl ...

%.idl-needs-rebuild : %.idl supplemental.dep

perl update-idl-needs-rebuild.pl ...

JS%.cpp : %.idl-needs-rebuild

perl generate-bindings.pl ...

resolve-supplemental.pl generates the following supplemental.dep.
The number in () is the last access timestamp of the file.

A.idl(1200)
B.idl(1000) B-supplemental1.idl(800) B-supplemental2.idl(1200)
C.idl(1000)

update-idl-needs-rebuild.pl for X.idl touches X.idl-needs-rebuild,
if X.idl-needs-rebuild is older than X.idl or the IDL files which are
supplementing X.idl. For example, if the timestamps of A.idl-needs-rebuild,
B.idl-needs-rebuild and C.idl-needs-rebuild are all 1000, then A.idl-needs-rebuild
and B.idl-needs-rebuild will be touched.

Even if no IDL files are modified, update-idl-needs-rebuild.pl can run for all IDL files,
but generate-bindings.pl won't run. If any IDL file is updated, resolve-supplemental.pl
will run once, update-idl-needs-rebuild.pl will run for all IDL files, and
generate-bindings.pl will run for the IDL files which are modified or whose
dependencies are changed.

No tests. I manually confirmed the followings:

  • Touch Element.idl, then only Element.idl is rebuilt
  • Touch DOMWindow.idl, then only DOMWindow.idl is rebuilt
  • Touch DOMWindowWebAudio.idl, then only DOMWindow.idl and DOMWindowWebAudio.idl are rebuilt
  • DerivedSources.make: Modified the build flow as described above.
  • bindings/scripts/generate-bindings.pl: Modified to read an IDL file path from .idl-needs-rebuild.
  • bindings/scripts/update-idl-needs-rebuild.pl: Added. Touches X.idl-needs-rebuild if

the X.idl-needs-rebuild is older than X.idl or the IDL files which are supplementing X.idl.
(touch):

15:10 Changeset [106861] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, chromium expectations update.
Layout Test http/tests/media/video-served-as-text.html is flaky on cr-win
https://bugs.webkit.org/show_bug.cgi?id=72904

Test is not flaky on XP.

Patch by Ami Fischman <fischman@chromium.org> on 2012-02-06

  • platform/chromium/test_expectations.txt:
15:08 Changeset [106860] by mdelaney@apple.com
  • 1 edit in trunk/Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp

Windows build fix

15:02 Changeset [106859] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Chromium build fix after r106836.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::doPixelReadbackToCanvas):

15:00 Changeset [106858] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk

AudioBus need to support stereo->mono down mix in copyFrom sumFrom etc.
https://bugs.webkit.org/show_bug.cgi?id=77609

Patch by Wei James <james.wei@intel.com> on 2012-02-06
Reviewed by Kenneth Russell.

Test: webaudio/stereo2mono-down-mixing.html

  • platform/audio/AudioBus.cpp:

(WebCore):
(WebCore::AudioBus::copyFrom):
(WebCore::AudioBus::sumFrom):

14:55 Changeset [106857] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] storage/indexeddb/index-cursor.html timeouts on Mac Debug
https://bugs.webkit.org/show_bug.cgi?id=65862

No sign of this test timing out in recent history, and significant
performance work has been done since it was filed. Unmarking as SLOW/PASS.

Reviewed by Tony Chang.

  • platform/chromium/test_expectations.txt:
14:54 Changeset [106856] by ericu@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[filesystem/Chromium] crackFileSystemURL needs to use innerURL
https://bugs.webkit.org/show_bug.cgi?id=77881

Reviewed by Adam Barth.

  • src/AsyncFileSystemChromium.cpp:

(WebCore::AsyncFileSystem::crackFileSystemURL):
Add the new code path, taken only if innerURL is present.

14:39 Changeset [106855] by jchaffraix@webkit.org
  • 1 edit
    2 adds
    1 delete in trunk/LayoutTests

Unreviewed gardening.

More font differences that need a rebaseline.

  • platform/chromium-linux-x86/fast/canvas/check-stale-putImageData-expected.png: Removed.
  • platform/chromium-linux/fast/canvas/check-stale-putImageData-expected.png: Added.
  • platform/chromium-win/fast/canvas/check-stale-putImageData-expected.png: Added.
14:35 Changeset [106854] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Chromium] rebaseline test on win/mac after enabling paint opaque tracking for draw culling
https://bugs.webkit.org/show_bug.cgi?id=77497

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-06
Reviewed by James Robinson.

  • platform/chromium-win/fast/repaint/block-selection-gap-in-composited-layer-expected.png: Added.
  • platform/chromium/test_expectations.txt:
14:32 Changeset [106853] by abarth@webkit.org
  • 4 edits in trunk/LayoutTests

http/tests/security/mixedContent/insecure-plugin-in-iframe.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=77901

Reviewed by Eric Seidel.

This test fails occationally because of the order of the frame load
callbacks. Now that we log mixed content errors to the console, we
don't need to dump the frame load callbacks in this test.

  • http/tests/security/mixedContent/insecure-plugin-in-iframe-expected.txt:
  • http/tests/security/mixedContent/insecure-plugin-in-iframe.html:
14:30 Changeset [106852] by cdn@chromium.org
  • 3 edits
    2 adds in trunk

Source/WebCore: Add RefPtrs for parent and sibling counter nodes
https://bugs.webkit.org/show_bug.cgi?id=75212

Reviewed by Adam Barth.

Test: fast/css/counters/reparent-table-children-with-counters-crash.html

  • rendering/RenderCounter.cpp:

(WebCore::findPlaceForCounter):
(WebCore::makeCounterNode):
(WebCore::updateCounters):

LayoutTests: Test for crash when counter nodes are reparented outside of tables
https://bugs.webkit.org/show_bug.cgi?id=75212

Reviewed by Adam Barth.

  • fast/css/counters/reparent-table-children-with-counters-crash-expected.txt: Added.
  • fast/css/counters/reparent-table-children-with-counters-crash.html: Added.
14:26 Changeset [106851] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

Unreviewed fix for the new API test that is failing -
WEBKIT_INSPECTOR_PATH needs to be set, since we do not install our
builds.

  • tests/testwebinspector.c:

(main):

14:17 Changeset [106850] by mdelaney@apple.com
  • 2 edits in trunk/Source/WebCore/platform/mac

Fix for burning SL tree

14:17 Changeset [106849] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

According to the flakiness dashboard, these tests do appear to be
successfully de-flaked.

  • platform/chromium/test_expectations.txt:
14:16 LayoutUnit created by eae@chromium.org
Added initial draft of wiki page explaining LayoutUnits.
14:06 Changeset [106848] by jochen@chromium.org
  • 4 edits in branches/chromium/1025/Source/WebCore

Merge 106846 - Before accessing a frame's script controller in V8 bindings, first check that the frame actually exists
https://bugs.webkit.org/show_bug.cgi?id=77370

Reviewed by Adam Barth.

I don't have a working reproduction of the crash yet. As soon as I have
one, I will add new layout tests.

  • bindings/v8/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::addListener):

  • bindings/v8/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute):

  • bindings/v8/ScriptCachedFrameData.cpp:

(WebCore::ScriptCachedFrameData::restore):

  • page/DOMTimer.cpp:

(WebCore::DOMTimer::DOMTimer): remove temporary debug code
Review URL: https://chromiumcodereview.appspot.com/9340005

13:59 Changeset [106847] by commit-queue@webkit.org
  • 4 edits in trunk

[GTK] Add missing pango include dir to fix build
https://bugs.webkit.org/show_bug.cgi?id=77832

Patch by Kalev Lember <kalevlember@gmail.com> on 2012-02-06
Reviewed by Martin Robinson.

Source/WebCore:

  • GNUmakefile.am: Added $(PANGO_CFLAGS) to libWebCore_la_CPPFLAGS.

Tools:

  • GNUmakefile.am: Added $(PANGO_CFLAGS) to libWebCoreInternals_la_CPPFLAGS.
13:55 Changeset [106846] by jochen@chromium.org
  • 5 edits in trunk/Source/WebCore

Before accessing a frame's script controller in V8 bindings, first check that the frame actually exists
https://bugs.webkit.org/show_bug.cgi?id=77370

Reviewed by Adam Barth.

I don't have a working reproduction of the crash yet. As soon as I have
one, I will add new layout tests.

  • bindings/v8/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::addListener):

  • bindings/v8/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute):

  • bindings/v8/ScriptCachedFrameData.cpp:

(WebCore::ScriptCachedFrameData::restore):

  • page/DOMTimer.cpp:

(WebCore::DOMTimer::DOMTimer): remove temporary debug code

13:43 Changeset [106845] by senorblanco@chromium.org
  • 3 edits in branches/chromium/963/Source/WebCore

Merge 104501 - [chromium win] Creating lots of temporary canvas contexts will crash.
https://bugs.webkit.org/show_bug.cgi?id=68420

When using the skia port, the allocation of 2d canvas backing stores
no longer needs to be done through a platform API (GDI/CG) because
canvases now use skia for drawing text. Removing the allocation through
GDI on windows prevents resource exhaustion due to unreferenced canvases
that are awaiting garbage collection.

Patch by Justin Novosad <junov@chromium.org> on 2012-01-09
Reviewed by Stephen White.

No new tests: Relying on existing canvas layout tests.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::createImageBuffer):

  • platform/graphics/ImageBuffer.h:
  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::createNonPlatformCanvas):
(WebCore::ImageBuffer::ImageBuffer):

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9340004

13:39 Changeset [106844] by jchaffraix@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed rebaseline after r106836.

The rebaseline is caused by a font difference.

  • platform/chromium-linux-x86/fast/canvas/check-stale-putImageData-expected.png: Added.
13:34 Changeset [106843] by mdelaney@apple.com
  • 4 edits in trunk/WebKitLibraries

Correcting the version of WKSI committed in r106836

13:25 Changeset [106842] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium test expectation change

Unmarking storage/indexeddb/data-corruption.html as TIMEOUT. Was apparently
bulk-marked as TIMEOUT on Snow Leopard as part of WK54322 although it is
not mentioned in that issue. The test hasn't failed in recent history and
there has been substantial rework on the IndexedDB feature since the
expectation was set.

  • platform/chromium/test_expectations.txt:
13:19 Changeset [106841] by shawnsingh@chromium.org
  • 4 edits in branches/chromium/1025

Merge 106459 - Fix the semantics of passing contentsVisible flag to GraphicsLayers
https://bugs.webkit.org/show_bug.cgi?id=76975

Reviewed by Simon Fraser.

Source/WebCore:

This patch is covered by existing tests, in particular
compositing/visibility/layer-visible-content.html; its
expectations are rebaselined.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

LayoutTests:

  • compositing/visibility/layer-visible-content-expected.txt: rebaselined expected result
  • compositing/visibility/layer-visible-content.html: fixed height so that result is platform-independent
  • platform/chromium/test_expectations.txt: removed fail expectation, it should pass now.

TBR=shawnsingh@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9342003

13:17 Changeset [106840] by jamesr@google.com
  • 7 edits in trunk/Source

Source/WebCore: Support detaching TextureManager from ManagedTexture
https://bugs.webkit.org/show_bug.cgi?id=77655

Reviewed by Kenneth Russell.
Initial patch by Alok Priyadarshi.

TextureManager now holds references to the textures it manages.
This allows TextureManager to inform managed textures when it gets deleted
so that the texture that outlive the TextureManager can handle the situation gracefully.

Unit test in TextureManagerTest.cpp

  • platform/graphics/chromium/ManagedTexture.cpp:

(WebCore::ManagedTexture::ManagedTexture):
(WebCore::ManagedTexture::~ManagedTexture):
(WebCore):
(WebCore::ManagedTexture::managerWillDie):
(WebCore::ManagedTexture::isValid):
(WebCore::ManagedTexture::reserve):
(WebCore::ManagedTexture::unreserve):
(WebCore::ManagedTexture::steal):
(WebCore::ManagedTexture::reset):

  • platform/graphics/chromium/ManagedTexture.h:

(WebCore::ManagedTexture::manager):
(ManagedTexture):
(WebCore::ManagedTexture::isReserved):

  • platform/graphics/chromium/TextureManager.cpp:

(WebCore::TextureManager::~TextureManager):
(WebCore):
(WebCore::TextureManager::setPreferredMemoryLimitBytes):
(WebCore::TextureManager::registerTexture):
(WebCore::TextureManager::unregisterTexture):

  • platform/graphics/chromium/TextureManager.h:

(WebCore):
(TextureManager):

Source/WebKit/chromium: [chromium] Support detaching TextureManager from ManagedTexture
https://bugs.webkit.org/show_bug.cgi?id=77655

Adds unit test for destroying a TextureManager while ManagedTextures are still alive referring to it.

Reviewed by Kenneth Russell.

  • tests/TextureManagerTest.cpp:
13:05 Changeset [106839] by andersca@apple.com
  • 6 edits in trunk

Wheel event handler count not updated when adding handlers to the window
https://bugs.webkit.org/show_bug.cgi?id=77895

Reviewed by Dan Bernstein.

Source/WebCore:

Test: fast/events/wheelevent-handler-count.html

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
Update the wheel event count.

  • testing/Internals.cpp:

(WebCore::Internals::wheelEventHandlerCount):

  • testing/Internals.h:
  • testing/Internals.idl:

Add wheelEventHandlerCount to window.internals.

LayoutTests:

  • fast/events/wheelevent-handler-count-expected.txt: Added.
  • fast/events/wheelevent-handler-count.html: Added.
13:01 Changeset [106838] by commit-queue@webkit.org
  • 7 edits in trunk

Source/WebKit2: [GTK] Fix remaining errors in GTK+ WebKit2 API
https://bugs.webkit.org/show_bug.cgi?id=77890

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-02-06
Reviewed by Gustavo Noronha Silva.

Fix some style issues in the GTK+ WebKit2 API section of the source code.

  • UIProcess/API/gtk/WebKitPrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:
  • UIProcess/API/gtk/tests/TestMain.h:

Tools: [GTK] Fix remaining errors in GTK+ WebKit2 API
https://bugs.webkit.org/show_bug.cgi?id=77890

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-02-06
Reviewed by Gustavo Noronha Silva.

Verify that WebKit2 GTK+ test files are not skipped during style checks.
Skip soup_server_new when checking for NULL versus 0 usage.

  • Scripts/webkitpy/style/checker_unittest.py:

(CheckerDispatcherSkipTest.test_should_skip_with_warning):

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_for_null):

13:00 CommitterTips edited by bweinstein@apple.com
(diff)
13:00 CommitterTips edited by bweinstein@apple.com
(diff)
12:57 CommitterTips edited by bweinstein@apple.com
(diff)
12:56 Changeset [106837] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebCore

Merged r106729.

12:54 Changeset [106836] by mdelaney@apple.com
  • 28 edits
    3 adds in trunk

toDataURL() uses stale data after putImageData()
https://bugs.webkit.org/show_bug.cgi?id=65767

Source/WebCore:

This patch fixes the issue we've encountered of getting back
stale copies of the CGContext of accelerated ImageBuffers who have seen
putImageData calls but have not been drawn into via the CG API.
This issue is fixed by modifying the way we implement putImageData
in ImageBufferCG to draw the bits wrapped in a CGImage while the CGContext
is in a state where the data will effectively be copied (as is needed for
implementing putImageData) instead of directly modifying the bits of the IOSurface.

Reviewed by Chris Marrin.

Test: fast/canvas/check-stale-putImageData, pixel test to check that the canvas is in fact painted.

  • platform/graphics/cg/ImageBufferCG.cpp: Implement new way of putting image data.
  • platform/graphics/ImageBuffer.h: Merged two previously separate put data calls

into a single and more sensibly named 'putByteArray', since that's what it does!

  • WebCore.exp.in: Added new WKSI call for use in ImageBufferCG.cpp
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Using new method name.

  • html/canvas/CanvasRenderingContext2D.cpp:
  • platform/graphics/ImageBuffer.cpp:
  • platform/graphics/ShadowBlur.cpp:
  • platform/graphics/filters/FEColorMatrix.cpp:
  • platform/graphics/filters/FEDropShadow.cpp:
  • platform/graphics/filters/FilterEffect.cpp:

Updated other ports' ImageBuffers to use new method.

  • platform/graphics/cairo/ImageBufferCairo.cpp:
  • platform/graphics/qt/ImageBufferQt.cpp:
  • platform/graphics/skia/ImageBufferSkia.cpp:
  • platform/graphics/wince/ImageBufferWinCE.cpp:
  • platform/graphics/wx/ImageBufferWx.cpp:

Source/WebKit/chromium:

Reviewed by Chris Marrin.

  • src/WebViewImpl.cpp: Updated method name.

(WebKit::WebViewImpl::doPixelReadbackToCanvas):

Source/WebKit/mac:

Reviewed by Chris Marrin.

  • WebCoreSupport/WebSystemInterface.mm:

Source/WebKit2:

Reviewed by Chris Marrin.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

WebKitLibraries:

Added WKCGContextResetClip for use in reseting clip for new putByteArray method.

Reviewed by Chris Marrin.

  • WebKitSystemInterface.h: Added WKCGContextResetClip.
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceLion.a:
12:54 Changeset [106835] by lforschler@apple.com
  • 5 edits
    3 copies in branches/safari-534.54-branch

Merged r104356.

12:48 Changeset [106834] by lforschler@apple.com
  • 3 edits in branches/safari-534.54-branch/Source/JavaScriptCore

Merged r106594.

12:42 Changeset [106833] by caio.oliveira@openbossa.org
  • 30 edits in trunk/Source

Provide more attribute methods in Element
https://bugs.webkit.org/show_bug.cgi?id=77800

Reviewed by Ryosuke Niwa.

Source/WebCore:

Reduce the clients of NamedNodeMap. This will make easier to change the
implementation of our attribute storage. The clients now use Element methods
that expose Attribute* accessors.

Instead of checking the existence of NamedNodeMap, clients can call
hasAttributes() or hasAttributesWithoutUpdate() (that skips updating invalid
style or animation svg attributes).

If there are attributes, they can be accessed by index via attributeCount() /
attributeItem(), as well as by QualifiedName. Those accessors assume there are an
attribute storage.

  • css/SelectorChecker.cpp:

(WebCore::anyAttributeMatches):
(WebCore::SelectorChecker::checkOneSelector):

  • css/SelectorChecker.h:

(WebCore::SelectorChecker::checkExactAttribute):

  • dom/DatasetDOMStringMap.cpp:

(WebCore::DatasetDOMStringMap::getNames):
(WebCore::DatasetDOMStringMap::item):
(WebCore::DatasetDOMStringMap::contains):

  • dom/Document.cpp:

(WebCore::Document::importNode): use setAttributesFromElement() instead of manually copying.

  • dom/Element.h:

(Element):
(WebCore::Element::hasAttributesWithoutUpdate):
(WebCore):
(WebCore::Element::attributeCount):
(WebCore::Element::attributeItem):
(WebCore::Element::getAttributeItem):
(WebCore::Element::removeAttribute):

  • dom/Node.cpp:

(WebCore::Node::isDefaultNamespace):
(WebCore::Node::lookupNamespaceURI):
(WebCore::Node::lookupNamespacePrefix):
(WebCore::Node::compareDocumentPosition):

  • editing/ApplyStyleCommand.cpp:

(WebCore::hasNoAttributeOrOnlyStyleAttribute):
(WebCore::isEmptyFontTag):

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::elementIsStyledSpanOrHTMLEquivalent):

  • editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::highestVisuallyEquivalentDivBelowRoot):

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendElement):

  • editing/markup.cpp:

(WebCore::completeURLs):
(WebCore::StyledMarkupAccumulator::appendElement):

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::parametersForPlugin):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateType):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parametersForPlugin):

  • html/HTMLParamElement.cpp:

(WebCore::HTMLParamElement::isURLAttribute):

  • html/parser/HTMLFormattingElementList.cpp:

(WebCore::attributeCountWithoutUpdate):
(WebCore::HTMLFormattingElementList::tryToEnsureNoahsArkConditionQuickly):
(WebCore::HTMLFormattingElementList::ensureNoahsArkCondition): Store Attribute*
to avoid looking up the right element again by name.

  • inspector/DOMEditor.cpp:

(WebCore::DOMEditor::innerPatchNode):
(WebCore::DOMEditor::createDigest):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::buildArrayForElementAttributes):

  • page/PageSerializer.cpp:

(WebCore::isCharsetSpecifyingNode):

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::getPresentationAttribute):

  • xml/XPathFunctions.cpp:

(WebCore::XPath::FunLang::evaluate):

  • xml/XPathNodeSet.cpp:

(WebCore::XPath::NodeSet::traversalSort):

  • xml/XPathStep.cpp:

(WebCore::XPath::Step::nodesInAxis):

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):

  • xml/parser/XMLTreeBuilder.cpp:

(WebCore::XMLTreeBuilder::XMLTreeBuilder):

Source/WebKit/chromium:

  • src/WebPageSerializerImpl.cpp:

(WebKit::WebPageSerializerImpl::openTagToString): access attributes via Element interface.

Source/WebKit/qt:

  • Api/qwebelement.cpp:

(QWebElement::attributeNames): access attributes via Element interface.

12:29 Changeset [106832] by eric@webkit.org
  • 3 edits in trunk/Tools

webkit-patch apply-from-bug should be able to apply non-reviewed patches
https://bugs.webkit.org/show_bug.cgi?id=77883

Reviewed by Adam Barth.

This is very helpful if you use bugzilla as a replacement for git-stash.
Makes it simpler to re-apply the patch w/o having to look up the patch id.

  • Scripts/webkitpy/tool/commands/download.py:

(ProcessBugsMixin._fetch_list_of_patches_to_process):

  • Scripts/webkitpy/tool/commands/download_unittest.py:

(DownloadCommandsTest.test_apply_from_bug):

12:12 Changeset [106831] by kov@webkit.org
  • 6 edits
    1 add in trunk

[GTK] Insta-crash when closing browser with inspector window opened
https://bugs.webkit.org/show_bug.cgi?id=50744

Reviewed by Martin Robinson.

Source/WebKit/gtk:

  • GNUmakefile.am:
  • WebCoreSupport/InspectorClientGtk.cpp:

(WebKit::InspectorClient::releaseFrontendPage): also let go of the
frontend client when releasing the frontend page;
(WebKit::InspectorFrontendClient::~InspectorFrontendClient(): Call releaseFrontendPage()
like other ports do instead of just disconnectFrontendClient().
(WebKit::InspectorFrontendClient::destroyInspectorWindow): Use GRefPtr for the
inspector ref.
(WebKit::InspectorFrontendClient::bringToFront): Adjust for GRefPtr usage.
(WebKit::InspectorFrontendClient::attachWindow): Ditto.
(WebKit::InspectorFrontendClient::detachWindow): Ditto.
(WebKit::InspectorFrontendClient::inspectedURLChanged): Ditto.

  • WebCoreSupport/InspectorClientGtk.h:

(InspectorFrontendClient): Use GRefPtr for inspector member.

  • tests/testwebinspector.c: Added. Test that killing a WebView with the inspector

open does not crash, and that closing and reinspecting works.
(quitLoop):
(consoleMessageCallback):
(inspectElementCallback):
(closeInspector):
(showInspector):
(test_webkit_web_inspector_close_and_inspect):
(test_webkit_web_inspector_destroy_inspected_web_view):
(main):

LayoutTests:

  • platform/gtk/Skipped: unskip inspector/debugger/open-close-open.html,

which now passes.

12:00 Changeset [106830] by jsbell@chromium.org
  • 5 edits in trunk

IndexedDB: Raise exception during add/put call if autoIncrement key insertion will fail
https://bugs.webkit.org/show_bug.cgi?id=77374

Source/WebCore:

If a put request will use a key generator, try inserting a dummy key during the sync
put() call to check if the key insertion will succeed so an exception can be raised
early, rather than deferring to the asynchronous task.

Reviewed by Tony Chang.

Test: storage/indexeddb/keypath-edges.html

  • storage/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::put):

LayoutTests:

Reviewed by Tony Chang.

  • storage/indexeddb/keypath-edges-expected.txt:
  • storage/indexeddb/keypath-edges.html:
11:56 Changeset [106829] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test fast/forms/listbox-clear-restore.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=77889

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:54 Changeset [106828] by kov@webkit.org
  • 4 edits in trunk/Source

Add a null check for the gdkwindow, that will happen if the window
is not mapped.

Reviewed by Martin Robinson.

  • platform/gtk/GtkUtilities.cpp:

(WebCore::convertWidgetPointToScreenPoint):

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::setCursor):

11:50 Changeset [106827] by commit-queue@webkit.org
  • 13 edits in trunk

Source/WebCore: IndexedDB createObjectStore should throw if options arg is invalid
Added logic to OptionsObject to determine if an invalid object was created.
Javascript bindings now detect invalid OptionsObject's and throw TypeError when found.
https://bugs.webkit.org/show_bug.cgi?id=58471

Patch by Eugene Girard <girard@chromium.org> on 2012-02-06
Reviewed by Adam Barth.

Test: storage/indexeddb/createObjectStore-bad-options.html

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateParametersCheck):

  • bindings/v8/OptionsObject.cpp:

(WebCore::OptionsObject::isObject):

  • bindings/v8/OptionsObject.h:

LayoutTests: IndexedDB createObjectStore should throw if options arg is invalid (not an object).
Added unit tests to test invalid arguments.
storage/indexddb/transaction-basics was modified only to correct calls that would
now throw.
https://bugs.webkit.org/show_bug.cgi?id=58471

Patch by Eugene Girard <girard@chromium.org> on 2012-02-06
Reviewed by Adam Barth.

  • storage/indexeddb/create-object-store-options-expected.txt:
  • storage/indexeddb/create-object-store-options.html:
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/resources/shared.js:

(evalAndExpectExceptionClass):

  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-basics.html:
  • storage/indexeddb/tutorial.html:
11:50 Changeset [106826] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/platform/Widget.h

Fixing incorrect usage of AppUnits as parameters to Widgets.

11:37 Changeset [106825] by jesus@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] http/tests/loading/state-object-security-exception.html fails
https://bugs.webkit.org/show_bug.cgi?id=62731

Unreviewed gardening.

Skipped 3 tests because they were still failing after http://trac.webkit.org/changeset/106812 .
Skipped tests were:
fast/history/form-submit-in-frame-via-onclick.html
fast/history/form-submit-in-frame.html
http/tests/loading/state-object-security-exception.html

  • platform/qt-wk2/Skipped:
11:37 Changeset [106824] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit2

gcc build fix after r106749.

  • UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::WebPreferences):

11:28 Changeset [106823] by jchaffraix@webkit.org
  • 36 edits
    4 deletes in trunk

Unreviewed, rolling out r106797 and r106806.
http://trac.webkit.org/changeset/106797
http://trac.webkit.org/changeset/106806
https://bugs.webkit.org/show_bug.cgi?id=77888

The change is still causing some crashes in webaudio/ on the
Chromium bots (Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-06

Source/WebCore:

  • Modules/intents/IntentRequest.cpp:

(WebCore::IntentRequest::create):

  • bindings/generic/ActiveDOMCallback.cpp:

(WebCore::ActiveDOMCallback::ActiveDOMCallback):

  • dom/ActiveDOMObject.cpp:

(WebCore::ActiveDOMObject::ActiveDOMObject):
(WebCore::ActiveDOMObject::~ActiveDOMObject):

  • dom/ActiveDOMObject.h:

(ActiveDOMObject):

  • dom/DocumentEventQueue.cpp:

(WebCore::DocumentEventQueue::DocumentEventQueue):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::ScriptExecutionContext):
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
(WebCore::ScriptExecutionContext::stopActiveDOMObjects):

  • dom/ScriptExecutionContext.h:

(ScriptExecutionContext):

  • fileapi/DOMFileSystem.cpp:

(WebCore::DOMFileSystem::create):

  • fileapi/FileReader.cpp:

(WebCore):

  • fileapi/FileReader.h:

(WebCore::FileReader::create):

  • fileapi/FileWriter.cpp:

(WebCore):

  • fileapi/FileWriter.h:

(WebCore::FileWriter::create):

  • history/CachedFrame.cpp:

(WebCore::CachedFrame::CachedFrame):

  • html/HTMLAudioElement.cpp:

(WebCore::HTMLAudioElement::create):
(WebCore::HTMLAudioElement::createForJSConstructor):

  • html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::create):

  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::create):

  • mediastream/PeerConnection.cpp:

(WebCore::PeerConnection::create):

  • notifications/Notification.cpp:

(WebCore::Notification::create):

  • notifications/NotificationCenter.cpp:
  • notifications/NotificationCenter.h:

(WebCore::NotificationCenter::create):

  • page/DOMTimer.cpp:

(WebCore::DOMTimer::install):
(WebCore::DOMTimer::fired):

  • page/EventSource.cpp:

(WebCore::EventSource::create):

  • page/SuspendableTimer.cpp:

(WebCore::SuspendableTimer::SuspendableTimer):

  • storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::create):

  • storage/IDBRequest.cpp:

(WebCore::IDBRequest::create):

  • storage/IDBTransaction.cpp:

(WebCore::IDBTransaction::create):

  • storage/IDBVersionChangeRequest.cpp:

(WebCore::IDBVersionChangeRequest::create):

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::create):

  • websockets/WebSocket.cpp:
  • websockets/WebSocket.h:

(WebCore::WebSocket::create):

  • workers/SharedWorker.cpp:

(WebCore::SharedWorker::create):

  • workers/Worker.cpp:

(WebCore::Worker::create):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::create):

LayoutTests:

  • fast/events/resources/suspend-subframe-1.html: Removed.
  • fast/events/resources/suspend-subframe-2.html: Removed.
  • fast/events/suspend-timers-expected.txt: Removed.
  • fast/events/suspend-timers.html: Removed.
  • platform/chromium/test_expectations.txt:
11:24 Changeset [106822] by lforschler@apple.com
  • 9 edits in branches/safari-534.54-branch/Source

Merged r106678.

11:13 Changeset [106821] by dslomov@google.com
  • 1 edit in branches/chromium/1025/Source/WebCore/bindings/v8/V8Helpers.cpp

Merge 106722 - [Chromium] WebCore::toV8Context crashes if DomWindow::frame() returns null.
https://bugs.webkit.org/show_bug.cgi?id=77686.

Reviewed by Adam Barth.

  • bindings/v8/V8Helpers.cpp:

(WebCore::toV8Context):

TBR=dslomov@google.com
Review URL: https://chromiumcodereview.appspot.com/9334005

11:01 Changeset [106820] by rniwa@webkit.org
  • 1 edit
    2 copies in branches/chromium/1025

Merge 106380 - Source/WebCore: Crash in DeleteSelectionCommand::handleGeneralDelete when attempting to delete the start block
https://bugs.webkit.org/show_bug.cgi?id=77077

Reviewed by Enrica Casucci.

The crash was caused by a missing null check after removing the position out of the start block.
Fixed the bug by adding an early return.

Tests: editing/deleting/delete-start-block.html

editing/selection/move-into-empty-root-inline-box.html

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::handleGeneralDelete):

LayoutTests: Crash in previousLinePosition when moving into a root inline box without leaves
https://bugs.webkit.org/show_bug.cgi?id=76812

Reviewed by Enrica Casucci.

Add a regression test for the crash. Unfortunately, we can only test previousLinePosition.

  • editing/selection/move-into-empty-root-inline-box-expected.txt: Added.
  • editing/selection/move-into-empty-root-inline-box.html: Added.

http://crbug.com/99408/
Review URL: https://chromiumcodereview.appspot.com/9331006

10:35 Changeset [106819] by caio.oliveira@openbossa.org
  • 6 edits in trunk/Source/WebCore

Move style related functions from NamedNodeMap to ElementAttributeData
https://bugs.webkit.org/show_bug.cgi?id=77879

Reviewed by Ryosuke Niwa.

This commit also removes the NamedNodeMap::mappedAttributeCount(),
which is a leftover from removal of mapped attributes.

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::ensureInlineStyleDecl):
(WebCore):
(WebCore::ElementAttributeData::destroyInlineStyleDecl):
(WebCore::ElementAttributeData::ensureAttributeStyle):

  • dom/ElementAttributeData.h:

(WebCore::ElementAttributeData::inlineStyleDecl):
(ElementAttributeData):
(WebCore::ElementAttributeData::attributeStyle):

  • dom/NamedNodeMap.cpp:
  • dom/NamedNodeMap.h:
  • dom/StyledElement.h:

(StyledElement):
(WebCore::StyledElement::inlineStyleDecl):
(WebCore::StyledElement::ensureInlineStyleDecl):
(WebCore::StyledElement::attributeStyle):
(WebCore::StyledElement::ensureAttributeStyle):
(WebCore::StyledElement::destroyInlineStyleDecl):

10:23 Changeset [106818] by inferno@chromium.org
  • 3 edits
    3 adds in trunk

Crash in SubframeLoader::loadSubframe.
https://bugs.webkit.org/show_bug.cgi?id=77345

Reviewed by Nate Chapin.

Source/WebCore:

Mutation event when loading subframe can blow away the
main frame. Add a RefPtr to protect against that.

Test: fast/frames/subframe-load-crash-main.html

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::loadSubframe):

LayoutTests:

  • fast/frames/resources/subframe-load-crash.svg: Added.
  • fast/frames/subframe-load-crash-main-expected.txt: Added.
  • fast/frames/subframe-load-crash-main.html: Added.
10:20 Changeset [106817] by senorblanco@chromium.org
  • 2 edits in branches/chromium/1025

Merge 106477 - [SKIA/CHROMIUM] Perform getImageData format conversions using Skia
https://bugs.webkit.org/show_bug.cgi?id=77553

Patch by Brian Salomon <bsalomon@google.com> on 2012-02-01
Reviewed by Stephen White.

Source/WebCore:

Many existing canvas tests exercise this functionality.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::getImageData):

LayoutTests:

  • platform/chromium/test_expectations.txt:

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9331005

09:59 Changeset [106816] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[GTK] WebKitWebView does a lot of work during size_allocate when not mapped
https://bugs.webkit.org/show_bug.cgi?id=77743

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-02-06
Reviewed by Gustavo Noronha Silva.

Instead of resizing the guts of a WebView when it's not mapped, wait
until it's mapped and do one resize. This prevents unmapped WebViews
from adding to a container's resize cost.

Source/WebKit/gtk:

  • webkit/webkitwebview.cpp:

(resizeWebViewFromAllocation): Abstracted out this helper.
(webkit_web_view_size_allocate): Wait until map to resize umapped widgets.
(webkitWebViewMap): Added this vmethod implementation.
(webkit_web_view_class_init): Added vmethod.

  • webkit/webkitwebviewprivate.h: Added new needsResizeOnMap member.

Source/WebKit2:

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(_WebKitWebViewBasePrivate): Added a new member needsResizeOnMap.
(resizeWebKitWebViewBaseFromAllocation): Abstracted out this helper.
(webkitWebViewBaseSizeAllocate): Wait until map to resize unmapped WebViews.
(webkitWebViewBaseMap): Added this vmethod implementation.
(webkit_web_view_base_class_init): Added vmethod.

09:49 Changeset [106815] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Initial implementation of GraphicsContext3DOpenGLES.cpp
https://bugs.webkit.org/show_bug.cgi?id=76248

Patch by ChangSeok Oh <shivamidow@gmail.com> on 2012-02-06
Reviewed by Martin Robinson.

Implemented APIs in GraphicsContext3DOpenGLES.cpp according to the GLES spec. roughly.
But no way to run these codes right now, because they need an extra port
specific implementation to work. I plan to add these extra codes for the GTK port
in the next patch. And also this patch doesn't support anti-aliasing yet. Another bug
will deal with it.
Moved some APIs in GraphicsContext3DOpenGLES.cpp to GraphicsContext3DCommon.cpp.
It looks it could be shared between gl and gles.
Two helper functions are added to avoid code duplication in GraphicsContext3D.
Added a missing period at the end of comment lines.

No new tests required.
We'll be able to verify this patch by using the existing webgl test cases.

  • platform/graphics/GraphicsContext3D.h: Add build flag to access stencilBuffer & depthBuffer for gles.

(WebCore):

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::reshapeFBOs): Helper function extracted from GC3D::reshape to resize regular & multisampled FBOs.
(WebCore::GraphicsContext3D::resolveMultisamplingIfNecessary): Helper function to resolve multisampling.

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::validateAttributes): Add condition to disable antialiasing & packedDepthStencilExtension for GLES.
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):

Following APIs looked shareable so that moved into GC3DOpenGLCommon.cpp.
(WebCore::GraphicsContext3D::prepareTexture):
(WebCore):
(WebCore::GraphicsContext3D::readRenderingResults):
(WebCore::GraphicsContext3D::reshape):
(WebCore::GraphicsContext3D::bindFramebuffer):
(WebCore::GraphicsContext3D::copyTexImage2D):
(WebCore::GraphicsContext3D::copyTexSubImage2D):
(WebCore::GraphicsContext3D::getActiveUniform):
(WebCore::GraphicsContext3D::readPixels):

Added a missing period at the end of comment line.
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::getActiveAttrib):
(WebCore::GraphicsContext3D::uniform2fv):
(WebCore::GraphicsContext3D::uniform3fv):
(WebCore::GraphicsContext3D::uniform4fv):
(WebCore::GraphicsContext3D::uniform2iv):
(WebCore::GraphicsContext3D::uniform3iv):
(WebCore::GraphicsContext3D::uniform4iv):
(WebCore::GraphicsContext3D::uniformMatrix2fv):
(WebCore::GraphicsContext3D::uniformMatrix3fv):
(WebCore::GraphicsContext3D::uniformMatrix4fv):
(WebCore::GraphicsContext3D::texSubImage2D):

  • platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:

(WebCore::GraphicsContext3D::reshapeFBOs): Same with the above.
(WebCore::GraphicsContext3D::resolveMultisamplingIfNecessary): Same with the above.

Brief explanation about what the differences are between gl and gles.
(WebCore::GraphicsContext3D::renderbufferStorage): Removed codes for converting GLES parameter to GL parameter.
(WebCore::GraphicsContext3D::getIntegerv): Removed codes that emulate GLES.
(WebCore::GraphicsContext3D::texImage2D): Removed codes for converting GLES parameter to GL parameter.

09:33 Changeset [106814] by philn@webkit.org
  • 3 edits in trunk/Tools

[webkitpy] cpp style-checker complains about readability/naming in GStreamer elements source files
https://bugs.webkit.org/show_bug.cgi?id=77866

Reviewed by Martin Robinson.

  • Scripts/webkitpy/style/checker.py: Ignore readability/naming

errors in some gstreamer source code files defining new GStreamer elements.

  • Scripts/webkitpy/style/checker_unittest.py:

(GlobalVariablesTest.test_path_rules_specifier):

09:31 Changeset [106813] by senorblanco@chromium.org
  • 1 edit in branches/chromium/1025/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp

Merge 106732 - [chromium] Fix multi-second hangs in compositor invalidating large layers
https://bugs.webkit.org/show_bug.cgi?id=77774

Reviewed by James Robinson.

Correctness covered by existing tests.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::pushPropertiesTo):
Remove tiles from the tiler when they are invalid (ie., no longer have
texture backing).
(WebCore::TiledLayerChromium::invalidateRect):
Instead of iterating over the tile indices (which may be very large),
iterate over the tile hash map instead.

TBR=senorblanco@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9333004

09:05 Changeset [106812] by jesus@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] http/tests/loading/state-object-security-exception.html fails
https://bugs.webkit.org/show_bug.cgi?id=62731

Rubber stamped by Csaba Osztrogonác.

Unskipping tests that were kept as skipped even after
https://bugs.webkit.org/show_bug.cgi?id=42333 was fixed.

  • platform/wk2/Skipped:
08:57 Changeset [106811] by apavlov@chromium.org
  • 8 edits in trunk/Source/WebCore

Web Inspector: [Meta] Allow emulation of touch events
https://bugs.webkit.org/show_bug.cgi?id=77096

Reviewed by Pavel Feldman.

This is the inspector part of the change, core part implementation tracked in bug 77105.

  • English.lproj/localizedStrings.js:
  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:

(DOMAgentState):
(WebCore::InspectorDOMAgent::clearFrontend):
(WebCore::InspectorDOMAgent::restore):
(WebCore):
(WebCore::InspectorDOMAgent::updateTouchEventEmulationInDocuments):
(WebCore::InspectorDOMAgent::setTouchEmulationEnabled):

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype._captureDOM):
(WebInspector.DOMAgent.prototype._emulateTouchEventsChanged):

  • inspector/front-end/Settings.js:

(WebInspector.Settings):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):

08:39 Changeset [106810] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[Blackberry] Non-supported about: operations never stops loading
https://bugs.webkit.org/show_bug.cgi?id=76366

Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-02-06
Reviewed by Rob Buis.

If user typed a non-supported "about:" scheme such as "about:nonsupport",
the loadAboutURL() function in NetworkManger should recognize and handle it as
an error of invalid url.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::loadAboutURL):
(WebCore::NetworkJob::handleAbout):

  • platform/network/blackberry/NetworkJob.h:

(NetworkJob):

  • platform/network/blackberry/NetworkManager.cpp:

(WebCore::NetworkManager::startJob):

08:26 Changeset [106809] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Remove unused disabledComputedProperties from methods in StylesSidebarPane
https://bugs.webkit.org/show_bug.cgi?id=77876

Reviewed by Pavel Feldman.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._refreshUpdate):
(WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._markUsedProperties):
(WebInspector.StylesSidebarPane.prototype._refreshSectionsForStyleRules):
(WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
(WebInspector.StylePropertiesSection.prototype.onpopulate):
(WebInspector.ComputedStylePropertiesSection):
(WebInspector.ComputedStylePropertiesSection.prototype._isPropertyInherited):

08:20 Changeset [106808] by loislo@chromium.org
  • 5 edits in trunk

Web Inspector: Redesign summary view / retaining tree contents
https://bugs.webkit.org/show_bug.cgi?id=77870

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-02-06
Reviewed by Pavel Feldman.

  1. Make object IDs less contrast.
  2. Put array indices in [].
  3. Do not write type if it's just "Object".

Source/WebCore:

  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotGenericObjectNode.prototype._createObjectCell):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
(WebInspector.HeapSnapshotObjectNode.prototype._emptyData):
(WebInspector.HeapSnapshotObjectNode.prototype._enhanceData):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):
(WebInspector.HeapSnapshotConstructorNode.prototype.get data):

  • inspector/front-end/heapProfiler.css:

(.detailed-heapshot-view .console-formatted-id):
(.detailed-heapshot-view td.object-column span.grayed):

LayoutTests:

  • inspector/profiler/detailed-heapshots-test.js:

(initialize_DetailedHeapshotTest.):
(initialize_DetailedHeapshotTest):

08:10 Changeset [106807] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebCore

[Texmap][Qt] Avoid an image copy when uploading textures in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=77748

Reviewed by Kenneth Rohde Christiansen.

Use QPixmap::buffer() API to get access to the QPixmap's pixels without implicit copies.

Instrumentation shows that the deep image copies created from TextureMapperGL are
eliminated.

  • platform/graphics/opengl/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::updateContents):

08:05 Changeset [106806] by tonyg@chromium.org
  • 2 edits in trunk/Source/WebCore

LayoutTest failures on r106797
https://bugs.webkit.org/show_bug.cgi?id=77868

Call suspendIfNeeded from subclass of IDBRequest, IDBVersionChangeRequest.

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-06
Reviewed by Simon Hausmann.

  • storage/IDBVersionChangeRequest.cpp:

(WebCore::IDBVersionChangeRequest::create):

06:54 Changeset [106805] by carlosgc@webkit.org
  • 2 edits in trunk/Tools

[GTK] Make sure html_dir exists before calling gtkdoc-rebase
https://bugs.webkit.org/show_bug.cgi?id=77869

Reviewed by Philippe Normand.

  • gtk/gtkdoc.py:

(GTKDoc.rebase_installed_docs): Check html_dir exists.

06:18 Changeset [106804] by noam.rosenthal@nokia.com
  • 3 edits in trunk/Source/WebCore

[Qt] Implement ImageBuffer::copyImage(ImageBuffer::DontCopyBackingStore)
https://bugs.webkit.org/show_bug.cgi?id=77689

Reviewed by Kenneth Rohde Christiansen.

Use StillImageQt::createForRendering when using DontCopyBackingStore.
Enable DontCopyBackingStore in TextureMapperNode.
This removes deep copies resulting from the use of ImageBuffer.

Instrumentation shows that deep image copies resulted from ImageBuffer are eliminated.

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::ImageBuffer::copyImage):

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::renderContent):

06:07 Changeset [106803] by commit-queue@webkit.org
  • 7 edits in trunk/Source

WebGestureEvent can not encode delta and area.
https://bugs.webkit.org/show_bug.cgi?id=77728

Source/WebCore:

Add area field to PlatformGestureEvent.

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-06
Reviewed by Kenneth Rohde Christiansen.

  • platform/PlatformGestureEvent.h:

(WebCore::PlatformGestureEvent::PlatformGestureEvent):
(WebCore::PlatformGestureEvent::area):

Source/WebKit2:

Support delta and area fields in WebGestureEvent, and send area with Qt tap gesture.

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-06
Reviewed by Kenneth Rohde Christiansen.

  • Shared/WebEvent.h:

(WebKit::WebGestureEvent::area):
(WebKit::WebGestureEvent::delta):

  • Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformGestureEvent::WebKit2PlatformGestureEvent):

  • Shared/WebGestureEvent.cpp:

(WebKit::WebGestureEvent::WebGestureEvent):
(WebKit::WebGestureEvent::encode):
(WebKit::WebGestureEvent::decode):

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::handleSingleTapEvent):

05:55 Changeset [106802] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry]Use extension for a mimetype as the suggested extension
if the url file doesn't have an extension.
https://bugs.webkit.org/show_bug.cgi?id=76779

Patch by Charles Wei <charles.wei@torchmobile.com.cn> on 2012-02-06
Reviewed by Antonio Gomes.

No new tests.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::sendResponseIfNeeded):

05:24 Changeset [106801] by hans@chromium.org
  • 4 edits in trunk/LayoutTests

Speech input: fix fast/speech/bubble-position.html
https://bugs.webkit.org/show_bug.cgi?id=77732

Reviewed by Tony Gentilcore.

There is no need for the test to check the pixel-exact position of the
rect, since that seems to vary a little between platforms.
The point of the test is to check that the rect is within the iframe,
so let's do that.

  • fast/speech/bubble-position-expected.txt:
  • fast/speech/bubble-position.html:
05:11 Changeset [106800] by jocelyn.turcotte@nokia.com
  • 14 edits
    9 deletes in trunk/Source/WebKit2

[Qt][WK2] Remove TiledDrawingArea and dependencies.
https://bugs.webkit.org/show_bug.cgi?id=71681

Reviewed by Kenneth Rohde Christiansen.

Tiled drawing surface functionality got converted to LayerTree.
TiledDrawingArea and its dependencies are not used by any port anymore.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • Shared/DrawingAreaInfo.h:
  • Target.pri:
  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPagePrivate::QQuickWebPagePrivate):

  • UIProcess/API/qt/qquickwebpage_p.h:
  • UIProcess/API/qt/qquickwebpage_p_p.h:

(QQuickWebPagePrivate):

  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxy.messages.in:
  • UIProcess/TiledDrawingAreaProxy.cpp: Removed.
  • UIProcess/TiledDrawingAreaProxy.h: Removed.
  • UIProcess/qt/QtSGTileNode.cpp: Removed.
  • UIProcess/qt/QtSGTileNode.h: Removed.
  • UIProcess/qt/QtSGUpdateQueue.cpp: Removed.
  • UIProcess/qt/QtSGUpdateQueue.h: Removed.
  • UIProcess/qt/TiledDrawingAreaProxyQt.cpp: Removed.
  • WebProcess/WebPage/DrawingArea.cpp:

(WebKit::DrawingArea::create):

  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/DrawingArea.messages.in:
  • WebProcess/WebPage/TiledDrawingArea.cpp: Removed.
  • WebProcess/WebPage/TiledDrawingArea.h: Removed.
  • WebProcess/WebPage/WebPage.h:

(WebPage):

05:09 Changeset [106799] by jocelyn.turcotte@nokia.com
  • 14 edits in trunk

[Qt] Don't version QtWebKit.experimental.
https://bugs.webkit.org/show_bug.cgi?id=77739

Reviewed by Tor Arne Vestbø.

Source/WebKit/qt:

We won't support previous versions of the experimental API.

  • declarative/experimental/plugin.cpp:

Source/WebKit2:

  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_itemSelector.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_messaging.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_download.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_geopermission.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_javaScriptDialogs.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_navigationHistory.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml:

Tools:

  • MiniBrowser/qt/qml/BrowserWindow.qml:
04:56 Changeset [106798] by haraken@chromium.org
  • 52 edits in trunk/Source/WebCore

Rename [HasIndexGetter], [HasNameGetter] and [HasCustomIndexSetter] IDLs
https://bugs.webkit.org/show_bug.cgi?id=77848

Reviewed by Adam Barth.

For naming consistency with [CustomGetter] and [CustomSetter],
this patch renames the following IDLs:

[HasIndexGetter] => [IndexedGetter] (Remove "Has". This IDL is for "indexed" properties
in the Web IDL: http://dev.w3.org/2006/webapi/WebIDL/#idl-indexed-properties)
[HasCustomIndexSetter] => [CustomIndexedSetter] (Ditto.)
[HasNameGetter] => [NamedGetter] (Remove "Has". This IDL is for "named" properties
in the Web IDL: http://dev.w3.org/2006/webapi/WebIDL/#idl-named-properties)

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateImplementationIndexer):
(GenerateImplementationNamedPropertyGetter):

  • bindings/scripts/test/TestEventTarget.idl: No change in run-bindings-tests results.
  • bindings/scripts/test/TestTypedArray.idl: Ditto.
  • Modules/gamepad/GamepadList.idl:
  • css/CSSRuleList.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSValueList.idl:
  • css/MediaList.idl:
  • css/StyleSheetList.idl:
  • css/WebKitCSSFilterValue.idl:
  • css/WebKitCSSKeyframesRule.idl:
  • css/WebKitCSSTransformValue.idl:
  • dom/ClientRectList.idl:
  • dom/DOMStringList.idl:
  • dom/DOMStringMap.idl:
  • dom/DataTransferItemList.idl:
  • dom/NamedNodeMap.idl:
  • dom/NodeList.idl:
  • dom/TouchList.idl:
  • fileapi/EntryArray.idl:
  • fileapi/EntryArraySync.idl:
  • fileapi/FileList.idl:
  • html/DOMSettableTokenList.idl:
  • html/DOMTokenList.idl:
  • html/HTMLAllCollection.idl:
  • html/HTMLCollection.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLOptionsCollection.idl:
  • html/HTMLPropertiesCollection.idl:
  • html/HTMLSelectElement.idl:
  • html/TextTrackCueList.idl:
  • html/canvas/CanvasPixelArray.idl:
  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • html/canvas/Uint8ClampedArray.idl:
  • html/track/TextTrackList.idl:
  • mediastream/MediaStreamList.idl:
  • mediastream/MediaStreamTrackList.idl:
  • page/SpeechInputResultList.idl:
  • page/WebKitAnimationList.idl:
  • plugins/DOMMimeTypeArray.idl:
  • plugins/DOMPlugin.idl:
  • plugins/DOMPluginArray.idl:
  • storage/Storage.idl:
04:36 Changeset [106797] by commit-queue@webkit.org
  • 35 edits
    4 adds in trunk

Source/WebCore: Ensure timers and other active DOM objects do not fire in suspended documents.
https://bugs.webkit.org/show_bug.cgi?id=53733

ScriptExecutionContext now remembers it has suspended active DOM objects
and suspends all newly installed active DOM objects as well.

All create-calls active DOM objects now calls the post constructor method
suspendIfNeeded that updates the suspend state. It is post constructor
because the suspend/resume functions are virtual and thus can not be called
from constructors.

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-06
Reviewed by Mihai Parparita.

Test: fast/events/suspend-timers.html

  • Modules/intents/IntentRequest.cpp:

(WebCore::IntentRequest::create):

  • bindings/generic/ActiveDOMCallback.cpp:

(WebCore::ActiveDOMCallback::ActiveDOMCallback):

  • dom/ActiveDOMObject.cpp:

(WebCore::ActiveDOMObject::ActiveDOMObject):
(WebCore::ActiveDOMObject::~ActiveDOMObject):
(WebCore::ActiveDOMObject::suspendIfNeeded):

  • dom/ActiveDOMObject.h:

(WebCore::ActiveDOMObject::suspendIfNeededCalled):

  • dom/DocumentEventQueue.cpp:

(WebCore::DocumentEventQueue::DocumentEventQueue):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::ScriptExecutionContext):
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
(WebCore::ScriptExecutionContext::stopActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjectIfNeeded):

  • dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::activeDOMObjectsAreSuspended):

  • fileapi/DOMFileSystem.cpp:

(WebCore::DOMFileSystem::create):

  • fileapi/FileReader.cpp:

(WebCore::FileReader::create):

  • fileapi/FileReader.h:
  • fileapi/FileWriter.cpp:

(WebCore::FileWriter::create):

  • fileapi/FileWriter.h:
  • history/CachedFrame.cpp:

(WebCore::CachedFrame::CachedFrame):

  • html/HTMLAudioElement.cpp:

(WebCore::HTMLAudioElement::create):

  • html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::create):

  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::create):

  • mediastream/PeerConnection.cpp:

(WebCore::PeerConnection::create):

  • notifications/Notification.cpp:

(WebCore::Notification::create):

  • notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::create):

  • notifications/NotificationCenter.h:
  • page/DOMTimer.cpp:

(WebCore::DOMTimer::install):
(WebCore::DOMTimer::fired):

  • page/EventSource.cpp:

(WebCore::EventSource::create):

  • page/SuspendableTimer.cpp:

(WebCore::SuspendableTimer::SuspendableTimer):

  • storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::create):

  • storage/IDBRequest.cpp:

(WebCore::IDBRequest::create):

  • storage/IDBTransaction.cpp:

(WebCore::IDBTransaction::create):

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::create):

  • websockets/WebSocket.cpp:

(WebCore::WebSocket::create):

  • websockets/WebSocket.h:
  • workers/SharedWorker.cpp:

(WebCore::SharedWorker::create):

  • workers/Worker.cpp:

(WebCore::Worker::create):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::create):

LayoutTests: Test that timers do not fire from subframes of suspended documents.
https://bugs.webkit.org/show_bug.cgi?id=53733

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-06
Reviewed by Mihai Parparita.

  • fast/events/resources/suspend-subframe-1.html: Added.
  • fast/events/resources/suspend-subframe-2.html: Added.
  • fast/events/suspend-timers-expected.txt: Added.
  • fast/events/suspend-timers.html: Added.
  • platform/chromium/test_expectations.txt:
04:33 Changeset [106796] by paroga@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed WinCE build fix after r106197.

  • tools/CodeProfiling.cpp:

(JSC::CodeProfiling::notifyAllocator): getenv() isn't supported by WinCE. Don't call it.

03:18 Changeset [106795] by philn@webkit.org
  • 2 edits
    1 add in trunk/Source/WebCore

Adding FFTFrameGStreamer.cpp that I forgot to commit
in r106537. That new file was reviewed in https://bugs.webkit.org/show_bug.cgi?id=73545.

  • platform/audio/gstreamer/FFTFrameGStreamer.cpp: Added.
02:39 Changeset [106794] by hayato@chromium.org
  • 13 edits
    5 adds in trunk

Add <shadow> element, which is guarded by SHADOW_DOM flag.
https://bugs.webkit.org/show_bug.cgi?id=76435

Reviewed by Dimitri Glazkov.

Test: fast/dom/shadow/shadow-element.html

Source/WebCore:

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLTagNames.in:
  • html/shadow/HTMLShadowElement.cpp: Added.

(WebCore):
(WebCore::HTMLShadowElement::HTMLShadowElement):
(WebCore::HTMLShadowElement::create):
(WebCore::HTMLShadowElement::~HTMLShadowElement):

  • html/shadow/HTMLShadowElement.h: Added.

(WebCore):
(HTMLShadowElement):

  • html/shadow/HTMLShadowElement.idl: Added.

LayoutTests:

  • fast/dom/shadow/shadow-element-expected.txt: Added.
  • fast/dom/shadow/shadow-element.html: Added.
02:26 Changeset [106793] by carlosgc@webkit.org
  • 4 edits in trunk

[GTK] Update NEWS and configure.ac for 1.7.5 release
https://bugs.webkit.org/show_bug.cgi?id=77859

Reviewed by Philippe Normand.

.:

  • configure.ac: Bumped version number.

Source/WebKit/gtk:

  • NEWS: Added release notes for 1.7.5.
02:18 Changeset [106792] by commit-queue@webkit.org
  • 11 edits
    2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=76995.
WebKit fails IETC :indeterminate and input type=radio test.

All input types should respect indeterminate property(getter and setter). This is true with other browsers.
Indeterminate appearance for radio input type is supported by IOS platform. Webkit need not support indeterminate appearance
for radio input type on other platforms.

Patch by Joe Thomas <joethomas@motorola.com> on 2012-02-06
Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/forms/indeterminate-input-types.html

  • html/CheckboxInputType.cpp:

(WebCore::CheckboxInputType::supportsIndeterminateAppearance): Checks indeterminate appearance is supported.
(WebCore):

  • html/CheckboxInputType.h:

(CheckboxInputType):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setIndeterminate): Removed the check isCheckable().
(WebCore::HTMLInputElement::isIndeterminate): Checks indeterminate appearance is supported.
(WebCore):

  • html/HTMLInputElement.h:

(HTMLInputElement):

  • html/InputType.cpp:

(WebCore::InputType::supportsIndeterminateAppearance): Checks indeterminate appearance is supported.
(WebCore):

  • html/InputType.h:

(InputType):

  • html/RadioInputType.cpp:

(WebCore::RadioInputType::willDispatchClick): Indeterminate related code is moved to IOS specific.
(WebCore::RadioInputType::didDispatchClick): Ditto.
(WebCore::RadioInputType::supportsIndeterminateAppearance): Checks indeterminate appearance is supported.
(WebCore):

  • html/RadioInputType.h:

(RadioInputType):

LayoutTests:

  • fast/forms/indeterminate-input-types-expected.txt: Added.
  • fast/forms/indeterminate-input-types.html: Added.
  • fast/forms/indeterminate-radio.html:
02:02 Changeset [106791] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Remove unused variable in PluginViewBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=77847

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-02-06
Reviewed by Kentaro Hara.

No changes in behavior, so no new tests.

  • plugins/blackberry/PluginViewBlackBerry.cpp:

(WebCore::PluginView::updatePluginWidget):

01:58 Changeset [106790] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

[BlackBerry] Remove unused variable in BackingStore
https://bugs.webkit.org/show_bug.cgi?id=77851

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-02-06
Reviewed by Kentaro Hara.

  • blackberry/Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::blitContents):

01:40 Changeset [106789] by zimmermann@webkit.org
  • 2 edits in trunk/LayoutTests

2012-02-06 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Switch to unix file endings and at a trailing newline - hopefully the bots will accept my follow up patch then.

  • svg/filters/invalidate-on-child-layout.svg:
01:29 Changeset [106788] by carlosgc@webkit.org
  • 9 edits in trunk

[GTK] Fix several gtkdoc-fixxref warnings
https://bugs.webkit.org/show_bug.cgi?id=77613

Reviewed by Martin Robinson.

Source/WebKit/gtk:

  • docs/webkitgtk-docs.sgml: Remove webkitspellcheckerenchant

section.

  • docs/webkitgtk-sections.txt: Remove webkitspellcheckerenchant

symbols and move WebKitWebNavigationReason from the private
section to the global section.

  • webkit/webkitwebnavigationaction.h: Document

WebKitWebNavigationReason enum.

Source/WebKit2:

  • UIProcess/API/gtk/WebKitWindowProperties.cpp: Fix a typo, a

colon was missing in WebKitWebView::ready-to-show.

Tools:

  • gtk/generate-gtkdoc:

(get_webkit1_options): Add webkitspellcheckerenchant.* to the list
of ignored files, since it's private.

  • gtk/gtkdoc.py:

(GTKDoc._ignored_files_basenames): Helper function that returns a
string with the list of ignored files basenames separated by a
spaces, as expected by several gtkdoc commands.
(GTKDoc._run_gtkdoc_scan): Use _ignored_files_basenames for
--ignore-headers option.
(GTKDoc._run_gtkdoc_mkdb): Use _ignored_files_basenames for
--ignore-files option.

01:27 Changeset [106787] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Fix CallArgument type in Inspector.json
https://bugs.webkit.org/show_bug.cgi?id=77839

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-06
Reviewed by Yury Semikhatsky.

Protocol description is fixed: field type is changed. No changes to
program code are necessary.

  • inspector/Inspector-0.1.json:
  • inspector/Inspector-1.0.json:
  • inspector/Inspector.json:
01:23 Changeset [106786] by carlosgc@webkit.org
  • 5 edits in trunk/Tools

[GTK] Fix xrefs after installing API documentation
https://bugs.webkit.org/show_bug.cgi?id=77551

Reviewed by Martin Robinson.

  • GNUmakefile.am: Call generate-gtkdoc --rebase after installing

api docs.

  • gtk/common.py:

(prefix_of_pkg_config_file): Get the prefix variable of the given
pkg-config file.
(gtk_version_of_pkg_config_file): Get the gtk version required by
the given pkg-config file.

  • gtk/generate-gtkdoc: Add --rebase command line option to rebase

installed documentation.
(get_gtkdoc_module_paths): Get paths where API doc is installed
for the dependencies of the given pkg-config file.
(get_common_xref_deps): Get API doc directories of dependencies
common to WebKit1 and WebKit2.
(get_webkit2_options): Add cross_reference_deps option.
(get_webkit1_options): Ditto
(rebase_installed_docs): Helper function to create a generator for
the given pkg-config file and options and call rebase_installed_docs.

  • gtk/gtkdoc.py:

(GTKDoc.init): Initialize cross_reference_deps.
(GTKDoc._run_gtkdoc_fixxref): Add API doc directories of
dependencies.
(GTKDoc.rebase_installed_docs): Call gtkdoc-rebase to fix xref
links of installed documentation.
(PkgConfigGTKDoc.init): Get the prefix from the pkg-config
file.

01:22 Changeset [106785] by abarth@webkit.org
  • 4 edits in trunk/LayoutTests

Layout Test http/tests/security/xssAuditor/dom-write-innerHTML.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=67538

Reviewed by Kentaro Hara.

Try to fix the flakiness in this test by kicking off the <img> load
before the load event has fired for the inner frame. That way, the
load event for the main frame will be delayed until the image finishes
loading (and its error handler has fired), removing the need for the
setTimeout.

  • http/tests/security/xssAuditor/dom-write-innerHTML.html:
  • http/tests/security/xssAuditor/resources/echo-dom-write-innerHTML.html:
  • platform/chromium/test_expectations.txt:
01:07 Changeset [106784] by sergio@webkit.org
  • 4 edits in trunk/Tools

Incorrect statistics shown when running run-webkit-tests with --repeat-each or --iterations
https://bugs.webkit.org/show_bug.cgi?id=77672

Reviewed by Dirk Pranke.

Test repetitions must be taken into account when working out
the statistics shown by run-webkit-tests.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.prepare_lists_and_print_output):
(Manager._print_result_summary):

  • Scripts/webkitpy/layout_tests/models/result_summary.py:

(ResultSummary.init):
(ResultSummary.add):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_repeat_each_iterations_num_tests):

00:56 Changeset [106783] by barraclough@apple.com
  • 24 edits in trunk/Source

Remove JSObject defineGetter/defineSetter lookupGetter/lookupSetter
https://bugs.webkit.org/show_bug.cgi?id=77451

Reviewed by Sam Weinig.

These can now all be implemented in terms of defineOwnProperty & getPropertyDescriptor.
Also remove initializeGetterSetterProperty, since this is equivalent to putDirectAccessor.

Source/JavaScriptCore:

(JSC::DebuggerActivation::defineOwnProperty):

  • debugger/DebuggerActivation.h:

(DebuggerActivation):

  • runtime/ClassInfo.h:

(MethodTable):
(JSC):

  • runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::finishCreation):

  • runtime/JSCell.cpp:

(JSC):

  • runtime/JSCell.h:

(JSCell):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::getOwnPropertyDescriptor):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::defineOwnProperty):
(JSC):

  • runtime/JSGlobalObject.h:

(JSGlobalObject):

  • runtime/JSObject.cpp:

(JSC):

  • runtime/JSObject.h:

(JSObject):

  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncDefineGetter):
(JSC::objectProtoFuncDefineSetter):
(JSC::objectProtoFuncLookupGetter):
(JSC::objectProtoFuncLookupSetter):

Source/WebCore:

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore):
(WebCore::JSDOMWindow::defineOwnProperty):

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore):

  • bindings/js/JSDOMWindowShell.h:

(JSDOMWindowShell):

  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::defineOwnProperty):
(WebCore::JSLocationPrototype::defineOwnProperty):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

  • page/DOMWindow.idl:
  • page/Location.idl:

Source/WebKit/qt:

  • Api/qwebframe.cpp:

(QWebFramePrivate::addQtSenderToGlobalObject):

00:51 Changeset [106782] by carlosgc@webkit.org
  • 5 edits in trunk/Source

Source/JavaScriptCore: Unreviewed. Fix make distcheck.

  • GNUmakefile.list.am: Add missing files.

Source/WebCore: Unreviewed. Fix make distrcheck.

  • GNUmakefile.am: Fix typo in inspector json file.
  • GNUmakefile.list.am: Remove non existent file.
00:38 Changeset [106781] by pfeldman@chromium.org
  • 3 edits
    2 copies in branches/chromium/1025

Merge 106638 - Web Inspector: preserve elements panel selection upon node drag'n'drop
https://bugs.webkit.org/show_bug.cgi?id=77722

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: inspector/elements/move-node.html

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype._markRevision):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype._ondrop):
(WebInspector.ElementsTreeOutline.prototype._doMove.callback):
(WebInspector.ElementsTreeOutline.prototype._doMove):

LayoutTests:

  • inspector/elements/move-node-expected.txt: Added.
  • inspector/elements/move-node.html: Added.

TBR=pfeldman@chromium.org
BUG=112578
Review URL: https://chromiumcodereview.appspot.com/9328038

00:04 Changeset [106780] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2012-02-06 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Qt minimal compilation fix after r106777.

  • inspector/InspectorDatabaseAgent.h: added missing #if ENABLED guards.

02/05/12:

23:54 Changeset [106779] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: REGRESSION detached dom nodes aren't highlighted
https://bugs.webkit.org/show_bug.cgi?id=77829

This functionality was lost when I replaced (Native roots) with (Detached DOM trees) on v8 side.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.get isDetachedDOMTreesRoot):
(WebInspector.HeapSnapshot.prototype._markDetachedDOMTreeNodes):

23:52 Changeset [106778] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: get rid of artificial heap snapshot nodes from the retaining tree.
https://bugs.webkit.org/show_bug.cgi?id=77850

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotObjectNode):
(WebInspector.HeapSnapshotObjectNode.prototype.updateHasChildren):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.get isArtificial):
(WebInspector.HeapSnapshot.prototype._init):

23:39 Changeset [106777] by yurys@chromium.org
  • 27 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: switch domain agents to formal interfaces in BackendDispatcher
https://bugs.webkit.org/show_bug.cgi?id=77444

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-05
Reviewed by Yury Semikhatsky.

All agent code is switched to formal interfaces. Actual agent class
names and includes are dropped from InspectorBackendDispatcher.h.

  • inspector/CodeGeneratorInspector.py:

(DomainNameFixes.get_fixed_data):
(Generator.go):

  • inspector/InspectorAgent.h:
  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getMatchedStylesForNode):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::highlightNode):

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

  • inspector/InspectorDOMDebuggerAgent.h:
  • inspector/InspectorDOMStorageAgent.h:
  • inspector/InspectorDatabaseAgent.h:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::continueToLocation):

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

  • inspector/InspectorFileSystemAgent.h:
  • inspector/InspectorIndexedDBAgent.h:
  • inspector/InspectorMemoryAgent.h:
  • inspector/InspectorPageAgent.h:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::getProfile):
(WebCore::InspectorProfilerAgent::removeProfile):

  • inspector/InspectorProfilerAgent.h:

(InspectorProfilerAgent):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::setExtraHTTPHeaders):

  • inspector/InspectorResourceAgent.h:

(InspectorResourceAgent):

  • inspector/InspectorRuntimeAgent.h:
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::start):

  • inspector/InspectorTimelineAgent.h:

(InspectorTimelineAgent):

  • inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::sendMessageToWorker):

  • inspector/InspectorWorkerAgent.h:

(InspectorWorkerAgent):

23:06 Changeset [106776] by haraken@chromium.org
  • 52 edits in trunk/Source/WebCore

Rename [TreatNullAs=EmptyString] to [TreatNullAs=NullString],
[TreatUndefinedAs=EmptyString] to [TreatUndefinedAs=NullString]
https://bugs.webkit.org/show_bug.cgi?id=77611

Reviewed by Adam Barth.

While the Web IDL spec requires [TreatNullAs=EmptyString] and [TreatUndefinedAs=EmptyString],
the current WebKit treats them as (not an empty string but) a null string.
To avoid confusion, this patch renames [TreatNullAs=EmptyString] to [TreatNullAs=NullString],
and [TreatUndefinedAs=EmptyString] to [TreatUndefinedAs=NullString].
(Eventually we should fix WebKit so that it uses an empty string and then
rename them to [TreatNullAs=EmptyString] and [TreatUndefinedAs=EmptyString].)

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm: Added FIXME.

(JSValueToNative):

  • bindings/scripts/CodeGeneratorV8.pm: Ditto.

(GetNativeTypeFromSignature):

  • bindings/scripts/test/TestObj.idl:
  • css/CSSCharsetRule.idl:
  • css/CSSPageRule.idl:
  • css/CSSRule.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSStyleRule.idl:
  • css/CSSValue.idl:
  • css/MediaList.idl:
  • css/WebKitCSSKeyframesRule.idl:
  • dom/Attr.idl:
  • dom/CharacterData.idl:
  • dom/DOMImplementation.idl:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/NamedNodeMap.idl:
  • dom/Node.idl:
  • dom/ProcessingInstruction.idl:
  • dom/ShadowRoot.idl:
  • fileapi/Blob.idl:
  • fileapi/DirectoryEntry.idl:
  • fileapi/DirectoryEntrySync.idl:
  • fileapi/Entry.idl:
  • fileapi/EntrySync.idl:
  • fileapi/WebKitBlobBuilder.idl:
  • html/HTMLAnchorElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLCanvasElement.idl:
  • html/HTMLDocument.idl:
  • html/HTMLElement.idl:
  • html/HTMLFieldSetElement.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLKeygenElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLOutputElement.idl:
  • html/HTMLScriptElement.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/HTMLTitleElement.idl:
  • html/canvas/CanvasRenderingContext2D.idl:
  • page/Console.idl:
  • page/DOMWindow.idl:
  • storage/StorageEvent.idl:
  • svg/SVGAngle.idl:
  • svg/SVGElement.idl:
  • svg/SVGLength.idl:
  • svg/SVGScriptElement.idl:
22:44 Changeset [106775] by fpizlo@apple.com
  • 15 edits
    2 adds in trunk/Source/JavaScriptCore

DFG's child references from one node to another should have room for type information
https://bugs.webkit.org/show_bug.cgi?id=77797

Reviewed by Oliver Hunt.

The DFG::Node::child fields now contain both a DFG::NodeIndex (which is just an unsigned)
and a DFG::UseKind (which is currently an effectively empty enum). They are encapsulated
together as a DFG::NodeUse, which can in most cases still be used as an index (for
example DFG::Graph, AbstractState, and SpeculativeJIT all accept NodeUse in most places
where they really want a NodeIndex).

The NodeUse stores both the index and the UseKind without bloating the memory usage of
DFG::Node, since we really don't need full 32 bits for the NodeIndex (a DFG::Node is
roughly 11 words, so if we assume that we never want to use more than 1GB to DFG compile
something - likely a sensible assumption! - then we will only be able to have room for
about 24 million nodes, which means we only need about 24.5 bits for the node index).
Currently the DFG::NodeUse allocates 4 bits for the UseKind and 28 bits for the index,
but stores the index as a signed number to make NoNode work naturally. Hence we really
just have 27 bits for the index.

This is performance-neutral on all benchmarks we track.

(JSC::DFG::AbstractState::forNode):
(AbstractState):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::toInt32):
(JSC::DFG::ByteCodeParser::addVarArgChild):
(JSC::DFG::ByteCodeParser::processPhiStack):

  • dfg/DFGCommon.h:
  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(DFG):

  • dfg/DFGGraph.h:

(Graph):
(JSC::DFG::Graph::operator[]):
(JSC::DFG::Graph::at):
(JSC::DFG::Graph::ref):
(JSC::DFG::Graph::deref):
(JSC::DFG::Graph::clearAndDerefChild1):
(JSC::DFG::Graph::clearAndDerefChild2):
(JSC::DFG::Graph::clearAndDerefChild3):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::getPrediction):

  • dfg/DFGNode.h:

(JSC::DFG::Node::Node):
(JSC::DFG::Node::child1):
(JSC::DFG::Node::child1Unchecked):
(JSC::DFG::Node::child2):
(JSC::DFG::Node::child3):
(JSC::DFG::Node::firstChild):
(JSC::DFG::Node::numChildren):
(JSC::DFG::Node::dumpChildren):
(Node):

  • dfg/DFGNodeReferenceBlob.h: Added.

(DFG):
(NodeReferenceBlob):
(JSC::DFG::NodeReferenceBlob::NodeReferenceBlob):
(JSC::DFG::NodeReferenceBlob::child):
(JSC::DFG::NodeReferenceBlob::child1):
(JSC::DFG::NodeReferenceBlob::child2):
(JSC::DFG::NodeReferenceBlob::child3):
(JSC::DFG::NodeReferenceBlob::child1Unchecked):
(JSC::DFG::NodeReferenceBlob::initialize):
(JSC::DFG::NodeReferenceBlob::firstChild):
(JSC::DFG::NodeReferenceBlob::setFirstChild):
(JSC::DFG::NodeReferenceBlob::numChildren):
(JSC::DFG::NodeReferenceBlob::setNumChildren):

  • dfg/DFGNodeUse.h: Added.

(DFG):
(NodeUse):
(JSC::DFG::NodeUse::NodeUse):
(JSC::DFG::NodeUse::indexUnchecked):
(JSC::DFG::NodeUse::index):
(JSC::DFG::NodeUse::setIndex):
(JSC::DFG::NodeUse::useKind):
(JSC::DFG::NodeUse::setUseKind):
(JSC::DFG::NodeUse::isSet):
(JSC::DFG::NodeUse::operator!):
(JSC::DFG::NodeUse::operator==):
(JSC::DFG::NodeUse::operator!=):
(JSC::DFG::NodeUse::shift):
(JSC::DFG::NodeUse::makeWord):
(JSC::DFG::operator==):
(JSC::DFG::operator!=):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::vote):
(JSC::DFG::Propagator::toDouble):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::canonicalize):
(JSC::DFG::Propagator::startIndex):
(JSC::DFG::Propagator::globalVarLoadElimination):
(JSC::DFG::Propagator::getByValLoadElimination):
(JSC::DFG::Propagator::getByOffsetLoadElimination):
(JSC::DFG::Propagator::performSubstitution):
(JSC::DFG::Propagator::performNodeCSE):

  • dfg/DFGScoreBoard.h:

(JSC::DFG::ScoreBoard::use):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::useChildren):
(JSC::DFG::SpeculativeJIT::writeBarrier):
(JSC::DFG::SpeculativeJIT::nonSpeculativeStrictEq):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileSoftModulo):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileArithSub):
(JSC::DFG::SpeculativeJIT::compileStrictEqForConstant):
(JSC::DFG::SpeculativeJIT::compileStrictEq):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::at):
(JSC::DFG::SpeculativeJIT::canReuse):
(JSC::DFG::SpeculativeJIT::use):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
(JSC::DFG::IntegerOperand::IntegerOperand):
(JSC::DFG::DoubleOperand::DoubleOperand):
(JSC::DFG::JSValueOperand::JSValueOperand):
(JSC::DFG::StorageOperand::StorageOperand):
(JSC::DFG::SpeculateIntegerOperand::SpeculateIntegerOperand):
(JSC::DFG::SpeculateStrictInt32Operand::SpeculateStrictInt32Operand):
(JSC::DFG::SpeculateDoubleOperand::SpeculateDoubleOperand):
(JSC::DFG::SpeculateCellOperand::SpeculateCellOperand):
(JSC::DFG::SpeculateBooleanOperand::SpeculateBooleanOperand):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compileValueAdd):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileValueAdd):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

21:55 Changeset [106774] by abarth@webkit.org
  • 6 edits in trunk/LayoutTests

xss-DENIED-from-data-url-in-foreign-domain-subframe.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=77849

Reviewed by Kentaro Hara.

This test doesn't seem to be sequenced correctly w.r.t. the load events
of the various frames involved. This patch re-orders some of the
triggers in the hopes of making the test no longer flaky.

  • http/tests/security/dataURL/resources/foreign-domain-data-url-accessor-iframe.html:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe.html:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
  • platform/chromium/test_expectations.txt:
20:47 Changeset [106773] by haraken@chromium.org
  • 12 edits in trunk/Source/WebCore

Rename [JSCCustom*] IDL to [JSCustom*] IDL
https://bugs.webkit.org/show_bug.cgi?id=77844

Reviewed by Adam Barth.

Most existing JSC-specific IDLs have "JS" prefix. We can rename [JSCCustom] to
[JSCustom], [JSCCustomGetter] to [JSCustomGetter], and [JSCCustomSetter] to
[JSCustomSetter].

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • css/CSSStyleDeclaration.idl:
  • html/HTMLDocument.idl:
  • html/canvas/DataView.idl:
  • page/DOMWindow.idl:
  • page/MemoryInfo.idl:
  • webaudio/ConvolverNode.idl:
  • webaudio/DOMWindowWebAudio.idl:
  • webaudio/WaveShaperNode.idl:
  • websockets/DOMWindowWebSocket.idl:
  • workers/WorkerContext.idl:
20:01 Changeset [106772] by commit-queue@webkit.org
  • 14 edits
    1 add in trunk

[EFL] Enable WebGL with glx backend
https://bugs.webkit.org/show_bug.cgi?id=77308

Patch by ChangSeok Oh <shivamidow@gmail.com> on 2012-02-05
Reviewed by Martin Robinson.

.:

Enabled WebGL feature for EFL port. The way is very similar to the one of GTK port.

  • Source/cmake/OptionsEfl.cmake: Added feature option for WebGL.

Source/WebCore:

Implemented WebGL feature for EFL port. The way is very similar to the one of GTK port.

No new tests required. We can verify this feature with the existing test cases.

  • CMakeLists.txt: Revised common files required for WebGL.
  • PlatformEfl.cmake: Added EFL specific files.
  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::getContext):

  • platform/graphics/ANGLEWebKitBridge.h:
  • platform/graphics/GraphicsContext3D.h:

(WebCore):
(WebCore::GraphicsContext3D::platformTexture):
(GraphicsContext3D):
(WebCore::GraphicsContext3D::paintsIntoCanvasBuffer):

  • platform/graphics/efl/DrawingBufferEfl.cpp: Copied from GTK port.

(WebCore):
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::~DrawingBuffer):
(WebCore::DrawingBuffer::platformColorBuffer):
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):

  • platform/graphics/efl/GraphicsContext3DEfl.cpp: Almost same with GraphicsContext3DGtk.cpp.

(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
(WebCore::GraphicsContext3D::isGLES2Compliant):

  • platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::createVertexArrayOES):
(WebCore::Extensions3DOpenGL::deleteVertexArrayOES):
(WebCore::Extensions3DOpenGL::isVertexArrayOES):
(WebCore::Extensions3DOpenGL::bindVertexArrayOES):

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

Source/WebKit/efl:

Activated WebGL feature.

  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):

19:53 Changeset [106771] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash in FormSubmission::create.
https://bugs.webkit.org/show_bug.cgi?id=77813

Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/forms/form-submission-create-crash.xhtml

  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):

LayoutTests:

  • fast/forms/form-submission-create-crash-expected.txt: Added.
  • fast/forms/form-submission-create-crash.xhtml: Added.
18:25 Changeset [106770] by kling@webkit.org
  • 6 edits
    1 delete in trunk/Source/WebCore

Remove unused file MappedAttributeEntry.h.
<http://webkit.org/b/77841>

Reviewed by Anders Carlsson.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/MappedAttributeEntry.h: Removed.
  • dom/StyledElement.h:
18:21 Changeset [106769] by kling@webkit.org
  • 253 edits in trunk/Source/WebCore

StyledElement: Rename parseMappedAttribute() to parseAttribute().
<http://webkit.org/b/77830>

Reviewed by Anders Carlsson.

Rename across the board and decorate subclasses with OVERRIDE.

18:06 Changeset [106768] by kov@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed syntax fix.

  • English.lproj/localizedStrings.js:
17:33 Changeset [106767] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Swedish buildfix.

  • dom/Document.cpp:

(WebCore::wheelEventHandlerCountChanged):

16:43 Changeset [106766] by andersca@apple.com
  • 8 edits in trunk/Source/WebCore

The scrolling tree should be aware of any wheel event handlers on the page
https://bugs.webkit.org/show_bug.cgi?id=77840

Reviewed by Andreas Kling.

If there are wheel event handlers on the page, any wheel events must be redispatched
to the main thread so they can go through the DOM event handling.

  • dom/Document.cpp:

(WebCore::wheelEventHandlerCountChanged):
Inform the scrolling coordinator that the wheel event count changed.

(WebCore::Document::didAddWheelEventHandler):
(WebCore::Document::didRemoveWheelEventHandler):
Call wheelEventHandlerCountChanged.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::frameViewWheelEventHandlerCountChanged):
Call recomputeWheelEventHandlerCount.

(WebCore::ScrollingCoordinator::recomputeWheelEventHandlerCount):
Update the scrolling tree state.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::ScrollingTree):
Initialize m_hasWheelEventHandlers to false.

(WebCore::ScrollingTree::tryToHandleWheelEvent):
If m_hasWheelEventHandlers is true, bail.

(WebCore::ScrollingTree::commitNewTreeState):
Update m_hasWheelEventHandlers.

  • page/scrolling/ScrollingTreeState.cpp:

(WebCore::ScrollingTreeState::ScrollingTreeState):
(WebCore::ScrollingTreeState::setWheelEventHandlerCount):
Add getter and setter for the wheel event handler count.

14:27 Changeset [106765] by abarth@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

Rebaseline xss-inactive-closure.html. This test "fails" because of a
subtle difference in how V8 and JSC do security checks. Essentially,
V8 does security checks based on the current ScriptExecutionContext
whereas JSC does security checks based on the current DOMWindow. I'm
working on fixing these differences in bugs like
https://bugs.webkit.org/show_bug.cgi?id=75793, but it's a long road.

In any case, the behavior indicated by this test is fine from a
security point of view, so it's better to rebaseline this test because
that will let us detect future regressions.

  • platform/chromium/http/tests/security/listener/xss-inactive-closure-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
14:16 Changeset [106764] by abarth@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

Rebaseline xss-DENIED-defineProperty. These V8-specific results appear
to also be passing, just with slightly fewer console messages.

  • platform/chromium/http/tests/security/xss-DENIED-defineProperty-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
14:02 Changeset [106763] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Further cleanup of failing and flaky security LayoutTests. This patch
updates the expectations to match the behavior as described by the
flakiness dashboard.

  • platform/chromium/test_expectations.txt:
13:54 Changeset [106762] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

This test is no longer flaky. It appears to pass all the time.

  • platform/chromium/test_expectations.txt:
10:51 Changeset [106761] by mitz@apple.com
  • 7 edits in trunk

<rdar://problem/10809525> WebKit2’s WebFrameLoaderClient::shouldUseCredentialStorage() always returns true
https://bugs.webkit.org/show_bug.cgi?id=77823

Reviewed by Anders Carlsson.

Source/WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.cpp:

(WebKit::InjectedBundlePageResourceLoadClient::shouldUseCredentialStorage): Added. Calls
through to the client if it implements shouldUseCredentialStorage. Returns true otherwise.

  • WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::shouldUseCredentialStorage): Changed to call the injected
bundle resource load client.

Tools:

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.

06:02 Changeset [106760] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Remove g_thread_init() calls
https://bugs.webkit.org/show_bug.cgi?id=77828

Reviewed by Andreas Kling.

g_thread_init has been deprecated since glib 2.32. This function is no longer necessary.
The GLib threading system is automatically initialized at the start of your program.

  • ewk/ewk_main.cpp:

(_ewk_init_body):

01:36 Changeset [106759] by gyuyoung.kim@samsung.com
  • 4 edits in trunk

[CMAKE] Support javascriptcore test for EFL port.
https://bugs.webkit.org/show_bug.cgi?id=77425

Reviewed by Daniel Bates.

Efl and WinCE as well as Blackberry port are now using Cmake as its build system
and they are share the make file to create jsc excutable. In order to run
"run-javascriptcore-tests", EFL port needs to change jsc installation configuration
with executable output directory(e.g. Programs). So, this patch change jsc installation
configuration only for EFL port.

.:

  • Source/cmake/OptionsEfl.cmake: Change *jsc_efl* name with *jsc*.

Source/JavaScriptCore:

  • shell/CMakeLists.txt:
01:27 Changeset [106758] by gyuyoung.kim@samsung.com
  • 2 edits in trunk

[CMAKE] Do not build Tools when building jsc only.
https://bugs.webkit.org/show_bug.cgi?id=77826

Reviewed by Daniel Bates.

Do not build Tools when jsc is only built. Build breaks occur because
Tools is built together when building jsc.

  • CMakeLists.txt: Build Tools directory when ENABLE_TOOLS is on.
01:26 Changeset [106757] by kling@webkit.org
  • 14 edits in trunk/Source/WebCore

Remove mapped vs non-mapped attribute distinction.
<http://webkit.org/b/77827>

Reviewed by Antti Koivisto.

Removed the isMappedAttribute flag from Attribute as it no longer serves
a practical purpose. Previously, StyledElement would generate mapped
attributes and plain Element would generate non-mapped ones.

The distinction is now made much more clearly by dividing the work between
Element's and StyledElement's attributeChanged() methods. The only thing
that StyledElement wants to do in addition to what Element does is
calling parseMappedAttribute() (which we'll rename in a later patch.)

  • dom/Attribute.cpp:

(WebCore::Attribute::clone):

  • dom/Attribute.h:

(WebCore::Attribute::create):
(WebCore::Attribute::Attribute):
(Attribute):

  • dom/Document.cpp:

(WebCore::Document::createAttributeNS):

  • dom/Element.cpp:

(WebCore::Element::attributeChanged):

  • dom/Element.h:

(Element):

  • dom/Node.cpp:

(WebCore::Node::dumpStatistics):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::parseMappedAttribute):

  • dom/StyledElement.h:

(StyledElement):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::attributesForIsindexInput):

  • html/parser/TextDocumentParser.cpp:

(WebCore::TextDocumentParser::insertFakePreElement):

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::getPresentationAttribute):

  • xml/parser/MarkupTokenBase.h:

(WebCore::::initializeAttributes):

00:29 Changeset [106756] by kling@webkit.org
  • 18 edits
    2 deletes in trunk/Source/WebCore

Kill CSSMappedAttributeDeclaration.
<http://webkit.org/b/77820>

Reviewed by Antti Koivisto.

Replace all use of CSSMappedAttributeDeclaration by StylePropertySet.
Moved the setNeedsStyleRecalc() calls from CSSMappedAttributeDeclaration
to the add/remove-CSS-property helpers in StyledElement.

This removes one step of indirection for attribute styles and reduces
the size of elements that have presentational attributes by one pointer.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/CSSMappedAttributeDeclaration.cpp: Removed.
  • dom/CSSMappedAttributeDeclaration.h: Removed.
  • dom/DOMAllInOne.cpp:

Remove CSSMappedAttributeDeclaration.{cpp,h}

  • css/CSSParser.h:
  • css/CSSParser.cpp:

(WebCore::parseSimpleLengthValue):

Remove CSSParser::parseMappedAttributeValue(), we now use parseValue()
directly instead. We lose the benefit of caching new CSSValues in the
document's CSSValuePool but this optimization can be added back later.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::matchAllRules):

  • dom/ElementAttributeData.h:

(ElementAttributeData):

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::ensureAttributeStyle):

  • dom/NamedNodeMap.h:

(WebCore::NamedNodeMap::attributeStyle):
(NamedNodeMap):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::removeCSSProperties):
(WebCore::StyledElement::addCSSProperty):
(WebCore::StyledElement::addCSSImageProperty):
(WebCore::StyledElement::addCSSLength):
(WebCore::StyledElement::addCSSColor):

  • dom/StyledElement.h:

(WebCore):
(WebCore::StyledElement::attributeStyle):
(WebCore::StyledElement::ensureAttributeStyle):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::buildArrayForAttributeStyles):

00:27 Changeset [106755] by loislo@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: beautify retaining tree items view.
https://bugs.webkit.org/show_bug.cgi?id=77810

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotGenericObjectNode.prototype._createObjectCell):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):

  • inspector/front-end/heapProfiler.css:

(.cycled-ancessor-node):

  • inspector/front-end/profilesPanel.css:

02/04/12:

22:13 Changeset [106754] by shawnsingh@chromium.org
  • 5 edits in trunk/Source

[chromium] Add support to force full damage in CCDamageTracker
https://bugs.webkit.org/show_bug.cgi?id=76805

Reviewed by James Robinson.

Source/WebCore:

Unit test added to CCDamageTrackerTest.cpp.

This feature is needed for events that should cause the entire
surface to be damaged, even if layers themselves had only partial
damage or no damage at all. For example, tab-switching is one such
event.

  • platform/graphics/chromium/cc/CCDamageTracker.cpp:

(WebCore::CCDamageTracker::CCDamageTracker):
(WebCore::CCDamageTracker::updateDamageRectForNextFrame):

  • platform/graphics/chromium/cc/CCDamageTracker.h:

(WebCore::CCDamageTracker::forceFullDamageNextUpdate):
(CCDamageTracker):

Source/WebKit/chromium:

  • tests/CCDamageTrackerTest.cpp:

(WebKitTests::TEST_F):
(WebKitTests):

18:53 Changeset [106753] by mitz@apple.com
  • 9 edits in trunk

<rdar://problem/10660698> Clients cannot prevent caching of individual responses
https://bugs.webkit.org/show_bug.cgi?id=77822

Reviewed by Sam Weinig.

Source/WebKit2:

  • Shared/APIClientTraits.cpp: Added definition of interfaceSizesByVersion for

WKBundlePageResourceLoadClient.

  • Shared/APIClientTraits.h: Added APIClientTraits specialization for WKBundlePageResourceLoadClient.
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h: Added WKBundlePageShouldCacheResponseCallback

typedef, added shouldCacheResponse member to WKBundlePageResourceLoadClient, and bumped
kWKBundlePageResourceLoadClientCurrentVersion to 1.

  • WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.cpp:

(WebKit::InjectedBundlePageResourceLoadClient::shouldCacheResponse): Added. Calls through
to the client if it implements shouldCacheResponse. Returns true otherwise.

  • WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::willCacheResponse): Changed to call
InjectedBundlePageResourceLoadClient::shouldCacheResponse() and return nil if the former
returns false.
(WebKit::WebFrameLoaderClient::shouldCacheResponse): Changed to call
InjectedBundlePageResourceLoadClient::shouldCacheResponse().

Tools:

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.

17:03 Changeset [106752] by andersca@apple.com
  • 6 edits in trunk/Source/WebCore

Remove dead code from ScrollingCoordinator
https://bugs.webkit.org/show_bug.cgi?id=77821

Reviewed by Sam Weinig.

  • WebCore.exp.in:
  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::ScrollingCoordinator):

  • page/scrolling/ScrollingCoordinator.h:

(ScrollingCoordinator):

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinator::frameViewScrollLayerDidChange):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::frameViewDidChangeSize):
(WebCore::RenderLayerCompositor::updateRootLayerPosition):

16:55 Changeset [106751] by weinig@apple.com
  • 7 edits
    2 adds in trunk

Add ability to send WKURLRequests in WebKit2 API user messages
https://bugs.webkit.org/show_bug.cgi?id=77819

Reviewed by Anders Carlsson.

Source/WebKit2:

Test: WebKit2UserMessageRoundTripTest API test.

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
Add encode/decode for WebURLRequest.

Tools:

Add testing for round-tripping WKTypes from the UIProcess,
to the WebProcess, and back.

  • This commit adds a test fixture and tests for WKURLRequestRef, WKURLRef, and WKStringRef. More can easily be added.
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Added.

(TestWebKitAPI):
(WebKit2UserMessageRoundTripTest):
(TestWebKitAPI::WebKit2UserMessageRoundTripTest::WebKit2UserMessageRoundTripTest):
(TestWebKitAPI::WebKit2UserMessageRoundTripTest::didReceiveMessageFromInjectedBundle):
(TestWebKitAPI::WebKit2UserMessageRoundTripTest::didFinishLoadForFrame):
(TestWebKitAPI::WebKit2UserMessageRoundTripTest::setInjectedBundleClient):
(TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
(TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp):
(TestWebKitAPI::WebKit2UserMessageRoundTripTest::roundTrip):
(TestWebKitAPI::TEST_F):

  • TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp: Added.

(TestWebKitAPI):
(UserMessageTest):
(TestWebKitAPI::UserMessageTest::UserMessageTest):
(TestWebKitAPI::UserMessageTest::didReceiveMessage):

  • TestWebKitAPI/mac/PlatformWebViewMac.mm:

(TestWebKitAPI::PlatformWebView::resizeTo):
(TestWebKitAPI):

  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
  • TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
16:43 Changeset [106750] by andersca@apple.com
  • 6 edits in trunk/Source/WebCore

The scrolling tree should inform the main scrolling coordinator when the scroll position changes
https://bugs.webkit.org/show_bug.cgi?id=77818

Reviewed by Sam Weinig.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::updateMainFrameScrollPosition):
Set the main frame scroll position.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::updateMainFrameScrollPosition):
Call ScrollingCoordinator::updateMainFrameScrollPosition on the main thread.

  • page/scrolling/mac/ScrollingTreeNodeMac.mm:

(WebCore::ScrollingTreeNodeMac::scrollBy):
Call ScrollingTree::updateMainFrameScrollPosition.

16:18 Changeset [106749] by mitz@apple.com
  • 7 edits in trunk

<rdar://problem/10772406> WKPreferences instances cannot be copied
https://bugs.webkit.org/show_bug.cgi?id=77816

Reviewed by Sam Weinig.

Source/WebKit2:

Test added in TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesCreateCopy): Added.

  • UIProcess/API/C/WKPreferencesPrivate.h:
  • UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::WebPreferences): Added this constructor that copies the
WebPreferencesStore of the given WebPreferences.

  • UIProcess/WebPreferences.h:

(WebKit::WebPreferences::create): Added this create function that takes a WebPreferences
instance and creates a new instance with a copy of the given instance’s store.

Tools:

  • TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:

(TestWebKitAPI::TEST):

15:49 Changeset [106748] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Rubber stamped by Sam Weinig.

  • yarr/YarrPattern.cpp:

(JSC::Yarr::YarrPatternConstructor::quantifyAtom):

  • Fix comment.
14:56 Changeset [106747] by commit-queue@webkit.org
  • 2 edits in trunk

Fix bug in svg-link-hover-use.svg
https://bugs.webkit.org/show_bug.cgi?id=77768

Patch by Philip Rogers <pdr@google.com> on 2012-02-04
Reviewed by Eric Seidel.

  • ManualTests/svg-link-hover-use.svg:
14:56 Changeset [106746] by kling@webkit.org
  • 19 edits in trunk/Source/WebCore

Element: Remove unnecessary attributeChanged() argument.
<http://webkit.org/b/77814>

Reviewed by Ryosuke Niwa.

Remove the 'preserveDecls' argument to Element::attributeChanged() as that is no
longer needed after the removal of per-attribute style declarations.
Decorated subclass overrides with OVERRIDE since we're touching the lines.

Also removed an old inaccurate comment in NamedNodeMap::setAttributes() - calling
attributeChanged() is absolutely necessary to initialize element-specific state.

  • dom/Element.cpp:

(WebCore::Element::attributeChanged):

  • dom/Element.h:

(Element):

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::setAttributes):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::attributeChanged):

  • dom/StyledElement.h:

(StyledElement):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateType):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::attributeChanged):

  • html/HTMLMediaElement.h:

(HTMLMediaElement):

  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::attributeChanged):

  • html/HTMLScriptElement.h:

(HTMLScriptElement):

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::attributeChanged):

  • html/HTMLTrackElement.h:

(HTMLTrackElement):

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::attributeChanged):

  • svg/SVGAnimationElement.h:
  • svg/SVGElement.cpp:

(WebCore::SVGElement::attributeChanged):

  • svg/SVGElement.h:

(SVGElement):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::attributeChanged):

  • svg/animation/SVGSMILElement.h:

(SVGSMILElement):

14:44 Changeset [106745] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[GTK] CurrentTime: Reorder headers for win32
https://bugs.webkit.org/show_bug.cgi?id=77808

Patch by Kalev Lember <kalevlember@gmail.com> on 2012-02-04
Reviewed by Martin Robinson.

In GTK+ win32 port, monotonicallyIncreasingTime() implementation is
based on g_get_monotonic_time(). Reorder headers to make sure glib.h
gets included even when the platform is win32.

CurrentTime.cpp: In function 'double WTF::monotonicallyIncreasingTime()':
CurrentTime.cpp:321:53: error: 'g_get_monotonic_time' was not declared in this scope
CurrentTime.cpp:322:1: warning: control reaches end of non-void function [-Wreturn-type]

  • wtf/CurrentTime.cpp:
14:40 Changeset [106744] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Crash when reparenting children of flexible boxes
https://bugs.webkit.org/show_bug.cgi?id=77458

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-02-04
Reviewed by Ojan Vafai.

Source/WebCore:

This fixes some regressions I introduced in r106150. RenderBlock::
removeChild needs to be careful about not collapsing anonymous
blocks underneath flexible boxes, and also about node ordering
when there is an after block.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeChild):
(WebCore::RenderBlock::collapseAnonymousBoxChild):

LayoutTests:

This test case reparents a block node from under a flexible box so
that only anonymous blocks and floating generated blocks remain.
A recent patch caused these anonymous blocks to be collapsed, which
is incorrect.

  • fast/css-generated-content/remove-div-from-flexible-box-with-floating-after-content-crash-expected.txt: Added
  • fast/css-generated-content/remove-div-from-flexible-box-with-floating-after-content-crash.html: Added
14:26 Changeset [106743] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Debug build fix after r106715.

  • html/HTMLDetailsElement.cpp:

(WebCore::DetailsSummaryElement::create):

14:24 Changeset [106742] by commit-queue@webkit.org
  • 2 edits in trunk

[GTK] Use the wide character version of win32 API by default
https://bugs.webkit.org/show_bug.cgi?id=77809

Patch by Kalev Lember <kalevlember@gmail.com> on 2012-02-04
Reviewed by Martin Robinson.

Certain win32-specific files (like PluginDatabaseWin.cpp) make the
assumption that the wide character version of win32 API is the default.
Define _UNICODE and UNICODE to do this, similar to what other win32
ports are doing.

  • GNUmakefile.am:
13:31 Changeset [106741] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed test fix after r106740.
<http://webkit.org/b/77204>

Disable matched declaration caching for elements with attribute style until we can
figure out how it's supposed to work.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::matchAllRules):

04:24 Changeset [106740] by kling@webkit.org
  • 74 edits in trunk

Kill per-Attribute style declarations.
<http://webkit.org/b/77204>

Reviewed by Antti Koivisto.

Source/WebCore:

TL;DR summary: Remove the per-Attribute style declarations and replace them by a single
style declaration on StyledElement that acts as a secondary inline style.

The previous design was conceived in the Age of the Old Web(tm) where the majority of
element styling was accomplished via attributes. Nowadays, CSS is a much better tool for
this and we should optimize around that instead.

StyledElements now have an attributeStyle() which contains all the styling from attributes.
parseMappedAttribute() is responsible for adding/removing properties to the attributeStyle
as the corresponding attributes come in/out of the element.

Each Attribute instance shrinks by one pointer, each element that has attributes grows by
one pointer. The styles from individual attributes are no longer shared, so content that
uses a lot of repeating styling attributes will see a slight memory regression from this.
Future improvements to this could enable sharing the attributeStyle between elements that
have the same exact attributes to mitigate some of the damage.

There should be no web-facing behavior change from this, but it does break two things:

  • The Inspector feature for displaying per-attribute styles. To keep things manageable, this patch simply files all the attribute styles together under an anonymous attribute in the Inspector.
  • The Obj-C DOM binding for Attr::style() has to be kept for compatibility reasons, though it's already deprecated. It will now always return nil, since there's no way to retrieve a live style declaration that's specific to a certain Attr.
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::matchAllRules):
(WebCore::CSSStyleSelector::canShareStyleWithElement):

  • dom/Attr.h:

(WebCore):
(Attr):
(WebCore::Attr::style):

  • dom/Attribute.cpp:

(WebCore::Attribute::clone):

  • dom/Attribute.h:

(WebCore):
(WebCore::Attribute::create):
(WebCore::Attribute::createMapped):
(Attribute):
(WebCore::Attribute::Attribute):

  • dom/CSSMappedAttributeDeclaration.cpp:

(WebCore::CSSMappedAttributeDeclaration::~CSSMappedAttributeDeclaration):
(WebCore::CSSMappedAttributeDeclaration::setMappedProperty):

  • dom/CSSMappedAttributeDeclaration.h:

(CSSMappedAttributeDeclaration):
(WebCore::CSSMappedAttributeDeclaration::CSSMappedAttributeDeclaration):

  • dom/Element.h:

(Element):

  • dom/ElementAttributeData.h:

(ElementAttributeData):

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::ensureAttributeStyle):
(WebCore):

  • dom/NamedNodeMap.h:

(WebCore::NamedNodeMap::attributeStyle):
(NamedNodeMap):

  • dom/StyledElement.cpp:

(WebCore):
(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::removeCSSProperties):
(WebCore::StyledElement::addCSSProperty):
(WebCore::StyledElement::addCSSImageProperty):
(WebCore::StyledElement::addCSSLength):
(WebCore::StyledElement::addCSSColor):

  • dom/StyledElement.h:

(StyledElement):
(WebCore::StyledElement::removeCSSProperty):
(WebCore::StyledElement::attributeStyle):
(WebCore::StyledElement::ensureAttributeStyle):

  • html/HTMLBRElement.cpp:

(WebCore::HTMLBRElement::parseMappedAttribute):

  • html/HTMLBRElement.h:

(HTMLBRElement):

  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::parseMappedAttribute):

  • html/HTMLBodyElement.h:

(HTMLBodyElement):

  • html/HTMLDivElement.cpp:

(WebCore::HTMLDivElement::parseMappedAttribute):

  • html/HTMLDivElement.h:

(HTMLDivElement):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::applyBorderAttribute):
(WebCore::HTMLElement::mapLanguageAttributeToLocale):
(WebCore::HTMLElement::parseMappedAttribute):
(WebCore::HTMLElement::removeHTMLAlignment):
(WebCore):
(WebCore::HTMLElement::addHTMLAlignmentToStyledElement):
(WebCore::HTMLElement::setContentEditable):

  • html/HTMLElement.h:

(HTMLElement):

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::parseMappedAttribute):

  • html/HTMLEmbedElement.h:

(HTMLEmbedElement):

  • html/HTMLFontElement.cpp:

(WebCore::HTMLFontElement::parseMappedAttribute):

  • html/HTMLFontElement.h:

(HTMLFontElement):

  • html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::parseMappedAttribute):

  • html/HTMLFrameSetElement.h:

(HTMLFrameSetElement):

  • html/HTMLHRElement.cpp:

(WebCore::HTMLHRElement::parseMappedAttribute):

  • html/HTMLHRElement.h:

(HTMLHRElement):

  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::parseMappedAttribute):

  • html/HTMLIFrameElement.h:

(HTMLIFrameElement):

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseMappedAttribute):

  • html/HTMLImageElement.h:

(HTMLImageElement):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::parseMappedAttribute):

  • html/HTMLInputElement.h:

(HTMLInputElement):

  • html/HTMLLIElement.cpp:

(WebCore::HTMLLIElement::parseMappedAttribute):

  • html/HTMLLIElement.h:

(HTMLLIElement):

  • html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::parseMappedAttribute):

  • html/HTMLMarqueeElement.h:

(HTMLMarqueeElement):

  • html/HTMLOListElement.cpp:

(WebCore::HTMLOListElement::parseMappedAttribute):

  • html/HTMLOListElement.h:

(HTMLOListElement):

  • html/HTMLOutputElement.cpp:
  • html/HTMLOutputElement.h:

(HTMLOutputElement):

  • html/HTMLParagraphElement.cpp:

(WebCore::HTMLParagraphElement::parseMappedAttribute):

  • html/HTMLParagraphElement.h:

(HTMLParagraphElement):

  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::parseMappedAttribute):

  • html/HTMLPlugInElement.h:

(HTMLPlugInElement):

  • html/HTMLPreElement.cpp:

(WebCore::HTMLPreElement::parseMappedAttribute):

  • html/HTMLPreElement.h:

(HTMLPreElement):

  • html/HTMLTableCaptionElement.cpp:

(WebCore::HTMLTableCaptionElement::parseMappedAttribute):

  • html/HTMLTableCaptionElement.h:

(HTMLTableCaptionElement):

  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::parseMappedAttribute):

  • html/HTMLTableCellElement.h:

(HTMLTableCellElement):

  • html/HTMLTableColElement.cpp:

(WebCore::HTMLTableColElement::parseMappedAttribute):

  • html/HTMLTableColElement.h:

(HTMLTableColElement):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::parseMappedAttribute):

  • html/HTMLTableElement.h:

(HTMLTableElement):

  • html/HTMLTablePartElement.cpp:

(WebCore):
(WebCore::HTMLTablePartElement::parseMappedAttribute):

  • html/HTMLTablePartElement.h:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::parseMappedAttribute):

  • html/HTMLUListElement.cpp:

(WebCore::HTMLUListElement::parseMappedAttribute):

  • html/HTMLUListElement.h:

(HTMLUListElement):

  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::parseMappedAttribute):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::buildArrayForAttributeStyles):

  • mathml/MathMLElement.cpp:

(WebCore::MathMLElement::parseMappedAttribute):

  • mathml/MathMLElement.h:
  • svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::parseMappedAttribute):

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::parseMappedAttribute):
(WebCore::SVGStyledElement::getPresentationAttribute):

  • svg/SVGStyledElement.h:

(SVGStyledElement):

  • svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::parseMappedAttribute):

LayoutTests:

Rebaselined 3 inspector tests since attribute styles are no longer shown per-attribute.

  • inspector/elements/elements-panel-styles-expected.txt:
  • inspector/styles/styles-computed-trace-expected.txt:
  • inspector/styles/styles-new-API-expected.txt:
02:22 Changeset [106739] by abarth@webkit.org
  • 7 edits in trunk/Tools

garden-o-matic's All Failure tab should let you examine and rebaseline expected failures
https://bugs.webkit.org/show_bug.cgi?id=77802

Reviewed by Eric Seidel.

This patch refactors our directory grouping code into base.js where it
can be shared between failures.js and notifications.js. It then adds
an Examine action to each group of failures that triggers the "results"
view.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
02:20 Changeset [106738] by loislo@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: get rid of cycles in retaining tree
https://bugs.webkit.org/show_bug.cgi?id=77801

Drive by fix: 'retained by' prefix was removed.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotObjectNode):
(WebInspector.HeapSnapshotObjectNode.prototype._updateHasChildren):
(WebInspector.HeapSnapshotObjectNode.prototype._createChildNode):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):

  • inspector/front-end/profilesPanel.css:

(.cycled-ancessor-node):

02:12 Changeset [106737] by haraken@chromium.org
  • 152 edits in trunk/Source/WebCore

Add the "JS" prefix to JSC specific IDL attributes
https://bugs.webkit.org/show_bug.cgi?id=77693

Reviewed by Darin Adler.

Some JSC specific IDLs do not have "JS" prefix, e.g. [CustomIsReachable].
It might be OK since JSC is the main JavaScript engine in WebKit, but
distinguishing IDLs widely used in WebKit and IDLs used in JSC only would help
people understand the role of IDLs.

This patch renames the following JSC specific IDLs:

CustomFinalize => JSCustomFinalize
CustomIsReachable => JSCustomIsReachable
CustomMarkFunction => JSCustomMarkFunction
CustomToJS => JSCustomToJS
CustomNativeConverter => JSCustomToNativeObject (Note: For naming consistency with [JSCustomToJS])
GenerateIsReachable => JSGenerateIsReachable
GenerateToJS => JSGenerateToJS
NoStaticTables => JSNoStaticTables
WindowEventListener => JSWindowEventListener
InlineGetOwnPropertySlot => JSInlineGetOwnPropertySlot
DelegatingPrototypePutFunction => JSCustomPrototypePutDelegate

No tests. No changes in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(HasCustomToV8Implementation):

  • bindings/scripts/test/TestTypedArray.idl: No change in run-bindings-tests results.
  • css/CSSRule.idl:
  • css/CSSRuleList.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSValue.idl:
  • css/MediaList.idl:
  • css/MediaQueryListListener.idl:
  • css/StyleMedia.idl:
  • css/StyleSheet.idl:
  • css/StyleSheetList.idl:
  • dom/Attr.idl:
  • dom/DOMCoreException.idl:
  • dom/DOMImplementation.idl:
  • dom/DOMStringMap.idl:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/ErrorEvent.idl:
  • dom/Event.idl:
  • dom/EventException.idl:
  • dom/EventListener.idl:
  • dom/MessageChannel.idl:
  • dom/MessageEvent.idl:
  • dom/MessagePort.idl:
  • dom/NamedNodeMap.idl:
  • dom/Node.idl:
  • dom/NodeFilter.idl:
  • dom/NodeIterator.idl:
  • dom/NodeList.idl:
  • dom/TreeWalker.idl:
  • dom/WebKitNamedFlow.idl:
  • fileapi/Blob.idl:
  • fileapi/DOMFileSystem.idl:
  • fileapi/DOMFileSystemSync.idl:
  • fileapi/DirectoryEntry.idl:
  • fileapi/DirectoryEntrySync.idl:
  • fileapi/DirectoryReader.idl:
  • fileapi/DirectoryReaderSync.idl:
  • fileapi/Entry.idl:
  • fileapi/EntryArray.idl:
  • fileapi/EntryArraySync.idl:
  • fileapi/EntrySync.idl:
  • fileapi/File.idl:
  • fileapi/FileEntry.idl:
  • fileapi/FileEntrySync.idl:
  • fileapi/FileError.idl:
  • fileapi/FileException.idl:
  • fileapi/FileList.idl:
  • fileapi/FileReader.idl:
  • fileapi/FileReaderSync.idl:
  • fileapi/FileWriter.idl:
  • fileapi/Metadata.idl:
  • fileapi/OperationNotAllowedException.idl:
  • fileapi/WebKitBlobBuilder.idl:
  • html/DOMFormData.idl:
  • html/DOMSettableTokenList.idl:
  • html/DOMTokenList.idl:
  • html/DOMURL.idl:
  • html/HTMLAllCollection.idl:
  • html/HTMLBodyElement.idl:
  • html/HTMLCollection.idl:
  • html/HTMLFrameSetElement.idl:
  • html/ImageData.idl:
  • html/MediaController.idl:
  • html/TextTrack.idl:
  • html/TextTrackCue.idl:
  • html/VoidCallback.idl:
  • html/canvas/ArrayBuffer.idl:
  • html/canvas/ArrayBufferView.idl:
  • html/canvas/CanvasRenderingContext.idl:
  • html/canvas/DataView.idl:
  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/OESStandardDerivatives.idl:
  • html/canvas/OESTextureFloat.idl:
  • html/canvas/OESVertexArrayObject.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • html/canvas/Uint8ClampedArray.idl:
  • html/canvas/WebGLCompressedTextures.idl:
  • html/canvas/WebGLDebugRendererInfo.idl:
  • html/canvas/WebGLDebugShaders.idl:
  • html/canvas/WebGLLoseContext.idl:
  • html/canvas/WebGLRenderingContext.idl:
  • html/track/TextTrackList.idl:
  • loader/appcache/DOMApplicationCache.idl:
  • mediastream/LocalMediaStream.idl:
  • page/BarInfo.idl:
  • page/Console.idl:
  • page/DOMSelection.idl:
  • page/DOMWindow.idl:
  • page/EventSource.idl:
  • page/Geolocation.idl:
  • page/History.idl:
  • page/Location.idl:
  • page/Navigator.idl:
  • page/Screen.idl:
  • page/WorkerNavigator.idl:
  • plugins/DOMMimeTypeArray.idl:
  • plugins/DOMPluginArray.idl:
  • storage/Database.idl:
  • storage/DatabaseSync.idl:
  • storage/IDBAny.idl:
  • storage/IDBKey.idl:
  • storage/SQLError.idl:
  • storage/SQLException.idl:
  • storage/SQLResultSet.idl:
  • storage/SQLResultSetRowList.idl:
  • storage/SQLTransaction.idl:
  • storage/SQLTransactionSync.idl:
  • storage/Storage.idl:
  • svg/SVGElementInstance.idl:
  • svg/SVGPathSeg.idl:
  • webaudio/AudioBufferCallback.idl:
  • webaudio/AudioBufferSourceNode.idl:
  • webaudio/AudioContext.idl:
  • webaudio/AudioDestinationNode.idl:
  • webaudio/AudioGain.idl:
  • webaudio/AudioGainNode.idl:
  • webaudio/AudioPannerNode.idl:
  • webaudio/AudioProcessingEvent.idl:
  • webaudio/BiquadFilterNode.idl:
  • webaudio/ConvolverNode.idl:
  • webaudio/DelayNode.idl:
  • webaudio/DynamicsCompressorNode.idl:
  • webaudio/HighPass2FilterNode.idl:
  • webaudio/JavaScriptAudioNode.idl:
  • webaudio/LowPass2FilterNode.idl:
  • webaudio/MediaElementAudioSourceNode.idl:
  • webaudio/OfflineAudioCompletionEvent.idl:
  • webaudio/RealtimeAnalyserNode.idl:
  • webaudio/WaveShaperNode.idl:
  • websockets/CloseEvent.idl:
  • websockets/WebSocket.idl:
  • workers/AbstractWorker.idl:
  • workers/DedicatedWorkerContext.idl:
  • workers/SharedWorker.idl:
  • workers/SharedWorkerContext.idl:
  • workers/Worker.idl:
  • workers/WorkerContext.idl:
  • workers/WorkerLocation.idl:
  • xml/XMLHttpRequest.idl:
  • xml/XMLHttpRequestException.idl:
  • xml/XMLHttpRequestProgressEvent.idl:
  • xml/XMLHttpRequestUpload.idl:
  • xml/XPathResult.idl:
02:09 Changeset [106736] by abarth@webkit.org
  • 4 edits in trunk/LayoutTests

http/tests/security/xss-eval fails due to difference in JSC and V8 eval
https://bugs.webkit.org/show_bug.cgi?id=77806

Reviewed by Eric Seidel.

Both the JSC and V8 behaviors are reasonable in this case. This patch
modifies the test to show that either behavior isn't a security
vulnerability.

  • http/tests/security/xss-eval.html:
  • platform/chromium/http/tests/security/xss-eval-expected.txt:
  • platform/chromium/test_expectations.txt:
01:50 Changeset [106735] by ojan@chromium.org
  • 3 edits in trunk/Tools

check-webkit-style is throwing an exception
https://bugs.webkit.org/show_bug.cgi?id=77744

Reviewed by David Levin.

If the test_list is None, then we don't need to check for unsupported
feature tests to skip.

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._has_test_in_directories):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(test_skipped_tests_for_unsupported_features_empty_test_list):

01:42 Changeset [106734] by eae@chromium.org
  • 13 edits in trunk/Source/WebCore

Convert RenderTheme over to new layout abstraction
https://bugs.webkit.org/show_bug.cgi?id=77783

Reviewed by Eric Seidel.

Change the RenderTheme classes to use the new layout abstraction as a
part of the ongoing conversion work.

No new tests.

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::volumeSliderOffsetFromMuteButton):
(WebCore::RenderTheme::baselinePosition):
(WebCore::RenderTheme::adjustRepaintRect):
(WebCore::RenderTheme::meterSizeForBounds):

  • rendering/RenderTheme.h:

(RenderTheme):
(WebCore::RenderTheme::paintCapsLockIndicator):

  • rendering/RenderThemeChromiumMac.h:

(RenderThemeChromiumMac):

  • rendering/RenderThemeChromiumMac.mm:

(WebCore::RenderThemeChromiumMac::volumeSliderOffsetFromMuteButton):

  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::convertToPaintingRect):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):

  • rendering/RenderThemeChromiumSkia.h:
  • rendering/RenderThemeMac.h:

(RenderThemeMac):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::adjustRepaintRect):
(WebCore::RenderThemeMac::inflateRect):
(WebCore::RenderThemeMac::setControlSize):
(WebCore::RenderThemeMac::paintCapsLockIndicator):
(WebCore::RenderThemeMac::paintMenuList):
(WebCore::RenderThemeMac::meterSizeForBounds):
(WebCore::RenderThemeMac::paintMenuListButtonGradients):
(WebCore::RenderThemeMac::setPopupButtonCellState):
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::volumeSliderOffsetFromMuteButton):

  • rendering/RenderThemeSafari.cpp:

(WebCore::RenderThemeSafari::baselinePosition):

  • rendering/RenderThemeSafari.h:

(RenderThemeSafari):

  • rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::paintSearchFieldCancelButton):
(WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeWin::paintSearchFieldResultsButton):
(WebCore::RenderThemeWin::volumeSliderOffsetFromMuteButton):

  • rendering/RenderThemeWin.h:

(RenderThemeWin):

01:40 Changeset [106733] by dgrogan@chromium.org
  • 2 edits in trunk/LayoutTests

IndexedDB: mark quota layout test WONTFIX
https://bugs.webkit.org/show_bug.cgi?id=77459

Reviewed by Tony Chang.

  • platform/chromium/test_expectations.txt:
01:26 Changeset [106732] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Fix multi-second hangs in compositor invalidating large layers
https://bugs.webkit.org/show_bug.cgi?id=77774

Reviewed by James Robinson.

Correctness covered by existing tests.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::pushPropertiesTo):
Remove tiles from the tiler when they are invalid (ie., no longer have
texture backing).
(WebCore::TiledLayerChromium::invalidateRect):
Instead of iterating over the tile indices (which may be very large),
iterate over the tile hash map instead.

01:24 Changeset [106731] by commit-queue@webkit.org
  • 1 edit
    4 adds in trunk/Source/WebKit

[BlackBerry] Upstream BlackBerry WebCoreSupport ClientExtension and GeolocationControllerClientBlackBerry classes
https://bugs.webkit.org/show_bug.cgi?id=77751

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-02-04
Reviewed by Rob Buis.

Initial upstream, no new tests.

  • blackberry/WebCoreSupport/ClientExtension.cpp: Added.
  • blackberry/WebCoreSupport/ClientExtension.h: Added.
  • blackberry/WebCoreSupport/GeolocationControllerClientBlackBerry.cpp: Added.
  • blackberry/WebCoreSupport/GeolocationControllerClientBlackBerry.h: Added.
01:19 Changeset [106730] by commit-queue@webkit.org
  • 4 edits in trunk

Source/WebCore: Patch by Swapna P <spottabathini@innominds.com> on 2012-02-04
Reviewed by Antonio Gomes.

Bug: iframe with scrolling=no incorrectly autoscrollable
https://bugs.webkit.org/show_bug.cgi?id=61558

Added check for frame scrolling mode just before applying scroll on frame content in function RenderLayer::scrollRect

Testcase: LayoutTests/fast/events/autoscroll-with-non-scrollable-parent.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollRectToVisible):

LayoutTests: Patch by Swapna P <spottabathini@innominds.com> on 2012-02-04
Reviewed by Antonio Gomes.

Bug: iframe with scrolling=no incorrectly autoscrollable
https://bugs.webkit.org/show_bug.cgi?id=61558

Did change inorder to print correct log as per the description provided in test case.

  • fast/events/autoscroll-with-non-scrollable-parent.html:

02/03/12:

22:43 Changeset [106729] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Canvas-into-canvas drawing should respect backing store scale ratio
https://bugs.webkit.org/show_bug.cgi?id=77784
<rdar://problem/10549729>

Reviewed by Dan Bernstein.

Respect the backing store scale ratio when drawing a canvas into another
canvas via ctx.drawImage(canvas, x, y). Previous behavior caused canvas
drawing to differ based on the size of the backing store, which is ideally
an implementation detail to authors.

Also, rename the source canvas arguments to CanvasRenderingContext2D::drawImage
to be more clear.

No new tests.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawImage):

20:45 Changeset [106728] by abarth@webkit.org
  • 2 edits
    1 add
    1 delete in trunk/LayoutTests

Add a Chromium-specific baseline for this test. These results appear to be passing.

  • platform/chromium-win/http/tests/security/cross-frame-access-put-expected.txt: Removed.
  • platform/chromium/http/tests/security/cross-frame-access-put-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
19:59 Changeset [106727] by abarth@webkit.org
  • 5 edits in trunk/Tools

List of all failures in garden-o-matic should actually list all the failures
https://bugs.webkit.org/show_bug.cgi?id=77796

Reviewed by Eric Seidel.

This patch wires a bit more data into the new "All Failures" tab. I've
also iterated on how we enable this experimental feature. The tab is
still just a dumb list, but we'll make it smarter.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
19:50 Changeset [106726] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Windows build fix after r106692.

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_reference_files):

18:01 Changeset [106725] by bdakin@apple.com
  • 4 edits
    3 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=77782
WebPageProxy::didNewFirstVisuallyNonEmptyLayout should is called more than
once on some pages with frames
-and corresponding-
<rdar://problem/10798474>

Reviewed by Sam Weinig.

Source/WebCore:

startCountingRelevantRepaintedObjects() should only be called for the main
frame. Otherwise, the counter will be re-set inappropriately, and
didNewFirstVisuallyNonEmptyLayout may even end up firing more than once.

  • page/FrameView.cpp:

(WebCore::FrameView::performPostLayoutTasks):

Tools:

One new test.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp: Added.

(TestWebKitAPI):
(TestWebKitAPI::didForceRepaint):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp: Added.

(TestWebKitAPI):
(NewFirstVisuallyNonEmptyLayoutFramesTest):
(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::NewFirstVisuallyNonEmptyLayoutFramesTest):
(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):

  • TestWebKitAPI/Tests/WebKit2/lots-of-iframes.html: Added.
17:59 Changeset [106724] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Reduce the memory allocations of WebCore's cssPropertyName()
https://bugs.webkit.org/show_bug.cgi?id=74782

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-02-03
Reviewed by Geoffrey Garen.

Add a fast path to avoid the use of the StringBuilder.

The string builder is needed for two cases:
-CSS prefix (the character after the prefix must be uppercase)
-JavaScript CamelCase name for CSS properties

We can skip all memory allocations if the property is not in those
two cases. We start by testing the string for uppercase characters,
and just return the an identical string.

This patch create a "fast case" 2.7 times faster than previously.
The "slow case" is 2-3% slower due to the additional check at the beginning.

  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore):
(WebCore::containsASCIIUpperChar):
(WebCore::cssPropertyName):
(WebCore::isCSSPropertyName):

17:56 Changeset [106723] by andersca@apple.com
  • 9 edits in trunk/Source

WebKit2 should dispatch wheel events to the new ScrollingTree class
https://bugs.webkit.org/show_bug.cgi?id=77795

Reviewed by Andreas Kling.

Source/WebCore:

  • WebCore.exp.in:

Add new symbols needed by WebKit2.

  • WebCore.xcodeproj/project.pbxproj:

Make ScrollingTree.h private so it can be included by WebKit2.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::scrollingTree):

  • page/scrolling/ScrollingCoordinator.h:

Add a scrolling tree getter.

Source/WebKit2:

Replace all uses of ScrollingCoordinator with ScrollingTree instead.
Also, don't try to handle gesture events on the scrolling thread anymore;
we don't need to to that right now.

  • WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::addScrollingTreeForPage):
(WebKit::EventDispatcher::removeScrollingTreeForPage):
(WebKit::EventDispatcher::wheelEvent):
(WebKit::EventDispatcher::gestureEvent):

  • WebProcess/WebPage/EventDispatcher.h:

(WebCore):
(EventDispatcher):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::~TiledCoreAnimationDrawingArea):

17:45 Changeset [106722] by dslomov@google.com
  • 2 edits in trunk/Source/WebCore

[Chromium] WebCore::toV8Context crashes if DomWindow::frame() returns null.
https://bugs.webkit.org/show_bug.cgi?id=77686.

Reviewed by Adam Barth.

  • bindings/v8/V8Helpers.cpp:

(WebCore::toV8Context):

17:41 Changeset [106721] by dpranke@chromium.org
  • 12 edits in trunk/Tools

webkitpy: change exit() calls to sys.exit(), fix a leak in outputcapture
https://bugs.webkit.org/show_bug.cgi?id=77781

Reviewed by Eric Seidel.

This change fixes a couple of issues discovered while debugging
test-webkitpy; both calling exit() instead of sys.exit() --
which is discouraged in program code instead of the interpreter
-- and a particular usage of outputcapture were stdin to get whacked
and preventing debugging.

This change introduces a couple of common _exit() methods that
will standardize how webkit-patch exit's, in case we need to do
something different in the future.

  • Scripts/webkitpy/common/system/deprecated_logging.py:

(error):

  • Scripts/webkitpy/common/system/outputcapture.py:

(OutputCapture.assert_outputs):

  • Scripts/webkitpy/tool/bot/queueengine.py:

(QueueEngine.exit_after_handled_error):

  • Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:

(AbstractSequencedCommand.execute):

  • Scripts/webkitpy/tool/commands/queues.py:

(StyleQueue.handle_script_error):

  • Scripts/webkitpy/tool/commands/upload.py:

(MarkBugFixed.execute):

  • Scripts/webkitpy/tool/multicommandtool.py:

(Command._exit):

  • Scripts/webkitpy/tool/steps/abstractstep.py:

(AbstractStep._exit):

  • Scripts/webkitpy/tool/steps/checkstyle.py:

(CheckStyle.run):

  • Scripts/webkitpy/tool/steps/commit.py:

(Commit._check_test_expectations):

  • Scripts/webkitpy/tool/steps/confirmdiff.py:

(ConfirmDiff.run):

17:33 Changeset [106720] by andersca@apple.com
  • 6 edits in trunk/Source/WebCore

The scrolling tree should be able to handle wheel events
https://bugs.webkit.org/show_bug.cgi?id=77794

Reviewed by Andreas Kling.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::tryToHandleWheelEvent):
New function. Currently this always returns that it was able to handle the wheel event,
but this will change in the future.

(WebCore::ScrollingTree::handleWheelEvent):
Ask the root node to handle the wheel event.

  • page/scrolling/ScrollingTreeNode.h:

Add a handleWheelEvent pure virtual member function.

  • page/scrolling/mac/ScrollingTreeNodeMac.mm:

(WebCore::ScrollingTreeNodeMac::handleWheelEvent):
Call scrollBy for now. Eventually this should use a scroll elasticity controller to handle
things like rubber-banding.

(WebCore::ScrollingTreeNodeMac::scrollPosition):
(WebCore::ScrollingTreeNodeMac::setScrollPosition):
Add getters and setters for the scroll position.

(WebCore::ScrollingTreeNodeMac::scrollBy):
Update the scroll position given the offset.

17:32 Changeset [106719] by lforschler@apple.com
  • 1 edit in trunk/Tools/Scripts/update-webkit-dependency

buildbot fix for curl.

17:30 Changeset [106718] by vangelis@chromium.org
  • 1 edit
    2 copies in branches/chromium/1025

Merge 106672 - REGRESSION (r105401-105403): Blue flash on css border transition
https://bugs.webkit.org/show_bug.cgi?id=77491

Reviewed by Simon Fraser.

Source/WebCore:

The new blend function added with r105403 takes unsigned as parameters therefore
we have to be careful to not overflow in case the to is less than from (animating
from 400 to 0 for example).

Test: animations/animation-border-overflow.html

  • platform/animation/AnimationUtilities.h:

(WebCore::blend):

LayoutTests:

  • animations/animation-border-overflow-expected.txt: Added.
  • animations/animation-border-overflow.html: Added.

TBR=alexis.menard@openbossa.org
Review URL: https://chromiumcodereview.appspot.com/9328025

17:29 Changeset [106717] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

[WK2 Mac] No need to allow access to input methods or keyboard layouts
https://bugs.webkit.org/show_bug.cgi?id=77775
<rdar://problem/9276253>
<rdar://problem/9276268>

Reviewed by Dan Bernstein.

  • WebProcess/com.apple.WebProcess.sb: These rules were likely only necessary in early days

of WebKit2. If there are cases when this happens, that's likely wrong, and we need to know
about that.

17:26 Changeset [106716] by lforschler@apple.com
  • 1 edit in trunk/Tools/Scripts/update-webkit-dependency

Another http -> https fix for curl

17:22 Changeset [106715] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Crash in Node::dispatchSubtreeModifiedEvent
https://bugs.webkit.org/show_bug.cgi?id=77449

Reviewed by Alexey Proskuryakov.

Source/WebCore:

The bug was caused by appendChild not retaining this pointer.
This is normally okay because there's another owner within JSC/V8 binding code that
holds onto the node but this isn't the case when nodes are created as a part
of setting document.title. Fixed the crash by retaining the pointer as needed.

Test: fast/dom/remove-body-during-title-creation.html

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::appendChild):

LayoutTests:

Add a regression test for the crash.

  • fast/dom/remove-body-during-title-creation-expected.txt: Added.
  • fast/dom/remove-body-during-title-creation.html: Added.
17:19 Changeset [106714] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Perf bot build fix.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._generate_json):

17:18 Changeset [106713] by abarth@webkit.org
  • 6 edits in trunk/Tools

Add a blank "Expected Failures" tab to garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=77793

Reviewed by Eric Seidel.

This tab will help us explore and manage our expected failures. The
tab is hidden by default via a new "experimental features" flag.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:

(#unexpected):
(#onebar.partytime #unexpected):

17:09 Changeset [106712] by lforschler@apple.com
  • 2 edits in trunk/Tools/Scripts

Fix other instances of http://developer links which should be https://developer

17:05 Changeset [106711] by andersca@apple.com
  • 6 edits in trunk/Source/WebCore

Apply changed properties from the updated scrolling tree state
https://bugs.webkit.org/show_bug.cgi?id=77792

Reviewed by Andreas Kling.

  • page/scrolling/ScrollingTreeNode.cpp:

(WebCore::ScrollingTreeNode::update):
Update the tree node properties from the scrolling tree state.

  • page/scrolling/ScrollingTreeNode.h:

(WebCore::ScrollingTreeNode::scrollingTree):
(WebCore::ScrollingTreeNode::viewportRect):
(WebCore::ScrollingTreeNode::contentsSize):
Add getters.

  • page/scrolling/ScrollingTreeState.h:

(WebCore::ScrollingTreeState::changedProperties):
New function for accessing the changed properties of the scrolling tree state.

  • page/scrolling/mac/ScrollingTreeNodeMac.h:
  • page/scrolling/mac/ScrollingTreeNodeMac.mm:

(WebCore::ScrollingTreeNodeMac::update):
Update the scroll layer from the scrolling tree if necessary.

16:57 Changeset [106710] by lforschler@apple.com
  • 1 edit in trunk/Tools/Scripts/update-webkit-support-libs

Fix URL string

16:31 Changeset [106709] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

[WK2] Use properly quoted string literals
https://bugs.webkit.org/show_bug.cgi?id=77583

Reviewed by Darin Adler.

Also added some FIXMEs.

  • WebProcess/com.apple.WebProcess.sb:
16:29 Changeset [106708] by lforschler@apple.com
  • 2 edits in trunk/Tools

update-webkit-support-libraries is broken with the change from http to https on developer.apple.com
https://bugs.webkit.org/show_bug.cgi?id=77785

Fix the build bots.

Pass the -k and --sslv3 keys to make curl work with https on https://developer.apple.com

  • Scripts/update-webkit-support-libs:

(downloadExpectedVersionNumber):

16:24 Changeset [106707] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Prefix the typedef in WTF_MAKE_FAST_ALLOCATED with underscores
https://bugs.webkit.org/show_bug.cgi?id=77788

Reviewed by Andreas Kling.

The current typedef name, 'ThisIsHereToForceASemicolonAfterThisMacro', shows up when trying to
code-complete 'this' in Xcode. Prefix the typedef with two underscores to stop this from happening.

  • wtf/FastAllocBase.h:
16:22 Changeset [106706] by beidson@apple.com
  • 10 edits in trunk/Source

2012-02-03 Brady Eidson <beidson@apple.com>

<rdar://problem/10742441> and https://bugs.webkit.org/show_bug.cgi?id=77766
Need a WK2 API to filter which subframes go into WebArchives as they are created.

Reviewed by Darin Adler.

Source/WebCore:

This adds a filter callback object that allows clients to get called back for each
subframe that might be added to a WebArchive.

API only, No new layout tests.

  • WebCore.exp.in:
  • loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::create):
(WebCore::LegacyWebArchive::createFromSelection):

  • loader/archive/cf/LegacyWebArchive.h:

(FrameFilter):
(WebCore:: FrameFilter::~ FrameFilter):
(LegacyWebArchive):

Source/WebKit2:

Add a new WKBundleFrame API that takes a filter callback object to allow or reject
subframes from a WebArchive:

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameCopyWebArchive):
(WKBundleFrameCopyWebArchiveFilteringSubframes):

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h:

Implement the above API by calling through to WebCore:

  • WebProcess/WebPage/WebFrame.cpp:

(WebFrameFilter):
(WebKit::WebFrameFilter::WebFrameFilter):
(WebKit::WebFrameFilter::shouldIncludeSubframe):
(WebKit::WebFrame::webArchiveData):

  • WebProcess/WebPage/WebFrame.h:

(WebFrame):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::getWebArchiveOfFrame):

16:16 Changeset [106705] by jsbell@chromium.org
  • 4 edits
    2 adds in trunk

IndexedDB: Key generators not rolled back if insertion fails or is aborted
https://bugs.webkit.org/show_bug.cgi?id=77060

Reviewed by Tony Chang.

Source/WebCore:

Test: storage/indexeddb/key-generator.html

  • storage/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::put): Add abort task to reset cache.
(WebCore::IDBObjectStoreBackendImpl::revertAutoIncrementKeyCache):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::putInternal): Reset cache on error.

  • storage/IDBObjectStoreBackendImpl.h:

(IDBObjectStoreBackendImpl):

LayoutTests:

  • storage/indexeddb/key-generator-expected.txt: Added.
  • storage/indexeddb/key-generator.html: Added.
16:10 Changeset [106704] by tony@chromium.org
  • 3 edits
    2 adds in trunk

positive and negative flex values are not being cleared on style changes
https://bugs.webkit.org/show_bug.cgi?id=77771

Reviewed by Ojan Vafai.

Source/WebCore:

If the width or height was a flex() value, but is no longer a flex
value, we weren't clearing the positive and negative flex values in
RenderStyle.

Test: css3/flexbox/flex-no-flex.html

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyLength::applyValue):

LayoutTests:

  • css3/flexbox/flex-no-flex-expected.txt: Added.
  • css3/flexbox/flex-no-flex.html: Added.
16:01 Changeset [106703] by lforschler@apple.com
  • 3 edits in trunk/Tools

Add a Mac Lion Performance bot.
https://bugs.webkit.org/show_bug.cgi?id=77765

Reviewed by Adam Roben.

This will update the master configuration in the following ways:

Add a new performance slave (apple-xseve-11)
Add a new Factory to download a build and run perf tests.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(DownloadAndPerfTestFactory):
(DownloadAndPerfTestFactory.init):

15:53 Changeset [106702] by dpranke@chromium.org
  • 1 edit
    1 delete in trunk/Tools

Extra TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk in repository
https://bugs.webkit.org/show_bug.cgi?id=77752

Reviewed by James Robinson.

Delete unneeded file accidentally checked in in r106481.

  • TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk: Removed.
15:47 Changeset [106701] by ap@apple.com
  • 3 edits in trunk/Source/WebKit2

[Mac WK2] Use a minimally invasive way to fake plug-in process name
https://bugs.webkit.org/show_bug.cgi?id=77682

Reviewed by Darin Adler.

  • PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::netscapePluginModule):

Only change the name as it's seen from within the process.

  • Shared/Plugins/PluginQuirks.h: Fixed a typo.
15:18 Changeset [106700] by jamesr@google.com
  • 20 edits in trunk/Source

[chromium] Defer makeContextCurrent in compositor until first frame
https://bugs.webkit.org/show_bug.cgi?id=77269

Reviewed by Kenneth Russell.

Source/WebCore:

There are situations where we need to instantiate a compositor, but can't call makeContextCurrent() until some
initialization work completes on another thread that we cannot block for. This defers the first
makeContextCurrent() call until we need to produce the first frame at which point we know the call can succeed,
assuming that the scheduler does the right thing.

This is accomplished by splitting up proxy initialization into two pieces:
*) initializeContext() which attempts to instantiate a GraphicsContext3D. This can fail if we can't make a
context at all, in which case we abort completely and return NULL from CCLayerTreeHost::create().

*) initializeLayerRenderer() which uses the previously-created context to instantiate our compositor objects and

grab our renderer capabilities. This can fail if the context is not usable for compositing, which we report
to the client as a lost context event.

Internally this introduces a new state to the CCLayerTreeHostImpl where it has a context but does not yet have a
LayerRendererChromium, which has fairly minimal impact. One other change is that we don't instantiate the
TextureManagers until we have the renderer capabilities, but this isn't necessary until we want to start
painting so it doesn't have any impact outside of some overly intrustive unit tests.

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::paintContentsIfDirty):
(WebCore::ContentLayerChromium::createTextureUpdater):

  • platform/graphics/chromium/ContentLayerChromium.h:

(ContentLayerChromium):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/ImageLayerChromium.h:

(ImageLayerChromium):

  • platform/graphics/chromium/TiledLayerChromium.cpp:
  • platform/graphics/chromium/TiledLayerChromium.h:

(WebCore::TiledLayerChromium::setSampledTexelFormat):
(TiledLayerChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::initializeLayerRenderer):
(WebCore):
(WebCore::CCLayerTreeHost::beginCommitOnImplThread):
(WebCore::CCLayerTreeHost::compositeAndReadback):
(WebCore::CCLayerTreeHost::finishAllRendering):
(WebCore::CCLayerTreeHost::setViewportSize):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::updateLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):
():

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::isContextLost):

  • platform/graphics/chromium/cc/CCProxy.h:

(CCProxy):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::CCSingleThreadProxy):
(WebCore::CCSingleThreadProxy::compositeAndReadback):
(WebCore::CCSingleThreadProxy::initializeContext):
(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::layerRendererCapabilities):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(CCSingleThreadProxy):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::initializeContext):
(WebCore):
(WebCore::CCThreadProxy::initializeLayerRenderer):
(WebCore::CCThreadProxy::layerRendererCapabilities):
(WebCore::CCThreadProxy::initializeImplOnImplThread):
(WebCore::CCThreadProxy::initializeContextOnImplThread):
(WebCore::CCThreadProxy::initializeLayerRendererOnImplThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestSetViewportSize::beginTest):

  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):

15:13 Changeset [106699] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed compile fix for chromium - add commas after entries in list in WebCore.gypi

  • WebCore.gypi:
15:03 Changeset [106698] by kling@webkit.org
  • 6 edits in trunk/Source/WebCore

Unreviewed build fix attempt after r106695.

CSSMutableStyleDeclaration was renamed to StylePropertySet.

  • bindings/scripts/CodeGeneratorCPP.pm:

(AddIncludesForType):

  • bindings/scripts/CodeGeneratorV8.pm:

(AddIncludesForType):

  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8Proxy.cpp:
14:52 Changeset [106697] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Let userIdleTime() return maximum number instead of 0 as
most of other ports do.
https://bugs.webkit.org/show_bug.cgi?id=77769

Patch by Yong Li <yoli@rim.com> on 2012-02-03
Reviewed by Rob Buis.

userIdleTime() should return a big number so it won't block page cache
from releasing cached pages. See PageCache::releaseAutoreleasedPagesNowOrReschedule().

No new tests as no visible functional changes.

  • platform/blackberry/SystemTimeBlackBerry.cpp:

(WebCore::userIdleTime):

14:46 Changeset [106696] by andersca@apple.com
  • 6 edits
    4 copies in trunk/Source/WebCore

Commit scrolling tree state changes to the scrolling tree
https://bugs.webkit.org/show_bug.cgi?id=77780

Reviewed by Darin Adler.

  • WebCore.xcodeproj/project.pbxproj:
  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::commitTreeState):
Send the new scrolling tree state over to the ScrollingTree on the scrolling thread.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::ScrollingTree):
Create a root node.

(WebCore::ScrollingTree::commitNewTreeState):
Update the root node.

  • page/scrolling/ScrollingTreeNode.cpp: Copied from Source/WebCore/page/scrolling/ScrollingTree.cpp.
  • page/scrolling/ScrollingTreeNode.h: Copied from Source/WebCore/page/scrolling/ScrollingTree.cpp.

Stub out an abstract ScrollingTreeNode class.

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinator::frameViewScrollLayerDidChange):
Update the scroll layer on the tree state.

  • page/scrolling/mac/ScrollingTreeNodeMac.h: Copied from Source/WebCore/page/scrolling/ScrollingTree.cpp.
  • page/scrolling/mac/ScrollingTreeNodeMac.mm: Copied from Source/WebCore/page/scrolling/ScrollingTree.cpp.

Stub out the concrete ScrollingTreeNodeMac subclass.

14:41 Changeset [106695] by antti@apple.com
  • 49 edits
    2 moves in trunk/Source

Rename CSSMutableStyleDeclaration.h/.cpp to StylePropertySet.h/.cpp
https://bugs.webkit.org/show_bug.cgi?id=77779

Reviewed by Darin Adler.

Source/WebCore:

Match the new class name.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCSSStyleDeclarationCustom.cpp:
  • bindings/js/JSDOMBinding.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(NativeToJSValue):

  • bindings/scripts/CodeGeneratorObjC.pm:

(AddIncludesForType):

  • css/CSSAllInOne.cpp:
  • css/CSSComputedStyleDeclaration.cpp:
  • css/CSSFontFaceRule.cpp:
  • css/CSSFontFaceRule.h:
  • css/CSSFontSelector.cpp:
  • css/CSSMutableStyleDeclaration.cpp: Removed.
  • css/CSSMutableStyleDeclaration.h: Removed.
  • css/CSSPageRule.cpp:
  • css/CSSParser.cpp:
  • css/CSSStyleRule.cpp:
  • css/CSSStyleRule.h:
  • css/StylePropertySet.cpp: Copied from Source/WebCore/css/CSSMutableStyleDeclaration.cpp.
  • css/StylePropertySet.h: Copied from Source/WebCore/css/CSSMutableStyleDeclaration.h.
  • css/WebKitCSSKeyframeRule.cpp:
  • css/WebKitCSSKeyframeRule.h:
  • css/WebKitCSSKeyframesRule.cpp:
  • css/WebKitCSSMatrix.cpp:
  • dom/CSSMappedAttributeDeclaration.h:
  • dom/ElementAttributeData.h:
  • dom/StyledElement.cpp:
  • dom/StyledElement.h:
  • editing/ApplyStyleCommand.cpp:
  • editing/DeleteButtonController.cpp:
  • editing/EditingStyle.cpp:
  • editing/Editor.cpp:
  • editing/EditorCommand.cpp:
  • editing/RemoveCSSPropertyCommand.cpp:
  • editing/ReplaceSelectionCommand.cpp:
  • editing/markup.cpp:
  • html/canvas/CanvasRenderingContext2D.cpp:
  • html/shadow/MeterShadowElement.cpp:
  • inspector/InspectorCSSAgent.cpp:
  • inspector/InspectorDOMAgent.cpp:
  • page/DragController.cpp:
  • page/Frame.cpp:
  • rendering/RenderLayer.cpp:
  • rendering/RenderTreeAsText.cpp:
  • svg/SVGFontFaceElement.h:

(WebCore):

Source/WebKit/mac:

  • WebView/WebHTMLView.mm:

Source/WebKit/qt:

  • Api/qwebelement.cpp:
14:23 Changeset [106694] by mihnea@adobe.com
  • 9 edits
    4 adds in trunk

Crash in RenderFlowThread::setRegionBoxesRegionStyle
https://bugs.webkit.org/show_bug.cgi?id=77474

Reviewed by David Hyatt.

Source/WebCore:

Flexbox and deprecated flexible box should also compute their region range
when they are part of a named flow. Until now, only RenderBlock elements
were doing that. Flexbox and deprecated flexible box, while implementing
their own layoutBlock method, were not doing that.

Tests: fast/regions/flexbox-in-region-crash.html

fast/regions/select-in-region-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeInitialRegionRangeForBlock):
(WebCore):
(WebCore::RenderBlock::computeRegionRangeForBlock):
(WebCore::RenderBlock::layoutBlock):

  • rendering/RenderBlock.h:

(RenderBlock):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::removeRegionFromThread):
(WebCore::RenderFlowThread::removeRenderBoxRegionInfo):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::paintReplaced):

  • rendering/RenderRegion.h:

(RenderRegion):

LayoutTests:

  • fast/regions/flexbox-in-region-crash-expected.txt: Added.
  • fast/regions/flexbox-in-region-crash.html: Added.
  • fast/regions/select-in-region-crash-expected.txt: Added.
  • fast/regions/select-in-region-crash.html: Added.
14:07 Changeset [106693] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/accessibility/AccessibilityRenderObject.cpp

Fixing a use of enclosingIntRect in Accessibility code. Should be pixelSnapped instead.

13:48 Changeset [106692] by rniwa@webkit.org
  • 7 edits in trunk/Tools

Ref Tests should support plain SVG files
https://bugs.webkit.org/show_bug.cgi?id=77685

Reviewed by Tony Chang.

Don't assume reference files always use .html as the extension.
Instead, use the list of supported extension to look for -expected.* and -mismatch.*

Also fix various bugs in MockFileSystem and TestPort.

  • Scripts/webkitpy/common/system/filesystem_mock.py:

(MockFileSystem.isdir):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.reference_files):

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_is_test_file):
(PortTest.test_reference_files):

  • Scripts/webkitpy/layout_tests/port/test.py:

(TestInstance.init):

13:28 Changeset [106691] by piman@chromium.org
  • 5 edits in branches/chromium/1025/Source

Merge 106663 - [Chromium] Use the current clip when marking paints as opaque
https://bugs.webkit.org/show_bug.cgi?id=77582

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-03
Reviewed by Stephen White.

Source/WebCore:

New unit test in PlatformContextSkiaTest.cpp

  • platform/graphics/skia/OpaqueRegionSkia.cpp:

(WebCore::OpaqueRegionSkia::markRectAsOpaque):

  • platform/graphics/skia/PlatformContextSkia.h:

(WebCore::PlatformContextSkia::canvas):

Source/WebKit/chromium:

  • tests/PlatformContextSkiaTest.cpp:

(WebCore::TEST):
(WebCore):

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9328008

13:25 Changeset [106690] by andersca@apple.com
  • 6 edits in trunk/Source/WebCore

Update the tree state after layout and add a way to commit it
https://bugs.webkit.org/show_bug.cgi?id=77767

Reviewed by Andreas Kling.

  • page/FrameView.cpp:

(WebCore::FrameView::performPostLayoutTasks):
Call ScrollingCoordinator::frameViewLayoutUpdated if we have a scrolling coordinator.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::ScrollingCoordinator):
Initialize m_scrollingTreeStateCommitterTimer.

(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
Update the viewport rect and contents size of the frame view.

(WebCore::ScrollingCoordinator::scheduleTreeStateCommit):
Schedule a tree state commit unless we've already scheduled one or there are no changed properties.

(WebCore::ScrollingCoordinator::scrollingTreeStateCommitterTimerFired):
Call commitTreeState().

(WebCore::ScrollingCoordinator::commitTreeStateIfNeeded):
Commit the tree state unless there are no changed properties.

(WebCore::ScrollingCoordinator::commitTreeState):
Commit the tree state. We currently don't do anything with the committed state yet.

  • page/scrolling/ScrollingCoordinator.h:

Add new member functions and the timer member variable.

  • page/scrolling/ScrollingTreeState.cpp:

(WebCore::ScrollingTreeState::commit):
Copy the current tree state and restore the changed properties on the original.

  • page/scrolling/ScrollingTreeState.h:

(WebCore::ScrollingTreeState::hasChangedProperties):
Return whether there are any changed properties in the tree state.

13:25 Changeset [106689] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

complete rebaseline of box-shadow-clipped-slices
https://bugs.webkit.org/show_bug.cgi?id=77565

Patch by Elliot Poger <epoger@google.com> on 2012-02-03
Reviewed by Darin Adler.

  • platform/chromium/test_expectations.txt:
13:13 Changeset [106688] by commit-queue@webkit.org
  • 2 edits in trunk

[GTK] configure: Print out the -Wno-c++0x-compat test result
https://bugs.webkit.org/show_bug.cgi?id=77757

Patch by Kalev Lember <kalevlember@gmail.com> on 2012-02-03
Reviewed by Martin Robinson.

The check whether -Wno-c++0x-compat flag is needed didn't print out
the test result (and newline), which caused the following test to be
displayed on the same line.

checking if we have to disable C++0x compat warnings for GCC >= 4.6.0... checking pthread.h usability... yes

  • configure.ac:
13:10 Changeset [106687] by rniwa@webkit.org
  • 15 edits in trunk

perf-o-matic should store chromium svn revision
https://bugs.webkit.org/show_bug.cgi?id=77725

Reviewed by Dirk Pranke.

.:

Store both WebKit and Chromium revisions when both are reported.

  • Websites/webkit-perf.appspot.com/models.py:

(Build):

  • Websites/webkit-perf.appspot.com/report_handler.py:

(ReportHandler.post):
(ReportHandler._create_build_if_possible):
(ReportHandler._create_build_if_possible.execute):

  • Websites/webkit-perf.appspot.com/static/manual-submit.html:

Tools:

Report both WebKit and Chromium revisions to the graph server. Renamed test_repository_paths to
repository_paths since it's nothing to do with tests. Also refactored scm so that head_svn_revision
is implemented in terms of newly added svn_revision.

  • Scripts/webkitpy/common/checkout/scm/git.py:

(Git.svn_revision):

  • Scripts/webkitpy/common/checkout/scm/scm.py:

(SCM.head_svn_revision):
(SCM):
(SCM.svn_revision):

  • Scripts/webkitpy/common/checkout/scm/scm_mock.py:

(MockSCM.svn_revision):

  • Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN.svn_revision):

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:

(JSONLayoutResultsGenerator.init):

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

(JSONResultsGeneratorBase._insert_generic_metadata):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.repository_paths):

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.repository_paths):

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._generate_json):

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(test_run_test_set_with_json_output):
(test_run_test_set_with_json_source):
(test_run_test_set_with_multiple_repositories):

12:59 Changeset [106686] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

Fix alignment warnings in ARMv7
https://bugs.webkit.org/show_bug.cgi?id=55368

Patch by Rob Buis <rbuis@rim.com> on 2012-02-03
Reviewed by Filip Pizlo.

Use reinterpret_cast_ptr and static_cast to get rid of alignment issues in ARMv7 code.

  • heap/HandleTypes.h:

(JSC::HandleTypes::getFromSlot):

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::specializedSweep):

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::forEachCell):

  • runtime/WriteBarrier.h:

(JSC::WriteBarrierBase::get):
(JSC::WriteBarrierBase::unvalidatedGet):

12:57 Changeset [106685] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

HTMLElement: Clean up tabindex attribute parsing.
<http://webkit.org/b/77763>

Reviewed by Antti Koivisto.

Remove an unnecessary getAttribute() call when parsing tabindexAttr.

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute):

12:46 Changeset [106684] by dgrogan@chromium.org
  • 3 edits in trunk/LayoutTests

Make js-test-pre.js more worker friendly
https://bugs.webkit.org/show_bug.cgi?id=77487

Replace uses of 'window' with 'self'.

Reviewed by Ojan Vafai.

  • fast/js/resources/js-test-pre.js:
  • storage/indexeddb/resources/basics.js:
12:22 Changeset [106683] by andersca@apple.com
  • 3 edits
    1 copy in trunk/Source/WebCore

ScrollingTreeState should keep track of the scroll layer
https://bugs.webkit.org/show_bug.cgi?id=77762

Reviewed by Andreas Kling.

  • WebCore.xcodeproj/project.pbxproj:
  • page/scrolling/ScrollingTreeState.h:

(ScrollingTreeState):

  • page/scrolling/mac/ScrollingTreeStateMac.mm: Copied from Source/WebCore/page/scrolling/ScrollingTreeState.h.

(WebCore):
(WebCore::ScrollingTreeState::platformScrollLayer):
(WebCore::ScrollingTreeState::setScrollLayer):

12:08 Changeset [106682] by jochen@chromium.org
  • 1 edit in branches/chromium/1025/Source/WebCore/page/DOMTimer.cpp

Merge 106636 - Crash when trying to add a timer to a detached document.
https://bugs.webkit.org/show_bug.cgi?id=77692

Reviewed by Alexey Proskuryakov.

In http://webkit.org/b/77370, a timer is fired on a detached document.
Since a document clears all timers when it is detached, and it
shouldn't be possible to add a timer to a detached document, we crash
if this should happen anyway. This will hopefully result in an easier
to debug crash dump.

  • page/DOMTimer.cpp:

(WebCore::DOMTimer::DOMTimer):

TBR=jochen@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9317088

11:46 Changeset [106681] by antti@apple.com
  • 63 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=77740
Split CSSMutableStyleDeclaration into separate internal and CSSOM types

Reviewed by Andreas Kling and Darin Adler.

Source/WebCore:

Split the CSSMutableStyleDeclaration into an internal type (StylePropertySet) and a CSSOM implementation type (PropertySetCSSStyleDeclaration).

To keep things somewhat manageable, this patch does NOT

  • rename or add any files (so files names won't match types)
  • rename fields, methods or variables to match new type names (like CSSStyleRule::declaration() -> CSSStyleRule::propertySet())
  • try to realize any memory or performance gains (StylePropertySet loses the vptr but gains PropertySetCSSStyleDeclaration*)
  • WebCore.exp.in:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::copy):
(WebCore::CSSComputedStyleDeclaration::makeMutable):
(WebCore::CSSComputedStyleDeclaration::copyPropertiesInSet):

  • css/CSSComputedStyleDeclaration.h:

(WebCore):
(CSSComputedStyleDeclaration):

  • css/CSSFontFaceRule.h:

(WebCore::CSSFontFaceRule::style):
(WebCore::CSSFontFaceRule::declaration):
(WebCore::CSSFontFaceRule::setDeclaration):
(CSSFontFaceRule):

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):

  • css/CSSMutableStyleDeclaration.cpp:

(PropertySetCSSStyleDeclaration):
(WebCore::PropertySetCSSStyleDeclaration::create):
(WebCore::PropertySetCSSStyleDeclaration::PropertySetCSSStyleDeclaration):
(WebCore):
(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::~StylePropertySet):
(WebCore::StylePropertySet::deref):
(WebCore::StylePropertySet::contextStyleSheet):
(WebCore::StylePropertySet::copyPropertiesFrom):
(WebCore::StylePropertySet::getPropertyValue):
(WebCore::StylePropertySet::borderSpacingValue):
(WebCore::StylePropertySet::appendFontLonghandValueIfExplicit):
(WebCore::StylePropertySet::fontValue):
(WebCore::StylePropertySet::get4Values):
(WebCore::StylePropertySet::getLayeredShorthandValue):
(WebCore::StylePropertySet::getShorthandValue):
(WebCore::StylePropertySet::getCommonValue):
(WebCore::StylePropertySet::getPropertyCSSValue):
(WebCore::StylePropertySet::removeShorthandProperty):
(WebCore::StylePropertySet::removeProperty):
(WebCore::StylePropertySet::setNeedsStyleRecalc):
(WebCore::StylePropertySet::propertyIsImportant):
(WebCore::StylePropertySet::getPropertyShorthand):
(WebCore::StylePropertySet::isPropertyImplicit):
(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet::parseDeclaration):
(WebCore::StylePropertySet::addParsedProperties):
(WebCore::StylePropertySet::addParsedProperty):
(WebCore::StylePropertySet::asText):
(WebCore::StylePropertySet::merge):
(WebCore::StylePropertySet::addSubresourceStyleURLs):
(WebCore::StylePropertySet::copyBlockProperties):
(WebCore::StylePropertySet::removeBlockProperties):
(WebCore::StylePropertySet::removePropertiesInSet):
(WebCore::StylePropertySet::findPropertyWithId):
(WebCore::StylePropertySet::propertyMatches):
(WebCore::StylePropertySet::removeEquivalentProperties):
(WebCore::StylePropertySet::copy):
(WebCore::StylePropertySet::copyPropertiesInSet):
(WebCore::StylePropertySet::ensureCSSStyleDeclaration):
(WebCore::PropertySetCSSStyleDeclaration::length):
(WebCore::PropertySetCSSStyleDeclaration::item):
(WebCore::PropertySetCSSStyleDeclaration::parentRule):
(WebCore::PropertySetCSSStyleDeclaration::cssText):
(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyPriority):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyShorthand):
(WebCore::PropertySetCSSStyleDeclaration::isPropertyImplicit):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
(WebCore::PropertySetCSSStyleDeclaration::parentStyleSheet):
(WebCore::PropertySetCSSStyleDeclaration::copy):
(WebCore::PropertySetCSSStyleDeclaration::makeMutable):
(WebCore::PropertySetCSSStyleDeclaration::cssPropertyMatches):

  • css/CSSMutableStyleDeclaration.h:

(WebCore):
(StylePropertySet):
(WebCore::StylePropertySet::create):
(WebCore::StylePropertySet::createInline):

  • css/CSSPageRule.h:

(WebCore):

  • css/CSSParser.cpp:

(WebCore::parseColorValue):
(WebCore::parseSimpleLengthValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseDeclaration):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createKeyframeRule):

  • css/CSSParser.h:

(WebCore):
(CSSParser):

  • css/CSSStyleDeclaration.h:

(WebCore):
(CSSStyleDeclaration):

  • css/CSSStyleRule.h:

(WebCore::CSSStyleRule::style):
(WebCore::CSSStyleRule::setDeclaration):
(WebCore::CSSStyleRule::declaration):
(CSSStyleRule):

  • css/CSSStyleSelector.cpp:

(WebCore::leftToRightDeclaration):
(WebCore::rightToLeftDeclaration):
(WebCore::CSSStyleSelector::addMatchedDeclaration):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
(WebCore::CSSStyleSelector::matchAllRules):
(WebCore::CSSStyleSelector::styleForKeyframe):
(WebCore::isInsideRegionRule):
(WebCore::CSSStyleSelector::applyDeclaration):
(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::CSSStyleSelector::matchPageRulesForList):

  • css/CSSStyleSelector.h:

(CSSStyleSelector):
(MatchedStyleDeclaration):

  • css/WebKitCSSKeyframeRule.cpp:

(WebCore::WebKitCSSKeyframeRule::setDeclaration):

  • css/WebKitCSSKeyframeRule.h:

(WebCore::WebKitCSSKeyframeRule::style):
(WebCore::WebKitCSSKeyframeRule::declaration):
(WebKitCSSKeyframeRule):

  • css/WebKitCSSMatrix.cpp:

(WebCore::WebKitCSSMatrix::setMatrixValue):

  • dom/Attr.h:

(WebCore::Attr::style):

  • dom/Attribute.h:

(WebCore::Attribute::decl):

  • dom/CSSMappedAttributeDeclaration.h:

(WebCore::CSSMappedAttributeDeclaration::declaration):
(WebCore::CSSMappedAttributeDeclaration::CSSMappedAttributeDeclaration):
(CSSMappedAttributeDeclaration):

  • dom/Document.cpp:

(WebCore::Document::createCSSStyleDeclaration):

  • dom/ElementAttributeData.h:

(ElementAttributeData):

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::ensureInlineStyleDecl):

  • dom/NamedNodeMap.h:

(WebCore::NamedNodeMap::inlineStyleDecl):
(NamedNodeMap):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::updateStyleAttribute):
(WebCore::StyledElement::copyNonAttributeProperties):
(WebCore::StyledElement::addSubresourceAttributeURLs):

  • dom/StyledElement.h:

(WebCore::StyledElement::additionalAttributeStyle):
(WebCore::StyledElement::inlineStyleDecl):
(WebCore::StyledElement::ensureInlineStyleDecl):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
(WebCore::ApplyStyleCommand::removeCSSStyle):
(WebCore::ApplyStyleCommand::addBlockStyle):
(WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):

  • editing/DeleteButtonController.cpp:

(WebCore::DeleteButtonController::createDeletionUI):

  • editing/EditingStyle.cpp:

(WebCore::copyEditingProperties):
(WebCore::editingStyleFromComputedStyle):
(WebCore):
(WebCore::HTMLElementEquivalent::propertyExistsInStyle):
(HTMLElementEquivalent):
(WebCore::HTMLElementEquivalent::valueIsPresentInStyle):
(HTMLTextDecorationEquivalent):
(WebCore::HTMLTextDecorationEquivalent::propertyExistsInStyle):
(WebCore::HTMLTextDecorationEquivalent::valueIsPresentInStyle):
(HTMLAttributeEquivalent):
(WebCore::HTMLAttributeEquivalent::valueIsPresentInStyle):
(WebCore::HTMLAttributeEquivalent::attributeValueAsCSSValue):
(WebCore::EditingStyle::EditingStyle):
(WebCore::getRGBAFontColor):
(WebCore::EditingStyle::setProperty):
(WebCore::EditingStyle::setStyle):
(WebCore::EditingStyle::overrideWithStyle):
(WebCore::EditingStyle::extractAndRemoveTextDirection):
(WebCore::EditingStyle::removeStyleAddedByNode):
(WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode):
(WebCore::EditingStyle::triStateOfStyle):
(WebCore::EditingStyle::conflictsWithInlineStyleOfElement):
(WebCore::EditingStyle::elementIsStyledSpanOrHTMLEquivalent):
(WebCore::elementMatchesAndPropertyIsNotInInlineStyleDecl):
(WebCore::EditingStyle::mergeStyle):
(WebCore::styleFromMatchedRulesForElement):
(WebCore::EditingStyle::mergeStyleFromRules):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):
(WebCore::removePropertiesInStyle):
(WebCore::EditingStyle::removeStyleFromRulesAndContext):
(WebCore::EditingStyle::removePropertiesInElementDefaultStyle):
(WebCore::EditingStyle::forceInline):
(WebCore::reconcileTextDecorationProperties):
(WebCore::StyleChange::StyleChange):
(WebCore::setTextDecorationProperty):
(WebCore::StyleChange::extractTextStyles):
(WebCore::diffTextDecorations):
(WebCore::fontWeightIsBold):
(WebCore::getTextAlignment):
(WebCore::getPropertiesNotIn):
(WebCore::getIdentifierValue):
(WebCore::isTransparentColorValue):
(WebCore::hasTransparentBackgroundColor):

  • editing/EditingStyle.h:

(WebCore):
(WebCore::EditingStyle::create):
(EditingStyle):
(WebCore::EditingStyle::style):
(StyleChange):

  • editing/Editor.cpp:

(WebCore::Editor::setBaseWritingDirection):
(WebCore::Editor::applyEditingStyleToElement):

  • editing/EditorCommand.cpp:

(WebCore::applyCommandToFrame):
(WebCore::executeApplyStyle):
(WebCore::executeToggleStyleInList):
(WebCore::executeApplyParagraphStyle):
(WebCore::executeMakeTextWritingDirectionLeftToRight):
(WebCore::executeMakeTextWritingDirectionNatural):
(WebCore::executeMakeTextWritingDirectionRightToLeft):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::copyTypingStyle):

  • editing/FrameSelection.h:

(WebCore):

  • editing/RemoveCSSPropertyCommand.cpp:

(WebCore::RemoveCSSPropertyCommand::doApply):
(WebCore::RemoveCSSPropertyCommand::doUnapply):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):

  • editing/ReplaceSelectionCommand.h:

(WebCore):

  • editing/markup.cpp:

(WebCore):
(StyledMarkupAccumulator):
(WebCore::StyledMarkupAccumulator::wrapWithStyleNode):
(WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag):
(WebCore::propertyMissingOrEqualToNone):

  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::additionalAttributeStyle):

  • html/HTMLTableCellElement.h:

(HTMLTableCellElement):

  • html/HTMLTableColElement.cpp:

(WebCore::HTMLTableColElement::additionalAttributeStyle):

  • html/HTMLTableColElement.h:

(HTMLTableColElement):

  • html/HTMLTableElement.cpp:

(WebCore::leakBorderStyle):
(WebCore::HTMLTableElement::additionalAttributeStyle):
(WebCore::HTMLTableElement::createSharedCellStyle):
(WebCore::HTMLTableElement::additionalCellStyle):
(WebCore::leakGroupBorderStyle):
(WebCore::HTMLTableElement::additionalGroupStyle):

  • html/HTMLTableElement.h:

(HTMLTableElement):

  • html/HTMLTableSectionElement.cpp:

(WebCore::HTMLTableSectionElement::additionalAttributeStyle):

  • html/HTMLTableSectionElement.h:

(HTMLTableSectionElement):

  • html/ValidationMessage.cpp:

(WebCore::adjustBubblePosition):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setFont):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::setPosition):
(WebCore::MediaControlPanelElement::resetPosition):
(WebCore::MediaControlPanelElement::makeOpaque):
(WebCore::MediaControlPanelElement::makeTransparent):

  • html/shadow/SliderThumbElement.cpp:

(WebCore::TrackLimiterElement::create):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::buildArrayForAttributeStyles):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):

  • page/DragController.cpp:

(WebCore::DragController::concludeEditDrag):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::retrieveResourcesForCSSDeclaration):

  • page/PageSerializer.h:

(WebCore):
(PageSerializer):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::resize):

  • rendering/RenderTreeAsText.cpp:

(WebCore::isEmptyOrUnstyledAppleStyleSpan):

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::SVGFontFaceElement):

Source/WebKit/mac:

  • WebView/WebFrame.mm:

(-[WebFrame _typingStyle]):

Source/WebKit/qt:

  • Api/qwebelement.cpp:

(QWebElement::styleProperty):

11:32 Changeset [106680] by jochen@chromium.org
  • 6 edits
    3 adds in trunk

Remove unneccesary canExecuteScripts check from v8 bindings, and correctly indeicate when we're about to execute a script
https://bugs.webkit.org/show_bug.cgi?id=76704

Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/isolatedWorld/sandboxed-iframe.html

  • bindings/v8/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute):

  • bindings/v8/V8EventListener.cpp:

(WebCore::V8EventListener::callListenerFunction):

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::callListenerFunction):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::handleOutOfMemory):
(WebCore::toV8Context):

LayoutTests:

  • http/tests/security/isolatedWorld/resources/fail.html:
  • http/tests/security/isolatedWorld/sandboxed-iframe-expected.txt:
  • http/tests/security/isolatedWorld/sandboxed-iframe.html:
11:30 Changeset [106679] by andersca@apple.com
  • 4 edits
    2 adds in trunk/Source/WebCore

Add ScrollingTreeState class
https://bugs.webkit.org/show_bug.cgi?id=77756

Reviewed by Andreas Kling.

Add a new ScrollingTreeState whose intent is to be a data container for the current
scrolling tree state. the ScrollingCoordinator class will update it and periodically
send over the new state to the ScrollingTree object on the scrolling thread.

  • WebCore.xcodeproj/project.pbxproj:
  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::ScrollingCoordinator):

  • page/scrolling/ScrollingCoordinator.h:

(WebCore):
(ScrollingCoordinator):

  • page/scrolling/ScrollingTreeState.cpp: Added.

(WebCore):
(WebCore::ScrollingTreeState::create):
(WebCore::ScrollingTreeState::ScrollingTreeState):
(WebCore::ScrollingTreeState::~ScrollingTreeState):
(WebCore::ScrollingTreeState::setViewportRect):
(WebCore::ScrollingTreeState::setContentsSize):

  • page/scrolling/ScrollingTreeState.h: Added.

(WebCore):
(ScrollingTreeState):
(WebCore::ScrollingTreeState::viewportRect):
(WebCore::ScrollingTreeState::contentsSize):

11:29 Changeset [106678] by bdakin@apple.com
  • 18 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=77691
Fix PlatformScreen layering violation and PlatformScreenMac's incorrect use
of device scale

Reviewed by Andy Estes.

Source/WebCore:

Make screenAvailableRect() and screenRect() take a Widget again instead of a
FrameView since taking a FrameView is a layering violation.

  • WebCore.exp.in:
  • platform/PlatformScreen.h:

(WebCore):

  • platform/blackberry/PlatformScreenBlackBerry.cpp:

(WebCore::screenAvailableRect):
(WebCore::screenRect):

  • platform/chromium/PlatformScreenChromium.cpp:

(WebCore::screenRect):
(WebCore::screenAvailableRect):

  • platform/chromium/PlatformSupport.h:

(WebCore):
(PlatformSupport):

  • platform/efl/PlatformScreenEfl.cpp:

(WebCore::screenRect):
(WebCore::screenAvailableRect):

  • platform/gtk/PlatformScreenGtk.cpp:

(WebCore::screenRect):
(WebCore::screenAvailableRect):

  • platform/qt/PlatformScreenQt.cpp:

(WebCore::screenRect):
(WebCore::screenAvailableRect):

  • platform/win/PlatformScreenWin.cpp:

(WebCore::screenRect):
(WebCore::screenAvailableRect):

  • platform/wx/ScreenWx.cpp:

(WebCore::screenRect):
(WebCore::screenAvailableRect):

It's wrong for the deviceScaleFactor to be taken into consideration here at
all.

  • platform/mac/PlatformScreenMac.mm:

(WebCore::screenRect):
(WebCore::screenAvailableRect):
(WebCore::toUserSpace):
(WebCore::toDeviceSpace):

Source/WebKit/chromium:

These two functions now take a Widget again rather than a FrameView.

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::screenRect):
(WebCore::PlatformSupport::screenAvailableRect):

Source/WebKit/mac:

toUserSpace() and toDeviceSpace() don't need to take device scale. Also
restore a comment that I needlessly removed.

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::setWindowRect):
(WebChromeClient::windowRect):

Source/WebKit2:

toUserSpace() and toDeviceSpace() don't need to take device scale.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _convertToDeviceSpace:]):
(-[WKView _convertToUserSpace:]):

11:27 Changeset [106677] by mhahnenberg@apple.com
  • 1 edit
    2 adds in trunk/Source/JavaScriptCore

Build fix

Unreviewed build fix

Forgot to add a couple files.

  • heap/MarkedAllocator.cpp: Added.

(JSC):
(JSC::MarkedAllocator::tryAllocateHelper):
(JSC::MarkedAllocator::tryAllocate):
(JSC::MarkedAllocator::allocateSlowCase):
(JSC::MarkedAllocator::allocateBlock):
(JSC::MarkedAllocator::addBlock):
(JSC::MarkedAllocator::removeBlock):

  • heap/MarkedAllocator.h: Added.

(JSC):
(DFG):
(MarkedAllocator):
(JSC::MarkedAllocator::cellSize):
(JSC::MarkedAllocator::heap):
(JSC::MarkedAllocator::setHeap):
(JSC::MarkedAllocator::setCellSize):
(JSC::MarkedAllocator::setMarkedSpace):
(JSC::MarkedAllocator::MarkedAllocator):
(JSC::MarkedAllocator::allocate):
(JSC::MarkedAllocator::reset):
(JSC::MarkedAllocator::zapFreeList):
(JSC::MarkedAllocator::forEachBlock):

11:21 Changeset [106676] by mhahnenberg@apple.com
  • 13 edits in trunk/Source/JavaScriptCore

Refactor MarkedBlock::SizeClass into a separate class
https://bugs.webkit.org/show_bug.cgi?id=77600

Reviewed by Geoffrey Garen.

We pulled SizeClass out into its own class, named MarkedAllocator, and gave it
the responsibility of allocating objects from the collection of MarkedBlocks
that it manages. Also limited the amount of coupling to internal data fields
from other places, although it's mostly unavoidable in the JIT code.

Eventually MarkedAllocator will implement various policies to do with object
management, e.g. whether or not to run destructors on objects that it manages.
MarkedSpace will manage a collection of MarkedAllocators with varying policies,
as it does now but to a larger extent.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::emitAllocateJSFinalObject):

  • heap/Heap.cpp:

(JSC::Heap::collect):
(JSC::Heap::resetAllocators):

  • heap/Heap.h:

(JSC::Heap::allocatorForObject):
(Heap):

  • heap/MarkedAllocator.cpp: Added.

(JSC):
(JSC::MarkedAllocator::tryAllocateHelper):
(JSC::MarkedAllocator::tryAllocate):
(JSC::MarkedAllocator::allocateSlowCase):
(JSC::MarkedAllocator::allocateBlock):
(JSC::MarkedAllocator::addBlock):
(JSC::MarkedAllocator::removeBlock):

  • heap/MarkedAllocator.h: Added.

(JSC):
(DFG):
(MarkedAllocator):
(JSC::MarkedAllocator::cellSize):
(JSC::MarkedAllocator::heap):
(JSC::MarkedAllocator::setHeap):
(JSC::MarkedAllocator::setCellSize):
(JSC::MarkedAllocator::setMarkedSpace):
(JSC::MarkedAllocator::MarkedAllocator):
(JSC::MarkedAllocator::allocate):
(JSC::MarkedAllocator::reset):
(JSC::MarkedAllocator::zapFreeList):
(JSC::MarkedAllocator::forEachBlock):

  • heap/MarkedSpace.cpp:

(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::resetAllocators):
(JSC::MarkedSpace::canonicalizeCellLivenessData):
(JSC::TakeIfUnmarked::operator()):

  • heap/MarkedSpace.h:

(MarkedSpace):
(JSC::MarkedSpace::allocatorFor):
(JSC::MarkedSpace::allocate):
(JSC::MarkedSpace::forEachBlock):
(JSC::MarkedSpace::didAddBlock):
(JSC::MarkedSpace::didConsumeFreeList):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicJSObject):

10:39 Changeset [106675] by scherkus@chromium.org
  • 2 edits in branches/chromium/1025/Source/WebCore

Merge 106610 - Avoid crashing renderer when GPU process dies by not caching textures between video frames.
https://bugs.webkit.org/show_bug.cgi?id=77654

Patch by Ami Fischman <fischman@chromium.org> on 2012-02-02
Reviewed by James Robinson.

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::draw):

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9309085

10:25 Changeset [106674] by mitz@apple.com
  • 2 edits in trunk

Added Radar links

10:23 Changeset [106673] by mitz@apple.com
  • 3 edits
    2 adds in trunk

Floating image leaves hole in previous column when wrapped to next column
https://bugs.webkit.org/show_bug.cgi?id=77694

Reviewed by Darin Adler.

Source/WebCore:

Tests: fast/dynamic/float-moved-downwards-for-pagination-expected.html

fast/dynamic/float-moved-downwards-for-pagination.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::clearFloats): When determining which lines to dirty,
also check for changes to the top edge of the float, which can happen when
float gets pushed down by a pagination strut.

LayoutTests:

  • fast/dynamic/float-moved-downwards-for-pagination-expected.html: Added.
  • fast/dynamic/float-moved-downwards-for-pagination.html: Added.
10:21 Changeset [106672] by alexis.menard@openbossa.org
  • 3 edits
    2 adds in trunk

REGRESSION (r105401-105403): Blue flash on css border transition
https://bugs.webkit.org/show_bug.cgi?id=77491

Reviewed by Simon Fraser.

Source/WebCore:

The new blend function added with r105403 takes unsigned as parameters therefore
we have to be careful to not overflow in case the to is less than from (animating
from 400 to 0 for example).

Test: animations/animation-border-overflow.html

  • platform/animation/AnimationUtilities.h:

(WebCore::blend):

LayoutTests:

  • animations/animation-border-overflow-expected.txt: Added.
  • animations/animation-border-overflow.html: Added.
10:02 Changeset [106671] by jesus@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Incorrect line number dumping
https://bugs.webkit.org/show_bug.cgi?id=60074

Reviewed by Csaba Osztrogonác.

Test http/tests/security/contentSecurityPolicy/eval-blocked.html
is now passing, unskipping it.

  • platform/qt-wk2/Skipped:
09:38 Changeset [106670] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Chromium] ImageBufferSkia: remove unnecessary overload of flush in
AcceleratedDeviceContext
https://bugs.webkit.org/show_bug.cgi?id=77741

Patch by Justin Novosad <junov@chromium.org> on 2012-02-03
Reviewed by Stephen White.

Removing dead code.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(AcceleratedDeviceContext):

09:31 Changeset [106669] by jknotten@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[skia] Fix unit test PlatformContextSkiaTest.trackOpaqueOvalTest
https://bugs.webkit.org/show_bug.cgi?id=77738

We need to clear the bitmap before the test runs, otherwise the
contents of the bitmap will be uninitialised. This causes an
unpredicatable result as the canvas draw operations blend the
destination bitmap with the source colour.

Similarly, valgrind discovered that
PlatformContextSkiaTest.trackOpaqueTest and
PlatformContextSkiaTest.trackOpaqueLineTest suffers from the same
problem.

Also, re-enable WebFrameTest.FindInPage which was falsely
blamed for making this test fail.

Reviewed by Stephen White.

  • tests/PlatformContextSkiaTest.cpp:

(WebCore::TEST):

  • tests/WebFrameTest.cpp:

(WebKit::TEST_F):

09:02 Changeset [106668] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebCore

Speculative unreviewed build fix for Qt-Windows
after http://trac.webkit.org/changeset/106659.

  • platform/graphics/texmap/TextureMapper.h:

(WebCore::TextureMapper::platformCreateAccelerated):

08:56 Changeset [106667] by commit-queue@webkit.org
  • 35 edits
    4 deletes in trunk

Unreviewed, rolling out r106654.
http://trac.webkit.org/changeset/106654
https://bugs.webkit.org/show_bug.cgi?id=77742

triggers asserts on mac, win, gtk, qt debug bots (Requested by
philn-tp on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-03

Source/WebCore:

  • Modules/intents/IntentRequest.cpp:

(WebCore::IntentRequest::create):

  • bindings/generic/ActiveDOMCallback.cpp:

(WebCore::ActiveDOMCallback::ActiveDOMCallback):

  • dom/ActiveDOMObject.cpp:

(WebCore::ActiveDOMObject::ActiveDOMObject):
(WebCore::ActiveDOMObject::~ActiveDOMObject):

  • dom/ActiveDOMObject.h:

(ActiveDOMObject):

  • dom/DocumentEventQueue.cpp:

(WebCore::DocumentEventQueue::DocumentEventQueue):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::ScriptExecutionContext):
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
(WebCore::ScriptExecutionContext::stopActiveDOMObjects):

  • dom/ScriptExecutionContext.h:

(ScriptExecutionContext):

  • fileapi/DOMFileSystem.cpp:

(WebCore::DOMFileSystem::create):

  • fileapi/FileReader.cpp:

(WebCore):

  • fileapi/FileReader.h:

(WebCore::FileReader::create):

  • fileapi/FileWriter.cpp:

(WebCore):

  • fileapi/FileWriter.h:

(WebCore::FileWriter::create):

  • history/CachedFrame.cpp:

(WebCore::CachedFrame::CachedFrame):

  • html/HTMLAudioElement.cpp:

(WebCore::HTMLAudioElement::create):

  • html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::create):

  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::create):

  • mediastream/PeerConnection.cpp:

(WebCore::PeerConnection::create):

  • notifications/Notification.cpp:

(WebCore::Notification::create):

  • notifications/NotificationCenter.cpp:
  • notifications/NotificationCenter.h:

(WebCore::NotificationCenter::create):

  • page/DOMTimer.cpp:

(WebCore::DOMTimer::install):
(WebCore::DOMTimer::fired):

  • page/EventSource.cpp:

(WebCore::EventSource::create):

  • page/SuspendableTimer.cpp:

(WebCore::SuspendableTimer::SuspendableTimer):

  • storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::create):

  • storage/IDBRequest.cpp:

(WebCore::IDBRequest::create):

  • storage/IDBTransaction.cpp:

(WebCore::IDBTransaction::create):

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::create):

  • websockets/WebSocket.cpp:
  • websockets/WebSocket.h:

(WebCore::WebSocket::create):

  • workers/SharedWorker.cpp:

(WebCore::SharedWorker::create):

  • workers/Worker.cpp:

(WebCore::Worker::create):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::create):

LayoutTests:

  • fast/events/resources/suspend-subframe-1.html: Removed.
  • fast/events/resources/suspend-subframe-2.html: Removed.
  • fast/events/suspend-timers-expected.txt: Removed.
  • fast/events/suspend-timers.html: Removed.
  • platform/chromium/test_expectations.txt:
08:53 Changeset [106666] by haraken@chromium.org
  • 27 edits in trunk/Source/WebCore

Add the "V8" prefix to V8 specific IDL attributes
https://bugs.webkit.org/show_bug.cgi?id=77713

Reviewed by Adam Barth.

This patch adds the "V8" prefix to a V8 specific IDL attribute:
[EnabledAtRuntime] => [V8EnabledAtRuntime]

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateImplementation):
(GetRuntimeEnableFunctionName):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp: Updated the run-bindings-tests results.

(WebCore::ConfigureV8TestObjTemplate):

  • Modules/gamepad/NavigatorGamepad.idl:
  • dom/Clipboard.idl:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/MouseEvent.idl:
  • dom/ShadowRoot.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLTrackElement.idl:
  • html/TextTrack.idl:
  • html/TextTrackCue.idl:
  • html/TextTrackCueList.idl:
  • html/shadow/HTMLContentElement.idl:
  • html/track/TextTrackList.idl:
  • html/track/TrackEvent.idl:
  • page/DOMWindow.idl:
  • page/History.idl:
  • page/Navigator.idl:
  • storage/DOMWindowSQLDatabase.idl:
  • webaudio/DOMWindowWebAudio.idl:
  • websockets/DOMWindowWebSocket.idl:
  • workers/WorkerContext.idl:
  • xml/XMLHttpRequest.idl:
08:50 Changeset [106665] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Retained size for classes is too conservative in heap profiler
https://bugs.webkit.org/show_bug.cgi?id=77726

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-02-03
Reviewed by Yury Semikhatsky.

Makes retained size of all objects of particular class show correct value
in Summary view of heap profiler.

  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotConstructorNode.prototype.get data):

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype._buildAggregates):
(WebInspector.HeapSnapshot.prototype._buildAggregates.forDominatedNodes):

08:43 Changeset [106664] by apavlov@chromium.org
  • 5 edits
    2 adds in trunk

Web Inspector: Introduce "Copy XPath" popup menu item for DOM elements
https://bugs.webkit.org/show_bug.cgi?id=77619

Reviewed by Vsevolod Vlasov.

Source/WebCore:

XPath is optimized whenever an element has the "id" attribute.

Test: inspector/elements/node-xpath.xhtml

  • English.lproj/localizedStrings.js:
  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode.XPathStep):
(WebInspector.DOMNode.XPathStep.prototype.toString):
(WebInspector.DOMNode.prototype.copyXPath):
(WebInspector.DOMNode.prototype.isXMLNode):
(WebInspector.DOMNode.prototype.xPath):
(WebInspector.DOMNode.prototype._xPathValue):
(WebInspector.DOMNode.prototype._xPathIndex):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype._populateNodeContextMenu):

LayoutTests:

  • inspector/elements/node-xpath-expected.txt: Added.
  • inspector/elements/node-xpath.xhtml: Added.
08:28 Changeset [106663] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[Chromium] Use the current clip when marking paints as opaque
https://bugs.webkit.org/show_bug.cgi?id=77582

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-03
Reviewed by Stephen White.

Source/WebCore:

New unit test in PlatformContextSkiaTest.cpp

  • platform/graphics/skia/OpaqueRegionSkia.cpp:

(WebCore::OpaqueRegionSkia::markRectAsOpaque):

  • platform/graphics/skia/PlatformContextSkia.h:

(WebCore::PlatformContextSkia::canvas):

Source/WebKit/chromium:

  • tests/PlatformContextSkiaTest.cpp:

(WebCore::TEST):
(WebCore):

08:20 Changeset [106662] by yurys@chromium.org
  • 10 edits in trunk

inspector/debugger/pause-in-inline-script.html asserts in chromium debug
https://bugs.webkit.org/show_bug.cgi?id=77663

Source/WebCore:

Make ASSERT in MainResourceLoader not fail if debugger hits breakpoint
in the main resource inline script.

Reviewed by Pavel Feldman.

Test: inspector/debugger/pause-in-inline-script.html

  • bindings/js/ScriptDebugServer.h:

(WebCore::ScriptDebugServer::isPaused):
(ScriptDebugServer):

  • bindings/v8/ScriptDebugServer.h:

(ScriptDebugServer):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::didClearMainFrameWindowObject):
(WebCore):
(WebCore::InspectorDebuggerAgent::isPaused):

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::isDebuggerPausedImpl):
(WebCore):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::isDebuggerPaused):
(WebCore):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::didFinishLoading):

LayoutTests:

Reviewed by Pavel Feldman.

  • platform/chromium/test_expectations.txt: assert was fixed, remove custom expectation for inspector/debugger/pause-in-inline-script.html
07:56 Changeset [106661] by apavlov@chromium.org
  • 1 edit
    2 copies in branches/chromium/1025

Merge 106560 - Web Inspector: [REGRESSION] Slow continuous DOM traversal with Up/Down keys
https://bugs.webkit.org/show_bug.cgi?id=77643

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/styles/updates-during-dom-traversal.html

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate):

LayoutTests:

  • inspector/styles/updates-during-dom-traversal-expected.txt: Added.
  • inspector/styles/updates-during-dom-traversal.html: Added.

TBR=apavlov@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9310084

07:07 Changeset [106660] by haraken@chromium.org
  • 19 edits in trunk/Source/WebCore

Fix typo
https://bugs.webkit.org/show_bug.cgi?id=77708

Reviewed by Adam Roben.

This patch fixes typos: [ObjCLegacyUnamedParameters] => [ObjCLegacyUnnamedParameters]

No tests. No change in behavior.

  • css/CSSMediaRule.idl:
  • css/CSSPrimitiveValue.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSStyleSheet.idl:
  • dom/CharacterData.idl:
  • dom/DOMImplementation.idl:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/Event.idl:
  • dom/EventTarget.idl:
  • dom/MouseEvent.idl:
  • dom/MutationEvent.idl:
  • dom/NamedNodeMap.idl:
  • dom/Node.idl:
  • dom/Range.idl:
  • dom/UIEvent.idl:
  • html/HTMLSelectElement.idl:
  • xml/XPathExpression.idl:
06:59 Changeset [106659] by noam.rosenthal@nokia.com
  • 19 edits
    2 adds
    2 deletes in trunk/Source

[Qt][Texmap] Refactor TextureMapper API to use ImageBuffers when possible.
https://bugs.webkit.org/show_bug.cgi?id=77148

Reviewed by Martin Robinson.

Source/WebCore:

Removed TextureMapperQt, and instead created a TextureMapperImageBuffer class,
which responds to an "Software" mode of TextureMapper, instead of creating subclasses
of TextureMapper directly. This allows using the software fallback of TextureMapper by any
sort.

To make the ImageBuffer backend easier, content updates to BitmapTexture can now use either
an image, or a raw data pointer. The raw data pointer is provided for performance reasons,
as converting data to/from Image references in Qt generates unnecessary deep copies of the
image data.

Also, functions that use TransformationMatrix were added to GraphicsContext, to allow for
3D transforms in cross platform code.
After this patch everything renders the same. An additional bug report was created to allow
ImageBuffer shallow image copies: https://bugs.webkit.org/show_bug.cgi?id=77689

Covered extensively by existing tests, no behavioral changes.

  • Target.pri:
  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/GraphicsContext.h:

(WebCore):
(GraphicsContext):

  • platform/graphics/cairo/TextureMapperCairo.cpp:
  • platform/graphics/opengl/TextureMapperGL.cpp:

(TextureMapperGLData):
(BitmapTextureGL):
(WebCore::BitmapTextureGL::BitmapTextureGL):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::BitmapTextureGL::reset):
(WebCore):
(WebCore::swizzleBGRAToRGBA):
(WebCore::BitmapTextureGL::updateContents):
(WebCore::BitmapTextureGL::destroy):
(WebCore::TextureMapperGL::bindSurface):
(WebCore::TextureMapper::platformCreateAccelerated):

  • platform/graphics/opengl/TextureMapperGL.h:

(TextureMapperGL):
(WebCore::TextureMapperGL::accelerationMode):
(WebCore):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore):
(WebCore::GraphicsContext::get3DTransform):
(WebCore::GraphicsContext::concat3DTransform):
(WebCore::GraphicsContext::set3DTransform):

  • platform/graphics/qt/TextureMapperQt.cpp: Removed.
  • platform/graphics/qt/TextureMapperQt.h: Removed.
  • platform/graphics/texmap/TextureMapper.cpp:

(WebCore):
(BitmapTextureImageBuffer):
(TextureMapperImageBuffer):

  • platform/graphics/texmap/TextureMapper.h:

(WebCore::BitmapTexture::BitmapTexture):
(BitmapTexture):
(WebCore::BitmapTexture::bpp):
(WebCore::BitmapTexture::isOpaque):
(WebCore::TextureMapper::setGraphicsContext):
(WebCore::TextureMapper::graphicsContext):
(TextureMapper):
(WebCore::TextureMapper::TextureMapper):
(WebCore::TextureMapper::platformCreateAccelerated):

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::renderContent):
(WebCore::TextureMapperNode::setContentsTileBackBuffer):

  • platform/graphics/texmap/TextureMapperNode.h:

(TextureMapperNode):

Source/WebKit/qt:

Use TextureMapper::create instead of creating TextureMapperGL/TextureMapperQt directly.

  • Api/qwebframe.cpp:

(QWebFramePrivate::renderCompositedLayers):

  • WebCoreSupport/PageClientQt.cpp:

(WebCore::PageClientQWidget::setRootGraphicsLayer):
(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):

Source/WebKit2:

Use TextureMapper::create instead of creating TextureMapperGL/TextureMapperQt directly.
Remove calls to unused API.

  • UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit::LayerTreeHostProxy::paintToGraphicsContext):
(WebKit::LayerTreeHostProxy::createImage):
(WebKit::LayerTreeHostProxy::ensureRootLayer):

06:47 Changeset [106658] by jocelyn.turcotte@nokia.com
  • 25 edits
    1 copy
    1 move
    1 add
    1 delete in trunk

[Qt] Split QQuickWebViewPrivate in two classes, for desktop and touch behavior.
https://bugs.webkit.org/show_bug.cgi?id=77632

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Replace the runtime property setting the desktop behavior on each instance
by a static boolean controlling the behavior used by future created WebViews.

  • UIProcess/API/qt/qquickwebpage.cpp:

Let only setContentsSize control the size of the drawing area instead of deferring
it until geometryChanged is called.
(QQuickWebPagePrivate::QQuickWebPagePrivate):

  • UIProcess/API/qt/qquickwebpage_p.h:
  • UIProcess/API/qt/qquickwebpage_p_p.h:

(QQuickWebPagePrivate):

  • UIProcess/API/qt/qquickwebview.cpp:

(createPrivateObject):
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::~QQuickWebViewPrivate):
(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::processDidCrash):
(QQuickWebViewLegacyPrivate::QQuickWebViewLegacyPrivate):
(QQuickWebViewLegacyPrivate::initialize):
(QQuickWebViewLegacyPrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::QQuickWebViewFlickablePrivate):
(QQuickWebViewFlickablePrivate::~QQuickWebViewFlickablePrivate):
(QQuickWebViewFlickablePrivate::initialize):
(QQuickWebViewFlickablePrivate::loadDidCommit):
(QQuickWebViewFlickablePrivate::didFinishFirstNonEmptyLayout):
(QQuickWebViewFlickablePrivate::didChangeViewportProperties):
(QQuickWebViewFlickablePrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::_q_updateVisibleContentRectAndScale):
(QQuickWebViewFlickablePrivate::_q_suspend):
(QQuickWebViewFlickablePrivate::_q_resume):
(QQuickWebViewFlickablePrivate::pageDidRequestScroll):
(QQuickWebViewFlickablePrivate::didChangeContentsSize):
(QQuickWebViewFlickablePrivate::computeViewportConstraints):
(QQuickWebViewFlickablePrivate::PostTransitionState::apply):
(QQuickWebViewExperimental::setFlickableViewportEnabled):
The switch is now a static function that has to be called before a WebView
is created. The switch can have it's default defined by the deploying platform.
(QQuickWebViewExperimental::flickableViewportEnabled):
(QQuickWebView::QQuickWebView):
On creation of QQuickWebView, the static boolean is read to know if we want
a QQuickWebViewTouchPrivate or a QQuickWebViewDesktopPrivate.
(QQuickWebView::geometryChanged):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):
(QQuickWebViewPrivate::loadDidCommit):
(QQuickWebViewPrivate::didFinishFirstNonEmptyLayout):
(QQuickWebViewPrivate::didChangeViewportProperties):
(QQuickWebViewPrivate::viewportInteractionEngine):
(QQuickWebViewPrivate::updateViewportSize):
(QQuickWebViewPrivate::_q_updateVisibleContentRectAndScale):
(QQuickWebViewPrivate::_q_suspend):
(QQuickWebViewPrivate::_q_resume):
(QQuickWebViewPrivate::pageDidRequestScroll):
(QQuickWebViewPrivate::didChangeContentsSize):
(QQuickWebViewLegacyPrivate):
(QQuickWebViewFlickablePrivate):
(QQuickWebViewFlickablePrivate::viewportInteractionEngine):
(PostTransitionState):
(QQuickWebViewFlickablePrivate::PostTransitionState::PostTransitionState):

  • UIProcess/API/qt/qwebviewportinfo.cpp:

(QWebViewportInfo::currentScale):
(QWebViewportInfo::devicePixelRatio):
(QWebViewportInfo::initialScale):
(QWebViewportInfo::minimumScale):
(QWebViewportInfo::maximumScale):
(QWebViewportInfo::isScalable):
(QWebViewportInfo::layoutSize):

  • UIProcess/API/qt/tests/publicapi/publicapi.pro:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior.pro: Added.
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/DesktopWebView.qml: Removed.
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_itemSelector.qml: Renamed

from Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_itemSelector.qml.
Moved to DesktopBehavior instead of using a DesktopWebView to workaround the touch event limitation.

  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_messaging.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml:
  • UIProcess/API/qt/tests/qmltests/WebView.pro: Copied

from Source/WebKit2/UIProcess/API/qt/tests/qmltests/qmltests.pro.

  • UIProcess/API/qt/tests/qmltests/qmltests.pro:

Split qmltests in two executables, tst_qmltests_DesktopBehavior and tst_qmltests_WebView.
The former runs without setFlickableViewportEnabled and the later does.

  • UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp:

(main):

  • UIProcess/API/qt/tests/qquickwebview/qquickwebview.pro:
  • UIProcess/API/qt/tests/tests.pri:
  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::QtWebPageEventHandler):

Tools:

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):

  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::sendTouchEvent):
(MiniBrowserApplication::handleUserOptions):

  • MiniBrowser/qt/MiniBrowserApplication.h:

(WindowOptions):
(WindowOptions::WindowOptions):

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::PlatformWebView):

  • WebKitTestRunner/qt/main.cpp:

(main):

  • qmake/mkspecs/features/default_post.prf:
06:47 Changeset [106657] by yurys@chromium.org
  • 12 edits
    2 adds in trunk

Web Inspector: console evaluation doesn't work on breakpoint in pages with CSP
https://bugs.webkit.org/show_bug.cgi?id=77203

Inspector console evaluation now works when debugger is paused in a page with
content-security-policy prohibiting evals.

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/eval-on-pause-blocked.html

  • bindings/js/JSInjectedScriptHostCustom.cpp:
  • bindings/js/ScriptState.cpp:

(WebCore::evalEnabled):
(WebCore):
(WebCore::setEvalEnabled):

  • bindings/js/ScriptState.h:

(WebCore):

  • bindings/v8/ScriptObject.h:

(WebCore::ScriptObject::ScriptObject):

  • bindings/v8/ScriptState.cpp:

(WebCore::evalEnabled):
(WebCore):
(WebCore::setEvalEnabled):

  • bindings/v8/ScriptState.h:

(WebCore):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::makeCall):

  • inspector/InjectedScriptHost.idl:
  • inspector/InjectedScriptSource.js:

(.):

LayoutTests:

  • inspector/debugger/eval-on-pause-blocked-expected.txt: Added.
  • inspector/debugger/eval-on-pause-blocked.html: Added.
06:44 Changeset [106656] by jocelyn.turcotte@nokia.com
  • 8 edits in trunk/Source/WebKit2

[Qt] Rename content* to contents* in QQuickWebPage.
https://bugs.webkit.org/show_bug.cgi?id=77629

Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPagePrivate::QQuickWebPagePrivate):
(QQuickWebPagePrivate::paintToCurrentGLContext):
(QQuickWebPage::setContentsSize):
(QQuickWebPage::contentsSize):
(QQuickWebPage::setContentsScale):
(QQuickWebPage::contentsScale):
(QQuickWebPage::transformToItem):
(QQuickWebPagePrivate::updateSize):

  • UIProcess/API/qt/qquickwebpage_p.h:
  • UIProcess/API/qt/qquickwebpage_p_p.h:

(QQuickWebPagePrivate):

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::didChangeContentsSize):
(QQuickWebViewPrivate::updateVisibleContentRectAndScale):
(QQuickWebViewPrivate::PostTransitionState::apply):

  • UIProcess/API/qt/qwebviewportinfo.cpp:

(QWebViewportInfo::contentsSize):

  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::scrollRequest):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::setItemRectVisible):
(WebKit::QtViewportInteractionEngine::event):
(WebKit::QtViewportInteractionEngine::wheelEvent):
(WebKit::QtViewportInteractionEngine::pagePositionRequest):
(WebKit::QtViewportInteractionEngine::computePosRangeForItemAtScale):
(WebKit::QtViewportInteractionEngine::applyConstraints):
(WebKit::QtViewportInteractionEngine::currentCSSScale):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
(WebKit::QtViewportInteractionEngine::scaleContent):

06:05 Changeset [106655] by rwlbuis@webkit.org
  • 4 edits in trunk/Source/WebCore

2012-02-03 Rob Buis <rbuis@rim.com>

Upstream targetType usage on ResourceRequest for BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=77649

Reviewed by Antonio Gomes.

Upstream bits that make use of targetType enum.

  • loader/PingLoader.cpp: (WebCore::PingLoader::loadImage): (WebCore::PingLoader::sendPing): (WebCore::PingLoader::reportContentSecurityPolicyViolation):
  • platform/network/blackberry/ResourceRequest.h: (ResourceRequest): (WebCore::ResourceRequest::targetType): (WebCore::ResourceRequest::setTargetType):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::createRequest):
05:42 Changeset [106654] by commit-queue@webkit.org
  • 35 edits
    4 adds in trunk

Source/WebCore: Ensure timers and other active DOM objects do not fire in suspended documents.
https://bugs.webkit.org/show_bug.cgi?id=53733

ScriptExecutionContext now remembers it has suspended active DOM objects
and suspends all newly installed active DOM objects as well.

All create-calls active DOM objects now calls the post constructor method
suspendIfNeeded that updates the suspend state. It is post constructor
because the suspend/resume functions are virtual and thus can not be called
from constructors.

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-03
Reviewed by Mihai Parparita.

Test: fast/events/suspend-timers.html

  • Modules/intents/IntentRequest.cpp:

(WebCore::IntentRequest::create):

  • bindings/generic/ActiveDOMCallback.cpp:

(WebCore::ActiveDOMCallback::ActiveDOMCallback):

  • dom/ActiveDOMObject.cpp:

(WebCore::ActiveDOMObject::ActiveDOMObject):
(WebCore::ActiveDOMObject::~ActiveDOMObject):
(WebCore::ActiveDOMObject::suspendIfNeeded):

  • dom/ActiveDOMObject.h:

(WebCore::ActiveDOMObject::suspendIfNeededCalled):

  • dom/DocumentEventQueue.cpp:

(WebCore::DocumentEventQueue::DocumentEventQueue):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::ScriptExecutionContext):
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
(WebCore::ScriptExecutionContext::stopActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjectIfNeeded):

  • dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::activeDOMObjectsAreSuspended):

  • fileapi/DOMFileSystem.cpp:

(WebCore::DOMFileSystem::create):

  • fileapi/FileReader.cpp:

(WebCore::FileReader::create):

  • fileapi/FileReader.h:
  • fileapi/FileWriter.cpp:

(WebCore::FileWriter::create):

  • fileapi/FileWriter.h:
  • history/CachedFrame.cpp:

(WebCore::CachedFrame::CachedFrame):

  • html/HTMLAudioElement.cpp:

(WebCore::HTMLAudioElement::create):

  • html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::create):

  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::create):

  • mediastream/PeerConnection.cpp:

(WebCore::PeerConnection::create):

  • notifications/Notification.cpp:

(WebCore::Notification::create):

  • notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::create):

  • notifications/NotificationCenter.h:
  • page/DOMTimer.cpp:

(WebCore::DOMTimer::install):
(WebCore::DOMTimer::fired):

  • page/EventSource.cpp:

(WebCore::EventSource::create):

  • page/SuspendableTimer.cpp:

(WebCore::SuspendableTimer::SuspendableTimer):

  • storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::create):

  • storage/IDBRequest.cpp:

(WebCore::IDBRequest::create):

  • storage/IDBTransaction.cpp:

(WebCore::IDBTransaction::create):

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::create):

  • websockets/WebSocket.cpp:

(WebCore::WebSocket::create):

  • websockets/WebSocket.h:
  • workers/SharedWorker.cpp:

(WebCore::SharedWorker::create):

  • workers/Worker.cpp:

(WebCore::Worker::create):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::create):

LayoutTests: Test that timers do not fire from subframes of suspended documents.
https://bugs.webkit.org/show_bug.cgi?id=53733

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-03
Reviewed by Mihai Parparita.

  • fast/events/resources/suspend-subframe-1.html: Added.
  • fast/events/resources/suspend-subframe-2.html: Added.
  • fast/events/suspend-timers-expected.txt: Added.
  • fast/events/suspend-timers.html: Added.
  • platform/chromium/test_expectations.txt:
05:36 Changeset [106653] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2012-02-03 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium deps.

  • DEPS:
05:23 Changeset [106652] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

New test introduced in r106642 failes on Qt Linux Release
https://bugs.webkit.org/show_bug.cgi?id=77729

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-02-03
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
05:05 Changeset [106651] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[Qt] Fix build when cross-compiling
https://bugs.webkit.org/show_bug.cgi?id=77634

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-02-03
Reviewed by Tor Arne Vestbø.

Source/WebKit2:

  • WebKit2.pri: Link in -lrt on linux mkspecs, regardless of whether gcc

is in use or not. More specifically this fixes the case where the makespace
is not linux-g++* but for a cross-compiling one like linux-arm-gnueabi-g++.

Source/WTF:

  • WTF.pri: Don't use icu-config for determining the library search

path and libraries needed for ICU. Either we use icu-config for includes
_and_ libraries or we don't. Right now we assume that icu is a system library
and expect the headers in the default include search pathes (/usr/include for example).
However we use icu-config to figure out where the libraries are, which breaks when
cross-compiling, because icu-config isn't cross-compile friendly (I wish icu was using
pkg-config). I think for the time being we should require ICU as a _system_ library,
which implies the header and library availability in default search paths. This also
makes the build succeed when cross-compiling with --sysroot.

04:51 Changeset [106650] by commit-queue@webkit.org
  • 6 edits
    1 delete in trunk

[Qt] Replace GNU linker script for exports with export macros in WTF/JSC
https://bugs.webkit.org/show_bug.cgi?id=77723

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-02-03
Reviewed by Tor Arne Vestbø.

.:

  • Source/api.pri: Remove use of GNU linker script on Linux.
  • Source/qtwebkit-export.map: Removed.

Source/JavaScriptCore:

  • wtf/Platform.h: Enable use of export macros.

Tools:

  • Tools.pro: Compile WTR again on all platforms with WK2.
04:49 Changeset [106649] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Do not ASSERT on TouchStationary TouchPoint state.
https://bugs.webkit.org/show_bug.cgi?id=77620

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-03
Reviewed by Kenneth Rohde Christiansen.

  • page/EventHandler.cpp:

(WebCore::eventNameForTouchPointState): Explicitly show that TouchStationary is asserted.
(WebCore::EventHandler::handleTouchEvent):

Remove TouchStationary from ASSERT. The value of HitTestRequest is restored to the
value it should have if hittested, but is not used.

04:14 Changeset [106648] by haraken@chromium.org
  • 25 edits in trunk/Source/WebCore

Add the "ObjC" prefix to ObjC specific IDL attributes
https://bugs.webkit.org/show_bug.cgi?id=77708

Reviewed by Adam Barth.

This patch adds the "ObjC" prefix to ObjC specific IDL attributes, as follows:

[Polymorphic] => [ObjCPolymorphic]
[OldStyleObjC] => [ObjCLegacyUnamedParameters]
[UsesView] => [ObjCUseDefaultView] (Note: Renamed for clarification)

No tests. No changes in behavior.

  • bindings/scripts/CodeGeneratorObjC.pm:

(GenerateHeader):
(GenerateImplementation):

  • css/CSSMediaRule.idl:
  • css/CSSPrimitiveValue.idl:
  • css/CSSRule.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSStyleSheet.idl:
  • css/CSSValue.idl:
  • css/StyleSheet.idl:
  • dom/CharacterData.idl:
  • dom/DOMImplementation.idl:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/Event.idl:
  • dom/EventTarget.idl:
  • dom/MouseEvent.idl:
  • dom/MutationEvent.idl:
  • dom/NamedNodeMap.idl:
  • dom/Node.idl:
  • dom/Range.idl:
  • dom/UIEvent.idl:
  • html/HTMLCollection.idl:
  • html/HTMLSelectElement.idl:
  • svg/SVGPathSeg.idl:
  • xml/XPathExpression.idl:
04:02 Changeset [106647] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Ensure that inspector disabled build works
https://bugs.webkit.org/show_bug.cgi?id=77604

Patch by Sriram Neelakandan <sriram.neelakandan@gmail.com> on 2012-02-03
Reviewed by Tor Arne Vestbø.

  • qmake/mkspecs/features/features.prf:
03:39 Changeset [106646] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

TypingCommand should be prepared against detached document.
https://bugs.webkit.org/show_bug.cgi?id=77216

Reviewed by Ryosuke Niwa.

Added null checks for document()->frame().

No new tests. Just tighten guards for possible codepaths.

  • editing/TypingCommand.cpp:

(WebCore::TypingCommand::markMisspellingsAfterTyping):
(WebCore::TypingCommand::typingAddedToOpenCommand):
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):

03:05 Changeset [106645] by haraken@chromium.org
  • 26 edits in trunk/Source/WebCore

Rename [DontEnum] IDL to [NotEnumerable] IDL
https://bugs.webkit.org/show_bug.cgi?id=77710

Reviewed by Adam Barth.

[DontEnum] is a negation of Enumerable? in the ECMAScript spec
(8.6.1 of http://www.ecma-international.org/publications/files/ECMA-ST/Ecma-262.pdf).
This patch renames [DontEnum] to [NotEnumerable].

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateAttributesHashTable):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateSingleBatchedAttribute):
(GenerateImplementation):

  • css/WebKitCSSMatrix.idl:
  • dom/DOMCoreException.idl:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/EventException.idl:
  • dom/RangeException.idl:
  • fileapi/FileException.idl:
  • fileapi/OperationNotAllowedException.idl:
  • html/DOMTokenList.idl:
  • html/HTMLAnchorElement.idl:
  • html/HTMLBodyElement.idl:
  • html/HTMLFrameSetElement.idl:
  • html/HTMLInputElement.idl:
  • page/DOMSelection.idl:
  • page/DOMWindow.idl:
  • page/Location.idl:
  • storage/IDBDatabaseException.idl:
  • storage/Storage.idl:
  • svg/SVGElementInstance.idl:
  • svg/SVGException.idl:
  • workers/WorkerLocation.idl:
  • xml/XMLHttpRequestException.idl:
  • xml/XPathException.idl:
03:02 Changeset [106644] by haraken@chromium.org
  • 21 edits in trunk/Source/WebCore

Rename [InitializedByConstructor] IDL to [InitializedByEventConstructor] IDL
https://bugs.webkit.org/show_bug.cgi?id=77711

Reviewed by Adam Barth.

[InitializedByConstructor] can be used only when [ConstructorTemplate=Event]
is specified on the interface. This patch renames [InitializedByConstructor] to
[InitializedByEventConstructor] for clarification.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateConstructorDefinition):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateEventConstructorCallback):

  • bindings/scripts/test/TestEventConstructor.idl:
  • bindings/scripts/test/V8/V8TestEventConstructor.cpp: Updated the run-bindings-tests results.

(WebCore):

  • dom/BeforeLoadEvent.idl:
  • dom/CustomEvent.idl:
  • dom/ErrorEvent.idl:
  • dom/Event.idl:
  • dom/HashChangeEvent.idl:
  • dom/MessageEvent.idl:
  • dom/OverflowEvent.idl:
  • dom/PageTransitionEvent.idl:
  • dom/PopStateEvent.idl:
  • dom/ProgressEvent.idl:
  • dom/WebKitAnimationEvent.idl:
  • dom/WebKitTransitionEvent.idl:
  • html/canvas/WebGLContextEvent.idl:
  • html/track/TrackEvent.idl:
  • storage/StorageEvent.idl:
  • websockets/CloseEvent.idl:
02:31 Changeset [106643] by haraken@chromium.org
  • 6 edits in trunk/Source/WebCore

Add the "CPP" prefix to CPP specific IDL attributes
https://bugs.webkit.org/show_bug.cgi?id=77707

Reviewed by Adam Barth.

This patch adds the "CPP" prefix to a CPP specific IDL attribute.
Specifically, this patch renames [PureInterface] to [CPPPureInterface]

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorCPP.pm:

(GenerateHeader):
(GenerateImplementation):

  • css/MediaQueryListListener.idl:
  • dom/EventListener.idl:
  • dom/EventTarget.idl:
  • dom/NodeFilter.idl:
02:10 Changeset [106642] by apavlov@chromium.org
  • 10 edits
    2 adds in trunk

Implement touch event emulation in the WebCore layer
https://bugs.webkit.org/show_bug.cgi?id=77105

Reviewed by Ryosuke Niwa.

Source/WebCore:

This change essentially maps mouse events into single-touch events in the following way:

  • mousedown -> touchstart
  • mouseup -> touchend
  • mousemove -> touchmove (between mousedown and mouseup).

Test: fast/events/touch/emulate-touch-events.html

  • page/EventHandler.cpp:

(SyntheticTouchPoint): A synthetic touch point built from PlatformMouseEvent.
(WebCore::SyntheticTouchPoint::SyntheticTouchPoint):
(SyntheticSingleTouchEvent): A synthetic touch point event built from PlatformMouseEvent.
(WebCore::SyntheticSingleTouchEvent::SyntheticSingleTouchEvent):
(WebCore::EventHandler::handleMouseReleaseEvent): Invoke maybeDispatchSyntheticTouchEvent() and bail out if necessary.
(WebCore::EventHandler::handleMousePressEvent): Invoke maybeDispatchSyntheticTouchEvent() and bail out if necessary.
(WebCore::EventHandler::mouseMoved): Invoke maybeDispatchSyntheticTouchEvent() and bail out if necessary.
(WebCore::EventHandler::dispatchSyntheticTouchEventIfEnabled): Dispatch a synthetic touch event if necessary.

  • page/EventHandler.h: Added new method.
  • page/Settings.cpp:

(WebCore::Settings::Settings): Added m_touchEventEmulationEnabled initializer.

  • page/Settings.h: Added m_touchEventEmulationEnabled, getter, and setter.

(WebCore::Settings::setTouchEventEmulationEnabled): Added.
(WebCore::Settings::isTouchEventEmulationEnabled): Added.

  • platform/PlatformTouchPoint.h:

(WebCore::PlatformTouchPoint::PlatformTouchPoint): Unconditionally compile the parameterless ctor.

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::setTouchEventEmulationEnabled): Added for testing.

  • testing/InternalSettings.h: Added setTouchEventEmulationEnabled() for testing.
  • testing/InternalSettings.idl: Added setTouchEventEmulationEnabled() for testing.

LayoutTests:

  • fast/events/touch/emulate-touch-events-expected.txt: Added.
  • fast/events/touch/emulate-touch-events.html: Added.
02:04 Changeset [106641] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Group all the security failures together.

  • platform/chromium/test_expectations.txt:
02:01 Changeset [106640] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Remove [NoCPPCustom] IDL
https://bugs.webkit.org/show_bug.cgi?id=77704

Reviewed by Adam Barth.

This patch removes [NoCPPCustom], by replacing [Custom, NoCPPCustom]
in HTMLDocument.idl with [JSCCustom, V8Custom].

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorCPP.pm:

(ShouldSkipType):

  • html/HTMLDocument.idl:
01:54 Changeset [106639] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

Remove [LegacyParent] from CodeGeneratorGObject.pm, and rename it to [JSLegacyParent]
https://bugs.webkit.org/show_bug.cgi?id=77706

Reviewed by Adam Barth.

This patch removes dead code about [LegacyParent] from CodeGeneratorGObject.pm,
and renames [LegacyParent] to [JSLegacyParent].

No tests. No changes in behavior.

  • bindings/scripts/CodeGeneratorGObject.pm:

(Generate):

  • bindings/scripts/CodeGeneratorJS.pm:

(GetParentClassName):
(GenerateHeader):
(GenerateImplementation):

  • page/DOMWindow.idl:
  • workers/WorkerContext.idl:
01:28 Changeset [106638] by pfeldman@chromium.org
  • 5 edits
    2 adds in trunk

Web Inspector: preserve elements panel selection upon node drag'n'drop
https://bugs.webkit.org/show_bug.cgi?id=77722

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: inspector/elements/move-node.html

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype._markRevision):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype._ondrop):
(WebInspector.ElementsTreeOutline.prototype._doMove.callback):
(WebInspector.ElementsTreeOutline.prototype._doMove):

LayoutTests:

  • inspector/elements/move-node-expected.txt: Added.
  • inspector/elements/move-node.html: Added.
00:30 Changeset [106637] by commit-queue@webkit.org
  • 13 edits in trunk

Source/WebCore: Reimplement DETAILS and SUMMARY using selector query.
https://bugs.webkit.org/show_bug.cgi?id=75930

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-03
Reviewed by Hajime Morita.

DETAILS is reimplemented using content element and its fallback feature.
We don't need to recreate DOM even if SUMMARY is removed from or added into DETAILS.

No new tests, should be covered by existing tests.

  • html/HTMLDetailsElement.cpp:

(WebCore::DetailsSummaryElement::fallbackSummary):

Takes fallback element of content summary.

(DetailsSummaryElement):
(WebCore::DetailsSummaryElement::create):

Creates a fallback element also.

(WebCore):
(WebCore::HTMLDetailsElement::create):
(WebCore::HTMLDetailsElement::HTMLDetailsElement):
(WebCore::HTMLDetailsElement::createShadowSubtree):
(WebCore::HTMLDetailsElement::findMainSummary):
(WebCore::HTMLDetailsElement::parseMappedAttribute):
(WebCore::HTMLDetailsElement::childShouldCreateRenderer):
(WebCore::HTMLDetailsElement::toggleOpen):

  • html/HTMLDetailsElement.h:

(HTMLDetailsElement):

  • html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::isMainSummary):

LayoutTests: Reimplement DETAILS and SUMMARY using selector query.
https://bugs.webkit.org/show_bug.cgi?id=75930

Since the implementation of DETAILS shadow tree, the path of caret position is also changed.

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-03
Reviewed by Hajime Morita.

  • platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/qt/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/qt/fast/html/details-remove-summary-4-and-click-expected.txt:
00:19 Changeset [106636] by jochen@chromium.org
  • 2 edits in trunk/Source/WebCore

Crash when trying to add a timer to a detached document.
https://bugs.webkit.org/show_bug.cgi?id=77692

Reviewed by Alexey Proskuryakov.

In http://webkit.org/b/77370, a timer is fired on a detached document.
Since a document clears all timers when it is detached, and it
shouldn't be possible to add a timer to a detached document, we crash
if this should happen anyway. This will hopefully result in an easier
to debug crash dump.

  • page/DOMTimer.cpp:

(WebCore::DOMTimer::DOMTimer):

00:16 Changeset [106635] by commit-queue@webkit.org
  • 8 edits in trunk

Stop calling Element::ensureShadowRoot in Internals.
https://bugs.webkit.org/show_bug.cgi?id=77612

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-03
Reviewed by Hajime Morita.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

We want to check a shadow root is built-in or created by users to support multiple shadow subtrees.
But Element::ensureShadowRoot() makes it difficult, because it doesn't care about the returning shadow element
is built-in or user generated, so let's remove Element::ensureShadowRoot().

As a first step, this patch removes ensureShadowRoot() in Internals.

No new tests, because no changes in behavior.

  • WebCore.exp.in:
  • testing/Internals.cpp:

(WebCore::Internals::ensureShadowRoot):

Source/WebKit2:

Exports symbols.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

02/02/12:

23:44 Changeset [106634] by mrowe@apple.com
  • 2 edits in trunk

<http://webkit.org/b/77717> Makefile should provide control over output verbosity

Allow the filtering of the output of our Makefile to be configured via a user default
and overriden via a command-line argument to make.

The Makefile takes the verbosity from BuildTranscriptVerbosity default in the
org.webkit.BuildConfiguration domain. The supported values are "default", "quiet"
and "noisy". "default" maintains the existing behavior of only filtering out
the setenv lines from Xcode's shell script build phases. "quiet" filters all output
through filter-build-webkit. "noisy" provides unfiltered output. The verbosity can
be overriden for a single invocation of make by specifying the VERBOSITY variable
on the make command line.

To always get full output:
defaults write org.webkit.BuildConfiguration BuildTranscriptVerbosity noisy

To always get filtered ouptut:
defaults write org.webkit.BuildConfiguration BuildTranscriptVerbosity quiet

To get full output for a single build:
make VERBOSITY=noisy

Reviewed by Dan Bernstein.

  • Makefile.shared:
23:37 Changeset [106633] by commit-queue@webkit.org
  • 8 edits in trunk

Web Inspector: Always show percents together with counters in heap inspector.
https://bugs.webkit.org/show_bug.cgi?id=77434

Source/WebCore:

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-02-02
Reviewed by Pavel Feldman.

  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotGridNode.prototype._toPercentString):
(WebInspector.HeapSnapshotGridNode.prototype._createValueCell):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.createCell):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
(WebInspector.HeapSnapshotConstructorNode.prototype.createCell):
(WebInspector.HeapSnapshotConstructorNode.prototype.get data):
(WebInspector.HeapSnapshotDiffNode.prototype.get data):

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.HeapSnapshotContainmentDataGrid):
(WebInspector.HeapSnapshotConstructorsDataGrid):
(WebInspector.HeapSnapshotDiffDataGrid):
(WebInspector.HeapSnapshotDominatorsDataGrid):
(WebInspector.DetailedHeapshotView.prototype._mouseDownInContentsGrid):
(WebInspector.DetailedHeapshotView.prototype.get _isShowingAsPercent):
(WebInspector.DetailedHeapshotView.prototype._percentClicked):

  • inspector/front-end/heapProfiler.css:

(.detailed-heapshot-view .data-grid span.percent-column):

LayoutTests:

Added parseInt conversion as counters are now strings not ints.

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-02-02
Reviewed by Pavel Feldman.

  • inspector/profiler/detailed-heapshots-comparison-show-all.html:
  • inspector/profiler/detailed-heapshots-comparison-show-next.html:
  • inspector/profiler/detailed-heapshots-summary-show-all.html:
23:30 Changeset [106632] by commit-queue@webkit.org
  • 17 edits
    8 adds in trunk

Use content-language from http-equiv to set document locale and font
https://bugs.webkit.org/show_bug.cgi?id=76701

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-02-02
Reviewed by Darin Adler.

Source/WebCore:

So far, only content-language set through http-equiv is used; the HTTP Content-Language
header is not yet supported.

Tests: fast/text/content-language-case-insensitivity.html

fast/text/content-language-mapped-to-webkit-locale.html
fast/text/international/content-language-font-selection-expected.html
fast/text/international/content-language-font-selection.html
fast/text/international/content-language-with-subtags-expected.html
fast/text/international/content-language-with-subtags.html

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForDocument): Use content language when selecting initial font.

  • dom/Document.cpp:

(WebCore::Document::setContentLanguage): Recalculate style so language is taken into account.
(WebCore):

  • dom/Document.h:

(Document):

LayoutTests:

Add tests that content-language from http-equiv sets document locale and is used in font selection.

  • fast/text/content-language-case-insensitivity-expected.txt: Added.
  • fast/text/content-language-case-insensitivity.html: Added.
  • fast/text/content-language-mapped-to-webkit-locale-expected.txt: Added.
  • fast/text/content-language-mapped-to-webkit-locale.html: Added.
  • fast/text/international/content-language-font-selection-expected.html: Added.
  • fast/text/international/content-language-font-selection.html: Added.
  • fast/text/international/content-language-with-subtags-expected.html: Added.
  • fast/text/international/content-language-with-subtags.html: Added.
  • fast/text/lang-mapped-to-webkit-locale-expected.txt:
  • fast/text/lang-mapped-to-webkit-locale.xhtml: Fix some style issues.
  • fast/text/xml-lang-ignored-in-html-expected.txt:
  • fast/text/xml-lang-ignored-in-html.html: Fix some style issues.
  • platform/efl/Skipped: Skip tests using overridePreference("WebKit*FontMap"...) on non-Chromium ports.
  • platform/gtk-wk2/Skipped: Ditto.
  • platform/gtk/Skipped: Ditto.
  • platform/mac/Skipped: Ditto.
  • platform/qt/Skipped: Ditto.
  • platform/win/Skipped: Ditto.
  • platform/wincairo/Skipped: Ditto.
  • platform/wk2/Skipped: Ditto.
23:12 Changeset [106631] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r106554.

  • platform/qt/Skipped: Skip one more failing test.
22:59 Changeset [106630] by ossy@webkit.org
  • 19 edits
    2 adds
    2 deletes in trunk/Source

Unreviewed, rolling out r106620.
http://trac.webkit.org/changeset/106620
https://bugs.webkit.org/show_bug.cgi?id=77716

It broke non ENABLE(3D_RENDERING) builds (Requested by
Ossy_morning on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-02

Source/WebCore:

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • platform/graphics/GraphicsContext.h:

(WebCore):
(GraphicsContext):

  • platform/graphics/cairo/TextureMapperCairo.cpp:

(WebCore::TextureMapper::create):
(WebCore):

  • platform/graphics/opengl/TextureMapperGL.cpp:

(Entry):
(DirectlyCompositedImageRepository):
(WebCore::TextureMapperGLData::DirectlyCompositedImageRepository::findOrCreate):
(WebCore::TextureMapperGLData::DirectlyCompositedImageRepository::deref):
(WebCore::TextureMapperGLData::DirectlyCompositedImageRepository::DirectlyCompositedImageRepository):
(WebCore::TextureMapperGLData::DirectlyCompositedImageRepository::~DirectlyCompositedImageRepository):
(TextureMapperGLData):
(BitmapTextureGL):
(WebCore::BitmapTextureGL::isOpaque):
(WebCore::BitmapTextureGL::pack):
(WebCore::BitmapTextureGL::unpack):
(WebCore::BitmapTextureGL::isPacked):
(WebCore::BitmapTextureGL::BitmapTextureGL):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::BitmapTextureGL::reset):
(WebCore::BitmapTextureGL::beginPaint):
(WebCore::BitmapTextureGL::endPaint):
(WebCore):
(WebCore::BitmapTextureGL::updateContents):
(WebCore::BitmapTextureGL::updateRawContents):
(WebCore::BitmapTextureGL::setContentsToImage):
(WebCore::BitmapTextureGL::destroy):
(WebCore::TextureMapperGL::bindSurface):

  • platform/graphics/opengl/TextureMapperGL.h:

(TextureMapperGL):
(WebCore::TextureMapperGL::allowSurfaceForRoot):
(BGRA32PremultimpliedBuffer):
(WebCore::BGRA32PremultimpliedBuffer::~BGRA32PremultimpliedBuffer):
(WebCore):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):

  • platform/graphics/qt/GraphicsContextQt.cpp:
  • platform/graphics/qt/TextureMapperQt.cpp: Added.

(WebCore):
(WebCore::BitmapTextureQt::destroy):
(WebCore::BitmapTextureQt::reset):
(WebCore::BitmapTextureQt::beginPaint):
(WebCore::BitmapTextureQt::endPaint):
(WebCore::BitmapTextureQt::updateContents):
(WebCore::BitmapTextureQt::save):
(WebCore::BitmapTextureQt::setContentsToImage):
(WebCore::BitmapTextureQt::pack):
(WebCore::BitmapTextureQt::unpack):
(WebCore::TextureMapperQt::beginClip):
(WebCore::TextureMapperQt::endClip):
(WebCore::TextureMapperQt::viewportSize):
(WebCore::TextureMapperQt::TextureMapperQt):
(WebCore::TextureMapperQt::setGraphicsContext):
(WebCore::TextureMapperQt::graphicsContext):
(WebCore::TextureMapperQt::bindSurface):
(WebCore::TextureMapperQt::drawTexture):
(WebCore::TextureMapper::create):
(WebCore::TextureMapperQt::createTexture):
(WebCore::BitmapTextureQt::BitmapTextureQt):
(WebCore::TextureMapperQt::beginPainting):
(WebCore::TextureMapperQt::endPainting):
(BGRA32PremultimpliedBufferQt):
(WebCore::BGRA32PremultimpliedBufferQt::beginPaint):
(WebCore::BGRA32PremultimpliedBufferQt::endPaint):
(WebCore::BGRA32PremultimpliedBufferQt::data):
(WebCore::BGRA32PremultimpliedBuffer::create):
(WebCore::uidForImage):

  • platform/graphics/qt/TextureMapperQt.h: Added.

(WebCore):
(BitmapTextureQt):
(WebCore::BitmapTextureQt::~BitmapTextureQt):
(WebCore::BitmapTextureQt::size):
(WebCore::BitmapTextureQt::isValid):
(WebCore::BitmapTextureQt::sourceRect):
(WebCore::BitmapTextureQt::isPacked):
(WebCore::BitmapTextureQt::painter):
(TextureMapperQt):
(WebCore::TextureMapperQt::allowSurfaceForRoot):
(WebCore::TextureMapperQt::initialize):
(WebCore::TextureMapperQt::create):
(WebCore::TextureMapperQt::currentPainter):

  • platform/graphics/texmap/TextureMapper.cpp:
  • platform/graphics/texmap/TextureMapper.h:

(WebCore::BitmapTexture::BitmapTexture):
(WebCore::BitmapTexture::allowOfflineTextureUpload):
(BitmapTexture):
(WebCore::BitmapTexture::pack):
(WebCore::BitmapTexture::unpack):
(WebCore::BitmapTexture::isPacked):
(WebCore::BitmapTexture::updateRawContents):
(WebCore::BitmapTexture::beginPaintMedia):
(WebCore::BitmapTexture::save):
(WebCore::BitmapTexture::lock):
(WebCore::BitmapTexture::unlock):
(WebCore::BitmapTexture::isLocked):
(TextureMapper):
(WebCore::TextureMapper::viewportSize):
(WebCore::TextureMapper::setViewportSize):
(WebCore::TextureMapper::allowPartialUpdates):
(WebCore::TextureMapper::isOpenGLBacked):
(WebCore::TextureMapper::setTransform):
(WebCore::TextureMapper::transform):

  • platform/graphics/texmap/TextureMapperImageBuffer.cpp: Removed.
  • platform/graphics/texmap/TextureMapperImageBuffer.h: Removed.
  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::renderContent):
(WebCore::TextureMapperNode::setContentsTileBackBuffer):

  • platform/graphics/texmap/TextureMapperNode.h:

(TextureMapperNode):

Source/WebKit/qt:

  • Api/qwebframe.cpp:

(QWebFramePrivate::renderCompositedLayers):

  • WebCoreSupport/PageClientQt.cpp:

(WebCore::PageClientQWidget::setRootGraphicsLayer):
(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):

Source/WebKit2:

  • UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit::LayerTreeHostProxy::paintToGraphicsContext):
(WebKit::LayerTreeHostProxy::createImage):
(WebKit::LayerTreeHostProxy::ensureRootLayer):

22:44 Changeset [106629] by mikelawther@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

gradient tests for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75822

Reviewed by Hajime Morita.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

  • css3/calc/css3-radial-gradients-expected-mismatch.html: Added.
  • css3/calc/css3-radial-gradients.html: Added.
  • css3/calc/gradient-color-stops-expected-mismatch.html: Added.
  • css3/calc/gradient-color-stops.html: Added.
21:44 Changeset [106628] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

ColorInputType needs to use ensureInlineStyleDecl
https://bugs.webkit.org/show_bug.cgi?id=77699

Reviewed by Kent Tamura.

Because WebCore internally should use the more specific CSSMutableStyleDeclaration
http://trac.webkit.org/changeset/105739

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::updateColorSwatch):

21:42 Changeset [106627] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Add contentsSize flag into ewk_tiled_backing_store's private data.
https://bugs.webkit.org/show_bug.cgi?id=77586

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2012-02-02
Reviewed by Andreas Kling.

As both zoom and content size change are identified by model flag,
ewk_tiled_backing_store can not detect the conflict between them.
In order to prevent conflict between zoom and contents size change,
contentsSize flag is newly added.

  • ewk/ewk_tiled_backing_store.cpp:

(_Ewk_Tiled_Backing_Store_Item):
(_Ewk_Tiled_Backing_Store_Data):
(_ewk_tiled_backing_store_smart_calculate):
(ewk_tiled_backing_store_contents_resize):

21:29 Changeset [106626] by rolandsteiner@chromium.org
  • 4 edits in trunk/Source/WebCore

Simplify SelectorChecker::checkSelector and checkOneSelector
https://bugs.webkit.org/show_bug.cgi?id=77697

Make use of Element::previous/nextElementSibling.
Made those methods inline.
Simplify code in checkSelector and checkOneSelector, esp. for first/nth/nth-last/last/only-child implementations.

Reviewed by Andreas Kling.

No new tests. (refactoring)

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkSelector):
(WebCore::SelectorChecker::checkOneSelector):

  • dom/Element.cpp:
  • dom/Element.h:

(WebCore::Element::previousElementSibling):
(WebCore):
(WebCore::Element::nextElementSibling):

21:26 Changeset [106625] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

ColorChooserClient is missing a virtual destructor
https://bugs.webkit.org/show_bug.cgi?id=77698

Reviewed by Kent Tamura.

  • platform/ColorChooserClient.h:

(WebCore::ColorChooserClient::~ColorChooserClient): Added.

21:14 Changeset [106624] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove OVERRIDE from ColorInputType::valueAsColor
https://bugs.webkit.org/show_bug.cgi?id=77701

Reviewed by Kent Tamura.

  • html/ColorInputType.h:

(WebCore::ColorInputType::valueAsColor):

20:51 Changeset [106623] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

Support 'disabled' attribute on SVGStyleElement
https://bugs.webkit.org/show_bug.cgi?id=52130

Source/WebCore:

Adding disabled property to SVGStyleElement, which
mirrors the functionality added to HTMLStyleElement
for DOM1. The disabled property reflects and sets
the disabled state of its style sheet.

Based off of patch for bug 25287

Patch by Bear Travis <betravis@adobe.com> on 2012-02-02
Reviewed by Dirk Schulze.

Test: svg/dom/SVGStyleElement/disable-svg-style-element.html

  • svg/SVGStyleElement.cpp:

(WebCore::SVGStyleElement::disabled):
(WebCore):
(WebCore::SVGStyleElement::setDisabled):

  • svg/SVGStyleElement.h:

(SVGStyleElement):

  • svg/SVGStyleElement.idl:

LayoutTests:

Test the disabled property of an svg style element.
Based off of the patch for bug 25287.

Patch by Bear Travis <betravis@adobe.com> on 2012-02-02
Reviewed by Dirk Schulze.

  • svg/dom/SVGStyleElement/disable-svg-style-element-expected.txt: Added.
  • svg/dom/SVGStyleElement/disable-svg-style-element.html: Added.
  • svg/dom/SVGStyleElement/script-tests/disable-svg-style-element.js: Added.

(createStyle):

20:37 Changeset [106622] by hayato@chromium.org
  • 2 edits in trunk/Source/WebCore

Make ShadowRoot interface inherit DocumentFragment interface in IDL.
https://bugs.webkit.org/show_bug.cgi?id=77511

Reviewed by Kentaro Hara.

This patch contains only the change of IDL to isolate issues.
Other changes, such as tests for querySelector of ShadowRoot, will be added in follow-up patches.

No tests. No change in behavior.

  • dom/ShadowRoot.idl:
20:08 Changeset [106621] by commit-queue@webkit.org
  • 3 edits
    17 adds in trunk

Check parameters to biquad filters
https://bugs.webkit.org/show_bug.cgi?id=71413

Source/WebCore:

Patch by Raymond Toy <rtoy@google.com> on 2012-02-02
Reviewed by Kenneth Russell.

Tests added for each filter type and for the limiting cases for
each filter type.

  • platform/audio/Biquad.cpp:

(WebCore::Biquad::setLowpassParams):
(WebCore::Biquad::setHighpassParams):
(WebCore::Biquad::setLowShelfParams):
(WebCore::Biquad::setHighShelfParams):
(WebCore::Biquad::setPeakingParams):
(WebCore::Biquad::setAllpassParams):
(WebCore::Biquad::setNotchParams):
(WebCore::Biquad::setBandpassParams):
Check for invalid parameters and clip them to something sensible.
Also check for the limiting cases and try to use the limiting form
of the z-transform for the biquad. Some issues cannot be
consistently handled because the z-transform is not continuous as
the parameters approach the limit.

LayoutTests:

Patch by Raymond Toy <rtoy@chromium.org> on 2012-02-02
Reviewed by Kenneth Russell.

  • webaudio/biquad-allpass-expected.txt: Added
  • webaudio/biquad-allpass.html: Added
  • webaudio/biquad-bandpass-expected.txt: Added
  • webaudio/biquad-bandpass.html: Added
  • webaudio/biquad-highpass-expected.txt: Added
  • webaudio/biquad-highpass.html: Added
  • webaudio/biquad-highshelf-expected.txt: Added
  • webaudio/biquad-highshelf.html: Added
  • webaudio/biquad-lowpass-expected.txt: Added
  • webaudio/biquad-lowpass.html: Added
  • webaudio/biquad-lowshelf-expected.txt: Added
  • webaudio/biquad-lowshelf.html: Added
  • webaudio/biquad-notch-expected.txt: Added
  • webaudio/biquad-notch.html: Added
  • webaudio/biquad-peaking-expected.txt: Added
  • webaudio/biquad-peaking.html: Added
  • webaudio/resources/biquad-testing.js: Added
20:00 Changeset [106620] by noam.rosenthal@nokia.com
  • 19 edits
    2 adds
    2 deletes in trunk/Source

[Qt][Texmap] Refactor TextureMapper API to use ImageBuffers when possible.
https://bugs.webkit.org/show_bug.cgi?id=77148

Reviewed by Martin Robinson.

Source/WebCore:

Removed TextureMapperQt, and instead created a TextureMapperImageBuffer class,
which responds to an "Software" mode of TextureMapper, instead of creating subclasses
of TextureMapper directly. This allows using the software fallback of TextureMapper by any
sort.

To make the ImageBuffer backend easier, content updates to BitmapTexture can now use either
an image, or a raw data pointer. The raw data pointer is provided for performance reasons,
as converting data to/from Image references in Qt generates unnecessary deep copies of the
image data.

Also, functions that use TransformationMatrix were added to GraphicsContext, to allow for
3D transforms in cross platform code.
After this patch everything renders the same. An additional bug report was created to allow
ImageBuffer shallow image copies: https://bugs.webkit.org/show_bug.cgi?id=77689

Covered extensively by existing tests, no behavioral changes.

  • Target.pri:
  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/GraphicsContext.h:

(WebCore):
(GraphicsContext):

  • platform/graphics/cairo/TextureMapperCairo.cpp:
  • platform/graphics/opengl/TextureMapperGL.cpp:

(TextureMapperGLData):
(BitmapTextureGL):
(WebCore::BitmapTextureGL::BitmapTextureGL):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::BitmapTextureGL::reset):
(WebCore):
(WebCore::swizzleBGRAToRGBA):
(WebCore::BitmapTextureGL::updateContents):
(WebCore::BitmapTextureGL::destroy):
(WebCore::TextureMapperGL::bindSurface):
(WebCore::TextureMapper::platformCreateAccelerated):

  • platform/graphics/opengl/TextureMapperGL.h:

(TextureMapperGL):
(WebCore::TextureMapperGL::accelerationMode):
(WebCore):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore):
(WebCore::GraphicsContext::get3DTransform):
(WebCore::GraphicsContext::concat3DTransform):
(WebCore::GraphicsContext::set3DTransform):

  • platform/graphics/qt/TextureMapperQt.cpp: Removed.
  • platform/graphics/qt/TextureMapperQt.h: Removed.
  • platform/graphics/texmap/TextureMapper.cpp:

(WebCore):
(BitmapTextureImageBuffer):
(TextureMapperImageBuffer):

  • platform/graphics/texmap/TextureMapper.h:

(WebCore::BitmapTexture::BitmapTexture):
(BitmapTexture):
(WebCore::BitmapTexture::bpp):
(WebCore::BitmapTexture::isOpaque):
(WebCore::TextureMapper::setGraphicsContext):
(WebCore::TextureMapper::graphicsContext):
(TextureMapper):
(WebCore::TextureMapper::TextureMapper):
(WebCore::TextureMapper::platformCreateAccelerated):

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::renderContent):
(WebCore::TextureMapperNode::setContentsTileBackBuffer):

  • platform/graphics/texmap/TextureMapperNode.h:

(TextureMapperNode):

Source/WebKit/qt:

Use TextureMapper::create instead of creating TextureMapperGL/TextureMapperQt directly.

  • Api/qwebframe.cpp:

(QWebFramePrivate::renderCompositedLayers):

  • WebCoreSupport/PageClientQt.cpp:

(WebCore::PageClientQWidget::setRootGraphicsLayer):
(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):

Source/WebKit2:

Use TextureMapper::create instead of creating TextureMapperGL/TextureMapperQt directly.
Remove calls to unused API.

  • UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit::LayerTreeHostProxy::paintToGraphicsContext):
(WebKit::LayerTreeHostProxy::createImage):
(WebKit::LayerTreeHostProxy::ensureRootLayer):

19:33 Changeset [106619] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/LayoutTests

Refactoring: Share test drivers of shadow content tests.
https://bugs.webkit.org/show_bug.cgi?id=77584

Extracts shared test code from content-element-move.html and content-element-select-dynamic.html.
This test framework will be used a few more times.

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-02
Reviewed by Hajime Morita.

  • fast/dom/resources/shadow-test-driver.js: Added.

(log):
(cleanUp):
(removeContainerLines):
(check):
(createSpanWithText):
(createContentWithSelect):
(appendShadow):
(appendShadowDeep):
(doTestIfLeft.callIfDone):
(doneTest):
(doTest):

  • fast/dom/shadow/content-element-move.html:
  • fast/dom/shadow/content-element-select-dynamic.html:
19:23 Changeset [106618] by abarth@webkit.org
  • 13 edits in trunk/Source/WebCore

Rename checkNodeSecurity and allowsAccessFromFrame to have sensible names
https://bugs.webkit.org/show_bug.cgi?id=75796

Reviewed by Eric Seidel.

As requested by Darin Adler, this patch renames these functions be
clear that we're asking whether the access should be allowed rather
than explicitly allowing the access.

  • bindings/generic/BindingSecurity.h:

(BindingSecurity):
(WebCore::::shouldAllowAccessToNode):
(WebCore::::allowSettingFrameSrcToJavascriptUrl):

  • bindings/js/JSDOMBinding.cpp:

(WebCore::shouldAllowAccessToNode):
(WebCore::shouldAllowAccessToFrame):

  • bindings/js/JSDOMBinding.h:

(WebCore):

  • bindings/js/JSHTMLFrameElementCustom.cpp:

(WebCore::allowSettingJavascriptURL):

  • bindings/js/JSHistoryCustom.cpp:

(WebCore::JSHistory::getOwnPropertySlotDelegate):
(WebCore::JSHistory::getOwnPropertyDescriptorDelegate):
(WebCore::JSHistory::putDelegate):
(WebCore::JSHistory::deleteProperty):
(WebCore::JSHistory::getOwnPropertyNames):

  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::getOwnPropertySlotDelegate):
(WebCore::JSLocation::getOwnPropertyDescriptorDelegate):
(WebCore::JSLocation::putDelegate):
(WebCore::JSLocation::deleteProperty):
(WebCore::JSLocation::getOwnPropertyNames):
(WebCore::JSLocation::toStringFunction):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::canAccessFromCurrentOrigin):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertyDescriptorBody):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateFunctionCallback):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::JSTestActiveDOMObject::getOwnPropertyDescriptor):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjContentDocument):
(WebCore::jsTestObjPrototypeFunctionGetSVGDocument):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::contentDocumentAttrGetter):
(WebCore::TestObjInternal::getSVGDocumentCallback):

19:18 Changeset [106617] by jochen@chromium.org
  • 2 edits in trunk/Tools

[chromium] add support for --makeargs to the ninja-based build
https://bugs.webkit.org/show_bug.cgi?id=77688

Reviewed by Adam Barth.

  • Scripts/webkitdirs.pm:

(buildChromiumNinja):

19:03 Changeset [106616] by eric@webkit.org
  • 3 edits in trunk/Tools

Run tests in serial on SnowLeopard to avoid CFURLCache crashes
https://bugs.webkit.org/show_bug.cgi?id=75145

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.default_child_processes):

  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:

(test_operating_system):
(test_default_child_processes):

18:53 Changeset [106615] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Make gtk+ symbols available to WidgetBackingStoreCairo.cpp
https://bugs.webkit.org/show_bug.cgi?id=77679

WidgetBackingStoreCairo.cpp uses GTK+ symbols, so we need it in
webcoregtk_sources instead of webcore_sources.

Patch by Kalev Lember <kalevlember@gmail.com> on 2012-02-02
Reviewed by Martin Robinson.

  • GNUmakefile.list.am: Move WidgetBackingStoreCairo.cpp to webcoregtk.
18:52 Changeset [106614] by morrita@google.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, removing an unnecessarily JS_PRIVATE_EXPORT annotation.

  • interpreter/Interpreter.h:

(Interpreter):

18:47 Changeset [106613] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

StyleRecalc should occur when shadow root exists and light children are changed.
https://bugs.webkit.org/show_bug.cgi?id=76262

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-02
Reviewed by Hajime Morita.

Source/WebCore:

When light children is changed, the element included in HTMLContentElement may also be changed.
So we have to recalculate inclusion of content element again.

Test: fast/dom/shadow/shadow-contents-fallback-dynamic.html

  • dom/Element.cpp:

(WebCore::Element::childrenChanged):

LayoutTests:

Tests for dynamic content fallback.
Also, unnecessary RenderText objects in previous test expectations were removed.

  • fast/dom/shadow/shadow-contents-fallback-dynamic-expected.txt: Added.
  • fast/dom/shadow/shadow-contents-fallback-dynamic.html: Added.
  • platform/chromium-win/fast/html/details-remove-child-2-expected.txt:
  • platform/gtk/fast/html/details-remove-child-2-expected.txt:
  • platform/mac/fast/html/details-remove-child-2-expected.txt:
  • platform/qt/fast/html/details-remove-child-2-expected.txt:
18:40 Changeset [106612] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk/LayoutTests

noteGrainOn needs more tests
https://bugs.webkit.org/show_bug.cgi?id=77225

Patch by Raymond Toy <rtoy@google.com> on 2012-02-02
Reviewed by Kenneth Russell.

  • webaudio/note-grain-on-play.html: Added.
  • webaudio/note-grain-on-play-expected.txt: Added.
  • webaudio/note-grain-on-timing.html: Refactored to use new

functions in note-grain-on-testing.js.

  • webaudio/note-grain-on-timing-expected.txt: Updated.
  • webaudio/resources/audio-testing.js:

(grainLengthInSampleFrames): Utility to compute length of a grain
in samples.

  • webaudio/resources/note-grain-on-testing.js: Added.

(createSignalBuffer):
(findStartAndEndSamples):
(playGrain):
(playAllGrains):
(verifyStarAndtEndTimes): Common functions for note-grain-on-play and
note-grain-on-timing tests to use.

18:28 Changeset [106611] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Typo in sample-accurate-scheduling layout test?
https://bugs.webkit.org/show_bug.cgi?id=75996

Patch by Raymond Toy <rtoy@google.com> on 2012-02-02
Reviewed by Kenneth Russell.

  • webaudio/sample-accurate-scheduling-expected.txt: Updated
  • webaudio/sample-accurate-scheduling.html: Fix typo, add test for

expected number of events.

18:13 Changeset [106610] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Avoid crashing renderer when GPU process dies by not caching textures between video frames.
https://bugs.webkit.org/show_bug.cgi?id=77654

Patch by Ami Fischman <fischman@chromium.org> on 2012-02-02
Reviewed by James Robinson.

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::draw):

18:04 Changeset [106609] by andersca@apple.com
  • 4 edits
    2 adds in trunk/Source/WebCore

Add ScrollingTree class
https://bugs.webkit.org/show_bug.cgi?id=77695

Reviewed by Andreas Kling.

  • WebCore.xcodeproj/project.pbxproj:

Add new files.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::ScrollingCoordinator):
Create a scrolling tree.

(WebCore::ScrollingCoordinator::~ScrollingCoordinator):
Assert that the scrolling tree is null.

(WebCore::ScrollingCoordinator::pageDestroyed):
Null out the scrolling tree member variable and tell it to invalidate itself.

  • page/scrolling/ScrollingTree.cpp: Added.

(WebCore::ScrollingTree::invalidate):
Null out the scrolling coordinator, breaking the reference cycle between the scrolling
coordinator and the scrolling tree.

  • page/scrolling/ScrollingTree.h: Added.
17:49 Changeset [106608] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] Don't use uint
https://bugs.webkit.org/show_bug.cgi?id=77678

Patch by Kalev Lember <kalevlember@gmail.com> on 2012-02-02
Reviewed by Martin Robinson.

With the MingGW cross compiler toolchain in Fedora, uint wasn't
defined, so use unsigned int instead.

  • WebCoreSupport/ChromeClientGtk.h:

(ChromeClient): Use unsigned int instead of uint

17:35 Changeset [106607] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

Refactor plugin drawing to be more data driven
https://bugs.webkit.org/show_bug.cgi?id=76715

Patch by Tim Dresser <tdresser@chromium.org> on 2012-02-02
Reviewed by James Robinson.

CCPluginLayerImpl no longer handles drawing itself, but produces a list of CCPluginDrawQuads.
These quads are then drawn by LayerRendererChromium.

CCLayerImpl::willDraw(LayerRendererChromium*) is called directly before appendQuads.
This allows for CCLayerImpl objects to allocate textures before appendQuads is called.

This is a refactor, so no new tests were added.
Flash was tested manually on Linux and Mac.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::PluginProgramBinding::set):
(PluginProgramBinding):
(WebCore):
(WebCore::TexStretchPluginProgramBinding::set):
(TexStretchPluginProgramBinding):
(WebCore::TexTransformPluginProgramBinding::set):
(TexTransformPluginProgramBinding):
(WebCore::LayerRendererChromium::drawPluginQuad):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::willDraw):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):

  • platform/graphics/chromium/cc/CCPluginDrawQuad.cpp:

(WebCore::CCPluginDrawQuad::create):
(WebCore::CCPluginDrawQuad::CCPluginDrawQuad):

  • platform/graphics/chromium/cc/CCPluginDrawQuad.h:

(CCPluginDrawQuad):
(WebCore::CCPluginDrawQuad::uvRect):
(WebCore::CCPluginDrawQuad::textureId):
(WebCore::CCPluginDrawQuad::flipped):
(WebCore::CCPluginDrawQuad::ioSurfaceWidth):
(WebCore::CCPluginDrawQuad::ioSurfaceHeight):
(WebCore::CCPluginDrawQuad::ioSurfaceTextureId):

  • platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:

(WebCore::CCPluginLayerImpl::willDraw):
(WebCore::CCPluginLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCPluginLayerImpl.h:

(CCPluginLayerImpl):

17:01 Changeset [106606] by morrita@google.com
  • 5 edits
    3 deletes in trunk/Source/JavaScriptCore

[Mac] eliminate JavaScriptCore.exp
https://bugs.webkit.org/show_bug.cgi?id=72854

Reviewed by Darin Adler.

  • Removed exp files and corresponding makefile entries.
  • Changed the build configuration no to use exp file.
16:47 Changeset [106605] by haraken@chromium.org
  • 12 edits in trunk/Source/WebCore

V8 idl code generator doesn't handle SerializedScriptValue attributes properly.
https://bugs.webkit.org/show_bug.cgi?id=77295

Patch by Pablo Flouret <pablof@motorola.com> on 2012-01-29
Reviewed by Kentaro Hara.

Only the case of one (and only one) SerializedScriptValue attribute was
handled, and it was deserialized eagerly in the constructor instead of
generating getters/setters. This patch gets rid of that behavior and
generates the getters and setters instead (similar to what the JSC
generator does).
Also handle the case of SSV attributes with [CachedAttribute]
declaration, caching the deserialized value in a hidden attribute on the
object.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
(GenerateToV8Converters):
(JSValueToNative):
(NativeToJSValue):

  • bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:

(WebDOMTestSerializedScriptValueInterface::setValue):
(WebDOMTestSerializedScriptValueInterface::readonlyValue):
(WebDOMTestSerializedScriptValueInterface::cachedValue):
(WebDOMTestSerializedScriptValueInterface::setCachedValue):
(WebDOMTestSerializedScriptValueInterface::cachedReadonlyValue):

  • bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h:

(WebDOMTestSerializedScriptValueInterface):

  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:

(webkit_dom_test_serialized_script_value_interface_set_value):
(webkit_dom_test_serialized_script_value_interface_get_readonly_value):
(webkit_dom_test_serialized_script_value_interface_get_cached_value):
(webkit_dom_test_serialized_script_value_interface_set_cached_value):
(webkit_dom_test_serialized_script_value_interface_get_cached_readonly_value):
(webkit_dom_test_serialized_script_value_interface_get_property):
(webkit_dom_test_serialized_script_value_interface_class_init):

  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

():
(WebCore::jsTestSerializedScriptValueInterfaceReadonlyValue):
(WebCore):
(WebCore::jsTestSerializedScriptValueInterfaceCachedValue):
(WebCore::jsTestSerializedScriptValueInterfaceCachedReadonlyValue):
(WebCore::JSTestSerializedScriptValueInterface::put):
(WebCore::setJSTestSerializedScriptValueInterfaceValue):
(WebCore::setJSTestSerializedScriptValueInterfaceCachedValue):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(JSTestSerializedScriptValueInterface):
(JSTestSerializedScriptValueInterfacePrototype):
(WebCore):

  • bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h:
  • bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm:

(-[DOMTestSerializedScriptValueInterface setValue:]):
(-[DOMTestSerializedScriptValueInterface readonlyValue]):
(-[DOMTestSerializedScriptValueInterface cachedValue]):
(-[DOMTestSerializedScriptValueInterface setCachedValue:]):
(-[DOMTestSerializedScriptValueInterface cachedReadonlyValue]):

  • bindings/scripts/test/TestSerializedScriptValueInterface.idl:
  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceInternal::valueAttrGetter):
(TestSerializedScriptValueInterfaceInternal):
(WebCore::TestSerializedScriptValueInterfaceInternal::valueAttrSetter):
(WebCore::TestSerializedScriptValueInterfaceInternal::readonlyValueAttrGetter):
(WebCore::TestSerializedScriptValueInterfaceInternal::cachedValueAttrGetter):
(WebCore::TestSerializedScriptValueInterfaceInternal::cachedValueAttrSetter):
(WebCore::TestSerializedScriptValueInterfaceInternal::cachedReadonlyValueAttrGetter):
():
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):

16:47 Changeset [106604] by abarth@webkit.org
  • 2 edits in branches/chromium/1025/Source/WebCore/dom

Merge 106603 - BMW Car Configuration Page doesn't work (Only manifests in Chromium)
https://bugs.webkit.org/show_bug.cgi?id=77312

Reviewed by Dimitri Glazkov.

When we autogenerated the event factory, we missed the check for
whether touch events were enabled at runtime:
http://trac.webkit.org/changeset/97933/trunk/Source/WebCore/dom/Document.cpp

This patch adds the check back.

Unfortunately, there isn't a testing frame work for
RuntimeEnabledFeatures. The main difficulty is that these static bools
need to be set when WebKit is initialized and can't be changed (which
is why they're not part of WebCore::Settings). To test them properly,
we'd need a testing framework that booted up WebKit for each test.

We could test this particular change (which doesn't need the bool to be
constant through the runtime of WebKit), but that would create a
sandtrap for future patches who might thing that this testing framework
can really be used to test RuntimeEnabledFeatures.

The net result is that Chromium is going to end up living with the
non-default codepath for these settings being untested, which will lead
to regressions like this one. If we ened up with a bunch of these
regressions, we'll likely end up with a testing framework similar to
Chromium's browsers_tests, which create a fresh subprocess for each
test.

  • dom/EventFactory.in:
  • dom/make_event_factory.pl:

(defaultItemFactory):
(generateImplementation):

TBR=abarth@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9325015

16:26 Changeset [106603] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

BMW Car Configuration Page doesn't work (Only manifests in Chromium)
https://bugs.webkit.org/show_bug.cgi?id=77312

Reviewed by Dimitri Glazkov.

When we autogenerated the event factory, we missed the check for
whether touch events were enabled at runtime:
http://trac.webkit.org/changeset/97933/trunk/Source/WebCore/dom/Document.cpp

This patch adds the check back.

Unfortunately, there isn't a testing frame work for
RuntimeEnabledFeatures. The main difficulty is that these static bools
need to be set when WebKit is initialized and can't be changed (which
is why they're not part of WebCore::Settings). To test them properly,
we'd need a testing framework that booted up WebKit for each test.

We could test this particular change (which doesn't need the bool to be
constant through the runtime of WebKit), but that would create a
sandtrap for future patches who might thing that this testing framework
can really be used to test RuntimeEnabledFeatures.

The net result is that Chromium is going to end up living with the
non-default codepath for these settings being untested, which will lead
to regressions like this one. If we ened up with a bunch of these
regressions, we'll likely end up with a testing framework similar to
Chromium's browsers_tests, which create a fresh subprocess for each
test.

  • dom/EventFactory.in:
  • dom/make_event_factory.pl:

(defaultItemFactory):
(generateImplementation):

16:24 Changeset [106602] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Fix up test expectations for two tests that now pass.
https://bugs.webkit.org/show_bug.cgi?id=77256

Patch by Raymond Toy <rtoy@google.com> on 2012-02-02
Reviewed by Eric Seidel.

  • platform/chromium/test_expectations.txt:

webaudio/audiobuffersource-playbackrate.html and
webaudio/gain.html pass on windows now after the fix for bug

  1. Delete these.
16:06 Changeset [106601] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

[Chromium] Use SkCanvas::flush in skia port
https://bugs.webkit.org/show_bug.cgi?id=77463

Patch by Justin Novosad <junov@chromium.org> on 2012-02-02
Reviewed by Stephen White.

Code cleanup in skia port. Using SkCanvas::flush to remove
unnecessary dependency on GrContext. Removed unnecessary inclusions
and forward declarations of GrContext in several source files.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/LayerRendererChromium.cpp:
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
  • platform/graphics/chromium/cc/CCProxy.h:
  • platform/graphics/skia/PlatformContextSkia.cpp:
15:42 Changeset [106600] by benjamin@webkit.org
  • 3 edits
    2 adds in trunk

Running a Web Worker on about:blank crashes the interpreter
https://bugs.webkit.org/show_bug.cgi?id=77593

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-02-02
Reviewed by Michael Saboff.

Source/JavaScriptCore:

The method Interpreter::execute() was crashing on empty programs because
the assumption is made the source is not null.

This patch shortcut the execution when the String is null to avoid invalid
memory access.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

LayoutTests:

The Worker thread should not crash if running on an empty page.
The timer is necessary to give a chance for the thread to start.

  • fast/workers/empty-worker-nocrash-expected.txt: Added.
  • fast/workers/empty-worker-nocrash.html: Added.
15:41 Changeset [106599] by lforschler@apple.com
  • 4 edits in trunk/Source

Versioning.

15:36 Changeset [106598] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[GTK] Use win32 native threading
https://bugs.webkit.org/show_bug.cgi?id=77676

Patch by Kalev Lember <kalevlember@gmail.com> on 2012-02-02
Reviewed by Martin Robinson.

r97269 switched from glib threading to pthreads, breaking win32 GTK+.
This is a follow up, removing some leftovers in ThreadSpecific.h and
switching win32 to use the native threading in ThreadingWin.cpp.

  • GNUmakefile.list.am: Compile in win32 native threading support
  • wtf/ThreadSpecific.h: Remove GTK+-specific definitions

(ThreadSpecific):
(WTF::::destroy):

15:34 Changeset [106597] by lforschler@apple.com
  • 1 copy in tags/Safari-535.19

New Tag.

15:18 Changeset [106596] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

retrieveCallerFromVMCode should call trueCallerFrame
https://bugs.webkit.org/show_bug.cgi?id=77684

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::retrieveCallerFromVMCode):

LayoutTests:

Rubber stamped by Oliver Hunt.

  • fast/js/dfg-inline-function-dot-caller-expected.txt: Added.
  • fast/js/dfg-inline-function-dot-caller.html: Added.
  • fast/js/script-tests/dfg-inline-function-dot-caller.js: Added.

(resultArray):
(object.nonInlineable.nonInlineable.if):
(object.nonInlineable):
(object.inlineable):
(makeInlinableCall):
(g):

15:03 Changeset [106595] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[GTK] Implement current executable path finding for win32
https://bugs.webkit.org/show_bug.cgi?id=77677

Patch by Kalev Lember <kalevlember@gmail.com> on 2012-02-02
Reviewed by Martin Robinson.

The WTF helper for getting the binary path that was added in r101710
left out the win32 implementation. Fix this.

  • wtf/gobject/GlibUtilities.cpp:

(getCurrentExecutablePath):

14:55 Changeset [106594] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Throwing away bytecode and then reparsing during DFG optimization is just
plain wrong and makes things crash
https://bugs.webkit.org/show_bug.cgi?id=77680
<rdar://problem/10798490>

Reviewed by Oliver Hunt.

This is the minimal surgical fix: it removes the code that triggered bytecode
throw-away. Once we're confident that this is a good idea, we can kill all of
the code that implements the feature.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::discardBytecodeLater):
(JSC::CodeBlock::addValueProfile):

  • jit/JITDriver.h:

(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):

14:50 Changeset [106593] by aestes@apple.com
  • 8 edits in trunk

Turn on CSS Filters on Windows
https://bugs.webkit.org/show_bug.cgi?id=76667

Source/WebCore:

Turning on CSS_FILTERS flag for Windows and fixed a couple of resultant build errors

Patch by Chris Marrin <cmarrin@apple.com> on 2012-02-02
Reviewed by Adele Peterson.

  • WebCore.vcproj/copyForwardingHeaders.cmd:
  • platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayer::setFilters):
(PlatformCALayer::filtersCanBeComposited):

WebKitLibraries:

Turned on CSS_FILTERS for Windows

Patch by Chris Marrin <cmarrin@apple.com> on 2012-02-02
Reviewed by Adele Peterson.

  • win/tools/vsprops/FeatureDefines.vsprops:

LayoutTests:

Skipped filter test files not supported on Windows

Patch by Chris Marrin <cmarrin@apple.com> on 2012-02-02
Reviewed by Adele Peterson.

  • platform/win/Skipped:
14:16 Changeset [106592] by jonlee@apple.com
  • 18 edits in trunk/Source

Clear shown notifications when context is no longer active
https://bugs.webkit.org/show_bug.cgi?id=77363
<rdar://problem/10568907>

Reviewed by Darin Adler.

Source/WebCore:

  • notifications/NotificationPresenter.h: Add new virtual function to clear notifications

associated with a given execution context. By default the notifications are left alone, as
before. Individual implementations can override to allow notifications to clear them.

  • notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::disconnectFrame): When disconnecting the page from the frame, we
call clearNotifications().

  • page/Frame.cpp:

(WebCore::Frame::pageDestroyed): When the page is destroyed, tell the DOM window to reset notifications.

Source/WebKit/win:

  • WebCoreSupport/WebDesktopNotificationsDelegate.h:

(WebDesktopNotificationsDelegate): Add previously missing virtual functions.

  • WebCoreSupport/WebDesktopNotificationsDelegate.cpp:

(WebDesktopNotificationsDelegate::notificationControllerDestroyed):
(WebDesktopNotificationsDelegate::cancelRequestsForPermission):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebNotificationClient.cpp:

(WebKit::WebNotificationClient::clearNotifications): Forward the call to
WebNotificationManager.

  • WebProcess/WebCoreSupport/WebNotificationClient.h:

(WebNotificationClient):

  • WebProcess/Notifications/WebNotificationManager.h: Add an additional map that maps

all notifications associated with a given ScriptExecutionContext instance.

  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::show): Create a map entry for the notification's
context if it doesn't exist already, and note that notification's ID. Also, correct
the return value of show() if notifications are not enabled, to return false.
(WebKit::WebNotificationManager::didCloseNotifications): When the notification is closed,
we remove that notification from the map.
(WebKit::WebNotificationManager::clearNotifications): Use the map entry for the given
context, and pass that along to the proxy so that all of the notifications with those IDs
can be cleared. In the meantime, we remove that context's map entry.

  • UIProcess/Notifications/WebNotificationManagerProxy.messages.in: New ClearNotifications()

message.

  • UIProcess/Notifications/WebNotificationManagerProxy.h:
  • UIProcess/Notifications/WebNotificationManagerProxy.cpp:

(WebKit::WebNotificationManagerProxy::clearNotifications): Forward the call to the provider.
Then remove this proxy's entries for the given notification IDs.

  • UIProcess/Notifications/WebNotificationProvider.cpp:

(WebKit::WebNotificationProvider::clearNotifications): Convert the vector of IDs to a mutable
array.

  • UIProcess/Notifications/WebNotificationProvider.h:

(WebNotificationProvider):

  • UIProcess/API/C/WKNotificationProvider.h: Add WK API to tell the platform to clear the notifications.

Remove the #if guard since they already exist in WebNotificationManager functions:

  • WebProcess/WebCoreSupport/WebNotificationClient.cpp:

(WebKit::WebNotificationClient::show):
(WebKit::WebNotificationClient::cancel):
(WebKit::WebNotificationClient::notificationObjectDestroyed):

13:55 Changeset [106591] by dpranke@chromium.org
  • 5 edits in trunk/Tools

nrwt shouldn't blow up when there are errors in test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=73603

Reviewed by Ojan Vafai.

This change removes the distinction between 'errors' and 'warnings'
in the test expectations parser. Now, any problem is a
'warning', and if we are linting the file, warnings become fatal (errors).

This will allow a normal run-webkit-tests run to proceed even if
there are bad lines.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(ParseError.init):
(ParseError.str):
(ParseError.repr):
(TestExpectationSerializer.to_string):
(TestExpectationParser._parse_modifiers):
(TestExpectationParser._parse_expectations):
(TestExpectationParser._check_modifiers_against_expectations):
(TestExpectationParser._tokenize):
(TestExpectationLine.init):
(TestExpectationLine.is_invalid):
(TestExpectationsModel.add_expectation_line):
(TestExpectationsModel._already_seen_better_match):
(TestExpectations.init):
(TestExpectations._report_warnings):
(TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(assert_bad_expectations):
(test_parse_warning):
(test_overridesduplicate):
(ExpectationSyntaxTests.test_missing_expectation):
(ExpectationSyntaxTests.test_missing_colon):
(ExpectationSyntaxTests.test_too_many_colons):
(ExpectationSyntaxTests.test_too_many_equals_signs):
(ExpectationSyntaxTests.test_unrecognized_expectation):
(SemanticTests.test_bug_format):
(SemanticTests.test_bad_bugid):
(SemanticTests.test_slow_and_timeout):
(test_ambiguous):
(test_more_modifiers):
(test_order_in_file):
(test_macro_overrides):
(RebaseliningTest.assertRemove):
(TestExpectationParserTests.test_tokenize_blank):
(TestExpectationParserTests.test_tokenize_missing_colon):
(TestExpectationParserTests.test_tokenize_extra_colon):
(TestExpectationParserTests.test_tokenize_empty_comment):
(TestExpectationParserTests.test_tokenize_comment):
(TestExpectationParserTests.test_tokenize_missing_equal):
(TestExpectationParserTests.test_tokenize_extra_equal):
(TestExpectationParserTests.test_tokenize_valid):
(TestExpectationParserTests.test_tokenize_valid_with_comment):
(TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
(TestExpectationSerializerTests.test_unparsed_to_string):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(lint):

  • Scripts/webkitpy/style/checkers/test_expectations.py:

(TestExpectationsChecker.check_test_expectations):

13:49 Changeset [106590] by fpizlo@apple.com
  • 30 edits in trunk/Source/JavaScriptCore

Release build debugging should be easier
https://bugs.webkit.org/show_bug.cgi?id=77669

Reviewed by Gavin Barraclough.

  • assembler/ARMAssembler.h:

(ARMAssembler):
(JSC::ARMAssembler::debugOffset):

  • assembler/ARMv7Assembler.h:

(ARMv7Assembler):
(JSC::ARMv7Assembler::debugOffset):
(ARMInstructionFormatter):
(JSC::ARMv7Assembler::ARMInstructionFormatter::debugOffset):

  • assembler/AbstractMacroAssembler.h:

(AbstractMacroAssembler):
(JSC::AbstractMacroAssembler::debugOffset):

  • assembler/AssemblerBuffer.h:

(AssemblerBuffer):
(JSC::AssemblerBuffer::debugOffset):

  • assembler/LinkBuffer.h:

(LinkBuffer):
(JSC::LinkBuffer::debugSize):

  • assembler/MIPSAssembler.h:

(MIPSAssembler):
(JSC::MIPSAssembler::debugOffset):

  • assembler/X86Assembler.h:

(X86Assembler):
(JSC::X86Assembler::debugOffset):
(X86InstructionFormatter):
(JSC::X86Assembler::X86InstructionFormatter::debugOffset):

  • bytecode/CodeBlock.cpp:

(JSC):

  • bytecode/CodeBlock.h:

(CodeBlock):

  • bytecode/CodeOrigin.h:

(CodeOrigin):
(JSC):
(JSC::CodeOrigin::inlineStack):

  • bytecode/DFGExitProfile.h:

(JSC::DFG::exitKindToString):

  • bytecode/DataFormat.h:

(JSC::dataFormatToString):

  • bytecode/PredictedType.cpp:

(JSC):
(JSC::predictionToString):

  • bytecode/PredictedType.h:

(JSC):

  • bytecode/ValueRecovery.h:

(ValueRecovery):
(JSC::ValueRecovery::dump):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC):
(JSC::BytecodeGenerator::setDumpsGeneratedCode):
(JSC::BytecodeGenerator::dumpsGeneratedCode):
(JSC::BytecodeGenerator::generate):

  • dfg/DFGAbstractValue.h:

(StructureAbstractValue):
(JSC::DFG::StructureAbstractValue::dump):
(AbstractValue):
(JSC::DFG::AbstractValue::dump):

  • dfg/DFGAssemblyHelpers.h:

(DFG):
(AssemblyHelpers):
(JSC::DFG::AssemblyHelpers::debugCall):

  • dfg/DFGFPRInfo.h:

(FPRInfo):
(JSC::DFG::FPRInfo::debugName):

  • dfg/DFGGPRInfo.h:

(GPRInfo):
(JSC::DFG::GPRInfo::debugName):

  • dfg/DFGGraph.cpp:

(DFG):

  • dfg/DFGGraph.h:

(Graph):

  • dfg/DFGNode.h:

(DFG):
(JSC::DFG::arithNodeFlagsAsString):
(Node):
(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::dumpChildren):

  • dfg/DFGOSRExit.cpp:

(DFG):
(JSC::DFG::OSRExit::dump):

  • dfg/DFGOSRExit.h:

(OSRExit):

  • runtime/JSValue.cpp:

(JSC):
(JSC::JSValue::description):

  • runtime/JSValue.h:

(JSValue):

  • wtf/BitVector.cpp:

(WTF):
(WTF::BitVector::dump):

  • wtf/BitVector.h:

(BitVector):

13:19 Changeset [106589] by oliver@apple.com
  • 5 edits in trunk

Getters and setters cause line numbers in errors/console.log to be offset for the whole file
https://bugs.webkit.org/show_bug.cgi?id=77675

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

Our default literal parsing logic doesn't handle the extra work required for
getters and setters. When it encounters one, it rolls back the lexer and
then switches to a more complete parsing function. Unfortunately it was only
winding back the character position, and was ignoring the line number and
other lexer data. This led to every getter and setter causing the line number
to be incorrectly incremented leading to increasingly incorrect numbers for
the rest of the file.

  • parser/Parser.cpp:

(JSC::::parseObjectLiteral):

LayoutTests:

Add getter and setter line number tests.

  • fast/js/exception-linenums-expected.txt:
  • fast/js/script-tests/exception-linenums.js:

(firstPropIsGetter.get getter):
(secondPropIsGetter.prop.1.get getter):
(firstPropIsSetter.set setter):
(secondPropIsSetter.prop.1.set setter):

13:18 Changeset [106588] by andersca@apple.com
  • 6 edits in trunk/Source/WebCore

The overhang area layer should have a linen background
https://bugs.webkit.org/show_bug.cgi?id=77670
<rdar://problem/10797727>

Reviewed by Andreas Kling.

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinator::scrollByOnScrollingThread):
Add an #ifdef so that scroll position clamping can be disabled. This will be
removed once rubber-banding works properly.

  • platform/ScrollbarTheme.h:

(WebCore::ScrollbarTheme::setUpOverhangAreasLayerContents):
Add new empty function.

  • platform/mac/ScrollbarThemeMac.h:

(ScrollbarThemeMac):

  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::linenBackgroundColor):
Helper function for getting the CGColorRef that represents the linen background color.

(WebCore::ScrollbarThemeMac::setUpOverhangAreasLayerContents):
Set the linen background color as the overhang areas layer background color.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
Call ScrollbarTheme::setUpOverhangAreasLayerContents.

13:15 Changeset [106587] by japhet@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

2012-02-02 Nate Chapin <japhet@chromium.org>

Unreviewed, chromium expectations update.
Remove custom chromium-mac expectation for fast/canvas/fillPath-shadow.html,
since it's failing the same way as chromium win/linux.

  • platform/chromium-mac/fast/canvas/canvas-fillPath-shadow-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
13:12 BuildingQt5OnHarmattan edited by lauro.neto@openbossa.org
(diff)
13:10 Changeset [106586] by commit-queue@webkit.org
  • 7 edits in trunk

Unreviewed, rolling out r106566.
http://trac.webkit.org/changeset/106566
https://bugs.webkit.org/show_bug.cgi?id=77673

Broke the Windows build (Requested by jessieberlin on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-02

Source/WebCore:

  • WebCore.vcproj/copyForwardingHeaders.cmd:
  • platform/graphics/ca/win/PlatformCALayerWin.cpp:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:

LayoutTests:

  • platform/win/Skipped:
13:04 Changeset [106585] by scherkus@chromium.org
  • 2 edits in trunk/LayoutTests

2012-02-02 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, updating Chromium test expectations.
https://bugs.webkit.org/show_bug.cgi?id=73681

  • platform/chromium/test_expectations.txt:
13:03 Changeset [106584] by rniwa@webkit.org
  • 4 edits
    1 delete in trunk

Unreviewed, rolling out r106543.
http://trac.webkit.org/changeset/106543
https://bugs.webkit.org/show_bug.cgi?id=77671

Made tests less stable (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-02

PerformanceTests:

  • resources/init.html: Removed.

Tools:

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner):
(PerfTestsRunner.init):
(PerfTestsRunner._run_tests_set):
(PerfTestsRunner._run_single_test):

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(MainTest.TestDriver.run_test):
(run_test):

13:00 Changeset [106583] by japhet@chromium.org
  • 2 edits in trunk/LayoutTests

2012-02-02 Nate Chapin <japhet@chromium.org>

Unreviewed, chromium expectations update.
Mark some touch event tests as crashing, since they're
asserting as of r106554.

  • platform/chromium/test_expectations.txt:
12:56 Changeset [106582] by lforschler@apple.com
  • 2 edits in branches/safari-534.54-branch/Source/WebKit2

Merged r106508.

12:53 Changeset [106581] by tommyw@google.com
  • 12 edits
    8 copies
    1 add in trunk/Source

[chromium] MediaStream API: Adding the embedding code for MediaStreamCenter
https://bugs.webkit.org/show_bug.cgi?id=73130

Reviewed by Darin Fisher.

Source/WebCore:

Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.

  • mediastream/UserMediaClient.h:

(UserMediaClient):

  • mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::didCompleteQuery):

  • mediastream/UserMediaRequest.h:

(UserMediaRequest):
(WebCore::UserMediaRequest::audio):
(WebCore::UserMediaRequest::video):
(WebCore::UserMediaRequest::cameraPreferenceUser):
(WebCore::UserMediaRequest::cameraPreferenceEnvironment):

  • platform/mediastream/MediaStreamCenter.cpp:

(WebCore):
(WebCore::MediaStreamCenter::queryMediaStreamSources):

  • platform/mediastream/MediaStreamCenter.h:

(WebCore):
(MediaStreamSourcesQueryClient):
(MediaStreamCenter):

Source/WebKit/chromium:

  • WebKit.gyp:
  • bridge/MediaStreamCenter.cpp: Copied from Source/WebKit/chromium/src/UserMediaClientImpl.h.

(WebCore):
(WebCore::MediaStreamCenter::MediaStreamCenter):
(WebCore::MediaStreamCenter::~MediaStreamCenter):
(WebCore::MediaStreamCenter::queryMediaStreamSources):
(WebCore::MediaStreamCenter::didSetMediaStreamTrackEnabled):
(WebCore::MediaStreamCenter::didStopLocalMediaStream):
(WebCore::MediaStreamCenter::didConstructMediaStream):

  • bridge/MediaStreamCenterInternal.cpp: Added.

(WebCore):
(WebCore::MediaStreamCenterInternal::MediaStreamCenterInternal):
(WebCore::MediaStreamCenterInternal::~MediaStreamCenterInternal):
(WebCore::MediaStreamCenterInternal::queryMediaStreamSources):
(WebCore::MediaStreamCenterInternal::didSetMediaStreamTrackEnabled):
(WebCore::MediaStreamCenterInternal::didStopLocalMediaStream):
(WebCore::MediaStreamCenterInternal::didConstructMediaStream):
(WebCore::MediaStreamCenterInternal::stopLocalMediaStream):

  • bridge/MediaStreamCenterInternal.h: Copied from Source/WebKit/chromium/src/UserMediaClientImpl.h.

(WebKit):
(WebCore):
(MediaStreamCenterInternal):

  • public/platform/WebKitPlatformSupport.h:

(WebKit):
(WebKit::WebKitPlatformSupport::createMediaStreamCenter):

  • public/platform/WebMediaStreamCenter.h: Copied from Source/WebKit/chromium/src/UserMediaClientImpl.h.

(WebKit):
(WebMediaStreamCenter):
(WebKit::WebMediaStreamCenter::~WebMediaStreamCenter):

  • public/platform/WebMediaStreamCenterClient.h: Copied from Source/WebKit/chromium/src/UserMediaClientImpl.h.

(WebKit):
(WebMediaStreamCenterClient):
(WebKit::WebMediaStreamCenterClient::~WebMediaStreamCenterClient):

  • public/platform/WebMediaStreamComponent.h: Copied from Source/WebKit/chromium/src/UserMediaClientImpl.h.

(WebCore):
(WebKit):
(WebMediaStreamComponent):
(WebKit::WebMediaStreamComponent::WebMediaStreamComponent):
(WebKit::WebMediaStreamComponent::~WebMediaStreamComponent):
(WebKit::WebMediaStreamComponent::isNull):

  • public/platform/WebMediaStreamDescriptor.h:

(WebKit):
(WebMediaStreamDescriptor):

  • public/platform/WebMediaStreamSourcesRequest.h: Copied from Source/WebKit/chromium/src/UserMediaClientImpl.h.

(WebCore):
(WebKit):
(WebMediaStreamSourcesRequest):
(WebKit::WebMediaStreamSourcesRequest::WebMediaStreamSourcesRequest):
(WebKit::WebMediaStreamSourcesRequest::~WebMediaStreamSourcesRequest):
(WebKit::WebMediaStreamSourcesRequest::isNull):

  • src/UserMediaClientImpl.h:

(UserMediaClientImpl):

  • src/WebMediaStreamComponent.cpp: Copied from Source/WebKit/chromium/src/UserMediaClientImpl.h.

(WebKit):
(WebKit::WebMediaStreamComponent::WebMediaStreamComponent):
(WebKit::WebMediaStreamComponent::operator=):
(WebKit::WebMediaStreamComponent::reset):
(WebKit::WebMediaStreamComponent::operator PassRefPtr<MediaStreamComponent>):
(WebKit::WebMediaStreamComponent::operator MediaStreamComponent*):
(WebKit::WebMediaStreamComponent::isEnabled):
(WebKit::WebMediaStreamComponent::source):

  • src/WebMediaStreamDescriptor.cpp:

(WebKit::WebMediaStreamDescriptor::WebMediaStreamDescriptor):
(WebKit):
(WebKit::WebMediaStreamDescriptor::audioSources):
(WebKit::WebMediaStreamDescriptor::videoSources):

  • src/WebMediaStreamSourcesRequest.cpp: Copied from Source/WebKit/chromium/src/UserMediaClientImpl.h.

(WebKit):
(WebKit::WebMediaStreamSourcesRequest::WebMediaStreamSourcesRequest):
(WebKit::WebMediaStreamSourcesRequest::reset):
(WebKit::WebMediaStreamSourcesRequest::audio):
(WebKit::WebMediaStreamSourcesRequest::video):
(WebKit::WebMediaStreamSourcesRequest::didCompleteQuery):

12:46 Changeset [106580] by commit-queue@webkit.org
  • 4 edits
    7 adds in trunk

Constant values to set "distanceModel" are undefined
https://bugs.webkit.org/show_bug.cgi?id=74273

Patch by Raymond Toy <rtoy@google.com> on 2012-02-02
Reviewed by Kenneth Russell.

Source/WebCore:

Tests: webaudio/distance-exponential.html

webaudio/distance-inverse.html
webaudio/distance-linear.html

  • webaudio/AudioPannerNode.h: Define enum for the new constants

for the distance models.

  • webaudio/AudioPannerNode.idl: Define matching constants for the

distance models.

LayoutTests:

  • webaudio/distance-exponential-expected.txt: Added.
  • webaudio/distance-exponential.html: Added.
  • webaudio/distance-inverse-expected.txt: Added.
  • webaudio/distance-inverse.html: Added.
  • webaudio/distance-linear-expected.txt: Added.
  • webaudio/distance-linear.html: Added.
  • webaudio/resources/distance-model-testing.js: Added.

(createImpulseBuffer):
(linearDistance):
(exponentialDistance):
(inverseDistance):
(createGraph):
(startSources):
(equalPowerGain):
(checkDistanceResult.return.renderedBuffer):
(checkDistanceResult):

12:29 Changeset [106579] by commit-queue@webkit.org
  • 8 edits in trunk

Illegal panner model values should throw an exception
https://bugs.webkit.org/show_bug.cgi?id=77235

Patch by Raymond Toy <rtoy@google.com> on 2012-02-02
Reviewed by Kenneth Russell.

Source/WebCore:

Modified existing panner-set-model test to catch exceptions.
Debug build should not crash anymore.

  • webaudio/AudioPannerNode.cpp:

(WebCore::AudioPannerNode::setPanningModel): Throw exception for
invalid model values.

  • webaudio/AudioPannerNode.h:

(AudioPannerNode): Update declaration

  • webaudio/AudioPannerNode.idl: Setting panner model can throw

exception.

LayoutTests:

  • webaudio/panner-set-model-expected.txt: Updated.
  • webaudio/panner-set-model.html: Catch the errors that are thrown

for invalid panning model values.

  • platform/chromium/test_expectations.txt: Remove test that no

longer crashes.

12:02 Changeset [106578] by japhet@chromium.org
  • 2 edits in trunk/LayoutTests

2012-02-02 Nate Chapin <japhet@chromium.org>

Unreviewed, chromium expectations update.

  • platform/chromium/test_expectations.txt:
12:02 Changeset [106577] by bdakin@apple.com
  • 2 edits
    4 adds in trunk/Tools

https://bugs.webkit.org/show_bug.cgi?id=77664
Add API tests for didNewFirstVisuallyNonEmptyLayout

Reviewed by Darin Adler.

Two new tests.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp: Added.

(TestWebKitAPI):
(TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp: Added.

(TestWebKitAPI):
(TestWebKitAPI::didForceRepaint):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp: Added.

(TestWebKitAPI):
(NewFirstVisuallyNonEmptyLayoutFailsTest):
(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::NewFirstVisuallyNonEmptyLayoutFailsTest):
(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):

  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp: Added.

(TestWebKitAPI):
(NewFirstVisuallyNonEmptyLayoutTest):
(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::NewFirstVisuallyNonEmptyLayoutTest):
(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage):

11:49 Changeset [106576] by rniwa@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Chromium rebaseline after r106543.

  • platform/chromium/fast/events/remove-target-with-shadow-in-drag-expected.txt: Added.
11:24 Changeset [106575] by haraken@chromium.org
  • 23 edits in trunk/Source/WebCore

Rename [ConvertUndefinedOrNullToNullString] to
[TreatNullAs=EmptyString, TreatUndefinedAs=EmptyString]
https://bugs.webkit.org/show_bug.cgi?id=77611

Reviewed by Adam Barth.

This patch renames [ConvertUndefinedOrNullToNullString] to
[TreatNullAs=EmptyString, TreatUndefinedAs=EmptyString], according to the spec
(http://dev.w3.org/2006/webapi/WebIDL/#TreatNullAs,
http://dev.w3.org/2006/webapi/WebIDL/#TreatUndefinedAs).

No tests. No changes in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(JSValueToNative):

  • bindings/scripts/CodeGeneratorV8.pm:

(GetNativeTypeFromSignature):

  • dom/DOMImplementation.idl:
  • dom/Document.idl:
  • fileapi/Blob.idl:
  • fileapi/DirectoryEntry.idl:
  • fileapi/DirectoryEntrySync.idl:
  • fileapi/Entry.idl:
  • fileapi/EntrySync.idl:
  • fileapi/WebKitBlobBuilder.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLCanvasElement.idl:
  • html/HTMLFieldSetElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLKeygenElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLOutputElement.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLTextAreaElement.idl:
  • page/Console.idl:
  • page/DOMWindow.idl:
  • bindings/scripts/test/TestObj.idl: No changes in run-bindings-tests results.
11:12 Changeset [106574] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix type punning warning in HashTable.h debug builds
https://bugs.webkit.org/show_bug.cgi?id=77422

Patch by Andy Wingo <wingo@igalia.com> on 2012-02-02
Reviewed by Gavin Barraclough.

  • wtf/HashTable.h (WTF::HashTable::checkKey): Fix type punning

warning appearing in debug builds with gcc-4.6.2 on GNU/Linux.

11:06 Changeset [106573] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-02

  • DEPS:
11:03 Changeset [106572] by andersca@apple.com
  • 4 edits in trunk/Source

NPAPI will not send mouse up events when mouse is outside plugin area
https://bugs.webkit.org/show_bug.cgi?id=77657
<rdar://problem/10160674>

Reviewed by Andreas Kling.

Source/WebCore:

Export EventHandler::setCapturingMouseEventsNode.

  • WebCore.exp.in:

Source/WebKit2:

Use EventHandler::setCapturingMouseEventsNode to ensure we get all the mouse events when the mouse is down.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::handleEvent):

10:59 Changeset [106571] by ossy@webkit.org
  • 3 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening.
https://bugs.webkit.org/show_bug.cgi?id=67485

  • platform/qt-wk2/Skipped:
    • fast/dom/Window/window-properties.html: unskip, it needed only update
    • fast/text/complex-preferred-logical-widths.html: unskip, it passes now
    • http/tests/loading/empty-urls.html: unskip, it doesn't exist now
    • http/tests/loading/progress-finished-callback.html: move to the correct place
  • platform/qt-wk2/fast/dom/Window/window-properties-expected.txt: Updated.
10:37 Changeset [106570] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Unskip a now passing test.
10:08 Changeset [106569] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Paint the Qt Mac bot green.

  • platform/qt-mac/Skipped:
10:08 Changeset [106568] by antti@apple.com
  • 15 edits in trunk/Source/WebCore

Move remaining implementation from CSSStyleDeclaration to subclasses
https://bugs.webkit.org/show_bug.cgi?id=77621

Reviewed by Andreas Kling.

This leaves CSSStyleDeclaration a near-pure CSSOM interface.

  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::isCSSPropertyName):
(WebCore::JSCSSStyleDeclaration::putDelegate):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::parentRule):
(WebCore):

  • css/CSSComputedStyleDeclaration.h:

(CSSComputedStyleDeclaration):

  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
(WebCore::CSSMutableStyleDeclaration::contextStyleSheet):
(WebCore):
(WebCore::CSSMutableStyleDeclaration::parentRule):

  • css/CSSMutableStyleDeclaration.h:

(WebCore::CSSMutableStyleDeclaration::isInlineStyleDeclaration):
(WebCore::CSSMutableStyleDeclaration::parentRuleInternal):
(WebCore::CSSMutableStyleDeclaration::clearParentRule):
(CSSMutableStyleDeclaration):
(WebCore::CSSMutableStyleDeclaration::parentElement):
(WebCore::CSSMutableStyleDeclaration::clearParentElement):
(WebCore::CSSMutableStyleDeclaration::parentStyleSheet):

  • css/CSSParser.cpp:

(WebCore::parseColorValue):
(WebCore::parseSimpleLengthValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseDeclaration):

  • css/CSSStyleDeclaration.cpp:

(WebCore):

  • css/CSSStyleDeclaration.h:

(CSSStyleDeclaration):
(WebCore::CSSStyleDeclaration::parentStyleSheet):
(WebCore::CSSStyleDeclaration::CSSStyleDeclaration):

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::setSelectorText):

Eliminate unnecessary call to CSSMutableStyleDeclaration::parentStyleSheet()

  • css/CSSStyleRule.h:

(WebCore::CSSStyleRule::setDeclaration):

  • css/CSSStyleSelector.cpp:

(WebCore::isInsideRegionRule):
(WebCore::CSSStyleSelector::applyDeclaration):

  • css/WebKitCSSKeyframeRule.cpp:

(WebCore::WebKitCSSKeyframeRule::setDeclaration):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeFrame):
(WebCore::PageSerializer::serializeCSSStyleSheet):
(WebCore::PageSerializer::retrieveResourcesForCSSRule):
(WebCore::PageSerializer::retrieveResourcesForCSSDeclaration):

  • page/PageSerializer.h:


Eliminate unnecessary call to CSSMutableStyleDeclaration::parentStyleSheet()


(WebCore):
(PageSerializer):

10:03 Changeset [106567] by ossy@webkit.org
  • 4 edits in trunk/LayoutTests

[Qt] One more unreviewed gardening after r106487
https://bugs.webkit.org/show_bug.cgi?id=77628

  • platform/qt-5.0/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/qt/Skipped: Skip new crashing tests after r106554.
09:58 Changeset [106566] by cmarrin@apple.com
  • 7 edits in trunk

Turn on CSS Filters on Windows
https://bugs.webkit.org/show_bug.cgi?id=76667

Source/WebCore:

Turning on CSS_FILTERS flag for Windows and fixed a couple of resultant build errors

Reviewed by Adele Peterson.

  • WebCore.vcproj/copyForwardingHeaders.cmd:
  • platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayer::setFilters):
(PlatformCALayer::filtersCanBeComposited):

WebKitLibraries:

Turned on CSS_FILTERS for Windows

Reviewed by Adele Peterson.

  • win/tools/vsprops/FeatureDefines.vsprops:

LayoutTests:

Skipped filter test files not supported on Windows

Reviewed by Adele Peterson.

  • platform/win/Skipped:
09:44 Changeset [106565] by andersca@apple.com
  • 5 edits
    3 adds in trunk/Source/WebCore

Move ScrollingThread to its own file
https://bugs.webkit.org/show_bug.cgi?id=77652

Reviewed by Sam Weinig.

This just shuffles some classes around and makes ScrollingCoordinator call into ScrollingThread.
Hopefully we'll be able to make ScrollingThread use the new WebCore::RunLoop class eventually.

  • WebCore.xcodeproj/project.pbxproj:
  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::handleWheelEvent):

  • page/scrolling/ScrollingCoordinator.h:

(ScrollingCoordinator):

  • page/scrolling/ScrollingThread.cpp: Added.

(WebCore):
(WebCore::ScrollingThread::ScrollingThread):
(WebCore::ScrollingThread::isCurrentThread):
(WebCore::ScrollingThread::dispatch):
(WebCore::ScrollingThread::shared):
(WebCore::ScrollingThread::createThreadIfNeeded):
(WebCore::ScrollingThread::threadCallback):
(WebCore::ScrollingThread::threadBody):
(WebCore::ScrollingThread::dispatchFunctionsFromScrollingThread):

  • page/scrolling/ScrollingThread.h: Added.

(WebCore):
(ScrollingThread):

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinator::scrollByOnScrollingThread):
(WebCore::ScrollingCoordinator::updateMainFrameScrollLayerPositionOnScrollingThread):

  • page/scrolling/mac/ScrollingThreadMac.mm: Added.

(WebCore):
(WebCore::ScrollingThread::initializeRunLoop):
(WebCore::ScrollingThread::wakeUpRunLoop):
(WebCore::ScrollingThread::threadRunLoopSourceCallback):

09:39 Changeset [106564] by tonyg@chromium.org
  • 1 edit
    14 adds in trunk/LayoutTests

Unreviewed chromium baselines for new tests in r106551.

  • platform/chromium-mac-leopard/svg/custom/glyph-selection-arabic-forms-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/glyph-selection-arabic-forms-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/custom/glyph-selection-bidi-mirror-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/glyph-selection-non-bmp-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/glyph-selection-arabic-forms-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/glyph-selection-arabic-forms-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/custom/glyph-selection-bidi-mirror-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/glyph-selection-bidi-mirror-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/custom/glyph-selection-non-bmp-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/glyph-selection-non-bmp-expected.txt: Added.
  • platform/chromium-win/svg/custom/glyph-selection-arabic-forms-expected.png: Added.
  • platform/chromium-win/svg/custom/glyph-selection-bidi-mirror-expected.png: Added.
  • platform/chromium-win/svg/custom/glyph-selection-non-bmp-expected.png: Added.
  • platform/chromium-win/svg/custom/glyph-selection-non-bmp-expected.txt: Added.
09:20 Changeset [106563] by commit-queue@webkit.org
  • 5 edits
    9 deletes in trunk

Unreviewed, rolling out r106551.
http://trac.webkit.org/changeset/106551
https://bugs.webkit.org/show_bug.cgi?id=77648

Breaking mac and gtk tests due to font differences. (Requested
by _pdr_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-02

Source/WebCore:

  • platform/graphics/SVGGlyph.cpp:

(WebCore::charactersWithArabicForm):

  • svg/SVGFontData.cpp:

(WebCore::SVGFontData::applySVGGlyphSelection):

  • svg/SVGFontData.h:

(SVGFontData):

LayoutTests:

  • svg/custom/glyph-selection-arabic-forms-expected.png: Removed.
  • svg/custom/glyph-selection-arabic-forms-expected.txt: Removed.
  • svg/custom/glyph-selection-arabic-forms.svg: Removed.
  • svg/custom/glyph-selection-bidi-mirror-expected.png: Removed.
  • svg/custom/glyph-selection-bidi-mirror-expected.txt: Removed.
  • svg/custom/glyph-selection-bidi-mirror.svg: Removed.
  • svg/custom/glyph-selection-non-bmp-expected.png: Removed.
  • svg/custom/glyph-selection-non-bmp-expected.txt: Removed.
  • svg/custom/glyph-selection-non-bmp.svg: Removed.
09:15 Changeset [106562] by kubo@profusion.mobi
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Remove check for ENABLE_GTK_PLUGINS_SUPPORT
https://bugs.webkit.org/show_bug.cgi?id=77647

Reviewed by Martin Robinson.

There is no clear reason why this check was in place (it came with the
upstreaming of the port), but ENABLE_GTK_PLUGINS_SUPPORT is not set
anywhere, and the build system does not even check for the presence of
GTK+ when building.

  • ewk/ewk_main.cpp:

(_ewk_init_body):

08:59 Changeset [106561] by msaboff@apple.com
  • 2 edits in trunk/Tools

Add myself as a reviewer.

08:51 WebKit Team edited by msaboff@apple.com
(diff)
08:40 Changeset [106560] by apavlov@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: [REGRESSION] Slow continuous DOM traversal with Up/Down keys
https://bugs.webkit.org/show_bug.cgi?id=77643

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/styles/updates-during-dom-traversal.html

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate):

LayoutTests:

  • inspector/styles/updates-during-dom-traversal-expected.txt: Added.
  • inspector/styles/updates-during-dom-traversal.html: Added.
08:28 Changeset [106559] by commit-queue@webkit.org
  • 13 edits in trunk/Source

[GTK] WebKitWebView won't work in a GtkOffscreenWindow
https://bugs.webkit.org/show_bug.cgi?id=76911

Patch by Claudio Saavedra <csaavedra@igalia.com> and Martin Robinson <mrobinson@igalia.com> on 2012-02-02
Reviewed by Philippe Normand.

Source/WebCore:

  • platform/gtk/GtkUtilities.cpp:

(WebCore::widgetIsOnscreenToplevelWindow): Added this helper.

  • platform/gtk/GtkUtilities.h:

(WebCore): Added helper declaration.

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::windowRect): Use the new widgetIsOnscreenToplevelWindow helper.
(WebKit::ChromeClient::setWindowRect): Ditto.
(WebKit::ChromeClient::unfocus): Ditto.
(WebKit::ChromeClient::runOpenPanel): Ditto.

  • tests/testwebview.c: Added a test to ensure that loading a page in an offscreen window does not crash.
  • webkit/webkitglobals.cpp:

(currentToplevelCallback):

  • webkit/webkitwebframe.cpp:

(webkit_web_frame_print_full):
(webkit_web_frame_print):

  • webkit/webkitwebview.cpp:

(webkit_web_view_focus_in_event):
(webkit_web_view_script_dialog):

Source/WebKit2:

  • UIProcess/API/gtk/WebKitUIClient.cpp:

(getWindowFrame): Use the new helper.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewCreateJavaScriptDialog): Ditto

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseRealize): Ditto.
(webkitWebViewBaseSizeAllocate): Ditto.
(webkitWebViewBaseFocusInEvent): Ditto.

07:53 Changeset [106558] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

fast/speech/bubble-position.html fails on mac
https://bugs.webkit.org/show_bug.cgi?id=77641

Unreviewed expectations update.

  • platform/chromium/test_expectations.txt: Test introduced by 106438, never passed on mac.
07:48 Changeset [106557] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][Mac] Unreviewed gardening, skip new failing tests to paint the bot green.

  • platform/qt-mac/Skipped:
07:27 Changeset [106556] by tonyg@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed rebaseline of imperceptible shadow change.

  • platform/chromium-mac-snowleopard/fast/box-shadow/box-shadow-clipped-slices-expected.png:
07:13 Changeset [106555] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r106551.

  • platform/qt/Skipped: Skip new tests because of missing testfonts.
07:09 Changeset [106554] by commit-queue@webkit.org
  • 7 edits in trunk/Source

Source/WebCore: Update active and hover state on touch release.
https://bugs.webkit.org/show_bug.cgi?id=77620

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-02
Reviewed by Kenneth Rohde Christiansen.

  • rendering/HitTestRequest.h:

(WebCore::HitTestRequest::move):
(WebCore::HitTestRequest::release):
(WebCore::HitTestRequest::touchEvent):
(WebCore::HitTestRequest::mouseEvent):
(WebCore::HitTestRequest::touchMove):
(WebCore::HitTestRequest::touchRelease):

Rename the enum values in HitTestRequest to be mouse/touch
agnostic, and add value for recognizing touch events.

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::nodeAtPoint): Update for HitTestRequest rename.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTest): ditto
(WebCore::RenderLayer::updateHoverActiveState): Reset hoverstate on touch release.

  • page/EventHandler.cpp:

(WebCore::EventHandler::updateSelectionForMouseDrag): Update for HitTestRequest rename.
(WebCore::EventHandler::handleMouseMoveEvent): ditto
(WebCore::EventHandler::handleMouseReleaseEvent): ditto
(WebCore::EventHandler::hoverTimerFired): ditto
(WebCore::EventHandler::dragSourceEndedAt): ditto
(WebCore::EventHandler::handleTouchEvent): Hittest touch release to reset

active and hover states and add touch enum to all touch hittests.

Source/WebKit/chromium: Update enum name for HitTestRequest::RequestType
https://bugs.webkit.org/show_bug.cgi?id=77620

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-02
Reviewed by Kenneth Rohde Christiansen.

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::visiblePositionForWindowPoint):

06:47 Changeset [106553] by ossy@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

[Qt] Unreviewed gardening after r106487
https://bugs.webkit.org/show_bug.cgi?id=77628

Patch by János Badics <dicska@gmail.com> on 2012-02-02

  • platform/qt-wk2/Skipped: Skip the test made fast/events/resize-subframe.html timeout.
  • platform/qt/fast/events/remove-target-with-shadow-in-drag-expected.txt: Added.
06:42 BuildingQt5OnHarmattan edited by lauro.neto@openbossa.org
Add information about qt5 packages for n9. (diff)
06:28 Changeset [106552] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: enable editing of selected rows on single click in elements panel.
https://bugs.webkit.org/show_bug.cgi?id=77627

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype.onattach):
(WebInspector.ElementsTreeElement.prototype.onselect):
(WebInspector.ElementsTreeElement.prototype._mouseDown):

  • inspector/front-end/treeoutline.js:

(TreeElement.prototype.selectOnMouseDown):
(TreeElement.prototype.select):

06:27 Changeset [106551] by commit-queue@webkit.org
  • 5 edits
    9 adds in trunk

Fix mirroring with SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=77067

Patch by Philip Rogers <pdr@google.com> on 2012-02-02
Reviewed by Nikolas Zimmermann.

Source/WebCore:

SVG fonts were incorrectly handling mirrored characters in bidi text.
In this change I added the function createStringWithMirroredCharacters
which handles mirroring the characters when selecting glyphs for SVG
fonts. I also made a small cosmetic change in the function
charactersWithArabicForm, changing the bool parameter "mirror" to "rtl"
which better reflects what it actually does.

Several new tests were added to test mirroring with SVG fonts in the
presence of Arabic forms and non-BMP characters.

Tests: svg/custom/glyph-selection-arabic-forms.svg

svg/custom/glyph-selection-bidi-mirror.svg
svg/custom/glyph-selection-non-bmp.svg

  • platform/graphics/SVGGlyph.cpp:

(WebCore::charactersWithArabicForm):

  • svg/SVGFontData.cpp:

(WebCore::SVGFontData::applySVGGlyphSelection):
(WebCore::SVGFontData::createStringWithMirroredCharacters):

  • svg/SVGFontData.h:

(SVGFontData):

LayoutTests:

SVG fonts were incorrectly handling mirrored characters in bidi text.
In this change I added the function createStringWithMirroredCharacters
which handles mirroring the characters when selecting glyphs for SVG
fonts. I also made a small cosmetic change in the function
charactersWithArabicForm, changing the bool parameter "mirror" to "rtl"
which better reflects what it actually does.

Several new tests were added to test mirroring with SVG fonts in the
presence of Arabic forms and non-BMP characters.

  • svg/custom/glyph-selection-arabic-forms-expected.txt: Added.
  • svg/custom/glyph-selection-arabic-forms.svg: Added.
  • svg/custom/glyph-selection-bidi-mirror-expected.txt: Added.
  • svg/custom/glyph-selection-bidi-mirror.svg: Added.
  • svg/custom/glyph-selection-non-bmp-expected.txt: Added.
  • svg/custom/glyph-selection-non-bmp.svg: Added.
06:25 Changeset [106550] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: add experiment for single click styles editing.
https://bugs.webkit.org/show_bug.cgi?id=77624

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection):
(WebInspector.StylePropertyTreeElement.prototype.onattach):
(WebInspector.StylePropertyTreeElement.prototype._mouseDown):
(WebInspector.StylePropertyTreeElement.prototype._resetMouseDownElement):
(WebInspector.StylePropertyTreeElement.prototype):
(WebInspector.StylePropertyTreeElement.prototype.selectElement.context):

06:13 Changeset [106549] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/Tools

Add myself as a commiter

05:58 Changeset [106548] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, marking a new test as flaky on GTK.

  • platform/gtk/test_expectations.txt:

fast/forms/radio/radio-group.html fails on and off.

05:53 Changeset [106547] by kenneth@webkit.org
  • 2 edits in trunk/Source/WebCore

Make the tap highlighting work for all test cases
https://bugs.webkit.org/show_bug.cgi?id=77626

Reviewed by Simon Hausmann.

Clean up of the current code to make it more generic. Now uses
addFocusRingRects for finding the areas to highlight.

Tested by current manual tests.

  • page/GestureTapHighlighter.cpp:

(WebCore::GestureTapHighlighter::pathForNodeHighlight):

05:42 Changeset [106546] by philn@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed, GTK rebaseline and skipping 3 new test failures.

  • platform/gtk/Skipped:
  • platform/gtk/fast/events/remove-target-with-shadow-in-drag-expected.txt: Added.
05:18 Changeset [106545] by mario@webkit.org
  • 4 edits in trunk/Source

[Gtk] atk_text_get_text_at_offset() sometimes fails to provide the correct line
https://bugs.webkit.org/show_bug.cgi?id=72382

Reviewed by Martin Robinson.

Source/WebCore:

Do not add unnecesary blanks at the end of a line of text.

  • accessibility/gtk/WebKitAccessibleInterfaceText.cpp:

(textForRenderer): Do not just append a '\n' at the end of a line
if the linebreak for that line was already considered.

Source/WebKit/gtk:

New unit test to ensure the right line is retrieved for the first
position of each line in a multiline preformatted portion of text.

  • tests/testatk.c:

(testWebkitAtkGetTextAtOffsetWithPreformattedText): New unit test.
(main): Add the new unit test.

02:25 Changeset [106544] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Regions should ignore the saved currentRenderFlowThread during repainting
because if there are imbricated flow threads, it might end using the wrong one.

[CSSRegions] Assert failure in RenderView::computeRectForRepaint
https://bugs.webkit.org/show_bug.cgi?id=77430

Patch by Raul Hudea <rhudea@adobe.com> on 2012-02-02
Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/imbricated-flow-threads-crash.html

  • rendering/RenderFlowThread.cpp:

(CurrentRenderFlowThreadDisabler):
(WebCore::CurrentRenderFlowThreadDisabler::CurrentRenderFlowThreadDisabler):
(WebCore::CurrentRenderFlowThreadDisabler::~CurrentRenderFlowThreadDisabler):
(WebCore):
(WebCore::RenderFlowThread::repaintRectangleInRegions):

LayoutTests:

  • fast/regions/imbricated-flow-threads-crash-expected.txt: Added.
  • fast/regions/imbricated-flow-threads-crash.html: Added.
02:24 Changeset [106543] by rniwa@webkit.org
  • 4 edits
    1 add in trunk

[PerformanceTests] tests have dependencies
https://bugs.webkit.org/show_bug.cgi?id=77506

Reviewed by Hajime Morita.

PerformanceTests:

  • resources/init.html: Added.

Tools:

Load an initialization page before each test after starting a DRT so that
warming up DRT won't affect the performance test results.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner):
(PerfTestsRunner.init):
(PerfTestsRunner._run_tests_set):
(PerfTestsRunner._run_single_test):

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(MainTest.TestDriver.run_test):
(test_initial_page_loaded):
(test_initial_page_loaded.run_test):

01:31 Changeset [106542] by kinuko@chromium.org
  • 16 edits in trunk/Source

Cleanup: Move chrome-specific filesystem type handling code (for FileSystem API) under chromium directory (re-landing r105395)
https://bugs.webkit.org/show_bug.cgi?id=76551

Source/WebCore:

Reviewed by David Levin.

Moved the implementation of crackFileSystemURL() and toURL() from
WebCore/fileapi/DOMFileSystemBase into WebCore/platform/AsyncFileSystem
so that each platform can extend/implement their behavior if necessary.

No new tests as it has no functional changes.

  • fileapi/DOMFileSystemBase.cpp: Moved crackFileSystemURL() to AsyncFileSystem.
  • fileapi/DOMFileSystemBase.h:

(DOMFileSystemBase):

  • fileapi/EntryBase.cpp: Moved toURL() to AsyncFileSystem.

(WebCore::EntryBase::toURL):

  • page/DOMWindow.cpp: Made corresponding callsite changes.

(WebCore::DOMWindow::webkitRequestFileSystem):
(WebCore::DOMWindow::webkitResolveLocalFileSystemURL):

  • page/DOMWindow.h:
  • platform/AsyncFileSystem.cpp:

(WebCore::AsyncFileSystem::isValidType): Added.

  • platform/AsyncFileSystem.h:

(AsyncFileSystem):

  • workers/WorkerContext.cpp: Made corresponding callsite changes.

(WebCore::WorkerContext::webkitRequestFileSystem):
(WebCore::WorkerContext::webkitRequestFileSystemSync):
(WebCore::WorkerContext::webkitResolveLocalFileSystemURL):
(WebCore::WorkerContext::webkitResolveLocalFileSystemSyncURL):

  • workers/WorkerContext.h:

Source/WebKit/chromium:

  • src/AssertMatchingEnums.cpp: Removed the matching assertion for AsyncFileSystem::External (as now we directly use WebFileSystem::TypeExternal).
  • src/AsyncFileSystemChromium.cpp:

(WebCore::AsyncFileSystem::crackFileSystemURL): Added.
(WebCore::AsyncFileSystem::isValidType): Added.
(WebCore::AsyncFileSystemChromium::toURL): Added.

  • src/AsyncFileSystemChromium.h:

(AsyncFileSystemChromium):

  • src/WorkerAsyncFileSystemChromium.cpp: Made this subclass of AsyncFileSystemChromium (rather than that of AsyncFileSystem)

(WebCore::WorkerAsyncFileSystemChromium::WorkerAsyncFileSystemChromium):

  • src/WorkerAsyncFileSystemChromium.h:

(WorkerAsyncFileSystemChromium):

01:12 Changeset [106541] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: pause on uncaugh exceptions state is not properly restored
https://bugs.webkit.org/show_bug.cgi?id=77558

'Pause on exceptions' state is now stored in InspectorState object so that it is
properly restored on inspected process change.

Reviewed by Vsevolod Vlasov.

  • inspector/InspectorDebuggerAgent.cpp:

(DebuggerAgentState):
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::disable):
(WebCore::InspectorDebuggerAgent::restore):
(WebCore::InspectorDebuggerAgent::setPauseOnExceptions):
(WebCore):
(WebCore::InspectorDebuggerAgent::setPauseOnExceptionsImpl):

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

00:27 Changeset [106540] by rniwa@webkit.org
  • 3 edits in trunk/Tools

Re-land r106442 per Adam's suggestion. We'll do both restarting DRT and loading a fake test first.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._run_tests_set):
(PerfTestsRunner._run_single_test):

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(create_runner):
(test_run_passing_test):
(test_run_silent_test):
(test_run_failed_test):
(test_run_tonguey_test):
(test_run_timeout_test):
(test_run_crash_test):
(test_run_test_set_kills_drt_per_run):
(test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
(test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.init):
(test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):

00:23 Changeset [106539] by haraken@chromium.org
  • 3 edits
    2 adds in trunk

The third argument of addEventListener/removeEventListener of PeerConnection should be optional
https://bugs.webkit.org/show_bug.cgi?id=77606

Reviewed by Adam Barth.

Source/WebCore:

This patch corrects a typo in PeerConnection.idl, i.e. [optional] => [Optional].

Test: fast/mediastream/peerconnection-eventlistener-optional-argument.html

  • mediastream/PeerConnection.idl:

LayoutTests:

The added test confirms if the third argument of addEventListener() and
removeEventListener() is optional.

  • fast/mediastream/peerconnection-eventlistener-optional-argument-expected.txt: Added.
  • fast/mediastream/peerconnection-eventlistener-optional-argument.html: Added.
00:09 Changeset [106538] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk

hidden attribute on <input type=file /> suppresses the file selection dialog
https://bugs.webkit.org/show_bug.cgi?id=58208

Patch by Rakesh KN <rakesh.kn@motorola.com> on 2012-02-02
Reviewed by Ryosuke Niwa.

.:

  • ManualTests/input-file-hidden-open-dialog-on-click.html: Added.

Adding manual test as the file dialog opens only in User gesture.

Source/WebCore:

We want to allow opening file dialog on hidden element when click() is called
on the element. The behaviour is similar to Firefox and IE.

Added manual test as the file dialog opens only on user gesture.

  • html/FileInputType.cpp:

(WebCore::FileInputType::handleDOMActivateEvent):
Removed renderer check as input can be hidden.

00:04 Changeset [106537] by philn@webkit.org
  • 13 edits in trunk

[GStreamer] FFTFrame implementation
https://bugs.webkit.org/show_bug.cgi?id=73545

Reviewed by Chris Rogers.

.:

  • configure.ac: Enable the WebAudio option again and remove

libfftw checks.

Source/WebCore:

FFTFrame implementation based on GStreamer's FFT processing
library.

No new tests, existing WebAudio tests cover this.

  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • platform/audio/FFTFrame.h:
  • platform/audio/FFTFrameStub.cpp:
  • platform/audio/gstreamer/FFTFrameGStreamer.cpp: Added.

(WebCore::FFTFrame::FFTFrame):
(WebCore::FFTFrame::initialize):
(WebCore::FFTFrame::cleanup):
(WebCore::FFTFrame::~FFTFrame):
(WebCore::FFTFrame::multiply):
(WebCore::FFTFrame::doFFT):
(WebCore::FFTFrame::doInverseFFT):
(WebCore::FFTFrame::realData):
(WebCore::FFTFrame::imagData):

Source/WebKit/gtk:

  • GNUmakefile.am: Remove libfftw compilation flags.

Source/WebKit2:

  • GNUmakefile.am: Remove libfftw compilation flags.

LayoutTests:

  • webaudio/resources/convolution-testing.js:

(checkTail1): Adapt convolution threshold for GStreamerFFTFrame
implementation, as advised by Chris Rogers.

00:00 Changeset [106536] by haraken@chromium.org
  • 9 edits in trunk/Source/WebCore

Rename [CheckFrameSecurity] and [SVGCheckSecurity] to [CheckAccessToNode]
https://bugs.webkit.org/show_bug.cgi?id=77601

Reviewed by Adam Barth.

[CheckFrameSecurity] and [SVGCheckSecurity] have the same meaning; i.e. generate code
to check allowAccessToNode() for a given attribute or method. This patch renames them
to [CheckAccessToNode].

No tests. No changes in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateFunctionCallback):

  • html/HTMLEmbedElement.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLIFrameElement.idl:
  • html/HTMLObjectElement.idl:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp: Updated the test results.

(WebCore):

Note: See TracTimeline for information about the timeline view.