Timeline


and

02/07/12:

23:21 Changeset [107043] by mrobinson@webkit.org

[GTK] [WK2] Add WebKitResponsePolicyDecision
https://bugs.webkit.org/show_bug.cgi?id=76789

Reviewed by Philippe Normand.

Add a WebKitResponsePolicyDecision GObject, use it for response
policy decisions and add a test.

  • GNUmakefile.am: Added new source files to the list.
  • UIProcess/API/gtk/WebKitPolicyClient.cpp:

(decidePolicyForResponseCallback): Added this callback which creates the request
and fires the signal.
(attachPolicyClientToPage): Added new callback to the C API policy client.

  • UIProcess/API/gtk/WebKitResponsePolicyDecision.cpp: Added.
  • UIProcess/API/gtk/WebKitResponsePolicyDecision.h: Added.
  • UIProcess/API/gtk/WebKitResponsePolicyDecisionPrivate.h: Added.
  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Added new docs.
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Ditto.
  • UIProcess/API/gtk/tests/TestWebKitPolicyClient.cpp:

(testResponsePolicy): Added this test for response policy decisions.
(serverCallback): Added a SoupServer to test policy response policy decisions.
(beforeAll): Ditto.
(afterAll): Ditto.

22:56 Changeset [107042] by commit-queue@webkit.org

[chromium] Move geometry headers in Platform API to Platform directory
https://bugs.webkit.org/show_bug.cgi?id=78067

Patch by James Robinson <jamesr@chromium.org> on 2012-02-07
Reviewed by Adam Barth.

Source/Platform:

This moves several geometry-related headers in the chromium WebKit platform API to Platform/chromium/public.
These require a bit of extra work since when WEBKIT_IMPLEMENTATION is set they #include headers from
WebCore/platform such as IntPoint so that the implementations of several functions can be inlined. Since we do
not want to add anything in WebCore to the include path of projects that depend on the Platform API this poses a
bit of an issue. I've added an extra build step to copy the specific headers used into the
SHARED_INTERMEDIATE_DIR to preserve this inlining.

Eventually we'll move the cross-platform code, including these headers, into somewhere under Platform/, but doing
that requires non-trivial modifications to every build system in WebKit.

  • Platform.gyp/Platform.gyp:
  • Platform.gyp/copy_webcore_headers.py: Added.

(CopyHeaders):
(Main):

  • chromium/public/WebFloatPoint.h: Copied from Source/WebKit/chromium/public/platform/WebFloatPoint.h.

(WebKit):
(WebFloatPoint):
(WebKit::WebFloatPoint::WebFloatPoint):
(WebKit::WebFloatPoint::operator=):
(WebKit::WebFloatPoint::operator WebCore::FloatPoint):
(WebKit::operator==):
(WebKit::operator!=):

  • chromium/public/WebFloatQuad.h: Copied from Source/WebKit/chromium/public/platform/WebFloatQuad.h.

(WebKit):
(WebFloatQuad):
(WebKit::WebFloatQuad::WebFloatQuad):
(WebKit::WebFloatQuad::operator=):

  • chromium/public/WebFloatRect.h: Copied from Source/WebKit/chromium/public/platform/WebFloatRect.h.

(WebKit):
(WebFloatRect):
(WebKit::WebFloatRect::isEmpty):
(WebKit::WebFloatRect::WebFloatRect):
(WebKit::WebFloatRect::operator=):
(WebKit::WebFloatRect::operator WebCore::FloatRect):
(WebKit::operator==):
(WebKit::operator!=):

  • chromium/public/WebPoint.h: Copied from Source/WebKit/chromium/public/platform/WebPoint.h.

(WebKit):
(WebPoint):
(WebKit::WebPoint::WebPoint):
(WebKit::WebPoint::operator=):
(WebKit::WebPoint::operator WebCore::IntPoint):
(WebKit::WebPoint::operator gfx::Point):
(WebKit::operator==):
(WebKit::operator!=):

  • chromium/public/WebRect.h: Copied from Source/WebKit/chromium/public/platform/WebRect.h.

(WebKit):
(WebRect):
(WebKit::WebRect::isEmpty):
(WebKit::WebRect::WebRect):
(WebKit::WebRect::operator=):
(WebKit::WebRect::operator WebCore::IntRect):
(WebKit::WebRect::operator gfx::Rect):
(WebKit::operator==):
(WebKit::operator!=):

  • chromium/public/WebSize.h: Copied from Source/WebKit/chromium/public/platform/WebSize.h.

(WebKit):
(WebSize):
(WebKit::WebSize::isEmpty):
(WebKit::WebSize::WebSize):
(WebKit::WebSize::operator=):
(WebKit::WebSize::operator WebCore::IntSize):
(WebKit::WebSize::operator gfx::Size):
(WebKit::operator==):
(WebKit::operator!=):

Source/WebKit/chromium:

Add forwarding headers for several API types moved into Platform.

  • public/platform/WebFloatPoint.h:
  • public/platform/WebFloatQuad.h:
  • public/platform/WebFloatRect.h:
  • public/platform/WebPoint.h:
  • public/platform/WebRect.h:
  • public/platform/WebSize.h:
22:40 Changeset [107041] by haraken@chromium.org

Add "JS" prefix to JSC-specific IDLs
https://bugs.webkit.org/show_bug.cgi?id=77846

Reviewed by Darin Adler.

In bug 77693, we have added "JS" prefix to several JSC specific IDLs.
This patch adds "JS" prefix to the remaining JSC specific IDLs.
Specifically, this patch renames IDLs as follows:

[CustomDefineOwnProperty] => [JSCustomDefineOwnProperty]
[CustomPrototypeDefineOwnProperty] => [JSCustomPrototypeDefineOwnProperty]
[GenerateNativeConverter] => [JSGenerateToNativeObject] (Note: For naming consistency
with [JSGenerateToJS] and [JSCustomToNativeObject])
[DelegatingGetOwnPropertySlot] => [JSCustomGetOwnPropertySlotDelegate] (Note: Should be prefixed "JS",
should be prefixed with "Custom", and for naming consistency with [CustomGetOwnPropertySlot])

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/test/TestTypedArray.idl:
  • dom/Attr.idl:
  • dom/DataTransferItemList.idl:
  • dom/Document.idl:
  • dom/DocumentType.idl:
  • dom/Element.idl:
  • dom/Node.idl:
  • fileapi/DirectoryEntry.idl:
  • fileapi/DirectoryEntrySync.idl:
  • fileapi/File.idl:
  • fileapi/FileEntry.idl:
  • fileapi/FileEntrySync.idl:
  • fileapi/WebKitBlobBuilder.idl:
  • html/DOMFormData.idl:
  • html/DOMURL.idl:
  • html/HTMLAppletElement.idl:
  • html/HTMLCanvasElement.idl:
  • html/HTMLElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLImageElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLOptionElement.idl:
  • html/HTMLOptionsCollection.idl:
  • html/HTMLTableCaptionElement.idl:
  • html/HTMLTableSectionElement.idl:
  • html/HTMLVideoElement.idl:
  • html/TextTrackCue.idl:
  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • html/canvas/Uint8ClampedArray.idl:
  • mediastream/LocalMediaStream.idl:
  • page/DOMWindow.idl:
  • page/History.idl:
  • page/Location.idl:
  • storage/StorageInfo.idl:
  • svg/SVGElement.idl:
  • svg/SVGElementInstance.idl:
  • workers/DedicatedWorkerContext.idl:
  • workers/SharedWorker.idl:
  • workers/SharedWorkerContext.idl:
  • workers/Worker.idl:
  • workers/WorkerContext.idl:
22:33 Changeset [107040] by morrita@google.com

[Chromium] WebTextCheckingResult should have new default constructor
https://bugs.webkit.org/show_bug.cgi?id=78066

Reviewed by Ryosuke Niwa.

Added a new default constructor. ex-default constructor will be removed
in an upcoming change.

  • public/WebTextCheckingResult.h:

(WebKit::WebTextCheckingResult::WebTextCheckingResult):
(WebTextCheckingResult):

21:47 Changeset [107039] by haraken@chromium.org

Rename [HasOverridingNameGetter] attribute to [CustomNamedGetter] attribute
https://bugs.webkit.org/show_bug.cgi?id=78076

Reviewed by Adam Barth.

This patch renames the [HasOverridingNameGetter] attribute to the
[CustomNamedGetter] attribute, for naming consistency with [CustomNamedSetter].

Test: bindings/scripts/test/TestCustomNamedGetter.idl

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateImplementationNamedPropertyGetter):

  • html/HTMLDocument.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLFrameSetElement.idl:
  • bindings/scripts/test/TestCustomNamedGetter.idl: Renamed from Source/WebCore/bindings/scripts/test/TestOverridingNameGetter.idl.
  • bindings/scripts/test/CPP/WebDOMTestCustomNamedGetter.cpp: Updated run-bindings-tests results.

(WebDOMTestCustomNamedGetter::WebDOMTestCustomNamedGetterPrivate::WebDOMTestCustomNamedGetterPrivate):
(WebDOMTestCustomNamedGetter::WebDOMTestCustomNamedGetterPrivate):
(WebDOMTestCustomNamedGetter::WebDOMTestCustomNamedGetter):
(WebDOMTestCustomNamedGetter::operator=):
(WebDOMTestCustomNamedGetter::impl):
(WebDOMTestCustomNamedGetter::~WebDOMTestCustomNamedGetter):
(WebDOMTestCustomNamedGetter::anotherFunction):
(toWebCore):
(toWebKit):

  • bindings/scripts/test/CPP/WebDOMTestCustomNamedGetter.h: Ditto.

(WebCore):
(WebDOMTestCustomNamedGetter):

  • bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp: Ditto.

(WebKit):
(WebKit::kit):
(webkit_dom_test_custom_named_getter_another_function):
(WebKit::core):
(webkit_dom_test_custom_named_getter_finalize):
(webkit_dom_test_custom_named_getter_set_property):
(webkit_dom_test_custom_named_getter_get_property):
(webkit_dom_test_custom_named_getter_constructed):
(webkit_dom_test_custom_named_getter_class_init):
(webkit_dom_test_custom_named_getter_init):
(WebKit::wrapTestCustomNamedGetter):

  • bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.h: Ditto.

(_WebKitDOMTestCustomNamedGetter):
(_WebKitDOMTestCustomNamedGetterClass):

  • bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetterPrivate.h: Ditto.

(WebKit):

  • bindings/scripts/test/GObject/WebKitDOMTestOverridingNameGetter.h: Ditto.
  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp: Ditto.

(WebCore):
(WebCore::JSTestCustomNamedGetterConstructor::JSTestCustomNamedGetterConstructor):
(WebCore::JSTestCustomNamedGetterConstructor::finishCreation):
(WebCore::JSTestCustomNamedGetterConstructor::getOwnPropertySlot):
(WebCore::JSTestCustomNamedGetterConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestCustomNamedGetterPrototype::self):
(WebCore::JSTestCustomNamedGetterPrototype::getOwnPropertySlot):
(WebCore::JSTestCustomNamedGetterPrototype::getOwnPropertyDescriptor):
(WebCore::JSTestCustomNamedGetter::JSTestCustomNamedGetter):
(WebCore::JSTestCustomNamedGetter::finishCreation):
(WebCore::JSTestCustomNamedGetter::createPrototype):
(WebCore::JSTestCustomNamedGetter::destroy):
(WebCore::JSTestCustomNamedGetter::getOwnPropertySlot):
(WebCore::JSTestCustomNamedGetter::getOwnPropertyDescriptor):
(WebCore::jsTestCustomNamedGetterConstructor):
(WebCore::JSTestCustomNamedGetter::getConstructor):
(WebCore::jsTestCustomNamedGetterPrototypeFunctionAnotherFunction):
(WebCore::isObservable):
(WebCore::JSTestCustomNamedGetterOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestCustomNamedGetterOwner::finalize):
(WebCore::toJS):
(WebCore::toTestCustomNamedGetter):

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.h: Ditto.

(WebCore):
(JSTestCustomNamedGetter):
(WebCore::JSTestCustomNamedGetter::create):
(WebCore::JSTestCustomNamedGetter::createStructure):
(WebCore::JSTestCustomNamedGetter::impl):
(WebCore::JSTestCustomNamedGetter::releaseImpl):
(WebCore::JSTestCustomNamedGetter::releaseImplIfNotNull):
(JSTestCustomNamedGetterOwner):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
(JSTestCustomNamedGetterPrototype):
(WebCore::JSTestCustomNamedGetterPrototype::create):
(WebCore::JSTestCustomNamedGetterPrototype::createStructure):
(WebCore::JSTestCustomNamedGetterPrototype::JSTestCustomNamedGetterPrototype):
(JSTestCustomNamedGetterConstructor):
(WebCore::JSTestCustomNamedGetterConstructor::create):
(WebCore::JSTestCustomNamedGetterConstructor::createStructure):

  • bindings/scripts/test/JS/JSTestOverridingNameGetter.cpp:
  • bindings/scripts/test/ObjC/DOMTestCustomNamedGetter.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestCustomNamedGetter.mm: Ditto.

(-[DOMTestCustomNamedGetter dealloc]):
(-[DOMTestCustomNamedGetter finalize]):
(-[DOMTestCustomNamedGetter anotherFunction:]):
(core):
(kit):

  • bindings/scripts/test/ObjC/DOMTestCustomNamedGetterInternal.h: Ditto.

(WebCore):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp: Ditto.

(WebCore):
(TestCustomNamedGetterInternal):
(WebCore::TestCustomNamedGetterInternal::V8_USE):
(WebCore::TestCustomNamedGetterInternal::anotherFunctionCallback):
(WebCore::ConfigureV8TestCustomNamedGetterTemplate):
(WebCore::V8TestCustomNamedGetter::GetRawTemplate):
(WebCore::V8TestCustomNamedGetter::GetTemplate):
(WebCore::V8TestCustomNamedGetter::HasInstance):
(WebCore::V8TestCustomNamedGetter::wrapSlow):
(WebCore::V8TestCustomNamedGetter::derefObject):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h: Ditto.

(WebCore):
(V8TestCustomNamedGetter):
(WebCore::V8TestCustomNamedGetter::toNative):
(WebCore::V8TestCustomNamedGetter::existingWrapper):
(WebCore::V8TestCustomNamedGetter::wrap):
(WebCore::toV8):

21:37 Changeset [107038] by eae@chromium.org

Revert TableSection cell and border calculations to integers
https://bugs.webkit.org/show_bug.cgi?id=77918

Reviewed by Eric Seidel.

Change RenderTableSection cell width, row height and border calculations
back to use integers. Table layout is done on integer bounds to comply
with the specification and to ensure that columns given the same width,
including percentage widths, are rendered with identical widths. The same
applies to heights.

No new tests.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::setCellLogicalWidths):
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::calcOuterBorderBefore):
(WebCore::RenderTableSection::calcOuterBorderAfter):
(WebCore::RenderTableSection::calcOuterBorderStart):
(WebCore::RenderTableSection::calcOuterBorderEnd):
(WebCore::RenderTableSection::paintObject):
(WebCore::RenderTableSection::nodeAtPoint):

  • rendering/RenderTableSection.h:

(RenderTableSection):
(WebCore::RenderTableSection::RowStruct::RowStruct):
(WebCore::RenderTableSection::outerBorderBefore):
(WebCore::RenderTableSection::outerBorderAfter):
(WebCore::RenderTableSection::outerBorderStart):
(WebCore::RenderTableSection::outerBorderEnd):

21:34 Changeset [107037] by commit-queue@webkit.org

Plumb through webGLErrorsToConsoleEnable in WebSettings
https://bugs.webkit.org/show_bug.cgi?id=78061

Patch by Gregg Tavares <gman@google.com> on 2012-02-07
Reviewed by Kenneth Russell.

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setWebGLErrorsToConsoleEnabled):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

21:06 Changeset [107036] by commit-queue@webkit.org

Source/JavaScriptCore: [chromium] Remove the enable marcro for the no longer necessary Chromium
gesture recognizer.
https://bugs.webkit.org/show_bug.cgi?id=77492

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07
Reviewed by Adam Barth.

  • wtf/Platform.h:

Source/WebCore: [chromium] Remove the no longer necessary Chromium gesture recognizer.
https://bugs.webkit.org/show_bug.cgi?id=77492

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07
Reviewed by Adam Barth.

  • WebCore.gypi:
  • platform/PlatformGestureRecognizer.h: Removed.
  • platform/chromium/FramelessScrollView.h:

(WebCore):
(FramelessScrollView):

  • platform/chromium/GestureRecognizerChromium.cpp: Removed.
  • platform/chromium/GestureRecognizerChromium.h: Removed.
  • platform/chromium/PopupContainer.cpp:

(WebCore):

  • platform/chromium/PopupContainer.h:
  • platform/chromium/PopupListBox.cpp:

(WebCore):

  • platform/chromium/PopupListBox.h:

(PopupListBox):

Source/WebKit: [chromium] Remove no longer necessary Chromium gesture recognizer code.
https://bugs.webkit.org/show_bug.cgi?id=77492

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07
Reviewed by Adam Barth.

  • blackberry/WebCoreSupport/AboutDataEnableFeatures.in:

Source/WebKit/chromium: [chromium] Remove no longer necessary Chromium gesture recognizer code.
https://bugs.webkit.org/show_bug.cgi?id=77492

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07
Reviewed by Adam Barth.

  • WebKit.gypi:
  • features.gypi:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::createFrameView):

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::WebPopupMenuImpl):
(WebKit::WebPopupMenuImpl::handleTouchEvent):

  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::touchEvent):

  • src/WebViewImpl.h:

(WebCore):
(WebViewImpl):

  • tests/InnerGestureRecognizerTest.cpp: Removed.

LayoutTests: [chromium] Remove unnecessary Chromium gesture recognizer tests.
https://bugs.webkit.org/show_bug.cgi?id=77492

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07
Reviewed by Adam Barth.

  • fast/events/touch/page-scaled-touch-gesture-click-expected.txt:
  • fast/events/touch/page-scaled-touch-gesture-click.html:
  • fast/events/touch/touch-gesture-click-expected.txt: Removed.
  • fast/events/touch/touch-gesture-click.html: Removed.
  • fast/events/touch/touch-gesture-scroll-expected.txt: Removed.
  • fast/events/touch/touch-gesture-scroll.html: Removed.
  • platform/chromium/fast/events/touch/touch-gesture-click-expected.txt: Removed.
  • platform/chromium/fast/events/touch/touch-gesture-scroll-expected.txt: Removed.
20:23 Changeset [107035] by arv@chromium.org

[V8] Allow bindings for attributes on DOM nodes to also set a named hidden reference
https://bugs.webkit.org/show_bug.cgi?id=78052

Reviewed by Nate Chapin.

Source/WebCore:

Before this patch the code generator did not add the named hidden reference when the data node
was a DOM Node. This lead to us having to create custom toV8 bindings in a few places.

Covered by existing tests

  • Target.pri:
  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(HasCustomToV8Implementation):

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:
  • bindings/v8/custom/V8DOMTokenListCustom.cpp: Removed.
  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:

LayoutTests:

  • platform/chromium/test_expectations.txt:
20:14 Changeset [107034] by haraken@chromium.org

[GTK] Ignore [Custom] attributes in CodeGeneratorGObject.pm
https://bugs.webkit.org/show_bug.cgi?id=78059

Reviewed by Adam Barth.

CodeGeneratorGObject.pm does not support custom attributes.
We can skip generating code for attributes with [Custom].
The change would make sense, since CodeGeneratorGObject.pm already
skips attributes with [CustomGetter] or [CustomSetter].

Test: bindings/scripts/test/TestObj.idl

  • bindings/scripts/CodeGeneratorGObject.pm:

(SkipAttribute):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
20:05 Changeset [107033] by leo.yang@torchmobile.com.cn

[BlackBerry] Upstream ChromeClientBlackBerry.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=77843

Reviewed by Rob Buis.

Initial upstream, no new tests.

  • blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp: Added.
  • blackberry/WebCoreSupport/ChromeClientBlackBerry.h: Added.
19:56 Changeset [107032] by eae@chromium.org

Add pixelSnappedX/Y/Width/Height methods
https://bugs.webkit.org/show_bug.cgi?id=78040

Reviewed by Eric Seidel.

Add pixel snapped versions of x/y/width/height methods. These return the
same value as the x/w/width/height methods for now but once we move over
to sub pixel layout they will snap the subpixel value to a device pixel
and return an integer value.

When snapping the left and top edge is simply rounded to the nearest
device pixel.
The right and bottom edges are computed by subtracting the rounded left/
top edge from the precise location and size. This ensures that the edges
all line up with device pixels and that the total size of an object,
including borders, is at most one pixel off.

In summary, the values are computed as follows:

x: round(x)
y: round(y)
maxX: round(x + width)
maxY: round(y + height)
width: round(x + width) - round(x)
height: round(y + height) - round(y)

We use the term pixel snapped to indicate that the numbers are not merely
rounded. This also matches the naming used by the line box tree.

No new tests, no functionality changes.

  • page/PrintContext.cpp:

(WebCore::PrintContext::pageNumberForElement):

  • rendering/RenderBlock.cpp:

(WebCore::::collectIfNeeded):

  • rendering/RenderBlock.h:

(RenderBlock):
(WebCore::RenderBlock::pixelSnappedLogicalRightOffsetForLine):
(WebCore::RenderBlock::pixelSnappedLogicalLeftOffsetForLine):
(WebCore::RenderBlock::FloatingObject::pixelSnappedX):
(WebCore::RenderBlock::FloatingObject::pixelSnappedMaxX):
(WebCore::RenderBlock::FloatingObject::pixelSnappedY):
(WebCore::RenderBlock::FloatingObject::pixelSnappedMaxY):
(WebCore::RenderBlock::FloatingObject::pixelSnappedWidth):
(WebCore::RenderBlock::FloatingObject::pixelSnappedHeight):
(FloatingObject):
(WebCore::RenderBlock::pixelSnappedLogicalTopForFloat):
(WebCore::RenderBlock::pixelSnappedLogicalBottomForFloat):
(WebCore::RenderBlock::pixelSnappedLogicalLeftForFloat):
(WebCore::RenderBlock::pixelSnappedLogicalRightForFloat):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::pixelSnappedClientWidth):
(WebCore):
(WebCore::RenderBox::pixelSnappedClientHeight):
(WebCore::RenderBox::scrollHeight):

  • rendering/RenderBox.h:

(WebCore::RenderBox::pixelSnappedWidth):
(WebCore::RenderBox::pixelSnappedHeight):
(RenderBox):
(WebCore::RenderBox::pixelSnappedOffsetWidth):
(WebCore::RenderBox::pixelSnappedOffsetHeight):
(WebCore::RenderBox::clientLogicalWidth):
(WebCore::RenderBox::clientLogicalHeight):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::pixelSnappedOffsetWidth):
(WebCore):
(WebCore::RenderBoxModelObject::pixelSnappedOffsetHeight):

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::pixelSnappedOffsetLeft):
(WebCore::RenderBoxModelObject::pixelSnappedOffsetTop):
(RenderBoxModelObject):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::pixelSnappedScrollWidth):
(WebCore):
(WebCore::RenderLayer::pixelSnappedScrollHeight):
(WebCore::RenderLayer::computeScrollDimensions):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):

  • rendering/RenderLayer.h:

(RenderLayer):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::scrollHeight):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::volumeSliderOffsetFromMuteButton):

  • rendering/RenderTreeAsText.cpp:

(WebCore::write):

19:53 Changeset [107031] by jchaffraix@webkit.org

Unreviewed gardening.

Add / update the baselines for fast/text/synthetic-bold-transformed.html and svg/custom/use-disappears-after-style-update.svg.

  • platform/chromium-linux-x86/svg/custom/use-disappears-after-style-update-expected.txt: Added.
  • platform/chromium-linux/fast/text/synthetic-bold-transformed-expected.png: Added.
  • platform/chromium-linux/svg/custom/use-disappears-after-style-update-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/synthetic-bold-transformed-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/use-disappears-after-style-update-expected.txt: Added.
  • platform/chromium-win-xp/svg/custom/use-disappears-after-style-update-expected.txt: Added.
  • platform/chromium-win/fast/text/synthetic-bold-transformed-expected.png: Added.
  • platform/chromium-win/svg/custom/use-disappears-after-style-update-expected.png: Added.
  • platform/chromium-win/svg/custom/use-disappears-after-style-update-expected.txt: Added.
19:40 Changeset [107030] by mikelawther@chromium.org

CSS3 calc() - simple parse time evaluation
https://bugs.webkit.org/show_bug.cgi?id=77960

Source/WebCore:

Adds simple number/percent expression evaluation. rgb() and hsl() functions now
allow simple calc() expressions.

Reviewed by Ojan Vafai.

  • css/CSSCalculationValue.cpp:

(WebCore):
(WebCore::CSSCalcValue::doubleValue):
(WebCore::CSSCalcPrimitiveValue::doubleValue):
(WebCore::CSSCalcBinaryOperation::doubleValue):
(CSSCalcBinaryOperation):
(WebCore::CSSCalcBinaryOperation::evaluate):

  • css/CSSCalculationValue.h:

(CSSCalcExpressionNode):
(WebCore::CSSCalcValue::isInt):
(CSSCalcValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parsedDouble):

LayoutTests:

Reviewed by Ojan Vafai.

  • css3/calc/color-hsl-expected.txt:
  • css3/calc/color-rgb-expected.txt:
19:26 Changeset [107029] by kling@webkit.org

REGRESSION(r106668-r106889): Chromium page cycler tests (Intl2) performance regressions.
<http://webkit.org/b/78068>

Reviewed by Ryosuke Niwa.

Create CSS_IDENT values for attribute styles in the document's CSSValuePool.
This regressed in r106756 and I suspect it'll fix up the cycler regression.

  • dom/StyledElement.cpp:

(WebCore::StyledElement::addCSSProperty):

19:20 Changeset [107028] by timothy@apple.com

Avoid making a window for the Web Inspector when it is docked.

This also makes sure the inspector WKView is in a window before the page is loaded.
This avoids some redundant work caused by moving it to a window later.

https://webkit.org/b/78064

Reviewed by Brian Weinstein.

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::createInspectorPage): Set m_isAttached here...
(WebKit::WebInspectorProxy::didLoadInspectorPage): ... instead of here.

  • UIProcess/WebInspectorProxy.h:

(WebInspectorProxy):

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::createInspectorWindow): Added. Factored out of platformOpen.
(WebKit::WebInspectorProxy::updateInspectorWindowTitle): Added. Factored out of platformInspectedURLChanged.
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Call platformAttach or createInspectorWindow.
(WebKit::WebInspectorProxy::platformOpen): Make the view or window visible.
(WebKit::WebInspectorProxy::platformDidClose): Only message m_inspectorWindow if it isn't nil.
(WebKit::WebInspectorProxy::platformInspectedURLChanged): Store the urlString and call updateInspectorWindowTitle.
(WebKit::WebInspectorProxy::inspectedViewFrameDidChange): Return early if not visible.
(WebKit::WebInspectorProxy::platformAttach): Start out hidden if we are not visible yet. Destroy the window.
(WebKit::WebInspectorProxy::platformDetach): Use createInspectorWindow to create it again.

19:10 Changeset [107027] by noel.gordon@gmail.com

Remove TextureMapperQt from the gyp projects
https://bugs.webkit.org/show_bug.cgi?id=78055

Reviewed by Noam Rosenthal.

TextureMapperQt.{cpp,h} were removed in r106659, remove references to
these files from the gyp projects.

  • WebCore.gypi:
19:00 Changeset [107026] by tony@chromium.org

merge DashboardSupportCSSPropertyNames.in into CSSPropertyNames.in
https://bugs.webkit.org/show_bug.cgi?id=78036

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES.

Source/WebCore:

In r89362, we started running the preprocessor through CSSPropertyNames.in.
Now we can move DashboardSupportCSSPropertyNames.in into CSSPropertyNames.in
and wrap it in an #if.

No new tests, build refactoring.

  • Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES.
  • DerivedSources.make: Remove DashboardSupportCSSPropertyNames.in.
  • DerivedSources.pri: Remove DashboardSupportCSSPropertyNames.in.
  • WebCore.xcodeproj/project.pbxproj: Remove DashboardSupportCSSPropertyNames.in.
  • css/CSSPropertyNames.in: Wrap -webkit-dashboard-region in an #if.
  • css/DashboardSupportCSSPropertyNames.in: Removed.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES.

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES.
18:51 Changeset [107025] by commit-queue@webkit.org

Enable IPP for FFTFrame
https://bugs.webkit.org/show_bug.cgi?id=75522

Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-02-07
Reviewed by Tony Chang.

Add the FFTFrame implementation using Intel IPP's DFT algorithm.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/audio/FFTFrame.h:

(FFTFrame):

  • platform/audio/FFTFrameStub.cpp:
  • platform/audio/ipp/FFTFrameIPP.cpp: Added.

(WebCore):
(WebCore::FFTFrame::FFTFrame):
(WebCore::FFTFrame::initialize):
(WebCore::FFTFrame::cleanup):
(WebCore::FFTFrame::~FFTFrame):
(WebCore::FFTFrame::multiply):
(WebCore::FFTFrame::doFFT):
(WebCore::FFTFrame::doInverseFFT):
(WebCore::FFTFrame::realData):
(WebCore::FFTFrame::imagData):
(WebCore::FFTFrame::getUpToDateComplexData):

18:47 Changeset [107024] by enne@google.com

Properly detect top level frames when propogating compositing
https://bugs.webkit.org/show_bug.cgi?id=78033

Reviewed by James Robinson.

There's no need to enumerate all tag names when searching for a
top-level frame. If a render view's document has a frame, then that
frame is not the top-level one.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingFrame):

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

18:21 Changeset [107023] by commit-queue@webkit.org

Resolve crash in FrameLoader::checkTimerFired.
https://bugs.webkit.org/show_bug.cgi?id=77907

Patch by Chris Palmer <palmer@google.com> on 2012-02-07
Reviewed by Eric Seidel.

Source/WebCore:

Test is LayoutTests/http/tests/appcache/deferred-events-delete-while-raising-timer.html.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkTimerFired):

LayoutTests:

  • http/tests/appcache/deferred-events-delete-while-raising-timer-expected.txt: Added.
  • http/tests/appcache/deferred-events-delete-while-raising-timer.html: Added.
  • http/tests/appcache/resources/deferred-events-delete-while-raising-timer-1.html: Added.
  • http/tests/appcache/resources/deferred-events-delete-while-raising-timer-2.html: Added.
18:06 Changeset [107022] by commit-queue@webkit.org

[Chromium] add option for 2d canvas defered rendering to DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=78039

Patch by Justin Novosad <junov@chromium.org> on 2012-02-07
Reviewed by Stephen White.

Adding the --enable-deferred-2d-canvas switch to DumpRenderTree

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::resetWebSettings):
(TestShell::runFileTest):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell::setDeferred2dCanvasEnabled):
(TestShell):

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset):
(WebPreferences::applyTo):

  • DumpRenderTree/chromium/WebPreferences.h:

(WebPreferences):

18:05 Changeset [107021] by commit-queue@webkit.org

[BlackBerry] NetworkJob should stop redirecting when the request is cleared by client
https://bugs.webkit.org/show_bug.cgi?id=78029

Patch by Yong Li <yoli@rim.com> on 2012-02-07
Reviewed by Rob Buis.

When a redirect is rejected by security origin check, the ResourceRequest
will be cleared (see DocumentThreadableLoader::redirectReceived()). In this
case, we should stop handling the request.

No new tests because existing tests (like http:/tests/xmlhttprequest/redirect-cross
-origin-tripmine.html) can cover this.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::startNewJobWithRequest):

17:51 Changeset [107020] by gyuyoung.kim@samsung.com

[CMAKE] Use *bin* and *lib* directories for executable and libraries.
https://bugs.webkit.org/show_bug.cgi?id=77928

Reviewed by Daniel Bates.

CMake has used *Programs* directory for executable. In addition, shared libraries are being
built in source directory. It is better to set common places in order to maintain executable
and libraries. *bin* is for executable and *lib* is for library.

.:

  • CMakeLists.txt: Set library output path.
  • Source/cmake/WebKitFS.cmake: Remove *Programs* creation.

Source/JavaScriptCore:

  • shell/CMakeLists.txt: Change *Programs* with *bin*.

Source/WebKit2:

  • CMakeLists.txt:

Tools:

  • DumpRenderTree/efl/CMakeLists.txt:
  • EWebLauncher/CMakeLists.txt:
  • Scripts/run-launcher:
  • Scripts/webkitdirs.pm:

(jscProductDir):

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort._path_to_driver):
(EflPort._path_to_image_diff):

17:49 Changeset [107019] by commit-queue@webkit.org

Remove extraneous MathML code before bug 52444 fix
https://bugs.webkit.org/show_bug.cgi?id=78034

Source/WebCore:

Patch by David Barton <dbarton@mathscribe.com> on 2012-02-07
Reviewed by Eric Seidel.

Per Darin Adler, I am breaking up the patch fixing bug 52444 into smaller pieces.
This patch removes a couple unused functions, some extra blank lines, unused #include
directives, etc., and adds a very few WebKit-standard changes to these files.

No new tests.

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore):

  • rendering/mathml/RenderMathMLBlock.h:

(WebCore::RenderMathMLBlock::getBoxModelObjectHeight):

  • changed to a static member function since 'this' is unused; removed redundant non-const version

(WebCore::RenderMathMLBlock::getBoxModelObjectWidth):

  • changed to a static member function since 'this' is unused; removed redundant non-const version

(WebCore):

  • rendering/mathml/RenderMathMLFraction.cpp:
  • rendering/mathml/RenderMathMLMath.cpp:
  • rendering/mathml/RenderMathMLMath.h:
  • rendering/mathml/RenderMathMLOperator.h:

(WebCore):

  • rendering/mathml/RenderMathMLRoot.cpp:
  • rendering/mathml/RenderMathMLRow.cpp:
  • rendering/mathml/RenderMathMLRow.h:
  • rendering/mathml/RenderMathMLSquareRoot.cpp:
  • rendering/mathml/RenderMathMLSquareRoot.h:
  • rendering/mathml/RenderMathMLSubSup.cpp:
  • rendering/mathml/RenderMathMLSubSup.h:
  • rendering/mathml/RenderMathMLUnderOver.cpp:
  • rendering/mathml/RenderMathMLUnderOver.h:

LayoutTests:

Patch by David Barton <dbarton@mathscribe.com> on 2012-02-07
Reviewed by Eric Seidel.

The rendering of the scrollbar in row-expected.png was flaky, presumably due to a test
environment timing issue, so I removed it.

  • mathml/presentation/row.xhtml:
  • platform/mac/mathml/presentation/row-expected.png:
  • platform/mac/mathml/presentation/row-expected.txt:
17:37 Changeset [107018] by commit-queue@webkit.org

Override expected-failure mac-leopard/media/media-blocked-by-beforeload-expected.txt with copy of expected-success expectation, for chromium-mac-leopard.
https://bugs.webkit.org/show_bug.cgi?id=78030

Unreviewed.

Patch by Ami Fischman <fischman@chromium.org> on 2012-02-07

  • platform/chromium-mac-leopard/media/media-blocked-by-beforeload-expected.txt: Added.
17:28 Changeset [107017] by timothy@apple.com

Initilize the WebPageProxy intrinsicDeviceScaleFactor on creation of the WKView.

If WKView was created and loaded a page with canvas elements before beinging moved
to a window, the canvas elements would be locked in at a pixel ratio of 1. With this
change the WKView will use the main screen's pixel ratio until it moves to a window.

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:contextRef:pageGroupRef:]): Call setIntrinsicDeviceScaleFactor.

17:16 Changeset [107016] by commit-queue@webkit.org

Get rid of Source/autotools/webkit.m4
https://bugs.webkit.org/show_bug.cgi?id=77833

Patch by Priit Laes <plaes@plaes.org> on 2012-02-07
Reviewed by Martin Robinson.

Move checks from webkit.m4 to configure.ac and modernize macros:

. Check for visibility flags after CXX has been defined
. Use PKG_PROG_PKG_CONFIG for pkg-config lookup
. Drop unused LIBFFTW_REQUIRED_VERSION
. Update ICU libs for mingw (bug 77837).
. Require Pango 1.21.0 (as per unicode backend)
. Bump minimum glib version due to g_thread_init changes

  • Source/autotools/webkit.m4: Removed.
  • configure.ac:
17:15 Changeset [107015] by lforschler@apple.com

Versioning.

17:03 Changeset [107014] by commit-queue@webkit.org

[Chromium] REGRESSION(r101854): Causing large amounts of unnecessary repainting.
https://bugs.webkit.org/show_bug.cgi?id=78020

Patch by David Reveman <reveman@chromium.org> on 2012-02-07
Reviewed by James Robinson.

Source/WebCore:

Revert r101854.

This patch is tested by the following unit test:

  • TextureManagerTest.requestTextureExceedingPreferredLimit
  • platform/graphics/chromium/ManagedTexture.cpp:

(WebCore::ManagedTexture::reserve):

  • platform/graphics/chromium/TextureManager.cpp:

(WebCore::TextureManager::requestTexture):

  • platform/graphics/chromium/TextureManager.h:

(TextureManager):

Source/WebKit/chromium:

Update TextureManagerTest.requestTextureExceedingPreferredLimit test.

  • tests/TextureManagerTest.cpp:

(WTF::TextureManagerTest::requestTexture):
(WTF::TEST_F):

17:00 Changeset [107013] by andersca@apple.com

Use the non-fast-scrollable region to detect when we can't do fast scrolling
https://bugs.webkit.org/show_bug.cgi?id=78056
<rdar://problem/10247932>

Reviewed by Sam Weinig.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
Actually set the non-fast scrollable region on the scrolling tree state.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::tryToHandleWheelEvent):
Check if the wheel event's position is inside the non-fast-scrollable region
and return false if it is.

(WebCore::ScrollingTree::updateMainFrameScrollPosition):
Store the cached main frame scroll position so we can use it in tryToHandleWheelEvent.

  • platform/graphics/Region.cpp:
  • platform/graphics/Region.h:

Add a simple contains(const IntPoint&) member function.

16:59 Changeset [107012] by mitz@apple.com

<rdar://problem/10475450> Synthetic bold is illegible under some scaling transforms
https://bugs.webkit.org/show_bug.cgi?id=78044

Reviewed by Beth Dakin.

Source/WebCore:

Tests: fast/text/synthetic-bold-transformed-expected.html

fast/text/synthetic-bold-transformed.html

  • platform/graphics/mac/FontMac.mm:

(WebCore::Font::drawGlyphs): Changed to interpret syntheticBoldOffset as a length in device pixels.

LayoutTests:

  • fast/text/synthetic-bold-transformed-expected.html: Added.
  • fast/text/synthetic-bold-transformed.html: Added.
16:58 Changeset [107011] by lforschler@apple.com

New tag.

16:55 Changeset [107010] by commit-queue@webkit.org

[EFL] Add missing initialization of editable variable.
https://bugs.webkit.org/show_bug.cgi?id=77948

Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-02-07
Reviewed by Eric Seidel.

The value of editable in Ewk_Frame_Smart_Data struct is not set.

  • ewk/ewk_frame.cpp:

(ewk_frame_editable_set):

16:52 Changeset [107009] by leviw@chromium.org

Update LayoutUnit usage in ColumnInfo and RenderFrameSet
https://bugs.webkit.org/show_bug.cgi?id=77914

Reviewed by Eric Seidel.

Updating ColumnInfo and RenderFrameSet to use LayoutUnits
instead of directly referencing integers for locations and
distances.

No new tests. No changed behavior.

  • rendering/ColumnInfo.h:

(WebCore::ColumnInfo::forcedBreakOffset):
(WebCore::ColumnInfo::maximumDistanceBetweenForcedBreaks):
(ColumnInfo):

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::paintColumnBorder):
(WebCore::RenderFrameSet::paintRowBorder):

  • rendering/RenderFrameSet.h:

(RenderFrameSet):

16:40 Changeset [107008] by adamk@chromium.org

Add JSC support for delivering mutations when the outermost script context exits
https://bugs.webkit.org/show_bug.cgi?id=70289

Reviewed by Eric Seidel.

Source/WebCore:

The meat of this change is in JSMainThreadExecState, where a counter
is incremented every time WebCore calls into JSC and decremented every
time it returns. When the counter reaches zero, any pending mutations
are delivered (this mirrors very similar code in V8Proxy and V8RecursionScope).

The rest of the changes are of two sorts: compilation/logic fixes for
JSC code when ENABLE(MUTATION_OBSERVERS) is true, and additional
usages of JSMainThreadExecState so as to trigger the above
increment/decrements at the appropriate times.

  • bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
Use JSMainThreadExecState instead of JSC::call.

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue): Add support
for tryGetProperty with a HashMap<AtomicString>.

  • bindings/js/JSDictionary.h:
  • bindings/js/JSErrorHandler.cpp:

(WebCore::JSErrorHandler::handleEvent):
Use JSMainThreadExecState instead of JSC::call.

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::open):
Use JSMainThreadExecState instead of JSC::call.

  • bindings/js/JSMainThreadExecState.cpp:

(WebCore::JSMainThreadExecState::didLeaveScriptContext):

  • bindings/js/JSMainThreadExecState.h:

(WebCore::JSMainThreadExecState::JSMainThreadExecState):
Increment a static recursion level counter.
(WebCore::JSMainThreadExecState::~JSMainThreadExecState):
Decrement a static recursion level counter and, if we are
at zero (the outermost script invocation), deliver any
outstanding mutation records.

  • bindings/js/JSNodeFilterCondition.cpp:

(WebCore::JSNodeFilterCondition::acceptNode):
Use JSMainThreadExecState instead of JSC::call.

  • bindings/js/JSWebKitMutationObserverCustom.cpp:

(WebCore::JSWebKitMutationObserver::observe):
Fix JSDictionary logic, add support for attributeFilter.

Tools:

  • DumpRenderTree/mac/EventSendingController.mm: Add support for

eventSender.scheduleAsynchronousKeyDown.
(+[EventSendingController isSelectorExcludedFromWebScript:]):
(+[EventSendingController webScriptNameForSelector:]):
(-[EventSendingController keyDownWrapper:withModifiers:withLocation:]):
(-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]):

  • Scripts/build-webkit: Properly alphabetize --mutation-observers in the --help output.

LayoutTests:

With the various fixes in this change, 8/10 tests in fast/mutation
pass under WebKit/Mac. Of the failing tests, only one is due to
a deficiency in the Mac port's code (end-of-task-delivery.html);
the other is due to lack of support for a feature (FILE_SYSTEM)
exercised by the test (non-event-delivery.html).

  • fast/mutation/non-event-delivery.html: Made it fail fast if FileSystem support isn't available.
  • fast/mutation/observe-attributes.html: Fixed calls to removeEventListener.
  • fast/mutation/observe-characterdata.html: ditto.
16:26 Changeset [107007] by lforschler@apple.com

Merged r106982.

16:17 Changeset [107006] by andersca@apple.com

Fix build.

  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::scrollableAreaBoundingBox):

16:14 Changeset [107005] by leviw@chromium.org

[SVG] Use element disappears after scripted change
https://bugs.webkit.org/show_bug.cgi?id=74392

Reviewed by Eric Seidel.

Source/WebCore:

Solution uncovered by Nikolas Zimmermann. Removing an early return that caused
SVGUseElements to not update the shadow root's style, and therefor not render
correctly.

Test: svg/custom/use-disappears-after-style-update.svg

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::didRecalcStyle):

LayoutTests:

  • platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.png: Added.
  • platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.txt: Added.
  • svg/custom/use-disappears-after-style-update.svg: Added.
16:00 Changeset [107004] by haraken@chromium.org

Rename [v8OnProto] IDL attribute to [V8OnProto] IDL attribute
https://bugs.webkit.org/show_bug.cgi?id=77973

Reviewed by Adam Barth.

This patch renames [v8OnProto] to [V8OnProto], since V8 specific IDL
attributes should be prefixed by "V8".

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):

15:58 Changeset [107003] by lforschler@apple.com

Merge patch for 78045.

15:53 Changeset [107002] by jer.noble@apple.com

media/audio-data-url.html test broken on Lion
https://bugs.webkit.org/show_bug.cgi?id=69779

Reviewed by Eric Carlson.

Do not use "OpenForPlayback" attribute on data:// urls, as CoreMedia/QuickTime X cannot
handle those URLs.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::createQTMovie):

15:47 Changeset [107001] by andersca@apple.com

Scrolling tree should keep track of region we can't do fast scrolling for
https://bugs.webkit.org/show_bug.cgi?id=78050

Reviewed by Dan Bernstein.

We currently won't do fast scrolling for subframes and other types of scrollable areas.
Because of this, we'll have the scrolling tree keep a region of the page for which we can't
do fast scrolling. This region will be updated after layout.

  • page/FrameView.cpp:

(WebCore::FrameView::scrollableAreaBoundingBox):
Return the bounding box.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
Go through all the scrollable areas in this frame view and compute the region which we can't do
fast scrolling for.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::commitNewTreeState):
Update the non-fast-scrollable region.

  • page/scrolling/ScrollingTreeState.cpp:

(WebCore::ScrollingTreeState::setNonFastScrollableRegion):
Set the non-fast-scrollable region if it's changed.

  • platform/ScrollableArea.h:

Add scrollableAreaBoundingBox member function.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollableAreaBoundingBox):
Return the bounding box.

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::scrollableAreaBoundingBox):
Return the bounding box.

15:46 Changeset [107000] by leviw@chromium.org

unicode-bidi:plaintext is supposed to be effective on display:inline elements too
https://bugs.webkit.org/show_bug.cgi?id=73310

Reviewed by Eric Seidel.

Source/WebCore:

Adding support for unicode-bidi: plaintext as a property on inlines. These are treated
like unicode-bidi: isolate with the addition of their directionality being determined
by the UBA.

Tests: fast/text/international/inline-plaintext-is-isolated-expected.html

fast/text/international/inline-plaintext-is-isolated.html
fast/text/international/inline-plaintext-relayout-with-leading-neutrals-expected.html
fast/text/international/inline-plaintext-relayout-with-leading-neutrals.html
fast/text/international/inline-plaintext-with-generated-content-expected.html
fast/text/international/inline-plaintext-with-generated-content.html

  • platform/text/UnicodeBidi.h:

(WebCore::isIsolated): Added this convenience function as Plaintext and Isolate Unicode-Bidi values
are both treated as isolated content.

  • rendering/InlineIterator.h:

(WebCore::notifyObserverEnteredObject): Inline now supports Unicode-Bidi Plaintext.
(WebCore::notifyObserverWillExitObject): Ditto.
(WebCore::bidiFirstSkippingEmptyInlines): Changed to support being called without a resolver.
(WebCore::isIsolatedInline): Inline now supports Unicode-Bidi: Plaintext.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::determineDirectionality): Generalized for inlines.
(WebCore::constructBidiRuns): Added support for Unicode-Bidi: Plaintext as an isolated inline.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Fixed comment.
(WebCore::RenderBlock::determineStartPosition): Fixed comment and switched to updated
bidiFirstSkippingEmptyInlines.

LayoutTests:

Ref tests for unicode-bidi: plaintext on inlines.

  • fast/text/international/inline-plaintext-is-isolated-expected.html: Added.
  • fast/text/international/inline-plaintext-is-isolated.html: Added.
  • fast/text/international/inline-plaintext-relayout-with-leading-neutrals-expected.html: Added.
  • fast/text/international/inline-plaintext-relayout-with-leading-neutrals.html: Added.
  • fast/text/international/inline-plaintext-with-generated-content-expected.html: Added.
  • fast/text/international/inline-plaintext-with-generated-content.html: Added.
15:43 Changeset [106999] by barraclough@apple.com

Crash on http://www.rickshawbags.com/
https://bugs.webkit.org/show_bug.cgi?id=78045

Reviewed by Darin Adler.

Problem URL is: http://www.rickshawbags.com/customize/custom-bag#!thl=rickshaw/bag()

This is a bug introduced by https://bugs.webkit.org/show_bug.cgi?id=71933,
isVariableObject() checks were excluding StaticScopeObjects, this patch
inadvertently changed them to be included.

  • runtime/JSType.h:
    • sort JSType enum such that StaticScopeObjectType comes before VariableObjectType, and thus is excluded from isVariableObject() checks.
15:38 Changeset [106998] by haraken@chromium.org

[Refactoring] Use the [IsWorkerContext] IDL in CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=77957

Reviewed by Adam Barth.

This patch replaces IsSubType("WorkerContext") and something equivalent that
with the [IsWorkerContext] IDL.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GetInternalFields):
(GenerateConstructorGetter):
(GenerateImplementation):

15:29 Changeset [106997] by commit-queue@webkit.org

[Chromium] Crash when using per-tile painting on Windows.
https://bugs.webkit.org/show_bug.cgi?id=75715

Patch by David Reveman <reveman@chromium.org> on 2012-02-07
Reviewed by James Robinson.

PlatformCanvas constructor on win32 expects forth argument to be a
shared section handle. Passing a pointer to a system memory causes
it to crash. Fix this by not using the PlatformCanvas API for
SkCanvas construction in per-tile texture uploader.

Tested with manual tests.

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::prepareRect):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::updateRect):

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:

(Texture):

15:12 Changeset [106996] by jer.noble@apple.com

Unreviewed build fix; make OSStatus the explicit return type for CMTimebase functions.

  • platform/mac/PlatformClockCM.mm:
15:07 Changeset [106995] by jchaffraix@webkit.org

Unreviewed gardening after r106982.

  • platform/chromium/test_expectations.txt:

We don't have at least one of the layoutTestController
functions used in this test so we are receiving an
exception and timing out.

15:03 Changeset [106994] by commit-queue@webkit.org

[chromium] Unit test for bug #77996
https://bugs.webkit.org/show_bug.cgi?id=78019

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-07
Reviewed by James Robinson.

  • tests/CCLayerTreeHostTest.cpp:

(CCLayerTreeHostTestManySurfaces):
(WTF::CCLayerTreeHostTestManySurfaces::CCLayerTreeHostTestManySurfaces):
(WTF::CCLayerTreeHostTestManySurfaces::beginTest):
(WTF::CCLayerTreeHostTestManySurfaces::afterTest):
(WTF):

14:52 Changeset [106993] by commit-queue@webkit.org

[BlackBerry] Upstream DumpRenderTreeSupport
https://bugs.webkit.org/show_bug.cgi?id=77991

Patch by Rob Buis <rbuis@rim.com> on 2012-02-07
Reviewed by Antonio Gomes.

No functionalities changed, no new tests.

  • blackberry/WebKitSupport/DumpRenderTreeSupport.cpp: Added.

(toGeolocationClientMock):
(DumpRenderTreeSupport::DumpRenderTreeSupport):
(DumpRenderTreeSupport::~DumpRenderTreeSupport):
(DumpRenderTreeSupport::javaScriptObjectsCount):
(DumpRenderTreeSupport::garbageCollectorCollect):
(DumpRenderTreeSupport::garbageCollectorCollectOnAlternateThread):
(DumpRenderTreeSupport::setLinksIncludedInFocusChain):
(DumpRenderTreeSupport::linksIncludedInFocusChain):
(DumpRenderTreeSupport::dumpConfigurationForViewport):
(DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests):
(DumpRenderTreeSupport::resetGeolocationMock):
(DumpRenderTreeSupport::setMockGeolocationError):
(DumpRenderTreeSupport::setMockGeolocationPermission):
(DumpRenderTreeSupport::setMockGeolocationPosition):
(DumpRenderTreeSupport::scalePageBy):
(DumpRenderTreeSupport::computedStyleIncludingVisitedInfo):

  • blackberry/WebKitSupport/DumpRenderTreeSupport.h: Added.

(WebKit):
(WebCore):
(WTF):
(DumpRenderTreeSupport):

14:20 Changeset [106992] by jamesr@google.com

[chromium] Allow retaining texture across frames in composited video playback and correctly handle lost context
https://bugs.webkit.org/show_bug.cgi?id=77923

Reviewed by Kenneth Russell.

Thanks to r106840, we can improve the video playback mode a bit. Instead of creating a new texture on every
frame, this attempts to reuse the texture from the previous frame unless the context is lost. Also improves
error checking in case the TextureManager cannot successfully reserve memory for the texture.

Tested manually by killing the GPU process with an html5 video playing and verifying that the video playback
continues and that we don't create a new set of textures for each plane on each frame.

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::draw):
(WebCore::CCVideoLayerImpl::reserveTextures):

14:18 Changeset [106991] by commit-queue@webkit.org

IndexedDB createIndex should fail if options arg is invalid
https://bugs.webkit.org/show_bug.cgi?id=58467

Patch by Eugene Girard <girard@chromium.org> on 2012-02-07
Reviewed by Tony Chang.

This ticket was fixed as part of https://bugs.webkit.org/show_bug.cgi?id=58471
Adding unit tests to verify correct operation.

  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics-workers-expected.txt:
  • storage/indexeddb/resources/index-basics.js:

(deleteExisting):

14:08 Changeset [106990] by jchaffraix@webkit.org

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:

Mark those 2 tests as crashing in Debug as they seem
to be hitting an ASSERT.

14:02 Changeset [106989] by ossy@webkit.org

[Qt] Unreviewed gardening, paint the bots green.

  • platform/qt/Skipped: Skip failing/crashing tests, because we like regressions in trunk.
13:52 Changeset [106988] by mdelaney@apple.com

https://bugs.webkit.org/show_bug.cgi?id=77912
Removing old CG shadow code.

A CG-specific shadow offset hack was added in http://trac.webkit.org/changeset/34317
for this particular setShadow method. However, this shadow offset adjustment for CG
has since moved down into platform specific code. Thus, this offset adjustment here
is now redundant.

The CG-only shadow setting code block in this setShadow method is now redundant.
Since it sets the shadow values to the CGContext directly - and not to the State object -
it will be overwritten later by any subsequent calls to setting shadow values such as
blur, offset, or shadow color.

Reviewed by Simon Fraser.

No new tests. Current canvas tests cover this path.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setShadow):

13:52 Changeset [106987] by commit-queue@webkit.org

Process Scroll-gesture events from the compositor.
https://bugs.webkit.org/show_bug.cgi?id=77477

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-02-07
Reviewed by James Robinson.

  • src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::WebCompositorInputHandlerImpl):
(WebKit::WebCompositorInputHandlerImpl::handleInputEvent):

  • src/WebCompositorInputHandlerImpl.h:

(WebCompositorInputHandlerImpl):

13:50 Changeset [106986] by jamesr@google.com

[chromium] Gracefully handle compositor initialization failure in single-threaded proxy
https://bugs.webkit.org/show_bug.cgi?id=78013

Reviewed by Kenneth Russell.

If compositor initialization fails it's not safe to proceed through the rest of the frame process. This adds
some early outs.

Tested manually by forcing the first makeContextCurrent() call fail.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::updateLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::compositeAndReadback):
(WebCore::CCSingleThreadProxy::compositeImmediately):
(WebCore::CCSingleThreadProxy::commitIfNeeded):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(CCSingleThreadProxy):

13:48 Changeset [106985] by ap@apple.com

Keep a reference in didReceiveInvalidMessage.
https://bugs.webkit.org/show_bug.cgi?id=78024

Reviewed by Anders Carlsson.

  • UIProcess/WebConnectionToWebProcess.cpp: (WebKit::WebConnectionToWebProcess::didReceiveInvalidMessage):
13:46 Changeset [106984] by crogers@google.com

Add Chris Rogers to reviewers section
https://bugs.webkit.org/show_bug.cgi?id=78016

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/config/committers.py:
13:37 Changeset [106983] by zimmermann@webkit.org

layoutTestController.display() is flaky for SVG tests
https://bugs.webkit.org/show_bug.cgi?id=78021

Reviewed by Dan Bernstein.

Fix race condition in repaint rect tracking. When running a test using the repaint.js
harness right after a test starting with "svg/W3C-SVG-1.1" the repaint test will fail,
the gray overlay isn't contained in the pixel dump anymore. This is because of a specific
hack that forces 480x360 instead of 800x600 pixel test dumps for any test starting with
svg/W3C-SVG-1.1. The resizing of the web view was done when dumping the render tree, after
the repaint test already run, thus invalidating the previously tracked repaint rects.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(dump):
(runTest):

13:37 Changeset [106982] by beidson@apple.com

<rdar://problem/9567286> and https://bugs.webkit.org/show_bug.cgi?id=78003 WebKit associates credentials with the wrong site if the authentication challenge takes place after a redirect chain

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials.html

Associate the credential with the URL of the challenge itself, not the original request:

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::receivedCredential):

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::receivedCredential):

LayoutTests:

  • http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials-expected.txt: Added.
  • http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials.html: Added.
  • http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-1-redirect-to-auth.php: Added.
  • http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-2-auth-then-redirect-to-finish.php: Added.
  • http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-3-output-credentials-then-finish.php: Added.
13:24 Changeset [106981] by jchaffraix@webkit.org

Revert r106958.

  • platform/chromium/test_expectations.txt:

It was a mistake as the test is really flaky not slow,
so now it is taking way longer to fail (see http://webkit.org/b/77997).

13:22 Changeset [106980] by tony@chromium.org

move warning about css values and render style constants closer to where it applies
https://bugs.webkit.org/show_bug.cgi?id=78017

Reviewed by Darin Adler.

Move the warning about keeping RenderStyleConstnats.h enums and
CSSValueKeywords.in values in the same order closer to the properties
that the warning applies to. The warning was easy to miss and was
confusing since it doesn't apply to most values.

Also refactor 2 conversion functions to
enumerate the possible values so the order doesn't matter.

No new tests, just refactoring and comment cleanup.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::operator EListStylePosition): Name all possible values and add a NOT_REACHED().
(WebCore::CSSPrimitiveValue::operator EUserModify): Name all possible values and add a NOT_REACHED().

  • css/CSSValueKeywords.in:
  • css/SVGCSSPropertyNames.in:
  • css/SVGCSSValueKeywords.in:
  • rendering/style/RenderStyleConstants.h:
13:06 Changeset [106979] by eae@chromium.org

Various build fixes for branch

12:48 Changeset [106978] by jer.noble@apple.com

Use CMClock as a timing source for PlatformClock where available.
https://bugs.webkit.org/show_bug.cgi?id=77885

Reviewed by Eric Carlson.

Source/JavaScriptCore:

  • wtf/Platform.h: Added WTF_USE_COREMEDIA.

Source/WebCore:

No new tests; performance improvement covered by existing test cases.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/Clock.cpp:

(Clock::create): Use PlatformClockCM if available.

  • platform/mac/PlatformClockCM.h: Added.

(WebCore::PlatformClockCM::playRate):
(WebCore::PlatformClockCM::isRunning):

  • platform/mac/PlatformClockCM.mm: Added.

(PlatformClockCM::PlatformClockCM):
(PlatformClockCM::initializeWithTimingSource):
(PlatformClockCM::setCurrentTime):
(PlatformClockCM::currentTime):
(PlatformClockCM::setPlayRate):
(PlatformClockCM::start):
(PlatformClockCM::stop):

12:45 Changeset [106977] by andersca@apple.com

ScrollableAreaSet should be moved from Page to FrameView
https://bugs.webkit.org/show_bug.cgi?id=62762

Reviewed by Beth Dakin.

Source/WebCore:

It makes more sense for the set of scrollable areas to be per frame view instead of per page;
scrollable areas are associated with a containing frame view and their lifecycle follows the lifecycle of the
frame view much more closely. This could even fix a bunch of crashes where a scrollable area outlived its containing page.

  • WebCore.exp.in:

Replace the Page member functions with FrameView member functions instead.

  • page/EventHandler.cpp:

(WebCore::EventHandler::mouseMoved):
Check if the frame view contains the given layer.

(WebCore::EventHandler::updateMouseEventTargetNode):
Ditto.

  • page/FocusController.cpp:

(WebCore::contentAreaDidShowOrHide):
Add helper function.

(WebCore::FocusController::setContainingWindowIsVisible):
Call contentAreaDidShowOrHide for the main frame view, and for all scrollable areas
inside all subframe views.

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
Use early returns to make the code more clear. Also, don't add the scrollable area to the set here.

(WebCore::FrameView::~FrameView):
Don't remove the scrollable area here.

(WebCore::FrameView::zoomAnimatorTransformChanged):
m_page is gone so use m_frame->page() instead.

(WebCore::FrameView::setAnimatorsAreActive):
Call ScrollAnimator::setIsActive for all the scrollable areas in this frame view. Previously we used to do
this for all scrollable areas on the page, but since setAnimatorsAreActive will be called for each document,
this will be done implicitly.

(WebCore::FrameView::notifyPageThatContentAreaWillPaint):
Call ScrollableArea::contentDidPaint for this frame view and all its immediate scrollable areas. Previously, we used
to do this for all scrollable areas on the page, but we only need to do it for this frame view.

(WebCore::FrameView::scrollAnimatorEnabled):
Get the page from m_frame since m_page is gone.

(WebCore::FrameView::addScrollableArea):
(WebCore::FrameView::removeScrollableArea):
(WebCore::FrameView::containsScrollableArea):
Move these member functions here from Page.

(WebCore::FrameView::addChild):
If we are adding a frame view, add it to the scrollable area set.

(WebCore::FrameView::removeChild):
If we are removing a frame view, remove it from the scrollable area set.

  • page/FrameView.h:

Move the member function declarations and the scrollable area set member variable here from Page.

  • page/Page.cpp:

(WebCore::Page::~Page):
Don't call disconnectPage on the scrollable areas anymore.

  • platform/ScrollView.h:

(ScrollView):
Make addChild and removeChild virtual.

  • platform/ScrollableArea.h:

Remove disconnectFromPage.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::~RenderLayer):
(WebCore::RenderLayer::styleChanged):
The frame view now keeps track of the scrollable areas.

  • rendering/RenderLayer.h:

Remove the page member variable and disconnectFromPage.

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::RenderListBox):
(WebCore::RenderListBox::~RenderListBox):
The frame view now keeps track of the scrollable areas.

  • rendering/RenderListBox.h:

Remove the page member variable and disconnectFromPage.

Source/WebKit/chromium:

Update for changes to WebCore now that the scrollable area set is kept per frame view.

  • src/ScrollbarGroup.cpp:

(WebKit::ScrollbarGroup::ScrollbarGroup):
(WebKit::ScrollbarGroup::~ScrollbarGroup):

  • src/ScrollbarGroup.h:

(WebCore):
(ScrollbarGroup):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::scrollbarGroup):

Source/WebKit2:

  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp:

(WebKit::BuiltInPDFView::initialize):
Call FrameView::addScrollableArea instead.

(WebKit::BuiltInPDFView::destroy):
Call FrameView::removeScrollableArea instead.

  • WebProcess/Plugins/PDF/BuiltInPDFView.h:

Remove disconnectFromPage since it no longer exists on ScrollableArea.

12:40 Changeset [106976] by commit-queue@webkit.org

[BlackBerry] Upstream BlackBerry WebCoreSupport DeviceOrientationClientBlackBerry and DeviceMotionClientBlackBerry classes
https://bugs.webkit.org/show_bug.cgi?id=77993

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-02-07
Reviewed by Rob Buis.

Initial upstream, no new tests.

  • blackberry/WebCoreSupport/DeviceMotionClientBlackBerry.cpp: Added.
  • blackberry/WebCoreSupport/DeviceMotionClientBlackBerry.h: Added.
  • blackberry/WebCoreSupport/DeviceOrientationClientBlackBerry.cpp: Added.
  • blackberry/WebCoreSupport/DeviceOrientationClientBlackBerry.h: Added.
12:28 Changeset [106975] by jchaffraix@webkit.org

Unreviewed gardening.

  • platform/chromium-linux/fast/forms/tabbing-input-iframe-expected.png:
  • platform/chromium-win/fast/events/frame-tab-focus-expected.txt: Removed.
  • platform/chromium/fast/events/frame-tab-focus-expected.txt: Added.
  • platform/chromium/test_expectations.txt:

Rebaseline some old entries in test_expectations.

12:16 Changeset [106974] by commit-queue@webkit.org

createImpulseBuffer uses incorrect length
https://bugs.webkit.org/show_bug.cgi?id=77665

Patch by Raymond Toy <rtoy@google.com> on 2012-02-07
Reviewed by Kenneth Russell.

  • webaudio/resources/audio-testing.js:

(createImpulseBuffer): Fix bug so the buffer has the correct
length.

12:04 Changeset [106973] by mdelaney@apple.com

Remove redundant checks in CanvasRenderingContext2D.cpp
https://bugs.webkit.org/show_bug.cgi?id=78000

Reviewed by Dan Bernstein.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setShadowColor):
(WebCore::CanvasRenderingContext2D::setShadow):
(WebCore::CanvasRenderingContext2D::drawImage):

12:01 Changeset [106972] by inferno@chromium.org

Crash in ContainerNode functions due to mutation events.
https://bugs.webkit.org/show_bug.cgi?id=77999

Reviewed by Ryosuke Niwa.

Source/WebCore:

Add RefPtr to protect premature deletion of this due to mutation events.

Tests: fast/dom/remove-body-during-body-replacement.html

fast/dom/remove-body-during-body-replacement2.html

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::appendChild):

LayoutTests:

  • fast/dom/remove-body-during-body-replacement-expected.txt: Added.
  • fast/dom/remove-body-during-body-replacement.html: Added.
  • fast/dom/remove-body-during-body-replacement2-expected.txt: Added.
  • fast/dom/remove-body-during-body-replacement2.html: Added.
11:59 Changeset [106971] by jsbell@chromium.org

[Chromium] storage/indexeddb/index-cursor.html timeouts on Mac Debug
https://bugs.webkit.org/show_bug.cgi?id=65862

Unreviewed test expectations change. Removed this expectation in r106857
but it's still timing out so restoring it for now.

  • platform/chromium/test_expectations.txt:
11:50 Changeset [106970] by eae@chromium.org

Merging trunk changes up until 106956 into subpixel branch.

11:46 Changeset [106969] by commit-queue@webkit.org

[Chromium] Memory bug during occlusion tracking if Vector::append() needs to reallocate the buffer
https://bugs.webkit.org/show_bug.cgi?id=77996

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-07
Reviewed by James Robinson.

We're holding onto the last element in the Vector and then calling
append(). If append() reallocates the Vector's buffer, the pointer
is no longer valid.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::enterTargetRenderSurface):

11:37 Changeset [106968] by inferno@chromium.org

Source/WebCore: Crash due to column style not updated on post block
in splitInlines.
https://bugs.webkit.org/show_bug.cgi?id=77939

Reviewed by Julien Chaffraix.

Test: fast/multicol/span/split-inline-wrong-post-block-crash.html

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::splitFlow):

LayoutTests: Crash due to column style not updated on post block
in splitInlines.
https://bugs.webkit.org/show_bug.cgi?id=77939

Reviewed by Julien Chaffraix.

  • fast/multicol/span/split-inline-wrong-post-block-crash-expected.txt: Added.
  • fast/multicol/span/split-inline-wrong-post-block-crash.html: Added.
11:34 Changeset [106967] by jchaffraix@webkit.org

Unreviewed gardening.

  • platform/chromium-mac-snowleopard/svg/carto.net/window-expected.txt: Removed.
  • platform/chromium/test_expectations.txt: Added a TEXT output to a test as seen

on the bots.

11:30 Changeset [106966] by commit-queue@webkit.org

[chromium] re-enable fast/repaint/block-selection-gap-in-composited-layer for win/mac
https://bugs.webkit.org/show_bug.cgi?id=77896

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-07
Reviewed by Kenneth Russell.

  • platform/chromium/test_expectations.txt:
11:26 Changeset [106965] by hans@chromium.org

Chromium: remove WebSpeechInputResult::set
https://bugs.webkit.org/show_bug.cgi?id=77977

Reviewed by Darin Fisher.

It was renamed to assign() in r106475.

Source/WebKit/chromium:

  • public/WebSpeechInputResult.h:

Tools:

  • DumpRenderTree/chromium/MockWebSpeechInputController.cpp:

(makeRectResult):

11:18 Changeset [106964] by dino@apple.com

Apple/Safari: Enable WebGL multisampling on ATI cards
for OS X 10.7.2 and above.
https://bugs.webkit.org/show_bug.cgi?id=77922

Address review comments by Alexey Proskuryakov and Mark Rowe.

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::systemAllowsMultisamplingOnATICards):

11:18 Changeset [106963] by mikelawther@chromium.org

composited mask test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=76006

Reviewed by Ojan Vafai.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

  • css3/calc/resources/alpha-gradient.png: Added.
  • css3/calc/simple-composited-mask-expected-mismatch.html: Added.
  • css3/calc/simple-composited-mask.html: Added.
11:03 Changeset [106962] by commit-queue@webkit.org

[Chromium] media/track/track-cue-nothing-to-render.html fails intermittently on Mac
https://bugs.webkit.org/show_bug.cgi?id=75132

Unreviewed, chromium expectations update.
Fixed with http://crrev.com/120714.

Patch by Ami Fischman <fischman@chromium.org> on 2012-02-07

  • platform/chromium/test_expectations.txt:
10:57 Changeset [106961] by carlosgc@webkit.org

[GTK] Add cut, copy and paste methods to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=76998

Reviewed by Martin Robinson.

  • GNUmakefile.am: Add WebKitEditingCommands.h.
  • UIProcess/API/gtk/WebKitEditingCommands.h: Added.
  • UIProcess/API/gtk/WebKitWebView.cpp:

(didValidateCommand): Callback called by the C API when an editor
command has been validated.
(webkit_web_view_can_execute_editing_command): Asynchronously
validate the given editing command.
(webkit_web_view_can_execute_editing_command_finish): Finish async
operation started by webkit_web_view_can_execute_editing_command().
(webkit_web_view_execute_editing_command): Execute the given
command.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
  • UIProcess/API/gtk/tests/GNUmakefile.am:
  • UIProcess/API/gtk/tests/LoadTrackingTest.cpp:

(LoadTrackingTest::provisionalLoadFailed): Do not finish the main
loop on load failure, now finished is always called.

  • UIProcess/API/gtk/tests/TestBackForwardList.cpp: Use WebViewTest

instead of LoadTrackingTest.

  • UIProcess/API/gtk/tests/TestWebViewEditor.cpp: Added.

(testWebViewEditorCutCopyPasteNonEditable):
(testWebViewEditorCutCopyPasteEditable):
(beforeAll):
(afterAll):

  • UIProcess/API/gtk/tests/WebViewTest.cpp:

(loadChanged):
(WebViewTest::waitUntilLoadFinished): Run a main loop until load
finished.

  • UIProcess/API/gtk/tests/WebViewTest.h: Add waitUntilLoadFinished().
  • UIProcess/API/gtk/webkit2.h: Include WebKitEditingCommands.h.
10:55 WebKitGTK/1.6.x edited by mrobinson@webkit.org
(diff)
10:54 Changeset [106960] by rniwa@webkit.org

Dashboard on perf-o-matic should be sorted
https://bugs.webkit.org/show_bug.cgi?id=77924

Reviewed by Tony Chang.

Sort tests in the frontend using the fact ES5 keeps the property order in the insertion order.

  • Websites/webkit-perf.appspot.com/js/config.js:

(fetchDashboardManifest):

10:49 Changeset [106959] by commit-queue@webkit.org

Unreviewed, chromium expectations update.
[Chromium] Layout Test media/media-blocked-by-beforeload.html fails for LEOPARD
https://bugs.webkit.org/show_bug.cgi?id=77412

Fixed with http://crrev.com/120714.

Patch by Ami Fischman <fischman@chromium.org> on 2012-02-07

  • platform/chromium/test_expectations.txt:
09:45 Changeset [106958] by jchaffraix@webkit.org

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:

Mark an SVG test as SLOW.

09:38 Changeset [106957] by vsevik@chromium.org

Web Inspector: CodeGeneratorInspector.py: extend Array validator functionality
https://bugs.webkit.org/show_bug.cgi?id=77919

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-07
Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-07
Reviewed by Yury Semikhatsky.

Array validator method runtimeCast is added, internal backing method
is moved from .cpp to .h (it's template anyway), boolean validator is
supported.

  • inspector/CodeGeneratorInspector.py:

(RawTypes.Bool.get_validate_method_params.ValidateMethodParams):
(RawTypes.Bool.get_validate_method_params):
(TypeBuilder):

09:34 Changeset [106956] by dino@apple.com

Apple/Safari: Enable WebGL multisampling on ATI cards
for OS X 10.7.2 and above.
https://bugs.webkit.org/show_bug.cgi?id=77922

Reviewed by Chris Marrin.

Follow Chrome's lead to allow WebGL antialiasing
on ATI cards as long as we're on 10.7.2 and above.

No new tests. Covered by existing tests.

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::systemAllowsMultisamplingOnATICards):
(WebCore):
(WebCore::GraphicsContext3D::validateAttributes):

09:21 Changeset [106955] by commit-queue@webkit.org

[Chromium] Layout Test media/controls-drag-timebar.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=77531

No more flakiness.

Patch by Ami Fischman <fischman@chromium.org> on 2012-02-07
Reviewed by Eric Carlson.

  • platform/chromium/test_expectations.txt:
09:19 Changeset [106954] by ossy@webkit.org

[Qt][WK2] Unreviewed gardening.

  • platform/qt-wk2/Skipped: Skip failing tests, because we like regressions in trunk.
09:00 Changeset [106953] by pfeldman@chromium.org

Web Inspector: add generic support for undo-ing DOM edits.
https://bugs.webkit.org/show_bug.cgi?id=77875

Reviewed by Yury Semikhatsky.

Source/WebCore:

This change introduces InspectorHistory::Action that encapsulates all DOM modifications
initiated by the inspector. There is a way to undo these actions up until the undoable
state marker.

Tests: inspector/elements/undo-dom-edits-2.html

inspector/elements/undo-dom-edits.html
inspector/styles/undo-add-property.html
inspector/styles/undo-change-property.html
inspector/styles/undo-property-toggle.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/Inspector.json:
  • inspector/InspectorAllInOne.cpp:
  • inspector/InspectorCSSAgent.cpp:

(InspectorCSSAgent::StyleSheetAction):
(WebCore::InspectorCSSAgent::StyleSheetAction::StyleSheetAction):
(WebCore::InspectorCSSAgent::StyleSheetAction::perform):
(WebCore::InspectorCSSAgent::StyleSheetAction::undo):
(WebCore):
(InspectorCSSAgent::SetStyleSheetTextAction):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::SetStyleSheetTextAction):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::perform):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::undo):
(InspectorCSSAgent::SetPropertyTextAction):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::SetPropertyTextAction):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::toString):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::perform):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::undo):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::mergeId):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::merge):
(InspectorCSSAgent::TogglePropertyAction):
(WebCore::InspectorCSSAgent::TogglePropertyAction::TogglePropertyAction):
(WebCore::InspectorCSSAgent::TogglePropertyAction::perform):
(WebCore::InspectorCSSAgent::TogglePropertyAction::undo):
(WebCore::InspectorCSSAgent::getStyleSheetText):
(WebCore::InspectorCSSAgent::setStyleSheetText):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/InspectorDOMAgent.cpp:

(InspectorDOMAgent::DOMAction):
(WebCore::InspectorDOMAgent::DOMAction::DOMAction):
(WebCore::InspectorDOMAgent::DOMAction::perform):
(WebCore::InspectorDOMAgent::DOMAction::undo):
(WebCore):
(InspectorDOMAgent::RemoveChildAction):
(WebCore::InspectorDOMAgent::RemoveChildAction::RemoveChildAction):
(WebCore::InspectorDOMAgent::RemoveChildAction::perform):
(WebCore::InspectorDOMAgent::RemoveChildAction::undo):
(InspectorDOMAgent::InsertBeforeAction):
(WebCore::InspectorDOMAgent::InsertBeforeAction::InsertBeforeAction):
(WebCore::InspectorDOMAgent::InsertBeforeAction::perform):
(WebCore::InspectorDOMAgent::InsertBeforeAction::undo):
(InspectorDOMAgent::RemoveAttributeAction):
(WebCore::InspectorDOMAgent::RemoveAttributeAction::RemoveAttributeAction):
(WebCore::InspectorDOMAgent::RemoveAttributeAction::perform):
(WebCore::InspectorDOMAgent::RemoveAttributeAction::undo):
(InspectorDOMAgent::SetAttributeAction):
(WebCore::InspectorDOMAgent::SetAttributeAction::SetAttributeAction):
(WebCore::InspectorDOMAgent::SetAttributeAction::perform):
(WebCore::InspectorDOMAgent::SetAttributeAction::undo):
(InspectorDOMAgent::SetOuterHTMLAction):
(WebCore::InspectorDOMAgent::SetOuterHTMLAction::SetOuterHTMLAction):
(WebCore::InspectorDOMAgent::SetOuterHTMLAction::perform):
(WebCore::InspectorDOMAgent::SetOuterHTMLAction::undo):
(WebCore::InspectorDOMAgent::SetOuterHTMLAction::newNode):
(InspectorDOMAgent::ReplaceWholeTextAction):
(WebCore::InspectorDOMAgent::ReplaceWholeTextAction::ReplaceWholeTextAction):
(WebCore::InspectorDOMAgent::ReplaceWholeTextAction::perform):
(WebCore::InspectorDOMAgent::ReplaceWholeTextAction::undo):
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::reset):
(WebCore::InspectorDOMAgent::setAttributeValue):
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::removeAttribute):
(WebCore::InspectorDOMAgent::removeNode):
(WebCore::InspectorDOMAgent::setNodeName):
(WebCore::InspectorDOMAgent::setOuterHTML):
(WebCore::InspectorDOMAgent::setNodeValue):
(WebCore::InspectorDOMAgent::moveTo):
(WebCore::InspectorDOMAgent::undo):
(WebCore::InspectorDOMAgent::markUndoableState):

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):
(WebCore::InspectorDOMAgent::history):

  • inspector/InspectorHistory.cpp: Added.

(WebCore::InspectorHistory::Action::Action):
(WebCore):
(WebCore::InspectorHistory::Action::~Action):
(WebCore::InspectorHistory::Action::toString):
(WebCore::InspectorHistory::Action::isUndoableStateMark):
(WebCore::InspectorHistory::Action::mergeId):
(WebCore::InspectorHistory::Action::merge):
(WebCore::InspectorHistory::InspectorHistory):
(WebCore::InspectorHistory::~InspectorHistory):
(WebCore::InspectorHistory::perform):
(WebCore::InspectorHistory::markUndoableState):
(WebCore::InspectorHistory::undo):
(WebCore::InspectorHistory::reset):

  • inspector/InspectorHistory.h: Added.

(WebCore):
(InspectorHistory):
(Action):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyle::styleText):
(WebCore::InspectorStyleSheet::addRule):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
(WebCore::InspectorStyleSheet::buildObjectForStyle):
(WebCore::InspectorStyleSheet::setPropertyText):
(WebCore::InspectorStyleSheet::getText):
(WebCore::InspectorStyleSheetForInlineStyle::getText):

  • inspector/InspectorStyleSheet.h:

(InspectorStyle):
(InspectorStyleSheet):
(InspectorStyleSheetForInlineStyle):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSProperty.prototype.setText):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype._selectedNodeChanged):
(WebInspector.ElementsPanel.prototype._updateSidebars):
(WebInspector.ElementsPanel.prototype.handleShortcut):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.prototype.onpopulate):
(WebInspector.StylePropertiesSection.prototype.addNewBlankProperty):
(WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):
(WebInspector.StylePropertyTreeElement):
(WebInspector.StylePropertyTreeElement.prototype):

LayoutTests:

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.rangeText):
(initialize_ElementTest.InspectorTest.generateUndoTest):

  • inspector/elements/undo-dom-edits-2-expected.txt: Added.
  • inspector/elements/undo-dom-edits-2.html: Added.
  • inspector/elements/undo-dom-edits-expected.txt: Added.
  • inspector/elements/undo-dom-edits.html: Added.
  • inspector/styles/undo-add-property-expected.txt: Added.
  • inspector/styles/undo-add-property.html: Added.
  • inspector/styles/undo-change-property-expected.txt: Added.
  • inspector/styles/undo-change-property.html: Added.
  • inspector/styles/undo-property-toggle-expected.txt: Added.
  • inspector/styles/undo-property-toggle.html: Added.
08:55 Changeset [106952] by tonyg@chromium.org

Unreviewed, more svg rebaselines following change in r106918.

  • platform/chromium-linux/svg/text/text-text-05-t-expected.png:
08:43 Changeset [106951] by tonyg@chromium.org

Unreviewed, rolling out r106935.
http://trac.webkit.org/changeset/106935
https://bugs.webkit.org/show_bug.cgi?id=77994

"Crashes runMultiThread webkit_unit_test" (Requested by tonyg-
cr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-07

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::setNeedsRedraw):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::setNeedsRedraw):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::setNeedsRedraw):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

  • public/WebWidget.h:

(WebWidget):

  • src/WebViewImpl.cpp:
  • src/WebViewImpl.h:

(WebViewImpl):

08:28 Changeset [106950] by ossy@webkit.org

[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
https://bugs.webkit.org/show_bug.cgi?id=52810

  • platform/qt/Skipped: Skip one more test because of this bug.
08:18 Changeset [106949] by commit-queue@webkit.org

Encode radius, force and rotationAngle in WebPlatformTouchPoint.
https://bugs.webkit.org/show_bug.cgi?id=77986

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-07
Reviewed by Kenneth Rohde Christiansen.

  • Shared/WebEvent.h:

(WebKit::WebPlatformTouchPoint::WebPlatformTouchPoint):
(WebPlatformTouchPoint):
(WebKit::WebPlatformTouchPoint::radius):
(WebKit::WebPlatformTouchPoint::rotationAngle):
(WebKit::WebPlatformTouchPoint::force):

  • Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformTouchPoint::WebKit2PlatformTouchPoint):

  • Shared/WebPlatformTouchPoint.cpp:

(WebKit::WebPlatformTouchPoint::WebPlatformTouchPoint):
(WebKit::WebPlatformTouchPoint::encode):
(WebKit::WebPlatformTouchPoint::decode):

08:16 Changeset [106948] by ossy@webkit.org

Unreviewed gardening after r106898. Update platform specific expected results

Patch by Ádám Kallai <Kallai.Adam@stud.u-szeged.hu> on 2012-02-07

  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
08:13 Changeset [106947] by commit-queue@webkit.org

Unreviewed, rolling out r106932.
http://trac.webkit.org/changeset/106932
https://bugs.webkit.org/show_bug.cgi?id=77988

Breaks Mac bots (Requested by pfeldman on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-07

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/Inspector.json:
  • inspector/InspectorAllInOne.cpp:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getStyleSheetText):
(WebCore::InspectorCSSAgent::setStyleSheetText):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::reset):
(WebCore::InspectorDOMAgent::setAttributeValue):
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::removeAttribute):
(WebCore::InspectorDOMAgent::removeNode):
(WebCore::InspectorDOMAgent::setNodeName):
(WebCore::InspectorDOMAgent::setOuterHTML):
(WebCore::InspectorDOMAgent::setNodeValue):
(WebCore::InspectorDOMAgent::moveTo):

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

  • inspector/InspectorHistory.cpp: Removed.
  • inspector/InspectorHistory.h: Removed.
  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyle::styleText):
(WebCore::InspectorStyleSheet::addRule):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
(WebCore::InspectorStyleSheet::buildObjectForStyle):
(WebCore::InspectorStyleSheet::setPropertyText):
(WebCore::InspectorStyleSheet::text):
(WebCore::InspectorStyleSheetForInlineStyle::text):

  • inspector/InspectorStyleSheet.h:

(InspectorStyle):
(InspectorStyleSheet):
(InspectorStyleSheetForInlineStyle):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSProperty.prototype.setText):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype._selectedNodeChanged):
(WebInspector.ElementsPanel.prototype.handleShortcut):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.prototype.onpopulate):
(WebInspector.StylePropertiesSection.prototype.addNewBlankProperty):
(WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):
(WebInspector.StylePropertyTreeElement):
(WebInspector.StylePropertyTreeElement.prototype):

LayoutTests:

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.rangeText):

  • inspector/elements/undo-dom-edits-2-expected.txt: Removed.
  • inspector/elements/undo-dom-edits-2.html: Removed.
  • inspector/elements/undo-dom-edits-expected.txt: Removed.
  • inspector/elements/undo-dom-edits.html: Removed.
  • inspector/styles/undo-add-property-expected.txt: Removed.
  • inspector/styles/undo-add-property.html: Removed.
  • inspector/styles/undo-change-property-expected.txt: Removed.
  • inspector/styles/undo-change-property.html: Removed.
  • inspector/styles/undo-property-toggle-expected.txt: Removed.
  • inspector/styles/undo-property-toggle.html: Removed.
08:09 Changeset [106946] by commit-queue@webkit.org

[Qt] Give emulated touch-point a radius
https://bugs.webkit.org/show_bug.cgi?id=77985

Increase the radius of touch-point and show the actual size of the touch point in the touch-point mockup.

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-07
Reviewed by Kenneth Rohde Christiansen.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::updateVisualMockTouchPoints):

  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::notify):

  • MiniBrowser/qt/qml/MockTouchPoint.qml:
08:00 Changeset [106945] by commit-queue@webkit.org

Update .gitignore for Qt Creator/KDevelop.
https://bugs.webkit.org/show_bug.cgi?id=77984

Patch by Frederik Gladhorn <frederik.gladhorn@nokia.com> on 2012-02-07
Reviewed by Simon Hausmann.

  • .gitignore: Ignore temp files created by Qt Creator and KDevelop.
07:55 Changeset [106944] by commit-queue@webkit.org

[GTK] Broken "HTML5 <scoped style>" detection
https://bugs.webkit.org/show_bug.cgi?id=77979

Patch by Priit Laes <plaes@plaes.org> on 2012-02-07
Reviewed by Gustavo Noronha Silva.

  • configure.ac: Fix wrong variable for HTML5 <style scoped> detection
07:54 Changeset [106943] by tonyg@chromium.org

Unreviewed, a couple more chromium rebaselines after r106918.

  • platform/chromium-mac-leopard/svg/hixie/perf/006-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/hixie/perf/006-expected.png: Added.
07:51 Changeset [106942] by tonyg@chromium.org

Unreviewed, more chromium rebaselines as a result of change in r106918.

  • platform/chromium-mac-leopard/svg/carto.net/tabgroup-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dom/SVGPathSegList-segment-modification-expected.png:
  • platform/chromium-mac-leopard/svg/filters/filter-width-update-expected.png:
  • platform/chromium-mac-leopard/svg/hixie/perf/003-expected.png:
  • platform/chromium-mac-leopard/svg/hixie/perf/004-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/hixie/perf/005-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/hixie/perf/007-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/carto.net/tabgroup-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dom/SVGPathSegList-segment-modification-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/filter-width-update-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/perf/003-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/perf/004-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/perf/005-expected.png: Added.
  • platform/chromium-mac/svg/dom/SVGPathSegList-segment-modification-expected.png: Removed.
  • platform/chromium-mac/svg/filters/filter-width-update-expected.png: Removed.
  • platform/mac/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt: Removed.
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Removed.
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Removed.
  • platform/qt/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt: Removed.
  • platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Removed.
  • platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Removed.
  • svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt: Renamed from LayoutTests/platform/gtk/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt.
  • svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Renamed from LayoutTests/platform/gtk/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt.
  • svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Renamed from LayoutTests/platform/gtk/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt.
07:46 Changeset [106941] by commit-queue@webkit.org

[GTK] Build failure with --enable-web-audio
https://bugs.webkit.org/show_bug.cgi?id=77978

Patch by Priit Laes <plaes@plaes.org> on 2012-02-07
Reviewed by Gustavo Noronha Silva.

  • GNUmakefile.list.am: Include AudioSourceProviderClient.h
07:46 Changeset [106940] by tonyg@chromium.org

Unreviewed chromium rebaseline to account for change in r106918.

  • platform/chromium-linux/svg/text/append-text-node-to-tspan-expected.png: Added.
  • platform/chromium-linux/svg/text/remove-text-node-from-tspan-expected.png: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-linux/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
  • platform/chromium-mac-leopard/svg/carto.net/window-expected.png:
  • platform/chromium-mac-leopard/svg/hixie/perf/001-expected.png: Added.
  • platform/chromium-mac-leopard/svg/hixie/perf/002-expected.png: Added.
  • platform/chromium-mac-leopard/svg/text/text-text-05-t-expected.png: Added.
  • platform/chromium-mac-leopard/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/carto.net/window-expected.png:
  • platform/chromium-mac-snowleopard/svg/carto.net/window-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/carto.net/window-expected.txt.
  • platform/chromium-mac-snowleopard/svg/hixie/perf/001-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/perf/001-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.txt.
  • platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.png:
  • platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.txt:
  • platform/chromium-mac-snowleopard/svg/text/text-text-05-t-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-hixie-mixed-008-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/zoom/page/zoom-hixie-mixed-008-expected.png.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png.
  • platform/chromium-mac-snowleopard/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/text/zoom-hixie-mixed-008-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/zoom/text/zoom-hixie-mixed-008-expected.png.
  • platform/chromium-mac-snowleopard/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png.
  • platform/chromium-win/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
  • platform/chromium-win/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
  • platform/chromium-win/svg/carto.net/window-expected.png:
  • platform/chromium-win/svg/carto.net/window-expected.txt:
  • platform/chromium-win/svg/hixie/perf/001-expected.png:
  • platform/chromium-win/svg/hixie/perf/001-expected.txt:
  • platform/chromium-win/svg/hixie/perf/002-expected.png:
  • platform/chromium-win/svg/hixie/perf/002-expected.txt:
  • platform/chromium-win/svg/text/append-text-node-to-tspan-expected.png: Added.
  • platform/chromium-win/svg/text/append-text-node-to-tspan-expected.txt: Added.
  • platform/chromium-win/svg/text/remove-text-node-from-tspan-expected.png: Added.
  • platform/chromium-win/svg/text/remove-text-node-from-tspan-expected.txt: Added.
  • platform/chromium-win/svg/text/text-text-05-t-expected.png:
  • platform/chromium-win/svg/text/text-text-05-t-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-background-images-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt:
  • platform/chromium-win/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
  • platform/chromium-win/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
  • platform/chromium-win/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
  • platform/mac-snowleopard/svg/zoom/page/zoom-hixie-mixed-008-expected.png: Removed.
  • platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Removed.
  • platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Removed.
  • platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Removed.
  • platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Removed.
  • svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Renamed from LayoutTests/platform/gtk/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt.
  • svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Renamed from LayoutTests/platform/gtk/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt.
07:33 Changeset [106939] by abecsi@webkit.org

[Qt] [WK2] Fix the debug build after r106920

  • WebProcess/qt/WebProcessQt.cpp:

(WebKit::WebProcess::platformSetCacheModel):
Remove unnecessary assert.

07:29 Changeset [106938] by ossy@webkit.org

[Qt] Unreviewed gardening. Update platform specific expected files after r106918.

  • platform/qt/Skipped: Unskip non-existing tests.
  • platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt:
  • platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt:
  • platform/qt/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt:
  • platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt:
  • platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt:
  • platform/qt/svg/carto.net/tabgroup-expected.png:
  • platform/qt/svg/carto.net/tabgroup-expected.txt:
  • platform/qt/svg/carto.net/window-expected.png:
  • platform/qt/svg/carto.net/window-expected.txt:
  • platform/qt/svg/dom/SVGPathSegList-segment-modification-expected.png:
  • platform/qt/svg/dom/SVGPathSegList-segment-modification-expected.txt:
  • platform/qt/svg/filters/filter-width-update-expected.png:
  • platform/qt/svg/filters/filter-width-update-expected.txt:
  • platform/qt/svg/hixie/perf/003-expected.png:
  • platform/qt/svg/hixie/perf/003-expected.txt:
  • platform/qt/svg/hixie/perf/004-expected.png:
  • platform/qt/svg/hixie/perf/004-expected.txt:
  • platform/qt/svg/hixie/perf/005-expected.png:
  • platform/qt/svg/hixie/perf/005-expected.txt:
  • platform/qt/svg/hixie/perf/006-expected.png:
  • platform/qt/svg/hixie/perf/006-expected.txt:
  • platform/qt/svg/zoom/page/zoom-background-images-expected.png:
  • platform/qt/svg/zoom/page/zoom-background-images-expected.txt:
  • platform/qt/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
  • platform/qt/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
  • platform/qt/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
  • platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.png:
  • platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
  • platform/qt/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png:
  • platform/qt/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
07:27 Changeset [106937] by commit-queue@webkit.org

Web Inspector: fix objects duplication when switching filter in heap profiler.
https://bugs.webkit.org/show_bug.cgi?id=77974

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-02-07
Reviewed by Yury Semikhatsky.

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):

07:22 Changeset [106936] by mario@webkit.org

[GTK] Include gdk-pixbuf in the jhbuild modules
https://bugs.webkit.org/show_bug.cgi?id=77980

Reviewed by Gustavo Noronha Silva.

  • gtk/jhbuild.modules: Add gdk-pixbuf to the jhbuild moduleset.
07:16 Changeset [106935] by commit-queue@webkit.org

[chromium] Add setNeedsRedraw to WebWidget
https://bugs.webkit.org/show_bug.cgi?id=77555

Patch by Jonathan Backer <backer@chromium.org> on 2012-02-07
Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::setNeedsRedraw):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::setNeedsRedraw):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::setNeedsRedraw):
(WebCore::CCThreadProxy::resetDamageTrackerOnImplThread):
(WebCore):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

  • public/WebWidget.h:

(WebWidget):
(WebKit::WebWidget::setNeedsRedraw):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setNeedsRedraw):
(WebKit):

  • src/WebViewImpl.h:

(WebViewImpl):

06:58 BuildingGtk edited by kov@webkit.org
Add libtiff4-dev as a dependency (diff)
06:52 Changeset [106934] by tonyg@chromium.org

Unreviewed gardening.

  • platform/chromium-mac-leopard/fast/canvas/check-stale-putImageData-expected.png: Added. Pixel results for platform font.
06:32 Changeset [106933] by ossy@webkit.org

[Qt][WK2] Compute and set cache capacities using the current CacheModel
https://bugs.webkit.org/show_bug.cgi?id=73918

Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-02-07
Reviewed by Kenneth Rohde Christiansen.

No new tests. (build fix)

  • platform/qt/FileSystemQt.cpp:

(WebCore::getVolumeFreeSizeForPath):

06:00 Changeset [106932] by pfeldman@chromium.org

Web Inspector: add generic support for undo-ing DOM edits.
https://bugs.webkit.org/show_bug.cgi?id=77875

Reviewed by Yury Semikhatsky.

Source/WebCore:

This change introduces InspectorHistory::Action that encapsulates all DOM modifications
initiated by the inspector. There is a way to undo these actions up until the undoable
state marker.

Tests: inspector/elements/undo-dom-edits-2.html

inspector/elements/undo-dom-edits.html
inspector/styles/undo-add-property.html
inspector/styles/undo-change-property.html
inspector/styles/undo-property-toggle.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/Inspector.json:
  • inspector/InspectorAllInOne.cpp:
  • inspector/InspectorCSSAgent.cpp:

(InspectorCSSAgent::StyleSheetAction):
(WebCore::InspectorCSSAgent::StyleSheetAction::StyleSheetAction):
(WebCore::InspectorCSSAgent::StyleSheetAction::perform):
(WebCore::InspectorCSSAgent::StyleSheetAction::undo):
(WebCore):
(InspectorCSSAgent::SetStyleSheetTextAction):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::SetStyleSheetTextAction):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::perform):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::undo):
(InspectorCSSAgent::SetPropertyTextAction):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::SetPropertyTextAction):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::toString):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::perform):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::undo):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::mergeId):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::merge):
(InspectorCSSAgent::TogglePropertyAction):
(WebCore::InspectorCSSAgent::TogglePropertyAction::TogglePropertyAction):
(WebCore::InspectorCSSAgent::TogglePropertyAction::perform):
(WebCore::InspectorCSSAgent::TogglePropertyAction::undo):
(WebCore::InspectorCSSAgent::getStyleSheetText):
(WebCore::InspectorCSSAgent::setStyleSheetText):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::reset):
(WebCore::InspectorDOMAgent::setAttributeValue):
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::removeAttribute):
(WebCore::InspectorDOMAgent::removeNode):
(WebCore::InspectorDOMAgent::setNodeName):
(WebCore::InspectorDOMAgent::setOuterHTML):
(WebCore::InspectorDOMAgent::setNodeValue):
(WebCore::InspectorDOMAgent::moveTo):
(WebCore::InspectorDOMAgent::undo):
(WebCore):
(WebCore::InspectorDOMAgent::markUndoableState):

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):
(WebCore::InspectorDOMAgent::history):

  • inspector/InspectorHistory.cpp: Added.

(WebCore::InspectorHistory::Action::Action):
(WebCore):
(WebCore::InspectorHistory::Action::~Action):
(WebCore::InspectorHistory::Action::toString):
(WebCore::InspectorHistory::Action::isUndoableStateMark):
(WebCore::InspectorHistory::Action::mergeId):
(WebCore::InspectorHistory::Action::merge):
(WebCore::InspectorHistory::InspectorHistory):
(WebCore::InspectorHistory::~InspectorHistory):
(WebCore::InspectorHistory::perform):
(WebCore::InspectorHistory::markUndoableState):
(WebCore::InspectorHistory::undo):
(WebCore::InspectorHistory::reset):

  • inspector/InspectorHistory.h: Added.

(WebCore):
(InspectorHistory):
(Action):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyle::styleText):
(WebCore::InspectorStyleSheet::addRule):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
(WebCore::InspectorStyleSheet::buildObjectForStyle):
(WebCore::InspectorStyleSheet::setPropertyText):
(WebCore::InspectorStyleSheet::getText):
(WebCore::InspectorStyleSheetForInlineStyle::getText):

  • inspector/InspectorStyleSheet.h:

(InspectorStyle):
(InspectorStyleSheet):
(InspectorStyleSheetForInlineStyle):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSProperty.prototype.setText):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype._selectedNodeChanged):
(WebInspector.ElementsPanel.prototype._updateSidebars):
(WebInspector.ElementsPanel.prototype.handleShortcut):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.prototype.onpopulate):
(WebInspector.StylePropertiesSection.prototype.addNewBlankProperty):
(WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):
(WebInspector.StylePropertyTreeElement):
(WebInspector.StylePropertyTreeElement.prototype):

LayoutTests:

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.rangeText):
(initialize_ElementTest.InspectorTest.generateUndoTest):

  • inspector/elements/undo-dom-edits-2-expected.txt: Added.
  • inspector/elements/undo-dom-edits-2.html: Added.
  • inspector/elements/undo-dom-edits-expected.txt: Added.
  • inspector/elements/undo-dom-edits.html: Added.
  • inspector/styles/undo-add-property-expected.txt: Added.
  • inspector/styles/undo-add-property.html: Added.
  • inspector/styles/undo-change-property-expected.txt: Added.
  • inspector/styles/undo-change-property.html: Added.
  • inspector/styles/undo-property-toggle-expected.txt: Added.
  • inspector/styles/undo-property-toggle.html: Added.
05:41 Changeset [106931] by commit-queue@webkit.org

[Blackberry] Clean up Networkjob and Networkmanger: remove unused variables in release build and change some public functions into be private ones
https://bugs.webkit.org/show_bug.cgi?id=77926

Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-02-07
Reviewed by Rob Buis.

  1. rename clientIsOk to isClientAvailable.
  2. m_isRunning is only for an ASSERT in NetWorkManager, So move out from

release build but keep available in debug build.

No changes in behavior, so no new tests.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::NetworkJob):
(WebCore::NetworkJob::handleNotifyDataReceived):
(WebCore::NetworkJob::handleNotifyDataSent):
(WebCore::NetworkJob::handleNotifyClose):
(WebCore::NetworkJob::startNewJobWithRequest):
(WebCore::NetworkJob::sendResponseIfNeeded):
(WebCore::NetworkJob::sendMultipartResponseIfNeeded):

  • platform/network/blackberry/NetworkJob.h:

(NetworkJob):
(WebCore::NetworkJob::isClientAvailable):

05:09 Changeset [106930] by abecsi@webkit.org

[Qt][WK2] Add the componentComplete method to WebView
https://bugs.webkit.org/show_bug.cgi?id=77111

Reviewed by Simon Hausmann.

Move the initialization of the interaction engine to componentComplete
in preparation of switching to a Flickable based content positioning
for the touch based WebView.
Suspend the page and delay the dispatch of load success on startup until
the component finished initialization. With this patch instantiating the
WebView in C++ is only possible by creating a QDeclarativeComponent as
the initialization depends on the componentComplete method being called.
Also return valid default values in the viewport info functions if the
interaction engine is not yet initialized because the viewport info
component could finish initialization earlier than the WebView, which
results in QML warnings during MiniBrowser startup.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::loadDidSucceed):
(QQuickWebViewFlickablePrivate::QQuickWebViewFlickablePrivate):
(QQuickWebViewFlickablePrivate::initialize):
(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebViewFlickablePrivate::loadDidSucceed):
(QQuickWebViewFlickablePrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::_q_resume):
(QQuickWebView::geometryChanged):
(QQuickWebView::componentComplete):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate::onComponentComplete):
(QQuickWebViewPrivate):
(QQuickWebViewFlickablePrivate):

  • UIProcess/API/qt/qwebviewportinfo.cpp:

(QWebViewportInfo::currentScale):
(QWebViewportInfo::devicePixelRatio):
(QWebViewportInfo::initialScale):
(QWebViewportInfo::minimumScale):
(QWebViewportInfo::maximumScale):
(QWebViewportInfo::isScalable):
(QWebViewportInfo::layoutSize):

  • UIProcess/API/qt/tests/qquickwebview/qquickwebview.pro:
  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::tst_QQuickWebView):
(tst_QQuickWebView::init):
(tst_QQuickWebView::multipleWebViewWindows):
(tst_QQuickWebView::multipleWebViews):

  • UIProcess/qt/QtWebPageLoadClient.cpp:

(QtWebPageLoadClient::dispatchLoadSucceeded):

04:55 Changeset [106929] by commit-queue@webkit.org

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-07

  • DEPS:
04:52 Changeset [106928] by yurys@chromium.org

Web Inspector: don't mark object is queriable if it is only reachable by internal reference
https://bugs.webkit.org/show_bug.cgi?id=77877

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):

LayoutTests:

  • inspector/profiler/heap-snapshot.html:
04:44 Changeset [106927] by ossy@webkit.org

[Qt] New svg/hittest tests introduced in r106882 fail
https://bugs.webkit.org/show_bug.cgi?id=77964

Patch by Ádám Kallai <Kallai.Adam@stud.u-szeged.hu> on 2012-02-07
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped: Skip failing tests until fix.
04:43 Changeset [106926] by loislo@chromium.org

Unreviewed, rolling out r106909.
http://trac.webkit.org/changeset/106909
https://bugs.webkit.org/show_bug.cgi?id=77965

~20 tests are crashing on chromium win release bot. (Requested
by loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-07

  • html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::createShadowSubtree):

  • html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::HTMLKeygenElement):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::createShadowSubtree):

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::createShadowSubtree):

  • html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::createShadowSubtree):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::createShadowSubtree):

04:29 Changeset [106925] by kling@webkit.org

REGRESSION(r106819): ~28% or so performance regression on the ManInBlue HTML benchmark
<http://webkit.org/b/77952>

Reviewed by Andreas Kling.
Patch by Ryosuke Niwa.

The performance regression was caused by using ensureAttributeData() which forces the
regeneration of invalidated attributes ("style" and SVG animatable attributes.)
Added an ensureAttributeDataWithoutUpdate() helper that only ensures the presence
of ElementAttributeData, not the validity of its contents. Use that when grabbing
at an element's inline and attribute styles.

  • dom/Element.h:

(Element):
(WebCore::Element::ensureAttributeDataWithoutUpdate):

  • dom/StyledElement.h:

(WebCore::StyledElement::ensureInlineStyleDecl):
(WebCore::StyledElement::ensureAttributeStyle):

04:23 Changeset [106924] by ossy@webkit.org

[Qt][WK2] Compute and set cache capacities using the current CacheModel
https://bugs.webkit.org/show_bug.cgi?id=73918

Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-02-07
Reviewed by Csaba Osztrogonác.

No new tests. (build fix).

  • platform/qt/FileSystemQt.cpp:
04:12 Changeset [106923] by philn@webkit.org

Unreviewed, GTK svg rebaseline after r106918.

  • platform/gtk/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt:
  • platform/gtk/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt:
  • platform/gtk/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt:
  • platform/gtk/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt:
  • platform/gtk/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt:
  • platform/gtk/svg/carto.net/tabgroup-expected.txt:
  • platform/gtk/svg/carto.net/window-expected.txt:
  • platform/gtk/svg/dom/SVGPathSegList-segment-modification-expected.txt:
  • platform/gtk/svg/filters/filter-width-update-expected.txt:
  • platform/gtk/svg/text/text-text-05-t-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-background-images-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
03:50 Changeset [106922] by commit-queue@webkit.org

Unreviewed, rolling out r106915.
http://trac.webkit.org/changeset/106915
https://bugs.webkit.org/show_bug.cgi?id=77961

because 106912 was rolled out (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-07

  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
  • platform/qt/fast/dom/constructed-objects-prototypes-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
03:45 Changeset [106921] by commit-queue@webkit.org

[EFL][WK2] Add ModuleEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=63608

Patch by YoungTaeck Song <youngtaeck.song@samsung.com> on 2012-02-07
Reviewed by Andreas Kling.

Add first version of ModuleEfl.cpp including load(), unload() and platformFunctionPointer().

  • Platform/Module.h:
  • Platform/efl/ModuleEfl.cpp: Added.

(WebKit::Module::load):
(WebKit::Module::unload):
(WebKit::Module::platformFunctionPointer):

03:42 Changeset [106920] by commit-queue@webkit.org

[Qt][WK2] Compute and set cache capacities using the current CacheModel
https://bugs.webkit.org/show_bug.cgi?id=73918

Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-02-07
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

No new tests. (Not applicable)

Added OS-specific implementation for retrieving the free disk space.

  • platform/FileSystem.h:

(WebCore):

  • platform/qt/FileSystemQt.cpp:

(WebCore::getVolumeFreeSizeForPath):
(WebCore):

Source/WebKit2:

First part of the implementation. The next steps are the implementation
of the API for the Qt WebKit 2 port and the hybrid memory and disk cache.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

(WebProcessCreationParameters):

  • UIProcess/qt/WebContextQt.cpp:

(WebKit::defaultDiskCacheDirectory):
(WebKit):
(WebKit::WebContext::platformInitializeWebProcess):

  • WebProcess/qt/WebProcessQt.cpp:

(WebKit::physicalMemorySizeInBytes):
(WebKit):
(WebKit::WebProcess::platformSetCacheModel):
(WebKit::WebProcess::platformInitializeWebProcess):

03:19 Changeset [106919] by commit-queue@webkit.org

[Qt] Prevent early test termination with newer Qt 5
https://bugs.webkit.org/show_bug.cgi?id=77945

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-02-07
Reviewed by Csaba Osztrogonác.

QTBUG-24120 tracks a regression in Qt that would make layout tests
terminate early. This patch works around it in a Qt 4 + 5 safe manner
by disabling the quitOnLastWindowClosed feature, which we don't want/need
for DRT anyway.

  • DumpRenderTree/qt/main.cpp:

(main): Don't quit on last window closed.

03:19 Changeset [106918] by zimmermann@webkit.org

Rewrite SVG tests to make extensive use of display() in repaint tests
https://bugs.webkit.org/show_bug.cgi?id=77736

Reviewed by Andreas Kling.

Convert all tests in svg/ (except svg/custom & svg/dynamic-updates) that exercise repainting to use the
fast/repaint/resources/repaint.js harness, which forces a layout, and calls layoutTestController.display()
before executing the actual repaint test, so that repaint rectangles are properly tracked and shown (white
areas that are redrawn, on top of the gray background, painted over the web view after the initial painting).

Previously SVG tests used to work like this: (using an HTML example, but it doesn't matter)
<html><body><svg><rect/><script>function change() { rect.setAttribute(...); layoutTestController.notifyDone(); } setTimeout(change, 0); </script></svg></body></html>

We expected that the initial painting was done, before change() as called. This is unreliable for various reasons:

  • the timeout is not guaranteed to fire after the document loaded, it may happen inbetween on eg. a slow connection.
  • nor is it guaranteed that the document has painted initially before we enter change(). This leads to the current regressions -- if we break repainting, we can't see it in the current layout tests, as the initial painting always happens after change() executed in trunk, at least on a fast machine.

In order to make repaint testing reliable we have to use following scheme:
<html><body onload="runRepaintTest()"><svg><rect/><script>function repaintTest() { rect.setAttribute(...); }</script></svg></body></html>

runRepaintTest() is provided by the repaint.js harness and does:
if (window.layoutTestController) {

document.body.offsetTop;
layoutTestController.display();
repaintTest();

} else {

setTimeout(repaintTest, 100);

}

Using this harness outside of DRT allows to test SVG repainting tests in the browser as well, as the repainting changes
aren't immediately fired (0ms timer) but instead delayed by 100ms, so a visual "flash" is visible, if something changes.
For DRT it does two things. First it forces Document::updateLayout() to be called, and then forces the web view to paint
immediately, and then it starts tracking any repaint rects, that are fired _after_ the initial painting, which are then
highlighted in the pixel test dump later on. Using display() is the only way to get reliable painting results across
DRT/WebKitTestRunner, and to get rid of the flakiness.

All *.xml/*.html/*.htm/*.xhtml tests which excersise repainting can be moved to use runRepaintTest() from repaint.js.
<body> needs to be changed to <body onload="runRepaintTest()">, and the timeouts & waitUntilDone/notifyDone calls can
be removed from the tests, leading to much nicer testcases, removing lots of boilerplate.

Pure *.svg tests unfortunately can't use <svg onload="runRepaintTest()"> at the moment, due timing differences between
the HTML load and the SVGLoad event, that's out of scope for this bug report. To remove any hacks from the testcases
themselves, I centralized following work-around in a new function in repaint.js, and let all *.svg tests use it.

function runSVGRepaintTest() {

if (window.layoutTestController) {

layoutTestController.waitUntilDone();
setTimeout(runRepaintTest, 0);

} else

runRepaintTest();

}

runRepaintTest() has to be called from a timer at the moment, as the SVGLoad event fires earlier as HTML load event.
Before that is fixed, we have to use <svg onload="runSVGRepaintTest()"> instead of <svg onload="runRepaintTest()">
and append: layoutTestController.notifyDone() to the repaintTest() functions in the testcases. That should explain
the testcase differences between pure-SVG and non-pure-SVG tests, and why I treated them differently. This approach
is unfortunately as flakey as the old, so to make pure *.svg tests test repainting reliable, the bug needs to be fixed.

Note that svg/custom, and svg/dynamic-updates will be fixed in another chunk, as they also require large amounts
of rebaselines.

  • fast/repaint/resources/repaint.js:

(runRepaintTest):
(runSVGRepaintTest):

  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/as-background-image/animated-svg-as-background-expected.png:
  • platform/mac/svg/as-image/animated-svg-as-image-expected.png:
  • platform/mac/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png:
  • platform/mac/svg/as-image/animated-svg-as-image-same-image-expected.png:
  • platform/mac/svg/as-image/svg-image-change-content-size-expected.png:
  • platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png:
  • platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt:
  • platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png:
  • platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt:
  • platform/mac/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png:
  • platform/mac/svg/as-object/embedded-svg-size-changes-expected.png:
  • platform/mac/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.png:
  • platform/mac/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt:
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-expected.png:
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png:
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt:
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png:
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt:
  • platform/mac/svg/carto.net/tabgroup-expected.png:
  • platform/mac/svg/carto.net/tabgroup-expected.txt:
  • platform/mac/svg/carto.net/window-expected.png:
  • platform/mac/svg/carto.net/window-expected.txt:
  • platform/mac/svg/css/shadow-changes-expected.png:
  • platform/mac/svg/dom/SVGPathSegList-segment-modification-expected.png:
  • platform/mac/svg/dom/SVGPathSegList-segment-modification-expected.txt:
  • platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png:
  • platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png:
  • platform/mac/svg/dom/SVGRectElement/rect-modify-rx-expected.png:
  • platform/mac/svg/filters/filter-refresh-expected.png:
  • platform/mac/svg/filters/filter-width-update-expected.png:
  • platform/mac/svg/filters/filter-width-update-expected.txt:
  • platform/mac/svg/filters/invalidate-on-child-layout-expected.png:
  • platform/mac/svg/hixie/perf/001-expected.png:
  • platform/mac/svg/hixie/perf/002-expected.png:
  • platform/mac/svg/hixie/perf/003-expected.png:
  • platform/mac/svg/hixie/perf/003-expected.txt:
  • platform/mac/svg/hixie/perf/004-expected.png:
  • platform/mac/svg/hixie/perf/004-expected.txt:
  • platform/mac/svg/hixie/perf/005-expected.png:
  • platform/mac/svg/hixie/perf/005-expected.txt:
  • platform/mac/svg/hixie/perf/006-expected.png:
  • platform/mac/svg/hixie/perf/006-expected.txt:
  • platform/mac/svg/hixie/perf/007-expected.png:
  • platform/mac/svg/hixie/perf/007-expected.txt:
  • platform/mac/svg/repaint/filter-child-repaint-expected.png:
  • platform/mac/svg/repaint/image-href-change-expected.png:
  • platform/mac/svg/repaint/image-with-clip-path-expected.png:
  • platform/mac/svg/text/append-text-node-to-tspan-expected.png:
  • platform/mac/svg/text/modify-text-node-in-tspan-expected.png:
  • platform/mac/svg/text/remove-text-node-from-tspan-expected.png:
  • platform/mac/svg/text/remove-tspan-from-text-expected.png:
  • platform/mac/svg/text/text-text-05-t-expected.png:
  • platform/mac/svg/text/text-text-05-t-expected.txt:
  • platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.png:
  • platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png:
  • platform/mac/svg/zoom/page/zoom-background-images-expected.txt:
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
  • platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png:
  • platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt:
  • platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png:
  • platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
  • platform/mac/svg/zoom/page/zoom-svg-as-image-expected.png:
  • platform/mac/svg/zoom/page/zoom-svg-as-object-expected.png:
  • platform/mac/svg/zoom/page/zoom-svg-as-relative-image-expected.png:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
  • platform/mac/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.png:
  • platform/mac/svg/zoom/text/absolute-sized-document-scrollbars-expected.png:
  • platform/mac/svg/zoom/text/relative-sized-document-scrollbars-expected.png:
  • platform/mac/svg/zoom/text/zoom-foreignObject-expected.png:
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.png:
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-009-expected.png:
  • platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png:
  • platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
  • svg/as-background-image/animated-svg-as-background.html:
  • svg/as-background-image/resources/animated-rect-relative-size.svg:
  • svg/as-background-image/svg-as-background-5.html:
  • svg/as-background-image/svg-background-partial-redraw.html:
  • svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size.html:
  • svg/as-image/animated-svg-as-image-same-image.html:
  • svg/as-image/animated-svg-as-image.html:
  • svg/as-image/resources/animated-rect-fixed-size-2.svg: Copied from LayoutTests/svg/as-image/resources/animated-rect-same-image.svg.
  • svg/as-image/resources/animated-rect-fixed-size.svg:
  • svg/as-image/resources/animated-rect-relative-size.svg:
  • svg/as-image/resources/animated-rect-same-image.svg:
  • svg/as-image/svg-image-change-content-size.xhtml:
  • svg/as-object/embedded-svg-immediate-offsetWidth-query.html:
  • svg/as-object/embedded-svg-size-changes-no-layout-triggers.html:
  • svg/as-object/embedded-svg-size-changes.html:
  • svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1.html:
  • svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2.html:
  • svg/as-object/nested-embedded-svg-size-changes.html:
  • svg/as-object/resources/embedded-svg-size-changes-no-layout-triggers.svg:
  • svg/as-object/resources/nested-embedded-svg-size-changes-target-no-layout-triggers-1.html:
  • svg/carto.net/tabgroup.svg:
  • svg/carto.net/window.svg:
  • svg/css/shadow-changes.svg:
  • svg/dom/SVGPathSegList-segment-modification.svg:
  • svg/dom/SVGPathSegList-xml-dom-synchronization.xhtml:
  • svg/dom/SVGPathSegList-xml-dom-synchronization2.xhtml:
  • svg/dom/SVGRectElement/rect-modify-rx.svg:
  • svg/filters/animate-fill-expected.png:
  • svg/filters/animate-fill.svg:
  • svg/filters/feImage-reference-invalidation-expected.png:
  • svg/filters/feImage-reference-invalidation.svg:
  • svg/filters/feImage-target-add-to-document-expected.png:
  • svg/filters/feImage-target-add-to-document.svg:
  • svg/filters/feImage-target-changes-id-expected.png:
  • svg/filters/feImage-target-changes-id.svg:
  • svg/filters/feImage-target-id-change-expected.png:
  • svg/filters/feImage-target-id-change.svg:
  • svg/filters/feImage-target-reappend-to-document-expected.png:
  • svg/filters/feImage-target-reappend-to-document.svg:
  • svg/filters/feImage-target-remove-from-document-expected.png:
  • svg/filters/feImage-target-remove-from-document.svg:
  • svg/filters/filter-refresh.svg:
  • svg/filters/filter-width-update.svg:
  • svg/filters/invalidate-on-child-layout.svg:
  • svg/hixie/perf/001.xml:
  • svg/hixie/perf/002.xml:
  • svg/hixie/perf/003.xml:
  • svg/hixie/perf/004.xml:
  • svg/hixie/perf/005.xml:
  • svg/hixie/perf/006.xml:
  • svg/hixie/perf/007.xml:
  • svg/hixie/perf/resources/smallcats.gif: Added.
  • svg/repaint/container-repaint-expected.png:
  • svg/repaint/container-repaint.svg:
  • svg/repaint/filter-child-repaint.svg:
  • svg/repaint/image-href-change.svg:
  • svg/repaint/image-with-clip-path.svg:
  • svg/text/append-text-node-to-tspan.html:
  • svg/text/modify-text-node-in-tspan.html:
  • svg/text/remove-text-node-from-tspan.html:
  • svg/text/remove-tspan-from-text.html:
  • svg/text/text-text-05-t.svg:
  • svg/transforms/animated-path-inside-transformed-html.xhtml:
  • svg/zoom/page/absolute-sized-document-no-scrollbars.svg:
  • svg/zoom/page/absolute-sized-document-scrollbars.svg:
  • svg/zoom/page/relative-sized-document-scrollbars.svg:
  • svg/zoom/page/zoom-background-image-tiled.html:
  • svg/zoom/page/zoom-background-images.html:
  • svg/zoom/page/zoom-coords-viewattr-01-b.svg:
  • svg/zoom/page/zoom-foreignObject.svg:
  • svg/zoom/page/zoom-getBoundingClientRect.xhtml:
  • svg/zoom/page/zoom-hixie-mixed-008.xml:
  • svg/zoom/page/zoom-hixie-mixed-009.xml:
  • svg/zoom/page/zoom-hixie-rendering-model-004.xhtml:
  • svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html:
  • svg/zoom/page/zoom-mask-with-percentages.svg:
  • svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm:
  • svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox.html:
  • svg/zoom/page/zoom-svg-as-background-with-relative-size.html:
  • svg/zoom/page/zoom-svg-as-image.html:
  • svg/zoom/page/zoom-svg-as-object.html:
  • svg/zoom/page/zoom-svg-as-relative-image.html:
  • svg/zoom/page/zoom-svg-float-border-padding.xml:
  • svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml:
  • svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml:
  • svg/zoom/page/zoom-svg-through-object-with-auto-size.html:
  • svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml:
  • svg/zoom/page/zoom-svg-through-object-with-override-size.html:
  • svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml:
  • svg/zoom/page/zoom-svg-through-object-with-text.xhtml-disabled:
  • svg/zoom/page/zoom-zoom-coords.xhtml:
  • svg/zoom/resources/testPageZoom.js:

(repaintTest):

  • svg/zoom/resources/testTextZoom.js:

(repaintTest):

  • svg/zoom/text/absolute-sized-document-no-scrollbars.svg:
  • svg/zoom/text/absolute-sized-document-scrollbars.svg:
  • svg/zoom/text/relative-sized-document-scrollbars.svg:
  • svg/zoom/text/zoom-coords-viewattr-01-b.svg:
  • svg/zoom/text/zoom-foreignObject.svg:
  • svg/zoom/text/zoom-hixie-mixed-008.xml:
  • svg/zoom/text/zoom-hixie-mixed-009.xml:
  • svg/zoom/text/zoom-hixie-rendering-model-004.xhtml:
  • svg/zoom/text/zoom-svg-float-border-padding.xml:
03:10 Changeset [106917] by kenneth@webkit.org

[Inspector] Add the Nokia N9 user agent
https://bugs.webkit.org/show_bug.cgi?id=77949

Reviewed by Simon Hausmann.

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.get const):

02:29 Changeset [106916] by apavlov@chromium.org

[CRASH] bool EventHandler::dispatchSyntheticTouchEventIfEnabled(const PlatformMouseEvent& event) references a NULL pointer
https://bugs.webkit.org/show_bug.cgi?id=77953

Reviewed by Andreas Kling.

  • page/EventHandler.cpp:

(WebCore::EventHandler::dispatchSyntheticTouchEventIfEnabled):

02:22 Changeset [106915] by commit-queue@webkit.org

GTK & QT Rebaseline after r106912.
https://bugs.webkit.org/show_bug.cgi?id=77942

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2012-02-07
Reviewed by David Levin.

  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
  • platform/qt/fast/dom/constructed-objects-prototypes-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
01:51 Applications using WebKit edited by renhuan@360.cn
(diff)
01:44 Changeset [106914] by haraken@chromium.org

Unreviewed, rolling out r106912.
http://trac.webkit.org/changeset/106912
https://bugs.webkit.org/show_bug.cgi?id=77947

"AppleWebKit build is broken" (Requested by haraken on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-07

Source/WebCore:

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore):

  • dom/ScriptExecutionContext.h:

(WebCore):
(ScriptExecutionContext):

  • html/DOMURL.cpp:

(WebCore::DOMURL::DOMURL):
(WebCore):
(WebCore::DOMURL::~DOMURL):
(WebCore::DOMURL::contextDestroyed):
(WebCore::DOMURL::createObjectURL):
(WebCore::DOMURL::revokeObjectURL):

  • html/DOMURL.h:

(WebCore::DOMURL::create):
(DOMURL):

  • html/DOMURL.idl:
  • html/PublicURLManager.h: Removed.
  • page/DOMWindow.cpp:

(WebCore):
(WebCore::DOMWindow::webkitURL):

  • page/DOMWindow.h:

(DOMWindow):

  • page/DOMWindow.idl:
  • workers/WorkerContext.cpp:

(WebCore):
(WebCore::WorkerContext::webkitURL):

  • workers/WorkerContext.h:

(WorkerContext):

  • workers/WorkerContext.idl:

LayoutTests:

  • fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt: Removed.
  • fast/dom/DOMURL/check-instanceof-domurl-functions.html: Removed.
01:28 Applications using WebKit edited by whzeng@126.com
(diff)
00:54 Changeset [106913] by haraken@chromium.org

Unreviewed, rolling out r106862.
http://trac.webkit.org/changeset/106862
https://bugs.webkit.org/show_bug.cgi?id=77510

Mac build fails if we manually remove generated code

  • DerivedSources.make:
  • bindings/scripts/generate-bindings.pl:

(generateEmptyHeaderAndCpp):

  • bindings/scripts/resolve-supplemental.pl:
  • bindings/scripts/update-idl-needs-rebuild.pl: Removed.
00:40 Applications using WebKit edited by renhuan@360.cn
(diff)
00:18 Changeset [106912] by commit-queue@webkit.org

Migrate createObjectURL & revokeObjectURL to static (Class) methods.
https://bugs.webkit.org/show_bug.cgi?id=74386

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2012-02-07
Reviewed by David Levin.

Source/WebCore:

Test: fast/dom/DOMURL/check-instanceof-domurl-functions.html
Already Existing:

fast/files/revoke-blob-url.html
fast/dom/window-domurl-crash.html
fast/files/apply-blob-url-to-img.html
fast/files/create-blob-url-crash.html
fast/files/workers/inline-worker-via-blob-url.html

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::fileThread):
(WebCore):
(WebCore::ScriptExecutionContext::publicURLManager):

  • dom/ScriptExecutionContext.h:

(WebCore):
(ScriptExecutionContext):

  • html/DOMURL.cpp:

(WebCore):
(WebCore::DOMURL::createObjectURL): Changed to static.
(WebCore::DOMURL::revokeObjectURL): ditto.

  • html/DOMURL.h:

(DOMURL):
(WebCore::DOMURL::create):

  • html/DOMURL.idl:
  • html/PublicURLManager.h: Added.

(WebCore):
(PublicURLManager):
(WebCore::PublicURLManager::create):
(WebCore::PublicURLManager::contextDestroyed):
(WebCore::PublicURLManager::blobURLs):
(WebCore::PublicURLManager::streamURLs):

  • page/DOMWindow.cpp: Removed object initialization for DOMURL.

(WebCore):

  • page/DOMWindow.h: ditto.

(DOMWindow):

  • page/DOMWindow.idl:
  • workers/WorkerContext.cpp:

(WebCore):

  • workers/WorkerContext.h:

(WorkerContext):

  • workers/WorkerContext.idl:

LayoutTests:

Added test to check if createObjectURL & revokeObjectURL are static functions.

  • fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt: Added.
  • fast/dom/DOMURL/check-instanceof-domurl-functions.html: Added.
00:16 Changeset [106911] by vsevik@chromium.org

http/tests/inspector/indexeddb/database-structure.html failing on chromium win/linux
https://bugs.webkit.org/show_bug.cgi?id=77661

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):

LayoutTests:

  • platform/chromium/test_expectations.txt:
00:09 Changeset [106910] by hayato@chromium.org

Fix build on Mac with '--shadow-dom'.
https://bugs.webkit.org/show_bug.cgi?id=77940

Reviewed by Hajime Morita.

  • WebCore.xcodeproj/project.pbxproj:

02/06/12:

23:25 Changeset [106909] by commit-queue@webkit.org

Stop calling Element::ensureShadowRoot() if it is used in construction phase.
https://bugs.webkit.org/show_bug.cgi?id=77929

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-06
Reviewed by Hajime Morita.

ShadowRoot's life cycle can be consufing If Element::ensureShadowRoot() is used.
So we want to remove Element::ensureShadowRoot().
This patch replaces Element::ensureShadowRoot() if it is used in object construction phase.

No new tests, no change in behavior.

  • html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::createShadowSubtree):

  • html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::HTMLKeygenElement):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::createShadowSubtree):

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::createShadowSubtree):

  • html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::createShadowSubtree):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::createShadowSubtree):

23:22 Changeset [106908] by commit-queue@webkit.org

[EFL] Define to prevent a single backing-store application from calling the tiled view function.
https://bugs.webkit.org/show_bug.cgi?id=77842

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2012-02-06
Reviewed by Andreas Kling.

The define prevents an application using single backing store from calling tiled cache function.
The tiled APIs opened to outer should check the view type before being called.

  • ewk/ewk_private.h:
  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(ewk_view_frame_view_creation_notify):

  • ewk/ewk_view_tiled.cpp:

(ewk_view_tiled_unused_cache_get):
(ewk_view_tiled_unused_cache_set):

23:09 Changeset [106907] by commit-queue@webkit.org

Remove Element::ensureShadowRoot export.
https://bugs.webkit.org/show_bug.cgi?id=77932

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-06
Reviewed by Hajime Morita.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

Removes Element::ensureShadowRoot export.

No new tests, no change in behavior.

  • WebCore.exp.in:

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
22:33 Changeset [106906] by abarth@webkit.org

http/tests/security/xssAuditor/cookie-injection.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=77908

Reviewed by Eric Seidel.

Before this patch, the output of this test depended on the state of the
global cookie store. When running tests in parallel, the cookie store
is shared by multiple tests, and so its state varies from run to run.

This patch changes this test to look only for the specific cookie used
by this test, which should make the test more reliable when run in
parallel with other tests.

  • http/tests/security/xssAuditor/cookie-injection-expected.txt:
  • http/tests/security/xssAuditor/resources/echo-intertag.pl:
  • platform/chromium/test_expectations.txt:
21:45 Changeset [106905] by loislo@chromium.org

Unreviewed. Web Inspector: rename Artificial to Synthetic according to v8 patch r10614.

  • inspector/front-end/DetailedHeapshotGridNodes.js:
  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.get isSynthetic):
(WebInspector.HeapSnapshot.prototype._init):

21:44 Changeset [106904] by commit-queue@webkit.org

[EFL] Adopt C++ style using camelCase and full variable names.
https://bugs.webkit.org/show_bug.cgi?id=76378

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2012-02-06
Reviewed by Andreas Kling.

Modify the code to use camelCase and spell out variable names instead of using abbreviations.
Modify the comments which do not match with actual parameters and correct misspelled words.
Adopt EFL Coding style in header files.
The logic of the code is not changed.

  • ewk/ewk_cookies.h:
  • ewk/ewk_frame.cpp:

(ewk_frame_selection_get):
(ewk_frame_feed_focus_in):
(EWKPrivate::coreFrame):

  • ewk/ewk_frame.h:
  • ewk/ewk_history.cpp:

(ewk_history_item_new):
(ewk_history_item_title_get):
(ewk_history_item_title_alternate_get):
(ewk_history_item_uri_get):
(ewk_history_item_uri_original_get):

  • ewk/ewk_network.h:
  • ewk/ewk_tiled_backing_store.cpp:

(_Ewk_Tiled_Backing_Store_Item):
(_Ewk_Tiled_Backing_Store_Data):
(_ewk_tiled_backing_store_tile_associate):
(_ewk_tiled_backing_store_tile_dissociate):
(_ewk_tiled_backing_store_pre_render_request_clear):
(_ewk_tiled_backing_store_pre_render_request_process_single):
(_ewk_tiled_backing_store_item_fill):
(_ewk_tiled_backing_store_item_add):
(_ewk_tiled_backing_store_item_smooth_scale_set):
(_ewk_tiled_backing_store_view_cols_end_add):
(_ewk_tiled_backing_store_view_rows_all_del):
(_ewk_tiled_backing_store_render):
(_ewk_tiled_backing_store_mem_dbg):
(_ewk_tiled_backing_store_sig_usr):
(_ewk_tiled_backing_store_smart_add):
(_ewk_tiled_backing_store_smart_del):
(_ewk_tiled_backing_store_smart_move):
(_ewk_tiled_backing_store_smart_resize):
(_ewk_tiled_backing_store_recalc_renderers):
(_ewk_tiled_backing_store_view_dbg):
(_ewk_tiled_backing_store_view_wrap_up):
(_ewk_tiled_backing_store_view_wrap_down):
(_ewk_tiled_backing_store_view_wrap_left):
(_ewk_tiled_backing_store_view_refill):
(_ewk_tiled_backing_store_view_pos_apply):
(_ewk_tiled_backing_store_smart_calculate_offset_force):
(_ewk_tiled_backing_store_smart_calculate_offset):
(_ewk_tiled_backing_store_smart_calculate_pos):
(_ewk_tiled_backing_store_smart_calculate):
(_ewk_tiled_backing_store_scroll_full_offset_set_internal):
(ewk_tiled_backing_store_scroll_full_offset_set):
(ewk_tiled_backing_store_scroll_full_offset_add):
(_ewk_tiled_backing_store_zoom_set_internal):
(ewk_tiled_backing_store_zoom_set):
(ewk_tiled_backing_store_zoom_weak_set):
(ewk_tiled_backing_store_fix_offsets):
(ewk_tiled_backing_store_flush):
(ewk_tiled_backing_store_pre_render_region):
(ewk_tiled_backing_store_pre_render_relative_radius):

  • ewk/ewk_tiled_backing_store.h:

(_Ewk_Tile):

  • ewk/ewk_tiled_matrix.cpp:

(_Ewk_Tile_Matrix):
(_ewk_tile_matrix_cell_free):
(_ewk_tile_matrix_tile_free):
(ewk_tile_matrix_new):
(ewk_tile_matrix_free):
(ewk_tile_matrix_unused_cache_get):
(ewk_tile_matrix_tile_exact_get):
(ewk_tile_matrix_tile_new):
(ewk_tile_matrix_tile_put):
(ewk_tile_matrix_dbg):
(ewk_tile_matrix_freeze):
(ewk_tile_matrix_thaw):

  • ewk/ewk_tiled_matrix.h:
  • ewk/ewk_tiled_model.cpp:

(tile_account):
(ewk_tile_updates_process):
(ewk_tile_unused_cache_tile_put):
(ewk_tile_unused_cache_dbg):

  • ewk/ewk_tiled_model.h:
  • ewk/ewk_util.h:
  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_smart_focus_in):
(_ewk_view_smart_pre_render_region):
(ewk_view_pre_render_region):
(ewk_view_toolbars_visible_get):
(ewk_view_statusbar_visible_get):
(ewk_view_scrollbars_visible_get):
(ewk_view_menubar_visible_get):
(ewk_view_zoom_range_set):

  • ewk/ewk_view.h:
  • ewk/ewk_view_single.cpp:

(_ewk_view_single_smart_repaints_process):

  • ewk/ewk_view_tiled.cpp:

(_ewk_view_tiled_smart_backing_store_add):
(_ewk_view_tiled_smart_add):
(ewk_view_tiled_unused_cache_get):
(ewk_view_tiled_unused_cache_set):

21:09 Changeset [106903] by leo.yang@torchmobile.com.cn

[BlackBerry] Use WebPagePrivate instead of WebPage in GeolocationControllerClientBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=77927

Reviewed by Antonio Gomes.

WebKit/blackberry/Api/WebPage which has a d pointer is designed for public API.
GeolocationControllerClientBlackBerry in WebKit/blackberry/WebCoreSupport should
use the d pointer directly because the client is internal implementation.

No functionalities changed, no new tests.

  • blackberry/WebCoreSupport/GeolocationControllerClientBlackBerry.cpp:

(GeolocationControllerClientBlackBerry::GeolocationControllerClientBlackBerry):
(GeolocationControllerClientBlackBerry::requestPermission):
(GeolocationControllerClientBlackBerry::cancelPermissionRequest):
(GeolocationControllerClientBlackBerry::onLocationUpdate):
(GeolocationControllerClientBlackBerry::onLocationError):

  • blackberry/WebCoreSupport/GeolocationControllerClientBlackBerry.h:

(WebKit):
(GeolocationControllerClientBlackBerry):

20:47 Changeset [106902] by hayato@chromium.org

Implement querySelector on ShadowRoot.
https://bugs.webkit.org/show_bug.cgi?id=77714

Reviewed by Dimitri Glazkov.

Source/WebCore:

  • dom/SelectorQuery.cpp:

(WebCore::nodeIsRootNodeOfTreeScope):
(WebCore):
(WebCore::SelectorDataList::execute):

LayoutTests:

  • fast/dom/shadow/shadow-root-js-api-expected.txt:
  • fast/dom/shadow/shadow-root-js-api.html:
20:41 Changeset [106901] by mrobinson@webkit.org

[GTK] Add TextureMapperGL implementation
https://bugs.webkit.org/show_bug.cgi?id=75308

.:

Patch by Martin Robinson <mrobinson@igalia.com> and Nayan Kumar K <nayankk@motorola.com> on 2012-02-06
Reviewed by Alejandro G. Castro.

  • GNUmakefile.am: TextureMapperGL implies USE(TEXTURE_MAPPER)
  • configure.ac: Only allow enabling the GL version of TextureMapper on X11.

Source/WebCore:

Patch by Martin Robinson <mrobinson@igalia.com> and Nayan Kumar K <nayankk@motorola.com> on 2012-02-06
Reviewed by Alejandro G. Castro.

No new tests. This will be covered by accelerated compositing and
3D CSS transform tests eventually.

  • GNUmakefile.list.am: Added some files necessary to build TextureMapperGL.
  • platform/graphics/cairo/TextureMapperGLCairo.cpp: Added implementations.
  • platform/graphics/cairo/TextureMapperGLCairo.h: Updated member list.
  • platform/graphics/gtk/WindowGLContext.h: Added.
  • platform/graphics/gtk/WindowGLContextGLX.cpp: Added.
  • platform/graphics/opengl/TextureMapperGL.cpp: Use the GL shims on GTK.

Source/WebKit/gtk:

Patch by Martin Robinson <mrobinson@igalia.com> and Nayan Kumar K <nayankk@motorola.com> on 2012-02-06
Reviewed by Alejandro G. Castro.

  • GNUmakefile.am: Add AcceleratedCompositingContextGL to the list.
  • WebCoreSupport/AcceleratedCompositingContext.h:

(AcceleratedCompositingContext): Added some members for AcceleratedCompositingContextGL.

  • WebCoreSupport/AcceleratedCompositingContextClutter.cpp: Added empty implementations

for GraphicsLayerClient. This is only used for the GL variant.

  • WebCoreSupport/AcceleratedCompositingContextGL.cpp: Added.
  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::performAllPendingScrolls): Update the root layer while scrolling.
(WebKit::ChromeClient::paint): Update the root layer after painting.

  • webkit/webkitwebsettings.cpp: Added an enable-accelerated-compositing setting.
  • webkit/webkitwebsettingsprivate.h: Ditto.
  • webkit/webkitwebview.cpp:

(webkit_web_view_draw): Call into TextureMapper now.
(webkit_web_view_realize): Use gdk_window_ensure_native here.
(webkit_web_view_update_settings): Support the new enable-accelerated-compositing setting.
(webkit_web_view_settings_notify): Ditto.

Source/WebKit2:

Reviewed by Alejandro G. Castro.

Fix the WebKit2 + AC build for GTK+.

  • GNUmakefile.am: Add some missing source files.
  • UIProcess/DrawingAreaProxy.cpp:

(WebKit): Add USE(TILED_BACKING_STORE) to the guard.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage): Ditto.

  • WebProcess/WebPage/DrawingArea.h:

(DrawingArea): Ditto.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit): Ditto.

  • WebProcess/WebPage/DrawingAreaImpl.h:

(DrawingAreaImpl): Ditto.

20:26 Changeset [106900] by eae@chromium.org

Change baselinePosition and lineHeight to LayoutUnit
https://bugs.webkit.org/show_bug.cgi?id=77905

Reviewed by Eric Seidel.

Change the virtual baselinePosition and lineHeight methods to return
LayoutUnits as they are both computed from the height and top/bottom
margins (or width and left/right margins for vertical text), all of
which are LayoutUnits.

No new tests.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::baselinePosition):

  • platform/efl/RenderThemeEfl.h:

(RenderThemeEfl):

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::baselinePosition):

  • platform/gtk/RenderThemeGtk.h:

(RenderThemeGtk):

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::baselinePosition):

  • platform/qt/RenderThemeQt.h:

(RenderThemeQt):

  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::lineHeight):
(WebCore::RenderListMarker::baselinePosition):

  • rendering/RenderListMarker.h:

(RenderListMarker):

  • rendering/RenderSlider.cpp:

(WebCore::RenderSlider::baselinePosition):

  • rendering/RenderSlider.h:

(RenderSlider):

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::baselinePosition):
(WebCore::RootInlineBox::lineHeight):

  • rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::baselinePosition):

  • rendering/mathml/RenderMathMLFraction.h:

(RenderMathMLFraction):

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::baselinePosition):

  • rendering/mathml/RenderMathMLOperator.h:

(RenderMathMLOperator):

  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::baselinePosition):

  • rendering/mathml/RenderMathMLRow.h:

(RenderMathMLRow):

  • rendering/mathml/RenderMathMLSubSup.cpp:

(WebCore::RenderMathMLSubSup::baselinePosition):

  • rendering/mathml/RenderMathMLSubSup.h:

(RenderMathMLSubSup):

  • rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore::RenderMathMLUnderOver::baselinePosition):

  • rendering/mathml/RenderMathMLUnderOver.h:

(RenderMathMLUnderOver):

20:16 Changeset [106899] by wangxianzhu@chromium.org

Avoid Page::updateViewportArguments() if the causing frame is not the main frame
https://bugs.webkit.org/show_bug.cgi?id=77387

Reviewed by Kenneth Rohde Christiansen.

  • dom/Document.cpp:

(WebCore::Document::processViewport):
(WebCore::Document::updateViewportArguments):
(WebCore::Document::setInPageCache):

  • dom/Document.h:

(Document):

  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::insertedIntoDocument):

  • page/Frame.cpp:

(WebCore::Frame::setDocument):

  • page/Page.cpp:

(WebCore::Page::viewportArguments):
(WebCore):

  • page/Page.h:

(Page):

20:05 Changeset [106898] by dgrogan@chromium.org

js-test-pre.js: relay calls to testPassed, testFailed, debug, etc from
worker to document.
https://bugs.webkit.org/show_bug.cgi?id=76762

Reviewed by Ojan Vafai.

  • fast/filesystem/resources/async-operations.js:
  • fast/filesystem/resources/directory-entry-to-uri.js:
  • fast/filesystem/resources/file-entry-to-uri-sync.js:
  • fast/filesystem/resources/file-entry-to-uri.js:
  • fast/filesystem/resources/file-from-file-entry-sync.js:
  • fast/filesystem/resources/file-from-file-entry.js:
  • fast/filesystem/resources/file-writer-abort-continue.js:
  • fast/filesystem/resources/file-writer-abort-depth.js:
  • fast/filesystem/resources/file-writer-abort.js:
  • fast/filesystem/resources/file-writer-events.js:
  • fast/filesystem/resources/file-writer-gc-blob.js:
  • fast/filesystem/resources/file-writer-sync-truncate-extend.js:
  • fast/filesystem/resources/file-writer-sync-write-overlapped.js:
  • fast/filesystem/resources/file-writer-truncate-extend.js:
  • fast/filesystem/resources/file-writer-write-overlapped.js:
  • fast/filesystem/resources/fs-worker-common.js:
  • fast/filesystem/resources/fs-worker-test-util.js: Removed.
  • fast/filesystem/resources/simple-persistent-sync.js:
  • fast/filesystem/resources/simple-persistent.js:
  • fast/filesystem/resources/simple-readonly.js:
  • fast/filesystem/resources/simple-required-arguments-getdirectory.js:
  • fast/filesystem/resources/simple-required-arguments-getfile.js:
  • fast/filesystem/resources/simple-required-arguments-getmetadata.js:
  • fast/filesystem/resources/simple-required-arguments-remove.js:
  • fast/filesystem/resources/simple-temporary-sync.js:
  • fast/filesystem/resources/simple-temporary.js:
  • fast/filesystem/resources/sync-operations.js:
  • fast/filesystem/workers/async-operations.html:
  • fast/filesystem/workers/file-entry-to-uri-sync.html:
  • fast/filesystem/workers/file-from-file-entry-sync.html:
  • fast/filesystem/workers/file-from-file-entry.html:
  • fast/filesystem/workers/file-writer-events.html:
  • fast/filesystem/workers/file-writer-gc-blob.html:
  • fast/filesystem/workers/file-writer-sync-truncate-extend.html:
  • fast/filesystem/workers/file-writer-sync-write-overlapped.html:
  • fast/filesystem/workers/file-writer-truncate-extend.html:
  • fast/filesystem/workers/file-writer-write-overlapped.html:
  • fast/filesystem/workers/simple-persistent-sync.html:
  • fast/filesystem/workers/simple-persistent.html:
  • fast/filesystem/workers/simple-temporary-sync.html:
  • fast/filesystem/workers/simple-temporary.html:
  • fast/filesystem/workers/sync-operations.html:
  • fast/js/resources/js-test-pre.js:

(testPassed):
(testFailed):
(finishJSTest):
(startWorker.worker.onmessage):
(startWorker.worker.onerror):
(startWorker):

  • storage/indexeddb/basics-workers.html:
  • storage/indexeddb/resources/basics.js:
20:01 Changeset [106897] by jchaffraix@webkit.org

Unreviewed gardening.

  • platform/chromium-mac-snowleopard/fast/canvas/check-stale-putImageData-expected.png: Added.

Yet another font difference.

  • platform/chromium/test_expectations.txt: Added LEOPARD to the list of flaky platforms.
19:52 Changeset [106896] by abarth@webkit.org

http/tests/security/mixedContent/insecure-script-in-iframe.html flaky in chromium debug
https://bugs.webkit.org/show_bug.cgi?id=65567

Reviewed by Eric Seidel.

My theory is that the extra log message is caused by the preload
scanner requesting the script, which might occur if the test is running
extremely slowly (as it might on a debug bot).

This patch simplifies the test in the hopes of removing the flakiness.

  • http/tests/security/mixedContent/insecure-script-in-iframe-expected.txt:
  • http/tests/security/mixedContent/insecure-script-in-iframe.html:
  • http/tests/security/mixedContent/resources/frame-with-insecure-script.html:
  • platform/chromium/test_expectations.txt:
19:20 Changeset [106895] by mrobinson@webkit.org

Fix some miscellaneous 'make dist' error for WebKitGTK+.

Source/WebCore:

  • GNUmakefile.list.am: Add some missing Shadow DOM files to the

source list.

Source/WebKit2:

  • GNUmakefile.am: Do not distribute generated files.

Tools:

  • MiniBrowser/gtk/GNUmakefile.am: The MiniBrowser generated

files should not be distributed.

19:11 Changeset [106894] by abarth@webkit.org

http/tests/security/mixedContent/insecure-image-in-main-frame.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=77904

Reviewed by Darin Adler.

My theory is that the extra log message is caused by the preload
scanner requesting the image, which might occur if the test is running
extremely slowly (as it might on a debug bot).

This patch simplifies the test in the hopes of removing the flakiness.

  • http/tests/security/mixedContent/insecure-image-in-main-frame-expected.txt:
  • http/tests/security/mixedContent/insecure-image-in-main-frame.html:
  • http/tests/security/mixedContent/resources/frame-with-insecure-image.html:
  • platform/chromium/test_expectations.txt:
18:55 Changeset [106893] by commit-queue@webkit.org

Add contains() test to Region
https://bugs.webkit.org/show_bug.cgi?id=72294

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-06
Reviewed by Anders Carlsson.

  • platform/graphics/Region.cpp:

(WebCore::Region::contains):
(WebCore):

  • platform/graphics/Region.h:

(Region):
(Shape):
(WebCore::operator==):
(WebCore):

18:43 Changeset [106892] by haraken@chromium.org

Rename [DontCheckEnums], [ReturnsNew], [DoNotCheckDomainSecurityOnGet],
[DoNotCheckDomainSecurityOnSet] and [ImplementationFunction] IDLs
https://bugs.webkit.org/show_bug.cgi?id=77852

Reviewed by Adam Barth.

This patch renames [DontCheckEnums], [ReturnsNew], [DoNotCheckDomainSecurityOnGet],
[DoNotCheckDomainSecurityOnSet] and [ImplementationFunction] IDLs for clarification.

[DontCheckEnums] => [DoNotCheckConstants] (This IDL inserts assertions to check if a
constant value is equal to the expected constant value)
[ReturnsNew] => [ReturnNewObject] (For clarification)
[DoNotCheckDomainSecurityOnGet] => [DoNotCheckDomainSecurityOnGetter] (For naming consistency
with other [*Getter] IDLs)
[DoNotCheckDomainSecurityOnSet] => [DoNotCheckDomainSecurityOnSetter] (For naming consistency
with other [*Setter] IDLs)
[ImplementationFunction=] => [ImplementedAs=] (For clarification. This IDL specifies a method
name in implementation)

No tests. No change in behavior.

  • bindings/scripts/CodeGenerator.pm:

(ShouldCheckEnums):
(GenerateCompileTimeCheckForEnumsIfNeeded):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
(NativeToJSValue):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateSingleBatchedAttribute):
(GenerateFunctionCallString):
(NativeToJSValue):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/TestTypedArray.idl:
  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

  • css/WebKitCSSFilterValue.idl:
  • css/WebKitCSSTransformValue.idl:
  • dom/DOMCoreException.idl:
  • dom/Document.idl:
  • dom/EventException.idl:
  • dom/RangeException.idl:
  • fileapi/FileException.idl:
  • fileapi/OperationNotAllowedException.idl:
  • html/HTMLFormElement.idl:
  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/OESStandardDerivatives.idl:
  • html/canvas/OESVertexArrayObject.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • html/canvas/Uint8ClampedArray.idl:
  • html/canvas/WebGLCompressedTextures.idl:
  • html/canvas/WebGLDebugRendererInfo.idl:
  • html/canvas/WebGLRenderingContext.idl:
  • inspector/JavaScriptCallFrame.idl:
  • loader/appcache/DOMApplicationCache.idl:
  • page/Console.idl:
  • page/DOMWindow.idl:
  • page/Location.idl:
  • storage/IDBCursor.idl:
  • storage/IDBDatabaseException.idl:
  • storage/IDBObjectStore.idl:
  • storage/SQLException.idl:
  • svg/SVGComponentTransferFunctionElement.idl:
  • svg/SVGException.idl:
  • svg/SVGFEBlendElement.idl:
  • svg/SVGFEColorMatrixElement.idl:
  • svg/SVGFECompositeElement.idl:
  • svg/SVGFEConvolveMatrixElement.idl:
  • svg/SVGFEDisplacementMapElement.idl:
  • svg/SVGFEMorphologyElement.idl:
  • svg/SVGFETurbulenceElement.idl:
  • svg/SVGGradientElement.idl:
  • xml/XMLHttpRequestException.idl:
  • xml/XPathException.idl:
18:24 Changeset [106891] by jamesr@google.com

[chromium] canvas demo is slow due to unnecessary resource cleanups
https://bugs.webkit.org/show_bug.cgi?id=77135

Reviewed by Kenneth Russell.

Source/WebCore:

This defers dropping a ManagedTexture until it is evicted by the manager, the layer is destroyed, the
TextureManager is destroyed, or the layer is added to a CCLayerTreeHost that has a different texture manager. In
particular, removing a layer from a CCLayerTreeHost and then adding it back to the same host does not drop any
ManagedTextures unless the manager has to evict it for other reasons. This provides a big speedup on sites that
rebuild the compositing tree frequently.

New unit test added for ManagedTexture / TextureManager interaction.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::setLayerTreeHost):
(WebCore::Canvas2DLayerChromium::setTextureManager):

  • platform/graphics/chromium/Canvas2DLayerChromium.h:

(Canvas2DLayerChromium):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setLayerTreeHost):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):

  • platform/graphics/chromium/ManagedTexture.cpp:

(WebCore::ManagedTexture::setTextureManager):
(WebCore):
(WebCore::ManagedTexture::steal):
(WebCore::ManagedTexture::clear):

  • platform/graphics/chromium/ManagedTexture.h:

(ManagedTexture):

  • platform/graphics/chromium/RenderSurfaceChromium.h:

(RenderSurfaceChromium):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::setLayerTreeHost):
(WebCore):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):

  • platform/graphics/chromium/TiledLayerChromium.h:

Source/WebKit/chromium:

  • tests/Canvas2DLayerChromiumTest.cpp:

(WebCore::Canvas2DLayerChromiumTest::fullLifecycleTest):

  • tests/TextureManagerTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:
18:21 Changeset [106890] by rniwa@webkit.org

Perf-o-matic should show min/max/stdev on graphs
https://bugs.webkit.org/show_bug.cgi?id=77702

Reviewed by Andreas Kling.

Include min/max/stdev in test runs when available to be shown on the perf-o-matic.

Also merge a change to config.js and increment the version number by 1 (unreviewed).

  • Websites/webkit-perf.appspot.com/app.yaml:
  • Websites/webkit-perf.appspot.com/js/config.js:
  • Websites/webkit-perf.appspot.com/runs_handler.py:

(RunsHandler.get):

18:04 Changeset [106889] by haraken@chromium.org

Unreviewed, rolling out r106883.
http://trac.webkit.org/changeset/106883
https://bugs.webkit.org/show_bug.cgi?id=77852

build failure around Chromium V8 bindings

  • bindings/scripts/CodeGenerator.pm:

(ShouldCheckEnums):
(GenerateCompileTimeCheckForEnumsIfNeeded):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
(NativeToJSValue):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateSingleBatchedAttribute):
(GenerateFunctionCallString):
(NativeToJSValue):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/TestTypedArray.idl:
  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

  • css/WebKitCSSFilterValue.idl:
  • css/WebKitCSSTransformValue.idl:
  • dom/DOMCoreException.idl:
  • dom/Document.idl:
  • dom/EventException.idl:
  • dom/RangeException.idl:
  • fileapi/FileException.idl:
  • fileapi/OperationNotAllowedException.idl:
  • html/HTMLFormElement.idl:
  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/OESStandardDerivatives.idl:
  • html/canvas/OESVertexArrayObject.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • html/canvas/Uint8ClampedArray.idl:
  • html/canvas/WebGLCompressedTextures.idl:
  • html/canvas/WebGLDebugRendererInfo.idl:
  • html/canvas/WebGLRenderingContext.idl:
  • inspector/JavaScriptCallFrame.idl:
  • loader/appcache/DOMApplicationCache.idl:
  • page/Console.idl:
  • page/DOMWindow.idl:
  • page/Location.idl:
  • storage/IDBCursor.idl:
  • storage/IDBDatabaseException.idl:
  • storage/IDBObjectStore.idl:
  • storage/SQLException.idl:
  • svg/SVGComponentTransferFunctionElement.idl:
  • svg/SVGException.idl:
  • svg/SVGFEBlendElement.idl:
  • svg/SVGFEColorMatrixElement.idl:
  • svg/SVGFECompositeElement.idl:
  • svg/SVGFEConvolveMatrixElement.idl:
  • svg/SVGFEDisplacementMapElement.idl:
  • svg/SVGFEMorphologyElement.idl:
  • svg/SVGFETurbulenceElement.idl:
  • svg/SVGGradientElement.idl:
  • xml/XMLHttpRequestException.idl:
  • xml/XPathException.idl:
17:58 Changeset [106888] by commit-queue@webkit.org

WebGL must allocate smaller drawing buffer when the allocation fails.
https://bugs.webkit.org/show_bug.cgi?id=76654

Patch by Yongsheng Zhu <yongsheng.zhu@intel.com> on 2012-02-06
Reviewed by Kenneth Russell.

Test: fast/canvas/webgl/drawingbuffer-test.html

  • platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore):
(WebCore::DrawingBuffer::create):
(WebCore::DrawingBuffer::reset):

17:42 Changeset [106887] by jchaffraix@webkit.org

Unreviewed gardening.

  • DEPS: Rolling the DEPS to get the apple_webkit update

and fix the Chromium build.

17:39 Changeset [106886] by dgrogan@chromium.org

Port some indexeddb layout tests to workers.
https://bugs.webkit.org/show_bug.cgi?id=77805

Reviewed by Tony Chang.

  • storage/indexeddb/index-basics-workers-expected.txt: Added.
  • storage/indexeddb/index-basics-workers.html: Added.
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics-workers-expected.txt: Added.
  • storage/indexeddb/objectstore-basics-workers.html: Added.
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/resources/index-basics.js: Copied from LayoutTests/storage/indexeddb/index-basics.html.

(test):
(setVersion):
(deleteExisting):
(addData):
(addData2):
(addData3):
(getData):
(getObjectData):
(getObjectData2):
(getObjectData3):
(getDataFail):
(getObjectDataFail):
(getObjectData4):
(openKeyCursor):
(cursor1Continue):
(cursor1Continue2):
(cursor1Continue3):
(openObjectCursor):
(cursor2Continue):
(cursor2Continue2):
(cursor2Continue3):
(last.try.get testFailed):
(last):

  • storage/indexeddb/resources/objectstore-basics.js: Copied from LayoutTests/storage/indexeddb/objectstore-basics.html.

(test):
(openSuccess):
(setVersionSuccess):
(createIndex):
(testSetVersionAbort):
(createAnotherIndex):
(checkMetadata):
(addData):
(addDateSuccess):
(addSuccess):
(addAgainFailure):
(getSuccess):
(getSuccessDateKey):
(removeSuccess):
(removeSuccessButFalse):
(testPreConditions.request.onsuccess):
(testPreConditions):

17:37 Changeset [106885] by haraken@chromium.org

Unreviewed. Rebaselined run-bindings-tests results.

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::optionsObjectCallback):

17:36 Changeset [106884] by leviw@chromium.org

Correct usage of LayoutUnits in dom, editing, page, accessibility, inspector, and loader
https://bugs.webkit.org/show_bug.cgi?id=77891

Reviewed by Darin Adler.

Updating the usage of LayoutUnits in the dom, editing, page, accessibility, inspector, and loader
directories to properly use LayoutUnits vs ints.

No new tests. No new behavior.

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::boundsForVisiblePositionRange):
(WebCore::AccessibilityObject::doAXBoundsForRange):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isOffScreen):
(WebCore::AccessibilityRenderObject::clickPoint):
(WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange):
(WebCore::AccessibilityRenderObject::doAXBoundsForRange):
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::elementAccessibilityHitTest):

  • accessibility/AccessibilitySlider.h:

(AccessibilitySlider):

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityShowContextMenu]):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::computedTransform):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • dom/Clipboard.h:

(WebCore::Clipboard::dragLocation):
(Clipboard):

  • dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::renderedRectsForMarkers):

  • dom/DocumentMarkerController.h:
  • dom/Element.cpp:

(WebCore::Element::screenRect):

  • dom/Element.h:

(Element):

  • editing/Editor.cpp:

(WebCore::Editor::rangeForPoint):
(WebCore::Editor::firstRectForRange):

  • editing/RenderedPosition.cpp:

(WebCore::RenderedPosition::absoluteRect):

  • editing/RenderedPosition.h:

(WebCore::RenderedPosition::absoluteRect):
(RenderedPosition):

  • editing/VisiblePosition.h:

(VisiblePosition):

  • inspector/DOMNodeHighlighter.cpp:
  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::createJavaAppletWidget):

  • loader/SubframeLoader.h:

(SubframeLoader):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEvent):

  • page/Frame.cpp:

(WebCore::Frame::nodeImage):

  • page/win/FrameCGWin.cpp:

(WebCore::Frame::nodeImage):

17:33 Changeset [106883] by haraken@chromium.org

Rename [DontCheckEnums], [ReturnsNew], [DoNotCheckDomainSecurityOnGet],
[DoNotCheckDomainSecurityOnSet] and [ImplementationFunction] IDLs
https://bugs.webkit.org/show_bug.cgi?id=77852

Reviewed by Adam Barth.

This patch renames [DontCheckEnums], [ReturnsNew], [DoNotCheckDomainSecurityOnGet],
[DoNotCheckDomainSecurityOnSet] and [ImplementationFunction] IDLs for clarification.

[DontCheckEnums] => [DoNotCheckConstants] (This IDL inserts assertions to check if a
constant value is equal to the expected constant value)
[ReturnsNew] => [ReturnNewObject] (For clarification)
[DoNotCheckDomainSecurityOnGet] => [DoNotCheckDomainSecurityOnGetter] (For naming consistency
with other [*Getter] IDLs)
[DoNotCheckDomainSecurityOnSet] => [DoNotCheckDomainSecurityOnSetter] (For naming consistency
with other [*Setter] IDLs)
[ImplementationFunction=] => [ImplementedAs=] (For clarification. This IDL specifies a method
name in implementation)

No tests. No change in behavior.

  • bindings/scripts/CodeGenerator.pm:

(ShouldCheckEnums):
(GenerateCompileTimeCheckForEnumsIfNeeded):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
(NativeToJSValue):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateSingleBatchedAttribute):
(GenerateFunctionCallString):
(NativeToJSValue):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/TestTypedArray.idl:
  • bindings/scripts/test/JS/JSTestInterface.cpp: Updated run-bindings-tests results.

(WebCore):

  • bindings/scripts/test/JS/JSTestObj.cpp: Ditto.

(WebCore):

  • bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.

(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp: Ditto.

(WebCore):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/TestTypedArray.idl:
  • css/WebKitCSSFilterValue.idl:
  • css/WebKitCSSTransformValue.idl:
  • dom/DOMCoreException.idl:
  • dom/Document.idl:
  • dom/EventException.idl:
  • dom/RangeException.idl:
  • fileapi/FileException.idl:
  • fileapi/OperationNotAllowedException.idl:
  • html/HTMLFormElement.idl:
  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/OESStandardDerivatives.idl:
  • html/canvas/OESVertexArrayObject.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • html/canvas/Uint8ClampedArray.idl:
  • html/canvas/WebGLCompressedTextures.idl:
  • html/canvas/WebGLDebugRendererInfo.idl:
  • html/canvas/WebGLRenderingContext.idl:
  • inspector/JavaScriptCallFrame.idl:
  • loader/appcache/DOMApplicationCache.idl:
  • page/Console.idl:
  • page/DOMWindow.idl:
  • page/Location.idl:
  • storage/IDBCursor.idl:
  • storage/IDBDatabaseException.idl:
  • storage/IDBObjectStore.idl:
  • storage/SQLException.idl:
  • svg/SVGComponentTransferFunctionElement.idl:
  • svg/SVGException.idl:
  • svg/SVGFEBlendElement.idl:
  • svg/SVGFEColorMatrixElement.idl:
  • svg/SVGFECompositeElement.idl:
  • svg/SVGFEConvolveMatrixElement.idl:
  • svg/SVGFEDisplacementMapElement.idl:
  • svg/SVGFEMorphologyElement.idl:
  • svg/SVGFETurbulenceElement.idl:
  • svg/SVGGradientElement.idl:
  • xml/XMLHttpRequestException.idl:
17:30 Changeset [106882] by commit-queue@webkit.org

RenderSVGShape::strokeContains will fail for some strokes
https://bugs.webkit.org/show_bug.cgi?id=76931

Patch by Stephen Chenney <schenney@chromium.org> on 2012-02-06
Reviewed by Darin Adler.

Source/WebCore:

Adding support for rounded zero-length endcaps for SVG path hit
testing.

Tests: svg/hittest/zero-length-butt-cap-path.xhtml

svg/hittest/zero-length-round-cap-path.xhtml
svg/hittest/zero-length-square-cap-path.xhtml

  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::strokeContains):

LayoutTests:

New tests for hit testing against an SVG path of zero length with
endcaps.

  • svg/hittest/zero-length-butt-cap-path-expected.txt: Added.
  • svg/hittest/zero-length-butt-cap-path.xhtml: Added.
  • svg/hittest/zero-length-round-cap-path-expected.txt: Added.
  • svg/hittest/zero-length-round-cap-path.xhtml: Added.
  • svg/hittest/zero-length-square-cap-path-expected.txt: Added.
  • svg/hittest/zero-length-square-cap-path.xhtml: Added.
17:20 WebKit Team edited by igor.oliveira@openbossa.org
(diff)
17:14 WebKitGTK/1.6.x edited by mrobinson@webkit.org
(diff)
17:09 Changeset [106881] by commit-queue@webkit.org

Add webGLErrorsToConsoleEnabled Settings flag
https://bugs.webkit.org/show_bug.cgi?id=77696

Patch by Gregg Tavares <gman@google.com> on 2012-02-06
Reviewed by Kenneth Russell.

No new tests as there is no change in behavior.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::setupFlags):

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(Settings):
(WebCore::Settings::webGLErrorsToConsoleEnabled):

17:07 Changeset [106880] by eae@chromium.org

Convert PopupMenuClient::clientPadding over to new layout abstraction
https://bugs.webkit.org/show_bug.cgi?id=77798

Reviewed by Eric Seidel.

Change PopupMenuClient and all classes inheriting from it to use the new
layout types for padding.

Source/WebCore:

No new tests.

  • platform/PopupMenuClient.h:

(PopupMenuClient):

  • rendering/RenderMenuList.h:
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::clientPaddingLeft):
(WebCore::RenderTextControlSingleLine::clientPaddingRight):

  • rendering/RenderTextControlSingleLine.h:

Source/WebKit/chromium:

  • src/AutofillPopupMenuClient.cpp:

(WebKit::AutofillPopupMenuClient::clientPaddingLeft):
(WebKit::AutofillPopupMenuClient::clientPaddingRight):

  • src/AutofillPopupMenuClient.h:

(AutofillPopupMenuClient):

  • tests/PopupMenuTest.cpp:

(WebKit::TestPopupMenuClient::clientPaddingLeft):
(WebKit::TestPopupMenuClient::clientPaddingRight):

17:07 Changeset [106879] by fpizlo@apple.com

ValueToNumber and ValueToDouble nodes don't do anything and should be removed
https://bugs.webkit.org/show_bug.cgi?id=77855
<rdar://problem/10811325>

Reviewed by Gavin Barraclough.

Removed ValueToNumber and ValueToDouble, because the only thing they were doing
was wasting registers.

This looks like a 1% win on V8 (with a 5% win on crypto) and a 2-3% win on Kraken,
mostly due to a >10% win on gaussian-blur. No win anywhere else.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getToInt32):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGNode.h:

(DFG):
(JSC::DFG::Node::hasArithNodeFlags):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::vote):
(JSC::DFG::Propagator::doRoundOfDoubleVoting):
(Propagator):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::canonicalize):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

16:55 Changeset [106878] by commit-queue@webkit.org

Fix color animations by value
https://bugs.webkit.org/show_bug.cgi?id=77812

Patch by Philip Rogers <pdr@google.com> on 2012-02-06
Reviewed by Darin Adler.

Source/WebCore:

Test: svg/animations/animate-color-fill-from-by.html

  • svg/SVGAnimatedColor.cpp:

(WebCore::SVGAnimatedColorAnimator::calculateFromAndByValues):

LayoutTests:

  • svg/animations/animate-color-fill-from-by-expected.txt: Added.
  • svg/animations/animate-color-fill-from-by.html: Added.
  • svg/animations/script-tests/animate-color-fill-from-by.js: Added.

(checkFillColor):
(sample1):
(sample2):
(sample3):
(executeTest):

16:53 Changeset [106877] by kov@webkit.org

Do not try to chdir to the directory where the executable is in
only if the path is absolute. This makes tests runnable from
anywhere.

Reviewed by Martin Robinson.

  • tests/test_utils.c:

(testutils_relative_chdir):

16:52 Changeset [106876] by jer.noble@apple.com

REGRESSION (r104303): Clicking inline video controls gives the video a focus ring
https://bugs.webkit.org/show_bug.cgi?id=77288

Reviewed by Darin Adler.

Source/WebCore:

Test: media/video-mouse-focus.html

Do not allow media elements to be focused by mouse click by overriding isMouseFocusable
and returning false.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::isMouseFocusable):

  • html/HTMLMediaElement.h:

LayoutTests:

  • media/video-mouse-focus-expected.txt: Added.
  • media/video-mouse-focus.html: Added.
16:43 Changeset [106875] by andersca@apple.com

Source/WebCore: Overlay scrollbars flash when window is simply activated
https://bugs.webkit.org/show_bug.cgi?id=77911
<rdar://problem/10211995>

Reviewed by Kenneth Russell.

Add a new member function, FocusController::setContainingWindowIsVisible, and move the code
that calls ScrollableArea::contentAreaDidShow/ScrollableArea::contentAreaDidHide there, since
we only want to flash scrollers when the window becomes visible.

  • WebCore.exp.in:
  • page/FocusController.cpp:

(WebCore::FocusController::FocusController):
(WebCore::FocusController::setActive):
(WebCore::FocusController::setContainingWindowIsVisible):
(WebCore):

  • page/FocusController.h:

(FocusController):
(WebCore::FocusController::containingWindowIsVisible):

  • platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollbarPainterControllerDelegate scrollerImpPair:setContentAreaNeedsDisplayInRect:]):
Call ScrollAnimatorMac::contentAreaWillPaint here, since that will trigger AppKit to flash the scrollers.

Source/WebKit/mac: Overlay scrollbars flash when window is simply activated
https://bugs.webkit.org/show_bug.cgi?id=77911
<rdar://problem/10211995>

Reviewed by Kenneth Russell.

  • WebView/WebView.mm:

(-[WebView _windowWillOrderOnScreen:]):
(-[WebView _windowWillOrderOffScreen:]):
Call FocusController::setContainingWindowIsVisible.

Source/WebKit2: Overlay scrollbars flash when window is simply activated
https://bugs.webkit.org/show_bug.cgi?id=77911

Reviewed by Kenneth Russell.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _updateWindowVisibility]):
Use -[NSWindow isVisible] here, since we also want to consider the window hidden if the application itself is hidden.

(-[WKView _windowDidOrderOffScreen:]):
(-[WKView _windowDidOrderOnScreen:]):
Call -[WKView updateWindowVisibility].

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setWindowIsVisible):
Call FocusController::setContainingWindowIsVisible.

16:41 Changeset [106874] by commit-queue@webkit.org

postMessage leaks MemoryEvent object
https://bugs.webkit.org/show_bug.cgi?id=77893

Patch by Greg Simon <gregsimon@chromium.org> on 2012-02-06
Reviewed by Adam Barth.

Changed from PassRefPtr().leakRef() to RefPtr.get() when
calling into FrameLoaderClient to stop +1 extra ref.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessageTimerFired):

16:38 Changeset [106873] by commit-queue@webkit.org

WebGL conformance test misc/functions-returning-strings.html fails
https://bugs.webkit.org/show_bug.cgi?id=77149

Source/WebCore:

Make sure that WebGL methods returning strings don't return null when
they run successfully.

Patch by Ehsan Akhgari <ehsan.akhgari@gmail.com> on 2012-02-06
Reviewed by Kenneth Russell.

Test: fast/canvas/webgl/functions-returning-strings.html

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::getProgramInfoLog):
(WebCore::WebGLRenderingContext::getShaderInfoLog):
(WebCore::WebGLRenderingContext::getShaderSource):
(WebCore::WebGLRenderingContext::ensureNotNull):

  • html/canvas/WebGLRenderingContext.h:

(WebGLRenderingContext):

LayoutTests:

Imported the WebGL conformance test related to this.

Patch by Ehsan Akhgari <ehsan.akhgari@gmail.com> on 2012-02-06
Reviewed by Kenneth Russell.

  • fast/canvas/webgl/functions-returning-strings-expected.txt: Added.
  • fast/canvas/webgl/functions-returning-strings.html: Added.
16:34 Changeset [106872] by enrica@apple.com

Refactor Mac platform implementation of the Pasteboard class.
https://bugs.webkit.org/show_bug.cgi?id=77567

The goal of this change is to remove the majority of the methods in
the class interface that are Mac specific.
writeSelectionForTypes has been left to support OS X services.
Some of the methods have been turned into static functions.
The method asURL was being used only by the DragData class and its
implementation has been moved there.
This is a first step in the direction of removing NSPasteboard access from
the WebProcess for WebKit2 (https://bugs.webkit.org/show_bug.cgi?id=77259)
leaving the WebKit1 behavior unchanged.

Reviewed by Alexey Proskuryakov.

No new tests. No changes in behavior.

  • platform/Pasteboard.h: Removed most of the Mac specific methods.
  • platform/mac/ClipboardMac.mm:

(WebCore::ClipboardMac::writeRange):
(WebCore::ClipboardMac::writeURL):

  • platform/mac/DragDataMac.mm:

(WebCore::DragData::asURL): Moved code from PasteboardMac.mm. Removed FIXME
because we only want to handle the case of single file, otherwise the user
doesn't know which of the files has been chosen.

  • platform/mac/PasteboardMac.mm:

(WebCore::writeURLForTypes):
(WebCore::Pasteboard::writeURL):
(WebCore::writeFileWrapperAsRTFDAttachment): Now a static function.
(WebCore::Pasteboard::writeImage):
(WebCore::documentFragmentWithImageResource): Ditto.
(WebCore::documentFragmentWithRTF): Ditto.
(WebCore::Pasteboard::documentFragment):

16:30 Changeset [106871] by crogers@google.com

Merge 106864 - zvmul incorrectly multiplies complex arrays on Windows.
https://bugs.webkit.org/show_bug.cgi?id=77900

TBR=crogers@google.com
Review URL: https://chromiumcodereview.appspot.com/9350003

16:25 Changeset [106870] by jamesr@google.com

[chromium] Drop tiles completely outside of layer bounds when resizing to a smaller size
https://bugs.webkit.org/show_bug.cgi?id=77910

Reviewed by Kenneth Russell.

Source/WebCore:

When resizing a tiled layer to a smaller size, drop all tiles that lie completely outside the new layer bounds.
This avoids attempting to access out-of-bounds tiles when iterating over all tiles in the tiler, which triggers
ASSERT()s, as well as saves some memory.

New unit test added to TiledLayerChromiumTest.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::invalidateRect):

  • platform/graphics/chromium/cc/CCLayerTilingData.cpp:

(WebCore::CCLayerTilingData::setBounds):

Source/WebKit/chromium:

Adds test for resizing a layer to cover fewer tiles. Test hits ASSERT()s without any code changes.

  • tests/TiledLayerChromiumTest.cpp:

(::TEST):

16:14 Changeset [106869] by leviw@chromium.org

Reverting RenderFrameSet's canResizeRow/Column to operate on IntPoints.

16:09 Changeset [106868] by leviw@chromium.org

Call intValue on grid lengths instead of explicitly operating on floats when we only use integer precision for FrameSets.

16:08 Changeset [106867] by rniwa@webkit.org

Revert r106859. It was completely bogus.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::doPixelReadbackToCanvas):

16:00 Changeset [106866] by leviw@chromium.org

Fix pixel snapping logic for FrameSets. This is for code correctness, but would never actually lead to incorrect renderings.

15:44 Changeset [106865] by morrita@google.com

[PerformanceTests] Each Dromaeo test needs its landing html.
https://bugs.webkit.org/show_bug.cgi?id=77504

Reviewed by Ryosuke Niwa.

PerformanceTests:

  • Added landing pages for each test which are listed in MANIFEST.json
  • Removed some tests which depends on the library whose license is incompatible to WebKit.
  • Added local copy of corresponding library. And replace the references to the remote sources to the local copies.
  • Removed old library files under Dromaeo/resources/dromaeo/web/lib/.
  • Skipped Sunsupier and v8 test. Such JS centric test should have its own test instead of running as a part of Dromaeo.
  • Dromaeo/cssquery-dojo.html: Added.
  • Dromaeo/cssquery-jquery.html: Added.
  • Dromaeo/cssquery-prototype.html: Added.
  • Dromaeo/dom-attr.html: Added.
  • Dromaeo/dom-modify.html: Added.
  • Dromaeo/dom-traverse.html: Added.
  • Dromaeo/dromaeo-3d-cube.html: Added.
  • Dromaeo/dromaeo-core-eval.html: Added.
  • Dromaeo/dromaeo-object-array.html: Added.
  • Dromaeo/dromaeo-object-regexp.html: Added.
  • Dromaeo/dromaeo-object-string.html: Added.
  • Dromaeo/dromaeo-string-base64.html: Added.
  • Dromaeo/jslib-attr-jquery.html: Added.
  • Dromaeo/jslib-attr-prototype.html: Added.
  • Dromaeo/jslib-event-jquery.html: Added.
  • Dromaeo/jslib-event-prototype.html: Added.
  • Dromaeo/jslib-modify-jquery.html: Added.
  • Dromaeo/jslib-modify-prototype.html: Added.
  • Dromaeo/jslib-style-jquery.html: Added.
  • Dromaeo/jslib-style-prototype.html: Added.
  • Dromaeo/jslib-traverse-jquery.html: Added.
  • Dromaeo/jslib-traverse-prototype.html: Added.
  • Dromaeo/resources/dromaeo/web/lib/dojo.js: Removed.
  • Dromaeo/resources/dromaeo/web/lib/dojo-1.6.1.js: Added.
  • Dromaeo/resources/dromaeo/web/lib/jquery.js: Removed.
  • Dromaeo/resources/dromaeo/web/lib/jquery-1.6.4.js: Added.
  • Dromaeo/resources/dromaeo/web/lib/mootools.js: Removed.
  • Dromaeo/resources/dromaeo/web/lib/prototype.js: Removed.
  • Dromaeo/resources/dromaeo/web/lib/prototype-1.7.js: Added.
  • Dromaeo/resources/dromaeo/web/tests/cssquery-dojo.html:
  • Dromaeo/resources/dromaeo/web/tests/cssquery-jquery.html:
  • Dromaeo/resources/dromaeo/web/tests/cssquery-mootools.html: Removed.
  • Dromaeo/resources/dromaeo/web/tests/cssquery-prototype.html:
  • Dromaeo/resources/dromaeo/web/tests/jslib-attr-jquery.html:
  • Dromaeo/resources/dromaeo/web/tests/jslib-attr-prototype.html:
  • Dromaeo/resources/dromaeo/web/tests/jslib-event-jquery.html:
  • Dromaeo/resources/dromaeo/web/tests/jslib-event-prototype.html:
  • Dromaeo/resources/dromaeo/web/tests/jslib-modify-jquery.html:
  • Dromaeo/resources/dromaeo/web/tests/jslib-modify-prototype.html:
  • Dromaeo/resources/dromaeo/web/tests/jslib-style-jquery.html:
  • Dromaeo/resources/dromaeo/web/tests/jslib-style-prototype.html:
  • Dromaeo/resources/dromaeo/web/tests/jslib-traverse-jquery.html:
  • Dromaeo/resources/dromaeo/web/tests/jslib-traverse-prototype.html:
  • Dromaeo/sunspider-3d-morph.html: Added.
  • Dromaeo/sunspider-3d-raytrace.html: Added.
  • Dromaeo/sunspider-access-binary-trees.html: Added.
  • Dromaeo/sunspider-access-fannkuch.html: Added.
  • Dromaeo/sunspider-access-nbody.html: Added.
  • Dromaeo/sunspider-access-nsieve.html: Added.
  • Dromaeo/sunspider-bitops-3bit-bits-in-byte.html: Added.
  • Dromaeo/sunspider-bitops-bits-in-byte.html: Added.
  • Dromaeo/sunspider-bitops-bitwise-and.html: Added.
  • Dromaeo/sunspider-bitops-nsieve-bits.html: Added.
  • Dromaeo/sunspider-controlflow-recursive.html: Added.
  • Dromaeo/sunspider-crypto-aes.html: Added.
  • Dromaeo/sunspider-crypto-md5.html: Added.
  • Dromaeo/sunspider-crypto-sha1.html: Added.
  • Dromaeo/sunspider-date-format-tofte.html: Added.
  • Dromaeo/sunspider-date-format-xparb.html: Added.
  • Dromaeo/sunspider-math-cordic.html: Added.
  • Dromaeo/sunspider-math-partial-sums.html: Added.
  • Dromaeo/sunspider-math-spectral-norm.html: Added.
  • Dromaeo/sunspider-regexp-dna.html: Added.
  • Dromaeo/sunspider-string-fasta.html: Added.
  • Dromaeo/sunspider-string-tagcloud.html: Added.
  • Dromaeo/sunspider-string-unpack-code.html: Added.
  • Dromaeo/sunspider-string-validate-input.html: Added.
  • Dromaeo/v8-crypto.html: Added.
  • Dromaeo/v8-deltablue.html: Added.
  • Dromaeo/v8-earley-boyer.html: Added.
  • Dromaeo/v8-raytrace.html: Added.
  • Dromaeo/v8-richards.html: Added.
  • Skipped:

Tools:

Added an ignorable pattern which happens in some Dromaeo tests.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner):

15:23 Changeset [106864] by crogers@google.com

zvmul incorrectly multiplies complex arrays on Windows.
https://bugs.webkit.org/show_bug.cgi?id=77900

Reviewed by Kenneth Russell.

Source/WebCore:

  • platform/audio/VectorMath.cpp:

(WebCore::VectorMath::zvmul):

LayoutTests:

  • platform/chromium/test_expectations.txt:
15:14 Changeset [106863] by kling@webkit.org

REGRESSION(r106756): 10% performance hit on DOM/Template.
<http://webkit.org/b/77831>

Reviewed by Ryosuke Niwa.

Let the StylePropertySet used for element attribute style have the element as its parent.
This is accomplished by adding an m_parentIsElement bit to StylePropertySet and sharing
some of the internal logic with inline styles.

In the end, this means that CSSParser will now pick up the document's CSSValuePool when
parsing properties for attribute styles, which fixes the perf regression from r106756.

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::contextStyleSheet):

Find contextStyleSheet via the parentElement() when there is one.

(WebCore::StylePropertySet::setNeedsStyleRecalc):

Always set FullStyleChange for attribute style mutations. We can probably use the
same lighter invalidation as inline styles, but that's a topic for another patch.

  • css/StylePropertySet.h:

(WebCore::StylePropertySet::createInline):
(WebCore::StylePropertySet::createAttributeStyle):
(WebCore::StylePropertySet::parentRuleInternal):
(WebCore::StylePropertySet::clearParentRule):
(StylePropertySet):
(WebCore::StylePropertySet::parentElement):
(WebCore::StylePropertySet::clearParentElement):

Added m_parentIsElement bit and update assertions as appropriate to not just
cover the inline style case. Added a createAttributeStyle() helper to create
a StylePropertySet for use as Element::attributeStyle().

  • dom/StyledElement.h:
  • dom/ElementAttributeData.h:
  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::ensureAttributeStyle):

Use StylePropertySet::createAttributeStyle().

  • dom/StyledElement.cpp:

(WebCore::StyledElement::removeCSSProperties):
(WebCore::StyledElement::addCSSProperty):
(WebCore::StyledElement::addCSSImageProperty):

Remove setNeedsStyleRecalc() calls since that is now handled automatically by
StylePropertySet's mutation methods.

15:10 Changeset [106862] by haraken@chromium.org

In AppleWebKit, stop rebuilding IDLs that need not to be rebuilt
https://bugs.webkit.org/show_bug.cgi?id=77510

Reviewed by Adam Barth.

Currently, if any IDL file is updated, all IDL files are rebuilt.
This patch stops rebuilding IDL files which are not modified nor
whose supplemental dependencies are not changed.

The new build flow is as follows:

supplemental.dep : $(ALL_IDLS)

perl resolve-supplemental.pl ...

%.idl-needs-rebuild : %.idl supplemental.dep

perl update-idl-needs-rebuild.pl ...

JS%.cpp : %.idl-needs-rebuild

perl generate-bindings.pl ...

resolve-supplemental.pl generates the following supplemental.dep.
The number in () is the last access timestamp of the file.

A.idl(1200)
B.idl(1000) B-supplemental1.idl(800) B-supplemental2.idl(1200)
C.idl(1000)

update-idl-needs-rebuild.pl for X.idl touches X.idl-needs-rebuild,
if X.idl-needs-rebuild is older than X.idl or the IDL files which are
supplementing X.idl. For example, if the timestamps of A.idl-needs-rebuild,
B.idl-needs-rebuild and C.idl-needs-rebuild are all 1000, then A.idl-needs-rebuild
and B.idl-needs-rebuild will be touched.

Even if no IDL files are modified, update-idl-needs-rebuild.pl can run for all IDL files,
but generate-bindings.pl won't run. If any IDL file is updated, resolve-supplemental.pl
will run once, update-idl-needs-rebuild.pl will run for all IDL files, and
generate-bindings.pl will run for the IDL files which are modified or whose
dependencies are changed.

No tests. I manually confirmed the followings:

  • Touch Element.idl, then only Element.idl is rebuilt
  • Touch DOMWindow.idl, then only DOMWindow.idl is rebuilt
  • Touch DOMWindowWebAudio.idl, then only DOMWindow.idl and DOMWindowWebAudio.idl are rebuilt
  • DerivedSources.make: Modified the build flow as described above.
  • bindings/scripts/generate-bindings.pl: Modified to read an IDL file path from .idl-needs-rebuild.
  • bindings/scripts/update-idl-needs-rebuild.pl: Added. Touches X.idl-needs-rebuild if

the X.idl-needs-rebuild is older than X.idl or the IDL files which are supplementing X.idl.
(touch):

15:10 Changeset [106861] by commit-queue@webkit.org

Unreviewed, chromium expectations update.
Layout Test http/tests/media/video-served-as-text.html is flaky on cr-win
https://bugs.webkit.org/show_bug.cgi?id=72904

Test is not flaky on XP.

Patch by Ami Fischman <fischman@chromium.org> on 2012-02-06

  • platform/chromium/test_expectations.txt:
15:08 Changeset [106860] by mdelaney@apple.com

Windows build fix

15:02 Changeset [106859] by rniwa@webkit.org

Chromium build fix after r106836.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::doPixelReadbackToCanvas):

15:00 Changeset [106858] by commit-queue@webkit.org

AudioBus need to support stereo->mono down mix in copyFrom sumFrom etc.
https://bugs.webkit.org/show_bug.cgi?id=77609

Patch by Wei James <james.wei@intel.com> on 2012-02-06
Reviewed by Kenneth Russell.

Test: webaudio/stereo2mono-down-mixing.html

  • platform/audio/AudioBus.cpp:

(WebCore):
(WebCore::AudioBus::copyFrom):
(WebCore::AudioBus::sumFrom):

14:55 Changeset [106857] by jsbell@chromium.org

[Chromium] storage/indexeddb/index-cursor.html timeouts on Mac Debug
https://bugs.webkit.org/show_bug.cgi?id=65862

No sign of this test timing out in recent history, and significant
performance work has been done since it was filed. Unmarking as SLOW/PASS.

Reviewed by Tony Chang.

  • platform/chromium/test_expectations.txt:
14:54 Changeset [106856] by ericu@chromium.org

[filesystem/Chromium] crackFileSystemURL needs to use innerURL
https://bugs.webkit.org/show_bug.cgi?id=77881

Reviewed by Adam Barth.

  • src/AsyncFileSystemChromium.cpp:

(WebCore::AsyncFileSystem::crackFileSystemURL):
Add the new code path, taken only if innerURL is present.

14:39 Changeset [106855] by jchaffraix@webkit.org

Unreviewed gardening.

More font differences that need a rebaseline.

  • platform/chromium-linux-x86/fast/canvas/check-stale-putImageData-expected.png: Removed.
  • platform/chromium-linux/fast/canvas/check-stale-putImageData-expected.png: Added.
  • platform/chromium-win/fast/canvas/check-stale-putImageData-expected.png: Added.
14:35 Changeset [106854] by commit-queue@webkit.org

[Chromium] rebaseline test on win/mac after enabling paint opaque tracking for draw culling
https://bugs.webkit.org/show_bug.cgi?id=77497

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-06
Reviewed by James Robinson.

  • platform/chromium-win/fast/repaint/block-selection-gap-in-composited-layer-expected.png: Added.
  • platform/chromium/test_expectations.txt:
14:32 Changeset [106853] by abarth@webkit.org

http/tests/security/mixedContent/insecure-plugin-in-iframe.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=77901

Reviewed by Eric Seidel.

This test fails occationally because of the order of the frame load
callbacks. Now that we log mixed content errors to the console, we
don't need to dump the frame load callbacks in this test.

  • http/tests/security/mixedContent/insecure-plugin-in-iframe-expected.txt:
  • http/tests/security/mixedContent/insecure-plugin-in-iframe.html:
14:30 Changeset [106852] by cdn@chromium.org

Source/WebCore: Add RefPtrs for parent and sibling counter nodes
https://bugs.webkit.org/show_bug.cgi?id=75212

Reviewed by Adam Barth.

Test: fast/css/counters/reparent-table-children-with-counters-crash.html

  • rendering/RenderCounter.cpp:

(WebCore::findPlaceForCounter):
(WebCore::makeCounterNode):
(WebCore::updateCounters):

LayoutTests: Test for crash when counter nodes are reparented outside of tables
https://bugs.webkit.org/show_bug.cgi?id=75212

Reviewed by Adam Barth.

  • fast/css/counters/reparent-table-children-with-counters-crash-expected.txt: Added.
  • fast/css/counters/reparent-table-children-with-counters-crash.html: Added.
14:26 Changeset [106851] by kov@webkit.org

Unreviewed fix for the new API test that is failing -
WEBKIT_INSPECTOR_PATH needs to be set, since we do not install our
builds.

  • tests/testwebinspector.c:

(main):

14:17 Changeset [106850] by mdelaney@apple.com

Fix for burning SL tree

14:17 Changeset [106849] by abarth@webkit.org

According to the flakiness dashboard, these tests do appear to be
successfully de-flaked.

  • platform/chromium/test_expectations.txt:
14:16 LayoutUnit created by eae@chromium.org
Added initial draft of wiki page explaining LayoutUnits.
14:06 Changeset [106848] by jochen@chromium.org

Merge 106846 - Before accessing a frame's script controller in V8 bindings, first check that the frame actually exists
https://bugs.webkit.org/show_bug.cgi?id=77370

Reviewed by Adam Barth.

I don't have a working reproduction of the crash yet. As soon as I have
one, I will add new layout tests.

  • bindings/v8/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::addListener):

  • bindings/v8/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute):

  • bindings/v8/ScriptCachedFrameData.cpp:

(WebCore::ScriptCachedFrameData::restore):

  • page/DOMTimer.cpp:

(WebCore::DOMTimer::DOMTimer): remove temporary debug code
Review URL: https://chromiumcodereview.appspot.com/9340005

13:59 Changeset [106847] by commit-queue@webkit.org

[GTK] Add missing pango include dir to fix build
https://bugs.webkit.org/show_bug.cgi?id=77832

Patch by Kalev Lember <kalevlember@gmail.com> on 2012-02-06
Reviewed by Martin Robinson.

Source/WebCore:

  • GNUmakefile.am: Added $(PANGO_CFLAGS) to libWebCore_la_CPPFLAGS.

Tools:

  • GNUmakefile.am: Added $(PANGO_CFLAGS) to libWebCoreInternals_la_CPPFLAGS.
13:55 Changeset [106846] by jochen@chromium.org

Before accessing a frame's script controller in V8 bindings, first check that the frame actually exists
https://bugs.webkit.org/show_bug.cgi?id=77370

Reviewed by Adam Barth.

I don't have a working reproduction of the crash yet. As soon as I have
one, I will add new layout tests.

  • bindings/v8/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::addListener):

  • bindings/v8/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute):

  • bindings/v8/ScriptCachedFrameData.cpp:

(WebCore::ScriptCachedFrameData::restore):

  • page/DOMTimer.cpp:

(WebCore::DOMTimer::DOMTimer): remove temporary debug code

13:43 Changeset [106845] by senorblanco@chromium.org

Merge 104501 - [chromium win] Creating lots of temporary canvas contexts will crash.
https://bugs.webkit.org/show_bug.cgi?id=68420

When using the skia port, the allocation of 2d canvas backing stores
no longer needs to be done through a platform API (GDI/CG) because
canvases now use skia for drawing text. Removing the allocation through
GDI on windows prevents resource exhaustion due to unreferenced canvases
that are awaiting garbage collection.

Patch by Justin Novosad <junov@chromium.org> on 2012-01-09
Reviewed by Stephen White.

No new tests: Relying on existing canvas layout tests.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::createImageBuffer):

  • platform/graphics/ImageBuffer.h:
  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::createNonPlatformCanvas):
(WebCore::ImageBuffer::ImageBuffer):

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9340004

13:39 Changeset [106844] by jchaffraix@webkit.org

Unreviewed rebaseline after r106836.

The rebaseline is caused by a font difference.

  • platform/chromium-linux-x86/fast/canvas/check-stale-putImageData-expected.png: Added.
13:34 Changeset [106843] by mdelaney@apple.com

Correcting the version of WKSI committed in r106836

13:25 Changeset [106842] by jsbell@chromium.org

Unreviewed chromium test expectation change

Unmarking storage/indexeddb/data-corruption.html as TIMEOUT. Was apparently
bulk-marked as TIMEOUT on Snow Leopard as part of WK54322 although it is
not mentioned in that issue. The test hasn't failed in recent history and
there has been substantial rework on the IndexedDB feature since the
expectation was set.

  • platform/chromium/test_expectations.txt:
13:19 Changeset [106841] by shawnsingh@chromium.org

Merge 106459 - Fix the semantics of passing contentsVisible flag to GraphicsLayers
https://bugs.webkit.org/show_bug.cgi?id=76975

Reviewed by Simon Fraser.

Source/WebCore:

This patch is covered by existing tests, in particular
compositing/visibility/layer-visible-content.html; its
expectations are rebaselined.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

LayoutTests:

  • compositing/visibility/layer-visible-content-expected.txt: rebaselined expected result
  • compositing/visibility/layer-visible-content.html: fixed height so that result is platform-independent
  • platform/chromium/test_expectations.txt: removed fail expectation, it should pass now.

TBR=shawnsingh@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9342003

13:17 Changeset [106840] by jamesr@google.com

Source/WebCore: Support detaching TextureManager from ManagedTexture
https://bugs.webkit.org/show_bug.cgi?id=77655

Reviewed by Kenneth Russell.
Initial patch by Alok Priyadarshi.

TextureManager now holds references to the textures it manages.
This allows TextureManager to inform managed textures when it gets deleted
so that the texture that outlive the TextureManager can handle the situation gracefully.

Unit test in TextureManagerTest.cpp

  • platform/graphics/chromium/ManagedTexture.cpp:

(WebCore::ManagedTexture::ManagedTexture):
(WebCore::ManagedTexture::~ManagedTexture):
(WebCore):
(WebCore::ManagedTexture::managerWillDie):
(WebCore::ManagedTexture::isValid):
(WebCore::ManagedTexture::reserve):
(WebCore::ManagedTexture::unreserve):
(WebCore::ManagedTexture::steal):
(WebCore::ManagedTexture::reset):

  • platform/graphics/chromium/ManagedTexture.h:

(WebCore::ManagedTexture::manager):
(ManagedTexture):
(WebCore::ManagedTexture::isReserved):

  • platform/graphics/chromium/TextureManager.cpp:

(WebCore::TextureManager::~TextureManager):
(WebCore):
(WebCore::TextureManager::setPreferredMemoryLimitBytes):
(WebCore::TextureManager::registerTexture):
(WebCore::TextureManager::unregisterTexture):

  • platform/graphics/chromium/TextureManager.h:

(WebCore):
(TextureManager):

Source/WebKit/chromium: [chromium] Support detaching TextureManager from ManagedTexture
https://bugs.webkit.org/show_bug.cgi?id=77655

Adds unit test for destroying a TextureManager while ManagedTextures are still alive referring to it.

Reviewed by Kenneth Russell.

  • tests/TextureManagerTest.cpp:
13:05 Changeset [106839] by andersca@apple.com

Wheel event handler count not updated when adding handlers to the window
https://bugs.webkit.org/show_bug.cgi?id=77895

Reviewed by Dan Bernstein.

Source/WebCore:

Test: fast/events/wheelevent-handler-count.html

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
Update the wheel event count.

  • testing/Internals.cpp:

(WebCore::Internals::wheelEventHandlerCount):

  • testing/Internals.h:
  • testing/Internals.idl:

Add wheelEventHandlerCount to window.internals.

LayoutTests:

  • fast/events/wheelevent-handler-count-expected.txt: Added.
  • fast/events/wheelevent-handler-count.html: Added.
13:01 Changeset [106838] by commit-queue@webkit.org

Source/WebKit2: [GTK] Fix remaining errors in GTK+ WebKit2 API
https://bugs.webkit.org/show_bug.cgi?id=77890

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-02-06
Reviewed by Gustavo Noronha Silva.

Fix some style issues in the GTK+ WebKit2 API section of the source code.

  • UIProcess/API/gtk/WebKitPrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:
  • UIProcess/API/gtk/tests/TestMain.h:

Tools: [GTK] Fix remaining errors in GTK+ WebKit2 API
https://bugs.webkit.org/show_bug.cgi?id=77890

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-02-06
Reviewed by Gustavo Noronha Silva.

Verify that WebKit2 GTK+ test files are not skipped during style checks.
Skip soup_server_new when checking for NULL versus 0 usage.

  • Scripts/webkitpy/style/checker_unittest.py:

(CheckerDispatcherSkipTest.test_should_skip_with_warning):

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_for_null):

13:00 CommitterTips edited by bweinstein@apple.com
(diff)
13:00 CommitterTips edited by bweinstein@apple.com
(diff)
12:57 CommitterTips edited by bweinstein@apple.com
(diff)
12:56 Changeset [106837] by lforschler@apple.com

Merged r106729.

12:54 Changeset [106836] by mdelaney@apple.com

toDataURL() uses stale data after putImageData()
https://bugs.webkit.org/show_bug.cgi?id=65767

Source/WebCore:

This patch fixes the issue we've encountered of getting back
stale copies of the CGContext of accelerated ImageBuffers who have seen
putImageData calls but have not been drawn into via the CG API.
This issue is fixed by modifying the way we implement putImageData
in ImageBufferCG to draw the bits wrapped in a CGImage while the CGContext
is in a state where the data will effectively be copied (as is needed for
implementing putImageData) instead of directly modifying the bits of the IOSurface.

Reviewed by Chris Marrin.

Test: fast/canvas/check-stale-putImageData, pixel test to check that the canvas is in fact painted.

  • platform/graphics/cg/ImageBufferCG.cpp: Implement new way of putting image data.
  • platform/graphics/ImageBuffer.h: Merged two previously separate put data calls

into a single and more sensibly named 'putByteArray', since that's what it does!

  • WebCore.exp.in: Added new WKSI call for use in ImageBufferCG.cpp
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Using new method name.

  • html/canvas/CanvasRenderingContext2D.cpp:
  • platform/graphics/ImageBuffer.cpp:
  • platform/graphics/ShadowBlur.cpp:
  • platform/graphics/filters/FEColorMatrix.cpp:
  • platform/graphics/filters/FEDropShadow.cpp:
  • platform/graphics/filters/FilterEffect.cpp:

Updated other ports' ImageBuffers to use new method.

  • platform/graphics/cairo/ImageBufferCairo.cpp:
  • platform/graphics/qt/ImageBufferQt.cpp:
  • platform/graphics/skia/ImageBufferSkia.cpp:
  • platform/graphics/wince/ImageBufferWinCE.cpp:
  • platform/graphics/wx/ImageBufferWx.cpp:

Source/WebKit/chromium:

Reviewed by Chris Marrin.

  • src/WebViewImpl.cpp: Updated method name.

(WebKit::WebViewImpl::doPixelReadbackToCanvas):

Source/WebKit/mac:

Reviewed by Chris Marrin.

  • WebCoreSupport/WebSystemInterface.mm:

Source/WebKit2:

Reviewed by Chris Marrin.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

WebKitLibraries:

Added WKCGContextResetClip for use in reseting clip for new putByteArray method.

Reviewed by Chris Marrin.

  • WebKitSystemInterface.h: Added WKCGContextResetClip.
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceLion.a:
12:54 Changeset [106835] by lforschler@apple.com

Merged r104356.

12:48 Changeset [106834] by lforschler@apple.com

Merged r106594.

12:42 Changeset [106833] by caio.oliveira@openbossa.org

Provide more attribute methods in Element
https://bugs.webkit.org/show_bug.cgi?id=77800

Reviewed by Ryosuke Niwa.

Source/WebCore:

Reduce the clients of NamedNodeMap. This will make easier to change the
implementation of our attribute storage. The clients now use Element methods
that expose Attribute* accessors.

Instead of checking the existence of NamedNodeMap, clients can call
hasAttributes() or hasAttributesWithoutUpdate() (that skips updating invalid
style or animation svg attributes).

If there are attributes, they can be accessed by index via attributeCount() /
attributeItem(), as well as by QualifiedName. Those accessors assume there are an
attribute storage.

  • css/SelectorChecker.cpp:

(WebCore::anyAttributeMatches):
(WebCore::SelectorChecker::checkOneSelector):

  • css/SelectorChecker.h:

(WebCore::SelectorChecker::checkExactAttribute):

  • dom/DatasetDOMStringMap.cpp:

(WebCore::DatasetDOMStringMap::getNames):
(WebCore::DatasetDOMStringMap::item):
(WebCore::DatasetDOMStringMap::contains):

  • dom/Document.cpp:

(WebCore::Document::importNode): use setAttributesFromElement() instead of manually copying.

  • dom/Element.h:

(Element):
(WebCore::Element::hasAttributesWithoutUpdate):
(WebCore):
(WebCore::Element::attributeCount):
(WebCore::Element::attributeItem):
(WebCore::Element::getAttributeItem):
(WebCore::Element::removeAttribute):

  • dom/Node.cpp:

(WebCore::Node::isDefaultNamespace):
(WebCore::Node::lookupNamespaceURI):
(WebCore::Node::lookupNamespacePrefix):
(WebCore::Node::compareDocumentPosition):

  • editing/ApplyStyleCommand.cpp:

(WebCore::hasNoAttributeOrOnlyStyleAttribute):
(WebCore::isEmptyFontTag):

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::elementIsStyledSpanOrHTMLEquivalent):

  • editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::highestVisuallyEquivalentDivBelowRoot):

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendElement):

  • editing/markup.cpp:

(WebCore::completeURLs):
(WebCore::StyledMarkupAccumulator::appendElement):

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::parametersForPlugin):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateType):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parametersForPlugin):

  • html/HTMLParamElement.cpp:

(WebCore::HTMLParamElement::isURLAttribute):

  • html/parser/HTMLFormattingElementList.cpp:

(WebCore::attributeCountWithoutUpdate):
(WebCore::HTMLFormattingElementList::tryToEnsureNoahsArkConditionQuickly):
(WebCore::HTMLFormattingElementList::ensureNoahsArkCondition): Store Attribute*
to avoid looking up the right element again by name.

  • inspector/DOMEditor.cpp:

(WebCore::DOMEditor::innerPatchNode):
(WebCore::DOMEditor::createDigest):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::buildArrayForElementAttributes):

  • page/PageSerializer.cpp:

(WebCore::isCharsetSpecifyingNode):

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::getPresentationAttribute):

  • xml/XPathFunctions.cpp:

(WebCore::XPath::FunLang::evaluate):

  • xml/XPathNodeSet.cpp:

(WebCore::XPath::NodeSet::traversalSort):

  • xml/XPathStep.cpp:

(WebCore::XPath::Step::nodesInAxis):

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):

  • xml/parser/XMLTreeBuilder.cpp:

(WebCore::XMLTreeBuilder::XMLTreeBuilder):

Source/WebKit/chromium:

  • src/WebPageSerializerImpl.cpp:

(WebKit::WebPageSerializerImpl::openTagToString): access attributes via Element interface.

Source/WebKit/qt:

  • Api/qwebelement.cpp:

(QWebElement::attributeNames): access attributes via Element interface.

12:29 Changeset [106832] by eric@webkit.org

webkit-patch apply-from-bug should be able to apply non-reviewed patches
https://bugs.webkit.org/show_bug.cgi?id=77883

Reviewed by Adam Barth.

This is very helpful if you use bugzilla as a replacement for git-stash.
Makes it simpler to re-apply the patch w/o having to look up the patch id.

  • Scripts/webkitpy/tool/commands/download.py:

(ProcessBugsMixin._fetch_list_of_patches_to_process):

  • Scripts/webkitpy/tool/commands/download_unittest.py:

(DownloadCommandsTest.test_apply_from_bug):

12:12 Changeset [106831] by kov@webkit.org

[GTK] Insta-crash when closing browser with inspector window opened
https://bugs.webkit.org/show_bug.cgi?id=50744

Reviewed by Martin Robinson.

Source/WebKit/gtk:

  • GNUmakefile.am:
  • WebCoreSupport/InspectorClientGtk.cpp:

(WebKit::InspectorClient::releaseFrontendPage): also let go of the
frontend client when releasing the frontend page;
(WebKit::InspectorFrontendClient::~InspectorFrontendClient(): Call releaseFrontendPage()
like other ports do instead of just disconnectFrontendClient().
(WebKit::InspectorFrontendClient::destroyInspectorWindow): Use GRefPtr for the
inspector ref.
(WebKit::InspectorFrontendClient::bringToFront): Adjust for GRefPtr usage.
(WebKit::InspectorFrontendClient::attachWindow): Ditto.
(WebKit::InspectorFrontendClient::detachWindow): Ditto.
(WebKit::InspectorFrontendClient::inspectedURLChanged): Ditto.

  • WebCoreSupport/InspectorClientGtk.h:

(InspectorFrontendClient): Use GRefPtr for inspector member.

  • tests/testwebinspector.c: Added. Test that killing a WebView with the inspector

open does not crash, and that closing and reinspecting works.
(quitLoop):
(consoleMessageCallback):
(inspectElementCallback):
(closeInspector):
(showInspector):
(test_webkit_web_inspector_close_and_inspect):
(test_webkit_web_inspector_destroy_inspected_web_view):
(main):

LayoutTests:

  • platform/gtk/Skipped: unskip inspector/debugger/open-close-open.html,

which now passes.

12:00 Changeset [106830] by jsbell@chromium.org

IndexedDB: Raise exception during add/put call if autoIncrement key insertion will fail
https://bugs.webkit.org/show_bug.cgi?id=77374

Source/WebCore:

If a put request will use a key generator, try inserting a dummy key during the sync
put() call to check if the key insertion will succeed so an exception can be raised
early, rather than deferring to the asynchronous task.

Reviewed by Tony Chang.

Test: storage/indexeddb/keypath-edges.html

  • storage/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::put):

LayoutTests:

Reviewed by Tony Chang.

  • storage/indexeddb/keypath-edges-expected.txt:
  • storage/indexeddb/keypath-edges.html:
11:56 Changeset [106829] by jchaffraix@webkit.org

[Chromium] Test fast/forms/listbox-clear-restore.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=77889

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:54 Changeset [106828] by kov@webkit.org

Add a null check for the gdkwindow, that will happen if the window
is not mapped.

Reviewed by Martin Robinson.

  • platform/gtk/GtkUtilities.cpp:

(WebCore::convertWidgetPointToScreenPoint):

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::setCursor):

11:50 Changeset [106827] by commit-queue@webkit.org

Source/WebCore: IndexedDB createObjectStore should throw if options arg is invalid
Added logic to OptionsObject to determine if an invalid object was created.
Javascript bindings now detect invalid OptionsObject's and throw TypeError when found.
https://bugs.webkit.org/show_bug.cgi?id=58471

Patch by Eugene Girard <girard@chromium.org> on 2012-02-06
Reviewed by Adam Barth.

Test: storage/indexeddb/createObjectStore-bad-options.html

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateParametersCheck):

  • bindings/v8/OptionsObject.cpp:

(WebCore::OptionsObject::isObject):

  • bindings/v8/OptionsObject.h:

LayoutTests: IndexedDB createObjectStore should throw if options arg is invalid (not an object).
Added unit tests to test invalid arguments.
storage/indexddb/transaction-basics was modified only to correct calls that would
now throw.
https://bugs.webkit.org/show_bug.cgi?id=58471

Patch by Eugene Girard <girard@chromium.org> on 2012-02-06
Reviewed by Adam Barth.

  • storage/indexeddb/create-object-store-options-expected.txt:
  • storage/indexeddb/create-object-store-options.html:
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/resources/shared.js:

(evalAndExpectExceptionClass):

  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-basics.html:
  • storage/indexeddb/tutorial.html:
11:50 Changeset [106826] by leviw@chromium.org

Fixing incorrect usage of AppUnits as parameters to Widgets.

11:37 Changeset [106825] by jesus@webkit.org

[Qt][WK2] http/tests/loading/state-object-security-exception.html fails
https://bugs.webkit.org/show_bug.cgi?id=62731

Unreviewed gardening.

Skipped 3 tests because they were still failing after http://trac.webkit.org/changeset/106812 .
Skipped tests were:
fast/history/form-submit-in-frame-via-onclick.html
fast/history/form-submit-in-frame.html
http/tests/loading/state-object-security-exception.html

  • platform/qt-wk2/Skipped:
11:37 Changeset [106824] by rniwa@webkit.org

gcc build fix after r106749.

  • UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::WebPreferences):

11:28 Changeset [106823] by jchaffraix@webkit.org

Unreviewed, rolling out r106797 and r106806.
http://trac.webkit.org/changeset/106797
http://trac.webkit.org/changeset/106806
https://bugs.webkit.org/show_bug.cgi?id=77888

The change is still causing some crashes in webaudio/ on the
Chromium bots (Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-06

Source/WebCore:

  • Modules/intents/IntentRequest.cpp:

(WebCore::IntentRequest::create):

  • bindings/generic/ActiveDOMCallback.cpp:

(WebCore::ActiveDOMCallback::ActiveDOMCallback):

  • dom/ActiveDOMObject.cpp:

(WebCore::ActiveDOMObject::ActiveDOMObject):
(WebCore::ActiveDOMObject::~ActiveDOMObject):

  • dom/ActiveDOMObject.h:

(ActiveDOMObject):

  • dom/DocumentEventQueue.cpp:

(WebCore::DocumentEventQueue::DocumentEventQueue):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::ScriptExecutionContext):
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
(WebCore::ScriptExecutionContext::stopActiveDOMObjects):

  • dom/ScriptExecutionContext.h:

(ScriptExecutionContext):

  • fileapi/DOMFileSystem.cpp:

(WebCore::DOMFileSystem::create):

  • fileapi/FileReader.cpp:

(WebCore):

  • fileapi/FileReader.h:

(WebCore::FileReader::create):

  • fileapi/FileWriter.cpp:

(WebCore):

  • fileapi/FileWriter.h:

(WebCore::FileWriter::create):

  • history/CachedFrame.cpp:

(WebCore::CachedFrame::CachedFrame):

  • html/HTMLAudioElement.cpp:

(WebCore::HTMLAudioElement::create):
(WebCore::HTMLAudioElement::createForJSConstructor):

  • html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::create):

  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::create):

  • mediastream/PeerConnection.cpp:

(WebCore::PeerConnection::create):

  • notifications/Notification.cpp:

(WebCore::Notification::create):

  • notifications/NotificationCenter.cpp:
  • notifications/NotificationCenter.h:

(WebCore::NotificationCenter::create):

  • page/DOMTimer.cpp:

(WebCore::DOMTimer::install):
(WebCore::DOMTimer::fired):

  • page/EventSource.cpp:

(WebCore::EventSource::create):

  • page/SuspendableTimer.cpp:

(WebCore::SuspendableTimer::SuspendableTimer):

  • storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::create):

  • storage/IDBRequest.cpp:

(WebCore::IDBRequest::create):

  • storage/IDBTransaction.cpp:

(WebCore::IDBTransaction::create):

  • storage/IDBVersionChangeRequest.cpp:

(WebCore::IDBVersionChangeRequest::create):

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::create):

  • websockets/WebSocket.cpp:
  • websockets/WebSocket.h:

(WebCore::WebSocket::create):

  • workers/SharedWorker.cpp:

(WebCore::SharedWorker::create):

  • workers/Worker.cpp:

(WebCore::Worker::create):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::create):

LayoutTests:

  • fast/events/resources/suspend-subframe-1.html: Removed.
  • fast/events/resources/suspend-subframe-2.html: Removed.
  • fast/events/suspend-timers-expected.txt: Removed.
  • fast/events/suspend-timers.html: Removed.
  • platform/chromium/test_expectations.txt:
11:24 Changeset [106822] by lforschler@apple.com

Merged r106678.

11:13 Changeset [106821] by dslomov@google.com

Merge 106722 - [Chromium] WebCore::toV8Context crashes if DomWindow::frame() returns null.
https://bugs.webkit.org/show_bug.cgi?id=77686.

Reviewed by Adam Barth.

  • bindings/v8/V8Helpers.cpp:

(WebCore::toV8Context):

TBR=dslomov@google.com
Review URL: https://chromiumcodereview.appspot.com/9334005

11:01 Changeset [106820] by rniwa@webkit.org

Merge 106380 - Source/WebCore: Crash in DeleteSelectionCommand::handleGeneralDelete when attempting to delete the start block
https://bugs.webkit.org/show_bug.cgi?id=77077

Reviewed by Enrica Casucci.

The crash was caused by a missing null check after removing the position out of the start block.
Fixed the bug by adding an early return.

Tests: editing/deleting/delete-start-block.html

editing/selection/move-into-empty-root-inline-box.html

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::handleGeneralDelete):

LayoutTests: Crash in previousLinePosition when moving into a root inline box without leaves
https://bugs.webkit.org/show_bug.cgi?id=76812

Reviewed by Enrica Casucci.

Add a regression test for the crash. Unfortunately, we can only test previousLinePosition.

  • editing/selection/move-into-empty-root-inline-box-expected.txt: Added.
  • editing/selection/move-into-empty-root-inline-box.html: Added.

http://crbug.com/99408/
Review URL: https://chromiumcodereview.appspot.com/9331006

10:35 Changeset [106819] by caio.oliveira@openbossa.org

Move style related functions from NamedNodeMap to ElementAttributeData
https://bugs.webkit.org/show_bug.cgi?id=77879

Reviewed by Ryosuke Niwa.

This commit also removes the NamedNodeMap::mappedAttributeCount(),
which is a leftover from removal of mapped attributes.

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::ensureInlineStyleDecl):
(WebCore):
(WebCore::ElementAttributeData::destroyInlineStyleDecl):
(WebCore::ElementAttributeData::ensureAttributeStyle):

  • dom/ElementAttributeData.h:

(WebCore::ElementAttributeData::inlineStyleDecl):
(ElementAttributeData):
(WebCore::ElementAttributeData::attributeStyle):

  • dom/NamedNodeMap.cpp:
  • dom/NamedNodeMap.h:
  • dom/StyledElement.h:

(StyledElement):
(WebCore::StyledElement::inlineStyleDecl):
(WebCore::StyledElement::ensureInlineStyleDecl):
(WebCore::StyledElement::attributeStyle):
(WebCore::StyledElement::ensureAttributeStyle):
(WebCore::StyledElement::destroyInlineStyleDecl):

10:23 Changeset [106818] by inferno@chromium.org

Crash in SubframeLoader::loadSubframe.
https://bugs.webkit.org/show_bug.cgi?id=77345

Reviewed by Nate Chapin.

Source/WebCore:

Mutation event when loading subframe can blow away the
main frame. Add a RefPtr to protect against that.

Test: fast/frames/subframe-load-crash-main.html

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::loadSubframe):

LayoutTests:

  • fast/frames/resources/subframe-load-crash.svg: Added.
  • fast/frames/subframe-load-crash-main-expected.txt: Added.
  • fast/frames/subframe-load-crash-main.html: Added.
10:20 Changeset [106817] by senorblanco@chromium.org

Merge 106477 - [SKIA/CHROMIUM] Perform getImageData format conversions using Skia
https://bugs.webkit.org/show_bug.cgi?id=77553

Patch by Brian Salomon <bsalomon@google.com> on 2012-02-01
Reviewed by Stephen White.

Source/WebCore:

Many existing canvas tests exercise this functionality.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::getImageData):

LayoutTests:

  • platform/chromium/test_expectations.txt:

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9331005

09:59 Changeset [106816] by commit-queue@webkit.org

[GTK] WebKitWebView does a lot of work during size_allocate when not mapped
https://bugs.webkit.org/show_bug.cgi?id=77743

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-02-06
Reviewed by Gustavo Noronha Silva.

Instead of resizing the guts of a WebView when it's not mapped, wait
until it's mapped and do one resize. This prevents unmapped WebViews
from adding to a container's resize cost.

Source/WebKit/gtk:

  • webkit/webkitwebview.cpp:

(resizeWebViewFromAllocation): Abstracted out this helper.
(webkit_web_view_size_allocate): Wait until map to resize umapped widgets.
(webkitWebViewMap): Added this vmethod implementation.
(webkit_web_view_class_init): Added vmethod.

  • webkit/webkitwebviewprivate.h: Added new needsResizeOnMap member.

Source/WebKit2:

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(_WebKitWebViewBasePrivate): Added a new member needsResizeOnMap.
(resizeWebKitWebViewBaseFromAllocation): Abstracted out this helper.
(webkitWebViewBaseSizeAllocate): Wait until map to resize unmapped WebViews.
(webkitWebViewBaseMap): Added this vmethod implementation.
(webkit_web_view_base_class_init): Added vmethod.

09:49 Changeset [106815] by commit-queue@webkit.org

Initial implementation of GraphicsContext3DOpenGLES.cpp
https://bugs.webkit.org/show_bug.cgi?id=76248

Patch by ChangSeok Oh <shivamidow@gmail.com> on 2012-02-06
Reviewed by Martin Robinson.

Implemented APIs in GraphicsContext3DOpenGLES.cpp according to the GLES spec. roughly.
But no way to run these codes right now, because they need an extra port
specific implementation to work. I plan to add these extra codes for the GTK port
in the next patch. And also this patch doesn't support anti-aliasing yet. Another bug
will deal with it.
Moved some APIs in GraphicsContext3DOpenGLES.cpp to GraphicsContext3DCommon.cpp.
It looks it could be shared between gl and gles.
Two helper functions are added to avoid code duplication in GraphicsContext3D.
Added a missing period at the end of comment lines.

No new tests required.
We'll be able to verify this patch by using the existing webgl test cases.

  • platform/graphics/GraphicsContext3D.h: Add build flag to access stencilBuffer & depthBuffer for gles.

(WebCore):

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::reshapeFBOs): Helper function extracted from GC3D::reshape to resize regular & multisampled FBOs.
(WebCore::GraphicsContext3D::resolveMultisamplingIfNecessary): Helper function to resolve multisampling.

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::validateAttributes): Add condition to disable antialiasing & packedDepthStencilExtension for GLES.
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):

Following APIs looked shareable so that moved into GC3DOpenGLCommon.cpp.
(WebCore::GraphicsContext3D::prepareTexture):
(WebCore):
(WebCore::GraphicsContext3D::readRenderingResults):
(WebCore::GraphicsContext3D::reshape):
(WebCore::GraphicsContext3D::bindFramebuffer):
(WebCore::GraphicsContext3D::copyTexImage2D):
(WebCore::GraphicsContext3D::copyTexSubImage2D):
(WebCore::GraphicsContext3D::getActiveUniform):
(WebCore::GraphicsContext3D::readPixels):

Added a missing period at the end of comment line.
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::getActiveAttrib):
(WebCore::GraphicsContext3D::uniform2fv):
(WebCore::GraphicsContext3D::uniform3fv):
(WebCore::GraphicsContext3D::uniform4fv):
(WebCore::GraphicsContext3D::uniform2iv):
(WebCore::GraphicsContext3D::uniform3iv):
(WebCore::GraphicsContext3D::uniform4iv):
(WebCore::GraphicsContext3D::uniformMatrix2fv):
(WebCore::GraphicsContext3D::uniformMatrix3fv):
(WebCore::GraphicsContext3D::uniformMatrix4fv):
(WebCore::GraphicsContext3D::texSubImage2D):

  • platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:

(WebCore::GraphicsContext3D::reshapeFBOs): Same with the above.
(WebCore::GraphicsContext3D::resolveMultisamplingIfNecessary): Same with the above.

Brief explanation about what the differences are between gl and gles.
(WebCore::GraphicsContext3D::renderbufferStorage): Removed codes for converting GLES parameter to GL parameter.
(WebCore::GraphicsContext3D::getIntegerv): Removed codes that emulate GLES.
(WebCore::GraphicsContext3D::texImage2D): Removed codes for converting GLES parameter to GL parameter.

09:33 Changeset [106814] by philn@webkit.org

[webkitpy] cpp style-checker complains about readability/naming in GStreamer elements source files
https://bugs.webkit.org/show_bug.cgi?id=77866

Reviewed by Martin Robinson.

  • Scripts/webkitpy/style/checker.py: Ignore readability/naming

errors in some gstreamer source code files defining new GStreamer elements.

  • Scripts/webkitpy/style/checker_unittest.py:

(GlobalVariablesTest.test_path_rules_specifier):

09:31 Changeset [106813] by senorblanco@chromium.org

Merge 106732 - [chromium] Fix multi-second hangs in compositor invalidating large layers
https://bugs.webkit.org/show_bug.cgi?id=77774

Reviewed by James Robinson.

Correctness covered by existing tests.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::pushPropertiesTo):
Remove tiles from the tiler when they are invalid (ie., no longer have
texture backing).
(WebCore::TiledLayerChromium::invalidateRect):
Instead of iterating over the tile indices (which may be very large),
iterate over the tile hash map instead.

TBR=senorblanco@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9333004

09:05 Changeset [106812] by jesus@webkit.org

[Qt][WK2] http/tests/loading/state-object-security-exception.html fails
https://bugs.webkit.org/show_bug.cgi?id=62731

Rubber stamped by Csaba Osztrogonác.

Unskipping tests that were kept as skipped even after
https://bugs.webkit.org/show_bug.cgi?id=42333 was fixed.

  • platform/wk2/Skipped:
08:57 Changeset [106811] by apavlov@chromium.org

Web Inspector: [Meta] Allow emulation of touch events
https://bugs.webkit.org/show_bug.cgi?id=77096

Reviewed by Pavel Feldman.

This is the inspector part of the change, core part implementation tracked in bug 77105.

  • English.lproj/localizedStrings.js:
  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:

(DOMAgentState):
(WebCore::InspectorDOMAgent::clearFrontend):
(WebCore::InspectorDOMAgent::restore):
(WebCore):
(WebCore::InspectorDOMAgent::updateTouchEventEmulationInDocuments):
(WebCore::InspectorDOMAgent::setTouchEmulationEnabled):

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype._captureDOM):
(WebInspector.DOMAgent.prototype._emulateTouchEventsChanged):

  • inspector/front-end/Settings.js:

(WebInspector.Settings):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):

08:39 Changeset [106810] by commit-queue@webkit.org

[Blackberry] Non-supported about: operations never stops loading
https://bugs.webkit.org/show_bug.cgi?id=76366

Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-02-06
Reviewed by Rob Buis.

If user typed a non-supported "about:" scheme such as "about:nonsupport",
the loadAboutURL() function in NetworkManger should recognize and handle it as
an error of invalid url.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::loadAboutURL):
(WebCore::NetworkJob::handleAbout):

  • platform/network/blackberry/NetworkJob.h:

(NetworkJob):

  • platform/network/blackberry/NetworkManager.cpp:

(WebCore::NetworkManager::startJob):

08:26 Changeset [106809] by apavlov@chromium.org

Web Inspector: Remove unused disabledComputedProperties from methods in StylesSidebarPane
https://bugs.webkit.org/show_bug.cgi?id=77876

Reviewed by Pavel Feldman.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._refreshUpdate):
(WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._markUsedProperties):
(WebInspector.StylesSidebarPane.prototype._refreshSectionsForStyleRules):
(WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
(WebInspector.StylePropertiesSection.prototype.onpopulate):
(WebInspector.ComputedStylePropertiesSection):
(WebInspector.ComputedStylePropertiesSection.prototype._isPropertyInherited):

08:20 Changeset [106808] by loislo@chromium.org

Web Inspector: Redesign summary view / retaining tree contents
https://bugs.webkit.org/show_bug.cgi?id=77870

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-02-06
Reviewed by Pavel Feldman.

  1. Make object IDs less contrast.
  2. Put array indices in [].
  3. Do not write type if it's just "Object".

Source/WebCore:

  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotGenericObjectNode.prototype._createObjectCell):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
(WebInspector.HeapSnapshotObjectNode.prototype._emptyData):
(WebInspector.HeapSnapshotObjectNode.prototype._enhanceData):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):
(WebInspector.HeapSnapshotConstructorNode.prototype.get data):

  • inspector/front-end/heapProfiler.css:

(.detailed-heapshot-view .console-formatted-id):
(.detailed-heapshot-view td.object-column span.grayed):

LayoutTests:

  • inspector/profiler/detailed-heapshots-test.js:

(initialize_DetailedHeapshotTest.):
(initialize_DetailedHeapshotTest):

08:10 Changeset [106807] by noam.rosenthal@nokia.com

[Texmap][Qt] Avoid an image copy when uploading textures in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=77748

Reviewed by Kenneth Rohde Christiansen.

Use QPixmap::buffer() API to get access to the QPixmap's pixels without implicit copies.

Instrumentation shows that the deep image copies created from TextureMapperGL are
eliminated.

  • platform/graphics/opengl/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::updateContents):

08:05 Changeset [106806] by tonyg@chromium.org

LayoutTest failures on r106797
https://bugs.webkit.org/show_bug.cgi?id=77868

Call suspendIfNeeded from subclass of IDBRequest, IDBVersionChangeRequest.

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-06
Reviewed by Simon Hausmann.

  • storage/IDBVersionChangeRequest.cpp:

(WebCore::IDBVersionChangeRequest::create):

06:54 Changeset [106805] by carlosgc@webkit.org

[GTK] Make sure html_dir exists before calling gtkdoc-rebase
https://bugs.webkit.org/show_bug.cgi?id=77869

Reviewed by Philippe Normand.

  • gtk/gtkdoc.py:

(GTKDoc.rebase_installed_docs): Check html_dir exists.

06:18 Changeset [106804] by noam.rosenthal@nokia.com

[Qt] Implement ImageBuffer::copyImage(ImageBuffer::DontCopyBackingStore)
https://bugs.webkit.org/show_bug.cgi?id=77689

Reviewed by Kenneth Rohde Christiansen.

Use StillImageQt::createForRendering when using DontCopyBackingStore.
Enable DontCopyBackingStore in TextureMapperNode.
This removes deep copies resulting from the use of ImageBuffer.

Instrumentation shows that deep image copies resulted from ImageBuffer are eliminated.

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::ImageBuffer::copyImage):

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::renderContent):

06:07 Changeset [106803] by commit-queue@webkit.org

WebGestureEvent can not encode delta and area.
https://bugs.webkit.org/show_bug.cgi?id=77728

Source/WebCore:

Add area field to PlatformGestureEvent.

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-06
Reviewed by Kenneth Rohde Christiansen.

  • platform/PlatformGestureEvent.h:

(WebCore::PlatformGestureEvent::PlatformGestureEvent):
(WebCore::PlatformGestureEvent::area):

Source/WebKit2:

Support delta and area fields in WebGestureEvent, and send area with Qt tap gesture.

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-06
Reviewed by Kenneth Rohde Christiansen.

  • Shared/WebEvent.h:

(WebKit::WebGestureEvent::area):
(WebKit::WebGestureEvent::delta):

  • Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformGestureEvent::WebKit2PlatformGestureEvent):

  • Shared/WebGestureEvent.cpp:

(WebKit::WebGestureEvent::WebGestureEvent):
(WebKit::WebGestureEvent::encode):
(WebKit::WebGestureEvent::decode):

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::handleSingleTapEvent):

05:55 Changeset [106802] by commit-queue@webkit.org

[BlackBerry]Use extension for a mimetype as the suggested extension
if the url file doesn't have an extension.
https://bugs.webkit.org/show_bug.cgi?id=76779

Patch by Charles Wei <charles.wei@torchmobile.com.cn> on 2012-02-06
Reviewed by Antonio Gomes.

No new tests.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::sendResponseIfNeeded):

05:24 Changeset [106801] by hans@chromium.org

Speech input: fix fast/speech/bubble-position.html
https://bugs.webkit.org/show_bug.cgi?id=77732

Reviewed by Tony Gentilcore.

There is no need for the test to check the pixel-exact position of the
rect, since that seems to vary a little between platforms.
The point of the test is to check that the rect is within the iframe,
so let's do that.

  • fast/speech/bubble-position-expected.txt:
  • fast/speech/bubble-position.html:
05:11 Changeset [106800] by jocelyn.turcotte@nokia.com

[Qt][WK2] Remove TiledDrawingArea and dependencies.
https://bugs.webkit.org/show_bug.cgi?id=71681

Reviewed by Kenneth Rohde Christiansen.

Tiled drawing surface functionality got converted to LayerTree.
TiledDrawingArea and its dependencies are not used by any port anymore.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • Shared/DrawingAreaInfo.h:
  • Target.pri:
  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPagePrivate::QQuickWebPagePrivate):

  • UIProcess/API/qt/qquickwebpage_p.h:
  • UIProcess/API/qt/qquickwebpage_p_p.h:

(QQuickWebPagePrivate):

  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxy.messages.in:
  • UIProcess/TiledDrawingAreaProxy.cpp: Removed.
  • UIProcess/TiledDrawingAreaProxy.h: Removed.
  • UIProcess/qt/QtSGTileNode.cpp: Removed.
  • UIProcess/qt/QtSGTileNode.h: Removed.
  • UIProcess/qt/QtSGUpdateQueue.cpp: Removed.
  • UIProcess/qt/QtSGUpdateQueue.h: Removed.
  • UIProcess/qt/TiledDrawingAreaProxyQt.cpp: Removed.
  • WebProcess/WebPage/DrawingArea.cpp:

(WebKit::DrawingArea::create):

  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/DrawingArea.messages.in:
  • WebProcess/WebPage/TiledDrawingArea.cpp: Removed.
  • WebProcess/WebPage/TiledDrawingArea.h: Removed.
  • WebProcess/WebPage/WebPage.h:

(WebPage):

05:09 Changeset [106799] by jocelyn.turcotte@nokia.com

[Qt] Don't version QtWebKit.experimental.
https://bugs.webkit.org/show_bug.cgi?id=77739

Reviewed by Tor Arne Vestbø.

Source/WebKit/qt:

We won't support previous versions of the experimental API.

  • declarative/experimental/plugin.cpp:

Source/WebKit2:

  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_itemSelector.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_messaging.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_download.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_geopermission.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_javaScriptDialogs.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_navigationHistory.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml:

Tools:

  • MiniBrowser/qt/qml/BrowserWindow.qml:
04:56 Changeset [106798] by haraken@chromium.org

Rename [HasIndexGetter], [HasNameGetter] and [HasCustomIndexSetter] IDLs
https://bugs.webkit.org/show_bug.cgi?id=77848

Reviewed by Adam Barth.

For naming consistency with [CustomGetter] and [CustomSetter],
this patch renames the following IDLs:

[HasIndexGetter] => [IndexedGetter] (Remove "Has". This IDL is for "indexed" properties
in the Web IDL: http://dev.w3.org/2006/webapi/WebIDL/#idl-indexed-properties)
[HasCustomIndexSetter] => [CustomIndexedSetter] (Ditto.)
[HasNameGetter] => [NamedGetter] (Remove "Has". This IDL is for "named" properties
in the Web IDL: http://dev.w3.org/2006/webapi/WebIDL/#idl-named-properties)

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateImplementationIndexer):
(GenerateImplementationNamedPropertyGetter):

  • bindings/scripts/test/TestEventTarget.idl: No change in run-bindings-tests results.
  • bindings/scripts/test/TestTypedArray.idl: Ditto.
  • Modules/gamepad/GamepadList.idl:
  • css/CSSRuleList.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSValueList.idl:
  • css/MediaList.idl:
  • css/StyleSheetList.idl:
  • css/WebKitCSSFilterValue.idl:
  • css/WebKitCSSKeyframesRule.idl:
  • css/WebKitCSSTransformValue.idl:
  • dom/ClientRectList.idl:
  • dom/DOMStringList.idl:
  • dom/DOMStringMap.idl:
  • dom/DataTransferItemList.idl:
  • dom/NamedNodeMap.idl:
  • dom/NodeList.idl:
  • dom/TouchList.idl:
  • fileapi/EntryArray.idl:
  • fileapi/EntryArraySync.idl:
  • fileapi/FileList.idl:
  • html/DOMSettableTokenList.idl:
  • html/DOMTokenList.idl:
  • html/HTMLAllCollection.idl:
  • html/HTMLCollection.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLOptionsCollection.idl:
  • html/HTMLPropertiesCollection.idl:
  • html/HTMLSelectElement.idl:
  • html/TextTrackCueList.idl:
  • html/canvas/CanvasPixelArray.idl:
  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • html/canvas/Uint8ClampedArray.idl:
  • html/track/TextTrackList.idl:
  • mediastream/MediaStreamList.idl:
  • mediastream/MediaStreamTrackList.idl:
  • page/SpeechInputResultList.idl:
  • page/WebKitAnimationList.idl:
  • plugins/DOMMimeTypeArray.idl:
  • plugins/DOMPlugin.idl:
  • plugins/DOMPluginArray.idl:
  • storage/Storage.idl:
04:36 Changeset [106797] by commit-queue@webkit.org

Source/WebCore: Ensure timers and other active DOM objects do not fire in suspended documents.
https://bugs.webkit.org/show_bug.cgi?id=53733

ScriptExecutionContext now remembers it has suspended active DOM objects
and suspends all newly installed active DOM objects as well.

All create-calls active DOM objects now calls the post constructor method
suspendIfNeeded that updates the suspend state. It is post constructor
because the suspend/resume functions are virtual and thus can not be called
from constructors.

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-06
Reviewed by Mihai Parparita.

Test: fast/events/suspend-timers.html

  • Modules/intents/IntentRequest.cpp:

(WebCore::IntentRequest::create):

  • bindings/generic/ActiveDOMCallback.cpp:

(WebCore::ActiveDOMCallback::ActiveDOMCallback):

  • dom/ActiveDOMObject.cpp:

(WebCore::ActiveDOMObject::ActiveDOMObject):
(WebCore::ActiveDOMObject::~ActiveDOMObject):
(WebCore::ActiveDOMObject::suspendIfNeeded):

  • dom/ActiveDOMObject.h:

(WebCore::ActiveDOMObject::suspendIfNeededCalled):

  • dom/DocumentEventQueue.cpp:

(WebCore::DocumentEventQueue::DocumentEventQueue):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::ScriptExecutionContext):
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
(WebCore::ScriptExecutionContext::stopActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjectIfNeeded):

  • dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::activeDOMObjectsAreSuspended):

  • fileapi/DOMFileSystem.cpp:

(WebCore::DOMFileSystem::create):

  • fileapi/FileReader.cpp:

(WebCore::FileReader::create):

  • fileapi/FileReader.h:
  • fileapi/FileWriter.cpp:

(WebCore::FileWriter::create):

  • fileapi/FileWriter.h:
  • history/CachedFrame.cpp:

(WebCore::CachedFrame::CachedFrame):

  • html/HTMLAudioElement.cpp:

(WebCore::HTMLAudioElement::create):

  • html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::create):

  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::create):

  • mediastream/PeerConnection.cpp:

(WebCore::PeerConnection::create):

  • notifications/Notification.cpp:

(WebCore::Notification::create):

  • notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::create):

  • notifications/NotificationCenter.h:
  • page/DOMTimer.cpp:

(WebCore::DOMTimer::install):
(WebCore::DOMTimer::fired):

  • page/EventSource.cpp:

(WebCore::EventSource::create):

  • page/SuspendableTimer.cpp:

(WebCore::SuspendableTimer::SuspendableTimer):

  • storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::create):

  • storage/IDBRequest.cpp:

(WebCore::IDBRequest::create):

  • storage/IDBTransaction.cpp:

(WebCore::IDBTransaction::create):

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::create):

  • websockets/WebSocket.cpp:

(WebCore::WebSocket::create):

  • websockets/WebSocket.h:
  • workers/SharedWorker.cpp:

(WebCore::SharedWorker::create):

  • workers/Worker.cpp:

(WebCore::Worker::create):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::create):

LayoutTests: Test that timers do not fire from subframes of suspended documents.
https://bugs.webkit.org/show_bug.cgi?id=53733

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-06
Reviewed by Mihai Parparita.

  • fast/events/resources/suspend-subframe-1.html: Added.
  • fast/events/resources/suspend-subframe-2.html: Added.
  • fast/events/suspend-timers-expected.txt: Added.
  • fast/events/suspend-timers.html: Added.
  • platform/chromium/test_expectations.txt:
04:33 Changeset [106796] by paroga@webkit.org

Unreviewed WinCE build fix after r106197.

  • tools/CodeProfiling.cpp:

(JSC::CodeProfiling::notifyAllocator): getenv() isn't supported by WinCE. Don't call it.

03:18 Changeset [106795] by philn@webkit.org

Adding FFTFrameGStreamer.cpp that I forgot to commit
in r106537. That new file was reviewed in https://bugs.webkit.org/show_bug.cgi?id=73545.

  • platform/audio/gstreamer/FFTFrameGStreamer.cpp: Added.
02:39 Changeset [106794] by hayato@chromium.org

Add <shadow> element, which is guarded by SHADOW_DOM flag.
https://bugs.webkit.org/show_bug.cgi?id=76435

Reviewed by Dimitri Glazkov.

Test: fast/dom/shadow/shadow-element.html

Source/WebCore:

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLTagNames.in:
  • html/shadow/HTMLShadowElement.cpp: Added.

(WebCore):
(WebCore::HTMLShadowElement::HTMLShadowElement):
(WebCore::HTMLShadowElement::create):
(WebCore::HTMLShadowElement::~HTMLShadowElement):

  • html/shadow/HTMLShadowElement.h: Added.

(WebCore):
(HTMLShadowElement):

  • html/shadow/HTMLShadowElement.idl: Added.

LayoutTests:

  • fast/dom/shadow/shadow-element-expected.txt: Added.
  • fast/dom/shadow/shadow-element.html: Added.
02:26 Changeset [106793] by carlosgc@webkit.org

[GTK] Update NEWS and configure.ac for 1.7.5 release
https://bugs.webkit.org/show_bug.cgi?id=77859

Reviewed by Philippe Normand.

.:

  • configure.ac: Bumped version number.

Source/WebKit/gtk:

  • NEWS: Added release notes for 1.7.5.
02:18 Changeset [106792] by commit-queue@webkit.org

https://bugs.webkit.org/show_bug.cgi?id=76995.
WebKit fails IETC :indeterminate and input type=radio test.

All input types should respect indeterminate property(getter and setter). This is true with other browsers.
Indeterminate appearance for radio input type is supported by IOS platform. Webkit need not support indeterminate appearance
for radio input type on other platforms.

Patch by Joe Thomas <joethomas@motorola.com> on 2012-02-06
Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/forms/indeterminate-input-types.html

  • html/CheckboxInputType.cpp:

(WebCore::CheckboxInputType::supportsIndeterminateAppearance): Checks indeterminate appearance is supported.
(WebCore):

  • html/CheckboxInputType.h:

(CheckboxInputType):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setIndeterminate): Removed the check isCheckable().
(WebCore::HTMLInputElement::isIndeterminate): Checks indeterminate appearance is supported.
(WebCore):

  • html/HTMLInputElement.h:

(HTMLInputElement):

  • html/InputType.cpp:

(WebCore::InputType::supportsIndeterminateAppearance): Checks indeterminate appearance is supported.
(WebCore):

  • html/InputType.h:

(InputType):

  • html/RadioInputType.cpp:

(WebCore::RadioInputType::willDispatchClick): Indeterminate related code is moved to IOS specific.
(WebCore::RadioInputType::didDispatchClick): Ditto.
(WebCore::RadioInputType::supportsIndeterminateAppearance): Checks indeterminate appearance is supported.
(WebCore):

  • html/RadioInputType.h:

(RadioInputType):

LayoutTests:

  • fast/forms/indeterminate-input-types-expected.txt: Added.
  • fast/forms/indeterminate-input-types.html: Added.
  • fast/forms/indeterminate-radio.html:
02:02 Changeset [106791] by commit-queue@webkit.org

[BlackBerry] Remove unused variable in PluginViewBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=77847

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-02-06
Reviewed by Kentaro Hara.

No changes in behavior, so no new tests.

  • plugins/blackberry/PluginViewBlackBerry.cpp:

(WebCore::PluginView::updatePluginWidget):

01:58 Changeset [106790] by commit-queue@webkit.org

[BlackBerry] Remove unused variable in BackingStore
https://bugs.webkit.org/show_bug.cgi?id=77851

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-02-06
Reviewed by Kentaro Hara.

  • blackberry/Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::blitContents):

01:40 Changeset [106789] by zimmermann@webkit.org

2012-02-06 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Switch to unix file endings and at a trailing newline - hopefully the bots will accept my follow up patch then.

  • svg/filters/invalidate-on-child-layout.svg:
01:29 Changeset [106788] by carlosgc@webkit.org

[GTK] Fix several gtkdoc-fixxref warnings
https://bugs.webkit.org/show_bug.cgi?id=77613

Reviewed by Martin Robinson.

Source/WebKit/gtk:

  • docs/webkitgtk-docs.sgml: Remove webkitspellcheckerenchant

section.

  • docs/webkitgtk-sections.txt: Remove webkitspellcheckerenchant

symbols and move WebKitWebNavigationReason from the private
section to the global section.

  • webkit/webkitwebnavigationaction.h: Document

WebKitWebNavigationReason enum.

Source/WebKit2:

  • UIProcess/API/gtk/WebKitWindowProperties.cpp: Fix a typo, a

colon was missing in WebKitWebView::ready-to-show.

Tools:

  • gtk/generate-gtkdoc:

(get_webkit1_options): Add webkitspellcheckerenchant.* to the list
of ignored files, since it's private.

  • gtk/gtkdoc.py:

(GTKDoc._ignored_files_basenames): Helper function that returns a
string with the list of ignored files basenames separated by a
spaces, as expected by several gtkdoc commands.
(GTKDoc._run_gtkdoc_scan): Use _ignored_files_basenames for
--ignore-headers option.
(GTKDoc._run_gtkdoc_mkdb): Use _ignored_files_basenames for
--ignore-files option.

01:27 Changeset [106787] by commit-queue@webkit.org

Web Inspector: Fix CallArgument type in Inspector.json
https://bugs.webkit.org/show_bug.cgi?id=77839

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-06
Reviewed by Yury Semikhatsky.

Protocol description is fixed: field type is changed. No changes to
program code are necessary.

  • inspector/Inspector-0.1.json:
  • inspector/Inspector-1.0.json:
  • inspector/Inspector.json:
01:23 Changeset [106786] by carlosgc@webkit.org

[GTK] Fix xrefs after installing API documentation
https://bugs.webkit.org/show_bug.cgi?id=77551

Reviewed by Martin Robinson.

  • GNUmakefile.am: Call generate-gtkdoc --rebase after installing

api docs.

  • gtk/common.py:

(prefix_of_pkg_config_file): Get the prefix variable of the given
pkg-config file.
(gtk_version_of_pkg_config_file): Get the gtk version required by
the given pkg-config file.

  • gtk/generate-gtkdoc: Add --rebase command line option to rebase

installed documentation.
(get_gtkdoc_module_paths): Get paths where API doc is installed
for the dependencies of the given pkg-config file.
(get_common_xref_deps): Get API doc directories of dependencies
common to WebKit1 and WebKit2.
(get_webkit2_options): Add cross_reference_deps option.
(get_webkit1_options): Ditto
(rebase_installed_docs): Helper function to create a generator for
the given pkg-config file and options and call rebase_installed_docs.

  • gtk/gtkdoc.py:

(GTKDoc.init): Initialize cross_reference_deps.
(GTKDoc._run_gtkdoc_fixxref): Add API doc directories of
dependencies.
(GTKDoc.rebase_installed_docs): Call gtkdoc-rebase to fix xref
links of installed documentation.
(PkgConfigGTKDoc.init): Get the prefix from the pkg-config
file.

01:22 Changeset [106785] by abarth@webkit.org

Layout Test http/tests/security/xssAuditor/dom-write-innerHTML.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=67538

Reviewed by Kentaro Hara.

Try to fix the flakiness in this test by kicking off the <img> load
before the load event has fired for the inner frame. That way, the
load event for the main frame will be delayed until the image finishes
loading (and its error handler has fired), removing the need for the
setTimeout.

  • http/tests/security/xssAuditor/dom-write-innerHTML.html:
  • http/tests/security/xssAuditor/resources/echo-dom-write-innerHTML.html:
  • platform/chromium/test_expectations.txt:
01:07 Changeset [106784] by sergio@webkit.org

Incorrect statistics shown when running run-webkit-tests with --repeat-each or --iterations
https://bugs.webkit.org/show_bug.cgi?id=77672

Reviewed by Dirk Pranke.

Test repetitions must be taken into account when working out
the statistics shown by run-webkit-tests.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.prepare_lists_and_print_output):
(Manager._print_result_summary):

  • Scripts/webkitpy/layout_tests/models/result_summary.py:

(ResultSummary.init):
(ResultSummary.add):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_repeat_each_iterations_num_tests):

00:56 Changeset [106783] by barraclough@apple.com

Remove JSObject defineGetter/defineSetter lookupGetter/lookupSetter
https://bugs.webkit.org/show_bug.cgi?id=77451

Reviewed by Sam Weinig.

These can now all be implemented in terms of defineOwnProperty & getPropertyDescriptor.
Also remove initializeGetterSetterProperty, since this is equivalent to putDirectAccessor.

Source/JavaScriptCore:

(JSC::DebuggerActivation::defineOwnProperty):

  • debugger/DebuggerActivation.h:

(DebuggerActivation):

  • runtime/ClassInfo.h:

(MethodTable):
(JSC):

  • runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::finishCreation):

  • runtime/JSCell.cpp:

(JSC):

  • runtime/JSCell.h:

(JSCell):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::getOwnPropertyDescriptor):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::defineOwnProperty):
(JSC):

  • runtime/JSGlobalObject.h:

(JSGlobalObject):

  • runtime/JSObject.cpp:

(JSC):

  • runtime/JSObject.h:

(JSObject):

  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncDefineGetter):
(JSC::objectProtoFuncDefineSetter):
(JSC::objectProtoFuncLookupGetter):
(JSC::objectProtoFuncLookupSetter):

Source/WebCore:

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore):
(WebCore::JSDOMWindow::defineOwnProperty):

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore):

  • bindings/js/JSDOMWindowShell.h:

(JSDOMWindowShell):

  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::defineOwnProperty):
(WebCore::JSLocationPrototype::defineOwnProperty):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

  • page/DOMWindow.idl:
  • page/Location.idl:

Source/WebKit/qt:

  • Api/qwebframe.cpp:

(QWebFramePrivate::addQtSenderToGlobalObject):

00:51 Changeset [106782] by carlosgc@webkit.org

Source/JavaScriptCore: Unreviewed. Fix make distcheck.

  • GNUmakefile.list.am: Add missing files.

Source/WebCore: Unreviewed. Fix make distrcheck.

  • GNUmakefile.am: Fix typo in inspector json file.
  • GNUmakefile.list.am: Remove non existent file.
00:38 Changeset [106781] by pfeldman@chromium.org

Merge 106638 - Web Inspector: preserve elements panel selection upon node drag'n'drop
https://bugs.webkit.org/show_bug.cgi?id=77722

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: inspector/elements/move-node.html

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype._markRevision):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype._ondrop):
(WebInspector.ElementsTreeOutline.prototype._doMove.callback):
(WebInspector.ElementsTreeOutline.prototype._doMove):

LayoutTests:

  • inspector/elements/move-node-expected.txt: Added.
  • inspector/elements/move-node.html: Added.

TBR=pfeldman@chromium.org
BUG=112578
Review URL: https://chromiumcodereview.appspot.com/9328038

00:04 Changeset [106780] by yurys@chromium.org

2012-02-06 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Qt minimal compilation fix after r106777.

  • inspector/InspectorDatabaseAgent.h: added missing #if ENABLED guards.

02/05/12:

23:54 Changeset [106779] by loislo@chromium.org

Web Inspector: REGRESSION detached dom nodes aren't highlighted
https://bugs.webkit.org/show_bug.cgi?id=77829

This functionality was lost when I replaced (Native roots) with (Detached DOM trees) on v8 side.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.get isDetachedDOMTreesRoot):
(WebInspector.HeapSnapshot.prototype._markDetachedDOMTreeNodes):

23:52 Changeset [106778] by loislo@chromium.org

Web Inspector: get rid of artificial heap snapshot nodes from the retaining tree.
https://bugs.webkit.org/show_bug.cgi?id=77850

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotObjectNode):
(WebInspector.HeapSnapshotObjectNode.prototype.updateHasChildren):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.get isArtificial):
(WebInspector.HeapSnapshot.prototype._init):

23:39 Changeset [106777] by yurys@chromium.org

Web Inspector: CodeGeneratorInspector.py: switch domain agents to formal interfaces in BackendDispatcher
https://bugs.webkit.org/show_bug.cgi?id=77444

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-05
Reviewed by Yury Semikhatsky.

All agent code is switched to formal interfaces. Actual agent class
names and includes are dropped from InspectorBackendDispatcher.h.

  • inspector/CodeGeneratorInspector.py:

(DomainNameFixes.get_fixed_data):
(Generator.go):

  • inspector/InspectorAgent.h:
  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getMatchedStylesForNode):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::highlightNode):

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

  • inspector/InspectorDOMDebuggerAgent.h:
  • inspector/InspectorDOMStorageAgent.h:
  • inspector/InspectorDatabaseAgent.h:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::continueToLocation):

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

  • inspector/InspectorFileSystemAgent.h:
  • inspector/InspectorIndexedDBAgent.h:
  • inspector/InspectorMemoryAgent.h:
  • inspector/InspectorPageAgent.h:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::getProfile):
(WebCore::InspectorProfilerAgent::removeProfile):

  • inspector/InspectorProfilerAgent.h:

(InspectorProfilerAgent):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::setExtraHTTPHeaders):

  • inspector/InspectorResourceAgent.h:

(InspectorResourceAgent):

  • inspector/InspectorRuntimeAgent.h:
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::start):

  • inspector/InspectorTimelineAgent.h:

(InspectorTimelineAgent):

  • inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::sendMessageToWorker):

  • inspector/InspectorWorkerAgent.h:

(InspectorWorkerAgent):

23:06 Changeset [106776] by haraken@chromium.org

Rename [TreatNullAs=EmptyString] to [TreatNullAs=NullString],
[TreatUndefinedAs=EmptyString] to [TreatUndefinedAs=NullString]
https://bugs.webkit.org/show_bug.cgi?id=77611

Reviewed by Adam Barth.

While the Web IDL spec requires [TreatNullAs=EmptyString] and [TreatUndefinedAs=EmptyString],
the current WebKit treats them as (not an empty string but) a null string.
To avoid confusion, this patch renames [TreatNullAs=EmptyString] to [TreatNullAs=NullString],
and [TreatUndefinedAs=EmptyString] to [TreatUndefinedAs=NullString].
(Eventually we should fix WebKit so that it uses an empty string and then
rename them to [TreatNullAs=EmptyString] and [TreatUndefinedAs=EmptyString].)

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm: Added FIXME.

(JSValueToNative):

  • bindings/scripts/CodeGeneratorV8.pm: Ditto.

(GetNativeTypeFromSignature):

  • bindings/scripts/test/TestObj.idl:
  • css/CSSCharsetRule.idl:
  • css/CSSPageRule.idl:
  • css/CSSRule.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSStyleRule.idl:
  • css/CSSValue.idl:
  • css/MediaList.idl:
  • css/WebKitCSSKeyframesRule.idl:
  • dom/Attr.idl:
  • dom/CharacterData.idl:
  • dom/DOMImplementation.idl:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/NamedNodeMap.idl:
  • dom/Node.idl:
  • dom/ProcessingInstruction.idl:
  • dom/ShadowRoot.idl:
  • fileapi/Blob.idl:
  • fileapi/DirectoryEntry.idl:
  • fileapi/DirectoryEntrySync.idl:
  • fileapi/Entry.idl:
  • fileapi/EntrySync.idl:
  • fileapi/WebKitBlobBuilder.idl:
  • html/HTMLAnchorElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLCanvasElement.idl:
  • html/HTMLDocument.idl:
  • html/HTMLElement.idl:
  • html/HTMLFieldSetElement.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLKeygenElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLOutputElement.idl:
  • html/HTMLScriptElement.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/HTMLTitleElement.idl:
  • html/canvas/CanvasRenderingContext2D.idl:
  • page/Console.idl:
  • page/DOMWindow.idl:
  • storage/StorageEvent.idl:
  • svg/SVGAngle.idl:
  • svg/SVGElement.idl:
  • svg/SVGLength.idl:
  • svg/SVGScriptElement.idl:
22:44 Changeset [106775] by fpizlo@apple.com

DFG's child references from one node to another should have room for type information
https://bugs.webkit.org/show_bug.cgi?id=77797

Reviewed by Oliver Hunt.

The DFG::Node::child fields now contain both a DFG::NodeIndex (which is just an unsigned)
and a DFG::UseKind (which is currently an effectively empty enum). They are encapsulated
together as a DFG::NodeUse, which can in most cases still be used as an index (for
example DFG::Graph, AbstractState, and SpeculativeJIT all accept NodeUse in most places
where they really want a NodeIndex).

The NodeUse stores both the index and the UseKind without bloating the memory usage of
DFG::Node, since we really don't need full 32 bits for the NodeIndex (a DFG::Node is
roughly 11 words, so if we assume that we never want to use more than 1GB to DFG compile
something - likely a sensible assumption! - then we will only be able to have room for
about 24 million nodes, which means we only need about 24.5 bits for the node index).
Currently the DFG::NodeUse allocates 4 bits for the UseKind and 28 bits for the index,
but stores the index as a signed number to make NoNode work naturally. Hence we really
just have 27 bits for the index.

This is performance-neutral on all benchmarks we track.

(JSC::DFG::AbstractState::forNode):
(AbstractState):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::toInt32):
(JSC::DFG::ByteCodeParser::addVarArgChild):
(JSC::DFG::ByteCodeParser::processPhiStack):

  • dfg/DFGCommon.h:
  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(DFG):

  • dfg/DFGGraph.h:

(Graph):
(JSC::DFG::Graph::operator[]):
(JSC::DFG::Graph::at):
(JSC::DFG::Graph::ref):
(JSC::DFG::Graph::deref):
(JSC::DFG::Graph::clearAndDerefChild1):
(JSC::DFG::Graph::clearAndDerefChild2):
(JSC::DFG::Graph::clearAndDerefChild3):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::getPrediction):

  • dfg/DFGNode.h:

(JSC::DFG::Node::Node):
(JSC::DFG::Node::child1):
(JSC::DFG::Node::child1Unchecked):
(JSC::DFG::Node::child2):
(JSC::DFG::Node::child3):
(JSC::DFG::Node::firstChild):
(JSC::DFG::Node::numChildren):
(JSC::DFG::Node::dumpChildren):
(Node):

  • dfg/DFGNodeReferenceBlob.h: Added.

(DFG):
(NodeReferenceBlob):
(JSC::DFG::NodeReferenceBlob::NodeReferenceBlob):
(JSC::DFG::NodeReferenceBlob::child):
(JSC::DFG::NodeReferenceBlob::child1):
(JSC::DFG::NodeReferenceBlob::child2):
(JSC::DFG::NodeReferenceBlob::child3):
(JSC::DFG::NodeReferenceBlob::child1Unchecked):
(JSC::DFG::NodeReferenceBlob::initialize):
(JSC::DFG::NodeReferenceBlob::firstChild):
(JSC::DFG::NodeReferenceBlob::setFirstChild):
(JSC::DFG::NodeReferenceBlob::numChildren):
(JSC::DFG::NodeReferenceBlob::setNumChildren):

  • dfg/DFGNodeUse.h: Added.

(DFG):
(NodeUse):
(JSC::DFG::NodeUse::NodeUse):
(JSC::DFG::NodeUse::indexUnchecked):
(JSC::DFG::NodeUse::index):
(JSC::DFG::NodeUse::setIndex):
(JSC::DFG::NodeUse::useKind):
(JSC::DFG::NodeUse::setUseKind):
(JSC::DFG::NodeUse::isSet):
(JSC::DFG::NodeUse::operator!):
(JSC::DFG::NodeUse::operator==):
(JSC::DFG::NodeUse::operator!=):
(JSC::DFG::NodeUse::shift):
(JSC::DFG::NodeUse::makeWord):
(JSC::DFG::operator==):
(JSC::DFG::operator!=):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::vote):
(JSC::DFG::Propagator::toDouble):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::canonicalize):
(JSC::DFG::Propagator::startIndex):
(JSC::DFG::Propagator::globalVarLoadElimination):
(JSC::DFG::Propagator::getByValLoadElimination):
(JSC::DFG::Propagator::getByOffsetLoadElimination):
(JSC::DFG::Propagator::performSubstitution):
(JSC::DFG::Propagator::performNodeCSE):

  • dfg/DFGScoreBoard.h:

(JSC::DFG::ScoreBoard::use):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::useChildren):
(JSC::DFG::SpeculativeJIT::writeBarrier):
(JSC::DFG::SpeculativeJIT::nonSpeculativeStrictEq):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileSoftModulo):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileArithSub):
(JSC::DFG::SpeculativeJIT::compileStrictEqForConstant):
(JSC::DFG::SpeculativeJIT::compileStrictEq):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::at):
(JSC::DFG::SpeculativeJIT::canReuse):
(JSC::DFG::SpeculativeJIT::use):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
(JSC::DFG::IntegerOperand::IntegerOperand):
(JSC::DFG::DoubleOperand::DoubleOperand):
(JSC::DFG::JSValueOperand::JSValueOperand):
(JSC::DFG::StorageOperand::StorageOperand):
(JSC::DFG::SpeculateIntegerOperand::SpeculateIntegerOperand):
(JSC::DFG::SpeculateStrictInt32Operand::SpeculateStrictInt32Operand):
(JSC::DFG::SpeculateDoubleOperand::SpeculateDoubleOperand):
(JSC::DFG::SpeculateCellOperand::SpeculateCellOperand):
(JSC::DFG::SpeculateBooleanOperand::SpeculateBooleanOperand):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compileValueAdd):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileValueAdd):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

21:55 Changeset [106774] by abarth@webkit.org

xss-DENIED-from-data-url-in-foreign-domain-subframe.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=77849

Reviewed by Kentaro Hara.

This test doesn't seem to be sequenced correctly w.r.t. the load events
of the various frames involved. This patch re-orders some of the
triggers in the hopes of making the test no longer flaky.

  • http/tests/security/dataURL/resources/foreign-domain-data-url-accessor-iframe.html:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe.html:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
  • platform/chromium/test_expectations.txt:
20:47 Changeset [106773] by haraken@chromium.org

Rename [JSCCustom*] IDL to [JSCustom*] IDL
https://bugs.webkit.org/show_bug.cgi?id=77844

Reviewed by Adam Barth.

Most existing JSC-specific IDLs have "JS" prefix. We can rename [JSCCustom] to
[JSCustom], [JSCCustomGetter] to [JSCustomGetter], and [JSCCustomSetter] to
[JSCustomSetter].

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • css/CSSStyleDeclaration.idl:
  • html/HTMLDocument.idl:
  • html/canvas/DataView.idl:
  • page/DOMWindow.idl:
  • page/MemoryInfo.idl:
  • webaudio/ConvolverNode.idl:
  • webaudio/DOMWindowWebAudio.idl:
  • webaudio/WaveShaperNode.idl:
  • websockets/DOMWindowWebSocket.idl:
  • workers/WorkerContext.idl:
20:01 Changeset [106772] by commit-queue@webkit.org

[EFL] Enable WebGL with glx backend
https://bugs.webkit.org/show_bug.cgi?id=77308

Patch by ChangSeok Oh <shivamidow@gmail.com> on 2012-02-05
Reviewed by Martin Robinson.

.:

Enabled WebGL feature for EFL port. The way is very similar to the one of GTK port.

  • Source/cmake/OptionsEfl.cmake: Added feature option for WebGL.

Source/WebCore:

Implemented WebGL feature for EFL port. The way is very similar to the one of GTK port.

No new tests required. We can verify this feature with the existing test cases.

  • CMakeLists.txt: Revised common files required for WebGL.
  • PlatformEfl.cmake: Added EFL specific files.
  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::getContext):

  • platform/graphics/ANGLEWebKitBridge.h:
  • platform/graphics/GraphicsContext3D.h:

(WebCore):
(WebCore::GraphicsContext3D::platformTexture):
(GraphicsContext3D):
(WebCore::GraphicsContext3D::paintsIntoCanvasBuffer):

  • platform/graphics/efl/DrawingBufferEfl.cpp: Copied from GTK port.

(WebCore):
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::~DrawingBuffer):
(WebCore::DrawingBuffer::platformColorBuffer):
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):

  • platform/graphics/efl/GraphicsContext3DEfl.cpp: Almost same with GraphicsContext3DGtk.cpp.

(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
(WebCore::GraphicsContext3D::isGLES2Compliant):

  • platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::createVertexArrayOES):
(WebCore::Extensions3DOpenGL::deleteVertexArrayOES):
(WebCore::Extensions3DOpenGL::isVertexArrayOES):
(WebCore::Extensions3DOpenGL::bindVertexArrayOES):

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

Source/WebKit/efl:

Activated WebGL feature.

  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):

19:53 Changeset [106771] by inferno@chromium.org

Crash in FormSubmission::create.
https://bugs.webkit.org/show_bug.cgi?id=77813

Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/forms/form-submission-create-crash.xhtml

  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):

LayoutTests:

  • fast/forms/form-submission-create-crash-expected.txt: Added.
  • fast/forms/form-submission-create-crash.xhtml: Added.
18:25 Changeset [106770] by kling@webkit.org

Remove unused file MappedAttributeEntry.h.
<http://webkit.org/b/77841>

Reviewed by Anders Carlsson.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/MappedAttributeEntry.h: Removed.
  • dom/StyledElement.h:
18:21 Changeset [106769] by kling@webkit.org

StyledElement: Rename parseMappedAttribute() to parseAttribute().
<http://webkit.org/b/77830>

Reviewed by Anders Carlsson.

Rename across the board and decorate subclasses with OVERRIDE.

18:06 Changeset [106768] by kov@webkit.org

Unreviewed syntax fix.

  • English.lproj/localizedStrings.js:
17:33 Changeset [106767] by kling@webkit.org

Swedish buildfix.

  • dom/Document.cpp:

(WebCore::wheelEventHandlerCountChanged):

16:43 Changeset [106766] by andersca@apple.com

The scrolling tree should be aware of any wheel event handlers on the page
https://bugs.webkit.org/show_bug.cgi?id=77840

Reviewed by Andreas Kling.

If there are wheel event handlers on the page, any wheel events must be redispatched
to the main thread so they can go through the DOM event handling.

  • dom/Document.cpp:

(WebCore::wheelEventHandlerCountChanged):
Inform the scrolling coordinator that the wheel event count changed.

(WebCore::Document::didAddWheelEventHandler):
(WebCore::Document::didRemoveWheelEventHandler):
Call wheelEventHandlerCountChanged.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::frameViewWheelEventHandlerCountChanged):
Call recomputeWheelEventHandlerCount.

(WebCore::ScrollingCoordinator::recomputeWheelEventHandlerCount):
Update the scrolling tree state.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::ScrollingTree):
Initialize m_hasWheelEventHandlers to false.

(WebCore::ScrollingTree::tryToHandleWheelEvent):
If m_hasWheelEventHandlers is true, bail.

(WebCore::ScrollingTree::commitNewTreeState):
Update m_hasWheelEventHandlers.

  • page/scrolling/ScrollingTreeState.cpp:

(WebCore::ScrollingTreeState::ScrollingTreeState):
(WebCore::ScrollingTreeState::setWheelEventHandlerCount):
Add getter and setter for the wheel event handler count.

14:27 Changeset [106765] by abarth@webkit.org

Rebaseline xss-inactive-closure.html. This test "fails" because of a
subtle difference in how V8 and JSC do security checks. Essentially,
V8 does security checks based on the current ScriptExecutionContext
whereas JSC does security checks based on the current DOMWindow. I'm
working on fixing these differences in bugs like
https://bugs.webkit.org/show_bug.cgi?id=75793, but it's a long road.

In any case, the behavior indicated by this test is fine from a
security point of view, so it's better to rebaseline this test because
that will let us detect future regressions.

  • platform/chromium/http/tests/security/listener/xss-inactive-closure-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
14:16 Changeset [106764] by abarth@webkit.org

Rebaseline xss-DENIED-defineProperty. These V8-specific results appear
to also be passing, just with slightly fewer console messages.

  • platform/chromium/http/tests/security/xss-DENIED-defineProperty-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
14:02 Changeset [106763] by abarth@webkit.org

Further cleanup of failing and flaky security LayoutTests. This patch
updates the expectations to match the behavior as described by the
flakiness dashboard.

  • platform/chromium/test_expectations.txt:
13:54 Changeset [106762] by abarth@webkit.org

This test is no longer flaky. It appears to pass all the time.

  • platform/chromium/test_expectations.txt:
10:51 Changeset [106761] by mitz@apple.com

<rdar://problem/10809525> WebKit2’s WebFrameLoaderClient::shouldUseCredentialStorage() always returns true
https://bugs.webkit.org/show_bug.cgi?id=77823

Reviewed by Anders Carlsson.

Source/WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.cpp:

(WebKit::InjectedBundlePageResourceLoadClient::shouldUseCredentialStorage): Added. Calls
through to the client if it implements shouldUseCredentialStorage. Returns true otherwise.

  • WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::shouldUseCredentialStorage): Changed to call the injected
bundle resource load client.

Tools:

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.

06:02 Changeset [106760] by gyuyoung.kim@samsung.com

[EFL] Remove g_thread_init() calls
https://bugs.webkit.org/show_bug.cgi?id=77828

Reviewed by Andreas Kling.

g_thread_init has been deprecated since glib 2.32. This function is no longer necessary.
The GLib threading system is automatically initialized at the start of your program.

  • ewk/ewk_main.cpp:

(_ewk_init_body):

01:36 Changeset [106759] by gyuyoung.kim@samsung.com

[CMAKE] Support javascriptcore test for EFL port.
https://bugs.webkit.org/show_bug.cgi?id=77425

Reviewed by Daniel Bates.

Efl and WinCE as well as Blackberry port are now using Cmake as its build system
and they are share the make file to create jsc excutable. In order to run
"run-javascriptcore-tests", EFL port needs to change jsc installation configuration
with executable output directory(e.g. Programs). So, this patch change jsc installation
configuration only for EFL port.

.:

  • Source/cmake/OptionsEfl.cmake: Change *jsc_efl* name with *jsc*.

Source/JavaScriptCore:

  • shell/CMakeLists.txt:
01:27 Changeset [106758] by gyuyoung.kim@samsung.com

[CMAKE] Do not build Tools when building jsc only.
https://bugs.webkit.org/show_bug.cgi?id=77826

Reviewed by Daniel Bates.

Do not build Tools when jsc is only built. Build breaks occur because
Tools is built together when building jsc.

  • CMakeLists.txt: Build Tools directory when ENABLE_TOOLS is on.
01:26 Changeset [106757] by kling@webkit.org

Remove mapped vs non-mapped attribute distinction.
<http://webkit.org/b/77827>

Reviewed by Antti Koivisto.

Removed the isMappedAttribute flag from Attribute as it no longer serves
a practical purpose. Previously, StyledElement would generate mapped
attributes and plain Element would generate non-mapped ones.

The distinction is now made much more clearly by dividing the work between
Element's and StyledElement's attributeChanged() methods. The only thing
that StyledElement wants to do in addition to what Element does is
calling parseMappedAttribute() (which we'll rename in a later patch.)

  • dom/Attribute.cpp:

(WebCore::Attribute::clone):

  • dom/Attribute.h:

(WebCore::Attribute::create):
(WebCore::Attribute::Attribute):
(Attribute):

  • dom/Document.cpp:

(WebCore::Document::createAttributeNS):

  • dom/Element.cpp:

(WebCore::Element::attributeChanged):

  • dom/Element.h:

(Element):

  • dom/Node.cpp:

(WebCore::Node::dumpStatistics):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::parseMappedAttribute):

  • dom/StyledElement.h:

(StyledElement):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::attributesForIsindexInput):

  • html/parser/TextDocumentParser.cpp:

(WebCore::TextDocumentParser::insertFakePreElement):

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::getPresentationAttribute):

  • xml/parser/MarkupTokenBase.h:

(WebCore::::initializeAttributes):

00:29 Changeset [106756] by kling@webkit.org

Kill CSSMappedAttributeDeclaration.
<http://webkit.org/b/77820>

Reviewed by Antti Koivisto.

Replace all use of CSSMappedAttributeDeclaration by StylePropertySet.
Moved the setNeedsStyleRecalc() calls from CSSMappedAttributeDeclaration
to the add/remove-CSS-property helpers in StyledElement.

This removes one step of indirection for attribute styles and reduces
the size of elements that have presentational attributes by one pointer.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/CSSMappedAttributeDeclaration.cpp: Removed.
  • dom/CSSMappedAttributeDeclaration.h: Removed.
  • dom/DOMAllInOne.cpp:

Remove CSSMappedAttributeDeclaration.{cpp,h}

  • css/CSSParser.h:
  • css/CSSParser.cpp:

(WebCore::parseSimpleLengthValue):

Remove CSSParser::parseMappedAttributeValue(), we now use parseValue()
directly instead. We lose the benefit of caching new CSSValues in the
document's CSSValuePool but this optimization can be added back later.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::matchAllRules):

  • dom/ElementAttributeData.h:

(ElementAttributeData):

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::ensureAttributeStyle):

  • dom/NamedNodeMap.h:

(WebCore::NamedNodeMap::attributeStyle):
(NamedNodeMap):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::removeCSSProperties):
(WebCore::StyledElement::addCSSProperty):
(WebCore::StyledElement::addCSSImageProperty):
(WebCore::StyledElement::addCSSLength):
(WebCore::StyledElement::addCSSColor):

  • dom/StyledElement.h:

(WebCore):
(WebCore::StyledElement::attributeStyle):
(WebCore::StyledElement::ensureAttributeStyle):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::buildArrayForAttributeStyles):

00:27 Changeset [106755] by loislo@chromium.org

Web Inspector: beautify retaining tree items view.
https://bugs.webkit.org/show_bug.cgi?id=77810

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotGenericObjectNode.prototype._createObjectCell):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):

  • inspector/front-end/heapProfiler.css:

(.cycled-ancessor-node):

  • inspector/front-end/profilesPanel.css:

02/04/12:

22:13 Changeset [106754] by shawnsingh@chromium.org

[chromium] Add support to force full damage in CCDamageTracker
https://bugs.webkit.org/show_bug.cgi?id=76805

Reviewed by James Robinson.

Source/WebCore:

Unit test added to CCDamageTrackerTest.cpp.

This feature is needed for events that should cause the entire
surface to be damaged, even if layers themselves had only partial
damage or no damage at all. For example, tab-switching is one such
event.

  • platform/graphics/chromium/cc/CCDamageTracker.cpp:

(WebCore::CCDamageTracker::CCDamageTracker):
(WebCore::CCDamageTracker::updateDamageRectForNextFrame):

  • platform/graphics/chromium/cc/CCDamageTracker.h:

(WebCore::CCDamageTracker::forceFullDamageNextUpdate):
(CCDamageTracker):

Source/WebKit/chromium:

  • tests/CCDamageTrackerTest.cpp:

(WebKitTests::TEST_F):
(WebKitTests):

18:53 Changeset [106753] by mitz@apple.com

<rdar://problem/10660698> Clients cannot prevent caching of individual responses
https://bugs.webkit.org/show_bug.cgi?id=77822

Reviewed by Sam Weinig.

Source/WebKit2:

  • Shared/APIClientTraits.cpp: Added definition of interfaceSizesByVersion for

WKBundlePageResourceLoadClient.

  • Shared/APIClientTraits.h: Added APIClientTraits specialization for WKBundlePageResourceLoadClient.
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h: Added WKBundlePageShouldCacheResponseCallback

typedef, added shouldCacheResponse member to WKBundlePageResourceLoadClient, and bumped
kWKBundlePageResourceLoadClientCurrentVersion to 1.

  • WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.cpp:

(WebKit::InjectedBundlePageResourceLoadClient::shouldCacheResponse): Added. Calls through
to the client if it implements shouldCacheResponse. Returns true otherwise.

  • WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::willCacheResponse): Changed to call
InjectedBundlePageResourceLoadClient::shouldCacheResponse() and return nil if the former
returns false.
(WebKit::WebFrameLoaderClient::shouldCacheResponse): Changed to call
InjectedBundlePageResourceLoadClient::shouldCacheResponse().

Tools:

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.

17:03 Changeset [106752] by andersca@apple.com

Remove dead code from ScrollingCoordinator
https://bugs.webkit.org/show_bug.cgi?id=77821

Reviewed by Sam Weinig.

  • WebCore.exp.in:
  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::ScrollingCoordinator):

  • page/scrolling/ScrollingCoordinator.h:

(ScrollingCoordinator):

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinator::frameViewScrollLayerDidChange):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::frameViewDidChangeSize):
(WebCore::RenderLayerCompositor::updateRootLayerPosition):

16:55 Changeset [106751] by weinig@apple.com

Add ability to send WKURLRequests in WebKit2 API user messages
https://bugs.webkit.org/show_bug.cgi?id=77819

Reviewed by Anders Carlsson.

Source/WebKit2:

Test: WebKit2UserMessageRoundTripTest API test.

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
Add encode/decode for WebURLRequest.

Tools:

Add testing for round-tripping WKTypes from the UIProcess,
to the WebProcess, and back.

  • This commit adds a test fixture and tests for WKURLRequestRef, WKURLRef, and WKStringRef. More can easily be added.
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Added.

(TestWebKitAPI):
(WebKit2UserMessageRoundTripTest):
(TestWebKitAPI::WebKit2UserMessageRoundTripTest::WebKit2UserMessageRoundTripTest):
(TestWebKitAPI::WebKit2UserMessageRoundTripTest::didReceiveMessageFromInjectedBundle):
(TestWebKitAPI::WebKit2UserMessageRoundTripTest::didFinishLoadForFrame):
(TestWebKitAPI::WebKit2UserMessageRoundTripTest::setInjectedBundleClient):
(TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
(TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp):
(TestWebKitAPI::WebKit2UserMessageRoundTripTest::roundTrip):
(TestWebKitAPI::TEST_F):

  • TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp: Added.

(TestWebKitAPI):
(UserMessageTest):
(TestWebKitAPI::UserMessageTest::UserMessageTest):
(TestWebKitAPI::UserMessageTest::didReceiveMessage):

  • TestWebKitAPI/mac/PlatformWebViewMac.mm:

(TestWebKitAPI::PlatformWebView::resizeTo):
(TestWebKitAPI):

  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
  • TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
16:43 Changeset [106750] by andersca@apple.com

The scrolling tree should inform the main scrolling coordinator when the scroll position changes
https://bugs.webkit.org/show_bug.cgi?id=77818

Reviewed by Sam Weinig.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::updateMainFrameScrollPosition):
Set the main frame scroll position.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::updateMainFrameScrollPosition):
Call ScrollingCoordinator::updateMainFrameScrollPosition on the main thread.

  • page/scrolling/mac/ScrollingTreeNodeMac.mm:

(WebCore::ScrollingTreeNodeMac::scrollBy):
Call ScrollingTree::updateMainFrameScrollPosition.

16:18 Changeset [106749] by mitz@apple.com

<rdar://problem/10772406> WKPreferences instances cannot be copied
https://bugs.webkit.org/show_bug.cgi?id=77816

Reviewed by Sam Weinig.

Source/WebKit2:

Test added in TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesCreateCopy): Added.

  • UIProcess/API/C/WKPreferencesPrivate.h:
  • UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::WebPreferences): Added this constructor that copies the
WebPreferencesStore of the given WebPreferences.

  • UIProcess/WebPreferences.h:

(WebKit::WebPreferences::create): Added this create function that takes a WebPreferences
instance and creates a new instance with a copy of the given instance’s store.

Tools:

  • TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:

(TestWebKitAPI::TEST):

15:49 Changeset [106748] by barraclough@apple.com

Rubber stamped by Sam Weinig.

  • yarr/YarrPattern.cpp:

(JSC::Yarr::YarrPatternConstructor::quantifyAtom):

  • Fix comment.
14:56 Changeset [106747] by commit-queue@webkit.org

Fix bug in svg-link-hover-use.svg
https://bugs.webkit.org/show_bug.cgi?id=77768

Patch by Philip Rogers <pdr@google.com> on 2012-02-04
Reviewed by Eric Seidel.

  • ManualTests/svg-link-hover-use.svg:
14:56 Changeset [106746] by kling@webkit.org

Element: Remove unnecessary attributeChanged() argument.
<http://webkit.org/b/77814>

Reviewed by Ryosuke Niwa.

Remove the 'preserveDecls' argument to Element::attributeChanged() as that is no
longer needed after the removal of per-attribute style declarations.
Decorated subclass overrides with OVERRIDE since we're touching the lines.

Also removed an old inaccurate comment in NamedNodeMap::setAttributes() - calling
attributeChanged() is absolutely necessary to initialize element-specific state.

  • dom/Element.cpp:

(WebCore::Element::attributeChanged):

  • dom/Element.h:

(Element):

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::setAttributes):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::attributeChanged):

  • dom/StyledElement.h:

(StyledElement):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateType):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::attributeChanged):

  • html/HTMLMediaElement.h:

(HTMLMediaElement):

  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::attributeChanged):

  • html/HTMLScriptElement.h:

(HTMLScriptElement):

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::attributeChanged):

  • html/HTMLTrackElement.h:

(HTMLTrackElement):

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::attributeChanged):

  • svg/SVGAnimationElement.h:
  • svg/SVGElement.cpp:

(WebCore::SVGElement::attributeChanged):

  • svg/SVGElement.h:

(SVGElement):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::attributeChanged):

  • svg/animation/SVGSMILElement.h:

(SVGSMILElement):

14:44 Changeset [106745] by commit-queue@webkit.org

[GTK] CurrentTime: Reorder headers for win32
https://bugs.webkit.org/show_bug.cgi?id=77808

Patch by Kalev Lember <kalevlember@gmail.com> on 2012-02-04
Reviewed by Martin Robinson.

In GTK+ win32 port, monotonicallyIncreasingTime() implementation is
based on g_get_monotonic_time(). Reorder headers to make sure glib.h
gets included even when the platform is win32.

CurrentTime.cpp: In function 'double WTF::monotonicallyIncreasingTime()':
CurrentTime.cpp:321:53: error: 'g_get_monotonic_time' was not declared in this scope
CurrentTime.cpp:322:1: warning: control reaches end of non-void function [-Wreturn-type]

  • wtf/CurrentTime.cpp:
14:40 Changeset [106744] by commit-queue@webkit.org

Crash when reparenting children of flexible boxes
https://bugs.webkit.org/show_bug.cgi?id=77458

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-02-04
Reviewed by Ojan Vafai.

Source/WebCore:

This fixes some regressions I introduced in r106150. RenderBlock::
removeChild needs to be careful about not collapsing anonymous
blocks underneath flexible boxes, and also about node ordering
when there is an after block.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeChild):
(WebCore::RenderBlock::collapseAnonymousBoxChild):

LayoutTests:

This test case reparents a block node from under a flexible box so
that only anonymous blocks and floating generated blocks remain.
A recent patch caused these anonymous blocks to be collapsed, which
is incorrect.

  • fast/css-generated-content/remove-div-from-flexible-box-with-floating-after-content-crash-expected.txt: Added
  • fast/css-generated-content/remove-div-from-flexible-box-with-floating-after-content-crash.html: Added
14:26 Changeset [106743] by rniwa@webkit.org

Debug build fix after r106715.

  • html/HTMLDetailsElement.cpp:

(WebCore::DetailsSummaryElement::create):

14:24 Changeset [106742] by commit-queue@webkit.org

[GTK] Use the wide character version of win32 API by default
https://bugs.webkit.org/show_bug.cgi?id=77809

Patch by Kalev Lember <kalevlember@gmail.com> on 2012-02-04
Reviewed by Martin Robinson.

Certain win32-specific files (like PluginDatabaseWin.cpp) make the
assumption that the wide character version of win32 API is the default.
Define _UNICODE and UNICODE to do this, similar to what other win32
ports are doing.

  • GNUmakefile.am:
13:31 Changeset [106741] by kling@webkit.org

Unreviewed test fix after r106740.
<http://webkit.org/b/77204>

Disable matched declaration caching for elements with attribute style until we can
figure out how it's supposed to work.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::matchAllRules):

04:24 Changeset [106740] by kling@webkit.org

Kill per-Attribute style declarations.
<http://webkit.org/b/77204>

Reviewed by Antti Koivisto.

Source/WebCore:

TL;DR summary: Remove the per-Attribute style declarations and replace them by a single
style declaration on StyledElement that acts as a secondary inline style.

The previous design was conceived in the Age of the Old Web(tm) where the majority of
element styling was accomplished via attributes. Nowadays, CSS is a much better tool for
this and we should optimize around that instead.

StyledElements now have an attributeStyle() which contains all the styling from attributes.
parseMappedAttribute() is responsible for adding/removing properties to the attributeStyle
as the corresponding attributes come in/out of the element.

Each Attribute instance shrinks by one pointer, each element that has attributes grows by
one pointer. The styles from individual attributes are no longer shared, so content that
uses a lot of repeating styling attributes will see a slight memory regression from this.
Future improvements to this could enable sharing the attributeStyle between elements that
have the same exact attributes to mitigate some of the damage.

There should be no web-facing behavior change from this, but it does break two things:

  • The Inspector feature for displaying per-attribute styles. To keep things manageable, this patch simply files all the attribute styles together under an anonymous attribute in the Inspector.
  • The Obj-C DOM binding for Attr::style() has to be kept for compatibility reasons, though it's already deprecated. It will now always return nil, since there's no way to retrieve a live style declaration that's specific to a certain Attr.
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::matchAllRules):
(WebCore::CSSStyleSelector::canShareStyleWithElement):

  • dom/Attr.h:

(WebCore):
(Attr):
(WebCore::Attr::style):

  • dom/Attribute.cpp:

(WebCore::Attribute::clone):

  • dom/Attribute.h:

(WebCore):
(WebCore::Attribute::create):
(WebCore::Attribute::createMapped):
(Attribute):
(WebCore::Attribute::Attribute):

  • dom/CSSMappedAttributeDeclaration.cpp:

(WebCore::CSSMappedAttributeDeclaration::~CSSMappedAttributeDeclaration):
(WebCore::CSSMappedAttributeDeclaration::setMappedProperty):

  • dom/CSSMappedAttributeDeclaration.h:

(CSSMappedAttributeDeclaration):
(WebCore::CSSMappedAttributeDeclaration::CSSMappedAttributeDeclaration):

  • dom/Element.h:

(Element):

  • dom/ElementAttributeData.h:

(ElementAttributeData):

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::ensureAttributeStyle):
(WebCore):

  • dom/NamedNodeMap.h:

(WebCore::NamedNodeMap::attributeStyle):
(NamedNodeMap):

  • dom/StyledElement.cpp:

(WebCore):
(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::removeCSSProperties):
(WebCore::StyledElement::addCSSProperty):
(WebCore::StyledElement::addCSSImageProperty):
(WebCore::StyledElement::addCSSLength):
(WebCore::StyledElement::addCSSColor):

  • dom/StyledElement.h:

(StyledElement):
(WebCore::StyledElement::removeCSSProperty):
(WebCore::StyledElement::attributeStyle):
(WebCore::StyledElement::ensureAttributeStyle):

  • html/HTMLBRElement.cpp:

(WebCore::HTMLBRElement::parseMappedAttribute):

  • html/HTMLBRElement.h:

(HTMLBRElement):

  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::parseMappedAttribute):

  • html/HTMLBodyElement.h:

(HTMLBodyElement):

  • html/HTMLDivElement.cpp:

(WebCore::HTMLDivElement::parseMappedAttribute):

  • html/HTMLDivElement.h:

(HTMLDivElement):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::applyBorderAttribute):
(WebCore::HTMLElement::mapLanguageAttributeToLocale):
(WebCore::HTMLElement::parseMappedAttribute):
(WebCore::HTMLElement::removeHTMLAlignment):
(WebCore):
(WebCore::HTMLElement::addHTMLAlignmentToStyledElement):
(WebCore::HTMLElement::setContentEditable):

  • html/HTMLElement.h:

(HTMLElement):

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::parseMappedAttribute):

  • html/HTMLEmbedElement.h:

(HTMLEmbedElement):

  • html/HTMLFontElement.cpp:

(WebCore::HTMLFontElement::parseMappedAttribute):

  • html/HTMLFontElement.h:

(HTMLFontElement):

  • html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::parseMappedAttribute):

  • html/HTMLFrameSetElement.h:

(HTMLFrameSetElement):

  • html/HTMLHRElement.cpp:

(WebCore::HTMLHRElement::parseMappedAttribute):

  • html/HTMLHRElement.h:

(HTMLHRElement):

  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::parseMappedAttribute):

  • html/HTMLIFrameElement.h:

(HTMLIFrameElement):

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseMappedAttribute):

  • html/HTMLImageElement.h:

(HTMLImageElement):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::parseMappedAttribute):

  • html/HTMLInputElement.h:

(HTMLInputElement):

  • html/HTMLLIElement.cpp:

(WebCore::HTMLLIElement::parseMappedAttribute):

  • html/HTMLLIElement.h:

(HTMLLIElement):

  • html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::parseMappedAttribute):

  • html/HTMLMarqueeElement.h:

(HTMLMarqueeElement):

  • html/HTMLOListElement.cpp:

(WebCore::HTMLOListElement::parseMappedAttribute):

  • html/HTMLOListElement.h:

(HTMLOListElement):

  • html/HTMLOutputElement.cpp:
  • html/HTMLOutputElement.h:

(HTMLOutputElement):

  • html/HTMLParagraphElement.cpp:

(WebCore::HTMLParagraphElement::parseMappedAttribute):

  • html/HTMLParagraphElement.h:

(HTMLParagraphElement):

  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::parseMappedAttribute):

  • html/HTMLPlugInElement.h:

(HTMLPlugInElement):

  • html/HTMLPreElement.cpp:

(WebCore::HTMLPreElement::parseMappedAttribute):

  • html/HTMLPreElement.h:

(HTMLPreElement):

  • html/HTMLTableCaptionElement.cpp:

(WebCore::HTMLTableCaptionElement::parseMappedAttribute):

  • html/HTMLTableCaptionElement.h:

(HTMLTableCaptionElement):

  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::parseMappedAttribute):

  • html/HTMLTableCellElement.h:

(HTMLTableCellElement):

  • html/HTMLTableColElement.cpp:

(WebCore::HTMLTableColElement::parseMappedAttribute):

  • html/HTMLTableColElement.h:

(HTMLTableColElement):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::parseMappedAttribute):

  • html/HTMLTableElement.h:

(HTMLTableElement):

  • html/HTMLTablePartElement.cpp:

(WebCore):
(WebCore::HTMLTablePartElement::parseMappedAttribute):

  • html/HTMLTablePartElement.h:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::parseMappedAttribute):

  • html/HTMLUListElement.cpp:

(WebCore::HTMLUListElement::parseMappedAttribute):

  • html/HTMLUListElement.h:

(HTMLUListElement):

  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::parseMappedAttribute):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::buildArrayForAttributeStyles):

  • mathml/MathMLElement.cpp:

(WebCore::MathMLElement::parseMappedAttribute):

  • mathml/MathMLElement.h:
  • svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::parseMappedAttribute):

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::parseMappedAttribute):
(WebCore::SVGStyledElement::getPresentationAttribute):

  • svg/SVGStyledElement.h:

(SVGStyledElement):

  • svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::parseMappedAttribute):

LayoutTests:

Rebaselined 3 inspector tests since attribute styles are no longer shown per-attribute.

  • inspector/elements/elements-panel-styles-expected.txt:
  • inspector/styles/styles-computed-trace-expected.txt:
  • inspector/styles/styles-new-API-expected.txt:
02:22 Changeset [106739] by abarth@webkit.org

garden-o-matic's All Failure tab should let you examine and rebaseline expected failures
https://bugs.webkit.org/show_bug.cgi?id=77802

Reviewed by Eric Seidel.

This patch refactors our directory grouping code into base.js where it
can be shared between failures.js and notifications.js. It then adds
an Examine action to each group of failures that triggers the "results"
view.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
02:20 Changeset [106738] by loislo@chromium.org

Web Inspector: get rid of cycles in retaining tree
https://bugs.webkit.org/show_bug.cgi?id=77801

Drive by fix: 'retained by' prefix was removed.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotObjectNode):
(WebInspector.HeapSnapshotObjectNode.prototype._updateHasChildren):
(WebInspector.HeapSnapshotObjectNode.prototype._createChildNode):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):

  • inspector/front-end/profilesPanel.css:

(.cycled-ancessor-node):

02:12 Changeset [106737] by haraken@chromium.org

Add the "JS" prefix to JSC specific IDL attributes
https://bugs.webkit.org/show_bug.cgi?id=77693

Reviewed by Darin Adler.

Some JSC specific IDLs do not have "JS" prefix, e.g. [CustomIsReachable].
It might be OK since JSC is the main JavaScript engine in WebKit, but
distinguishing IDLs widely used in WebKit and IDLs used in JSC only would help
people understand the role of IDLs.

This patch renames the following JSC specific IDLs:

CustomFinalize => JSCustomFinalize
CustomIsReachable => JSCustomIsReachable
CustomMarkFunction => JSCustomMarkFunction
CustomToJS => JSCustomToJS
CustomNativeConverter => JSCustomToNativeObject (Note: For naming consistency with [JSCustomToJS])
GenerateIsReachable => JSGenerateIsReachable
GenerateToJS => JSGenerateToJS
NoStaticTables => JSNoStaticTables
WindowEventListener => JSWindowEventListener
InlineGetOwnPropertySlot => JSInlineGetOwnPropertySlot
DelegatingPrototypePutFunction => JSCustomPrototypePutDelegate

No tests. No changes in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(HasCustomToV8Implementation):

  • bindings/scripts/test/TestTypedArray.idl: No change in run-bindings-tests results.
  • css/CSSRule.idl:
  • css/CSSRuleList.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSValue.idl:
  • css/MediaList.idl:
  • css/MediaQueryListListener.idl:
  • css/StyleMedia.idl:
  • css/StyleSheet.idl:
  • css/StyleSheetList.idl:
  • dom/Attr.idl:
  • dom/DOMCoreException.idl:
  • dom/DOMImplementation.idl:
  • dom/DOMStringMap.idl:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/ErrorEvent.idl:
  • dom/Event.idl:
  • dom/EventException.idl:
  • dom/EventListener.idl:
  • dom/MessageChannel.idl:
  • dom/MessageEvent.idl:
  • dom/MessagePort.idl:
  • dom/NamedNodeMap.idl:
  • dom/Node.idl:
  • dom/NodeFilter.idl:
  • dom/NodeIterator.idl:
  • dom/NodeList.idl:
  • dom/TreeWalker.idl:
  • dom/WebKitNamedFlow.idl:
  • fileapi/Blob.idl:
  • fileapi/DOMFileSystem.idl:
  • fileapi/DOMFileSystemSync.idl:
  • fileapi/DirectoryEntry.idl:
  • fileapi/DirectoryEntrySync.idl:
  • fileapi/DirectoryReader.idl:
  • fileapi/DirectoryReaderSync.idl:
  • fileapi/Entry.idl:
  • fileapi/EntryArray.idl:
  • fileapi/EntryArraySync.idl:
  • fileapi/EntrySync.idl:
  • fileapi/File.idl:
  • fileapi/FileEntry.idl:
  • fileapi/FileEntrySync.idl:
  • fileapi/FileError.idl:
  • fileapi/FileException.idl:
  • fileapi/FileList.idl:
  • fileapi/FileReader.idl:
  • fileapi/FileReaderSync.idl:
  • fileapi/FileWriter.idl:
  • fileapi/Metadata.idl:
  • fileapi/OperationNotAllowedException.idl:
  • fileapi/WebKitBlobBuilder.idl:
  • html/DOMFormData.idl:
  • html/DOMSettableTokenList.idl:
  • html/DOMTokenList.idl:
  • html/DOMURL.idl:
  • html/HTMLAllCollection.idl:
  • html/HTMLBodyElement.idl:
  • html/HTMLCollection.idl:
  • html/HTMLFrameSetElement.idl:
  • html/ImageData.idl:
  • html/MediaController.idl:
  • html/TextTrack.idl:
  • html/TextTrackCue.idl:
  • html/VoidCallback.idl:
  • html/canvas/ArrayBuffer.idl:
  • html/canvas/ArrayBufferView.idl:
  • html/canvas/CanvasRenderingContext.idl:
  • html/canvas/DataView.idl:
  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/OESStandardDerivatives.idl:
  • html/canvas/OESTextureFloat.idl:
  • html/canvas/OESVertexArrayObject.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • html/canvas/Uint8ClampedArray.idl:
  • html/canvas/WebGLCompressedTextures.idl:
  • html/canvas/WebGLDebugRendererInfo.idl:
  • html/canvas/WebGLDebugShaders.idl:
  • html/canvas/WebGLLoseContext.idl:
  • html/canvas/WebGLRenderingContext.idl:
  • html/track/TextTrackList.idl:
  • loader/appcache/DOMApplicationCache.idl:
  • mediastream/LocalMediaStream.idl:
  • page/BarInfo.idl:
  • page/Console.idl:
  • page/DOMSelection.idl:
  • page/DOMWindow.idl:
  • page/EventSource.idl:
  • page/Geolocation.idl:
  • page/History.idl:
  • page/Location.idl:
  • page/Navigator.idl:
  • page/Screen.idl:
  • page/WorkerNavigator.idl:
  • plugins/DOMMimeTypeArray.idl:
  • plugins/DOMPluginArray.idl:
  • storage/Database.idl:
  • storage/DatabaseSync.idl:
  • storage/IDBAny.idl:
  • storage/IDBKey.idl:
  • storage/SQLError.idl:
  • storage/SQLException.idl:
  • storage/SQLResultSet.idl:
  • storage/SQLResultSetRowList.idl:
  • storage/SQLTransaction.idl:
  • storage/SQLTransactionSync.idl:
  • storage/Storage.idl:
  • svg/SVGElementInstance.idl:
  • svg/SVGPathSeg.idl:
  • webaudio/AudioBufferCallback.idl:
  • webaudio/AudioBufferSourceNode.idl:
  • webaudio/AudioContext.idl:
  • webaudio/AudioDestinationNode.idl:
  • webaudio/AudioGain.idl:
  • webaudio/AudioGainNode.idl:
  • webaudio/AudioPannerNode.idl:
  • webaudio/AudioProcessingEvent.idl:
  • webaudio/BiquadFilterNode.idl:
  • webaudio/ConvolverNode.idl:
  • webaudio/DelayNode.idl:
  • webaudio/DynamicsCompressorNode.idl:
  • webaudio/HighPass2FilterNode.idl:
  • webaudio/JavaScriptAudioNode.idl:
  • webaudio/LowPass2FilterNode.idl:
  • webaudio/MediaElementAudioSourceNode.idl:
  • webaudio/OfflineAudioCompletionEvent.idl:
  • webaudio/RealtimeAnalyserNode.idl:
  • webaudio/WaveShaperNode.idl:
  • websockets/CloseEvent.idl:
  • websockets/WebSocket.idl:
  • workers/AbstractWorker.idl:
  • workers/DedicatedWorkerContext.idl:
  • workers/SharedWorker.idl:
  • workers/SharedWorkerContext.idl:
  • workers/Worker.idl:
  • workers/WorkerContext.idl:
  • workers/WorkerLocation.idl:
  • xml/XMLHttpRequest.idl:
  • xml/XMLHttpRequestException.idl:
  • xml/XMLHttpRequestProgressEvent.idl:
  • xml/XMLHttpRequestUpload.idl:
  • xml/XPathResult.idl:
02:09 Changeset [106736] by abarth@webkit.org

http/tests/security/xss-eval fails due to difference in JSC and V8 eval
https://bugs.webkit.org/show_bug.cgi?id=77806

Reviewed by Eric Seidel.

Both the JSC and V8 behaviors are reasonable in this case. This patch
modifies the test to show that either behavior isn't a security
vulnerability.

  • http/tests/security/xss-eval.html:
  • platform/chromium/http/tests/security/xss-eval-expected.txt:
  • platform/chromium/test_expectations.txt:
01:50 Changeset [106735] by ojan@chromium.org

check-webkit-style is throwing an exception
https://bugs.webkit.org/show_bug.cgi?id=77744

Reviewed by David Levin.

If the test_list is None, then we don't need to check for unsupported
feature tests to skip.

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._has_test_in_directories):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(test_skipped_tests_for_unsupported_features_empty_test_list):

01:42 Changeset [106734] by eae@chromium.org

Convert RenderTheme over to new layout abstraction
https://bugs.webkit.org/show_bug.cgi?id=77783

Reviewed by Eric Seidel.

Change the RenderTheme classes to use the new layout abstraction as a
part of the ongoing conversion work.

No new tests.

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::volumeSliderOffsetFromMuteButton):
(WebCore::RenderTheme::baselinePosition):
(WebCore::RenderTheme::adjustRepaintRect):
(WebCore::RenderTheme::meterSizeForBounds):

  • rendering/RenderTheme.h:

(RenderTheme):
(WebCore::RenderTheme::paintCapsLockIndicator):

  • rendering/RenderThemeChromiumMac.h:

(RenderThemeChromiumMac):

  • rendering/RenderThemeChromiumMac.mm:

(WebCore::RenderThemeChromiumMac::volumeSliderOffsetFromMuteButton):

  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::convertToPaintingRect):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):

  • rendering/RenderThemeChromiumSkia.h:
  • rendering/RenderThemeMac.h:

(RenderThemeMac):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::adjustRepaintRect):
(WebCore::RenderThemeMac::inflateRect):
(WebCore::RenderThemeMac::setControlSize):
(WebCore::RenderThemeMac::paintCapsLockIndicator):
(WebCore::RenderThemeMac::paintMenuList):
(WebCore::RenderThemeMac::meterSizeForBounds):
(WebCore::RenderThemeMac::paintMenuListButtonGradients):
(WebCore::RenderThemeMac::setPopupButtonCellState):
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::volumeSliderOffsetFromMuteButton):

  • rendering/RenderThemeSafari.cpp:

(WebCore::RenderThemeSafari::baselinePosition):

  • rendering/RenderThemeSafari.h:

(RenderThemeSafari):

  • rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::paintSearchFieldCancelButton):
(WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeWin::paintSearchFieldResultsButton):
(WebCore::RenderThemeWin::volumeSliderOffsetFromMuteButton):

  • rendering/RenderThemeWin.h:

(RenderThemeWin):

01:40 Changeset [106733] by dgrogan@chromium.org

IndexedDB: mark quota layout test WONTFIX
https://bugs.webkit.org/show_bug.cgi?id=77459

Reviewed by Tony Chang.

  • platform/chromium/test_expectations.txt:
01:26 Changeset [106732] by senorblanco@chromium.org

[chromium] Fix multi-second hangs in compositor invalidating large layers
https://bugs.webkit.org/show_bug.cgi?id=77774

Reviewed by James Robinson.

Correctness covered by existing tests.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::pushPropertiesTo):
Remove tiles from the tiler when they are invalid (ie., no longer have
texture backing).
(WebCore::TiledLayerChromium::invalidateRect):
Instead of iterating over the tile indices (which may be very large),
iterate over the tile hash map instead.

01:24 Changeset [106731] by commit-queue@webkit.org

[BlackBerry] Upstream BlackBerry WebCoreSupport ClientExtension and GeolocationControllerClientBlackBerry classes
https://bugs.webkit.org/show_bug.cgi?id=77751

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-02-04
Reviewed by Rob Buis.

Initial upstream, no new tests.

  • blackberry/WebCoreSupport/ClientExtension.cpp: Added.
  • blackberry/WebCoreSupport/ClientExtension.h: Added.
  • blackberry/WebCoreSupport/GeolocationControllerClientBlackBerry.cpp: Added.
  • blackberry/WebCoreSupport/GeolocationControllerClientBlackBerry.h: Added.
01:19 Changeset [106730] by commit-queue@webkit.org

Source/WebCore: Patch by Swapna P <spottabathini@innominds.com> on 2012-02-04
Reviewed by Antonio Gomes.

Bug: iframe with scrolling=no incorrectly autoscrollable
https://bugs.webkit.org/show_bug.cgi?id=61558

Added check for frame scrolling mode just before applying scroll on frame content in function RenderLayer::scrollRect

Testcase: LayoutTests/fast/events/autoscroll-with-non-scrollable-parent.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollRectToVisible):

LayoutTests: Patch by Swapna P <spottabathini@innominds.com> on 2012-02-04
Reviewed by Antonio Gomes.

Bug: iframe with scrolling=no incorrectly autoscrollable
https://bugs.webkit.org/show_bug.cgi?id=61558

Did change inorder to print correct log as per the description provided in test case.

  • fast/events/autoscroll-with-non-scrollable-parent.html:

02/03/12:

22:43 Changeset [106729] by timothy_horton@apple.com

Canvas-into-canvas drawing should respect backing store scale ratio
https://bugs.webkit.org/show_bug.cgi?id=77784
<rdar://problem/10549729>

Reviewed by Dan Bernstein.

Respect the backing store scale ratio when drawing a canvas into another
canvas via ctx.drawImage(canvas, x, y). Previous behavior caused canvas
drawing to differ based on the size of the backing store, which is ideally
an implementation detail to authors.

Also, rename the source canvas arguments to CanvasRenderingContext2D::drawImage
to be more clear.

No new tests.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawImage):

20:45 Changeset [106728] by abarth@webkit.org

Add a Chromium-specific baseline for this test. These results appear to be passing.

  • platform/chromium-win/http/tests/security/cross-frame-access-put-expected.txt: Removed.
  • platform/chromium/http/tests/security/cross-frame-access-put-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
19:59 Changeset [106727] by abarth@webkit.org

List of all failures in garden-o-matic should actually list all the failures
https://bugs.webkit.org/show_bug.cgi?id=77796

Reviewed by Eric Seidel.

This patch wires a bit more data into the new "All Failures" tab. I've
also iterated on how we enable this experimental feature. The tab is
still just a dumb list, but we'll make it smarter.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
19:50 Changeset [106726] by rniwa@webkit.org

Windows build fix after r106692.

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_reference_files):

18:01 Changeset [106725] by bdakin@apple.com

https://bugs.webkit.org/show_bug.cgi?id=77782
WebPageProxy::didNewFirstVisuallyNonEmptyLayout should is called more than
once on some pages with frames
-and corresponding-
<rdar://problem/10798474>

Reviewed by Sam Weinig.

Source/WebCore:

startCountingRelevantRepaintedObjects() should only be called for the main
frame. Otherwise, the counter will be re-set inappropriately, and
didNewFirstVisuallyNonEmptyLayout may even end up firing more than once.

  • page/FrameView.cpp:

(WebCore::FrameView::performPostLayoutTasks):

Tools:

One new test.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp: Added.

(TestWebKitAPI):
(TestWebKitAPI::didForceRepaint):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp: Added.

(TestWebKitAPI):
(NewFirstVisuallyNonEmptyLayoutFramesTest):
(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::NewFirstVisuallyNonEmptyLayoutFramesTest):
(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):

  • TestWebKitAPI/Tests/WebKit2/lots-of-iframes.html: Added.
17:59 Changeset [106724] by benjamin@webkit.org

Reduce the memory allocations of WebCore's cssPropertyName()
https://bugs.webkit.org/show_bug.cgi?id=74782

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-02-03
Reviewed by Geoffrey Garen.

Add a fast path to avoid the use of the StringBuilder.

The string builder is needed for two cases:
-CSS prefix (the character after the prefix must be uppercase)
-JavaScript CamelCase name for CSS properties

We can skip all memory allocations if the property is not in those
two cases. We start by testing the string for uppercase characters,
and just return the an identical string.

This patch create a "fast case" 2.7 times faster than previously.
The "slow case" is 2-3% slower due to the additional check at the beginning.

  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore):
(WebCore::containsASCIIUpperChar):
(WebCore::cssPropertyName):
(WebCore::isCSSPropertyName):

17:56 Changeset [106723] by andersca@apple.com

WebKit2 should dispatch wheel events to the new ScrollingTree class
https://bugs.webkit.org/show_bug.cgi?id=77795

Reviewed by Andreas Kling.

Source/WebCore:

  • WebCore.exp.in:

Add new symbols needed by WebKit2.

  • WebCore.xcodeproj/project.pbxproj:

Make ScrollingTree.h private so it can be included by WebKit2.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::scrollingTree):

  • page/scrolling/ScrollingCoordinator.h:

Add a scrolling tree getter.

Source/WebKit2:

Replace all uses of ScrollingCoordinator with ScrollingTree instead.
Also, don't try to handle gesture events on the scrolling thread anymore;
we don't need to to that right now.

  • WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::addScrollingTreeForPage):
(WebKit::EventDispatcher::removeScrollingTreeForPage):
(WebKit::EventDispatcher::wheelEvent):
(WebKit::EventDispatcher::gestureEvent):

  • WebProcess/WebPage/EventDispatcher.h:

(WebCore):
(EventDispatcher):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::~TiledCoreAnimationDrawingArea):

17:45 Changeset [106722] by dslomov@google.com

[Chromium] WebCore::toV8Context crashes if DomWindow::frame() returns null.
https://bugs.webkit.org/show_bug.cgi?id=77686.

Reviewed by Adam Barth.

  • bindings/v8/V8Helpers.cpp:

(WebCore::toV8Context):

17:41 Changeset [106721] by dpranke@chromium.org

webkitpy: change exit() calls to sys.exit(), fix a leak in outputcapture
https://bugs.webkit.org/show_bug.cgi?id=77781

Reviewed by Eric Seidel.

This change fixes a couple of issues discovered while debugging
test-webkitpy; both calling exit() instead of sys.exit() --
which is discouraged in program code instead of the interpreter
-- and a particular usage of outputcapture were stdin to get whacked
and preventing debugging.

This change introduces a couple of common _exit() methods that
will standardize how webkit-patch exit's, in case we need to do
something different in the future.

  • Scripts/webkitpy/common/system/deprecated_logging.py:

(error):

  • Scripts/webkitpy/common/system/outputcapture.py:

(OutputCapture.assert_outputs):

  • Scripts/webkitpy/tool/bot/queueengine.py:

(QueueEngine.exit_after_handled_error):

  • Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:

(AbstractSequencedCommand.execute):

  • Scripts/webkitpy/tool/commands/queues.py:

(StyleQueue.handle_script_error):

  • Scripts/webkitpy/tool/commands/upload.py:

(MarkBugFixed.execute):

  • Scripts/webkitpy/tool/multicommandtool.py:

(Command._exit):

  • Scripts/webkitpy/tool/steps/abstractstep.py:

(AbstractStep._exit):

  • Scripts/webkitpy/tool/steps/checkstyle.py:

(CheckStyle.run):

  • Scripts/webkitpy/tool/steps/commit.py:

(Commit._check_test_expectations):

  • Scripts/webkitpy/tool/steps/confirmdiff.py:

(ConfirmDiff.run):

17:33 Changeset [106720] by andersca@apple.com

The scrolling tree should be able to handle wheel events
https://bugs.webkit.org/show_bug.cgi?id=77794

Reviewed by Andreas Kling.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::tryToHandleWheelEvent):
New function. Currently this always returns that it was able to handle the wheel event,
but this will change in the future.

(WebCore::ScrollingTree::handleWheelEvent):
Ask the root node to handle the wheel event.

  • page/scrolling/ScrollingTreeNode.h:

Add a handleWheelEvent pure virtual member function.

  • page/scrolling/mac/ScrollingTreeNodeMac.mm:

(WebCore::ScrollingTreeNodeMac::handleWheelEvent):
Call scrollBy for now. Eventually this should use a scroll elasticity controller to handle
things like rubber-banding.

(WebCore::ScrollingTreeNodeMac::scrollPosition):
(WebCore::ScrollingTreeNodeMac::setScrollPosition):
Add getters and setters for the scroll position.

(WebCore::ScrollingTreeNodeMac::scrollBy):
Update the scroll position given the offset.

17:32 Changeset [106719] by lforschler@apple.com

buildbot fix for curl.

17:30 Changeset [106718] by vangelis@chromium.org

Merge 106672 - REGRESSION (r105401-105403): Blue flash on css border transition
https://bugs.webkit.org/show_bug.cgi?id=77491

Reviewed by Simon Fraser.

Source/WebCore:

The new blend function added with r105403 takes unsigned as parameters therefore
we have to be careful to not overflow in case the to is less than from (animating
from 400 to 0 for example).

Test: animations/animation-border-overflow.html

  • platform/animation/AnimationUtilities.h:

(WebCore::blend):

LayoutTests:

  • animations/animation-border-overflow-expected.txt: Added.
  • animations/animation-border-overflow.html: Added.

TBR=alexis.menard@openbossa.org
Review URL: https://chromiumcodereview.appspot.com/9328025

17:29 Changeset [106717] by ap@apple.com

[WK2 Mac] No need to allow access to input methods or keyboard layouts
https://bugs.webkit.org/show_bug.cgi?id=77775
<rdar://problem/9276253>
<rdar://problem/9276268>

Reviewed by Dan Bernstein.

  • WebProcess/com.apple.WebProcess.sb: These rules were likely only necessary in early days

of WebKit2. If there are cases when this happens, that's likely wrong, and we need to know
about that.

17:26 Changeset [106716] by lforschler@apple.com

Another http -> https fix for curl

17:22 Changeset [106715] by rniwa@webkit.org

Crash in Node::dispatchSubtreeModifiedEvent
https://bugs.webkit.org/show_bug.cgi?id=77449

Reviewed by Alexey Proskuryakov.

Source/WebCore:

The bug was caused by appendChild not retaining this pointer.
This is normally okay because there's another owner within JSC/V8 binding code that
holds onto the node but this isn't the case when nodes are created as a part
of setting document.title. Fixed the crash by retaining the pointer as needed.

Test: fast/dom/remove-body-during-title-creation.html

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::appendChild):

LayoutTests:

Add a regression test for the crash.

  • fast/dom/remove-body-during-title-creation-expected.txt: Added.
  • fast/dom/remove-body-during-title-creation.html: Added.
17:19 Changeset [106714] by rniwa@webkit.org

Perf bot build fix.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._generate_json):

17:18 Changeset [106713] by abarth@webkit.org

Add a blank "Expected Failures" tab to garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=77793

Reviewed by Eric Seidel.

This tab will help us explore and manage our expected failures. The
tab is hidden by default via a new "experimental features" flag.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:

(#unexpected):
(#onebar.partytime #unexpected):

17:09 Changeset [106712] by lforschler@apple.com

Fix other instances of http://developer links which should be https://developer

17:05 Changeset [106711] by andersca@apple.com

Apply changed properties from the updated scrolling tree state
https://bugs.webkit.org/show_bug.cgi?id=77792

Reviewed by Andreas Kling.

  • page/scrolling/ScrollingTreeNode.cpp:

(WebCore::ScrollingTreeNode::update):
Update the tree node properties from the scrolling tree state.

  • page/scrolling/ScrollingTreeNode.h:

(WebCore::ScrollingTreeNode::scrollingTree):
(WebCore::ScrollingTreeNode::viewportRect):
(WebCore::ScrollingTreeNode::contentsSize):
Add getters.

  • page/scrolling/ScrollingTreeState.h:

(WebCore::ScrollingTreeState::changedProperties):
New function for accessing the changed properties of the scrolling tree state.

  • page/scrolling/mac/ScrollingTreeNodeMac.h:
  • page/scrolling/mac/ScrollingTreeNodeMac.mm:

(WebCore::ScrollingTreeNodeMac::update):
Update the scroll layer from the scrolling tree if necessary.

16:57 Changeset [106710] by lforschler@apple.com

Fix URL string

16:31 Changeset [106709] by ap@apple.com

[WK2] Use properly quoted string literals
https://bugs.webkit.org/show_bug.cgi?id=77583

Reviewed by Darin Adler.

Also added some FIXMEs.

  • WebProcess/com.apple.WebProcess.sb:
16:29 Changeset [106708] by lforschler@apple.com

update-webkit-support-libraries is broken with the change from http to https on developer.apple.com
https://bugs.webkit.org/show_bug.cgi?id=77785

Fix the build bots.

Pass the -k and --sslv3 keys to make curl work with https on https://developer.apple.com

  • Scripts/update-webkit-support-libs:

(downloadExpectedVersionNumber):

16:24 Changeset [106707] by andersca@apple.com

Prefix the typedef in WTF_MAKE_FAST_ALLOCATED with underscores
https://bugs.webkit.org/show_bug.cgi?id=77788

Reviewed by Andreas Kling.

The current typedef name, 'ThisIsHereToForceASemicolonAfterThisMacro', shows up when trying to
code-complete 'this' in Xcode. Prefix the typedef with two underscores to stop this from happening.

  • wtf/FastAllocBase.h:
16:22 Changeset [106706] by beidson@apple.com

2012-02-03 Brady Eidson <beidson@apple.com>

<rdar://problem/10742441> and https://bugs.webkit.org/show_bug.cgi?id=77766
Need a WK2 API to filter which subframes go into WebArchives as they are created.

Reviewed by Darin Adler.

Source/WebCore:

This adds a filter callback object that allows clients to get called back for each
subframe that might be added to a WebArchive.

API only, No new layout tests.

  • WebCore.exp.in:
  • loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::create):
(WebCore::LegacyWebArchive::createFromSelection):

  • loader/archive/cf/LegacyWebArchive.h:

(FrameFilter):
(WebCore:: FrameFilter::~ FrameFilter):
(LegacyWebArchive):

Source/WebKit2:

Add a new WKBundleFrame API that takes a filter callback object to allow or reject
subframes from a WebArchive:

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameCopyWebArchive):
(WKBundleFrameCopyWebArchiveFilteringSubframes):

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h:

Implement the above API by calling through to WebCore:

  • WebProcess/WebPage/WebFrame.cpp:

(WebFrameFilter):
(WebKit::WebFrameFilter::WebFrameFilter):
(WebKit::WebFrameFilter::shouldIncludeSubframe):
(WebKit::WebFrame::webArchiveData):

  • WebProcess/WebPage/WebFrame.h:

(WebFrame):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::getWebArchiveOfFrame):

16:16 Changeset [106705] by jsbell@chromium.org

IndexedDB: Key generators not rolled back if insertion fails or is aborted
https://bugs.webkit.org/show_bug.cgi?id=77060

Reviewed by Tony Chang.

Source/WebCore:

Test: storage/indexeddb/key-generator.html

  • storage/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::put): Add abort task to reset cache.
(WebCore::IDBObjectStoreBackendImpl::revertAutoIncrementKeyCache):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::putInternal): Reset cache on error.

  • storage/IDBObjectStoreBackendImpl.h:

(IDBObjectStoreBackendImpl):

LayoutTests:

  • storage/indexeddb/key-generator-expected.txt: Added.
  • storage/indexeddb/key-generator.html: Added.
16:10 Changeset [106704] by tony@chromium.org

positive and negative flex values are not being cleared on style changes
https://bugs.webkit.org/show_bug.cgi?id=77771

Reviewed by Ojan Vafai.

Source/WebCore:

If the width or height was a flex() value, but is no longer a flex
value, we weren't clearing the positive and negative flex values in
RenderStyle.

Test: css3/flexbox/flex-no-flex.html

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyLength::applyValue):

LayoutTests:

  • css3/flexbox/flex-no-flex-expected.txt: Added.
  • css3/flexbox/flex-no-flex.html: Added.
16:01 Changeset [106703] by lforschler@apple.com

Add a Mac Lion Performance bot.
https://bugs.webkit.org/show_bug.cgi?id=77765

Reviewed by Adam Roben.

This will update the master configuration in the following ways:

Add a new performance slave (apple-xseve-11)
Add a new Factory to download a build and run perf tests.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(DownloadAndPerfTestFactory):
(DownloadAndPerfTestFactory.init):

15:53 Changeset [106702] by dpranke@chromium.org

Extra TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk in repository
https://bugs.webkit.org/show_bug.cgi?id=77752

Reviewed by James Robinson.

Delete unneeded file accidentally checked in in r106481.

  • TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk: Removed.
15:47 Changeset [106701] by ap@apple.com

[Mac WK2] Use a minimally invasive way to fake plug-in process name
https://bugs.webkit.org/show_bug.cgi?id=77682

Reviewed by Darin Adler.

  • PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::netscapePluginModule):

Only change the name as it's seen from within the process.

  • Shared/Plugins/PluginQuirks.h: Fixed a typo.
15:18 Changeset [106700] by jamesr@google.com

[chromium] Defer makeContextCurrent in compositor until first frame
https://bugs.webkit.org/show_bug.cgi?id=77269

Reviewed by Kenneth Russell.

Source/WebCore:

There are situations where we need to instantiate a compositor, but can't call makeContextCurrent() until some
initialization work completes on another thread that we cannot block for. This defers the first
makeContextCurrent() call until we need to produce the first frame at which point we know the call can succeed,
assuming that the scheduler does the right thing.

This is accomplished by splitting up proxy initialization into two pieces:
*) initializeContext() which attempts to instantiate a GraphicsContext3D. This can fail if we can't make a
context at all, in which case we abort completely and return NULL from CCLayerTreeHost::create().

*) initializeLayerRenderer() which uses the previously-created context to instantiate our compositor objects and

grab our renderer capabilities. This can fail if the context is not usable for compositing, which we report
to the client as a lost context event.

Internally this introduces a new state to the CCLayerTreeHostImpl where it has a context but does not yet have a
LayerRendererChromium, which has fairly minimal impact. One other change is that we don't instantiate the
TextureManagers until we have the renderer capabilities, but this isn't necessary until we want to start
painting so it doesn't have any impact outside of some overly intrustive unit tests.

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::paintContentsIfDirty):
(WebCore::ContentLayerChromium::createTextureUpdater):

  • platform/graphics/chromium/ContentLayerChromium.h:

(ContentLayerChromium):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/ImageLayerChromium.h:

(ImageLayerChromium):

  • platform/graphics/chromium/TiledLayerChromium.cpp:
  • platform/graphics/chromium/TiledLayerChromium.h:

(WebCore::TiledLayerChromium::setSampledTexelFormat):
(TiledLayerChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::initializeLayerRenderer):
(WebCore):
(WebCore::CCLayerTreeHost::beginCommitOnImplThread):
(WebCore::CCLayerTreeHost::compositeAndReadback):
(WebCore::CCLayerTreeHost::finishAllRendering):
(WebCore::CCLayerTreeHost::setViewportSize):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::updateLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):
():

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::isContextLost):

  • platform/graphics/chromium/cc/CCProxy.h:

(CCProxy):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::CCSingleThreadProxy):
(WebCore::CCSingleThreadProxy::compositeAndReadback):
(WebCore::CCSingleThreadProxy::initializeContext):
(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::layerRendererCapabilities):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(CCSingleThreadProxy):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::initializeContext):
(WebCore):
(WebCore::CCThreadProxy::initializeLayerRenderer):
(WebCore::CCThreadProxy::layerRendererCapabilities):
(WebCore::CCThreadProxy::initializeImplOnImplThread):
(WebCore::CCThreadProxy::initializeContextOnImplThread):
(WebCore::CCThreadProxy::initializeLayerRendererOnImplThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestSetViewportSize::beginTest):

  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):

15:13 Changeset [106699] by jamesr@google.com

Unreviewed compile fix for chromium - add commas after entries in list in WebCore.gypi

  • WebCore.gypi:
15:03 Changeset [106698] by kling@webkit.org

Unreviewed build fix attempt after r106695.

CSSMutableStyleDeclaration was renamed to StylePropertySet.

  • bindings/scripts/CodeGeneratorCPP.pm:

(AddIncludesForType):

  • bindings/scripts/CodeGeneratorV8.pm:

(AddIncludesForType):

  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8Proxy.cpp:
14:52 Changeset [106697] by commit-queue@webkit.org

[BlackBerry] Let userIdleTime() return maximum number instead of 0 as
most of other ports do.
https://bugs.webkit.org/show_bug.cgi?id=77769

Patch by Yong Li <yoli@rim.com> on 2012-02-03
Reviewed by Rob Buis.

userIdleTime() should return a big number so it won't block page cache
from releasing cached pages. See PageCache::releaseAutoreleasedPagesNowOrReschedule().

No new tests as no visible functional changes.

  • platform/blackberry/SystemTimeBlackBerry.cpp:

(WebCore::userIdleTime):

14:46 Changeset [106696] by andersca@apple.com

Commit scrolling tree state changes to the scrolling tree
https://bugs.webkit.org/show_bug.cgi?id=77780

Reviewed by Darin Adler.

  • WebCore.xcodeproj/project.pbxproj:
  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::commitTreeState):
Send the new scrolling tree state over to the ScrollingTree on the scrolling thread.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::ScrollingTree):
Create a root node.

(WebCore::ScrollingTree::commitNewTreeState):
Update the root node.

  • page/scrolling/ScrollingTreeNode.cpp: Copied from Source/WebCore/page/scrolling/ScrollingTree.cpp.
  • page/scrolling/ScrollingTreeNode.h: Copied from Source/WebCore/page/scrolling/ScrollingTree.cpp.

Stub out an abstract ScrollingTreeNode class.

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinator::frameViewScrollLayerDidChange):
Update the scroll layer on the tree state.

  • page/scrolling/mac/ScrollingTreeNodeMac.h: Copied from Source/WebCore/page/scrolling/ScrollingTree.cpp.
  • page/scrolling/mac/ScrollingTreeNodeMac.mm: Copied from Source/WebCore/page/scrolling/ScrollingTree.cpp.

Stub out the concrete ScrollingTreeNodeMac subclass.

14:41 Changeset [106695] by antti@apple.com

Rename CSSMutableStyleDeclaration.h/.cpp to StylePropertySet.h/.cpp
https://bugs.webkit.org/show_bug.cgi?id=77779

Reviewed by Darin Adler.

Source/WebCore:

Match the new class name.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCSSStyleDeclarationCustom.cpp:
  • bindings/js/JSDOMBinding.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(NativeToJSValue):

  • bindings/scripts/CodeGeneratorObjC.pm:

(AddIncludesForType):

  • css/CSSAllInOne.cpp:
  • css/CSSComputedStyleDeclaration.cpp:
  • css/CSSFontFaceRule.cpp:
  • css/CSSFontFaceRule.h:
  • css/CSSFontSelector.cpp:
  • css/CSSMutableStyleDeclaration.cpp: Removed.
  • css/CSSMutableStyleDeclaration.h: Removed.
  • css/CSSPageRule.cpp:
  • css/CSSParser.cpp:
  • css/CSSStyleRule.cpp:
  • css/CSSStyleRule.h:
  • css/StylePropertySet.cpp: Copied from Source/WebCore/css/CSSMutableStyleDeclaration.cpp.
  • css/StylePropertySet.h: Copied from Source/WebCore/css/CSSMutableStyleDeclaration.h.
  • css/WebKitCSSKeyframeRule.cpp:
  • css/WebKitCSSKeyframeRule.h:
  • css/WebKitCSSKeyframesRule.cpp:
  • css/WebKitCSSMatrix.cpp:
  • dom/CSSMappedAttributeDeclaration.h:
  • dom/ElementAttributeData.h:
  • dom/StyledElement.cpp:
  • dom/StyledElement.h:
  • editing/ApplyStyleCommand.cpp:
  • editing/DeleteButtonController.cpp:
  • editing/EditingStyle.cpp:
  • editing/Editor.cpp:
  • editing/EditorCommand.cpp:
  • editing/RemoveCSSPropertyCommand.cpp:
  • editing/ReplaceSelectionCommand.cpp:
  • editing/markup.cpp:
  • html/canvas/CanvasRenderingContext2D.cpp:
  • html/shadow/MeterShadowElement.cpp:
  • inspector/InspectorCSSAgent.cpp:
  • inspector/InspectorDOMAgent.cpp:
  • page/DragController.cpp:
  • page/Frame.cpp:
  • rendering/RenderLayer.cpp:
  • rendering/RenderTreeAsText.cpp:
  • svg/SVGFontFaceElement.h:

(WebCore):

Source/WebKit/mac:

  • WebView/WebHTMLView.mm:

Source/WebKit/qt:

  • Api/qwebelement.cpp:
14:23 Changeset [106694] by mihnea@adobe.com

Crash in RenderFlowThread::setRegionBoxesRegionStyle
https://bugs.webkit.org/show_bug.cgi?id=77474

Reviewed by David Hyatt.

Source/WebCore:

Flexbox and deprecated flexible box should also compute their region range
when they are part of a named flow. Until now, only RenderBlock elements
were doing that. Flexbox and deprecated flexible box, while implementing
their own layoutBlock method, were not doing that.

Tests: fast/regions/flexbox-in-region-crash.html

fast/regions/select-in-region-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeInitialRegionRangeForBlock):
(WebCore):
(WebCore::RenderBlock::computeRegionRangeForBlock):
(WebCore::RenderBlock::layoutBlock):

  • rendering/RenderBlock.h:

(RenderBlock):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::removeRegionFromThread):
(WebCore::RenderFlowThread::removeRenderBoxRegionInfo):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::paintReplaced):

  • rendering/RenderRegion.h:

(RenderRegion):

LayoutTests:

  • fast/regions/flexbox-in-region-crash-expected.txt: Added.
  • fast/regions/flexbox-in-region-crash.html: Added.
  • fast/regions/select-in-region-crash-expected.txt: Added.
  • fast/regions/select-in-region-crash.html: Added.
14:07 Changeset [106693] by leviw@chromium.org

Fixing a use of enclosingIntRect in Accessibility code. Should be pixelSnapped instead.

13:48 Changeset [106692] by rniwa@webkit.org

Ref Tests should support plain SVG files
https://bugs.webkit.org/show_bug.cgi?id=77685

Reviewed by Tony Chang.

Don't assume reference files always use .html as the extension.
Instead, use the list of supported extension to look for -expected.* and -mismatch.*

Also fix various bugs in MockFileSystem and TestPort.

  • Scripts/webkitpy/common/system/filesystem_mock.py:

(MockFileSystem.isdir):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.reference_files):

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_is_test_file):
(PortTest.test_reference_files):

  • Scripts/webkitpy/layout_tests/port/test.py:

(TestInstance.init):

13:28 Changeset [106691] by piman@chromium.org

Merge 106663 - [Chromium] Use the current clip when marking paints as opaque
https://bugs.webkit.org/show_bug.cgi?id=77582

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-03
Reviewed by Stephen White.

Source/WebCore:

New unit test in PlatformContextSkiaTest.cpp

  • platform/graphics/skia/OpaqueRegionSkia.cpp:

(WebCore::OpaqueRegionSkia::markRectAsOpaque):

  • platform/graphics/skia/PlatformContextSkia.h:

(WebCore::PlatformContextSkia::canvas):

Source/WebKit/chromium:

  • tests/PlatformContextSkiaTest.cpp:

(WebCore::TEST):
(WebCore):

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9328008

13:25 Changeset [106690] by andersca@apple.com

Update the tree state after layout and add a way to commit it
https://bugs.webkit.org/show_bug.cgi?id=77767

Reviewed by Andreas Kling.

  • page/FrameView.cpp:

(WebCore::FrameView::performPostLayoutTasks):
Call ScrollingCoordinator::frameViewLayoutUpdated if we have a scrolling coordinator.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::ScrollingCoordinator):
Initialize m_scrollingTreeStateCommitterTimer.

(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
Update the viewport rect and contents size of the frame view.

(WebCore::ScrollingCoordinator::scheduleTreeStateCommit):
Schedule a tree state commit unless we've already scheduled one or there are no changed properties.

(WebCore::ScrollingCoordinator::scrollingTreeStateCommitterTimerFired):
Call commitTreeState().

(WebCore::ScrollingCoordinator::commitTreeStateIfNeeded):
Commit the tree state unless there are no changed properties.

(WebCore::ScrollingCoordinator::commitTreeState):
Commit the tree state. We currently don't do anything with the committed state yet.

  • page/scrolling/ScrollingCoordinator.h:

Add new member functions and the timer member variable.

  • page/scrolling/ScrollingTreeState.cpp:

(WebCore::ScrollingTreeState::commit):
Copy the current tree state and restore the changed properties on the original.

  • page/scrolling/ScrollingTreeState.h:

(WebCore::ScrollingTreeState::hasChangedProperties):
Return whether there are any changed properties in the tree state.

13:25 Changeset [106689] by commit-queue@webkit.org

complete rebaseline of box-shadow-clipped-slices
https://bugs.webkit.org/show_bug.cgi?id=77565

Patch by Elliot Poger <epoger@google.com> on 2012-02-03
Reviewed by Darin Adler.

  • platform/chromium/test_expectations.txt:
13:13 Changeset [106688] by commit-queue@webkit.org

[GTK] configure: Print out the -Wno-c++0x-compat test result
https://bugs.webkit.org/show_bug.cgi?id=77757

Patch by Kalev Lember <kalevlember@gmail.com> on 2012-02-03
Reviewed by Martin Robinson.

The check whether -Wno-c++0x-compat flag is needed didn't print out
the test result (and newline), which caused the following test to be
displayed on the same line.

checking if we have to disable C++0x compat warnings for GCC >= 4.6.0... checking pthread.h usability... yes

  • configure.ac:
13:10 Changeset [106687] by rniwa@webkit.org

perf-o-matic should store chromium svn revision
https://bugs.webkit.org/show_bug.cgi?id=77725

Reviewed by Dirk Pranke.

.:

Store both WebKit and Chromium revisions when both are reported.

  • Websites/webkit-perf.appspot.com/models.py:

(Build):

  • Websites/webkit-perf.appspot.com/report_handler.py:

(ReportHandler.post):
(ReportHandler._create_build_if_possible):
(ReportHandler._create_build_if_possible.execute):

  • Websites/webkit-perf.appspot.com/static/manual-submit.html:

Tools:

Report both WebKit and Chromium revisions to the graph server. Renamed test_repository_paths to
repository_paths since it's nothing to do with tests. Also refactored scm so that head_svn_revision
is implemented in terms of newly added svn_revision.

  • Scripts/webkitpy/common/checkout/scm/git.py:

(Git.svn_revision):

  • Scripts/webkitpy/common/checkout/scm/scm.py:

(SCM.head_svn_revision):
(SCM):
(SCM.svn_revision):

  • Scripts/webkitpy/common/checkout/scm/scm_mock.py:

(MockSCM.svn_revision):

  • Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN.svn_revision):

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:

(JSONLayoutResultsGenerator.init):

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

(JSONResultsGeneratorBase._insert_generic_metadata):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.repository_paths):

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.repository_paths):

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._generate_json):

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(test_run_test_set_with_json_output):
(test_run_test_set_with_json_source):
(test_run_test_set_with_multiple_repositories):

12:59 Changeset [106686] by commit-queue@webkit.org

Fix alignment warnings in ARMv7
https://bugs.webkit.org/show_bug.cgi?id=55368

Patch by Rob Buis <rbuis@rim.com> on 2012-02-03
Reviewed by Filip Pizlo.

Use reinterpret_cast_ptr and static_cast to get rid of alignment issues in ARMv7 code.

  • heap/HandleTypes.h:

(JSC::HandleTypes::getFromSlot):

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::specializedSweep):

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::forEachCell):

  • runtime/WriteBarrier.h:

(JSC::WriteBarrierBase::get):
(JSC::WriteBarrierBase::unvalidatedGet):

12:57 Changeset [106685] by kling@webkit.org

HTMLElement: Clean up tabindex attribute parsing.
<http://webkit.org/b/77763>

Reviewed by Antti Koivisto.

Remove an unnecessary getAttribute() call when parsing tabindexAttr.

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute):

12:46 Changeset [106684] by dgrogan@chromium.org

Make js-test-pre.js more worker friendly
https://bugs.webkit.org/show_bug.cgi?id=77487

Replace uses of 'window' with 'self'.

Reviewed by Ojan Vafai.

  • fast/js/resources/js-test-pre.js:
  • storage/indexeddb/resources/basics.js:
12:22 Changeset [106683] by andersca@apple.com

ScrollingTreeState should keep track of the scroll layer
https://bugs.webkit.org/show_bug.cgi?id=77762

Reviewed by Andreas Kling.

  • WebCore.xcodeproj/project.pbxproj:
  • page/scrolling/ScrollingTreeState.h:

(ScrollingTreeState):

  • page/scrolling/mac/ScrollingTreeStateMac.mm: Copied from Source/WebCore/page/scrolling/ScrollingTreeState.h.

(WebCore):
(WebCore::ScrollingTreeState::platformScrollLayer):
(WebCore::ScrollingTreeState::setScrollLayer):

12:08 Changeset [106682] by jochen@chromium.org

Merge 106636 - Crash when trying to add a timer to a detached document.
https://bugs.webkit.org/show_bug.cgi?id=77692

Reviewed by Alexey Proskuryakov.

In http://webkit.org/b/77370, a timer is fired on a detached document.
Since a document clears all timers when it is detached, and it
shouldn't be possible to add a timer to a detached document, we crash
if this should happen anyway. This will hopefully result in an easier
to debug crash dump.

  • page/DOMTimer.cpp:

(WebCore::DOMTimer::DOMTimer):

TBR=jochen@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9317088

11:46 Changeset [106681] by antti@apple.com

https://bugs.webkit.org/show_bug.cgi?id=77740
Split CSSMutableStyleDeclaration into separate internal and CSSOM types

Reviewed by Andreas Kling and Darin Adler.

Source/WebCore:

Split the CSSMutableStyleDeclaration into an internal type (StylePropertySet) and a CSSOM implementation type (PropertySetCSSStyleDeclaration).

To keep things somewhat manageable, this patch does NOT

  • rename or add any files (so files names won't match types)
  • rename fields, methods or variables to match new type names (like CSSStyleRule::declaration() -> CSSStyleRule::propertySet())
  • try to realize any memory or performance gains (StylePropertySet loses the vptr but gains PropertySetCSSStyleDeclaration*)
  • WebCore.exp.in:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::copy):
(WebCore::CSSComputedStyleDeclaration::makeMutable):
(WebCore::CSSComputedStyleDeclaration::copyPropertiesInSet):

  • css/CSSComputedStyleDeclaration.h:

(WebCore):
(CSSComputedStyleDeclaration):

  • css/CSSFontFaceRule.h:

(WebCore::CSSFontFaceRule::style):
(WebCore::CSSFontFaceRule::declaration):
(WebCore::CSSFontFaceRule::setDeclaration):
(CSSFontFaceRule):

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):

  • css/CSSMutableStyleDeclaration.cpp:

(PropertySetCSSStyleDeclaration):
(WebCore::PropertySetCSSStyleDeclaration::create):
(WebCore::PropertySetCSSStyleDeclaration::PropertySetCSSStyleDeclaration):
(WebCore):
(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::~StylePropertySet):
(WebCore::StylePropertySet::deref):
(WebCore::StylePropertySet::contextStyleSheet):
(WebCore::StylePropertySet::copyPropertiesFrom):
(WebCore::StylePropertySet::getPropertyValue):
(WebCore::StylePropertySet::borderSpacingValue):
(WebCore::StylePropertySet::appendFontLonghandValueIfExplicit):
(WebCore::StylePropertySet::fontValue):
(WebCore::StylePropertySet::get4Values):
(WebCore::StylePropertySet::getLayeredShorthandValue):
(WebCore::StylePropertySet::getShorthandValue):
(WebCore::StylePropertySet::getCommonValue):
(WebCore::StylePropertySet::getPropertyCSSValue):
(WebCore::StylePropertySet::removeShorthandProperty):
(WebCore::StylePropertySet::removeProperty):
(WebCore::StylePropertySet::setNeedsStyleRecalc):
(WebCore::StylePropertySet::propertyIsImportant):
(WebCore::StylePropertySet::getPropertyShorthand):
(WebCore::StylePropertySet::isPropertyImplicit):
(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet::parseDeclaration):
(WebCore::StylePropertySet::addParsedProperties):
(WebCore::StylePropertySet::addParsedProperty):
(WebCore::StylePropertySet::asText):
(WebCore::StylePropertySet::merge):
(WebCore::StylePropertySet::addSubresourceStyleURLs):
(WebCore::StylePropertySet::copyBlockProperties):
(WebCore::StylePropertySet::removeBlockProperties):
(WebCore::StylePropertySet::removePropertiesInSet):
(WebCore::StylePropertySet::findPropertyWithId):
(WebCore::StylePropertySet::propertyMatches):
(WebCore::StylePropertySet::removeEquivalentProperties):
(WebCore::StylePropertySet::copy):
(WebCore::StylePropertySet::copyPropertiesInSet):
(WebCore::StylePropertySet::ensureCSSStyleDeclaration):
(WebCore::PropertySetCSSStyleDeclaration::length):
(WebCore::PropertySetCSSStyleDeclaration::item):
(WebCore::PropertySetCSSStyleDeclaration::parentRule):
(WebCore::PropertySetCSSStyleDeclaration::cssText):
(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyPriority):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyShorthand):
(WebCore::PropertySetCSSStyleDeclaration::isPropertyImplicit):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
(WebCore::PropertySetCSSStyleDeclaration::parentStyleSheet):
(WebCore::PropertySetCSSStyleDeclaration::copy):
(WebCore::PropertySetCSSStyleDeclaration::makeMutable):
(WebCore::PropertySetCSSStyleDeclaration::cssPropertyMatches):

  • css/CSSMutableStyleDeclaration.h:

(WebCore):
(StylePropertySet):
(WebCore::StylePropertySet::create):
(WebCore::StylePropertySet::createInline):

  • css/CSSPageRule.h:

(WebCore):

  • css/CSSParser.cpp:

(WebCore::parseColorValue):
(WebCore::parseSimpleLengthValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseDeclaration):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createKeyframeRule):

  • css/CSSParser.h:

(WebCore):
(CSSParser):

  • css/CSSStyleDeclaration.h:

(WebCore):
(CSSStyleDeclaration):

  • css/CSSStyleRule.h:

(WebCore::CSSStyleRule::style):
(WebCore::CSSStyleRule::setDeclaration):
(WebCore::CSSStyleRule::declaration):
(CSSStyleRule):

  • css/CSSStyleSelector.cpp:

(WebCore::leftToRightDeclaration):
(WebCore::rightToLeftDeclaration):
(WebCore::CSSStyleSelector::addMatchedDeclaration):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
(WebCore::CSSStyleSelector::matchAllRules):
(WebCore::CSSStyleSelector::styleForKeyframe):
(WebCore::isInsideRegionRule):
(WebCore::CSSStyleSelector::applyDeclaration):
(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::CSSStyleSelector::matchPageRulesForList):

  • css/CSSStyleSelector.h:

(CSSStyleSelector):
(MatchedStyleDeclaration):

  • css/WebKitCSSKeyframeRule.cpp:

(WebCore::WebKitCSSKeyframeRule::setDeclaration):

  • css/WebKitCSSKeyframeRule.h:

(WebCore::WebKitCSSKeyframeRule::style):
(WebCore::WebKitCSSKeyframeRule::declaration):
(WebKitCSSKeyframeRule):

  • css/WebKitCSSMatrix.cpp:

(WebCore::WebKitCSSMatrix::setMatrixValue):

  • dom/Attr.h:

(WebCore::Attr::style):

  • dom/Attribute.h:

(WebCore::Attribute::decl):

  • dom/CSSMappedAttributeDeclaration.h:

(WebCore::CSSMappedAttributeDeclaration::declaration):
(WebCore::CSSMappedAttributeDeclaration::CSSMappedAttributeDeclaration):
(CSSMappedAttributeDeclaration):

  • dom/Document.cpp:

(WebCore::Document::createCSSStyleDeclaration):

  • dom/ElementAttributeData.h:

(ElementAttributeData):

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::ensureInlineStyleDecl):

  • dom/NamedNodeMap.h:

(WebCore::NamedNodeMap::inlineStyleDecl):
(NamedNodeMap):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::updateStyleAttribute):
(WebCore::StyledElement::copyNonAttributeProperties):
(WebCore::StyledElement::addSubresourceAttributeURLs):

  • dom/StyledElement.h:

(WebCore::StyledElement::additionalAttributeStyle):
(WebCore::StyledElement::inlineStyleDecl):
(WebCore::StyledElement::ensureInlineStyleDecl):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
(WebCore::ApplyStyleCommand::removeCSSStyle):
(WebCore::ApplyStyleCommand::addBlockStyle):
(WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):

  • editing/DeleteButtonController.cpp:

(WebCore::DeleteButtonController::createDeletionUI):

  • editing/EditingStyle.cpp:

(WebCore::copyEditingProperties):
(WebCore::editingStyleFromComputedStyle):
(WebCore):
(WebCore::HTMLElementEquivalent::propertyExistsInStyle):
(HTMLElementEquivalent):
(WebCore::HTMLElementEquivalent::valueIsPresentInStyle):
(HTMLTextDecorationEquivalent):
(WebCore::HTMLTextDecorationEquivalent::propertyExistsInStyle):
(WebCore::HTMLTextDecorationEquivalent::valueIsPresentInStyle):
(HTMLAttributeEquivalent):
(WebCore::HTMLAttributeEquivalent::valueIsPresentInStyle):
(WebCore::HTMLAttributeEquivalent::attributeValueAsCSSValue):
(WebCore::EditingStyle::EditingStyle):
(WebCore::getRGBAFontColor):
(WebCore::EditingStyle::setProperty):
(WebCore::EditingStyle::setStyle):
(WebCore::EditingStyle::overrideWithStyle):
(WebCore::EditingStyle::extractAndRemoveTextDirection):
(WebCore::EditingStyle::removeStyleAddedByNode):
(WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode):
(WebCore::EditingStyle::triStateOfStyle):
(WebCore::EditingStyle::conflictsWithInlineStyleOfElement):
(WebCore::EditingStyle::elementIsStyledSpanOrHTMLEquivalent):
(WebCore::elementMatchesAndPropertyIsNotInInlineStyleDecl):
(WebCore::EditingStyle::mergeStyle):
(WebCore::styleFromMatchedRulesForElement):
(WebCore::EditingStyle::mergeStyleFromRules):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):
(WebCore::removePropertiesInStyle):
(WebCore::EditingStyle::removeStyleFromRulesAndContext):
(WebCore::EditingStyle::removePropertiesInElementDefaultStyle):
(WebCore::EditingStyle::forceInline):
(WebCore::reconcileTextDecorationProperties):
(WebCore::StyleChange::StyleChange):
(WebCore::setTextDecorationProperty):
(WebCore::StyleChange::extractTextStyles):
(WebCore::diffTextDecorations):
(WebCore::fontWeightIsBold):
(WebCore::getTextAlignment):
(WebCore::getPropertiesNotIn):
(WebCore::getIdentifierValue):
(WebCore::isTransparentColorValue):
(WebCore::hasTransparentBackgroundColor):

  • editing/EditingStyle.h:

(WebCore):
(WebCore::EditingStyle::create):
(EditingStyle):
(WebCore::EditingStyle::style):
(StyleChange):

  • editing/Editor.cpp:

(WebCore::Editor::setBaseWritingDirection):
(WebCore::Editor::applyEditingStyleToElement):

  • editing/EditorCommand.cpp:

(WebCore::applyCommandToFrame):
(WebCore::executeApplyStyle):
(WebCore::executeToggleStyleInList):
(WebCore::executeApplyParagraphStyle):
(WebCore::executeMakeTextWritingDirectionLeftToRight):
(WebCore::executeMakeTextWritingDirectionNatural):
(WebCore::executeMakeTextWritingDirectionRightToLeft):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::copyTypingStyle):

  • editing/FrameSelection.h:

(WebCore):

  • editing/RemoveCSSPropertyCommand.cpp:

(WebCore::RemoveCSSPropertyCommand::doApply):
(WebCore::RemoveCSSPropertyCommand::doUnapply):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):

  • editing/ReplaceSelectionCommand.h:

(WebCore):

  • editing/markup.cpp:

(WebCore):
(StyledMarkupAccumulator):
(WebCore::StyledMarkupAccumulator::wrapWithStyleNode):
(WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag):
(WebCore::propertyMissingOrEqualToNone):

  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::additionalAttributeStyle):

  • html/HTMLTableCellElement.h:

(HTMLTableCellElement):

  • html/HTMLTableColElement.cpp:

(WebCore::HTMLTableColElement::additionalAttributeStyle):

  • html/HTMLTableColElement.h:

(HTMLTableColElement):

  • html/HTMLTableElement.cpp:

(WebCore::leakBorderStyle):
(WebCore::HTMLTableElement::additionalAttributeStyle):
(WebCore::HTMLTableElement::createSharedCellStyle):
(WebCore::HTMLTableElement::additionalCellStyle):
(WebCore::leakGroupBorderStyle):
(WebCore::HTMLTableElement::additionalGroupStyle):

  • html/HTMLTableElement.h:

(HTMLTableElement):

  • html/HTMLTableSectionElement.cpp:

(WebCore::HTMLTableSectionElement::additionalAttributeStyle):

  • html/HTMLTableSectionElement.h:

(HTMLTableSectionElement):

  • html/ValidationMessage.cpp:

(WebCore::adjustBubblePosition):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setFont):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::setPosition):
(WebCore::MediaControlPanelElement::resetPosition):
(WebCore::MediaControlPanelElement::makeOpaque):
(WebCore::MediaControlPanelElement::makeTransparent):

  • html/shadow/SliderThumbElement.cpp:

(WebCore::TrackLimiterElement::create):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::buildArrayForAttributeStyles):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):

  • page/DragController.cpp:

(WebCore::DragController::concludeEditDrag):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::retrieveResourcesForCSSDeclaration):

  • page/PageSerializer.h:

(WebCore):
(PageSerializer):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::resize):

  • rendering/RenderTreeAsText.cpp:

(WebCore::isEmptyOrUnstyledAppleStyleSpan):

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::SVGFontFaceElement):

Source/WebKit/mac:

  • WebView/WebFrame.mm:

(-[WebFrame _typingStyle]):

Source/WebKit/qt:

  • Api/qwebelement.cpp:

(QWebElement::styleProperty):

11:32 Changeset [106680] by jochen@chromium.org

Remove unneccesary canExecuteScripts check from v8 bindings, and correctly indeicate when we're about to execute a script
https://bugs.webkit.org/show_bug.cgi?id=76704

Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/isolatedWorld/sandboxed-iframe.html

  • bindings/v8/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute):

  • bindings/v8/V8EventListener.cpp:

(WebCore::V8EventListener::callListenerFunction):

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::callListenerFunction):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::handleOutOfMemory):
(WebCore::toV8Context):

LayoutTests:

  • http/tests/security/isolatedWorld/resources/fail.html:
  • http/tests/security/isolatedWorld/sandboxed-iframe-expected.txt:
  • http/tests/security/isolatedWorld/sandboxed-iframe.html:
11:30 Changeset [106679] by andersca@apple.com

Add ScrollingTreeState class
https://bugs.webkit.org/show_bug.cgi?id=77756

Reviewed by Andreas Kling.

Add a new ScrollingTreeState whose intent is to be a data container for the current
scrolling tree state. the ScrollingCoordinator class will update it and periodically
send over the new state to the ScrollingTree object on the scrolling thread.

  • WebCore.xcodeproj/project.pbxproj:
  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::ScrollingCoordinator):

  • page/scrolling/ScrollingCoordinator.h:

(WebCore):
(ScrollingCoordinator):

  • page/scrolling/ScrollingTreeState.cpp: Added.

(WebCore):
(WebCore::ScrollingTreeState::create):
(WebCore::ScrollingTreeState::ScrollingTreeState):
(WebCore::ScrollingTreeState::~ScrollingTreeState):
(WebCore::ScrollingTreeState::setViewportRect):
(WebCore::ScrollingTreeState::setContentsSize):

  • page/scrolling/ScrollingTreeState.h: Added.

(WebCore):
(ScrollingTreeState):
(WebCore::ScrollingTreeState::viewportRect):
(WebCore::ScrollingTreeState::contentsSize):

11:29 Changeset [106678] by bdakin@apple.com

https://bugs.webkit.org/show_bug.cgi?id=77691
Fix PlatformScreen layering violation and PlatformScreenMac's incorrect use
of device scale

Reviewed by Andy Estes.

Source/WebCore:

Make screenAvailableRect() and screenRect() take a Widget again instead of a
FrameView since taking a FrameView is a layering violation.

  • WebCore.exp.in:
  • platform/PlatformScreen.h:

(WebCore):

  • platform/blackberry/PlatformScreenBlackBerry.cpp:

(WebCore::screenAvailableRect):
(WebCore::screenRect):

  • platform/chromium/PlatformScreenChromium.cpp:

(WebCore::screenRect):
(WebCore::screenAvailableRect):

  • platform/chromium/PlatformSupport.h:

(WebCore):
(PlatformSupport):

  • platform/efl/PlatformScreenEfl.cpp:

(WebCore::screenRect):
(WebCore::screenAvailableRect):

  • platform/gtk/PlatformScreenGtk.cpp:

(WebCore::screenRect):
(WebCore::screenAvailableRect):

  • platform/qt/PlatformScreenQt.cpp:

(WebCore::screenRect):
(WebCore::screenAvailableRect):

  • platform/win/PlatformScreenWin.cpp:

(WebCore::screenRect):
(WebCore::screenAvailableRect):

  • platform/wx/ScreenWx.cpp:

(WebCore::screenRect):
(WebCore::screenAvailableRect):

It's wrong for the deviceScaleFactor to be taken into consideration here at
all.

  • platform/mac/PlatformScreenMac.mm:

(WebCore::screenRect):
(WebCore::screenAvailableRect):
(WebCore::toUserSpace):
(WebCore::toDeviceSpace):

Source/WebKit/chromium:

These two functions now take a Widget again rather than a FrameView.

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::screenRect):
(WebCore::PlatformSupport::screenAvailableRect):

Source/WebKit/mac:

toUserSpace() and toDeviceSpace() don't need to take device scale. Also
restore a comment that I needlessly removed.

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::setWindowRect):
(WebChromeClient::windowRect):

Source/WebKit2:

toUserSpace() and toDeviceSpace() don't need to take device scale.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _convertToDeviceSpace:]):
(-[WKView _convertToUserSpace:]):

11:27 Changeset [106677] by mhahnenberg@apple.com

Build fix

Unreviewed build fix

Forgot to add a couple files.

  • heap/MarkedAllocator.cpp: Added.

(JSC):
(JSC::MarkedAllocator::tryAllocateHelper):
(JSC::MarkedAllocator::tryAllocate):
(JSC::MarkedAllocator::allocateSlowCase):
(JSC::MarkedAllocator::allocateBlock):
(JSC::MarkedAllocator::addBlock):
(JSC::MarkedAllocator::removeBlock):

  • heap/MarkedAllocator.h: Added.

(JSC):
(DFG):
(MarkedAllocator):
(JSC::MarkedAllocator::cellSize):
(JSC::MarkedAllocator::heap):
(JSC::MarkedAllocator::setHeap):
(JSC::MarkedAllocator::setCellSize):
(JSC::MarkedAllocator::setMarkedSpace):
(JSC::MarkedAllocator::MarkedAllocator):
(JSC::MarkedAllocator::allocate):
(JSC::MarkedAllocator::reset):
(JSC::MarkedAllocator::zapFreeList):
(JSC::MarkedAllocator::forEachBlock):

11:21 Changeset [106676] by mhahnenberg@apple.com

Refactor MarkedBlock::SizeClass into a separate class
https://bugs.webkit.org/show_bug.cgi?id=77600

Reviewed by Geoffrey Garen.

We pulled SizeClass out into its own class, named MarkedAllocator, and gave it
the responsibility of allocating objects from the collection of MarkedBlocks
that it manages. Also limited the amount of coupling to internal data fields
from other places, although it's mostly unavoidable in the JIT code.

Eventually MarkedAllocator will implement various policies to do with object
management, e.g. whether or not to run destructors on objects that it manages.
MarkedSpace will manage a collection of MarkedAllocators with varying policies,
as it does now but to a larger extent.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::emitAllocateJSFinalObject):

  • heap/Heap.cpp:

(JSC::Heap::collect):
(JSC::Heap::resetAllocators):

  • heap/Heap.h:

(JSC::Heap::allocatorForObject):
(Heap):

  • heap/MarkedAllocator.cpp: Added.

(JSC):
(JSC::MarkedAllocator::tryAllocateHelper):
(JSC::MarkedAllocator::tryAllocate):
(JSC::MarkedAllocator::allocateSlowCase):
(JSC::MarkedAllocator::allocateBlock):
(JSC::MarkedAllocator::addBlock):
(JSC::MarkedAllocator::removeBlock):

  • heap/MarkedAllocator.h: Added.

(JSC):
(DFG):
(MarkedAllocator):
(JSC::MarkedAllocator::cellSize):
(JSC::MarkedAllocator::heap):
(JSC::MarkedAllocator::setHeap):
(JSC::MarkedAllocator::setCellSize):
(JSC::MarkedAllocator::setMarkedSpace):
(JSC::MarkedAllocator::MarkedAllocator):
(JSC::MarkedAllocator::allocate):
(JSC::MarkedAllocator::reset):
(JSC::MarkedAllocator::zapFreeList):
(JSC::MarkedAllocator::forEachBlock):

  • heap/MarkedSpace.cpp:

(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::resetAllocators):
(JSC::MarkedSpace::canonicalizeCellLivenessData):
(JSC::TakeIfUnmarked::operator()):

  • heap/MarkedSpace.h:

(MarkedSpace):
(JSC::MarkedSpace::allocatorFor):
(JSC::MarkedSpace::allocate):
(JSC::MarkedSpace::forEachBlock):
(JSC::MarkedSpace::didAddBlock):
(JSC::MarkedSpace::didConsumeFreeList):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicJSObject):

10:39 Changeset [106675] by scherkus@chromium.org

Merge 106610 - Avoid crashing renderer when GPU process dies by not caching textures between video frames.
https://bugs.webkit.org/show_bug.cgi?id=77654

Patch by Ami Fischman <fischman@chromium.org> on 2012-02-02
Reviewed by James Robinson.

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::draw):

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9309085

10:25 Changeset [106674] by mitz@apple.com

Added Radar links

10:23 Changeset [106673] by mitz@apple.com

Floating image leaves hole in previous column when wrapped to next column
https://bugs.webkit.org/show_bug.cgi?id=77694

Reviewed by Darin Adler.

Source/WebCore:

Tests: fast/dynamic/float-moved-downwards-for-pagination-expected.html

fast/dynamic/float-moved-downwards-for-pagination.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::clearFloats): When determining which lines to dirty,
also check for changes to the top edge of the float, which can happen when
float gets pushed down by a pagination strut.

LayoutTests:

  • fast/dynamic/float-moved-downwards-for-pagination-expected.html: Added.
  • fast/dynamic/float-moved-downwards-for-pagination.html: Added.
10:21 Changeset [106672] by alexis.menard@openbossa.org

REGRESSION (r105401-105403): Blue flash on css border transition
https://bugs.webkit.org/show_bug.cgi?id=77491

Reviewed by Simon Fraser.

Source/WebCore:

The new blend function added with r105403 takes unsigned as parameters therefore
we have to be careful to not overflow in case the to is less than from (animating
from 400 to 0 for example).

Test: animations/animation-border-overflow.html

  • platform/animation/AnimationUtilities.h:

(WebCore::blend):

LayoutTests:

  • animations/animation-border-overflow-expected.txt: Added.
  • animations/animation-border-overflow.html: Added.
10:02 Changeset [106671] by jesus@webkit.org

[Qt][WK2] Incorrect line number dumping
https://bugs.webkit.org/show_bug.cgi?id=60074

Reviewed by Csaba Osztrogonác.

Test http/tests/security/contentSecurityPolicy/eval-blocked.html
is now passing, unskipping it.

  • platform/qt-wk2/Skipped:
09:38 Changeset [106670] by commit-queue@webkit.org

[Chromium] ImageBufferSkia: remove unnecessary overload of flush in
AcceleratedDeviceContext
https://bugs.webkit.org/show_bug.cgi?id=77741

Patch by Justin Novosad <junov@chromium.org> on 2012-02-03
Reviewed by Stephen White.

Removing dead code.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(AcceleratedDeviceContext):

09:31 Changeset [106669] by jknotten@chromium.org

[skia] Fix unit test PlatformContextSkiaTest.trackOpaqueOvalTest
https://bugs.webkit.org/show_bug.cgi?id=77738

We need to clear the bitmap before the test runs, otherwise the
contents of the bitmap will be uninitialised. This causes an
unpredicatable result as the canvas draw operations blend the
destination bitmap with the source colour.

Similarly, valgrind discovered that
PlatformContextSkiaTest.trackOpaqueTest and
PlatformContextSkiaTest.trackOpaqueLineTest suffers from the same
problem.

Also, re-enable WebFrameTest.FindInPage which was falsely
blamed for making this test fail.

Reviewed by Stephen White.

  • tests/PlatformContextSkiaTest.cpp:

(WebCore::TEST):

  • tests/WebFrameTest.cpp:

(WebKit::TEST_F):

09:02 Changeset [106668] by kbalazs@webkit.org

Speculative unreviewed build fix for Qt-Windows
after http://trac.webkit.org/changeset/106659.

  • platform/graphics/texmap/TextureMapper.h:

(WebCore::TextureMapper::platformCreateAccelerated):

08:56 Changeset [106667] by commit-queue@webkit.org

Unreviewed, rolling out r106654.
http://trac.webkit.org/changeset/106654
https://bugs.webkit.org/show_bug.cgi?id=77742

triggers asserts on mac, win, gtk, qt debug bots (Requested by
philn-tp on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-03

Source/WebCore:

  • Modules/intents/IntentRequest.cpp:

(WebCore::IntentRequest::create):

  • bindings/generic/ActiveDOMCallback.cpp:

(WebCore::ActiveDOMCallback::ActiveDOMCallback):

  • dom/ActiveDOMObject.cpp:

(WebCore::ActiveDOMObject::ActiveDOMObject):
(WebCore::ActiveDOMObject::~ActiveDOMObject):

  • dom/ActiveDOMObject.h:

(ActiveDOMObject):

  • dom/DocumentEventQueue.cpp:

(WebCore::DocumentEventQueue::DocumentEventQueue):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::ScriptExecutionContext):
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
(WebCore::ScriptExecutionContext::stopActiveDOMObjects):

  • dom/ScriptExecutionContext.h:

(ScriptExecutionContext):

  • fileapi/DOMFileSystem.cpp:

(WebCore::DOMFileSystem::create):

  • fileapi/FileReader.cpp:

(WebCore):

  • fileapi/FileReader.h:

(WebCore::FileReader::create):

  • fileapi/FileWriter.cpp:

(WebCore):

  • fileapi/FileWriter.h:

(WebCore::FileWriter::create):

  • history/CachedFrame.cpp:

(WebCore::CachedFrame::CachedFrame):

  • html/HTMLAudioElement.cpp:

(WebCore::HTMLAudioElement::create):

  • html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::create):

  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::create):

  • mediastream/PeerConnection.cpp:

(WebCore::PeerConnection::create):

  • notifications/Notification.cpp:

(WebCore::Notification::create):

  • notifications/NotificationCenter.cpp:
  • notifications/NotificationCenter.h:

(WebCore::NotificationCenter::create):

  • page/DOMTimer.cpp:

(WebCore::DOMTimer::install):
(WebCore::DOMTimer::fired):

  • page/EventSource.cpp:

(WebCore::EventSource::create):

  • page/SuspendableTimer.cpp:

(WebCore::SuspendableTimer::SuspendableTimer):

  • storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::create):

  • storage/IDBRequest.cpp:

(WebCore::IDBRequest::create):

  • storage/IDBTransaction.cpp:

(WebCore::IDBTransaction::create):

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::create):

  • websockets/WebSocket.cpp:
  • websockets/WebSocket.h:

(WebCore::WebSocket::create):

  • workers/SharedWorker.cpp:

(WebCore::SharedWorker::create):

  • workers/Worker.cpp:

(WebCore::Worker::create):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::create):

LayoutTests:

  • fast/events/resources/suspend-subframe-1.html: Removed.
  • fast/events/resources/suspend-subframe-2.html: Removed.
  • fast/events/suspend-timers-expected.txt: Removed.
  • fast/events/suspend-timers.html: Removed.
  • platform/chromium/test_expectations.txt:
08:53 Changeset [106666] by haraken@chromium.org

Add the "V8" prefix to V8 specific IDL attributes
https://bugs.webkit.org/show_bug.cgi?id=77713

Reviewed by Adam Barth.

This patch adds the "V8" prefix to a V8 specific IDL attribute:
[EnabledAtRuntime] => [V8EnabledAtRuntime]

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateImplementation):
(GetRuntimeEnableFunctionName):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp: Updated the run-bindings-tests results.

(WebCore::ConfigureV8TestObjTemplate):

  • Modules/gamepad/NavigatorGamepad.idl:
  • dom/Clipboard.idl:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/MouseEvent.idl:
  • dom/ShadowRoot.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLTrackElement.idl:
  • html/TextTrack.idl:
  • html/TextTrackCue.idl:
  • html/TextTrackCueList.idl:
  • html/shadow/HTMLContentElement.idl:
  • html/track/TextTrackList.idl:
  • html/track/TrackEvent.idl:
  • page/DOMWindow.idl:
  • page/History.idl:
  • page/Navigator.idl:
  • storage/DOMWindowSQLDatabase.idl:
  • webaudio/DOMWindowWebAudio.idl:
  • websockets/DOMWindowWebSocket.idl:
  • workers/WorkerContext.idl:
  • xml/XMLHttpRequest.idl:
08:50 Changeset [106665] by commit-queue@webkit.org

Web Inspector: Retained size for classes is too conservative in heap profiler
https://bugs.webkit.org/show_bug.cgi?id=77726

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-02-03
Reviewed by Yury Semikhatsky.

Makes retained size of all objects of particular class show correct value
in Summary view of heap profiler.

  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotConstructorNode.prototype.get data):

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype._buildAggregates):
(WebInspector.HeapSnapshot.prototype._buildAggregates.forDominatedNodes):

08:43 Changeset [106664] by apavlov@chromium.org

Web Inspector: Introduce "Copy XPath" popup menu item for DOM elements
https://bugs.webkit.org/show_bug.cgi?id=77619

Reviewed by Vsevolod Vlasov.

Source/WebCore:

XPath is optimized whenever an element has the "id" attribute.

Test: inspector/elements/node-xpath.xhtml

  • English.lproj/localizedStrings.js:
  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode.XPathStep):
(WebInspector.DOMNode.XPathStep.prototype.toString):
(WebInspector.DOMNode.prototype.copyXPath):
(WebInspector.DOMNode.prototype.isXMLNode):
(WebInspector.DOMNode.prototype.xPath):
(WebInspector.DOMNode.prototype._xPathValue):
(WebInspector.DOMNode.prototype._xPathIndex):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype._populateNodeContextMenu):

LayoutTests:

  • inspector/elements/node-xpath-expected.txt: Added.
  • inspector/elements/node-xpath.xhtml: Added.
08:28 Changeset [106663] by commit-queue@webkit.org

[Chromium] Use the current clip when marking paints as opaque
https://bugs.webkit.org/show_bug.cgi?id=77582

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-03
Reviewed by Stephen White.

Source/WebCore:

New unit test in PlatformContextSkiaTest.cpp

  • platform/graphics/skia/OpaqueRegionSkia.cpp:

(WebCore::OpaqueRegionSkia::markRectAsOpaque):

  • platform/graphics/skia/PlatformContextSkia.h:

(WebCore::PlatformContextSkia::canvas):

Source/WebKit/chromium:

  • tests/PlatformContextSkiaTest.cpp:

(WebCore::TEST):
(WebCore):

08:20 Changeset [106662] by yurys@chromium.org

inspector/debugger/pause-in-inline-script.html asserts in chromium debug
https://bugs.webkit.org/show_bug.cgi?id=77663

Source/WebCore:

Make ASSERT in MainResourceLoader not fail if debugger hits breakpoint
in the main resource inline script.

Reviewed by Pavel Feldman.

Test: inspector/debugger/pause-in-inline-script.html

  • bindings/js/ScriptDebugServer.h:

(WebCore::ScriptDebugServer::isPaused):
(ScriptDebugServer):

  • bindings/v8/ScriptDebugServer.h:

(ScriptDebugServer):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::didClearMainFrameWindowObject):
(WebCore):
(WebCore::InspectorDebuggerAgent::isPaused):

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::isDebuggerPausedImpl):
(WebCore):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::isDebuggerPaused):
(WebCore):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::didFinishLoading):

LayoutTests:

Reviewed by Pavel Feldman.

  • platform/chromium/test_expectations.txt: assert was fixed, remove custom expectation for inspector/debugger/pause-in-inline-script.html
07:56 Changeset [106661] by apavlov@chromium.org

Merge 106560 - Web Inspector: [REGRESSION] Slow continuous DOM traversal with Up/Down keys
https://bugs.webkit.org/show_bug.cgi?id=77643

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/styles/updates-during-dom-traversal.html

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate):

LayoutTests:

  • inspector/styles/updates-during-dom-traversal-expected.txt: Added.
  • inspector/styles/updates-during-dom-traversal.html: Added.

TBR=apavlov@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9310084

07:07 Changeset [106660] by haraken@chromium.org

Fix typo
https://bugs.webkit.org/show_bug.cgi?id=77708

Reviewed by Adam Roben.

This patch fixes typos: [ObjCLegacyUnamedParameters] => [ObjCLegacyUnnamedParameters]

No tests. No change in behavior.

  • css/CSSMediaRule.idl:
  • css/CSSPrimitiveValue.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSStyleSheet.idl:
  • dom/CharacterData.idl:
  • dom/DOMImplementation.idl:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/Event.idl:
  • dom/EventTarget.idl:
  • dom/MouseEvent.idl:
  • dom/MutationEvent.idl:
  • dom/NamedNodeMap.idl:
  • dom/Node.idl:
  • dom/Range.idl:
  • dom/UIEvent.idl:
  • html/HTMLSelectElement.idl:
  • xml/XPathExpression.idl:
06:59 Changeset [106659] by noam.rosenthal@nokia.com

[Qt][Texmap] Refactor TextureMapper API to use ImageBuffers when possible.
https://bugs.webkit.org/show_bug.cgi?id=77148

Reviewed by Martin Robinson.

Source/WebCore:

Removed TextureMapperQt, and instead created a TextureMapperImageBuffer class,
which responds to an "Software" mode of TextureMapper, instead of creating subclasses
of TextureMapper directly. This allows using the software fallback of TextureMapper by any
sort.

To make the ImageBuffer backend easier, content updates to BitmapTexture can now use either
an image, or a raw data pointer. The raw data pointer is provided for performance reasons,
as converting data to/from Image references in Qt generates unnecessary deep copies of the
image data.

Also, functions that use TransformationMatrix were added to GraphicsContext, to allow for
3D transforms in cross platform code.
After this patch everything renders the same. An additional bug report was created to allow
ImageBuffer shallow image copies: https://bugs.webkit.org/show_bug.cgi?id=77689

Covered extensively by existing tests, no behavioral changes.

  • Target.pri:
  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/GraphicsContext.h:

(WebCore):
(GraphicsContext):

  • platform/graphics/cairo/TextureMapperCairo.cpp:
  • platform/graphics/opengl/TextureMapperGL.cpp:

(TextureMapperGLData):
(BitmapTextureGL):
(WebCore::BitmapTextureGL::BitmapTextureGL):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::BitmapTextureGL::reset):
(WebCore):
(WebCore::swizzleBGRAToRGBA):
(WebCore::BitmapTextureGL::updateContents):
(WebCore::BitmapTextureGL::destroy):
(WebCore::TextureMapperGL::bindSurface):
(WebCore::TextureMapper::platformCreateAccelerated):

  • platform/graphics/opengl/TextureMapperGL.h:

(TextureMapperGL):
(WebCore::TextureMapperGL::accelerationMode):
(WebCore):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore):
(WebCore::GraphicsContext::get3DTransform):
(WebCore::GraphicsContext::concat3DTransform):
(WebCore::GraphicsContext::set3DTransform):

  • platform/graphics/qt/TextureMapperQt.cpp: Removed.
  • platform/graphics/qt/TextureMapperQt.h: Removed.
  • platform/graphics/texmap/TextureMapper.cpp:

(WebCore):
(BitmapTextureImageBuffer):
(TextureMapperImageBuffer):

  • platform/graphics/texmap/TextureMapper.h:

(WebCore::BitmapTexture::BitmapTexture):
(BitmapTexture):
(WebCore::BitmapTexture::bpp):
(WebCore::BitmapTexture::isOpaque):
(WebCore::TextureMapper::setGraphicsContext):
(WebCore::TextureMapper::graphicsContext):
(TextureMapper):
(WebCore::TextureMapper::TextureMapper):
(WebCore::TextureMapper::platformCreateAccelerated):

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::renderContent):
(WebCore::TextureMapperNode::setContentsTileBackBuffer):

  • platform/graphics/texmap/TextureMapperNode.h:

(TextureMapperNode):

Source/WebKit/qt:

Use TextureMapper::create instead of creating TextureMapperGL/TextureMapperQt directly.

  • Api/qwebframe.cpp:

(QWebFramePrivate::renderCompositedLayers):

  • WebCoreSupport/PageClientQt.cpp:

(WebCore::PageClientQWidget::setRootGraphicsLayer):
(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):

Source/WebKit2:

Use TextureMapper::create instead of creating TextureMapperGL/TextureMapperQt directly.
Remove calls to unused API.

  • UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit::LayerTreeHostProxy::paintToGraphicsContext):
(WebKit::LayerTreeHostProxy::createImage):
(WebKit::LayerTreeHostProxy::ensureRootLayer):

06:47 Changeset [106658] by jocelyn.turcotte@nokia.com

[Qt] Split QQuickWebViewPrivate in two classes, for desktop and touch behavior.
https://bugs.webkit.org/show_bug.cgi?id=77632

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Replace the runtime property setting the desktop behavior on each instance
by a static boolean controlling the behavior used by future created WebViews.

  • UIProcess/API/qt/qquickwebpage.cpp:

Let only setContentsSize control the size of the drawing area instead of deferring
it until geometryChanged is called.
(QQuickWebPagePrivate::QQuickWebPagePrivate):

  • UIProcess/API/qt/qquickwebpage_p.h:
  • UIProcess/API/qt/qquickwebpage_p_p.h:

(QQuickWebPagePrivate):

  • UIProcess/API/qt/qquickwebview.cpp:

(createPrivateObject):
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::~QQuickWebViewPrivate):
(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::processDidCrash):
(QQuickWebViewLegacyPrivate::QQuickWebViewLegacyPrivate):
(QQuickWebViewLegacyPrivate::initialize):
(QQuickWebViewLegacyPrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::QQuickWebViewFlickablePrivate):
(QQuickWebViewFlickablePrivate::~QQuickWebViewFlickablePrivate):
(QQuickWebViewFlickablePrivate::initialize):
(QQuickWebViewFlickablePrivate::loadDidCommit):
(QQuickWebViewFlickablePrivate::didFinishFirstNonEmptyLayout):
(QQuickWebViewFlickablePrivate::didChangeViewportProperties):
(QQuickWebViewFlickablePrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::_q_updateVisibleContentRectAndScale):
(QQuickWebViewFlickablePrivate::_q_suspend):
(QQuickWebViewFlickablePrivate::_q_resume):
(QQuickWebViewFlickablePrivate::pageDidRequestScroll):
(QQuickWebViewFlickablePrivate::didChangeContentsSize):
(QQuickWebViewFlickablePrivate::computeViewportConstraints):
(QQuickWebViewFlickablePrivate::PostTransitionState::apply):
(QQuickWebViewExperimental::setFlickableViewportEnabled):
The switch is now a static function that has to be called before a WebView
is created. The switch can have it's default defined by the deploying platform.
(QQuickWebViewExperimental::flickableViewportEnabled):
(QQuickWebView::QQuickWebView):
On creation of QQuickWebView, the static boolean is read to know if we want
a QQuickWebViewTouchPrivate or a QQuickWebViewDesktopPrivate.
(QQuickWebView::geometryChanged):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):
(QQuickWebViewPrivate::loadDidCommit):
(QQuickWebViewPrivate::didFinishFirstNonEmptyLayout):
(QQuickWebViewPrivate::didChangeViewportProperties):
(QQuickWebViewPrivate::viewportInteractionEngine):
(QQuickWebViewPrivate::updateViewportSize):
(QQuickWebViewPrivate::_q_updateVisibleContentRectAndScale):
(QQuickWebViewPrivate::_q_suspend):
(QQuickWebViewPrivate::_q_resume):
(QQuickWebViewPrivate::pageDidRequestScroll):
(QQuickWebViewPrivate::didChangeContentsSize):
(QQuickWebViewLegacyPrivate):
(QQuickWebViewFlickablePrivate):
(QQuickWebViewFlickablePrivate::viewportInteractionEngine):
(PostTransitionState):
(QQuickWebViewFlickablePrivate::PostTransitionState::PostTransitionState):

  • UIProcess/API/qt/qwebviewportinfo.cpp:

(QWebViewportInfo::currentScale):
(QWebViewportInfo::devicePixelRatio):
(QWebViewportInfo::initialScale):
(QWebViewportInfo::minimumScale):
(QWebViewportInfo::maximumScale):
(QWebViewportInfo::isScalable):
(QWebViewportInfo::layoutSize):

  • UIProcess/API/qt/tests/publicapi/publicapi.pro:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior.pro: Added.
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/DesktopWebView.qml: Removed.
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_itemSelector.qml: Renamed

from Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_itemSelector.qml.
Moved to DesktopBehavior instead of using a DesktopWebView to workaround the touch event limitation.

  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_messaging.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml:
  • UIProcess/API/qt/tests/qmltests/WebView.pro: Copied

from Source/WebKit2/UIProcess/API/qt/tests/qmltests/qmltests.pro.

  • UIProcess/API/qt/tests/qmltests/qmltests.pro:

Split qmltests in two executables, tst_qmltests_DesktopBehavior and tst_qmltests_WebView.
The former runs without setFlickableViewportEnabled and the later does.

  • UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp:

(main):

  • UIProcess/API/qt/tests/qquickwebview/qquickwebview.pro:
  • UIProcess/API/qt/tests/tests.pri:
  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::QtWebPageEventHandler):

Tools:

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):

  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::sendTouchEvent):
(MiniBrowserApplication::handleUserOptions):

  • MiniBrowser/qt/MiniBrowserApplication.h:

(WindowOptions):
(WindowOptions::WindowOptions):

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::PlatformWebView):

  • WebKitTestRunner/qt/main.cpp:

(main):

  • qmake/mkspecs/features/default_post.prf:
06:47 Changeset [106657] by yurys@chromium.org

Web Inspector: console evaluation doesn't work on breakpoint in pages with CSP
https://bugs.webkit.org/show_bug.cgi?id=77203

Inspector console evaluation now works when debugger is paused in a page with
content-security-policy prohibiting evals.

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/eval-on-pause-blocked.html

  • bindings/js/JSInjectedScriptHostCustom.cpp:
  • bindings/js/ScriptState.cpp:

(WebCore::evalEnabled):
(WebCore):
(WebCore::setEvalEnabled):

  • bindings/js/ScriptState.h:

(WebCore):

  • bindings/v8/ScriptObject.h:

(WebCore::ScriptObject::ScriptObject):

  • bindings/v8/ScriptState.cpp:

(WebCore::evalEnabled):
(WebCore):
(WebCore::setEvalEnabled):

  • bindings/v8/ScriptState.h:

(WebCore):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::makeCall):

  • inspector/InjectedScriptHost.idl:
  • inspector/InjectedScriptSource.js:

(.):

LayoutTests:

  • inspector/debugger/eval-on-pause-blocked-expected.txt: Added.
  • inspector/debugger/eval-on-pause-blocked.html: Added.
06:44 Changeset [106656] by jocelyn.turcotte@nokia.com

[Qt] Rename content* to contents* in QQuickWebPage.
https://bugs.webkit.org/show_bug.cgi?id=77629

Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPagePrivate::QQuickWebPagePrivate):
(QQuickWebPagePrivate::paintToCurrentGLContext):
(QQuickWebPage::setContentsSize):
(QQuickWebPage::contentsSize):
(QQuickWebPage::setContentsScale):
(QQuickWebPage::contentsScale):
(QQuickWebPage::transformToItem):
(QQuickWebPagePrivate::updateSize):

  • UIProcess/API/qt/qquickwebpage_p.h:
  • UIProcess/API/qt/qquickwebpage_p_p.h:

(QQuickWebPagePrivate):

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::didChangeContentsSize):
(QQuickWebViewPrivate::updateVisibleContentRectAndScale):
(QQuickWebViewPrivate::PostTransitionState::apply):

  • UIProcess/API/qt/qwebviewportinfo.cpp:

(QWebViewportInfo::contentsSize):

  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::scrollRequest):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::setItemRectVisible):
(WebKit::QtViewportInteractionEngine::event):
(WebKit::QtViewportInteractionEngine::wheelEvent):
(WebKit::QtViewportInteractionEngine::pagePositionRequest):
(WebKit::QtViewportInteractionEngine::computePosRangeForItemAtScale):
(WebKit::QtViewportInteractionEngine::applyConstraints):
(WebKit::QtViewportInteractionEngine::currentCSSScale):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
(WebKit::QtViewportInteractionEngine::scaleContent):

06:05 Changeset [106655] by rwlbuis@webkit.org

2012-02-03 Rob Buis <rbuis@rim.com>

Upstream targetType usage on ResourceRequest for BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=77649

Reviewed by Antonio Gomes.

Upstream bits that make use of targetType enum.

  • loader/PingLoader.cpp: (WebCore::PingLoader::loadImage): (WebCore::PingLoader::sendPing): (WebCore::PingLoader::reportContentSecurityPolicyViolation):
  • platform/network/blackberry/ResourceRequest.h: (ResourceRequest): (WebCore::ResourceRequest::targetType): (WebCore::ResourceRequest::setTargetType):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::createRequest):
05:42 Changeset [106654] by commit-queue@webkit.org

Source/WebCore: Ensure timers and other active DOM objects do not fire in suspended documents.
https://bugs.webkit.org/show_bug.cgi?id=53733

ScriptExecutionContext now remembers it has suspended active DOM objects
and suspends all newly installed active DOM objects as well.

All create-calls active DOM objects now calls the post constructor method
suspendIfNeeded that updates the suspend state. It is post constructor
because the suspend/resume functions are virtual and thus can not be called
from constructors.

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-03
Reviewed by Mihai Parparita.

Test: fast/events/suspend-timers.html

  • Modules/intents/IntentRequest.cpp:

(WebCore::IntentRequest::create):

  • bindings/generic/ActiveDOMCallback.cpp:

(WebCore::ActiveDOMCallback::ActiveDOMCallback):

  • dom/ActiveDOMObject.cpp:

(WebCore::ActiveDOMObject::ActiveDOMObject):
(WebCore::ActiveDOMObject::~ActiveDOMObject):
(WebCore::ActiveDOMObject::suspendIfNeeded):

  • dom/ActiveDOMObject.h:

(WebCore::ActiveDOMObject::suspendIfNeededCalled):

  • dom/DocumentEventQueue.cpp:

(WebCore::DocumentEventQueue::DocumentEventQueue):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::ScriptExecutionContext):
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
(WebCore::ScriptExecutionContext::stopActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjectIfNeeded):

  • dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::activeDOMObjectsAreSuspended):

  • fileapi/DOMFileSystem.cpp:

(WebCore::DOMFileSystem::create):

  • fileapi/FileReader.cpp:

(WebCore::FileReader::create):

  • fileapi/FileReader.h:
  • fileapi/FileWriter.cpp:

(WebCore::FileWriter::create):

  • fileapi/FileWriter.h:
  • history/CachedFrame.cpp:

(WebCore::CachedFrame::CachedFrame):

  • html/HTMLAudioElement.cpp:

(WebCore::HTMLAudioElement::create):

  • html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::create):

  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::create):

  • mediastream/PeerConnection.cpp:

(WebCore::PeerConnection::create):

  • notifications/Notification.cpp:

(WebCore::Notification::create):

  • notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::create):

  • notifications/NotificationCenter.h:
  • page/DOMTimer.cpp:

(WebCore::DOMTimer::install):
(WebCore::DOMTimer::fired):

  • page/EventSource.cpp:

(WebCore::EventSource::create):

  • page/SuspendableTimer.cpp:

(WebCore::SuspendableTimer::SuspendableTimer):

  • storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::create):

  • storage/IDBRequest.cpp:

(WebCore::IDBRequest::create):

  • storage/IDBTransaction.cpp:

(WebCore::IDBTransaction::create):

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::create):

  • websockets/WebSocket.cpp:

(WebCore::WebSocket::create):

  • websockets/WebSocket.h:
  • workers/SharedWorker.cpp:

(WebCore::SharedWorker::create):

  • workers/Worker.cpp:

(WebCore::Worker::create):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::create):

LayoutTests: Test that timers do not fire from subframes of suspended documents.
https://bugs.webkit.org/show_bug.cgi?id=53733

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-03
Reviewed by Mihai Parparita.

  • fast/events/resources/suspend-subframe-1.html: Added.
  • fast/events/resources/suspend-subframe-2.html: Added.
  • fast/events/suspend-timers-expected.txt: Added.
  • fast/events/suspend-timers.html: Added.
  • platform/chromium/test_expectations.txt:
05:36 Changeset [106653] by yurys@chromium.org

2012-02-03 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium deps.

  • DEPS:
05:23 Changeset [106652] by ossy@webkit.org

New test introduced in r106642 failes on Qt Linux Release
https://bugs.webkit.org/show_bug.cgi?id=77729

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-02-03
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
05:05 Changeset [106651] by commit-queue@webkit.org

[Qt] Fix build when cross-compiling
https://bugs.webkit.org/show_bug.cgi?id=77634

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-02-03
Reviewed by Tor Arne Vestbø.

Source/WebKit2:

  • WebKit2.pri: Link in -lrt on linux mkspecs, regardless of whether gcc

is in use or not. More specifically this fixes the case where the makespace
is not linux-g++* but for a cross-compiling one like linux-arm-gnueabi-g++.

Source/WTF:

  • WTF.pri: Don't use icu-config for determining the library search

path and libraries needed for ICU. Either we use icu-config for includes
_and_ libraries or we don't. Right now we assume that icu is a system library
and expect the headers in the default include search pathes (/usr/include for example).
However we use icu-config to figure out where the libraries are, which breaks when
cross-compiling, because icu-config isn't cross-compile friendly (I wish icu was using
pkg-config). I think for the time being we should require ICU as a _system_ library,
which implies the header and library availability in default search paths. This also
makes the build succeed when cross-compiling with --sysroot.

04:51 Changeset [106650] by commit-queue@webkit.org

[Qt] Replace GNU linker script for exports with export macros in WTF/JSC
https://bugs.webkit.org/show_bug.cgi?id=77723

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-02-03
Reviewed by Tor Arne Vestbø.

.:

  • Source/api.pri: Remove use of GNU linker script on Linux.
  • Source/qtwebkit-export.map: Removed.

Source/JavaScriptCore:

  • wtf/Platform.h: Enable use of export macros.

Tools:

  • Tools.pro: Compile WTR again on all platforms with WK2.
04:49 Changeset [106649] by commit-queue@webkit.org

Do not ASSERT on TouchStationary TouchPoint state.
https://bugs.webkit.org/show_bug.cgi?id=77620

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-03
Reviewed by Kenneth Rohde Christiansen.

  • page/EventHandler.cpp:

(WebCore::eventNameForTouchPointState): Explicitly show that TouchStationary is asserted.
(WebCore::EventHandler::handleTouchEvent):

Remove TouchStationary from ASSERT. The value of HitTestRequest is restored to the
value it should have if hittested, but is not used.

04:14 Changeset [106648] by haraken@chromium.org

Add the "ObjC" prefix to ObjC specific IDL attributes
https://bugs.webkit.org/show_bug.cgi?id=77708

Reviewed by Adam Barth.

This patch adds the "ObjC" prefix to ObjC specific IDL attributes, as follows:

[Polymorphic] => [ObjCPolymorphic]
[OldStyleObjC] => [ObjCLegacyUnamedParameters]
[UsesView] => [ObjCUseDefaultView] (Note: Renamed for clarification)

No tests. No changes in behavior.

  • bindings/scripts/CodeGeneratorObjC.pm:

(GenerateHeader):
(GenerateImplementation):

  • css/CSSMediaRule.idl:
  • css/CSSPrimitiveValue.idl:
  • css/CSSRule.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSStyleSheet.idl:
  • css/CSSValue.idl:
  • css/StyleSheet.idl:
  • dom/CharacterData.idl:
  • dom/DOMImplementation.idl:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/Event.idl:
  • dom/EventTarget.idl:
  • dom/MouseEvent.idl:
  • dom/MutationEvent.idl:
  • dom/NamedNodeMap.idl:
  • dom/Node.idl:
  • dom/Range.idl:
  • dom/UIEvent.idl:
  • html/HTMLCollection.idl:
  • html/HTMLSelectElement.idl:
  • svg/SVGPathSeg.idl:
  • xml/XPathExpression.idl:
04:02 Changeset [106647] by commit-queue@webkit.org

Ensure that inspector disabled build works
https://bugs.webkit.org/show_bug.cgi?id=77604

Patch by Sriram Neelakandan <sriram.neelakandan@gmail.com> on 2012-02-03
Reviewed by Tor Arne Vestbø.

  • qmake/mkspecs/features/features.prf:
03:39 Changeset [106646] by morrita@google.com

TypingCommand should be prepared against detached document.
https://bugs.webkit.org/show_bug.cgi?id=77216

Reviewed by Ryosuke Niwa.

Added null checks for document()->frame().

No new tests. Just tighten guards for possible codepaths.

  • editing/TypingCommand.cpp:

(WebCore::TypingCommand::markMisspellingsAfterTyping):
(WebCore::TypingCommand::typingAddedToOpenCommand):
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):

03:05 Changeset [106645] by haraken@chromium.org

Rename [DontEnum] IDL to [NotEnumerable] IDL
https://bugs.webkit.org/show_bug.cgi?id=77710

Reviewed by Adam Barth.

[DontEnum] is a negation of Enumerable? in the ECMAScript spec
(8.6.1 of http://www.ecma-international.org/publications/files/ECMA-ST/Ecma-262.pdf).
This patch renames [DontEnum] to [NotEnumerable].

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateAttributesHashTable):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateSingleBatchedAttribute):
(GenerateImplementation):

  • css/WebKitCSSMatrix.idl:
  • dom/DOMCoreException.idl:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/EventException.idl:
  • dom/RangeException.idl:
  • fileapi/FileException.idl:
  • fileapi/OperationNotAllowedException.idl:
  • html/DOMTokenList.idl:
  • html/HTMLAnchorElement.idl:
  • html/HTMLBodyElement.idl:
  • html/HTMLFrameSetElement.idl:
  • html/HTMLInputElement.idl:
  • page/DOMSelection.idl:
  • page/DOMWindow.idl:
  • page/Location.idl:
  • storage/IDBDatabaseException.idl:
  • storage/Storage.idl:
  • svg/SVGElementInstance.idl:
  • svg/SVGException.idl:
  • workers/WorkerLocation.idl:
  • xml/XMLHttpRequestException.idl:
  • xml/XPathException.idl:
03:02 Changeset [106644] by haraken@chromium.org

Rename [InitializedByConstructor] IDL to [InitializedByEventConstructor] IDL
https://bugs.webkit.org/show_bug.cgi?id=77711

Reviewed by Adam Barth.

[InitializedByConstructor] can be used only when [ConstructorTemplate=Event]
is specified on the interface. This patch renames [InitializedByConstructor] to
[InitializedByEventConstructor] for clarification.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateConstructorDefinition):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateEventConstructorCallback):

  • bindings/scripts/test/TestEventConstructor.idl:
  • bindings/scripts/test/V8/V8TestEventConstructor.cpp: Updated the run-bindings-tests results.

(WebCore):

  • dom/BeforeLoadEvent.idl:
  • dom/CustomEvent.idl:
  • dom/ErrorEvent.idl:
  • dom/Event.idl:
  • dom/HashChangeEvent.idl:
  • dom/MessageEvent.idl:
  • dom/OverflowEvent.idl:
  • dom/PageTransitionEvent.idl:
  • dom/PopStateEvent.idl:
  • dom/ProgressEvent.idl:
  • dom/WebKitAnimationEvent.idl:
  • dom/WebKitTransitionEvent.idl:
  • html/canvas/WebGLContextEvent.idl:
  • html/track/TrackEvent.idl:
  • storage/StorageEvent.idl:
  • websockets/CloseEvent.idl:
02:31 Changeset [106643] by haraken@chromium.org

Add the "CPP" prefix to CPP specific IDL attributes
https://bugs.webkit.org/show_bug.cgi?id=77707

Reviewed by Adam Barth.

This patch adds the "CPP" prefix to a CPP specific IDL attribute.
Specifically, this patch renames [PureInterface] to [CPPPureInterface]

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorCPP.pm:

(GenerateHeader):
(GenerateImplementation):

  • css/MediaQueryListListener.idl:
  • dom/EventListener.idl:
  • dom/EventTarget.idl:
  • dom/NodeFilter.idl:
02:10 Changeset [106642] by apavlov@chromium.org

Implement touch event emulation in the WebCore layer
https://bugs.webkit.org/show_bug.cgi?id=77105

Reviewed by Ryosuke Niwa.

Source/WebCore:

This change essentially maps mouse events into single-touch events in the following way:

  • mousedown -> touchstart
  • mouseup -> touchend
  • mousemove -> touchmove (between mousedown and mouseup).

Test: fast/events/touch/emulate-touch-events.html

  • page/EventHandler.cpp:

(SyntheticTouchPoint): A synthetic touch point built from PlatformMouseEvent.
(WebCore::SyntheticTouchPoint::SyntheticTouchPoint):
(SyntheticSingleTouchEvent): A synthetic touch point event built from PlatformMouseEvent.
(WebCore::SyntheticSingleTouchEvent::SyntheticSingleTouchEvent):
(WebCore::EventHandler::handleMouseReleaseEvent): Invoke maybeDispatchSyntheticTouchEvent() and bail out if necessary.
(WebCore::EventHandler::handleMousePressEvent): Invoke maybeDispatchSyntheticTouchEvent() and bail out if necessary.
(WebCore::EventHandler::mouseMoved): Invoke maybeDispatchSyntheticTouchEvent() and bail out if necessary.
(WebCore::EventHandler::dispatchSyntheticTouchEventIfEnabled): Dispatch a synthetic touch event if necessary.

  • page/EventHandler.h: Added new method.
  • page/Settings.cpp:

(WebCore::Settings::Settings): Added m_touchEventEmulationEnabled initializer.

  • page/Settings.h: Added m_touchEventEmulationEnabled, getter, and setter.

(WebCore::Settings::setTouchEventEmulationEnabled): Added.
(WebCore::Settings::isTouchEventEmulationEnabled): Added.

  • platform/PlatformTouchPoint.h:

(WebCore::PlatformTouchPoint::PlatformTouchPoint): Unconditionally compile the parameterless ctor.

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::setTouchEventEmulationEnabled): Added for testing.

  • testing/InternalSettings.h: Added setTouchEventEmulationEnabled() for testing.
  • testing/InternalSettings.idl: Added setTouchEventEmulationEnabled() for testing.

LayoutTests:

  • fast/events/touch/emulate-touch-events-expected.txt: Added.
  • fast/events/touch/emulate-touch-events.html: Added.
02:04 Changeset [106641] by abarth@webkit.org

Group all the security failures together.

  • platform/chromium/test_expectations.txt:
02:01 Changeset [106640] by haraken@chromium.org

Remove [NoCPPCustom] IDL
https://bugs.webkit.org/show_bug.cgi?id=77704

Reviewed by Adam Barth.

This patch removes [NoCPPCustom], by replacing [Custom, NoCPPCustom]
in HTMLDocument.idl with [JSCCustom, V8Custom].

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorCPP.pm:

(ShouldSkipType):

  • html/HTMLDocument.idl:
01:54 Changeset [106639] by haraken@chromium.org

Remove [LegacyParent] from CodeGeneratorGObject.pm, and rename it to [JSLegacyParent]
https://bugs.webkit.org/show_bug.cgi?id=77706

Reviewed by Adam Barth.

This patch removes dead code about [LegacyParent] from CodeGeneratorGObject.pm,
and renames [LegacyParent] to [JSLegacyParent].

No tests. No changes in behavior.

  • bindings/scripts/CodeGeneratorGObject.pm:

(Generate):

  • bindings/scripts/CodeGeneratorJS.pm:

(GetParentClassName):
(GenerateHeader):
(GenerateImplementation):

  • page/DOMWindow.idl:
  • workers/WorkerContext.idl:
01:28 Changeset [106638] by pfeldman@chromium.org

Web Inspector: preserve elements panel selection upon node drag'n'drop
https://bugs.webkit.org/show_bug.cgi?id=77722

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: inspector/elements/move-node.html

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype._markRevision):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype._ondrop):
(WebInspector.ElementsTreeOutline.prototype._doMove.callback):
(WebInspector.ElementsTreeOutline.prototype._doMove):

LayoutTests:

  • inspector/elements/move-node-expected.txt: Added.
  • inspector/elements/move-node.html: Added.
00:30 Changeset [106637] by commit-queue@webkit.org

Source/WebCore: Reimplement DETAILS and SUMMARY using selector query.
https://bugs.webkit.org/show_bug.cgi?id=75930

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-03
Reviewed by Hajime Morita.

DETAILS is reimplemented using content element and its fallback feature.
We don't need to recreate DOM even if SUMMARY is removed from or added into DETAILS.

No new tests, should be covered by existing tests.

  • html/HTMLDetailsElement.cpp:

(WebCore::DetailsSummaryElement::fallbackSummary):

Takes fallback element of content summary.

(DetailsSummaryElement):
(WebCore::DetailsSummaryElement::create):

Creates a fallback element also.

(WebCore):
(WebCore::HTMLDetailsElement::create):
(WebCore::HTMLDetailsElement::HTMLDetailsElement):
(WebCore::HTMLDetailsElement::createShadowSubtree):
(WebCore::HTMLDetailsElement::findMainSummary):
(WebCore::HTMLDetailsElement::parseMappedAttribute):
(WebCore::HTMLDetailsElement::childShouldCreateRenderer):
(WebCore::HTMLDetailsElement::toggleOpen):

  • html/HTMLDetailsElement.h:

(HTMLDetailsElement):

  • html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::isMainSummary):

LayoutTests: Reimplement DETAILS and SUMMARY using selector query.
https://bugs.webkit.org/show_bug.cgi?id=75930

Since the implementation of DETAILS shadow tree, the path of caret position is also changed.

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-03
Reviewed by Hajime Morita.

  • platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/qt/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/qt/fast/html/details-remove-summary-4-and-click-expected.txt:
00:19 Changeset [106636] by jochen@chromium.org

Crash when trying to add a timer to a detached document.
https://bugs.webkit.org/show_bug.cgi?id=77692

Reviewed by Alexey Proskuryakov.

In http://webkit.org/b/77370, a timer is fired on a detached document.
Since a document clears all timers when it is detached, and it
shouldn't be possible to add a timer to a detached document, we crash
if this should happen anyway. This will hopefully result in an easier
to debug crash dump.

  • page/DOMTimer.cpp:

(WebCore::DOMTimer::DOMTimer):

00:16 Changeset [106635] by commit-queue@webkit.org

Stop calling Element::ensureShadowRoot in Internals.
https://bugs.webkit.org/show_bug.cgi?id=77612

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-03
Reviewed by Hajime Morita.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

We want to check a shadow root is built-in or created by users to support multiple shadow subtrees.
But Element::ensureShadowRoot() makes it difficult, because it doesn't care about the returning shadow element
is built-in or user generated, so let's remove Element::ensureShadowRoot().

As a first step, this patch removes ensureShadowRoot() in Internals.

No new tests, because no changes in behavior.

  • WebCore.exp.in:
  • testing/Internals.cpp:

(WebCore::Internals::ensureShadowRoot):

Source/WebKit2:

Exports symbols.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
Note: See TracTimeline for information about the timeline view.