Timeline


and

02/09/12:

23:58 Changeset [107372] by ossy@webkit.org

Unreviewed gardening after r107289.

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
23:55 Changeset [107371] by haraken@chromium.org

Unreviewed, rolling out r107368.
http://trac.webkit.org/changeset/107368
https://bugs.webkit.org/show_bug.cgi?id=78327

break GTK build

  • bindings/scripts/CodeGeneratorCPP.pm:

(ShouldSkipType):

  • bindings/scripts/CodeGeneratorGObject.pm:

(SkipFunction):
(GenerateFunction):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateCallWith):
(GenerateParametersCheck):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateFunctionCallback):
(GenerateCallWith):
(GenerateFunctionCallString):

  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj customArgsAndException:]):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::customArgsAndExceptionCallback):
(TestObjInternal):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):

  • bindings/v8/custom/V8ConsoleCustom.cpp:

(WebCore::V8Console::assertCallback):

  • page/Console.cpp:

(WebCore::Console::assertCondition):
(WebCore::Console::timeEnd):

  • page/Console.h:

(Console):

  • page/Console.idl:
23:55 Changeset [107370] by abarth@webkit.org

Update baselines for W3C-SVG-1.1-SE. These new baselines all appear to
be correct.

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Removed.
  • platform/mac/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Removed.
  • platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Removed.
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Removed.
  • platform/mac/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Removed.
  • platform/mac/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Added.
  • svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
  • svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added.
  • svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Added.
  • svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Added.
23:49 Changeset [107369] by zherczeg@webkit.org

Heap-buffer-overflow in WebCore::CSSParser::lex
https://bugs.webkit.org/show_bug.cgi?id=77402

Reviewed by Antti Koivisto.

Source/WebCore:

Comments should check only a single \0 terminator.

Test: fast/css/parsing-css-comment.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::lex):

LayoutTests:

Test various comment types.

  • fast/css/parsing-css-comment-expected.txt: Added.
  • fast/css/parsing-css-comment.html: Added.
23:38 Changeset [107368] by haraken@chromium.org

Replace [CustomArgumentHandling] with [CallWith=ScriptArguments|CallStack]
https://bugs.webkit.org/show_bug.cgi?id=78327

Reviewed by Adam Barth.

This patch replaces [CustomArgumentHandling] with [CallWith=ScriptArguments|CallStack],
and removes [CustomArgumentHandling].

Test: bindings/scripts/test/TestObj.idl

  • bindings/scripts/CodeGeneratorJS.pm: Modified to replace

[CustomArgumentHandling] with [CallWith=ScriptArguments|CallStack].
(GenerateCallWith):
(GenerateParametersCheck):

  • bindings/scripts/CodeGeneratorV8.pm: Ditto.

(GenerateCallWith):

  • bindings/scripts/CodeGeneratorCPP.pm: Simply removed [CustomArgumentHandling]

from the skipped list. By this fix, CodeGeneratorCPP.pm will generate
meaningless code for attributes or methods which was previously marked as
[CustomArgumentHandling], but this change will be harmless.
(ShouldSkipType):

  • bindings/scripts/CodeGeneratorGObject.pm: Ditto.

(SkipFunction):
(GenerateFunction):

  • bindings/v8/custom/V8ConsoleCustom.cpp: Changed the argument order.

(WebCore::V8Console::assertCallback):

  • page/Console.cpp: Ditto.

(WebCore::Console::assertCondition):
(WebCore::Console::timeEnd):

  • page/Console.h: Ditto.

(Console):

  • bindings/scripts/test/TestObj.idl: Added test cases for [CallWith=ScriptArguments|CallStack].
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated run-bindings-tests results.

(WebDOMTestObj::withScriptArgumentsAndCallStackAttribute):
(WebDOMTestObj::setWithScriptArgumentsAndCallStackAttribute):
(WebDOMTestObj::withScriptArgumentsAndCallStack):

  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_with_script_arguments_and_call_stack):
(webkit_dom_test_obj_get_with_script_arguments_and_call_stack_attribute):
(webkit_dom_test_obj_set_with_script_arguments_and_call_stack_attribute):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):
(WebCore::jsTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::setJSTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::jsTestObjPrototypeFunctionWithScriptArgumentsAndCallStack):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj withScriptArgumentsAndCallStackAttribute]):
(-[DOMTestObj setWithScriptArgumentsAndCallStackAttribute:]):
(-[DOMTestObj withScriptArgumentsAndCallStack]):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::withScriptArgumentsAndCallStackAttributeAttrGetter):
(TestObjInternal):
(WebCore::TestObjInternal::withScriptArgumentsAndCallStackAttributeAttrSetter):
(WebCore::TestObjInternal::withScriptArgumentsAndCallStackCallback):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):

23:09 Changeset [107367] by abarth@webkit.org

Dromaeo/dom-traverse.html should go fast
https://bugs.webkit.org/show_bug.cgi?id=78307

Reviewed by Eric Seidel.

This patch improves Dromaeo/dom-traverse.html by roughly 2.5% by
removing a branch. Previously, we null-checked the result of
V8DOMWrapper::getWrapper in a hot code path, but the only case where we
return a non-empty wrapper comes from a cold code path. By pushing the
null check into the cold codepath, we eliminate the branch from the
hot code path.

This patch also annotates the branches in the hot code path with their
likely outcome. I didn't measure a statistically significant
improvement with that aspect of the change, but it seems worthwhile.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::getExistingWrapperInline):
(WebCore):
(WebCore::V8DOMWrapper::getExistingWrapperSlow):
(WebCore::V8DOMWrapper::getWrapperSlow):

  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getExistingWrapper):
(V8DOMWrapper):
(WebCore::V8DOMWrapper::getWrapper):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::toV8Slow):

23:07 Changeset [107366] by eae@chromium.org

Convert Frame/FrameView to LayoutUnits in preparation for turning on subpixel layout
https://bugs.webkit.org/show_bug.cgi?id=78311

Reviewed by Eric Seidel.

No new tests, no new functionality.

  • page/Frame.cpp:

(WebCore::Frame::nodeImage):
Pixel snap painting rect for image to ensure that it is painted aligned
to device pixels. This avoids avoid unwanted anti-aliasing.

  • page/FrameView.cpp:

(WebCore::FrameView::windowClipRectForLayer):
Pixel snap clip rects as all window coordinates and sizes are exposed as
integers.

  • page/GestureTapHighlighter.cpp:
  • page/Page.cpp:

(WebCore::Page::addRelevantRepaintedObject):
As the painting is done aligned on pixel boundaries we need to pixel snap
the view rect when checking if it intersects the objects paint rect.

  • page/mac/FrameMac.mm:

(WebCore::Frame::snapshotDragImage):
(WebCore::Frame::nodeImage):
Pixel snap painting rect for image to ensure that it is painted aligned
to device pixels. This avoids avoid unwanted anti-aliasing.

  • page/win/FrameCGWin.cpp:

(WebCore::Frame::nodeImage):
Pixel snap painting rect for image to ensure that it is painted aligned
to device pixels. This avoids avoid unwanted anti-aliasing.

  • rendering/LayoutTypes.h:

(WebCore::pixelSnappedIntRect):
(WebCore):
No-op implementation of pixelSnappedIntRect for now.

22:44 Changeset [107365] by bashi@chromium.org

Add WebSocket extension support
https://bugs.webkit.org/show_bug.cgi?id=78079

Source/WebCore:

This patch introduces WebSocketExtensionDispatcher class, which creates client's
Sec-WebSocket-Extensions header field and parses the server response.
This patch doesn't add any actual extension, so no changes in behavior.

Reviewed by Kent Tamura.

No new tests except for chromium port.

  • CMakeLists.txt: Added WebSocketExtensionDispatcher.(cpp|h) and WebSocketExtensionProcessor.h.
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • websockets/WebSocketExtensionDispatcher.cpp: Added.

(WebCore):
(ExtensionParser):
(WebCore::ExtensionParser::ExtensionParser):
(WebCore::ExtensionParser::currentToken):
(WebCore::ExtensionParser::finished):
(WebCore::ExtensionParser::parsedSuccessfully):
(WebCore::isTokenCharacter):
(WebCore::isSeparator):
(WebCore::ExtensionParser::skipSpaces):
(WebCore::ExtensionParser::consumeToken):
(WebCore::ExtensionParser::consumeQuotedString):
(WebCore::ExtensionParser::consumeQuotedStringOrToken):
(WebCore::ExtensionParser::consumeCharacter):
(WebCore::WebSocketExtensionDispatcher::reset):
(WebCore::WebSocketExtensionDispatcher::addProcessor):
(WebCore::WebSocketExtensionDispatcher::createHeaderValue):
(WebCore::WebSocketExtensionDispatcher::processHeaderValue):
(WebCore::WebSocketExtensionDispatcher::failureReason):

  • websockets/WebSocketExtensionDispatcher.h: Added.

(WebCore):
(WebSocketExtensionDispatcher):
(WebCore::WebSocketExtensionDispatcher::WebSocketExtensionDispatcher):

  • websockets/WebSocketExtensionProcessor.h: Added.

(WebCore):
(WebSocketExtensionProcessor):
(WebCore::WebSocketExtensionProcessor::~WebSocketExtensionProcessor):
(WebCore::WebSocketExtensionProcessor::extensionToken):
(WebCore::WebSocketExtensionProcessor::failureReason):
(WebCore::WebSocketExtensionProcessor::WebSocketExtensionProcessor):

  • websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::clientHandshakeMessage): Adds extension header value if exists.
(WebCore::WebSocketHandshake::clientHandshakeRequest): Ditto.
(WebCore::WebSocketHandshake::reset): Resets WebSocketExtensionDispatcher object.
(WebCore::WebSocketHandshake::serverHandshakeResponse): Removed.
(WebCore::WebSocketHandshake::addExtensionProcessor): Added.
(WebCore::WebSocketHandshake::readHTTPHeaders): Parses and checks every time Sec-WebSocket-Extensions header appears.
(WebCore::WebSocketHandshake::checkResponseHeaders): Removed the check of Sec-WebSocket-Extensions.

  • websockets/WebSocketHandshake.h: Removed serverHandshakeResponse().

Source/WebKit/chromium:

Add some tests which check WebSocketExtensions::processHeaderValue()
parses the given response correctly.

Reviewed by Kent Tamura.

  • WebKit.gypi:
  • tests/WebSocketExtensionDispatcherTest.cpp: Added.

(WebCore):
(MockWebSocketExtensionProcessor):
(WebCore::MockWebSocketExtensionProcessor::MockWebSocketExtensionProcessor):
(WebSocketExtensionDispatcherTest):
(WebCore::WebSocketExtensionDispatcherTest::WebSocketExtensionDispatcherTest):
(WebCore::WebSocketExtensionDispatcherTest::SetUp):
(WebCore::WebSocketExtensionDispatcherTest::TearDown):
(WebCore::WebSocketExtensionDispatcherTest::addMockProcessor):
(WebCore::WebSocketExtensionDispatcherTest::appendResult):
(WebCore::MockWebSocketExtensionProcessor::processResponse):
(WebCore::TEST_F):

LayoutTests:

Reviewed by Kent Tamura.

  • http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header-expected.txt: Rebaselined.
22:34 Changeset [107364] by wangxianzhu@chromium.org

Avoid compositing invisible fixed positioned elements
https://bugs.webkit.org/show_bug.cgi?id=78186

Reviewed by James Robinson.

Source/WebCore:

Test: compositing/layer-creation/fixed-position-out-of-view.html

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForPosition):

LayoutTests:

  • compositing/layer-creation/fixed-position-out-of-view-expected.txt: Added.
  • compositing/layer-creation/fixed-position-out-of-view.html: Added.
22:26 Changeset [107363] by jamesr@google.com

[chromium] Update compositing test baselines for mock scrollbars

  • platform/chromium-mac-snowleopard/compositing/direct-image-compositing-expected.png: Removed.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-mac/compositing/direct-image-compositing-expected.png: Added.
  • platform/chromium-mac/compositing/geometry/fixed-in-composited-expected.png:
  • platform/chromium-mac/compositing/iframes/iframe-copy-on-scroll-expected.png:
  • platform/chromium-mac/compositing/masks/multiple-masks-expected.png:
  • platform/chromium-mac/compositing/masks/simple-composited-mask-expected.png:
  • platform/chromium-mac/compositing/overflow/overflow-scroll-expected.png:
  • platform/chromium-mac/compositing/overflow/scrollbar-painting-expected.png:
  • platform/chromium-win/compositing/direct-image-compositing-expected.png:
  • platform/chromium-win/compositing/geometry/fixed-in-composited-expected.png:
  • platform/chromium-win/compositing/iframes/iframe-copy-on-scroll-expected.png:
  • platform/chromium-win/compositing/masks/multiple-masks-expected.png:
  • platform/chromium-win/compositing/masks/simple-composited-mask-expected.png:
  • platform/chromium-win/compositing/overflow/overflow-scroll-expected.png:
  • platform/chromium-win/compositing/overflow/scrollbar-painting-expected.png:
  • platform/chromium-win/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium/test_expectations.txt:
22:23 Changeset [107362] by timothy@apple.com

Prevent attaching when inspecting the Web Inspector.

Source/WebCore:

https://webkit.org/b/78304

Reviewed by Brian Weinstein.

  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::canAttachWindow): Prevent attaching when the page is an inspector page.

Source/WebKit2:

Also adds some comments about keeping in sync with InspectorFrontendClientLocal::canAttachWindow
and why there are two implementations of the same function.

https://webkit.org/b/78304

Reviewed by Brian Weinstein.

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::canAttach): Prevent attaching when the page is an inspector page.
Added comments about InspectorFrontendClientLocal::canAttachWindow.

  • UIProcess/WebInspectorProxy.h:

(WebInspectorProxy): Added comment about keeping in sync with InspectorFrontendClientLocal.

22:18 Changeset [107361] by eric@webkit.org

Rename compare_text and compare_audio to make it clear that they're !=
https://bugs.webkit.org/show_bug.cgi?id=78301

Reviewed by Adam Barth.

I also removed the maybe_create_directory function which was redundant.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.set_up_run):

  • Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(TestResultWriter._make_output_directory):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.do_text_results_differ):
(Port.do_audio_results_differ):
(Port.diff_text):
(Port.driver_name):
(Port.skips_perf_test):

  • Scripts/webkitpy/layout_tests/port/win.py:

(WinPort.do_text_results_differ):

  • Scripts/webkitpy/layout_tests/port/win_unittest.py:

(WinPortTest.test_do_text_results_differ):

  • Scripts/webkitpy/layout_tests/servers/apache_http_server.py:

(LayoutTestApacheHttpd.init):

  • Scripts/webkitpy/layout_tests/servers/http_server_base.py:

(HttpServerBase.init):

  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:

(Rebaseliner._diff_baselines):

22:08 Changeset [107360] by commit-queue@webkit.org

[Chromium] Assertion failure minX <= maxX in Region.cpp
https://bugs.webkit.org/show_bug.cgi?id=78038

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-09
Reviewed by James Robinson.

Covered by existing tests (should make them stop asserting).

Clamp sizes for composited layers coming out of WebCore to make sure they are valid non-negative values.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setSize):

21:59 Changeset [107359] by ap@apple.com

Managed network proxy settings are not used in WebProcess
https://bugs.webkit.org/show_bug.cgi?id=78288
<rdar://problem/9962116>

Reviewed by Anders Carlsson.

  • WebProcess/com.apple.WebProcess.sb: Allow reading managed preferences.
21:58 Changeset [107358] by commit-queue@webkit.org

Make WebGLRenderingContext::printWarningToConsole safer
https://bugs.webkit.org/show_bug.cgi?id=78284

Patch by Gregg Tavares <gman@google.com> on 2012-02-09
Reviewed by Kenneth Russell.

No new tests because no change in functionality.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::printWarningToConsole):

21:51 Changeset [107357] by wjmaclean@chromium.org

[chromium] Add support for starting page/scale animations on CC impl thread from WebViewImpl
https://bugs.webkit.org/show_bug.cgi?id=77872

Reviewed by James Robinson.

Source/WebCore:

Added unit test.

Provides a pathway to invoke CCLayerTreeHostImpl::startPageScaleAnimation() from
WebViewImpl. This is intended to support scale and scroll animations, such as WebInputEvent::GestureDoubleTap.

  • platform/CrossThreadCopier.h:

(WebCore):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::startPageScaleAnimation):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCProxy.h:

(CCProxy):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::startPageScaleAnimation):
(WebCore):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(CCSingleThreadProxy):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::startPageScaleAnimation):
(WebCore):
(WebCore::CCThreadProxy::requestStartPageScaleAnimationOnImplThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

Provides a pathway to invoke CCLayerTreeHostImpl::startPageScaleAnimation() from
WebViewImpl. This is intended to support scale and scroll animations, such as WebInputEvent::GestureDoubleTap.

  • src/WebViewImpl.cpp:

(WebKit):
(WebKit::WebViewImpl::startPageScaleAnimation):

  • src/WebViewImpl.h:

(WebViewImpl):

  • tests/CCLayerTreeHostTest.cpp:

(WTF):
(CCLayerTreeHostTestStartPageScaleAnimation):
(WTF::CCLayerTreeHostTestStartPageScaleAnimation::CCLayerTreeHostTestStartPageScaleAnimation):
(WTF::CCLayerTreeHostTestStartPageScaleAnimation::beginTest):
(WTF::CCLayerTreeHostTestStartPageScaleAnimation::requestStartPageScaleAnimation):
(WTF::CCLayerTreeHostTestStartPageScaleAnimation::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestStartPageScaleAnimation::applyScrollAndScale):
(WTF::CCLayerTreeHostTestStartPageScaleAnimation::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestStartPageScaleAnimation::afterTest):
(WTF::TEST_F):

21:45 Changeset [107356] by ap@apple.com

ASSERTION FAILED: checkURLReceivedFromWebProcess(originalURL) loading a local file, if the WebProcess crashed
https://bugs.webkit.org/show_bug.cgi?id=70845
<rdar://problem/10269985>

Reviewed by Anders Carlsson.

This also fixes some case where WebProcess did not get a sandbox extension after a crash.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::reattachToWebProcessWithItem): We no longer need to pass a sandbox
extension here, we're now passing it at b/f navigation bottleneck.
(WebKit::WebPageProxy::reload): Pass a sandbox extension - reload may mean reloading an error
page after a crash, so WebProcess may no longer have the extension.
(WebKit::WebPageProxy::goForward): We no longer need to pass a sandbox extension here,
we're now passing it at b/f navigation bottleneck. Also, fixed a bug where we first null checked
a WebBackForwardListItem pointer, and then used it anyway.
(WebKit::WebPageProxy::goBack): Ditto.
(WebKit::WebPageProxy::goToBackForwardItem): Ditto.
(WebKit::WebPageProxy::backForwardGoToItem): This is the bottleneck. We get here both for UI
actions like pressing the Back button, and for window.history.go() navigations. JS navigations
previously didn't open up the sandbox. URLs in UI process b/f list are trusted, so it's
always OK to grant a sandbox extension if one of them is a file: one.

  • UIProcess/WebPageProxy.h: backForwardGoToItem() now returns a sandbox extension handle.
  • UIProcess/WebPageProxy.messages.in: Ditto.
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::checkURLReceivedFromWebProcess): If a URL is in UI process b/f
list, then it has been already vetted as something the Web process knows about. No need to
crash if it actually attempts going there.
(WebKit::WebProcessProxy::didReceiveInvalidMessage): Removed a useless comment (we have tons
of fprintfs besides this one). Fixed log message syntax.

  • UIProcess/cf/WebPageProxyCF.cpp: (WebKit::WebPageProxy::restoreFromSessionStateData):

We no longer need to pass a sandbox extension here, we're now passing it at b/f navigation
bottleneck.

  • WebProcess/WebPage/WebBackForwardListProxy.cpp: (WebKit::WebBackForwardListProxy::goToItem):

We now get an extension here, when telling UI process that we're navigating to a b/f list item.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::reload): Use the extension we're getting.
(WebKit::WebPage::goForward): Don't use one we're not getting.
(WebKit::WebPage::goBack): Ditto.
(WebKit::WebPage::goToBackForwardItem): Ditto.
(WebKit::WebPage::restoreSessionAndNavigateToCurrentItem): Ditto.

  • WebProcess/WebPage/WebPage.h: Adjusted signatures accordingly.
  • WebProcess/WebPage/WebPage.messages.in: Ditto.
21:42 Changeset [107355] by ap@apple.com

REGRESSION (r104885): Articles not displayed in Vienna RSS reader
https://bugs.webkit.org/show_bug.cgi?id=78280
<rdar://problem/10762545>

Reviewed by Oliver Hunt.

  • Misc/WebNSURLExtras.h:
  • Misc/WebNSURLExtras.mm: (-[NSURL _webkit_URLFromURLOrPath]):

Added a method to create a URL from a path, similarly to what KURL used to do.

  • WebView/WebFrame.mm: (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]):

Use it in an API where a known regression occurred.

21:28 Changeset [107354] by commit-queue@webkit.org

[Gtk] http/tests/workers/terminate-during-sync-operation.html fails locally
https://bugs.webkit.org/show_bug.cgi?id=78270

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-02-09
Reviewed by Martin Robinson.

Skip a workers http test that utilizes not-yet-supported File System API.

  • platform/gtk/Skipped:
21:23 Changeset [107353] by tsepez@chromium.org

[chromium] skip tests affected by deprecation of in-url identities.
https://bugs.webkit.org/show_bug.cgi?id=78259

Reviewed by Adam Barth.

  • platform/chromium/test_expectations.txt:
21:02 Changeset [107352] by wangxianzhu@chromium.org

[Chromium] TiledLayerChromium::protectVisibleTileTextures() should only protect the visible textures
https://bugs.webkit.org/show_bug.cgi?id=78249

Reviewed by James Robinson.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::protectVisibleTileTextures):

20:33 Changeset [107351] by commit-queue@webkit.org

[GTK] Add DRT support for modal dialogs
https://bugs.webkit.org/show_bug.cgi?id=53600

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-02-09
Reviewed by Martin Robinson.

Source/WebKit/gtk:

Add support for running modal dialogs.

A new signal is added to the WebKitWebView. When emitted, the web view
is requesting to be displayed as a modal dialog. If accepted, the
ChromeClient then establishes a loop that is run until the chrome is destroyed.
If denied, nothing is done.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::ChromeClient):
(WebKit::ChromeClient::chromeDestroyed):
(WebKit::ChromeClient::canRunModal):
(WebKit::ChromeClient::runModal):

  • WebCoreSupport/ChromeClientGtk.h:

(ChromeClient):

  • webkit/webkitwebview.cpp:

(webkit_web_view_class_init):

Tools:

Implement the modal dialogs handling in DumpRenderTree and GtkLauncher.
Most significantly, when creating a new web view in GtkLauncher, the window
of the web view opener is passed around. In DumpRenderTree, the window of
the main web view is always considered as the opener. This is required so
the modal dialog's toplevel can be made transient for the opener's toplevel.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(webViewRunModalDialog):
(createWebView):

  • GtkLauncher/main.c:

(createWebViewCb):
(runModalDialogCb):
(createBrowser):
(createWindow):
(main):

LayoutTests:

Unskip the passing modal dialogs tests and log the remaining skipped test.

  • platform/gtk/Skipped:
20:30 Changeset [107350] by commit-queue@webkit.org

[Gtk] security/set-form-autocomplete-attribute.html fails
https://bugs.webkit.org/show_bug.cgi?id=78261

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-02-09
Reviewed by Martin Robinson.

Source/WebKit/gtk:

Add a helper function to DumpRenderTreeSupportGtk, returning
whether or not an element does perform autocompletion.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::elementDoesAutoCompleteForElementWithId):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Tools:

Use the new helper in DumpRenderTreeSupportGtk to properly
test whether an element performs autocompletion.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::elementDoesAutoCompleteForElementWithId):

LayoutTests:

Unskip the newly-passing test

  • platform/gtk/Skipped:
20:14 Changeset [107349] by morrita@google.com

Unreviewed attempt to fix a test flakiness.

  • editing/spelling/spelling-marker-description.html:
19:48 Changeset [107348] by commit-queue@webkit.org

Eliminate dead code in BytecodeGenerator::resolve()
https://bugs.webkit.org/show_bug.cgi?id=78242

Patch by Andy Wingo <wingo@igalia.com> on 2012-02-09
Reviewed by Gavin Barraclough.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::resolve):
BytecodeGenerator::shouldOptimizeLocals() is only true for
FunctionCode, and thus cannot be true for GlobalCode.

19:45 Changeset [107347] by hayato@chromium.org

Add Node::isShadowElement() member function.
https://bugs.webkit.org/show_bug.cgi?id=78201

Reviewed by Dimitri Glazkov.

No tests. No change in behavior. An upcoming change requires this to detect HTMLShadowElement.

  • dom/Node.h:

(Node):
(WebCore::Node::isShadowElement):

  • html/shadow/HTMLShadowElement.h:

(WebCore::HTMLShadowElement::isShadowElement):

19:34 Changeset [107346] by rniwa@webkit.org

CachedResourceLoader is destroyed before CSSFontSelector is destroyed
https://bugs.webkit.org/show_bug.cgi?id=77817

Reviewed by Adam Barth.

Explicitly clear style selector before destorying the cached resource loader.

No new tests but PerformanceTests/Parser/html5-full-render.html was crashing
on performance bots due to this bug.

  • dom/Document.cpp:

(WebCore::Document::~Document):

19:14 Changeset [107345] by commit-queue@webkit.org

Remove BytecodeGenerator::isLocal
https://bugs.webkit.org/show_bug.cgi?id=78241

Minor refactor to BytecodeGenerator.

Patch by Andy Wingo <wingo@igalia.com> on 2012-02-09
Reviewed by Gavin Barraclough.

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::isLocal):
(JSC::BytecodeGenerator::isLocalConstant): Remove now-unused
methods.

  • bytecompiler/NodesCodegen.cpp:

(JSC::ResolveNode::isPure): Use the ResolveResult mechanism
instead of isLocal. This will recognize more resolve nodes as
being pure.
(JSC::PrefixResolveNode::emitBytecode): Use isReadOnly on the
location instead of isLocalConstant.

18:55 Changeset [107344] by leo.yang@torchmobile.com.cn

[BlackBerry] Upstream JavaScriptDebuggerBlackBerry.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=78203

Reviewed by Rob Buis.

Initial upstream, no new tests.

  • blackberry/WebCoreSupport/JavaScriptDebuggerBlackBerry.cpp: Added.
  • blackberry/WebCoreSupport/JavaScriptDebuggerBlackBerry.h: Added.
18:47 Changeset [107343] by cevans@google.com

Merge 106972
BUG=112093
Review URL: https://chromiumcodereview.appspot.com/9371041

18:45 Changeset [107342] by cevans@google.com

Merge 106715
BUG=112093
Review URL: https://chromiumcodereview.appspot.com/9374044

18:35 Changeset [107341] by cevans@google.com

Merge 106972
BUG=112093
Review URL: https://chromiumcodereview.appspot.com/9375043

18:33 Changeset [107340] by jamesr@google.com

[chromium] Unreviewed expectation followup for r107329

  • platform/chromium-linux/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium/test_expectations.txt:
18:32 Changeset [107339] by cevans@google.com

Merge 106715
BUG=112093
Review URL: https://chromiumcodereview.appspot.com/9374043

18:26 Changeset [107338] by oliver@apple.com

The JS Parser scope object needs a VectorTrait specialization
https://bugs.webkit.org/show_bug.cgi?id=78308

Reviewed by Gavin Barraclough.

This showed up as a periodic crash in various bits of generated code
originally, but I've added an assertion in the bytecode generator
that makes the effected code much more crash-happy should it go
wrong again.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::resolve):

  • parser/Parser.cpp:
  • parser/Parser.h:

(JSC):

  • runtime/JSActivation.h:

(JSC::JSActivation::isValidScopedLookup):
(JSActivation):

18:19 Changeset [107337] by rniwa@webkit.org

Perf-o-matic shouldn't rely on memcache to store cached JSON responses
https://bugs.webkit.org/show_bug.cgi?id=78306

Reviewed by Adam Barth.

Added PersistentCache model that stores the generated JSON responses.

  • Websites/webkit-perf.appspot.com/controller.py:

(set_persistent_cache):
(set_persistent_cache.execute):
(get_persistent_cache):
(cache_manifest):
(CachedManifestHandler.get):
(cache_dashboard):
(CachedDashboardHandler.get):
(cache_runs):
(CachedRunsHandler.get):

  • Websites/webkit-perf.appspot.com/models.py:

(TestResult):
(ReportLog):
(PersistentCache):

18:13 Changeset [107336] by cevans@google.com

Merge 106744
BUG=104317
Review URL: https://chromiumcodereview.appspot.com/9374042

18:10 Changeset [107335] by andersca@apple.com

Update the scroll layer position on the main thread when we have slow repaint objects
https://bugs.webkit.org/show_bug.cgi?id=78300
<rdar://problem/10710754>

Reviewed by Dan Bernstein.

When we have slow repaint objects (background-attachment: fixed), we need to update the
scroll layer position on the main thread, otherwise the web page will appear to jiggle.

  • page/FrameView.cpp:

(WebCore::FrameView::addSlowRepaintObject):
(WebCore::FrameView::removeSlowRepaintObject):
Call ScrollingCoordinator::frameViewHasSlowRepaintObjectsDidChange if needed.

  • page/FrameView.h:

(WebCore::FrameView::hasSlowRepaintObjects):
Add new getter.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::frameViewHasSlowRepaintObjectsDidChange):
Call ScrollingTreeNode::shouldUpdateScrollLayerPositionOnMainThread.

(WebCore::ScrollingCoordinator::updateMainFrameScrollPositionAndScrollLayerPosition):
New function that will update both the main frame scroll position and the scroll layer position.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::updateMainFrameScrollPositionAndScrollLayerPosition):
Dispatch a call to ScrollingCoordinator::updateMainFrameScrollPositionAndScrollLayerPosition on the main thread.

  • page/scrolling/ScrollingTreeNode.cpp:

(WebCore::ScrollingTreeNode::ScrollingTreeNode):
Initialize m_shouldUpdateScrollLayerPositionOnMainThread.

(WebCore::ScrollingTreeNode::update):
Set m_shouldUpdateScrollLayerPositionOnMainThread.

  • page/scrolling/ScrollingTreeState.cpp:

(WebCore::ScrollingTreeState::ScrollingTreeState):
Initialize m_shouldUpdateScrollLayerPositionOnMainThread.

(WebCore::ScrollingTreeState::setShouldUpdateScrollLayerPositionOnMainThread):
Update m_shouldUpdateScrollLayerPositionOnMainThread if needed.

  • page/scrolling/mac/ScrollingTreeNodeMac.mm:

(WebCore::ScrollingTreeNodeMac::setScrollPosition):
Assert that we're not supposed to update the scroll layer position on the main thread.

(WebCore::ScrollingTreeNodeMac::scrollBy):
If we're supposed to update the scroll layer position on the main thread,
call ScrollingTree::updateMainFrameScrollPositionAndScrollLayerPosition.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::frameViewDidScroll):
If the frame view has its scrolling coordinated by a scrolling coordinator, don't update the scroll layer position.

17:58 Changeset [107334] by cevans@google.com

Merge 106744
BUG=104317
Review URL: https://chromiumcodereview.appspot.com/9375041

17:57 Changeset [107333] by cevans@google.com

Merge 106150
BUG=104317
Review URL: https://chromiumcodereview.appspot.com/9371039

17:54 Changeset [107332] by andersca@apple.com

FrameView::addSlowRepaintObject() doesn't update m_canBlitOnScroll correctly
https://bugs.webkit.org/show_bug.cgi?id=78291

Reviewed by Dan Bernstein.

m_slowRepaintObjectCount needs to be incremented before calling updateCanBlitOnScrollRecursively(),
because otherwise useSlowRepaints() will return false even though we have to use slow repaints.

I was unable to make a layout test for this because it requires that updateCanBlitOnScrollRecursively() isn't
called again after m_slowRepaintObjectCount has been incremented.

  • page/FrameView.cpp:

(WebCore::FrameView::addSlowRepaintObject):

17:48 Changeset [107331] by cevans@google.com

Merge 106852
BUG=106336
Review URL: https://chromiumcodereview.appspot.com/9373051

17:47 Changeset [107330] by cevans@google.com

Merge 106852
BUG=106336
Review URL: https://chromiumcodereview.appspot.com/9371036

17:45 Changeset [107329] by jamesr@google.com

[chromium] Enable mock scrollbars for compositing layout tests
https://bugs.webkit.org/show_bug.cgi?id=78299

Reviewed by Dirk Pranke.

Tools:

This enables mock scrollbars by default for compositing tests. These pixel tests are intended to test the
compositor behavior, not native theming, and having real scrollbars causes us to have to maintain significantly
more pngs than we should and expose weird alpha bugs in our theming that doesn't impact real users.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::runFileTest):

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset):
(WebPreferences::applyTo):

  • DumpRenderTree/chromium/WebPreferences.h:

(WebPreferences):

LayoutTests:

  • platform/chromium-linux/compositing/direct-image-compositing-expected.png:
  • platform/chromium-linux/compositing/geometry/ancestor-overflow-change-expected.png: Removed.
  • platform/chromium-linux/compositing/geometry/fixed-in-composited-expected.png:
  • platform/chromium-linux/compositing/geometry/tall-page-composited-expected.png: Removed.
  • platform/chromium-linux/compositing/iframes/iframe-copy-on-scroll-expected.png:
  • platform/chromium-linux/compositing/iframes/iframe-in-composited-layer-expected.png: Removed.
  • platform/chromium-linux/compositing/masks/masked-ancestor-expected.png:
  • platform/chromium-linux/compositing/masks/multiple-masks-expected.png:
  • platform/chromium-linux/compositing/masks/simple-composited-mask-expected.png:
  • platform/chromium-linux/compositing/overflow/overflow-scroll-expected.png:
  • platform/chromium-linux/compositing/overflow/scrollbar-painting-expected.png:
  • platform/chromium-mac/compositing/geometry/tall-page-composited-expected.png: Removed.
  • platform/chromium-mac/compositing/iframes/iframe-in-composited-layer-expected.png: Removed.
  • platform/chromium-win/compositing/geometry/ancestor-overflow-change-expected.png: Removed.
  • platform/chromium-win/compositing/geometry/tall-page-composited-expected.png: Removed.
  • platform/chromium-win/compositing/iframes/iframe-in-composited-layer-expected.png: Removed.
  • platform/chromium-win/compositing/scaling/tiled-layer-recursion-expected.png: Removed.
  • platform/chromium/compositing/geometry/ancestor-overflow-change-expected.png:
  • platform/chromium/compositing/geometry/tall-page-composited-expected.png: Renamed from LayoutTests/platform/chromium-linux/compositing/scaling/tiled-layer-recursion-expected.png.
  • platform/chromium/compositing/iframes/iframe-in-composited-layer-expected.png: Added.
  • platform/chromium/compositing/scaling/tiled-layer-recursion-expected.png:
  • platform/chromium/test_expectations.txt:
17:44 Changeset [107328] by cevans@google.com

Merge 107123
BUG=112694
Review URL: https://chromiumcodereview.appspot.com/9372049

17:43 Changeset [107327] by cevans@google.com

Merge 107123
BUG=112694
Review URL: https://chromiumcodereview.appspot.com/9375040

17:38 Changeset [107326] by cevans@google.com

Merge 106968
BUG=112847
Review URL: https://chromiumcodereview.appspot.com/9372048

17:36 Changeset [107325] by cevans@google.com

Merge 106968
BUG=112847
Review URL: https://chromiumcodereview.appspot.com/9375039

17:24 Changeset [107324] by cevans@google.com

Merge 106771
BUG=112735
Review URL: https://chromiumcodereview.appspot.com/9369055

17:24 Changeset [107323] by leviw@chromium.org

Correcting remaining usage of enclosingIntRect in RenderLayer.cpp. These should all be pixel snapped.

17:23 Changeset [107322] by cevans@google.com

Merge 106771
BUG=112735
Review URL: https://chromiumcodereview.appspot.com/9369053

17:18 Changeset [107321] by cevans@google.com

Merge 107023
BUG=111088
Review URL: https://chromiumcodereview.appspot.com/9371035

17:17 Changeset [107320] by cevans@google.com

Merge 107023
BUG=111088
Review URL: https://chromiumcodereview.appspot.com/9370044

17:17 Changeset [107319] by lforschler@apple.com

Versioning.

17:16 Changeset [107318] by mdelaney@apple.com

Quick fix for an omission from r107301 caught by jchaffraix

17:15 Changeset [107317] by ojan@chromium.org

Remove TreeOrderIterator and iterate over the child boxes directly.
https://bugs.webkit.org/show_bug.cgi?id=78294

Reviewed by Tony Chang.

No new tests. This is purely a refactor. No change in behavior.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):

  • rendering/RenderFlexibleBox.h:

(RenderFlexibleBox):
(FlexOrderHashTraits):
(WebCore::RenderFlexibleBox::FlexOrderHashTraits::emptyValue):
(WebCore::RenderFlexibleBox::FlexOrderHashTraits::constructDeletedValue):
(WebCore::RenderFlexibleBox::FlexOrderHashTraits::isDeletedValue):

17:13 Changeset [107316] by cevans@google.com

Merge 106818
BUG=111779
Review URL: https://chromiumcodereview.appspot.com/9371034

17:12 Changeset [107315] by cevans@google.com

Merge 106818
BUG=111779
Review URL: https://chromiumcodereview.appspot.com/9374039

17:11 Changeset [107314] by haraken@chromium.org

Code generators should support multiple values for the [CallWith=] attribute
https://bugs.webkit.org/show_bug.cgi?id=78224

Reviewed by Adam Barth.

Currently we can specify only one value for one [CallWith=],
like [CallWith=ScriptExecutionContext] or [CallWith=ScriptState].
To reduce redundant IDL attributes, we are planning to support multiple
values for [CallWith=], like [CallWith=ScriptExecutionContext|ScriptArguments|CallStack].
This patch makes a change on code generators to support it.

Test: bindings/scripts/test/TestObj.idl
No change in WebKit behavior since IDL files have not yet used [CallWith=X|Y|Z].

  • bindings/scripts/CodeGenerator.pm: Modified to support [CallWith=X|Y|Z].

(ExtendedAttributeContains):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
(GenerateCallWith):
(GenerateParametersCheck):
(GenerateImplementationFunctionCall):
(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateCallWith):
(GenerateFunctionCallString):

  • bindings/scripts/test/TestObj.idl: Added test cases for [CallWith=X|Y|Z].
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated run-bindings-tests results.

(WebDOMTestObj::withScriptExecutionContextAndScriptStateAttribute):
(WebDOMTestObj::setWithScriptExecutionContextAndScriptStateAttribute):
(WebDOMTestObj::withScriptExecutionContextAndScriptStateAttributeRaises):
(WebDOMTestObj::setWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebDOMTestObj::withScriptExecutionContextAndScriptStateWithSpacesAttribute):
(WebDOMTestObj::setWithScriptExecutionContextAndScriptStateWithSpacesAttribute):
(WebDOMTestObj::withScriptExecutionContextAndScriptState):
(WebDOMTestObj::withScriptExecutionContextAndScriptStateObjException):
(WebDOMTestObj::withScriptExecutionContextAndScriptStateWithSpaces):

  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_with_script_execution_context_and_script_state):
(webkit_dom_test_obj_with_script_execution_context_and_script_state_obj_exception):
(webkit_dom_test_obj_with_script_execution_context_and_script_state_with_spaces):
(webkit_dom_test_obj_get_with_script_execution_context_and_script_state_attribute):
(webkit_dom_test_obj_set_with_script_execution_context_and_script_state_attribute):
(webkit_dom_test_obj_get_with_script_execution_context_and_script_state_attribute_raises):
(webkit_dom_test_obj_set_with_script_execution_context_and_script_state_attribute_raises):
(webkit_dom_test_obj_get_with_script_execution_context_and_script_state_with_spaces_attribute):
(webkit_dom_test_obj_set_with_script_execution_context_and_script_state_with_spaces_attribute):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptState):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateObjException):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateWithSpaces):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj withScriptExecutionContextAndScriptStateAttribute]):
(-[DOMTestObj setWithScriptExecutionContextAndScriptStateAttribute:]):
(-[DOMTestObj withScriptExecutionContextAndScriptStateAttributeRaises]):
(-[DOMTestObj setWithScriptExecutionContextAndScriptStateAttributeRaises:]):
(-[DOMTestObj withScriptExecutionContextAndScriptStateWithSpacesAttribute]):
(-[DOMTestObj setWithScriptExecutionContextAndScriptStateWithSpacesAttribute:]):
(-[DOMTestObj withScriptExecutionContextAndScriptState]):
(-[DOMTestObj withScriptExecutionContextAndScriptStateObjException]):
(-[DOMTestObj withScriptExecutionContextAndScriptStateWithSpaces]):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::withScriptExecutionContextAndScriptStateAttributeAttrGetter):
(TestObjInternal):
(WebCore::TestObjInternal::withScriptExecutionContextAndScriptStateAttributeAttrSetter):
(WebCore::TestObjInternal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjInternal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjInternal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrGetter):
(WebCore::TestObjInternal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetter):
(WebCore::TestObjInternal::withScriptExecutionContextAndScriptStateCallback):
(WebCore::TestObjInternal::withScriptExecutionContextAndScriptStateObjExceptionCallback):
(WebCore::TestObjInternal::withScriptExecutionContextAndScriptStateWithSpacesCallback):
(WebCore):

17:09 Changeset [107313] by lforschler@apple.com

New Tag.

16:56 Changeset [107312] by haraken@chromium.org

Rename [ConvertNullStringTo=] to [TreatReturnedNullStringAs=]
https://bugs.webkit.org/show_bug.cgi?id=78108

Reviewed by Adam Barth.

[ConvertNullStringTo=] is not descriptive. To clarify that it specifies
the behavior when the null string is returned by WebCore, this patch renames
[ConvertNullStringTo=] to [TreatReturnedNullStringAs=]. This change is also
for naming consistency with [TreatNullAs] and [TreatUndefinedAs].

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(NativeToJSValue):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementationIndexer):
(NativeToJSValue):

  • bindings/scripts/test/TestObj.idl:
  • css/CSSCharsetRule.idl:
  • css/CSSImportRule.idl:
  • css/CSSPageRule.idl:
  • css/CSSRule.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSStyleRule.idl:
  • css/CSSValue.idl:
  • css/MediaList.idl:
  • css/StyleSheet.idl:
  • css/WebKitCSSKeyframesRule.idl:
  • dom/Attr.idl:
  • dom/CharacterData.idl:
  • dom/Clipboard.idl:
  • dom/DOMStringList.idl:
  • dom/Document.idl:
  • dom/DocumentType.idl:
  • dom/Element.idl:
  • dom/Entity.idl:
  • dom/MutationRecord.idl:
  • dom/Node.idl:
  • dom/Notation.idl:
  • dom/ProcessingInstruction.idl:
  • html/DOMTokenList.idl:
  • html/DOMURL.idl:
  • html/HTMLMediaElement.idl:
  • html/canvas/WebGLDebugShaders.idl:
  • html/canvas/WebGLRenderingContext.idl:
  • page/DOMWindow.idl:
  • storage/IDBObjectStore.idl:
  • storage/IDBRequest.idl:
  • storage/Storage.idl:
  • storage/StorageEvent.idl:
  • websockets/WebSocket.idl:
  • xml/XMLHttpRequest.idl:
  • xml/XPathNSResolver.idl:
  • xml/XSLTProcessor.idl:
16:54 Changeset [107311] by leviw@chromium.org

Removing an unnecessary parameter from LayoutPainter and switching it to use pixelSnapped instead of enclosingIntRect. This fixes some unnecessary repaints.

16:42 Changeset [107310] by tony@chromium.org

more refactoring of RenderFlexibleBox in preparation for multiline
https://bugs.webkit.org/show_bug.cgi?id=78281

Reviewed by Ojan Vafai.

Previously, we were creating Vector of each flex item's preferred size in document order,
but for multiline, we need to break the lines in the flex order. I just removed this code
since it was the wrong order.

Instead, have 2 funtions, computeMainAxisPreferredSizes which only does the necessary
layouts and margin computations to compute preferred sizes and computeFlexOrder which
does the work of computing the flex order, preferred sizes, positive/negative flex.

For multiline, we will have computeFlexOrder drive a while loop and it will return the
flex items, preferred size, and positive/negative flex values for each line.

No new tests, just refactoring.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes): Only layout auto sized children and set margins.
(WebCore::RenderFlexibleBox::computeFlexOrder): Compute flex order, preferred size, positive/negative flex.
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithm): Use the precomputed flex order.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Use the precomputed flex order.
(WebCore::RenderFlexibleBox::layoutColumnReverse): Use the precomputed flex order.
(WebCore::RenderFlexibleBox::alignChildren): Use the precomputed flex order.

  • rendering/RenderFlexibleBox.h:

(RenderFlexibleBox):

16:40 Changeset [107309] by jchaffraix@webkit.org

Another unreviewed massive SVG rebaseline (all our windows bots that I missed).

  • platform/chromium-linux/svg/custom/animate-target-id-changed-expected.png: Removed.
  • platform/chromium-linux/svg/custom/animate-target-id-changed-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/clip-path-href-changes-expected.png: Removed.
  • platform/chromium-linux/svg/custom/clip-path-href-changes-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/fill-opacity-update-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/js-late-clipPath-and-object-creation-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/js-update-container-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/js-update-gradient-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/marker-child-changes-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/marker-strokeWidth-changes-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/prevent-default-expected.png: Removed.
  • platform/chromium-linux/svg/custom/prevent-default-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/repaint-stroke-width-changes-expected.png: Removed.
  • platform/chromium-linux/svg/custom/repaint-stroke-width-changes-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/stroke-opacity-update-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/use-elementInstance-event-target-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/custom/use-setAttribute-crash-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/custom/repaint-stroke-width-changes-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/use-elementInstance-event-target-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/use-setAttribute-crash-expected.txt:
  • platform/chromium-win-vista/svg/custom/use-setAttribute-crash-expected.txt: Added.
  • platform/chromium-win-xp/svg/custom/use-setAttribute-crash-expected.txt: Added.
  • platform/chromium-win/svg/custom/animate-target-id-changed-expected.png:
  • platform/chromium-win/svg/custom/animate-target-id-changed-expected.txt: Removed.
  • platform/chromium-win/svg/custom/clip-path-href-changes-expected.png:
  • platform/chromium-win/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
  • platform/chromium-win/svg/custom/prevent-default-expected.png:
  • platform/chromium-win/svg/custom/repaint-stroke-width-changes-expected.png:
  • platform/chromium-win/svg/custom/use-elementInstance-event-target-expected.txt:
  • platform/chromium-win/svg/custom/use-setAttribute-crash-expected.txt:
  • platform/chromium/svg/custom/clip-path-href-changes-expected.txt: Removed.
  • platform/chromium/svg/custom/fill-opacity-update-expected.txt: Removed.
  • platform/chromium/svg/custom/js-update-container-expected.txt: Removed.
  • platform/chromium/svg/custom/js-update-gradient-expected.txt: Removed.
  • platform/chromium/svg/custom/marker-child-changes-expected.txt: Removed.
  • platform/chromium/svg/custom/marker-strokeWidth-changes-expected.txt: Removed.
  • platform/chromium/svg/custom/prevent-default-expected.txt: Removed.
  • platform/chromium/svg/custom/repaint-stroke-width-changes-expected.txt: Removed.
  • platform/chromium/svg/custom/stroke-opacity-update-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:

Marked the really fishy rebaseline here.

16:36 Changeset [107308] by lforschler@apple.com

Merged r106596.

16:36 Changeset [107307] by mdelaney@apple.com

HiDPI: WebKit2's drag images are blurry
https://bugs.webkit.org/show_bug.cgi?id=67779

Use the proper deviceScaleFactor() instead of accessing _intrinsicDeviceScaleFactor

Reviewed by Beth Dakin.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _setDragImage:at:linkDrag:]):

16:35 Changeset [107306] by adamk@chromium.org

Split one MutationObserver layout test into two
https://bugs.webkit.org/show_bug.cgi?id=78285

Reviewed by Ojan Vafai.

Rather than a single non-event-delivery.html test,
created seperate tests for SQL database and FileSystem,
making it easy to skip them separately if the underlying
feature isn't supported by a particular platform.

  • fast/mutation/database-callback-delivery-expected.txt: Added.
  • fast/mutation/database-callback-delivery.html: Added.
  • fast/mutation/filesystem-callback-delivery-expected.txt: Added.
  • fast/mutation/filesystem-callback-delivery.html: Added.
  • fast/mutation/non-event-delivery-expected.txt: Removed.
  • fast/mutation/non-event-delivery.html: Removed.
16:31 Changeset [107305] by eae@chromium.org

Remove unnecessary type conversions.

16:25 Changeset [107304] by haraken@chromium.org

Rename [Optional=CallWithDefaultValue] and [Optional=CallWithNullValue]
https://bugs.webkit.org/show_bug.cgi?id=78200

Reviewed by Adam Barth.

[Optional=CallWithDefaultValue] and [Optional=CallWithNullValue] are confusing.

  • [Optional=CallWithDefaultValue] indicates that a missing value should be treated

as if the JavaScript undefined is passed.

  • [Optional=CallWithNullValue] indicates that a missing value should be treated as

the WebKit null value (i.e. JSValue() or v8::Local<v8::Value>()).

  • Actually, the difference between [Optional=CallWithDefaultValue] and

[Optional=CallWithNullValue] will appear only when the type of the missing value
is DOMString. In case of [Optional=CallWithDefaultValue], the missing value is
converted to the string "undefined". On the other hand, in case of
[Optional=CallWithNullValue], the missing value is converted to the WebKit null string.

With these observations, this patch renames as follows:

  • Rename [Optional=CallWithDefaultValue] to [Optional=DefaultIsUndefined].
  • Rename [Optional=CallWithNullValue] to [Optional=DefaultIsNullString].

Test: bindings/scripts/test/TestObj.idl

  • bindings/js/JSDOMBinding.h: Renamed MissingIsEmpty to DefaultIsNullString,

renamed MissingIsUndefined to DefaultIsUndefined.

  • bindings/v8/V8Binding.h: Ditto.
  • bindings/v8/custom/V8BindingMacros.h: Ditto.
  • bindings/scripts/CodeGeneratorJS.pm: Modified to support the renaming.

(GenerateParametersCheck):

  • bindings/scripts/CodeGeneratorV8.pm: Ditto.

(GenerateParametersCheck):
(RequiresCustomSignature):

  • bindings/scripts/test/TestObj.idl: Renamed [Optional=...] as described above.
  • bindings/scripts/test/TestInterface.idl: Ditto.
  • bindings/scripts/test/TestNamedConstructor.idl: Ditto.
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated run-bindings-tests results.

(WebDOMTestObj::methodWithOptionalString):
(WebDOMTestObj::methodWithOptionalStringIsUndefinedString):
(WebDOMTestObj::methodWithOptionalStringIsNullString):

  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_method_with_optional_string):
(webkit_dom_test_obj_method_with_optional_string_is_undefined_string):
(webkit_dom_test_obj_method_with_optional_string_is_null_string):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalString):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsUndefinedString):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsNullString):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj methodWithOptionalString:]):
(-[DOMTestObj methodWithOptionalStringIsUndefinedString:]):
(-[DOMTestObj methodWithOptionalStringIsNullString:]):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::methodWithOptionalStringCallback):
(TestObjInternal):
(WebCore::TestObjInternal::methodWithOptionalStringIsUndefinedStringCallback):
(WebCore::TestObjInternal::methodWithOptionalStringIsNullStringCallback):
(WebCore):

  • Modules/gamepad/GamepadList.idl: Renamed [Optional=...] as described above.
  • Modules/intents/Intent.idl:
  • css/CSSMediaRule.idl:
  • css/CSSPrimitiveValue.idl:
  • css/CSSRuleList.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSStyleSheet.idl:
  • css/CSSValueList.idl:
  • css/MediaList.idl:
  • css/MediaQueryList.idl:
  • css/MediaQueryListListener.idl:
  • css/StyleMedia.idl:
  • css/StyleSheetList.idl:
  • css/WebKitCSSKeyframesRule.idl:
  • css/WebKitCSSMatrix.idl:
  • dom/CharacterData.idl:
  • dom/ClientRectList.idl:
  • dom/CompositionEvent.idl:
  • dom/CustomEvent.idl:
  • dom/DOMImplementation.idl:
  • dom/DOMStringList.idl:
  • dom/DataTransferItem.idl:
  • dom/DataTransferItemList.idl:
  • dom/DeviceMotionEvent.idl:
  • dom/DeviceOrientationEvent.idl:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/Event.idl:
  • dom/HashChangeEvent.idl:
  • dom/KeyboardEvent.idl:
  • dom/MessageEvent.idl:
  • dom/MouseEvent.idl:
  • dom/MutationEvent.idl:
  • dom/NamedNodeMap.idl:
  • dom/Node.idl:
  • dom/NodeFilter.idl:
  • dom/NodeList.idl:
  • dom/OverflowEvent.idl:
  • dom/Range.idl:
  • dom/ShadowRoot.idl:
  • dom/Text.idl:
  • dom/TextEvent.idl:
  • dom/TouchEvent.idl:
  • dom/UIEvent.idl:
  • dom/WheelEvent.idl:
  • html/DOMFormData.idl:
  • html/HTMLAllCollection.idl:
  • html/HTMLAudioElement.idl:
  • html/HTMLCanvasElement.idl:
  • html/HTMLCollection.idl:
  • html/HTMLDocument.idl:
  • html/HTMLElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLOptionElement.idl:
  • html/HTMLOptionsCollection.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLTableElement.idl:
  • html/HTMLTableRowElement.idl:
  • html/HTMLTableSectionElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/TextTrackCue.idl:
  • html/canvas/CanvasGradient.idl:
  • html/canvas/CanvasRenderingContext2D.idl:
  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/OESVertexArrayObject.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • html/canvas/Uint8ClampedArray.idl:
  • page/Console.idl:
  • page/DOMSelection.idl:
  • page/DOMWindow.idl:
  • page/History.idl:
  • page/Location.idl:
  • plugins/DOMMimeTypeArray.idl:
  • plugins/DOMPlugin.idl:
  • plugins/DOMPluginArray.idl:
  • storage/IDBDatabase.idl:
  • storage/StorageEvent.idl:
  • svg/ElementTimeControl.idl:
  • svg/SVGDocument.idl:
  • svg/SVGElementInstanceList.idl:
  • svg/SVGFEDropShadowElement.idl:
  • svg/SVGFEGaussianBlurElement.idl:
  • svg/SVGFEMorphologyElement.idl:
  • svg/SVGFilterElement.idl:
  • svg/SVGLocatable.idl:
  • svg/SVGMarkerElement.idl:
  • svg/SVGPathElement.idl:
  • svg/SVGSVGElement.idl:
  • svg/SVGStylable.idl:
  • svg/SVGTests.idl:
  • svg/SVGTextContentElement.idl:
  • webaudio/AudioNode.idl:
  • workers/SharedWorker.idl:
  • workers/WorkerContext.idl:
  • xml/DOMParser.idl:
  • xml/XMLSerializer.idl:
  • xml/XPathEvaluator.idl:
  • xml/XPathExpression.idl:
  • xml/XPathNSResolver.idl:
  • xml/XPathResult.idl:
16:21 Changeset [107303] by cevans@google.com

Merge 106694
BUG=112151
Review URL: https://chromiumcodereview.appspot.com/9371032

16:09 Changeset [107302] by eric@webkit.org

Remove more uses of "os" from our webkitpy code
https://bugs.webkit.org/show_bug.cgi?id=78292

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/checkout/checkout_mock.py:

(MockCheckout.init):
(MockCheckout.is_path_to_changelog):

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  • Scripts/webkitpy/common/system/filesystem_mock.py:

(MockFileSystem._split):

  • Scripts/webkitpy/common/system/zipfileset_unittest.py:
  • Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/tool/bot/queueengine.py:
  • Scripts/webkitpy/tool/bot/sheriff_unittest.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  • Scripts/webkitpy/tool/commands/rebaselineserver.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
  • Scripts/webkitpy/tool/commands/upload.py:

(CreateBug.prompt_for_bug_title_and_comment):

  • Scripts/webkitpy/tool/servers/reflectionhandler.py:
  • Scripts/webkitpy/tool/steps/attachtobug.py:

(AttachToBug.run):

  • Scripts/webkitpy/tool/steps/checkstyle.py:
  • Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
  • Scripts/webkitpy/tool/steps/commit_unittest.py:
  • Scripts/webkitpy/tool/steps/editchangelog.py:
  • Scripts/webkitpy/tool/steps/preparechangelog.py:
  • Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:

(PrepareChangeLogTest.test_ensure_bug_url):

  • Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
  • Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
  • Scripts/webkitpy/tool/steps/validatereviewer.py:
16:05 Changeset [107301] by mdelaney@apple.com

getComputedStyle() returns different values for different zoom levels
https://bugs.webkit.org/show_bug.cgi?id=32230

Reviewed by Beth Dakin.

Source/WebCore:

Test: fast/css/getComputedStyle/getComputedStyle-zoom-and-background-size.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::fillSizeToCSSValue): Pass down the RenderStyle for use in adjusting
values to account for zoom.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Adjust additional
properties that are affected by zoom.

LayoutTests:

  • fast/css/getComputedStyle/getComputedStyle-zoom-and-background-size-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-zoom-and-background-size.html: Added.
15:59 Changeset [107300] by cevans@google.com

Merge 107046
BUG=113160
Review URL: https://chromiumcodereview.appspot.com/9370040

15:41 Changeset [107299] by haraken@chromium.org

Rename [Return] to [CustomReturn]
https://bugs.webkit.org/show_bug.cgi?id=78225

Reviewed by Adam Barth.

[Return] is used to handle custom code for a returned value.
To clarify it, this patch renames [Return] to [CustomReturn].

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorCPP.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateFunction):

  • bindings/scripts/CodeGeneratorObjC.pm:

(GenerateImplementation):

  • dom/Node.idl:
15:33 Changeset [107298] by jchaffraix@webkit.org

Unreviewed gardening.

  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Replaced.
  • platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt: Removed.
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.

Updated those baseline for line-grid-snap to line-snap renaming.

  • platform/chromium/test_expectations.txt:

Added another crasher following r107242.

15:09 Changeset [107297] by eric@webkit.org

Remove the cr-mac-ews (it's long been dead)
https://bugs.webkit.org/show_bug.cgi?id=78267

Reviewed by Adam Barth.

  • QueueStatusServer/model/queues.py:

(Queue):

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(ChromiumWindowsEWS):

  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

(EarlyWarningSytemTest._test_builder_ews):
(EarlyWarningSytemTest._test_testing_ews):

15:09 Changeset [107296] by leviw@chromium.org

Add roundedIntPoint method for LayoutPoints
https://bugs.webkit.org/show_bug.cgi?id=78262

Reviewed by Eric Seidel.

Adding a roundedIntPoint method that operates on a LayoutPoint. Currently, this does
nothing as LayoutPoint is a typedef to IntPoint. When we enable sub-pixel LayoutUnits,
this is a critical part in our pixel snapping strategy, where we round the logical top-
left point, then snap the right and bottom edges.

Also using this new method where we wish to convert LayoutPoints to IntPoints, which
we're currently doing implicitly (since they're the same thing).

No new tests. No change in functionality.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::visiblePositionForPoint):
(WebCore::AccessibilityRenderObject::accessibilityHitTest):

  • page/EventHandler.cpp:

(WebCore::EventHandler::eventMayStartDrag):
(WebCore::EventHandler::hitTestResultAtPoint):
(WebCore::EventHandler::selectCursor):

  • rendering/LayoutTypes.h:

(WebCore::roundedIntPoint):
(WebCore):

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::getReplacementTextGeometry):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::paintIntoRegion):

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::getCursor):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::paintReplaced):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollRectToVisible):
(WebCore::RenderLayer::offsetFromResizeCorner):
(WebCore::RenderLayer::isPointInResizeControl):
(WebCore::RenderLayer::paintLayerContents):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintContents):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::paintContents):

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::paint):

  • rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::paint):

  • rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::paint):

  • rendering/mathml/RenderMathMLSquareRoot.cpp:

(WebCore::RenderMathMLSquareRoot::paint):

15:06 Changeset [107295] by jamesr@google.com

[chromium] Update baselines for compositing/iframes/iframe-content-flipping.html

  • platform/chromium-mac-snowleopard/compositing/iframes/iframe-content-flipping-expected.png: Renamed from LayoutTests/platform/chromium-mac/compositing/iframes/iframe-content-flipping-expected.png.
  • platform/chromium-win/compositing/iframes/iframe-content-flipping-expected.png:
  • platform/chromium/test_expectations.txt:
14:46 Changeset [107294] by rwlbuis@webkit.org

[BlackBerry] Upstream BlackBerry WebKitSupport WebPageCompositor class
https://bugs.webkit.org/show_bug.cgi?id=78276

Reviewed by Antonio Gomes.

Initial upstream, no new tests.

  • blackberry/WebKitSupport/WebPageCompositor.cpp: Added.
  • blackberry/WebKitSupport/WebPageCompositor.h: Added.
14:33 Changeset [107293] by dpranke@chromium.org

some tests in webkitpy are being run three times
https://bugs.webkit.org/show_bug.cgi?id=78283

Reviewed by Ryosuke Niwa.

It turns out that if you import a class derived from
unittest.TestCase as a base name (e.g., from ... import ChangeLogTest),
the unittest framework treats it as if the class was defined in
the file (as well in the original file). This led us to running
the tests in ChangeLogTest three times.

  • Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:

(PrepareChangeLogTest):

  • Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:

(_assert_message_for_revert_output):

14:19 Changeset [107292] by eae@chromium.org

Merge trunk changes for xcode project file up until 107124.

14:18 Changeset [107291] by commit-queue@webkit.org

[Chromium] Add chromium-style tracing support
https://bugs.webkit.org/show_bug.cgi?id=76885

Patch by John Bates <jbates@google.com> on 2012-02-09
Reviewed by Darin Fisher.

This code enables WebKit trace events to pass through more data to the
chromium platform tracing API and generally to use the full tracing
API provided by chromium.

Source/WebCore:

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::evaluate): Replace old tracing API.

  • page/Console.cpp:

(WebCore::Console::time): Replace old tracing API.
(WebCore::Console::timeEnd): Replace old tracing API.

  • platform/chromium/PlatformSupport.h:
  • platform/chromium/TraceEvent.h:

(WebCore::TraceEvent::TraceID::TraceID):
(WebCore::TraceEvent::TraceID::data):
(WebCore::TraceEvent::TraceStringWithCopy::TraceStringWithCopy):
(WebCore::TraceEvent::TraceStringWithCopy::operator const char* ):
(WebCore::TraceEvent::setTraceValue):
(WebCore::TraceEvent::addTraceEvent):
(WebCore::TraceEvent::TraceEndOnScopeClose::TraceEndOnScopeClose):
(WebCore::TraceEvent::TraceEndOnScopeClose::~TraceEndOnScopeClose):
(WebCore::TraceEvent::TraceEndOnScopeClose::initialize):
(WebCore::TraceEvent::TraceEndOnScopeClose::addEventIfEnabled):
(WebCore::TraceEvent::TraceEndOnScopeCloseThreshold::TraceEndOnScopeCloseThreshold):
(WebCore::TraceEvent::TraceEndOnScopeCloseThreshold::~TraceEndOnScopeCloseThreshold):
(WebCore::TraceEvent::TraceEndOnScopeCloseThreshold::initialize):
(WebCore::TraceEvent::TraceEndOnScopeCloseThreshold::addEventIfEnabled):

Source/WebKit/chromium:

  • public/platform/WebKitPlatformSupport.h:

(WebKit::WebKitPlatformSupport::getTraceCategoryEnabledFlag):
(WebKit::WebKitPlatformSupport::addTraceEvent):

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::getTraceCategoryEnabledFlag):
(WebCore::PlatformSupport::addTraceEvent):

14:17 Changeset [107290] by eae@chromium.org

Changed QWebElement::geometry to pixel snap values as opposed to returning a QRectF

13:59 Changeset [107289] by hyatt@apple.com

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=78256

Rename line-grid-snap to line-snap so that it matches the draft proposal for the
property.

Reviewed by Dan Bernstein.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator LineSnap):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::alignBoxesInBlockDirection):
(WebCore::RootInlineBox::lineSnapAdjustment):

  • rendering/RootInlineBox.h:

(RootInlineBox):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h:

(StyleRareInheritedData):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=78256

Rename line-grid-snap to line-snap so that it matches the draft proposal for the
property.

Reviewed by Dan Bernstein.

  • fast/line-grid/line-grid-contains-value.html:
  • fast/line-grid/line-grid-floating.html:
  • fast/line-grid/line-grid-inside-columns.html:
  • fast/line-grid/line-grid-into-columns.html:
  • fast/line-grid/line-grid-into-floats.html:
  • fast/line-grid/line-grid-nested.html:
  • fast/line-grid/line-grid-positioned.html:
  • fast/line-grid/line-grid-snap-parsing.html: Removed.
  • fast/line-grid/line-snap-parsing-expected.txt: Added.
  • fast/line-grid/line-snap-parsing.html: Added.
  • fast/line-grid/script-tests/line-grid-snap-parsing.js: Removed.
  • fast/line-grid/script-tests/line-snap-parsing.js: Added.
13:47 Changeset [107288] by benjamin@webkit.org

The localization of htmlSelectMultipleItems() needs better support of pluralization
https://bugs.webkit.org/show_bug.cgi?id=78197

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-02-09
Reviewed by Joseph Pecoraro.

For translation, the localization of 0 and 1 depends on the language.

  • English.lproj/Localizable.strings:
  • platform/DefaultLocalizationStrategy.cpp:

(WebCore::DefaultLocalizationStrategy::htmlSelectMultipleItems):

13:40 Changeset [107287] by commit-queue@webkit.org

[chromium] Plumb setNeedsRedraw.
https://bugs.webkit.org/show_bug.cgi?id=78248

Patch by Jonathan Backer <backer@chromium.org> on 2012-02-09
Reviewed by James Robinson.

  • public/platform/WebLayerTreeView.h:

(WebLayerTreeView):

  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::setNeedsRedraw):
(WebKit):

13:37 Changeset [107286] by abarth@webkit.org

Remove extraneous line in previous patch. I forgot to remove this
before landing.

  • Scripts/webkitpy/layout_tests/port/driver.py:

(DriverProxy.start):

13:31 Changeset [107285] by andersca@apple.com

ScrollingTreeNodeMac should implement ScrollElasticityController
https://bugs.webkit.org/show_bug.cgi?id=78277

Reviewed by Andreas Kling.

Add stubbed out implementations of the ScrollElasticityController member functions.

  • page/scrolling/mac/ScrollingTreeNodeMac.h:

(ScrollingTreeNodeMac):

  • page/scrolling/mac/ScrollingTreeNodeMac.mm:

(WebCore::ScrollingTreeNodeMac::allowsHorizontalStretching):
(WebCore):
(WebCore::ScrollingTreeNodeMac::allowsVerticalStretching):
(WebCore::ScrollingTreeNodeMac::stretchAmount):
(WebCore::ScrollingTreeNodeMac::pinnedInDirection):
(WebCore::ScrollingTreeNodeMac::canScrollHorizontally):
(WebCore::ScrollingTreeNodeMac::canScrollVertically):
(WebCore::ScrollingTreeNodeMac::shouldRubberBandInDirection):
(WebCore::ScrollingTreeNodeMac::absoluteScrollPosition):
(WebCore::ScrollingTreeNodeMac::immediateScrollBy):
(WebCore::ScrollingTreeNodeMac::immediateScrollByWithoutContentEdgeConstraints):
(WebCore::ScrollingTreeNodeMac::startSnapRubberbandTimer):
(WebCore::ScrollingTreeNodeMac::stopSnapRubberbandTimer):

13:26 Changeset [107284] by abarth@webkit.org

run-perf-tests should have an option to pause before running tests so we can attach Instruments
https://bugs.webkit.org/show_bug.cgi?id=78271

Reviewed by Ryosuke Niwa.

This lets me attach instruments to profile the performance of the test.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumDriver.start):

  • Scripts/webkitpy/layout_tests/port/driver.py:

(Driver.start):
(DriverProxy.start):

  • Scripts/webkitpy/layout_tests/port/server_process.py:

(ServerProcess.start):

  • Scripts/webkitpy/layout_tests/port/test.py:

(TestDriver.start):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitDriver.start):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(get_tests_run.RecordingTestDriver.start):

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._parse_args):
(PerfTestsRunner._run_tests_set):

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(start):
(test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
(test_run_test_set_kills_drt_per_run):
(test_run_test_set_kills_drt_per_run.TestDriverWithStartCount):
(test_run_test_set_kills_drt_per_run.TestDriverWithStartCount.start):

13:23 Changeset [107283] by eae@chromium.org

Merged windows project file

13:20 Changeset [107282] by enne@google.com

[chromium] Correct potential double reserveTextures() in CCLayerTreeHost
https://bugs.webkit.org/show_bug.cgi?id=78258

Reviewed by James Robinson.

This isn't a problem currently, because scrollbar layers don't create
render surfaces. However, if this ever got used for other layers, we
could call reserve on them twice needlessly. It's also just bad form
to have an iterator doing the wrong thing.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::reserveTextures):

13:07 Changeset [107281] by jchaffraix@webkit.org

Unreviewed rebaseline, yet another small font difference.

  • platform/chromium-mac-leopard/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-win-xp/svg/carto.net/selectionlist-expected.png: Added.
  • platform/chromium-win-xp/svg/carto.net/selectionlist-expected.txt: Added.
13:02 Changeset [107280] by ap@apple.com

[WK2] Allow reading some debug-only preference files
https://bugs.webkit.org/show_bug.cgi?id=78255
<rdar://problem/9382382>
<rdar://problem/10830558>

Reviewed by Dan Bernstein.

  • WebProcess/com.apple.WebProcess.sb:
13:01 Changeset [107279] by jchaffraix@webkit.org

Unreviewed, rolling out r107261.
http://trac.webkit.org/changeset/107261
https://bugs.webkit.org/show_bug.cgi?id=78274

It has regressed svg/W3C-SVG-1.1/styling-css-05-b.svg (using
lang() selectors) (Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-09

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithControl):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::isCommonAttributeSelectorAttribute):

12:49 Changeset [107278] by jsbell@chromium.org

[Chromium] IndexedDB: IDBVersionChangeRequest V8 wrapper not generated as ActiveDOMObject
https://bugs.webkit.org/show_bug.cgi?id=78167

Source/WebCore:

Add ActiveDOMObject annotation to IDBVersionChangeRequest.idl; it is not
automagically inherited from IDBRequest.idl.

Reviewed by Adam Barth.

Test: storage/indexeddb/versionchangerequest-activedomobject.html

  • storage/IDBVersionChangeRequest.idl:

LayoutTests:

Reviewed by Adam Barth.

  • storage/indexeddb/versionchangerequest-activedomobject-expected.txt: Added.
  • storage/indexeddb/versionchangerequest-activedomobject.html: Added.
12:44 Changeset [107277] by andersca@apple.com

The scrolling tree should know more about the scrollbar state
https://bugs.webkit.org/show_bug.cgi?id=78268

Reviewed by Andreas Kling.

With this change, the scroll tree now keeps track of the horizontal scroll elasticity,
the vertical scroll elasticity and whether the page has enabled scrollbars.

This is needed in order to make rubber-banding work correctly when doing fast scrolling.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):

  • page/scrolling/ScrollingTreeNode.cpp:

(WebCore::ScrollingTreeNode::ScrollingTreeNode):
(WebCore::ScrollingTreeNode::update):

  • page/scrolling/ScrollingTreeNode.h:

(ScrollingTreeNode):

  • page/scrolling/ScrollingTreeState.cpp:

(WebCore::ScrollingTreeState::ScrollingTreeState):
(WebCore::ScrollingTreeState::setHorizontalScrollElasticity):
(WebCore):
(WebCore::ScrollingTreeState::setVerticalScrollElasticity):
(WebCore::ScrollingTreeState::setHasEnabledHorizontalScrollbar):
(WebCore::ScrollingTreeState::setHasEnabledVerticalScrollbar):

  • page/scrolling/ScrollingTreeState.h:

(WebCore::ScrollingTreeState::horizontalScrollElasticity):
(ScrollingTreeState):
(WebCore::ScrollingTreeState::verticalScrollElasticity):
(WebCore::ScrollingTreeState::hasEnabledHorizontalScrollbar):
(WebCore::ScrollingTreeState::hasEnabledVerticalScrollbar):

12:43 Changeset [107276] by enne@google.com

Merge 107024 - Properly detect top level frames when propogating compositing
https://bugs.webkit.org/show_bug.cgi?id=78033

Reviewed by James Robinson.

There's no need to enumerate all tag names when searching for a
top-level frame. If a render view's document has a frame, then that
frame is not the top-level one.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingFrame):

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

TBR=enne@google.com
Review URL: https://chromiumcodereview.appspot.com/9369039

12:21 Changeset [107275] by abarth@webkit.org

run-perf-tests --chromium should run the chromium port
https://bugs.webkit.org/show_bug.cgi?id=78266

Reviewed by Ryosuke Niwa.

This patch makes run-perf-tests work more like run-webkit-tests.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._parse_args):

12:20 Changeset [107274] by rniwa@webkit.org

Perf-o-matic should update memcache in taskqueue
https://bugs.webkit.org/show_bug.cgi?id=78209

Reviewed by Adam Barth.

Update dashboard, manifest, and runs memcaches in taskqueue.
Also centralized the management of caches in controller.py.

  • Websites/webkit-perf.appspot.com/app.yaml:
  • Websites/webkit-perf.appspot.com/controller.py: Added.

(cache_manifest):
(schedule_manifest_update):
(CachedManifestHandler):
(CachedManifestHandler.get):
(cache_dashboard):
(schedule_dashboard_update):
(CachedDashboardHandler):
(CachedDashboardHandler.get):
(cache_runs):
(schedule_runs_update):
(CachedRunsHandler):
(CachedRunsHandler.get):

  • Websites/webkit-perf.appspot.com/create_handler.py:

(CreateHandler.post):

  • Websites/webkit-perf.appspot.com/dashboard_handler.py:

(DashboardHandler.post):

  • Websites/webkit-perf.appspot.com/main.py:
  • Websites/webkit-perf.appspot.com/manifest_handler.py:

(ManifestHandler.post):

  • Websites/webkit-perf.appspot.com/merge_tests_handler.py:

(MergeTestsHandler.post):

  • Websites/webkit-perf.appspot.com/report_handler.py:

(ReportHandler.post):

  • Websites/webkit-perf.appspot.com/runs_handler.py:

(RunsHandler.post):

12:18 Changeset [107273] by commit-queue@webkit.org

[Qt][WK2] run-webkit-tests --qt crashes if WEBKIT_TESTFONTS is not set
https://bugs.webkit.org/show_bug.cgi?id=77466

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2012-02-09
Reviewed by Dirk Pranke.

Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
is set or if we should raise an error. A unit test was added.

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort.operating_system):
(QtPort):
(QtPort.check_sys_deps):

  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:

(QtPortTest.test_operating_system):
(QtPortTest):
(QtPortTest.test_check_sys_deps):

12:11 Changeset [107272] by eae@chromium.org

Fix usage of LayoutUnit in GestureTapHighlighter and update QT port to use explicit subpixel to platform types conversion.

12:11 Changeset [107271] by eric@webkit.org

Rename ports.WebKitPort to DeprecatedPort and make it stop being all class methods
https://bugs.webkit.org/show_bug.cgi?id=78263

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/config/ports.py:

(DeprecatedPort):
(DeprecatedPort.name):
(DeprecatedPort.flag):
(DeprecatedPort.script_path):
(DeprecatedPort.script_shell_command):
(DeprecatedPort.port):
(DeprecatedPort.makeArgs):
(DeprecatedPort.update_webkit_command):
(DeprecatedPort.check_webkit_style_command):
(DeprecatedPort.prepare_changelog_command):
(DeprecatedPort.build_webkit_command):
(DeprecatedPort.run_javascriptcore_tests_command):
(DeprecatedPort.run_webkit_unit_tests_command):
(DeprecatedPort.run_webkit_tests_command):
(DeprecatedPort.run_python_unittests_command):
(DeprecatedPort.run_perl_unittests_command):
(DeprecatedPort.layout_tests_results_path):
(MacPort):
(WinPort):
(GtkPort):
(GtkPort.build_webkit_command):
(GtkPort.run_webkit_tests_command):
(QtPort):
(QtPort.build_webkit_command):
(EflPort):
(EflPort.build_webkit_command):
(ChromiumPort):
(ChromiumPort.update_webkit_command):
(ChromiumPort.build_webkit_command):
(ChromiumPort.run_webkit_tests_command):
(ChromiumPort.run_javascriptcore_tests_command):
(ChromiumXVFBPort):
(ChromiumXVFBPort.run_webkit_tests_command):

  • Scripts/webkitpy/common/config/ports_unittest.py:

(DeprecatedPortTest):
(DeprecatedPortTest.test_mac_port):
(DeprecatedPortTest.test_gtk_port):
(DeprecatedPortTest.test_qt_port):
(DeprecatedPortTest.test_chromium_port):
(DeprecatedPortTest.test_chromium_xvfb_port):

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(AbstractEarlyWarningSystem.init):

  • Scripts/webkitpy/tool/commands/sheriffbot.py:
  • Scripts/webkitpy/tool/main.py:

(WebKitPatch):
(WebKitPatch.handle_global_options):

  • Scripts/webkitpy/tool/steps/abstractstep.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:

(StepsTest.test_runtests_args):

12:04 Changeset [107270] by wangxianzhu@chromium.org

Unnecessary and incorrect invalidation about composited fixed-position layers
https://bugs.webkit.org/show_bug.cgi?id=75638

When a FrameView scrolls, composited fixed-position layers should
not contribute to the invalidation rect of the root layer.

Reviewed by Simon Fraser.

No new tests. Haven't found a good way to test this programatically.

  • page/FrameView.cpp:

(WebCore::FrameView::scrollContentsFastPath):

11:56 Changeset [107269] by leviw@chromium.org

Fixing an overflow rect calculated in RenderListMarker to use pixelSnapped instead of enclosingIntRect.

11:44 Changeset [107268] by jchaffraix@webkit.org

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:

Mark fast/workers/storage/interrupt-database.html as slow to see if it helps with the flakiness.
Mark a new animation test as flaky (already know issue in the animation testing framework).

11:35 Changeset [107267] by mdelaney@apple.com

HiDPI: WebKit2's link-dragging images are blurry
https://bugs.webkit.org/show_bug.cgi?id=67779

Reviewed by Beth Dakin.

Teach startDrag about the deviceScaleFactor so that it creates
an appropriately scaled bitmap image to ship over.

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::WebDragClient::startDrag):
(WebKit::convertImageToBitmap):

Have setDragImage assume that it's receiving a bitmap image scaled
up by the deviceScaleFactor that it sees.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _setDragImage:at:linkDrag:]):

11:16 Changeset [107266] by commit-queue@webkit.org

Unreviewed, rolling out r107035.
http://trac.webkit.org/changeset/107035
https://bugs.webkit.org/show_bug.cgi?id=78253

Regressed DOMDivWalk (Requested by arv on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-09

Source/WebCore:

  • Target.pri:
  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(HasCustomToV8Implementation):

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::toV8):
(WebCore):

  • bindings/v8/custom/V8DOMTokenListCustom.cpp: Copied from Source/WebCore/bindings/v8/custom/V8NamedNodeMapCustom.cpp.

(WebCore):
(WebCore::toV8):

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:

(WebCore::toV8):
(WebCore):

LayoutTests:

  • platform/chromium/test_expectations.txt:
11:15 Changeset [107265] by leviw@chromium.org

isPointInResizeControl should not truncate LayoutUnits when determining its boundaries.

11:12 Changeset [107264] by jchaffraix@webkit.org

Another unreviewed svg rebaselining after r107207.

  • platform/chromium-mac-leopard/svg/custom/animate-path-discrete-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/custom/circle-move-invalidation-expected.png:
  • platform/chromium-mac-leopard/svg/custom/js-late-clipPath-creation-expected.png:
  • platform/chromium-mac-leopard/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/chromium-mac-leopard/svg/custom/js-late-gradient-creation-expected.png:
  • platform/chromium-mac-leopard/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/chromium-mac-leopard/svg/custom/relative-sized-content-expected.png:
  • platform/chromium-mac-leopard/svg/custom/relative-sized-deep-shadow-tree-content-expected.png:
  • platform/chromium-mac-leopard/svg/custom/relative-sized-image-expected.png:
  • platform/chromium-mac-leopard/svg/custom/relative-sized-inner-svg-expected.png:
  • platform/chromium-mac-leopard/svg/custom/relative-sized-shadow-tree-content-expected.png:
  • platform/chromium-mac-leopard/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.png:
  • platform/chromium-mac-leopard/svg/custom/relative-sized-use-on-symbol-expected.png:
  • platform/chromium-mac-leopard/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png:
  • platform/chromium-mac-leopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-mac-leopard/svg/custom/text-xy-updates-SVGList-expected.png:
  • platform/chromium-mac-leopard/svg/custom/use-disappears-after-style-update-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/custom/use-elementInstance-methods-expected.png:
  • platform/chromium-mac-leopard/svg/custom/use-event-handler-on-referenced-element-expected.png:
  • platform/chromium-mac-leopard/svg/custom/use-event-handler-on-use-element-expected.png:
  • platform/chromium-mac-leopard/svg/custom/use-instanceRoot-event-bubbling-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/use-instanceRoot-event-listeners-expected.png: Added.
11:11 Changeset [107263] by commit-queue@webkit.org

MathML internals for bug 52444 fix - type checking, PassRefPtr
https://bugs.webkit.org/show_bug.cgi?id=78180

Patch by David Barton <dbarton@mathscribe.com> on 2012-02-09
Reviewed by Eric Seidel.

static_cast<Element*>(node()) is done in methods in RenderMathMLFenced.cpp and a few
other files. It is more type-safe if the RenderMathMLFenced() or other constructor only
accepts an Element*, not a Node*. Also a couple functions were changed to return a
PassRefPtr instead of a RefPtr.

No new tests.

  • rendering/mathml/RenderMathMLFenced.cpp:

(WebCore::RenderMathMLFenced::RenderMathMLFenced):
(WebCore::RenderMathMLFenced::updateFromElement):
(WebCore::RenderMathMLFenced::makeOperatorStyle):
(WebCore::RenderMathMLFenced::makeFences):
(WebCore::RenderMathMLFenced::addChild):

  • rendering/mathml/RenderMathMLFenced.h:

(RenderMathMLFenced):

  • rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::RenderMathMLFraction):

  • rendering/mathml/RenderMathMLFraction.h:

(RenderMathMLFraction):

  • rendering/mathml/RenderMathMLMath.cpp:

(WebCore::RenderMathMLMath::RenderMathMLMath):

  • rendering/mathml/RenderMathMLMath.h:

(RenderMathMLMath):

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::RenderMathMLOperator):
(WebCore::RenderMathMLOperator::updateFromElement):
(WebCore::RenderMathMLOperator::createStackableStyle):
(WebCore::RenderMathMLOperator::createGlyph):

  • rendering/mathml/RenderMathMLOperator.h:

(RenderMathMLOperator):

  • rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::RenderMathMLRoot):
(WebCore::RenderMathMLRoot::layout):

  • rendering/mathml/RenderMathMLRoot.h:

(RenderMathMLRoot):

  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::RenderMathMLRow):

  • rendering/mathml/RenderMathMLRow.h:

(RenderMathMLRow):

  • rendering/mathml/RenderMathMLSquareRoot.cpp:

(WebCore::RenderMathMLSquareRoot::RenderMathMLSquareRoot):

  • rendering/mathml/RenderMathMLSquareRoot.h:

(RenderMathMLSquareRoot):

  • rendering/mathml/RenderMathMLSubSup.cpp:

(WebCore::RenderMathMLSubSup::addChild):

  • rendering/mathml/RenderMathMLSubSup.h:

(RenderMathMLSubSup):

  • rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore::RenderMathMLUnderOver::RenderMathMLUnderOver):

  • rendering/mathml/RenderMathMLUnderOver.h:

(RenderMathMLUnderOver):

11:01 Changeset [107262] by jchaffraix@webkit.org

Unreviewed gardening.

  • platform/chromium-mac-snowleopard/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-mac-snowleopard/svg/carto.net/selectionlist-expected.txt: Added.

New baseline (font issue).

  • platform/chromium/test_expectations.txt:

Added 2 tests that started asserting on one bot.

10:56 Changeset [107261] by kling@webkit.org

Avoid unnecessary work when evaluating style sharing candidates.
<http://webkit.org/b/78220>

Reviewed by Antti Koivisto.

Do the cheap checks (bitfields, pointers) before calling virtuals and doing hash lookups.
Remove comparison of attributes that are reflected in the attribute styles (cellpadding,
lang and xml:lang.) Moved comparison of "type" and "readonly" attributes into the more
specific canShareStyleWithControl() since they are only relevant for input elements.
Don't bother calling isFormControlElement() on both elements since we already know they
have the same tagQName().

Altogether this knocks off 8-9ms worth of samples per cycle of the "Moz" page cycler test.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithControl):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::isCommonAttributeSelectorAttribute):

10:38 Changeset [107260] by commit-queue@webkit.org

[EFL] Introducing functions to set local storage db path and clear
those dbs.
https://bugs.webkit.org/show_bug.cgi?id=77107

This patch exposes the web local storage tracker database path
setting cabability, introduced on bug 77006, to the EFL port of
WebKit. Particularly, we have our own storage tracker client
object, to initialize the storage tracker backend on ewk_init().

Patch by Gustavo Lima Chaves <glima@profusion.mobi> on 2012-02-09
Reviewed by Kenneth Rohde Christiansen.

  • CMakeListsEfl.txt:
  • WebCoreSupport/StorageTrackerClientEfl.cpp: Added.

(WebCore):
(WebCore::StorageTrackerClientEfl::dispatchDidModifyOrigin):
(WebCore::StorageTrackerClientEfl::didFinishLoadingOrigins):

  • WebCoreSupport/StorageTrackerClientEfl.h: Added.

(WebCore):
(StorageTrackerClientEfl):

  • ewk/ewk_main.cpp:

(trackerClient):
(_ewk_init_body):

  • ewk/ewk_settings.cpp:

(ewk_settings_local_storage_path_set):
(ewk_settings_local_storage_path_get):
(ewk_settings_local_storage_database_clear):
(ewk_settings_local_storage_database_origin_clear):

  • ewk/ewk_settings.h:
10:27 Changeset [107259] by mikelawther@chromium.org

CSS3 calc() - remove mod
https://bugs.webkit.org/show_bug.cgi?id=78226

Source/WebCore:

mod has been removed from the spec for calc().

Reviewed by Ojan Vafai.

  • css/CSSCalculationValue.cpp:

(WebCore::CSSCalcBinaryOperation::create):
(WebCore::CSSCalcBinaryOperation::evaluate):
(WebCore::CSSCalcExpressionNodeParser::parseValueMultiplicativeExpression):

  • css/CSSGrammar.y:
  • platform/CalculationValue.h:

LayoutTests:

Reviewed by Ojan Vafai.

  • css3/calc/simple-calcs-expected.txt:
  • css3/calc/simple-calcs.html:
09:59 WebKitGTK/1.6.x edited by mrobinson@webkit.org
(diff)
09:42 Changeset [107258] by jochen@chromium.org

Add missing file for fast/events/scroll-event-during-modal-dialog.html
https://bugs.webkit.org/show_bug.cgi?id=78234

Reviewed by Mihai Parparita.

  • fast/events/resources/scroll-event-modal-dialog.html: Added.
09:42 Changeset [107257] by pfeldman@chromium.org

Web Inspector: rename DOMEditor to DOMPatchSupport, move undoable actions from
InspectorDOMAgent to the new DOMEditor.
https://bugs.webkit.org/show_bug.cgi?id=78245

Reviewed by Yury Semikhatsky.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/DOMEditor.cpp:

(DOMEditor::DOMAction):
(WebCore::DOMEditor::DOMAction::DOMAction):
(WebCore::DOMEditor::DOMAction::perform):
(WebCore::DOMEditor::DOMAction::undo):
(DOMEditor::RemoveChildAction):
(WebCore::DOMEditor::RemoveChildAction::RemoveChildAction):
(WebCore::DOMEditor::RemoveChildAction::perform):
(WebCore::DOMEditor::RemoveChildAction::undo):
(DOMEditor::InsertBeforeAction):
(WebCore::DOMEditor::InsertBeforeAction::InsertBeforeAction):
(WebCore::DOMEditor::InsertBeforeAction::perform):
(WebCore::DOMEditor::InsertBeforeAction::undo):
(DOMEditor::RemoveAttributeAction):
(WebCore::DOMEditor::RemoveAttributeAction::RemoveAttributeAction):
(WebCore::DOMEditor::RemoveAttributeAction::perform):
(WebCore::DOMEditor::RemoveAttributeAction::undo):
(DOMEditor::SetAttributeAction):
(WebCore::DOMEditor::SetAttributeAction::SetAttributeAction):
(WebCore::DOMEditor::SetAttributeAction::perform):
(WebCore::DOMEditor::SetAttributeAction::undo):
(DOMEditor::SetOuterHTMLAction):
(WebCore::DOMEditor::SetOuterHTMLAction::SetOuterHTMLAction):
(WebCore::DOMEditor::SetOuterHTMLAction::perform):
(WebCore::DOMEditor::SetOuterHTMLAction::undo):
(WebCore::DOMEditor::SetOuterHTMLAction::newNode):
(DOMEditor::ReplaceWholeTextAction):
(WebCore::DOMEditor::ReplaceWholeTextAction::ReplaceWholeTextAction):
(WebCore::DOMEditor::ReplaceWholeTextAction::perform):
(WebCore::DOMEditor::ReplaceWholeTextAction::undo):
(WebCore::DOMEditor::DOMEditor):
(WebCore):
(WebCore::DOMEditor::~DOMEditor):
(WebCore::DOMEditor::insertBefore):
(WebCore::DOMEditor::removeChild):
(WebCore::DOMEditor::setAttribute):
(WebCore::DOMEditor::removeAttribute):
(WebCore::DOMEditor::setOuterHTML):
(WebCore::DOMEditor::replaceWholeText):

  • inspector/DOMEditor.h:

(WebCore):
(DOMEditor):

  • inspector/DOMPatchSupport.cpp: Copied from Source/WebCore/inspector/DOMEditor.cpp.

(WebCore::DOMPatchSupport::DOMPatchSupport):
(WebCore::DOMPatchSupport::~DOMPatchSupport):
(WebCore::DOMPatchSupport::patchDocument):
(WebCore::DOMPatchSupport::patchNode):
(WebCore::DOMPatchSupport::innerPatchNode):
(WebCore):
(WebCore::DOMPatchSupport::diff):
(WebCore::DOMPatchSupport::innerPatchChildren):
(WebCore::DOMPatchSupport::createDigest):
(WebCore::DOMPatchSupport::insertBefore):
(WebCore::DOMPatchSupport::removeChild):
(WebCore::DOMPatchSupport::markNodeAsUsed):
(WebCore::DOMPatchSupport::dumpMap):

  • inspector/DOMPatchSupport.h: Copied from Source/WebCore/inspector/DOMEditor.h.

(DOMPatchSupport):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::setFrontend):
(WebCore::InspectorDOMAgent::clearFrontend):
(WebCore::InspectorDOMAgent::reset):
(WebCore::InspectorDOMAgent::setAttributeValue):
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::removeAttribute):
(WebCore::InspectorDOMAgent::removeNode):
(WebCore::InspectorDOMAgent::setNodeName):
(WebCore::InspectorDOMAgent::setOuterHTML):
(WebCore::InspectorDOMAgent::setNodeValue):
(WebCore::InspectorDOMAgent::moveTo):

  • inspector/InspectorDOMAgent.h:

(WebCore):
(InspectorDOMAgent):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::setDocumentContent):

09:31 Changeset [107256] by mrowe@apple.com

REGRESSION (r104746): iframes load PDFs as media documents
<http://webkit.org/b/77079> / <rdar://problem/10757933>

Roll out r104746 since it completely broke support for loading PDF documents in subframes.

Reviewed by Adam Treat.

  • dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createDocument):

09:25 Changeset [107255] by jochen@chromium.org

[chromium] always initialize makeArgs in buildChromiumNinja
https://bugs.webkit.org/show_bug.cgi?id=78231

Reviewed by Tony Gentilcore.

  • Scripts/webkitdirs.pm:

(buildChromiumNinja):

09:18 Changeset [107254] by carlosgc@webkit.org

[GTK] Show url of current hovered link in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=78098

Reviewed by Martin Robinson.

  • MiniBrowser/gtk/BrowserWindow.c:

(webViewMouseTargetChanged): Check whether hit test result is a
link and use the url to update the status bar text.
(browserWindowConstructed): Connect to
WebKitWebView::mouse-target-changed signal.

09:11 Changeset [107253] by podivilov@chromium.org

2012-02-09 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, gardening, more svg fixes.

Mark svg/custom/absolute-sized-content-with-resources.xhtml as IMAGE+TEXT and
rebaseline svg/carto.net/slider-expected.png.

  • platform/chromium-linux/svg/carto.net/slider-expected.png:
  • platform/chromium/test_expectations.txt:
09:09 Changeset [107252] by mrobinson@webkit.org

Build fix for GTK+ 2.x after my previous commit.

  • webkit/webkitwebview.cpp:

(webkit_web_view_expose_event): The name of the event is expose_event and not expose.

08:53 Changeset [107251] by caseq@chromium.org

Web Inspector: [refactoring] take _showShortEvents out of timeline calculator
https://bugs.webkit.org/show_bug.cgi?id=78230

Reviewed by Pavel Feldman.

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._toggleFilterButtonClicked):
(WebInspector.TimelinePanel.prototype._refresh):
(WebInspector.TimelinePanel.prototype._addToRecordsWindow):

08:51 Changeset [107250] by carlosgc@webkit.org

[GTK] Add WebKitWebView::mouse-target-changed signal to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=78097

Reviewed by Martin Robinson.

.:

  • Source/autotools/symbols.filter: Add freeOwnedGPtr<_GdkEvent>

symbol to be able to use GOwnPtr<GdkEvent> in WebKit2 GTK+ unit
tests.

Source/WebKit2:

  • GNUmakefile.am: Add new files to compilation.
  • UIProcess/API/gtk/WebKitHitTestResult.cpp: Added.

(webkitHitTestResultFinalize):
(webkitHitTestResultGetProperty):
(webkitHitTestResultSetProperty):
(webkit_hit_test_result_init):
(webkit_hit_test_result_class_init):
(webkitHitTestResultCreate): Create a new WebKitHitTestResult for
the given WKHitTestResult.
(stringIsEqualToCString): Helper function to compare String and
CString considering String::isEmpty() == CString.isNull().
(webkitHitTestResultCompare): Helper function to check whether a
WebKitHitTestResult contains the same information than the given
WKHitTestResult.
(webkit_hit_test_result_get_context):
(webkit_hit_test_result_context_is_link):
(webkit_hit_test_result_context_is_image):
(webkit_hit_test_result_context_is_media):
(webkit_hit_test_result_get_link_uri):
(webkit_hit_test_result_get_link_title):
(webkit_hit_test_result_get_link_label):
(webkit_hit_test_result_get_image_uri):
(webkit_hit_test_result_get_media_uri):

  • UIProcess/API/gtk/WebKitHitTestResult.h: Added.
  • UIProcess/API/gtk/WebKitHitTestResultPrivate.h:
  • UIProcess/API/gtk/WebKitNavigationPolicyDecision.cpp:

(webkitNavigationPolicyDecisionCreate): Use
wkEventModifiersToGdkModifiers.

  • UIProcess/API/gtk/WebKitPrivate.cpp:

(wkEventModifiersToGdkModifiers): Moved from
WebKitNavigationPolicyDecision and renamed to wkEventModifiersToGdkModifiers.

  • UIProcess/API/gtk/WebKitPrivate.h:
  • UIProcess/API/gtk/WebKitUIClient.cpp:

(mouseDidMoveOverElement): UI client callback that calls
webkitWebViewMouseTargetChanged().
(attachUIClientToView): Add implementation for callback
mouseDidMoveOverElement.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_class_init): Add
WebKitWebView::mouse-target-changed signal.
(webkitWebViewMouseTargetChanged): Emit
WebKitWebView::mouse-target-changed signal.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/WebKitWebViewPrivate.h:
  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new section for

WebKitHitTestResult.

  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewMouseTarget):
(beforeAll):

  • UIProcess/API/gtk/tests/WebViewTest.cpp:

(WebViewTest::WebViewTest):
(WebViewTest::~WebViewTest):
(parentWindowMapped):
(WebViewTest::showInWindowAndWaitUntilMapped): Method to add the
view into a popup window and show it running the main loop until
the window is mapped.
(WebViewTest::mouseMoveTo): Method to synthesize a
GDK_MOTION_EVENT on the given coordinates and using the given
modifiers.

  • UIProcess/API/gtk/tests/WebViewTest.h:
  • UIProcess/API/gtk/webkit2.h: Include WebKitHitTestResult.h.
  • UIProcess/API/gtk/webkit2marshal.list:
08:38 Changeset [107249] by mrobinson@webkit.org

[GTK] Embedded GtkWidgets are not drawn
https://bugs.webkit.org/show_bug.cgi?id=63451

Source/WebCore:

Remove widget from it's parent container when GtkPluginWidget is destroyed.
Remove paint() method because real expose even is used for drawing child widgets now.

Patch by Dan Vrátil <dvratil@redhat.com>, Milan Crha <mcrha@redhat.com> on 2012-02-08
Reviewed by Martin Robinson.

  • platform/gtk/GtkPluginWidget.cpp:

(WebCore::GtkPluginWidget::~GtkPluginWidget):
(WebCore):

  • platform/gtk/GtkPluginWidget.h:

(GtkPluginWidget):

Source/WebKit/gtk:

Insert plugin widgets to WebKitWebView container as it's children.
Chain up to parent in webkit_web_view_draw() to ensure the child widgets are drawn.

Patch by Dan Vrátil <dvratil@redhat.com>, Milan Crha <mcrha@redhat.com> on 2012-02-08
Reviewed by Martin Robinson.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::createPlugin):

  • webkit/webkitwebview.cpp:

(webkit_web_view_draw):

08:25 Changeset [107248] by podivilov@chromium.org

2012-02-09 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, update chromium svg expectations after r107207.

  • platform/chromium-linux-x86/svg/custom/repaint-stroke-width-changes-expected.png: Removed.
  • platform/chromium-linux/svg/custom/animate-target-id-changed-expected.png: Added.
  • platform/chromium-linux/svg/custom/animate-target-id-changed-expected.txt: Added.
  • platform/chromium-linux/svg/custom/clip-path-href-changes-expected.png: Added.
  • platform/chromium-linux/svg/custom/clip-path-href-changes-expected.txt: Added.
  • platform/chromium-linux/svg/custom/fill-opacity-update-expected.txt: Added.
  • platform/chromium-linux/svg/custom/glyph-selection-arabic-forms-expected.png: Added.
  • platform/chromium-linux/svg/custom/glyph-selection-bidi-mirror-expected.png: Added.
  • platform/chromium-linux/svg/custom/glyph-selection-non-bmp-expected.png: Copied from LayoutTests/platform/chromium-linux/svg/custom/repaint-stroke-width-changes-expected.png.
  • platform/chromium-linux/svg/custom/hit-test-with-br-expected.png:
  • platform/chromium-linux/svg/custom/js-late-clipPath-and-object-creation-expected.txt: Added.
  • platform/chromium-linux/svg/custom/js-update-container-expected.txt: Added.
  • platform/chromium-linux/svg/custom/js-update-gradient-expected.txt: Added.
  • platform/chromium-linux/svg/custom/js-update-style-expected.txt: Added.
  • platform/chromium-linux/svg/custom/marker-child-changes-expected.txt: Added.
  • platform/chromium-linux/svg/custom/marker-strokeWidth-changes-expected.txt: Added.
  • platform/chromium-linux/svg/custom/prevent-default-expected.png: Added.
  • platform/chromium-linux/svg/custom/prevent-default-expected.txt: Added.
  • platform/chromium-linux/svg/custom/repaint-on-constant-size-change-expected.png: Copied from LayoutTests/platform/chromium-linux/svg/custom/repaint-stroke-width-changes-expected.png.
  • platform/chromium-linux/svg/custom/repaint-stroke-width-changes-expected.png:
  • platform/chromium-linux/svg/custom/repaint-stroke-width-changes-expected.txt: Added.
  • platform/chromium-linux/svg/custom/stroke-opacity-update-expected.txt: Added.
  • platform/chromium-linux/svg/custom/use-crash-in-non-wellformed-document-expected.txt: Added.
  • platform/chromium-linux/svg/custom/use-elementInstance-event-target-expected.txt: Added.
  • platform/chromium-linux/svg/custom/use-setAttribute-crash-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/custom/clip-path-href-changes-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/custom/fill-opacity-update-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/custom/glyph-selection-arabic-forms-expected.png:
  • platform/chromium-mac-leopard/svg/custom/glyph-selection-arabic-forms-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/custom/glyph-selection-non-bmp-expected.png:
  • platform/chromium-mac-leopard/svg/custom/hit-test-with-br-expected.png:
  • platform/chromium-mac-leopard/svg/custom/js-late-clipPath-and-object-creation-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/custom/js-update-container-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/custom/js-update-gradient-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/custom/js-update-style-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/custom/marker-child-changes-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/custom/marker-strokeWidth-changes-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/custom/prevent-default-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/custom/stroke-opacity-update-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/custom/use-elementInstance-event-target-expected.png:
  • platform/chromium-mac-leopard/svg/custom/use-setAttribute-crash-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/glyph-selection-arabic-forms-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/glyph-selection-arabic-forms-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/glyph-selection-bidi-mirror-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/glyph-selection-non-bmp-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/glyph-selection-non-bmp-expected.txt: Removed.
  • platform/chromium-win/svg/custom/glyph-selection-arabic-forms-expected.png:
  • platform/chromium-win/svg/custom/glyph-selection-bidi-mirror-expected.txt: Added.
  • platform/chromium-win/svg/custom/glyph-selection-non-bmp-expected.png:
  • platform/chromium-win/svg/custom/glyph-selection-non-bmp-expected.txt: Removed.
  • platform/chromium-win/svg/custom/hit-test-with-br-expected.png:
  • platform/chromium-win/svg/custom/hit-test-with-br-expected.txt:
08:12 Changeset [107247] by rwlbuis@webkit.org

[BlackBerry] Upstream DumpRenderTreeBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=78042

Reviewed by Antonio Gomes.

Upstream final part of our DRT implementation.

  • DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: Added.
  • DumpRenderTree/blackberry/PNGImageEncoder.cpp: Added.
  • DumpRenderTree/blackberry/PNGImageEncoder.h: Added.
  • DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp: Added.
  • DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h: Added.
08:00 Changeset [107246] by ossy@webkit.org

[Qt] Unreviewed gardening.

  • platform/qt-5.0/fast/images/embed-image-expected.txt: Add after Qt5 update.
  • platform/qt-wk2/ [...] .png: Remove obsolete png files.
  • platform/qt/Skipped: Skip new tests without expected files.
07:53 Changeset [107245] by mikelawther@chromium.org

update CSS3 calc() color tests to use pre/post js
https://bugs.webkit.org/show_bug.cgi?id=77596

Note that these tests are intended to 'fail' as calc() functionality
had not yet landed (see http://webkit.org/b/16662)

Reviewed by Kent Tamura.

  • css3/calc/color-hsl-expected.txt:
  • css3/calc/color-hsl.html:
  • css3/calc/color-rgb-expected.txt:
  • css3/calc/color-rgb.html:
07:49 Changeset [107244] by commit-queue@webkit.org

Setting media element 'src' attribute to "" should trigger load
https://bugs.webkit.org/show_bug.cgi?id=47907

Patch by Arun Patole <arun.patole@motorola.com> on 2012-02-09
Reviewed by Eric Carlson.

Source/WebCore:

Test: media/video-src-empty.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::attributeChanged):Trigger a load, as long as the 'src' attribute is present.

LayoutTests:

  • media/video-src-empty-expected.txt: Added, test for <video> with empty src.
  • media/video-src-empty.html: Added.
  • media/video-src-none-expected.txt:
  • media/video-src-none.html: removed "empty src" test as it is handled in separate test: video-src-empty.html.
  • platform/chromium/test_expectations.txt: media/video-empty-source.html needs a rebaseline.
07:40 Changeset [107243] by commit-queue@webkit.org

[chromium] Add setNeedsRedraw to WebWidget
https://bugs.webkit.org/show_bug.cgi?id=77555

Patch by Jonathan Backer <backer@chromium.org> on 2012-02-09
Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::setNeedsRedraw):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::setFullRootLayerDamage):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::setNeedsRedraw):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::setNeedsRedraw):
(WebCore::CCThreadProxy::setFullRootLayerDamageOnImplThread):
(WebCore):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

  • public/WebWidget.h:

(WebWidget):
(WebKit::WebWidget::setNeedsRedraw):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setNeedsRedraw):
(WebKit):

  • src/WebViewImpl.h:

(WebViewImpl):

07:26 Changeset [107242] by pfeldman@chromium.org

Web Inspector: fix setOuterHTML for the case that adds / removes duplicate.
https://bugs.webkit.org/show_bug.cgi?id=78235

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/DOMEditor.cpp:

(WebCore::DOMEditor::diff):
(WebCore::DOMEditor::innerPatchChildren):
(WebCore):
(WebCore::nodeName):
(WebCore::DOMEditor::dumpMap):

  • inspector/DOMEditor.h:

(DOMEditor):

LayoutTests:

  • inspector/elements/set-outer-html-2-expected.txt:
  • inspector/elements/set-outer-html-2.html:
  • inspector/elements/set-outer-html-expected.txt:
  • inspector/elements/set-outer-html.html:
07:23 Changeset [107241] by podivilov@chromium.org

2012-02-09 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, update chromium svg expectations after r107207.

  • 400 platform/chromium*/svg/custom/* files
07:05 Changeset [107240] by ossy@webkit.org

[Qt][Mac] Skip new failing tests to paint the bot green.

  • platform/qt-mac/Skipped:
06:49 Changeset [107239] by commit-queue@webkit.org

Source/WebCore: Ensure timers and other active DOM objects do not fire in suspended documents.
https://bugs.webkit.org/show_bug.cgi?id=53733

ScriptExecutionContext now remembers it has suspended active DOM objects
and suspends all newly installed active DOM objects as well.

All create-calls active DOM objects now calls the post constructor method
suspendIfNeeded that updates the suspend state. It is post constructor
because the suspend/resume functions are virtual and thus can not be called
from constructors.

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-09
Reviewed by Mihai Parparita.

Test: fast/events/suspend-timers.html

  • Modules/intents/IntentRequest.cpp:

(WebCore::IntentRequest::create):

  • bindings/generic/ActiveDOMCallback.cpp:

(WebCore::ActiveDOMCallback::ActiveDOMCallback):

  • dom/ActiveDOMObject.cpp:

(WebCore::ActiveDOMObject::ActiveDOMObject):
(WebCore::ActiveDOMObject::~ActiveDOMObject):
(WebCore::ActiveDOMObject::suspendIfNeeded):

  • dom/ActiveDOMObject.h:

(WebCore::ActiveDOMObject::suspendIfNeededCalled):

  • dom/DocumentEventQueue.cpp:

(WebCore::DocumentEventQueue::DocumentEventQueue):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::ScriptExecutionContext):
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
(WebCore::ScriptExecutionContext::stopActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjectIfNeeded):

  • dom/ScriptExecutionContext.h:

(ScriptExecutionContext):
(WebCore::ScriptExecutionContext::activeDOMObjectsAreSuspended):

  • fileapi/DOMFileSystem.cpp:

(WebCore::DOMFileSystem::create):

  • fileapi/FileReader.cpp:

(WebCore::FileReader::create):

  • fileapi/FileReader.h:
  • fileapi/FileWriter.cpp:

(WebCore::FileWriter::create):

  • fileapi/FileWriter.h:
  • history/CachedFrame.cpp:

(WebCore::CachedFrame::CachedFrame):

  • html/HTMLAudioElement.cpp:

(WebCore::HTMLAudioElement::create):
(WebCore::HTMLAudioElement::createForJSConstructor):

  • html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::create):

  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::create):

  • mediastream/PeerConnection.cpp:

(WebCore::PeerConnection::create):

  • notifications/Notification.cpp:

(WebCore::Notification::create):

  • notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::create):

  • notifications/NotificationCenter.h:
  • page/DOMTimer.cpp:

(WebCore::DOMTimer::install):
(WebCore::DOMTimer::fired):

  • page/EventSource.cpp:

(WebCore::EventSource::create):

  • page/SuspendableTimer.cpp:

(WebCore::SuspendableTimer::SuspendableTimer):

  • storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::create):

  • storage/IDBRequest.cpp:

(WebCore::IDBRequest::create):

  • storage/IDBTransaction.cpp:

(WebCore::IDBTransaction::create):

  • storage/IDBVersionChangeRequest.cpp:

(WebCore::IDBVersionChangeRequest::create):

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::create):
(WebCore::AudioContext::createOfflineContext):

  • websockets/WebSocket.cpp:

(WebCore::WebSocket::create):

  • websockets/WebSocket.h:
  • workers/SharedWorker.cpp:

(WebCore::SharedWorker::create):

  • workers/Worker.cpp:

(WebCore::Worker::create):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::create):

LayoutTests: Test that timers do not fire from subframes of suspended documents.
https://bugs.webkit.org/show_bug.cgi?id=53733

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-09
Reviewed by Mihai Parparita.

  • fast/events/resources/suspend-subframe-1.html: Added.
  • fast/events/resources/suspend-subframe-2.html: Added.
  • fast/events/suspend-timers-expected.txt: Added.
  • fast/events/suspend-timers.html: Added.
  • platform/chromium/test_expectations.txt:
06:45 Changeset [107238] by vsevik@chromium.org

Unreviewed followup for r107235.

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._hideNavigatorOverlay):
(WebInspector.ScriptsPanel.prototype._navigatorOverlayWillHide):

06:40 Changeset [107237] by jocelyn.turcotte@nokia.com

[Qt] Fetch the visible rect from LayerTreeHost instead of keeping a copy in each layer.
https://bugs.webkit.org/show_bug.cgi?id=78009

Reviewed by Noam Rosenthal.

Since WebGraphicsLayers are now accessed directly from LayerTreeHost, they don't
need to keep the visible rect to pass it down their child layers anymore.

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::setContentsScale):
(WebCore::WebGraphicsLayer::tiledBackingStoreVisibleRect):
(WebCore::WebGraphicsLayer::adjustVisibleRect):
(WebCore):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:

(WebGraphicsLayerClient):
(WebGraphicsLayer):

  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::registerLayer):
(WebKit::LayerTreeHostQt::visibleContentsRect):
(WebKit):
(WebKit::LayerTreeHostQt::setVisibleContentRectAndScale):

  • WebProcess/WebPage/qt/LayerTreeHostQt.h:

(LayerTreeHostQt):

06:38 Changeset [107236] by jocelyn.turcotte@nokia.com

[Qt] Control the lifetime of TiledBackingStores in WebGraphicsLayer.
https://bugs.webkit.org/show_bug.cgi?id=78005

Reviewed by Noam Rosenthal.

This makes sure that no empty tiles are generated for layers without contents and that
no interaction is made with the TiledBackingStore until we got a WebGraphicsLayerClient.

  • Create the main TiledBackingStore only when the layer has drawsContent and has no directly composited image
  • Removed recreateBackingStoreIfNeeded and do the (re)creation of the backing stores in updateContentBuffers
  • Call purgeBackingStores on registered layers instead of passing it down the layer tree
  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::WebGraphicsLayer):
(WebCore::WebGraphicsLayer::~WebGraphicsLayer):
(WebCore::WebGraphicsLayer::setDrawsContent):
(WebCore::WebGraphicsLayer::setNeedsDisplayInRect):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
(WebCore::WebGraphicsLayer::setVisibleContentRectTrajectoryVector):
(WebCore::WebGraphicsLayer::tiledBackingStoreContentsRect):
(WebCore::WebGraphicsLayer::updateContentBuffers):
(WebCore::WebGraphicsLayer::purgeBackingStores):
(WebCore::WebGraphicsLayer::setWebGraphicsLayerClient):
(WebCore::WebGraphicsLayer::computeTransformedVisibleRect):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:

(WebGraphicsLayer):

  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::LayerTreeHostQt):
(WebKit::LayerTreeHostQt::flushPendingLayerChanges):
(WebKit):
(WebKit::LayerTreeHostQt::purgeBackingStores):

  • WebProcess/WebPage/qt/LayerTreeHostQt.h:

(LayerTreeHostQt):

06:37 Changeset [107235] by vsevik@chromium.org

Web Inspector: Support hiding scripts panel debug sidebar.
https://bugs.webkit.org/show_bug.cgi?id=77543

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.sh:
  • inspector/front-end/Dialog.js:

(WebInspector.Dialog):
(WebInspector.DialogDelegate.prototype.show):

  • inspector/front-end/Images/navigatorPinButton.png: Added.
  • inspector/front-end/Images/navigatorShowHideButton.png: Added.
  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator):
(WebInspector.ScriptsNavigator.prototype.get view):
(WebInspector.ScriptsNavigator.prototype.get element):
(WebInspector.ScriptsNavigator.prototype.show):
(WebInspector.ScriptsNavigator.prototype.focus):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._fileSelected):
(WebInspector.ScriptsPanel.prototype._createDebugToolbar):
(WebInspector.ScriptsPanel.prototype._createNavigatorControls):
(WebInspector.ScriptsPanel.prototype._createNavigatorControlButton):
(WebInspector.ScriptsPanel.prototype._toggleNavigator):
(WebInspector.ScriptsPanel.prototype._hidePinnedNavigator):
(WebInspector.ScriptsPanel.prototype.set _pinNavigator):
(WebInspector.ScriptsPanel.prototype.set _showNavigatorOverlay):
(WebInspector.ScriptsPanel.prototype._hideNavigatorOverlay):
(WebInspector.ScriptsPanel.prototype._navigatorOverlayWasShown):
(WebInspector.ScriptsPanel.prototype._navigatorOverlayWillHide):

  • inspector/front-end/SidebarOverlay.js: Added.
  • inspector/front-end/SplitView.js:

(WebInspector.SplitView.prototype.get resizable):
(WebInspector.SplitView.prototype.hideMainElement):
(WebInspector.SplitView.prototype.showMainElement):
(WebInspector.SplitView.prototype.hideSidebarElement):
(WebInspector.SplitView.prototype.showSidebarElement):
(WebInspector.SplitView.prototype._resizerDragging):

  • inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer.prototype.get element):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/dialog.css:
  • inspector/front-end/inspector.html:
  • inspector/front-end/scriptsPanel.css:
06:35 Changeset [107234] by jocelyn.turcotte@nokia.com

[Qt] Remove WebGraphicsLayer::updateTileBuffersRecursively
https://bugs.webkit.org/show_bug.cgi?id=78105

Reviewed by Kenneth Rohde Christiansen.

The method is unused.

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:

(WebGraphicsLayer):

06:33 Changeset [107233] by jocelyn.turcotte@nokia.com

[Qt] Register individual WebGraphicsLayers to LayerTreeHost instead of handling the tree as a whole.
https://bugs.webkit.org/show_bug.cgi?id=77976

Reviewed by Kenneth Rohde Christiansen.

The LayerTreeHost association had to be maintained between re-parented layers and it would be
impossible to know if the layer would be disconnected from the LayerTreeHost only for reparenting
or disconnected for good (in other words, that the LayerTreeHost could be deleted meanwhile).

Instead, this patch assumes that graphics layers will only be in contact with one instance of
LayerTreeHost, and that this association can be kept until either the graphics layer or the layer
tree host gets deleted.

The registered layers are kept in a set and the visible rect and scales are passed directly
to layers instead of down the tree, through the root layer.

This also fixes the !m_layerInfo.imageBackingStoreID ASSERT that was popping in unit tests.

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::WebGraphicsLayer):
(WebCore::WebGraphicsLayer::~WebGraphicsLayer):
(WebCore::WebGraphicsLayer::setChildren):
(WebCore::WebGraphicsLayer::addChild):
(WebCore::WebGraphicsLayer::addChildAtIndex):
(WebCore::WebGraphicsLayer::addChildAbove):
(WebCore::WebGraphicsLayer::addChildBelow):
(WebCore::WebGraphicsLayer::replaceChild):
(WebCore::WebGraphicsLayer::removeFromParent):
(WebCore::WebGraphicsLayer::setContentsToImage):
(WebCore::WebGraphicsLayer::setMaskLayer):
(WebCore::WebGraphicsLayer::setReplicatedByLayer):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
(WebCore::WebGraphicsLayer::setVisibleContentRectAndScale):
(WebCore::WebGraphicsLayer::tiledBackingStoreUpdatesAllowed):
(WebCore::WebGraphicsLayer::createTile):
(WebCore::WebGraphicsLayer::updateTile):
(WebCore::WebGraphicsLayer::removeTile):
(WebCore::WebGraphicsLayer::updateContentBuffers):
(WebCore::WebGraphicsLayer::purgeBackingStores):
(WebCore::WebGraphicsLayer::setWebGraphicsLayerClient):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:

(WebCore):
(WebGraphicsLayerClient):
(WebGraphicsLayer):

  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::~LayerTreeHostQt):
(WebKit::LayerTreeHostQt::LayerTreeHostQt):
(WebKit::LayerTreeHostQt::attachLayer):
(WebKit):
(WebKit::LayerTreeHostQt::detachLayer):
(WebKit::LayerTreeHostQt::setVisibleContentRectAndScale):

  • WebProcess/WebPage/qt/LayerTreeHostQt.h:

(LayerTreeHostQt):

06:31 Changeset [107232] by abecsi@webkit.org

[Qt][WK2] WebView should use Flickable instead of QScroller to handle positioning
https://bugs.webkit.org/show_bug.cgi?id=76275

Reviewed by Simon Hausmann and Kenneth Rohde Christiansen.

The current WebView implementation uses QScroller to manage positioning but other
similar items in QML (ie. ListView, GridView) use Flickable as their base class.
Since QScroller will be dropped from Qt5 this patch removes the QScroller code
and redirects pan gestures to a dynamically created encapsulated Flickable instance
(QtFlickProvider) which handles the positioning.

This implementation only uses public QML API and does not depend on declarative-private.
It propagates a small subset of the Flickable API as the public API of the WebView.
This minimalistic API is accessible via the experimental extension and makes it possible
in QML to place additional items (such as toolbars, scroll indicators and floating menus)
aroud the page.
These items can use anchoring and binding for positioning on the flickable contentItem.

The patch depends however on the automatic touch->mouse event synthetization of Qt5.
The touch events sent to the flickProvider are translated to mouse events automatically
as long as the Flickable does not handle touch events directly.

After this change QtWebKit2 does no longer depend on QtWidgets and this dependency can be
removed in a follow-up patch.

  • Target.pri: Added QtFlickProvider source.
  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPagePrivate::paintToCurrentGLContext):
(QQuickWebPage::transformToItem):
(QQuickWebPagePrivate::updateSize):

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::pageItemPos):
(QQuickWebViewFlickablePrivate::pageItemPos):
(QQuickWebViewFlickablePrivate::updateContentsSize):
(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebViewFlickablePrivate::updateViewportSize):
(QQuickWebViewExperimental::flickableData):
(QQuickWebViewExperimental::contentItem):
(QQuickWebViewExperimental::contentWidth):
(QQuickWebViewExperimental::setContentWidth):
(QQuickWebViewExperimental::contentHeight):
(QQuickWebViewExperimental::setContentHeight):
(QQuickWebViewExperimental::contentX):
(QQuickWebViewExperimental::setContentX):
(QQuickWebViewExperimental::contentY):
(QQuickWebViewExperimental::setContentY):
(QQuickWebView::pageItemPos):
(QQuickWebView::updateContentsSize):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):
(QQuickWebViewPrivate::updateContentsSize):
(QQuickWebViewFlickablePrivate):

  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::scrollRequest):

  • UIProcess/qt/QtFlickProvider.cpp: Added.

(QtFlickProvider::QtFlickProvider):
(QtFlickProvider::handleTouchFlickEvent):
(QtFlickProvider::contentItem):
(QtFlickProvider::flickableData):
(QtFlickProvider::contentPos):
(QtFlickProvider::setContentPos):
(QtFlickProvider::viewportSize):
(QtFlickProvider::setViewportSize):
(QtFlickProvider::returnToBounds):
(QtFlickProvider::cancelFlick):
(QtFlickProvider::isMoving):
(QtFlickProvider::isDragging):
(QtFlickProvider::isFlicking):
(QtFlickProvider::contentWidth):
(QtFlickProvider::setContentWidth):
(QtFlickProvider::contentHeight):
(QtFlickProvider::setContentHeight):
(QtFlickProvider::contentX):
(QtFlickProvider::setContentX):
(QtFlickProvider::contentY):
(QtFlickProvider::setContentY):

  • UIProcess/qt/QtFlickProvider.h: Added.

(QtFlickProvider):

  • UIProcess/qt/QtPanGestureRecognizer.cpp:

(WebKit::QtPanGestureRecognizer::recognize):

  • UIProcess/qt/QtPanGestureRecognizer.h:

(QtPanGestureRecognizer):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::setItemRectVisible):
(WebKit::QtViewportInteractionEngine::scrollStateChanged):
(WebKit):
(WebKit::QtViewportInteractionEngine::wheelEvent):
(WebKit::QtViewportInteractionEngine::reset):
(WebKit::QtViewportInteractionEngine::applyConstraints):
(WebKit::QtViewportInteractionEngine::scrollAnimationActive):
(WebKit::QtViewportInteractionEngine::panGestureActive):
(WebKit::QtViewportInteractionEngine::panGestureStarted):
(WebKit::QtViewportInteractionEngine::panGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::panGestureCancelled):
(WebKit::QtViewportInteractionEngine::panGestureEnded):
(WebKit::QtViewportInteractionEngine::pinchGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::scaleContent):

  • UIProcess/qt/QtViewportInteractionEngine.h:

(QtViewportInteractionEngine):

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::doneWithTouchEvent):

06:26 Changeset [107231] by zimmermann@webkit.org

2012-02-09 Nikolas Zimmermann <nzimmermann@rim.com>

Update expectations. svg/custom/nested-embedded-svg-size-changes.html no longer timeouts.

  • platform/chromium/test_expectations.txt:
05:58 Changeset [107230] by zimmermann@webkit.org

2012-02-09 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Make the hit-test-with-br.xhtml work on non-Mac platforms.
it was skipped on Chromium Win/Linux before, as the click on the <rect> never suceeeded.
On Mac the coordinate 10x70, was the upper left corner of the rectangle, so if the font
size is just slightly larger, or the size of the <br/>, then we failed to fire the click
event - so just click at 50x80, to be on the safe side.

  • svg/custom/hit-test-with-br.xhtml:
05:53 Changeset [107229] by yurys@chromium.org

Merge 106662 - inspector/debugger/pause-in-inline-script.html asserts in chromium debug
https://bugs.webkit.org/show_bug.cgi?id=77663

Source/WebCore:

Make ASSERT in MainResourceLoader not fail if debugger hits breakpoint
in the main resource inline script.

Reviewed by Pavel Feldman.

Test: inspector/debugger/pause-in-inline-script.html

  • bindings/js/ScriptDebugServer.h:

(WebCore::ScriptDebugServer::isPaused):
(ScriptDebugServer):

  • bindings/v8/ScriptDebugServer.h:

(ScriptDebugServer):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::didClearMainFrameWindowObject):
(WebCore):
(WebCore::InspectorDebuggerAgent::isPaused):

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::isDebuggerPausedImpl):
(WebCore):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::isDebuggerPaused):
(WebCore):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::didFinishLoading):

LayoutTests:

Reviewed by Pavel Feldman.

  • platform/chromium/test_expectations.txt: assert was fixed, remove custom expectation for inspector/debugger/pause-in-inline-script.html

TBR=yurys@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9375012

05:46 Changeset [107228] by yurys@chromium.org

Merge 106468 - Web Inspector: debugger reports wrong sources when paused in inline script on page reload
https://bugs.webkit.org/show_bug.cgi?id=77548

Source/WebCore:

V8 returns treats each script source as ending with \n, now we take
this into account when reporting script line count to the inspector
front-end.

Reviewed by Vsevolod Vlasov.

Test: inspector/debugger/pause-in-inline-script.html

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::dispatchDidParseSource):

  • bindings/v8/DebuggerScript.js:

LayoutTests:

Reviewed by Vsevolod Vlasov.

  • inspector/debugger/debugger-scripts-expected.txt:
  • inspector/debugger/pause-in-inline-script-expected.txt: Added.
  • inspector/debugger/pause-in-inline-script.html: Added.
  • platform/chromium/inspector/debugger/debugger-scripts-expected.txt:

TBR=yurys@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9371015

05:39 Changeset [107227] by zimmermann@webkit.org

[Chromium] Layout Test svg/as-object/nested-embedded-svg-size-changes.html times out
https://bugs.webkit.org/show_bug.cgi?id=77183

Reviewed by Zoltan Herczeg.

Another attempt at fixing svg/as-object/nested-embedded-svg-size-changes.html,
by guessing from the JS trace, where it might happened.

  • svg/as-object/nested-embedded-svg-size-changes.html:
05:37 Changeset [107226] by commit-queue@webkit.org

LayoutTests/fast/harness/resources/modal-dialog.html is missing the opening html tag
https://bugs.webkit.org/show_bug.cgi?id=78217

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-02-09
Reviewed by Andreas Kling.

Add the missing opening <html> tag.

  • fast/harness/resources/modal-dialog.html:
05:23 Changeset [107225] by commit-queue@webkit.org

Source/WebCore: Web Inspector: Show percentage by default in heap profiler.
https://bugs.webkit.org/show_bug.cgi?id=78103

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-02-09
Reviewed by Pavel Feldman.

  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotGridNode.prototype._toPercentString):
(WebInspector.HeapSnapshotGridNode.prototype._createValueCell):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
(WebInspector.HeapSnapshotConstructorNode.prototype.get data):

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.profileCallback):
(WebInspector.DetailedHeapshotView):
(WebInspector.DetailedHeapshotView.prototype.get statusBarItems):
(WebInspector.DetailedHeapshotView.prototype._mouseDownInContentsGrid):
(WebInspector.DetailedHeapshotView.prototype._updateFilterOptions):

  • inspector/front-end/UIUtils.js:

(Number.withThousandsSeparator):

  • inspector/front-end/heapProfiler.css:

(.detailed-heapshot-view .data-grid span.percent-column):

LayoutTests: WebInspector: Show percentage by default in heap profiler.
https://bugs.webkit.org/show_bug.cgi?id=78103

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-02-09
Reviewed by Pavel Feldman.

  • inspector/profiler/detailed-heapshots-test.js:
05:14 Changeset [107224] by ossy@webkit.org

[WK2] SVG animation pause API missing
https://bugs.webkit.org/show_bug.cgi?id=63396

Unreviewed gardening, skip svg/animations/animate-color-fill-from-by.html because of this bug.

  • platform/wk2/Skipped:
05:04 Changeset [107223] by loislo@chromium.org

Web Inspector: Timeline memory graph would have been more useful if it had used minUsedHeapSize as the lower bound. Currently it uses zero as the lower bound.
https://bugs.webkit.org/show_bug.cgi?id=78222

Reviewed by Pavel Feldman.

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.HeapGraph):
(WebInspector.HeapGraph.prototype.update):

  • inspector/front-end/timelinePanel.css:

(.memory-graph-label):
(.max.memory-graph-label):
(.min.memory-graph-label):

04:55 Changeset [107222] by zimmermann@webkit.org

2012-02-09 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Move platform dependant results where they belong, and add Qt specific ones.

  • platform/mac/svg/custom/glyph-selection-arabic-forms-expected.png: Renamed from LayoutTests/svg/custom/glyph-selection-arabic-forms-expected.png.
  • platform/mac/svg/custom/glyph-selection-arabic-forms-expected.txt: Renamed from LayoutTests/svg/custom/glyph-selection-arabic-forms-expected.txt.
  • platform/mac/svg/custom/glyph-selection-bidi-mirror-expected.png: Renamed from LayoutTests/svg/custom/glyph-selection-bidi-mirror-expected.png.
  • platform/mac/svg/custom/glyph-selection-bidi-mirror-expected.txt: Renamed from LayoutTests/svg/custom/glyph-selection-bidi-mirror-expected.txt.
  • platform/mac/svg/custom/glyph-selection-non-bmp-expected.png: Renamed from LayoutTests/svg/custom/glyph-selection-non-bmp-expected.png.
  • platform/mac/svg/custom/glyph-selection-non-bmp-expected.txt: Renamed from LayoutTests/svg/custom/glyph-selection-non-bmp-expected.txt.
  • platform/qt/svg/custom/glyph-selection-arabic-forms-expected.txt: Added.
  • platform/qt/svg/custom/glyph-selection-bidi-mirror-expected.txt: Added.
  • platform/qt/svg/custom/glyph-selection-non-bmp-expected.txt: Added.
04:50 Changeset [107221] by ossy@webkit.org

[Qt] Fix compilation with newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=77653

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-02-09
Reviewed by Tor Arne Vestbø.

  • Api/qgraphicswebview.cpp: Removed unnecessary inclusion of removed header file.
  • declarative/public.pri: Use quick1 instead of qtquick1. It's mandator with Qt 5.
  • tests/tests.pri: Ditto.
  • declarative/qdeclarativewebview_p.h: Fix includes, just use the module-less

version that works with all Qt versions.

  • tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: Ditto.
04:41 Changeset [107220] by apavlov@chromium.org

Web Inspector: Update protocol and UI to follow bug 77204 (Kill per-Attribute style declarations)
https://bugs.webkit.org/show_bug.cgi?id=77962

Reviewed by Pavel Feldman.

Source/WebCore:

  • English.lproj/localizedStrings.js:
  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getInlineStylesForNode):
(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel.prototype.getInlineStylesAsync):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate.inlineCallback):
(WebInspector.StylesSidebarPane.prototype._rebuildStyleRules):
(WebInspector.StylesSidebarPane.prototype._rebuildStyleRules.get continue):

LayoutTests:

  • inspector/elements/elements-panel-styles-expected.txt:
  • inspector/styles/styles-computed-trace-expected.txt:
  • inspector/styles/styles-new-API-expected.txt:
  • inspector/styles/styles-new-API.html:
04:33 Changeset [107219] by zimmermann@webkit.org

2012-02-09 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Add missing Mac/Lion result.

  • platform/mac/svg/carto.net/scrollbar-expected.png: Added.
  • svg/custom/glyph-selection-bidi-mirror-expected.txt:
04:26 Changeset [107218] by zimmermann@webkit.org

2012-02-09 Nikolas Zimmermann <nzimmermann@rim.com>

Switch svg/custom tests to repaint harness
https://bugs.webkit.org/show_bug.cgi?id=78115

Not reviewed. Fix last minute typo, in nested-embedded-svg-size-changes.html, that may lead to flakiness.

  • svg/as-object/nested-embedded-svg-size-changes.html:
04:24 Changeset [107217] by pfeldman@chromium.org

Web Inspector: toggle Edit as HTML on F2, drag nodes up / down upon Ctrl(Cmd) Up / Down.
https://bugs.webkit.org/show_bug.cgi?id=78123

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • English.lproj/localizedStrings.js:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::SetOuterHTMLAction::SetOuterHTMLAction):
(WebCore::InspectorDOMAgent::SetOuterHTMLAction::undo):
(InspectorDOMAgent::SetOuterHTMLAction):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype._registerShortcuts):
(WebInspector.ElementsPanel.prototype.handleShortcut):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype._ondragstart):
(WebInspector.ElementsTreeOutline.prototype._ondragover):
(WebInspector.ElementsTreeOutline.prototype._doMove):
(WebInspector.ElementsTreeOutline.prototype._ondragend):
(WebInspector.ElementsTreeOutline.prototype._populateContextMenu):
(WebInspector.ElementsTreeOutline.prototype.handleShortcut):
(WebInspector.ElementsTreeOutline.prototype._toggleEditAsHTML):
(WebInspector.ElementsTreeOutline.prototype._selectNodeAfterEdit):
(WebInspector.ElementsTreeElement.prototype._startEditingAsHTML.commit):
(WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.changeTagNameCallback):
(WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted):

  • inspector/front-end/UIUtils.js:

LayoutTests:

  • inspector/elements/move-node.html:
  • inspector/elements/undo-dom-edits-expected.txt:
  • inspector/elements/undo-dom-edits.html:
04:02 Changeset [107216] by zimmermann@webkit.org

2012-02-09 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Rebaseline some Qt svg results.

  • platform/qt/svg/custom/absolute-sized-content-with-resources-expected.txt:
  • platform/qt/svg/custom/foreignObject-crash-on-hover-expected.txt:
  • platform/qt/svg/custom/hit-test-unclosed-subpaths-expected.txt:
  • platform/qt/svg/custom/js-update-bounce-expected.txt:
  • platform/qt/svg/custom/js-update-stop-linked-gradient-expected.txt:
  • platform/qt/svg/custom/js-update-style-expected.txt:
  • platform/qt/svg/custom/mask-invalidation-expected.txt:
  • platform/qt/svg/custom/relative-sized-content-with-resources-expected.txt:
  • platform/qt/svg/custom/text-repaint-including-stroke-expected.txt:
  • platform/qt/svg/custom/use-clipped-hit-expected.txt:
03:58 Changeset [107215] by bashi@chromium.org

Unreviewed test expectation update.

  • platform/chromium-linux/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/layout-width-change-expected.png: Renamed from LayoutTests/platform/chromium/platform/chromium/compositing/layout-width-change-expected.png.
03:56 Changeset [107214] by rolandsteiner@chromium.org

2012-02-09 Roland Steiner <rolandsteiner@chromium.org>

SelectorChecker::checkSelector: move parameters into a struct
https://bugs.webkit.org/show_bug.cgi?id=77525

Added 'SelectorCheckingContext' struct to hold parameters for the function.
Adapted calling sites.
(fixing change log after the commit message got bungled up).

Reviewed by Antti Koivisto.

No new tests. (refactoring)

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkSelector):
  • css/SelectorChecker.cpp: (WebCore::SelectorChecker::checkSelector): (WebCore): (WebCore::SelectorChecker::checkOneSelector):
  • css/SelectorChecker.h: (SelectorCheckingContext): (WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext): (SelectorChecker):
03:44 Changeset [107213] by zimmermann@webkit.org

[Qt] REGRESSION(r106918): It made svg/as-object/nested-embedded-svg-size-changes.html fail in debug mode
https://bugs.webkit.org/show_bug.cgi?id=78026

[Chromium] Layout Test svg/as-object/nested-embedded-svg-size-changes.html times out
https://bugs.webkit.org/show_bug.cgi?id=77183

Reviewed by Andreas Kling.

Rework testcases, to wait for the embedded SVG of the embedded HTML that we're loading.
Should fix the flakiness for both Qt/Chromium.

  • platform/qt/Skipped: Unskip test.
  • svg/as-object/nested-embedded-svg-size-changes.html: Wait for the embedded SVG to load, before trying to access it.
  • svg/as-object/resources/nested-embedded-svg-size-changes-target.html:
03:44 Changeset [107212] by rolandsteiner@chromium.org

Fix mirroring with SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=77067

Patch by Philip Rogers <pdr@google.com> on 2012-02-09
Reviewed by Nikolas Zimmermann.

SVG fonts were incorrectly handling mirrored characters in bidi text.
In this change I added the function createStringWithMirroredCharacters
which handles mirroring the characters when selecting glyphs for SVG
fonts. I also made a small cosmetic change in the function
charactersWithArabicForm, changing the bool parameter "mirror" to "rtl"
which better reflects what it actually does.

Several new tests were added to test mirroring with SVG fonts in the
presence of Arabic forms and non-BMP characters.

Tests: svg/custom/glyph-selection-arabic-forms.svg

svg/custom/glyph-selection-bidi-mirror.svg
svg/custom/glyph-selection-non-bmp.svg

  • platform/graphics/SVGGlyph.cpp:

(WebCore::charactersWithArabicForm):

  • svg/SVGFontData.cpp:

(WebCore::SVGFontData::applySVGGlyphSelection):
(WebCore::SVGFontData::createStringWithMirroredCharacters):

  • svg/SVGFontData.h:

(SVGFontData):

03:40 Changeset [107211] by zimmermann@webkit.org

2012-02-09 Philip Rogers <pdr@google.com>

Fix mirroring with SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=77067

Reviewed by Nikolas Zimmermann.

SVG fonts were incorrectly handling mirrored characters in bidi text.
In this change I added the function createStringWithMirroredCharacters
which handles mirroring the characters when selecting glyphs for SVG
fonts. I also made a small cosmetic change in the function
charactersWithArabicForm, changing the bool parameter "mirror" to "rtl"
which better reflects what it actually does.

Several new tests were added to test mirroring with SVG fonts in the
presence of Arabic forms and non-BMP characters.

  • platform/gtk/test_expectations.txt:
  • platform/win/test_expectations.txt:
  • svg/custom/glyph-selection-arabic-forms-expected.txt: Added.
  • svg/custom/glyph-selection-arabic-forms.svg: Added.
  • svg/custom/glyph-selection-bidi-mirror-expected.txt: Added.
  • svg/custom/glyph-selection-bidi-mirror.svg: Added.
  • svg/custom/glyph-selection-non-bmp-expected.png: Added.
  • svg/custom/glyph-selection-non-bmp-expected.txt: Added.
  • svg/custom/glyph-selection-non-bmp.svg: Added.

2012-02-09 Philip Rogers <pdr@google.com>

Fix mirroring with SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=77067

Reviewed by Nikolas Zimmermann.

SVG fonts were incorrectly handling mirrored characters in bidi text.
In this change I added the function createStringWithMirroredCharacters
which handles mirroring the characters when selecting glyphs for SVG
fonts. I also made a small cosmetic change in the function
charactersWithArabicForm, changing the bool parameter "mirror" to "rtl"
which better reflects what it actually does.

Several new tests were added to test mirroring with SVG fonts in the
presence of Arabic forms and non-BMP characters.

Tests: svg/custom/glyph-selection-arabic-forms.svg

svg/custom/glyph-selection-bidi-mirror.svg
svg/custom/glyph-selection-non-bmp.svg

  • platform/graphics/SVGGlyph.cpp: (WebCore::charactersWithArabicForm):
  • svg/SVGFontData.cpp: (WebCore::SVGFontData::applySVGGlyphSelection): (WebCore::SVGFontData::createStringWithMirroredCharacters):
  • svg/SVGFontData.h: (SVGFontData):
03:37 Changeset [107210] by philn@webkit.org

Unreviewed, GTK rebaseline after r107207.

  • platform/gtk/svg/custom/absolute-sized-content-with-resources-expected.txt:
  • platform/gtk/svg/custom/foreignObject-crash-on-hover-expected.txt:
  • platform/gtk/svg/custom/hit-test-unclosed-subpaths-expected.txt:
  • platform/gtk/svg/custom/js-update-bounce-expected.txt:
  • platform/gtk/svg/custom/js-update-stop-linked-gradient-expected.txt:
  • platform/gtk/svg/custom/js-update-style-expected.txt:
  • platform/gtk/svg/custom/mask-invalidation-expected.txt:
  • platform/gtk/svg/custom/relative-sized-content-with-resources-expected.txt:
  • platform/gtk/svg/custom/text-repaint-including-stroke-expected.txt:
  • platform/gtk/svg/custom/use-clipped-hit-expected.txt:
03:28 Changeset [107209] by vsevik@chromium.org

Web Inspector: Scripts navigator fails to reopen previously closed script.
https://bugs.webkit.org/show_bug.cgi?id=78212

Reviewed by Pavel Feldman.

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._reset):
(WebInspector.ScriptsPanel.prototype._showFile):
(WebInspector.ScriptsPanel.prototype._editorClosed):

  • inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer.prototype._tabClosed):

03:21 Changeset [107208] by commit-queue@webkit.org

ASSERT_NO_EXCEPTION should be initialized with non-zero value.
https://bugs.webkit.org/show_bug.cgi?id=78194

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-09
Reviewed by Hajime Morita.

ExceptionCode should not be checked without initializing it.
However, we encountered a bug that breaks this rule.
It was missed until now because ExceptionCode is sometimes set to 0 even if it is not initialized.
This patch ensures it is initialized as non-zero value.

No new tests, no change in behavior.

  • dom/ExceptionCodePlaceholder.cpp:

(WebCore::NoExceptionAssertionChecker::NoExceptionAssertionChecker):
(WebCore::NoExceptionAssertionChecker::~NoExceptionAssertionChecker):

  • dom/ExceptionCodePlaceholder.h:

(NoExceptionAssertionChecker):

03:21 Changeset [107207] by zimmermann@webkit.org

Switch svg/custom tests to repaint harness
https://bugs.webkit.org/show_bug.cgi?id=78115

Reviewed by Andreas Kling.

Make all tests that exercise repainting use the fast/repaint/resources/repaint.js harness.

  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/custom/absolute-sized-content-with-resources-expected.png:
  • platform/mac/svg/custom/absolute-sized-content-with-resources-expected.txt:
  • platform/mac/svg/custom/animate-path-discrete-expected.png:
  • platform/mac/svg/custom/animate-path-morphing-expected.png:
  • platform/mac/svg/custom/animate-target-id-changed-expected.png:
  • platform/mac/svg/custom/animate-target-removed-from-document-expected.png:
  • platform/mac/svg/custom/circle-move-invalidation-expected.png:
  • platform/mac/svg/custom/clip-path-child-changes-expected.png:
  • platform/mac/svg/custom/clip-path-href-changes-expected.png:
  • platform/mac/svg/custom/clip-path-id-changes-expected.png:
  • platform/mac/svg/custom/clip-path-units-changes-expected.png:
  • platform/mac/svg/custom/deep-dynamic-updates-expected.png:
  • platform/mac/svg/custom/fill-opacity-update-expected.png:
  • platform/mac/svg/custom/foreignObject-crash-on-hover-expected.png:
  • platform/mac/svg/custom/foreignObject-crash-on-hover-expected.txt:
  • platform/mac/svg/custom/gradient-add-stops-expected.png:
  • platform/mac/svg/custom/gradient-stop-style-change-expected.png:
  • platform/mac/svg/custom/hit-test-unclosed-subpaths-expected.png:
  • platform/mac/svg/custom/hit-test-unclosed-subpaths-expected.txt:
  • platform/mac/svg/custom/hit-test-with-br-expected.png:
  • platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.png:
  • platform/mac/svg/custom/js-late-clipPath-creation-expected.png:
  • platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/mac/svg/custom/js-late-gradient-creation-expected.png:
  • platform/mac/svg/custom/js-late-marker-and-object-creation-expected.png:
  • platform/mac/svg/custom/js-late-marker-creation-expected.png:
  • platform/mac/svg/custom/js-late-mask-and-object-creation-expected.png:
  • platform/mac/svg/custom/js-late-mask-creation-expected.png:
  • platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/mac/svg/custom/js-late-pattern-creation-expected.png:
  • platform/mac/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png:
  • platform/mac/svg/custom/js-update-bounce-expected.png:
  • platform/mac/svg/custom/js-update-bounce-expected.txt:
  • platform/mac/svg/custom/js-update-container-expected.png:
  • platform/mac/svg/custom/js-update-container2-expected.png:
  • platform/mac/svg/custom/js-update-gradient-expected.png:
  • platform/mac/svg/custom/js-update-image-expected.png:
  • platform/mac/svg/custom/js-update-path-changes-expected.png:
  • platform/mac/svg/custom/js-update-path-removal-expected.png:
  • platform/mac/svg/custom/js-update-pattern-child-expected.png:
  • platform/mac/svg/custom/js-update-pattern-expected.png:
  • platform/mac/svg/custom/js-update-polygon-changes-expected.png:
  • platform/mac/svg/custom/js-update-polygon-removal-expected.png:
  • platform/mac/svg/custom/js-update-stop-expected.png:
  • platform/mac/svg/custom/js-update-stop-linked-gradient-expected.png:
  • platform/mac/svg/custom/js-update-stop-linked-gradient-expected.txt:
  • platform/mac/svg/custom/js-update-style-expected.png:
  • platform/mac/svg/custom/js-update-style-expected.txt:
  • platform/mac/svg/custom/js-update-transform-addition-expected.png:
  • platform/mac/svg/custom/js-update-transform-changes-expected.png:
  • platform/mac/svg/custom/marker-child-changes-css-expected.png:
  • platform/mac/svg/custom/marker-child-changes-expected.png:
  • platform/mac/svg/custom/marker-strokeWidth-changes-expected.png:
  • platform/mac/svg/custom/marker-viewBox-changes-expected.png:
  • platform/mac/svg/custom/mask-child-changes-expected.png:
  • platform/mac/svg/custom/mask-invalidation-expected.png:
  • platform/mac/svg/custom/mask-invalidation-expected.txt:
  • platform/mac/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png:
  • platform/mac/svg/custom/prevent-default-expected.png:
  • platform/mac/svg/custom/relative-sized-content-expected.png:
  • platform/mac/svg/custom/relative-sized-content-with-resources-expected.png:
  • platform/mac/svg/custom/relative-sized-content-with-resources-expected.txt:
  • platform/mac/svg/custom/relative-sized-deep-shadow-tree-content-expected.png:
  • platform/mac/svg/custom/relative-sized-image-expected.png:
  • platform/mac/svg/custom/relative-sized-inner-svg-expected.png:
  • platform/mac/svg/custom/relative-sized-shadow-tree-content-expected.png:
  • platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.png:
  • platform/mac/svg/custom/relative-sized-use-on-symbol-expected.png:
  • platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png:
  • platform/mac/svg/custom/repaint-moving-svg-and-div-expected.png:
  • platform/mac/svg/custom/repaint-on-image-bounds-change-expected.png:
  • platform/mac/svg/custom/resource-client-removal-expected.png:
  • platform/mac/svg/custom/resource-invalidate-on-target-update-expected.png:
  • platform/mac/svg/custom/scroll-hit-test-expected.png:
  • platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/mac/svg/custom/stroke-opacity-update-expected.png:
  • platform/mac/svg/custom/svg-absolute-children-expected.png:
  • platform/mac/svg/custom/text-dom-removal-expected.png:
  • platform/mac/svg/custom/text-repaint-including-stroke-expected.png:
  • platform/mac/svg/custom/text-repaint-including-stroke-expected.txt:
  • platform/mac/svg/custom/text-xy-updates-SVGList-expected.png:
  • platform/mac/svg/custom/use-clipped-hit-expected.png:
  • platform/mac/svg/custom/use-clipped-hit-expected.txt:
  • platform/mac/svg/custom/use-detach-expected.png:
  • platform/mac/svg/custom/use-disappears-after-style-update-expected.png:
  • platform/mac/svg/custom/use-elementInstance-event-target-expected.png:
  • platform/mac/svg/custom/use-elementInstance-methods-expected.png:
  • platform/mac/svg/custom/use-event-handler-on-referenced-element-expected.png:
  • platform/mac/svg/custom/use-event-handler-on-use-element-expected.png:
  • platform/mac/svg/custom/use-inherit-style-expected.png:
  • platform/mac/svg/custom/use-instanceRoot-as-event-target-expected.png: Removed.
  • platform/mac/svg/custom/use-instanceRoot-event-bubbling-expected.png:
  • platform/mac/svg/custom/use-instanceRoot-event-listeners-expected.png:
  • platform/mac/svg/custom/use-setAttribute-crash-expected.png:
  • svg/custom/absolute-sized-content-with-resources.xhtml:
  • svg/custom/animate-path-discrete.svg:
  • svg/custom/animate-path-morphing.svg:
  • svg/custom/animate-target-id-changed.svg:
  • svg/custom/animate-target-removed-from-document.svg:
  • svg/custom/circle-move-invalidation.svg:
  • svg/custom/clip-path-child-changes.svg:
  • svg/custom/clip-path-href-changes.svg:
  • svg/custom/clip-path-id-changes.svg:
  • svg/custom/clip-path-units-changes.svg:
  • svg/custom/deep-dynamic-updates.svg:
  • svg/custom/fill-opacity-update.svg:
  • svg/custom/foreignObject-crash-on-hover.xml:
  • svg/custom/gradient-add-stops.svg:
  • svg/custom/gradient-stop-style-change.svg:
  • svg/custom/hit-test-path-stroke.svg:
  • svg/custom/hit-test-path.svg:
  • svg/custom/hit-test-unclosed-subpaths.svg:
  • svg/custom/hit-test-with-br.xhtml:
  • svg/custom/js-late-clipPath-and-object-creation.svg:
  • svg/custom/js-late-clipPath-creation.svg:
  • svg/custom/js-late-gradient-and-object-creation.svg:
  • svg/custom/js-late-gradient-creation.svg:
  • svg/custom/js-late-marker-and-object-creation.svg:
  • svg/custom/js-late-marker-creation.svg:
  • svg/custom/js-late-mask-and-object-creation.svg:
  • svg/custom/js-late-mask-creation.svg:
  • svg/custom/js-late-pattern-and-object-creation.svg:
  • svg/custom/js-late-pattern-creation.svg:
  • svg/custom/js-repaint-rect-on-path-with-stroke.svg:
  • svg/custom/js-update-bounce.svg:
  • svg/custom/js-update-container.svg:
  • svg/custom/js-update-container2.svg:
  • svg/custom/js-update-gradient.svg:
  • svg/custom/js-update-image.svg:
  • svg/custom/js-update-path-changes.svg:
  • svg/custom/js-update-path-removal.svg:
  • svg/custom/js-update-pattern-child.svg:
  • svg/custom/js-update-pattern.svg:
  • svg/custom/js-update-polygon-changes.svg:
  • svg/custom/js-update-polygon-removal.svg:
  • svg/custom/js-update-stop-linked-gradient.svg:
  • svg/custom/js-update-stop.svg:
  • svg/custom/js-update-style.svg:
  • svg/custom/js-update-transform-addition.svg:
  • svg/custom/js-update-transform-changes.svg:
  • svg/custom/linking-a-03-b-all.svg:
  • svg/custom/linking-a-03-b-preserveAspectRatio.svg:
  • svg/custom/linking-a-03-b-transform.svg:
  • svg/custom/linking-a-03-b-viewBox-transform.svg:
  • svg/custom/linking-a-03-b-viewBox.svg:
  • svg/custom/linking-a-03-b-viewTarget.svg:
  • svg/custom/linking-a-03-b-zoomAndPan.svg:
  • svg/custom/marker-child-changes-css.svg:
  • svg/custom/marker-child-changes.svg:
  • svg/custom/marker-strokeWidth-changes.svg:
  • svg/custom/marker-viewBox-changes.svg:
  • svg/custom/mask-child-changes.svg:
  • svg/custom/mask-invalidation.svg:
  • svg/custom/object-sizing-no-width-height-change-content-box-size.xhtml:
  • svg/custom/pending-resource-after-removal-expected.png:
  • svg/custom/pending-resource-after-removal.xhtml:
  • svg/custom/pending-resource-leak-2.svg:
  • svg/custom/pending-resource-leak-3.svg:
  • svg/custom/prevent-default.svg:
  • svg/custom/relative-sized-content-with-resources.xhtml:
  • svg/custom/relative-sized-content.xhtml:
  • svg/custom/relative-sized-deep-shadow-tree-content.xhtml:
  • svg/custom/relative-sized-image.xhtml:
  • svg/custom/relative-sized-inner-svg.xhtml:
  • svg/custom/relative-sized-shadow-tree-content-with-symbol.xhtml:
  • svg/custom/relative-sized-shadow-tree-content.xhtml:
  • svg/custom/relative-sized-use-on-symbol.xhtml:
  • svg/custom/relative-sized-use-without-attributes-on-symbol.xhtml:
  • svg/custom/repaint-moving-svg-and-div.xhtml:
  • svg/custom/repaint-on-constant-size-change.svg:
  • svg/custom/repaint-on-image-bounds-change.svg:
  • svg/custom/repaint-shadow.svg:
  • svg/custom/repaint-stroke-width-changes.svg:
  • svg/custom/resource-client-removal.svg:
  • svg/custom/resource-invalidate-on-target-update.svg:
  • svg/custom/resources/use-instanceRoot-event-bubbling.js:

(repaintTest):

  • svg/custom/resources/use-instanceRoot-event-listeners.js:

(repaintTest):

  • svg/custom/scroll-hit-test.xhtml:
  • svg/custom/scroll-to-anchor-in-symbol.svg:
  • svg/custom/scrolling-embedded-svg-file-image-repaint-problem.html:
  • svg/custom/stroke-opacity-update.svg:
  • svg/custom/svg-absolute-children.svg:
  • svg/custom/svg-disallowed-in-dashboard-object.html:
  • svg/custom/svg-fonts-in-html-linebreaks.html:
  • svg/custom/text-dom-removal.svg:
  • svg/custom/text-repaint-including-stroke.svg:
  • svg/custom/text-xy-updates-SVGList.xhtml:
  • svg/custom/use-animation-in-fill.html:
  • svg/custom/use-clipped-hit.svg:
  • svg/custom/use-crash-in-non-wellformed-document.svg:
  • svg/custom/use-crash-when-href-change.svg:
  • svg/custom/use-detach.svg:
  • svg/custom/use-disappears-after-style-update.svg:
  • svg/custom/use-elementInstance-event-target.svg:
  • svg/custom/use-elementInstance-methods.svg:
  • svg/custom/use-event-handler-on-referenced-element.svg:
  • svg/custom/use-event-handler-on-use-element.svg:
  • svg/custom/use-inherit-style.svg:
  • svg/custom/use-instanceRoot-as-event-target.xhtml:
  • svg/custom/use-instanceRoot-event-bubbling.xhtml:
  • svg/custom/use-instanceRoot-event-listeners.xhtml:
  • svg/custom/use-multiple-on-nested-disallowed-font.html:
  • svg/custom/use-setAttribute-crash.svg:
02:28 Changeset [107206] by philn@webkit.org

Unreviewed, GTK baselines for new tests.

  • platform/gtk/fast/line-grid/line-grid-contains-value-expected.txt: Added.
  • platform/gtk/fast/line-grid/line-grid-into-columns-expected.txt: Added.
  • platform/gtk/svg/clip-path/clip-in-clip-expected.txt: Added.
  • platform/gtk/svg/clip-path/clip-path-tspan-and-stroke-expected.txt: Added.
  • platform/gtk/svg/clip-path/clipper-placement-issue-expected.txt: Added.
  • platform/gtk/svg/custom/use-disappears-after-style-update-expected.txt: Added.
  • platform/gtk/svg/filters/feImage-change-target-id-expected.txt: Added.
  • platform/gtk/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.txt: Added.
  • platform/gtk/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.txt: Added.
  • platform/gtk/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.txt: Added.
  • platform/gtk/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.txt: Added.
  • platform/gtk/svg/filters/feImage-late-indirect-update-expected.txt: Added.
  • platform/gtk/svg/filters/feImage-multiple-targets-id-change-expected.txt: Added.
  • platform/gtk/svg/filters/feImage-position-expected.txt: Added.
  • platform/gtk/svg/filters/feImage-remove-target-expected.txt: Added.
  • platform/gtk/svg/filters/feImage-subregions-expected.txt: Added.
  • platform/gtk/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.txt: Added.
  • platform/gtk/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.txt: Added.
  • platform/gtk/svg/filters/feImage-target-add-to-document-expected.txt: Added.
  • platform/gtk/svg/filters/feImage-target-attribute-change-expected.txt: Added.
  • platform/gtk/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.txt: Added.
  • platform/gtk/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.txt: Added.
  • platform/gtk/svg/filters/feImage-target-changes-id-expected.txt: Added.
  • platform/gtk/svg/filters/feImage-target-id-change-expected.txt: Added.
  • platform/gtk/svg/filters/feImage-target-inline-style-change-expected.txt: Added.
  • platform/gtk/svg/filters/feImage-target-property-change-expected.txt: Added.
  • platform/gtk/svg/filters/feImage-target-reappend-to-document-expected.txt: Added.
  • platform/gtk/svg/filters/feImage-target-remove-from-document-expected.txt: Added.
  • platform/gtk/svg/filters/feImage-target-style-change-expected.txt: Added.
  • platform/gtk/svg/filters/filter-placement-issue-expected.txt: Added.
  • platform/gtk/svg/stroke/zero-length-path-linecap-rendering-expected.txt: Added.
  • platform/gtk/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Added.
  • platform/gtk/svg/wicd/sizing-flakiness-expected.txt: Added.
02:21 Changeset [107205] by rolandsteiner@chromium.org

Unreviewed, rolling out r107197.
http://trac.webkit.org/changeset/107197
https://bugs.webkit.org/show_bug.cgi?id=77525

broke Chromium Linux

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::checkSelector):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkSelector):
(WebCore):
(WebCore::SelectorChecker::checkOneSelector):

  • css/SelectorChecker.h:
02:00 Changeset [107204] by haraken@chromium.org

Unreviewed, rolling out r107182, r107186, r107189, r107191,
and r107199.
http://trac.webkit.org/changeset/107182
http://trac.webkit.org/changeset/107186
http://trac.webkit.org/changeset/107189
http://trac.webkit.org/changeset/107191
http://trac.webkit.org/changeset/107199
https://bugs.webkit.org/show_bug.cgi?id=78200

Layout tests of JSC-related port are crashing

  • Modules/gamepad/GamepadList.idl:
  • Modules/intents/Intent.idl:
  • bindings/js/JSDOMBinding.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(GenerateParametersCheck):
(NativeToJSValue):
(GenerateConstructorDefinition):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateParametersCheck):
(GenerateImplementationIndexer):
(RequiresCustomSignature):
(NativeToJSValue):

  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSFloat64Array.cpp:

(WebCore::jsFloat64ArrayPrototypeFunctionFoo):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunction):
(WebCore::jsTestActiveDOMObjectPrototypeFunctionPostMessage):

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore::jsTestCustomNamedGetterPrototypeFunctionAnotherFunction):

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::jsTestEventTargetPrototypeFunctionItem):
(WebCore::jsTestEventTargetPrototypeFunctionDispatchEvent):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::constructJSTestInterface):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionSerializedValue):
(WebCore::jsTestObjPrototypeFunctionIdbKey):
(WebCore::jsTestObjPrototypeFunctionOptionsObject):
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod6):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod7):
(WebCore::jsTestObjConstructorFunctionClassMethodWithOptional):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod11):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod12):
(WebCore::jsTestObjPrototypeFunctionConvert1):
(WebCore::jsTestObjPrototypeFunctionConvert2):
(WebCore::jsTestObjPrototypeFunctionConvert3):
(WebCore::jsTestObjPrototypeFunctionConvert4):
(WebCore::jsTestObjPrototypeFunctionConvert5):
(WebCore::jsTestObjPrototypeFunctionStrictFunction):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):

  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:
  • bindings/scripts/test/TestInterface.idl:
  • bindings/scripts/test/TestNamedConstructor.idl:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayInternal::fooCallback):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectInternal::excitingFunctionCallback):
(WebCore::TestActiveDOMObjectInternal::postMessageCallback):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::TestCustomNamedGetterInternal::anotherFunctionCallback):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetInternal::itemCallback):
(WebCore::TestEventTargetInternal::dispatchEventCallback):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceInternal::supplementalMethod2Callback):
(WebCore::V8TestInterface::constructorCallback):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::TestMediaQueryListListenerInternal::methodCallback):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::voidMethodWithArgsCallback):
(WebCore::TestObjInternal::intMethodWithArgsCallback):
(WebCore::TestObjInternal::objMethodWithArgsCallback):
(WebCore::TestObjInternal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjInternal::idbKeyCallback):
(WebCore::TestObjInternal::optionsObjectCallback):
(WebCore::TestObjInternal::customArgsAndExceptionCallback):
(WebCore::TestObjInternal::methodWithOptionalArgCallback):
(WebCore::TestObjInternal::methodWithNonOptionalArgAndOptionalArgCallback):
(WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
(WebCore::TestObjInternal::methodWithNonCallbackArgAndCallbackArgCallback):
(WebCore::TestObjInternal::overloadedMethod1Callback):
(WebCore::TestObjInternal::overloadedMethod2Callback):
(WebCore::TestObjInternal::overloadedMethod3Callback):
(WebCore::TestObjInternal::overloadedMethod4Callback):
(WebCore::TestObjInternal::overloadedMethod6Callback):
(WebCore::TestObjInternal::overloadedMethod7Callback):
(WebCore::TestObjInternal::classMethodWithOptionalCallback):
(WebCore::TestObjInternal::overloadedMethod11Callback):
(WebCore::TestObjInternal::overloadedMethod12Callback):
(WebCore::TestObjInternal::enabledAtRuntimeMethod1Callback):
(WebCore::TestObjInternal::enabledAtRuntimeMethod2Callback):
(WebCore::TestObjInternal::convert1Callback):
(WebCore::TestObjInternal::convert2Callback):
(WebCore::TestObjInternal::convert3Callback):
(WebCore::TestObjInternal::convert4Callback):
(WebCore::TestObjInternal::convert5Callback):
(WebCore::TestObjInternal::strictFunctionCallback):
(WebCore):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):

  • bindings/v8/V8Binding.h:
  • bindings/v8/custom/V8BindingMacros.h:
  • css/CSSCharsetRule.idl:
  • css/CSSImportRule.idl:
  • css/CSSMediaRule.idl:
  • css/CSSPageRule.idl:
  • css/CSSPrimitiveValue.idl:
  • css/CSSRule.idl:
  • css/CSSRuleList.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSStyleRule.idl:
  • css/CSSStyleSheet.idl:
  • css/CSSValue.idl:
  • css/CSSValueList.idl:
  • css/MediaList.idl:
  • css/MediaQueryList.idl:
  • css/MediaQueryListListener.idl:
  • css/StyleMedia.idl:
  • css/StyleSheet.idl:
  • css/StyleSheetList.idl:
  • css/WebKitCSSKeyframesRule.idl:
  • css/WebKitCSSMatrix.idl:
  • dom/Attr.idl:
  • dom/CharacterData.idl:
  • dom/ClientRectList.idl:
  • dom/Clipboard.idl:
  • dom/CompositionEvent.idl:
  • dom/CustomEvent.idl:
  • dom/DOMImplementation.idl:
  • dom/DOMStringList.idl:
  • dom/DataTransferItem.idl:
  • dom/DataTransferItemList.idl:
  • dom/DeviceMotionEvent.idl:
  • dom/DeviceOrientationEvent.idl:
  • dom/Document.idl:
  • dom/DocumentType.idl:
  • dom/Element.idl:
  • dom/Entity.idl:
  • dom/Event.idl:
  • dom/HashChangeEvent.idl:
  • dom/KeyboardEvent.idl:
  • dom/MessageEvent.idl:
  • dom/MouseEvent.idl:
  • dom/MutationEvent.idl:
  • dom/MutationRecord.idl:
  • dom/NamedNodeMap.idl:
  • dom/Node.idl:
  • dom/NodeFilter.idl:
  • dom/NodeList.idl:
  • dom/Notation.idl:
  • dom/OverflowEvent.idl:
  • dom/ProcessingInstruction.idl:
  • dom/Range.idl:
  • dom/ShadowRoot.idl:
  • dom/Text.idl:
  • dom/TextEvent.idl:
  • dom/TouchEvent.idl:
  • dom/UIEvent.idl:
  • dom/WheelEvent.idl:
  • html/DOMFormData.idl:
  • html/DOMTokenList.idl:
  • html/DOMURL.idl:
  • html/HTMLAllCollection.idl:
  • html/HTMLAudioElement.idl:
  • html/HTMLCanvasElement.idl:
  • html/HTMLCollection.idl:
  • html/HTMLDocument.idl:
  • html/HTMLElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLOptionElement.idl:
  • html/HTMLOptionsCollection.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLTableElement.idl:
  • html/HTMLTableRowElement.idl:
  • html/HTMLTableSectionElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/TextTrackCue.idl:
  • html/canvas/CanvasGradient.idl:
  • html/canvas/CanvasRenderingContext2D.idl:
  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/OESVertexArrayObject.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • html/canvas/Uint8ClampedArray.idl:
  • html/canvas/WebGLDebugShaders.idl:
  • html/canvas/WebGLRenderingContext.idl:
  • page/Console.idl:
  • page/DOMSelection.idl:
  • page/DOMWindow.idl:
  • page/History.idl:
  • page/Location.idl:
  • plugins/DOMMimeTypeArray.idl:
  • plugins/DOMPlugin.idl:
  • plugins/DOMPluginArray.idl:
  • storage/IDBDatabase.idl:
  • storage/IDBObjectStore.idl:
  • storage/IDBRequest.idl:
  • storage/Storage.idl:
  • storage/StorageEvent.idl:
  • svg/ElementTimeControl.idl:
  • svg/SVGDocument.idl:
  • svg/SVGElementInstanceList.idl:
  • svg/SVGFEDropShadowElement.idl:
  • svg/SVGFEGaussianBlurElement.idl:
  • svg/SVGFEMorphologyElement.idl:
  • svg/SVGFilterElement.idl:
  • svg/SVGLocatable.idl:
  • svg/SVGMarkerElement.idl:
  • svg/SVGPathElement.idl:
  • svg/SVGSVGElement.idl:
  • svg/SVGStylable.idl:
  • svg/SVGTests.idl:
  • svg/SVGTextContentElement.idl:
  • webaudio/AudioNode.idl:
  • websockets/WebSocket.idl:
  • workers/SharedWorker.idl:
  • workers/WorkerContext.idl:
  • xml/DOMParser.idl:
  • xml/XMLHttpRequest.idl:
  • xml/XMLSerializer.idl:
  • xml/XPathEvaluator.idl:
  • xml/XPathExpression.idl:
  • xml/XPathNSResolver.idl:
  • xml/XPathResult.idl:
  • xml/XSLTProcessor.idl:
01:55 Changeset [107203] by podivilov@chromium.org

Unreviewed, add chromium expectations for new tests added in r107160.

  • platform/chromium-linux/fast/line-grid/line-grid-inside-columns-expected.png:
  • platform/chromium-linux/fast/line-grid/line-grid-into-columns-expected.png: Added.
  • platform/chromium-mac-leopard/fast/line-grid/line-grid-into-columns-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/line-grid/line-grid-into-columns-expected.png: Added.
  • platform/chromium-win/fast/line-grid/line-grid-inside-columns-expected.png:
  • platform/chromium-win/fast/line-grid/line-grid-inside-columns-expected.txt:
  • platform/chromium-win/fast/line-grid/line-grid-into-columns-expected.png: Added.
  • platform/chromium-win/fast/line-grid/line-grid-into-columns-expected.txt: Added.
01:54 Changeset [107202] by commit-queue@webkit.org

Disable adding a shadow root to elements having a dynamic built-in shadow root.
https://bugs.webkit.org/show_bug.cgi?id=77935

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-09
Reviewed by Hajime Morita.

Source/WebCore:

We temporarily disable adding a shadow root in elements having a dynamic user agent shadow root.
These shadow roots are currently created using Element::ensureShadowRoot.
So we don't check the condition if a shadow root is created eaither using Element::ensureShadowRoot
or ShadowRoot::CreatingUserAgentShadowRoot is specified for ShadowRoot::create.

Test: fast/dom/shadow/shadow-disable.html

  • dom/Element.cpp:

(WebCore::Element::ensureShadowRoot):

  • dom/ShadowRoot.cpp:

(WebCore::allowsUserShadowRoot):
(WebCore):
(WebCore::ShadowRoot::create):

  • dom/ShadowRoot.h:

(ShadowRoot):

  • html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::createShadowSubtree):

ShadowRoot::CreatingUserAgentShadowRoot is specified.

  • html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::HTMLKeygenElement): ditto.

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::createShadowSubtree): ditto.

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::createShadowSubtree): ditto.

  • html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::createShadowSubtree): ditto.

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::createShadowSubtree): ditto.

LayoutTests:

  • fast/dom/shadow/shadow-disable-expected.txt: Added.
  • fast/dom/shadow/shadow-disable.html: Added.
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
01:51 Changeset [107201] by apavlov@chromium.org

Web Inspector: hovering over element with :hover style halts inspector
https://bugs.webkit.org/show_bug.cgi?id=78086

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/styles/updates-throttled.html

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._innerUpdate.computedStyleCallback):
(WebInspector.StylesSidebarPane.prototype._innerUpdate):

LayoutTests:

  • inspector/styles/updates-throttled-expected.txt: Added.
  • inspector/styles/updates-throttled.html: Added.
01:50 Changeset [107200] by commit-queue@webkit.org

Improve http-equiv content-language parsing
https://bugs.webkit.org/show_bug.cgi?id=77724

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-02-09
Reviewed by Alexey Proskuryakov.

Add tests for mapping http-equiv content-language to -webkit-locale to cover dynamic changes to the meta
element and a comma-separated list of languages. The desired behavior of some of these is not yet decided, so
some of the tests currently fail and the expectations may change. See comments in bug and in the tests.

  • fast/text/content-language-comma-separated-list-expected.txt: Added.
  • fast/text/content-language-comma-separated-list.html: Added.
  • fast/text/content-language-dynamically-added-expected.txt: Added.
  • fast/text/content-language-dynamically-added.html: Added.
  • fast/text/content-language-dynamically-changed-expected.txt: Added.
  • fast/text/content-language-dynamically-changed.html: Added.
  • fast/text/content-language-dynamically-removed-expected.txt: Added.
  • fast/text/content-language-dynamically-removed.html: Added.
  • fast/text/content-language-multiple.html: Fix to actually test http-equiv content-language.
01:46 Changeset [107199] by haraken@chromium.org

Unreviewed. Fix build failure caused by r107191.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheck):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateParametersCheck):

01:42 Changeset [107198] by podivilov@chromium.org

2012-02-09 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, gardening, remove stale chromium expectations for synthetic-bold-transformed.

  • platform/chromium-linux/fast/text/synthetic-bold-transformed-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/synthetic-bold-transformed-expected.png: Removed.
  • platform/chromium-win/fast/text/synthetic-bold-transformed-expected.png: Removed.
01:36 Changeset [107197] by rolandsteiner@chromium.org

2012-02-09 Roland Steiner <rolandsteiner@chromium.org>

SelectorChecker::checkSelector: move parameters into a struct
https://bugs.webkit.org/show_bug.cgi?id=77525

Added 'SelectorCheckingContext' struct to hold parameters for the function.
Adapted calling sites.

Reviewed by Antti Koivisto.

No new tests. (refactoring)

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkSelector):
  • css/SelectorChecker.cpp: (WebCore::SelectorChecker::checkSelector): (WebCore): (WebCore::SelectorChecker::checkOneSelector):
  • css/SelectorChecker.h: (SelectorCheckingContext): (WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext): (SelectorChecker):
01:33 Changeset [107196] by tkent@chromium.org

Do not localize numbers in scientific notation
https://bugs.webkit.org/show_bug.cgi?id=78208

Reviewed by Hajime Morita.

.:

  • ManualTests/input-number-localization.html: Updated for scientific notation.

Source/WebCore:

For a preparation of fixing http://wkb.ug/62939, we stop supporting
localized numbers in scientific notation in <input type=number>.

We're going to change number localization processing so that it replaces
letters one by one. It will be very hard to support scientific notation.

  • html/NumberInputType.cpp:

(WebCore::isE): A helper functio for String::find() to detect scientific notation.
(WebCore::NumberInputType::visibleValue): Avoid localization for scientific notation.
(WebCore::NumberInputType::convertFromVisibleValue): ditto.
(WebCore::NumberInputType::isAcceptableValue):
Use convertFromVisibleValue, also stop accepting a standard format as a fallback.

01:18 Changeset [107195] by rniwa@webkit.org

kill-old-processes should kill gcc and clang
https://bugs.webkit.org/show_bug.cgi?id=78189

Reviewed by Eric Seidel.

Added a bunch of processes names of gcc and clang to the list.

  • BuildSlaveSupport/kill-old-processes:
01:05 Changeset [107194] by leo.yang@torchmobile.com.cn

EntryBase.cpp is missing in CMake build system when turning on ENABLE_FILE_SYSTEM
https://bugs.webkit.org/show_bug.cgi?id=78190

Reviewed by Antonio Gomes.

EntryBase.cpp is not in the CMake build system, which causes build failure (undefined
symbols to EntryBase) when turning on ENABLE_FILE_SYSTEM.

Build system fix, no new tests.

  • CMakeLists.txt:
01:03 Changeset [107193] by kling@webkit.org

REGRESSION(r53878): Input elements don't share their styles if the document contains no validity style rules.
<http://webkit.org/b/69400>

Reviewed by Kent Tamura.

Don't reject style sharing candidates prematurely just because the document doesn't
have any :valid or :invalid selectors.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithControl):

01:03 Changeset [107192] by mikelawther@chromium.org

Unreviewed test_expectations change.

[chromium] remove expectation for css3/calc/block-mask-overlay-image-outset.html
https://bugs.webkit.org/show_bug.cgi?id=78183

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=css3%2Fcalc%2Fblock-mask-overlay
shows this test has not failed as far back as its history is recorded.

  • platform/chromium/test_expectations.txt:
00:55 Changeset [107191] by haraken@chromium.org

Unreviewed. Fixed typo in the following files. [TreatUndefinedAs] => [TreatAsUndefined].

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheck):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated run-bindings-tests results.

(WebDOMTestObj::methodWithOptionalIsUndefinedString):

  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_method_with_optional_is_undefined_string):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalIsUndefinedString):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalIsNullStringString):
(WebCore::jsTestObjPrototypeFunctionConvert5):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj methodWithOptionalIsUndefinedString:]):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::methodWithOptionalIsUndefinedStringCallback):
(WebCore):

00:50 Changeset [107190] by gyuyoung.kim@samsung.com

[CMAKE] Change lowercase variable with uppercase's.
https://bugs.webkit.org/show_bug.cgi?id=78198

Reviewed by Daniel Bates.

CMake variable is only written by uppercase.

  • CMakeLists.txt:
00:31 SettingUpDevelopmentEnvironmentForN9 edited by zarvai@inf.u-szeged.hu
(diff)
00:28 SettingUpDevelopmentEnvironmentForN9 edited by zarvai@inf.u-szeged.hu
(diff)
00:25 SettingUpDevelopmentEnvironmentForN9 edited by zarvai@inf.u-szeged.hu
(diff)
00:16 Changeset [107189] by haraken@chromium.org

Unreviewed. Fixed typo in the following files. [TreatReturnedNullStringTo=] => [TreatReturnedNullStringAs=].

  • bindings/scripts/test/TestObj.idl:
  • css/CSSCharsetRule.idl:
  • css/CSSImportRule.idl:
  • css/CSSPageRule.idl:
  • css/CSSRule.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSStyleRule.idl:
  • css/CSSValue.idl:
  • css/MediaList.idl:
  • css/StyleSheet.idl:
  • css/WebKitCSSKeyframesRule.idl:
  • dom/Attr.idl:
  • dom/CharacterData.idl:
  • dom/Clipboard.idl:
  • dom/DOMStringList.idl:
  • dom/Document.idl:
  • dom/DocumentType.idl:
  • dom/Element.idl:
  • dom/Entity.idl:
  • dom/MutationRecord.idl:
  • dom/Node.idl:
  • dom/Notation.idl:
  • dom/ProcessingInstruction.idl:
  • html/DOMTokenList.idl:
  • html/DOMURL.idl:
  • html/HTMLMediaElement.idl:
  • html/canvas/WebGLDebugShaders.idl:
  • html/canvas/WebGLRenderingContext.idl:
  • page/DOMWindow.idl:
  • storage/IDBObjectStore.idl:
  • storage/IDBRequest.idl:
  • storage/Storage.idl:
  • storage/StorageEvent.idl:
  • websockets/WebSocket.idl:
  • xml/XMLHttpRequest.idl:
  • xml/XPathNSResolver.idl:
  • xml/XSLTProcessor.idl:

02/08/12:

23:58 Changeset [107188] by philn@webkit.org

Unreviewed, GTK rebaseline.

  • platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt:
  • platform/gtk/fast/forms/select-overflow-scroll-expected.txt:
  • platform/gtk/fast/forms/select-overflow-scroll-inherited-expected.txt:
  • platform/gtk/fast/line-grid/line-grid-inside-columns-expected.txt:
23:52 Changeset [107187] by commit-queue@webkit.org

Fix a typo for r107125
https://bugs.webkit.org/show_bug.cgi?id=77804

Patch by Raymond Liu <raymond.liu@intel.com> on 2012-02-08
Reviewed by James Robinson.

  • tests/WebCompositorInputHandlerImplTest.cpp:
23:20 Changeset [107186] by haraken@chromium.org

Rename [ConvertNullStringTo=] to [TreatReturnedNullStringAs=]
https://bugs.webkit.org/show_bug.cgi?id=78108

Reviewed by Adam Barth.

[ConvertNullStringTo=] is not descriptive. To clarify that it specifies
the behavior when the null string is returned by WebCore, this patch renames
[ConvertNullStringTo=] to [TreatReturnedNullStringAs=]. This change is also
for naming consistency with [TreatNullAs] and [TreatUndefinedAs].

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(NativeToJSValue):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementationIndexer):
(NativeToJSValue):

  • bindings/scripts/test/TestObj.idl: No change in run-bindings-tests results.
  • css/CSSCharsetRule.idl:
  • css/CSSImportRule.idl:
  • css/CSSPageRule.idl:
  • css/CSSRule.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSStyleRule.idl:
  • css/CSSValue.idl:
  • css/MediaList.idl:
  • css/StyleSheet.idl:
  • css/WebKitCSSKeyframesRule.idl:
  • dom/Attr.idl:
  • dom/CharacterData.idl:
  • dom/Clipboard.idl:
  • dom/DOMStringList.idl:
  • dom/Document.idl:
  • dom/DocumentType.idl:
  • dom/Element.idl:
  • dom/Entity.idl:
  • dom/MutationRecord.idl:
  • dom/Node.idl:
  • dom/Notation.idl:
  • dom/ProcessingInstruction.idl:
  • html/DOMTokenList.idl:
  • html/DOMURL.idl:
  • html/HTMLMediaElement.idl:
  • html/canvas/WebGLDebugShaders.idl:
  • html/canvas/WebGLRenderingContext.idl:
  • page/DOMWindow.idl:
  • storage/IDBObjectStore.idl:
  • storage/IDBRequest.idl:
  • storage/Storage.idl:
  • storage/StorageEvent.idl:
  • websockets/WebSocket.idl:
  • xml/XMLHttpRequest.idl:
  • xml/XPathNSResolver.idl:
  • xml/XSLTProcessor.idl:
23:14 Changeset [107185] by kling@webkit.org

Simplify ownership of StyledElement::additionalAttributeStyles().
<http://webkit.org/b/78204>

Reviewed by Anders Carlsson.

Change additionalAttributeStyle() to return a raw pointer rather than a PassRefPtr.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::matchAllRules):
(WebCore::CSSStyleSelector::canShareStyleWithElement):

  • dom/StyledElement.h:

(WebCore::StyledElement::additionalAttributeStyle):

  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::additionalAttributeStyle):

  • html/HTMLTableCellElement.h:

(HTMLTableCellElement):

  • html/HTMLTableColElement.cpp:

(WebCore::HTMLTableColElement::additionalAttributeStyle):

  • html/HTMLTableColElement.h:

(HTMLTableColElement):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::additionalAttributeStyle):
(WebCore::HTMLTableElement::additionalCellStyle):
(WebCore::HTMLTableElement::additionalGroupStyle):

  • html/HTMLTableElement.h:

(HTMLTableElement):

  • html/HTMLTableSectionElement.cpp:

(WebCore::HTMLTableSectionElement::additionalAttributeStyle):

  • html/HTMLTableSectionElement.h:

(HTMLTableSectionElement):

23:14 Changeset [107184] by commit-queue@webkit.org

[PerformanceTests] sunspider-crypto-md5.html and sunspider-crypto-sha1.html are timing out on cr-mac perf bot
https://bugs.webkit.org/show_bug.cgi?id=78174

Patch by Hajime Morrita <morrita@chromium.org> on 2012-02-08
Reviewed by Ryosuke Niwa.

Pulled back removed files.

  • Dromaeo/resources/dromaeo/web/tests/sunspider-crypto-md5.html: Added.
  • Dromaeo/resources/dromaeo/web/tests/sunspider-crypto-sha1.html: Added.
23:02 Changeset [107183] by commit-queue@webkit.org

[BlackBerry] Upstream BlackBerry WebCoreSupport FrameNetworkingContextBlackBerry and IconDatabaseClientBlackBerry classes
https://bugs.webkit.org/show_bug.cgi?id=78049

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-02-08
Reviewed by Rob Buis.

Initial upstream, no new tests.

  • blackberry/WebCoreSupport/FrameNetworkingContextBlackBerry.cpp: Added.
  • blackberry/WebCoreSupport/FrameNetworkingContextBlackBerry.h: Added.
  • blackberry/WebCoreSupport/IconDatabaseClientBlackBerry.cpp: Added.
  • blackberry/WebCoreSupport/IconDatabaseClientBlackBerry.h: Added.
22:58 Changeset [107182] by haraken@chromium.org

Rename [Optional=CallWithDefalutValue] and [Optional=CallWithNullValue]
https://bugs.webkit.org/show_bug.cgi?id=78200

Reviewed by Adam Barth.

[Optional=CallWithDefalutValue] and [Optional=CallWithNullValue] are confusing.

  • [Optional=CallWithDefalutValue] indicates that a missing value should be treated

as if the JavaScript undefined is passed.

  • [Optional=CallWithNullValue] indicates that a missing value should be treated as

the WebKit null value (i.e. JSValue() or v8::Local<v8::Value>()).

  • Actually, the difference between [Optional=CallWithDefalutValue] and

[Optional=CallWithNullValue] appears only when the type of the missing value is DOMString.
In case of [Optional=CallWithDefalutValue], the missing value is converted to the string
"undefined". On the other hand, in case of [Optional=CallWithNullValue], the missing
value is converted to the WebKit null string.

With these observations, this patch renames them as follows:

  • Rename [Optional=CallWithDefalutValue] to [Optional=TreatAsUndefined].
  • Remove [Optional=CallWithNullValue]. Instead, we use

[Optional=TreatAsUndefined, TreatUndefinedAs=NullString].

Test: bindings/scripts/test/TestInterface.idl

  • bindings/js/JSDOMBinding.h: Renamed MissingIsUndefined to MissingIsUndefinedValue,

renamed MissingIsEmpty to MissingIsNullValue.

  • bindings/v8/V8Binding.h: Ditto.
  • bindings/v8/custom/V8BindingMacros.h: Ditto.
  • bindings/scripts/CodeGeneratorJS.pm: Modified to support the IDL attribute renaming.

(GenerateParametersCheck):
(GenerateConstructorDefinition):

  • bindings/scripts/CodeGeneratorV8.pm: Ditto.

(GenerateParametersCheck):
(RequiresCustomSignature):

  • Modules/gamepad/GamepadList.idl: Renamed IDL attributes as described above.
  • Modules/intents/Intent.idl:
  • css/CSSMediaRule.idl:
  • css/CSSPrimitiveValue.idl:
  • css/CSSRuleList.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSStyleSheet.idl:
  • css/CSSValueList.idl:
  • css/MediaList.idl:
  • css/MediaQueryList.idl:
  • css/MediaQueryListListener.idl:
  • css/StyleMedia.idl:
  • css/StyleSheetList.idl:
  • css/WebKitCSSKeyframesRule.idl:
  • css/WebKitCSSMatrix.idl:
  • dom/CharacterData.idl:
  • dom/ClientRectList.idl:
  • dom/CompositionEvent.idl:
  • dom/CustomEvent.idl:
  • dom/DOMImplementation.idl:
  • dom/DOMStringList.idl:
  • dom/DataTransferItem.idl:
  • dom/DataTransferItemList.idl:
  • dom/DeviceMotionEvent.idl:
  • dom/DeviceOrientationEvent.idl:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/Event.idl:
  • dom/HashChangeEvent.idl:
  • dom/KeyboardEvent.idl:
  • dom/MessageEvent.idl:
  • dom/MouseEvent.idl:
  • dom/MutationEvent.idl:
  • dom/NamedNodeMap.idl:
  • dom/Node.idl:
  • dom/NodeFilter.idl:
  • dom/NodeList.idl:
  • dom/OverflowEvent.idl:
  • dom/Range.idl:
  • dom/ShadowRoot.idl:
  • dom/Text.idl:
  • dom/TextEvent.idl:
  • dom/TouchEvent.idl:
  • dom/UIEvent.idl:
  • dom/WheelEvent.idl:
  • html/DOMFormData.idl:
  • html/HTMLAllCollection.idl:
  • html/HTMLAudioElement.idl:
  • html/HTMLCanvasElement.idl:
  • html/HTMLCollection.idl:
  • html/HTMLDocument.idl:
  • html/HTMLElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLOptionElement.idl:
  • html/HTMLOptionsCollection.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLTableElement.idl:
  • html/HTMLTableRowElement.idl:
  • html/HTMLTableSectionElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/TextTrackCue.idl:
  • html/canvas/CanvasGradient.idl:
  • html/canvas/CanvasRenderingContext2D.idl:
  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/OESVertexArrayObject.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • html/canvas/Uint8ClampedArray.idl:
  • page/Console.idl:
  • page/DOMSelection.idl:
  • page/DOMWindow.idl:
  • page/History.idl:
  • page/Location.idl:
  • plugins/DOMMimeTypeArray.idl:
  • plugins/DOMPlugin.idl:
  • plugins/DOMPluginArray.idl:
  • storage/IDBDatabase.idl:
  • storage/StorageEvent.idl:
  • svg/ElementTimeControl.idl:
  • svg/SVGDocument.idl:
  • svg/SVGElementInstanceList.idl:
  • svg/SVGFEDropShadowElement.idl:
  • svg/SVGFEGaussianBlurElement.idl:
  • svg/SVGFEMorphologyElement.idl:
  • svg/SVGFilterElement.idl:
  • svg/SVGLocatable.idl:
  • svg/SVGMarkerElement.idl:
  • svg/SVGPathElement.idl:
  • svg/SVGSVGElement.idl:
  • svg/SVGStylable.idl:
  • svg/SVGTests.idl:
  • svg/SVGTextContentElement.idl:
  • webaudio/AudioNode.idl:
  • workers/SharedWorker.idl:
  • workers/WorkerContext.idl:
  • xml/DOMParser.idl:
  • xml/XMLSerializer.idl:
  • xml/XPathEvaluator.idl:
  • xml/XPathExpression.idl:
  • xml/XPathNSResolver.idl:
  • xml/XPathResult.idl:
  • bindings/scripts/test/TestInterface.idl: Added test cases for [Optional],

[Optional=TreatAsUndefined] and [Optional=TreatAsUndefined, TreatUndefinedAs=NullString]

  • bindings/scripts/test/TestNamedConstructor.idl: Renamed IDL attributes as described above.
  • bindings/scripts/test/TestObj.idl: Ditto.
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated run-bindings-tests results.

(WebDOMTestObj::methodWithOptionalString):
(WebDOMTestObj::methodWithOptionalIsTreatAsUndefinedString):
(WebDOMTestObj::methodWithOptionalIsNullStringString):

  • bindings/scripts/test/CPP/WebDOMTestObj.h: Ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.

(webkit_dom_test_obj_method_with_optional_string):
(webkit_dom_test_obj_method_with_optional_is_treat_as_undefined_string):
(webkit_dom_test_obj_method_with_optional_is_null_string_string):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
  • bindings/scripts/test/JS/JSFloat64Array.cpp: Ditto.

(WebCore::jsFloat64ArrayPrototypeFunctionFoo):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp: Ditto.

(WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunction):
(WebCore::jsTestActiveDOMObjectPrototypeFunctionPostMessage):

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp: Ditto.

(WebCore::jsTestCustomNamedGetterPrototypeFunctionAnotherFunction):

  • bindings/scripts/test/JS/JSTestEventTarget.cpp: Ditto.

(WebCore::jsTestEventTargetPrototypeFunctionItem):
(WebCore::jsTestEventTargetPrototypeFunctionDispatchEvent):

  • bindings/scripts/test/JS/JSTestInterface.cpp: Ditto.

(WebCore::JSTestInterfaceConstructor::constructJSTestInterface):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: Ditto.

(WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp: Ditto.

(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):

  • bindings/scripts/test/JS/JSTestObj.cpp: Ditto.

(WebCore):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionSerializedValue):
(WebCore::jsTestObjPrototypeFunctionIdbKey):
(WebCore::jsTestObjPrototypeFunctionOptionsObject):
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalString):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalIsTreatAsUndefinedString):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalIsNullStringString):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod6):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod7):
(WebCore::jsTestObjConstructorFunctionClassMethodWithOptional):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod11):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod12):
(WebCore::jsTestObjPrototypeFunctionConvert1):
(WebCore::jsTestObjPrototypeFunctionConvert2):
(WebCore::jsTestObjPrototypeFunctionConvert3):
(WebCore::jsTestObjPrototypeFunctionConvert4):
(WebCore::jsTestObjPrototypeFunctionConvert5):
(WebCore::jsTestObjPrototypeFunctionStrictFunction):

  • bindings/scripts/test/JS/JSTestObj.h: Ditto.

(WebCore):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Ditto.

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):

  • bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.

(-[DOMTestObj methodWithOptionalString:]):
(-[DOMTestObj methodWithOptionalIsTreatAsUndefinedString:]):
(-[DOMTestObj methodWithOptionalIsNullStringString:]):

  • bindings/scripts/test/V8/V8Float64Array.cpp: Ditto.

(WebCore::Float64ArrayInternal::fooCallback):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp: Ditto.

(WebCore::TestActiveDOMObjectInternal::excitingFunctionCallback):
(WebCore::TestActiveDOMObjectInternal::postMessageCallback):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp: Ditto.

(WebCore::TestCustomNamedGetterInternal::anotherFunctionCallback):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp: Ditto.

(WebCore::TestEventTargetInternal::itemCallback):
(WebCore::TestEventTargetInternal::dispatchEventCallback):

  • bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.

(WebCore::TestInterfaceInternal::supplementalMethod2Callback):
(WebCore::V8TestInterface::constructorCallback):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp: Ditto.

(WebCore::TestMediaQueryListListenerInternal::methodCallback):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp: Ditto.

(WebCore::V8TestNamedConstructorConstructorCallback):

  • bindings/scripts/test/V8/V8TestObj.cpp: Ditto.

(WebCore::TestObjInternal::voidMethodWithArgsCallback):
(WebCore::TestObjInternal::intMethodWithArgsCallback):
(WebCore::TestObjInternal::objMethodWithArgsCallback):
(WebCore::TestObjInternal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjInternal::idbKeyCallback):
(WebCore::TestObjInternal::optionsObjectCallback):
(WebCore::TestObjInternal::customArgsAndExceptionCallback):
(WebCore::TestObjInternal::methodWithOptionalArgCallback):
(WebCore::TestObjInternal::methodWithNonOptionalArgAndOptionalArgCallback):
(WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
(WebCore::TestObjInternal::methodWithOptionalStringCallback):
(TestObjInternal):
(WebCore::TestObjInternal::methodWithOptionalIsTreatAsUndefinedStringCallback):
(WebCore::TestObjInternal::methodWithOptionalIsNullStringStringCallback):
(WebCore::TestObjInternal::methodWithNonCallbackArgAndCallbackArgCallback):
(WebCore::TestObjInternal::overloadedMethod1Callback):
(WebCore::TestObjInternal::overloadedMethod2Callback):
(WebCore::TestObjInternal::overloadedMethod3Callback):
(WebCore::TestObjInternal::overloadedMethod4Callback):
(WebCore::TestObjInternal::overloadedMethod6Callback):
(WebCore::TestObjInternal::overloadedMethod7Callback):
(WebCore::TestObjInternal::classMethodWithOptionalCallback):
(WebCore::TestObjInternal::overloadedMethod11Callback):
(WebCore::TestObjInternal::overloadedMethod12Callback):
(WebCore::TestObjInternal::enabledAtRuntimeMethod1Callback):
(WebCore::TestObjInternal::enabledAtRuntimeMethod2Callback):
(WebCore::TestObjInternal::convert1Callback):
(WebCore::TestObjInternal::convert2Callback):
(WebCore::TestObjInternal::convert3Callback):
(WebCore::TestObjInternal::convert4Callback):
(WebCore::TestObjInternal::convert5Callback):
(WebCore::TestObjInternal::strictFunctionCallback):
(WebCore):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp: Ditto.

(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):

22:43 Changeset [107181] by haraken@chromium.org

Rename [HasNumericIndexGetter] to [NumericIndexedGetter]
https://bugs.webkit.org/show_bug.cgi?id=78096

Reviewed by Adam Barth.

This patch renames [HasNumericIndexGetter] to [NumericIndexedGetter],
for naming consistency with [IndexedGetter] and [CustomIndexedGetter].

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateImplementationIndexer):

  • bindings/scripts/test/TestTypedArray.idl: No change in run-bindings-tests results.
  • html/canvas/CanvasPixelArray.idl:
  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • html/canvas/Uint8ClampedArray.idl:
22:12 Changeset [107180] by commit-queue@webkit.org

[WK2][EFL] creating dummy class derived from ResourceHandleClient for Efl download module.
https://bugs.webkit.org/show_bug.cgi?id=76171

Patch by Keunsoon Lee <keunsoon.lee@samsung.com> on 2012-02-08
Reviewed by Andreas Kling.

FileDownloaderEfl is a practical class to operate file download.
It communicates with Download class to start download
and to notify downloading states to user(e.g. client application).
Besides FileDownloaderEfl derives from ResourceHandleClient
and receives chunked data from ResourceHandle directly
or redirects data flow which is started from MainResourceLoader
by mean of exchanging ResourceHandle's existing client for FileDownloaderEfl.

This patch has only dummy functions to make easy to review.
Working patch will be uploaded on another bug thread.

  • PlatformEfl.cmake: added new file to compile.
  • WebProcess/Downloads/Download.h: added FileDownloaderEfl's instance as a form of OwnPtr<FileDownloaderEfl>.

(WebKit):
(Download):

  • WebProcess/Downloads/efl/DownloadEfl.cpp:

(WebKit::Download::start): calling to FileDownloaderEfl::start() to start download for passing ResourceRequest.

  • WebProcess/Downloads/efl/FileDownloaderEfl.cpp: Added. a practical class to operate file download.

(WebKit):
(WebKit::FileDownloaderEfl::create): create function, which returns PassOwnPtr<FileDownloaderEfl>.
(WebKit::FileDownloaderEfl::FileDownloaderEfl): constructor, which receives Download* as a parameter.
(WebKit::FileDownloaderEfl::~FileDownloaderEfl): deconstructor.
(WebKit::FileDownloaderEfl::start): a function to start downloading for passed ResourceRequest.
It does nothing for now, but shows how Download class can call FileDownloaderEfl's function.
(WebKit::FileDownloaderEfl::didReceiveResponse): virtual function for ResourceHandleClient.
It will receive response header information from ResourceHandle.
(WebKit::FileDownloaderEfl::didReceiveData): virtual function for ResourceHandleClient.
It will receive chunk data from ResourceHandle.
(WebKit::FileDownloaderEfl::didFinishLoading): virtual function for ResourceHandleClient.
It will be notified loading is finished from ResourceHandle.
(WebKit::FileDownloaderEfl::didFail): virtual function for ResourceHandleClient.
It will be notified loading is fail with ResourceError from ResourceHandle.
(WebKit::FileDownloaderEfl::shouldUseCredentialStorage): virtual function for ResourceHandleClient.
It returns whether to use credential storage or not.
(WebKit::FileDownloaderEfl::didReceiveAuthenticationChallenge): virtual function for ResourceHandleClient.
It will receive AuthenticationChallenge.
(WebKit::FileDownloaderEfl::didCancelAuthenticationChallenge): virtual function for ResourceHandleClient.
It will be notified AuthenticationChallenge is canceled.
(WebKit::FileDownloaderEfl::receivedCancellation): virtual function for ResourceHandleClient.

  • WebProcess/Downloads/efl/FileDownloaderEfl.h: Added.

(WebCore):
(WebKit):
(FileDownloaderEfl):

21:57 Changeset [107179] by tony@chromium.org

refactor RenderFlexibleBox to return preferred sizes of all children
https://bugs.webkit.org/show_bug.cgi?id=78169

Reviewed by Ojan Vafai.

This is in preparation for multi-line flexbox. We need the preferred
size of each child so we can compute where the multi-line breaks happen.

No new tests, just refactoring.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild): Renamed from preferredMainAxisContentExtentForFlexItem because
other methods are ForChild rather than ForFlexItem.
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithm):

  • rendering/RenderFlexibleBox.h:

(RenderFlexibleBox):

21:46 Changeset [107178] by morrita@google.com

Stop calling Element::ensureShadowRoot() if it is used in construction phase.
https://bugs.webkit.org/show_bug.cgi?id=77929

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-08
Reviewed by Hajime Morita.

ShadowRoot's life cycle can be consufing If Element::ensureShadowRoot() is used.
So we want to remove Element::ensureShadowRoot().
This patch replaces Element::ensureShadowRoot() if it is used in object construction phase.

No new tests, no change in behavior.

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::create):

Initialize exception code before calling appendChild.

  • html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::createShadowSubtree):

  • html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::HTMLKeygenElement):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::createShadowSubtree):

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::createShadowSubtree):

  • html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::createShadowSubtree):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::createShadowSubtree):

21:26 Changeset [107177] by commit-queue@webkit.org

[Chromium] Avoid unnecessary full tile updates without breaking atomicity of commits.
https://bugs.webkit.org/show_bug.cgi?id=76740

Patch by David Reveman <reveman@chromium.org> on 2012-02-08
Reviewed by James Robinson.

Source/WebCore:

Allow the final batch of texture uploads to be performed without
allocating new textures and re-painting complete tiles.

This patch is tested by the following unit test:

  • CCLayerTreeHostTestAtomicCommitWithPartialUpdate.runMultiThread
  • TiledLayerChromiumTest.partialUpdates
  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::UpdatableTile::UpdatableTile):
(UpdatableTile):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore):
(WebCore::TiledLayerChromium::tileOnlyNeedsPartialUpdate):
(WebCore::TiledLayerChromium::tileNeedsBufferedUpdate):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):

  • platform/graphics/chromium/TiledLayerChromium.h:

(TiledLayerChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initializeLayerRenderer):
(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::CCLayerTreeHost::requestPartialTextureUpdate):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):
(CCSettings):
(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCProxy.h:

(CCProxy):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::doCommit):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(WebCore::CCSingleThreadProxy::maxPartialTextureUpdates):

  • platform/graphics/chromium/cc/CCTextureUpdater.cpp:

(WebCore::CCTextureUpdater::append):
(WebCore):
(WebCore::CCTextureUpdater::appendPartial):
(WebCore::CCTextureUpdater::hasMoreUpdates):
(WebCore::CCTextureUpdater::update):
(WebCore::CCTextureUpdater::clear):

  • platform/graphics/chromium/cc/CCTextureUpdater.h:

(CCTextureUpdater):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WTF):
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):
(WebCore::CCThreadProxy::maxPartialTextureUpdates):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

Add CCLayerTreeHostTestAtomicCommitWithPartialUpdate and
TiledLayerChromiumTest.partialUpdates tests that verifies
atomicity of commits with partial updates.

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestAtomicCommit::CCLayerTreeHostTestAtomicCommit):
(WTF::CCLayerTreeHostTestAtomicCommit::beginTest):
(WTF::CCLayerTreeHostTestAtomicCommit::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommit::layout):
(CCLayerTreeHostTestAtomicCommit):
(CCLayerTreeHostTestAtomicCommitWithPartialUpdate):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::CCLayerTreeHostTestAtomicCommitWithPartialUpdate):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::beginTest):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::layout):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::afterTest):
(WTF):
(WTF::TEST_F):

  • tests/TiledLayerChromiumTest.cpp:

(WTF::FakeLayerTextureUpdater::Texture::Texture):
(WTF::FakeLayerTextureUpdater::Texture::updateRect):
(Texture):
(WTF::FakeLayerTextureUpdater::FakeLayerTextureUpdater):
(FakeLayerTextureUpdater):
(WTF::FakeLayerTextureUpdater::updateCount):
(WTF::FakeLayerTextureUpdater::clearUpdateCount):
(WTF::FakeLayerTextureUpdater::updateRect):
(WTF::FakeLayerTextureUpdater::createTexture):
(FakeTiledLayerChromium):
(WTF::TEST):
(WTF):

21:23 Changeset [107176] by morrita@google.com

Replacement text should be available from the marker.
https://bugs.webkit.org/show_bug.cgi?id=77934

.:

Reviewed by Kent Tamura.

  • Source/autotools/symbols.filter: Added an exporting symbol.

Source/WebCore:

Reviewed by Kent Tamura.

On spellchecking, TextCheckingResult can contain a replacement text
which is usable both for an automatic replacement and for showing a suggestion.

But when marking a misspelled word ragarding to returned
TextCheckingResult, Editor uses only the misspelled range data and
discards the replacement value. Then it asks the same value again
when showing suggestion/autocorrection.

It would be great if the marker holds the replacement text
and Editor can use it on suggesting a correction, without any re-request.
This is especially true in the case when it needs IPC messaging for spellchecking:
We can save one round-trip by this technique.

Here is actual change:

  • Passed the replacement text to addMarker() for for misspelling markers. Note that this is done only for the unified checker path because legacy TextCheckerClient API doesn't provide such a replacement.
  • Added an Internals API to retrieve a description text on a marker.

Test: editing/spelling/spelling-marker-description.html

  • WebCore.exp.in:
  • editing/Editor.cpp:

(WebCore::Editor::markAndReplaceFor):

  • testing/Internals.cpp:

(WebCore::Internals::markerAt):
(WebCore):
(WebCore::Internals::markerRangeForNode):
(WebCore::Internals::markerDescriptionForNode):

  • testing/Internals.h:

(WebCore):
(Internals):

  • testing/Internals.idl:

Source/WebKit/chromium:

didFinishCheckingText() accidentally dropped the description text
given from the backend. Fixed to copy it on the API-to-Core
convertion. The test won't work without this fix.

Reviewed by Kent Tamura.

  • src/WebTextCheckingCompletionImpl.cpp:

(WebKit::toCoreResults):

Source/WebKit/win:

Reviewed by Kent Tamura.

  • WebKit.vcproj/WebKit_Cairo.def:
  • WebKit.vcproj/WebKit_Cairo_debug.def:

Source/WebKit2:

Reviewed by Kent Tamura.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

Tools:

Made the mock requestCheckingOfText() implementation to return
a replacement text for each misspelled word if available.

Reviewed by Kent Tamura.

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::finishLastTextCheck):

LayoutTests:

Reviewed by Kent Tamura.

  • editing/spelling/spelling-marker-description-expected.txt: Added.
  • editing/spelling/spelling-marker-description.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
21:06 Changeset [107175] by eric@webkit.org

Remove more cruft now that HTMLIsIndexElement is gone
https://bugs.webkit.org/show_bug.cgi?id=77887

Reviewed by Darin Adler.

Just removing dead code, thus no tests.
There is likely more to remove after this.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLInputElement.cpp:
  • html/HTMLInputElement.h:

(HTMLInputElement):

  • html/InputType.cpp:

(WebCore::createInputTypeFactoryMap):

  • html/InputType.h:

(InputTypeNames):

  • html/IsIndexInputType.cpp: Removed.
  • html/IsIndexInputType.h: Removed.
  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::isContentEditable):

20:49 Changeset [107174] by commit-queue@webkit.org

[V8][Chromium] Race between worker accessing WebDatabase and frame closing down.
https://bugs.webkit.org/show_bug.cgi?id=78150
Handle case when the frame is shut down under us gracefully.

Patch by Dmitry Lomov <dslomov@chromium.org> on 2012-02-08
Reviewed by David Levin.

  • src/DatabaseObserver.cpp:

(WebCore::DatabaseObserver::canEstablishDatabase): Handle WebWorkerBase::view returning 0.

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::openFromWorker): Handle WebWorkerBase::view returning 0.

  • src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::allowFileSystem):
(WebKit::WebWorkerClientImpl::allowDatabase):
(WebKit::WebWorkerClientImpl::view):

20:41 Changeset [107173] by kling@webkit.org

Increased style sharing for elements with presentation attributes.
<http://webkit.org/b/78199>

Reviewed by Antti Koivisto.

When determining whether two elements can share style, we can do a lot better.
Instead of comparing the attribute maps for exact equality, do a property-by-property
comparison of the attributeStyle() and the additionalAttributeStyle() (if any.)

This increases our style sharing hit rate and shaves 100ms off of each cycle on
Chromium's "Moz" page cycler test on my machine.

The function that compares attribute styles has O(n2) runtime in the worst case,
where n is the number of properties in the styles. However, given the low number of
properties found in attribute styles, this should be fine, and it doesn't seem to
heat up in profiles.

  • css/CSSStyleSelector.cpp:

(WebCore::attributeStylesEqual):
(WebCore::CSSStyleSelector::canShareStyleWithElement):

20:34 Changeset [107172] by commit-queue@webkit.org

Fix the caculation of preDelayFrames in DynamicsCompressorKernel
https://bugs.webkit.org/show_bug.cgi?id=78057

Patch by Raymond Liu <raymond.liu@intel.com> on 2012-02-08
Reviewed by Chris Rogers.

No new tests required.

  • platform/audio/DynamicsCompressorKernel.cpp:

(WebCore::DynamicsCompressorKernel::setPreDelayTime):

20:04 Changeset [107171] by commit-queue@webkit.org

[Qt][DRT] DumpRenderTreeQt should support --no-timeout and --timeout options
https://bugs.webkit.org/show_bug.cgi?id=78146

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2012-02-08
Reviewed by Ryosuke Niwa.

Our DumpRenderTree should support --no-timeout and --timeout options in order
to be able to use run-perf-tests and have a Performance Bot.
This patch adds setTimeout and setShouldTimeout functions to our LayoutTestController
and the necessary code to handle such command line arguments to our DumpRenderTree.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::setTimeout):
(WebCore):
(WebCore::DumpRenderTree::setShouldTimeout):

  • DumpRenderTree/qt/DumpRenderTreeQt.h:

(DumpRenderTree):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::waitUntilDone):
(LayoutTestController::notifyDone):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:

(LayoutTestController::setTimeout):
(LayoutTestController::setShouldTimeout):
(LayoutTestController):

  • DumpRenderTree/qt/main.cpp:

(isOption):
(printUsage):
(main):

19:34 Changeset [107170] by adamk@chromium.org

DOM mutations should not be delivered on worker threads
https://bugs.webkit.org/show_bug.cgi?id=77898

Reviewed by Dmitry Titov.

Source/WebCore:

In V8RecursionScope, only call WebKitMutationObserver::deliverAllMutations
if in a Document context.

This is accomplished through a change to V8Proxy::instrumentedCallFunction
(which now takes a Frame* instead of a Page*), requiring an update to all
callers of that function (accounting for the majority of files changed
in this patch).

Added ASSERT(isMainThread()) in a deliverAllMutations to confirm that
it's no longer called on worker threads, and in enqueueMutationRecord,
where the same global store of active observers is accessed.

See also http://crbug.com/112586, where the problem was initially
reported.

  • bindings/v8/ScriptFunctionCall.cpp:

(WebCore::ScriptCallback::call):

  • bindings/v8/V8NodeFilterCondition.cpp:

(WebCore::V8NodeFilterCondition::acceptNode):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::runScript):
(WebCore::V8Proxy::callFunction):
(WebCore::V8Proxy::instrumentedCallFunction):

  • bindings/v8/V8Proxy.h:

(WebCore):
(V8Proxy):

  • bindings/v8/V8RecursionScope.cpp:

(WebCore::V8RecursionScope::didLeaveScriptContext):

  • bindings/v8/V8RecursionScope.h:

(WebCore):
(WebCore::V8RecursionScope::V8RecursionScope):
(V8RecursionScope):
(WebCore::V8RecursionScope::~V8RecursionScope):

  • bindings/v8/V8WindowErrorHandler.cpp:

(WebCore::V8WindowErrorHandler::callListenerFunction):

  • bindings/v8/custom/V8CustomVoidCallback.cpp:

(WebCore::invokeCallback):

  • bindings/v8/custom/V8CustomXPathNSResolver.cpp:

(WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):

  • dom/WebKitMutationObserver.cpp:

(WebCore::WebKitMutationObserver::enqueueMutationRecord):
(WebCore::WebKitMutationObserver::deliverAllMutations):

Source/WebKit/chromium:

  • src/WebDevToolsFrontendImpl.cpp:

(WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend):

19:20 Changeset [107169] by leo.yang@torchmobile.com.cn

[BlackBerry] Upstream InspectorClientBlackBerry.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=78082

Reviewed by Rob Buis.

Initial upstream, no new tests.

  • blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp: Added.
  • blackberry/WebCoreSupport/InspectorClientBlackBerry.h: Added.
19:02 Changeset [107168] by andersca@apple.com

Don't use the wheel event handler count to track if a page has horizontal scrollbars
https://bugs.webkit.org/show_bug.cgi?id=78192

Reviewed by Andreas Kling.

Source/WebCore:

Stop calling Document::didAddWheelEventHandler and Document::didRemoveWheelEventHandler when
adding and removing scrollbars.

  • page/FrameView.cpp:
  • page/FrameView.h:

(FrameView):

  • rendering/RenderLayer.cpp:
  • rendering/RenderLayer.h:

Source/WebKit2:

Prior to this change, we were incrementing and decrementing the wheel event handler count
whenever a scrollable area gained or lost a horizontal scrollbar, so we could use the count
to determine if Safari can handle horizontal wheel events directly or whether they have to be sent
to the web process first.

What this meant was that whenever a page had horizontal scrollbars we'd have to send all scroll wheel events
to the main thread instead of the scrolling thread, regardless of whether there were any wheel event handlers.

After this change, we traverse the tree of scrollable areas after every layout and check if any of them
have a horizontal scrollbar. (We still also check if there are wheel event handlers).

If traversing the tree after every layout is deemed to slow we can go back to caching the number of horizontal scrollbars
in a page, but the number of subframes in a page is usually very small and the number of other scrollable areas is even smaller.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::willHandleHorizontalScrollEvents):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::setCanShortCircuitHorizontalWheelEvents):
(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::numWheelEventHandlersChanged):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidLayout):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::numWheelEventHandlersChanged):
(WebKit):
(WebKit::hasEnabledHorizontalScrollbar):
(WebKit::pageContainsAnyHorizontalScrollbars):
(WebKit::WebPage::recomputeShortCircuitHorizontalWheelEventsState):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

18:55 Changeset [107167] by eae@chromium.org

Remove skia FixedPoint/Rect/Size files from build

18:45 Changeset [107166] by commit-queue@webkit.org

Roll Chromium DEPS
https://bugs.webkit.org/show_bug.cgi?id=78152

Patch by Scott Graham <scottmg@chromium.org> on 2012-02-08
Reviewed by Adam Barth.

  • DEPS:
18:38 Changeset [107165] by kov@webkit.org

Rubber-stamped by Martin Robinson.

  • gtk/common.py:

(get_build_path): Move test for current directory being a valid
directory up so it takes precedence over WebKitBuild/Release and
WebKitBuild/Debug when they exist as well.

18:28 Changeset [107164] by kov@webkit.org

[GTK] doc rebasing does not respect DESTDIR
https://bugs.webkit.org/show_bug.cgi?id=78177

Reviewed by Martin Robinson.

  • GNUmakefile.am: Pass DESTDIR on to generate-gtkdoc, when

calling it for rebasing.

  • gtk/generate-gtkdoc:

(get_common_options): Handle the new --virtual-root option.

  • gtk/gtkdoc.py:

(GTKDoc.rebase_installed_docs): If a virtual-root has been given, pass
it on to gtkdoc-rebase as dest-dir, and prefix the htmldir with it.

18:20 Changeset [107163] by eae@chromium.org

Remove platform specific implicit conversions from/to FloatRect/Point/Size and make conversions explicit in platform code.

18:07 Changeset [107162] by igor.o@sisa.samsung.com

Source/WebCore: Implement reverse animation direction

Implement reverse animation direction
https://bugs.webkit.org/show_bug.cgi?id=60525

Implement reverse and alternate-reverse direction.

Reviewed by Dean Jackson.

Tests: animations/animation-direction-alternate-reverse.html

animations/animation-direction-reverse.html
animations/fill-mode-reverse.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseAnimationDirection):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::mapAnimationDirection):

  • css/CSSValueKeywords.in:
  • page/WebKitAnimation.cpp:

(WebCore::WebKitAnimation::direction):

  • page/WebKitAnimation.h:
  • page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::fractionalTime):

  • platform/animation/Animation.h:

(Animation):

  • platform/graphics/texmap/TextureMapperAnimation.cpp:

(WebCore):
(WebCore::shouldReverseAnimationValue):
(WebCore::normalizedAnimationValue):

LayoutTests: Implement reverse animation direction
https://bugs.webkit.org/show_bug.cgi?id=60525

Add test for the new animation-direction values.

Reviewed by Dean Jackson.

  • animations/animation-direction-alternate-reverse-expected.txt: Added.
  • animations/animation-direction-alternate-reverse.html: Added.
  • animations/animation-direction-reverse-expected.txt: Added.
  • animations/animation-direction-reverse.html: Added.
  • animations/fill-mode-reverse-expected.txt: Added.
  • animations/fill-mode-reverse.html: Added.
17:56 Changeset [107161] by commit-queue@webkit.org

[chromium] Avoid creating a temporary GraphicsContext3D if someone requests the WebView's GraphicsContext3D before initialization is complete
https://bugs.webkit.org/show_bug.cgi?id=78154

Patch by James Robinson <jamesr@chromium.org> on 2012-02-08
Reviewed by Kenneth Russell.

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::context):

17:50 Changeset [107160] by hyatt@apple.com

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=78157

Make multi-column layout work with line grids that are outside of the multi-column
block.

Reviewed by Dan Bernstein.

Added new tests in fast/line-grid.

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::propagateLineGridInfo):
(WebCore::LayoutState::establishLineGrid):
(WebCore):
(WebCore::LayoutState::computeLineGridPaginationOrigin):

  • rendering/LayoutState.h:

(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::lineGrid):
(WebCore::LayoutState::lineGridOffset):
(WebCore::LayoutState::lineGridPaginationOrigin):
(WebCore::LayoutState::needsBlockDirectionLocationSetBeforeLayout):
(LayoutState):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlockChildren):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):

  • rendering/RenderView.h:

(WebCore::RenderView::pushLayoutState):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::lineGridSnapAdjustment):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=78157

Make multi-column layout work with line grids that are outside of the multi-column
block.

Reviewed by Dan Bernstein.

  • fast/line-grid/line-grid-into-columns.html: Added.
  • platform/mac/fast/line-grid/line-grid-into-columns-expected.png: Added.
  • platform/mac/fast/line-grid/line-grid-into-columns-expected.txt: Added.
17:41 Changeset [107159] by commit-queue@webkit.org

Improve http-equiv content-language parsing
https://bugs.webkit.org/show_bug.cgi?id=77724

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-02-08
Reviewed by Alexey Proskuryakov.

Add more tests for mapping http-equiv content-language to -webkit-locale. The desired behavior of some
of these is not yet decided, so some of the tests currently fail and the expectations may change. See comments in bug and in the tests.

  • fast/text/content-language-case-insensitivity-expected.txt:
  • fast/text/content-language-case-insensitivity.html: Style fixes.
  • fast/text/content-language-empty-expected.txt: Added.
  • fast/text/content-language-empty.html: Added.
  • fast/text/content-language-late-expected.txt: Added.
  • fast/text/content-language-late.html: Added.
  • fast/text/content-language-mapped-to-webkit-locale-expected.txt:
  • fast/text/content-language-mapped-to-webkit-locale.html: Style fixes.
  • fast/text/content-language-multiple-expected.txt: Added.
  • fast/text/content-language-multiple.html: Added.
  • fast/text/content-language-no-content-expected.txt: Added.
  • fast/text/content-language-no-content.html: Added.
  • fast/text/content-language-only-whitespace-expected.txt: Added.
  • fast/text/content-language-only-whitespace.html: Added.
  • fast/text/content-language-with-whitespace-expected.txt: Added.
  • fast/text/content-language-with-whitespace.html: Added.
17:41 Changeset [107158] by leo.yang@torchmobile.com.cn

[BlackBerry] Remove EditCommandBlackBerry.cpp from build system
https://bugs.webkit.org/show_bug.cgi?id=78078

Reviewed by Rob Buis.

WebKit/blackberry/WebCoreSupport/EditCommandBlackBerry.cpp which hasn't
been upstreamed has been removed from the BlackBerry porting internally.
So we should remove it from the build system.

  • blackberry/CMakeListsBlackBerry.txt:
17:30 Changeset [107157] by mdelaney@apple.com

GeneratorGeneratedImage::drawPattern does not factor in its destination context's scale when generating its image tiles

https://bugs.webkit.org/show_bug.cgi?id=67729
<rdar://problem/10087050>

Reviewed by Beth Dakin.

No new tests, current pixel tests will cover this. Though some pixel results might improve to become less pixel-y.

  • platform/graphics/GeneratorGeneratedImage.cpp:

(WebCore::GeneratorGeneratedImage::draw): Updated context to destContext for consistency.
(WebCore::GeneratorGeneratedImage::drawPattern): Taught drawPattern about the destination
scale factor to avoid having low-res generated images such as gradients in certain cases.

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::createCompatibleBuffer): Have the image buffer match the
context acceleration setting as well.

16:50 Changeset [107156] by abarth@webkit.org

Remove Python 2.5 support from WebKit
https://bugs.webkit.org/show_bug.cgi?id=71593

Reviewed by Eric Seidel.

This is the last vestige of our Python 2.5 support.

  • Scripts/webkitpy/tool/commands/queues_unittest.py:

(AbstractQueueTest.test_log_from_script_error_for_upload):

16:46 Changeset [107155] by abarth@webkit.org

version_check.py should inform users that we don't support Python 2.5 anymore
https://bugs.webkit.org/show_bug.cgi?id=78179

Reviewed by Eric Seidel.

We don't support Python 2.5 anymore.

  • Scripts/webkitpy/common/version_check.py:
16:37 Changeset [107154] by abarth@webkit.org

Remove empty directory.

16:32 Changeset [107153] by abarth@webkit.org

test_configuration.py shouldn't re-implement itertools
https://bugs.webkit.org/show_bug.cgi?id=78178

Reviewed by Eric Seidel.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py:

(TestConfigurationConverter.to_specifiers_list):
(TestConfigurationConverter.to_specifiers_list.try_collapsing):
(TestConfigurationConverter.to_specifiers_list.try_abbreviating):
(TestConfigurationConverter):

16:30 Changeset [107152] by jchaffraix@webkit.org

Unreviewed gardening.

  • platform/mac-future/svg/carto.net: Added.
  • platform/mac-future/svg/carto.net/scrollbar-expected.png: Added.
  • platform/mac/svg/carto.net/scrollbar-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.png:
  • platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.txt: Added.

Updated the baseline here, thanks to the text on the button...

  • platform/chromium/test_expectations.txt:

Marked one test as failing as some output don't make much sense.

16:27 Changeset [107151] by abarth@webkit.org

webkitpy should reply upon the multiprocessing package existing
https://bugs.webkit.org/show_bug.cgi?id=78176

Reviewed by Eric Seidel.

Now that we don't support Python 2.5, this import can't fail.

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:

(get):
(_Process):
(_Process.init):
(_Process.run):

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:

(FunctionTests.test_getprocesses):
(MultiProcessBrokerTests.setUp):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.init):
(Port.default_worker_model):

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumMacPort.check_build):

  • Scripts/webkitpy/layout_tests/port/port_testcase.py:

(PortTestCase.test_default_worker_model):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
16:25 Changeset [107150] by kov@webkit.org

Unreviewed typo fix that makes docs build again for the gtk2-based
library.

  • gtk/generate-gtkdoc:
16:24 Changeset [107149] by adamk@chromium.org

Simplify and correct mutation delivery timing for JSC
https://bugs.webkit.org/show_bug.cgi?id=78172

Reviewed by Adam Barth.

Instead of keeping a static recursion counter in JSMainThreadExecState,
simply wait for a state change from non-null ExecState to null ExecState.
Because s_mainThreadState is initially null, this equivalent to
waiting for s_recursionLevel to rewind to zero.

This also properly handles the usage of JSMainThreadNullState (and
does not do mutation delivery), since that class is only used by
non-JS bindings. Now fast/mutation/end-of-task-delivery.html properly
fails, whereas it was passing before due to usage of the ObjC DOM API
from DumpRenderTree.

  • bindings/js/JSMainThreadExecState.cpp:

(WebCore):

  • bindings/js/JSMainThreadExecState.h: Added a comment explaining the purpose of JSMainThreadNullState.

(WebCore::JSMainThreadExecState::JSMainThreadExecState):
(WebCore::JSMainThreadExecState::~JSMainThreadExecState):
(JSMainThreadExecState):
(WebCore):

16:21 Changeset [107148] by haraken@chromium.org

Remove [ConvertToString] from CodeGeneratorCPP.pm and rename
it to [ObjCImplementedAsUnsignedLong]
https://bugs.webkit.org/show_bug.cgi?id=78100

Reviewed by Eric Seidel.

Now [ConvertToString] is used by ObjC's HTMLElement.size only.
This patch removes [ConvertToString] code from CodeGeneratorCPP.pm,
and renames [ConvertToString] to [ObjCImplementedAsUnsignedLong].

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorCPP.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorObjC.pm:

(GenerateImplementation):

  • html/HTMLInputElement.idl: Removed FIXME comment, because the latest spec

says HTMLInputElement.size should be unsigned long.
(http://www.whatwg.org/specs/web-apps/current-work/multipage/the-input-element.html#the-input-element)

16:10 Changeset [107147] by abarth@webkit.org

Don't re-implement ZipFile.extractall
https://bugs.webkit.org/show_bug.cgi?id=78173

Reviewed by Eric Seidel.

We can use ZipFile.extractall now that we don't support Python 2.5.

  • Scripts/webkitpy/common/system/autoinstall.py:

(AutoInstaller._extract_targz):
(AutoInstaller._unzip):

16:04 Changeset [107146] by leo.yang@torchmobile.com.cn

REGRESSION(r84194): Build fails when turning on ENABLE_FILE_SYSTEM
https://bugs.webkit.org/show_bug.cgi?id=78088

Reviewed by Antonio Gomes.

WebCore::getDOMObjectWrapper was changed to WebCore::wrap in r84194.
Adapt to this change in JSEntryCustom.cpp and JSEntrySyncCustom.cpp.

Build fix, no new tests.

  • bindings/js/JSEntryCustom.cpp:

(WebCore::toJS):

  • bindings/js/JSEntrySyncCustom.cpp:

(WebCore::toJS):

15:59 Changeset [107145] by abarth@webkit.org

Remove the ospath compat shim from webkitpy
https://bugs.webkit.org/show_bug.cgi?id=78170

Reviewed by Eric Seidel.

We no longer need this compat shim now that we don't support Python 2.5.

  • Scripts/webkitpy/common/checkout/scm/git.py:
  • Scripts/webkitpy/common/checkout/scm/svn.py:
  • Scripts/webkitpy/common/system/filesystem.py:

(FileSystem.relpath):

  • Scripts/webkitpy/common/system/filesystem_mock.py:

(MockFileSystem.relpath):

  • Scripts/webkitpy/common/system/ospath.py: Removed.
  • Scripts/webkitpy/common/system/ospath_unittest.py: Removed.
15:57 Changeset [107144] by rniwa@webkit.org

Build fix attempt after r107053.

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(test_collect_tests):

15:48 Changeset [107143] by commit-queue@webkit.org

[Chromium] Fix opaque tracking for box shadows and non-composited child elements
https://bugs.webkit.org/show_bug.cgi?id=78073

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-08
Reviewed by Stephen White.

Source/WebCore:

Tests: compositing/culling/scrolled-within-boxshadow.html

compositing/culling/translated-boxshadow.html

Unit tests: PlatformContextSkiaTest.cpp

When painting a box shadow, a filter is applied to the skia canvas, that can make
pixels painted with an opaque color end up non-opaque. So consider image/mask/color
filters when deciding if a paint is opaque.

Also when painting the background of an element with a box shadow, the background is
painted with a transform on the skia canvas based on the size of the box shadow. This
transform needs to be considered when tracking an opaque paint.

However, when a layer's contentRect position is non-zero, we translate the GraphicsContext
to put the contentRect at 0,0 in the skia canvas. For tracking opaque regions in the resulting
layer, we need to unto this translation. Scaling can also occur which we must undo. So we pass
the transform in to PlatformContextSkia to go from the SkCanvas back to the layer's content
coordinate space. Opaque paints can then be tracked in the layer's content space rather than
in the skia canvas space.

  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapCanvasLayerTextureUpdater::prepareToUpdate):

  • platform/graphics/chromium/CanvasLayerTextureUpdater.cpp:

(WebCore::CanvasLayerTextureUpdater::paintContents):

  • platform/graphics/chromium/CanvasLayerTextureUpdater.h:

(WebCore):
(CanvasLayerTextureUpdater):

  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::SkPictureCanvasLayerTextureUpdater::prepareToUpdate):

  • platform/graphics/skia/OpaqueRegionSkia.cpp:

(WebCore::paintIsOpaque):
(WebCore::OpaqueRegionSkia::didDrawRect):
(WebCore::OpaqueRegionSkia::didDrawPath):
(WebCore::OpaqueRegionSkia::didDrawPoints):
(WebCore::OpaqueRegionSkia::didDrawBounded):
(WebCore::OpaqueRegionSkia::didDraw):
(WebCore::OpaqueRegionSkia::markRectAsOpaque):
(WebCore::OpaqueRegionSkia::markRectAsNonOpaque):

  • platform/graphics/skia/OpaqueRegionSkia.h:

(WebCore):
(OpaqueRegionSkia):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::didDrawRect):
(WebCore::PlatformContextSkia::didDrawPath):
(WebCore::PlatformContextSkia::didDrawPoints):
(WebCore::PlatformContextSkia::didDrawBounded):

  • platform/graphics/skia/PlatformContextSkia.h:

(PlatformContextSkia):
(WebCore::PlatformContextSkia::setOpaqueRegionTransform):

Source/WebKit/chromium:

  • tests/PlatformContextSkiaTest.cpp:

(WebCore::TEST):
(WebCore):

LayoutTests:

  • compositing/culling/scrolled-within-boxshadow-expected.png: Added.
  • compositing/culling/scrolled-within-boxshadow-expected.txt: Added.
  • compositing/culling/scrolled-within-boxshadow.html: Added.
  • compositing/culling/translated-boxshadow-expected.png: Added.
  • compositing/culling/translated-boxshadow-expected.txt: Added.
  • compositing/culling/translated-boxshadow.html: Added.
15:46 Changeset [107142] by eae@chromium.org

Merging trunk changes up until 107124 into subpixel branch.

15:35 Changeset [107141] by abarth@webkit.org

Remove simplejson because it's no longer used by webkitpy
https://bugs.webkit.org/show_bug.cgi?id=78164

Reviewed by Eric Seidel.

All the importers of this code were removed in a previous patch.

  • Scripts/webkitpy/thirdparty/simplejson: Removed.
  • Scripts/webkitpy/thirdparty/simplejson/LICENSE.txt: Removed.
  • Scripts/webkitpy/thirdparty/simplejson/README.txt: Removed.
  • Scripts/webkitpy/thirdparty/simplejson/init.py: Removed.
  • Scripts/webkitpy/thirdparty/simplejson/_speedups.c: Removed.
  • Scripts/webkitpy/thirdparty/simplejson/decoder.py: Removed.
  • Scripts/webkitpy/thirdparty/simplejson/encoder.py: Removed.
  • Scripts/webkitpy/thirdparty/simplejson/jsonfilter.py: Removed.
  • Scripts/webkitpy/thirdparty/simplejson/ordered_dict.py: Removed.
  • Scripts/webkitpy/thirdparty/simplejson/scanner.py: Removed.
  • Scripts/webkitpy/thirdparty/simplejson/tool.py: Removed.
15:34 Changeset [107140] by jchaffraix@webkit.org

Unreviewed gardening.

  • platform/chromium-mac-snowleopard/platform/chromium/compositing/lost-compositor-context-with-video-expected.png: Added.

Updated this baseline. It looks like an opacity difference of 1 that we could't really explain.

  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug120364-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug22019-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug23151-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46480-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46480-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug56405-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_td_nowrap-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug67915-2-expected.png: Added.
  • platform/chromium/tables/mozilla/bugs/bug56405-expected.txt: Removed.

Rebaselined those tests on snowleopard as we started taking up the new snow-leopard baselines from r107122.

  • platform/chromium/test_expectations.txt:

Mark compositing/iframes/scrolling-iframe.html as flaky as seen on a snow-leopard or windows (debug) bot near you.

15:26 Changeset [107139] by abarth@webkit.org

webkitpy still imports simplejson
https://bugs.webkit.org/show_bug.cgi?id=78161

Reviewed by Eric Seidel.

We no longer support Python 2.5, so we can rely upon Python's built-in
JSON package.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/common/net/resultsjsonparser.py:
  • Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
  • Scripts/webkitpy/layout_tests/models/test_expectations.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  • Scripts/webkitpy/style/checkers/jsonchecker.py:
  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
  • Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
  • Scripts/webkitpy/tool/servers/reflectionhandler.py:
15:20 Changeset [107138] by kov@webkit.org

[GTK] Fails to build docs with non-standard build directories
https://bugs.webkit.org/show_bug.cgi?id=78118

  • gtk/common.py:

(get_build_path): add comment to document changes done in r107098,
as requested by the reviewer and forgotten by me.

15:14 Changeset [107137] by haraken@chromium.org

Remove [CustomHeader] from CanvasPixelArray and rename [CustomHeader] to [JSCustomHeader]
https://bugs.webkit.org/show_bug.cgi?id=78089

Reviewed by Adam Barth.

This patch removes [CustomHeader] from CanvasPixelArray.idl, since CanvasPixelArrayCustom.h
does not exist. (The reason why missing CanvasPixelArrayCustom.h has not caused build failure
is that [CustomHeader] has been JSC-specific and JSC has not enabled CanvasPixelArray.)
Also, this patch renames [CustomHeader] to [JSCustomHeader], since whether a given class
should have custom header or not will depend on JavaScript bindings.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

  • dom/Node.idl:
  • html/canvas/CanvasPixelArray.idl:
15:08 Changeset [107136] by abarth@webkit.org

Stop importing with_statement from the mysterious future
https://bugs.webkit.org/show_bug.cgi?id=78156

Reviewed by Eric Seidel.

The future is now! (Well, at least 2008, when Python 2.6 was released,
is no longer the future.)

  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
  • Scripts/webkitpy/common/checkout/checkout_unittest.py:
  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  • Scripts/webkitpy/common/net/credentials_unittest.py:
  • Scripts/webkitpy/common/net/file_uploader.py:
  • Scripts/webkitpy/common/newstringio_unittest.py:
  • Scripts/webkitpy/common/system/autoinstall.py:
  • Scripts/webkitpy/common/system/crashlogs.py:
  • Scripts/webkitpy/common/system/fileset.py:
  • Scripts/webkitpy/common/system/filesystem.py:
  • Scripts/webkitpy/common/system/filesystem_unittest.py:
  • Scripts/webkitpy/common/system/path.py:
  • Scripts/webkitpy/common/thread/threadedmessagequeue.py:
  • Scripts/webkitpy/layout_tests/controllers/manager.py:
  • Scripts/webkitpy/layout_tests/port/base.py:

(of):

  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  • Scripts/webkitpy/style/filereader_unittest.py:
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
  • Scripts/webkitpy/tool/commands/analyzechangelog.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/servers/reflectionhandler.py:
  • Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
14:44 Changeset [107135] by commit-queue@webkit.org

Dispatch updateViewportArguments(), when Document is finished
restoring from page cache.

https://bugs.webkit.org/show_bug.cgi?id=77943

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-02-08
Reviewed by Kenneth Rohde Christiansen.

Move updateViewportArguments() call from setPageInCache() to
documentDidResumeFromPageCache() to ensure, that the Document is
fully resumed from the page cache and attached to the mainframe,
when the viewport arguments are updated.

No tests. No change in behaviour.

  • dom/Document.cpp:

(WebCore::Document::setInPageCache):
(WebCore::Document::documentDidResumeFromPageCache):

14:38 Changeset [107134] by jchaffraix@webkit.org

Unreviewed gardening.

  • platform/chromium-mac-leopard/svg/repaint/inner-svg-change-viewBox-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/repaint/inner-svg-change-viewBox-expected.png: Added.

Add those 2 new baselines.

14:17 Changeset [107133] by leviw@chromium.org

Prevent painting rects that snap to zero width or height.

13:49 BuildingQt5OnHarmattan edited by lauro.neto@openbossa.org
(diff)
13:47 Changeset [107132] by jamesr@google.com

[chromium] Add a layout test for losing the compositor context with a video playing
https://bugs.webkit.org/show_bug.cgi?id=78060

Reviewed by Eric Carlson.

Adds a test to prevent regressions with video playback when we lose the compositor context. This test loads up a
video, forces a frame to be displayed, simulates a lost context, then finishes the test (which causes another
frame to be displayed).

Prior to r106610 this test times out in debug and crashes in ASAN.

  • platform/chromium/compositing/lost-compositor-context-with-video-expected.png: Added.
  • platform/chromium/compositing/lost-compositor-context-with-video-expected.txt: Added.
  • platform/chromium/compositing/lost-compositor-context-with-video.html: Added.
13:46 Changeset [107131] by oliver@apple.com

Whoops, fix the build.

13:41 Changeset [107130] by shawnsingh@chromium.org

[chromium] Remove incorrect early exit in CCDamageTracker
https://bugs.webkit.org/show_bug.cgi?id=76924

Reviewed by James Robinson.

Source/WebCore:

New unit test added to CCDamageTrackerTest.cpp

This patch does three things: (1) adds unit test that demonstrates
that early exiting in CCDamageTracker is wrong, (2) removes the
early exit and cleans up the surrounding code, and (3) re-names
several functions in CCDamageTracker so that state updating is
implied by the name, and not just a bad side-effect of the functions.

  • platform/graphics/chromium/cc/CCDamageTracker.cpp:

(WebCore::CCDamageTracker::updateDamageTrackingState):
(WebCore::CCDamageTracker::trackDamageFromActiveLayers):
(WebCore::CCDamageTracker::trackDamageFromSurfaceMask):
(WebCore::CCDamageTracker::trackDamageFromLeftoverRects):

  • platform/graphics/chromium/cc/CCDamageTracker.h:

(CCDamageTracker):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::trackDamageForAllSurfaces):

Source/WebKit/chromium:

  • tests/CCDamageTrackerTest.cpp:

(WebKitTests::emulateDrawingOneFrame):
(WebKitTests::TEST_F):
(WebKitTests):

13:37 Changeset [107129] by rwlbuis@webkit.org

[BlackBerry] Upstream DumpRenderTreeBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=78042

Reviewed by Antonio Gomes.

Upstream more parts of our DRT implementation.

  • DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp: Added.
  • DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp: Added.
  • DumpRenderTree/blackberry/EventSender.cpp: Added.
  • DumpRenderTree/blackberry/EventSender.h: Added.
  • DumpRenderTree/blackberry/GCControllerBlackBerry.cpp: Added.
  • DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp: Added.
13:35 Changeset [107128] by oliver@apple.com

Fix issue encountered while debugging stacktraces
https://bugs.webkit.org/show_bug.cgi?id=78147

Reviewed by Gavin Barraclough.

Debugging is easier if we always ensure that we have a non-null
inferred name.

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::FunctionExecutable):

13:32 Changeset [107127] by jamesr@google.com

[chromium] Check that we can make the SharedGraphicsContext3D current before returning
https://bugs.webkit.org/show_bug.cgi?id=78142

Reviewed by Stephen White.

If we can't make the context current, we can't use it.

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp:

(WebCore::SharedGraphicsContext3D::get):

13:30 BuildingQt5OnHarmattan edited by lauro.neto@openbossa.org
(diff)
13:22 Changeset [107126] by oliver@apple.com

updateTopCallframe in the baseline JIT doesn't provide enough information to the stubs
https://bugs.webkit.org/show_bug.cgi?id=78145

Reviewed by Gavin Barraclough.

Fix the updateTopCallFrame helper to store additional information
that becomes necessary when we are trying to provide more stack
frame information.

  • interpreter/CallFrame.h:

(JSC::ExecState::bytecodeOffsetForBaselineJIT):
(ExecState):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JIT.h:

(JSC::JIT::compileGetByIdProto):
(JSC::JIT::compileGetByIdSelfList):
(JSC::JIT::compileGetByIdProtoList):
(JSC::JIT::compileGetByIdChainList):
(JSC::JIT::compileGetByIdChain):
(JSC::JIT::compilePutByIdTransition):
(JIT):

  • jit/JITInlineMethods.h:

(JSC::JIT::updateTopCallFrame):

13:12 Changeset [107125] by commit-queue@webkit.org

Add support for pinch gesture processing in the MT compositor.
https://bugs.webkit.org/show_bug.cgi?id=77804

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-02-08
Reviewed by James Robinson.

  • public/WebInputEvent.h:
  • src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::WebCompositorInputHandlerImpl):
(WebKit::WebCompositorInputHandlerImpl::handleInputEvent):

  • src/WebCompositorInputHandlerImpl.h:

(WebCompositorInputHandlerImpl):

  • src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleInputEvent):

  • tests/WebCompositorInputHandlerImplTest.cpp:
13:02 Changeset [107124] by dpranke@chromium.org

check-webkit-style failing with "Path does not exist."
https://bugs.webkit.org/show_bug.cgi?id=77873

Reviewed by Ojan Vafai.

This change fixes the way the style checker determines which
Port class to use for a given test_expectations.txt path; the
previous version used a heuristic that didn't really work in the
first place.

  • Scripts/webkitpy/style/checkers/test_expectations.py:

(TestExpectationsChecker._determine_port_from_expectations_path):
(TestExpectationsChecker.init):

  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py:

(TestExpectationsTestCase._expect_port_for_expectations_path):
(TestExpectationsTestCase.test_determine_port_from_expectations_path):

12:53 Changeset [107123] by inferno@chromium.org

Crash in Node::normalize.
https://bugs.webkit.org/show_bug.cgi?id=78135

Reviewed by Ryosuke Niwa.

No new tests. Original testcase does not reduce to manageable
extent.

  • dom/Node.cpp:

(WebCore::Node::normalize):

12:42 Changeset [107122] by eae@chromium.org

Update pixel table test expectations for mac to match new DRT scrollbars
https://bugs.webkit.org/show_bug.cgi?id=76938

Rubber stamped by Eric Seidel.

  • platform/mac/tables/mozilla/bugs/bug101674-expected.png:
  • platform/mac/tables/mozilla/bugs/bug10296-1-expected.png:
  • platform/mac/tables/mozilla/bugs/bug113235-1-expected.png:
  • platform/mac/tables/mozilla/bugs/bug113235-3-expected.png:
  • platform/mac/tables/mozilla/bugs/bug11944-expected.png:
  • platform/mac/tables/mozilla/bugs/bug120364-expected.png:
  • platform/mac/tables/mozilla/bugs/bug131020-expected.png:
  • platform/mac/tables/mozilla/bugs/bug131020_iframe-expected.png:
  • platform/mac/tables/mozilla/bugs/bug137388-2-expected.png:
  • platform/mac/tables/mozilla/bugs/bug149275-1-expected.png:
  • platform/mac/tables/mozilla/bugs/bug22019-expected.png:
  • platform/mac/tables/mozilla/bugs/bug23151-expected.png:
  • platform/mac/tables/mozilla/bugs/bug27038-2-expected.png:
  • platform/mac/tables/mozilla/bugs/bug29314-expected.png:
  • platform/mac/tables/mozilla/bugs/bug32205-2-expected.png:
  • platform/mac/tables/mozilla/bugs/bug38916-expected.png:
  • platform/mac/tables/mozilla/bugs/bug43039-expected.png:
  • platform/mac/tables/mozilla/bugs/bug43854-1-expected.png:
  • platform/mac/tables/mozilla/bugs/bug44505-expected.png:
  • platform/mac/tables/mozilla/bugs/bug46480-1-expected.png:
  • platform/mac/tables/mozilla/bugs/bug46480-2-expected.png:
  • platform/mac/tables/mozilla/bugs/bug50695-1-expected.png:
  • platform/mac/tables/mozilla/bugs/bug56405-expected.png:
  • platform/mac/tables/mozilla/bugs/bug67915-1-expected.png:
  • platform/mac/tables/mozilla/bugs/bug73321-expected.png:
  • platform/mac/tables/mozilla/bugs/bug92143-expected.png:
  • platform/mac/tables/mozilla/bugs/bug96334-expected.png:
  • platform/mac/tables/mozilla/bugs/bug96343-expected.png:
  • platform/mac/tables/mozilla/marvin/x_table_bgcolor_name-expected.png:
  • platform/mac/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.png:
  • platform/mac/tables/mozilla/marvin/x_td_bgcolor_name-expected.png:
  • platform/mac/tables/mozilla/marvin/x_td_bgcolor_rgb-expected.png:
  • platform/mac/tables/mozilla/marvin/x_td_height-expected.png:
  • platform/mac/tables/mozilla/marvin/x_td_nowrap-expected.png:
  • platform/mac/tables/mozilla/marvin/x_th_bgcolor_name-expected.png:
  • platform/mac/tables/mozilla/marvin/x_th_bgcolor_rgb-expected.png:
  • platform/mac/tables/mozilla/marvin/x_th_height-expected.png:
  • platform/mac/tables/mozilla/marvin/x_th_nowrap-expected.png:
  • platform/mac/tables/mozilla/marvin/x_tr_bgcolor_name-expected.png:
  • platform/mac/tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug101759-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug14007-1-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug19526-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug22122-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug67915-2-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
  • platform/mac/tables/mozilla_expected_failures/core/backgrounds-expected.png:
  • platform/mac/tables/mozilla_expected_failures/core/col_span2-expected.png:
  • platform/mac/tables/mozilla_expected_failures/core/columns-expected.png:
  • platform/mac/tables/mozilla_expected_failures/core/conflicts-expected.png:
  • platform/mac/tables/mozilla_expected_failures/core/standards1-expected.png:
  • platform/mac/tables/mozilla_expected_failures/other/empty_cells-expected.png:
12:39 Changeset [107121] by jamesr@google.com

Make WebGL context current early to check validity
https://bugs.webkit.org/show_bug.cgi?id=78141

Patch by Antoine Labour <piman@chromium.org> on 2012-02-08
Reviewed by James Robinson.

Covered by existing tests

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::create):

12:35 Changeset [107120] by commit-queue@webkit.org

[chromium] Disable root layer clears on release builds.
https://bugs.webkit.org/show_bug.cgi?id=77478

Patch by Jonathan Backer <backer@chromium.org> on 2012-02-08
Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::clearRenderSurface):
(WebCore::LayerRendererChromium::drawRenderPass):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

LayoutTests:

  • platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-gpu-linux/media/video-zoom-expected.png:
  • platform/chromium-linux/compositing/direct-image-compositing-expected.png:
  • platform/chromium-linux/compositing/geometry/ancestor-overflow-change-expected.png:
  • platform/chromium-linux/compositing/geometry/fixed-in-composited-expected.png:
  • platform/chromium-linux/compositing/geometry/tall-page-composited-expected.png:
  • platform/chromium-linux/compositing/masks/masked-ancestor-expected.png:
  • platform/chromium-linux/compositing/masks/multiple-masks-expected.png:
  • platform/chromium-linux/compositing/masks/simple-composited-mask-expected.png:
  • platform/chromium-linux/compositing/scaling/tiled-layer-recursion-expected.png:
  • platform/chromium-linux/platform/chromium/compositing/layout-width-change-expected.png:
12:24 Changeset [107119] by andersca@apple.com

Add a content shadow layer to the render layer compositor
https://bugs.webkit.org/show_bug.cgi?id=78133
<rdar://problem/10797742>

Reviewed by Beth Dakin.

Have the render layer compositor optionally create a content shadow layer,
and add a ScrollbarTheme::setUpContentShadowLayer member function that subclasses
can use to set content shadow properties.

  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::setUpContentShadowLayer):
Set the layer properties once, and set the shadow path on every call, since we know that this
function will be called every time the size of the content shadow layer changes.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateRootLayerPosition):
Reposition the content shadow layer, and call ScrollbarTheme::setUpContentShadowLayer if the size changes.

(WebCore::RenderLayerCompositor::requiresContentShadowLayer):
Add new helper function.

(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
Create a content shadow layer if needed.

12:20 Changeset [107118] by aestes@apple.com

REGRESSION (r102983): ClicktoFlash drawing of old style youtube embeds missing until resize
https://bugs.webkit.org/show_bug.cgi?id=77167

Reviewed by Eric Seidel.

Source/WebCore:

Test: plugins/layout-in-beforeload-listener-affects-plugin-loading.html

r102983 made FrameView::updateWidgets() check if the DOM node actually
needs a widget update before calling updateWidget(). Due to historical
reasons, however, updateWidget() can be legitimately called twice: once
at attach time for non-Netscape plug-ins and once at layout time for
Netscape plug-ins.

If the widget represents a Netscape plug-in, but updateWidget() is
called for the CreateOnlyNonNetscapePlugins case after the DOM node was
marked as needing an update, updateWidget() will clear the update flag
and prevent a second call to updateWidget() at layout time for the
CreateAnyWidgetType case.

As much as I loathe adding to the code duplication between
HTMLEmbedElement::updateWidget() and HTMLObjectElement::updateWidget(),
the simplest solution seems to be marking the DOM node as needing
update in the case where we are calling updateWidget() for the
CreateOnlyNonNetscapePlugins case and we know we will be loading a
Netscape plug-in.

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::updateWidget): Call
setNeedsWidgetUpdate(true) if pluginCreationOption is
CreateOnlyNonNetscapePlugins but we will load a Netscape plug-in.

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateWidget): Ditto.

  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::guardedDispatchBeforeLoadEvent): Remove an
invalid assertion that prevents the layout test from running in a Debug
configuration.

LayoutTests:

  • plugins/layout-in-beforeload-listener-affects-plugin-loading-expected.txt: Added.
  • plugins/layout-in-beforeload-listener-affects-plugin-loading.html: Added.
12:17 Changeset [107117] by commit-queue@webkit.org

[chromium] Make dependency on Accelerate.framework explicit.
https://bugs.webkit.org/show_bug.cgi?id=78131

It's used by platform/audio/mac/FFTFrameMac.cpp. The explicit
dependency is needed to build a libwebkit.dylib.

Patch by Nico Weber <nicolasweber@gmx.de> on 2012-02-08
Reviewed by Tony Chang.

  • WebKit.gyp:
12:17 Changeset [107116] by kbr@google.com

Merge 106888 - WebGL must allocate smaller drawing buffer when the allocation fails.
https://bugs.webkit.org/show_bug.cgi?id=76654

Patch by Yongsheng Zhu <yongsheng.zhu@intel.com> on 2012-02-06
Reviewed by Kenneth Russell.

Test: fast/canvas/webgl/drawingbuffer-test.html

  • platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore):
(WebCore::DrawingBuffer::create):
(WebCore::DrawingBuffer::reset):

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9359020

12:16 Changeset [107115] by commit-queue@webkit.org

[Chromium] Don't add selection from password fields to context menu.
https://bugs.webkit.org/show_bug.cgi?id=77733

Patch by Bernhard Bauer <bauerb@google.com> on 2012-02-08
Reviewed by Adam Barth.

  • src/ContextMenuClientImpl.cpp:

(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

12:11 Changeset [107114] by caryclark@google.com

Unreviewed rebaselines for vertical text tests.
See https://bugs.webkit.org/show_bug.cgi?id=78120

  • platform/chromium-mac-leopard/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:

[...]

  • platform/chromium-mac-snowleopard/fast/writing-mode/vertical-font-fallback-expected.png: Added.
  • platform/chromium/test_expectations.txt:
11:59 Changeset [107113] by commit-queue@webkit.org

nrwt: make --skip-pixel-test-if-no-baseline option
https://bugs.webkit.org/show_bug.cgi?id=70484

Patch by Fehér Zsolt <feherzs@inf.u-szeged.hu> on 2012-02-08
Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner.init):
(SingleTestRunner._should_fetch_expected_checksum):

  • Scripts/webkitpy/layout_tests/controllers/worker.py:

(Worker.handle_test_list):

  • Scripts/webkitpy/layout_tests/models/test_input.py:

(TestInput.init):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitDriver.cmd_line):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(_set_up_derived_options):
(parse_args):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_skip_pixel_test_if_no_baseline_option):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::runTest):

  • WebKitTestRunner/TestController.h:

(TestController):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::TestInvocation):
(WTR::TestInvocation::setIsPixelTest):

  • WebKitTestRunner/TestInvocation.h:

(WTR::TestInvocation::setSkipPixelTestOption):
(TestInvocation):

11:58 Changeset [107112] by ojan@chromium.org

Floated flexboxes render as regular RenderBlocks
https://bugs.webkit.org/show_bug.cgi?id=77909

Reviewed by Eric Seidel.

Source/WebCore:

Add grid/flexbox cases to adjusting the display of floated/positioned
elements. Also, move this logic into a switch statement. This makes
the code more readable and gives compile warnings when new display types
are added that aren't handled here.

Test: css3/flexbox/floated-flexbox.html

  • css/CSSStyleSelector.cpp:

(WebCore::adjustDisplay):
(WebCore):
(WebCore::CSSStyleSelector::adjustRenderStyle):

LayoutTests:

  • css3/flexbox/floated-flexbox-expected.txt: Added.
  • css3/flexbox/floated-flexbox.html: Added.
11:44 Changeset [107111] by commit-queue@webkit.org

[chromium] Let -Wglobal-constructors hack in shared build metastasize to mac
https://bugs.webkit.org/show_bug.cgi?id=78130

Patch by Nico Weber <nicolasweber@gmx.de> on 2012-02-08
Reviewed by Tony Chang.

  • WebKit.gyp:
11:29 Changeset [107110] by jamesr@google.com

r107042 caused compile breakages on chromium try bots
https://bugs.webkit.org/show_bug.cgi?id=78125

Reviewed by Adam Barth.

Replace the copy script with a copies GYP action since the MSVS generator tracks dependencies on a per-file
basis.

  • Platform.gyp/Platform.gyp:
  • Platform.gyp/copy_webcore_headers.py: Removed.
11:26 Changeset [107109] by jchaffraix@webkit.org

Unreviewed gardening.

  • platform/chromium-linux/fast/line-grid/line-grid-contains-value-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/line-grid/line-grid-contains-value-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/line-grid/line-grid-contains-value-expected.png: Added.
  • platform/chromium-win/fast/line-grid/line-grid-contains-value-expected.png: Added.
  • platform/chromium-win/fast/line-grid/line-grid-contains-value-expected.txt: Added.

More rebaseline of those (I pulled the trigger too early).

  • platform/chromium/rubberbanding/custom-scrollbars-ne-expected.png:
  • platform/chromium/rubberbanding/custom-scrollbars-nw-expected.png:
  • platform/chromium/rubberbanding/custom-scrollbars-se-expected.png:
  • platform/chromium/rubberbanding/custom-scrollbars-sw-expected.png:

Update the expected files. I don't know how we ended up with a blue color when the html specifies
an orange.

  • platform/chromium/test_expectations.txt:

Mark a test as timing out as it has been raising an exception on the bots fairly regularly.

11:19 Changeset [107108] by krit@webkit.org

viewBox on nested SVG causes wrong content size for relative values
https://bugs.webkit.org/show_bug.cgi?id=69459

Reviewed by Nikolas.

Source/WebCore:

In the past we just checked the change of the viewport size of the root SVG element. If the size changed, all childs
with relative length values needed a relayout. We did not consider that we might have other viewports in the document.
Childs with relative lengths had a strange zooming, if just the viewport size of an inner SVG element changed.

With this patch we check if the size of the nearest viewport changes. Is this the case, childs with relative lengths
need a relayout.

Test: inner-svg-change-viewBox.svg

  • rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::layout):

  • rendering/svg/RenderSVGContainer.h:

(RenderSVGContainer):
(WebCore::RenderSVGContainer::determineIfLayoutSizeChanged): Check if we need layout and have relative length values.

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::layout): Remove resetting 'viewport size changed' flag for code operability. No influence on the layout.

  • rendering/svg/RenderSVGViewportContainer.cpp:

(WebCore::RenderSVGViewportContainer::RenderSVGViewportContainer): Add a flag that indicates that the viewport size changes.
(WebCore::RenderSVGViewportContainer::determineIfLayoutSizeChanged): The flag gets set during the layout phase of the SVG element if the size changes.
(WebCore):

  • rendering/svg/RenderSVGViewportContainer.h:

(WebCore::RenderSVGViewportContainer::isLayoutSizeChanged): Added getter to get flag status.
(RenderSVGViewportContainer):
(WebCore::toRenderSVGViewportContainer): Added casting function for constant RenderObjects.
(WebCore):

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::layoutSizeOfNearestViewportChanged): Search the nearest viewport and check if the size changed.
(WebCore):
(WebCore::SVGRenderSupport::layoutChildren): Don't check the roots viewport for size changes, but the nearest viewport.

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::svgAttributeChanged): Added viewBoxAttr to the list of attributes that cause relayout.

LayoutTests:

Test relayout of content of inner SVG on change of relative length values.

  • svg/repaint/inner-svg-change-viewBox-expected.png: Added.
  • svg/repaint/inner-svg-change-viewBox-expected.txt: Added.
  • svg/repaint/inner-svg-change-viewBox.svg: Added.
11:13 Changeset [107107] by commit-queue@webkit.org

Implement new WEBGL compressed texture extensions
https://bugs.webkit.org/show_bug.cgi?id=77066

Source/WebCore:

This removes the old experimental compressed
texture extension and implements the first new
one.

A test is in the WebGL conformance tests in
extensions/webgl-compressed-texture-s3tc.html
and will be copied here in a future patch.

Patch by Gregg Tavares <gman@google.com> on 2012-02-08
Reviewed by Kenneth Russell.

No new tests. Test coming in future patch.

  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):

  • html/canvas/WebGLCompressedTextureS3TC.cpp: Added.

(WebCore):
(WebCore::WebGLCompressedTextureS3TC::WebGLCompressedTextureS3TC):
(WebCore::WebGLCompressedTextureS3TC::~WebGLCompressedTextureS3TC):
(WebCore::WebGLCompressedTextureS3TC::getName):
(WebCore::WebGLCompressedTextureS3TC::create):
(WebCore::WebGLCompressedTextureS3TC::supported):

  • html/canvas/WebGLCompressedTextureS3TC.h: Copied from Source/WebCore/html/canvas/WebGLExtension.h.

(WebCore):
(WebGLCompressedTextureS3TC):

  • html/canvas/WebGLCompressedTextureS3TC.idl: Renamed from Source/WebCore/html/canvas/WebGLCompressedTextures.idl.
  • html/canvas/WebGLCompressedTextures.cpp: Removed.
  • html/canvas/WebGLCompressedTextures.h: Removed.
  • html/canvas/WebGLExtension.h:
  • html/canvas/WebGLGetInfo.cpp:

(WebCore::WebGLGetInfo::WebGLGetInfo):
(WebCore):
(WebCore::WebGLGetInfo::getWebGLUnsignedIntArray):

  • html/canvas/WebGLGetInfo.h:
  • html/canvas/WebGLObject.cpp:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::addCompressedTextureFormat):
(WebCore::WebGLRenderingContext::compressedTexImage2D):
(WebCore::WebGLRenderingContext::compressedTexSubImage2D):
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::validateCompressedTexFormat):
(WebCore::WebGLRenderingContext::validateCompressedTexFuncData):
(WebCore::WebGLRenderingContext::validateCompressedTexDimensions):
(WebCore::WebGLRenderingContext::validateCompressedTexSubDimensions):

  • html/canvas/WebGLRenderingContext.h:

(WebCore):
(WebGLRenderingContext):

  • html/canvas/WebGLRenderingContext.idl:

LayoutTests:

Patch by Gregg Tavares <gman@chromium.org> on 2012-02-08
Reviewed by Kenneth Russell.

  • fast/canvas/webgl/constants.html:
  • fast/canvas/webgl/gl-get-calls-expected.txt:
  • fast/canvas/webgl/gl-get-calls.html:
10:49 Changeset [107106] by loislo@chromium.org

Web Inspector: heap snapshot: implement Distance column in Object's retaining tree.
https://bugs.webkit.org/show_bug.cgi?id=78113

Retaining path list was replaced with Retaining tree some time ago.
But it was not so useful when we want to track the retaining path from an object to a DOM Window node.

Drive by fix: sort doesn't work in retaining tree panel.
Drive by fix: save/load child nodes doesn't work for the retaining tree panel.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotObjectNode):
(WebInspector.HeapSnapshotObjectNode.prototype._childHashForEntity): save/load children fix
(WebInspector.HeapSnapshotObjectNode.prototype._childHashForNode): save/load children fix
(WebInspector.HeapSnapshotObjectNode.prototype.comparator):
(WebInspector.HeapSnapshotObjectNode.prototype._enhanceData):

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.HeapSnapshotContainmentDataGrid):
(WebInspector.HeapSnapshotRetainmentDataGrid):
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype._sortFields):

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotRetainerEdge.prototype.set retainerIndex):
(WebInspector.HeapSnapshotRetainerEdge.prototype.set edgeIndex):
(WebInspector.HeapSnapshotRetainerEdge.prototype.get _node):
(WebInspector.HeapSnapshotRetainerEdge.prototype.get _edge):
(WebInspector.HeapSnapshotNode.prototype.get distanceToWindow):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype._buildRetainers):
(WebInspector.HeapSnapshot.prototype._calculateObjectToWindowDistance):
(WebInspector.HeapSnapshot.prototype._bfs):
(WebInspector.HeapSnapshotEdgesProvider.prototype._serialize):
(WebInspector.HeapSnapshotEdgesProvider.prototype.sort.compareEdgeFieldName):
(WebInspector.HeapSnapshotEdgesProvider.prototype.sort.compareNodeField):
(WebInspector.HeapSnapshotEdgesProvider.prototype.sort.compareEdgeAndNode):
(WebInspector.HeapSnapshotEdgesProvider.prototype.sort.compareNodeAndEdge):
(WebInspector.HeapSnapshotEdgesProvider.prototype.sort.compareNodeAndNode):
(WebInspector.HeapSnapshotEdgesProvider.prototype.sort):
(WebInspector.HeapSnapshotNodesProvider.prototype._serialize):

  • inspector/front-end/heapProfiler.css:

(.detailed-heapshot-view .data-grid td.distanceToWindow-column):

10:35 Changeset [107105] by commit-queue@webkit.org

[BlackBerry] Upstream DumpRenderTreeBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=78042

Patch by Rob Buis <rbuis@rim.com> on 2012-02-08
Reviewed by Antonio Gomes.

Source/WebKit:

Add abstract interface for our DumpRenderTree solution.

  • blackberry/Api/DumpRenderTreeClient.h: Added.

Tools:

Add implementation for our DumpRenderTree solution.

  • DumpRenderTree/blackberry/DumpRenderTree.cpp: Added.
  • DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h: Added.
10:29 Changeset [107104] by ossy@webkit.org

[Qt] svg/zoom/page/zoom-coords-viewattr-01-b.svg fails
https://bugs.webkit.org/show_bug.cgi?id=78128

  • platform/qt/Skipped: Skip it until fix.
10:27 Changeset [107103] by jchaffraix@webkit.org

Unreviewed morning gardening.

  • platform/chromium-linux/fast/line-grid/line-grid-contains-value-expected.png: Added.
  • platform/chromium-linux/fast/line-grid/line-grid-contains-value-expected.txt: Added.

Rebaselined this file (font difference).

  • platform/chromium/test_expectations.txt: Marked one test as SLOW on Window.
10:00 Changeset [107102] by andersca@apple.com

Fix assertion in svg/dom/SVGStyledElement-pendingResource-crash.html
https://bugs.webkit.org/show_bug.cgi?id=78126

Reviewed by Dan Bernstein.

This broke in r106977 when I tried to change an early return into an ASSERT,
so let's bring back the early return.

  • page/FrameView.cpp:

(WebCore::FrameView::notifyPageThatContentAreaWillPaint):

09:56 Changeset [107101] by ossy@webkit.org

Unreviewed, rolling out r106920, r106924, r106933, r106939,
and r107090.
http://trac.webkit.org/changeset/106920
http://trac.webkit.org/changeset/106924
http://trac.webkit.org/changeset/106933
http://trac.webkit.org/changeset/106939
http://trac.webkit.org/changeset/107090
https://bugs.webkit.org/show_bug.cgi?id=78124

Something is completely wrong this change (Requested by
Ossy_gardener on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-08

Source/WebCore:

  • platform/FileSystem.h:

(WebCore):

  • platform/qt/FileSystemQt.cpp:

Source/WebKit2:

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

(WebProcessCreationParameters):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):

  • UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::platformInitializeWebProcess):

  • WebProcess/qt/WebProcessQt.cpp:

(WebKit):
(WebKit::WebProcess::platformSetCacheModel):
(WebKit::WebProcess::platformInitializeWebProcess):

09:35 Changeset [107100] by antti@apple.com

REGRESSION (r106681): Null check missing in [WebFrame(WebInternal) _typingStyle]
https://bugs.webkit.org/show_bug.cgi?id=78080

Source/WebKit/mac:

Reviewed by Reviewed by Andreas Kling, Darin Adler and Dan Bernstein.

  • WebView/WebFrame.mm:

(-[WebFrame _typingStyle]):

Tools:

Reviewed by Andreas Kling, Darin Adler and Dan Bernstein.

Add API test.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: Added.

(TestWebKitAPI):
(TestWebKitAPI::TEST):

09:34 Changeset [107099] by hyatt@apple.com

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=78122

Add support for the "contains" value for line-grid-snap. This value centers the line box in between the
text-top and text-bottom of the minimum number of grid lines that enclose the line box. This is useful for
centering headers in a line grid.

Reviewed by Adam Roben.

Added a new test in fast/line-grid.

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::lineGridSnapAdjustment):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=78122

Add a new test that shows the "contains" value in action.

Reviewed by Adam Roben.

  • fast/line-grid/line-grid-contains-value.html: Added.
  • platform/mac/fast/line-grid/line-grid-contains-value-expected.png: Added.
  • platform/mac/fast/line-grid/line-grid-contains-value-expected.txt: Added.
09:31 Changeset [107098] by commit-queue@webkit.org

[GTK] Fails to build docs with non-standard build directories
https://bugs.webkit.org/show_bug.cgi?id=78118

Patch by Gustavo Noronha Silva <gns@gnome.org> on 2012-02-08
Reviewed by Martin Robinson.

  • gtk/common.py:

(get_build_path): also try the current directory as a valid build
dir, which makes non-standard build directories such as build-2.0
and build-3.0 work

09:15 Changeset [107097] by caryclark@google.com

[Skia Mac] Make misspelling underline dots unclipped
https://bugs.webkit.org/show_bug.cgi?id=78117
http://code.google.com/p/chromium/issues/detail?id=113154

Reviewed by Stephen White.

No new tests. Existing layout tests cover this.

As is done on the CoreGraphics Mac platform, adjust the
underline width to remove partial dots, not including the
trailing transparent pixel column.

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::drawLineForTextChecking):

09:05 Changeset [107096] by mitz@apple.com

Moved a Mac-specific test to platform/mac.

  • fast/text/synthetic-bold-transformed-expected.html: Removed.
  • fast/text/synthetic-bold-transformed.html: Removed.
  • platform/mac/fast/text/synthetic-bold-transformed-expected.html: Copied from fast/text/synthetic-bold-transformed-expected.html.
  • platform/mac/fast/text/synthetic-bold-transformed.html: Copied from fast/text/synthetic-bold-transformed.html.
09:01 Changeset [107095] by commit-queue@webkit.org

Initial upstreaming of input handling for BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=77992

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-02-08
Reviewed by Rob Buis.

  • blackberry/WebKitSupport/InputHandler.cpp: Added.
  • blackberry/WebKitSupport/InputHandler.h: Added.
08:57 Changeset [107094] by commit-queue@webkit.org

Chromium: Fix Mac rubber band overhang drawing on composited pages and re-enable tests.
https://bugs.webkit.org/show_bug.cgi?id=78007

This got broken by: http://trac.webkit.org/changeset/105470
And the tests were accidentally(?) disabled in: http://trac.webkit.org/changeset/95191

There is still three tests that fail from the set, but the cause for these is different,
which I'm still investigating.

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2012-02-08
Reviewed by James Robinson.

Source/WebKit/chromium:

  • src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::NonCompositedContentHost):

LayoutTests:

  • platform/chromium/test_expectations.txt:
08:42 Changeset [107093] by pfeldman@chromium.org

Web Inspector: bind entire subtree upon childNodeInserted so that text node were accounted.
https://bugs.webkit.org/show_bug.cgi?id=78116

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode):
(WebInspector.DOMDocument):
(WebInspector.DOMAgent.prototype._setDocument):
(WebInspector.DOMAgent.prototype._setDetachedRoot):
(WebInspector.DOMAgent.prototype._setChildNodes):
(WebInspector.DOMAgent.prototype._childNodeRemoved):
(WebInspector.DOMAgent.prototype._unbind):

LayoutTests:

  • inspector/elements/insert-node-expected.txt:
  • inspector/elements/insert-node.html:
08:31 Changeset [107092] by carlosgc@webkit.org

[GTK] Fix a crash when WebKitWebView is created without a WebContext
https://bugs.webkit.org/show_bug.cgi?id=78104

Reviewed by Philippe Normand.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewSetProperty): Make sure WebKitWebView:web-context
property is initialized to the default web context when a web
context is not passed to g_object_new().

  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewDefaultContext): Check that a web view created with
g_object_new has the default context.

08:17 Changeset [107091] by commit-queue@webkit.org

Web Inspector: Optional out arguments are not supported in the Web Inspector protocol, which breaks the implementation
https://bugs.webkit.org/show_bug.cgi?id=77967

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-08
Reviewed by Yury Semikhatsky.

Condition for RefPtr-based types added. This is more-or-less a hack
and it's should be redone together with the switch to type-safe API.

  • inspector/CodeGeneratorInspector.py:

(Generator.process_command):

08:02 Changeset [107090] by commit-queue@webkit.org

[Qt][WK2] Compute and set cache capacities using the current CacheModel
https://bugs.webkit.org/show_bug.cgi?id=73918

Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-02-08
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext): Set default cacheModel for Qt platform to
CacheModelPrimaryWebBrowser.

LayoutTests:

  • platform/qt-wk2/Skipped: Unskip tests skipped for regression from r106920.
07:51 Changeset [107089] by yurys@chromium.org

Web Inspector: inspected object wrapper should be released by InjectedScript when popover closes
https://bugs.webkit.org/show_bug.cgi?id=77972

When object popover is shown the object under cursor is resolved and its
wrapper is put into 'popover' object wrapper group. The group is discarded
when the popover closes.

Reviewed by Pavel Feldman.

  • bindings/js/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::objectByHeapObjectId):

  • bindings/js/ScriptProfiler.h:

(WebCore):
(ScriptProfiler):

  • bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::objectByHeapObjectId):
(WebCore):

  • bindings/v8/ScriptProfiler.h:

(WebCore):
(ScriptProfiler):

  • inspector/Inspector.json:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::getObjectByHeapObjectId):

  • inspector/InspectorProfilerAgent.h:

(InspectorProfilerAgent):

  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotGenericObjectNode.prototype.queryObjectContent):

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype._resolveObjectForPopover):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype._resolveObjectForPopover):
(WebInspector.JavaScriptSourceFrame.prototype._onHidePopover):

  • inspector/front-end/ObjectPopoverHelper.js:

(WebInspector.ObjectPopoverHelper):
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):
(WebInspector.ObjectPopoverHelper.prototype._onHideObjectPopover):

07:51 Changeset [107088] by carlosgc@webkit.org

[GTK] Open links in a new window when clicking with the middle button in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=78099

Reviewed by Martin Robinson.

  • MiniBrowser/gtk/BrowserWindow.c:

(webViewDecidePolicy): Check whether it's a link clicked with the
middle mouse button and load the request in a new window.
(browserWindowConstructed): Connect to
WebKitWebView::decide-policy signal.

07:48 Changeset [107087] by carlosgc@webkit.org

[GTK] Fix WebKitWebView::decide-policy API documentation
https://bugs.webkit.org/show_bug.cgi?id=78101

Reviewed by Martin Robinson.

  • It refers to WebKitPolicyClient instead of WebKitWebView
  • Trailing ':' is missing
  • References @decision as WebKitNavigationPolicyDecision instead

of WebKitPolicyDecision

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_class_init):

07:38 Changeset [107086] by mario@webkit.org

[Gtk] atk_text_get_text_at_offset() fails to provide the correct line for list items whose text wraps
https://bugs.webkit.org/show_bug.cgi?id=73431

Reviewed by Chris Fleizach.

Source/WebCore:

Don't replace item's markers with the objectReplacementCharacter
character, as they will be treated in an special way later on.

  • accessibility/gtk/WebKitAccessibleInterfaceText.cpp:

(textForRenderer): Don't append the objectReplacementCharacter
character for list item's markers.

Source/WebKit/gtk:

Updated unit test to check text wrapping accross different lines
inside list items with bullet markers.

  • tests/testatk.c:

(testWebkitAtkGetTextAtOffsetWithSpecialCharacters): Updated test.

07:11 Changeset [107085] by commit-queue@webkit.org

Remote web inspector reentrancy fixes
https://bugs.webkit.org/show_bug.cgi?id=77022

Patch by Leo Franchi <lfranchi@kde.org> on 2012-02-08
Reviewed by Joseph Pecoraro.

  • WebCoreSupport/InspectorServerQt.cpp:

(WebCore::InspectorServerRequestHandlerQt::tcpReadyRead):
(WebCore::InspectorServerRequestHandlerQt::webSocketReadyRead):

06:57 Changeset [107084] by podivilov@chromium.org

Unreviewed, add chromium expectations for fast/forms/select-overflow-scroll* tests.

  • platform/chromium-linux/fast/forms/select-overflow-scroll-expected.png: Added.
  • platform/chromium-linux/fast/forms/select-overflow-scroll-expected.txt: Added.
  • platform/chromium-linux/fast/forms/select-overflow-scroll-inherited-expected.png: Added.
  • platform/chromium-linux/fast/forms/select-overflow-scroll-inherited-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-inherited-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/select-overflow-scroll-inherited-expected.txt: Added.
  • platform/chromium-win/fast/forms/select-overflow-scroll-expected.png: Added.
  • platform/chromium-win/fast/forms/select-overflow-scroll-expected.txt: Added.
  • platform/chromium-win/fast/forms/select-overflow-scroll-inherited-expected.png: Added.
  • platform/chromium-win/fast/forms/select-overflow-scroll-inherited-expected.txt: Added.
06:49 Changeset [107083] by pfeldman@chromium.org

Web Inspector: do not clear entire tree map upon last element deletion.
https://bugs.webkit.org/show_bug.cgi?id=78112

Reviewed by Yury Semikhatsky.

  • inspector/front-end/treeoutline.js:

(TreeOutline.prototype._forgetChildrenRecursive):

06:39 Changeset [107082] by commit-queue@webkit.org

Migrate createObjectURL & revokeObjectURL to static (Class) methods.
https://bugs.webkit.org/show_bug.cgi?id=74386

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2012-02-08
Reviewed by Kentaro Hara.

Source/WebCore:

Move createObjectURL & revokeObjectURL from DOMURL implementation to
static methods as per specs - http://www.w3.org/TR/FileAPI/#creating-revoking

Test: fast/dom/DOMURL/check-instanceof-domurl-functions.html
Already Existing:

fast/files/revoke-blob-url.html
fast/dom/window-domurl-crash.html
fast/files/apply-blob-url-to-img.html
fast/files/create-blob-url-crash.html
fast/files/workers/inline-worker-via-blob-url.html

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::fileThread):
(WebCore):
(WebCore::ScriptExecutionContext::publicURLManager):

  • dom/ScriptExecutionContext.h:

(WebCore):
(ScriptExecutionContext):

  • html/DOMURL.cpp:

(WebCore):
(WebCore::DOMURL::createObjectURL): Changed to static.
(WebCore::DOMURL::revokeObjectURL): ditto.

  • html/DOMURL.h:

(DOMURL):
(WebCore::DOMURL::create):

  • html/DOMURL.idl:
  • html/PublicURLManager.h: Added.

(WebCore):
(PublicURLManager):
(WebCore::PublicURLManager::create):
(WebCore::PublicURLManager::contextDestroyed):
(WebCore::PublicURLManager::blobURLs):
(WebCore::PublicURLManager::streamURLs):

  • page/DOMWindow.cpp: Removed object initialization for DOMURL.

(WebCore):

  • page/DOMWindow.h: ditto.

(DOMWindow):

  • page/DOMWindow.idl:
  • workers/WorkerContext.cpp:

(WebCore):

  • workers/WorkerContext.h:

(WorkerContext):

  • workers/WorkerContext.idl:

LayoutTests:

Added test to check if createObjectURL & revokeObjectURL are static functions.

  • fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt: Added.
  • fast/dom/DOMURL/check-instanceof-domurl-functions.html: Added.
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: GTK Rebaseline.
  • platform/gtk/fast/js/global-constructors-expected.txt: ditto.
  • platform/qt/fast/dom/constructed-objects-prototypes-expected.txt: Qt Rebaseline.
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt: ditto.
  • platform/qt/fast/js/global-constructors-expected.txt: ditto.
06:06 Changeset [107081] by podivilov@chromium.org

2012-02-08 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, chromium expectations update: mark repaint-on-image-bounds-change.svg as IMAGE+TEXT IMAGE.

  • platform/chromium/test_expectations.txt:
06:02 Changeset [107080] by podivilov@chromium.org

Unreviewed, update chromium svg expectations after r107067.

  • platform/chromium-linux/svg/filters/feImage-late-indirect-update-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-animated-transform-on-target-rect-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-change-target-id-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-late-indirect-update-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-multiple-targets-id-change-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-remove-target-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-target-attribute-change-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-target-inline-style-change-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-target-property-change-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-target-style-change-expected.png: Added.
  • platform/chromium-win/svg/filters/feImage-animated-transform-on-target-rect-expected.png: Added.
  • platform/chromium-win/svg/filters/feImage-late-indirect-update-expected.png: Added.
  • platform/chromium-win/svg/filters/feImage-multiple-targets-id-change-expected.png: Added.
  • platform/chromium-win/svg/filters/feImage-target-attribute-change-expected.png: Added.
  • platform/chromium-win/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png: Added.
  • platform/chromium-win/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png: Added.
  • platform/chromium-win/svg/filters/feImage-target-inline-style-change-expected.png: Added.
  • platform/chromium-win/svg/filters/feImage-target-property-change-expected.png: Added.
  • platform/chromium-win/svg/filters/feImage-target-style-change-expected.png: Added.
05:48 WebKitGTK/1.6.x edited by kov@webkit.org
(diff)
05:47 WebKitGTK/1.6.x edited by kov@webkit.org
(diff)
05:22 Changeset [107079] by apavlov@chromium.org

Web Inspector: Add changes for Spectrum colorpicker
https://bugs.webkit.org/show_bug.cgi?id=75454

Patch by Brian Grinstead <briangrinstead@gmail.com> on 2012-02-01
Reviewed by Pavel Feldman.

  • inspector/front-end/Color.js:

(WebInspector.Color.fromRGB):

  • inspector/front-end/utilities.js:

(Element.prototype.totalOffsetLeft):
(Element.prototype.totalOffsetTop):
(Element.prototype.totalOffset):
(Element.prototype.scrollOffset):
():

05:00 Changeset [107078] by podivilov@chromium.org

2012-02-08 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, repaint-on-image-bounds-change.svg still has wrong image in chromium.
https://bugs.webkit.org/show_bug.cgi?id=78084

  • platform/chromium/test_expectations.txt:
04:59 Changeset [107077] by philn@webkit.org

Unreviewed, GTK rebaseline and skipping 2 new failing tests.

  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
04:58 Changeset [107076] by apavlov@chromium.org

Web Inspector: Avoid an avalanche of "class" attribute modifications in WatchExpressionsSidebarPane
https://bugs.webkit.org/show_bug.cgi?id=78102

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/WatchExpressionsSidebarPane.js:

(WebInspector.WatchExpressionsSection.prototype._updateHoveredElement):

04:48 Changeset [107075] by ossy@webkit.org

[Qt] New http/tests/security/ introduced r107046 fail
https://bugs.webkit.org/show_bug.cgi?id=78093

Unskip these tests and rebaselines for Qt and GTK.

Patch by Ádám Kallai <Kallai.Adam@stud.u-szeged.hu> on 2012-02-08
Reviewed by Csaba Osztrogonác.

  • platform/gtk/Skipped:
  • platform/gtk/http/tests/security/cross-frame-access-put-expected.txt:
  • platform/qt/Skipped:
  • platform/qt/http/tests/security/cross-frame-access-put-expected.txt:
04:38 Changeset [107074] by ossy@webkit.org

[Qt] Unreviewed gardening after r107057. Update Qt specific expected results.

  • platform/qt/svg/custom/SVGPoint-matrixTransform-expected.png:
  • platform/qt/svg/custom/SVGPoint-matrixTransform-expected.txt:
  • platform/qt/svg/custom/getTransformToElement-expected.png:
  • platform/qt/svg/custom/getTransformToElement-expected.txt:
  • platform/qt/svg/custom/pointer-events-text-css-transform-expected.png:
  • platform/qt/svg/custom/pointer-events-text-css-transform-expected.txt:
  • platform/qt/svg/custom/polyline-setattribute-points-null-expected.png:
  • platform/qt/svg/custom/polyline-setattribute-points-null-expected.txt:
  • platform/qt/svg/custom/text-ctm-expected.png:
  • platform/qt/svg/custom/text-ctm-expected.txt:
  • platform/qt/svg/custom/text-hit-test-expected.png:
  • platform/qt/svg/custom/text-hit-test-expected.txt:
04:37 Changeset [107073] by zimmermann@webkit.org

2012-02-08 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Rebaseline Gtk/SVG results.

  • platform/gtk/svg/carto.net/scrollbar-expected.txt:
  • platform/gtk/svg/custom/polyline-setattribute-points-null-expected.txt:
04:34 Changeset [107072] by commit-queue@webkit.org

CSS2 overflow: scrollbar not visible on SELECT elements when overflow: scroll is set.
https://bugs.webkit.org/show_bug.cgi?id=69993

Patch by Antaryami Pandia <antaryami.pandia@motorola.com> on 2012-02-08
Reviewed by Simon Fraser.

Source/WebCore:

The issue was that for overflow:scroll, currently webkit always places the horizontal
and vertical scrollbar. But Since the listbox renderer handles its scrolling,
we should not set scrollbar for list-box.

Tests: fast/css/getComputedStyle/computed-style-select-overflow.html

fast/forms/select-overflow-scroll-inherited.html
fast/forms/select-overflow-scroll.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateScrollInfoAfterLayout):

LayoutTests:

  • fast/css/getComputedStyle/computed-style-select-overflow-expected.txt: Added.
  • fast/css/getComputedStyle/computed-style-select-overflow.html: Added.
  • fast/forms/select-overflow-scroll-inherited.html: Added.
  • fast/forms/select-overflow-scroll.html: Added.
  • platform/gtk/fast/forms/select-overflow-scroll-expected.txt: Added.
  • platform/gtk/fast/forms/select-overflow-scroll-inherited-expected.txt: Added.
04:31 Changeset [107071] by zimmermann@webkit.org

qt fixes

04:24 Changeset [107070] by mahesh.kulkarni@nokia.com

[Qt] Build broken if qt missing openssl
https://bugs.webkit.org/show_bug.cgi?id=77894

Reviewed by Chang Shu.

Build fix. No new test content.

  • WebProcess/qt/QtNetworkAccessManager.cpp:

(WebKit::QtNetworkAccessManager::onSslErrors):

04:18 Changeset [107069] by haraken@chromium.org

Unreviewed. Rebaselined the test that has been failing since r107046.

  • http/tests/security/cross-frame-access-put-expected.txt:
04:13 Changeset [107068] by yael.aharon@nokia.com

[WK2] Text notifications should have an iconURL
https://bugs.webkit.org/show_bug.cgi?id=77968

Reviewed by Simon Hausmann.

Per http://www.w3.org/TR/notifications simple text notifications should have an iconURL.
Add an iconURL to WebNotification and add a public API to access it.

  • UIProcess/API/C/WKNotification.cpp:

(WKNotificationCopyiconURL):

  • UIProcess/API/C/WKNotification.h:
  • UIProcess/Notifications/WebNotification.cpp:

(WebKit::WebNotification::WebNotification):

  • UIProcess/Notifications/WebNotification.h:

(WebKit::WebNotification::create):
(WebKit::WebNotification::iconURL):
(WebNotification):

  • UIProcess/Notifications/WebNotificationManagerProxy.cpp:

(WebKit::WebNotificationManagerProxy::show):

  • UIProcess/Notifications/WebNotificationManagerProxy.h:

(WebNotificationManagerProxy):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showNotification):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::show):

04:12 Changeset [107067] by zimmermann@webkit.org

feImage doesn't invalidate when its target SVG element is animated
https://bugs.webkit.org/show_bug.cgi?id=73860

Reviewed by Dirk Schulze.

Source/WebCore:

Consider following testcase:
<defs>

<rect id="rect" fill="red" width="50" height="50"/>
<filter id="filter">

<feImage xlink:href="#rect"/>

</filter>

</defs>
<rect width="50" height="50" filter="url(#filter)"/>

If the <rect id="rect"> gets changed dynamically (attribute/property/style change) the <feImage>
doesn't notice this, as there's no link between the <rect> and the <feImage>, as the <rect> is not
a child of the <feImage/>. To get invalidations working for these situations, we have to track
the referencingElement & referencedElement in SVGDocumentExtensions.

Fixes parts the SVG-Wow twirl testcase and David Daileys SVG waves example.

Tests: svg/filters/feImage-animated-transform-on-target-rect.svg

svg/filters/feImage-late-indirect-update.svg
svg/filters/feImage-mutliple-targets-id-change.svg
svg/filters/feImage-target-attribute-change-with-use-indirection-2.svg
svg/filters/feImage-target-attribute-change-with-use-indirection.svg
svg/filters/feImage-target-attribute-change.svg
svg/filters/feImage-target-inline-style-change.svg
svg/filters/feImage-target-property-change.svg
svg/filters/feImage-target-style-change.svg

  • rendering/svg/RenderSVGResource.cpp:

(WebCore::removeFromFilterCacheAndInvalidateDependencies): Renamed from removeFromFilterCache, as it has another purpose now.
(WebCore::RenderSVGResource::markForLayoutAndParentResourceInvalidation): s/removeFromFilterCache/removeFromFilterCacheAndInvalidateDependencies/.

  • rendering/svg/RenderSVGResource.h: Removed removeFromFilterCache, it got inlined.
  • svg/SVGDocumentExtensions.cpp: Add a new HashMap<SVGElement*, OwnPtr<HashSet<SVGElement*> > > used for dependency tracking.

(WebCore::SVGDocumentExtensions::setOfElementsReferencingTarget): Returns all elements the passed in element depends on.
(WebCore::SVGDocumentExtensions::addElementReferencingTarget): Register element 'a' referencing target 'b'.
(WebCore::SVGDocumentExtensions::removeAllTargetReferencesForElement): Called by element 'a' on destruction or any target change.
(WebCore::SVGDocumentExtensions::removeAllElementReferencesForTarget): Called by element 'b' on destruction.

  • svg/SVGDocumentExtensions.h: Expose new methods.
  • svg/SVGElement.cpp:

(WebCore::SVGElement::~SVGElement): Call remove removeAllElementReferencesForTarget on destruction.

  • svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::clearResourceReferences):
(WebCore::SVGFEImageElement::buildPendingResource):

LayoutTests:

Add lots of new testcases covering <feImage> invalidation, when the referenced target changes.
Thanks to the repaint harness, it uncovered a bug with feImage-late-indirect-update.svg - there no gray
overlay rects are visible, as the whole screen gets repainted, which is a bug!

  • platform/mac/svg/filters/feImage-animated-transform-on-target-rect-expected.png: Added.
  • platform/mac/svg/filters/feImage-change-target-id-expected.png: Added.
  • platform/mac/svg/filters/feImage-change-target-id-expected.txt: Added.
  • platform/mac/svg/filters/feImage-late-indirect-update-expected.png: Added.
  • platform/mac/svg/filters/feImage-late-indirect-update-expected.txt: Added.
  • platform/mac/svg/filters/feImage-multiple-targets-id-change-expected.png: Added.
  • platform/mac/svg/filters/feImage-multiple-targets-id-change-expected.txt: Added.
  • platform/mac/svg/filters/feImage-remove-target-expected.png: Added.
  • platform/mac/svg/filters/feImage-remove-target-expected.txt: Added.
  • platform/mac/svg/filters/feImage-target-add-to-document-expected.png: Renamed from LayoutTests/svg/filters/feImage-target-add-to-document-expected.png.
  • platform/mac/svg/filters/feImage-target-add-to-document-expected.txt: Copied from LayoutTests/svg/filters/feImage-target-add-to-document-expected.txt.
  • platform/mac/svg/filters/feImage-target-attribute-change-expected.png: Added.
  • platform/mac/svg/filters/feImage-target-attribute-change-expected.txt: Copied from LayoutTests/svg/filters/feImage-target-changes-id-expected.txt.
  • platform/mac/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png: Added.
  • platform/mac/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.txt: Added.
  • platform/mac/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png: Added.
  • platform/mac/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.txt: Added.
  • platform/mac/svg/filters/feImage-target-changes-id-expected.png: Renamed from LayoutTests/svg/filters/feImage-target-changes-id-expected.png.
  • platform/mac/svg/filters/feImage-target-changes-id-expected.txt: Copied from LayoutTests/svg/filters/feImage-target-changes-id-expected.txt.
  • platform/mac/svg/filters/feImage-target-id-change-expected.png: Renamed from LayoutTests/svg/filters/feImage-target-id-change-expected.png.
  • platform/mac/svg/filters/feImage-target-id-change-expected.txt: Renamed from LayoutTests/svg/filters/feImage-target-id-change-expected.txt.
  • platform/mac/svg/filters/feImage-target-inline-style-change-expected.png: Added.
  • platform/mac/svg/filters/feImage-target-inline-style-change-expected.txt: Copied from LayoutTests/svg/filters/feImage-target-changes-id-expected.txt.
  • platform/mac/svg/filters/feImage-target-property-change-expected.png: Added.
  • platform/mac/svg/filters/feImage-target-property-change-expected.txt: Copied from LayoutTests/svg/filters/feImage-target-changes-id-expected.txt.
  • platform/mac/svg/filters/feImage-target-reappend-to-document-expected.png: Renamed from LayoutTests/svg/filters/feImage-target-reappend-to-document-expected.png.
  • platform/mac/svg/filters/feImage-target-reappend-to-document-expected.txt: Renamed from LayoutTests/svg/filters/feImage-target-reappend-to-document-expected.txt.
  • platform/mac/svg/filters/feImage-target-remove-from-document-expected.png: Renamed from LayoutTests/svg/filters/feImage-target-remove-from-document-expected.png.
  • platform/mac/svg/filters/feImage-target-remove-from-document-expected.txt: Renamed from LayoutTests/svg/filters/feImage-target-remove-from-document-expected.txt.
  • platform/mac/svg/filters/feImage-target-style-change-expected.png: Added.
  • platform/mac/svg/filters/feImage-target-style-change-expected.txt: Renamed from LayoutTests/svg/filters/feImage-target-changes-id-expected.txt.
  • svg/filters/feImage-animated-transform-on-target-rect-expected.txt: Added.
  • svg/filters/feImage-animated-transform-on-target-rect.svg: Added.
  • svg/filters/feImage-change-target-id.svg: Added.
  • svg/filters/feImage-late-indirect-update.svg: Added.
  • svg/filters/feImage-multiple-targets-id-change.svg: Added.
  • svg/filters/feImage-remove-target.svg: Added.
  • svg/filters/feImage-target-attribute-change-with-use-indirection-2.svg: Added.
  • svg/filters/feImage-target-attribute-change-with-use-indirection.svg: Added.
  • svg/filters/feImage-target-attribute-change.svg: Added.
  • svg/filters/feImage-target-inline-style-change.svg: Added.
  • svg/filters/feImage-target-property-change.svg: Added.
  • svg/filters/feImage-target-style-change.svg: Added.
04:02 Changeset [107066] by ossy@webkit.org

[Qt] Unreviewed gardening. Unskip now passing tests, skip failing tests and one update.

  • platform/qt/Skipped:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
03:53 Changeset [107065] by commit-queue@webkit.org

[EFL] Using string method instead of char* operation in the platformLanguage().
https://bugs.webkit.org/show_bug.cgi?id=78077

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-02-08
Reviewed by Andreas Kling.

No new tests. Just fix a bug of platformLanguage function.

  • platform/efl/LanguageEfl.cpp:

(WebCore::platformLanguage):
Change char* operation to string operation.

03:40 Changeset [107064] by rniwa@webkit.org

Revert a part of the change in r106687 as a build fix.

Since Chromium port doesn't checkout the entire WebKit trunk,
we can't run "svn info" on webkit_base.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.repository_paths):

03:15 Changeset [107063] by haraken@chromium.org

Unreviewed. Skip http/tests/security/cross-frame-access-put.html in qt and gtk.
The test needs rebaselining.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
03:13 Changeset [107062] by apavlov@chromium.org

Web Inspector: Touch event emulation fails for iframes
https://bugs.webkit.org/show_bug.cgi?id=77987

Reviewed by Pavel Feldman.

Source/WebCore:

Test: fast/events/touch/emulated-touch-iframe.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseReleaseEvent):

LayoutTests:

  • fast/events/touch/emulated-touch-iframe-expected.txt: Added.
  • fast/events/touch/emulated-touch-iframe.html: Added.
  • fast/events/touch/resources/emulated-touch-iframe2.html: Added.
03:03 Changeset [107061] by kling@webkit.org

StyledElement: Manully setNeedsStyleRecalc() after adding CSSProperties directly.
<http://webkit.org/b/78068>

Rubber-stamped by Ryosuke Niwa.

Turns out that setProperty() with a CSSProperty has quite different behavior from
the other setProperty() methods. We should probably clean that up (separately.)
For now, simply call setNeedsStyleRecalc() manually in the addCSS* functions that
use setProperty(CSSProperty).

  • dom/StyledElement.cpp:

(WebCore::StyledElement::addCSSProperty):
(WebCore::StyledElement::addCSSImageProperty):

02:55 Changeset [107060] by morrita@google.com

Unreviewed, rolling out r107050.
http://trac.webkit.org/changeset/107050
https://bugs.webkit.org/show_bug.cgi?id=78094

May crash editing tests (Requested by morrita on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-08

  • html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::createShadowSubtree):

  • html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::HTMLKeygenElement):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::createShadowSubtree):

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::createShadowSubtree):

  • html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::createShadowSubtree):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::createShadowSubtree):

02:42 Changeset [107059] by ossy@webkit.org

[Qt] REGRESSION(r106918): It made svg/zoom/page/zoom-foreignObject.svg crash with Qt5-WK1
https://bugs.webkit.org/show_bug.cgi?id=77995

Patch by Nikolas Zimmermann <nzimmermann@rim.com> on 2012-02-08
Reviewed by Csaba Osztrogonác.

Source/WebCore:

From the stack traces it's obvious that SVGImageChromeClient tried to invalidate the root view,
while its SVGImage was being destructed, due to an updateStyleIfNeeded() call, coming
from frameDetached(). There's no point in redrawing there, so we should just stop it.

Covered by existing tests on the Qt but, unfortunately I couldn't reproduce it on Mac.

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImageChromeClient::invalidateContentsAndRootView): Stop invalidating if m_page is 0.
(WebCore::SVGImage::~SVGImage): Clear m_page, so that SVGImageChromeClient knows we're destructing.

  • svg/graphics/SVGImage.h:

LayoutTests:

  • platform/qt/Skipped: Unskip previously skipped tests.
02:39 Changeset [107058] by commit-queue@webkit.org

Add state attribute to history's dom interface.
https://bugs.webkit.org/show_bug.cgi?id=76035

Patch by Pablo Flouret <pablof@motorola.com> on 2012-02-08
Reviewed by Kentaro Hara.

Source/WebCore:

Tests: fast/loader/stateobjects/state-attribute-object-types.html

fast/loader/stateobjects/state-attribute-only-one-deserialization.html

  • bindings/js/JSHistoryCustom.cpp:

(WebCore::JSHistory::state):
(WebCore):
(WebCore::JSHistory::pushState):
(WebCore::JSHistory::replaceState):

  • bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::stateAccessorGetter):
(WebCore):
(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):

  • page/History.cpp:

(WebCore::History::History):
(WebCore::History::state):
(WebCore):
(WebCore::History::stateInternal):
(WebCore::History::stateChanged):

  • page/History.h:

(History):

  • page/History.idl:

LayoutTests:

  • fast/dom/Window/window-appendages-cleared-expected.txt:
  • fast/loader/stateobjects/state-attribute-object-types-expected.txt: Added.
  • fast/loader/stateobjects/state-attribute-object-types.html: Added.
  • fast/loader/stateobjects/state-attribute-only-one-deserialization-expected.txt: Added.
  • fast/loader/stateobjects/state-attribute-only-one-deserialization.html: Added.
02:21 Changeset [107057] by zimmermann@webkit.org

SVGLoad event fires too early
https://bugs.webkit.org/show_bug.cgi?id=78084

Reviewed by Hajime Morita.

Source/WebCore:

SVGLoad event fires too early, making it impossible to use the vanilla repaint.js harness (runRepaintTest).

We're using a hack called runSVGRepaintTest() at the moment in trunk, which runs runRepaintTest() from a 0ms timer,
which is not reliable. The main difference between HTML onload and SVG onload is that HTMLs event is a "window event",
thus dispatched through DOMWindow (eg. <body onload="alert(event.target)" will yield Document,
<svg onload="alert(evt.target)"> will say SVGSVGElement).

Consider:
<svg onload="alert('1')>
<g onload="alert('2)">
<rect onload="alert('3')"/>
</svg>

As soon as the <rect> finishes parsing (SVGElement::finishedParsingChildren), it's SVGLoad event is fired.
So first you'll see '3', then '2', then '1'.

Using:
<svg onload="alert('1')>
<g onload="alert('2)">
<image xlink:href="someExternal.jpg" onload="alert('3')"/>
</svg>

will yield the same SVGLoad order. When using <image externalREsourcesRequired="true", first the '1' will fire,
then '3', then '2', all as expected and specified in SVG.

http://www.w3.org/TR/SVG/interact.html#LoadEvent says:
"The event is triggered at the point at which the user agent has fully parsed the element and its descendants and is
ready to act appropriately upon that element, such as being ready to render the element to the target device. Referenced
external resources that are required must be loaded, parsed and ready to render before the event is triggered. Optional
external resources are not required to be ready for the event to be triggered."

What we don't implement correctly is the second part of the first sentence: "and is ready to act appropriately upon that
element, such as being ready to render the element to the target device". We currently fire the SVGLoad event, right after
</svg> is seen, if no externalResourceRequired="true" attributes are set anywhere. This is not wrong, but not correct for
WebKit, as we're not yet "ready to render".

HTML fires its window onload event from Document::implicitClose(), where it calls Document::dispatchWindowLoadEvent.
At this point we're ready to render. So I'm now aligning the timing of the outermost <svg> elements SVGLoad event, to be
equal to HTML. This lets use use the repaint.js harness w/o any special SVG tricks.

Covered by existing tests.

  • dom/Document.cpp:

(WebCore::Document::implicitClose): Dispatch SVGLoad event for outermost <svg> elements from here, as HTML does for its window onload event.

  • svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::dispatchSVGLoadEventToOutermostSVGElements): Sends a SVGLoad event to all outermost <svg> elements in a document, if possible.
There can be multiple ones, if using <svg><foreignObject><svg>... - the <svg> in the <fO> also acts as outermost <svg> element.

  • svg/SVGDocumentExtensions.h: Add new dispatchSVGLoadEventToOutermostSVGElements() helper.
  • svg/SVGElement.cpp:

(WebCore::SVGElement::isOutermostSVGSVGElement): Moved from SVGSVGElement into SVGElement, and renamed from isOutermostSVG().
(WebCore::SVGElement::sendSVGLoadEventIfPossible): Don't dispatch load events to outermost <svg> elements, if Document::implicitClose() wasn't called yet.
(WebCore::SVGElement::finishParsingChildren): Stop using the default SVGLoad dispatching logic for outermost <svg> elements.

  • svg/SVGElement.h: Add isOutermostSVGSVGElement().
  • svg/SVGSVGElement.cpp: Rename isOutermostSVG to isOutermostSVGSVGElement.

(WebCore::SVGSVGElement::currentScale):
(WebCore::SVGSVGElement::setCurrentScale):
(WebCore::SVGSVGElement::localCoordinateSpaceTransform):
(WebCore::SVGSVGElement::createRenderer):

  • svg/SVGSVGElement.h: Move isOutermostSVG() to SVGElement.
  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::title): Rename isOutermostSVG to isOutermostSVGSVGElement.

LayoutTests:

Remove runSVGRepaintTest() from repaint.js again, and convert all *.svg tests to use runRepaintTest() directly.
This is now possible as the outermost <svg> elements load event timing as aligned with HTML.

  • fast/repaint/resources/repaint.js: Remove runSVGRepaintTest(), it's no longer needed.

(runRepaintTest): s/document.rootElement/document.documentElement/ to make it work for all HTML/XHTML and SVG documents (XHTML was broken).

  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/custom/SVGPoint-matrixTransform-expected.png:
  • platform/mac/svg/custom/SVGPoint-matrixTransform-expected.txt:
  • platform/mac/svg/custom/getTransformToElement-expected.png:
  • platform/mac/svg/custom/getTransformToElement-expected.txt:
  • platform/mac/svg/custom/polyline-setattribute-points-null-expected.png:
  • platform/mac/svg/custom/polyline-setattribute-points-null-expected.txt:
  • platform/mac/svg/custom/text-ctm-expected.png:
  • platform/mac/svg/custom/text-ctm-expected.txt:
  • platform/mac/svg/custom/text-hit-test-expected.png:
  • platform/mac/svg/custom/text-hit-test-expected.txt:
  • platform/mac/svg/filters/filter-refresh-expected.png:
  • svg/carto.net/tabgroup.svg:
  • svg/carto.net/window.svg:
  • svg/css/shadow-changes.svg:
  • svg/custom/loadevents-externalresourcesrequired.svg:
  • svg/dom/SVGPathSegList-segment-modification.svg:
  • svg/dom/SVGPathSegList-xml-dom-synchronization2.xhtml:
  • svg/dom/SVGRectElement/rect-modify-rx.svg:
  • svg/filters/animate-fill.svg:
  • svg/filters/feImage-reference-invalidation.svg:
  • svg/filters/feImage-target-add-to-document.svg:
  • svg/filters/feImage-target-changes-id.svg:
  • svg/filters/feImage-target-id-change.svg:
  • svg/filters/feImage-target-reappend-to-document.svg:
  • svg/filters/feImage-target-remove-from-document.svg:
  • svg/filters/filter-refresh.svg:
  • svg/filters/filter-width-update.svg:
  • svg/filters/invalidate-on-child-layout.svg:
  • svg/hixie/perf/001.xml:
  • svg/hixie/perf/002.xml:
  • svg/hixie/perf/003.xml:
  • svg/hixie/perf/004.xml:
  • svg/hixie/perf/005.xml:
  • svg/hixie/perf/006.xml:
  • svg/hixie/perf/007.xml:
  • svg/repaint/container-repaint.svg:
  • svg/repaint/filter-child-repaint.svg:
  • svg/repaint/image-href-change.svg:
  • svg/repaint/image-with-clip-path.svg:
  • svg/text/text-text-05-t.svg:
  • svg/zoom/page/absolute-sized-document-no-scrollbars.svg:
  • svg/zoom/page/absolute-sized-document-scrollbars.svg:
  • svg/zoom/page/relative-sized-document-scrollbars.svg:
  • svg/zoom/page/zoom-coords-viewattr-01-b.svg:
  • svg/zoom/page/zoom-foreignObject.svg:
  • svg/zoom/page/zoom-mask-with-percentages.svg:
  • svg/zoom/resources/testPageZoom.js:

(repaintTest):

  • svg/zoom/text/absolute-sized-document-no-scrollbars.svg:
  • svg/zoom/text/absolute-sized-document-scrollbars.svg:
  • svg/zoom/text/relative-sized-document-scrollbars.svg:
  • svg/zoom/text/zoom-coords-viewattr-01-b.svg:
  • svg/zoom/text/zoom-foreignObject.svg:
02:11 Changeset [107056] by apavlov@chromium.org

Web Inspector: [CRASH] InspectorDOMAgent::updateTouchEventEmulationInPage()
https://bugs.webkit.org/show_bug.cgi?id=78090

Reviewed by Vsevolod Vlasov.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::updateTouchEventEmulationInPage):

02:00 Changeset [107055] by apavlov@chromium.org

Web Inspector: Closed computed style sidebar pane rebuilds, resulting in slowness
https://bugs.webkit.org/show_bug.cgi?id=77865

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/styles/lazy-computed-style.html

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane):
(WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._refreshComputedStyleSection):
(WebInspector.ComputedStyleSidebarPane.prototype.expand):
(WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):

LayoutTests:

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.selectNodeAndWaitForStylesWithComputed.stylesCallback):
(initialize_ElementTest.InspectorTest.selectNodeAndWaitForStylesWithComputed):

  • inspector/elements/elements-panel-styles.html:
  • inspector/styles/css-live-edit.html:
  • inspector/styles/lazy-computed-style-expected.txt: Added.
  • inspector/styles/lazy-computed-style.html: Added.
  • inspector/styles/styles-computed-trace.html:
01:52 Changeset [107054] by tommyw@google.com

MediaStream API: Adding the onstatechange callback to PeerConnection
https://bugs.webkit.org/show_bug.cgi?id=77954

When readyState changes a callback should be triggered.

Reviewed by Adam Barth.

Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.

  • dom/EventNames.h:

(WebCore):

  • mediastream/PeerConnection.cpp:

(WebCore::PeerConnection::changeReadyState):

  • mediastream/PeerConnection.h:

(PeerConnection):
(WebCore::PeerConnection::didChangeState):

  • mediastream/PeerConnection.idl:
  • platform/mediastream/PeerConnectionHandlerClient.h:

(PeerConnectionHandlerClient):

01:51 Changeset [107053] by rniwa@webkit.org

run-perf-tests doesn't recognize paths that start with PerformanceTests
https://bugs.webkit.org/show_bug.cgi?id=78012

Reviewed by Adam Barth.

Use resolve paths using filesystem.relpath before passing it to find_files.find.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner):
(PerfTestsRunner._collect_tests):

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(test_collect_tests):
(test_collect_tests.add_file):

01:17 Changeset [107052] by ossy@webkit.org

Unreviewed gardening after r106982.
Skip a new test because of missing AuthenticationChallenges support.

  • platform/qt/Skipped:
  • platform/wk2/Skipped:
00:57 Changeset [107051] by haraken@chromium.org

Rename [DelegatingPutFunction] IDL to [CustomNamedSetter] IDL
https://bugs.webkit.org/show_bug.cgi?id=77963

Reviewed by Adam Barth.

This patch renames [DelegatingPutFunction] IDL to [CustomNamedSetter] IDL,
for clarification and for naming consistency with [NamedGetter] and [CustomIndexedSetter].

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateImplementationIndexer):
(GenerateImplementationNamedPropertyGetter):

  • bindings/scripts/test/TestInterface.idl:
  • css/CSSStyleDeclaration.idl:
  • dom/DOMStringMap.idl:
  • html/HTMLAppletElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLObjectElement.idl:
  • page/History.idl:
  • page/Location.idl:
  • storage/Storage.idl:
00:57 Changeset [107050] by commit-queue@webkit.org

Stop calling Element::ensureShadowRoot() if it is used in construction phase.
https://bugs.webkit.org/show_bug.cgi?id=77929

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-08
Reviewed by Hajime Morita.

ShadowRoot's life cycle can be consufing If Element::ensureShadowRoot() is used.
So we want to remove Element::ensureShadowRoot().
This patch replaces Element::ensureShadowRoot() if it is used in object construction phase.

No new tests, no change in behavior.

  • html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::createShadowSubtree):

  • html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::HTMLKeygenElement):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::createShadowSubtree):

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::createShadowSubtree):

  • html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::createShadowSubtree):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::createShadowSubtree):

00:47 Changeset [107049] by zimmermann@webkit.org

2012-02-08 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Add missing results for a new SVG test.

  • platform/mac/svg/custom/use-disappears-after-style-update-expected.png: Added.
  • platform/mac/svg/custom/use-disappears-after-style-update-expected.txt: Added.
00:37 Changeset [107048] by podivilov@chromium.org

2012-02-08 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, remove deleted touch-gesture-scroll.html test from test_expectations.txt.

  • platform/chromium/test_expectations.txt:
00:29 Changeset [107047] by dmazzoni@google.com

Unreviewed, updating expectations to SKIP test that times out or crashes on most platforms.

00:13 Changeset [107046] by haraken@chromium.org

Replace [CheckNodeSecurity] with [CheckAccessToNode]
https://bugs.webkit.org/show_bug.cgi?id=77971

Reviewed by Adam Barth.

Source/WebCore:

[CheckNodeSecurity] is not implemented by code generators.
This patch replaces [CheckNodeSecurity] with [CheckAccessToNode].

Test: http/tests/security/cross-frame-access-frameelement.html

  • page/DOMWindow.idl:

LayoutTests:

The added test checks if frameElement is accessible from the same or cross origin iframe.

  • http/tests/security/cross-frame-access-frameelement-expected.txt: Added.
  • http/tests/security/cross-frame-access-frameelement.html: Added.
  • http/tests/security/resources/cross-frame-access-frameelement-from-iframe.html: Added.
  • platform/chromium/http/tests/security/cross-frame-access-put-expected.txt: Updated the test result.
00:05 Changeset [107045] by haraken@chromium.org

Rename [CustomPushEventHandlerScope] to [JSCustomPushEventHandlerScope]
https://bugs.webkit.org/show_bug.cgi?id=78081

Reviewed by Adam Barth.

[CustomPushEventHandlerScope] is a JSC-specific IDL attribute.
This patch renames it to [JSCustomPushEventHandlerScope]

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

  • dom/Node.idl:
  • html/HTMLElement.idl:
00:05 Changeset [107044] by philn@webkit.org

[GTK][WK2] enable-webaudio WebSetting
https://bugs.webkit.org/show_bug.cgi?id=77959

Reviewed by Martin Robinson.

Add a new WebKitGTK WebSetting to enable/disable WebAudio at
runtime.

  • UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_get_enable_webaudio):
(webkit_settings_set_enable_webaudio):

  • UIProcess/API/gtk/WebKitSettings.h:
  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings):

02/07/12:

23:21 Changeset [107043] by mrobinson@webkit.org

[GTK] [WK2] Add WebKitResponsePolicyDecision
https://bugs.webkit.org/show_bug.cgi?id=76789

Reviewed by Philippe Normand.

Add a WebKitResponsePolicyDecision GObject, use it for response
policy decisions and add a test.

  • GNUmakefile.am: Added new source files to the list.
  • UIProcess/API/gtk/WebKitPolicyClient.cpp:

(decidePolicyForResponseCallback): Added this callback which creates the request
and fires the signal.
(attachPolicyClientToPage): Added new callback to the C API policy client.

  • UIProcess/API/gtk/WebKitResponsePolicyDecision.cpp: Added.
  • UIProcess/API/gtk/WebKitResponsePolicyDecision.h: Added.
  • UIProcess/API/gtk/WebKitResponsePolicyDecisionPrivate.h: Added.
  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Added new docs.
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Ditto.
  • UIProcess/API/gtk/tests/TestWebKitPolicyClient.cpp:

(testResponsePolicy): Added this test for response policy decisions.
(serverCallback): Added a SoupServer to test policy response policy decisions.
(beforeAll): Ditto.
(afterAll): Ditto.

22:56 Changeset [107042] by commit-queue@webkit.org

[chromium] Move geometry headers in Platform API to Platform directory
https://bugs.webkit.org/show_bug.cgi?id=78067

Patch by James Robinson <jamesr@chromium.org> on 2012-02-07
Reviewed by Adam Barth.

Source/Platform:

This moves several geometry-related headers in the chromium WebKit platform API to Platform/chromium/public.
These require a bit of extra work since when WEBKIT_IMPLEMENTATION is set they #include headers from
WebCore/platform such as IntPoint so that the implementations of several functions can be inlined. Since we do
not want to add anything in WebCore to the include path of projects that depend on the Platform API this poses a
bit of an issue. I've added an extra build step to copy the specific headers used into the
SHARED_INTERMEDIATE_DIR to preserve this inlining.

Eventually we'll move the cross-platform code, including these headers, into somewhere under Platform/, but doing
that requires non-trivial modifications to every build system in WebKit.

  • Platform.gyp/Platform.gyp:
  • Platform.gyp/copy_webcore_headers.py: Added.

(CopyHeaders):
(Main):

  • chromium/public/WebFloatPoint.h: Copied from Source/WebKit/chromium/public/platform/WebFloatPoint.h.

(WebKit):
(WebFloatPoint):
(WebKit::WebFloatPoint::WebFloatPoint):
(WebKit::WebFloatPoint::operator=):
(WebKit::WebFloatPoint::operator WebCore::FloatPoint):
(WebKit::operator==):
(WebKit::operator!=):

  • chromium/public/WebFloatQuad.h: Copied from Source/WebKit/chromium/public/platform/WebFloatQuad.h.

(WebKit):
(WebFloatQuad):
(WebKit::WebFloatQuad::WebFloatQuad):
(WebKit::WebFloatQuad::operator=):

  • chromium/public/WebFloatRect.h: Copied from Source/WebKit/chromium/public/platform/WebFloatRect.h.

(WebKit):
(WebFloatRect):
(WebKit::WebFloatRect::isEmpty):
(WebKit::WebFloatRect::WebFloatRect):
(WebKit::WebFloatRect::operator=):
(WebKit::WebFloatRect::operator WebCore::FloatRect):
(WebKit::operator==):
(WebKit::operator!=):

  • chromium/public/WebPoint.h: Copied from Source/WebKit/chromium/public/platform/WebPoint.h.

(WebKit):
(WebPoint):
(WebKit::WebPoint::WebPoint):
(WebKit::WebPoint::operator=):
(WebKit::WebPoint::operator WebCore::IntPoint):
(WebKit::WebPoint::operator gfx::Point):
(WebKit::operator==):
(WebKit::operator!=):

  • chromium/public/WebRect.h: Copied from Source/WebKit/chromium/public/platform/WebRect.h.

(WebKit):
(WebRect):
(WebKit::WebRect::isEmpty):
(WebKit::WebRect::WebRect):
(WebKit::WebRect::operator=):
(WebKit::WebRect::operator WebCore::IntRect):
(WebKit::WebRect::operator gfx::Rect):
(WebKit::operator==):
(WebKit::operator!=):

  • chromium/public/WebSize.h: Copied from Source/WebKit/chromium/public/platform/WebSize.h.

(WebKit):
(WebSize):
(WebKit::WebSize::isEmpty):
(WebKit::WebSize::WebSize):
(WebKit::WebSize::operator=):
(WebKit::WebSize::operator WebCore::IntSize):
(WebKit::WebSize::operator gfx::Size):
(WebKit::operator==):
(WebKit::operator!=):

Source/WebKit/chromium:

Add forwarding headers for several API types moved into Platform.

  • public/platform/WebFloatPoint.h:
  • public/platform/WebFloatQuad.h:
  • public/platform/WebFloatRect.h:
  • public/platform/WebPoint.h:
  • public/platform/WebRect.h:
  • public/platform/WebSize.h:
22:40 Changeset [107041] by haraken@chromium.org

Add "JS" prefix to JSC-specific IDLs
https://bugs.webkit.org/show_bug.cgi?id=77846

Reviewed by Darin Adler.

In bug 77693, we have added "JS" prefix to several JSC specific IDLs.
This patch adds "JS" prefix to the remaining JSC specific IDLs.
Specifically, this patch renames IDLs as follows:

[CustomDefineOwnProperty] => [JSCustomDefineOwnProperty]
[CustomPrototypeDefineOwnProperty] => [JSCustomPrototypeDefineOwnProperty]
[GenerateNativeConverter] => [JSGenerateToNativeObject] (Note: For naming consistency
with [JSGenerateToJS] and [JSCustomToNativeObject])
[DelegatingGetOwnPropertySlot] => [JSCustomGetOwnPropertySlotDelegate] (Note: Should be prefixed "JS",
should be prefixed with "Custom", and for naming consistency with [CustomGetOwnPropertySlot])

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/test/TestTypedArray.idl:
  • dom/Attr.idl:
  • dom/DataTransferItemList.idl:
  • dom/Document.idl:
  • dom/DocumentType.idl:
  • dom/Element.idl:
  • dom/Node.idl:
  • fileapi/DirectoryEntry.idl:
  • fileapi/DirectoryEntrySync.idl:
  • fileapi/File.idl:
  • fileapi/FileEntry.idl:
  • fileapi/FileEntrySync.idl:
  • fileapi/WebKitBlobBuilder.idl:
  • html/DOMFormData.idl:
  • html/DOMURL.idl:
  • html/HTMLAppletElement.idl:
  • html/HTMLCanvasElement.idl:
  • html/HTMLElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLImageElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLOptionElement.idl:
  • html/HTMLOptionsCollection.idl:
  • html/HTMLTableCaptionElement.idl:
  • html/HTMLTableSectionElement.idl:
  • html/HTMLVideoElement.idl:
  • html/TextTrackCue.idl:
  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • html/canvas/Uint8ClampedArray.idl:
  • mediastream/LocalMediaStream.idl:
  • page/DOMWindow.idl:
  • page/History.idl:
  • page/Location.idl:
  • storage/StorageInfo.idl:
  • svg/SVGElement.idl:
  • svg/SVGElementInstance.idl:
  • workers/DedicatedWorkerContext.idl:
  • workers/SharedWorker.idl:
  • workers/SharedWorkerContext.idl:
  • workers/Worker.idl:
  • workers/WorkerContext.idl:
22:33 Changeset [107040] by morrita@google.com

[Chromium] WebTextCheckingResult should have new default constructor
https://bugs.webkit.org/show_bug.cgi?id=78066

Reviewed by Ryosuke Niwa.

Added a new default constructor. ex-default constructor will be removed
in an upcoming change.

  • public/WebTextCheckingResult.h:

(WebKit::WebTextCheckingResult::WebTextCheckingResult):
(WebTextCheckingResult):

21:47 Changeset [107039] by haraken@chromium.org

Rename [HasOverridingNameGetter] attribute to [CustomNamedGetter] attribute
https://bugs.webkit.org/show_bug.cgi?id=78076

Reviewed by Adam Barth.

This patch renames the [HasOverridingNameGetter] attribute to the
[CustomNamedGetter] attribute, for naming consistency with [CustomNamedSetter].

Test: bindings/scripts/test/TestCustomNamedGetter.idl

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateImplementationNamedPropertyGetter):

  • html/HTMLDocument.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLFrameSetElement.idl:
  • bindings/scripts/test/TestCustomNamedGetter.idl: Renamed from Source/WebCore/bindings/scripts/test/TestOverridingNameGetter.idl.
  • bindings/scripts/test/CPP/WebDOMTestCustomNamedGetter.cpp: Updated run-bindings-tests results.

(WebDOMTestCustomNamedGetter::WebDOMTestCustomNamedGetterPrivate::WebDOMTestCustomNamedGetterPrivate):
(WebDOMTestCustomNamedGetter::WebDOMTestCustomNamedGetterPrivate):
(WebDOMTestCustomNamedGetter::WebDOMTestCustomNamedGetter):
(WebDOMTestCustomNamedGetter::operator=):
(WebDOMTestCustomNamedGetter::impl):
(WebDOMTestCustomNamedGetter::~WebDOMTestCustomNamedGetter):
(WebDOMTestCustomNamedGetter::anotherFunction):
(toWebCore):
(toWebKit):

  • bindings/scripts/test/CPP/WebDOMTestCustomNamedGetter.h: Ditto.

(WebCore):
(WebDOMTestCustomNamedGetter):

  • bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp: Ditto.

(WebKit):
(WebKit::kit):
(webkit_dom_test_custom_named_getter_another_function):
(WebKit::core):
(webkit_dom_test_custom_named_getter_finalize):
(webkit_dom_test_custom_named_getter_set_property):
(webkit_dom_test_custom_named_getter_get_property):
(webkit_dom_test_custom_named_getter_constructed):
(webkit_dom_test_custom_named_getter_class_init):
(webkit_dom_test_custom_named_getter_init):
(WebKit::wrapTestCustomNamedGetter):

  • bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.h: Ditto.

(_WebKitDOMTestCustomNamedGetter):
(_WebKitDOMTestCustomNamedGetterClass):

  • bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetterPrivate.h: Ditto.

(WebKit):

  • bindings/scripts/test/GObject/WebKitDOMTestOverridingNameGetter.h: Ditto.
  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp: Ditto.

(WebCore):
(WebCore::JSTestCustomNamedGetterConstructor::JSTestCustomNamedGetterConstructor):
(WebCore::JSTestCustomNamedGetterConstructor::finishCreation):
(WebCore::JSTestCustomNamedGetterConstructor::getOwnPropertySlot):
(WebCore::JSTestCustomNamedGetterConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestCustomNamedGetterPrototype::self):
(WebCore::JSTestCustomNamedGetterPrototype::getOwnPropertySlot):
(WebCore::JSTestCustomNamedGetterPrototype::getOwnPropertyDescriptor):
(WebCore::JSTestCustomNamedGetter::JSTestCustomNamedGetter):
(WebCore::JSTestCustomNamedGetter::finishCreation):
(WebCore::JSTestCustomNamedGetter::createPrototype):
(WebCore::JSTestCustomNamedGetter::destroy):
(WebCore::JSTestCustomNamedGetter::getOwnPropertySlot):
(WebCore::JSTestCustomNamedGetter::getOwnPropertyDescriptor):
(WebCore::jsTestCustomNamedGetterConstructor):
(WebCore::JSTestCustomNamedGetter::getConstructor):
(WebCore::jsTestCustomNamedGetterPrototypeFunctionAnotherFunction):
(WebCore::isObservable):
(WebCore::JSTestCustomNamedGetterOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestCustomNamedGetterOwner::finalize):
(WebCore::toJS):
(WebCore::toTestCustomNamedGetter):

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.h: Ditto.

(WebCore):
(JSTestCustomNamedGetter):
(WebCore::JSTestCustomNamedGetter::create):
(WebCore::JSTestCustomNamedGetter::createStructure):
(WebCore::JSTestCustomNamedGetter::impl):
(WebCore::JSTestCustomNamedGetter::releaseImpl):
(WebCore::JSTestCustomNamedGetter::releaseImplIfNotNull):
(JSTestCustomNamedGetterOwner):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
(JSTestCustomNamedGetterPrototype):
(WebCore::JSTestCustomNamedGetterPrototype::create):
(WebCore::JSTestCustomNamedGetterPrototype::createStructure):
(WebCore::JSTestCustomNamedGetterPrototype::JSTestCustomNamedGetterPrototype):
(JSTestCustomNamedGetterConstructor):
(WebCore::JSTestCustomNamedGetterConstructor::create):
(WebCore::JSTestCustomNamedGetterConstructor::createStructure):

  • bindings/scripts/test/JS/JSTestOverridingNameGetter.cpp:
  • bindings/scripts/test/ObjC/DOMTestCustomNamedGetter.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestCustomNamedGetter.mm: Ditto.

(-[DOMTestCustomNamedGetter dealloc]):
(-[DOMTestCustomNamedGetter finalize]):
(-[DOMTestCustomNamedGetter anotherFunction:]):
(core):
(kit):

  • bindings/scripts/test/ObjC/DOMTestCustomNamedGetterInternal.h: Ditto.

(WebCore):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp: Ditto.

(WebCore):
(TestCustomNamedGetterInternal):
(WebCore::TestCustomNamedGetterInternal::V8_USE):
(WebCore::TestCustomNamedGetterInternal::anotherFunctionCallback):
(WebCore::ConfigureV8TestCustomNamedGetterTemplate):
(WebCore::V8TestCustomNamedGetter::GetRawTemplate):
(WebCore::V8TestCustomNamedGetter::GetTemplate):
(WebCore::V8TestCustomNamedGetter::HasInstance):
(WebCore::V8TestCustomNamedGetter::wrapSlow):
(WebCore::V8TestCustomNamedGetter::derefObject):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h: Ditto.

(WebCore):
(V8TestCustomNamedGetter):
(WebCore::V8TestCustomNamedGetter::toNative):
(WebCore::V8TestCustomNamedGetter::existingWrapper):
(WebCore::V8TestCustomNamedGetter::wrap):
(WebCore::toV8):

21:37 Changeset [107038] by eae@chromium.org

Revert TableSection cell and border calculations to integers
https://bugs.webkit.org/show_bug.cgi?id=77918

Reviewed by Eric Seidel.

Change RenderTableSection cell width, row height and border calculations
back to use integers. Table layout is done on integer bounds to comply
with the specification and to ensure that columns given the same width,
including percentage widths, are rendered with identical widths. The same
applies to heights.

No new tests.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::setCellLogicalWidths):
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::calcOuterBorderBefore):
(WebCore::RenderTableSection::calcOuterBorderAfter):
(WebCore::RenderTableSection::calcOuterBorderStart):
(WebCore::RenderTableSection::calcOuterBorderEnd):
(WebCore::RenderTableSection::paintObject):
(WebCore::RenderTableSection::nodeAtPoint):

  • rendering/RenderTableSection.h:

(RenderTableSection):
(WebCore::RenderTableSection::RowStruct::RowStruct):
(WebCore::RenderTableSection::outerBorderBefore):
(WebCore::RenderTableSection::outerBorderAfter):
(WebCore::RenderTableSection::outerBorderStart):
(WebCore::RenderTableSection::outerBorderEnd):

21:34 Changeset [107037] by commit-queue@webkit.org

Plumb through webGLErrorsToConsoleEnable in WebSettings
https://bugs.webkit.org/show_bug.cgi?id=78061

Patch by Gregg Tavares <gman@google.com> on 2012-02-07
Reviewed by Kenneth Russell.

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setWebGLErrorsToConsoleEnabled):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

21:06 Changeset [107036] by commit-queue@webkit.org

Source/JavaScriptCore: [chromium] Remove the enable marcro for the no longer necessary Chromium
gesture recognizer.
https://bugs.webkit.org/show_bug.cgi?id=77492

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07
Reviewed by Adam Barth.

  • wtf/Platform.h:

Source/WebCore: [chromium] Remove the no longer necessary Chromium gesture recognizer.
https://bugs.webkit.org/show_bug.cgi?id=77492

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07
Reviewed by Adam Barth.

  • WebCore.gypi:
  • platform/PlatformGestureRecognizer.h: Removed.
  • platform/chromium/FramelessScrollView.h:

(WebCore):
(FramelessScrollView):

  • platform/chromium/GestureRecognizerChromium.cpp: Removed.
  • platform/chromium/GestureRecognizerChromium.h: Removed.
  • platform/chromium/PopupContainer.cpp:

(WebCore):

  • platform/chromium/PopupContainer.h:
  • platform/chromium/PopupListBox.cpp:

(WebCore):

  • platform/chromium/PopupListBox.h:

(PopupListBox):

Source/WebKit: [chromium] Remove no longer necessary Chromium gesture recognizer code.
https://bugs.webkit.org/show_bug.cgi?id=77492

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07
Reviewed by Adam Barth.

  • blackberry/WebCoreSupport/AboutDataEnableFeatures.in:

Source/WebKit/chromium: [chromium] Remove no longer necessary Chromium gesture recognizer code.
https://bugs.webkit.org/show_bug.cgi?id=77492

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07
Reviewed by Adam Barth.

  • WebKit.gypi:
  • features.gypi:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::createFrameView):

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::WebPopupMenuImpl):
(WebKit::WebPopupMenuImpl::handleTouchEvent):

  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::touchEvent):

  • src/WebViewImpl.h:

(WebCore):
(WebViewImpl):

  • tests/InnerGestureRecognizerTest.cpp: Removed.

LayoutTests: [chromium] Remove unnecessary Chromium gesture recognizer tests.
https://bugs.webkit.org/show_bug.cgi?id=77492

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-02-07
Reviewed by Adam Barth.

  • fast/events/touch/page-scaled-touch-gesture-click-expected.txt:
  • fast/events/touch/page-scaled-touch-gesture-click.html:
  • fast/events/touch/touch-gesture-click-expected.txt: Removed.
  • fast/events/touch/touch-gesture-click.html: Removed.
  • fast/events/touch/touch-gesture-scroll-expected.txt: Removed.
  • fast/events/touch/touch-gesture-scroll.html: Removed.
  • platform/chromium/fast/events/touch/touch-gesture-click-expected.txt: Removed.
  • platform/chromium/fast/events/touch/touch-gesture-scroll-expected.txt: Removed.
20:23 Changeset [107035] by arv@chromium.org

[V8] Allow bindings for attributes on DOM nodes to also set a named hidden reference
https://bugs.webkit.org/show_bug.cgi?id=78052

Reviewed by Nate Chapin.

Source/WebCore:

Before this patch the code generator did not add the named hidden reference when the data node
was a DOM Node. This lead to us having to create custom toV8 bindings in a few places.

Covered by existing tests

  • Target.pri:
  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(HasCustomToV8Implementation):

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:
  • bindings/v8/custom/V8DOMTokenListCustom.cpp: Removed.
  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:

LayoutTests:

  • platform/chromium/test_expectations.txt:
20:14 Changeset [107034] by haraken@chromium.org

[GTK] Ignore [Custom] attributes in CodeGeneratorGObject.pm
https://bugs.webkit.org/show_bug.cgi?id=78059

Reviewed by Adam Barth.

CodeGeneratorGObject.pm does not support custom attributes.
We can skip generating code for attributes with [Custom].
The change would make sense, since CodeGeneratorGObject.pm already
skips attributes with [CustomGetter] or [CustomSetter].

Test: bindings/scripts/test/TestObj.idl

  • bindings/scripts/CodeGeneratorGObject.pm:

(SkipAttribute):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
20:05 Changeset [107033] by leo.yang@torchmobile.com.cn

[BlackBerry] Upstream ChromeClientBlackBerry.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=77843

Reviewed by Rob Buis.

Initial upstream, no new tests.

  • blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp: Added.
  • blackberry/WebCoreSupport/ChromeClientBlackBerry.h: Added.
19:56 Changeset [107032] by eae@chromium.org

Add pixelSnappedX/Y/Width/Height methods
https://bugs.webkit.org/show_bug.cgi?id=78040

Reviewed by Eric Seidel.

Add pixel snapped versions of x/y/width/height methods. These return the
same value as the x/w/width/height methods for now but once we move over
to sub pixel layout they will snap the subpixel value to a device pixel
and return an integer value.

When snapping the left and top edge is simply rounded to the nearest
device pixel.
The right and bottom edges are computed by subtracting the rounded left/
top edge from the precise location and size. This ensures that the edges
all line up with device pixels and that the total size of an object,
including borders, is at most one pixel off.

In summary, the values are computed as follows:

x: round(x)
y: round(y)
maxX: round(x + width)
maxY: round(y + height)
width: round(x + width) - round(x)
height: round(y + height) - round(y)

We use the term pixel snapped to indicate that the numbers are not merely
rounded. This also matches the naming used by the line box tree.

No new tests, no functionality changes.

  • page/PrintContext.cpp:

(WebCore::PrintContext::pageNumberForElement):

  • rendering/RenderBlock.cpp:

(WebCore::::collectIfNeeded):

  • rendering/RenderBlock.h:

(RenderBlock):
(WebCore::RenderBlock::pixelSnappedLogicalRightOffsetForLine):
(WebCore::RenderBlock::pixelSnappedLogicalLeftOffsetForLine):
(WebCore::RenderBlock::FloatingObject::pixelSnappedX):
(WebCore::RenderBlock::FloatingObject::pixelSnappedMaxX):
(WebCore::RenderBlock::FloatingObject::pixelSnappedY):
(WebCore::RenderBlock::FloatingObject::pixelSnappedMaxY):
(WebCore::RenderBlock::FloatingObject::pixelSnappedWidth):
(WebCore::RenderBlock::FloatingObject::pixelSnappedHeight):
(FloatingObject):
(WebCore::RenderBlock::pixelSnappedLogicalTopForFloat):
(WebCore::RenderBlock::pixelSnappedLogicalBottomForFloat):
(WebCore::RenderBlock::pixelSnappedLogicalLeftForFloat):
(WebCore::RenderBlock::pixelSnappedLogicalRightForFloat):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::pixelSnappedClientWidth):
(WebCore):
(WebCore::RenderBox::pixelSnappedClientHeight):
(WebCore::RenderBox::scrollHeight):

  • rendering/RenderBox.h:

(WebCore::RenderBox::pixelSnappedWidth):
(WebCore::RenderBox::pixelSnappedHeight):
(RenderBox):
(WebCore::RenderBox::pixelSnappedOffsetWidth):
(WebCore::RenderBox::pixelSnappedOffsetHeight):
(WebCore::RenderBox::clientLogicalWidth):
(WebCore::RenderBox::clientLogicalHeight):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::pixelSnappedOffsetWidth):
(WebCore):
(WebCore::RenderBoxModelObject::pixelSnappedOffsetHeight):

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::pixelSnappedOffsetLeft):
(WebCore::RenderBoxModelObject::pixelSnappedOffsetTop):
(RenderBoxModelObject):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::pixelSnappedScrollWidth):
(WebCore):
(WebCore::RenderLayer::pixelSnappedScrollHeight):
(WebCore::RenderLayer::computeScrollDimensions):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):

  • rendering/RenderLayer.h:

(RenderLayer):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::scrollHeight):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::volumeSliderOffsetFromMuteButton):

  • rendering/RenderTreeAsText.cpp:

(WebCore::write):

19:53 Changeset [107031] by jchaffraix@webkit.org

Unreviewed gardening.

Add / update the baselines for fast/text/synthetic-bold-transformed.html and svg/custom/use-disappears-after-style-update.svg.

  • platform/chromium-linux-x86/svg/custom/use-disappears-after-style-update-expected.txt: Added.
  • platform/chromium-linux/fast/text/synthetic-bold-transformed-expected.png: Added.
  • platform/chromium-linux/svg/custom/use-disappears-after-style-update-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/synthetic-bold-transformed-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/use-disappears-after-style-update-expected.txt: Added.
  • platform/chromium-win-xp/svg/custom/use-disappears-after-style-update-expected.txt: Added.
  • platform/chromium-win/fast/text/synthetic-bold-transformed-expected.png: Added.
  • platform/chromium-win/svg/custom/use-disappears-after-style-update-expected.png: Added.
  • platform/chromium-win/svg/custom/use-disappears-after-style-update-expected.txt: Added.
19:40 Changeset [107030] by mikelawther@chromium.org

CSS3 calc() - simple parse time evaluation
https://bugs.webkit.org/show_bug.cgi?id=77960

Source/WebCore:

Adds simple number/percent expression evaluation. rgb() and hsl() functions now
allow simple calc() expressions.

Reviewed by Ojan Vafai.

  • css/CSSCalculationValue.cpp:

(WebCore):
(WebCore::CSSCalcValue::doubleValue):
(WebCore::CSSCalcPrimitiveValue::doubleValue):
(WebCore::CSSCalcBinaryOperation::doubleValue):
(CSSCalcBinaryOperation):
(WebCore::CSSCalcBinaryOperation::evaluate):

  • css/CSSCalculationValue.h:

(CSSCalcExpressionNode):
(WebCore::CSSCalcValue::isInt):
(CSSCalcValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parsedDouble):

LayoutTests:

Reviewed by Ojan Vafai.

  • css3/calc/color-hsl-expected.txt:
  • css3/calc/color-rgb-expected.txt:
19:26 Changeset [107029] by kling@webkit.org

REGRESSION(r106668-r106889): Chromium page cycler tests (Intl2) performance regressions.
<http://webkit.org/b/78068>

Reviewed by Ryosuke Niwa.

Create CSS_IDENT values for attribute styles in the document's CSSValuePool.
This regressed in r106756 and I suspect it'll fix up the cycler regression.

  • dom/StyledElement.cpp:

(WebCore::StyledElement::addCSSProperty):

19:20 Changeset [107028] by timothy@apple.com

Avoid making a window for the Web Inspector when it is docked.

This also makes sure the inspector WKView is in a window before the page is loaded.
This avoids some redundant work caused by moving it to a window later.

https://webkit.org/b/78064

Reviewed by Brian Weinstein.

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::createInspectorPage): Set m_isAttached here...
(WebKit::WebInspectorProxy::didLoadInspectorPage): ... instead of here.

  • UIProcess/WebInspectorProxy.h:

(WebInspectorProxy):

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::createInspectorWindow): Added. Factored out of platformOpen.
(WebKit::WebInspectorProxy::updateInspectorWindowTitle): Added. Factored out of platformInspectedURLChanged.
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Call platformAttach or createInspectorWindow.
(WebKit::WebInspectorProxy::platformOpen): Make the view or window visible.
(WebKit::WebInspectorProxy::platformDidClose): Only message m_inspectorWindow if it isn't nil.
(WebKit::WebInspectorProxy::platformInspectedURLChanged): Store the urlString and call updateInspectorWindowTitle.
(WebKit::WebInspectorProxy::inspectedViewFrameDidChange): Return early if not visible.
(WebKit::WebInspectorProxy::platformAttach): Start out hidden if we are not visible yet. Destroy the window.
(WebKit::WebInspectorProxy::platformDetach): Use createInspectorWindow to create it again.

19:10 Changeset [107027] by noel.gordon@gmail.com

Remove TextureMapperQt from the gyp projects
https://bugs.webkit.org/show_bug.cgi?id=78055

Reviewed by Noam Rosenthal.

TextureMapperQt.{cpp,h} were removed in r106659, remove references to
these files from the gyp projects.

  • WebCore.gypi:
19:00 Changeset [107026] by tony@chromium.org

merge DashboardSupportCSSPropertyNames.in into CSSPropertyNames.in
https://bugs.webkit.org/show_bug.cgi?id=78036

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES.

Source/WebCore:

In r89362, we started running the preprocessor through CSSPropertyNames.in.
Now we can move DashboardSupportCSSPropertyNames.in into CSSPropertyNames.in
and wrap it in an #if.

No new tests, build refactoring.

  • Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES.
  • DerivedSources.make: Remove DashboardSupportCSSPropertyNames.in.
  • DerivedSources.pri: Remove DashboardSupportCSSPropertyNames.in.
  • WebCore.xcodeproj/project.pbxproj: Remove DashboardSupportCSSPropertyNames.in.
  • css/CSSPropertyNames.in: Wrap -webkit-dashboard-region in an #if.
  • css/DashboardSupportCSSPropertyNames.in: Removed.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES.

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES.
18:51 Changeset [107025] by commit-queue@webkit.org

Enable IPP for FFTFrame
https://bugs.webkit.org/show_bug.cgi?id=75522

Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-02-07
Reviewed by Tony Chang.

Add the FFTFrame implementation using Intel IPP's DFT algorithm.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/audio/FFTFrame.h:

(FFTFrame):

  • platform/audio/FFTFrameStub.cpp:
  • platform/audio/ipp/FFTFrameIPP.cpp: Added.

(WebCore):
(WebCore::FFTFrame::FFTFrame):
(WebCore::FFTFrame::initialize):
(WebCore::FFTFrame::cleanup):
(WebCore::FFTFrame::~FFTFrame):
(WebCore::FFTFrame::multiply):
(WebCore::FFTFrame::doFFT):
(WebCore::FFTFrame::doInverseFFT):
(WebCore::FFTFrame::realData):
(WebCore::FFTFrame::imagData):
(WebCore::FFTFrame::getUpToDateComplexData):

18:47 Changeset [107024] by enne@google.com

Properly detect top level frames when propogating compositing
https://bugs.webkit.org/show_bug.cgi?id=78033

Reviewed by James Robinson.

There's no need to enumerate all tag names when searching for a
top-level frame. If a render view's document has a frame, then that
frame is not the top-level one.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingFrame):

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

18:21 Changeset [107023] by commit-queue@webkit.org

Resolve crash in FrameLoader::checkTimerFired.
https://bugs.webkit.org/show_bug.cgi?id=77907

Patch by Chris Palmer <palmer@google.com> on 2012-02-07
Reviewed by Eric Seidel.

Source/WebCore:

Test is LayoutTests/http/tests/appcache/deferred-events-delete-while-raising-timer.html.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkTimerFired):

LayoutTests:

  • http/tests/appcache/deferred-events-delete-while-raising-timer-expected.txt: Added.
  • http/tests/appcache/deferred-events-delete-while-raising-timer.html: Added.
  • http/tests/appcache/resources/deferred-events-delete-while-raising-timer-1.html: Added.
  • http/tests/appcache/resources/deferred-events-delete-while-raising-timer-2.html: Added.
18:06 Changeset [107022] by commit-queue@webkit.org

[Chromium] add option for 2d canvas defered rendering to DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=78039

Patch by Justin Novosad <junov@chromium.org> on 2012-02-07
Reviewed by Stephen White.

Adding the --enable-deferred-2d-canvas switch to DumpRenderTree

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::resetWebSettings):
(TestShell::runFileTest):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell::setDeferred2dCanvasEnabled):
(TestShell):

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset):
(WebPreferences::applyTo):

  • DumpRenderTree/chromium/WebPreferences.h:

(WebPreferences):

18:05 Changeset [107021] by commit-queue@webkit.org

[BlackBerry] NetworkJob should stop redirecting when the request is cleared by client
https://bugs.webkit.org/show_bug.cgi?id=78029

Patch by Yong Li <yoli@rim.com> on 2012-02-07
Reviewed by Rob Buis.

When a redirect is rejected by security origin check, the ResourceRequest
will be cleared (see DocumentThreadableLoader::redirectReceived()). In this
case, we should stop handling the request.

No new tests because existing tests (like http:/tests/xmlhttprequest/redirect-cross
-origin-tripmine.html) can cover this.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::startNewJobWithRequest):

17:51 Changeset [107020] by gyuyoung.kim@samsung.com

[CMAKE] Use *bin* and *lib* directories for executable and libraries.
https://bugs.webkit.org/show_bug.cgi?id=77928

Reviewed by Daniel Bates.

CMake has used *Programs* directory for executable. In addition, shared libraries are being
built in source directory. It is better to set common places in order to maintain executable
and libraries. *bin* is for executable and *lib* is for library.

.:

  • CMakeLists.txt: Set library output path.
  • Source/cmake/WebKitFS.cmake: Remove *Programs* creation.

Source/JavaScriptCore:

  • shell/CMakeLists.txt: Change *Programs* with *bin*.

Source/WebKit2:

  • CMakeLists.txt:

Tools:

  • DumpRenderTree/efl/CMakeLists.txt:
  • EWebLauncher/CMakeLists.txt:
  • Scripts/run-launcher:
  • Scripts/webkitdirs.pm:

(jscProductDir):

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort._path_to_driver):
(EflPort._path_to_image_diff):

17:49 Changeset [107019] by commit-queue@webkit.org

Remove extraneous MathML code before bug 52444 fix
https://bugs.webkit.org/show_bug.cgi?id=78034

Source/WebCore:

Patch by David Barton <dbarton@mathscribe.com> on 2012-02-07
Reviewed by Eric Seidel.

Per Darin Adler, I am breaking up the patch fixing bug 52444 into smaller pieces.
This patch removes a couple unused functions, some extra blank lines, unused #include
directives, etc., and adds a very few WebKit-standard changes to these files.

No new tests.

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore):

  • rendering/mathml/RenderMathMLBlock.h:

(WebCore::RenderMathMLBlock::getBoxModelObjectHeight):

  • changed to a static member function since 'this' is unused; removed redundant non-const version

(WebCore::RenderMathMLBlock::getBoxModelObjectWidth):

  • changed to a static member function since 'this' is unused; removed redundant non-const version

(WebCore):

  • rendering/mathml/RenderMathMLFraction.cpp:
  • rendering/mathml/RenderMathMLMath.cpp:
  • rendering/mathml/RenderMathMLMath.h:
  • rendering/mathml/RenderMathMLOperator.h:

(WebCore):

  • rendering/mathml/RenderMathMLRoot.cpp:
  • rendering/mathml/RenderMathMLRow.cpp:
  • rendering/mathml/RenderMathMLRow.h:
  • rendering/mathml/RenderMathMLSquareRoot.cpp:
  • rendering/mathml/RenderMathMLSquareRoot.h:
  • rendering/mathml/RenderMathMLSubSup.cpp:
  • rendering/mathml/RenderMathMLSubSup.h:
  • rendering/mathml/RenderMathMLUnderOver.cpp:
  • rendering/mathml/RenderMathMLUnderOver.h:

LayoutTests:

Patch by David Barton <dbarton@mathscribe.com> on 2012-02-07
Reviewed by Eric Seidel.

The rendering of the scrollbar in row-expected.png was flaky, presumably due to a test
environment timing issue, so I removed it.

  • mathml/presentation/row.xhtml:
  • platform/mac/mathml/presentation/row-expected.png:
  • platform/mac/mathml/presentation/row-expected.txt:
17:37 Changeset [107018] by commit-queue@webkit.org

Override expected-failure mac-leopard/media/media-blocked-by-beforeload-expected.txt with copy of expected-success expectation, for chromium-mac-leopard.
https://bugs.webkit.org/show_bug.cgi?id=78030

Unreviewed.

Patch by Ami Fischman <fischman@chromium.org> on 2012-02-07

  • platform/chromium-mac-leopard/media/media-blocked-by-beforeload-expected.txt: Added.
17:28 Changeset [107017] by timothy@apple.com

Initilize the WebPageProxy intrinsicDeviceScaleFactor on creation of the WKView.

If WKView was created and loaded a page with canvas elements before beinging moved
to a window, the canvas elements would be locked in at a pixel ratio of 1. With this
change the WKView will use the main screen's pixel ratio until it moves to a window.

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:contextRef:pageGroupRef:]): Call setIntrinsicDeviceScaleFactor.

17:16 Changeset [107016] by commit-queue@webkit.org

Get rid of Source/autotools/webkit.m4
https://bugs.webkit.org/show_bug.cgi?id=77833

Patch by Priit Laes <plaes@plaes.org> on 2012-02-07
Reviewed by Martin Robinson.

Move checks from webkit.m4 to configure.ac and modernize macros:

. Check for visibility flags after CXX has been defined
. Use PKG_PROG_PKG_CONFIG for pkg-config lookup
. Drop unused LIBFFTW_REQUIRED_VERSION
. Update ICU libs for mingw (bug 77837).
. Require Pango 1.21.0 (as per unicode backend)
. Bump minimum glib version due to g_thread_init changes

  • Source/autotools/webkit.m4: Removed.
  • configure.ac:
17:15 Changeset [107015] by lforschler@apple.com

Versioning.

17:03 Changeset [107014] by commit-queue@webkit.org

[Chromium] REGRESSION(r101854): Causing large amounts of unnecessary repainting.
https://bugs.webkit.org/show_bug.cgi?id=78020

Patch by David Reveman <reveman@chromium.org> on 2012-02-07
Reviewed by James Robinson.

Source/WebCore:

Revert r101854.

This patch is tested by the following unit test:

  • TextureManagerTest.requestTextureExceedingPreferredLimit
  • platform/graphics/chromium/ManagedTexture.cpp:

(WebCore::ManagedTexture::reserve):

  • platform/graphics/chromium/TextureManager.cpp:

(WebCore::TextureManager::requestTexture):

  • platform/graphics/chromium/TextureManager.h:

(TextureManager):

Source/WebKit/chromium:

Update TextureManagerTest.requestTextureExceedingPreferredLimit test.

  • tests/TextureManagerTest.cpp:

(WTF::TextureManagerTest::requestTexture):
(WTF::TEST_F):

17:00 Changeset [107013] by andersca@apple.com

Use the non-fast-scrollable region to detect when we can't do fast scrolling
https://bugs.webkit.org/show_bug.cgi?id=78056
<rdar://problem/10247932>

Reviewed by Sam Weinig.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
Actually set the non-fast scrollable region on the scrolling tree state.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::tryToHandleWheelEvent):
Check if the wheel event's position is inside the non-fast-scrollable region
and return false if it is.

(WebCore::ScrollingTree::updateMainFrameScrollPosition):
Store the cached main frame scroll position so we can use it in tryToHandleWheelEvent.

  • platform/graphics/Region.cpp:
  • platform/graphics/Region.h:

Add a simple contains(const IntPoint&) member function.

16:59 Changeset [107012] by mitz@apple.com

<rdar://problem/10475450> Synthetic bold is illegible under some scaling transforms
https://bugs.webkit.org/show_bug.cgi?id=78044

Reviewed by Beth Dakin.

Source/WebCore:

Tests: fast/text/synthetic-bold-transformed-expected.html

fast/text/synthetic-bold-transformed.html

  • platform/graphics/mac/FontMac.mm:

(WebCore::Font::drawGlyphs): Changed to interpret syntheticBoldOffset as a length in device pixels.

LayoutTests:

  • fast/text/synthetic-bold-transformed-expected.html: Added.
  • fast/text/synthetic-bold-transformed.html: Added.
16:58 Changeset [107011] by lforschler@apple.com

New tag.

16:55 Changeset [107010] by commit-queue@webkit.org

[EFL] Add missing initialization of editable variable.
https://bugs.webkit.org/show_bug.cgi?id=77948

Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-02-07
Reviewed by Eric Seidel.

The value of editable in Ewk_Frame_Smart_Data struct is not set.

  • ewk/ewk_frame.cpp:

(ewk_frame_editable_set):

16:52 Changeset [107009] by leviw@chromium.org

Update LayoutUnit usage in ColumnInfo and RenderFrameSet
https://bugs.webkit.org/show_bug.cgi?id=77914

Reviewed by Eric Seidel.

Updating ColumnInfo and RenderFrameSet to use LayoutUnits
instead of directly referencing integers for locations and
distances.

No new tests. No changed behavior.

  • rendering/ColumnInfo.h:

(WebCore::ColumnInfo::forcedBreakOffset):
(WebCore::ColumnInfo::maximumDistanceBetweenForcedBreaks):
(ColumnInfo):

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::paintColumnBorder):
(WebCore::RenderFrameSet::paintRowBorder):

  • rendering/RenderFrameSet.h:

(RenderFrameSet):

16:40 Changeset [107008] by adamk@chromium.org

Add JSC support for delivering mutations when the outermost script context exits
https://bugs.webkit.org/show_bug.cgi?id=70289

Reviewed by Eric Seidel.

Source/WebCore:

The meat of this change is in JSMainThreadExecState, where a counter
is incremented every time WebCore calls into JSC and decremented every
time it returns. When the counter reaches zero, any pending mutations
are delivered (this mirrors very similar code in V8Proxy and V8RecursionScope).

The rest of the changes are of two sorts: compilation/logic fixes for
JSC code when ENABLE(MUTATION_OBSERVERS) is true, and additional
usages of JSMainThreadExecState so as to trigger the above
increment/decrements at the appropriate times.

  • bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
Use JSMainThreadExecState instead of JSC::call.

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue): Add support
for tryGetProperty with a HashMap<AtomicString>.

  • bindings/js/JSDictionary.h:
  • bindings/js/JSErrorHandler.cpp:

(WebCore::JSErrorHandler::handleEvent):
Use JSMainThreadExecState instead of JSC::call.

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::open):
Use JSMainThreadExecState instead of JSC::call.

  • bindings/js/JSMainThreadExecState.cpp:

(WebCore::JSMainThreadExecState::didLeaveScriptContext):

  • bindings/js/JSMainThreadExecState.h:

(WebCore::JSMainThreadExecState::JSMainThreadExecState):
Increment a static recursion level counter.
(WebCore::JSMainThreadExecState::~JSMainThreadExecState):
Decrement a static recursion level counter and, if we are
at zero (the outermost script invocation), deliver any
outstanding mutation records.

  • bindings/js/JSNodeFilterCondition.cpp:

(WebCore::JSNodeFilterCondition::acceptNode):
Use JSMainThreadExecState instead of JSC::call.

  • bindings/js/JSWebKitMutationObserverCustom.cpp:

(WebCore::JSWebKitMutationObserver::observe):
Fix JSDictionary logic, add support for attributeFilter.

Tools:

  • DumpRenderTree/mac/EventSendingController.mm: Add support for

eventSender.scheduleAsynchronousKeyDown.
(+[EventSendingController isSelectorExcludedFromWebScript:]):
(+[EventSendingController webScriptNameForSelector:]):
(-[EventSendingController keyDownWrapper:withModifiers:withLocation:]):
(-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]):

  • Scripts/build-webkit: Properly alphabetize --mutation-observers in the --help output.

LayoutTests:

With the various fixes in this change, 8/10 tests in fast/mutation
pass under WebKit/Mac. Of the failing tests, only one is due to
a deficiency in the Mac port's code (end-of-task-delivery.html);
the other is due to lack of support for a feature (FILE_SYSTEM)
exercised by the test (non-event-delivery.html).

  • fast/mutation/non-event-delivery.html: Made it fail fast if FileSystem support isn't available.
  • fast/mutation/observe-attributes.html: Fixed calls to removeEventListener.
  • fast/mutation/observe-characterdata.html: ditto.
16:26 Changeset [107007] by lforschler@apple.com

Merged r106982.

16:17 Changeset [107006] by andersca@apple.com

Fix build.

  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::scrollableAreaBoundingBox):

16:14 Changeset [107005] by leviw@chromium.org

[SVG] Use element disappears after scripted change
https://bugs.webkit.org/show_bug.cgi?id=74392

Reviewed by Eric Seidel.

Source/WebCore:

Solution uncovered by Nikolas Zimmermann. Removing an early return that caused
SVGUseElements to not update the shadow root's style, and therefor not render
correctly.

Test: svg/custom/use-disappears-after-style-update.svg

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::didRecalcStyle):

LayoutTests:

  • platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.png: Added.
  • platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.txt: Added.
  • svg/custom/use-disappears-after-style-update.svg: Added.
16:00 Changeset [107004] by haraken@chromium.org

Rename [v8OnProto] IDL attribute to [V8OnProto] IDL attribute
https://bugs.webkit.org/show_bug.cgi?id=77973

Reviewed by Adam Barth.

This patch renames [v8OnProto] to [V8OnProto], since V8 specific IDL
attributes should be prefixed by "V8".

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):

15:58 Changeset [107003] by lforschler@apple.com

Merge patch for 78045.

15:53 Changeset [107002] by jer.noble@apple.com

media/audio-data-url.html test broken on Lion
https://bugs.webkit.org/show_bug.cgi?id=69779

Reviewed by Eric Carlson.

Do not use "OpenForPlayback" attribute on data:// urls, as CoreMedia/QuickTime X cannot
handle those URLs.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::createQTMovie):

15:47 Changeset [107001] by andersca@apple.com

Scrolling tree should keep track of region we can't do fast scrolling for
https://bugs.webkit.org/show_bug.cgi?id=78050

Reviewed by Dan Bernstein.

We currently won't do fast scrolling for subframes and other types of scrollable areas.
Because of this, we'll have the scrolling tree keep a region of the page for which we can't
do fast scrolling. This region will be updated after layout.

  • page/FrameView.cpp:

(WebCore::FrameView::scrollableAreaBoundingBox):
Return the bounding box.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
Go through all the scrollable areas in this frame view and compute the region which we can't do
fast scrolling for.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::commitNewTreeState):
Update the non-fast-scrollable region.

  • page/scrolling/ScrollingTreeState.cpp:

(WebCore::ScrollingTreeState::setNonFastScrollableRegion):
Set the non-fast-scrollable region if it's changed.

  • platform/ScrollableArea.h:

Add scrollableAreaBoundingBox member function.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollableAreaBoundingBox):
Return the bounding box.

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::scrollableAreaBoundingBox):
Return the bounding box.

15:46 Changeset [107000] by leviw@chromium.org

unicode-bidi:plaintext is supposed to be effective on display:inline elements too
https://bugs.webkit.org/show_bug.cgi?id=73310

Reviewed by Eric Seidel.

Source/WebCore:

Adding support for unicode-bidi: plaintext as a property on inlines. These are treated
like unicode-bidi: isolate with the addition of their directionality being determined
by the UBA.

Tests: fast/text/international/inline-plaintext-is-isolated-expected.html

fast/text/international/inline-plaintext-is-isolated.html
fast/text/international/inline-plaintext-relayout-with-leading-neutrals-expected.html
fast/text/international/inline-plaintext-relayout-with-leading-neutrals.html
fast/text/international/inline-plaintext-with-generated-content-expected.html
fast/text/international/inline-plaintext-with-generated-content.html

  • platform/text/UnicodeBidi.h:

(WebCore::isIsolated): Added this convenience function as Plaintext and Isolate Unicode-Bidi values
are both treated as isolated content.

  • rendering/InlineIterator.h:

(WebCore::notifyObserverEnteredObject): Inline now supports Unicode-Bidi Plaintext.
(WebCore::notifyObserverWillExitObject): Ditto.
(WebCore::bidiFirstSkippingEmptyInlines): Changed to support being called without a resolver.
(WebCore::isIsolatedInline): Inline now supports Unicode-Bidi: Plaintext.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::determineDirectionality): Generalized for inlines.
(WebCore::constructBidiRuns): Added support for Unicode-Bidi: Plaintext as an isolated inline.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Fixed comment.
(WebCore::RenderBlock::determineStartPosition): Fixed comment and switched to updated
bidiFirstSkippingEmptyInlines.

LayoutTests:

Ref tests for unicode-bidi: plaintext on inlines.

  • fast/text/international/inline-plaintext-is-isolated-expected.html: Added.
  • fast/text/international/inline-plaintext-is-isolated.html: Added.
  • fast/text/international/inline-plaintext-relayout-with-leading-neutrals-expected.html: Added.
  • fast/text/international/inline-plaintext-relayout-with-leading-neutrals.html: Added.
  • fast/text/international/inline-plaintext-with-generated-content-expected.html: Added.
  • fast/text/international/inline-plaintext-with-generated-content.html: Added.
15:43 Changeset [106999] by barraclough@apple.com

Crash on http://www.rickshawbags.com/
https://bugs.webkit.org/show_bug.cgi?id=78045

Reviewed by Darin Adler.

Problem URL is: http://www.rickshawbags.com/customize/custom-bag#!thl=rickshaw/bag()

This is a bug introduced by https://bugs.webkit.org/show_bug.cgi?id=71933,
isVariableObject() checks were excluding StaticScopeObjects, this patch
inadvertently changed them to be included.

  • runtime/JSType.h:
    • sort JSType enum such that StaticScopeObjectType comes before VariableObjectType, and thus is excluded from isVariableObject() checks.
15:38 Changeset [106998] by haraken@chromium.org

[Refactoring] Use the [IsWorkerContext] IDL in CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=77957

Reviewed by Adam Barth.

This patch replaces IsSubType("WorkerContext") and something equivalent that
with the [IsWorkerContext] IDL.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GetInternalFields):
(GenerateConstructorGetter):
(GenerateImplementation):

15:29 Changeset [106997] by commit-queue@webkit.org

[Chromium] Crash when using per-tile painting on Windows.
https://bugs.webkit.org/show_bug.cgi?id=75715

Patch by David Reveman <reveman@chromium.org> on 2012-02-07
Reviewed by James Robinson.

PlatformCanvas constructor on win32 expects forth argument to be a
shared section handle. Passing a pointer to a system memory causes
it to crash. Fix this by not using the PlatformCanvas API for
SkCanvas construction in per-tile texture uploader.

Tested with manual tests.

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::prepareRect):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::updateRect):

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:

(Texture):

15:12 Changeset [106996] by jer.noble@apple.com

Unreviewed build fix; make OSStatus the explicit return type for CMTimebase functions.

  • platform/mac/PlatformClockCM.mm:
15:07 Changeset [106995] by jchaffraix@webkit.org

Unreviewed gardening after r106982.

  • platform/chromium/test_expectations.txt:

We don't have at least one of the layoutTestController
functions used in this test so we are receiving an
exception and timing out.

15:03 Changeset [106994] by commit-queue@webkit.org

[chromium] Unit test for bug #77996
https://bugs.webkit.org/show_bug.cgi?id=78019

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-07
Reviewed by James Robinson.

  • tests/CCLayerTreeHostTest.cpp:

(CCLayerTreeHostTestManySurfaces):
(WTF::CCLayerTreeHostTestManySurfaces::CCLayerTreeHostTestManySurfaces):
(WTF::CCLayerTreeHostTestManySurfaces::beginTest):
(WTF::CCLayerTreeHostTestManySurfaces::afterTest):
(WTF):

14:52 Changeset [106993] by commit-queue@webkit.org

[BlackBerry] Upstream DumpRenderTreeSupport
https://bugs.webkit.org/show_bug.cgi?id=77991

Patch by Rob Buis <rbuis@rim.com> on 2012-02-07
Reviewed by Antonio Gomes.

No functionalities changed, no new tests.

  • blackberry/WebKitSupport/DumpRenderTreeSupport.cpp: Added.

(toGeolocationClientMock):
(DumpRenderTreeSupport::DumpRenderTreeSupport):
(DumpRenderTreeSupport::~DumpRenderTreeSupport):
(DumpRenderTreeSupport::javaScriptObjectsCount):
(DumpRenderTreeSupport::garbageCollectorCollect):
(DumpRenderTreeSupport::garbageCollectorCollectOnAlternateThread):
(DumpRenderTreeSupport::setLinksIncludedInFocusChain):
(DumpRenderTreeSupport::linksIncludedInFocusChain):
(DumpRenderTreeSupport::dumpConfigurationForViewport):
(DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests):
(DumpRenderTreeSupport::resetGeolocationMock):
(DumpRenderTreeSupport::setMockGeolocationError):
(DumpRenderTreeSupport::setMockGeolocationPermission):
(DumpRenderTreeSupport::setMockGeolocationPosition):
(DumpRenderTreeSupport::scalePageBy):
(DumpRenderTreeSupport::computedStyleIncludingVisitedInfo):

  • blackberry/WebKitSupport/DumpRenderTreeSupport.h: Added.

(WebKit):
(WebCore):
(WTF):
(DumpRenderTreeSupport):

14:20 Changeset [106992] by jamesr@google.com

[chromium] Allow retaining texture across frames in composited video playback and correctly handle lost context
https://bugs.webkit.org/show_bug.cgi?id=77923

Reviewed by Kenneth Russell.

Thanks to r106840, we can improve the video playback mode a bit. Instead of creating a new texture on every
frame, this attempts to reuse the texture from the previous frame unless the context is lost. Also improves
error checking in case the TextureManager cannot successfully reserve memory for the texture.

Tested manually by killing the GPU process with an html5 video playing and verifying that the video playback
continues and that we don't create a new set of textures for each plane on each frame.

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::draw):
(WebCore::CCVideoLayerImpl::reserveTextures):

14:18 Changeset [106991] by commit-queue@webkit.org

IndexedDB createIndex should fail if options arg is invalid
https://bugs.webkit.org/show_bug.cgi?id=58467

Patch by Eugene Girard <girard@chromium.org> on 2012-02-07
Reviewed by Tony Chang.

This ticket was fixed as part of https://bugs.webkit.org/show_bug.cgi?id=58471
Adding unit tests to verify correct operation.

  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics-workers-expected.txt:
  • storage/indexeddb/resources/index-basics.js:

(deleteExisting):

14:08 Changeset [106990] by jchaffraix@webkit.org

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:

Mark those 2 tests as crashing in Debug as they seem
to be hitting an ASSERT.

14:02 Changeset [106989] by ossy@webkit.org

[Qt] Unreviewed gardening, paint the bots green.

  • platform/qt/Skipped: Skip failing/crashing tests, because we like regressions in trunk.
13:52 Changeset [106988] by mdelaney@apple.com

https://bugs.webkit.org/show_bug.cgi?id=77912
Removing old CG shadow code.

A CG-specific shadow offset hack was added in http://trac.webkit.org/changeset/34317
for this particular setShadow method. However, this shadow offset adjustment for CG
has since moved down into platform specific code. Thus, this offset adjustment here
is now redundant.

The CG-only shadow setting code block in this setShadow method is now redundant.
Since it sets the shadow values to the CGContext directly - and not to the State object -
it will be overwritten later by any subsequent calls to setting shadow values such as
blur, offset, or shadow color.

Reviewed by Simon Fraser.

No new tests. Current canvas tests cover this path.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setShadow):

13:52 Changeset [106987] by commit-queue@webkit.org

Process Scroll-gesture events from the compositor.
https://bugs.webkit.org/show_bug.cgi?id=77477

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-02-07
Reviewed by James Robinson.

  • src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::WebCompositorInputHandlerImpl):
(WebKit::WebCompositorInputHandlerImpl::handleInputEvent):

  • src/WebCompositorInputHandlerImpl.h:

(WebCompositorInputHandlerImpl):

13:50 Changeset [106986] by jamesr@google.com

[chromium] Gracefully handle compositor initialization failure in single-threaded proxy
https://bugs.webkit.org/show_bug.cgi?id=78013

Reviewed by Kenneth Russell.

If compositor initialization fails it's not safe to proceed through the rest of the frame process. This adds
some early outs.

Tested manually by forcing the first makeContextCurrent() call fail.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::updateLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::compositeAndReadback):
(WebCore::CCSingleThreadProxy::compositeImmediately):
(WebCore::CCSingleThreadProxy::commitIfNeeded):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(CCSingleThreadProxy):

13:48 Changeset [106985] by ap@apple.com

Keep a reference in didReceiveInvalidMessage.
https://bugs.webkit.org/show_bug.cgi?id=78024

Reviewed by Anders Carlsson.

  • UIProcess/WebConnectionToWebProcess.cpp: (WebKit::WebConnectionToWebProcess::didReceiveInvalidMessage):
13:46 Changeset [106984] by crogers@google.com

Add Chris Rogers to reviewers section
https://bugs.webkit.org/show_bug.cgi?id=78016

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/config/committers.py:
13:37 Changeset [106983] by zimmermann@webkit.org

layoutTestController.display() is flaky for SVG tests
https://bugs.webkit.org/show_bug.cgi?id=78021

Reviewed by Dan Bernstein.

Fix race condition in repaint rect tracking. When running a test using the repaint.js
harness right after a test starting with "svg/W3C-SVG-1.1" the repaint test will fail,
the gray overlay isn't contained in the pixel dump anymore. This is because of a specific
hack that forces 480x360 instead of 800x600 pixel test dumps for any test starting with
svg/W3C-SVG-1.1. The resizing of the web view was done when dumping the render tree, after
the repaint test already run, thus invalidating the previously tracked repaint rects.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(dump):
(runTest):

13:37 Changeset [106982] by beidson@apple.com

<rdar://problem/9567286> and https://bugs.webkit.org/show_bug.cgi?id=78003 WebKit associates credentials with the wrong site if the authentication challenge takes place after a redirect chain

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials.html

Associate the credential with the URL of the challenge itself, not the original request:

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::receivedCredential):

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::receivedCredential):

LayoutTests:

  • http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials-expected.txt: Added.
  • http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials.html: Added.
  • http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-1-redirect-to-auth.php: Added.
  • http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-2-auth-then-redirect-to-finish.php: Added.
  • http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-3-output-credentials-then-finish.php: Added.
13:24 Changeset [106981] by jchaffraix@webkit.org

Revert r106958.

  • platform/chromium/test_expectations.txt:

It was a mistake as the test is really flaky not slow,
so now it is taking way longer to fail (see http://webkit.org/b/77997).

13:22 Changeset [106980] by tony@chromium.org

move warning about css values and render style constants closer to where it applies
https://bugs.webkit.org/show_bug.cgi?id=78017

Reviewed by Darin Adler.

Move the warning about keeping RenderStyleConstnats.h enums and
CSSValueKeywords.in values in the same order closer to the properties
that the warning applies to. The warning was easy to miss and was
confusing since it doesn't apply to most values.

Also refactor 2 conversion functions to
enumerate the possible values so the order doesn't matter.

No new tests, just refactoring and comment cleanup.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::operator EListStylePosition): Name all possible values and add a NOT_REACHED().
(WebCore::CSSPrimitiveValue::operator EUserModify): Name all possible values and add a NOT_REACHED().

  • css/CSSValueKeywords.in:
  • css/SVGCSSPropertyNames.in:
  • css/SVGCSSValueKeywords.in:
  • rendering/style/RenderStyleConstants.h:
13:06 Changeset [106979] by eae@chromium.org

Various build fixes for branch

12:48 Changeset [106978] by jer.noble@apple.com

Use CMClock as a timing source for PlatformClock where available.
https://bugs.webkit.org/show_bug.cgi?id=77885

Reviewed by Eric Carlson.

Source/JavaScriptCore:

  • wtf/Platform.h: Added WTF_USE_COREMEDIA.

Source/WebCore:

No new tests; performance improvement covered by existing test cases.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/Clock.cpp:

(Clock::create): Use PlatformClockCM if available.

  • platform/mac/PlatformClockCM.h: Added.

(WebCore::PlatformClockCM::playRate):
(WebCore::PlatformClockCM::isRunning):

  • platform/mac/PlatformClockCM.mm: Added.

(PlatformClockCM::PlatformClockCM):
(PlatformClockCM::initializeWithTimingSource):
(PlatformClockCM::setCurrentTime):
(PlatformClockCM::currentTime):
(PlatformClockCM::setPlayRate):
(PlatformClockCM::start):
(PlatformClockCM::stop):

12:45 Changeset [106977] by andersca@apple.com

ScrollableAreaSet should be moved from Page to FrameView
https://bugs.webkit.org/show_bug.cgi?id=62762

Reviewed by Beth Dakin.

Source/WebCore:

It makes more sense for the set of scrollable areas to be per frame view instead of per page;
scrollable areas are associated with a containing frame view and their lifecycle follows the lifecycle of the
frame view much more closely. This could even fix a bunch of crashes where a scrollable area outlived its containing page.

  • WebCore.exp.in:

Replace the Page member functions with FrameView member functions instead.

  • page/EventHandler.cpp:

(WebCore::EventHandler::mouseMoved):
Check if the frame view contains the given layer.

(WebCore::EventHandler::updateMouseEventTargetNode):
Ditto.

  • page/FocusController.cpp:

(WebCore::contentAreaDidShowOrHide):
Add helper function.

(WebCore::FocusController::setContainingWindowIsVisible):
Call contentAreaDidShowOrHide for the main frame view, and for all scrollable areas
inside all subframe views.

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
Use early returns to make the code more clear. Also, don't add the scrollable area to the set here.

(WebCore::FrameView::~FrameView):
Don't remove the scrollable area here.

(WebCore::FrameView::zoomAnimatorTransformChanged):
m_page is gone so use m_frame->page() instead.

(WebCore::FrameView::setAnimatorsAreActive):
Call ScrollAnimator::setIsActive for all the scrollable areas in this frame view. Previously we used to do
this for all scrollable areas on the page, but since setAnimatorsAreActive will be called for each document,
this will be done implicitly.

(WebCore::FrameView::notifyPageThatContentAreaWillPaint):
Call ScrollableArea::contentDidPaint for this frame view and all its immediate scrollable areas. Previously, we used
to do this for all scrollable areas on the page, but we only need to do it for this frame view.

(WebCore::FrameView::scrollAnimatorEnabled):
Get the page from m_frame since m_page is gone.

(WebCore::FrameView::addScrollableArea):
(WebCore::FrameView::removeScrollableArea):
(WebCore::FrameView::containsScrollableArea):
Move these member functions here from Page.

(WebCore::FrameView::addChild):
If we are adding a frame view, add it to the scrollable area set.

(WebCore::FrameView::removeChild):
If we are removing a frame view, remove it from the scrollable area set.

  • page/FrameView.h:

Move the member function declarations and the scrollable area set member variable here from Page.

  • page/Page.cpp:

(WebCore::Page::~Page):
Don't call disconnectPage on the scrollable areas anymore.

  • platform/ScrollView.h:

(ScrollView):
Make addChild and removeChild virtual.

  • platform/ScrollableArea.h:

Remove disconnectFromPage.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::~RenderLayer):
(WebCore::RenderLayer::styleChanged):
The frame view now keeps track of the scrollable areas.

  • rendering/RenderLayer.h:

Remove the page member variable and disconnectFromPage.

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::RenderListBox):
(WebCore::RenderListBox::~RenderListBox):
The frame view now keeps track of the scrollable areas.

  • rendering/RenderListBox.h:

Remove the page member variable and disconnectFromPage.

Source/WebKit/chromium:

Update for changes to WebCore now that the scrollable area set is kept per frame view.

  • src/ScrollbarGroup.cpp:

(WebKit::ScrollbarGroup::ScrollbarGroup):
(WebKit::ScrollbarGroup::~ScrollbarGroup):

  • src/ScrollbarGroup.h:

(WebCore):
(ScrollbarGroup):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::scrollbarGroup):

Source/WebKit2:

  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp:

(WebKit::BuiltInPDFView::initialize):
Call FrameView::addScrollableArea instead.

(WebKit::BuiltInPDFView::destroy):
Call FrameView::removeScrollableArea instead.

  • WebProcess/Plugins/PDF/BuiltInPDFView.h:

Remove disconnectFromPage since it no longer exists on ScrollableArea.

12:40 Changeset [106976] by commit-queue@webkit.org

[BlackBerry] Upstream BlackBerry WebCoreSupport DeviceOrientationClientBlackBerry and DeviceMotionClientBlackBerry classes
https://bugs.webkit.org/show_bug.cgi?id=77993

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-02-07
Reviewed by Rob Buis.

Initial upstream, no new tests.

  • blackberry/WebCoreSupport/DeviceMotionClientBlackBerry.cpp: Added.
  • blackberry/WebCoreSupport/DeviceMotionClientBlackBerry.h: Added.
  • blackberry/WebCoreSupport/DeviceOrientationClientBlackBerry.cpp: Added.
  • blackberry/WebCoreSupport/DeviceOrientationClientBlackBerry.h: Added.
12:28 Changeset [106975] by jchaffraix@webkit.org

Unreviewed gardening.

  • platform/chromium-linux/fast/forms/tabbing-input-iframe-expected.png:
  • platform/chromium-win/fast/events/frame-tab-focus-expected.txt: Removed.
  • platform/chromium/fast/events/frame-tab-focus-expected.txt: Added.
  • platform/chromium/test_expectations.txt:

Rebaseline some old entries in test_expectations.

12:16 Changeset [106974] by commit-queue@webkit.org

createImpulseBuffer uses incorrect length
https://bugs.webkit.org/show_bug.cgi?id=77665

Patch by Raymond Toy <rtoy@google.com> on 2012-02-07
Reviewed by Kenneth Russell.

  • webaudio/resources/audio-testing.js:

(createImpulseBuffer): Fix bug so the buffer has the correct
length.

12:04 Changeset [106973] by mdelaney@apple.com

Remove redundant checks in CanvasRenderingContext2D.cpp
https://bugs.webkit.org/show_bug.cgi?id=78000

Reviewed by Dan Bernstein.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setShadowColor):
(WebCore::CanvasRenderingContext2D::setShadow):
(WebCore::CanvasRenderingContext2D::drawImage):

12:01 Changeset [106972] by inferno@chromium.org

Crash in ContainerNode functions due to mutation events.
https://bugs.webkit.org/show_bug.cgi?id=77999

Reviewed by Ryosuke Niwa.

Source/WebCore:

Add RefPtr to protect premature deletion of this due to mutation events.

Tests: fast/dom/remove-body-during-body-replacement.html

fast/dom/remove-body-during-body-replacement2.html

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::appendChild):

LayoutTests:

  • fast/dom/remove-body-during-body-replacement-expected.txt: Added.
  • fast/dom/remove-body-during-body-replacement.html: Added.
  • fast/dom/remove-body-during-body-replacement2-expected.txt: Added.
  • fast/dom/remove-body-during-body-replacement2.html: Added.
11:59 Changeset [106971] by jsbell@chromium.org

[Chromium] storage/indexeddb/index-cursor.html timeouts on Mac Debug
https://bugs.webkit.org/show_bug.cgi?id=65862

Unreviewed test expectations change. Removed this expectation in r106857
but it's still timing out so restoring it for now.

  • platform/chromium/test_expectations.txt:
11:50 Changeset [106970] by eae@chromium.org

Merging trunk changes up until 106956 into subpixel branch.

11:46 Changeset [106969] by commit-queue@webkit.org

[Chromium] Memory bug during occlusion tracking if Vector::append() needs to reallocate the buffer
https://bugs.webkit.org/show_bug.cgi?id=77996

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-07
Reviewed by James Robinson.

We're holding onto the last element in the Vector and then calling
append(). If append() reallocates the Vector's buffer, the pointer
is no longer valid.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::enterTargetRenderSurface):

11:37 Changeset [106968] by inferno@chromium.org

Source/WebCore: Crash due to column style not updated on post block
in splitInlines.
https://bugs.webkit.org/show_bug.cgi?id=77939

Reviewed by Julien Chaffraix.

Test: fast/multicol/span/split-inline-wrong-post-block-crash.html

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::splitFlow):

LayoutTests: Crash due to column style not updated on post block
in splitInlines.
https://bugs.webkit.org/show_bug.cgi?id=77939

Reviewed by Julien Chaffraix.

  • fast/multicol/span/split-inline-wrong-post-block-crash-expected.txt: Added.
  • fast/multicol/span/split-inline-wrong-post-block-crash.html: Added.
11:34 Changeset [106967] by jchaffraix@webkit.org

Unreviewed gardening.

  • platform/chromium-mac-snowleopard/svg/carto.net/window-expected.txt: Removed.
  • platform/chromium/test_expectations.txt: Added a TEXT output to a test as seen

on the bots.

11:30 Changeset [106966] by commit-queue@webkit.org

[chromium] re-enable fast/repaint/block-selection-gap-in-composited-layer for win/mac
https://bugs.webkit.org/show_bug.cgi?id=77896

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-07
Reviewed by Kenneth Russell.

  • platform/chromium/test_expectations.txt:
11:26 Changeset [106965] by hans@chromium.org

Chromium: remove WebSpeechInputResult::set
https://bugs.webkit.org/show_bug.cgi?id=77977

Reviewed by Darin Fisher.

It was renamed to assign() in r106475.

Source/WebKit/chromium:

  • public/WebSpeechInputResult.h:

Tools:

  • DumpRenderTree/chromium/MockWebSpeechInputController.cpp:

(makeRectResult):

11:18 Changeset [106964] by dino@apple.com

Apple/Safari: Enable WebGL multisampling on ATI cards
for OS X 10.7.2 and above.
https://bugs.webkit.org/show_bug.cgi?id=77922

Address review comments by Alexey Proskuryakov and Mark Rowe.

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::systemAllowsMultisamplingOnATICards):

11:18 Changeset [106963] by mikelawther@chromium.org

composited mask test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=76006

Reviewed by Ojan Vafai.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

  • css3/calc/resources/alpha-gradient.png: Added.
  • css3/calc/simple-composited-mask-expected-mismatch.html: Added.
  • css3/calc/simple-composited-mask.html: Added.
11:03 Changeset [106962] by commit-queue@webkit.org

[Chromium] media/track/track-cue-nothing-to-render.html fails intermittently on Mac
https://bugs.webkit.org/show_bug.cgi?id=75132

Unreviewed, chromium expectations update.
Fixed with http://crrev.com/120714.

Patch by Ami Fischman <fischman@chromium.org> on 2012-02-07

  • platform/chromium/test_expectations.txt:
10:57 Changeset [106961] by carlosgc@webkit.org

[GTK] Add cut, copy and paste methods to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=76998

Reviewed by Martin Robinson.

  • GNUmakefile.am: Add WebKitEditingCommands.h.
  • UIProcess/API/gtk/WebKitEditingCommands.h: Added.
  • UIProcess/API/gtk/WebKitWebView.cpp:

(didValidateCommand): Callback called by the C API when an editor
command has been validated.
(webkit_web_view_can_execute_editing_command): Asynchronously
validate the given editing command.
(webkit_web_view_can_execute_editing_command_finish): Finish async
operation started by webkit_web_view_can_execute_editing_command().
(webkit_web_view_execute_editing_command): Execute the given
command.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
  • UIProcess/API/gtk/tests/GNUmakefile.am:
  • UIProcess/API/gtk/tests/LoadTrackingTest.cpp:

(LoadTrackingTest::provisionalLoadFailed): Do not finish the main
loop on load failure, now finished is always called.

  • UIProcess/API/gtk/tests/TestBackForwardList.cpp: Use WebViewTest

instead of LoadTrackingTest.

  • UIProcess/API/gtk/tests/TestWebViewEditor.cpp: Added.

(testWebViewEditorCutCopyPasteNonEditable):
(testWebViewEditorCutCopyPasteEditable):
(beforeAll):
(afterAll):

  • UIProcess/API/gtk/tests/WebViewTest.cpp:

(loadChanged):
(WebViewTest::waitUntilLoadFinished): Run a main loop until load
finished.

  • UIProcess/API/gtk/tests/WebViewTest.h: Add waitUntilLoadFinished().
  • UIProcess/API/gtk/webkit2.h: Include WebKitEditingCommands.h.
10:55 WebKitGTK/1.6.x edited by mrobinson@webkit.org
(diff)
10:54 Changeset [106960] by rniwa@webkit.org

Dashboard on perf-o-matic should be sorted
https://bugs.webkit.org/show_bug.cgi?id=77924

Reviewed by Tony Chang.

Sort tests in the frontend using the fact ES5 keeps the property order in the insertion order.

  • Websites/webkit-perf.appspot.com/js/config.js:

(fetchDashboardManifest):

10:49 Changeset [106959] by commit-queue@webkit.org

Unreviewed, chromium expectations update.
[Chromium] Layout Test media/media-blocked-by-beforeload.html fails for LEOPARD
https://bugs.webkit.org/show_bug.cgi?id=77412

Fixed with http://crrev.com/120714.

Patch by Ami Fischman <fischman@chromium.org> on 2012-02-07

  • platform/chromium/test_expectations.txt:
09:45 Changeset [106958] by jchaffraix@webkit.org

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:

Mark an SVG test as SLOW.

09:38 Changeset [106957] by vsevik@chromium.org

Web Inspector: CodeGeneratorInspector.py: extend Array validator functionality
https://bugs.webkit.org/show_bug.cgi?id=77919

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-07
Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-07
Reviewed by Yury Semikhatsky.

Array validator method runtimeCast is added, internal backing method
is moved from .cpp to .h (it's template anyway), boolean validator is
supported.

  • inspector/CodeGeneratorInspector.py:

(RawTypes.Bool.get_validate_method_params.ValidateMethodParams):
(RawTypes.Bool.get_validate_method_params):
(TypeBuilder):

09:34 Changeset [106956] by dino@apple.com

Apple/Safari: Enable WebGL multisampling on ATI cards
for OS X 10.7.2 and above.
https://bugs.webkit.org/show_bug.cgi?id=77922

Reviewed by Chris Marrin.

Follow Chrome's lead to allow WebGL antialiasing
on ATI cards as long as we're on 10.7.2 and above.

No new tests. Covered by existing tests.

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::systemAllowsMultisamplingOnATICards):
(WebCore):
(WebCore::GraphicsContext3D::validateAttributes):

09:21 Changeset [106955] by commit-queue@webkit.org

[Chromium] Layout Test media/controls-drag-timebar.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=77531

No more flakiness.

Patch by Ami Fischman <fischman@chromium.org> on 2012-02-07
Reviewed by Eric Carlson.

  • platform/chromium/test_expectations.txt:
09:19 Changeset [106954] by ossy@webkit.org

[Qt][WK2] Unreviewed gardening.

  • platform/qt-wk2/Skipped: Skip failing tests, because we like regressions in trunk.
09:00 Changeset [106953] by pfeldman@chromium.org

Web Inspector: add generic support for undo-ing DOM edits.
https://bugs.webkit.org/show_bug.cgi?id=77875

Reviewed by Yury Semikhatsky.

Source/WebCore:

This change introduces InspectorHistory::Action that encapsulates all DOM modifications
initiated by the inspector. There is a way to undo these actions up until the undoable
state marker.

Tests: inspector/elements/undo-dom-edits-2.html

inspector/elements/undo-dom-edits.html
inspector/styles/undo-add-property.html
inspector/styles/undo-change-property.html
inspector/styles/undo-property-toggle.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/Inspector.json:
  • inspector/InspectorAllInOne.cpp:
  • inspector/InspectorCSSAgent.cpp:

(InspectorCSSAgent::StyleSheetAction):
(WebCore::InspectorCSSAgent::StyleSheetAction::StyleSheetAction):
(WebCore::InspectorCSSAgent::StyleSheetAction::perform):
(WebCore::InspectorCSSAgent::StyleSheetAction::undo):
(WebCore):
(InspectorCSSAgent::SetStyleSheetTextAction):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::SetStyleSheetTextAction):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::perform):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::undo):
(InspectorCSSAgent::SetPropertyTextAction):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::SetPropertyTextAction):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::toString):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::perform):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::undo):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::mergeId):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::merge):
(InspectorCSSAgent::TogglePropertyAction):
(WebCore::InspectorCSSAgent::TogglePropertyAction::TogglePropertyAction):
(WebCore::InspectorCSSAgent::TogglePropertyAction::perform):
(WebCore::InspectorCSSAgent::TogglePropertyAction::undo):
(WebCore::InspectorCSSAgent::getStyleSheetText):
(WebCore::InspectorCSSAgent::setStyleSheetText):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/InspectorDOMAgent.cpp:

(InspectorDOMAgent::DOMAction):
(WebCore::InspectorDOMAgent::DOMAction::DOMAction):
(WebCore::InspectorDOMAgent::DOMAction::perform):
(WebCore::InspectorDOMAgent::DOMAction::undo):
(WebCore):
(InspectorDOMAgent::RemoveChildAction):
(WebCore::InspectorDOMAgent::RemoveChildAction::RemoveChildAction):
(WebCore::InspectorDOMAgent::RemoveChildAction::perform):
(WebCore::InspectorDOMAgent::RemoveChildAction::undo):
(InspectorDOMAgent::InsertBeforeAction):
(WebCore::InspectorDOMAgent::InsertBeforeAction::InsertBeforeAction):
(WebCore::InspectorDOMAgent::InsertBeforeAction::perform):
(WebCore::InspectorDOMAgent::InsertBeforeAction::undo):
(InspectorDOMAgent::RemoveAttributeAction):
(WebCore::InspectorDOMAgent::RemoveAttributeAction::RemoveAttributeAction):
(WebCore::InspectorDOMAgent::RemoveAttributeAction::perform):
(WebCore::InspectorDOMAgent::RemoveAttributeAction::undo):
(InspectorDOMAgent::SetAttributeAction):
(WebCore::InspectorDOMAgent::SetAttributeAction::SetAttributeAction):
(WebCore::InspectorDOMAgent::SetAttributeAction::perform):
(WebCore::InspectorDOMAgent::SetAttributeAction::undo):
(InspectorDOMAgent::SetOuterHTMLAction):
(WebCore::InspectorDOMAgent::SetOuterHTMLAction::SetOuterHTMLAction):
(WebCore::InspectorDOMAgent::SetOuterHTMLAction::perform):
(WebCore::InspectorDOMAgent::SetOuterHTMLAction::undo):
(WebCore::InspectorDOMAgent::SetOuterHTMLAction::newNode):
(InspectorDOMAgent::ReplaceWholeTextAction):
(WebCore::InspectorDOMAgent::ReplaceWholeTextAction::ReplaceWholeTextAction):
(WebCore::InspectorDOMAgent::ReplaceWholeTextAction::perform):
(WebCore::InspectorDOMAgent::ReplaceWholeTextAction::undo):
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::reset):
(WebCore::InspectorDOMAgent::setAttributeValue):
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::removeAttribute):
(WebCore::InspectorDOMAgent::removeNode):
(WebCore::InspectorDOMAgent::setNodeName):
(WebCore::InspectorDOMAgent::setOuterHTML):
(WebCore::InspectorDOMAgent::setNodeValue):
(WebCore::InspectorDOMAgent::moveTo):
(WebCore::InspectorDOMAgent::undo):
(WebCore::InspectorDOMAgent::markUndoableState):

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):
(WebCore::InspectorDOMAgent::history):

  • inspector/InspectorHistory.cpp: Added.

(WebCore::InspectorHistory::Action::Action):
(WebCore):
(WebCore::InspectorHistory::Action::~Action):
(WebCore::InspectorHistory::Action::toString):
(WebCore::InspectorHistory::Action::isUndoableStateMark):
(WebCore::InspectorHistory::Action::mergeId):
(WebCore::InspectorHistory::Action::merge):
(WebCore::InspectorHistory::InspectorHistory):
(WebCore::InspectorHistory::~InspectorHistory):
(WebCore::InspectorHistory::perform):
(WebCore::InspectorHistory::markUndoableState):
(WebCore::InspectorHistory::undo):
(WebCore::InspectorHistory::reset):

  • inspector/InspectorHistory.h: Added.

(WebCore):
(InspectorHistory):
(Action):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyle::styleText):
(WebCore::InspectorStyleSheet::addRule):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
(WebCore::InspectorStyleSheet::buildObjectForStyle):
(WebCore::InspectorStyleSheet::setPropertyText):
(WebCore::InspectorStyleSheet::getText):
(WebCore::InspectorStyleSheetForInlineStyle::getText):

  • inspector/InspectorStyleSheet.h:

(InspectorStyle):
(InspectorStyleSheet):
(InspectorStyleSheetForInlineStyle):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSProperty.prototype.setText):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype._selectedNodeChanged):
(WebInspector.ElementsPanel.prototype._updateSidebars):
(WebInspector.ElementsPanel.prototype.handleShortcut):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.prototype.onpopulate):
(WebInspector.StylePropertiesSection.prototype.addNewBlankProperty):
(WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):
(WebInspector.StylePropertyTreeElement):
(WebInspector.StylePropertyTreeElement.prototype):

LayoutTests:

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.rangeText):
(initialize_ElementTest.InspectorTest.generateUndoTest):

  • inspector/elements/undo-dom-edits-2-expected.txt: Added.
  • inspector/elements/undo-dom-edits-2.html: Added.
  • inspector/elements/undo-dom-edits-expected.txt: Added.
  • inspector/elements/undo-dom-edits.html: Added.
  • inspector/styles/undo-add-property-expected.txt: Added.
  • inspector/styles/undo-add-property.html: Added.
  • inspector/styles/undo-change-property-expected.txt: Added.
  • inspector/styles/undo-change-property.html: Added.
  • inspector/styles/undo-property-toggle-expected.txt: Added.
  • inspector/styles/undo-property-toggle.html: Added.
08:55 Changeset [106952] by tonyg@chromium.org

Unreviewed, more svg rebaselines following change in r106918.

  • platform/chromium-linux/svg/text/text-text-05-t-expected.png:
08:43 Changeset [106951] by tonyg@chromium.org

Unreviewed, rolling out r106935.
http://trac.webkit.org/changeset/106935
https://bugs.webkit.org/show_bug.cgi?id=77994

"Crashes runMultiThread webkit_unit_test" (Requested by tonyg-
cr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-07

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::setNeedsRedraw):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::setNeedsRedraw):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::setNeedsRedraw):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

  • public/WebWidget.h:

(WebWidget):

  • src/WebViewImpl.cpp:
  • src/WebViewImpl.h:

(WebViewImpl):

08:28 Changeset [106950] by ossy@webkit.org

[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
https://bugs.webkit.org/show_bug.cgi?id=52810

  • platform/qt/Skipped: Skip one more test because of this bug.
08:18 Changeset [106949] by commit-queue@webkit.org

Encode radius, force and rotationAngle in WebPlatformTouchPoint.
https://bugs.webkit.org/show_bug.cgi?id=77986

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-07
Reviewed by Kenneth Rohde Christiansen.

  • Shared/WebEvent.h:

(WebKit::WebPlatformTouchPoint::WebPlatformTouchPoint):
(WebPlatformTouchPoint):
(WebKit::WebPlatformTouchPoint::radius):
(WebKit::WebPlatformTouchPoint::rotationAngle):
(WebKit::WebPlatformTouchPoint::force):

  • Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformTouchPoint::WebKit2PlatformTouchPoint):

  • Shared/WebPlatformTouchPoint.cpp:

(WebKit::WebPlatformTouchPoint::WebPlatformTouchPoint):
(WebKit::WebPlatformTouchPoint::encode):
(WebKit::WebPlatformTouchPoint::decode):

08:16 Changeset [106948] by ossy@webkit.org

Unreviewed gardening after r106898. Update platform specific expected results

Patch by Ádám Kallai <Kallai.Adam@stud.u-szeged.hu> on 2012-02-07

  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
08:13 Changeset [106947] by commit-queue@webkit.org

Unreviewed, rolling out r106932.
http://trac.webkit.org/changeset/106932
https://bugs.webkit.org/show_bug.cgi?id=77988

Breaks Mac bots (Requested by pfeldman on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-07

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/Inspector.json:
  • inspector/InspectorAllInOne.cpp:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getStyleSheetText):
(WebCore::InspectorCSSAgent::setStyleSheetText):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::reset):
(WebCore::InspectorDOMAgent::setAttributeValue):
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::removeAttribute):
(WebCore::InspectorDOMAgent::removeNode):
(WebCore::InspectorDOMAgent::setNodeName):
(WebCore::InspectorDOMAgent::setOuterHTML):
(WebCore::InspectorDOMAgent::setNodeValue):
(WebCore::InspectorDOMAgent::moveTo):

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

  • inspector/InspectorHistory.cpp: Removed.
  • inspector/InspectorHistory.h: Removed.
  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyle::styleText):
(WebCore::InspectorStyleSheet::addRule):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
(WebCore::InspectorStyleSheet::buildObjectForStyle):
(WebCore::InspectorStyleSheet::setPropertyText):
(WebCore::InspectorStyleSheet::text):
(WebCore::InspectorStyleSheetForInlineStyle::text):

  • inspector/InspectorStyleSheet.h:

(InspectorStyle):
(InspectorStyleSheet):
(InspectorStyleSheetForInlineStyle):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSProperty.prototype.setText):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype._selectedNodeChanged):
(WebInspector.ElementsPanel.prototype.handleShortcut):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.prototype.onpopulate):
(WebInspector.StylePropertiesSection.prototype.addNewBlankProperty):
(WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):
(WebInspector.StylePropertyTreeElement):
(WebInspector.StylePropertyTreeElement.prototype):

LayoutTests:

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.rangeText):

  • inspector/elements/undo-dom-edits-2-expected.txt: Removed.
  • inspector/elements/undo-dom-edits-2.html: Removed.
  • inspector/elements/undo-dom-edits-expected.txt: Removed.
  • inspector/elements/undo-dom-edits.html: Removed.
  • inspector/styles/undo-add-property-expected.txt: Removed.
  • inspector/styles/undo-add-property.html: Removed.
  • inspector/styles/undo-change-property-expected.txt: Removed.
  • inspector/styles/undo-change-property.html: Removed.
  • inspector/styles/undo-property-toggle-expected.txt: Removed.
  • inspector/styles/undo-property-toggle.html: Removed.
08:09 Changeset [106946] by commit-queue@webkit.org

[Qt] Give emulated touch-point a radius
https://bugs.webkit.org/show_bug.cgi?id=77985

Increase the radius of touch-point and show the actual size of the touch point in the touch-point mockup.

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-07
Reviewed by Kenneth Rohde Christiansen.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::updateVisualMockTouchPoints):

  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::notify):

  • MiniBrowser/qt/qml/MockTouchPoint.qml:
08:00 Changeset [106945] by commit-queue@webkit.org

Update .gitignore for Qt Creator/KDevelop.
https://bugs.webkit.org/show_bug.cgi?id=77984

Patch by Frederik Gladhorn <frederik.gladhorn@nokia.com> on 2012-02-07
Reviewed by Simon Hausmann.

  • .gitignore: Ignore temp files created by Qt Creator and KDevelop.
07:55 Changeset [106944] by commit-queue@webkit.org

[GTK] Broken "HTML5 <scoped style>" detection
https://bugs.webkit.org/show_bug.cgi?id=77979

Patch by Priit Laes <plaes@plaes.org> on 2012-02-07
Reviewed by Gustavo Noronha Silva.

  • configure.ac: Fix wrong variable for HTML5 <style scoped> detection
07:54 Changeset [106943] by tonyg@chromium.org

Unreviewed, a couple more chromium rebaselines after r106918.

  • platform/chromium-mac-leopard/svg/hixie/perf/006-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/hixie/perf/006-expected.png: Added.
07:51 Changeset [106942] by tonyg@chromium.org

Unreviewed, more chromium rebaselines as a result of change in r106918.

  • platform/chromium-mac-leopard/svg/carto.net/tabgroup-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dom/SVGPathSegList-segment-modification-expected.png:
  • platform/chromium-mac-leopard/svg/filters/filter-width-update-expected.png:
  • platform/chromium-mac-leopard/svg/hixie/perf/003-expected.png:
  • platform/chromium-mac-leopard/svg/hixie/perf/004-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/hixie/perf/005-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/hixie/perf/007-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/carto.net/tabgroup-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dom/SVGPathSegList-segment-modification-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/filter-width-update-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/perf/003-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/perf/004-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/perf/005-expected.png: Added.
  • platform/chromium-mac/svg/dom/SVGPathSegList-segment-modification-expected.png: Removed.
  • platform/chromium-mac/svg/filters/filter-width-update-expected.png: Removed.
  • platform/mac/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt: Removed.
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Removed.
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Removed.
  • platform/qt/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt: Removed.
  • platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Removed.
  • platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Removed.
  • svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt: Renamed from LayoutTests/platform/gtk/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt.
  • svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Renamed from LayoutTests/platform/gtk/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt.
  • svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Renamed from LayoutTests/platform/gtk/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt.
07:46 Changeset [106941] by commit-queue@webkit.org

[GTK] Build failure with --enable-web-audio
https://bugs.webkit.org/show_bug.cgi?id=77978

Patch by Priit Laes <plaes@plaes.org> on 2012-02-07
Reviewed by Gustavo Noronha Silva.

  • GNUmakefile.list.am: Include AudioSourceProviderClient.h
07:46 Changeset [106940] by tonyg@chromium.org

Unreviewed chromium rebaseline to account for change in r106918.

  • platform/chromium-linux/svg/text/append-text-node-to-tspan-expected.png: Added.
  • platform/chromium-linux/svg/text/remove-text-node-from-tspan-expected.png: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-linux/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
  • platform/chromium-mac-leopard/svg/carto.net/window-expected.png:
  • platform/chromium-mac-leopard/svg/hixie/perf/001-expected.png: Added.
  • platform/chromium-mac-leopard/svg/hixie/perf/002-expected.png: Added.
  • platform/chromium-mac-leopard/svg/text/text-text-05-t-expected.png: Added.
  • platform/chromium-mac-leopard/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/carto.net/window-expected.png:
  • platform/chromium-mac-snowleopard/svg/carto.net/window-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/carto.net/window-expected.txt.
  • platform/chromium-mac-snowleopard/svg/hixie/perf/001-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/perf/001-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.txt.
  • platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.png:
  • platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.txt:
  • platform/chromium-mac-snowleopard/svg/text/text-text-05-t-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-hixie-mixed-008-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/zoom/page/zoom-hixie-mixed-008-expected.png.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png.
  • platform/chromium-mac-snowleopard/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/text/zoom-hixie-mixed-008-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/zoom/text/zoom-hixie-mixed-008-expected.png.
  • platform/chromium-mac-snowleopard/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png.
  • platform/chromium-win/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
  • platform/chromium-win/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
  • platform/chromium-win/svg/carto.net/window-expected.png:
  • platform/chromium-win/svg/carto.net/window-expected.txt:
  • platform/chromium-win/svg/hixie/perf/001-expected.png:
  • platform/chromium-win/svg/hixie/perf/001-expected.txt:
  • platform/chromium-win/svg/hixie/perf/002-expected.png:
  • platform/chromium-win/svg/hixie/perf/002-expected.txt:
  • platform/chromium-win/svg/text/append-text-node-to-tspan-expected.png: Added.
  • platform/chromium-win/svg/text/append-text-node-to-tspan-expected.txt: Added.
  • platform/chromium-win/svg/text/remove-text-node-from-tspan-expected.png: Added.
  • platform/chromium-win/svg/text/remove-text-node-from-tspan-expected.txt: Added.
  • platform/chromium-win/svg/text/text-text-05-t-expected.png:
  • platform/chromium-win/svg/text/text-text-05-t-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-background-images-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt:
  • platform/chromium-win/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
  • platform/chromium-win/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
  • platform/chromium-win/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
  • platform/mac-snowleopard/svg/zoom/page/zoom-hixie-mixed-008-expected.png: Removed.
  • platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Removed.
  • platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Removed.
  • platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Removed.
  • platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Removed.
  • svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Renamed from LayoutTests/platform/gtk/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt.
  • svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Renamed from LayoutTests/platform/gtk/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt.
07:33 Changeset [106939] by abecsi@webkit.org

[Qt] [WK2] Fix the debug build after r106920

  • WebProcess/qt/WebProcessQt.cpp:

(WebKit::WebProcess::platformSetCacheModel):
Remove unnecessary assert.

07:29 Changeset [106938] by ossy@webkit.org

[Qt] Unreviewed gardening. Update platform specific expected files after r106918.

  • platform/qt/Skipped: Unskip non-existing tests.
  • platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt:
  • platform/qt/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt:
  • platform/qt/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt:
  • platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt:
  • platform/qt/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt:
  • platform/qt/svg/carto.net/tabgroup-expected.png:
  • platform/qt/svg/carto.net/tabgroup-expected.txt:
  • platform/qt/svg/carto.net/window-expected.png:
  • platform/qt/svg/carto.net/window-expected.txt:
  • platform/qt/svg/dom/SVGPathSegList-segment-modification-expected.png:
  • platform/qt/svg/dom/SVGPathSegList-segment-modification-expected.txt:
  • platform/qt/svg/filters/filter-width-update-expected.png:
  • platform/qt/svg/filters/filter-width-update-expected.txt:
  • platform/qt/svg/hixie/perf/003-expected.png:
  • platform/qt/svg/hixie/perf/003-expected.txt:
  • platform/qt/svg/hixie/perf/004-expected.png:
  • platform/qt/svg/hixie/perf/004-expected.txt:
  • platform/qt/svg/hixie/perf/005-expected.png:
  • platform/qt/svg/hixie/perf/005-expected.txt:
  • platform/qt/svg/hixie/perf/006-expected.png:
  • platform/qt/svg/hixie/perf/006-expected.txt:
  • platform/qt/svg/zoom/page/zoom-background-images-expected.png:
  • platform/qt/svg/zoom/page/zoom-background-images-expected.txt:
  • platform/qt/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
  • platform/qt/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
  • platform/qt/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
  • platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.png:
  • platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
  • platform/qt/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png:
  • platform/qt/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
07:27 Changeset [106937] by commit-queue@webkit.org

Web Inspector: fix objects duplication when switching filter in heap profiler.
https://bugs.webkit.org/show_bug.cgi?id=77974

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-02-07
Reviewed by Yury Semikhatsky.

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):

07:22 Changeset [106936] by mario@webkit.org

[GTK] Include gdk-pixbuf in the jhbuild modules
https://bugs.webkit.org/show_bug.cgi?id=77980

Reviewed by Gustavo Noronha Silva.

  • gtk/jhbuild.modules: Add gdk-pixbuf to the jhbuild moduleset.
07:16 Changeset [106935] by commit-queue@webkit.org

[chromium] Add setNeedsRedraw to WebWidget
https://bugs.webkit.org/show_bug.cgi?id=77555

Patch by Jonathan Backer <backer@chromium.org> on 2012-02-07
Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::setNeedsRedraw):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::setNeedsRedraw):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::setNeedsRedraw):
(WebCore::CCThreadProxy::resetDamageTrackerOnImplThread):
(WebCore):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

  • public/WebWidget.h:

(WebWidget):
(WebKit::WebWidget::setNeedsRedraw):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setNeedsRedraw):
(WebKit):

  • src/WebViewImpl.h:

(WebViewImpl):

06:58 BuildingGtk edited by kov@webkit.org
Add libtiff4-dev as a dependency (diff)
06:52 Changeset [106934] by tonyg@chromium.org

Unreviewed gardening.

  • platform/chromium-mac-leopard/fast/canvas/check-stale-putImageData-expected.png: Added. Pixel results for platform font.
06:32 Changeset [106933] by ossy@webkit.org

[Qt][WK2] Compute and set cache capacities using the current CacheModel
https://bugs.webkit.org/show_bug.cgi?id=73918

Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-02-07
Reviewed by Kenneth Rohde Christiansen.

No new tests. (build fix)

  • platform/qt/FileSystemQt.cpp:

(WebCore::getVolumeFreeSizeForPath):

06:00 Changeset [106932] by pfeldman@chromium.org

Web Inspector: add generic support for undo-ing DOM edits.
https://bugs.webkit.org/show_bug.cgi?id=77875

Reviewed by Yury Semikhatsky.

Source/WebCore:

This change introduces InspectorHistory::Action that encapsulates all DOM modifications
initiated by the inspector. There is a way to undo these actions up until the undoable
state marker.

Tests: inspector/elements/undo-dom-edits-2.html

inspector/elements/undo-dom-edits.html
inspector/styles/undo-add-property.html
inspector/styles/undo-change-property.html
inspector/styles/undo-property-toggle.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/Inspector.json:
  • inspector/InspectorAllInOne.cpp:
  • inspector/InspectorCSSAgent.cpp:

(InspectorCSSAgent::StyleSheetAction):
(WebCore::InspectorCSSAgent::StyleSheetAction::StyleSheetAction):
(WebCore::InspectorCSSAgent::StyleSheetAction::perform):
(WebCore::InspectorCSSAgent::StyleSheetAction::undo):
(WebCore):
(InspectorCSSAgent::SetStyleSheetTextAction):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::SetStyleSheetTextAction):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::perform):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::undo):
(InspectorCSSAgent::SetPropertyTextAction):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::SetPropertyTextAction):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::toString):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::perform):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::undo):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::mergeId):
(WebCore::InspectorCSSAgent::SetPropertyTextAction::merge):
(InspectorCSSAgent::TogglePropertyAction):
(WebCore::InspectorCSSAgent::TogglePropertyAction::TogglePropertyAction):
(WebCore::InspectorCSSAgent::TogglePropertyAction::perform):
(WebCore::InspectorCSSAgent::TogglePropertyAction::undo):
(WebCore::InspectorCSSAgent::getStyleSheetText):
(WebCore::InspectorCSSAgent::setStyleSheetText):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::reset):
(WebCore::InspectorDOMAgent::setAttributeValue):
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::removeAttribute):
(WebCore::InspectorDOMAgent::removeNode):
(WebCore::InspectorDOMAgent::setNodeName):
(WebCore::InspectorDOMAgent::setOuterHTML):
(WebCore::InspectorDOMAgent::setNodeValue):
(WebCore::InspectorDOMAgent::moveTo):
(WebCore::InspectorDOMAgent::undo):
(WebCore):
(WebCore::InspectorDOMAgent::markUndoableState):

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):
(WebCore::InspectorDOMAgent::history):

  • inspector/InspectorHistory.cpp: Added.

(WebCore::InspectorHistory::Action::Action):
(WebCore):
(WebCore::InspectorHistory::Action::~Action):
(WebCore::InspectorHistory::Action::toString):
(WebCore::InspectorHistory::Action::isUndoableStateMark):
(WebCore::InspectorHistory::Action::mergeId):
(WebCore::InspectorHistory::Action::merge):
(WebCore::InspectorHistory::InspectorHistory):
(WebCore::InspectorHistory::~InspectorHistory):
(WebCore::InspectorHistory::perform):
(WebCore::InspectorHistory::markUndoableState):
(WebCore::InspectorHistory::undo):
(WebCore::InspectorHistory::reset):

  • inspector/InspectorHistory.h: Added.

(WebCore):
(InspectorHistory):
(Action):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyle::styleText):
(WebCore::InspectorStyleSheet::addRule):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
(WebCore::InspectorStyleSheet::buildObjectForStyle):
(WebCore::InspectorStyleSheet::setPropertyText):
(WebCore::InspectorStyleSheet::getText):
(WebCore::InspectorStyleSheetForInlineStyle::getText):

  • inspector/InspectorStyleSheet.h:

(InspectorStyle):
(InspectorStyleSheet):
(InspectorStyleSheetForInlineStyle):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSProperty.prototype.setText):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype._selectedNodeChanged):
(WebInspector.ElementsPanel.prototype._updateSidebars):
(WebInspector.ElementsPanel.prototype.handleShortcut):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.prototype.onpopulate):
(WebInspector.StylePropertiesSection.prototype.addNewBlankProperty):
(WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):
(WebInspector.StylePropertyTreeElement):
(WebInspector.StylePropertyTreeElement.prototype):

LayoutTests:

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.rangeText):
(initialize_ElementTest.InspectorTest.generateUndoTest):

  • inspector/elements/undo-dom-edits-2-expected.txt: Added.
  • inspector/elements/undo-dom-edits-2.html: Added.
  • inspector/elements/undo-dom-edits-expected.txt: Added.
  • inspector/elements/undo-dom-edits.html: Added.
  • inspector/styles/undo-add-property-expected.txt: Added.
  • inspector/styles/undo-add-property.html: Added.
  • inspector/styles/undo-change-property-expected.txt: Added.
  • inspector/styles/undo-change-property.html: Added.
  • inspector/styles/undo-property-toggle-expected.txt: Added.
  • inspector/styles/undo-property-toggle.html: Added.
05:41 Changeset [106931] by commit-queue@webkit.org

[Blackberry] Clean up Networkjob and Networkmanger: remove unused variables in release build and change some public functions into be private ones
https://bugs.webkit.org/show_bug.cgi?id=77926

Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-02-07
Reviewed by Rob Buis.

  1. rename clientIsOk to isClientAvailable.
  2. m_isRunning is only for an ASSERT in NetWorkManager, So move out from

release build but keep available in debug build.

No changes in behavior, so no new tests.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::NetworkJob):
(WebCore::NetworkJob::handleNotifyDataReceived):
(WebCore::NetworkJob::handleNotifyDataSent):
(WebCore::NetworkJob::handleNotifyClose):
(WebCore::NetworkJob::startNewJobWithRequest):
(WebCore::NetworkJob::sendResponseIfNeeded):
(WebCore::NetworkJob::sendMultipartResponseIfNeeded):

  • platform/network/blackberry/NetworkJob.h:

(NetworkJob):
(WebCore::NetworkJob::isClientAvailable):

05:09 Changeset [106930] by abecsi@webkit.org

[Qt][WK2] Add the componentComplete method to WebView
https://bugs.webkit.org/show_bug.cgi?id=77111

Reviewed by Simon Hausmann.

Move the initialization of the interaction engine to componentComplete
in preparation of switching to a Flickable based content positioning
for the touch based WebView.
Suspend the page and delay the dispatch of load success on startup until
the component finished initialization. With this patch instantiating the
WebView in C++ is only possible by creating a QDeclarativeComponent as
the initialization depends on the componentComplete method being called.
Also return valid default values in the viewport info functions if the
interaction engine is not yet initialized because the viewport info
component could finish initialization earlier than the WebView, which
results in QML warnings during MiniBrowser startup.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::loadDidSucceed):
(QQuickWebViewFlickablePrivate::QQuickWebViewFlickablePrivate):
(QQuickWebViewFlickablePrivate::initialize):
(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebViewFlickablePrivate::loadDidSucceed):
(QQuickWebViewFlickablePrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::_q_resume):
(QQuickWebView::geometryChanged):
(QQuickWebView::componentComplete):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate::onComponentComplete):
(QQuickWebViewPrivate):
(QQuickWebViewFlickablePrivate):

  • UIProcess/API/qt/qwebviewportinfo.cpp:

(QWebViewportInfo::currentScale):
(QWebViewportInfo::devicePixelRatio):
(QWebViewportInfo::initialScale):
(QWebViewportInfo::minimumScale):
(QWebViewportInfo::maximumScale):
(QWebViewportInfo::isScalable):
(QWebViewportInfo::layoutSize):

  • UIProcess/API/qt/tests/qquickwebview/qquickwebview.pro:
  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::tst_QQuickWebView):
(tst_QQuickWebView::init):
(tst_QQuickWebView::multipleWebViewWindows):
(tst_QQuickWebView::multipleWebViews):

  • UIProcess/qt/QtWebPageLoadClient.cpp:

(QtWebPageLoadClient::dispatchLoadSucceeded):

04:55 Changeset [106929] by commit-queue@webkit.org

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-07

  • DEPS:
04:52 Changeset [106928] by yurys@chromium.org

Web Inspector: don't mark object is queriable if it is only reachable by internal reference
https://bugs.webkit.org/show_bug.cgi?id=77877

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):

LayoutTests:

  • inspector/profiler/heap-snapshot.html:
04:44 Changeset [106927] by ossy@webkit.org

[Qt] New svg/hittest tests introduced in r106882 fail
https://bugs.webkit.org/show_bug.cgi?id=77964

Patch by Ádám Kallai <Kallai.Adam@stud.u-szeged.hu> on 2012-02-07
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped: Skip failing tests until fix.
04:43 Changeset [106926] by loislo@chromium.org

Unreviewed, rolling out r106909.
http://trac.webkit.org/changeset/106909
https://bugs.webkit.org/show_bug.cgi?id=77965

~20 tests are crashing on chromium win release bot. (Requested
by loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-07

  • html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::createShadowSubtree):

  • html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::HTMLKeygenElement):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::createShadowSubtree):

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::createShadowSubtree):

  • html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::createShadowSubtree):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::createShadowSubtree):

04:29 Changeset [106925] by kling@webkit.org

REGRESSION(r106819): ~28% or so performance regression on the ManInBlue HTML benchmark
<http://webkit.org/b/77952>

Reviewed by Andreas Kling.
Patch by Ryosuke Niwa.

The performance regression was caused by using ensureAttributeData() which forces the
regeneration of invalidated attributes ("style" and SVG animatable attributes.)
Added an ensureAttributeDataWithoutUpdate() helper that only ensures the presence
of ElementAttributeData, not the validity of its contents. Use that when grabbing
at an element's inline and attribute styles.

  • dom/Element.h:

(Element):
(WebCore::Element::ensureAttributeDataWithoutUpdate):

  • dom/StyledElement.h:

(WebCore::StyledElement::ensureInlineStyleDecl):
(WebCore::StyledElement::ensureAttributeStyle):

04:23 Changeset [106924] by ossy@webkit.org

[Qt][WK2] Compute and set cache capacities using the current CacheModel
https://bugs.webkit.org/show_bug.cgi?id=73918

Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-02-07
Reviewed by Csaba Osztrogonác.

No new tests. (build fix).

  • platform/qt/FileSystemQt.cpp:
04:12 Changeset [106923] by philn@webkit.org

Unreviewed, GTK svg rebaseline after r106918.

  • platform/gtk/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt:
  • platform/gtk/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt:
  • platform/gtk/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt:
  • platform/gtk/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt:
  • platform/gtk/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt:
  • platform/gtk/svg/carto.net/tabgroup-expected.txt:
  • platform/gtk/svg/carto.net/window-expected.txt:
  • platform/gtk/svg/dom/SVGPathSegList-segment-modification-expected.txt:
  • platform/gtk/svg/filters/filter-width-update-expected.txt:
  • platform/gtk/svg/text/text-text-05-t-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-background-images-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
03:50 Changeset [106922] by commit-queue@webkit.org

Unreviewed, rolling out r106915.
http://trac.webkit.org/changeset/106915
https://bugs.webkit.org/show_bug.cgi?id=77961

because 106912 was rolled out (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-07

  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
  • platform/qt/fast/dom/constructed-objects-prototypes-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
03:45 Changeset [106921] by commit-queue@webkit.org

[EFL][WK2] Add ModuleEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=63608

Patch by YoungTaeck Song <youngtaeck.song@samsung.com> on 2012-02-07
Reviewed by Andreas Kling.

Add first version of ModuleEfl.cpp including load(), unload() and platformFunctionPointer().

  • Platform/Module.h:
  • Platform/efl/ModuleEfl.cpp: Added.

(WebKit::Module::load):
(WebKit::Module::unload):
(WebKit::Module::platformFunctionPointer):

03:42 Changeset [106920] by commit-queue@webkit.org

[Qt][WK2] Compute and set cache capacities using the current CacheModel
https://bugs.webkit.org/show_bug.cgi?id=73918

Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-02-07
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

No new tests. (Not applicable)

Added OS-specific implementation for retrieving the free disk space.

  • platform/FileSystem.h:

(WebCore):

  • platform/qt/FileSystemQt.cpp:

(WebCore::getVolumeFreeSizeForPath):
(WebCore):

Source/WebKit2:

First part of the implementation. The next steps are the implementation
of the API for the Qt WebKit 2 port and the hybrid memory and disk cache.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

(WebProcessCreationParameters):

  • UIProcess/qt/WebContextQt.cpp:

(WebKit::defaultDiskCacheDirectory):
(WebKit):
(WebKit::WebContext::platformInitializeWebProcess):

  • WebProcess/qt/WebProcessQt.cpp:

(WebKit::physicalMemorySizeInBytes):
(WebKit):
(WebKit::WebProcess::platformSetCacheModel):
(WebKit::WebProcess::platformInitializeWebProcess):

03:19 Changeset [106919] by commit-queue@webkit.org

[Qt] Prevent early test termination with newer Qt 5
https://bugs.webkit.org/show_bug.cgi?id=77945

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-02-07
Reviewed by Csaba Osztrogonác.

QTBUG-24120 tracks a regression in Qt that would make layout tests
terminate early. This patch works around it in a Qt 4 + 5 safe manner
by disabling the quitOnLastWindowClosed feature, which we don't want/need
for DRT anyway.

  • DumpRenderTree/qt/main.cpp:

(main): Don't quit on last window closed.

03:19 Changeset [106918] by zimmermann@webkit.org

Rewrite SVG tests to make extensive use of display() in repaint tests
https://bugs.webkit.org/show_bug.cgi?id=77736

Reviewed by Andreas Kling.

Convert all tests in svg/ (except svg/custom & svg/dynamic-updates) that exercise repainting to use the
fast/repaint/resources/repaint.js harness, which forces a layout, and calls layoutTestController.display()
before executing the actual repaint test, so that repaint rectangles are properly tracked and shown (white
areas that are redrawn, on top of the gray background, painted over the web view after the initial painting).

Previously SVG tests used to work like this: (using an HTML example, but it doesn't matter)
<html><body><svg><rect/><script>function change() { rect.setAttribute(...); layoutTestController.notifyDone(); } setTimeout(change, 0); </script></svg></body></html>

We expected that the initial painting was done, before change() as called. This is unreliable for various reasons:

  • the timeout is not guaranteed to fire after the document loaded, it may happen inbetween on eg. a slow connection.
  • nor is it guaranteed that the document has painted initially before we enter change(). This leads to the current regressions -- if we break repainting, we can't see it in the current layout tests, as the initial painting always happens after change() executed in trunk, at least on a fast machine.

In order to make repaint testing reliable we have to use following scheme:
<html><body onload="runRepaintTest()"><svg><rect/><script>function repaintTest() { rect.setAttribute(...); }</script></svg></body></html>

runRepaintTest() is provided by the repaint.js harness and does:
if (window.layoutTestController) {

document.body.offsetTop;
layoutTestController.display();
repaintTest();

} else {

setTimeout(repaintTest, 100);

}

Using this harness outside of DRT allows to test SVG repainting tests in the browser as well, as the repainting changes
aren't immediately fired (0ms timer) but instead delayed by 100ms, so a visual "flash" is visible, if something changes.
For DRT it does two things. First it forces Document::updateLayout() to be called, and then forces the web view to paint
immediately, and then it starts tracking any repaint rects, that are fired _after_ the initial painting, which are then
highlighted in the pixel test dump later on. Using display() is the only way to get reliable painting results across
DRT/WebKitTestRunner, and to get rid of the flakiness.

All *.xml/*.html/*.htm/*.xhtml tests which excersise repainting can be moved to use runRepaintTest() from repaint.js.
<body> needs to be changed to <body onload="runRepaintTest()">, and the timeouts & waitUntilDone/notifyDone calls can
be removed from the tests, leading to much nicer testcases, removing lots of boilerplate.

Pure *.svg tests unfortunately can't use <svg onload="runRepaintTest()"> at the moment, due timing differences between
the HTML load and the SVGLoad event, that's out of scope for this bug report. To remove any hacks from the testcases
themselves, I centralized following work-around in a new function in repaint.js, and let all *.svg tests use it.

function runSVGRepaintTest() {

if (window.layoutTestController) {

layoutTestController.waitUntilDone();
setTimeout(runRepaintTest, 0);

} else

runRepaintTest();

}

runRepaintTest() has to be called from a timer at the moment, as the SVGLoad event fires earlier as HTML load event.
Before that is fixed, we have to use <svg onload="runSVGRepaintTest()"> instead of <svg onload="runRepaintTest()">
and append: layoutTestController.notifyDone() to the repaintTest() functions in the testcases. That should explain
the testcase differences between pure-SVG and non-pure-SVG tests, and why I treated them differently. This approach
is unfortunately as flakey as the old, so to make pure *.svg tests test repainting reliable, the bug needs to be fixed.

Note that svg/custom, and svg/dynamic-updates will be fixed in another chunk, as they also require large amounts
of rebaselines.

  • fast/repaint/resources/repaint.js:

(runRepaintTest):
(runSVGRepaintTest):

  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/as-background-image/animated-svg-as-background-expected.png:
  • platform/mac/svg/as-image/animated-svg-as-image-expected.png:
  • platform/mac/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png:
  • platform/mac/svg/as-image/animated-svg-as-image-same-image-expected.png:
  • platform/mac/svg/as-image/svg-image-change-content-size-expected.png:
  • platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png:
  • platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt:
  • platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png:
  • platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt:
  • platform/mac/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png:
  • platform/mac/svg/as-object/embedded-svg-size-changes-expected.png:
  • platform/mac/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.png:
  • platform/mac/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt:
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-expected.png:
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png:
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt:
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png:
  • platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt:
  • platform/mac/svg/carto.net/tabgroup-expected.png:
  • platform/mac/svg/carto.net/tabgroup-expected.txt:
  • platform/mac/svg/carto.net/window-expected.png:
  • platform/mac/svg/carto.net/window-expected.txt:
  • platform/mac/svg/css/shadow-changes-expected.png:
  • platform/mac/svg/dom/SVGPathSegList-segment-modification-expected.png:
  • platform/mac/svg/dom/SVGPathSegList-segment-modification-expected.txt:
  • platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png:
  • platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png:
  • platform/mac/svg/dom/SVGRectElement/rect-modify-rx-expected.png:
  • platform/mac/svg/filters/filter-refresh-expected.png:
  • platform/mac/svg/filters/filter-width-update-expected.png:
  • platform/mac/svg/filters/filter-width-update-expected.txt:
  • platform/mac/svg/filters/invalidate-on-child-layout-expected.png:
  • platform/mac/svg/hixie/perf/001-expected.png:
  • platform/mac/svg/hixie/perf/002-expected.png:
  • platform/mac/svg/hixie/perf/003-expected.png:
  • platform/mac/svg/hixie/perf/003-expected.txt:
  • platform/mac/svg/hixie/perf/004-expected.png:
  • platform/mac/svg/hixie/perf/004-expected.txt:
  • platform/mac/svg/hixie/perf/005-expected.png:
  • platform/mac/svg/hixie/perf/005-expected.txt:
  • platform/mac/svg/hixie/perf/006-expected.png:
  • platform/mac/svg/hixie/perf/006-expected.txt:
  • platform/mac/svg/hixie/perf/007-expected.png:
  • platform/mac/svg/hixie/perf/007-expected.txt:
  • platform/mac/svg/repaint/filter-child-repaint-expected.png:
  • platform/mac/svg/repaint/image-href-change-expected.png:
  • platform/mac/svg/repaint/image-with-clip-path-expected.png:
  • platform/mac/svg/text/append-text-node-to-tspan-expected.png:
  • platform/mac/svg/text/modify-text-node-in-tspan-expected.png:
  • platform/mac/svg/text/remove-text-node-from-tspan-expected.png:
  • platform/mac/svg/text/remove-tspan-from-text-expected.png:
  • platform/mac/svg/text/text-text-05-t-expected.png:
  • platform/mac/svg/text/text-text-05-t-expected.txt:
  • platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.png:
  • platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png:
  • platform/mac/svg/zoom/page/zoom-background-images-expected.txt:
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
  • platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png:
  • platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt:
  • platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png:
  • platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
  • platform/mac/svg/zoom/page/zoom-svg-as-image-expected.png:
  • platform/mac/svg/zoom/page/zoom-svg-as-object-expected.png:
  • platform/mac/svg/zoom/page/zoom-svg-as-relative-image-expected.png:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
  • platform/mac/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.png:
  • platform/mac/svg/zoom/text/absolute-sized-document-scrollbars-expected.png:
  • platform/mac/svg/zoom/text/relative-sized-document-scrollbars-expected.png:
  • platform/mac/svg/zoom/text/zoom-foreignObject-expected.png:
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.png:
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-009-expected.png:
  • platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png:
  • platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
  • svg/as-background-image/animated-svg-as-background.html:
  • svg/as-background-image/resources/animated-rect-relative-size.svg:
  • svg/as-background-image/svg-as-background-5.html:
  • svg/as-background-image/svg-background-partial-redraw.html:
  • svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size.html:
  • svg/as-image/animated-svg-as-image-same-image.html:
  • svg/as-image/animated-svg-as-image.html:
  • svg/as-image/resources/animated-rect-fixed-size-2.svg: Copied from LayoutTests/svg/as-image/resources/animated-rect-same-image.svg.
  • svg/as-image/resources/animated-rect-fixed-size.svg:
  • svg/as-image/resources/animated-rect-relative-size.svg:
  • svg/as-image/resources/animated-rect-same-image.svg:
  • svg/as-image/svg-image-change-content-size.xhtml:
  • svg/as-object/embedded-svg-immediate-offsetWidth-query.html:
  • svg/as-object/embedded-svg-size-changes-no-layout-triggers.html:
  • svg/as-object/embedded-svg-size-changes.html:
  • svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1.html:
  • svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2.html:
  • svg/as-object/nested-embedded-svg-size-changes.html:
  • svg/as-object/resources/embedded-svg-size-changes-no-layout-triggers.svg:
  • svg/as-object/resources/nested-embedded-svg-size-changes-target-no-layout-triggers-1.html:
  • svg/carto.net/tabgroup.svg:
  • svg/carto.net/window.svg:
  • svg/css/shadow-changes.svg:
  • svg/dom/SVGPathSegList-segment-modification.svg:
  • svg/dom/SVGPathSegList-xml-dom-synchronization.xhtml:
  • svg/dom/SVGPathSegList-xml-dom-synchronization2.xhtml:
  • svg/dom/SVGRectElement/rect-modify-rx.svg:
  • svg/filters/animate-fill-expected.png:
  • svg/filters/animate-fill.svg:
  • svg/filters/feImage-reference-invalidation-expected.png:
  • svg/filters/feImage-reference-invalidation.svg:
  • svg/filters/feImage-target-add-to-document-expected.png:
  • svg/filters/feImage-target-add-to-document.svg:
  • svg/filters/feImage-target-changes-id-expected.png:
  • svg/filters/feImage-target-changes-id.svg:
  • svg/filters/feImage-target-id-change-expected.png:
  • svg/filters/feImage-target-id-change.svg:
  • svg/filters/feImage-target-reappend-to-document-expected.png:
  • svg/filters/feImage-target-reappend-to-document.svg:
  • svg/filters/feImage-target-remove-from-document-expected.png:
  • svg/filters/feImage-target-remove-from-document.svg:
  • svg/filters/filter-refresh.svg:
  • svg/filters/filter-width-update.svg:
  • svg/filters/invalidate-on-child-layout.svg:
  • svg/hixie/perf/001.xml:
  • svg/hixie/perf/002.xml:
  • svg/hixie/perf/003.xml:
  • svg/hixie/perf/004.xml:
  • svg/hixie/perf/005.xml:
  • svg/hixie/perf/006.xml:
  • svg/hixie/perf/007.xml:
  • svg/hixie/perf/resources/smallcats.gif: Added.
  • svg/repaint/container-repaint-expected.png:
  • svg/repaint/container-repaint.svg:
  • svg/repaint/filter-child-repaint.svg:
  • svg/repaint/image-href-change.svg:
  • svg/repaint/image-with-clip-path.svg:
  • svg/text/append-text-node-to-tspan.html:
  • svg/text/modify-text-node-in-tspan.html:
  • svg/text/remove-text-node-from-tspan.html:
  • svg/text/remove-tspan-from-text.html:
  • svg/text/text-text-05-t.svg:
  • svg/transforms/animated-path-inside-transformed-html.xhtml:
  • svg/zoom/page/absolute-sized-document-no-scrollbars.svg:
  • svg/zoom/page/absolute-sized-document-scrollbars.svg:
  • svg/zoom/page/relative-sized-document-scrollbars.svg:
  • svg/zoom/page/zoom-background-image-tiled.html:
  • svg/zoom/page/zoom-background-images.html:
  • svg/zoom/page/zoom-coords-viewattr-01-b.svg:
  • svg/zoom/page/zoom-foreignObject.svg:
  • svg/zoom/page/zoom-getBoundingClientRect.xhtml:
  • svg/zoom/page/zoom-hixie-mixed-008.xml:
  • svg/zoom/page/zoom-hixie-mixed-009.xml:
  • svg/zoom/page/zoom-hixie-rendering-model-004.xhtml:
  • svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html:
  • svg/zoom/page/zoom-mask-with-percentages.svg:
  • svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm:
  • svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox.html:
  • svg/zoom/page/zoom-svg-as-background-with-relative-size.html:
  • svg/zoom/page/zoom-svg-as-image.html:
  • svg/zoom/page/zoom-svg-as-object.html:
  • svg/zoom/page/zoom-svg-as-relative-image.html:
  • svg/zoom/page/zoom-svg-float-border-padding.xml:
  • svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml:
  • svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml:
  • svg/zoom/page/zoom-svg-through-object-with-auto-size.html:
  • svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml:
  • svg/zoom/page/zoom-svg-through-object-with-override-size.html:
  • svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml:
  • svg/zoom/page/zoom-svg-through-object-with-text.xhtml-disabled:
  • svg/zoom/page/zoom-zoom-coords.xhtml:
  • svg/zoom/resources/testPageZoom.js:

(repaintTest):

  • svg/zoom/resources/testTextZoom.js:

(repaintTest):

  • svg/zoom/text/absolute-sized-document-no-scrollbars.svg:
  • svg/zoom/text/absolute-sized-document-scrollbars.svg:
  • svg/zoom/text/relative-sized-document-scrollbars.svg:
  • svg/zoom/text/zoom-coords-viewattr-01-b.svg:
  • svg/zoom/text/zoom-foreignObject.svg:
  • svg/zoom/text/zoom-hixie-mixed-008.xml:
  • svg/zoom/text/zoom-hixie-mixed-009.xml:
  • svg/zoom/text/zoom-hixie-rendering-model-004.xhtml:
  • svg/zoom/text/zoom-svg-float-border-padding.xml:
03:10 Changeset [106917] by kenneth@webkit.org

[Inspector] Add the Nokia N9 user agent
https://bugs.webkit.org/show_bug.cgi?id=77949

Reviewed by Simon Hausmann.

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.get const):

02:29 Changeset [106916] by apavlov@chromium.org

[CRASH] bool EventHandler::dispatchSyntheticTouchEventIfEnabled(const PlatformMouseEvent& event) references a NULL pointer
https://bugs.webkit.org/show_bug.cgi?id=77953

Reviewed by Andreas Kling.

  • page/EventHandler.cpp:

(WebCore::EventHandler::dispatchSyntheticTouchEventIfEnabled):

02:22 Changeset [106915] by commit-queue@webkit.org

GTK & QT Rebaseline after r106912.
https://bugs.webkit.org/show_bug.cgi?id=77942

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2012-02-07
Reviewed by David Levin.

  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
  • platform/qt/fast/dom/constructed-objects-prototypes-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
01:51 Applications using WebKit edited by renhuan@360.cn
(diff)
01:44 Changeset [106914] by haraken@chromium.org

Unreviewed, rolling out r106912.
http://trac.webkit.org/changeset/106912
https://bugs.webkit.org/show_bug.cgi?id=77947

"AppleWebKit build is broken" (Requested by haraken on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-07

Source/WebCore:

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore):

  • dom/ScriptExecutionContext.h:

(WebCore):
(ScriptExecutionContext):

  • html/DOMURL.cpp:

(WebCore::DOMURL::DOMURL):
(WebCore):
(WebCore::DOMURL::~DOMURL):
(WebCore::DOMURL::contextDestroyed):
(WebCore::DOMURL::createObjectURL):
(WebCore::DOMURL::revokeObjectURL):

  • html/DOMURL.h:

(WebCore::DOMURL::create):
(DOMURL):

  • html/DOMURL.idl:
  • html/PublicURLManager.h: Removed.
  • page/DOMWindow.cpp:

(WebCore):
(WebCore::DOMWindow::webkitURL):

  • page/DOMWindow.h:

(DOMWindow):

  • page/DOMWindow.idl:
  • workers/WorkerContext.cpp:

(WebCore):
(WebCore::WorkerContext::webkitURL):

  • workers/WorkerContext.h:

(WorkerContext):

  • workers/WorkerContext.idl:

LayoutTests:

  • fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt: Removed.
  • fast/dom/DOMURL/check-instanceof-domurl-functions.html: Removed.
01:28 Applications using WebKit edited by whzeng@126.com
(diff)
00:54 Changeset [106913] by haraken@chromium.org

Unreviewed, rolling out r106862.
http://trac.webkit.org/changeset/106862
https://bugs.webkit.org/show_bug.cgi?id=77510

Mac build fails if we manually remove generated code

  • DerivedSources.make:
  • bindings/scripts/generate-bindings.pl:

(generateEmptyHeaderAndCpp):

  • bindings/scripts/resolve-supplemental.pl:
  • bindings/scripts/update-idl-needs-rebuild.pl: Removed.
00:40 Applications using WebKit edited by renhuan@360.cn
(diff)
00:18 Changeset [106912] by commit-queue@webkit.org

Migrate createObjectURL & revokeObjectURL to static (Class) methods.
https://bugs.webkit.org/show_bug.cgi?id=74386

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2012-02-07
Reviewed by David Levin.

Source/WebCore:

Test: fast/dom/DOMURL/check-instanceof-domurl-functions.html
Already Existing:

fast/files/revoke-blob-url.html
fast/dom/window-domurl-crash.html
fast/files/apply-blob-url-to-img.html
fast/files/create-blob-url-crash.html
fast/files/workers/inline-worker-via-blob-url.html

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::fileThread):
(WebCore):
(WebCore::ScriptExecutionContext::publicURLManager):

  • dom/ScriptExecutionContext.h:

(WebCore):
(ScriptExecutionContext):

  • html/DOMURL.cpp:

(WebCore):
(WebCore::DOMURL::createObjectURL): Changed to static.
(WebCore::DOMURL::revokeObjectURL): ditto.

  • html/DOMURL.h:

(DOMURL):
(WebCore::DOMURL::create):

  • html/DOMURL.idl:
  • html/PublicURLManager.h: Added.

(WebCore):
(PublicURLManager):
(WebCore::PublicURLManager::create):
(WebCore::PublicURLManager::contextDestroyed):
(WebCore::PublicURLManager::blobURLs):
(WebCore::PublicURLManager::streamURLs):

  • page/DOMWindow.cpp: Removed object initialization for DOMURL.

(WebCore):

  • page/DOMWindow.h: ditto.

(DOMWindow):

  • page/DOMWindow.idl:
  • workers/WorkerContext.cpp:

(WebCore):

  • workers/WorkerContext.h:

(WorkerContext):

  • workers/WorkerContext.idl:

LayoutTests:

Added test to check if createObjectURL & revokeObjectURL are static functions.

  • fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt: Added.
  • fast/dom/DOMURL/check-instanceof-domurl-functions.html: Added.
00:16 Changeset [106911] by vsevik@chromium.org

http/tests/inspector/indexeddb/database-structure.html failing on chromium win/linux
https://bugs.webkit.org/show_bug.cgi?id=77661

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):

LayoutTests:

  • platform/chromium/test_expectations.txt:
00:09 Changeset [106910] by hayato@chromium.org

Fix build on Mac with '--shadow-dom'.
https://bugs.webkit.org/show_bug.cgi?id=77940

Reviewed by Hajime Morita.

  • WebCore.xcodeproj/project.pbxproj:

02/06/12:

23:25 Changeset [106909] by commit-queue@webkit.org

Stop calling Element::ensureShadowRoot() if it is used in construction phase.
https://bugs.webkit.org/show_bug.cgi?id=77929

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-06
Reviewed by Hajime Morita.

ShadowRoot's life cycle can be consufing If Element::ensureShadowRoot() is used.
So we want to remove Element::ensureShadowRoot().
This patch replaces Element::ensureShadowRoot() if it is used in object construction phase.

No new tests, no change in behavior.

  • html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::createShadowSubtree):

  • html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::HTMLKeygenElement):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::createShadowSubtree):

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::createShadowSubtree):

  • html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::createShadowSubtree):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::createShadowSubtree):

23:22 Changeset [106908] by commit-queue@webkit.org

[EFL] Define to prevent a single backing-store application from calling the tiled view function.
https://bugs.webkit.org/show_bug.cgi?id=77842

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2012-02-06
Reviewed by Andreas Kling.

The define prevents an application using single backing store from calling tiled cache function.
The tiled APIs opened to outer should check the view type before being called.

  • ewk/ewk_private.h:
  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(ewk_view_frame_view_creation_notify):

  • ewk/ewk_view_tiled.cpp:

(ewk_view_tiled_unused_cache_get):
(ewk_view_tiled_unused_cache_set):

23:09 Changeset [106907] by commit-queue@webkit.org

Remove Element::ensureShadowRoot export.
https://bugs.webkit.org/show_bug.cgi?id=77932

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-06
Reviewed by Hajime Morita.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

Removes Element::ensureShadowRoot export.

No new tests, no change in behavior.

  • WebCore.exp.in:

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
22:33 Changeset [106906] by abarth@webkit.org

http/tests/security/xssAuditor/cookie-injection.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=77908

Reviewed by Eric Seidel.

Before this patch, the output of this test depended on the state of the
global cookie store. When running tests in parallel, the cookie store
is shared by multiple tests, and so its state varies from run to run.

This patch changes this test to look only for the specific cookie used
by this test, which should make the test more reliable when run in
parallel with other tests.

  • http/tests/security/xssAuditor/cookie-injection-expected.txt:
  • http/tests/security/xssAuditor/resources/echo-intertag.pl:
  • platform/chromium/test_expectations.txt:
21:45 Changeset [106905] by loislo@chromium.org

Unreviewed. Web Inspector: rename Artificial to Synthetic according to v8 patch r10614.

  • inspector/front-end/DetailedHeapshotGridNodes.js:
  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.get isSynthetic):
(WebInspector.HeapSnapshot.prototype._init):

21:44 Changeset [106904] by commit-queue@webkit.org

[EFL] Adopt C++ style using camelCase and full variable names.
https://bugs.webkit.org/show_bug.cgi?id=76378

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2012-02-06
Reviewed by Andreas Kling.

Modify the code to use camelCase and spell out variable names instead of using abbreviations.
Modify the comments which do not match with actual parameters and correct misspelled words.
Adopt EFL Coding style in header files.
The logic of the code is not changed.

  • ewk/ewk_cookies.h:
  • ewk/ewk_frame.cpp:

(ewk_frame_selection_get):
(ewk_frame_feed_focus_in):
(EWKPrivate::coreFrame):

  • ewk/ewk_frame.h:
  • ewk/ewk_history.cpp:

(ewk_history_item_new):
(ewk_history_item_title_get):
(ewk_history_item_title_alternate_get):
(ewk_history_item_uri_get):
(ewk_history_item_uri_original_get):

  • ewk/ewk_network.h:
  • ewk/ewk_tiled_backing_store.cpp:

(_Ewk_Tiled_Backing_Store_Item):
(_Ewk_Tiled_Backing_Store_Data):
(_ewk_tiled_backing_store_tile_associate):
(_ewk_tiled_backing_store_tile_dissociate):
(_ewk_tiled_backing_store_pre_render_request_clear):
(_ewk_tiled_backing_store_pre_render_request_process_single):
(_ewk_tiled_backing_store_item_fill):
(_ewk_tiled_backing_store_item_add):
(_ewk_tiled_backing_store_item_smooth_scale_set):
(_ewk_tiled_backing_store_view_cols_end_add):
(_ewk_tiled_backing_store_view_rows_all_del):
(_ewk_tiled_backing_store_render):
(_ewk_tiled_backing_store_mem_dbg):
(_ewk_tiled_backing_store_sig_usr):
(_ewk_tiled_backing_store_smart_add):
(_ewk_tiled_backing_store_smart_del):
(_ewk_tiled_backing_store_smart_move):
(_ewk_tiled_backing_store_smart_resize):
(_ewk_tiled_backing_store_recalc_renderers):
(_ewk_tiled_backing_store_view_dbg):
(_ewk_tiled_backing_store_view_wrap_up):
(_ewk_tiled_backing_store_view_wrap_down):
(_ewk_tiled_backing_store_view_wrap_left):
(_ewk_tiled_backing_store_view_refill):
(_ewk_tiled_backing_store_view_pos_apply):
(_ewk_tiled_backing_store_smart_calculate_offset_force):
(_ewk_tiled_backing_store_smart_calculate_offset):
(_ewk_tiled_backing_store_smart_calculate_pos):
(_ewk_tiled_backing_store_smart_calculate):
(_ewk_tiled_backing_store_scroll_full_offset_set_internal):
(ewk_tiled_backing_store_scroll_full_offset_set):
(ewk_tiled_backing_store_scroll_full_offset_add):
(_ewk_tiled_backing_store_zoom_set_internal):
(ewk_tiled_backing_store_zoom_set):
(ewk_tiled_backing_store_zoom_weak_set):
(ewk_tiled_backing_store_fix_offsets):
(ewk_tiled_backing_store_flush):
(ewk_tiled_backing_store_pre_render_region):
(ewk_tiled_backing_store_pre_render_relative_radius):

  • ewk/ewk_tiled_backing_store.h:

(_Ewk_Tile):

  • ewk/ewk_tiled_matrix.cpp:

(_Ewk_Tile_Matrix):
(_ewk_tile_matrix_cell_free):
(_ewk_tile_matrix_tile_free):
(ewk_tile_matrix_new):
(ewk_tile_matrix_free):
(ewk_tile_matrix_unused_cache_get):
(ewk_tile_matrix_tile_exact_get):
(ewk_tile_matrix_tile_new):
(ewk_tile_matrix_tile_put):
(ewk_tile_matrix_dbg):
(ewk_tile_matrix_freeze):
(ewk_tile_matrix_thaw):

  • ewk/ewk_tiled_matrix.h:
  • ewk/ewk_tiled_model.cpp:

(tile_account):
(ewk_tile_updates_process):
(ewk_tile_unused_cache_tile_put):
(ewk_tile_unused_cache_dbg):

  • ewk/ewk_tiled_model.h:
  • ewk/ewk_util.h:
  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_smart_focus_in):
(_ewk_view_smart_pre_render_region):
(ewk_view_pre_render_region):
(ewk_view_toolbars_visible_get):
(ewk_view_statusbar_visible_get):
(ewk_view_scrollbars_visible_get):
(ewk_view_menubar_visible_get):
(ewk_view_zoom_range_set):

  • ewk/ewk_view.h:
  • ewk/ewk_view_single.cpp:

(_ewk_view_single_smart_repaints_process):

  • ewk/ewk_view_tiled.cpp:

(_ewk_view_tiled_smart_backing_store_add):
(_ewk_view_tiled_smart_add):
(ewk_view_tiled_unused_cache_get):
(ewk_view_tiled_unused_cache_set):

21:09 Changeset [106903] by leo.yang@torchmobile.com.cn

[BlackBerry] Use WebPagePrivate instead of WebPage in GeolocationControllerClientBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=77927

Reviewed by Antonio Gomes.

WebKit/blackberry/Api/WebPage which has a d pointer is designed for public API.
GeolocationControllerClientBlackBerry in WebKit/blackberry/WebCoreSupport should
use the d pointer directly because the client is internal implementation.

No functionalities changed, no new tests.

  • blackberry/WebCoreSupport/GeolocationControllerClientBlackBerry.cpp:

(GeolocationControllerClientBlackBerry::GeolocationControllerClientBlackBerry):
(GeolocationControllerClientBlackBerry::requestPermission):
(GeolocationControllerClientBlackBerry::cancelPermissionRequest):
(GeolocationControllerClientBlackBerry::onLocationUpdate):
(GeolocationControllerClientBlackBerry::onLocationError):

  • blackberry/WebCoreSupport/GeolocationControllerClientBlackBerry.h:

(WebKit):
(GeolocationControllerClientBlackBerry):

20:47 Changeset [106902] by hayato@chromium.org

Implement querySelector on ShadowRoot.
https://bugs.webkit.org/show_bug.cgi?id=77714

Reviewed by Dimitri Glazkov.

Source/WebCore:

  • dom/SelectorQuery.cpp:

(WebCore::nodeIsRootNodeOfTreeScope):
(WebCore):
(WebCore::SelectorDataList::execute):

LayoutTests:

  • fast/dom/shadow/shadow-root-js-api-expected.txt:
  • fast/dom/shadow/shadow-root-js-api.html:
20:41 Changeset [106901] by mrobinson@webkit.org

[GTK] Add TextureMapperGL implementation
https://bugs.webkit.org/show_bug.cgi?id=75308

.:

Patch by Martin Robinson <mrobinson@igalia.com> and Nayan Kumar K <nayankk@motorola.com> on 2012-02-06
Reviewed by Alejandro G. Castro.

  • GNUmakefile.am: TextureMapperGL implies USE(TEXTURE_MAPPER)
  • configure.ac: Only allow enabling the GL version of TextureMapper on X11.

Source/WebCore:

Patch by Martin Robinson <mrobinson@igalia.com> and Nayan Kumar K <nayankk@motorola.com> on 2012-02-06
Reviewed by Alejandro G. Castro.

No new tests. This will be covered by accelerated compositing and
3D CSS transform tests eventually.

  • GNUmakefile.list.am: Added some files necessary to build TextureMapperGL.
  • platform/graphics/cairo/TextureMapperGLCairo.cpp: Added implementations.
  • platform/graphics/cairo/TextureMapperGLCairo.h: Updated member list.
  • platform/graphics/gtk/WindowGLContext.h: Added.
  • platform/graphics/gtk/WindowGLContextGLX.cpp: Added.
  • platform/graphics/opengl/TextureMapperGL.cpp: Use the GL shims on GTK.

Source/WebKit/gtk:

Patch by Martin Robinson <mrobinson@igalia.com> and Nayan Kumar K <nayankk@motorola.com> on 2012-02-06
Reviewed by Alejandro G. Castro.

  • GNUmakefile.am: Add AcceleratedCompositingContextGL to the list.
  • WebCoreSupport/AcceleratedCompositingContext.h:

(AcceleratedCompositingContext): Added some members for AcceleratedCompositingContextGL.

  • WebCoreSupport/AcceleratedCompositingContextClutter.cpp: Added empty implementations

for GraphicsLayerClient. This is only used for the GL variant.

  • WebCoreSupport/AcceleratedCompositingContextGL.cpp: Added.
  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::performAllPendingScrolls): Update the root layer while scrolling.
(WebKit::ChromeClient::paint): Update the root layer after painting.

  • webkit/webkitwebsettings.cpp: Added an enable-accelerated-compositing setting.
  • webkit/webkitwebsettingsprivate.h: Ditto.
  • webkit/webkitwebview.cpp:

(webkit_web_view_draw): Call into TextureMapper now.
(webkit_web_view_realize): Use gdk_window_ensure_native here.
(webkit_web_view_update_settings): Support the new enable-accelerated-compositing setting.
(webkit_web_view_settings_notify): Ditto.

Source/WebKit2:

Reviewed by Alejandro G. Castro.

Fix the WebKit2 + AC build for GTK+.

  • GNUmakefile.am: Add some missing source files.
  • UIProcess/DrawingAreaProxy.cpp:

(WebKit): Add USE(TILED_BACKING_STORE) to the guard.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage): Ditto.

  • WebProcess/WebPage/DrawingArea.h:

(DrawingArea): Ditto.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit): Ditto.

  • WebProcess/WebPage/DrawingAreaImpl.h:

(DrawingAreaImpl): Ditto.

20:26 Changeset [106900] by eae@chromium.org

Change baselinePosition and lineHeight to LayoutUnit
https://bugs.webkit.org/show_bug.cgi?id=77905

Reviewed by Eric Seidel.

Change the virtual baselinePosition and lineHeight methods to return
LayoutUnits as they are both computed from the height and top/bottom
margins (or width and left/right margins for vertical text), all of
which are LayoutUnits.

No new tests.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::baselinePosition):

  • platform/efl/RenderThemeEfl.h:

(RenderThemeEfl):

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::baselinePosition):

  • platform/gtk/RenderThemeGtk.h:

(RenderThemeGtk):

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::baselinePosition):

  • platform/qt/RenderThemeQt.h:

(RenderThemeQt):

  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::lineHeight):
(WebCore::RenderListMarker::baselinePosition):

  • rendering/RenderListMarker.h:

(RenderListMarker):

  • rendering/RenderSlider.cpp:

(WebCore::RenderSlider::baselinePosition):

  • rendering/RenderSlider.h:

(RenderSlider):

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::baselinePosition):
(WebCore::RootInlineBox::lineHeight):

  • rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::baselinePosition):

  • rendering/mathml/RenderMathMLFraction.h:

(RenderMathMLFraction):

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::baselinePosition):

  • rendering/mathml/RenderMathMLOperator.h:

(RenderMathMLOperator):

  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::baselinePosition):

  • rendering/mathml/RenderMathMLRow.h:

(RenderMathMLRow):

  • rendering/mathml/RenderMathMLSubSup.cpp:

(WebCore::RenderMathMLSubSup::baselinePosition):

  • rendering/mathml/RenderMathMLSubSup.h:

(RenderMathMLSubSup):

  • rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore::RenderMathMLUnderOver::baselinePosition):

  • rendering/mathml/RenderMathMLUnderOver.h:

(RenderMathMLUnderOver):

20:16 Changeset [106899] by wangxianzhu@chromium.org

Avoid Page::updateViewportArguments() if the causing frame is not the main frame
https://bugs.webkit.org/show_bug.cgi?id=77387

Reviewed by Kenneth Rohde Christiansen.

  • dom/Document.cpp:

(WebCore::Document::processViewport):
(WebCore::Document::updateViewportArguments):
(WebCore::Document::setInPageCache):

  • dom/Document.h:

(Document):

  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::insertedIntoDocument):

  • page/Frame.cpp:

(WebCore::Frame::setDocument):

  • page/Page.cpp:

(WebCore::Page::viewportArguments):
(WebCore):

  • page/Page.h:

(Page):

20:05 Changeset [106898] by dgrogan@chromium.org

js-test-pre.js: relay calls to testPassed, testFailed, debug, etc from
worker to document.
https://bugs.webkit.org/show_bug.cgi?id=76762

Reviewed by Ojan Vafai.

  • fast/filesystem/resources/async-operations.js:
  • fast/filesystem/resources/directory-entry-to-uri.js:
  • fast/filesystem/resources/file-entry-to-uri-sync.js:
  • fast/filesystem/resources/file-entry-to-uri.js:
  • fast/filesystem/resources/file-from-file-entry-sync.js:
  • fast/filesystem/resources/file-from-file-entry.js:
  • fast/filesystem/resources/file-writer-abort-continue.js:
  • fast/filesystem/resources/file-writer-abort-depth.js:
  • fast/filesystem/resources/file-writer-abort.js:
  • fast/filesystem/resources/file-writer-events.js:
  • fast/filesystem/resources/file-writer-gc-blob.js:
  • fast/filesystem/resources/file-writer-sync-truncate-extend.js:
  • fast/filesystem/resources/file-writer-sync-write-overlapped.js:
  • fast/filesystem/resources/file-writer-truncate-extend.js:
  • fast/filesystem/resources/file-writer-write-overlapped.js:
  • fast/filesystem/resources/fs-worker-common.js:
  • fast/filesystem/resources/fs-worker-test-util.js: Removed.
  • fast/filesystem/resources/simple-persistent-sync.js:
  • fast/filesystem/resources/simple-persistent.js:
  • fast/filesystem/resources/simple-readonly.js:
  • fast/filesystem/resources/simple-required-arguments-getdirectory.js:
  • fast/filesystem/resources/simple-required-arguments-getfile.js:
  • fast/filesystem/resources/simple-required-arguments-getmetadata.js:
  • fast/filesystem/resources/simple-required-arguments-remove.js:
  • fast/filesystem/resources/simple-temporary-sync.js:
  • fast/filesystem/resources/simple-temporary.js:
  • fast/filesystem/resources/sync-operations.js:
  • fast/filesystem/workers/async-operations.html:
  • fast/filesystem/workers/file-entry-to-uri-sync.html:
  • fast/filesystem/workers/file-from-file-entry-sync.html:
  • fast/filesystem/workers/file-from-file-entry.html:
  • fast/filesystem/workers/file-writer-events.html:
  • fast/filesystem/workers/file-writer-gc-blob.html:
  • fast/filesystem/workers/file-writer-sync-truncate-extend.html:
  • fast/filesystem/workers/file-writer-sync-write-overlapped.html:
  • fast/filesystem/workers/file-writer-truncate-extend.html:
  • fast/filesystem/workers/file-writer-write-overlapped.html:
  • fast/filesystem/workers/simple-persistent-sync.html:
  • fast/filesystem/workers/simple-persistent.html:
  • fast/filesystem/workers/simple-temporary-sync.html:
  • fast/filesystem/workers/simple-temporary.html:
  • fast/filesystem/workers/sync-operations.html:
  • fast/js/resources/js-test-pre.js:

(testPassed):
(testFailed):
(finishJSTest):
(startWorker.worker.onmessage):
(startWorker.worker.onerror):
(startWorker):

  • storage/indexeddb/basics-workers.html:
  • storage/indexeddb/resources/basics.js:
20:01 Changeset [106897] by jchaffraix@webkit.org

Unreviewed gardening.

  • platform/chromium-mac-snowleopard/fast/canvas/check-stale-putImageData-expected.png: Added.

Yet another font difference.

  • platform/chromium/test_expectations.txt: Added LEOPARD to the list of flaky platforms.
19:52 Changeset [106896] by abarth@webkit.org

http/tests/security/mixedContent/insecure-script-in-iframe.html flaky in chromium debug
https://bugs.webkit.org/show_bug.cgi?id=65567

Reviewed by Eric Seidel.

My theory is that the extra log message is caused by the preload
scanner requesting the script, which might occur if the test is running
extremely slowly (as it might on a debug bot).

This patch simplifies the test in the hopes of removing the flakiness.

  • http/tests/security/mixedContent/insecure-script-in-iframe-expected.txt:
  • http/tests/security/mixedContent/insecure-script-in-iframe.html:
  • http/tests/security/mixedContent/resources/frame-with-insecure-script.html:
  • platform/chromium/test_expectations.txt:
19:20 Changeset [106895] by mrobinson@webkit.org

Fix some miscellaneous 'make dist' error for WebKitGTK+.

Source/WebCore:

  • GNUmakefile.list.am: Add some missing Shadow DOM files to the

source list.

Source/WebKit2:

  • GNUmakefile.am: Do not distribute generated files.

Tools:

  • MiniBrowser/gtk/GNUmakefile.am: The MiniBrowser generated

files should not be distributed.

19:11 Changeset [106894] by abarth@webkit.org

http/tests/security/mixedContent/insecure-image-in-main-frame.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=77904

Reviewed by Darin Adler.

My theory is that the extra log message is caused by the preload
scanner requesting the image, which might occur if the test is running
extremely slowly (as it might on a debug bot).

This patch simplifies the test in the hopes of removing the flakiness.

  • http/tests/security/mixedContent/insecure-image-in-main-frame-expected.txt:
  • http/tests/security/mixedContent/insecure-image-in-main-frame.html:
  • http/tests/security/mixedContent/resources/frame-with-insecure-image.html:
  • platform/chromium/test_expectations.txt:
18:55 Changeset [106893] by commit-queue@webkit.org

Add contains() test to Region
https://bugs.webkit.org/show_bug.cgi?id=72294

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-06
Reviewed by Anders Carlsson.

  • platform/graphics/Region.cpp:

(WebCore::Region::contains):
(WebCore):

  • platform/graphics/Region.h:

(Region):
(Shape):
(WebCore::operator==):
(WebCore):

18:43 Changeset [106892] by haraken@chromium.org

Rename [DontCheckEnums], [ReturnsNew], [DoNotCheckDomainSecurityOnGet],
[DoNotCheckDomainSecurityOnSet] and [ImplementationFunction] IDLs
https://bugs.webkit.org/show_bug.cgi?id=77852

Reviewed by Adam Barth.

This patch renames [DontCheckEnums], [ReturnsNew], [DoNotCheckDomainSecurityOnGet],
[DoNotCheckDomainSecurityOnSet] and [ImplementationFunction] IDLs for clarification.

[DontCheckEnums] => [DoNotCheckConstants] (This IDL inserts assertions to check if a
constant value is equal to the expected constant value)
[ReturnsNew] => [ReturnNewObject] (For clarification)
[DoNotCheckDomainSecurityOnGet] => [DoNotCheckDomainSecurityOnGetter] (For naming consistency
with other [*Getter] IDLs)
[DoNotCheckDomainSecurityOnSet] => [DoNotCheckDomainSecurityOnSetter] (For naming consistency
with other [*Setter] IDLs)
[ImplementationFunction=] => [ImplementedAs=] (For clarification. This IDL specifies a method
name in implementation)

No tests. No change in behavior.

  • bindings/scripts/CodeGenerator.pm:

(ShouldCheckEnums):
(GenerateCompileTimeCheckForEnumsIfNeeded):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
(NativeToJSValue):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateSingleBatchedAttribute):
(GenerateFunctionCallString):
(NativeToJSValue):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/TestTypedArray.idl:
  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

  • css/WebKitCSSFilterValue.idl:
  • css/WebKitCSSTransformValue.idl:
  • dom/DOMCoreException.idl:
  • dom/Document.idl:
  • dom/EventException.idl:
  • dom/RangeException.idl:
  • fileapi/FileException.idl:
  • fileapi/OperationNotAllowedException.idl:
  • html/HTMLFormElement.idl:
  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/OESStandardDerivatives.idl:
  • html/canvas/OESVertexArrayObject.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • html/canvas/Uint8ClampedArray.idl:
  • html/canvas/WebGLCompressedTextures.idl:
  • html/canvas/WebGLDebugRendererInfo.idl:
  • html/canvas/WebGLRenderingContext.idl:
  • inspector/JavaScriptCallFrame.idl:
  • loader/appcache/DOMApplicationCache.idl:
  • page/Console.idl:
  • page/DOMWindow.idl:
  • page/Location.idl:
  • storage/IDBCursor.idl:
  • storage/IDBDatabaseException.idl:
  • storage/IDBObjectStore.idl:
  • storage/SQLException.idl:
  • svg/SVGComponentTransferFunctionElement.idl:
  • svg/SVGException.idl:
  • svg/SVGFEBlendElement.idl:
  • svg/SVGFEColorMatrixElement.idl:
  • svg/SVGFECompositeElement.idl:
  • svg/SVGFEConvolveMatrixElement.idl:
  • svg/SVGFEDisplacementMapElement.idl:
  • svg/SVGFEMorphologyElement.idl:
  • svg/SVGFETurbulenceElement.idl:
  • svg/SVGGradientElement.idl:
  • xml/XMLHttpRequestException.idl:
  • xml/XPathException.idl:
18:24 Changeset [106891] by jamesr@google.com

[chromium] canvas demo is slow due to unnecessary resource cleanups
https://bugs.webkit.org/show_bug.cgi?id=77135

Reviewed by Kenneth Russell.

Source/WebCore:

This defers dropping a ManagedTexture until it is evicted by the manager, the layer is destroyed, the
TextureManager is destroyed, or the layer is added to a CCLayerTreeHost that has a different texture manager. In
particular, removing a layer from a CCLayerTreeHost and then adding it back to the same host does not drop any
ManagedTextures unless the manager has to evict it for other reasons. This provides a big speedup on sites that
rebuild the compositing tree frequently.

New unit test added for ManagedTexture / TextureManager interaction.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::setLayerTreeHost):
(WebCore::Canvas2DLayerChromium::setTextureManager):

  • platform/graphics/chromium/Canvas2DLayerChromium.h:

(Canvas2DLayerChromium):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setLayerTreeHost):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):

  • platform/graphics/chromium/ManagedTexture.cpp:

(WebCore::ManagedTexture::setTextureManager):
(WebCore):
(WebCore::ManagedTexture::steal):
(WebCore::ManagedTexture::clear):

  • platform/graphics/chromium/ManagedTexture.h:

(ManagedTexture):

  • platform/graphics/chromium/RenderSurfaceChromium.h:

(RenderSurfaceChromium):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::setLayerTreeHost):
(WebCore):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):

  • platform/graphics/chromium/TiledLayerChromium.h:

Source/WebKit/chromium:

  • tests/Canvas2DLayerChromiumTest.cpp:

(WebCore::Canvas2DLayerChromiumTest::fullLifecycleTest):

  • tests/TextureManagerTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:
18:21 Changeset [106890] by rniwa@webkit.org

Perf-o-matic should show min/max/stdev on graphs
https://bugs.webkit.org/show_bug.cgi?id=77702

Reviewed by Andreas Kling.

Include min/max/stdev in test runs when available to be shown on the perf-o-matic.

Also merge a change to config.js and increment the version number by 1 (unreviewed).

  • Websites/webkit-perf.appspot.com/app.yaml:
  • Websites/webkit-perf.appspot.com/js/config.js:
  • Websites/webkit-perf.appspot.com/runs_handler.py:

(RunsHandler.get):

18:04 Changeset [106889] by haraken@chromium.org

Unreviewed, rolling out r106883.
http://trac.webkit.org/changeset/106883
https://bugs.webkit.org/show_bug.cgi?id=77852

build failure around Chromium V8 bindings

  • bindings/scripts/CodeGenerator.pm:

(ShouldCheckEnums):
(GenerateCompileTimeCheckForEnumsIfNeeded):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
(NativeToJSValue):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateSingleBatchedAttribute):
(GenerateFunctionCallString):
(NativeToJSValue):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/TestTypedArray.idl:
  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

  • css/WebKitCSSFilterValue.idl:
  • css/WebKitCSSTransformValue.idl:
  • dom/DOMCoreException.idl:
  • dom/Document.idl:
  • dom/EventException.idl:
  • dom/RangeException.idl:
  • fileapi/FileException.idl:
  • fileapi/OperationNotAllowedException.idl:
  • html/HTMLFormElement.idl:
  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/OESStandardDerivatives.idl:
  • html/canvas/OESVertexArrayObject.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • html/canvas/Uint8ClampedArray.idl:
  • html/canvas/WebGLCompressedTextures.idl:
  • html/canvas/WebGLDebugRendererInfo.idl:
  • html/canvas/WebGLRenderingContext.idl:
  • inspector/JavaScriptCallFrame.idl:
  • loader/appcache/DOMApplicationCache.idl:
  • page/Console.idl:
  • page/DOMWindow.idl:
  • page/Location.idl:
  • storage/IDBCursor.idl:
  • storage/IDBDatabaseException.idl:
  • storage/IDBObjectStore.idl:
  • storage/SQLException.idl:
  • svg/SVGComponentTransferFunctionElement.idl:
  • svg/SVGException.idl:
  • svg/SVGFEBlendElement.idl:
  • svg/SVGFEColorMatrixElement.idl:
  • svg/SVGFECompositeElement.idl:
  • svg/SVGFEConvolveMatrixElement.idl:
  • svg/SVGFEDisplacementMapElement.idl:
  • svg/SVGFEMorphologyElement.idl:
  • svg/SVGFETurbulenceElement.idl:
  • svg/SVGGradientElement.idl:
  • xml/XMLHttpRequestException.idl:
  • xml/XPathException.idl:
17:58 Changeset [106888] by commit-queue@webkit.org

WebGL must allocate smaller drawing buffer when the allocation fails.
https://bugs.webkit.org/show_bug.cgi?id=76654

Patch by Yongsheng Zhu <yongsheng.zhu@intel.com> on 2012-02-06
Reviewed by Kenneth Russell.

Test: fast/canvas/webgl/drawingbuffer-test.html

  • platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore):
(WebCore::DrawingBuffer::create):
(WebCore::DrawingBuffer::reset):

17:42 Changeset [106887] by jchaffraix@webkit.org

Unreviewed gardening.

  • DEPS: Rolling the DEPS to get the apple_webkit update

and fix the Chromium build.

17:39 Changeset [106886] by dgrogan@chromium.org

Port some indexeddb layout tests to workers.
https://bugs.webkit.org/show_bug.cgi?id=77805

Reviewed by Tony Chang.

  • storage/indexeddb/index-basics-workers-expected.txt: Added.
  • storage/indexeddb/index-basics-workers.html: Added.
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics-workers-expected.txt: Added.
  • storage/indexeddb/objectstore-basics-workers.html: Added.
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/resources/index-basics.js: Copied from LayoutTests/storage/indexeddb/index-basics.html.

(test):
(setVersion):
(deleteExisting):
(addData):
(addData2):
(addData3):
(getData):
(getObjectData):
(getObjectData2):
(getObjectData3):
(getDataFail):
(getObjectDataFail):
(getObjectData4):
(openKeyCursor):
(cursor1Continue):
(cursor1Continue2):
(cursor1Continue3):
(openObjectCursor):
(cursor2Continue):
(cursor2Continue2):
(cursor2Continue3):
(last.try.get testFailed):
(last):

  • storage/indexeddb/resources/objectstore-basics.js: Copied from LayoutTests/storage/indexeddb/objectstore-basics.html.

(test):
(openSuccess):
(setVersionSuccess):
(createIndex):
(testSetVersionAbort):
(createAnotherIndex):
(checkMetadata):
(addData):
(addDateSuccess):
(addSuccess):
(addAgainFailure):
(getSuccess):
(getSuccessDateKey):
(removeSuccess):
(removeSuccessButFalse):
(testPreConditions.request.onsuccess):
(testPreConditions):

17:37 Changeset [106885] by haraken@chromium.org

Unreviewed. Rebaselined run-bindings-tests results.

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::optionsObjectCallback):

17:36 Changeset [106884] by leviw@chromium.org

Correct usage of LayoutUnits in dom, editing, page, accessibility, inspector, and loader
https://bugs.webkit.org/show_bug.cgi?id=77891

Reviewed by Darin Adler.

Updating the usage of LayoutUnits in the dom, editing, page, accessibility, inspector, and loader
directories to properly use LayoutUnits vs ints.

No new tests. No new behavior.

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::boundsForVisiblePositionRange):
(WebCore::AccessibilityObject::doAXBoundsForRange):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isOffScreen):
(WebCore::AccessibilityRenderObject::clickPoint):
(WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange):
(WebCore::AccessibilityRenderObject::doAXBoundsForRange):
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::elementAccessibilityHitTest):

  • accessibility/AccessibilitySlider.h:

(AccessibilitySlider):

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityShowContextMenu]):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::computedTransform):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • dom/Clipboard.h:

(WebCore::Clipboard::dragLocation):
(Clipboard):

  • dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::renderedRectsForMarkers):

  • dom/DocumentMarkerController.h:
  • dom/Element.cpp:

(WebCore::Element::screenRect):

  • dom/Element.h:

(Element):

  • editing/Editor.cpp:

(WebCore::Editor::rangeForPoint):
(WebCore::Editor::firstRectForRange):

  • editing/RenderedPosition.cpp:

(WebCore::RenderedPosition::absoluteRect):

  • editing/RenderedPosition.h:

(WebCore::RenderedPosition::absoluteRect):
(RenderedPosition):

  • editing/VisiblePosition.h:

(VisiblePosition):

  • inspector/DOMNodeHighlighter.cpp:
  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::createJavaAppletWidget):

  • loader/SubframeLoader.h:

(SubframeLoader):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEvent):

  • page/Frame.cpp:

(WebCore::Frame::nodeImage):

  • page/win/FrameCGWin.cpp:

(WebCore::Frame::nodeImage):

17:33 Changeset [106883] by haraken@chromium.org

Rename [DontCheckEnums], [ReturnsNew], [DoNotCheckDomainSecurityOnGet],
[DoNotCheckDomainSecurityOnSet] and [ImplementationFunction] IDLs
https://bugs.webkit.org/show_bug.cgi?id=77852

Reviewed by Adam Barth.

This patch renames [DontCheckEnums], [ReturnsNew], [DoNotCheckDomainSecurityOnGet],
[DoNotCheckDomainSecurityOnSet] and [ImplementationFunction] IDLs for clarification.

[DontCheckEnums] => [DoNotCheckConstants] (This IDL inserts assertions to check if a
constant value is equal to the expected constant value)
[ReturnsNew] => [ReturnNewObject] (For clarification)
[DoNotCheckDomainSecurityOnGet] => [DoNotCheckDomainSecurityOnGetter] (For naming consistency
with other [*Getter] IDLs)
[DoNotCheckDomainSecurityOnSet] => [DoNotCheckDomainSecurityOnSetter] (For naming consistency
with other [*Setter] IDLs)
[ImplementationFunction=] => [ImplementedAs=] (For clarification. This IDL specifies a method
name in implementation)

No tests. No change in behavior.

  • bindings/scripts/CodeGenerator.pm:

(ShouldCheckEnums):
(GenerateCompileTimeCheckForEnumsIfNeeded):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
(NativeToJSValue):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateSingleBatchedAttribute):
(GenerateFunctionCallString):
(NativeToJSValue):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/TestTypedArray.idl:
  • bindings/scripts/test/JS/JSTestInterface.cpp: Updated run-bindings-tests results.

(WebCore):

  • bindings/scripts/test/JS/JSTestObj.cpp: Ditto.

(WebCore):

  • bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.

(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp: Ditto.

(WebCore):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/TestTypedArray.idl:
  • css/WebKitCSSFilterValue.idl:
  • css/WebKitCSSTransformValue.idl:
  • dom/DOMCoreException.idl:
  • dom/Document.idl:
  • dom/EventException.idl:
  • dom/RangeException.idl:
  • fileapi/FileException.idl:
  • fileapi/OperationNotAllowedException.idl:
  • html/HTMLFormElement.idl:
  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/OESStandardDerivatives.idl:
  • html/canvas/OESVertexArrayObject.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • html/canvas/Uint8ClampedArray.idl:
  • html/canvas/WebGLCompressedTextures.idl:
  • html/canvas/WebGLDebugRendererInfo.idl:
  • html/canvas/WebGLRenderingContext.idl:
  • inspector/JavaScriptCallFrame.idl:
  • loader/appcache/DOMApplicationCache.idl:
  • page/Console.idl:
  • page/DOMWindow.idl:
  • page/Location.idl:
  • storage/IDBCursor.idl:
  • storage/IDBDatabaseException.idl:
  • storage/IDBObjectStore.idl:
  • storage/SQLException.idl:
  • svg/SVGComponentTransferFunctionElement.idl:
  • svg/SVGException.idl:
  • svg/SVGFEBlendElement.idl:
  • svg/SVGFEColorMatrixElement.idl:
  • svg/SVGFECompositeElement.idl:
  • svg/SVGFEConvolveMatrixElement.idl:
  • svg/SVGFEDisplacementMapElement.idl:
  • svg/SVGFEMorphologyElement.idl:
  • svg/SVGFETurbulenceElement.idl:
  • svg/SVGGradientElement.idl:
  • xml/XMLHttpRequestException.idl:
17:30 Changeset [106882] by commit-queue@webkit.org

RenderSVGShape::strokeContains will fail for some strokes
https://bugs.webkit.org/show_bug.cgi?id=76931

Patch by Stephen Chenney <schenney@chromium.org> on 2012-02-06
Reviewed by Darin Adler.

Source/WebCore:

Adding support for rounded zero-length endcaps for SVG path hit
testing.

Tests: svg/hittest/zero-length-butt-cap-path.xhtml

svg/hittest/zero-length-round-cap-path.xhtml
svg/hittest/zero-length-square-cap-path.xhtml

  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::strokeContains):

LayoutTests:

New tests for hit testing against an SVG path of zero length with
endcaps.

  • svg/hittest/zero-length-butt-cap-path-expected.txt: Added.
  • svg/hittest/zero-length-butt-cap-path.xhtml: Added.
  • svg/hittest/zero-length-round-cap-path-expected.txt: Added.
  • svg/hittest/zero-length-round-cap-path.xhtml: Added.
  • svg/hittest/zero-length-square-cap-path-expected.txt: Added.
  • svg/hittest/zero-length-square-cap-path.xhtml: Added.
17:20 WebKit Team edited by igor.oliveira@openbossa.org
(diff)
17:14 WebKitGTK/1.6.x edited by mrobinson@webkit.org
(diff)
17:09 Changeset [106881] by commit-queue@webkit.org

Add webGLErrorsToConsoleEnabled Settings flag
https://bugs.webkit.org/show_bug.cgi?id=77696

Patch by Gregg Tavares <gman@google.com> on 2012-02-06
Reviewed by Kenneth Russell.

No new tests as there is no change in behavior.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::setupFlags):

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(Settings):
(WebCore::Settings::webGLErrorsToConsoleEnabled):

17:07 Changeset [106880] by eae@chromium.org

Convert PopupMenuClient::clientPadding over to new layout abstraction
https://bugs.webkit.org/show_bug.cgi?id=77798

Reviewed by Eric Seidel.

Change PopupMenuClient and all classes inheriting from it to use the new
layout types for padding.

Source/WebCore:

No new tests.

  • platform/PopupMenuClient.h:

(PopupMenuClient):

  • rendering/RenderMenuList.h:
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::clientPaddingLeft):
(WebCore::RenderTextControlSingleLine::clientPaddingRight):

  • rendering/RenderTextControlSingleLine.h:

Source/WebKit/chromium:

  • src/AutofillPopupMenuClient.cpp:

(WebKit::AutofillPopupMenuClient::clientPaddingLeft):
(WebKit::AutofillPopupMenuClient::clientPaddingRight):

  • src/AutofillPopupMenuClient.h:

(AutofillPopupMenuClient):

  • tests/PopupMenuTest.cpp:

(WebKit::TestPopupMenuClient::clientPaddingLeft):
(WebKit::TestPopupMenuClient::clientPaddingRight):

17:07 Changeset [106879] by fpizlo@apple.com

ValueToNumber and ValueToDouble nodes don't do anything and should be removed
https://bugs.webkit.org/show_bug.cgi?id=77855
<rdar://problem/10811325>

Reviewed by Gavin Barraclough.

Removed ValueToNumber and ValueToDouble, because the only thing they were doing
was wasting registers.

This looks like a 1% win on V8 (with a 5% win on crypto) and a 2-3% win on Kraken,
mostly due to a >10% win on gaussian-blur. No win anywhere else.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getToInt32):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGNode.h:

(DFG):
(JSC::DFG::Node::hasArithNodeFlags):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::vote):
(JSC::DFG::Propagator::doRoundOfDoubleVoting):
(Propagator):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::canonicalize):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

16:55 Changeset [106878] by commit-queue@webkit.org

Fix color animations by value
https://bugs.webkit.org/show_bug.cgi?id=77812

Patch by Philip Rogers <pdr@google.com> on 2012-02-06
Reviewed by Darin Adler.

Source/WebCore:

Test: svg/animations/animate-color-fill-from-by.html

  • svg/SVGAnimatedColor.cpp:

(WebCore::SVGAnimatedColorAnimator::calculateFromAndByValues):

LayoutTests:

  • svg/animations/animate-color-fill-from-by-expected.txt: Added.
  • svg/animations/animate-color-fill-from-by.html: Added.
  • svg/animations/script-tests/animate-color-fill-from-by.js: Added.

(checkFillColor):
(sample1):
(sample2):
(sample3):
(executeTest):

16:53 Changeset [106877] by kov@webkit.org

Do not try to chdir to the directory where the executable is in
only if the path is absolute. This makes tests runnable from
anywhere.

Reviewed by Martin Robinson.

  • tests/test_utils.c:

(testutils_relative_chdir):

16:52 Changeset [106876] by jer.noble@apple.com

REGRESSION (r104303): Clicking inline video controls gives the video a focus ring
https://bugs.webkit.org/show_bug.cgi?id=77288

Reviewed by Darin Adler.

Source/WebCore:

Test: media/video-mouse-focus.html

Do not allow media elements to be focused by mouse click by overriding isMouseFocusable
and returning false.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::isMouseFocusable):

  • html/HTMLMediaElement.h:

LayoutTests:

  • media/video-mouse-focus-expected.txt: Added.
  • media/video-mouse-focus.html: Added.
16:43 Changeset [106875] by andersca@apple.com

Source/WebCore: Overlay scrollbars flash when window is simply activated
https://bugs.webkit.org/show_bug.cgi?id=77911
<rdar://problem/10211995>

Reviewed by Kenneth Russell.

Add a new member function, FocusController::setContainingWindowIsVisible, and move the code
that calls ScrollableArea::contentAreaDidShow/ScrollableArea::contentAreaDidHide there, since
we only want to flash scrollers when the window becomes visible.

  • WebCore.exp.in:
  • page/FocusController.cpp:

(WebCore::FocusController::FocusController):
(WebCore::FocusController::setActive):
(WebCore::FocusController::setContainingWindowIsVisible):
(WebCore):

  • page/FocusController.h:

(FocusController):
(WebCore::FocusController::containingWindowIsVisible):

  • platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollbarPainterControllerDelegate scrollerImpPair:setContentAreaNeedsDisplayInRect:]):
Call ScrollAnimatorMac::contentAreaWillPaint here, since that will trigger AppKit to flash the scrollers.

Source/WebKit/mac: Overlay scrollbars flash when window is simply activated
https://bugs.webkit.org/show_bug.cgi?id=77911
<rdar://problem/10211995>

Reviewed by Kenneth Russell.

  • WebView/WebView.mm:

(-[WebView _windowWillOrderOnScreen:]):
(-[WebView _windowWillOrderOffScreen:]):
Call FocusController::setContainingWindowIsVisible.

Source/WebKit2: Overlay scrollbars flash when window is simply activated
https://bugs.webkit.org/show_bug.cgi?id=77911

Reviewed by Kenneth Russell.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _updateWindowVisibility]):
Use -[NSWindow isVisible] here, since we also want to consider the window hidden if the application itself is hidden.

(-[WKView _windowDidOrderOffScreen:]):
(-[WKView _windowDidOrderOnScreen:]):
Call -[WKView updateWindowVisibility].

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setWindowIsVisible):
Call FocusController::setContainingWindowIsVisible.

16:41 Changeset [106874] by commit-queue@webkit.org

postMessage leaks MemoryEvent object
https://bugs.webkit.org/show_bug.cgi?id=77893

Patch by Greg Simon <gregsimon@chromium.org> on 2012-02-06
Reviewed by Adam Barth.

Changed from PassRefPtr().leakRef() to RefPtr.get() when
calling into FrameLoaderClient to stop +1 extra ref.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessageTimerFired):

16:38 Changeset [106873] by commit-queue@webkit.org

WebGL conformance test misc/functions-returning-strings.html fails
https://bugs.webkit.org/show_bug.cgi?id=77149

Source/WebCore:

Make sure that WebGL methods returning strings don't return null when
they run successfully.

Patch by Ehsan Akhgari <ehsan.akhgari@gmail.com> on 2012-02-06
Reviewed by Kenneth Russell.

Test: fast/canvas/webgl/functions-returning-strings.html

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::getProgramInfoLog):
(WebCore::WebGLRenderingContext::getShaderInfoLog):
(WebCore::WebGLRenderingContext::getShaderSource):
(WebCore::WebGLRenderingContext::ensureNotNull):

  • html/canvas/WebGLRenderingContext.h:

(WebGLRenderingContext):

LayoutTests:

Imported the WebGL conformance test related to this.

Patch by Ehsan Akhgari <ehsan.akhgari@gmail.com> on 2012-02-06
Reviewed by Kenneth Russell.

  • fast/canvas/webgl/functions-returning-strings-expected.txt: Added.
  • fast/canvas/webgl/functions-returning-strings.html: Added.
16:34 Changeset [106872] by enrica@apple.com

Refactor Mac platform implementation of the Pasteboard class.
https://bugs.webkit.org/show_bug.cgi?id=77567

The goal of this change is to remove the majority of the methods in
the class interface that are Mac specific.
writeSelectionForTypes has been left to support OS X services.
Some of the methods have been turned into static functions.
The method asURL was being used only by the DragData class and its
implementation has been moved there.
This is a first step in the direction of removing NSPasteboard access from
the WebProcess for WebKit2 (https://bugs.webkit.org/show_bug.cgi?id=77259)
leaving the WebKit1 behavior unchanged.

Reviewed by Alexey Proskuryakov.

No new tests. No changes in behavior.

  • platform/Pasteboard.h: Removed most of the Mac specific methods.
  • platform/mac/ClipboardMac.mm:

(WebCore::ClipboardMac::writeRange):
(WebCore::ClipboardMac::writeURL):

  • platform/mac/DragDataMac.mm:

(WebCore::DragData::asURL): Moved code from PasteboardMac.mm. Removed FIXME
because we only want to handle the case of single file, otherwise the user
doesn't know which of the files has been chosen.

  • platform/mac/PasteboardMac.mm:

(WebCore::writeURLForTypes):
(WebCore::Pasteboard::writeURL):
(WebCore::writeFileWrapperAsRTFDAttachment): Now a static function.
(WebCore::Pasteboard::writeImage):
(WebCore::documentFragmentWithImageResource): Ditto.
(WebCore::documentFragmentWithRTF): Ditto.
(WebCore::Pasteboard::documentFragment):

16:30 Changeset [106871] by crogers@google.com

Merge 106864 - zvmul incorrectly multiplies complex arrays on Windows.
https://bugs.webkit.org/show_bug.cgi?id=77900

TBR=crogers@google.com
Review URL: https://chromiumcodereview.appspot.com/9350003

16:25 Changeset [106870] by jamesr@google.com

[chromium] Drop tiles completely outside of layer bounds when resizing to a smaller size
https://bugs.webkit.org/show_bug.cgi?id=77910

Reviewed by Kenneth Russell.

Source/WebCore:

When resizing a tiled layer to a smaller size, drop all tiles that lie completely outside the new layer bounds.
This avoids attempting to access out-of-bounds tiles when iterating over all tiles in the tiler, which triggers
ASSERT()s, as well as saves some memory.

New unit test added to TiledLayerChromiumTest.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::invalidateRect):

  • platform/graphics/chromium/cc/CCLayerTilingData.cpp:

(WebCore::CCLayerTilingData::setBounds):

Source/WebKit/chromium:

Adds test for resizing a layer to cover fewer tiles. Test hits ASSERT()s without any code changes.

  • tests/TiledLayerChromiumTest.cpp:

(::TEST):

16:14 Changeset [106869] by leviw@chromium.org

Reverting RenderFrameSet's canResizeRow/Column to operate on IntPoints.

16:09 Changeset [106868] by leviw@chromium.org

Call intValue on grid lengths instead of explicitly operating on floats when we only use integer precision for FrameSets.

16:08 Changeset [106867] by rniwa@webkit.org

Revert r106859. It was completely bogus.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::doPixelReadbackToCanvas):

16:00 Changeset [106866] by leviw@chromium.org

Fix pixel snapping logic for FrameSets. This is for code correctness, but would never actually lead to incorrect renderings.

15:44 Changeset [106865] by morrita@google.com

[PerformanceTests] Each Dromaeo test needs its landing html.
https://bugs.webkit.org/show_bug.cgi?id=77504

Reviewed by Ryosuke Niwa.

PerformanceTests:

  • Added landing pages for each test which are listed in MANIFEST.json
  • Removed some tests which depends on the library whose license is incompatible to WebKit.
  • Added local copy of corresponding library. And replace the references to the remote sources to the local copies.
  • Removed old library files under Dromaeo/resources/dromaeo/web/lib/.
  • Skipped Sunsupier and v8 test. Such JS centric test should have its own test instead of running as a part of Dromaeo.
  • Dromaeo/cssquery-dojo.html: Added.
  • Dromaeo/cssquery-jquery.html: Added.
  • Dromaeo/cssquery-prototype.html: Added.
  • Dromaeo/dom-attr.html: Added.
  • Dromaeo/dom-modify.html: Added.
  • Dromaeo/dom-traverse.html: Added.
  • Dromaeo/dromaeo-3d-cube.html: Added.
  • Dromaeo/dromaeo-core-eval.html: Added.
  • Dromaeo/dromaeo-object-array.html: Added.
  • Dromaeo/dromaeo-object-regexp.html: Added.
  • Dromaeo/dromaeo-object-string.html: Added.
  • Dromaeo/dromaeo-string-base64.html: Added.
  • Dromaeo/jslib-attr-jquery.html: Added.
  • Dromaeo/jslib-attr-prototype.html: Added.
  • Dromaeo/jslib-event-jquery.html: Added.
  • Dromaeo/jslib-event-prototype.html: Added.
  • Dromaeo/jslib-modify-jquery.html: Added.
  • Dromaeo/jslib-modify-prototype.html: Added.
  • Dromaeo/jslib-style-jquery.html: Added.
  • Dromaeo/jslib-style-prototype.html: Added.
  • Dromaeo/jslib-traverse-jquery.html: Added.
  • Dromaeo/jslib-traverse-prototype.html: Added.
  • Dromaeo/resources/dromaeo/web/lib/dojo.js: Removed.
  • Dromaeo/resources/dromaeo/web/lib/dojo-1.6.1.js: Added.
  • Dromaeo/resources/dromaeo/web/lib/jquery.js: Removed.
  • Dromaeo/resources/dromaeo/web/lib/jquery-1.6.4.js: Added.
  • Dromaeo/resources/dromaeo/web/lib/mootools.js: Removed.
  • Dromaeo/resources/dromaeo/web/lib/prototype.js: Removed.
  • Dromaeo/resources/dromaeo/web/lib/prototype-1.7.js: Added.
  • Dromaeo/resources/dromaeo/web/tests/cssquery-dojo.html:
  • Dromaeo/resources/dromaeo/web/tests/cssquery-jquery.html:
  • Dromaeo/resources/dromaeo/web/tests/cssquery-mootools.html: Removed.
  • Dromaeo/resources/dromaeo/web/tests/cssquery-prototype.html:
  • Dromaeo/resources/dromaeo/web/tests/jslib-attr-jquery.html:
  • Dromaeo/resources/dromaeo/web/tests/jslib-attr-prototype.html:
  • Dromaeo/resources/dromaeo/web/tests/jslib-event-jquery.html:
  • Dromaeo/resources/dromaeo/web/tests/jslib-event-prototype.html:
  • Dromaeo/resources/dromaeo/web/tests/jslib-modify-jquery.html:
  • Dromaeo/resources/dromaeo/web/tests/jslib-modify-prototype.html:
  • Dromaeo/resources/dromaeo/web/tests/jslib-style-jquery.html:
  • Dromaeo/resources/dromaeo/web/tests/jslib-style-prototype.html:
  • Dromaeo/resources/dromaeo/web/tests/jslib-traverse-jquery.html:
  • Dromaeo/resources/dromaeo/web/tests/jslib-traverse-prototype.html:
  • Dromaeo/sunspider-3d-morph.html: Added.
  • Dromaeo/sunspider-3d-raytrace.html: Added.
  • Dromaeo/sunspider-access-binary-trees.html: Added.
  • Dromaeo/sunspider-access-fannkuch.html: Added.
  • Dromaeo/sunspider-access-nbody.html: Added.
  • Dromaeo/sunspider-access-nsieve.html: Added.
  • Dromaeo/sunspider-bitops-3bit-bits-in-byte.html: Added.
  • Dromaeo/sunspider-bitops-bits-in-byte.html: Added.
  • Dromaeo/sunspider-bitops-bitwise-and.html: Added.
  • Dromaeo/sunspider-bitops-nsieve-bits.html: Added.
  • Dromaeo/sunspider-controlflow-recursive.html: Added.
  • Dromaeo/sunspider-crypto-aes.html: Added.
  • Dromaeo/sunspider-crypto-md5.html: Added.
  • Dromaeo/sunspider-crypto-sha1.html: Added.
  • Dromaeo/sunspider-date-format-tofte.html: Added.
  • Dromaeo/sunspider-date-format-xparb.html: Added.
  • Dromaeo/sunspider-math-cordic.html: Added.
  • Dromaeo/sunspider-math-partial-sums.html: Added.
  • Dromaeo/sunspider-math-spectral-norm.html: Added.
  • Dromaeo/sunspider-regexp-dna.html: Added.
  • Dromaeo/sunspider-string-fasta.html: Added.
  • Dromaeo/sunspider-string-tagcloud.html: Added.
  • Dromaeo/sunspider-string-unpack-code.html: Added.
  • Dromaeo/sunspider-string-validate-input.html: Added.
  • Dromaeo/v8-crypto.html: Added.
  • Dromaeo/v8-deltablue.html: Added.
  • Dromaeo/v8-earley-boyer.html: Added.
  • Dromaeo/v8-raytrace.html: Added.
  • Dromaeo/v8-richards.html: Added.
  • Skipped:

Tools:

Added an ignorable pattern which happens in some Dromaeo tests.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner):

15:23 Changeset [106864] by crogers@google.com

zvmul incorrectly multiplies complex arrays on Windows.
https://bugs.webkit.org/show_bug.cgi?id=77900

Reviewed by Kenneth Russell.

Source/WebCore:

  • platform/audio/VectorMath.cpp:

(WebCore::VectorMath::zvmul):

LayoutTests:

  • platform/chromium/test_expectations.txt:
15:14 Changeset [106863] by kling@webkit.org

REGRESSION(r106756): 10% performance hit on DOM/Template.
<http://webkit.org/b/77831>

Reviewed by Ryosuke Niwa.

Let the StylePropertySet used for element attribute style have the element as its parent.
This is accomplished by adding an m_parentIsElement bit to StylePropertySet and sharing
some of the internal logic with inline styles.

In the end, this means that CSSParser will now pick up the document's CSSValuePool when
parsing properties for attribute styles, which fixes the perf regression from r106756.

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::contextStyleSheet):

Find contextStyleSheet via the parentElement() when there is one.

(WebCore::StylePropertySet::setNeedsStyleRecalc):

Always set FullStyleChange for attribute style mutations. We can probably use the
same lighter invalidation as inline styles, but that's a topic for another patch.

  • css/StylePropertySet.h:

(WebCore::StylePropertySet::createInline):
(WebCore::StylePropertySet::createAttributeStyle):
(WebCore::StylePropertySet::parentRuleInternal):
(WebCore::StylePropertySet::clearParentRule):
(StylePropertySet):
(WebCore::StylePropertySet::parentElement):
(WebCore::StylePropertySet::clearParentElement):

Added m_parentIsElement bit and update assertions as appropriate to not just
cover the inline style case. Added a createAttributeStyle() helper to create
a StylePropertySet for use as Element::attributeStyle().

  • dom/StyledElement.h:
  • dom/ElementAttributeData.h:
  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::ensureAttributeStyle):

Use StylePropertySet::createAttributeStyle().

  • dom/StyledElement.cpp:

(WebCore::StyledElement::removeCSSProperties):
(WebCore::StyledElement::addCSSProperty):
(WebCore::StyledElement::addCSSImageProperty):

Remove setNeedsStyleRecalc() calls since that is now handled automatically by
StylePropertySet's mutation methods.

15:10 Changeset [106862] by haraken@chromium.org

In AppleWebKit, stop rebuilding IDLs that need not to be rebuilt
https://bugs.webkit.org/show_bug.cgi?id=77510

Reviewed by Adam Barth.

Currently, if any IDL file is updated, all IDL files are rebuilt.
This patch stops rebuilding IDL files which are not modified nor
whose supplemental dependencies are not changed.

The new build flow is as follows:

supplemental.dep : $(ALL_IDLS)

perl resolve-supplemental.pl ...

%.idl-needs-rebuild : %.idl supplemental.dep

perl update-idl-needs-rebuild.pl ...

JS%.cpp : %.idl-needs-rebuild

perl generate-bindings.pl ...

resolve-supplemental.pl generates the following supplemental.dep.
The number in () is the last access timestamp of the file.

A.idl(1200)
B.idl(1000) B-supplemental1.idl(800) B-supplemental2.idl(1200)
C.idl(1000)

update-idl-needs-rebuild.pl for X.idl touches X.idl-needs-rebuild,
if X.idl-needs-rebuild is older than X.idl or the IDL files which are
supplementing X.idl. For example, if the timestamps of A.idl-needs-rebuild,
B.idl-needs-rebuild and C.idl-needs-rebuild are all 1000, then A.idl-needs-rebuild
and B.idl-needs-rebuild will be touched.

Even if no IDL files are modified, update-idl-needs-rebuild.pl can run for all IDL files,
but generate-bindings.pl won't run. If any IDL file is updated, resolve-supplemental.pl
will run once, update-idl-needs-rebuild.pl will run for all IDL files, and
generate-bindings.pl will run for the IDL files which are modified or whose
dependencies are changed.

No tests. I manually confirmed the followings:

  • Touch Element.idl, then only Element.idl is rebuilt
  • Touch DOMWindow.idl, then only DOMWindow.idl is rebuilt
  • Touch DOMWindowWebAudio.idl, then only DOMWindow.idl and DOMWindowWebAudio.idl are rebuilt
  • DerivedSources.make: Modified the build flow as described above.
  • bindings/scripts/generate-bindings.pl: Modified to read an IDL file path from .idl-needs-rebuild.
  • bindings/scripts/update-idl-needs-rebuild.pl: Added. Touches X.idl-needs-rebuild if

the X.idl-needs-rebuild is older than X.idl or the IDL files which are supplementing X.idl.
(touch):

15:10 Changeset [106861] by commit-queue@webkit.org

Unreviewed, chromium expectations update.
Layout Test http/tests/media/video-served-as-text.html is flaky on cr-win
https://bugs.webkit.org/show_bug.cgi?id=72904

Test is not flaky on XP.

Patch by Ami Fischman <fischman@chromium.org> on 2012-02-06

  • platform/chromium/test_expectations.txt:
15:08 Changeset [106860] by mdelaney@apple.com

Windows build fix

15:02 Changeset [106859] by rniwa@webkit.org

Chromium build fix after r106836.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::doPixelReadbackToCanvas):

15:00 Changeset [106858] by commit-queue@webkit.org

AudioBus need to support stereo->mono down mix in copyFrom sumFrom etc.
https://bugs.webkit.org/show_bug.cgi?id=77609

Patch by Wei James <james.wei@intel.com> on 2012-02-06
Reviewed by Kenneth Russell.

Test: webaudio/stereo2mono-down-mixing.html

  • platform/audio/AudioBus.cpp:

(WebCore):
(WebCore::AudioBus::copyFrom):
(WebCore::AudioBus::sumFrom):

14:55 Changeset [106857] by jsbell@chromium.org

[Chromium] storage/indexeddb/index-cursor.html timeouts on Mac Debug
https://bugs.webkit.org/show_bug.cgi?id=65862

No sign of this test timing out in recent history, and significant
performance work has been done since it was filed. Unmarking as SLOW/PASS.

Reviewed by Tony Chang.

  • platform/chromium/test_expectations.txt:
14:54 Changeset [106856] by ericu@chromium.org

[filesystem/Chromium] crackFileSystemURL needs to use innerURL
https://bugs.webkit.org/show_bug.cgi?id=77881

Reviewed by Adam Barth.

  • src/AsyncFileSystemChromium.cpp:

(WebCore::AsyncFileSystem::crackFileSystemURL):
Add the new code path, taken only if innerURL is present.

14:39 Changeset [106855] by jchaffraix@webkit.org

Unreviewed gardening.

More font differences that need a rebaseline.

  • platform/chromium-linux-x86/fast/canvas/check-stale-putImageData-expected.png: Removed.
  • platform/chromium-linux/fast/canvas/check-stale-putImageData-expected.png: Added.
  • platform/chromium-win/fast/canvas/check-stale-putImageData-expected.png: Added.
14:35 Changeset [106854] by commit-queue@webkit.org

[Chromium] rebaseline test on win/mac after enabling paint opaque tracking for draw culling
https://bugs.webkit.org/show_bug.cgi?id=77497

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-06
Reviewed by James Robinson.

  • platform/chromium-win/fast/repaint/block-selection-gap-in-composited-layer-expected.png: Added.
  • platform/chromium/test_expectations.txt:
14:32 Changeset [106853] by abarth@webkit.org

http/tests/security/mixedContent/insecure-plugin-in-iframe.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=77901

Reviewed by Eric Seidel.

This test fails occationally because of the order of the frame load
callbacks. Now that we log mixed content errors to the console, we
don't need to dump the frame load callbacks in this test.

  • http/tests/security/mixedContent/insecure-plugin-in-iframe-expected.txt:
  • http/tests/security/mixedContent/insecure-plugin-in-iframe.html:
14:30 Changeset [106852] by cdn@chromium.org

Source/WebCore: Add RefPtrs for parent and sibling counter nodes
https://bugs.webkit.org/show_bug.cgi?id=75212

Reviewed by Adam Barth.

Test: fast/css/counters/reparent-table-children-with-counters-crash.html

  • rendering/RenderCounter.cpp:

(WebCore::findPlaceForCounter):
(WebCore::makeCounterNode):
(WebCore::updateCounters):

LayoutTests: Test for crash when counter nodes are reparented outside of tables
https://bugs.webkit.org/show_bug.cgi?id=75212

Reviewed by Adam Barth.

  • fast/css/counters/reparent-table-children-with-counters-crash-expected.txt: Added.
  • fast/css/counters/reparent-table-children-with-counters-crash.html: Added.
14:26 Changeset [106851] by kov@webkit.org

Unreviewed fix for the new API test that is failing -
WEBKIT_INSPECTOR_PATH needs to be set, since we do not install our
builds.

  • tests/testwebinspector.c:

(main):

14:17 Changeset [106850] by mdelaney@apple.com

Fix for burning SL tree

14:17 Changeset [106849] by abarth@webkit.org

According to the flakiness dashboard, these tests do appear to be
successfully de-flaked.

  • platform/chromium/test_expectations.txt:
14:16 LayoutUnit created by eae@chromium.org
Added initial draft of wiki page explaining LayoutUnits.
14:06 Changeset [106848] by jochen@chromium.org

Merge 106846 - Before accessing a frame's script controller in V8 bindings, first check that the frame actually exists
https://bugs.webkit.org/show_bug.cgi?id=77370

Reviewed by Adam Barth.

I don't have a working reproduction of the crash yet. As soon as I have
one, I will add new layout tests.

  • bindings/v8/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::addListener):

  • bindings/v8/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute):

  • bindings/v8/ScriptCachedFrameData.cpp:

(WebCore::ScriptCachedFrameData::restore):

  • page/DOMTimer.cpp:

(WebCore::DOMTimer::DOMTimer): remove temporary debug code
Review URL: https://chromiumcodereview.appspot.com/9340005

13:59 Changeset [106847] by commit-queue@webkit.org

[GTK] Add missing pango include dir to fix build
https://bugs.webkit.org/show_bug.cgi?id=77832

Patch by Kalev Lember <kalevlember@gmail.com> on 2012-02-06
Reviewed by Martin Robinson.

Source/WebCore:

  • GNUmakefile.am: Added $(PANGO_CFLAGS) to libWebCore_la_CPPFLAGS.

Tools:

  • GNUmakefile.am: Added $(PANGO_CFLAGS) to libWebCoreInternals_la_CPPFLAGS.
13:55 Changeset [106846] by jochen@chromium.org

Before accessing a frame's script controller in V8 bindings, first check that the frame actually exists
https://bugs.webkit.org/show_bug.cgi?id=77370

Reviewed by Adam Barth.

I don't have a working reproduction of the crash yet. As soon as I have
one, I will add new layout tests.

  • bindings/v8/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::addListener):

  • bindings/v8/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute):

  • bindings/v8/ScriptCachedFrameData.cpp:

(WebCore::ScriptCachedFrameData::restore):

  • page/DOMTimer.cpp:

(WebCore::DOMTimer::DOMTimer): remove temporary debug code

13:43 Changeset [106845] by senorblanco@chromium.org

Merge 104501 - [chromium win] Creating lots of temporary canvas contexts will crash.
https://bugs.webkit.org/show_bug.cgi?id=68420

When using the skia port, the allocation of 2d canvas backing stores
no longer needs to be done through a platform API (GDI/CG) because
canvases now use skia for drawing text. Removing the allocation through
GDI on windows prevents resource exhaustion due to unreferenced canvases
that are awaiting garbage collection.

Patch by Justin Novosad <junov@chromium.org> on 2012-01-09
Reviewed by Stephen White.

No new tests: Relying on existing canvas layout tests.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::createImageBuffer):

  • platform/graphics/ImageBuffer.h:
  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::createNonPlatformCanvas):
(WebCore::ImageBuffer::ImageBuffer):

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9340004

13:39 Changeset [106844] by jchaffraix@webkit.org

Unreviewed rebaseline after r106836.

The rebaseline is caused by a font difference.

  • platform/chromium-linux-x86/fast/canvas/check-stale-putImageData-expected.png: Added.
13:34 Changeset [106843] by mdelaney@apple.com

Correcting the version of WKSI committed in r106836

13:25 Changeset [106842] by jsbell@chromium.org

Unreviewed chromium test expectation change

Unmarking storage/indexeddb/data-corruption.html as TIMEOUT. Was apparently
bulk-marked as TIMEOUT on Snow Leopard as part of WK54322 although it is
not mentioned in that issue. The test hasn't failed in recent history and
there has been substantial rework on the IndexedDB feature since the
expectation was set.

  • platform/chromium/test_expectations.txt:
13:19 Changeset [106841] by shawnsingh@chromium.org

Merge 106459 - Fix the semantics of passing contentsVisible flag to GraphicsLayers
https://bugs.webkit.org/show_bug.cgi?id=76975

Reviewed by Simon Fraser.

Source/WebCore:

This patch is covered by existing tests, in particular
compositing/visibility/layer-visible-content.html; its
expectations are rebaselined.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

LayoutTests:

  • compositing/visibility/layer-visible-content-expected.txt: rebaselined expected result
  • compositing/visibility/layer-visible-content.html: fixed height so that result is platform-independent
  • platform/chromium/test_expectations.txt: removed fail expectation, it should pass now.

TBR=shawnsingh@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9342003

13:17 Changeset [106840] by jamesr@google.com

Source/WebCore: Support detaching TextureManager from ManagedTexture
https://bugs.webkit.org/show_bug.cgi?id=77655

Reviewed by Kenneth Russell.
Initial patch by Alok Priyadarshi.

TextureManager now holds references to the textures it manages.
This allows TextureManager to inform managed textures when it gets deleted
so that the texture that outlive the TextureManager can handle the situation gracefully.

Unit test in TextureManagerTest.cpp

  • platform/graphics/chromium/ManagedTexture.cpp:

(WebCore::ManagedTexture::ManagedTexture):
(WebCore::ManagedTexture::~ManagedTexture):
(WebCore):
(WebCore::ManagedTexture::managerWillDie):
(WebCore::ManagedTexture::isValid):
(WebCore::ManagedTexture::reserve):
(WebCore::ManagedTexture::unreserve):
(WebCore::ManagedTexture::steal):
(WebCore::ManagedTexture::reset):

  • platform/graphics/chromium/ManagedTexture.h:

(WebCore::ManagedTexture::manager):
(ManagedTexture):
(WebCore::ManagedTexture::isReserved):

  • platform/graphics/chromium/TextureManager.cpp:

(WebCore::TextureManager::~TextureManager):
(WebCore):
(WebCore::TextureManager::setPreferredMemoryLimitBytes):
(WebCore::TextureManager::registerTexture):
(WebCore::TextureManager::unregisterTexture):

  • platform/graphics/chromium/TextureManager.h:

(WebCore):
(TextureManager):

Source/WebKit/chromium: [chromium] Support detaching TextureManager from ManagedTexture
https://bugs.webkit.org/show_bug.cgi?id=77655

Adds unit test for destroying a TextureManager while ManagedTextures are still alive referring to it.

Reviewed by Kenneth Russell.

  • tests/TextureManagerTest.cpp:
13:05 Changeset [106839] by andersca@apple.com

Wheel event handler count not updated when adding handlers to the window
https://bugs.webkit.org/show_bug.cgi?id=77895

Reviewed by Dan Bernstein.

Source/WebCore:

Test: fast/events/wheelevent-handler-count.html

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
Update the wheel event count.

  • testing/Internals.cpp:

(WebCore::Internals::wheelEventHandlerCount):

  • testing/Internals.h:
  • testing/Internals.idl:

Add wheelEventHandlerCount to window.internals.

LayoutTests:

  • fast/events/wheelevent-handler-count-expected.txt: Added.
  • fast/events/wheelevent-handler-count.html: Added.
13:01 Changeset [106838] by commit-queue@webkit.org

Source/WebKit2: [GTK] Fix remaining errors in GTK+ WebKit2 API
https://bugs.webkit.org/show_bug.cgi?id=77890

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-02-06
Reviewed by Gustavo Noronha Silva.

Fix some style issues in the GTK+ WebKit2 API section of the source code.

  • UIProcess/API/gtk/WebKitPrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:
  • UIProcess/API/gtk/tests/TestMain.h:

Tools: [GTK] Fix remaining errors in GTK+ WebKit2 API
https://bugs.webkit.org/show_bug.cgi?id=77890

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-02-06
Reviewed by Gustavo Noronha Silva.

Verify that WebKit2 GTK+ test files are not skipped during style checks.
Skip soup_server_new when checking for NULL versus 0 usage.

  • Scripts/webkitpy/style/checker_unittest.py:

(CheckerDispatcherSkipTest.test_should_skip_with_warning):

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_for_null):

13:00 CommitterTips edited by bweinstein@apple.com
(diff)
13:00 CommitterTips edited by bweinstein@apple.com
(diff)
12:57 CommitterTips edited by bweinstein@apple.com
(diff)
12:56 Changeset [106837] by lforschler@apple.com

Merged r106729.

12:54 Changeset [106836] by mdelaney@apple.com

toDataURL() uses stale data after putImageData()
https://bugs.webkit.org/show_bug.cgi?id=65767

Source/WebCore:

This patch fixes the issue we've encountered of getting back
stale copies of the CGContext of accelerated ImageBuffers who have seen
putImageData calls but have not been drawn into via the CG API.
This issue is fixed by modifying the way we implement putImageData
in ImageBufferCG to draw the bits wrapped in a CGImage while the CGContext
is in a state where the data will effectively be copied (as is needed for
implementing putImageData) instead of directly modifying the bits of the IOSurface.

Reviewed by Chris Marrin.

Test: fast/canvas/check-stale-putImageData, pixel test to check that the canvas is in fact painted.

  • platform/graphics/cg/ImageBufferCG.cpp: Implement new way of putting image data.
  • platform/graphics/ImageBuffer.h: Merged two previously separate put data calls

into a single and more sensibly named 'putByteArray', since that's what it does!

  • WebCore.exp.in: Added new WKSI call for use in ImageBufferCG.cpp
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Using new method name.

  • html/canvas/CanvasRenderingContext2D.cpp:
  • platform/graphics/ImageBuffer.cpp:
  • platform/graphics/ShadowBlur.cpp:
  • platform/graphics/filters/FEColorMatrix.cpp:
  • platform/graphics/filters/FEDropShadow.cpp:
  • platform/graphics/filters/FilterEffect.cpp:

Updated other ports' ImageBuffers to use new method.

  • platform/graphics/cairo/ImageBufferCairo.cpp:
  • platform/graphics/qt/ImageBufferQt.cpp:
  • platform/graphics/skia/ImageBufferSkia.cpp:
  • platform/graphics/wince/ImageBufferWinCE.cpp:
  • platform/graphics/wx/ImageBufferWx.cpp:

Source/WebKit/chromium:

Reviewed by Chris Marrin.

  • src/WebViewImpl.cpp: Updated method name.

(WebKit::WebViewImpl::doPixelReadbackToCanvas):

Source/WebKit/mac:

Reviewed by Chris Marrin.

  • WebCoreSupport/WebSystemInterface.mm:

Source/WebKit2:

Reviewed by Chris Marrin.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

WebKitLibraries:

Added WKCGContextResetClip for use in reseting clip for new putByteArray method.

Reviewed by Chris Marrin.

  • WebKitSystemInterface.h: Added WKCGContextResetClip.
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceLion.a:
12:54 Changeset [106835] by lforschler@apple.com

Merged r104356.

12:48 Changeset [106834] by lforschler@apple.com

Merged r106594.

12:42 Changeset [106833] by caio.oliveira@openbossa.org

Provide more attribute methods in Element
https://bugs.webkit.org/show_bug.cgi?id=77800

Reviewed by Ryosuke Niwa.

Source/WebCore:

Reduce the clients of NamedNodeMap. This will make easier to change the
implementation of our attribute storage. The clients now use Element methods
that expose Attribute* accessors.

Instead of checking the existence of NamedNodeMap, clients can call
hasAttributes() or hasAttributesWithoutUpdate() (that skips updating invalid
style or animation svg attributes).

If there are attributes, they can be accessed by index via attributeCount() /
attributeItem(), as well as by QualifiedName. Those accessors assume there are an
attribute storage.

  • css/SelectorChecker.cpp:

(WebCore::anyAttributeMatches):
(WebCore::SelectorChecker::checkOneSelector):

  • css/SelectorChecker.h:

(WebCore::SelectorChecker::checkExactAttribute):

  • dom/DatasetDOMStringMap.cpp:

(WebCore::DatasetDOMStringMap::getNames):
(WebCore::DatasetDOMStringMap::item):
(WebCore::DatasetDOMStringMap::contains):

  • dom/Document.cpp:

(WebCore::Document::importNode): use setAttributesFromElement() instead of manually copying.

  • dom/Element.h:

(Element):
(WebCore::Element::hasAttributesWithoutUpdate):
(WebCore):
(WebCore::Element::attributeCount):
(WebCore::Element::attributeItem):
(WebCore::Element::getAttributeItem):
(WebCore::Element::removeAttribute):

  • dom/Node.cpp:

(WebCore::Node::isDefaultNamespace):
(WebCore::Node::lookupNamespaceURI):
(WebCore::Node::lookupNamespacePrefix):
(WebCore::Node::compareDocumentPosition):

  • editing/ApplyStyleCommand.cpp:

(WebCore::hasNoAttributeOrOnlyStyleAttribute):
(WebCore::isEmptyFontTag):

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::elementIsStyledSpanOrHTMLEquivalent):

  • editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::highestVisuallyEquivalentDivBelowRoot):

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendElement):

  • editing/markup.cpp:

(WebCore::completeURLs):
(WebCore::StyledMarkupAccumulator::appendElement):

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::parametersForPlugin):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateType):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parametersForPlugin):

  • html/HTMLParamElement.cpp:

(WebCore::HTMLParamElement::isURLAttribute):

  • html/parser/HTMLFormattingElementList.cpp:

(WebCore::attributeCountWithoutUpdate):
(WebCore::HTMLFormattingElementList::tryToEnsureNoahsArkConditionQuickly):
(WebCore::HTMLFormattingElementList::ensureNoahsArkCondition): Store Attribute*
to avoid looking up the right element again by name.

  • inspector/DOMEditor.cpp:

(WebCore::DOMEditor::innerPatchNode):
(WebCore::DOMEditor::createDigest):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::buildArrayForElementAttributes):

  • page/PageSerializer.cpp:

(WebCore::isCharsetSpecifyingNode):

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::getPresentationAttribute):

  • xml/XPathFunctions.cpp:

(WebCore::XPath::FunLang::evaluate):

  • xml/XPathNodeSet.cpp:

(WebCore::XPath::NodeSet::traversalSort):

  • xml/XPathStep.cpp:

(WebCore::XPath::Step::nodesInAxis):

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):

  • xml/parser/XMLTreeBuilder.cpp:

(WebCore::XMLTreeBuilder::XMLTreeBuilder):

Source/WebKit/chromium:

  • src/WebPageSerializerImpl.cpp:

(WebKit::WebPageSerializerImpl::openTagToString): access attributes via Element interface.

Source/WebKit/qt:

  • Api/qwebelement.cpp:

(QWebElement::attributeNames): access attributes via Element interface.

12:29 Changeset [106832] by eric@webkit.org

webkit-patch apply-from-bug should be able to apply non-reviewed patches
https://bugs.webkit.org/show_bug.cgi?id=77883

Reviewed by Adam Barth.

This is very helpful if you use bugzilla as a replacement for git-stash.
Makes it simpler to re-apply the patch w/o having to look up the patch id.

  • Scripts/webkitpy/tool/commands/download.py:

(ProcessBugsMixin._fetch_list_of_patches_to_process):

  • Scripts/webkitpy/tool/commands/download_unittest.py:

(DownloadCommandsTest.test_apply_from_bug):

12:12 Changeset [106831] by kov@webkit.org

[GTK] Insta-crash when closing browser with inspector window opened
https://bugs.webkit.org/show_bug.cgi?id=50744

Reviewed by Martin Robinson.

Source/WebKit/gtk:

  • GNUmakefile.am:
  • WebCoreSupport/InspectorClientGtk.cpp:

(WebKit::InspectorClient::releaseFrontendPage): also let go of the
frontend client when releasing the frontend page;
(WebKit::InspectorFrontendClient::~InspectorFrontendClient(): Call releaseFrontendPage()
like other ports do instead of just disconnectFrontendClient().
(WebKit::InspectorFrontendClient::destroyInspectorWindow): Use GRefPtr for the
inspector ref.
(WebKit::InspectorFrontendClient::bringToFront): Adjust for GRefPtr usage.
(WebKit::InspectorFrontendClient::attachWindow): Ditto.
(WebKit::InspectorFrontendClient::detachWindow): Ditto.
(WebKit::InspectorFrontendClient::inspectedURLChanged): Ditto.

  • WebCoreSupport/InspectorClientGtk.h:

(InspectorFrontendClient): Use GRefPtr for inspector member.

  • tests/testwebinspector.c: Added. Test that killing a WebView with the inspector

open does not crash, and that closing and reinspecting works.
(quitLoop):
(consoleMessageCallback):
(inspectElementCallback):
(closeInspector):
(showInspector):
(test_webkit_web_inspector_close_and_inspect):
(test_webkit_web_inspector_destroy_inspected_web_view):
(main):

LayoutTests:

  • platform/gtk/Skipped: unskip inspector/debugger/open-close-open.html,

which now passes.

12:00 Changeset [106830] by jsbell@chromium.org

IndexedDB: Raise exception during add/put call if autoIncrement key insertion will fail
https://bugs.webkit.org/show_bug.cgi?id=77374

Source/WebCore:

If a put request will use a key generator, try inserting a dummy key during the sync
put() call to check if the key insertion will succeed so an exception can be raised
early, rather than deferring to the asynchronous task.

Reviewed by Tony Chang.

Test: storage/indexeddb/keypath-edges.html

  • storage/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::put):

LayoutTests:

Reviewed by Tony Chang.

  • storage/indexeddb/keypath-edges-expected.txt:
  • storage/indexeddb/keypath-edges.html:
11:56 Changeset [106829] by jchaffraix@webkit.org

[Chromium] Test fast/forms/listbox-clear-restore.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=77889

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
11:54 Changeset [106828] by kov@webkit.org

Add a null check for the gdkwindow, that will happen if the window
is not mapped.

Reviewed by Martin Robinson.

  • platform/gtk/GtkUtilities.cpp:

(WebCore::convertWidgetPointToScreenPoint):

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::setCursor):

11:50 Changeset [106827] by commit-queue@webkit.org

Source/WebCore: IndexedDB createObjectStore should throw if options arg is invalid
Added logic to OptionsObject to determine if an invalid object was created.
Javascript bindings now detect invalid OptionsObject's and throw TypeError when found.
https://bugs.webkit.org/show_bug.cgi?id=58471

Patch by Eugene Girard <girard@chromium.org> on 2012-02-06
Reviewed by Adam Barth.

Test: storage/indexeddb/createObjectStore-bad-options.html

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateParametersCheck):

  • bindings/v8/OptionsObject.cpp:

(WebCore::OptionsObject::isObject):

  • bindings/v8/OptionsObject.h:

LayoutTests: IndexedDB createObjectStore should throw if options arg is invalid (not an object).
Added unit tests to test invalid arguments.
storage/indexddb/transaction-basics was modified only to correct calls that would
now throw.
https://bugs.webkit.org/show_bug.cgi?id=58471

Patch by Eugene Girard <girard@chromium.org> on 2012-02-06
Reviewed by Adam Barth.

  • storage/indexeddb/create-object-store-options-expected.txt:
  • storage/indexeddb/create-object-store-options.html:
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/resources/shared.js:

(evalAndExpectExceptionClass):

  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-basics.html:
  • storage/indexeddb/tutorial.html:
11:50 Changeset [106826] by leviw@chromium.org

Fixing incorrect usage of AppUnits as parameters to Widgets.

11:37 Changeset [106825] by jesus@webkit.org

[Qt][WK2] http/tests/loading/state-object-security-exception.html fails
https://bugs.webkit.org/show_bug.cgi?id=62731

Unreviewed gardening.

Skipped 3 tests because they were still failing after http://trac.webkit.org/changeset/106812 .
Skipped tests were:
fast/history/form-submit-in-frame-via-onclick.html
fast/history/form-submit-in-frame.html
http/tests/loading/state-object-security-exception.html

  • platform/qt-wk2/Skipped:
11:37 Changeset [106824] by rniwa@webkit.org

gcc build fix after r106749.

  • UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::WebPreferences):

11:28 Changeset [106823] by jchaffraix@webkit.org

Unreviewed, rolling out r106797 and r106806.
http://trac.webkit.org/changeset/106797
http://trac.webkit.org/changeset/106806
https://bugs.webkit.org/show_bug.cgi?id=77888

The change is still causing some crashes in webaudio/ on the
Chromium bots (Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-06

Source/WebCore:

  • Modules/intents/IntentRequest.cpp:

(WebCore::IntentRequest::create):

  • bindings/generic/ActiveDOMCallback.cpp:

(WebCore::ActiveDOMCallback::ActiveDOMCallback):

  • dom/ActiveDOMObject.cpp:

(WebCore::ActiveDOMObject::ActiveDOMObject):
(WebCore::ActiveDOMObject::~ActiveDOMObject):

  • dom/ActiveDOMObject.h:

(ActiveDOMObject):

  • dom/DocumentEventQueue.cpp:

(WebCore::DocumentEventQueue::DocumentEventQueue):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::ScriptExecutionContext):
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
(WebCore::ScriptExecutionContext::stopActiveDOMObjects):

  • dom/ScriptExecutionContext.h:

(ScriptExecutionContext):

  • fileapi/DOMFileSystem.cpp:

(WebCore::DOMFileSystem::create):

  • fileapi/FileReader.cpp:

(WebCore):

  • fileapi/FileReader.h:

(WebCore::FileReader::create):

  • fileapi/FileWriter.cpp:

(WebCore):

  • fileapi/FileWriter.h:

(WebCore::FileWriter::create):

  • history/CachedFrame.cpp:

(WebCore::CachedFrame::CachedFrame):

  • html/HTMLAudioElement.cpp:

(WebCore::HTMLAudioElement::create):
(WebCore::HTMLAudioElement::createForJSConstructor):

  • html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::create):

  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::create):

  • mediastream/PeerConnection.cpp:

(WebCore::PeerConnection::create):

  • notifications/Notification.cpp:

(WebCore::Notification::create):

  • notifications/NotificationCenter.cpp:
  • notifications/NotificationCenter.h:

(WebCore::NotificationCenter::create):

  • page/DOMTimer.cpp:

(WebCore::DOMTimer::install):
(WebCore::DOMTimer::fired):

  • page/EventSource.cpp:

(WebCore::EventSource::create):

  • page/SuspendableTimer.cpp:

(WebCore::SuspendableTimer::SuspendableTimer):

  • storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::create):

  • storage/IDBRequest.cpp:

(WebCore::IDBRequest::create):

  • storage/IDBTransaction.cpp:

(WebCore::IDBTransaction::create):

  • storage/IDBVersionChangeRequest.cpp:

(WebCore::IDBVersionChangeRequest::create):

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::create):

  • websockets/WebSocket.cpp:
  • websockets/WebSocket.h:

(WebCore::WebSocket::create):

  • workers/SharedWorker.cpp:

(WebCore::SharedWorker::create):

  • workers/Worker.cpp:

(WebCore::Worker::create):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::create):

LayoutTests:

  • fast/events/resources/suspend-subframe-1.html: Removed.
  • fast/events/resources/suspend-subframe-2.html: Removed.
  • fast/events/suspend-timers-expected.txt: Removed.
  • fast/events/suspend-timers.html: Removed.
  • platform/chromium/test_expectations.txt:
11:24 Changeset [106822] by lforschler@apple.com

Merged r106678.

11:13 Changeset [106821] by dslomov@google.com

Merge 106722 - [Chromium] WebCore::toV8Context crashes if DomWindow::frame() returns null.
https://bugs.webkit.org/show_bug.cgi?id=77686.

Reviewed by Adam Barth.

  • bindings/v8/V8Helpers.cpp:

(WebCore::toV8Context):

TBR=dslomov@google.com
Review URL: https://chromiumcodereview.appspot.com/9334005

11:01 Changeset [106820] by rniwa@webkit.org

Merge 106380 - Source/WebCore: Crash in DeleteSelectionCommand::handleGeneralDelete when attempting to delete the start block
https://bugs.webkit.org/show_bug.cgi?id=77077

Reviewed by Enrica Casucci.

The crash was caused by a missing null check after removing the position out of the start block.
Fixed the bug by adding an early return.

Tests: editing/deleting/delete-start-block.html

editing/selection/move-into-empty-root-inline-box.html

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::handleGeneralDelete):

LayoutTests: Crash in previousLinePosition when moving into a root inline box without leaves
https://bugs.webkit.org/show_bug.cgi?id=76812

Reviewed by Enrica Casucci.

Add a regression test for the crash. Unfortunately, we can only test previousLinePosition.

  • editing/selection/move-into-empty-root-inline-box-expected.txt: Added.
  • editing/selection/move-into-empty-root-inline-box.html: Added.

http://crbug.com/99408/
Review URL: https://chromiumcodereview.appspot.com/9331006

10:35 Changeset [106819] by caio.oliveira@openbossa.org

Move style related functions from NamedNodeMap to ElementAttributeData
https://bugs.webkit.org/show_bug.cgi?id=77879

Reviewed by Ryosuke Niwa.

This commit also removes the NamedNodeMap::mappedAttributeCount(),
which is a leftover from removal of mapped attributes.

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::ensureInlineStyleDecl):
(WebCore):
(WebCore::ElementAttributeData::destroyInlineStyleDecl):
(WebCore::ElementAttributeData::ensureAttributeStyle):

  • dom/ElementAttributeData.h:

(WebCore::ElementAttributeData::inlineStyleDecl):
(ElementAttributeData):
(WebCore::ElementAttributeData::attributeStyle):

  • dom/NamedNodeMap.cpp:
  • dom/NamedNodeMap.h:
  • dom/StyledElement.h:

(StyledElement):
(WebCore::StyledElement::inlineStyleDecl):
(WebCore::StyledElement::ensureInlineStyleDecl):
(WebCore::StyledElement::attributeStyle):
(WebCore::StyledElement::ensureAttributeStyle):
(WebCore::StyledElement::destroyInlineStyleDecl):

10:23 Changeset [106818] by inferno@chromium.org

Crash in SubframeLoader::loadSubframe.
https://bugs.webkit.org/show_bug.cgi?id=77345

Reviewed by Nate Chapin.

Source/WebCore:

Mutation event when loading subframe can blow away the
main frame. Add a RefPtr to protect against that.

Test: fast/frames/subframe-load-crash-main.html

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::loadSubframe):

LayoutTests:

  • fast/frames/resources/subframe-load-crash.svg: Added.
  • fast/frames/subframe-load-crash-main-expected.txt: Added.
  • fast/frames/subframe-load-crash-main.html: Added.
10:20 Changeset [106817] by senorblanco@chromium.org

Merge 106477 - [SKIA/CHROMIUM] Perform getImageData format conversions using Skia
https://bugs.webkit.org/show_bug.cgi?id=77553

Patch by Brian Salomon <bsalomon@google.com> on 2012-02-01
Reviewed by Stephen White.

Source/WebCore:

Many existing canvas tests exercise this functionality.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::getImageData):

LayoutTests:

  • platform/chromium/test_expectations.txt:

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9331005

09:59 Changeset [106816] by commit-queue@webkit.org

[GTK] WebKitWebView does a lot of work during size_allocate when not mapped
https://bugs.webkit.org/show_bug.cgi?id=77743

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-02-06
Reviewed by Gustavo Noronha Silva.

Instead of resizing the guts of a WebView when it's not mapped, wait
until it's mapped and do one resize. This prevents unmapped WebViews
from adding to a container's resize cost.

Source/WebKit/gtk:

  • webkit/webkitwebview.cpp:

(resizeWebViewFromAllocation): Abstracted out this helper.
(webkit_web_view_size_allocate): Wait until map to resize umapped widgets.
(webkitWebViewMap): Added this vmethod implementation.
(webkit_web_view_class_init): Added vmethod.

  • webkit/webkitwebviewprivate.h: Added new needsResizeOnMap member.

Source/WebKit2:

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(_WebKitWebViewBasePrivate): Added a new member needsResizeOnMap.
(resizeWebKitWebViewBaseFromAllocation): Abstracted out this helper.
(webkitWebViewBaseSizeAllocate): Wait until map to resize unmapped WebViews.
(webkitWebViewBaseMap): Added this vmethod implementation.
(webkit_web_view_base_class_init): Added vmethod.

09:49 Changeset [106815] by commit-queue@webkit.org

Initial implementation of GraphicsContext3DOpenGLES.cpp
https://bugs.webkit.org/show_bug.cgi?id=76248

Patch by ChangSeok Oh <shivamidow@gmail.com> on 2012-02-06
Reviewed by Martin Robinson.

Implemented APIs in GraphicsContext3DOpenGLES.cpp according to the GLES spec. roughly.
But no way to run these codes right now, because they need an extra port
specific implementation to work. I plan to add these extra codes for the GTK port
in the next patch. And also this patch doesn't support anti-aliasing yet. Another bug
will deal with it.
Moved some APIs in GraphicsContext3DOpenGLES.cpp to GraphicsContext3DCommon.cpp.
It looks it could be shared between gl and gles.
Two helper functions are added to avoid code duplication in GraphicsContext3D.
Added a missing period at the end of comment lines.

No new tests required.
We'll be able to verify this patch by using the existing webgl test cases.

  • platform/graphics/GraphicsContext3D.h: Add build flag to access stencilBuffer & depthBuffer for gles.

(WebCore):

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::reshapeFBOs): Helper function extracted from GC3D::reshape to resize regular & multisampled FBOs.
(WebCore::GraphicsContext3D::resolveMultisamplingIfNecessary): Helper function to resolve multisampling.

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::validateAttributes): Add condition to disable antialiasing & packedDepthStencilExtension for GLES.
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):

Following APIs looked shareable so that moved into GC3DOpenGLCommon.cpp.
(WebCore::GraphicsContext3D::prepareTexture):
(WebCore):
(WebCore::GraphicsContext3D::readRenderingResults):
(WebCore::GraphicsContext3D::reshape):
(WebCore::GraphicsContext3D::bindFramebuffer):
(WebCore::GraphicsContext3D::copyTexImage2D):
(WebCore::GraphicsContext3D::copyTexSubImage2D):
(WebCore::GraphicsContext3D::getActiveUniform):
(WebCore::GraphicsContext3D::readPixels):

Added a missing period at the end of comment line.
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::getActiveAttrib):
(WebCore::GraphicsContext3D::uniform2fv):
(WebCore::GraphicsContext3D::uniform3fv):
(WebCore::GraphicsContext3D::uniform4fv):
(WebCore::GraphicsContext3D::uniform2iv):
(WebCore::GraphicsContext3D::uniform3iv):
(WebCore::GraphicsContext3D::uniform4iv):
(WebCore::GraphicsContext3D::uniformMatrix2fv):
(WebCore::GraphicsContext3D::uniformMatrix3fv):
(WebCore::GraphicsContext3D::uniformMatrix4fv):
(WebCore::GraphicsContext3D::texSubImage2D):

  • platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:

(WebCore::GraphicsContext3D::reshapeFBOs): Same with the above.
(WebCore::GraphicsContext3D::resolveMultisamplingIfNecessary): Same with the above.

Brief explanation about what the differences are between gl and gles.
(WebCore::GraphicsContext3D::renderbufferStorage): Removed codes for converting GLES parameter to GL parameter.
(WebCore::GraphicsContext3D::getIntegerv): Removed codes that emulate GLES.
(WebCore::GraphicsContext3D::texImage2D): Removed codes for converting GLES parameter to GL parameter.

09:33 Changeset [106814] by philn@webkit.org

[webkitpy] cpp style-checker complains about readability/naming in GStreamer elements source files
https://bugs.webkit.org/show_bug.cgi?id=77866

Reviewed by Martin Robinson.

  • Scripts/webkitpy/style/checker.py: Ignore readability/naming

errors in some gstreamer source code files defining new GStreamer elements.

  • Scripts/webkitpy/style/checker_unittest.py:

(GlobalVariablesTest.test_path_rules_specifier):

09:31 Changeset [106813] by senorblanco@chromium.org

Merge 106732 - [chromium] Fix multi-second hangs in compositor invalidating large layers
https://bugs.webkit.org/show_bug.cgi?id=77774

Reviewed by James Robinson.

Correctness covered by existing tests.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::pushPropertiesTo):
Remove tiles from the tiler when they are invalid (ie., no longer have
texture backing).
(WebCore::TiledLayerChromium::invalidateRect):
Instead of iterating over the tile indices (which may be very large),
iterate over the tile hash map instead.

TBR=senorblanco@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9333004

09:05 Changeset [106812] by jesus@webkit.org

[Qt][WK2] http/tests/loading/state-object-security-exception.html fails
https://bugs.webkit.org/show_bug.cgi?id=62731

Rubber stamped by Csaba Osztrogonác.

Unskipping tests that were kept as skipped even after
https://bugs.webkit.org/show_bug.cgi?id=42333 was fixed.

  • platform/wk2/Skipped:
08:57 Changeset [106811] by apavlov@chromium.org

Web Inspector: [Meta] Allow emulation of touch events
https://bugs.webkit.org/show_bug.cgi?id=77096

Reviewed by Pavel Feldman.

This is the inspector part of the change, core part implementation tracked in bug 77105.

  • English.lproj/localizedStrings.js:
  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:

(DOMAgentState):
(WebCore::InspectorDOMAgent::clearFrontend):
(WebCore::InspectorDOMAgent::restore):
(WebCore):
(WebCore::InspectorDOMAgent::updateTouchEventEmulationInDocuments):
(WebCore::InspectorDOMAgent::setTouchEmulationEnabled):

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype._captureDOM):
(WebInspector.DOMAgent.prototype._emulateTouchEventsChanged):

  • inspector/front-end/Settings.js:

(WebInspector.Settings):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):

08:39 Changeset [106810] by commit-queue@webkit.org

[Blackberry] Non-supported about: operations never stops loading
https://bugs.webkit.org/show_bug.cgi?id=76366

Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-02-06
Reviewed by Rob Buis.

If user typed a non-supported "about:" scheme such as "about:nonsupport",
the loadAboutURL() function in NetworkManger should recognize and handle it as
an error of invalid url.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::loadAboutURL):
(WebCore::NetworkJob::handleAbout):

  • platform/network/blackberry/NetworkJob.h:

(NetworkJob):

  • platform/network/blackberry/NetworkManager.cpp:

(WebCore::NetworkManager::startJob):

08:26 Changeset [106809] by apavlov@chromium.org

Web Inspector: Remove unused disabledComputedProperties from methods in StylesSidebarPane
https://bugs.webkit.org/show_bug.cgi?id=77876

Reviewed by Pavel Feldman.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._refreshUpdate):
(WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._markUsedProperties):
(WebInspector.StylesSidebarPane.prototype._refreshSectionsForStyleRules):
(WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
(WebInspector.StylePropertiesSection.prototype.onpopulate):
(WebInspector.ComputedStylePropertiesSection):
(WebInspector.ComputedStylePropertiesSection.prototype._isPropertyInherited):

08:20 Changeset [106808] by loislo@chromium.org

Web Inspector: Redesign summary view / retaining tree contents
https://bugs.webkit.org/show_bug.cgi?id=77870

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-02-06
Reviewed by Pavel Feldman.

  1. Make object IDs less contrast.
  2. Put array indices in [].
  3. Do not write type if it's just "Object".

Source/WebCore:

  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotGenericObjectNode.prototype._createObjectCell):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
(WebInspector.HeapSnapshotObjectNode.prototype._emptyData):
(WebInspector.HeapSnapshotObjectNode.prototype._enhanceData):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):
(WebInspector.HeapSnapshotConstructorNode.prototype.get data):

  • inspector/front-end/heapProfiler.css:

(.detailed-heapshot-view .console-formatted-id):
(.detailed-heapshot-view td.object-column span.grayed):

LayoutTests:

  • inspector/profiler/detailed-heapshots-test.js:

(initialize_DetailedHeapshotTest.):
(initialize_DetailedHeapshotTest):

08:10 Changeset [106807] by noam.rosenthal@nokia.com

[Texmap][Qt] Avoid an image copy when uploading textures in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=77748

Reviewed by Kenneth Rohde Christiansen.

Use QPixmap::buffer() API to get access to the QPixmap's pixels without implicit copies.

Instrumentation shows that the deep image copies created from TextureMapperGL are
eliminated.

  • platform/graphics/opengl/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::updateContents):

08:05 Changeset [106806] by tonyg@chromium.org

LayoutTest failures on r106797
https://bugs.webkit.org/show_bug.cgi?id=77868

Call suspendIfNeeded from subclass of IDBRequest, IDBVersionChangeRequest.

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-06
Reviewed by Simon Hausmann.

  • storage/IDBVersionChangeRequest.cpp:

(WebCore::IDBVersionChangeRequest::create):

06:54 Changeset [106805] by carlosgc@webkit.org

[GTK] Make sure html_dir exists before calling gtkdoc-rebase
https://bugs.webkit.org/show_bug.cgi?id=77869

Reviewed by Philippe Normand.

  • gtk/gtkdoc.py:

(GTKDoc.rebase_installed_docs): Check html_dir exists.

06:18 Changeset [106804] by noam.rosenthal@nokia.com

[Qt] Implement ImageBuffer::copyImage(ImageBuffer::DontCopyBackingStore)
https://bugs.webkit.org/show_bug.cgi?id=77689

Reviewed by Kenneth Rohde Christiansen.

Use StillImageQt::createForRendering when using DontCopyBackingStore.
Enable DontCopyBackingStore in TextureMapperNode.
This removes deep copies resulting from the use of ImageBuffer.

Instrumentation shows that deep image copies resulted from ImageBuffer are eliminated.

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::ImageBuffer::copyImage):

  • platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::renderContent):

06:07 Changeset [106803] by commit-queue@webkit.org

WebGestureEvent can not encode delta and area.
https://bugs.webkit.org/show_bug.cgi?id=77728

Source/WebCore:

Add area field to PlatformGestureEvent.

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-06
Reviewed by Kenneth Rohde Christiansen.

  • platform/PlatformGestureEvent.h:

(WebCore::PlatformGestureEvent::PlatformGestureEvent):
(WebCore::PlatformGestureEvent::area):

Source/WebKit2:

Support delta and area fields in WebGestureEvent, and send area with Qt tap gesture.

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-06
Reviewed by Kenneth Rohde Christiansen.

  • Shared/WebEvent.h:

(WebKit::WebGestureEvent::area):
(WebKit::WebGestureEvent::delta):

  • Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformGestureEvent::WebKit2PlatformGestureEvent):

  • Shared/WebGestureEvent.cpp:

(WebKit::WebGestureEvent::WebGestureEvent):
(WebKit::WebGestureEvent::encode):
(WebKit::WebGestureEvent::decode):

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::handleSingleTapEvent):

05:55 Changeset [106802] by commit-queue@webkit.org

[BlackBerry]Use extension for a mimetype as the suggested extension
if the url file doesn't have an extension.
https://bugs.webkit.org/show_bug.cgi?id=76779

Patch by Charles Wei <charles.wei@torchmobile.com.cn> on 2012-02-06
Reviewed by Antonio Gomes.

No new tests.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::sendResponseIfNeeded):

05:24 Changeset [106801] by hans@chromium.org

Speech input: fix fast/speech/bubble-position.html
https://bugs.webkit.org/show_bug.cgi?id=77732

Reviewed by Tony Gentilcore.

There is no need for the test to check the pixel-exact position of the
rect, since that seems to vary a little between platforms.
The point of the test is to check that the rect is within the iframe,
so let's do that.

  • fast/speech/bubble-position-expected.txt:
  • fast/speech/bubble-position.html:
05:11 Changeset [106800] by jocelyn.turcotte@nokia.com

[Qt][WK2] Remove TiledDrawingArea and dependencies.
https://bugs.webkit.org/show_bug.cgi?id=71681

Reviewed by Kenneth Rohde Christiansen.

Tiled drawing surface functionality got converted to LayerTree.
TiledDrawingArea and its dependencies are not used by any port anymore.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • Shared/DrawingAreaInfo.h:
  • Target.pri:
  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPagePrivate::QQuickWebPagePrivate):

  • UIProcess/API/qt/qquickwebpage_p.h:
  • UIProcess/API/qt/qquickwebpage_p_p.h:

(QQuickWebPagePrivate):

  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxy.messages.in:
  • UIProcess/TiledDrawingAreaProxy.cpp: Removed.
  • UIProcess/TiledDrawingAreaProxy.h: Removed.
  • UIProcess/qt/QtSGTileNode.cpp: Removed.
  • UIProcess/qt/QtSGTileNode.h: Removed.
  • UIProcess/qt/QtSGUpdateQueue.cpp: Removed.
  • UIProcess/qt/QtSGUpdateQueue.h: Removed.
  • UIProcess/qt/TiledDrawingAreaProxyQt.cpp: Removed.
  • WebProcess/WebPage/DrawingArea.cpp:

(WebKit::DrawingArea::create):

  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/DrawingArea.messages.in:
  • WebProcess/WebPage/TiledDrawingArea.cpp: Removed.
  • WebProcess/WebPage/TiledDrawingArea.h: Removed.
  • WebProcess/WebPage/WebPage.h:

(WebPage):

05:09 Changeset [106799] by jocelyn.turcotte@nokia.com

[Qt] Don't version QtWebKit.experimental.
https://bugs.webkit.org/show_bug.cgi?id=77739

Reviewed by Tor Arne Vestbø.

Source/WebKit/qt:

We won't support previous versions of the experimental API.

  • declarative/experimental/plugin.cpp:

Source/WebKit2:

  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_itemSelector.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_messaging.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_download.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_geopermission.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_javaScriptDialogs.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_navigationHistory.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml:

Tools:

  • MiniBrowser/qt/qml/BrowserWindow.qml:
04:56 Changeset [106798] by haraken@chromium.org

Rename [HasIndexGetter], [HasNameGetter] and [HasCustomIndexSetter] IDLs
https://bugs.webkit.org/show_bug.cgi?id=77848

Reviewed by Adam Barth.

For naming consistency with [CustomGetter] and [CustomSetter],
this patch renames the following IDLs:

[HasIndexGetter] => [IndexedGetter] (Remove "Has". This IDL is for "indexed" properties
in the Web IDL: http://dev.w3.org/2006/webapi/WebIDL/#idl-indexed-properties)
[HasCustomIndexSetter] => [CustomIndexedSetter] (Ditto.)
[HasNameGetter] => [NamedGetter] (Remove "Has". This IDL is for "named" properties
in the Web IDL: http://dev.w3.org/2006/webapi/WebIDL/#idl-named-properties)

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateImplementationIndexer):
(GenerateImplementationNamedPropertyGetter):

  • bindings/scripts/test/TestEventTarget.idl: No change in run-bindings-tests results.
  • bindings/scripts/test/TestTypedArray.idl: Ditto.
  • Modules/gamepad/GamepadList.idl:
  • css/CSSRuleList.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSValueList.idl:
  • css/MediaList.idl:
  • css/StyleSheetList.idl:
  • css/WebKitCSSFilterValue.idl:
  • css/WebKitCSSKeyframesRule.idl:
  • css/WebKitCSSTransformValue.idl:
  • dom/ClientRectList.idl:
  • dom/DOMStringList.idl:
  • dom/DOMStringMap.idl:
  • dom/DataTransferItemList.idl:
  • dom/NamedNodeMap.idl:
  • dom/NodeList.idl:
  • dom/TouchList.idl:
  • fileapi/EntryArray.idl:
  • fileapi/EntryArraySync.idl:
  • fileapi/FileList.idl:
  • html/DOMSettableTokenList.idl:
  • html/DOMTokenList.idl:
  • html/HTMLAllCollection.idl:
  • html/HTMLCollection.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLOptionsCollection.idl:
  • html/HTMLPropertiesCollection.idl:
  • html/HTMLSelectElement.idl:
  • html/TextTrackCueList.idl:
  • html/canvas/CanvasPixelArray.idl:
  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • html/canvas/Uint8ClampedArray.idl:
  • html/track/TextTrackList.idl:
  • mediastream/MediaStreamList.idl:
  • mediastream/MediaStreamTrackList.idl:
  • page/SpeechInputResultList.idl:
  • page/WebKitAnimationList.idl:
  • plugins/DOMMimeTypeArray.idl:
  • plugins/DOMPlugin.idl:
  • plugins/DOMPluginArray.idl:
  • storage/Storage.idl:
04:36 Changeset [106797] by commit-queue@webkit.org

Source/WebCore: Ensure timers and other active DOM objects do not fire in suspended documents.
https://bugs.webkit.org/show_bug.cgi?id=53733

ScriptExecutionContext now remembers it has suspended active DOM objects
and suspends all newly installed active DOM objects as well.

All create-calls active DOM objects now calls the post constructor method
suspendIfNeeded that updates the suspend state. It is post constructor
because the suspend/resume functions are virtual and thus can not be called
from constructors.

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-06
Reviewed by Mihai Parparita.

Test: fast/events/suspend-timers.html

  • Modules/intents/IntentRequest.cpp:

(WebCore::IntentRequest::create):

  • bindings/generic/ActiveDOMCallback.cpp:

(WebCore::ActiveDOMCallback::ActiveDOMCallback):

  • dom/ActiveDOMObject.cpp:

(WebCore::ActiveDOMObject::ActiveDOMObject):
(WebCore::ActiveDOMObject::~ActiveDOMObject):
(WebCore::ActiveDOMObject::suspendIfNeeded):

  • dom/ActiveDOMObject.h:

(WebCore::ActiveDOMObject::suspendIfNeededCalled):

  • dom/DocumentEventQueue.cpp:

(WebCore::DocumentEventQueue::DocumentEventQueue):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::ScriptExecutionContext):
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
(WebCore::ScriptExecutionContext::stopActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjectIfNeeded):

  • dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::activeDOMObjectsAreSuspended):

  • fileapi/DOMFileSystem.cpp:

(WebCore::DOMFileSystem::create):

  • fileapi/FileReader.cpp:

(WebCore::FileReader::create):

  • fileapi/FileReader.h:
  • fileapi/FileWriter.cpp:

(WebCore::FileWriter::create):

  • fileapi/FileWriter.h:
  • history/CachedFrame.cpp:

(WebCore::CachedFrame::CachedFrame):

  • html/HTMLAudioElement.cpp:

(WebCore::HTMLAudioElement::create):

  • html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::create):

  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::create):

  • mediastream/PeerConnection.cpp:

(WebCore::PeerConnection::create):

  • notifications/Notification.cpp:

(WebCore::Notification::create):

  • notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::create):

  • notifications/NotificationCenter.h:
  • page/DOMTimer.cpp:

(WebCore::DOMTimer::install):
(WebCore::DOMTimer::fired):

  • page/EventSource.cpp:

(WebCore::EventSource::create):

  • page/SuspendableTimer.cpp:

(WebCore::SuspendableTimer::SuspendableTimer):

  • storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::create):

  • storage/IDBRequest.cpp:

(WebCore::IDBRequest::create):

  • storage/IDBTransaction.cpp:

(WebCore::IDBTransaction::create):

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::create):

  • websockets/WebSocket.cpp:

(WebCore::WebSocket::create):

  • websockets/WebSocket.h:
  • workers/SharedWorker.cpp:

(WebCore::SharedWorker::create):

  • workers/Worker.cpp:

(WebCore::Worker::create):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::create):

LayoutTests: Test that timers do not fire from subframes of suspended documents.
https://bugs.webkit.org/show_bug.cgi?id=53733

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-06
Reviewed by Mihai Parparita.

  • fast/events/resources/suspend-subframe-1.html: Added.
  • fast/events/resources/suspend-subframe-2.html: Added.
  • fast/events/suspend-timers-expected.txt: Added.
  • fast/events/suspend-timers.html: Added.
  • platform/chromium/test_expectations.txt:
04:33 Changeset [106796] by paroga@webkit.org

Unreviewed WinCE build fix after r106197.

  • tools/CodeProfiling.cpp:

(JSC::CodeProfiling::notifyAllocator): getenv() isn't supported by WinCE. Don't call it.

03:18 Changeset [106795] by philn@webkit.org

Adding FFTFrameGStreamer.cpp that I forgot to commit
in r106537. That new file was reviewed in https://bugs.webkit.org/show_bug.cgi?id=73545.

  • platform/audio/gstreamer/FFTFrameGStreamer.cpp: Added.
02:39 Changeset [106794] by hayato@chromium.org

Add <shadow> element, which is guarded by SHADOW_DOM flag.
https://bugs.webkit.org/show_bug.cgi?id=76435

Reviewed by Dimitri Glazkov.

Test: fast/dom/shadow/shadow-element.html

Source/WebCore:

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLTagNames.in:
  • html/shadow/HTMLShadowElement.cpp: Added.

(WebCore):
(WebCore::HTMLShadowElement::HTMLShadowElement):
(WebCore::HTMLShadowElement::create):
(WebCore::HTMLShadowElement::~HTMLShadowElement):

  • html/shadow/HTMLShadowElement.h: Added.

(WebCore):
(HTMLShadowElement):

  • html/shadow/HTMLShadowElement.idl: Added.

LayoutTests:

  • fast/dom/shadow/shadow-element-expected.txt: Added.
  • fast/dom/shadow/shadow-element.html: Added.
02:26 Changeset [106793] by carlosgc@webkit.org

[GTK] Update NEWS and configure.ac for 1.7.5 release
https://bugs.webkit.org/show_bug.cgi?id=77859

Reviewed by Philippe Normand.

.:

  • configure.ac: Bumped version number.

Source/WebKit/gtk:

  • NEWS: Added release notes for 1.7.5.
02:18 Changeset [106792] by commit-queue@webkit.org

https://bugs.webkit.org/show_bug.cgi?id=76995.
WebKit fails IETC :indeterminate and input type=radio test.

All input types should respect indeterminate property(getter and setter). This is true with other browsers.
Indeterminate appearance for radio input type is supported by IOS platform. Webkit need not support indeterminate appearance
for radio input type on other platforms.

Patch by Joe Thomas <joethomas@motorola.com> on 2012-02-06
Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/forms/indeterminate-input-types.html

  • html/CheckboxInputType.cpp:

(WebCore::CheckboxInputType::supportsIndeterminateAppearance): Checks indeterminate appearance is supported.
(WebCore):

  • html/CheckboxInputType.h:

(CheckboxInputType):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setIndeterminate): Removed the check isCheckable().
(WebCore::HTMLInputElement::isIndeterminate): Checks indeterminate appearance is supported.
(WebCore):

  • html/HTMLInputElement.h:

(HTMLInputElement):

  • html/InputType.cpp:

(WebCore::InputType::supportsIndeterminateAppearance): Checks indeterminate appearance is supported.
(WebCore):

  • html/InputType.h:

(InputType):

  • html/RadioInputType.cpp:

(WebCore::RadioInputType::willDispatchClick): Indeterminate related code is moved to IOS specific.
(WebCore::RadioInputType::didDispatchClick): Ditto.
(WebCore::RadioInputType::supportsIndeterminateAppearance): Checks indeterminate appearance is supported.
(WebCore):

  • html/RadioInputType.h:

(RadioInputType):

LayoutTests:

  • fast/forms/indeterminate-input-types-expected.txt: Added.
  • fast/forms/indeterminate-input-types.html: Added.
  • fast/forms/indeterminate-radio.html:
02:02 Changeset [106791] by commit-queue@webkit.org

[BlackBerry] Remove unused variable in PluginViewBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=77847

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-02-06
Reviewed by Kentaro Hara.

No changes in behavior, so no new tests.

  • plugins/blackberry/PluginViewBlackBerry.cpp:

(WebCore::PluginView::updatePluginWidget):

01:58 Changeset [106790] by commit-queue@webkit.org

[BlackBerry] Remove unused variable in BackingStore
https://bugs.webkit.org/show_bug.cgi?id=77851

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-02-06
Reviewed by Kentaro Hara.

  • blackberry/Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::blitContents):

01:40 Changeset [106789] by zimmermann@webkit.org

2012-02-06 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Switch to unix file endings and at a trailing newline - hopefully the bots will accept my follow up patch then.

  • svg/filters/invalidate-on-child-layout.svg:
01:29 Changeset [106788] by carlosgc@webkit.org

[GTK] Fix several gtkdoc-fixxref warnings
https://bugs.webkit.org/show_bug.cgi?id=77613

Reviewed by Martin Robinson.

Source/WebKit/gtk:

  • docs/webkitgtk-docs.sgml: Remove webkitspellcheckerenchant

section.

  • docs/webkitgtk-sections.txt: Remove webkitspellcheckerenchant

symbols and move WebKitWebNavigationReason from the private
section to the global section.

  • webkit/webkitwebnavigationaction.h: Document

WebKitWebNavigationReason enum.

Source/WebKit2:

  • UIProcess/API/gtk/WebKitWindowProperties.cpp: Fix a typo, a

colon was missing in WebKitWebView::ready-to-show.

Tools:

  • gtk/generate-gtkdoc:

(get_webkit1_options): Add webkitspellcheckerenchant.* to the list
of ignored files, since it's private.

  • gtk/gtkdoc.py:

(GTKDoc._ignored_files_basenames): Helper function that returns a
string with the list of ignored files basenames separated by a
spaces, as expected by several gtkdoc commands.
(GTKDoc._run_gtkdoc_scan): Use _ignored_files_basenames for
--ignore-headers option.
(GTKDoc._run_gtkdoc_mkdb): Use _ignored_files_basenames for
--ignore-files option.

01:27 Changeset [106787] by commit-queue@webkit.org

Web Inspector: Fix CallArgument type in Inspector.json
https://bugs.webkit.org/show_bug.cgi?id=77839

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-06
Reviewed by Yury Semikhatsky.

Protocol description is fixed: field type is changed. No changes to
program code are necessary.

  • inspector/Inspector-0.1.json:
  • inspector/Inspector-1.0.json:
  • inspector/Inspector.json:
01:23 Changeset [106786] by carlosgc@webkit.org

[GTK] Fix xrefs after installing API documentation
https://bugs.webkit.org/show_bug.cgi?id=77551

Reviewed by Martin Robinson.

  • GNUmakefile.am: Call generate-gtkdoc --rebase after installing

api docs.

  • gtk/common.py:

(prefix_of_pkg_config_file): Get the prefix variable of the given
pkg-config file.
(gtk_version_of_pkg_config_file): Get the gtk version required by
the given pkg-config file.

  • gtk/generate-gtkdoc: Add --rebase command line option to rebase

installed documentation.
(get_gtkdoc_module_paths): Get paths where API doc is installed
for the dependencies of the given pkg-config file.
(get_common_xref_deps): Get API doc directories of dependencies
common to WebKit1 and WebKit2.
(get_webkit2_options): Add cross_reference_deps option.
(get_webkit1_options): Ditto
(rebase_installed_docs): Helper function to create a generator for
the given pkg-config file and options and call rebase_installed_docs.

  • gtk/gtkdoc.py:

(GTKDoc.init): Initialize cross_reference_deps.
(GTKDoc._run_gtkdoc_fixxref): Add API doc directories of
dependencies.
(GTKDoc.rebase_installed_docs): Call gtkdoc-rebase to fix xref
links of installed documentation.
(PkgConfigGTKDoc.init): Get the prefix from the pkg-config
file.

01:22 Changeset [106785] by abarth@webkit.org

Layout Test http/tests/security/xssAuditor/dom-write-innerHTML.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=67538

Reviewed by Kentaro Hara.

Try to fix the flakiness in this test by kicking off the <img> load
before the load event has fired for the inner frame. That way, the
load event for the main frame will be delayed until the image finishes
loading (and its error handler has fired), removing the need for the
setTimeout.

  • http/tests/security/xssAuditor/dom-write-innerHTML.html:
  • http/tests/security/xssAuditor/resources/echo-dom-write-innerHTML.html:
  • platform/chromium/test_expectations.txt:
01:07 Changeset [106784] by sergio@webkit.org

Incorrect statistics shown when running run-webkit-tests with --repeat-each or --iterations
https://bugs.webkit.org/show_bug.cgi?id=77672

Reviewed by Dirk Pranke.

Test repetitions must be taken into account when working out
the statistics shown by run-webkit-tests.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.prepare_lists_and_print_output):
(Manager._print_result_summary):

  • Scripts/webkitpy/layout_tests/models/result_summary.py:

(ResultSummary.init):
(ResultSummary.add):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_repeat_each_iterations_num_tests):

00:56 Changeset [106783] by barraclough@apple.com

Remove JSObject defineGetter/defineSetter lookupGetter/lookupSetter
https://bugs.webkit.org/show_bug.cgi?id=77451

Reviewed by Sam Weinig.

These can now all be implemented in terms of defineOwnProperty & getPropertyDescriptor.
Also remove initializeGetterSetterProperty, since this is equivalent to putDirectAccessor.

Source/JavaScriptCore:

(JSC::DebuggerActivation::defineOwnProperty):

  • debugger/DebuggerActivation.h:

(DebuggerActivation):

  • runtime/ClassInfo.h:

(MethodTable):
(JSC):

  • runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::finishCreation):

  • runtime/JSCell.cpp:

(JSC):

  • runtime/JSCell.h:

(JSCell):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::getOwnPropertyDescriptor):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::defineOwnProperty):
(JSC):

  • runtime/JSGlobalObject.h:

(JSGlobalObject):

  • runtime/JSObject.cpp:

(JSC):

  • runtime/JSObject.h:

(JSObject):

  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncDefineGetter):
(JSC::objectProtoFuncDefineSetter):
(JSC::objectProtoFuncLookupGetter):
(JSC::objectProtoFuncLookupSetter):

Source/WebCore:

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore):
(WebCore::JSDOMWindow::defineOwnProperty):

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore):

  • bindings/js/JSDOMWindowShell.h:

(JSDOMWindowShell):

  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::defineOwnProperty):
(WebCore::JSLocationPrototype::defineOwnProperty):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

  • page/DOMWindow.idl:
  • page/Location.idl:

Source/WebKit/qt:

  • Api/qwebframe.cpp:

(QWebFramePrivate::addQtSenderToGlobalObject):

00:51 Changeset [106782] by carlosgc@webkit.org

Source/JavaScriptCore: Unreviewed. Fix make distcheck.

  • GNUmakefile.list.am: Add missing files.

Source/WebCore: Unreviewed. Fix make distrcheck.

  • GNUmakefile.am: Fix typo in inspector json file.
  • GNUmakefile.list.am: Remove non existent file.
00:38 Changeset [106781] by pfeldman@chromium.org

Merge 106638 - Web Inspector: preserve elements panel selection upon node drag'n'drop
https://bugs.webkit.org/show_bug.cgi?id=77722

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: inspector/elements/move-node.html

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype._markRevision):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype._ondrop):
(WebInspector.ElementsTreeOutline.prototype._doMove.callback):
(WebInspector.ElementsTreeOutline.prototype._doMove):

LayoutTests:

  • inspector/elements/move-node-expected.txt: Added.
  • inspector/elements/move-node.html: Added.

TBR=pfeldman@chromium.org
BUG=112578
Review URL: https://chromiumcodereview.appspot.com/9328038

00:04 Changeset [106780] by yurys@chromium.org

2012-02-06 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Qt minimal compilation fix after r106777.

  • inspector/InspectorDatabaseAgent.h: added missing #if ENABLED guards.

02/05/12:

23:54 Changeset [106779] by loislo@chromium.org

Web Inspector: REGRESSION detached dom nodes aren't highlighted
https://bugs.webkit.org/show_bug.cgi?id=77829

This functionality was lost when I replaced (Native roots) with (Detached DOM trees) on v8 side.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.get isDetachedDOMTreesRoot):
(WebInspector.HeapSnapshot.prototype._markDetachedDOMTreeNodes):

23:52 Changeset [106778] by loislo@chromium.org

Web Inspector: get rid of artificial heap snapshot nodes from the retaining tree.
https://bugs.webkit.org/show_bug.cgi?id=77850

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotObjectNode):
(WebInspector.HeapSnapshotObjectNode.prototype.updateHasChildren):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.get isArtificial):
(WebInspector.HeapSnapshot.prototype._init):

23:39 Changeset [106777] by yurys@chromium.org

Web Inspector: CodeGeneratorInspector.py: switch domain agents to formal interfaces in BackendDispatcher
https://bugs.webkit.org/show_bug.cgi?id=77444

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-05
Reviewed by Yury Semikhatsky.

All agent code is switched to formal interfaces. Actual agent class
names and includes are dropped from InspectorBackendDispatcher.h.

  • inspector/CodeGeneratorInspector.py:

(DomainNameFixes.get_fixed_data):
(Generator.go):

  • inspector/InspectorAgent.h:
  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getMatchedStylesForNode):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::highlightNode):

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

  • inspector/InspectorDOMDebuggerAgent.h:
  • inspector/InspectorDOMStorageAgent.h:
  • inspector/InspectorDatabaseAgent.h:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::continueToLocation):

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

  • inspector/InspectorFileSystemAgent.h:
  • inspector/InspectorIndexedDBAgent.h:
  • inspector/InspectorMemoryAgent.h:
  • inspector/InspectorPageAgent.h:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::getProfile):
(WebCore::InspectorProfilerAgent::removeProfile):

  • inspector/InspectorProfilerAgent.h:

(InspectorProfilerAgent):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::setExtraHTTPHeaders):

  • inspector/InspectorResourceAgent.h:

(InspectorResourceAgent):

  • inspector/InspectorRuntimeAgent.h:
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::start):

  • inspector/InspectorTimelineAgent.h:

(InspectorTimelineAgent):

  • inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::sendMessageToWorker):

  • inspector/InspectorWorkerAgent.h:

(InspectorWorkerAgent):

23:06 Changeset [106776] by haraken@chromium.org

Rename [TreatNullAs=EmptyString] to [TreatNullAs=NullString],
[TreatUndefinedAs=EmptyString] to [TreatUndefinedAs=NullString]
https://bugs.webkit.org/show_bug.cgi?id=77611

Reviewed by Adam Barth.

While the Web IDL spec requires [TreatNullAs=EmptyString] and [TreatUndefinedAs=EmptyString],
the current WebKit treats them as (not an empty string but) a null string.
To avoid confusion, this patch renames [TreatNullAs=EmptyString] to [TreatNullAs=NullString],
and [TreatUndefinedAs=EmptyString] to [TreatUndefinedAs=NullString].
(Eventually we should fix WebKit so that it uses an empty string and then
rename them to [TreatNullAs=EmptyString] and [TreatUndefinedAs=EmptyString].)

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm: Added FIXME.

(JSValueToNative):

  • bindings/scripts/CodeGeneratorV8.pm: Ditto.

(GetNativeTypeFromSignature):

  • bindings/scripts/test/TestObj.idl:
  • css/CSSCharsetRule.idl:
  • css/CSSPageRule.idl:
  • css/CSSRule.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSStyleRule.idl:
  • css/CSSValue.idl:
  • css/MediaList.idl:
  • css/WebKitCSSKeyframesRule.idl:
  • dom/Attr.idl:
  • dom/CharacterData.idl:
  • dom/DOMImplementation.idl:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/NamedNodeMap.idl:
  • dom/Node.idl:
  • dom/ProcessingInstruction.idl:
  • dom/ShadowRoot.idl:
  • fileapi/Blob.idl:
  • fileapi/DirectoryEntry.idl:
  • fileapi/DirectoryEntrySync.idl:
  • fileapi/Entry.idl:
  • fileapi/EntrySync.idl:
  • fileapi/WebKitBlobBuilder.idl:
  • html/HTMLAnchorElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLCanvasElement.idl:
  • html/HTMLDocument.idl:
  • html/HTMLElement.idl:
  • html/HTMLFieldSetElement.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLKeygenElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLOutputElement.idl:
  • html/HTMLScriptElement.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/HTMLTitleElement.idl:
  • html/canvas/CanvasRenderingContext2D.idl:
  • page/Console.idl:
  • page/DOMWindow.idl:
  • storage/StorageEvent.idl:
  • svg/SVGAngle.idl:
  • svg/SVGElement.idl:
  • svg/SVGLength.idl:
  • svg/SVGScriptElement.idl:
22:44 Changeset [106775] by fpizlo@apple.com

DFG's child references from one node to another should have room for type information
https://bugs.webkit.org/show_bug.cgi?id=77797

Reviewed by Oliver Hunt.

The DFG::Node::child fields now contain both a DFG::NodeIndex (which is just an unsigned)
and a DFG::UseKind (which is currently an effectively empty enum). They are encapsulated
together as a DFG::NodeUse, which can in most cases still be used as an index (for
example DFG::Graph, AbstractState, and SpeculativeJIT all accept NodeUse in most places
where they really want a NodeIndex).

The NodeUse stores both the index and the UseKind without bloating the memory usage of
DFG::Node, since we really don't need full 32 bits for the NodeIndex (a DFG::Node is
roughly 11 words, so if we assume that we never want to use more than 1GB to DFG compile
something - likely a sensible assumption! - then we will only be able to have room for
about 24 million nodes, which means we only need about 24.5 bits for the node index).
Currently the DFG::NodeUse allocates 4 bits for the UseKind and 28 bits for the index,
but stores the index as a signed number to make NoNode work naturally. Hence we really
just have 27 bits for the index.

This is performance-neutral on all benchmarks we track.

(JSC::DFG::AbstractState::forNode):
(AbstractState):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::toInt32):
(JSC::DFG::ByteCodeParser::addVarArgChild):
(JSC::DFG::ByteCodeParser::processPhiStack):

  • dfg/DFGCommon.h:
  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(DFG):

  • dfg/DFGGraph.h:

(Graph):
(JSC::DFG::Graph::operator[]):
(JSC::DFG::Graph::at):
(JSC::DFG::Graph::ref):
(JSC::DFG::Graph::deref):
(JSC::DFG::Graph::clearAndDerefChild1):
(JSC::DFG::Graph::clearAndDerefChild2):
(JSC::DFG::Graph::clearAndDerefChild3):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::getPrediction):

  • dfg/DFGNode.h:

(JSC::DFG::Node::Node):
(JSC::DFG::Node::child1):
(JSC::DFG::Node::child1Unchecked):
(JSC::DFG::Node::child2):
(JSC::DFG::Node::child3):
(JSC::DFG::Node::firstChild):
(JSC::DFG::Node::numChildren):
(JSC::DFG::Node::dumpChildren):
(Node):

  • dfg/DFGNodeReferenceBlob.h: Added.

(DFG):
(NodeReferenceBlob):
(JSC::DFG::NodeReferenceBlob::NodeReferenceBlob):
(JSC::DFG::NodeReferenceBlob::child):
(JSC::DFG::NodeReferenceBlob::child1):
(JSC::DFG::NodeReferenceBlob::child2):
(JSC::DFG::NodeReferenceBlob::child3):
(JSC::DFG::NodeReferenceBlob::child1Unchecked):
(JSC::DFG::NodeReferenceBlob::initialize):
(JSC::DFG::NodeReferenceBlob::firstChild):
(JSC::DFG::NodeReferenceBlob::setFirstChild):
(JSC::DFG::NodeReferenceBlob::numChildren):
(JSC::DFG::NodeReferenceBlob::setNumChildren):

  • dfg/DFGNodeUse.h: Added.

(DFG):
(NodeUse):
(JSC::DFG::NodeUse::NodeUse):
(JSC::DFG::NodeUse::indexUnchecked):
(JSC::DFG::NodeUse::index):
(JSC::DFG::NodeUse::setIndex):
(JSC::DFG::NodeUse::useKind):
(JSC::DFG::NodeUse::setUseKind):
(JSC::DFG::NodeUse::isSet):
(JSC::DFG::NodeUse::operator!):
(JSC::DFG::NodeUse::operator==):
(JSC::DFG::NodeUse::operator!=):
(JSC::DFG::NodeUse::shift):
(JSC::DFG::NodeUse::makeWord):
(JSC::DFG::operator==):
(JSC::DFG::operator!=):

  • dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::vote):
(JSC::DFG::Propagator::toDouble):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::canonicalize):
(JSC::DFG::Propagator::startIndex):
(JSC::DFG::Propagator::globalVarLoadElimination):
(JSC::DFG::Propagator::getByValLoadElimination):
(JSC::DFG::Propagator::getByOffsetLoadElimination):
(JSC::DFG::Propagator::performSubstitution):
(JSC::DFG::Propagator::performNodeCSE):

  • dfg/DFGScoreBoard.h:

(JSC::DFG::ScoreBoard::use):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::useChildren):
(JSC::DFG::SpeculativeJIT::writeBarrier):
(JSC::DFG::SpeculativeJIT::nonSpeculativeStrictEq):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileSoftModulo):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileArithSub):
(JSC::DFG::SpeculativeJIT::compileStrictEqForConstant):
(JSC::DFG::SpeculativeJIT::compileStrictEq):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::at):
(JSC::DFG::SpeculativeJIT::canReuse):
(JSC::DFG::SpeculativeJIT::use):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
(JSC::DFG::IntegerOperand::IntegerOperand):
(JSC::DFG::DoubleOperand::DoubleOperand):
(JSC::DFG::JSValueOperand::JSValueOperand):
(JSC::DFG::StorageOperand::StorageOperand):
(JSC::DFG::SpeculateIntegerOperand::SpeculateIntegerOperand):
(JSC::DFG::SpeculateStrictInt32Operand::SpeculateStrictInt32Operand):
(JSC::DFG::SpeculateDoubleOperand::SpeculateDoubleOperand):
(JSC::DFG::SpeculateCellOperand::SpeculateCellOperand):
(JSC::DFG::SpeculateBooleanOperand::SpeculateBooleanOperand):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compileValueAdd):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileValueAdd):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

21:55 Changeset [106774] by abarth@webkit.org

xss-DENIED-from-data-url-in-foreign-domain-subframe.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=77849

Reviewed by Kentaro Hara.

This test doesn't seem to be sequenced correctly w.r.t. the load events
of the various frames involved. This patch re-orders some of the
triggers in the hopes of making the test no longer flaky.

  • http/tests/security/dataURL/resources/foreign-domain-data-url-accessor-iframe.html:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe.html:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
  • platform/chromium/test_expectations.txt:
20:47 Changeset [106773] by haraken@chromium.org

Rename [JSCCustom*] IDL to [JSCustom*] IDL
https://bugs.webkit.org/show_bug.cgi?id=77844

Reviewed by Adam Barth.

Most existing JSC-specific IDLs have "JS" prefix. We can rename [JSCCustom] to
[JSCustom], [JSCCustomGetter] to [JSCustomGetter], and [JSCCustomSetter] to
[JSCustomSetter].

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • css/CSSStyleDeclaration.idl:
  • html/HTMLDocument.idl:
  • html/canvas/DataView.idl:
  • page/DOMWindow.idl:
  • page/MemoryInfo.idl:
  • webaudio/ConvolverNode.idl:
  • webaudio/DOMWindowWebAudio.idl:
  • webaudio/WaveShaperNode.idl:
  • websockets/DOMWindowWebSocket.idl:
  • workers/WorkerContext.idl:
20:01 Changeset [106772] by commit-queue@webkit.org

[EFL] Enable WebGL with glx backend
https://bugs.webkit.org/show_bug.cgi?id=77308

Patch by ChangSeok Oh <shivamidow@gmail.com> on 2012-02-05
Reviewed by Martin Robinson.

.:

Enabled WebGL feature for EFL port. The way is very similar to the one of GTK port.

  • Source/cmake/OptionsEfl.cmake: Added feature option for WebGL.

Source/WebCore:

Implemented WebGL feature for EFL port. The way is very similar to the one of GTK port.

No new tests required. We can verify this feature with the existing test cases.

  • CMakeLists.txt: Revised common files required for WebGL.
  • PlatformEfl.cmake: Added EFL specific files.
  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::getContext):

  • platform/graphics/ANGLEWebKitBridge.h:
  • platform/graphics/GraphicsContext3D.h:

(WebCore):
(WebCore::GraphicsContext3D::platformTexture):
(GraphicsContext3D):
(WebCore::GraphicsContext3D::paintsIntoCanvasBuffer):

  • platform/graphics/efl/DrawingBufferEfl.cpp: Copied from GTK port.

(WebCore):
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::~DrawingBuffer):
(WebCore::DrawingBuffer::platformColorBuffer):
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):

  • platform/graphics/efl/GraphicsContext3DEfl.cpp: Almost same with GraphicsContext3DGtk.cpp.

(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
(WebCore::GraphicsContext3D::isGLES2Compliant):

  • platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::createVertexArrayOES):
(WebCore::Extensions3DOpenGL::deleteVertexArrayOES):
(WebCore::Extensions3DOpenGL::isVertexArrayOES):
(WebCore::Extensions3DOpenGL::bindVertexArrayOES):

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

Source/WebKit/efl:

Activated WebGL feature.

  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):

19:53 Changeset [106771] by inferno@chromium.org

Crash in FormSubmission::create.
https://bugs.webkit.org/show_bug.cgi?id=77813

Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/forms/form-submission-create-crash.xhtml

  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):

LayoutTests:

  • fast/forms/form-submission-create-crash-expected.txt: Added.
  • fast/forms/form-submission-create-crash.xhtml: Added.
18:25 Changeset [106770] by kling@webkit.org

Remove unused file MappedAttributeEntry.h.
<http://webkit.org/b/77841>

Reviewed by Anders Carlsson.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/MappedAttributeEntry.h: Removed.
  • dom/StyledElement.h:
18:21 Changeset [106769] by kling@webkit.org

StyledElement: Rename parseMappedAttribute() to parseAttribute().
<http://webkit.org/b/77830>

Reviewed by Anders Carlsson.

Rename across the board and decorate subclasses with OVERRIDE.

18:06 Changeset [106768] by kov@webkit.org

Unreviewed syntax fix.

  • English.lproj/localizedStrings.js:
17:33 Changeset [106767] by kling@webkit.org

Swedish buildfix.

  • dom/Document.cpp:

(WebCore::wheelEventHandlerCountChanged):

16:43 Changeset [106766] by andersca@apple.com

The scrolling tree should be aware of any wheel event handlers on the page
https://bugs.webkit.org/show_bug.cgi?id=77840

Reviewed by Andreas Kling.

If there are wheel event handlers on the page, any wheel events must be redispatched
to the main thread so they can go through the DOM event handling.

  • dom/Document.cpp:

(WebCore::wheelEventHandlerCountChanged):
Inform the scrolling coordinator that the wheel event count changed.

(WebCore::Document::didAddWheelEventHandler):
(WebCore::Document::didRemoveWheelEventHandler):
Call wheelEventHandlerCountChanged.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::frameViewWheelEventHandlerCountChanged):
Call recomputeWheelEventHandlerCount.

(WebCore::ScrollingCoordinator::recomputeWheelEventHandlerCount):
Update the scrolling tree state.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::ScrollingTree):
Initialize m_hasWheelEventHandlers to false.

(WebCore::ScrollingTree::tryToHandleWheelEvent):
If m_hasWheelEventHandlers is true, bail.

(WebCore::ScrollingTree::commitNewTreeState):
Update m_hasWheelEventHandlers.

  • page/scrolling/ScrollingTreeState.cpp:

(WebCore::ScrollingTreeState::ScrollingTreeState):
(WebCore::ScrollingTreeState::setWheelEventHandlerCount):
Add getter and setter for the wheel event handler count.

14:27 Changeset [106765] by abarth@webkit.org

Rebaseline xss-inactive-closure.html. This test "fails" because of a
subtle difference in how V8 and JSC do security checks. Essentially,
V8 does security checks based on the current ScriptExecutionContext
whereas JSC does security checks based on the current DOMWindow. I'm
working on fixing these differences in bugs like
https://bugs.webkit.org/show_bug.cgi?id=75793, but it's a long road.

In any case, the behavior indicated by this test is fine from a
security point of view, so it's better to rebaseline this test because
that will let us detect future regressions.

  • platform/chromium/http/tests/security/listener/xss-inactive-closure-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
14:16 Changeset [106764] by abarth@webkit.org

Rebaseline xss-DENIED-defineProperty. These V8-specific results appear
to also be passing, just with slightly fewer console messages.

  • platform/chromium/http/tests/security/xss-DENIED-defineProperty-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
14:02 Changeset [106763] by abarth@webkit.org

Further cleanup of failing and flaky security LayoutTests. This patch
updates the expectations to match the behavior as described by the
flakiness dashboard.

  • platform/chromium/test_expectations.txt:
13:54 Changeset [106762] by abarth@webkit.org

This test is no longer flaky. It appears to pass all the time.

  • platform/chromium/test_expectations.txt:
10:51 Changeset [106761] by mitz@apple.com

<rdar://problem/10809525> WebKit2’s WebFrameLoaderClient::shouldUseCredentialStorage() always returns true
https://bugs.webkit.org/show_bug.cgi?id=77823

Reviewed by Anders Carlsson.

Source/WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.cpp:

(WebKit::InjectedBundlePageResourceLoadClient::shouldUseCredentialStorage): Added. Calls
through to the client if it implements shouldUseCredentialStorage. Returns true otherwise.

  • WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::shouldUseCredentialStorage): Changed to call the injected
bundle resource load client.

Tools:

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.

06:02 Changeset [106760] by gyuyoung.kim@samsung.com

[EFL] Remove g_thread_init() calls
https://bugs.webkit.org/show_bug.cgi?id=77828

Reviewed by Andreas Kling.

g_thread_init has been deprecated since glib 2.32. This function is no longer necessary.
The GLib threading system is automatically initialized at the start of your program.

  • ewk/ewk_main.cpp:

(_ewk_init_body):

01:36 Changeset [106759] by gyuyoung.kim@samsung.com

[CMAKE] Support javascriptcore test for EFL port.
https://bugs.webkit.org/show_bug.cgi?id=77425

Reviewed by Daniel Bates.

Efl and WinCE as well as Blackberry port are now using Cmake as its build system
and they are share the make file to create jsc excutable. In order to run
"run-javascriptcore-tests", EFL port needs to change jsc installation configuration
with executable output directory(e.g. Programs). So, this patch change jsc installation
configuration only for EFL port.

.:

  • Source/cmake/OptionsEfl.cmake: Change *jsc_efl* name with *jsc*.

Source/JavaScriptCore:

  • shell/CMakeLists.txt:
01:27 Changeset [106758] by gyuyoung.kim@samsung.com

[CMAKE] Do not build Tools when building jsc only.
https://bugs.webkit.org/show_bug.cgi?id=77826

Reviewed by Daniel Bates.

Do not build Tools when jsc is only built. Build breaks occur because
Tools is built together when building jsc.

  • CMakeLists.txt: Build Tools directory when ENABLE_TOOLS is on.
01:26 Changeset [106757] by kling@webkit.org

Remove mapped vs non-mapped attribute distinction.
<http://webkit.org/b/77827>

Reviewed by Antti Koivisto.

Removed the isMappedAttribute flag from Attribute as it no longer serves
a practical purpose. Previously, StyledElement would generate mapped
attributes and plain Element would generate non-mapped ones.

The distinction is now made much more clearly by dividing the work between
Element's and StyledElement's attributeChanged() methods. The only thing
that StyledElement wants to do in addition to what Element does is
calling parseMappedAttribute() (which we'll rename in a later patch.)

  • dom/Attribute.cpp:

(WebCore::Attribute::clone):

  • dom/Attribute.h:

(WebCore::Attribute::create):
(WebCore::Attribute::Attribute):
(Attribute):

  • dom/Document.cpp:

(WebCore::Document::createAttributeNS):

  • dom/Element.cpp:

(WebCore::Element::attributeChanged):

  • dom/Element.h:

(Element):

  • dom/Node.cpp:

(WebCore::Node::dumpStatistics):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::parseMappedAttribute):

  • dom/StyledElement.h:

(StyledElement):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::attributesForIsindexInput):

  • html/parser/TextDocumentParser.cpp:

(WebCore::TextDocumentParser::insertFakePreElement):

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::getPresentationAttribute):

  • xml/parser/MarkupTokenBase.h:

(WebCore::::initializeAttributes):

00:29 Changeset [106756] by kling@webkit.org

Kill CSSMappedAttributeDeclaration.
<http://webkit.org/b/77820>

Reviewed by Antti Koivisto.

Replace all use of CSSMappedAttributeDeclaration by StylePropertySet.
Moved the setNeedsStyleRecalc() calls from CSSMappedAttributeDeclaration
to the add/remove-CSS-property helpers in StyledElement.

This removes one step of indirection for attribute styles and reduces
the size of elements that have presentational attributes by one pointer.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/CSSMappedAttributeDeclaration.cpp: Removed.
  • dom/CSSMappedAttributeDeclaration.h: Removed.
  • dom/DOMAllInOne.cpp:

Remove CSSMappedAttributeDeclaration.{cpp,h}

  • css/CSSParser.h:
  • css/CSSParser.cpp:

(WebCore::parseSimpleLengthValue):

Remove CSSParser::parseMappedAttributeValue(), we now use parseValue()
directly instead. We lose the benefit of caching new CSSValues in the
document's CSSValuePool but this optimization can be added back later.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::matchAllRules):

  • dom/ElementAttributeData.h:

(ElementAttributeData):

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::ensureAttributeStyle):

  • dom/NamedNodeMap.h:

(WebCore::NamedNodeMap::attributeStyle):
(NamedNodeMap):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::removeCSSProperties):
(WebCore::StyledElement::addCSSProperty):
(WebCore::StyledElement::addCSSImageProperty):
(WebCore::StyledElement::addCSSLength):
(WebCore::StyledElement::addCSSColor):

  • dom/StyledElement.h:

(WebCore):
(WebCore::StyledElement::attributeStyle):
(WebCore::StyledElement::ensureAttributeStyle):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::buildArrayForAttributeStyles):

00:27 Changeset [106755] by loislo@chromium.org

Web Inspector: beautify retaining tree items view.
https://bugs.webkit.org/show_bug.cgi?id=77810

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotGenericObjectNode.prototype._createObjectCell):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):

  • inspector/front-end/heapProfiler.css:

(.cycled-ancessor-node):

  • inspector/front-end/profilesPanel.css:
Note: See TracTimeline for information about the timeline view.