Timeline


and

02/22/12:

23:36 Changeset [108617] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Skipped a test that uses Chromium-only LayoutTestController functionality.

Rubber-stamped by Joseph Pecoraro.

  • platform/mac/Skipped: Added fast/dom/title-directionality-removeChild.html.
23:36 Changeset [108616] by igor.o@sisa.samsung.com
  • 3 edits in trunk/Source/WebCore

Every call to RenderObject::setAnimatableStyle() iterates through all m_compositeAnimations: potentially O(N2)
https://bugs.webkit.org/show_bug.cgi?id=38025

This patchs implements updateAnimationTimerForRenderer, it just checks the timeToNextService for
the current RenderObject reducing the amount of iterations.

Reviewed by Simon Fraser.

  • page/animation/AnimationController.cpp:

(WebCore):
(WebCore::AnimationControllerPrivate::updateAnimationTimerForRenderer):
(WebCore::AnimationController::updateAnimations):

  • page/animation/AnimationControllerPrivate.h:

(AnimationControllerPrivate):

23:29 Changeset [108615] by commit-queue@webkit.org
  • 13 edits in trunk/Source

NOTIFICATIONS should be implemented as PageSupplement
https://bugs.webkit.org/show_bug.cgi?id=79052

Patch by Hajime Morrita <morrita@chromium.org> on 2012-02-22
Reviewed by Adam Barth.

Source/WebCore:

Turned NotificationController to a PageSupplement.

No new tests. No behavior change.

  • notifications/NotificationController.cpp:

(WebCore::NotificationController::clientFrom):
(WebCore):
(WebCore::NotificationController::supplementName):
(WebCore::provideNotification):

  • notifications/NotificationController.h:

(NotificationController):
(WebCore::NotificationController::from):

  • notifications/NotificationPresenter.h:

(WebCore):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::webkitNotifications):

  • page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::PageClients::PageClients):

  • page/Page.h:

(WebCore):
(PageClients):
(Page):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):

23:22 Changeset [108614] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit2

[Qt][WK2] navigationType is missing in new API
https://bugs.webkit.org/show_bug.cgi?id=78867

Patch by Michael Tyutyunik <michael.tyutyunik@nokia.com> on 2012-02-22
Reviewed by Simon Hausmann.

In QtWebPagePolicyClient::decidePolicyForNavigationAction()
navigationType argument is dropped by mistake. Adding it back
and make it available through NavigationRequest.

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qwebnavigationrequest.cpp:

(QWebNavigationRequestPrivate::QWebNavigationRequestPrivate):
(QWebNavigationRequestPrivate):
(QWebNavigationRequest::QWebNavigationRequest):
(QWebNavigationRequest::navigationType):

  • UIProcess/API/qt/qwebnavigationrequest_p.h:
  • UIProcess/qt/QtWebPagePolicyClient.cpp:

(QtWebPagePolicyClient::decidePolicyForNavigationAction):
(toQuickWebViewNavigationType):

  • UIProcess/qt/QtWebPagePolicyClient.h:

(QtWebPagePolicyClient):

23:04 Changeset [108613] by dslomov@google.com
  • 3 edits
    1 delete in trunk

[Chromium][V8] Support Uint8ClampedArray in postMessage
https://bugs.webkit.org/show_bug.cgi?id=79291.

Reviewed by Kenneth Russell.

Source/WebCore:

Covered by existing tests.

  • bindings/v8/SerializedScriptValue.cpp:

LayoutTests:

  • platform/chromium/fast/canvas/webgl/array-message-passing-expected.txt: Removed.
22:50 Changeset [108612] by tkent@chromium.org
  • 1 edit
    34 moves in trunk/LayoutTests

Move <input type=radio> tests to fast/forms/radio/
https://bugs.webkit.org/show_bug.cgi?id=78678

Reviewed by Kentaro Hara.

  • fast/forms/ValidityState-valueMissing-radio-expected.txt: Removed.
  • fast/forms/ValidityState-valueMissing-radio.html: Removed.
  • fast/forms/indeterminate-radio-expected.txt: Removed.
  • fast/forms/indeterminate-radio.html: Removed.
  • fast/forms/input-radio-checked-tab-expected.txt: Removed.
  • fast/forms/input-radio-checked-tab.html: Removed.
  • fast/forms/interactive-validation-required-radio-expected.txt: Removed.
  • fast/forms/interactive-validation-required-radio.html: Removed.
  • fast/forms/radio-attr-order-expected.txt: Removed.
  • fast/forms/radio-attr-order.html: Removed.
  • fast/forms/radio-button-no-change-event-expected.txt: Removed.
  • fast/forms/radio-button-no-change-event.html: Removed.
  • fast/forms/radio-check-click-and-drag-expected.txt: Removed.
  • fast/forms/radio-check-click-and-drag.html: Removed.
  • fast/forms/radio-default-value-expected.txt: Removed.
  • fast/forms/radio-default-value.html: Removed.
  • fast/forms/radio-group-keyboard-change-event-expected.txt: Removed.
  • fast/forms/radio-group-keyboard-change-event.html: Removed.
  • fast/forms/radio-nested-labels-expected.txt: Removed.
  • fast/forms/radio-nested-labels.html: Removed.
  • fast/forms/radio-no-theme-padding-expected.txt: Removed.
  • fast/forms/radio-no-theme-padding.html: Removed.
  • fast/forms/radio-remove-form-attr-expected.txt: Removed.
  • fast/forms/radio-remove-form-attr.html: Removed.
  • fast/forms/radio/ValidityState-valueMissing-radio-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-valueMissing-radio-expected.txt.
  • fast/forms/radio/ValidityState-valueMissing-radio.html: Copied from LayoutTests/fast/forms/ValidityState-valueMissing-radio.html.
  • fast/forms/radio/indeterminate-radio-expected.txt: Copied from LayoutTests/fast/forms/indeterminate-radio-expected.txt.
  • fast/forms/radio/indeterminate-radio.html: Copied from LayoutTests/fast/forms/indeterminate-radio.html.
  • fast/forms/radio/input-radio-checked-tab-expected.txt: Copied from LayoutTests/fast/forms/input-radio-checked-tab-expected.txt.
  • fast/forms/radio/input-radio-checked-tab.html: Copied from LayoutTests/fast/forms/input-radio-checked-tab.html.
  • fast/forms/radio/interactive-validation-required-radio-expected.txt: Copied from LayoutTests/fast/forms/interactive-validation-required-radio-expected.txt.
  • fast/forms/radio/interactive-validation-required-radio.html: Copied from LayoutTests/fast/forms/interactive-validation-required-radio.html.
  • fast/forms/radio/radio-attr-order-expected.txt: Copied from LayoutTests/fast/forms/radio-attr-order-expected.txt.
  • fast/forms/radio/radio-attr-order.html: Copied from LayoutTests/fast/forms/radio-attr-order.html.
  • fast/forms/radio/radio-button-no-change-event-expected.txt: Copied from LayoutTests/fast/forms/radio-button-no-change-event-expected.txt.
  • fast/forms/radio/radio-button-no-change-event.html: Copied from LayoutTests/fast/forms/radio-button-no-change-event.html.
  • fast/forms/radio/radio-check-click-and-drag-expected.txt: Copied from LayoutTests/fast/forms/radio-check-click-and-drag-expected.txt.
  • fast/forms/radio/radio-check-click-and-drag.html: Copied from LayoutTests/fast/forms/radio-check-click-and-drag.html.
  • fast/forms/radio/radio-default-value-expected.txt: Copied from LayoutTests/fast/forms/radio-default-value-expected.txt.
  • fast/forms/radio/radio-default-value.html: Copied from LayoutTests/fast/forms/radio-default-value.html.
  • fast/forms/radio/radio-group-keyboard-change-event-expected.txt: Copied from LayoutTests/fast/forms/radio-group-keyboard-change-event-expected.txt.
  • fast/forms/radio/radio-group-keyboard-change-event.html: Copied from LayoutTests/fast/forms/radio-group-keyboard-change-event.html.
  • fast/forms/radio/radio-nested-labels-expected.txt: Copied from LayoutTests/fast/forms/radio-nested-labels-expected.txt.
  • fast/forms/radio/radio-nested-labels.html: Copied from LayoutTests/fast/forms/radio-nested-labels.html.
  • fast/forms/radio/radio-no-theme-padding-expected.txt: Copied from LayoutTests/fast/forms/radio-no-theme-padding-expected.txt.
  • fast/forms/radio/radio-no-theme-padding.html: Copied from LayoutTests/fast/forms/radio-no-theme-padding.html.
  • fast/forms/radio/radio-remove-form-attr-expected.txt: Copied from LayoutTests/fast/forms/radio-remove-form-attr-expected.txt.
  • fast/forms/radio/radio-remove-form-attr.html: Copied from LayoutTests/fast/forms/radio-remove-form-attr.html.
  • fast/forms/radio/radio_checked-expected.txt: Copied from LayoutTests/fast/forms/radio_checked-expected.txt.
  • fast/forms/radio/radio_checked.html: Copied from LayoutTests/fast/forms/radio_checked.html.
  • fast/forms/radio/radio_checked_dynamic-expected.txt: Copied from LayoutTests/fast/forms/radio_checked_dynamic-expected.txt.
  • fast/forms/radio/radio_checked_dynamic.html: Copied from LayoutTests/fast/forms/radio_checked_dynamic.html.
  • fast/forms/radio/radio_checked_name-expected.txt: Copied from LayoutTests/fast/forms/radio_checked_name-expected.txt.
  • fast/forms/radio/radio_checked_name.html: Copied from LayoutTests/fast/forms/radio_checked_name.html.
  • fast/forms/radio/remove-radio-button-assert-expected.txt: Copied from LayoutTests/fast/forms/remove-radio-button-assert-expected.txt.
  • fast/forms/radio/remove-radio-button-assert.html: Copied from LayoutTests/fast/forms/remove-radio-button-assert.html.
  • fast/forms/radio/state-restore-radio-group-expected.txt: Copied from LayoutTests/fast/forms/state-restore-radio-group-expected.txt.
  • fast/forms/radio/state-restore-radio-group.html: Copied from LayoutTests/fast/forms/state-restore-radio-group.html.
  • fast/forms/radio_checked-expected.txt: Removed.
  • fast/forms/radio_checked.html: Removed.
  • fast/forms/radio_checked_dynamic-expected.txt: Removed.
  • fast/forms/radio_checked_dynamic.html: Removed.
  • fast/forms/radio_checked_name-expected.txt: Removed.
  • fast/forms/radio_checked_name.html: Removed.
  • fast/forms/remove-radio-button-assert-expected.txt: Removed.
  • fast/forms/remove-radio-button-assert.html: Removed.
  • fast/forms/state-restore-radio-group-expected.txt: Removed.
  • fast/forms/state-restore-radio-group.html: Removed.
22:40 Changeset [108611] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Updated expected test results for the addition of -webkit-line-align (r108133) and the
renaming of -webkit-line-grid-snap (r107289).

Rubber-stamped by Andy Estes.

  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
22:26 Changeset [108610] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Enable Geolocation bindings for GObject
https://bugs.webkit.org/show_bug.cgi?id=79293

Reviewed by Adam Barth.

This patch adds "WebCore::" to supplemental method calls.
This will solve the GTK build failure we have observed in the Geolocation API,
and thus this patch enables the Geolocation API.

  • Modules/geolocation/NavigatorGeolocation.idl:
  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateProperty):
(GenerateFunction):

22:13 Changeset [108609] by bashi@chromium.org
  • 2 edits in trunk/LayoutTests

REGRESSION (r107516): fast/css/font-face-default-font.html is failing
https://bugs.webkit.org/show_bug.cgi?id=79260

Add @font-face with "font-style: italic;" so that affecting the rule
for italic text.

Reviewed by Dan Bernstein.

  • fast/css/font-face-default-font.html:
21:58 Changeset [108608] by morrita@google.com
  • 3 edits in trunk/Source/WebCore

[Refactoring] Align supplementName() values.
https://bugs.webkit.org/show_bug.cgi?id=79311

Reviewed by Adam Barth.

No new tests. No behavioral change.

  • dom/DeviceOrientationController.cpp:

(WebCore::DeviceOrientationController::supplementName):

  • mediastream/UserMediaController.cpp:

(WebCore::UserMediaController::supplementName):

21:46 Changeset [108607] by yutak@chromium.org
  • 51 edits
    2 deletes in trunk

Unreviewed, rolling out r108602.
http://trac.webkit.org/changeset/108602
https://bugs.webkit.org/show_bug.cgi?id=78878

Caused a couple of layout test failures on Chromium bots.

Source/WebCore:

  • dom/Element.cpp:

(WebCore::Element::childShouldCreateRenderer):

  • dom/Element.h:

(Element):

  • dom/Node.h:

(WebCore::Node::childShouldCreateRenderer):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::shouldCreateRenderer):

  • dom/NodeRenderingContext.h:

(NodeRenderingContext):

  • html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::childShouldCreateRenderer):

  • html/HTMLDetailsElement.h:

(HTMLDetailsElement):

  • html/HTMLMediaElement.cpp:

(WebCore):

  • html/HTMLMediaElement.h:

(HTMLMediaElement):

  • html/HTMLMeterElement.cpp:
  • html/HTMLMeterElement.h:

(HTMLMeterElement):

  • html/HTMLProgressElement.cpp:
  • html/HTMLProgressElement.h:

(HTMLProgressElement):

  • html/HTMLSelectElement.cpp:
  • html/HTMLSelectElement.h:

(HTMLSelectElement):

  • html/HTMLSummaryElement.cpp:
  • html/HTMLSummaryElement.h:

(HTMLSummaryElement):

  • html/HTMLTextFormControlElement.cpp:
  • html/HTMLTextFormControlElement.h:

(HTMLTextFormControlElement):

  • rendering/RenderButton.cpp:

(WebCore::RenderButton::canHaveChildren):
(WebCore):

  • rendering/RenderButton.h:

(RenderButton):

  • rendering/RenderListBox.h:

(WebCore::RenderListBox::canHaveChildren):
(RenderListBox):

  • rendering/RenderMedia.h:
  • rendering/RenderMenuList.h:

(WebCore::RenderMenuList::canHaveChildren):

  • rendering/RenderMeter.h:

(WebCore::RenderMeter::canHaveChildren):

  • rendering/RenderProgress.h:

(WebCore::RenderProgress::canHaveChildren):

  • rendering/RenderTextControl.h:

(WebCore::RenderTextControl::canHaveChildren):

  • rendering/svg/RenderSVGRoot.h:

(WebCore::RenderSVGRoot::canHaveChildren):

  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::childShouldCreateRenderer):

  • svg/SVGAElement.h:

(SVGAElement):

  • svg/SVGAltGlyphElement.cpp:

(WebCore::SVGAltGlyphElement::childShouldCreateRenderer):

  • svg/SVGAltGlyphElement.h:

(SVGAltGlyphElement):

  • svg/SVGDocument.cpp:

(WebCore::SVGDocument::childShouldCreateRenderer):

  • svg/SVGDocument.h:

(SVGDocument):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::childShouldCreateRenderer):

  • svg/SVGElement.h:

(SVGElement):

  • svg/SVGForeignObjectElement.cpp:

(WebCore::SVGForeignObjectElement::childShouldCreateRenderer):

  • svg/SVGForeignObjectElement.h:

(SVGForeignObjectElement):

  • svg/SVGSwitchElement.cpp:

(WebCore::SVGSwitchElement::childShouldCreateRenderer):

  • svg/SVGSwitchElement.h:

(SVGSwitchElement):

  • svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::childShouldCreateRenderer):

  • svg/SVGTRefElement.h:

(SVGTRefElement):

  • svg/SVGTSpanElement.cpp:

(WebCore::SVGTSpanElement::childShouldCreateRenderer):

  • svg/SVGTSpanElement.h:

(SVGTSpanElement):

  • svg/SVGTextElement.cpp:

(WebCore::SVGTextElement::childShouldCreateRenderer):

  • svg/SVGTextElement.h:

(SVGTextElement):

  • svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::childShouldCreateRenderer):

  • svg/SVGTextPathElement.h:

LayoutTests:

  • fast/dom/shadow/shadow-on-image-expected.html: Removed.
  • fast/dom/shadow/shadow-on-image.html: Removed.
  • platform/chromium/test_expectations.txt:
21:36 Changeset [108606] by inferno@chromium.org
  • 4 edits
    6 adds in trunk

Crash in RenderBlock::addChildIgnoringAnonymousColumnBlocks.
https://bugs.webkit.org/show_bug.cgi?id=79043

Reviewed by Julien Chaffraix.

Source/WebCore:

Tests: fast/runin/runin-div-before-child.html

fast/runin/runin-table-before-child.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks): handle
the case of run-in elements and strengthen code to handle cases where
beforeChild is incorrectly set.

  • rendering/RenderObject.h: remove anonymousContainer function since

the new logic in RenderBlock does not need it.

LayoutTests:

  • fast/runin/runin-div-before-child-expected.png: Added.
  • fast/runin/runin-div-before-child-expected.txt: Added.
  • fast/runin/runin-div-before-child.html: Added.
  • fast/runin/runin-table-before-child-expected.png: Added.
  • fast/runin/runin-table-before-child-expected.txt: Added.
  • fast/runin/runin-table-before-child.html: Added.
21:14 Changeset [108605] by hayato@chromium.org
  • 10 edits in trunk/Source/WebCore

Make ShadowRootList manage a node distribution.
https://bugs.webkit.org/show_bug.cgi?id=79008

Reviewed by Dimitri Glazkov.

The result of node distributions is currently stored in
ShadowRoot. To support multiple ShadowRoots, such node distribution
information should be managed in one place per shadow host. Now
ShadowRootList takes this responsibility on behalf of owing
multiple ShadowRoots. Clients should ask ShadowRootList for such
information, not for each ShadowRoot.

No tests. No change in behavior.

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::create):
(WebCore::ShadowRoot::attach):

  • dom/ShadowRoot.h:

(ShadowRoot):

  • dom/ShadowRootList.cpp:

(WebCore::ShadowRootList::insertionPointFor):
(WebCore):
(WebCore::ShadowRootList::isSelectorActive):
(WebCore::ShadowRootList::ensureSelector):

  • dom/ShadowRootList.h:

(WebCore):
(ShadowRootList):
(WebCore::ShadowRootList::hasShadowRoot):
(WebCore::ShadowRootList::youngestShadowRoot):
(WebCore::ShadowRootList::oldestShadowRoot):
(WebCore::ShadowRootList::selector):
(WebCore::ShadowRootList::host):

  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::attach):
(WebCore::HTMLContentElement::detach):

  • html/shadow/HTMLContentSelector.cpp:

(WebCore::HTMLContentSelector::willSelectOver):

  • html/shadow/HTMLContentSelector.h:

(HTMLContentSelector):

20:51 Changeset [108604] by commit-queue@webkit.org
  • 4 edits
    7 adds in trunk

Add multi channels support in AudioBus and AudioBufferSourceNode
https://bugs.webkit.org/show_bug.cgi?id=79017

Patch by Wei James <james.wei@intel.com> on 2012-02-22
Reviewed by Chris Rogers.

Source/WebCore:

Tests: webaudio/up-mixing-mono-51.html

webaudio/up-mixing-mono-stereo.html
webaudio/up-mixing-stereo-51.html

  • platform/audio/AudioBus.cpp:

(WebCore::AudioBus::copyFrom):
(WebCore::AudioBus::sumFrom):
(WebCore::AudioBus::processWithGainFromMonoStereo):
(WebCore::AudioBus::processWithGainFrom):

LayoutTests:

  • webaudio/resources/audio-testing.js:

(writeAudioBuffer):

  • webaudio/resources/mix-testing.js: Added.

(createToneBuffer):

  • webaudio/up-mixing-mono-51-expected.wav: Added.
  • webaudio/up-mixing-mono-51.html: Added.
  • webaudio/up-mixing-mono-stereo-expected.wav: Added.
  • webaudio/up-mixing-mono-stereo.html: Added.
  • webaudio/up-mixing-stereo-51-expected.wav: Added.
  • webaudio/up-mixing-stereo-51.html: Added.
20:24 Changeset [108603] by haraken@chromium.org
  • 9 edits in trunk/Source/WebCore

[Supplemental] should support constants
https://bugs.webkit.org/show_bug.cgi?id=79303

Reviewed by Adam Barth.

Given that we have

interface [Supplemental=Y] X { constant int A = 123; }

then the code generator should generate

X::A

to refer to the constant. However, the current code generator generates Y::A instead.
This patch fixes it.

Test: bindings/scripts/test/TestSupplemental.idl

  • bindings/scripts/CodeGenerator.pm: Modified as described above.

(GenerateCompileTimeCheckForEnumsIfNeeded):

  • bindings/scripts/test/JS/JSTestInterface.cpp: Updated run-bindings-tests results.

(WebCore):

  • bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.

(WebCore):

  • page/DOMWindow.h: Moved DOMWindow::FileSystemType to DOMWindowFileSystem::FileSystemType.

(DOMWindow):

  • fileapi/DOMWindowFileSystem.h: Ditto.

(DOMWindowFileSystem):

  • fileapi/DOMWindowFileSystem.cpp: Ditto.

(WebCore):

20:01 Changeset [108602] by morrita@google.com
  • 51 edits
    2 adds in trunk

Adding a ShadowRoot to image-backed element causes a crash
https://bugs.webkit.org/show_bug.cgi?id=78878

Reviewed by Dimitri Glazkov.

Source/WebCore:

The crash happened because NodeRenderingContext tried to append a
child to a renderer regardless one isn't capable of holding any
children if it appears in the shadow attaching phase. RenderImage
is one of such renderer classes which aren't capable.

NodeRenderingContext decide whether the contextual node as a child
can create its renderer based on RenderObject::canHaveChildren()
and Node::childShouldCreateRenderer(). But the responsibility
between these two methods are getting confused. which results this
unfortuante crash path.

This change re-aligns the responsibility:

  • Now canHaveChildren() purely declares the ability of the renderer. If the renderer is capable of having children, it return true regardless of HTML semantics.
  • On the other hand, childShouldCreateRenderer() cares about the semantics. If the element doesn't allow children to be rendered, this returns false.
  • Note that these decision on elements are contextual. Each element needs to know which role it is playing in the tree composition algorithm of Shadow DOM. That's why the method parameter is changed from Node* to NodeRenderingContext.

With this change, some decision points are moved from a renderer to an
element. Following renderers no longer stop reject having children:

  • RenderButton, RenderListBox, RenderMenuList, RenderMeter, RenderProgress, RenderTextControl.

Corresponding element for such a render (HTMLProgressElement of
RenderProgress for exaple) now cares about that.

Tests: fast/dom/shadow/shadow-on-image-expected.html
fast/dom/shadow/shadow-on-image.html

  • dom/Element.cpp:

(WebCore::Element::childShouldCreateRenderer):

  • dom/Element.h:

(Element):

  • dom/Node.h:
  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::shouldCreateRenderer):

  • dom/NodeRenderingContext.h:

(NodeRenderingContext):
(WebCore::NodeRenderingContext::isOnEncapsulationBoundary):
(WebCore):

  • html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::childShouldCreateRenderer):

  • html/HTMLDetailsElement.h:

(HTMLDetailsElement):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::childShouldCreateRenderer):
(WebCore):

  • html/HTMLMeterElement.h:

(HTMLMeterElement):

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::childShouldCreateRenderer):

  • html/HTMLMediaElement.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::childShouldCreateRenderer):
(WebCore):

  • html/HTMLProgressElement.h:

(HTMLProgressElement):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::childShouldCreateRenderer):
(WebCore):

  • html/HTMLSelectElement.h:

(HTMLSelectElement):

  • html/HTMLSummaryElement.cpp:
  • html/HTMLSummaryElement.h:

(HTMLSummaryElement):

  • html/HTMLTextFormControlElement.cpp:
  • html/HTMLTextFormControlElement.h:

(HTMLTextFormControlElement):

  • rendering/RenderButton.cpp:
  • rendering/RenderButton.h:

(RenderButton):

  • rendering/RenderListBox.h:

(RenderListBox):

  • rendering/RenderMedia.h:

(WebCore::RenderMedia::canHaveChildren):

  • rendering/RenderMenuList.h:
  • rendering/RenderMeter.h:
  • rendering/RenderProgress.h:
  • rendering/RenderTextControl.h:
  • rendering/svg/RenderSVGRoot.h:
  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::childShouldCreateRenderer):

  • svg/SVGAElement.h:

(SVGAElement):

  • svg/SVGAltGlyphElement.cpp:

(WebCore::SVGAltGlyphElement::childShouldCreateRenderer):

  • svg/SVGAltGlyphElement.h:

(SVGAltGlyphElement):

  • svg/SVGDocument.cpp:

(WebCore::SVGDocument::childShouldCreateRenderer):

  • svg/SVGDocument.h:

(SVGDocument):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::childShouldCreateRenderer):

  • svg/SVGElement.h:

(SVGElement):

  • svg/SVGForeignObjectElement.cpp:

(WebCore::SVGForeignObjectElement::childShouldCreateRenderer):

  • svg/SVGForeignObjectElement.h:

(SVGForeignObjectElement):

  • svg/SVGSwitchElement.cpp:

(WebCore::SVGSwitchElement::childShouldCreateRenderer):

  • svg/SVGSwitchElement.h:

(SVGSwitchElement):

  • svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::childShouldCreateRenderer):

  • svg/SVGTRefElement.h:

(SVGTRefElement):

  • svg/SVGTSpanElement.cpp:

(WebCore::SVGTSpanElement::childShouldCreateRenderer):

  • svg/SVGTSpanElement.h:

(SVGTSpanElement):

  • svg/SVGTextElement.cpp:

(WebCore::SVGTextElement::childShouldCreateRenderer):

  • svg/SVGTextElement.h:

(SVGTextElement):

  • svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::childShouldCreateRenderer):

  • svg/SVGTextPathElement.h:

LayoutTests:

  • fast/dom/shadow/shadow-on-image-expected.html: Added.
  • fast/dom/shadow/shadow-on-image.html: Added.
19:57 Changeset [108601] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] NetworkJob can access deleted objects.
https://bugs.webkit.org/show_bug.cgi?id=79246

Patch by Yong Li <yoli@rim.com> on 2012-02-22
Reviewed by Antonio Gomes.

When a NetworkJob is created by unload handler, we still need
to send the request to the server, but we shouldn't save and
keep using the Frame pointer because the frame is being detached.
The NetworkJob will be cancelled by PingLoader as soon as it gets
first response from host.
Also see https://bugs.webkit.org/show_bug.cgi?id=30457.

No new tests because existing test case is good enough like
LayoutTests/http/tests/navigation/image-load-in-unload-handler.html.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::NetworkJob):
(WebCore::NetworkJob::initialize):

19:44 Changeset [108600] by bashi@chromium.org
  • 3 edits in trunk/Source/WebCore

[WebSocket] Remove zlib.h from WebSocketDeflater.h
https://bugs.webkit.org/show_bug.cgi?id=79298

Use forward declaration and OwnPtr for z_stream to move zlib.h from
.h file to .cpp file.

Reviewed by Kent Tamura.

No new tests. No behavior change.

  • websockets/WebSocketDeflater.cpp:

(WebCore::WebSocketDeflater::WebSocketDeflater):
(WebCore::WebSocketDeflater::initialize):
(WebCore::WebSocketDeflater::~WebSocketDeflater):
(WebCore::setStreamParameter):
(WebCore::WebSocketDeflater::addBytes):
(WebCore::WebSocketDeflater::finish):
(WebCore::WebSocketDeflater::reset):
(WebCore::WebSocketInflater::WebSocketInflater):
(WebCore::WebSocketInflater::initialize):
(WebCore::WebSocketInflater::~WebSocketInflater):
(WebCore::WebSocketInflater::addBytes):
(WebCore::WebSocketInflater::finish):

  • websockets/WebSocketDeflater.h:

(WebSocketDeflater): Use OwnPtr for m_stream.
(WebSocketInflater): Ditto.

19:37 Changeset [108599] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening. Two inspector tests are timing out on Mac Debug.

  • platform/chromium/test_expectations.txt:
19:37 Changeset [108598] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Add unit test for surface occlusion
https://bugs.webkit.org/show_bug.cgi?id=79302

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-22
Reviewed by James Robinson.

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore::TEST):
(WebCore):

19:07 Changeset [108597] by jamesr@google.com
  • 12 edits in trunk/Source

Remove GraphicsContext3D::paintsIntoCanvasBuffer and unify WebGL and canvas 2d logic
https://bugs.webkit.org/show_bug.cgi?id=79317

Reviewed by Kenneth Russell.

Source/WebCore:

HTMLCanvasElement::paint needs to know whether to attempt to paint the canvas buffer for its context. In the
case of an accelerated canvas or WebGL context, unless we are printing it is typically the composited layer's
responsibility to present the contents and the element itself is only responsible for backgrounds, borders and
the like. This removes a rather indirect path that WebGL content used to take to accomplish this and unifies
the logic with CanvasRenderingContext2D's, which has the exact same needs.

Covered by existing canvas layout tests.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::paintsIntoCanvasBuffer):
(WebCore):
(WebCore::HTMLCanvasElement::paint):

  • html/HTMLCanvasElement.h:

(HTMLCanvasElement):

  • html/canvas/CanvasRenderingContext.h:
  • html/canvas/CanvasRenderingContext2D.cpp:
  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):

  • html/canvas/WebGLRenderingContext.h:
  • platform/graphics/GraphicsContext3D.h:

Source/WebKit/chromium:

Remove paintsIntoCanvasBuffer() implementations.

  • src/GraphicsContext3DChromium.cpp:

(WebCore):

  • src/GraphicsContext3DPrivate.h:
19:05 Changeset [108596] by commit-queue@webkit.org
  • 14 edits
    4 adds in trunk

PopStateEvent.state should use the same object as history.state
https://bugs.webkit.org/show_bug.cgi?id=77493

Patch by Pablo Flouret <pablof@motorola.com> on 2012-02-22
Reviewed by Kentaro Hara.

Source/WebCore:

Tests: fast/loader/stateobjects/state-attribute-history-getter.html

fast/loader/stateobjects/state-attribute-popstate-event.html

  • bindings/js/JSPopStateEventCustom.cpp:

(WebCore):
(WebCore::cacheState):
(WebCore::JSPopStateEvent::state):

  • bindings/v8/V8HiddenPropertyName.h:

(WebCore):

  • bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::stateAccessorGetter):
(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):

  • bindings/v8/custom/V8PopStateEventCustom.cpp:

(WebCore):
(WebCore::cacheState):
(WebCore::V8PopStateEvent::stateAccessorGetter):

  • dom/Document.cpp:

(WebCore::Document::enqueuePopstateEvent):

  • dom/PopStateEvent.cpp:

(WebCore::PopStateEvent::PopStateEvent):
(WebCore::PopStateEvent::create):

  • dom/PopStateEvent.h:

(WebCore):
(PopStateEvent):
(WebCore::PopStateEvent::history):

  • dom/PopStateEvent.idl:
  • page/History.cpp:

(WebCore::History::stateChanged):
(WebCore):
(WebCore::History::isSameAsCurrentState):

  • page/History.h:

(History):

LayoutTests:

  • fast/loader/stateobjects/state-attribute-history-getter-expected.txt: Added.
  • fast/loader/stateobjects/state-attribute-history-getter.html: Added.
  • fast/loader/stateobjects/state-attribute-only-one-deserialization-expected.txt:
  • fast/loader/stateobjects/state-attribute-only-one-deserialization.html:
  • fast/loader/stateobjects/state-attribute-popstate-event-expected.txt: Added.
  • fast/loader/stateobjects/state-attribute-popstate-event.html: Added.
19:01 Changeset [108595] by adamk@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove obsolete FIXMEs from ContainerNode
https://bugs.webkit.org/show_bug.cgi?id=79295

Reviewed by Ryosuke Niwa.

Each of these three identical FIXMEs has since been fixed by adding
"RefPtr<Node> protect(this)" at the top of each method.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::removeChild):

18:51 Changeset [108594] by dslomov@google.com
  • 6 edits in trunk

[JSC] Implement ArrayBuffer and typed array cloning in JSC
https://bugs.webkit.org/show_bug.cgi?id=79294

Reviewed by Oliver Hunt.

Source/WebCore:

Covered by existing tests.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::typedArrayElementSize):
(WebCore):
(WebCore::CloneSerializer::dumpArrayBufferView):
(CloneSerializer):
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneSerializer::write):
(WebCore::CloneDeserializer::readArrayBufferViewSubtag):
(CloneDeserializer):
(WebCore::CloneDeserializer::readArrayBuffer):
(WebCore::CloneDeserializer::readArrayBufferView):
(WebCore::CloneDeserializer::getJSValue):
(WebCore::CloneDeserializer::readTerminal):

LayoutTests:

  • fast/canvas/webgl/array-message-passing-expected.txt: Updated expectation after cloning implemented.
  • fast/canvas/webgl/script-tests/array-message-passing.js: Added Uint8ClampedArray
  • platform/chromium/fast/canvas/webgl/array-message-passing-expected.txt: Updated expectations. Fixing covered by https://bugs.webkit.org/show_bug.cgi?id=79291
18:24 Changeset [108593] by enne@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] Unreviewed speculative chromium-mac build fix.
https://bugs.webkit.org/show_bug.cgi?id=75874

This broke in r108581.

  • platform/graphics/chromium/cc/CCLayerAnimationController.h:

(WebCore):

18:19 Changeset [108592] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

exponentialRampToValue doesn't use starting value
https://bugs.webkit.org/show_bug.cgi?id=78035

Patch by Raymond Toy <rtoy@google.com> on 2012-02-22
Reviewed by Chris Rogers.

Source/WebCore:

Test: webaudio/audioparam-exponentialRampToValueAtTime.html

  • webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::valuesForTimeRangeImpl): Set
starting value for exponential ramp.

LayoutTests:

  • webaudio/audioparam-exponentialRampToValueAtTime-expected.txt: Added.
  • webaudio/audioparam-exponentialRampToValueAtTime.html: Added.
  • webaudio/resources/audioparam-testing.js: Added.

(createConstantBuffer):
(createExponentialRampArray):
(comparePartialSignals):
(verifyDiscontinuities):
(compareSignals):
(doAutomation):

18:16 Changeset [108591] by yutak@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r108590.
http://trac.webkit.org/changeset/108590

I mistakenly disabled tests even though the fix was already
in.

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore::TEST):

18:09 Changeset [108590] by yutak@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Unreviewed. Disable two tests from CCOcclusionTrackerTest
which cause assertion failures.

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore):
(WebCore::TEST):

18:08 Changeset [108589] by eae@chromium.org
  • 2 edits in branches/subpixellayout/Source/WebCore/platform

Removed unused methods from branch.

17:51 Changeset [108588] by enne@google.com
  • 3 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Rebaseline more svg tests.

This test was also broken after r108559. It times out on all platforms
but windows, so only rebaselining windows.

  • platform/chromium-win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png:
  • platform/chromium-win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
17:43 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
17:42 Changeset [108587] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Fix CCOcclusionTracker unit test assertion
https://bugs.webkit.org/show_bug.cgi?id=79275

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-22
Reviewed by James Robinson.

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore::TEST):

17:40 Changeset [108586] by kling@webkit.org
  • 4 edits in trunk/Source/WebCore

Make parsing color presentation attributes do less pointless work.
<http://webkit.org/b/79304>

Reviewed by Antti Koivisto.

Let HTMLElement::addHTMLColorToStyle() construct the color CSSValue directly
rather than passing a string that has to go through CSSParser.

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::setProperty):

  • css/StylePropertySet.h:

Added a setProperty(propertyID, CSSValue) overload that expands shorthand
properties if necessary. Also added a little comment about the behavior
differences between setProperty() overloads.

  • html/HTMLElement.cpp:

(WebCore::parseColorStringWithCrazyLegacyRules):

Changed this to return an RGBA32.

(WebCore::HTMLElement::addHTMLColorToStyle):

Figure out the RGB value and construct a (pooled) CSSValue directly.

17:35 Changeset [108585] by enne@google.com
  • 6 edits
    1 copy in trunk/LayoutTests

[chromium] Unreviewed gardening. Rebaseline zoom-replaced-intrinsic-ratio

This was broken after r108559 and the result looks reasonable given
the description of the change, so rebaselining.

  • platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt.
  • platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
17:34 Changeset [108584] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

fast/files/create-blob-url-crash.html is no longer flaky.
https://bugs.webkit.org/show_bug.cgi?id=60125

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
17:32 Changeset [108583] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Fix to launch the EWebLauncher using the script, run-launcher.
https://bugs.webkit.org/show_bug.cgi?id=79076

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-02-22
Reviewed by Andreas Kling.

  • Scripts/webkitdirs.pm: Fix the path of libewebkit.so.

(builtDylibPathForName):

17:25 Changeset [108582] by barraclough@apple.com
  • 6 edits in trunk

Implement DefineOwnProperty? for the arguments object
https://bugs.webkit.org/show_bug.cgi?id=79309

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • runtime/Arguments.cpp:

(JSC::Arguments::deletePropertyByIndex):
(JSC::Arguments::deleteProperty):

  • Deleting an argument should also delete the copy on the object, if any.

(JSC::Arguments::defineOwnProperty):

  • Defining a property may override the live mapping.
  • runtime/Arguments.h:

(Arguments):

LayoutTests:

  • fast/js/arguments-expected.txt:
  • fast/js/script-tests/arguments.js:
    • Added test cases
17:22 Changeset [108581] by commit-queue@webkit.org
  • 36 edits
    1 copy
    5 adds in trunk/Source

[chromium] Plumb from GraphicsLayer to the cc thread animation code
https://bugs.webkit.org/show_bug.cgi?id=75874

Patch by Ian Vollick <vollick@chromium.org> on 2012-02-22
Reviewed by James Robinson.

Source/WebCore:

  • WebCore.gypi:
  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setThreadedAnimationEnabled):
(WebCore::Settings::threadedAnimationEnabled):
(Settings):

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(std):
(WebCore::GraphicsLayerChromium::addChild):
(WebCore::GraphicsLayerChromium::addAnimation):
(WebCore):
(WebCore::GraphicsLayerChromium::pauseAnimation):
(WebCore::GraphicsLayerChromium::removeAnimation):
(WebCore::GraphicsLayerChromium::suspendAnimations):
(WebCore::GraphicsLayerChromium::resumeAnimations):
(WebCore::GraphicsLayerChromium::setContentsToMedia):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore::GraphicsLayerChromium::mapAnimationNameToId):

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(GraphicsLayerChromium):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::addAnimation):
(WebCore):
(WebCore::LayerChromium::pauseAnimation):
(WebCore::LayerChromium::removeAnimation):
(WebCore::LayerChromium::suspendAnimations):
(WebCore::LayerChromium::resumeAnimations):
(WebCore::LayerChromium::setLayerAnimationController):
(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore):
(LayerChromium):
(WebCore::LayerChromium::layerAnimationController):
(WebCore::LayerChromium::numChildren):

  • platform/graphics/chromium/cc/CCActiveAnimation.cpp:

(WebCore::CCActiveAnimation::create):
(WebCore):
(WebCore::CCActiveAnimation::CCActiveAnimation):
(WebCore::CCActiveAnimation::~CCActiveAnimation):
(WebCore::CCActiveAnimation::isWaiting):
(WebCore::CCActiveAnimation::isRunningOrHasRun):
(WebCore::CCActiveAnimation::cloneForImplThread):
(WebCore::CCActiveAnimation::synchronizeProperties):

  • platform/graphics/chromium/cc/CCActiveAnimation.h:

(CCActiveAnimation):
(WebCore::CCActiveAnimation::AnimationSignature::AnimationSignature):
(AnimationSignature):
(WebCore::CCActiveAnimation::id):
(WebCore::CCActiveAnimation::group):
(WebCore::CCActiveAnimation::signature):

  • platform/graphics/chromium/cc/CCAnimationCurve.h:

(CCAnimationCurve):
(CCTransformAnimationCurve):

  • platform/graphics/chromium/cc/CCAnimationEvents.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCAnimationCurve.h.

(WebCore):
(WebCore::CCAnimationStartedEvent::CCAnimationStartedEvent):
(CCAnimationStartedEvent):

  • platform/graphics/chromium/cc/CCLayerAnimationController.cpp: Added.

(WebCore):
(WebCore::CCLayerAnimationController::CCLayerAnimationController):
(WebCore::CCLayerAnimationController::~CCLayerAnimationController):
(WebCore::CCLayerAnimationController::create):
(WebCore::CCLayerAnimationController::addAnimation):
(WebCore::CCLayerAnimationController::pauseAnimation):
(WebCore::CCLayerAnimationController::removeAnimation):
(WebCore::CCLayerAnimationController::suspendAnimations):
(WebCore::CCLayerAnimationController::resumeAnimations):
(WebCore::CCLayerAnimationController::synchronizeAnimations):
(WebCore::CCLayerAnimationController::removeCompletedAnimations):
(WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):
(WebCore::CCLayerAnimationController::removeAnimationsCompletedOnMainThread):
(WebCore::CCLayerAnimationController::pushAnimationProperties):
(WebCore::CCLayerAnimationController::getActiveAnimation):
(WebCore::CCLayerAnimationController::remove):

  • platform/graphics/chromium/cc/CCLayerAnimationController.h: Added.

(WebCore):
(CCLayerAnimationController):
(WebCore::CCLayerAnimationController::activeAnimations):

  • platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.cpp:

(WebCore::CCLayerAnimationControllerImpl::~CCLayerAnimationControllerImpl):
(WebCore):
(WebCore::CCLayerAnimationControllerImpl::animate):
(WebCore::CCLayerAnimationControllerImpl::add):
(WebCore::CCLayerAnimationControllerImpl::getActiveAnimation):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForNextTick):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForStartTime):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForTargetAvailability):
(WebCore::CCLayerAnimationControllerImpl::purgeFinishedAnimations):
(WebCore::CCLayerAnimationControllerImpl::tickAnimations):

  • platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.h:

(CCLayerAnimationControllerImplClient):
(CCLayerAnimationControllerImpl):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):
(WebCore::CCLayerImpl::id):
(WebCore::CCLayerImpl::opacity):
(WebCore::CCLayerImpl::transform):
(WebCore::CCLayerImpl::bounds):
(WebCore::CCLayerImpl::layerAnimationController):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::setAnimationEvents):
(WebCore):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):
(CCSettings):
(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::animate):
(WebCore::CCLayerTreeHostImpl::animateLayersRecursive):
(WebCore):
(WebCore::CCLayerTreeHostImpl::animatePageScale):
(WebCore::CCLayerTreeHostImpl::animateLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImplClient):
(CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::needsAnimateLayers):
(WebCore::CCLayerTreeHostImpl::setNeedsAnimateLayers):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::postAnimationEventsToMainThreadOnImplThread):
(WebCore):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(CCSingleThreadProxy):
(WebCore):
(DebugScopedSetMainThread):
(WebCore::DebugScopedSetMainThread::DebugScopedSetMainThread):
(WebCore::DebugScopedSetMainThread::~DebugScopedSetMainThread):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::postAnimationEventsToMainThreadOnImplThread):
(WebCore):
(WebCore::CCThreadProxy::setAnimationEvents):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

  • WebKit.gypi:
  • public/WebSettings.h:
  • public/platform/WebLayerTreeView.h:

(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):

  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCSettings):

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setThreadedAnimationEnabled):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • tests/CCActiveAnimationTest.cpp:

(WebCore::createActiveAnimation):

  • tests/CCAnimationTestCommon.cpp: Added.

(WebKitTests):
(WebKitTests::FakeFloatAnimationCurve::FakeFloatAnimationCurve):
(WebKitTests::FakeFloatAnimationCurve::~FakeFloatAnimationCurve):
(WebKitTests::FakeFloatAnimationCurve::clone):
(WebKitTests::FakeTransformTransition::FakeTransformTransition):
(WebKitTests::FakeTransformTransition::~FakeTransformTransition):
(WebKitTests::FakeTransformTransition::getValue):
(WebKitTests::FakeTransformTransition::clone):
(WebKitTests::FakeFloatTransition::FakeFloatTransition):
(WebKitTests::FakeFloatTransition::~FakeFloatTransition):
(WebKitTests::FakeFloatTransition::getValue):
(WebKitTests::FakeLayerAnimationControllerImplClient::FakeLayerAnimationControllerImplClient):
(WebKitTests::FakeLayerAnimationControllerImplClient::~FakeLayerAnimationControllerImplClient):
(WebKitTests::FakeFloatTransition::clone):
(WebKitTests::addOpacityTransition):

  • tests/CCAnimationTestCommon.h: Added.

(WebCore):
(WebKitTests):
(FakeFloatAnimationCurve):
(WebKitTests::FakeFloatAnimationCurve::duration):
(WebKitTests::FakeFloatAnimationCurve::getValue):
(FakeTransformTransition):
(WebKitTests::FakeTransformTransition::duration):
(FakeFloatTransition):
(WebKitTests::FakeFloatTransition::duration):
(FakeLayerAnimationControllerImplClient):
(WebKitTests::FakeLayerAnimationControllerImplClient::id):
(WebKitTests::FakeLayerAnimationControllerImplClient::opacity):
(WebKitTests::FakeLayerAnimationControllerImplClient::setOpacity):
(WebKitTests::FakeLayerAnimationControllerImplClient::transform):
(WebKitTests::FakeLayerAnimationControllerImplClient::setTransform):
(WebKitTests::FakeLayerAnimationControllerImplClient::bounds):

  • tests/CCLayerAnimationControllerImplTest.cpp:

(WebKitTests::createActiveAnimation):
(WebKitTests::TEST):

  • tests/CCLayerAnimationControllerTest.cpp: Added.

(WebKitTests):
(WebKitTests::createActiveAnimation):
(WebKitTests::TEST):

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::CCLayerTreeHostImplTest::postAnimationEventsToMainThreadOnImplThread):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::TestHooks::animateLayers):
(MockLayerTreeHostImpl):
(WTF::MockLayerTreeHostImpl::animateLayers):
(WTF::MockLayerTreeHost::create):
(WTF::MockLayerTreeHost::createLayerTreeHostImpl):
(WTF):
(MockLayerAnimationController):
(WTF::MockLayerAnimationController::create):
(WTF::MockLayerAnimationController::addAnimation):
(WTF::MockLayerTreeHostClient::scheduleComposite):
(WTF::CCLayerTreeHostTest::postAddAnimationToMainThread):
(CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::dispatchAddAnimation):
(WTF::CCLayerTreeHostTest::doBeginTest):
(CCLayerTreeHostTestAddAnimation):
(WTF::CCLayerTreeHostTestAddAnimation::CCLayerTreeHostTestAddAnimation):
(WTF::CCLayerTreeHostTestAddAnimation::beginTest):
(WTF::CCLayerTreeHostTestAddAnimation::animateLayers):
(WTF::CCLayerTreeHostTestAddAnimation::afterTest):
(WTF::TEST_F):

  • tests/TreeSynchronizerTest.cpp:

(FakeLayerAnimationController):
(WebKitTests::FakeLayerAnimationController::create):
(WebKitTests::FakeLayerAnimationController::synchronizedAnimations):
(WebKitTests::FakeLayerAnimationController::FakeLayerAnimationController):
(WebKitTests::FakeLayerAnimationController::synchronizeAnimations):
(WebKitTests):
(WebKitTests::TEST):

17:20 Changeset [108580] by eae@chromium.org
  • 3587 edits
    804 copies
    338 deletes in branches/subpixellayout

Merge trunk changes up until 108547 into subpixel branch.

17:13 Changeset [108579] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Subframes with scrollable areas must be added to the non-fast scrollable region
https://bugs.webkit.org/show_bug.cgi?id=79306
<rdar://problem/10915564>

Reviewed by Andreas Kling.

When computing the non-fast scrollable region, add subframes with scrollable regions to the region.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::computeNonFastScrollableRegion):

17:04 Changeset [108578] by enne@google.com
  • 16 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Update expectations after skia roll.

It is most likely that the Skia roll from 3216 to 3226 slightly
changed image expectations for the following tests. None of these are
perceptually any different, so just rebaselining.

  • platform/chromium-linux/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/chromium-linux/fast/borders/border-image-rotate-transform-expected.png:
  • platform/chromium-linux/svg/custom/focus-ring-expected.png:
  • platform/chromium-linux/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/chromium-mac-leopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/chromium-mac-leopard/svg/custom/focus-ring-expected.png:
  • platform/chromium-mac-leopard/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-image-rotate-transform-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/focus-ring-expected.png:
  • platform/chromium-mac-snowleopard/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/chromium-win/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/chromium-win/fast/borders/border-image-rotate-transform-expected.png:
  • platform/chromium-win/svg/custom/focus-ring-expected.png:
  • platform/chromium-win/svg/transforms/animated-path-inside-transformed-html-expected.png:
16:56 Changeset [108577] by commit-queue@webkit.org
  • 5 edits in trunk

[Qt] Add eventSender.gestureTap
https://bugs.webkit.org/show_bug.cgi?id=66173

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-22
Reviewed by Kenneth Rohde Christiansen.

Tools:

  • DumpRenderTree/qt/EventSenderQt.cpp:

(EventSender::gestureTap):

  • DumpRenderTree/qt/EventSenderQt.h:

LayoutTests:

Unskip gestureTap test.

  • platform/qt/Skipped:
16:49 WebKitIDL edited by ericu@chromium.org
Copied info from http://trac.webkit.org/wiki/IdlAttributes (diff)
16:47 Changeset [108576] by japhet@chromium.org
  • 3 edits
    2 adds in trunk

Source/WebCore: CachedResourceLoader ignores the Range header
in determineRavlidationPolicy(), resulting in incorrect
cache hits.

Reviewed by Adam Barth.

Test: http/tests/xmlhttprequest/range-test.html
Test written by Aaron Colwell (acolwell@chromium.org).

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::determineRevalidationPolicy):

LayoutTests: Test Range header compliance for CachedResources.
https://bugs.webkit.org/show_bug.cgi?id=76564

Reviewed by Adam Barth.

  • http/tests/xmlhttprequest/range-test-expected.txt: Added.
  • http/tests/xmlhttprequest/range-test.html: Added.
16:44 Changeset [108575] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Generalize svg failures from r108494.

  • platform/chromium/test_expectations.txt:
16:42 Changeset [108574] by antti@apple.com
  • 8 edits
    3 adds in trunk

REGRESSION (r104060): Web font is not loaded if specified by link element dynamically inserted
https://bugs.webkit.org/show_bug.cgi?id=79186

Reviewed by Andreas Kling.

Source/WebCore:

Test: fast/css/font-face-insert-link.html

If a dynamically inserted stylesheet contains @font-face rules, we may fail to update the rendering.

Before r104060 the style selector was destroyed on every style change, and the font selector along with it.
This is no longer the case and we can't rely on comparing font selector pointers when comparing Fonts
for equality. This patch adds version number to the font selector and checks it in Font::operator==.
The version number is incremented when new font-face rules are added to the font selector.

FontFallbackList is an object shared between Fonts so the extra field shouldn't matter much in terms
of memory.

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::CSSFontSelector):
(WebCore::CSSFontSelector::addFontFaceRule):

  • css/CSSFontSelector.h:

(CSSFontSelector):

  • platform/graphics/Font.cpp:

(WebCore::Font::operator==):

  • platform/graphics/FontFallbackList.cpp:

(WebCore::FontFallbackList::FontFallbackList):
(WebCore::FontFallbackList::invalidate):

  • platform/graphics/FontFallbackList.h:

(FontFallbackList):
(WebCore::FontFallbackList::fontSelectorVersion):

  • platform/graphics/FontSelector.h:

(FontSelector):

LayoutTests:

  • fast/css/font-face-insert-link-expected.txt: Added.
  • fast/css/font-face-insert-link.html: Added.
  • fast/css/resources/ahem.css: Added.

(@font-face):

16:38 Changeset [108573] by japhet@chromium.org
  • 7 edits in trunk

Source/WebCore: Prevent CachedRawResource from sending the same data
chunk multiple times.
https://bugs.webkit.org/show_bug.cgi?id=78810

Reviewed by Adam Barth.

If a CachedRawResource receives data while a CachedRawResourceCallback
timer is active, the incremental data will be sent to the client, followed
but all data received so far, resulting in invalid data. Resolving this adds
complexity to CachedRawResource and requires making a few more CachedResource
functions virtual, so push the callback logic into CachedResource where it can
be implemented more cleanly.

Test: inspector/debugger/script-formatter-console.html

should no longer be flaky.

  • loader/cache/CachedRawResource.cpp: CachedRawResourceCallback renamed and moved to CachedResource.

(WebCore::CachedRawResource::didAddClient): More or less the same as sendCallbacks() was.

  • loader/cache/CachedRawResource.h:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::addClient): Check the return value of addClientToSet() to determine whether

or not to call didAddClient.

(WebCore::CachedResource::didAddClient): May be called during addClient(), or may be called on a timer.

If called on a timer, move the client between sets.

(WebCore::CachedResource::addClientToSet): Determine whether didAddClient() can be called synchronously and

return true if it can.

(WebCore::CachedResource::removeClient): Ensure we cancel pending callbacks if necessary.
(WebCore::CachedResource::CachedResourceCallback::CachedResourceCallback): Renamed and moved from CachedRawResource.

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::hasClients): Check m_clientsAwaitingCallback as well as m_clients.
(WebCore::CachedResource::CachedResourceCallback::schedule):
(WebCore::CachedResource::hasClient): Helper for calling contains() on both m_clientsAwaitingCallback and m_clients.

LayoutTests: inspector/debugger/script-formatter-console.html should
no longer be flaky.
https://bugs.webkit.org/show_bug.cgi?id=78810

Reviewed by Adam Barth.

  • platform/chromium/test_expectations.txt:
16:26 Changeset [108572] by kubo@profusion.mobi
  • 1 edit
    2 deletes in trunk

[CMake] Remove FindGDK.cmake and FindGDK-PixBuf.cmake
https://bugs.webkit.org/show_bug.cgi?id=79292

Reviewed by Daniel Bates.

These files were committed when the EFL port's buildsystem code
was upstreamed, but are currently not being used anywhere, as the EFL
port has not depended on GDK for a long time.

  • Source/cmake/FindGDK-PixBuf.cmake: Removed.
  • Source/cmake/FindGDK.cmake: Removed.
16:24 Changeset [108571] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

Implement TiledCoreAnimationDrawingAreaProxy::deviceScaleFactorDidChange
https://bugs.webkit.org/show_bug.cgi?id=79297
<rdar://problem/10748510>

Reviewed by Beth Dakin.

  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::deviceScaleFactorDidChange):
Send a message to the web process.

  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::setDeviceScaleFactor):
Add empty stub.

  • WebProcess/WebPage/DrawingArea.messages.in:

Add SetDeviceScaleFactor message.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::setDeviceScaleFactor):
Call WebPage::setDeviceScaleFactor.

16:16 Changeset [108570] by beidson@apple.com
  • 14 edits in trunk

<rdar://problem/10406044> and https://bugs.webkit.org/show_bug.cgi?id=79279
Synchronous ShouldGoToBackForwardListItem causes lots of WebProcess hangs

Reviewed by NOBODY (OOPS!).

Source/WebKit2:

Anytime the WebProcess sends a sync message up to the UI Process a hang can ensue.

In the case of shouldGoToBackForwardListItem it seems many clients want a back/forward
notification but don't actually want to make a policy decision.

Making it an asynchronous notification instead of a synchronous policy call will remove the
possibility of a hang here.

If clients later decide it is important to have a policy here we should implement a form of
shouldGoToBackForwardListItem in the bundle loader client.

Add a notification "willGoToBackForwardListItem" to the WKPageLoaderClient:

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeLoaderClient): Tell the WebProcess whether it should be

sending the shouldGoToBackForwardListItem or willGoToBackForwardListItem form of this message.

(WebKit::WebPageProxy::shouldGoToBackForwardListItem):
(WebKit::WebPageProxy::willGoToBackForwardListItem):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in: Add an asynchronous WillGoToBackForwardListItem message

Store a flag in the WebProcess - Sent from the UIProcess - to tell the FrameLoaderClient which form
of the callback should be used:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::willGoToBackForwardItemCallbackEnabled):
(WebKit::WebPage::setWillGoToBackForwardItemCallbackEnabled):

  • WebProcess/WebPage/WebPage.messages.in:
  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::shouldGoToBackForwardListItem): Only consider calling this for

version 0 clients.

(WebKit::WebLoaderClient::willGoToBackForwardListItem): Later clients get this callback.

  • UIProcess/WebLoaderClient.h:

(WebLoaderClient):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::shouldGoToHistoryItem): Send either the synchronous "should" message

or the asynchronous "will" message depending on which the WebProcess was last told that the
UIProcess expects. There is an edge case where the wrong one might be sent because the WebProcess
hasn't received the message about a change in the WKPageLoaderClient yet but that's probably okay;
It seems unlikely that a UIProcess client would ever rapidly change between v0 and other versions
of the loader client and the UIProcess of WebKit2 is equipped to handle that case if it comes up.

Tools:

Update our tools to the new form of the PageLoadClient.

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

15:47 Changeset [108569] by mrobinson@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.6.2

Tagging the WebKitGTK+ 1.6.2 release

15:46 Changeset [108568] by barraclough@apple.com
  • 8 edits in trunk

Fix Object.freeze for non-final objects.
https://bugs.webkit.org/show_bug.cgi?id=79286

Reviewed by Oliver Hunt.

For vanilla objects we implement this with a single transition, for objects
with special properties we should just follow the spec defined algorithm.

Source/JavaScriptCore:

  • runtime/JSArray.cpp:

(JSC::SparseArrayValueMap::put):

  • this does need to handle inextensible objects.
  • runtime/ObjectConstructor.cpp:

(JSC::objectConstructorSeal):
(JSC::objectConstructorFreeze):

  • Implement spec defined algorithm for non-final objects.
  • runtime/Structure.cpp:

(JSC::Structure::Structure):
(JSC::Structure::freezeTransition):

  • freeze should set m_hasReadOnlyOrGetterSetterPropertiesExcludingProto.
  • runtime/Structure.h:

(JSC::Structure::hasReadOnlyOrGetterSetterPropertiesExcludingProto):
(JSC::Structure::setHasGetterSetterProperties):
(JSC::Structure::setContainsReadOnlyProperties):
(Structure):

  • renamed m_hasReadOnlyOrGetterSetterPropertiesExcludingProto.

LayoutTests:

  • fast/js/preventExtensions-expected.txt:
  • fast/js/script-tests/preventExtensions.js:
    • added new tests.
15:46 Changeset [108567] by dbates@webkit.org
  • 1 edit in trunk/Source/WebCore/ChangeLog

Update change log entry for r108561 to reflect removal of "if (m_dispatchSoonList.isEmpty())".
https://bugs.webkit.org/show_bug.cgi?id=78840

Mention removal of unnecessary check for empty list m_dispatchSoonList in EventSender::cancelEvent().

Also, fix the date in the change log entry for changeset r108562 since it landed today (02/22/2012).

15:45 Changeset [108566] by jonlee@apple.com
  • 3 edits in trunk/Source/WebKit2

[WK2] Clearing notifications does not clean up internal state
https://bugs.webkit.org/show_bug.cgi?id=78861
<rdar://problem/10881167>

Reviewed by Anders Carlsson.

  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::clearNotifications): This function was missing removing the notification
entries from the other maps.
(WebKit::WebNotificationManager::didDestroyNotification): When the notification is destroyed, it should
also be removed from the context map.
(WebKit::WebNotificationManager::didCloseNotifications): Refactor to pull out the code that removes
a provided notification from the context map.
(WebKit::WebNotificationManager::removeNotificationFromContextMap): Find the notification in the map, and
remove it. If the map is empty, get rid of the entry.

  • WebProcess/Notifications/WebNotificationManager.h:

(WebNotificationManager):

15:44 Changeset [108565] by mrobinson@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.6.3

Tagging the WebKitGTK+ 1.6.3 release

15:43 Changeset [108564] by mrobinson@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.7.90

Tagging the WebKitGTK+ 1.7.90 release

15:43 Changeset [108563] by jonlee@apple.com
  • 2 edits in trunk/Source/WebKit2

Code cleanup in WebNotificationManager (79285)
https://bugs.webkit.org/show_bug.cgi?id=79285
<rdar://problem/10914522>

Reviewed by Anders Carlsson.

  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::show): Simplify adding a blank vector to the map using .add(),
similar to what is found in WebNotificationClient.mm in WebKit 1.

15:40 Changeset [108562] by rniwa@webkit.org
  • 11 edits in trunk/Source

Remove the remaining uses of CSSStyleDeclaration in Editor
https://bugs.webkit.org/show_bug.cgi?id=78939

Reviewed by Enrica Casucci.

Source/WebCore:

Changed the argument types of shouldApplyStyle, applyParagraphStyle, applyStyleToSelection,
applyParagraphStyleToSelection, and computeAndSetTypingStyle in Editor from CSSStyleDeclaration
to StylePropertySet.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • editing/Editor.cpp:

(WebCore::Editor::applyStyle):
(WebCore::Editor::shouldApplyStyle):
(WebCore::Editor::applyParagraphStyle):
(WebCore::Editor::applyStyleToSelection):
(WebCore::Editor::applyParagraphStyleToSelection):
(WebCore::Editor::setBaseWritingDirection):
(WebCore::Editor::computeAndSetTypingStyle):

  • editing/Editor.h:

(WebCore):
(Editor):

  • editing/EditorCommand.cpp:

(WebCore::applyCommandToFrame):
(WebCore::executeApplyParagraphStyle):
(WebCore::executeMakeTextWritingDirectionLeftToRight):
(WebCore::executeMakeTextWritingDirectionNatural):
(WebCore::executeMakeTextWritingDirectionRightToLeft):

  • loader/EmptyClients.h:

(WebCore::EmptyEditorClient::shouldApplyStyle):

  • page/DragController.cpp:

(WebCore::DragController::concludeEditDrag):

  • page/EditorClient.h:

(WebCore):
(EditorClient):

Source/WebKit/blackberry:

  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::shouldApplyStyle):

  • WebCoreSupport/EditorClientBlackBerry.h:

(EditorClientBlackBerry):

Source/WebKit/chromium:

  • src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::shouldApplyStyle):

  • src/EditorClientImpl.h:

(EditorClientImpl):

Source/WebKit/efl:

  • WebCoreSupport/EditorClientEfl.cpp:

(WebCore::EditorClientEfl::shouldApplyStyle):

  • WebCoreSupport/EditorClientEfl.h:

(EditorClientEfl):

Source/WebKit/gtk:

  • WebCoreSupport/EditorClientGtk.cpp:

(WebKit::EditorClient::shouldApplyStyle):

  • WebCoreSupport/EditorClientGtk.h:

(EditorClient):

Source/WebKit/mac:

  • WebCoreSupport/WebEditorClient.h:

(WebEditorClient):

  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::shouldApplyStyle):

  • WebView/WebFrame.mm:

(-[WebFrame _setTypingStyle:withUndoAction:]):

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
(-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):

  • WebView/WebView.mm:

(-[WebView applyStyle:]):

Source/WebKit/qt:

  • WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::shouldApplyStyle):

  • WebCoreSupport/EditorClientQt.h:

(EditorClientQt):

Source/WebKit/win:

  • WebCoreSupport/WebEditorClient.cpp:

(WebEditorClient::shouldApplyStyle):

  • WebCoreSupport/WebEditorClient.h:

(WebEditorClient):

Source/WebKit/wince:

  • WebCoreSupport/EditorClientWinCE.cpp:

(WebKit::EditorClientWinCE::shouldApplyStyle):

Source/WebKit/wx:

  • WebKitSupport/EditorClientWx.cpp:

(WebCore::EditorClientWx::shouldApplyStyle):

  • WebKitSupport/EditorClientWx.h:

(EditorClientWx):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::shouldApplyStyle):

  • WebProcess/WebCoreSupport/WebEditorClient.h:

(WebEditorClient):

15:28 Changeset [108561] by dbates@webkit.org
  • 8 edits
    1 add in trunk/Source/WebCore

Abstract ImageEventSender into a general purpose EventSender
https://bugs.webkit.org/show_bug.cgi?id=78840

Reviewed by Adam Barth.

Abstract the functionality in ImageEventSender so that it can be used again.
This functionality may be useful in fixing WebKit Bug #38995.

No functionality was changed; no new tests.

  • GNUmakefile.list.am: Added EventSender.h.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/EventSender.h: Added.

(WebCore):
(EventSender):
(WebCore::EventSender::eventType):
(WebCore::EventSender::hasPendingEvents):
(WebCore::EventSender::timerFired):
(WebCore::::EventSender):
(WebCore::::dispatchEventSoon):
(WebCore::::cancelEvent):
(WebCore::::dispatchPendingEvents):

  • loader/ImageLoader.cpp: Modified to use EventSender.

(WebCore):
(WebCore::ImageLoader::dispatchPendingEvent): Added; called by EventSender when the ImageLoader
should dispatch a pending BeforeLoad or Load event.

  • loader/ImageLoader.h:

(WebCore):
(ImageLoader):

15:23 Changeset [108560] by dbates@webkit.org
  • 3 edits in trunk/Tools

new-run-webkit-tests shouldn't restore Safari state on Lion when showing results
https://bugs.webkit.org/show_bug.cgi?id=79277

Reviewed by Adam Barth.

Pass command line argument no-saved-state to run-safari to disable Safari
state restoration for the session on OS 10.7.

  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.show_results_html_file):

  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:

(test_show_results_html_file):

15:17 Changeset [108559] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Paddings and borders on root SVG element with viewbox causes child SVG elements to be rendered with the incorrect size
https://bugs.webkit.org/show_bug.cgi?id=78613

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-02-22
Reviewed by Nikolas Zimmermann.

Source/WebCore:

When computing its localToBorderBoxTransform, RenderSVGRoot was using its width and height
as the dimensions of the SVG viewport. However, width and height include CSS borders and
paddings, which are not part of the SVG viewport area. Now, RenderSVGRoot uses its
contentWidth and contentHeight, which correspond to the SVG viewport area.

Tests: svg/custom/svg-root-padding-border-margin-expected.html

svg/custom/svg-root-padding-border-margin.html

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::buildLocalToBorderBoxTransform):

LayoutTests:

  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/custom/circle-move-invalidation-expected.png:
  • platform/mac/svg/custom/circle-move-invalidation-expected.txt:

This test contains a circle drawn inside a root SVG element with a 1px border. This bug
was causing WebKit to render the circle 1px too large, reflected in the expectations.
The expectations have been updated.

  • svg/custom/svg-root-padding-border-margin-expected.html: Added.
  • svg/custom/svg-root-padding-border-margin.html: Added.
15:15 Changeset [108558] by kubo@profusion.mobi
  • 2 edits
    2 deletes in trunk/Source/WebCore

[EFL] Get rid of GeolocationServiceEfl
https://bugs.webkit.org/show_bug.cgi?id=79270

Reviewed by Adam Barth.

These were just a bunch of dummy files with no real functionality, and
removing them helps the preparation of bug 78853, which will make
client-based geolocation the default.

No new tests, this functionality was not used.

  • PlatformEfl.cmake:
  • platform/efl/GeolocationServiceEfl.cpp: Removed.
  • platform/efl/GeolocationServiceEfl.h: Removed.
15:10 Changeset [108557] by jchaffraix@webkit.org
  • 4 edits in trunk/Source/WebCore

Clean-up RenderTableSection::calcRowLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=77705

Reviewed by Eric Seidel.

Refactoring / simplication of the code.

This change removes some variables that were unneeded and were
hiding what the code was really doing. Also some of the code was
split and moved down to RenderTableCell.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::logicalHeightForRowSizing):

  • rendering/RenderTableCell.h:

(RenderTableCell):
Added the previous helper function to calculate the cell's
adjusted logical height.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):
Removed some variables, simplified the rowspan logic to be clearer
(and added a comment about how we handle rowspans).

15:07 Changeset [108556] by abarth@webkit.org
  • 10 edits
    3 adds in trunk/Source/WebCore

Move FILE_SYSTEM code out of DOMWindow and into the fileapi folder
https://bugs.webkit.org/show_bug.cgi?id=79259

Reviewed by Eric Seidel.

This patch is part of our ongoing effort to remove ifdefs from code
classes. The FILE_SYSTEM code in DOMWindow doesn't really have any
necessary connection to DOMWindow. DOMWindow is just the context
object that the API hangs off of.

This patch moves the FILE_SYSTEM code into the fileapi folder using
[Supplemental].

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • fileapi/DOMWindowFileSystem.cpp: Added.

(WebCore):
(WebCore::DOMWindowFileSystem::DOMWindowFileSystem):
(WebCore::DOMWindowFileSystem::~DOMWindowFileSystem):
(WebCore::DOMWindowFileSystem::webkitRequestFileSystem):
(WebCore::DOMWindowFileSystem::webkitResolveLocalFileSystemURL):

  • fileapi/DOMWindowFileSystem.h: Added.

(WebCore):
(DOMWindowFileSystem):

  • fileapi/DOMWindowFileSystem.idl: Added.
  • page/DOMWindow.cpp:

(WebCore):

  • page/DOMWindow.h:

(WebCore):
(DOMWindow):

  • page/DOMWindow.idl:
14:54 Changeset [108555] by macpherson@chromium.org
  • 4 edits in trunk/Source/WebCore

Re-implement many more HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macros in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=79200

Reviewed by Andreas Kling.

No new tests / refactoring only.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • rendering/style/RenderStyle.h:
14:52 Changeset [108554] by dcheng@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Cleanup unused WebDragData methods after r107846
https://bugs.webkit.org/show_bug.cgi?id=78837

Reviewed by Tony Chang.

The deleted methods have been replaced by items() and setItems().

  • public/platform/WebDragData.h:

(WebDragData):

  • src/WebDragData.cpp:

(WebKit::WebDragData::addItem): Add ensureMutable() call to verify preconditions for

mutating the item store.

14:26 Changeset [108553] by mhahnenberg@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Allocations from CopiedBlocks should always be 8-byte aligned
https://bugs.webkit.org/show_bug.cgi?id=79271

Reviewed by Geoffrey Garen.

  • heap/CopiedAllocator.h:

(JSC::CopiedAllocator::allocate):

  • heap/CopiedBlock.h: Changed to add padding so that the start of the payload is always

guaranteed to be 8 byte aligned on both 64- and 32-bit platforms.
(CopiedBlock):

  • heap/CopiedSpace.cpp: Changed all assertions of isPointerAligned to is8ByteAligned.

(JSC::CopiedSpace::tryAllocateOversize):
(JSC::CopiedSpace::getFreshBlock):

  • heap/CopiedSpaceInlineMethods.h:

(JSC::CopiedSpace::allocateFromBlock):

  • runtime/JSArray.h:

(ArrayStorage): Added padding for ArrayStorage to make sure that it is always 8 byte
aligned on both 64- and 32-bit platforms.

  • wtf/StdLibExtras.h:

(WTF::is8ByteAligned): Added new utility function that functions similarly to the
way isPointerAligned does, but it just always checks for 8 byte alignment.
(WTF):

14:25 Changeset [108552] by eae@chromium.org
  • 10 edits in branches/subpixellayout/Source/WebCore

Fix qt build on branch.

14:21 Changeset [108551] by tsepez@chromium.org
  • 4 edits
    8 adds in trunk

XSSAuditor bypass with <svg> tags and html-entities.
https://bugs.webkit.org/show_bug.cgi?id=78836

Reviewed by Adam Barth.

Source/WebCore:

Tests: http/tests/security/xssAuditor/iframe-onload-in-svg-tag.html

http/tests/security/xssAuditor/script-tag-inside-svg-tag.html
http/tests/security/xssAuditor/script-tag-inside-svg-tag2.html
http/tests/security/xssAuditor/script-tag-inside-svg-tag3.html

  • html/parser/XSSAuditor.cpp:

(WebCore::isNonCanonicalCharacter):
(WebCore::isTerminatingCharacter):
(WebCore):
(WebCore::startsHTMLCommentAt):
(WebCore::startsSingleLineCommentAt):
(WebCore::fullyDecodeString):
(WebCore::XSSAuditor::XSSAuditor):
(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::filterToken):
(WebCore::XSSAuditor::filterStartToken):
(WebCore::XSSAuditor::filterEndToken):
(WebCore::XSSAuditor::filterCharacterToken):
(WebCore::XSSAuditor::filterScriptToken):
(WebCore::XSSAuditor::filterObjectToken):
(WebCore::XSSAuditor::filterParamToken):
(WebCore::XSSAuditor::filterEmbedToken):
(WebCore::XSSAuditor::filterAppletToken):
(WebCore::XSSAuditor::filterIframeToken):
(WebCore::XSSAuditor::filterMetaToken):
(WebCore::XSSAuditor::filterBaseToken):
(WebCore::XSSAuditor::filterFormToken):
(WebCore::XSSAuditor::decodedSnippetForAttribute):
(WebCore::XSSAuditor::snippetForJavaScript):

  • html/parser/XSSAuditor.h:

(XSSAuditor):

LayoutTests:

  • http/tests/security/xssAuditor/iframe-onload-in-svg-tag-expected.txt: Added.
  • http/tests/security/xssAuditor/iframe-onload-in-svg-tag.html: Added.
  • http/tests/security/xssAuditor/script-tag-inside-svg-tag-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-inside-svg-tag.html: Added.
  • http/tests/security/xssAuditor/script-tag-inside-svg-tag2-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-inside-svg-tag2.html: Added.
  • http/tests/security/xssAuditor/script-tag-inside-svg-tag3-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-inside-svg-tag3.html: Added.
14:09 Changeset [108550] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Crash when marking cached pages for full style recalc
https://bugs.webkit.org/show_bug.cgi?id=79276
<rdar://problem/10884036>

Reviewed by Beth Dakin.

Guard against a null history item.

  • history/BackForwardController.cpp:

(WebCore::BackForwardController::markPagesForFullStyleRecalc):

14:03 Changeset [108549] by eae@chromium.org
  • 43 edits in branches/subpixellayout/Source/WebCore

Revert baselinePosition to int on branch.

13:56 Changeset [108548] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

Crash from empty anonymous block preceding :before content
https://bugs.webkit.org/show_bug.cgi?id=78250

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-02-22
Reviewed by David Hyatt.

Source/WebCore:

RenderListMarkers getting removed from the tree in updateMarkerLocation()
can leave parent anonymous blocks behind with no children. This was
confusing updateBeforeAfterContent() because it does not expect
an empty block to precede :before content renderers.

Fix is to remove the anonymous block if it will lose all of its children.

  • rendering/RenderListItem.cpp:

(WebCore::RenderListItem::updateMarkerLocation):

LayoutTests:

Test exercises a crashing condition from extra :before content being
created after a RenderListMarker in an anonymous block has been moved.

Also rebasing some tests that had extraneous anonymous blocks in their
render tree dumps.

  • fast/css-generated-content/before-content-with-list-marker-in-anon-block-crash-expected.txt: Added
  • fast/css-generated-content/before-content-with-list-marker-in-anon-block-crash.html: Added
  • platform/chromium-win/editing/execCommand/create-list-with-hr-expected.txt:
  • platform/gtk/editing/execCommand/create-list-with-hr-expected.txt:
  • platform/mac/editing/execCommand/create-list-with-hr-expected.txt:
  • platform/qt/editing/execCommand/create-list-with-hr-expected.txt:
13:33 Changeset [108547] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Source/WebCore: Crash due to accessing removed parent lineboxes when clearing view selection.
https://bugs.webkit.org/show_bug.cgi?id=79264

Reviewed by Eric Seidel.

When our block needed a full layout, we were deleting our own lineboxes
and letting descendant children (at any level in hierarchy and not just
immediate children) clear their own lineboxes as we keep laying them out.
This was problematic because those descendant children lineboxes were
pointing to removed parent lineboxes in the meantime. An example scenario
where this would go wrong is first-letter object removal, which can cause
clearing view selection, leading to accessing parent lineboxes. The patch
modifies clearing the entire linebox tree upfront. It shouldn't introduce
performance issues since it will eventually happen as we are laying out
those children.

Test: fast/css-generated-content/first-letter-textbox-parent-crash.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):

LayoutTests: Crash due to accessing removed parent lineboxes when clearing view selection.
https://bugs.webkit.org/show_bug.cgi?id=79264

Reviewed by Eric Seidel.

  • fast/css-generated-content/first-letter-textbox-parent-crash-expected.txt: Added.
  • fast/css-generated-content/first-letter-textbox-parent-crash.html: Added.
13:24 Changeset [108546] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderMarquee.cpp

Fixing a merge artifact in RenderMarquee.

13:23 Changeset [108545] by leviw@chromium.org
  • 2 edits in branches/subpixellayout/Source/WebCore/rendering

Adding a floorToInt method for ease in moving to trunk, and flooring the right offset for line layout, as due to column layout, we can't be guaranteed to pixel snap at render time identically to layout time.

13:17 Changeset [108544] by mrobinson@webkit.org
  • 1 edit in releases/WebKitGTK/webkit-1.8/Source/WebCore/GNUmakefile.am

Fix bad merge

13:07 Changeset [108543] by inferno@chromium.org
  • 3 edits
    7 adds in trunk

Cloning and linebox issues in multi-column layout.
https://bugs.webkit.org/show_bug.cgi?id=78273

Reviewed by Eric Seidel.

Source/WebCore:

Tests: fast/multicol/span/clone-flexbox.html

fast/multicol/span/clone-summary.html
fast/multicol/span/textbox-not-removed-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::clone): Fix cloning algorithm to take
care of cloning descendant classes of RenderBlock.
(WebCore::RenderBlock::splitBlocks): When we move our inline children
to cloneBlock, we need to clear our entire line box tree. Any descendant
child in the hierarchy could be a part of our line box tree and will
never get cleared since the child has moved to new parent cloneBlock.

LayoutTests:

  • fast/multicol/span/clone-flexbox-expected.png:
  • fast/multicol/span/clone-flexbox-expected.txt: Added.
  • fast/multicol/span/clone-flexbox.html: Added. Test passes if we

see two RenderFlexibox in the rendertree.

  • fast/multicol/span/clone-summary-expected.png: Added.
  • fast/multicol/span/clone-summary-expected.txt: Added.
  • fast/multicol/span/clone-summary.html: Added. Test passes if we

see two RenderSummary in the rendertree.

  • fast/multicol/span/textbox-not-removed-crash-expected.txt: Added.
  • fast/multicol/span/textbox-not-removed-crash.html: Added. Test

passes it we do not crash on m_hasBadParent assert in InlineBox.

13:00 Changeset [108542] by commit-queue@webkit.org
  • 5 edits in trunk/Source

CCLayerTreeHostImpl calls didDraw more frequently than willDraw
https://bugs.webkit.org/show_bug.cgi?id=79139

Patch by Tim Dresser <tdresser@chromium.org> on 2012-02-22
Reviewed by James Robinson.

Source/WebCore:

Ensure that didDraw is called if and only if willDraw was called previously.

CCLayerTreeHostImplTest.didDrawNotCalledOnHiddenLayer has been added to ensure that
hidden layers, for which willDraw is not called, will also not have didDraw called.

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::drawLayers):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::didDraw):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::DidDrawCheckLayer::willDraw):
(DidDrawCheckLayer):
(WebKit::DidDrawCheckLayer::willDrawCalled):
(WebKit::DidDrawCheckLayer::DidDrawCheckLayer):
(WebKit::TEST_F):
(WebKit):

12:57 Changeset [108541] by leviw@chromium.org
  • 2 edits in trunk/Source/WebCore

ScrollbarThemeComposite::thumbPosition uses the result of a divide by zero
https://bugs.webkit.org/show_bug.cgi?id=78910

Reviewed by Eric Seidel.

Adding a check to avoid doing a floating point divide by zero and assigning NaN to an integer.
This causes problems with our conversion to subpixel layout, which asserts when we overflow.

  • platform/ScrollbarThemeComposite.cpp:

(WebCore::ScrollbarThemeComposite::thumbPosition):

12:51 Changeset [108540] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Explicitly include unistd.h in TestNetscapePlugIn for GCC 4.7
https://bugs.webkit.org/show_bug.cgi?id=77759

Patch by Kalev Lember <kalevlember@gmail.com> on 2012-02-22
Reviewed by Tony Chang.

Fixes build with gcc 4.7.

r100432 added the include only for ANDROID; this changes the ifdef to
also cover other unix platforms. On Fedora 17 the gcc 4.7 compiler no
longer implicitly includes unistd.h from standard headers and other
unix platforms are likely to get gcc 4.7 as well in the future.

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
12:43 Changeset [108539] by enne@google.com
  • 2 edits
    7 adds in trunk/LayoutTests

[chromium] Unreviewed gardening. Rebaseline svg expectations after r108493.

Blindly updating expected to actual on Chromium. They only started
failing after the base expectations were updated and don't have any
perceptual differences.

  • platform/chromium-mac-snowleopard/svg/foreignObject/clip-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/foreignObject/filter-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/foreignObject/mask-expected.png: Added.
  • platform/chromium-win/svg/custom/visited-link-color-expected.png: Added.
  • platform/chromium-win/svg/foreignObject/clip-expected.png: Added.
  • platform/chromium-win/svg/foreignObject/filter-expected.png: Added.
  • platform/chromium-win/svg/foreignObject/mask-expected.png: Added.
  • platform/chromium/test_expectations.txt:
12:41 Changeset [108538] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Have the DynamicsCompressorNode support multi-channel data
https://bugs.webkit.org/show_bug.cgi?id=77856

Patch by Raymond Liu <raymond.liu@intel.com> on 2012-02-22
Reviewed by Chris Rogers.

  • platform/audio/DynamicsCompressor.cpp:

(WebCore::DynamicsCompressor::DynamicsCompressor):
(WebCore::DynamicsCompressor::setEmphasisStageParameters):
(WebCore::DynamicsCompressor::process):
(WebCore::DynamicsCompressor::reset):
(WebCore::DynamicsCompressor::setNumberOfChannels):
(WebCore):

  • platform/audio/DynamicsCompressor.h:

(DynamicsCompressor):

  • platform/audio/DynamicsCompressorKernel.cpp:

(WebCore::DynamicsCompressorKernel::DynamicsCompressorKernel):
(WebCore::DynamicsCompressorKernel::setNumberOfChannels):
(WebCore):
(WebCore::DynamicsCompressorKernel::setPreDelayTime):
(WebCore::DynamicsCompressorKernel::process):
(WebCore::DynamicsCompressorKernel::reset):

  • platform/audio/DynamicsCompressorKernel.h:

(DynamicsCompressorKernel):

  • webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
(WebCore::DynamicsCompressorNode::initialize):

12:31 Changeset [108537] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

Not correctly recalculating layout for elements within nested SVG elements
https://bugs.webkit.org/show_bug.cgi?id=77535

Patch by Bear Travis <betravis@adobe.com> on 2012-02-22
Reviewed by Dirk Schulze.

Source/WebCore:

Relatively positioned text is not correctly updating its position when the
size of its nearest viewport changes. Updating to mark text for layout when
viewPort size changes.

Test: svg/repaint/inner-svg-change-viewPort-relative.svg

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::layoutChildren):

LayoutTests:

Adding a repaint test for a relatively sized inner svg and inner svg content when
its width/height changes.

  • platform/chromium/test_expectations.txt:
  • svg/repaint/inner-svg-change-viewPort-relative-expected.png: Added.
  • svg/repaint/inner-svg-change-viewPort-relative-expected.txt: Added.
  • svg/repaint/inner-svg-change-viewPort-relative.svg: Added.
12:18 Changeset [108536] by commit-queue@webkit.org
  • 8 edits in trunk

[chromium] Fix remaining compositing/rubberbanding test failures
https://bugs.webkit.org/show_bug.cgi?id=78008

These were happening due to the fact that ScrollView wasn't updating
the overhang layer when the contentsSize was updated. This is necessary
because calculateOverhangAreasForPainting() takes the contentsSize into
account when determining whether the overhang areas are visible.

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2012-02-22
Reviewed by James Robinson.

Source/WebCore:

Re-enabled the following tests with updated baselines:

  • platform/chromium/compositing/rubberbanding/transform-overhang-e-expected.png:
  • platform/chromium/compositing/rubberbanding/transform-overhang-s-expected.png:
  • platform/chromium/compositing/rubberbanding/transform-overhang-se-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::setContentsSize):
(WebCore::ScrollView::scrollContents):
(WebCore::ScrollView::updateOverhangAreas):
(WebCore):

  • platform/ScrollView.h:

(ScrollView):

LayoutTests:

Re-enabled the following tests with updated baselines:

  • platform/chromium/compositing/rubberbanding/transform-overhang-e-expected.png:
  • platform/chromium/compositing/rubberbanding/transform-overhang-s-expected.png:
  • platform/chromium/compositing/rubberbanding/transform-overhang-se-expected.png:
  • platform/chromium/test_expectations.txt:
12:15 Changeset [108535] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] InputHandler has signed vs unsigned comparison.
https://bugs.webkit.org/show_bug.cgi?id=79261

Fix warning by casting the unsigned int to an int.

Patch by Mike Fenton <mifenton@rim.com> on 2012-02-22
Reviewed by Rob Buis.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::rectForCaret):

12:11 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
12:09 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
12:08 Changeset [108534] by mrobinson@webkit.org
  • 4 edits in releases/WebKitGTK/webkit-1.8

.: Update the version information in preparation for the 1.7.90 release.

Reviewed by Gustavo Noronha Silva.

  • configure.ac: Update versions.

Source/WebKit/gtk: Update the NEWS file in preparation for the 1.7.90 release.

Reviewed by Gustavo Noronha Silva.

  • NEWS: Update NEWS.
12:04 Changeset [108533] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Regression] network worker tests crash on qt.
https://bugs.webkit.org/show_bug.cgi?id=79263

Reviewed by Pavel Feldman.

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::createDecoder):
(WebCore::InspectorPageAgent::cachedResourceContent):

12:02 Changeset [108532] by enne@google.com
  • 4 edits
    1 add in trunk/Source/WebCore

Unreviewed, rolling out r108518.
http://trac.webkit.org/changeset/108518
https://bugs.webkit.org/show_bug.cgi?id=75864

Breaks surfaceOcclusionWithOverlappingSiblingSurfaces unit test.

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCLayerIterator.cpp:

(WebCore):
(WebCore::CCLayerIteratorActions::BackToFront::begin):
(WebCore::CCLayerIteratorActions::BackToFront::end):
(WebCore::CCLayerIteratorActions::BackToFront::next):
(WebCore::CCLayerIteratorActions::FrontToBack::begin):
(WebCore::CCLayerIteratorActions::FrontToBack::end):
(WebCore::CCLayerIteratorActions::FrontToBack::next):
(WebCore::CCLayerIteratorActions::FrontToBack::goToHighestInSubtree):

  • platform/graphics/chromium/cc/CCLayerIterator.h:

(WebCore):
(WebCore::CCLayerIterator::CCLayerIterator):
(WebCore::CCLayerIterator::operator++):
(WebCore::CCLayerIterator::operator==):
(WebCore::CCLayerIterator::operator->):
(WebCore::CCLayerIterator::operator*):
(WebCore::CCLayerIterator::representsTargetRenderSurface):
(WebCore::CCLayerIterator::representsContributingRenderSurface):
(WebCore::CCLayerIterator::targetRenderSurfaceLayer):
(CCLayerIterator):
(BackToFront):
(FrontToBack):

  • platform/graphics/chromium/cc/CCLayerIteratorPosition.h: Added.

(WebCore):
(CCLayerIteratorPositionValue):
(WebCore::CCLayerIteratorPosition::CCLayerIteratorPosition):
(CCLayerIteratorPosition):
(WebCore::CCLayerIteratorPosition::currentLayer):
(WebCore::CCLayerIteratorPosition::currentLayerRepresentsContributingRenderSurface):
(WebCore::CCLayerIteratorPosition::currentLayerRepresentsTargetRenderSurface):
(WebCore::CCLayerIteratorPosition::targetRenderSurfaceLayer):
(WebCore::CCLayerIteratorPosition::targetRenderSurface):
(WebCore::CCLayerIteratorPosition::targetRenderSurfaceChildren):
(WebCore::CCLayerIteratorPosition::operator==):

11:52 Changeset [108531] by mrobinson@webkit.org
  • 9 edits in releases/WebKitGTK/webkit-1.8

Merging r108459

11:48 Changeset [108530] by mrobinson@webkit.org
  • 7 edits in releases/WebKitGTK/webkit-1.8

Merging r108523

11:43 Changeset [108529] by mrobinson@webkit.org
  • 13 edits in releases/WebKitGTK/webkit-1.8

Rolling out a bad merge

11:37 Changeset [108528] by mitz@apple.com
  • 4 edits in trunk

REGRESSION (r62632): page-break-inside: avoid is ignored
https://bugs.webkit.org/show_bug.cgi?id=79262

Reviewed by Adele Peterson.

Source/WebCore:

This was disabled in r62632 because of <http://webkit.org/b/41532>. Changes to the
pagination code since then have invalidated that bug, so enabling the feature again does not
re-introduce the bug.

Updated expected results for printing/page-break-inside-avoid.html.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustForUnsplittableChild):

LayoutTests:

  • printing/page-break-inside-avoid-expected.txt:
11:20 Changeset [108527] by philn@webkit.org
  • 8 edits in trunk

Unreviewed, rolling out r108522.
http://trac.webkit.org/changeset/108522
https://bugs.webkit.org/show_bug.cgi?id=76181

Broke 4 fullscreen tests on GTK.

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::supportsFullScreenForElement):
(WebKit::ChromeClient::enterFullScreenForElement):
(WebKit::ChromeClient::exitFullScreenForElement):

  • WebCoreSupport/ChromeClientGtk.h:

(ChromeClient):

  • tests/testwebview.c:
  • webkit/webkitwebview.cpp:

(webkit_web_view_class_init):

  • webkit/webkitwebview.h:

(_WebKitWebViewClass):

Tools:

  • GtkLauncher/main.c:

(createBrowser):
(createWindow):

11:18 Changeset [108526] by mrobinson@webkit.org
  • 13 edits in releases/WebKitGTK/webkit-1.8

Merging r108459

11:14 Changeset [108525] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Mark some XHR tests as asserting.
https://bugs.webkit.org/show_bug.cgi?id=79229

  • platform/chromium/test_expectations.txt:
11:12 Changeset [108524] by philn@webkit.org
  • 4 edits in trunk/Source/WebCore

[GStreamer] webkitwebsrc: use HTTP referer provided by MediaPlayer
https://bugs.webkit.org/show_bug.cgi?id=79236

Reviewed by Martin Robinson.

Store a pointer to the MediaPlayer object in the private structure
of the WebKitWebSrc element so we can call its public methods,
like ::referrer().

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::sourceChanged):

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(_WebKitWebSrcPrivate):

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.h:
10:56 Changeset [108523] by mrobinson@webkit.org
  • 7 edits in trunk

[GTK] Clean build is broken when using make -j
https://bugs.webkit.org/show_bug.cgi?id=76388

.:

  • GNUmakefile.am: Add new global source list variables.

Source/WebCore:

No new tests. This is just a build fix.

Use order-only dependencies to ensure that built sources are built before
files that depend on them.

  • GNUmakefile.am: Establish an order-only dependency on some built sources before starting

to build non-generated sources. Rename some temporary files and variables to be more consistent.

  • bindings/gobject/GNUmakefile.am: Updated to reflect new variable names.

Source/WebKit2:

  • GNUmakefile.am: Add some WebKit2 sources to global sources lists

so that we can refer to them in separate GNUmakefiles.

10:56 Changeset [108522] by philn@webkit.org
  • 8 edits in trunk

[GTK] FullScreen signals
https://bugs.webkit.org/show_bug.cgi?id=76181

Reviewed by Martin Robinson.

Source/WebKit/gtk:

Added entering-fullscreen and leaving-fullscreen signals, meant to
be used by the user agent to be notified when an element requests
full screen display and when the full screen display is to be
disabled.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::supportsFullScreenForElement):
(WebKit::onFullscreenGtkKeyPressEvent):
(WebKit::ChromeClient::cancelFullScreen):
(WebKit::ChromeClient::enterFullScreenForElement):
(WebKit::ChromeClient::exitFullScreenForElement):

  • WebCoreSupport/ChromeClientGtk.h:
  • tests/testwebview.c:
  • webkit/webkitwebview.cpp:

(webkit_web_view_real_entering_fullscreen):
(webkit_web_view_real_leaving_fullscreen):
(webkit_web_view_class_init):

  • webkit/webkitwebview.h:

Tools:

Use the two new entering/leaving fullscreen signals to hide/show
the tool bar, the status bar and ask the user's permission before
entering fullscreen.

  • GtkLauncher/main.c:

(webViewFullscreenMessageWindowClose):
(webViewWindowStateEvent):
(hide_widget):
(show_widget):
(webViewEnteringFullScreen):
(webViewLeavingFullScreen):
(createBrowser):
(createWindow):

10:45 Changeset [108521] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk/Source

[Chromium] New CCOcclusionTracker class with tests
https://bugs.webkit.org/show_bug.cgi?id=78549

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-22
Reviewed by James Robinson.

Source/WebCore:

Adds a CCOcclusionTrackerBase template class that is able to track occlusion
of layers while traversing the layer tree from front-to-back, with typedefed
versions for the main and impl threads.

At each step of the front-to-back traversal, the class should be notified of
changes to the current render target, and when done working with a layer, the
layer is added the tracked occlusion.

The class provides tests for checking if a rect in content space
for a layer/surface is occluded by others in front of it.

Unit tests: CCOcclusionTrackerTest.cpp

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp: Added.

(WebCore):
(WebCore::::enterTargetRenderSurface):
(WebCore::::finishedTargetRenderSurface):
(WebCore::transformSurfaceOpaqueRegion):
(WebCore::::leaveToTargetRenderSurface):
(WebCore::contentToScreenSpaceTransform):
(WebCore::contentToTargetSurfaceTransform):
(WebCore::computeOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):
(WebCore::testContentRectOccluded):
(WebCore::::occluded):
(WebCore::::surfaceOccluded):
(WebCore::rectSubtractRegion):
(WebCore::computeUnoccludedContentRect):
(WebCore::::unoccludedContentRect):
(WebCore::::surfaceUnoccludedContentRect):
(WebCore::::currentOcclusionInScreenSpace):
(WebCore::::currentOcclusionInTargetSurface):

  • platform/graphics/chromium/cc/CCOcclusionTracker.h: Added.

(WebCore):
(CCOcclusionTrackerBase):
(WebCore::CCOcclusionTrackerBase::CCOcclusionTrackerBase):
(StackObject):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCLayerTreeHostCommonTest.cpp:

(WebCore):

  • tests/CCOcclusionTrackerTest.cpp: Added.

(WebCore):
(WebCore::setLayerPropertiesForTesting):
(LayerChromiumWithForcedDrawsContent):
(WebCore::LayerChromiumWithForcedDrawsContent::LayerChromiumWithForcedDrawsContent):
(WebCore::LayerChromiumWithForcedDrawsContent::drawsContent):
(TestCCOcclusionTracker):
(WebCore::TestCCOcclusionTracker::occlusionInScreenSpace):
(WebCore::TestCCOcclusionTracker::occlusionInTargetSurface):
(WebCore::TestCCOcclusionTracker::setOcclusionInScreenSpace):
(WebCore::TestCCOcclusionTracker::setOcclusionInTargetSurface):
(WebCore::TEST):

10:42 Changeset [108520] by jsbell@chromium.org
  • 14 edits
    1 add in trunk/Source/WebCore

[Chromium] IndexedDB: Integrate with about:tracing
https://bugs.webkit.org/show_bug.cgi?id=78831

Annotate interesting IDB functions so they show up in the
tracing utility included in the Chromium port.

Reviewed by Tony Chang.

  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/v8/IDBBindingUtilities.cpp:

(WebCore::createIDBKeyFromSerializedValueAndKeyPath):
(WebCore::injectIDBKeyIntoSerializedValue):

  • storage/IDBCursor.cpp:

(WebCore::IDBCursor::direction):
(WebCore::IDBCursor::key):
(WebCore::IDBCursor::primaryKey):
(WebCore::IDBCursor::value):
(WebCore::IDBCursor::update):
(WebCore::IDBCursor::continueFunction):
(WebCore::IDBCursor::deleteFunction):

  • storage/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::direction):
(WebCore::IDBCursorBackendImpl::key):
(WebCore::IDBCursorBackendImpl::primaryKey):
(WebCore::IDBCursorBackendImpl::value):
(WebCore::IDBCursorBackendImpl::update):
(WebCore::IDBCursorBackendImpl::continueFunction):
(WebCore::IDBCursorBackendImpl::continueFunctionInternal):
(WebCore::IDBCursorBackendImpl::deleteFunction):
(WebCore::IDBCursorBackendImpl::prefetchContinue):
(WebCore::IDBCursorBackendImpl::prefetchContinueInternal):
(WebCore::IDBCursorBackendImpl::prefetchReset):
(WebCore::IDBCursorBackendImpl::close):

  • storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::dispatchEvent):

  • storage/IDBIndex.cpp:

(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::count):
(WebCore::IDBIndex::openKeyCursor):
(WebCore::IDBIndex::get):
(WebCore::IDBIndex::getKey):

  • storage/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::openCursorInternal):
(WebCore::IDBIndexBackendImpl::openCursor):
(WebCore::IDBIndexBackendImpl::openKeyCursor):
(WebCore::IDBIndexBackendImpl::countInternal):
(WebCore::IDBIndexBackendImpl::count):
(WebCore::IDBIndexBackendImpl::getInternal):
(WebCore::IDBIndexBackendImpl::get):
(WebCore::IDBIndexBackendImpl::getKey):

  • storage/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::name):
(WebCore::IDBObjectStore::keyPath):
(WebCore::IDBObjectStore::indexNames):
(WebCore::IDBObjectStore::transaction):
(WebCore::IDBObjectStore::get):
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::deleteFunction):
(WebCore::IDBObjectStore::clear):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::openCursor):
(WebCore::IDBObjectStore::count):

  • storage/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::get):
(WebCore::IDBObjectStoreBackendImpl::getInternal):
(WebCore::fetchKeyFromKeyPath):
(WebCore::injectKeyIntoKeyPath):
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteFunction):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):
(WebCore::IDBObjectStoreBackendImpl::clear):
(WebCore::IDBObjectStoreBackendImpl::openCursor):
(WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
(WebCore::IDBObjectStoreBackendImpl::count):
(WebCore::IDBObjectStoreBackendImpl::countInternal):

  • storage/IDBRequest.cpp:

(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::onSuccessWithContinuation):
(WebCore::IDBRequest::dispatchEvent):

  • storage/IDBTracing.h: Added.
  • storage/IDBTransaction.cpp:

(WebCore::IDBTransaction::dispatchEvent):

  • storage/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::abort):
(WebCore::IDBTransactionBackendImpl::commit):
(WebCore::IDBTransactionBackendImpl::taskTimerFired):
(WebCore::IDBTransactionBackendImpl::taskEventTimerFired):

10:38 Changeset [108519] by evan@chromium.org
  • 2 edits
    3 copies in branches/chromium/1025

Merge 107862 - REGRESSION(r105057): Dynamically changing <tspan> offsets is broken
https://bugs.webkit.org/show_bug.cgi?id=78385
<rdar://problem/10832932>

Reviewed by Simon Fraser.

Don't short-circuit buildLayoutAttributesIfNeeded if m_textPositions is already full;
we can't skip rebuilding the layout attributes, just walking the tree to acquire the
positioning lists (invalidation of positioning lists is already covered by textDOMChanged).

Test: svg/text/tspan-dynamic-positioning.svg

  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp:

(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesIfNeeded):

Add a test ensuring that changing the offset of a <tspan> post-load results in correct layout.

  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/text/tspan-dynamic-positioning-expected.png: Added.
  • platform/mac/svg/text/tspan-dynamic-positioning-expected.txt: Added.
  • svg/text/tspan-dynamic-positioning.svg: Added.

TBR=timothy_horton@apple.com
Review URL: https://chromiumcodereview.appspot.com/9429058

10:35 Changeset [108518] by commit-queue@webkit.org
  • 4 edits
    1 delete in trunk/Source/WebCore

[chromium] Push CCLayerIteratorPosition struct into CCLayerIterator class.
https://bugs.webkit.org/show_bug.cgi?id=75864

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-22
Reviewed by James Robinson.

  • platform/graphics/chromium/cc/CCLayerIterator.cpp:

(WebCore::CCLayerIteratorActions::BackToFront::begin):
(WebCore::CCLayerIteratorActions::BackToFront::end):
(WebCore::CCLayerIteratorActions::BackToFront::next):
(WebCore::CCLayerIteratorActions::FrontToBack::begin):
(WebCore::CCLayerIteratorActions::FrontToBack::end):
(WebCore::CCLayerIteratorActions::FrontToBack::next):
(WebCore::CCLayerIteratorActions::FrontToBack::goToHighestInSubtree):

  • platform/graphics/chromium/cc/CCLayerIterator.h:

(WebCore::CCLayerIterator::CCLayerIterator):
(WebCore::CCLayerIterator::operator++):
(WebCore::CCLayerIterator::operator==):
(WebCore::CCLayerIterator::operator->):
(WebCore::CCLayerIterator::operator*):
(WebCore::CCLayerIterator::representsTargetRenderSurface):
(WebCore::CCLayerIterator::representsContributingRenderSurface):
(WebCore::CCLayerIterator::currentLayer):
(WebCore::CCLayerIterator::currentLayerRepresentsContributingRenderSurface):
(WebCore::CCLayerIterator::currentLayerRepresentsTargetRenderSurface):
(WebCore::CCLayerIterator::targetRenderSurfaceLayer):
(WebCore::CCLayerIterator::targetRenderSurface):
(WebCore::CCLayerIterator::targetRenderSurfaceChildren):

  • platform/graphics/chromium/cc/CCLayerIteratorPosition.h: Removed.
10:35 Changeset [108517] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Marking svg failures from r108494.
https://bugs.webkit.org/show_bug.cgi?id=41386

  • platform/chromium/test_expectations.txt:
10:25 Changeset [108516] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Update Linux ChromiumOS builders in flakiness dashboard.
https://bugs.webkit.org/show_bug.cgi?id=79238

Patch by Rob Flack <flackr@chromium.org> on 2012-02-22
Reviewed by Ojan Vafai.

  • TestResultServer/static-dashboards/builders.js:
10:19 Changeset [108515] by dpranke@chromium.org
  • 2 edits in trunk/Tools

webkitpy: test_function_length_check_definition_huge_lines is slow
https://bugs.webkit.org/show_bug.cgi?id=79185

Reviewed by Adam Barth.

This test takes ~3 seconds to run, apparently because we're
running a test on a 10,000 line function :). Dropping the
function length to 640 still exercises the code path and
provides a 10x speedup.

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(CppStyleTest):
(CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines):

10:17 WebKitGTK/1.8.x edited by sergio@webkit.org
(diff)
10:16 Changeset [108514] by dpranke@chromium.org
  • 3 edits in trunk/Tools

webkitpy: speed up FileLockTest.test_lock_lifecycle
https://bugs.webkit.org/show_bug.cgi?id=79189

Reviewed by Adam Barth.

The unit test had a second lock trying to acquire a
lock already held, and a hard-coded timeout of one second.
I have changed the timeouts to a tenth of a second (which
is probably still fine) and changed the hard-spin on
the lock to a slow-spin every hundredth of a second.

  • Scripts/webkitpy/common/system/file_lock.py:

(FileLock.acquire_lock):

  • Scripts/webkitpy/common/system/file_lock_integrationtest.py:

(FileLockTest.setUp):
(FileLockTest.test_stuck_lock):

10:10 Changeset [108513] by rgabor@webkit.org
  • 2 edits in trunk/Tools

build-webkit should use environment variable at number of CPU
detection on all platform
https://bugs.webkit.org/show_bug.cgi?id=79227

Reviewed by Martin Robinson.

  • Scripts/webkitdirs.pm:

(determineNumberOfCPUs):

09:44 Changeset [108512] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

[GTK][WK2] Add WebGL WebSetting.
https://bugs.webkit.org/show_bug.cgi?id=79217

Patch by Antaryami Pandia <antaryami.pandia@motorola.com> on 2012-02-22
Reviewed by Martin Robinson.

Add a WebSetting to enable/disable Webgl.

  • UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_set_enable_webaudio):
(webkit_settings_get_enable_webgl):
(webkit_settings_set_enable_webgl):

  • UIProcess/API/gtk/WebKitSettings.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings):

09:39 Changeset [108511] by pfeldman@chromium.org
  • 8 edits in trunk

Web Inspector: console doesn't show properly arrays from which tail values have been deleted
https://bugs.webkit.org/show_bug.cgi?id=79242

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._printArray.appendUndefined):
(WebInspector.ConsoleMessageImpl.prototype._printArray):

LayoutTests:

  • inspector/console/console-format-expected.txt:
  • inspector/console/console-format.html:
  • platform/chromium/inspector/console/console-format-collections-expected.txt:
  • platform/chromium/inspector/console/console-format-expected.txt:
09:26 Changeset [108510] by pfeldman@chromium.org
  • 1 edit
    2 copies in branches/chromium/1025

Merge 107681 - Web Inspector: [REGRESSION] Copy Stack Trace is broken
https://bugs.webkit.org/show_bug.cgi?id=78583

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/debugger/copy-stack-trace.html

  • inspector/front-end/CallStackSidebarPane.js:

(WebInspector.CallStackSidebarPane.prototype._copyStackTrace):

LayoutTests:

  • inspector/debugger/copy-stack-trace-expected.txt: Added.
  • inspector/debugger/copy-stack-trace.html: Added.

TBR=pfeldman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9430052

09:09 Changeset [108509] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: warning external font mime (font/font/woff).
https://bugs.webkit.org/show_bug.cgi?id=79244

Reviewed by Yury Semikhatsky.

  • inspector/front-end/Resource.js:
09:05 Changeset [108508] by yurys@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: use dots as markers on the counter graphs
https://bugs.webkit.org/show_bug.cgi?id=79243

Changed counter graphs marker and counter text styles.

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/MemoryStatistics.js:

(WebInspector.MemoryStatistics):
(WebInspector.MemoryStatistics.prototype._createCounterSidebarElement):
(WebInspector.MemoryStatistics.prototype.addTimlineEvent):
(WebInspector.MemoryStatistics.prototype._draw):
(WebInspector.MemoryStatistics.prototype._onMouseOut):
(WebInspector.MemoryStatistics.prototype._onMouseOver):
(WebInspector.MemoryStatistics.prototype._onMouseMove):
(WebInspector.MemoryStatistics.prototype._refreshCurrentValues):
(WebInspector.MemoryStatistics.prototype._recordIndexAt):
(WebInspector.MemoryStatistics.prototype._highlightCurrentPositionOnGraphs):
(WebInspector.MemoryStatistics.prototype._clearMarkers):
(WebInspector.MemoryStatistics.prototype._saveImageUnderMarker):
(WebInspector.MemoryStatistics.prototype.refresh):
(WebInspector.MemoryStatistics.prototype._drawPolyline):
(WebInspector.MemoryStatistics.prototype._clear):

  • inspector/front-end/timelinePanel.css:

(.memory-counter-sidebar-info):
(.memory-counter-sidebar-info .title):
(.memory-counter-sidebar-info .counter-value):

08:54 Changeset [108507] by pfeldman@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: make 'glue asynchronous events' optional.
https://bugs.webkit.org/show_bug.cgi?id=79240

Reviewed by Yury Semikhatsky.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/Images/statusbarButtonGlyphs.png:
  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype.get statusBarItems):
(WebInspector.TimelinePanel.prototype._createStatusbarButtons):
(WebInspector.TimelinePanel.prototype._glueParentButtonClicked):
(WebInspector.TimelinePanel.prototype._toggleStartAtZeroButtonClicked):
(WebInspector.TimelinePanel.prototype._repopulateRecords):
(WebInspector.TimelinePanel.prototype._findParentRecord):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype.sidebarResized):
(WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages):
(WebInspector.TimelineCalculator.prototype.computeBarGraphWindowPosition):
(WebInspector.TimelineRecordGraphRow):
(WebInspector.TimelineRecordGraphRow.prototype.update):
(WebInspector.TimelinePanel.FormattedRecord.prototype._calculateAggregatedStats):

  • inspector/front-end/timelinePanel.css:

(.glue-async-status-bar-item .glyph):
(.timeline-start-at-zero-status-bar-item .glyph):

08:47 Changeset [108506] by vsevik@chromium.org
  • 4 edits
    2 adds in trunk

Web Inspector: [REGRESSION] Console xhr logging is broken for async xhrs since r107672.
https://bugs.webkit.org/show_bug.cgi?id=79229

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/console-xhr-logging-async.html

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::setInitialScriptContent):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::didFinishLoading):

LayoutTests:

  • http/tests/inspector/console-xhr-logging-async-expected.txt: Added.
  • http/tests/inspector/console-xhr-logging-async.html: Added.
08:29 Changeset [108505] by mihnea@adobe.com
  • 12 edits in trunk

[Qt] REGRESSION(r108108): It made 3 fast/repaint tests fail
https://bugs.webkit.org/show_bug.cgi?id=78960

Reviewed by Csaba Osztrogonác.

Source/WebKit/qt:

  • Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):
(QWebSettings::QWebSettings):

  • Api/qwebsettings.h:

Tools:

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::overridePreference):

LayoutTests:

  • fast/repaint/japanese-rl-selection-repaint-in-regions.html:
  • fast/repaint/line-flow-with-floats-in-regions.html:
  • fast/repaint/overflow-flipped-writing-mode-block-in-regions.html:
  • fast/repaint/region-painting-invalidation.html:
  • fast/repaint/region-painting-via-layout.html:
  • platform/qt/Skipped:
08:08 Changeset [108504] by caseq@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: fix memory counters and start-at-zero modes of timeline panels to co-exist nicely
https://bugs.webkit.org/show_bug.cgi?id=79241

Reviewed by Yury Semikhatsky.

  • inspector/front-end/MemoryStatistics.js:

(WebInspector.MemoryStatistics.prototype.addTimlineEvent):

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype._showTimelines):
(WebInspector.TimelineOverviewPane.prototype._showMemoryGraph):
(WebInspector.TimelineOverviewPane.prototype.setStartAtZero):
(WebInspector.TimelineOverviewPane.prototype._onWindowChanged):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._timelinesOverviewModeChanged):

07:42 Changeset [108503] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

[Chromium] video-referer.html fails
https://bugs.webkit.org/show_bug.cgi?id=79239

Unreviewed, skipping a test that started to fail after r108387.

  • platform/chromium/test_expectations.txt:
07:16 Changeset [108502] by caseq@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: [experimental] add a mode to display timeline events aligned by the start time
https://bugs.webkit.org/show_bug.cgi?id=79123

Reviewed by Pavel Feldman.

  • inspector/front-end/Images/statusbarButtonGlyphs.png:
  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype._showTimelines):
(WebInspector.TimelineOverviewPane.prototype._showMemoryGraph):
(WebInspector.TimelineOverviewPane.prototype._onWindowChanged):
(WebInspector.TimelineOverviewPane.prototype.setStartAtZero):
(WebInspector.TimelineOverviewPane.prototype.update):
(WebInspector.TimelineOverviewPane.prototype.reset):
(WebInspector.TimelineOverviewWindow):
(WebInspector.TimelineOverviewWindow.prototype.reset):
(WebInspector.TimelineOverviewWindow.prototype._setWindowPosition):
(WebInspector.TimelineOverviewWindow.prototype.scrollWindow):
(WebInspector.TimelineStartAtZeroOverview):
(WebInspector.TimelineStartAtZeroOverview.prototype.reset):
(WebInspector.TimelineStartAtZeroOverview.prototype.update):
(WebInspector.TimelineStartAtZeroOverview.prototype._filterRecords):
(WebInspector.TimelineStartAtZeroOverview.prototype._buildBar):
(WebInspector.TimelineStartAtZeroOverview.prototype._onWindowChanged):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype.get statusBarItems):
(WebInspector.TimelinePanel.prototype._createStatusbarButtons):
(WebInspector.TimelinePanel.prototype._toggleStartAtZeroButtonClicked):
(WebInspector.TimelinePanel.prototype.get _startAtZero):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype.sidebarResized):
(WebInspector.TimelinePanel.prototype._onRecordsCleared):
(WebInspector.TimelinePanel.prototype._resetPanel):
(WebInspector.TimelinePanel.prototype._scheduleRefresh):
(WebInspector.TimelinePanel.prototype._refresh):
(WebInspector.TimelinePanel.prototype._filterRecords):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelineCalculator.prototype.computeBarGraphWindowPosition):
(WebInspector.TimelineStartAtZeroCalculator):
(WebInspector.TimelineStartAtZeroCalculator.prototype.computeBarGraphPercentages):
(WebInspector.TimelineStartAtZeroCalculator.prototype.computeBarGraphWindowPosition):
(WebInspector.TimelineStartAtZeroCalculator.prototype.calculateWindow):
(WebInspector.TimelineStartAtZeroCalculator.prototype.reset):
(WebInspector.TimelineStartAtZeroCalculator.prototype.updateBoundaries):
(WebInspector.TimelineStartAtZeroCalculator.prototype.formatValue):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generateAggregatedInfo):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._calculateAggregatedStats):
(WebInspector.TimelinePanel.FormattedRecord.prototype.get aggregatedStats):
(WebInspector.TimelineModel.prototype.get records):
(WebInspector.TimelinePresentationModel):
(WebInspector.TimelinePresentationModel.prototype.reset):
(WebInspector.TimelinePresentationModel.prototype.setWindowIndices):
(WebInspector.TimelineRecordFilter):
(WebInspector.TimelineRecordFilter.prototype.accept):
(WebInspector.TimelineStartAtZeroRecordFilter):
(WebInspector.TimelineStartAtZeroRecordFilter.prototype.accept):

  • inspector/front-end/timelinePanel.css:

(.timeline-start-at-zero #timeline-overview-sidebar):
(.timeline-start-at-zero #timeline-overview-grid):
(.timeline-overview-window):
(.timeline-start-at-zero .timeline-overview-window):
(.timeline-start-at-zero .timeline-overview-dividers-background):
(.timeline-overview-window-rulers):
(.timeline-start-at-zero #timeline-overview-memory):
(.popover .timeline-loading):
(.popover .timeline-scripting):
(.popover .timeline-rendering):
(.timeline-start-at-zero-status-bar-item .glyph):
(.timeline-start-at-zero-status-bar-item.toggled-on .glyph):
(.timeline-overview-start-at-zero):
(.timeline-overview-start-at-zero-bars):
(.timeline-overview-start-at-zero-bars .padding):
(.timeline-overview-start-at-zero-bars .timeline-bar-vertical):
(.timeline-bar-vertical div:first-child):
(.timeline-bar-vertical .timeline-loading):
(.timeline-bar-vertical .timeline-scripting):
(.timeline-bar-vertical .timeline-rendering):

07:15 Changeset [108501] by kenneth@webkit.org
  • 5 edits in trunk/Source

[Qt] Disregard previous backing store as soon as possible https://bugs.webkit.org/show_bug.cgi?id=79232

Reviewed by Simon Hausmann and No'am Rosenthal.

Source/WebCore:

Make it possible to drop non-visible tiles and to test
if the current visible rect is fully covered.

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::visibleContentsRect):
(WebCore::TiledBackingStore::coverageRatio):
(WebCore::TiledBackingStore::visibleAreaIsCovered):
(WebCore):
(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::removeAllNonVisibleTiles):

  • platform/graphics/TiledBackingStore.h:

(TiledBackingStore):

Source/WebKit2:

Between creating the new backing store and painting the content,
we do not want to drop the previous one as that might result in
briefly seeing flickering as the old tiles may be dropped before
something replaces them.

But we do need to drop it at some point and we need to make sure
to not spike the memory usage before of this.

What we now do, is to store the previous backing store as before,
but drop all tiles which are not visible and then drop it as soon
as the visible rect (which might change due if followed by a quick
panning) has been fully covered by tiles.

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::setContentsScale):
(WebCore::WebGraphicsLayer::updateContentBuffers):

07:12 Changeset [108500] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, skipping one more mediastream failure on GTK.

  • platform/gtk/Skipped:
07:11 Changeset [108499] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] Implement proxy authentication handling.
https://bugs.webkit.org/show_bug.cgi?id=78792

Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-02-22
Reviewed by Simon Hausmann.

This patch corrects two bugs with the previous implementation:

  1. The signal proxyAuthenticationRequired was not connected to a slot.
  2. The slot onProxyAuthenticationRequired had the wrong parameters.
  • WebProcess/qt/QtNetworkAccessManager.cpp:

(WebKit::QtNetworkAccessManager::QtNetworkAccessManager):
(WebKit::QtNetworkAccessManager::onProxyAuthenticationRequired):

  • WebProcess/qt/QtNetworkAccessManager.h: Added include.

(QtNetworkAccessManager):

07:10 Changeset [108498] by hausmann@webkit.org
  • 5 edits
    1 delete in trunk/Source

[Qt] Move QMenu dependant scrollbar context menu handling out of WebCore
https://bugs.webkit.org/show_bug.cgi?id=79233

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Move the code into WebKit/qt/Api/qwebpage.cpp, the only place where it is called from.

  • Target.pri: Remove ScrollbarQt.cpp from build.
  • platform/Scrollbar.h: Remove Qt-only context menu handling but make moveThum

accessible from the outside.

  • platform/qt/ScrollbarQt.cpp: Removed. Not needed anymore.

Source/WebKit/qt:

Move scrollbar context menu handling here, it's the only place where it is
used.

  • Api/qwebpage.cpp:

(handleScrollbarContextMenuEvent):
(QWebPage::swallowContextMenuEvent):

07:07 Changeset [108497] by vsevik@chromium.org
  • 6 edits
    6 adds in trunk

Web Inspector: retrieving content for some XHR requests crashes inspected page renderer
https://bugs.webkit.org/show_bug.cgi?id=79026

Reviewed by Pavel Feldman.

Source/WebCore:

Fixed loading empty xhr content and xhr content decoding that was
broken in r107672.

Tests: http/tests/inspector/network/network-cyrillic-xhr.html

http/tests/inspector/network/network-empty-xhr.html

  • inspector/InspectorPageAgent.cpp:

(WebCore):
(WebCore::InspectorPageAgent::createDecoder):
(WebCore::InspectorPageAgent::cachedResourceContent):

  • inspector/InspectorPageAgent.h:

(WebCore):

  • inspector/NetworkResourcesData.cpp:

(WebCore::NetworkResourcesData::ResourceData::decodeDataToContent):
(WebCore::NetworkResourcesData::responseReceived):

  • inspector/NetworkResourcesData.h:

(WebCore::NetworkResourcesData::ResourceData::decoder):
(WebCore::NetworkResourcesData::ResourceData::setDecoder):

LayoutTests:

  • http/tests/inspector/network/network-cyrillic-xhr-expected.txt: Added.
  • http/tests/inspector/network/network-cyrillic-xhr.html: Added.
  • http/tests/inspector/network/network-empty-xhr-expected.txt: Added.
  • http/tests/inspector/network/network-empty-xhr.html: Added.
  • http/tests/inspector/network/resources/cyrillic.html: Added.
  • http/tests/inspector/network/resources/empty.html: Added.
07:05 Changeset [108496] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: remove neural-net-style constructions
https://bugs.webkit.org/show_bug.cgi?id=79153

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-22
Reviewed by Yury Semikhatsky.

CParamType class removed completely, some ("virtual") methods are
removed. TypeModel notion is added instead with some minor helper
classes and methods.

  • inspector/CodeGeneratorInspector.py:

(DomainNameFixes):
(RawTypes.BaseType):
(RawTypes.String):
(RawTypes.String.get_raw_type_model):
(RawTypes.Int):
(RawTypes.Int.get_raw_type_model):
(RawTypes.Number):
(RawTypes.Number.get_raw_type_model):
(RawTypes.Bool):
(RawTypes.Bool.get_raw_type_model):
(RawTypes.Object):
(RawTypes.Object.get_raw_type_model):
(RawTypes.Any):
(RawTypes.Any.get_raw_type_model):
(RawTypes.Array):
(RawTypes.Array.get_raw_type_model):
(replace_right_shift):
(CommandReturnPassModel):
(CommandReturnPassModel.ByReference):
(CommandReturnPassModel.ByReference.init):
(CommandReturnPassModel.ByReference.get_return_var_type):
(CommandReturnPassModel.get_output_argument_prefix):
(CommandReturnPassModel.get_output_to_raw_expression):
(CommandReturnPassModel.get_output_parameter_type):
(CommandReturnPassModel.get_set_return_condition):
(CommandReturnPassModel.ByPointer):
(CommandReturnPassModel.ByPointer.init):
(CommandReturnPassModel.ByPointer.get_return_var_type):
(TypeModel):
(TypeModel.RefPtrBased):
(TypeModel.RefPtrBased.init):
(TypeModel.RefPtrBased.get_optional):
(TypeModel.RefPtrBased.get_command_return_pass_model):
(TypeModel.RefPtrBased.get_input_param_type_text):
(TypeModel.RefPtrBased.get_event_setter_expression_pattern):
(TypeModel.Enum):
(TypeModel.Enum.init):
(TypeModel.Enum.get_optional):
(TypeModel.Enum.get_optional.EnumOptional):
(TypeModel.Enum.get_optional.EnumOptional.get_optional):
(TypeModel.Enum.get_optional.EnumOptional.get_command_return_pass_model):
(TypeModel.Enum.get_input_param_type_text):
(TypeModel.Enum.get_event_setter_expression_pattern):
(TypeModel.Enum.get_command_return_pass_model):
(TypeModel.ValueType):
(TypeModel.ValueType.init):
(TypeModel.ValueType.get_optional):
(TypeModel.ValueType.get_command_return_pass_model):
(TypeModel.ValueType.get_input_param_type_text):
(TypeModel.ValueType.get_event_setter_expression_pattern):
(TypeModel.ValueType.ValueOptional):
(TypeModel.ValueType.ValueOptional.init):
(TypeModel.ValueType.ValueOptional.get_optional):
(TypeModel.ValueType.ValueOptional.get_command_return_pass_model):
(TypeModel.ValueType.ValueOptional.get_input_param_type_text):
(TypeModel.ValueType.ValueOptional.get_event_setter_expression_pattern):
(TypeModel.init_class):
(TypeBindings.create_ad_hoc_type_declaration.Helper):
(TypeBindings.create_type_declaration_.EnumBinding.get_array_item_c_type_text):
(TypeBindings.create_type_declaration_.EnumBinding.get_setter_value_expression_pattern):
(TypeBindings.create_type_declaration_.EnumBinding):
(TypeBindings.create_type_declaration_.EnumBinding.get_type_model):
(TypeBindings.create_type_declaration_):
(TypeBindings.create_type_declaration_.get_type_model):
(TypeBindings.create_type_declaration_.get_array_item_c_type_text):
(get_type_model):
(AdHocTypeContextImpl.init):
(PlainObjectBinding):
(PlainObjectBinding.get_type_model):
(AdHocTypeContext):
(ArrayBinding.get_array_item_c_type_text):
(ArrayBinding):
(ArrayBinding.get_type_model):
(RawTypeBinding.get_validator_call_text):
(RawTypeBinding.reduce_to_raw_type):
(RawTypeBinding):
(RawTypeBinding.get_type_model):
(MethodGenerateModes.StrictParameterMode.get_c_param_type_text):
(MethodGenerateModes.RawParameterMode.get_c_param_type_text):
(MethodGenerateModes.CombinedMode.get_c_param_type_text):
(Generator.go):
(Generator.process_event):
(Generator.process_command):
(Generator.resolve_type_and_generate_ad_hoc):
(Generator.resolve_type_and_generate_ad_hoc.AdHocTypeContext):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::didParseSource):

07:00 Changeset [108495] by vsevik@chromium.org
  • 14 edits
    2 adds in trunk

Web Inspector: [InspectorIndexedDB] Show IndexedDB views on selection IndexedDB elements in resources panel.
https://bugs.webkit.org/show_bug.cgi?id=79098

Reviewed by Pavel Feldman.

Source/WebCore:

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):

  • inspector/compile-front-end.sh:
  • inspector/front-end/IndexedDBModel.js:

(WebInspector.IndexedDBModel.prototype._assertFrameId):
(WebInspector.IndexedDBModel.prototype.loadObjectStoreData):
(WebInspector.IndexedDBModel.prototype.loadIndexData):

  • inspector/front-end/IndexedDBViews.js: Added.
  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertiesSection):
(WebInspector.ObjectPropertiesSection.prototype.updateProperties):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.showIndexedDB):
(WebInspector.IndexedDBTreeElement.prototype.refreshIndexedDB):
(WebInspector.IndexedDBTreeElement.prototype._indexedDBAdded):
(WebInspector.IDBDatabaseTreeElement):
(WebInspector.IDBDatabaseTreeElement.prototype.get itemURL):
(WebInspector.IDBDatabaseTreeElement.prototype.update):
(WebInspector.IDBDatabaseTreeElement.prototype.onselect):
(WebInspector.IDBObjectStoreTreeElement):
(WebInspector.IDBObjectStoreTreeElement.prototype.get itemURL):
(WebInspector.IDBObjectStoreTreeElement.prototype.update):
(WebInspector.IDBObjectStoreTreeElement.prototype.onselect):
(WebInspector.IDBIndexTreeElement):
(WebInspector.IDBIndexTreeElement.prototype.get itemURL):
(WebInspector.IDBIndexTreeElement.prototype.update):
(WebInspector.IDBIndexTreeElement.prototype.onselect):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/externs.js:
  • inspector/front-end/indexedDBViews.css: Added.
  • inspector/front-end/inspector.html:

LayoutTests:

  • http/tests/inspector/indexeddb/database-data.html:
06:49 Changeset [108494] by zimmermann@webkit.org
  • 6 edits
    21 adds in trunk

REGRESSION(58212): html foreignObjects with positions other than static not hidden correctly when parent has display:none
https://bugs.webkit.org/show_bug.cgi?id=41386

Reviewed by Zoltan Herczeg.

Source/WebCore:

r58212 gave SVGGElements a renderer, regardless if "display: none" was set or not, for various reasons (see change set).
The <g> renderer for such cases is a RenderSVGHiddenContainer. We make sure in SVG that such subtrees are never used
for painting & hittesting - they only exist for the purpose of SVG DOM (query getCTM, etc..) and to create renderers
for child resources, like <g display="none"><linearGradient>.

This concept still works fine for: <g display="none"><foreignObject><body>Foobar</body></foreignObject></g>, as
RenderSVGForeignObject::paint is never called thus we never paint the subtree of the <fO>. If the <body> elements
contains "position: relative" a new layer is created for the <body>. When the document paints we have two seperated
layers, and the <body> layer doesn't know that it's actually inside a "SVG hidden subtree", and gets painted, where it
shouldn't. HTML doesn't have this problems, as a display: none object, never creates a renderer.

The fix is to disallow layer creation in hidden SVG subtrees, to mimic what would happen if we'd follow HTML rules
to not create renderers for display: none objects. This avoids any indirections - as no layers are created anymore.

Tests: svg/foreignObject/fO-display-none-with-relative-pos-content.svg

svg/foreignObject/fO-display-none.svg
svg/foreignObject/fO-parent-display-changes.svg
svg/foreignObject/fO-parent-display-none-with-relative-pos-content.svg
svg/foreignObject/fO-parent-display-none.svg
svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content.svg
svg/foreignObject/fO-parent-of-parent-display-none.svg

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::styleDidChange): Only create layers, if its allowed -- layerCreationAllowedForSubtree() will always return true for HTML, and only false for layers inside a hidden SVG subtree.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::addChild): Only create layers, if its allowed.

  • rendering/RenderObject.h: Add inline layerCreationAllowedForSubtree() helper, that craws the tree to find a RenderSVGHiddenContainer ancestor, if not present, return true.

LayoutTests:

Add new tests covering <foreignObject> content inside a <g display="none">.

  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/foreignObject/fO-display-none-expected.png: Added.
  • platform/mac/svg/foreignObject/fO-display-none-expected.txt: Added.
  • platform/mac/svg/foreignObject/fO-display-none-with-relative-pos-content-expected.png: Added.
  • platform/mac/svg/foreignObject/fO-display-none-with-relative-pos-content-expected.txt: Added.
  • platform/mac/svg/foreignObject/fO-parent-display-changes-expected.png: Added.
  • platform/mac/svg/foreignObject/fO-parent-display-changes-expected.txt: Added.
  • platform/mac/svg/foreignObject/fO-parent-display-none-expected.png: Added.
  • platform/mac/svg/foreignObject/fO-parent-display-none-expected.txt: Added.
  • platform/mac/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.png: Added.
  • platform/mac/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt: Added.
  • platform/mac/svg/foreignObject/fO-parent-of-parent-display-none-expected.png: Added.
  • platform/mac/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt: Added.
  • platform/mac/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.png: Added.
  • platform/mac/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt: Added.
  • svg/foreignObject/fO-display-none-with-relative-pos-content.svg: Added.
  • svg/foreignObject/fO-display-none.svg: Added.
  • svg/foreignObject/fO-parent-display-changes.svg: Added.
  • svg/foreignObject/fO-parent-display-none-with-relative-pos-content.svg: Added.
  • svg/foreignObject/fO-parent-display-none.svg: Added.
  • svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content.svg: Added.
  • svg/foreignObject/fO-parent-of-parent-display-none.svg: Added.
06:21 Changeset [108493] by zimmermann@webkit.org
  • 35 edits in trunk/LayoutTests

2012-02-22 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix SVG pixel test results, which now show up as hash failures, since DRT was fixed to report these.

  • platform/mac/svg/W3C-SVG-1.1/coords-units-03-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-02-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-text-04-t-expected.png:
  • platform/mac/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/mac/svg/clip-path/clip-in-mask-expected.png:
  • platform/mac/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png:
  • platform/mac/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png:
  • platform/mac/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png:
  • platform/mac/svg/custom/circular-marker-reference-2-expected.png:
  • platform/mac/svg/custom/glyph-selection-arabic-forms-expected.png:
  • platform/mac/svg/custom/glyph-selection-bidi-mirror-expected.png:
  • platform/mac/svg/custom/glyph-selection-non-bmp-expected.png:
  • platform/mac/svg/custom/gradient-rotated-bbox-expected.png:
  • platform/mac/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.png:
  • platform/mac/svg/custom/marker-opacity-expected.png:
  • platform/mac/svg/custom/non-circular-marker-reference-expected.png:
  • platform/mac/svg/dom/SVGLocatable-getCTM-svg-root-expected.png:
  • platform/mac/svg/hixie/error/017-expected.png:
  • platform/mac/svg/text/text-align-05-b-expected.png:
  • platform/mac/svg/text/text-path-01-b-expected.png:
  • platform/mac/svg/text/text-text-01-b-expected.png:
  • platform/mac/svg/text/text-text-07-t-expected.png:
  • platform/mac/svg/text/text-tselect-02-f-expected.png:
  • svg/as-image/svg-non-integer-scaled-image-expected.png:
  • svg/custom/visited-link-color-expected.png:
  • svg/custom/zero-path-square-cap-rendering2-expected.png:
  • svg/foreignObject/clip-expected.png:
  • svg/foreignObject/filter-expected.png:
  • svg/foreignObject/mask-expected.png:
06:18 Changeset [108492] by zherczeg@webkit.org
  • 2 edits in trunk/Source/WebCore

Drop clipToImageBuffer from RenderBoxModelObject
https://bugs.webkit.org/show_bug.cgi?id=79225

Reviewed by Nikolas Zimmermann.

-webkit-background-clip: text is a rarely used non-standard
feature uses clipToImageBuffer. It is replaced by
CompositeDestinationIn on a transparent layer. The new
approach has the same speed as the old one.

Existing tests cover this issue.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):

05:56 Changeset [108491] by kenneth@webkit.org
  • 7 edits in trunk/Source

Merge setVisibleRectTrajectoryVector and adjustVisibleRect to the more descriptive coverWithTilesIfNeeded https://bugs.webkit.org/show_bug.cgi?id=79230

Reviewed by Simon Hausmann.

Source/WebCore:

Both setVisibleRectTrajectoryVector and the adjustVisibleRect are
used for initiating re-tiling, so make that more obvious and merge
the two.

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::coverWithTilesIfNeeded):

  • platform/graphics/TiledBackingStore.h:

(TiledBackingStore):

Source/WebKit/qt:

  • Api/qgraphicswebview.cpp:

(QGraphicsWebView::paint):

Use coverWithTilesIfNeeded().

Source/WebKit2:

Replace use by coverWithTilesIfNeeded().

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::setVisibleContentRectTrajectoryVector):
(WebCore::WebGraphicsLayer::adjustVisibleRect):
(WebCore::WebGraphicsLayer::computeTransformedVisibleRect):

05:38 Changeset [108490] by zimmermann@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION: unbalanced transparency layers for clipPath
https://bugs.webkit.org/show_bug.cgi?id=78074

Reviewed by Zoltan Herczeg.

Source/WebCore:

If we're rendering to a mask image buffer, all children are rendered with opacity=1, regardless what their RenderStyles specify.
SVGRenderSupport::finishRenderSVGContent() did not take this into account and always called endTransparencyLayer(). Fix that
by checking if we're rendering to a mask image buffer, if so don't call endTransparencyLayer().

Add new reftest covering both the visual & logical correctness (no assertion).

Tests: svg/clip-path/opacity-assertion-expected.svg

svg/clip-path/opacity-assertion.svg

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::isRenderingMaskImage): Extraced as sharable helper function.
(WebCore::SVGRenderSupport::prepareToRenderSVGContent): Factor out isRenderingMaskImage() function.
(WebCore::SVGRenderSupport::finishRenderSVGContent): Only call endTransparencyLayer(), if we actually called beginTL() first.

LayoutTests:

  • svg/clip-path/opacity-assertion-expected.svg: Added.
  • svg/clip-path/opacity-assertion.svg: Added.
05:36 Changeset [108489] by kenneth@webkit.org
  • 2 edits in trunk/Source/WebCore

Improve comments in tiling code.

Rubberstamped by Simon Hausmann.

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::createTiles):

05:27 Changeset [108488] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

Not reviewed: build fix.

  • inspector/InspectorController.cpp:
  • inspector/InspectorController.h:

(InspectorController):

05:25 Changeset [108487] by commit-queue@webkit.org
  • 7 edits in trunk

[chromium] Build WebKit with MEDIA_STREAM disabled.
https://bugs.webkit.org/show_bug.cgi?id=79214

Patch by Hao Zheng <zhenghao@chromium.org> on 2012-02-22
Reviewed by Kent Tamura.

Source/WebKit/chromium:

  • src/UserMediaClientImpl.h:

Tools:

  • DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
  • DumpRenderTree/chromium/WebUserMediaClientMock.h:
  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createMediaPlayer):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

05:13 Changeset [108486] by pfeldman@chromium.org
  • 20 edits in trunk

Web Inspector: do not filter out requestAnimationFrame from timeline, implement stop on animation events.
https://bugs.webkit.org/show_bug.cgi?id=79116

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • English.lproj/localizedStrings.js:
  • dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::registerCallback):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didRequestAnimationFrameCallbackImpl):
(WebCore::InspectorInstrumentation::didCancelAnimationFrameCallbackImpl):
(WebCore::InspectorInstrumentation::willFireAnimationFrameEventImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didRequestAnimationFrameCallback):

  • inspector/InspectorTimelineAgent.cpp:

(TimelineRecordType):
(WebCore::InspectorTimelineAgent::didRequestAnimationFrameCallback):
(WebCore::InspectorTimelineAgent::didCancelAnimationFrameCallback):
(WebCore::InspectorTimelineAgent::willFireAnimationFrameEvent):
(WebCore::InspectorTimelineAgent::didFireAnimationFrameEvent):

  • inspector/InspectorTimelineAgent.h:

(InspectorTimelineAgent):

  • inspector/front-end/BreakpointsSidebarPane.js:

(WebInspector.EventListenerBreakpointsSidebarPane):
(WebInspector.EventListenerBreakpointsSidebarPane.eventNameForUI):

  • inspector/front-end/TimelineAgent.js:
  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype.get _recordStyles):
(WebInspector.TimelinePanel.prototype._findParentRecord):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype._onRecordsCleared):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):

LayoutTests:

  • inspector/timeline/timeline-animation-frame-expected.txt:
  • inspector/timeline/timeline-animation-frame.html:
  • inspector/timeline/timeline-enum-stability-expected.txt:
  • platform/chromium/inspector/timeline/timeline-animation-frame-expected.txt:
05:10 Changeset [108485] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove unused class declaration in WebCore/page/scrolling/ScrollingCoordinator.h
https://bugs.webkit.org/show_bug.cgi?id=79175

Patch by Changhun Kang <temoochin@company100.net> on 2012-02-22
Reviewed by Kentaro Hara.

  • page/scrolling/ScrollingCoordinator.h:

Remove PlatformGestureEvent class declaration.
(WebCore):

05:05 Changeset [108484] by ossy@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r108456.
http://trac.webkit.org/changeset/108456
https://bugs.webkit.org/show_bug.cgi?id=79223

Broke fast/regex/pcre-test-4.html and cannot find anyone on
IRC (Requested by zherczeg on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-22

  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::backtrackPatternCharacterGreedy):

04:56 Changeset [108483] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt][WK2] Fix the N9 build
https://bugs.webkit.org/show_bug.cgi?id=79101

Reviewed by Simon Hausmann.

Fixed the include order of the rolled out r108359 not to break
the build with CONFIG+=force_static_libs_as_shared.

  • platform/graphics/OpenGLShims.h: Add missing include.
04:51 Changeset [108482] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, regular maintenance of test expectations.

  • platform/chromium/test_expectations.txt:
04:47 WebKit Team edited by wingo@igalia.com
Remove duplicate entry for Enrica Casucci (diff)
04:20 Changeset [108481] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip a new failing test.

  • platform/qt/Skipped:
04:06 Changeset [108480] by shinyak@chromium.org
  • 9 edits in trunk

firstRendererOf() should also return a fallback element renderer in NodeRenderingContext.
https://bugs.webkit.org/show_bug.cgi?id=79180

Reviewed by Hajime Morita.

Source/WebCore:

Currently we have handled AttachingFallback in some special mannger, however if firstRendererOf
and lastRendererOf return a fallback element renderer, we don't need to handle it in such a manner.

We have introduced new attaching phase: AttachingFallbacked, and AttachingNotFallbacked.
They are used for fallback elements.

Added new test cases in:

fast/dom/shadow/shadow-contents-fallback.html
fast/dom/shadow/shadow-contents-fallback-dynamic.html

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::firstRendererOf):
(WebCore::lastRendererOf):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):
(WebCore::NodeRenderingContext::shouldCreateRenderer):

  • dom/NodeRenderingContext.h:
  • html/shadow/InsertionPoint.h:

(WebCore::isInsertionPoint):
(WebCore):
(WebCore::toInsertionPoint):

LayoutTests:

Added new test cases, e.g. <content> in <content>, with display:none.

  • fast/dom/shadow/shadow-contents-fallback-dynamic-expected.txt:
  • fast/dom/shadow/shadow-contents-fallback-dynamic.html:
  • fast/dom/shadow/shadow-contents-fallback-expected.txt:
  • fast/dom/shadow/shadow-contents-fallback.html:
03:46 Changeset [108479] by zeno.albisser@nokia.com
  • 2 edits in trunk/Tools

[Qt][WK2][Mac] WebKitTestRunner does not build with clang.
https://bugs.webkit.org/show_bug.cgi?id=79124

WebKitTestRunnerPrefix.h should also be included
when building with clang.

Reviewed by Kenneth Rohde Christiansen.

  • WebKitTestRunner/Target.pri:
03:38 Changeset [108478] by ossy@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Unreviewed gardening after r108464.

  • Target.pri:
03:21 Changeset [108477] by haraken@chromium.org
  • 1 edit
    4 adds in trunk/PerformanceTests

Add performance tests for the Element.id getter and setter
https://bugs.webkit.org/show_bug.cgi?id=79209

Reviewed by Adam Barth.

This patch adds performance tests for the Element.id getter and setter.

The results of 10 runs in my local Chromium/Linux are as follows:

dom_attributes_id_getter.html:
median= 92.0 ms, stdev= 1.65151445649 ms, min= 89.0 ms, max= 96.0 ms
median= 87.5 ms, stdev= 1.84390889146 ms, min= 85.0 ms, max= 92.0 ms
median= 94.0 ms, stdev= 1.46543508898 ms, min= 90.0 ms, max= 95.0 ms
median= 86.0 ms, stdev= 1.66958078571 ms, min= 84.0 ms, max= 91.0 ms
median= 94.0 ms, stdev= 2.25610283454 ms, min= 103.0 ms, max= 98.0 ms
median= 86.0 ms, stdev= 1.49666295471 ms, min= 84.0 ms, max= 91.0 ms
median= 86.0 ms, stdev= 1.5321553446 ms, min= 84.0 ms, max= 90.0 ms
median= 86.0 ms, stdev= 2.20227155455 ms, min= 84.0 ms, max= 94.0 ms
median= 96.0 ms, stdev= 1.74570902501 ms, min= 101.0 ms, max= 99.0 ms
median= 86.0 ms, stdev= 1.63935963108 ms, min= 84.0 ms, max= 90.0 ms
median= 94.0 ms, stdev= 1.49248115566 ms, min= 90.0 ms, max= 95.0 ms
median= 88.0 ms, stdev= 5.20192272146 ms, min= 84.0 ms, max= 98.0 ms
median= 86.0 ms, stdev= 1.41067359797 ms, min= 84.0 ms, max= 89.0 ms
median= 86.0 ms, stdev= 1.48660687473 ms, min= 84.0 ms, max= 89.0 ms
median= 94.0 ms, stdev= 1.58113883008 ms, min= 93.0 ms, max= 97.0 ms
median= 86.0 ms, stdev= 1.95959179423 ms, min= 84.0 ms, max= 93.0 ms
median= 86.0 ms, stdev= 1.8547236991 ms, min= 84.0 ms, max= 92.0 ms
median= 86.0 ms, stdev= 1.39283882772 ms, min= 84.0 ms, max= 89.0 ms
median= 88.0 ms, stdev= 1.48660687473 ms, min= 85.0 ms, max= 90.0 ms
median= 86.5 ms, stdev= 2.3 ms, min= 84.0 ms, max= 93.0 ms

dom_attributes_id_setter.html:
median= 123.0 ms, stdev= 2.06397674406 ms, min= 119.0 ms, max= 128.0 ms
median= 119.0 ms, stdev= 1.92028643697 ms, min= 117.0 ms, max= 123.0 ms
median= 121.0 ms, stdev= 1.8781639971 ms, min= 118.0 ms, max= 123.0 ms
median= 123.0 ms, stdev= 2.21585198062 ms, min= 119.0 ms, max= 130.0 ms
median= 124.5 ms, stdev= 2.36378933071 ms, min= 119.0 ms, max= 129.0 ms
median= 122.0 ms, stdev= 2.4474476501 ms, min= 118.0 ms, max= 128.0 ms
median= 123.0 ms, stdev= 1.76351920885 ms, min= 118.0 ms, max= 125.0 ms
median= 119.0 ms, stdev= 1.79652442232 ms, min= 117.0 ms, max= 125.0 ms
median= 121.0 ms, stdev= 1.49916643506 ms, min= 119.0 ms, max= 123.0 ms
median= 119.5 ms, stdev= 1.85135085816 ms, min= 117.0 ms, max= 125.0 ms
median= 124.0 ms, stdev= 1.43090880213 ms, min= 120.0 ms, max= 124.0 ms
median= 122.0 ms, stdev= 1.45859521458 ms, min= 118.0 ms, max= 123.0 ms
median= 123.0 ms, stdev= 1.50332963784 ms, min= 120.0 ms, max= 124.0 ms
median= 123.0 ms, stdev= 1.3638181697 ms, min= 120.0 ms, max= 125.0 ms
median= 119.0 ms, stdev= 1.43527000944 ms, min= 117.0 ms, max= 121.0 ms
median= 122.5 ms, stdev= 1.71682847134 ms, min= 118.0 ms, max= 124.0 ms
median= 121.0 ms, stdev= 1.44481832768 ms, min= 118.0 ms, max= 123.0 ms
median= 120.0 ms, stdev= 1.40978721799 ms, min= 117.0 ms, max= 122.0 ms
median= 122.0 ms, stdev= 1.68522995464 ms, min= 119.0 ms, max= 125.0 ms
median= 122.0 ms, stdev= 1.55804364509 ms, min= 118.0 ms, max= 123.0 ms

  • Bindings/dom_attributes_id_getter.html: Added.
  • Bindings/dom_attributes_id_setter.html: Added.
  • Bindings/resources/dom_attributes_common.js: Added.
03:20 Changeset [108476] by bashi@chromium.org
  • 15 edits
    13 deletes in trunk

Unreviewed, rolling out r108468.
http://trac.webkit.org/changeset/108468
https://bugs.webkit.org/show_bug.cgi?id=79219

Broke Chromium Win release build (Requested by bashi on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-22

Source/JavaScriptCore:

  • wtf/Platform.h:

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • websockets/WebSocket.cpp:

(WebCore::WebSocket::didConnect):

  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::connect):
(WebCore::WebSocketChannel::fail):
(WebCore::WebSocketChannel::processFrame):
(WebCore::WebSocketChannel::sendFrame):

  • websockets/WebSocketChannel.h:
  • websockets/WebSocketDeflateFramer.cpp: Removed.
  • websockets/WebSocketDeflateFramer.h: Removed.

LayoutTests:

  • http/tests/websocket/tests/hybi/compressed-control-frame-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/compressed-control-frame.html: Removed.
  • http/tests/websocket/tests/hybi/compressed-control-frame_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff.html: Removed.
  • http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter.html: Removed.
  • http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/deflate-frame-parameter-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/deflate-frame-parameter.html: Removed.
  • http/tests/websocket/tests/hybi/deflate-frame_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header-expected.txt:
  • http/tests/websocket/tests/hybi/send-file-blob_wsh.py:

(web_socket_transfer_data):

03:05 Changeset [108475] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK gardening, unskip 2 tests that should pass now.

  • platform/gtk/Skipped:
02:45 Changeset [108474] by rolandsteiner@chromium.org
  • 12 edits in trunk

<style scoped>: Add runtime-flag
https://bugs.webkit.org/show_bug.cgi?id=79074

Source/WebCore:

Added runtime-flag.
Query runtime flag when (un)registering a <style scoped> element, and when determineing a style sheet's scope.

Reviewed by Dimitri Glazkov.

No new tests. (no change in functionality)

  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::styleScopedEnabled):
(WebCore::RuntimeEnabledFeatures::setStyleScopedEnabled):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::determineScopingElement):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::registerWithScopingNode):
(WebCore::HTMLStyleElement::unregisterWithScopingNode):

  • html/HTMLStyleElement.idl:

Source/WebKit/chromium:

Added a runtime-flag.
Enable default STYLE_SCOPED compile-time flag for Chromium.

Reviewed by Dimitri Glazkov.

  • features.gypi: enable STYLE_SCOPED
  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableStyleScoped):
(WebKit):
(WebKit::WebRuntimeFeatures::isStyleScopedEnabled):

Tools:

Enable the runtime-flag for DRT.

Reviewed by Dimitri Glazkov.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

02:42 Changeset [108473] by apavlov@chromium.org
  • 7 edits in trunk

Web Inspector: Audit rules to recommend unprefixing supported CSS properties
https://bugs.webkit.org/show_bug.cgi?id=78985

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/AuditCategories.js:

(WebInspector.AuditCategories.PagePerformance.prototype.initialize):

  • inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.CSSRuleBase):
(WebInspector.AuditRules.CSSRuleBase.prototype.doRun.sheetsCallback):
(WebInspector.AuditRules.CSSRuleBase.prototype.doRun):
(WebInspector.AuditRules.CSSRuleBase.prototype._visitStyleSheet.sheetCallback):
(WebInspector.AuditRules.CSSRuleBase.prototype._visitStyleSheet):
(WebInspector.AuditRules.CSSRuleBase.prototype._visitRule):
(WebInspector.AuditRules.CSSRuleBase.prototype.visitStyleSheet):
(WebInspector.AuditRules.CSSRuleBase.prototype.didVisitStyleSheet):
(WebInspector.AuditRules.CSSRuleBase.prototype.visitRule):
(WebInspector.AuditRules.CSSRuleBase.prototype.didVisitRule):
(WebInspector.AuditRules.CSSRuleBase.prototype.visitProperty):
(WebInspector.AuditRules.VendorPrefixedCSSProperties):
(WebInspector.AuditRules.VendorPrefixedCSSProperties.prototype.didVisitStyleSheet):
(WebInspector.AuditRules.VendorPrefixedCSSProperties.prototype.visitRule):
(WebInspector.AuditRules.VendorPrefixedCSSProperties.prototype.didVisitRule):
(WebInspector.AuditRules.VendorPrefixedCSSProperties.prototype.visitProperty):

  • inspector/front-end/ResourceUtils.js:

LayoutTests:

  • inspector/audits/audits-panel-functional-expected.txt:
  • inspector/audits/audits-panel-functional.html:
02:20 Changeset [108472] by pfeldman@chromium.org
  • 1 edit in branches/chromium/1025/Source/WebCore/inspector/InspectorInstrumentation.cpp

Merge 106347 - Web Inspector: DOMDebugger.setEventListenerBreakpoint should accept regular DOM event names.
https://bugs.webkit.org/show_bug.cgi?id=77409

(Fixing merge 2)

Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::setEventListenerBreakpoint):
(WebCore):
(WebCore::InspectorDOMDebuggerAgent::setInstrumentationBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::setBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeEventListenerBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeInstrumentationBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):

  • inspector/InspectorDOMDebuggerAgent.h:

(InspectorDOMDebuggerAgent):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didInstallTimerImpl):
(WebCore::InspectorInstrumentation::didRemoveTimerImpl):
(WebCore::InspectorInstrumentation::willHandleEventImpl):
(WebCore::InspectorInstrumentation::willFireTimerImpl):
(WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):

  • inspector/front-end/BreakpointsSidebarPane.js:

(WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint):

TBR=pfeldman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9429046

02:17 Changeset [108471] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[Qt][WK2] Add frame flattening setting to QWebPreferences.
https://bugs.webkit.org/show_bug.cgi?id=79099

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-02-22
Reviewed by Simon Hausmann.

Frame flattening is enabled by default for Qt WebKit2.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize):

  • UIProcess/API/qt/qwebpreferences.cpp:

(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferences::setNavigatorQtObjectEnabled):
(QWebPreferences::frameFlatteningEnabled):
(QWebPreferences::setFrameFlatteningEnabled):

  • UIProcess/API/qt/qwebpreferences_p.h:
02:12 Changeset [108470] by shinyak@chromium.org
  • 2 edits in trunk/Source/WebCore

Node::attach() should be after attaching children in Element::attach().
https://bugs.webkit.org/show_bug.cgi?id=79201

Reviewed by Hajime Morita.

In Element::attach(), Node::attach() is called before attaching children if a shaodw root exists.
This may cause O(N2) problem in NodeRenderingContext.

No new tests. Existing tests should cover this.

  • dom/Element.cpp:

(WebCore::Element::attach):

02:04 Changeset [108469] by pfeldman@chromium.org
  • 1 edit in branches/chromium/1025/Source/WebCore/inspector/InspectorInstrumentation.cpp

Merge 106347 - Web Inspector: DOMDebugger.setEventListenerBreakpoint should accept regular DOM event names.
https://bugs.webkit.org/show_bug.cgi?id=77409

Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::setEventListenerBreakpoint):
(WebCore):
(WebCore::InspectorDOMDebuggerAgent::setInstrumentationBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::setBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeEventListenerBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeInstrumentationBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):

  • inspector/InspectorDOMDebuggerAgent.h:

(InspectorDOMDebuggerAgent):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didInstallTimerImpl):
(WebCore::InspectorInstrumentation::didRemoveTimerImpl):
(WebCore::InspectorInstrumentation::willHandleEventImpl):
(WebCore::InspectorInstrumentation::willFireTimerImpl):
(WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):

  • inspector/front-end/BreakpointsSidebarPane.js:

(WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint):

TBR=pfeldman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9429045

02:03 Changeset [108468] by bashi@chromium.org
  • 15 edits
    1 copy
    12 adds in trunk

Adding WebSocket per-frame DEFLATE extension
https://bugs.webkit.org/show_bug.cgi?id=77522

Source/JavaScriptCore:

Added USE(ZLIB) flag.

Reviewed by Kent Tamura.

  • wtf/Platform.h:

Source/WebCore:

Add WebSocketDeflateFramer class which handles deflate-frame extension.
This class encapsulates WebSocketDeflater and WebSocketInflater classes,
which depend on zlib, so that WebSocketChannel is not necessary to aware
zlib dependency.

Reviewed by Kent Tamura.

Tests: http/tests/websocket/tests/hybi/compressed-control-frame.html

http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff.html
http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter.html
http/tests/websocket/tests/hybi/deflate-frame-parameter.html

  • CMakeLists.txt: Added WebSocketDeflateFramer.(cpp|h)
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • websockets/WebSocket.cpp:

(WebCore::WebSocket::didConnect): Set m_extensions.

  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::connect): Add deflate-frame extension processor to WebSocketHanshake if deflate can use.
(WebCore::WebSocketChannel::fail): Call m_deflateFramer.didFail().
(WebCore::WebSocketChannel::processFrame): Decompress frames if needed.
(WebCore::WebSocketChannel::sendFrame): Compress frames if possible.

  • websockets/WebSocketChannel.h:
  • websockets/WebSocketDeflateFramer.cpp: Added.

(WebCore):
(WebSocketExtensionDeflateFrame):
(WebCore::WebSocketExtensionDeflateFrame::create):
(WebCore::WebSocketExtensionDeflateFrame::~WebSocketExtensionDeflateFrame):
(WebCore::WebSocketExtensionDeflateFrame::WebSocketExtensionDeflateFrame):
(WebCore::WebSocketExtensionDeflateFrame::handshakeString):
(WebCore::WebSocketExtensionDeflateFrame::processResponse):
(WebCore::DeflateResultHolder::DeflateResultHolder):
(WebCore::DeflateResultHolder::~DeflateResultHolder):
(WebCore::DeflateResultHolder::fail):
(WebCore::InflateResultHolder::InflateResultHolder):
(WebCore::InflateResultHolder::~InflateResultHolder):
(WebCore::InflateResultHolder::fail):
(WebCore::WebSocketDeflateFramer::WebSocketDeflateFramer):
(WebCore::WebSocketDeflateFramer::createExtensionProcessor):
(WebCore::WebSocketDeflateFramer::canDeflate):
(WebCore::WebSocketDeflateFramer::enableDeflate):
(WebCore::WebSocketDeflateFramer::deflate):
(WebCore::WebSocketDeflateFramer::resetDeflateContext):
(WebCore::WebSocketDeflateFramer::inflate):
(WebCore::WebSocketDeflateFramer::resetInflateContext):
(WebCore::WebSocketDeflateFramer::didFail):

  • websockets/WebSocketDeflateFramer.h: Added.

(WebCore):
(DeflateResultHolder):
(WebCore::DeflateResultHolder::succeeded):
(WebCore::DeflateResultHolder::failureReason):
(InflateResultHolder):
(WebCore::InflateResultHolder::succeeded):
(WebCore::InflateResultHolder::failureReason):
(WebSocketDeflateFramer):
(WebCore::WebSocketDeflateFramer::enabled):

LayoutTests:

Added tests for WebSocket deflate-frame extension. Also updated some
tests to follow the change.

Reviewed by Kent Tamura.

  • http/tests/websocket/tests/hybi/compressed-control-frame-expected.txt: Added.
  • http/tests/websocket/tests/hybi/compressed-control-frame.html: Added.
  • http/tests/websocket/tests/hybi/compressed-control-frame_wsh.py: Added.

(web_socket_do_extra_handshake):
(web_socket_transfer_data):

  • http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff-expected.txt: Added.
  • http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff.html: Added.
  • http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter-expected.txt: Added.
  • http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter.html: Added.
  • http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter_wsh.py: Added.

(web_socket_do_extra_handshake):
(web_socket_transfer_data):

  • http/tests/websocket/tests/hybi/deflate-frame-parameter-expected.txt: Added.
  • http/tests/websocket/tests/hybi/deflate-frame-parameter.html: Added.
  • http/tests/websocket/tests/hybi/deflate-frame_wsh.py: Added.

(_get_deflate_frame_extension_processor):
(web_socket_do_extra_handshake):
(web_socket_transfer_data):

  • http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header-expected.txt:
  • http/tests/websocket/tests/hybi/send-file-blob_wsh.py:

(_retrieve_frame):
(web_socket_transfer_data):

02:00 Changeset [108467] by yutak@chromium.org
  • 5 edits
    3 deletes in trunk/Source

Unreviewed, rolling out r108453.
http://trac.webkit.org/changeset/108453
https://bugs.webkit.org/show_bug.cgi?id=78549

Broke Chromium's webkit_unit_tests.

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp: Removed.
  • platform/graphics/chromium/cc/CCOcclusionTracker.h: Removed.

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCLayerTreeHostCommonTest.cpp:

(WebCore::TEST):
(WebCore):

  • tests/CCOcclusionTrackerTest.cpp: Removed.
01:56 Changeset [108466] by zherczeg@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] clipToImageBuffer assertion fix in debug mode on Qt.

Rubber stamped by Csaba Osztrogonác.

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::restorePlatformState):

01:45 Changeset [108465] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

[GTK] fast/frames/frame-dead-region.html crash
https://bugs.webkit.org/show_bug.cgi?id=79205

Unreviewed.

Apparently we're not supposed to call willDetachPage from
CachedFrame::destroy. This call got added in
http://trac.webkit.org/changeset/108428, but it seems to cause a crash.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::closeAndRemoveChild):
(WebCore::FrameLoader::detachFromParent):

  • page/Frame.h:

(WebCore::Frame::detachFromPage):

  • page/Page.cpp:

(WebCore::Page::~Page):

01:40 Changeset [108464] by abarth@webkit.org
  • 10 edits
    16 moves in trunk/Source/WebCore

Move Geolocation code into Modules/geolocation
https://bugs.webkit.org/show_bug.cgi?id=79204

Reviewed by Hajime Morita.

There are still some dangling references into the Geolocation module,
which I will clean up in a followup patch.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Modules/geolocation/Geolocation.cpp: Copied from Source/WebCore/page/Geolocation.cpp.
  • Modules/geolocation/Geolocation.h: Copied from Source/WebCore/page/Geolocation.h.
  • Modules/geolocation/Geolocation.idl: Copied from Source/WebCore/page/Geolocation.idl.
  • Modules/geolocation/GeolocationController.cpp: Copied from Source/WebCore/page/GeolocationController.cpp.
  • Modules/geolocation/GeolocationController.h: Copied from Source/WebCore/page/GeolocationController.h.
  • Modules/geolocation/GeolocationError.h: Copied from Source/WebCore/page/GeolocationError.h.
  • Modules/geolocation/GeolocationPosition.h: Copied from Source/WebCore/page/GeolocationPosition.h.
  • Modules/geolocation/Geoposition.h: Copied from Source/WebCore/page/Geoposition.h.
  • Modules/geolocation/Geoposition.idl: Copied from Source/WebCore/page/Geoposition.idl.
  • Modules/geolocation/PositionCallback.h: Copied from Source/WebCore/page/PositionCallback.h.
  • Modules/geolocation/PositionCallback.idl: Copied from Source/WebCore/page/PositionCallback.idl.
  • Modules/geolocation/PositionError.h: Copied from Source/WebCore/page/PositionError.h.
  • Modules/geolocation/PositionError.idl: Copied from Source/WebCore/page/PositionError.idl.
  • Modules/geolocation/PositionErrorCallback.h: Copied from Source/WebCore/page/PositionErrorCallback.h.
  • Modules/geolocation/PositionErrorCallback.idl: Copied from Source/WebCore/page/PositionErrorCallback.idl.
  • Modules/geolocation/PositionOptions.h: Copied from Source/WebCore/page/PositionOptions.h.
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/Geolocation.cpp: Removed.
  • page/Geolocation.h: Removed.
  • page/Geolocation.idl: Removed.
  • page/GeolocationController.cpp: Removed.
  • page/GeolocationController.h: Removed.
  • page/GeolocationError.h: Removed.
  • page/GeolocationPosition.h: Removed.
  • page/Geoposition.h: Removed.
  • page/Geoposition.idl: Removed.
  • page/PositionCallback.h: Removed.
  • page/PositionCallback.idl: Removed.
  • page/PositionError.h: Removed.
  • page/PositionError.idl: Removed.
  • page/PositionErrorCallback.h: Removed.
  • page/PositionErrorCallback.idl: Removed.
  • page/PositionOptions.h: Removed.
01:28 Changeset [108463] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[gtk] Accessibility: use find funtion in vector instead of for.
https://bugs.webkit.org/show_bug.cgi?id=77878

Patch by Frederik Gladhorn <frederik.gladhorn@nokia.com> on 2012-02-22
Reviewed by Hajime Morita.

Minor cleanup, use the find function from vector.

  • accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetIndexInParent):

01:14 Changeset [108462] by rniwa@webkit.org
  • 40 edits in trunk/Source

Remove the remaining uses of CSSStyleDeclaration in Editor
https://bugs.webkit.org/show_bug.cgi?id=78939

Reviewed by Enrica Casucci.

Source/WebCore:

Changed the argument types of shouldApplyStyle, applyParagraphStyle, applyStyleToSelection,
applyParagraphStyleToSelection, and computeAndSetTypingStyle in Editor from CSSStyleDeclaration
to StylePropertySet.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • editing/Editor.cpp:

(WebCore::Editor::applyStyle):
(WebCore::Editor::shouldApplyStyle):
(WebCore::Editor::applyParagraphStyle):
(WebCore::Editor::applyStyleToSelection):
(WebCore::Editor::applyParagraphStyleToSelection):
(WebCore::Editor::setBaseWritingDirection):
(WebCore::Editor::computeAndSetTypingStyle):

  • editing/Editor.h:

(WebCore):
(Editor):

  • editing/EditorCommand.cpp:

(WebCore::applyCommandToFrame):
(WebCore::executeApplyParagraphStyle):
(WebCore::executeMakeTextWritingDirectionLeftToRight):
(WebCore::executeMakeTextWritingDirectionNatural):
(WebCore::executeMakeTextWritingDirectionRightToLeft):

  • loader/EmptyClients.h:

(WebCore::EmptyEditorClient::shouldApplyStyle):

  • page/DragController.cpp:

(WebCore::DragController::concludeEditDrag):

  • page/EditorClient.h:

(WebCore):
(EditorClient):

Source/WebKit/blackberry:

  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::shouldApplyStyle):

  • WebCoreSupport/EditorClientBlackBerry.h:

(EditorClientBlackBerry):

Source/WebKit/chromium:

  • src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::shouldApplyStyle):

  • src/EditorClientImpl.h:

(EditorClientImpl):

Source/WebKit/efl:

  • WebCoreSupport/EditorClientEfl.cpp:

(WebCore::EditorClientEfl::shouldApplyStyle):

  • WebCoreSupport/EditorClientEfl.h:

(EditorClientEfl):

Source/WebKit/gtk:

  • WebCoreSupport/EditorClientGtk.cpp:

(WebKit::EditorClient::shouldApplyStyle):

  • WebCoreSupport/EditorClientGtk.h:

(EditorClient):

Source/WebKit/mac:

  • WebCoreSupport/WebEditorClient.h:

(WebEditorClient):

  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::shouldApplyStyle):

  • WebView/WebFrame.mm:

(-[WebFrame _setTypingStyle:withUndoAction:]):

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
(-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):

  • WebView/WebView.mm:

(-[WebView applyStyle:]):

Source/WebKit/qt:

  • WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::shouldApplyStyle):

  • WebCoreSupport/EditorClientQt.h:

(EditorClientQt):

Source/WebKit/win:

  • WebCoreSupport/WebEditorClient.cpp:

(WebEditorClient::shouldApplyStyle):

  • WebCoreSupport/WebEditorClient.h:

(WebEditorClient):

Source/WebKit/wince:

  • WebCoreSupport/EditorClientWinCE.cpp:

(WebKit::EditorClientWinCE::shouldApplyStyle):

Source/WebKit/wx:

  • WebKitSupport/EditorClientWx.cpp:

(WebCore::EditorClientWx::shouldApplyStyle):

  • WebKitSupport/EditorClientWx.h:

(EditorClientWx):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::shouldApplyStyle):

  • WebProcess/WebCoreSupport/WebEditorClient.h:

(WebEditorClient):

01:04 Changeset [108461] by pfeldman@chromium.org
  • 1 edit
    1 copy in branches/chromium/1025/Source/WebCore/inspector

Merge 106352 - Web Inspector: boost protocol version to 1.0
https://bugs.webkit.org/show_bug.cgi?id=77408

Reviewed by Yury Semikhatsky.

  • inspector/Inspector-1.0.json: Copied from Source/WebCore/inspector/Inspector.json.
  • inspector/Inspector.json:

TBR=pfeldman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9430040

01:03 Changeset [108460] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[GTK] fast/mediastream/peerconnection-argument-types.html fails
https://bugs.webkit.org/show_bug.cgi?id=79096

Patch by Yanbin Zhang <yanbin.zhang@intel.com> on 2012-02-22
Reviewed by Adam Barth.

  • fast/mediastream/peerconnection-argument-types-expected.txt:
  • fast/mediastream/script-tests/argument-types.js:
00:55 Changeset [108459] by carlosgc@webkit.org
  • 9 edits in trunk

Unreviewed, rolling out r107351.
http://trac.webkit.org/changeset/107351
https://bugs.webkit.org/show_bug.cgi?id=53600

Several issues introduced in WebKitGTK+ API

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::ChromeClient):
(WebKit::ChromeClient::chromeDestroyed):
(WebKit::ChromeClient::canRunModal):
(WebKit::ChromeClient::runModal):

  • WebCoreSupport/ChromeClientGtk.h:

(ChromeClient):

  • webkit/webkitwebview.cpp:

(webkit_web_view_class_init):

Tools:

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(createWebView):

  • GtkLauncher/main.c:

(createWebViewCb):
(createBrowser):
(createWindow):
(main):

LayoutTests:

  • platform/gtk/Skipped:
00:54 Changeset [108458] by commit-queue@webkit.org
  • 8 edits in trunk/Source

[chromium] Cull quads outside of the scissoring damage rect
https://bugs.webkit.org/show_bug.cgi?id=79181

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-22
Reviewed by James Robinson.

Source/WebCore:

Quads outside of the partial swap cause us to execute GL operations
that actually use a fair amount of CPU time (enough to affect power
usage). Here we cull quads by only keeping their intersection
with the damage rect used for partial swap.

Unit test: CCQuadCuller.cpp

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::optimizeRenderPasses):

  • platform/graphics/chromium/cc/CCQuadCuller.cpp:

(WebCore::CCQuadCuller::cullOccludedQuads):

  • platform/graphics/chromium/cc/CCQuadCuller.h:

(CCQuadCuller):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::optimizeQuads):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(CCRenderPass):

Source/WebKit/chromium:

  • tests/CCQuadCullerTest.cpp:

(WebCore::TEST):
(WebCore):

00:49 Changeset [108457] by pfeldman@chromium.org
  • 5 edits in branches/chromium/1025/Source/WebCore/inspector

Merge 106347 - Web Inspector: DOMDebugger.setEventListenerBreakpoint should accept regular DOM event names.
https://bugs.webkit.org/show_bug.cgi?id=77409

Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::setEventListenerBreakpoint):
(WebCore):
(WebCore::InspectorDOMDebuggerAgent::setInstrumentationBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::setBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeEventListenerBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeInstrumentationBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):

  • inspector/InspectorDOMDebuggerAgent.h:

(InspectorDOMDebuggerAgent):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didInstallTimerImpl):
(WebCore::InspectorInstrumentation::didRemoveTimerImpl):
(WebCore::InspectorInstrumentation::willHandleEventImpl):
(WebCore::InspectorInstrumentation::willFireTimerImpl):
(WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):

  • inspector/front-end/BreakpointsSidebarPane.js:

(WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint):

TBR=pfeldman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9429043

00:43 Changeset [108456] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Short circuit fixed for a 16 bt pattern character and an 8 bit string.
https://bugs.webkit.org/show_bug.cgi?id=75602

Patch by Hojong Han <hojong.han@samsung.com> on 2012-02-22
Reviewed by Gavin Barraclough.

  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::backtrackPatternCharacterGreedy):

00:37 Changeset [108455] by philn@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed, GTK gardening.

  • platform/gtk/Skipped:
  • platform/gtk/fast/forms/float-before-fieldset-expected.txt:
00:30 Changeset [108454] by jonlee@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Part of r108409 was incorrect, and incorporated an older version of a sub-patch.
This is the actual sub-patch that should have been submitted.

  • WebCoreSupport/WebNotificationClient.h:
  • WebCoreSupport/WebNotificationClient.mm:

(WebNotificationClient::show):
(WebNotificationClient::cancel):
(WebNotificationClient::clearNotifications):
(WebNotificationClient::notificationObjectDestroyed):
(WebNotificationClient::notificationControllerDestroyed):

00:27 WebKitEFLLayoutTest edited by gyuyoung.kim@samsung.com
(diff)
00:26 WebKitEFLLayoutTest edited by gyuyoung.kim@samsung.com
(diff)
00:25 WebKitEFLLayoutTest edited by gyuyoung.kim@samsung.com
(diff)
00:24 WebKitEFLLayoutTest edited by gyuyoung.kim@samsung.com
(diff)
00:20 EFLWebKit edited by gyuyoung.kim@samsung.com
Add dependent package (diff)

02/21/12:

23:59 Changeset [108453] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk/Source

[Chromium] New CCOcclusionTracker class with tests
https://bugs.webkit.org/show_bug.cgi?id=78549

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-21
Reviewed by James Robinson.

Source/WebCore:

Adds a CCOcclusionTrackerBase template class that is able to track occlusion
of layers while traversing the layer tree from front-to-back, with typedefed
versions for the main and impl threads.

At each step of the front-to-back traversal, the class should be notified of
changes to the current render target, and when done working with a layer, the
layer is added the tracked occlusion.

The class provides tests for checking if a rect in content space
for a layer/surface is occluded by others in front of it.

Unit tests: CCOcclusionTrackerTest.cpp

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp: Added.

(WebCore):
(WebCore::::enterTargetRenderSurface):
(WebCore::::finishedTargetRenderSurface):
(WebCore::transformSurfaceOpaqueRegion):
(WebCore::::leaveToTargetRenderSurface):
(WebCore::contentToScreenSpaceTransform):
(WebCore::contentToTargetSurfaceTransform):
(WebCore::computeOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):
(WebCore::testContentRectOccluded):
(WebCore::::occluded):
(WebCore::::surfaceOccluded):
(WebCore::rectSubtractRegion):
(WebCore::computeUnoccludedContentRect):
(WebCore::::unoccludedContentRect):
(WebCore::::surfaceUnoccludedContentRect):
(WebCore::::currentOcclusionInScreenSpace):
(WebCore::::currentOcclusionInTargetSurface):

  • platform/graphics/chromium/cc/CCOcclusionTracker.h: Added.

(WebCore):
(CCOcclusionTrackerBase):
(WebCore::CCOcclusionTrackerBase::CCOcclusionTrackerBase):
(StackObject):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCLayerTreeHostCommonTest.cpp:

(WebCore):

  • tests/CCOcclusionTrackerTest.cpp: Added.

(WebCore):
(WebCore::setLayerPropertiesForTesting):
(LayerChromiumWithForcedDrawsContent):
(WebCore::LayerChromiumWithForcedDrawsContent::LayerChromiumWithForcedDrawsContent):
(WebCore::LayerChromiumWithForcedDrawsContent::drawsContent):
(TestCCOcclusionTracker):
(WebCore::TestCCOcclusionTracker::occlusionInScreenSpace):
(WebCore::TestCCOcclusionTracker::occlusionInTargetSurface):
(WebCore::TestCCOcclusionTracker::setOcclusionInScreenSpace):
(WebCore::TestCCOcclusionTracker::setOcclusionInTargetSurface):
(WebCore::TEST):

23:37 Changeset [108452] by carlosgc@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Null ResourceErrors are encoded/decoded as empty ResourceErrors
https://bugs.webkit.org/show_bug.cgi?id=79120

Reviewed by Martin Robinson.

  • Shared/gtk/WebCoreArgumentCodersGtk.cpp:

(CoreIPC::::encode): Encode a boolean to indicate whether it's a
Null error.
(CoreIPC::::decode): Check whether the error is Null and do not
continue decoding in such case.

23:33 Changeset [108451] by kling@webkit.org
  • 6 edits in trunk/Source/WebCore

Cache <font face> family lists in CSSValuePool.
<http://webkit.org/b/79195>

Reviewed by Antti Koivisto.

HTMLFontElements with "face" attributes are very common in legacy web content.
Add a String->CSSValue cache for these in CSSValuePool and use it to avoid
reparsing and recreating duplicate font face values.

This knocks 20ms (~1.5%) worth of samples off of the Moz page cycler on my system.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFontFaceValue):

  • css/CSSParser.h:
  • css/CSSValuePool.cpp:

(WebCore::CSSValuePool::createFontFaceValue):

  • css/CSSValuePool.h:
  • html/HTMLFontElement.cpp:

(WebCore::HTMLFontElement::collectStyleForAttribute):

23:28 Changeset [108450] by abarth@webkit.org
  • 10 edits
    3 adds in trunk/Source/WebCore

Separate the implementation of registerProtocolHandler from Navigator.cpp
https://bugs.webkit.org/show_bug.cgi?id=78945

Reviewed by Eric Seidel.

The implementation of registerProtocolHandler needlessly complicates
the implementation of Navigator.cpp. In principle,
registerProtocolHandler (and possibly registerContentHandler, when we
implement that feature) could be its own module, but that seems like
overkill for one or two files.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/Navigator.cpp:

(WebCore):

  • page/Navigator.h:

(Navigator):

  • page/Navigator.idl:
23:20 Changeset [108449] by morrita@google.com
  • 6 edits in trunk/Source/WebCore

HasIDFlag and HasClassFlag can be removed.
https://bugs.webkit.org/show_bug.cgi?id=77861

Reviewed by Andreas Kling.

Replaced HasIDFlag and HasClassFlag with a check against
ElementAttributeData. It looks these flags (originally bitfields)
were legacy of ancient era, where we didn't cache @id and @class
values and needed a hash lookup for each check.

No new tests. No behavioral change.

  • dom/Element.cpp:

(WebCore::Element::idAttributeChanged):

  • dom/Element.h:

(WebCore::Element::hasID):
(WebCore):
(WebCore::Element::hasClass):
(WebCore::Node::hasID):
(WebCore::Node::hasClass):

  • dom/ElementAttributeData.h:

(WebCore::ElementAttributeData::hasID):
(WebCore::ElementAttributeData::hasClass):
(ElementAttributeData):

  • dom/Node.h:

(Node):
(WebCore::nodeStyleChangeShift):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::classAttributeChanged):

23:15 Changeset [108448] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix for systems with case sensitive disks.

  • llint/LLIntOfflineAsmConfig.h:
22:29 Changeset [108447] by mdelaney@apple.com
  • 2 edits in trunk/Source/WebCore

2D Canvas setTransform makes unnecessary matrix mults
https://bugs.webkit.org/show_bug.cgi?id=79190

Reviewed by Dan Bernstein.

No new tests - plenty of current tests using setTransform.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setTransform):

21:46 Changeset [108446] by morrita@google.com
  • 9 edits in trunk/Source

INPUT_SPEECH should be implemented as a PageSupplement.
https://bugs.webkit.org/show_bug.cgi?id=79051

Source/WebCore:

Turned SpeechInput to a PageSupplement.

Reviewed by Adam Barth.

No new tests. No behavior change.

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::InputFieldSpeechButtonElement::speechInput):
(WebCore::InputFieldSpeechButtonElement::attach):

  • page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::PageClients::PageClients):

  • page/Page.h:

(WebCore):
(PageClients):
(Page):

  • page/SpeechInput.cpp:

(WebCore::SpeechInput::supplementName):
(WebCore):
(WebCore::provideSpeechInputTo):

  • page/SpeechInput.h:

(SpeechInput):
(WebCore::SpeechInput::from):

  • page/SpeechInputClient.h:

(WebCore):

Source/WebKit/chromium:

Reviewed by Adam Barth.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

21:29 Changeset [108445] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[chromium] Add three small zoom gesture features
https://bugs.webkit.org/show_bug.cgi?id=74216

Patch by Alexandre Elias <aelias@google.com> on 2012-02-21
Reviewed by James Robinson.

  1. Support panning around with two fingers.
  2. When double-tap zooming, issue the commit at final/scroll scale as

early as possible.

  1. When pinch zooming out, issue a commit at minimum scale to avoid

showing checkerboard.

Added test for panning to CCLayerTreeHostImplTest::pinchGesture.
(The other features are heuristics whose exact behavior we don't need
to lock in with a test.)

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::startPageScaleAnimation):
(WebCore::CCLayerTreeHostImpl::pinchGestureBegin):
(WebCore::CCLayerTreeHostImpl::pinchGestureUpdate):
(WebCore::CCLayerTreeHostImpl::computeDoubleTapZoomDeltas):
(WebCore::CCLayerTreeHostImpl::computePinchZoomDeltas):
(WebCore::CCLayerTreeHostImpl::makeScrollAndScaleSet):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
21:23 Changeset [108444] by fpizlo@apple.com
  • 79 edits
    38 adds in trunk

JSC should be a triple-tier VM
https://bugs.webkit.org/show_bug.cgi?id=75812
<rdar://problem/10079694>

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

Implemented an interpreter that uses the JIT's calling convention. This
interpreter is called LLInt, or the Low Level Interpreter. JSC will now
will start by executing code in LLInt and will only tier up to the old
JIT after the code is proven hot.

LLInt is written in a modified form of our macro assembly. This new macro
assembly is compiled by an offline assembler (see offlineasm), which
implements many modern conveniences such as a Turing-complete CPS-based
macro language and direct access to relevant C++ type information
(basically offsets of fields and sizes of structs/classes).

Code executing in LLInt appears to the rest of the JSC world "as if" it
were executing in the old JIT. Hence, things like exception handling and
cross-execution-engine calls just work and require pretty much no
additional overhead.

This interpreter is 2-2.5x faster than our old interpreter on SunSpider,
V8, and Kraken. With triple-tiering turned on, we're neutral on SunSpider,
V8, and Kraken, but appear to get a double-digit improvement on real-world
websites due to a huge reduction in the amount of JIT'ing.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
  • JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • assembler/LinkBuffer.h:
  • assembler/MacroAssemblerCodeRef.h:

(MacroAssemblerCodePtr):
(JSC::MacroAssemblerCodePtr::createFromExecutableAddress):

  • bytecode/BytecodeConventions.h: Added.
  • bytecode/CallLinkStatus.cpp:

(JSC::CallLinkStatus::computeFromLLInt):
(JSC):
(JSC::CallLinkStatus::computeFor):

  • bytecode/CallLinkStatus.h:

(JSC::CallLinkStatus::isSet):
(JSC::CallLinkStatus::operator!):
(CallLinkStatus):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC):
(JSC::CodeBlock::unlinkCalls):
(JSC::CodeBlock::unlinkIncomingCalls):
(JSC::CodeBlock::bytecodeOffset):
(JSC::ProgramCodeBlock::jettison):
(JSC::EvalCodeBlock::jettison):
(JSC::FunctionCodeBlock::jettison):
(JSC::ProgramCodeBlock::jitCompileImpl):
(JSC::EvalCodeBlock::jitCompileImpl):
(JSC::FunctionCodeBlock::jitCompileImpl):

  • bytecode/CodeBlock.h:

(JSC):
(CodeBlock):
(JSC::CodeBlock::baselineVersion):
(JSC::CodeBlock::linkIncomingCall):
(JSC::CodeBlock::bytecodeOffset):
(JSC::CodeBlock::jitCompile):
(JSC::CodeBlock::hasOptimizedReplacement):
(JSC::CodeBlock::addPropertyAccessInstruction):
(JSC::CodeBlock::addGlobalResolveInstruction):
(JSC::CodeBlock::addLLIntCallLinkInfo):
(JSC::CodeBlock::addGlobalResolveInfo):
(JSC::CodeBlock::numberOfMethodCallLinkInfos):
(JSC::CodeBlock::valueProfilePredictionForBytecodeOffset):
(JSC::CodeBlock::likelyToTakeSlowCase):
(JSC::CodeBlock::couldTakeSlowCase):
(JSC::CodeBlock::likelyToTakeSpecialFastCase):
(JSC::CodeBlock::likelyToTakeDeepestSlowCase):
(JSC::CodeBlock::likelyToTakeAnySlowCase):
(JSC::CodeBlock::addFrequentExitSite):
(JSC::CodeBlock::dontJITAnytimeSoon):
(JSC::CodeBlock::jitAfterWarmUp):
(JSC::CodeBlock::jitSoon):
(JSC::CodeBlock::llintExecuteCounter):
(ProgramCodeBlock):
(EvalCodeBlock):
(FunctionCodeBlock):

  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFromLLInt):
(JSC):
(JSC::GetByIdStatus::computeFor):

  • bytecode/GetByIdStatus.h:

(JSC::GetByIdStatus::GetByIdStatus):
(JSC::GetByIdStatus::wasSeenInJIT):
(GetByIdStatus):

  • bytecode/Instruction.h:

(JSC):
(JSC::Instruction::Instruction):
(Instruction):

  • bytecode/LLIntCallLinkInfo.h: Added.

(JSC):
(JSC::LLIntCallLinkInfo::LLIntCallLinkInfo):
(LLIntCallLinkInfo):
(JSC::LLIntCallLinkInfo::~LLIntCallLinkInfo):
(JSC::LLIntCallLinkInfo::isLinked):
(JSC::LLIntCallLinkInfo::unlink):

  • bytecode/MethodCallLinkStatus.cpp:

(JSC::MethodCallLinkStatus::computeFor):

  • bytecode/Opcode.cpp:

(JSC):

  • bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFromLLInt):
(JSC):
(JSC::PutByIdStatus::computeFor):

  • bytecode/PutByIdStatus.h:

(PutByIdStatus):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveWithBase):
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::emitPutById):
(JSC::BytecodeGenerator::emitDirectPutById):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):
(JSC::BytecodeGenerator::emitCatch):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOperations.cpp:
  • heap/Heap.h:

(JSC):
(JSC::Heap::firstAllocatorWithoutDestructors):
(Heap):

  • heap/MarkStack.cpp:

(JSC::visitChildren):

  • heap/MarkedAllocator.h:

(JSC):
(MarkedAllocator):

  • heap/MarkedSpace.h:

(JSC):
(MarkedSpace):
(JSC::MarkedSpace::firstAllocator):

  • interpreter/CallFrame.cpp:

(JSC):
(JSC::CallFrame::bytecodeOffsetForNonDFGCode):
(JSC::CallFrame::setBytecodeOffsetForNonDFGCode):
(JSC::CallFrame::currentVPC):
(JSC::CallFrame::setCurrentVPC):
(JSC::CallFrame::trueCallerFrame):

  • interpreter/CallFrame.h:

(JSC::ExecState::hasReturnPC):
(JSC::ExecState::clearReturnPC):
(ExecState):
(JSC::ExecState::bytecodeOffsetForNonDFGCode):
(JSC::ExecState::currentVPC):
(JSC::ExecState::setCurrentVPC):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::Interpreter):
(JSC::Interpreter::~Interpreter):
(JSC):
(JSC::Interpreter::initialize):
(JSC::Interpreter::isOpcode):
(JSC::Interpreter::unwindCallFrame):
(JSC::getCallerInfo):
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::retrieveLastCaller):

  • interpreter/Interpreter.h:

(JSC):
(Interpreter):
(JSC::Interpreter::getOpcode):
(JSC::Interpreter::getOpcodeID):
(JSC::Interpreter::classicEnabled):

  • interpreter/RegisterFile.h:

(JSC):
(RegisterFile):

  • jit/ExecutableAllocator.h:

(JSC):

  • jit/HostCallReturnValue.cpp: Added.

(JSC):
(JSC::getHostCallReturnValueWithExecState):

  • jit/HostCallReturnValue.h: Added.

(JSC):
(JSC::initializeHostCallReturnValue):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):

  • jit/JITCode.h:

(JSC::JITCode::isOptimizingJIT):
(JITCode):
(JSC::JITCode::isBaselineCode):
(JSC::JITCode::JITCode):

  • jit/JITDriver.h:

(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):

  • jit/JITExceptions.cpp:

(JSC::jitThrow):

  • jit/JITInlineMethods.h:

(JSC::JIT::updateTopCallFrame):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):
(JSC):

  • jit/JITStubs.h:

(JSC):

  • jit/JSInterfaceJIT.h:
  • llint: Added.
  • llint/LLIntCommon.h: Added.
  • llint/LLIntData.cpp: Added.

(LLInt):
(JSC::LLInt::Data::Data):
(JSC::LLInt::Data::performAssertions):
(JSC::LLInt::Data::~Data):

  • llint/LLIntData.h: Added.

(JSC):
(LLInt):
(Data):
(JSC::LLInt::Data::exceptionInstructions):
(JSC::LLInt::Data::opcodeMap):
(JSC::LLInt::Data::performAssertions):

  • llint/LLIntEntrypoints.cpp: Added.

(LLInt):
(JSC::LLInt::getFunctionEntrypoint):
(JSC::LLInt::getEvalEntrypoint):
(JSC::LLInt::getProgramEntrypoint):

  • llint/LLIntEntrypoints.h: Added.

(JSC):
(LLInt):
(JSC::LLInt::getEntrypoint):

  • llint/LLIntExceptions.cpp: Added.

(LLInt):
(JSC::LLInt::interpreterThrowInCaller):
(JSC::LLInt::returnToThrowForThrownException):
(JSC::LLInt::returnToThrow):
(JSC::LLInt::callToThrow):

  • llint/LLIntExceptions.h: Added.

(JSC):
(LLInt):

  • llint/LLIntOfflineAsmConfig.h: Added.
  • llint/LLIntOffsetsExtractor.cpp: Added.

(JSC):
(LLIntOffsetsExtractor):
(JSC::LLIntOffsetsExtractor::dummy):
(main):

  • llint/LLIntSlowPaths.cpp: Added.

(LLInt):
(JSC::LLInt::llint_trace_operand):
(JSC::LLInt::llint_trace_value):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::traceFunctionPrologue):
(JSC::LLInt::shouldJIT):
(JSC::LLInt::entryOSR):
(JSC::LLInt::resolveGlobal):
(JSC::LLInt::getByVal):
(JSC::LLInt::handleHostCall):
(JSC::LLInt::setUpCall):
(JSC::LLInt::genericCall):

  • llint/LLIntSlowPaths.h: Added.

(JSC):
(LLInt):

  • llint/LLIntThunks.cpp: Added.

(LLInt):
(JSC::LLInt::generateThunkWithJumpTo):
(JSC::LLInt::functionForCallEntryThunkGenerator):
(JSC::LLInt::functionForConstructEntryThunkGenerator):
(JSC::LLInt::functionForCallArityCheckThunkGenerator):
(JSC::LLInt::functionForConstructArityCheckThunkGenerator):
(JSC::LLInt::evalEntryThunkGenerator):
(JSC::LLInt::programEntryThunkGenerator):

  • llint/LLIntThunks.h: Added.

(JSC):
(LLInt):

  • llint/LowLevelInterpreter.asm: Added.
  • llint/LowLevelInterpreter.cpp: Added.
  • llint/LowLevelInterpreter.h: Added.
  • offlineasm: Added.
  • offlineasm/armv7.rb: Added.
  • offlineasm/asm.rb: Added.
  • offlineasm/ast.rb: Added.
  • offlineasm/backends.rb: Added.
  • offlineasm/generate_offset_extractor.rb: Added.
  • offlineasm/instructions.rb: Added.
  • offlineasm/offset_extractor_constants.rb: Added.
  • offlineasm/offsets.rb: Added.
  • offlineasm/opt.rb: Added.
  • offlineasm/parser.rb: Added.
  • offlineasm/registers.rb: Added.
  • offlineasm/self_hash.rb: Added.
  • offlineasm/settings.rb: Added.
  • offlineasm/transform.rb: Added.
  • offlineasm/x86.rb: Added.
  • runtime/CodeSpecializationKind.h: Added.

(JSC):

  • runtime/CommonSlowPaths.h:

(JSC::CommonSlowPaths::arityCheckFor):
(CommonSlowPaths):

  • runtime/Executable.cpp:

(JSC::jettisonCodeBlock):
(JSC):
(JSC::EvalExecutable::jitCompile):
(JSC::samplingDescription):
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::jitCompile):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::baselineCodeBlockFor):
(JSC::FunctionExecutable::jitCompileForCall):
(JSC::FunctionExecutable::jitCompileForConstruct):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

  • runtime/Executable.h:

(JSC):
(EvalExecutable):
(ProgramExecutable):
(FunctionExecutable):
(JSC::FunctionExecutable::jitCompileFor):

  • runtime/ExecutionHarness.h: Added.

(JSC):
(JSC::prepareForExecution):
(JSC::prepareFunctionForExecution):

  • runtime/JSArray.h:

(JSC):
(JSArray):

  • runtime/JSCell.h:

(JSC):
(JSCell):

  • runtime/JSFunction.h:

(JSC):
(JSFunction):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSC):
(JSGlobalData):

  • runtime/JSGlobalObject.h:

(JSC):
(JSGlobalObject):

  • runtime/JSObject.h:

(JSC):
(JSObject):
(JSFinalObject):

  • runtime/JSPropertyNameIterator.h:

(JSC):
(JSPropertyNameIterator):

  • runtime/JSString.h:

(JSC):
(JSString):

  • runtime/JSTypeInfo.h:

(JSC):
(TypeInfo):

  • runtime/JSValue.cpp:

(JSC::JSValue::description):

  • runtime/JSValue.h:

(LLInt):
(JSValue):

  • runtime/JSVariableObject.h:

(JSC):
(JSVariableObject):

  • runtime/Options.cpp:

(Options):
(JSC::Options::initializeOptions):

  • runtime/Options.h:

(Options):

  • runtime/ScopeChain.h:

(JSC):
(ScopeChainNode):

  • runtime/Structure.cpp:

(JSC::Structure::addPropertyTransition):

  • runtime/Structure.h:

(JSC):
(Structure):

  • runtime/StructureChain.h:

(JSC):
(StructureChain):

  • wtf/InlineASM.h:
  • wtf/Platform.h:
  • wtf/SentinelLinkedList.h:

(SentinelLinkedList):
(WTF::SentinelLinkedList::isEmpty):

  • wtf/text/StringImpl.h:

(JSC):
(StringImpl):

Source/WebCore:

Reviewed by Gavin Barraclough.

No new tests, because there is no change in behavior.

  • CMakeLists.txt:

Source/WebKit:

Reviewed by Gavin Barraclough.

Changed EFL's build system to include a new directory in JavaScriptCore.

  • CMakeLists.txt:

Tools:

Reviewed by Gavin Barraclough.

Changed EFL's build system to include a new directory in JavaScriptCore.

  • DumpRenderTree/efl/CMakeLists.txt:
21:13 Changeset [108443] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

NavigatorMediaStream.idl defines an interface for NavigatorGamepad
https://bugs.webkit.org/show_bug.cgi?id=79152

Reviewed by Adam Barth.

Fixed a typo: NavigatorGamepad => NavigatorMediaStream

This typo fix just changes the name of generated files:

  • V8NavigatorGamepad.h => V8NavigatorMediaStream.h
  • V8NavigatorGamepad.cpp => V8NavigatorMediaStream.cpp

The reason why the typo has not caused any serious build issues is that
the generate files for supplemental interfaces are "empty" and not important.
They just exist to control makefile dependencies.

No tests. No change in behavior.

  • mediastream/NavigatorMediaStream.idl:
21:12 Changeset [108442] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Fix compositor setting color uniforms incorrectly for solid color quads.
https://bugs.webkit.org/show_bug.cgi?id=76017

Patch by Daniel Sievers <sievers@chromium.org> on 2012-02-21
Reviewed by James Robinson.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawSolidColorQuad):

20:42 Changeset [108441] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

getCTM() on SVG root element with borders, paddings, and viewbox returns incorrect values
https://bugs.webkit.org/show_bug.cgi?id=78631

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-02-21
Reviewed by Eric Seidel.

Source/WebCore:

SVGSVGElement::currentViewportSize was returning the size of the SVG viewport plus CSS
borders and paddings, causing the CTM calculation to be off.

Test: svg/dom/SVGLocatable-getCTM-svg-root.html

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::currentViewportSize):

SVGSVGElement::currentViewportSize now uses the contentBoxRect instead of the frameRect.
The contentBoxRect corresponds to the SVG viewport and does not include borders and
paddings.

LayoutTests:

  • platform/chromium/test_expectations.txt
  • platform/mac/svg/dom/SVGLocatable-getCTM-svg-root-expected.png
  • svg/dom/SVGLocatable-getCTM-svg-root-expected.txt: Added.
  • svg/dom/SVGLocatable-getCTM-svg-root.html: Added.
20:34 Changeset [108440] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/Source/WebCore

[BlackBerry] Upstream Icon class in platform/graphics/blackberry
https://bugs.webkit.org/show_bug.cgi?id=79088

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-02-21
Reviewed by Antonio Gomes.

Initial upstreaming, no new tests.

  • platform/graphics/blackberry/IconBlackBerry.cpp: Added.

(WebCore):
(WebCore::Icon::~Icon):
(WebCore::Icon::paint):
(WebCore::Icon::createIconForFiles):

20:26 Changeset [108439] by bashi@chromium.org
  • 6 edits in trunk

Rename "reserved1" flag of WebSocketFrame to compress
https://bugs.webkit.org/show_bug.cgi?id=79187

Source/WebCore:

WebSocket deflate-frame extension draft specification defines COMP bit.
http://tools.ietf.org/html/draft-tyoshino-hybi-websocket-perframe-deflate-05#page-11

Reviewed by Kent Tamura.

No new tests. http/tests/websocket/tests/hybi/reserved-bits.html is revised to follow the change.

  • websockets/WebSocketChannel.cpp:

(WebCore):
(WebCore::WebSocketChannel::parseFrame): "reserved1" renamed "compress".
(WebCore::WebSocketChannel::processFrame): Removed reserved1 flag check.
(WebCore::makeFrameData):
(WebCore::WebSocketChannel::sendFrame):

  • websockets/WebSocketFrame.h: "reserved1" flag renamed "compress".

(WebCore::WebSocketFrame::WebSocketFrame):
(WebSocketFrame):

LayoutTests:

Reviewed by Kent Tamura.

  • http/tests/websocket/tests/hybi/reserved-bits-expected.txt: Revised to follow the change in meaning rsv1 bit.
  • http/tests/websocket/tests/hybi/reserved-bits.html: Ditto.
20:02 Changeset [108438] by yael.aharon@nokia.com
  • 5 edits
    4 moves in trunk/Source/WebCore

[Texmap] Move all TextureMapper related files to graphics/texmap
https://bugs.webkit.org/show_bug.cgi?id=79141

Reviewed by Martin Robinson.

Move TextureMaooerGL and TextureMapperShaderManager files to graphics/texmap.
No new tests.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • platform/graphics/qt/GraphicsContext3DQt.cpp
  • platform/graphics/opengl/TextureMapperGL.cpp: Removed.
  • platform/graphics/opengl/TextureMapperGL.h: Removed.
  • platform/graphics/opengl/TextureMapperShaderManager.cpp: Removed.
  • platform/graphics/opengl/TextureMapperShaderManager.h: Removed.
  • platform/graphics/texmap/TextureMapperGL.cpp: Copied from Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp.
  • platform/graphics/texmap/TextureMapperGL.h: Copied from Source/WebCore/platform/graphics/opengl/TextureMapperGL.h.
  • platform/graphics/texmap/TextureMapperShaderManager.cpp: Copied from Source/WebCore/platform/graphics/opengl/TextureMapperShaderManager.cpp.
  • platform/graphics/texmap/TextureMapperShaderManager.h: Copied from Source/WebCore/platform/graphics/opengl/TextureMapperShaderManager.h.
19:56 Changeset [108437] by morrita@google.com
  • 11 edits
    2 adds in trunk/Source

MEDIA_STREAM should be implemented as a PageSupplement.
https://bugs.webkit.org/show_bug.cgi?id=79050

Reviewed by Adam Barth.

Source/WebCore:

Added UserMediaController which implements PageSupplement. This
controller mediates WebCore-to-client communication and lifecycle
management. Then pushed UserMediaController out as a
PageSupplement module.

No new tests. No behavior change.

  • WebCore.gypi:
  • GNUmakefile.list.am:
  • mediastream/NavigatorMediaStream.cpp:

(WebCore::NavigatorMediaStream::webkitGetUserMedia):

  • mediastream/UserMediaClient.h:

(WebCore):

  • mediastream/UserMediaController.cpp: Added.

(WebCore):
(WebCore::UserMediaController::supplementName):
(WebCore::UserMediaController::UserMediaController):
(WebCore::UserMediaController::~UserMediaController):
(WebCore::UserMediaController::create):
(WebCore::provideUserMediaTo):

  • mediastream/UserMediaController.h: Added.

(WebCore):
(UserMediaController):
(WebCore::UserMediaController::client):
(WebCore::UserMediaController::from):
(WebCore::UserMediaController::requestUserMedia):
(WebCore::UserMediaController::cancelUserMediaRequest):

  • mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::create):
(WebCore::UserMediaRequest::UserMediaRequest):
(WebCore::UserMediaRequest::didCompleteQuery):
(WebCore::UserMediaRequest::contextDestroyed):

  • mediastream/UserMediaRequest.h:

(WebCore):
(UserMediaRequest):

  • page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::~Page):
(WebCore::Page::PageClients::PageClients):

  • page/Page.h:

(WebCore):
(PageClients):
(Page):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

19:35 Changeset [108436] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Node::isContentEditable should only update styles, not layout
https://bugs.webkit.org/show_bug.cgi?id=78637

Patch by James Robinson <jamesr@chromium.org> on 2012-02-21
Reviewed by Ryosuke Niwa.

isContentEditable depends on knowing the node's current computed style, so it has to update styles if they are
out of date. It does not depend on knowing any layout-derived properties, however, so updating layout is just a
waste of time.

Behavior is covered by existing layout tests, primarily in editing/

  • dom/Node.cpp:

(WebCore::Node::isContentEditable):
(WebCore::Node::isContentRichlyEditable):

19:16 Changeset [108435] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

Partially revert r108418 - move allowEventDispatch() call back to where it used to be.

Rubber-stamped by Ryosuke Niwa.

Tested by fast/text/find-layout-crash.html

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChildren):

19:11 Changeset [108434] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Background jitters on pages with background-attachment: fixed
https://bugs.webkit.org/show_bug.cgi?id=79182

Reviewed by Dan Bernstein.

Make sure to update the main frame scroll position before updating the scrolling layer.
This also fixes a (purely theoretical) bug where we wouldn't be updating the main frame
position if the main frame didn't have a scroll layer.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::updateMainFrameScrollPositionAndScrollLayerPosition):

18:58 Changeset [108433] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Early-out in Region::unite() for adding an empty region.
https://bugs.webkit.org/show_bug.cgi?id=79174

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-21
Reviewed by Anders Carlsson.

  • platform/graphics/Region.cpp:

(WebCore::Region::unite):

18:46 Changeset [108432] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Unbreak double-typed arrays on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=79177

Reviewed by Gavin Barraclough.

The existing code had completely broken address arithmetic.

  • JSCTypedArrayStubs.h:

(JSC):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::storeDouble):
(JSC::MacroAssemblerARMv7::storeFloat):

18:45 Changeset [108431] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[chromium] Painting a layer clears opaque rect in untouched tiles
https://bugs.webkit.org/show_bug.cgi?id=79157

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-21
Reviewed by James Robinson.

Source/WebCore:

When painting a tiled layer, we would throw away the saved opaque rect
for any tiles that were not part of the paint. So now we check
if we are able to save the existing saved opaque rect in a more
proper way:

  1. If any pixels of the saved rect are painted non-opaque, we replace

the saved rect.

  1. If an opaque rect is drawn outside of the saved rect, we replace

the saved rect.

Unit test: TiledLayerChromiumTest.cpp

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::addSelfToOccludedScreenSpace):

Source/WebKit/chromium:

  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):

18:42 Changeset [108430] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Small typo in AudioPannerNode.cpp
https://bugs.webkit.org/show_bug.cgi?id=75890

Change to check elevation as intended instead of azimuth.

Patch by Raymond Toy <rtoy@google.com> on 2012-02-21
Reviewed by Chris Rogers.

No new tests for correction of typo.

  • webaudio/AudioPannerNode.cpp:

(WebCore::AudioPannerNode::getAzimuthElevation):

18:35 Changeset [108429] by jonlee@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Build fix. Push ENABLE_NOTIFICATIONS into .mm file.

  • WebCoreSupport/WebNotificationClient.h:
  • WebView/WebNotification.h:
  • WebView/WebNotification.mm:

(-[WebNotification title]):
(-[WebNotification body]):
(-[WebNotification origin]):
(-[WebNotification notificationID]):
(-[WebNotification dispatchShowEvent]):
(-[WebNotification dispatchCloseEvent]):
(-[WebNotification dispatchClickEvent]):
(-[WebNotification dispatchErrorEvent]):

18:23 WikiStart edited by haraken@chromium.org
(diff)
18:22 Changeset [108428] by abarth@webkit.org
  • 40 edits
    4 adds in trunk/Source

Frame and Navigator shouldn't need to worry about Geolocation
https://bugs.webkit.org/show_bug.cgi?id=78860

Reviewed by Eric Seidel.

This patch removes some Geolocation-specific code from Frame and
Navigator in favor of our new supplemental module mechanism. We're
still refining the module system, but we seem to be converging on a
simple Observer/Supplement design.

In a future patch, I'll move the remaining Geolocation-related files in
WebCore into Modules/geolocation. This patch appears to be the first
patch that introduces a module used by all the various build systems,
which is why there's a bit more build system overhead than usual.

  • Modules/geolocation: Added.
  • Modules/geolocation/NavigatorGeolocation.cpp: Added.

(WebCore):
(WebCore::NavigatorGeolocation::NavigatorGeolocation):
(WebCore::NavigatorGeolocation::~NavigatorGeolocation):
(WebCore::NavigatorGeolocation::pageDestroyed):
(WebCore::NavigatorGeolocation::from):
(WebCore::NavigatorGeolocation::geolocation):

  • Modules/geolocation/NavigatorGeolocation.h: Added.

(WebCore):
(NavigatorGeolocation):

  • Modules/geolocation/NavigatorGeolocation.idl: Added.
    • I've temporarily disabled this API for GObject because it generates a strange compile error. Once I land this patch, I'll spend some more time fixing the compile error.
  • page/DOMWindow.cpp:

(WebCore):

  • page/DOMWindow.h:

(DOMWindow):

  • page/Frame.cpp:

(WebCore::Frame::pageDestroyed):
(WebCore::Frame::transferChildFrameToNewDocument):

  • page/FrameDestructionObserver.cpp:

(WebCore::FrameDestructionObserver::pageDestroyed):
(WebCore):

  • page/FrameDestructionObserver.h:

(FrameDestructionObserver):

  • page/Navigator.cpp:

(WebCore):

  • page/Navigator.h:

(WebCore):
(Navigator):

  • page/Navigator.idl:
18:20 WebKitIDL edited by haraken@chromium.org
(diff)
18:20 WebKitIDL edited by haraken@chromium.org
(diff)
17:51 Changeset [108427] by barraclough@apple.com
  • 7 edits in trunk

Should be able to reconfigure a non-configurable property as read-only
https://bugs.webkit.org/show_bug.cgi?id=79170

Reviewed by Sam Weinig.

See ES5.1 8.12.9 10.a.i - the spec prohibits making a read-only property writable,
but does not inhibit making a writable property read-only.

Source/JavaScriptCore:

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSC::JSGlobalData::setInDefineOwnProperty):
(JSGlobalData):
(JSC::JSGlobalData::isInDefineOwnProperty):

  • Added flag, tracking whether we are in JSObject::defineOwnProperty.
  • runtime/JSObject.cpp:

(JSC::JSObject::deleteProperty):
(DefineOwnPropertyScope):

  • Always allow properties to be deleted by DefineOwnProperty - assume it knows what it is doing!

(JSC::DefineOwnPropertyScope::DefineOwnPropertyScope):
(JSC::DefineOwnPropertyScope::~DefineOwnPropertyScope):

  • Added RAII helper.

(JSC::JSObject::defineOwnProperty):

  • Track on the globalData when we are in this method.

LayoutTests:

  • fast/js/Object-defineProperty-expected.txt:
  • fast/js/script-tests/Object-defineProperty.js:
    • Update test result (this was enforcing incorrect behaviour).
17:49 Changeset [108426] by shawnsingh@chromium.org
  • 4 edits in trunk/Source/WebCore

[chromium] Refactor CCLayerTreeHostCommon: merge scattered setTargetRenderSurface logic
https://bugs.webkit.org/show_bug.cgi?id=78936

Reviewed by James Robinson.

No change in behavior, the code moved around already covered by existing tests.

In calculateDrawTransformsAndVisibility(), there are two separate
if-else statements where setTargetRenderSurface logic is
performed, and this makes the code less readable and more error
prone. This patch merges the logic, removing the redundant if-else
statements.

This code also merges one other set of if-statements that are
equivalent, if (layer->parent()) and if (layer!=rootLayer).

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::createRenderSurface):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::createRenderSurface):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsAndVisibilityInternal):

17:36 Changeset [108425] by sullivan@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Build fix.

  • WebView/WebUIDelegatePrivate.h:

Added @class declarations for DOMNode and DOMElement.

17:24 WebKitIDL edited by haraken@chromium.org
(diff)
17:23 Changeset [108424] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Remove FIXME from resolve-supplemental.pl
https://bugs.webkit.org/show_bug.cgi?id=79160

Reviewed by Adam Barth.

The IDL attribute checker has been enabled in all build systems.
This patch removes FIXME in resolve-supplemental.pl.
Also, this patch improves a comment in IDLAttributes.txt.

No tests. No change in behavior.

  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/resolve-supplemental.pl:
17:19 Changeset [108423] by eae@chromium.org
  • 8 edits
    2 adds in trunk/Source/WebCore

Add FractionalLayoutRect for sub-pixel layout
https://bugs.webkit.org/show_bug.cgi?id=78924

Reviewed by Eric Seidel.

Add FractionalLayoutUnit version of Rect class. Uses FractionalLayoutPoint
and FractionalLayoutSize internally.

Also add conversions to int/float versions of same.

No new tests.

  • GNUmakefile.list.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/FloatRect.cpp:

(WebCore::FloatRect::FloatRect):
(WebCore):

  • platform/graphics/FloatRect.h:

(WebCore):
(FloatRect):

  • platform/graphics/FractionalLayoutRect.cpp: Added.

(WebCore):
(WebCore::FractionalLayoutRect::FractionalLayoutRect):
(WebCore::FractionalLayoutRect::intersects):
(WebCore::FractionalLayoutRect::contains):
(WebCore::FractionalLayoutRect::intersect):
(WebCore::FractionalLayoutRect::unite):
(WebCore::FractionalLayoutRect::uniteIfNonZero):
(WebCore::FractionalLayoutRect::scale):
(WebCore::unionRect):
(WebCore::enclosingIntRect):
(WebCore::enclosingFractionalLayoutRect):
(WebCore::pixelSnappedIntRect):

  • platform/graphics/FractionalLayoutRect.h: Added.

(WebCore):
(FractionalLayoutRect):
(WebCore::FractionalLayoutRect::FractionalLayoutRect):
(WebCore::FractionalLayoutRect::location):
(WebCore::FractionalLayoutRect::size):
(WebCore::FractionalLayoutRect::setLocation):
(WebCore::FractionalLayoutRect::setSize):
(WebCore::FractionalLayoutRect::x):
(WebCore::FractionalLayoutRect::y):
(WebCore::FractionalLayoutRect::maxX):
(WebCore::FractionalLayoutRect::maxY):
(WebCore::FractionalLayoutRect::width):
(WebCore::FractionalLayoutRect::height):
(WebCore::FractionalLayoutRect::setX):
(WebCore::FractionalLayoutRect::setY):
(WebCore::FractionalLayoutRect::setWidth):
(WebCore::FractionalLayoutRect::setHeight):
(WebCore::FractionalLayoutRect::isEmpty):
(WebCore::FractionalLayoutRect::center):
(WebCore::FractionalLayoutRect::move):
(WebCore::FractionalLayoutRect::moveBy):
(WebCore::FractionalLayoutRect::expand):
(WebCore::FractionalLayoutRect::contract):
(WebCore::FractionalLayoutRect::shiftXEdgeTo):
(WebCore::FractionalLayoutRect::shiftMaxXEdgeTo):
(WebCore::FractionalLayoutRect::shiftYEdgeTo):
(WebCore::FractionalLayoutRect::shiftMaxYEdgeTo):
(WebCore::FractionalLayoutRect::minXMinYCorner):
(WebCore::FractionalLayoutRect::maxXMinYCorner):
(WebCore::FractionalLayoutRect::minXMaxYCorner):
(WebCore::FractionalLayoutRect::maxXMaxYCorner):
(WebCore::FractionalLayoutRect::contains):
(WebCore::FractionalLayoutRect::inflateX):
(WebCore::FractionalLayoutRect::inflateY):
(WebCore::FractionalLayoutRect::inflate):
(WebCore::FractionalLayoutRect::transposedRect):
(WebCore::FractionalLayoutRect::infiniteRect):
(WebCore::intersection):
(WebCore::unionRect):
(WebCore::operator==):
(WebCore::operator!=):

  • platform/graphics/IntRect.cpp:

(WebCore::IntRect::IntRect):
(WebCore):

  • platform/graphics/IntRect.h:

(WebCore):
(IntRect):

17:11 WebKitIDL edited by haraken@chromium.org
(diff)
17:04 Changeset [108422] by jamesr@google.com
  • 7 edits in trunk/Source

Enable ScrollingCoordinator in chromium whenever compositing is enabled
https://bugs.webkit.org/show_bug.cgi?id=79165

Reviewed by Adam Barth.

Source/WebCore:

As the title says.

  • page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::setScrollLayer):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setScrollParameters):
(WebCore::ScrollingCoordinator::setWheelEventHandlerCount):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):

Remove ASSERT_NOT_REACHED()ed from these functions, they are now expected to be called but do nothing.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::RenderLayerBacking):

Guard a mac-specific piece of code in #if PLATFORM(MAC). This code already has a FIXME.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::shouldCompositeOverflowControls):

Make coordinatesScroll..() sufficient but not necessary for compositing overflow controls. In chromium, we
want to composite overflow controls even for FrameViews that we aren't coordinating via the
ScrollingCoordinator.

Source/WebKit/chromium:

  • src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::setViewport):

Whenever the ScrollingCoordinator is enabled the scroll layer's position is expected to be updated
externally to RenderLayerCompositor, so set it here.

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setAcceleratedCompositingEnabled):

17:01 Changeset [108421] by jonlee@apple.com
  • 5 edits in trunk/Source/WebKit/mac

Build fix for r108409.

  • WebCoreSupport/WebNotificationClient.h:

(WebCore):

  • WebCoreSupport/WebNotificationClient.mm:
  • WebView/WebNotification.h:

(WebSecurityOrigin):

  • WebView/WebNotification.mm:

(core):
(-[WebNotification initWithCoreNotification:notificationID:]):

16:55 WebKitIDL edited by haraken@chromium.org
(diff)
16:49 Changeset [108420] by oliver@apple.com
  • 4 edits
    1 add in trunk/Source/JavaScriptCore

Make TypedArrays be available in commandline jsc
https://bugs.webkit.org/show_bug.cgi?id=79163

Reviewed by Gavin Barraclough.

Adds a compile time option to have jsc support a basic implementation
of the TypedArrays available in WebCore. This lets us test the typed
array logic in the JIT witout having to build webcore.

  • JSCTypedArrayStubs.h: Added.

(JSC):

(GlobalObject::finishCreation):
(GlobalObject):
(GlobalObject::addConstructableFunction):

  • runtime/JSGlobalData.h:

(JSGlobalData):

16:47 Changeset [108419] by dcheng@chromium.org
  • 5 edits in trunk

[chromium] Fix image drag out on Chromium
https://bugs.webkit.org/show_bug.cgi?id=79158

Reviewed by Tony Chang.

Source/WebKit/chromium:

We constructed the WebDragData::Item for dragging out an image but never added it to the
item list. This is normally covered by the fast/events/drag-image-filename.html layout test,
but the bug wasn't caught in the original patch since the implementations in Chrome and DRT
had diverged.

  • src/WebDragData.cpp:

(WebKit::WebDragData::items):

Tools:

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::dumpFilenameBeingDragged):
(EventSender::beginDragWithFiles):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(addDRTFakeFileToDataObject):

16:46 Changeset [108418] by adamk@chromium.org
  • 3 edits
    6 adds in trunk

Setting innerText causes DOMSubtreeModified to be dispatched too early
https://bugs.webkit.org/show_bug.cgi?id=79140

Reviewed by Ryosuke Niwa.

Source/WebCore:

Followup to r108152: move children change notifications later in
ContainerNode::removeChildren(), thus making sure Node::inDocument()
is in the correct state when we call into script.

Tests: fast/dom/getElementById-consistency3.html

fast/dom/getElementById-consistency4.html
fast/dom/getElementById-consistency5.html

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChildren):

LayoutTests:

  • fast/dom/getElementById-consistency3-expected.txt: Added.
  • fast/dom/getElementById-consistency3.html: Added.
  • fast/dom/getElementById-consistency4-expected.txt: Added.
  • fast/dom/getElementById-consistency4.html: Added.
  • fast/dom/getElementById-consistency5-expected.txt: Added.
  • fast/dom/getElementById-consistency5.html: Added.
16:42 Changeset [108417] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Assertion failure in TextIterator::handleTextBox
https://bugs.webkit.org/show_bug.cgi?id=78530

Source/WebCore:

Reviewed by Eric Seidel.

The assertion failure was caused by handleTextNodeFirstLetter's updating m_text without clearing
m_sortedTextBoxesPosition. Re-structured handleTextNode so that we always reset m_sortedTextBoxesPosition
when we have a first-letter.

Test: editing/text-iterator/rtl-first-letter-text-iterator-crash.html

  • editing/TextIterator.cpp:

(WebCore::TextIterator::handleTextNode):
(WebCore::TextIterator::handleTextBox):
(WebCore::TextIterator::handleTextNodeFirstLetter):

LayoutTests:

Reviewed by Enrica Casucci.

Add a regression test. Also rebaseline a crash test.

  • editing/text-iterator/rtl-first-letter-text-iterator-crash-expected.txt: Added.
  • editing/text-iterator/rtl-first-letter-text-iterator-crash.html: Added.
  • editing/text-iterator/rtl-selection-crash-expected.txt:
16:38 Changeset [108416] by yael.aharon@nokia.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix.

No new tests.

  • platform/graphics/opengl/TextureMapperGL.cpp:
16:34 Changeset [108415] by adamk@chromium.org
  • 3 edits
    2 adds in trunk

ContainerNode::childrenChanged must be called immediately after removing children
https://bugs.webkit.org/show_bug.cgi?id=79162

Reviewed by Ryosuke Niwa.

Source/WebCore:

In r108152, a call to childrenChanged() was erroneously moved
below the call to child->removedFromDocument(). This breaks, at the
least, the behavior of the <title> element. This patch corrects the
mistake and adds a test.

Test: fast/dom/title-directionality-removeChild.html

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChild):

LayoutTests:

  • fast/dom/title-directionality-removeChild-expected.txt: Added.
  • fast/dom/title-directionality-removeChild.html: Added.
16:32 Changeset [108414] by dpranke@chromium.org
  • 4 edits in trunk/Tools

webkitpy: speed up hot filesystem_mock functions
https://bugs.webkit.org/show_bug.cgi?id=79159

Reviewed by Adam Barth.

Profiling run_webkit_tests_integrationtest.py revealed that
isdir(), normpath(), and join() are called a lot and were very
slow.This patch speeds them up substantially, shaving 20 seconds
off of the execution time.

  • Scripts/webkitpy/common/system/filesystem_mock.py:

(MockFileSystem.isdir):
(MockFileSystem._slow_but_correct_join):
(MockFileSystem.join):
(MockFileSystem.listdir):
(MockFileSystem._slow_but_correct_normpath):
(MockFileSystem.normpath):
(MockFileSystem.write_binary_file):

  • Scripts/webkitpy/common/system/filesystem_mock_unittest.py:

(MockFileSystemTest.quick_check):
(MockFileSystemTest):
(MockFileSystemTest.test_join):
(MockFileSystemTest.test_normpath):

  • Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:

(get_test_config): Call write_binary_file() instead of updating

filesystem.files directly, so that we create directories as
needed.

16:29 Changeset [108413] by dpranke@chromium.org
  • 4 edits in trunk/Tools

nrwt: make the delay between starting workers configurable per-port
https://bugs.webkit.org/show_bug.cgi?id=79148

Reviewed by Eric Seidel.

Because of bug 79147, we have to sleep a bit in between starting
DRTs; however, doing so across the board slows down the Test
port. Making this configurable shaves 10 seconds off of
run_webkit_tests_integrationtest.py

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._run_tests):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.worker_startup_delay_secs):

  • Scripts/webkitpy/layout_tests/port/test.py:

(TestPort.worker_startup_delay_secs):

16:19 Changeset [108412] by tsepez@chromium.org
  • 4 edits in trunk

equalIgnoringNullity() only comparing half the bytes for equality
https://bugs.webkit.org/show_bug.cgi?id=79135

Reviewed by Adam Barth.

Source/JavaScriptCore:

  • wtf/text/StringImpl.h:

(WTF::equalIgnoringNullity):

LayoutTests:

  • http/tests/security/xssAuditor/script-tag.html:
16:16 WebKitIDL edited by haraken@chromium.org
(diff)
16:12 Changeset [108411] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Update chromium expectations for accessibility/aria-invalid.html

  • platform/chromium/test_expectations.txt:
16:03 Changeset [108410] by macpherson@chromium.org
  • 4 edits in trunk/Source/WebCore

Implement many instances of HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=79067

Reviewed by Andreas Kling.

No new tests / refactoring only.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • rendering/style/RenderStyle.h:
16:00 Changeset [108409] by jonlee@apple.com
  • 20 edits
    2 copies
    1 add in trunk

Source/WebCore: Bring notifications support to WK1 mac
https://bugs.webkit.org/show_bug.cgi?id=78783
<rdar://problem/10610578>

Reviewed by Anders Carlsson.

  • WebCore.exp.in: Expose dispatchErrorEvent on Notification.

Source/WebKit: Bring notifications support to WK1 mac: showing, canceling, removing notifications
https://bugs.webkit.org/show_bug.cgi?id=78783
<rdar://problem/10610578>

Reviewed by Anders Carlsson.

  • WebKit.xcodeproj/project.pbxproj: Added new files.

Source/WebKit/mac: Bring notifications support to WK1 mac: permission requests
https://bugs.webkit.org/show_bug.cgi?id=78783
<rdar://problem/10610578>

Reviewed by Anders Carlsson.

  • WebCoreSupport/WebNotificationClient.h:
  • WebCoreSupport/WebNotificationClient.mm: Create policy listener, which conforms to the

WebAllowDenyPolicyListener protocol, similar to geolocation.
(WebNotificationClient::requestPermission):
(WebNotificationClient::checkPermission):
(-[WebNotificationPolicyListener initWithCallback:]):
(-[WebNotificationPolicyListener allow]): Call the callback.
(-[WebNotificationPolicyListener deny]): Call the callback.

  • WebView/WebUIDelegatePrivate.h: Define new UI delegate method to ask the user to decide a

policy for navigations.

====
Bring notifications support to WK1 mac: showing, canceling, removing notifications

Create a WebKit wrapper object for WebCore::Notification, which also keeps track of an assigned
ID.

  • WebView/WebNotification.h: Added.

(WebSecurityOrigin):

  • WebView/WebNotification.mm: Added.

(core):
(-[WebNotification initWithCoreNotification:notificationID:]):
(-[WebNotification init]):
(-[WebNotification dealloc]):
(-[WebNotification title]):
(-[WebNotification body]):
(-[WebNotification origin]):
(-[WebNotification notificationID]):
(-[WebNotification dispatchShowEvent]):
(-[WebNotification dispatchCloseEvent]):
(-[WebNotification dispatchClickEvent]):
(-[WebNotification dispatchErrorEvent]):

  • WebView/WebNotificationInternal.h: Added.

(WebCore): Internal category to allow creating instances with WebCore objects.

Extend WebView to include a WebNotificationProvider, which clients implement.

  • WebView/WebViewData.h: Add a private member for the provider.
  • WebView/WebViewPrivate.h:
    • Define an enum WebNotificationPermission that mirrors WebCore::NotificationPresenter::Permission that client which implement the provider can use to return policy decisions.
    • Define WebNotificationProvider.
    • Category WebViewNotification extends WebView with methods that set and manager the notification provider, and handle events from the platform notifications.
  • WebView/WebView.mm:

(-[WebView _setNotificationProvider:]): Sets the provider when initializing the WebView.
(-[WebView _notificationControllerDestroyed]):
(-[WebView _notificationProvider]):
(-[WebView _notificationDidShow:]):
(-[WebView _notificationDidClick:]):
(-[WebView _notificationsDidClose:]):

  • WebCoreSupport/WebNotificationClient.h: Add variables that map between WebCore::Notification

instances, their assigned IDs, their contexts, and corresponding WebKit wrapper objects.

  • WebCoreSupport/WebNotificationClient.mm:

(generateNotificationID): Created unique IDs for each shown notification.
(WebNotificationClient::show): Create wrapper object for notification, assign ID, cache the
mappings between the objects, and forward it to the provider.
(WebNotificationClient::cancel):
(WebNotificationClient::clearNotifications): Clear all notifications associated with the
provided context.
(WebNotificationClient::notificationObjectDestroyed): Remove the notification from the maps.
(WebNotificationClient::notificationControllerDestroyed): If the controller is destroyed, tell
the provider to clear of the notifications related to this web view.

====
(Prep work for) Bring notifications support to WK1 mac

Rename WebGeolocationPolicyListener. The interface is generic enough to be reused for
notification requests. To avoid having to create a new listener type, instead rename it
to WebAllowDenyPolicyListener.

  • WebView/WebUIDelegatePrivate.h: Rename the protocol.
  • WebCoreSupport/WebGeolocationClient.mm: Refactor geolocation request listener to use

new name.

Add preference to keep track of whether notifications are enabled in general.

  • WebView/WebPreferenceKeysPrivate.h: Add WebNotificationsEnabledKey for storing the

preference.

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]): By default have them enabled.
(-[WebPreferences setNotificationsEnabled:]):
(-[WebPreferences notificationsEnabled]):

  • WebView/WebPreferencesPrivate.h:

Add a stringValue method that exposes WebCore::SecurityOrigin::toString() for storing the
notification policy for a given origin.

  • WebCoreSupport/WebSecurityOrigin.mm:

(-[WebSecurityOrigin stringValue]):

  • WebCoreSupport/WebSecurityOriginPrivate.h:

Tools: Bring notifications support to WK1 mac
https://bugs.webkit.org/show_bug.cgi?id=78783
<rdar://problem/10610578>

Reviewed by Anders Carlsson.

  • DumpRenderTree/mac/UIDelegate.mm: Refactor WebGeolocationPolicyListener to WebAllowDenyPolicyListener.

(-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
(-[UIDelegate timerFired]):

15:33 Changeset [108408] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Draw tiles of previous contents-scale for opaque layers if they don't intersect with previous tiles
https://bugs.webkit.org/show_bug.cgi?id=78962

Only avoid painting old-scale tiles in semi-transparent situtations if the old
tiles intersect with existing tiles.

Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/qt/LayerBackingStore.cpp:

(WebKit::LayerBackingStore::paintToTextureMapper):

15:30 Changeset [108407] by noam.rosenthal@nokia.com
  • 4 edits in trunk/Source

[Qt] Previous web page appears outside content rect
https://bugs.webkit.org/show_bug.cgi?id=78816

Source/WebCore:

Adjust the scissor clipping by -1, as the glScissor() function requires coordinates and
not sizes.

Reviewed by Kenneth Rohde Christiansen.

No new functionality.

  • platform/graphics/opengl/TextureMapperGL.cpp:

(WebCore::scissorClip):

Source/WebKit2:

Apply a clip on painted tiles if some of the tiles fall outside of the target rect.

Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/qt/LayerBackingStore.cpp:

(WebKit::LayerBackingStore::paintToTextureMapper):

15:28 Changeset [108406] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Source/WebCore: Added support for pause-on-exit flag on a TextTrackCue.
https://bugs.webkit.org/show_bug.cgi?id=72173

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-02-21
Reviewed by Eric Carlson.

Test: media/track/track-cues-pause-on-exit.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updateActiveTextTrackCues): Implemented
support for pausing the video if the pause-on-exit flag is set on
a cue that is currently exiting.

LayoutTests: Added relevant tests and functionality for supporting pause-on-exit
flag for a TextTrackCue.

https://bugs.webkit.org/show_bug.cgi?id=72173

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-02-21
Reviewed by Eric Carlson.

  • media/track/captions-webvtt/simple-captions.vtt: Added.
  • media/track/track-cues-pause-on-exit-expected.txt: Added.
  • media/track/track-cues-pause-on-exit.html: Added.
14:57 Changeset [108405] by noam.rosenthal@nokia.com
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] Accelerated animations don't work on Mac
https://bugs.webkit.org/show_bug.cgi?id=78963

Problem came from using a non-RunLoop timer.
Remove the unused viewportUpdateTimer, and use the existing animationTimer instead.
Use a continuous timer that we only stop when animations stop.

Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/LayerTreeHostProxy.h:

(LayerTreeHostProxy):

  • UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::LayerTreeHostProxy):
(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit):
(WebKit::LayerTreeHostProxy::syncAnimations):

14:51 Changeset [108404] by haraken@chromium.org
  • 10 edits in trunk/Source/WebCore

Enable the IDL attribute checker in all build systems
https://bugs.webkit.org/show_bug.cgi?id=79090

Reviewed by Adam Barth.

We have enabled the IDL attribute checker in Chromium in r108322.
This patch enables the IDL attribute checker in all other
build systems.

No tests. I manually checked that [Custommm], [CallWith=],
[CallWith=ScriptExecutionContext|Foo] cause build failures.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • UseJSC.cmake:
  • UseV8.cmake:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/IDLAttributes.txt: Added [ObjCCustomImplementation]

since I forgot to add it in r108322.

14:46 Changeset [108403] by rniwa@webkit.org
  • 2 edits in trunk

Fix more typos.

14:44 Changeset [108402] by yael.aharon@nokia.com
  • 8 edits
    2 adds in trunk/Source/WebCore

[Texmap] Better management of shaders in TextureMapperGL
https://bugs.webkit.org/show_bug.cgi?id=78674

Reviewed by Noam Rosenthal.

Split TextureMapperGL.cpp into two files.
Get rid of the enums that we were using to identify shaders and to identify variables.
Switch flip and opaque from using bool to using enums.

No new tests. This is refactoring only.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • platform/graphics/OpenGLShims.h:
  • platform/graphics/opengl/TextureMapperGL.cpp:

(WebCore):
(SharedGLData):
(WebCore::TextureMapperGLData::SharedGLData::SharedGLData):
(WebCore::TextureMapperGLData::SharedGLData::~SharedGLData):
(WebCore::TextureMapperGLData::TextureMapperGLData):
(TextureMapperGLData):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::TextureMapperGL::drawTextureWithMaskAndOpacity):
(WebCore::TextureMapperGL::drawTextureSimple):
(WebCore::TextureMapperGL::beginClip):

  • platform/graphics/opengl/TextureMapperGL.h:
  • platform/graphics/opengl/TextureMapperShaderManager.cpp: Added.

(WebCore):
(WebCore::FRAGMENT_SHADER):
(WebCore::TextureMapperShaderProgram::initializeProgram):
(WebCore::TextureMapperShaderProgram::getUniformLocation):
(WebCore::TextureMapperShaderProgram::~TextureMapperShaderProgram):
(WebCore::TextureMapperShaderProgramSimple::create):
(WebCore::TextureMapperShaderProgramSimple::TextureMapperShaderProgramSimple):
(WebCore::TextureMapperShaderProgramSimple::vertexShaderSource):
(WebCore::TextureMapperShaderProgramSimple::fragmentShaderSource):
(WebCore::TextureMapperShaderProgramOpacityAndMask::create):
(WebCore::TextureMapperShaderProgramOpacityAndMask::TextureMapperShaderProgramOpacityAndMask):
(WebCore::TextureMapperShaderProgramOpacityAndMask::vertexShaderSource):
(WebCore::TextureMapperShaderProgramOpacityAndMask::fragmentShaderSource):
(WebCore::TextureMapperShaderProgramClip::create):
(WebCore::TextureMapperShaderProgramClip::TextureMapperShaderProgramClip):
(WebCore::TextureMapperShaderProgramClip::vertexShaderSource):
(WebCore::TextureMapperShaderProgramClip::fragmentShaderSource):
(WebCore::TextureMapperShaderManager::TextureMapperShaderManager):
(WebCore::TextureMapperShaderManager::~TextureMapperShaderManager):

  • platform/graphics/opengl/TextureMapperShaderManager.h: Added.

(WebCore):
(WebCore::debugGLCommand):
(TextureMapperShaderProgram):
(WebCore::TextureMapperShaderProgram::id):
(WebCore::TextureMapperShaderProgram::vertexAttrib):
(WebCore::TextureMapperShaderProgram::shaderType):
(TextureMapperShaderProgramSimple):
(WebCore::TextureMapperShaderProgramSimple::matrixVariable):
(WebCore::TextureMapperShaderProgramSimple::sourceMatrixVariable):
(WebCore::TextureMapperShaderProgramSimple::sourceTextureVariable):
(WebCore::TextureMapperShaderProgramSimple::opacityVariable):
(TextureMapperShaderProgramOpacityAndMask):
(WebCore::TextureMapperShaderProgramOpacityAndMask::sourceMatrixVariable):
(WebCore::TextureMapperShaderProgramOpacityAndMask::matrixVariable):
(WebCore::TextureMapperShaderProgramOpacityAndMask::maskMatrixVariable):
(WebCore::TextureMapperShaderProgramOpacityAndMask::sourceTextureVariable):
(WebCore::TextureMapperShaderProgramOpacityAndMask::maskTextureVariable):
(WebCore::TextureMapperShaderProgramOpacityAndMask::opacityVariable):
(TextureMapperShaderProgramClip):
(WebCore::TextureMapperShaderProgramClip::matrixVariable):
(TextureMapperShaderManager):
(WebCore::TextureMapperShaderManager::getShaderProgram):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):

  • platform/graphics/texmap/TextureMapper.h:

(WebCore::BitmapTexture::reset):
(WebCore::BitmapTexture::isOpaque):
(BitmapTexture):

14:37 Changeset [108401] by rniwa@webkit.org
  • 1 edit in trunk/ChangeLog

Fix the typo.

14:29 Changeset [108400] by haraken@chromium.org
  • 2 edits in trunk/Tools

Enable the IDL attribute checker in run-bindings-tests
https://bugs.webkit.org/show_bug.cgi?id=79091

Reviewed by Adam Barth.

We have enabled the IDL attribute checker in Chromium in r108322.
This patch enables the IDL attribute checker in run-bindings-tests.

No tests. I manually checked that [Custommm], [CallWith=],
[CallWith=ScriptExecutionContext|Foo] in TestObj.idl cause
run-bindings-tests failures.

  • Scripts/webkitpy/bindings/main.py:

(BindingsTests.generate_supplemental_dependency):

14:26 Changeset [108399] by rniwa@webkit.org
  • 5 edits
    2 adds
    3 deletes in trunk

perf-o-matic: Extract logic to generate JSON responses as classes to unit test
https://bugs.webkit.org/show_bug.cgi?id=79018

Rubber-stamped by Adam Birth.

Extracted DashboardJSONGenerator, ManifestJSONGenerator, and RunsJSONGenerator
into json_generators.py from DashboardHandler, ManifestHandler, and RunsHandler
and added unit tests for the former three classes.

Merged the latter three classes into controler.py since they have become too trivial
to have their own files.

  • Websites/webkit-perf.appspot.com/controller.py:

(ManifestUpdateHandler):
(ManifestUpdateHandler.get):
(ManifestUpdateHandler.post):
(DashboardUpdateHandler):
(DashboardUpdateHandler.get):
(DashboardUpdateHandler.post):
(_get_test_branch_platform_ids):
(RunsUpdateHandler):
(RunsUpdateHandler.get):
(CachedRunsHandler.get):

  • Websites/webkit-perf.appspot.com/dashboard_handler.py: Removed.
  • Websites/webkit-perf.appspot.com/json_generators.py: Added.

(JSONGeneratorBase):
(JSONGeneratorBase.to_json):
(DashboardJSONGenerator):
(DashboardJSONGenerator.init):
(DashboardJSONGenerator.value):
(ManifestJSONGenerator):
(ManifestJSONGenerator.init):
(ManifestJSONGenerator.value):
(RunsJSONGenerator):
(RunsJSONGenerator.init):
(RunsJSONGenerator._generate_runs):
(RunsJSONGenerator._entry_from_build_and_result):
(RunsJSONGenerator.value):

  • Websites/webkit-perf.appspot.com/json_generators_unittest.py: Added.

(_create_results):
(JSONGeneratorBaseTest):
(JSONGeneratorBaseTest.test_to_json):
(JSONGeneratorBaseTest.test_to_json.AJSONGenerator):
(JSONGeneratorBaseTest.test_to_json.AJSONGenerator.value):
(DashboardJSONGeneratorTest):
(DashboardJSONGeneratorTest.test_value_no_branch):
(DashboardJSONGeneratorTest.test_value_no_plaforms):
(DashboardJSONGeneratorTest.test_value_single_platform):
(DashboardJSONGeneratorTest.test_value_two_platforms):
(ManifestJSONGeneratorTest):
(ManifestJSONGeneratorTest.test_value_no_branch):
(ManifestJSONGeneratorTest.test_value_no_plaforms):
(ManifestJSONGeneratorTest._assert_single_test):
(ManifestJSONGeneratorTest.test_value_single_platform):
(ManifestJSONGeneratorTest.test_value_two_platforms):
(ManifestJSONGeneratorTest.test_value_two_tests):
(RunsJSONGeneratorTest):
(RunsJSONGeneratorTest._create_results):
(RunsJSONGeneratorTest.test_generate_runs):
(RunsJSONGeneratorTest.test_value_without_results):
(RunsJSONGeneratorTest.test_value_with_results):
(RunsJSONGeneratorTest._assert_entry):
(RunsJSONGeneratorTest.test_run_from_build_and_result):
(RunsJSONGeneratorTest.test_run_from_build_and_result.create_build):

  • Websites/webkit-perf.appspot.com/main.py:
  • Websites/webkit-perf.appspot.com/manifest_handler.py: Removed.
  • Websites/webkit-perf.appspot.com/models.py:

(Test.update_or_insert.execute):
(Test):
(TestResult.get_or_insert_from_parsed_json):

  • Websites/webkit-perf.appspot.com/models_unittest.py:

(TestModelTests.test_update_or_insert_to_update):
(TestResultTests.test_get_or_insert_stat_value):

  • Websites/webkit-perf.appspot.com/runs_handler.py: Removed.
14:26 Changeset [108398] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/AutoTableLayout.cpp

Explicitly converting table's logical width, as well as borders, padding, spacing, etc. to integers before doing math with them to avoid truncating the width an extra pixel unnecessarily.

14:21 Changeset [108397] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

The tile cache should keep track of the tile coverage rect
https://bugs.webkit.org/show_bug.cgi?id=79149
<rdar://problem/10877338>

Reviewed by Andreas Kling.

Keep track of the tile coverage rect and use it to avoid trying to iterate over non-existent tiles on large pages.

  • platform/graphics/ca/mac/TileCache.h:

(TileCache):

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::setNeedsDisplayInRect):
(WebCore::TileCache::revalidateTiles):

14:05 Changeset [108396] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

Make WebKitCSSShaderValue inherit directly from CSSValue.
<http://webkit.org/b/79144>

Reviewed by Antti Koivisto.

WebKitCSSShaderValue was inheriting from CSSPrimitiveValue but only used
it for storing the shader URL. Moved that to a String member instead.

WebKitCSSShaderValues didn't even return true for isPrimitiveValue() so
there should be no behavior change whatsoever here.

  • css/WebKitCSSShaderValue.cpp:

(WebCore::WebKitCSSShaderValue::WebKitCSSShaderValue):
(WebCore::WebKitCSSShaderValue::cachedShader):
(WebCore::WebKitCSSShaderValue::customCssText):

  • css/WebKitCSSShaderValue.h:

(WebKitCSSShaderValue):

13:57 Changeset [108395] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed windows build fix - avoid return statement after return if USE(ACCELERATED_COMPOSITING) is set.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::coordinatesScrollingForFrameView):

13:46 Changeset [108394] by leviw@chromium.org
  • 2 edits in branches/subpixellayout/Source/WebCore/rendering

Fixing the order of arguments to pixelSnappedIntRectFromEdges in RenderInline, and properly calculating the available logical width in RenderBlockLineLayout. Both of these were regressions from my previous commit.

13:40 Changeset [108393] by ossy@webkit.org
  • 1 edit
    1 move
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Typo fix.

  • platform/qt-5.0-wk2/http/tests/websocket/tests/hybi/bad-sub-protocol-non-ascii-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/http/tests/websocket/test/hybi/bad-sub-protocol-non-ascii-expected.txt.
13:39 Changeset [108392] by jamesr@google.com
  • 3 edits in trunk/Source/WebCore

ScrollingCoordinator::coordinatesScrollingForFrameView should be conditional on compositing being active
https://bugs.webkit.org/show_bug.cgi?id=79126

Reviewed by Anders Carlsson.

The ScrollingCoordinator should only attempt to coordinate scrolling when compositing is active, since it's all
about manipulating GraphicsLayers. Adds a runtime check.

Also removes some stray #if ENABLE(THREADED_SCROLLING) guards that snuck into FrameView.

  • page/FrameView.cpp:

(WebCore::FrameView::addFixedObject):
(WebCore::FrameView::removeFixedObject):

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::coordinatesScrollingForFrameView):
(WebCore::ScrollingCoordinator::frameViewRootLayerDidChange):

13:35 Changeset [108391] by jamesr@google.com
  • 4 edits in trunk/Source/WebCore

Chromium build fix. Unreviwed but rubber-stamped by Antti.

  • dom/Document.cpp:
  • editing/ReplaceSelectionCommand.cpp:
  • inspector/InspectorStyleSheet.h:
13:29 Changeset [108390] by senorblanco@chromium.org
  • 1 edit
    3 copies in branches/chromium/1025

Merge 107822 - Source/WebCore: Fix for incorrect/offset image in CSS filters (non-composited path)
https://bugs.webkit.org/show_bug.cgi?id=78626

Reviewed by Darin Adler.

Test: css3/filters/multiple-filters-invalidation.html

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::prepare):
When invalidating results, invalidate all intermediate filter
results, not just the last effect's result.

LayoutTests: New test to exercise invalidation of multiple CSS filters.
https://bugs.webkit.org/show_bug.cgi?id=78626

Reviewed by Darin Adler.

  • css3/filters/multiple-filters-invalidation-expected.txt: Added.
  • css3/filters/multiple-filters-invalidation.html: Added.
  • platform/mac-snowleopard/css3/filters/multiple-filters-invalidation-expected.png: Added.

TBR=senorblanco@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9429011

13:20 Changeset [108389] by ossy@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

[Qt] Unreviewed evening gardening after r108364.

  • platform/qt/fast/forms/float-before-fieldset-expected.png: Added.
  • platform/qt/fast/forms/float-before-fieldset-expected.txt: Updated.
13:14 Changeset [108388] by wjmaclean@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Enable compositor filter layout tests (except on mac and win debug)
https://bugs.webkit.org/show_bug.cgi?id=79111

Reviewed by Stephen White.

  • platform/chromium/test_expectations.txt:
13:08 Changeset [108387] by eric.carlson@apple.com
  • 10 edits
    1 delete in trunk

Set Referrer header for media downloads
https://bugs.webkit.org/show_bug.cgi?id=78614

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: http/tests/media/video-referer.html was modified to test this change.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerReferrer): New, return the document's referer.

  • html/HTMLMediaElement.h:
  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::referrer): New, return the client's mediaPlayerReferrer.

  • platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerReferrer):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Tell AVFoundation to add

a referer header.

LayoutTests:

  • http/tests/media/resources/video-referer-check-referer.php: Get the test file and content-type

from parameters on the url. Fail if referrer is anything but video-referer.html. Add support for
byte-range requests so it will work with AVFoundation.

  • http/tests/media/video-referer.html: Pass video file name and content-type as url parameters

instead of having another cgi set a cookie. Set the php script as the 'src' on a <source> element
instead of on the <video> element so we can also add a 'type' attribute.

12:58 Changeset [108386] by antti@apple.com
  • 2 edits in trunk/Source/WebCore

Not reviewed.

Remove some obsolete comments, use consistent name for propertyID.

  • css/StylePropertySet.h:

(StylePropertySet):

12:48 Changeset [108385] by antti@apple.com
  • 5 edits in trunk/Source/WebCore

Clean up StylePropertySet included headers
https://bugs.webkit.org/show_bug.cgi?id=79134

Reviewed by Andreas Kling.

Remove unneccesary includes.

  • bindings/js/JSDOMBinding.h:
  • css/StylePropertySet.cpp:
  • css/StylePropertySet.h:

(WebCore):
(StylePropertySet):

  • editing/RemoveCSSPropertyCommand.cpp:
12:43 Changeset [108384] by cfleizach@apple.com
  • 2 edits in trunk/LayoutTests

AX: move aria-invalid test to top level, so other platforms can use it
https://bugs.webkit.org/show_bug.cgi?id=79041

Unreviewed. Forgot to update paths.

  • accessibility/aria-invalid.html:
12:10 Changeset [108383] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix bug from r107672.
https://bugs.webkit.org/show_bug.cgi?id=78773

Before set MediaStreamTrack disable/enable operation,
checking the status of MediaStream that contains this MediaStreamTrack.
if MediaStream is finished, then skipping operation of
didSetMediaStreamTrackEnabled().

Patch by Lin Wei <wei.a.lin@intel.com> on 2012-02-21
Reviewed by Adam Barth.

  • mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::setEnabled):

11:59 Changeset [108382] by jchaffraix@webkit.org
  • 11 edits in trunk/Source/WebCore

Move RenderLayer::scrolledContentOffset calls to a common function
https://bugs.webkit.org/show_bug.cgi?id=76971

Reviewed by David Hyatt.

Refactoring without any change in behavior.

This change adds a RenderBox::scrolledContentOffset function to handle all
the calls that goes through the layer(). This indirection will enable us to
add layer() checks without patching a lot of call sites as part of bug 75568.

We also moved down the concept of scroll offset down to RenderBox where it belongs!

  • rendering/RenderLayer.h:

(RenderLayer):
(WebCore::RenderLayer::scrolledContentOffset):
Moved scrolledContent to the private section of the class to prevent misuse.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::scrolledContentOffset):
New function to add an indirection with RenderLayer.

  • editing/visible_units.cpp:

(WebCore::absoluteLineDirectionPointToLocalPointInBlock):

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::paintObject):
(WebCore::RenderBlock::selectionGapRectsForRepaint):
(WebCore::RenderBlock::paintSelection):
(WebCore::RenderBlock::nodeAtPoint):
(WebCore::RenderBlock::offsetForContents):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::offsetFromContainer):
(WebCore::RenderBox::computeRectForRepaint):

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::clippedOverflowRectForRepaint):
(WebCore::RenderInline::computeRectForRepaint):
(WebCore::RenderInline::offsetFromContainer):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::computeRectForRepaint):
(WebCore::RenderObject::mapLocalToContainer):
(WebCore::RenderObject::mapAbsoluteToLocalPoint):
(WebCore::RenderObject::offsetFromContainer):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlInnerBlock::positionForPoint):
Patched all those call sites to use the new function.

11:55 Changeset [108381] by rafaelw@chromium.org
  • 2 edits in trunk/Tools

Add rafaelw as a committer.

Unreviewed.

  • Scripts/webkitpy/common/config/committers.py:
11:49 Changeset [108380] by tonikitoo@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

2012-02-18 Antonio Gomes <agomes@rim.com>

Fat fingers - cache the first rect-based hit test so we do not need to do it again
https://bugs.webkit.org/show_bug.cgi?id=79115

Reviewed by Adam Treat.

Our FatFingers implementation runs currently in two phases:
the first checks for the elements intrinsically clickable;
the second checks for elements made clickable by the page
(for example, a div with a onclick event listener attached to it).
For each phase, we perform a rect hittest, which is not needed since
the result of each is the same.

Patch introduces a caching mechanism so we avoid on rect hittest:
when the first phase runs, it caches each nodeset per document in
a hashmap. This second phase works with the cached results.

No behavioral change, but performance is better since we
avoid one (possibly expensive) rect hittest.

I measured the performance gain on https://www.kvd.se/, and we
save up to 0.04 seconds, by caching and re-using the results.

  • WebKitSupport/FatFingers.cpp: (BlackBerry::WebKit::dumpHitTestResult): (BlackBerry::WebKit::FatFingers::findBestPoint): (BlackBerry::WebKit::FatFingers::findIntersectingRegions): (BlackBerry::WebKit::FatFingers::cachingStrategy): (WebKit): (BlackBerry::WebKit::FatFingers::getNodesFromRect):
  • WebKitSupport/FatFingers.h:
11:41 Changeset [108379] by dpranke@chromium.org
  • 2 edits in trunk/Tools

webkitpy: update names after deleting message_broker
https://bugs.webkit.org/show_bug.cgi?id=79000

Reviewed by Eric Seidel.

Part 3 of 3 in deleting message_broker.py; this change just
adjusts the names for the newly merged symbols so that they are
private as appropriate.

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:

(get):
(_Broker):
(_BrokerConnection):
(_BrokerConnection.init):
(AbstractWorker.init):
(_ManagerConnection):
(_ManagerConnection.init):
(_WorkerConnection):
(_WorkerConnection.init):

11:33 Changeset [108378] by dpranke@chromium.org
  • 2 edits
    1 delete in trunk/Tools

webkitpy: merge message_broker.py into manager_worker_broker.py
https://bugs.webkit.org/show_bug.cgi?id=78999

Reviewed by Tony Chang.

This is pretty much a straight cut-and-paste of one file into
another (broken up so that docstrings and imports are in the
right place).

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:

(BrokerClient):
(BrokerClient.is_done):
(BrokerClient.name):
(Broker):
(Broker.init):
(Broker.add_topic):
(Broker._get_queue_for_topic):
(Broker.post_message):
(Broker.run_message_loop):
(Broker.run_all_pending):
(Broker._run_loop):
(Broker._dispatch_message):
(_Message):
(_Message.loads):
(_Message.init):
(_Message.dumps):
(_Message.repr):
(BrokerConnection):
(BrokerConnection.init):
(BrokerConnection.run_message_loop):
(BrokerConnection.post_message):
(BrokerConnection.raise_exception):

  • Scripts/webkitpy/layout_tests/controllers/message_broker.py: Removed.
11:33 Changeset [108377] by eae@chromium.org
  • 5 edits in trunk/Source/WebCore

Remove obsolete float comparison FIXMEs
https://bugs.webkit.org/show_bug.cgi?id=79127

Reviewed by Eric Seidel.

Remove obsolete FIXME comments added back when we were planning to use
floating point units for layout.

No new tests, no code changes.

  • page/FrameView.cpp:

(WebCore::FrameView::init):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats):
(WebCore::RenderBlock::getClearDelta):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computeLogicalHeightUsing):
(WebCore::RenderBox::computePercentageLogicalHeight):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::ImageQualityController::shouldPaintAtLowQuality):

11:28 Changeset [108376] by dpranke@chromium.org
  • 3 edits
    1 delete in trunk/Tools

webkitpy: prepare to delete message_broker.py
https://bugs.webkit.org/show_bug.cgi?id=78997

Reviewed by Eric Seidel.

This is part 1 of 3 changes to fix bug 78187. This change
prepares the code for merging message_broker.py into
manager_worker_broker.py; the tests in message_broker_unittest
are merged into manager_worker_broker_unittest, the symbols
needed by the tests are exported from manager_worker_broker.py,
and manager_worker_broker itself is updated to refer to the
symbols directly (without the module prefix).

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:

(get):
(AbstractWorker):
(AbstractWorker.init):
(_ManagerConnection):
(_ManagerConnection.init):
(_WorkerConnection):
(_WorkerConnection.init):

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:

(InterfaceTest.test_brokerclient_is_abstract):
(InterfaceTest.test_brokerclient_is_abstract.methods):
(MessageTest):
(MessageTest.testno_body):
(MessageTest.test
body):

  • Scripts/webkitpy/layout_tests/controllers/message_broker_unittest.py: Removed.
11:25 Changeset [108375] by dgrogan@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

IndexedDB: webFrame isn't threadsafe, don't use it from a worker thread
https://bugs.webkit.org/show_bug.cgi?id=78659

After crrev.com/121669, indexed db doesn't use the web frame for
anything if called from a web worker.

No new tests - this check was defensive and possibly not ever
triggered.

Reviewed by Tony Chang.

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::openFromWorker):

11:17 Changeset [108374] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: it is nearly impossible to select and copy text on the Elements panel.
https://bugs.webkit.org/show_bug.cgi?id=60814

Reviewed by Pavel Feldman.

  • inspector/front-end/inspector.js:

(WebInspector.documentClick.followLink):
(WebInspector.documentClick):

11:13 Changeset [108373] by cfleizach@apple.com
  • 3 edits
    2 moves in trunk/LayoutTests

AX: move aria-invalid test to top level, so other platforms can use it
https://bugs.webkit.org/show_bug.cgi?id=79041

Reviewed by David Kilzer.

  • accessibility/aria-invalid-expected.txt: Copied from LayoutTests/platform/mac/accessibility/aria-invalid-expected.txt.
  • accessibility/aria-invalid.html: Copied from LayoutTests/platform/mac/accessibility/aria-invalid.html.
  • platform/gtk/Skipped:
  • platform/mac/accessibility/aria-invalid-expected.txt: Removed.
  • platform/mac/accessibility/aria-invalid.html: Removed.
  • platform/win/Skipped:
11:10 Changeset [108372] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash in RenderTableSection::nodeAtPoint.
https://bugs.webkit.org/show_bug.cgi?id=78922

Reviewed by Julien Chaffraix.

Source/WebCore:

Test: fast/table/table-section-node-at-point-crash.html

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::nodeAtPoint): recalc cells if the
m_needsCellRecalc is set. Otherwise, we will end up accessing
removed table cells.

LayoutTests:

  • fast/table/table-section-node-at-point-crash-expected.txt: Added.
  • fast/table/table-section-node-at-point-crash.html: Added.
10:54 Changeset [108371] by jamesr@google.com
  • 2 edits
    2 adds in trunk/LayoutTests

[chromium] Unreviewed, update chromium leopard baselines for r108364

  • platform/chromium-mac-leopard/fast/block/float/centered-float-avoidance-complexity-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/shrink-to-avoid-float-complexity-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/float-before-fieldset-expected.png:
10:46 WebKitIDL edited by arv@chromium.org
(diff)
10:38 Changeset [108370] by antti@apple.com
  • 8 edits
    1 copy
    1 add in trunk/Source/WebCore

Move PropertySetCSSStyleDeclaration to a file of its own
https://bugs.webkit.org/show_bug.cgi?id=79121

Rubber-stamped by Andreas Kling.

This makes StylePropertySet.cpp more readable.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/PropertySetCSSStyleDeclaration.cpp: Copied from Source/WebCore/css/StylePropertySet.cpp.

(WebCore::PropertySetCSSStyleDeclaration::ref):
(WebCore::PropertySetCSSStyleDeclaration::deref):
(WebCore):

  • css/PropertySetCSSStyleDeclaration.h: Added.

(WebCore):
(PropertySetCSSStyleDeclaration):
(WebCore::PropertySetCSSStyleDeclaration::PropertySetCSSStyleDeclaration):
(WebCore::PropertySetCSSStyleDeclaration::parentElement):
(WebCore::PropertySetCSSStyleDeclaration::clearParentRule):
(WebCore::PropertySetCSSStyleDeclaration::clearParentElement):
(WebCore::PropertySetCSSStyleDeclaration::contextStyleSheet):
(WebCore::PropertySetCSSStyleDeclaration::setNeedsStyleRecalc):
(RuleCSSStyleDeclaration):
(WebCore::RuleCSSStyleDeclaration::RuleCSSStyleDeclaration):
(WebCore::RuleCSSStyleDeclaration::parentRule):
(WebCore::RuleCSSStyleDeclaration::clearParentRule):
(InlineCSSStyleDeclaration):
(WebCore::InlineCSSStyleDeclaration::InlineCSSStyleDeclaration):
(WebCore::InlineCSSStyleDeclaration::parentElement):
(WebCore::InlineCSSStyleDeclaration::clearParentElement):

  • css/StylePropertySet.cpp:

(WebCore):

10:24 Changeset [108369] by paroga@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Unnecessary preprocessor macros in MainThread.h/cpp
https://bugs.webkit.org/show_bug.cgi?id=79083

Removed invalid/wrong PLATFORM(WINDOWS) preprocessor macro.

Patch by Roland Takacs <takacs.roland@stud.u-szeged.hu> on 2012-02-21

  • wtf/MainThread.cpp:

(WTF):

  • wtf/MainThread.h:

(WTF):

10:22 Changeset [108368] by jamesr@google.com
  • 4 edits
    9 adds
    1 delete in trunk/LayoutTests

[chromium] Unreviewed, update chromium baselines for r108364

  • platform/chromium-linux/fast/block/float/centered-float-avoidance-complexity-expected.png: Added.
  • platform/chromium-linux/fast/block/float/shrink-to-avoid-float-complexity-expected.png: Added.
  • platform/chromium-linux/fast/forms/float-before-fieldset-expected.png:
  • platform/chromium-mac-snowleopard/fast/block/float/centered-float-avoidance-complexity-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/float/shrink-to-avoid-float-complexity-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/float-before-fieldset-expected.png: Added.
  • platform/chromium-mac/fast/forms/float-before-fieldset-expected.png: Removed.
  • platform/chromium-win/fast/block/float/centered-float-avoidance-complexity-expected.png: Added.
  • platform/chromium-win/fast/block/float/centered-float-avoidance-complexity-expected.txt: Added.
  • platform/chromium-win/fast/block/float/shrink-to-avoid-float-complexity-expected.png: Added.
  • platform/chromium-win/fast/block/float/shrink-to-avoid-float-complexity-expected.txt: Added.
  • platform/chromium-win/fast/forms/float-before-fieldset-expected.png:
  • platform/chromium-win/fast/forms/float-before-fieldset-expected.txt:
10:20 Changeset [108367] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[GTK] WebAudio build is broken
https://bugs.webkit.org/show_bug.cgi?id=79113

Patch by Philippe Normand <pnormand@igalia.com> on 2012-02-21
Reviewed by Martin Robinson.

  • platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(webKitWebAudioGStreamerChannelPosition): Set a default value for
the position variable.

  • platform/audio/gtk/AudioBusGtk.cpp: Include CString.h, needed

for sharedResourcesPath().

10:00 Changeset [108366] by kling@webkit.org
  • 16 edits
    2 adds
    2 deletes in trunk

Kill FontFamilyValue.
<http://webkit.org/b/79103>

Reviewed by Antti Koivisto.

Source/WebCore:

Remove FontFamilyValue and replace all usage by CSSPrimitiveValue.
The class was only used to filter font family names, removing bracketed
suffixes, e.g "[Xft]".

This was added to KHTML in 2002 to support the use of specific X11 font
families inside KMail: <https://bugs.kde.org/show_bug.cgi?id=38808>

Test: fast/css/font-family-trailing-bracket-gunk.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):

  • css/CSSParser.cpp:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • css/CSSValue.cpp:

(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

  • css/CSSValue.h:
  • css/CSSValuePool.cpp:

(WebCore::CSSValuePool::createFontFamilyValue):

  • css/CSSValuePool.h:

(CSSValuePool):

  • css/FontFamilyValue.cpp: Removed.
  • css/FontFamilyValue.h: Removed.

LayoutTests:

  • fast/css/font-family-trailing-bracket-gunk-expected.txt: Added.
  • fast/css/font-family-trailing-bracket-gunk.html: Added.
09:35 Changeset [108365] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

Little optimization for CSSParser::parseFillShorthand.
https://bugs.webkit.org/show_bug.cgi?id=79042

Reviewed by Hajime Morita.

Remove one extra loop that we can combine with the following one
which adds the properties to the parser's list of properties. I also
removed a useless check.
Instruments shows on the css-parser-yui benchmark an improvement
of 13ms (from 77ms spent in the function to 64ms).

No new tests : refactoring, existings tests should cover.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFillShorthand):

09:17 Changeset [108364] by hyatt@apple.com
  • 8 edits
    6 adds in trunk

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=79046

width of overflow:hidden blocks is wrong when their margins overlap floats.

Relevant discussion is here: http://lists.w3.org/Archives/Public/www-style/2012Feb/0954.html

This patch makes the following changes to how objects shrink when avoiding floats:
(1) The containing block width used for percentage calculations is now constant. This means that
an overflow:hidden block with a margin-left of 10% will no longer change what 10% means depending
on the available line width. From a code perspective, containingBlockLogicalWidthForContent and
containingBlockLogicalWidthForContentInRegion no longer contain any special-case code for
shrinkToAvoidFloats() objects.

(2) Now the computation of the logical width for the shrinking object itself handles the adjustments.
Two kinds of adjustments are made for both the start and end margins. Conceptually what we do is shrink
the object to the available line width minus our margins, and then expand the width back out to the content edge
or to the float edge as necessary. If the float fully fits in the margin, then we expand back out to the
content edge. Otherwise if the float doesn't fit, then we expand only to the float edge, making sure our
margin overlaps with the float. This expansion is not performed for negative margins, since our result is already
correct in that case.

Reviewed by Dan Bernstein.

Added the new tests from the thread on www-style about this issue (from Alan Gresley and George Talbot)
in fast/block/float.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::containsFloat):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::containsFloats):
Changed to be const.

(WebCore::RenderBlock::endOffsetForLine):
(WebCore::RenderBlock::endOffsetForContent):
Added endOffsetForXXX methods to mirror their startOffset counterparts. Used by the width adjustment code.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats):
New method that handles shrinking the logical width to the line width (and then re-expanding back out to the
float and/or content edges as needed).

(WebCore::RenderBox::containingBlockLogicalWidthForContent):
(WebCore::RenderBox::containingBlockLogicalWidthForContentInRegion):
Patched to no longer do the shrinking of objects to avoid floats.

(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
Patched to handle calling the new shrinking code to adjust our logical width.

  • rendering/RenderBox.h:

(RenderBox):
The signature of computeLogicalWithUsing changed to be region-specific and to carry along enough information
to efficiently perform the shrinking.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth):
Patched to handle calling the new shrinking code to adjust our logical width.

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=79046

width of overflow:hidden blocks is wrong when their margins overlap floats.

Added new tests from www-style thread: http://lists.w3.org/Archives/Public/www-style/2012Feb/0954.html

Reviewed by Dan Bernstein.

  • fast/block/float/centered-float-avoidance-complexity.html: Added.
  • fast/block/float/shrink-to-avoid-float-complexity.html: Added.
  • platform/mac/fast/block/float/centered-float-avoidance-complexity-expected.png: Added.
  • platform/mac/fast/block/float/centered-float-avoidance-complexity-expected.txt: Added.
  • platform/mac/fast/block/float/shrink-to-avoid-float-complexity-expected.png: Added.
  • platform/mac/fast/block/float/shrink-to-avoid-float-complexity-expected.txt: Added.
09:01 Changeset [108363] by weinig@apple.com
  • 17 edits in trunk

Attempt to fix the Snow Leopard build.

Source/JavaScriptCore:

  • Configurations/Base.xcconfig:

Source/ThirdParty:

  • gtest/xcode/Config/General.xcconfig:

Source/ThirdParty/ANGLE:

  • Configurations/Base.xcconfig:

Source/WebCore:

  • Configurations/Base.xcconfig:

Source/WebKit/mac:

  • Configurations/Base.xcconfig:

Source/WebKit2:

  • Configurations/Base.xcconfig:

Tools:

  • DumpRenderTree/mac/Configurations/Base.xcconfig:
  • MiniBrowser/Configurations/Base.xcconfig:
  • TestWebKitAPI/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/Base.xcconfig:
08:49 Changeset [108362] by ossy@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

[Qt] Unreviewed gardening, add platform specific expected file after r107689.

  • platform/qt-5.0-wk2/http/tests/websocket/test/hybi/bad-sub-protocol-non-ascii-expected.txt: Added.
08:44 Changeset [108361] by weinig@apple.com
  • 17 edits in trunk

Use libc++ when building with Clang on Mac
https://bugs.webkit.org/show_bug.cgi?id=78981

Reviewed by Dan Bernstein.

Source/JavaScriptCore:

  • Configurations/Base.xcconfig:

Source/ThirdParty:

  • gtest/xcode/Config/General.xcconfig:

In addition to enabling libc++ when building with Clang,
disable gtest's use of tr1::tuple, which doesn't exist in
libc++.

Source/ThirdParty/ANGLE:

  • Configurations/Base.xcconfig:

Source/WebCore:

  • Configurations/Base.xcconfig:

Source/WebKit/mac:

  • Configurations/Base.xcconfig:

Source/WebKit2:

  • Configurations/Base.xcconfig:

Tools:

  • DumpRenderTree/mac/Configurations/Base.xcconfig:
  • MiniBrowser/Configurations/Base.xcconfig:
  • TestWebKitAPI/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/Base.xcconfig:
08:38 Changeset [108360] by aroben@apple.com
  • 2 edits in trunk/Source/WebCore

Mac build fix

  • WebCore.xcodeproj/project.pbxproj: Mark TextTrack.h and TextTrackCue.h private so that

WebKit can include them.

08:26 Changeset [108359] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt][WK2] Fix the N9 build
https://bugs.webkit.org/show_bug.cgi?id=79101

Reviewed by Noam Rosenthal.

No new tests needed.

  • platform/graphics/opengl/TextureMapperGL.cpp: Add missing include.
08:26 Changeset [108358] by aroben@apple.com
  • 79 edits
    8 deletes in trunk

Roll out r108309, r108323, and r108326

They broke the 32-bit Lion build.

Original bugs is <http://webkit.org/b/75812> <rdar://problem/10079694>.

Source/JavaScriptCore:

  • CMakeLists.txt:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
  • JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • assembler/LinkBuffer.h:
  • assembler/MacroAssemblerCodeRef.h:
  • bytecode/BytecodeConventions.h: Removed.
  • bytecode/CallLinkStatus.cpp:
  • bytecode/CallLinkStatus.h:
  • bytecode/CodeBlock.cpp:
  • bytecode/CodeBlock.h:
  • bytecode/GetByIdStatus.cpp:
  • bytecode/GetByIdStatus.h:
  • bytecode/Instruction.h:
  • bytecode/LLIntCallLinkInfo.h: Removed.
  • bytecode/MethodCallLinkStatus.cpp:
  • bytecode/Opcode.cpp:
  • bytecode/Opcode.h:
  • bytecode/PutByIdStatus.cpp:
  • bytecode/PutByIdStatus.h:
  • bytecompiler/BytecodeGenerator.cpp:
  • dfg/DFGByteCodeParser.cpp:
  • dfg/DFGCapabilities.h:
  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOperations.cpp:
  • heap/Heap.h:
  • heap/MarkStack.cpp:
  • heap/MarkedAllocator.h:
  • heap/MarkedSpace.h:
  • interpreter/CallFrame.cpp:
  • interpreter/CallFrame.h:
  • interpreter/Interpreter.cpp:
  • interpreter/Interpreter.h:
  • interpreter/RegisterFile.h:
  • jit/ExecutableAllocator.h:
  • jit/HostCallReturnValue.cpp: Removed.
  • jit/HostCallReturnValue.h: Removed.
  • jit/JIT.cpp:
  • jit/JITCode.h:
  • jit/JITDriver.h:
  • jit/JITExceptions.cpp:
  • jit/JITInlineMethods.h:
  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
  • jit/JSInterfaceJIT.h:
  • llint/LLIntCommon.h: Removed.
  • llint/LLIntData.cpp: Removed.
  • llint/LLIntData.h: Removed.
  • llint/LLIntEntrypoints.cpp: Removed.
  • llint/LLIntEntrypoints.h: Removed.
  • llint/LLIntExceptions.cpp: Removed.
  • llint/LLIntExceptions.h: Removed.
  • llint/LLIntOfflineAsmConfig.h: Removed.
  • llint/LLIntOffsetsExtractor.cpp: Removed.
  • llint/LLIntSlowPaths.cpp: Removed.
  • llint/LLIntSlowPaths.h: Removed.
  • llint/LLIntThunks.cpp: Removed.
  • llint/LLIntThunks.h: Removed.
  • llint/LowLevelInterpreter.asm: Removed.
  • llint/LowLevelInterpreter.cpp: Removed.
  • llint/LowLevelInterpreter.h: Removed.
  • offlineasm/armv7.rb: Removed.
  • offlineasm/asm.rb: Removed.
  • offlineasm/ast.rb: Removed.
  • offlineasm/backends.rb: Removed.
  • offlineasm/generate_offset_extractor.rb: Removed.
  • offlineasm/instructions.rb: Removed.
  • offlineasm/offset_extractor_constants.rb: Removed.
  • offlineasm/offsets.rb: Removed.
  • offlineasm/opt.rb: Removed.
  • offlineasm/parser.rb: Removed.
  • offlineasm/registers.rb: Removed.
  • offlineasm/self_hash.rb: Removed.
  • offlineasm/settings.rb: Removed.
  • offlineasm/transform.rb: Removed.
  • offlineasm/x86.rb: Removed.
  • runtime/CodeSpecializationKind.h: Removed.
  • runtime/CommonSlowPaths.h:
  • runtime/Executable.cpp:
  • runtime/Executable.h:
  • runtime/ExecutionHarness.h: Removed.
  • runtime/JSArray.h:
  • runtime/JSCell.h:
  • runtime/JSFunction.h:
  • runtime/JSGlobalData.cpp:
  • runtime/JSGlobalData.h:
  • runtime/JSGlobalObject.h:
  • runtime/JSObject.h:
  • runtime/JSPropertyNameIterator.h:
  • runtime/JSString.h:
  • runtime/JSTypeInfo.h:
  • runtime/JSValue.cpp:
  • runtime/JSValue.h:
  • runtime/JSVariableObject.h:
  • runtime/Options.cpp:
  • runtime/Options.h:
  • runtime/ScopeChain.h:
  • runtime/Structure.cpp:
  • runtime/Structure.h:
  • runtime/StructureChain.h:
  • wtf/InlineASM.h:
  • wtf/Platform.h:
  • wtf/SentinelLinkedList.h:
  • wtf/text/StringImpl.h:

Source/WebCore:

  • CMakeLists.txt:

Source/WebKit:

  • CMakeLists.txt:

Tools:

  • DumpRenderTree/efl/CMakeLists.txt:
08:20 Changeset [108357] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt]REGRESSION(r92254): It made 2 tests timeout
https://bugs.webkit.org/show_bug.cgi?id=65609

  • platform/qt/Skipped: Unskip now passing tests.
08:17 Changeset [108356] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [SuggestBox] textPrompt.css disablement displays garbled suggest box
https://bugs.webkit.org/show_bug.cgi?id=79107

Reviewed by Pavel Feldman.

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.SuggestBox):
(WebInspector.TextPrompt.SuggestBox.prototype.get visible):
(WebInspector.TextPrompt.SuggestBox.prototype.hide):
(WebInspector.TextPrompt.SuggestBox.prototype.removeFromElement):
(WebInspector.TextPrompt.SuggestBox.prototype._completionsReady):

  • inspector/front-end/textPrompt.css:

(.suggest-box):

08:14 Changeset [108355] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: timeline hangs on a page with deep chain of nested events.
https://bugs.webkit.org/show_bug.cgi?id=79106

Use stack of states instead of recursive calls when traversing records tree to
avoid stack overflow.

Reviewed by Pavel Feldman.

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane.prototype._forAllRecords):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._filterRecords):

07:56 Changeset [108354] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [crash] upon style modification after navigation
https://bugs.webkit.org/show_bug.cgi?id=79108

Reviewed by Yury Semikhatsky.

  • inspector/InspectorHistory.cpp:

(WebCore::InspectorHistory::undo):
(WebCore::InspectorHistory::redo):
(WebCore::InspectorHistory::reset):

07:52 Changeset [108353] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

Use WTF::cryptographicallyRandomValues in FileSystemWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=79089

Reviewed by Adam Roben.

Avoid loading and unloading of the crypto library during every
call to openTemporaryFile() and make the code easier.

  • platform/win/FileSystemWin.cpp:

(WebCore::openTemporaryFile):

07:31 Changeset [108352] by ossy@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove stylesheet pointer from StylePropertySet
https://bugs.webkit.org/show_bug.cgi?id=79092

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2012-02-21
Reviewed by Csaba Osztrogonác.

Qt buildfix after r108345.

  • css/CSSParser.cpp:

(WebCore::parseColorValue):

07:14 Changeset [108351] by ossy@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove stylesheet pointer from StylePropertySet
https://bugs.webkit.org/show_bug.cgi?id=79092

Reviewed by Antti Koivisto.

Qt buildfix after r108345. We need this workaround because of buggy gcc (4.4.5), which
reported a false warning: 'value$m_ptr' may be used uninitialized in this function

  • css/CSSParser.cpp:

(WebCore::parseSimpleLengthValue):

06:39 WebKitGTK/1.8.x edited by kov@webkit.org
merged Does not build on IA64, SPARC and Alpha (diff)
06:37 Changeset [108350] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

Shrink attribute style property sets after populating them.
<http://webkit.org/b/78972>

Reviewed by Antti Koivisto.

Add a StylePropertySet::shrinkToFit() and call it at the end of updateStyleAttribute()
to minimize the amount of wasted space.

  • css/StylePropertySet.h:

(WebCore::StylePropertySet::shrinkToFit):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::updateAttributeStyle):

06:33 WebKitEFLLayoutTest edited by gyuyoung.kim@samsung.com
Modify build options to build WebKit EFL (diff)
06:20 Changeset [108349] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip new failing and crashing test to paint the bot green.

  • platform/qt-mac/Skipped:
06:09 Changeset [108348] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/JavaScriptCore

Merging r108347

06:06 Changeset [108347] by kov@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Does not build on IA64, SPARC and Alpha
https://bugs.webkit.org/show_bug.cgi?id=79047

Patch by Gustavo Noronha Silva <kov@debian.org> and Bob Tracy <rct@frus.com> on 2012-02-21
Rubber-stamped by Kent Tamura.

  • wtf/dtoa/utils.h: these architectures also have correct double

operations, so add them to the appropriate side of the check.

05:53 Changeset [108346] by ossy@webkit.org
  • 4 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, unskip now passing tests.

  • platform/qt-4.8/Skipped:
  • platform/qt-5.0-wk2/Skipped:
  • platform/wk2/Skipped:
05:49 Changeset [108345] by antti@apple.com
  • 35 edits in trunk/Source/WebCore

Remove stylesheet pointer from StylePropertySet
https://bugs.webkit.org/show_bug.cgi?id=79092

Reviewed by Andreas Kling.

The context should be passed as an argument for CSS parser invoking setters that actually need it.

  • Remove the context stylesheet pointer.
  • Add context stylesheet argument to setters.
  • Drop an unnecessary StylePropertySet constructor, pass strict parsing flag directly.
  • Adapt to changes by passing in the context stylesheet where needed.
  • Add StyledElement::applyPresentationAttributeToStyle helpers for building up the attribute style.
  • css/CSSFontFaceRule.cpp:

(WebCore::CSSFontFaceRule::addSubresourceStyleURLs):

  • css/CSSParser.cpp:

(WebCore::parseColorValue):
(WebCore::parseSimpleLengthValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseDeclaration):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createKeyframeRule):

  • css/CSSParser.h:

(CSSParser):

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::addSubresourceStyleURLs):

  • css/StylePropertySet.cpp:

(WebCore::PropertySetCSSStyleDeclaration::contextStyleSheet):
(WebCore::PropertySetCSSStyleDeclaration::setNeedsStyleRecalc):
(RuleCSSStyleDeclaration):
(InlineCSSStyleDeclaration):
(WebCore):
(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet::parseDeclaration):
(WebCore::StylePropertySet::addSubresourceStyleURLs):
(WebCore::StylePropertySet::clearParentRule):
(WebCore::StylePropertySet::clearParentElement):
(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
(WebCore::PropertySetCSSStyleDeclaration::parentStyleSheet):
(WebCore::RuleCSSStyleDeclaration::setNeedsStyleRecalc):
(WebCore::RuleCSSStyleDeclaration::contextStyleSheet):
(WebCore::InlineCSSStyleDeclaration::contextStyleSheet):
(SameSizeAsStylePropertySet):

  • css/StylePropertySet.h:

(WebCore::StylePropertySet::create):
(StylePropertySet):

  • css/WebKitCSSMatrix.cpp:

(WebCore::WebKitCSSMatrix::setMatrixValue):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::ensureInlineStyleDecl):

  • dom/StyledElement.cpp:

(WebCore):
(WebCore::StyledElement::parseAttribute):
(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::addSubresourceAttributeURLs):
(WebCore::StyledElement::updateAttributeStyle):

  • dom/StyledElement.h:

(StyledElement):
(WebCore::StyledElement::applyPresentationAttributeToStyle):
(WebCore):

  • html/HTMLBRElement.cpp:

(WebCore::HTMLBRElement::collectStyleForAttribute):

  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::collectStyleForAttribute):

  • html/HTMLDivElement.cpp:

(WebCore::HTMLDivElement::collectStyleForAttribute):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::applyBorderAttributeToStyle):
(WebCore::HTMLElement::mapLanguageAttributeToLocale):
(WebCore::HTMLElement::collectStyleForAttribute):
(WebCore::HTMLElement::applyAlignmentAttributeToStyle):
(WebCore::HTMLElement::addHTMLLengthToStyle):
(WebCore::HTMLElement::addHTMLColorToStyle):

  • html/HTMLElement.h:

(HTMLElement):

  • html/HTMLFontElement.cpp:

(WebCore::HTMLFontElement::collectStyleForAttribute):

  • html/HTMLHRElement.cpp:

(WebCore::HTMLHRElement::collectStyleForAttribute):

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::collectStyleForAttribute):

  • html/HTMLLIElement.cpp:

(WebCore::HTMLLIElement::collectStyleForAttribute):

  • html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::collectStyleForAttribute):

  • html/HTMLOListElement.cpp:

(WebCore::HTMLOListElement::collectStyleForAttribute):

  • html/HTMLParagraphElement.cpp:

(WebCore::HTMLParagraphElement::collectStyleForAttribute):

  • html/HTMLTableCaptionElement.cpp:

(WebCore::HTMLTableCaptionElement::collectStyleForAttribute):

  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::collectStyleForAttribute):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::collectStyleForAttribute):

  • html/HTMLTablePartElement.cpp:

(WebCore::HTMLTablePartElement::collectStyleForAttribute):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::collectStyleForAttribute):

  • html/HTMLUListElement.cpp:

(WebCore::HTMLUListElement::collectStyleForAttribute):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setFont):

  • mathml/MathMLElement.cpp:

(WebCore::MathMLElement::collectStyleForAttribute):

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::insertedIntoDocument):
(WebCore::SVGFontFaceElement::removedFromDocument):
(WebCore::SVGFontFaceElement::removeFromMappedElementSheet):

  • svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::collectStyleForAttribute):

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::collectStyleForAttribute):

  • svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::collectStyleForAttribute):

05:10 Changeset [108344] by yurys@chromium.org
  • 15 edits in trunk/Source

[V8] Web Inspector: set breakpoint/pause doesn't work when worker is in a tight loop
https://bugs.webkit.org/show_bug.cgi?id=79097

Source/WebCore:

Worker script will be interrupted to dispatch all arriving inspector commands.
This way debugger will be operable even if worker is in a tight loop.

Reviewed by Pavel Feldman.

  • bindings/js/ScriptDebugServer.h:

(Task):
(WebCore::ScriptDebugServer::Task::~Task):
(ScriptDebugServer):

  • bindings/js/WorkerScriptDebugServer.cpp:

(WebCore::WorkerScriptDebugServer::interruptAndRunTask):
(WebCore):

  • bindings/js/WorkerScriptDebugServer.h:

(WorkerScriptDebugServer):

  • bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::interruptAndRun):

  • bindings/v8/ScriptDebugServer.h:

(ScriptDebugServer):

  • bindings/v8/WorkerScriptDebugServer.cpp:

(WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
(WebCore::WorkerScriptDebugServer::interruptAndRunTask):
(WebCore):

  • bindings/v8/WorkerScriptDebugServer.h:

(v8):
(WebCore):
(WorkerScriptDebugServer):

  • inspector/WorkerDebuggerAgent.cpp:

(WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):
(WebCore::WorkerDebuggerAgent::~WorkerDebuggerAgent):
(WebCore):
(WebCore::WorkerDebuggerAgent::interruptAndDispatchInspectorCommands):

  • inspector/WorkerDebuggerAgent.h:

(WebCore):
(WorkerDebuggerAgent):

  • workers/WorkerMessagingProxy.cpp:

(WebCore):
(WebCore::WorkerMessagingProxy::sendMessageToInspector):

  • workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::run):
(WebCore::WorkerRunLoop::runInMode):

  • workers/WorkerRunLoop.h:

(WorkerRunLoop):

Source/WebKit/chromium:

Worker script execution will be interrupted for dispatching inspector commands.

Reviewed by Pavel Feldman.

  • src/WebSharedWorkerImpl.cpp:

(WebKit::WebSharedWorkerImpl::dispatchDevToolsMessage):

05:05 Changeset [108343] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] 3 SVG tests assert after r107207
https://bugs.webkit.org/show_bug.cgi?id=78332

  • platform/qt/Skipped: Skip 3 more asserting test.
04:38 Changeset [108342] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] REGRESSION(r108112): sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.2_decodeURIComponent/S15.1.3.2_A1.2_T2.html crashes intermittently
https://bugs.webkit.org/show_bug.cgi?id=79029

  • platform/qt/Skipped: Skip new crashing test.
04:34 Changeset [108341] by ossy@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] tst_QWebPage::infiniteLoopJS() timeouts with DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=79040

Reviewed by Simon Hausmann.

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage): Disable tst_QWebPage::infiniteLoopJS() until proper fix.

04:26 Changeset [108340] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Not reviewed: fixing Mac build (take 2).

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::setShowPaintRects):

04:16 Changeset [108339] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, skip new failing mediastream test on GTK.

  • platform/gtk/Skipped:
04:13 Changeset [108338] by pfeldman@chromium.org
  • 7 edits in trunk/Source/WebCore

Not reviewed: fixing Mac build.

  • inspector/DOMNodeHighlighter.cpp:

(WebCore::DOMNodeHighlighter::drawOutline):

  • inspector/DOMNodeHighlighter.h:

(DOMNodeHighlighter):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willPaintImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willPaint):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::willPaint):
(WebCore::InspectorPageAgent::didPaint):

  • inspector/InspectorPageAgent.h:
04:04 Changeset [108337] by vsevik@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: Switch Debugger agent to TypeBuilder
https://bugs.webkit.org/show_bug.cgi?id=78390

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-21
Reviewed by Vsevolod Vlasov.

Client code is switched to TypeBuilder.

  • inspector/CodeGeneratorInspector.py:
  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::getFunctionDetails):
(WebCore::InjectedScript::getProperties):
(WebCore::InjectedScript::wrapCallFrames):

  • inspector/InjectedScript.h:

(InjectedScript):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::getFunctionDetails):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::currentCallFrames):
(WebCore::InspectorDebuggerAgent::didParseSource):

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

04:00 Changeset [108336] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Not reviewed: fixing poor merge in r108332.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.prototype._handleSelectorClick):

  • inspector/front-end/externs.js:
03:47 Changeset [108335] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Styles] Rule source URL tooltip should show line number
https://bugs.webkit.org/show_bug.cgi?id=79087

Reviewed by Pavel Feldman.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection):
(WebInspector.StylePropertiesSection.prototype._createRuleOriginNode):

03:46 Changeset [108334] by philn@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

Fix one more GTK+ unit test after r108278.

Reviewed by Alejandro G. Castro.

  • tests/testkeyevents.c:

(map_event_cb): No longer grab focus here.
(setup_keyevent_test): Grabbing focus here seems to be late enough in the process.

03:34 Changeset [108333] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Print warning when importing experimental WK2 APIs in QML
https://bugs.webkit.org/show_bug.cgi?id=78817

Patch by Andras Becsi <andras.becsi@nokia.com> on 2012-02-21
Reviewed by Simon Hausmann.

  • declarative/experimental/plugin.cpp:
03:32 Changeset [108332] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: clicking empty space should not re-enter edit mode
https://bugs.webkit.org/show_bug.cgi?id=79024

Patch by Pavel Feldman <pfeldman@chomium.org> on 2012-02-21
Reviewed by Vsevolod Vlasov.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection):
(WebInspector.StylePropertiesSection.prototype._handleEmptySpaceMouseDown):
(WebInspector.StylePropertiesSection.prototype._handleEmptySpaceClick):

03:30 Changeset [108331] by pfeldman@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: evaluate on hover does not work for large files.
https://bugs.webkit.org/show_bug.cgi?id=79015

Patch by Pavel Feldman <pfeldman@chomium.org> on 2012-02-21
Reviewed by Yury Semikhatsky.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype._getPopoverAnchor):
(WebInspector.JavaScriptSourceFrame.prototype._highlightExpression):

  • inspector/front-end/Popover.js:

(WebInspector.PopoverHelper.prototype._handleMouseAction):

  • inspector/front-end/SourceJavaScriptTokenizer.js:

(WebInspector.SourceJavaScriptTokenizer):
(WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):

  • inspector/front-end/SourceJavaScriptTokenizer.re2js:
03:28 Changeset [108330] by pfeldman@chromium.org
  • 15 edits in trunk/Source/WebCore

Web Inspector: add "show paint rectangles" setting.
https://bugs.webkit.org/show_bug.cgi?id=79030

Reviewed by Yury Semikhatsky.

  • English.lproj/localizedStrings.js:
  • inspector/DOMNodeHighlighter.cpp:

(WebCore::DOMNodeHighlighter::drawOutline):
(DOMNodeHighlighter):

  • inspector/DOMNodeHighlighter.h:

(WebCore):
(DOMNodeHighlighter):

  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willPaintImpl):
(WebCore::InspectorInstrumentation::didPaintImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willPaint):

  • inspector/InspectorPageAgent.cpp:

(PageAgentState):
(WebCore::InspectorPageAgent::create):
(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::setShowPaintRects):
(WebCore):
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
(WebCore::InspectorPageAgent::willPaint):
(WebCore::InspectorPageAgent::didPaint):
(WebCore::InspectorPageAgent::buildObjectForFrame):

  • inspector/InspectorPageAgent.h:

(WebCore):

  • inspector/front-end/Settings.js:

(WebInspector.Settings):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):
(WebInspector.SettingsScreen.prototype._showPaintRectsChanged):

  • inspector/front-end/inspector.js:
  • page/FrameView.cpp:

(WebCore::FrameView::paintContents):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintContents):

03:26 Changeset [108329] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Clean-up project file after r108310

Reviewed by Csaba Osztrogonác.

No new tests needed.

  • Target.pri: Fix path for TextTrack headers.
02:57 Changeset [108328] by abecsi@webkit.org
  • 13 edits in trunk

[Qt][WK2] Get rid of the dependency to QtWidgets
https://bugs.webkit.org/show_bug.cgi?id=76276

Reviewed by Simon Hausmann.

Source/WebKit2:

  • Target.pri:
  • UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp:

(main):

  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
  • UIProcess/API/qt/tests/tests.pri:
  • UIProcess/API/qt/tests/util.h:

Tools:

  • MiniBrowser/qt/MiniBrowser.pro:
  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::MiniBrowserApplication):
(MiniBrowserApplication::notify):
(MiniBrowserApplication::sendTouchEvent):

  • MiniBrowser/qt/MiniBrowserApplication.h:

(MiniBrowserApplication):

  • QtTestBrowser/locationedit.h:
  • WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:

(WTR::activateFonts):

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:
02:33 Changeset [108327] by philn@webkit.org
  • 4 edits
    14 adds in trunk

[GStreamer] media/W3C failures
https://bugs.webkit.org/show_bug.cgi?id=75078

Reviewed by Martin Robinson.

Source/WebCore:

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::load): Clean out everything
after file:// url path to cope with media/W3C tests loading
file:///path/to/media.ext?some parameters.

LayoutTests:

Unskip now passing tests and add GTK baselines for them.

  • platform/gtk/Skipped:
  • platform/gtk/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Added.
  • platform/gtk/media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt: Added.
  • platform/gtk/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Added.
  • platform/gtk/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt: Added.
  • platform/gtk/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Added.
  • platform/gtk/media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt: Added.
  • platform/gtk/media/W3C/video/canPlayType/canPlayType_two_implies_one_2-expected.txt: Added.
  • platform/gtk/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt: Added.
  • platform/gtk/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt: Added.
01:49 Changeset [108326] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Fix massive crashes in all tests introduced by previous build fix, and fix non-DFG build.
https://bugs.webkit.org/show_bug.cgi?id=75812

Reviewed by Csaba Osztrogonác.

  • dfg/DFGOperations.cpp:

(JSC):

  • jit/HostCallReturnValue.h:

(JSC::initializeHostCallReturnValue):

01:29 SettingUpDevelopmentEnvironmentForN9 edited by zarvai@inf.u-szeged.hu
(diff)
01:20 Changeset [108325] by mlilek@apple.com
  • 2 edits in trunk/Source/WebCore

Not reviewed, build fix for non-client-based Geolocation builds after r107982.

  • page/Geolocation.cpp:
01:09 Changeset [108324] by yurys@chromium.org
  • 6 edits in trunk/Source/WebCore

[V8] Web Inspector: simplify worker debugger implementation
https://bugs.webkit.org/show_bug.cgi?id=79085

There is one instance of WorkerScriptDebugServer per worker thread. We don't
need to resolve WorkerContext from V8::Context anymore.

Reviewed by Pavel Feldman.

  • bindings/v8/WorkerScriptDebugServer.cpp:

(WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
(WebCore::WorkerScriptDebugServer::addListener):
(WebCore::WorkerScriptDebugServer::removeListener):
(WebCore::WorkerScriptDebugServer::getDebugListenerForContext):
(WebCore::WorkerScriptDebugServer::runMessageLoopOnPause):

  • bindings/v8/WorkerScriptDebugServer.h:

(WorkerScriptDebugServer):

  • inspector/WorkerDebuggerAgent.cpp:

(WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):
(WebCore::WorkerDebuggerAgent::startListeningScriptDebugServer):
(WebCore::WorkerDebuggerAgent::stopListeningScriptDebugServer):

01:09 Changeset [108323] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Attempted build fix for ELF platforms.

  • dfg/DFGOperations.cpp:

(JSC):
(JSC::getHostCallReturnValueWithExecState):

  • jit/HostCallReturnValue.cpp:

(JSC):

  • jit/HostCallReturnValue.h:

(JSC::initializeHostCallReturnValue):

01:00 Changeset [108322] by haraken@chromium.org
  • 6 edits
    1 add in trunk/Source/WebCore

Enable the IDL attribute checker in Chromium
https://bugs.webkit.org/show_bug.cgi?id=79082

Reviewed by Adam Barth.

We have fixed 10~ bugs caused by typos of IDL attributes.
This patch adds an IDL attribute checker, which checks if all IDL attributes
used in IDL files are implemented by code generators.

  • The IDL attribute checker uses IDLAttributes.txt, which lists all IDL attributes implemented in code generators. If we want to add a new IDL attribute, we need to add it to IDLAttributes.txt manually.
  • The IDL attribute checker checks if all IDL attributes used in IDL files are listed in IDLAttributes.txt.
  • If the IDL attribute checker fails, the build fails with a verbose error message.

No tests. I manually checked that [Custommm], [CallWith=],
[CallWith=ScriptExecutionContext|Foo] cause build failures.

  • WebCore.gyp/WebCore.gyp: Modified to enable the IDL attribute checker.
  • bindings/scripts/resolve-supplemental.pl:

(loadIDLAttributes): This method loads a list of IDL attributes from IDLAttributes.txt.
(checkIDLAttributes): This method implementes the IDL attribute checker as described above.
(checkIfIDLAttributesExists):

  • bindings/scripts/IDLParser.pm: "1" is not good to represent that

the IDL attribute does not have any value. This patch changed it to "VALUE_IS_MISSING".
(parseExtendedAttributes):
(ParseInterface):

  • bindings/scripts/CodeGenerator.pm: Ditto.

(ContentAttributeName):

  • bindings/scripts/CodeGeneratorV8.pm: Ditto.

(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateSingleBatchedAttribute):
(GetRuntimeEnableFunctionName):

  • bindings/scripts/IDLAttributes.txt: Added. This file lists all IDL attributes implemented

in code generators.

00:43 Changeset [108321] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

Use Win32 API to get file information
https://bugs.webkit.org/show_bug.cgi?id=55336

Reviewed by Adam Roben.

Use FindFirstFile() in favour over _wstat64() to share the code with WinCE.

  • platform/win/FileSystemWin.cpp:

(WebCore):
(WebCore::getFindData):
(WebCore::getFileSize):
(WebCore::getFileModificationTime):
(WebCore::fileExists):

00:25 Changeset [108320] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, update test expectations to reflect recent flakiness.

  • platform/chromium/test_expectations.txt:
00:19 Changeset [108319] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

Rebaseline a test for GTK+.

  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: New baseline.
00:10 Changeset [108318] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

Skip some test that are failing after r108278.

  • platform/gtk/Skipped: Skip a few tests.

02/20/12:

23:54 Changeset [108317] by abarth@webkit.org
  • 2 edits in trunk/Tools

mastercfg_unittest.py fails without simplejson
https://bugs.webkit.org/show_bug.cgi?id=79070

Reviewed by Csaba Osztrogonác.

Now that we require Python 2.6 (and higher) we can import json rather
than simplejson. We still need to use the simplejson name because
that's what the master.cfg script expects.

  • BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:

(BuildBotConfigLoader._add_dependant_modules_to_sys_modules):

23:51 Changeset [108316] by mrobinson@webkit.org
  • 3 edits in releases/WebKitGTK/webkit-1.8/Source/JavaScriptCore

Merging r108279

23:49 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
23:48 WebKitGTK/WebKit2Roadmap edited by carlosgc@webkit.org
(diff)
23:47 Changeset [108315] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk

Merging r108313

23:46 Changeset [108314] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk

Merging r108312

23:45 Changeset [108313] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

Fix GTK+ unit tests after r108281.

Reviewed by Alejandro G. Castro.

  • tests/testwebplugindatabase.c:

(test_webkit_web_plugin_database_get_plugins): Update the description used
in the test.

23:44 Changeset [108312] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

Fix GTK+ unit tests after r108278.

Reviewed by Alejandro G. Castro.

Now that WebCore is no longer stealing focus, we need to
adjust where we grab focus to ensure that it actually succeeds.

  • tests/testcopyandpaste.c:

(map_event_cb): No longer grab focus here.
(runPasteTestCallback): Grabbing focus here seems to be late enough in the process.

23:41 WebKitGTK/WebKit2Roadmap edited by carlosgc@webkit.org
(diff)
23:32 Changeset [108311] by abarth@webkit.org
  • 4 edits in trunk

Invalid cast in WebCore::toElement / WebCore::HTMLElementStack::ElementRecord::element
https://bugs.webkit.org/show_bug.cgi?id=78975

Reviewed by Eric Seidel.

Source/WebCore:

We're supposed to set the action attribute on the form element we just
created. Previously, we assumed the newly created form element would
be on the top of the stack of open elements, but if we're in the table
body insertion mode, the form element gets treated as self closing and
is therefore popped off the stack of open elements.

Fortunately, we already cache a pointer to the most recently inserted
form element on the HTMLConstructionSite, so we can just grab the
element from there.

Test: html5lib/runner.html

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processIsindexStartTagForInBody):
(WebCore):

LayoutTests:

  • html5lib/resourcesl/webkit-02.dat:
23:07 Changeset [108310] by abarth@webkit.org
  • 7 edits
    11 moves in trunk/Source/WebCore

Unite TextTrack-related files with their friends in WebCore/html/track
https://bugs.webkit.org/show_bug.cgi?id=78941

Reviewed by Eric Seidel.

The code that supports <track> seems to be split between the
WebCore/html directory and the WebCore/html/track directory. This
patch unites this code in the WebCore/html/track directory.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • html/LoadableTextTrack.cpp: Removed.
  • html/LoadableTextTrack.h: Removed.
  • html/TextTrack.cpp: Removed.
  • html/TextTrack.h: Removed.
  • html/TextTrack.idl: Removed.
  • html/TextTrackCue.cpp: Removed.
  • html/TextTrackCue.h: Removed.
  • html/TextTrackCue.idl: Removed.
  • html/TextTrackCueList.cpp: Removed.
  • html/TextTrackCueList.h: Removed.
  • html/TextTrackCueList.idl: Removed.
  • html/track/LoadableTextTrack.cpp: Copied from Source/WebCore/html/LoadableTextTrack.cpp.
  • html/track/LoadableTextTrack.h: Copied from Source/WebCore/html/LoadableTextTrack.h.
  • html/track/TextTrack.cpp: Copied from Source/WebCore/html/TextTrack.cpp.
  • html/track/TextTrack.h: Copied from Source/WebCore/html/TextTrack.h.
  • html/track/TextTrack.idl: Copied from Source/WebCore/html/TextTrack.idl.
  • html/track/TextTrackCue.cpp: Copied from Source/WebCore/html/TextTrackCue.cpp.
  • html/track/TextTrackCue.h: Copied from Source/WebCore/html/TextTrackCue.h.
  • html/track/TextTrackCue.idl: Copied from Source/WebCore/html/TextTrackCue.idl.
  • html/track/TextTrackCueList.cpp: Copied from Source/WebCore/html/TextTrackCueList.cpp.
  • html/track/TextTrackCueList.h: Copied from Source/WebCore/html/TextTrackCueList.h.
  • html/track/TextTrackCueList.idl: Copied from Source/WebCore/html/TextTrackCueList.idl.
22:49 Changeset [108309] by fpizlo@apple.com
  • 79 edits
    39 adds in trunk

JSC should be a triple-tier VM
https://bugs.webkit.org/show_bug.cgi?id=75812
<rdar://problem/10079694>

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

Implemented an interpreter that uses the JIT's calling convention. This
interpreter is called LLInt, or the Low Level Interpreter. JSC will now
will start by executing code in LLInt and will only tier up to the old
JIT after the code is proven hot.

LLInt is written in a modified form of our macro assembly. This new macro
assembly is compiled by an offline assembler (see offlineasm), which
implements many modern conveniences such as a Turing-complete CPS-based
macro language and direct access to relevant C++ type information
(basically offsets of fields and sizes of structs/classes).

Code executing in LLInt appears to the rest of the JSC world "as if" it
were executing in the old JIT. Hence, things like exception handling and
cross-execution-engine calls just work and require pretty much no
additional overhead.

This interpreter is 2-2.5x faster than our old interpreter on SunSpider,
V8, and Kraken. With triple-tiering turned on, we're neutral on SunSpider,
V8, and Kraken, but appear to get a double-digit improvement on real-world
websites due to a huge reduction in the amount of JIT'ing.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
  • JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • assembler/LinkBuffer.h:
  • assembler/MacroAssemblerCodeRef.h:

(MacroAssemblerCodePtr):
(JSC::MacroAssemblerCodePtr::createFromExecutableAddress):

  • bytecode/BytecodeConventions.h: Added.
  • bytecode/CallLinkStatus.cpp:

(JSC::CallLinkStatus::computeFromLLInt):
(JSC):
(JSC::CallLinkStatus::computeFor):

  • bytecode/CallLinkStatus.h:

(JSC::CallLinkStatus::isSet):
(JSC::CallLinkStatus::operator!):
(CallLinkStatus):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC):
(JSC::CodeBlock::unlinkCalls):
(JSC::CodeBlock::unlinkIncomingCalls):
(JSC::CodeBlock::bytecodeOffset):
(JSC::ProgramCodeBlock::jettison):
(JSC::EvalCodeBlock::jettison):
(JSC::FunctionCodeBlock::jettison):
(JSC::ProgramCodeBlock::jitCompileImpl):
(JSC::EvalCodeBlock::jitCompileImpl):
(JSC::FunctionCodeBlock::jitCompileImpl):

  • bytecode/CodeBlock.h:

(JSC):
(CodeBlock):
(JSC::CodeBlock::baselineVersion):
(JSC::CodeBlock::linkIncomingCall):
(JSC::CodeBlock::bytecodeOffset):
(JSC::CodeBlock::jitCompile):
(JSC::CodeBlock::hasOptimizedReplacement):
(JSC::CodeBlock::addPropertyAccessInstruction):
(JSC::CodeBlock::addGlobalResolveInstruction):
(JSC::CodeBlock::addLLIntCallLinkInfo):
(JSC::CodeBlock::addGlobalResolveInfo):
(JSC::CodeBlock::numberOfMethodCallLinkInfos):
(JSC::CodeBlock::valueProfilePredictionForBytecodeOffset):
(JSC::CodeBlock::likelyToTakeSlowCase):
(JSC::CodeBlock::couldTakeSlowCase):
(JSC::CodeBlock::likelyToTakeSpecialFastCase):
(JSC::CodeBlock::likelyToTakeDeepestSlowCase):
(JSC::CodeBlock::likelyToTakeAnySlowCase):
(JSC::CodeBlock::addFrequentExitSite):
(JSC::CodeBlock::dontJITAnytimeSoon):
(JSC::CodeBlock::jitAfterWarmUp):
(JSC::CodeBlock::jitSoon):
(JSC::CodeBlock::llintExecuteCounter):
(ProgramCodeBlock):
(EvalCodeBlock):
(FunctionCodeBlock):

  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFromLLInt):
(JSC):
(JSC::GetByIdStatus::computeFor):

  • bytecode/GetByIdStatus.h:

(JSC::GetByIdStatus::GetByIdStatus):
(JSC::GetByIdStatus::wasSeenInJIT):
(GetByIdStatus):

  • bytecode/Instruction.h:

(JSC):
(JSC::Instruction::Instruction):
(Instruction):

  • bytecode/LLIntCallLinkInfo.h: Added.

(JSC):
(JSC::LLIntCallLinkInfo::LLIntCallLinkInfo):
(LLIntCallLinkInfo):
(JSC::LLIntCallLinkInfo::~LLIntCallLinkInfo):
(JSC::LLIntCallLinkInfo::isLinked):
(JSC::LLIntCallLinkInfo::unlink):

  • bytecode/MethodCallLinkStatus.cpp:

(JSC::MethodCallLinkStatus::computeFor):

  • bytecode/Opcode.cpp:

(JSC):

  • bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFromLLInt):
(JSC):
(JSC::PutByIdStatus::computeFor):

  • bytecode/PutByIdStatus.h:

(PutByIdStatus):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveWithBase):
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::emitPutById):
(JSC::BytecodeGenerator::emitDirectPutById):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):
(JSC::BytecodeGenerator::emitCatch):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOperations.cpp:
  • heap/Heap.h:

(JSC):
(JSC::Heap::firstAllocatorWithoutDestructors):
(Heap):

  • heap/MarkStack.cpp:

(JSC::visitChildren):

  • heap/MarkedAllocator.h:

(JSC):
(MarkedAllocator):

  • heap/MarkedSpace.h:

(JSC):
(MarkedSpace):
(JSC::MarkedSpace::firstAllocator):

  • interpreter/CallFrame.cpp:

(JSC):
(JSC::CallFrame::bytecodeOffsetForNonDFGCode):
(JSC::CallFrame::setBytecodeOffsetForNonDFGCode):
(JSC::CallFrame::currentVPC):
(JSC::CallFrame::setCurrentVPC):
(JSC::CallFrame::trueCallerFrame):

  • interpreter/CallFrame.h:

(JSC::ExecState::hasReturnPC):
(JSC::ExecState::clearReturnPC):
(ExecState):
(JSC::ExecState::bytecodeOffsetForNonDFGCode):
(JSC::ExecState::currentVPC):
(JSC::ExecState::setCurrentVPC):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::Interpreter):
(JSC::Interpreter::~Interpreter):
(JSC):
(JSC::Interpreter::initialize):
(JSC::Interpreter::isOpcode):
(JSC::Interpreter::unwindCallFrame):
(JSC::getCallerInfo):
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::retrieveLastCaller):

  • interpreter/Interpreter.h:

(JSC):
(Interpreter):
(JSC::Interpreter::getOpcode):
(JSC::Interpreter::getOpcodeID):
(JSC::Interpreter::classicEnabled):

  • interpreter/RegisterFile.h:

(JSC):
(RegisterFile):

  • jit/ExecutableAllocator.h:

(JSC):

  • jit/HostCallReturnValue.cpp: Added.

(JSC):
(JSC::getHostCallReturnValueWithExecState):

  • jit/HostCallReturnValue.h: Added.

(JSC):
(JSC::initializeHostCallReturnValue):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):

  • jit/JITCode.h:

(JSC::JITCode::isOptimizingJIT):
(JITCode):
(JSC::JITCode::isBaselineCode):
(JSC::JITCode::JITCode):

  • jit/JITDriver.h:

(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):

  • jit/JITExceptions.cpp:

(JSC::jitThrow):

  • jit/JITInlineMethods.h:

(JSC::JIT::updateTopCallFrame):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):
(JSC):

  • jit/JITStubs.h:

(JSC):

  • jit/JSInterfaceJIT.h:
  • llint: Added.
  • llint/LLIntCommon.h: Added.
  • llint/LLIntData.cpp: Added.

(LLInt):
(JSC::LLInt::Data::Data):
(JSC::LLInt::Data::performAssertions):
(JSC::LLInt::Data::~Data):

  • llint/LLIntData.h: Added.

(JSC):
(LLInt):
(Data):
(JSC::LLInt::Data::exceptionInstructions):
(JSC::LLInt::Data::opcodeMap):
(JSC::LLInt::Data::performAssertions):

  • llint/LLIntEntrypoints.cpp: Added.

(LLInt):
(JSC::LLInt::getFunctionEntrypoint):
(JSC::LLInt::getEvalEntrypoint):
(JSC::LLInt::getProgramEntrypoint):

  • llint/LLIntEntrypoints.h: Added.

(JSC):
(LLInt):
(JSC::LLInt::getEntrypoint):

  • llint/LLIntExceptions.cpp: Added.

(LLInt):
(JSC::LLInt::interpreterThrowInCaller):
(JSC::LLInt::returnToThrowForThrownException):
(JSC::LLInt::returnToThrow):
(JSC::LLInt::callToThrow):

  • llint/LLIntExceptions.h: Added.

(JSC):
(LLInt):

  • llint/LLIntOfflineAsmConfig.h: Added.
  • llint/LLIntOffsetsExtractor.cpp: Added.

(JSC):
(LLIntOffsetsExtractor):
(JSC::LLIntOffsetsExtractor::dummy):
(main):

  • llint/LLIntSlowPaths.cpp: Added.

(LLInt):
(JSC::LLInt::llint_trace_operand):
(JSC::LLInt::llint_trace_value):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::traceFunctionPrologue):
(JSC::LLInt::shouldJIT):
(JSC::LLInt::entryOSR):
(JSC::LLInt::resolveGlobal):
(JSC::LLInt::getByVal):
(JSC::LLInt::handleHostCall):
(JSC::LLInt::setUpCall):
(JSC::LLInt::genericCall):

  • llint/LLIntSlowPaths.h: Added.

(JSC):
(LLInt):

  • llint/LLIntThunks.cpp: Added.

(LLInt):
(JSC::LLInt::generateThunkWithJumpTo):
(JSC::LLInt::functionForCallEntryThunkGenerator):
(JSC::LLInt::functionForConstructEntryThunkGenerator):
(JSC::LLInt::functionForCallArityCheckThunkGenerator):
(JSC::LLInt::functionForConstructArityCheckThunkGenerator):
(JSC::LLInt::evalEntryThunkGenerator):
(JSC::LLInt::programEntryThunkGenerator):

  • llint/LLIntThunks.h: Added.

(JSC):
(LLInt):

  • llint/LowLevelInterpreter.asm: Added.
  • llint/LowLevelInterpreter.cpp: Added.
  • llint/LowLevelInterpreter.h: Added.
  • offlineasm: Added.
  • offlineasm/armv7.rb: Added.
  • offlineasm/asm.rb: Added.
  • offlineasm/ast.rb: Added.
  • offlineasm/backends.rb: Added.
  • offlineasm/generate_offset_extractor.rb: Added.
  • offlineasm/instructions.rb: Added.
  • offlineasm/offset_extractor_constants.rb: Added.
  • offlineasm/offsets.rb: Added.
  • offlineasm/opt.rb: Added.
  • offlineasm/parser.rb: Added.
  • offlineasm/registers.rb: Added.
  • offlineasm/self_hash.rb: Added.
  • offlineasm/settings.rb: Added.
  • offlineasm/transform.rb: Added.
  • offlineasm/x86.rb: Added.
  • runtime/CodeSpecializationKind.h: Added.

(JSC):

  • runtime/CommonSlowPaths.h:

(JSC::CommonSlowPaths::arityCheckFor):
(CommonSlowPaths):

  • runtime/Executable.cpp:

(JSC::jettisonCodeBlock):
(JSC):
(JSC::EvalExecutable::jitCompile):
(JSC::samplingDescription):
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::jitCompile):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::baselineCodeBlockFor):
(JSC::FunctionExecutable::jitCompileForCall):
(JSC::FunctionExecutable::jitCompileForConstruct):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

  • runtime/Executable.h:

(JSC):
(EvalExecutable):
(ProgramExecutable):
(FunctionExecutable):
(JSC::FunctionExecutable::jitCompileFor):

  • runtime/ExecutionHarness.h: Added.

(JSC):
(JSC::prepareForExecution):
(JSC::prepareFunctionForExecution):

  • runtime/JSArray.h:

(JSC):
(JSArray):

  • runtime/JSCell.h:

(JSC):
(JSCell):

  • runtime/JSFunction.h:

(JSC):
(JSFunction):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSC):
(JSGlobalData):

  • runtime/JSGlobalObject.h:

(JSC):
(JSGlobalObject):

  • runtime/JSObject.h:

(JSC):
(JSObject):
(JSFinalObject):

  • runtime/JSPropertyNameIterator.h:

(JSC):
(JSPropertyNameIterator):

  • runtime/JSString.h:

(JSC):
(JSString):

  • runtime/JSTypeInfo.h:

(JSC):
(TypeInfo):

  • runtime/JSValue.cpp:

(JSC::JSValue::description):

  • runtime/JSValue.h:

(LLInt):
(JSValue):

  • runtime/JSVariableObject.h:

(JSC):
(JSVariableObject):

  • runtime/Options.cpp:

(Options):
(JSC::Options::initializeOptions):

  • runtime/Options.h:

(Options):

  • runtime/ScopeChain.h:

(JSC):
(ScopeChainNode):

  • runtime/Structure.cpp:

(JSC::Structure::addPropertyTransition):

  • runtime/Structure.h:

(JSC):
(Structure):

  • runtime/StructureChain.h:

(JSC):
(StructureChain):

  • wtf/InlineASM.h:
  • wtf/Platform.h:
  • wtf/SentinelLinkedList.h:

(SentinelLinkedList):
(WTF::SentinelLinkedList::isEmpty):

  • wtf/text/StringImpl.h:

(JSC):
(StringImpl):

Source/WebCore:

Reviewed by Gavin Barraclough.

No new tests, because there is no change in behavior.

  • CMakeLists.txt:

Source/WebKit:

Reviewed by Gavin Barraclough.

Changed EFL's build system to include a new directory in JavaScriptCore.

  • CMakeLists.txt:

Tools:

Reviewed by Gavin Barraclough.

Changed EFL's build system to include a new directory in JavaScriptCore.

  • DumpRenderTree/efl/CMakeLists.txt:
22:38 Changeset [108308] by benjamin@webkit.org
  • 18 edits
    1 copy
    3 deletes in trunk/Source

Get rid of the LocalizationStrategy
https://bugs.webkit.org/show_bug.cgi?id=78324

Reviewed by Sam Weinig.

Source/WebCore:

Remove LocalizationStrategy and unify the localization behind
LocalizedStrings.h and LocalizedStrings.cpp.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/DefaultLocalizationStrategy.cpp: Removed.
  • platform/DefaultLocalizationStrategy.h: Removed.
  • platform/LocalizationStrategy.h: Removed.
  • platform/LocalizedStrings.cpp:
  • platform/LocalizedStrings.h:

(WebCore):

  • platform/PlatformStrategies.cpp:
  • platform/PlatformStrategies.h:

(WebCore):
(WebCore::PlatformStrategies::PlatformStrategies):
(PlatformStrategies):

  • platform/qt/LocalizedStringsQt.cpp: Copied from Source/WebKit/qt/WebCoreSupport/PlatformStrategiesQt.cpp.

Source/WebKit/qt:

Move the localization code from PlatformStrategiesQt.cpp
to LocalizedStringsQt.cpp.

Get rid of LocalizationStrategy from PlatformStrategiesQt

  • WebCoreSupport/PlatformStrategiesQt.cpp:
  • WebCoreSupport/PlatformStrategiesQt.h:

(PlatformStrategiesQt):

Source/WebKit/wince:

Remove a useless #include of LocalizationStrategy.h.

  • WebCoreSupport/PlatformStrategiesWinCE.h:
22:34 Changeset [108307] by fpizlo@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out http://trac.webkit.org/changeset/108291
It completely broke the 32-bit JIT.

  • heap/CopiedAllocator.h:
  • heap/CopiedSpace.h:

(CopiedSpace):

  • heap/Heap.h:

(JSC::Heap::allocatorForObjectWithDestructor):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:

(JIT):

  • jit/JITInlineMethods.h:

(JSC):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_new_array):

  • runtime/JSArray.cpp:

(JSC::storageSize):
(JSC):

  • runtime/JSArray.h:

(ArrayStorage):
(JSArray):

22:30 Changeset [108306] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r108259.

  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt: Updated.
22:23 Changeset [108305] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove [TreatReturnedNullStringAsNull] from HTMLMediaElement.mediaGroup
https://bugs.webkit.org/show_bug.cgi?id=79064

Reviewed by Hajime Morita.

[TreatReturnedNullStringAsNull] is a typo of [TreatReturnedNullStringAs=Null].
But as far as I read the spec
(http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#attr-media-mediagroup),
there is no statement about what value should be returned when HTMLMediaElement.mediaGroup
is not yet initialized. In particular, there is no statement that says "null should
be returned when HTMLMediaElement.mediaGroup is not initialized". Thus, instead of
fixing the typo, just removing [TreatReturnedNullStringAsNull] would make sense.
Removing [TreatReturnedNullStringAsNull] does not change the current behavior.

Test: media/media-controller.html (No change in the test results.)

  • html/HTMLMediaElement.idl:
22:17 Changeset [108304] by barraclough@apple.com
  • 7 edits in trunk

Put? should throw if prototype chain contains a readonly property.
https://bugs.webkit.org/show_bug.cgi?id=79069

Reviewed by Oliver Hunt.

Currently we only check the base of the put, not the prototype chain.
Fold this check in with the test for accessors.

Source/JavaScriptCore:

  • runtime/JSObject.cpp:

(JSC::JSObject::put):

  • Updated to test all objects in the propotype chain for readonly properties.

(JSC::JSObject::putDirectAccessor):
(JSC::putDescriptor):

  • Record the presence of readonly properties on the structure.
  • runtime/Structure.cpp:

(JSC::Structure::Structure):

  • hasGetterSetterPropertiesExcludingProto expanded to hasReadOnlyOrGetterSetterPropertiesExcludingProto.
  • runtime/Structure.h:

(JSC::Structure::hasReadOnlyOrGetterSetterPropertiesExcludingProto):
(JSC::Structure::setHasGetterSetterProperties):

  • hasGetterSetterPropertiesExcludingProto expanded to hasReadOnlyOrGetterSetterPropertiesExcludingProto.

(JSC::Structure::setContainsReadOnlyProperties):

  • Added.

LayoutTests:

  • fast/js/Object-defineProperty-expected.txt:
  • fast/js/script-tests/Object-defineProperty.js:

(get shouldBeTrue):

  • Added test case.
22:15 Changeset [108303] by hayato@chromium.org
  • 11 edits in trunk/Source/WebCore

Use InsertinonPoint instead of HTMLContentElement.
https://bugs.webkit.org/show_bug.cgi?id=78778

Reviewed by Hajime Morita.

Replace HTMLContentElement with InsertionPoint in NodeRenderingContext and HTMLContentSelection.
This is one of followup patches for r108207.

No new tests, no change in behavior.

  • dom/NodeRenderingContext.cpp:

(WebCore::nextRendererOf):
(WebCore::previousRendererOf):
(WebCore::firstRendererOf):
(WebCore::lastRendererOf):

  • dom/NodeRenderingContext.h:

(WebCore):
(NodeRenderingContext):
(WebCore::NodeRenderingContext::insertionPoint):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::insertionPointFor):

  • dom/ShadowRoot.h:

(WebCore):

  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::HTMLContentElement):
(WebCore::HTMLContentElement::attach):
(WebCore::HTMLContentElement::detach):

  • html/shadow/HTMLContentElement.h:

(HTMLContentElement):

  • html/shadow/HTMLContentSelector.cpp:

(WebCore::HTMLContentSelector::select):

  • html/shadow/HTMLContentSelector.h:

(WebCore):
(HTMLContentSelection):
(WebCore::HTMLContentSelection::insertionPoint):
(WebCore::HTMLContentSelection::HTMLContentSelection):
(WebCore::HTMLContentSelection::create):

  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::InsertionPoint):

  • html/shadow/InsertionPoint.h:

(WebCore::InsertionPoint::selections):
(WebCore::InsertionPoint::hasSelection):
(InsertionPoint):

22:00 Changeset [108302] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

MathML internals - code clean-up for RenderMathMLSubSup
https://bugs.webkit.org/show_bug.cgi?id=79063

Patch by David Barton <dbarton@mathscribe.com> on 2012-02-20
Reviewed by Eric Seidel.

In the next patch, I will shrink and revise the <msubsup> formatting code. To make this
easier to follow, I am first doing some simple code clean-up.

No new tests.

  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::layout):

  • rendering/mathml/RenderMathMLRow.h:

(WebCore::RenderMathMLRow::isRenderMathMLRow):

  • rendering/mathml/RenderMathMLSubSup.cpp:

(WebCore::RenderMathMLSubSup::stretchToHeight):
(WebCore::RenderMathMLSubSup::layout):

  • There is no need to iterate over baseWrapper's children since it should have only one child, the base of the <msubsup>.
21:52 Changeset [108301] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Replace [V8Custom=DOMWindowNOP] with [V8Custom]
https://bugs.webkit.org/show_bug.cgi?id=79062

Reviewed by Adam Barth.

[V8Custom=DOMWindowNOP] is not implemented by CodeGeneratorV8.pm.
This patch replaces it with [V8Custom].

No new tests. No change in behavior.

  • page/DOMWindow.idl:
21:28 Changeset [108300] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[JSGenerateIsReachable=ImplRoot] is not implemented, it should be [JSGenerateIsReachable]
https://bugs.webkit.org/show_bug.cgi?id=79061

Reviewed by Adam Barth.

CSSStyleDeclaration.idl uses [JSGenerateIsReachable=ImplRoot],
but "ImplRoot" is not implemented in CodeGeneratorJS.pm.
This patch replaces [JSGenerateIsReachable=ImplRoot] with [JSGenerateIsReachable].

No tests. No change in behavior.

  • css/CSSStyleDeclaration.idl:
21:25 Changeset [108299] by commit-queue@webkit.org
  • 3 edits
    9 adds in trunk/LayoutTests

There is no complete test cases of optional arguments for MediaStream API and PeerConnection
https://bugs.webkit.org/show_bug.cgi?id=78578

Reviewed by Adam Barth.

  • fast/mediastream/peerconnection-AttributesMethod-expected.txt: Added.
  • fast/mediastream/peerconnection-AttributesMethod.html: Added.
  • fast/mediastream/peerconnection-addstream-expected.txt:
  • fast/mediastream/peerconnection-argument-types-expected.txt: Added.
  • fast/mediastream/peerconnection-argument-types.html: Added.
  • fast/mediastream/peerconnection-removestream-expected.txt: Added.
  • fast/mediastream/peerconnection-removestream.html: Added.
  • fast/mediastream/script-tests/AttributesMethod.js: Added.
  • fast/mediastream/script-tests/argument-types.js: Added.
  • fast/mediastream/script-tests/peerconnection-addstream.js:
  • fast/mediastream/script-tests/peerconnection-removestream.js: Added.

Patch by Yanbin Zhang <yanbin.zhang@intel.com> on 2012-02-20

21:21 Changeset [108298] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[EnabledAtRuntime] in HTMLShadowElement.idl should be [V8EnabledAtRuntime]
https://bugs.webkit.org/show_bug.cgi?id=79058

Reviewed by Adam Barth.

[EnabledAtRuntime] does not exist any longer. It should be [V8EnabledAtRuntime].

No tests.

  • html/shadow/HTMLShadowElement.idl:
20:52 Changeset [108297] by haraken@chromium.org
  • 11 edits in trunk/Source/WebCore

Replace [Callback=FunctionOnly] with [Callback]
https://bugs.webkit.org/show_bug.cgi?id=79060

Reviewed by Adam Barth.

[Callback=FunctionOnly] is not implemented by any code generator.
This patch replaces it with [Callback].

No tests. No change in behavior.

  • Modules/intents/IntentResultCallback.idl:
  • Modules/intents/NavigatorIntents.idl:
  • dom/RequestAnimationFrameCallback.idl:
  • mediastream/NavigatorMediaStream.idl:
  • mediastream/NavigatorUserMediaErrorCallback.idl:
  • mediastream/NavigatorUserMediaSuccessCallback.idl:
  • mediastream/PeerConnection.idl:
  • mediastream/SignalingCallback.idl:
  • page/PositionCallback.idl:
  • page/PositionErrorCallback.idl:
20:17 Changeset [108296] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Need to override active/inactive text search highlight color for RenderThemeBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=78920

Override two functions for text search highlight colors so that we can
provide platform specified colors.

Patch by Andy Chen <andchen@rim.com> on 2012-02-17
Reviewed by Antonio Gomes.

No function change so no new tests.

  • platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::platformActiveTextSearchHighlightColor):
(WebCore::RenderThemeBlackBerry::platformInactiveTextSearchHighlightColor):

  • platform/blackberry/RenderThemeBlackBerry.h:
20:12 Changeset [108295] by yutak@chromium.org
  • 4 edits in trunk/LayoutTests

[Chromium] Unreviewed, update test expectations.

  • platform/chromium/fast/dom/Window/window-custom-prototype-expected.txt:
  • platform/chromium/fast/js/string-capitalization-expected.txt:
  • platform/chromium/test_expectations.txt:
20:06 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
20:05 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
20:05 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
19:59 Changeset [108294] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8

Merging r108288

19:48 Changeset [108293] by jknotten@chromium.org
  • 2 edits in trunk/Source/WebCore

Default canvas backing store to be 1:1 with specified dimensions.
https://bugs.webkit.org/show_bug.cgi?id=78971

Reviewed by Adam Barth.

Although the canvas specification states that the backing image may
be larger than the user-specified dimensions, there are a number of
philip canvas tests that fail when the backing image data is not
1:1 with the specified canvas dimensions. These failures are
tracked in https://bugs.webkit.org/show_bug.cgi?id=73645

This change defaults the canvas backing store to be 1:1 with the
user-specified dimensions, while also providing an
ENABLE(HIGH_DPI_CANVAS) build option to reinstate the original
behaviour, so that the above bug may be more easily fixed.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::HTMLCanvasElement):

19:24 Changeset [108292] by bashi@chromium.org
  • 2 edits in trunk/Tools

Update pywebsocket to 0.7.2
https://bugs.webkit.org/show_bug.cgi?id=79066

This version includes vendor-prefixed deflate-frame extension support.

Reviewed by Kent Tamura.

  • Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook._install_pywebsocket):

19:20 Changeset [108291] by mhahnenberg@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

Implement fast path for op_new_array in the baseline JIT
https://bugs.webkit.org/show_bug.cgi?id=78612

Reviewed by Filip Pizlo.

  • heap/CopiedAllocator.h:

(CopiedAllocator): Friended the JIT to allow access to m_currentOffset.

  • heap/CopiedSpace.h:

(CopiedSpace): Friended the JIT to allow access to
(JSC::CopiedSpace::allocator):

  • heap/Heap.h:

(JSC::Heap::storageAllocator): Added a getter for the CopiedAllocator class so the JIT
can use it for simple allocation i.e. when we can just bump the offset without having to
do anything else.

  • jit/JIT.cpp:

(JSC::JIT::privateCompileSlowCases): Added new slow case for op_new_array for when
we have to bail out because the fast allocation path fails for whatever reason.

  • jit/JIT.h:

(JIT):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicStorage): Added utility function that allows objects to
allocate generic backing stores. This function is used by emitAllocateJSArray.
(JSC):
(JSC::JIT::emitAllocateJSArray): Added utility function that allows the client to
more easily allocate JSArrays. This function is used by emit_op_new_array and I expect
it will also be used for emit_op_new_array_buffer.

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_new_array): Changed to do inline allocation of JSArrays. Still does
a stub call for oversize arrays.
(JSC):
(JSC::JIT::emitSlow_op_new_array): Just bails out to a stub call if we fail in any way on
the fast path.

  • runtime/JSArray.cpp:

(JSC):

  • runtime/JSArray.h: Added lots of offset functions for all the fields that we need to

initialize in the JIT.
(ArrayStorage):
(JSC::ArrayStorage::lengthOffset):
(JSC::ArrayStorage::numValuesInVectorOffset):
(JSC::ArrayStorage::allocBaseOffset):
(JSC::ArrayStorage::vectorOffset):
(JSArray):
(JSC::JSArray::sparseValueMapOffset):
(JSC::JSArray::subclassDataOffset):
(JSC::JSArray::indexBiasOffset):
(JSC):
(JSC::JSArray::storageSize): Moved this function from being a static function in the cpp file
to being a static function in the JSArray class. This move allows the JIT to call it to
see what size it should allocate.

19:19 Changeset [108290] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Source/WebCore

Upstream RenderThemeBlackberry.h/.cpp into WebCore/platform/blackberry
https://bugs.webkit.org/show_bug.cgi?id=78785

Main Contributors:
Daniel Bates <dbates@rim.com>
Bryan Gislason <bgislason@rim.com>
Akash Vaswani <akvaswani@rim.com>
Dave Battista <dbattista@rim.com>
Robin Cao <robin.cao@torchmobile.com.cn>
Genevieve Mak <gmak@rim.com>
Mike Fenton <mifenton@rim.com>

Patch by Mary Wu <mary.wu@torchmobile.com.cn> on 2012-02-20
Reviewed by Antonio Gomes.

Initial upstream, no new tests.

  • platform/blackberry/RenderThemeBlackBerry.cpp: Added.
  • platform/blackberry/RenderThemeBlackBerry.h: Added.
19:10 Changeset [108289] by commit-queue@webkit.org
  • 4 edits
    1 move
    3 deletes in trunk/Source/WebCore

[GTK] [EFL] Collapse duplicate WebGL support code
https://bugs.webkit.org/show_bug.cgi?id=78970

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-02-20
Reviewed by Gustavo Noronha Silva.

No new tests. This just cleans up duplicated code.

Centralize duplicated WebGL code for EFL and GTK+ in the Cairo
directory. This is in preparation for the changes necessary to
connect WebGL to the TextureMapper AC.

  • GNUmakefile.list.am: Update source list.
  • PlatformEfl.cmake: Update source list.
  • platform/graphics/cairo/DrawingBufferCairo.cpp: Renamed from Source/WebCore/platform/graphics/gtk/DrawingBufferGtk.cpp.
  • platform/graphics/cairo/GraphicsContext3DCairo.cpp: Integrated the code From GraphicsContext3DGtk.cpp.
  • platform/graphics/efl/DrawingBufferEfl.cpp: Removed.
  • platform/graphics/efl/GraphicsContext3DEfl.cpp: Removed.
  • platform/graphics/gtk/GraphicsContext3DGtk.cpp: Removed.
19:05 Changeset [108288] by commit-queue@webkit.org
  • 2 edits in trunk

[GTK] Turn on requestAnimationFrame for release builds
https://bugs.webkit.org/show_bug.cgi?id=79038

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-02-20
Reviewed by Gustavo Noronha Silva.

  • configure.ac: Turn on requestAnimationFrame by default.
18:53 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
18:51 Changeset [108287] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8

Merging r108277

18:48 Changeset [108286] by mrobinson@webkit.org
  • 5 edits in releases/WebKitGTK/webkit-1.8/Source

Merging r108278

18:45 Changeset [108285] by mrobinson@webkit.org
  • 12 edits in releases/WebKitGTK/webkit-1.8

Merging r108281

18:39 Changeset [108284] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore

Merging rr108248

18:37 Changeset [108283] by mrobinson@webkit.org
  • 4 edits
    4 deletes in releases/WebKitGTK/webkit-1.8

Merging r108237

18:35 Changeset [108282] by barraclough@apple.com
  • 6 edits in trunk

DefineOwnProperty fails with numeric properties & Object.prototype
https://bugs.webkit.org/show_bug.cgi?id=79059

Reviewed by Oliver Hunt.

ObjectPrototype caches whether it contains any numeric properties (m_hasNoPropertiesWithUInt32Names),
calls to defineOwnProperty need to update this cache.

Source/JavaScriptCore:

  • runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::put):
(JSC::ObjectPrototype::defineOwnProperty):
(JSC):
(JSC::ObjectPrototype::getOwnPropertySlotByIndex):

  • runtime/ObjectPrototype.h:

(ObjectPrototype):

LayoutTests:

  • fast/js/Object-defineProperty-expected.txt:
  • fast/js/script-tests/Object-defineProperty.js:

(shouldBe.shouldBe.shouldBe.shouldBe.shouldBe.shouldBe.shouldBe.shouldThrow.Object.defineProperty):

18:27 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
18:19 Changeset [108281] by commit-queue@webkit.org
  • 12 edits in trunk

[UNIX] Plugin information fields are not interpreted as UTF-8
https://bugs.webkit.org/show_bug.cgi?id=78635

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-02-20
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Interpret plugin metadata as UTF8 aways. This matches the behavior
of Chromium and the Totem plugin.

This is tested by a change to TestNetscapePlugin and expectations updates.

  • plugins/efl/PluginPackageEfl.cpp:

(WebCore::PluginPackage::fetchInfo): Use String::fromUTF8.

  • plugins/gtk/PluginPackageGtk.cpp:

(WebCore::PluginPackage::fetchInfo): Use String::fromUTF8.

  • plugins/qt/PluginPackageQt.cpp:

(WebCore::PluginPackage::fetchInfo): Use String::fromUTF8.

Source/WebKit2:

Interpret plugin metadata as UTF8 aways. This matches the behavior
of Chromium and the Totem plugin.

  • Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:

(WebKit::NetscapePluginModule::getPluginInfoForLoadedPlugin): Use String::fromUTF8.

Tools:

Interpret plugin metadata as UTF8 aways. This matches the behavior
of Chromium and the Totem plugin.

  • DumpRenderTree/TestNetscapePlugIn/main.cpp:

(NPP_GetValue): Include a UTF-8 character in the description string for testing purposes.

LayoutTests:

Update expectations to match the fact that TestNetscapePlugin is now
returning a Unicode character in the description field.

  • platform/chromium-linux/plugins/plugin-javascript-access-expected.txt:
  • platform/gtk/plugins/plugin-javascript-access-expected.txt:
  • platform/qt/plugins/plugin-javascript-access-expected.txt:
18:16 Changeset [108280] by commit-queue@webkit.org
  • 3 edits
    3 moves
    3 adds in trunk/Tools

[GTK] [Qt] Move the unix forwarding headers for TestNetscapePlugin to the TestNetscapePlugin directory
https://bugs.webkit.org/show_bug.cgi?id=78935

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-02-20
Reviewed by Gustavo Noronha Silva.

Move the TestNetscapePlugin headers to a more appropriate directory and update
the build files to match.

  • DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h.
  • DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h.
  • DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h.
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update build.
  • GNUmakefile.am: Ditto.
18:12 Changeset [108279] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Does not build on GNU Hurd
https://bugs.webkit.org/show_bug.cgi?id=79045

Patch by Pino Toscano <pino@debian.org> on 2012-02-20
Reviewed by Gustavo Noronha Silva.

  • wtf/Platform.h: define WTF_OS_HURD.
  • wtf/ThreadIdentifierDataPthreads.cpp: adds a band-aid fix

for the lack of PTHREAD_KEYS_MAX definition, with a value which
should not cause issues.

18:04 Changeset [108278] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[GTK] Web content oftens steals focus from other widgets
https://bugs.webkit.org/show_bug.cgi?id=77791

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-02-20
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

  • platform/gtk/WidgetGtk.cpp:

(WebCore::Widget::setFocus): No longer do anything special to try
to grab "real" widget focus. This matches the behavior on Qt.

  • plugins/gtk/PluginViewGtk.cpp:

(WebCore::PluginView::setFocus): Moved the focus handling to here.
This ensures that behavior for plugins does not change.

Source/WebKit/gtk:

  • tests/testwebview.c: Added a WebKit1 test to verify this behavior.
18:02 Changeset [108277] by commit-queue@webkit.org
  • 2 edits in trunk

[GTK] Geolocation support should be on by default
https://bugs.webkit.org/show_bug.cgi?id=79037

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-02-20
Reviewed by Gustavo Noronha Silva.

  • configure.ac: Turn on geolocation support in release builds.
17:33 Changeset [108276] by yael.aharon@nokia.com
  • 2 edits in trunk/Source/WebCore

Regression (108135) isOpaque() returns uninitialized variable.
https://bugs.webkit.org/show_bug.cgi?id=79049

Reviewed by Noam Rosenthal.

isOpaque() should use the new m_flags instead of the old m_isOpaque.
No new tests. No new functionality.

  • platform/graphics/texmap/TextureMapper.h:

(WebCore::BitmapTexture::reset):
(WebCore::BitmapTexture::isOpaque):
(BitmapTexture):

17:27 Changeset [108275] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

Unreviewed. Rebaselined run-bindings-tests results.

  • bindings/scripts/test/CPP/WebDOMTestInterface.cpp:
  • bindings/scripts/test/CPP/WebDOMTestInterface.h:
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
17:20 Changeset [108274] by noam.rosenthal@nokia.com
  • 3 edits in trunk/Source/WebCore

[Qt][WK2] Clipping is broken
https://bugs.webkit.org/show_bug.cgi?id=78677

It's not necessary to add a full-viewport rect to the scissor clip stack.
It creates a situation where if there's a clip in the page, we return to
the viewport clip instead of applying the WebView's clip we got from the
scenegraph.

Also, it's unnecessary to clip before we paint the layer's content, we should
only clip afterwards, before painting the children.

Reviewed by Kenneth Rohde Christiansen.

No new functionality.

  • platform/graphics/opengl/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::size):
(WebCore::scissorClip):
(WebCore):
(WebCore::TextureMapperGL::beginScissorClip):
(WebCore::TextureMapperGL::endScissorClip):

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::paintSelfAndChildren):

17:15 Changeset [108273] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebCore

[Texmap] Layers and tiles appear to have missing pixels in their right/bottom borders
https://bugs.webkit.org/show_bug.cgi?id=78961

The relativeSize member should point to one pixel before the edge, since it's used
by glVertexAttribPointer, which takes edge points and not sizes.

Reviewed by Kenneth Rohde Christiansen.

No new funcionality.

  • platform/graphics/opengl/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::didReset):

17:05 Changeset [108272] by commit-queue@webkit.org
  • 17 edits
    11 adds in trunk

.: Add a new API for the Vibration API(W3C).
https://bugs.webkit.org/show_bug.cgi?id=72010

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-02-20
Reviewed by Hajime Morita.

Add Implementation for the Vibration API to the WebKit-EFL port.
http://dev.w3.org/2009/dap/vibration/

  • Source/cmake/OptionsEfl.cmake: Add ENABLE_VIBRATION feature.
  • Source/cmakeconfig.h.cmake:

Source/WebCore: Add a new API for the Vibration API(W3C).
https://bugs.webkit.org/show_bug.cgi?id=72010

http://dev.w3.org/2009/dap/vibration/
This patch implements navigator.webkitvibrate() API.
This API operates differently depending upon a given parameter:

  1. It cancels vibration when given 0 or [].
  2. It gives a vibration duration in milliseconds when given as a single integer value.
  3. It gives a vibration pattern when given as an integer array. For instance, [1000 300 1000] generates a vibration of 1000ms followed by 300ms of idle time, and then creates another vibration of 1000ms.

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-02-20
Reviewed by Hajime Morita.

Test: fast/dom/navigator-vibration.html

  • CMakeLists.txt:
  • Modules/vibration/NavigatorVibration.cpp: Added.

(WebCore):
(WebCore::NavigatorVibration::NavigatorVibration):
(WebCore::NavigatorVibration::~NavigatorVibration):
(WebCore::NavigatorVibration::webkitVibrate):
Add webkitVibrate method to get an array or single integer parameter for vibrating.
They check vibration is activated in the platform, and then call vibrate() in the Vibration class.

  • Modules/vibration/NavigatorVibration.h: Added.

(WebCore):
(NavigatorVibration):

  • Modules/vibration/NavigatorVibration.idl: Added.
  • Modules/vibration/Vibration.cpp: Added.

This class implements the entire vibration logic.
(WebCore):
(WebCore::Vibration::Vibration):
(WebCore::Vibration::~Vibration):
(WebCore::Vibration::create):
(WebCore::Vibration::vibrate):
(WebCore::Vibration::cancelVibration):
(WebCore::Vibration::suspendVibration):
(WebCore::Vibration::resumeVibration):
(WebCore::Vibration::timerStartFired):
(WebCore::Vibration::timerStopFired):
(WebCore::Vibration::supplementName):
(WebCore::Vibration::isActive):
(WebCore::provideVibrationTo):

  • Modules/vibration/Vibration.h: Added.

(WebCore):
(Vibration):
(WebCore::Vibration::from):

  • Modules/vibration/VibrationClient.h: Added.

vibrate() and cancelVibrate() need to be implemented in the VibrationClient.
(WebCore):
(VibrationClient):
(WebCore::VibrationClient::~VibrationClient):

Source/WebKit/efl: Add a new API for the Vibration API(W3C).
https://bugs.webkit.org/show_bug.cgi?id=72010

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-02-20
Reviewed by Hajime Morita.

Implementation for the Vibration API feature to the EFL-port layer.
http://dev.w3.org/2009/dap/vibration/
There are two methods for vibration API.

  • vibrate : Vibrate device for receiving as a parameter.
  • cancelVibrate : Cancel current vibration.
  • CMakeListsEfl.txt:
  • WebCoreSupport/VibrationClientEfl.cpp: Added.

(WebCore):
(WebCore::VibrationClientEfl::VibrationClientEfl):
(WebCore::VibrationClientEfl::vibrate):
(WebCore::VibrationClientEfl::cancelVibration):
(WebCore::VibrationClientEfl::vibrationDestroyed):

  • WebCoreSupport/VibrationClientEfl.h: Added.

(WebCore):
(VibrationClientEfl):
(WebCore::VibrationClientEfl::~VibrationClientEfl):

  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):

Tools: Add a new API for the Vibration API(W3C).
https://bugs.webkit.org/show_bug.cgi?id=72010

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-02-20
Reviewed by Hajime Morita.

  • Scripts/build-webkit: Enable ENABLE_VIBRATION feature.

LayoutTests: Add a new test case for the Vibration API.
https://bugs.webkit.org/show_bug.cgi?id=72010

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-02-20
Reviewed by Hajime Morita.

  • fast/dom/navigator-vibration-expected.txt: Added.
  • fast/dom/navigator-vibration.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
16:57 Changeset [108271] by yutak@chromium.org
  • 6 edits in trunk/Source/WebCore

Unreviewed, rolling out r108263.
http://trac.webkit.org/changeset/108263
https://bugs.webkit.org/show_bug.cgi?id=77856

Broke Chromium Windows build.

  • platform/audio/DynamicsCompressor.cpp:

(WebCore::DynamicsCompressor::DynamicsCompressor):
(WebCore::DynamicsCompressor::setEmphasisStageParameters):
(WebCore::DynamicsCompressor::process):
(WebCore::DynamicsCompressor::reset):

  • platform/audio/DynamicsCompressor.h:

(WebCore::DynamicsCompressor::isStereo):
(DynamicsCompressor):

  • platform/audio/DynamicsCompressorKernel.cpp:

(WebCore::DynamicsCompressorKernel::DynamicsCompressorKernel):
(WebCore::DynamicsCompressorKernel::setPreDelayTime):
(WebCore::DynamicsCompressorKernel::process):
(WebCore::DynamicsCompressorKernel::reset):

  • platform/audio/DynamicsCompressorKernel.h:

(DynamicsCompressorKernel):

  • webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
(WebCore::DynamicsCompressorNode::initialize):

16:25 Changeset [108270] by rniwa@webkit.org
  • 6 edits in trunk

Move more logic from handler classes to model classes and add unit tests
https://bugs.webkit.org/show_bug.cgi?id=78989

Reviewed by Hajime Morita.

Extracted various functions from CreateHandler, ReportHanlder, and RunsHanlder to model classes
in order to unit-test them, added DataStoreTestsBase to reduce the code duplication in tests,
and added a whole bunch of unit tests in models_unittest.py.

  • Websites/webkit-perf.appspot.com/create_handler.py:

(CreateHandler._create_branch):
(CreateHandler._create_platform):

  • Websites/webkit-perf.appspot.com/models.py:

(_create_if_possible):
(_create_if_possible.execute):
(Branch):
(Branch.create_if_possible):
(Platform):
(Platform.create_if_possible):
(Build):
(Build.get_or_insert_from_log):
(Test):
(Test.update_or_insert):
(Test.update_or_insert.execute):
(TestResult):
(TestResult.get_or_insert_from_parsed_json):
(TestResult.get_or_insert_from_parsed_json._float_or_none):
(TestResult.generate_runs):

  • Websites/webkit-perf.appspot.com/models_unittest.py:

(DataStoreTestsBase):
(DataStoreTestsBase.assertThereIsNoInstanceOf):
(DataStoreTestsBase.assertOnlyInstance):
(DataStoreTestsBase.assertEqualUnorderedList):
(HelperTests):
(HelperTests.test_create_in_transaction_with_numeric_id_holder):
(HelperTests.test_failing_in_create_in_transaction_with_numeric_id_holder):
(HelperTests.test_raising_in_create_in_transaction_with_numeric_id_holder):
(HelperTests.test_delete_model_with_numeric_id_holder):
(BranchTests):
(BranchTests.test_create_if_possible):
(PlatformTests):
(PlatformTests.test_create_if_possible):
(BuilderTests):
(_create_some_builder):
(BuildTests):
(BuildTests.test_get_or_insert_from_log):
(TestModelTests):
(TestModelTests.test_update_or_insert):
(TestModelTests.test_update_or_insert_to_update):
(TestResultTests):
(TestResultTests._create_build):
(TestResultTests.test_get_or_insert_value):
(TestResultTests.test_get_or_insert_stat_value):
(TestResultTests._create_results):
(TestResultTests.test_generate_runs):
(ReportLogTests):
(ReportLogTests.test_branch):
(ReportLogTests.test_platform):
(PersistentCacheTests):
(PersistentCacheTests.setUp):
(PersistentCacheTests.test_set):

  • Websites/webkit-perf.appspot.com/report_process_handler.py:

(ReportProcessHandler.post):

  • Websites/webkit-perf.appspot.com/runs_handler.py:

(RunsHandler.get):
(RunsHandler.post):

16:18 Changeset [108269] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed windows build fix.

15:49 Changeset [108268] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Undoing accidental changes

  • heap/Heap.cpp:

(JSC::Heap::collectAllGarbage):

15:42 Changeset [108267] by mhahnenberg@apple.com
  • 11 edits
    1 add in trunk/Source/JavaScriptCore

Factor out allocation in CopySpace into a separate CopyAllocator
https://bugs.webkit.org/show_bug.cgi?id=78610

Reviewed by Oliver Hunt.

Added a new CopyAllocator class, which allows us to do allocations without
having to load the current offset and store the current offset in the current
block. This change will allow us to easily do inline assembly in the JIT for
array allocations.

(JSC):
(CopiedAllocator):
(JSC::CopiedAllocator::currentBlock):
(JSC::CopiedAllocator::CopiedAllocator):
(JSC::CopiedAllocator::allocate):
(JSC::CopiedAllocator::fitsInCurrentBlock):
(JSC::CopiedAllocator::wasLastAllocation):
(JSC::CopiedAllocator::startedCopying):
(JSC::CopiedAllocator::resetCurrentBlock):
(JSC::CopiedAllocator::currentUtilization):
(JSC::CopiedAllocator::resetLastAllocation):

  • heap/CopiedBlock.h:

(CopiedBlock):

  • heap/CopiedSpace.cpp: Moved some stuff from CopiedSpaceInlineMethods to here because we

weren't really getting any benefits from having such big functions in a header file.
(JSC::CopiedSpace::CopiedSpace):
(JSC):
(JSC::CopiedSpace::init):
(JSC::CopiedSpace::tryAllocateSlowCase):
(JSC::CopiedSpace::tryAllocateOversize):
(JSC::CopiedSpace::tryReallocate):
(JSC::CopiedSpace::tryReallocateOversize):
(JSC::CopiedSpace::doneFillingBlock):
(JSC::CopiedSpace::doneCopying):
(JSC::CopiedSpace::getFreshBlock):

  • heap/CopiedSpace.h:

(CopiedSpace):

  • heap/CopiedSpaceInlineMethods.h:

(JSC):
(JSC::CopiedSpace::startedCopying):
(JSC::CopiedSpace::addNewBlock):
(JSC::CopiedSpace::allocateNewBlock):
(JSC::CopiedSpace::fitsInBlock):
(JSC::CopiedSpace::tryAllocate):
(JSC::CopiedSpace::allocateFromBlock):

  • heap/Heap.cpp:

(JSC::Heap::collectAllGarbage):

  • heap/HeapBlock.h:

(HeapBlock):

15:39 WebKitGTK/1.8.x edited by kov@webkit.org
chrome version update merged (diff)
15:38 Changeset [108266] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk

Merging http://trac.webkit.org/changeset/108264

15:37 Changeset [108265] by paroga@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix Visual Studio 2010 build.

  • bytecompiler/NodesCodegen.cpp:

(JSC::PropertyListNode::emitBytecode):

15:22 Changeset [108264] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] Needs to claim being a more up-to-date Chrome
https://bugs.webkit.org/show_bug.cgi?id=79044

Reviewed by Martin Robinson.

  • webkit/webkitwebsettings.cpp:

(chromeUserAgent): update the version of Chrome we claim to be
to avoid warnings from sites such as Wordpress saying that our
browser is outdated.

15:16 WebKitGTK/1.8.x edited by kov@webkit.org
Adding to proposed merges [GTK] Needs to claim being a more up-to-date … (diff)
14:10 Changeset [108263] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Have the DynamicsCompressorNode support multi-channel data
https://bugs.webkit.org/show_bug.cgi?id=77856

Patch by Raymond Liu <raymond.liu@intel.com> on 2012-02-20
Reviewed by Chris Rogers.

  • platform/audio/DynamicsCompressor.cpp:

(WebCore::DynamicsCompressor::DynamicsCompressor):
(WebCore::DynamicsCompressor::setEmphasisStageParameters):
(WebCore::DynamicsCompressor::process):
(WebCore::DynamicsCompressor::reset):
(WebCore::DynamicsCompressor::setNumberOfChannels):
(WebCore):

  • platform/audio/DynamicsCompressor.h:

(DynamicsCompressor):

  • platform/audio/DynamicsCompressorKernel.cpp:

(WebCore::DynamicsCompressorKernel::DynamicsCompressorKernel):
(WebCore::DynamicsCompressorKernel::setNumberOfChannels):
(WebCore):
(WebCore::DynamicsCompressorKernel::setPreDelayTime):
(WebCore::DynamicsCompressorKernel::process):
(WebCore::DynamicsCompressorKernel::reset):

  • platform/audio/DynamicsCompressorKernel.h:

(DynamicsCompressorKernel):

  • webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
(WebCore::DynamicsCompressorNode::initialize):

14:02 Changeset [108262] by commit-queue@webkit.org
  • 11 edits in trunk

RenderMathMLRow::baselinePosition() only if linePositionMode == PositionOnContainingLine
https://bugs.webkit.org/show_bug.cgi?id=79039

Patch by David Barton <dbarton@mathscribe.com> on 2012-02-20
Reviewed by Eric Seidel.

Source/WebCore:

RenderMathMLRow::baselinePosition() is actually unnecessary, but I am deleting it in two
steps. First we add a guard to restrict it to the intended PositionOnContainingLine
case, leaving PositionOfInteriorLineBoxes to a superclass, RenderBlock. This removes
some randomness, and tightens up the results of four existing test files.

Test: mathml/presentation/row.xhtml, fenced.xhtml, mo.xhtml, and mo-stretch.html

  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::baselinePosition):

LayoutTests:

  • platform/mac/mathml/presentation/fenced-expected.png:
  • platform/mac/mathml/presentation/fenced-expected.txt:
  • platform/mac/mathml/presentation/mo-expected.png:
  • platform/mac/mathml/presentation/mo-expected.txt:
  • platform/mac/mathml/presentation/mo-stretch-expected.png: Added property svn:mime-type.
  • platform/mac/mathml/presentation/mo-stretch-expected.txt:
  • platform/mac/mathml/presentation/row-expected.png:
  • platform/mac/mathml/presentation/row-expected.txt:
13:55 Changeset [108261] by jonlee@apple.com
  • 11 edits in trunk/Source/WebCore

HTML input file control "No File Selected" needs more room in some languages
https://bugs.webkit.org/show_bug.cgi?id=32366
<rdar://problem/4481028>

Reviewed by David Hyatt.

The patch exposes a function to return the "no file(s) selected" label text.

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::fileListDefaultLabel): Added to expose the text for the label in
file upload controls when nothing has been selected.
(WebCore::RenderTheme::fileListNameForWidth): Refactor to use fileListDefaultLabel().

  • rendering/RenderTheme.h: Change fileListNameForWidth() to be a const function.
  • rendering/RenderThemeMac.h: Update fileListNameForWidth() to be a const function for

platform implementations.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::fileListNameForWidth): Refactor to use fileListDefaultLabel().

Update fileListNameForWidth() to be a const function for platform implementations.

  • platform/gtk/RenderThemeGtk.h:
  • platform/gtk/RenderThemeGtk.cpp:
  • platform/qt/RenderThemeQt.h:
  • platform/qt/RenderThemeQt.cpp:
  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::computePreferredLogicalWidths): Change the calculation
of the max preferred logical width. Calculate the length of the "no file(s) selected" text,
and include the button and after-button margin. Take the max of that and the original
default width, which was a string of 34 (defaultWidthNumChars) "0"'s, in the case that the
label text is too short.

13:52 Changeset [108260] by barraclough@apple.com
  • 2 edits in trunk/Source/WebCore

Rubber stamped by Sam Weinig.

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::allowsAccessFrom):

  • Errk, remove dead code from end of function.
13:14 Changeset [108259] by barraclough@apple.com
  • 33 edits in trunk

Move special proto property to Object.prototype
https://bugs.webkit.org/show_bug.cgi?id=78409

Reviewed by Oliver Hunt.

Re-implement this as a regular accessor property. This has three key benefits:
1) It makes it possible for objects to be given properties named proto.
2) Object.prototype.proto can be deleted, preventing object prototypes from being changed.
3) This largely removes the magic used the implement proto, it can just be made a regular accessor property.

Source/JavaScriptCore:

  • parser/Parser.cpp:

(JSC::::parseFunctionInfo):

  • No need to prohibit functions named proto.
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

  • Add proto accessor to Object.prototype.
  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncProtoGetter):
(JSC::globalFuncProtoSetter):

  • Definition of the proto accessor functions.
  • runtime/JSGlobalObjectFunctions.h:
    • Declaration of the proto accessor functions.
  • runtime/JSObject.cpp:

(JSC::JSObject::put):

  • Remove the special handling for proto, there is still a check to allow for a fast guard for accessors excluding proto.

(JSC::JSObject::putDirectAccessor):

  • Track on the structure whether an object contains accessors other than one for proto.

(JSC::JSObject::defineOwnProperty):

  • No need to prohibit definition of own properties named proto.
  • runtime/JSObject.h:

(JSC::JSObject::inlineGetOwnPropertySlot):

  • Remove the special handling for proto.

(JSC::JSValue::get):

  • Remove the special handling for proto.
  • runtime/JSString.cpp:

(JSC::JSString::getOwnPropertySlot):

  • Remove the special handling for proto.
  • runtime/JSValue.h:

(JSValue):

  • Made synthesizePrototype public (this may be needed by the proto getter).
  • runtime/ObjectConstructor.cpp:

(JSC::objectConstructorGetPrototypeOf):

  • Perform the security check & call prototype() directly.
  • runtime/Structure.cpp:

(JSC::Structure::Structure):

  • Added 'ExcludingProto' variant of the 'hasGetterSetterProperties' state.
  • runtime/Structure.h:

(JSC::Structure::hasGetterSetterPropertiesExcludingProto):
(JSC::Structure::setHasGetterSetterProperties):
(Structure):

  • Added 'ExcludingProto' variant of the 'hasGetterSetterProperties' state.

Source/WebCore:

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::allowsAccessFrom):
(WebCore):

  • expose allowsAccessFrom check to JSC.
  • bindings/js/JSDOMWindowBase.h:

(JSDOMWindowBase):

  • expose allowsAccessFrom check to JSC.

LayoutTests:

  • fast/js/Object-getOwnPropertyNames-expected.txt:
  • fast/js/cyclic-prototypes-expected.txt:
  • fast/js/parser-syntax-check-expected.txt:
  • fast/js/preventExtensions-expected.txt:
  • fast/js/prototypes-expected.txt:
    • Update results
  • fast/js/script-tests/Object-getOwnPropertyNames.js:
    • proto is now a property of Object Prototype.
  • fast/js/script-tests/cyclic-prototypes.js:
    • setting an object's prototype to null removes proto setter, future usage won't set prototype.
  • fast/js/script-tests/parser-syntax-check.js:
    • Allow functions named proto
  • fast/js/script-tests/preventExtensions.js:
    • Setting proto should not throw.
  • fast/js/script-tests/prototypes.js:
    • Objects may contained own properties named proto, add new test cases.
13:11 Changeset [108258] by paroga@webkit.org
  • 2 edits in trunk

[CMake] Fix PLATFORM() define for Windows.

Define WTF_PLATFORM_WIN instead of WTF_PLATFORM_WINDOWS.

  • Source/cmake/OptionsWindows.cmake:
12:43 Changeset [108257] by benjamin@webkit.org
  • 5 edits
    2 adds in trunk

Make JSCSSStyleDeclaration work directly with CSS Property ID
https://bugs.webkit.org/show_bug.cgi?id=79014

Reviewed by Geoffrey Garen.

Source/WebCore:

Previously, accessing the CSS property was done by converting from
the JavaScript name to the CSS name, then converting that name to a lowercase
character array, and finally getting the CSS property ID.

This patch cut the indirection and make the code go directly from the
JavaScript name conversion to the CSS property ID.

This improves the performance mainly due to the following:
-avoid dynamic memory allocation
-cut the conversion early when possible
-do not parse the string twice
The previous fast-path optimization was removed because it is no longer
necessary with this change.

The improvement are the following:
-previous fast-path: no change
-previous slow-path: ~3 times faster

Test: fast/dom/CSSStyleDeclaration/access-longest-css-property.html
This just test the edge case of CSSPropertyName.

  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::writeWebKitPrefix):
(WebCore::writeEpubPrefix):
(WebCore::cssPropertyIDForJSCSSPropertyName):
(WebCore::isCSSPropertyName):
(WebCore::JSCSSStyleDeclaration::nameGetter):
(WebCore::JSCSSStyleDeclaration::putDelegate):

  • css/CSSParser.cpp:

(WebCore::cssPropertyID):
(WebCore):
(WebCore::cssPropertyNameIOSAliasing):

  • css/CSSParser.h:

(WebCore):

LayoutTests:

  • fast/dom/CSSStyleDeclaration/access-longest-css-property-expected.txt: Added.
  • fast/dom/CSSStyleDeclaration/access-longest-css-property.html: Added.
11:26 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
11:15 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
11:03 Changeset [108256] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Updated Localizable.strings after r107440.

Rubber-stamped by Joseph Pecoraro.

  • English.lproj/Localizable.strings:
11:00 Changeset [108255] by ossy@webkit.org
  • 8 edits in trunk/LayoutTests

Unreviewed gardening after r108226.
Skip tests because ENABLE(SHADOW_DOM) is disabled on these platforms.

  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
11:00 Changeset [108254] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit2

Merging r108250

10:59 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
10:58 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
10:49 Changeset [108253] by japhet@chromium.org
  • 2 edits in branches/chromium/963/Source/WebCore/rendering/style

Merge 108100 - 2012-02-17 Nate Chapin <japhet@chromium.org>

[Chromium mac] Cursors and background images disappear.
https://bugs.webkit.org/show_bug.cgi?id=78834

The issue occurs because a CachedImage sees that it has no clients
and decide it is safe to purge its m_data buffer. However,
StyleCachedImage is holding a CachedResourceHandle to the
CachedImage, and it can still add a client later. If it does so,
the CachedImage says everything is loaded but has no data.

Reviewed by Adam Barth.

No new tests, since the known repros have resisted reduction.
Tested manually with chrome.angrybirds.com, redfin.com and a
couple of other sites.

  • rendering/style/StyleCachedImage.cpp:
  • rendering/style/StyleCachedImage.h: Ensure the underlying

CachedImage has a client for the lifetime of the
StyleCachedImage and doesn't purge its buffer. Call
addClient(this) in the constructor and removeClient(this) in
the destructor, then ignore all cache callbacks.

TBR=japhet@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9424038

10:49 Changeset [108252] by msaboff@apple.com
  • 5 edits in trunk

Update toLower and toUpper tests for Unicode 6.1 changes
https://bugs.webkit.org/show_bug.cgi?id=78923

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • tests/mozilla/ecma/String/15.5.4.11-2.js: Updated the test

to handle a third set of results for updated Unicode 6.1
changes.
(getTestCases):
(TestCaseMultiExpected):
(writeTestCaseResultMultiExpected):
(getTestCaseResultMultiExpected):
(test):
(GetUnicodeValues):
(DecimalToHexString):

LayoutTests:

  • fast/js/script-tests/string-capitalization.js: Updated the test

to handle a new set of characters that have different results depending
on what version of Unicode the platform supports. The tests work
for Unicode 5.0 through 6.1.
(createExpected):

  • fast/js/string-capitalization-expected.txt:
10:46 Changeset [108251] by japhet@chromium.org
  • 2 edits in branches/chromium/1025/Source/WebCore/rendering/style

Merge 108100 - 2012-02-17 Nate Chapin <japhet@chromium.org>

[Chromium mac] Cursors and background images disappear.
https://bugs.webkit.org/show_bug.cgi?id=78834

The issue occurs because a CachedImage sees that it has no clients
and decide it is safe to purge its m_data buffer. However,
StyleCachedImage is holding a CachedResourceHandle to the
CachedImage, and it can still add a client later. If it does so,
the CachedImage says everything is loaded but has no data.

Reviewed by Adam Barth.

No new tests, since the known repros have resisted reduction.
Tested manually with chrome.angrybirds.com, redfin.com and a
couple of other sites.

  • rendering/style/StyleCachedImage.cpp:
  • rendering/style/StyleCachedImage.h: Ensure the underlying

CachedImage has a client for the lifetime of the
StyleCachedImage and doesn't purge its buffer. Call
addClient(this) in the constructor and removeClient(this) in
the destructor, then ignore all cache callbacks.

TBR=japhet@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9424037

10:46 Changeset [108250] by carlosgc@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Adding SOUP_TYPE_PROXY_RESOLVER_DEFAULT feature to soup session makes WebProcess to hang
https://bugs.webkit.org/show_bug.cgi?id=79036

Reviewed by Martin Robinson.

This looks like a bug in gobject. Initializing the WebProcess
before creating the soup session seems to fix the problem. It's
actually a workaround, but initializing the WebProcess as sson as
possible it's a good idea in any case.

  • WebProcess/gtk/WebProcessMainGtk.cpp:

(WebKit::WebProcessMainGtk):

10:43 WebKitGTK/WebKit2Roadmap edited by mrobinson@webkit.org
(diff)
10:35 Changeset [108249] by commit-queue@webkit.org
  • 10 edits
    3 adds in trunk

MathML internals - remove nonOperatorHeight(), hasBase()
https://bugs.webkit.org/show_bug.cgi?id=78977

Source/WebCore:

Patch by David Barton <dbarton@mathscribe.com> on 2012-02-20
Reviewed by Eric Seidel.

Stretchy operators, including embellished ones, should stretch to the largest height of
the non-stretchy items in the same explicit or implicit <mrow>.
RenderMathMLRow::layout() used to use hasBase(), isRenderMathMLOperator(), and
nonOperatorHeight() to approximate this height. We now use unembellishedOperator() to
improve this approximation, while also simplifying the code. More plainly, the code used
to skip all operators when estimating this height, instead of just the stretchy ones. We
continue to do that for now, but we more accurately skip all embellished operators
(using our currently implemented approximate definition of this), and use the simple and
true height of the remaining items. In case all items in the row are stretchy,
style()->fontSize() is better than using whatever heights these items currently happen
to be stretched to.

Test: mathml/presentation/mo-stretch.html, and many existing tests

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore):

  • rendering/mathml/RenderMathMLBlock.h:

(WebCore::RenderMathMLBlock::unembellishedOperator):

  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore):
(WebCore::RenderMathMLRow::layout):

  • rendering/mathml/RenderMathMLRow.h:

(WebCore::RenderMathMLRow::isRenderMathMLRow):

  • rendering/mathml/RenderMathMLSubSup.cpp:

(WebCore):

  • rendering/mathml/RenderMathMLSubSup.h:

(RenderMathMLSubSup):

  • rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore):

  • rendering/mathml/RenderMathMLUnderOver.h:

(RenderMathMLUnderOver):

LayoutTests:

Patch by David Barton <dbarton@mathscribe.com> on 2012-02-20
Reviewed by Eric Seidel.

More tests with multiple embellished stretchy and non-stretchy operators will be added
later, when code is added to more precisely handle such cases.

  • mathml/presentation/mo-stretch.html: Added.
  • platform/mac/mathml/presentation/mo-stretch-expected.png: Added.
  • platform/mac/mathml/presentation/mo-stretch-expected.txt: Added.
09:57 WebKitGTK/WebKit2Roadmap edited by mrobinson@webkit.org
(diff)
09:34 WebKitGTK/1.8.x edited by kov@webkit.org
(diff)
09:24 Changeset [108248] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Stop the committer timer when the page is destroyed
https://bugs.webkit.org/show_bug.cgi?id=78907

Reviewed by Adam Roben.

We don't want the committer timer to fire after the scrolling tree has been invalidated,
so stop the committer timer to prevent it from firing and trying to access the scrolling tree.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::pageDestroyed):

09:11 Changeset [108247] by paroga@webkit.org
  • 3 edits in trunk/Source/WebCore

[WIN] Allow compiling FileSystem without CoreFoundation.
https://bugs.webkit.org/show_bug.cgi?id=79032

Reviewed by Adam Roben.

Add #if USE(CF) around code using the CoreFoundation functions.

  • platform/FileSystem.h:
  • platform/win/FileSystemWin.cpp:
08:57 Changeset [108246] by ossy@webkit.org
  • 3 edits in trunk/Tools

[Qt] run-qtwebkit-tests doesn't consider timeouts as failures
https://bugs.webkit.org/show_bug.cgi?id=71816

RunQtAPITests will notify if a timeout occurs during testing.
Added unittest to the master.cfg

Patch by János Badics <dicska@gmail.com> on 2012-02-20
Reviewed by Csaba Osztrogonác.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunQtAPITests.evaluateCommand):

  • BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:

(RunQtAPITestsTest):
(RunQtAPITestsTest.assertResults):
(RunQtAPITestsTest.test_timeout):
(test_success):
(test_failure):
(test_timeout_and_failure):

08:50 Changeset [108245] by commit-queue@webkit.org
  • 1 edit
    7 adds in trunk/Source/WebCore

[BlackBerry] Upstream the first few files in platform/graphics/blackberry
https://bugs.webkit.org/show_bug.cgi?id=79023

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-02-20
Reviewed by Antonio Gomes.

Initial upstreaming, no new tests.

  • platform/graphics/blackberry/FloatPointBlackBerry.cpp: Added.

(WebCore):
(WebCore::FloatPoint::FloatPoint):
(WebCore::FloatPoint::operator BlackBerry::Platform::FloatPoint):

  • platform/graphics/blackberry/FloatRectBlackBerry.cpp: Added.

(WebCore):
(WebCore::FloatRect::FloatRect):
(WebCore::FloatRect::operator BlackBerry::Platform::FloatRect):

  • platform/graphics/blackberry/FloatSizeBlackBerry.cpp: Added.

(WebCore):
(WebCore::FloatSize::FloatSize):
(WebCore::FloatSize::operator BlackBerry::Platform::FloatSize):

  • platform/graphics/blackberry/IntPointBlackBerry.cpp: Added.

(WebCore):
(WebCore::IntPoint::IntPoint):
(WebCore::IntPoint::operator BlackBerry::Platform::IntPoint):

  • platform/graphics/blackberry/IntRectBlackBerry.cpp: Added.

(WebCore):
(WebCore::IntRect::IntRect):
(WebCore::IntRect::operator BlackBerry::Platform::IntRect):

  • platform/graphics/blackberry/IntSizeBlackBerry.cpp: Added.

(WebCore):
(WebCore::IntSize::IntSize):
(WebCore::IntSize::operator BlackBerry::Platform::IntSize):

08:43 Changeset [108244] by tonikitoo@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

2012-02-19 Antonio Gomes <agomes@rim.com>

All default video/audio control elements should be rect-hit testable (Part II)
PR #139518 / MKS_3005538

Reviewed by George Staikos.

Add HTMLInputElement::isMediaControlElement as a criteria
to consider a element as clickable.

Note that is should be only used while in the "ClickableByDefault"
phase of FatFingers.

  • WebKitSupport/FatFingers.cpp: (BlackBerry::WebKit::FatFingers::isElementClickable):
08:40 Changeset [108243] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

[WIN] Share openTemporaryFile with WinCE
https://bugs.webkit.org/show_bug.cgi?id=58750

Reviewed by Adam Roben.

Use pathByAppendingComponent instead of PathCombine to share the
code with WinCE. Also use the wide version of Windows functions.

  • platform/win/FileSystemWin.cpp:

(WebCore::openTemporaryFile):

07:23 Changeset [108242] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
07:19 WebKitIDL edited by haraken@chromium.org
(diff)
07:11 WebKitGTK/1.8.x edited by kov@webkit.org
(diff)
07:02 Changeset [108241] by commit-queue@webkit.org
  • 16 edits
    6 adds in trunk

Source/WebCore: Added code to support dispatching of missed cues in case of normal playback
and event sorting in case of simultaneous event triggering.

<track>-related events cuechange, enter, and exit should be sorted and filtered before dispatching
https://bugs.webkit.org/show_bug.cgi?id=72171

Patch by Victor Carbune <victor@rosedu.org> on 2012-02-20
Reviewed by Eric Carlson.

Tests: media/track/track-cues-missed.html

media/track/track-cues-sorted-before-dispatch.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Added initialization code
for newly added state variables.
(WebCore::trackIndexCompare): Static boolean compare function between
the index of two tracks.
(WebCore):
(WebCore::eventTimeCueCompare): Static boolean compare function between
events associated with text track cues.
(WebCore::HTMLMediaElement::updateActiveTextTrackCues): Added code to
sort the events associated with text track cues before dispatching.
Each step from the specification is commented within the code.
(WebCore::HTMLMediaElement::finishSeek): Added a boolean variable that
is needed within the text track update function, to know whether a seek
event has occured before or not.
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Moved the update
call for text tracks at the beginning of the function instead of the end.
'ended' events for video should be dispatched after track specific events.

  • html/HTMLMediaElement.h: Added variables to keep

state information required by the text track update algorithm (last time
the algorithm was run, and whether a seeking event has occured)
(HTMLMediaElement):

  • html/LoadableTextTrack.cpp: Refactored fireCueChangeEvent method

(WebCore::LoadableTextTrack::fireCueChangeEvent): The method dispatches a
synchronous cue change event for the track element.

  • html/LoadableTextTrack.h:

(LoadableTextTrack):

  • html/TextTrack.cpp: Modified the fireCueChange method, cached track index.

(WebCore::TextTrack::TextTrack):
(WebCore::TextTrack::trackIndex): Cached the track index.
(WebCore):
(WebCore::TextTrack::invalidateTrackIndex): Invalidates the track. Used
when a new track is added in a TextTrackList instance.

  • html/TextTrack.h:

(TextTrack):
(WebCore::TextTrack::fireCueChangeEvent): The fireCueChangeEvent has been changed,
as events need to be fired asyncronously.

  • html/TextTrackCue.cpp: Added internal variables to keep the current index

position in the track cue order. This is invalidated when an element is
inserted before.
(WebCore::TextTrackCue::TextTrackCue):
(WebCore::TextTrackCue::cueIndex): Getter for the cueIndex.
(WebCore):
(WebCore::TextTrackCue::invalidateCueIndex): Invalidates the currently stored
cue index.
(WebCore::TextTrackCue::dispatchEvent): Event dispatching is done asynchronously
now. This should be the only method used for event dispatching.
(WebCore::TextTrackCue::setIsActive): The setIsActive method no longer dispatches
events, but rather just changes the m_isActive variable.

  • html/TextTrackCue.h:

(TextTrackCue):

  • html/TextTrackCueList.cpp:

(WebCore::TextTrackCueList::getCueIndex): Retrieves the cue index, in the track cue
order, of a given cue.
(WebCore):
(WebCore::TextTrackCueList::add): Modified the add method such that all the next cue
indexes are invalidated.
(WebCore::TextTrackCueList::invalidateCueIndexes): Invalidates all cue indexes starting
with a specific position.

  • html/TextTrackCueList.h:

(TextTrackCueList):

  • html/track/TextTrackList.cpp:

(TextTrackList::getTrackIndex): Retrieves the track index position.
(TextTrackList::append): Added method for invalidating the text track index in case of
changing the list contents.

  • html/track/TextTrackList.h:

(TextTrackList):

LayoutTests: <track>-related events cuechange, enter, and exit should be sorted and filtered before dispatching
https://bugs.webkit.org/show_bug.cgi?id=72171

Patch by Victor Carbune <victor@rosedu.org> on 2012-02-20
Reviewed by Eric Carlson.

  • media/track/captions-webvtt/missed-cues.vtt: Added.
  • media/track/captions-webvtt/sorted-dispatch.vtt: Added.
  • media/track/track-cues-cuechange-expected.txt: This test had to be changed because

the synchronous dispatch of the events against the HTMLTrackElement doesn't mean that
the text track actually has any active cues at the dispatch moment.

  • media/track/track-cues-cuechange.html: Changed tests structure to guide the entering and

exit events according to the asynchronous dispatch done by TextTrack.

  • media/track/track-cues-missed-expected.txt: Added.
  • media/track/track-cues-missed.html: Added.
  • media/track/track-cues-sorted-before-dispatch-expected.txt: Added.
  • media/track/track-cues-sorted-before-dispatch.html: Added.
06:54 Changeset [108240] by bashi@chromium.org
  • 8 edits
    1 add in trunk/Source/WebCore

[WebSocket] Move WebSocketChannel::FrameData into a separate header file
https://bugs.webkit.org/show_bug.cgi?id=78682

Extract WebSocketChannel::FrameData as WebSocketFrame. This brings
flexibility to add classes which want to do something for
incoming/outgoing frames (e.g. compression/decompression).

Reviewed by Kent Tamura.

No new tests. No behavior change.

  • GNUmakefile.list.am: AddedWebSocketFrame.h
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • websockets/WebSocketChannel.cpp: Modified to use WebSocketFrame instead of FrameData

(WebCore):
(WebCore::WebSocketChannel::send):
(WebCore::WebSocketChannel::startClosingHandshake):
(WebCore::WebSocketChannel::parseFrame):
(WebCore::WebSocketChannel::processFrame):
(WebCore::WebSocketChannel::enqueueTextFrame):
(WebCore::WebSocketChannel::enqueueRawFrame):
(WebCore::WebSocketChannel::enqueueBlobFrame):
(WebCore::appendMaskedFramePayload): Added.
(WebCore::makeFrameData): Added.
(WebCore::WebSocketChannel::sendFrame):

  • websockets/WebSocketChannel.h: Removed FrameData.

(WebSocketChannel):
(QueuedFrame):

  • websockets/WebSocketFrame.h: Added.

(WebCore):
(WebSocketFrame):
(WebCore::WebSocketFrame::isNonControlOpCode):
(WebCore::WebSocketFrame::isControlOpCode):
(WebCore::WebSocketFrame::isReservedOpCode):
(WebCore::WebSocketFrame::WebSocketFrame):

06:53 Changeset [108239] by aroben@apple.com
  • 2 edits in trunk/Source/WebCore

32-bit build fix

  • platform/FractionalLayoutUnit.h:

(WebCore::FractionalLayoutUnit::setRawValue): Explicitly cast long long to int, since they
are different widths in 32-bit.

06:51 Changeset [108238] by aroben@apple.com
  • 2 edits in trunk/Source/WebCore

Clang build fix

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::willModifyDOMAttr): Removed unused parameter.

06:13 WebKitIDL edited by haraken@chromium.org
(diff)
06:03 Changeset [108237] by vsevik@chromium.org
  • 4 edits
    4 deletes in trunk

Unreviewed manual rollout of r107970 which breaks table column widths
updates from javascript (e.g. inspector's network panel).

Source/WebCore:

  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::calcWidthArray):

  • rendering/RenderTableCol.h:

(RenderTableCol):

LayoutTests:

  • css2.1/20110323/fixed-table-layout-013-expected.html: Removed.
  • css2.1/20110323/fixed-table-layout-013.htm: Removed.
  • css2.1/20110323/fixed-table-layout-015-expected.html: Removed.
  • css2.1/20110323/fixed-table-layout-015.htm: Removed.
06:02 WebKitIDL edited by haraken@chromium.org
(diff)
05:42 Changeset [108236] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Styles] Inconsistent alignment of non-parsed properties (having an exclamation mark)
https://bugs.webkit.org/show_bug.cgi?id=79028

Reviewed by Yury Semikhatsky.

  • inspector/front-end/elementsPanel.css:

(.styles-section .properties li.not-parsed-ok img.exclamation-mark):

05:11 Changeset [108235] by apavlov@chromium.org
  • 9 edits in trunk

Web Inspector: DOMAttrModified should not be fired if the attribute value remains the same
https://bugs.webkit.org/show_bug.cgi?id=79025

Reviewed by Pavel Feldman.

Source/WebCore:

  • dom/Element.cpp:

(WebCore::Element::willModifyAttribute):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::willModifyDOMAttr):
(WebCore):
(WebCore::InspectorDOMAgent::didModifyDOMAttr):

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willModifyDOMAttr):

LayoutTests:

  • inspector/elements/set-attribute-expected.txt:
  • inspector/elements/set-attribute.html:
05:10 WebKitIDL edited by haraken@chromium.org
(diff)
05:00 Changeset [108234] by wingo@igalia.com
  • 1 edit in trunk/Source/JavaScriptCore/ChangeLog

Fix ChangeLog from last commit.

  • ChangeLog: Quick fix to date and email address.
04:49 Changeset [108233] by wingo@igalia.com
  • 3 edits in trunk/Source/JavaScriptCore

2012-02-120 Andy Wingo <wingo@pobox.com>

Remove unused features from CodeFeatures
https://bugs.webkit.org/show_bug.cgi?id=78804

Reviewed by Gavin Barraclough.

  • parser/Nodes.h:
  • parser/ASTBuilder.h:

(JSC::ClosureFeature):
(JSC::ASTBuilder::createFunctionBody):
(JSC::ASTBuilder::usesClosures):
Remove "ClosureFeature". Since we track captured variables more
precisely, this bit doesn't do us any good.

(JSC::AssignFeature):
(JSC::ASTBuilder::makeAssignNode):
(JSC::ASTBuilder::makePrefixNode):
(JSC::ASTBuilder::makePostfixNode):
(JSC::ASTBuilder::usesAssignment):
Similarly, remove AssignFeature. It is unused.

04:49 EFLWebKit edited by dominik.rottsches@intel.com
libsoup version. (diff)
04:26 WebKit Team edited by wingo@igalia.com
fix markup (diff)
04:26 WebKit Team edited by wingo@igalia.com
add myself as a committer (diff)
04:25 Changeset [108232] by commit-queue@webkit.org
  • 22 edits in trunk/Source/WebKit2

[Qt][WK2] Implement proxy authentication handling.
https://bugs.webkit.org/show_bug.cgi?id=78792

Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-02-20
Reviewed by Simon Hausmann.

This patch implements the proxy authentication handling
for the Qt port in a similar matter to the http authentication
implementation.

Since there is a need to pass the proxy port, which is of type uint16_t,
from the WebProcess to the UIProcess, an encoder and a decoder for
this type was added because it did not exist.

The message that was added to the WebPageProxy is called synchronously
as this is needed by the implementation of the network access manager
and has also been implemented this way already for the http
authentication.

  • Platform/CoreIPC/ArgumentDecoder.cpp:

(CoreIPC::ArgumentDecoder::decodeUInt16):
(CoreIPC):

  • Platform/CoreIPC/ArgumentDecoder.h:

(ArgumentDecoder):
(CoreIPC::ArgumentDecoder::decode):
(CoreIPC):

  • Platform/CoreIPC/ArgumentEncoder.cpp:

(CoreIPC::ArgumentEncoder::encodeUInt16):
(CoreIPC):

  • Platform/CoreIPC/ArgumentEncoder.h:

(ArgumentEncoder):
(CoreIPC::ArgumentEncoder::encode):
(CoreIPC):

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::handleProxyAuthenticationRequiredRequest):
(QQuickWebViewExperimental::proxyAuthenticationDialog):
(QQuickWebViewExperimental::setProxyAuthenticationDialog):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

  • UIProcess/PageClient.h:

(PageClient):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::proxyAuthenticationRequiredRequest):
(WebKit):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/qt/QtDialogRunner.cpp:

(ProxyAuthenticationDialogContextObject):
(ProxyAuthenticationDialogContextObject::ProxyAuthenticationDialogContextObject):
(ProxyAuthenticationDialogContextObject::hostname):
(ProxyAuthenticationDialogContextObject::port):
(ProxyAuthenticationDialogContextObject::prefilledUsername):
(ProxyAuthenticationDialogContextObject::accept):
(ProxyAuthenticationDialogContextObject::reject):
(QtDialogRunner::initForProxyAuthentication):

  • UIProcess/qt/QtDialogRunner.h:

(QtDialogRunner):

  • UIProcess/qt/QtPageClient.cpp:

(QtPageClient::handleProxyAuthenticationRequiredRequest):

  • UIProcess/qt/QtPageClient.h:

(QtPageClient):

  • WebProcess/WebPage/DecoderAdapter.cpp:

(WebKit::DecoderAdapter::decodeUInt16):
(WebKit):

  • WebProcess/WebPage/DecoderAdapter.h:

(DecoderAdapter):

  • WebProcess/WebPage/EncoderAdapter.cpp:

(WebKit::EncoderAdapter::encodeUInt16):
(WebKit):

  • WebProcess/WebPage/EncoderAdapter.h:

(EncoderAdapter):

  • WebProcess/qt/QtNetworkAccessManager.cpp:

(WebKit::QtNetworkAccessManager::onProxyAuthenticationRequired):
(WebKit):

  • WebProcess/qt/QtNetworkAccessManager.h:

(QtNetworkAccessManager):

04:16 Changeset [108231] by wingo@igalia.com
  • 2 edits in trunk/Tools

Add wingo as a committer.

Unreviewed.

  • Scripts/webkitpy/common/config/committers.py: Add myself to the

committers list.

04:14 WebKitGTK/WebKit2Roadmap edited by carlosgc@webkit.org
(diff)
04:13 WebKitGTK/WebKit2Roadmap edited by carlosgc@webkit.org
(diff)
03:44 Changeset [108230] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Correct a typo error in ScrollingCoordinator.h
https://bugs.webkit.org/show_bug.cgi?id=79012

Patch by Kwonjin Jeong <gram@company100.net> on 2012-02-20
Reviewed by Andreas Kling.

  • page/scrolling/ScrollingCoordinator.h:

(ScrollingCoordinator):

02:50 Changeset [108229] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Styles] box-shadow and -webkit-box-shadow properties are not considered color-aware
https://bugs.webkit.org/show_bug.cgi?id=78988

Reviewed by Yury Semikhatsky.

  • inspector/front-end/CSSKeywordCompletions.js:
02:47 Changeset [108228] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

[Forms] Spin buttons of number input type should fire both input and change event
https://bugs.webkit.org/show_bug.cgi?id=75067

Patch by Yosifumi Inoue <yosin@chromium.org> on 2012-02-20
Reviewed by Kent Tamura.

Source/WebCore:

This patch makes spin button in number input field clicks to fire input and change events as described in WHATWG HTML5 specification.
To implement this behavior, this patch introduces new value DispatchInputAndChangeEvent in TextFieldEventBehavior.

Test: fast/forms/number/spin-button-events.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::stepUpFromRenderer): Pass DispatchInputAndChangeEvent instead of DispatchChangeEvent to applyStep, setValue, and setValueAsNumber.

  • html/HTMLTextFormControlElement.h: Add new enum value DispatchInputAndChangeEvent to TextFieldEventBehavior.
  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::setValue): Handle DispatchInputAndChangeEvent and use RefPtr for element to keep reference.

LayoutTests:

  • fast/forms/number/spin-button-events-expected.txt: Added.
  • fast/forms/number/spin-button-events.html: Added.
02:15 Changeset [108227] by paroga@webkit.org
  • 2 edits in trunk/Source/WebKit2

[CMake] Update and sort list of source files.

  • CMakeLists.txt:
01:33 Changeset [108226] by shinyak@chromium.org
  • 5 edits
    2 adds in trunk

Attached/Detached state must be testable
https://bugs.webkit.org/show_bug.cgi?id=79010

Reviewed by Hajime Morita.

Source/WebCore:

Added a method to check an element attached or not.

Test: fast/dom/shadow/shadow-root-attached.html

  • testing/Internals.cpp:

(WebCore::Internals::attached):
(WebCore):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

LayoutTests:

  • fast/dom/shadow/shadow-root-attached-expected.txt: Added.
  • fast/dom/shadow/shadow-root-attached.html: Added.
01:30 Changeset [108225] by jochen@chromium.org
  • 4 edits in trunk/Tools

[chromium] check that we're not running multiple modal dialogs at the same time
https://bugs.webkit.org/show_bug.cgi?id=78486

Reviewed by Kent Tamura.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell::setIsDisplayingModalDialog):
(TestShell::isDisplayingModalDialog):
(TestShell):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::runModal):

01:25 WebKitIDL edited by haraken@chromium.org
(diff)
01:16 Changeset [108224] by mrobinson@webkit.org
  • 8 edits in releases/WebKitGTK/webkit-1.8

Merging r108222

01:15 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
01:14 Changeset [108223] by mrobinson@webkit.org
  • 3 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit2

Merging r108216

01:13 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
01:12 Changeset [108222] by mrobinson@webkit.org
  • 8 edits in trunk

Fix WebKit2GTK+ for 'make distcheck'.

Instead of conditionally including WebKit2 GNUmakefiles, always
include them and conditionally activate the final targets.

.:

  • GNUmakefile.am:

Source/WebKit2:

  • GNUmakefile.am:
  • UIProcess/API/gtk/tests/GNUmakefile.am:

Tools:

  • MiniBrowser/gtk/GNUmakefile.am:
  • WebKitTestRunner/GNUmakefile.am:
00:59 Changeset [108221] by bashi@chromium.org
  • 9 edits
    3 adds in trunk/Source

[WebSocket] Add deflater/inflater classes
https://bugs.webkit.org/show_bug.cgi?id=78449

Source/WebCore:

Add WebSocketDeflater/WebSocketInflater classes which wrap zlib
functions. These classes are not used yet, but will be used for
supporting WebSocket deflate-frame extension.

This patch is second try. The previous patch broke Chromium Win
build. I added dependency of zlib to WebCore.gyp. I think it's
OK because Chromium already depends on zlib.

Reviewed by Kent Tamura.

No new tests except for chromium port. Behavior is unchanged.

  • GNUmakefile.list.am: Added WebSocketDeflater.(cpp|h).
  • WebCore.gyp/WebCore.gyp: Added zlib dependency.
  • WebCore.gypi: Added WebSocketDeflater.(cpp|h).
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • websockets/WebSocketDeflater.cpp: Added.

(WebCore):
(WebCore::WebSocketDeflater::create):
(WebCore::WebSocketDeflater::WebSocketDeflater):
(WebCore::WebSocketDeflater::initialize):
(WebCore::WebSocketDeflater::~WebSocketDeflater):
(WebCore::setStreamParameter):
(WebCore::WebSocketDeflater::addBytes):
(WebCore::WebSocketDeflater::finish):
(WebCore::WebSocketDeflater::reset):
(WebCore::WebSocketInflater::create):
(WebCore::WebSocketInflater::WebSocketInflater):
(WebCore::WebSocketInflater::initialize):
(WebCore::WebSocketInflater::~WebSocketInflater):
(WebCore::WebSocketInflater::addBytes):
(WebCore::WebSocketInflater::finish):
(WebCore::WebSocketInflater::reset):

  • websockets/WebSocketDeflater.h: Added.

(WebCore):
(WebSocketDeflater):
(WebCore::WebSocketDeflater::data):
(WebCore::WebSocketDeflater::size):
(WebSocketInflater):
(WebCore::WebSocketInflater::data):
(WebCore::WebSocketInflater::size):

Source/WebKit/chromium:

Add tests which ensure WebSocketDeflater/WebSocketInflater can
compress/decompress data correctly.

Reviewed by Kent Tamura.

  • WebKit.gypi: Added zlib dependency.
  • WebKitUnitTests.gyp: Ditto.
  • tests/WebSocketDeflaterTest.cpp: Added.

(WebCore):
(WebCore::TEST):

00:48 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
00:48 WebKitIDL edited by haraken@chromium.org
(diff)
00:45 Changeset [108220] by mrobinson@webkit.org
  • 3 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore

Merging r108191

00:40 Changeset [108219] by mrobinson@webkit.org
  • 8 edits in releases/WebKitGTK/webkit-1.8/Source

Merging r108206

00:40 Changeset [108218] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: consume undo/redo shortcuts.
https://bugs.webkit.org/show_bug.cgi?id=79016

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.handleShortcut):

00:39 Changeset [108217] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

Enable video option for EFL port in build-webkit.
https://bugs.webkit.org/show_bug.cgi?id=79006

Reviewed by Daniel Bates.

  • Scripts/build-webkit:
00:38 Changeset [108216] by mrobinson@webkit.org
  • 3 edits in trunk/Source/WebKit2

[GTK][WK2] WebKit2 does not build if gtk-unix-printing-3.0 is not available
https://bugs.webkit.org/show_bug.cgi?id=79011

Fix the build when gtk-unix-printing-3.0 is not present.

  • UIProcess/API/gtk/WebKitPrintOperation.cpp:

(webkitPrintOperationRunDialog):
(webkitPrintOperationRunDialogForFrame):

  • WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:

(WebKit::WebPrintOperationGtk::create):

00:37 Changeset [108215] by philn@webkit.org
  • 2 edits in trunk/Source/WebCore

MediaPlayer: MediaPlayerPrivate registration cleanup
https://bugs.webkit.org/show_bug.cgi?id=78897

Reviewed by Martin Robinson.

  • platform/graphics/MediaPlayer.cpp:

(WebCore::installedMediaEngines): Simplified GStreamer Private
player registration by using the PlatformMediaEngineClassName
macro like other players do.

00:34 Changeset [108214] by philn@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed, GTK baselines for a new fast/css-generated-content
test.

  • platform/gtk/fast/css-generated-content/before-content-continuation-chain-expected.txt: Added.
00:28 Changeset [108213] by philn@webkit.org
  • 5 edits in trunk/LayoutTests

Unreviewed, GTK fast/repaint rebaseline.

  • platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
  • platform/gtk/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
  • platform/gtk/fast/repaint/region-painting-via-layout-expected.txt:
00:07 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)

02/19/12:

23:51 Changeset [108212] by yurys@chromium.org
  • 5 edits in trunk/Source

[Chromium] Web Inspector: terminated workers are not removed from dedicated worker list
https://bugs.webkit.org/show_bug.cgi?id=78899

Source/WebCore:

Notify inspector about starting context from WorkerContextProxy not from Worker.

Reviewed by Pavel Feldman.

  • workers/Worker.cpp:

(WebCore::Worker::notifyFinished):

  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::startWorkerContext):

Source/WebKit/chromium:

Pass original WorkerContextProxy object to the inspector instrumentation instead
of Chromium-specific one for consistency with WorkerMessagingProxy implementation
in WebCore.

Reviewed by Pavel Feldman.

  • src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::startWorkerContext):

23:47 WebKitIDL edited by haraken@chromium.org
(diff)
23:41 Changeset [108211] by gyuyoung.kim@samsung.com
  • 8 edits in trunk

[CMAKE] Check gstreamer minimum required version.
https://bugs.webkit.org/show_bug.cgi?id=79005

Reviewed by Daniel Bates.

To enable video, Gstreamer version requires to be above 0.10.30.
This patch checks whether Gstreamer version is greater than 0.10.30.

  • Source/cmake/FindGStreamer-App.cmake:
  • Source/cmake/FindGStreamer-Base.cmake:
  • Source/cmake/FindGStreamer-Interfaces.cmake:
  • Source/cmake/FindGStreamer-Pbutils.cmake:
  • Source/cmake/FindGStreamer-Plugins-Base.cmake:
  • Source/cmake/FindGStreamer-Video.cmake:
  • Source/cmake/FindGStreamer.cmake:
23:03 Changeset [108210] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, update a few test expectations.

  • platform/chromium/test_expectations.txt:
22:41 WebKitIDL edited by haraken@chromium.org
(diff)
22:31 WebKitIDL edited by haraken@chromium.org
(diff)
22:30 WebKitIDL edited by haraken@chromium.org
(diff)
22:29 WebKitIDL edited by haraken@chromium.org
(diff)
22:26 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
22:22 WebKitIDL edited by haraken@chromium.org
(diff)
22:17 Changeset [108209] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

Use shadowRootList for ColorInputType
https://bugs.webkit.org/show_bug.cgi?id=79007

Reviewed by Kent Tamura.

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::createShadowSubtree): Changed shadowRoot to shadowRootList.
(WebCore::ColorInputType::shadowColorSwatch): Changed shadowRoot to shadowRootList.

22:14 WebKitIDL edited by haraken@chromium.org
(diff)
22:06 Changeset [108208] by noel.gordon@gmail.com
  • 5 edits
    1 add
    1 delete in trunk/LayoutTests

[chromium] Unreviewed. Update remaining expectations for SVGImageElement-svgdom-requiredFeatures.html.

  • platform/chromium-linux/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png: Removed.
  • platform/chromium-win/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png:
  • platform/chromium/test_expectations.txt:
22:01 WebKitIDL edited by haraken@chromium.org
(diff)
22:00 WebKitIDL edited by haraken@chromium.org
(diff)
22:00 Changeset [108207] by shinyak@chromium.org
  • 9 edits
    2 adds in trunk/Source/WebCore

Introduce InsertionPoint, which will be a common base class of HTMLShadowElement and HTMLContentElement.
https://bugs.webkit.org/show_bug.cgi?id=78771

Reviewed by Hajime Morita.

This patch introduces InsertionPoint, which will be a common base class of HTMLShadowElement and HTMLContentElement.

This is a step for rendering <shadow> correctly, because <shadow> has almost the same function of <content>.
After this patch, we will change NodeRenderingContext and related classes to accept InsertionPoint instead of
HTMLContentElement only.

No new tests, no change in behavior.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::HTMLContentElement):
(WebCore::HTMLContentElement::attach):
(WebCore::HTMLContentElement::detach):
(WebCore::HTMLContentElement::parseAttribute):

  • html/shadow/HTMLContentElement.h:
  • html/shadow/InsertionPoint.cpp: Added.

(WebCore):
(WebCore::InsertionPoint::InsertionPoint):
(WebCore::InsertionPoint::~InsertionPoint):

  • html/shadow/InsertionPoint.h: Added.

(WebCore):
(InsertionPoint):

21:59 WebKitIDL edited by haraken@chromium.org
(diff)
21:24 Changeset [108206] by commit-queue@webkit.org
  • 8 edits in trunk/Source

[GTK] Can't find webinspector and error page redirection on Windows
https://bugs.webkit.org/show_bug.cgi?id=51616

Source/WebCore:

Create and use an abstraction for finding shared resources on Windows.

Patch by Paweł Forysiuk <tuxator@o2.pl> on 2012-02-19
Reviewed by Martin Robinson.

  • platform/FileSystem.h:

(WebCore):

  • platform/audio/gtk/AudioBusGtk.cpp:

(WebCore::AudioBus::loadPlatformResource):

  • platform/graphics/gtk/ImageGtk.cpp:

(WebCore::getPathToImageResource):

  • platform/gtk/FileSystemGtk.cpp:

(WebCore::sharedResourcesPath):
(WebCore):

Source/WebKit/gtk:

Use an abstraction for finding shared resources on Windows.

Patch by Paweł Forysiuk <tuxator@o2.pl> on 2012-02-19
Reviewed by Martin Robinson.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDidFailLoad):

  • WebCoreSupport/InspectorClientGtk.cpp:

(WebKit::InspectorClient::inspectorFilesPath):

20:22 Changeset [108205] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening. Update Leopard expectation for
SVGImageElement-svgdom-requiredFeatures.html.

  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png:
17:11 Changeset [108204] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed - mark failing test as failing.

  • platform/chromium/test_expectations.txt:
16:04 Changeset [108203] by jamesr@google.com
  • 2 edits
    11 adds in trunk/LayoutTests

[chromium] Unreviewed gardening. Add leopard baselines for fast/css/relative-positioned-block-* tests, fix up test_expectations.txt

  • platform/chromium-mac-leopard/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/relative-positioned-block-with-inline-ancestor-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png: Added.
  • platform/chromium/test_expectations.txt:
15:51 Changeset [108202] by jamesr@google.com
  • 9 edits
    1 copy in trunk/Source/WebCore

Move stub implementations of ScrollingCoordinator functions into ScrollingCoordinatorNone.cpp
https://bugs.webkit.org/show_bug.cgi?id=78951

Reviewed by Adam Barth.

This move stubs for ScrollingCoordinator functions into ScrollingCoordinatorNone.cpp instead of #ifdefing inside
ScrollingCoordinator.cpp. The mac port uses ScrollingCoordinator when #if ENABLE(THREADED_SCROLLING) is not set
and implementations in ScrollingCoordinator.cpp / ScrollingCoordinatorMac.mm otherwise. The chromium port
always uses implementations in ScrollingCoordinatorChromium.cpp. All other ports use
ScrollingCoordinatorNone.cpp.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbx:
  • page/scrolling/ScrollingCoordinator.cpp:
  • page/scrolling/ScrollingCoordinatorNone.cpp:

(WebCore):
(WebCore::ScrollingCoordinator::create):
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::setScrollLayer):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setScrollParameters):
(WebCore::ScrollingCoordinator::setWheelEventHandlerCount):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinator::create):
(WebCore):

15:47 Changeset [108201] by haraken@chromium.org
  • 8 edits in trunk/Source/WebCore

Rename [CheckDomainSecurity] to [CheckSecurity]
https://bugs.webkit.org/show_bug.cgi?id=78874

Reviewed by Adam Barth.

"Domain security" isn't a term that's used elsewhere.
This patch renames IDL attributes as follows:

  • [CheckDomainSecurity] => [CheckSecurity]
  • [DoNotCheckDomainSecurity] => [DoNotCheckSecurity]
  • [DoNotCheckDomainSecurityOnGetter] => [DoNotCheckSecurityOnGetter]
  • [DoNotCheckDomainSecurityOnSetter] => [DoNotCheckSecurityOnSetter]

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertyDescriptorBody):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(IsVisibleAcrossOrigins):
(GenerateFunctionCallback):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
(GenerateToV8Converters):

  • bindings/scripts/test/TestDomainSecurity.idl:
  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::ConfigureV8TestActiveDOMObjectTemplate):

  • page/DOMWindow.idl:
  • page/History.idl:
  • page/Location.idl:
15:32 Changeset [108200] by jamesr@google.com
  • 8 edits
    2 adds
    2 deletes in trunk

Unreviewed, rolling out r108195.
http://trac.webkit.org/changeset/108195
https://bugs.webkit.org/show_bug.cgi?id=77700

Lots of failing ASSERT()s on v8 bots, requested by kling on
#webkit

Source/WebCore:

  • bindings/js/JSCSSValueCustom.cpp:

(WebCore::toJS):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

LayoutTests:

  • fast/css/css-value-wrapper-sameness-expected.txt: Removed.
  • fast/css/css-value-wrapper-sameness.html: Removed.
  • fast/dom/StyleSheet/gc-inline-style-cssvalues-expected.txt: Added.
  • fast/dom/StyleSheet/gc-inline-style-cssvalues.html: Added.
  • fast/dom/domListEnumeration-expected.txt:
  • fast/dom/gc-9-expected.txt:
  • fast/dom/gc-9.html:
  • fast/dom/script-tests/domListEnumeration.js:
15:30 Changeset [108199] by haraken@chromium.org
  • 10 edits in trunk/Source/WebCore

Rename [CheckAccessToNode] to [CheckSecurityForNode]
https://bugs.webkit.org/show_bug.cgi?id=78991

Reviewed by Adam Barth.

For naming consistency with [CheckSecurity], this patch renames
[CheckAccessToNode] to [CheckSecurityForNode].

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateFunctionCallback):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

  • html/HTMLEmbedElement.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLIFrameElement.idl:
  • html/HTMLObjectElement.idl:
  • page/DOMWindow.idl:
15:24 Changeset [108198] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

Sort WebCore XCode project files with sort-Xcode-project-files script. Unreviewed.

  • WebCore.xcodeproj/project.pbxproj:
14:50 WebKitGTK/1.8.x edited by kov@webkit.org
(diff)
14:43 Changeset [108197] by kov@webkit.org
  • 7 edits in releases/WebKitGTK/webkit-1.8

Merging r108190

12:58 Changeset [108196] by robert@webkit.org
  • 4 edits in trunk/LayoutTests

Update expectations for test results changed by r108185

The bots only check text results.

Unreviewed.

  • platform/gtk/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
12:16 Changeset [108195] by kling@webkit.org
  • 8 edits
    2 adds
    2 deletes in trunk

Make CSSValue wrapper getters return unique objects every time.
<http://webkit.org/b/77700>

Reviewed by Antti Koivisto.

Source/WebCore:

Change the behavior of CSSValue getters to return unique JS wrappers every
time they are called. This means we no longer have to deal with the risk
of leaking custom properties between unrelated documents, and are free to
implement global value sharing across WebCore.

This patch will be followed by one making CSSValuePool globally shared,
it's done in two steps to monitor the impact of this change.

  • bindings/js/JSCSSValueCustom.cpp:

(WebCore::toJS):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(IsCSSValueType):

LayoutTests:

  • fast/css/css-value-wrapper-sameness-expected.txt: Added.
  • fast/css/css-value-wrapper-sameness.html: Added.
  • fast/dom/StyleSheet/gc-inline-style-cssvalues-expected.txt: Removed.
  • fast/dom/StyleSheet/gc-inline-style-cssvalues.html: Removed.
  • fast/dom/domListEnumeration-expected.txt:
  • fast/dom/gc-9-expected.txt:
  • fast/dom/gc-9.html:
  • fast/dom/script-tests/domListEnumeration.js:
12:06 Changeset [108194] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash in RenderBlock::splitAnonymousBlocksAroundChild.
https://bugs.webkit.org/show_bug.cgi?id=78994

Reviewed by Eric Seidel.

Source/WebCore:

Generalize splitTablePartsAroundChild to handle splitting
in nested tables.
Table->Table Section->Table Row->Table Cell->Table->Table Section->Table Row

Test: fast/table/table-split-inside-table.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::splitTablePartsAroundChild):

LayoutTests:

  • fast/table/table-split-inside-table-expected.txt: Added.
  • fast/table/table-split-inside-table.html: Added.
11:36 Changeset [108193] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

Unreviewed. Remove gsettings schema from EXTRA_DIST.

  • GNUmakefile.am:
11:29 Changeset [108192] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Use modifier keys to execute pre-rendering.
https://bugs.webkit.org/show_bug.cgi?id=77933

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2012-02-19
Reviewed by Chang Shu.

Use modifier key to execute pre-rendering instead of using reserved function keys.

  • EWebLauncher/main.c:

(on_key_down):

11:16 Changeset [108191] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[GTK] Fix build on platforms where UChar is wchar_t
https://bugs.webkit.org/show_bug.cgi?id=78996

Patch by Kalev Lember <kalevlember@gmail.com> on 2012-02-19
Reviewed by Martin Robinson.

The ICU backend defines UChar as wchar_t for platforms where wchar_t is
16 bits wide, e.g. win32.

  • platform/graphics/pango/FontPango.cpp:

(WebCore::utf16ToUtf8): Use reinterpret_cast instead of static_cast.

  • platform/gtk/GtkPopupMenu.cpp:

(WebCore::GtkPopupMenu::typeAheadFind): Ditto.

11:16 Changeset [108190] by kov@webkit.org
  • 7 edits
    1 delete in trunk

[GTK] Remove unused GSettings stuff
https://bugs.webkit.org/show_bug.cgi?id=78995

Reviewed by Martin Robinson.

.:

  • configure.ac: remove gsettings schema file creation.

Source/WebKit/gtk:

  • GNUmakefile.am: remove GSettings-related stuff.
  • WebCoreSupport/InspectorClientGtk.cpp:

(WebKit): Remove unused code.

  • org.webkitgtk.gschema.xml.in: Removed.
  • webkit/webkitwebinspector.cpp:

(webkit_web_inspector_execute_script): remove gsettings-related helper.

  • webkit/webkitwebinspectorprivate.h: Ditto.
11:03 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
11:01 Changeset [108189] by rniwa@webkit.org
  • 3 edits in trunk

Perf-o-matic should show both WebKit and Chromium revisions
https://bugs.webkit.org/show_bug.cgi?id=78955

Reviewed by Andreas Kling.

Include Chromium revision numbers in runs responses when available.

  • Websites/webkit-perf.appspot.com/js/config.js:

(urlForChangeset):
(urlForChangesetList):

  • Websites/webkit-perf.appspot.com/runs_handler.py:

(RunsHandler.post):

10:32 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
10:16 WebKitGTK edited by mrobinson@webkit.org
(diff)
10:15 WebKitGTK/1.8.x created by mrobinson@webkit.org
09:41 Changeset [108188] by mrobinson@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.8

Branching for the WebKitGTK+ 1.8 stable release

08:53 Changeset [108187] by carlosgc@webkit.org
  • 4 edits in trunk/Source

Unreviewed. Fix make distcheck issues.

Source/JavaScriptCore:

  • GNUmakefile.list.am: Add missing files.

Source/WebCore:

  • GNUmakefile.list.am: Add missing header.
08:27 Changeset [108186] by robert@webkit.org
  • 5 edits
    25 moves
    36 adds
    2 deletes in trunk/LayoutTests

Chromium results for r108185

Unreviewed gardening.

  • platform/chromium-linux/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png.
  • platform/chromium-linux/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png.
  • platform/chromium-linux/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png.
  • platform/chromium-linux/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png.
  • platform/chromium-linux/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png.
  • platform/chromium-linux/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png.
  • platform/chromium-linux/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png.
  • platform/chromium-linux/fast/css/relative-positioned-block-with-inline-ancestor-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-expected.png.
  • platform/chromium-linux/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png.
  • platform/chromium-linux/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png.
  • platform/chromium-linux/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/encoding/utf-16-big-endian-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/encoding/utf-16-big-endian-expected.png.
  • platform/chromium-mac-snowleopard/fast/encoding/utf-16-little-endian-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/encoding/utf-16-little-endian-expected.png.
  • platform/chromium-mac-snowleopard/fast/inline/continuation-outlines-with-layers-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/inline/continuation-outlines-with-layers-expected.png.
  • platform/chromium-mac-snowleopard/fast/repaint/transform-absolute-in-positioned-container-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/transform-absolute-in-positioned-container-expected.txt: Added.
  • platform/chromium-mac/fast/encoding/utf-16-big-endian-expected.png: Removed.
  • platform/chromium-mac/fast/encoding/utf-16-little-endian-expected.png: Removed.
  • platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png: Added.
  • platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.txt.
  • platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png: Added.
  • platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.txt.
  • platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png: Added.
  • platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-expected.txt.
  • platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png: Added.
  • platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.txt.
  • platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png: Added.
  • platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.txt.
  • platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png: Added.
  • platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.txt.
  • platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png: Added.
  • platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.txt.
  • platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-expected.png: Added.
  • platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-expected.txt.
  • platform/chromium-win/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png: Added.
  • platform/chromium-win/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.txt.
  • platform/chromium-win/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png: Added.
  • platform/chromium-win/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.txt.
  • platform/chromium-win/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png: Added.
  • platform/chromium-win/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.txt.
  • platform/chromium-win/fast/encoding/utf-16-big-endian-expected.png:
  • platform/chromium-win/fast/encoding/utf-16-little-endian-expected.png:
  • platform/chromium-win/fast/inline/continuation-outlines-with-layers-expected.png:
  • platform/chromium-win/fast/repaint/transform-absolute-in-positioned-container-expected.png:
07:24 Changeset [108185] by robert@webkit.org
  • 19 edits
    43 adds in trunk

CSS 2.1 failure: inline-box-002.htm fails
https://bugs.webkit.org/show_bug.cgi?id=69210

Reviewed by David Hyatt.

Source/WebCore:

Tests: css2.1/20110323/dynamic-top-change-005.htm

css2.1/20110323/dynamic-top-change-005a.htm
css2.1/20110323/dynamic-top-change-005b.htm
css2.1/20110323/inline-box-002.htm
fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed.html
fast/css/relative-positioned-block-nested-with-inline-parent-dynamic.html
fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic.html
fast/css/relative-positioned-block-nested-with-inline-parent.html
fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic.html
fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed.html
fast/css/relative-positioned-block-with-inline-ancestor-dynamic.html
fast/css/relative-positioned-block-with-inline-ancestor.html
fast/css/relative-positioned-block-with-inline-parent-dynamic-removed.html
fast/css/relative-positioned-block-with-inline-parent-dynamic.html
fast/css/relative-positioned-block-with-inline-parent-keeps-style.html
fast/css/relative-positioned-block-with-inline-parent.html

A block within an inline is affected by relative positioning on the inline box. Give
the anonymous block containing the block a layer and make it relative positioned. Then
calculate the offset of the anonymous block's layer by accumulating the offsets from its
inline continuation and the inline continuation's inline parents.
If the position of an inline changes from or to relative positioned then ensure that any
descendant blocks update their position and layer accordingly.

  • rendering/RenderBoxModelObject.cpp:

(): add an enum RelPosAxis
(WebCore::accumulateRelativePositionOffsets):
Total up the offsets of all relatively positioned inlines that are de-facto parents of the relatively
positioned anonymous block's child block.

(WebCore):
(WebCore::RenderBoxModelObject::relativePositionOffsetX):
Use accumulateRelativePositionOffsets when calculating the relative position offset of a relatively positioned anonymous block.

(WebCore::RenderBoxModelObject::relativePositionOffsetY): ditto

  • rendering/RenderInline.cpp:

(WebCore::hasRelPositionedInlineAncestor):
Detects if the anonymous block contains a block that is the de-facto descendant of a relatively positioned inline.

(WebCore::updateStyleOfAnonymousBlockContinuations):
Update the style's positioning for each anonymous block containing a block that is descendant from the inline whose style has changed.

(WebCore::RenderInline::styleDidChange):
If an inline changes to or from relative positioning ensure that any descendant blocks change to or from relative positioning
as well, unless they still have a relatively positioned ancestor after the current ancestor loses its relative positioning.

(WebCore::RenderInline::addChildIgnoringContinuation):
If the anonymous block contains a block that is effectively descended from a relatively positioned inline, make it relatively
positioned so the block will respect its inline ancestor's relative positioning.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::propagateStyleToAnonymousChildren):
Preserve style position in anonymous block continuations when the parent block propagates a style change.

LayoutTests:

  • css2.1/20110323/dynamic-top-change-005-expected.html: Added.
  • css2.1/20110323/dynamic-top-change-005.htm: Added.
  • css2.1/20110323/dynamic-top-change-005a-expected.html: Added.
  • css2.1/20110323/dynamic-top-change-005a.htm: Added.
  • css2.1/20110323/dynamic-top-change-005b-expected.html: Added.
  • css2.1/20110323/dynamic-top-change-005b.htm: Added.
  • css2.1/20110323/inline-box-002-expected.html: Added.
  • css2.1/20110323/inline-box-002.htm: Added.
  • fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed.html: Added.
  • fast/css/relative-positioned-block-nested-with-inline-parent-dynamic.html: Added.
  • fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic.html: Added.
  • fast/css/relative-positioned-block-nested-with-inline-parent.html: Added.
  • fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic.html: Added.
  • fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed.html: Added.
  • fast/css/relative-positioned-block-with-inline-ancestor-dynamic.html: Added.
  • fast/css/relative-positioned-block-with-inline-ancestor.html: Added.
  • fast/css/relative-positioned-block-with-inline-parent-dynamic-removed.html: Added.
  • fast/css/relative-positioned-block-with-inline-parent-dynamic.html: Added.
  • fast/css/relative-positioned-block-with-inline-parent-expected.html: Added.
  • fast/css/relative-positioned-block-with-inline-parent-keeps-style.html: Added.
  • fast/css/relative-positioned-block-with-inline-parent.html: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.txt: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.txt: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-expected.txt: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.txt: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.txt: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.txt: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.txt: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-expected.txt: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.txt: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.txt: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.txt: Added.
  • platform/chromium-linux/fast/encoding/utf-16-big-endian-expected.png:
  • platform/chromium-linux/fast/encoding/utf-16-little-endian-expected.png:
  • platform/chromium-linux/fast/inline/continuation-outlines-with-layers-2-expected.txt:
  • platform/chromium-linux/fast/inline/continuation-outlines-with-layers-expected.png:
  • platform/chromium-linux/fast/repaint/transform-absolute-in-positioned-container-expected.png:
  • platform/chromium-win/fast/encoding/utf-16-big-endian-expected.txt:
  • platform/chromium-win/fast/encoding/utf-16-little-endian-expected.txt:
  • platform/chromium-win/fast/inline/continuation-outlines-with-layers-expected.txt:
  • platform/chromium-win/fast/repaint/transform-absolute-in-positioned-container-expected.txt:
  • platform/chromium/test_expectations.txt: Suppress existing tests until results rebaselined.
  • platform/gtk/test_expectations.txt: ditto
  • platform/mac/test_expectations.txt: ditto
  • platform/qt/test_expectations.txt: ditto
  • platform/win/Skipped: ditto

02/18/12:

22:25 Changeset [108184] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk/Source

Track the NPN protocol version negotiated with the server
https://bugs.webkit.org/show_bug.cgi?id=77349

Source/WebCore:

Patch by raman Tenneti <rtenneti@chromium.org> on 2012-02-18
Reviewed by Darin Fisher..

[chromium] Added ExtraData to WebURLResponse.

No intended functionality change.

  • platform/network/chromium/ResourceResponse.h:

(ExtraData):
(WebCore::ResourceResponse::ExtraData::~ExtraData):
(ResourceResponse):
(WebCore::ResourceResponse::extraData):
(WebCore::ResourceResponse::setExtraData):

Source/WebKit/chromium:

Patch by raman Tenneti <rtenneti@chromium.org> on 2012-02-18
Reviewed by Darin Fisher.

[chromium] Added ExtraData to WebURLResponse.

  • WebKit.gypi:
  • public/platform/WebURLResponse.h:

(ExtraData):
(WebKit::WebURLResponse::ExtraData::~ExtraData):
(WebURLResponse):

  • src/WebURLResponse.cpp:

(WebKit::WebURLResponse::extraData):
(WebKit):
(WebKit::WebURLResponse::setExtraData):

  • tests/WebURLResponseTest.cpp: Added.

(WebKit):
(TestExtraData):
(WebKit::TestExtraData::TestExtraData):
(WebKit::TestExtraData::~TestExtraData):
(WebKit::TEST):

20:57 Changeset [108183] by inferno@chromium.org
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r107965.
http://trac.webkit.org/changeset/107965
https://bugs.webkit.org/show_bug.cgi?id=78273

Source/WebCore:

crashes

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::clone):

LayoutTests:

Crashes on ClusterFuzz.

  • fast/multicol/span/clone-flexbox-expected.txt: Removed.
  • fast/multicol/span/clone-flexbox.html: Removed.
20:07 Changeset [108182] by dpranke@chromium.org
  • 2 edits in trunk/Tools

Fix one more dangling reference to worker_connection.name, delete unused code.

Unreviewed, build fix.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.update):
(_WorkerState.init):

19:53 Changeset [108181] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

<rdar://problem/10891801> BackingStore::scroll() unnecessarily copies pixels around
https://bugs.webkit.org/show_bug.cgi?id=78976

Reviewed by Anders Carlsson.

Rather than move pixels in the backing store in response to scrolling, we can maintain a
mapping, for the most recently scrolled rect, from backing store coordinates to view
client coordinates.

  • UIProcess/BackingStore.h:
  • UIProcess/mac/BackingStoreMac.mm:

(WebKit::BackingStore::performWithScrolledRectTransform): Added. Given a block to be
performed on a rect, divides the rect into parts such that for each part the mapping from
backing store coordinates to client coordinates is a (uniform) translation, and performs
the block on that part, passing it the translation that applies to the part.
(WebKit::BackingStore::resetScrolledRect): Added. Copies everything in the scrolled rect
back to where it should be under the identity map, and resets the scrolled rect and offset.
(WebKit::BackingStore::paint): Changed to call through performWithScrolledRectTransform().
(WebKit::BackingStore::incorporateUpdate): Ditto.
(WebKit::BackingStore::scroll): Now instead of copying pixels, just updates the scrolled
rect and offset.

17:53 Changeset [108180] by weinig@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Fix style issues in DFG Phase classes
https://bugs.webkit.org/show_bug.cgi?id=78983

Reviewed by Ryosuke Niwa.

  • dfg/DFGArithNodeFlagsInferencePhase.cpp:
  • dfg/DFGCFAPhase.cpp:
  • dfg/DFGCSEPhase.cpp:
  • dfg/DFGPredictionPropagationPhase.cpp:
  • dfg/DFGVirtualRegisterAllocationPhase.cpp:

Add a space before the colon in class declarations.

17:08 Changeset [108179] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Make WebCore compile with libc++ (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=78974

Reviewed by Anders Carlsson.

  • config.h:

Disable the DisallowCType check when using libc++.

16:57 Changeset [108178] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the build.

  • page/DOMWindow.idl:
16:50 Changeset [108177] by dpranke@chromium.org
  • 4 edits in trunk/Tools

Add a change that should've been in r108005.

Unreviewed, build fix.

In the refactoring/cleanup in r108005 I should've changed the
implementation of WorkerConnection to make it match BrokerClient
(and everything else) so that objects had a name() method
instead of a name property.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._run_tests):

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:

(_WorkerConnection.init):
(_WorkerConnection.name):

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:

(_TestWorker.init):
(_TestsMixin.name):
(_TestsMixin.test_name):
(_TestsMixin.test_cancel):
(_TestsMixin.test_unknown_message):

16:33 Changeset [108176] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Attempt to fix Windows build.

15:51 Changeset [108175] by dpranke@chromium.org
  • 6 edits
    2 deletes in trunk/Tools

webkitpy: remove webkitpy.common.array_stream
https://bugs.webkit.org/show_bug.cgi?id=78952

Reviewed by Eric Seidel.

Turns out array_stream didn't really do anything that StringIO
didn't do (at least as of Python 2.6). This change removes it
and updates all of the callers. Where possible, I changed the
test assertions in order to capture the intent more clearly,
e.g., instead of calling self.assertTrue('foo' in stream.get()),
we have self.assertContainsLine(stream, 'foo'), and instead of
self.assertTrue(stream.empty()), we have self.assertEmpty(stream) -
the latter isn't that much more readable, but StringIO doesn't
export an empty() method.

  • Scripts/webkitpy/common/array_stream.py: Removed.
  • Scripts/webkitpy/common/array_stream_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(passing_run):
(run_and_capture):
(StreamTestingMixin):
(StreamTestingMixin.assertContains):
(StreamTestingMixin.assertContainsLine):
(StreamTestingMixin.assertEmpty):
(StreamTestingMixin.assertNotEmpty):
(LintTest):
(LintTest.test_lint_test_files):
(LintTest.test_lint_test_fileserrors):
(MainTest):
(MainTest.test_child_process_1):
(MainTest.test_child_processes_2):
(MainTest.test_child_processes_min):
(MainTest.test_help_printing):
(MainTest.test_hung_thread):
(MainTest.test_no_tests_found):
(MainTest.test_no_tests_found_2):
(MainTest.test_repeat_each_iterations_num_tests):
(MainTest.test_test_list):
(MainTest.test_unexpected_failures):
(MainTest.test_worker_model
inline_with_child_processes):
(MainTest.test_additional_platform_directory):
(RebaselineTest):
(RebaselineTest.assertBaselines):
(RebaselineTest.test_reset_results):
(RebaselineTest.test_missing_results):
(RebaselineTest.test_new_baseline):

  • Scripts/webkitpy/layout_tests/views/metered_stream.py:

(MeteredStream.update):

  • Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:

(TestMeteredStream.test_regular):

  • Scripts/webkitpy/layout_tests/views/printing_unittest.py:

(TestUtilityFunctions.assertEmpty):
(TestUtilityFunctions):
(TestUtilityFunctions.assertNotEmpty):
(TestUtilityFunctions.assertWritten):
(TestUtilityFunctions.test_configure_logging):
(Testprinter.assertEmpty):
(Testprinter):
(Testprinter.assertNotEmpty):
(Testprinter.assertWritten):
(Testprinter.reset):
(Testprinter.get_printer):
(Testprinter.test_help_printer):
(Testprinter.do_switch_tests.do_helper):
(Testprinter.test_print_one_line_summary):
(Testprinter.test_print_test_result):
(Testprinter.test_print_progress):
(Testprinter.test_write_nothing):
(Testprinter.test_write_misc):
(Testprinter.test_write_everything):
(Testprinter.test_write_verbose):
(Testprinter.test_print_unexpected_results):

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(MainTest.assertWritten):
(create_runner):
(test_run_test_set):
(test_run_test_set_kills_drt_per_run):
(test_run_test_set_for_parser_tests):
(test_run_test_set_with_json_output):
(test_run_test_set_with_json_source):
(test_run_test_set_with_multiple_repositories):
(test_upload_json):

15:42 Changeset [108174] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Make WebCore compile with libc++ (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=78974

Reviewed by Anders Carlsson.

Add a workaround for <rdar://problem/10858112>, which cause the standard heap functions
not to work when using an iterator with proxy objects for reference and pointer types.

  • WebCorePrefix.h:

(move):
Add an overload of std::move that the heap functions can call successfully.

14:30 Changeset [108173] by kling@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed chromium rebaselines after r108157.

  • platform/chromium-mac/fast/dom/setPrimitiveValue-exceptions-expected.txt:
  • platform/chromium-win/fast/dom/setPrimitiveValue-exceptions-expected.txt:
14:10 Changeset [108172] by kevino@webkit.org
  • 4 edits in trunk

[wx] Fix wx port compilation.

14:07 Changeset [108171] by kevino@webkit.org
  • 3 edits in trunk/Source/WebCore

[wx] Build fixes for C++ bindings after recent changes.

14:04 Changeset [108170] by kevino@webkit.org
  • 2 edits in trunk/Source/WebCore

[wx] Build fix, add new platform method wx impl.

13:48 Changeset [108169] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix part of the windows build failure.

  • WebCore.vcproj/WebCore.vcproj:

Don't build JSWebKitCSSRegionRule.cpp, since it is already being built
as part of DerivedSources.cpp.

13:30 Changeset [108168] by weinig@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix the libc++ build.

Reviewed by Anders Carlsson.

  • heap/Weak.h:

Libc++'s nullptr emulation does not allow default construction
of the nullptr_t type. Work around this with the arguably clearer
just returning nullptr.

13:28 Changeset [108167] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the ENABLE(THREADED_SCROLLING) build.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setScrollParameters):

12:07 Changeset [108166] by fpizlo@apple.com
  • 6 edits
    12 adds
    2 deletes in trunk/Source/JavaScriptCore

DFGPropagator.cpp has too many things
https://bugs.webkit.org/show_bug.cgi?id=78956

Reviewed by Oliver Hunt.

Added the notion of a DFG::Phase. Removed DFG::Propagator, and took its
various things and put them into separate files. These new phases follow
the naming convention "DFG<name>Phase" where <name> is a noun. They are
called via functions of the form "perform<name>".

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • dfg/DFGArithNodeFlagsInferencePhase.cpp: Added.

(DFG):
(JSC::DFG::performArithNodeFlagsInference):

  • dfg/DFGArithNodeFlagsInferencePhase.h: Added.

(DFG):

  • dfg/DFGCFAPhase.cpp: Added.

(DFG):
(JSC::DFG::performCFA):

  • dfg/DFGCFAPhase.h: Added.

(DFG):

  • dfg/DFGCSEPhase.cpp: Added.

(DFG):
(JSC::DFG::performCSE):

  • dfg/DFGCSEPhase.h: Added.

(DFG):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGPhase.cpp: Added.

(DFG):
(JSC::DFG::Phase::beginPhase):
(JSC::DFG::Phase::endPhase):

  • dfg/DFGPhase.h: Added.

(DFG):
(Phase):
(JSC::DFG::Phase::Phase):
(JSC::DFG::Phase::~Phase):
(JSC::DFG::Phase::globalData):
(JSC::DFG::Phase::codeBlock):
(JSC::DFG::Phase::profiledBlock):
(JSC::DFG::Phase::beginPhase):
(JSC::DFG::Phase::endPhase):
(JSC::DFG::runPhase):

  • dfg/DFGPredictionPropagationPhase.cpp: Added.

(DFG):
(JSC::DFG::performPredictionPropagation):

  • dfg/DFGPredictionPropagationPhase.h: Added.

(DFG):

  • dfg/DFGPropagator.cpp: Removed.
  • dfg/DFGPropagator.h: Removed.
  • dfg/DFGVirtualRegisterAllocationPhase.cpp: Added.

(DFG):
(JSC::DFG::performVirtualRegisterAllocation):

  • dfg/DFGVirtualRegisterAllocationPhase.h: Added.

(DFG):

11:58 Changeset [108165] by kling@webkit.org
  • 7 edits in trunk/Source/WebCore

HTML: Remove unnecessary attributeChange() overrides.
<http://webkit.org/b/78890>

Reviewed by Anders Carlsson.

Move logic from attributeChanged() overrides into parseAttribute().
This is a step towards making attributeChanged() non-virtual.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

  • html/HTMLMediaElement.h:

(HTMLMediaElement):

  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::parseAttribute):

  • html/HTMLScriptElement.h:

(HTMLScriptElement):

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::parseAttribute):

  • html/HTMLTrackElement.h:

(HTMLTrackElement):

11:53 Changeset [108164] by kling@webkit.org
  • 4 edits in trunk/Source/WebCore

Remove Element::createAttribute().
<http://webkit.org/b/78965>

Reviewed by Anders Carlsson.

Switch call sites to use Attribute::create() directly, as there is no magic
in calling Element::createAttribute() anymore (it used to be virtual and handled
differently by StyledElement.)

  • dom/Element.cpp:

(WebCore::Element::setAttributeInternal):

  • dom/Element.h:
  • svg/properties/SVGAnimatedPropertySynchronizer.h:
11:48 Changeset [108163] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

HTMLBodyElement: Avoid synchronous style recalc when setting link/vlink/alink.
<http://webkit.org/b/78959>

Reviewed by Anders Carlsson.

Mark the body element for deferred style recalc instead of doing it synchronously
when the attributes change.

  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::parseAttribute):

10:33 Changeset [108162] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the TextureMapper build for non-Qt ports. Qt debug builds
must use RTTI, but GTK+, at least, does not.

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::updateBackingStore): Make the RTTI check
Qt only.

10:17 Changeset [108161] by kevino@webkit.org
  • 2 edits in trunk/Tools

[wx] Unreviewed build fix. Don't error out or hang if we have
downloaded dependencies but server update check fails.

05:04 Changeset [108160] by ossy@webkit.org
  • 6 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r107971.

  • platform/qt/tables/mozilla/bugs/bug27038-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug27038-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug27038-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug27038-2-expected.txt:
  • platform/qt/test_expectations.txt:
04:59 Changeset [108159] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed weekend gardening, skip new failing tests.

  • platform/qt/Skipped:
04:51 Changeset [108158] by ossy@webkit.org
  • 4 edits in trunk/LayoutTests

Unreviewed gardening r108133.

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
03:42 Changeset [108157] by kling@webkit.org
  • 5 edits in trunk

FontFamilyValue: Utilize inheritance from CSSPrimitiveValue better.
<http://webkit.org/b/78806>

Reviewed by Antti Koivisto.

Source/WebCore:

Now that FontFamilyValue's string doesn't change after creation, we can just
pass the massaged family name up to the CSSPrimitiveValue constructor and get
cached cssText() for free. This also shrinks FontFamilyValue by sizeof(String)
though that's less of an issue now that we cache them in CSSValuePool.

  • css/FontFamilyValue.cpp:

(WebCore::stripFontFamilyJunk):
(WebCore::FontFamilyValue::FontFamilyValue):

  • css/FontFamilyValue.h:

(WebCore::FontFamilyValue::familyName):
(FontFamilyValue):

LayoutTests:

Rebaseline as CSSPrimitiveValue.getStringValue() is no longer broken for
font-family values.

  • fast/dom/setPrimitiveValue-exceptions-expected.txt:
00:25 Changeset [108156] by lforschler@apple.com
  • 5 edits in branches/safari-534.54-branch/Source

Versioning

00:19 Changeset [108155] by lforschler@apple.com
  • 1 copy in tags/Safari-534.54.16

New tag.

Note: See TracTimeline for information about the timeline view.