Timeline


and

02/24/12:

23:20 Changeset [108887] by noel.gordon@gmail.com

Unreviewed. Add missing fast/images/rgb-jpeg-with-adobe-marker-only.html results.

  • platform/chromium-mac-snowleopard/fast/images/rgb-jpeg-with-adobe-marker-only-expected.txt: Removed.
  • platform/chromium-win/fast/images/rgb-jpeg-with-adobe-marker-only-expected.png: Added.
  • platform/chromium/test_expectations.txt:
20:09 Changeset [108886] by jamesr@google.com

[chromium] Replace RefPtr with OwnPtr for CCLayerImpl tree structure
https://bugs.webkit.org/show_bug.cgi?id=78404

Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-02-24
Reviewed by James Robinson.

Source/WebCore:

No new tests. Updated existing test to reflect changes.

  • platform/graphics/chromium/CanvasLayerChromium.cpp:

(WebCore::CanvasLayerChromium::createCCLayerImpl):

  • platform/graphics/chromium/CanvasLayerChromium.h:

(CanvasLayerChromium):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::createCCLayerImpl):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):

  • platform/graphics/chromium/PluginLayerChromium.cpp:

(WebCore::PluginLayerChromium::createCCLayerImpl):

  • platform/graphics/chromium/PluginLayerChromium.h:

(PluginLayerChromium):

  • platform/graphics/chromium/SolidColorLayerChromium.cpp:

(WebCore::SolidColorLayerChromium::createCCLayerImpl):

  • platform/graphics/chromium/SolidColorLayerChromium.h:

(SolidColorLayerChromium):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::createCCLayerImpl):

  • platform/graphics/chromium/TiledLayerChromium.h:

(TiledLayerChromium):

  • platform/graphics/chromium/TreeSynchronizer.cpp:

(WebCore::TreeSynchronizer::synchronizeTrees):
(WebCore::TreeSynchronizer::collectExistingCCLayerImplRecursive):
(WebCore):
(WebCore::TreeSynchronizer::reuseOrCreateCCLayerImpl):
(WebCore::TreeSynchronizer::synchronizeTreeRecursive):

  • platform/graphics/chromium/TreeSynchronizer.h:

(TreeSynchronizer):

  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::createCCLayerImpl):

  • platform/graphics/chromium/VideoLayerChromium.h:

(VideoLayerChromium):

  • platform/graphics/chromium/cc/CCCanvasLayerImpl.h:

(WebCore::CCCanvasLayerImpl::create):

  • platform/graphics/chromium/cc/CCDamageTracker.cpp:

(WebCore::CCDamageTracker::updateDamageTrackingState):
(WebCore::CCDamageTracker::trackDamageFromActiveLayers):

  • platform/graphics/chromium/cc/CCDamageTracker.h:

(CCDamageTracker):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::addChild):
(WebCore::sortLayers):
(WebCore::CCLayerImpl::setMaskLayer):
(WebCore::CCLayerImpl::setReplicaLayer):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::create):
(WebCore::CCLayerImpl::children):
(CCLayerImpl):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerIterator.cpp:

(WebCore):
(WebCore::CCLayerIteratorActions::BackToFront::begin):
(WebCore::CCLayerIteratorActions::BackToFront::end):
(WebCore::CCLayerIteratorActions::BackToFront::next):
(WebCore::CCLayerIteratorActions::FrontToBack::begin):
(WebCore::CCLayerIteratorActions::FrontToBack::end):
(WebCore::CCLayerIteratorActions::FrontToBack::next):
(WebCore::CCLayerIteratorActions::FrontToBack::goToHighestInSubtree):

  • platform/graphics/chromium/cc/CCLayerIterator.h:

(WebCore):
(CCLayerIterator):
(WebCore::CCLayerIterator::begin):
(WebCore::CCLayerIterator::end):
(WebCore::CCLayerIterator::targetRenderSurfaceLayer):
(WebCore::CCLayerIterator::CCLayerIterator):
(WebCore::CCLayerIterator::getRawPtr):
(WebCore::CCLayerIterator::currentLayer):
(WebCore::CCLayerIterator::targetRenderSurfaceChildren):
(BackToFront):
(FrontToBack):

  • platform/graphics/chromium/cc/CCLayerSorter.cpp:

(WebCore::CCLayerSorter::createGraphNodes):

  • platform/graphics/chromium/cc/CCLayerSorter.h:

(CCLayerSorter):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):
(WebCore::CCLayerTreeHost::reserveTextures):
(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore):
(WebCore::calculateDrawTransformsAndVisibilityInternal):
(WebCore::walkLayersAndCalculateVisibleLayerRects):
(WebCore::CCLayerTreeHostCommon::calculateDrawTransformsAndVisibility):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:

(CCLayerTreeHostCommon):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::trackDamageForAllSurfaces):
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::drawLayers):
(WebCore::CCLayerTreeHostImpl::setRootLayer):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::releaseRootLayer):
(WebCore::CCLayerTreeHostImpl::scrollLayer):

  • platform/graphics/chromium/cc/CCPluginLayerImpl.h:

(WebCore::CCPluginLayerImpl::create):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore::CCRenderSurface::layerList):
(CCRenderSurface):

  • platform/graphics/chromium/cc/CCSolidColorLayerImpl.h:

(WebCore::CCSolidColorLayerImpl::create):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:

(WebCore::CCTiledLayerImpl::create):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:

(WebCore::CCVideoLayerImpl::create):

Source/WebKit/chromium:

  • tests/CCDamageTrackerTest.cpp:

(WebKitTests::executeCalculateDrawTransformsAndVisibility):
(WebKitTests::emulateDrawingOneFrame):
(WebKitTests::createTestTreeWithOneSurface):
(WebKitTests::createTestTreeWithTwoSurfaces):
(WebKitTests::createAndSetUpTestTreeWithOneSurface):
(WebKitTests::createAndSetUpTestTreeWithTwoSurfaces):
(WebKitTests::TEST_F):

  • tests/CCLayerImplTest.cpp:

(WebCore::TEST):

  • tests/CCLayerIteratorTest.cpp:
  • tests/CCLayerSorterTest.cpp:

(WebCore::TEST):

  • tests/CCLayerTreeHostCommonTest.cpp:

(WebCore::TEST):

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::CCLayerTreeHostImplTest::setupScrollAndContentsLayers):
(WebKit::TEST_F):
(WebKit::DidDrawCheckLayer::create):
(WebKit::BlendStateCheckLayer::create):

  • tests/CCRenderSurfaceTest.cpp:

(WebCore::TEST):

  • tests/CCSolidColorLayerImplTest.cpp:

(CCLayerTestCommon::TEST):

  • tests/CCTiledLayerImplTest.cpp:

(CCLayerTestCommon::createLayer):
(CCLayerTestCommon::TEST):
(CCLayerTestCommon::getQuads):

  • tests/Canvas2DLayerChromiumTest.cpp:

(WebCore::Canvas2DLayerChromiumTest::fullLifecycleTest):

  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):

  • tests/TreeSynchronizerTest.cpp:

(WebKitTests::MockCCLayerImpl::create):
(WebKitTests::MockLayerChromium::createCCLayerImpl):
(WebKitTests::expectTreesAreIdentical):
(WebKitTests::TEST):

19:27 Changeset [108885] by kling@webkit.org

Don't pass constant strings to CSSParser for presentation attributes.
<http://webkit.org/b/79530>

Reviewed by Anders Carlsson.

"both" -> CSSValueBoth.
"center" -> CSSValueCenter.

  • html/HTMLBRElement.cpp:

(WebCore::HTMLBRElement::collectStyleForAttribute):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::collectStyleForAttribute):

18:57 Changeset [108884] by enne@google.com

Unreviewed, rename mispelled expectation files.
https://bugs.webkit.org/show_bug.cgi?id=79457

WebKit is no abode for poor spelling.

  • fast/images/rgb-jpeg-with-adobe-marker-only-expected.txt: Renamed from LayoutTests/fast/images/rgb-jpeg-with-abode-marker-only-expected.txt.
  • fast/images/rgb-jpeg-with-adobe-marker-only.html: Renamed from LayoutTests/fast/images/rgb-jpeg-with-abode-marker-only.html.
  • platform/chromium-mac-snowleopard/fast/images/rgb-jpeg-with-adobe-marker-only-expected.png: Renamed from LayoutTests/platform/chromium-mac-snowleopard/fast/images/rgb-jpeg-with-abode-marker-only-expected.png.
  • platform/chromium-mac-snowleopard/fast/images/rgb-jpeg-with-adobe-marker-only-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/fast/images/rgb-jpeg-with-abode-marker-only-expected.txt.
  • platform/mac-snowleopard/fast/images/rgb-jpeg-with-adobe-marker-only-expected.png: Renamed from LayoutTests/platform/mac-snowleopard/fast/images/rgb-jpeg-with-abode-marker-only-expected.png.
18:55 Changeset [108883] by jamesr@google.com

[chromium] Make WebViewImpl depend on WebLayerTreeView instead of CCLayerTreeHost
https://bugs.webkit.org/show_bug.cgi?id=75591

Reviewed by Kenneth Russell.

This converts WebViewImpl from depending on CCLayerTreeHost to WebLayerTreeView in order to provide better
isolation and allow for future refactorings. The changes to WebViewImpl are mostly mechanical. The
WebLayerTreeView and WebLayerTreeViewClient interfaces have both grown and changed slightly:

  • Setup path for WebLayerTreeView changed to expose an initialize() function instead of a create() factory

function. The new model is that a WebLayerTreeView when constructed is in a null state. Calling initialize()
attempts to re-initialize the WLTV, which can either fail or succeed. All other functions must be called on a
successfully initialized view.

  • WebLayerTreeView expanded to include functionality that CCLayerTreeHost exposes but WebLayerTreeView did not.

Some of this is only valid for the single thread case and will be removed when we invert the scheduling control
logic, these bits are commented.

  • WebLayerTreeViewClient expanded with some flow-control related APIs.

Refactor only, no change in behavior.

  • public/platform/WebLayerTreeView.h:

(WebKit::WebLayerTreeView::Settings::Settings):
(WebKit::WebLayerTreeView::isNull):

  • public/platform/WebLayerTreeViewClient.h:
  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::scheduleCompositingLayerSync):

  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::initialize):
(WebKit::WebLayerTreeView::compositorIdentifier):
(WebKit::WebLayerTreeView::setVisible):
(WebKit::WebLayerTreeView::setNeedsAnimate):
(WebKit::WebLayerTreeView::updateAnimations):
(WebKit::WebLayerTreeView::setNeedsRedraw):
(WebKit::WebLayerTreeView::setPageScaleFactorAndLimits):
(WebKit::WebLayerTreeView::startPageScaleAnimation):
(WebKit::WebLayerTreeView::finishAllRendering):
(WebKit::WebLayerTreeView::context):
(WebKit::WebLayerTreeView::loseCompositorContext):

  • src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::didRecreateGraphicsContext):
(WebKit::WebLayerTreeViewImpl::didCommitAndDrawFrame):
(WebKit::WebLayerTreeViewImpl::didCompleteSwapBuffers):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::animate):
(WebKit::WebViewImpl::doPixelReadbackToCanvas):
(WebKit::WebViewImpl::paint):
(WebKit::WebViewImpl::composite):
(WebKit::WebViewImpl::loseCompositorContext):
(WebKit::WebViewImpl::computePageScaleFactorLimits):
(WebKit::WebViewImpl::addPageOverlay):
(WebKit::WebViewImpl::removePageOverlay):
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::scheduleCompositingLayerSync):
(WebKit::WebViewImpl::scrollRootLayerRect):
(WebKit::WebViewImpl::invalidateRootLayerRect):
(WebKit::WebViewImpl::scheduleAnimation):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::createContext3D):
(WebKit::WebViewImpl::applyScrollAndScale):
(WebKit::WebViewImpl::didRebindGraphicsContext):
(WebKit::WebViewImpl::updateLayerTreeViewport):
(WebKit::WebViewImpl::graphicsContext3D):
(WebKit::WebViewImpl::setVisibilityState):

  • src/WebViewImpl.h:
  • tests/WebLayerTest.cpp:
18:41 Changeset [108882] by yael.aharon@nokia.com

[Texmap] Add const-ness to TextureMapperShaderManager
https://bugs.webkit.org/show_bug.cgi?id=79545

Reviewed by Noam Rosenthal.

Add const to new methods.
No new tests.

  • platform/graphics/texmap/TextureMapperShaderManager.cpp:

(WebCore::TextureMapperShaderProgramSimple::vertexShaderSource):
(WebCore::TextureMapperShaderProgramSimple::fragmentShaderSource):
(WebCore::TextureMapperShaderProgramOpacityAndMask::vertexShaderSource):
(WebCore::TextureMapperShaderProgramOpacityAndMask::fragmentShaderSource):

  • platform/graphics/texmap/TextureMapperShaderManager.h:

(WebCore::TextureMapperShaderProgram::matrixVariable):
(WebCore::TextureMapperShaderProgram::sourceMatrixVariable):
(WebCore::TextureMapperShaderProgram::sourceTextureVariable):
(WebCore::TextureMapperShaderProgram::opacityVariable):
(TextureMapperShaderProgram):
(TextureMapperShaderProgramSimple):
(WebCore::TextureMapperShaderProgramOpacityAndMask::maskMatrixVariable):
(WebCore::TextureMapperShaderProgramOpacityAndMask::maskTextureVariable):
(TextureMapperShaderProgramOpacityAndMask):

18:39 Changeset [108881] by tsepez@chromium.org

XSS Auditor targeting legitimate frames as false positives.
https://bugs.webkit.org/show_bug.cgi?id=79397

Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/xssAuditor/script-tag-safe4.html

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::filterCharacterToken):
(WebCore::XSSAuditor::filterScriptToken):
(WebCore::XSSAuditor::filterObjectToken):
(WebCore::XSSAuditor::filterEmbedToken):
(WebCore::XSSAuditor::filterAppletToken):
(WebCore::XSSAuditor::filterIframeToken):
(WebCore::XSSAuditor::decodedSnippetForToken):
(WebCore):
(WebCore::XSSAuditor::decodedSnippetForName):
(WebCore::XSSAuditor::decodedSnippetForAttribute):
(WebCore::XSSAuditor::decodedSnippetForJavascript):
(WebCore::XSSAuditor::isContainedInRequest):
(WebCore::XSSAuditor::isSameOriginResource):

  • html/parser/XSSAuditor.h:

LayoutTests:

  • http/tests/security/xssAuditor/resources/script-tag-safe4-frame.html: Added.
  • http/tests/security/xssAuditor/script-tag-safe4-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-safe4.html: Added.
18:19 Changeset [108880] by commit-queue@webkit.org

[chromium] Plumb animation started notifications from CCLayerTreeHost to GraphicsLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=77646

Patch by Ian Vollick <vollick@chromium.org> on 2012-02-24
Reviewed by James Robinson.

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(std):
(WebCore::GraphicsLayerChromium::~GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::addAnimation):
(WebCore::GraphicsLayerChromium::pauseAnimation):
(WebCore::GraphicsLayerChromium::removeAnimation):
(WebCore::GraphicsLayerChromium::suspendAnimations):
(WebCore::GraphicsLayerChromium::resumeAnimations):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore::GraphicsLayerChromium::mapAnimationNameToId):
(WebCore):
(WebCore::GraphicsLayerChromium::notifyAnimationStarted):
(WebCore::GraphicsLayerChromium::notifyAnimationFinished):

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(GraphicsLayerChromium):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setAnimationEvent):
(WebCore):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore):
(LayerChromium):
(WebCore::LayerChromium::setLayerAnimationDelegate):

  • platform/graphics/chromium/cc/CCAnimationEvents.cpp: Added.

(WebCore):
(WebCore::CCAnimationEvent::CCAnimationEvent):
(WebCore::CCAnimationEvent::~CCAnimationEvent):
(WebCore::CCAnimationEvent::toAnimationStartedEvent):
(WebCore::CCAnimationEvent::toAnimationFinishedEvent):
(WebCore::CCAnimationStartedEvent::create):
(WebCore::CCAnimationStartedEvent::CCAnimationStartedEvent):
(WebCore::CCAnimationStartedEvent::~CCAnimationStartedEvent):
(WebCore::CCAnimationStartedEvent::type):
(WebCore::CCAnimationFinishedEvent::create):
(WebCore::CCAnimationFinishedEvent::CCAnimationFinishedEvent):
(WebCore::CCAnimationFinishedEvent::~CCAnimationFinishedEvent):
(WebCore::CCAnimationFinishedEvent::type):

  • platform/graphics/chromium/cc/CCAnimationEvents.h:

(WebCore):
(CCAnimationEvent):
(WebCore::CCAnimationEvent::layerId):
(CCAnimationStartedEvent):
(WebCore::CCAnimationStartedEvent::startTime):
(CCAnimationFinishedEvent):
(WebCore::CCAnimationFinishedEvent::animationId):

  • platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.cpp:

(WebCore::CCLayerAnimationControllerImpl::animate):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForNextTick):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForStartTime):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForTargetAvailability):
(WebCore::CCLayerAnimationControllerImpl::purgeFinishedAnimations):
(WebCore::CCLayerAnimationControllerImpl::tickAnimations):

  • platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.h:

(CCLayerAnimationControllerImpl):

  • platform/graphics/chromium/cc/CCLayerAnimationDelegate.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCAnimationEvents.h.

(WebCore):
(CCLayerAnimationDelegate):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::setAnimationEvents):
(WebCore::CCLayerTreeHost::setAnimationEventsRecursive):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(TestHooks):
(WTF::TestHooks::notifyAnimationStarted):
(WTF::TestHooks::notifyAnimationFinished):
(WTF::MockLayerTreeHost::create):
(WTF::CCLayerTreeHostTestAddAnimation::CCLayerTreeHostTestAddAnimation):
(WTF::CCLayerTreeHostTestAddAnimation::animateLayers):
(WTF::CCLayerTreeHostTestAddAnimation::notifyAnimationStarted):
(CCLayerTreeHostTestAddAnimation):
(WTF::CCLayerTreeHostTestAddAnimation::notifyAnimationFinished):

18:19 Changeset [108879] by darin@chromium.org

Add watchlist for ChromiumPlatformApi matching Source/Platform/chromium/public/

Reviewed by James Robinson.

  • Scripts/webkitpy/common/config/watchlist:
18:01 Changeset [108878] by inferno@chromium.org

Regression(r107477): Crash in StaticNodeList::itemWithName.
https://bugs.webkit.org/show_bug.cgi?id=79532

Reviewed by Andreas Kling.

Source/WebCore:

Make sure that node is an element node before checking its id attribute.

Test: fast/mutation/mutation-callback-non-element-crash.html

  • dom/StaticNodeList.cpp:

(WebCore::StaticNodeList::itemWithName):

LayoutTests:

  • fast/mutation/mutation-callback-non-element-crash-expected.txt: Added.
  • fast/mutation/mutation-callback-non-element-crash.html: Added.
17:56 Changeset [108877] by jamesr@google.com

[chromium] WebKit::setColorNames is a client API
https://bugs.webkit.org/show_bug.cgi?id=79539

Reviewed by Darin Fisher.

Source/Platform:

  • Platform.gypi:
  • chromium/public/WebColor.h:

(WebKit):

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebColorName.h: Renamed from Source/Platform/chromium/public/WebColorName.h.

(WebKit):

  • public/platform/WebColorName.h:
  • src/WebColor.cpp:
17:46 Changeset [108876] by tony@chromium.org

More refactoring in RenderFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=79533

Reviewed by Ojan Vafai.

No new tests, just refactoring.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutFlexItems): Move the flipping of RTL+column positions to its own method.
This might be a tiny bit slower, but it's clearer since it's not related to alignment.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Move the logical height calculation out of the loop. We only need the final height.
(WebCore::RenderFlexibleBox::alignChildren):
(WebCore::RenderFlexibleBox::flipForRightToLeftColumn):

  • rendering/RenderFlexibleBox.h:

(RenderFlexibleBox):

17:31 Changeset [108875] by inferno@chromium.org

Positioned objects not cleared when moving children
to clone block in multi-column layout.
https://bugs.webkit.org/show_bug.cgi?id=78416

Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/multicol/span/positioned-child-not-removed-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::splitBlocks):

LayoutTests:

  • fast/multicol/span/positioned-child-not-removed-crash-expected.txt: Added.
  • fast/multicol/span/positioned-child-not-removed-crash.html: Added.
17:11 Changeset [108874] by msaboff@apple.com

Unreviewed, Windows build fix. Changed "-1" to newly
created constant JSC::Yarr::offsetNoMatch added in r108858.

  • platform/text/RegularExpression.cpp: (WebCore::RegularExpression::match):
17:10 Changeset [108873] by tomz@codeaurora.org

team.html (on webkit.org) doesn't recognize codeaurora.org
https://bugs.webkit.org/show_bug.cgi?id=79529

Reviewed by Ryosuke Niwa.

  • team.html:
16:58 Changeset [108872] by eric.carlson@apple.com

Update TextTrackCue API
https://bugs.webkit.org/show_bug.cgi?id=79368

Source/WebCore:

Change TextTrackCue.alignment to .align, TextTrackCue.linePosition and .textPosition to .line
and .position, and TextTrackCue.direction to .vertical. Change direction values "horizontal"
to "","vertical" to "rl", and "vertical-lr" to "lr".

Reviewed by Eric Seidel.

No new tests, updated existing tests for API changes.

  • html/track/TextTrackCue.cpp:

(WebCore::horizontalKeyword):
(WebCore::verticalGrowingLeftKeyword):
(WebCore):
(WebCore::verticalGrowingRightKeyword):
(WebCore::verticalKeywordOLD):
(WebCore::verticallrKeywordOLD):
(WebCore::TextTrackCue::TextTrackCue):
(WebCore::TextTrackCue::vertical):
(WebCore::TextTrackCue::setVertical):
(WebCore::TextTrackCue::setLine):
(WebCore::TextTrackCue::setPosition):
(WebCore::TextTrackCue::align):
(WebCore::TextTrackCue::setAlign):
(WebCore::TextTrackCue::parseSettings):

  • html/track/TextTrackCue.h:

(TextTrackCue):
(WebCore::TextTrackCue::line):
(WebCore::TextTrackCue::position):

  • html/track/TextTrackCue.idl:

LayoutTests:

Reviewed by Eric Seidel.

  • media/track/track-add-remove-cue-expected.txt:
  • media/track/track-add-remove-cue.html:
  • media/track/track-cue-mutable-expected.txt:
  • media/track/track-cue-mutable.html:
  • media/track/track-webvtt-tc013-settings-expected.txt:
  • media/track/track-webvtt-tc013-settings.html:
  • media/track/track-webvtt-tc014-alignment-expected.txt:
  • media/track/track-webvtt-tc014-alignment.html:
  • media/track/track-webvtt-tc015-positioning-expected.txt:
  • media/track/track-webvtt-tc015-positioning.html:
  • media/track/track-webvtt-tc016-align-positioning-expected.txt:
  • media/track/track-webvtt-tc016-align-positioning.html:
  • media/track/track-webvtt-tc017-line-position-expected.txt:
  • media/track/track-webvtt-tc017-line-position.html:
  • media/track/track-webvtt-tc018-align-text-line-position-expected.txt:
  • media/track/track-webvtt-tc018-align-text-line-position.html:
  • media/track/track-webvtt-tc020-cue-size-align-expected.txt:
  • media/track/track-webvtt-tc020-cue-size-align.html:
  • media/track/track-webvtt-tc021-valign-expected.txt:
  • media/track/track-webvtt-tc021-valign.html:
  • platform/mac/Skipped:
16:54 Changeset [108871] by enne@google.com

Fix uninitialized variables in HarfBuzzShaperBase
https://bugs.webkit.org/show_bug.cgi?id=79546

Reviewed by Dirk Pranke.

These were introduced in r108733.

  • platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp:

(WebCore::HarfBuzzShaperBase::HarfBuzzShaperBase):

16:49 Changeset [108870] by noel.gordon@gmail.com

[chromium] JPEG RGB image with Adode Marker fails to turbo swizzle decode
https://bugs.webkit.org/show_bug.cgi?id=79457

Reviewed by Adam Barth.

Source/WebCore:

If a JPEG has no JFIF marker, the Adode Marker must be used to determine the image
color space for decoding via that markers transform value. Transform 0 images with
3 color components (RGB) fail to decode with libjpeg-turbo when a swizzle decoding
is active. Detect this case and decode using JCS_RGB output color space instead.

Test: fast/images/rgb-jpeg-with-abode-marker-only.html

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageReader::decode):

LayoutTests:

  • fast/images/resources/rgb-jpeg-with-adobe-marker-only.jpg: Added.
  • fast/images/rgb-jpeg-with-abode-marker-only-expected.txt: Added.
  • fast/images/rgb-jpeg-with-abode-marker-only.html: Added.
  • platform/chromium-mac-snowleopard/fast/images/rgb-jpeg-with-abode-marker-only-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/images/rgb-jpeg-with-abode-marker-only-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac-snowleopard/fast/images/rgb-jpeg-with-abode-marker-only-expected.png: Added.
16:45 Changeset [108869] by msaboff@apple.com

Unreviewed, Windows build fix. Changed signature in export to match
change made in r108858.

16:30 Changeset [108868] by dpranke@chromium.org

webkitpy: changelog_unittest test_fuzzy_reviewer_match is slow
https://bugs.webkit.org/show_bug.cgi?id=79258

Reviewed by Ryosuke Niwa.

Split the fuzzy matching into separate functions so that they
can be sharded and run in parallel.

Also, fix a bug in the svn_blame_regexp that was causing us
to require ChangeLog lines to have at least one space after the
author, making the code require trailing whitespace in the
changelog in some places (this was making my life harder because
I have my text editor set to strip trailing whitespace in python
files, and that was causing test_parse_log_entries_from_changelog() to fail
when the whitespace on line 275 was removed).

  • Scripts/webkitpy/common/checkout/changelog.py:

(ChangeLog):

  • Scripts/webkitpy/common/checkout/changelog_unittest.py:

(test_fuzzy_reviewer_matchnone):
(test_fuzzy_reviewer_match_adam_barth):
(test_fuzzy_reviewer_match_darin_adler_et_al):
(test_fuzzy_reviewer_match_dimitri_glazkov):
(test_fuzzy_reviewer_match_george_staikos):
(test_fuzzy_reviewer_match_mark_rowe):

16:26 Changeset [108867] by jsbell@chromium.org

[V8] IndexedDB: IDBTransaction objects leak in Workers
https://bugs.webkit.org/show_bug.cgi?id=79308

Source/WebCore:

Use a V8RecursionScope whenever Workers call into script, so that
post-script side-effects can be executed.

Reviewed by Tony Chang.

Test: storage/indexeddb/transaction-abort-workers.html

  • bindings/v8/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute):

  • bindings/v8/V8WorkerContextErrorHandler.cpp:

(WebCore::V8WorkerContextErrorHandler::callListenerFunction):

  • bindings/v8/V8WorkerContextEventListener.cpp:

(WebCore::V8WorkerContextEventListener::callListenerFunction):

  • bindings/v8/WorkerContextExecutionProxy.cpp: Replace custom recursion tracking.

(WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
(WebCore::WorkerContextExecutionProxy::runScript):

  • bindings/v8/WorkerContextExecutionProxy.h:

(WorkerContextExecutionProxy):

LayoutTests:

Reviewed by Tony Chang.

  • fast/js/resources/js-test-pre.js:

(startWorker): Return Worker object so onerror can be hooked.

  • storage/indexeddb/resources/transaction-abort-workers.js: Added.
  • storage/indexeddb/transaction-abort-workers-expected.txt: Added.
  • storage/indexeddb/transaction-abort-workers.html: Added.
16:23 Changeset [108866] by fpizlo@apple.com

DFG support for op_new_regexp should be enabled
https://bugs.webkit.org/show_bug.cgi?id=79538

Reviewed by Oliver Hunt.

No performance change.

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

  • dfg/DFGCommon.h:
16:22 Changeset [108865] by enne@google.com

Unreviewed, rolling out r108860.
http://trac.webkit.org/changeset/108860
https://bugs.webkit.org/show_bug.cgi?id=79544

"Breaks Linux compile" (Requested by enne on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-24

Source/Platform:

  • Platform.gypi:
  • chromium/public/WebColor.h:

(WebKit):

  • chromium/public/WebColorName.h: Renamed from Source/WebKit/chromium/public/WebColorName.h.

(WebKit):

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/platform/WebColorName.h:
  • src/WebColor.cpp: Renamed from Source/WebKit/chromium/src/WebColorName.cpp.

(WebKit):
(WebKit::toCSSValueKeyword):
(WebKit::setNamedColors):

16:19 Changeset [108864] by dpranke@chromium.org

webkitpy: committers_unittest fuzzy matching is really slow
https://bugs.webkit.org/show_bug.cgi?id=79179

Reviewed by Ryosuke Niwa.

Break the fuzzy matching tests into individual routines for
each contributor so that the intent is a little clearer, so
that it's easier to test individual names (and identify
duplicate tests), and so that we can eventually run
them in parallel.

Also, mark most of them as 'integration' tests so that they
can be skipped if we want to go fast (we leave a few as
regular tests for functional coverage).

  • Scripts/webkitpy/common/config/committers_unittest.py:

(CommittersTest):
(CommittersTest.test_contributors_by_fuzzy_match):
(CommittersTest.integration_test_contributorsnone):
(CommittersTest.integration_test_contributors
none_2):
(CommittersTest.integration_test_contributorsnone_3):
(CommittersTest.integration_test_contributors_ada_chan):
(CommittersTest.integration_test_contributors_adele_peterson):
(CommittersTest.integration_test_contributors_alexey_proskuryakov):
(CommittersTest.integration_test_contributors_alice_liu):
(CommittersTest.integration_test_contributors_alp_toker):
(CommittersTest.integration_test_contributors_anders_carlsson):
(CommittersTest.integration_test_contributors_antti_koivisto):
(CommittersTest.integration_test_contributors_beth_dakin):
(CommittersTest.integration_test_contributors_brady_eidson):
(CommittersTest.integration_test_contributors_cameron_zwarich):
(CommittersTest.integration_test_contributors_chris_blumenberg):
(CommittersTest.integration_test_contributors_dan_bernstein):
(CommittersTest.integration_test_contributors_dan_bernstein_2):
(CommittersTest.integration_test_contributors_darin_adler):
(CommittersTest.integration_test_contributors_david_harrison):
(CommittersTest.integration_test_contributors_david_harrison_2):
(CommittersTest.integration_test_contributors_david_hyatt):
(CommittersTest.integration_test_contributors_david_kilzer):
(CommittersTest.integration_test_contributors_don_melton):
(CommittersTest.integration_test_contributors_eric_seidel):
(CommittersTest.integration_test_contributors_geoffrey_garen):
(CommittersTest.integration_test_contributors_greg_bolsinga):
(CommittersTest.integration_test_contributors_holger_freyther):
(CommittersTest.integration_test_contributors_jon_sullivan):
(CommittersTest.integration_test_contributors_jon_honeycutt):
(CommittersTest.integration_test_contributors_joseph_pecoraro):
(CommittersTest.integration_test_contributors_ken_kocienda):
(CommittersTest.integration_test_contributors_kenneth_russell):
(CommittersTest.integration_test_contributors_kevin_decker):
(CommittersTest.integration_test_contributors_kevin_mccullough):
(CommittersTest.integration_test_contributors_lars_knoll):
(CommittersTest.integration_test_contributors_lars_weintraub):
(CommittersTest.integration_test_contributors_maciej_stachowiak):
(CommittersTest.integration_test_contributors_mark_rowe):
(CommittersTest.integration_test_contributors_nikolas_zimmermann):
(CommittersTest.integration_test_contributors_oliver_hunt):
(CommittersTest.integration_test_contributors_rniwa):
(CommittersTest.disabled_integration_test_contributors_simon_fraser):
(CommittersTest.integration_test_contributors_steve_falkenburg):
(CommittersTest.integration_test_contributors_sam_weinig):
(CommittersTest.integration_test_contributors_tim_omernick):
(CommittersTest.integration_test_contributors_timothy_hatcher):
(CommittersTest.integration_test_contributors_tor_arne_vestbo):
(CommittersTest.integration_test_contributors_vicki_murley):
(CommittersTest.integration_test_contributors_zack_rusin):

16:17 Changeset [108863] by jamesr@google.com

Merge 106603 - BMW Car Configuration Page doesn't work (Only manifests in Chromium)
https://bugs.webkit.org/show_bug.cgi?id=77312

Reviewed by Dimitri Glazkov.

When we autogenerated the event factory, we missed the check for
whether touch events were enabled at runtime:
http://trac.webkit.org/changeset/97933/trunk/Source/WebCore/dom/Document.cpp

This patch adds the check back.

Unfortunately, there isn't a testing frame work for
RuntimeEnabledFeatures. The main difficulty is that these static bools
need to be set when WebKit is initialized and can't be changed (which
is why they're not part of WebCore::Settings). To test them properly,
we'd need a testing framework that booted up WebKit for each test.

We could test this particular change (which doesn't need the bool to be
constant through the runtime of WebKit), but that would create a
sandtrap for future patches who might thing that this testing framework
can really be used to test RuntimeEnabledFeatures.

The net result is that Chromium is going to end up living with the
non-default codepath for these settings being untested, which will lead
to regressions like this one. If we ened up with a bunch of these
regressions, we'll likely end up with a testing framework similar to
Chromium's browsers_tests, which create a fresh subprocess for each
test.

  • dom/EventFactory.in:
  • dom/make_event_factory.pl:

(defaultItemFactory):
(generateImplementation):

TBR=abarth@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9467023

16:12 Changeset [108862] by dpranke@chromium.org

webkitpy: should autoinstall coverage
https://bugs.webkit.org/show_bug.cgi?id=79535

Reviewed by Eric Seidel.

We should automatically print the coverage report after the run, too.

  • Scripts/webkitpy/test/main.py:

(Tester._run_tests):

  • Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook.find_module):
(AutoinstallImportHook._install_coverage):

16:03 Changeset [108861] by commit-queue@webkit.org

Limit WebGL Errors in Console to 10 per context
https://bugs.webkit.org/show_bug.cgi?id=79387

Patch by Gregg Tavares <gman@google.com> on 2012-02-24
Reviewed by Kenneth Russell.

Some apps generated enough errors to overload
the Dev Tools so limit the number of errors.
For a correct app there should never be any
errors so seeing the first few should be enough
to debug.

No new tests as no new functionality

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContextErrorMessageCallback::onErrorMessage):
(WebCore::WebGLRenderingContext::WebGLRenderingContext):
(WebCore::WebGLRenderingContext::initializeNewContext):
(WebCore::WebGLRenderingContext::printGLErrorToConsole):
(WebCore::WebGLRenderingContext::synthesizeGLError):

  • html/canvas/WebGLRenderingContext.h:

(WebGLRenderingContext):

15:57 Changeset [108860] by jamesr@google.com

[chromium] WebKit::setColorNames is a client API
https://bugs.webkit.org/show_bug.cgi?id=79539

Reviewed by Darin Fisher.

Source/Platform:

  • Platform.gypi:
  • chromium/public/WebColor.h:

(WebKit):

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebColorName.h: Renamed from Source/Platform/chromium/public/WebColorName.h.

(WebKit):

  • public/platform/WebColorName.h:
  • src/WebColor.cpp:
15:57 Changeset [108859] by enne@google.com

[chromium] Unreviewed, mark fast/files/workers tests as flaky crashers
https://bugs.webkit.org/show_bug.cgi?id=79540

  • platform/chromium/test_expectations.txt:
15:55 Changeset [108858] by msaboff@apple.com

ASSERT(position < 0) in JSC::Yarr::Interpreter::InputStream::readChecked
https://bugs.webkit.org/show_bug.cgi?id=73728

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Fixed the mixing of signed and unsigned character indeces in YARR
interpreter.

  • runtime/RegExp.cpp:

(JSC::RegExp::match): Added code to check for match longer than 231 and
return no match after resetting the offsets.

  • yarr/YarrInterpreter.cpp: Changed to use unsigned for all character index

handling except when matching back references.
(JSC::Yarr::Interpreter::InputStream::readChecked):
(JSC::Yarr::Interpreter::InputStream::checkInput):
(JSC::Yarr::Interpreter::InputStream::uncheckInput):
(JSC::Yarr::Interpreter::InputStream::atStart):
(JSC::Yarr::Interpreter::InputStream::atEnd):
(JSC::Yarr::Interpreter::InputStream::isAvailableInput):
(JSC::Yarr::Interpreter::checkCharacter):
(JSC::Yarr::Interpreter::checkCasedCharacter):
(JSC::Yarr::Interpreter::checkCharacterClass):
(JSC::Yarr::Interpreter::tryConsumeBackReference):
(JSC::Yarr::Interpreter::matchAssertionBOL):
(JSC::Yarr::Interpreter::matchAssertionWordBoundary):
(JSC::Yarr::Interpreter::backtrackPatternCharacter):
(JSC::Yarr::Interpreter::backtrackPatternCasedCharacter):
(JSC::Yarr::Interpreter::matchCharacterClass):
(JSC::Yarr::Interpreter::backtrackCharacterClass):
(JSC::Yarr::Interpreter::matchParenthesesOnceBegin):
(JSC::Yarr::Interpreter::matchDisjunction):
(JSC::Yarr::Interpreter::interpret):
(JSC::Yarr::ByteCompiler::assertionBOL):
(JSC::Yarr::ByteCompiler::assertionEOL):
(JSC::Yarr::ByteCompiler::assertionWordBoundary):
(JSC::Yarr::ByteCompiler::atomPatternCharacter):
(JSC::Yarr::ByteCompiler::atomCharacterClass):
(JSC::Yarr::ByteCompiler::atomBackReference):
(JSC::Yarr::ByteCompiler::atomParenthesesOnceBegin):
(JSC::Yarr::ByteCompiler::atomParenthesesTerminalBegin):
(JSC::Yarr::ByteCompiler::atomParenthesesSubpatternBegin):
(JSC::Yarr::ByteCompiler::atomParentheticalAssertionEnd):
(JSC::Yarr::ByteCompiler::emitDisjunction):

  • yarr/YarrInterpreter.h:

Source/WebCore:

No new tests, refactored usage of JSC::Yarr interpreter.
Should be covered by existing tests.

Changed WebCore callers of JSC::Yarr:Interpreter::interpret() to match the
new signature with unsigned offsets.

  • inspector/ContentSearchUtils.cpp:

(WebCore::ContentSearchUtils::findMagicComment):

  • platform/text/RegularExpression.cpp:

(WebCore::RegularExpression::match):

LayoutTests:

Updated test for change. Test is from defect.

  • fast/regex/overflow-expected.txt:
  • fast/regex/script-tests/overflow.js:
15:49 Changeset [108857] by commit-queue@webkit.org

onclick is not reliable for transformed SVG elements
https://bugs.webkit.org/show_bug.cgi?id=34714

Patch by Hans Muller <hmuller@adobe.com> on 2012-02-24
Reviewed by Dirk Schulze.

Source/WebCore:

Use FloatPoints in RenderSVGRoot::nodeAtPoint() when converting the incoming
point to local coordinates.

Test: svg/hittest/svg-small-viewbox.xhtml

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::nodeAtPoint):

LayoutTests:

New svg-small-viewbox test checks that elementFromPoint() works correctly with SVG
elements defined within a 1x1 viewbox.

Revised select-textLength-spacing-squeeze-2.svg to avoid a corner-case,
removed unnecessary -1 adjustment of absEndPos.x from SelectionTestCase.js.

  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-2-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
  • svg/hittest/svg-small-viewbox-expected.txt: Added.
  • svg/hittest/svg-small-viewbox.xhtml: Added.
  • svg/text/resources/SelectionTestCase.js:

(selectRange):

  • svg/text/select-textLength-spacing-squeeze-2.svg:
15:35 Changeset [108856] by fpizlo@apple.com

Unreviewed, build fix for builds where the DFG is disabled but the LLInt is
enabled.

  • llint/LLIntOfflineAsmConfig.h:
  • llint/LowLevelInterpreter.asm:
15:24 Changeset [108855] by jchaffraix@webkit.org

Implement limited parsing of -webkit-grid-column and -webkit-grid-row
https://bugs.webkit.org/show_bug.cgi?id=79151

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/css-grid-layout/grid-item-column-row-get-set.html

This change implements a subset of the grammar:

-webkit-grid-{row|column} := <integer> | 'auto'

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Added the new files to our build systems.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForGridPosition): Check that we have the right translated grammar
(this function will be more useful once we implement more of the grammar).
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Added handling for the new properties.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
Allow only 'auto' or <integer>.

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):
grid-colum and grid-row are not inherited.

  • css/CSSPropertyNames.in:

Added the 2 new properties.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleGridItemData.cpp: Added.

(WebCore::StyleGridItemData::StyleGridItemData):

  • rendering/style/StyleGridItemData.h: Added.

(StyleGridItemData):
(WebCore::StyleGridItemData::create):
(WebCore::StyleGridItemData::copy):
(WebCore::StyleGridItemData::operator==):
(WebCore::StyleGridItemData::operator!=):
Implemented the minimum working class.

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

(StyleRareNonInheritedData):
Added StyleGridItemData to the class StyleRareNonInheritedData.

LayoutTests:

  • fast/css-grid-layout/grid-item-column-row-get-set-expected.txt: Added.
  • fast/css-grid-layout/grid-item-column-row-get-set.html: Added.
15:18 Changeset [108854] by enne@google.com

[chromium] Unreviewed gardening. Remove expectations for nonexistent tests.

Make --lint-test-files run clean again for Chromium.

  • platform/chromium/test_expectations.txt:
15:16 WebKitIDL edited by arv@chromium.org
Fix documentation for InterfaceName (diff)
15:03 Changeset [108853] by commit-queue@webkit.org

Fix copypasta in build-webkit's --vibration option description
https://bugs.webkit.org/show_bug.cgi?id=79528

Patch by Pablo Flouret <pablof@motorola.com> on 2012-02-24
Reviewed by Andreas Kling.

  • Scripts/build-webkit:
14:57 WebKitGTK/KeepingTheTreeGreen edited by adamk@chromium.org
(diff)
14:56 Changeset [108852] by jsbell@chromium.org

IndexedDB: IDBObjectStore.count() and IDBIndex.count() should accept key argument
https://bugs.webkit.org/show_bug.cgi?id=79422

Reviewed by Tony Chang.

Source/WebCore:

Tests: storage/indexeddb/index-count.html

storage/indexeddb/objectstore-count.html

  • storage/IDBIndex.cpp:

(WebCore::IDBIndex::count):
(WebCore):

  • storage/IDBIndex.h:

(WebCore::IDBIndex::count):
(IDBIndex):

  • storage/IDBIndex.idl:
  • storage/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::deleteFunction):
(WebCore::IDBObjectStore::count):
(WebCore):

  • storage/IDBObjectStore.h:

(WebCore::IDBObjectStore::count):
(IDBObjectStore):

  • storage/IDBObjectStore.idl:

LayoutTests:

  • storage/indexeddb/index-count-expected.txt:
  • storage/indexeddb/index-count.html:
  • storage/indexeddb/objectstore-count-expected.txt:
  • storage/indexeddb/objectstore-count.html:
14:54 Changeset [108851] by aestes@apple.com

REGRESSION (r108730): Webkit nightlies fails to start due to WKPreferencesGetSuppressIncrementalRendering renaming
https://bugs.webkit.org/show_bug.cgi?id=79515

Reviewed by Alexey Proskuryakov.

Some versions of Safari contain call sites to two functions in WebKit2
that were removed in r108730. Restore these two functions so that these
versions of Safari can be used with WebKit nightly builds.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetSuppressIncrementalRendering):
(WKPreferencesGetSuppressIncrementalRendering):

  • UIProcess/API/C/WKPreferences.h:
14:46 Changeset [108850] by beidson@apple.com

<rdar://problem/10805709> and https://bugs.webkit.org/show_bug.cgi?id=79421
Need a WK1 Mac API to filter which subframes go into WebArchives as they are created

Reviewed by Sam Weinig (with additional comments by Adam Roben)

Add webArchiveByFilteringSubframes: which takes a callback block:

  • DOM/WebDOMOperationsPrivate.h:

Add FrameFilter that adapts the block, and use it to implement the new SPI:

  • DOM/WebDOMOperations.mm:

(WebFrameFilter):
(WebFrameFilter::WebFrameFilter):
(WebFrameFilter::~WebFrameFilter):
(WebFrameFilter::shouldIncludeSubframe):
(-[DOMNode webArchiveByFilteringSubframes:]):

14:39 Changeset [108849] by abarth@webkit.org

Move mediastream into Modules/mediastream
https://bugs.webkit.org/show_bug.cgi?id=79517

Reviewed by Eric Seidel.

This patch moves the mediastream directory into Modules. mediastream
is a self-contained feature and is a good candidate for being a module.

  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • Modules/mediastream: Copied from Source/WebCore/mediastream.
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • mediastream: Removed.
  • mediastream/DOMWindowMediaStream.idl: Removed.
  • mediastream/LocalMediaStream.cpp: Removed.
  • mediastream/LocalMediaStream.h: Removed.
  • mediastream/LocalMediaStream.idl: Removed.
  • mediastream/MediaStream.cpp: Removed.
  • mediastream/MediaStream.h: Removed.
  • mediastream/MediaStream.idl: Removed.
  • mediastream/MediaStreamEvent.cpp: Removed.
  • mediastream/MediaStreamEvent.h: Removed.
  • mediastream/MediaStreamEvent.idl: Removed.
  • mediastream/MediaStreamList.cpp: Removed.
  • mediastream/MediaStreamList.h: Removed.
  • mediastream/MediaStreamList.idl: Removed.
  • mediastream/MediaStreamRegistry.cpp: Removed.
  • mediastream/MediaStreamRegistry.h: Removed.
  • mediastream/MediaStreamTrack.cpp: Removed.
  • mediastream/MediaStreamTrack.h: Removed.
  • mediastream/MediaStreamTrack.idl: Removed.
  • mediastream/MediaStreamTrackList.cpp: Removed.
  • mediastream/MediaStreamTrackList.h: Removed.
  • mediastream/MediaStreamTrackList.idl: Removed.
  • mediastream/NavigatorMediaStream.cpp: Removed.
  • mediastream/NavigatorMediaStream.h: Removed.
  • mediastream/NavigatorMediaStream.idl: Removed.
  • mediastream/NavigatorUserMediaError.h: Removed.
  • mediastream/NavigatorUserMediaError.idl: Removed.
  • mediastream/NavigatorUserMediaErrorCallback.h: Removed.
  • mediastream/NavigatorUserMediaErrorCallback.idl: Removed.
  • mediastream/NavigatorUserMediaSuccessCallback.h: Removed.
  • mediastream/NavigatorUserMediaSuccessCallback.idl: Removed.
  • mediastream/PeerConnection.cpp: Removed.
  • mediastream/PeerConnection.h: Removed.
  • mediastream/PeerConnection.idl: Removed.
  • mediastream/SignalingCallback.h: Removed.
  • mediastream/SignalingCallback.idl: Removed.
  • mediastream/UserMediaClient.h: Removed.
  • mediastream/UserMediaController.cpp: Removed.
  • mediastream/UserMediaController.h: Removed.
  • mediastream/UserMediaRequest.cpp: Removed.
  • mediastream/UserMediaRequest.h: Removed.
14:38 Changeset [108848] by jamesr@google.com

[chromium] Move WebGraphicsContext3D header into the Platform directory
https://bugs.webkit.org/show_bug.cgi?id=79301

Reviewed by Adam Barth.

Moves WebGraphicsContext3D and WebNonCopyable (which WGC3D depends on).

Source/Platform:

  • Platform.gypi:
  • chromium/public/WebGraphicsContext3D.h: Copied from Source/WebKit/chromium/public/platform/WebGraphicsContext3D.h.

(WebKit):
(WebGraphicsContext3D):
(ActiveInfo):
(WebKit::WebGraphicsContext3D::Attributes::Attributes):
(Attributes):
(WebGraphicsContextLostCallback):
(WebKit::WebGraphicsContext3D::WebGraphicsContextLostCallback::~WebGraphicsContextLostCallback):
(WebGraphicsErrorMessageCallback):
(WebKit::WebGraphicsContext3D::WebGraphicsErrorMessageCallback::~WebGraphicsErrorMessageCallback):
(WebGraphicsSwapBuffersCompleteCallbackCHROMIUM):
(WebKit::WebGraphicsContext3D::WebGraphicsSwapBuffersCompleteCallbackCHROMIUM::~WebGraphicsSwapBuffersCompleteCallbackCHROMIUM):
(WebGraphicsMemoryAllocationChangedCallbackCHROMIUM):
(WebKit::WebGraphicsContext3D::WebGraphicsMemoryAllocationChangedCallbackCHROMIUM::~WebGraphicsMemoryAllocationChangedCallbackCHROMIUM):
(WebKit::WebGraphicsContext3D::~WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::setMemoryAllocationChangedCallbackCHROMIUM):
(WebKit::WebGraphicsContext3D::setParentContext):
(WebKit::WebGraphicsContext3D::setSwapBuffersCompleteCallbackCHROMIUM):
(WebKit::WebGraphicsContext3D::rateLimitOffscreenContextCHROMIUM):
(WebKit::WebGraphicsContext3D::setContextLostCallback):
(WebKit::WebGraphicsContext3D::setErrorMessageCallback):
(WebKit::WebGraphicsContext3D::getGraphicsResetStatusARB):
(WebKit::WebGraphicsContext3D::getTranslatedShaderSourceANGLE):
(WebKit::WebGraphicsContext3D::texImageIOSurface2DCHROMIUM):
(WebKit::WebGraphicsContext3D::texStorage2DEXT):
(WebKit::WebGraphicsContext3D::onCreateGrGLInterface):

  • chromium/public/WebNonCopyable.h: Copied from Source/WebKit/chromium/public/platform/WebNonCopyable.h.

(WebKit):
(WebNonCopyable):
(WebKit::WebNonCopyable::WebNonCopyable):
(WebKit::WebNonCopyable::~WebNonCopyable):

Source/WebKit/chromium:

  • public/platform/WebGraphicsContext3D.h:
  • public/platform/WebNonCopyable.h:
14:24 Changeset [108847] by inferno@chromium.org

Overhanging floats not removed from new flex box.
https://bugs.webkit.org/show_bug.cgi?id=79522

Reviewed by Ojan Vafai.

Source/WebCore:

Similar to r69476.

Test: fast/flexbox/overhanging-floats-not-removed-crash.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):

LayoutTests:

  • fast/flexbox/overhanging-floats-not-removed-crash-expected.txt: Added.
  • fast/flexbox/overhanging-floats-not-removed-crash.html: Added.
14:15 Changeset [108846] by rniwa@webkit.org

Rename dom*_*attributes.html to dom*-*attributes.html to follow the WebKit convention.

  • Bindings/dom-attributes.html: Copied from PerformanceTests/Bindings/dom_attributes.html.
  • Bindings/dom_attributes.html: Removed.
14:09 Changeset [108845] by rniwa@webkit.org

Increment perf-o-matic version.

  • Websites/webkit-perf.appspot.com/app.yaml:
13:40 Changeset [108844] by commit-queue@webkit.org

Adding myself to ScrollingCoordinator watchlist
https://bugs.webkit.org/show_bug.cgi?id=79525

Patch by Antonio Gomes <agomes@rim.com> on 2012-02-24
Reviewed by Rob Buis.

  • Scripts/webkitpy/common/config/watchlist:
13:38 Changeset [108843] by bfulgham@webkit.org

[WinCairo] Compute more acurate font heights.
https://bugs.webkit.org/show_bug.cgi?id=79524

Reviewed by Adam Roben.

Adjust font handling as suggested by Lynn Neir to use the proper
xHeight value for the font, rather than the fall-back guess
used in the current code.

css1/text_properties/line_height.html

  • platform/graphics/win/SimpleFontDataCairoWin.cpp:

(WebCore::SimpleFontData::platformInit): Properly initialize a

few elements.

(WebCore::SimpleFontData::platformWidthForGlyph): Use the Cairo

cairo_scaled_font_text_extents call, rather than attempting
to compute the value from ::GetGlyphOutline.

13:31 Changeset [108842] by fpizlo@apple.com

DFG should be able to handle variables getting captured
https://bugs.webkit.org/show_bug.cgi?id=79469

Reviewed by Oliver Hunt.

Made captured variables work by placing a Flush on the SetLocal and
forcing the emission of the GetLocal even if copy propagation tells us
who has the value.

Changed the CFA and various prediction codes to understand that we can't
really prove anything about captured variables. Well, we could in the
future by just looking at what side effects are happening, but in this
first cut we just assume that we can't reason about captured variables.

Also added a mode where the DFG pretends that all variables and arguments
got captured. Used this mode to harden the code.

This is performance neutral. Capturing all variables is a slow down, but
not too big of one. This seems to predict that when we add activation
support, the amount of speed benefit we'll get from increased coverage
will far outweigh the pessimism that we'll have to endure for captured
variables.

  • bytecode/CodeType.h:

(JSC::codeTypeToString):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::merge):

  • dfg/DFGAbstractState.h:

(AbstractState):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::flushArgument):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGCapabilities.h:

(JSC::DFG::mightInlineFunctionForCall):
(JSC::DFG::mightInlineFunctionForConstruct):

  • dfg/DFGCommon.h:
  • dfg/DFGGraph.h:

(JSC::DFG::Graph::needsActivation):
(Graph):
(JSC::DFG::Graph::argumentIsCaptured):
(JSC::DFG::Graph::localIsCaptured):
(JSC::DFG::Graph::isCaptured):

  • dfg/DFGNode.h:

(JSC::DFG::Node::shouldGenerate):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):

  • dfg/DFGSpeculativeJIT.cpp:

(DFG):
(JSC::DFG::ValueSource::dump):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:

(ValueSource):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGVirtualRegisterAllocationPhase.cpp:

(JSC::DFG::VirtualRegisterAllocationPhase::run):

13:10 Changeset [108841] by barraclough@apple.com

Should not allow malformed \x escapes
https://bugs.webkit.org/show_bug.cgi?id=79462

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • parser/Lexer.cpp:

(JSC::::parseString):
(JSC::::parseStringSlowCase):

  • Prohibit malformed '\x' escapes
  • tests/mozilla/ecma/Array/15.4.5.1-1.js:
  • tests/mozilla/ecma/LexicalConventions/7.7.4.js:
  • tests/mozilla/ecma_2/RegExp/hex-001.js:
  • tests/mozilla/js1_2/regexp/hexadecimal.js:
    • Remove erroneous test cases (correct behaviour is tested by LayoutTests/sputnik).

LayoutTests:

  • fast/regex/script-tests/pcre-test-1.js:
    • Fix bad escapes in test case.
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A4.3_T6-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A6.1_T4-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A6.2_T1-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A6.2_T2-expected.txt:
    • Check in passing results.
13:08 Changeset [108840] by commit-queue@webkit.org

[chromium] Purge Skia's GPU texture cache using GL_CHROMIUM_gpu_memory_manager
https://bugs.webkit.org/show_bug.cgi?id=78265

Patch by Michal Mocny <mmocny@google.com> on 2012-02-24
Reviewed by Stephen White.

  • src/GraphicsContext3DChromium.cpp:

(GrMemoryAllocationChangedCallback):
(WebCore::GrMemoryAllocationChangedCallback::GrMemoryAllocationChangedCallback):
(WebCore::GrMemoryAllocationChangedCallback::onGpuMemoryAllocationChanged):
(WebCore):
(WebCore::GraphicsContext3DPrivate::grContext):

13:06 Changeset [108839] by enne@google.com

Fix flaky tests by removing call to dumpResourceResponseMIMETypes
https://bugs.webkit.org/show_bug.cgi?id=79505

Reviewed by Daniel Bates.

It appears to be a race condition (on Chromium at least) between when
script executes and the style sheet resource response occurs. This
prevents some of the text to be output if the response occurs before
the call to set the flag to dump responses. Since the tests themselves
already test the results of loading stylesheets properly, this extra
text is superfluous and can be removed.

This change modifies all tests using link-load-utilities.js to dump
stylesheet resource responses. Other tests are using
dumpResponseResponseMIMEType, but for things other than stylesheets.

  • fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-existent-and-non-existent-import-expected.txt:
  • fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-non-existent-import-expected.txt:
  • fast/dom/HTMLLinkElement/link-onload-before-page-load-expected.txt:
  • fast/dom/HTMLLinkElement/link-onload-expected.txt:
  • fast/dom/HTMLLinkElement/link-onload-stylesheet-with-import-expected.txt:
  • fast/dom/HTMLLinkElement/link-onload2-expected.txt:
  • fast/dom/HTMLLinkElement/programmatically-add-link-with-onload-handler-expected.txt:
  • fast/dom/HTMLLinkElement/resources/link-load-utilities.js:
  • fast/dom/HTMLStyleElement/style-onerror-with-existent-and-non-existent-import-expected.txt:
12:45 Changeset [108838] by darin@chromium.org

Update watchlist for ChromiumPublicApi to include Platform/chromium/public/

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/config/watchlist:
12:42 Changeset [108837] by dpranke@chromium.org

webkitpy: config_unittest is sensitive to other tests that might've already run
https://bugs.webkit.org/show_bug.cgi?id=79382

Reviewed by Adam Barth.

If another test runs prior to config_unittest and pokes the
cached configuration, the first test in config_unittest might
fail; the tearDown() will then allow subsequent tests to pass.
Clearing the configuration prior to each test makes things
slightly slower but safer.

  • Scripts/webkitpy/layout_tests/port/config_unittest.py:

(ConfigTest.setUp):

12:36 Changeset [108836] by ddkilzer@apple.com

Use xcrun to find compiler paths for Generate Derived Sources build phase script
<http://webkit.org/b/79512>

Reviewed by Dan Bernstein.

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

(Generate Derived Sources): Use xcrun to find the path to the
compiler since that works on both iOS and OS X.

12:07 Changeset [108835] by commit-queue@webkit.org

Make fast/canvas/canvas-strokePath-shadow.html allow for pixel tolerance
https://bugs.webkit.org/show_bug.cgi?id=79488

Patch by Elliot Poger <epoger@google.com> on 2012-02-24
Reviewed by Adam Barth.

  • fast/canvas/script-tests/canvas-strokePath-shadow.js:

(shouldBeAlmost):

  • fast/js/resources/js-test-pre.js:

(shouldBeCloseTo):

11:41 Changeset [108834] by timothy_horton@apple.com

Infinite repaint loop with SVGImageCache and deferred repaint timers
https://bugs.webkit.org/show_bug.cgi?id=78315
<rdar://problem/10651634>

Reviewed by Dean Jackson.

Only defer image redraw on a timer if we're in layout. This breaks
the repaint loop while still preventing us from drawing inside layout.

No new tests, as the problem only occurs in a nonstandard configuration.

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::draw):
(WebCore::SVGImage::frameView):
(WebCore):

  • svg/graphics/SVGImage.h:

(WebCore):

  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::imageContentChanged):
(WebCore::SVGImageCache::redraw):
(WebCore::SVGImageCache::redrawTimerFired):
(WebCore):

  • svg/graphics/SVGImageCache.h:

(SVGImageCache):

11:40 Changeset [108833] by jamesr@google.com

[chromium] Remove deprecated and unused WebGraphicsContext3D::initialize call
https://bugs.webkit.org/show_bug.cgi?id=79296

Reviewed by Kenneth Russell.

The old way to initialize a WebGraphicsContext3D from inside WebKit was to call initialize() on it with a
WebView*. The new way to do this is via the WebViewClient interface. This deletes the old, unused path.

  • public/platform/WebGraphicsContext3D.h:

(WebKit):

  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/FakeWebGraphicsContext3D.h:
11:39 Changeset [108832] by timothy_horton@apple.com

SVG should be supported in Dashboard compatibility mode
https://bugs.webkit.org/show_bug.cgi?id=78322
<rdar://problem/5861278>

Reviewed by Dean Jackson.

Enable SVG elements inside Dashboard, more or less reverting r21418.

Tests: http/tests/xmlhttprequest/svg-created-by-xhr-allowed-in-dashboard.html

svg/custom/embedded-svg-allowed-in-dashboard.xml
svg/custom/manually-parsed-embedded-svg-allowed-in-dashboard.html
svg/custom/manually-parsed-svg-allowed-in-dashboard.html
svg/custom/svg-allowed-in-dashboard-object.html

  • dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createDocument):

  • dom/Document.cpp:

(WebCore::Document::importNode):

  • dom/make_names.pl:

(printFactoryCppFile):

Change tests that ensured that SVG didn't work in Dashboard to instead test that it does!

  • http/tests/xmlhttprequest/svg-created-by-xhr-allowed-in-dashboard-expected.txt: Added.
  • http/tests/xmlhttprequest/svg-created-by-xhr-allowed-in-dashboard.html: Renamed from LayoutTests/http/tests/xmlhttprequest/svg-created-by-xhr-disallowed-in-dashboard.html.
  • http/tests/xmlhttprequest/svg-created-by-xhr-disallowed-in-dashboard-expected.txt: Removed.
  • svg/custom/embedded-svg-allowed-in-dashboard-expected.txt: Added.
  • svg/custom/embedded-svg-allowed-in-dashboard.xml: Renamed from LayoutTests/svg/custom/embedded-svg-disallowed-in-dashboard.xml.
  • svg/custom/embedded-svg-disallowed-in-dashboard-expected.txt: Removed.
  • svg/custom/manually-parsed-embedded-svg-allowed-in-dashboard-expected.txt: Added.
  • svg/custom/manually-parsed-embedded-svg-allowed-in-dashboard.html: Renamed from LayoutTests/svg/custom/manually-parsed-embedded-svg-disallowed-in-dashboard.html.
  • svg/custom/manually-parsed-embedded-svg-disallowed-in-dashboard-expected.txt: Removed.
  • svg/custom/manually-parsed-svg-allowed-in-dashboard-expected.txt: Added.
  • svg/custom/manually-parsed-svg-allowed-in-dashboard.html: Renamed from LayoutTests/svg/custom/manually-parsed-svg-disallowed-in-dashboard.html.
  • svg/custom/manually-parsed-svg-disallowed-in-dashboard-expected.txt: Removed.
  • svg/custom/svg-allowed-in-dashboard-object-expected.txt: Added.
  • svg/custom/svg-allowed-in-dashboard-object.html: Renamed from LayoutTests/svg/custom/svg-disallowed-in-dashboard-object.html.
  • svg/custom/svg-disallowed-in-dashboard-object-expected.txt: Removed.
11:35 Changeset [108831] by commit-queue@webkit.org

Expose a setting to exempt media playback from user gesture requirement after a user gesture is initiated on loading/playing a media
https://bugs.webkit.org/show_bug.cgi?id=79167

Patch by Min Qin <qinmin@google.com> on 2012-02-24
Reviewed by Adam Barth.

Source/WebCore:

Test: media/video-play-require-user-gesture.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::load):
(WebCore::HTMLMediaElement::play):
(WebCore::HTMLMediaElement::removeBehaviorsRestrictionsAfterFirstUserGesture):
(WebCore):

  • html/HTMLMediaElement.h:

(HTMLMediaElement):

  • testing/Internals.cpp:

(WebCore::Internals::setMediaPlaybackRequiresUserGesture):
(WebCore):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

LayoutTests:

  • media/video-play-require-user-gesture-expected.txt: Added.
  • media/video-play-require-user-gesture.html: Added.
11:32 Changeset [108830] by abarth@webkit.org

DOMWindow*.idl should have had the same license block as DOMWindow.idl did originally
https://bugs.webkit.org/show_bug.cgi?id=79507

Reviewed by Alexey Proskuryakov.

In moving pieces of DOMWindow.idl into separate files, we mistakenly
changed some of the license blocks. All these files should have a
license block that matches the file that originally contained the code.

  • Modules/intents/DOMWindowIntents.idl:
  • fileapi/DOMWindowFileSystem.idl:
  • html/DOMWindowHTML.idl:
  • html/canvas/DOMWindowWebGL.idl:
  • mediastream/DOMWindowMediaStream.idl:
  • storage/DOMWindowSQLDatabase.idl:
  • svg/DOMWindowSVG.idl:
  • webaudio/DOMWindowWebAudio.idl:
  • websockets/DOMWindowWebSocket.idl:
  • workers/DOMWindowWorker.idl:
  • xml/DOMWindowXML.idl:
11:28 Changeset [108829] by jamesr@google.com

[chromium] Move Web*Layer* headers into Platform
https://bugs.webkit.org/show_bug.cgi?id=79425

Reviewed by Adam Barth.

Source/Platform:

This moves the Web*Layer* headers and their dependencies from WebKit/chromium/public/platform/ into
Platform/chromium/public.

  • Platform.gypi:
  • chromium/public/WebCanvas.h: Copied from Source/WebKit/chromium/public/platform/WebCanvas.h.

(WebKit):

  • chromium/public/WebColor.h: Copied from Source/WebKit/chromium/public/platform/WebColor.h.

(WebKit):

  • chromium/public/WebColorName.h: Copied from Source/WebKit/chromium/public/platform/WebColorName.h.

(WebKit):

  • chromium/public/WebContentLayer.h: Copied from Source/WebKit/chromium/public/platform/WebContentLayer.h.

(WebKit):
(WebContentLayer):
(WebKit::WebContentLayer::WebContentLayer):
(WebKit::WebContentLayer::~WebContentLayer):
(WebKit::WebContentLayer::operator=):

  • chromium/public/WebContentLayerClient.h: Copied from Source/WebKit/chromium/public/platform/WebContentLayerClient.h.

(WebKit):
(WebContentLayerClient):
(WebKit::WebContentLayerClient::~WebContentLayerClient):

  • chromium/public/WebExternalTextureLayer.h: Copied from Source/WebKit/chromium/public/platform/WebExternalTextureLayer.h.

(WebKit):
(WebExternalTextureLayer):
(WebKit::WebExternalTextureLayer::WebExternalTextureLayer):
(WebKit::WebExternalTextureLayer::~WebExternalTextureLayer):
(WebKit::WebExternalTextureLayer::operator=):

  • chromium/public/WebLayer.h: Copied from Source/WebKit/chromium/public/platform/WebLayer.h.

(WebKit):
(WebLayer):
(WebKit::WebLayer::WebLayer):
(WebKit::WebLayer::~WebLayer):
(WebKit::WebLayer::operator=):
(WebKit::WebLayer::isNull):
(WebKit::WebLayer::to):
(WebKit::WebLayer::toConst):
(WebKit::WebLayer::unwrap):
(WebKit::WebLayer::constUnwrap):
(WebKit::operator==):
(WebKit::operator!=):

  • chromium/public/WebLayerTreeView.h: Copied from Source/WebKit/chromium/public/platform/WebLayerTreeView.h.

(WebCore):
(WebKit):
(WebLayerTreeView):
(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):
(WebKit::WebLayerTreeView::WebLayerTreeView):
(WebKit::WebLayerTreeView::~WebLayerTreeView):
(WebKit::WebLayerTreeView::operator=):
(WebKit::operator==):
(WebKit::operator!=):

  • chromium/public/WebLayerTreeViewClient.h: Copied from Source/WebKit/chromium/public/platform/WebLayerTreeViewClient.h.

(WebKit):
(WebLayerTreeViewClient):
(WebKit::WebLayerTreeViewClient::~WebLayerTreeViewClient):

  • chromium/public/WebPrivatePtr.h: Copied from Source/WebKit/chromium/public/platform/WebPrivatePtr.h.

(WebKit):
(WebPrivatePtr):
(WebKit::WebPrivatePtr::WebPrivatePtr):
(WebKit::WebPrivatePtr::~WebPrivatePtr):
(WebKit::WebPrivatePtr::isNull):
(WebKit::WebPrivatePtr::reset):
(WebKit::WebPrivatePtr::operator=):
(WebKit::WebPrivatePtr::get):
(WebKit::WebPrivatePtr::operator->):
(WebKit::WebPrivatePtr::assign):

  • chromium/public/WebSolidColorLayer.h: Copied from Source/WebKit/chromium/public/platform/WebSolidColorLayer.h.

(WebKit):
(WebSolidColorLayer):

Source/WebKit/chromium:

Adds forwarding headers for Web*Layer* APIs and their dependencies. The forwarding headers for the Web*Layer*
APIs are temporary since Web*Layer* is not exposed in the client interface. The other headers (such as
WebColor) are exposed in both the client and platform APIs, so the forwarding headers are permanent, although we
might move them back down to public/ at some point.

  • public/platform/WebCanvas.h:
  • public/platform/WebColor.h:
  • public/platform/WebColorName.h:
  • public/platform/WebContentLayer.h:
  • public/platform/WebContentLayerClient.h:
  • public/platform/WebExternalTextureLayer.h:
  • public/platform/WebLayer.h:
  • public/platform/WebLayerTreeView.h:
  • public/platform/WebLayerTreeViewClient.h:
  • public/platform/WebPrivatePtr.h:
  • public/platform/WebSolidColorLayer.h:
11:27 Changeset [108828] by lforschler@apple.com

Versioning.

11:25 Changeset [108827] by lforschler@apple.com

New Tag.

11:22 Changeset [108826] by ddkilzer@apple.com

Use xcrun to find compiler paths for Generate Derived Sources build phase script
<http://webkit.org/b/79512>

Reviewed by Mark Rowe.

  • WebCore.xcodeproj/project.pbxproj:

(Generate Derived Sources): Use xcrun to find the path to the
compiler since that works on both iOS and OS X.

11:06 Changeset [108825] by andersca@apple.com

Crash in TileCache::revalidateTiles
https://bugs.webkit.org/show_bug.cgi?id=79510
<rdar://problem/10928035>

Reviewed by Sam Weinig.

Handle the tile cache layer's PlatformCALayer going away before the
CALayer itself has been deallocated.

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::revalidateTiles):

11:06 Changeset [108824] by jamesr@google.com

Create a watchlist for ScrollingCoordinator changes
https://bugs.webkit.org/show_bug.cgi?id=79511

Reviewed by Anders Carlsson.

  • Scripts/webkitpy/common/config/watchlist:
11:00 Changeset [108823] by commit-queue@webkit.org

Remove spurious mac-specific tests
https://bugs.webkit.org/show_bug.cgi?id=75091

Patch by Philip Rogers <pdr@google.com> on 2012-02-24
Reviewed by Daniel Bates.

  • platform/mac/svg/text/text-rescale.html: Removed.
  • platform/mac/svg/text/text-viewbox-rescale.html: Removed.
10:51 Changeset [108822] by jberlin@webkit.org

requestPermission callback not invoked if the WebProcess doesn't have to ask the UI Process
about the permission level.
https://bugs.webkit.org/show_bug.cgi?id=79494

Reviewed by Jon Honeycutt.

Invoke the callback in the case where the permission level is known and no message is sent
to the UI Process.

  • WebProcess/Notifications/NotificationPermissionRequestManager.cpp:

(WebKit::NotificationPermissionRequestManager::startRequest):

10:51 Changeset [108821] by commit-queue@webkit.org

[chromium] Have WebFrameImpl::selectionAsMarkup create interchange markup.
https://bugs.webkit.org/show_bug.cgi?id=77307

Patch by Peter Collingbourne <peter@pcc.me.uk> on 2012-02-24
Reviewed by Tony Chang.

This function is currently used to build markup in order to
print the selection, and will also be used to build markup for
the clipboard. Without this change, the markup will refer to
(for example) nonexistent CSS classes and invalid relative
paths and therefore will not be interpreted correctly.

Chromium bug: http://crbug.com/23329

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::selectionAsMarkup):

10:41 Changeset [108820] by dbates@webkit.org

Fix change log entry for changeset r108819; add bug URL
https://bugs.webkit.org/show_bug.cgi?id=79504

Changeset r108819 is associated with bug #79504.

  • ChangeLog
10:37 Changeset [108819] by dbates@webkit.org

Substitute ENABLE(CLASSIC_INTERPRETER) for ENABLE(INTERPRETER) in Interpreter.cpp

Reviewed by Oliver Hunt.

There are a few places in Interpreter.cpp that need to be updated to use
ENABLE(CLASSIC_INTERPRETER) following the renaming of ENABLE_INTERPRETER to
ENABLE_CLASSIC_INTERPRETER in changeset <http://trac.webkit.org/changeset/108020>
(https://bugs.webkit.org/show_bug.cgi?id=78791).

  • interpreter/Interpreter.cpp:

(JSC::getLineNumberForCallFrame):
(JSC::getCallerInfo):
(JSC::getSourceURLFromCallFrame):

10:26 Changeset [108818] by eae@chromium.org

Merge GNUMakefile from trunk into branch.

10:04 Changeset [108817] by adamk@chromium.org

Don't notify the inspector of Node insertions initiated by the parser
https://bugs.webkit.org/show_bug.cgi?id=79388

Reviewed by Adam Barth.

This is part of a series of changes to make ContainerNode's
implementation simpler and more internally consistent.

I don't know of a way to break on parser-initiated insertions,
and the code already doesn't notify on parser-initiated removes
(in ContainerNode::parserRemoveChild).

No new tests, should already be covered by
inspector/debugger/dom-breakpoints.html.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::parserInsertBefore):
(WebCore::ContainerNode::parserAddChild):

09:56 Changeset [108816] by jocelyn.turcotte@nokia.com

[Qt] Signal and property cleanup in QQuickWebView
https://bugs.webkit.org/show_bug.cgi?id=78820

Reviewed by Simon Hausmann.

  • Remove parameters from property change notify signals: titleChanged, urlChanged, iconChanged, loadProgressChanged
  • Rename the parameters of linkHovered to prevent shadoing properties of WebView
  • Rename navigationStateChanged to navigationHistoryChanged
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::_q_onUrlChanged):
(QQuickWebViewPrivate::setIcon):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

  • UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml:
  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::loadProgress):

  • UIProcess/qt/QtWebPageLoadClient.cpp:

(QtWebPageLoadClient::didCommitLoadForFrame):
(QtWebPageLoadClient::didSameDocumentNavigationForFrame):
(QtWebPageLoadClient::didReceiveTitleForFrame):
(QtWebPageLoadClient::setLoadProgress):

  • UIProcess/qt/QtWebPageLoadClient.h:

(QtWebPageLoadClient):

09:50 Changeset [108815] by jocelyn.turcotte@nokia.com

[Qt] API: Unify the loading properties and signals.
https://bugs.webkit.org/show_bug.cgi?id=79486

Reviewed by Simon Hausmann.

Source/WebKit/qt:

  • declarative/plugin.cpp:

(WebKitQmlPlugin::registerTypes):

Source/WebKit2:

  • Remove the canReload signal, instead assume that calling reload in those cases won't have any effect.
  • Replace loadStarted, loadSucceeded and loadFailed by a single signal: loadingChanged. The signal carries an argument with a status and error codes giving the intended context.
  • Use loadingChanged as the notification signal for the property "loading" instead of navigationStateChanged.

Also update all API tests to use the new loading signals and add some utility functions
to track the loading since the new API aims to be more adapted to declarative logic
and the auto tests are using an imperative logic.

  • Target.pri:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::loadDidSucceed):
(QQuickWebViewPrivate::didChangeLoadingState):
(QQuickWebViewPrivate::processDidCrash):
(QQuickWebViewPrivate::didRelaunchProcess):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

  • UIProcess/API/qt/qwebloadrequest.cpp: Added.

(QWebLoadRequestPrivate):
(QWebLoadRequestPrivate::QWebLoadRequestPrivate):
(QWebLoadRequest::QWebLoadRequest):
(QWebLoadRequest::~QWebLoadRequest):
(QWebLoadRequest::url):
(QWebLoadRequest::status):
(QWebLoadRequest::errorString):
(QWebLoadRequest::errorDomain):
(QWebLoadRequest::errorCode):

  • UIProcess/API/qt/qwebloadrequest_p.h: Added.
  • UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_itemSelector.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_messaging.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_favIconLoad.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_javaScriptDialogs.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadFail.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadHtml.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgress.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgressSignal.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadUrl.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_navigationHistory.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_properties.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_titleChanged.qml:
  • UIProcess/API/qt/tests/qmltests/common/TestWebView.qml: Added.
  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::navigationStatusAtStartup):
(LoadStartedCatcher::LoadStartedCatcher):
(LoadStartedCatcher::onLoadingChanged):
(tst_QQuickWebView::stopEnabledAfterLoadStarted):
(tst_QQuickWebView::loadEmptyPageViewHidden):
(tst_QQuickWebView::loadNonexistentFileUrl):
(tst_QQuickWebView::backAndForward):
(tst_QQuickWebView::reload):
(tst_QQuickWebView::stop):
(tst_QQuickWebView::loadProgress):
(tst_QQuickWebView::showWebView):
(tst_QQuickWebView::multipleWebViewWindows):
(tst_QQuickWebView::multipleWebViews):
(tst_QQuickWebView::scrollRequest):

  • UIProcess/API/qt/tests/util.cpp:

(LoadSpy):
(LoadSpy::LoadSpy):
(LoadSpy::onLoadingChanged):
(waitForLoadSucceeded):
(waitForLoadFailed):

  • UIProcess/API/qt/tests/util.h:
  • UIProcess/qt/QtWebError.h:
  • UIProcess/qt/QtWebPageLoadClient.cpp:

(QtWebPageLoadClient::didStartProvisionalLoadForFrame):
(QtWebPageLoadClient::dispatchLoadFailed):

  • UIProcess/qt/QtWebPageLoadClient.h:

(QtWebPageLoadClient):

09:26 Changeset [108814] by dbates@webkit.org

Attempt to fix the Windows and WinCE build after changeset r108809
<http://trac.webkit.org/changeset/108809> (https://bugs.webkit.org/show_bug.cgi?id=38995)

Substitute styleLoadEventSender() for loadEventSender() in HTMLStyleElement.cpp
and substitute linkLoadEventSender() for loadEventSender() in HTMLLinkElement.cpp.

  • html/HTMLLinkElement.cpp:

(WebCore::linkLoadEventSender):
(WebCore::HTMLLinkElement::~HTMLLinkElement):
(WebCore::HTMLLinkElement::dispatchPendingLoadEvents):
(WebCore::HTMLLinkElement::dispatchPendingEvent):
(WebCore::HTMLLinkElement::notifyLoadedSheetAndAllCriticalSubresources):

  • html/HTMLStyleElement.cpp:

(WebCore::styleLoadEventSender):
(WebCore::HTMLStyleElement::~HTMLStyleElement):
(WebCore::HTMLStyleElement::dispatchPendingLoadEvents):
(WebCore::HTMLStyleElement::dispatchPendingEvent):
(WebCore::HTMLStyleElement::notifyLoadedSheetAndAllCriticalSubresources):

09:25 Changeset [108813] by aroben@apple.com

Undo the BUILDING_WTF part of r108808

This broke the build, which is obviously worse than the linker warning it was trying to
solve.

09:21 Changeset [108812] by peter@chromium.org

[Chromium] Fix Chromium Android build by building HarfBuzzShaperBase.cpp
https://bugs.webkit.org/show_bug.cgi?id=79497

Reviewed by Tony Gentilcore.

The Chromium Android build was broken by revision r108733, as the
HarfBuzzShaperBase.cpp file also should have been included for Android.
Fix the build by including it.

  • WebCore.gyp/WebCore.gyp:
09:02 Changeset [108811] by philn@webkit.org

Unreviewed, GTK SVG rebaseline (from 64-bit Release bot) and
skipping one more fast/dom/shadow test.

  • platform/gtk/Skipped:
  • platform/gtk/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
  • platform/gtk/svg/carto.net/scrollbar-expected.txt:
  • platform/gtk/svg/carto.net/window-expected.txt:
  • platform/gtk/svg/custom/circle-move-invalidation-expected.txt:
  • platform/gtk/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
  • platform/gtk/svg/custom/js-late-gradient-and-object-creation-expected.txt:
  • platform/gtk/svg/custom/js-late-pattern-and-object-creation-expected.txt:
  • platform/gtk/svg/custom/use-detach-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
09:02 Changeset [108810] by yael.aharon@nokia.com

[Texmap] Consolidate the common parts of TextureMapperGL::drawTexture
https://bugs.webkit.org/show_bug.cgi?id=79143

Reviewed by Noam Rosenthal.

Combine the two drawTexture methods into one, and extract the part that
could not be combined into its own method.
No new tests. Refactoring only.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore):
(WebCore::TextureMapperGL::drawTexture):

  • platform/graphics/texmap/TextureMapperGL.h:

(WebCore):
(BitmapTextureGL):
(WebCore::BitmapTextureGL::~BitmapTextureGL):
(WebCore::BitmapTextureGL::id):
(WebCore::BitmapTextureGL::relativeSize):
(WebCore::BitmapTextureGL::setTextureMapper):
(WebCore::BitmapTextureGL::BitmapTextureGL):

  • platform/graphics/texmap/TextureMapperShaderManager.cpp:

(WebCore::TextureMapperShaderProgramOpacityAndMask::fragmentShaderSource):
(WebCore):
(WebCore::TextureMapperShaderProgramOpacityAndMask::prepare):

  • platform/graphics/texmap/TextureMapperShaderManager.h:

(WebCore):
(WebCore::TextureMapperShaderProgram::prepare):
(WebCore::TextureMapperShaderProgram::matrixVariable):
(WebCore::TextureMapperShaderProgram::sourceMatrixVariable):
(WebCore::TextureMapperShaderProgram::sourceTextureVariable):
(WebCore::TextureMapperShaderProgram::opacityVariable):
(TextureMapperShaderProgram):
(TextureMapperShaderProgramSimple):
(TextureMapperShaderProgramOpacityAndMask):
(WebCore::TextureMapperShaderProgramOpacityAndMask::maskMatrixVariable):
(WebCore::TextureMapperShaderProgramOpacityAndMask::maskTextureVariable):

08:50 Changeset [108809] by dbates@webkit.org

style element and link element for CSS stylesheet should emit load/error event when sheet loads/fails to load
https://bugs.webkit.org/show_bug.cgi?id=38995

Reviewed by Adam Barth and Nate Chapin.

Source/WebCore:

Tests: fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-existent-and-non-existent-import.html

fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-non-existent-import.html
fast/dom/HTMLLinkElement/link-onerror.html
fast/dom/HTMLLinkElement/link-onload-before-page-load.html
fast/dom/HTMLLinkElement/link-onload-stylesheet-with-import.html
fast/dom/HTMLLinkElement/link-onload.html
fast/dom/HTMLLinkElement/link-onload2.html
fast/dom/HTMLLinkElement/programmatically-add-link-with-onerror-handler.html
fast/dom/HTMLLinkElement/programmatically-add-link-with-onload-handler.html
fast/dom/HTMLStyleElement/programmatically-add-style-with-onerror-handler.html
fast/dom/HTMLStyleElement/programmatically-add-style-with-onload-handler.html
fast/dom/HTMLStyleElement/style-onerror-with-existent-and-non-existent-import.html
fast/dom/HTMLStyleElement/style-onerror.html
fast/dom/HTMLStyleElement/style-onload-before-page-load.html
fast/dom/HTMLStyleElement/style-onload.html
fast/dom/HTMLStyleElement/style-onload2.html

Implements support for firing Load and Error events at HTML Link and HTML Style elements as per
the HTML5 spec. (draft 05/25/2011) section "The link element" <http://www.w3.org/TR/html5/semantics.html#the-link-element>
and "The style element" <http://www.w3.org/TR/html5/semantics.html#the-style-element>, respectively.

  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::setCSSStyleSheet): Modified to call CSSStyleSheet::notifyLoadedSheet()
after the style sheet associated with the @import rule loaded.

  • css/CSSStyleSheet.cpp: Added instance variable m_didLoadErrorOccur to track whether a network error

occurred while loading any @import style sheets.
(WebCore::CSSStyleSheet::CSSStyleSheet):
(WebCore::CSSStyleSheet::checkLoaded):
(WebCore):
(WebCore::CSSStyleSheet::notifyLoadedSheet): Added; update m_didLoadErrorOccur to reflect if a network
error occurred while loading a style sheet associated with an @import rule.

  • css/CSSStyleSheet.h:

(WebCore):
(CSSStyleSheet):

  • dom/Document.cpp:

(WebCore::Document::implicitClose): Call HTML{LinkElement, StyleElement}::dispatchPendingLoadEvents() to
ensure that all pending Load events for link and style elements are dispatched before we fire the Load
event for the window.

  • dom/Node.h:

(WebCore::Node::notifyLoadedSheetAndAllCriticalSubresources): Added; as stated in its name, this method is
called once a style sheet and all its critical subresources (@imports) have loaded.

  • html/HTMLLinkElement.cpp:

(WebCore::loadEventSender):
(WebCore):
(WebCore::HTMLLinkElement::HTMLLinkElement):
(WebCore::HTMLLinkElement::~HTMLLinkElement): Modified to cancel all pending Load events on destruction.
(WebCore::HTMLLinkElement::parseAttribute): Register event listeners for Load and Error events regardless of whether we
built with link prefetch support.
(WebCore::HTMLLinkElement::setCSSStyleSheet):
(WebCore::HTMLLinkElement::dispatchPendingLoadEvents): Added; called from Document::implicitClose() to
ensure that all pending Load events for link elements have been dispatched before we fire the Load event
for the window.
(WebCore::HTMLLinkElement::dispatchPendingEvent): Added; called by EventSender.
(WebCore::HTMLLinkElement::notifyLoadedSheetAndAllCriticalSubresources): Added.

  • html/HTMLLinkElement.h:

(WebCore):
(HTMLLinkElement):

  • html/HTMLStyleElement.cpp:

(WebCore::loadEventSender):
(WebCore):
(WebCore::HTMLStyleElement::HTMLStyleElement):
(WebCore::HTMLStyleElement::~HTMLStyleElement): Modified to cancel all pending Load events on destruction.
(WebCore::HTMLStyleElement::parseAttribute): Register event listeners for Load and Error events.
(WebCore::HTMLStyleElement::dispatchPendingLoadEvents): Added; called from Document::implicitClose() to
ensure that all pending Load events for link elements have been dispatched before we fire the Load event
for the window.
(WebCore::HTMLStyleElement::dispatchPendingEvent): Added; called by EventSender.
(WebCore::HTMLStyleElement::notifyLoadedSheetAndAllCriticalSubresources): Added.

  • html/HTMLStyleElement.h:

(WebCore):
(HTMLStyleElement):

LayoutTests:

Add test cases to ensure we dispatch Load/Error events to HTML Link and HTML Style elements.

  • fast/dom/HTMLLinkElement/link-onerror-expected.txt: Added.
  • fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-existent-and-non-existent-import-expected.txt: Added.
  • fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-existent-and-non-existent-import.html: Added.
  • fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-non-existent-import-expected.txt: Added.
  • fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-non-existent-import.html: Added.
  • fast/dom/HTMLLinkElement/link-onerror.html: Added.
  • fast/dom/HTMLLinkElement/link-onload-before-page-load-expected.txt: Added.
  • fast/dom/HTMLLinkElement/link-onload-before-page-load.html: Added.
  • fast/dom/HTMLLinkElement/link-onload-expected.txt: Added.
  • fast/dom/HTMLLinkElement/link-onload-stylesheet-with-import-expected.txt: Added.
  • fast/dom/HTMLLinkElement/link-onload-stylesheet-with-import.html: Added.
  • fast/dom/HTMLLinkElement/link-onload.html: Added.
  • fast/dom/HTMLLinkElement/link-onload2-expected.txt: Added.
  • fast/dom/HTMLLinkElement/link-onload2.html: Added.
  • fast/dom/HTMLLinkElement/programmatically-add-link-with-onerror-handler-expected.txt: Added.
  • fast/dom/HTMLLinkElement/programmatically-add-link-with-onerror-handler.html: Added.
  • fast/dom/HTMLLinkElement/programmatically-add-link-with-onload-handler-expected.txt: Added.
  • fast/dom/HTMLLinkElement/programmatically-add-link-with-onload-handler.html: Added.
  • fast/dom/HTMLLinkElement/resources/link-load-utilities.js: Added.

(shouldComputedColorOfElementBeEqualToRGBString):
(createLinkElementWithStylesheet):
(createStyleElementWithString):
(log):
(testPassed):
(testFailed):
(testPassedAndNotifyDone):
(testFailedAndNotifyDone):
(testFinished):

  • fast/dom/HTMLLinkElement/resources/stylesheet-with-existent-and-non-existent-import.css: Added.

(#test):

  • fast/dom/HTMLLinkElement/resources/stylesheet-with-import.css: Added.

(#test):

  • fast/dom/HTMLLinkElement/resources/stylesheet-with-non-existent-import.css: Added.

(#test):

  • fast/dom/HTMLLinkElement/resources/stylesheet.css: Added.

(#test):

  • fast/dom/HTMLStyleElement/programmatically-add-style-with-onerror-handler-expected.txt: Added.
  • fast/dom/HTMLStyleElement/programmatically-add-style-with-onerror-handler.html: Added.
  • fast/dom/HTMLStyleElement/programmatically-add-style-with-onload-handler-expected.txt: Added.
  • fast/dom/HTMLStyleElement/programmatically-add-style-with-onload-handler.html: Added.
  • fast/dom/HTMLStyleElement/style-onerror-expected.txt: Added.
  • fast/dom/HTMLStyleElement/style-onerror-with-existent-and-non-existent-import-expected.txt: Added.
  • fast/dom/HTMLStyleElement/style-onerror-with-existent-and-non-existent-import.html: Added.
  • fast/dom/HTMLStyleElement/style-onerror.html: Added.
  • fast/dom/HTMLStyleElement/style-onload-before-page-load-expected.txt: Added.
  • fast/dom/HTMLStyleElement/style-onload-before-page-load.html: Added.
  • fast/dom/HTMLStyleElement/style-onload-expected.txt: Added.
  • fast/dom/HTMLStyleElement/style-onload.html: Added.
  • fast/dom/HTMLStyleElement/style-onload2-expected.txt: Added.
  • fast/dom/HTMLStyleElement/style-onload2.html: Added.
08:49 Changeset [108808] by aroben@apple.com

Fix linker warnings on Windows

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Removed symbols that are already

exported via JS_EXPORTDATA.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Define BUILDING_WTF. We

aren't actually building WTF, but we are statically linking it, so we need to define this
symbol so that we export WTF's exports.

08:48 Changeset [108807] by aroben@apple.com

Mac build fix after r108698

  • page/scrolling/mac/ScrollingCoordinatorMac.mm: Added missing #import.
08:33 Changeset [108806] by commit-queue@webkit.org

[EFL][DRT] Implement setValueForUser and setAutofilled.
https://bugs.webkit.org/show_bug.cgi?id=79237

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2012-02-24
Reviewed by Andreas Kling.

Source/WebKit:

Adds the main directory of WebKit's source to find headers of JavaScriptCore.

  • PlatformEfl.cmake:

Source/WebKit/efl:

Adds missing implementation setValueForUser and setAutofilled to EFL's DumpRenderTreeSupport.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::setValueForUser):
(DumpRenderTreeSupportEfl::setAutofilled):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Adds missing implementation setValueForUser and setAutofilled to EFL's LayoutTestController.
Those implementations are related with input fields and allow to pass following tests:
fast/forms/onchange-setvalueforuser.html
fast/forms/input-autofilled.html
fast/forms/reset-autofilled.html

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setValueForUser):
(LayoutTestController::setAutofilled):

LayoutTests:

Adds missing implementation setValueForUser and setAutofilled to EFL's LayoutTestController.
Those implementations are related with input fields and allow to pass following tests:
fast/forms/onchange-setvalueforuser.html
fast/forms/input-autofilled.html
fast/forms/reset-autofilled.html

  • platform/efl/Skipped:
08:33 Changeset [108805] by hausmann@webkit.org

Unreviewed, rolling out r108798.
http://trac.webkit.org/changeset/108798
https://bugs.webkit.org/show_bug.cgi?id=78047

Broke too many Qt WK2 tests.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebView::keyPressEvent):
(QQuickWebView::keyReleaseEvent):
(QQuickWebView::inputMethodEvent):
(QQuickWebView::focusInEvent):
(QQuickWebView::focusOutEvent):
(QQuickWebView::touchEvent):
(QQuickWebView::mousePressEvent):
(QQuickWebView::mouseMoveEvent):
(QQuickWebView::mouseReleaseEvent):
(QQuickWebView::mouseDoubleClickEvent):
(QQuickWebView::wheelEvent):
(QQuickWebView::hoverEnterEvent):
(QQuickWebView::hoverMoveEvent):
(QQuickWebView::hoverLeaveEvent):
(QQuickWebView::dragMoveEvent):
(QQuickWebView::dragEnterEvent):
(QQuickWebView::dragLeaveEvent):
(QQuickWebView::dropEvent):
(QQuickWebView::event):

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::handleEvent):
(QtWebPageEventHandler::handleMouseMoveEvent):
(QtWebPageEventHandler::handleMousePressEvent):
(QtWebPageEventHandler::handleMouseReleaseEvent):
(QtWebPageEventHandler::handleWheelEvent):
(QtWebPageEventHandler::handleHoverLeaveEvent):
(QtWebPageEventHandler::handleHoverMoveEvent):
(QtWebPageEventHandler::handleDragEnterEvent):
(QtWebPageEventHandler::handleDragLeaveEvent):
(QtWebPageEventHandler::handleDragMoveEvent):
(QtWebPageEventHandler::handleDropEvent):
(QtWebPageEventHandler::handleKeyPressEvent):
(QtWebPageEventHandler::handleKeyReleaseEvent):
(QtWebPageEventHandler::handleFocusInEvent):
(QtWebPageEventHandler::handleFocusOutEvent):
(QtWebPageEventHandler::inputMethodEvent):
(QtWebPageEventHandler::touchEvent):

  • UIProcess/qt/QtWebPageEventHandler.h:

(QtWebPageEventHandler):

08:33 Changeset [108804] by ossy@webkit.org

Unreviewed speculative buildfix after r108785 for ENABLE(SVG) && !ENABLE(XSLT) case.

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::canRequest):

08:33 Changeset [108803] by commit-queue@webkit.org

[BlackBerry] Eliminate excessive BlackBerry::Platform use in InputHandler
https://bugs.webkit.org/show_bug.cgi?id=79393

Patch by Mike Fenton <mifenton@rim.com> on 2012-02-24
Reviewed by Antonio Gomes.

Cleanup usage of BlackBerry::Platform in InputHandler.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::convertStringToWchar):
(BlackBerry::WebKit::convertStringToWcharVector):
(BlackBerry::WebKit::convertSpannableStringToString):
(BlackBerry::WebKit::InputHandler::learnText):
(BlackBerry::WebKit::InputHandler::setElementUnfocused):
(BlackBerry::WebKit::InputHandler::shouldAcceptInputFocus):
(BlackBerry::WebKit::InputHandler::setElementFocused):
(BlackBerry::WebKit::InputHandler::nodeTextChanged):
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
(BlackBerry::WebKit::InputHandler::frameUnloaded):
(BlackBerry::WebKit::InputHandler::selectionChanged):
(BlackBerry::WebKit::InputHandler::setSelection):
(BlackBerry::WebKit::InputHandler::handleKeyboardInput):
(BlackBerry::WebKit::InputHandler::deleteTextRelativeToCursor):
(BlackBerry::WebKit::InputHandler::deleteText):
(BlackBerry::WebKit::InputHandler::spannableTextInRange):
(BlackBerry::WebKit::InputHandler::setComposingRegion):
(BlackBerry::WebKit::InputHandler::finishComposition):
(BlackBerry::WebKit::InputHandler::setText):
(BlackBerry::WebKit::InputHandler::setTextAttributes):
(BlackBerry::WebKit::InputHandler::setRelativeCursorPosition):
(BlackBerry::WebKit::InputHandler::setSpannableTextAndRelativeCursor):
(BlackBerry::WebKit::InputHandler::setComposingText):
(BlackBerry::WebKit::InputHandler::commitText):

08:00 Changeset [108802] by pfeldman@chromium.org

Not reviewed: chromium image for inspector status bar button updated.

Patch by Pavel Feldman <pfeldman@chromium.org> on 2012-02-24

  • src/js/Images/segmentSelectedEndChromium.png:
07:54 Changeset [108801] by ossy@webkit.org

[Qt] Unreviewed gardening, skip new failing tests.

  • platform/qt/Skipped:
07:54 Changeset [108800] by vsevik@chromium.org

Web Inspector: Do not show scripts panel navigator automatically more than once to the same user.
https://bugs.webkit.org/show_bug.cgi?id=79489

Reviewed by Pavel Feldman.

  • inspector/front-end/ScriptsPanel.js:
07:51 Changeset [108799] by philn@webkit.org

Unreviewed, GTK rebaseline and skip a fast/dom/shadow test.

  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
07:48 Changeset [108798] by hausmann@webkit.org

[Qt][WK2] QQuickWebView::event should lookup faster which events QQuickWebPage can handle
https://bugs.webkit.org/show_bug.cgi?id=78047

Reviewed by Kenneth Rohde Christiansen.

Replaced double-dispatch of events with direct forwarding of events from QQuickWebView::*Event to
QtWebPageEventHandler::handle*Event.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebView::keyPressEvent):
(QQuickWebView::keyReleaseEvent):
(QQuickWebView::inputMethodEvent):
(QQuickWebView::focusInEvent):
(QQuickWebView::focusOutEvent):
(QQuickWebView::touchEvent):
(QQuickWebView::mousePressEvent):
(QQuickWebView::mouseMoveEvent):
(QQuickWebView::mouseReleaseEvent):
(QQuickWebView::mouseDoubleClickEvent):
(QQuickWebView::wheelEvent):
(QQuickWebView::hoverEnterEvent):
(QQuickWebView::hoverMoveEvent):
(QQuickWebView::hoverLeaveEvent):
(QQuickWebView::dragMoveEvent):
(QQuickWebView::dragEnterEvent):
(QQuickWebView::dragLeaveEvent):
(QQuickWebView::dropEvent):
(QQuickWebView::event):

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::handleMouseMoveEvent):
(QtWebPageEventHandler::handleMousePressEvent):
(QtWebPageEventHandler::handleMouseReleaseEvent):
(QtWebPageEventHandler::handleWheelEvent):
(QtWebPageEventHandler::handleHoverLeaveEvent):
(QtWebPageEventHandler::handleHoverMoveEvent):
(QtWebPageEventHandler::handleDragEnterEvent):
(QtWebPageEventHandler::handleDragLeaveEvent):
(QtWebPageEventHandler::handleDragMoveEvent):
(QtWebPageEventHandler::handleDropEvent):
(QtWebPageEventHandler::handleKeyPressEvent):
(QtWebPageEventHandler::handleKeyReleaseEvent):
(QtWebPageEventHandler::handleFocusInEvent):
(QtWebPageEventHandler::handleFocusOutEvent):
(QtWebPageEventHandler::handleInputMethodEvent):
(QtWebPageEventHandler::handleTouchEvent):

  • UIProcess/qt/QtWebPageEventHandler.h:

(QtWebPageEventHandler):

07:40 Changeset [108797] by philn@webkit.org

Fix GTK WebAudio build for WebKitGTK 1.7.90.

Patch by Priit Laes <plaes@plaes.org> on 2012-02-24
Rubber-stamped by Philippe Normand.

Source/JavaScriptCore:

  • GNUmakefile.list.am: Add Complex.h to the list of files so it

gets disted in the tarballs.

Source/WebCore:

  • GNUmakefile.list.am: Add AudioBufferCallback.h and

DenormalDisabler.h to the list of files so they get disted in the
tarballs.

07:34 Changeset [108796] by commit-queue@webkit.org

[BlackBerry] Eliminate excessive BlackBerry::Platform use in SelectionHandler.
https://bugs.webkit.org/show_bug.cgi?id=79391

Patch by Mike Fenton <mifenton@rim.com> on 2012-02-24
Reviewed by Antonio Gomes.

Clean up usage of BlackBerry::Platform in SelectionHandler and
explicitly define what namespace to use for ambiguous objects like
IntRect and IntPoint.

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::cancelSelection):
(BlackBerry::WebKit::SelectionHandler::getConsolidatedRegionOfTextQuadsForSelection):
(BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
(BlackBerry::WebKit::directionOfPointRelativeToRect):
(BlackBerry::WebKit::SelectionHandler::shouldUpdateSelectionOrCaretForPoint):
(BlackBerry::WebKit::SelectionHandler::setCaretPosition):
(BlackBerry::WebKit::directionalVisiblePositionAtExtentOfBox):
(BlackBerry::WebKit::pointIsOutsideOfBoundingBoxInDirection):
(BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
(BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
(BlackBerry::WebKit::SelectionHandler::clipPointToFocusNode):
(BlackBerry::WebKit::SelectionHandler::setSelection):
(BlackBerry::WebKit::SelectionHandler::selectAtPoint):
(BlackBerry::WebKit::SelectionHandler::selectObject):
(BlackBerry::WebKit::comparePointsToReferencePoint):
(BlackBerry::WebKit::minXMinYCorner):
(BlackBerry::WebKit::maxXMinYCorner):
(BlackBerry::WebKit::minXMaxYCorner):
(BlackBerry::WebKit::maxXMaxYCorner):
(BlackBerry::WebKit::caretLocationForRect):
(BlackBerry::WebKit::caretComparisonPointForRect):
(BlackBerry::WebKit::adjustCaretRects):
(BlackBerry::WebKit::SelectionHandler::clipRegionToVisibleContainer):
(BlackBerry::WebKit::referencePoint):
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
(BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
(BlackBerry::WebKit::SelectionHandler::selectionContains):

07:32 Changeset [108795] by yurys@chromium.org

Web Inspector: show all counters on one graph
https://bugs.webkit.org/show_bug.cgi?id=79484

Now it is possible to hide any counter. All graphs share the same area.
Current values are displayed above that area.

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/MemoryStatistics.js:

(WebInspector.MemoryStatistics.getDocumentCount):
(WebInspector.MemoryStatistics.getNodeCount):
(WebInspector.MemoryStatistics.getListenerCount):
(WebInspector.MemoryStatistics):
(WebInspector.SwatchCheckbox):
(WebInspector.SwatchCheckbox.prototype.get checked):
(WebInspector.SwatchCheckbox.prototype.set checked):
(WebInspector.SwatchCheckbox.prototype._toggleCheckbox):
(WebInspector.CounterUI):
(WebInspector.CounterUI.prototype._toggleCounterGraph):
(WebInspector.CounterUI.prototype.setRange):
(WebInspector.CounterUI.prototype.updateCurrentValue):
(WebInspector.CounterUI.prototype.clearCurrentValueAndMarker):
(WebInspector.CounterUI.prototype.get visible):
(WebInspector.CounterUI.prototype.saveImageUnderMarker):
(WebInspector.CounterUI.prototype.restoreImageUnderMarker):
(WebInspector.CounterUI.prototype.discardImageUnderMarker):
(WebInspector.MemoryStatistics.prototype._updateSize):
(WebInspector.MemoryStatistics.prototype._draw):
(WebInspector.MemoryStatistics.prototype._onMouseOut):
(WebInspector.MemoryStatistics.prototype._refreshCurrentValues):
(WebInspector.MemoryStatistics.prototype._highlightCurrentPositionOnGraphs):
(WebInspector.MemoryStatistics.prototype._drawGraph):
(WebInspector.MemoryStatistics.prototype._clear):

  • inspector/front-end/timelinePanel.css:

(.memory-counter-sidebar-info):
(.memory-counter-sidebar-info .swatch):
(.memory-counter-sidebar-info .title):
(.memory-counter-value):
(#counter-values-bar):

07:28 Changeset [108794] by pfeldman@chromium.org

Web Inspector: map Ctrl/Cmd +/- to zoom in hosted mode.
https://bugs.webkit.org/show_bug.cgi?id=79475

(In remote front-end mode, default zoom actions are working.)

Reviewed by Yury Semikhatsky.

  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::setZoomFactor):
(WebCore):

  • inspector/InspectorFrontendHost.h:

(InspectorFrontendHost):

  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub):
(.WebInspector.InspectorFrontendHostStub.prototype.loadResourceSynchronously):
(.WebInspector.InspectorFrontendHostStub.prototype.setZoomFactor):

  • inspector/front-end/Settings.js:

(WebInspector.Settings):

  • inspector/front-end/inspector.js:

(WebInspector._initializeCapability):
(WebInspector._zoomIn):
(WebInspector._zoomOut):
(WebInspector._resetZoom):
(WebInspector._requestZoom.set InspectorFrontendHost):
(WebInspector._requestZoom):
(WebInspector._doLoadedDoneWithCapabilities.get if):
(WebInspector.documentKeyDown):

07:03 Changeset [108793] by commit-queue@webkit.org

Refactor EventHandler::handleGestureEvent.
https://bugs.webkit.org/show_bug.cgi?id=79476

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-24
Reviewed by Kenneth Rohde Christiansen.

No new tests. No behavior change.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleGestureTap):
(WebCore::EventHandler::handleGestureScrollUpdate):

  • page/EventHandler.h:
06:48 Changeset [108792] by zoltan@webkit.org

[Qt] Allow to use WebCore imagedecoders
https://bugs.webkit.org/show_bug.cgi?id=32410

Source/WebCore:

Add ENABLE(QT_IMAGE_DECODER) guards around Qt imagedecoders and set it to default.
By passing ENABLE_QT_IMAGE_DECODER=0 define to the build system, WebKit will build
with WebCore's imagedecoders.

I added NO_RETURN attribute and PLATFORM(QT) conditionals to 2 functions of PNG and
JPEG decoders to avoid compiler warnings because in Qt-port we treat warning as errors (-Werror).

I'm continuing the refactoring of this area and try to use Qt imagedecoders only in
cases when WebCore doesn't support the image format.

Reviewed by Simon Hausmann.

No behavior change, no need new tests.

  • Target.pri:
  • WebCore.pri:
  • platform/MIMETypeRegistry.cpp:

(WebCore::initializeSupportedImageMIMETypes):
(WebCore::initializeSupportedImageMIMETypesForEncoding):

  • platform/image-decoders/ImageDecoder.h:

(WebCore::ImageFrame::getAddr):
(ImageFrame):

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

NO_RETURN has been added to a function to avoid warning message.

  • platform/image-decoders/png/PNGImageDecoder.cpp:

NO_RETURN has been added to a function to avoid warning message.
(WebCore):

  • platform/image-decoders/qt/ImageFrameQt.cpp:

(WebCore):
(WebCore::ImageFrame::asNewNativeImage):

Tools:

Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.

Reviewed by Simon Hausmann.

  • qmake/mkspecs/features/features.prf:
06:46 Changeset [108791] by commit-queue@webkit.org

[Windows, WinCairo] Handle indeterminate checkbox state
https://bugs.webkit.org/show_bug.cgi?id=79288

Patch by Lynn Neir <lynn.neir@skype.net> on 2012-02-24
Reviewed by Adam Roben.

Tested by fast/forms/indeterminate.html

  • rendering/RenderThemeWin.cpp: Add code to check for indeterminate state in CheckBox.
06:42 Changeset [108790] by kbalazs@webkit.org

[Qt] Add Qt5 way to force 96 DPI for tests
https://bugs.webkit.org/show_bug.cgi?id=79364

Reviewed by Simon Hausmann.

  • DumpRenderTree/qt/main.cpp:

(main):

  • WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:

(WTR::activateFonts):

06:41 Changeset [108789] by ossy@webkit.org

[Qt] Use private QSGRenderNode in QQuickWebView for improved Qt Scene Graph integration
https://bugs.webkit.org/show_bug.cgi?id=79022

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-02-24
Reviewed by Csaba Osztrogonác.

  • Target.pri:
  • UIProcess/API/qt/qquickwebpage.cpp:

(PageProxyNode::PageProxyNode):
(PageProxyNode::changedStates):
(PageProxyNode::render):
(PageProxyNode):

06:39 Changeset [108788] by ossy@webkit.org

[Qt] Font related problem with newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=79402

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-02-24
Reviewed by Kenneth Rohde Christiansen.

Apply the descent += 1 workaround needed to produce correct metrics only for Qt 4,
because the behaviour has been corrected in Qt 5.

  • platform/graphics/qt/SimpleFontDataQt.cpp:

(WebCore::SimpleFontData::platformInit):

06:37 Changeset [108787] by haraken@chromium.org

Move XML-related APIs from DOMWindow.idl to DOMWindowXML.idl
https://bugs.webkit.org/show_bug.cgi?id=79434

Reviewed by Adam Barth.

For WebKit modularization, this patch moves XML-related APIs
from DOMWindow.idl to DOMWIndowXML.idl.

No tests. No change in behavior.

  • xml/DOMWindowXML.idl: Added.
  • page/DOMWindow.idl:
  • CMakeLists.txt: Added "DOMWindowXML.idl".
  • DerivedSources.make: Ditto.
  • DerivedSources.pri: Ditto.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
06:36 Changeset [108786] by ossy@webkit.org

[Qt] Build fix. macro "QSKIP" now only takes 1 argument on Qt5
https://bugs.webkit.org/show_bug.cgi?id=79328

Patch by Holger Hans Peter Freyther <holger@moiji-mobile.com> on 2012-02-24
Reviewed by Csaba Osztrogonác.

Introduce an alternative QSKIP that can work with both Qt4
and Qt5 without adding #ifdef to each usage site.

  • tests/benchmarks/loading/tst_loading.cpp:

(tst_Loading::load):

  • tests/benchmarks/painting/tst_painting.cpp:

(tst_Painting::paint):

  • tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:

(tst_QDeclarativeWebView::elementAreaAt):

  • tests/qwebframe/tst_qwebframe.cpp:

(tst_QWebFrame::setHtmlWithBaseURL):

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::geolocationRequestJS):
(tst_QWebPage::loadHtml5Video):
(tst_QWebPage::screenshot):

  • tests/qwebview/tst_qwebview.cpp:

(tst_QWebView::reusePage):

06:31 Changeset [108785] by reni@webkit.org

External <use> xlink:href references do not work
https://bugs.webkit.org/show_bug.cgi?id=12499

Reviewed by Nikolas Zimmermann.

Support external references on <use> by introducing CachedSVGDocument.
CachedSVGDocument is a CachedResource specialized for SVGDocuments.
This CachedSVGDocument will be stored for every use element with external reference.
This first patch only contains the new classes to test whether it works on every platform.
So they aren't used anywhere and just a follow-up patch will bind them into the caching system.

No new tests - no change in functionality.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/cache/CachedResource.cpp:

(WebCore::defaultPriorityForResourceType):
(WebCore::cachedResourceTypeToTargetType):

  • loader/cache/CachedResource.h:
  • loader/cache/CachedResourceClient.h:

(CachedResourceClient):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource):
(WebCore::CachedResourceLoader::checkInsecureContent):
(WebCore::CachedResourceLoader::canRequest):

  • loader/cache/CachedSVGDocument.cpp: Added.

(WebCore):
(WebCore::CachedSVGDocument::CachedSVGDocument):
(WebCore::CachedSVGDocument::~CachedSVGDocument):
(WebCore::CachedSVGDocument::setEncoding):
(WebCore::CachedSVGDocument::encoding):
(WebCore::CachedSVGDocument::data):

  • loader/cache/CachedSVGDocument.h: Added.

(WebCore):
(CachedSVGDocument):
(WebCore::CachedSVGDocument::document):
(WebCore::CachedSVGDocument::schedule):
(CachedSVGDocumentClient):
(WebCore::CachedSVGDocumentClient::~CachedSVGDocumentClient):
(WebCore::CachedSVGDocumentClient::expectedType):
(WebCore::CachedSVGDocumentClient::resourceClientType):

06:20 WebKitGTK/WebKit2Roadmap edited by carlosgc@webkit.org
(diff)
06:16 Changeset [108784] by alexis.menard@openbossa.org

Little optimization in CSSParser::parseShorthand.
https://bugs.webkit.org/show_bug.cgi?id=79356

Reviewed by Tony Chang.

Remove one loop by initializing array values at declaration time.
Also early return when the number of properties parsed are equals
with longhands count of the shorthand. It happens to be very often
the case (e.g. border). Instruments shows an improvement from 19ms
to 17ms on the time spent in this function for the css-parser-yui
benchmark.

No new tests : refactor, exisiting ones should cover.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseShorthand):

06:09 Changeset [108783] by jochen@chromium.org

Tests for showModalDialog need to ask for permission to open windows
https://bugs.webkit.org/show_bug.cgi?id=79465

Reviewed by Tony Gentilcore.

  • fast/animation/request-animation-frame-during-modal.html:
  • fast/events/scroll-event-during-modal-dialog.html:
06:03 Changeset [108782] by haraken@chromium.org

Unreviewed, rolling out r108477.
http://trac.webkit.org/changeset/108477
https://bugs.webkit.org/show_bug.cgi?id=79209

The perf tests committed in r108748 covers the perf tests
committed in r108477. So I'll roll out r108477.

  • Bindings/dom_attributes_id_getter.html: Removed.
  • Bindings/dom_attributes_id_setter.html: Removed.
  • Bindings/resources/dom_attributes_common.js: Removed.
05:50 Changeset [108781] by haraken@chromium.org

Move HTML-related APIs from DOMWindow.idl to DOMWindowHTML.idl
https://bugs.webkit.org/show_bug.cgi?id=79436

Reviewed by Adam Barth.

For WebKit modularization, this patch moves HTML-related APIs
from DOMWindow.idl to DOMWindowHTML.idl.

No tests. No change in behavior.

  • html/DOMWindowHTML.idl:
  • page/DOMWindow.idl:
05:41 Changeset [108780] by jochen@chromium.org

[v8] when a named item on document goes out of scope, actually remove it
https://bugs.webkit.org/show_bug.cgi?id=79409

Reviewed by Adam Barth.

Source/WebCore:

The original change already included the code, but it led to some
problems, so it was reverted in http://trac.webkit.org/changeset/63845.
However, not removing the items leaks a considerable amount of memory,
so I'm adding the code back. The bug that led to the revert was that
the accessor was removed unconditionally. I'm now only removing it,
when the last item with that name is removed.

Test: fast/dom/HTMLDocument/named-item.html

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::namedItemRemoved):

LayoutTests:

  • fast/dom/HTMLDocument/named-item-expected.txt: Added.
  • fast/dom/HTMLDocument/named-item.html: Added.
05:38 Changeset [108779] by zherczeg@webkit.org

[Qt] Buildfix for "Zero out CopiedBlocks on initialization".
https://bugs.webkit.org/show_bug.cgi?id=79199

Ruber stamped by Csaba Osztrogonác.

Temporary fix since the new member wastes a little space on
64 bit systems. Although it is harmless, it is only needed
for 32 bit systems.

  • heap/CopiedBlock.h:

(CopiedBlock):

05:33 Changeset [108778] by haraken@chromium.org

Move Worker-related APIs from DOMWindow.idl to DOMWindowWorker.idl
https://bugs.webkit.org/show_bug.cgi?id=79442

Reviewed by Adam Barth.

For WebKit modularization, this patch moves Worker-related APIs
from DOMWindow.idl to DOMWindowWorker.idl.

No tests. No change in behavior.

  • workers/DOMWindowWorker.idl: Added.
  • page/DOMWindow.idl:
  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • WebCore.gypi:
05:32 Changeset [108777] by carlosgc@webkit.org

[GTK] MiniBrowser should reload the view then the reload button is clicked
https://bugs.webkit.org/show_bug.cgi?id=79472

Reviewed by Philippe Normand.

  • MiniBrowser/gtk/BrowserWindow.c:

(reloadCallback): Call webkit_web_view_reload().
(browser_window_init): Connect reload item clicked even to
reloadCallback instead of activateUriEntryCallback.

05:30 Changeset [108776] by carlosgc@webkit.org

[GTK] Encode/decode Null ResourceResponse objects in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=79471

Reviewed by Philippe Normand.

  • Shared/gtk/WebCoreArgumentCodersGtk.cpp:

(CoreIPC::::encode): Check whether ResourceResponse is Null before
encoding it.
(CoreIPC::::decode): Check whether response is Null and create a
Null ResourceResponse object in such case.

05:03 Changeset [108775] by commit-queue@webkit.org

[BlackBerry] Upstream helper classes for skia
https://bugs.webkit.org/show_bug.cgi?id=79216

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-02-24
Reviewed by Antonio Gomes.

Initial upstreaming, no new tests.

  • platform/graphics/blackberry/skia/ImageBufferData.h: Added.

(WebCore):
(ImageBufferData):

  • platform/graphics/blackberry/skia/PlatformSupport.cpp: Added.

(WebCore):
(WebCore::setFontRenderStyleDefaults):
(WebCore::PlatformSupport::getRenderStyleForStrike):
(WebCore::PlatformSupport::getFontFamilyForCharacters):

  • platform/graphics/blackberry/skia/PlatformSupport.h: Added.

(WebCore):
(PlatformSupport):
(FontFamily):

04:39 Changeset [108774] by commit-queue@webkit.org

[BlackBerry] Upstream ImageBlackBerry in platform/graphics/blackberry
https://bugs.webkit.org/show_bug.cgi?id=79212

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-02-24
Reviewed by Antonio Gomes.

Initial upstreaming, no new tests.

  • PlatformBlackBerry.cmake:
  • platform/graphics/blackberry/ImageBlackBerry.cpp: Added.

(WebCore):
(WebCore::Image::loadPlatformResource):

04:34 Changeset [108773] by leo.yang@torchmobile.com.cn

[BlackBerry] Upstream the BlackBerry change to platform/graphics/IntSize.h
https://bugs.webkit.org/show_bug.cgi?id=79430

Reviewed by Antonio Gomes.

Add conversion convenience between WebCore::IntSize and BlackBerry::Platform::IntSize.

The porting can't be built yet, no new tests.

  • platform/graphics/IntSize.h:

(Platform):
(IntSize):

04:32 Changeset [108772] by shinyak@chromium.org

SpellCheckRequest needs to know the context where the spellcheck happened.
https://bugs.webkit.org/show_bug.cgi?id=79320

Reviewed by Hajime Morita.

Source/WebCore:

WebKit clients should be able to get the context how the spellcheck happended.
For example, WebKit clients may want to change the behavior by a spellcheck request is
invoked in typing or in pasting.

This patch added an enum in SpellCheckRequest so that WebKit clients can understand the context.

  • editing/Editor.cpp:

(WebCore::Editor::replaceSelectionWithFragment):
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):

  • editing/SpellChecker.cpp:

(WebCore::SpellCheckRequest::SpellCheckRequest):
(WebCore::SpellCheckRequest::create):
(WebCore::SpellChecker::invokeRequest):

  • editing/SpellChecker.h:

(SpellCheckRequest):
(WebCore::SpellCheckRequest::textCheckingRequest):
(WebCore::SpellCheckRequest::processType):

  • loader/EmptyClients.h:

(WebCore::EmptyTextCheckerClient::requestCheckingOfString):

  • platform/text/TextCheckerClient.h:

(WebCore):
(TextCheckerClient):

  • platform/text/TextChecking.h:

(TextCheckingRequest):
(WebCore::TextCheckingRequest::TextCheckingRequest):
(WebCore::TextCheckingRequest::setSequence):
(WebCore::TextCheckingRequest::sequence):
(WebCore::TextCheckingRequest::text):
(WebCore::TextCheckingRequest::mask):
(WebCore::TextCheckingRequest::processType):
(WebCore):

Source/WebKit/blackberry:

  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::requestCheckingOfString):

  • WebCoreSupport/EditorClientBlackBerry.h:

(EditorClientBlackBerry):

Source/WebKit/chromium:

  • src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::requestCheckingOfString):

  • src/EditorClientImpl.h:

(EditorClientImpl):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::requestTextChecking):

Source/WebKit/efl:

  • WebCoreSupport/EditorClientEfl.h:

(WebCore::EditorClientEfl::requestCheckingOfString):

Source/WebKit/gtk:

  • WebCoreSupport/TextCheckerClientGtk.h:

(WebKit::TextCheckerClientGtk::requestCheckingOfString):

Source/WebKit/mac:

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::requestCheckingOfString):

Source/WebKit/qt:

  • WebCoreSupport/TextCheckerClientQt.h:

(WebCore::TextCheckerClientQt::requestCheckingOfString):

Source/WebKit/win:

  • WebCoreSupport/WebEditorClient.h:

(WebEditorClient::requestCheckingOfString):
(WebEditorClient):

Source/WebKit/wince:

  • WebCoreSupport/EditorClientWinCE.h:

(WebKit::EditorClientWinCE::requestCheckingOfString):

Source/WebKit/wx:

  • WebKitSupport/EditorClientWx.h:

(WebCore::EditorClientWx::requestCheckingOfString):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::requestCheckingOfString):

  • WebProcess/WebCoreSupport/WebEditorClient.h:
04:09 Changeset [108771] by kenneth@webkit.org

[Qt] Tiling: Improve the method names dealing with moving and scaling.

Rubberstamped by Simon Hausmann.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewLegacyPrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebViewFlickablePrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::_q_commitScaleChange):
(QQuickWebViewPrivate::_q_commitPositionChange):
(QQuickWebViewFlickablePrivate::_q_resume):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):
(QQuickWebViewPrivate::_q_commitScaleChange):
(QQuickWebViewFlickablePrivate):

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::setVisibleContentsRectForScaling):
(WebKit::DrawingAreaProxy::setVisibleContentsRectForPanning):

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::setVisibleContentsRectForScaling):
(WebKit::DrawingAreaProxyImpl::setVisibleContentsRectForPanning):

  • UIProcess/DrawingAreaProxyImpl.h:

(DrawingAreaProxyImpl):

  • UIProcess/LayerTreeHostProxy.h:

(LayerTreeHostProxy):

  • UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::setVisibleContentsRectForPanning):
(WebKit::LayerTreeHostProxy::setVisibleContentsRectForScaling):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::ViewportUpdateDeferrer::~ViewportUpdateDeferrer):
(WebKit::QtViewportInteractionEngine::flickableMovingPositionUpdate):
(WebKit::QtViewportInteractionEngine::wheelEvent):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):

  • UIProcess/qt/QtViewportInteractionEngine.h:

(QtViewportInteractionEngine):

  • WebProcess/WebPage/LayerTreeHost.h:

(WebKit::LayerTreeHost::setVisibleContentsRectForScaling):
(WebKit::LayerTreeHost::setVisibleContentsRectForPanning):
(WebKit::LayerTreeHost::setVisibleContentsRectForLayer):

  • WebProcess/WebPage/LayerTreeHost.messages.in:
  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::setVisibleContentsRectForScaling):
(WebKit::LayerTreeHostQt::setVisibleContentsRectForPanning):

  • WebProcess/WebPage/qt/LayerTreeHostQt.h:

(LayerTreeHostQt):

04:02 Changeset [108770] by hayato@chromium.org

Make Node::showTreeForThis (and Node::showTreeForThisAcrossFrame) dump multiple shadow roots.
https://bugs.webkit.org/show_bug.cgi?id=79351

Reviewed by Dimitri Glazkov.

No new tests since these utility functions are only available in debug build.
I manually tested in GDB session.

  • dom/Node.cpp:

(WebCore::oldestShadowRootFor):
(WebCore::traverseTreeAndMark):
(WebCore::parentOrHostOrFrameOwner):
(WebCore::showSubTreeAcrossFrame):

  • dom/ShadowRoot.h:

(WebCore::ShadowRoot::youngerShadowRoot):
(WebCore::ShadowRoot::olderShadowRoot):
(WebCore::toShadowRoot):
(WebCore):

03:58 Changeset [108769] by pfeldman@chromium.org

Not reviewed: follow up to inspector's r108331, using more general condition.

Patch by Pavel Feldman <pfeldman@chromium.org> on 2012-02-24

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype._getPopoverAnchor):

03:57 Changeset [108768] by haraken@chromium.org

Move WebGL APIs from DOMWindow.idl to DOMWindowWebGL.idl
https://bugs.webkit.org/show_bug.cgi?id=79432

Reviewed by Adam Barth.

For WebKit modularization, this patch moves WebGL-related APIs
from DOMWindow.idl to DOMWindowWebGL.idl.

No tests. No change in behavior.

  • html/canvas/DOMWindowWebGL.idl: Added.
  • page/DOMWindow.idl:
  • DerivedSources.make: Added DOMWindowWebGL.idl.
  • DerivedSources.pri: Ditto.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
03:35 Changeset [108767] by vsevik@chromium.org

Web Inspector: [Regression] network worker tests crash on qt.
https://bugs.webkit.org/show_bug.cgi?id=79263

Reviewed by Pavel Feldman.

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::createDecoder):
(WebCore::InspectorPageAgent::cachedResourceContent):

03:25 Changeset [108766] by commit-queue@webkit.org

Convert some fast/regions pixel tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=78906

Patch by Flex Mobile <rhauck@adobe.com> on 2012-02-24
Reviewed by Hajime Morita.

  • fast/regions/float-pushed-width-change-expected.html: Added.
  • fast/regions/float-pushed-width-change.html:
  • platform/chromium/test_expectations.txt:
  • platform/efl/fast/regions/float-pushed-width-change-expected.png: Removed.
  • platform/efl/fast/regions/float-pushed-width-change-expected.txt: Removed.
  • platform/mac/fast/regions/float-pushed-width-change-expected.png: Removed.
  • platform/mac/fast/regions/float-pushed-width-change-expected.txt: Removed.
03:21 Changeset [108765] by kling@webkit.org

Miscellaneous CSSParser dodging in presentation attribute parsing.
<http://webkit.org/b/79468>

Reviewed by Antti Koivisto.

  • Bypass CSSParser when adding constant values to attribute styles.
  • Added fast paths for the valid HTMLTablePartElement align values.
  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::collectStyleForAttribute):

  • html/HTMLHRElement.cpp:

(WebCore::HTMLHRElement::collectStyleForAttribute):

  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::collectStyleForAttribute):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::collectStyleForAttribute):

  • html/HTMLTablePartElement.cpp:

(WebCore::HTMLTablePartElement::collectStyleForAttribute):

03:01 Changeset [108764] by commit-queue@webkit.org

[chromium] Avoid culling work for fully-non-opaque tiles, and add tracing for draw culling
https://bugs.webkit.org/show_bug.cgi?id=79183

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-24
Reviewed by James Robinson.

Addresses performance issues with draw culling by avoiding the work
of mapRect and other function calls when the quad has no opaque area.
And adds a TRACE_EVENT to watch the time spent in draw culling.

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::optimizeRenderPasses):

  • platform/graphics/chromium/cc/CCQuadCuller.cpp:

(WebCore::CCQuadCuller::cullOccludedQuads):

02:54 Changeset [108763] by commit-queue@webkit.org

[BlackBerry] Anchor mailto: with target set won't launch Messaging application when clicked
https://bugs.webkit.org/show_bug.cgi?id=79318

Need to give the client a chance to decide how to handle the new window request.

Patch by Charles Wei <charles.wei@torchmobile.com.cn> on 2012-02-24
Reviewed by Rob Buis.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNewWindowAction):

02:40 Changeset [108762] by commit-queue@webkit.org

[Chromium] video-referer.html fails
https://bugs.webkit.org/show_bug.cgi?id=79239

Fix error event race at startup and cleanup event code to take
advantage of more succinct video-test.js functionality; such as
waitForEventAndFail, etc.

Since this test uses a <source> element without a 'src' tag, an error
event gets fired during load. If we don't wait until after the <body>
onload fires, we'll pickup this error we don't care about.

Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-02-24
Reviewed by Eric Carlson.

  • http/tests/media/video-referer-expected.txt:
  • http/tests/media/video-referer.html:
  • platform/chromium/test_expectations.txt:
02:33 Changeset [108761] by zimmermann@webkit.org

2012-02-24 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Update layout test results after r108699.

  • platform/mac/svg/carto.net/tabgroup-expected.png:
  • platform/mac/svg/carto.net/tabgroup-expected.txt:
  • platform/mac/svg/carto.net/window-expected.png:
  • platform/mac/svg/carto.net/window-expected.txt:
  • platform/mac/svg/custom/circle-move-invalidation-expected.png:
  • platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.png:
  • platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
  • platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.txt:
  • platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.txt:
  • platform/mac/svg/custom/text-ctm-expected.png:
  • platform/mac/svg/custom/text-ctm-expected.txt:
  • platform/mac/svg/custom/use-detach-expected.png:
  • platform/mac/svg/custom/use-detach-expected.txt:
  • platform/mac/svg/hixie/perf/003-expected.png:
  • platform/mac/svg/hixie/perf/003-expected.txt:
02:20 WebKitGTK/1.8.x edited by sergio@webkit.org
(diff)
02:19 Changeset [108760] by sergio@webkit.org

[WK2] [GTK] Destructor not invoked in EditorClientFrameDestructionObserver
https://bugs.webkit.org/show_bug.cgi?id=79466

Reviewed by Philippe Normand.

Explicitly cast the observer before deleting it instead of just
deleting a generic pointer. We must to that in order to get the
destructor of the object properly called.

  • WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:

(WebKit::EditorClientFrameDestructionObserver::destroyOnClosureFinalization):

02:12 Changeset [108759] by vsevik@chromium.org

Web Inspector: Scripts panel navigator overlay should be shown automatically only one time.
https://bugs.webkit.org/show_bug.cgi?id=79467

Reviewed by Pavel Feldman.

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._hideNavigatorOverlay):
(WebInspector.ScriptsPanel.prototype._navigatorOverlayWillHide):

01:59 Changeset [108758] by morrita@google.com

Adding a ShadowRoot to image-backed element causes a crash
https://bugs.webkit.org/show_bug.cgi?id=78878

Reviewed by Dimitri Glazkov.

Source/WebCore:

The crash happened because NodeRenderingContext tried to append a
child to a renderer regardless one isn't capable of holding any
children if it appears in the shadow attaching phase. RenderImage
is one of such renderer classes which aren't capable.

NodeRenderingContext decide whether the contextual node as a child
can create its renderer based on RenderObject::canHaveChildren()
and Node::childShouldCreateRenderer(). But the responsibility
between these two methods are getting confused. which results this
unfortuante crash path.

This change re-aligns the responsibility:

  • Now canHaveChildren() purely declares the ability of the renderer. If the renderer is capable of having children, it return true regardless of HTML semantics.
  • On the other hand, childShouldCreateRenderer() cares about the semantics. If the element doesn't allow children to be rendered, this returns false.
  • Note that these decision on elements are contextual. Each element needs to know which role it is playing in the tree composition algorithm of Shadow DOM. That's why the method parameter is changed from Node* to NodeRenderingContext.
  • Fixed updateFirstLetter() which relied on this confused assumption. This change introduces RenderDeprecatedFlexibleBox::buttonText() to refine the relying assumption.

With this change, some decision points are moved from a renderer to an
element. Following renderers no longer stop reject having children:

  • RenderButton, RenderListBox, RenderMenuList, RenderMeter, RenderProgress, RenderTextControl.

Corresponding element for such a render (HTMLProgressElement of
RenderProgress for exaple) now cares about that.

Reviewed by Dimitri Glazkov.

Tests: fast/dom/shadow/shadow-on-image-expected.html

fast/dom/shadow/shadow-on-image.html

  • dom/Element.cpp:

(WebCore::Element::childShouldCreateRenderer):

  • dom/Element.h:

(Element):

  • dom/Node.h:

(WebCore::Node::childShouldCreateRenderer):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::shouldCreateRenderer):

  • dom/NodeRenderingContext.h:

(NodeRenderingContext):
(WebCore::NodeRenderingContext::isOnEncapsulationBoundary):
(WebCore):

  • html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::childShouldCreateRenderer):

  • html/HTMLDetailsElement.h:

(HTMLDetailsElement):

  • html/HTMLMediaElement.cpp:

(WebCore):
(WebCore::HTMLMediaElement::childShouldCreateRenderer):

  • html/HTMLMediaElement.h:

(HTMLMediaElement):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::childShouldCreateRenderer):
(WebCore):

  • html/HTMLMeterElement.h:

(HTMLMeterElement):

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::childShouldCreateRenderer):
(WebCore):

  • html/HTMLProgressElement.h:

(HTMLProgressElement):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::childShouldCreateRenderer):
(WebCore):

  • html/HTMLSelectElement.h:

(HTMLSelectElement):

  • html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::childShouldCreateRenderer):
(WebCore):

  • html/HTMLSummaryElement.h:

(HTMLSummaryElement):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::childShouldCreateRenderer):
(WebCore):

  • html/HTMLTextFormControlElement.h:

(HTMLTextFormControlElement):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetter):

  • rendering/RenderButton.cpp:
  • rendering/RenderButton.h:

(RenderButton):

  • rendering/RenderDeprecatedFlexibleBox.h:

(WebCore::RenderDeprecatedFlexibleBox::buttonText):

  • rendering/RenderListBox.h:

(RenderListBox):

  • rendering/RenderMedia.h:

(WebCore::RenderMedia::canHaveChildren):

  • rendering/RenderMenuList.h:

(RenderMenuList):
(WebCore::RenderMenuList::hasControlClip):

  • rendering/RenderMeter.h:
  • rendering/RenderProgress.h:
  • rendering/RenderTextControl.h:
  • rendering/svg/RenderSVGRoot.h:

(WebCore::RenderSVGRoot::canHaveChildren):

  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::childShouldCreateRenderer):

  • svg/SVGAElement.h:

(SVGAElement):

  • svg/SVGAltGlyphElement.cpp:

(WebCore::SVGAltGlyphElement::childShouldCreateRenderer):

  • svg/SVGAltGlyphElement.h:

(SVGAltGlyphElement):

  • svg/SVGDocument.cpp:

(WebCore::SVGDocument::childShouldCreateRenderer):

  • svg/SVGDocument.h:

(SVGDocument):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::childShouldCreateRenderer):

  • svg/SVGElement.h:

(SVGElement):

  • svg/SVGForeignObjectElement.cpp:

(WebCore::SVGForeignObjectElement::childShouldCreateRenderer):

  • svg/SVGForeignObjectElement.h:

(SVGForeignObjectElement):

  • svg/SVGSwitchElement.cpp:

(WebCore::SVGSwitchElement::childShouldCreateRenderer):

  • svg/SVGSwitchElement.h:

(SVGSwitchElement):

  • svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::childShouldCreateRenderer):

  • svg/SVGTRefElement.h:

(SVGTRefElement):

  • svg/SVGTSpanElement.cpp:

(WebCore::SVGTSpanElement::childShouldCreateRenderer):

  • svg/SVGTSpanElement.h:

(SVGTSpanElement):

  • svg/SVGTextElement.cpp:

(WebCore::SVGTextElement::childShouldCreateRenderer):

  • svg/SVGTextElement.h:

(SVGTextElement):

  • svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::childShouldCreateRenderer):

  • svg/SVGTextPathElement.h:

LayoutTests:

  • fast/dom/shadow/shadow-on-image-expected.html: Added.
  • fast/dom/shadow/shadow-on-image.html: Added.
01:56 Changeset [108757] by haraken@chromium.org

Support [Supplemental] on static methods
https://bugs.webkit.org/show_bug.cgi?id=79357

Reviewed by Adam Barth.

[Supplemental] on static methods does not work in CodeGeneratorJS.pm
and CodeGeneratorV8.pm due to mis-ordered if-elsif statements.
This patch fixes it and supports [Supplemental] on static methods.

Test: bindings/scripts/test/TestSupplemental.idl

  • bindings/scripts/CodeGeneratorJS.pm: Modified as described above.

(GenerateParametersCheck):

  • bindings/scripts/CodeGeneratorV8.pm: Ditto.

(GenerateFunctionCallString):

  • bindings/scripts/test/TestSupplemental.idl: Added a test case.
  • bindings/scripts/test/CPP/WebDOMTestInterface.cpp: Updated run-bindings-tests results.

(WebDOMTestInterface::supplementalMethod4):

  • bindings/scripts/test/CPP/WebDOMTestInterface.h: Ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp: Ditto.

(webkit_dom_test_interface_supplemental_method4):

  • bindings/scripts/test/GObject/WebKitDOMTestInterface.h: Ditto.
  • bindings/scripts/test/JS/JSTestInterface.cpp: Ditto.

(WebCore):
(WebCore::JSTestInterfaceConstructor::getOwnPropertySlot):
(WebCore::JSTestInterfaceConstructor::getOwnPropertyDescriptor):
(WebCore::jsTestInterfaceConstructorFunctionSupplementalMethod4):

  • bindings/scripts/test/JS/JSTestInterface.h: Ditto.

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestInterface.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestInterface.mm: Ditto.

(-[DOMTestInterface supplementalMethod4]):

  • bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.

(TestInterfaceInternal):
(WebCore::TestInterfaceInternal::supplementalMethod4Callback):
(WebCore::ConfigureV8TestInterfaceTemplate):

01:53 Changeset [108756] by bashi@chromium.org

[Qt] Unreviewed gardening.

Remove tests introduced in r108731 but rolled out.

  • platform/qt/Skipped: Removed rolled out tests.
01:53 Changeset [108755] by tony@chromium.org

Small refactor in RenderFlexibleBox::layoutAndPlaceChildren
https://bugs.webkit.org/show_bug.cgi?id=79420

Reviewed by Ojan Vafai.

No new tests, just a refactor.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Share some of the logic
in computing the cross axis length.

01:50 Changeset [108754] by yurys@chromium.org

Web Inspector: cannot drag timeline overview window when clicking inside the window
https://bugs.webkit.org/show_bug.cgi?id=79453

Reviewed by Pavel Feldman.

  • inspector/front-end/timelinePanel.css:

(.timeline-overview-window-rulers):

01:49 Changeset [108753] by commit-queue@webkit.org

Remove useless jump instructions for short circuit
https://bugs.webkit.org/show_bug.cgi?id=75602

Patch by Han Hojong <hojong.han@samsung.com> on 2012-02-24
Reviewed by Michael Saboff.

Jump instruction is inserted to make short circuit,
however it does nothing but moving to the next instruction.
Therefore useless jump instructions are removed,
and jump list is moved into the case not for a short circuit,
so that only necessary instructions are added to JIT code
unless it has a 16 bit pattern character and an 8 bit string.

  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::generatePatternCharacterGreedy):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterNonGreedy):

01:47 Changeset [108752] by bashi@chromium.org

Unreviewed, rolling out r108731.
http://trac.webkit.org/changeset/108731
https://bugs.webkit.org/show_bug.cgi?id=79464

Broke Chromium Win tests (Requested by bashi on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-24

Source/JavaScriptCore:

  • wtf/Platform.h:

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • websockets/WebSocket.cpp:

(WebCore::WebSocket::didConnect):

  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::connect):
(WebCore::WebSocketChannel::fail):
(WebCore::WebSocketChannel::processFrame):
(WebCore::WebSocketChannel::sendFrame):

  • websockets/WebSocketChannel.h:
  • websockets/WebSocketDeflateFramer.cpp: Removed.
  • websockets/WebSocketDeflateFramer.h: Removed.

LayoutTests:

  • http/tests/websocket/tests/hybi/compressed-control-frame-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/compressed-control-frame.html: Removed.
  • http/tests/websocket/tests/hybi/compressed-control-frame_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff.html: Removed.
  • http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter.html: Removed.
  • http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/deflate-frame-parameter-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/deflate-frame-parameter.html: Removed.
  • http/tests/websocket/tests/hybi/deflate-frame_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header-expected.txt:
  • http/tests/websocket/tests/hybi/send-file-blob_wsh.py:

(web_socket_transfer_data):

01:41 Changeset [108751] by vsevik@chromium.org

Web Inspector: Show scripts panel navigator overlay on the first scripts panel opening.
https://bugs.webkit.org/show_bug.cgi?id=79248

Reviewed by Pavel Feldman.

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.wasShown):
(WebInspector.ScriptsPanel.prototype.set _showNavigatorOverlay):
(WebInspector.ScriptsPanel.prototype._hideNavigatorOverlay):

01:33 Changeset [108750] by mikelawther@chromium.org

CSS3 calc(): handle non-negative values
https://bugs.webkit.org/show_bug.cgi?id=79188

Reviewed by Daniel Bates.

Source/WebCore:

Some CSS properties (e.g. padding) are required to be non-negative. These
are now restricted to the correct range.

Tests: css3/calc/negative-padding-expected.html

css3/calc/negative-padding.html

  • css/CSSCalculationValue.cpp:

(WebCore):
(WebCore::CSSCalcValue::clampToPermittedRange): Added
(WebCore::CSSCalcValue::doubleValue):
(WebCore::CSSCalcValue::isNegative): Added
(WebCore::CSSCalcValue::computeLengthPx):
(WebCore::CSSCalcValue::create):

  • css/CSSCalculationValue.h:

(CSSCalcValue):
(WebCore::CSSCalcValue::CSSCalcValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::validCalculationUnit):
(WebCore::CSSParser::parseCalculation):

  • css/CSSParser.h:
  • platform/CalculationValue.h:

LayoutTests:

  • css3/calc/negative-padding-expected.html: Added.
  • css3/calc/negative-padding.html: Added.
01:31 Changeset [108749] by vsevik@chromium.org

Web Inspector: [Regression] xhr tests are crashing after r108506.
https://bugs.webkit.org/show_bug.cgi?id=79265

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::setInitialScriptContent):
(WebCore::InspectorResourceAgent::setInitialXHRContent):

LayoutTests:

  • platform/chromium/test_expectations.txt:
00:55 Changeset [108748] by haraken@chromium.org

Add performance tests for DOM attribute getters and setters
https://bugs.webkit.org/show_bug.cgi?id=79208

Reviewed by Ryosuke Niwa.

PerformanceTests:

This patch adds performance micro-benchmarks for DOM attribute
getters and setters. We selected DOM attributes from HTMLElement,
Element and Node which will most impact on the DOM performance
in the real Web and which have different call-paths from another
DOM attribute.

The perf test result in my local Chromium/Linux environment is as follows:
median= 14967.0 ms, stdev= 85.2385476178 ms, min= 14861.0 ms, max= 15155.0 ms

If we run the test with DumpRenderTree, we can get the following test results:
Info: [HTMLElement.id] avg=65.76ms, median=65.00ms, stdev=2.14ms, min=63, max=70
Info: [HTMLElement.title] avg=64.05ms, median=63.00ms, stdev=1.50ms, min=63, max=67
Info: [HTMLElement.lang] avg=64.19ms, median=63.00ms, stdev=1.82ms, min=62, max=67
Info: [HTMLElement.dir] avg=64.10ms, median=63.00ms, stdev=1.72ms, min=62, max=68
Info: [HTMLElement.className] avg=63.33ms, median=63.00ms, stdev=0.89ms, min=63, max=67
Info: [HTMLElement.classList] avg=1946.00ms, median=1945.00ms, stdev=38.22ms, min=1921, max=2110
Info: [HTMLElement.tabIndex] avg=83.52ms, median=80.00ms, stdev=6.00ms, min=79, max=94
Info: [HTMLElement.draggable] avg=78.14ms, median=81.00ms, stdev=3.51ms, min=74, max=82
Info: [HTMLElement.webkitdropzone] avg=64.33ms, median=63.00ms, stdev=1.98ms, min=63, max=68
Info: [HTMLElement.hidden] avg=65.57ms, median=64.00ms, stdev=3.27ms, min=63, max=71
Info: [HTMLElement.accessKey] avg=64.43ms, median=63.00ms, stdev=2.11ms, min=62, max=68
Info: [HTMLElement.children] avg=130.76ms, median=128.00ms, stdev=9.75ms, min=109, max=143
Info: [HTMLElement.isContentEditable] avg=74.29ms, median=75.00ms, stdev=2.00ms, min=71, max=77
Info: [HTMLElement.spellcheck] avg=79.52ms, median=80.00ms, stdev=2.52ms, min=76, max=82
Info: [HTMLElement.innerHTML] avg=279.05ms, median=279.00ms, stdev=1.96ms, min=276, max=283
Info: [HTMLElement.innerText] avg=204.14ms, median=203.00ms, stdev=2.95ms, min=200, max=210
Info: [HTMLElement.outerHTML] avg=1544.10ms, median=1546.00ms, stdev=15.56ms, min=1514, max=1568
Info: [HTMLElement.outerText] avg=216.05ms, median=207.00ms, stdev=18.19ms, min=201, max=247
Info: [HTMLElement.contentEditable] avg=334.24ms, median=323.00ms, stdev=36.06ms, min=318, max=446
Info: [HTMLElement.id="foo"] avg=53.19ms, median=53.00ms, stdev=1.76ms, min=52, max=58
Info: [HTMLElement.title="foo"] avg=63.14ms, median=63.00ms, stdev=0.35ms, min=63, max=64
Info: [HTMLElement.lang="foo"] avg=60.86ms, median=61.00ms, stdev=0.56ms, min=60, max=62
Info: [HTMLElement.dir="foo"] avg=53.57ms, median=54.00ms, stdev=0.58ms, min=53, max=55
Info: [HTMLElement.className="foo"] avg=64.52ms, median=64.00ms, stdev=0.91ms, min=63, max=66
Info: [HTMLElement.tabIndex="foo"] avg=367.86ms, median=369.00ms, stdev=8.06ms, min=352, max=380
Info: [HTMLElement.draggable="foo"] avg=79.43ms, median=79.00ms, stdev=0.58ms, min=79, max=81
Info: [HTMLElement.webkitdropzone="foo"] avg=62.14ms, median=62.00ms, stdev=0.35ms, min=62, max=63
Info: [HTMLElement.hidden="foo"] avg=61.67ms, median=62.00ms, stdev=0.71ms, min=61, max=64
Info: [HTMLElement.accessKey="foo"] avg=61.86ms, median=62.00ms, stdev=0.56ms, min=61, max=63
Info: [HTMLElement.spellcheck="foo"] avg=79.57ms, median=80.00ms, stdev=0.58ms, min=78, max=80
Info: [HTMLElement.innerHTML="foo"] avg=1176.67ms, median=1169.00ms, stdev=26.60ms, min=1146, max=1246
Info: [HTMLElement.innerText="foo"] avg=51.62ms, median=52.00ms, stdev=0.72ms, min=50, max=53
Info: [Element.tagName] avg=79.52ms, median=80.00ms, stdev=1.05ms, min=78, max=81
Info: [Element.style] avg=126.19ms, median=126.00ms, stdev=10.40ms, min=104, max=161
Info: [Element.offsetLeft] avg=98.95ms, median=104.00ms, stdev=4.01ms, min=100, max=99
Info: [Element.clientLeft] avg=98.33ms, median=102.00ms, stdev=2.59ms, min=100, max=99
Info: [Element.scrollLeft] avg=103.29ms, median=96.00ms, stdev=15.63ms, min=100, max=97
Info: [Element.dataset] avg=2448.62ms, median=2441.00ms, stdev=20.43ms, min=2426, max=2503
Info: [Element.firstElementChild] avg=58.71ms, median=58.00ms, stdev=2.37ms, min=57, max=65
Info: [Element.lastElementChild] avg=56.33ms, median=55.00ms, stdev=1.83ms, min=54, max=59
Info: [Element.previousElementSibling] avg=52.95ms, median=52.00ms, stdev=1.70ms, min=52, max=57
Info: [Element.nextElementSibling] avg=58.48ms, median=58.00ms, stdev=1.79ms, min=57, max=63
Info: [Element.childElementCount] avg=64.57ms, median=64.00ms, stdev=1.81ms, min=63, max=71
Info: [Element.onload] avg=98.38ms, median=98.00ms, stdev=0.49ms, min=98, max=99
Info: [Element.scrollLeft="foo"] avg=95.24ms, median=95.00ms, stdev=0.92ms, min=94, max=98
Info: [Element.onload="foo"] avg=67.14ms, median=67.00ms, stdev=0.56ms, min=66, max=68
Info: [Node.nodeName] avg=76.29ms, median=76.00ms, stdev=0.63ms, min=75, max=77
Info: [Node.nodeType] avg=53.05ms, median=52.00ms, stdev=2.61ms, min=52, max=61
Info: [Node.parentNode] avg=53.52ms, median=53.00ms, stdev=1.22ms, min=52, max=56
Info: [Node.childNodes] avg=118.33ms, median=123.00ms, stdev=8.85ms, min=107, max=129
Info: [Node.firstChild] avg=53.62ms, median=53.00ms, stdev=1.13ms, min=51, max=55
Info: [Node.lastChild] avg=53.14ms, median=53.00ms, stdev=1.21ms, min=52, max=55
Info: [Node.previousSibling] avg=51.86ms, median=51.00ms, stdev=1.55ms, min=50, max=54
Info: [Node.nextSibling] avg=52.86ms, median=54.00ms, stdev=1.81ms, min=50, max=55
Info: [Node.attributes] avg=2027.71ms, median=2026.00ms, stdev=10.48ms, min=2010, max=2051
Info: [Node.ownerDocument] avg=152.14ms, median=152.00ms, stdev=1.73ms, min=149, max=155
Info: [Node.namespaceURI] avg=60.86ms, median=59.00ms, stdev=3.85ms, min=56, max=66
Info: [Node.localName] avg=60.00ms, median=59.00ms, stdev=2.71ms, min=57, max=66
Info: [Node.baseURI] avg=671.10ms, median=668.00ms, stdev=10.66ms, min=659, max=706
Info: [Node.parentElement] avg=55.05ms, median=56.00ms, stdev=2.15ms, min=52, max=58
Info: [Node.nodeValue] avg=61.24ms, median=60.00ms, stdev=2.56ms, min=59, max=68
Info: [Node.prefix] avg=60.90ms, median=58.00ms, stdev=4.26ms, min=57, max=68
Info: [Node.textContent] avg=149.71ms, median=149.00ms, stdev=1.12ms, min=148, max=152
Info: [Node.nodeValue="foo"] avg=23.62ms, median=23.00ms, stdev=0.72ms, min=23, max=25
Info: [Node.prefix="foo"] avg=49.57ms, median=49.00ms, stdev=0.73ms, min=49, max=51
Info: [Node.textContent="foo"] avg=145.81ms, median=140.00ms, stdev=17.43ms, min=138, max=199

  • Bindings/dom_attributes.html: Added.
  • resources/runner.js:

(PerfTestRunner.info):

Tools:

We want to allow perf tests to output info messages
that do not affect the test results. To accomplish this,
this patch modifies perftestsrunner.py so that it ignores
a line that starts from "Info:".

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner):

00:42 Changeset [108747] by commit-queue@webkit.org

[BlackBerry] Enable requestAnimationFrame
https://bugs.webkit.org/show_bug.cgi?id=79408

Source/JavaScriptCore:

Use timer implementation of requestAnimationFrame on BlackBerry.

Patch by Andrew Lo <anlo@rim.com> on 2012-02-24
Reviewed by Rob Buis.

  • wtf/Platform.h:

Tools:

Enable requestAnimationFrame for BlackBerry.

Patch by Andrew Lo <anlo@rim.com> on 2012-02-24
Reviewed by Rob Buis.

  • Scripts/build-webkit:
00:38 Changeset [108746] by commit-queue@webkit.org

Rename LocalStorageThread to StorageThread and LocalStorageTask to StorageTask.
https://bugs.webkit.org/show_bug.cgi?id=79358

Revision 45124 commented FIXME to rename these classes.

Patch by Huang Dongsung <luxtella@company100.net> on 2012-02-24
Reviewed by Kentaro Hara.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • storage/LocalStorageTask.h: Removed.
  • storage/StorageSyncManager.cpp:

(WebCore::StorageSyncManager::StorageSyncManager):
(WebCore::StorageSyncManager::scheduleImport):
(WebCore::StorageSyncManager::scheduleSync):
(WebCore::StorageSyncManager::scheduleDeleteEmptyDatabase):

  • storage/StorageSyncManager.h:

(WebCore):
(StorageSyncManager):

  • storage/StorageTask.cpp: Renamed from Source/WebCore/storage/LocalStorageTask.cpp.

(WebCore):
(WebCore::StorageTask::StorageTask):
(WebCore::StorageTask::~StorageTask):
(WebCore::StorageTask::performTask):

  • storage/StorageTask.h: Added.

(WebCore):
(StorageTask):
(WebCore::StorageTask::createImport):
(WebCore::StorageTask::createSync):
(WebCore::StorageTask::createDeleteEmptyDatabase):
(WebCore::StorageTask::createOriginIdentifiersImport):
(WebCore::StorageTask::createSetOriginDetails):
(WebCore::StorageTask::createDeleteOrigin):
(WebCore::StorageTask::createDeleteAllOrigins):
(WebCore::StorageTask::createTerminate):

  • storage/StorageThread.cpp: Renamed from Source/WebCore/storage/LocalStorageThread.cpp.

(WebCore):
(WebCore::StorageThread::create):
(WebCore::StorageThread::StorageThread):
(WebCore::StorageThread::~StorageThread):
(WebCore::StorageThread::start):
(WebCore::StorageThread::threadEntryPointCallback):
(WebCore::StorageThread::threadEntryPoint):
(WebCore::StorageThread::scheduleTask):
(WebCore::StorageThread::terminate):
(WebCore::StorageThread::performTerminate):

  • storage/StorageThread.h: Renamed from Source/WebCore/storage/LocalStorageThread.h.

(WebCore):
(StorageThread):

  • storage/StorageTracker.cpp:

(WebCore::StorageTracker::StorageTracker):
(WebCore::StorageTracker::importOriginIdentifiers):
(WebCore::StorageTracker::setOriginDetails):
(WebCore::StorageTracker::scheduleTask):
(WebCore::StorageTracker::deleteAllOrigins):
(WebCore::StorageTracker::deleteOrigin):

  • storage/StorageTracker.h:

(WebCore):
(StorageTracker):

  • storage/wince/StorageThreadWinCE.cpp: Renamed from Source/WebCore/storage/wince/LocalStorageThreadWinCE.cpp.

(WebCore):
(WebCore::StorageThread::StorageThread):
(WebCore::StorageThread::~StorageThread):
(WebCore::StorageThread::start):
(WebCore::StorageThread::timerFired):
(WebCore::StorageThread::scheduleImport):
(WebCore::StorageThread::scheduleSync):
(WebCore::StorageThread::terminate):
(WebCore::StorageThread::performTerminate):

  • storage/wince/StorageThreadWinCE.h: Renamed from Source/WebCore/storage/wince/LocalStorageThreadWinCE.h.

(WebCore):
(StorageThread):
(WebCore::StorageThread::create):

00:34 Changeset [108745] by pfeldman@chromium.org

Web Inspector: prepare border images on timelines to enable zooming.
https://bugs.webkit.org/show_bug.cgi?id=79360

Reviewed by Yury Semikhatsky.

  • inspector/front-end/Images/timelineBarBlue.png:
  • inspector/front-end/Images/timelineBarGray.png:
  • inspector/front-end/Images/timelineBarGreen.png:
  • inspector/front-end/Images/timelineBarOrange.png:
  • inspector/front-end/Images/timelineBarPurple.png:
  • inspector/front-end/Images/timelineBarRed.png:
  • inspector/front-end/Images/timelineBarYellow.png:
  • inspector/front-end/Images/timelineHollowPillBlue.png:
  • inspector/front-end/Images/timelineHollowPillGray.png:
  • inspector/front-end/Images/timelineHollowPillGreen.png:
  • inspector/front-end/Images/timelineHollowPillOrange.png:
  • inspector/front-end/Images/timelineHollowPillPurple.png:
  • inspector/front-end/Images/timelineHollowPillRed.png:
  • inspector/front-end/Images/timelineHollowPillYellow.png:
  • inspector/front-end/Images/timelinePillBlue.png:
  • inspector/front-end/Images/timelinePillGray.png:
  • inspector/front-end/Images/timelinePillGreen.png:
  • inspector/front-end/Images/timelinePillOrange.png:
  • inspector/front-end/Images/timelinePillPurple.png:
  • inspector/front-end/Images/timelinePillRed.png:
  • inspector/front-end/Images/timelinePillYellow.png:
  • inspector/front-end/inspectorCommon.css:

(body):

  • inspector/front-end/networkLogView.css:

(.network-graph-bar):
(.resource-cached .network-graph-bar):
(.network-category-documents .network-graph-bar):
(.network-category-documents.resource-cached .network-graph-bar):
(.network-category-stylesheets .network-graph-bar):
(.network-category-stylesheets.resource-cached .network-graph-bar):
(.network-category-images.resource-cached .network-graph-bar):
(.network-category-fonts .network-graph-bar):
(.network-category-fonts.resource-cached .network-graph-bar):
(.network-category-scripts .network-graph-bar):
(.network-category-scripts.resource-cached .network-graph-bar):
(.network-category-xhr .network-graph-bar):
(.network-category-xhr.resource-cached .network-graph-bar):
(.network-category-websockets .network-graph-bar):
(.network-category-websockets.resource-cached .network-graph-bar):

00:33 Changeset [108744] by abarth@webkit.org

style-queue tries to apply the patch twice
https://bugs.webkit.org/show_bug.cgi?id=79459

Reviewed by Eric Seidel.

Previously, we applied the patch using both apply-patch and
check-style. This patch introduces a check-style-local to mirror the
apply-watchlist-local, which operates on the current working diff.

This patch also cleans up some other bugs I found by running the queue
locally for a while. The queue still prints out a slightly
less-than-ideal message on the bugs when it find an error, but it's ok
for now. We'll need to iterate a bit.

  • Scripts/webkitpy/tool/bot/stylequeuetask.py:

(StyleQueueTask.validate):
(StyleQueueTask._check_style):

  • Scripts/webkitpy/tool/commands/download.py:

(CheckStyleLocal):

  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

(EarlyWarningSytemTest._default_expected_stderr):
(EarlyWarningSytemTest._test_testing_ews):

  • Scripts/webkitpy/tool/commands/queues.py:

(AbstractReviewQueue.handle_script_error):
(StyleQueue.review_patch):

  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/queuestest.py:

(QueuesTest.assert_queue_outputs):

00:28 Changeset [108743] by yurys@chromium.org

Web Inspector: exception in front-end on selecting an element in heap snapshot
https://bugs.webkit.org/show_bug.cgi?id=79447

Fixed a typo in method name and added a check that selected node has
corresponding heap snapshot object before adding that object to the console
as $0 entry.

Reviewed by Pavel Feldman.

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype._inspectedObjectChanged):

00:20 Changeset [108742] by commit-queue@webkit.org

\u200c and \u200d should be allowed in IdentifierPart, as per ES5
https://bugs.webkit.org/show_bug.cgi?id=78908

Source/JavaScriptCore:

Add additional checks for zero-width non-joiner (0x200C) and
zero-width joiner (0x200D) characters.

Patch by Mathias Bynens <mathias@qiwi.be> on 2012-02-24
Reviewed by Michael Saboff.

  • parser/Lexer.cpp:

(JSC::isNonASCIIIdentPart)

  • runtime/LiteralParser.cpp:

(JSC::::Lexer::lexIdentifier)

LayoutTests:

Patch by Mathias Bynens <mathias@qiwi.be> on 2012-02-24
Reviewed by Michael Saboff.

  • fast/js/var-declarations-zero-width-expected.txt: Added.
  • fast/js/var-declarations-zero-width.html: Added.
  • fast/js/removing-Cf-characters-expected.txt: Removed the ZWJ test.
  • fast/js/script-tests/removing-Cf-characters.js: Removed the ZWJ test.
  • fast/js/script-tests/var-declarations-zero-width.js: Added.
  • platform/chromium/test_expectations.txt: Disable the new test in Chromium, for now.
00:17 Changeset [108741] by yuzo@google.com

[chromium] Unreviewed test expectation change.
svg/repaint/image-with-clip-path.svg is flaky for DEBUG builds.

  • platform/chromium/test_expectations.txt:
00:11 Changeset [108740] by yuzo@google.com

[chromium] Unreviewed test expectation change.
svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm is flaky for DEBUG builds.

  • platform/chromium/test_expectations.txt:
00:00 Changeset [108739] by ossy@webkit.org

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Skip failing tests.

02/23/12:

23:58 Changeset [108738] by yuzo@google.com

[chromium] Unreviewed test expectation change.
svg/text/text-rescale.html and svg/text/text-viewbox-rescale.html
are failing on Win, Linux, and Mac since added by wk r108699.

  • platform/chromium/test_expectations.txt:
23:52 Changeset [108737] by abarth@webkit.org

should_proceed_with_work_item is unused and can be removed
https://bugs.webkit.org/show_bug.cgi?id=79416

Reviewed by Eric Seidel.

We used to use this function to check whether the tree is red. Now, we
don't use external measures of whether to proceed with work items.
Instead, we analyze them with the idea in mind that the tree might be
red.

  • Scripts/webkitpy/tool/bot/queueengine.py:

(QueueEngineDelegate.next_work_item):
(QueueEngine.run):

  • Scripts/webkitpy/tool/bot/queueengine_unittest.py:

(LoggingDelegate):
(LoggingDelegate.next_work_item):
(RaisingDelegate.process_work_item):
(QueueEngineTest.test_terminating_error):

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(AbstractEarlyWarningSystem.init):

  • Scripts/webkitpy/tool/commands/queues.py:

(AbstractQueue.next_work_item):
(FeederQueue.next_work_item):
(CommitQueue.next_work_item):
(AbstractReviewQueue.next_work_item):
(StyleQueue.init):

  • Scripts/webkitpy/tool/commands/queues_unittest.py:

(FeederQueueTest.test_feeder_queue):
(CommitQueueTest.test_commit_queue):
(test_commit_queue_failure):
(test_commit_queue_failure_with_failing_tests):
(test_rollout):
(test_rollout_lands):
(StyleQueueTest.test_style_queue_with_style_exception):
(test_style_queue_with_watch_list_exception):

  • Scripts/webkitpy/tool/commands/queuestest.py:

(QueuesTest.assert_queue_outputs):

  • Scripts/webkitpy/tool/commands/sheriffbot.py:

(SheriffBot.next_work_item):

23:49 Changeset [108736] by ossy@webkit.org

[Qt] Unreviewed morning gardening.

  • platform/qt/Skipped:
  • platform/qt/fast/block/float/centered-float-avoidance-complexity-expected.png: Added.
  • platform/qt/fast/block/float/centered-float-avoidance-complexity-expected.txt: Added.
  • platform/qt/fast/block/float/shrink-to-avoid-float-complexity-expected.png: Added.
  • platform/qt/fast/block/float/shrink-to-avoid-float-complexity-expected.txt: Added.
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.png:
  • platform/qt/fast/js/global-constructors-expected.txt:
  • platform/qt/fast/repaint/region-painting-invalidation-expected.png: Added.
  • platform/qt/fast/repaint/region-painting-invalidation-expected.txt: Added.
  • platform/qt/svg/carto.net/window-expected.png:
  • platform/qt/svg/carto.net/window-expected.txt:
  • platform/qt/svg/custom/js-late-clipPath-and-object-creation-expected.png:
  • platform/qt/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
  • platform/qt/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/qt/svg/custom/js-late-gradient-and-object-creation-expected.txt:
  • platform/qt/svg/custom/pointer-events-text-css-transform-expected.png:
  • platform/qt/svg/custom/pointer-events-text-css-transform-expected.txt:
  • platform/qt/svg/custom/text-ctm-expected.png:
  • platform/qt/svg/custom/text-ctm-expected.txt:
  • platform/qt/svg/hixie/perf/003-expected.png:
  • platform/qt/svg/hixie/perf/003-expected.txt:
  • platform/qt/svg/text/ems-display-none-expected.png: Added.
  • platform/qt/svg/text/ems-display-none-expected.txt: Added.
  • platform/qt/svg/text/exs-display-none-expected.png: Added.
  • platform/qt/svg/text/exs-display-none-expected.txt: Added.
  • platform/qt/svg/text/text-fill-opacity-expected.png: Added.
  • platform/qt/svg/text/text-fill-opacity-expected.txt: Added.
  • platform/qt/svg/text/text-viewbox-rescale-expected.png: Added.
  • platform/qt/svg/text/text-viewbox-rescale-expected.txt: Added.
  • platform/qt/svg/text/tspan-dynamic-positioning-expected.png: Added.
  • platform/qt/svg/text/tspan-dynamic-positioning-expected.txt: Added.
23:37 Changeset [108735] by pfeldman@chromium.org

Web Inspector: hide color picker upon panel switch.
https://bugs.webkit.org/show_bug.cgi?id=79355

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.willHide):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._showUserAgentStylesSettingChanged):
(WebInspector.StylesSidebarPane.prototype.willHide):

23:28 Changeset [108734] by pfeldman@chromium.org

Web Inspector: make color review larger in the color picker.
https://bugs.webkit.org/show_bug.cgi?id=79339

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/Popover.js:

(WebInspector.Popover.prototype.hide):

  • inspector/front-end/Spectrum.js:
  • inspector/front-end/elementsPanel.css:

(.spectrum-container):
(.spectrum-color):
(.spectrum-display-value):
(.spectrum-hue):
(.spectrum-fill):
(.spectrum-range-container label):
(.spectrum-range-container input):
(.spectrum-slider):
(.spectrum-container .swatch):

  • inspector/front-end/inspector.css:

(.swatch):

23:00 Changeset [108733] by bashi@chromium.org

[Chromium] Add HarfBuzzShaperBase class
https://bugs.webkit.org/show_bug.cgi?id=79336

Extract a part of ComplexTextControllerHarfBuzz class as
HarfBuzzShaperBase class. This patch intends to share the code between
old HarfBuzz and HarfBuzz-ng.

Reviewed by Tony Chang.

No new tests. No behavior change. Existing tests in fast/text should pass.

  • PlatformBlackBerry.cmake: Added HarfBuzzShaperBase.cpp.
  • WebCore.gyp/WebCore.gyp: Added HarfBuzzShaperBase.(cpp|h).
  • WebCore.gypi: Ditto.
  • platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp:

(WebCore::ComplexTextController::ComplexTextController): Removed redundant arguments.
(WebCore::ComplexTextController::nextScriptRun): Use m_normalizedBuffer and m_normalizedBufferLength instead of m_run.
(WebCore::ComplexTextController::setupFontForScriptRun): Ditto.
(WebCore::ComplexTextController::setGlyphPositions): Ditto.

  • platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.h:

(ComplexTextController):

  • platform/graphics/harfbuzz/FontHarfBuzz.cpp:

(WebCore::Font::drawComplexText): Removed redundant arguments of ComplexTextController constructor.
(WebCore::Font::floatWidthForComplexText): Ditto.
(WebCore::Font::offsetForPositionForComplexText): Ditto.
(WebCore::Font::selectionRectForComplexText): Ditto.

  • platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp: Added.

(WebCore):
(WebCore::HarfBuzzShaperBase::HarfBuzzShaperBase):
(WebCore::normalizeSpacesAndMirrorChars):
(WebCore::HarfBuzzShaperBase::setNormalizedBuffer):
(WebCore::HarfBuzzShaperBase::isWordEnd):
(WebCore::HarfBuzzShaperBase::determineWordBreakSpacing):
(WebCore::HarfBuzzShaperBase::setPadding):

  • platform/graphics/harfbuzz/HarfBuzzShaperBase.h: Added.

(WebCore):
(HarfBuzzShaperBase):
(WebCore::HarfBuzzShaperBase::~HarfBuzzShaperBase):
(WebCore::HarfBuzzShaperBase::isCodepointSpace):

22:34 Changeset [108732] by commit-queue@webkit.org

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-23

  • DEPS:
22:29 Changeset [108731] by bashi@chromium.org

Adding WebSocket per-frame DEFLATE extension
https://bugs.webkit.org/show_bug.cgi?id=77522

Source/JavaScriptCore:

Added USE(ZLIB) flag.

Reviewed by Kent Tamura.

  • wtf/Platform.h:

Source/WebCore:

Add WebSocketDeflateFramer class which handles deflate-frame extension.
This class encapsulates WebSocketDeflater and WebSocketInflater classes,
which depend on zlib, so that WebSocketChannel is not necessary to aware
zlib dependency.

This is the second patch to land. The previous patch broke Chromium Win
release build. r108600 should fix the build failure. I also added
zlib entry to |export_dependent_settings| of |webcore_prerequisites|
target.

Reviewed by Kent Tamura.

Tests: http/tests/websocket/tests/hybi/compressed-control-frame.html

http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff.html
http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter.html
http/tests/websocket/tests/hybi/deflate-frame-parameter.html

  • CMakeLists.txt: Added WebSocketDeflateFramer.(cpp|h)
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.gyp/WebCore.gyp: Added zlib dependency.
  • WebCore.vcproj/WebCore.vcproj: Added WebSocketDeflateFramer.(cpp|h)
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • websockets/WebSocket.cpp:

(WebCore::WebSocket::didConnect): Set m_extensions.

  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::connect): Add deflate-frame extension processor to WebSocketHanshake if deflate can use.
(WebCore::WebSocketChannel::fail): Call m_deflateFramer.didFail().
(WebCore::WebSocketChannel::processFrame): Decompress frames if needed.
(WebCore::WebSocketChannel::sendFrame): Compress frames if possible.

  • websockets/WebSocketChannel.h:
  • websockets/WebSocketDeflateFramer.cpp: Added.

(WebCore):
(WebSocketExtensionDeflateFrame):
(WebCore::WebSocketExtensionDeflateFrame::create):
(WebCore::WebSocketExtensionDeflateFrame::~WebSocketExtensionDeflateFrame):
(WebCore::WebSocketExtensionDeflateFrame::WebSocketExtensionDeflateFrame):
(WebCore::WebSocketExtensionDeflateFrame::handshakeString):
(WebCore::WebSocketExtensionDeflateFrame::processResponse):
(WebCore::DeflateResultHolder::DeflateResultHolder):
(WebCore::DeflateResultHolder::~DeflateResultHolder):
(WebCore::DeflateResultHolder::fail):
(WebCore::InflateResultHolder::InflateResultHolder):
(WebCore::InflateResultHolder::~InflateResultHolder):
(WebCore::InflateResultHolder::fail):
(WebCore::WebSocketDeflateFramer::WebSocketDeflateFramer):
(WebCore::WebSocketDeflateFramer::createExtensionProcessor):
(WebCore::WebSocketDeflateFramer::canDeflate):
(WebCore::WebSocketDeflateFramer::enableDeflate):
(WebCore::WebSocketDeflateFramer::deflate):
(WebCore::WebSocketDeflateFramer::resetDeflateContext):
(WebCore::WebSocketDeflateFramer::inflate):
(WebCore::WebSocketDeflateFramer::resetInflateContext):
(WebCore::WebSocketDeflateFramer::didFail):

  • websockets/WebSocketDeflateFramer.h: Added.

(WebCore):
(DeflateResultHolder):
(WebCore::DeflateResultHolder::succeeded):
(WebCore::DeflateResultHolder::failureReason):
(InflateResultHolder):
(WebCore::InflateResultHolder::succeeded):
(WebCore::InflateResultHolder::failureReason):
(WebSocketDeflateFramer):
(WebCore::WebSocketDeflateFramer::enabled):

LayoutTests:

Added tests for WebSocket deflate-frame extension. Also updated some
tests to follow the change.

Reviewed by Kent Tamura.

  • http/tests/websocket/tests/hybi/compressed-control-frame-expected.txt: Added.
  • http/tests/websocket/tests/hybi/compressed-control-frame.html: Added.
  • http/tests/websocket/tests/hybi/compressed-control-frame_wsh.py: Added.

(web_socket_do_extra_handshake):
(web_socket_transfer_data):

  • http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff-expected.txt: Added.
  • http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff.html: Added.
  • http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter-expected.txt: Added.
  • http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter.html: Added.
  • http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter_wsh.py: Added.

(web_socket_do_extra_handshake):
(web_socket_transfer_data):

  • http/tests/websocket/tests/hybi/deflate-frame-parameter-expected.txt: Added.
  • http/tests/websocket/tests/hybi/deflate-frame-parameter.html: Added.
  • http/tests/websocket/tests/hybi/deflate-frame_wsh.py: Added.

(_get_deflate_frame_extension_processor):
(web_socket_do_extra_handshake):
(web_socket_transfer_data):

  • http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header-expected.txt:
  • http/tests/websocket/tests/hybi/send-file-blob_wsh.py:

(_retrieve_frame):
(web_socket_transfer_data):

22:24 Changeset [108730] by aestes@apple.com

Rename [setS|s]uppressIncrementalRendering to [setS|s]uppressesIncrementalRendering and make it WebPreferences API.
https://bugs.webkit.org/show_bug.cgi?id=79433

Reviewed by Dan Bernstein.

Source/WebCore:

  • dom/Document.cpp:

(WebCore::Document::implicitClose):
(WebCore::Document::visualUpdatesAllowed):

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setSuppressesIncrementalRendering):
(WebCore::Settings::suppressesIncrementalRendering):
(Settings):

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.mm:

(-[WebInspectorWindowController init]):

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences setSuppressesIncrementalRendering:]):
(-[WebPreferences suppressesIncrementalRendering]):
(-[WebPreferences setSuppressIncrementalRendering:]):
(-[WebPreferences suppressIncrementalRendering]):

  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

  • Shared/WebPreferencesStore.h:

(WebKit):

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetSuppressesIncrementalRendering):
(WKPreferencesGetSuppressesIncrementalRendering):

  • UIProcess/API/C/WKPreferences.h:
  • UIProcess/WebInspectorProxy.cpp:

(WebKit::createInspectorPageGroup):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidFirstLayout):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

22:21 Changeset [108729] by arv@chromium.org

Rename DOMWindow to Window in the bindings
https://bugs.webkit.org/show_bug.cgi?id=78721

Reviewed by Adam Barth.

Source/WebCore:

Covered by existing tests.

  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.isWindow):

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.get isWindow):
(WebInspector.HeapSnapshot.prototype._calculateObjectToWindowDistance):
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):

  • page/DOMWindow.idl:

LayoutTests:

  • fast/dom/Window/atob-btoa-expected.txt:
  • fast/dom/Window/atob-btoa.html:
  • fast/dom/Window/window-lookup-precedence-expected.txt:
  • fast/dom/Window/window-lookup-precedence.html:
  • fast/dom/Window/window-postmessage-args-expected.txt:
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/dom-constructors-expected.txt:
  • fast/dom/dom-constructors.html:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/script-tests/prototype-inheritance-2.js:

(pushPropertyValuesWithUnseenTypes):

  • fast/dom/wrapper-classes-expected.txt:
  • fast/dom/wrapper-classes.html:
  • fast/events/device-orientation-crash-expected.txt:
  • fast/events/device-orientation-crash.html:
  • fast/events/event-trace-expected.txt:
  • fast/events/event-view-toString-expected.txt:
  • fast/events/popup-blocked-to-post-blank-expected.txt:
  • fast/events/popup-blocked-to-post-blank.html:
  • fast/js/eval-cross-window-expected.txt:
  • fast/js/eval-keyword-vs-function-expected.txt:
  • fast/js/function-bind-expected.txt:
  • fast/js/mozilla/strict/10.4.3-expected.txt:
  • fast/js/mozilla/strict/15.3.4.5-expected.txt:
  • fast/js/mozilla/strict/this-for-function-expression-recursion-expected.txt:
  • fast/js/script-tests/function-bind.js:
  • fast/js/toString-and-valueOf-override-expected.txt:
  • http/tests/inspector-enabled/console-clear-arguments-on-frame-remove-expected.txt:
  • http/tests/security/cross-frame-access-custom-expected.txt:
  • http/tests/security/cross-frame-access-custom.html:
  • http/tests/security/cross-frame-access-put-expected.txt:
  • http/tests/security/document-all-expected.txt:
  • inspector/console/console-dir-global-expected.txt:
  • inspector/debugger/debugger-expand-scope-expected.txt:
  • inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockWithDOM):
(initialize_HeapSnapshotTest):

  • inspector/profiler/heap-snapshot.html:
  • java/lc3/JSObject/ToJSObject-001-expected.txt:
  • java/lc3/JSObject/ToObject-001-expected.txt:
  • java/lc3/JSObject/ToString-001-expected.txt:
  • platform/chromium-mac/fast/events/event-view-toString-expected.txt:
  • platform/chromium-win/fast/events/event-view-toString-expected.txt:
  • platform/chromium-win/fast/js/README:
  • platform/chromium/fast/dom/Window/window-lookup-precedence-expected.txt:
  • platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:
  • platform/chromium/fast/dom/wrapper-classes-expected.txt:
  • platform/chromium/fast/js/mozilla/strict/15.3.4.5-expected.txt:
  • platform/chromium/fast/js/toString-and-valueOf-override-expected.txt:
  • platform/chromium/http/tests/security/cross-frame-access-call-expected.txt:
  • platform/chromium/http/tests/security/cross-frame-access-put-expected.txt:
  • platform/chromium/inspector/console/console-dir-global-expected.txt:
  • platform/chromium/inspector/debugger/debugger-expand-scope-expected.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
  • platform/gtk/http/tests/security/cross-frame-access-put-expected.txt:
  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/mac/fast/dom/wrapper-classes-objc.html:
  • platform/mac/fast/js/global-constructors-expected.txt:
  • platform/qt-5.0-wk2/fast/dom/Window/window-properties-expected.txt:
  • platform/qt-5.0-wk2/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt-5.0-wk2/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt-arm/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
  • platform/qt/http/tests/security/cross-frame-access-put-expected.txt:
  • platform/win/fast/dom/Window/window-properties-expected.txt:
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
  • sputnik/Conformance/11_Expressions/11.1_Primary_Expressions/11.1.1_The_this_Keyword/S11.1.1_A2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/S15.1_A1_T1-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/S15.1_A1_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/S15.1_A2_T1-expected.txt:
21:43 Changeset [108728] by shinyak@chromium.org

NodeRenderingContext should have ShadowRootList instead of ShadowRoot.
https://bugs.webkit.org/show_bug.cgi?id=79079

Reviewed by Dimitri Glazkov.

Apparently NodeRenderingContext should have ShadowRootList instead of ShadowRoot.
This patch changes it.

No new tests. Simple refactoring.

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::NodeRenderingContext::hostChildrenChanged):
(WebCore::NodeRenderingContext::shouldCreateRenderer):

  • dom/NodeRenderingContext.h:

(WebCore):

21:31 Changeset [108727] by commit-queue@webkit.org

[chromium] Implement keyframed animations for the cc thread.
https://bugs.webkit.org/show_bug.cgi?id=77229

Patch by Ian Vollick <vollick@chromium.org> on 2012-02-23
Reviewed by James Robinson.

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::hasActiveAnimation):
(WebCore):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):

  • platform/graphics/chromium/cc/CCActiveAnimation.cpp:

(WebCore::CCActiveAnimation::CCActiveAnimation):
(WebCore::CCActiveAnimation::isFinishedAt):
(WebCore::CCActiveAnimation::trimTimeToCurrentIteration):
(WebCore::CCActiveAnimation::cloneForImplThread):

  • platform/graphics/chromium/cc/CCActiveAnimation.h:

(WebCore::CCActiveAnimation::curve):
(CCActiveAnimation):

  • platform/graphics/chromium/cc/CCKeyframedAnimationCurve.cpp: Added.

(WebCore::CCKeyframedFloatAnimationCurve::create):
(WebCore):
(WebCore::CCKeyframedFloatAnimationCurve::CCKeyframedFloatAnimationCurve):
(WebCore::CCKeyframedFloatAnimationCurve::~CCKeyframedFloatAnimationCurve):
(WebCore::CCKeyframedFloatAnimationCurve::duration):
(WebCore::CCKeyframedFloatAnimationCurve::clone):
(WebCore::CCKeyframedFloatAnimationCurve::getValue):
(WebCore::CCKeyframedTransformAnimationCurve::create):
(WebCore::CCKeyframedTransformAnimationCurve::CCKeyframedTransformAnimationCurve):
(WebCore::CCKeyframedTransformAnimationCurve::~CCKeyframedTransformAnimationCurve):
(WebCore::CCKeyframedTransformAnimationCurve::duration):
(WebCore::CCKeyframedTransformAnimationCurve::clone):
(WebCore::CCKeyframedTransformAnimationCurve::getValue):

  • platform/graphics/chromium/cc/CCKeyframedAnimationCurve.h: Added.

(WebCore):
(WebCore::CCFloatKeyframe::CCFloatKeyframe):
(CCFloatKeyframe):
(WebCore::CCTransformKeyframe::CCTransformKeyframe):
(CCTransformKeyframe):
(CCKeyframedFloatAnimationCurve):
(CCKeyframedTransformAnimationCurve):

  • platform/graphics/chromium/cc/CCLayerAnimationController.cpp:

(WebCore::CCLayerAnimationController::addAnimation):

  • platform/graphics/chromium/cc/CCLayerAnimationController.h:

(WebCore::CCLayerAnimationController::hasActiveAnimation):
(CCLayerAnimationController):

  • platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.cpp:

(WebCore::CCLayerAnimationControllerImpl::tickAnimations):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCAnimationTestCommon.cpp:

(WebCore):
(WebCore::addOpacityTransition):
(WebKitTests::addOpacityTransitionToController):
(WebKitTests::addOpacityTransitionToLayer):

  • tests/CCAnimationTestCommon.h:

(WebCore):
(WebKitTests):

  • tests/CCKeyframedAnimationCurveTest.cpp: Added.

(WebCore):
(WebCore::expectTranslateX):
(WebCore::TEST):

  • tests/CCLayerAnimationControllerTest.cpp:

(WebKitTests::expectTranslateX):
(WebKitTests):
(WebKitTests::TEST):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::dispatchAddAnimation):
(WTF::CCLayerTreeHostTest::doBeginTest):

21:25 Changeset [108726] by commit-queue@webkit.org

Use MathExtras round() in timeToSampleFrame
https://bugs.webkit.org/show_bug.cgi?id=79281

Patch by Raymond Toy <rtoy@google.com> on 2012-02-23
Reviewed by Chris Rogers.

No new tests. Existing tests cover this change.

  • platform/audio/AudioUtilities.cpp:

(WebCore::AudioUtilities::timeToSampleFrame): Use round().

21:24 Changeset [108725] by mitz@apple.com

REGRESSION: Assertion failure in Document::setCompatibilityMode() (!m_styleSheets->length()) in fast/dynamic/crash-paint-no-documentElement-renderer.html
https://bugs.webkit.org/show_bug.cgi?id=79333

Reviewed by Sam Weinig.

Disabled the test. The assertion failure is tracked by <http://webkit.org/b/68859>.

  • fast/dynamic/crash-paint-no-documentElement-renderer.html: Removed.
  • fast/dynamic/crash-paint-no-documentElement-renderer.html-disabled: Copied from LayoutTests/fast/dynamic/crash-paint-no-documentElement-renderer.html.
  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/gtk/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
20:58 Changeset [108724] by commit-queue@webkit.org

Don't clear IntentRequest callback pointers on stop()

This causes re-entry into ScriptExecutionContext when
the ActiveDOMCallback objects get deleted, which crashes.
Instead, just de-activate the object and wait for
context destruction to clean up.

Test crashes consistently without fix and passes with fix.
Added some test infrastructure to support this test.
https://bugs.webkit.org/show_bug.cgi?id=78638

Patch by Greg Billock <gbillock@google.com> on 2012-02-23
Reviewed by Adam Barth.

  • Modules/intents/IntentRequest.cpp:

(WebCore::IntentRequest::IntentRequest):
(WebCore::IntentRequest::stop):
(WebCore::IntentRequest::postResult):
(WebCore::IntentRequest::postFailure):

  • Modules/intents/IntentRequest.h:

(IntentRequest):

20:40 Changeset [108723] by commit-queue@webkit.org

[BlackBerry] Selection handler has compile failure with logs enabled.
https://bugs.webkit.org/show_bug.cgi?id=79392

Patch by Mike Fenton <mifenton@rim.com> on 2012-02-23
Reviewed by Antonio Gomes.

Build Fix. Update log to avoid usage of toString which was removed.

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):

20:34 Changeset [108722] by commit-queue@webkit.org

Upstream BlackBerry Cookie Management Classes
https://bugs.webkit.org/show_bug.cgi?id=73654

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-02-23
Reviewed by Rob Buis.

.:

Manual test to see in milliseconds how quickly 100 writes followed by 100 reads take.
This test is ran twice and the average read and write for each of the 2 runs is shown.

  • ManualTests/cookieSpeedTest.html: Added.

Source/WebCore:

Added ManualTests/cookieSpeedTest.html as well as tested functionality
on the BlackBerry port with http://testsuites.opera.com/cookies/
Passes all non Cookie 2 tests since Cookie 2 is not implemented/supported at this time.
Error handling and extended tests do not all pass and will be updated with future bugs/patches.

  • platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp: Added.
  • platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.h: Added.
  • platform/blackberry/CookieJarBlackBerry.cpp: Added.
  • platform/blackberry/CookieManager.cpp: Added.
  • platform/blackberry/CookieManager.h: Added.
  • platform/blackberry/CookieMap.cpp: Added.
  • platform/blackberry/CookieMap.h: Added.
  • platform/blackberry/CookieParser.cpp: Added.
  • platform/blackberry/CookieParser.h: Added.
  • platform/blackberry/ParsedCookie.cpp: Added.
  • platform/blackberry/ParsedCookie.h: Added.
20:28 Changeset [108721] by tonikitoo@webkit.org

2012-02-19 Antonio Gomes <agomes@rim.com>

Fat fingers - Add a clearer way to distinguish the node we want (shadow or non-shadow)
https://bugs.webkit.org/show_bug.cgi?id=79256
PR #127814 / MKS_2587410

Reviewed by Rob Buis.

Patch adds a cleaner way for call sites of FatFingersResult to
query for the appropriated target node: shadow or non-shadow DOM nodes.

It also renames FatFingersResults::validNode to ::node, assuming
that "invalid" nodes are not applicable in any context.

  • Api/WebPage.cpp: (BlackBerry::WebKit::WebPagePrivate::clearDocumentData): (BlackBerry::WebKit::WebPagePrivate::contextNode): (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
  • WebKitSupport/FatFingers.h: (FatFingersResult): (BlackBerry::WebKit::FatFingersResult::node): (BlackBerry::WebKit::FatFingersResult::nodeAsElementIfApplicable):
  • WebKitSupport/SelectionHandler.cpp: (BlackBerry::WebKit::SelectionHandler::selectAtPoint):
  • WebKitSupport/TouchEventHandler.cpp: (BlackBerry::WebKit::TouchEventHandler::touchHoldEvent): (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
20:04 Changeset [108720] by bashi@chromium.org

Unreviewed test fix after r108699.

Fix wrong path of repaint.js in platform/mac/svg/text/text-rescale.html
and platform/mac/svg/text/text-viewbox-rescale.html

  • platform/mac/svg/text/text-rescale.html:
  • platform/mac/svg/text/text-viewbox-rescale.html:
19:55 Changeset [108719] by leviw@chromium.org

Switch drawLineForBoxSide to use integers
https://bugs.webkit.org/show_bug.cgi?id=78647

Reviewed by Eric Seidel.

drawLineForBoxSide handles painting lines for boxes which must be done on pixel boundaries.
Its interface doesn't make it possible to pixel snap properly within the function itself --
it draws one side of the box at a time, and the logical right and bottom lines can only be
properly determined using the logical top and left positions -- so it needs to be treated
like a graphics context function, whereby the caller handles the proper pixel snapping before
passing the values in.

No new tests. No change in behavior.

  • rendering/LayoutTypes.h:

(WebCore::pixelSnappedIntRectFromEdges): convenience function for returning a pixel snapped
int rect from four LayoutUnits that are its edges (as opposed to position and size).

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintColumnRules): Pixel snapping the column rule rect.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintOneBorderSide): Side rects are now IntRects by the time
they get to paintOneBorderSide.
(WebCore::calculateSideRect): Properly use RoundedRect as IntRects instead of LayoutRects.
(WebCore::RenderBoxModelObject::paintBorderSides): Ditto.
(WebCore::RenderBoxModelObject::paintBorder): Ditto.
(WebCore::calculateSideRectIncludingInner): Ditto.

  • rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::paintOutlineForLine): Outline widths are related to borders and stored
as ints. Removing an unnecessary conversion to LayoutUnits. Pixel snapping the edges of the box.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::drawLineForBoxSide): Moving back to integers and removing an
unnecessary pixelSnappedIntRect call.
(WebCore::RenderObject::paintOutline): Pixel snapping the column rule rect and using an integer
for outlineOffset.

  • rendering/RenderObject.h:

(RenderObject):

19:41 Changeset [108718] by commit-queue@webkit.org

[BlackBerry] Upstream BlackBerry API web page related files
https://bugs.webkit.org/show_bug.cgi?id=74380

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-02-23
Reviewed by Antonio Gomes.

Initial upstream, no new tests.

  • Api/WebPage.cpp: Added.
  • Api/WebPage.h: Added.
  • Api/WebPage_p.h: Added.
19:11 Changeset [108717] by leo.yang@torchmobile.com.cn

[BlackBerry] Remove unused ChromeClientBlackBerry::platformCompositingWindow(), platformWindow() and WebPageClient::compositingWindow()
https://bugs.webkit.org/show_bug.cgi?id=78681

Reviewed by Antonio Gomes.

  • Api/WebPageClient.h:
  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore):

  • WebCoreSupport/ChromeClientBlackBerry.h:

(ChromeClientBlackBerry):

19:10 Changeset [108716] by mhahnenberg@apple.com

Zero out CopiedBlocks on initialization
https://bugs.webkit.org/show_bug.cgi?id=79199

Reviewed by Filip Pizlo.

Made CopyBlocks zero their payloads during construction. This allows
JSArray to avoid having to manually clear its backing store upon allocation
and also alleviates any future pain with regard to the garbage collector trying
to mark what it thinks are values in what is actually uninitialized memory.

  • heap/CopiedBlock.h:

(JSC::CopiedBlock::CopiedBlock):

  • runtime/JSArray.cpp:

(JSC::JSArray::finishCreation):
(JSC::JSArray::tryFinishCreationUninitialized):
(JSC::JSArray::increaseVectorLength):
(JSC::JSArray::unshiftCountSlowCase):

19:05 Changeset [108715] by leo.yang@torchmobile.com.cn

[BlackBerry] Upstream the BlackBerry change to platform/graphics/IntPoint.h
https://bugs.webkit.org/show_bug.cgi?id=79094

Reviewed by Antonio Gomes.

Add conversion convenience between WebCore::IntPoint and BlackBerry::Platform::IntPoint.

The porting can't be built yet, no new tests.

  • platform/graphics/IntPoint.h:

(Platform):
(IntPoint):

19:03 Changeset [108714] by commit-queue@webkit.org

[Chromium] Add profiling trace for deferred canvas rendering
https://bugs.webkit.org/show_bug.cgi?id=79376

Patch by Justin Novosad <junov@chromium.org> on 2012-02-23
Reviewed by Stephen White.

No new tests.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):
Profiling trace for the entire method, as well as for
calls to canvas flush and context flush, both of which may
cause deferred operation to be executed.

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::bitmap):
Inserting a profiling trace in this method because it may cause
deferred draw commands to be executed.

18:37 Changeset [108713] by shinyak@chromium.org

ShadowRootList should have recalculation flag instead of ShadowRoot.
https://bugs.webkit.org/show_bug.cgi?id=79071

Reviewed by Hajime Morita.

When light children or shadow children are changed, we currently re-construct a shadow subtree.
However, when supporting multiple shadow subtrees, all shadow subtrees should be re-constructed.
So ShadowRootList should have re-construction flag instead of ShadowRoot.

Also, re-construction methods in ShadowRoot should be moved to ShadowRootList.

No new tests, should be convered by existing tests.

  • dom/Element.cpp:

(WebCore::Element::recalcStyle):
(WebCore::Element::childrenChanged):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::hostChildrenChanged):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::list):

  • dom/ShadowRoot.h:

(WebCore):
(ShadowRoot):

  • dom/ShadowRootList.cpp:

(WebCore::ShadowRootList::ShadowRootList):
(WebCore::ShadowRootList::reattach):
(WebCore):
(WebCore::ShadowRootList::childNeedsStyleRecalc):
(WebCore::ShadowRootList::needsStyleRecalc):
(WebCore::ShadowRootList::recalcShadowTreeStyle):
(WebCore::ShadowRootList::needsReattachHostChildrenAndShadow):
(WebCore::ShadowRootList::hostChildrenChanged):
(WebCore::ShadowRootList::setNeedsReattachHostChildrenAndShadow):
(WebCore::ShadowRootList::reattachHostChildrenAndShadow):

  • dom/ShadowRootList.h:

(WebCore):
(ShadowRootList):
(WebCore::ShadowRootList::clearNeedsReattachHostChildrenAndShadow):

  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::attach):
(WebCore::HTMLContentElement::detach):
(WebCore::HTMLContentElement::parseAttribute):

18:20 Changeset [108712] by rolandsteiner@chromium.org

Unreviewed: add clause in ASSERT missing from r108474.

No new tests. (fix)

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::willRemove):

18:16 Changeset [108711] by leo.yang@torchmobile.com.cn

[BlackBerry] Upstream GLES2Context.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=79196

Reviewed by Rob Buis.

Initial upstream, no new tests.

  • WebKitSupport/GLES2Context.cpp: Added.
  • WebKitSupport/GLES2Context.h: Added.
18:11 Changeset [108710] by eric@webkit.org

Split out HTML constructors into new DOMWindowHTML suplemental idl
https://bugs.webkit.org/show_bug.cgi?id=79377

Reviewed by Adam Barth.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • html/DOMWindowHTML.idl: Added.
  • page/DOMWindow.idl:
18:04 Changeset [108709] by eric@webkit.org

Move SVG element constructors out of DOMWindow.idl into a new DOMWindowSVG.idl suplemental
https://bugs.webkit.org/show_bug.cgi?id=79379

Reviewed by Adam Barth.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • page/DOMWindow.idl:
  • svg/DOMWindowSVG.idl: Added.
17:56 Changeset [108708] by leviw@chromium.org

Fixing the Mac build and adding a pixelSnappedBorderBoxRect. borderBoxRect should probably be deprecated...

17:48 Changeset [108707] by enne@google.com

Unreviewed, add Stephen Chenney to committers.py as a contributor.

  • Scripts/webkitpy/common/config/committers.py:
17:38 Changeset [108706] by jamesr@google.com

[chromium] Clean up GraphicsContext3D initialization paths
https://bugs.webkit.org/show_bug.cgi?id=79321

Reviewed by Kenneth Russell.

This simplifies the GraphicsContext3D initialization paths down to two simple codepaths, one for offscreen
contexts initialized from WebCore and one for onscreen (compositor) contexts initialized by WebViewImpl or
WebLayerTreeViewImpl.

Offscreen initialization path:
1) WebCore code calls WebCore::GraphicsContext3D::create(), implemented in GraphicsContext3DChromium.cpp
2) GraphicsContext3D::create() instantiates a WebGraphicsContext3D via the static WebKitPlatformSupport interface
3) GraphicsContext3DPrivate::createGraphicsContextFromWebContext() wraps the WebGraphicsContext3D in a
GraphicsContext3D's m_private pointer.

Onscreen initialization path:
1) WebViewImpl or WebLayerTreeViewImpl request an onscreen WebGraphicsContext3D from either their WebViewClient
or WebLayerTreeViewClient, respectively
2) GraphicsContext3DPrivate::createGraphicsContextFromWebContext() wraps the WebGraphicsContext3D in a
GraphicsContext3D's m_private pointer.

There are no other initialization paths. Specifically, we do not support instantiating onscreen contexts from
within WebCore.

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):
(WebCore):
(WebCore::GraphicsContext3DPrivate::platformTexture):
(WebCore::GraphicsContext3D::create):

  • src/GraphicsContext3DPrivate.h:

(GraphicsContext3DPrivate):

  • src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::createLayerTreeHostContext3D):

  • src/WebViewImpl.cpp:

(std::getCompositorContextAttributes):
(WebKit::WebViewImpl::createCompositorGraphicsContext3D):
(WebKit):
(WebKit::WebViewImpl::createLayerTreeHostContext3D):
(WebKit::WebViewImpl::graphicsContext3D):

  • src/WebViewImpl.h:

(WebViewImpl):

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::CCLayerTreeHostImplTest::createContext):
(CCLayerTreeHostImplTest):
(WebKit::TEST_F):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):

  • tests/Canvas2DLayerChromiumTest.cpp:

(WebCore::Canvas2DLayerChromiumTest::fullLifecycleTest):

  • tests/CompositorFakeGraphicsContext3D.h:

(WebCore::createCompositorMockGraphicsContext3D):

  • tests/FakeGraphicsContext3DTest.cpp:

(TEST):

17:37 Changeset [108705] by eae@chromium.org

Fix QT build on branch.

17:33 Changeset [108704] by enne@google.com

[chromium] Unreviewed gardening. Apply bug number to svg/carto.net failures.
https://bugs.webkit.org/show_bug.cgi?id=79423

These two tests were in a set of tests that needed to be rebaselined
after a jpeg decoder change. However, there was also a text change
during this period that caused debug vs. release differences for text
spans in the SVG output. Filing a real bug so this can get looked at.

  • platform/chromium/test_expectations.txt:
17:32 Changeset [108703] by commit-queue@webkit.org

[chromium] Plumb video damage to the damage tracker.
https://bugs.webkit.org/show_bug.cgi?id=79373

Patch by Jonathan Backer <backer@chromium.org> on 2012-02-23
Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::contentChanged):
(WebCore):

  • platform/graphics/chromium/VideoLayerChromium.h:

(VideoLayerChromium):

Source/WebKit/chromium:

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::repaint):

17:27 Changeset [108702] by commit-queue@webkit.org

[BlackBerry] InputHandler requires cleanup of Navigation Mode handling.
https://bugs.webkit.org/show_bug.cgi?id=79366

Patch by Mike Fenton <mifenton@rim.com> on 2012-02-23
Reviewed by Rob Buis.

Cleanup InputHandler navigation based code.

1) Remove the concept of NavigationMode and replace it

with simple showKeyboard calls.

2) Remove navigation move events and replace with standard

key events.

3) Standardize function/variable names and remove obsolete

functions.

  • Api/WebPageClient.h:
  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::InputHandler):
(BlackBerry::WebKit::InputHandler::nodeFocused):
(BlackBerry::WebKit::InputHandler::setElementUnfocused):
(BlackBerry::WebKit::InputHandler::setElementFocused):
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
(BlackBerry::WebKit::InputHandler::setDelayKeyboardVisibilityChange):
(BlackBerry::WebKit::InputHandler::processPendingKeyboardVisibilityChange):
(BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):

  • WebKitSupport/InputHandler.h:

(InputHandler):

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::setCaretPosition):
(BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::touchEventCancel):
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):

17:25 Changeset [108701] by abarth@webkit.org

style-queue logs bogus messages to the QueueStatusServer
https://bugs.webkit.org/show_bug.cgi?id=79424

Reviewed by Eric Seidel.

Copy/paste error.

  • Scripts/webkitpy/tool/bot/stylequeuetask.py:

(StyleQueueTask._check_style):
(StyleQueueTask._apply_watch_list):

  • Scripts/webkitpy/tool/commands/queues_unittest.py:
16:54 Changeset [108700] by morrita@google.com

This test checks select attribute of content element is valid.
https://bugs.webkit.org/show_bug.cgi?id=65595

Reviewed by Dimitri Glazkov.

Source/WebCore:

This change introduces FrameTree::scopedChild() and
FrameTree::scopedChild(), which can be used for scope-aware
frame lookup. Using these, the named accessor and the indexed
acceccor on Document, and Window.length are now TreeScope
aware. They don't count iframes in Shadow DOM.

This change also removes FrameTree::m_childCount since
Frame::childCount() is no longer in the hot
path. m_scopedChildCount is added instead.

Test: fast/dom/shadow/iframe-shadow.html

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::childFrameGetter):
(WebCore::indexGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::indexedPropertyGetter):
(WebCore::V8DOMWindow::namedPropertyGetter):
(WebCore::V8DOMWindow::namedSecurityCheck):
(WebCore::V8DOMWindow::indexedSecurityCheck):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::length):

  • page/Frame.cpp:

(WebCore::Frame::inScope):
(WebCore):

  • page/Frame.h:

(WebCore):
(Frame):

  • page/FrameTree.cpp:

(WebCore::FrameTree::actuallyAppendChild):
(WebCore::FrameTree::removeChild):
(WebCore::FrameTree::scopedChild):
(WebCore):
(WebCore::FrameTree::scopedChildCount):
(WebCore::FrameTree::childCount):

  • page/FrameTree.h:

(WebCore):
(FrameTree):
(WebCore::FrameTree::FrameTree):

LayoutTests:

  • fast/dom/shadow/iframe-shadow-expected.txt: Added.
  • fast/dom/shadow/iframe-shadow.html: Added.
16:52 Changeset [108699] by commit-queue@webkit.org

Recompute font metrics on scale changes
https://bugs.webkit.org/show_bug.cgi?id=75091

Patch by Philip Rogers <pdr@google.com> on 2012-02-23
Reviewed by Nikolas Zimmermann.

Source/WebCore:

SVG text metrics depend on the transform from renderer to the svg root
which requires that we propagate transform changes down to text.
This change adds a boolean for tracking transform changes to
SVGViewportContainers and SVGTransformableContainers, and updates
RenderSVGText::layout() to recalculate text metrics if the transform
of an ancestor has changed.

Tests: platform/mac/svg/text/text-rescale.html

platform/mac/svg/text/text-viewbox-rescale.html
svg/text/text-rescale.html
svg/text/text-viewbox-rescale.html

  • rendering/RenderObject.h:

(WebCore::RenderObject::isSVGTransformableContainer):
(WebCore::RenderObject::isSVGViewportContainer):

  • rendering/svg/RenderSVGContainer.h:

(WebCore::RenderSVGContainer::didTransformToRootUpdate):

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::computeNewScaledFontForStyle):

  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::RenderSVGText):
(WebCore::RenderSVGText::layout):

  • rendering/svg/RenderSVGText.h:

(WebCore::RenderSVGText::setNeedsTextMetricsUpdate):
(RenderSVGText):

  • rendering/svg/RenderSVGTransformableContainer.cpp:

(WebCore::RenderSVGTransformableContainer::RenderSVGTransformableContainer):
(WebCore::RenderSVGTransformableContainer::calculateLocalTransform):

  • rendering/svg/RenderSVGTransformableContainer.h:

(WebCore::RenderSVGTransformableContainer::isSVGTransformableContainer):
(WebCore::RenderSVGTransformableContainer::didTransformToRootUpdate):
(RenderSVGTransformableContainer):

  • rendering/svg/RenderSVGViewportContainer.cpp:

(WebCore::RenderSVGViewportContainer::RenderSVGViewportContainer):
(WebCore::RenderSVGViewportContainer::calcViewport):

  • rendering/svg/RenderSVGViewportContainer.h:

(WebCore::RenderSVGViewportContainer::didTransformToRootUpdate):
(RenderSVGViewportContainer):

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::transformToRootChanged):
(WebCore):
(WebCore::SVGRenderSupport::layoutChildren):

  • rendering/svg/SVGRenderSupport.h:

(SVGRenderSupport):

LayoutTests:

  • platform/chromium-linux/svg/text/text-rescale-expected.png: Added.
  • platform/chromium-linux/svg/text/text-rescale-expected.txt: Added.
  • platform/chromium-linux/svg/text/text-viewbox-rescale-expected.png: Added.
  • platform/chromium-linux/svg/text/text-viewbox-rescale-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/text/text-rescale-expected.png: Added.
  • platform/mac/svg/text/text-rescale-expected.txt: Added.
  • platform/mac/svg/text/text-rescale.html: Added.
  • platform/mac/svg/text/text-viewbox-rescale-expected.png: Added.
  • platform/mac/svg/text/text-viewbox-rescale-expected.txt: Added.
  • platform/mac/svg/text/text-viewbox-rescale.html: Added.
  • svg/text/text-rescale-expected.png: Added.
  • svg/text/text-rescale-expected.txt: Added.
  • svg/text/text-rescale.html: Added.
  • svg/text/text-viewbox-rescale-expected.png: Added.
  • svg/text/text-viewbox-rescale-expected.txt: Added.
  • svg/text/text-viewbox-rescale.html: Added.
16:29 Changeset [108698] by jamesr@google.com

[chromium] Notify compositor of wheel event registration via ScrollingCoordinator
https://bugs.webkit.org/show_bug.cgi?id=79133

Reviewed by Dimitri Glazkov.

Source/WebCore:

This notifies the chromium compositor of changes to the number of wheel event handlers via ScrollingCoordinator
instead of through ChromeClient/WebViewImpl. This is the path we'll use for other properties in the future and
is more extensible for handling things other than the root layer.

Property behavior is covered by new unit tests in LayerChromiumTests and CCLayerTreeHostImplTest.

  • page/scrolling/ScrollingCoordinator.cpp:
  • page/scrolling/ScrollingCoordinator.h:

(WebCore):
(ScrollingCoordinator):

Add a ScrollingCoordinatorPrivate so implementations can tack on additional data without having to #ifdef up
ScrollingCoordinator.h/cpp

  • page/scrolling/ScrollingCoordinatorNone.cpp:

(WebCore):
(WebCore::ScrollingCoordinator::~ScrollingCoordinator):

  • page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(ScrollingCoordinatorPrivate):

ScrollingCoordinatorPrivate in the chromium implementation keeps a reference to the scroll layer.

(WebCore::ScrollingCoordinatorPrivate::ScrollingCoordinatorPrivate):
(WebCore::ScrollingCoordinatorPrivate::~ScrollingCoordinatorPrivate):
(WebCore::ScrollingCoordinatorPrivate::setScrollLayer):
(WebCore::ScrollingCoordinatorPrivate::scrollLayer):
(WebCore):
(WebCore::ScrollingCoordinator::create):
(WebCore::ScrollingCoordinator::~ScrollingCoordinator):
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::setScrollLayer):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setScrollParameters):
(WebCore::ScrollingCoordinator::setWheelEventHandlerCount):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore):
(WebCore::ScrollingCoordinator::~ScrollingCoordinator):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setHaveWheelEventHandlers):
(WebCore):
(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):

  • platform/graphics/chromium/cc/CCInputHandler.h:
  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::haveWheelEventHandlers):
(WebCore::CCLayerImpl::setHaveWheelEventHandlers):
(CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::scrollBegin):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

Source/WebKit/chromium:

Rips out old wheel event notification and adds unit tests for new LayerChromium property.

  • src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::setViewport):

  • src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::handleInputEvent):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::numberOfWheelEventHandlersChanged):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • src/WebViewImpl.h:
  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::TEST_F):
(WebKit):

  • tests/LayerChromiumTest.cpp:
  • tests/WebCompositorInputHandlerImplTest.cpp:
16:26 Changeset [108697] by enne@google.com

[chromium] Unreviewed gardening. Re-enable a handful of tests.

These have no relation to each other, but all don't appear to be
failing anymore, so removing expectations for them.

  • platform/chromium/test_expectations.txt:
16:24 Changeset [108696] by noam.rosenthal@nokia.com

[Qt][WK2] Clipping is broken
https://bugs.webkit.org/show_bug.cgi?id=78677

Reviewed by Simon Hausmann.

Rework the clipping stack in TextureMapperGL.
Instead of saving a stack of IntRect scissor clips, we save every clipping change in the
stack, and reapply it when we end the clip. Popping the stack is almost free, since we
don't reapply the stencil but simply change the stencil test index.

In addition, we don't use a special shader for clipping, and we don't apply clipping for
masked children, since they're already clipped because they're rendered into an intermediate
buffer.

This fixes exiting tests in LayoutTests/compositing/overflow.
It also fixes asserts in the leaves demo, as well as asserts in nytimes.com and other sites.

  • page/FrameView.cpp:

(WebCore::FrameView::paintContents):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(ClipState):
(WebCore::TextureMapperGLData::SharedGLData::ClipState::ClipState):
(SharedGLData):
(WebCore::TextureMapperGLData::SharedGLData::pushClipState):
(WebCore::TextureMapperGLData::SharedGLData::popClipState):
(WebCore::TextureMapperGLData::SharedGLData::scissorClip):
(WebCore::TextureMapperGLData::SharedGLData::applyCurrentClip):
(TextureMapperGLData):
(BitmapTextureGL):
(WebCore::TextureMapperGLData::initStencil):
(WebCore):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::TextureMapperGL::endPainting):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::BitmapTextureGL::initStencil):
(WebCore::BitmapTextureGL::bind):
(WebCore::BitmapTextureGL::destroy):
(WebCore::TextureMapperGL::bindSurface):
(WebCore::TextureMapperGL::beginScissorClip):
(WebCore::TextureMapperGL::beginClip):
(WebCore::TextureMapperGL::endClip):

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::paintSelfAndChildren):

  • platform/graphics/texmap/TextureMapperShaderManager.cpp:
  • platform/graphics/texmap/TextureMapperShaderManager.h:
16:18 Changeset [108695] by commit-queue@webkit.org

Add Chromium gpu_tests to the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=79300

Patch by Dave Tu <dtu@chromium.org> on 2012-02-23
Reviewed by Ojan Vafai.

  • Tools/TestResultServer/static-dashboards/builders.js:
  • Tools/TestResultServer/static-dashboards/dashboard_base.js:
16:08 Changeset [108694] by commit-queue@webkit.org

[GTK] Wrong signal name on emission in WebKitWindowProperties.cpp
https://bugs.webkit.org/show_bug.cgi?id=79352

Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-02-23
Reviewed by Philippe Normand.

Emit the signal 'resizable' instead of 'resizable-visible'.

  • UIProcess/API/gtk/WebKitWindowProperties.cpp:

(webkitWindowPropertiesSetResizable): Use right signal name.

16:05 Changeset [108693] by eric@webkit.org

Use self._filesystem in more places in the SCM classes
https://bugs.webkit.org/show_bug.cgi?id=79415

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/checkout/scm/detection_unittest.py:

(SCMDetectorTest.test_detect_scm_system):

  • Scripts/webkitpy/common/checkout/scm/git.py:

(Git.find_checkout_root):
(Git.to_object_name):

  • Scripts/webkitpy/common/checkout/scm/scm.py:

(SCM.init):
(SCM.in_working_directory):

  • Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN.find_uuid):
(SVN.find_checkout_root):

16:03 Changeset [108692] by enne@google.com

Unreviewed, rolling out r108685.
http://trac.webkit.org/changeset/108685
https://bugs.webkit.org/show_bug.cgi?id=79414

Broke Chromium builds (Requested by enne on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-23

Source/WebCore:

  • Target.pri:
  • WebCore.pri:
  • platform/MIMETypeRegistry.cpp:

(WebCore::initializeSupportedImageMIMETypes):
(WebCore::initializeSupportedImageMIMETypesForEncoding):

  • platform/image-decoders/ImageDecoder.h:

(WebCore::ImageFrame::getAddr):
(ImageFrame):

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
  • platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore):

  • platform/image-decoders/qt/ImageFrameQt.cpp:

Tools:

  • qmake/mkspecs/features/features.prf:
15:59 Changeset [108691] by abarth@webkit.org

style-queue shouldn't spam bugs if it fails to update its working copy
https://bugs.webkit.org/show_bug.cgi?id=79412

Reviewed by Eric Seidel.

This patch moves style-queue over to the new PatchAnalysisTask
infrastructure, which is smarter about retrying patches when update
fails.

  • Scripts/webkitpy/common/system/executive_mock.py:

(MockExecutive.run_and_throw_if_fail):

  • Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
  • Scripts/webkitpy/tool/bot/patchanalysistask.py:

(UnableToApplyPatch):
(UnableToApplyPatch.init):
(PatchAnalysisTask.init):

  • Scripts/webkitpy/tool/bot/stylequeuetask.py: Added.

(StyleQueueTaskDelegate):
(StyleQueueTaskDelegate.parent_command):
(StyleQueueTask):
(StyleQueueTask.validate):
(StyleQueueTask._check_style):
(StyleQueueTask._apply_watch_list):
(StyleQueueTask.run):

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/queues.py:

(StyleQueue):
(StyleQueue.should_proceed_with_work_item):
(StyleQueue.review_patch):
(StyleQueue.run_command):
(StyleQueue.command_passed):
(StyleQueue.command_failed):
(StyleQueue.expected_failures):
(StyleQueue.refetch_patch):

  • Scripts/webkitpy/tool/commands/queues_unittest.py:

(StyleQueueTest.test_style_queue_with_style_exception):
(test_style_queue_with_watch_list_exception):

15:55 Changeset [108690] by commit-queue@webkit.org

CSS2:text-decoration: <rt> element should not inherit text-decoration property
https://bugs.webkit.org/show_bug.cgi?id=71266

Patch by Koji Ishii <kojiishi@gmail.com> on 2012-02-23
Reviewed by Kentaro Hara.

Source/WebCore:

Tests: fast/ruby/text-decoration-in-descendants-ruby-expected.html

fast/ruby/text-decoration-in-descendants-ruby.html

The spec says "text decorations are not propagated to any out-of-flow descendants":
http://www.w3.org/TR/2011/WD-css3-text-20110901/#decoration
Floats etc. are fixed in bug 18611, but <rt> is not inline either and therefore
it should be included; it was confirmed at a discussion at www-style.
http://lists.w3.org/Archives/Public/www-style/2011Sep/0238.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

LayoutTests:

The spec says "text decorations are not propagated to any out-of-flow descendants":
http://www.w3.org/TR/2011/WD-css3-text-20110901/#decoration
Floats etc. are fixed in bug 18611, but <rt> is not inline either and therefore
it should be included; it was confirmed at a discussion at www-style.
http://lists.w3.org/Archives/Public/www-style/2011Sep/0238.html

  • fast/ruby/text-decoration-in-descendants-ruby-expected.html: Added.
  • fast/ruby/text-decoration-in-descendants-ruby.html: Added.
15:54 Changeset [108689] by leviw@chromium.org

Adding a pixelSnappedIntRect method that takes top, left, width, and height. Pixel snapping borders for tables. Fixing inconsistencies in RenderObject.cpp.

15:52 Changeset [108688] by eae@chromium.org

Clean up chromium and qt platform code on branch.

15:50 Changeset [108687] by fpizlo@apple.com

Make fast/js/script-tests/dfg-inline-function-dot-caller not timeout.

Rubber stamped by Oliver Hunt.

Verified that the test still causes inlining to happen and still passes but
otherwise reduced the loops to take an order of magnitude fewer iterations.

  • fast/js/script-tests/dfg-inline-function-dot-caller.js:

(object.nonInlineable.nonInlineable.if):
(object.nonInlineable):
(makeInlinableCall):

15:44 Changeset [108686] by enne@google.com

[chromium] Unreviewed gardening. Mark two fast/files/ tests as non-flaky.
https://bugs.webkit.org/show_bug.cgi?id=45667

These two look like they're passing consistently, so remove
expectations.

  • platform/chromium/test_expectations.txt:
15:37 Changeset [108685] by zoltan@webkit.org

[Qt] Allow to use WebCore imagedecoders
https://bugs.webkit.org/show_bug.cgi?id=32410

Source/WebCore:

Add ENABLE(QT_IMAGE_DECODER) guards around Qt imagedecoders and set it to default.
By passing ENABLE_QT_IMAGE_DECODER=0 define to the build system WebKit will build
with WebCore's imagedecoders.

I added NO_RETURN attribute to 2 functions of PNG and JPEG decoders to avoid compiler warnings
because in Qt-port we treat warning as errors (-Werror).

I'm continuing the refactoring of this area and try to use Qt imagedecoders only in
cases when WebCore doesn't support the image format.

Reviewed by Simon Hausmann.

No behavior change, no need new tests.

  • Target.pri:
  • WebCore.pri:
  • platform/MIMETypeRegistry.cpp:

(WebCore::initializeSupportedImageMIMETypes):
(WebCore::initializeSupportedImageMIMETypesForEncoding):

  • platform/image-decoders/ImageDecoder.h:

(WebCore::ImageFrame::getAddr):
(ImageFrame):

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

NO_RETURN has been added to a function to avoid warning message.

  • platform/image-decoders/png/PNGImageDecoder.cpp:

NO_RETURN has been added to a function to avoid warning message.
(WebCore):

  • platform/image-decoders/qt/ImageFrameQt.cpp:

(WebCore):
(WebCore::ImageFrame::asNewNativeImage):

Tools:

Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.

Reviewed by Simon Hausmann.

  • qmake/mkspecs/features/features.prf:
15:26 Changeset [108684] by eric@webkit.org

Remove old broken find_checkout_root tests now that find_checkout_root is gone
https://bugs.webkit.org/show_bug.cgi?id=79405

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/checkout/scm/detection_unittest.py: Added.

(SCMDetectorTest):
(SCMDetectorTest.test_find_checkout_root):

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:

(SVNTestRepository.tear_down):

15:20 Changeset [108683] by enne@google.com

[chromium] Unreviewed gardening. Mark a media-fragments test as slow.
https://bugs.webkit.org/show_bug.cgi?id=77523

This has been periodically timing out on Win, so give it more time.

  • platform/chromium/test_expectations.txt:
15:20 Changeset [108682] by commit-queue@webkit.org

[Qt][WK2] Implement proxy authentication dialog.
https://bugs.webkit.org/show_bug.cgi?id=79350

Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-02-23
Reviewed by Simon Hausmann.

  • MiniBrowser/qt/MiniBrowser.qrc:
  • MiniBrowser/qt/qml/BrowserWindow.qml:
  • MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Added.
15:18 Changeset [108681] by oliver@apple.com

Make Interpreter::getStackTrace be able to generate the line number for the top callframe if none is provided
https://bugs.webkit.org/show_bug.cgi?id=79407

Reviewed by Gavin Barraclough.

Outside of exception handling, we don't know what our source line number is. This
change allows us to pass -1 is as the initial line number, and get the correct line
number in the resultant stack trace. We can't completely elide the initial line
number (yet) due to some idiosyncrasies of the exception handling machinery.

  • interpreter/Interpreter.cpp:

(JSC::getLineNumberForCallFrame):
(JSC):
(JSC::Interpreter::getStackTrace):

15:13 Changeset [108680] by senorblanco@chromium.org

[chromium] New baselines for CSS3 filters drop-shadow() tests.

Unreviewed gardening.

  • platform/chromium-linux/css3/filters/effect-drop-shadow-hw-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-drop-shadow-hw-expected.png:
  • platform/chromium-win/css3/filters/effect-drop-shadow-hw-expected.png:
  • platform/chromium/test_expectations.txt:
15:12 Changeset [108679] by enne@google.com

Unreviewed, rolling out r108666.
http://trac.webkit.org/changeset/108666
https://bugs.webkit.org/show_bug.cgi?id=79321

Breaks webplugin tests: http://goo.gl/CoHIi

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore):
(WebCore::GraphicsContext3DPrivate::create):
(WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):
(WebCore::GraphicsContext3DPrivate::createGraphicsContextForAnotherThread):
(WebCore::GraphicsContext3DPrivate::platformTexture):
(WebCore::GraphicsContext3D::create):

  • src/GraphicsContext3DPrivate.h:

(WebKit):
(GraphicsContext3DPrivate):

  • src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::createLayerTreeHostContext3D):

  • src/WebViewImpl.cpp:

(std::getCompositorContextAttributes):
(WebKit::WebViewImpl::createLayerTreeHostContext3D):
(WebKit::WebViewImpl::graphicsContext3D):

  • tests/CCLayerTreeHostImplTest.cpp:

(CCLayerTreeHostImplTest):
(WebKit::TEST_F):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):

  • tests/Canvas2DLayerChromiumTest.cpp:

(WebCore::Canvas2DLayerChromiumTest::fullLifecycleTest):

  • tests/CompositorFakeGraphicsContext3D.h:

(WebCore::createCompositorMockGraphicsContext3D):

  • tests/FakeGraphicsContext3DTest.cpp:

(TEST):

15:03 Changeset [108678] by commit-queue@webkit.org

[chromium] Push CCLayerIteratorPosition struct into CCLayerIterator class.
https://bugs.webkit.org/show_bug.cgi?id=75864

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-23
Reviewed by James Robinson.

  • platform/graphics/chromium/cc/CCLayerIterator.cpp:

(WebCore::CCLayerIteratorActions::BackToFront::begin):
(WebCore::CCLayerIteratorActions::BackToFront::end):
(WebCore::CCLayerIteratorActions::BackToFront::next):
(WebCore::CCLayerIteratorActions::FrontToBack::begin):
(WebCore::CCLayerIteratorActions::FrontToBack::end):
(WebCore::CCLayerIteratorActions::FrontToBack::next):
(WebCore::CCLayerIteratorActions::FrontToBack::goToHighestInSubtree):

  • platform/graphics/chromium/cc/CCLayerIterator.h:

(WebCore::CCLayerIterator::CCLayerIterator):
(WebCore::CCLayerIterator::operator++):
(WebCore::CCLayerIterator::operator==):
(WebCore::CCLayerIterator::operator->):
(WebCore::CCLayerIterator::operator*):
(WebCore::CCLayerIterator::representsTargetRenderSurface):
(WebCore::CCLayerIterator::representsContributingRenderSurface):
(WebCore::CCLayerIterator::currentLayer):
(WebCore::CCLayerIterator::currentLayerRepresentsContributingRenderSurface):
(WebCore::CCLayerIterator::currentLayerRepresentsTargetRenderSurface):
(WebCore::CCLayerIterator::targetRenderSurfaceLayer):
(WebCore::CCLayerIterator::targetRenderSurface):
(WebCore::CCLayerIterator::targetRenderSurfaceChildren):

  • platform/graphics/chromium/cc/CCLayerIteratorPosition.h: Removed.
14:51 Changeset [108677] by fpizlo@apple.com

DFG OSR exit value profiling should have graceful handling of local variables and arguments
https://bugs.webkit.org/show_bug.cgi?id=79310

Reviewed by Gavin Barraclough.

Previously, if we OSR exited because a prediction in a local was wrong, we'd
only realize what the true type of the local was if the regular value profiling
kicked in and told us. Unless the local was block-locally copy propagated, in
which case we'd know from an OSR exit profile.

This patch adds OSR exit profiling to all locals and arguments. Now, if we OSR
exit because of a mispredicted local or argument type, we'll know what the type of
the local or argument should be immediately upon exiting.

The way that local variable OSR exit profiling works is that we now have a lazily
added set of OSR-exit-only value profiles for exit sites that are BadType and that
cited a GetLocal as their value source. The value profiles are only added if the
OSR exit is taken, and are keyed by CodeBlock, bytecode index of the GetLocal, and
operand. The look-up is performed by querying the
CompressedLazyOperandValueProfileHolder in the CodeBlock, using a key that contains
the bytecode index and the operand. Because the value profiles are added at random
times, they are not sorted; instead they are just stored in an arbitrarily-ordered
SegmentedVector. Look-ups are made fast by "decompressing": the DFG::ByteCodeParser
creates a LazyOperandValueProfileParser, which turns the
CompressedLazyOperandValueProfileHolder's contents into a HashMap for the duration
of DFG parsing.

Previously, OSR exits had a pointer to the ValueProfile that had the specFailBucket
into which values observed during OSR exit would be placed. Now it uses a lazy
thunk for a ValueProfile. I call this the MethodOfGettingAValueProfile. It may
either contain a ValueProfile inside it (which works for previous uses of OSR exit
profiling) or it may just have knowledge of how to go about creating the
LazyOperandValueProfile in the case that the OSR exit is actually taken. This
ensures that we never have to create NumOperands*NumBytecodeIndices*NumCodeBlocks
value profiling buckets unless we actually did OSR exit on every single operand,
in every single instruction, in each code block (that's probably unlikely).

This appears to be neutral on the major benchmarks, but is a double-digit speed-up
on code deliberately written to have data flow that spans basic blocks and where
the code exhibits post-optimization polymorphism in a local variable.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::stronglyVisitStrongReferences):

  • bytecode/CodeBlock.h:

(CodeBlock):
(JSC::CodeBlock::lazyOperandValueProfiles):

  • bytecode/LazyOperandValueProfile.cpp: Added.

(JSC):
(JSC::CompressedLazyOperandValueProfileHolder::CompressedLazyOperandValueProfileHolder):
(JSC::CompressedLazyOperandValueProfileHolder::~CompressedLazyOperandValueProfileHolder):
(JSC::CompressedLazyOperandValueProfileHolder::computeUpdatedPredictions):
(JSC::CompressedLazyOperandValueProfileHolder::add):
(JSC::LazyOperandValueProfileParser::LazyOperandValueProfileParser):
(JSC::LazyOperandValueProfileParser::~LazyOperandValueProfileParser):
(JSC::LazyOperandValueProfileParser::getIfPresent):
(JSC::LazyOperandValueProfileParser::prediction):

  • bytecode/LazyOperandValueProfile.h: Added.

(JSC):
(LazyOperandValueProfileKey):
(JSC::LazyOperandValueProfileKey::LazyOperandValueProfileKey):
(JSC::LazyOperandValueProfileKey::operator!):
(JSC::LazyOperandValueProfileKey::operator==):
(JSC::LazyOperandValueProfileKey::hash):
(JSC::LazyOperandValueProfileKey::bytecodeOffset):
(JSC::LazyOperandValueProfileKey::operand):
(JSC::LazyOperandValueProfileKey::isHashTableDeletedValue):
(JSC::LazyOperandValueProfileKeyHash::hash):
(JSC::LazyOperandValueProfileKeyHash::equal):
(LazyOperandValueProfileKeyHash):
(WTF):
(JSC::LazyOperandValueProfile::LazyOperandValueProfile):
(LazyOperandValueProfile):
(JSC::LazyOperandValueProfile::key):
(CompressedLazyOperandValueProfileHolder):
(LazyOperandValueProfileParser):

  • bytecode/MethodOfGettingAValueProfile.cpp: Added.

(JSC):
(JSC::MethodOfGettingAValueProfile::fromLazyOperand):
(JSC::MethodOfGettingAValueProfile::getSpecFailBucket):

  • bytecode/MethodOfGettingAValueProfile.h: Added.

(JSC):
(MethodOfGettingAValueProfile):
(JSC::MethodOfGettingAValueProfile::MethodOfGettingAValueProfile):
(JSC::MethodOfGettingAValueProfile::operator!):

  • bytecode/ValueProfile.cpp: Removed.
  • bytecode/ValueProfile.h:

(JSC):
(ValueProfileBase):
(JSC::ValueProfileBase::ValueProfileBase):
(JSC::ValueProfileBase::dump):
(JSC::ValueProfileBase::computeUpdatedPrediction):
(JSC::MinimalValueProfile::MinimalValueProfile):
(ValueProfileWithLogNumberOfBuckets):
(JSC::ValueProfileWithLogNumberOfBuckets::ValueProfileWithLogNumberOfBuckets):
(JSC::ValueProfile::ValueProfile):
(JSC::getValueProfileBytecodeOffset):
(JSC::getRareCaseProfileBytecodeOffset):

  • dfg/DFGByteCodeParser.cpp:

(ByteCodeParser):
(JSC::DFG::ByteCodeParser::injectLazyOperandPrediction):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(InlineStackEntry):
(JSC::DFG::ByteCodeParser::fixVariableAccessPredictions):
(DFG):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::valueProfileFor):
(JSC::DFG::Graph::methodOfGettingAValueProfileFor):
(Graph):

  • dfg/DFGNode.h:

(Node):

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::OSRExit):

  • dfg/DFGOSRExit.h:

(OSRExit):

  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGPhase.cpp:

(JSC::DFG::Phase::beginPhase):
(JSC::DFG::Phase::endPhase):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArgumentTypes):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::speculationCheck):

  • dfg/DFGVariableAccessData.h:

(JSC::DFG::VariableAccessData::nonUnifiedPrediction):
(VariableAccessData):

14:41 Changeset [108676] by andersca@apple.com

Flush layer changes after layout when resizing web page
https://bugs.webkit.org/show_bug.cgi?id=79399
<rdar://problem/10920157>

Reviewed by Andreas Kling.

Flush layer changes after layout, otherwise the scrollbars won't be updated
until sometime later which looks bad.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):

14:10 Changeset [108675] by commit-queue@webkit.org

[Chromium] Add video stream texture support
https://bugs.webkit.org/show_bug.cgi?id=78398

This upstreams the abstraction used on Android for
hardware video decoding with the compositor.

Most of the interfaces are kept generic and the core
of this change is to allow texturing from an external
texture while receiving notifications (on the compositor
thread if we are running it) when there are new frames to
be displayed.

Patch by Daniel Sievers <sievers@chromium.org> on 2012-02-23
Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/Extensions3DChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawSingleTextureVideoQuad):
(WebCore::LayerRendererChromium::drawRGBA):
(WebCore::LayerRendererChromium::drawNativeTexture):
(WebCore):
(WebCore::LayerRendererChromium::drawStreamTexture):
(WebCore::LayerRendererChromium::drawVideoQuad):
(WebCore::LayerRendererChromium::streamTextureLayerProgram):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

  • platform/graphics/chromium/ShaderChromium.cpp:

(WebCore::VertexShaderVideoTransform::VertexShaderVideoTransform):
(WebCore):
(WebCore::VertexShaderVideoTransform::init):
(WebCore::VertexShaderVideoTransform::getShaderString):
(WebCore::FragmentShaderOESImageExternal::init):
(WebCore::FragmentShaderOESImageExternal::getShaderString):

  • platform/graphics/chromium/ShaderChromium.h:

(VertexShaderVideoTransform):
(WebCore::VertexShaderVideoTransform::matrixLocation):
(WebCore::VertexShaderVideoTransform::texTransformLocation):
(WebCore::VertexShaderVideoTransform::texMatrixLocation):
(WebCore):
(FragmentShaderOESImageExternal):

  • platform/graphics/chromium/VideoFrameChromium.h:
  • platform/graphics/chromium/VideoFrameProvider.h:

(Client):
(VideoFrameProvider):

  • platform/graphics/chromium/cc/CCVideoDrawQuad.cpp:

(WebCore::CCVideoDrawQuad::CCVideoDrawQuad):

  • platform/graphics/chromium/cc/CCVideoDrawQuad.h:

(WebCore::CCVideoDrawQuad::matrix):
(CCVideoDrawQuad):
(WebCore::CCVideoDrawQuad::setMatrix):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore):
(WebCore::CCVideoLayerImpl::CCVideoLayerImpl):
(WebCore::convertVFCFormatToGC3DFormat):
(WebCore::CCVideoLayerImpl::appendQuads):
(WebCore::CCVideoLayerImpl::didReceiveFrame):
(WebCore::CCVideoLayerImpl::didUpdateMatrix):
(WebCore::CCVideoLayerImpl::setNeedsRedraw):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:

(WebCore):
(CCVideoLayerImpl):

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebMediaPlayer.h:

(WebKit):
(WebKit::WebMediaPlayer::setStreamTextureClient):
(WebMediaPlayer):

  • public/WebStreamTextureClient.h: Copied from Source/WebKit/chromium/public/WebVideoFrame.h.

(WebKit):
(WebStreamTextureClient):
(WebKit::WebStreamTextureClient::~WebStreamTextureClient):

  • public/WebVideoFrame.h:
  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
(WebKit::WebMediaPlayerClientImpl::setVideoFrameProviderClient):
(WebKit::WebMediaPlayerClientImpl::didReceiveFrame):
(WebKit):
(WebKit::WebMediaPlayerClientImpl::didUpdateMatrix):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

14:05 Changeset [108674] by senorblanco@chromium.org

Source/WebCore: [chromium] Implement drop-shadow() CSS filter on composited layers.
https://bugs.webkit.org/show_bug.cgi?id=79386

Reviewed by James Robinson.

Covered by css3/filters/effect-drop-shadow-hw.html

  • platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:

(WebCore::CCRenderSurfaceFilters::apply):

  • platform/graphics/filters/FilterOperation.h:

(WebCore::DropShadowFilterOperation::movesPixels):

LayoutTests: [chromium] Mark drop-shadow() tests as failing, pending a rebaseline.
https://bugs.webkit.org/show_bug.cgi?id=79386

Reviewed by James Robinson.

  • platform/chromium/test_expectations.txt:
13:52 Changeset [108673] by leviw@chromium.org

Cleaning up pixelSnappedLogical*OffsetForLine code.

13:42 Changeset [108672] by fpizlo@apple.com

Build fix.

  • llint/LLIntOffsetsExtractor.cpp:
13:41 Changeset [108671] by lforschler@apple.com

Versioning.

13:38 Changeset [108670] by lforschler@apple.com

New Tag.

13:23 Changeset [108669] by arv@chromium.org

Add support for InterfaceName in the bindings
https://bugs.webkit.org/show_bug.cgi?id=79384

Reviewed by Adam Barth.

This makes the interface name part of the idl file instead of being hard coded into the code generators.

  • bindings/scripts/CodeGenerator.pm:

(GetVisibleInterfaceName): Extracted from CodeGenerator{JS,V8}.pm and changed to look at the extended attribute.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
(GenerateConstructorDefinition):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementation):

  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::ConfigureV8TestObjTemplate):

  • dom/DOMCoreException.idl: Set the InterfaceName.
  • html/DOMFormData.idl: Ditto.
  • plugins/DOMMimeType.idl: Ditto.
  • plugins/DOMMimeTypeArray.idl: Ditto.
  • plugins/DOMPlugin.idl: Ditto.
  • plugins/DOMPluginArray.idl: Ditto.
13:17 Changeset [108668] by rniwa@webkit.org

REGRESSION(r99076): WebKit pastes the trailing newline into a single-line text field
https://bugs.webkit.org/show_bug.cgi?id=79305

Reviewed by Tony Chang.

Source/WebCore:

The bug was caused by ReplacementFragment::m_hasInterchangeNewlineAtEnd not reset even when
text field's beforeTextInserted event handler removed interchange new lines at the end.
Because the event handler is responsible for trimming new lines, we need to recompute the values
for m_hasInterchangeNewlineAt* after the event dispatch.

Test: editing/input/paste-text-ending-with-interchange-newline.html

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplacementFragment::ReplacementFragment):

LayoutTests:

Add a regression test. Also make Markup.dump() dump the shadow DOM of the specififed node.

  • editing/input/paste-text-ending-with-interchange-newline-expected.txt: Added.
  • editing/input/paste-text-ending-with-interchange-newline.html: Added.
  • resources/dump-as-markup.js:

(Markup._get):
(Markup._getShadowHostIfPossible):

13:15 Changeset [108667] by kling@webkit.org

Make use of StylePropertySet::setProperty(propertyID, CSSValue).
<http://webkit.org/b/79374>

Reviewed by Antti Koivisto.

Use the new setProperty() overload that takes a CSSValue in more places. This allows us
to get rid of 1/3 setProperty() overloads that don't expand shorthands.

  • css/StylePropertySet.h:
  • css/StylePropertySet.cpp:

Remove the setProperty() overload for specific primitive value types. StyledElement
can take care of this without help from StylePropertySet.

  • dom/StyledElement.h:
  • dom/StyledElement.cpp:

(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::addPropertyToAttributeStyle):

Switch some functions over to using the setProperty() overload that takes a CSSValue.

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::applyBorderAttributeToStyle):

  • html/HTMLHRElement.cpp:

(WebCore::HTMLHRElement::collectStyleForAttribute):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::collectStyleForAttribute):

  • html/HTMLTablePartElement.cpp:

(WebCore::HTMLTablePartElement::collectStyleForAttribute):

Use shorthands where possible to shrink the code a bit. Pass border widths as CSS_PX
values directly instead of making a CSSParser round-trip.

13:09 Changeset [108666] by jamesr@google.com

[chromium] Clean up GraphicsContext3D initialization paths
https://bugs.webkit.org/show_bug.cgi?id=79321

Reviewed by Kenneth Russell.

This simplifies the GraphicsContext3D initialization paths down to two simple codepaths, one for offscreen
contexts initialized from WebCore and one for onscreen (compositor) contexts initialized by WebViewImpl or
WebLayerTreeViewImpl.

Offscreen initialization path:
1) WebCore code calls WebCore::GraphicsContext3D::create(), implemented in GraphicsContext3DChromium.cpp
2) GraphicsContext3D::create() instantiates a WebGraphicsContext3D via the static WebKitPlatformSupport interface
3) GraphicsContext3DPrivate::createGraphicsContextFromWebContext() wraps the WebGraphicsContext3D in a
GraphicsContext3D's m_private pointer.

Onscreen initialization path:
1) WebViewImpl or WebLayerTreeViewImpl request an onscreen WebGraphicsContext3D from either their WebViewClient
or WebLayerTreeViewClient, respectively
2) GraphicsContext3DPrivate::createGraphicsContextFromWebContext() wraps the WebGraphicsContext3D in a
GraphicsContext3D's m_private pointer.

There are no other initialization paths. Specifically, we do not support instantiating onscreen contexts from
within WebCore.

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):
(WebCore):
(WebCore::GraphicsContext3DPrivate::platformTexture):
(WebCore::GraphicsContext3D::create):

  • src/GraphicsContext3DPrivate.h:

(GraphicsContext3DPrivate):

  • src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::createLayerTreeHostContext3D):

  • src/WebViewImpl.cpp:

(std::getCompositorContextAttributes):
(WebKit::WebViewImpl::createLayerTreeHostContext3D):
(WebKit::WebViewImpl::graphicsContext3D):

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::CCLayerTreeHostImplTest::createContext):
(CCLayerTreeHostImplTest):
(WebKit::TEST_F):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):

  • tests/Canvas2DLayerChromiumTest.cpp:

(WebCore::Canvas2DLayerChromiumTest::fullLifecycleTest):

  • tests/CompositorFakeGraphicsContext3D.h:

(WebCore::createCompositorMockGraphicsContext3D):

  • tests/FakeGraphicsContext3DTest.cpp:

(TEST):

13:06 Changeset [108665] by commit-queue@webkit.org

Add UserGestureIndicator capability to Chromium API.
https://bugs.webkit.org/show_bug.cgi?id=77690

Patch by Greg Billock <gbillock@google.com> on 2012-02-23
Reviewed by Darin Fisher.

  • WebKit.gyp:
  • public/WebScopedUserGesture.h: Added.
  • src/WebScopedUserGesture.cpp: Added.
12:54 Changeset [108664] by kevino@webkit.org

[wx] Build fixes, update the build system after recent changes.

12:52 Changeset [108663] by kevino@webkit.org

[wx] Build fix, use the strings in LocalizedStrings.cpp.

12:51 Changeset [108662] by dbates@webkit.org

Add missing "Reviewed by" line to change log entry for changeset r108631
(https://bugs.webkit.org/show_bug.cgi?id=79252)

The patch landed in changeset r108631 was reviewed by Martin Robinson.

  • ChangeLog:
12:48 Changeset [108661] by kevino@webkit.org

[wx] Build fix, disable LLINT for now and fix ENABLE defines for it.

12:47 Changeset [108660] by kevino@webkit.org

[wx] Build fix for non-Mac wx builds.

12:46 Changeset [108659] by alokp@chromium.org

Microsoft IE fishtank demo causes assertion in RenderLayer::convertToLayerCoords
https://bugs.webkit.org/show_bug.cgi?id=61964

Reviewed by James Robinson.

The assertion is caused with the following callstack:
WebCore::RenderLayer::convertToLayerCoords
WebCore::RenderLayerCompositor::layerWillBeRemoved
WebCore::RenderLayer::removeChild
WebCore::RenderLayer::removeOnlyThisLayer

WebCore::RenderLayer::removeOnlyThisLayer removes itself from the parent
before moving its children to its parent. When WebCore::RenderLayer::convertToLayerCoords
is called for one of the children, it tries to walk to root only to stop at the immediate
parent which was disconnected from the tree in WebCore::RenderLayer::removeOnlyThisLayer.
If removal of layer is delayed until the children has been moved, the ASSERT is avoided.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::removeOnlyThisLayer):

12:43 WikiStart edited by kov@webkit.org
(diff)
12:27 Changeset [108658] by mdelaney@apple.com

Missed an if from r108657.

12:17 Changeset [108657] by mdelaney@apple.com

Fix for canvas breakage caused by r108597 from the following:
https://bugs.webkit.org/show_bug.cgi?id=79317

Reviewed by Oliver Hunt.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::paintsIntoCanvasBuffer):

12:06 Changeset [108656] by pfeldman@chromium.org

Web Inspector: mad Redo to Cmd+Shift+Z, not Cmd+Y on a Mac.
https://bugs.webkit.org/show_bug.cgi?id=79341

Reviewed by Timothy Hatcher.

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.handleShortcut):

12:02 Changeset [108655] by ossy@webkit.org

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Skip a failing test.
11:58 Changeset [108654] by rniwa@webkit.org

Mac build fix after 108629.

  • WebCore.exp.in:
11:46 Changeset [108653] by tsepez@chromium.org

[chromium] XSS Auditor bypass via javascript url and control characters
https://bugs.webkit.org/show_bug.cgi?id=79154

Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/xssAuditor/javascript-link-control-char2.html

  • html/parser/XSSAuditor.cpp:

(WebCore):
(WebCore::XSSAuditor::eraseDangerousAttributesIfInjected):

LayoutTests:

  • http/tests/security/xssAuditor/javascript-link-control-char2-expected.txt: Added.
  • http/tests/security/xssAuditor/javascript-link-control-char2.html: Added.
  • platform/chromium/http/tests/security/xssAuditor: Added.
  • platform/chromium/http/tests/security/xssAuditor/javascript-link-control-char2-expected.txt: Added.
11:45 Changeset [108652] by fpizlo@apple.com

DFG's logic for emitting a Flush is too convoluted and contains an inaccurate comment
https://bugs.webkit.org/show_bug.cgi?id=79334

Reviewed by Oliver Hunt.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::flush):

11:43 Changeset [108651] by barraclough@apple.com

Object.isSealed / Object.isFrozen don't work for native objects
https://bugs.webkit.org/show_bug.cgi?id=79331

Reviewed by Sam Weinig.

Need to inspect all properties, including static ones.
This exposes a couple of bugs in Array & Arguments:

  • getOwnPropertyDescriptor doesn't correctly report the writable attribute of array length.
  • Arguments object's defineOwnProperty does not handle callee/caller/length correctly.

Source/JavaScriptCore:

  • runtime/Arguments.cpp:

(JSC::Arguments::defineOwnProperty):

  • Add handling for callee/caller/length.
  • runtime/JSArray.cpp:

(JSC::JSArray::getOwnPropertyDescriptor):

  • report length's writability correctly.
  • runtime/ObjectConstructor.cpp:

(JSC::objectConstructorSeal):
(JSC::objectConstructorFreeze):
(JSC::objectConstructorIsSealed):
(JSC::objectConstructorIsFrozen):

  • Add spec-based implementation for non-final objects.

LayoutTests:

  • fast/js/preventExtensions-expected.txt:
  • fast/js/script-tests/preventExtensions.js:
    • Added tests.
11:41 Changeset [108650] by barraclough@apple.com

pop of array hole should get from the prototype chain
https://bugs.webkit.org/show_bug.cgi?id=79338

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • runtime/JSArray.cpp:

(JSC::JSArray::pop):

  • If the fast fast vector case fails, more closely follow the spec.

LayoutTests:

  • sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.6_Array_prototype_pop/S15.4.4.6_A4_T1-expected.txt:
    • Checking passing test result.
11:29 Changeset [108649] by commit-queue@webkit.org

JSString::outOfMemory() should ASSERT(isRope()) rather than !isRope()
https://bugs.webkit.org/show_bug.cgi?id=79268

Patch by Yong Li <yoli@rim.com> on 2012-02-23
Reviewed by Michael Saboff.

resolveRope() is the only caller of outOfMemory(), and it calls outOfMemory()
after it fails to allocate a buffer for m_value. So outOfMemory() should assert
isRope() rather than !isRope().

  • runtime/JSString.cpp:

(JSC::JSString::outOfMemory):

11:23 Changeset [108648] by paroga@webkit.org

[CMake] Add WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS macro
https://bugs.webkit.org/show_bug.cgi?id=79371

Reviewed by Daniel Bates.

.:

Add a new macro to handle the inclusion of the platform specific *.cmake files.
In the future this macro should get expanded to also handle feature specifc
files, like the UseJSC.cmake in WebCore we already have.

  • Source/cmake/WebKitMacros.cmake:

Source/JavaScriptCore:

  • CMakeLists.txt:
  • shell/CMakeLists.txt:
  • wtf/CMakeLists.txt:

Source/WebCore:

  • CMakeLists.txt:

Source/WebKit:

  • CMakeLists.txt:
  • PlatformBlackBerry.cmake: Renamed from Source/WebKit/blackberry/CMakeListsBlackBerry.txt.
  • PlatformEfl.cmake: Renamed from Source/WebKit/efl/CMakeListsEfl.txt.
  • PlatformWinCE.cmake: Renamed from Source/WebKit/wince/CMakeListsWinCE.txt.

Source/WebKit2:

  • CMakeLists.txt:
11:15 Changeset [108647] by paroga@webkit.org

[CMake] Add FindDirectX
https://bugs.webkit.org/show_bug.cgi?id=79344

Reviewed by Adam Roben.

  • Source/cmake/FindDirectX.cmake: Added.
11:14 Changeset [108646] by ossy@webkit.org

[Qt] Unreviewed gardening.

  • platform/qt/Skipped:
  • platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png:
  • platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
11:12 Changeset [108645] by jchaffraix@webkit.org

Cleanup RenderBlock::moveChildrenTo
https://bugs.webkit.org/show_bug.cgi?id=79319

Reviewed by Eric Seidel.

Refactoring, no change in behavior expected.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::moveChildrenTo):
Removed inline check that was redundant, switched to |while| to a |for|
to show what's going on more closely and adds a call to moveChildTo to
share more code between the 2 functions.

11:06 Changeset [108644] by paroga@webkit.org

[CMake] Add FindQuickTimeSDK
https://bugs.webkit.org/show_bug.cgi?id=79345

Reviewed by Adam Roben.

  • Source/cmake/FindQuickTimeSDK.cmake: Added.
11:04 WebKitGTK/Releasing edited by carlosgc@webkit.org
(diff)
11:03 WebKitGTK/Releasing edited by carlosgc@webkit.org
Add more removed parts (diff)
11:00 WebKitGTK/Releasing edited by carlosgc@webkit.org
We are following GNOME schedule (diff)
11:00 Changeset [108643] by hausmann@webkit.org

[Qt] Add support for touch cancellation
https://bugs.webkit.org/show_bug.cgi?id=79348

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Map Qt touch cancel events to the WebCore equivalent.

No new tests, unskipped existing test for Qt 5.

  • platform/PlatformTouchPoint.h:

(PlatformTouchPoint):

  • platform/qt/PlatformTouchEventQt.cpp:

(WebCore::PlatformTouchEvent::PlatformTouchEvent):

  • platform/qt/PlatformTouchPointQt.cpp:

(WebCore::PlatformTouchPoint::PlatformTouchPoint):

Source/WebKit/qt:

Forward incoming touch cancellation events to the WebCore
event handler.

  • Api/qgraphicswebview.cpp:

(QGraphicsWebView::sceneEvent):

  • Api/qwebpage.cpp:

(QWebPage::event):

  • Api/qwebview.cpp:

(QWebView::event):

Source/WebKit2:

Convert and forward incoming touch cancellation events
to the web process.

  • Shared/qt/WebEventFactoryQt.cpp:

(WebKit::webEventTypeForEvent):
(WebKit::WebEventFactory::createWebTouchEvent):

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebView::event):

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::handleEvent):

Tools:

Added straight-forward touch cancellation event sending to Qt WK1 DRT
and WK2 WTR.

  • DumpRenderTree/qt/EventSenderQt.cpp:

(EventSender::touchCancel):
(EventSender::cancelTouchPoint):

  • DumpRenderTree/qt/EventSenderQt.h:

(EventSender):

  • WebKitTestRunner/EventSenderProxy.h:

(EventSenderProxy):

  • WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::EventSendingController::touchCancel):
(WTR):
(WTR::EventSendingController::cancelTouchPoint):

  • WebKitTestRunner/InjectedBundle/EventSendingController.h:

(EventSendingController):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):

  • WebKitTestRunner/qt/EventSenderProxyQt.cpp:

(WTR::EventSenderProxy::touchCancel):
(WTR):
(WTR::EventSenderProxy::cancelTouchPoint):

LayoutTests:

Moved touch cancel event layout tests from general skip list to the
Qt 4 specific one. The Qt 5 version we depend on has QEvent::TouchCancel, which
is all we need in order to implement touch cancellation in DRT/WTR.

  • platform/qt-4.8/Skipped:
  • platform/qt/Skipped:
10:59 WebKitGTK/Releasing edited by carlosgc@webkit.org
Bring back information about how to update library version (diff)
10:58 Changeset [108642] by bfulgham@webkit.org

[WinCairo] Build fix after r108428.

  • win/WebKit2CFLite.def: Add missing export declaration.
10:46 Changeset [108641] by hausmann@webkit.org

Fix the PRI macros used in WTF::String formatters to be compatible with Qt and Visual Studio 2005 and newer.
https://bugs.webkit.org/show_bug.cgi?id=76210

Add compile time check for Visual Studio 2005 or newer.

Patch by Aron Rosenberg <arosenberg@logitech.com> on 2012-02-23
Reviewed by Simon Hausmann.

  • os-win32/inttypes.h:
10:43 Changeset [108640] by hausmann@webkit.org

Unreviewed test fix after r108614: Adjust public API after changes.

  • UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp:
10:35 Changeset [108639] by ossy@webkit.org

[Qt] Build fix. Qt WebKit2 can not be compiled due to QtWebPageEventHandler.
https://bugs.webkit.org/show_bug.cgi?id=79335

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-02-23
Reviewed by Kenneth Rohde Christiansen.

In the upcoming Qt 5 builds the convenient setInputMethodHints method on QQuickItem
will be removed. There's no need for us to use it, we can implement passing the hints
to the input method right away in our re-implementation of inputMethodQuery, which works
with old and newer Qt 5 builds.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebView::inputMethodQuery):

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::updateTextInputState):

10:15 Changeset [108638] by arv@chromium.org

Unreviewed. Rebaseline binding test files.

  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:

(webkit_dom_test_interface_supplemental_method1):
(webkit_dom_test_interface_supplemental_method2):
(webkit_dom_test_interface_get_supplemental_str1):
(webkit_dom_test_interface_get_supplemental_str2):
(webkit_dom_test_interface_set_supplemental_str2):
(webkit_dom_test_interface_get_supplemental_node):
(webkit_dom_test_interface_set_supplemental_node):
(webkit_dom_test_interface_set_property):
(webkit_dom_test_interface_get_property):

10:10 Changeset [108637] by eae@chromium.org

Fix usage of enclosing/pixelSnapped/round in branch

10:01 Changeset [108636] by andersca@apple.com

Crash in ScrollElasticityController::snapRubberBandTimerFired()
https://bugs.webkit.org/show_bug.cgi?id=79372
<rdar://problem/10915193>

Reviewed by Andreas Kling.

Invalidate the rubber-band timer in the ScrollingTreeNodeMac destructor.

  • page/scrolling/mac/ScrollingTreeNodeMac.h:

(ScrollingTreeNodeMac):

  • page/scrolling/mac/ScrollingTreeNodeMac.mm:

(WebCore::ScrollingTreeNodeMac::~ScrollingTreeNodeMac):
(WebCore):

09:56 WebKitGTK/Releasing edited by mrobinson@webkit.org
(diff)
09:32 Changeset [108635] by commit-queue@webkit.org

Unreviewed, rolling out r108626.
http://trac.webkit.org/changeset/108626
https://bugs.webkit.org/show_bug.cgi?id=79370

broke qt-wk2 bot, somehow the workaround does not work on the
bot (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-23

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::WrapperWindow::handleStatusChanged):
(WTR::PlatformWebView::resizeTo):

09:31 WebKitGTK/Releasing edited by mrobinson@webkit.org
(diff)
09:30 WebKitGTK/1.8.x edited by sergio@webkit.org
(diff)
09:28 Changeset [108634] by pfeldman@chromium.org

Web Inspector: add experiment that loads stylesheets as links
https://bugs.webkit.org/show_bug.cgi?id=79340

Reviewed by Timothy Hatcher.

  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/View.js:

(WebInspector.View.prototype._doLoadCSS):

08:54 Changeset [108633] by paroga@webkit.org

Unreviewed WinCE build fix after r108462.

  • WebCoreSupport/EditorClientWinCE.h:

(EditorClientWinCE):

08:44 Changeset [108632] by peter@chromium.org

Unreviewed, rolling out r108627 and r108630.
https://bugs.webkit.org/show_bug.cgi?id=79367

ffmpeg is creating issues and was just reverted upstream as well.

  • DEPS:
08:38 Changeset [108631] by sergio@webkit.org

[WK2][GTK] WebProcess SIGSEVs due to incorrect clipboard handling
https://bugs.webkit.org/show_bug.cgi?id=79252

Do not execute clipboard callbacks after the Frame associated with
it is destroyed.

This change is already covered by the TestWebViewEditor unit tests
(among others), they hang (because WebProcess dies) without this
patch in Debug builds.

  • WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:

(EditorClientFrameDestructionObserver):
(WebKit::EditorClientFrameDestructionObserver::EditorClientFrameDestructionObserver):
(WebKit::EditorClientFrameDestructionObserver::frameDestroyed):
(WebKit::EditorClientFrameDestructionObserver::destroyOnClosureFinalization):
(WebKit):
(WebKit::WebEditorClient::setSelectionPrimaryClipboardIfNeeded):

08:19 Changeset [108630] by peter@chromium.org

Unreviewed build fix. Remove the ffmpeg binary directory from the
Chromium-Windows DEPS file, following the commit done in the
Chromium repository:
http://src.chromium.org/viewvc/chrome?view=rev&revision=123123

  • DEPS:
08:08 Changeset [108629] by aroben@apple.com

Mac build fix after r108615

  • WebCore.exp.in: Added a missing export.
07:57 Changeset [108628] by commit-queue@webkit.org

[GTK] DRT doesn't support scheduleAsynchronousKeyDown.
https://bugs.webkit.org/show_bug.cgi?id=78481

Patch by ChangSeok Oh <shivamidow@gmail.com> on 2012-02-23
Reviewed by Gustavo Noronha Silva.

Source/WebKit/gtk:

Added a new API to deliver all mutations explicitly.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::deliverAllMutationsIfNecessary):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Tools:

Extracted shareable code from keyDownCallback and then added createKeyPressEvent
to create gdk press key event.
Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.

  • DumpRenderTree/gtk/EventSender.cpp:

(scheduleAsynchronousClickCallback):
(createKeyPressEvent):
(sendKeyDown):
(keyDownCallback):
(sendAsynchronousKeyDown):
(scheduleAsynchronousKeyDownCallback):

LayoutTests:

Removed following skipped tests.
fast/mutation/end-of-task-delivery.html
fast/mutation/inline-event-listener.html

  • platform/gtk/Skipped:
07:30 Changeset [108627] by peter@chromium.org

Unreviewed. Rolled DEPS.

  • DEPS:
07:28 Changeset [108626] by kbalazs@webkit.org

[Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
https://bugs.webkit.org/show_bug.cgi?id=76546

Reviewed by Simon Hausmann.

Co-authored with Simon Hausmann.

Revert the workaround introduced in r107868 and reintroduce
the qml binding so we can test the code path that we are more
interested in. The reason that it did not work before is that
we don't have an active platform window which we now workaround
by propagating the resize through QWindowSystemInterface.

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::WrapperWindow::handleStatusChanged):
(WTR::PlatformWebView::resizeTo):

07:10 Changeset [108625] by kenneth@webkit.org

[Qt] Page doesn't get repainted while panning is in progress https://bugs.webkit.org/show_bug.cgi?id=78602

Reviewed by Simon Hausmann.

The tiling code needed the current visibleContentsRect in order to be
able to create tiles, so we now make sure it gets it. We also needed
to make sure to set the trajectory vector while panning and while the
flicking engine was animating kinetic scrolling.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewFlickablePrivate::_q_updateVisibleContentRectAndScale):
(QQuickWebViewPrivate::_q_viewportTrajectoryVectorChanged):

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::setVisibleContentRectTrajectoryVector):

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::setVisibleContentRectTrajectoryVector):

  • UIProcess/DrawingAreaProxyImpl.h:

(DrawingAreaProxyImpl):

  • UIProcess/LayerTreeHostProxy.h:

(LayerTreeHostProxy):

  • UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::setVisibleContentRectTrajectoryVector):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::flickableMovingStateChanged):
(WebKit):
(WebKit::QtViewportInteractionEngine::panMoveStarted):
(WebKit::QtViewportInteractionEngine::panMoveEnded):
(WebKit::QtViewportInteractionEngine::flickableMovingPositionUpdate):
(WebKit::QtViewportInteractionEngine::panGestureRequestUpdate):

  • UIProcess/qt/QtViewportInteractionEngine.h:

(QtViewportInteractionEngine):

  • WebProcess/WebPage/LayerTreeHost.h:

(WebKit::LayerTreeHost::setVisibleContentRectTrajectoryVector):

  • WebProcess/WebPage/LayerTreeHost.messages.in:
  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::setVisibleContentRectAndScale):
(WebKit::LayerTreeHostQt::setVisibleContentRectTrajectoryVector):

  • WebProcess/WebPage/qt/LayerTreeHostQt.h:

(LayerTreeHostQt):

06:58 Changeset [108624] by commit-queue@webkit.org

Unreviewed, rolling out r108577.
http://trac.webkit.org/changeset/108577
https://bugs.webkit.org/show_bug.cgi?id=79359

It doesn't work as expected (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-23

Tools:

  • DumpRenderTree/qt/EventSenderQt.cpp:

(EventSender::postEvent):

  • DumpRenderTree/qt/EventSenderQt.h:

(EventSender):

LayoutTests:

  • platform/qt/Skipped:
04:26 Changeset [108623] by abarth@webkit.org

Move MediaStream related declarations from DOMWindow to DOMWindowMediaStream
https://bugs.webkit.org/show_bug.cgi?id=79343

Reviewed by Eric Seidel.

These declarations belong in the MEDIA_STREAM module.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • mediastream/DOMWindowMediaStream.idl: Added.
  • page/DOMWindow.idl:
01:32 Changeset [108622] by paroga@webkit.org

[CMAKE][WK2] Cleanup WebKit2/CMakeLists.txt.
https://bugs.webkit.org/show_bug.cgi?id=76122

Reviewed by Eric Seidel.

  • CMakeLists.txt: Removed hardcoded WTF_USE_JSC preprocessor definition.
00:51 Changeset [108621] by hausmann@webkit.org

[WK2] Trivial build fix after r108615.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

00:45 Changeset [108620] by philn@webkit.org

[GTK] FullScreen signals
https://bugs.webkit.org/show_bug.cgi?id=76181

Reviewed by Martin Robinson.

Source/WebKit/gtk:

Added entering-fullscreen and leaving-fullscreen signals, meant to
be used by the user agent to be notified when an element requests
full screen display and when the full screen display is to be
disabled.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::supportsFullScreenForElement):
(WebKit::onFullscreenGtkKeyPressEvent):
(WebKit::ChromeClient::cancelFullScreen):
(WebKit::ChromeClient::enterFullScreenForElement):
(WebKit::ChromeClient::exitFullScreenForElement):

  • WebCoreSupport/ChromeClientGtk.h:
  • tests/testwebview.c:
  • webkit/webkitwebview.cpp:

(webkit_web_view_real_entering_fullscreen):
(webkit_web_view_real_leaving_fullscreen):
(webkit_web_view_class_init):

  • webkit/webkitwebview.h:

Tools:

Use the two new entering/leaving fullscreen signals to hide/show
the tool bar, the status bar and ask the user's permission before
entering fullscreen.

  • GtkLauncher/main.c:

(webViewFullscreenMessageWindowClose):
(webViewWindowStateEvent):
(hide_widget):
(show_widget):
(webViewEnteringFullScreen):
(webViewLeavingFullScreen):
(createBrowser):
(createWindow):

00:32 Changeset [108619] by bashi@chromium.org

[Chromium] Unreviewed test expectations update for fast/css/font-face-default-font.html

  • platform/chromium-linux/fast/css/font-face-default-font-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/css/font-face-default-font-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/css/font-face-default-font-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/font-face-default-font-expected.txt: Removed.
  • platform/chromium-win/fast/css/font-face-default-font-expected.png:
  • platform/chromium-win/fast/css/font-face-default-font-expected.txt:
00:24 Changeset [108618] by ossy@webkit.org

[Qt] Unreviewed gardening.

  • platform/qt/Skipped:
  • platform/qt/fast/multicol/span/clone-flexbox-expected.png: Added.
  • platform/qt/fast/multicol/span/clone-flexbox-expected.txt: Added.
  • platform/qt/fast/multicol/span/clone-summary-expected.png: Added.
  • platform/qt/fast/multicol/span/clone-summary-expected.txt: Added.
  • platform/qt/svg/custom/circle-move-invalidation-expected.png:
  • platform/qt/svg/custom/circle-move-invalidation-expected.txt:
  • platform/qt/svg/repaint/inner-svg-change-viewPort-relative-expected.png: Added.
  • platform/qt/svg/repaint/inner-svg-change-viewPort-relative-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:

02/22/12:

23:36 Changeset [108617] by mitz@apple.com

Skipped a test that uses Chromium-only LayoutTestController functionality.

Rubber-stamped by Joseph Pecoraro.

  • platform/mac/Skipped: Added fast/dom/title-directionality-removeChild.html.
23:36 Changeset [108616] by igor.o@sisa.samsung.com

Every call to RenderObject::setAnimatableStyle() iterates through all m_compositeAnimations: potentially O(N2)
https://bugs.webkit.org/show_bug.cgi?id=38025

This patchs implements updateAnimationTimerForRenderer, it just checks the timeToNextService for
the current RenderObject reducing the amount of iterations.

Reviewed by Simon Fraser.

  • page/animation/AnimationController.cpp:

(WebCore):
(WebCore::AnimationControllerPrivate::updateAnimationTimerForRenderer):
(WebCore::AnimationController::updateAnimations):

  • page/animation/AnimationControllerPrivate.h:

(AnimationControllerPrivate):

23:29 Changeset [108615] by commit-queue@webkit.org

NOTIFICATIONS should be implemented as PageSupplement
https://bugs.webkit.org/show_bug.cgi?id=79052

Patch by Hajime Morrita <morrita@chromium.org> on 2012-02-22
Reviewed by Adam Barth.

Source/WebCore:

Turned NotificationController to a PageSupplement.

No new tests. No behavior change.

  • notifications/NotificationController.cpp:

(WebCore::NotificationController::clientFrom):
(WebCore):
(WebCore::NotificationController::supplementName):
(WebCore::provideNotification):

  • notifications/NotificationController.h:

(NotificationController):
(WebCore::NotificationController::from):

  • notifications/NotificationPresenter.h:

(WebCore):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::webkitNotifications):

  • page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::PageClients::PageClients):

  • page/Page.h:

(WebCore):
(PageClients):
(Page):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):

23:22 Changeset [108614] by commit-queue@webkit.org

[Qt][WK2] navigationType is missing in new API
https://bugs.webkit.org/show_bug.cgi?id=78867

Patch by Michael Tyutyunik <michael.tyutyunik@nokia.com> on 2012-02-22
Reviewed by Simon Hausmann.

In QtWebPagePolicyClient::decidePolicyForNavigationAction()
navigationType argument is dropped by mistake. Adding it back
and make it available through NavigationRequest.

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qwebnavigationrequest.cpp:

(QWebNavigationRequestPrivate::QWebNavigationRequestPrivate):
(QWebNavigationRequestPrivate):
(QWebNavigationRequest::QWebNavigationRequest):
(QWebNavigationRequest::navigationType):

  • UIProcess/API/qt/qwebnavigationrequest_p.h:
  • UIProcess/qt/QtWebPagePolicyClient.cpp:

(QtWebPagePolicyClient::decidePolicyForNavigationAction):
(toQuickWebViewNavigationType):

  • UIProcess/qt/QtWebPagePolicyClient.h:

(QtWebPagePolicyClient):

23:04 Changeset [108613] by dslomov@google.com

[Chromium][V8] Support Uint8ClampedArray in postMessage
https://bugs.webkit.org/show_bug.cgi?id=79291.

Reviewed by Kenneth Russell.

Source/WebCore:

Covered by existing tests.

  • bindings/v8/SerializedScriptValue.cpp:

LayoutTests:

  • platform/chromium/fast/canvas/webgl/array-message-passing-expected.txt: Removed.
22:50 Changeset [108612] by tkent@chromium.org

Move <input type=radio> tests to fast/forms/radio/
https://bugs.webkit.org/show_bug.cgi?id=78678

Reviewed by Kentaro Hara.

  • fast/forms/ValidityState-valueMissing-radio-expected.txt: Removed.
  • fast/forms/ValidityState-valueMissing-radio.html: Removed.
  • fast/forms/indeterminate-radio-expected.txt: Removed.
  • fast/forms/indeterminate-radio.html: Removed.
  • fast/forms/input-radio-checked-tab-expected.txt: Removed.
  • fast/forms/input-radio-checked-tab.html: Removed.
  • fast/forms/interactive-validation-required-radio-expected.txt: Removed.
  • fast/forms/interactive-validation-required-radio.html: Removed.
  • fast/forms/radio-attr-order-expected.txt: Removed.
  • fast/forms/radio-attr-order.html: Removed.
  • fast/forms/radio-button-no-change-event-expected.txt: Removed.
  • fast/forms/radio-button-no-change-event.html: Removed.
  • fast/forms/radio-check-click-and-drag-expected.txt: Removed.
  • fast/forms/radio-check-click-and-drag.html: Removed.
  • fast/forms/radio-default-value-expected.txt: Removed.
  • fast/forms/radio-default-value.html: Removed.
  • fast/forms/radio-group-keyboard-change-event-expected.txt: Removed.
  • fast/forms/radio-group-keyboard-change-event.html: Removed.
  • fast/forms/radio-nested-labels-expected.txt: Removed.
  • fast/forms/radio-nested-labels.html: Removed.
  • fast/forms/radio-no-theme-padding-expected.txt: Removed.
  • fast/forms/radio-no-theme-padding.html: Removed.
  • fast/forms/radio-remove-form-attr-expected.txt: Removed.
  • fast/forms/radio-remove-form-attr.html: Removed.
  • fast/forms/radio/ValidityState-valueMissing-radio-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-valueMissing-radio-expected.txt.
  • fast/forms/radio/ValidityState-valueMissing-radio.html: Copied from LayoutTests/fast/forms/ValidityState-valueMissing-radio.html.
  • fast/forms/radio/indeterminate-radio-expected.txt: Copied from LayoutTests/fast/forms/indeterminate-radio-expected.txt.
  • fast/forms/radio/indeterminate-radio.html: Copied from LayoutTests/fast/forms/indeterminate-radio.html.
  • fast/forms/radio/input-radio-checked-tab-expected.txt: Copied from LayoutTests/fast/forms/input-radio-checked-tab-expected.txt.
  • fast/forms/radio/input-radio-checked-tab.html: Copied from LayoutTests/fast/forms/input-radio-checked-tab.html.
  • fast/forms/radio/interactive-validation-required-radio-expected.txt: Copied from LayoutTests/fast/forms/interactive-validation-required-radio-expected.txt.
  • fast/forms/radio/interactive-validation-required-radio.html: Copied from LayoutTests/fast/forms/interactive-validation-required-radio.html.
  • fast/forms/radio/radio-attr-order-expected.txt: Copied from LayoutTests/fast/forms/radio-attr-order-expected.txt.
  • fast/forms/radio/radio-attr-order.html: Copied from LayoutTests/fast/forms/radio-attr-order.html.
  • fast/forms/radio/radio-button-no-change-event-expected.txt: Copied from LayoutTests/fast/forms/radio-button-no-change-event-expected.txt.
  • fast/forms/radio/radio-button-no-change-event.html: Copied from LayoutTests/fast/forms/radio-button-no-change-event.html.
  • fast/forms/radio/radio-check-click-and-drag-expected.txt: Copied from LayoutTests/fast/forms/radio-check-click-and-drag-expected.txt.
  • fast/forms/radio/radio-check-click-and-drag.html: Copied from LayoutTests/fast/forms/radio-check-click-and-drag.html.
  • fast/forms/radio/radio-default-value-expected.txt: Copied from LayoutTests/fast/forms/radio-default-value-expected.txt.
  • fast/forms/radio/radio-default-value.html: Copied from LayoutTests/fast/forms/radio-default-value.html.
  • fast/forms/radio/radio-group-keyboard-change-event-expected.txt: Copied from LayoutTests/fast/forms/radio-group-keyboard-change-event-expected.txt.
  • fast/forms/radio/radio-group-keyboard-change-event.html: Copied from LayoutTests/fast/forms/radio-group-keyboard-change-event.html.
  • fast/forms/radio/radio-nested-labels-expected.txt: Copied from LayoutTests/fast/forms/radio-nested-labels-expected.txt.
  • fast/forms/radio/radio-nested-labels.html: Copied from LayoutTests/fast/forms/radio-nested-labels.html.
  • fast/forms/radio/radio-no-theme-padding-expected.txt: Copied from LayoutTests/fast/forms/radio-no-theme-padding-expected.txt.
  • fast/forms/radio/radio-no-theme-padding.html: Copied from LayoutTests/fast/forms/radio-no-theme-padding.html.
  • fast/forms/radio/radio-remove-form-attr-expected.txt: Copied from LayoutTests/fast/forms/radio-remove-form-attr-expected.txt.
  • fast/forms/radio/radio-remove-form-attr.html: Copied from LayoutTests/fast/forms/radio-remove-form-attr.html.
  • fast/forms/radio/radio_checked-expected.txt: Copied from LayoutTests/fast/forms/radio_checked-expected.txt.
  • fast/forms/radio/radio_checked.html: Copied from LayoutTests/fast/forms/radio_checked.html.
  • fast/forms/radio/radio_checked_dynamic-expected.txt: Copied from LayoutTests/fast/forms/radio_checked_dynamic-expected.txt.
  • fast/forms/radio/radio_checked_dynamic.html: Copied from LayoutTests/fast/forms/radio_checked_dynamic.html.
  • fast/forms/radio/radio_checked_name-expected.txt: Copied from LayoutTests/fast/forms/radio_checked_name-expected.txt.
  • fast/forms/radio/radio_checked_name.html: Copied from LayoutTests/fast/forms/radio_checked_name.html.
  • fast/forms/radio/remove-radio-button-assert-expected.txt: Copied from LayoutTests/fast/forms/remove-radio-button-assert-expected.txt.
  • fast/forms/radio/remove-radio-button-assert.html: Copied from LayoutTests/fast/forms/remove-radio-button-assert.html.
  • fast/forms/radio/state-restore-radio-group-expected.txt: Copied from LayoutTests/fast/forms/state-restore-radio-group-expected.txt.
  • fast/forms/radio/state-restore-radio-group.html: Copied from LayoutTests/fast/forms/state-restore-radio-group.html.
  • fast/forms/radio_checked-expected.txt: Removed.
  • fast/forms/radio_checked.html: Removed.
  • fast/forms/radio_checked_dynamic-expected.txt: Removed.
  • fast/forms/radio_checked_dynamic.html: Removed.
  • fast/forms/radio_checked_name-expected.txt: Removed.
  • fast/forms/radio_checked_name.html: Removed.
  • fast/forms/remove-radio-button-assert-expected.txt: Removed.
  • fast/forms/remove-radio-button-assert.html: Removed.
  • fast/forms/state-restore-radio-group-expected.txt: Removed.
  • fast/forms/state-restore-radio-group.html: Removed.
22:40 Changeset [108611] by mitz@apple.com

Updated expected test results for the addition of -webkit-line-align (r108133) and the
renaming of -webkit-line-grid-snap (r107289).

Rubber-stamped by Andy Estes.

  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
22:26 Changeset [108610] by haraken@chromium.org

Enable Geolocation bindings for GObject
https://bugs.webkit.org/show_bug.cgi?id=79293

Reviewed by Adam Barth.

This patch adds "WebCore::" to supplemental method calls.
This will solve the GTK build failure we have observed in the Geolocation API,
and thus this patch enables the Geolocation API.

  • Modules/geolocation/NavigatorGeolocation.idl:
  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateProperty):
(GenerateFunction):

22:13 Changeset [108609] by bashi@chromium.org

REGRESSION (r107516): fast/css/font-face-default-font.html is failing
https://bugs.webkit.org/show_bug.cgi?id=79260

Add @font-face with "font-style: italic;" so that affecting the rule
for italic text.

Reviewed by Dan Bernstein.

  • fast/css/font-face-default-font.html:
21:58 Changeset [108608] by morrita@google.com

[Refactoring] Align supplementName() values.
https://bugs.webkit.org/show_bug.cgi?id=79311

Reviewed by Adam Barth.

No new tests. No behavioral change.

  • dom/DeviceOrientationController.cpp:

(WebCore::DeviceOrientationController::supplementName):

  • mediastream/UserMediaController.cpp:

(WebCore::UserMediaController::supplementName):

21:46 Changeset [108607] by yutak@chromium.org

Unreviewed, rolling out r108602.
http://trac.webkit.org/changeset/108602
https://bugs.webkit.org/show_bug.cgi?id=78878

Caused a couple of layout test failures on Chromium bots.

Source/WebCore:

  • dom/Element.cpp:

(WebCore::Element::childShouldCreateRenderer):

  • dom/Element.h:

(Element):

  • dom/Node.h:

(WebCore::Node::childShouldCreateRenderer):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::shouldCreateRenderer):

  • dom/NodeRenderingContext.h:

(NodeRenderingContext):

  • html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::childShouldCreateRenderer):

  • html/HTMLDetailsElement.h:

(HTMLDetailsElement):

  • html/HTMLMediaElement.cpp:

(WebCore):

  • html/HTMLMediaElement.h:

(HTMLMediaElement):

  • html/HTMLMeterElement.cpp:
  • html/HTMLMeterElement.h:

(HTMLMeterElement):

  • html/HTMLProgressElement.cpp:
  • html/HTMLProgressElement.h:

(HTMLProgressElement):

  • html/HTMLSelectElement.cpp:
  • html/HTMLSelectElement.h:

(HTMLSelectElement):

  • html/HTMLSummaryElement.cpp:
  • html/HTMLSummaryElement.h:

(HTMLSummaryElement):

  • html/HTMLTextFormControlElement.cpp:
  • html/HTMLTextFormControlElement.h:

(HTMLTextFormControlElement):

  • rendering/RenderButton.cpp:

(WebCore::RenderButton::canHaveChildren):
(WebCore):

  • rendering/RenderButton.h:

(RenderButton):

  • rendering/RenderListBox.h:

(WebCore::RenderListBox::canHaveChildren):
(RenderListBox):

  • rendering/RenderMedia.h:
  • rendering/RenderMenuList.h:

(WebCore::RenderMenuList::canHaveChildren):

  • rendering/RenderMeter.h:

(WebCore::RenderMeter::canHaveChildren):

  • rendering/RenderProgress.h:

(WebCore::RenderProgress::canHaveChildren):

  • rendering/RenderTextControl.h:

(WebCore::RenderTextControl::canHaveChildren):

  • rendering/svg/RenderSVGRoot.h:

(WebCore::RenderSVGRoot::canHaveChildren):

  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::childShouldCreateRenderer):

  • svg/SVGAElement.h:

(SVGAElement):

  • svg/SVGAltGlyphElement.cpp:

(WebCore::SVGAltGlyphElement::childShouldCreateRenderer):

  • svg/SVGAltGlyphElement.h:

(SVGAltGlyphElement):

  • svg/SVGDocument.cpp:

(WebCore::SVGDocument::childShouldCreateRenderer):

  • svg/SVGDocument.h:

(SVGDocument):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::childShouldCreateRenderer):

  • svg/SVGElement.h:

(SVGElement):

  • svg/SVGForeignObjectElement.cpp:

(WebCore::SVGForeignObjectElement::childShouldCreateRenderer):

  • svg/SVGForeignObjectElement.h:

(SVGForeignObjectElement):

  • svg/SVGSwitchElement.cpp:

(WebCore::SVGSwitchElement::childShouldCreateRenderer):

  • svg/SVGSwitchElement.h:

(SVGSwitchElement):

  • svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::childShouldCreateRenderer):

  • svg/SVGTRefElement.h:

(SVGTRefElement):

  • svg/SVGTSpanElement.cpp:

(WebCore::SVGTSpanElement::childShouldCreateRenderer):

  • svg/SVGTSpanElement.h:

(SVGTSpanElement):

  • svg/SVGTextElement.cpp:

(WebCore::SVGTextElement::childShouldCreateRenderer):

  • svg/SVGTextElement.h:

(SVGTextElement):

  • svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::childShouldCreateRenderer):

  • svg/SVGTextPathElement.h:

LayoutTests:

  • fast/dom/shadow/shadow-on-image-expected.html: Removed.
  • fast/dom/shadow/shadow-on-image.html: Removed.
  • platform/chromium/test_expectations.txt:
21:36 Changeset [108606] by inferno@chromium.org

Crash in RenderBlock::addChildIgnoringAnonymousColumnBlocks.
https://bugs.webkit.org/show_bug.cgi?id=79043

Reviewed by Julien Chaffraix.

Source/WebCore:

Tests: fast/runin/runin-div-before-child.html

fast/runin/runin-table-before-child.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks): handle
the case of run-in elements and strengthen code to handle cases where
beforeChild is incorrectly set.

  • rendering/RenderObject.h: remove anonymousContainer function since

the new logic in RenderBlock does not need it.

LayoutTests:

  • fast/runin/runin-div-before-child-expected.png: Added.
  • fast/runin/runin-div-before-child-expected.txt: Added.
  • fast/runin/runin-div-before-child.html: Added.
  • fast/runin/runin-table-before-child-expected.png: Added.
  • fast/runin/runin-table-before-child-expected.txt: Added.
  • fast/runin/runin-table-before-child.html: Added.
21:14 Changeset [108605] by hayato@chromium.org

Make ShadowRootList manage a node distribution.
https://bugs.webkit.org/show_bug.cgi?id=79008

Reviewed by Dimitri Glazkov.

The result of node distributions is currently stored in
ShadowRoot. To support multiple ShadowRoots, such node distribution
information should be managed in one place per shadow host. Now
ShadowRootList takes this responsibility on behalf of owing
multiple ShadowRoots. Clients should ask ShadowRootList for such
information, not for each ShadowRoot.

No tests. No change in behavior.

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::create):
(WebCore::ShadowRoot::attach):

  • dom/ShadowRoot.h:

(ShadowRoot):

  • dom/ShadowRootList.cpp:

(WebCore::ShadowRootList::insertionPointFor):
(WebCore):
(WebCore::ShadowRootList::isSelectorActive):
(WebCore::ShadowRootList::ensureSelector):

  • dom/ShadowRootList.h:

(WebCore):
(ShadowRootList):
(WebCore::ShadowRootList::hasShadowRoot):
(WebCore::ShadowRootList::youngestShadowRoot):
(WebCore::ShadowRootList::oldestShadowRoot):
(WebCore::ShadowRootList::selector):
(WebCore::ShadowRootList::host):

  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::attach):
(WebCore::HTMLContentElement::detach):

  • html/shadow/HTMLContentSelector.cpp:

(WebCore::HTMLContentSelector::willSelectOver):

  • html/shadow/HTMLContentSelector.h:

(HTMLContentSelector):

20:51 Changeset [108604] by commit-queue@webkit.org

Add multi channels support in AudioBus and AudioBufferSourceNode
https://bugs.webkit.org/show_bug.cgi?id=79017

Patch by Wei James <james.wei@intel.com> on 2012-02-22
Reviewed by Chris Rogers.

Source/WebCore:

Tests: webaudio/up-mixing-mono-51.html

webaudio/up-mixing-mono-stereo.html
webaudio/up-mixing-stereo-51.html

  • platform/audio/AudioBus.cpp:

(WebCore::AudioBus::copyFrom):
(WebCore::AudioBus::sumFrom):
(WebCore::AudioBus::processWithGainFromMonoStereo):
(WebCore::AudioBus::processWithGainFrom):

LayoutTests:

  • webaudio/resources/audio-testing.js:

(writeAudioBuffer):

  • webaudio/resources/mix-testing.js: Added.

(createToneBuffer):

  • webaudio/up-mixing-mono-51-expected.wav: Added.
  • webaudio/up-mixing-mono-51.html: Added.
  • webaudio/up-mixing-mono-stereo-expected.wav: Added.
  • webaudio/up-mixing-mono-stereo.html: Added.
  • webaudio/up-mixing-stereo-51-expected.wav: Added.
  • webaudio/up-mixing-stereo-51.html: Added.
20:24 Changeset [108603] by haraken@chromium.org

[Supplemental] should support constants
https://bugs.webkit.org/show_bug.cgi?id=79303

Reviewed by Adam Barth.

Given that we have

interface [Supplemental=Y] X { constant int A = 123; }

then the code generator should generate

X::A

to refer to the constant. However, the current code generator generates Y::A instead.
This patch fixes it.

Test: bindings/scripts/test/TestSupplemental.idl

  • bindings/scripts/CodeGenerator.pm: Modified as described above.

(GenerateCompileTimeCheckForEnumsIfNeeded):

  • bindings/scripts/test/JS/JSTestInterface.cpp: Updated run-bindings-tests results.

(WebCore):

  • bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.

(WebCore):

  • page/DOMWindow.h: Moved DOMWindow::FileSystemType to DOMWindowFileSystem::FileSystemType.

(DOMWindow):

  • fileapi/DOMWindowFileSystem.h: Ditto.

(DOMWindowFileSystem):

  • fileapi/DOMWindowFileSystem.cpp: Ditto.

(WebCore):

20:01 Changeset [108602] by morrita@google.com

Adding a ShadowRoot to image-backed element causes a crash
https://bugs.webkit.org/show_bug.cgi?id=78878

Reviewed by Dimitri Glazkov.

Source/WebCore:

The crash happened because NodeRenderingContext tried to append a
child to a renderer regardless one isn't capable of holding any
children if it appears in the shadow attaching phase. RenderImage
is one of such renderer classes which aren't capable.

NodeRenderingContext decide whether the contextual node as a child
can create its renderer based on RenderObject::canHaveChildren()
and Node::childShouldCreateRenderer(). But the responsibility
between these two methods are getting confused. which results this
unfortuante crash path.

This change re-aligns the responsibility:

  • Now canHaveChildren() purely declares the ability of the renderer. If the renderer is capable of having children, it return true regardless of HTML semantics.
  • On the other hand, childShouldCreateRenderer() cares about the semantics. If the element doesn't allow children to be rendered, this returns false.
  • Note that these decision on elements are contextual. Each element needs to know which role it is playing in the tree composition algorithm of Shadow DOM. That's why the method parameter is changed from Node* to NodeRenderingContext.

With this change, some decision points are moved from a renderer to an
element. Following renderers no longer stop reject having children:

  • RenderButton, RenderListBox, RenderMenuList, RenderMeter, RenderProgress, RenderTextControl.

Corresponding element for such a render (HTMLProgressElement of
RenderProgress for exaple) now cares about that.

Tests: fast/dom/shadow/shadow-on-image-expected.html
fast/dom/shadow/shadow-on-image.html

  • dom/Element.cpp:

(WebCore::Element::childShouldCreateRenderer):

  • dom/Element.h:

(Element):

  • dom/Node.h:
  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::shouldCreateRenderer):

  • dom/NodeRenderingContext.h:

(NodeRenderingContext):
(WebCore::NodeRenderingContext::isOnEncapsulationBoundary):
(WebCore):

  • html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::childShouldCreateRenderer):

  • html/HTMLDetailsElement.h:

(HTMLDetailsElement):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::childShouldCreateRenderer):
(WebCore):

  • html/HTMLMeterElement.h:

(HTMLMeterElement):

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::childShouldCreateRenderer):

  • html/HTMLMediaElement.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::childShouldCreateRenderer):
(WebCore):

  • html/HTMLProgressElement.h:

(HTMLProgressElement):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::childShouldCreateRenderer):
(WebCore):

  • html/HTMLSelectElement.h:

(HTMLSelectElement):

  • html/HTMLSummaryElement.cpp:
  • html/HTMLSummaryElement.h:

(HTMLSummaryElement):

  • html/HTMLTextFormControlElement.cpp:
  • html/HTMLTextFormControlElement.h:

(HTMLTextFormControlElement):

  • rendering/RenderButton.cpp:
  • rendering/RenderButton.h:

(RenderButton):

  • rendering/RenderListBox.h:

(RenderListBox):

  • rendering/RenderMedia.h:

(WebCore::RenderMedia::canHaveChildren):

  • rendering/RenderMenuList.h:
  • rendering/RenderMeter.h:
  • rendering/RenderProgress.h:
  • rendering/RenderTextControl.h:
  • rendering/svg/RenderSVGRoot.h:
  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::childShouldCreateRenderer):

  • svg/SVGAElement.h:

(SVGAElement):

  • svg/SVGAltGlyphElement.cpp:

(WebCore::SVGAltGlyphElement::childShouldCreateRenderer):

  • svg/SVGAltGlyphElement.h:

(SVGAltGlyphElement):

  • svg/SVGDocument.cpp:

(WebCore::SVGDocument::childShouldCreateRenderer):

  • svg/SVGDocument.h:

(SVGDocument):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::childShouldCreateRenderer):

  • svg/SVGElement.h:

(SVGElement):

  • svg/SVGForeignObjectElement.cpp:

(WebCore::SVGForeignObjectElement::childShouldCreateRenderer):

  • svg/SVGForeignObjectElement.h:

(SVGForeignObjectElement):

  • svg/SVGSwitchElement.cpp:

(WebCore::SVGSwitchElement::childShouldCreateRenderer):

  • svg/SVGSwitchElement.h:

(SVGSwitchElement):

  • svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::childShouldCreateRenderer):

  • svg/SVGTRefElement.h:

(SVGTRefElement):

  • svg/SVGTSpanElement.cpp:

(WebCore::SVGTSpanElement::childShouldCreateRenderer):

  • svg/SVGTSpanElement.h:

(SVGTSpanElement):

  • svg/SVGTextElement.cpp:

(WebCore::SVGTextElement::childShouldCreateRenderer):

  • svg/SVGTextElement.h:

(SVGTextElement):

  • svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::childShouldCreateRenderer):

  • svg/SVGTextPathElement.h:

LayoutTests:

  • fast/dom/shadow/shadow-on-image-expected.html: Added.
  • fast/dom/shadow/shadow-on-image.html: Added.
19:57 Changeset [108601] by commit-queue@webkit.org

[BlackBerry] NetworkJob can access deleted objects.
https://bugs.webkit.org/show_bug.cgi?id=79246

Patch by Yong Li <yoli@rim.com> on 2012-02-22
Reviewed by Antonio Gomes.

When a NetworkJob is created by unload handler, we still need
to send the request to the server, but we shouldn't save and
keep using the Frame pointer because the frame is being detached.
The NetworkJob will be cancelled by PingLoader as soon as it gets
first response from host.
Also see https://bugs.webkit.org/show_bug.cgi?id=30457.

No new tests because existing test case is good enough like
LayoutTests/http/tests/navigation/image-load-in-unload-handler.html.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::NetworkJob):
(WebCore::NetworkJob::initialize):

19:44 Changeset [108600] by bashi@chromium.org

[WebSocket] Remove zlib.h from WebSocketDeflater.h
https://bugs.webkit.org/show_bug.cgi?id=79298

Use forward declaration and OwnPtr for z_stream to move zlib.h from
.h file to .cpp file.

Reviewed by Kent Tamura.

No new tests. No behavior change.

  • websockets/WebSocketDeflater.cpp:

(WebCore::WebSocketDeflater::WebSocketDeflater):
(WebCore::WebSocketDeflater::initialize):
(WebCore::WebSocketDeflater::~WebSocketDeflater):
(WebCore::setStreamParameter):
(WebCore::WebSocketDeflater::addBytes):
(WebCore::WebSocketDeflater::finish):
(WebCore::WebSocketDeflater::reset):
(WebCore::WebSocketInflater::WebSocketInflater):
(WebCore::WebSocketInflater::initialize):
(WebCore::WebSocketInflater::~WebSocketInflater):
(WebCore::WebSocketInflater::addBytes):
(WebCore::WebSocketInflater::finish):

  • websockets/WebSocketDeflater.h:

(WebSocketDeflater): Use OwnPtr for m_stream.
(WebSocketInflater): Ditto.

19:37 Changeset [108599] by yutak@chromium.org

[Chromium] Unreviewed gardening. Two inspector tests are timing out on Mac Debug.

  • platform/chromium/test_expectations.txt:
19:37 Changeset [108598] by commit-queue@webkit.org

[chromium] Add unit test for surface occlusion
https://bugs.webkit.org/show_bug.cgi?id=79302

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-22
Reviewed by James Robinson.

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore::TEST):
(WebCore):

19:07 Changeset [108597] by jamesr@google.com

Remove GraphicsContext3D::paintsIntoCanvasBuffer and unify WebGL and canvas 2d logic
https://bugs.webkit.org/show_bug.cgi?id=79317

Reviewed by Kenneth Russell.

Source/WebCore:

HTMLCanvasElement::paint needs to know whether to attempt to paint the canvas buffer for its context. In the
case of an accelerated canvas or WebGL context, unless we are printing it is typically the composited layer's
responsibility to present the contents and the element itself is only responsible for backgrounds, borders and
the like. This removes a rather indirect path that WebGL content used to take to accomplish this and unifies
the logic with CanvasRenderingContext2D's, which has the exact same needs.

Covered by existing canvas layout tests.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::paintsIntoCanvasBuffer):
(WebCore):
(WebCore::HTMLCanvasElement::paint):

  • html/HTMLCanvasElement.h:

(HTMLCanvasElement):

  • html/canvas/CanvasRenderingContext.h:
  • html/canvas/CanvasRenderingContext2D.cpp:
  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):

  • html/canvas/WebGLRenderingContext.h:
  • platform/graphics/GraphicsContext3D.h:

Source/WebKit/chromium:

Remove paintsIntoCanvasBuffer() implementations.

  • src/GraphicsContext3DChromium.cpp:

(WebCore):

  • src/GraphicsContext3DPrivate.h:
19:05 Changeset [108596] by commit-queue@webkit.org

PopStateEvent.state should use the same object as history.state
https://bugs.webkit.org/show_bug.cgi?id=77493

Patch by Pablo Flouret <pablof@motorola.com> on 2012-02-22
Reviewed by Kentaro Hara.

Source/WebCore:

Tests: fast/loader/stateobjects/state-attribute-history-getter.html

fast/loader/stateobjects/state-attribute-popstate-event.html

  • bindings/js/JSPopStateEventCustom.cpp:

(WebCore):
(WebCore::cacheState):
(WebCore::JSPopStateEvent::state):

  • bindings/v8/V8HiddenPropertyName.h:

(WebCore):

  • bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::stateAccessorGetter):
(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):

  • bindings/v8/custom/V8PopStateEventCustom.cpp:

(WebCore):
(WebCore::cacheState):
(WebCore::V8PopStateEvent::stateAccessorGetter):

  • dom/Document.cpp:

(WebCore::Document::enqueuePopstateEvent):

  • dom/PopStateEvent.cpp:

(WebCore::PopStateEvent::PopStateEvent):
(WebCore::PopStateEvent::create):

  • dom/PopStateEvent.h:

(WebCore):
(PopStateEvent):
(WebCore::PopStateEvent::history):

  • dom/PopStateEvent.idl:
  • page/History.cpp:

(WebCore::History::stateChanged):
(WebCore):
(WebCore::History::isSameAsCurrentState):

  • page/History.h:

(History):

LayoutTests:

  • fast/loader/stateobjects/state-attribute-history-getter-expected.txt: Added.
  • fast/loader/stateobjects/state-attribute-history-getter.html: Added.
  • fast/loader/stateobjects/state-attribute-only-one-deserialization-expected.txt:
  • fast/loader/stateobjects/state-attribute-only-one-deserialization.html:
  • fast/loader/stateobjects/state-attribute-popstate-event-expected.txt: Added.
  • fast/loader/stateobjects/state-attribute-popstate-event.html: Added.
19:01 Changeset [108595] by adamk@chromium.org

Remove obsolete FIXMEs from ContainerNode
https://bugs.webkit.org/show_bug.cgi?id=79295

Reviewed by Ryosuke Niwa.

Each of these three identical FIXMEs has since been fixed by adding
"RefPtr<Node> protect(this)" at the top of each method.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::removeChild):

18:51 Changeset [108594] by dslomov@google.com

[JSC] Implement ArrayBuffer and typed array cloning in JSC
https://bugs.webkit.org/show_bug.cgi?id=79294

Reviewed by Oliver Hunt.

Source/WebCore:

Covered by existing tests.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::typedArrayElementSize):
(WebCore):
(WebCore::CloneSerializer::dumpArrayBufferView):
(CloneSerializer):
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneSerializer::write):
(WebCore::CloneDeserializer::readArrayBufferViewSubtag):
(CloneDeserializer):
(WebCore::CloneDeserializer::readArrayBuffer):
(WebCore::CloneDeserializer::readArrayBufferView):
(WebCore::CloneDeserializer::getJSValue):
(WebCore::CloneDeserializer::readTerminal):

LayoutTests:

  • fast/canvas/webgl/array-message-passing-expected.txt: Updated expectation after cloning implemented.
  • fast/canvas/webgl/script-tests/array-message-passing.js: Added Uint8ClampedArray
  • platform/chromium/fast/canvas/webgl/array-message-passing-expected.txt: Updated expectations. Fixing covered by https://bugs.webkit.org/show_bug.cgi?id=79291
18:24 Changeset [108593] by enne@google.com

[chromium] Unreviewed speculative chromium-mac build fix.
https://bugs.webkit.org/show_bug.cgi?id=75874

This broke in r108581.

  • platform/graphics/chromium/cc/CCLayerAnimationController.h:

(WebCore):

18:19 Changeset [108592] by commit-queue@webkit.org

exponentialRampToValue doesn't use starting value
https://bugs.webkit.org/show_bug.cgi?id=78035

Patch by Raymond Toy <rtoy@google.com> on 2012-02-22
Reviewed by Chris Rogers.

Source/WebCore:

Test: webaudio/audioparam-exponentialRampToValueAtTime.html

  • webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::valuesForTimeRangeImpl): Set
starting value for exponential ramp.

LayoutTests:

  • webaudio/audioparam-exponentialRampToValueAtTime-expected.txt: Added.
  • webaudio/audioparam-exponentialRampToValueAtTime.html: Added.
  • webaudio/resources/audioparam-testing.js: Added.

(createConstantBuffer):
(createExponentialRampArray):
(comparePartialSignals):
(verifyDiscontinuities):
(compareSignals):
(doAutomation):

18:16 Changeset [108591] by yutak@chromium.org

Unreviewed, rolling out r108590.
http://trac.webkit.org/changeset/108590

I mistakenly disabled tests even though the fix was already
in.

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore::TEST):

18:09 Changeset [108590] by yutak@chromium.org

[Chromium] Unreviewed. Disable two tests from CCOcclusionTrackerTest
which cause assertion failures.

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore):
(WebCore::TEST):

18:08 Changeset [108589] by eae@chromium.org

Removed unused methods from branch.

17:51 Changeset [108588] by enne@google.com

[chromium] Unreviewed gardening. Rebaseline more svg tests.

This test was also broken after r108559. It times out on all platforms
but windows, so only rebaselining windows.

  • platform/chromium-win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png:
  • platform/chromium-win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
17:43 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
17:42 Changeset [108587] by commit-queue@webkit.org

[chromium] Fix CCOcclusionTracker unit test assertion
https://bugs.webkit.org/show_bug.cgi?id=79275

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-22
Reviewed by James Robinson.

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore::TEST):

17:40 Changeset [108586] by kling@webkit.org

Make parsing color presentation attributes do less pointless work.
<http://webkit.org/b/79304>

Reviewed by Antti Koivisto.

Let HTMLElement::addHTMLColorToStyle() construct the color CSSValue directly
rather than passing a string that has to go through CSSParser.

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::setProperty):

  • css/StylePropertySet.h:

Added a setProperty(propertyID, CSSValue) overload that expands shorthand
properties if necessary. Also added a little comment about the behavior
differences between setProperty() overloads.

  • html/HTMLElement.cpp:

(WebCore::parseColorStringWithCrazyLegacyRules):

Changed this to return an RGBA32.

(WebCore::HTMLElement::addHTMLColorToStyle):

Figure out the RGB value and construct a (pooled) CSSValue directly.

17:35 Changeset [108585] by enne@google.com

[chromium] Unreviewed gardening. Rebaseline zoom-replaced-intrinsic-ratio

This was broken after r108559 and the result looks reasonable given
the description of the change, so rebaselining.

  • platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt.
  • platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
17:34 Changeset [108584] by dpranke@chromium.org

fast/files/create-blob-url-crash.html is no longer flaky.
https://bugs.webkit.org/show_bug.cgi?id=60125

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
17:32 Changeset [108583] by commit-queue@webkit.org

[EFL] Fix to launch the EWebLauncher using the script, run-launcher.
https://bugs.webkit.org/show_bug.cgi?id=79076

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-02-22
Reviewed by Andreas Kling.

  • Scripts/webkitdirs.pm: Fix the path of libewebkit.so.

(builtDylibPathForName):

17:25 Changeset [108582] by barraclough@apple.com

Implement DefineOwnProperty? for the arguments object
https://bugs.webkit.org/show_bug.cgi?id=79309

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • runtime/Arguments.cpp:

(JSC::Arguments::deletePropertyByIndex):
(JSC::Arguments::deleteProperty):

  • Deleting an argument should also delete the copy on the object, if any.

(JSC::Arguments::defineOwnProperty):

  • Defining a property may override the live mapping.
  • runtime/Arguments.h:

(Arguments):

LayoutTests:

  • fast/js/arguments-expected.txt:
  • fast/js/script-tests/arguments.js:
    • Added test cases
17:22 Changeset [108581] by commit-queue@webkit.org

[chromium] Plumb from GraphicsLayer to the cc thread animation code
https://bugs.webkit.org/show_bug.cgi?id=75874

Patch by Ian Vollick <vollick@chromium.org> on 2012-02-22
Reviewed by James Robinson.

Source/WebCore:

  • WebCore.gypi:
  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setThreadedAnimationEnabled):
(WebCore::Settings::threadedAnimationEnabled):
(Settings):

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(std):
(WebCore::GraphicsLayerChromium::addChild):
(WebCore::GraphicsLayerChromium::addAnimation):
(WebCore):
(WebCore::GraphicsLayerChromium::pauseAnimation):
(WebCore::GraphicsLayerChromium::removeAnimation):
(WebCore::GraphicsLayerChromium::suspendAnimations):
(WebCore::GraphicsLayerChromium::resumeAnimations):
(WebCore::GraphicsLayerChromium::setContentsToMedia):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore::GraphicsLayerChromium::mapAnimationNameToId):

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(GraphicsLayerChromium):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::addAnimation):
(WebCore):
(WebCore::LayerChromium::pauseAnimation):
(WebCore::LayerChromium::removeAnimation):
(WebCore::LayerChromium::suspendAnimations):
(WebCore::LayerChromium::resumeAnimations):
(WebCore::LayerChromium::setLayerAnimationController):
(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore):
(LayerChromium):
(WebCore::LayerChromium::layerAnimationController):
(WebCore::LayerChromium::numChildren):

  • platform/graphics/chromium/cc/CCActiveAnimation.cpp:

(WebCore::CCActiveAnimation::create):
(WebCore):
(WebCore::CCActiveAnimation::CCActiveAnimation):
(WebCore::CCActiveAnimation::~CCActiveAnimation):
(WebCore::CCActiveAnimation::isWaiting):
(WebCore::CCActiveAnimation::isRunningOrHasRun):
(WebCore::CCActiveAnimation::cloneForImplThread):
(WebCore::CCActiveAnimation::synchronizeProperties):

  • platform/graphics/chromium/cc/CCActiveAnimation.h:

(CCActiveAnimation):
(WebCore::CCActiveAnimation::AnimationSignature::AnimationSignature):
(AnimationSignature):
(WebCore::CCActiveAnimation::id):
(WebCore::CCActiveAnimation::group):
(WebCore::CCActiveAnimation::signature):

  • platform/graphics/chromium/cc/CCAnimationCurve.h:

(CCAnimationCurve):
(CCTransformAnimationCurve):

  • platform/graphics/chromium/cc/CCAnimationEvents.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCAnimationCurve.h.

(WebCore):
(WebCore::CCAnimationStartedEvent::CCAnimationStartedEvent):
(CCAnimationStartedEvent):

  • platform/graphics/chromium/cc/CCLayerAnimationController.cpp: Added.

(WebCore):
(WebCore::CCLayerAnimationController::CCLayerAnimationController):
(WebCore::CCLayerAnimationController::~CCLayerAnimationController):
(WebCore::CCLayerAnimationController::create):
(WebCore::CCLayerAnimationController::addAnimation):
(WebCore::CCLayerAnimationController::pauseAnimation):
(WebCore::CCLayerAnimationController::removeAnimation):
(WebCore::CCLayerAnimationController::suspendAnimations):
(WebCore::CCLayerAnimationController::resumeAnimations):
(WebCore::CCLayerAnimationController::synchronizeAnimations):
(WebCore::CCLayerAnimationController::removeCompletedAnimations):
(WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):
(WebCore::CCLayerAnimationController::removeAnimationsCompletedOnMainThread):
(WebCore::CCLayerAnimationController::pushAnimationProperties):
(WebCore::CCLayerAnimationController::getActiveAnimation):
(WebCore::CCLayerAnimationController::remove):

  • platform/graphics/chromium/cc/CCLayerAnimationController.h: Added.

(WebCore):
(CCLayerAnimationController):
(WebCore::CCLayerAnimationController::activeAnimations):

  • platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.cpp:

(WebCore::CCLayerAnimationControllerImpl::~CCLayerAnimationControllerImpl):
(WebCore):
(WebCore::CCLayerAnimationControllerImpl::animate):
(WebCore::CCLayerAnimationControllerImpl::add):
(WebCore::CCLayerAnimationControllerImpl::getActiveAnimation):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForNextTick):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForStartTime):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForTargetAvailability):
(WebCore::CCLayerAnimationControllerImpl::purgeFinishedAnimations):
(WebCore::CCLayerAnimationControllerImpl::tickAnimations):

  • platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.h:

(CCLayerAnimationControllerImplClient):
(CCLayerAnimationControllerImpl):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):
(WebCore::CCLayerImpl::id):
(WebCore::CCLayerImpl::opacity):
(WebCore::CCLayerImpl::transform):
(WebCore::CCLayerImpl::bounds):
(WebCore::CCLayerImpl::layerAnimationController):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::setAnimationEvents):
(WebCore):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):
(CCSettings):
(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::animate):
(WebCore::CCLayerTreeHostImpl::animateLayersRecursive):
(WebCore):
(WebCore::CCLayerTreeHostImpl::animatePageScale):
(WebCore::CCLayerTreeHostImpl::animateLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImplClient):
(CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::needsAnimateLayers):
(WebCore::CCLayerTreeHostImpl::setNeedsAnimateLayers):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::postAnimationEventsToMainThreadOnImplThread):
(WebCore):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(CCSingleThreadProxy):
(WebCore):
(DebugScopedSetMainThread):
(WebCore::DebugScopedSetMainThread::DebugScopedSetMainThread):
(WebCore::DebugScopedSetMainThread::~DebugScopedSetMainThread):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::postAnimationEventsToMainThreadOnImplThread):
(WebCore):
(WebCore::CCThreadProxy::setAnimationEvents):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

  • WebKit.gypi:
  • public/WebSettings.h:
  • public/platform/WebLayerTreeView.h:

(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):

  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCSettings):

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setThreadedAnimationEnabled):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • tests/CCActiveAnimationTest.cpp:

(WebCore::createActiveAnimation):

  • tests/CCAnimationTestCommon.cpp: Added.

(WebKitTests):
(WebKitTests::FakeFloatAnimationCurve::FakeFloatAnimationCurve):
(WebKitTests::FakeFloatAnimationCurve::~FakeFloatAnimationCurve):
(WebKitTests::FakeFloatAnimationCurve::clone):
(WebKitTests::FakeTransformTransition::FakeTransformTransition):
(WebKitTests::FakeTransformTransition::~FakeTransformTransition):
(WebKitTests::FakeTransformTransition::getValue):
(WebKitTests::FakeTransformTransition::clone):
(WebKitTests::FakeFloatTransition::FakeFloatTransition):
(WebKitTests::FakeFloatTransition::~FakeFloatTransition):
(WebKitTests::FakeFloatTransition::getValue):
(WebKitTests::FakeLayerAnimationControllerImplClient::FakeLayerAnimationControllerImplClient):
(WebKitTests::FakeLayerAnimationControllerImplClient::~FakeLayerAnimationControllerImplClient):
(WebKitTests::FakeFloatTransition::clone):
(WebKitTests::addOpacityTransition):

  • tests/CCAnimationTestCommon.h: Added.

(WebCore):
(WebKitTests):
(FakeFloatAnimationCurve):
(WebKitTests::FakeFloatAnimationCurve::duration):
(WebKitTests::FakeFloatAnimationCurve::getValue):
(FakeTransformTransition):
(WebKitTests::FakeTransformTransition::duration):
(FakeFloatTransition):
(WebKitTests::FakeFloatTransition::duration):
(FakeLayerAnimationControllerImplClient):
(WebKitTests::FakeLayerAnimationControllerImplClient::id):
(WebKitTests::FakeLayerAnimationControllerImplClient::opacity):
(WebKitTests::FakeLayerAnimationControllerImplClient::setOpacity):
(WebKitTests::FakeLayerAnimationControllerImplClient::transform):
(WebKitTests::FakeLayerAnimationControllerImplClient::setTransform):
(WebKitTests::FakeLayerAnimationControllerImplClient::bounds):

  • tests/CCLayerAnimationControllerImplTest.cpp:

(WebKitTests::createActiveAnimation):
(WebKitTests::TEST):

  • tests/CCLayerAnimationControllerTest.cpp: Added.

(WebKitTests):
(WebKitTests::createActiveAnimation):
(WebKitTests::TEST):

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::CCLayerTreeHostImplTest::postAnimationEventsToMainThreadOnImplThread):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::TestHooks::animateLayers):
(MockLayerTreeHostImpl):
(WTF::MockLayerTreeHostImpl::animateLayers):
(WTF::MockLayerTreeHost::create):
(WTF::MockLayerTreeHost::createLayerTreeHostImpl):
(WTF):
(MockLayerAnimationController):
(WTF::MockLayerAnimationController::create):
(WTF::MockLayerAnimationController::addAnimation):
(WTF::MockLayerTreeHostClient::scheduleComposite):
(WTF::CCLayerTreeHostTest::postAddAnimationToMainThread):
(CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::dispatchAddAnimation):
(WTF::CCLayerTreeHostTest::doBeginTest):
(CCLayerTreeHostTestAddAnimation):
(WTF::CCLayerTreeHostTestAddAnimation::CCLayerTreeHostTestAddAnimation):
(WTF::CCLayerTreeHostTestAddAnimation::beginTest):
(WTF::CCLayerTreeHostTestAddAnimation::animateLayers):
(WTF::CCLayerTreeHostTestAddAnimation::afterTest):
(WTF::TEST_F):

  • tests/TreeSynchronizerTest.cpp:

(FakeLayerAnimationController):
(WebKitTests::FakeLayerAnimationController::create):
(WebKitTests::FakeLayerAnimationController::synchronizedAnimations):
(WebKitTests::FakeLayerAnimationController::FakeLayerAnimationController):
(WebKitTests::FakeLayerAnimationController::synchronizeAnimations):
(WebKitTests):
(WebKitTests::TEST):

17:20 Changeset [108580] by eae@chromium.org

Merge trunk changes up until 108547 into subpixel branch.

17:13 Changeset [108579] by andersca@apple.com

Subframes with scrollable areas must be added to the non-fast scrollable region
https://bugs.webkit.org/show_bug.cgi?id=79306
<rdar://problem/10915564>

Reviewed by Andreas Kling.

When computing the non-fast scrollable region, add subframes with scrollable regions to the region.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::computeNonFastScrollableRegion):

17:04 Changeset [108578] by enne@google.com

[chromium] Unreviewed gardening. Update expectations after skia roll.

It is most likely that the Skia roll from 3216 to 3226 slightly
changed image expectations for the following tests. None of these are
perceptually any different, so just rebaselining.

  • platform/chromium-linux/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/chromium-linux/fast/borders/border-image-rotate-transform-expected.png:
  • platform/chromium-linux/svg/custom/focus-ring-expected.png:
  • platform/chromium-linux/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/chromium-mac-leopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/chromium-mac-leopard/svg/custom/focus-ring-expected.png:
  • platform/chromium-mac-leopard/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-image-rotate-transform-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/focus-ring-expected.png:
  • platform/chromium-mac-snowleopard/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/chromium-win/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/chromium-win/fast/borders/border-image-rotate-transform-expected.png:
  • platform/chromium-win/svg/custom/focus-ring-expected.png:
  • platform/chromium-win/svg/transforms/animated-path-inside-transformed-html-expected.png:
16:56 Changeset [108577] by commit-queue@webkit.org

[Qt] Add eventSender.gestureTap
https://bugs.webkit.org/show_bug.cgi?id=66173

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-22
Reviewed by Kenneth Rohde Christiansen.

Tools:

  • DumpRenderTree/qt/EventSenderQt.cpp:

(EventSender::gestureTap):

  • DumpRenderTree/qt/EventSenderQt.h:

LayoutTests:

Unskip gestureTap test.

  • platform/qt/Skipped:
16:49 WebKitIDL edited by ericu@chromium.org
Copied info from http://trac.webkit.org/wiki/IdlAttributes (diff)
16:47 Changeset [108576] by japhet@chromium.org

Source/WebCore: CachedResourceLoader ignores the Range header
in determineRavlidationPolicy(), resulting in incorrect
cache hits.

Reviewed by Adam Barth.

Test: http/tests/xmlhttprequest/range-test.html
Test written by Aaron Colwell (acolwell@chromium.org).

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::determineRevalidationPolicy):

LayoutTests: Test Range header compliance for CachedResources.
https://bugs.webkit.org/show_bug.cgi?id=76564

Reviewed by Adam Barth.

  • http/tests/xmlhttprequest/range-test-expected.txt: Added.
  • http/tests/xmlhttprequest/range-test.html: Added.
16:44 Changeset [108575] by enne@google.com

[chromium] Unreviewed gardening. Generalize svg failures from r108494.

  • platform/chromium/test_expectations.txt:
16:42 Changeset [108574] by antti@apple.com

REGRESSION (r104060): Web font is not loaded if specified by link element dynamically inserted
https://bugs.webkit.org/show_bug.cgi?id=79186

Reviewed by Andreas Kling.

Source/WebCore:

Test: fast/css/font-face-insert-link.html

If a dynamically inserted stylesheet contains @font-face rules, we may fail to update the rendering.

Before r104060 the style selector was destroyed on every style change, and the font selector along with it.
This is no longer the case and we can't rely on comparing font selector pointers when comparing Fonts
for equality. This patch adds version number to the font selector and checks it in Font::operator==.
The version number is incremented when new font-face rules are added to the font selector.

FontFallbackList is an object shared between Fonts so the extra field shouldn't matter much in terms
of memory.

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::CSSFontSelector):
(WebCore::CSSFontSelector::addFontFaceRule):

  • css/CSSFontSelector.h:

(CSSFontSelector):

  • platform/graphics/Font.cpp:

(WebCore::Font::operator==):

  • platform/graphics/FontFallbackList.cpp:

(WebCore::FontFallbackList::FontFallbackList):
(WebCore::FontFallbackList::invalidate):

  • platform/graphics/FontFallbackList.h:

(FontFallbackList):
(WebCore::FontFallbackList::fontSelectorVersion):

  • platform/graphics/FontSelector.h:

(FontSelector):

LayoutTests:

  • fast/css/font-face-insert-link-expected.txt: Added.
  • fast/css/font-face-insert-link.html: Added.
  • fast/css/resources/ahem.css: Added.

(@font-face):

16:38 Changeset [108573] by japhet@chromium.org

Source/WebCore: Prevent CachedRawResource from sending the same data
chunk multiple times.
https://bugs.webkit.org/show_bug.cgi?id=78810

Reviewed by Adam Barth.

If a CachedRawResource receives data while a CachedRawResourceCallback
timer is active, the incremental data will be sent to the client, followed
but all data received so far, resulting in invalid data. Resolving this adds
complexity to CachedRawResource and requires making a few more CachedResource
functions virtual, so push the callback logic into CachedResource where it can
be implemented more cleanly.

Test: inspector/debugger/script-formatter-console.html

should no longer be flaky.

  • loader/cache/CachedRawResource.cpp: CachedRawResourceCallback renamed and moved to CachedResource.

(WebCore::CachedRawResource::didAddClient): More or less the same as sendCallbacks() was.

  • loader/cache/CachedRawResource.h:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::addClient): Check the return value of addClientToSet() to determine whether

or not to call didAddClient.

(WebCore::CachedResource::didAddClient): May be called during addClient(), or may be called on a timer.

If called on a timer, move the client between sets.

(WebCore::CachedResource::addClientToSet): Determine whether didAddClient() can be called synchronously and

return true if it can.

(WebCore::CachedResource::removeClient): Ensure we cancel pending callbacks if necessary.
(WebCore::CachedResource::CachedResourceCallback::CachedResourceCallback): Renamed and moved from CachedRawResource.

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::hasClients): Check m_clientsAwaitingCallback as well as m_clients.
(WebCore::CachedResource::CachedResourceCallback::schedule):
(WebCore::CachedResource::hasClient): Helper for calling contains() on both m_clientsAwaitingCallback and m_clients.

LayoutTests: inspector/debugger/script-formatter-console.html should
no longer be flaky.
https://bugs.webkit.org/show_bug.cgi?id=78810

Reviewed by Adam Barth.

  • platform/chromium/test_expectations.txt:
16:26 Changeset [108572] by kubo@profusion.mobi

[CMake] Remove FindGDK.cmake and FindGDK-PixBuf.cmake
https://bugs.webkit.org/show_bug.cgi?id=79292

Reviewed by Daniel Bates.

These files were committed when the EFL port's buildsystem code
was upstreamed, but are currently not being used anywhere, as the EFL
port has not depended on GDK for a long time.

  • Source/cmake/FindGDK-PixBuf.cmake: Removed.
  • Source/cmake/FindGDK.cmake: Removed.
16:24 Changeset [108571] by andersca@apple.com

Implement TiledCoreAnimationDrawingAreaProxy::deviceScaleFactorDidChange
https://bugs.webkit.org/show_bug.cgi?id=79297
<rdar://problem/10748510>

Reviewed by Beth Dakin.

  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::deviceScaleFactorDidChange):
Send a message to the web process.

  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::setDeviceScaleFactor):
Add empty stub.

  • WebProcess/WebPage/DrawingArea.messages.in:

Add SetDeviceScaleFactor message.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::setDeviceScaleFactor):
Call WebPage::setDeviceScaleFactor.

16:16 Changeset [108570] by beidson@apple.com

<rdar://problem/10406044> and https://bugs.webkit.org/show_bug.cgi?id=79279
Synchronous ShouldGoToBackForwardListItem causes lots of WebProcess hangs

Reviewed by NOBODY (OOPS!).

Source/WebKit2:

Anytime the WebProcess sends a sync message up to the UI Process a hang can ensue.

In the case of shouldGoToBackForwardListItem it seems many clients want a back/forward
notification but don't actually want to make a policy decision.

Making it an asynchronous notification instead of a synchronous policy call will remove the
possibility of a hang here.

If clients later decide it is important to have a policy here we should implement a form of
shouldGoToBackForwardListItem in the bundle loader client.

Add a notification "willGoToBackForwardListItem" to the WKPageLoaderClient:

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeLoaderClient): Tell the WebProcess whether it should be

sending the shouldGoToBackForwardListItem or willGoToBackForwardListItem form of this message.

(WebKit::WebPageProxy::shouldGoToBackForwardListItem):
(WebKit::WebPageProxy::willGoToBackForwardListItem):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in: Add an asynchronous WillGoToBackForwardListItem message

Store a flag in the WebProcess - Sent from the UIProcess - to tell the FrameLoaderClient which form
of the callback should be used:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::willGoToBackForwardItemCallbackEnabled):
(WebKit::WebPage::setWillGoToBackForwardItemCallbackEnabled):

  • WebProcess/WebPage/WebPage.messages.in:
  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::shouldGoToBackForwardListItem): Only consider calling this for

version 0 clients.

(WebKit::WebLoaderClient::willGoToBackForwardListItem): Later clients get this callback.

  • UIProcess/WebLoaderClient.h:

(WebLoaderClient):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::shouldGoToHistoryItem): Send either the synchronous "should" message

or the asynchronous "will" message depending on which the WebProcess was last told that the
UIProcess expects. There is an edge case where the wrong one might be sent because the WebProcess
hasn't received the message about a change in the WKPageLoaderClient yet but that's probably okay;
It seems unlikely that a UIProcess client would ever rapidly change between v0 and other versions
of the loader client and the UIProcess of WebKit2 is equipped to handle that case if it comes up.

Tools:

Update our tools to the new form of the PageLoadClient.

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

15:47 Changeset [108569] by mrobinson@webkit.org

Tagging the WebKitGTK+ 1.6.2 release

15:46 Changeset [108568] by barraclough@apple.com

Fix Object.freeze for non-final objects.
https://bugs.webkit.org/show_bug.cgi?id=79286

Reviewed by Oliver Hunt.

For vanilla objects we implement this with a single transition, for objects
with special properties we should just follow the spec defined algorithm.

Source/JavaScriptCore:

  • runtime/JSArray.cpp:

(JSC::SparseArrayValueMap::put):

  • this does need to handle inextensible objects.
  • runtime/ObjectConstructor.cpp:

(JSC::objectConstructorSeal):
(JSC::objectConstructorFreeze):

  • Implement spec defined algorithm for non-final objects.
  • runtime/Structure.cpp:

(JSC::Structure::Structure):
(JSC::Structure::freezeTransition):

  • freeze should set m_hasReadOnlyOrGetterSetterPropertiesExcludingProto.
  • runtime/Structure.h:

(JSC::Structure::hasReadOnlyOrGetterSetterPropertiesExcludingProto):
(JSC::Structure::setHasGetterSetterProperties):
(JSC::Structure::setContainsReadOnlyProperties):
(Structure):

  • renamed m_hasReadOnlyOrGetterSetterPropertiesExcludingProto.

LayoutTests:

  • fast/js/preventExtensions-expected.txt:
  • fast/js/script-tests/preventExtensions.js:
    • added new tests.
15:46 Changeset [108567] by dbates@webkit.org

Update change log entry for r108561 to reflect removal of "if (m_dispatchSoonList.isEmpty())".
https://bugs.webkit.org/show_bug.cgi?id=78840

Mention removal of unnecessary check for empty list m_dispatchSoonList in EventSender::cancelEvent().

Also, fix the date in the change log entry for changeset r108562 since it landed today (02/22/2012).

15:45 Changeset [108566] by jonlee@apple.com

[WK2] Clearing notifications does not clean up internal state
https://bugs.webkit.org/show_bug.cgi?id=78861
<rdar://problem/10881167>

Reviewed by Anders Carlsson.

  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::clearNotifications): This function was missing removing the notification
entries from the other maps.
(WebKit::WebNotificationManager::didDestroyNotification): When the notification is destroyed, it should
also be removed from the context map.
(WebKit::WebNotificationManager::didCloseNotifications): Refactor to pull out the code that removes
a provided notification from the context map.
(WebKit::WebNotificationManager::removeNotificationFromContextMap): Find the notification in the map, and
remove it. If the map is empty, get rid of the entry.

  • WebProcess/Notifications/WebNotificationManager.h:

(WebNotificationManager):

15:44 Changeset [108565] by mrobinson@webkit.org

Tagging the WebKitGTK+ 1.6.3 release

15:43 Changeset [108564] by mrobinson@webkit.org

Tagging the WebKitGTK+ 1.7.90 release

15:43 Changeset [108563] by jonlee@apple.com

Code cleanup in WebNotificationManager (79285)
https://bugs.webkit.org/show_bug.cgi?id=79285
<rdar://problem/10914522>

Reviewed by Anders Carlsson.

  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::show): Simplify adding a blank vector to the map using .add(),
similar to what is found in WebNotificationClient.mm in WebKit 1.

15:40 Changeset [108562] by rniwa@webkit.org

Remove the remaining uses of CSSStyleDeclaration in Editor
https://bugs.webkit.org/show_bug.cgi?id=78939

Reviewed by Enrica Casucci.

Source/WebCore:

Changed the argument types of shouldApplyStyle, applyParagraphStyle, applyStyleToSelection,
applyParagraphStyleToSelection, and computeAndSetTypingStyle in Editor from CSSStyleDeclaration
to StylePropertySet.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • editing/Editor.cpp:

(WebCore::Editor::applyStyle):
(WebCore::Editor::shouldApplyStyle):
(WebCore::Editor::applyParagraphStyle):
(WebCore::Editor::applyStyleToSelection):
(WebCore::Editor::applyParagraphStyleToSelection):
(WebCore::Editor::setBaseWritingDirection):
(WebCore::Editor::computeAndSetTypingStyle):

  • editing/Editor.h:

(WebCore):
(Editor):

  • editing/EditorCommand.cpp:

(WebCore::applyCommandToFrame):
(WebCore::executeApplyParagraphStyle):
(WebCore::executeMakeTextWritingDirectionLeftToRight):
(WebCore::executeMakeTextWritingDirectionNatural):
(WebCore::executeMakeTextWritingDirectionRightToLeft):

  • loader/EmptyClients.h:

(WebCore::EmptyEditorClient::shouldApplyStyle):

  • page/DragController.cpp:

(WebCore::DragController::concludeEditDrag):

  • page/EditorClient.h:

(WebCore):
(EditorClient):

Source/WebKit/blackberry:

  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::shouldApplyStyle):

  • WebCoreSupport/EditorClientBlackBerry.h:

(EditorClientBlackBerry):

Source/WebKit/chromium:

  • src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::shouldApplyStyle):

  • src/EditorClientImpl.h:

(EditorClientImpl):

Source/WebKit/efl:

  • WebCoreSupport/EditorClientEfl.cpp:

(WebCore::EditorClientEfl::shouldApplyStyle):

  • WebCoreSupport/EditorClientEfl.h:

(EditorClientEfl):

Source/WebKit/gtk:

  • WebCoreSupport/EditorClientGtk.cpp:

(WebKit::EditorClient::shouldApplyStyle):

  • WebCoreSupport/EditorClientGtk.h:

(EditorClient):

Source/WebKit/mac:

  • WebCoreSupport/WebEditorClient.h:

(WebEditorClient):

  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::shouldApplyStyle):

  • WebView/WebFrame.mm:

(-[WebFrame _setTypingStyle:withUndoAction:]):

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
(-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):

  • WebView/WebView.mm:

(-[WebView applyStyle:]):

Source/WebKit/qt:

  • WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::shouldApplyStyle):

  • WebCoreSupport/EditorClientQt.h:

(EditorClientQt):

Source/WebKit/win:

  • WebCoreSupport/WebEditorClient.cpp:

(WebEditorClient::shouldApplyStyle):

  • WebCoreSupport/WebEditorClient.h:

(WebEditorClient):

Source/WebKit/wince:

  • WebCoreSupport/EditorClientWinCE.cpp:

(WebKit::EditorClientWinCE::shouldApplyStyle):

Source/WebKit/wx:

  • WebKitSupport/EditorClientWx.cpp:

(WebCore::EditorClientWx::shouldApplyStyle):

  • WebKitSupport/EditorClientWx.h:

(EditorClientWx):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::shouldApplyStyle):

  • WebProcess/WebCoreSupport/WebEditorClient.h:

(WebEditorClient):

15:28 Changeset [108561] by dbates@webkit.org

Abstract ImageEventSender into a general purpose EventSender
https://bugs.webkit.org/show_bug.cgi?id=78840

Reviewed by Adam Barth.

Abstract the functionality in ImageEventSender so that it can be used again.
This functionality may be useful in fixing WebKit Bug #38995.

No functionality was changed; no new tests.

  • GNUmakefile.list.am: Added EventSender.h.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/EventSender.h: Added.

(WebCore):
(EventSender):
(WebCore::EventSender::eventType):
(WebCore::EventSender::hasPendingEvents):
(WebCore::EventSender::timerFired):
(WebCore::::EventSender):
(WebCore::::dispatchEventSoon):
(WebCore::::cancelEvent):
(WebCore::::dispatchPendingEvents):

  • loader/ImageLoader.cpp: Modified to use EventSender.

(WebCore):
(WebCore::ImageLoader::dispatchPendingEvent): Added; called by EventSender when the ImageLoader
should dispatch a pending BeforeLoad or Load event.

  • loader/ImageLoader.h:

(WebCore):
(ImageLoader):

15:23 Changeset [108560] by dbates@webkit.org

new-run-webkit-tests shouldn't restore Safari state on Lion when showing results
https://bugs.webkit.org/show_bug.cgi?id=79277

Reviewed by Adam Barth.

Pass command line argument no-saved-state to run-safari to disable Safari
state restoration for the session on OS 10.7.

  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.show_results_html_file):

  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:

(test_show_results_html_file):

15:17 Changeset [108559] by commit-queue@webkit.org

Paddings and borders on root SVG element with viewbox causes child SVG elements to be rendered with the incorrect size
https://bugs.webkit.org/show_bug.cgi?id=78613

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-02-22
Reviewed by Nikolas Zimmermann.

Source/WebCore:

When computing its localToBorderBoxTransform, RenderSVGRoot was using its width and height
as the dimensions of the SVG viewport. However, width and height include CSS borders and
paddings, which are not part of the SVG viewport area. Now, RenderSVGRoot uses its
contentWidth and contentHeight, which correspond to the SVG viewport area.

Tests: svg/custom/svg-root-padding-border-margin-expected.html

svg/custom/svg-root-padding-border-margin.html

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::buildLocalToBorderBoxTransform):

LayoutTests:

  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/custom/circle-move-invalidation-expected.png:
  • platform/mac/svg/custom/circle-move-invalidation-expected.txt:

This test contains a circle drawn inside a root SVG element with a 1px border. This bug
was causing WebKit to render the circle 1px too large, reflected in the expectations.
The expectations have been updated.

  • svg/custom/svg-root-padding-border-margin-expected.html: Added.
  • svg/custom/svg-root-padding-border-margin.html: Added.
15:15 Changeset [108558] by kubo@profusion.mobi

[EFL] Get rid of GeolocationServiceEfl
https://bugs.webkit.org/show_bug.cgi?id=79270

Reviewed by Adam Barth.

These were just a bunch of dummy files with no real functionality, and
removing them helps the preparation of bug 78853, which will make
client-based geolocation the default.

No new tests, this functionality was not used.

  • PlatformEfl.cmake:
  • platform/efl/GeolocationServiceEfl.cpp: Removed.
  • platform/efl/GeolocationServiceEfl.h: Removed.
15:10 Changeset [108557] by jchaffraix@webkit.org

Clean-up RenderTableSection::calcRowLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=77705

Reviewed by Eric Seidel.

Refactoring / simplication of the code.

This change removes some variables that were unneeded and were
hiding what the code was really doing. Also some of the code was
split and moved down to RenderTableCell.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::logicalHeightForRowSizing):

  • rendering/RenderTableCell.h:

(RenderTableCell):
Added the previous helper function to calculate the cell's
adjusted logical height.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):
Removed some variables, simplified the rowspan logic to be clearer
(and added a comment about how we handle rowspans).

15:07 Changeset [108556] by abarth@webkit.org

Move FILE_SYSTEM code out of DOMWindow and into the fileapi folder
https://bugs.webkit.org/show_bug.cgi?id=79259

Reviewed by Eric Seidel.

This patch is part of our ongoing effort to remove ifdefs from code
classes. The FILE_SYSTEM code in DOMWindow doesn't really have any
necessary connection to DOMWindow. DOMWindow is just the context
object that the API hangs off of.

This patch moves the FILE_SYSTEM code into the fileapi folder using
[Supplemental].

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • fileapi/DOMWindowFileSystem.cpp: Added.

(WebCore):
(WebCore::DOMWindowFileSystem::DOMWindowFileSystem):
(WebCore::DOMWindowFileSystem::~DOMWindowFileSystem):
(WebCore::DOMWindowFileSystem::webkitRequestFileSystem):
(WebCore::DOMWindowFileSystem::webkitResolveLocalFileSystemURL):

  • fileapi/DOMWindowFileSystem.h: Added.

(WebCore):
(DOMWindowFileSystem):

  • fileapi/DOMWindowFileSystem.idl: Added.
  • page/DOMWindow.cpp:

(WebCore):

  • page/DOMWindow.h:

(WebCore):
(DOMWindow):

  • page/DOMWindow.idl:
14:54 Changeset [108555] by macpherson@chromium.org

Re-implement many more HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macros in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=79200

Reviewed by Andreas Kling.

No new tests / refactoring only.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • rendering/style/RenderStyle.h:
14:52 Changeset [108554] by dcheng@chromium.org

[chromium] Cleanup unused WebDragData methods after r107846
https://bugs.webkit.org/show_bug.cgi?id=78837

Reviewed by Tony Chang.

The deleted methods have been replaced by items() and setItems().

  • public/platform/WebDragData.h:

(WebDragData):

  • src/WebDragData.cpp:

(WebKit::WebDragData::addItem): Add ensureMutable() call to verify preconditions for

mutating the item store.

14:26 Changeset [108553] by mhahnenberg@apple.com

Allocations from CopiedBlocks should always be 8-byte aligned
https://bugs.webkit.org/show_bug.cgi?id=79271

Reviewed by Geoffrey Garen.

  • heap/CopiedAllocator.h:

(JSC::CopiedAllocator::allocate):

  • heap/CopiedBlock.h: Changed to add padding so that the start of the payload is always

guaranteed to be 8 byte aligned on both 64- and 32-bit platforms.
(CopiedBlock):

  • heap/CopiedSpace.cpp: Changed all assertions of isPointerAligned to is8ByteAligned.

(JSC::CopiedSpace::tryAllocateOversize):
(JSC::CopiedSpace::getFreshBlock):

  • heap/CopiedSpaceInlineMethods.h:

(JSC::CopiedSpace::allocateFromBlock):

  • runtime/JSArray.h:

(ArrayStorage): Added padding for ArrayStorage to make sure that it is always 8 byte
aligned on both 64- and 32-bit platforms.

  • wtf/StdLibExtras.h:

(WTF::is8ByteAligned): Added new utility function that functions similarly to the
way isPointerAligned does, but it just always checks for 8 byte alignment.
(WTF):

14:25 Changeset [108552] by eae@chromium.org

Fix qt build on branch.

14:21 Changeset [108551] by tsepez@chromium.org

XSSAuditor bypass with <svg> tags and html-entities.
https://bugs.webkit.org/show_bug.cgi?id=78836

Reviewed by Adam Barth.

Source/WebCore:

Tests: http/tests/security/xssAuditor/iframe-onload-in-svg-tag.html

http/tests/security/xssAuditor/script-tag-inside-svg-tag.html
http/tests/security/xssAuditor/script-tag-inside-svg-tag2.html
http/tests/security/xssAuditor/script-tag-inside-svg-tag3.html

  • html/parser/XSSAuditor.cpp:

(WebCore::isNonCanonicalCharacter):
(WebCore::isTerminatingCharacter):
(WebCore):
(WebCore::startsHTMLCommentAt):
(WebCore::startsSingleLineCommentAt):
(WebCore::fullyDecodeString):
(WebCore::XSSAuditor::XSSAuditor):
(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::filterToken):
(WebCore::XSSAuditor::filterStartToken):
(WebCore::XSSAuditor::filterEndToken):
(WebCore::XSSAuditor::filterCharacterToken):
(WebCore::XSSAuditor::filterScriptToken):
(WebCore::XSSAuditor::filterObjectToken):
(WebCore::XSSAuditor::filterParamToken):
(WebCore::XSSAuditor::filterEmbedToken):
(WebCore::XSSAuditor::filterAppletToken):
(WebCore::XSSAuditor::filterIframeToken):
(WebCore::XSSAuditor::filterMetaToken):
(WebCore::XSSAuditor::filterBaseToken):
(WebCore::XSSAuditor::filterFormToken):
(WebCore::XSSAuditor::decodedSnippetForAttribute):
(WebCore::XSSAuditor::snippetForJavaScript):

  • html/parser/XSSAuditor.h:

(XSSAuditor):

LayoutTests:

  • http/tests/security/xssAuditor/iframe-onload-in-svg-tag-expected.txt: Added.
  • http/tests/security/xssAuditor/iframe-onload-in-svg-tag.html: Added.
  • http/tests/security/xssAuditor/script-tag-inside-svg-tag-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-inside-svg-tag.html: Added.
  • http/tests/security/xssAuditor/script-tag-inside-svg-tag2-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-inside-svg-tag2.html: Added.
  • http/tests/security/xssAuditor/script-tag-inside-svg-tag3-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-inside-svg-tag3.html: Added.
14:09 Changeset [108550] by andersca@apple.com

Crash when marking cached pages for full style recalc
https://bugs.webkit.org/show_bug.cgi?id=79276
<rdar://problem/10884036>

Reviewed by Beth Dakin.

Guard against a null history item.

  • history/BackForwardController.cpp:

(WebCore::BackForwardController::markPagesForFullStyleRecalc):

14:03 Changeset [108549] by eae@chromium.org

Revert baselinePosition to int on branch.

13:56 Changeset [108548] by commit-queue@webkit.org

Crash from empty anonymous block preceding :before content
https://bugs.webkit.org/show_bug.cgi?id=78250

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-02-22
Reviewed by David Hyatt.

Source/WebCore:

RenderListMarkers getting removed from the tree in updateMarkerLocation()
can leave parent anonymous blocks behind with no children. This was
confusing updateBeforeAfterContent() because it does not expect
an empty block to precede :before content renderers.

Fix is to remove the anonymous block if it will lose all of its children.

  • rendering/RenderListItem.cpp:

(WebCore::RenderListItem::updateMarkerLocation):

LayoutTests:

Test exercises a crashing condition from extra :before content being
created after a RenderListMarker in an anonymous block has been moved.

Also rebasing some tests that had extraneous anonymous blocks in their
render tree dumps.

  • fast/css-generated-content/before-content-with-list-marker-in-anon-block-crash-expected.txt: Added
  • fast/css-generated-content/before-content-with-list-marker-in-anon-block-crash.html: Added
  • platform/chromium-win/editing/execCommand/create-list-with-hr-expected.txt:
  • platform/gtk/editing/execCommand/create-list-with-hr-expected.txt:
  • platform/mac/editing/execCommand/create-list-with-hr-expected.txt:
  • platform/qt/editing/execCommand/create-list-with-hr-expected.txt:
13:33 Changeset [108547] by inferno@chromium.org

Source/WebCore: Crash due to accessing removed parent lineboxes when clearing view selection.
https://bugs.webkit.org/show_bug.cgi?id=79264

Reviewed by Eric Seidel.

When our block needed a full layout, we were deleting our own lineboxes
and letting descendant children (at any level in hierarchy and not just
immediate children) clear their own lineboxes as we keep laying them out.
This was problematic because those descendant children lineboxes were
pointing to removed parent lineboxes in the meantime. An example scenario
where this would go wrong is first-letter object removal, which can cause
clearing view selection, leading to accessing parent lineboxes. The patch
modifies clearing the entire linebox tree upfront. It shouldn't introduce
performance issues since it will eventually happen as we are laying out
those children.

Test: fast/css-generated-content/first-letter-textbox-parent-crash.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):

LayoutTests: Crash due to accessing removed parent lineboxes when clearing view selection.
https://bugs.webkit.org/show_bug.cgi?id=79264

Reviewed by Eric Seidel.

  • fast/css-generated-content/first-letter-textbox-parent-crash-expected.txt: Added.
  • fast/css-generated-content/first-letter-textbox-parent-crash.html: Added.
13:24 Changeset [108546] by leviw@chromium.org

Fixing a merge artifact in RenderMarquee.

13:23 Changeset [108545] by leviw@chromium.org

Adding a floorToInt method for ease in moving to trunk, and flooring the right offset for line layout, as due to column layout, we can't be guaranteed to pixel snap at render time identically to layout time.

13:17 Changeset [108544] by mrobinson@webkit.org

Fix bad merge

13:07 Changeset [108543] by inferno@chromium.org

Cloning and linebox issues in multi-column layout.
https://bugs.webkit.org/show_bug.cgi?id=78273

Reviewed by Eric Seidel.

Source/WebCore:

Tests: fast/multicol/span/clone-flexbox.html

fast/multicol/span/clone-summary.html
fast/multicol/span/textbox-not-removed-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::clone): Fix cloning algorithm to take
care of cloning descendant classes of RenderBlock.
(WebCore::RenderBlock::splitBlocks): When we move our inline children
to cloneBlock, we need to clear our entire line box tree. Any descendant
child in the hierarchy could be a part of our line box tree and will
never get cleared since the child has moved to new parent cloneBlock.

LayoutTests:

  • fast/multicol/span/clone-flexbox-expected.png:
  • fast/multicol/span/clone-flexbox-expected.txt: Added.
  • fast/multicol/span/clone-flexbox.html: Added. Test passes if we

see two RenderFlexibox in the rendertree.

  • fast/multicol/span/clone-summary-expected.png: Added.
  • fast/multicol/span/clone-summary-expected.txt: Added.
  • fast/multicol/span/clone-summary.html: Added. Test passes if we

see two RenderSummary in the rendertree.

  • fast/multicol/span/textbox-not-removed-crash-expected.txt: Added.
  • fast/multicol/span/textbox-not-removed-crash.html: Added. Test

passes it we do not crash on m_hasBadParent assert in InlineBox.

13:00 Changeset [108542] by commit-queue@webkit.org

CCLayerTreeHostImpl calls didDraw more frequently than willDraw
https://bugs.webkit.org/show_bug.cgi?id=79139

Patch by Tim Dresser <tdresser@chromium.org> on 2012-02-22
Reviewed by James Robinson.

Source/WebCore:

Ensure that didDraw is called if and only if willDraw was called previously.

CCLayerTreeHostImplTest.didDrawNotCalledOnHiddenLayer has been added to ensure that
hidden layers, for which willDraw is not called, will also not have didDraw called.

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::drawLayers):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::didDraw):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::DidDrawCheckLayer::willDraw):
(DidDrawCheckLayer):
(WebKit::DidDrawCheckLayer::willDrawCalled):
(WebKit::DidDrawCheckLayer::DidDrawCheckLayer):
(WebKit::TEST_F):
(WebKit):

12:57 Changeset [108541] by leviw@chromium.org

ScrollbarThemeComposite::thumbPosition uses the result of a divide by zero
https://bugs.webkit.org/show_bug.cgi?id=78910

Reviewed by Eric Seidel.

Adding a check to avoid doing a floating point divide by zero and assigning NaN to an integer.
This causes problems with our conversion to subpixel layout, which asserts when we overflow.

  • platform/ScrollbarThemeComposite.cpp:

(WebCore::ScrollbarThemeComposite::thumbPosition):

12:51 Changeset [108540] by commit-queue@webkit.org

Explicitly include unistd.h in TestNetscapePlugIn for GCC 4.7
https://bugs.webkit.org/show_bug.cgi?id=77759

Patch by Kalev Lember <kalevlember@gmail.com> on 2012-02-22
Reviewed by Tony Chang.

Fixes build with gcc 4.7.

r100432 added the include only for ANDROID; this changes the ifdef to
also cover other unix platforms. On Fedora 17 the gcc 4.7 compiler no
longer implicitly includes unistd.h from standard headers and other
unix platforms are likely to get gcc 4.7 as well in the future.

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
12:43 Changeset [108539] by enne@google.com

[chromium] Unreviewed gardening. Rebaseline svg expectations after r108493.

Blindly updating expected to actual on Chromium. They only started
failing after the base expectations were updated and don't have any
perceptual differences.

  • platform/chromium-mac-snowleopard/svg/foreignObject/clip-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/foreignObject/filter-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/foreignObject/mask-expected.png: Added.
  • platform/chromium-win/svg/custom/visited-link-color-expected.png: Added.
  • platform/chromium-win/svg/foreignObject/clip-expected.png: Added.
  • platform/chromium-win/svg/foreignObject/filter-expected.png: Added.
  • platform/chromium-win/svg/foreignObject/mask-expected.png: Added.
  • platform/chromium/test_expectations.txt:
12:41 Changeset [108538] by commit-queue@webkit.org

Have the DynamicsCompressorNode support multi-channel data
https://bugs.webkit.org/show_bug.cgi?id=77856

Patch by Raymond Liu <raymond.liu@intel.com> on 2012-02-22
Reviewed by Chris Rogers.

  • platform/audio/DynamicsCompressor.cpp:

(WebCore::DynamicsCompressor::DynamicsCompressor):
(WebCore::DynamicsCompressor::setEmphasisStageParameters):
(WebCore::DynamicsCompressor::process):
(WebCore::DynamicsCompressor::reset):
(WebCore::DynamicsCompressor::setNumberOfChannels):
(WebCore):

  • platform/audio/DynamicsCompressor.h:

(DynamicsCompressor):

  • platform/audio/DynamicsCompressorKernel.cpp:

(WebCore::DynamicsCompressorKernel::DynamicsCompressorKernel):
(WebCore::DynamicsCompressorKernel::setNumberOfChannels):
(WebCore):
(WebCore::DynamicsCompressorKernel::setPreDelayTime):
(WebCore::DynamicsCompressorKernel::process):
(WebCore::DynamicsCompressorKernel::reset):

  • platform/audio/DynamicsCompressorKernel.h:

(DynamicsCompressorKernel):

  • webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
(WebCore::DynamicsCompressorNode::initialize):

12:31 Changeset [108537] by commit-queue@webkit.org

Not correctly recalculating layout for elements within nested SVG elements
https://bugs.webkit.org/show_bug.cgi?id=77535

Patch by Bear Travis <betravis@adobe.com> on 2012-02-22
Reviewed by Dirk Schulze.

Source/WebCore:

Relatively positioned text is not correctly updating its position when the
size of its nearest viewport changes. Updating to mark text for layout when
viewPort size changes.

Test: svg/repaint/inner-svg-change-viewPort-relative.svg

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::layoutChildren):

LayoutTests:

Adding a repaint test for a relatively sized inner svg and inner svg content when
its width/height changes.

  • platform/chromium/test_expectations.txt:
  • svg/repaint/inner-svg-change-viewPort-relative-expected.png: Added.
  • svg/repaint/inner-svg-change-viewPort-relative-expected.txt: Added.
  • svg/repaint/inner-svg-change-viewPort-relative.svg: Added.
12:18 Changeset [108536] by commit-queue@webkit.org

[chromium] Fix remaining compositing/rubberbanding test failures
https://bugs.webkit.org/show_bug.cgi?id=78008

These were happening due to the fact that ScrollView wasn't updating
the overhang layer when the contentsSize was updated. This is necessary
because calculateOverhangAreasForPainting() takes the contentsSize into
account when determining whether the overhang areas are visible.

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2012-02-22
Reviewed by James Robinson.

Source/WebCore:

Re-enabled the following tests with updated baselines:

  • platform/chromium/compositing/rubberbanding/transform-overhang-e-expected.png:
  • platform/chromium/compositing/rubberbanding/transform-overhang-s-expected.png:
  • platform/chromium/compositing/rubberbanding/transform-overhang-se-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::setContentsSize):
(WebCore::ScrollView::scrollContents):
(WebCore::ScrollView::updateOverhangAreas):
(WebCore):

  • platform/ScrollView.h:

(ScrollView):

LayoutTests:

Re-enabled the following tests with updated baselines:

  • platform/chromium/compositing/rubberbanding/transform-overhang-e-expected.png:
  • platform/chromium/compositing/rubberbanding/transform-overhang-s-expected.png:
  • platform/chromium/compositing/rubberbanding/transform-overhang-se-expected.png:
  • platform/chromium/test_expectations.txt:
12:15 Changeset [108535] by commit-queue@webkit.org

[BlackBerry] InputHandler has signed vs unsigned comparison.
https://bugs.webkit.org/show_bug.cgi?id=79261

Fix warning by casting the unsigned int to an int.

Patch by Mike Fenton <mifenton@rim.com> on 2012-02-22
Reviewed by Rob Buis.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::rectForCaret):

12:11 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
12:09 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
12:08 Changeset [108534] by mrobinson@webkit.org

.: Update the version information in preparation for the 1.7.90 release.

Reviewed by Gustavo Noronha Silva.

  • configure.ac: Update versions.

Source/WebKit/gtk: Update the NEWS file in preparation for the 1.7.90 release.

Reviewed by Gustavo Noronha Silva.

  • NEWS: Update NEWS.
12:04 Changeset [108533] by vsevik@chromium.org

Web Inspector: [Regression] network worker tests crash on qt.
https://bugs.webkit.org/show_bug.cgi?id=79263

Reviewed by Pavel Feldman.

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::createDecoder):
(WebCore::InspectorPageAgent::cachedResourceContent):

12:02 Changeset [108532] by enne@google.com

Unreviewed, rolling out r108518.
http://trac.webkit.org/changeset/108518
https://bugs.webkit.org/show_bug.cgi?id=75864

Breaks surfaceOcclusionWithOverlappingSiblingSurfaces unit test.

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCLayerIterator.cpp:

(WebCore):
(WebCore::CCLayerIteratorActions::BackToFront::begin):
(WebCore::CCLayerIteratorActions::BackToFront::end):
(WebCore::CCLayerIteratorActions::BackToFront::next):
(WebCore::CCLayerIteratorActions::FrontToBack::begin):
(WebCore::CCLayerIteratorActions::FrontToBack::end):
(WebCore::CCLayerIteratorActions::FrontToBack::next):
(WebCore::CCLayerIteratorActions::FrontToBack::goToHighestInSubtree):

  • platform/graphics/chromium/cc/CCLayerIterator.h:

(WebCore):
(WebCore::CCLayerIterator::CCLayerIterator):
(WebCore::CCLayerIterator::operator++):
(WebCore::CCLayerIterator::operator==):
(WebCore::CCLayerIterator::operator->):
(WebCore::CCLayerIterator::operator*):
(WebCore::CCLayerIterator::representsTargetRenderSurface):
(WebCore::CCLayerIterator::representsContributingRenderSurface):
(WebCore::CCLayerIterator::targetRenderSurfaceLayer):
(CCLayerIterator):
(BackToFront):
(FrontToBack):

  • platform/graphics/chromium/cc/CCLayerIteratorPosition.h: Added.

(WebCore):
(CCLayerIteratorPositionValue):
(WebCore::CCLayerIteratorPosition::CCLayerIteratorPosition):
(CCLayerIteratorPosition):
(WebCore::CCLayerIteratorPosition::currentLayer):
(WebCore::CCLayerIteratorPosition::currentLayerRepresentsContributingRenderSurface):
(WebCore::CCLayerIteratorPosition::currentLayerRepresentsTargetRenderSurface):
(WebCore::CCLayerIteratorPosition::targetRenderSurfaceLayer):
(WebCore::CCLayerIteratorPosition::targetRenderSurface):
(WebCore::CCLayerIteratorPosition::targetRenderSurfaceChildren):
(WebCore::CCLayerIteratorPosition::operator==):

11:52 Changeset [108531] by mrobinson@webkit.org

Merging r108459

11:48 Changeset [108530] by mrobinson@webkit.org

Merging r108523

11:43 Changeset [108529] by mrobinson@webkit.org

Rolling out a bad merge

11:37 Changeset [108528] by mitz@apple.com

REGRESSION (r62632): page-break-inside: avoid is ignored
https://bugs.webkit.org/show_bug.cgi?id=79262

Reviewed by Adele Peterson.

Source/WebCore:

This was disabled in r62632 because of <http://webkit.org/b/41532>. Changes to the
pagination code since then have invalidated that bug, so enabling the feature again does not
re-introduce the bug.

Updated expected results for printing/page-break-inside-avoid.html.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustForUnsplittableChild):

LayoutTests:

  • printing/page-break-inside-avoid-expected.txt:
11:20 Changeset [108527] by philn@webkit.org

Unreviewed, rolling out r108522.
http://trac.webkit.org/changeset/108522
https://bugs.webkit.org/show_bug.cgi?id=76181

Broke 4 fullscreen tests on GTK.

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::supportsFullScreenForElement):
(WebKit::ChromeClient::enterFullScreenForElement):
(WebKit::ChromeClient::exitFullScreenForElement):

  • WebCoreSupport/ChromeClientGtk.h:

(ChromeClient):

  • tests/testwebview.c:
  • webkit/webkitwebview.cpp:

(webkit_web_view_class_init):

  • webkit/webkitwebview.h:

(_WebKitWebViewClass):

Tools:

  • GtkLauncher/main.c:

(createBrowser):
(createWindow):

11:18 Changeset [108526] by mrobinson@webkit.org

Merging r108459

11:14 Changeset [108525] by enne@google.com

[chromium] Unreviewed gardening. Mark some XHR tests as asserting.
https://bugs.webkit.org/show_bug.cgi?id=79229

  • platform/chromium/test_expectations.txt:
11:12 Changeset [108524] by philn@webkit.org

[GStreamer] webkitwebsrc: use HTTP referer provided by MediaPlayer
https://bugs.webkit.org/show_bug.cgi?id=79236

Reviewed by Martin Robinson.

Store a pointer to the MediaPlayer object in the private structure
of the WebKitWebSrc element so we can call its public methods,
like ::referrer().

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::sourceChanged):

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(_WebKitWebSrcPrivate):

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.h:
10:56 Changeset [108523] by mrobinson@webkit.org

[GTK] Clean build is broken when using make -j
https://bugs.webkit.org/show_bug.cgi?id=76388

.:

  • GNUmakefile.am: Add new global source list variables.

Source/WebCore:

No new tests. This is just a build fix.

Use order-only dependencies to ensure that built sources are built before
files that depend on them.

  • GNUmakefile.am: Establish an order-only dependency on some built sources before starting

to build non-generated sources. Rename some temporary files and variables to be more consistent.

  • bindings/gobject/GNUmakefile.am: Updated to reflect new variable names.

Source/WebKit2:

  • GNUmakefile.am: Add some WebKit2 sources to global sources lists

so that we can refer to them in separate GNUmakefiles.

10:56 Changeset [108522] by philn@webkit.org

[GTK] FullScreen signals
https://bugs.webkit.org/show_bug.cgi?id=76181

Reviewed by Martin Robinson.

Source/WebKit/gtk:

Added entering-fullscreen and leaving-fullscreen signals, meant to
be used by the user agent to be notified when an element requests
full screen display and when the full screen display is to be
disabled.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::supportsFullScreenForElement):
(WebKit::onFullscreenGtkKeyPressEvent):
(WebKit::ChromeClient::cancelFullScreen):
(WebKit::ChromeClient::enterFullScreenForElement):
(WebKit::ChromeClient::exitFullScreenForElement):

  • WebCoreSupport/ChromeClientGtk.h:
  • tests/testwebview.c:
  • webkit/webkitwebview.cpp:

(webkit_web_view_real_entering_fullscreen):
(webkit_web_view_real_leaving_fullscreen):
(webkit_web_view_class_init):

  • webkit/webkitwebview.h:

Tools:

Use the two new entering/leaving fullscreen signals to hide/show
the tool bar, the status bar and ask the user's permission before
entering fullscreen.

  • GtkLauncher/main.c:

(webViewFullscreenMessageWindowClose):
(webViewWindowStateEvent):
(hide_widget):
(show_widget):
(webViewEnteringFullScreen):
(webViewLeavingFullScreen):
(createBrowser):
(createWindow):

10:45 Changeset [108521] by commit-queue@webkit.org

[Chromium] New CCOcclusionTracker class with tests
https://bugs.webkit.org/show_bug.cgi?id=78549

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-22
Reviewed by James Robinson.

Source/WebCore:

Adds a CCOcclusionTrackerBase template class that is able to track occlusion
of layers while traversing the layer tree from front-to-back, with typedefed
versions for the main and impl threads.

At each step of the front-to-back traversal, the class should be notified of
changes to the current render target, and when done working with a layer, the
layer is added the tracked occlusion.

The class provides tests for checking if a rect in content space
for a layer/surface is occluded by others in front of it.

Unit tests: CCOcclusionTrackerTest.cpp

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp: Added.

(WebCore):
(WebCore::::enterTargetRenderSurface):
(WebCore::::finishedTargetRenderSurface):
(WebCore::transformSurfaceOpaqueRegion):
(WebCore::::leaveToTargetRenderSurface):
(WebCore::contentToScreenSpaceTransform):
(WebCore::contentToTargetSurfaceTransform):
(WebCore::computeOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):
(WebCore::testContentRectOccluded):
(WebCore::::occluded):
(WebCore::::surfaceOccluded):
(WebCore::rectSubtractRegion):
(WebCore::computeUnoccludedContentRect):
(WebCore::::unoccludedContentRect):
(WebCore::::surfaceUnoccludedContentRect):
(WebCore::::currentOcclusionInScreenSpace):
(WebCore::::currentOcclusionInTargetSurface):

  • platform/graphics/chromium/cc/CCOcclusionTracker.h: Added.

(WebCore):
(CCOcclusionTrackerBase):
(WebCore::CCOcclusionTrackerBase::CCOcclusionTrackerBase):
(StackObject):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCLayerTreeHostCommonTest.cpp:

(WebCore):

  • tests/CCOcclusionTrackerTest.cpp: Added.

(WebCore):
(WebCore::setLayerPropertiesForTesting):
(LayerChromiumWithForcedDrawsContent):
(WebCore::LayerChromiumWithForcedDrawsContent::LayerChromiumWithForcedDrawsContent):
(WebCore::LayerChromiumWithForcedDrawsContent::drawsContent):
(TestCCOcclusionTracker):
(WebCore::TestCCOcclusionTracker::occlusionInScreenSpace):
(WebCore::TestCCOcclusionTracker::occlusionInTargetSurface):
(WebCore::TestCCOcclusionTracker::setOcclusionInScreenSpace):
(WebCore::TestCCOcclusionTracker::setOcclusionInTargetSurface):
(WebCore::TEST):

10:42 Changeset [108520] by jsbell@chromium.org

[Chromium] IndexedDB: Integrate with about:tracing
https://bugs.webkit.org/show_bug.cgi?id=78831

Annotate interesting IDB functions so they show up in the
tracing utility included in the Chromium port.

Reviewed by Tony Chang.

  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/v8/IDBBindingUtilities.cpp:

(WebCore::createIDBKeyFromSerializedValueAndKeyPath):
(WebCore::injectIDBKeyIntoSerializedValue):

  • storage/IDBCursor.cpp:

(WebCore::IDBCursor::direction):
(WebCore::IDBCursor::key):
(WebCore::IDBCursor::primaryKey):
(WebCore::IDBCursor::value):
(WebCore::IDBCursor::update):
(WebCore::IDBCursor::continueFunction):
(WebCore::IDBCursor::deleteFunction):

  • storage/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::direction):
(WebCore::IDBCursorBackendImpl::key):
(WebCore::IDBCursorBackendImpl::primaryKey):
(WebCore::IDBCursorBackendImpl::value):
(WebCore::IDBCursorBackendImpl::update):
(WebCore::IDBCursorBackendImpl::continueFunction):
(WebCore::IDBCursorBackendImpl::continueFunctionInternal):
(WebCore::IDBCursorBackendImpl::deleteFunction):
(WebCore::IDBCursorBackendImpl::prefetchContinue):
(WebCore::IDBCursorBackendImpl::prefetchContinueInternal):
(WebCore::IDBCursorBackendImpl::prefetchReset):
(WebCore::IDBCursorBackendImpl::close):

  • storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::dispatchEvent):

  • storage/IDBIndex.cpp:

(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::count):
(WebCore::IDBIndex::openKeyCursor):
(WebCore::IDBIndex::get):
(WebCore::IDBIndex::getKey):

  • storage/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::openCursorInternal):
(WebCore::IDBIndexBackendImpl::openCursor):
(WebCore::IDBIndexBackendImpl::openKeyCursor):
(WebCore::IDBIndexBackendImpl::countInternal):
(WebCore::IDBIndexBackendImpl::count):
(WebCore::IDBIndexBackendImpl::getInternal):
(WebCore::IDBIndexBackendImpl::get):
(WebCore::IDBIndexBackendImpl::getKey):

  • storage/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::name):
(WebCore::IDBObjectStore::keyPath):
(WebCore::IDBObjectStore::indexNames):
(WebCore::IDBObjectStore::transaction):
(WebCore::IDBObjectStore::get):
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::deleteFunction):
(WebCore::IDBObjectStore::clear):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::openCursor):
(WebCore::IDBObjectStore::count):

  • storage/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::get):
(WebCore::IDBObjectStoreBackendImpl::getInternal):
(WebCore::fetchKeyFromKeyPath):
(WebCore::injectKeyIntoKeyPath):
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteFunction):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):
(WebCore::IDBObjectStoreBackendImpl::clear):
(WebCore::IDBObjectStoreBackendImpl::openCursor):
(WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
(WebCore::IDBObjectStoreBackendImpl::count):
(WebCore::IDBObjectStoreBackendImpl::countInternal):

  • storage/IDBRequest.cpp:

(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::onSuccessWithContinuation):
(WebCore::IDBRequest::dispatchEvent):

  • storage/IDBTracing.h: Added.
  • storage/IDBTransaction.cpp:

(WebCore::IDBTransaction::dispatchEvent):

  • storage/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::abort):
(WebCore::IDBTransactionBackendImpl::commit):
(WebCore::IDBTransactionBackendImpl::taskTimerFired):
(WebCore::IDBTransactionBackendImpl::taskEventTimerFired):

10:38 Changeset [108519] by evan@chromium.org

Merge 107862 - REGRESSION(r105057): Dynamically changing <tspan> offsets is broken
https://bugs.webkit.org/show_bug.cgi?id=78385
<rdar://problem/10832932>

Reviewed by Simon Fraser.

Don't short-circuit buildLayoutAttributesIfNeeded if m_textPositions is already full;
we can't skip rebuilding the layout attributes, just walking the tree to acquire the
positioning lists (invalidation of positioning lists is already covered by textDOMChanged).

Test: svg/text/tspan-dynamic-positioning.svg

  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp:

(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesIfNeeded):

Add a test ensuring that changing the offset of a <tspan> post-load results in correct layout.

  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/text/tspan-dynamic-positioning-expected.png: Added.
  • platform/mac/svg/text/tspan-dynamic-positioning-expected.txt: Added.
  • svg/text/tspan-dynamic-positioning.svg: Added.

TBR=timothy_horton@apple.com
Review URL: https://chromiumcodereview.appspot.com/9429058

10:35 Changeset [108518] by commit-queue@webkit.org

[chromium] Push CCLayerIteratorPosition struct into CCLayerIterator class.
https://bugs.webkit.org/show_bug.cgi?id=75864

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-22
Reviewed by James Robinson.

  • platform/graphics/chromium/cc/CCLayerIterator.cpp:

(WebCore::CCLayerIteratorActions::BackToFront::begin):
(WebCore::CCLayerIteratorActions::BackToFront::end):
(WebCore::CCLayerIteratorActions::BackToFront::next):
(WebCore::CCLayerIteratorActions::FrontToBack::begin):
(WebCore::CCLayerIteratorActions::FrontToBack::end):
(WebCore::CCLayerIteratorActions::FrontToBack::next):
(WebCore::CCLayerIteratorActions::FrontToBack::goToHighestInSubtree):

  • platform/graphics/chromium/cc/CCLayerIterator.h:

(WebCore::CCLayerIterator::CCLayerIterator):
(WebCore::CCLayerIterator::operator++):
(WebCore::CCLayerIterator::operator==):
(WebCore::CCLayerIterator::operator->):
(WebCore::CCLayerIterator::operator*):
(WebCore::CCLayerIterator::representsTargetRenderSurface):
(WebCore::CCLayerIterator::representsContributingRenderSurface):
(WebCore::CCLayerIterator::currentLayer):
(WebCore::CCLayerIterator::currentLayerRepresentsContributingRenderSurface):
(WebCore::CCLayerIterator::currentLayerRepresentsTargetRenderSurface):
(WebCore::CCLayerIterator::targetRenderSurfaceLayer):
(WebCore::CCLayerIterator::targetRenderSurface):
(WebCore::CCLayerIterator::targetRenderSurfaceChildren):

  • platform/graphics/chromium/cc/CCLayerIteratorPosition.h: Removed.
10:35 Changeset [108517] by enne@google.com

[chromium] Unreviewed gardening. Marking svg failures from r108494.
https://bugs.webkit.org/show_bug.cgi?id=41386

  • platform/chromium/test_expectations.txt:
10:25 Changeset [108516] by commit-queue@webkit.org

Update Linux ChromiumOS builders in flakiness dashboard.
https://bugs.webkit.org/show_bug.cgi?id=79238

Patch by Rob Flack <flackr@chromium.org> on 2012-02-22
Reviewed by Ojan Vafai.

  • TestResultServer/static-dashboards/builders.js:
10:19 Changeset [108515] by dpranke@chromium.org

webkitpy: test_function_length_check_definition_huge_lines is slow
https://bugs.webkit.org/show_bug.cgi?id=79185

Reviewed by Adam Barth.

This test takes ~3 seconds to run, apparently because we're
running a test on a 10,000 line function :). Dropping the
function length to 640 still exercises the code path and
provides a 10x speedup.

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(CppStyleTest):
(CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines):

10:17 WebKitGTK/1.8.x edited by sergio@webkit.org
(diff)
10:16 Changeset [108514] by dpranke@chromium.org

webkitpy: speed up FileLockTest.test_lock_lifecycle
https://bugs.webkit.org/show_bug.cgi?id=79189

Reviewed by Adam Barth.

The unit test had a second lock trying to acquire a
lock already held, and a hard-coded timeout of one second.
I have changed the timeouts to a tenth of a second (which
is probably still fine) and changed the hard-spin on
the lock to a slow-spin every hundredth of a second.

  • Scripts/webkitpy/common/system/file_lock.py:

(FileLock.acquire_lock):

  • Scripts/webkitpy/common/system/file_lock_integrationtest.py:

(FileLockTest.setUp):
(FileLockTest.test_stuck_lock):

10:10 Changeset [108513] by rgabor@webkit.org

build-webkit should use environment variable at number of CPU
detection on all platform
https://bugs.webkit.org/show_bug.cgi?id=79227

Reviewed by Martin Robinson.

  • Scripts/webkitdirs.pm:

(determineNumberOfCPUs):

09:44 Changeset [108512] by commit-queue@webkit.org

[GTK][WK2] Add WebGL WebSetting.
https://bugs.webkit.org/show_bug.cgi?id=79217

Patch by Antaryami Pandia <antaryami.pandia@motorola.com> on 2012-02-22
Reviewed by Martin Robinson.

Add a WebSetting to enable/disable Webgl.

  • UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_set_enable_webaudio):
(webkit_settings_get_enable_webgl):
(webkit_settings_set_enable_webgl):

  • UIProcess/API/gtk/WebKitSettings.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings):

09:39 Changeset [108511] by pfeldman@chromium.org

Web Inspector: console doesn't show properly arrays from which tail values have been deleted
https://bugs.webkit.org/show_bug.cgi?id=79242

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._printArray.appendUndefined):
(WebInspector.ConsoleMessageImpl.prototype._printArray):

LayoutTests:

  • inspector/console/console-format-expected.txt:
  • inspector/console/console-format.html:
  • platform/chromium/inspector/console/console-format-collections-expected.txt:
  • platform/chromium/inspector/console/console-format-expected.txt:
09:26 Changeset [108510] by pfeldman@chromium.org

Merge 107681 - Web Inspector: [REGRESSION] Copy Stack Trace is broken
https://bugs.webkit.org/show_bug.cgi?id=78583

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/debugger/copy-stack-trace.html

  • inspector/front-end/CallStackSidebarPane.js:

(WebInspector.CallStackSidebarPane.prototype._copyStackTrace):

LayoutTests:

  • inspector/debugger/copy-stack-trace-expected.txt: Added.
  • inspector/debugger/copy-stack-trace.html: Added.

TBR=pfeldman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9430052

09:09 Changeset [108509] by pfeldman@chromium.org

Web Inspector: warning external font mime (font/font/woff).
https://bugs.webkit.org/show_bug.cgi?id=79244

Reviewed by Yury Semikhatsky.

  • inspector/front-end/Resource.js:
09:05 Changeset [108508] by yurys@chromium.org

Web Inspector: use dots as markers on the counter graphs
https://bugs.webkit.org/show_bug.cgi?id=79243

Changed counter graphs marker and counter text styles.

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/MemoryStatistics.js:

(WebInspector.MemoryStatistics):
(WebInspector.MemoryStatistics.prototype._createCounterSidebarElement):
(WebInspector.MemoryStatistics.prototype.addTimlineEvent):
(WebInspector.MemoryStatistics.prototype._draw):
(WebInspector.MemoryStatistics.prototype._onMouseOut):
(WebInspector.MemoryStatistics.prototype._onMouseOver):
(WebInspector.MemoryStatistics.prototype._onMouseMove):
(WebInspector.MemoryStatistics.prototype._refreshCurrentValues):
(WebInspector.MemoryStatistics.prototype._recordIndexAt):
(WebInspector.MemoryStatistics.prototype._highlightCurrentPositionOnGraphs):
(WebInspector.MemoryStatistics.prototype._clearMarkers):
(WebInspector.MemoryStatistics.prototype._saveImageUnderMarker):
(WebInspector.MemoryStatistics.prototype.refresh):
(WebInspector.MemoryStatistics.prototype._drawPolyline):
(WebInspector.MemoryStatistics.prototype._clear):

  • inspector/front-end/timelinePanel.css:

(.memory-counter-sidebar-info):
(.memory-counter-sidebar-info .title):
(.memory-counter-sidebar-info .counter-value):

08:54 Changeset [108507] by pfeldman@chromium.org

Web Inspector: make 'glue asynchronous events' optional.
https://bugs.webkit.org/show_bug.cgi?id=79240

Reviewed by Yury Semikhatsky.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/Images/statusbarButtonGlyphs.png:
  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype.get statusBarItems):
(WebInspector.TimelinePanel.prototype._createStatusbarButtons):
(WebInspector.TimelinePanel.prototype._glueParentButtonClicked):
(WebInspector.TimelinePanel.prototype._toggleStartAtZeroButtonClicked):
(WebInspector.TimelinePanel.prototype._repopulateRecords):
(WebInspector.TimelinePanel.prototype._findParentRecord):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype.sidebarResized):
(WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages):
(WebInspector.TimelineCalculator.prototype.computeBarGraphWindowPosition):
(WebInspector.TimelineRecordGraphRow):
(WebInspector.TimelineRecordGraphRow.prototype.update):
(WebInspector.TimelinePanel.FormattedRecord.prototype._calculateAggregatedStats):

  • inspector/front-end/timelinePanel.css:

(.glue-async-status-bar-item .glyph):
(.timeline-start-at-zero-status-bar-item .glyph):

08:47 Changeset [108506] by vsevik@chromium.org

Web Inspector: [REGRESSION] Console xhr logging is broken for async xhrs since r107672.
https://bugs.webkit.org/show_bug.cgi?id=79229

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/console-xhr-logging-async.html

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::setInitialScriptContent):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::didFinishLoading):

LayoutTests:

  • http/tests/inspector/console-xhr-logging-async-expected.txt: Added.
  • http/tests/inspector/console-xhr-logging-async.html: Added.
08:29 Changeset [108505] by mihnea@adobe.com

[Qt] REGRESSION(r108108): It made 3 fast/repaint tests fail
https://bugs.webkit.org/show_bug.cgi?id=78960

Reviewed by Csaba Osztrogonác.

Source/WebKit/qt:

  • Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):
(QWebSettings::QWebSettings):

  • Api/qwebsettings.h:

Tools:

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::overridePreference):

LayoutTests:

  • fast/repaint/japanese-rl-selection-repaint-in-regions.html:
  • fast/repaint/line-flow-with-floats-in-regions.html:
  • fast/repaint/overflow-flipped-writing-mode-block-in-regions.html:
  • fast/repaint/region-painting-invalidation.html:
  • fast/repaint/region-painting-via-layout.html:
  • platform/qt/Skipped:
08:08 Changeset [108504] by caseq@chromium.org

Web Inspector: fix memory counters and start-at-zero modes of timeline panels to co-exist nicely
https://bugs.webkit.org/show_bug.cgi?id=79241

Reviewed by Yury Semikhatsky.

  • inspector/front-end/MemoryStatistics.js:

(WebInspector.MemoryStatistics.prototype.addTimlineEvent):

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype._showTimelines):
(WebInspector.TimelineOverviewPane.prototype._showMemoryGraph):
(WebInspector.TimelineOverviewPane.prototype.setStartAtZero):
(WebInspector.TimelineOverviewPane.prototype._onWindowChanged):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._timelinesOverviewModeChanged):

07:42 Changeset [108503] by eric.carlson@apple.com

[Chromium] video-referer.html fails
https://bugs.webkit.org/show_bug.cgi?id=79239

Unreviewed, skipping a test that started to fail after r108387.

  • platform/chromium/test_expectations.txt:
07:16 Changeset [108502] by caseq@chromium.org

Web Inspector: [experimental] add a mode to display timeline events aligned by the start time
https://bugs.webkit.org/show_bug.cgi?id=79123

Reviewed by Pavel Feldman.

  • inspector/front-end/Images/statusbarButtonGlyphs.png:
  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype._showTimelines):
(WebInspector.TimelineOverviewPane.prototype._showMemoryGraph):
(WebInspector.TimelineOverviewPane.prototype._onWindowChanged):
(WebInspector.TimelineOverviewPane.prototype.setStartAtZero):
(WebInspector.TimelineOverviewPane.prototype.update):
(WebInspector.TimelineOverviewPane.prototype.reset):
(WebInspector.TimelineOverviewWindow):
(WebInspector.TimelineOverviewWindow.prototype.reset):
(WebInspector.TimelineOverviewWindow.prototype._setWindowPosition):
(WebInspector.TimelineOverviewWindow.prototype.scrollWindow):
(WebInspector.TimelineStartAtZeroOverview):
(WebInspector.TimelineStartAtZeroOverview.prototype.reset):
(WebInspector.TimelineStartAtZeroOverview.prototype.update):
(WebInspector.TimelineStartAtZeroOverview.prototype._filterRecords):
(WebInspector.TimelineStartAtZeroOverview.prototype._buildBar):
(WebInspector.TimelineStartAtZeroOverview.prototype._onWindowChanged):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype.get statusBarItems):
(WebInspector.TimelinePanel.prototype._createStatusbarButtons):
(WebInspector.TimelinePanel.prototype._toggleStartAtZeroButtonClicked):
(WebInspector.TimelinePanel.prototype.get _startAtZero):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype.sidebarResized):
(WebInspector.TimelinePanel.prototype._onRecordsCleared):
(WebInspector.TimelinePanel.prototype._resetPanel):
(WebInspector.TimelinePanel.prototype._scheduleRefresh):
(WebInspector.TimelinePanel.prototype._refresh):
(WebInspector.TimelinePanel.prototype._filterRecords):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelineCalculator.prototype.computeBarGraphWindowPosition):
(WebInspector.TimelineStartAtZeroCalculator):
(WebInspector.TimelineStartAtZeroCalculator.prototype.computeBarGraphPercentages):
(WebInspector.TimelineStartAtZeroCalculator.prototype.computeBarGraphWindowPosition):
(WebInspector.TimelineStartAtZeroCalculator.prototype.calculateWindow):
(WebInspector.TimelineStartAtZeroCalculator.prototype.reset):
(WebInspector.TimelineStartAtZeroCalculator.prototype.updateBoundaries):
(WebInspector.TimelineStartAtZeroCalculator.prototype.formatValue):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generateAggregatedInfo):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._calculateAggregatedStats):
(WebInspector.TimelinePanel.FormattedRecord.prototype.get aggregatedStats):
(WebInspector.TimelineModel.prototype.get records):
(WebInspector.TimelinePresentationModel):
(WebInspector.TimelinePresentationModel.prototype.reset):
(WebInspector.TimelinePresentationModel.prototype.setWindowIndices):
(WebInspector.TimelineRecordFilter):
(WebInspector.TimelineRecordFilter.prototype.accept):
(WebInspector.TimelineStartAtZeroRecordFilter):
(WebInspector.TimelineStartAtZeroRecordFilter.prototype.accept):

  • inspector/front-end/timelinePanel.css:

(.timeline-start-at-zero #timeline-overview-sidebar):
(.timeline-start-at-zero #timeline-overview-grid):
(.timeline-overview-window):
(.timeline-start-at-zero .timeline-overview-window):
(.timeline-start-at-zero .timeline-overview-dividers-background):
(.timeline-overview-window-rulers):
(.timeline-start-at-zero #timeline-overview-memory):
(.popover .timeline-loading):
(.popover .timeline-scripting):
(.popover .timeline-rendering):
(.timeline-start-at-zero-status-bar-item .glyph):
(.timeline-start-at-zero-status-bar-item.toggled-on .glyph):
(.timeline-overview-start-at-zero):
(.timeline-overview-start-at-zero-bars):
(.timeline-overview-start-at-zero-bars .padding):
(.timeline-overview-start-at-zero-bars .timeline-bar-vertical):
(.timeline-bar-vertical div:first-child):
(.timeline-bar-vertical .timeline-loading):
(.timeline-bar-vertical .timeline-scripting):
(.timeline-bar-vertical .timeline-rendering):

07:15 Changeset [108501] by kenneth@webkit.org

[Qt] Disregard previous backing store as soon as possible https://bugs.webkit.org/show_bug.cgi?id=79232

Reviewed by Simon Hausmann and No'am Rosenthal.

Source/WebCore:

Make it possible to drop non-visible tiles and to test
if the current visible rect is fully covered.

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::visibleContentsRect):
(WebCore::TiledBackingStore::coverageRatio):
(WebCore::TiledBackingStore::visibleAreaIsCovered):
(WebCore):
(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::removeAllNonVisibleTiles):

  • platform/graphics/TiledBackingStore.h:

(TiledBackingStore):

Source/WebKit2:

Between creating the new backing store and painting the content,
we do not want to drop the previous one as that might result in
briefly seeing flickering as the old tiles may be dropped before
something replaces them.

But we do need to drop it at some point and we need to make sure
to not spike the memory usage before of this.

What we now do, is to store the previous backing store as before,
but drop all tiles which are not visible and then drop it as soon
as the visible rect (which might change due if followed by a quick
panning) has been fully covered by tiles.

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::setContentsScale):
(WebCore::WebGraphicsLayer::updateContentBuffers):

07:12 Changeset [108500] by philn@webkit.org

Unreviewed, skipping one more mediastream failure on GTK.

  • platform/gtk/Skipped:
07:11 Changeset [108499] by commit-queue@webkit.org

[Qt][WK2] Implement proxy authentication handling.
https://bugs.webkit.org/show_bug.cgi?id=78792

Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-02-22
Reviewed by Simon Hausmann.

This patch corrects two bugs with the previous implementation:

  1. The signal proxyAuthenticationRequired was not connected to a slot.
  2. The slot onProxyAuthenticationRequired had the wrong parameters.
  • WebProcess/qt/QtNetworkAccessManager.cpp:

(WebKit::QtNetworkAccessManager::QtNetworkAccessManager):
(WebKit::QtNetworkAccessManager::onProxyAuthenticationRequired):

  • WebProcess/qt/QtNetworkAccessManager.h: Added include.

(QtNetworkAccessManager):

07:10 Changeset [108498] by hausmann@webkit.org

[Qt] Move QMenu dependant scrollbar context menu handling out of WebCore
https://bugs.webkit.org/show_bug.cgi?id=79233

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Move the code into WebKit/qt/Api/qwebpage.cpp, the only place where it is called from.

  • Target.pri: Remove ScrollbarQt.cpp from build.
  • platform/Scrollbar.h: Remove Qt-only context menu handling but make moveThum

accessible from the outside.

  • platform/qt/ScrollbarQt.cpp: Removed. Not needed anymore.

Source/WebKit/qt:

Move scrollbar context menu handling here, it's the only place where it is
used.

  • Api/qwebpage.cpp:

(handleScrollbarContextMenuEvent):
(QWebPage::swallowContextMenuEvent):

07:07 Changeset [108497] by vsevik@chromium.org

Web Inspector: retrieving content for some XHR requests crashes inspected page renderer
https://bugs.webkit.org/show_bug.cgi?id=79026

Reviewed by Pavel Feldman.

Source/WebCore:

Fixed loading empty xhr content and xhr content decoding that was
broken in r107672.

Tests: http/tests/inspector/network/network-cyrillic-xhr.html

http/tests/inspector/network/network-empty-xhr.html

  • inspector/InspectorPageAgent.cpp:

(WebCore):
(WebCore::InspectorPageAgent::createDecoder):
(WebCore::InspectorPageAgent::cachedResourceContent):

  • inspector/InspectorPageAgent.h:

(WebCore):

  • inspector/NetworkResourcesData.cpp:

(WebCore::NetworkResourcesData::ResourceData::decodeDataToContent):
(WebCore::NetworkResourcesData::responseReceived):

  • inspector/NetworkResourcesData.h:

(WebCore::NetworkResourcesData::ResourceData::decoder):
(WebCore::NetworkResourcesData::ResourceData::setDecoder):

LayoutTests:

  • http/tests/inspector/network/network-cyrillic-xhr-expected.txt: Added.
  • http/tests/inspector/network/network-cyrillic-xhr.html: Added.
  • http/tests/inspector/network/network-empty-xhr-expected.txt: Added.
  • http/tests/inspector/network/network-empty-xhr.html: Added.
  • http/tests/inspector/network/resources/cyrillic.html: Added.
  • http/tests/inspector/network/resources/empty.html: Added.
07:05 Changeset [108496] by yurys@chromium.org

Web Inspector: CodeGeneratorInspector.py: remove neural-net-style constructions
https://bugs.webkit.org/show_bug.cgi?id=79153

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-22
Reviewed by Yury Semikhatsky.

CParamType class removed completely, some ("virtual") methods are
removed. TypeModel notion is added instead with some minor helper
classes and methods.

  • inspector/CodeGeneratorInspector.py:

(DomainNameFixes):
(RawTypes.BaseType):
(RawTypes.String):
(RawTypes.String.get_raw_type_model):
(RawTypes.Int):
(RawTypes.Int.get_raw_type_model):
(RawTypes.Number):
(RawTypes.Number.get_raw_type_model):
(RawTypes.Bool):
(RawTypes.Bool.get_raw_type_model):
(RawTypes.Object):
(RawTypes.Object.get_raw_type_model):
(RawTypes.Any):
(RawTypes.Any.get_raw_type_model):
(RawTypes.Array):
(RawTypes.Array.get_raw_type_model):
(replace_right_shift):
(CommandReturnPassModel):
(CommandReturnPassModel.ByReference):
(CommandReturnPassModel.ByReference.init):
(CommandReturnPassModel.ByReference.get_return_var_type):
(CommandReturnPassModel.get_output_argument_prefix):
(CommandReturnPassModel.get_output_to_raw_expression):
(CommandReturnPassModel.get_output_parameter_type):
(CommandReturnPassModel.get_set_return_condition):
(CommandReturnPassModel.ByPointer):
(CommandReturnPassModel.ByPointer.init):
(CommandReturnPassModel.ByPointer.get_return_var_type):
(TypeModel):
(TypeModel.RefPtrBased):
(TypeModel.RefPtrBased.init):
(TypeModel.RefPtrBased.get_optional):
(TypeModel.RefPtrBased.get_command_return_pass_model):
(TypeModel.RefPtrBased.get_input_param_type_text):
(TypeModel.RefPtrBased.get_event_setter_expression_pattern):
(TypeModel.Enum):
(TypeModel.Enum.init):
(TypeModel.Enum.get_optional):
(TypeModel.Enum.get_optional.EnumOptional):
(TypeModel.Enum.get_optional.EnumOptional.get_optional):
(TypeModel.Enum.get_optional.EnumOptional.get_command_return_pass_model):
(TypeModel.Enum.get_input_param_type_text):
(TypeModel.Enum.get_event_setter_expression_pattern):
(TypeModel.Enum.get_command_return_pass_model):
(TypeModel.ValueType):
(TypeModel.ValueType.init):
(TypeModel.ValueType.get_optional):
(TypeModel.ValueType.get_command_return_pass_model):
(TypeModel.ValueType.get_input_param_type_text):
(TypeModel.ValueType.get_event_setter_expression_pattern):
(TypeModel.ValueType.ValueOptional):
(TypeModel.ValueType.ValueOptional.init):
(TypeModel.ValueType.ValueOptional.get_optional):
(TypeModel.ValueType.ValueOptional.get_command_return_pass_model):
(TypeModel.ValueType.ValueOptional.get_input_param_type_text):
(TypeModel.ValueType.ValueOptional.get_event_setter_expression_pattern):
(TypeModel.init_class):
(TypeBindings.create_ad_hoc_type_declaration.Helper):
(TypeBindings.create_type_declaration_.EnumBinding.get_array_item_c_type_text):
(TypeBindings.create_type_declaration_.EnumBinding.get_setter_value_expression_pattern):
(TypeBindings.create_type_declaration_.EnumBinding):
(TypeBindings.create_type_declaration_.EnumBinding.get_type_model):
(TypeBindings.create_type_declaration_):
(TypeBindings.create_type_declaration_.get_type_model):
(TypeBindings.create_type_declaration_.get_array_item_c_type_text):
(get_type_model):
(AdHocTypeContextImpl.init):
(PlainObjectBinding):
(PlainObjectBinding.get_type_model):
(AdHocTypeContext):
(ArrayBinding.get_array_item_c_type_text):
(ArrayBinding):
(ArrayBinding.get_type_model):
(RawTypeBinding.get_validator_call_text):
(RawTypeBinding.reduce_to_raw_type):
(RawTypeBinding):
(RawTypeBinding.get_type_model):
(MethodGenerateModes.StrictParameterMode.get_c_param_type_text):
(MethodGenerateModes.RawParameterMode.get_c_param_type_text):
(MethodGenerateModes.CombinedMode.get_c_param_type_text):
(Generator.go):
(Generator.process_event):
(Generator.process_command):
(Generator.resolve_type_and_generate_ad_hoc):
(Generator.resolve_type_and_generate_ad_hoc.AdHocTypeContext):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::didParseSource):

07:00 Changeset [108495] by vsevik@chromium.org

Web Inspector: [InspectorIndexedDB] Show IndexedDB views on selection IndexedDB elements in resources panel.
https://bugs.webkit.org/show_bug.cgi?id=79098

Reviewed by Pavel Feldman.

Source/WebCore:

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):

  • inspector/compile-front-end.sh:
  • inspector/front-end/IndexedDBModel.js:

(WebInspector.IndexedDBModel.prototype._assertFrameId):
(WebInspector.IndexedDBModel.prototype.loadObjectStoreData):
(WebInspector.IndexedDBModel.prototype.loadIndexData):

  • inspector/front-end/IndexedDBViews.js: Added.
  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertiesSection):
(WebInspector.ObjectPropertiesSection.prototype.updateProperties):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.showIndexedDB):
(WebInspector.IndexedDBTreeElement.prototype.refreshIndexedDB):
(WebInspector.IndexedDBTreeElement.prototype._indexedDBAdded):
(WebInspector.IDBDatabaseTreeElement):
(WebInspector.IDBDatabaseTreeElement.prototype.get itemURL):
(WebInspector.IDBDatabaseTreeElement.prototype.update):
(WebInspector.IDBDatabaseTreeElement.prototype.onselect):
(WebInspector.IDBObjectStoreTreeElement):
(WebInspector.IDBObjectStoreTreeElement.prototype.get itemURL):
(WebInspector.IDBObjectStoreTreeElement.prototype.update):
(WebInspector.IDBObjectStoreTreeElement.prototype.onselect):
(WebInspector.IDBIndexTreeElement):
(WebInspector.IDBIndexTreeElement.prototype.get itemURL):
(WebInspector.IDBIndexTreeElement.prototype.update):
(WebInspector.IDBIndexTreeElement.prototype.onselect):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/externs.js:
  • inspector/front-end/indexedDBViews.css: Added.
  • inspector/front-end/inspector.html:

LayoutTests:

  • http/tests/inspector/indexeddb/database-data.html:
06:49 Changeset [108494] by zimmermann@webkit.org

REGRESSION(58212): html foreignObjects with positions other than static not hidden correctly when parent has display:none
https://bugs.webkit.org/show_bug.cgi?id=41386

Reviewed by Zoltan Herczeg.

Source/WebCore:

r58212 gave SVGGElements a renderer, regardless if "display: none" was set or not, for various reasons (see change set).
The <g> renderer for such cases is a RenderSVGHiddenContainer. We make sure in SVG that such subtrees are never used
for painting & hittesting - they only exist for the purpose of SVG DOM (query getCTM, etc..) and to create renderers
for child resources, like <g display="none"><linearGradient>.

This concept still works fine for: <g display="none"><foreignObject><body>Foobar</body></foreignObject></g>, as
RenderSVGForeignObject::paint is never called thus we never paint the subtree of the <fO>. If the <body> elements
contains "position: relative" a new layer is created for the <body>. When the document paints we have two seperated
layers, and the <body> layer doesn't know that it's actually inside a "SVG hidden subtree", and gets painted, where it
shouldn't. HTML doesn't have this problems, as a display: none object, never creates a renderer.

The fix is to disallow layer creation in hidden SVG subtrees, to mimic what would happen if we'd follow HTML rules
to not create renderers for display: none objects. This avoids any indirections - as no layers are created anymore.

Tests: svg/foreignObject/fO-display-none-with-relative-pos-content.svg

svg/foreignObject/fO-display-none.svg
svg/foreignObject/fO-parent-display-changes.svg
svg/foreignObject/fO-parent-display-none-with-relative-pos-content.svg
svg/foreignObject/fO-parent-display-none.svg
svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content.svg
svg/foreignObject/fO-parent-of-parent-display-none.svg

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::styleDidChange): Only create layers, if its allowed -- layerCreationAllowedForSubtree() will always return true for HTML, and only false for layers inside a hidden SVG subtree.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::addChild): Only create layers, if its allowed.

  • rendering/RenderObject.h: Add inline layerCreationAllowedForSubtree() helper, that craws the tree to find a RenderSVGHiddenContainer ancestor, if not present, return true.

LayoutTests:

Add new tests covering <foreignObject> content inside a <g display="none">.

  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/foreignObject/fO-display-none-expected.png: Added.
  • platform/mac/svg/foreignObject/fO-display-none-expected.txt: Added.
  • platform/mac/svg/foreignObject/fO-display-none-with-relative-pos-content-expected.png: Added.
  • platform/mac/svg/foreignObject/fO-display-none-with-relative-pos-content-expected.txt: Added.
  • platform/mac/svg/foreignObject/fO-parent-display-changes-expected.png: Added.
  • platform/mac/svg/foreignObject/fO-parent-display-changes-expected.txt: Added.
  • platform/mac/svg/foreignObject/fO-parent-display-none-expected.png: Added.
  • platform/mac/svg/foreignObject/fO-parent-display-none-expected.txt: Added.
  • platform/mac/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.png: Added.
  • platform/mac/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt: Added.
  • platform/mac/svg/foreignObject/fO-parent-of-parent-display-none-expected.png: Added.
  • platform/mac/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt: Added.
  • platform/mac/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.png: Added.
  • platform/mac/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt: Added.
  • svg/foreignObject/fO-display-none-with-relative-pos-content.svg: Added.
  • svg/foreignObject/fO-display-none.svg: Added.
  • svg/foreignObject/fO-parent-display-changes.svg: Added.
  • svg/foreignObject/fO-parent-display-none-with-relative-pos-content.svg: Added.
  • svg/foreignObject/fO-parent-display-none.svg: Added.
  • svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content.svg: Added.
  • svg/foreignObject/fO-parent-of-parent-display-none.svg: Added.
06:21 Changeset [108493] by zimmermann@webkit.org

2012-02-22 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix SVG pixel test results, which now show up as hash failures, since DRT was fixed to report these.

  • platform/mac/svg/W3C-SVG-1.1/coords-units-03-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-02-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-text-04-t-expected.png:
  • platform/mac/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/mac/svg/clip-path/clip-in-mask-expected.png:
  • platform/mac/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png:
  • platform/mac/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png:
  • platform/mac/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png:
  • platform/mac/svg/custom/circular-marker-reference-2-expected.png:
  • platform/mac/svg/custom/glyph-selection-arabic-forms-expected.png:
  • platform/mac/svg/custom/glyph-selection-bidi-mirror-expected.png:
  • platform/mac/svg/custom/glyph-selection-non-bmp-expected.png:
  • platform/mac/svg/custom/gradient-rotated-bbox-expected.png:
  • platform/mac/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.png:
  • platform/mac/svg/custom/marker-opacity-expected.png:
  • platform/mac/svg/custom/non-circular-marker-reference-expected.png:
  • platform/mac/svg/dom/SVGLocatable-getCTM-svg-root-expected.png:
  • platform/mac/svg/hixie/error/017-expected.png:
  • platform/mac/svg/text/text-align-05-b-expected.png:
  • platform/mac/svg/text/text-path-01-b-expected.png:
  • platform/mac/svg/text/text-text-01-b-expected.png:
  • platform/mac/svg/text/text-text-07-t-expected.png:
  • platform/mac/svg/text/text-tselect-02-f-expected.png:
  • svg/as-image/svg-non-integer-scaled-image-expected.png:
  • svg/custom/visited-link-color-expected.png:
  • svg/custom/zero-path-square-cap-rendering2-expected.png:
  • svg/foreignObject/clip-expected.png:
  • svg/foreignObject/filter-expected.png:
  • svg/foreignObject/mask-expected.png:
06:18 Changeset [108492] by zherczeg@webkit.org

Drop clipToImageBuffer from RenderBoxModelObject
https://bugs.webkit.org/show_bug.cgi?id=79225

Reviewed by Nikolas Zimmermann.

-webkit-background-clip: text is a rarely used non-standard
feature uses clipToImageBuffer. It is replaced by
CompositeDestinationIn on a transparent layer. The new
approach has the same speed as the old one.

Existing tests cover this issue.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):

05:56 Changeset [108491] by kenneth@webkit.org

Merge setVisibleRectTrajectoryVector and adjustVisibleRect to the more descriptive coverWithTilesIfNeeded https://bugs.webkit.org/show_bug.cgi?id=79230

Reviewed by Simon Hausmann.

Source/WebCore:

Both setVisibleRectTrajectoryVector and the adjustVisibleRect are
used for initiating re-tiling, so make that more obvious and merge
the two.

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::coverWithTilesIfNeeded):

  • platform/graphics/TiledBackingStore.h:

(TiledBackingStore):

Source/WebKit/qt:

  • Api/qgraphicswebview.cpp:

(QGraphicsWebView::paint):

Use coverWithTilesIfNeeded().

Source/WebKit2:

Replace use by coverWithTilesIfNeeded().

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::setVisibleContentRectTrajectoryVector):
(WebCore::WebGraphicsLayer::adjustVisibleRect):
(WebCore::WebGraphicsLayer::computeTransformedVisibleRect):

05:38 Changeset [108490] by zimmermann@webkit.org

REGRESSION: unbalanced transparency layers for clipPath
https://bugs.webkit.org/show_bug.cgi?id=78074

Reviewed by Zoltan Herczeg.

Source/WebCore:

If we're rendering to a mask image buffer, all children are rendered with opacity=1, regardless what their RenderStyles specify.
SVGRenderSupport::finishRenderSVGContent() did not take this into account and always called endTransparencyLayer(). Fix that
by checking if we're rendering to a mask image buffer, if so don't call endTransparencyLayer().

Add new reftest covering both the visual & logical correctness (no assertion).

Tests: svg/clip-path/opacity-assertion-expected.svg

svg/clip-path/opacity-assertion.svg

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::isRenderingMaskImage): Extraced as sharable helper function.
(WebCore::SVGRenderSupport::prepareToRenderSVGContent): Factor out isRenderingMaskImage() function.
(WebCore::SVGRenderSupport::finishRenderSVGContent): Only call endTransparencyLayer(), if we actually called beginTL() first.

LayoutTests:

  • svg/clip-path/opacity-assertion-expected.svg: Added.
  • svg/clip-path/opacity-assertion.svg: Added.
05:36 Changeset [108489] by kenneth@webkit.org

Improve comments in tiling code.

Rubberstamped by Simon Hausmann.

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::createTiles):

05:27 Changeset [108488] by pfeldman@chromium.org

Not reviewed: build fix.

  • inspector/InspectorController.cpp:
  • inspector/InspectorController.h:

(InspectorController):

05:25 Changeset [108487] by commit-queue@webkit.org

[chromium] Build WebKit with MEDIA_STREAM disabled.
https://bugs.webkit.org/show_bug.cgi?id=79214

Patch by Hao Zheng <zhenghao@chromium.org> on 2012-02-22
Reviewed by Kent Tamura.

Source/WebKit/chromium:

  • src/UserMediaClientImpl.h:

Tools:

  • DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
  • DumpRenderTree/chromium/WebUserMediaClientMock.h:
  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createMediaPlayer):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

05:13 Changeset [108486] by pfeldman@chromium.org

Web Inspector: do not filter out requestAnimationFrame from timeline, implement stop on animation events.
https://bugs.webkit.org/show_bug.cgi?id=79116

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • English.lproj/localizedStrings.js:
  • dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::registerCallback):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didRequestAnimationFrameCallbackImpl):
(WebCore::InspectorInstrumentation::didCancelAnimationFrameCallbackImpl):
(WebCore::InspectorInstrumentation::willFireAnimationFrameEventImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didRequestAnimationFrameCallback):

  • inspector/InspectorTimelineAgent.cpp:

(TimelineRecordType):
(WebCore::InspectorTimelineAgent::didRequestAnimationFrameCallback):
(WebCore::InspectorTimelineAgent::didCancelAnimationFrameCallback):
(WebCore::InspectorTimelineAgent::willFireAnimationFrameEvent):
(WebCore::InspectorTimelineAgent::didFireAnimationFrameEvent):

  • inspector/InspectorTimelineAgent.h:

(InspectorTimelineAgent):

  • inspector/front-end/BreakpointsSidebarPane.js:

(WebInspector.EventListenerBreakpointsSidebarPane):
(WebInspector.EventListenerBreakpointsSidebarPane.eventNameForUI):

  • inspector/front-end/TimelineAgent.js:
  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype.get _recordStyles):
(WebInspector.TimelinePanel.prototype._findParentRecord):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype._onRecordsCleared):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):

LayoutTests:

  • inspector/timeline/timeline-animation-frame-expected.txt:
  • inspector/timeline/timeline-animation-frame.html:
  • inspector/timeline/timeline-enum-stability-expected.txt:
  • platform/chromium/inspector/timeline/timeline-animation-frame-expected.txt:
05:10 Changeset [108485] by haraken@chromium.org

Remove unused class declaration in WebCore/page/scrolling/ScrollingCoordinator.h
https://bugs.webkit.org/show_bug.cgi?id=79175

Patch by Changhun Kang <temoochin@company100.net> on 2012-02-22
Reviewed by Kentaro Hara.

  • page/scrolling/ScrollingCoordinator.h:

Remove PlatformGestureEvent class declaration.
(WebCore):

05:05 Changeset [108484] by ossy@webkit.org

Unreviewed, rolling out r108456.
http://trac.webkit.org/changeset/108456
https://bugs.webkit.org/show_bug.cgi?id=79223

Broke fast/regex/pcre-test-4.html and cannot find anyone on
IRC (Requested by zherczeg on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-22

  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::backtrackPatternCharacterGreedy):

04:56 Changeset [108483] by abecsi@webkit.org

[Qt][WK2] Fix the N9 build
https://bugs.webkit.org/show_bug.cgi?id=79101

Reviewed by Simon Hausmann.

Fixed the include order of the rolled out r108359 not to break
the build with CONFIG+=force_static_libs_as_shared.

  • platform/graphics/OpenGLShims.h: Add missing include.
04:51 Changeset [108482] by yutak@chromium.org

[Chromium] Unreviewed, regular maintenance of test expectations.

  • platform/chromium/test_expectations.txt:
04:47 WebKit Team edited by wingo@igalia.com
Remove duplicate entry for Enrica Casucci (diff)
04:20 Changeset [108481] by ossy@webkit.org

[Qt] Unreviewed gardening, skip a new failing test.

  • platform/qt/Skipped:
04:06 Changeset [108480] by shinyak@chromium.org

firstRendererOf() should also return a fallback element renderer in NodeRenderingContext.
https://bugs.webkit.org/show_bug.cgi?id=79180

Reviewed by Hajime Morita.

Source/WebCore:

Currently we have handled AttachingFallback in some special mannger, however if firstRendererOf
and lastRendererOf return a fallback element renderer, we don't need to handle it in such a manner.

We have introduced new attaching phase: AttachingFallbacked, and AttachingNotFallbacked.
They are used for fallback elements.

Added new test cases in:

fast/dom/shadow/shadow-contents-fallback.html
fast/dom/shadow/shadow-contents-fallback-dynamic.html

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::firstRendererOf):
(WebCore::lastRendererOf):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):
(WebCore::NodeRenderingContext::shouldCreateRenderer):

  • dom/NodeRenderingContext.h:
  • html/shadow/InsertionPoint.h:

(WebCore::isInsertionPoint):
(WebCore):
(WebCore::toInsertionPoint):

LayoutTests:

Added new test cases, e.g. <content> in <content>, with display:none.

  • fast/dom/shadow/shadow-contents-fallback-dynamic-expected.txt:
  • fast/dom/shadow/shadow-contents-fallback-dynamic.html:
  • fast/dom/shadow/shadow-contents-fallback-expected.txt:
  • fast/dom/shadow/shadow-contents-fallback.html:
03:46 Changeset [108479] by zeno.albisser@nokia.com

[Qt][WK2][Mac] WebKitTestRunner does not build with clang.
https://bugs.webkit.org/show_bug.cgi?id=79124

WebKitTestRunnerPrefix.h should also be included
when building with clang.

Reviewed by Kenneth Rohde Christiansen.

  • WebKitTestRunner/Target.pri:
03:38 Changeset [108478] by ossy@webkit.org

[Qt] Unreviewed gardening after r108464.

  • Target.pri:
03:21 Changeset [108477] by haraken@chromium.org

Add performance tests for the Element.id getter and setter
https://bugs.webkit.org/show_bug.cgi?id=79209

Reviewed by Adam Barth.

This patch adds performance tests for the Element.id getter and setter.

The results of 10 runs in my local Chromium/Linux are as follows:

dom_attributes_id_getter.html:
median= 92.0 ms, stdev= 1.65151445649 ms, min= 89.0 ms, max= 96.0 ms
median= 87.5 ms, stdev= 1.84390889146 ms, min= 85.0 ms, max= 92.0 ms
median= 94.0 ms, stdev= 1.46543508898 ms, min= 90.0 ms, max= 95.0 ms
median= 86.0 ms, stdev= 1.66958078571 ms, min= 84.0 ms, max= 91.0 ms
median= 94.0 ms, stdev= 2.25610283454 ms, min= 103.0 ms, max= 98.0 ms
median= 86.0 ms, stdev= 1.49666295471 ms, min= 84.0 ms, max= 91.0 ms
median= 86.0 ms, stdev= 1.5321553446 ms, min= 84.0 ms, max= 90.0 ms
median= 86.0 ms, stdev= 2.20227155455 ms, min= 84.0 ms, max= 94.0 ms
median= 96.0 ms, stdev= 1.74570902501 ms, min= 101.0 ms, max= 99.0 ms
median= 86.0 ms, stdev= 1.63935963108 ms, min= 84.0 ms, max= 90.0 ms
median= 94.0 ms, stdev= 1.49248115566 ms, min= 90.0 ms, max= 95.0 ms
median= 88.0 ms, stdev= 5.20192272146 ms, min= 84.0 ms, max= 98.0 ms
median= 86.0 ms, stdev= 1.41067359797 ms, min= 84.0 ms, max= 89.0 ms
median= 86.0 ms, stdev= 1.48660687473 ms, min= 84.0 ms, max= 89.0 ms
median= 94.0 ms, stdev= 1.58113883008 ms, min= 93.0 ms, max= 97.0 ms
median= 86.0 ms, stdev= 1.95959179423 ms, min= 84.0 ms, max= 93.0 ms
median= 86.0 ms, stdev= 1.8547236991 ms, min= 84.0 ms, max= 92.0 ms
median= 86.0 ms, stdev= 1.39283882772 ms, min= 84.0 ms, max= 89.0 ms
median= 88.0 ms, stdev= 1.48660687473 ms, min= 85.0 ms, max= 90.0 ms
median= 86.5 ms, stdev= 2.3 ms, min= 84.0 ms, max= 93.0 ms

dom_attributes_id_setter.html:
median= 123.0 ms, stdev= 2.06397674406 ms, min= 119.0 ms, max= 128.0 ms
median= 119.0 ms, stdev= 1.92028643697 ms, min= 117.0 ms, max= 123.0 ms
median= 121.0 ms, stdev= 1.8781639971 ms, min= 118.0 ms, max= 123.0 ms
median= 123.0 ms, stdev= 2.21585198062 ms, min= 119.0 ms, max= 130.0 ms
median= 124.5 ms, stdev= 2.36378933071 ms, min= 119.0 ms, max= 129.0 ms
median= 122.0 ms, stdev= 2.4474476501 ms, min= 118.0 ms, max= 128.0 ms
median= 123.0 ms, stdev= 1.76351920885 ms, min= 118.0 ms, max= 125.0 ms
median= 119.0 ms, stdev= 1.79652442232 ms, min= 117.0 ms, max= 125.0 ms
median= 121.0 ms, stdev= 1.49916643506 ms, min= 119.0 ms, max= 123.0 ms
median= 119.5 ms, stdev= 1.85135085816 ms, min= 117.0 ms, max= 125.0 ms
median= 124.0 ms, stdev= 1.43090880213 ms, min= 120.0 ms, max= 124.0 ms
median= 122.0 ms, stdev= 1.45859521458 ms, min= 118.0 ms, max= 123.0 ms
median= 123.0 ms, stdev= 1.50332963784 ms, min= 120.0 ms, max= 124.0 ms
median= 123.0 ms, stdev= 1.3638181697 ms, min= 120.0 ms, max= 125.0 ms
median= 119.0 ms, stdev= 1.43527000944 ms, min= 117.0 ms, max= 121.0 ms
median= 122.5 ms, stdev= 1.71682847134 ms, min= 118.0 ms, max= 124.0 ms
median= 121.0 ms, stdev= 1.44481832768 ms, min= 118.0 ms, max= 123.0 ms
median= 120.0 ms, stdev= 1.40978721799 ms, min= 117.0 ms, max= 122.0 ms
median= 122.0 ms, stdev= 1.68522995464 ms, min= 119.0 ms, max= 125.0 ms
median= 122.0 ms, stdev= 1.55804364509 ms, min= 118.0 ms, max= 123.0 ms

  • Bindings/dom_attributes_id_getter.html: Added.
  • Bindings/dom_attributes_id_setter.html: Added.
  • Bindings/resources/dom_attributes_common.js: Added.
03:20 Changeset [108476] by bashi@chromium.org

Unreviewed, rolling out r108468.
http://trac.webkit.org/changeset/108468
https://bugs.webkit.org/show_bug.cgi?id=79219

Broke Chromium Win release build (Requested by bashi on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-22

Source/JavaScriptCore:

  • wtf/Platform.h:

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • websockets/WebSocket.cpp:

(WebCore::WebSocket::didConnect):

  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::connect):
(WebCore::WebSocketChannel::fail):
(WebCore::WebSocketChannel::processFrame):
(WebCore::WebSocketChannel::sendFrame):

  • websockets/WebSocketChannel.h:
  • websockets/WebSocketDeflateFramer.cpp: Removed.
  • websockets/WebSocketDeflateFramer.h: Removed.

LayoutTests:

  • http/tests/websocket/tests/hybi/compressed-control-frame-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/compressed-control-frame.html: Removed.
  • http/tests/websocket/tests/hybi/compressed-control-frame_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff.html: Removed.
  • http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter.html: Removed.
  • http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/deflate-frame-parameter-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/deflate-frame-parameter.html: Removed.
  • http/tests/websocket/tests/hybi/deflate-frame_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header-expected.txt:
  • http/tests/websocket/tests/hybi/send-file-blob_wsh.py:

(web_socket_transfer_data):

03:05 Changeset [108475] by philn@webkit.org

Unreviewed, GTK gardening, unskip 2 tests that should pass now.

  • platform/gtk/Skipped:
02:45 Changeset [108474] by rolandsteiner@chromium.org

<style scoped>: Add runtime-flag
https://bugs.webkit.org/show_bug.cgi?id=79074

Source/WebCore:

Added runtime-flag.
Query runtime flag when (un)registering a <style scoped> element, and when determineing a style sheet's scope.

Reviewed by Dimitri Glazkov.

No new tests. (no change in functionality)

  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::styleScopedEnabled):
(WebCore::RuntimeEnabledFeatures::setStyleScopedEnabled):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::determineScopingElement):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::registerWithScopingNode):
(WebCore::HTMLStyleElement::unregisterWithScopingNode):

  • html/HTMLStyleElement.idl:

Source/WebKit/chromium:

Added a runtime-flag.
Enable default STYLE_SCOPED compile-time flag for Chromium.

Reviewed by Dimitri Glazkov.

  • features.gypi: enable STYLE_SCOPED
  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableStyleScoped):
(WebKit):
(WebKit::WebRuntimeFeatures::isStyleScopedEnabled):

Tools:

Enable the runtime-flag for DRT.

Reviewed by Dimitri Glazkov.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

02:42 Changeset [108473] by apavlov@chromium.org

Web Inspector: Audit rules to recommend unprefixing supported CSS properties
https://bugs.webkit.org/show_bug.cgi?id=78985

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/AuditCategories.js:

(WebInspector.AuditCategories.PagePerformance.prototype.initialize):

  • inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.CSSRuleBase):
(WebInspector.AuditRules.CSSRuleBase.prototype.doRun.sheetsCallback):
(WebInspector.AuditRules.CSSRuleBase.prototype.doRun):
(WebInspector.AuditRules.CSSRuleBase.prototype._visitStyleSheet.sheetCallback):
(WebInspector.AuditRules.CSSRuleBase.prototype._visitStyleSheet):
(WebInspector.AuditRules.CSSRuleBase.prototype._visitRule):
(WebInspector.AuditRules.CSSRuleBase.prototype.visitStyleSheet):
(WebInspector.AuditRules.CSSRuleBase.prototype.didVisitStyleSheet):
(WebInspector.AuditRules.CSSRuleBase.prototype.visitRule):
(WebInspector.AuditRules.CSSRuleBase.prototype.didVisitRule):
(WebInspector.AuditRules.CSSRuleBase.prototype.visitProperty):
(WebInspector.AuditRules.VendorPrefixedCSSProperties):
(WebInspector.AuditRules.VendorPrefixedCSSProperties.prototype.didVisitStyleSheet):
(WebInspector.AuditRules.VendorPrefixedCSSProperties.prototype.visitRule):
(WebInspector.AuditRules.VendorPrefixedCSSProperties.prototype.didVisitRule):
(WebInspector.AuditRules.VendorPrefixedCSSProperties.prototype.visitProperty):

  • inspector/front-end/ResourceUtils.js:

LayoutTests:

  • inspector/audits/audits-panel-functional-expected.txt:
  • inspector/audits/audits-panel-functional.html:
02:20 Changeset [108472] by pfeldman@chromium.org

Merge 106347 - Web Inspector: DOMDebugger.setEventListenerBreakpoint should accept regular DOM event names.
https://bugs.webkit.org/show_bug.cgi?id=77409

(Fixing merge 2)

Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::setEventListenerBreakpoint):
(WebCore):
(WebCore::InspectorDOMDebuggerAgent::setInstrumentationBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::setBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeEventListenerBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeInstrumentationBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):

  • inspector/InspectorDOMDebuggerAgent.h:

(InspectorDOMDebuggerAgent):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didInstallTimerImpl):
(WebCore::InspectorInstrumentation::didRemoveTimerImpl):
(WebCore::InspectorInstrumentation::willHandleEventImpl):
(WebCore::InspectorInstrumentation::willFireTimerImpl):
(WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):

  • inspector/front-end/BreakpointsSidebarPane.js:

(WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint):

TBR=pfeldman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9429046

02:17 Changeset [108471] by commit-queue@webkit.org

[Qt][WK2] Add frame flattening setting to QWebPreferences.
https://bugs.webkit.org/show_bug.cgi?id=79099

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-02-22
Reviewed by Simon Hausmann.

Frame flattening is enabled by default for Qt WebKit2.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize):

  • UIProcess/API/qt/qwebpreferences.cpp:

(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferences::setNavigatorQtObjectEnabled):
(QWebPreferences::frameFlatteningEnabled):
(QWebPreferences::setFrameFlatteningEnabled):

  • UIProcess/API/qt/qwebpreferences_p.h:
02:12 Changeset [108470] by shinyak@chromium.org

Node::attach() should be after attaching children in Element::attach().
https://bugs.webkit.org/show_bug.cgi?id=79201

Reviewed by Hajime Morita.

In Element::attach(), Node::attach() is called before attaching children if a shaodw root exists.
This may cause O(N2) problem in NodeRenderingContext.

No new tests. Existing tests should cover this.

  • dom/Element.cpp:

(WebCore::Element::attach):

02:04 Changeset [108469] by pfeldman@chromium.org

Merge 106347 - Web Inspector: DOMDebugger.setEventListenerBreakpoint should accept regular DOM event names.
https://bugs.webkit.org/show_bug.cgi?id=77409

Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::setEventListenerBreakpoint):
(WebCore):
(WebCore::InspectorDOMDebuggerAgent::setInstrumentationBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::setBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeEventListenerBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeInstrumentationBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):

  • inspector/InspectorDOMDebuggerAgent.h:

(InspectorDOMDebuggerAgent):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didInstallTimerImpl):
(WebCore::InspectorInstrumentation::didRemoveTimerImpl):
(WebCore::InspectorInstrumentation::willHandleEventImpl):
(WebCore::InspectorInstrumentation::willFireTimerImpl):
(WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):

  • inspector/front-end/BreakpointsSidebarPane.js:

(WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint):

TBR=pfeldman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9429045

02:03 Changeset [108468] by bashi@chromium.org

Adding WebSocket per-frame DEFLATE extension
https://bugs.webkit.org/show_bug.cgi?id=77522

Source/JavaScriptCore:

Added USE(ZLIB) flag.

Reviewed by Kent Tamura.

  • wtf/Platform.h:

Source/WebCore:

Add WebSocketDeflateFramer class which handles deflate-frame extension.
This class encapsulates WebSocketDeflater and WebSocketInflater classes,
which depend on zlib, so that WebSocketChannel is not necessary to aware
zlib dependency.

Reviewed by Kent Tamura.

Tests: http/tests/websocket/tests/hybi/compressed-control-frame.html

http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff.html
http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter.html
http/tests/websocket/tests/hybi/deflate-frame-parameter.html

  • CMakeLists.txt: Added WebSocketDeflateFramer.(cpp|h)
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • websockets/WebSocket.cpp:

(WebCore::WebSocket::didConnect): Set m_extensions.

  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::connect): Add deflate-frame extension processor to WebSocketHanshake if deflate can use.
(WebCore::WebSocketChannel::fail): Call m_deflateFramer.didFail().
(WebCore::WebSocketChannel::processFrame): Decompress frames if needed.
(WebCore::WebSocketChannel::sendFrame): Compress frames if possible.

  • websockets/WebSocketChannel.h:
  • websockets/WebSocketDeflateFramer.cpp: Added.

(WebCore):
(WebSocketExtensionDeflateFrame):
(WebCore::WebSocketExtensionDeflateFrame::create):
(WebCore::WebSocketExtensionDeflateFrame::~WebSocketExtensionDeflateFrame):
(WebCore::WebSocketExtensionDeflateFrame::WebSocketExtensionDeflateFrame):
(WebCore::WebSocketExtensionDeflateFrame::handshakeString):
(WebCore::WebSocketExtensionDeflateFrame::processResponse):
(WebCore::DeflateResultHolder::DeflateResultHolder):
(WebCore::DeflateResultHolder::~DeflateResultHolder):
(WebCore::DeflateResultHolder::fail):
(WebCore::InflateResultHolder::InflateResultHolder):
(WebCore::InflateResultHolder::~InflateResultHolder):
(WebCore::InflateResultHolder::fail):
(WebCore::WebSocketDeflateFramer::WebSocketDeflateFramer):
(WebCore::WebSocketDeflateFramer::createExtensionProcessor):
(WebCore::WebSocketDeflateFramer::canDeflate):
(WebCore::WebSocketDeflateFramer::enableDeflate):
(WebCore::WebSocketDeflateFramer::deflate):
(WebCore::WebSocketDeflateFramer::resetDeflateContext):
(WebCore::WebSocketDeflateFramer::inflate):
(WebCore::WebSocketDeflateFramer::resetInflateContext):
(WebCore::WebSocketDeflateFramer::didFail):

  • websockets/WebSocketDeflateFramer.h: Added.

(WebCore):
(DeflateResultHolder):
(WebCore::DeflateResultHolder::succeeded):
(WebCore::DeflateResultHolder::failureReason):
(InflateResultHolder):
(WebCore::InflateResultHolder::succeeded):
(WebCore::InflateResultHolder::failureReason):
(WebSocketDeflateFramer):
(WebCore::WebSocketDeflateFramer::enabled):

LayoutTests:

Added tests for WebSocket deflate-frame extension. Also updated some
tests to follow the change.

Reviewed by Kent Tamura.

  • http/tests/websocket/tests/hybi/compressed-control-frame-expected.txt: Added.
  • http/tests/websocket/tests/hybi/compressed-control-frame.html: Added.
  • http/tests/websocket/tests/hybi/compressed-control-frame_wsh.py: Added.

(web_socket_do_extra_handshake):
(web_socket_transfer_data):

  • http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff-expected.txt: Added.
  • http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff.html: Added.
  • http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter-expected.txt: Added.
  • http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter.html: Added.
  • http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter_wsh.py: Added.

(web_socket_do_extra_handshake):
(web_socket_transfer_data):

  • http/tests/websocket/tests/hybi/deflate-frame-parameter-expected.txt: Added.
  • http/tests/websocket/tests/hybi/deflate-frame-parameter.html: Added.
  • http/tests/websocket/tests/hybi/deflate-frame_wsh.py: Added.

(_get_deflate_frame_extension_processor):
(web_socket_do_extra_handshake):
(web_socket_transfer_data):

  • http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header-expected.txt:
  • http/tests/websocket/tests/hybi/send-file-blob_wsh.py:

(_retrieve_frame):
(web_socket_transfer_data):

02:00 Changeset [108467] by yutak@chromium.org

Unreviewed, rolling out r108453.
http://trac.webkit.org/changeset/108453
https://bugs.webkit.org/show_bug.cgi?id=78549

Broke Chromium's webkit_unit_tests.

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp: Removed.
  • platform/graphics/chromium/cc/CCOcclusionTracker.h: Removed.

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCLayerTreeHostCommonTest.cpp:

(WebCore::TEST):
(WebCore):

  • tests/CCOcclusionTrackerTest.cpp: Removed.
01:56 Changeset [108466] by zherczeg@webkit.org

[Qt] clipToImageBuffer assertion fix in debug mode on Qt.

Rubber stamped by Csaba Osztrogonác.

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::restorePlatformState):

01:45 Changeset [108465] by abarth@webkit.org

[GTK] fast/frames/frame-dead-region.html crash
https://bugs.webkit.org/show_bug.cgi?id=79205

Unreviewed.

Apparently we're not supposed to call willDetachPage from
CachedFrame::destroy. This call got added in
http://trac.webkit.org/changeset/108428, but it seems to cause a crash.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::closeAndRemoveChild):
(WebCore::FrameLoader::detachFromParent):

  • page/Frame.h:

(WebCore::Frame::detachFromPage):

  • page/Page.cpp:

(WebCore::Page::~Page):

01:40 Changeset [108464] by abarth@webkit.org

Move Geolocation code into Modules/geolocation
https://bugs.webkit.org/show_bug.cgi?id=79204

Reviewed by Hajime Morita.

There are still some dangling references into the Geolocation module,
which I will clean up in a followup patch.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Modules/geolocation/Geolocation.cpp: Copied from Source/WebCore/page/Geolocation.cpp.
  • Modules/geolocation/Geolocation.h: Copied from Source/WebCore/page/Geolocation.h.
  • Modules/geolocation/Geolocation.idl: Copied from Source/WebCore/page/Geolocation.idl.
  • Modules/geolocation/GeolocationController.cpp: Copied from Source/WebCore/page/GeolocationController.cpp.
  • Modules/geolocation/GeolocationController.h: Copied from Source/WebCore/page/GeolocationController.h.
  • Modules/geolocation/GeolocationError.h: Copied from Source/WebCore/page/GeolocationError.h.
  • Modules/geolocation/GeolocationPosition.h: Copied from Source/WebCore/page/GeolocationPosition.h.
  • Modules/geolocation/Geoposition.h: Copied from Source/WebCore/page/Geoposition.h.
  • Modules/geolocation/Geoposition.idl: Copied from Source/WebCore/page/Geoposition.idl.
  • Modules/geolocation/PositionCallback.h: Copied from Source/WebCore/page/PositionCallback.h.
  • Modules/geolocation/PositionCallback.idl: Copied from Source/WebCore/page/PositionCallback.idl.
  • Modules/geolocation/PositionError.h: Copied from Source/WebCore/page/PositionError.h.
  • Modules/geolocation/PositionError.idl: Copied from Source/WebCore/page/PositionError.idl.
  • Modules/geolocation/PositionErrorCallback.h: Copied from Source/WebCore/page/PositionErrorCallback.h.
  • Modules/geolocation/PositionErrorCallback.idl: Copied from Source/WebCore/page/PositionErrorCallback.idl.
  • Modules/geolocation/PositionOptions.h: Copied from Source/WebCore/page/PositionOptions.h.
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/Geolocation.cpp: Removed.
  • page/Geolocation.h: Removed.
  • page/Geolocation.idl: Removed.
  • page/GeolocationController.cpp: Removed.
  • page/GeolocationController.h: Removed.
  • page/GeolocationError.h: Removed.
  • page/GeolocationPosition.h: Removed.
  • page/Geoposition.h: Removed.
  • page/Geoposition.idl: Removed.
  • page/PositionCallback.h: Removed.
  • page/PositionCallback.idl: Removed.
  • page/PositionError.h: Removed.
  • page/PositionError.idl: Removed.
  • page/PositionErrorCallback.h: Removed.
  • page/PositionErrorCallback.idl: Removed.
  • page/PositionOptions.h: Removed.
01:28 Changeset [108463] by commit-queue@webkit.org

[gtk] Accessibility: use find funtion in vector instead of for.
https://bugs.webkit.org/show_bug.cgi?id=77878

Patch by Frederik Gladhorn <frederik.gladhorn@nokia.com> on 2012-02-22
Reviewed by Hajime Morita.

Minor cleanup, use the find function from vector.

  • accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetIndexInParent):

01:14 Changeset [108462] by rniwa@webkit.org

Remove the remaining uses of CSSStyleDeclaration in Editor
https://bugs.webkit.org/show_bug.cgi?id=78939

Reviewed by Enrica Casucci.

Source/WebCore:

Changed the argument types of shouldApplyStyle, applyParagraphStyle, applyStyleToSelection,
applyParagraphStyleToSelection, and computeAndSetTypingStyle in Editor from CSSStyleDeclaration
to StylePropertySet.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • editing/Editor.cpp:

(WebCore::Editor::applyStyle):
(WebCore::Editor::shouldApplyStyle):
(WebCore::Editor::applyParagraphStyle):
(WebCore::Editor::applyStyleToSelection):
(WebCore::Editor::applyParagraphStyleToSelection):
(WebCore::Editor::setBaseWritingDirection):
(WebCore::Editor::computeAndSetTypingStyle):

  • editing/Editor.h:

(WebCore):
(Editor):

  • editing/EditorCommand.cpp:

(WebCore::applyCommandToFrame):
(WebCore::executeApplyParagraphStyle):
(WebCore::executeMakeTextWritingDirectionLeftToRight):
(WebCore::executeMakeTextWritingDirectionNatural):
(WebCore::executeMakeTextWritingDirectionRightToLeft):

  • loader/EmptyClients.h:

(WebCore::EmptyEditorClient::shouldApplyStyle):

  • page/DragController.cpp:

(WebCore::DragController::concludeEditDrag):

  • page/EditorClient.h:

(WebCore):
(EditorClient):

Source/WebKit/blackberry:

  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::shouldApplyStyle):

  • WebCoreSupport/EditorClientBlackBerry.h:

(EditorClientBlackBerry):

Source/WebKit/chromium:

  • src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::shouldApplyStyle):

  • src/EditorClientImpl.h:

(EditorClientImpl):

Source/WebKit/efl:

  • WebCoreSupport/EditorClientEfl.cpp:

(WebCore::EditorClientEfl::shouldApplyStyle):

  • WebCoreSupport/EditorClientEfl.h:

(EditorClientEfl):

Source/WebKit/gtk:

  • WebCoreSupport/EditorClientGtk.cpp:

(WebKit::EditorClient::shouldApplyStyle):

  • WebCoreSupport/EditorClientGtk.h:

(EditorClient):

Source/WebKit/mac:

  • WebCoreSupport/WebEditorClient.h:

(WebEditorClient):

  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::shouldApplyStyle):

  • WebView/WebFrame.mm:

(-[WebFrame _setTypingStyle:withUndoAction:]):

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
(-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):

  • WebView/WebView.mm:

(-[WebView applyStyle:]):

Source/WebKit/qt:

  • WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::shouldApplyStyle):

  • WebCoreSupport/EditorClientQt.h:

(EditorClientQt):

Source/WebKit/win:

  • WebCoreSupport/WebEditorClient.cpp:

(WebEditorClient::shouldApplyStyle):

  • WebCoreSupport/WebEditorClient.h:

(WebEditorClient):

Source/WebKit/wince:

  • WebCoreSupport/EditorClientWinCE.cpp:

(WebKit::EditorClientWinCE::shouldApplyStyle):

Source/WebKit/wx:

  • WebKitSupport/EditorClientWx.cpp:

(WebCore::EditorClientWx::shouldApplyStyle):

  • WebKitSupport/EditorClientWx.h:

(EditorClientWx):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::shouldApplyStyle):

  • WebProcess/WebCoreSupport/WebEditorClient.h:

(WebEditorClient):

01:04 Changeset [108461] by pfeldman@chromium.org

Merge 106352 - Web Inspector: boost protocol version to 1.0
https://bugs.webkit.org/show_bug.cgi?id=77408

Reviewed by Yury Semikhatsky.

  • inspector/Inspector-1.0.json: Copied from Source/WebCore/inspector/Inspector.json.
  • inspector/Inspector.json:

TBR=pfeldman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9430040

01:03 Changeset [108460] by commit-queue@webkit.org

[GTK] fast/mediastream/peerconnection-argument-types.html fails
https://bugs.webkit.org/show_bug.cgi?id=79096

Patch by Yanbin Zhang <yanbin.zhang@intel.com> on 2012-02-22
Reviewed by Adam Barth.

  • fast/mediastream/peerconnection-argument-types-expected.txt:
  • fast/mediastream/script-tests/argument-types.js:
00:55 Changeset [108459] by carlosgc@webkit.org

Unreviewed, rolling out r107351.
http://trac.webkit.org/changeset/107351
https://bugs.webkit.org/show_bug.cgi?id=53600

Several issues introduced in WebKitGTK+ API

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::ChromeClient):
(WebKit::ChromeClient::chromeDestroyed):
(WebKit::ChromeClient::canRunModal):
(WebKit::ChromeClient::runModal):

  • WebCoreSupport/ChromeClientGtk.h:

(ChromeClient):

  • webkit/webkitwebview.cpp:

(webkit_web_view_class_init):

Tools:

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(createWebView):

  • GtkLauncher/main.c:

(createWebViewCb):
(createBrowser):
(createWindow):
(main):

LayoutTests:

  • platform/gtk/Skipped:
00:54 Changeset [108458] by commit-queue@webkit.org

[chromium] Cull quads outside of the scissoring damage rect
https://bugs.webkit.org/show_bug.cgi?id=79181

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-22
Reviewed by James Robinson.

Source/WebCore:

Quads outside of the partial swap cause us to execute GL operations
that actually use a fair amount of CPU time (enough to affect power
usage). Here we cull quads by only keeping their intersection
with the damage rect used for partial swap.

Unit test: CCQuadCuller.cpp

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::optimizeRenderPasses):

  • platform/graphics/chromium/cc/CCQuadCuller.cpp:

(WebCore::CCQuadCuller::cullOccludedQuads):

  • platform/graphics/chromium/cc/CCQuadCuller.h:

(CCQuadCuller):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::optimizeQuads):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(CCRenderPass):

Source/WebKit/chromium:

  • tests/CCQuadCullerTest.cpp:

(WebCore::TEST):
(WebCore):

00:49 Changeset [108457] by pfeldman@chromium.org

Merge 106347 - Web Inspector: DOMDebugger.setEventListenerBreakpoint should accept regular DOM event names.
https://bugs.webkit.org/show_bug.cgi?id=77409

Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::setEventListenerBreakpoint):
(WebCore):
(WebCore::InspectorDOMDebuggerAgent::setInstrumentationBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::setBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeEventListenerBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeInstrumentationBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):

  • inspector/InspectorDOMDebuggerAgent.h:

(InspectorDOMDebuggerAgent):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didInstallTimerImpl):
(WebCore::InspectorInstrumentation::didRemoveTimerImpl):
(WebCore::InspectorInstrumentation::willHandleEventImpl):
(WebCore::InspectorInstrumentation::willFireTimerImpl):
(WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):

  • inspector/front-end/BreakpointsSidebarPane.js:

(WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint):

TBR=pfeldman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9429043

00:43 Changeset [108456] by commit-queue@webkit.org

Short circuit fixed for a 16 bt pattern character and an 8 bit string.
https://bugs.webkit.org/show_bug.cgi?id=75602

Patch by Hojong Han <hojong.han@samsung.com> on 2012-02-22
Reviewed by Gavin Barraclough.

  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::backtrackPatternCharacterGreedy):

00:37 Changeset [108455] by philn@webkit.org

Unreviewed, GTK gardening.

  • platform/gtk/Skipped:
  • platform/gtk/fast/forms/float-before-fieldset-expected.txt:
00:30 Changeset [108454] by jonlee@apple.com

Part of r108409 was incorrect, and incorporated an older version of a sub-patch.
This is the actual sub-patch that should have been submitted.

  • WebCoreSupport/WebNotificationClient.h:
  • WebCoreSupport/WebNotificationClient.mm:

(WebNotificationClient::show):
(WebNotificationClient::cancel):
(WebNotificationClient::clearNotifications):
(WebNotificationClient::notificationObjectDestroyed):
(WebNotificationClient::notificationControllerDestroyed):

00:27 WebKitEFLLayoutTest edited by gyuyoung.kim@samsung.com
(diff)
00:26 WebKitEFLLayoutTest edited by gyuyoung.kim@samsung.com
(diff)
00:25 WebKitEFLLayoutTest edited by gyuyoung.kim@samsung.com
(diff)
00:24 WebKitEFLLayoutTest edited by gyuyoung.kim@samsung.com
(diff)
00:20 EFLWebKit edited by gyuyoung.kim@samsung.com
Add dependent package (diff)

02/21/12:

23:59 Changeset [108453] by commit-queue@webkit.org

[Chromium] New CCOcclusionTracker class with tests
https://bugs.webkit.org/show_bug.cgi?id=78549

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-21
Reviewed by James Robinson.

Source/WebCore:

Adds a CCOcclusionTrackerBase template class that is able to track occlusion
of layers while traversing the layer tree from front-to-back, with typedefed
versions for the main and impl threads.

At each step of the front-to-back traversal, the class should be notified of
changes to the current render target, and when done working with a layer, the
layer is added the tracked occlusion.

The class provides tests for checking if a rect in content space
for a layer/surface is occluded by others in front of it.

Unit tests: CCOcclusionTrackerTest.cpp

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp: Added.

(WebCore):
(WebCore::::enterTargetRenderSurface):
(WebCore::::finishedTargetRenderSurface):
(WebCore::transformSurfaceOpaqueRegion):
(WebCore::::leaveToTargetRenderSurface):
(WebCore::contentToScreenSpaceTransform):
(WebCore::contentToTargetSurfaceTransform):
(WebCore::computeOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):
(WebCore::testContentRectOccluded):
(WebCore::::occluded):
(WebCore::::surfaceOccluded):
(WebCore::rectSubtractRegion):
(WebCore::computeUnoccludedContentRect):
(WebCore::::unoccludedContentRect):
(WebCore::::surfaceUnoccludedContentRect):
(WebCore::::currentOcclusionInScreenSpace):
(WebCore::::currentOcclusionInTargetSurface):

  • platform/graphics/chromium/cc/CCOcclusionTracker.h: Added.

(WebCore):
(CCOcclusionTrackerBase):
(WebCore::CCOcclusionTrackerBase::CCOcclusionTrackerBase):
(StackObject):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCLayerTreeHostCommonTest.cpp:

(WebCore):

  • tests/CCOcclusionTrackerTest.cpp: Added.

(WebCore):
(WebCore::setLayerPropertiesForTesting):
(LayerChromiumWithForcedDrawsContent):
(WebCore::LayerChromiumWithForcedDrawsContent::LayerChromiumWithForcedDrawsContent):
(WebCore::LayerChromiumWithForcedDrawsContent::drawsContent):
(TestCCOcclusionTracker):
(WebCore::TestCCOcclusionTracker::occlusionInScreenSpace):
(WebCore::TestCCOcclusionTracker::occlusionInTargetSurface):
(WebCore::TestCCOcclusionTracker::setOcclusionInScreenSpace):
(WebCore::TestCCOcclusionTracker::setOcclusionInTargetSurface):
(WebCore::TEST):

23:37 Changeset [108452] by carlosgc@webkit.org

[GTK] Null ResourceErrors are encoded/decoded as empty ResourceErrors
https://bugs.webkit.org/show_bug.cgi?id=79120

Reviewed by Martin Robinson.

  • Shared/gtk/WebCoreArgumentCodersGtk.cpp:

(CoreIPC::::encode): Encode a boolean to indicate whether it's a
Null error.
(CoreIPC::::decode): Check whether the error is Null and do not
continue decoding in such case.

23:33 Changeset [108451] by kling@webkit.org

Cache <font face> family lists in CSSValuePool.
<http://webkit.org/b/79195>

Reviewed by Antti Koivisto.

HTMLFontElements with "face" attributes are very common in legacy web content.
Add a String->CSSValue cache for these in CSSValuePool and use it to avoid
reparsing and recreating duplicate font face values.

This knocks 20ms (~1.5%) worth of samples off of the Moz page cycler on my system.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFontFaceValue):

  • css/CSSParser.h:
  • css/CSSValuePool.cpp:

(WebCore::CSSValuePool::createFontFaceValue):

  • css/CSSValuePool.h:
  • html/HTMLFontElement.cpp:

(WebCore::HTMLFontElement::collectStyleForAttribute):

23:28 Changeset [108450] by abarth@webkit.org

Separate the implementation of registerProtocolHandler from Navigator.cpp
https://bugs.webkit.org/show_bug.cgi?id=78945

Reviewed by Eric Seidel.

The implementation of registerProtocolHandler needlessly complicates
the implementation of Navigator.cpp. In principle,
registerProtocolHandler (and possibly registerContentHandler, when we
implement that feature) could be its own module, but that seems like
overkill for one or two files.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/Navigator.cpp:

(WebCore):

  • page/Navigator.h:

(Navigator):

  • page/Navigator.idl:
23:20 Changeset [108449] by morrita@google.com

HasIDFlag and HasClassFlag can be removed.
https://bugs.webkit.org/show_bug.cgi?id=77861

Reviewed by Andreas Kling.

Replaced HasIDFlag and HasClassFlag with a check against
ElementAttributeData. It looks these flags (originally bitfields)
were legacy of ancient era, where we didn't cache @id and @class
values and needed a hash lookup for each check.

No new tests. No behavioral change.

  • dom/Element.cpp:

(WebCore::Element::idAttributeChanged):

  • dom/Element.h:

(WebCore::Element::hasID):
(WebCore):
(WebCore::Element::hasClass):
(WebCore::Node::hasID):
(WebCore::Node::hasClass):

  • dom/ElementAttributeData.h:

(WebCore::ElementAttributeData::hasID):
(WebCore::ElementAttributeData::hasClass):
(ElementAttributeData):

  • dom/Node.h:

(Node):
(WebCore::nodeStyleChangeShift):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::classAttributeChanged):

23:15 Changeset [108448] by fpizlo@apple.com

Build fix for systems with case sensitive disks.

  • llint/LLIntOfflineAsmConfig.h:
22:29 Changeset [108447] by mdelaney@apple.com

2D Canvas setTransform makes unnecessary matrix mults
https://bugs.webkit.org/show_bug.cgi?id=79190

Reviewed by Dan Bernstein.

No new tests - plenty of current tests using setTransform.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setTransform):

21:46 Changeset [108446] by morrita@google.com

INPUT_SPEECH should be implemented as a PageSupplement.
https://bugs.webkit.org/show_bug.cgi?id=79051

Source/WebCore:

Turned SpeechInput to a PageSupplement.

Reviewed by Adam Barth.

No new tests. No behavior change.

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::InputFieldSpeechButtonElement::speechInput):
(WebCore::InputFieldSpeechButtonElement::attach):

  • page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::PageClients::PageClients):

  • page/Page.h:

(WebCore):
(PageClients):
(Page):

  • page/SpeechInput.cpp:

(WebCore::SpeechInput::supplementName):
(WebCore):
(WebCore::provideSpeechInputTo):

  • page/SpeechInput.h:

(SpeechInput):
(WebCore::SpeechInput::from):

  • page/SpeechInputClient.h:

(WebCore):

Source/WebKit/chromium:

Reviewed by Adam Barth.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

21:29 Changeset [108445] by commit-queue@webkit.org

[chromium] Add three small zoom gesture features
https://bugs.webkit.org/show_bug.cgi?id=74216

Patch by Alexandre Elias <aelias@google.com> on 2012-02-21
Reviewed by James Robinson.

  1. Support panning around with two fingers.
  2. When double-tap zooming, issue the commit at final/scroll scale as

early as possible.

  1. When pinch zooming out, issue a commit at minimum scale to avoid

showing checkerboard.

Added test for panning to CCLayerTreeHostImplTest::pinchGesture.
(The other features are heuristics whose exact behavior we don't need
to lock in with a test.)

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::startPageScaleAnimation):
(WebCore::CCLayerTreeHostImpl::pinchGestureBegin):
(WebCore::CCLayerTreeHostImpl::pinchGestureUpdate):
(WebCore::CCLayerTreeHostImpl::computeDoubleTapZoomDeltas):
(WebCore::CCLayerTreeHostImpl::computePinchZoomDeltas):
(WebCore::CCLayerTreeHostImpl::makeScrollAndScaleSet):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
21:23 Changeset [108444] by fpizlo@apple.com

JSC should be a triple-tier VM
https://bugs.webkit.org/show_bug.cgi?id=75812
<rdar://problem/10079694>

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

Implemented an interpreter that uses the JIT's calling convention. This
interpreter is called LLInt, or the Low Level Interpreter. JSC will now
will start by executing code in LLInt and will only tier up to the old
JIT after the code is proven hot.

LLInt is written in a modified form of our macro assembly. This new macro
assembly is compiled by an offline assembler (see offlineasm), which
implements many modern conveniences such as a Turing-complete CPS-based
macro language and direct access to relevant C++ type information
(basically offsets of fields and sizes of structs/classes).

Code executing in LLInt appears to the rest of the JSC world "as if" it
were executing in the old JIT. Hence, things like exception handling and
cross-execution-engine calls just work and require pretty much no
additional overhead.

This interpreter is 2-2.5x faster than our old interpreter on SunSpider,
V8, and Kraken. With triple-tiering turned on, we're neutral on SunSpider,
V8, and Kraken, but appear to get a double-digit improvement on real-world
websites due to a huge reduction in the amount of JIT'ing.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
  • JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • assembler/LinkBuffer.h:
  • assembler/MacroAssemblerCodeRef.h:

(MacroAssemblerCodePtr):
(JSC::MacroAssemblerCodePtr::createFromExecutableAddress):

  • bytecode/BytecodeConventions.h: Added.
  • bytecode/CallLinkStatus.cpp:

(JSC::CallLinkStatus::computeFromLLInt):
(JSC):
(JSC::CallLinkStatus::computeFor):

  • bytecode/CallLinkStatus.h:

(JSC::CallLinkStatus::isSet):
(JSC::CallLinkStatus::operator!):
(CallLinkStatus):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC):
(JSC::CodeBlock::unlinkCalls):
(JSC::CodeBlock::unlinkIncomingCalls):
(JSC::CodeBlock::bytecodeOffset):
(JSC::ProgramCodeBlock::jettison):
(JSC::EvalCodeBlock::jettison):
(JSC::FunctionCodeBlock::jettison):
(JSC::ProgramCodeBlock::jitCompileImpl):
(JSC::EvalCodeBlock::jitCompileImpl):
(JSC::FunctionCodeBlock::jitCompileImpl):

  • bytecode/CodeBlock.h:

(JSC):
(CodeBlock):
(JSC::CodeBlock::baselineVersion):
(JSC::CodeBlock::linkIncomingCall):
(JSC::CodeBlock::bytecodeOffset):
(JSC::CodeBlock::jitCompile):
(JSC::CodeBlock::hasOptimizedReplacement):
(JSC::CodeBlock::addPropertyAccessInstruction):
(JSC::CodeBlock::addGlobalResolveInstruction):
(JSC::CodeBlock::addLLIntCallLinkInfo):
(JSC::CodeBlock::addGlobalResolveInfo):
(JSC::CodeBlock::numberOfMethodCallLinkInfos):
(JSC::CodeBlock::valueProfilePredictionForBytecodeOffset):
(JSC::CodeBlock::likelyToTakeSlowCase):
(JSC::CodeBlock::couldTakeSlowCase):
(JSC::CodeBlock::likelyToTakeSpecialFastCase):
(JSC::CodeBlock::likelyToTakeDeepestSlowCase):
(JSC::CodeBlock::likelyToTakeAnySlowCase):
(JSC::CodeBlock::addFrequentExitSite):
(JSC::CodeBlock::dontJITAnytimeSoon):
(JSC::CodeBlock::jitAfterWarmUp):
(JSC::CodeBlock::jitSoon):
(JSC::CodeBlock::llintExecuteCounter):
(ProgramCodeBlock):
(EvalCodeBlock):
(FunctionCodeBlock):

  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFromLLInt):
(JSC):
(JSC::GetByIdStatus::computeFor):

  • bytecode/GetByIdStatus.h:

(JSC::GetByIdStatus::GetByIdStatus):
(JSC::GetByIdStatus::wasSeenInJIT):
(GetByIdStatus):

  • bytecode/Instruction.h:

(JSC):
(JSC::Instruction::Instruction):
(Instruction):

  • bytecode/LLIntCallLinkInfo.h: Added.

(JSC):
(JSC::LLIntCallLinkInfo::LLIntCallLinkInfo):
(LLIntCallLinkInfo):
(JSC::LLIntCallLinkInfo::~LLIntCallLinkInfo):
(JSC::LLIntCallLinkInfo::isLinked):
(JSC::LLIntCallLinkInfo::unlink):

  • bytecode/MethodCallLinkStatus.cpp:

(JSC::MethodCallLinkStatus::computeFor):

  • bytecode/Opcode.cpp:

(JSC):

  • bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFromLLInt):
(JSC):
(JSC::PutByIdStatus::computeFor):

  • bytecode/PutByIdStatus.h:

(PutByIdStatus):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveWithBase):
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::emitPutById):
(JSC::BytecodeGenerator::emitDirectPutById):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):
(JSC::BytecodeGenerator::emitCatch):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOperations.cpp:
  • heap/Heap.h:

(JSC):
(JSC::Heap::firstAllocatorWithoutDestructors):
(Heap):

  • heap/MarkStack.cpp:

(JSC::visitChildren):

  • heap/MarkedAllocator.h:

(JSC):
(MarkedAllocator):

  • heap/MarkedSpace.h:

(JSC):
(MarkedSpace):
(JSC::MarkedSpace::firstAllocator):

  • interpreter/CallFrame.cpp:

(JSC):
(JSC::CallFrame::bytecodeOffsetForNonDFGCode):
(JSC::CallFrame::setBytecodeOffsetForNonDFGCode):
(JSC::CallFrame::currentVPC):
(JSC::CallFrame::setCurrentVPC):
(JSC::CallFrame::trueCallerFrame):

  • interpreter/CallFrame.h:

(JSC::ExecState::hasReturnPC):
(JSC::ExecState::clearReturnPC):
(ExecState):
(JSC::ExecState::bytecodeOffsetForNonDFGCode):
(JSC::ExecState::currentVPC):
(JSC::ExecState::setCurrentVPC):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::Interpreter):
(JSC::Interpreter::~Interpreter):
(JSC):
(JSC::Interpreter::initialize):
(JSC::Interpreter::isOpcode):
(JSC::Interpreter::unwindCallFrame):
(JSC::getCallerInfo):
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::retrieveLastCaller):

  • interpreter/Interpreter.h:

(JSC):
(Interpreter):
(JSC::Interpreter::getOpcode):
(JSC::Interpreter::getOpcodeID):
(JSC::Interpreter::classicEnabled):

  • interpreter/RegisterFile.h:

(JSC):
(RegisterFile):

  • jit/ExecutableAllocator.h:

(JSC):

  • jit/HostCallReturnValue.cpp: Added.

(JSC):
(JSC::getHostCallReturnValueWithExecState):

  • jit/HostCallReturnValue.h: Added.

(JSC):
(JSC::initializeHostCallReturnValue):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):

  • jit/JITCode.h:

(JSC::JITCode::isOptimizingJIT):
(JITCode):
(JSC::JITCode::isBaselineCode):
(JSC::JITCode::JITCode):

  • jit/JITDriver.h:

(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):

  • jit/JITExceptions.cpp:

(JSC::jitThrow):

  • jit/JITInlineMethods.h:

(JSC::JIT::updateTopCallFrame):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):
(JSC):

  • jit/JITStubs.h:

(JSC):

  • jit/JSInterfaceJIT.h:
  • llint: Added.
  • llint/LLIntCommon.h: Added.
  • llint/LLIntData.cpp: Added.

(LLInt):
(JSC::LLInt::Data::Data):
(JSC::LLInt::Data::performAssertions):
(JSC::LLInt::Data::~Data):

  • llint/LLIntData.h: Added.

(JSC):
(LLInt):
(Data):
(JSC::LLInt::Data::exceptionInstructions):
(JSC::LLInt::Data::opcodeMap):
(JSC::LLInt::Data::performAssertions):

  • llint/LLIntEntrypoints.cpp: Added.

(LLInt):
(JSC::LLInt::getFunctionEntrypoint):
(JSC::LLInt::getEvalEntrypoint):
(JSC::LLInt::getProgramEntrypoint):

  • llint/LLIntEntrypoints.h: Added.

(JSC):
(LLInt):
(JSC::LLInt::getEntrypoint):

  • llint/LLIntExceptions.cpp: Added.

(LLInt):
(JSC::LLInt::interpreterThrowInCaller):
(JSC::LLInt::returnToThrowForThrownException):
(JSC::LLInt::returnToThrow):
(JSC::LLInt::callToThrow):

  • llint/LLIntExceptions.h: Added.

(JSC):
(LLInt):

  • llint/LLIntOfflineAsmConfig.h: Added.
  • llint/LLIntOffsetsExtractor.cpp: Added.

(JSC):
(LLIntOffsetsExtractor):
(JSC::LLIntOffsetsExtractor::dummy):
(main):

  • llint/LLIntSlowPaths.cpp: Added.

(LLInt):
(JSC::LLInt::llint_trace_operand):
(JSC::LLInt::llint_trace_value):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::traceFunctionPrologue):
(JSC::LLInt::shouldJIT):
(JSC::LLInt::entryOSR):
(JSC::LLInt::resolveGlobal):
(JSC::LLInt::getByVal):
(JSC::LLInt::handleHostCall):
(JSC::LLInt::setUpCall):
(JSC::LLInt::genericCall):

  • llint/LLIntSlowPaths.h: Added.

(JSC):
(LLInt):

  • llint/LLIntThunks.cpp: Added.

(LLInt):
(JSC::LLInt::generateThunkWithJumpTo):
(JSC::LLInt::functionForCallEntryThunkGenerator):
(JSC::LLInt::functionForConstructEntryThunkGenerator):
(JSC::LLInt::functionForCallArityCheckThunkGenerator):
(JSC::LLInt::functionForConstructArityCheckThunkGenerator):
(JSC::LLInt::evalEntryThunkGenerator):
(JSC::LLInt::programEntryThunkGenerator):

  • llint/LLIntThunks.h: Added.

(JSC):
(LLInt):

  • llint/LowLevelInterpreter.asm: Added.
  • llint/LowLevelInterpreter.cpp: Added.
  • llint/LowLevelInterpreter.h: Added.
  • offlineasm: Added.
  • offlineasm/armv7.rb: Added.
  • offlineasm/asm.rb: Added.
  • offlineasm/ast.rb: Added.
  • offlineasm/backends.rb: Added.
  • offlineasm/generate_offset_extractor.rb: Added.
  • offlineasm/instructions.rb: Added.
  • offlineasm/offset_extractor_constants.rb: Added.
  • offlineasm/offsets.rb: Added.
  • offlineasm/opt.rb: Added.
  • offlineasm/parser.rb: Added.
  • offlineasm/registers.rb: Added.
  • offlineasm/self_hash.rb: Added.
  • offlineasm/settings.rb: Added.
  • offlineasm/transform.rb: Added.
  • offlineasm/x86.rb: Added.
  • runtime/CodeSpecializationKind.h: Added.

(JSC):

  • runtime/CommonSlowPaths.h:

(JSC::CommonSlowPaths::arityCheckFor):
(CommonSlowPaths):

  • runtime/Executable.cpp:

(JSC::jettisonCodeBlock):
(JSC):
(JSC::EvalExecutable::jitCompile):
(JSC::samplingDescription):
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::jitCompile):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::baselineCodeBlockFor):
(JSC::FunctionExecutable::jitCompileForCall):
(JSC::FunctionExecutable::jitCompileForConstruct):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

  • runtime/Executable.h:

(JSC):
(EvalExecutable):
(ProgramExecutable):
(FunctionExecutable):
(JSC::FunctionExecutable::jitCompileFor):

  • runtime/ExecutionHarness.h: Added.

(JSC):
(JSC::prepareForExecution):
(JSC::prepareFunctionForExecution):

  • runtime/JSArray.h:

(JSC):
(JSArray):

  • runtime/JSCell.h:

(JSC):
(JSCell):

  • runtime/JSFunction.h:

(JSC):
(JSFunction):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSC):
(JSGlobalData):

  • runtime/JSGlobalObject.h:

(JSC):
(JSGlobalObject):

  • runtime/JSObject.h:

(JSC):
(JSObject):
(JSFinalObject):

  • runtime/JSPropertyNameIterator.h:

(JSC):
(JSPropertyNameIterator):

  • runtime/JSString.h:

(JSC):
(JSString):

  • runtime/JSTypeInfo.h:

(JSC):
(TypeInfo):

  • runtime/JSValue.cpp:

(JSC::JSValue::description):

  • runtime/JSValue.h:

(LLInt):
(JSValue):

  • runtime/JSVariableObject.h:

(JSC):
(JSVariableObject):

  • runtime/Options.cpp:

(Options):
(JSC::Options::initializeOptions):

  • runtime/Options.h:

(Options):

  • runtime/ScopeChain.h:

(JSC):
(ScopeChainNode):

  • runtime/Structure.cpp:

(JSC::Structure::addPropertyTransition):

  • runtime/Structure.h:

(JSC):
(Structure):

  • runtime/StructureChain.h:

(JSC):
(StructureChain):

  • wtf/InlineASM.h:
  • wtf/Platform.h:
  • wtf/SentinelLinkedList.h:

(SentinelLinkedList):
(WTF::SentinelLinkedList::isEmpty):

  • wtf/text/StringImpl.h:

(JSC):
(StringImpl):

Source/WebCore:

Reviewed by Gavin Barraclough.

No new tests, because there is no change in behavior.

  • CMakeLists.txt:

Source/WebKit:

Reviewed by Gavin Barraclough.

Changed EFL's build system to include a new directory in JavaScriptCore.

  • CMakeLists.txt:

Tools:

Reviewed by Gavin Barraclough.

Changed EFL's build system to include a new directory in JavaScriptCore.

  • DumpRenderTree/efl/CMakeLists.txt:
21:13 Changeset [108443] by haraken@chromium.org

NavigatorMediaStream.idl defines an interface for NavigatorGamepad
https://bugs.webkit.org/show_bug.cgi?id=79152

Reviewed by Adam Barth.

Fixed a typo: NavigatorGamepad => NavigatorMediaStream

This typo fix just changes the name of generated files:

  • V8NavigatorGamepad.h => V8NavigatorMediaStream.h
  • V8NavigatorGamepad.cpp => V8NavigatorMediaStream.cpp

The reason why the typo has not caused any serious build issues is that
the generate files for supplemental interfaces are "empty" and not important.
They just exist to control makefile dependencies.

No tests. No change in behavior.

  • mediastream/NavigatorMediaStream.idl:
21:12 Changeset [108442] by commit-queue@webkit.org

[Chromium] Fix compositor setting color uniforms incorrectly for solid color quads.
https://bugs.webkit.org/show_bug.cgi?id=76017

Patch by Daniel Sievers <sievers@chromium.org> on 2012-02-21
Reviewed by James Robinson.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawSolidColorQuad):

20:42 Changeset [108441] by commit-queue@webkit.org

getCTM() on SVG root element with borders, paddings, and viewbox returns incorrect values
https://bugs.webkit.org/show_bug.cgi?id=78631

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-02-21
Reviewed by Eric Seidel.

Source/WebCore:

SVGSVGElement::currentViewportSize was returning the size of the SVG viewport plus CSS
borders and paddings, causing the CTM calculation to be off.

Test: svg/dom/SVGLocatable-getCTM-svg-root.html

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::currentViewportSize):

SVGSVGElement::currentViewportSize now uses the contentBoxRect instead of the frameRect.
The contentBoxRect corresponds to the SVG viewport and does not include borders and
paddings.

LayoutTests:

  • platform/chromium/test_expectations.txt
  • platform/mac/svg/dom/SVGLocatable-getCTM-svg-root-expected.png
  • svg/dom/SVGLocatable-getCTM-svg-root-expected.txt: Added.
  • svg/dom/SVGLocatable-getCTM-svg-root.html: Added.
20:34 Changeset [108440] by commit-queue@webkit.org

[BlackBerry] Upstream Icon class in platform/graphics/blackberry
https://bugs.webkit.org/show_bug.cgi?id=79088

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-02-21
Reviewed by Antonio Gomes.

Initial upstreaming, no new tests.

  • platform/graphics/blackberry/IconBlackBerry.cpp: Added.

(WebCore):
(WebCore::Icon::~Icon):
(WebCore::Icon::paint):
(WebCore::Icon::createIconForFiles):

20:26 Changeset [108439] by bashi@chromium.org

Rename "reserved1" flag of WebSocketFrame to compress
https://bugs.webkit.org/show_bug.cgi?id=79187

Source/WebCore:

WebSocket deflate-frame extension draft specification defines COMP bit.
http://tools.ietf.org/html/draft-tyoshino-hybi-websocket-perframe-deflate-05#page-11

Reviewed by Kent Tamura.

No new tests. http/tests/websocket/tests/hybi/reserved-bits.html is revised to follow the change.

  • websockets/WebSocketChannel.cpp:

(WebCore):
(WebCore::WebSocketChannel::parseFrame): "reserved1" renamed "compress".
(WebCore::WebSocketChannel::processFrame): Removed reserved1 flag check.
(WebCore::makeFrameData):
(WebCore::WebSocketChannel::sendFrame):

  • websockets/WebSocketFrame.h: "reserved1" flag renamed "compress".

(WebCore::WebSocketFrame::WebSocketFrame):
(WebSocketFrame):

LayoutTests:

Reviewed by Kent Tamura.

  • http/tests/websocket/tests/hybi/reserved-bits-expected.txt: Revised to follow the change in meaning rsv1 bit.
  • http/tests/websocket/tests/hybi/reserved-bits.html: Ditto.
20:02 Changeset [108438] by yael.aharon@nokia.com

[Texmap] Move all TextureMapper related files to graphics/texmap
https://bugs.webkit.org/show_bug.cgi?id=79141

Reviewed by Martin Robinson.

Move TextureMaooerGL and TextureMapperShaderManager files to graphics/texmap.
No new tests.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • platform/graphics/qt/GraphicsContext3DQt.cpp
  • platform/graphics/opengl/TextureMapperGL.cpp: Removed.
  • platform/graphics/opengl/TextureMapperGL.h: Removed.
  • platform/graphics/opengl/TextureMapperShaderManager.cpp: Removed.
  • platform/graphics/opengl/TextureMapperShaderManager.h: Removed.
  • platform/graphics/texmap/TextureMapperGL.cpp: Copied from Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp.
  • platform/graphics/texmap/TextureMapperGL.h: Copied from Source/WebCore/platform/graphics/opengl/TextureMapperGL.h.
  • platform/graphics/texmap/TextureMapperShaderManager.cpp: Copied from Source/WebCore/platform/graphics/opengl/TextureMapperShaderManager.cpp.
  • platform/graphics/texmap/TextureMapperShaderManager.h: Copied from Source/WebCore/platform/graphics/opengl/TextureMapperShaderManager.h.
19:56 Changeset [108437] by morrita@google.com

MEDIA_STREAM should be implemented as a PageSupplement.
https://bugs.webkit.org/show_bug.cgi?id=79050

Reviewed by Adam Barth.

Source/WebCore:

Added UserMediaController which implements PageSupplement. This
controller mediates WebCore-to-client communication and lifecycle
management. Then pushed UserMediaController out as a
PageSupplement module.

No new tests. No behavior change.

  • WebCore.gypi:
  • GNUmakefile.list.am:
  • mediastream/NavigatorMediaStream.cpp:

(WebCore::NavigatorMediaStream::webkitGetUserMedia):

  • mediastream/UserMediaClient.h:

(WebCore):

  • mediastream/UserMediaController.cpp: Added.

(WebCore):
(WebCore::UserMediaController::supplementName):
(WebCore::UserMediaController::UserMediaController):
(WebCore::UserMediaController::~UserMediaController):
(WebCore::UserMediaController::create):
(WebCore::provideUserMediaTo):

  • mediastream/UserMediaController.h: Added.

(WebCore):
(UserMediaController):
(WebCore::UserMediaController::client):
(WebCore::UserMediaController::from):
(WebCore::UserMediaController::requestUserMedia):
(WebCore::UserMediaController::cancelUserMediaRequest):

  • mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::create):
(WebCore::UserMediaRequest::UserMediaRequest):
(WebCore::UserMediaRequest::didCompleteQuery):
(WebCore::UserMediaRequest::contextDestroyed):

  • mediastream/UserMediaRequest.h:

(WebCore):
(UserMediaRequest):

  • page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::~Page):
(WebCore::Page::PageClients::PageClients):

  • page/Page.h:

(WebCore):
(PageClients):
(Page):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

19:35 Changeset [108436] by commit-queue@webkit.org

Node::isContentEditable should only update styles, not layout
https://bugs.webkit.org/show_bug.cgi?id=78637

Patch by James Robinson <jamesr@chromium.org> on 2012-02-21
Reviewed by Ryosuke Niwa.

isContentEditable depends on knowing the node's current computed style, so it has to update styles if they are
out of date. It does not depend on knowing any layout-derived properties, however, so updating layout is just a
waste of time.

Behavior is covered by existing layout tests, primarily in editing/

  • dom/Node.cpp:

(WebCore::Node::isContentEditable):
(WebCore::Node::isContentRichlyEditable):

19:16 Changeset [108435] by jamesr@google.com

Partially revert r108418 - move allowEventDispatch() call back to where it used to be.

Rubber-stamped by Ryosuke Niwa.

Tested by fast/text/find-layout-crash.html

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChildren):

19:11 Changeset [108434] by andersca@apple.com

Background jitters on pages with background-attachment: fixed
https://bugs.webkit.org/show_bug.cgi?id=79182

Reviewed by Dan Bernstein.

Make sure to update the main frame scroll position before updating the scrolling layer.
This also fixes a (purely theoretical) bug where we wouldn't be updating the main frame
position if the main frame didn't have a scroll layer.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::updateMainFrameScrollPositionAndScrollLayerPosition):

18:58 Changeset [108433] by commit-queue@webkit.org

Early-out in Region::unite() for adding an empty region.
https://bugs.webkit.org/show_bug.cgi?id=79174

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-21
Reviewed by Anders Carlsson.

  • platform/graphics/Region.cpp:

(WebCore::Region::unite):

18:46 Changeset [108432] by oliver@apple.com

Unbreak double-typed arrays on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=79177

Reviewed by Gavin Barraclough.

The existing code had completely broken address arithmetic.

  • JSCTypedArrayStubs.h:

(JSC):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::storeDouble):
(JSC::MacroAssemblerARMv7::storeFloat):

18:45 Changeset [108431] by commit-queue@webkit.org

[chromium] Painting a layer clears opaque rect in untouched tiles
https://bugs.webkit.org/show_bug.cgi?id=79157

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-21
Reviewed by James Robinson.

Source/WebCore:

When painting a tiled layer, we would throw away the saved opaque rect
for any tiles that were not part of the paint. So now we check
if we are able to save the existing saved opaque rect in a more
proper way:

  1. If any pixels of the saved rect are painted non-opaque, we replace

the saved rect.

  1. If an opaque rect is drawn outside of the saved rect, we replace

the saved rect.

Unit test: TiledLayerChromiumTest.cpp

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::addSelfToOccludedScreenSpace):

Source/WebKit/chromium:

  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):

18:42 Changeset [108430] by commit-queue@webkit.org

Small typo in AudioPannerNode.cpp
https://bugs.webkit.org/show_bug.cgi?id=75890

Change to check elevation as intended instead of azimuth.

Patch by Raymond Toy <rtoy@google.com> on 2012-02-21
Reviewed by Chris Rogers.

No new tests for correction of typo.

  • webaudio/AudioPannerNode.cpp:

(WebCore::AudioPannerNode::getAzimuthElevation):

18:35 Changeset [108429] by jonlee@apple.com

Build fix. Push ENABLE_NOTIFICATIONS into .mm file.

  • WebCoreSupport/WebNotificationClient.h:
  • WebView/WebNotification.h:
  • WebView/WebNotification.mm:

(-[WebNotification title]):
(-[WebNotification body]):
(-[WebNotification origin]):
(-[WebNotification notificationID]):
(-[WebNotification dispatchShowEvent]):
(-[WebNotification dispatchCloseEvent]):
(-[WebNotification dispatchClickEvent]):
(-[WebNotification dispatchErrorEvent]):

18:23 WikiStart edited by haraken@chromium.org
(diff)
18:22 Changeset [108428] by abarth@webkit.org

Frame and Navigator shouldn't need to worry about Geolocation
https://bugs.webkit.org/show_bug.cgi?id=78860

Reviewed by Eric Seidel.

This patch removes some Geolocation-specific code from Frame and
Navigator in favor of our new supplemental module mechanism. We're
still refining the module system, but we seem to be converging on a
simple Observer/Supplement design.

In a future patch, I'll move the remaining Geolocation-related files in
WebCore into Modules/geolocation. This patch appears to be the first
patch that introduces a module used by all the various build systems,
which is why there's a bit more build system overhead than usual.

  • Modules/geolocation: Added.
  • Modules/geolocation/NavigatorGeolocation.cpp: Added.

(WebCore):
(WebCore::NavigatorGeolocation::NavigatorGeolocation):
(WebCore::NavigatorGeolocation::~NavigatorGeolocation):
(WebCore::NavigatorGeolocation::pageDestroyed):
(WebCore::NavigatorGeolocation::from):
(WebCore::NavigatorGeolocation::geolocation):

  • Modules/geolocation/NavigatorGeolocation.h: Added.

(WebCore):
(NavigatorGeolocation):

  • Modules/geolocation/NavigatorGeolocation.idl: Added.
    • I've temporarily disabled this API for GObject because it generates a strange compile error. Once I land this patch, I'll spend some more time fixing the compile error.
  • page/DOMWindow.cpp:

(WebCore):

  • page/DOMWindow.h:

(DOMWindow):

  • page/Frame.cpp:

(WebCore::Frame::pageDestroyed):
(WebCore::Frame::transferChildFrameToNewDocument):

  • page/FrameDestructionObserver.cpp:

(WebCore::FrameDestructionObserver::pageDestroyed):
(WebCore):

  • page/FrameDestructionObserver.h:

(FrameDestructionObserver):

  • page/Navigator.cpp:

(WebCore):

  • page/Navigator.h:

(WebCore):
(Navigator):

  • page/Navigator.idl:
18:20 WebKitIDL edited by haraken@chromium.org
(diff)
18:20 WebKitIDL edited by haraken@chromium.org
(diff)
17:51 Changeset [108427] by barraclough@apple.com

Should be able to reconfigure a non-configurable property as read-only
https://bugs.webkit.org/show_bug.cgi?id=79170

Reviewed by Sam Weinig.

See ES5.1 8.12.9 10.a.i - the spec prohibits making a read-only property writable,
but does not inhibit making a writable property read-only.

Source/JavaScriptCore:

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSC::JSGlobalData::setInDefineOwnProperty):
(JSGlobalData):
(JSC::JSGlobalData::isInDefineOwnProperty):

  • Added flag, tracking whether we are in JSObject::defineOwnProperty.
  • runtime/JSObject.cpp:

(JSC::JSObject::deleteProperty):
(DefineOwnPropertyScope):

  • Always allow properties to be deleted by DefineOwnProperty - assume it knows what it is doing!

(JSC::DefineOwnPropertyScope::DefineOwnPropertyScope):
(JSC::DefineOwnPropertyScope::~DefineOwnPropertyScope):

  • Added RAII helper.

(JSC::JSObject::defineOwnProperty):

  • Track on the globalData when we are in this method.

LayoutTests:

  • fast/js/Object-defineProperty-expected.txt:
  • fast/js/script-tests/Object-defineProperty.js:
    • Update test result (this was enforcing incorrect behaviour).
17:49 Changeset [108426] by shawnsingh@chromium.org

[chromium] Refactor CCLayerTreeHostCommon: merge scattered setTargetRenderSurface logic
https://bugs.webkit.org/show_bug.cgi?id=78936

Reviewed by James Robinson.

No change in behavior, the code moved around already covered by existing tests.

In calculateDrawTransformsAndVisibility(), there are two separate
if-else statements where setTargetRenderSurface logic is
performed, and this makes the code less readable and more error
prone. This patch merges the logic, removing the redundant if-else
statements.

This code also merges one other set of if-statements that are
equivalent, if (layer->parent()) and if (layer!=rootLayer).

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::createRenderSurface):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::createRenderSurface):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsAndVisibilityInternal):

17:36 Changeset [108425] by sullivan@apple.com

Build fix.

  • WebView/WebUIDelegatePrivate.h:

Added @class declarations for DOMNode and DOMElement.

17:24 WebKitIDL edited by haraken@chromium.org
(diff)
17:23 Changeset [108424] by haraken@chromium.org

Remove FIXME from resolve-supplemental.pl
https://bugs.webkit.org/show_bug.cgi?id=79160

Reviewed by Adam Barth.

The IDL attribute checker has been enabled in all build systems.
This patch removes FIXME in resolve-supplemental.pl.
Also, this patch improves a comment in IDLAttributes.txt.

No tests. No change in behavior.

  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/resolve-supplemental.pl:
17:19 Changeset [108423] by eae@chromium.org

Add FractionalLayoutRect for sub-pixel layout
https://bugs.webkit.org/show_bug.cgi?id=78924

Reviewed by Eric Seidel.

Add FractionalLayoutUnit version of Rect class. Uses FractionalLayoutPoint
and FractionalLayoutSize internally.

Also add conversions to int/float versions of same.

No new tests.

  • GNUmakefile.list.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/FloatRect.cpp:

(WebCore::FloatRect::FloatRect):
(WebCore):

  • platform/graphics/FloatRect.h:

(WebCore):
(FloatRect):

  • platform/graphics/FractionalLayoutRect.cpp: Added.

(WebCore):
(WebCore::FractionalLayoutRect::FractionalLayoutRect):
(WebCore::FractionalLayoutRect::intersects):
(WebCore::FractionalLayoutRect::contains):
(WebCore::FractionalLayoutRect::intersect):
(WebCore::FractionalLayoutRect::unite):
(WebCore::FractionalLayoutRect::uniteIfNonZero):
(WebCore::FractionalLayoutRect::scale):
(WebCore::unionRect):
(WebCore::enclosingIntRect):
(WebCore::enclosingFractionalLayoutRect):
(WebCore::pixelSnappedIntRect):

  • platform/graphics/FractionalLayoutRect.h: Added.

(WebCore):
(FractionalLayoutRect):
(WebCore::FractionalLayoutRect::FractionalLayoutRect):
(WebCore::FractionalLayoutRect::location):
(WebCore::FractionalLayoutRect::size):
(WebCore::FractionalLayoutRect::setLocation):
(WebCore::FractionalLayoutRect::setSize):
(WebCore::FractionalLayoutRect::x):
(WebCore::FractionalLayoutRect::y):
(WebCore::FractionalLayoutRect::maxX):
(WebCore::FractionalLayoutRect::maxY):
(WebCore::FractionalLayoutRect::width):
(WebCore::FractionalLayoutRect::height):
(WebCore::FractionalLayoutRect::setX):
(WebCore::FractionalLayoutRect::setY):
(WebCore::FractionalLayoutRect::setWidth):
(WebCore::FractionalLayoutRect::setHeight):
(WebCore::FractionalLayoutRect::isEmpty):
(WebCore::FractionalLayoutRect::center):
(WebCore::FractionalLayoutRect::move):
(WebCore::FractionalLayoutRect::moveBy):
(WebCore::FractionalLayoutRect::expand):
(WebCore::FractionalLayoutRect::contract):
(WebCore::FractionalLayoutRect::shiftXEdgeTo):
(WebCore::FractionalLayoutRect::shiftMaxXEdgeTo):
(WebCore::FractionalLayoutRect::shiftYEdgeTo):
(WebCore::FractionalLayoutRect::shiftMaxYEdgeTo):
(WebCore::FractionalLayoutRect::minXMinYCorner):
(WebCore::FractionalLayoutRect::maxXMinYCorner):
(WebCore::FractionalLayoutRect::minXMaxYCorner):
(WebCore::FractionalLayoutRect::maxXMaxYCorner):
(WebCore::FractionalLayoutRect::contains):
(WebCore::FractionalLayoutRect::inflateX):
(WebCore::FractionalLayoutRect::inflateY):
(WebCore::FractionalLayoutRect::inflate):
(WebCore::FractionalLayoutRect::transposedRect):
(WebCore::FractionalLayoutRect::infiniteRect):
(WebCore::intersection):
(WebCore::unionRect):
(WebCore::operator==):
(WebCore::operator!=):

  • platform/graphics/IntRect.cpp:

(WebCore::IntRect::IntRect):
(WebCore):

  • platform/graphics/IntRect.h:

(WebCore):
(IntRect):

17:11 WebKitIDL edited by haraken@chromium.org
(diff)
17:04 Changeset [108422] by jamesr@google.com

Enable ScrollingCoordinator in chromium whenever compositing is enabled
https://bugs.webkit.org/show_bug.cgi?id=79165

Reviewed by Adam Barth.

Source/WebCore:

As the title says.

  • page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::setScrollLayer):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setScrollParameters):
(WebCore::ScrollingCoordinator::setWheelEventHandlerCount):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):

Remove ASSERT_NOT_REACHED()ed from these functions, they are now expected to be called but do nothing.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::RenderLayerBacking):

Guard a mac-specific piece of code in #if PLATFORM(MAC). This code already has a FIXME.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::shouldCompositeOverflowControls):

Make coordinatesScroll..() sufficient but not necessary for compositing overflow controls. In chromium, we
want to composite overflow controls even for FrameViews that we aren't coordinating via the
ScrollingCoordinator.

Source/WebKit/chromium:

  • src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::setViewport):

Whenever the ScrollingCoordinator is enabled the scroll layer's position is expected to be updated
externally to RenderLayerCompositor, so set it here.

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setAcceleratedCompositingEnabled):

17:01 Changeset [108421] by jonlee@apple.com

Build fix for r108409.

  • WebCoreSupport/WebNotificationClient.h:

(WebCore):

  • WebCoreSupport/WebNotificationClient.mm:
  • WebView/WebNotification.h:

(WebSecurityOrigin):

  • WebView/WebNotification.mm:

(core):
(-[WebNotification initWithCoreNotification:notificationID:]):

16:55 WebKitIDL edited by haraken@chromium.org
(diff)
16:49 Changeset [108420] by oliver@apple.com

Make TypedArrays be available in commandline jsc
https://bugs.webkit.org/show_bug.cgi?id=79163

Reviewed by Gavin Barraclough.

Adds a compile time option to have jsc support a basic implementation
of the TypedArrays available in WebCore. This lets us test the typed
array logic in the JIT witout having to build webcore.

  • JSCTypedArrayStubs.h: Added.

(JSC):

(GlobalObject::finishCreation):
(GlobalObject):
(GlobalObject::addConstructableFunction):

  • runtime/JSGlobalData.h:

(JSGlobalData):

16:47 Changeset [108419] by dcheng@chromium.org

[chromium] Fix image drag out on Chromium
https://bugs.webkit.org/show_bug.cgi?id=79158

Reviewed by Tony Chang.

Source/WebKit/chromium:

We constructed the WebDragData::Item for dragging out an image but never added it to the
item list. This is normally covered by the fast/events/drag-image-filename.html layout test,
but the bug wasn't caught in the original patch since the implementations in Chrome and DRT
had diverged.

  • src/WebDragData.cpp:

(WebKit::WebDragData::items):

Tools:

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::dumpFilenameBeingDragged):
(EventSender::beginDragWithFiles):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(addDRTFakeFileToDataObject):

16:46 Changeset [108418] by adamk@chromium.org

Setting innerText causes DOMSubtreeModified to be dispatched too early
https://bugs.webkit.org/show_bug.cgi?id=79140

Reviewed by Ryosuke Niwa.

Source/WebCore:

Followup to r108152: move children change notifications later in
ContainerNode::removeChildren(), thus making sure Node::inDocument()
is in the correct state when we call into script.

Tests: fast/dom/getElementById-consistency3.html

fast/dom/getElementById-consistency4.html
fast/dom/getElementById-consistency5.html

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChildren):

LayoutTests:

  • fast/dom/getElementById-consistency3-expected.txt: Added.
  • fast/dom/getElementById-consistency3.html: Added.
  • fast/dom/getElementById-consistency4-expected.txt: Added.
  • fast/dom/getElementById-consistency4.html: Added.
  • fast/dom/getElementById-consistency5-expected.txt: Added.
  • fast/dom/getElementById-consistency5.html: Added.
16:42 Changeset [108417] by rniwa@webkit.org

Assertion failure in TextIterator::handleTextBox
https://bugs.webkit.org/show_bug.cgi?id=78530

Source/WebCore:

Reviewed by Eric Seidel.

The assertion failure was caused by handleTextNodeFirstLetter's updating m_text without clearing
m_sortedTextBoxesPosition. Re-structured handleTextNode so that we always reset m_sortedTextBoxesPosition
when we have a first-letter.

Test: editing/text-iterator/rtl-first-letter-text-iterator-crash.html

  • editing/TextIterator.cpp:

(WebCore::TextIterator::handleTextNode):
(WebCore::TextIterator::handleTextBox):
(WebCore::TextIterator::handleTextNodeFirstLetter):

LayoutTests:

Reviewed by Enrica Casucci.

Add a regression test. Also rebaseline a crash test.

  • editing/text-iterator/rtl-first-letter-text-iterator-crash-expected.txt: Added.
  • editing/text-iterator/rtl-first-letter-text-iterator-crash.html: Added.
  • editing/text-iterator/rtl-selection-crash-expected.txt:
16:38 Changeset [108416] by yael.aharon@nokia.com

Unreviewed build fix.

No new tests.

  • platform/graphics/opengl/TextureMapperGL.cpp:
16:34 Changeset [108415] by adamk@chromium.org

ContainerNode::childrenChanged must be called immediately after removing children
https://bugs.webkit.org/show_bug.cgi?id=79162

Reviewed by Ryosuke Niwa.

Source/WebCore:

In r108152, a call to childrenChanged() was erroneously moved
below the call to child->removedFromDocument(). This breaks, at the
least, the behavior of the <title> element. This patch corrects the
mistake and adds a test.

Test: fast/dom/title-directionality-removeChild.html

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChild):

LayoutTests:

  • fast/dom/title-directionality-removeChild-expected.txt: Added.
  • fast/dom/title-directionality-removeChild.html: Added.
16:32 Changeset [108414] by dpranke@chromium.org

webkitpy: speed up hot filesystem_mock functions
https://bugs.webkit.org/show_bug.cgi?id=79159

Reviewed by Adam Barth.

Profiling run_webkit_tests_integrationtest.py revealed that
isdir(), normpath(), and join() are called a lot and were very
slow.This patch speeds them up substantially, shaving 20 seconds
off of the execution time.

  • Scripts/webkitpy/common/system/filesystem_mock.py:

(MockFileSystem.isdir):
(MockFileSystem._slow_but_correct_join):
(MockFileSystem.join):
(MockFileSystem.listdir):
(MockFileSystem._slow_but_correct_normpath):
(MockFileSystem.normpath):
(MockFileSystem.write_binary_file):

  • Scripts/webkitpy/common/system/filesystem_mock_unittest.py:

(MockFileSystemTest.quick_check):
(MockFileSystemTest):
(MockFileSystemTest.test_join):
(MockFileSystemTest.test_normpath):

  • Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:

(get_test_config): Call write_binary_file() instead of updating

filesystem.files directly, so that we create directories as
needed.

16:29 Changeset [108413] by dpranke@chromium.org

nrwt: make the delay between starting workers configurable per-port
https://bugs.webkit.org/show_bug.cgi?id=79148

Reviewed by Eric Seidel.

Because of bug 79147, we have to sleep a bit in between starting
DRTs; however, doing so across the board slows down the Test
port. Making this configurable shaves 10 seconds off of
run_webkit_tests_integrationtest.py

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._run_tests):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.worker_startup_delay_secs):

  • Scripts/webkitpy/layout_tests/port/test.py:

(TestPort.worker_startup_delay_secs):

16:19 Changeset [108412] by tsepez@chromium.org

equalIgnoringNullity() only comparing half the bytes for equality
https://bugs.webkit.org/show_bug.cgi?id=79135

Reviewed by Adam Barth.

Source/JavaScriptCore:

  • wtf/text/StringImpl.h:

(WTF::equalIgnoringNullity):

LayoutTests:

  • http/tests/security/xssAuditor/script-tag.html:
16:16 WebKitIDL edited by haraken@chromium.org
(diff)
16:12 Changeset [108411] by jamesr@google.com

[chromium] Update chromium expectations for accessibility/aria-invalid.html

  • platform/chromium/test_expectations.txt:
16:03 Changeset [108410] by macpherson@chromium.org

Implement many instances of HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=79067

Reviewed by Andreas Kling.

No new tests / refactoring only.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • rendering/style/RenderStyle.h:
16:00 Changeset [108409] by jonlee@apple.com

Source/WebCore: Bring notifications support to WK1 mac
https://bugs.webkit.org/show_bug.cgi?id=78783
<rdar://problem/10610578>

Reviewed by Anders Carlsson.

  • WebCore.exp.in: Expose dispatchErrorEvent on Notification.

Source/WebKit: Bring notifications support to WK1 mac: showing, canceling, removing notifications
https://bugs.webkit.org/show_bug.cgi?id=78783
<rdar://problem/10610578>

Reviewed by Anders Carlsson.

  • WebKit.xcodeproj/project.pbxproj: Added new files.

Source/WebKit/mac: Bring notifications support to WK1 mac: permission requests
https://bugs.webkit.org/show_bug.cgi?id=78783
<rdar://problem/10610578>

Reviewed by Anders Carlsson.

  • WebCoreSupport/WebNotificationClient.h:
  • WebCoreSupport/WebNotificationClient.mm: Create policy listener, which conforms to the

WebAllowDenyPolicyListener protocol, similar to geolocation.
(WebNotificationClient::requestPermission):
(WebNotificationClient::checkPermission):
(-[WebNotificationPolicyListener initWithCallback:]):
(-[WebNotificationPolicyListener allow]): Call the callback.
(-[WebNotificationPolicyListener deny]): Call the callback.

  • WebView/WebUIDelegatePrivate.h: Define new UI delegate method to ask the user to decide a

policy for navigations.

====
Bring notifications support to WK1 mac: showing, canceling, removing notifications

Create a WebKit wrapper object for WebCore::Notification, which also keeps track of an assigned
ID.

  • WebView/WebNotification.h: Added.

(WebSecurityOrigin):

  • WebView/WebNotification.mm: Added.

(core):
(-[WebNotification initWithCoreNotification:notificationID:]):
(-[WebNotification init]):
(-[WebNotification dealloc]):
(-[WebNotification title]):
(-[WebNotification body]):
(-[WebNotification origin]):
(-[WebNotification notificationID]):
(-[WebNotification dispatchShowEvent]):
(-[WebNotification dispatchCloseEvent]):
(-[WebNotification dispatchClickEvent]):
(-[WebNotification dispatchErrorEvent]):

  • WebView/WebNotificationInternal.h: Added.

(WebCore): Internal category to allow creating instances with WebCore objects.

Extend WebView to include a WebNotificationProvider, which clients implement.

  • WebView/WebViewData.h: Add a private member for the provider.
  • WebView/WebViewPrivate.h:
    • Define an enum WebNotificationPermission that mirrors WebCore::NotificationPresenter::Permission that client which implement the provider can use to return policy decisions.
    • Define WebNotificationProvider.
    • Category WebViewNotification extends WebView with methods that set and manager the notification provider, and handle events from the platform notifications.
  • WebView/WebView.mm:

(-[WebView _setNotificationProvider:]): Sets the provider when initializing the WebView.
(-[WebView _notificationControllerDestroyed]):
(-[WebView _notificationProvider]):
(-[WebView _notificationDidShow:]):
(-[WebView _notificationDidClick:]):
(-[WebView _notificationsDidClose:]):

  • WebCoreSupport/WebNotificationClient.h: Add variables that map between WebCore::Notification

instances, their assigned IDs, their contexts, and corresponding WebKit wrapper objects.

  • WebCoreSupport/WebNotificationClient.mm:

(generateNotificationID): Created unique IDs for each shown notification.
(WebNotificationClient::show): Create wrapper object for notification, assign ID, cache the
mappings between the objects, and forward it to the provider.
(WebNotificationClient::cancel):
(WebNotificationClient::clearNotifications): Clear all notifications associated with the
provided context.
(WebNotificationClient::notificationObjectDestroyed): Remove the notification from the maps.
(WebNotificationClient::notificationControllerDestroyed): If the controller is destroyed, tell
the provider to clear of the notifications related to this web view.

====
(Prep work for) Bring notifications support to WK1 mac

Rename WebGeolocationPolicyListener. The interface is generic enough to be reused for
notification requests. To avoid having to create a new listener type, instead rename it
to WebAllowDenyPolicyListener.

  • WebView/WebUIDelegatePrivate.h: Rename the protocol.
  • WebCoreSupport/WebGeolocationClient.mm: Refactor geolocation request listener to use

new name.

Add preference to keep track of whether notifications are enabled in general.

  • WebView/WebPreferenceKeysPrivate.h: Add WebNotificationsEnabledKey for storing the

preference.

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]): By default have them enabled.
(-[WebPreferences setNotificationsEnabled:]):
(-[WebPreferences notificationsEnabled]):

  • WebView/WebPreferencesPrivate.h:

Add a stringValue method that exposes WebCore::SecurityOrigin::toString() for storing the
notification policy for a given origin.

  • WebCoreSupport/WebSecurityOrigin.mm:

(-[WebSecurityOrigin stringValue]):

  • WebCoreSupport/WebSecurityOriginPrivate.h:

Tools: Bring notifications support to WK1 mac
https://bugs.webkit.org/show_bug.cgi?id=78783
<rdar://problem/10610578>

Reviewed by Anders Carlsson.

  • DumpRenderTree/mac/UIDelegate.mm: Refactor WebGeolocationPolicyListener to WebAllowDenyPolicyListener.

(-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
(-[UIDelegate timerFired]):

15:33 Changeset [108408] by noam.rosenthal@nokia.com

[Qt][WK2] Draw tiles of previous contents-scale for opaque layers if they don't intersect with previous tiles
https://bugs.webkit.org/show_bug.cgi?id=78962

Only avoid painting old-scale tiles in semi-transparent situtations if the old
tiles intersect with existing tiles.

Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/qt/LayerBackingStore.cpp:

(WebKit::LayerBackingStore::paintToTextureMapper):

15:30 Changeset [108407] by noam.rosenthal@nokia.com

[Qt] Previous web page appears outside content rect
https://bugs.webkit.org/show_bug.cgi?id=78816

Source/WebCore:

Adjust the scissor clipping by -1, as the glScissor() function requires coordinates and
not sizes.

Reviewed by Kenneth Rohde Christiansen.

No new functionality.

  • platform/graphics/opengl/TextureMapperGL.cpp:

(WebCore::scissorClip):

Source/WebKit2:

Apply a clip on painted tiles if some of the tiles fall outside of the target rect.

Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/qt/LayerBackingStore.cpp:

(WebKit::LayerBackingStore::paintToTextureMapper):

15:28 Changeset [108406] by commit-queue@webkit.org

Source/WebCore: Added support for pause-on-exit flag on a TextTrackCue.
https://bugs.webkit.org/show_bug.cgi?id=72173

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-02-21
Reviewed by Eric Carlson.

Test: media/track/track-cues-pause-on-exit.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updateActiveTextTrackCues): Implemented
support for pausing the video if the pause-on-exit flag is set on
a cue that is currently exiting.

LayoutTests: Added relevant tests and functionality for supporting pause-on-exit
flag for a TextTrackCue.

https://bugs.webkit.org/show_bug.cgi?id=72173

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-02-21
Reviewed by Eric Carlson.

  • media/track/captions-webvtt/simple-captions.vtt: Added.
  • media/track/track-cues-pause-on-exit-expected.txt: Added.
  • media/track/track-cues-pause-on-exit.html: Added.
14:57 Changeset [108405] by noam.rosenthal@nokia.com

[Qt][WK2] Accelerated animations don't work on Mac
https://bugs.webkit.org/show_bug.cgi?id=78963

Problem came from using a non-RunLoop timer.
Remove the unused viewportUpdateTimer, and use the existing animationTimer instead.
Use a continuous timer that we only stop when animations stop.

Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/LayerTreeHostProxy.h:

(LayerTreeHostProxy):

  • UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::LayerTreeHostProxy):
(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit):
(WebKit::LayerTreeHostProxy::syncAnimations):

14:51 Changeset [108404] by haraken@chromium.org

Enable the IDL attribute checker in all build systems
https://bugs.webkit.org/show_bug.cgi?id=79090

Reviewed by Adam Barth.

We have enabled the IDL attribute checker in Chromium in r108322.
This patch enables the IDL attribute checker in all other
build systems.

No tests. I manually checked that [Custommm], [CallWith=],
[CallWith=ScriptExecutionContext|Foo] cause build failures.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • UseJSC.cmake:
  • UseV8.cmake:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/IDLAttributes.txt: Added [ObjCCustomImplementation]

since I forgot to add it in r108322.

14:46 Changeset [108403] by rniwa@webkit.org

Fix more typos.

14:44 Changeset [108402] by yael.aharon@nokia.com

[Texmap] Better management of shaders in TextureMapperGL
https://bugs.webkit.org/show_bug.cgi?id=78674

Reviewed by Noam Rosenthal.

Split TextureMapperGL.cpp into two files.
Get rid of the enums that we were using to identify shaders and to identify variables.
Switch flip and opaque from using bool to using enums.

No new tests. This is refactoring only.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • platform/graphics/OpenGLShims.h:
  • platform/graphics/opengl/TextureMapperGL.cpp:

(WebCore):
(SharedGLData):
(WebCore::TextureMapperGLData::SharedGLData::SharedGLData):
(WebCore::TextureMapperGLData::SharedGLData::~SharedGLData):
(WebCore::TextureMapperGLData::TextureMapperGLData):
(TextureMapperGLData):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::TextureMapperGL::drawTextureWithMaskAndOpacity):
(WebCore::TextureMapperGL::drawTextureSimple):
(WebCore::TextureMapperGL::beginClip):

  • platform/graphics/opengl/TextureMapperGL.h:
  • platform/graphics/opengl/TextureMapperShaderManager.cpp: Added.

(WebCore):
(WebCore::FRAGMENT_SHADER):
(WebCore::TextureMapperShaderProgram::initializeProgram):
(WebCore::TextureMapperShaderProgram::getUniformLocation):
(WebCore::TextureMapperShaderProgram::~TextureMapperShaderProgram):
(WebCore::TextureMapperShaderProgramSimple::create):
(WebCore::TextureMapperShaderProgramSimple::TextureMapperShaderProgramSimple):
(WebCore::TextureMapperShaderProgramSimple::vertexShaderSource):
(WebCore::TextureMapperShaderProgramSimple::fragmentShaderSource):
(WebCore::TextureMapperShaderProgramOpacityAndMask::create):
(WebCore::TextureMapperShaderProgramOpacityAndMask::TextureMapperShaderProgramOpacityAndMask):
(WebCore::TextureMapperShaderProgramOpacityAndMask::vertexShaderSource):
(WebCore::TextureMapperShaderProgramOpacityAndMask::fragmentShaderSource):
(WebCore::TextureMapperShaderProgramClip::create):
(WebCore::TextureMapperShaderProgramClip::TextureMapperShaderProgramClip):
(WebCore::TextureMapperShaderProgramClip::vertexShaderSource):
(WebCore::TextureMapperShaderProgramClip::fragmentShaderSource):
(WebCore::TextureMapperShaderManager::TextureMapperShaderManager):
(WebCore::TextureMapperShaderManager::~TextureMapperShaderManager):

  • platform/graphics/opengl/TextureMapperShaderManager.h: Added.

(WebCore):
(WebCore::debugGLCommand):
(TextureMapperShaderProgram):
(WebCore::TextureMapperShaderProgram::id):
(WebCore::TextureMapperShaderProgram::vertexAttrib):
(WebCore::TextureMapperShaderProgram::shaderType):
(TextureMapperShaderProgramSimple):
(WebCore::TextureMapperShaderProgramSimple::matrixVariable):
(WebCore::TextureMapperShaderProgramSimple::sourceMatrixVariable):
(WebCore::TextureMapperShaderProgramSimple::sourceTextureVariable):
(WebCore::TextureMapperShaderProgramSimple::opacityVariable):
(TextureMapperShaderProgramOpacityAndMask):
(WebCore::TextureMapperShaderProgramOpacityAndMask::sourceMatrixVariable):
(WebCore::TextureMapperShaderProgramOpacityAndMask::matrixVariable):
(WebCore::TextureMapperShaderProgramOpacityAndMask::maskMatrixVariable):
(WebCore::TextureMapperShaderProgramOpacityAndMask::sourceTextureVariable):
(WebCore::TextureMapperShaderProgramOpacityAndMask::maskTextureVariable):
(WebCore::TextureMapperShaderProgramOpacityAndMask::opacityVariable):
(TextureMapperShaderProgramClip):
(WebCore::TextureMapperShaderProgramClip::matrixVariable):
(TextureMapperShaderManager):
(WebCore::TextureMapperShaderManager::getShaderProgram):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):

  • platform/graphics/texmap/TextureMapper.h:

(WebCore::BitmapTexture::reset):
(WebCore::BitmapTexture::isOpaque):
(BitmapTexture):

14:37 Changeset [108401] by rniwa@webkit.org

Fix the typo.

14:29 Changeset [108400] by haraken@chromium.org

Enable the IDL attribute checker in run-bindings-tests
https://bugs.webkit.org/show_bug.cgi?id=79091

Reviewed by Adam Barth.

We have enabled the IDL attribute checker in Chromium in r108322.
This patch enables the IDL attribute checker in run-bindings-tests.

No tests. I manually checked that [Custommm], [CallWith=],
[CallWith=ScriptExecutionContext|Foo] in TestObj.idl cause
run-bindings-tests failures.

  • Scripts/webkitpy/bindings/main.py:

(BindingsTests.generate_supplemental_dependency):

14:26 Changeset [108399] by rniwa@webkit.org

perf-o-matic: Extract logic to generate JSON responses as classes to unit test
https://bugs.webkit.org/show_bug.cgi?id=79018

Rubber-stamped by Adam Birth.

Extracted DashboardJSONGenerator, ManifestJSONGenerator, and RunsJSONGenerator
into json_generators.py from DashboardHandler, ManifestHandler, and RunsHandler
and added unit tests for the former three classes.

Merged the latter three classes into controler.py since they have become too trivial
to have their own files.

  • Websites/webkit-perf.appspot.com/controller.py:

(ManifestUpdateHandler):
(ManifestUpdateHandler.get):
(ManifestUpdateHandler.post):
(DashboardUpdateHandler):
(DashboardUpdateHandler.get):
(DashboardUpdateHandler.post):
(_get_test_branch_platform_ids):
(RunsUpdateHandler):
(RunsUpdateHandler.get):
(CachedRunsHandler.get):

  • Websites/webkit-perf.appspot.com/dashboard_handler.py: Removed.
  • Websites/webkit-perf.appspot.com/json_generators.py: Added.

(JSONGeneratorBase):
(JSONGeneratorBase.to_json):
(DashboardJSONGenerator):
(DashboardJSONGenerator.init):
(DashboardJSONGenerator.value):
(ManifestJSONGenerator):
(ManifestJSONGenerator.init):
(ManifestJSONGenerator.value):
(RunsJSONGenerator):
(RunsJSONGenerator.init):
(RunsJSONGenerator._generate_runs):
(RunsJSONGenerator._entry_from_build_and_result):
(RunsJSONGenerator.value):

  • Websites/webkit-perf.appspot.com/json_generators_unittest.py: Added.

(_create_results):
(JSONGeneratorBaseTest):
(JSONGeneratorBaseTest.test_to_json):
(JSONGeneratorBaseTest.test_to_json.AJSONGenerator):
(JSONGeneratorBaseTest.test_to_json.AJSONGenerator.value):
(DashboardJSONGeneratorTest):
(DashboardJSONGeneratorTest.test_value_no_branch):
(DashboardJSONGeneratorTest.test_value_no_plaforms):
(DashboardJSONGeneratorTest.test_value_single_platform):
(DashboardJSONGeneratorTest.test_value_two_platforms):
(ManifestJSONGeneratorTest):
(ManifestJSONGeneratorTest.test_value_no_branch):
(ManifestJSONGeneratorTest.test_value_no_plaforms):
(ManifestJSONGeneratorTest._assert_single_test):
(ManifestJSONGeneratorTest.test_value_single_platform):
(ManifestJSONGeneratorTest.test_value_two_platforms):
(ManifestJSONGeneratorTest.test_value_two_tests):
(RunsJSONGeneratorTest):
(RunsJSONGeneratorTest._create_results):
(RunsJSONGeneratorTest.test_generate_runs):
(RunsJSONGeneratorTest.test_value_without_results):
(RunsJSONGeneratorTest.test_value_with_results):
(RunsJSONGeneratorTest._assert_entry):
(RunsJSONGeneratorTest.test_run_from_build_and_result):
(RunsJSONGeneratorTest.test_run_from_build_and_result.create_build):

  • Websites/webkit-perf.appspot.com/main.py:
  • Websites/webkit-perf.appspot.com/manifest_handler.py: Removed.
  • Websites/webkit-perf.appspot.com/models.py:

(Test.update_or_insert.execute):
(Test):
(TestResult.get_or_insert_from_parsed_json):

  • Websites/webkit-perf.appspot.com/models_unittest.py:

(TestModelTests.test_update_or_insert_to_update):
(TestResultTests.test_get_or_insert_stat_value):

  • Websites/webkit-perf.appspot.com/runs_handler.py: Removed.
14:26 Changeset [108398] by leviw@chromium.org

Explicitly converting table's logical width, as well as borders, padding, spacing, etc. to integers before doing math with them to avoid truncating the width an extra pixel unnecessarily.

14:21 Changeset [108397] by andersca@apple.com

The tile cache should keep track of the tile coverage rect
https://bugs.webkit.org/show_bug.cgi?id=79149
<rdar://problem/10877338>

Reviewed by Andreas Kling.

Keep track of the tile coverage rect and use it to avoid trying to iterate over non-existent tiles on large pages.

  • platform/graphics/ca/mac/TileCache.h:

(TileCache):

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::setNeedsDisplayInRect):
(WebCore::TileCache::revalidateTiles):

14:05 Changeset [108396] by kling@webkit.org

Make WebKitCSSShaderValue inherit directly from CSSValue.
<http://webkit.org/b/79144>

Reviewed by Antti Koivisto.

WebKitCSSShaderValue was inheriting from CSSPrimitiveValue but only used
it for storing the shader URL. Moved that to a String member instead.

WebKitCSSShaderValues didn't even return true for isPrimitiveValue() so
there should be no behavior change whatsoever here.

  • css/WebKitCSSShaderValue.cpp:

(WebCore::WebKitCSSShaderValue::WebKitCSSShaderValue):
(WebCore::WebKitCSSShaderValue::cachedShader):
(WebCore::WebKitCSSShaderValue::customCssText):

  • css/WebKitCSSShaderValue.h:

(WebKitCSSShaderValue):

13:57 Changeset [108395] by jamesr@google.com

Unreviewed windows build fix - avoid return statement after return if USE(ACCELERATED_COMPOSITING) is set.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::coordinatesScrollingForFrameView):

13:46 Changeset [108394] by leviw@chromium.org

Fixing the order of arguments to pixelSnappedIntRectFromEdges in RenderInline, and properly calculating the available logical width in RenderBlockLineLayout. Both of these were regressions from my previous commit.

13:40 Changeset [108393] by ossy@webkit.org

[Qt] Unreviewed gardening. Typo fix.

  • platform/qt-5.0-wk2/http/tests/websocket/tests/hybi/bad-sub-protocol-non-ascii-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/http/tests/websocket/test/hybi/bad-sub-protocol-non-ascii-expected.txt.
13:39 Changeset [108392] by jamesr@google.com

ScrollingCoordinator::coordinatesScrollingForFrameView should be conditional on compositing being active
https://bugs.webkit.org/show_bug.cgi?id=79126

Reviewed by Anders Carlsson.

The ScrollingCoordinator should only attempt to coordinate scrolling when compositing is active, since it's all
about manipulating GraphicsLayers. Adds a runtime check.

Also removes some stray #if ENABLE(THREADED_SCROLLING) guards that snuck into FrameView.

  • page/FrameView.cpp:

(WebCore::FrameView::addFixedObject):
(WebCore::FrameView::removeFixedObject):

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::coordinatesScrollingForFrameView):
(WebCore::ScrollingCoordinator::frameViewRootLayerDidChange):

13:35 Changeset [108391] by jamesr@google.com

Chromium build fix. Unreviwed but rubber-stamped by Antti.

  • dom/Document.cpp:
  • editing/ReplaceSelectionCommand.cpp:
  • inspector/InspectorStyleSheet.h:
13:29 Changeset [108390] by senorblanco@chromium.org

Merge 107822 - Source/WebCore: Fix for incorrect/offset image in CSS filters (non-composited path)
https://bugs.webkit.org/show_bug.cgi?id=78626

Reviewed by Darin Adler.

Test: css3/filters/multiple-filters-invalidation.html

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::prepare):
When invalidating results, invalidate all intermediate filter
results, not just the last effect's result.

LayoutTests: New test to exercise invalidation of multiple CSS filters.
https://bugs.webkit.org/show_bug.cgi?id=78626

Reviewed by Darin Adler.

  • css3/filters/multiple-filters-invalidation-expected.txt: Added.
  • css3/filters/multiple-filters-invalidation.html: Added.
  • platform/mac-snowleopard/css3/filters/multiple-filters-invalidation-expected.png: Added.

TBR=senorblanco@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9429011

13:20 Changeset [108389] by ossy@webkit.org

[Qt] Unreviewed evening gardening after r108364.

  • platform/qt/fast/forms/float-before-fieldset-expected.png: Added.
  • platform/qt/fast/forms/float-before-fieldset-expected.txt: Updated.
13:14 Changeset [108388] by wjmaclean@chromium.org

[chromium] Enable compositor filter layout tests (except on mac and win debug)
https://bugs.webkit.org/show_bug.cgi?id=79111

Reviewed by Stephen White.

  • platform/chromium/test_expectations.txt:
13:08 Changeset [108387] by eric.carlson@apple.com

Set Referrer header for media downloads
https://bugs.webkit.org/show_bug.cgi?id=78614

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: http/tests/media/video-referer.html was modified to test this change.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerReferrer): New, return the document's referer.

  • html/HTMLMediaElement.h:
  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::referrer): New, return the client's mediaPlayerReferrer.

  • platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerReferrer):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Tell AVFoundation to add

a referer header.

LayoutTests:

  • http/tests/media/resources/video-referer-check-referer.php: Get the test file and content-type

from parameters on the url. Fail if referrer is anything but video-referer.html. Add support for
byte-range requests so it will work with AVFoundation.

  • http/tests/media/video-referer.html: Pass video file name and content-type as url parameters

instead of having another cgi set a cookie. Set the php script as the 'src' on a <source> element
instead of on the <video> element so we can also add a 'type' attribute.

12:58 Changeset [108386] by antti@apple.com

Not reviewed.

Remove some obsolete comments, use consistent name for propertyID.

  • css/StylePropertySet.h:

(StylePropertySet):

12:48 Changeset [108385] by antti@apple.com

Clean up StylePropertySet included headers
https://bugs.webkit.org/show_bug.cgi?id=79134

Reviewed by Andreas Kling.

Remove unneccesary includes.

  • bindings/js/JSDOMBinding.h:
  • css/StylePropertySet.cpp:
  • css/StylePropertySet.h:

(WebCore):
(StylePropertySet):

  • editing/RemoveCSSPropertyCommand.cpp:
12:43 Changeset [108384] by cfleizach@apple.com

AX: move aria-invalid test to top level, so other platforms can use it
https://bugs.webkit.org/show_bug.cgi?id=79041

Unreviewed. Forgot to update paths.

  • accessibility/aria-invalid.html:
12:10 Changeset [108383] by commit-queue@webkit.org

Fix bug from r107672.
https://bugs.webkit.org/show_bug.cgi?id=78773

Before set MediaStreamTrack disable/enable operation,
checking the status of MediaStream that contains this MediaStreamTrack.
if MediaStream is finished, then skipping operation of
didSetMediaStreamTrackEnabled().

Patch by Lin Wei <wei.a.lin@intel.com> on 2012-02-21
Reviewed by Adam Barth.

  • mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::setEnabled):

11:59 Changeset [108382] by jchaffraix@webkit.org

Move RenderLayer::scrolledContentOffset calls to a common function
https://bugs.webkit.org/show_bug.cgi?id=76971

Reviewed by David Hyatt.

Refactoring without any change in behavior.

This change adds a RenderBox::scrolledContentOffset function to handle all
the calls that goes through the layer(). This indirection will enable us to
add layer() checks without patching a lot of call sites as part of bug 75568.

We also moved down the concept of scroll offset down to RenderBox where it belongs!

  • rendering/RenderLayer.h:

(RenderLayer):
(WebCore::RenderLayer::scrolledContentOffset):
Moved scrolledContent to the private section of the class to prevent misuse.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::scrolledContentOffset):
New function to add an indirection with RenderLayer.

  • editing/visible_units.cpp:

(WebCore::absoluteLineDirectionPointToLocalPointInBlock):

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::paintObject):
(WebCore::RenderBlock::selectionGapRectsForRepaint):
(WebCore::RenderBlock::paintSelection):
(WebCore::RenderBlock::nodeAtPoint):
(WebCore::RenderBlock::offsetForContents):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::offsetFromContainer):
(WebCore::RenderBox::computeRectForRepaint):

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::clippedOverflowRectForRepaint):
(WebCore::RenderInline::computeRectForRepaint):
(WebCore::RenderInline::offsetFromContainer):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::computeRectForRepaint):
(WebCore::RenderObject::mapLocalToContainer):
(WebCore::RenderObject::mapAbsoluteToLocalPoint):
(WebCore::RenderObject::offsetFromContainer):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlInnerBlock::positionForPoint):
Patched all those call sites to use the new function.

11:55 Changeset [108381] by rafaelw@chromium.org

Add rafaelw as a committer.

Unreviewed.

  • Scripts/webkitpy/common/config/committers.py:
11:49 Changeset [108380] by tonikitoo@webkit.org

2012-02-18 Antonio Gomes <agomes@rim.com>

Fat fingers - cache the first rect-based hit test so we do not need to do it again
https://bugs.webkit.org/show_bug.cgi?id=79115

Reviewed by Adam Treat.

Our FatFingers implementation runs currently in two phases:
the first checks for the elements intrinsically clickable;
the second checks for elements made clickable by the page
(for example, a div with a onclick event listener attached to it).
For each phase, we perform a rect hittest, which is not needed since
the result of each is the same.

Patch introduces a caching mechanism so we avoid on rect hittest:
when the first phase runs, it caches each nodeset per document in
a hashmap. This second phase works with the cached results.

No behavioral change, but performance is better since we
avoid one (possibly expensive) rect hittest.

I measured the performance gain on https://www.kvd.se/, and we
save up to 0.04 seconds, by caching and re-using the results.

  • WebKitSupport/FatFingers.cpp: (BlackBerry::WebKit::dumpHitTestResult): (BlackBerry::WebKit::FatFingers::findBestPoint): (BlackBerry::WebKit::FatFingers::findIntersectingRegions): (BlackBerry::WebKit::FatFingers::cachingStrategy): (WebKit): (BlackBerry::WebKit::FatFingers::getNodesFromRect):
  • WebKitSupport/FatFingers.h:
11:41 Changeset [108379] by dpranke@chromium.org

webkitpy: update names after deleting message_broker
https://bugs.webkit.org/show_bug.cgi?id=79000

Reviewed by Eric Seidel.

Part 3 of 3 in deleting message_broker.py; this change just
adjusts the names for the newly merged symbols so that they are
private as appropriate.

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:

(get):
(_Broker):
(_BrokerConnection):
(_BrokerConnection.init):
(AbstractWorker.init):
(_ManagerConnection):
(_ManagerConnection.init):
(_WorkerConnection):
(_WorkerConnection.init):

11:33 Changeset [108378] by dpranke@chromium.org

webkitpy: merge message_broker.py into manager_worker_broker.py
https://bugs.webkit.org/show_bug.cgi?id=78999

Reviewed by Tony Chang.

This is pretty much a straight cut-and-paste of one file into
another (broken up so that docstrings and imports are in the
right place).

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:

(BrokerClient):
(BrokerClient.is_done):
(BrokerClient.name):
(Broker):
(Broker.init):
(Broker.add_topic):
(Broker._get_queue_for_topic):
(Broker.post_message):
(Broker.run_message_loop):
(Broker.run_all_pending):
(Broker._run_loop):
(Broker._dispatch_message):
(_Message):
(_Message.loads):
(_Message.init):
(_Message.dumps):
(_Message.repr):
(BrokerConnection):
(BrokerConnection.init):
(BrokerConnection.run_message_loop):
(BrokerConnection.post_message):
(BrokerConnection.raise_exception):

  • Scripts/webkitpy/layout_tests/controllers/message_broker.py: Removed.
11:33 Changeset [108377] by eae@chromium.org

Remove obsolete float comparison FIXMEs
https://bugs.webkit.org/show_bug.cgi?id=79127

Reviewed by Eric Seidel.

Remove obsolete FIXME comments added back when we were planning to use
floating point units for layout.

No new tests, no code changes.

  • page/FrameView.cpp:

(WebCore::FrameView::init):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats):
(WebCore::RenderBlock::getClearDelta):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computeLogicalHeightUsing):
(WebCore::RenderBox::computePercentageLogicalHeight):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::ImageQualityController::shouldPaintAtLowQuality):

11:28 Changeset [108376] by dpranke@chromium.org

webkitpy: prepare to delete message_broker.py
https://bugs.webkit.org/show_bug.cgi?id=78997

Reviewed by Eric Seidel.

This is part 1 of 3 changes to fix bug 78187. This change
prepares the code for merging message_broker.py into
manager_worker_broker.py; the tests in message_broker_unittest
are merged into manager_worker_broker_unittest, the symbols
needed by the tests are exported from manager_worker_broker.py,
and manager_worker_broker itself is updated to refer to the
symbols directly (without the module prefix).

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:

(get):
(AbstractWorker):
(AbstractWorker.init):
(_ManagerConnection):
(_ManagerConnection.init):
(_WorkerConnection):
(_WorkerConnection.init):

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:

(InterfaceTest.test_brokerclient_is_abstract):
(InterfaceTest.test_brokerclient_is_abstract.methods):
(MessageTest):
(MessageTest.testno_body):
(MessageTest.test
body):

  • Scripts/webkitpy/layout_tests/controllers/message_broker_unittest.py: Removed.
11:25 Changeset [108375] by dgrogan@chromium.org

IndexedDB: webFrame isn't threadsafe, don't use it from a worker thread
https://bugs.webkit.org/show_bug.cgi?id=78659

After crrev.com/121669, indexed db doesn't use the web frame for
anything if called from a web worker.

No new tests - this check was defensive and possibly not ever
triggered.

Reviewed by Tony Chang.

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::openFromWorker):

11:17 Changeset [108374] by apavlov@chromium.org

Web Inspector: it is nearly impossible to select and copy text on the Elements panel.
https://bugs.webkit.org/show_bug.cgi?id=60814

Reviewed by Pavel Feldman.

  • inspector/front-end/inspector.js:

(WebInspector.documentClick.followLink):
(WebInspector.documentClick):

11:13 Changeset [108373] by cfleizach@apple.com

AX: move aria-invalid test to top level, so other platforms can use it
https://bugs.webkit.org/show_bug.cgi?id=79041

Reviewed by David Kilzer.

  • accessibility/aria-invalid-expected.txt: Copied from LayoutTests/platform/mac/accessibility/aria-invalid-expected.txt.
  • accessibility/aria-invalid.html: Copied from LayoutTests/platform/mac/accessibility/aria-invalid.html.
  • platform/gtk/Skipped:
  • platform/mac/accessibility/aria-invalid-expected.txt: Removed.
  • platform/mac/accessibility/aria-invalid.html: Removed.
  • platform/win/Skipped:
11:10 Changeset [108372] by inferno@chromium.org

Crash in RenderTableSection::nodeAtPoint.
https://bugs.webkit.org/show_bug.cgi?id=78922

Reviewed by Julien Chaffraix.

Source/WebCore:

Test: fast/table/table-section-node-at-point-crash.html

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::nodeAtPoint): recalc cells if the
m_needsCellRecalc is set. Otherwise, we will end up accessing
removed table cells.

LayoutTests:

  • fast/table/table-section-node-at-point-crash-expected.txt: Added.
  • fast/table/table-section-node-at-point-crash.html: Added.
10:54 Changeset [108371] by jamesr@google.com

[chromium] Unreviewed, update chromium leopard baselines for r108364

  • platform/chromium-mac-leopard/fast/block/float/centered-float-avoidance-complexity-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/shrink-to-avoid-float-complexity-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/float-before-fieldset-expected.png:
10:46 WebKitIDL edited by arv@chromium.org
(diff)
10:38 Changeset [108370] by antti@apple.com

Move PropertySetCSSStyleDeclaration to a file of its own
https://bugs.webkit.org/show_bug.cgi?id=79121

Rubber-stamped by Andreas Kling.

This makes StylePropertySet.cpp more readable.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/PropertySetCSSStyleDeclaration.cpp: Copied from Source/WebCore/css/StylePropertySet.cpp.

(WebCore::PropertySetCSSStyleDeclaration::ref):
(WebCore::PropertySetCSSStyleDeclaration::deref):
(WebCore):

  • css/PropertySetCSSStyleDeclaration.h: Added.

(WebCore):
(PropertySetCSSStyleDeclaration):
(WebCore::PropertySetCSSStyleDeclaration::PropertySetCSSStyleDeclaration):
(WebCore::PropertySetCSSStyleDeclaration::parentElement):
(WebCore::PropertySetCSSStyleDeclaration::clearParentRule):
(WebCore::PropertySetCSSStyleDeclaration::clearParentElement):
(WebCore::PropertySetCSSStyleDeclaration::contextStyleSheet):
(WebCore::PropertySetCSSStyleDeclaration::setNeedsStyleRecalc):
(RuleCSSStyleDeclaration):
(WebCore::RuleCSSStyleDeclaration::RuleCSSStyleDeclaration):
(WebCore::RuleCSSStyleDeclaration::parentRule):
(WebCore::RuleCSSStyleDeclaration::clearParentRule):
(InlineCSSStyleDeclaration):
(WebCore::InlineCSSStyleDeclaration::InlineCSSStyleDeclaration):
(WebCore::InlineCSSStyleDeclaration::parentElement):
(WebCore::InlineCSSStyleDeclaration::clearParentElement):

  • css/StylePropertySet.cpp:

(WebCore):

10:24 Changeset [108369] by paroga@webkit.org

Unnecessary preprocessor macros in MainThread.h/cpp
https://bugs.webkit.org/show_bug.cgi?id=79083

Removed invalid/wrong PLATFORM(WINDOWS) preprocessor macro.

Patch by Roland Takacs <takacs.roland@stud.u-szeged.hu> on 2012-02-21

  • wtf/MainThread.cpp:

(WTF):

  • wtf/MainThread.h:

(WTF):

10:22 Changeset [108368] by jamesr@google.com

[chromium] Unreviewed, update chromium baselines for r108364

  • platform/chromium-linux/fast/block/float/centered-float-avoidance-complexity-expected.png: Added.
  • platform/chromium-linux/fast/block/float/shrink-to-avoid-float-complexity-expected.png: Added.
  • platform/chromium-linux/fast/forms/float-before-fieldset-expected.png:
  • platform/chromium-mac-snowleopard/fast/block/float/centered-float-avoidance-complexity-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/float/shrink-to-avoid-float-complexity-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/float-before-fieldset-expected.png: Added.
  • platform/chromium-mac/fast/forms/float-before-fieldset-expected.png: Removed.
  • platform/chromium-win/fast/block/float/centered-float-avoidance-complexity-expected.png: Added.
  • platform/chromium-win/fast/block/float/centered-float-avoidance-complexity-expected.txt: Added.
  • platform/chromium-win/fast/block/float/shrink-to-avoid-float-complexity-expected.png: Added.
  • platform/chromium-win/fast/block/float/shrink-to-avoid-float-complexity-expected.txt: Added.
  • platform/chromium-win/fast/forms/float-before-fieldset-expected.png:
  • platform/chromium-win/fast/forms/float-before-fieldset-expected.txt:
10:20 Changeset [108367] by commit-queue@webkit.org

[GTK] WebAudio build is broken
https://bugs.webkit.org/show_bug.cgi?id=79113

Patch by Philippe Normand <pnormand@igalia.com> on 2012-02-21
Reviewed by Martin Robinson.

  • platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(webKitWebAudioGStreamerChannelPosition): Set a default value for
the position variable.

  • platform/audio/gtk/AudioBusGtk.cpp: Include CString.h, needed

for sharedResourcesPath().

10:00 Changeset [108366] by kling@webkit.org

Kill FontFamilyValue.
<http://webkit.org/b/79103>

Reviewed by Antti Koivisto.

Source/WebCore:

Remove FontFamilyValue and replace all usage by CSSPrimitiveValue.
The class was only used to filter font family names, removing bracketed
suffixes, e.g "[Xft]".

This was added to KHTML in 2002 to support the use of specific X11 font
families inside KMail: <https://bugs.kde.org/show_bug.cgi?id=38808>

Test: fast/css/font-family-trailing-bracket-gunk.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):

  • css/CSSParser.cpp:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • css/CSSValue.cpp:

(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

  • css/CSSValue.h:
  • css/CSSValuePool.cpp:

(WebCore::CSSValuePool::createFontFamilyValue):

  • css/CSSValuePool.h:

(CSSValuePool):

  • css/FontFamilyValue.cpp: Removed.
  • css/FontFamilyValue.h: Removed.

LayoutTests:

  • fast/css/font-family-trailing-bracket-gunk-expected.txt: Added.
  • fast/css/font-family-trailing-bracket-gunk.html: Added.
09:35 Changeset [108365] by alexis.menard@openbossa.org

Little optimization for CSSParser::parseFillShorthand.
https://bugs.webkit.org/show_bug.cgi?id=79042

Reviewed by Hajime Morita.

Remove one extra loop that we can combine with the following one
which adds the properties to the parser's list of properties. I also
removed a useless check.
Instruments shows on the css-parser-yui benchmark an improvement
of 13ms (from 77ms spent in the function to 64ms).

No new tests : refactoring, existings tests should cover.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFillShorthand):

09:17 Changeset [108364] by hyatt@apple.com

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=79046

width of overflow:hidden blocks is wrong when their margins overlap floats.

Relevant discussion is here: http://lists.w3.org/Archives/Public/www-style/2012Feb/0954.html

This patch makes the following changes to how objects shrink when avoiding floats:
(1) The containing block width used for percentage calculations is now constant. This means that
an overflow:hidden block with a margin-left of 10% will no longer change what 10% means depending
on the available line width. From a code perspective, containingBlockLogicalWidthForContent and
containingBlockLogicalWidthForContentInRegion no longer contain any special-case code for
shrinkToAvoidFloats() objects.

(2) Now the computation of the logical width for the shrinking object itself handles the adjustments.
Two kinds of adjustments are made for both the start and end margins. Conceptually what we do is shrink
the object to the available line width minus our margins, and then expand the width back out to the content edge
or to the float edge as necessary. If the float fully fits in the margin, then we expand back out to the
content edge. Otherwise if the float doesn't fit, then we expand only to the float edge, making sure our
margin overlaps with the float. This expansion is not performed for negative margins, since our result is already
correct in that case.

Reviewed by Dan Bernstein.

Added the new tests from the thread on www-style about this issue (from Alan Gresley and George Talbot)
in fast/block/float.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::containsFloat):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::containsFloats):
Changed to be const.

(WebCore::RenderBlock::endOffsetForLine):
(WebCore::RenderBlock::endOffsetForContent):
Added endOffsetForXXX methods to mirror their startOffset counterparts. Used by the width adjustment code.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats):
New method that handles shrinking the logical width to the line width (and then re-expanding back out to the
float and/or content edges as needed).

(WebCore::RenderBox::containingBlockLogicalWidthForContent):
(WebCore::RenderBox::containingBlockLogicalWidthForContentInRegion):
Patched to no longer do the shrinking of objects to avoid floats.

(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
Patched to handle calling the new shrinking code to adjust our logical width.

  • rendering/RenderBox.h:

(RenderBox):
The signature of computeLogicalWithUsing changed to be region-specific and to carry along enough information
to efficiently perform the shrinking.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth):
Patched to handle calling the new shrinking code to adjust our logical width.

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=79046

width of overflow:hidden blocks is wrong when their margins overlap floats.

Added new tests from www-style thread: http://lists.w3.org/Archives/Public/www-style/2012Feb/0954.html

Reviewed by Dan Bernstein.

  • fast/block/float/centered-float-avoidance-complexity.html: Added.
  • fast/block/float/shrink-to-avoid-float-complexity.html: Added.
  • platform/mac/fast/block/float/centered-float-avoidance-complexity-expected.png: Added.
  • platform/mac/fast/block/float/centered-float-avoidance-complexity-expected.txt: Added.
  • platform/mac/fast/block/float/shrink-to-avoid-float-complexity-expected.png: Added.
  • platform/mac/fast/block/float/shrink-to-avoid-float-complexity-expected.txt: Added.
09:01 Changeset [108363] by weinig@apple.com

Attempt to fix the Snow Leopard build.

Source/JavaScriptCore:

  • Configurations/Base.xcconfig:

Source/ThirdParty:

  • gtest/xcode/Config/General.xcconfig:

Source/ThirdParty/ANGLE:

  • Configurations/Base.xcconfig:

Source/WebCore:

  • Configurations/Base.xcconfig:

Source/WebKit/mac:

  • Configurations/Base.xcconfig:

Source/WebKit2:

  • Configurations/Base.xcconfig:

Tools:

  • DumpRenderTree/mac/Configurations/Base.xcconfig:
  • MiniBrowser/Configurations/Base.xcconfig:
  • TestWebKitAPI/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/Base.xcconfig:
08:49 Changeset [108362] by ossy@webkit.org

[Qt] Unreviewed gardening, add platform specific expected file after r107689.

  • platform/qt-5.0-wk2/http/tests/websocket/test/hybi/bad-sub-protocol-non-ascii-expected.txt: Added.
08:44 Changeset [108361] by weinig@apple.com

Use libc++ when building with Clang on Mac
https://bugs.webkit.org/show_bug.cgi?id=78981

Reviewed by Dan Bernstein.

Source/JavaScriptCore:

  • Configurations/Base.xcconfig:

Source/ThirdParty:

  • gtest/xcode/Config/General.xcconfig:

In addition to enabling libc++ when building with Clang,
disable gtest's use of tr1::tuple, which doesn't exist in
libc++.

Source/ThirdParty/ANGLE:

  • Configurations/Base.xcconfig:

Source/WebCore:

  • Configurations/Base.xcconfig:

Source/WebKit/mac:

  • Configurations/Base.xcconfig:

Source/WebKit2:

  • Configurations/Base.xcconfig:

Tools:

  • DumpRenderTree/mac/Configurations/Base.xcconfig:
  • MiniBrowser/Configurations/Base.xcconfig:
  • TestWebKitAPI/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/Base.xcconfig:
08:38 Changeset [108360] by aroben@apple.com

Mac build fix

  • WebCore.xcodeproj/project.pbxproj: Mark TextTrack.h and TextTrackCue.h private so that

WebKit can include them.

08:26 Changeset [108359] by abecsi@webkit.org

[Qt][WK2] Fix the N9 build
https://bugs.webkit.org/show_bug.cgi?id=79101

Reviewed by Noam Rosenthal.

No new tests needed.

  • platform/graphics/opengl/TextureMapperGL.cpp: Add missing include.
08:26 Changeset [108358] by aroben@apple.com

Roll out r108309, r108323, and r108326

They broke the 32-bit Lion build.

Original bugs is <http://webkit.org/b/75812> <rdar://problem/10079694>.

Source/JavaScriptCore:

  • CMakeLists.txt:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
  • JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • assembler/LinkBuffer.h:
  • assembler/MacroAssemblerCodeRef.h:
  • bytecode/BytecodeConventions.h: Removed.
  • bytecode/CallLinkStatus.cpp:
  • bytecode/CallLinkStatus.h:
  • bytecode/CodeBlock.cpp:
  • bytecode/CodeBlock.h:
  • bytecode/GetByIdStatus.cpp:
  • bytecode/GetByIdStatus.h:
  • bytecode/Instruction.h:
  • bytecode/LLIntCallLinkInfo.h: Removed.
  • bytecode/MethodCallLinkStatus.cpp:
  • bytecode/Opcode.cpp:
  • bytecode/Opcode.h:
  • bytecode/PutByIdStatus.cpp:
  • bytecode/PutByIdStatus.h:
  • bytecompiler/BytecodeGenerator.cpp:
  • dfg/DFGByteCodeParser.cpp:
  • dfg/DFGCapabilities.h:
  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOperations.cpp:
  • heap/Heap.h:
  • heap/MarkStack.cpp:
  • heap/MarkedAllocator.h:
  • heap/MarkedSpace.h:
  • interpreter/CallFrame.cpp:
  • interpreter/CallFrame.h:
  • interpreter/Interpreter.cpp:
  • interpreter/Interpreter.h:
  • interpreter/RegisterFile.h:
  • jit/ExecutableAllocator.h:
  • jit/HostCallReturnValue.cpp: Removed.
  • jit/HostCallReturnValue.h: Removed.
  • jit/JIT.cpp:
  • jit/JITCode.h:
  • jit/JITDriver.h:
  • jit/JITExceptions.cpp:
  • jit/JITInlineMethods.h:
  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
  • jit/JSInterfaceJIT.h:
  • llint/LLIntCommon.h: Removed.
  • llint/LLIntData.cpp: Removed.
  • llint/LLIntData.h: Removed.
  • llint/LLIntEntrypoints.cpp: Removed.
  • llint/LLIntEntrypoints.h: Removed.
  • llint/LLIntExceptions.cpp: Removed.
  • llint/LLIntExceptions.h: Removed.
  • llint/LLIntOfflineAsmConfig.h: Removed.
  • llint/LLIntOffsetsExtractor.cpp: Removed.
  • llint/LLIntSlowPaths.cpp: Removed.
  • llint/LLIntSlowPaths.h: Removed.
  • llint/LLIntThunks.cpp: Removed.
  • llint/LLIntThunks.h: Removed.
  • llint/LowLevelInterpreter.asm: Removed.
  • llint/LowLevelInterpreter.cpp: Removed.
  • llint/LowLevelInterpreter.h: Removed.
  • offlineasm/armv7.rb: Removed.
  • offlineasm/asm.rb: Removed.
  • offlineasm/ast.rb: Removed.
  • offlineasm/backends.rb: Removed.
  • offlineasm/generate_offset_extractor.rb: Removed.
  • offlineasm/instructions.rb: Removed.
  • offlineasm/offset_extractor_constants.rb: Removed.
  • offlineasm/offsets.rb: Removed.
  • offlineasm/opt.rb: Removed.
  • offlineasm/parser.rb: Removed.
  • offlineasm/registers.rb: Removed.
  • offlineasm/self_hash.rb: Removed.
  • offlineasm/settings.rb: Removed.
  • offlineasm/transform.rb: Removed.
  • offlineasm/x86.rb: Removed.
  • runtime/CodeSpecializationKind.h: Removed.
  • runtime/CommonSlowPaths.h:
  • runtime/Executable.cpp:
  • runtime/Executable.h:
  • runtime/ExecutionHarness.h: Removed.
  • runtime/JSArray.h:
  • runtime/JSCell.h:
  • runtime/JSFunction.h:
  • runtime/JSGlobalData.cpp:
  • runtime/JSGlobalData.h:
  • runtime/JSGlobalObject.h:
  • runtime/JSObject.h:
  • runtime/JSPropertyNameIterator.h:
  • runtime/JSString.h:
  • runtime/JSTypeInfo.h:
  • runtime/JSValue.cpp:
  • runtime/JSValue.h:
  • runtime/JSVariableObject.h:
  • runtime/Options.cpp:
  • runtime/Options.h:
  • runtime/ScopeChain.h:
  • runtime/Structure.cpp:
  • runtime/Structure.h:
  • runtime/StructureChain.h:
  • wtf/InlineASM.h:
  • wtf/Platform.h:
  • wtf/SentinelLinkedList.h:
  • wtf/text/StringImpl.h:

Source/WebCore:

  • CMakeLists.txt:

Source/WebKit:

  • CMakeLists.txt:

Tools:

  • DumpRenderTree/efl/CMakeLists.txt:
08:20 Changeset [108357] by ossy@webkit.org

[Qt]REGRESSION(r92254): It made 2 tests timeout
https://bugs.webkit.org/show_bug.cgi?id=65609

  • platform/qt/Skipped: Unskip now passing tests.
08:17 Changeset [108356] by apavlov@chromium.org

Web Inspector: [SuggestBox] textPrompt.css disablement displays garbled suggest box
https://bugs.webkit.org/show_bug.cgi?id=79107

Reviewed by Pavel Feldman.

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.SuggestBox):
(WebInspector.TextPrompt.SuggestBox.prototype.get visible):
(WebInspector.TextPrompt.SuggestBox.prototype.hide):
(WebInspector.TextPrompt.SuggestBox.prototype.removeFromElement):
(WebInspector.TextPrompt.SuggestBox.prototype._completionsReady):

  • inspector/front-end/textPrompt.css:

(.suggest-box):

08:14 Changeset [108355] by yurys@chromium.org

Web Inspector: timeline hangs on a page with deep chain of nested events.
https://bugs.webkit.org/show_bug.cgi?id=79106

Use stack of states instead of recursive calls when traversing records tree to
avoid stack overflow.

Reviewed by Pavel Feldman.

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane.prototype._forAllRecords):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._filterRecords):

07:56 Changeset [108354] by pfeldman@chromium.org

Web Inspector: [crash] upon style modification after navigation
https://bugs.webkit.org/show_bug.cgi?id=79108

Reviewed by Yury Semikhatsky.

  • inspector/InspectorHistory.cpp:

(WebCore::InspectorHistory::undo):
(WebCore::InspectorHistory::redo):
(WebCore::InspectorHistory::reset):

07:52 Changeset [108353] by paroga@webkit.org

Use WTF::cryptographicallyRandomValues in FileSystemWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=79089

Reviewed by Adam Roben.

Avoid loading and unloading of the crypto library during every
call to openTemporaryFile() and make the code easier.

  • platform/win/FileSystemWin.cpp:

(WebCore::openTemporaryFile):

07:31 Changeset [108352] by ossy@webkit.org

Remove stylesheet pointer from StylePropertySet
https://bugs.webkit.org/show_bug.cgi?id=79092

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2012-02-21
Reviewed by Csaba Osztrogonác.

Qt buildfix after r108345.

  • css/CSSParser.cpp:

(WebCore::parseColorValue):

07:14 Changeset [108351] by ossy@webkit.org

Remove stylesheet pointer from StylePropertySet
https://bugs.webkit.org/show_bug.cgi?id=79092

Reviewed by Antti Koivisto.

Qt buildfix after r108345. We need this workaround because of buggy gcc (4.4.5), which
reported a false warning: 'value$m_ptr' may be used uninitialized in this function

  • css/CSSParser.cpp:

(WebCore::parseSimpleLengthValue):

06:39 WebKitGTK/1.8.x edited by kov@webkit.org
merged Does not build on IA64, SPARC and Alpha (diff)
06:37 Changeset [108350] by kling@webkit.org

Shrink attribute style property sets after populating them.
<http://webkit.org/b/78972>

Reviewed by Antti Koivisto.

Add a StylePropertySet::shrinkToFit() and call it at the end of updateStyleAttribute()
to minimize the amount of wasted space.

  • css/StylePropertySet.h:

(WebCore::StylePropertySet::shrinkToFit):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::updateAttributeStyle):

06:33 WebKitEFLLayoutTest edited by gyuyoung.kim@samsung.com
Modify build options to build WebKit EFL (diff)
06:20 Changeset [108349] by ossy@webkit.org

[Qt] Unreviewed gardening, skip new failing and crashing test to paint the bot green.

  • platform/qt-mac/Skipped:
06:09 Changeset [108348] by kov@webkit.org

Merging r108347

06:06 Changeset [108347] by kov@webkit.org

Does not build on IA64, SPARC and Alpha
https://bugs.webkit.org/show_bug.cgi?id=79047

Patch by Gustavo Noronha Silva <kov@debian.org> and Bob Tracy <rct@frus.com> on 2012-02-21
Rubber-stamped by Kent Tamura.

  • wtf/dtoa/utils.h: these architectures also have correct double

operations, so add them to the appropriate side of the check.

05:53 Changeset [108346] by ossy@webkit.org

[Qt] Unreviewed gardening, unskip now passing tests.

  • platform/qt-4.8/Skipped:
  • platform/qt-5.0-wk2/Skipped:
  • platform/wk2/Skipped:
05:49 Changeset [108345] by antti@apple.com

Remove stylesheet pointer from StylePropertySet
https://bugs.webkit.org/show_bug.cgi?id=79092

Reviewed by Andreas Kling.

The context should be passed as an argument for CSS parser invoking setters that actually need it.

  • Remove the context stylesheet pointer.
  • Add context stylesheet argument to setters.
  • Drop an unnecessary StylePropertySet constructor, pass strict parsing flag directly.
  • Adapt to changes by passing in the context stylesheet where needed.
  • Add StyledElement::applyPresentationAttributeToStyle helpers for building up the attribute style.
  • css/CSSFontFaceRule.cpp:

(WebCore::CSSFontFaceRule::addSubresourceStyleURLs):

  • css/CSSParser.cpp:

(WebCore::parseColorValue):
(WebCore::parseSimpleLengthValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseDeclaration):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createKeyframeRule):

  • css/CSSParser.h:

(CSSParser):

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::addSubresourceStyleURLs):

  • css/StylePropertySet.cpp:

(WebCore::PropertySetCSSStyleDeclaration::contextStyleSheet):
(WebCore::PropertySetCSSStyleDeclaration::setNeedsStyleRecalc):
(RuleCSSStyleDeclaration):
(InlineCSSStyleDeclaration):
(WebCore):
(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet::parseDeclaration):
(WebCore::StylePropertySet::addSubresourceStyleURLs):
(WebCore::StylePropertySet::clearParentRule):
(WebCore::StylePropertySet::clearParentElement):
(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
(WebCore::PropertySetCSSStyleDeclaration::parentStyleSheet):
(WebCore::RuleCSSStyleDeclaration::setNeedsStyleRecalc):
(WebCore::RuleCSSStyleDeclaration::contextStyleSheet):
(WebCore::InlineCSSStyleDeclaration::contextStyleSheet):
(SameSizeAsStylePropertySet):

  • css/StylePropertySet.h:

(WebCore::StylePropertySet::create):
(StylePropertySet):

  • css/WebKitCSSMatrix.cpp:

(WebCore::WebKitCSSMatrix::setMatrixValue):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::ensureInlineStyleDecl):

  • dom/StyledElement.cpp:

(WebCore):
(WebCore::StyledElement::parseAttribute):
(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::addSubresourceAttributeURLs):
(WebCore::StyledElement::updateAttributeStyle):

  • dom/StyledElement.h:

(StyledElement):
(WebCore::StyledElement::applyPresentationAttributeToStyle):
(WebCore):

  • html/HTMLBRElement.cpp:

(WebCore::HTMLBRElement::collectStyleForAttribute):

  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::collectStyleForAttribute):

  • html/HTMLDivElement.cpp:

(WebCore::HTMLDivElement::collectStyleForAttribute):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::applyBorderAttributeToStyle):
(WebCore::HTMLElement::mapLanguageAttributeToLocale):
(WebCore::HTMLElement::collectStyleForAttribute):
(WebCore::HTMLElement::applyAlignmentAttributeToStyle):
(WebCore::HTMLElement::addHTMLLengthToStyle):
(WebCore::HTMLElement::addHTMLColorToStyle):

  • html/HTMLElement.h:

(HTMLElement):

  • html/HTMLFontElement.cpp:

(WebCore::HTMLFontElement::collectStyleForAttribute):

  • html/HTMLHRElement.cpp:

(WebCore::HTMLHRElement::collectStyleForAttribute):

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::collectStyleForAttribute):

  • html/HTMLLIElement.cpp:

(WebCore::HTMLLIElement::collectStyleForAttribute):

  • html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::collectStyleForAttribute):

  • html/HTMLOListElement.cpp:

(WebCore::HTMLOListElement::collectStyleForAttribute):

  • html/HTMLParagraphElement.cpp:

(WebCore::HTMLParagraphElement::collectStyleForAttribute):

  • html/HTMLTableCaptionElement.cpp:

(WebCore::HTMLTableCaptionElement::collectStyleForAttribute):

  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::collectStyleForAttribute):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::collectStyleForAttribute):

  • html/HTMLTablePartElement.cpp:

(WebCore::HTMLTablePartElement::collectStyleForAttribute):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::collectStyleForAttribute):

  • html/HTMLUListElement.cpp:

(WebCore::HTMLUListElement::collectStyleForAttribute):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setFont):

  • mathml/MathMLElement.cpp:

(WebCore::MathMLElement::collectStyleForAttribute):

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::insertedIntoDocument):
(WebCore::SVGFontFaceElement::removedFromDocument):
(WebCore::SVGFontFaceElement::removeFromMappedElementSheet):

  • svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::collectStyleForAttribute):

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::collectStyleForAttribute):

  • svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::collectStyleForAttribute):

05:10 Changeset [108344] by yurys@chromium.org

[V8] Web Inspector: set breakpoint/pause doesn't work when worker is in a tight loop
https://bugs.webkit.org/show_bug.cgi?id=79097

Source/WebCore:

Worker script will be interrupted to dispatch all arriving inspector commands.
This way debugger will be operable even if worker is in a tight loop.

Reviewed by Pavel Feldman.

  • bindings/js/ScriptDebugServer.h:

(Task):
(WebCore::ScriptDebugServer::Task::~Task):
(ScriptDebugServer):

  • bindings/js/WorkerScriptDebugServer.cpp:

(WebCore::WorkerScriptDebugServer::interruptAndRunTask):
(WebCore):

  • bindings/js/WorkerScriptDebugServer.h:

(WorkerScriptDebugServer):

  • bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::interruptAndRun):

  • bindings/v8/ScriptDebugServer.h:

(ScriptDebugServer):

  • bindings/v8/WorkerScriptDebugServer.cpp:

(WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
(WebCore::WorkerScriptDebugServer::interruptAndRunTask):
(WebCore):

  • bindings/v8/WorkerScriptDebugServer.h:

(v8):
(WebCore):
(WorkerScriptDebugServer):

  • inspector/WorkerDebuggerAgent.cpp:

(WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):
(WebCore::WorkerDebuggerAgent::~WorkerDebuggerAgent):
(WebCore):
(WebCore::WorkerDebuggerAgent::interruptAndDispatchInspectorCommands):

  • inspector/WorkerDebuggerAgent.h:

(WebCore):
(WorkerDebuggerAgent):

  • workers/WorkerMessagingProxy.cpp:

(WebCore):
(WebCore::WorkerMessagingProxy::sendMessageToInspector):

  • workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::run):
(WebCore::WorkerRunLoop::runInMode):

  • workers/WorkerRunLoop.h:

(WorkerRunLoop):

Source/WebKit/chromium:

Worker script execution will be interrupted for dispatching inspector commands.

Reviewed by Pavel Feldman.

  • src/WebSharedWorkerImpl.cpp:

(WebKit::WebSharedWorkerImpl::dispatchDevToolsMessage):

05:05 Changeset [108343] by ossy@webkit.org

[Qt] 3 SVG tests assert after r107207
https://bugs.webkit.org/show_bug.cgi?id=78332

  • platform/qt/Skipped: Skip 3 more asserting test.
04:38 Changeset [108342] by ossy@webkit.org

[Qt] REGRESSION(r108112): sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.2_decodeURIComponent/S15.1.3.2_A1.2_T2.html crashes intermittently
https://bugs.webkit.org/show_bug.cgi?id=79029

  • platform/qt/Skipped: Skip new crashing test.
04:34 Changeset [108341] by ossy@webkit.org

[Qt] tst_QWebPage::infiniteLoopJS() timeouts with DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=79040

Reviewed by Simon Hausmann.

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage): Disable tst_QWebPage::infiniteLoopJS() until proper fix.

04:26 Changeset [108340] by pfeldman@chromium.org

Not reviewed: fixing Mac build (take 2).

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::setShowPaintRects):

04:16 Changeset [108339] by philn@webkit.org

Unreviewed, skip new failing mediastream test on GTK.

  • platform/gtk/Skipped:
04:13 Changeset [108338] by pfeldman@chromium.org

Not reviewed: fixing Mac build.

  • inspector/DOMNodeHighlighter.cpp:

(WebCore::DOMNodeHighlighter::drawOutline):

  • inspector/DOMNodeHighlighter.h:

(DOMNodeHighlighter):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willPaintImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willPaint):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::willPaint):
(WebCore::InspectorPageAgent::didPaint):

  • inspector/InspectorPageAgent.h:
04:04 Changeset [108337] by vsevik@chromium.org

Web Inspector: Switch Debugger agent to TypeBuilder
https://bugs.webkit.org/show_bug.cgi?id=78390

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-21
Reviewed by Vsevolod Vlasov.

Client code is switched to TypeBuilder.

  • inspector/CodeGeneratorInspector.py:
  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::getFunctionDetails):
(WebCore::InjectedScript::getProperties):
(WebCore::InjectedScript::wrapCallFrames):

  • inspector/InjectedScript.h:

(InjectedScript):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::getFunctionDetails):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::currentCallFrames):
(WebCore::InspectorDebuggerAgent::didParseSource):

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

04:00 Changeset [108336] by pfeldman@chromium.org

Not reviewed: fixing poor merge in r108332.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.prototype._handleSelectorClick):

  • inspector/front-end/externs.js:
03:47 Changeset [108335] by apavlov@chromium.org

Web Inspector: [Styles] Rule source URL tooltip should show line number
https://bugs.webkit.org/show_bug.cgi?id=79087

Reviewed by Pavel Feldman.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection):
(WebInspector.StylePropertiesSection.prototype._createRuleOriginNode):

03:46 Changeset [108334] by philn@webkit.org

Fix one more GTK+ unit test after r108278.

Reviewed by Alejandro G. Castro.

  • tests/testkeyevents.c:

(map_event_cb): No longer grab focus here.
(setup_keyevent_test): Grabbing focus here seems to be late enough in the process.

03:34 Changeset [108333] by commit-queue@webkit.org

[Qt] Print warning when importing experimental WK2 APIs in QML
https://bugs.webkit.org/show_bug.cgi?id=78817

Patch by Andras Becsi <andras.becsi@nokia.com> on 2012-02-21
Reviewed by Simon Hausmann.

  • declarative/experimental/plugin.cpp:
03:32 Changeset [108332] by pfeldman@chromium.org

Web Inspector: clicking empty space should not re-enter edit mode
https://bugs.webkit.org/show_bug.cgi?id=79024

Patch by Pavel Feldman <pfeldman@chomium.org> on 2012-02-21
Reviewed by Vsevolod Vlasov.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection):
(WebInspector.StylePropertiesSection.prototype._handleEmptySpaceMouseDown):
(WebInspector.StylePropertiesSection.prototype._handleEmptySpaceClick):

03:30 Changeset [108331] by pfeldman@chromium.org

Web Inspector: evaluate on hover does not work for large files.
https://bugs.webkit.org/show_bug.cgi?id=79015

Patch by Pavel Feldman <pfeldman@chomium.org> on 2012-02-21
Reviewed by Yury Semikhatsky.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype._getPopoverAnchor):
(WebInspector.JavaScriptSourceFrame.prototype._highlightExpression):

  • inspector/front-end/Popover.js:

(WebInspector.PopoverHelper.prototype._handleMouseAction):

  • inspector/front-end/SourceJavaScriptTokenizer.js:

(WebInspector.SourceJavaScriptTokenizer):
(WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):

  • inspector/front-end/SourceJavaScriptTokenizer.re2js:
03:28 Changeset [108330] by pfeldman@chromium.org

Web Inspector: add "show paint rectangles" setting.
https://bugs.webkit.org/show_bug.cgi?id=79030

Reviewed by Yury Semikhatsky.

  • English.lproj/localizedStrings.js:
  • inspector/DOMNodeHighlighter.cpp:

(WebCore::DOMNodeHighlighter::drawOutline):
(DOMNodeHighlighter):

  • inspector/DOMNodeHighlighter.h:

(WebCore):
(DOMNodeHighlighter):

  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willPaintImpl):
(WebCore::InspectorInstrumentation::didPaintImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willPaint):

  • inspector/InspectorPageAgent.cpp:

(PageAgentState):
(WebCore::InspectorPageAgent::create):
(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::setShowPaintRects):
(WebCore):
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
(WebCore::InspectorPageAgent::willPaint):
(WebCore::InspectorPageAgent::didPaint):
(WebCore::InspectorPageAgent::buildObjectForFrame):

  • inspector/InspectorPageAgent.h:

(WebCore):

  • inspector/front-end/Settings.js:

(WebInspector.Settings):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):
(WebInspector.SettingsScreen.prototype._showPaintRectsChanged):

  • inspector/front-end/inspector.js:
  • page/FrameView.cpp:

(WebCore::FrameView::paintContents):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintContents):

03:26 Changeset [108329] by abecsi@webkit.org

[Qt] Clean-up project file after r108310

Reviewed by Csaba Osztrogonác.

No new tests needed.

  • Target.pri: Fix path for TextTrack headers.
02:57 Changeset [108328] by abecsi@webkit.org

[Qt][WK2] Get rid of the dependency to QtWidgets
https://bugs.webkit.org/show_bug.cgi?id=76276

Reviewed by Simon Hausmann.

Source/WebKit2:

  • Target.pri:
  • UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp:

(main):

  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
  • UIProcess/API/qt/tests/tests.pri:
  • UIProcess/API/qt/tests/util.h:

Tools:

  • MiniBrowser/qt/MiniBrowser.pro:
  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::MiniBrowserApplication):
(MiniBrowserApplication::notify):
(MiniBrowserApplication::sendTouchEvent):

  • MiniBrowser/qt/MiniBrowserApplication.h:

(MiniBrowserApplication):

  • QtTestBrowser/locationedit.h:
  • WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:

(WTR::activateFonts):

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:
02:33 Changeset [108327] by philn@webkit.org

[GStreamer] media/W3C failures
https://bugs.webkit.org/show_bug.cgi?id=75078

Reviewed by Martin Robinson.

Source/WebCore:

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::load): Clean out everything
after file:// url path to cope with media/W3C tests loading
file:///path/to/media.ext?some parameters.

LayoutTests:

Unskip now passing tests and add GTK baselines for them.

  • platform/gtk/Skipped:
  • platform/gtk/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Added.
  • platform/gtk/media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt: Added.
  • platform/gtk/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Added.
  • platform/gtk/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt: Added.
  • platform/gtk/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Added.
  • platform/gtk/media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt: Added.
  • platform/gtk/media/W3C/video/canPlayType/canPlayType_two_implies_one_2-expected.txt: Added.
  • platform/gtk/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt: Added.
  • platform/gtk/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt: Added.
01:49 Changeset [108326] by fpizlo@apple.com

Fix massive crashes in all tests introduced by previous build fix, and fix non-DFG build.
https://bugs.webkit.org/show_bug.cgi?id=75812

Reviewed by Csaba Osztrogonác.

  • dfg/DFGOperations.cpp:

(JSC):

  • jit/HostCallReturnValue.h:

(JSC::initializeHostCallReturnValue):

01:29 SettingUpDevelopmentEnvironmentForN9 edited by zarvai@inf.u-szeged.hu
(diff)
01:20 Changeset [108325] by mlilek@apple.com

Not reviewed, build fix for non-client-based Geolocation builds after r107982.

  • page/Geolocation.cpp:
01:09 Changeset [108324] by yurys@chromium.org

[V8] Web Inspector: simplify worker debugger implementation
https://bugs.webkit.org/show_bug.cgi?id=79085

There is one instance of WorkerScriptDebugServer per worker thread. We don't
need to resolve WorkerContext from V8::Context anymore.

Reviewed by Pavel Feldman.

  • bindings/v8/WorkerScriptDebugServer.cpp:

(WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
(WebCore::WorkerScriptDebugServer::addListener):
(WebCore::WorkerScriptDebugServer::removeListener):
(WebCore::WorkerScriptDebugServer::getDebugListenerForContext):
(WebCore::WorkerScriptDebugServer::runMessageLoopOnPause):

  • bindings/v8/WorkerScriptDebugServer.h:

(WorkerScriptDebugServer):

  • inspector/WorkerDebuggerAgent.cpp:

(WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):
(WebCore::WorkerDebuggerAgent::startListeningScriptDebugServer):
(WebCore::WorkerDebuggerAgent::stopListeningScriptDebugServer):

01:09 Changeset [108323] by fpizlo@apple.com

Attempted build fix for ELF platforms.

  • dfg/DFGOperations.cpp:

(JSC):
(JSC::getHostCallReturnValueWithExecState):

  • jit/HostCallReturnValue.cpp:

(JSC):

  • jit/HostCallReturnValue.h:

(JSC::initializeHostCallReturnValue):

01:00 Changeset [108322] by haraken@chromium.org

Enable the IDL attribute checker in Chromium
https://bugs.webkit.org/show_bug.cgi?id=79082

Reviewed by Adam Barth.

We have fixed 10~ bugs caused by typos of IDL attributes.
This patch adds an IDL attribute checker, which checks if all IDL attributes
used in IDL files are implemented by code generators.

  • The IDL attribute checker uses IDLAttributes.txt, which lists all IDL attributes implemented in code generators. If we want to add a new IDL attribute, we need to add it to IDLAttributes.txt manually.
  • The IDL attribute checker checks if all IDL attributes used in IDL files are listed in IDLAttributes.txt.
  • If the IDL attribute checker fails, the build fails with a verbose error message.

No tests. I manually checked that [Custommm], [CallWith=],
[CallWith=ScriptExecutionContext|Foo] cause build failures.

  • WebCore.gyp/WebCore.gyp: Modified to enable the IDL attribute checker.
  • bindings/scripts/resolve-supplemental.pl:

(loadIDLAttributes): This method loads a list of IDL attributes from IDLAttributes.txt.
(checkIDLAttributes): This method implementes the IDL attribute checker as described above.
(checkIfIDLAttributesExists):

  • bindings/scripts/IDLParser.pm: "1" is not good to represent that

the IDL attribute does not have any value. This patch changed it to "VALUE_IS_MISSING".
(parseExtendedAttributes):
(ParseInterface):

  • bindings/scripts/CodeGenerator.pm: Ditto.

(ContentAttributeName):

  • bindings/scripts/CodeGeneratorV8.pm: Ditto.

(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateSingleBatchedAttribute):
(GetRuntimeEnableFunctionName):

  • bindings/scripts/IDLAttributes.txt: Added. This file lists all IDL attributes implemented

in code generators.

00:43 Changeset [108321] by paroga@webkit.org

Use Win32 API to get file information
https://bugs.webkit.org/show_bug.cgi?id=55336

Reviewed by Adam Roben.

Use FindFirstFile() in favour over _wstat64() to share the code with WinCE.

  • platform/win/FileSystemWin.cpp:

(WebCore):
(WebCore::getFindData):
(WebCore::getFileSize):
(WebCore::getFileModificationTime):
(WebCore::fileExists):

00:25 Changeset [108320] by yutak@chromium.org

[Chromium] Unreviewed, update test expectations to reflect recent flakiness.

  • platform/chromium/test_expectations.txt:
00:19 Changeset [108319] by mrobinson@webkit.org

Rebaseline a test for GTK+.

  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: New baseline.
00:10 Changeset [108318] by mrobinson@webkit.org

Skip some test that are failing after r108278.

  • platform/gtk/Skipped: Skip a few tests.

02/20/12:

23:54 Changeset [108317] by abarth@webkit.org

mastercfg_unittest.py fails without simplejson
https://bugs.webkit.org/show_bug.cgi?id=79070

Reviewed by Csaba Osztrogonác.

Now that we require Python 2.6 (and higher) we can import json rather
than simplejson. We still need to use the simplejson name because
that's what the master.cfg script expects.

  • BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:

(BuildBotConfigLoader._add_dependant_modules_to_sys_modules):

23:51 Changeset [108316] by mrobinson@webkit.org

Merging r108279

23:49 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
23:48 WebKitGTK/WebKit2Roadmap edited by carlosgc@webkit.org
(diff)
23:47 Changeset [108315] by mrobinson@webkit.org

Merging r108313

23:46 Changeset [108314] by mrobinson@webkit.org

Merging r108312

23:45 Changeset [108313] by mrobinson@webkit.org

Fix GTK+ unit tests after r108281.

Reviewed by Alejandro G. Castro.

  • tests/testwebplugindatabase.c:

(test_webkit_web_plugin_database_get_plugins): Update the description used
in the test.

23:44 Changeset [108312] by mrobinson@webkit.org

Fix GTK+ unit tests after r108278.

Reviewed by Alejandro G. Castro.

Now that WebCore is no longer stealing focus, we need to
adjust where we grab focus to ensure that it actually succeeds.

  • tests/testcopyandpaste.c:

(map_event_cb): No longer grab focus here.
(runPasteTestCallback): Grabbing focus here seems to be late enough in the process.

23:41 WebKitGTK/WebKit2Roadmap edited by carlosgc@webkit.org
(diff)
23:32 Changeset [108311] by abarth@webkit.org

Invalid cast in WebCore::toElement / WebCore::HTMLElementStack::ElementRecord::element
https://bugs.webkit.org/show_bug.cgi?id=78975

Reviewed by Eric Seidel.

Source/WebCore:

We're supposed to set the action attribute on the form element we just
created. Previously, we assumed the newly created form element would
be on the top of the stack of open elements, but if we're in the table
body insertion mode, the form element gets treated as self closing and
is therefore popped off the stack of open elements.

Fortunately, we already cache a pointer to the most recently inserted
form element on the HTMLConstructionSite, so we can just grab the
element from there.

Test: html5lib/runner.html

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processIsindexStartTagForInBody):
(WebCore):

LayoutTests:

  • html5lib/resourcesl/webkit-02.dat:
23:07 Changeset [108310] by abarth@webkit.org

Unite TextTrack-related files with their friends in WebCore/html/track
https://bugs.webkit.org/show_bug.cgi?id=78941

Reviewed by Eric Seidel.

The code that supports <track> seems to be split between the
WebCore/html directory and the WebCore/html/track directory. This
patch unites this code in the WebCore/html/track directory.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • html/LoadableTextTrack.cpp: Removed.
  • html/LoadableTextTrack.h: Removed.
  • html/TextTrack.cpp: Removed.
  • html/TextTrack.h: Removed.
  • html/TextTrack.idl: Removed.
  • html/TextTrackCue.cpp: Removed.
  • html/TextTrackCue.h: Removed.
  • html/TextTrackCue.idl: Removed.
  • html/TextTrackCueList.cpp: Removed.
  • html/TextTrackCueList.h: Removed.
  • html/TextTrackCueList.idl: Removed.
  • html/track/LoadableTextTrack.cpp: Copied from Source/WebCore/html/LoadableTextTrack.cpp.
  • html/track/LoadableTextTrack.h: Copied from Source/WebCore/html/LoadableTextTrack.h.
  • html/track/TextTrack.cpp: Copied from Source/WebCore/html/TextTrack.cpp.
  • html/track/TextTrack.h: Copied from Source/WebCore/html/TextTrack.h.
  • html/track/TextTrack.idl: Copied from Source/WebCore/html/TextTrack.idl.
  • html/track/TextTrackCue.cpp: Copied from Source/WebCore/html/TextTrackCue.cpp.
  • html/track/TextTrackCue.h: Copied from Source/WebCore/html/TextTrackCue.h.
  • html/track/TextTrackCue.idl: Copied from Source/WebCore/html/TextTrackCue.idl.
  • html/track/TextTrackCueList.cpp: Copied from Source/WebCore/html/TextTrackCueList.cpp.
  • html/track/TextTrackCueList.h: Copied from Source/WebCore/html/TextTrackCueList.h.
  • html/track/TextTrackCueList.idl: Copied from Source/WebCore/html/TextTrackCueList.idl.
22:49 Changeset [108309] by fpizlo@apple.com

JSC should be a triple-tier VM
https://bugs.webkit.org/show_bug.cgi?id=75812
<rdar://problem/10079694>

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

Implemented an interpreter that uses the JIT's calling convention. This
interpreter is called LLInt, or the Low Level Interpreter. JSC will now
will start by executing code in LLInt and will only tier up to the old
JIT after the code is proven hot.

LLInt is written in a modified form of our macro assembly. This new macro
assembly is compiled by an offline assembler (see offlineasm), which
implements many modern conveniences such as a Turing-complete CPS-based
macro language and direct access to relevant C++ type information
(basically offsets of fields and sizes of structs/classes).

Code executing in LLInt appears to the rest of the JSC world "as if" it
were executing in the old JIT. Hence, things like exception handling and
cross-execution-engine calls just work and require pretty much no
additional overhead.

This interpreter is 2-2.5x faster than our old interpreter on SunSpider,
V8, and Kraken. With triple-tiering turned on, we're neutral on SunSpider,
V8, and Kraken, but appear to get a double-digit improvement on real-world
websites due to a huge reduction in the amount of JIT'ing.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
  • JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • assembler/LinkBuffer.h:
  • assembler/MacroAssemblerCodeRef.h:

(MacroAssemblerCodePtr):
(JSC::MacroAssemblerCodePtr::createFromExecutableAddress):

  • bytecode/BytecodeConventions.h: Added.
  • bytecode/CallLinkStatus.cpp:

(JSC::CallLinkStatus::computeFromLLInt):
(JSC):
(JSC::CallLinkStatus::computeFor):

  • bytecode/CallLinkStatus.h:

(JSC::CallLinkStatus::isSet):
(JSC::CallLinkStatus::operator!):
(CallLinkStatus):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC):
(JSC::CodeBlock::unlinkCalls):
(JSC::CodeBlock::unlinkIncomingCalls):
(JSC::CodeBlock::bytecodeOffset):
(JSC::ProgramCodeBlock::jettison):
(JSC::EvalCodeBlock::jettison):
(JSC::FunctionCodeBlock::jettison):
(JSC::ProgramCodeBlock::jitCompileImpl):
(JSC::EvalCodeBlock::jitCompileImpl):
(JSC::FunctionCodeBlock::jitCompileImpl):

  • bytecode/CodeBlock.h:

(JSC):
(CodeBlock):
(JSC::CodeBlock::baselineVersion):
(JSC::CodeBlock::linkIncomingCall):
(JSC::CodeBlock::bytecodeOffset):
(JSC::CodeBlock::jitCompile):
(JSC::CodeBlock::hasOptimizedReplacement):
(JSC::CodeBlock::addPropertyAccessInstruction):
(JSC::CodeBlock::addGlobalResolveInstruction):
(JSC::CodeBlock::addLLIntCallLinkInfo):
(JSC::CodeBlock::addGlobalResolveInfo):
(JSC::CodeBlock::numberOfMethodCallLinkInfos):
(JSC::CodeBlock::valueProfilePredictionForBytecodeOffset):
(JSC::CodeBlock::likelyToTakeSlowCase):
(JSC::CodeBlock::couldTakeSlowCase):
(JSC::CodeBlock::likelyToTakeSpecialFastCase):
(JSC::CodeBlock::likelyToTakeDeepestSlowCase):
(JSC::CodeBlock::likelyToTakeAnySlowCase):
(JSC::CodeBlock::addFrequentExitSite):
(JSC::CodeBlock::dontJITAnytimeSoon):
(JSC::CodeBlock::jitAfterWarmUp):
(JSC::CodeBlock::jitSoon):
(JSC::CodeBlock::llintExecuteCounter):
(ProgramCodeBlock):
(EvalCodeBlock):
(FunctionCodeBlock):

  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFromLLInt):
(JSC):
(JSC::GetByIdStatus::computeFor):

  • bytecode/GetByIdStatus.h:

(JSC::GetByIdStatus::GetByIdStatus):
(JSC::GetByIdStatus::wasSeenInJIT):
(GetByIdStatus):

  • bytecode/Instruction.h:

(JSC):
(JSC::Instruction::Instruction):
(Instruction):

  • bytecode/LLIntCallLinkInfo.h: Added.

(JSC):
(JSC::LLIntCallLinkInfo::LLIntCallLinkInfo):
(LLIntCallLinkInfo):
(JSC::LLIntCallLinkInfo::~LLIntCallLinkInfo):
(JSC::LLIntCallLinkInfo::isLinked):
(JSC::LLIntCallLinkInfo::unlink):

  • bytecode/MethodCallLinkStatus.cpp:

(JSC::MethodCallLinkStatus::computeFor):

  • bytecode/Opcode.cpp:

(JSC):

  • bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFromLLInt):
(JSC):
(JSC::PutByIdStatus::computeFor):

  • bytecode/PutByIdStatus.h:

(PutByIdStatus):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveWithBase):
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::emitPutById):
(JSC::BytecodeGenerator::emitDirectPutById):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):
(JSC::BytecodeGenerator::emitCatch):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOperations.cpp:
  • heap/Heap.h:

(JSC):
(JSC::Heap::firstAllocatorWithoutDestructors):
(Heap):

  • heap/MarkStack.cpp:

(JSC::visitChildren):

  • heap/MarkedAllocator.h:

(JSC):
(MarkedAllocator):

  • heap/MarkedSpace.h:

(JSC):
(MarkedSpace):
(JSC::MarkedSpace::firstAllocator):

  • interpreter/CallFrame.cpp:

(JSC):
(JSC::CallFrame::bytecodeOffsetForNonDFGCode):
(JSC::CallFrame::setBytecodeOffsetForNonDFGCode):
(JSC::CallFrame::currentVPC):
(JSC::CallFrame::setCurrentVPC):
(JSC::CallFrame::trueCallerFrame):

  • interpreter/CallFrame.h:

(JSC::ExecState::hasReturnPC):
(JSC::ExecState::clearReturnPC):
(ExecState):
(JSC::ExecState::bytecodeOffsetForNonDFGCode):
(JSC::ExecState::currentVPC):
(JSC::ExecState::setCurrentVPC):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::Interpreter):
(JSC::Interpreter::~Interpreter):
(JSC):
(JSC::Interpreter::initialize):
(JSC::Interpreter::isOpcode):
(JSC::Interpreter::unwindCallFrame):
(JSC::getCallerInfo):
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::retrieveLastCaller):

  • interpreter/Interpreter.h:

(JSC):
(Interpreter):
(JSC::Interpreter::getOpcode):
(JSC::Interpreter::getOpcodeID):
(JSC::Interpreter::classicEnabled):

  • interpreter/RegisterFile.h:

(JSC):
(RegisterFile):

  • jit/ExecutableAllocator.h:

(JSC):

  • jit/HostCallReturnValue.cpp: Added.

(JSC):
(JSC::getHostCallReturnValueWithExecState):

  • jit/HostCallReturnValue.h: Added.

(JSC):
(JSC::initializeHostCallReturnValue):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):

  • jit/JITCode.h:

(JSC::JITCode::isOptimizingJIT):
(JITCode):
(JSC::JITCode::isBaselineCode):
(JSC::JITCode::JITCode):

  • jit/JITDriver.h:

(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):

  • jit/JITExceptions.cpp:

(JSC::jitThrow):

  • jit/JITInlineMethods.h:

(JSC::JIT::updateTopCallFrame):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):
(JSC):

  • jit/JITStubs.h:

(JSC):

  • jit/JSInterfaceJIT.h:
  • llint: Added.
  • llint/LLIntCommon.h: Added.
  • llint/LLIntData.cpp: Added.

(LLInt):
(JSC::LLInt::Data::Data):
(JSC::LLInt::Data::performAssertions):
(JSC::LLInt::Data::~Data):

  • llint/LLIntData.h: Added.

(JSC):
(LLInt):
(Data):
(JSC::LLInt::Data::exceptionInstructions):
(JSC::LLInt::Data::opcodeMap):
(JSC::LLInt::Data::performAssertions):

  • llint/LLIntEntrypoints.cpp: Added.

(LLInt):
(JSC::LLInt::getFunctionEntrypoint):
(JSC::LLInt::getEvalEntrypoint):
(JSC::LLInt::getProgramEntrypoint):

  • llint/LLIntEntrypoints.h: Added.

(JSC):
(LLInt):
(JSC::LLInt::getEntrypoint):

  • llint/LLIntExceptions.cpp: Added.

(LLInt):
(JSC::LLInt::interpreterThrowInCaller):
(JSC::LLInt::returnToThrowForThrownException):
(JSC::LLInt::returnToThrow):
(JSC::LLInt::callToThrow):

  • llint/LLIntExceptions.h: Added.

(JSC):
(LLInt):

  • llint/LLIntOfflineAsmConfig.h: Added.
  • llint/LLIntOffsetsExtractor.cpp: Added.

(JSC):
(LLIntOffsetsExtractor):
(JSC::LLIntOffsetsExtractor::dummy):
(main):

  • llint/LLIntSlowPaths.cpp: Added.

(LLInt):
(JSC::LLInt::llint_trace_operand):
(JSC::LLInt::llint_trace_value):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::traceFunctionPrologue):
(JSC::LLInt::shouldJIT):
(JSC::LLInt::entryOSR):
(JSC::LLInt::resolveGlobal):
(JSC::LLInt::getByVal):
(JSC::LLInt::handleHostCall):
(JSC::LLInt::setUpCall):
(JSC::LLInt::genericCall):

  • llint/LLIntSlowPaths.h: Added.

(JSC):
(LLInt):

  • llint/LLIntThunks.cpp: Added.

(LLInt):
(JSC::LLInt::generateThunkWithJumpTo):
(JSC::LLInt::functionForCallEntryThunkGenerator):
(JSC::LLInt::functionForConstructEntryThunkGenerator):
(JSC::LLInt::functionForCallArityCheckThunkGenerator):
(JSC::LLInt::functionForConstructArityCheckThunkGenerator):
(JSC::LLInt::evalEntryThunkGenerator):
(JSC::LLInt::programEntryThunkGenerator):

  • llint/LLIntThunks.h: Added.

(JSC):
(LLInt):

  • llint/LowLevelInterpreter.asm: Added.
  • llint/LowLevelInterpreter.cpp: Added.
  • llint/LowLevelInterpreter.h: Added.
  • offlineasm: Added.
  • offlineasm/armv7.rb: Added.
  • offlineasm/asm.rb: Added.
  • offlineasm/ast.rb: Added.
  • offlineasm/backends.rb: Added.
  • offlineasm/generate_offset_extractor.rb: Added.
  • offlineasm/instructions.rb: Added.
  • offlineasm/offset_extractor_constants.rb: Added.
  • offlineasm/offsets.rb: Added.
  • offlineasm/opt.rb: Added.
  • offlineasm/parser.rb: Added.
  • offlineasm/registers.rb: Added.
  • offlineasm/self_hash.rb: Added.
  • offlineasm/settings.rb: Added.
  • offlineasm/transform.rb: Added.
  • offlineasm/x86.rb: Added.
  • runtime/CodeSpecializationKind.h: Added.

(JSC):

  • runtime/CommonSlowPaths.h:

(JSC::CommonSlowPaths::arityCheckFor):
(CommonSlowPaths):

  • runtime/Executable.cpp:

(JSC::jettisonCodeBlock):
(JSC):
(JSC::EvalExecutable::jitCompile):
(JSC::samplingDescription):
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::jitCompile):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::baselineCodeBlockFor):
(JSC::FunctionExecutable::jitCompileForCall):
(JSC::FunctionExecutable::jitCompileForConstruct):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

  • runtime/Executable.h:

(JSC):
(EvalExecutable):
(ProgramExecutable):
(FunctionExecutable):
(JSC::FunctionExecutable::jitCompileFor):

  • runtime/ExecutionHarness.h: Added.

(JSC):
(JSC::prepareForExecution):
(JSC::prepareFunctionForExecution):

  • runtime/JSArray.h:

(JSC):
(JSArray):

  • runtime/JSCell.h:

(JSC):
(JSCell):

  • runtime/JSFunction.h:

(JSC):
(JSFunction):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSC):
(JSGlobalData):

  • runtime/JSGlobalObject.h:

(JSC):
(JSGlobalObject):

  • runtime/JSObject.h:

(JSC):
(JSObject):
(JSFinalObject):

  • runtime/JSPropertyNameIterator.h:

(JSC):
(JSPropertyNameIterator):

  • runtime/JSString.h:

(JSC):
(JSString):

  • runtime/JSTypeInfo.h:

(JSC):
(TypeInfo):

  • runtime/JSValue.cpp:

(JSC::JSValue::description):

  • runtime/JSValue.h:

(LLInt):
(JSValue):

  • runtime/JSVariableObject.h:

(JSC):
(JSVariableObject):

  • runtime/Options.cpp:

(Options):
(JSC::Options::initializeOptions):

  • runtime/Options.h:

(Options):

  • runtime/ScopeChain.h:

(JSC):
(ScopeChainNode):

  • runtime/Structure.cpp:

(JSC::Structure::addPropertyTransition):

  • runtime/Structure.h:

(JSC):
(Structure):

  • runtime/StructureChain.h:

(JSC):
(StructureChain):

  • wtf/InlineASM.h:
  • wtf/Platform.h:
  • wtf/SentinelLinkedList.h:

(SentinelLinkedList):
(WTF::SentinelLinkedList::isEmpty):

  • wtf/text/StringImpl.h:

(JSC):
(StringImpl):

Source/WebCore:

Reviewed by Gavin Barraclough.

No new tests, because there is no change in behavior.

  • CMakeLists.txt:

Source/WebKit:

Reviewed by Gavin Barraclough.

Changed EFL's build system to include a new directory in JavaScriptCore.

  • CMakeLists.txt:

Tools:

Reviewed by Gavin Barraclough.

Changed EFL's build system to include a new directory in JavaScriptCore.

  • DumpRenderTree/efl/CMakeLists.txt:
22:38 Changeset [108308] by benjamin@webkit.org

Get rid of the LocalizationStrategy
https://bugs.webkit.org/show_bug.cgi?id=78324

Reviewed by Sam Weinig.

Source/WebCore:

Remove LocalizationStrategy and unify the localization behind
LocalizedStrings.h and LocalizedStrings.cpp.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/DefaultLocalizationStrategy.cpp: Removed.
  • platform/DefaultLocalizationStrategy.h: Removed.
  • platform/LocalizationStrategy.h: Removed.
  • platform/LocalizedStrings.cpp:
  • platform/LocalizedStrings.h:

(WebCore):

  • platform/PlatformStrategies.cpp:
  • platform/PlatformStrategies.h:

(WebCore):
(WebCore::PlatformStrategies::PlatformStrategies):
(PlatformStrategies):

  • platform/qt/LocalizedStringsQt.cpp: Copied from Source/WebKit/qt/WebCoreSupport/PlatformStrategiesQt.cpp.

Source/WebKit/qt:

Move the localization code from PlatformStrategiesQt.cpp
to LocalizedStringsQt.cpp.

Get rid of LocalizationStrategy from PlatformStrategiesQt

  • WebCoreSupport/PlatformStrategiesQt.cpp:
  • WebCoreSupport/PlatformStrategiesQt.h:

(PlatformStrategiesQt):

Source/WebKit/wince:

Remove a useless #include of LocalizationStrategy.h.

  • WebCoreSupport/PlatformStrategiesWinCE.h:
22:34 Changeset [108307] by fpizlo@apple.com

Unreviewed, rolling out http://trac.webkit.org/changeset/108291
It completely broke the 32-bit JIT.

  • heap/CopiedAllocator.h:
  • heap/CopiedSpace.h:

(CopiedSpace):

  • heap/Heap.h:

(JSC::Heap::allocatorForObjectWithDestructor):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:

(JIT):

  • jit/JITInlineMethods.h:

(JSC):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_new_array):

  • runtime/JSArray.cpp:

(JSC::storageSize):
(JSC):

  • runtime/JSArray.h:

(ArrayStorage):
(JSArray):

22:30 Changeset [108306] by ossy@webkit.org

[Qt] Unreviewed gardening after r108259.

  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt: Updated.
22:23 Changeset [108305] by haraken@chromium.org

Remove [TreatReturnedNullStringAsNull] from HTMLMediaElement.mediaGroup
https://bugs.webkit.org/show_bug.cgi?id=79064

Reviewed by Hajime Morita.

[TreatReturnedNullStringAsNull] is a typo of [TreatReturnedNullStringAs=Null].
But as far as I read the spec
(http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#attr-media-mediagroup),
there is no statement about what value should be returned when HTMLMediaElement.mediaGroup
is not yet initialized. In particular, there is no statement that says "null should
be returned when HTMLMediaElement.mediaGroup is not initialized". Thus, instead of
fixing the typo, just removing [TreatReturnedNullStringAsNull] would make sense.
Removing [TreatReturnedNullStringAsNull] does not change the current behavior.

Test: media/media-controller.html (No change in the test results.)

  • html/HTMLMediaElement.idl:
22:17 Changeset [108304] by barraclough@apple.com

Put? should throw if prototype chain contains a readonly property.
https://bugs.webkit.org/show_bug.cgi?id=79069

Reviewed by Oliver Hunt.

Currently we only check the base of the put, not the prototype chain.
Fold this check in with the test for accessors.

Source/JavaScriptCore:

  • runtime/JSObject.cpp:

(JSC::JSObject::put):

  • Updated to test all objects in the propotype chain for readonly properties.

(JSC::JSObject::putDirectAccessor):
(JSC::putDescriptor):

  • Record the presence of readonly properties on the structure.
  • runtime/Structure.cpp:

(JSC::Structure::Structure):

  • hasGetterSetterPropertiesExcludingProto expanded to hasReadOnlyOrGetterSetterPropertiesExcludingProto.
  • runtime/Structure.h:

(JSC::Structure::hasReadOnlyOrGetterSetterPropertiesExcludingProto):
(JSC::Structure::setHasGetterSetterProperties):

  • hasGetterSetterPropertiesExcludingProto expanded to hasReadOnlyOrGetterSetterPropertiesExcludingProto.

(JSC::Structure::setContainsReadOnlyProperties):

  • Added.

LayoutTests:

  • fast/js/Object-defineProperty-expected.txt:
  • fast/js/script-tests/Object-defineProperty.js:

(get shouldBeTrue):

  • Added test case.
22:15 Changeset [108303] by hayato@chromium.org

Use InsertinonPoint instead of HTMLContentElement.
https://bugs.webkit.org/show_bug.cgi?id=78778

Reviewed by Hajime Morita.

Replace HTMLContentElement with InsertionPoint in NodeRenderingContext and HTMLContentSelection.
This is one of followup patches for r108207.

No new tests, no change in behavior.

  • dom/NodeRenderingContext.cpp:

(WebCore::nextRendererOf):
(WebCore::previousRendererOf):
(WebCore::firstRendererOf):
(WebCore::lastRendererOf):

  • dom/NodeRenderingContext.h:

(WebCore):
(NodeRenderingContext):
(WebCore::NodeRenderingContext::insertionPoint):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::insertionPointFor):

  • dom/ShadowRoot.h:

(WebCore):

  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::HTMLContentElement):
(WebCore::HTMLContentElement::attach):
(WebCore::HTMLContentElement::detach):

  • html/shadow/HTMLContentElement.h:

(HTMLContentElement):

  • html/shadow/HTMLContentSelector.cpp:

(WebCore::HTMLContentSelector::select):

  • html/shadow/HTMLContentSelector.h:

(WebCore):
(HTMLContentSelection):
(WebCore::HTMLContentSelection::insertionPoint):
(WebCore::HTMLContentSelection::HTMLContentSelection):
(WebCore::HTMLContentSelection::create):

  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::InsertionPoint):

  • html/shadow/InsertionPoint.h:

(WebCore::InsertionPoint::selections):
(WebCore::InsertionPoint::hasSelection):
(InsertionPoint):

22:00 Changeset [108302] by commit-queue@webkit.org

MathML internals - code clean-up for RenderMathMLSubSup
https://bugs.webkit.org/show_bug.cgi?id=79063

Patch by David Barton <dbarton@mathscribe.com> on 2012-02-20
Reviewed by Eric Seidel.

In the next patch, I will shrink and revise the <msubsup> formatting code. To make this
easier to follow, I am first doing some simple code clean-up.

No new tests.

  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::layout):

  • rendering/mathml/RenderMathMLRow.h:

(WebCore::RenderMathMLRow::isRenderMathMLRow):

  • rendering/mathml/RenderMathMLSubSup.cpp:

(WebCore::RenderMathMLSubSup::stretchToHeight):
(WebCore::RenderMathMLSubSup::layout):

  • There is no need to iterate over baseWrapper's children since it should have only one child, the base of the <msubsup>.
21:52 Changeset [108301] by haraken@chromium.org

Replace [V8Custom=DOMWindowNOP] with [V8Custom]
https://bugs.webkit.org/show_bug.cgi?id=79062

Reviewed by Adam Barth.

[V8Custom=DOMWindowNOP] is not implemented by CodeGeneratorV8.pm.
This patch replaces it with [V8Custom].

No new tests. No change in behavior.

  • page/DOMWindow.idl:
21:28 Changeset [108300] by haraken@chromium.org

[JSGenerateIsReachable=ImplRoot] is not implemented, it should be [JSGenerateIsReachable]
https://bugs.webkit.org/show_bug.cgi?id=79061

Reviewed by Adam Barth.

CSSStyleDeclaration.idl uses [JSGenerateIsReachable=ImplRoot],
but "ImplRoot" is not implemented in CodeGeneratorJS.pm.
This patch replaces [JSGenerateIsReachable=ImplRoot] with [JSGenerateIsReachable].

No tests. No change in behavior.

  • css/CSSStyleDeclaration.idl:
21:25 Changeset [108299] by commit-queue@webkit.org

There is no complete test cases of optional arguments for MediaStream API and PeerConnection
https://bugs.webkit.org/show_bug.cgi?id=78578

Reviewed by Adam Barth.

  • fast/mediastream/peerconnection-AttributesMethod-expected.txt: Added.
  • fast/mediastream/peerconnection-AttributesMethod.html: Added.
  • fast/mediastream/peerconnection-addstream-expected.txt:
  • fast/mediastream/peerconnection-argument-types-expected.txt: Added.
  • fast/mediastream/peerconnection-argument-types.html: Added.
  • fast/mediastream/peerconnection-removestream-expected.txt: Added.
  • fast/mediastream/peerconnection-removestream.html: Added.
  • fast/mediastream/script-tests/AttributesMethod.js: Added.
  • fast/mediastream/script-tests/argument-types.js: Added.
  • fast/mediastream/script-tests/peerconnection-addstream.js:
  • fast/mediastream/script-tests/peerconnection-removestream.js: Added.

Patch by Yanbin Zhang <yanbin.zhang@intel.com> on 2012-02-20

21:21 Changeset [108298] by haraken@chromium.org

[EnabledAtRuntime] in HTMLShadowElement.idl should be [V8EnabledAtRuntime]
https://bugs.webkit.org/show_bug.cgi?id=79058

Reviewed by Adam Barth.

[EnabledAtRuntime] does not exist any longer. It should be [V8EnabledAtRuntime].

No tests.

  • html/shadow/HTMLShadowElement.idl:
20:52 Changeset [108297] by haraken@chromium.org

Replace [Callback=FunctionOnly] with [Callback]
https://bugs.webkit.org/show_bug.cgi?id=79060

Reviewed by Adam Barth.

[Callback=FunctionOnly] is not implemented by any code generator.
This patch replaces it with [Callback].

No tests. No change in behavior.

  • Modules/intents/IntentResultCallback.idl:
  • Modules/intents/NavigatorIntents.idl:
  • dom/RequestAnimationFrameCallback.idl:
  • mediastream/NavigatorMediaStream.idl:
  • mediastream/NavigatorUserMediaErrorCallback.idl:
  • mediastream/NavigatorUserMediaSuccessCallback.idl:
  • mediastream/PeerConnection.idl:
  • mediastream/SignalingCallback.idl:
  • page/PositionCallback.idl:
  • page/PositionErrorCallback.idl:
20:17 Changeset [108296] by commit-queue@webkit.org

[BlackBerry] Need to override active/inactive text search highlight color for RenderThemeBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=78920

Override two functions for text search highlight colors so that we can
provide platform specified colors.

Patch by Andy Chen <andchen@rim.com> on 2012-02-17
Reviewed by Antonio Gomes.

No function change so no new tests.

  • platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::platformActiveTextSearchHighlightColor):
(WebCore::RenderThemeBlackBerry::platformInactiveTextSearchHighlightColor):

  • platform/blackberry/RenderThemeBlackBerry.h:
20:12 Changeset [108295] by yutak@chromium.org

[Chromium] Unreviewed, update test expectations.

  • platform/chromium/fast/dom/Window/window-custom-prototype-expected.txt:
  • platform/chromium/fast/js/string-capitalization-expected.txt:
  • platform/chromium/test_expectations.txt:
20:06 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
20:05 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
20:05 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
19:59 Changeset [108294] by mrobinson@webkit.org

Merging r108288

19:48 Changeset [108293] by jknotten@chromium.org

Default canvas backing store to be 1:1 with specified dimensions.
https://bugs.webkit.org/show_bug.cgi?id=78971

Reviewed by Adam Barth.

Although the canvas specification states that the backing image may
be larger than the user-specified dimensions, there are a number of
philip canvas tests that fail when the backing image data is not
1:1 with the specified canvas dimensions. These failures are
tracked in https://bugs.webkit.org/show_bug.cgi?id=73645

This change defaults the canvas backing store to be 1:1 with the
user-specified dimensions, while also providing an
ENABLE(HIGH_DPI_CANVAS) build option to reinstate the original
behaviour, so that the above bug may be more easily fixed.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::HTMLCanvasElement):

19:24 Changeset [108292] by bashi@chromium.org

Update pywebsocket to 0.7.2
https://bugs.webkit.org/show_bug.cgi?id=79066

This version includes vendor-prefixed deflate-frame extension support.

Reviewed by Kent Tamura.

  • Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook._install_pywebsocket):

19:20 Changeset [108291] by mhahnenberg@apple.com

Implement fast path for op_new_array in the baseline JIT
https://bugs.webkit.org/show_bug.cgi?id=78612

Reviewed by Filip Pizlo.

  • heap/CopiedAllocator.h:

(CopiedAllocator): Friended the JIT to allow access to m_currentOffset.

  • heap/CopiedSpace.h:

(CopiedSpace): Friended the JIT to allow access to
(JSC::CopiedSpace::allocator):

  • heap/Heap.h:

(JSC::Heap::storageAllocator): Added a getter for the CopiedAllocator class so the JIT
can use it for simple allocation i.e. when we can just bump the offset without having to
do anything else.

  • jit/JIT.cpp:

(JSC::JIT::privateCompileSlowCases): Added new slow case for op_new_array for when
we have to bail out because the fast allocation path fails for whatever reason.

  • jit/JIT.h:

(JIT):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicStorage): Added utility function that allows objects to
allocate generic backing stores. This function is used by emitAllocateJSArray.
(JSC):
(JSC::JIT::emitAllocateJSArray): Added utility function that allows the client to
more easily allocate JSArrays. This function is used by emit_op_new_array and I expect
it will also be used for emit_op_new_array_buffer.

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_new_array): Changed to do inline allocation of JSArrays. Still does
a stub call for oversize arrays.
(JSC):
(JSC::JIT::emitSlow_op_new_array): Just bails out to a stub call if we fail in any way on
the fast path.

  • runtime/JSArray.cpp:

(JSC):

  • runtime/JSArray.h: Added lots of offset functions for all the fields that we need to

initialize in the JIT.
(ArrayStorage):
(JSC::ArrayStorage::lengthOffset):
(JSC::ArrayStorage::numValuesInVectorOffset):
(JSC::ArrayStorage::allocBaseOffset):
(JSC::ArrayStorage::vectorOffset):
(JSArray):
(JSC::JSArray::sparseValueMapOffset):
(JSC::JSArray::subclassDataOffset):
(JSC::JSArray::indexBiasOffset):
(JSC):
(JSC::JSArray::storageSize): Moved this function from being a static function in the cpp file
to being a static function in the JSArray class. This move allows the JIT to call it to
see what size it should allocate.

19:19 Changeset [108290] by commit-queue@webkit.org

Upstream RenderThemeBlackberry.h/.cpp into WebCore/platform/blackberry
https://bugs.webkit.org/show_bug.cgi?id=78785

Main Contributors:
Daniel Bates <dbates@rim.com>
Bryan Gislason <bgislason@rim.com>
Akash Vaswani <akvaswani@rim.com>
Dave Battista <dbattista@rim.com>
Robin Cao <robin.cao@torchmobile.com.cn>
Genevieve Mak <gmak@rim.com>
Mike Fenton <mifenton@rim.com>

Patch by Mary Wu <mary.wu@torchmobile.com.cn> on 2012-02-20
Reviewed by Antonio Gomes.

Initial upstream, no new tests.

  • platform/blackberry/RenderThemeBlackBerry.cpp: Added.
  • platform/blackberry/RenderThemeBlackBerry.h: Added.
19:10 Changeset [108289] by commit-queue@webkit.org

[GTK] [EFL] Collapse duplicate WebGL support code
https://bugs.webkit.org/show_bug.cgi?id=78970

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-02-20
Reviewed by Gustavo Noronha Silva.

No new tests. This just cleans up duplicated code.

Centralize duplicated WebGL code for EFL and GTK+ in the Cairo
directory. This is in preparation for the changes necessary to
connect WebGL to the TextureMapper AC.

  • GNUmakefile.list.am: Update source list.
  • PlatformEfl.cmake: Update source list.
  • platform/graphics/cairo/DrawingBufferCairo.cpp: Renamed from Source/WebCore/platform/graphics/gtk/DrawingBufferGtk.cpp.
  • platform/graphics/cairo/GraphicsContext3DCairo.cpp: Integrated the code From GraphicsContext3DGtk.cpp.
  • platform/graphics/efl/DrawingBufferEfl.cpp: Removed.
  • platform/graphics/efl/GraphicsContext3DEfl.cpp: Removed.
  • platform/graphics/gtk/GraphicsContext3DGtk.cpp: Removed.
19:05 Changeset [108288] by commit-queue@webkit.org

[GTK] Turn on requestAnimationFrame for release builds
https://bugs.webkit.org/show_bug.cgi?id=79038

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-02-20
Reviewed by Gustavo Noronha Silva.

  • configure.ac: Turn on requestAnimationFrame by default.
18:53 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
18:51 Changeset [108287] by mrobinson@webkit.org

Merging r108277

18:48 Changeset [108286] by mrobinson@webkit.org

Merging r108278

18:45 Changeset [108285] by mrobinson@webkit.org

Merging r108281

18:39 Changeset [108284] by mrobinson@webkit.org

Merging rr108248

18:37 Changeset [108283] by mrobinson@webkit.org

Merging r108237

18:35 Changeset [108282] by barraclough@apple.com

DefineOwnProperty fails with numeric properties & Object.prototype
https://bugs.webkit.org/show_bug.cgi?id=79059

Reviewed by Oliver Hunt.

ObjectPrototype caches whether it contains any numeric properties (m_hasNoPropertiesWithUInt32Names),
calls to defineOwnProperty need to update this cache.

Source/JavaScriptCore:

  • runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::put):
(JSC::ObjectPrototype::defineOwnProperty):
(JSC):
(JSC::ObjectPrototype::getOwnPropertySlotByIndex):

  • runtime/ObjectPrototype.h:

(ObjectPrototype):

LayoutTests:

  • fast/js/Object-defineProperty-expected.txt:
  • fast/js/script-tests/Object-defineProperty.js:

(shouldBe.shouldBe.shouldBe.shouldBe.shouldBe.shouldBe.shouldBe.shouldThrow.Object.defineProperty):

18:27 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
18:19 Changeset [108281] by commit-queue@webkit.org

[UNIX] Plugin information fields are not interpreted as UTF-8
https://bugs.webkit.org/show_bug.cgi?id=78635

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-02-20
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Interpret plugin metadata as UTF8 aways. This matches the behavior
of Chromium and the Totem plugin.

This is tested by a change to TestNetscapePlugin and expectations updates.

  • plugins/efl/PluginPackageEfl.cpp:

(WebCore::PluginPackage::fetchInfo): Use String::fromUTF8.

  • plugins/gtk/PluginPackageGtk.cpp:

(WebCore::PluginPackage::fetchInfo): Use String::fromUTF8.

  • plugins/qt/PluginPackageQt.cpp:

(WebCore::PluginPackage::fetchInfo): Use String::fromUTF8.

Source/WebKit2:

Interpret plugin metadata as UTF8 aways. This matches the behavior
of Chromium and the Totem plugin.

  • Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:

(WebKit::NetscapePluginModule::getPluginInfoForLoadedPlugin): Use String::fromUTF8.

Tools:

Interpret plugin metadata as UTF8 aways. This matches the behavior
of Chromium and the Totem plugin.

  • DumpRenderTree/TestNetscapePlugIn/main.cpp:

(NPP_GetValue): Include a UTF-8 character in the description string for testing purposes.

LayoutTests:

Update expectations to match the fact that TestNetscapePlugin is now
returning a Unicode character in the description field.

  • platform/chromium-linux/plugins/plugin-javascript-access-expected.txt:
  • platform/gtk/plugins/plugin-javascript-access-expected.txt:
  • platform/qt/plugins/plugin-javascript-access-expected.txt:
18:16 Changeset [108280] by commit-queue@webkit.org

[GTK] [Qt] Move the unix forwarding headers for TestNetscapePlugin to the TestNetscapePlugin directory
https://bugs.webkit.org/show_bug.cgi?id=78935

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-02-20
Reviewed by Gustavo Noronha Silva.

Move the TestNetscapePlugin headers to a more appropriate directory and update
the build files to match.

  • DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h.
  • DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h.
  • DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h.
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update build.
  • GNUmakefile.am: Ditto.
18:12 Changeset [108279] by commit-queue@webkit.org

Does not build on GNU Hurd
https://bugs.webkit.org/show_bug.cgi?id=79045

Patch by Pino Toscano <pino@debian.org> on 2012-02-20
Reviewed by Gustavo Noronha Silva.

  • wtf/Platform.h: define WTF_OS_HURD.
  • wtf/ThreadIdentifierDataPthreads.cpp: adds a band-aid fix

for the lack of PTHREAD_KEYS_MAX definition, with a value which
should not cause issues.

18:04 Changeset [108278] by commit-queue@webkit.org

[GTK] Web content oftens steals focus from other widgets
https://bugs.webkit.org/show_bug.cgi?id=77791

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-02-20
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

  • platform/gtk/WidgetGtk.cpp:

(WebCore::Widget::setFocus): No longer do anything special to try
to grab "real" widget focus. This matches the behavior on Qt.

  • plugins/gtk/PluginViewGtk.cpp:

(WebCore::PluginView::setFocus): Moved the focus handling to here.
This ensures that behavior for plugins does not change.

Source/WebKit/gtk:

  • tests/testwebview.c: Added a WebKit1 test to verify this behavior.
18:02 Changeset [108277] by commit-queue@webkit.org

[GTK] Geolocation support should be on by default
https://bugs.webkit.org/show_bug.cgi?id=79037

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-02-20
Reviewed by Gustavo Noronha Silva.

  • configure.ac: Turn on geolocation support in release builds.
17:33 Changeset [108276] by yael.aharon@nokia.com

Regression (108135) isOpaque() returns uninitialized variable.
https://bugs.webkit.org/show_bug.cgi?id=79049

Reviewed by Noam Rosenthal.

isOpaque() should use the new m_flags instead of the old m_isOpaque.
No new tests. No new functionality.

  • platform/graphics/texmap/TextureMapper.h:

(WebCore::BitmapTexture::reset):
(WebCore::BitmapTexture::isOpaque):
(BitmapTexture):

17:27 Changeset [108275] by haraken@chromium.org

Unreviewed. Rebaselined run-bindings-tests results.

  • bindings/scripts/test/CPP/WebDOMTestInterface.cpp:
  • bindings/scripts/test/CPP/WebDOMTestInterface.h:
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
17:20 Changeset [108274] by noam.rosenthal@nokia.com

[Qt][WK2] Clipping is broken
https://bugs.webkit.org/show_bug.cgi?id=78677

It's not necessary to add a full-viewport rect to the scissor clip stack.
It creates a situation where if there's a clip in the page, we return to
the viewport clip instead of applying the WebView's clip we got from the
scenegraph.

Also, it's unnecessary to clip before we paint the layer's content, we should
only clip afterwards, before painting the children.

Reviewed by Kenneth Rohde Christiansen.

No new functionality.

  • platform/graphics/opengl/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::size):
(WebCore::scissorClip):
(WebCore):
(WebCore::TextureMapperGL::beginScissorClip):
(WebCore::TextureMapperGL::endScissorClip):

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::paintSelfAndChildren):

17:15 Changeset [108273] by noam.rosenthal@nokia.com

[Texmap] Layers and tiles appear to have missing pixels in their right/bottom borders
https://bugs.webkit.org/show_bug.cgi?id=78961

The relativeSize member should point to one pixel before the edge, since it's used
by glVertexAttribPointer, which takes edge points and not sizes.

Reviewed by Kenneth Rohde Christiansen.

No new funcionality.

  • platform/graphics/opengl/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::didReset):

17:05 Changeset [108272] by commit-queue@webkit.org

.: Add a new API for the Vibration API(W3C).
https://bugs.webkit.org/show_bug.cgi?id=72010

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-02-20
Reviewed by Hajime Morita.

Add Implementation for the Vibration API to the WebKit-EFL port.
http://dev.w3.org/2009/dap/vibration/

  • Source/cmake/OptionsEfl.cmake: Add ENABLE_VIBRATION feature.
  • Source/cmakeconfig.h.cmake:

Source/WebCore: Add a new API for the Vibration API(W3C).
https://bugs.webkit.org/show_bug.cgi?id=72010

http://dev.w3.org/2009/dap/vibration/
This patch implements navigator.webkitvibrate() API.
This API operates differently depending upon a given parameter:

  1. It cancels vibration when given 0 or [].
  2. It gives a vibration duration in milliseconds when given as a single integer value.
  3. It gives a vibration pattern when given as an integer array. For instance, [1000 300 1000] generates a vibration of 1000ms followed by 300ms of idle time, and then creates another vibration of 1000ms.

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-02-20
Reviewed by Hajime Morita.

Test: fast/dom/navigator-vibration.html

  • CMakeLists.txt:
  • Modules/vibration/NavigatorVibration.cpp: Added.

(WebCore):
(WebCore::NavigatorVibration::NavigatorVibration):
(WebCore::NavigatorVibration::~NavigatorVibration):
(WebCore::NavigatorVibration::webkitVibrate):
Add webkitVibrate method to get an array or single integer parameter for vibrating.
They check vibration is activated in the platform, and then call vibrate() in the Vibration class.

  • Modules/vibration/NavigatorVibration.h: Added.

(WebCore):
(NavigatorVibration):

  • Modules/vibration/NavigatorVibration.idl: Added.
  • Modules/vibration/Vibration.cpp: Added.

This class implements the entire vibration logic.
(WebCore):
(WebCore::Vibration::Vibration):
(WebCore::Vibration::~Vibration):
(WebCore::Vibration::create):
(WebCore::Vibration::vibrate):
(WebCore::Vibration::cancelVibration):
(WebCore::Vibration::suspendVibration):
(WebCore::Vibration::resumeVibration):
(WebCore::Vibration::timerStartFired):
(WebCore::Vibration::timerStopFired):
(WebCore::Vibration::supplementName):
(WebCore::Vibration::isActive):
(WebCore::provideVibrationTo):

  • Modules/vibration/Vibration.h: Added.

(WebCore):
(Vibration):
(WebCore::Vibration::from):

  • Modules/vibration/VibrationClient.h: Added.

vibrate() and cancelVibrate() need to be implemented in the VibrationClient.
(WebCore):
(VibrationClient):
(WebCore::VibrationClient::~VibrationClient):

Source/WebKit/efl: Add a new API for the Vibration API(W3C).
https://bugs.webkit.org/show_bug.cgi?id=72010

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-02-20
Reviewed by Hajime Morita.

Implementation for the Vibration API feature to the EFL-port layer.
http://dev.w3.org/2009/dap/vibration/
There are two methods for vibration API.

  • vibrate : Vibrate device for receiving as a parameter.
  • cancelVibrate : Cancel current vibration.
  • CMakeListsEfl.txt:
  • WebCoreSupport/VibrationClientEfl.cpp: Added.

(WebCore):
(WebCore::VibrationClientEfl::VibrationClientEfl):
(WebCore::VibrationClientEfl::vibrate):
(WebCore::VibrationClientEfl::cancelVibration):
(WebCore::VibrationClientEfl::vibrationDestroyed):

  • WebCoreSupport/VibrationClientEfl.h: Added.

(WebCore):
(VibrationClientEfl):
(WebCore::VibrationClientEfl::~VibrationClientEfl):

  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):

Tools: Add a new API for the Vibration API(W3C).
https://bugs.webkit.org/show_bug.cgi?id=72010

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-02-20
Reviewed by Hajime Morita.

  • Scripts/build-webkit: Enable ENABLE_VIBRATION feature.

LayoutTests: Add a new test case for the Vibration API.
https://bugs.webkit.org/show_bug.cgi?id=72010

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-02-20
Reviewed by Hajime Morita.

  • fast/dom/navigator-vibration-expected.txt: Added.
  • fast/dom/navigator-vibration.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
16:57 Changeset [108271] by yutak@chromium.org

Unreviewed, rolling out r108263.
http://trac.webkit.org/changeset/108263
https://bugs.webkit.org/show_bug.cgi?id=77856

Broke Chromium Windows build.

  • platform/audio/DynamicsCompressor.cpp:

(WebCore::DynamicsCompressor::DynamicsCompressor):
(WebCore::DynamicsCompressor::setEmphasisStageParameters):
(WebCore::DynamicsCompressor::process):
(WebCore::DynamicsCompressor::reset):

  • platform/audio/DynamicsCompressor.h:

(WebCore::DynamicsCompressor::isStereo):
(DynamicsCompressor):

  • platform/audio/DynamicsCompressorKernel.cpp:

(WebCore::DynamicsCompressorKernel::DynamicsCompressorKernel):
(WebCore::DynamicsCompressorKernel::setPreDelayTime):
(WebCore::DynamicsCompressorKernel::process):
(WebCore::DynamicsCompressorKernel::reset):

  • platform/audio/DynamicsCompressorKernel.h:

(DynamicsCompressorKernel):

  • webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
(WebCore::DynamicsCompressorNode::initialize):

16:25 Changeset [108270] by rniwa@webkit.org

Move more logic from handler classes to model classes and add unit tests
https://bugs.webkit.org/show_bug.cgi?id=78989

Reviewed by Hajime Morita.

Extracted various functions from CreateHandler, ReportHanlder, and RunsHanlder to model classes
in order to unit-test them, added DataStoreTestsBase to reduce the code duplication in tests,
and added a whole bunch of unit tests in models_unittest.py.

  • Websites/webkit-perf.appspot.com/create_handler.py:

(CreateHandler._create_branch):
(CreateHandler._create_platform):

  • Websites/webkit-perf.appspot.com/models.py:

(_create_if_possible):
(_create_if_possible.execute):
(Branch):
(Branch.create_if_possible):
(Platform):
(Platform.create_if_possible):
(Build):
(Build.get_or_insert_from_log):
(Test):
(Test.update_or_insert):
(Test.update_or_insert.execute):
(TestResult):
(TestResult.get_or_insert_from_parsed_json):
(TestResult.get_or_insert_from_parsed_json._float_or_none):
(TestResult.generate_runs):

  • Websites/webkit-perf.appspot.com/models_unittest.py:

(DataStoreTestsBase):
(DataStoreTestsBase.assertThereIsNoInstanceOf):
(DataStoreTestsBase.assertOnlyInstance):
(DataStoreTestsBase.assertEqualUnorderedList):
(HelperTests):
(HelperTests.test_create_in_transaction_with_numeric_id_holder):
(HelperTests.test_failing_in_create_in_transaction_with_numeric_id_holder):
(HelperTests.test_raising_in_create_in_transaction_with_numeric_id_holder):
(HelperTests.test_delete_model_with_numeric_id_holder):
(BranchTests):
(BranchTests.test_create_if_possible):
(PlatformTests):
(PlatformTests.test_create_if_possible):
(BuilderTests):
(_create_some_builder):
(BuildTests):
(BuildTests.test_get_or_insert_from_log):
(TestModelTests):
(TestModelTests.test_update_or_insert):
(TestModelTests.test_update_or_insert_to_update):
(TestResultTests):
(TestResultTests._create_build):
(TestResultTests.test_get_or_insert_value):
(TestResultTests.test_get_or_insert_stat_value):
(TestResultTests._create_results):
(TestResultTests.test_generate_runs):
(ReportLogTests):
(ReportLogTests.test_branch):
(ReportLogTests.test_platform):
(PersistentCacheTests):
(PersistentCacheTests.setUp):
(PersistentCacheTests.test_set):

  • Websites/webkit-perf.appspot.com/report_process_handler.py:

(ReportProcessHandler.post):

  • Websites/webkit-perf.appspot.com/runs_handler.py:

(RunsHandler.get):
(RunsHandler.post):

16:18 Changeset [108269] by barraclough@apple.com

Unreviewed windows build fix.

15:49 Changeset [108268] by mhahnenberg@apple.com

Undoing accidental changes

  • heap/Heap.cpp:

(JSC::Heap::collectAllGarbage):

15:42 Changeset [108267] by mhahnenberg@apple.com

Factor out allocation in CopySpace into a separate CopyAllocator
https://bugs.webkit.org/show_bug.cgi?id=78610

Reviewed by Oliver Hunt.

Added a new CopyAllocator class, which allows us to do allocations without
having to load the current offset and store the current offset in the current
block. This change will allow us to easily do inline assembly in the JIT for
array allocations.

(JSC):
(CopiedAllocator):
(JSC::CopiedAllocator::currentBlock):
(JSC::CopiedAllocator::CopiedAllocator):
(JSC::CopiedAllocator::allocate):
(JSC::CopiedAllocator::fitsInCurrentBlock):
(JSC::CopiedAllocator::wasLastAllocation):
(JSC::CopiedAllocator::startedCopying):
(JSC::CopiedAllocator::resetCurrentBlock):
(JSC::CopiedAllocator::currentUtilization):
(JSC::CopiedAllocator::resetLastAllocation):

  • heap/CopiedBlock.h:

(CopiedBlock):

  • heap/CopiedSpace.cpp: Moved some stuff from CopiedSpaceInlineMethods to here because we

weren't really getting any benefits from having such big functions in a header file.
(JSC::CopiedSpace::CopiedSpace):
(JSC):
(JSC::CopiedSpace::init):
(JSC::CopiedSpace::tryAllocateSlowCase):
(JSC::CopiedSpace::tryAllocateOversize):
(JSC::CopiedSpace::tryReallocate):
(JSC::CopiedSpace::tryReallocateOversize):
(JSC::CopiedSpace::doneFillingBlock):
(JSC::CopiedSpace::doneCopying):
(JSC::CopiedSpace::getFreshBlock):

  • heap/CopiedSpace.h:

(CopiedSpace):

  • heap/CopiedSpaceInlineMethods.h:

(JSC):
(JSC::CopiedSpace::startedCopying):
(JSC::CopiedSpace::addNewBlock):
(JSC::CopiedSpace::allocateNewBlock):
(JSC::CopiedSpace::fitsInBlock):
(JSC::CopiedSpace::tryAllocate):
(JSC::CopiedSpace::allocateFromBlock):

  • heap/Heap.cpp:

(JSC::Heap::collectAllGarbage):

  • heap/HeapBlock.h:

(HeapBlock):

15:39 WebKitGTK/1.8.x edited by kov@webkit.org
chrome version update merged (diff)
15:38 Changeset [108266] by kov@webkit.org

Merging http://trac.webkit.org/changeset/108264

15:37 Changeset [108265] by paroga@webkit.org

Fix Visual Studio 2010 build.

  • bytecompiler/NodesCodegen.cpp:

(JSC::PropertyListNode::emitBytecode):

15:22 Changeset [108264] by kov@webkit.org

[GTK] Needs to claim being a more up-to-date Chrome
https://bugs.webkit.org/show_bug.cgi?id=79044

Reviewed by Martin Robinson.

  • webkit/webkitwebsettings.cpp:

(chromeUserAgent): update the version of Chrome we claim to be
to avoid warnings from sites such as Wordpress saying that our
browser is outdated.

15:16 WebKitGTK/1.8.x edited by kov@webkit.org
Adding to proposed merges [GTK] Needs to claim being a more up-to-date … (diff)
14:10 Changeset [108263] by commit-queue@webkit.org

Have the DynamicsCompressorNode support multi-channel data
https://bugs.webkit.org/show_bug.cgi?id=77856

Patch by Raymond Liu <raymond.liu@intel.com> on 2012-02-20
Reviewed by Chris Rogers.

  • platform/audio/DynamicsCompressor.cpp:

(WebCore::DynamicsCompressor::DynamicsCompressor):
(WebCore::DynamicsCompressor::setEmphasisStageParameters):
(WebCore::DynamicsCompressor::process):
(WebCore::DynamicsCompressor::reset):
(WebCore::DynamicsCompressor::setNumberOfChannels):
(WebCore):

  • platform/audio/DynamicsCompressor.h:

(DynamicsCompressor):

  • platform/audio/DynamicsCompressorKernel.cpp:

(WebCore::DynamicsCompressorKernel::DynamicsCompressorKernel):
(WebCore::DynamicsCompressorKernel::setNumberOfChannels):
(WebCore):
(WebCore::DynamicsCompressorKernel::setPreDelayTime):
(WebCore::DynamicsCompressorKernel::process):
(WebCore::DynamicsCompressorKernel::reset):

  • platform/audio/DynamicsCompressorKernel.h:

(DynamicsCompressorKernel):

  • webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
(WebCore::DynamicsCompressorNode::initialize):

14:02 Changeset [108262] by commit-queue@webkit.org

RenderMathMLRow::baselinePosition() only if linePositionMode == PositionOnContainingLine
https://bugs.webkit.org/show_bug.cgi?id=79039

Patch by David Barton <dbarton@mathscribe.com> on 2012-02-20
Reviewed by Eric Seidel.

Source/WebCore:

RenderMathMLRow::baselinePosition() is actually unnecessary, but I am deleting it in two
steps. First we add a guard to restrict it to the intended PositionOnContainingLine
case, leaving PositionOfInteriorLineBoxes to a superclass, RenderBlock. This removes
some randomness, and tightens up the results of four existing test files.

Test: mathml/presentation/row.xhtml, fenced.xhtml, mo.xhtml, and mo-stretch.html

  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::baselinePosition):

LayoutTests:

  • platform/mac/mathml/presentation/fenced-expected.png:
  • platform/mac/mathml/presentation/fenced-expected.txt:
  • platform/mac/mathml/presentation/mo-expected.png:
  • platform/mac/mathml/presentation/mo-expected.txt:
  • platform/mac/mathml/presentation/mo-stretch-expected.png: Added property svn:mime-type.
  • platform/mac/mathml/presentation/mo-stretch-expected.txt:
  • platform/mac/mathml/presentation/row-expected.png:
  • platform/mac/mathml/presentation/row-expected.txt:
13:55 Changeset [108261] by jonlee@apple.com

HTML input file control "No File Selected" needs more room in some languages
https://bugs.webkit.org/show_bug.cgi?id=32366
<rdar://problem/4481028>

Reviewed by David Hyatt.

The patch exposes a function to return the "no file(s) selected" label text.

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::fileListDefaultLabel): Added to expose the text for the label in
file upload controls when nothing has been selected.
(WebCore::RenderTheme::fileListNameForWidth): Refactor to use fileListDefaultLabel().

  • rendering/RenderTheme.h: Change fileListNameForWidth() to be a const function.
  • rendering/RenderThemeMac.h: Update fileListNameForWidth() to be a const function for

platform implementations.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::fileListNameForWidth): Refactor to use fileListDefaultLabel().

Update fileListNameForWidth() to be a const function for platform implementations.

  • platform/gtk/RenderThemeGtk.h:
  • platform/gtk/RenderThemeGtk.cpp:
  • platform/qt/RenderThemeQt.h:
  • platform/qt/RenderThemeQt.cpp:
  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::computePreferredLogicalWidths): Change the calculation
of the max preferred logical width. Calculate the length of the "no file(s) selected" text,
and include the button and after-button margin. Take the max of that and the original
default width, which was a string of 34 (defaultWidthNumChars) "0"'s, in the case that the
label text is too short.

13:52 Changeset [108260] by barraclough@apple.com

Rubber stamped by Sam Weinig.

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::allowsAccessFrom):

  • Errk, remove dead code from end of function.
13:14 Changeset [108259] by barraclough@apple.com

Move special proto property to Object.prototype
https://bugs.webkit.org/show_bug.cgi?id=78409

Reviewed by Oliver Hunt.

Re-implement this as a regular accessor property. This has three key benefits:
1) It makes it possible for objects to be given properties named proto.
2) Object.prototype.proto can be deleted, preventing object prototypes from being changed.
3) This largely removes the magic used the implement proto, it can just be made a regular accessor property.

Source/JavaScriptCore:

  • parser/Parser.cpp:

(JSC::::parseFunctionInfo):

  • No need to prohibit functions named proto.
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

  • Add proto accessor to Object.prototype.
  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncProtoGetter):
(JSC::globalFuncProtoSetter):

  • Definition of the proto accessor functions.
  • runtime/JSGlobalObjectFunctions.h:
    • Declaration of the proto accessor functions.
  • runtime/JSObject.cpp:

(JSC::JSObject::put):

  • Remove the special handling for proto, there is still a check to allow for a fast guard for accessors excluding proto.

(JSC::JSObject::putDirectAccessor):

  • Track on the structure whether an object contains accessors other than one for proto.

(JSC::JSObject::defineOwnProperty):

  • No need to prohibit definition of own properties named proto.
  • runtime/JSObject.h:

(JSC::JSObject::inlineGetOwnPropertySlot):

  • Remove the special handling for proto.

(JSC::JSValue::get):

  • Remove the special handling for proto.
  • runtime/JSString.cpp:

(JSC::JSString::getOwnPropertySlot):

  • Remove the special handling for proto.
  • runtime/JSValue.h:

(JSValue):

  • Made synthesizePrototype public (this may be needed by the proto getter).
  • runtime/ObjectConstructor.cpp:

(JSC::objectConstructorGetPrototypeOf):

  • Perform the security check & call prototype() directly.
  • runtime/Structure.cpp:

(JSC::Structure::Structure):

  • Added 'ExcludingProto' variant of the 'hasGetterSetterProperties' state.
  • runtime/Structure.h:

(JSC::Structure::hasGetterSetterPropertiesExcludingProto):
(JSC::Structure::setHasGetterSetterProperties):
(Structure):

  • Added 'ExcludingProto' variant of the 'hasGetterSetterProperties' state.

Source/WebCore:

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::allowsAccessFrom):
(WebCore):

  • expose allowsAccessFrom check to JSC.
  • bindings/js/JSDOMWindowBase.h:

(JSDOMWindowBase):

  • expose allowsAccessFrom check to JSC.

LayoutTests:

  • fast/js/Object-getOwnPropertyNames-expected.txt:
  • fast/js/cyclic-prototypes-expected.txt:
  • fast/js/parser-syntax-check-expected.txt:
  • fast/js/preventExtensions-expected.txt:
  • fast/js/prototypes-expected.txt:
    • Update results
  • fast/js/script-tests/Object-getOwnPropertyNames.js:
    • proto is now a property of Object Prototype.
  • fast/js/script-tests/cyclic-prototypes.js:
    • setting an object's prototype to null removes proto setter, future usage won't set prototype.
  • fast/js/script-tests/parser-syntax-check.js:
    • Allow functions named proto
  • fast/js/script-tests/preventExtensions.js:
    • Setting proto should not throw.
  • fast/js/script-tests/prototypes.js:
    • Objects may contained own properties named proto, add new test cases.
13:11 Changeset [108258] by paroga@webkit.org

[CMake] Fix PLATFORM() define for Windows.

Define WTF_PLATFORM_WIN instead of WTF_PLATFORM_WINDOWS.

  • Source/cmake/OptionsWindows.cmake:
12:43 Changeset [108257] by benjamin@webkit.org

Make JSCSSStyleDeclaration work directly with CSS Property ID
https://bugs.webkit.org/show_bug.cgi?id=79014

Reviewed by Geoffrey Garen.

Source/WebCore:

Previously, accessing the CSS property was done by converting from
the JavaScript name to the CSS name, then converting that name to a lowercase
character array, and finally getting the CSS property ID.

This patch cut the indirection and make the code go directly from the
JavaScript name conversion to the CSS property ID.

This improves the performance mainly due to the following:
-avoid dynamic memory allocation
-cut the conversion early when possible
-do not parse the string twice
The previous fast-path optimization was removed because it is no longer
necessary with this change.

The improvement are the following:
-previous fast-path: no change
-previous slow-path: ~3 times faster

Test: fast/dom/CSSStyleDeclaration/access-longest-css-property.html
This just test the edge case of CSSPropertyName.

  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::writeWebKitPrefix):
(WebCore::writeEpubPrefix):
(WebCore::cssPropertyIDForJSCSSPropertyName):
(WebCore::isCSSPropertyName):
(WebCore::JSCSSStyleDeclaration::nameGetter):
(WebCore::JSCSSStyleDeclaration::putDelegate):

  • css/CSSParser.cpp:

(WebCore::cssPropertyID):
(WebCore):
(WebCore::cssPropertyNameIOSAliasing):

  • css/CSSParser.h:

(WebCore):

LayoutTests:

  • fast/dom/CSSStyleDeclaration/access-longest-css-property-expected.txt: Added.
  • fast/dom/CSSStyleDeclaration/access-longest-css-property.html: Added.
11:26 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
11:15 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
11:03 Changeset [108256] by mitz@apple.com

Updated Localizable.strings after r107440.

Rubber-stamped by Joseph Pecoraro.

  • English.lproj/Localizable.strings:
11:00 Changeset [108255] by ossy@webkit.org

Unreviewed gardening after r108226.
Skip tests because ENABLE(SHADOW_DOM) is disabled on these platforms.

  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
11:00 Changeset [108254] by mrobinson@webkit.org

Merging r108250

10:59 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
10:58 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
10:49 Changeset [108253] by japhet@chromium.org

Merge 108100 - 2012-02-17 Nate Chapin <japhet@chromium.org>

[Chromium mac] Cursors and background images disappear.
https://bugs.webkit.org/show_bug.cgi?id=78834

The issue occurs because a CachedImage sees that it has no clients
and decide it is safe to purge its m_data buffer. However,
StyleCachedImage is holding a CachedResourceHandle to the
CachedImage, and it can still add a client later. If it does so,
the CachedImage says everything is loaded but has no data.

Reviewed by Adam Barth.

No new tests, since the known repros have resisted reduction.
Tested manually with chrome.angrybirds.com, redfin.com and a
couple of other sites.

  • rendering/style/StyleCachedImage.cpp:
  • rendering/style/StyleCachedImage.h: Ensure the underlying

CachedImage has a client for the lifetime of the
StyleCachedImage and doesn't purge its buffer. Call
addClient(this) in the constructor and removeClient(this) in
the destructor, then ignore all cache callbacks.

TBR=japhet@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9424038

10:49 Changeset [108252] by msaboff@apple.com

Update toLower and toUpper tests for Unicode 6.1 changes
https://bugs.webkit.org/show_bug.cgi?id=78923

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • tests/mozilla/ecma/String/15.5.4.11-2.js: Updated the test

to handle a third set of results for updated Unicode 6.1
changes.
(getTestCases):
(TestCaseMultiExpected):
(writeTestCaseResultMultiExpected):
(getTestCaseResultMultiExpected):
(test):
(GetUnicodeValues):
(DecimalToHexString):

LayoutTests:

  • fast/js/script-tests/string-capitalization.js: Updated the test

to handle a new set of characters that have different results depending
on what version of Unicode the platform supports. The tests work
for Unicode 5.0 through 6.1.
(createExpected):

  • fast/js/string-capitalization-expected.txt:
10:46 Changeset [108251] by japhet@chromium.org

Merge 108100 - 2012-02-17 Nate Chapin <japhet@chromium.org>

[Chromium mac] Cursors and background images disappear.
https://bugs.webkit.org/show_bug.cgi?id=78834

The issue occurs because a CachedImage sees that it has no clients
and decide it is safe to purge its m_data buffer. However,
StyleCachedImage is holding a CachedResourceHandle to the
CachedImage, and it can still add a client later. If it does so,
the CachedImage says everything is loaded but has no data.

Reviewed by Adam Barth.

No new tests, since the known repros have resisted reduction.
Tested manually with chrome.angrybirds.com, redfin.com and a
couple of other sites.

  • rendering/style/StyleCachedImage.cpp:
  • rendering/style/StyleCachedImage.h: Ensure the underlying

CachedImage has a client for the lifetime of the
StyleCachedImage and doesn't purge its buffer. Call
addClient(this) in the constructor and removeClient(this) in
the destructor, then ignore all cache callbacks.

TBR=japhet@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9424037

10:46 Changeset [108250] by carlosgc@webkit.org

[GTK] Adding SOUP_TYPE_PROXY_RESOLVER_DEFAULT feature to soup session makes WebProcess to hang
https://bugs.webkit.org/show_bug.cgi?id=79036

Reviewed by Martin Robinson.

This looks like a bug in gobject. Initializing the WebProcess
before creating the soup session seems to fix the problem. It's
actually a workaround, but initializing the WebProcess as sson as
possible it's a good idea in any case.

  • WebProcess/gtk/WebProcessMainGtk.cpp:

(WebKit::WebProcessMainGtk):

10:43 WebKitGTK/WebKit2Roadmap edited by mrobinson@webkit.org
(diff)
10:35 Changeset [108249] by commit-queue@webkit.org

MathML internals - remove nonOperatorHeight(), hasBase()
https://bugs.webkit.org/show_bug.cgi?id=78977

Source/WebCore:

Patch by David Barton <dbarton@mathscribe.com> on 2012-02-20
Reviewed by Eric Seidel.

Stretchy operators, including embellished ones, should stretch to the largest height of
the non-stretchy items in the same explicit or implicit <mrow>.
RenderMathMLRow::layout() used to use hasBase(), isRenderMathMLOperator(), and
nonOperatorHeight() to approximate this height. We now use unembellishedOperator() to
improve this approximation, while also simplifying the code. More plainly, the code used
to skip all operators when estimating this height, instead of just the stretchy ones. We
continue to do that for now, but we more accurately skip all embellished operators
(using our currently implemented approximate de