Timeline



Feb 28, 2012:

11:31 PM Changeset in webkit [109201] by bashi@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update.

Tests in platform/chromium/rubberbanding and
platform/chromium/compositing/rubberbanding are also failing on
Mac10.5.

  • platform/chromium/test_expectations.txt:
11:25 PM Changeset in webkit [109200] by commit-queue@webkit.org
  • 6 edits
    6 adds in trunk

Microdata: Implement HTMLPropertiesCollection collection.namedItem().
https://bugs.webkit.org/show_bug.cgi?id=73156

Patch by Arko Saha <arko@motorola.com> on 2012-02-28
Reviewed by Kentaro Hara.

Source/WebCore:

Tests: fast/dom/MicroData/nameditem-must-be-case-sensitive.html

fast/dom/MicroData/nameditem-must-return-correct-item-properties.html
fast/dom/MicroData/properties-collection-nameditem-test.html

  • bindings/scripts/CodeGeneratorJS.pm: Modified code generator to generate

JS bindings code for HTMLPropertiesCollection [NamedGetter] property.
(GenerateImplementation):

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::names):
(WebCore):
(WebCore::HTMLPropertiesCollection::namedItem): Returns a NodeList object
containing any elements that add a property named name.
(WebCore::HTMLPropertiesCollection::hasNamedItem): Checks if the items can
be retrieved or not based on the property named name.

  • html/HTMLPropertiesCollection.h: Added namedItem(), hasProperty(),

hasNamedItem() methods.
(HTMLPropertiesCollection):

  • html/HTMLPropertiesCollection.idl: Added namedItem() IDL method.

LayoutTests:

Added test-cases for collection.namedItem().

  • fast/dom/MicroData/nameditem-must-be-case-sensitive-expected.txt: Added.
  • fast/dom/MicroData/nameditem-must-be-case-sensitive.html: Added.
  • fast/dom/MicroData/nameditem-must-return-correct-item-properties-expected.txt: Added.
  • fast/dom/MicroData/nameditem-must-return-correct-item-properties.html: Added.
  • fast/dom/MicroData/properties-collection-nameditem-test-expected.txt: Added.
  • fast/dom/MicroData/properties-collection-nameditem-test.html: Added.
11:19 PM Changeset in webkit [109199] by bashi@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update after r109183

Some tests in platform/chromium/rubberbanding and
platform/chromium/compositing/rubberbanding are failing.

  • platform/chromium/test_expectations.txt:
10:51 PM Changeset in webkit [109198] by kinuko@chromium.org
  • 8 edits in trunk

Add size field to Metadata in FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=79813

WebKit-svn/LayoutTests:

Changed fast/filesystem/op-get-metadata test to also test if
getMetadata returns correct file sizes.

Reviewed by David Levin.

  • fast/filesystem/op-get-metadata-expected.txt:
  • fast/filesystem/resources/op-get-metadata.js:
  • fast/filesystem/resources/op-tests-helper.js:

(createTestEnvironment.Helper.this.createSuccessCallback.entry.createWriter): Added.
(createTestEnvironment.Helper.this.createSuccessCallback):
(createTestEnvironment.Helper.this.createNextEntry):
(runOperationTest.OperationTestHelper.this.testMetadataSuccessCallback):

WebKit-svn/Source/WebCore:

Reviewed by David Levin.

Test: fast/filesystem/op-get-metadata.html

  • fileapi/FileSystemCallbacks.cpp:

(WebCore::MetadataCallbacks::didReadMetadata):

  • fileapi/Metadata.h:

(WebCore::Metadata::create):
(WebCore::Metadata::modificationTime):
(WebCore::Metadata::size): Added.
(WebCore::Metadata::Metadata):

  • fileapi/Metadata.idl:
10:49 PM Changeset in webkit [109197] by kubo@profusion.mobi
  • 4 edits in trunk

[CMake] Always build wtf as a static library.
https://bugs.webkit.org/show_bug.cgi?id=79857

Reviewed by Eric Seidel.

.:

  • CMakeLists.txt: Put static libraries in ${CMAKE_BINARY_DIR} too

to have them grouped with the shared ones.

Source/JavaScriptCore:

To help the efforts in bug 75673 to move WTF out of
JavaScriptCore, act more like the other ports and remove the
possibility of building WTF as a shared library.

It does not make much sense to, for example, ship WTF as a
separate .so with webkit-efl packages, and it should be small
enough not to cause problems during linking.

  • wtf/CMakeLists.txt:
10:40 PM Changeset in webkit [109196] by dslomov@google.com
  • 22 edits in trunk

[JSC] Implement ArrayBuffer transfer
https://bugs.webkit.org/show_bug.cgi?id=73493.
Implement ArrayBuffer transfer, per Khronos spec: http://www.khronos.org/registry/typedarray/specs/latest/#9.
This brings parity with V8 implementation of transferable typed arrays.

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Extra export.
  • wtf/ArrayBuffer.h:

(ArrayBuffer): Added extra export.

Source/WebCore:

Covered by existing tests.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::handlePostMessage):

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue):

  • bindings/js/JSHistoryCustom.cpp:

(WebCore::JSHistory::pushState):
(WebCore::JSHistory::replaceState):

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::handleInitMessageEvent):

  • bindings/js/JSMessagePortCustom.cpp:

(WebCore::fillMessagePortArray):

  • bindings/js/JSMessagePortCustom.h:

(WebCore):
(WebCore::handlePostMessage):

  • bindings/js/ScriptValue.cpp:

(WebCore::ScriptValue::serialize):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore):
(WebCore::CloneSerializer::serialize):
(CloneSerializer):
(WebCore::CloneSerializer::CloneSerializer):
(WebCore::CloneSerializer::fillTransferMap):
(WebCore::CloneSerializer::dumpArrayBufferView):
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneDeserializer::deserialize):
(WebCore::CloneDeserializer::CloneDeserializer):
(WebCore::CloneDeserializer::readTerminal):
(CloneDeserializer):
(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::transferArrayBuffers):
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::deserialize):

  • bindings/js/SerializedScriptValue.h:

(WebCore):
(SerializedScriptValue):

LayoutTests:

  • fast/canvas/webgl/arraybuffer-transfer-of-control-expected.txt:
  • fast/canvas/webgl/script-tests/arraybuffer-transfer-of-control.js: Added tests for Uint8ClampedArray
  • fast/dom/Window/window-postmessage-args-expected.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
10:36 PM Changeset in webkit [109195] by kevino@webkit.org
  • 5 edits in trunk/Source

[wx] Unreviewed. Build fixes for wx port.

10:28 PM Changeset in webkit [109194] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Refactor SpeculativeJIT::emitAllocateJSFinalObject
https://bugs.webkit.org/show_bug.cgi?id=79801

Reviewed by Filip Pizlo.

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::emitAllocateBasicJSObject): Split emitAllocateJSFinalObject out to form this
function, which is more generic in that it can allocate a variety of classes.
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::emitAllocateJSFinalObject): Changed to use the new helper function.

10:17 PM Changeset in webkit [109193] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[Forms] Spin button sometimes ignores Indeterminate of m_upDownState
https://bugs.webkit.org/show_bug.cgi?id=79754

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-02-28
Reviewed by Kent Tamura.

Source/WebCore:

This patch checks enum value Indeterminate before using m_upDownState. This make
sure Indeterminate state doesn't act like Down state.

m_upDownState can be Indeterminate at mousedown event if mouse pointer is on
spin button when it is displayed.

Test: fast/forms/number/spin-button-state.html

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::SpinButtonElement::defaultEventHandler):
(WebCore::SpinButtonElement::repeatingTimerFired):

LayoutTests:

  • fast/forms/number/spin-button-state.html: Added.
  • fast/forms/number/spin-button-state-expected.txt: Added.
10:13 PM Changeset in webkit [109192] by morrita@google.com
  • 261 edits
    2 adds
    4 deletes in trunk

[Refactoring] RenderSummary and RenderDetail is no longer needed.
https://bugs.webkit.org/show_bug.cgi?id=79641

Source/WebCore:

Reviewed by Kent Tamura.

Removed RenderDetails and RenderSummary because its only
modification they had is already handled by RenderBlock::styleWillChange().
These are just a historical artifact. We could have removed these
classes when they were switched to shadow-based implementations.

Tests: fast/html/details-inline-expected.html

fast/html/details-inline.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::createRenderer):

  • html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::createRenderer):
(WebCore::HTMLSummaryElement::defaultEventHandler):

  • rendering/RenderDetails.cpp: Removed.
  • rendering/RenderDetails.h: Removed.
  • rendering/RenderDetailsMarker.cpp:

(WebCore::RenderDetailsMarker::isOpen):

  • rendering/RenderDetailsMarker.h:

(RenderDetailsMarker):

  • rendering/RenderObject.h:

(RenderObject):

  • rendering/RenderSummary.cpp: Removed.
  • rendering/RenderSummary.h: Removed.
  • rendering/RenderingAllInOne.cpp:

LayoutTests:

Reviewed by Kent Tamura.

  • Replaced "RenderSummary" and "RenderDetails" with "RenderBlock".
  • Added a test to ensure that summmary and details behave like a "inline-block" even when "inline" is given.
  • fast/html/details-inline-expected.html: Added.
  • fast/html/details-inline.html: Added.
  • platform/chromium-linux/fast/html/details-replace-summary-child-expected.txt:
  • platform/chromium-linux/fast/html/details-replace-text-expected.txt:
  • platform/chromium-win/fast/html/details-add-child-1-expected.txt:
  • platform/chromium-win/fast/html/details-add-child-2-expected.txt:
  • platform/chromium-win/fast/html/details-add-details-child-1-expected.txt:
  • platform/chromium-win/fast/html/details-add-details-child-2-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-1-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-10-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-2-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-3-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-4-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-5-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-6-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-7-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-8-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-9-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-child-1-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-child-2-expected.txt:
  • platform/chromium-win/fast/html/details-nested-1-expected.txt:
  • platform/chromium-win/fast/html/details-nested-2-expected.txt:
  • platform/chromium-win/fast/html/details-no-summary1-expected.txt:
  • platform/chromium-win/fast/html/details-no-summary2-expected.txt:
  • platform/chromium-win/fast/html/details-no-summary3-expected.txt:
  • platform/chromium-win/fast/html/details-no-summary4-expected.txt:
  • platform/chromium-win/fast/html/details-open-javascript-expected.txt:
  • platform/chromium-win/fast/html/details-open1-expected.txt:
  • platform/chromium-win/fast/html/details-open2-expected.txt:
  • platform/chromium-win/fast/html/details-open3-expected.txt:
  • platform/chromium-win/fast/html/details-open4-expected.txt:
  • platform/chromium-win/fast/html/details-open5-expected.txt:
  • platform/chromium-win/fast/html/details-open6-expected.txt:
  • platform/chromium-win/fast/html/details-position-expected.txt:
  • platform/chromium-win/fast/html/details-remove-child-1-expected.txt:
  • platform/chromium-win/fast/html/details-remove-child-2-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-1-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-2-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-3-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-4-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-5-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-6-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-child-1-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-child-2-expected.txt:
  • platform/chromium-win/fast/html/details-replace-summary-child-expected.txt:
  • platform/chromium-win/fast/html/details-replace-text-expected.txt:
  • platform/chromium-win/fast/html/details-writing-mode-expected.txt:
  • platform/gtk/fast/html/details-add-child-1-expected.txt:
  • platform/gtk/fast/html/details-add-child-2-expected.txt:
  • platform/gtk/fast/html/details-add-details-child-1-expected.txt:
  • platform/gtk/fast/html/details-add-details-child-2-expected.txt:
  • platform/gtk/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-1-expected.txt:
  • platform/gtk/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-10-expected.txt:
  • platform/gtk/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-2-expected.txt:
  • platform/gtk/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-3-expected.txt:
  • platform/gtk/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-4-expected.txt:
  • platform/gtk/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-5-expected.txt:
  • platform/gtk/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-6-expected.txt:
  • platform/gtk/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-7-expected.txt:
  • platform/gtk/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-8-expected.txt:
  • platform/gtk/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/gtk/fast/html/details-add-summary-9-expected.txt:
  • platform/gtk/fast/html/details-add-summary-child-1-expected.txt:
  • platform/gtk/fast/html/details-add-summary-child-2-expected.txt:
  • platform/gtk/fast/html/details-nested-1-expected.txt:
  • platform/gtk/fast/html/details-nested-2-expected.txt:
  • platform/gtk/fast/html/details-no-summary1-expected.txt:
  • platform/gtk/fast/html/details-no-summary2-expected.txt:
  • platform/gtk/fast/html/details-no-summary3-expected.txt:
  • platform/gtk/fast/html/details-no-summary4-expected.txt:
  • platform/gtk/fast/html/details-open-javascript-expected.txt:
  • platform/gtk/fast/html/details-open1-expected.txt:
  • platform/gtk/fast/html/details-open2-expected.txt:
  • platform/gtk/fast/html/details-open3-expected.txt:
  • platform/gtk/fast/html/details-open4-expected.txt:
  • platform/gtk/fast/html/details-open5-expected.txt:
  • platform/gtk/fast/html/details-open6-expected.txt:
  • platform/gtk/fast/html/details-position-expected.txt:
  • platform/gtk/fast/html/details-remove-child-1-expected.txt:
  • platform/gtk/fast/html/details-remove-child-2-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-1-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-2-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-3-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-4-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-5-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-6-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-child-1-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-child-2-expected.txt:
  • platform/gtk/fast/html/details-replace-summary-child-expected.txt:
  • platform/gtk/fast/html/details-replace-text-expected.txt:
  • platform/gtk/fast/html/details-writing-mode-expected.txt:
  • platform/mac/fast/html/details-add-child-1-expected.txt:
  • platform/mac/fast/html/details-add-child-2-expected.txt:
  • platform/mac/fast/html/details-add-details-child-1-expected.txt:
  • platform/mac/fast/html/details-add-details-child-2-expected.txt:
  • platform/mac/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-1-expected.txt:
  • platform/mac/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-10-expected.txt:
  • platform/mac/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-2-expected.txt:
  • platform/mac/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-3-expected.txt:
  • platform/mac/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-4-expected.txt:
  • platform/mac/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-5-expected.txt:
  • platform/mac/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-6-expected.txt:
  • platform/mac/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-7-expected.txt:
  • platform/mac/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-8-expected.txt:
  • platform/mac/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-9-expected.txt:
  • platform/mac/fast/html/details-add-summary-child-1-expected.txt:
  • platform/mac/fast/html/details-add-summary-child-2-expected.txt:
  • platform/mac/fast/html/details-nested-1-expected.txt:
  • platform/mac/fast/html/details-nested-2-expected.txt:
  • platform/mac/fast/html/details-no-summary1-expected.txt:
  • platform/mac/fast/html/details-no-summary2-expected.txt:
  • platform/mac/fast/html/details-no-summary3-expected.txt:
  • platform/mac/fast/html/details-no-summary4-expected.txt:
  • platform/mac/fast/html/details-open-javascript-expected.txt:
  • platform/mac/fast/html/details-open1-expected.txt:
  • platform/mac/fast/html/details-open2-expected.txt:
  • platform/mac/fast/html/details-open3-expected.txt:
  • platform/mac/fast/html/details-open4-expected.txt:
  • platform/mac/fast/html/details-open5-expected.txt:
  • platform/mac/fast/html/details-open6-expected.txt:
  • platform/mac/fast/html/details-position-expected.txt:
  • platform/mac/fast/html/details-remove-child-1-expected.txt:
  • platform/mac/fast/html/details-remove-child-2-expected.txt:
  • platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-1-expected.txt:
  • platform/mac/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-2-expected.txt:
  • platform/mac/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-3-expected.txt:
  • platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-4-expected.txt:
  • platform/mac/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-5-expected.txt:
  • platform/mac/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-6-expected.txt:
  • platform/mac/fast/html/details-remove-summary-child-1-expected.txt:
  • platform/mac/fast/html/details-remove-summary-child-2-expected.txt:
  • platform/mac/fast/html/details-replace-summary-child-expected.txt:
  • platform/mac/fast/html/details-replace-text-expected.txt:
  • platform/mac/fast/html/details-writing-mode-expected.txt:
  • platform/qt/fast/html/details-add-child-1-expected.txt:
  • platform/qt/fast/html/details-add-child-2-expected.txt:
  • platform/qt/fast/html/details-add-details-child-1-expected.txt:
  • platform/qt/fast/html/details-add-details-child-2-expected.txt:
  • platform/qt/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-1-expected.txt:
  • platform/qt/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-10-expected.txt:
  • platform/qt/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-2-expected.txt:
  • platform/qt/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-3-expected.txt:
  • platform/qt/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-4-expected.txt:
  • platform/qt/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-5-expected.txt:
  • platform/qt/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-6-expected.txt:
  • platform/qt/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-7-expected.txt:
  • platform/qt/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-8-expected.txt:
  • platform/qt/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-9-expected.txt:
  • platform/qt/fast/html/details-add-summary-child-1-expected.txt:
  • platform/qt/fast/html/details-add-summary-child-2-expected.txt:
  • platform/qt/fast/html/details-nested-1-expected.txt:
  • platform/qt/fast/html/details-nested-2-expected.txt:
  • platform/qt/fast/html/details-no-summary1-expected.txt:
  • platform/qt/fast/html/details-no-summary2-expected.txt:
  • platform/qt/fast/html/details-no-summary3-expected.txt:
  • platform/qt/fast/html/details-no-summary4-expected.txt:
  • platform/qt/fast/html/details-open-javascript-expected.txt:
  • platform/qt/fast/html/details-open1-expected.txt:
  • platform/qt/fast/html/details-open2-expected.txt:
  • platform/qt/fast/html/details-open3-expected.txt:
  • platform/qt/fast/html/details-open4-expected.txt:
  • platform/qt/fast/html/details-open5-expected.txt:
  • platform/qt/fast/html/details-open6-expected.txt:
  • platform/qt/fast/html/details-position-expected.txt:
  • platform/qt/fast/html/details-remove-child-1-expected.txt:
  • platform/qt/fast/html/details-remove-child-2-expected.txt:
  • platform/qt/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/qt/fast/html/details-remove-summary-1-expected.txt:
  • platform/qt/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/qt/fast/html/details-remove-summary-2-expected.txt:
  • platform/qt/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/qt/fast/html/details-remove-summary-3-expected.txt:
  • platform/qt/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/qt/fast/html/details-remove-summary-4-expected.txt:
  • platform/qt/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/qt/fast/html/details-remove-summary-5-expected.txt:
  • platform/qt/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/qt/fast/html/details-remove-summary-6-expected.txt:
  • platform/qt/fast/html/details-remove-summary-child-1-expected.txt:
  • platform/qt/fast/html/details-remove-summary-child-2-expected.txt:
  • platform/qt/fast/html/details-replace-summary-child-expected.txt:
  • platform/qt/fast/html/details-replace-text-expected.txt:
  • platform/qt/fast/html/details-writing-mode-expected.txt:
10:09 PM Changeset in webkit [109191] by hayato@chromium.org
  • 5 edits in trunk/LayoutTests

[Shadow DOM] Make createDOM() function used in testing Shadow DOM more flexible.
https://bugs.webkit.org/show_bug.cgi?id=79745

Reviewed by Dimitri Glazkov.

Replaces createDom and createShadow function defined in
LayoutTests/fast/dom/shadow/create-dom.js with more flexible
one. Now we can represent a shadow host which has both light
children and ShadowRoots in one expression.

  • fast/dom/shadow/access-key.html:
  • fast/dom/shadow/get-element-by-id-in-shadow-root.html:
  • fast/dom/shadow/resources/create-dom.js:

(createShadowRoot):
(createDOM):

  • fast/dom/shadow/shadow-boundary-events.html:
10:06 PM Changeset in webkit [109190] by rniwa@webkit.org
  • 6 edits in trunk

perf-o-matic: generate dashboard images using Google Chart Tools
https://bugs.webkit.org/show_bug.cgi?id=79838

Reviewed by Hajime Morita.

Rename RunsJSONGenerator to Runs and added an ability to generate parameters for Google chart tool.
Also added RunsChartHandler to make url-fetches these images and DashboardImageHandler to serve them.
The image is stored in DashboardImage model.

We can't enable flip the switch to use images yet because we don't create images on fly (they're
generated when runs are updated; i.e. bots upload new results). We should be able to flip the switch
once this patch lands and all perf bots cycle.

We probably make way too many calls to Google chart tool's server with this preliminary design but we
can easily move this task into the backend and run it via a cron job once we know it works.

  • Websites/webkit-perf.appspot.com/controller.py:

(schedule_runs_update):
(RunsUpdateHandler.post):
(RunsChartHandler):
(RunsChartHandler.get):
(RunsChartHandler.post):
(DashboardImageHandler):
(DashboardImageHandler.get):
(schedule_report_process):

  • Websites/webkit-perf.appspot.com/json_generators.py:

(ManifestJSONGenerator.value):
(Runs):
(Runs.init):
(Runs.value):
(Runs.chart_params):

  • Websites/webkit-perf.appspot.com/json_generators_unittest.py:

(RunsTest):
(RunsTest._create_results):
(RunsTest.test_generate_runs):
(RunsTest.test_value_without_results):
(RunsTest.test_value_with_results):
(RunsTest.test_run_from_build_and_result):
(RunsTest.test_chart_params_with_value):
(RunsTest.test_chart_params_with_value.split_as_int):

  • Websites/webkit-perf.appspot.com/main.py:
  • Websites/webkit-perf.appspot.com/models.py:

(PersistentCache.get_cache):
(DashboardImage):
(DashboardImage.key_name):

9:35 PM Changeset in webkit [109189] by dcheng@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r107917 and r109188.
http://trac.webkit.org/changeset/107917
http://trac.webkit.org/changeset/109188
https://bugs.webkit.org/show_bug.cgi?id=79865

Fix the chromium build. (Requested by dcheng on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-28

  • src/WebDragData.cpp:

(WebKit::WebDragData::items):

9:16 PM Changeset in webkit [109188] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Chromium build fix attempt.

  • src/WebDragData.cpp:
8:48 PM Changeset in webkit [109187] by bashi@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update

svg/W3C-SVG-1.1/animate-elem-37-t.svg is failing on Win.

  • platform/chromium/test_expectations.txt:
8:46 PM Changeset in webkit [109186] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Optimize the rects being drawn into compositing layers
https://bugs.webkit.org/show_bug.cgi?id=79852

Reviewed by Dan Bernstein.

Use the newly added WebKitSystemInterface method
to limit the area being painted in a CALayer
-drawInContext callback. This avoids redundant drawing,
for performance.

  • platform/graphics/mac/WebLayer.mm:

(drawLayerContents):

8:25 PM Changeset in webkit [109185] by bashi@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update after r109176

  • platform/chromium/test_expectations.txt:
8:25 PM Changeset in webkit [109184] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Fix the SnowLeopard build.

  • WebCore.exp.in:
6:36 PM Changeset in webkit [109183] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

With tiled drawing enabled, pressing Down arrow after scrolling via mouse gesture causes page to jump back up to top
https://bugs.webkit.org/show_bug.cgi?id=79249
<rdar://problem/10866273>

Reviewed by Sam Weinig.

ScrollableArea::notifyScrollPositionChanged must make sure that the scroll animator position is kept up to date.

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::setCurrentPosition):
(WebCore):

  • platform/ScrollAnimator.h:

(ScrollAnimator):

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::notifyScrollPositionChanged):

6:20 PM Changeset in webkit [109182] by dcheng@chromium.org
  • 32 edits
    2 deletes in trunk

Unreviewed, rolling out r107894.
http://trac.webkit.org/changeset/107894
https://bugs.webkit.org/show_bug.cgi?id=30416

dataTransfer.types should be an Array since DOMStringList is deprecated.

Source/WebCore:

  • bindings/js/JSClipboardCustom.cpp:

(WebCore::JSClipboard::types):
(WebCore):

  • bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::typesAccessorGetter):
(WebCore):

  • dom/Clipboard.cpp:

(WebCore::Clipboard::hasStringOfType):

  • dom/Clipboard.h:

(Clipboard):

  • dom/Clipboard.idl:
  • platform/blackberry/ClipboardBlackBerry.cpp:

(WebCore::ClipboardBlackBerry::types):

  • platform/blackberry/ClipboardBlackBerry.h:

(ClipboardBlackBerry):

  • platform/chromium/ChromiumDataObject.cpp:

(WebCore::ChromiumDataObject::types):

  • platform/chromium/ChromiumDataObject.h:

(ChromiumDataObject):

  • platform/chromium/ClipboardChromium.cpp:

(WebCore::ClipboardChromium::types):
(WebCore::ClipboardChromium::mayUpdateItems):

  • platform/chromium/ClipboardChromium.h:

(ClipboardChromium):

  • platform/chromium/DragDataChromium.cpp:

(WebCore::containsHTML):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::containsPlainText):
(WebCore::DragData::canSmartReplace):
(WebCore::DragData::asFragment):

  • platform/efl/ClipboardEfl.cpp:

(WebCore::ClipboardEfl::types):

  • platform/efl/ClipboardEfl.h:

(ClipboardEfl):

  • platform/gtk/ClipboardGtk.cpp:

(WebCore::ClipboardGtk::types):

  • platform/gtk/ClipboardGtk.h:

(ClipboardGtk):

  • platform/mac/ClipboardMac.h:

(ClipboardMac):

  • platform/mac/ClipboardMac.mm:

(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::ClipboardMac::types):

  • platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::types):

  • platform/qt/ClipboardQt.h:

(ClipboardQt):

  • platform/win/ClipboardWin.cpp:

(WebCore::addMimeTypesForFormat):
(WebCore::ClipboardWin::types):

  • platform/win/ClipboardWin.h:

(ClipboardWin):

  • platform/wx/ClipboardWx.cpp:

(WebCore::ClipboardWx::types):

  • platform/wx/ClipboardWx.h:

(ClipboardWx):

LayoutTests:

  • editing/pasteboard/clipboard-customData.html:
  • editing/pasteboard/onpaste-text-html-types.html:
  • fast/events/drag-and-drop-dataTransfer-types-nocrash.html:
  • fast/events/drag-customData.html:
  • fast/events/drag-dataTransfer-live-attributes-expected.txt: Removed.
  • fast/events/drag-dataTransfer-live-attributes.html: Removed.
  • http/tests/local/fileapi/resources/setup-file-input-element-for-drag.js:
  • http/tests/security/clipboard/script-tests/clipboard-file-access.js:

(checkForEventTransferType):

6:03 PM Changeset in webkit [109181] by Simon Fraser
  • 13 edits in trunk

Update WebKitSystemInterface.

Source/WebCore:

Reviewed by Sam Weinig.

  • WebCore.exp.in:

(drawLayerContents):

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

Reviewed by Sam Weinig.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

Reviewed by Sam Weinig.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

WebKitLibraries:

Reviewed by Sam Weinig.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
5:44 PM Changeset in webkit [109180] by commit-queue@webkit.org
  • 2 edits in trunk

Add new GPU builders to flakiness dashboard.
https://bugs.webkit.org/show_bug.cgi?id=79839

Patch by Dave Tu <dtu@chromium.org> on 2012-02-28
Reviewed by Ojan Vafai.

  • Tools/TestResultServer/static-dashboards/builders.js:
5:43 PM Changeset in webkit [109179] by morrita@google.com
  • 14 edits
    2 adds in trunk

<content> element should behave as HTMLUnknownElement outside of a shadow DOM subtree
https://bugs.webkit.org/show_bug.cgi?id=79551

Reviewed by Dimitri Glazkov.

Source/WebCore:

The problem happened because HTMLContentElement doesn't create renderer anytime.

This change allows it to create a renderer unless the HTMLContentElement is shadowed.
Since this could happen not only on <content> but also on upcoming <shadow>,
the corresponding part of the code is pulled up to InsertionPoint.

Tests: fast/dom/shadow/content-element-outside-shadow-style-expected.html

fast/dom/shadow/content-element-outside-shadow-style.html

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):

  • dom/ShadowRoot.h:

(WebCore):
(WebCore::TreeScope::isShadowRoot):

  • dom/TreeScope.h:

(TreeScope):

  • html/shadow/HTMLContentElement.h:
  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::isShadowBoundary):
(WebCore):

  • html/shadow/InsertionPoint.h:

(InsertionPoint):
(WebCore::isShadowBoundary):
(WebCore):

LayoutTests:

  • fast/dom/shadow/content-element-outside-shadow-style-expected.html: Added.
  • fast/dom/shadow/content-element-outside-shadow-style.html: Added.
  • fast/dom/shadow/content-element-outside-shadow.html:
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wk2/Skipped:
5:40 PM Changeset in webkit [109178] by eae@chromium.org
  • 3 edits in branches/subpixellayout/Source

qt build fixes for branch post r109122.

5:39 PM Changeset in webkit [109177] by barraclough@apple.com
  • 13 edits in trunk

Get?/Put? for primitives should not wrap on strict accessor call
https://bugs.webkit.org/show_bug.cgi?id=79588

Reviewed by Oliver Hunt.

In the case of Get?, this is a pretty trivial bug - just don't wrap
primitives at the point you call a getter.

For setters, this is a little more involved, since we have already wrapped
the value up in a synthesized object. Stop doing so. There is also a further
subtely, that in strict mode all attempts to create a new data property on
the object should throw.

Source/JavaScriptCore:

  • runtime/JSCell.cpp:

(JSC::JSCell::put):

  • Put? to a string primitive should use JSValue::putToPrimitive.
  • runtime/JSObject.cpp:

(JSC::JSObject::put):

  • Remove static function called in one place.
  • runtime/JSObject.h:

(JSC::JSValue::put):

  • Put? to a non-cell JSValue should use JSValue::putToPrimitive.
  • runtime/JSValue.cpp:

(JSC::JSValue::synthesizePrototype):

  • Add support for synthesizing the prototype of strings.

(JSC::JSValue::putToPrimitive):

  • Added, implements Put? for primitive bases, per 8.7.2.
  • runtime/JSValue.h:

(JSValue):

  • Add declaration for JSValue::putToPrimitive.
  • runtime/PropertySlot.cpp:

(JSC::PropertySlot::functionGetter):

  • Don't call ToObject on primitive this values.

LayoutTests:

  • fast/js/mozilla/strict/15.5.5.1-expected.txt:
  • fast/js/primitive-property-access-edge-cases-expected.txt:
  • fast/js/read-modify-eval-expected.txt:
  • fast/js/script-tests/primitive-property-access-edge-cases.js:
  • fast/js/script-tests/read-modify-eval.js:
    • Added new test cases & updated test results.
5:31 PM Changeset in webkit [109176] by dcheng@chromium.org
  • 28 edits in trunk

Clipboard::getData should return an empty string instead of undefined
https://bugs.webkit.org/show_bug.cgi?id=79712

Reviewed by Tony Chang.

Source/WebCore:

Per the spec, an empty string should be returned when there is no data for the given typestring.

Test: fast/events/dataTransfer-getData-returns-empty-string.html

  • bindings/js/JSClipboardCustom.cpp:
  • bindings/v8/custom/V8ClipboardCustom.cpp:
  • dom/Clipboard.h:

(Clipboard):

  • dom/Clipboard.idl:
  • platform/blackberry/ClipboardBlackBerry.cpp:

(WebCore::ClipboardBlackBerry::getData):

  • platform/blackberry/ClipboardBlackBerry.h:

(ClipboardBlackBerry):

  • platform/chromium/ClipboardChromium.cpp:

(WebCore::ClipboardChromium::getData):

  • platform/chromium/ClipboardChromium.h:

(ClipboardChromium):

  • platform/efl/ClipboardEfl.cpp:

(WebCore::ClipboardEfl::getData):

  • platform/efl/ClipboardEfl.h:

(ClipboardEfl):

  • platform/gtk/ClipboardGtk.cpp:

(WebCore::ClipboardGtk::getData):

  • platform/gtk/ClipboardGtk.h:

(ClipboardGtk):

  • platform/mac/ClipboardMac.h:

(ClipboardMac):

  • platform/mac/ClipboardMac.mm:

(WebCore::ClipboardMac::getData):

  • platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::getData):

  • platform/qt/ClipboardQt.h:

(ClipboardQt):

  • platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::getFullCFHTML):
(WebCore::getURL):
(WebCore::getPlainText):
(WebCore::getTextHTML):
(WebCore::getCFHTML):
(WebCore::fragmentFromHTML):

  • platform/win/ClipboardUtilitiesWin.h:

(WebCore):

  • platform/win/ClipboardWin.cpp:

(WebCore::ClipboardWin::getData):

  • platform/win/ClipboardWin.h:

(ClipboardWin):

  • platform/wx/ClipboardWx.cpp:

(WebCore::ClipboardWx::getData):

  • platform/wx/ClipboardWx.h:

(ClipboardWx):

LayoutTests:

  • fast/events/dataTransfer-getData-returns-empty-string-expected.txt: Added.
  • fast/events/dataTransfer-getData-returns-empty-string.html: Added.
  • http/tests/local/drag-over-remote-content-expected.txt:
  • http/tests/security/drag-over-remote-content-iframe-expected.txt:
  • http/tests/security/drag-over-remote-content-iframe.html:
5:28 PM Changeset in webkit [109175] by bashi@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Uninitialized value in LocaleToScriptCodeForFontSelection
https://bugs.webkit.org/show_bug.cgi?id=79779

Set USCRIPT_COMMON to scriptCode as the initial value.

Reviewed by Kent Tamura.

No new tests. No behavior change.

  • platform/text/LocaleToScriptMappingICU.cpp:

(WebCore::localeToScriptCodeForFontSelection):

5:26 PM Changeset in webkit [109174] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Re-enable parallel GC on Mac
https://bugs.webkit.org/show_bug.cgi?id=79837

Rubber stamped by Filip Pizlo.

  • runtime/Options.cpp:

(JSC::Options::initializeOptions): We accidentally disabled parallel GC with this line,
so we removed it and things should go back to normal.

5:17 PM Changeset in webkit [109173] by kbr@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] Work around IOSurface-related corruption during readback
https://bugs.webkit.org/show_bug.cgi?id=79735

Reviewed by James Robinson.

Copy the compositor's IOSurface-backed output into a temporary
texture and perform the ReadPixels operation against that texture.

It is infeasible to write an automated test for this issue.
Tested manually by performing print preview multiple times against
pages containing WebGL content on 10.7 and observing that the
corruption in the output is no longer present.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::getFramebufferPixels):

5:13 PM Changeset in webkit [109172] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Some run-javascriptcore-tests broken for 32-bit debug
https://bugs.webkit.org/show_bug.cgi?id=79844

Rubber stamped by Oliver Hunt.

These assertions are just plain wrong for 32-bit. We could either have a massive
assertion that depends on value representation, that has to be changed every
time we change the JITs, resulting in a bug tail of debug-mode crashes, or we
could get rid of the assertions. I pick the latter.

  • dfg/DFGOperations.cpp:
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

5:12 PM Changeset in webkit [109171] by enne@google.com
  • 4 edits in trunk/Source/WebCore

[chromium] Inform v8 about extra memory used for PatternSkia clamp mode
https://bugs.webkit.org/show_bug.cgi?id=79846

Reviewed by James Robinson.

For large images, creating a non-repeating Pattern in Skia can
allocate a lot of memory. Inform v8 about this so that it can
potentially garbage collect any Pattern objects that aren't being used
and that are holding onto large image copies.

  • platform/graphics/Pattern.cpp:

(WebCore::Pattern::Pattern):

  • platform/graphics/Pattern.h:

(Pattern):

  • platform/graphics/skia/PatternSkia.cpp:

(WebCore::Pattern::platformDestroy):
(WebCore::Pattern::platformPattern):

4:38 PM Changeset in webkit [109170] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, mark another compositing test as flaky.
https://bugs.webkit.org/show_bug.cgi?id=79823

  • platform/chromium/test_expectations.txt:
4:37 PM Changeset in webkit [109169] by commit-queue@webkit.org
  • 4 edits in trunk

All mouse events after a right click are ignored when they came from WebkitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=77350

Patch by Hugo Parente Lima <Hugo Parente Lima> on 2012-02-28
Reviewed by Chang Shu.

Source/WebKit2:

Never ignore mouse events when using sync events, even if the context menu is being
show but the Ui did replied the ShowContextMenu event with a ContextMenuHidden.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::mouseEventSyncForTesting):

LayoutTests:

Unskip fast/events/mouse-click-events.html.

  • platform/qt-5.0-wk2/Skipped:
4:27 PM Changeset in webkit [109168] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[chromium] Reset damage tracker on visibility change.
https://bugs.webkit.org/show_bug.cgi?id=79267

Patch by Jonathan Backer <backer@chromium.org> on 2012-02-28
Reviewed by James Robinson.

Source/WebCore:

Unit tests: CCLayerTreeHostImplTest.cpp

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::setVisible):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::PartialSwapTrackerContext::getString):
(WebKit):
(WebKit::TEST_F):

4:14 PM Changeset in webkit [109167] by commit-queue@webkit.org
  • 5 edits
    136 adds in trunk/LayoutTests

[Qt] Unskip compositing & 3d-rendering tests
https://bugs.webkit.org/show_bug.cgi?id=78687

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-02-28
Reviewed by Noam Rosenthal.

  • platform/qt-4.8/Skipped:
  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0-wk2/compositing/animation/busy-indicator-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/animation/state-at-end-event-transform-layer-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/animation/state-at-end-event-transform-layer-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/color-matching/image-color-matching-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/color-matching/image-color-matching-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/color-matching/pdf-image-match-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/color-matching/pdf-image-match-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/compositing-visible-descendant-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/compositing-visible-descendant-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/direct-image-compositing-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/direct-image-compositing-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/framesets/composited-frame-alignment-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/generated-content-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/generated-content-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/geometry/abs-position-inside-opacity-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/geometry/abs-position-inside-opacity-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/geometry/clipping-foreground-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/geometry/clipping-foreground-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/geometry/composited-html-size-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/geometry/composited-html-size-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/geometry/fixed-in-composited-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/geometry/fixed-in-composited-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/geometry/fixed-position-composited-page-scale-down-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/geometry/fixed-position-composited-page-scale-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/geometry/fixed-position-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/geometry/fixed-position-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/geometry/foreground-layer-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/geometry/horizontal-scroll-composited-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/geometry/layer-due-to-layer-children-deep-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/geometry/layer-due-to-layer-children-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/geometry/outline-change-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/geometry/outline-change-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/geometry/partial-layout-update-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/geometry/partial-layout-update-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/geometry/preserve-3d-switching-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/geometry/repaint-foreground-layer-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/geometry/root-layer-update-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/geometry/root-layer-update-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/geometry/vertical-scroll-composited-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/geometry/vertical-scroll-composited-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/geometry/video-fixed-scrolling-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/geometry/video-fixed-scrolling-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/composited-iframe-alignment-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/iframes/composited-iframe-alignment-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/iframe-copy-on-scroll-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/iframes/iframe-copy-on-scroll-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/iframe-in-composited-layer-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/iframes/iframe-in-composited-layer-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/iframes/resizer-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/iframes/resizer-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/images/direct-image-background-color-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/images/direct-image-background-color-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/layer-creation/spanOverlapsCanvas-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/layers-inside-overflow-scroll-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/layers-inside-overflow-scroll-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/overflow/fixed-position-ancestor-clip-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/overflow/fixed-position-ancestor-clip-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/overflow/overflow-compositing-descendant-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/overflow/overflow-compositing-descendant-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/overflow/overflow-positioning-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/overflow/overflow-positioning-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/overflow/overflow-scroll-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/overflow/overflow-scroll-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/overflow/parent-overflow-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/overflow/parent-overflow-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/overflow/scroll-ancestor-update-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/overflow/scroll-ancestor-update-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/overflow/scrollbar-painting-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/overflow/scrollbar-painting-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/overflow/theme-affects-visual-overflow-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/overflow/theme-affects-visual-overflow-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/plugins/composited-plugin-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/plugins/composited-plugin-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/repaint/become-overlay-composited-layer-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/repaint/become-overlay-composited-layer-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/repaint/composited-document-element-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/repaint/composited-document-element-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/repaint/content-into-overflow-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/repaint/content-into-overflow-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/repaint/layer-repaint-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/repaint/layer-repaint-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/repaint/layer-repaint-rects-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/repaint/layer-repaint-rects-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/repaint/opacity-between-absolute-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/repaint/opacity-between-absolute-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/repaint/opacity-between-absolute2-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/repaint/opacity-between-absolute2-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/repaint/overflow-into-content-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/repaint/overflow-into-content-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/repaint/same-size-invalidation-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/scaling/tiled-layer-recursion-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/self-painting-layers-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/self-painting-layers-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/shadows/shadow-drawing-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/shadows/shadow-drawing-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/sibling-positioning-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/sibling-positioning-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/text-on-large-layer-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/text-on-large-layer-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/transitions/scale-transition-no-start-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/transitions/scale-transition-no-start-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/transitions/singular-scale-transition-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/transitions/singular-scale-transition-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/video/video-background-color-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/video/video-background-color-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/visibility/visibility-composited-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/visibility/visibility-composited-transforms-expected.txt: Added.
  • platform/qt/Skipped:
4:10 PM Changeset in webkit [109166] by Lucas Forschler
  • 2 edits in trunk/Tools

Fix a typo in config.json
linx -> linux

  • BuildSlaveSupport/build.webkit.org-config/config.json:
4:07 PM Changeset in webkit [109165] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Remove suppressions of SVG crash flakiness on cr-mac
https://bugs.webkit.org/show_bug.cgi?id=79707

Unreviewed gardening.

The suspect cause of these failures was rolled out in r109164.
Removing the suppressions to see if the rollout fixes them.

  • platform/chromium/test_expectations.txt:
4:03 PM Changeset in webkit [109164] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, mark another compositing as flaky.
https://bugs.webkit.org/show_bug.cgi?id=79823

  • platform/chromium/test_expectations.txt:
3:58 PM Changeset in webkit [109163] by commit-queue@webkit.org
  • 10 edits in trunk/LayoutTests

No extra silence needed in multi-channels support layout test cases
https://bugs.webkit.org/show_bug.cgi?id=79752

Patch by Wei James <james.wei@intel.com> on 2012-02-28
Reviewed by Chris Rogers.

  • webaudio/audiobuffersource-multi-channels-expected.wav:
  • webaudio/audiobuffersource-multi-channels.html:
  • webaudio/resources/mix-testing.js:
  • webaudio/up-mixing-mono-51-expected.wav:
  • webaudio/up-mixing-mono-51.html:
  • webaudio/up-mixing-mono-stereo-expected.wav:
  • webaudio/up-mixing-mono-stereo.html:
  • webaudio/up-mixing-stereo-51-expected.wav:
  • webaudio/up-mixing-stereo-51.html:
3:53 PM Changeset in webkit [109162] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Unreviewed, rolling out r108834.
http://trac.webkit.org/changeset/108834
https://bugs.webkit.org/show_bug.cgi?id=79840

Seems to cause a number of crashes under
FrameView::doDeferredRepaints (Requested by jamesr on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-28

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::draw):

  • svg/graphics/SVGImage.h:
  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::imageContentChanged):
(WebCore::SVGImageCache::redrawTimerFired):

  • svg/graphics/SVGImageCache.h:

(SVGImageCache):

3:44 PM Changeset in webkit [109161] by mario@webkit.org
  • 3 edits in trunk/Source/WebCore

[GTK] Add support for nested event loops in RunLoop
https://bugs.webkit.org/show_bug.cgi?id=79499

Reviewed by Martin Robinson.

Run a new nested mainloop if the main event loop is already
running when calling to RunLoop::run(), and take care of stopping
the right main loop too when RunLoop::stop() is invoked.

  • platform/RunLoop.h:

(RunLoop):

  • platform/gtk/RunLoopGtk.cpp:

(WebCore::RunLoop::RunLoop):
(WebCore::RunLoop::~RunLoop):
(WebCore::RunLoop::run):
(WebCore::RunLoop::innermostLoop):
(WebCore::RunLoop::pushNestedMainLoop):
(WebCore::RunLoop::popNestedMainLoop):
(WebCore):
(WebCore::RunLoop::stop):

3:28 PM Changeset in webkit [109160] by eae@chromium.org
  • 5 edits in branches/subpixellayout/Source

Revert absoluteCaretBounds to IntRect on branch.

3:16 PM Changeset in webkit [109159] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

More build fix.

  • WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm: Check for build platform properly.
3:15 PM Changeset in webkit [109158] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Get rid of padding cruft in CopiedBlock
https://bugs.webkit.org/show_bug.cgi?id=79686

Reviewed by Filip Pizlo.

  • heap/CopiedBlock.h:

(CopiedBlock): Removed the extra padding that was used for alignment purposes until
the calculation of the payload offset into CopiedBlocks was redone recently.

3:09 PM Changeset in webkit [109157] by jchaffraix@webkit.org
  • 6 edits in trunk/Source/WebCore

Move RenderLayer::size() calls to a common function
https://bugs.webkit.org/show_bug.cgi?id=76972

Reviewed by Simon Fraser.

Refactoring only.

This change introduces RenderBox::cachedSizeForOverflowClip() that handles all the cached size
requests that currently goes through the RenderLayer. This indirection helps to decouple the need
for a RenderLayer so that we can lazily allocate RenderLayers as part of bug 75568.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::cachedSizeForOverflowClip):
Added this function to handle the calls to RenderLayer's size(). Unfortunately a lot of the
code calls RenderLayer::size() directly so I could not make it private.

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeRectForRepaint):

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::clippedOverflowRectForRepaint):
(WebCore::RenderInline::computeRectForRepaint):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::computeRectForRepaint):
Fixed the call sites above.

3:08 PM Changeset in webkit [109156] by dino@apple.com
  • 6 edits
    32 moves
    10 adds
    4 deletes in trunk/LayoutTests

Move custom filter tests into subdir to make them easier to skip https://bugs.webkit.org/show_bug.cgi?id=79825

Reviewed by Simon Fraser.

Moved all CSS Shader tests into a 'custom' sub-directory. Added this directory
to the relevant skip lists.

  • css3/filters/custom-filter-property-computed-style.html: Removed.
  • css3/filters/custom-filter-property-parsing-invalid.html: Removed.
  • css3/filters/custom-filter-property-parsing.html: Removed.
  • css3/filters/custom/custom-filter-property-computed-style-expected.txt: Renamed from LayoutTests/css3/filters/custom-filter-property-computed-style-expected.txt.
  • css3/filters/custom/custom-filter-property-computed-style.html: Added.
  • css3/filters/custom/custom-filter-property-parsing-expected.txt: Renamed from LayoutTests/css3/filters/custom-filter-property-parsing-expected.txt.
  • css3/filters/custom/custom-filter-property-parsing-invalid-expected.txt: Renamed from LayoutTests/css3/filters/custom-filter-property-parsing-invalid-expected.txt.
  • css3/filters/custom/custom-filter-property-parsing-invalid.html: Added.
  • css3/filters/custom/custom-filter-property-parsing.html: Added.
  • css3/filters/custom/custom-filter-shader-cache-expected.png: Renamed from LayoutTests/css3/filters/custom-filter-shader-cache-expected.png.
  • css3/filters/custom/custom-filter-shader-cache-expected.txt: Renamed from LayoutTests/css3/filters/custom-filter-shader-cache-expected.txt.
  • css3/filters/custom/custom-filter-shader-cache.html: Renamed from LayoutTests/css3/filters/custom-filter-shader-cache.html.
  • css3/filters/custom/effect-custom-combined-missing-expected.png: Renamed from LayoutTests/css3/filters/effect-custom-combined-missing-expected.png.
  • css3/filters/custom/effect-custom-combined-missing-expected.txt: Renamed from LayoutTests/css3/filters/effect-custom-combined-missing-expected.txt.
  • css3/filters/custom/effect-custom-combined-missing.html: Renamed from LayoutTests/css3/filters/effect-custom-combined-missing.html.
  • css3/filters/custom/effect-custom-disabled-expected.txt: Renamed from LayoutTests/css3/filters/effect-custom-disabled-expected.txt.
  • css3/filters/custom/effect-custom-disabled.html: Added.
  • css3/filters/custom/effect-custom-expected.png: Renamed from LayoutTests/css3/filters/effect-custom-expected.png.
  • css3/filters/custom/effect-custom-expected.txt: Renamed from LayoutTests/css3/filters/effect-custom-expected.txt.
  • css3/filters/custom/effect-custom-parameters-expected.png: Renamed from LayoutTests/css3/filters/effect-custom-parameters-expected.png.
  • css3/filters/custom/effect-custom-parameters-expected.txt: Renamed from LayoutTests/css3/filters/effect-custom-parameters-expected.txt.
  • css3/filters/custom/effect-custom-parameters.html: Renamed from LayoutTests/css3/filters/effect-custom-parameters.html.
  • css3/filters/custom/effect-custom.html: Renamed from LayoutTests/css3/filters/effect-custom.html.
  • css3/filters/custom/missing-custom-filter-shader-expected.png: Renamed from LayoutTests/css3/filters/missing-custom-filter-shader-expected.png.
  • css3/filters/custom/missing-custom-filter-shader-expected.txt: Renamed from LayoutTests/css3/filters/missing-custom-filter-shader-expected.txt.
  • css3/filters/custom/missing-custom-filter-shader.html: Renamed from LayoutTests/css3/filters/missing-custom-filter-shader.html.
  • css3/filters/effect-custom-disabled.html: Removed.
  • platform/chromium-mac-leopard/css3/filters/custom/effect-custom-combined-missing-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/css3/filters/effect-custom-combined-missing-expected.png.
  • platform/chromium-mac-leopard/css3/filters/custom/effect-custom-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/css3/filters/effect-custom-expected.png.
  • platform/chromium-mac-leopard/css3/filters/custom/effect-custom-parameters-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/css3/filters/effect-custom-parameters-expected.png.
  • platform/chromium-mac-snowleopard/css3/filters/custom/effect-custom-combined-missing-expected.png: Renamed from LayoutTests/platform/chromium-mac-snowleopard/css3/filters/effect-custom-combined-missing-expected.png.
  • platform/chromium-win/css3/filters/custom/effect-custom-combined-missing-expected.png: Renamed from LayoutTests/platform/chromium-win/css3/filters/effect-custom-combined-missing-expected.png.
  • platform/chromium-win/css3/filters/custom/effect-custom-expected.png: Renamed from LayoutTests/platform/chromium-win/css3/filters/effect-custom-expected.png.
  • platform/chromium-win/css3/filters/custom/effect-custom-parameters-expected.png: Renamed from LayoutTests/platform/chromium-win/css3/filters/effect-custom-parameters-expected.png.
  • platform/chromium/css3/filters/custom/effect-custom-combined-missing-expected.txt: Renamed from LayoutTests/platform/chromium/css3/filters/effect-custom-combined-missing-expected.txt.
  • platform/chromium/css3/filters/custom/effect-custom-disabled-expected.txt: Renamed from LayoutTests/platform/chromium/css3/filters/effect-custom-disabled-expected.txt.
  • platform/chromium/css3/filters/custom/effect-custom-expected.txt: Renamed from LayoutTests/platform/chromium/css3/filters/effect-custom-expected.txt.
  • platform/chromium/css3/filters/custom/effect-custom-parameters-expected.txt: Renamed from LayoutTests/platform/chromium/css3/filters/effect-custom-parameters-expected.txt.
  • platform/chromium/test_expectations.txt:
  • platform/mac-snowleopard/css3/filters/custom/effect-custom-expected.png: Renamed from LayoutTests/platform/mac-snowleopard/css3/filters/effect-custom-expected.png.
  • platform/mac-snowleopard/css3/filters/custom/effect-custom-parameters-expected.png: Renamed from LayoutTests/platform/mac-snowleopard/css3/filters/effect-custom-parameters-expected.png.
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
3:05 PM Changeset in webkit [109155] by commit-queue@webkit.org
  • 7 edits in trunk/Source

Provide DefaultDeviceScaleFactor though WebSettings
https://bugs.webkit.org/show_bug.cgi?id=79534

Patch by Tim Dresser <tdresser@chromium.org> on 2012-02-28
Reviewed by Darin Fisher.

Source/WebCore:

  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setDefaultDeviceScaleFactor):
(WebCore):

  • page/Settings.h:

(Settings):
(WebCore::Settings::defaultDeviceScaleFactor):

Source/WebKit/chromium:

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setDefaultDeviceScaleFactor):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

2:58 PM Changeset in webkit [109154] by oliver@apple.com
  • 2 edits in trunk/Source/WebCore

Fix build.

2:55 PM Changeset in webkit [109153] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, mark more SVG tests as flaky crashers on cr-mac.
https://bugs.webkit.org/show_bug.cgi?id=79707

  • platform/chromium/test_expectations.txt:
2:28 PM Changeset in webkit [109152] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=79824

Unreviewed build fix for when ENABLE(CSS_FILTERS) is on
but ENABLE(CSS_SHADERS) is off.

  • css/WebKitCSSFilterValue.cpp:

(WebCore::WebKitCSSFilterValue::typeUsesSpaceSeparator):

2:26 PM Changeset in webkit [109151] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Slow content causes choppy scrolling
https://bugs.webkit.org/show_bug.cgi?id=79403

Patch by Dave Moore <davemoore@chromium.org> on 2012-02-28
Reviewed by James Robinson.

This code helps make scrolling (via wheel or pad) less choppy
when the content takes a long time to respond to the fake mouse moves
generated during scrolls.

  • page/EventHandler.cpp:

(WebCore):
(MaximumDurationTracker):
(WebCore::MaximumDurationTracker::MaximumDurationTracker):
(WebCore::MaximumDurationTracker::~MaximumDurationTracker):
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clear):
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::dispatchFakeMouseMoveEventSoon):
(WebCore::EventHandler::dispatchFakeMouseMoveEventSoonInQuad):

  • page/EventHandler.h:
2:23 PM Changeset in webkit [109150] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Change the API to use std::string
https://bugs.webkit.org/show_bug.cgi?id=79818

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-02-28
Reviewed by Antonio Gomes.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::dispatchInspectorMessage):

  • Api/WebPage.h:
2:21 PM Changeset in webkit [109149] by kling@webkit.org
  • 67 edits in trunk/Source/WebCore

StyledElement::isPresentationAttribute() only needs the attribute name.
<http://webkit.org/b/79828>

Reviewed by Anders Carlsson.

Pass the QualifiedName to isPresentationAttribute instead of the whole
Attribute. We only need the name to know what kind of attribute it is.

This makes the code a little less ugly and makes it possible to use
the function without having an Attribute object.

  • dom/StyledElement.cpp:

(WebCore::StyledElement::attributeChanged):

  • dom/StyledElement.h:

(WebCore::StyledElement::isPresentationAttribute):

  • html/HTMLBRElement.cpp:

(WebCore::HTMLBRElement::isPresentationAttribute):

  • html/HTMLBRElement.h:
  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::isPresentationAttribute):

  • html/HTMLBodyElement.h:
  • html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::isPresentationAttribute):

  • html/HTMLButtonElement.h:
  • html/HTMLDivElement.cpp:

(WebCore::HTMLDivElement::isPresentationAttribute):

  • html/HTMLDivElement.h:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::isPresentationAttribute):

  • html/HTMLElement.h:
  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::isPresentationAttribute):

  • html/HTMLEmbedElement.h:
  • html/HTMLFontElement.cpp:

(WebCore::HTMLFontElement::isPresentationAttribute):

  • html/HTMLFontElement.h:
  • html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::isPresentationAttribute):

  • html/HTMLFrameSetElement.h:
  • html/HTMLHRElement.cpp:

(WebCore::HTMLHRElement::isPresentationAttribute):

  • html/HTMLHRElement.h:
  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::isPresentationAttribute):

  • html/HTMLIFrameElement.h:
  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::isPresentationAttribute):

  • html/HTMLImageElement.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::isPresentationAttribute):

  • html/HTMLInputElement.h:
  • html/HTMLLIElement.cpp:

(WebCore::HTMLLIElement::isPresentationAttribute):

  • html/HTMLLIElement.h:
  • html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::isPresentationAttribute):

  • html/HTMLMarqueeElement.h:
  • html/HTMLOListElement.cpp:

(WebCore::HTMLOListElement::isPresentationAttribute):

  • html/HTMLOListElement.h:
  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::isPresentationAttribute):

  • html/HTMLObjectElement.h:
  • html/HTMLParagraphElement.cpp:

(WebCore::HTMLParagraphElement::isPresentationAttribute):

  • html/HTMLParagraphElement.h:
  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::isPresentationAttribute):

  • html/HTMLPlugInElement.h:
  • html/HTMLPreElement.cpp:

(WebCore::HTMLPreElement::isPresentationAttribute):

  • html/HTMLPreElement.h:
  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::isPresentationAttribute):

  • html/HTMLSelectElement.h:
  • html/HTMLTableCaptionElement.cpp:

(WebCore::HTMLTableCaptionElement::isPresentationAttribute):

  • html/HTMLTableCaptionElement.h:
  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::isPresentationAttribute):

  • html/HTMLTableCellElement.h:
  • html/HTMLTableColElement.cpp:

(WebCore::HTMLTableColElement::isPresentationAttribute):

  • html/HTMLTableColElement.h:
  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::isPresentationAttribute):

  • html/HTMLTableElement.h:
  • html/HTMLTablePartElement.cpp:

(WebCore::HTMLTablePartElement::isPresentationAttribute):

  • html/HTMLTablePartElement.h:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::isPresentationAttribute):

  • html/HTMLTextAreaElement.h:
  • html/HTMLUListElement.cpp:

(WebCore::HTMLUListElement::isPresentationAttribute):

  • html/HTMLUListElement.h:
  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::isPresentationAttribute):

  • html/HTMLVideoElement.h:
  • mathml/MathMLElement.cpp:

(WebCore::MathMLElement::isPresentationAttribute):

  • mathml/MathMLElement.h:
  • svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::isPresentationAttribute):

  • svg/SVGImageElement.h:
  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::isPresentationAttribute):

  • svg/SVGStyledElement.h:
  • svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::isPresentationAttribute):

  • svg/SVGTextContentElement.h:
2:20 PM Changeset in webkit [109148] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Build fix.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_GetValue): Check for build platform properly.
1:58 PM Changeset in webkit [109147] by enrica@apple.com
  • 15 edits
    1 delete in trunk/Source

More Pasteboard code cleanup.
https://bugs.webkit.org/show_bug.cgi?id=79816

Source/WebCore:

Removing the last references to NSPasteboard.

Reviewed by Alexey Proskuryakov.

No new tests. No change in functionality.

  • WebCore.xcodeproj/project.pbxproj:
  • editing/mac/EditorMac.mm:

(WebCore::Editor::pasteWithPasteboard):
(WebCore::Editor::takeFindStringFromSelection):

  • loader/EmptyClients.h:

(WebCore::EmptyEditorClient::setInsertionPasteboard):

  • page/DragClient.h:
  • page/EditorClient.h:
  • platform/DragData.h:
  • platform/Pasteboard.h:
  • platform/mac/ClipboardMac.h:
  • platform/mac/PasteboardHelper.h: Removed.

Source/WebKit/mac:

Removing the last references to NSPasteboard.

Reviewed by Alexey Proskuryakov.

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::setInsertionPasteboard):

Source/WebKit2:

Removing the last references to NSPasteboard.

Reviewed by Alexey Proskuryakov.

  • WebProcess/WebCoreSupport/WebEditorClient.h:
  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:

(WebKit::WebEditorClient::setInsertionPasteboard):

1:49 PM Changeset in webkit [109146] by adamk@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r109137.
http://trac.webkit.org/changeset/109137
https://bugs.webkit.org/show_bug.cgi?id=79833

Broke cr-mac build (Requested by aklein on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-28

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore):
(WebCore::pathFromFont):

1:45 PM Changeset in webkit [109145] by eae@chromium.org
  • 2 edits in branches/subpixellayout/Source

Fix chromium build on branch.

1:43 PM Changeset in webkit [109144] by jshin@chromium.org
  • 4 edits
    3 adds in trunk

Add a fallback path to LineBreakIteratorPoolICU when the locale
name from a web page is invalid and ICU fails to get a line break
iterator instance. Also add a null check to
TextBreakIteratorICU::acquireLineBreakIterator.

https://bugs.webkit.org/show_bug.cgi?id=67640

Reviewed by Dan Bernstein.

Source/WebCore:

Test: fast/text/invalid-locale.html

  • platform/text/LineBreakIteratorPoolICU.h:

(WebCore::LineBreakIteratorPool::take):

  • platform/text/TextBreakIteratorICU.cpp:

(WebCore::acquireLineBreakIterator):

LayoutTests:

  • fast/text/invalid-locale-expected.txt: Added.
  • fast/text/invalid-locale.html: Added.
  • fast/text/resources/invalid-locale.html: Added.
1:16 PM Changeset in webkit [109143] by ap@apple.com
  • 4 edits
    3 adds in trunk/Source/WebKit2

[Mac] Add an experimental SPI for plug-ins to enter sandbox
https://bugs.webkit.org/show_bug.cgi?id=79709

Reviewed by Anders Carlsson.

  • PluginProcess/PluginProcess.h: (WebKit::PluginProcess::pluginPath): Exposed plugin path.
  • PluginProcess/mac/com.apple.WebKit.PluginProcess.sb: Added.
  • WebKit2.xcodeproj/project.pbxproj: Added new files.
  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_GetValue): Exposed

a function to access sandboxing functions when available.

  • WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.h: Added.
  • WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm: Added.
1:00 PM Changeset in webkit [109142] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash due to accessing removed continuation in multi-column layout.
https://bugs.webkit.org/show_bug.cgi?id=78417

Reviewed by David Hyatt.

Source/WebCore:

This patch addresses two problems:

  1. Run-in block got split due to addition of a column-span child.

The clone part was incorrectly intruding into the sibling block,
even when it was part of the continuation chain.

  1. Like r73296, we don't need to set continuation on an

anonymous block since we haven't split a real element.

Test: fast/multicol/span/runin-continuation-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
(WebCore::RenderBlock::handleRunInChild):

LayoutTests:

  • fast/multicol/span/runin-continuation-crash-expected.txt: Added.
  • fast/multicol/span/runin-continuation-crash.html: Added.
12:46 PM Changeset in webkit [109141] by ap@apple.com
  • 5 edits in trunk/WebKitLibraries

[Mac] Add an experimental SPI for plug-ins to enter sandbox
https://bugs.webkit.org/show_bug.cgi?id=79709

This pulls a lot of WKSI changes at once, because the script that updates it didn't
work for a while.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
12:46 PM Changeset in webkit [109140] by inferno@chromium.org
  • 3 edits
    3 adds in trunk

Incorrect before child parent calculation when adding new children
to anonymous column blocks.
https://bugs.webkit.org/show_bug.cgi?id=79755

Reviewed by David Hyatt.

Source/WebCore:

before child can be wrapped in anonymous containers, so need to
take care of that in before child parent calculation.

Test: fast/multicol/span/before-child-anonymous-column-block.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addChildToAnonymousColumnBlocks):

LayoutTests:

Test passes if you don't see the div block inside table and you see
two blocks in different columns in the pixel test.

  • fast/multicol/span/before-child-anonymous-column-block-expected.png: Added.
  • fast/multicol/span/before-child-anonymous-column-block-expected.txt: Added.
  • fast/multicol/span/before-child-anonymous-column-block.html: Added.
12:43 PM Changeset in webkit [109139] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Mark compositing/repaint/opacity-between-absolute.html as flaky.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
12:28 PM Changeset in webkit [109138] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix build with newer versions of clang.

Clang now warns since we're not passing a CFString literal to CFStringCreateWithFormatAndArguments,
but it's OK to ignore this warning since clang is also checking that the caller (vprintf_stderr_common)
takes a string literal.

  • wtf/Assertions.cpp:
12:28 PM Changeset in webkit [109137] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Reimplement pathFromFont() in SimpleFontDataMac.mm
https://bugs.webkit.org/show_bug.cgi?id=79811

Patch by Ned Holbrook <nholbrook@apple.com> on 2012-02-28
Reviewed by Dan Bernstein.

Debug-only function, so no new tests.

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::pathFromFont): Reimplemented.

12:28 PM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
12:25 PM Changeset in webkit [109136] by mahesh.kulkarni@nokia.com
  • 26 edits in trunk

[Qt] Allow read/write to the WebView.url property
https://bugs.webkit.org/show_bug.cgi?id=77554

Reviewed by Tor Arne Vestbø.

Source/WebKit2:

Change QML API WebView.url to read/write to reflect either the url requested by the user.
Also removed WebView.load(url). Defers setting url (loading page) until onComponentComplete is triggered.
Fixed c++ and qml tests to reflect the new API.

  • Target.pri:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::onComponentComplete):
(QQuickWebView::setUrl):

  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

  • UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_itemSelector.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_messaging.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_download.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_favIconLoad.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_geopermission.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_javaScriptDialogs.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadFail.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgress.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgressSignal.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadUrl.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_navigationHistory.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_origin.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_properties.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_titleChanged.qml:
  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::loadEmptyPageViewHidden):
(tst_QQuickWebView::loadNonexistentFileUrl):

Tools:

Fix MiniBrowser to use WebView.url property and remove WebView.load usage.

  • MiniBrowser/qt/qml/BrowserWindow.qml:
12:14 PM Modules edited by abarth@webkit.org
(diff)
12:06 PM Changeset in webkit [109135] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] x86 build fix after cleaning up WebPage.cpp
https://bugs.webkit.org/show_bug.cgi?id=79814

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-02-28
Reviewed by Antonio Gomes.

x86 build fix, keep WebPage::destroyWebPageCompositor() method where it
was which was outside of USE(ACCELERATED_COMPOSITING).

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::destroyWebPageCompositor):
(WebKit):

12:00 PM WebKitGTK/1.8.x edited by kalevlember@gmail.com
Added r108540 as proposed merge (diff)
11:55 AM Changeset in webkit [109134] by alexis.menard@openbossa.org
  • 5 edits in trunk

getComputedStyle fails for 'first-line' pseudo-element
https://bugs.webkit.org/show_bug.cgi?id=57505

Reviewed by Tony Chang.

Source/WebCore:

Querying the selector with a pseudo-element using getComputedStyle should work
even if the selector was not declared in the stylesheet. When not declared, we need
to use the RenderStyle created to do the rendering as there is no pseudo-style.
This match the behavior of Firefox.

No new tests : Updated expectation and extended getComputedStyle-with-pseudo-element.html.

  • dom/Element.cpp:

(WebCore::Element::computedStyle):

LayoutTests:

Update expected results to the new behavior. Also added some extra checks on
other pseudo-elements.

  • fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt:
  • fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html:
11:52 AM Changeset in webkit [109133] by commit-queue@webkit.org
  • 11 edits
    3 adds in trunk/Source/WebCore

Move FILE_SYSTEM code out of WorkerContext and into the fileapi folder
https://bugs.webkit.org/show_bug.cgi?id=79449

Patch by Ashod Nakashian <ashodnakashian@yahoo.com> on 2012-02-28
Reviewed by Adam Barth.

This moves FILE_SYSTEM code out of WorkerContext and into the fileapi/WorkerContextFileSystem.
None-functional changes, no new tests necessary.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • fileapi/WorkerContextFileSystem.cpp: Added.

(WebCore):
(WebCore::WorkerContextFileSystem::webkitRequestFileSystem):
(WebCore::WorkerContextFileSystem::webkitRequestFileSystemSync):
(WebCore::WorkerContextFileSystem::webkitResolveLocalFileSystemURL):
(WebCore::WorkerContextFileSystem::webkitResolveLocalFileSystemSyncURL):

  • fileapi/WorkerContextFileSystem.h: Added.

(WebCore):
(WorkerContextFileSystem):

  • fileapi/WorkerContextFileSystem.idl: Added.
  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::ensureEventTargetData):

  • workers/WorkerContext.h:

(WebCore):
(WorkerContext):

  • workers/WorkerContext.idl:
11:49 AM Changeset in webkit [109132] by ap@apple.com
  • 4 edits
    2 adds in trunk

FileReader crashes when file is not readable
https://bugs.webkit.org/show_bug.cgi?id=79715

Reviewed by Jian Li.

Source/WebCore:

Test: fast/files/file-reader-directory-crash.html

  • platform/SharedBuffer.cpp: (WebCore::SharedBuffer::SharedBuffer): Crash early if a caller

mixed up in-band error signal with length again.

  • platform/network/BlobResourceHandle.cpp:

(WebCore): Changed errors into an enum. Added a proper domain for blob errors.
(WebCore::BlobResourceHandle::didReceiveResponse): There is already a constant for INT_MAX
in C/C++.
(WebCore::BlobResourceHandle::didRead): Don't send "-1" for failure down the success path.
(WebCore::BlobResourceHandle::notifyFail): Use a proper domain for blob errors, and a non-
empty message.

LayoutTests:

  • fast/files/file-reader-directory-crash-expected.txt: Added.
  • fast/files/file-reader-directory-crash.html: Added.
11:47 AM Changeset in webkit [109131] by adamk@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, fix cr-win build after r109119.

  • platform/graphics/chromium/TransparencyWin.h:

(TransparencyWin):

11:40 AM Changeset in webkit [109130] by jocelyn.turcotte@nokia.com
  • 10 edits in trunk/Source/WebKit2

[Qt] Signal and property cleanup in QQuickWebView
https://bugs.webkit.org/show_bug.cgi?id=78820

Reviewed by Noam Rosenthal.

  • Remove parameters from property change notify signals: titleChanged, urlChanged, iconChanged, loadProgressChanged
  • Rename the parameters of linkHovered to prevent shadoing properties of WebView
  • Rename navigationStateChanged to navigationHistoryChanged
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::_q_onUrlChanged):
(QQuickWebViewPrivate::setIcon):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

  • UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml:
  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::loadProgress):

  • UIProcess/qt/QtWebPageLoadClient.cpp:

(QtWebPageLoadClient::didCommitLoadForFrame):
(QtWebPageLoadClient::didSameDocumentNavigationForFrame):
(QtWebPageLoadClient::didReceiveTitleForFrame):
(QtWebPageLoadClient::setLoadProgress):

  • UIProcess/qt/QtWebPageLoadClient.h:

(QtWebPageLoadClient):

11:35 AM Changeset in webkit [109129] by mario@webkit.org
  • 13 edits in trunk/Source

[GTK] Add GMainLoop and GMainContext to be handled by GRefPtr
https://bugs.webkit.org/show_bug.cgi?id=79496

Reviewed by Martin Robinson.

Source/JavaScriptCore:

Handle GMainLoop and GMainContext in GRefPtr, by calling
g_main_loop_(un)ref and g_main_context_(un)ref in the
implementation of the refGPtr and derefGPtr template functions.

  • wtf/gobject/GRefPtr.cpp:

(WTF::refGPtr):
(WTF):
(WTF::derefGPtr):

  • wtf/gobject/GRefPtr.h:

(WTF):

  • wtf/gobject/GTypedefs.h:

Source/WebCore:

Updated places where raw pointers to GMainLoop and GMainContext
were being used, replacing them with GRefPtr-based code.

  • platform/RunLoop.h:

(RunLoop):

  • platform/gtk/RunLoopGtk.cpp:

(WebCore::RunLoop::RunLoop):
(WebCore::RunLoop::~RunLoop):
(WebCore::RunLoop::mainLoop):
(WebCore::RunLoop::stop):
(WebCore::RunLoop::wakeUp):
(WebCore::RunLoop::TimerBase::start):

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCoreSynchronousLoader):
(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
(WebCore::WebCoreSynchronousLoader::~WebCoreSynchronousLoader):
(WebCore::WebCoreSynchronousLoader::didFinishLoading):
(WebCore::WebCoreSynchronousLoader::run):

Source/WebKit2:

Updated places where raw pointers to GMainLoop and GMainContext
were being used, replacing them with GRefPtr-based code.

  • Platform/WorkQueue.h:

(WorkQueue):

  • Platform/gtk/WorkQueueGtk.cpp:

(WorkQueue::platformInitialize):
(WorkQueue::platformInvalidate):
(WorkQueue::workQueueThreadBody):
(WorkQueue::registerEventSourceHandler):
(WorkQueue::dispatchOnSource):

  • UIProcess/gtk/WebPopupMenuProxyGtk.cpp:

(WebKit::WebPopupMenuProxyGtk::WebPopupMenuProxyGtk):
(WebKit::WebPopupMenuProxyGtk::showPopupMenu):
(WebKit::WebPopupMenuProxyGtk::shutdownRunLoop):

  • UIProcess/gtk/WebPopupMenuProxyGtk.h:

(WebPopupMenuProxyGtk):

11:32 AM Changeset in webkit [109128] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Set nativeKeyCode to include Windows scan code
https://bugs.webkit.org/show_bug.cgi?id=79289

Patch by Gary Kacmarcik <garykac@chromium.org> on 2012-02-28
Reviewed by Ryosuke Niwa.

Set the key event's nativeKeyCode on Windows Chromium so that it
actually includes the native scancode and other context bits.
Currently on Windows, the nativeKeyCode is set to be the same value as
the windowsKeyCode, which is redundant.

The actual native key information is required so that components (like
plugins) can reconstruct the original key event. The value stored in
the windowsKeyCode is a Windows virtual key code which does not provide
sufficient info to disambiguate the actual key being pressed (for
example, it cannot distinguish between the left and right shift keys).

All platforms except Windows currently send native key event info, so
this change will bring Windows in line with other platforms.

This change is part of our effort to send enhanced keycode information
to Pepper plugins in Chromium.

  • src/win/WebInputEventFactory.cpp:

(WebKit::WebInputEventFactory::keyboardEvent):

11:26 AM Changeset in webkit [109127] by danw@gnome.org
  • 2 edits in trunk/Tools

[GTK] make tests explicitly request GSettingsBackendMemory
https://bugs.webkit.org/show_bug.cgi?id=79788

Reviewed by Martin Robinson.

Explicitly request the fallback memory-based GSettings backend; if
other backends are available then we don't want to use them,
because they would make tests depend on the user's preferences.
And if other backends aren't available, we don't need glib to
print a warning about that fact.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort.setup_environ_for_server):

11:24 AM Changeset in webkit [109126] by eae@chromium.org
  • 3 edits in trunk/LayoutTests

Fix printing/zoomed-document.html for QT
https://bugs.webkit.org/show_bug.cgi?id=79808

Reviewed by Adam Barth.

Fix zoomed document test case to work on QT port and remove it from skip
list.

  • platform/qt/Skipped:
  • printing/zoomed-document.html:
11:15 AM Changeset in webkit [109125] by alokp@chromium.org
  • 3 edits
    2 adds in trunk

Heap-use-after-free in WebCore::RenderLayer::addChild
https://bugs.webkit.org/show_bug.cgi?id=79698

Reviewed by Simon Fraser.

Source/WebCore:

This patch fixes a regression introduced in r108659.
The reflection layer was moved to the parent by mistake. It was then
deleted and the parent was left holding on to a deleted pointer. This
patch restores the location where reflection layer is removed - before
moving the child layers.

Test: fast/reflections/toggle-reflection-crash.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::removeOnlyThisLayer):

LayoutTests:

  • fast/reflections/toggle-reflection-crash-expected.txt: Added.
  • fast/reflections/toggle-reflection-crash.html: Added.
11:12 AM Changeset in webkit [109124] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Crash from list marker having inline and block children
https://bugs.webkit.org/show_bug.cgi?id=79793

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-02-28
Reviewed by Julien Chaffraix.

Source/WebCore:

Crashing condition in which an anonymous block was being collapsed
even though it had a block sibling. removeChild() was not checking
for siblings that might precede :before content renderers, such
as list items. This patch corrects that.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeChild)

LayoutTests:

Test to exercise crashing condition in bug 79793. This creates a list
marker that precedes a floating :before content renderer and then
modifies the render tree to remove a neighboring header element.

  • fast/css-generated-content/floating-before-content-with-list-marker-crash-expected.txt: Added
  • fast/css-generated-content/floating-before-content-with-list-marker-crash.html: Added
10:51 AM Changeset in webkit [109123] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove unused focusedNodeChange notifications from the Chrome client.
https://bugs.webkit.org/show_bug.cgi?id=79794

Patch by Mike Fenton <mifenton@rim.com> on 2012-02-28
Reviewed by Rob Buis.

Remove unused notification for focusedNodeChanged.

Internally reviewed by Gen Mak.

  • Api/WebPageClient.h:
  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::focusedNodeChanged):

10:48 AM Changeset in webkit [109122] by leviw@chromium.org
  • 31 edits in branches/subpixellayout/Source/WebCore

Reverting absoluteRects, addFocusRingRects, culledInlineAbsoluteRects, and drawFocusRing to IntRects. Also adding a pixelSnappedIntRect convenience function that takes a LayoutPoint and LayoutSize.

10:29 AM Changeset in webkit [109121] by jocelyn.turcotte@nokia.com
  • 3 edits in trunk/Source/WebKit2

[Qt] Initialize QtWebContext as much as we can in its constructor.
https://bugs.webkit.org/show_bug.cgi?id=79809

Reviewed by Tor Arne Vestbø.

The icon database wouldn't be initialized on the QtWebContext while in WebKitTestRunner
since it doesn't call the initialize method on it after creating it.
Remove the initialize method, move the download manager and icon database initialization
in the constructor and call initializeContextInjectedBundleClient directly in
defaultContext to prevent overriding WKTR's injected bundle client.

  • UIProcess/qt/QtWebContext.cpp:

(WebKit::QtWebContext::QtWebContext):
(WebKit::QtWebContext::defaultContext):

  • UIProcess/qt/QtWebContext.h:

(QtWebContext):

10:24 AM Changeset in webkit [109120] by Carlos Garcia Campos
  • 5 edits in trunk/Source/WebKit2

[GTK] Inconsistent state of WebKitWebView when replacing content in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=79775

Reviewed by Martin Robinson.

Use an enum instead of a boolean to track the status of a
replace_content() load operation. We need to know when the load of
the replace content actually starts to not ignore valid load
events of a previous ongoing load operation.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewLoadChanged): Transit to new replace content state
when replacing content depending on the load event.
(webkitWebViewLoadFailed): Ignore load failed events when
replacing content.
(webkitWebViewSetEstimatedLoadProgress): Ignore load progress when
replacing content.
(webkit_web_view_replace_content): Set replace content status to
WillReplaceContent.

  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(replaceContentLoadCallback):
(testWebViewReplaceContent):

  • UIProcess/API/gtk/tests/WebViewTest.cpp:

(titleChanged):
(WebViewTest::waitUntilTitleChanged): Convenient method to wait
until title changes. Use with replaceConent() since load events
are not emitted when replacing content.

  • UIProcess/API/gtk/tests/WebViewTest.h:
10:22 AM Changeset in webkit [109119] by adamk@chromium.org
  • 5 edits in trunk/Source

Unreviewed, speculative test fix after r109016.

Source/WebCore:

  • platform/graphics/chromium/TransparencyWin.cpp:

(WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers): Explicitly pass a scale of 1 to ImageBuffer::create.

  • platform/graphics/chromium/TransparencyWin.h:

(WebCore): Update names of re-enabled tests.

Source/WebKit/chromium:

  • tests/TransparencyWinTest.cpp:

(WebCore::TEST): Update all ImageBuffer::create calls to include a scale of 1.

10:21 AM Changeset in webkit [109118] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Add basic page overlay support to TiledCoreAnimationDrawingArea
https://bugs.webkit.org/show_bug.cgi?id=79716
<rdar://problem/10923079>

Reviewed by Sam Weinig.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

Make TiledCoreAnimationDrawingArea a GraphicsLayerClient.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::didInstallPageOverlay):
Create the page overlay layer.

(WebKit::TiledCoreAnimationDrawingArea::didUninstallPageOverlay):
Destroy the page overlay layer.

(WebKit::TiledCoreAnimationDrawingArea::setPageOverlayNeedsDisplay):
Mark the page overlay layer as needing display.

(WebKit::TiledCoreAnimationDrawingArea::notifyAnimationStarted):
(WebKit::TiledCoreAnimationDrawingArea::notifySyncRequired):
Add empty GraphisLayerClient member function implementations.

(WebKit::TiledCoreAnimationDrawingArea::paintContents):
Ask the page overlay to paint itself.

(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
Flush the page overlay layer.

(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
Resize the page overlay layer.

(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
If we have a page overlay layer, add it as a sublayer of the root layer.

(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):
Create the page overlay layer and add it as a sublayer of the root layer.

(WebKit::TiledCoreAnimationDrawingArea::destroyPageOverlayLayer):
Remove the page overlay layer and destroy it.

9:56 AM Changeset in webkit [109117] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

[GTK] Remove virtual methods of WebKitDownload signals in WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=79804

Reviewed by Martin Robinson.

That comes from the first patch that followed the approach of the
first LoaderClient implementation. With current implementation
download signals, except decide-destination, don't need to be
true_handled, and they won't have a default handler
implementation. Also the download object is not supposed to be
inheritable, since instances are created privately by the
WebContext, so it's not possible to override the virtual methods
in derived classes.

  • UIProcess/API/gtk/WebKitDownload.cpp:

(webkit_download_class_init):
(webkitDownloadNotifyProgress):
(webkitDownloadFailed):
(webkitDownloadFinished):

  • UIProcess/API/gtk/WebKitDownload.h:

(_WebKitDownloadClass):

  • UIProcess/API/gtk/webkit2marshal.list:
9:44 AM Changeset in webkit [109116] by Antti Koivisto
  • 18 edits
    2 copies in trunk/Source

Give StyleRule files of its own
https://bugs.webkit.org/show_bug.cgi?id=79778

Totally rubber-stamped by Andreas Kling.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSParser.cpp:
  • css/CSSStyleRule.cpp:

(WebCore):
(WebCore::CSSStyleRule::style):

  • css/CSSStyleRule.h:

(WebCore):
(CSSStyleRule):

  • css/CSSStyleSelector.cpp:
  • css/CSSStyleSheet.cpp:
  • css/StyleRule.cpp: Copied from Source/WebCore/css/CSSStyleRule.cpp.

(WebCore):

  • css/StyleRule.h: Copied from Source/WebCore/css/CSSStyleRule.h.

(WebCore):

  • editing/EditingStyle.cpp:
  • inspector/InspectorCSSAgent.cpp:
  • inspector/InspectorInstrumentation.cpp:
  • inspector/InspectorStyleSheet.cpp:
  • page/PageSerializer.cpp:
9:20 AM Changeset in webkit [109115] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

Unreviewed, rolling out r109110.
http://trac.webkit.org/changeset/109110
https://bugs.webkit.org/show_bug.cgi?id=79806

webkitpy makes it too easy to add wkb.ug URLs to ChangeLogs
(Requested by aroben on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-28

  • Scripts/webkitpy/common/checkout/changelog.py:

(parse_bug_id):
(parse_bug_id_from_changelog):

  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
  • Scripts/webkitpy/common/config/urls.py:
9:05 AM Changeset in webkit [109114] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: remove window aspects from the timeline presentation model.
https://bugs.webkit.org/show_bug.cgi?id=79803

Reviewed by Yury Semikhatsky.

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype.accept):
(WebInspector.TimelineOverviewPane.prototype._setWindowIndices):
(WebInspector.TimelineOverviewPane.prototype.windowLeft):
(WebInspector.TimelineOverviewPane.prototype.windowRight):
(WebInspector.TimelineOverviewPane.prototype._fireWindowChanged):
(WebInspector.TimelineOverviewWindow.prototype._dragWindow):
(WebInspector.TimelineOverviewPane.WindowSelector):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._onCategoryCheckboxClicked):
(WebInspector.TimelinePanel.prototype._updateBoundaries):

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.prototype.reset):
(WebInspector.TimelineCategory):
(WebInspector.TimelineCategory.prototype.get hidden):
(WebInspector.TimelineCategory.prototype.set hidden):

9:03 AM Changeset in webkit [109113] by caio.oliveira@openbossa.org
  • 4 edits in trunk/Source/WebKit2

[Qt] Fix build for WK2, do not use enum type if values can be outside the enum
https://bugs.webkit.org/show_bug.cgi?id=79800

Reviewed by Csaba Osztrogonác.

We have two different enums called NavigationRequestAction. If we use one of them
to store the variables, compilers can rightfully warn about comparison with
values from other enums.

We might revisit the strategy of exposing different enumerations in experimental,
but for now, fallback to using int for the 'action' property in
QWebNavigationRequest.

  • UIProcess/API/qt/qwebnavigationrequest.cpp:

(QWebNavigationRequestPrivate):
(QWebNavigationRequest::setAction):
(QWebNavigationRequest::action):

  • UIProcess/API/qt/qwebnavigationrequest_p.h:
  • UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp:
8:52 AM Changeset in webkit [109112] by kenneth@webkit.org
  • 2 edits in trunk/Source/WebCore

Improve the visual of the tiling
https://bugs.webkit.org/show_bug.cgi?id=79648

Reviewed by Noam Rosenthal.

When we cover the view with tiles[1], we do so from the center
and out, in bigger and bigger cicles by finding the current minimum
covered distance.

This looks like painting a rect, then a cross, then a rect, ...
and can be noticed when a page blocks during tiling.

We can do this better by only covering with tiles in rects at a time.

The original code was done so that it gave preference to tiles in
vertical direction due to that being the most common scrolling
direction. This is not needed anymore as we are now using the
trajectory vector when panning, which always gives preference for
creating tiles in the panned direction.

[1] It should be noted that we always cover the visibleRect in one go,

and that we here are talking about covering the coverRect beyond
the visibleRect

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::tileDistance):

8:50 AM Changeset in webkit [109111] by aroben@webkit.org
  • 2 edits in trunk/Tools

Add my new email address

Fixes <http://wkb.ug/79797> Adam Roben's email address in webkitpy is soon to be incorrect

Reviewed by Anders Carlsson.

  • Scripts/webkitpy/common/config/committers.py:
8:49 AM Changeset in webkit [109110] by aroben@webkit.org
  • 4 edits in trunk/Tools

Teach webkitpy about wkb.ug URLs

Fixes <http://wkb.ug/79799> webkit-patch can't find bug numbers from ChangeLog entries that
use wkb.ug URLs

Patch by Adam Roben <Adam Roben> on 2012-02-28
Reviewed by Anders Carlsson.

  • Scripts/webkitpy/common/checkout/changelog.py:

(parse_bug_id):
(parse_bug_id_from_changelog):
Fall back to the tiny URL format if neither the short nor long URL formats work.

  • Scripts/webkitpy/common/checkout/changelog_unittest.py:

(ChangeLogTest.test_parse_bug_id_from_changelog): Added tests for the above changes.

  • Scripts/webkitpy/common/config/urls.py: Added bug_url_tiny, which can be used to match

wkb.ug URLs.

8:27 AM Changeset in webkit [109109] by yurys@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: preserve memory counters size after frontend reopening
https://bugs.webkit.org/show_bug.cgi?id=79792

Clear collected counter values when timeline panel is reset. Persist
timeline grid/counters splitter position to restore it when front-end
is opened next time.

Reviewed by Pavel Feldman.

  • inspector/front-end/MemoryStatistics.js:

(WebInspector.MemoryStatistics.prototype.reset):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._setSplitterPosition):
(WebInspector.TimelinePanel.prototype._resetPanel):

  • inspector/front-end/timelinePanel.css:

(#counter-values-bar):

8:27 AM Changeset in webkit [109108] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt] build-webkit does not detect the number of CPUs
https://bugs.webkit.org/show_bug.cgi?id=76445

Based on Seo Sanghyeon's work (modification:
Automatically determine the number of CPUs for make
only if -j make argument haven't already been specified.)

Patch by János Badics <dicska@gmail.com> on 2012-02-28
Reviewed by Csaba Osztrogonác.

  • Scripts/webkitdirs.pm:

(buildQMakeProjects):

8:18 AM Changeset in webkit [109107] by pfeldman@chromium.org
  • 7 edits in trunk

Web Inspector: move filtering of the timeline records into the presentation model.
https://bugs.webkit.org/show_bug.cgi?id=79789

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/TimelineModel.js:
  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype.setStartAtZero):
(WebInspector.TimelineOverviewPane.prototype.scrollWindow):
(WebInspector.TimelineOverviewPane.prototype.accept):
(WebInspector.TimelineOverviewPane.prototype._setWindowIndices):
(WebInspector.TimelineStartAtZeroOverview):
(WebInspector.TimelineStartAtZeroOverview.prototype._onWindowChanged):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._createStatusbarButtons):
(WebInspector.TimelinePanel.prototype._updateRecordsCounter):
(WebInspector.TimelinePanel.prototype._glueParentButtonClicked):
(WebInspector.TimelinePanel.prototype._toggleStartAtZeroButtonClicked):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype._resetPanel):
(WebInspector.TimelinePanel.prototype._refresh):
(WebInspector.TimelinePanel.prototype.revealRecordAt):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelineExpandableElement.prototype._update):
(WebInspector.TimelineCategoryFilter):
(WebInspector.TimelineCategoryFilter.prototype.accept):
(WebInspector.TimelineIsLongFilter):
(WebInspector.TimelineIsLongFilter.prototype.accept):

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel):
(WebInspector.TimelinePresentationModel.prototype.addFilter):
(WebInspector.TimelinePresentationModel.prototype.reset):
(WebInspector.TimelinePresentationModel.prototype.minimumRecordTime):
(WebInspector.TimelinePresentationModel.prototype.maximumRecordTime):
(WebInspector.TimelinePresentationModel.prototype.addRecord):
(WebInspector.TimelinePresentationModel.prototype._updateBoundaries):
(WebInspector.TimelinePresentationModel.prototype._findParentRecord):
(WebInspector.TimelinePresentationModel.prototype.setGlueRecords):
(WebInspector.TimelinePresentationModel.prototype.fireWindowChanged):
(WebInspector.TimelinePresentationModel.prototype.get _recordStyles):
(WebInspector.TimelinePresentationModel.prototype.filteredRecords):
(WebInspector.TimelinePresentationModel.prototype._filterRecords):
(WebInspector.TimelinePresentationModel.Record.prototype.get visibleChildrenCount):
(WebInspector.TimelinePresentationModel.Record.prototype.get invisibleChildrenCount):
(WebInspector.TimelinePresentationModel.Filter):
(WebInspector.TimelinePresentationModel.Filter.prototype.accept):

LayoutTests:

  • inspector/timeline/timeline-enum-stability-expected.txt:
8:11 AM Changeset in webkit [109106] by caio.oliveira@openbossa.org
  • 7 edits in trunk/Source/WebKit2

[Qt] API changes to QWebNavigationRequest
https://bugs.webkit.org/show_bug.cgi?id=78821

Reviewed by Kenneth Rohde Christiansen.

Changes discussed in API review at Szeged: rename 'button' to 'mouseButton',
rename 'modifiers' to 'keyboardModifiers', remove 'originatingUrl' and
use the enum type for 'action'.

  • UIProcess/API/qt/qwebnavigationrequest.cpp:

(QWebNavigationRequestPrivate::QWebNavigationRequestPrivate):
(QWebNavigationRequestPrivate):
(QWebNavigationRequest::QWebNavigationRequest):
(QWebNavigationRequest::setAction):
(QWebNavigationRequest::mouseButton):
(QWebNavigationRequest::keyboardModifiers):
(QWebNavigationRequest::action):

  • UIProcess/API/qt/qwebnavigationrequest_p.h:
  • UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml:
  • UIProcess/qt/QtWebPagePolicyClient.cpp:

(QtWebPagePolicyClient::decidePolicyForNavigationAction):

  • UIProcess/qt/QtWebPagePolicyClient.h:

(QtWebPagePolicyClient):

8:02 AM Changeset in webkit [109105] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

JSString::resolveRope() should report extra memory cost to the heap.
https://bugs.webkit.org/show_bug.cgi?id=79555

Patch by Yong Li <yoli@rim.com> on 2012-02-28
Reviewed by Michael Saboff.

At the time a JSString is constructed with fibers, it doesn't report
extra memory cost, which is reasonable because it hasn't allocate
new memory. However when the rope is resolved, it should report meory
cost for the new buffer.

  • runtime/JSString.cpp:

(JSC::JSString::resolveRope):

8:01 AM Changeset in webkit [109104] by commit-queue@webkit.org
  • 8 edits
    6 adds in trunk

Percent width/height SVG not always scaled on window resize
https://bugs.webkit.org/show_bug.cgi?id=79490

Patch by Florin Malita <fmalita@google.com> on 2012-02-28
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Tests: fast/repaint/percent-minheight-resize-expected.html

fast/repaint/percent-minheight-resize.html
svg/custom/svg-percent-scale-expected.html
svg/custom/svg-percent-scale-vonly-expected.html
svg/custom/svg-percent-scale-vonly.html
svg/custom/svg-percent-scale.html

Fix a couple of problems preventing correct SVG scaling on window resize:

  • RenderReplaced::computePreferredLogicalWidths is not SVG attribute aware and computes

a non-zero m_minPreferredLogicalWidth even when the SVG widh/height are percentages.

  • RenderBlock::layoutInlineChildren is also not SVG attribute aware and does not trigger

percent height child layouts on vertical-only resizes.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):
Use hasRelativeDimensions() instead of direct width/height->isPercent tests. This also fixes
an HTML issue where percent {min,max}Height inline elements are not updated on vertical-only resizes.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::hasRelativeDimensions):
(WebCore):

  • rendering/RenderBox.h:

(RenderBox):
Add virtual hasRelativeDimensions() method.

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computePreferredLogicalWidths):
Use hasRelativeDimensions() instead of direct width/height->isPercent tests.

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):
(WebCore::RenderSVGRoot::willBeDestroyed):
Register percent-height SVG elements with the gPercentHeightDescendantsMap, and clean-up on destruction
or height unit change.

(WebCore::RenderSVGRoot::hasRelativeDimensions):
(WebCore):

  • rendering/svg/RenderSVGRoot.h:

(RenderSVGRoot):
SVG-aware hasRelativeDimensions() override.

LayoutTests:

  • fast/repaint/percent-minheight-resize-expected.html: Added.
  • fast/repaint/percent-minheight-resize.html: Added.
  • svg/custom/svg-percent-scale-expected.html: Added.
  • svg/custom/svg-percent-scale-vonly-expected.html: Added.
  • svg/custom/svg-percent-scale-vonly.html: Added.
  • svg/custom/svg-percent-scale.html: Added.
6:43 AM Changeset in webkit [109103] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-28

  • DEPS:
6:22 AM Changeset in webkit [109102] by yurys@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: show resource dividers on memory counter graphs
https://bugs.webkit.org/show_bug.cgi?id=79782

Resource dividers are drawn on the memory counter graphs.

Reviewed by Pavel Feldman.

  • inspector/front-end/MemoryStatistics.js:

(WebInspector.MemoryStatistics.prototype.updateDividers):
(WebInspector.MemoryStatistics.prototype.setMainTimelineGrid):
(WebInspector.MemoryStatistics.prototype._updateSize):
(WebInspector.MemoryStatistics.prototype.show):
(WebInspector.MemoryStatistics.prototype.refresh):
(WebInspector.MemoryStatistics.prototype._refreshDividers):

  • inspector/front-end/TimelineGrid.js:

(WebInspector.TimelineGrid.prototype.get dividersElement):
(WebInspector.TimelineGrid.prototype.updateDividers):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._timelinesOverviewModeChanged):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelinePanel.prototype.get timlinePaddingLeft):

  • inspector/front-end/timelinePanel.css:

(#memory-graphs-canvas-container):
(#memory-graphs-canvas-container .resources-dividers):

5:30 AM Changeset in webkit [109101] by caio.oliveira@openbossa.org
  • 3 edits in trunk/Source/WebKit/qt

[Qt] Move registration of experimental types to the proper plugin
https://bugs.webkit.org/show_bug.cgi?id=79706

Reviewed by Tor Arne Vestbø.

  • declarative/experimental/plugin.cpp:
  • declarative/plugin.cpp:

(WebKitQmlPlugin::registerTypes):

5:15 AM Changeset in webkit [109100] by Nikolas Zimmermann
  • 159 edits in trunk/LayoutTests

2012-02-28 Nikolas Zimmermann <nzimmermann@rim.com>

Rebaseline Gtk results after r109097.

  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/struct-use-03-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/text-text-05-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
  • platform/gtk/svg/batik/filters/feTile-expected.txt:
  • platform/gtk/svg/batik/filters/filterRegions-expected.txt:
  • platform/gtk/svg/batik/masking/maskRegions-expected.txt:
  • platform/gtk/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
  • platform/gtk/svg/batik/paints/patternRegionA-expected.txt:
  • platform/gtk/svg/batik/paints/patternRegions-expected.txt:
  • platform/gtk/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
  • platform/gtk/svg/batik/text/longTextOnPath-expected.txt:
  • platform/gtk/svg/batik/text/textAnchor-expected.txt:
  • platform/gtk/svg/batik/text/textDecoration-expected.txt:
  • platform/gtk/svg/batik/text/textEffect-expected.txt:
  • platform/gtk/svg/batik/text/textEffect2-expected.txt:
  • platform/gtk/svg/batik/text/textEffect3-expected.txt:
  • platform/gtk/svg/batik/text/textFeatures-expected.txt:
  • platform/gtk/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
  • platform/gtk/svg/batik/text/textLayout-expected.txt:
  • platform/gtk/svg/batik/text/textLayout2-expected.txt:
  • platform/gtk/svg/batik/text/textLength-expected.txt:
  • platform/gtk/svg/batik/text/textOnPath-expected.txt:
  • platform/gtk/svg/batik/text/textOnPath2-expected.txt:
  • platform/gtk/svg/batik/text/textOnPath3-expected.txt:
  • platform/gtk/svg/batik/text/textOnPathSpaces-expected.txt:
  • platform/gtk/svg/batik/text/textPosition-expected.txt:
  • platform/gtk/svg/batik/text/textPosition2-expected.txt:
  • platform/gtk/svg/batik/text/textProperties-expected.txt:
  • platform/gtk/svg/batik/text/textProperties2-expected.txt:
  • platform/gtk/svg/batik/text/textStyles-expected.txt:
  • platform/gtk/svg/batik/text/verticalText-expected.txt:
  • platform/gtk/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/gtk/svg/carto.net/button-expected.txt:
  • platform/gtk/svg/carto.net/colourpicker-expected.txt:
  • platform/gtk/svg/carto.net/slider-expected.txt:
  • platform/gtk/svg/carto.net/window-expected.txt:
  • platform/gtk/svg/clip-path/clip-path-child-clipped-expected.txt:
  • platform/gtk/svg/clip-path/clip-path-clipped-no-content-expected.txt:
  • platform/gtk/svg/clip-path/clip-path-evenodd-expected.txt:
  • platform/gtk/svg/clip-path/clip-path-evenodd-nonzero-expected.txt:
  • platform/gtk/svg/clip-path/clip-path-nonzero-evenodd-expected.txt:
  • platform/gtk/svg/clip-path/clip-path-nonzero-expected.txt:
  • platform/gtk/svg/clip-path/clip-path-text-and-shape-expected.txt:
  • platform/gtk/svg/clip-path/clip-path-use-as-child2-expected.txt:
  • platform/gtk/svg/clip-path/clip-path-use-as-child3-expected.txt:
  • platform/gtk/svg/clip-path/clip-path-use-as-child4-expected.txt:
  • platform/gtk/svg/clip-path/clip-path-use-as-child5-expected.txt:
  • platform/gtk/svg/clip-path/clip-path-with-container-expected.txt:
  • platform/gtk/svg/clip-path/clip-path-with-invisibile-child-expected.txt:
  • platform/gtk/svg/clip-path/clip-path-with-text-clipped-expected.txt:
  • platform/gtk/svg/clip-path/clipper-placement-issue-expected.txt:
  • platform/gtk/svg/css/clippath-with-shadow-expected.txt:
  • platform/gtk/svg/css/mask-with-shadow-expected.txt:
  • platform/gtk/svg/custom/broken-internal-references-expected.txt:
  • platform/gtk/svg/custom/clip-path-referencing-use-expected.txt:
  • platform/gtk/svg/custom/embedding-external-svgs-expected.txt:
  • platform/gtk/svg/custom/path-textPath-simulation-expected.txt:
  • platform/gtk/svg/custom/pattern-rotate-expected.txt:
  • platform/gtk/svg/custom/recursive-clippath-expected.txt:
  • platform/gtk/svg/custom/recursive-mask-expected.txt:
  • platform/gtk/svg/custom/recursive-pattern-expected.txt:
  • platform/gtk/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
  • platform/gtk/svg/custom/relative-sized-shadow-tree-content-expected.txt:
  • platform/gtk/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
  • platform/gtk/svg/custom/relative-sized-use-on-symbol-expected.txt:
  • platform/gtk/svg/custom/struct-use-09-b-expected.txt:
  • platform/gtk/svg/custom/use-clipped-hit-expected.txt:
  • platform/gtk/svg/custom/use-detach-expected.txt:
  • platform/gtk/svg/custom/use-disappears-after-style-update-expected.txt:
  • platform/gtk/svg/custom/use-dynamic-append-expected.txt:
  • platform/gtk/svg/custom/use-elementInstance-event-target-expected.txt:
  • platform/gtk/svg/custom/use-elementInstance-methods-expected.txt:
  • platform/gtk/svg/custom/use-empty-reference-expected.txt:
  • platform/gtk/svg/custom/use-event-handler-on-referenced-element-expected.txt:
  • platform/gtk/svg/custom/use-event-handler-on-use-element-expected.txt:
  • platform/gtk/svg/custom/use-events-crash-expected.txt:
  • platform/gtk/svg/custom/use-instanceRoot-modifications-expected.txt:
  • platform/gtk/svg/custom/use-modify-container-in-target-expected.txt:
  • platform/gtk/svg/custom/use-modify-target-container-expected.txt:
  • platform/gtk/svg/custom/use-modify-target-symbol-expected.txt:
  • platform/gtk/svg/custom/use-nested-transform-expected.txt:
  • platform/gtk/svg/custom/use-on-disallowed-foreign-object-1-expected.txt:
  • platform/gtk/svg/custom/use-on-disallowed-foreign-object-2-expected.txt:
  • platform/gtk/svg/custom/use-on-disallowed-foreign-object-3-expected.txt:
  • platform/gtk/svg/custom/use-on-disallowed-foreign-object-4-expected.txt:
  • platform/gtk/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
  • platform/gtk/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
  • platform/gtk/svg/custom/use-on-g-containing-symbol-expected.txt:
  • platform/gtk/svg/custom/use-on-g-containing-use-expected.txt:
  • platform/gtk/svg/custom/use-on-g-expected.txt:
  • platform/gtk/svg/custom/use-on-non-svg-namespaced-element-expected.txt:
  • platform/gtk/svg/custom/use-on-rect-expected.txt:
  • platform/gtk/svg/custom/use-on-symbol-expected.txt:
  • platform/gtk/svg/custom/use-on-text-expected.txt:
  • platform/gtk/svg/custom/use-on-use-expected.txt:
  • platform/gtk/svg/custom/use-property-changes-through-dom-expected.txt:
  • platform/gtk/svg/custom/use-property-changes-through-svg-dom-expected.txt:
  • platform/gtk/svg/custom/use-property-synchronization-crash-expected.txt:
  • platform/gtk/svg/custom/use-recalcStyle-crash-expected.txt:
  • platform/gtk/svg/custom/use-recursion-1-expected.txt:
  • platform/gtk/svg/custom/use-recursion-2-expected.txt:
  • platform/gtk/svg/custom/use-recursion-3-expected.txt:
  • platform/gtk/svg/custom/use-recursion-4-expected.txt:
  • platform/gtk/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
  • platform/gtk/svg/custom/use-symbol-overflow-expected.txt:
  • platform/gtk/svg/custom/use-transform-expected.txt:
  • platform/gtk/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.txt:
  • platform/gtk/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.txt:
  • platform/gtk/svg/filters/filter-placement-issue-expected.txt:
  • platform/gtk/svg/filters/filter-refresh-expected.txt:
  • platform/gtk/svg/filters/filter-source-position-expected.txt:
  • platform/gtk/svg/hixie/error/014-expected.txt:
  • platform/gtk/svg/hixie/error/017-expected.txt:
  • platform/gtk/svg/hixie/use/001-expected.txt:
  • platform/gtk/svg/hixie/use/002-expected.txt:
  • platform/gtk/svg/overflow/overflow-on-inner-svg-element-expected.txt:
  • platform/gtk/svg/repaint/inner-svg-change-viewPort-relative-expected.txt:
  • platform/gtk/svg/stroke/zero-length-path-linecap-rendering-expected.txt:
  • platform/gtk/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt:
  • platform/gtk/svg/text/text-gradient-positioning-expected.txt:
  • platform/gtk/svg/text/text-path-01-b-expected.txt:
  • platform/gtk/svg/text/text-text-04-t-expected.txt:
  • platform/gtk/svg/text/text-text-05-t-expected.txt:
  • platform/gtk/svg/text/text-text-06-t-expected.txt:
  • platform/gtk/svg/transforms/svg-css-transforms-clip-path-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
  • svg/stroke/zero-length-arc-linecaps-rendering-expected.txt:
5:01 AM Changeset in webkit [109099] by Csaba Osztrogonác
  • 257 edits
    3 copies
    4 adds in trunk/LayoutTests

Integrate SVGUseElement within the new shadow root concept
https://bugs.webkit.org/show_bug.cgi?id=78902

Unreviewed gardening, update Qt specific expected files after r109097.

  • platform/qt/svg/[...]: Updated.
4:53 AM SettingUpDevelopmentEnvironmentForN9 edited by zarvai@inf.u-szeged.hu
(diff)
4:51 AM Changeset in webkit [109098] by Nikolas Zimmermann
  • 1 edit
    1 add in trunk/LayoutTests

2012-02-28 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Add missing Mac pixel test result.

  • platform/mac/svg/carto.net/scrollbar-expected.png: Added.
4:13 AM Changeset in webkit [109097] by Nikolas Zimmermann
  • 233 edits
    4 deletes in trunk

Integrate SVGUseElement within the new shadow root concept
https://bugs.webkit.org/show_bug.cgi?id=78902

Reviewed by Zoltan Herczeg.

Source/WebCore:

Replace SVG shadow tree implementation with the new, modern #shadow-root implementation.

Current situation in trunk:
SVGUseElement doesn't create/hold the shadow tree, unlike its expected in
the modern #shadow-root concept, but its renderer RenderSVGShadowTreeRootContainer.
That creates a cycle, as the actual DOM tree is stored as RefPtr<SVGGElement> inside
a renderer - that's weak conceptually, and has lead to sublte security bugs in the past.

Whenever a target element of a <use> element changed, invalidateShadowTree() is called
which calls setNeedsStyleRecalc(), and sets m_needsShadodwTreeRecreation to true.
Once style recalculation happens, the RenderSVGShadowTreeRootContainer then eventually
built the shadow tree, by cloning the target node, building the SVGElementInstance tree
etc, -- all within the render tree.

To easy reviewing, here's a dump of the current render tree for a simple <use> example:
<defs><rect id="rect"/></defs><use xlink:href="#rect"/>

Dump of render tree:
RenderSVGHiddenContainer {defs} <defs> (SVGDefsElement)

RenderSVGRect {rect} <rect> (SVGRectElement)

RenderSVGShadowTreeRootContainer {use} <use> (SVGUseElement)

RenderSVGContainer {g} <g> (SVGShadowTreeRootElement)

RenderSVGRect {rect} <rect> (SVGRectElement, clone of <rect> in <defs>)

The SVGShadowTreeRootElement is created & stored by RenderSVGShadowTreeRootContainer,
the renderer of the <use> element. The RenderSVGTransformableContainer renderer created
for the SVGShadowTreeRootElement stores the x/y translation induced by the <use> attributes.

There are lots of places all over WebCore that assume the existance of a <g> renderer
as first child of the <use> element, representing the "SVG shadow tree root".

Summary of this patch:
Let SVGUseElement create&maintain a #shadow-root, and append the cloned target elements
into this shadow root. We no longer have to take care of attachment/detachment, style
recalculation, etc. - that's handled transparenly by ShadowRoot(List) now.

This makes SVGShadowTreeElements & RenderSVGShadowTreeRootContainer obsolete. Switch
SVGUseElement to create a RenderSVGTransformableContainer as its renderer, and make
it respect the translation induced by the x/y attributes, given for a <use> element.

Remove all occourences of SVGShadowRoot, remove all special cases it induced.

It's all covered by existing tests, took a while to make them all pass again.

  • CMakeLists.txt: Remove SVGShadowTreeElements/RenderSVGShadowTreeRootContainer from build.
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList): Enable fast path for selector checking, now that special shadow tree rules are gone.

  • css/SelectorChecker.cpp:

(WebCore::linkAttribute): No need to guard this code with ENABLE(SVG).
(WebCore::SelectorChecker::checkSelector): Remove obsolete SVG shadow root special case.

  • dom/EventDispatcher.cpp:

(WebCore::eventTargetRespectingSVGTargetRules): Remove loop, simplify & cleanup this code.
(WebCore::EventDispatcher::adjustToShadowBoundaries): s/isShadowRootOrSVGShadowRoot/isShadowRoot/.
(WebCore::EventDispatcher::adjustRelatedTarget): Ditto.
(WebCore::EventDispatcher::ensureEventAncestors): Simplify logic for SVG, fixed a FIXME.

  • dom/Node.cpp: Remove obsolete svgShadowHost().

(WebCore::Node::shadowTreeRootNode): Remove obsolete isSVGShadowRoot() checks.
(WebCore::Node::nonBoundaryShadowTreeRootNode): Ditto.
(WebCore::Node::isInShadowTree): Make it const.

  • dom/Node.h: Remove isSVGShadowRoot/svgShadowHost.

(WebCore::Node::isShadowRoot): s/IsShadowRootOrSVGShadowRootFlag/isShadowRoot/.
(WebCore::Node::parentNode): Augment comments.
(WebCore::Node::parentNodeGuaranteedHostFree): Ditto.

  • dom/Range.cpp:

(WebCore::Range::checkNodeBA): Remove obsolete SVG shadow root special case.

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::prepareScript): Ditto.

  • rendering/RenderObject.h: Remove isSVGShadowTreeRootContainer.

(WebCore::RenderObject::isSVGTransformableContainer): Added.

  • rendering/svg/RenderSVGAllInOne.cpp: Remove SVGShadowTreeElements/RenderSVGShadowTreeRootContainer from build.
  • rendering/svg/RenderSVGModelObject.cpp:

(WebCore::isGraphicsElement): To check for <use>, a tag name comparision is needed now, as it no longer has a special renderer.

  • rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage): Ditto.
(WebCore::RenderSVGResourceClipper::calculateClipContentRepaintRect): Ditto.
(WebCore::RenderSVGResourceClipper::hitTestClipContent): Ditto.

  • rendering/svg/RenderSVGResourceContainer.cpp: Remove RenderSVGShadowTreeRootContainer.h include.
  • rendering/svg/RenderSVGShadowTreeRootContainer.cpp: Removed.
  • rendering/svg/RenderSVGShadowTreeRootContainer.h: Removed.
  • rendering/svg/RenderSVGTransformableContainer.cpp: Keep track of last used additional x/y translation.

(WebCore::RenderSVGTransformableContainer::calculateLocalTransform): Handle x/y translation for <use> contains here, instead of storing it in the SVGShadowTreeRootElement.

  • rendering/svg/RenderSVGTransformableContainer.h: Store last used x/y translation.

(WebCore::RenderSVGTransformableContainer::isSVGTransformableContainer): Return true.
(WebCore::toRenderSVGTransformableContainer): Add conversion helpers.

  • rendering/svg/RenderSVGViewportContainer.cpp: Ditto.

(WebCore::RenderSVGViewportContainer::calcViewport): Handle width/height attributes inheritance from the <use> element, if we're a <svg> or <symbol> replacement in the shadow tree.

  • rendering/svg/RenderSVGViewportContainer.h: Remove isSVGContainer() override which is not needed here (already present in RenderSVGContainer).
  • rendering/svg/SVGShadowTreeElements.cpp: Removed.
  • rendering/svg/SVGShadowTreeElements.h: Removed.
  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::createRenderer): Check if parentNode is really a SVGElement, before casting.

  • svg/SVGElement.cpp:

(WebCore::SVGElement::isOutermostSVGSVGElement): Early exit if tag name isn't <svg>, or if we're in a shadow tree (can't be an outermost <svg> element then).
(WebCore::hasLoadListener): Deploy parentOrHostElement() usage to remove any special cases, related to shadow boundaries.
(WebCore::SVGElement::sendSVGLoadEventIfPossible): Ditto.
(WebCore::SVGElement::customStyleForRenderer): Ditto.

  • svg/SVGElementInstance.cpp:

(WebCore::SVGElementInstance::invalidateAllInstancesOfElement): Call updateStyleIfNeeded() instead of updateLayoutIgnorePendingStylesheets().

  • svg/SVGGElement.cpp:

(WebCore::SVGGElement::rendererIsNeeded): s/parentNode/parentOrHostElement/ - we need to cross shadow boundaries now.

  • svg/SVGGElement.h: Remove obsolete isShadowTreeContainerElement().
  • svg/SVGLocatable.cpp:

(WebCore::SVGLocatable::nearestViewportElement): s/parentNode/parentOrHostElement/ - we need to cross shadow boundaries now.
(WebCore::SVGLocatable::farthestViewportElement): Ditto.
(WebCore::SVGLocatable::computeCTM): Ditto.

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::title): Ditto. (+ simplify code a lot, no need to walk the shadow tree to find its root anymore, use isInShadowTree() helper.)
(WebCore::SVGStyledElement::rendererIsNeeded): Ditto.

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::SVGUseElement): Remove no longer needed m_updatesBlocked.
(WebCore::SVGUseElement::create): Always call ensureShadowRoot(), to create a #shadow-root, upon creating a SVGUseElement.
(WebCore::SVGUseElement::insertedIntoDocument): Align with SVGFEImageElement/SVGTRefElement - call buildPendingResource() from insertedIntoDocument(), finally! (no renderer needed anymore to update the SVG shadow subtree).
(WebCore::SVGUseElement::removedFromDocument): Align with SVGFEImageElement/SVGTRefElement - immediately release the SVGElementInstance & shadow tree, once we're removed from the document.
(WebCore::SVGUseElement::svgAttributeChanged): Simplify code a lot, no longer need to deal with x/y/width/height attributes, the renderes in the shadow tree grab these values from their corresponding <use> elements automatically now.
(WebCore::SVGUseElement::willRecalcStyle):

New main part of the logic. invalidateShadowTree() calls setNeedsStyleRecalc, and sets m_needsShadowTreeRecreation=true. If we encounter this case, force rebuilding the SVG shadow tree
and the SVGElementInstance tree, immediately, before executing the actual style recalc. This allows us to lazily rebuild the SVG shadow tree for the <use> element. Consider:
<defs><rect id="rect"></defs> <use xlink:href="#rect"/>. Now from a script we change the rect x/y/width/height attributes:
rect.setAttribute("x", "10"); rect.setAttribute("y", "10")... each call will lead to a SVGUseElement::invalidateShadowTree() call by SVGElementInstance::invalidateAllInstancesOfElement, invoked after the <rect> element got parsed.
This won't update the shadow tree four times, but only once upon the next style recalculation - otherwise performance is a nightmare.
This will serve as future starting point, to explore partial SVG subtree re-clones, which should easily be doable now.

(WebCore::dumpInstanceTree): Add a 'static' to allow DUMP_INSTANCE_TREE to be used in clang builds.
(WebCore::SVGUseElement::clearResourceReferences): Added helper to release instance & shadow tree.
(WebCore::SVGUseElement::buildPendingResource): Modeled exactly like SVGFEImageElement/SVGTRefElement. It's possible to share more code between these in future.
(WebCore::SVGUseElement::buildShadowAndInstanceTree): Cleanup code, adapt to new shadow-root concept.
(WebCore::SVGUseElement::createRenderer): Create a RenderSVGTransformableContainer, no longer a <use> specific renderer.
(WebCore::removeDisallowedElementsFromSubtree): Use new replacedChild/appendChild variants, that don't require a ExceptionCode to be passed in.
(WebCore::SVGUseElement::buildShadowTree): Ditto.
(WebCore::SVGUseElement::expandUseElementsInShadowTree): Ditto.
(WebCore::SVGUseElement::expandSymbolElementsInShadowTree): Ditto.
(WebCore::SVGUseElement::invalidateShadowTree): Only trigger style recalculations if needed.

  • svg/SVGUseElement.h: Remove lots of now unnecessary overrides: attach/detach/didRecalcStyle/updateContainerOffset/updateContainerSizes/etc..
  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::insertedIntoDocument): No need to walk the shadow tree to find its root anymore, use isInShadowTree() helper.

LayoutTests:

Update results after the <use> rewrite. Lots of RendeSVGContainer lines are
gone in the expected results, as the artifical <g> element representing the
SVG shadow root is gone, replaced by a standar #shadow-root.

  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-use-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
  • platform/mac/svg/batik/filters/feTile-expected.txt:
  • platform/mac/svg/batik/filters/filterRegions-expected.txt:
  • platform/mac/svg/batik/masking/maskRegions-expected.txt:
  • platform/mac/svg/batik/paints/gradientLimit-expected.txt:
  • platform/mac/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
  • platform/mac/svg/batik/paints/patternRegionA-expected.txt:
  • platform/mac/svg/batik/paints/patternRegions-expected.txt:
  • platform/mac/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
  • platform/mac/svg/batik/text/longTextOnPath-expected.txt:
  • platform/mac/svg/batik/text/smallFonts-expected.txt:
  • platform/mac/svg/batik/text/textAnchor-expected.txt:
  • platform/mac/svg/batik/text/textDecoration-expected.txt:
  • platform/mac/svg/batik/text/textEffect-expected.txt:
  • platform/mac/svg/batik/text/textEffect2-expected.txt:
  • platform/mac/svg/batik/text/textEffect3-expected.txt:
  • platform/mac/svg/batik/text/textFeatures-expected.txt:
  • platform/mac/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
  • platform/mac/svg/batik/text/textLayout-expected.txt:
  • platform/mac/svg/batik/text/textLayout2-expected.txt:
  • platform/mac/svg/batik/text/textLength-expected.txt:
  • platform/mac/svg/batik/text/textOnPath-expected.txt:
  • platform/mac/svg/batik/text/textOnPath2-expected.txt:
  • platform/mac/svg/batik/text/textOnPath3-expected.txt:
  • platform/mac/svg/batik/text/textOnPathSpaces-expected.txt:
  • platform/mac/svg/batik/text/textPosition-expected.txt:
  • platform/mac/svg/batik/text/textPosition2-expected.txt:
  • platform/mac/svg/batik/text/textProperties-expected.txt:
  • platform/mac/svg/batik/text/textProperties2-expected.txt:
  • platform/mac/svg/batik/text/textStyles-expected.txt:
  • platform/mac/svg/batik/text/verticalText-expected.txt:
  • platform/mac/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/mac/svg/carto.net/button-expected.txt:
  • platform/mac/svg/carto.net/colourpicker-expected.txt:
  • platform/mac/svg/carto.net/slider-expected.txt:
  • platform/mac/svg/carto.net/window-expected.txt:
  • platform/mac/svg/clip-path/clip-path-child-clipped-expected.txt:
  • platform/mac/svg/clip-path/clip-path-clipped-no-content-expected.txt:
  • platform/mac/svg/clip-path/clip-path-evenodd-expected.txt:
  • platform/mac/svg/clip-path/clip-path-evenodd-nonzero-expected.txt:
  • platform/mac/svg/clip-path/clip-path-nonzero-evenodd-expected.txt:
  • platform/mac/svg/clip-path/clip-path-nonzero-expected.txt:
  • platform/mac/svg/clip-path/clip-path-text-and-shape-expected.txt:
  • platform/mac/svg/clip-path/clip-path-use-as-child2-expected.txt:
  • platform/mac/svg/clip-path/clip-path-use-as-child3-expected.txt:
  • platform/mac/svg/clip-path/clip-path-use-as-child4-expected.txt:
  • platform/mac/svg/clip-path/clip-path-use-as-child5-expected.txt:
  • platform/mac/svg/clip-path/clip-path-with-container-expected.txt:
  • platform/mac/svg/clip-path/clip-path-with-invisibile-child-expected.txt:
  • platform/mac/svg/clip-path/clip-path-with-text-clipped-expected.txt:
  • platform/mac/svg/clip-path/clipper-placement-issue-expected.txt:
  • platform/mac/svg/css/clippath-with-shadow-expected.txt:
  • platform/mac/svg/css/mask-with-shadow-expected.txt:
  • platform/mac/svg/custom/broken-internal-references-expected.txt:
  • platform/mac/svg/custom/clip-path-referencing-use-expected.txt:
  • platform/mac/svg/custom/clip-path-referencing-use2-expected.txt:
  • platform/mac/svg/custom/embedding-external-svgs-expected.txt:
  • platform/mac/svg/custom/path-textPath-simulation-expected.txt:
  • platform/mac/svg/custom/pattern-rotate-expected.txt:
  • platform/mac/svg/custom/recursive-clippath-expected.txt:
  • platform/mac/svg/custom/recursive-mask-expected.txt:
  • platform/mac/svg/custom/recursive-pattern-expected.txt:
  • platform/mac/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
  • platform/mac/svg/custom/relative-sized-shadow-tree-content-expected.txt:
  • platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
  • platform/mac/svg/custom/relative-sized-use-on-symbol-expected.txt:
  • platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
  • platform/mac/svg/custom/struct-use-09-b-expected.txt:
  • platform/mac/svg/custom/use-clipped-hit-expected.txt:
  • platform/mac/svg/custom/use-css-events-expected.txt:
  • platform/mac/svg/custom/use-detach-expected.txt:
  • platform/mac/svg/custom/use-disappears-after-style-update-expected.png:
  • platform/mac/svg/custom/use-disappears-after-style-update-expected.txt:
  • platform/mac/svg/custom/use-dynamic-append-expected.txt:
  • platform/mac/svg/custom/use-elementInstance-event-target-expected.txt:
  • platform/mac/svg/custom/use-elementInstance-methods-expected.txt:
  • platform/mac/svg/custom/use-empty-reference-expected.txt:
  • platform/mac/svg/custom/use-event-handler-on-referenced-element-expected.txt:
  • platform/mac/svg/custom/use-event-handler-on-use-element-expected.txt:
  • platform/mac/svg/custom/use-events-crash-expected.txt:
  • platform/mac/svg/custom/use-font-face-crash-expected.txt:
  • platform/mac/svg/custom/use-instanceRoot-event-bubbling-expected.png:
  • platform/mac/svg/custom/use-instanceRoot-event-listeners-expected.png:
  • platform/mac/svg/custom/use-instanceRoot-modifications-expected.txt:
  • platform/mac/svg/custom/use-modify-container-in-target-expected.txt:
  • platform/mac/svg/custom/use-modify-target-container-expected.txt:
  • platform/mac/svg/custom/use-modify-target-symbol-expected.txt:
  • platform/mac/svg/custom/use-nested-transform-expected.txt:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-1-expected.txt:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-2-expected.txt:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-3-expected.txt:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-4-expected.txt:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
  • platform/mac/svg/custom/use-on-g-containing-symbol-expected.txt:
  • platform/mac/svg/custom/use-on-g-containing-use-expected.txt:
  • platform/mac/svg/custom/use-on-g-expected.txt:
  • platform/mac/svg/custom/use-on-non-svg-namespaced-element-expected.txt:
  • platform/mac/svg/custom/use-on-rect-expected.txt:
  • platform/mac/svg/custom/use-on-symbol-expected.txt:
  • platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/mac/svg/custom/use-on-text-expected.txt:
  • platform/mac/svg/custom/use-on-use-expected.txt:
  • platform/mac/svg/custom/use-property-changes-through-dom-expected.txt:
  • platform/mac/svg/custom/use-property-changes-through-svg-dom-expected.txt:
  • platform/mac/svg/custom/use-property-synchronization-crash-expected.txt:
  • platform/mac/svg/custom/use-recalcStyle-crash-expected.txt:
  • platform/mac/svg/custom/use-recursion-1-expected.txt:
  • platform/mac/svg/custom/use-recursion-2-expected.txt:
  • platform/mac/svg/custom/use-recursion-3-expected.txt:
  • platform/mac/svg/custom/use-recursion-4-expected.png:
  • platform/mac/svg/custom/use-recursion-4-expected.txt:
  • platform/mac/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
  • platform/mac/svg/custom/use-symbol-overflow-expected.txt:
  • platform/mac/svg/custom/use-transform-expected.txt:
  • platform/mac/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.txt:
  • platform/mac/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.txt:
  • platform/mac/svg/filters/filter-placement-issue-expected.txt:
  • platform/mac/svg/filters/filter-refresh-expected.txt:
  • platform/mac/svg/filters/filter-source-position-expected.txt:
  • platform/mac/svg/hixie/error/014-expected.txt:
  • platform/mac/svg/hixie/error/017-expected.txt:
  • platform/mac/svg/hixie/use/001-expected.txt:
  • platform/mac/svg/hixie/use/002-expected.txt:
  • platform/mac/svg/overflow/overflow-on-inner-svg-element-expected.txt:
  • platform/mac/svg/stroke/zero-length-arc-linecaps-rendering-expected.txt:
  • platform/mac/svg/stroke/zero-length-path-linecap-rendering-expected.txt:
  • platform/mac/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt:
  • platform/mac/svg/text/text-gradient-positioning-expected.txt:
  • platform/mac/svg/text/text-path-01-b-expected.txt:
  • platform/mac/svg/text/text-text-04-t-expected.txt:
  • platform/mac/svg/text/text-text-05-t-expected.txt:
  • platform/mac/svg/text/text-text-06-t-expected.txt:
  • platform/mac/svg/transforms/svg-css-transforms-clip-path-expected.txt:
  • platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
  • svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt:
  • svg/clip-path/clip-path-childs-clipped-expected.txt:
  • svg/clip-path/clip-path-clipped-evenodd-twice-expected.txt:
  • svg/clip-path/clip-path-clipped-expected.txt:
  • svg/clip-path/clip-path-clipped-nonzero-expected.txt:
  • svg/clip-path/clip-path-on-clipped-use-expected.txt:
  • svg/clip-path/clip-path-use-as-child-expected.txt:
  • svg/css/circle-in-mask-with-shadow-expected.txt:
  • svg/custom/deep-dynamic-updates-expected.txt:
  • svg/custom/non-scaling-stroke-expected.txt:
  • svg/custom/resource-client-removal-expected.txt:
  • svg/custom/use-clipped-transform-expected.txt:
  • svg/custom/use-css-no-effect-on-shadow-tree-expected.txt:
  • svg/custom/use-forward-refs-expected.txt:
  • svg/custom/use-image-in-g-expected.txt:
  • svg/custom/use-in-symbol-with-offset-expected.txt:
  • svg/custom/use-inherit-style-expected.txt:
  • svg/custom/use-move-to-offset-expected.txt:
  • svg/custom/use-multiple-on-nested-disallowed-font-expected.txt:
  • svg/custom/use-on-clip-path-with-transformation-expected.txt:
  • svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt:
  • svg/custom/use-setAttribute-crash-expected.txt:
  • svg/custom/use-transfer-width-height-properties-to-svg-expected.txt:
  • svg/custom/use-transfer-width-height-properties-to-svg1-expected.txt:
  • svg/custom/use-transfer-width-height-properties-to-svg2-expected.txt:
  • svg/custom/use-transfer-width-height-properties-to-symbol-expected.txt:
  • svg/custom/use-transfer-width-height-properties-to-symbol1-expected.txt:
  • svg/custom/use-transfer-width-height-properties-to-symbol2-expected.txt:
  • svg/repaint/inner-svg-change-viewPort-relative-expected.txt:
3:36 AM Changeset in webkit [109096] by shinyak@chromium.org
  • 22 edits
    4 adds in trunk

Element should be able to have multiple shadow roots.
https://bugs.webkit.org/show_bug.cgi?id=77931

Reviewed by Hajime Morita.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

This patch enables us to add multiple shadow subtrees into elements.
Note that multiple shadow subtrees are enabled
only if RuntimeEnabledFeatures::multipleShadowSubtrees is enabled.

Since we don't have <shadow> element yet, only the youngest shadow tree
will be rendered. This patch includes tests to confirm adding a new shadow
tree dynamically to confirm only the youngest shadow tree is renderered.

Tests: fast/dom/shadow/multiple-shadowroot-rendering.html

fast/dom/shadow/multiple-shadowroot.html

  • WebCore.exp.in:
  • dom/Element.cpp: Uses ShadowRootList interfaces directly instead of ShadowRootList emulation methods.

(WebCore::Element::~Element):
(WebCore::Element::attach):
(WebCore::Element::addShadowRoot):
(WebCore::Element::removeShadowRootList):

  • dom/Element.h:

(Element):

  • dom/NodeRenderingContext.cpp: Makes non-youngest shadow subtrees hidden.

(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::NodeRenderingContext::hostChildrenChanged):

Since non-youngest children may be changed, make sure host children are changed.

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::create):

  • dom/ShadowRoot.h: Utility methods to make code intention clear are added.

(WebCore::ShadowRoot::youngerShadowRoot):
(WebCore::ShadowRoot::olderShadowRoot):
(ShadowRoot):
(WebCore::ShadowRoot::isYoungest):
(WebCore::ShadowRoot::isOldest):

  • dom/ShadowRootList.cpp:

(WebCore::ShadowRootList::popShadowRoot):
(WebCore::ShadowRootList::attach):
(WebCore::ShadowRootList::detach):

Detaches shadow subtrees.

  • testing/Internals.cpp:

(WebCore::Internals::address):
(WebCore):
(WebCore::Internals::youngerShadowRoot):
(WebCore::Internals::olderShadowRoot):
(WebCore::Internals::removeShadowRoot):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

  • fast/dom/resources/shadow-test-driver.js:

(createSpanWithText):
(doneTest):
(doTest):

  • fast/dom/shadow/multiple-shadowroot-expected.txt: Added.
  • fast/dom/shadow/multiple-shadowroot-rendering-expected.txt: Added.
  • fast/dom/shadow/multiple-shadowroot-rendering.html: Added.
  • fast/dom/shadow/multiple-shadowroot.html: Added.
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
2:55 AM Changeset in webkit [109095] by tkent@chromium.org
  • 2 edits in trunk/Tools

Update a pattern for forms files of watchlist
https://bugs.webkit.org/show_bug.cgi?id=79767

Reviewed by Kentaro Hara.

  • Scripts/webkitpy/common/config/watchlist:

Catches the following files with the "Forms" pattern.

  • HTMLDatListElement.*
  • HTMLKeygenElement.*
  • HTMLLegendElement.*
  • HTMLOutputElement.*
  • FormAssociatedElement.*
  • SliderThumbElement.*
  • TextControlInnerElements.*
  • RenderFileUploadControl.*
2:42 AM Changeset in webkit [109094] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

[Qt][WK2] Use movementStarted/Ended signals instead of movingChanged on QtViewportInterationEngine
https://bugs.webkit.org/show_bug.cgi?id=79521

Patch by Hugo Parente Lima <Hugo Parente Lima> on 2012-02-28
Reviewed by Kenneth Rohde Christiansen.

movingChanged() signal is emitted many times, so the use of movementStarted() and
movementEnded() is a better choice.

  • UIProcess/qt/QtFlickProvider.cpp:

(QtFlickProvider::QtFlickProvider):

  • UIProcess/qt/QtFlickProvider.h:

(QtFlickProvider):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):

  • UIProcess/qt/QtViewportInteractionEngine.h:

(QtViewportInteractionEngine):

2:21 AM Changeset in webkit [109093] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

[Chromium] We should reset mouse position before calling eventSender.mouseMove in LayoutTest
https://bugs.webkit.org/show_bug.cgi?id=79748

Calls eventSender.moveTo(0, 0) before other eventSender.moveTo call to make sure test scripts
get mousemove event.

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-02-28
Reviewed by Kent Tamura.

  • fast/forms/number/input-number-events.html:
  • fast/forms/number/input-number-large-padding.html:
  • fast/forms/number/input-spinbutton-capturing.html:
2:06 AM Changeset in webkit [109092] by Antti Koivisto
  • 2 edits in trunk/Source/WebKit/qt

Try to fix build.

Not reviewed.

  • Api/qwebelement.cpp:

(QWebElement::styleProperty):

1:38 AM Changeset in webkit [109091] by Antti Koivisto
  • 17 edits in trunk/Source/WebCore

Split CSSStyleRule into internal and CSSOM type
https://bugs.webkit.org/show_bug.cgi?id=79763

Reviewed by Andreas Kling.

  • Split the data out as StyleRule
  • Make CSSStyleSelector operate on StyleRule instead of CSSStyleRule


This is an intermediate step. Both CSSStyleRule and StyleRule are still always constructed so
the patch increases memory consumption by a few pointers per css rule. Upcoming
patches will make CSSStyleRules to be constructed on demand.

The patch does not yet move StyleRule to a file of its own.

  • css/CSSPageRule.cpp:

(WebCore::CSSPageRule::CSSPageRule):

  • css/CSSPageRule.h:

(WebCore::CSSPageRule::create):
(CSSPageRule):

  • css/CSSParser.cpp:

(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createPageRule):

  • css/CSSRule.h:

(WebCore::CSSRule::CSSRule):
(CSSRule):

  • css/CSSStyleRule.cpp:

(WebCore::StyleRule::StyleRule):
(WebCore):
(WebCore::StyleRule::~StyleRule):
(WebCore::StyleRule::addSubresourceStyleURLs):
(WebCore::StyleRule::ensureCSSStyleRule):
(WebCore::CSSStyleRule::CSSStyleRule):
(WebCore::CSSStyleRule::~CSSStyleRule):
(WebCore::CSSStyleRule::generateSelectorText):
(WebCore::CSSStyleRule::setSelectorText):
(WebCore::CSSStyleRule::cssText):

  • css/CSSStyleRule.h:

(WebCore):
(StyleRule):
(WebCore::StyleRule::selectorList):
(WebCore::StyleRule::properties):
(WebCore::StyleRule::sourceLine):
(WebCore::StyleRule::adoptSelectorVector):
(WebCore::StyleRule::adoptSelectorList):
(WebCore::StyleRule::setProperties):
(WebCore::CSSStyleRule::create):
(WebCore::CSSStyleRule::style):
(CSSStyleRule):
(WebCore::CSSStyleRule::styleRule):

  • css/CSSStyleSelector.cpp:

(RuleData):
(WebCore::RuleData::rule):
(RuleSet):
(WebCore::CSSStyleSelector::addMatchedProperties):
(WebCore::CSSStyleSelector::sortAndTransferMatchedRules):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • css/CSSStyleSelector.h:

(WebCore::CSSStyleSelector::RuleSelectorPair::RuleSelectorPair):
(RuleSelectorPair):
(MatchResult):
(CSSStyleSelector):

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::addSubresourceStyleURLs):

  • editing/EditingStyle.cpp:

(WebCore::styleFromMatchedRulesForElement):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::SelectorProfile::startSelector):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willMatchRuleImpl):
(WebCore::InspectorInstrumentation::willProcessRuleImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willMatchRule):
(WebCore::InspectorInstrumentation::willProcessRule):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::buildObjectForRule):
(WebCore::InspectorStyleSheet::revalidateStyle):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeFrame):
(WebCore::PageSerializer::serializeCSSStyleSheet):
(WebCore::PageSerializer::retrieveResourcesForRule):
(WebCore::PageSerializer::retrieveResourcesForProperties):

  • page/PageSerializer.h:

(WebCore):
(PageSerializer):

1:36 AM Changeset in webkit [109090] by bashi@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed test expectations update.

webaudio/audiobuffersource-channels.html crashes on debug builds.

  • platform/chromium/test_expectations.txt:
1:23 AM Changeset in webkit [109089] by rolandsteiner@chromium.org
  • 3 edits in trunk/Source/WebCore

RuntimeEnabledFeatures::setMultipleShadowSubtreesEnabled should not be inline
https://bugs.webkit.org/show_bug.cgi?id=79753

Moved the function implementation to the .cpp file.

Reviewed by Hajime Morita.

No new tests. (no functional change)

  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore::RuntimeEnabledFeatures::setMultipleShadowSubtreesEnabled):
(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):

12:53 AM Changeset in webkit [109088] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, marking a media test flaky on GTK.

  • platform/gtk/test_expectations.txt:

media/video-poster-blocked-by-willsendrequest.html is flaky.

12:22 AM Modules edited by morrita@google.com
(diff)
12:14 AM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
12:13 AM Changeset in webkit [109087] by Philippe Normand
  • 1 edit
    22 adds in trunk/LayoutTests

Unreviewed, GTK baselines for 22 new tests.

  • platform/gtk/fast/block/float/centered-float-avoidance-complexity-expected.txt: Added.
  • platform/gtk/fast/block/float/shrink-to-avoid-float-complexity-expected.txt: Added.
  • platform/gtk/fast/css/non-empty-span-expected.txt: Added.
  • platform/gtk/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.txt: Added.
  • platform/gtk/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.txt: Added.
  • platform/gtk/fast/css/relative-positioned-block-nested-with-inline-parent-expected.txt: Added.
  • platform/gtk/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.txt: Added.
  • platform/gtk/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.txt: Added.
  • platform/gtk/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.txt: Added.
  • platform/gtk/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.txt: Added.
  • platform/gtk/fast/css/relative-positioned-block-with-inline-ancestor-expected.txt: Added.
  • platform/gtk/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.txt: Added.
  • platform/gtk/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.txt: Added.
  • platform/gtk/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.txt: Added.
  • platform/gtk/fast/repaint/region-painting-invalidation-expected.txt: Added.
  • platform/gtk/svg/foreignObject/fO-display-none-expected.txt: Added.
  • platform/gtk/svg/foreignObject/fO-display-none-with-relative-pos-content-expected.txt: Added.
  • platform/gtk/svg/foreignObject/fO-parent-display-changes-expected.txt: Added.
  • platform/gtk/svg/foreignObject/fO-parent-display-none-expected.txt: Added.
  • platform/gtk/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt: Added.
  • platform/gtk/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt: Added.
  • platform/gtk/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt: Added.
12:07 AM Changeset in webkit [109086] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

Fix comment about RGB swizzle decoding and Adobe transform=0 images
https://bugs.webkit.org/show_bug.cgi?id=79457

Unreviewed. No new tests, comment change only.

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageReader::decode):

12:06 AM Changeset in webkit [109085] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update, skipping 2 new failing
ref tests.

  • platform/gtk/test_expectations.txt:
12:05 AM Changeset in webkit [109084] by shinyak@chromium.org
  • 14 edits in trunk

Element::removeShadowRoot() and setShadowRoot() should be moved into ShadowTree.
https://bugs.webkit.org/show_bug.cgi?id=78313

Reviewed by Hajime Morita.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

This patch is for refactoring ShadowTree related code.

(1) Element::removeShadowRoot() and Element::setShadowRoot() are moved into ShadowTree.
(2) ShadowTree is now put on its own heap.

No new tests, no change in behavior.

  • WebCore.exp.in:
  • dom/Element.cpp:

(WebCore::Element::~Element):
(WebCore::Element::shadowTree):
(WebCore::Element::ensureShadowTree):

Ensure the existence of ShadowTree. This does not ensure ShadowRoot exists.

  • dom/Element.h:

(Element):

  • dom/ElementRareData.h: Makes ShadowTree on Heap.

(ElementRareData):
(WebCore::ElementRareData::~ElementRareData):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::create):

  • dom/ShadowTree.cpp:

(WebCore::validateShadowRoot):
(WebCore):
(WebCore::ShadowTree::addShadowRoot):
(WebCore::ShadowTree::removeAllShadowRoots):

  • dom/ShadowTree.h:

(ShadowTree):

  • testing/Internals.cpp:

(WebCore::Internals::removeShadowRoot):

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
12:01 AM Modules edited by abarth@webkit.org
(diff)
12:01 AM Modules edited by abarth@webkit.org
(diff)
12:01 AM Modules edited by abarth@webkit.org
(diff)

Feb 27, 2012:

11:52 PM Modules edited by abarth@webkit.org
(diff)
11:46 PM Modules edited by abarth@webkit.org
(diff)
11:43 PM Modules edited by abarth@webkit.org
(diff)
11:43 PM Changeset in webkit [109083] by Philippe Normand
  • 10 edits
    7 adds in trunk/LayoutTests

Unreviewed, GTK rebaseline.

  • platform/gtk/Skipped: Skip all dom/shadow tests, GTK doesn't

support this feature yet.

  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/js/constructor-length-expected.txt:
  • platform/gtk/fast/multicol/span/clone-flexbox-expected.txt: Added.
  • platform/gtk/fast/multicol/span/clone-summary-expected.txt: Added.
  • platform/gtk/fast/runin/runin-div-before-child-expected.txt: Added.
  • platform/gtk/fast/runin/runin-table-before-child-expected.txt: Added.
  • platform/gtk/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
  • platform/gtk/media/audio-repaint-expected.txt:
  • platform/gtk/media/video-zoom-controls-expected.txt:
  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt: Added.
  • platform/gtk/svg/repaint/inner-svg-change-viewPort-relative-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
  • platform/gtk/svg/text/text-rescale-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
11:37 PM Modules edited by abarth@webkit.org
(diff)
11:32 PM Modules edited by abarth@webkit.org
(diff)
11:31 PM Modules edited by abarth@webkit.org
(diff)
11:28 PM Modules edited by abarth@webkit.org
(diff)
11:26 PM Modules edited by abarth@webkit.org
(diff)
11:19 PM Modules edited by abarth@webkit.org
(diff)
11:02 PM Changeset in webkit [109082] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

LayoutTests/fast/forms/number/input-number-events.html is failing since r108228
https://bugs.webkit.org/show_bug.cgi?id=79329

Remove trailing whitespace which makes test failure.

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-02-27
Reviewed by Kent Tamura.

  • fast/forms/number/input-number-events-expected.txt: Remove trailing whitespace at line 11.
10:57 PM Changeset in webkit [109081] by commit-queue@webkit.org
  • 18 edits in trunk

Fix <msubsup> formatting, especially for a tall base, subscript, or superscript
https://bugs.webkit.org/show_bug.cgi?id=79274

Patch by David Barton <Dave Barton> on 2012-02-27
Reviewed by Julien Chaffraix.

Source/WebCore:

Move the <msubsup> formatting code in stretchToHeight() to layout(). Then revise the
combined code to produce more vertically accurate results, and without extra white
space. Finally, don't multiply msub/msup/msubsup operator stretching by 1.2.

Test: Added the bug report's attached test case to mathml/presentation/subsup.xhtml, and
it and 5 other test files in mathml/presentation now produce improved results. The
integral sign in mo-stretch.html is no longer scaled up by an extra 1.2, and baselines
are more accurate so the base is higher in msubsup-sub-changed.png. Several examples are
slightly tighter vertically, because their (somewhat) anonymous blocks wrapping
subscripts and superscripts now have the correct font size.

  • rendering/mathml/RenderMathMLSubSup.cpp:

(WebCore):
(WebCore::RenderMathMLSubSup::addChild):
(WebCore::RenderMathMLSubSup::stretchToHeight):
(WebCore::RenderMathMLSubSup::layout):

  • rendering/mathml/RenderMathMLSubSup.h:

(RenderMathMLSubSup):

  • rendering/style/RenderStyle.h:

LayoutTests:

  • mathml/presentation/subsup.xhtml:
  • platform/mac/mathml/presentation/mo-stretch-expected.png: Added property svn:mime-type.
  • platform/mac/mathml/presentation/mo-stretch-expected.txt:
  • platform/mac/mathml/presentation/msubsup-base-changed-expected.png:
  • platform/mac/mathml/presentation/msubsup-base-changed-expected.txt:
  • platform/mac/mathml/presentation/msubsup-sub-changed-expected.png:
  • platform/mac/mathml/presentation/msubsup-sub-changed-expected.txt:
  • platform/mac/mathml/presentation/msubsup-sup-changed-expected.png:
  • platform/mac/mathml/presentation/msubsup-sup-changed-expected.txt:
  • platform/mac/mathml/presentation/sub-expected.png:
  • platform/mac/mathml/presentation/sub-expected.txt:
  • platform/mac/mathml/presentation/subsup-expected.png:
  • platform/mac/mathml/presentation/subsup-expected.txt:
10:49 PM Changeset in webkit [109080] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

kCTFontTableOptionExcludeSynthetic is unneeded
https://bugs.webkit.org/show_bug.cgi?id=79744

Patch by Ned Holbrook <nholbrook@apple.com> on 2012-02-27
Reviewed by Dan Bernstein.

The aforementioned option is a no-op, so no new tests.

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::fontHasVerticalGlyphs): Specify no options.

10:47 PM Changeset in webkit [109079] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed morning gardening.

  • platform/qt/Skipped: Skip new failing tests.
  • platform/qt/fast/dom/Window/window-properties-expected.txt: Updated.
10:34 PM Changeset in webkit [109078] by koz@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Add missing parameter to didCreateScriptContext() so it overrides base class again.
https://bugs.webkit.org/show_bug.cgi?id=79742

Reviewed by Kent Tamura.

  • tests/WebFrameTest.cpp:
10:12 PM Changeset in webkit [109077] by bashi@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Unreviewed gardening, Disable TransparencyWin.OpaqueCompositeLayerPixel

  • tests/TransparencyWinTest.cpp:

(WebCore::TEST):

10:03 PM Changeset in webkit [109076] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Multi-Channel support in AudioBufferSourceNode
https://bugs.webkit.org/show_bug.cgi?id=79202

Patch by Wei James <james.wei@intel.com> on 2012-02-27
Reviewed by Chris Rogers.

Source/WebCore:

Test: webaudio/audiobuffersource-multi-channels.html

  • webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::renderSilenceAndFinishIfNotLooping):
(WebCore::AudioBufferSourceNode::renderFromBuffer):
(WebCore::AudioBufferSourceNode::setBuffer):

  • webaudio/AudioBufferSourceNode.h:

(AudioBufferSourceNode):

LayoutTests:

  • webaudio/audiobuffersource-channels-expected.txt:
  • webaudio/audiobuffersource-channels.html:
  • webaudio/audiobuffersource-multi-channels-expected.wav: Added.
  • webaudio/audiobuffersource-multi-channels.html: Added.
9:59 PM Changeset in webkit [109075] by mrowe@apple.com
  • 5 edits in tags/Safari-535.23.1/Source/JavaScriptCore

Merge r108888.

9:49 PM Changeset in webkit [109074] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Upstream the BlackBerry change to platform/graphics/IntRect.h
https://bugs.webkit.org/show_bug.cgi?id=79732

Reviewed by Antonio Gomes.

Add conversion convenience between WebCore::IntRect and BlackBerry::Platform::IntRect.

The porting can't be built yet, no new tests.

  • platform/graphics/IntRect.h:

(Platform):
(IntRect):

9:42 PM Changeset in webkit [109073] by eae@chromium.org
  • 3 edits
    2 adds in trunk

Printed font-size should not be dependant on zoom level
https://bugs.webkit.org/show_bug.cgi?id=79717

Reviewed by Adam Barth.

Ignore full page zoom level when printing a document.

Source/WebCore:

Test: printing/zoomed-document.html

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

LayoutTests:

  • printing/zoomed-document-expected.txt: Added.
  • printing/zoomed-document.html: Added.
9:29 PM Changeset in webkit [109072] by bashi@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Unreviewed gardening, further compile fixes for
TransparencyWinTest.

  • platform/graphics/chromium/TransparencyWin.h:

(WebCore):

9:16 PM Changeset in webkit [109071] by bashi@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Unreviewed gardening, fix compile error after r109043

  • platform/graphics/chromium/TransparencyWin.h:

(TransparencyWin):

8:59 PM Changeset in webkit [109070] by kinuko@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Add createSnapshotFile API to WebFileSystem to create File snapshots for filesystem files
https://bugs.webkit.org/show_bug.cgi?id=79394

Reviewed by Darin Fisher.

  • public/platform/WebFileSystem.h:

(WebKit::WebFileSystem::createSnapshotFileAndReadMetadata): Added.

8:50 PM Changeset in webkit [109069] by bashi@chromium.org
  • 6 edits
    7 deletes in trunk

Unreviewed, rolling out r109041.
http://trac.webkit.org/changeset/109041
https://bugs.webkit.org/show_bug.cgi?id=79741

Broke Chromium Win build (Requested by bashi on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-27

Tools:

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/chromium/WebViewHost.h:

LayoutTests:

  • webintents/resources/web-intents-testing.js: Removed.
  • webintents/web-intents-failure-expected.txt: Removed.
  • webintents/web-intents-failure.html: Removed.
  • webintents/web-intents-invoke-expected.txt: Removed.
  • webintents/web-intents-invoke.html: Removed.
  • webintents/web-intents-reload.html:
  • webintents/web-intents-reply-expected.txt: Removed.
  • webintents/web-intents-reply.html: Removed.
8:41 PM Changeset in webkit [109068] by abarth@webkit.org
  • 8 edits
    1 move in trunk/Source/WebCore

EventFactory.in should be named EventNames.in
https://bugs.webkit.org/show_bug.cgi?id=79727

Reviewed by Kentaro Hara.

Originally EventFactory.in was just used to generate EventFactory.cpp,
but now we're able to generate a bunch of other Event-related code from
this "in" file.

In writing some documentation about how to use these mechanisms, the
name EventFactory.in didn't seem like the right name. This patch
renames EventFactory.in to EventNames.in, which more accurately
describes the role of this file (and matches the naming convention of
HTMLTagNames.in).

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/action_makenames.py:

(main):

  • WebCore.xcodeproj/project.pbxproj:
  • dom/EventNames.in: Copied from Source/WebCore/dom/EventFactory.in.
  • dom/EventFactory.in: Removed.
8:17 PM Changeset in webkit [109067] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Forms] Make order of attribute/method in HTMLInputElement.idl as same as specification
https://bugs.webkit.org/show_bug.cgi?id=79622

For ease of maintainability, this patch reorders attributes and methods declaration
matching with specification.

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-02-27
Reviewed by Adam Barth.

No new tests. No behavior change.

  • html/HTMLInputElement.idl: Reorder and remove obsolete comments.
7:52 PM Changeset in webkit [109066] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[chromium] Remove media tests from ChromiumGpu configurations
https://bugs.webkit.org/show_bug.cgi?id=79720

Patch by James Robinson <jamesr@chromium.org> on 2012-02-27
Reviewed by Adam Barth.

We no longer need to run the media/ tests in both GPU and non-GPU configurations since we can exercise the GPU
composited playback path via tests in the compositing/ directory.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

(_default_tests_paths):

  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:

(ChromiumGpuTest.test_default_tests_paths):
(ChromiumGpuTest.test_test_files):

7:44 PM Changeset in webkit [109065] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

Sort CSSStyleSelector property handler constructors by CSS property name.
https://bugs.webkit.org/show_bug.cgi?id=79713

Reviewed by Andreas Kling.

No new tests / refactoring only.

This patch is simply an automated sort of the property constructors.
Presently they are all over the place and it is difficult to know where to insert new rules.
This patch provides a clear pattern and should reduce future conflicts when adding properties.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

7:31 PM Changeset in webkit [109064] by koz@chromium.org
  • 9 edits in trunk/Source

[chromium] Plumb extensionGroup into didCreateScriptContext().
https://bugs.webkit.org/show_bug.cgi?id=79072

Reviewed by Darin Fisher.

Source/WebCore:

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initContextIfNeeded):

  • bindings/v8/V8IsolatedContext.cpp:

(WebCore::V8IsolatedContext::V8IsolatedContext):

  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::didCreateScriptContext):

  • loader/FrameLoaderClient.h:

(FrameLoaderClient):

Source/WebKit/chromium:

  • public/WebFrameClient.h:

(WebKit::WebFrameClient::didCreateScriptContext):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::didCreateScriptContext):

  • src/FrameLoaderClientImpl.h:

(FrameLoaderClientImpl):

7:29 PM Changeset in webkit [109063] by commit-queue@webkit.org
  • 2 edits in trunk

Update flakiness dashboard unit test.
https://bugs.webkit.org/show_bug.cgi?id=79711

Patch by Dave Tu <dtu@chromium.org> on 2012-02-27
Reviewed by Ojan Vafai.

  • Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
7:17 PM Modules edited by abarth@webkit.org
(diff)
7:09 PM Modules edited by abarth@webkit.org
(diff)
7:09 PM Changeset in webkit [109062] by commit-queue@webkit.org
  • 6 edits in trunk

Fixed a typo in CanvasRenderingContext2D::drawImage(HTMLCanvasElement);
incorrect source and destination rect used.
https://bugs.webkit.org/show_bug.cgi?id=79566

Source/WebCore:

Pass dstRect and bufferSrcRect to
CanvasRenderingContext2D::fullCanvasCompositedDrawImage() for the destination
and source rect, respectively.

Patch by Huang Dongsung <luxtella@company100.net> on 2012-02-27
Reviewed by Daniel Bates.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawImage):

LayoutTests:

I amended canvas-composite-canvas to cover this bug, and I also amended
canvas-composite-image because I changed
LayoutTests/fast/canvas/resources/canvas-composite-image-common.js.
However, the change of canvas-composite-image is reasonable because
drawImage(HTMLImageElement) will be able to have a similar bug.

Patch by Huang Dongsung <luxtella@company100.net> on 2012-02-27
Reviewed by Daniel Bates.

  • fast/canvas/canvas-composite-canvas.html:
  • fast/canvas/canvas-composite-image.html:
  • fast/canvas/resources/canvas-composite-image-common.js:

(setupContext):

7:09 PM Modules edited by abarth@webkit.org
(diff)
7:08 PM Modules edited by abarth@webkit.org
(diff)
7:05 PM Modules edited by abarth@webkit.org
(diff)
7:03 PM Modules edited by abarth@webkit.org
(diff)
7:01 PM Changeset in webkit [109061] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Source/WebCore

[EFL] Initial implementation of GraphicsContext3DPrivate
https://bugs.webkit.org/show_bug.cgi?id=62961

Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2012-02-27
Reviewed by Noam Rosenthal.

This patch adds the GraphicsContext3DPrivate class using Evas_GL.
GraphicsContext3DPrivate delegates all GL function calls to Evas_GL_API.

  • platform/graphics/efl/GraphicsContext3DPrivate.cpp: Added.

(WebCore):
(WebCore::GraphicsContext3DPrivate::create):
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::initialize):
(WebCore::GraphicsContext3DPrivate::createSurface):
(WebCore::GraphicsContext3DPrivate::platformGraphicsContext3D):
(WebCore::GraphicsContext3DPrivate::makeContextCurrent):
(WebCore::GraphicsContext3DPrivate::isGLES2Compliant):
(WebCore::GraphicsContext3DPrivate::activeTexture):
(WebCore::GraphicsContext3DPrivate::attachShader):
(WebCore::GraphicsContext3DPrivate::bindAttribLocation):
(WebCore::GraphicsContext3DPrivate::bindBuffer):
(WebCore::GraphicsContext3DPrivate::bindFramebuffer):
(WebCore::GraphicsContext3DPrivate::bindRenderbuffer):
(WebCore::GraphicsContext3DPrivate::bindTexture):
(WebCore::GraphicsContext3DPrivate::blendColor):
(WebCore::GraphicsContext3DPrivate::blendEquation):
(WebCore::GraphicsContext3DPrivate::blendEquationSeparate):
(WebCore::GraphicsContext3DPrivate::blendFunc):
(WebCore::GraphicsContext3DPrivate::blendFuncSeparate):
(WebCore::GraphicsContext3DPrivate::bufferData):
(WebCore::GraphicsContext3DPrivate::bufferSubData):
(WebCore::GraphicsContext3DPrivate::checkFramebufferStatus):
(WebCore::GraphicsContext3DPrivate::clear):
(WebCore::GraphicsContext3DPrivate::clearColor):
(WebCore::GraphicsContext3DPrivate::clearDepth):
(WebCore::GraphicsContext3DPrivate::clearStencil):
(WebCore::GraphicsContext3DPrivate::colorMask):
(WebCore::GraphicsContext3DPrivate::compileShader):
(WebCore::GraphicsContext3DPrivate::copyTexImage2D):
(WebCore::GraphicsContext3DPrivate::copyTexSubImage2D):
(WebCore::GraphicsContext3DPrivate::cullFace):
(WebCore::GraphicsContext3DPrivate::depthFunc):
(WebCore::GraphicsContext3DPrivate::depthMask):
(WebCore::GraphicsContext3DPrivate::depthRange):
(WebCore::GraphicsContext3DPrivate::detachShader):
(WebCore::GraphicsContext3DPrivate::disable):
(WebCore::GraphicsContext3DPrivate::disableVertexAttribArray):
(WebCore::GraphicsContext3DPrivate::drawArrays):
(WebCore::GraphicsContext3DPrivate::drawElements):
(WebCore::GraphicsContext3DPrivate::enable):
(WebCore::GraphicsContext3DPrivate::enableVertexAttribArray):
(WebCore::GraphicsContext3DPrivate::finish):
(WebCore::GraphicsContext3DPrivate::flush):
(WebCore::GraphicsContext3DPrivate::framebufferRenderbuffer):
(WebCore::GraphicsContext3DPrivate::framebufferTexture2D):
(WebCore::GraphicsContext3DPrivate::frontFace):
(WebCore::GraphicsContext3DPrivate::generateMipmap):
(WebCore::GraphicsContext3DPrivate::getActiveAttrib):
(WebCore::GraphicsContext3DPrivate::getActiveUniform):
(WebCore::GraphicsContext3DPrivate::getAttachedShaders):
(WebCore::GraphicsContext3DPrivate::getAttribLocation):
(WebCore::GraphicsContext3DPrivate::getBooleanv):
(WebCore::GraphicsContext3DPrivate::getBufferParameteriv):
(WebCore::GraphicsContext3DPrivate::getContextAttributes):
(WebCore::GraphicsContext3DPrivate::getError):
(WebCore::GraphicsContext3DPrivate::getFloatv):
(WebCore::GraphicsContext3DPrivate::getFramebufferAttachmentParameteriv):
(WebCore::GraphicsContext3DPrivate::getIntegerv):
(WebCore::GraphicsContext3DPrivate::getProgramiv):
(WebCore::GraphicsContext3DPrivate::getProgramInfoLog):
(WebCore::GraphicsContext3DPrivate::getRenderbufferParameteriv):
(WebCore::GraphicsContext3DPrivate::getShaderiv):
(WebCore::GraphicsContext3DPrivate::getShaderInfoLog):
(WebCore::GraphicsContext3DPrivate::getShaderSource):
(WebCore::GraphicsContext3DPrivate::getString):
(WebCore::GraphicsContext3DPrivate::getTexParameterfv):
(WebCore::GraphicsContext3DPrivate::getTexParameteriv):
(WebCore::GraphicsContext3DPrivate::getUniformfv):
(WebCore::GraphicsContext3DPrivate::getUniformiv):
(WebCore::GraphicsContext3DPrivate::getUniformLocation):
(WebCore::GraphicsContext3DPrivate::getVertexAttribfv):
(WebCore::GraphicsContext3DPrivate::getVertexAttribiv):
(WebCore::GraphicsContext3DPrivate::getVertexAttribOffset):
(WebCore::GraphicsContext3DPrivate::hint):
(WebCore::GraphicsContext3DPrivate::isBuffer):
(WebCore::GraphicsContext3DPrivate::isEnabled):
(WebCore::GraphicsContext3DPrivate::isFramebuffer):
(WebCore::GraphicsContext3DPrivate::isProgram):
(WebCore::GraphicsContext3DPrivate::isRenderbuffer):
(WebCore::GraphicsContext3DPrivate::isShader):
(WebCore::GraphicsContext3DPrivate::isTexture):
(WebCore::GraphicsContext3DPrivate::lineWidth):
(WebCore::GraphicsContext3DPrivate::linkProgram):
(WebCore::GraphicsContext3DPrivate::pixelStorei):
(WebCore::GraphicsContext3DPrivate::polygonOffset):
(WebCore::GraphicsContext3DPrivate::readPixels):
(WebCore::GraphicsContext3DPrivate::renderbufferStorage):
(WebCore::GraphicsContext3DPrivate::sampleCoverage):
(WebCore::GraphicsContext3DPrivate::scissor):
(WebCore::GraphicsContext3DPrivate::shaderSource):
(WebCore::GraphicsContext3DPrivate::stencilFunc):
(WebCore::GraphicsContext3DPrivate::stencilFuncSeparate):
(WebCore::GraphicsContext3DPrivate::stencilMask):
(WebCore::GraphicsContext3DPrivate::stencilMaskSeparate):
(WebCore::GraphicsContext3DPrivate::stencilOp):
(WebCore::GraphicsContext3DPrivate::stencilOpSeparate):
(WebCore::GraphicsContext3DPrivate::texImage2D):
(WebCore::GraphicsContext3DPrivate::texParameterf):
(WebCore::GraphicsContext3DPrivate::texParameteri):
(WebCore::GraphicsContext3DPrivate::texSubImage2D):
(WebCore::GraphicsContext3DPrivate::uniform1f):
(WebCore::GraphicsContext3DPrivate::uniform1fv):
(WebCore::GraphicsContext3DPrivate::uniform1i):
(WebCore::GraphicsContext3DPrivate::uniform1iv):
(WebCore::GraphicsContext3DPrivate::uniform2f):
(WebCore::GraphicsContext3DPrivate::uniform2fv):
(WebCore::GraphicsContext3DPrivate::uniform2i):
(WebCore::GraphicsContext3DPrivate::uniform2iv):
(WebCore::GraphicsContext3DPrivate::uniform3f):
(WebCore::GraphicsContext3DPrivate::uniform3fv):
(WebCore::GraphicsContext3DPrivate::uniform3i):
(WebCore::GraphicsContext3DPrivate::uniform3iv):
(WebCore::GraphicsContext3DPrivate::uniform4f):
(WebCore::GraphicsContext3DPrivate::uniform4fv):
(WebCore::GraphicsContext3DPrivate::uniform4i):
(WebCore::GraphicsContext3DPrivate::uniform4iv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix2fv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix3fv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix4fv):
(WebCore::GraphicsContext3DPrivate::useProgram):
(WebCore::GraphicsContext3DPrivate::validateProgram):
(WebCore::GraphicsContext3DPrivate::vertexAttrib1f):
(WebCore::GraphicsContext3DPrivate::vertexAttrib1fv):
(WebCore::GraphicsContext3DPrivate::vertexAttrib2f):
(WebCore::GraphicsContext3DPrivate::vertexAttrib2fv):
(WebCore::GraphicsContext3DPrivate::vertexAttrib3f):
(WebCore::GraphicsContext3DPrivate::vertexAttrib3fv):
(WebCore::GraphicsContext3DPrivate::vertexAttrib4f):
(WebCore::GraphicsContext3DPrivate::vertexAttrib4fv):
(WebCore::GraphicsContext3DPrivate::vertexAttribPointer):
(WebCore::GraphicsContext3DPrivate::viewport):
(WebCore::GraphicsContext3DPrivate::createBuffer):
(WebCore::GraphicsContext3DPrivate::createFramebuffer):
(WebCore::GraphicsContext3DPrivate::createProgram):
(WebCore::GraphicsContext3DPrivate::createRenderbuffer):
(WebCore::GraphicsContext3DPrivate::createShader):
(WebCore::GraphicsContext3DPrivate::createTexture):
(WebCore::GraphicsContext3DPrivate::deleteBuffer):
(WebCore::GraphicsContext3DPrivate::deleteFramebuffer):
(WebCore::GraphicsContext3DPrivate::deleteProgram):
(WebCore::GraphicsContext3DPrivate::deleteRenderbuffer):
(WebCore::GraphicsContext3DPrivate::deleteShader):
(WebCore::GraphicsContext3DPrivate::deleteTexture):
(WebCore::GraphicsContext3DPrivate::synthesizeGLError):
(WebCore::GraphicsContext3DPrivate::getExtensions):

  • platform/graphics/efl/GraphicsContext3DPrivate.h: Added.

(WebCore):
(GraphicsContext3DPrivate):

6:58 PM Modules edited by abarth@webkit.org
(diff)
6:36 PM Changeset in webkit [109060] by shawnsingh@chromium.org
  • 5 edits
    3 adds in trunk

RenderLayer ClipRect not accounting for transforms
https://bugs.webkit.org/show_bug.cgi?id=76486

Reviewed by Simon Fraser.

Source/WebCore:

Test: compositing/layer-creation/overlap-transformed-and-clipped.html

This patch changes calculateClipRects() so that the clipRect
offset is allowed to be converted across layers with
transforms. This is necessary because the RenderLayerCompositor
needs clipRects in document space, rather than with respect to
some local clipping layer.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::localToContainerPoint):
(WebCore):

  • rendering/RenderObject.h:

(RenderObject):

LayoutTests:

  • compositing/layer-creation/overlap-transformed-and-clipped-expected.png: Added.
  • compositing/layer-creation/overlap-transformed-and-clipped-expected.txt: Added.
  • compositing/layer-creation/overlap-transformed-and-clipped.html: Added.
6:36 PM Modules edited by abarth@webkit.org
(diff)
6:35 PM Changeset in webkit [109059] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

sputnik/Unicode/Unicode_500/S7.2_A1.6_T1.html crashes in the interpreter
https://bugs.webkit.org/show_bug.cgi?id=79728

Reviewed by Gavin Barraclough.

When initialising a chained get instruction we may end up in a state where
the instruction stream says we have a scopechain, but it has not yet been set
(eg. if allocating the StructureChain itself is what leads to the GC). We could
re-order the allocation, but it occurs in a couple of places, so it seems less
fragile simply to null check the scopechain slot before we actually visit the slot.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitStructures):

6:34 PM Changeset in webkit [109058] by adamk@chromium.org
  • 3 edits
    2 adds in trunk

[MutationObservers] Clear pending mutation records on disconnect()
https://bugs.webkit.org/show_bug.cgi?id=78639

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/mutation/disconnect-cancel-pending.html

  • dom/WebKitMutationObserver.cpp:

(WebCore::WebKitMutationObserver::disconnect): Clear pending records.
(WebCore::WebKitMutationObserver::deliver): Avoid calling the callback if no records are pending delivery.

LayoutTests:

  • fast/mutation/disconnect-cancel-pending-expected.txt: Added.
  • fast/mutation/disconnect-cancel-pending.html: Added.
6:25 PM Modules edited by abarth@webkit.org
(diff)
6:19 PM Modules edited by abarth@webkit.org
(diff)
6:14 PM Changeset in webkit [109057] by rniwa@webkit.org
  • 8 edits
    1 add
    1 delete in trunk

Extract the logic to merge tests from MergeTestsHandler and add unit tests
https://bugs.webkit.org/show_bug.cgi?id=79602

Reviewed by Hajime Morita.

Extracted Test.merge and TestResult.replace_to_change_test_name out of MergeTestsHandler,
and moved MergeTestsHandler into admin_handlers.py where it belongs.

Added new backend "model-manipulator" to execute tasks to merge tests.

Also revive the inadvertently removed manual submission form on the admin page.

  • Websites/webkit-perf.appspot.com/admin_handlers.py:

(AdminDashboardHandler.get_tests):
(MergeTestsHandler):
(MergeTestsHandler.post):

  • Websites/webkit-perf.appspot.com/app.yaml:
  • Websites/webkit-perf.appspot.com/backends.yaml: Added.
  • Websites/webkit-perf.appspot.com/css/admin.css:
  • Websites/webkit-perf.appspot.com/js/admin.js:
  • Websites/webkit-perf.appspot.com/main.py:
  • Websites/webkit-perf.appspot.com/merge_tests_handler.py: Removed.
  • Websites/webkit-perf.appspot.com/models.py:

(Test):
(Test.merge):
(TestResult.replace_to_change_test_name):

  • Websites/webkit-perf.appspot.com/models_unittest.py:

(DataStoreTestsBase.assertOnlyInstance):
(DataStoreTestsBase):
(DataStoreTestsBase.assertOnlyInstances):
(DataStoreTestsBase.assertEqualUnorderedModelList):
(DataStoreTestsBase.assertEqualUnorderedList):
(_create_build):
(TestModelTests.test_merge):
(TestResultTests):
(TestResultTests.test_get_or_insert_value):
(TestResultTests.test_get_or_insert_stat_value):
(TestResultTests.test_replace_to_change_test_name):
(TestResultTests.test_replace_to_change_test_name_with_stat_value):
(TestResultTests.test_replace_to_change_test_name_overrides_conflicting_result):

6:05 PM Changeset in webkit [109056] by dpranke@chromium.org
  • 2 edits in trunk/Tools

nrwt: log multiline stderr/crash output properly
https://bugs.webkit.org/show_bug.cgi?id=79722

Reviewed by Adam Barth.

This cleans up some nits in the log output to make things
slightly easier to read (every line gets timestamped, etc.).

Also tweaks the log message for pixel hash mismatches.

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner._handle_error):
(SingleTestRunner._compare_image):

5:59 PM Changeset in webkit [109055] by beidson@apple.com
  • 4 edits in trunk

<rdar://problem/10924993> and https://bugs.webkit.org/show_bug.cgi?id=79725
<a ping> doesn't work in WebKit2

Reviewed by Alexey Proskuryakov.

Source/WebKit2:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Push the WK2 <a ping> setting to WebCore::Settings.

LayoutTests:

  • platform/wk2/Skipped: Unskip some tests that now pass.
5:56 PM Modules edited by abarth@webkit.org
(diff)
5:51 PM Changeset in webkit [109054] by adamk@chromium.org
  • 3 edits
    2 adds in trunk

Always notify subtree of removal in ContainerNode::removeChildren
https://bugs.webkit.org/show_bug.cgi?id=79316

Reviewed by Ryosuke Niwa.

Source/WebCore:

In the inDocument case, Node::removedFromDocument is called.
In the out-of-document case, call ContainerNode::removedFromTree to ensure,
e.g., form-associated elements are properly disconnected.

Test: fast/forms/form-associated-element-removal.html

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChildren):

LayoutTests:

  • fast/forms/form-associated-element-removal-expected.txt: Added.
  • fast/forms/form-associated-element-removal.html: Added.
5:47 PM Changeset in webkit [109053] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Touch the master.cfg to force a reconfig.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(BuildAndTestLeaksFactory):
(NewBuildAndTestFactory):

5:44 PM Modules edited by abarth@webkit.org
(diff)
5:36 PM Changeset in webkit [109052] by abarth@webkit.org
  • 9 edits in trunk/Source/WebCore

Repair license blocks for files created during modularization
https://bugs.webkit.org/show_bug.cgi?id=79721

Reviewed by Eric Seidel.

We failed to copy the license blocks correctly when moving code into
these files. This patch restores the correct license blocks.

  • Modules/geolocation/NavigatorGeolocation.cpp:
  • Modules/geolocation/NavigatorGeolocation.h:
  • Modules/mediastream/NavigatorMediaStream.cpp:
  • Modules/mediastream/NavigatorMediaStream.h:
  • bindings/js/JSDOMWindowWebAudioCustom.cpp:
  • bindings/js/JSDOMWindowWebSocketCustom.cpp:
  • storage/DOMWindowSQLDatabase.cpp:
  • storage/DOMWindowSQLDatabase.h:
5:34 PM Changeset in webkit [109051] by commit-queue@webkit.org
  • 8 edits in trunk

[BlackBerry] Upstream BlackBerry API web page related files
https://bugs.webkit.org/show_bug.cgi?id=74380

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-02-27
Reviewed by Antonio Gomes.

Source/WebKit/blackberry:

Clean up WebPage.{h, cpp} and WebPage_p.h.

  • Remove WebPage::mainFrame() as it is bad to expose WebCore::Frame in the public API, adapt to the change by adding a new method WebPagePrivate::core(Const WebPage*) and expose it to DumpRenderTreeSupport.
  • Rename WebPage::spellCheckingEnabled to WebPage::setSpellCheckingEnabled.
  • Remove unused WebPage::focusNodeRect().
  • Remove extra blank lines.
  • Put WebPage methods and their associated WebPagePrivate methods together.

No new tests as this patch doesn't change behavior.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::WebPage):
(WebKit):
(BlackBerry::WebKit::WebPage::~WebPage):
(BlackBerry::WebKit::WebPagePrivate::core):
(BlackBerry::WebKit::WebPage::load):
(BlackBerry::WebKit::WebPage::loadExtended):
(BlackBerry::WebKit::WebPage::loadFile):
(BlackBerry::WebKit::WebPage::download):
(BlackBerry::WebKit::WebPage::loadString):
(BlackBerry::WebKit::WebPage::executeJavaScript):
(BlackBerry::WebKit::WebPage::executeJavaScriptInIsolatedWorld):
(BlackBerry::WebKit::WebPage::stopLoading):
(BlackBerry::WebKit::WebPage::prepareToDestroy):
(BlackBerry::WebKit::WebPage::setScrollPosition):
(BlackBerry::WebKit::WebPage::scrollBy):
(BlackBerry::WebKit::WebPage::notifyInRegionScrollStatusChanged):
(BlackBerry::WebKit::WebPage::zoomToFitScale):
(BlackBerry::WebKit::WebPage::initialScale):
(BlackBerry::WebKit::WebPage::maximumScale):
(BlackBerry::WebKit::WebPage::scrollPosition):
(BlackBerry::WebKit::WebPage::viewportSize):
(BlackBerry::WebKit::WebPage::activeNodeContext):
(BlackBerry::WebKit::WebPage::assignFocus):
(BlackBerry::WebKit::WebPage::blockZoomAnimationFinished):
(BlackBerry::WebKit::WebPage::onInputLocaleChanged):
(BlackBerry::WebKit::WebPage::setScreenOrientation):
(BlackBerry::WebKit::WebPage::applyPendingOrientationIfNeeded):
(BlackBerry::WebKit::WebPage::setViewportSize):
(BlackBerry::WebKit::WebPage::setDefaultLayoutSize):
(BlackBerry::WebKit::WebPage::setScrollOriginPoint):
(BlackBerry::WebKit::WebPage::textEncoding):
(BlackBerry::WebKit::WebPage::forcedTextEncoding):
(BlackBerry::WebKit::WebPage::setForcedTextEncoding):
(BlackBerry::WebKit::WebPage::setSpellCheckingEnabled):
(BlackBerry::WebKit::parentLayer):
(BlackBerry::WebKit::WebPagePrivate::inRegionScrollableAreasForPoint):
(BlackBerry::WebKit::WebPage::destroyWebPageCompositor):

  • Api/WebPage.h:

(WebCore):
(WebKit):

  • Api/WebPage_p.h:

(WebCore):
(WebKit):

  • WebKitSupport/DumpRenderTreeSupport.cpp:

(DumpRenderTreeSupport::corePage):
(DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests):
(DumpRenderTreeSupport::resetGeolocationMock):
(DumpRenderTreeSupport::setMockGeolocationError):
(DumpRenderTreeSupport::setMockGeolocationPermission):
(DumpRenderTreeSupport::setMockGeolocationPosition):
(DumpRenderTreeSupport::scalePageBy):

  • WebKitSupport/DumpRenderTreeSupport.h:

(WebCore):
(DumpRenderTreeSupport):

Tools:

Adapt to the removing of WebPage::mainFrame(), use
DumpRenderTreeSupport::corePage() and its mainFrame() instead.

No new tests as this patch doesn't change behavior.

  • DumpRenderTree/blackberry/DumpRenderTree.cpp:

(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
(BlackBerry::WebKit::DumpRenderTree::runTests):

5:32 PM Changeset in webkit [109050] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Add Windows and Linux Chromium perf bots
https://bugs.webkit.org/show_bug.cgi?id=79418

Reviewed by Tony Chang.

Add Chromium Win and Linux perf bots. Also replace Chromium Mac by
the dedicated perf bot slave (uses the same hardware).

  • BuildSlaveSupport/build.webkit.org-config/config.json:
5:30 PM Changeset in webkit [109049] by wangxianzhu@chromium.org
  • 2 edits in trunk/Tools

Undefined variable 'current' when running chromium_android.py
https://bugs.webkit.org/show_bug.cgi?id=79696

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidDriver._read_prompt):

5:24 PM Changeset in webkit [109048] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening, mark another svg test as flaky crasher
https://bugs.webkit.org/show_bug.cgi?id=79707

  • platform/chromium/test_expectations.txt:
5:19 PM Changeset in webkit [109047] by rniwa@webkit.org
  • 1 edit
    5 copies in branches/chromium/1025

Merge 108111 - REGRESSION: empty span creates renders with non-zero height
https://bugs.webkit.org/show_bug.cgi?id=76465

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/css/empty-span.html

fast/css/non-empty-span.html

Empty inlines with line-height, vertical-alignment or font metrics should only get a linebox if there is some
other content in the line. So only create line boxes for such elements on lines that are not empty.

This patch fixes a regression where an empty inline with line-height was propagating its height to an empty line.
It also fixes cases where lines with content that had a leading empty inline element weren't respecting the
vertical alignment or font-height of the empty inline.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::constructLine): only create line boxes for lines that are not empty.
(WebCore::requiresLineBoxForContent): an inline flow with line-height, vertical-alignment, or font-size

will need a linebox if the rest of the line is not empty.

(WebCore):
(WebCore::alwaysRequiresLineBox): rename from inlineFlowRequiresLineBox.
(WebCore::requiresLineBox):
(WebCore::RenderBlock::LineBreaker::nextLineBreak): if the inline flow definitely requires a line, mark

the line non-empty - otherwise hold off.

LayoutTests:

  • fast/css/empty-span-expected.html: Added.
  • fast/css/empty-span.html: Added.
  • fast/css/non-empty-span.html: Added.
  • platform/chromium/test_expectations.txt: Suppress result until rebaseline on MAC and WIN.
  • platform/chromium-linux-x86/fast/css/non-empty-span-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/non-empty-span-expected.txt: Added.

TBR=robert@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9478022

5:16 PM Changeset in webkit [109046] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening, mark more svg tests as flaky crashers
https://bugs.webkit.org/show_bug.cgi?id=79707

  • platform/chromium/test_expectations.txt:
5:12 PM Changeset in webkit [109045] by dbates@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add test case for ::selection:window-inactive
https://bugs.webkit.org/show_bug.cgi?id=79623

Reviewed by Beth Dakin.

Add reftest to ensure that we don't regress inactive selection color.

For completeness, support for inactive selection color was added in
<http://trac.webkit.org/changeset/41094> (<rdar://problem/6077775>).

  • fast/selectors/selection-window-inactive-expected.html: Added.
  • fast/selectors/selection-window-inactive.html: Added.
5:10 PM Changeset in webkit [109044] by bashi@chromium.org
  • 4 edits
    2 copies in branches/chromium/1025

Merge 108724 - Don't clear IntentRequest callback pointers on stop()

This causes re-entry into ScriptExecutionContext when
the ActiveDOMCallback objects get deleted, which crashes.
Instead, just de-activate the object and wait for
context destruction to clean up.

Test crashes consistently without fix and passes with fix.
Added some test infrastructure to support this test.
https://bugs.webkit.org/show_bug.cgi?id=78638

Patch by Greg Billock <gbillock@google.com> on 2012-02-23
Reviewed by Adam Barth.

  • Modules/intents/IntentRequest.cpp:

(WebCore::IntentRequest::IntentRequest):
(WebCore::IntentRequest::stop):
(WebCore::IntentRequest::postResult):
(WebCore::IntentRequest::postFailure):

  • Modules/intents/IntentRequest.h:

(IntentRequest):

TBR=gbillock@google.com
Review URL: https://chromiumcodereview.appspot.com/9479030

5:05 PM Changeset in webkit [109043] by enne@google.com
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Unreviewed gardening, disable TransparencyWinTest unit tests
https://bugs.webkit.org/show_bug.cgi?id=79718

  • tests/TransparencyWinTest.cpp:
5:05 PM Changeset in webkit [109042] by jchaffraix@webkit.org
  • 3 edits in trunk/Source/WebCore

Extract the logic for computing the dirty rows / columns out of RenderTableSection::paintObject
https://bugs.webkit.org/show_bug.cgi?id=79580

Reviewed by Eric Seidel.

Refactoring only.

  • rendering/RenderTableSection.h:

(CellSpan):
(WebCore::CellSpan::CellSpan):
(WebCore::CellSpan::start):
(WebCore::CellSpan::end):
Added this class to hold the span information.

(WebCore::RenderTableSection::fullTableRowSpan):
(WebCore::RenderTableSection::fullTableColumnSpan):
Those functions return the span corresponding to the full table.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::dirtiedRows):
(WebCore::RenderTableSection::dirtiedColumns):
Those functions compute the rows / columns impacted by a |damageRect|. On the slow painting path, they
return the full table span.

(WebCore::RenderTableSection::paintObject):
Updated this function to call the new ones. Also we now inflate the local rectangle with the outlineSize.
This wasn't done previously and we had to manually patch some size comparison to account for the outline.

4:48 PM Changeset in webkit [109041] by commit-queue@webkit.org
  • 6 edits
    7 adds in trunk

Add more tests for web intents
https://bugs.webkit.org/show_bug.cgi?id=79527

Patch by Greg Billock <gbillock@google.com> on 2012-02-27
Reviewed by Adam Barth.

Tools:

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::sendWebIntentResponse):

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):
(WebViewHost::currentIntentRequest):

LayoutTests:

  • webintents/resources/web-intents-testing.js: Added.
  • webintents/web-intents-failure-expected.txt: Added.
  • webintents/web-intents-failure.html: Added.
  • webintents/web-intents-invoke-expected.txt: Added.
  • webintents/web-intents-invoke.html: Added.
  • webintents/web-intents-reply-expected.txt: Added.
  • webintents/web-intents-reply.html: Added.
4:37 PM Changeset in webkit [109040] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Old JIT's style of JSVALUE64 strict equality is subtly wrong
https://bugs.webkit.org/show_bug.cgi?id=79700

Reviewed by Oliver Hunt.

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::comparePtr):
(MacroAssemblerX86_64):

  • dfg/DFGOperations.cpp:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeStrictEq):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):

  • jit/JITOpcodes.cpp:

(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emitSlow_op_stricteq):
(JSC::JIT::emitSlow_op_nstricteq):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

4:36 PM Changeset in webkit [109039] by commit-queue@webkit.org
  • 5 edits in trunk

[EFL] Support mutation observers
https://bugs.webkit.org/show_bug.cgi?id=79603

Patch by ChangSeok Oh <ChangSeok Oh> on 2012-02-27
Reviewed by Eric Seidel.

.:

Added a build-option for the mutation observers feature.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmakeconfig.h.cmake:

LayoutTests:

Rebased skipped tests regarding the mutation observers feature.

  • platform/efl/Skipped:
4:31 PM Changeset in webkit [109038] by barraclough@apple.com
  • 21 edits in trunk/Source/JavaScriptCore

Implement support for op_negate and op_bitnot in the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=79617

Reviewed by Filip Pizlo.

Add an ArithNegate op to the DFG JIT, to implement op_negate.

This patch also adds support for op_negate to the JSVALUE64 baseline JIT
(JSVALUE32_64 already had this), so that we can profile the slowpath usage.

This is a 2.5%-3% Sunspider progression and a 1% win on Kraken.

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::sub_S):

  • Added sub_S from immediate.

(ARMv7Assembler):
(JSC::ARMv7Assembler::vneg):

  • Added double negate.
  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::negateDouble):

  • Added double negate.

(MacroAssemblerARMv7):
(JSC::MacroAssemblerARMv7::branchNeg32):

  • Added.
  • assembler/MacroAssemblerX86.h:

(MacroAssemblerX86):

  • moved loadDouble, absDouble to common.
  • assembler/MacroAssemblerX86Common.h:

(MacroAssemblerX86Common):
(JSC::MacroAssemblerX86Common::absDouble):

  • implementation can be shared.

(JSC::MacroAssemblerX86Common::negateDouble):

  • Added.

(JSC::MacroAssemblerX86Common::loadDouble):

  • allow absDouble to have a common implementation.
  • assembler/MacroAssemblerX86_64.h:

(MacroAssemblerX86_64):

  • moved loadDouble, absDouble to common.
  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • support ArithNegate.
  • dfg/DFGArithNodeFlagsInferencePhase.cpp:

(JSC::DFG::ArithNodeFlagsInferencePhase::propagate):

  • support ArithNegate.
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::makeSafe):

  • support ArithNegate.

(JSC::DFG::ByteCodeParser::parseBlock):

  • support op_negate.
  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::performNodeCSE):

  • support ArithNegate.
  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

  • support op_negate.
  • dfg/DFGGraph.h:

(JSC::DFG::Graph::negateShouldSpeculateInteger):

  • support ArithNegate.
  • dfg/DFGNode.h:

(JSC::DFG::Node::hasArithNodeFlags):

  • support ArithNegate.
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • support ArithNegate.
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileArithNegate):

  • support ArithNegate.
  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

  • support ArithNegate.
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • support ArithNegate.
  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • support ArithNegate.
  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

  • Add support for op_negate in JSVALUE64.
  • jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_negate):
(JSC::JIT::emitSlow_op_negate):

  • Add support for op_negate in JSVALUE64.
4:17 PM Changeset in webkit [109037] by morrita@google.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

Unreviewed, fixed wrong bug URL on the ChangeLog.

4:07 PM Changeset in webkit [109036] by haraken@chromium.org
  • 10 edits
    1 move in trunk/Source/WebCore

Rename resolve-supplemental.pl to preprocess-idls.pl
https://bugs.webkit.org/show_bug.cgi?id=79660

Reviewed by Adam Barth.

Due to r108322, resolve-supplemental.pl not only resolves supplemental
dependencies but also runs IDL attribute checker. For clarification,
this patch renames resolve-supplemental.pl to preprocess-idls.pl.

No tests. Confirm that all builds pass.

  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • UseJSC.cmake:
  • UseV8.cmake:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.vcproj/MigrateScripts:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/preprocess-idls.pl: Renamed from Source/WebCore/bindings/scripts/resolve-supplemental.pl.
3:59 PM Changeset in webkit [109035] by haraken@chromium.org
  • 20 edits in trunk

[JSC] Add [ConstructorParameters=] to all custom constructors
https://bugs.webkit.org/show_bug.cgi?id=78221

Reviewed by Adam Barth.

Source/WebCore:

This patch adds [ConstructorParameters=X] to IDL files that have
custom constructors, where X is the maximum number of arguments
of the constructor. [ConstructorParameters=X] is needed for custom
constructors, because custom constructors do not have a signature
in IDL files and thus CodeGeneratorJS.pm cannot know the number of
constructor arguments.

Test: fast/js/constructor-length.html

  • dom/WebKitMutationObserver.idl:
  • html/DOMFormData.idl:
  • html/canvas/ArrayBuffer.idl:
  • html/canvas/DataView.idl:
  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • html/canvas/Uint8ClampedArray.idl:
  • webaudio/AudioContext.idl:
  • bindings/scripts/test/TestTypedArray.idl:
  • bindings/scripts/test/JS/JSFloat64Array.cpp: Updated run-bindings-tests results.

(WebCore::JSFloat64ArrayConstructor::finishCreation):

LayoutTests:

The added tests check the length property of the custom constructors.

  • fast/js/constructor-length.html:
  • platform/mac/fast/js/constructor-length-expected.txt:
3:56 PM Changeset in webkit [109034] by mahesh.kulkarni@nokia.com
  • 2 edits in trunk/Source/JavaScriptCore

2012-02-27 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>

Unreviewed. Build fix for linux-bot (qt) after r109021.

  • runtime/Error.cpp:
3:48 PM Changeset in webkit [109033] by jamesr@google.com
  • 5 edits in branches/chromium/1025/Source

Disable occlusion tracking and draw culling for Chromium m18

https://bugs.webkit.org/show_bug.cgi?id=79429
BUG=115957

3:40 PM Changeset in webkit [109032] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening, mark many svg tests as flaky crashers
https://bugs.webkit.org/show_bug.cgi?id=79707

  • platform/chromium/test_expectations.txt:
3:40 PM Changeset in webkit [109031] by kubo@profusion.mobi
  • 5 edits
    2 adds in trunk/Source/WebCore

[BlackBerry][EFL] Provide dummy RunLoop implementations.
https://bugs.webkit.org/show_bug.cgi?id=79398

Reviewed by Antonio Gomes.

r108067 fixed the EFL build by not building RunLoop.cpp on EFL and
BlackBerry, as both platforms lack an implementation that provides the
missing methods for the RunLoop class.

However, RunLoop.cpp is a generic file which should not be included
directly in PlatformWinCE.cmake (plus it helps in converting the
AppleWin port to CMake).

Fix this by providing a dummy implementation of the missing RunLoop
methods for both EFL and BlackBerry.

  • CMakeLists.txt:
  • PlatformBlackBerry.cmake:
  • PlatformEfl.cmake:
  • PlatformWinCE.cmake:
  • platform/blackberry/RunLoopBlackBerry.cpp: Added.

(WebCore):
(WebCore::RunLoop::RunLoop):
(WebCore::RunLoop::~RunLoop):
(WebCore::RunLoop::wakeUp):

  • platform/efl/RunLoopEfl.cpp: Added.

(WebCore):
(WebCore::RunLoop::RunLoop):
(WebCore::RunLoop::~RunLoop):
(WebCore::RunLoop::wakeUp):

3:32 PM Changeset in webkit [109030] by sullivan@apple.com
  • 3 edits in trunk/Source/WebCore

Build fix (on Lion at least).

  • dom/Attr.cpp:

(WebCore::Attr::childrenChanged):
Removed names of unused parameters.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::childrenChanged):
Ditto.

3:29 PM Modules created by abarth@webkit.org
3:22 PM Changeset in webkit [109029] by haraken@chromium.org
  • 7 edits in trunk/Source/WebCore

Remove [ConstructorParameters] from IDL files that have [Constructor]
https://bugs.webkit.org/show_bug.cgi?id=79643

Reviewed by Adam Barth.

This patch removes [ConstructorParameters] from IDL files that have [Constructor],
since CodeGeneratorJS.pm can automatically detect the number of constructor
arguments by the [Constructor(...)] signature.

Test: fast/js/constructor-length.html

  • Modules/mediastream/PeerConnection.idl:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateConstructorDefinition):

  • css/WebKitCSSMatrix.idl:
  • page/EventSource.idl:
  • workers/SharedWorker.idl:
  • workers/Worker.idl:
3:09 PM Changeset in webkit [109028] by jchaffraix@webkit.org
  • 2 edits in trunk/Source/WebCore

Avoid doing 2 hash lookups if we override RenderBox's logical width / height
https://bugs.webkit.org/show_bug.cgi?id=79591

Reviewed by Antonio Gomes.

Refactoring only.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::clearOverrideSize):
Instead of doing one hash lookup as part of hasOverride{Height|Width}, let's
just directly call HashMap::remove that will do the lookup instead.

2:59 PM Changeset in webkit [109027] by leviw@chromium.org
  • 19 edits in branches/subpixellayout/Source

Build fix for Mac. Converting linesBoundingBox and borderBoundingBox, and ShadowData to integers. Removing a whitespace change to bring patch size down. Removing an extraneous printf.

2:53 PM Changeset in webkit [109026] by adamk@chromium.org
  • 5 edits in trunk/Source/WebCore

Move WebCore-internal DOM notification methods from Node to ContainerNode where appropriate
https://bugs.webkit.org/show_bug.cgi?id=79697

Reviewed by Ryosuke Niwa.

insertedIntoTree/removedFromTree are only used by subclasses of
ContainerNode. Moreover, attempting to make use of these notifications
in a non-container Node would currently not work, because
Node::removedFromDocument/insertedIntoDocument do not dispatch to these methods.
Rather than adding useless calls to an always-empty virtual method,
this patch moves these methods to ContainerNode.

Meanwhile, childrenChanged moves to ContainerNode for an obvious reason:
non-container Nodes have no children to change.

No new tests, refactoring only.

  • dom/Attr.cpp:

(WebCore::Attr::childrenChanged): Remove call to now-nonexistent Node::childrenChanged.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChild): Check that the removed child is a container node before notifying it of removal.
(WebCore::ContainerNode::parserRemoveChild): ditto.
(WebCore::ContainerNode::insertedIntoTree): Remove call to now-nonexistent Node::insertedIntoTree.
(WebCore::ContainerNode::removedFromTree): Remove call to now-nonexistent Node::removedFromTree.
(WebCore::ContainerNode::childrenChanged): Remove call to now-nonexistent Node::childrenChanged.
(WebCore::notifyChildInserted): Check that the inserted child is a container node before notifying it of insertion.

  • dom/ContainerNode.h:

(ContainerNode): Migrate comments from Node.h, point back at it for more notification methods.

  • dom/Node.h:

(Node): Move methods, update comments to point at ContainerNode.h.

2:19 PM Changeset in webkit [109025] by eae@chromium.org
  • 10 edits in branches/subpixellayout/Source

Fix a IntRect/LayoutRect usage to avoid unnecessary type conversions on branch.

2:19 PM Changeset in webkit [109024] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening, mark two fast/regex tests as failing

  • platform/chromium/test_expectations.txt:
2:15 PM Changeset in webkit [109023] by crogers@google.com
  • 9 edits
    2 adds in trunk

Implement static compression curve parameters for DynamicsCompressorNode
https://bugs.webkit.org/show_bug.cgi?id=78937

Reviewed by Kenneth Russell.

Source/WebCore:

Test: webaudio/dynamicscompressor-basic.html

  • platform/audio/DynamicsCompressor.cpp:

(WebCore::DynamicsCompressor::setParameterValue):
(WebCore):
(WebCore::DynamicsCompressor::initializeParameters):
(WebCore::DynamicsCompressor::process):

  • platform/audio/DynamicsCompressor.h:
  • platform/audio/DynamicsCompressorKernel.cpp:

(WebCore):
(WebCore::DynamicsCompressorKernel::DynamicsCompressorKernel):
(WebCore::DynamicsCompressorKernel::setPreDelayTime):
(WebCore::DynamicsCompressorKernel::kneeCurve):
(WebCore::DynamicsCompressorKernel::saturate):
(WebCore::DynamicsCompressorKernel::slopeAt):
(WebCore::DynamicsCompressorKernel::kAtSlope):
(WebCore::DynamicsCompressorKernel::updateStaticCurveParameters):
(WebCore::DynamicsCompressorKernel::process):

  • platform/audio/DynamicsCompressorKernel.h:

(DynamicsCompressorKernel):
(WebCore::DynamicsCompressorKernel::meteringGain):

  • webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
(WebCore::DynamicsCompressorNode::process):

  • webaudio/DynamicsCompressorNode.h:

(WebCore):
(WebCore::DynamicsCompressorNode::create):
(DynamicsCompressorNode):
(WebCore::DynamicsCompressorNode::threshold):
(WebCore::DynamicsCompressorNode::knee):
(WebCore::DynamicsCompressorNode::ratio):
(WebCore::DynamicsCompressorNode::reduction):

  • webaudio/DynamicsCompressorNode.idl:

LayoutTests:

  • webaudio/dynamicscompressor-basic-expected.txt: Added.
  • webaudio/dynamicscompressor-basic.html: Added.
2:03 PM Changeset in webkit [109022] by enrica@apple.com
  • 7 edits in trunk/Source

WebKit2: implement platform strategy to access Pasteboard in the UI process.
https://bugs.webkit.org/show_bug.cgi?id=79253
<rdar://problem/9971876>

Reviewed by Alexey Proskuryakov.

Source/WebCore:

No new tests. No behavior change.

  • platform/mac/PlatformPasteboardMac.mm:

(WebCore::PlatformPasteboard::bufferForType): There is no need
to create a SharedBuffer object if there is no NSData in the pasteboard
for the given pasteboard type.

Source/WebKit2:

  • UIProcess/WebContext.h:
  • UIProcess/WebContext.messages.in: Added messages to access NSPasteboard

in the UI process.

  • UIProcess/mac/WebContextMac.mm: Added methods corresponding to the

new messages.
(WebKit::WebContext::getPasteboardTypes):
(WebKit::WebContext::getPasteboardPathnamesForType):
(WebKit::WebContext::getPasteboardStringForType):
(WebKit::WebContext::getPasteboardBufferForType):
(WebKit::WebContext::pasteboardCopy):
(WebKit::WebContext::getPasteboardChangeCount):
(WebKit::WebContext::getPasteboardUniqueName):
(WebKit::WebContext::getPasteboardColor):
(WebKit::WebContext::setPasteboardTypes):
(WebKit::WebContext::setPasteboardPathnamesForType):
(WebKit::WebContext::setPasteboardStringForType):
(WebKit::WebContext::setPasteboardBufferForType):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: New implementation of the PasteboardStrategy using message exchange

with the UI process.
(WebKit::WebPlatformStrategies::getTypes):
(WebKit::WebPlatformStrategies::bufferForType):
(WebKit::WebPlatformStrategies::getPathnamesForType):
(WebKit::WebPlatformStrategies::stringForType):
(WebKit::WebPlatformStrategies::copy):
(WebKit::WebPlatformStrategies::changeCount):
(WebKit::WebPlatformStrategies::uniqueName):
(WebKit::WebPlatformStrategies::color):
(WebKit::WebPlatformStrategies::setTypes):
(WebKit::WebPlatformStrategies::setBufferForType):
(WebKit::WebPlatformStrategies::setPathnamesForType):
(WebKit::WebPlatformStrategies::setStringForType):

1:33 PM Changeset in webkit [109021] by oliver@apple.com
  • 4 edits in trunk

REGRESSION (r108112): AWS Management Console at amazon.com fails to initialize
https://bugs.webkit.org/show_bug.cgi?id=79693

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Alas we can't provide the stack trace as an array, as despite everyone wanting
an array, everyone arbitrarily creates the array by calling split on the stack
trace. To create the array we would have provided them in the first place.

This changes the exception's stack property to a \n separated string. To get the
old array just do <exception>.stack.split("\n").

  • runtime/Error.cpp:

(JSC::addErrorInfo):

LayoutTests:

Update test case to handle Error.stack being a string rather than an array.

  • fast/js/script-tests/stack-trace.js:

(printStack):

1:24 PM Changeset in webkit [109020] by enne@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] Unreviewed speculative Chromium win build fix.

mdelaney's http://trac.webkit.org/changeset/109016 changed the
interface on ImageBuffer, but didn't update TransparencyWin.

  • platform/graphics/chromium/TransparencyWin.cpp:

(WebCore::TransparencyWin::OwnedBuffers::canHandleSize):

1:22 PM Changeset in webkit [109019] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Selection handling should be entirely directional
https://bugs.webkit.org/show_bug.cgi?id=79692

Patch by Mike Fenton <mifenton@rim.com> on 2012-02-27
Reviewed by Antonio Gomes.

Make all VisibleSelections directional.

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
(BlackBerry::WebKit::SelectionHandler::setSelection):

1:10 PM Changeset in webkit [109018] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Cleanup Gesture requirement when exiting video-play-require-user-gesture test
https://bugs.webkit.org/show_bug.cgi?id=79690

Patch by Min Qin <qinmin@google.com> on 2012-02-27
Reviewed by Philippe Normand.

  • media/video-play-require-user-gesture.html:
1:03 PM Changeset in webkit [109017] by wangxianzhu@chromium.org
  • 2 edits in trunk/Tools

Chromium-Android layout test script: the adb shell prompt is not always '# '
https://bugs.webkit.org/show_bug.cgi?id=79506

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidDriver._start):
(ChromiumAndroidDriver._read_prompt):

12:43 PM Changeset in webkit [109016] by mdelaney@apple.com
  • 26 edits in trunk/Source/WebCore

Add ImageBuffer support for having a hi-res backing store. This allows
ImageBuffer clients to specify a scale factor upon creation so that they
don't have to maintain that info themselves as they use/pass around the ImageBuffer.
https://bugs.webkit.org/show_bug.cgi?id=79395

Reviewed by Dan Bernstein.

No new tests. This patch doesn't change behavior.

  • platform/graphics/ImageBuffer.h:

(WebCore::ImageBuffer::create): Scale the backing store by the resolution scale.
(WebCore::ImageBuffer::logicalSize): Differentiate the logical size from the backing store's size.
(WebCore::ImageBuffer::internalSize): The backing store's size.

  • platform/graphics/cg/ImageBufferCG.cpp: Prefer the explicit use of logicalSize and internalSize.

Explicitly state a 1x scale for all ImageBuffer creation sites
since this is what they currently assume.

  • html/HTMLCanvasElement.cpp:
  • html/canvas/CanvasRenderingContext2D.cpp:
  • html/canvas/WebGLRenderingContext.cpp:
  • page/Frame.cpp:
  • platform/graphics/CrossfadeGeneratedImage.cpp:
  • platform/graphics/ShadowBlur.cpp:
  • platform/graphics/filters/FEColorMatrix.cpp:
  • platform/graphics/filters/FEDropShadow.cpp:
  • platform/graphics/filters/FilterEffect.cpp:
  • platform/mac/ScrollbarThemeMac.mm:
  • rendering/FilterEffectRenderer.cpp:
  • rendering/RenderThemeMac.mm:
  • rendering/svg/SVGImageBufferTools.cpp:
  • svg/graphics/SVGImage.cpp:
  • svg/graphics/SVGImageCache.cpp:

Update ImageBuffer::size() calls to new versions.

  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/ImageBuffer.cpp:
  • platform/graphics/skia/PlatformContextSkia.cpp:
12:36 PM Changeset in webkit [109015] by mihnea@adobe.com
  • 20 edits in trunk

[CSSRegions]-webkit-flow-into initial value should be none instead of auto
https://bugs.webkit.org/show_bug.cgi?id=79670

Reviewed by Simon Fraser.

Source/WebCore:

No new tests, modified expectations for existing tests.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFlowThread):

  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

LayoutTests:

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/regions/css-regions-disabled-expected.txt:
  • fast/regions/script-tests/css-regions-disabled.js:
  • fast/regions/script-tests/webkit-flow-parsing.js:
  • fast/regions/webkit-flow-parsing-expected.txt:
  • platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/svg/css/getComputedStyle-basic-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
12:33 PM Changeset in webkit [109014] by ojan@chromium.org
  • 3 edits
    2 adds in trunk

implement display: -webkit-inline-flexbox
https://bugs.webkit.org/show_bug.cgi?id=77772

Reviewed by David Hyatt.

Source/WebCore:

Tests: css3/flexbox/inline-flexbox-expected.html

css3/flexbox/inline-flexbox.html

  • rendering/style/RenderStyle.h:

-Add INLINE_FLEXBOX to the list of replaced display types.
-Restructure the isDisplayInline methods to avoid code duplication.

LayoutTests:

  • css3/flexbox/inline-flexbox-expected.html: Added.
  • css3/flexbox/inline-flexbox.html: Added.
12:03 PM Changeset in webkit [109013] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Dragging a selection handle outside of the content bounding box does not update the selection range correctly
https://bugs.webkit.org/show_bug.cgi?id=78608

Ensure that when selection handles leave the content bounding box that
the handle not being dragged remains fixed. Do not apply padding to a
direction that would cause the selection to shrink when performing the
handle direction detection.

Patch by Ed Baker <edbaker@rim.com> on 2012-02-27
Reviewed by Antonio Gomes.

  • WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::convertPointToFrame):

  • WebKitSupport/DOMSupport.h:
  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::clamp):
(BlackBerry::WebKit::directionalVisiblePositionAtExtentOfBox):
(BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
(BlackBerry::WebKit::SelectionHandler::setSelection):
(BlackBerry::WebKit::SelectionHandler::clipPointToVisibleContainer):

  • WebKitSupport/SelectionHandler.h:
11:58 AM Changeset in webkit [109012] by rniwa@webkit.org
  • 4 edits
    2 copies in branches/chromium/963

REGRESSION(r99076): WebKit pastes the trailing newline into a single-line text field
https://bugs.webkit.org/show_bug.cgi?id=79305

Reviewed by Tony Chang.

LayoutTests:

Add a regression test. Also make Markup.dump() dump the shadow DOM of the specififed node.

  • editing/input/paste-text-ending-with-interchange-newline-expected.txt: Added.
  • editing/input/paste-text-ending-with-interchange-newline.html: Added.
  • resources/dump-as-markup.js:

(Markup._get):
(Markup._getShadowHostIfPossible):

Source/WebCore:

The bug was caused by ReplacementFragment::m_hasInterchangeNewlineAtEnd not reset even when
text field's beforeTextInserted event handler removed interchange new lines at the end.
Because the event handler is responsible for trimming new lines, we need to recompute the values
for m_hasInterchangeNewlineAt* after the event dispatch.

Test: editing/input/paste-text-ending-with-interchange-newline.html

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplacementFragment::ReplacementFragment):
Merge 108668 - REGRESSION(r99076): WebKit pastes the trailing newline into a single-line text field
https://bugs.webkit.org/show_bug.cgi?id=79305

Reviewed by Tony Chang.

Source/WebCore:

The bug was caused by ReplacementFragment::m_hasInterchangeNewlineAtEnd not reset even when
text field's beforeTextInserted event handler removed interchange new lines at the end.
Because the event handler is responsible for trimming new lines, we need to recompute the values
for m_hasInterchangeNewlineAt* after the event dispatch.

Test: editing/input/paste-text-ending-with-interchange-newline.html

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplacementFragment::ReplacementFragment):

LayoutTests:

Add a regression test. Also make Markup.dump() dump the shadow DOM of the specififed node.

  • editing/input/paste-text-ending-with-interchange-newline-expected.txt: Added.
  • editing/input/paste-text-ending-with-interchange-newline.html: Added.
  • resources/dump-as-markup.js:

(Markup._get):
(Markup._getShadowHostIfPossible):

TBR=rniwa@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9477008

11:48 AM Changeset in webkit [109011] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Absolute positioned elements with Inline Relative Positioned Container are not layout correctly
https://bugs.webkit.org/show_bug.cgi?id=78713

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-02-27
Reviewed by David Hyatt.

Source/WebCore:

Test: fast/css/positioned-in-relative-position-inline-crash.html

Patch originally by Robin Cao.

This is a regression. r104183 changes containingBlock() so that it returns the container
of an anonymous block for positioned objects, not the anonymous block itself. We should
change markContainingBlocksForLayout() to match the change in containingBlock().

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::markContainingBlocksForLayout):

LayoutTests:

Test case originally by Robin Cao. This exercises the crashing
condition in bug 78713.

  • fast/css/positioned-in-relative-position-inline-crash-expected.txt: Added.
  • fast/css/positioned-in-relative-position-inline-crash.html: Added.
11:26 AM Changeset in webkit [109010] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderLayer.cpp

Properly using pixel snapping to determing RenderLayer size on Layered Inlines.

11:14 AM Changeset in webkit [109009] by pfeldman@chromium.org
  • 8 edits in trunk

Web Inspector: move record formatting into the timeline presentation model.
https://bugs.webkit.org/show_bug.cgi?id=79684

Source/WebCore:

Drive-by: fix for stop recording in reset; cpu time restored.

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/TimelineModel.js:

(WebInspector.TimelineModel.prototype.reset):

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane.prototype.update.updateBoundaries):
(WebInspector.TimelineOverviewCalculator.prototype.updateBoundaries):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._rootRecord):
(WebInspector.TimelinePanel.prototype._updateRecordsCounter):
(WebInspector.TimelinePanel.prototype._repopulateRecords):
(WebInspector.TimelinePanel.prototype._onTimelineEventRecorded):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype._resetPanel):
(WebInspector.TimelinePanel.prototype._refresh):
(WebInspector.TimelinePanel.prototype._updateBoundaries):
(WebInspector.TimelinePanel.prototype._filterRecords):
(WebInspector.TimelinePanel.prototype.revealRecordAt):
(WebInspector.TimelinePanel.prototype._showPopover):
(WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages):
(WebInspector.TimelineCalculator.prototype.computeBarGraphWindowPosition):
(WebInspector.TimelineCalculator.prototype.updateBoundaries):
(WebInspector.TimelineStartAtZeroCalculator.prototype.computeBarGraphPercentages):
(WebInspector.TimelineRecordGraphRow):
(WebInspector.TimelineRecordGraphRow.prototype.update):

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel):
(WebInspector.TimelinePresentationModel.prototype.createFormattedRecord):
(WebInspector.TimelinePresentationModel.prototype._createRootRecord):
(WebInspector.TimelinePresentationModel.prototype.rootRecord):
(WebInspector.TimelinePresentationModel.prototype.reset):
(WebInspector.TimelinePresentationModel.prototype._findParentRecord):
(WebInspector.TimelinePresentationModel.prototype._resetWindow):
(WebInspector.TimelinePresentationModel.prototype._addCategory):
(WebInspector.TimelinePresentationModel.prototype.setCategoryVisibility):
(WebInspector.TimelinePresentationModel.prototype.get _recordStyles):
(WebInspector.TimelinePresentationModel.Record):
(WebInspector.TimelinePresentationModel.Record.prototype.get lastChildEndTime):
(WebInspector.TimelinePresentationModel.Record.prototype.set lastChildEndTime):
(WebInspector.TimelinePresentationModel.Record.prototype.get selfTime):
(WebInspector.TimelinePresentationModel.Record.prototype.set selfTime):
(WebInspector.TimelinePresentationModel.Record.prototype.get cpuTime):
(WebInspector.TimelinePresentationModel.Record.prototype.isLong):
(WebInspector.TimelinePresentationModel.Record.prototype.get children):
(WebInspector.TimelinePresentationModel.Record.prototype.containsTime):
(WebInspector.TimelinePresentationModel.Record.prototype._generateAggregatedInfo):
(WebInspector.TimelinePresentationModel.Record.prototype.generatePopupContent):
(WebInspector.TimelinePresentationModel.Record.prototype._refreshDetails):
(WebInspector.TimelinePresentationModel.Record.prototype._getRecordDetails):
(WebInspector.TimelinePresentationModel.Record.prototype._linkifyLocation):
(WebInspector.TimelinePresentationModel.Record.prototype._linkifyCallFrame):
(WebInspector.TimelinePresentationModel.Record.prototype._linkifyTopCallFrame):
(WebInspector.TimelinePresentationModel.Record.prototype._linkifyScriptLocation):
(WebInspector.TimelinePresentationModel.Record.prototype.calculateAggregatedStats):
(WebInspector.TimelinePresentationModel.Record.prototype.get aggregatedStats):
(WebInspector.TimelinePresentationModel.PopupContentHelper):
(WebInspector.TimelinePresentationModel.PopupContentHelper.prototype._createCell):
(WebInspector.TimelinePresentationModel.PopupContentHelper.prototype._appendTextRow):
(WebInspector.TimelinePresentationModel.PopupContentHelper.prototype._appendElementRow):
(WebInspector.TimelinePresentationModel.PopupContentHelper.prototype._appendStackTrace):

  • inspector/front-end/timelinePanel.css:

(.timeline-graph-bar.cpu):

LayoutTests:

Reviewed by Vsevolod Vlasov.

  • inspector/timeline/timeline-receive-response-event.html:
10:29 AM Changeset in webkit [109008] by barraclough@apple.com
  • 6 edits
    3 adds in trunk

RegExp lastIndex should behave as a regular property
https://bugs.webkit.org/show_bug.cgi?id=79446

Reviewed by Sam Weinig.

lastIndex should be a regular data descriptor, with the attributes configurable:false,
enumerable:false, writable:true. As such, it should be possible to reconfigure writable
as false. If the lastIndex property is reconfigured to be read-only, we should respect
this correctly.

Source/JavaScriptCore:

  • runtime/CommonIdentifiers.h:
    • Removed some unused identifiers, added lastIndex.
  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::getOwnPropertySlot):

  • lastIndex is no longer a static value, provided specific handling.

(JSC::RegExpObject::getOwnPropertyDescriptor):

  • lastIndex is no longer a static value, provided specific handling.

(JSC::RegExpObject::deleteProperty):

  • lastIndex is no longer a static value, provided specific handling.

(JSC::RegExpObject::getOwnPropertyNames):

  • lastIndex is no longer a static value, provided specific handling.

(JSC::RegExpObject::getPropertyNames):

  • lastIndex is no longer a static value, provided specific handling.

(JSC::reject):

  • helper function for defineOwnProperty.

(JSC::RegExpObject::defineOwnProperty):

  • lastIndex is no longer a static value, provided specific handling.

(JSC::RegExpObject::put):

  • lastIndex is no longer a static value, provided specific handling.

(JSC::RegExpObject::match):

  • Pass setLastIndex an ExecState, so it can throw if read-only.
  • runtime/RegExpObject.h:

(JSC::RegExpObject::setLastIndex):

  • Pass setLastIndex an ExecState, so it can throw if read-only.

(RegExpObjectData):

  • Added lastIndexIsWritable.
  • runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncCompile):

  • Pass setLastIndex an ExecState, so it can throw if read-only.

LayoutTests:

  • fast/regex/lastIndex-expected.txt: Added.
  • fast/regex/lastIndex.html: Added.
  • fast/regex/script-tests/lastIndex.js: Added.
    • Added test cases for correct handling of lastIndex.
10:26 AM Changeset in webkit [109007] by barraclough@apple.com
  • 22 edits in trunk/Source/JavaScriptCore

Implement support for op_negate and op_bitnot in the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=79617

Reviewed by Sam Weinig.

Remove op_bitnop - this is redundant, ~x === x-1.
This is a fractional (<1%) progression.

Remove not32(X) from the MacroAssemblers - make this an optimization to add32(-1, X).
Remove CanReuse from the result type - this was unused.
Remove op_bitnot.

  • assembler/MacroAssemblerARM.h:

(MacroAssemblerARM):
(JSC::MacroAssemblerARM::xor32):

  • assembler/MacroAssemblerARMv7.h:

(MacroAssemblerARMv7):
(JSC::MacroAssemblerARMv7::xor32):

  • assembler/MacroAssemblerMIPS.h:

(MacroAssemblerMIPS):
(JSC::MacroAssemblerMIPS::xor32):

  • assembler/MacroAssemblerSH4.h:

(MacroAssemblerSH4):
(JSC::MacroAssemblerSH4::xor32):

  • assembler/MacroAssemblerX86Common.h:

(MacroAssemblerX86Common):
(JSC::MacroAssemblerX86Common::xor32):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

  • bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

  • bytecompiler/NodesCodegen.cpp:

(JSC):
(JSC::BitwiseNotNode::emitBytecode):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:

(JIT):

  • jit/JITArithmetic32_64.cpp:

(JSC):

  • jit/JITOpcodes.cpp:

(JSC):

  • jit/JITStubs.cpp:

(JSC):

  • jit/JITStubs.h:
  • llint/LLIntSlowPaths.cpp:

(LLInt):

  • llint/LLIntSlowPaths.h:

(LLInt):

  • llint/LowLevelInterpreter32_64.asm:
  • parser/NodeConstructors.h:

(JSC::NegateNode::NegateNode):
(JSC::BitwiseNotNode::BitwiseNotNode):
(JSC::MultNode::MultNode):
(JSC::DivNode::DivNode):
(JSC::ModNode::ModNode):
(JSC::SubNode::SubNode):
(JSC::UnsignedRightShiftNode::UnsignedRightShiftNode):

  • parser/Nodes.h:

(BitwiseNotNode):
(JSC::BitwiseNotNode::expr):
(JSC):

  • parser/ResultType.h:

(ResultType):
(JSC::ResultType::numberTypeIsInt32):
(JSC::ResultType::stringOrNumberType):
(JSC::ResultType::forAdd):
(JSC::ResultType::forBitOp):

10:15 AM Changeset in webkit [109006] by vsevik@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: Scripts navigator overlay should not consume mouse actions.
https://bugs.webkit.org/show_bug.cgi?id=79674

Reviewed by Pavel Feldman.

  • inspector/front-end/Panel.js:

(WebInspector.Panel.prototype.registerShortcut):
(WebInspector.Panel.prototype.unregisterShortcut):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._editorClosed):
(WebInspector.ScriptsPanel.prototype._editorSelected):
(WebInspector.ScriptsPanel.prototype._fileSelected):
(WebInspector.ScriptsPanel.prototype._escDownWhileNavigatorOverlayOpen):
(WebInspector.ScriptsPanel.prototype.set _showNavigatorOverlay):
(WebInspector.ScriptsPanel.prototype._hideNavigatorOverlay):
(WebInspector.ScriptsPanel.prototype._navigatorOverlayWasShown):

  • inspector/front-end/SidebarOverlay.js:

(WebInspector.SidebarOverlay):
(WebInspector.SidebarOverlay.prototype.show):
(WebInspector.SidebarOverlay.prototype._containingElementFocused):
(WebInspector.SidebarOverlay.prototype.position):
(WebInspector.SidebarOverlay.prototype.hide):
(WebInspector.SidebarOverlay.prototype._setWidth):

  • inspector/front-end/dialog.css:

(.go-to-line-dialog button:active):

  • inspector/front-end/scriptsPanel.css:

(#scripts-editor-view .sidebar-overlay):

  • inspector/front-end/splitView.css:

(.split-view-resizer):
(.sidebar-overlay):
(.sidebar-overlay-resizer):

10:04 AM Changeset in webkit [109005] by Philippe Normand
  • 6 edits
    2 adds in trunk/Source/WebCore

[GStreamer] 0.11 support in MediaPlayerPrivateGStreamer
https://bugs.webkit.org/show_bug.cgi?id=77089

Reviewed by Martin Robinson.

Basic port to GStreamer 0.11 APIs. This patch excludes the video
painting changes and the GStreamerGWorld changes which are handled
in two other patches (bugs 77087 and 77088).

  • GNUmakefile.list.am: Add GStreamerVersioning files to the build.
  • Source/WebCore/PlatformEfl.cmake: Ditto.
  • Source/WebCore/Target.pri: Ditto.
  • platform/graphics/gstreamer/GRefPtrGStreamer.cpp:

(WTF::GstElement):
(WTF::GstPad):
(WTF::GstPadTemplate):
(WTF::GstTask):

  • platform/graphics/gstreamer/GStreamerVersioning.cpp: Added.

(webkit_gst_object_ref_sink):
(webkit_gst_element_get_pad_caps):

  • platform/graphics/gstreamer/GStreamerVersioning.h: Added.
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::isAvailable):
(WebCore::MediaPlayerPrivateGStreamer::duration):
(WebCore::MediaPlayerPrivateGStreamer::naturalSize):

10:00 AM Changeset in webkit [109004] by mitz@apple.com
  • 4 edits
    2 adds in trunk

Source/WebKit2: <rdar://problem/9557598> REGRESSION (WebKit2): Non-activating links sometimes don’t work
https://bugs.webkit.org/show_bug.cgi?id=79607

Reviewed by Adele Peterson.

Test: TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm

This was caused by not mapping the mouse event coordinates from window coordinates to
document coordinates.

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performDictionaryLookupAtLocation): Convert the point to main frame
coordinates when performing the hit test.
(WebKit::WebPage::shouldDelayWindowOrderingEvent): Convert the point to the main or focused
frame coordinates when perfomring the hit test.
(WebKit::WebPage::acceptsFirstMouse): Ditto.

Tools: Added a test for <rdar://problem/9557598> REGRESSION (WebKit2): Non-activating links sometimes don’t work
https://bugs.webkit.org/show_bug.cgi?id=79607

Reviewed by Adele Peterson.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
  • TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm: Added.

(TestWebKitAPI::AcceptsFirstMouse::url):
(TestWebKitAPI::AcceptsFirstMouse::didLoadURL):
(TestWebKitAPI::AcceptsFirstMouse::runTest):
(TestWebKitAPI::TEST_F):

  • TestWebKitAPI/Tests/mac/acceptsFirstMouse.html: Added.
9:57 AM Changeset in webkit [109003] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Stop recomputing SVG path data twice during layout
https://bugs.webkit.org/show_bug.cgi?id=79672

Patch by Philip Rogers <pdr@google.com> on 2012-02-27
Reviewed by Nikolas Zimmermann.

  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::layout):

9:51 AM Changeset in webkit [109002] by timothy@apple.com
  • 12 edits in trunk/Source

Add WKInspector API to know when the Web Inspector is the frontmost window.

https://webkit.org/b/79649

Reviewed by John Sullivan.

Source/WebCore: Updated for WebKit2 string changes.

  • English.lproj/Localizable.strings: Updated.

Source/WebKit2: Also makes the Safari Develop menu items work when the Web Inspector is frontmost.

  • UIProcess/API/C/WKInspector.cpp:

(WKInspectorIsFront): Added. Call WebInspectorProxy::isFront.

  • UIProcess/API/C/WKInspector.h:
  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::isFront): Added. Call platformIsFront.

  • UIProcess/WebInspectorProxy.h:
  • UIProcess/efl/WebInspectorEfl.cpp:

(WebKit::WebInspectorProxy::platformIsFront): Added stub.

  • UIProcess/gtk/WebInspectorGtk.cpp:

(WebKit::WebInspectorProxy::platformIsFront): Added stub.

  • UIProcess/mac/WebInspectorProxyMac.mm:

(-[WKWebInspectorProxyObjCAdapter showWebInspector:]): Added. Makes the Develop menu items in Safari work when
the Web Inspector window is front.
(-[WKWebInspectorProxyObjCAdapter showErrorConsole:]): Added. Ditto.
(-[WKWebInspectorProxyObjCAdapter showResources:]): Added. Ditto.
(-[WKWebInspectorProxyObjCAdapter viewSource:]): Added. Ditto.
(-[WKWebInspectorProxyObjCAdapter toggleDebuggingJavaScript:]): Added. Ditto.
(-[WKWebInspectorProxyObjCAdapter toggleProfilingJavaScript:]): Added. Ditto.
(-[WKWebInspectorProxyObjCAdapter validateUserInterfaceItem:]): Added. Update the menu item titles.
(WebKit::WebInspectorProxy::platformIsFront): Added. Return if visible and the window is main.

  • UIProcess/qt/WebInspectorProxyQt.cpp:

(WebKit::WebInspectorProxy::platformIsFront): Added stub.

  • UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::platformIsFront): Added stub.

9:42 AM Changeset in webkit [109001] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening, mark getPutImageDataPair as slow
https://bugs.webkit.org/show_bug.cgi?id=79679

  • platform/chromium/test_expectations.txt:
9:34 AM Changeset in webkit [109000] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Ctrl+K should not zoom in
https://bugs.webkit.org/show_bug.cgi?id=79676

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/inspector.js:

(WebInspector.documentKeyDown):

9:22 AM Changeset in webkit [108999] by msaboff@apple.com
  • 5 edits in trunk

Error check regexp min quantifier
https://bugs.webkit.org/show_bug.cgi?id=70648

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Added checking for min or only quantifier being UINT_MAX.
When encountered this becomes a SyntaxError during parsing.

  • yarr/YarrParser.h:

(JSC::Yarr::Parser::parseQuantifier):
(JSC::Yarr::Parser::parse):
(Parser):

LayoutTests:

New test added to check for newly generated SyntaxError.

  • fast/regex/overflow-expected.txt:
  • fast/regex/script-tests/overflow.js:

(quantifyMaxInt):

9:01 AM Changeset in webkit [108998] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk

Patch from Vincent Untz <vuntz@gnome.org> to fix gtk2 build

8:58 AM Changeset in webkit [108997] by pfeldman@chromium.org
  • 14 edits
    2 adds
    1 delete in trunk

Web Inspector: extract TimelineModel and TimelinePresentationModel into their own files.
https://bugs.webkit.org/show_bug.cgi?id=79675

Reviewed by Vsevolod Vlasov.

Source/WebCore:

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.sh:
  • inspector/front-end/TimelineAgent.js: Removed.
  • inspector/front-end/TimelineModel.js: Added.

(WebInspector.TimelineModel):
(WebInspector.TimelineModel.prototype.startRecord):
(WebInspector.TimelineModel.prototype.stopRecord):
(WebInspector.TimelineModel.prototype.get records):
(WebInspector.TimelineModel.prototype._onRecordAdded):
(WebInspector.TimelineModel.prototype._addRecord):
(WebInspector.TimelineModel.prototype._loadNextChunk):
(WebInspector.TimelineModel.prototype._loadFromFile):
(WebInspector.TimelineModel.prototype._loadFromFile.onError):
(WebInspector.TimelineModel.prototype._saveToFile):
(WebInspector.TimelineModel.prototype._reset):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype.get _recordStyles):
(WebInspector.TimelinePanel.prototype._createEventDivider):
(WebInspector.TimelinePanel.prototype._findParentRecord):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):

  • inspector/front-end/TimelinePresentationModel.js: Added.

(WebInspector.TimelinePresentationModel):
(WebInspector.TimelinePresentationModel.prototype.reset):
(WebInspector.TimelinePresentationModel.prototype.get categories):
(WebInspector.TimelinePresentationModel.prototype.addCategory):
(WebInspector.TimelinePresentationModel.prototype.setWindowPosition):
(WebInspector.TimelinePresentationModel.prototype.setWindowIndices):
(WebInspector.TimelinePresentationModel.prototype.setCategoryVisibility):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:

LayoutTests:

  • inspector/timeline/timeline-enum-stability.html:
  • inspector/timeline/timeline-network-resource.html:
  • inspector/timeline/timeline-paint.html:
  • inspector/timeline/timeline-script-tag-1.html:
  • inspector/timeline/timeline-test.js:

(initialize_Timeline.InspectorTest.waitForRecordType.addRecord):
(initialize_Timeline.InspectorTest.waitForRecordType):
(initialize_Timeline.InspectorTest.printTimelineRecords):
(initialize_Timeline.InspectorTest.dumpTimelineRecord):
(initialize_Timeline.InspectorTest._timelineAgentTypeToString):

8:54 AM Changeset in webkit [108996] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

Build fix for building with GTK+ 2.x.

Patch by Vincent Untz <vuntz@gnome.org>> and Gustavo Noronha Silva <gns@gnome.org> on 2012-02-27

  • tests/testwebview.c:
8:49 AM SettingUpDevelopmentEnvironmentForN9 edited by zarvai@inf.u-szeged.hu
(diff)
8:36 AM Changeset in webkit [108995] by apavlov@chromium.org
  • 11 edits in trunk

Web Inspector: [Styles] Allow adding CSS properties anywhere in the style declaration, not only at the end
https://bugs.webkit.org/show_bug.cgi?id=79662

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleDeclaration.prototype.newBlankProperty):
(WebInspector.CSSProperty.prototype.setText):
(WebInspector.CSSProperty.prototype.setValue):

  • inspector/front-end/MetricsSidebarPane.js:

(WebInspector.MetricsSidebarPane.prototype._applyUserInput):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection):
(WebInspector.StylePropertiesSection.prototype._handleSelectorContainerClick):
(WebInspector.StylePropertiesSection.prototype.addNewBlankProperty):
(WebInspector.StylePropertyTreeElement.prototype):
(WebInspector.StylePropertyTreeElement.prototype.element.userInput.previousContent.context.moveDirection):
(WebInspector.StylePropertyTreeElement.prototype.styleText.updateInterface.majorChange.isRevert):

LayoutTests:

  • inspector/styles/styles-add-blank-property-expected.txt:
  • inspector/styles/styles-add-blank-property.html:
  • inspector/styles/styles-formatting.html:
  • inspector/styles/styles-history.html:
  • inspector/styles/undo-add-property-expected.txt:
  • inspector/styles/undo-add-property.html:
8:34 AM SettingUpDevelopmentEnvironmentForN9 edited by zarvai@inf.u-szeged.hu
(diff)
7:49 AM Changeset in webkit [108994] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed fix for lint error after r108992.

  • platform/chromium/test_expectations.txt:
7:22 AM Changeset in webkit [108993] by pfeldman@chromium.org
  • 15 edits in trunk

Source/WebCore: [Shadow]: Expose one ShadowRoot in the Elements panel (under experiment flag)
https://bugs.webkit.org/show_bug.cgi?id=78202

Reviewed by Yury Semikhatsky.

  • dom/ShadowTree.cpp:

(WebCore::ShadowTree::pushShadowRoot):
(WebCore::ShadowTree::popShadowRoot):

  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::unbind):
(WebCore::InspectorDOMAgent::assertEditableNode):
(WebCore::InspectorDOMAgent::assertEditableElement):
(WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
(WebCore::InspectorDOMAgent::setAttributeValue):
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::removeAttribute):
(WebCore::InspectorDOMAgent::removeNode):
(WebCore::InspectorDOMAgent::setOuterHTML):
(WebCore::InspectorDOMAgent::setNodeValue):
(WebCore::InspectorDOMAgent::moveTo):
(WebCore::InspectorDOMAgent::buildObjectForNode):
(WebCore::InspectorDOMAgent::didPushShadowRoot):
(WebCore):
(WebCore::InspectorDOMAgent::willPopShadowRoot):

  • inspector/InspectorDOMAgent.h:

(WebCore):
(InspectorDOMAgent):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didPushShadowRootImpl):
(WebCore):
(WebCore::InspectorInstrumentation::willPopShadowRootImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didPushShadowRoot):
(WebCore::InspectorInstrumentation::willPopShadowRoot):

  • inspector/PageConsoleAgent.cpp:

(WebCore::PageConsoleAgent::addInspectedNode):

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode):
(WebInspector.DOMNode.prototype.hasChildNodes):
(WebInspector.DOMNode.prototype.isInShadowTree):
(WebInspector.DOMNode.prototype._insertChild):
(WebInspector.DOMNode.prototype._setChildrenPayload):
(WebInspector.DOMDocument):
(WebInspector.DOMAgent.prototype._setDetachedRoot):
(WebInspector.DOMAgent.prototype._shadowRootPopped):
(WebInspector.DOMDispatcher.prototype.childNodeRemoved):
(WebInspector.DOMDispatcher.prototype.shadowRootPushed):
(WebInspector.DOMDispatcher.prototype.shadowRootPopped):

  • inspector/front-end/ElementsTreeOutline.js:
  • inspector/front-end/MemoryStatistics.js:
  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/inspector.css:

(.webkit-html-tag.shadow, .webkit-html-fragment.shadow):

LayoutTests: [Shadow]: Expose one ShadowRoot in the Elements panel
https://bugs.webkit.org/show_bug.cgi?id=78202

Reviewed by Yury Semikhatsky.

  • inspector/console/console-dirxml-expected.txt:
7:13 AM Changeset in webkit [108992] by pfeldman@chromium.org
  • 1 edit
    4 deletes in trunk/LayoutTests

Web Inspector: drop protocol-level tests
https://bugs.webkit.org/show_bug.cgi?id=79671

Reviewed by Vsevolod Vlasov.

  • inspector/protocol/console-agent-expected.txt: Removed.
  • inspector/protocol/console-agent.html: Removed.
  • inspector/protocol/runtime-agent-expected.txt: Removed.
  • inspector/protocol/runtime-agent.html: Removed.
7:07 AM Changeset in webkit [108991] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/efl

[EFL] Pairing up between evas_object_image_data_get and evas_object_image_data_set.
https://bugs.webkit.org/show_bug.cgi?id=79031

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2012-02-27
Reviewed by Zoltan Herczeg.

  • Get the pixel data when the cairo surface is created.
  • evas_object_image_data_get increases the reference count and returns the image buffer pointer.

evas_object_image_data_set decreases the reference count and when the ref count become zero,
the function releases the cached image inside evas engine.
We should make a pair between evas_object_image_data_set/get to return evas resource.

  • ewk/ewk_tiled_backing_store.h:

(_Ewk_Tile):

  • ewk/ewk_tiled_model.cpp:

(tile_account):
(ewk_tile_new):

  • ewk/ewk_view_tiled.cpp:

(_ewk_view_tiled_render_cb):

7:05 AM Changeset in webkit [108990] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [refactoring] remove dependencies from TimelinePanel from most of FormattedRecord
https://bugs.webkit.org/show_bug.cgi?id=79665

Reviewed by Pavel Feldman.

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyLocation):
(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyCallFrame):
(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyTopCallFrame):
(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyScriptLocation):
(WebInspector.TimelinePanel.PopupContentHelper):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):

6:56 AM Changeset in webkit [108989] by yurys@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: reveal corresponding timeline record when user clicks on memory graph
https://bugs.webkit.org/show_bug.cgi?id=79669

When user clicks on DOM counter graph corresponding timeline record is
revealed in timelime grid and all its ancestors are expanded.

Reviewed by Pavel Feldman.

  • inspector/front-end/MemoryStatistics.js:

(WebInspector.MemoryStatistics.prototype._onClick):

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane.prototype.update):
(WebInspector.HeapGraph.prototype.update):
(WebInspector.HeapGraph.prototype._clear):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype.revealRecordAt.recordFinder):
(WebInspector.TimelinePanel.prototype.revealRecordAt):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelinePanel.forAllRecords):
(WebInspector.TimelinePanel.FormattedRecord.prototype.containsTime):

6:46 AM QtWebKitBugs edited by Csaba Osztrogonác
Add the meta bug to fix crashes/assertions/timeouts (diff)
6:43 AM Changeset in webkit [108988] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed single line fix for r108983.

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype.willHide):

6:41 AM QtWebKitBugs edited by Csaba Osztrogonác
Add the meta bug to fix regressions cause layout test failures (diff)
5:47 AM Changeset in webkit [108987] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: repaint counter graphs when timeline splitter moves
https://bugs.webkit.org/show_bug.cgi?id=79644

Immediately refresh timeline panel on splitter move.

Reviewed by Pavel Feldman.

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._splitterDragging):

5:14 AM Changeset in webkit [108986] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Skip one more crashing test.

  • platform/qt-5.0-wk2/Skipped:
4:28 AM Changeset in webkit [108985] by Carlos Garcia Campos
  • 7 edits in trunk

Unreviewed. Fix make distcheck.

Source/JavaScriptCore:

  • GNUmakefile.list.am: Add missing files.

Source/WebCore:

  • GNUmakefile.am: Add missing files.
  • GNUmakefile.list.am: Ditto.

Tools:

  • GNUmakefile.am: Fix typo.
4:04 AM Changeset in webkit [108984] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

[CMake] Build fix after r108709.

  • CMakeLists.txt: Move DOMWindowSVG.idl to the other IDL files.
3:56 AM Changeset in webkit [108983] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [chromium] Profiles - Tooltip with object/property types stays on screen when another tab selected
https://bugs.webkit.org/show_bug.cgi?id=79654

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype.willHide):

3:38 AM Changeset in webkit [108982] by vestbo@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Remove page/PageSupplement.h from WebCore's Target.pri

The file itself was removed in r108958.

Reviewed by Kenneth Rohde Christiansen.

3:30 AM Changeset in webkit [108981] by vestbo@webkit.org
  • 8 edits in trunk

[Qt] Use USE() macro instead of ENABLE() for using the Qt image decoder

Reviewed by Kenneth Rohde Christiansen.

3:13 AM Changeset in webkit [108980] by morrita@google.com
  • 7 edits
    2 adds in trunk

Source/WebCore: Removing <ul>, <li> inside shadow DOM triggers assertion in updateListMarkerNumbers
https://bugs.webkit.org/show_bug.cgi?id=79630

Reviewed by Ryosuke Niwa.

This problem was caused by the inconsistent detach order of DOM tree where
Element::detach() called ContainerNode::detach() before shadow tree is detached.
This resulted the renderer of the element being destroyed even if its children,
each of which came from an element in the shadow tree, are alive.
In principle, child renderers should be destroyed before its parent.

This change aligns the detach order with the attach order. The shadow tree is
now deatched before parent's ContainerNode::detach() is called.

Test: fast/dom/shadow/shadow-ul-li.html

  • dom/Element.cpp:

(WebCore::Element::detach):

LayoutTests: Removing <ul>, <li> inside shadow DOM triggers assertion in updateListMarkerNumbers
https://bugs.webkit.org/show_bug.cgi?id=72440

Reviewed by Ryosuke Niwa.

  • fast/dom/shadow/shadow-ul-li-expected.txt: Added.
  • fast/dom/shadow/shadow-ul-li.html: Added.
  • fast/dom/shadow/shadow-ul-li.html:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wk2/Skipped:
3:05 AM Changeset in webkit [108979] by Csaba Osztrogonác
  • 4 edits in trunk/LayoutTests

Unreviewed gardening.

  • platform/qt-5.0-wk1/Skipped: Skip a new timeouting test.
  • platform/qt-5.0-wk2/Skipped: Skip a new _crashing_ test.
  • platform/wk2/Skipped: Unskip non-existning tests, rename entries as real files renamed before.
2:42 AM Changeset in webkit [108978] by bashi@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update.

Following tests are flaky:

  • compositing/reflections/remove-add-reflection.html
  • compositing/reflections/nested-reflection-transition.html
  • platform/chromium/test_expectations.txt:
2:27 AM Changeset in webkit [108977] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, try to skip previous tests to avoid crashes.

  • platform/qt/Skipped:
2:23 AM Changeset in webkit [108976] by keishi@webkit.org
  • 14 edits
    2 copies in trunk/Source/WebCore

Color input type should be clickable through keyboard
https://bugs.webkit.org/show_bug.cgi?id=79629

Reviewed by Kent Tamura.

Introduced BaseClickableWithKeyInputType that represents an input type
that can be clicked by pressing space/return keys.
ColorInputType, FileInputType directly inherit it because it doesn't
want the other methods(like appendFormData) in BaseButtonInputType.

  • CMakeLists.txt: Added BaseClickableWithKeyInputType.cpp
  • GNUmakefile.list.am: Added BaseClickableWithKeyInputType.{cpp,h}
  • Target.pri: Added BaseClickableWithKeyInputType.{cpp,h}
  • WebCore.gypi: Added BaseClickableWithKeyInputType.{cpp,h}
  • WebCore.vcproj/WebCore.vcproj: Added BaseClickableWithKeyInputType.{cpp,h}
  • WebCore.xcodeproj/project.pbxproj: Added BaseClickableWithKeyInputType.{cpp,h}
  • html/BaseButtonInputType.cpp:
  • html/BaseButtonInputType.h:

(WebCore::BaseButtonInputType::BaseButtonInputType): Inherits BaseClickableWithKeyInputType now.
(BaseButtonInputType):

  • html/BaseCheckableInputType.cpp: Changed comment.
  • html/BaseClickableWithKeyInputType.cpp:

(WebCore):
(WebCore::BaseClickableWithKeyInputType::handleKeydownEvent): Moved from BaseButtonInputType
(WebCore::BaseClickableWithKeyInputType::handleKeypressEvent): Moved from BaseButtonInputType
(WebCore::BaseClickableWithKeyInputType::handleKeyupEvent): Moved from BaseButtonInputType
(WebCore::BaseClickableWithKeyInputType::accessKeyAction): Moved from BaseButtonInputType

  • html/BaseClickableWithKeyInputType.h:

(WebCore):
(BaseClickableWithKeyInputType): Input type that can be clicked by pressing space/return keys.
(WebCore::BaseClickableWithKeyInputType::BaseClickableWithKeyInputType):

  • html/ColorInputType.h:

(WebCore::ColorInputType::ColorInputType): Inherits BaseClickableWithKeyInputType now.

  • html/FileInputType.cpp:

(WebCore::FileInputType::FileInputType):

  • html/FileInputType.h:

(FileInputType): Inherits BaseClickableWithKeyInputType now.

  • html/RangeInputType.cpp: Changed comment.

(WebCore):

2:21 AM Changeset in webkit [108975] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

Add missing include to ColorInputType.cpp
https://bugs.webkit.org/show_bug.cgi?id=79632

Reviewed by Kent Tamura.

  • html/ColorInputType.cpp: Include ShadowTree.h
2:19 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
Ad windowed plugins task (diff)
2:06 AM Changeset in webkit [108974] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

Add a ChromiumGpuAndroid port.
https://bugs.webkit.org/show_bug.cgi?id=79628

Patch by Hao Zheng <zhenghao@chromium.org> on 2012-02-27
Reviewed by Adam Barth.

Android does have a gpu port, so revert r107697.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.init):

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

(ChromiumGpuAndroidPort):
(ChromiumGpuAndroidPort.init):
(ChromiumGpuAndroidPort.baseline_search_path):
(ChromiumGpuAndroidPort.default_child_processes):
(ChromiumGpuAndroidPort.tests):

  • Scripts/webkitpy/layout_tests/port/factory.py:

(PortFactory):

2:01 AM Changeset in webkit [108973] by bashi@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update.

Following tests are flaky:

  • compositing/reflections/reflection-ordering.html
  • compositing/reflections/reflection-positioning.html
  • compositing/reflections/nested-reflection-transformed.html
  • compositing/reflections/nested-reflection-transformed2.html
  • platform/chromium/test_expectations.txt:
1:44 AM Changeset in webkit [108972] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Use built-in bind in ExtensionAPI.js

Web Inspector: [Extensions API] get rid of custom bind() in favor of built-in
https://bugs.webkit.org/show_bug.cgi?id=79570

Reviewed by Pavel Feldman.

  • inspector/front-end/ExtensionAPI.js:

(injectedExtensionAPI.EventSinkImpl.prototype.addListener):
(injectedExtensionAPI):
(injectedExtensionAPI.Panels.prototype.create):
(injectedExtensionAPI.AuditResultImpl):
(injectedExtensionAPI.ExtensionServerClient):

1:27 AM Changeset in webkit [108971] by podivilov@chromium.org
  • 12 edits in trunk

Web Inspector: get rid of RawSourceCode.sourceMapping getter.
https://bugs.webkit.org/show_bug.cgi?id=79461

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype.uiSourceCodeAdded):
(WebInspector.BreakpointManager.prototype.setBreakpoint):
(WebInspector.BreakpointManager.prototype._materializeBreakpoint):
(WebInspector.BreakpointManager.prototype._breakpointDebuggerLocationChanged):

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype.get location):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.rawLocationToUILocation):
(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):
(WebInspector.DebuggerPresentationModel.prototype._handleUISourceCodeListChanged):
(WebInspector.DebuggerPresentationModel.prototype._uiSourceCodeListChanged):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype._restoreConsoleMessages):
(WebInspector.DebuggerPresentationModel.prototype._restoreExecutionLine):
(WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):
(WebInspector.DebuggerPresentationModel.prototype.continueToLine):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.PresentationCallFrame.prototype.uiLocation):
(WebInspector.DebuggerPresentationModel.CallFramePlacard):
(WebInspector.DebuggerPresentationModel.CallFramePlacard.prototype.discard):
(WebInspector.DebuggerPresentationModel.CallFramePlacard.prototype._update):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.setContent):
(WebInspector.DebuggerPresentationModel.DefaultLinkifierFormatter.prototype.formatRawSourceCodeAnchor):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyRawSourceCode):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.reset):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor):

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.prototype.uiSourceCodeList):
(WebInspector.RawSourceCode.prototype._saveSourceMapping):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._updateCallFrame):

  • inspector/front-end/ScriptsSearchScope.js:

(WebInspector.ScriptsSearchResultsPane.prototype.createAnchor):

LayoutTests:

  • inspector/debugger/breakpoint-manager.html:
  • inspector/debugger/callstack-placards-discarded-expected.txt:
  • inspector/debugger/callstack-placards-discarded.html:
  • inspector/debugger/raw-source-code.html:
1:21 AM Changeset in webkit [108970] by mihnea@adobe.com
  • 17 edits
    2 copies
    12 adds in trunk

[CSSRegions]Implement NamedFlow::getRegionsByContentNode
https://bugs.webkit.org/show_bug.cgi?id=77746

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/regions/get-regions-by-content-node-horiz-bt.html

fast/regions/get-regions-by-content-node-horiz-tb.html
fast/regions/get-regions-by-content-node-vert-lr.html
fast/regions/get-regions-by-content-node-vert-rl.html
fast/regions/get-regions-by-content-node.html
fast/regions/get-regions-by-content-node2.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Node.cpp:

(WebCore::Node::removeCachedRegionNodeList):
(WebCore):
(WebCore::Node::getRegionsByContentNode):
(WebCore::NodeListsNodeData::invalidateCaches):
(WebCore::NodeListsNodeData::isEmpty):

  • dom/Node.h:

(WebCore):
(Node):

  • dom/NodeRareData.h:

(NodeListsNodeData):

  • dom/RegionNodeList.cpp:

(WebCore):
(WebCore::RegionNodeList::RegionNodeList):
(WebCore::RegionNodeList::~RegionNodeList):
(WebCore::RegionNodeList::nodeMatches):

  • dom/RegionNodeList.h:

(WebCore):
(RegionNodeList):
(WebCore::RegionNodeList::create):

  • dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::getRegionsByContentNode):
(WebCore):

  • dom/WebKitNamedFlow.h:

(WebCore):
(WebKitNamedFlow):

  • dom/WebKitNamedFlow.idl:
  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::regionInRange):
(WebCore):
(WebCore::RenderFlowThread::objectInFlowRegion):

  • rendering/RenderFlowThread.h:
  • rendering/RenderRegion.h:

(WebCore::RenderRegion::flowThread):

LayoutTests:

  • fast/regions/get-regions-by-content-node-expected.txt: Added.
  • fast/regions/get-regions-by-content-node-horiz-bt-expected.txt: Added.
  • fast/regions/get-regions-by-content-node-horiz-bt.html: Added.
  • fast/regions/get-regions-by-content-node-horiz-tb-expected.txt: Added.
  • fast/regions/get-regions-by-content-node-horiz-tb.html: Added.
  • fast/regions/get-regions-by-content-node-vert-lr-expected.txt: Added.
  • fast/regions/get-regions-by-content-node-vert-lr.html: Added.
  • fast/regions/get-regions-by-content-node-vert-rl-expected.txt: Added.
  • fast/regions/get-regions-by-content-node-vert-rl.html: Added.
  • fast/regions/get-regions-by-content-node.html: Added.
  • fast/regions/get-regions-by-content-node2-expected.txt: Added.
  • fast/regions/get-regions-by-content-node2.html: Added.
1:16 AM Changeset in webkit [108969] by bashi@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectaion update.

  • platform/chromium/test_expectations.txt: Changed expectation for http/tests/xmlhttprequest/xmlhttprequest-no-content-length-onProgress.html.
1:08 AM Changeset in webkit [108968] by bashi@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=79642

Following tests time out:

  • accessibility/aria-describedby-on-input.html
  • fast/loader/subresource-willSendRequest-null.html
  • http/tests/xmlhttprequest/xmlhttprequest-test-send-flag.html
  • media/video-playbackrate.html
  • platform/chromium/test_expectations.txt:
1:00 AM Changeset in webkit [108967] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: counter graphs should resize after console showing
https://bugs.webkit.org/show_bug.cgi?id=79640

Invoke Panel.doResize after showing drawer.

Reviewed by Pavel Feldman.

  • inspector/front-end/Drawer.js:

(WebInspector.Drawer.prototype.show.animationFinished):
(WebInspector.Drawer.prototype.show):

12:51 AM Changeset in webkit [108966] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Close TabbedPanes on middle click of tab handle
https://bugs.webkit.org/show_bug.cgi?id=79518

Patch by Dan Beam <dbeam@chromium.org> on 2012-02-27
Reviewed by Pavel Feldman.

  • inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPaneTab.prototype._createTabElement):
(WebInspector.TabbedPaneTab.prototype._tabClicked):

12:42 AM Changeset in webkit [108965] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: crash in fake workers
https://bugs.webkit.org/show_bug.cgi?id=79637

Notify front-end about worker creation/destruction synchronously instead of
posting a task.

Reviewed by Pavel Feldman.

  • inspector/InspectorAgent.cpp:

(WebCore):
(WebCore::InspectorAgent::didCreateWorker):
(WebCore::InspectorAgent::didDestroyWorker):

  • inspector/InspectorAgent.h:

(InspectorAgent):

12:40 AM Changeset in webkit [108964] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip the following crashing svg test.

  • platform/qt/Skipped:
12:38 AM WebKitGTK/WebKit2Roadmap edited by Philippe Normand
(diff)
12:27 AM Changeset in webkit [108963] by leo.yang@torchmobile.com.cn
  • 1 edit
    2 adds in trunk/Source/WebKit/blackberry

[BlackBerry] Upstream accelerated compositing helper class
https://bugs.webkit.org/show_bug.cgi?id=78448

Reviewed by Antonio Gomes.

Initial upstream, no new tests.

  • WebKitSupport/FrameLayers.cpp: Added.
  • WebKitSupport/FrameLayers.h: Added.

Feb 26, 2012:

11:50 PM Changeset in webkit [108962] by Csaba Osztrogonác
  • 4 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip new failing and crashing tests to paint the bots green.

  • platform/qt-5.0/Skipped:
  • platform/qt-mac/Skipped:
  • platform/qt/Skipped:
11:47 PM Changeset in webkit [108961] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[EFL][WK2] Add InjectedBundleEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=75463

Patch by YoungTaeck Song <youngtaeck.song@samsung.com> on 2012-02-26
Reviewed by Andreas Kling.

Add first version of InjectedBundleEfl.cpp including load() and placeholder for activateMacFontAscentHack().

  • WebProcess/InjectedBundle/InjectedBundle.h:
  • WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp:

(WebKit::InjectedBundle::load):
(WebKit::InjectedBundle::activateMacFontAscentHack):

10:54 PM Changeset in webkit [108960] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed.

Fix some warnings in the build from referencing the non-existent
websockets directory.

  • WebCore.gyp/WebCore.gyp:
10:50 PM Changeset in webkit [108959] by shinyak@chromium.org
  • 40 edits
    2 moves in trunk

Rename ShadowRootList to ShadowTree.
https://bugs.webkit.org/show_bug.cgi?id=79342

Reviewed by Hajime Morita.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

This patch renames ShadowRootList ot ShadowTree.

No new tests, no change in behavior.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/Document.cpp:

(WebCore::Document::buildAccessKeyMap):

  • dom/Element.cpp:

(WebCore::Element::willRemove):
(WebCore::Element::insertedIntoDocument):
(WebCore::Element::removedFromDocument):
(WebCore::Element::insertedIntoTree):
(WebCore::Element::removedFromTree):
(WebCore::Element::attach):
(WebCore::Element::detach):
(WebCore::Element::recalcStyle):
(WebCore::Element::hasShadowRoot):
(WebCore::Element::shadowTree):
(WebCore::Element::setShadowRoot):
(WebCore::Element::ensureShadowRoot):
(WebCore::Element::removeShadowRoot):
(WebCore::Element::childrenChanged):

  • dom/Element.h:

(WebCore):
(Element):

  • dom/ElementRareData.h:

(ElementRareData):
(WebCore::ElementRareData::~ElementRareData):

  • dom/Node.cpp:

(WebCore::oldestShadowRoot):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::NodeRenderingContext::hostChildrenChanged):
(WebCore::NodeRenderingContext::shouldCreateRenderer):

  • dom/NodeRenderingContext.h:

(WebCore):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::tree):
(WebCore::ShadowRoot::attach):

  • dom/ShadowRoot.h:

(WebCore):
(ShadowRoot):

  • dom/ShadowTree.cpp: Renamed from Source/WebCore/dom/ShadowRootList.cpp.

(WebCore):
(WebCore::ShadowTree::ShadowTree):
(WebCore::ShadowTree::~ShadowTree):
(WebCore::ShadowTree::pushShadowRoot):
(WebCore::ShadowTree::popShadowRoot):
(WebCore::ShadowTree::insertedIntoDocument):
(WebCore::ShadowTree::removedFromDocument):
(WebCore::ShadowTree::insertedIntoTree):
(WebCore::ShadowTree::removedFromTree):
(WebCore::ShadowTree::willRemove):
(WebCore::ShadowTree::attach):
(WebCore::ShadowTree::detach):
(WebCore::ShadowTree::insertionPointFor):
(WebCore::ShadowTree::isSelectorActive):
(WebCore::ShadowTree::reattach):
(WebCore::ShadowTree::childNeedsStyleRecalc):
(WebCore::ShadowTree::needsStyleRecalc):
(WebCore::ShadowTree::recalcShadowTreeStyle):
(WebCore::ShadowTree::needsReattachHostChildrenAndShadow):
(WebCore::ShadowTree::hostChildrenChanged):
(WebCore::ShadowTree::setNeedsReattachHostChildrenAndShadow):
(WebCore::ShadowTree::reattachHostChildrenAndShadow):
(WebCore::ShadowTree::ensureSelector):

  • dom/ShadowTree.h: Renamed from Source/WebCore/dom/ShadowRootList.h.

(WebCore):
(ShadowTree):
(WebCore::ShadowTree::hasShadowRoot):
(WebCore::ShadowTree::youngestShadowRoot):
(WebCore::ShadowTree::oldestShadowRoot):
(WebCore::ShadowTree::selector):
(WebCore::ShadowTree::clearNeedsReattachHostChildrenAndShadow):
(WebCore::ShadowTree::host):

  • dom/TreeScopeAdopter.cpp:

(WebCore::shadowRootFor):

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::createShadowSubtree):
(WebCore::ColorInputType::shadowColorSwatch):

  • html/FileInputType.cpp:

(WebCore::FileInputType::createShadowSubtree):
(WebCore::FileInputType::multipleAttributeChanged):

  • html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::findMainSummary):

  • html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::shadowSelect):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaControls):
(WebCore::HTMLMediaElement::hasMediaControls):

  • html/HTMLSummaryElement.cpp:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::innerTextElement):
(WebCore::HTMLTextAreaElement::updatePlaceholderText):

  • html/InputType.cpp:

(WebCore::InputType::destroyShadowSubtree):

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::handleMouseDownEvent):
(WebCore::RangeInputType::createShadowSubtree):

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::createShadowSubtree):
(WebCore::TextFieldInputType::updatePlaceholderText):

  • html/ValidationMessage.cpp:

(WebCore::ValidationMessage::deleteBubbleTree):

  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::attach):
(WebCore::HTMLContentElement::detach):
(WebCore::HTMLContentElement::parseAttribute):

  • html/shadow/SliderThumbElement.cpp:

(WebCore::sliderThumbElementOf):
(WebCore::RenderSliderContainer::layout):
(WebCore::trackLimiterElementOf):

  • page/FocusController.cpp:

(WebCore::shadowRoot):

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::uploadButton):

  • svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::updateReferencedText):
(WebCore::SVGTRefElement::detachTarget):

  • testing/Internals.cpp:

(WebCore::Internals::ensureShadowRoot):
(WebCore::Internals::youngestShadowRoot):
(WebCore::Internals::oldestShadowRoot):

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
10:33 PM Changeset in webkit [108958] by abarth@webkit.org
  • 30 edits
    1 add
    4 deletes in trunk/Source/WebCore

Extract Supplementable base class from Page and Navigator
https://bugs.webkit.org/show_bug.cgi?id=79624

Reviewed by Hajime Morita.

We'll use this pattern again soon for ScriptExecutionContext.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/gamepad/NavigatorGamepad.cpp:

(WebCore::NavigatorGamepad::from):

  • Modules/gamepad/NavigatorGamepad.h:
  • Modules/geolocation/NavigatorGeolocation.cpp:

(WebCore::NavigatorGeolocation::from):

  • Modules/geolocation/NavigatorGeolocation.h:
  • Modules/mediastream/NavigatorMediaStream.cpp:

(WebCore::NavigatorMediaStream::webkitGetUserMedia):

  • Modules/mediastream/UserMediaController.cpp:

(WebCore::provideUserMediaTo):

  • Modules/mediastream/UserMediaController.h:

(WebCore::UserMediaController::from):

  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DeviceMotionController.cpp:

(WebCore::provideDeviceMotionTo):

  • dom/DeviceMotionController.h:

(WebCore::DeviceMotionController::from):

  • dom/DeviceOrientationController.cpp:

(WebCore::provideDeviceOrientationTo):

  • dom/DeviceOrientationController.h:

(WebCore):
(WebCore::DeviceOrientationController::from):

  • notifications/NotificationController.cpp:

(WebCore::provideNotification):

  • notifications/NotificationController.h:

(WebCore):
(WebCore::NotificationController::from):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::page):
(WebCore):
(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
(WebCore::DOMWindow::removeAllEventListeners):

  • page/DOMWindow.h:

(WebCore):
(DOMWindow):

  • page/Navigator.cpp:

(WebCore):

  • page/Navigator.h:

(Navigator):

  • page/NavigatorSupplement.cpp: Removed.
  • page/NavigatorSupplement.h: Removed.
  • page/Page.cpp:

(WebCore):

  • page/Page.h:

(Page):

  • page/PageSupplement.cpp: Removed.
  • page/PageSupplement.h: Removed.
  • page/SpeechInput.cpp:

(WebCore::provideSpeechInputTo):

  • page/SpeechInput.h:

(WebCore::SpeechInput::from):

  • platform/Supplementable.h: Added.

(WebCore):
(Supplement):
(WebCore::Supplement::~Supplement):
(WebCore::Supplement::provideTo):
(WebCore::Supplement::from):
(Supplementable):
(WebCore::Supplementable::provideSupplement):
(WebCore::Supplementable::requireSupplement):

10:31 PM Changeset in webkit [108957] by commit-queue@webkit.org
  • 39 edits in trunk/Source

Move ChromeClient::showContextMenu() to ContextMenuClient
https://bugs.webkit.org/show_bug.cgi?id=79427

Patch by Hajime Morrita <morrita@chromium.org> on 2012-02-26
Reviewed by Adam Barth.

Source/JavaScriptCore:

Added ACCESSIBILITY_CONTEXT_MENUS.

  • wtf/Platform.h:

Source/WebCore:

  • Removed ChromeClient::showContextMenu(), Chrome::showContextMenu()
  • Added ContextMenuController::showContextMenuAt(), ContextMenuClient::showContextMenu()
  • Hided showContextMenu() behind ACCESSIBILITY_CONTEXT_MENUS

This change localizes context menu related code and will make it easy to
modularize CONTEXT_MENUS code.

Refactoring. No new tests.

  • WebCore.exp.in:
  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityShowContextMenu]):

  • loader/EmptyClients.h:

(EmptyContextMenuClient):
(WebCore::EmptyContextMenuClient::showContextMenu):

  • page/ContextMenuClient.h:

(ContextMenuClient):

  • page/ContextMenuController.cpp:

(WebCore):
(WebCore::ContextMenuController::showContextMenuAt):

  • page/ContextMenuController.h:

(ContextMenuController):

  • page/Chrome.cpp:
  • page/Chrome.h:

(Chrome):

  • page/ChromeClient.h:

(ChromeClient):

Source/WebKit/blackberry:

  • WebCoreSupport/ChromeClientBlackBerry.h:

(ChromeClientBlackBerry):

Source/WebKit/chromium:

  • src/ChromeClientImpl.h:

(ChromeClientImpl):

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.h:

(ChromeClientEfl):

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.h:

(ChromeClient):

Source/WebKit/mac:

  • WebCoreSupport/WebContextMenuClient.h:

(WebContextMenuClient):

  • WebCoreSupport/WebContextMenuClient.mm:

(WebContextMenuClient::showContextMenu): Moved from WebChromeClient

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

Source/WebKit/qt:

  • WebCoreSupport/ChromeClientQt.h:

(ChromeClientQt):

Source/WebKit/win:

  • WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

Source/WebKit/wince:

  • WebCoreSupport/ChromeClientWinCE.h:

(ChromeClientWinCE):

Source/WebKit/wx:

  • WebKitSupport/ChromeClientWx.h:

(ChromeClientWx):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:

(WebKit):
(WebKit::WebContextMenuClient::showContextMenu): Moved from WebChromeClient

  • WebProcess/WebCoreSupport/WebContextMenuClient.h:

(WebContextMenuClient):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::handleContextMenuEvent):
(WebKit::handleMouseEvent):
(WebKit::WebPage::mouseEvent):
(WebKit::WebPage::mouseEventSyncForTesting):

10:27 PM Changeset in webkit [108956] by benjamin@webkit.org
  • 2 edits
    1 add
    1 delete in trunk/Source/WebCore

[Mac] Release localized Strings instead of AutoRelease
https://bugs.webkit.org/show_bug.cgi?id=79552

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-02-26
Reviewed by Sam Weinig.

By using the CoreFoundation API, we can release the memory as soon as
the WTF::String is created.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/LocalizedStringsMac.cpp: Renamed from Source/WebCore/platform/mac/LocalizedStringsMac.mm.

(WebCore):
(WebCore::localizedString):

9:27 PM Changeset in webkit [108955] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

LayoutTests/fast/forms/number/input-number-events.html is failing since r108228
https://bugs.webkit.org/show_bug.cgi?id=79329

Update input-number-events.html test for r108228. Spin buttons of number input field
fire both input and change events.

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-02-26
Reviewed by Kent Tamura.

  • fast/forms/number/input-number-events-expected.txt: We get one change event from spin button click.
  • fast/forms/number/input-number-events.html: Change to one for change event.
9:10 PM Changeset in webkit [108954] by abarth@webkit.org
  • 10 edits
    2 adds in trunk/Source/WebCore

ContextDestructionObserver should live in its own file
https://bugs.webkit.org/show_bug.cgi?id=79619

Reviewed by Hajime Morita.

WebKit prefers to have one class per file. (This patch is paying a
build system hacking debt I incurred earlier.)

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ActiveDOMObject.cpp:

(WebCore):

  • dom/ActiveDOMObject.h:

(ActiveDOMObject):
(WebCore::ActiveDOMObject::suspendIfNeededCalled):
(WebCore::ActiveDOMObject::setPendingActivity):
(WebCore::ActiveDOMObject::unsetPendingActivity):

  • dom/ContextDestructionObserver.cpp: Added.

(WebCore):
(WebCore::ContextDestructionObserver::ContextDestructionObserver):
(WebCore::ContextDestructionObserver::~ContextDestructionObserver):
(WebCore::ContextDestructionObserver::contextDestroyed):

  • dom/ContextDestructionObserver.h: Added.

(WebCore):
(ContextDestructionObserver):
(WebCore::ContextDestructionObserver::scriptExecutionContext):

  • dom/DOMAllInOne.cpp:
9:05 PM Changeset in webkit [108953] by commit-queue@webkit.org
  • 2 edits in trunk

Update .gitignore for project property files generated by Eclipse.
https://bugs.webkit.org/show_bug.cgi?id=79463

Patch by Chang Wan Hong <jourmoon@company100.net> on 2012-02-26
Reviewed by Andreas Kling.

  • .gitignore: Ignore .project and .cproject
8:16 PM Changeset in webkit [108952] by krit@webkit.org
  • 36 edits in trunk/Source/WebCore

2012-02-26 Dirk Schulze <krit@webkit.org>

Cleanup of Adobes copyright text. The text got harmonized with copyright texts of other companies.

Rubber stamped by Adam Barth.

  • css/CSSWrapShapes.cpp:
  • css/CSSWrapShapes.h:
  • css/WebKitCSSRegionRule.cpp:
  • css/WebKitCSSRegionRule.h:
  • css/WebKitCSSRegionRule.idl:
  • css/WebKitCSSShaderValue.cpp:
  • css/WebKitCSSShaderValue.h:
  • dom/WebKitNamedFlow.cpp:
  • dom/WebKitNamedFlow.h:
  • dom/WebKitNamedFlow.idl:
  • loader/cache/CachedShader.cpp:
  • loader/cache/CachedShader.h:
  • platform/graphics/filters/CustomFilterMesh.cpp:
  • platform/graphics/filters/CustomFilterMesh.h:
  • platform/graphics/filters/CustomFilterNumberParameter.h:
  • platform/graphics/filters/CustomFilterOperation.cpp:
  • platform/graphics/filters/CustomFilterOperation.h:
  • platform/graphics/filters/CustomFilterParameter.h:
  • platform/graphics/filters/CustomFilterProgram.cpp:
  • platform/graphics/filters/CustomFilterProgram.h:
  • platform/graphics/filters/CustomFilterProgramClient.h:
  • platform/graphics/filters/CustomFilterShader.cpp:
  • platform/graphics/filters/CustomFilterShader.h:
  • platform/graphics/filters/FECustomFilter.cpp:
  • platform/graphics/filters/FECustomFilter.h:
  • rendering/FilterEffectObserver.h:
  • rendering/RenderFlowThread.cpp:
  • rendering/RenderFlowThread.h:
  • rendering/RenderRegion.cpp:
  • rendering/RenderRegion.h:
  • rendering/style/StyleCachedShader.cpp:
  • rendering/style/StyleCachedShader.h:
  • rendering/style/StyleCustomFilterProgram.h:
  • rendering/style/StylePendingShader.h:
  • rendering/style/StyleShader.h:
8:13 PM Changeset in webkit [108951] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Use Functional instead of a MessageQueue for messages to the LayerTreeHostProxy
renderer.
https://bugs.webkit.org/show_bug.cgi?id=79478

This makes a lot of the broilerplate code for message-passing unnecessary, and
results in a much more succinct implementation.

Patch by Huang Dongsung <luxtella@company100.net> on 2012-02-26
Reviewed by Noam Rosenthal.

  • UIProcess/LayerTreeHostProxy.h:

(WebKit):
(LayerTreeHostProxy):

  • UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit):
(WebKit::LayerTreeHostProxy::updateTile):
(WebKit::LayerTreeHostProxy::createImage):
(WebKit::LayerTreeHostProxy::syncRemoteContent):
(WebKit::LayerTreeHostProxy::dispatchUpdate):
(WebKit::LayerTreeHostProxy::createTileForLayer):
(WebKit::LayerTreeHostProxy::updateTileForLayer):
(WebKit::LayerTreeHostProxy::removeTileForLayer):
(WebKit::LayerTreeHostProxy::deleteCompositingLayer):
(WebKit::LayerTreeHostProxy::setRootCompositingLayer):
(WebKit::LayerTreeHostProxy::syncCompositingLayerState):
(WebKit::LayerTreeHostProxy::didRenderFrame):
(WebKit::LayerTreeHostProxy::createDirectlyCompositedImage):
(WebKit::LayerTreeHostProxy::destroyDirectlyCompositedImage):

8:07 PM Changeset in webkit [108950] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

LayoutTests/fast/xpath/xpath-functional-test.html is crashing in the DFG
https://bugs.webkit.org/show_bug.cgi?id=79616

Reviewed by Oliver Hunt.

Guard against the fact that in JSVALUE64, JSValue().isCell() == true.

  • dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::validate):

8:05 PM Changeset in webkit [108949] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG should support activations and nested functions
https://bugs.webkit.org/show_bug.cgi?id=79554

Reviewed by Sam Weinig.

Fix 32-bit. The 32-bit function+activation code had some really weird
register reuse bugs.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

8:02 PM Changeset in webkit [108948] by fpizlo@apple.com
  • 9 edits in trunk/LayoutTests

Unreviewed, update expectation files due to slight changes in the text
of exceptions.

  • sputnik/Conformance/12_Statement/12.1_Block/S12.1_A4_T1-expected.txt:
  • sputnik/Conformance/12_Statement/12.1_Block/S12.1_A4_T2-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8.1_T1-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8.1_T2-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8_T1-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8_T2-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8_T3-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.4_The_for_in_Statement/S12.6.4_A15-expected.txt:
7:50 PM Changeset in webkit [108947] by fpizlo@apple.com
  • 2 edits in trunk/Source/WebKit2

Build fix for SL.

  • Platform/mac/RemoteLayerClient.mm:

(WebKit::RemoteLayerClient::RemoteLayerClient):

7:12 PM Changeset in webkit [108946] by weinig@apple.com
  • 13 edits
    2 copies in trunk/Source/WebKit2

Encapsulate uses of WKSI to setup a remote layer into a new RemoteLayerClient class
https://bugs.webkit.org/show_bug.cgi?id=79612

Reviewed by Anders Carlsson.

  • Platform/mac/RemoteLayerClient.h:
  • Platform/mac/RemoteLayerClient.mm:

(WebKit::RemoteLayerClient::create):
(WebKit::RemoteLayerClient::RemoteLayerClient):
(WebKit::RemoteLayerClient::~RemoteLayerClient):
(WebKit::RemoteLayerClient::clientID):
(WebKit::RemoteLayerClient::invalidate):
New class that encapsulates calls to WKSI WKCARemoteLayerClient*. For platforms
where the use of WKSI is not necessary, due to CARemoteLayerClient being available,
stop using WKSI.

  • PluginProcess/PluginControllerProxy.cpp:
  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/mac/PluginControllerProxyMac.mm:

(WebKit::PluginControllerProxy::platformInitialize):
(WebKit::PluginControllerProxy::platformDestroy):
(WebKit::PluginControllerProxy::remoteLayerClientID):
(WebKit::PluginControllerProxy::platformGeometryDidChange):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.h:
  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:

(WebKit::WebFullScreenManagerMac::setRootFullScreenLayer):
(WebKit::WebFullScreenManagerMac::disposeOfLayerClient):

  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h:

(LayerTreeHostCAMac):

  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:

(WebKit::LayerTreeHostCAMac::platformInitialize):
(WebKit::LayerTreeHostCAMac::invalidate):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
Switch to using RemoteLayerClient.

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):

  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::PluginProcessProxy::platformInitializePluginProcess):
Use CARemoteLayerServer directly if available.

6:57 PM Changeset in webkit [108945] by bashi@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update after r108892.

  • platform/chromium/test_expectations.txt:
6:45 PM Changeset in webkit [108944] by bashi@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update after r108896

  • platform/chromium/test_expectations.txt:
6:07 PM Changeset in webkit [108943] by fpizlo@apple.com
  • 13 edits
    1 add in trunk/Source/JavaScriptCore

Getting the instruction stream for a code block should not require two loads
https://bugs.webkit.org/show_bug.cgi?id=79608

Reviewed by Sam Weinig.

Introduced the RefCountedArray class, which contains a single inline pointer
to a ref-counted non-resizeable vector backing store. This satisfies the
requirements of CodeBlock, which desires the ability to share instruction
streams with other CodeBlocks. It also reduces the number of loads required
for getting the instruction stream by one.

This patch also gets rid of the bytecode discarding logic, since we don't
use it anymore and it's unlikely to ever work right with DFG or LLInt. And
I didn't feel like porting dead code to use RefCountedArray.

  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/CodeBlock.cpp:

(JSC::instructionOffsetForNth):
(JSC::CodeBlock::dump):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::handlerForBytecodeOffset):
(JSC::CodeBlock::lineNumberForBytecodeOffset):
(JSC::CodeBlock::expressionRangeForBytecodeOffset):
(JSC::CodeBlock::shrinkToFit):

  • bytecode/CodeBlock.h:

(CodeBlock):
(JSC::CodeBlock::numberOfInstructions):
(JSC::CodeBlock::instructions):
(JSC::CodeBlock::instructionCount):
(JSC::CodeBlock::valueProfileForBytecodeOffset):
(JSC):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::Label::setLocation):
(JSC):
(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::newLabel):

  • bytecompiler/BytecodeGenerator.h:

(JSC):
(BytecodeGenerator):
(JSC::BytecodeGenerator::instructions):

  • bytecompiler/Label.h:

(JSC::Label::Label):
(Label):

  • dfg/DFGByteCodeCache.h:

(JSC::DFG::ByteCodeCache::~ByteCodeCache):
(JSC::DFG::ByteCodeCache::get):

  • jit/JITExceptions.cpp:

(JSC::genericThrow):

  • llint/LowLevelInterpreter32_64.asm:
  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::codeBlockWithBytecodeFor):
(JSC::FunctionExecutable::produceCodeBlockFor):

  • wtf/RefCountedArray.h: Added.

(WTF):
(RefCountedArray):
(WTF::RefCountedArray::RefCountedArray):
(WTF::RefCountedArray::operator=):
(WTF::RefCountedArray::~RefCountedArray):
(WTF::RefCountedArray::size):
(WTF::RefCountedArray::data):
(WTF::RefCountedArray::begin):
(WTF::RefCountedArray::end):
(WTF::RefCountedArray::at):
(WTF::RefCountedArray::operator[]):
(Header):
(WTF::RefCountedArray::Header::size):
(WTF::RefCountedArray::Header::payload):
(WTF::RefCountedArray::Header::fromPayload):

  • wtf/Platform.h:
5:48 PM Changeset in webkit [108942] by haraken@chromium.org
  • 2 edits in trunk/PerformanceTests

[Performance Tests] [Chromium] Bindings/dom-attributes.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=79593

Reviewed by Adam Barth.

This patch halves the execution time of Bindings/dom-attributes.html
in order to avoid timeout in Chromium. The reason for the timeout is that
V8 DOM bindings are too much slower than JSC bindings.
I am a bit afraid that this patch will reduce the accuracy of the
perf test results, but it would make sense to reduce the execution time
until we fix the performance issue in V8 DOM bindings.

  • Bindings/dom-attributes.html:
5:19 PM Changeset in webkit [108941] by jamesr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

Take 2 build fix.

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::TEST_F):

5:14 PM Changeset in webkit [108940] by noel.gordon@gmail.com
  • 1 edit
    4 deletes in trunk/LayoutTests

[chromium] Update expectations for svg carto.net tests
https://bugs.webkit.org/show_bug.cgi?id=79423

Unreviewed. Optimize svg/carto.net/scrollbar.svg and svg/carto.net/selectionlist.svg
test baselines.

  • platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/carto.net/selectionlist-expected.txt: Removed.
  • platform/chromium-win-xp/svg/carto.net/scrollbar-expected.txt: Removed.
  • platform/chromium-win-xp/svg/carto.net/selectionlist-expected.txt: Removed.
5:12 PM Changeset in webkit [108939] by jamesr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

Compile fix for CCLayerTreeHostImpl test.

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::TEST_F):

5:11 PM Changeset in webkit [108938] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/Source/WebCore

[EFL] Implementation of GraphicsContext3D for EFL port
https://bugs.webkit.org/show_bug.cgi?id=79452

Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2012-02-26
Reviewed by Noam Rosenthal.

Evas_GL is used to do OpenGL rendering on Evas, in which
a structure 'Evas_GL_API' contains all the OpenGL functions.

GraphicsContext3D in EFL port should call OpenGL functions indirectly
through the Evas_GL_API, and not use GraphicsContext3DOpenGL(Common).

So, we use the GraphicsContext3DPrivate to delegate all OpenGL function calls,
and it will be implemented to use Evas_GL (bug 62961).

No new tests. No behavior change.

  • platform/graphics/efl/GraphicsContext3DEfl.cpp: Added.

(WebCore):
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
(WebCore::GraphicsContext3D::platformLayer):
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::isGLES2Compliant):
(WebCore::GraphicsContext3D::activeTexture):
(WebCore::GraphicsContext3D::attachShader):
(WebCore::GraphicsContext3D::bindAttribLocation):
(WebCore::GraphicsContext3D::bindBuffer):
(WebCore::GraphicsContext3D::bindFramebuffer):
(WebCore::GraphicsContext3D::bindRenderbuffer):
(WebCore::GraphicsContext3D::bindTexture):
(WebCore::GraphicsContext3D::blendColor):
(WebCore::GraphicsContext3D::blendEquation):
(WebCore::GraphicsContext3D::blendEquationSeparate):
(WebCore::GraphicsContext3D::blendFunc):
(WebCore::GraphicsContext3D::blendFuncSeparate):
(WebCore::GraphicsContext3D::bufferData):
(WebCore::GraphicsContext3D::bufferSubData):
(WebCore::GraphicsContext3D::checkFramebufferStatus):
(WebCore::GraphicsContext3D::clear):
(WebCore::GraphicsContext3D::clearColor):
(WebCore::GraphicsContext3D::clearDepth):
(WebCore::GraphicsContext3D::clearStencil):
(WebCore::GraphicsContext3D::colorMask):
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::copyTexImage2D):
(WebCore::GraphicsContext3D::copyTexSubImage2D):
(WebCore::GraphicsContext3D::cullFace):
(WebCore::GraphicsContext3D::depthFunc):
(WebCore::GraphicsContext3D::depthMask):
(WebCore::GraphicsContext3D::depthRange):
(WebCore::GraphicsContext3D::detachShader):
(WebCore::GraphicsContext3D::disable):
(WebCore::GraphicsContext3D::disableVertexAttribArray):
(WebCore::GraphicsContext3D::drawArrays):
(WebCore::GraphicsContext3D::drawElements):
(WebCore::GraphicsContext3D::enable):
(WebCore::GraphicsContext3D::enableVertexAttribArray):
(WebCore::GraphicsContext3D::finish):
(WebCore::GraphicsContext3D::flush):
(WebCore::GraphicsContext3D::framebufferRenderbuffer):
(WebCore::GraphicsContext3D::framebufferTexture2D):
(WebCore::GraphicsContext3D::frontFace):
(WebCore::GraphicsContext3D::generateMipmap):
(WebCore::GraphicsContext3D::getActiveAttrib):
(WebCore::GraphicsContext3D::getActiveUniform):
(WebCore::GraphicsContext3D::getAttachedShaders):
(WebCore::GraphicsContext3D::getAttribLocation):
(WebCore::GraphicsContext3D::getBooleanv):
(WebCore::GraphicsContext3D::getBufferParameteriv):
(WebCore::GraphicsContext3D::getContextAttributes):
(WebCore::GraphicsContext3D::getError):
(WebCore::GraphicsContext3D::getFloatv):
(WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv):
(WebCore::GraphicsContext3D::getIntegerv):
(WebCore::GraphicsContext3D::getProgramiv):
(WebCore::GraphicsContext3D::getProgramInfoLog):
(WebCore::GraphicsContext3D::getRenderbufferParameteriv):
(WebCore::GraphicsContext3D::getShaderiv):
(WebCore::GraphicsContext3D::getShaderInfoLog):
(WebCore::GraphicsContext3D::getShaderSource):
(WebCore::GraphicsContext3D::getString):
(WebCore::GraphicsContext3D::getTexParameterfv):
(WebCore::GraphicsContext3D::getTexParameteriv):
(WebCore::GraphicsContext3D::getUniformfv):
(WebCore::GraphicsContext3D::getUniformiv):
(WebCore::GraphicsContext3D::getUniformLocation):
(WebCore::GraphicsContext3D::getVertexAttribfv):
(WebCore::GraphicsContext3D::getVertexAttribiv):
(WebCore::GraphicsContext3D::getVertexAttribOffset):
(WebCore::GraphicsContext3D::hint):
(WebCore::GraphicsContext3D::isBuffer):
(WebCore::GraphicsContext3D::isEnabled):
(WebCore::GraphicsContext3D::isFramebuffer):
(WebCore::GraphicsContext3D::isProgram):
(WebCore::GraphicsContext3D::isRenderbuffer):
(WebCore::GraphicsContext3D::isShader):
(WebCore::GraphicsContext3D::isTexture):
(WebCore::GraphicsContext3D::lineWidth):
(WebCore::GraphicsContext3D::linkProgram):
(WebCore::GraphicsContext3D::pixelStorei):
(WebCore::GraphicsContext3D::polygonOffset):
(WebCore::GraphicsContext3D::readPixels):
(WebCore::GraphicsContext3D::releaseShaderCompiler):
(WebCore::GraphicsContext3D::renderbufferStorage):
(WebCore::GraphicsContext3D::sampleCoverage):
(WebCore::GraphicsContext3D::scissor):
(WebCore::GraphicsContext3D::shaderSource):
(WebCore::GraphicsContext3D::stencilFunc):
(WebCore::GraphicsContext3D::stencilFuncSeparate):
(WebCore::GraphicsContext3D::stencilMask):
(WebCore::GraphicsContext3D::stencilMaskSeparate):
(WebCore::GraphicsContext3D::stencilOp):
(WebCore::GraphicsContext3D::stencilOpSeparate):
(WebCore::GraphicsContext3D::texImage2D):
(WebCore::GraphicsContext3D::texParameterf):
(WebCore::GraphicsContext3D::texParameteri):
(WebCore::GraphicsContext3D::texSubImage2D):
(WebCore::GraphicsContext3D::uniform1f):
(WebCore::GraphicsContext3D::uniform1fv):
(WebCore::GraphicsContext3D::uniform1i):
(WebCore::GraphicsContext3D::uniform1iv):
(WebCore::GraphicsContext3D::uniform2f):
(WebCore::GraphicsContext3D::uniform2fv):
(WebCore::GraphicsContext3D::uniform2i):
(WebCore::GraphicsContext3D::uniform2iv):
(WebCore::GraphicsContext3D::uniform3f):
(WebCore::GraphicsContext3D::uniform3fv):
(WebCore::GraphicsContext3D::uniform3i):
(WebCore::GraphicsContext3D::uniform3iv):
(WebCore::GraphicsContext3D::uniform4f):
(WebCore::GraphicsContext3D::uniform4fv):
(WebCore::GraphicsContext3D::uniform4i):
(WebCore::GraphicsContext3D::uniform4iv):
(WebCore::GraphicsContext3D::uniformMatrix2fv):
(WebCore::GraphicsContext3D::uniformMatrix3fv):
(WebCore::GraphicsContext3D::uniformMatrix4fv):
(WebCore::GraphicsContext3D::useProgram):
(WebCore::GraphicsContext3D::validateProgram):
(WebCore::GraphicsContext3D::vertexAttrib1f):
(WebCore::GraphicsContext3D::vertexAttrib1fv):
(WebCore::GraphicsContext3D::vertexAttrib2f):
(WebCore::GraphicsContext3D::vertexAttrib2fv):
(WebCore::GraphicsContext3D::vertexAttrib3f):
(WebCore::GraphicsContext3D::vertexAttrib3fv):
(WebCore::GraphicsContext3D::vertexAttrib4f):
(WebCore::GraphicsContext3D::vertexAttrib4fv):
(WebCore::GraphicsContext3D::vertexAttribPointer):
(WebCore::GraphicsContext3D::viewport):
(WebCore::GraphicsContext3D::reshape):
(WebCore::GraphicsContext3D::markContextChanged):
(WebCore::GraphicsContext3D::markLayerComposited):
(WebCore::GraphicsContext3D::layerComposited):
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
(WebCore::GraphicsContext3D::paintCompositedResultsToCanvas):
(WebCore::GraphicsContext3D::createBuffer):
(WebCore::GraphicsContext3D::createFramebuffer):
(WebCore::GraphicsContext3D::createProgram):
(WebCore::GraphicsContext3D::createRenderbuffer):
(WebCore::GraphicsContext3D::createShader):
(WebCore::GraphicsContext3D::createTexture):
(WebCore::GraphicsContext3D::deleteBuffer):
(WebCore::GraphicsContext3D::deleteFramebuffer):
(WebCore::GraphicsContext3D::deleteProgram):
(WebCore::GraphicsContext3D::deleteRenderbuffer):
(WebCore::GraphicsContext3D::deleteShader):
(WebCore::GraphicsContext3D::deleteTexture):
(WebCore::GraphicsContext3D::synthesizeGLError):
(WebCore::GraphicsContext3D::getExtensions):
(WebCore::GraphicsContext3D::getInternalFramebufferSize):
(WebCore::GraphicsContext3D::setContextLostCallback):
(WebCore::GraphicsContext3D::getImageData):
(WebCore::GraphicsContext3D::validateAttributes):
(WebCore::GraphicsContext3D::readRenderingResults):
(WebCore::GraphicsContext3D::reshapeFBOs):
(WebCore::GraphicsContext3D::resolveMultisamplingIfNecessary):
(WebCore::GraphicsContext3D::isResourceSafe):

5:04 PM Changeset in webkit [108937] by jamesr@google.com
  • 10 edits in trunk/Source

[chromium] Wire up shouldUpdateScrollPositionOnMainThread and nonFastScrollableRegion to compositor
https://bugs.webkit.org/show_bug.cgi?id=79155

Reviewed by Adam Barth.

Source/WebCore:

This hooks up ScrollingCoordinator::setNonFastScrollableRegion() and
ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread() to the chromium compositor
implementation and implements them on the impl thread.

New compositor behavior is covered by unit tests in LayerChromiumTests and CCLayerTreeHostImplTests. The rest is
just glue code.

  • page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setShouldScrollOnMainThread):
(WebCore):
(WebCore::LayerChromium::setNonFastScrollableRegion):
(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore):
(LayerChromium):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::shouldScrollOnMainThread):
(WebCore::CCLayerImpl::setShouldScrollOnMainThread):
(CCLayerImpl):
(WebCore::CCLayerImpl::nonFastScrollableRegion):
(WebCore::CCLayerImpl::setNonFastScrollableRegion):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::scrollBegin):

Source/WebKit/chromium:

Add new tests for shouldScrollOnMainThread and nonFastScrollableRegion properties.

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::TEST_F):
(WebKit):

  • tests/LayerChromiumTest.cpp:
4:52 PM WebKitEFLLayoutTest edited by gyuyoung.kim@samsung.com
(diff)
4:25 PM Changeset in webkit [108936] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed. Rebaselined run-bindings-tests results.

  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:

(webkit_dom_test_interface_supplemental_method4):

2:51 PM Changeset in webkit [108935] by commit-queue@webkit.org
  • 8 edits in trunk

StringLiteral and NumericLiteral are allowed as ObjectLiteral getter / setter name
https://bugs.webkit.org/show_bug.cgi?id=79571

Patch by Yusuke Suzuki <Yusuke Suzuki> on 2012-02-26
Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createGetterOrSetterProperty):

  • parser/Parser.cpp:

(JSC::::parseProperty):

  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createGetterOrSetterProperty):

LayoutTests:

  • fast/js/property-getters-and-setters-expected.txt:
  • fast/js/script-tests/property-getters-and-setters.js:

(o9.string_appeared_here.7.get string_appeared_here):
(o9.set string_appeared_here):
(get shouldBe):
(o10.string_appeared_here.7.get 42):
(o10.set 42):

  • platform/chromium/fast/js/property-getters-and-setters-expected.txt:
2:41 PM Changeset in webkit [108934] by mhahnenberg@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

Implement fast path for op_new_array in the baseline JIT
https://bugs.webkit.org/show_bug.cgi?id=78612

Reviewed by Filip Pizlo.

heap/CopiedAllocator.h:
(CopiedAllocator): Friended the JIT to allow access to m_currentOffset.

  • heap/CopiedSpace.h:

(CopiedSpace): Friended the JIT to allow access to isOversize.
(JSC::CopiedSpace::allocator):

  • heap/Heap.h:

(JSC::Heap::storageAllocator): Added a getter for the CopiedAllocator class so the JIT
can use it for simple allocation i.e. when we can just bump the offset without having to
do anything else.

  • jit/JIT.cpp:

(JSC::JIT::privateCompileSlowCases): Added new slow case for op_new_array for when
we have to bail out because the fast allocation path fails for whatever reason.

  • jit/JIT.h:

(JIT):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicStorage): Added utility function that allows objects to
allocate generic backing stores. This function is used by emitAllocateJSArray.
(JSC):
(JSC::JIT::emitAllocateJSArray): Added utility function that allows the client to
more easily allocate JSArrays. This function is used by emit_op_new_array and I expect
it will also be used for emit_op_new_array_buffer.

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_new_array): Changed to do inline allocation of JSArrays. Still does
a stub call for oversize arrays.
(JSC):
(JSC::JIT::emitSlow_op_new_array): New slow path that just bails out to a stub call if we
fail in any way on the fast path.

  • runtime/JSArray.cpp:

(JSC):

  • runtime/JSArray.h: Added lots of offset functions for all the fields that we need to

initialize in the JIT.
(ArrayStorage):
(JSC::ArrayStorage::lengthOffset):
(JSC::ArrayStorage::numValuesInVectorOffset):
(JSC::ArrayStorage::allocBaseOffset):
(JSC::ArrayStorage::vectorOffset):
(JSArray):
(JSC::JSArray::sparseValueMapOffset):
(JSC::JSArray::subclassDataOffset):
(JSC::JSArray::indexBiasOffset):
(JSC):
(JSC::JSArray::storageSize): Moved this function from being a static function in the cpp file
to being a static function in the JSArray class. This move allows the JIT to call it to
see what size it should allocate.

10:06 AM Changeset in webkit [108933] by inferno@chromium.org
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r108547.
http://trac.webkit.org/changeset/108547
https://bugs.webkit.org/show_bug.cgi?id=79606

Crashes on ClusterFuzz (Requested by inferno-sec on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-26

Source/WebCore:

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):

LayoutTests:

  • fast/css-generated-content/first-letter-textbox-parent-crash-expected.txt: Removed.
  • fast/css-generated-content/first-letter-textbox-parent-crash.html: Removed.
3:11 AM Changeset in webkit [108932] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Build fix for ENABLE(CLASSIC_INTERPRETER) after r108681.

  • interpreter/Interpreter.cpp:

(JSC::getLineNumberForCallFrame):
(JSC::Interpreter::getStackTrace):

12:55 AM Changeset in webkit [108931] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Build fix for !ENABLE(JIT) after r108681.

  • interpreter/Interpreter.cpp:

(JSC::getLineNumberForCallFrame):

Feb 25, 2012:

11:28 PM Changeset in webkit [108930] by abarth@webkit.org
  • 16 edits
    1 move in trunk

Move websockets to Modules/websockets
https://bugs.webkit.org/show_bug.cgi?id=79598

Reviewed by Eric Seidel.

Nowadays, the only ENABLE(WEB_SOCKETS) ifdef in WebCore proper is in
WebCore::Settings, and that will be removed (soon?) once Apple drops
support for the old WebSockets protocol.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • Modules/websockets: Copied from Source/WebCore/websockets.
  • Target.pri:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.vcproj/copyForwardingHeaders.cmd:
  • WebCore.xcodeproj/project.pbxproj:
  • websockets: Removed.
  • websockets/CloseEvent.h: Removed.
  • websockets/CloseEvent.idl: Removed.
  • websockets/DOMWindowWebSocket.idl: Removed.
  • websockets/ThreadableWebSocketChannel.cpp: Removed.
  • websockets/ThreadableWebSocketChannel.h: Removed.
  • websockets/ThreadableWebSocketChannelClientWrapper.cpp: Removed.
  • websockets/ThreadableWebSocketChannelClientWrapper.h: Removed.
  • websockets/WebSocket.cpp: Removed.
  • websockets/WebSocket.h: Removed.
  • websockets/WebSocket.idl: Removed.
  • websockets/WebSocketChannel.cpp: Removed.
  • websockets/WebSocketChannel.h: Removed.
  • websockets/WebSocketChannelClient.h: Removed.
  • websockets/WebSocketDeflater.cpp: Removed.
  • websockets/WebSocketDeflater.h: Removed.
  • websockets/WebSocketExtensionDispatcher.cpp: Removed.
  • websockets/WebSocketExtensionDispatcher.h: Removed.
  • websockets/WebSocketExtensionProcessor.h: Removed.
  • websockets/WebSocketFrame.h: Removed.
  • websockets/WebSocketHandshake.cpp: Removed.
  • websockets/WebSocketHandshake.h: Removed.
  • websockets/WebSocketHandshakeRequest.cpp: Removed.
  • websockets/WebSocketHandshakeRequest.h: Removed.
  • websockets/WebSocketHandshakeResponse.cpp: Removed.
  • websockets/WebSocketHandshakeResponse.h: Removed.
  • websockets/WorkerThreadableWebSocketChannel.cpp: Removed.
  • websockets/WorkerThreadableWebSocketChannel.h: Removed.
11:05 PM Changeset in webkit [108929] by benjamin@webkit.org
  • 5 edits in trunk/Source/WebCore

Get rid of KURL::deprecatedString()
https://bugs.webkit.org/show_bug.cgi?id=79594

Reviewed by Andreas Kling.

The method KURL::deprecatedString() is unused, remove it from WebCore.

The last reference to the method was removed in r96779.

  • platform/KURL.cpp:

(WebCore):

  • platform/KURL.h:

(KURL):

  • platform/KURLGoogle.cpp:

(WebCore):

  • platform/KURLWTFURL.cpp:

(WebCore):

10:51 PM Changeset in webkit [108928] by benjamin@webkit.org
  • 6 edits in trunk/Source/WebCore

Get rid of copyParsedQueryTo()
https://bugs.webkit.org/show_bug.cgi?id=79590

Reviewed by Andreas Kling.

The function KURL::copyParsedQueryTo() is unused. Remove it from WebCore.

The function was used by HTMLAnchorElement::getParameter() but that feature
was removed in r100164.

  • WebCore.order:
  • platform/KURL.cpp:

(WebCore):

  • platform/KURL.h:

(WebCore):
(KURL):

  • platform/KURLGoogle.cpp:

(WebCore):

  • platform/KURLWTFURL.cpp:

(WebCore):

10:35 PM Changeset in webkit [108927] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r108924.
http://trac.webkit.org/changeset/108924
https://bugs.webkit.org/show_bug.cgi?id=79597

broke 4 inspector tests (Requested by kling on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-25

  • dom/StyledElement.cpp:

(WebCore::StyledElement::parseAttribute):

10:16 PM Changeset in webkit [108926] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix typo in comment. This #endif is for a different ENABLE macro.

  • page/NavigatorRegisterProtocolHandler.cpp:
9:40 PM Changeset in webkit [108925] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Move an ASSERT to avoid it firing due to a race condition
https://bugs.webkit.org/show_bug.cgi?id=79596

Reviewed by Andreas Kling.

ScrollingThread::isCurrentThread() can return false if called too early.
Move it into ScrollingThread::initializeRunLoop where we know that the thread has
been set up correctly.

  • page/scrolling/ScrollingThread.cpp:

(WebCore::ScrollingThread::threadBody):

  • page/scrolling/mac/ScrollingThreadMac.mm:

(WebCore::ScrollingThread::initializeRunLoop):

9:08 PM Changeset in webkit [108924] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Setting style="" should destroy the element's inline style.
<http://webkit.org/b/79595>

Reviewed by Anders Carlsson.

There's no reason for an element with style="" to have an inline style object.
Remove the inline style in that case, just like we do when removing the style
attribute altogether.

  • dom/StyledElement.cpp:

(WebCore::StyledElement::parseAttribute):

8:12 PM Changeset in webkit [108923] by gyuyoung.kim@samsung.com
  • 7 edits in trunk

Change Build bot with BuildAndTest bot for EFL port.
https://bugs.webkit.org/show_bug.cgi?id=77518

Reviewed by Ryosuke Niwa.

Tools:

EFL build bot starts to support layout test.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • BuildSlaveSupport/built-product-archive:

(archiveBuiltProduct):
(extractBuiltProduct):

  • BuildSlaveSupport/test-result-archive:

(archiveTestResults):

  • Scripts/webkitdirs.pm: Enable SHARED_CORE option when ENABLE_DRT is enable in EFL port.

(generateBuildSystemFromCMakeProject):

LayoutTests:

  • platform/efl/Skipped: Update skip list with test cases which don't have expected result.
7:38 PM Changeset in webkit [108922] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

Update EFL port's Skipped file for Ubuntu 11.10.
https://bugs.webkit.org/show_bug.cgi?id=79440

Reviewed by Ryosuke Niwa.

To run EFL layout test on Ubuntu 11.10, Skipped file needs to be updated.

  • platform/efl/Skipped:
6:35 PM Changeset in webkit [108921] by rniwa@webkit.org
  • 2 edits in trunk

Perf-o-matic build fix after r108917. I need a scrollbar in order see all the tests.

  • Websites/webkit-perf.appspot.com/css/admin.css:

(html):

6:02 PM Changeset in webkit [108920] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Address review feedback from Andreas Kling.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformHandleMouseEvent):

5:59 PM Changeset in webkit [108919] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Mouse tracking incorrect in Silverlight when using multi monitor with offset arrangement
https://bugs.webkit.org/show_bug.cgi?id=79589
<rdar://problem/9719592>

Reviewed by Sam Weinig.

In the Carbon event model, mouse event coordinates are flipped relative to the first screen,
whereas the coordinates we get from the WebMouseEvent are flipped relative to the screen where
the containing WKView is on.

Instead of passing the global coordinates to NPP_HandleEvent, convert them to the flipped screen coordinate
system that the plug-in expects.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformHandleMouseEvent):

5:32 PM Changeset in webkit [108918] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit/mac

QuickLook events don't make it to WebKit plugins.
<rdar://problem/10931721>

Reviewed by Anders Carlsson.

  • WebView/WebHTMLView.mm:

(isQuickLookEvent):
(-[WebHTMLView hitTest:]):
Allow QuickLook events to hit test down to subviews.

5:22 PM Changeset in webkit [108917] by rniwa@webkit.org
  • 5 edits
    3 adds
    2 deletes in trunk

perf-o-matic needs a better admin page
https://bugs.webkit.org/show_bug.cgi?id=79585

Reviewed by Sam Weinig.

Add admin/ to replace admin/create-models.html and admin/merge-tests.

Also update MergeTestHandler to accept JSON requests and add "Admin" navigation link on all pages.

  • Websites/webkit-perf.appspot.com/admin_handlers.py: Added.
  • Websites/webkit-perf.appspot.com/controller.py:

(RunsUpdateHandler.post): Fix a regression from r108399.

  • Websites/webkit-perf.appspot.com/css/admin.css: Added.
  • Websites/webkit-perf.appspot.com/js/admin.js: Added.
  • Websites/webkit-perf.appspot.com/js/config.js:
  • Websites/webkit-perf.appspot.com/main.py:
  • Websites/webkit-perf.appspot.com/merge_tests.html: Removed.
  • Websites/webkit-perf.appspot.com/merge_tests_handler.py:

(MergeTestsHandler):
(MergeTestsHandler.post):

  • Websites/webkit-perf.appspot.com/static: Removed.
  • Websites/webkit-perf.appspot.com/static/create-models.html: Removed.
4:49 PM Changeset in webkit [108916] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Allow matched property cache for elements with additional attribute style.
<http://webkit.org/b/79583>

Reviewed by Antti Koivisto.

There's no reason to disallow the matched style property cache for elements
that return something from additionalAttributeStyle(). The only requirement
for a property set to be cached is that it either doesn't mutate OR that it
invalidates the document's CSSStyleSelector when doing so.

This allows some more match caching for table-related elements, though we
are still held back by explicitly 'inherited' properties in html.css.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

4:28 PM Changeset in webkit [108915] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Unreviewed, rolling out r108900.
http://trac.webkit.org/changeset/108900
https://bugs.webkit.org/show_bug.cgi?id=79587

broke some API tests, will investigate and re-commit
(Requested by noamr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-25

  • UIProcess/API/qt/qquickwebpage.cpp:

(computeEffectiveOpacity):
(QQuickWebPagePrivate::paintToCurrentGLContext):
(PageProxyNode::changedStates):
(PageProxyNode::render):

  • UIProcess/API/qt/qquickwebpage_p_p.h:

(QQuickWebPagePrivate):

4:19 PM Changeset in webkit [108914] by jchaffraix@webkit.org
  • 4 edits in trunk/Source/WebCore

Clean-up RenderTableSection::calcRowLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=77705

Reviewed by Nikolas Zimmermann.

Refactoring / simplication of the code.

This change removes some variables that were unneeded and were
hiding what the code was really doing. Also some of the code was
split and moved down to RenderTableCell.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::logicalHeightForRowSizing):

  • rendering/RenderTableCell.h:

(RenderTableCell):
Added the previous helper function to calculate the cell's
adjusted logical height.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):
Removed some variables, simplified the rowspan logic to be clearer
(and added a comment about how we handle rowspans).

4:19 PM Changeset in webkit [108913] by fpizlo@apple.com
  • 8 edits
    2 adds in trunk/Source/JavaScriptCore

LLInt assembly file should be split into 32-bit and 64-bit parts
https://bugs.webkit.org/show_bug.cgi?id=79584

Reviewed by Sam Weinig.

Moved LowLevelInterpreter.asm to LowLevelInterpreter32_64.asm. Gave offlineasm
the ability to include files, and correctly track dependencies: it restricts
the include mechanism to using the same directory as the source file, and uses
the SHA1 hash of all .asm files in that directory as an input hash.

  • llint/LLIntOfflineAsmConfig.h:
  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm: Added.
    • This is just the entire contents of what was previously LowLevelInterpreter.asm
  • llint/LowLevelInterpreter64.asm: Added.
  • offlineasm/asm.rb:
  • offlineasm/ast.rb:
  • offlineasm/generate_offset_extractor.rb:
  • offlineasm/parser.rb:
  • offlineasm/self_hash.rb:
3:59 PM Changeset in webkit [108912] by mrowe@apple.com
  • 2 edits in tags/Safari-535.23.1/Source/WebCore

Merge r108906.

3:59 PM Changeset in webkit [108911] by mrowe@apple.com
  • 4 edits in tags/Safari-535.23.1/Source

Versioning.

3:41 PM Changeset in webkit [108910] by mrowe@apple.com
  • 1 copy in tags/Safari-535.23.1

New tag.

3:27 PM Changeset in webkit [108909] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Offlineasm should support X86_64
https://bugs.webkit.org/show_bug.cgi?id=79581

Reviewed by Oliver Hunt.

  • llint/LLIntOfflineAsmConfig.h:
  • offlineasm/backends.rb:
  • offlineasm/instructions.rb:
  • offlineasm/settings.rb:
  • offlineasm/x86.rb:
3:05 PM Changeset in webkit [108908] by fpizlo@apple.com
  • 15 edits in trunk/Source/JavaScriptCore

DFG should support activations and nested functions
https://bugs.webkit.org/show_bug.cgi?id=79554

Reviewed by Oliver Hunt.

Wrote the simplest possible implementation of activations. Big speed-up on
code that uses activations, no speed-up on major benchmarks (SunSpider, V8,
Kraken) because they do not appear to have sufficient coverage over code
that uses activations.

  • bytecode/PredictedType.cpp:

(JSC::predictionToString):
(JSC::predictionFromValue):

  • bytecode/PredictedType.h:

(JSC):
(JSC::isEmptyPrediction):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::buildOperandMapsIfNecessary):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):
(JSC::DFG::canInlineOpcode):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::needsActivation):

  • dfg/DFGNode.h:

(DFG):
(JSC::DFG::Node::storageAccessDataIndex):
(Node):
(JSC::DFG::Node::hasFunctionDeclIndex):
(JSC::DFG::Node::functionDeclIndex):
(JSC::DFG::Node::hasFunctionExprIndex):
(JSC::DFG::Node::functionExprIndex):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileNewFunctionNoCheck):
(DFG):
(JSC::DFG::SpeculativeJIT::compileNewFunctionExpression):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

2:31 PM Changeset in webkit [108907] by benjamin@webkit.org
  • 9 edits
    4 adds in trunk/Source

Add an empty skeleton of KURL for WTFURL
https://bugs.webkit.org/show_bug.cgi?id=78990

Reviewed by Adam Barth.

Source/JavaScriptCore:

  • JavaScriptCore.xcodeproj/project.pbxproj: Export the relevant classes from WTFURL

so that can use them in WebCore.

Source/WebCore:

Add an empty skeleton of KURL based on WTFURL.

With WTFURL, the data of KURL is in an implicitely shared object
named KURLWTFURLImpl.

In KURLWTFURLImpl, KURL created with invalid URL would be stored
as a String. A valid URL would be stored as a ParsedURL.

  • ForwardingHeaders/wtf/url/ParsedURL.h: Added.
  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/KURL.cpp:

(WebCore):

  • platform/KURL.h:

(KURL):
(WebCore::KURL::KURL):
(WebCore::KURL::isHashTableDeletedValue):
(WebCore):

  • platform/KURLWTFURL.cpp: Added.

(WebCore):
(WebCore::KURL::KURL):
(WebCore::KURL::copy):
(WebCore::KURL::isNull):
(WebCore::KURL::isEmpty):
(WebCore::KURL::isValid):
(WebCore::KURL::hasPath):
(WebCore::KURL::string):
(WebCore::KURL::protocol):
(WebCore::KURL::host):
(WebCore::KURL::port):
(WebCore::KURL::hasPort):
(WebCore::KURL::user):
(WebCore::KURL::pass):
(WebCore::KURL::path):
(WebCore::KURL::lastPathComponent):
(WebCore::KURL::query):
(WebCore::KURL::fragmentIdentifier):
(WebCore::KURL::hasFragmentIdentifier):
(WebCore::KURL::copyParsedQueryTo):
(WebCore::KURL::baseAsString):
(WebCore::KURL::deprecatedString):
(WebCore::KURL::fileSystemPath):
(WebCore::KURL::protocolIs):
(WebCore::KURL::protocolIsInHTTPFamily):
(WebCore::KURL::setProtocol):
(WebCore::KURL::setHost):
(WebCore::KURL::removePort):
(WebCore::KURL::setPort):
(WebCore::KURL::setHostAndPort):
(WebCore::KURL::setUser):
(WebCore::KURL::setPass):
(WebCore::KURL::setPath):
(WebCore::KURL::setQuery):
(WebCore::KURL::setFragmentIdentifier):
(WebCore::KURL::removeFragmentIdentifier):
(WebCore::KURL::hostStart):
(WebCore::KURL::hostEnd):
(WebCore::KURL::pathStart):
(WebCore::KURL::pathEnd):
(WebCore::KURL::pathAfterLastSlash):
(WebCore::KURL::invalidate):
(WebCore::KURL::isHierarchical):
(WebCore::protocolIs):
(WebCore::equalIgnoringFragmentIdentifier):
(WebCore::protocolHostAndPortAreEqual):
(WebCore::encodeWithURLEscapeSequences):
(WebCore::decodeURLEscapeSequences):

  • platform/KURLWTFURLImpl.h: Copied from Source/WebCore/platform/mac/KURLMac.mm.

(WebCore):
(KURLWTFURLImpl):

  • platform/cf/KURLCFNet.cpp:

(WebCore):
(WebCore::KURL::KURL):
(WebCore::KURL::createCFURL):

  • platform/mac/KURLMac.mm:

(WebCore):
(WebCore::KURL::KURL):
(WebCore::KURL::operator NSURL *):

2:27 PM Changeset in webkit [108906] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Make the libc++ workaround more targeted
https://bugs.webkit.org/show_bug.cgi?id=79578
<rdar://problem/10933150>

Reviewed by Sam Weinig.

Change the std::move implementation to take a WebCore::TimerHeapReference directly so
WebCore still builds with a version of libc++ that has the right std::move function template.

  • WebCorePrefix.h:

(WebCore):
(move):

12:17 PM Changeset in webkit [108905] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed, fix build for DFG disabled and LLInt enabled.

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • llint/LLIntSlowPaths.cpp:

(LLInt):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):

11:16 AM Changeset in webkit [108904] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove HTMLEmbedElement::insertedIntoDocument().
<http://webkit.org/b/79576>

Reviewed by Anders Carlsson.

  • html/HTMLEmbedElement.cpp:
  • html/HTMLEmbedElement.h:
11:11 AM Changeset in webkit [108903] by enne@google.com
  • 2 edits in trunk/Source/WebCore

Fix unused variable warnings in HarfBuzzShaperBase
https://bugs.webkit.org/show_bug.cgi?id=79575

Reviewed by Andreas Kling.

In builds where asserts are not enabled, the error variable is unused.

  • platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp:

(WebCore::normalizeSpacesAndMirrorChars):

10:25 AM Changeset in webkit [108902] by enne@google.com
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Unreviewed gardening, fix Linux Clang OwnPtr breakage
https://bugs.webkit.org/show_bug.cgi?id=78404

r108886 doesn't compile on Linux Clang due to OwnPtr's public copy
constructor (i.e. "has internal linkage but is not defined"). Fixed
locally by changing copy initialization to direct initialization.

  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):

10:18 AM Changeset in webkit [108901] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove HTMLTableElement::attach().
<http://webkit.org/b/79574>

Reviewed by Anders Carlsson.

Remove this attach() override since it was only used to assert that
we're not already attached, and this is already done by Node::attach().

  • html/HTMLTableElement.cpp:
  • html/HTMLTableElement.h:
9:59 AM Changeset in webkit [108900] by noam.rosenthal@nokia.com
  • 3 edits in trunk/Source/WebKit2

[Qt] Use the existing inheritedOpacity/matrix properties of QSGNode
https://bugs.webkit.org/show_bug.cgi?id=79543

Use QSGNode::inheritedOpacity() and QSGNode::matrix().
Also, remove flags from changedStates() that we don't actually touch.

Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPagePrivate::paintToCurrentGLContext):
(PageProxyNode::changedStates):
(PageProxyNode::render):

  • UIProcess/API/qt/qquickwebpage_p_p.h:

(QQuickWebPagePrivate):

9:43 AM Changeset in webkit [108899] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

HTMLTableElement: Avoid CSSParser in createSharedCellStyle().
<http://webkit.org/b/79573>

Reviewed by Anders Carlsson.

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::createSharedCellStyle):

9:32 AM Changeset in webkit [108898] by enne@google.com
  • 6 edits
    1 delete in trunk/LayoutTests

[chromium] Unreviewed gardening, unrebaseline zoom-replaced-intrinsic-ratio

r1085557 got reverted, but tests had been rebaselined. Revert that.

  • platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Removed.
  • platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
9:21 AM Changeset in webkit [108897] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening, mark effect-drop-shadow-hw as flaky
https://bugs.webkit.org/show_bug.cgi?id=79572

  • platform/chromium/test_expectations.txt:
3:45 AM Changeset in webkit [108896] by noel.gordon@gmail.com
  • 11 edits
    1 move
    3 adds
    1 delete in trunk/LayoutTests

[chromium] Update expectations for svg carto.net tests
https://bugs.webkit.org/show_bug.cgi?id=79423

Unreviewed. Rebaseline svg/carto.net/scrollbar.svg and svg/carto.net/selectionlist.svg
to complete the JPEG decoding changes due to r107389.

  • platform/chromium-linux/svg/carto.net/scrollbar-expected.png:
  • platform/chromium-linux/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.png:
  • platform/chromium-mac-leopard/svg/carto.net/scrollbar-expected.txt:
  • platform/chromium-mac-leopard/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-mac-leopard/svg/carto.net/selectionlist-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/carto.net/scrollbar-expected.png:
  • platform/chromium-mac-snowleopard/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-win-xp/svg/carto.net/scrollbar-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/svg/carto.net/scrollbar-expected.txt.
  • platform/chromium-win-xp/svg/carto.net/selectionlist-expected.txt: Added.
  • platform/chromium-win/svg/carto.net/scrollbar-expected.png:
  • platform/chromium-win/svg/carto.net/selectionlist-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/carto.net/scrollbar-expected.png: Removed.
3:13 AM Changeset in webkit [108895] by Csaba Osztrogonác
  • 6 edits
    1 add in trunk/LayoutTests

[Qt] Unreviewed weekend gardening.

  • platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png:
  • platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
  • platform/qt/svg/css/getComputedStyle-basic-expected.png:
  • platform/qt/svg/css/getComputedStyle-basic-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
2:44 AM Changeset in webkit [108894] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed. Skip fast/images/color-jpeg-with-color-profile.html on LINUX WIN
https://bugs.webkit.org/show_bug.cgi?id=79565

SKIP this test: color profiles are not supported on Chromium LINUX, WIN

  • platform/chromium/test_expectations.txt:
1:58 AM Changeset in webkit [108893] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2012-02-25 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Rebase SVG text result.

  • svg/css/getComputedStyle-basic-expected.txt:
1:27 AM Changeset in webkit [108892] by Nikolas Zimmermann
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r108557.
http://trac.webkit.org/changeset/108557
https://bugs.webkit.org/show_bug.cgi?id=77705

Broke svg/zoom/page/zoom-replated-intrinsic-ratio-001.htm.

  • rendering/RenderTableCell.cpp:
  • rendering/RenderTableCell.h:

(RenderTableCell):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):

12:45 AM Changeset in webkit [108891] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed weekend gardening.

  • platform/qt/Skipped:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
12:25 AM Changeset in webkit [108890] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

HTMLParamElement: Clean up name/value attribute handling.
<http://webkit.org/b/79559>

Patch by Andreas Kling <awesomekling@apple.com> on 2012-02-25
Reviewed by Anders Carlsson.

Out-of-line name() and value(), and move the logic from parseAttribute()
into them instead. This makes the class a bit simpler and shrinks it by
two AtomicStrings. Also reduced isURLAttribute() to a two-liner.

  • html/HTMLParamElement.cpp:

(WebCore::HTMLParamElement::name):
(WebCore::HTMLParamElement::value):
(WebCore::HTMLParamElement::isURLAttribute):

  • html/HTMLParamElement.h:
12:10 AM Changeset in webkit [108889] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebKit2

Unreviewed, rolling out r108816.
http://trac.webkit.org/changeset/108816
https://bugs.webkit.org/show_bug.cgi?id=79562

It made many tests crash and timeout on Qt-WK2 (Requested by
ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-25

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::setIcon):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

  • UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml:
  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::loadProgress):

  • UIProcess/qt/QtWebPageLoadClient.cpp:

(QtWebPageLoadClient::didCommitLoadForFrame):
(QtWebPageLoadClient::didSameDocumentNavigationForFrame):
(QtWebPageLoadClient::didReceiveTitleForFrame):
(QtWebPageLoadClient::setLoadProgress):

  • UIProcess/qt/QtWebPageLoadClient.h:

(QtWebPageLoadClient):

12:07 AM Changeset in webkit [108888] by mhahnenberg@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Fix the CopiedBlock offset alignment in a cross platform fashion
https://bugs.webkit.org/show_bug.cgi?id=79556

Reviewed by Filip Pizlo.

Replaced m_payload with a payload() method that calculates the offset
of the payload with the proper alignment. This change allows us to
avoid alignment-related issues in a cross-platform manner.

  • heap/CopiedAllocator.h:

(JSC::CopiedAllocator::currentUtilization):

  • heap/CopiedBlock.h:

(JSC::CopiedBlock::CopiedBlock):
(JSC::CopiedBlock::payload):
(CopiedBlock):

  • heap/CopiedSpace.cpp:

(JSC::CopiedSpace::doneFillingBlock):

  • heap/CopiedSpaceInlineMethods.h:

(JSC::CopiedSpace::borrowBlock):
(JSC::CopiedSpace::allocateFromBlock):

Feb 24, 2012:

11:20 PM Changeset in webkit [108887] by noel.gordon@gmail.com
  • 2 edits
    1 add
    1 delete in trunk/LayoutTests

Unreviewed. Add missing fast/images/rgb-jpeg-with-adobe-marker-only.html results.

  • platform/chromium-mac-snowleopard/fast/images/rgb-jpeg-with-adobe-marker-only-expected.txt: Removed.
  • platform/chromium-win/fast/images/rgb-jpeg-with-adobe-marker-only-expected.png: Added.
  • platform/chromium/test_expectations.txt:
8:09 PM Changeset in webkit [108886] by jamesr@google.com
  • 47 edits in trunk/Source

[chromium] Replace RefPtr with OwnPtr for CCLayerImpl tree structure
https://bugs.webkit.org/show_bug.cgi?id=78404

Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-02-24
Reviewed by James Robinson.

Source/WebCore:

No new tests. Updated existing test to reflect changes.

  • platform/graphics/chromium/CanvasLayerChromium.cpp:

(WebCore::CanvasLayerChromium::createCCLayerImpl):

  • platform/graphics/chromium/CanvasLayerChromium.h:

(CanvasLayerChromium):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::createCCLayerImpl):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):

  • platform/graphics/chromium/PluginLayerChromium.cpp:

(WebCore::PluginLayerChromium::createCCLayerImpl):

  • platform/graphics/chromium/PluginLayerChromium.h:

(PluginLayerChromium):

  • platform/graphics/chromium/SolidColorLayerChromium.cpp:

(WebCore::SolidColorLayerChromium::createCCLayerImpl):

  • platform/graphics/chromium/SolidColorLayerChromium.h:

(SolidColorLayerChromium):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::createCCLayerImpl):

  • platform/graphics/chromium/TiledLayerChromium.h:

(TiledLayerChromium):

  • platform/graphics/chromium/TreeSynchronizer.cpp:

(WebCore::TreeSynchronizer::synchronizeTrees):
(WebCore::TreeSynchronizer::collectExistingCCLayerImplRecursive):
(WebCore):
(WebCore::TreeSynchronizer::reuseOrCreateCCLayerImpl):
(WebCore::TreeSynchronizer::synchronizeTreeRecursive):

  • platform/graphics/chromium/TreeSynchronizer.h:

(TreeSynchronizer):

  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::createCCLayerImpl):

  • platform/graphics/chromium/VideoLayerChromium.h:

(VideoLayerChromium):

  • platform/graphics/chromium/cc/CCCanvasLayerImpl.h:

(WebCore::CCCanvasLayerImpl::create):

  • platform/graphics/chromium/cc/CCDamageTracker.cpp:

(WebCore::CCDamageTracker::updateDamageTrackingState):
(WebCore::CCDamageTracker::trackDamageFromActiveLayers):

  • platform/graphics/chromium/cc/CCDamageTracker.h:

(CCDamageTracker):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::addChild):
(WebCore::sortLayers):
(WebCore::CCLayerImpl::setMaskLayer):
(WebCore::CCLayerImpl::setReplicaLayer):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::create):
(WebCore::CCLayerImpl::children):
(CCLayerImpl):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerIterator.cpp:

(WebCore):
(WebCore::CCLayerIteratorActions::BackToFront::begin):
(WebCore::CCLayerIteratorActions::BackToFront::end):
(WebCore::CCLayerIteratorActions::BackToFront::next):
(WebCore::CCLayerIteratorActions::FrontToBack::begin):
(WebCore::CCLayerIteratorActions::FrontToBack::end):
(WebCore::CCLayerIteratorActions::FrontToBack::next):
(WebCore::CCLayerIteratorActions::FrontToBack::goToHighestInSubtree):

  • platform/graphics/chromium/cc/CCLayerIterator.h:

(WebCore):
(CCLayerIterator):
(WebCore::CCLayerIterator::begin):
(WebCore::CCLayerIterator::end):
(WebCore::CCLayerIterator::targetRenderSurfaceLayer):
(WebCore::CCLayerIterator::CCLayerIterator):
(WebCore::CCLayerIterator::getRawPtr):
(WebCore::CCLayerIterator::currentLayer):
(WebCore::CCLayerIterator::targetRenderSurfaceChildren):
(BackToFront):
(FrontToBack):

  • platform/graphics/chromium/cc/CCLayerSorter.cpp:

(WebCore::CCLayerSorter::createGraphNodes):

  • platform/graphics/chromium/cc/CCLayerSorter.h:

(CCLayerSorter):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):
(WebCore::CCLayerTreeHost::reserveTextures):
(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore):
(WebCore::calculateDrawTransformsAndVisibilityInternal):
(WebCore::walkLayersAndCalculateVisibleLayerRects):
(WebCore::CCLayerTreeHostCommon::calculateDrawTransformsAndVisibility):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:

(CCLayerTreeHostCommon):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::trackDamageForAllSurfaces):
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::drawLayers):
(WebCore::CCLayerTreeHostImpl::setRootLayer):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::releaseRootLayer):
(WebCore::CCLayerTreeHostImpl::scrollLayer):

  • platform/graphics/chromium/cc/CCPluginLayerImpl.h:

(WebCore::CCPluginLayerImpl::create):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore::CCRenderSurface::layerList):
(CCRenderSurface):

  • platform/graphics/chromium/cc/CCSolidColorLayerImpl.h:

(WebCore::CCSolidColorLayerImpl::create):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:

(WebCore::CCTiledLayerImpl::create):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:

(WebCore::CCVideoLayerImpl::create):

Source/WebKit/chromium:

  • tests/CCDamageTrackerTest.cpp:

(WebKitTests::executeCalculateDrawTransformsAndVisibility):
(WebKitTests::emulateDrawingOneFrame):
(WebKitTests::createTestTreeWithOneSurface):
(WebKitTests::createTestTreeWithTwoSurfaces):
(WebKitTests::createAndSetUpTestTreeWithOneSurface):
(WebKitTests::createAndSetUpTestTreeWithTwoSurfaces):
(WebKitTests::TEST_F):

  • tests/CCLayerImplTest.cpp:

(WebCore::TEST):

  • tests/CCLayerIteratorTest.cpp:
  • tests/CCLayerSorterTest.cpp:

(WebCore::TEST):

  • tests/CCLayerTreeHostCommonTest.cpp:

(WebCore::TEST):

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::CCLayerTreeHostImplTest::setupScrollAndContentsLayers):
(WebKit::TEST_F):
(WebKit::DidDrawCheckLayer::create):
(WebKit::BlendStateCheckLayer::create):

  • tests/CCRenderSurfaceTest.cpp:

(WebCore::TEST):

  • tests/CCSolidColorLayerImplTest.cpp:

(CCLayerTestCommon::TEST):

  • tests/CCTiledLayerImplTest.cpp:

(CCLayerTestCommon::createLayer):
(CCLayerTestCommon::TEST):
(CCLayerTestCommon::getQuads):

  • tests/Canvas2DLayerChromiumTest.cpp:

(WebCore::Canvas2DLayerChromiumTest::fullLifecycleTest):

  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):

  • tests/TreeSynchronizerTest.cpp:

(WebKitTests::MockCCLayerImpl::create):
(WebKitTests::MockLayerChromium::createCCLayerImpl):
(WebKitTests::expectTreesAreIdentical):
(WebKitTests::TEST):

7:27 PM Changeset in webkit [108885] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

Don't pass constant strings to CSSParser for presentation attributes.
<http://webkit.org/b/79530>

Reviewed by Anders Carlsson.

"both" -> CSSValueBoth.
"center" -> CSSValueCenter.

  • html/HTMLBRElement.cpp:

(WebCore::HTMLBRElement::collectStyleForAttribute):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::collectStyleForAttribute):

6:57 PM Changeset in webkit [108884] by enne@google.com
  • 1 edit
    5 moves in trunk/LayoutTests

Unreviewed, rename mispelled expectation files.
https://bugs.webkit.org/show_bug.cgi?id=79457

WebKit is no abode for poor spelling.

  • fast/images/rgb-jpeg-with-adobe-marker-only-expected.txt: Renamed from LayoutTests/fast/images/rgb-jpeg-with-abode-marker-only-expected.txt.
  • fast/images/rgb-jpeg-with-adobe-marker-only.html: Renamed from LayoutTests/fast/images/rgb-jpeg-with-abode-marker-only.html.
  • platform/chromium-mac-snowleopard/fast/images/rgb-jpeg-with-adobe-marker-only-expected.png: Renamed from LayoutTests/platform/chromium-mac-snowleopard/fast/images/rgb-jpeg-with-abode-marker-only-expected.png.
  • platform/chromium-mac-snowleopard/fast/images/rgb-jpeg-with-adobe-marker-only-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/fast/images/rgb-jpeg-with-abode-marker-only-expected.txt.
  • platform/mac-snowleopard/fast/images/rgb-jpeg-with-adobe-marker-only-expected.png: Renamed from LayoutTests/platform/mac-snowleopard/fast/images/rgb-jpeg-with-abode-marker-only-expected.png.
6:55 PM Changeset in webkit [108883] by jamesr@google.com
  • 10 edits in trunk/Source

[chromium] Make WebViewImpl depend on WebLayerTreeView instead of CCLayerTreeHost
https://bugs.webkit.org/show_bug.cgi?id=75591

Reviewed by Kenneth Russell.

This converts WebViewImpl from depending on CCLayerTreeHost to WebLayerTreeView in order to provide better
isolation and allow for future refactorings. The changes to WebViewImpl are mostly mechanical. The
WebLayerTreeView and WebLayerTreeViewClient interfaces have both grown and changed slightly:

  • Setup path for WebLayerTreeView changed to expose an initialize() function instead of a create() factory

function. The new model is that a WebLayerTreeView when constructed is in a null state. Calling initialize()
attempts to re-initialize the WLTV, which can either fail or succeed. All other functions must be called on a
successfully initialized view.

  • WebLayerTreeView expanded to include functionality that CCLayerTreeHost exposes but WebLayerTreeView did not.

Some of this is only valid for the single thread case and will be removed when we invert the scheduling control
logic, these bits are commented.

  • WebLayerTreeViewClient expanded with some flow-control related APIs.

Refactor only, no change in behavior.

  • public/platform/WebLayerTreeView.h:

(WebKit::WebLayerTreeView::Settings::Settings):
(WebKit::WebLayerTreeView::isNull):

  • public/platform/WebLayerTreeViewClient.h:
  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::scheduleCompositingLayerSync):

  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::initialize):
(WebKit::WebLayerTreeView::compositorIdentifier):
(WebKit::WebLayerTreeView::setVisible):
(WebKit::WebLayerTreeView::setNeedsAnimate):
(WebKit::WebLayerTreeView::updateAnimations):
(WebKit::WebLayerTreeView::setNeedsRedraw):
(WebKit::WebLayerTreeView::setPageScaleFactorAndLimits):
(WebKit::WebLayerTreeView::startPageScaleAnimation):
(WebKit::WebLayerTreeView::finishAllRendering):
(WebKit::WebLayerTreeView::context):
(WebKit::WebLayerTreeView::loseCompositorContext):

  • src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::didRecreateGraphicsContext):
(WebKit::WebLayerTreeViewImpl::didCommitAndDrawFrame):
(WebKit::WebLayerTreeViewImpl::didCompleteSwapBuffers):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::animate):
(WebKit::WebViewImpl::doPixelReadbackToCanvas):
(WebKit::WebViewImpl::paint):
(WebKit::WebViewImpl::composite):
(WebKit::WebViewImpl::loseCompositorContext):
(WebKit::WebViewImpl::computePageScaleFactorLimits):
(WebKit::WebViewImpl::addPageOverlay):
(WebKit::WebViewImpl::removePageOverlay):
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::scheduleCompositingLayerSync):
(WebKit::WebViewImpl::scrollRootLayerRect):
(WebKit::WebViewImpl::invalidateRootLayerRect):
(WebKit::WebViewImpl::scheduleAnimation):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::createContext3D):
(WebKit::WebViewImpl::applyScrollAndScale):
(WebKit::WebViewImpl::didRebindGraphicsContext):
(WebKit::WebViewImpl::updateLayerTreeViewport):
(WebKit::WebViewImpl::graphicsContext3D):
(WebKit::WebViewImpl::setVisibilityState):

  • src/WebViewImpl.h:
  • tests/WebLayerTest.cpp:
6:41 PM Changeset in webkit [108882] by yael.aharon@nokia.com
  • 3 edits in trunk/Source/WebCore

[Texmap] Add const-ness to TextureMapperShaderManager
https://bugs.webkit.org/show_bug.cgi?id=79545

Reviewed by Noam Rosenthal.

Add const to new methods.
No new tests.

  • platform/graphics/texmap/TextureMapperShaderManager.cpp:

(WebCore::TextureMapperShaderProgramSimple::vertexShaderSource):
(WebCore::TextureMapperShaderProgramSimple::fragmentShaderSource):
(WebCore::TextureMapperShaderProgramOpacityAndMask::vertexShaderSource):
(WebCore::TextureMapperShaderProgramOpacityAndMask::fragmentShaderSource):

  • platform/graphics/texmap/TextureMapperShaderManager.h:

(WebCore::TextureMapperShaderProgram::matrixVariable):
(WebCore::TextureMapperShaderProgram::sourceMatrixVariable):
(WebCore::TextureMapperShaderProgram::sourceTextureVariable):
(WebCore::TextureMapperShaderProgram::opacityVariable):
(TextureMapperShaderProgram):
(TextureMapperShaderProgramSimple):
(WebCore::TextureMapperShaderProgramOpacityAndMask::maskMatrixVariable):
(WebCore::TextureMapperShaderProgramOpacityAndMask::maskTextureVariable):
(TextureMapperShaderProgramOpacityAndMask):

6:39 PM Changeset in webkit [108881] by tsepez@chromium.org
  • 4 edits
    3 adds in trunk

XSS Auditor targeting legitimate frames as false positives.
https://bugs.webkit.org/show_bug.cgi?id=79397

Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/xssAuditor/script-tag-safe4.html

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::filterCharacterToken):
(WebCore::XSSAuditor::filterScriptToken):
(WebCore::XSSAuditor::filterObjectToken):
(WebCore::XSSAuditor::filterEmbedToken):
(WebCore::XSSAuditor::filterAppletToken):
(WebCore::XSSAuditor::filterIframeToken):
(WebCore::XSSAuditor::decodedSnippetForToken):
(WebCore):
(WebCore::XSSAuditor::decodedSnippetForName):
(WebCore::XSSAuditor::decodedSnippetForAttribute):
(WebCore::XSSAuditor::decodedSnippetForJavascript):
(WebCore::XSSAuditor::isContainedInRequest):
(WebCore::XSSAuditor::isSameOriginResource):

  • html/parser/XSSAuditor.h:

LayoutTests:

  • http/tests/security/xssAuditor/resources/script-tag-safe4-frame.html: Added.
  • http/tests/security/xssAuditor/script-tag-safe4-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-safe4.html: Added.
6:19 PM Changeset in webkit [108880] by commit-queue@webkit.org
  • 13 edits
    1 copy
    1 add in trunk/Source

[chromium] Plumb animation started notifications from CCLayerTreeHost to GraphicsLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=77646

Patch by Ian Vollick <vollick@chromium.org> on 2012-02-24
Reviewed by James Robinson.

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(std):
(WebCore::GraphicsLayerChromium::~GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::addAnimation):
(WebCore::GraphicsLayerChromium::pauseAnimation):
(WebCore::GraphicsLayerChromium::removeAnimation):
(WebCore::GraphicsLayerChromium::suspendAnimations):
(WebCore::GraphicsLayerChromium::resumeAnimations):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore::GraphicsLayerChromium::mapAnimationNameToId):
(WebCore):
(WebCore::GraphicsLayerChromium::notifyAnimationStarted):
(WebCore::GraphicsLayerChromium::notifyAnimationFinished):

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(GraphicsLayerChromium):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setAnimationEvent):
(WebCore):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore):
(LayerChromium):
(WebCore::LayerChromium::setLayerAnimationDelegate):

  • platform/graphics/chromium/cc/CCAnimationEvents.cpp: Added.

(WebCore):
(WebCore::CCAnimationEvent::CCAnimationEvent):
(WebCore::CCAnimationEvent::~CCAnimationEvent):
(WebCore::CCAnimationEvent::toAnimationStartedEvent):
(WebCore::CCAnimationEvent::toAnimationFinishedEvent):
(WebCore::CCAnimationStartedEvent::create):
(WebCore::CCAnimationStartedEvent::CCAnimationStartedEvent):
(WebCore::CCAnimationStartedEvent::~CCAnimationStartedEvent):
(WebCore::CCAnimationStartedEvent::type):
(WebCore::CCAnimationFinishedEvent::create):
(WebCore::CCAnimationFinishedEvent::CCAnimationFinishedEvent):
(WebCore::CCAnimationFinishedEvent::~CCAnimationFinishedEvent):
(WebCore::CCAnimationFinishedEvent::type):

  • platform/graphics/chromium/cc/CCAnimationEvents.h:

(WebCore):
(CCAnimationEvent):
(WebCore::CCAnimationEvent::layerId):
(CCAnimationStartedEvent):
(WebCore::CCAnimationStartedEvent::startTime):
(CCAnimationFinishedEvent):
(WebCore::CCAnimationFinishedEvent::animationId):

  • platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.cpp:

(WebCore::CCLayerAnimationControllerImpl::animate):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForNextTick):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForStartTime):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForTargetAvailability):
(WebCore::CCLayerAnimationControllerImpl::purgeFinishedAnimations):
(WebCore::CCLayerAnimationControllerImpl::tickAnimations):

  • platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.h:

(CCLayerAnimationControllerImpl):

  • platform/graphics/chromium/cc/CCLayerAnimationDelegate.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCAnimationEvents.h.

(WebCore):
(CCLayerAnimationDelegate):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::setAnimationEvents):
(WebCore::CCLayerTreeHost::setAnimationEventsRecursive):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(TestHooks):
(WTF::TestHooks::notifyAnimationStarted):
(WTF::TestHooks::notifyAnimationFinished):
(WTF::MockLayerTreeHost::create):
(WTF::CCLayerTreeHostTestAddAnimation::CCLayerTreeHostTestAddAnimation):
(WTF::CCLayerTreeHostTestAddAnimation::animateLayers):
(WTF::CCLayerTreeHostTestAddAnimation::notifyAnimationStarted):
(CCLayerTreeHostTestAddAnimation):
(WTF::CCLayerTreeHostTestAddAnimation::notifyAnimationFinished):

6:19 PM Changeset in webkit [108879] by darin@chromium.org
  • 2 edits in trunk/Tools

Add watchlist for ChromiumPlatformApi matching Source/Platform/chromium/public/

Reviewed by James Robinson.

  • Scripts/webkitpy/common/config/watchlist:
6:01 PM Changeset in webkit [108878] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Regression(r107477): Crash in StaticNodeList::itemWithName.
https://bugs.webkit.org/show_bug.cgi?id=79532

Reviewed by Andreas Kling.

Source/WebCore:

Make sure that node is an element node before checking its id attribute.

Test: fast/mutation/mutation-callback-non-element-crash.html

  • dom/StaticNodeList.cpp:

(WebCore::StaticNodeList::itemWithName):

LayoutTests:

  • fast/mutation/mutation-callback-non-element-crash-expected.txt: Added.
  • fast/mutation/mutation-callback-non-element-crash.html: Added.
5:56 PM Changeset in webkit [108877] by jamesr@google.com
  • 6 edits
    2 moves in trunk/Source

[chromium] WebKit::setColorNames is a client API
https://bugs.webkit.org/show_bug.cgi?id=79539

Reviewed by Darin Fisher.

Source/Platform:

  • Platform.gypi:
  • chromium/public/WebColor.h:

(WebKit):

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebColorName.h: Renamed from Source/Platform/chromium/public/WebColorName.h.

(WebKit):

  • public/platform/WebColorName.h:
  • src/WebColor.cpp:
5:46 PM Changeset in webkit [108876] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

More refactoring in RenderFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=79533

Reviewed by Ojan Vafai.

No new tests, just refactoring.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutFlexItems): Move the flipping of RTL+column positions to its own method.
This might be a tiny bit slower, but it's clearer since it's not related to alignment.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Move the logical height calculation out of the loop. We only need the final height.
(WebCore::RenderFlexibleBox::alignChildren):
(WebCore::RenderFlexibleBox::flipForRightToLeftColumn):

  • rendering/RenderFlexibleBox.h:

(RenderFlexibleBox):

5:31 PM Changeset in webkit [108875] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Positioned objects not cleared when moving children
to clone block in multi-column layout.
https://bugs.webkit.org/show_bug.cgi?id=78416

Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/multicol/span/positioned-child-not-removed-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::splitBlocks):

LayoutTests:

  • fast/multicol/span/positioned-child-not-removed-crash-expected.txt: Added.
  • fast/multicol/span/positioned-child-not-removed-crash.html: Added.
5:11 PM Changeset in webkit [108874] by msaboff@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, Windows build fix. Changed "-1" to newly
created constant JSC::Yarr::offsetNoMatch added in r108858.

  • platform/text/RegularExpression.cpp: (WebCore::RegularExpression::match):
5:10 PM Changeset in webkit [108873] by tomz@codeaurora.org
  • 2 edits in trunk/Websites/webkit.org

team.html (on webkit.org) doesn't recognize codeaurora.org
https://bugs.webkit.org/show_bug.cgi?id=79529

Reviewed by Ryosuke Niwa.

  • team.html:
4:58 PM Changeset in webkit [108872] by eric.carlson@apple.com
  • 25 edits in trunk

Update TextTrackCue API
https://bugs.webkit.org/show_bug.cgi?id=79368

Source/WebCore:

Change TextTrackCue.alignment to .align, TextTrackCue.linePosition and .textPosition to .line
and .position, and TextTrackCue.direction to .vertical. Change direction values "horizontal"
to "","vertical" to "rl", and "vertical-lr" to "lr".

Reviewed by Eric Seidel.

No new tests, updated existing tests for API changes.

  • html/track/TextTrackCue.cpp:

(WebCore::horizontalKeyword):
(WebCore::verticalGrowingLeftKeyword):
(WebCore):
(WebCore::verticalGrowingRightKeyword):
(WebCore::verticalKeywordOLD):
(WebCore::verticallrKeywordOLD):
(WebCore::TextTrackCue::TextTrackCue):
(WebCore::TextTrackCue::vertical):
(WebCore::TextTrackCue::setVertical):
(WebCore::TextTrackCue::setLine):
(WebCore::TextTrackCue::setPosition):
(WebCore::TextTrackCue::align):
(WebCore::TextTrackCue::setAlign):
(WebCore::TextTrackCue::parseSettings):

  • html/track/TextTrackCue.h:

(TextTrackCue):
(WebCore::TextTrackCue::line):
(WebCore::TextTrackCue::position):

  • html/track/TextTrackCue.idl:

LayoutTests:

Reviewed by Eric Seidel.

  • media/track/track-add-remove-cue-expected.txt:
  • media/track/track-add-remove-cue.html:
  • media/track/track-cue-mutable-expected.txt:
  • media/track/track-cue-mutable.html:
  • media/track/track-webvtt-tc013-settings-expected.txt:
  • media/track/track-webvtt-tc013-settings.html:
  • media/track/track-webvtt-tc014-alignment-expected.txt:
  • media/track/track-webvtt-tc014-alignment.html:
  • media/track/track-webvtt-tc015-positioning-expected.txt:
  • media/track/track-webvtt-tc015-positioning.html:
  • media/track/track-webvtt-tc016-align-positioning-expected.txt:
  • media/track/track-webvtt-tc016-align-positioning.html:
  • media/track/track-webvtt-tc017-line-position-expected.txt:
  • media/track/track-webvtt-tc017-line-position.html:
  • media/track/track-webvtt-tc018-align-text-line-position-expected.txt:
  • media/track/track-webvtt-tc018-align-text-line-position.html:
  • media/track/track-webvtt-tc020-cue-size-align-expected.txt:
  • media/track/track-webvtt-tc020-cue-size-align.html:
  • media/track/track-webvtt-tc021-valign-expected.txt:
  • media/track/track-webvtt-tc021-valign.html:
  • platform/mac/Skipped:
4:54 PM Changeset in webkit [108871] by enne@google.com
  • 2 edits in trunk/Source/WebCore

Fix uninitialized variables in HarfBuzzShaperBase
https://bugs.webkit.org/show_bug.cgi?id=79546

Reviewed by Dirk Pranke.

These were introduced in r108733.

  • platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp:

(WebCore::HarfBuzzShaperBase::HarfBuzzShaperBase):

4:49 PM Changeset in webkit [108870] by noel.gordon@gmail.com
  • 4 edits
    6 adds in trunk

[chromium] JPEG RGB image with Adode Marker fails to turbo swizzle decode
https://bugs.webkit.org/show_bug.cgi?id=79457

Reviewed by Adam Barth.

Source/WebCore:

If a JPEG has no JFIF marker, the Adode Marker must be used to determine the image
color space for decoding via that markers transform value. Transform 0 images with
3 color components (RGB) fail to decode with libjpeg-turbo when a swizzle decoding
is active. Detect this case and decode using JCS_RGB output color space instead.

Test: fast/images/rgb-jpeg-with-abode-marker-only.html

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageReader::decode):

LayoutTests:

  • fast/images/resources/rgb-jpeg-with-adobe-marker-only.jpg: Added.
  • fast/images/rgb-jpeg-with-abode-marker-only-expected.txt: Added.
  • fast/images/rgb-jpeg-with-abode-marker-only.html: Added.
  • platform/chromium-mac-snowleopard/fast/images/rgb-jpeg-with-abode-marker-only-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/images/rgb-jpeg-with-abode-marker-only-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac-snowleopard/fast/images/rgb-jpeg-with-abode-marker-only-expected.png: Added.
4:45 PM Changeset in webkit [108869] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, Windows build fix. Changed signature in export to match
change made in r108858.

4:30 PM Changeset in webkit [108868] by dpranke@chromium.org
  • 3 edits in trunk/Tools

webkitpy: changelog_unittest test_fuzzy_reviewer_match is slow
https://bugs.webkit.org/show_bug.cgi?id=79258

Reviewed by Ryosuke Niwa.

Split the fuzzy matching into separate functions so that they
can be sharded and run in parallel.

Also, fix a bug in the svn_blame_regexp that was causing us
to require ChangeLog lines to have at least one space after the
author, making the code require trailing whitespace in the
changelog in some places (this was making my life harder because
I have my text editor set to strip trailing whitespace in python
files, and that was causing test_parse_log_entries_from_changelog() to fail
when the whitespace on line 275 was removed).

  • Scripts/webkitpy/common/checkout/changelog.py:

(ChangeLog):

  • Scripts/webkitpy/common/checkout/changelog_unittest.py:

(test_fuzzy_reviewer_matchnone):
(test_fuzzy_reviewer_match_adam_barth):
(test_fuzzy_reviewer_match_darin_adler_et_al):
(test_fuzzy_reviewer_match_dimitri_glazkov):
(test_fuzzy_reviewer_match_george_staikos):
(test_fuzzy_reviewer_match_mark_rowe):

4:26 PM Changeset in webkit [108867] by jsbell@chromium.org
  • 8 edits
    3 adds in trunk

[V8] IndexedDB: IDBTransaction objects leak in Workers
https://bugs.webkit.org/show_bug.cgi?id=79308

Source/WebCore:

Use a V8RecursionScope whenever Workers call into script, so that
post-script side-effects can be executed.

Reviewed by Tony Chang.

Test: storage/indexeddb/transaction-abort-workers.html

  • bindings/v8/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute):

  • bindings/v8/V8WorkerContextErrorHandler.cpp:

(WebCore::V8WorkerContextErrorHandler::callListenerFunction):

  • bindings/v8/V8WorkerContextEventListener.cpp:

(WebCore::V8WorkerContextEventListener::callListenerFunction):

  • bindings/v8/WorkerContextExecutionProxy.cpp: Replace custom recursion tracking.

(WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
(WebCore::WorkerContextExecutionProxy::runScript):

  • bindings/v8/WorkerContextExecutionProxy.h:

(WorkerContextExecutionProxy):

LayoutTests:

Reviewed by Tony Chang.

  • fast/js/resources/js-test-pre.js:

(startWorker): Return Worker object so onerror can be hooked.

  • storage/indexeddb/resources/transaction-abort-workers.js: Added.
  • storage/indexeddb/transaction-abort-workers-expected.txt: Added.
  • storage/indexeddb/transaction-abort-workers.html: Added.
4:23 PM Changeset in webkit [108866] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

DFG support for op_new_regexp should be enabled
https://bugs.webkit.org/show_bug.cgi?id=79538

Reviewed by Oliver Hunt.

No performance change.

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

  • dfg/DFGCommon.h:
4:22 PM Changeset in webkit [108865] by enne@google.com
  • 6 edits
    2 moves in trunk/Source

Unreviewed, rolling out r108860.
http://trac.webkit.org/changeset/108860
https://bugs.webkit.org/show_bug.cgi?id=79544

"Breaks Linux compile" (Requested by enne on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-24

Source/Platform:

  • Platform.gypi:
  • chromium/public/WebColor.h:

(WebKit):

  • chromium/public/WebColorName.h: Renamed from Source/WebKit/chromium/public/WebColorName.h.

(WebKit):

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/platform/WebColorName.h:
  • src/WebColor.cpp: Renamed from Source/WebKit/chromium/src/WebColorName.cpp.

(WebKit):
(WebKit::toCSSValueKeyword):
(WebKit::setNamedColors):

4:19 PM Changeset in webkit [108864] by dpranke@chromium.org
  • 2 edits in trunk/Tools

webkitpy: committers_unittest fuzzy matching is really slow
https://bugs.webkit.org/show_bug.cgi?id=79179

Reviewed by Ryosuke Niwa.

Break the fuzzy matching tests into individual routines for
each contributor so that the intent is a little clearer, so
that it's easier to test individual names (and identify
duplicate tests), and so that we can eventually run
them in parallel.

Also, mark most of them as 'integration' tests so that they
can be skipped if we want to go fast (we leave a few as
regular tests for functional coverage).

  • Scripts/webkitpy/common/config/committers_unittest.py:

(CommittersTest):
(CommittersTest.test_contributors_by_fuzzy_match):
(CommittersTest.integration_test_contributorsnone):
(CommittersTest.integration_test_contributors
none_2):
(CommittersTest.integration_test_contributorsnone_3):
(CommittersTest.integration_test_contributors_ada_chan):
(CommittersTest.integration_test_contributors_adele_peterson):
(CommittersTest.integration_test_contributors_alexey_proskuryakov):
(CommittersTest.integration_test_contributors_alice_liu):
(CommittersTest.integration_test_contributors_alp_toker):
(CommittersTest.integration_test_contributors_anders_carlsson):
(CommittersTest.integration_test_contributors_antti_koivisto):
(CommittersTest.integration_test_contributors_beth_dakin):
(CommittersTest.integration_test_contributors_brady_eidson):
(CommittersTest.integration_test_contributors_cameron_zwarich):
(CommittersTest.integration_test_contributors_chris_blumenberg):
(CommittersTest.integration_test_contributors_dan_bernstein):
(CommittersTest.integration_test_contributors_dan_bernstein_2):
(CommittersTest.integration_test_contributors_darin_adler):
(CommittersTest.integration_test_contributors_david_harrison):
(CommittersTest.integration_test_contributors_david_harrison_2):
(CommittersTest.integration_test_contributors_david_hyatt):
(CommittersTest.integration_test_contributors_david_kilzer):
(CommittersTest.integration_test_contributors_don_melton):
(CommittersTest.integration_test_contributors_eric_seidel):
(CommittersTest.integration_test_contributors_geoffrey_garen):
(CommittersTest.integration_test_contributors_greg_bolsinga):
(CommittersTest.integration_test_contributors_holger_freyther):
(CommittersTest.integration_test_contributors_jon_sullivan):
(CommittersTest.integration_test_contributors_jon_honeycutt):
(CommittersTest.integration_test_contributors_joseph_pecoraro):
(CommittersTest.integration_test_contributors_ken_kocienda):
(CommittersTest.integration_test_contributors_kenneth_russell):
(CommittersTest.integration_test_contributors_kevin_decker):
(CommittersTest.integration_test_contributors_kevin_mccullough):
(CommittersTest.integration_test_contributors_lars_knoll):
(CommittersTest.integration_test_contributors_lars_weintraub):
(CommittersTest.integration_test_contributors_maciej_stachowiak):
(CommittersTest.integration_test_contributors_mark_rowe):
(CommittersTest.integration_test_contributors_nikolas_zimmermann):
(CommittersTest.integration_test_contributors_oliver_hunt):
(CommittersTest.integration_test_contributors_rniwa):
(CommittersTest.disabled_integration_test_contributors_simon_fraser):
(CommittersTest.integration_test_contributors_steve_falkenburg):
(CommittersTest.integration_test_contributors_sam_weinig):
(CommittersTest.integration_test_contributors_tim_omernick):
(CommittersTest.integration_test_contributors_timothy_hatcher):
(CommittersTest.integration_test_contributors_tor_arne_vestbo):
(CommittersTest.integration_test_contributors_vicki_murley):
(CommittersTest.integration_test_contributors_zack_rusin):

4:17 PM Changeset in webkit [108863] by jamesr@google.com
  • 3 edits in branches/chromium/963/Source/WebCore

Merge 106603 - BMW Car Configuration Page doesn't work (Only manifests in Chromium)
https://bugs.webkit.org/show_bug.cgi?id=77312

Reviewed by Dimitri Glazkov.

When we autogenerated the event factory, we missed the check for
whether touch events were enabled at runtime:
http://trac.webkit.org/changeset/97933/trunk/Source/WebCore/dom/Document.cpp

This patch adds the check back.

Unfortunately, there isn't a testing frame work for
RuntimeEnabledFeatures. The main difficulty is that these static bools
need to be set when WebKit is initialized and can't be changed (which
is why they're not part of WebCore::Settings). To test them properly,
we'd need a testing framework that booted up WebKit for each test.

We could test this particular change (which doesn't need the bool to be
constant through the runtime of WebKit), but that would create a
sandtrap for future patches who might thing that this testing framework
can really be used to test RuntimeEnabledFeatures.

The net result is that Chromium is going to end up living with the
non-default codepath for these settings being untested, which will lead
to regressions like this one. If we ened up with a bunch of these
regressions, we'll likely end up with a testing framework similar to
Chromium's browsers_tests, which create a fresh subprocess for each
test.

  • dom/EventFactory.in:
  • dom/make_event_factory.pl:

(defaultItemFactory):
(generateImplementation):

TBR=abarth@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9467023

4:12 PM Changeset in webkit [108862] by dpranke@chromium.org
  • 3 edits in trunk/Tools

webkitpy: should autoinstall coverage
https://bugs.webkit.org/show_bug.cgi?id=79535

Reviewed by Eric Seidel.

We should automatically print the coverage report after the run, too.

  • Scripts/webkitpy/test/main.py:

(Tester._run_tests):

  • Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook.find_module):
(AutoinstallImportHook._install_coverage):

4:03 PM Changeset in webkit [108861] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Limit WebGL Errors in Console to 10 per context
https://bugs.webkit.org/show_bug.cgi?id=79387

Patch by Gregg Tavares <gman@google.com> on 2012-02-24
Reviewed by Kenneth Russell.

Some apps generated enough errors to overload
the Dev Tools so limit the number of errors.
For a correct app there should never be any
errors so seeing the first few should be enough
to debug.

No new tests as no new functionality

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContextErrorMessageCallback::onErrorMessage):
(WebCore::WebGLRenderingContext::WebGLRenderingContext):
(WebCore::WebGLRenderingContext::initializeNewContext):
(WebCore::WebGLRenderingContext::printGLErrorToConsole):
(WebCore::WebGLRenderingContext::synthesizeGLError):

  • html/canvas/WebGLRenderingContext.h:

(WebGLRenderingContext):

3:57 PM Changeset in webkit [108860] by jamesr@google.com
  • 6 edits
    2 moves in trunk/Source

[chromium] WebKit::setColorNames is a client API
https://bugs.webkit.org/show_bug.cgi?id=79539

Reviewed by Darin Fisher.

Source/Platform:

  • Platform.gypi:
  • chromium/public/WebColor.h:

(WebKit):

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebColorName.h: Renamed from Source/Platform/chromium/public/WebColorName.h.

(WebKit):

  • public/platform/WebColorName.h:
  • src/WebColor.cpp:
3:57 PM Changeset in webkit [108859] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, mark fast/files/workers tests as flaky crashers
https://bugs.webkit.org/show_bug.cgi?id=79540

  • platform/chromium/test_expectations.txt:
3:55 PM Changeset in webkit [108858] by msaboff@apple.com
  • 11 edits in trunk

ASSERT(position < 0) in JSC::Yarr::Interpreter::InputStream::readChecked
https://bugs.webkit.org/show_bug.cgi?id=73728

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Fixed the mixing of signed and unsigned character indeces in YARR
interpreter.

  • runtime/RegExp.cpp:

(JSC::RegExp::match): Added code to check for match longer than 231 and
return no match after resetting the offsets.

  • yarr/YarrInterpreter.cpp: Changed to use unsigned for all character index

handling except when matching back references.
(JSC::Yarr::Interpreter::InputStream::readChecked):
(JSC::Yarr::Interpreter::InputStream::checkInput):
(JSC::Yarr::Interpreter::InputStream::uncheckInput):
(JSC::Yarr::Interpreter::InputStream::atStart):
(JSC::Yarr::Interpreter::InputStream::atEnd):
(JSC::Yarr::Interpreter::InputStream::isAvailableInput):
(JSC::Yarr::Interpreter::checkCharacter):
(JSC::Yarr::Interpreter::checkCasedCharacter):
(JSC::Yarr::Interpreter::checkCharacterClass):
(JSC::Yarr::Interpreter::tryConsumeBackReference):
(JSC::Yarr::Interpreter::matchAssertionBOL):
(JSC::Yarr::Interpreter::matchAssertionWordBoundary):
(JSC::Yarr::Interpreter::backtrackPatternCharacter):
(JSC::Yarr::Interpreter::backtrackPatternCasedCharacter):
(JSC::Yarr::Interpreter::matchCharacterClass):
(JSC::Yarr::Interpreter::backtrackCharacterClass):
(JSC::Yarr::Interpreter::matchParenthesesOnceBegin):
(JSC::Yarr::Interpreter::matchDisjunction):
(JSC::Yarr::Interpreter::interpret):
(JSC::Yarr::ByteCompiler::assertionBOL):
(JSC::Yarr::ByteCompiler::assertionEOL):
(JSC::Yarr::ByteCompiler::assertionWordBoundary):
(JSC::Yarr::ByteCompiler::atomPatternCharacter):
(JSC::Yarr::ByteCompiler::atomCharacterClass):
(JSC::Yarr::ByteCompiler::atomBackReference):
(JSC::Yarr::ByteCompiler::atomParenthesesOnceBegin):
(JSC::Yarr::ByteCompiler::atomParenthesesTerminalBegin):
(JSC::Yarr::ByteCompiler::atomParenthesesSubpatternBegin):
(JSC::Yarr::ByteCompiler::atomParentheticalAssertionEnd):
(JSC::Yarr::ByteCompiler::emitDisjunction):

  • yarr/YarrInterpreter.h:

Source/WebCore:

No new tests, refactored usage of JSC::Yarr interpreter.
Should be covered by existing tests.

Changed WebCore callers of JSC::Yarr:Interpreter::interpret() to match the
new signature with unsigned offsets.

  • inspector/ContentSearchUtils.cpp:

(WebCore::ContentSearchUtils::findMagicComment):

  • platform/text/RegularExpression.cpp:

(WebCore::RegularExpression::match):

LayoutTests:

Updated test for change. Test is from defect.

  • fast/regex/overflow-expected.txt:
  • fast/regex/script-tests/overflow.js:
3:49 PM Changeset in webkit [108857] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

onclick is not reliable for transformed SVG elements
https://bugs.webkit.org/show_bug.cgi?id=34714

Patch by Hans Muller <hmuller@adobe.com> on 2012-02-24
Reviewed by Dirk Schulze.

Source/WebCore:

Use FloatPoints in RenderSVGRoot::nodeAtPoint() when converting the incoming
point to local coordinates.

Test: svg/hittest/svg-small-viewbox.xhtml

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::nodeAtPoint):

LayoutTests:

New svg-small-viewbox test checks that elementFromPoint() works correctly with SVG
elements defined within a 1x1 viewbox.

Revised select-textLength-spacing-squeeze-2.svg to avoid a corner-case,
removed unnecessary -1 adjustment of absEndPos.x from SelectionTestCase.js.

  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-2-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
  • svg/hittest/svg-small-viewbox-expected.txt: Added.
  • svg/hittest/svg-small-viewbox.xhtml: Added.
  • svg/text/resources/SelectionTestCase.js:

(selectRange):

  • svg/text/select-textLength-spacing-squeeze-2.svg:
3:35 PM Changeset in webkit [108856] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed, build fix for builds where the DFG is disabled but the LLInt is
enabled.

  • llint/LLIntOfflineAsmConfig.h:
  • llint/LowLevelInterpreter.asm:
3:24 PM Changeset in webkit [108855] by jchaffraix@webkit.org
  • 17 edits
    4 adds in trunk

Implement limited parsing of -webkit-grid-column and -webkit-grid-row
https://bugs.webkit.org/show_bug.cgi?id=79151

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/css-grid-layout/grid-item-column-row-get-set.html

This change implements a subset of the grammar:

-webkit-grid-{row|column} := <integer> | 'auto'

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Added the new files to our build systems.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForGridPosition): Check that we have the right translated grammar
(this function will be more useful once we implement more of the grammar).
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
Added handling for the new properties.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
Allow only 'auto' or <integer>.

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):
grid-colum and grid-row are not inherited.

  • css/CSSPropertyNames.in:

Added the 2 new properties.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleGridItemData.cpp: Added.

(WebCore::StyleGridItemData::StyleGridItemData):

  • rendering/style/StyleGridItemData.h: Added.

(StyleGridItemData):
(WebCore::StyleGridItemData::create):
(WebCore::StyleGridItemData::copy):
(WebCore::StyleGridItemData::operator==):
(WebCore::StyleGridItemData::operator!=):
Implemented the minimum working class.

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

(StyleRareNonInheritedData):
Added StyleGridItemData to the class StyleRareNonInheritedData.

LayoutTests:

  • fast/css-grid-layout/grid-item-column-row-get-set-expected.txt: Added.
  • fast/css-grid-layout/grid-item-column-row-get-set.html: Added.
3:18 PM Changeset in webkit [108854] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Remove expectations for nonexistent tests.

Make --lint-test-files run clean again for Chromium.

  • platform/chromium/test_expectations.txt:
3:16 PM WebKitIDL edited by arv@chromium.org
Fix documentation for InterfaceName (diff)
3:03 PM Changeset in webkit [108853] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Fix copypasta in build-webkit's --vibration option description
https://bugs.webkit.org/show_bug.cgi?id=79528

Patch by Pablo Flouret <pablof@motorola.com> on 2012-02-24
Reviewed by Andreas Kling.

  • Scripts/build-webkit:
2:57 PM WebKitGTK/KeepingTheTreeGreen edited by adamk@chromium.org
(diff)
2:56 PM Changeset in webkit [108852] by jsbell@chromium.org
  • 12 edits in trunk

IndexedDB: IDBObjectStore.count() and IDBIndex.count() should accept key argument
https://bugs.webkit.org/show_bug.cgi?id=79422

Reviewed by Tony Chang.

Source/WebCore:

Tests: storage/indexeddb/index-count.html

storage/indexeddb/objectstore-count.html

  • storage/IDBIndex.cpp:

(WebCore::IDBIndex::count):
(WebCore):

  • storage/IDBIndex.h:

(WebCore::IDBIndex::count):
(IDBIndex):

  • storage/IDBIndex.idl:
  • storage/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::deleteFunction):
(WebCore::IDBObjectStore::count):
(WebCore):

  • storage/IDBObjectStore.h:

(WebCore::IDBObjectStore::count):
(IDBObjectStore):

  • storage/IDBObjectStore.idl:

LayoutTests:

  • storage/indexeddb/index-count-expected.txt:
  • storage/indexeddb/index-count.html:
  • storage/indexeddb/objectstore-count-expected.txt:
  • storage/indexeddb/objectstore-count.html:
2:54 PM Changeset in webkit [108851] by aestes@apple.com
  • 3 edits in trunk/Source/WebKit2

REGRESSION (r108730): Webkit nightlies fails to start due to WKPreferencesGetSuppressIncrementalRendering renaming
https://bugs.webkit.org/show_bug.cgi?id=79515

Reviewed by Alexey Proskuryakov.

Some versions of Safari contain call sites to two functions in WebKit2
that were removed in r108730. Restore these two functions so that these
versions of Safari can be used with WebKit nightly builds.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetSuppressIncrementalRendering):
(WKPreferencesGetSuppressIncrementalRendering):

  • UIProcess/API/C/WKPreferences.h:
2:46 PM Changeset in webkit [108850] by beidson@apple.com
  • 3 edits in trunk/Source/WebKit/mac

<rdar://problem/10805709> and https://bugs.webkit.org/show_bug.cgi?id=79421
Need a WK1 Mac API to filter which subframes go into WebArchives as they are created

Reviewed by Sam Weinig (with additional comments by Adam Roben)

Add webArchiveByFilteringSubframes: which takes a callback block:

  • DOM/WebDOMOperationsPrivate.h:

Add FrameFilter that adapts the block, and use it to implement the new SPI:

  • DOM/WebDOMOperations.mm:

(WebFrameFilter):
(WebFrameFilter::WebFrameFilter):
(WebFrameFilter::~WebFrameFilter):
(WebFrameFilter::shouldIncludeSubframe):
(-[DOMNode webArchiveByFilteringSubframes:]):

2:39 PM Changeset in webkit [108849] by abarth@webkit.org
  • 5 edits
    1 move in trunk/Source/WebCore

Move mediastream into Modules/mediastream
https://bugs.webkit.org/show_bug.cgi?id=79517

Reviewed by Eric Seidel.

This patch moves the mediastream directory into Modules. mediastream
is a self-contained feature and is a good candidate for being a module.

  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • Modules/mediastream: Copied from Source/WebCore/mediastream.
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • mediastream: Removed.
  • mediastream/DOMWindowMediaStream.idl: Removed.
  • mediastream/LocalMediaStream.cpp: Removed.
  • mediastream/LocalMediaStream.h: Removed.
  • mediastream/LocalMediaStream.idl: Removed.
  • mediastream/MediaStream.cpp: Removed.
  • mediastream/MediaStream.h: Removed.
  • mediastream/MediaStream.idl: Removed.
  • mediastream/MediaStreamEvent.cpp: Removed.
  • mediastream/MediaStreamEvent.h: Removed.
  • mediastream/MediaStreamEvent.idl: Removed.
  • mediastream/MediaStreamList.cpp: Removed.
  • mediastream/MediaStreamList.h: Removed.
  • mediastream/MediaStreamList.idl: Removed.
  • mediastream/MediaStreamRegistry.cpp: Removed.
  • mediastream/MediaStreamRegistry.h: Removed.
  • mediastream/MediaStreamTrack.cpp: Removed.
  • mediastream/MediaStreamTrack.h: Removed.
  • mediastream/MediaStreamTrack.idl: Removed.
  • mediastream/MediaStreamTrackList.cpp: Removed.
  • mediastream/MediaStreamTrackList.h: Removed.
  • mediastream/MediaStreamTrackList.idl: Removed.
  • mediastream/NavigatorMediaStream.cpp: Removed.
  • mediastream/NavigatorMediaStream.h: Removed.
  • mediastream/NavigatorMediaStream.idl: Removed.
  • mediastream/NavigatorUserMediaError.h: Removed.
  • mediastream/NavigatorUserMediaError.idl: Removed.
  • mediastream/NavigatorUserMediaErrorCallback.h: Removed.
  • mediastream/NavigatorUserMediaErrorCallback.idl: Removed.
  • mediastream/NavigatorUserMediaSuccessCallback.h: Removed.
  • mediastream/NavigatorUserMediaSuccessCallback.idl: Removed.
  • mediastream/PeerConnection.cpp: Removed.
  • mediastream/PeerConnection.h: Removed.
  • mediastream/PeerConnection.idl: Removed.
  • mediastream/SignalingCallback.h: Removed.
  • mediastream/SignalingCallback.idl: Removed.
  • mediastream/UserMediaClient.h: Removed.
  • mediastream/UserMediaController.cpp: Removed.
  • mediastream/UserMediaController.h: Removed.
  • mediastream/UserMediaRequest.cpp: Removed.
  • mediastream/UserMediaRequest.h: Removed.
2:38 PM Changeset in webkit [108848] by jamesr@google.com
  • 5 edits
    2 copies in trunk/Source

[chromium] Move WebGraphicsContext3D header into the Platform directory
https://bugs.webkit.org/show_bug.cgi?id=79301

Reviewed by Adam Barth.

Moves WebGraphicsContext3D and WebNonCopyable (which WGC3D depends on).

Source/Platform:

  • Platform.gypi:
  • chromium/public/WebGraphicsContext3D.h: Copied from Source/WebKit/chromium/public/platform/WebGraphicsContext3D.h.

(WebKit):
(WebGraphicsContext3D):
(ActiveInfo):
(WebKit::WebGraphicsContext3D::Attributes::Attributes):
(Attributes):
(WebGraphicsContextLostCallback):
(WebKit::WebGraphicsContext3D::WebGraphicsContextLostCallback::~WebGraphicsContextLostCallback):
(WebGraphicsErrorMessageCallback):
(WebKit::WebGraphicsContext3D::WebGraphicsErrorMessageCallback::~WebGraphicsErrorMessageCallback):
(WebGraphicsSwapBuffersCompleteCallbackCHROMIUM):
(WebKit::WebGraphicsContext3D::WebGraphicsSwapBuffersCompleteCallbackCHROMIUM::~WebGraphicsSwapBuffersCompleteCallbackCHROMIUM):
(WebGraphicsMemoryAllocationChangedCallbackCHROMIUM):
(WebKit::WebGraphicsContext3D::WebGraphicsMemoryAllocationChangedCallbackCHROMIUM::~WebGraphicsMemoryAllocationChangedCallbackCHROMIUM):
(WebKit::WebGraphicsContext3D::~WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::setMemoryAllocationChangedCallbackCHROMIUM):
(WebKit::WebGraphicsContext3D::setParentContext):
(WebKit::WebGraphicsContext3D::setSwapBuffersCompleteCallbackCHROMIUM):
(WebKit::WebGraphicsContext3D::rateLimitOffscreenContextCHROMIUM):
(WebKit::WebGraphicsContext3D::setContextLostCallback):
(WebKit::WebGraphicsContext3D::setErrorMessageCallback):
(WebKit::WebGraphicsContext3D::getGraphicsResetStatusARB):
(WebKit::WebGraphicsContext3D::getTranslatedShaderSourceANGLE):
(WebKit::WebGraphicsContext3D::texImageIOSurface2DCHROMIUM):
(WebKit::WebGraphicsContext3D::texStorage2DEXT):
(WebKit::WebGraphicsContext3D::onCreateGrGLInterface):

  • chromium/public/WebNonCopyable.h: Copied from Source/WebKit/chromium/public/platform/WebNonCopyable.h.

(WebKit):
(WebNonCopyable):
(WebKit::WebNonCopyable::WebNonCopyable):
(WebKit::WebNonCopyable::~WebNonCopyable):

Source/WebKit/chromium:

  • public/platform/WebGraphicsContext3D.h:
  • public/platform/WebNonCopyable.h:
2:24 PM Changeset in webkit [108847] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Overhanging floats not removed from new flex box.
https://bugs.webkit.org/show_bug.cgi?id=79522

Reviewed by Ojan Vafai.

Source/WebCore:

Similar to r69476.

Test: fast/flexbox/overhanging-floats-not-removed-crash.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):

LayoutTests:

  • fast/flexbox/overhanging-floats-not-removed-crash-expected.txt: Added.
  • fast/flexbox/overhanging-floats-not-removed-crash.html: Added.
2:15 PM Changeset in webkit [108846] by rniwa@webkit.org
  • 1 edit
    1 move in trunk/PerformanceTests

Rename dom*_*attributes.html to dom*-*attributes.html to follow the WebKit convention.

  • Bindings/dom-attributes.html: Copied from PerformanceTests/Bindings/dom_attributes.html.
  • Bindings/dom_attributes.html: Removed.
2:09 PM Changeset in webkit [108845] by rniwa@webkit.org
  • 2 edits in trunk

Increment perf-o-matic version.

  • Websites/webkit-perf.appspot.com/app.yaml:
1:40 PM Changeset in webkit [108844] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Adding myself to ScrollingCoordinator watchlist
https://bugs.webkit.org/show_bug.cgi?id=79525

Patch by Antonio Gomes <agomes@rim.com> on 2012-02-24
Reviewed by Rob Buis.

  • Scripts/webkitpy/common/config/watchlist:
1:38 PM Changeset in webkit [108843] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebCore

[WinCairo] Compute more acurate font heights.
https://bugs.webkit.org/show_bug.cgi?id=79524

Reviewed by Adam Roben.

Adjust font handling as suggested by Lynn Neir to use the proper
xHeight value for the font, rather than the fall-back guess
used in the current code.

css1/text_properties/line_height.html

  • platform/graphics/win/SimpleFontDataCairoWin.cpp:

(WebCore::SimpleFontData::platformInit): Properly initialize a

few elements.

(WebCore::SimpleFontData::platformWidthForGlyph): Use the Cairo

cairo_scaled_font_text_extents call, rather than attempting
to compute the value from ::GetGlyphOutline.

1:31 PM Changeset in webkit [108842] by fpizlo@apple.com
  • 15 edits in trunk/Source/JavaScriptCore

DFG should be able to handle variables getting captured
https://bugs.webkit.org/show_bug.cgi?id=79469

Reviewed by Oliver Hunt.

Made captured variables work by placing a Flush on the SetLocal and
forcing the emission of the GetLocal even if copy propagation tells us
who has the value.

Changed the CFA and various prediction codes to understand that we can't
really prove anything about captured variables. Well, we could in the
future by just looking at what side effects are happening, but in this
first cut we just assume that we can't reason about captured variables.

Also added a mode where the DFG pretends that all variables and arguments
got captured. Used this mode to harden the code.

This is performance neutral. Capturing all variables is a slow down, but
not too big of one. This seems to predict that when we add activation
support, the amount of speed benefit we'll get from increased coverage
will far outweigh the pessimism that we'll have to endure for captured
variables.

  • bytecode/CodeType.h:

(JSC::codeTypeToString):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::merge):

  • dfg/DFGAbstractState.h:

(AbstractState):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::flushArgument):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGCapabilities.h:

(JSC::DFG::mightInlineFunctionForCall):
(JSC::DFG::mightInlineFunctionForConstruct):

  • dfg/DFGCommon.h:
  • dfg/DFGGraph.h:

(JSC::DFG::Graph::needsActivation):
(Graph):
(JSC::DFG::Graph::argumentIsCaptured):
(JSC::DFG::Graph::localIsCaptured):
(JSC::DFG::Graph::isCaptured):

  • dfg/DFGNode.h:

(JSC::DFG::Node::shouldGenerate):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):

  • dfg/DFGSpeculativeJIT.cpp:

(DFG):
(JSC::DFG::ValueSource::dump):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:

(ValueSource):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGVirtualRegisterAllocationPhase.cpp:

(JSC::DFG::VirtualRegisterAllocationPhase::run):

1:10 PM Changeset in webkit [108841] by barraclough@apple.com
  • 12 edits in trunk

Should not allow malformed \x escapes
https://bugs.webkit.org/show_bug.cgi?id=79462

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • parser/Lexer.cpp:

(JSC::::parseString):
(JSC::::parseStringSlowCase):

  • Prohibit malformed '\x' escapes
  • tests/mozilla/ecma/Array/15.4.5.1-1.js:
  • tests/mozilla/ecma/LexicalConventions/7.7.4.js:
  • tests/mozilla/ecma_2/RegExp/hex-001.js:
  • tests/mozilla/js1_2/regexp/hexadecimal.js:
    • Remove erroneous test cases (correct behaviour is tested by LayoutTests/sputnik).

LayoutTests:

  • fast/regex/script-tests/pcre-test-1.js:
    • Fix bad escapes in test case.
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A4.3_T6-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A6.1_T4-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A6.2_T1-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A6.2_T2-expected.txt:
    • Check in passing results.
1:08 PM Changeset in webkit [108840] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Purge Skia's GPU texture cache using GL_CHROMIUM_gpu_memory_manager
https://bugs.webkit.org/show_bug.cgi?id=78265

Patch by Michal Mocny <mmocny@google.com> on 2012-02-24
Reviewed by Stephen White.

  • src/GraphicsContext3DChromium.cpp:

(GrMemoryAllocationChangedCallback):
(WebCore::GrMemoryAllocationChangedCallback::GrMemoryAllocationChangedCallback):
(WebCore::GrMemoryAllocationChangedCallback::onGpuMemoryAllocationChanged):
(WebCore):
(WebCore::GraphicsContext3DPrivate::grContext):

1:06 PM Changeset in webkit [108839] by enne@google.com
  • 10 edits in trunk/LayoutTests

Fix flaky tests by removing call to dumpResourceResponseMIMETypes
https://bugs.webkit.org/show_bug.cgi?id=79505

Reviewed by Daniel Bates.

It appears to be a race condition (on Chromium at least) between when
script executes and the style sheet resource response occurs. This
prevents some of the text to be output if the response occurs before
the call to set the flag to dump responses. Since the tests themselves
already test the results of loading stylesheets properly, this extra
text is superfluous and can be removed.

This change modifies all tests using link-load-utilities.js to dump
stylesheet resource responses. Other tests are using
dumpResponseResponseMIMEType, but for things other than stylesheets.

  • fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-existent-and-non-existent-import-expected.txt:
  • fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-non-existent-import-expected.txt:
  • fast/dom/HTMLLinkElement/link-onload-before-page-load-expected.txt:
  • fast/dom/HTMLLinkElement/link-onload-expected.txt:
  • fast/dom/HTMLLinkElement/link-onload-stylesheet-with-import-expected.txt:
  • fast/dom/HTMLLinkElement/link-onload2-expected.txt:
  • fast/dom/HTMLLinkElement/programmatically-add-link-with-onload-handler-expected.txt:
  • fast/dom/HTMLLinkElement/resources/link-load-utilities.js:
  • fast/dom/HTMLStyleElement/style-onerror-with-existent-and-non-existent-import-expected.txt:
12:45 PM Changeset in webkit [108838] by darin@chromium.org
  • 2 edits in trunk/Tools

Update watchlist for ChromiumPublicApi to include Platform/chromium/public/

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/config/watchlist:
12:42 PM Changeset in webkit [108837] by dpranke@chromium.org
  • 2 edits in trunk/Tools

webkitpy: config_unittest is sensitive to other tests that might've already run
https://bugs.webkit.org/show_bug.cgi?id=79382

Reviewed by Adam Barth.

If another test runs prior to config_unittest and pokes the
cached configuration, the first test in config_unittest might
fail; the tearDown() will then allow subsequent tests to pass.
Clearing the configuration prior to each test makes things
slightly slower but safer.

  • Scripts/webkitpy/layout_tests/port/config_unittest.py:

(ConfigTest.setUp):

12:36 PM Changeset in webkit [108836] by ddkilzer@apple.com
  • 2 edits in trunk/Tools

Use xcrun to find compiler paths for Generate Derived Sources build phase script
<http://webkit.org/b/79512>

Reviewed by Dan Bernstein.

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

(Generate Derived Sources): Use xcrun to find the path to the
compiler since that works on both iOS and OS X.

12:07 PM Changeset in webkit [108835] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

Make fast/canvas/canvas-strokePath-shadow.html allow for pixel tolerance
https://bugs.webkit.org/show_bug.cgi?id=79488

Patch by Elliot Poger <epoger@google.com> on 2012-02-24
Reviewed by Adam Barth.

  • fast/canvas/script-tests/canvas-strokePath-shadow.js:

(shouldBeAlmost):

  • fast/js/resources/js-test-pre.js:

(shouldBeCloseTo):

11:41 AM Changeset in webkit [108834] by timothy_horton@apple.com
  • 5 edits in trunk/Source/WebCore

Infinite repaint loop with SVGImageCache and deferred repaint timers
https://bugs.webkit.org/show_bug.cgi?id=78315
<rdar://problem/10651634>

Reviewed by Dean Jackson.

Only defer image redraw on a timer if we're in layout. This breaks
the repaint loop while still preventing us from drawing inside layout.

No new tests, as the problem only occurs in a nonstandard configuration.

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::draw):
(WebCore::SVGImage::frameView):
(WebCore):

  • svg/graphics/SVGImage.h:

(WebCore):

  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::imageContentChanged):
(WebCore::SVGImageCache::redraw):
(WebCore::SVGImageCache::redrawTimerFired):
(WebCore):

  • svg/graphics/SVGImageCache.h:

(SVGImageCache):

11:40 AM Changeset in webkit [108833] by jamesr@google.com
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Remove deprecated and unused WebGraphicsContext3D::initialize call
https://bugs.webkit.org/show_bug.cgi?id=79296

Reviewed by Kenneth Russell.

The old way to initialize a WebGraphicsContext3D from inside WebKit was to call initialize() on it with a
WebView*. The new way to do this is via the WebViewClient interface. This deletes the old, unused path.

  • public/platform/WebGraphicsContext3D.h:

(WebKit):

  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/FakeWebGraphicsContext3D.h:
11:39 AM Changeset in webkit [108832] by timothy_horton@apple.com
  • 5 edits
    10 adds
    10 deletes in trunk

SVG should be supported in Dashboard compatibility mode
https://bugs.webkit.org/show_bug.cgi?id=78322
<rdar://problem/5861278>

Reviewed by Dean Jackson.

Enable SVG elements inside Dashboard, more or less reverting r21418.

Tests: http/tests/xmlhttprequest/svg-created-by-xhr-allowed-in-dashboard.html

svg/custom/embedded-svg-allowed-in-dashboard.xml
svg/custom/manually-parsed-embedded-svg-allowed-in-dashboard.html
svg/custom/manually-parsed-svg-allowed-in-dashboard.html
svg/custom/svg-allowed-in-dashboard-object.html

  • dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createDocument):

  • dom/Document.cpp:

(WebCore::Document::importNode):

  • dom/make_names.pl:

(printFactoryCppFile):

Change tests that ensured that SVG didn't work in Dashboard to instead test that it does!

  • http/tests/xmlhttprequest/svg-created-by-xhr-allowed-in-dashboard-expected.txt: Added.
  • http/tests/xmlhttprequest/svg-created-by-xhr-allowed-in-dashboard.html: Renamed from LayoutTests/http/tests/xmlhttprequest/svg-created-by-xhr-disallowed-in-dashboard.html.
  • http/tests/xmlhttprequest/svg-created-by-xhr-disallowed-in-dashboard-expected.txt: Removed.
  • svg/custom/embedded-svg-allowed-in-dashboard-expected.txt: Added.
  • svg/custom/embedded-svg-allowed-in-dashboard.xml: Renamed from LayoutTests/svg/custom/embedded-svg-disallowed-in-dashboard.xml.
  • svg/custom/embedded-svg-disallowed-in-dashboard-expected.txt: Removed.
  • svg/custom/manually-parsed-embedded-svg-allowed-in-dashboard-expected.txt: Added.
  • svg/custom/manually-parsed-embedded-svg-allowed-in-dashboard.html: Renamed from LayoutTests/svg/custom/manually-parsed-embedded-svg-disallowed-in-dashboard.html.
  • svg/custom/manually-parsed-embedded-svg-disallowed-in-dashboard-expected.txt: Removed.
  • svg/custom/manually-parsed-svg-allowed-in-dashboard-expected.txt: Added.
  • svg/custom/manually-parsed-svg-allowed-in-dashboard.html: Renamed from LayoutTests/svg/custom/manually-parsed-svg-disallowed-in-dashboard.html.
  • svg/custom/manually-parsed-svg-disallowed-in-dashboard-expected.txt: Removed.
  • svg/custom/svg-allowed-in-dashboard-object-expected.txt: Added.
  • svg/custom/svg-allowed-in-dashboard-object.html: Renamed from LayoutTests/svg/custom/svg-disallowed-in-dashboard-object.html.
  • svg/custom/svg-disallowed-in-dashboard-object-expected.txt: Removed.
11:35 AM Changeset in webkit [108831] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

Expose a setting to exempt media playback from user gesture requirement after a user gesture is initiated on loading/playing a media
https://bugs.webkit.org/show_bug.cgi?id=79167

Patch by Min Qin <qinmin@google.com> on 2012-02-24
Reviewed by Adam Barth.

Source/WebCore:

Test: media/video-play-require-user-gesture.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::load):
(WebCore::HTMLMediaElement::play):
(WebCore::HTMLMediaElement::removeBehaviorsRestrictionsAfterFirstUserGesture):
(WebCore):

  • html/HTMLMediaElement.h:

(HTMLMediaElement):

  • testing/Internals.cpp:

(WebCore::Internals::setMediaPlaybackRequiresUserGesture):
(WebCore):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

LayoutTests:

  • media/video-play-require-user-gesture-expected.txt: Added.
  • media/video-play-require-user-gesture.html: Added.
11:32 AM Changeset in webkit [108830] by abarth@webkit.org
  • 12 edits in trunk/Source/WebCore

DOMWindow*.idl should have had the same license block as DOMWindow.idl did originally
https://bugs.webkit.org/show_bug.cgi?id=79507

Reviewed by Alexey Proskuryakov.

In moving pieces of DOMWindow.idl into separate files, we mistakenly
changed some of the license blocks. All these files should have a
license block that matches the file that originally contained the code.

  • Modules/intents/DOMWindowIntents.idl:
  • fileapi/DOMWindowFileSystem.idl:
  • html/DOMWindowHTML.idl:
  • html/canvas/DOMWindowWebGL.idl:
  • mediastream/DOMWindowMediaStream.idl:
  • storage/DOMWindowSQLDatabase.idl:
  • svg/DOMWindowSVG.idl:
  • webaudio/DOMWindowWebAudio.idl:
  • websockets/DOMWindowWebSocket.idl:
  • workers/DOMWindowWorker.idl:
  • xml/DOMWindowXML.idl:
11:28 AM Changeset in webkit [108829] by jamesr@google.com
  • 14 edits
    11 copies in trunk/Source

[chromium] Move Web*Layer* headers into Platform
https://bugs.webkit.org/show_bug.cgi?id=79425

Reviewed by Adam Barth.

Source/Platform:

This moves the Web*Layer* headers and their dependencies from WebKit/chromium/public/platform/ into
Platform/chromium/public.

  • Platform.gypi:
  • chromium/public/WebCanvas.h: Copied from Source/WebKit/chromium/public/platform/WebCanvas.h.

(WebKit):

  • chromium/public/WebColor.h: Copied from Source/WebKit/chromium/public/platform/WebColor.h.

(WebKit):

  • chromium/public/WebColorName.h: Copied from Source/WebKit/chromium/public/platform/WebColorName.h.

(WebKit):

  • chromium/public/WebContentLayer.h: Copied from Source/WebKit/chromium/public/platform/WebContentLayer.h.

(WebKit):
(WebContentLayer):
(WebKit::WebContentLayer::WebContentLayer):
(WebKit::WebContentLayer::~WebContentLayer):
(WebKit::WebContentLayer::operator=):

  • chromium/public/WebContentLayerClient.h: Copied from Source/WebKit/chromium/public/platform/WebContentLayerClient.h.

(WebKit):
(WebContentLayerClient):
(WebKit::WebContentLayerClient::~WebContentLayerClient):

  • chromium/public/WebExternalTextureLayer.h: Copied from Source/WebKit/chromium/public/platform/WebExternalTextureLayer.h.

(WebKit):
(WebExternalTextureLayer):
(WebKit::WebExternalTextureLayer::WebExternalTextureLayer):
(WebKit::WebExternalTextureLayer::~WebExternalTextureLayer):
(WebKit::WebExternalTextureLayer::operator=):

  • chromium/public/WebLayer.h: Copied from Source/WebKit/chromium/public/platform/WebLayer.h.

(WebKit):
(WebLayer):
(WebKit::WebLayer::WebLayer):
(WebKit::WebLayer::~WebLayer):
(WebKit::WebLayer::operator=):
(WebKit::WebLayer::isNull):
(WebKit::WebLayer::to):
(WebKit::WebLayer::toConst):
(WebKit::WebLayer::unwrap):
(WebKit::WebLayer::constUnwrap):
(WebKit::operator==):
(WebKit::operator!=):

  • chromium/public/WebLayerTreeView.h: Copied from Source/WebKit/chromium/public/platform/WebLayerTreeView.h.

(WebCore):
(WebKit):
(WebLayerTreeView):
(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):
(WebKit::WebLayerTreeView::WebLayerTreeView):
(WebKit::WebLayerTreeView::~WebLayerTreeView):
(WebKit::WebLayerTreeView::operator=):
(WebKit::operator==):
(WebKit::operator!=):

  • chromium/public/WebLayerTreeViewClient.h: Copied from Source/WebKit/chromium/public/platform/WebLayerTreeViewClient.h.

(WebKit):
(WebLayerTreeViewClient):
(WebKit::WebLayerTreeViewClient::~WebLayerTreeViewClient):

  • chromium/public/WebPrivatePtr.h: Copied from Source/WebKit/chromium/public/platform/WebPrivatePtr.h.

(WebKit):
(WebPrivatePtr):
(WebKit::WebPrivatePtr::WebPrivatePtr):
(WebKit::WebPrivatePtr::~WebPrivatePtr):
(WebKit::WebPrivatePtr::isNull):
(WebKit::WebPrivatePtr::reset):
(WebKit::WebPrivatePtr::operator=):
(WebKit::WebPrivatePtr::get):
(WebKit::WebPrivatePtr::operator->):
(WebKit::WebPrivatePtr::assign):

  • chromium/public/WebSolidColorLayer.h: Copied from Source/WebKit/chromium/public/platform/WebSolidColorLayer.h.

(WebKit):
(WebSolidColorLayer):

Source/WebKit/chromium:

Adds forwarding headers for Web*Layer* APIs and their dependencies. The forwarding headers for the Web*Layer*
APIs are temporary since Web*Layer* is not exposed in the client interface. The other headers (such as
WebColor) are exposed in both the client and platform APIs, so the forwarding headers are permanent, although we
might move them back down to public/ at some point.

  • public/platform/WebCanvas.h:
  • public/platform/WebColor.h:
  • public/platform/WebColorName.h:
  • public/platform/WebContentLayer.h:
  • public/platform/WebContentLayerClient.h:
  • public/platform/WebExternalTextureLayer.h:
  • public/platform/WebLayer.h:
  • public/platform/WebLayerTreeView.h:
  • public/platform/WebLayerTreeViewClient.h:
  • public/platform/WebPrivatePtr.h:
  • public/platform/WebSolidColorLayer.h:
11:27 AM Changeset in webkit [108828] by Lucas Forschler
  • 4 edits in trunk/Source

Versioning.

11:25 AM Changeset in webkit [108827] by Lucas Forschler
  • 1 copy in tags/Safari-535.23

New Tag.

11:22 AM Changeset in webkit [108826] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

Use xcrun to find compiler paths for Generate Derived Sources build phase script
<http://webkit.org/b/79512>

Reviewed by Mark Rowe.

  • WebCore.xcodeproj/project.pbxproj:

(Generate Derived Sources): Use xcrun to find the path to the
compiler since that works on both iOS and OS X.

11:06 AM Changeset in webkit [108825] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Crash in TileCache::revalidateTiles
https://bugs.webkit.org/show_bug.cgi?id=79510
<rdar://problem/10928035>

Reviewed by Sam Weinig.

Handle the tile cache layer's PlatformCALayer going away before the
CALayer itself has been deallocated.

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::revalidateTiles):

11:06 AM Changeset in webkit [108824] by jamesr@google.com
  • 2 edits in trunk/Tools

Create a watchlist for ScrollingCoordinator changes
https://bugs.webkit.org/show_bug.cgi?id=79511

Reviewed by Anders Carlsson.

  • Scripts/webkitpy/common/config/watchlist:
11:00 AM Changeset in webkit [108823] by commit-queue@webkit.org
  • 1 edit
    2 deletes in trunk/LayoutTests

Remove spurious mac-specific tests
https://bugs.webkit.org/show_bug.cgi?id=75091

Patch by Philip Rogers <pdr@google.com> on 2012-02-24
Reviewed by Daniel Bates.

  • platform/mac/svg/text/text-rescale.html: Removed.
  • platform/mac/svg/text/text-viewbox-rescale.html: Removed.
10:51 AM Changeset in webkit [108822] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebKit2

requestPermission callback not invoked if the WebProcess doesn't have to ask the UI Process
about the permission level.
https://bugs.webkit.org/show_bug.cgi?id=79494

Reviewed by Jon Honeycutt.

Invoke the callback in the case where the permission level is known and no message is sent
to the UI Process.

  • WebProcess/Notifications/NotificationPermissionRequestManager.cpp:

(WebKit::NotificationPermissionRequestManager::startRequest):

10:51 AM Changeset in webkit [108821] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

[chromium] Have WebFrameImpl::selectionAsMarkup create interchange markup.
https://bugs.webkit.org/show_bug.cgi?id=77307

Patch by Peter Collingbourne <peter@pcc.me.uk> on 2012-02-24
Reviewed by Tony Chang.

This function is currently used to build markup in order to
print the selection, and will also be used to build markup for
the clipboard. Without this change, the markup will refer to
(for example) nonexistent CSS classes and invalid relative
paths and therefore will not be interpreted correctly.

Chromium bug: http://crbug.com/23329

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::selectionAsMarkup):

10:41 AM Changeset in webkit [108820] by dbates@webkit.org
  • 1 edit in trunk/Source/JavaScriptCore/ChangeLog

Fix change log entry for changeset r108819; add bug URL
https://bugs.webkit.org/show_bug.cgi?id=79504

Changeset r108819 is associated with bug #79504.

  • ChangeLog
10:37 AM Changeset in webkit [108819] by dbates@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Substitute ENABLE(CLASSIC_INTERPRETER) for ENABLE(INTERPRETER) in Interpreter.cpp

Reviewed by Oliver Hunt.

There are a few places in Interpreter.cpp that need to be updated to use
ENABLE(CLASSIC_INTERPRETER) following the renaming of ENABLE_INTERPRETER to
ENABLE_CLASSIC_INTERPRETER in changeset <http://trac.webkit.org/changeset/108020>
(https://bugs.webkit.org/show_bug.cgi?id=78791).

  • interpreter/Interpreter.cpp:

(JSC::getLineNumberForCallFrame):
(JSC::getCallerInfo):
(JSC::getSourceURLFromCallFrame):

10:26 AM Changeset in webkit [108818] by eae@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/GNUmakefile.list.am

Merge GNUMakefile from trunk into branch.

10:04 AM Changeset in webkit [108817] by adamk@chromium.org
  • 2 edits in trunk/Source/WebCore

Don't notify the inspector of Node insertions initiated by the parser
https://bugs.webkit.org/show_bug.cgi?id=79388

Reviewed by Adam Barth.

This is part of a series of changes to make ContainerNode's
implementation simpler and more internally consistent.

I don't know of a way to break on parser-initiated insertions,
and the code already doesn't notify on parser-initiated removes
(in ContainerNode::parserRemoveChild).

No new tests, should already be covered by
inspector/debugger/dom-breakpoints.html.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::parserInsertBefore):
(WebCore::ContainerNode::parserAddChild):

9:56 AM Changeset in webkit [108816] by jocelyn.turcotte@nokia.com
  • 10 edits in trunk/Source/WebKit2

[Qt] Signal and property cleanup in QQuickWebView
https://bugs.webkit.org/show_bug.cgi?id=78820

Reviewed by Simon Hausmann.

  • Remove parameters from property change notify signals: titleChanged, urlChanged, iconChanged, loadProgressChanged
  • Rename the parameters of linkHovered to prevent shadoing properties of WebView
  • Rename navigationStateChanged to navigationHistoryChanged
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::_q_onUrlChanged):
(QQuickWebViewPrivate::setIcon):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

  • UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml:
  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::loadProgress):

  • UIProcess/qt/QtWebPageLoadClient.cpp:

(QtWebPageLoadClient::didCommitLoadForFrame):
(QtWebPageLoadClient::didSameDocumentNavigationForFrame):
(QtWebPageLoadClient::didReceiveTitleForFrame):
(QtWebPageLoadClient::setLoadProgress):

  • UIProcess/qt/QtWebPageLoadClient.h:

(QtWebPageLoadClient):

9:50 AM Changeset in webkit [108815] by jocelyn.turcotte@nokia.com
  • 30 edits
    3 adds in trunk/Source

[Qt] API: Unify the loading properties and signals.
https://bugs.webkit.org/show_bug.cgi?id=79486

Reviewed by Simon Hausmann.

Source/WebKit/qt:

  • declarative/plugin.cpp:

(WebKitQmlPlugin::registerTypes):

Source/WebKit2:

  • Remove the canReload signal, instead assume that calling reload in those cases won't have any effect.
  • Replace loadStarted, loadSucceeded and loadFailed by a single signal: loadingChanged. The signal carries an argument with a status and error codes giving the intended context.
  • Use loadingChanged as the notification signal for the property "loading" instead of navigationStateChanged.

Also update all API tests to use the new loading signals and add some utility functions
to track the loading since the new API aims to be more adapted to declarative logic
and the auto tests are using an imperative logic.

  • Target.pri:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::loadDidSucceed):
(QQuickWebViewPrivate::didChangeLoadingState):
(QQuickWebViewPrivate::processDidCrash):
(QQuickWebViewPrivate::didRelaunchProcess):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

  • UIProcess/API/qt/qwebloadrequest.cpp: Added.

(QWebLoadRequestPrivate):
(QWebLoadRequestPrivate::QWebLoadRequestPrivate):
(QWebLoadRequest::QWebLoadRequest):
(QWebLoadRequest::~QWebLoadRequest):
(QWebLoadRequest::url):
(QWebLoadRequest::status):
(QWebLoadRequest::errorString):
(QWebLoadRequest::errorDomain):
(QWebLoadRequest::errorCode):

  • UIProcess/API/qt/qwebloadrequest_p.h: Added.
  • UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_itemSelector.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_messaging.qml:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_favIconLoad.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_javaScriptDialogs.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadFail.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadHtml.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgress.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgressSignal.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadUrl.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_navigationHistory.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_properties.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_titleChanged.qml:
  • UIProcess/API/qt/tests/qmltests/common/TestWebView.qml: Added.
  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::navigationStatusAtStartup):
(LoadStartedCatcher::LoadStartedCatcher):
(LoadStartedCatcher::onLoadingChanged):
(tst_QQuickWebView::stopEnabledAfterLoadStarted):
(tst_QQuickWebView::loadEmptyPageViewHidden):
(tst_QQuickWebView::loadNonexistentFileUrl):
(tst_QQuickWebView::backAndForward):
(tst_QQuickWebView::reload):
(tst_QQuickWebView::stop):
(tst_QQuickWebView::loadProgress):
(tst_QQuickWebView::showWebView):
(tst_QQuickWebView::multipleWebViewWindows):
(tst_QQuickWebView::multipleWebViews):
(tst_QQuickWebView::scrollRequest):

  • UIProcess/API/qt/tests/util.cpp:

(LoadSpy):
(LoadSpy::LoadSpy):
(LoadSpy::onLoadingChanged):
(waitForLoadSucceeded):
(waitForLoadFailed):

  • UIProcess/API/qt/tests/util.h:
  • UIProcess/qt/QtWebError.h:
  • UIProcess/qt/QtWebPageLoadClient.cpp:

(QtWebPageLoadClient::didStartProvisionalLoadForFrame):
(QtWebPageLoadClient::dispatchLoadFailed):

  • UIProcess/qt/QtWebPageLoadClient.h:

(QtWebPageLoadClient):

9:26 AM Changeset in webkit [108814] by dbates@webkit.org
  • 3 edits in trunk/Source/WebCore

Attempt to fix the Windows and WinCE build after changeset r108809
<http://trac.webkit.org/changeset/108809> (https://bugs.webkit.org/show_bug.cgi?id=38995)

Substitute styleLoadEventSender() for loadEventSender() in HTMLStyleElement.cpp
and substitute linkLoadEventSender() for loadEventSender() in HTMLLinkElement.cpp.

  • html/HTMLLinkElement.cpp:

(WebCore::linkLoadEventSender):
(WebCore::HTMLLinkElement::~HTMLLinkElement):
(WebCore::HTMLLinkElement::dispatchPendingLoadEvents):
(WebCore::HTMLLinkElement::dispatchPendingEvent):
(WebCore::HTMLLinkElement::notifyLoadedSheetAndAllCriticalSubresources):

  • html/HTMLStyleElement.cpp:

(WebCore::styleLoadEventSender):
(WebCore::HTMLStyleElement::~HTMLStyleElement):
(WebCore::HTMLStyleElement::dispatchPendingLoadEvents):
(WebCore::HTMLStyleElement::dispatchPendingEvent):
(WebCore::HTMLStyleElement::notifyLoadedSheetAndAllCriticalSubresources):

9:25 AM Changeset in webkit [108813] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Undo the BUILDING_WTF part of r108808

This broke the build, which is obviously worse than the linker warning it was trying to
solve.

9:21 AM Changeset in webkit [108812] by peter@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Fix Chromium Android build by building HarfBuzzShaperBase.cpp
https://bugs.webkit.org/show_bug.cgi?id=79497

Reviewed by Tony Gentilcore.

The Chromium Android build was broken by revision r108733, as the
HarfBuzzShaperBase.cpp file also should have been included for Android.
Fix the build by including it.

  • WebCore.gyp/WebCore.gyp:
9:02 AM Changeset in webkit [108811] by Philippe Normand
  • 11 edits in trunk/LayoutTests

Unreviewed, GTK SVG rebaseline (from 64-bit Release bot) and
skipping one more fast/dom/shadow test.

  • platform/gtk/Skipped:
  • platform/gtk/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
  • platform/gtk/svg/carto.net/scrollbar-expected.txt:
  • platform/gtk/svg/carto.net/window-expected.txt:
  • platform/gtk/svg/custom/circle-move-invalidation-expected.txt:
  • platform/gtk/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
  • platform/gtk/svg/custom/js-late-gradient-and-object-creation-expected.txt:
  • platform/gtk/svg/custom/js-late-pattern-and-object-creation-expected.txt:
  • platform/gtk/svg/custom/use-detach-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
9:02 AM Changeset in webkit [108810] by yael.aharon@nokia.com
  • 5 edits in trunk/Source/WebCore

[Texmap] Consolidate the common parts of TextureMapperGL::drawTexture
https://bugs.webkit.org/show_bug.cgi?id=79143

Reviewed by Noam Rosenthal.

Combine the two drawTexture methods into one, and extract the part that
could not be combined into its own method.
No new tests. Refactoring only.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore):
(WebCore::TextureMapperGL::drawTexture):

  • platform/graphics/texmap/TextureMapperGL.h:

(WebCore):
(BitmapTextureGL):
(WebCore::BitmapTextureGL::~BitmapTextureGL):
(WebCore::BitmapTextureGL::id):
(WebCore::BitmapTextureGL::relativeSize):
(WebCore::BitmapTextureGL::setTextureMapper):
(WebCore::BitmapTextureGL::BitmapTextureGL):

  • platform/graphics/texmap/TextureMapperShaderManager.cpp:

(WebCore::TextureMapperShaderProgramOpacityAndMask::fragmentShaderSource):
(WebCore):
(WebCore::TextureMapperShaderProgramOpacityAndMask::prepare):

  • platform/graphics/texmap/TextureMapperShaderManager.h:

(WebCore):
(WebCore::TextureMapperShaderProgram::prepare):
(WebCore::TextureMapperShaderProgram::matrixVariable):
(WebCore::TextureMapperShaderProgram::sourceMatrixVariable):
(WebCore::TextureMapperShaderProgram::sourceTextureVariable):
(WebCore::TextureMapperShaderProgram::opacityVariable):
(TextureMapperShaderProgram):
(TextureMapperShaderProgramSimple):
(TextureMapperShaderProgramOpacityAndMask):
(WebCore::TextureMapperShaderProgramOpacityAndMask::maskMatrixVariable):
(WebCore::TextureMapperShaderProgramOpacityAndMask::maskTextureVariable):

8:50 AM Changeset in webkit [108809] by dbates@webkit.org
  • 11 edits
    37 adds in trunk

style element and link element for CSS stylesheet should emit load/error event when sheet loads/fails to load
https://bugs.webkit.org/show_bug.cgi?id=38995

Reviewed by Adam Barth and Nate Chapin.

Source/WebCore:

Tests: fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-existent-and-non-existent-import.html

fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-non-existent-import.html
fast/dom/HTMLLinkElement/link-onerror.html
fast/dom/HTMLLinkElement/link-onload-before-page-load.html
fast/dom/HTMLLinkElement/link-onload-stylesheet-with-import.html
fast/dom/HTMLLinkElement/link-onload.html
fast/dom/HTMLLinkElement/link-onload2.html
fast/dom/HTMLLinkElement/programmatically-add-link-with-onerror-handler.html
fast/dom/HTMLLinkElement/programmatically-add-link-with-onload-handler.html
fast/dom/HTMLStyleElement/programmatically-add-style-with-onerror-handler.html
fast/dom/HTMLStyleElement/programmatically-add-style-with-onload-handler.html
fast/dom/HTMLStyleElement/style-onerror-with-existent-and-non-existent-import.html
fast/dom/HTMLStyleElement/style-onerror.html
fast/dom/HTMLStyleElement/style-onload-before-page-load.html
fast/dom/HTMLStyleElement/style-onload.html
fast/dom/HTMLStyleElement/style-onload2.html

Implements support for firing Load and Error events at HTML Link and HTML Style elements as per
the HTML5 spec. (draft 05/25/2011) section "The link element" <http://www.w3.org/TR/html5/semantics.html#the-link-element>
and "The style element" <http://www.w3.org/TR/html5/semantics.html#the-style-element>, respectively.

  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::setCSSStyleSheet): Modified to call CSSStyleSheet::notifyLoadedSheet()
after the style sheet associated with the @import rule loaded.

  • css/CSSStyleSheet.cpp: Added instance variable m_didLoadErrorOccur to track whether a network error

occurred while loading any @import style sheets.
(WebCore::CSSStyleSheet::CSSStyleSheet):
(WebCore::CSSStyleSheet::checkLoaded):
(WebCore):
(WebCore::CSSStyleSheet::notifyLoadedSheet): Added; update m_didLoadErrorOccur to reflect if a network
error occurred while loading a style sheet associated with an @import rule.

  • css/CSSStyleSheet.h:

(WebCore):
(CSSStyleSheet):

  • dom/Document.cpp:

(WebCore::Document::implicitClose): Call HTML{LinkElement, StyleElement}::dispatchPendingLoadEvents() to
ensure that all pending Load events for link and style elements are dispatched before we fire the Load
event for the window.

  • dom/Node.h:

(WebCore::Node::notifyLoadedSheetAndAllCriticalSubresources): Added; as stated in its name, this method is
called once a style sheet and all its critical subresources (@imports) have loaded.

  • html/HTMLLinkElement.cpp:

(WebCore::loadEventSender):
(WebCore):
(WebCore::HTMLLinkElement::HTMLLinkElement):
(WebCore::HTMLLinkElement::~HTMLLinkElement): Modified to cancel all pending Load events on destruction.
(WebCore::HTMLLinkElement::parseAttribute): Register event listeners for Load and Error events regardless of whether we
built with link prefetch support.
(WebCore::HTMLLinkElement::setCSSStyleSheet):
(WebCore::HTMLLinkElement::dispatchPendingLoadEvents): Added; called from Document::implicitClose() to
ensure that all pending Load events for link elements have been dispatched before we fire the Load event
for the window.
(WebCore::HTMLLinkElement::dispatchPendingEvent): Added; called by EventSender.
(WebCore::HTMLLinkElement::notifyLoadedSheetAndAllCriticalSubresources): Added.

  • html/HTMLLinkElement.h:

(WebCore):
(HTMLLinkElement):

  • html/HTMLStyleElement.cpp:

(WebCore::loadEventSender):
(WebCore):
(WebCore::HTMLStyleElement::HTMLStyleElement):
(WebCore::HTMLStyleElement::~HTMLStyleElement): Modified to cancel all pending Load events on destruction.
(WebCore::HTMLStyleElement::parseAttribute): Register event listeners for Load and Error events.
(WebCore::HTMLStyleElement::dispatchPendingLoadEvents): Added; called from Document::implicitClose() to
ensure that all pending Load events for link elements have been dispatched before we fire the Load event
for the window.
(WebCore::HTMLStyleElement::dispatchPendingEvent): Added; called by EventSender.
(WebCore::HTMLStyleElement::notifyLoadedSheetAndAllCriticalSubresources): Added.

  • html/HTMLStyleElement.h:

(WebCore):
(HTMLStyleElement):

LayoutTests:

Add test cases to ensure we dispatch Load/Error events to HTML Link and HTML Style elements.

  • fast/dom/HTMLLinkElement/link-onerror-expected.txt: Added.
  • fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-existent-and-non-existent-import-expected.txt: Added.
  • fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-existent-and-non-existent-import.html: Added.
  • fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-non-existent-import-expected.txt: Added.
  • fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-non-existent-import.html: Added.
  • fast/dom/HTMLLinkElement/link-onerror.html: Added.
  • fast/dom/HTMLLinkElement/link-onload-before-page-load-expected.txt: Added.
  • fast/dom/HTMLLinkElement/link-onload-before-page-load.html: Added.
  • fast/dom/HTMLLinkElement/link-onload-expected.txt: Added.
  • fast/dom/HTMLLinkElement/link-onload-stylesheet-with-import-expected.txt: Added.
  • fast/dom/HTMLLinkElement/link-onload-stylesheet-with-import.html: Added.
  • fast/dom/HTMLLinkElement/link-onload.html: Added.
  • fast/dom/HTMLLinkElement/link-onload2-expected.txt: Added.
  • fast/dom/HTMLLinkElement/link-onload2.html: Added.
  • fast/dom/HTMLLinkElement/programmatically-add-link-with-onerror-handler-expected.txt: Added.
  • fast/dom/HTMLLinkElement/programmatically-add-link-with-onerror-handler.html: Added.
  • fast/dom/HTMLLinkElement/programmatically-add-link-with-onload-handler-expected.txt: Added.
  • fast/dom/HTMLLinkElement/programmatically-add-link-with-onload-handler.html: Added.
  • fast/dom/HTMLLinkElement/resources/link-load-utilities.js: Added.

(shouldComputedColorOfElementBeEqualToRGBString):
(createLinkElementWithStylesheet):
(createStyleElementWithString):
(log):
(testPassed):
(testFailed):
(testPassedAndNotifyDone):
(testFailedAndNotifyDone):
(testFinished):

  • fast/dom/HTMLLinkElement/resources/stylesheet-with-existent-and-non-existent-import.css: Added.

(#test):

  • fast/dom/HTMLLinkElement/resources/stylesheet-with-import.css: Added.

(#test):

  • fast/dom/HTMLLinkElement/resources/stylesheet-with-non-existent-import.css: Added.

(#test):

  • fast/dom/HTMLLinkElement/resources/stylesheet.css: Added.

(#test):

  • fast/dom/HTMLStyleElement/programmatically-add-style-with-onerror-handler-expected.txt: Added.
  • fast/dom/HTMLStyleElement/programmatically-add-style-with-onerror-handler.html: Added.
  • fast/dom/HTMLStyleElement/programmatically-add-style-with-onload-handler-expected.txt: Added.
  • fast/dom/HTMLStyleElement/programmatically-add-style-with-onload-handler.html: Added.
  • fast/dom/HTMLStyleElement/style-onerror-expected.txt: Added.
  • fast/dom/HTMLStyleElement/style-onerror-with-existent-and-non-existent-import-expected.txt: Added.
  • fast/dom/HTMLStyleElement/style-onerror-with-existent-and-non-existent-import.html: Added.
  • fast/dom/HTMLStyleElement/style-onerror.html: Added.
  • fast/dom/HTMLStyleElement/style-onload-before-page-load-expected.txt: Added.
  • fast/dom/HTMLStyleElement/style-onload-before-page-load.html: Added.
  • fast/dom/HTMLStyleElement/style-onload-expected.txt: Added.
  • fast/dom/HTMLStyleElement/style-onload.html: Added.
  • fast/dom/HTMLStyleElement/style-onload2-expected.txt: Added.
  • fast/dom/HTMLStyleElement/style-onload2.html: Added.
8:49 AM Changeset in webkit [108808] by Adam Roben
  • 3 edits in trunk/Source/JavaScriptCore

Fix linker warnings on Windows

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Removed symbols that are already

exported via JS_EXPORTDATA.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Define BUILDING_WTF. We

aren't actually building WTF, but we are statically linking it, so we need to define this
symbol so that we export WTF's exports.

8:48 AM Changeset in webkit [108807] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Mac build fix after r108698

  • page/scrolling/mac/ScrollingCoordinatorMac.mm: Added missing #import.
8:33 AM Changeset in webkit [108806] by commit-queue@webkit.org
  • 9 edits in trunk

[EFL][DRT] Implement setValueForUser and setAutofilled.
https://bugs.webkit.org/show_bug.cgi?id=79237

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2012-02-24
Reviewed by Andreas Kling.

Source/WebKit:

Adds the main directory of WebKit's source to find headers of JavaScriptCore.

  • PlatformEfl.cmake:

Source/WebKit/efl:

Adds missing implementation setValueForUser and setAutofilled to EFL's DumpRenderTreeSupport.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::setValueForUser):
(DumpRenderTreeSupportEfl::setAutofilled):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Adds missing implementation setValueForUser and setAutofilled to EFL's LayoutTestController.
Those implementations are related with input fields and allow to pass following tests:
fast/forms/onchange-setvalueforuser.html
fast/forms/input-autofilled.html
fast/forms/reset-autofilled.html

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setValueForUser):
(LayoutTestController::setAutofilled):

LayoutTests:

Adds missing implementation setValueForUser and setAutofilled to EFL's LayoutTestController.
Those implementations are related with input fields and allow to pass following tests:
fast/forms/onchange-setvalueforuser.html
fast/forms/input-autofilled.html
fast/forms/reset-autofilled.html

  • platform/efl/Skipped:
8:33 AM Changeset in webkit [108805] by Simon Hausmann
  • 4 edits in trunk/Source/WebKit2

Unreviewed, rolling out r108798.
http://trac.webkit.org/changeset/108798
https://bugs.webkit.org/show_bug.cgi?id=78047

Broke too many Qt WK2 tests.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebView::keyPressEvent):
(QQuickWebView::keyReleaseEvent):
(QQuickWebView::inputMethodEvent):
(QQuickWebView::focusInEvent):
(QQuickWebView::focusOutEvent):
(QQuickWebView::touchEvent):
(QQuickWebView::mousePressEvent):
(QQuickWebView::mouseMoveEvent):
(QQuickWebView::mouseReleaseEvent):
(QQuickWebView::mouseDoubleClickEvent):
(QQuickWebView::wheelEvent):
(QQuickWebView::hoverEnterEvent):
(QQuickWebView::hoverMoveEvent):
(QQuickWebView::hoverLeaveEvent):
(QQuickWebView::dragMoveEvent):
(QQuickWebView::dragEnterEvent):
(QQuickWebView::dragLeaveEvent):
(QQuickWebView::dropEvent):
(QQuickWebView::event):

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::handleEvent):
(QtWebPageEventHandler::handleMouseMoveEvent):
(QtWebPageEventHandler::handleMousePressEvent):
(QtWebPageEventHandler::handleMouseReleaseEvent):
(QtWebPageEventHandler::handleWheelEvent):
(QtWebPageEventHandler::handleHoverLeaveEvent):
(QtWebPageEventHandler::handleHoverMoveEvent):
(QtWebPageEventHandler::handleDragEnterEvent):
(QtWebPageEventHandler::handleDragLeaveEvent):
(QtWebPageEventHandler::handleDragMoveEvent):
(QtWebPageEventHandler::handleDropEvent):
(QtWebPageEventHandler::handleKeyPressEvent):
(QtWebPageEventHandler::handleKeyReleaseEvent):
(QtWebPageEventHandler::handleFocusInEvent):
(QtWebPageEventHandler::handleFocusOutEvent):
(QtWebPageEventHandler::inputMethodEvent):
(QtWebPageEventHandler::touchEvent):

  • UIProcess/qt/QtWebPageEventHandler.h:

(QtWebPageEventHandler):

8:33 AM Changeset in webkit [108804] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Unreviewed speculative buildfix after r108785 for ENABLE(SVG) && !ENABLE(XSLT) case.

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::canRequest):

8:33 AM Changeset in webkit [108803] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Eliminate excessive BlackBerry::Platform use in InputHandler
https://bugs.webkit.org/show_bug.cgi?id=79393

Patch by Mike Fenton <mifenton@rim.com> on 2012-02-24
Reviewed by Antonio Gomes.

Cleanup usage of BlackBerry::Platform in InputHandler.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::convertStringToWchar):
(BlackBerry::WebKit::convertStringToWcharVector):
(BlackBerry::WebKit::convertSpannableStringToString):
(BlackBerry::WebKit::InputHandler::learnText):
(BlackBerry::WebKit::InputHandler::setElementUnfocused):
(BlackBerry::WebKit::InputHandler::shouldAcceptInputFocus):
(BlackBerry::WebKit::InputHandler::setElementFocused):
(BlackBerry::WebKit::InputHandler::nodeTextChanged):
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
(BlackBerry::WebKit::InputHandler::frameUnloaded):
(BlackBerry::WebKit::InputHandler::selectionChanged):
(BlackBerry::WebKit::InputHandler::setSelection):
(BlackBerry::WebKit::InputHandler::handleKeyboardInput):
(BlackBerry::WebKit::InputHandler::deleteTextRelativeToCursor):
(BlackBerry::WebKit::InputHandler::deleteText):
(BlackBerry::WebKit::InputHandler::spannableTextInRange):
(BlackBerry::WebKit::InputHandler::setComposingRegion):
(BlackBerry::WebKit::InputHandler::finishComposition):
(BlackBerry::WebKit::InputHandler::setText):
(BlackBerry::WebKit::InputHandler::setTextAttributes):
(BlackBerry::WebKit::InputHandler::setRelativeCursorPosition):
(BlackBerry::WebKit::InputHandler::setSpannableTextAndRelativeCursor):
(BlackBerry::WebKit::InputHandler::setComposingText):
(BlackBerry::WebKit::InputHandler::commitText):

8:00 AM Changeset in webkit [108802] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Not reviewed: chromium image for inspector status bar button updated.

Patch by Pavel Feldman <pfeldman@chromium.org> on 2012-02-24

  • src/js/Images/segmentSelectedEndChromium.png:
7:54 AM Changeset in webkit [108801] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip new failing tests.

  • platform/qt/Skipped:
7:54 AM Changeset in webkit [108800] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Do not show scripts panel navigator automatically more than once to the same user.
https://bugs.webkit.org/show_bug.cgi?id=79489

Reviewed by Pavel Feldman.

  • inspector/front-end/ScriptsPanel.js:
7:51 AM Changeset in webkit [108799] by Philippe Normand
  • 4 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline and skip a fast/dom/shadow test.

  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
7:48 AM Changeset in webkit [108798] by Simon Hausmann
  • 4 edits in trunk/Source/WebKit2

[Qt][WK2] QQuickWebView::event should lookup faster which events QQuickWebPage can handle
https://bugs.webkit.org/show_bug.cgi?id=78047

Reviewed by Kenneth Rohde Christiansen.

Replaced double-dispatch of events with direct forwarding of events from QQuickWebView::*Event to
QtWebPageEventHandler::handle*Event.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebView::keyPressEvent):
(QQuickWebView::keyReleaseEvent):
(QQuickWebView::inputMethodEvent):
(QQuickWebView::focusInEvent):
(QQuickWebView::focusOutEvent):
(QQuickWebView::touchEvent):
(QQuickWebView::mousePressEvent):
(QQuickWebView::mouseMoveEvent):
(QQuickWebView::mouseReleaseEvent):
(QQuickWebView::mouseDoubleClickEvent):
(QQuickWebView::wheelEvent):
(QQuickWebView::hoverEnterEvent):
(QQuickWebView::hoverMoveEvent):
(QQuickWebView::hoverLeaveEvent):
(QQuickWebView::dragMoveEvent):
(QQuickWebView::dragEnterEvent):
(QQuickWebView::dragLeaveEvent):
(QQuickWebView::dropEvent):
(QQuickWebView::event):

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::handleMouseMoveEvent):
(QtWebPageEventHandler::handleMousePressEvent):
(QtWebPageEventHandler::handleMouseReleaseEvent):
(QtWebPageEventHandler::handleWheelEvent):
(QtWebPageEventHandler::handleHoverLeaveEvent):
(QtWebPageEventHandler::handleHoverMoveEvent):
(QtWebPageEventHandler::handleDragEnterEvent):
(QtWebPageEventHandler::handleDragLeaveEvent):
(QtWebPageEventHandler::handleDragMoveEvent):
(QtWebPageEventHandler::handleDropEvent):
(QtWebPageEventHandler::handleKeyPressEvent):
(QtWebPageEventHandler::handleKeyReleaseEvent):
(QtWebPageEventHandler::handleFocusInEvent):
(QtWebPageEventHandler::handleFocusOutEvent):
(QtWebPageEventHandler::handleInputMethodEvent):
(QtWebPageEventHandler::handleTouchEvent):

  • UIProcess/qt/QtWebPageEventHandler.h:

(QtWebPageEventHandler):

7:40 AM Changeset in webkit [108797] by Philippe Normand
  • 4 edits in trunk/Source

Fix GTK WebAudio build for WebKitGTK 1.7.90.

Patch by Priit Laes <plaes@plaes.org> on 2012-02-24
Rubber-stamped by Philippe Normand.

Source/JavaScriptCore:

  • GNUmakefile.list.am: Add Complex.h to the list of files so it

gets disted in the tarballs.

Source/WebCore:

  • GNUmakefile.list.am: Add AudioBufferCallback.h and

DenormalDisabler.h to the list of files so they get disted in the
tarballs.

7:34 AM Changeset in webkit [108796] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Eliminate excessive BlackBerry::Platform use in SelectionHandler.
https://bugs.webkit.org/show_bug.cgi?id=79391

Patch by Mike Fenton <mifenton@rim.com> on 2012-02-24
Reviewed by Antonio Gomes.

Clean up usage of BlackBerry::Platform in SelectionHandler and
explicitly define what namespace to use for ambiguous objects like
IntRect and IntPoint.

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::cancelSelection):
(BlackBerry::WebKit::SelectionHandler::getConsolidatedRegionOfTextQuadsForSelection):
(BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
(BlackBerry::WebKit::directionOfPointRelativeToRect):
(BlackBerry::WebKit::SelectionHandler::shouldUpdateSelectionOrCaretForPoint):
(BlackBerry::WebKit::SelectionHandler::setCaretPosition):
(BlackBerry::WebKit::directionalVisiblePositionAtExtentOfBox):
(BlackBerry::WebKit::pointIsOutsideOfBoundingBoxInDirection):
(BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
(BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
(BlackBerry::WebKit::SelectionHandler::clipPointToFocusNode):
(BlackBerry::WebKit::SelectionHandler::setSelection):
(BlackBerry::WebKit::SelectionHandler::selectAtPoint):
(BlackBerry::WebKit::SelectionHandler::selectObject):
(BlackBerry::WebKit::comparePointsToReferencePoint):
(BlackBerry::WebKit::minXMinYCorner):
(BlackBerry::WebKit::maxXMinYCorner):
(BlackBerry::WebKit::minXMaxYCorner):
(BlackBerry::WebKit::maxXMaxYCorner):
(BlackBerry::WebKit::caretLocationForRect):
(BlackBerry::WebKit::caretComparisonPointForRect):
(BlackBerry::WebKit::adjustCaretRects):
(BlackBerry::WebKit::SelectionHandler::clipRegionToVisibleContainer):
(BlackBerry::WebKit::referencePoint):
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
(BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
(BlackBerry::WebKit::SelectionHandler::selectionContains):

7:32 AM Changeset in webkit [108795] by yurys@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: show all counters on one graph
https://bugs.webkit.org/show_bug.cgi?id=79484

Now it is possible to hide any counter. All graphs share the same area.
Current values are displayed above that area.

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/MemoryStatistics.js:

(WebInspector.MemoryStatistics.getDocumentCount):
(WebInspector.MemoryStatistics.getNodeCount):
(WebInspector.MemoryStatistics.getListenerCount):
(WebInspector.MemoryStatistics):
(WebInspector.SwatchCheckbox):
(WebInspector.SwatchCheckbox.prototype.get checked):
(WebInspector.SwatchCheckbox.prototype.set checked):
(WebInspector.SwatchCheckbox.prototype._toggleCheckbox):
(WebInspector.CounterUI):
(WebInspector.CounterUI.prototype._toggleCounterGraph):
(WebInspector.CounterUI.prototype.setRange):
(WebInspector.CounterUI.prototype.updateCurrentValue):
(WebInspector.CounterUI.prototype.clearCurrentValueAndMarker):
(WebInspector.CounterUI.prototype.get visible):
(WebInspector.CounterUI.prototype.saveImageUnderMarker):
(WebInspector.CounterUI.prototype.restoreImageUnderMarker):
(WebInspector.CounterUI.prototype.discardImageUnderMarker):
(WebInspector.MemoryStatistics.prototype._updateSize):
(WebInspector.MemoryStatistics.prototype._draw):
(WebInspector.MemoryStatistics.prototype._onMouseOut):
(WebInspector.MemoryStatistics.prototype._refreshCurrentValues):
(WebInspector.MemoryStatistics.prototype._highlightCurrentPositionOnGraphs):
(WebInspector.MemoryStatistics.prototype._drawGraph):
(WebInspector.MemoryStatistics.prototype._clear):

  • inspector/front-end/timelinePanel.css:

(.memory-counter-sidebar-info):
(.memory-counter-sidebar-info .swatch):
(.memory-counter-sidebar-info .title):
(.memory-counter-value):
(#counter-values-bar):

7:28 AM Changeset in webkit [108794] by pfeldman@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: map Ctrl/Cmd +/- to zoom in hosted mode.
https://bugs.webkit.org/show_bug.cgi?id=79475

(In remote front-end mode, default zoom actions are working.)

Reviewed by Yury Semikhatsky.

  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::setZoomFactor):
(WebCore):

  • inspector/InspectorFrontendHost.h:

(InspectorFrontendHost):

  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub):
(.WebInspector.InspectorFrontendHostStub.prototype.loadResourceSynchronously):
(.WebInspector.InspectorFrontendHostStub.prototype.setZoomFactor):

  • inspector/front-end/Settings.js:

(WebInspector.Settings):

  • inspector/front-end/inspector.js:

(WebInspector._initializeCapability):
(WebInspector._zoomIn):
(WebInspector._zoomOut):
(WebInspector._resetZoom):
(WebInspector._requestZoom.set InspectorFrontendHost):
(WebInspector._requestZoom):
(WebInspector._doLoadedDoneWithCapabilities.get if):
(WebInspector.documentKeyDown):

7:03 AM Changeset in webkit [108793] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Refactor EventHandler::handleGestureEvent.
https://bugs.webkit.org/show_bug.cgi?id=79476

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-24
Reviewed by Kenneth Rohde Christiansen.

No new tests. No behavior change.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleGestureTap):
(WebCore::EventHandler::handleGestureScrollUpdate):

  • page/EventHandler.h:
6:48 AM Changeset in webkit [108792] by zoltan@webkit.org
  • 11 edits in trunk

[Qt] Allow to use WebCore imagedecoders
https://bugs.webkit.org/show_bug.cgi?id=32410

Source/WebCore:

Add ENABLE(QT_IMAGE_DECODER) guards around Qt imagedecoders and set it to default.
By passing ENABLE_QT_IMAGE_DECODER=0 define to the build system, WebKit will build
with WebCore's imagedecoders.

I added NO_RETURN attribute and PLATFORM(QT) conditionals to 2 functions of PNG and
JPEG decoders to avoid compiler warnings because in Qt-port we treat warning as errors (-Werror).

I'm continuing the refactoring of this area and try to use Qt imagedecoders only in
cases when WebCore doesn't support the image format.

Reviewed by Simon Hausmann.

No behavior change, no need new tests.

  • Target.pri:
  • WebCore.pri:
  • platform/MIMETypeRegistry.cpp:

(WebCore::initializeSupportedImageMIMETypes):
(WebCore::initializeSupportedImageMIMETypesForEncoding):

  • platform/image-decoders/ImageDecoder.h:

(WebCore::ImageFrame::getAddr):
(ImageFrame):

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

NO_RETURN has been added to a function to avoid warning message.

  • platform/image-decoders/png/PNGImageDecoder.cpp:

NO_RETURN has been added to a function to avoid warning message.
(WebCore):

  • platform/image-decoders/qt/ImageFrameQt.cpp:

(WebCore):
(WebCore::ImageFrame::asNewNativeImage):

Tools:

Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.

Reviewed by Simon Hausmann.

  • qmake/mkspecs/features/features.prf:
6:46 AM Changeset in webkit [108791] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Windows, WinCairo] Handle indeterminate checkbox state
https://bugs.webkit.org/show_bug.cgi?id=79288

Patch by Lynn Neir <lynn.neir@skype.net> on 2012-02-24
Reviewed by Adam Roben.

Tested by fast/forms/indeterminate.html

  • rendering/RenderThemeWin.cpp: Add code to check for indeterminate state in CheckBox.
6:42 AM Changeset in webkit [108790] by kbalazs@webkit.org
  • 3 edits in trunk/Tools

[Qt] Add Qt5 way to force 96 DPI for tests
https://bugs.webkit.org/show_bug.cgi?id=79364

Reviewed by Simon Hausmann.

  • DumpRenderTree/qt/main.cpp:

(main):

  • WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:

(WTR::activateFonts):

6:41 AM Changeset in webkit [108789] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebKit2

[Qt] Use private QSGRenderNode in QQuickWebView for improved Qt Scene Graph integration
https://bugs.webkit.org/show_bug.cgi?id=79022

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-02-24
Reviewed by Csaba Osztrogonác.

  • Target.pri:
  • UIProcess/API/qt/qquickwebpage.cpp:

(PageProxyNode::PageProxyNode):
(PageProxyNode::changedStates):
(PageProxyNode::render):
(PageProxyNode):

6:39 AM Changeset in webkit [108788] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

[Qt] Font related problem with newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=79402

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-02-24
Reviewed by Kenneth Rohde Christiansen.

Apply the descent += 1 workaround needed to produce correct metrics only for Qt 4,
because the behaviour has been corrected in Qt 5.

  • platform/graphics/qt/SimpleFontDataQt.cpp:

(WebCore::SimpleFontData::platformInit):

6:37 AM Changeset in webkit [108787] by haraken@chromium.org
  • 8 edits
    1 add in trunk/Source/WebCore

Move XML-related APIs from DOMWindow.idl to DOMWindowXML.idl
https://bugs.webkit.org/show_bug.cgi?id=79434

Reviewed by Adam Barth.

For WebKit modularization, this patch moves XML-related APIs
from DOMWindow.idl to DOMWIndowXML.idl.

No tests. No change in behavior.

  • xml/DOMWindowXML.idl: Added.
  • page/DOMWindow.idl:
  • CMakeLists.txt: Added "DOMWindowXML.idl".
  • DerivedSources.make: Ditto.
  • DerivedSources.pri: Ditto.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
6:36 AM Changeset in webkit [108786] by Csaba Osztrogonác
  • 8 edits in trunk/Source/WebKit/qt

[Qt] Build fix. macro "QSKIP" now only takes 1 argument on Qt5
https://bugs.webkit.org/show_bug.cgi?id=79328

Patch by Holger Hans Peter Freyther <holger@moiji-mobile.com> on 2012-02-24
Reviewed by Csaba Osztrogonác.

Introduce an alternative QSKIP that can work with both Qt4
and Qt5 without adding #ifdef to each usage site.

  • tests/benchmarks/loading/tst_loading.cpp:

(tst_Loading::load):

  • tests/benchmarks/painting/tst_painting.cpp:

(tst_Painting::paint):

  • tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:

(tst_QDeclarativeWebView::elementAreaAt):

  • tests/qwebframe/tst_qwebframe.cpp:

(tst_QWebFrame::setHtmlWithBaseURL):

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::geolocationRequestJS):
(tst_QWebPage::loadHtml5Video):
(tst_QWebPage::screenshot):

  • tests/qwebview/tst_qwebview.cpp:

(tst_QWebView::reusePage):

6:31 AM Changeset in webkit [108785] by reni@webkit.org
  • 11 edits
    2 adds in trunk/Source/WebCore

External <use> xlink:href references do not work
https://bugs.webkit.org/show_bug.cgi?id=12499

Reviewed by Nikolas Zimmermann.

Support external references on <use> by introducing CachedSVGDocument.
CachedSVGDocument is a CachedResource specialized for SVGDocuments.
This CachedSVGDocument will be stored for every use element with external reference.
This first patch only contains the new classes to test whether it works on every platform.
So they aren't used anywhere and just a follow-up patch will bind them into the caching system.

No new tests - no change in functionality.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/cache/CachedResource.cpp:

(WebCore::defaultPriorityForResourceType):
(WebCore::cachedResourceTypeToTargetType):

  • loader/cache/CachedResource.h:
  • loader/cache/CachedResourceClient.h:

(CachedResourceClient):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource):
(WebCore::CachedResourceLoader::checkInsecureContent):
(WebCore::CachedResourceLoader::canRequest):

  • loader/cache/CachedSVGDocument.cpp: Added.

(WebCore):
(WebCore::CachedSVGDocument::CachedSVGDocument):
(WebCore::CachedSVGDocument::~CachedSVGDocument):
(WebCore::CachedSVGDocument::setEncoding):
(WebCore::CachedSVGDocument::encoding):
(WebCore::CachedSVGDocument::data):

  • loader/cache/CachedSVGDocument.h: Added.

(WebCore):
(CachedSVGDocument):
(WebCore::CachedSVGDocument::document):
(WebCore::CachedSVGDocument::schedule):
(CachedSVGDocumentClient):
(WebCore::CachedSVGDocumentClient::~CachedSVGDocumentClient):
(WebCore::CachedSVGDocumentClient::expectedType):
(WebCore::CachedSVGDocumentClient::resourceClientType):

6:20 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
(diff)
6:16 AM Changeset in webkit [108784] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

Little optimization in CSSParser::parseShorthand.
https://bugs.webkit.org/show_bug.cgi?id=79356

Reviewed by Tony Chang.

Remove one loop by initializing array values at declaration time.
Also early return when the number of properties parsed are equals
with longhands count of the shorthand. It happens to be very often
the case (e.g. border). Instruments shows an improvement from 19ms
to 17ms on the time spent in this function for the css-parser-yui
benchmark.

No new tests : refactor, exisiting ones should cover.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseShorthand):

6:09 AM Changeset in webkit [108783] by jochen@chromium.org
  • 3 edits in trunk/LayoutTests

Tests for showModalDialog need to ask for permission to open windows
https://bugs.webkit.org/show_bug.cgi?id=79465

Reviewed by Tony Gentilcore.

  • fast/animation/request-animation-frame-during-modal.html:
  • fast/events/scroll-event-during-modal-dialog.html:
6:03 AM Changeset in webkit [108782] by haraken@chromium.org
  • 1 edit
    3 deletes in trunk/PerformanceTests

Unreviewed, rolling out r108477.
http://trac.webkit.org/changeset/108477
https://bugs.webkit.org/show_bug.cgi?id=79209

The perf tests committed in r108748 covers the perf tests
committed in r108477. So I'll roll out r108477.

  • Bindings/dom_attributes_id_getter.html: Removed.
  • Bindings/dom_attributes_id_setter.html: Removed.
  • Bindings/resources/dom_attributes_common.js: Removed.
5:50 AM Changeset in webkit [108781] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Move HTML-related APIs from DOMWindow.idl to DOMWindowHTML.idl
https://bugs.webkit.org/show_bug.cgi?id=79436

Reviewed by Adam Barth.

For WebKit modularization, this patch moves HTML-related APIs
from DOMWindow.idl to DOMWindowHTML.idl.

No tests. No change in behavior.

  • html/DOMWindowHTML.idl:
  • page/DOMWindow.idl:
5:41 AM Changeset in webkit [108780] by jochen@chromium.org
  • 3 edits
    2 adds in trunk

[v8] when a named item on document goes out of scope, actually remove it
https://bugs.webkit.org/show_bug.cgi?id=79409

Reviewed by Adam Barth.

Source/WebCore:

The original change already included the code, but it led to some
problems, so it was reverted in http://trac.webkit.org/changeset/63845.
However, not removing the items leaks a considerable amount of memory,
so I'm adding the code back. The bug that led to the revert was that
the accessor was removed unconditionally. I'm now only removing it,
when the last item with that name is removed.

Test: fast/dom/HTMLDocument/named-item.html

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::namedItemRemoved):

LayoutTests:

  • fast/dom/HTMLDocument/named-item-expected.txt: Added.
  • fast/dom/HTMLDocument/named-item.html: Added.
5:38 AM Changeset in webkit [108779] by zherczeg@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[Qt] Buildfix for "Zero out CopiedBlocks on initialization".
https://bugs.webkit.org/show_bug.cgi?id=79199

Ruber stamped by Csaba Osztrogonác.

Temporary fix since the new member wastes a little space on
64 bit systems. Although it is harmless, it is only needed
for 32 bit systems.

  • heap/CopiedBlock.h:

(CopiedBlock):

5:33 AM Changeset in webkit [108778] by haraken@chromium.org
  • 7 edits
    1 add in trunk/Source/WebCore

Move Worker-related APIs from DOMWindow.idl to DOMWindowWorker.idl
https://bugs.webkit.org/show_bug.cgi?id=79442

Reviewed by Adam Barth.

For WebKit modularization, this patch moves Worker-related APIs
from DOMWindow.idl to DOMWindowWorker.idl.

No tests. No change in behavior.

  • workers/DOMWindowWorker.idl: Added.
  • page/DOMWindow.idl:
  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • WebCore.gypi:
5:32 AM Changeset in webkit [108777] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] MiniBrowser should reload the view then the reload button is clicked
https://bugs.webkit.org/show_bug.cgi?id=79472

Reviewed by Philippe Normand.

  • MiniBrowser/gtk/BrowserWindow.c:

(reloadCallback): Call webkit_web_view_reload().
(browser_window_init): Connect reload item clicked even to
reloadCallback instead of activateUriEntryCallback.

5:30 AM Changeset in webkit [108776] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Encode/decode Null ResourceResponse objects in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=79471

Reviewed by Philippe Normand.

  • Shared/gtk/WebCoreArgumentCodersGtk.cpp:

(CoreIPC::::encode): Check whether ResourceResponse is Null before
encoding it.
(CoreIPC::::decode): Check whether response is Null and create a
Null ResourceResponse object in such case.

5:03 AM Changeset in webkit [108775] by commit-queue@webkit.org
  • 1 edit
    4 adds in trunk/Source/WebCore

[BlackBerry] Upstream helper classes for skia
https://bugs.webkit.org/show_bug.cgi?id=79216

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-02-24
Reviewed by Antonio Gomes.

Initial upstreaming, no new tests.

  • platform/graphics/blackberry/skia/ImageBufferData.h: Added.

(WebCore):
(ImageBufferData):

  • platform/graphics/blackberry/skia/PlatformSupport.cpp: Added.

(WebCore):
(WebCore::setFontRenderStyleDefaults):
(WebCore::PlatformSupport::getRenderStyleForStrike):
(WebCore::PlatformSupport::getFontFamilyForCharacters):

  • platform/graphics/blackberry/skia/PlatformSupport.h: Added.

(WebCore):
(PlatformSupport):
(FontFamily):

4:39 AM Changeset in webkit [108774] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Source/WebCore

[BlackBerry] Upstream ImageBlackBerry in platform/graphics/blackberry
https://bugs.webkit.org/show_bug.cgi?id=79212

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-02-24
Reviewed by Antonio Gomes.

Initial upstreaming, no new tests.

  • PlatformBlackBerry.cmake:
  • platform/graphics/blackberry/ImageBlackBerry.cpp: Added.

(WebCore):
(WebCore::Image::loadPlatformResource):

4:34 AM Changeset in webkit [108773] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Upstream the BlackBerry change to platform/graphics/IntSize.h
https://bugs.webkit.org/show_bug.cgi?id=79430

Reviewed by Antonio Gomes.

Add conversion convenience between WebCore::IntSize and BlackBerry::Platform::IntSize.

The porting can't be built yet, no new tests.

  • platform/graphics/IntSize.h:

(Platform):
(IntSize):

4:32 AM Changeset in webkit [108772] by shinyak@chromium.org
  • 32 edits in trunk/Source

SpellCheckRequest needs to know the context where the spellcheck happened.
https://bugs.webkit.org/show_bug.cgi?id=79320

Reviewed by Hajime Morita.

Source/WebCore:

WebKit clients should be able to get the context how the spellcheck happended.
For example, WebKit clients may want to change the behavior by a spellcheck request is
invoked in typing or in pasting.

This patch added an enum in SpellCheckRequest so that WebKit clients can understand the context.

  • editing/Editor.cpp:

(WebCore::Editor::replaceSelectionWithFragment):
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):

  • editing/SpellChecker.cpp:

(WebCore::SpellCheckRequest::SpellCheckRequest):
(WebCore::SpellCheckRequest::create):
(WebCore::SpellChecker::invokeRequest):

  • editing/SpellChecker.h:

(SpellCheckRequest):
(WebCore::SpellCheckRequest::textCheckingRequest):
(WebCore::SpellCheckRequest::processType):

  • loader/EmptyClients.h:

(WebCore::EmptyTextCheckerClient::requestCheckingOfString):

  • platform/text/TextCheckerClient.h:

(WebCore):
(TextCheckerClient):

  • platform/text/TextChecking.h:

(TextCheckingRequest):
(WebCore::TextCheckingRequest::TextCheckingRequest):
(WebCore::TextCheckingRequest::setSequence):
(WebCore::TextCheckingRequest::sequence):
(WebCore::TextCheckingRequest::text):
(WebCore::TextCheckingRequest::mask):
(WebCore::TextCheckingRequest::processType):
(WebCore):

Source/WebKit/blackberry:

  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::requestCheckingOfString):

  • WebCoreSupport/EditorClientBlackBerry.h:

(EditorClientBlackBerry):

Source/WebKit/chromium:

  • src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::requestCheckingOfString):

  • src/EditorClientImpl.h:

(EditorClientImpl):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::requestTextChecking):

Source/WebKit/efl:

  • WebCoreSupport/EditorClientEfl.h:

(WebCore::EditorClientEfl::requestCheckingOfString):

Source/WebKit/gtk:

  • WebCoreSupport/TextCheckerClientGtk.h:

(WebKit::TextCheckerClientGtk::requestCheckingOfString):

Source/WebKit/mac:

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::requestCheckingOfString):

Source/WebKit/qt:

  • WebCoreSupport/TextCheckerClientQt.h:

(WebCore::TextCheckerClientQt::requestCheckingOfString):

Source/WebKit/win:

  • WebCoreSupport/WebEditorClient.h:

(WebEditorClient::requestCheckingOfString):
(WebEditorClient):

Source/WebKit/wince:

  • WebCoreSupport/EditorClientWinCE.h:

(WebKit::EditorClientWinCE::requestCheckingOfString):

Source/WebKit/wx:

  • WebKitSupport/EditorClientWx.h:

(WebCore::EditorClientWx::requestCheckingOfString):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::requestCheckingOfString):

  • WebProcess/WebCoreSupport/WebEditorClient.h:
4:09 AM Changeset in webkit [108771] by kenneth@webkit.org
  • 15 edits in trunk/Source/WebKit2

[Qt] Tiling: Improve the method names dealing with moving and scaling.

Rubberstamped by Simon Hausmann.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewLegacyPrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebViewFlickablePrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::_q_commitScaleChange):
(QQuickWebViewPrivate::_q_commitPositionChange):
(QQuickWebViewFlickablePrivate::_q_resume):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):
(QQuickWebViewPrivate::_q_commitScaleChange):
(QQuickWebViewFlickablePrivate):

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::setVisibleContentsRectForScaling):
(WebKit::DrawingAreaProxy::setVisibleContentsRectForPanning):

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::setVisibleContentsRectForScaling):
(WebKit::DrawingAreaProxyImpl::setVisibleContentsRectForPanning):

  • UIProcess/DrawingAreaProxyImpl.h:

(DrawingAreaProxyImpl):

  • UIProcess/LayerTreeHostProxy.h:

(LayerTreeHostProxy):

  • UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::setVisibleContentsRectForPanning):
(WebKit::LayerTreeHostProxy::setVisibleContentsRectForScaling):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::ViewportUpdateDeferrer::~ViewportUpdateDeferrer):
(WebKit::QtViewportInteractionEngine::flickableMovingPositionUpdate):
(WebKit::QtViewportInteractionEngine::wheelEvent):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):

  • UIProcess/qt/QtViewportInteractionEngine.h:

(QtViewportInteractionEngine):

  • WebProcess/WebPage/LayerTreeHost.h:

(WebKit::LayerTreeHost::setVisibleContentsRectForScaling):
(WebKit::LayerTreeHost::setVisibleContentsRectForPanning):
(WebKit::LayerTreeHost::setVisibleContentsRectForLayer):

  • WebProcess/WebPage/LayerTreeHost.messages.in:
  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::setVisibleContentsRectForScaling):
(WebKit::LayerTreeHostQt::setVisibleContentsRectForPanning):

  • WebProcess/WebPage/qt/LayerTreeHostQt.h:

(LayerTreeHostQt):

4:02 AM Changeset in webkit [108770] by hayato@chromium.org
  • 3 edits in trunk/Source/WebCore

Make Node::showTreeForThis (and Node::showTreeForThisAcrossFrame) dump multiple shadow roots.
https://bugs.webkit.org/show_bug.cgi?id=79351

Reviewed by Dimitri Glazkov.

No new tests since these utility functions are only available in debug build.
I manually tested in GDB session.

  • dom/Node.cpp:

(WebCore::oldestShadowRootFor):
(WebCore::traverseTreeAndMark):
(WebCore::parentOrHostOrFrameOwner):
(WebCore::showSubTreeAcrossFrame):

  • dom/ShadowRoot.h:

(WebCore::ShadowRoot::youngerShadowRoot):
(WebCore::ShadowRoot::olderShadowRoot):
(WebCore::toShadowRoot):
(WebCore):

3:58 AM Changeset in webkit [108769] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Not reviewed: follow up to inspector's r108331, using more general condition.

Patch by Pavel Feldman <pfeldman@chromium.org> on 2012-02-24

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype._getPopoverAnchor):

3:57 AM Changeset in webkit [108768] by haraken@chromium.org
  • 7 edits
    1 add in trunk/Source/WebCore

Move WebGL APIs from DOMWindow.idl to DOMWindowWebGL.idl
https://bugs.webkit.org/show_bug.cgi?id=79432

Reviewed by Adam Barth.

For WebKit modularization, this patch moves WebGL-related APIs
from DOMWindow.idl to DOMWindowWebGL.idl.

No tests. No change in behavior.

  • html/canvas/DOMWindowWebGL.idl: Added.
  • page/DOMWindow.idl:
  • DerivedSources.make: Added DOMWindowWebGL.idl.
  • DerivedSources.pri: Ditto.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
3:35 AM Changeset in webkit [108767] by vsevik@chromium.org
  • 3 edits in trunk

Web Inspector: [Regression] network worker tests crash on qt.
https://bugs.webkit.org/show_bug.cgi?id=79263

Reviewed by Pavel Feldman.

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::createDecoder):
(WebCore::InspectorPageAgent::cachedResourceContent):

3:25 AM Changeset in webkit [108766] by commit-queue@webkit.org
  • 3 edits
    1 add
    4 deletes in trunk/LayoutTests

Convert some fast/regions pixel tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=78906

Patch by Flex Mobile <rhauck@adobe.com> on 2012-02-24
Reviewed by Hajime Morita.

  • fast/regions/float-pushed-width-change-expected.html: Added.
  • fast/regions/float-pushed-width-change.html:
  • platform/chromium/test_expectations.txt:
  • platform/efl/fast/regions/float-pushed-width-change-expected.png: Removed.
  • platform/efl/fast/regions/float-pushed-width-change-expected.txt: Removed.
  • platform/mac/fast/regions/float-pushed-width-change-expected.png: Removed.
  • platform/mac/fast/regions/float-pushed-width-change-expected.txt: Removed.
3:21 AM Changeset in webkit [108765] by kling@webkit.org
  • 6 edits in trunk/Source/WebCore

Miscellaneous CSSParser dodging in presentation attribute parsing.
<http://webkit.org/b/79468>

Reviewed by Antti Koivisto.

  • Bypass CSSParser when adding constant values to attribute styles.
  • Added fast paths for the valid HTMLTablePartElement align values.
  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::collectStyleForAttribute):

  • html/HTMLHRElement.cpp:

(WebCore::HTMLHRElement::collectStyleForAttribute):

  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::collectStyleForAttribute):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::collectStyleForAttribute):

  • html/HTMLTablePartElement.cpp:

(WebCore::HTMLTablePartElement::collectStyleForAttribute):

3:01 AM Changeset in webkit [108764] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[chromium] Avoid culling work for fully-non-opaque tiles, and add tracing for draw culling
https://bugs.webkit.org/show_bug.cgi?id=79183

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-24
Reviewed by James Robinson.

Addresses performance issues with draw culling by avoiding the work
of mapRect and other function calls when the quad has no opaque area.
And adds a TRACE_EVENT to watch the time spent in draw culling.

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::optimizeRenderPasses):

  • platform/graphics/chromium/cc/CCQuadCuller.cpp:

(WebCore::CCQuadCuller::cullOccludedQuads):

2:54 AM Changeset in webkit [108763] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Anchor mailto: with target set won't launch Messaging application when clicked
https://bugs.webkit.org/show_bug.cgi?id=79318

Need to give the client a chance to decide how to handle the new window request.

Patch by Charles Wei <charles.wei@torchmobile.com.cn> on 2012-02-24
Reviewed by Rob Buis.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNewWindowAction):

2:40 AM Changeset in webkit [108762] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

[Chromium] video-referer.html fails
https://bugs.webkit.org/show_bug.cgi?id=79239

Fix error event race at startup and cleanup event code to take
advantage of more succinct video-test.js functionality; such as
waitForEventAndFail, etc.

Since this test uses a <source> element without a 'src' tag, an error
event gets fired during load. If we don't wait until after the <body>
onload fires, we'll pickup this error we don't care about.

Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-02-24
Reviewed by Eric Carlson.

  • http/tests/media/video-referer-expected.txt:
  • http/tests/media/video-referer.html:
  • platform/chromium/test_expectations.txt:
2:33 AM Changeset in webkit [108761] by Nikolas Zimmermann
  • 18 edits in trunk/LayoutTests

2012-02-24 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Update layout test results after r108699.

  • platform/mac/svg/carto.net/tabgroup-expected.png:
  • platform/mac/svg/carto.net/tabgroup-expected.txt:
  • platform/mac/svg/carto.net/window-expected.png:
  • platform/mac/svg/carto.net/window-expected.txt:
  • platform/mac/svg/custom/circle-move-invalidation-expected.png:
  • platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.png:
  • platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
  • platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.txt:
  • platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.txt:
  • platform/mac/svg/custom/text-ctm-expected.png:
  • platform/mac/svg/custom/text-ctm-expected.txt:
  • platform/mac/svg/custom/use-detach-expected.png:
  • platform/mac/svg/custom/use-detach-expected.txt:
  • platform/mac/svg/hixie/perf/003-expected.png:
  • platform/mac/svg/hixie/perf/003-expected.txt:
2:20 AM WebKitGTK/1.8.x edited by sergio@webkit.org
(diff)
2:19 AM Changeset in webkit [108760] by sergio@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] [GTK] Destructor not invoked in EditorClientFrameDestructionObserver
https://bugs.webkit.org/show_bug.cgi?id=79466

Reviewed by Philippe Normand.

Explicitly cast the observer before deleting it instead of just
deleting a generic pointer. We must to that in order to get the
destructor of the object properly called.

  • WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:

(WebKit::EditorClientFrameDestructionObserver::destroyOnClosureFinalization):

2:12 AM Changeset in webkit [108759] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Scripts panel navigator overlay should be shown automatically only one time.
https://bugs.webkit.org/show_bug.cgi?id=79467

Reviewed by Pavel Feldman.

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._hideNavigatorOverlay):
(WebInspector.ScriptsPanel.prototype._navigatorOverlayWillHide):

1:59 AM Changeset in webkit [108758] by morrita@google.com
  • 53 edits
    2 adds in trunk

Adding a ShadowRoot to image-backed element causes a crash
https://bugs.webkit.org/show_bug.cgi?id=78878

Reviewed by Dimitri Glazkov.

Source/WebCore:

The crash happened because NodeRenderingContext tried to append a
child to a renderer regardless one isn't capable of holding any
children if it appears in the shadow attaching phase. RenderImage
is one of such renderer classes which aren't capable.

NodeRenderingContext decide whether the contextual node as a child
can create its renderer based on RenderObject::canHaveChildren()
and Node::childShouldCreateRenderer(). But the responsibility
between these two methods are getting confused. which results this
unfortuante crash path.

This change re-aligns the responsibility:

  • Now canHaveChildren() purely declares the ability of the renderer. If the renderer is capable of having children, it return true regardless of HTML semantics.
  • On the other hand, childShouldCreateRenderer() cares about the semantics. If the element doesn't allow children to be rendered, this returns false.
  • Note that these decision on elements are contextual. Each element needs to know which role it is playing in the tree composition algorithm of Shadow DOM. That's why the method parameter is changed from Node* to NodeRenderingContext.
  • Fixed updateFirstLetter() which relied on this confused assumption. This change introduces RenderDeprecatedFlexibleBox::buttonText() to refine the relying assumption.

With this change, some decision points are moved from a renderer to an
element. Following renderers no longer stop reject having children:

  • RenderButton, RenderListBox, RenderMenuList, RenderMeter, RenderProgress, RenderTextControl.

Corresponding element for such a render (HTMLProgressElement of
RenderProgress for exaple) now cares about that.

Reviewed by Dimitri Glazkov.

Tests: fast/dom/shadow/shadow-on-image-expected.html

fast/dom/shadow/shadow-on-image.html

  • dom/Element.cpp:

(WebCore::Element::childShouldCreateRenderer):

  • dom/Element.h:

(Element):

  • dom/Node.h:

(WebCore::Node::childShouldCreateRenderer):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::shouldCreateRenderer):

  • dom/NodeRenderingContext.h:

(NodeRenderingContext):
(WebCore::NodeRenderingContext::isOnEncapsulationBoundary):
(WebCore):

  • html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::childShouldCreateRenderer):

  • html/HTMLDetailsElement.h:

(HTMLDetailsElement):

  • html/HTMLMediaElement.cpp:

(WebCore):
(WebCore::HTMLMediaElement::childShouldCreateRenderer):

  • html/HTMLMediaElement.h:

(HTMLMediaElement):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::childShouldCreateRenderer):
(WebCore):

  • html/HTMLMeterElement.h:

(HTMLMeterElement):

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::childShouldCreateRenderer):
(WebCore):

  • html/HTMLProgressElement.h:

(HTMLProgressElement):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::childShouldCreateRenderer):
(WebCore):

  • html/HTMLSelectElement.h:

(HTMLSelectElement):

  • html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::childShouldCreateRenderer):
(WebCore):

  • html/HTMLSummaryElement.h:

(HTMLSummaryElement):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::childShouldCreateRenderer):
(WebCore):

  • html/HTMLTextFormControlElement.h:

(HTMLTextFormControlElement):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetter):

  • rendering/RenderButton.cpp:
  • rendering/RenderButton.h:

(RenderButton):

  • rendering/RenderDeprecatedFlexibleBox.h:

(WebCore::RenderDeprecatedFlexibleBox::buttonText):

  • rendering/RenderListBox.h:

(RenderListBox):

  • rendering/RenderMedia.h:

(WebCore::RenderMedia::canHaveChildren):

  • rendering/RenderMenuList.h:

(RenderMenuList):
(WebCore::RenderMenuList::hasControlClip):

  • rendering/RenderMeter.h:
  • rendering/RenderProgress.h:
  • rendering/RenderTextControl.h:
  • rendering/svg/RenderSVGRoot.h:

(WebCore::RenderSVGRoot::canHaveChildren):

  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::childShouldCreateRenderer):

  • svg/SVGAElement.h:

(SVGAElement):

  • svg/SVGAltGlyphElement.cpp:

(WebCore::SVGAltGlyphElement::childShouldCreateRenderer):

  • svg/SVGAltGlyphElement.h:

(SVGAltGlyphElement):

  • svg/SVGDocument.cpp:

(WebCore::SVGDocument::childShouldCreateRenderer):

  • svg/SVGDocument.h:

(SVGDocument):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::childShouldCreateRenderer):

  • svg/SVGElement.h:

(SVGElement):

  • svg/SVGForeignObjectElement.cpp:

(WebCore::SVGForeignObjectElement::childShouldCreateRenderer):

  • svg/SVGForeignObjectElement.h:

(SVGForeignObjectElement):

  • svg/SVGSwitchElement.cpp:

(WebCore::SVGSwitchElement::childShouldCreateRenderer):

  • svg/SVGSwitchElement.h:

(SVGSwitchElement):

  • svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::childShouldCreateRenderer):

  • svg/SVGTRefElement.h:

(SVGTRefElement):

  • svg/SVGTSpanElement.cpp:

(WebCore::SVGTSpanElement::childShouldCreateRenderer):

  • svg/SVGTSpanElement.h:

(SVGTSpanElement):

  • svg/SVGTextElement.cpp:

(WebCore::SVGTextElement::childShouldCreateRenderer):

  • svg/SVGTextElement.h:

(SVGTextElement):

  • svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::childShouldCreateRenderer):

  • svg/SVGTextPathElement.h:

LayoutTests:

  • fast/dom/shadow/shadow-on-image-expected.html: Added.
  • fast/dom/shadow/shadow-on-image.html: Added.
1:56 AM Changeset in webkit [108757] by haraken@chromium.org
  • 13 edits in trunk/Source/WebCore

Support [Supplemental] on static methods
https://bugs.webkit.org/show_bug.cgi?id=79357

Reviewed by Adam Barth.

[Supplemental] on static methods does not work in CodeGeneratorJS.pm
and CodeGeneratorV8.pm due to mis-ordered if-elsif statements.
This patch fixes it and supports [Supplemental] on static methods.

Test: bindings/scripts/test/TestSupplemental.idl

  • bindings/scripts/CodeGeneratorJS.pm: Modified as described above.

(GenerateParametersCheck):

  • bindings/scripts/CodeGeneratorV8.pm: Ditto.

(GenerateFunctionCallString):

  • bindings/scripts/test/TestSupplemental.idl: Added a test case.
  • bindings/scripts/test/CPP/WebDOMTestInterface.cpp: Updated run-bindings-tests results.

(WebDOMTestInterface::supplementalMethod4):

  • bindings/scripts/test/CPP/WebDOMTestInterface.h: Ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp: Ditto.

(webkit_dom_test_interface_supplemental_method4):

  • bindings/scripts/test/GObject/WebKitDOMTestInterface.h: Ditto.
  • bindings/scripts/test/JS/JSTestInterface.cpp: Ditto.

(WebCore):
(WebCore::JSTestInterfaceConstructor::getOwnPropertySlot):
(WebCore::JSTestInterfaceConstructor::getOwnPropertyDescriptor):
(WebCore::jsTestInterfaceConstructorFunctionSupplementalMethod4):

  • bindings/scripts/test/JS/JSTestInterface.h: Ditto.

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestInterface.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestInterface.mm: Ditto.

(-[DOMTestInterface supplementalMethod4]):

  • bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.

(TestInterfaceInternal):
(WebCore::TestInterfaceInternal::supplementalMethod4Callback):
(WebCore::ConfigureV8TestInterfaceTemplate):

1:53 AM Changeset in webkit [108756] by bashi@chromium.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

Remove tests introduced in r108731 but rolled out.

  • platform/qt/Skipped: Removed rolled out tests.
1:53 AM Changeset in webkit [108755] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

Small refactor in RenderFlexibleBox::layoutAndPlaceChildren
https://bugs.webkit.org/show_bug.cgi?id=79420

Reviewed by Ojan Vafai.

No new tests, just a refactor.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Share some of the logic
in computing the cross axis length.

1:50 AM Changeset in webkit [108754] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: cannot drag timeline overview window when clicking inside the window
https://bugs.webkit.org/show_bug.cgi?id=79453

Reviewed by Pavel Feldman.

  • inspector/front-end/timelinePanel.css:

(.timeline-overview-window-rulers):

1:49 AM Changeset in webkit [108753] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Remove useless jump instructions for short circuit
https://bugs.webkit.org/show_bug.cgi?id=75602

Patch by Han Hojong <hojong.han@samsung.com> on 2012-02-24
Reviewed by Michael Saboff.

Jump instruction is inserted to make short circuit,
however it does nothing but moving to the next instruction.
Therefore useless jump instructions are removed,
and jump list is moved into the case not for a short circuit,
so that only necessary instructions are added to JIT code
unless it has a 16 bit pattern character and an 8 bit string.

  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::generatePatternCharacterGreedy):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterNonGreedy):

1:47 AM Changeset in webkit [108752] by bashi@chromium.org
  • 16 edits
    13 deletes in trunk

Unreviewed, rolling out r108731.
http://trac.webkit.org/changeset/108731
https://bugs.webkit.org/show_bug.cgi?id=79464

Broke Chromium Win tests (Requested by bashi on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-24

Source/JavaScriptCore:

  • wtf/Platform.h:

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • websockets/WebSocket.cpp:

(WebCore::WebSocket::didConnect):

  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::connect):
(WebCore::WebSocketChannel::fail):
(WebCore::WebSocketChannel::processFrame):
(WebCore::WebSocketChannel::sendFrame):

  • websockets/WebSocketChannel.h:
  • websockets/WebSocketDeflateFramer.cpp: Removed.
  • websockets/WebSocketDeflateFramer.h: Removed.

LayoutTests:

  • http/tests/websocket/tests/hybi/compressed-control-frame-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/compressed-control-frame.html: Removed.
  • http/tests/websocket/tests/hybi/compressed-control-frame_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff.html: Removed.
  • http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter.html: Removed.
  • http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/deflate-frame-parameter-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/deflate-frame-parameter.html: Removed.
  • http/tests/websocket/tests/hybi/deflate-frame_wsh.py: Removed.
  • http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header-expected.txt:
  • http/tests/websocket/tests/hybi/send-file-blob_wsh.py:

(web_socket_transfer_data):

1:41 AM Changeset in webkit [108751] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Show scripts panel navigator overlay on the first scripts panel opening.
https://bugs.webkit.org/show_bug.cgi?id=79248

Reviewed by Pavel Feldman.

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.wasShown):
(WebInspector.ScriptsPanel.prototype.set _showNavigatorOverlay):
(WebInspector.ScriptsPanel.prototype._hideNavigatorOverlay):

1:33 AM Changeset in webkit [108750] by mikelawther@chromium.org
  • 7 edits
    2 adds in trunk

CSS3 calc(): handle non-negative values
https://bugs.webkit.org/show_bug.cgi?id=79188

Reviewed by Daniel Bates.

Source/WebCore:

Some CSS properties (e.g. padding) are required to be non-negative. These
are now restricted to the correct range.

Tests: css3/calc/negative-padding-expected.html

css3/calc/negative-padding.html

  • css/CSSCalculationValue.cpp:

(WebCore):
(WebCore::CSSCalcValue::clampToPermittedRange): Added
(WebCore::CSSCalcValue::doubleValue):
(WebCore::CSSCalcValue::isNegative): Added
(WebCore::CSSCalcValue::computeLengthPx):
(WebCore::CSSCalcValue::create):

  • css/CSSCalculationValue.h:

(CSSCalcValue):
(WebCore::CSSCalcValue::CSSCalcValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::validCalculationUnit):
(WebCore::CSSParser::parseCalculation):

  • css/CSSParser.h:
  • platform/CalculationValue.h:

LayoutTests:

  • css3/calc/negative-padding-expected.html: Added.
  • css3/calc/negative-padding.html: Added.
1:31 AM Changeset in webkit [108749] by vsevik@chromium.org
  • 4 edits in trunk

Web Inspector: [Regression] xhr tests are crashing after r108506.
https://bugs.webkit.org/show_bug.cgi?id=79265

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::setInitialScriptContent):
(WebCore::InspectorResourceAgent::setInitialXHRContent):

LayoutTests:

  • platform/chromium/test_expectations.txt:
12:55 AM Changeset in webkit [108748] by haraken@chromium.org
  • 4 edits
    1 add in trunk

Add performance tests for DOM attribute getters and setters
https://bugs.webkit.org/show_bug.cgi?id=79208

Reviewed by Ryosuke Niwa.

PerformanceTests:

This patch adds performance micro-benchmarks for DOM attribute
getters and setters. We selected DOM attributes from HTMLElement,
Element and Node which will most impact on the DOM performance
in the real Web and which have different call-paths from another
DOM attribute.

The perf test result in my local Chromium/Linux environment is as follows:
median= 14967.0 ms, stdev= 85.2385476178 ms, min= 14861.0 ms, max= 15155.0 ms

If we run the test with DumpRenderTree, we can get the following test results:
Info: [HTMLElement.id] avg=65.76ms, median=65.00ms, stdev=2.14ms, min=63, max=70
Info: [HTMLElement.title] avg=64.05ms, median=63.00ms, stdev=1.50ms, min=63, max=67
Info: [HTMLElement.lang] avg=64.19ms, median=63.00ms, stdev=1.82ms, min=62, max=67
Info: [HTMLElement.dir] avg=64.10ms, median=63.00ms, stdev=1.72ms, min=62, max=68
Info: [HTMLElement.className] avg=63.33ms, median=63.00ms, stdev=0.89ms, min=63, max=67
Info: [HTMLElement.classList] avg=1946.00ms, median=1945.00ms, stdev=38.22ms, min=1921, max=2110
Info: [HTMLElement.tabIndex] avg=83.52ms, median=80.00ms, stdev=6.00ms, min=79, max=94
Info: [HTMLElement.draggable] avg=78.14ms, median=81.00ms, stdev=3.51ms, min=74, max=82
Info: [HTMLElement.webkitdropzone] avg=64.33ms, median=63.00ms, stdev=1.98ms, min=63, max=68
Info: [HTMLElement.hidden] avg=65.57ms, median=64.00ms, stdev=3.27ms, min=63, max=71
Info: [HTMLElement.accessKey] avg=64.43ms, median=63.00ms, stdev=2.11ms, min=62, max=68
Info: [HTMLElement.children] avg=130.76ms, median=128.00ms, stdev=9.75ms, min=109, max=143
Info: [HTMLElement.isContentEditable] avg=74.29ms, median=75.00ms, stdev=2.00ms, min=71, max=77
Info: [HTMLElement.spellcheck] avg=79.52ms, median=80.00ms, stdev=2.52ms, min=76, max=82
Info: [HTMLElement.innerHTML] avg=279.05ms, median=279.00ms, stdev=1.96ms, min=276, max=283
Info: [HTMLElement.innerText] avg=204.14ms, median=203.00ms, stdev=2.95ms, min=200, max=210
Info: [HTMLElement.outerHTML] avg=1544.10ms, median=1546.00ms, stdev=15.56ms, min=1514, max=1568
Info: [HTMLElement.outerText] avg=216.05ms, median=207.00ms, stdev=18.19ms, min=201, max=247
Info: [HTMLElement.contentEditable] avg=334.24ms, median=323.00ms, stdev=36.06ms, min=318, max=446
Info: [HTMLElement.id="foo"] avg=53.19ms, median=53.00ms, stdev=1.76ms, min=52, max=58
Info: [HTMLElement.title="foo"] avg=63.14ms, median=63.00ms, stdev=0.35ms, min=63, max=64
Info: [HTMLElement.lang="foo"] avg=60.86ms, median=61.00ms, stdev=0.56ms, min=60, max=62
Info: [HTMLElement.dir="foo"] avg=53.57ms, median=54.00ms, stdev=0.58ms, min=53, max=55
Info: [HTMLElement.className="foo"] avg=64.52ms, median=64.00ms, stdev=0.91ms, min=63, max=66
Info: [HTMLElement.tabIndex="foo"] avg=367.86ms, median=369.00ms, stdev=8.06ms, min=352, max=380
Info: [HTMLElement.draggable="foo"] avg=79.43ms, median=79.00ms, stdev=0.58ms, min=79, max=81
Info: [HTMLElement.webkitdropzone="foo"] avg=62.14ms, median=62.00ms, stdev=0.35ms, min=62, max=63
Info: [HTMLElement.hidden="foo"] avg=61.67ms, median=62.00ms, stdev=0.71ms, min=61, max=64
Info: [HTMLElement.accessKey="foo"] avg=61.86ms, median=62.00ms, stdev=0.56ms, min=61, max=63
Info: [HTMLElement.spellcheck="foo"] avg=79.57ms, median=80.00ms, stdev=0.58ms, min=78, max=80
Info: [HTMLElement.innerHTML="foo"] avg=1176.67ms, median=1169.00ms, stdev=26.60ms, min=1146, max=1246
Info: [HTMLElement.innerText="foo"] avg=51.62ms, median=52.00ms, stdev=0.72ms, min=50, max=53
Info: [Element.tagName] avg=79.52ms, median=80.00ms, stdev=1.05ms, min=78, max=81
Info: [Element.style] avg=126.19ms, median=126.00ms, stdev=10.40ms, min=104, max=161
Info: [Element.offsetLeft] avg=98.95ms, median=104.00ms, stdev=4.01ms, min=100, max=99
Info: [Element.clientLeft] avg=98.33ms, median=102.00ms, stdev=2.59ms, min=100, max=99
Info: [Element.scrollLeft] avg=103.29ms, median=96.00ms, stdev=15.63ms, min=100, max=97
Info: [Element.dataset] avg=2448.62ms, median=2441.00ms, stdev=20.43ms, min=2426, max=2503
Info: [Element.firstElementChild] avg=58.71ms, median=58.00ms, stdev=2.37ms, min=57, max=65
Info: [Element.lastElementChild] avg=56.33ms, median=55.00ms, stdev=1.83ms, min=54, max=59
Info: [Element.previousElementSibling] avg=52.95ms, median=52.00ms, stdev=1.70ms, min=52, max=57
Info: [Element.nextElementSibling] avg=58.48ms, median=58.00ms, stdev=1.79ms, min=57, max=63
Info: [Element.childElementCount] avg=64.57ms, median=64.00ms, stdev=1.81ms, min=63, max=71
Info: [Element.onload] avg=98.38ms, median=98.00ms, stdev=0.49ms, min=98, max=99
Info: [Element.scrollLeft="foo"] avg=95.24ms, median=95.00ms, stdev=0.92ms, min=94, max=98
Info: [Element.onload="foo"] avg=67.14ms, median=67.00ms, stdev=0.56ms, min=66, max=68
Info: [Node.nodeName] avg=76.29ms, median=76.00ms, stdev=0.63ms, min=75, max=77
Info: [Node.nodeType] avg=53.05ms, median=52.00ms, stdev=2.61ms, min=52, max=61
Info: [Node.parentNode] avg=53.52ms, median=53.00ms, stdev=1.22ms, min=52, max=56
Info: [Node.childNodes] avg=118.33ms, median=123.00ms, stdev=8.85ms, min=107, max=129
Info: [Node.firstChild] avg=53.62ms, median=53.00ms, stdev=1.13ms, min=51, max=55
Info: [Node.lastChild] avg=53.14ms, median=53.00ms, stdev=1.21ms, min=52, max=55
Info: [Node.previousSibling] avg=51.86ms, median=51.00ms, stdev=1.55ms, min=50, max=54
Info: [Node.nextSibling] avg=52.86ms, median=54.00ms, stdev=1.81ms, min=50, max=55
Info: [Node.attributes] avg=2027.71ms, median=2026.00ms, stdev=10.48ms, min=2010, max=2051
Info: [Node.ownerDocument] avg=152.14ms, median=152.00ms, stdev=1.73ms, min=149, max=155
Info: [Node.namespaceURI] avg=60.86ms, median=59.00ms, stdev=3.85ms, min=56, max=66
Info: [Node.localName] avg=60.00ms, median=59.00ms, stdev=2.71ms, min=57, max=66
Info: [Node.baseURI] avg=671.10ms, median=668.00ms, stdev=10.66ms, min=659, max=706
Info: [Node.parentElement] avg=55.05ms, median=56.00ms, stdev=2.15ms, min=52, max=58
Info: [Node.nodeValue] avg=61.24ms, median=60.00ms, stdev=2.56ms, min=59, max=68
Info: [Node.prefix] avg=60.90ms, median=58.00ms, stdev=4.26ms, min=57, max=68
Info: [Node.textContent] avg=149.71ms, median=149.00ms, stdev=1.12ms, min=148, max=152
Info: [Node.nodeValue="foo"] avg=23.62ms, median=23.00ms, stdev=0.72ms, min=23, max=25
Info: [Node.prefix="foo"] avg=49.57ms, median=49.00ms, stdev=0.73ms, min=49, max=51
Info: [Node.textContent="foo"] avg=145.81ms, median=140.00ms, stdev=17.43ms, min=138, max=199

  • Bindings/dom_attributes.html: Added.
  • resources/runner.js:

(PerfTestRunner.info):

Tools:

We want to allow perf tests to output info messages
that do not affect the test results. To accomplish this,
this patch modifies perftestsrunner.py so that it ignores
a line that starts from "Info:".

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner):

12:42 AM Changeset in webkit [108747] by commit-queue@webkit.org
  • 4 edits in trunk

[BlackBerry] Enable requestAnimationFrame
https://bugs.webkit.org/show_bug.cgi?id=79408

Source/JavaScriptCore:

Use timer implementation of requestAnimationFrame on BlackBerry.

Patch by Andrew Lo <anlo@rim.com> on 2012-02-24
Reviewed by Rob Buis.

  • wtf/Platform.h:

Tools:

Enable requestAnimationFrame for BlackBerry.

Patch by Andrew Lo <anlo@rim.com> on 2012-02-24
Reviewed by Rob Buis.

  • Scripts/build-webkit:
12:38 AM Changeset in webkit [108746] by commit-queue@webkit.org
  • 12 edits
    5 moves
    1 add
    1 delete in trunk/Source/WebCore

Rename LocalStorageThread to StorageThread and LocalStorageTask to StorageTask.
https://bugs.webkit.org/show_bug.cgi?id=79358

Revision 45124 commented FIXME to rename these classes.

Patch by Huang Dongsung <luxtella@company100.net> on 2012-02-24
Reviewed by Kentaro Hara.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • storage/LocalStorageTask.h: Removed.
  • storage/StorageSyncManager.cpp:

(WebCore::StorageSyncManager::StorageSyncManager):
(WebCore::StorageSyncManager::scheduleImport):
(WebCore::StorageSyncManager::scheduleSync):
(WebCore::StorageSyncManager::scheduleDeleteEmptyDatabase):

  • storage/StorageSyncManager.h:

(WebCore):
(StorageSyncManager):

  • storage/StorageTask.cpp: Renamed from Source/WebCore/storage/LocalStorageTask.cpp.

(WebCore):
(WebCore::StorageTask::StorageTask):
(WebCore::StorageTask::~StorageTask):
(WebCore::StorageTask::performTask):

  • storage/StorageTask.h: Added.

(WebCore):
(StorageTask):
(WebCore::StorageTask::createImport):
(WebCore::StorageTask::createSync):
(WebCore::StorageTask::createDeleteEmptyDatabase):
(WebCore::StorageTask::createOriginIdentifiersImport):
(WebCore::StorageTask::createSetOriginDetails):
(WebCore::StorageTask::createDeleteOrigin):
(WebCore::StorageTask::createDeleteAllOrigins):
(WebCore::StorageTask::createTerminate):

  • storage/StorageThread.cpp: Renamed from Source/WebCore/storage/LocalStorageThread.cpp.

(WebCore):
(WebCore::StorageThread::create):
(WebCore::StorageThread::StorageThread):
(WebCore::StorageThread::~StorageThread):
(WebCore::StorageThread::start):
(WebCore::StorageThread::threadEntryPointCallback):
(WebCore::StorageThread::threadEntryPoint):
(WebCore::StorageThread::scheduleTask):
(WebCore::StorageThread::terminate):
(WebCore::StorageThread::performTerminate):

  • storage/StorageThread.h: Renamed from Source/WebCore/storage/LocalStorageThread.h.

(WebCore):
(StorageThread):

  • storage/StorageTracker.cpp:

(WebCore::StorageTracker::StorageTracker):
(WebCore::StorageTracker::importOriginIdentifiers):
(WebCore::StorageTracker::setOriginDetails):
(WebCore::StorageTracker::scheduleTask):
(WebCore::StorageTracker::deleteAllOrigins):
(WebCore::StorageTracker::deleteOrigin):

  • storage/StorageTracker.h:

(WebCore):
(StorageTracker):

  • storage/wince/StorageThreadWinCE.cpp: Renamed from Source/WebCore/storage/wince/LocalStorageThreadWinCE.cpp.

(WebCore):
(WebCore::StorageThread::StorageThread):
(WebCore::StorageThread::~StorageThread):
(WebCore::StorageThread::start):
(WebCore::StorageThread::timerFired):
(WebCore::StorageThread::scheduleImport):
(WebCore::StorageThread::scheduleSync):
(WebCore::StorageThread::terminate):
(WebCore::StorageThread::performTerminate):

  • storage/wince/StorageThreadWinCE.h: Renamed from Source/WebCore/storage/wince/LocalStorageThreadWinCE.h.

(WebCore):
(StorageThread):
(WebCore::StorageThread::create):

12:34 AM Changeset in webkit [108745] by pfeldman@chromium.org
  • 24 edits in trunk/Source/WebCore

Web Inspector: prepare border images on timelines to enable zooming.
https://bugs.webkit.org/show_bug.cgi?id=79360

Reviewed by Yury Semikhatsky.

  • inspector/front-end/Images/timelineBarBlue.png:
  • inspector/front-end/Images/timelineBarGray.png:
  • inspector/front-end/Images/timelineBarGreen.png:
  • inspector/front-end/Images/timelineBarOrange.png:
  • inspector/front-end/Images/timelineBarPurple.png:
  • inspector/front-end/Images/timelineBarRed.png:
  • inspector/front-end/Images/timelineBarYellow.png:
  • inspector/front-end/Images/timelineHollowPillBlue.png:
  • inspector/front-end/Images/timelineHollowPillGray.png:
  • inspector/front-end/Images/timelineHollowPillGreen.png:
  • inspector/front-end/Images/timelineHollowPillOrange.png:
  • inspector/front-end/Images/timelineHollowPillPurple.png:
  • inspector/front-end/Images/timelineHollowPillRed.png:
  • inspector/front-end/Images/timelineHollowPillYellow.png:
  • inspector/front-end/Images/timelinePillBlue.png:
  • inspector/front-end/Images/timelinePillGray.png:
  • inspector/front-end/Images/timelinePillGreen.png:
  • inspector/front-end/Images/timelinePillOrange.png:
  • inspector/front-end/Images/timelinePillPurple.png:
  • inspector/front-end/Images/timelinePillRed.png:
  • inspector/front-end/Images/timelinePillYellow.png:
  • inspector/front-end/inspectorCommon.css:

(body):

  • inspector/front-end/networkLogView.css:

(.network-graph-bar):
(.resource-cached .network-graph-bar):
(.network-category-documents .network-graph-bar):
(.network-category-documents.resource-cached .network-graph-bar):
(.network-category-stylesheets .network-graph-bar):
(.network-category-stylesheets.resource-cached .network-graph-bar):
(.network-category-images.resource-cached .network-graph-bar):
(.network-category-fonts .network-graph-bar):
(.network-category-fonts.resource-cached .network-graph-bar):
(.network-category-scripts .network-graph-bar):
(.network-category-scripts.resource-cached .network-graph-bar):
(.network-category-xhr .network-graph-bar):
(.network-category-xhr.resource-cached .network-graph-bar):
(.network-category-websockets .network-graph-bar):
(.network-category-websockets.resource-cached .network-graph-bar):

12:33 AM Changeset in webkit [108744] by abarth@webkit.org
  • 7 edits in trunk/Tools

style-queue tries to apply the patch twice
https://bugs.webkit.org/show_bug.cgi?id=79459

Reviewed by Eric Seidel.

Previously, we applied the patch using both apply-patch and
check-style. This patch introduces a check-style-local to mirror the
apply-watchlist-local, which operates on the current working diff.

This patch also cleans up some other bugs I found by running the queue
locally for a while. The queue still prints out a slightly
less-than-ideal message on the bugs when it find an error, but it's ok
for now. We'll need to iterate a bit.

  • Scripts/webkitpy/tool/bot/stylequeuetask.py:

(StyleQueueTask.validate):
(StyleQueueTask._check_style):

  • Scripts/webkitpy/tool/commands/download.py:

(CheckStyleLocal):

  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

(EarlyWarningSytemTest._default_expected_stderr):
(EarlyWarningSytemTest._test_testing_ews):

  • Scripts/webkitpy/tool/commands/queues.py:

(AbstractReviewQueue.handle_script_error):
(StyleQueue.review_patch):

  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/queuestest.py:

(QueuesTest.assert_queue_outputs):

12:28 AM Changeset in webkit [108743] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: exception in front-end on selecting an element in heap snapshot
https://bugs.webkit.org/show_bug.cgi?id=79447

Fixed a typo in method name and added a check that selected node has
corresponding heap snapshot object before adding that object to the console
as $0 entry.

Reviewed by Pavel Feldman.

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype._inspectedObjectChanged):

12:20 AM Changeset in webkit [108742] by commit-queue@webkit.org
  • 7 edits
    3 adds in trunk

\u200c and \u200d should be allowed in IdentifierPart, as per ES5
https://bugs.webkit.org/show_bug.cgi?id=78908

Source/JavaScriptCore:

Add additional checks for zero-width non-joiner (0x200C) and
zero-width joiner (0x200D) characters.

Patch by Mathias Bynens <mathias@qiwi.be> on 2012-02-24
Reviewed by Michael Saboff.

  • parser/Lexer.cpp:

(JSC::isNonASCIIIdentPart)

  • runtime/LiteralParser.cpp:

(JSC::::Lexer::lexIdentifier)

LayoutTests:

Patch by Mathias Bynens <mathias@qiwi.be> on 2012-02-24
Reviewed by Michael Saboff.

  • fast/js/var-declarations-zero-width-expected.txt: Added.
  • fast/js/var-declarations-zero-width.html: Added.
  • fast/js/removing-Cf-characters-expected.txt: Removed the ZWJ test.
  • fast/js/script-tests/removing-Cf-characters.js: Removed the ZWJ test.
  • fast/js/script-tests/var-declarations-zero-width.js: Added.
  • platform/chromium/test_expectations.txt: Disable the new test in Chromium, for now.
12:17 AM Changeset in webkit [108741] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed test expectation change.
svg/repaint/image-with-clip-path.svg is flaky for DEBUG builds.

  • platform/chromium/test_expectations.txt:
12:11 AM Changeset in webkit [108740] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed test expectation change.
svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm is flaky for DEBUG builds.

  • platform/chromium/test_expectations.txt:
12:00 AM Changeset in webkit [108739] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Skip failing tests.
Note: See TracTimeline for information about the timeline view.