Timeline
Mar 2, 2012:
- 11:43 PM Changeset in webkit [109655] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip a new crashing test.
- platform/qt-5.0-wk2/Skipped:
- 11:34 PM Changeset in webkit [109654] by
-
- 3 edits2 adds in trunk/LayoutTests
[Qt] Unreviewed gardening, updated expected files.
- platform/qt/editing/selection/select-line-break-with-opposite-directionality-expected.png: Added.
- platform/qt/editing/selection/select-line-break-with-opposite-directionality-expected.txt: Added.
- platform/qt/fast/dom/prototype-inheritance-2-expected.png:
- platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
- 9:48 PM Changeset in webkit [109653] by
-
- 4 edits4 adds in trunk
Editor's default paragraph separator is not reset when a frame's document is changed
https://bugs.webkit.org/show_bug.cgi?id=80065
Patch by Pablo Flouret <pablof@motorola.com> on 2012-03-02
Reviewed by Ryosuke Niwa.
Source/WebCore:
Test: editing/execCommand/reset-values-after-navigation.html
- editing/Editor.cpp:
(WebCore::Editor::clear):
LayoutTests:
- editing/execCommand/default-paragraph-separator.html: Last line of the test did a manual reset of the value to work around this problem. Removed.
- editing/execCommand/reset-values-after-navigation-expected.txt: Added.
- editing/execCommand/reset-values-after-navigation.html: Added.
- editing/execCommand/resources/reset-default-values-helper-1.html: Added.
- editing/execCommand/resources/reset-default-values-helper-2.html: Added.
- 9:31 PM Changeset in webkit [109652] by
-
- 2 edits1 add in trunk/Source/WebCore
Have a copy of plug-in sandboxing API header in WebCore
https://bugs.webkit.org/show_bug.cgi?id=80185
<rdar://problem/8242128>
Reviewed by Anders Carlsson.
- plugins/npapi-sandbox.h: Added.
- WebCore.xcodeproj/project.pbxproj: Added as unused file.
- 7:28 PM Changeset in webkit [109651] by
-
- 1 edit2 adds in trunk/LayoutTests
:empty should apply to elements made empty via page dynamics
https://bugs.webkit.org/show_bug.cgi?id=79734
Reviewed by Antonio Gomes.
- fast/css/pseudo-empty-dynamic-empty-expected.txt: Added.
- fast/css/pseudo-empty-dynamic-empty.html: Added.
- 7:18 PM Changeset in webkit [109650] by
-
- 16 edits in tags/Safari-536.2
Merged r109340.
- 7:18 PM Changeset in webkit [109649] by
-
- 2 edits in trunk/Tools
Fix commit queue, remove duplicate entry.
- Scripts/webkitpy/common/config/committers.py:
- 7:16 PM Changeset in webkit [109648] by
-
- 4 edits in tags/Safari-536.2/Source
Versioning.
- 7:13 PM Changeset in webkit [109647] by
-
- 1 copy in tags/Safari-536.2
New Tag.
- 6:41 PM Changeset in webkit [109646] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Expose WebInspector state to client and clean up WebSettings
https://bugs.webkit.org/show_bug.cgi?id=80177
Patch by Mike Fenton <mifenton@rim.com> on 2012-03-02
Reviewed by Antonio Gomes.
Expose the Web Inspector state to WebPage client's and
re-order initialization of WebSettings to be alphabetical
matching their definitions.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::isWebInspectorEnabled):
- Api/WebPage.h:
- Api/WebSettings.cpp:
(BlackBerry::WebKit::WebSettings::standardSettings):
- 6:35 PM Changeset in webkit [109645] by
-
- 2 edits in trunk/Tools
Unreviewed, add myself as a committer * Scripts/webkitpy/common/config/committers.py:
- 5:52 PM Changeset in webkit [109644] by
-
- 3 edits in trunk/LayoutTests
ES5.1-15.3.5.4. prohibits Function.caller from Get?ting a strict caller
https://bugs.webkit.org/show_bug.cgi?id=80011
We now support getting the caller from within an accessor.
Reviewed by Sam Weinig.
- fast/js/function-dot-arguments-and-caller.html:
- platform/qt/Skipped:
- 5:48 PM Changeset in webkit [109643] by
-
- 1 edit2 adds in trunk/LayoutTests
Chrome 18 fails html5test.com XHR Blob response test
https://bugs.webkit.org/show_bug.cgi?id=76760
Unreviewed rebaselining. Cr-Linux returns
application/javascript for .js files instead of text/javascript.
- platform/chromium-linux/fast/files/xhr-response-blob-expected.txt: Added.
- 5:47 PM Changeset in webkit [109642] by
-
- 7 edits in trunk/Source/WebCore
Revert borders to integers for subpixel layout
https://bugs.webkit.org/show_bug.cgi?id=80175
Reviewed by Eric Seidel.
Change border representation and calculation back to integers to ensure
that borders given the same width are rendered with the same actual width.
This will also avoid unnecessary type conversions when we switch over
to subpixel precision.
No new tests.
- rendering/LayoutTypes.h:
(WebCore::pixelSnappedIntRect):
(WebCore):
- rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::borderTop):
(WebCore::RenderBoxModelObject::borderBottom):
(WebCore::RenderBoxModelObject::borderLeft):
(WebCore::RenderBoxModelObject::borderRight):
(WebCore::RenderBoxModelObject::borderBefore):
(WebCore::RenderBoxModelObject::borderAfter):
(WebCore::RenderBoxModelObject::borderStart):
(WebCore::RenderBoxModelObject::borderEnd):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
(WebCore::RenderTable::calcBorderStart):
(WebCore::RenderTable::calcBorderEnd):
(WebCore::RenderTable::borderBefore):
(WebCore::RenderTable::borderAfter):
(WebCore::RenderTable::outerBorderBefore):
(WebCore::RenderTable::outerBorderAfter):
(WebCore::RenderTable::outerBorderStart):
(WebCore::RenderTable::outerBorderEnd):
- rendering/RenderTable.h:
(WebCore::RenderTable::borderStart):
(WebCore::RenderTable::borderEnd):
(RenderTable):
(WebCore::RenderTable::borderLeft):
(WebCore::RenderTable::borderRight):
(WebCore::RenderTable::borderTop):
(WebCore::RenderTable::borderBottom):
(WebCore::RenderTable::outerBorderLeft):
(WebCore::RenderTable::outerBorderRight):
(WebCore::RenderTable::outerBorderTop):
(WebCore::RenderTable::outerBorderBottom):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
(WebCore::RenderTableCell::borderLeft):
(WebCore::RenderTableCell::borderRight):
(WebCore::RenderTableCell::borderTop):
(WebCore::RenderTableCell::borderBottom):
(WebCore::RenderTableCell::borderStart):
(WebCore::RenderTableCell::borderEnd):
(WebCore::RenderTableCell::borderBefore):
(WebCore::RenderTableCell::borderAfter):
(WebCore::RenderTableCell::borderHalfLeft):
(WebCore::RenderTableCell::borderHalfRight):
(WebCore::RenderTableCell::borderHalfTop):
(WebCore::RenderTableCell::borderHalfBottom):
(WebCore::RenderTableCell::borderHalfStart):
(WebCore::RenderTableCell::borderHalfEnd):
(WebCore::RenderTableCell::borderHalfBefore):
(WebCore::RenderTableCell::borderHalfAfter):
(WebCore::RenderTableCell::paintCollapsedBorders):
- rendering/RenderTableCell.h:
(RenderTableCell):
- 5:32 PM Changeset in webkit [109641] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed, remove an erroneous expected result that showed up in r109303.
- platform/chromium-linux/fast/workers/storage/use-same-database-in-page-and-workers-expected.txt: Removed.
- 5:24 PM Changeset in webkit [109640] by
-
- 2 edits in trunk/LayoutTests
Mark a few tests as flaky on Leopard debug.
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 5:22 PM Changeset in webkit [109639] by
-
- 8 edits in branches/subpixellayout/Source
Change RenderBox::borderBoundingBox to return pixel snapped values and get rid of pixelSnapped version of same.
- 5:22 PM Changeset in webkit [109638] by
-
- 3 edits in trunk/Source/WebKit/blackberry
Accelerated compositing: Checkerboard never goes away
https://bugs.webkit.org/show_bug.cgi?id=79020
RIM PR #134164
Patch by Arvid Nilsson <anilsson@rim.com> on 2012-03-02
Reviewed by Adam Treat.
Checkerboard appears in accelerated compositing layers when there's no
texture for (part of) a layer. The layer renderer queues up some render
jobs and schedules a commit to make the WebKit thread process those
jobs. Render jobs performed during commit cause texture upload jobs to
be scheduled on the UI thread. Texture uploads are performed when next
drawing the layers.
Unfortunately, sometimes commit operation happens without a subsequent
call draw the layers.
In order to implement one-shot drawing sync, I added a call to
commitRootLayerIfNeeded() in BackingStore::renderContents(), and
I was lucky that most of the time, renderContents() is followed by
blit(Visible)Contents() which in turn draws the layers.
However, render is not always followed by a blit, for example when
rendering offscreen tiles in BackingStore::renderOnIdle(), and in
direct rendering mode.
Fixed by making sure that every call to commitRootLayerIfNeeded() that
returns true is followed by a call to drawLayersOnCommit(), unless a
blit was requested already.
Also tweak the logic for one-shot drawing sync to make the code in
drawLayersOnCommit() reusable outside of rootLayerCommitTimerFired().
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::renderOnTimer):
(BlackBerry::WebKit::BackingStorePrivate::renderOnIdle):
(BlackBerry::WebKit::BackingStorePrivate::willFireTimer):
(BlackBerry::WebKit::BackingStorePrivate::renderDirectToWindow):
(BlackBerry::WebKit::BackingStorePrivate::render):
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
(BlackBerry::WebKit::BackingStorePrivate::blitContents):
(BlackBerry::WebKit::BackingStorePrivate::renderContents):
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::drawLayersOnCommitIfNeeded):
- Api/BackingStore_p.h:
(BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::willDrawLayersOnCommit):
- 5:03 PM Changeset in webkit [109637] by
-
- 2 edits in trunk/LayoutTests
Another test fix after r109593. Remove the extra start body tag.
- editing/selection/select-line-break-with-opposite-directionality.html:
- 4:59 PM Changeset in webkit [109636] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed rebaseline for Leopard.
- platform/chromium-mac-leopard/fast/dom/scroll-reveal-left-overflow-expected.png: Added.
- 4:57 PM Changeset in webkit [109635] by
-
- 4 edits5 adds in trunk
Chrome 18 fails html5test.com XHR Blob response test
https://bugs.webkit.org/show_bug.cgi?id=76760
Reviewed by Adam Barth.
Source/WebCore:
Most of the code was already there, this just fixes the FIXME
which was causing this feature not to work. Chromium already
had this #ifdef enabled, but other ports (at least Mac) do not.
Test: fast/files/xhr-response-blob.html
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::didFinishLoading):
LayoutTests:
- fast/files/script-tests/xhr-response-blob.js: Added.
(xhr.onreadystatechange):
- fast/files/xhr-response-blob-expected.txt: Added.
- fast/files/xhr-response-blob.html: Added.
- platform/chromium/fast/files/xhr-response-blob-expected.txt: Added.
- 4:50 PM Changeset in webkit [109634] by
-
- 7 edits1 delete in trunk/Source/WebCore
Revert Worker-related APIs from DOMWindowWorker.idl back to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=80151
Reviewed by Adam Barth.
Based on the discussion on webkit-dev@
(http://markmail.org/message/kagvswmah67zmrry#query:+page:1+mid:h34vzbiu5suub3ld+state:results),
this patch reverts Worker-related APIs from DOMWindowWorker.idl back to DOMWindow.idl.
No tests. No change in behavior.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- WebCore.gypi:
- page/DOMWindow.idl:
- workers/DOMWindowWorker.idl: Removed.
- 4:39 PM Changeset in webkit [109633] by
-
- 9 edits2 adds in trunk/Source/WebKit2
Move nsStringFromWebCoreString out of PageClientImpl
https://bugs.webkit.org/show_bug.cgi?id=80202
Reviewed by Sam Weinig.
nsStringFromWebCoreString() doesn't really belong in PageClientImpl.mm,
and it makes us include PageClientImpl.h in places where we shouldn't.
Move this function into StringUtilities.{h, mm}.
- Platform/mac/StringUtilities.h: Added.
- Platform/mac/StringUtilities.mm: Added.
(WebKit::nsStringFromWebCoreString):
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
- UIProcess/API/mac/WKView.mm:
- UIProcess/mac/WebContextMenuProxyMac.mm:
- UIProcess/mac/WebPageProxyMac.mm:
- UIProcess/mac/WebPopupMenuProxyMac.mm:
- UIProcess/mac/WebPreferencesMac.mm:
- WebKit2.xcodeproj/project.pbxproj:
- 4:29 PM Changeset in webkit [109632] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test expectations cleanup.
Marked a bunch of flakiness as happening only in DEBUG,
and removed a whole set of tests that are no longer flaky.
- platform/chromium/test_expectations.txt:
- 4:19 PM Changeset in webkit [109631] by
-
- 2 edits33 adds in trunk/LayoutTests
Unreviewed rebaseline of SVG feImage tests after r105612 and r106113.
- platform/chromium-linux/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png: Added.
- platform/chromium-linux/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png: Added.
- platform/chromium-linux/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png: Added.
- platform/chromium-linux/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png: Added.
- platform/chromium-mac-leopard/svg/filters/feImage-subregions-expected.png: Added.
- platform/chromium-mac-leopard/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png: Added.
- platform/chromium-mac-leopard/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-position-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-subregions-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-target-add-to-document-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-target-changes-id-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-target-id-change-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-target-reappend-to-document-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-target-remove-from-document-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-position-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-subregions-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-target-add-to-document-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-target-changes-id-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-target-id-change-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-target-reappend-to-document-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-target-remove-from-document-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 4:15 PM Changeset in webkit [109630] by
-
- 8 edits1 delete in trunk/Source/WebCore
Revert HTML-related APIs from DOMWindowHTML.idl back to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=80140
Reviewed by Adam Barth.
Based on the discussion on webkit-dev@
(http://markmail.org/message/kagvswmah67zmrry#query:+page:1+mid:h34vzbiu5suub3ld+state:results),
we should revert HTML-related APIs from DOMWindowHTML.idl back to DOMWindow.idl.
No tests. No change in behavior.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- html/DOMWindowHTML.idl: Removed.
- page/DOMWindow.idl:
- 4:08 PM Changeset in webkit [109629] by
-
- 9 edits1 add1 delete in trunk/LayoutTests
Unreviewed, rebaseline some SVG tests after r105612.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
- platform/chromium-linux/svg/filters/feImage-reference-svg-primitive-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/filters/feImage-reference-invalidation-expected.png:
- platform/chromium-mac-snowleopard/svg/filters/feImage-reference-svg-primitive-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png: Removed.
- platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
- platform/chromium-win/svg/filters/feImage-reference-invalidation-expected.png:
- platform/chromium-win/svg/filters/feImage-reference-svg-primitive-expected.png:
- platform/chromium/test_expectations.txt:
- 3:59 PM Changeset in webkit [109628] by
-
- 8 edits1 delete in trunk/Source/WebCore
Revert XML-related APIs from DOMWindowXML.idl back to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=80148
Reviewed by Adam Barth.
Based on the discussion on webkit-dev@
(http://markmail.org/message/kagvswmah67zmrry#query:+page:1+mid:h34vzbiu5suub3ld+state:results),
this patch reverts XML-related APIs from DOMWindowXML.idl back to DOMWindow.idl.
No tests. No change in behavior.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- page/DOMWindow.idl:
- xml/DOMWindowXML.idl: Removed.
- 3:57 PM Changeset in webkit [109627] by
-
- 3 edits in trunk/Source/JavaScriptCore
When getting the line number of a call into a call frame with no code block, it's
incorrect to rely on the returnPC
https://bugs.webkit.org/show_bug.cgi?id=80195
Reviewed by Oliver Hunt.
- interpreter/Interpreter.cpp:
(JSC::getCallerInfo):
- jit/JITCall.cpp:
(JSC::JIT::compileLoadVarargs):
- 3:49 PM Changeset in webkit [109626] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening, widen flaky crash expectations for FileWriter test.
- platform/chromium/test_expectations.txt:
- 3:42 PM Changeset in webkit [109625] by
-
- 2 edits1 move12 adds1 delete in trunk/LayoutTests
Unreviewed rebaselining, update a bunch of old results for Snow Leopard.
- platform/chromium-linux/css2.1/t1605-c545-txttrans-00-b-ag-expected.png: Added.
- platform/chromium-mac-snowleopard/css1/text_properties/text_transform-expected.png: Added.
- platform/chromium-mac-snowleopard/css1/text_properties/text_transform-expected.txt: Added.
- platform/chromium-mac-snowleopard/css2.1/t1605-c545-txttrans-00-b-ag-expected.png: Added.
- platform/chromium-mac-snowleopard/css2.1/t1605-c545-txttrans-00-b-ag-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/canvas/arc360-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/transform-default-parameter-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/dom/scroll-reveal-left-overflow-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/dom/scroll-reveal-left-overflow-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/dom/scroll-reveal-left-overflow-expected.txt.
- platform/chromium-mac-snowleopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
- platform/chromium-mac-snowleopard/fonts/monospace-expected.png: Added.
- platform/chromium-mac-snowleopard/transitions/move-after-transition-expected.png: Added.
- platform/chromium-mac/fast/dom/scroll-reveal-left-overflow-expected.png: Removed.
- platform/chromium/test_expectations.txt:
- 3:42 PM Changeset in webkit [109624] by
-
- 5 edits in branches/subpixellayout/Source/WebCore/rendering
Clean up paintInfo and absoluteBoundingBox calling code on branch.
- 3:34 PM Changeset in webkit [109623] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test fix. Don't add an event listener for interactive debugging
when the test is ran inside a DumpRenderTree / WebKitTestRunner.
- editing/selection/select-line-break-with-opposite-directionality.html:
- 3:24 PM Changeset in webkit [109622] by
-
- 1 edit in trunk/Source/WebKit2/ChangeLog
Fix a ChangeLog typo.
- 3:23 PM Changeset in webkit [109621] by
-
- 2 edits in trunk/Source/WebKit2
Remove com.apple.WebKit.PluginProcess.sb from WebKit2.xcodeproj's Headers build phase
https://bugs.webkit.org/show_bug.cgi?id=80197
Reviewed by Alexey Proskuryakov.
It doesn't belong there, and it makes the Xcode consider the project to
be invalid, triggering assertions in some builds of Xcode.
- WebKit2.xcodeproj/project.pbxproj:
- 3:10 PM Changeset in webkit [109620] by
-
- 4 edits in trunk
Make webkit-gtk translations respect LINGUAS
https://bugs.webkit.org/show_bug.cgi?id=79605
Patch by Alexandre Rostovtsev <tetromino@gentoo.org> on 2012-03-02
Reviewed by Martin Robinson.
.:
PO_LINGUAS, USER_LINGUAS, and USE_LINGUAS added to root
GNUmakefile.am to ensure that they can be used in the definition of
MOFILES that will be generated by automake.
- GNUmakefile.am:
Source/WebKit/gtk/po:
- GNUmakefile.am:
- 2:48 PM Changeset in webkit [109619] by
-
- 4 edits in trunk/Source/WebCore
Implement NamedNodeMap::setNamedItem() in terms of Element::setAttributeNode() instead of the other way round
https://bugs.webkit.org/show_bug.cgi?id=80188
Reviewed by Ryosuke Niwa.
Using setNamedItem() in setAttributeNode() implementation made us do unnecessary
checks like whether the element existed or whether the given node was an
attribute. So now setAttributeNode() do less work.
No new tests were added, functionality should be unchanged.
- dom/Element.cpp:
(WebCore::Element::setAttributeNode):
(WebCore::Element::setAttributeNodeNS):
- dom/Element.h:
(Element):
(WebCore::Element::attributes): We got rid of ensureUpdatedAttributes(), next in
line will be updatedAttributes().
- dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::setNamedItem):
- 2:44 PM Changeset in webkit [109618] by
-
- 2 edits in trunk/Source/JavaScriptCore
Expected results updated for checking type conversion
https://bugs.webkit.org/show_bug.cgi?id=80138
Patch by Han Hojong <hojong.han@samsung.com> on 2012-03-02
Reviewed by Gavin Barraclough.
- tests/mozilla/ecma/TypeConversion/9.3.1-3.js:
- 2:41 PM Changeset in webkit [109617] by
-
- 7 edits6 copies3 moves4 adds34 deletes in trunk/LayoutTests
Unreviewed, rolling out r109602.
http://trac.webkit.org/changeset/109602
https://bugs.webkit.org/show_bug.cgi?id=80194
some TEXT baselines were wrong and some baselines were wrongly
removed (Requested by jchaffraix on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-02
- platform/chromium-linux-x86/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
- platform/chromium-linux/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
- platform/chromium-linux/fast/forms/input-text-double-click-expected.txt:
- platform/chromium-mac-leopard/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
- platform/chromium-mac-leopard/fast/layers/remove-layer-with-nested-stacking-expected.png: Removed.
- platform/chromium-mac-leopard/fast/repaint/overflow-delete-line-expected.png: Removed.
- platform/chromium-mac-leopard/fast/repaint/repaint-resized-overflow-expected.png: Removed.
- platform/chromium-mac-leopard/fast/repaint/subtree-layoutstate-transform-expected.png: Removed.
- platform/chromium-mac-leopard/fast/repaint/subtree-root-skipped-expected.png: Removed.
- platform/chromium-mac-leopard/fast/replaced/replaced-breaking-expected.png: Removed.
- platform/chromium-mac-leopard/fast/text/textIteratorNilRenderer-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/box-shadow/shadow-buffer-partial-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/layers/remove-layer-with-nested-stacking-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/layers/remove-layer-with-nested-stacking-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/inline-relative-positioned-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/inline-relative-positioned-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/overflow-delete-line-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/overflow-delete-line-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/repaint-resized-overflow-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/repaint-resized-overflow-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-layoutstate-transform-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-layoutstate-transform-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-2-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-root-skipped-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-root-skipped-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.txt: Removed.
- platform/chromium-mac/fast/box-shadow/shadow-buffer-partial-expected.png: Added.
- platform/chromium-mac/fast/clip/008-expected.png: Added.
- platform/chromium-mac/fast/clip/011-expected.png: Added.
- platform/chromium-mac/fast/clip/012-expected.png: Added.
- platform/chromium-win-vista/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
- platform/chromium-win-xp/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
- platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png:
- platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
- platform/chromium-win/fast/clip/008-expected.txt:
- platform/chromium-win/fast/clip/011-expected.txt:
- platform/chromium-win/fast/clip/012-expected.txt:
- platform/chromium/test_expectations.txt:
- platform/gtk/fast/layers/add-layer-with-nested-stacking-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.txt.
- platform/gtk/fast/repaint/subtree-root-clip-2-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-2-expected.txt.
- platform/gtk/fast/repaint/subtree-root-clip-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-expected.txt.
- platform/mac/fast/layers/add-layer-with-nested-stacking-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.txt.
- platform/mac/fast/repaint/subtree-root-clip-2-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-2-expected.txt.
- platform/mac/fast/repaint/subtree-root-clip-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-expected.txt.
- platform/qt/fast/layers/add-layer-with-nested-stacking-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.txt.
- platform/qt/fast/repaint/subtree-root-clip-2-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-2-expected.txt.
- platform/qt/fast/repaint/subtree-root-clip-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-expected.txt.
- 2:34 PM Changeset in webkit [109616] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Widen/correct a few chromium expectations.
- platform/chromium/test_expectations.txt:
- 2:25 PM Changeset in webkit [109615] by
-
- 2 edits in trunk/PerformanceTests
DOM tests take too long to run
https://bugs.webkit.org/show_bug.cgi?id=80082
Reviewed by Eric Seidel.
Reduce benchmark.timeToRun from 500ms to 100ms. Doesn't seem to affect test results much
(except DOM/DOMTable.html) but significantly reduces the runtime of tests.
- DOM/resources/dom-perf.js:
(BenchmarkSuite.prototype.RunSingle):
- 2:16 PM Changeset in webkit [109614] by
-
- 2 edits in trunk/LayoutTests
Rebaseline an inspector test after r109599.
"evt" was changed to "event", lengthening it by two characters.
Unreviewed gardening.
- platform/chromium/inspector/debugger/debugger-scripts-expected.txt:
- 2:00 PM Changeset in webkit [109613] by
-
- 2 edits in trunk/Tools
Add the Chromium Lion canary bot to the flakiness dashboard.
- TestResultServer/static-dashboards/builders.js:
- 1:59 PM Changeset in webkit [109612] by
-
- 4 edits3 adds in trunk
Layout issue with fieldset legend element
https://bugs.webkit.org/show_bug.cgi?id=78684
Patch by SravanKumar Sandela <ssandela@innominds.com> on 2012-03-02
Reviewed by Dirk Pranke.
Source/WebCore:
The clipping logic for legend element was incorrect and now it has been corrected by taking correct offset in to consideration.
Test: fast/forms/fieldset-legend-padding-unclipped-fieldset-border.html
- rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::paintBoxDecorations):
LayoutTests:
- fast/forms/fieldset-legend-padding-unclipped-fieldset-border.html: Added.
Test case to check un-clipped border logic
- platform/chromium/test_expectations.txt:
- platform/win/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png: Added.
- platform/win/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt: Added.
- 1:45 PM Changeset in webkit [109611] by
-
- 12 edits in trunk/Source/WebCore
[V8] Bindings for node always check if they are a Document.
https://bugs.webkit.org/show_bug.cgi?id=79947
Reviewed by Adam Barth.
This changes the generated bindings code to only generate the Document code for the Document wrappers.
No new tests. Covered by existing tests.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateToV8Converters):
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::wrapSlow):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::wrapSlow):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::wrapSlow):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::wrapSlow):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::wrapSlow):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::wrapSlow):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::wrapSlow):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::wrapSlow):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::wrapSlow):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
- 1:40 PM Changeset in webkit [109610] by
-
- 3 edits2 adds in trunk
animation-timing-function falls back to ease when overriding animation-name
https://bugs.webkit.org/show_bug.cgi?id=71623
Source/WebCore:
In this patch the animation name needs to be the first value declared, if
a different value is found, we do not check for the animation name again.
Reviewed by Dean Jackson.
Test: animations/animation-shorthand-overriding.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseAnimationShorthand):
LayoutTests:
Add a test to verify if the override the animation-name property works when the parent
animation did not set the animation name.
Reviewed by Dean Jackson.
- animations/animation-shorthand-overriding-expected.txt: Added.
- animations/animation-shorthand-overriding.html: Added.
- 1:37 PM Changeset in webkit [109609] by
-
- 6 edits1 move1 add1 delete in trunk/Source/WebCore
[GTK] [AC] Connect WebGL to the TextureMapperGL code
https://bugs.webkit.org/show_bug.cgi?id=78968
Reviewed by Gustavo Noronha Silva.
No new tests. This is covered by existing accelerated compositing and
WebGL tests.
Rely on the shared version of GL acquisition from GLContext. This reduces
a lot of code and now allows us to connect WebGL into the accelerated compositing
rendering path.
- GNUmakefile.list.am: GLContext should be included for all X11 builds now.
There are no longer GTK+ specific versions of GraphicsContext3D.
- platform/graphics/GraphicsContext3D.h: Add a default argument for
resolveMultisamplingIfNecessary. This will resolve the entire texture.
- platform/graphics/cairo/GraphicsContext3DCairo.cpp: GraphicsContext3D is
now responsible for creating GraphicsContext3DPrivate in the constructor.
(WebCore::GraphicsContext3D::platformLayer): Now return m_private.
- platform/graphics/cairo/GraphicsContext3DPrivate.cpp: Added.
- platform/graphics/cairo/GraphicsContext3DPrivate.h: Renamed from Source/WebCore/platform/graphics/glx/GraphicsContext3DPrivate.h.
- platform/graphics/glx/GraphicsContext3DPrivate.cpp: Removed.
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::resolveMultisamplingIfNecessary): Properly
handle the default argument.
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::prepareTexture): Use the new default argument now.
(WebCore::GraphicsContext3D::readRenderingResults): Ditto.
- 1:33 PM Changeset in webkit [109608] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Fix spelling mistake in header guard
Reviewed by Noam Rosenthal.
- 1:32 PM Changeset in webkit [109607] by
-
- 2 edits in trunk
[Qt] Remove deleted file from api.pro
Reviewed by Noam Rosenthal.
- 1:13 PM Changeset in webkit [109606] by
-
- 3 edits in trunk/Tools
links for virtual tests are broken in the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=80180
Reviewed by Ojan Vafai.
- TestResultServer/static-dashboards/flakiness_dashboard.html:
(linkHTMLToOpenWindow):
- TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
(testLinkHTMLToOpenWindow): added.
- 1:08 PM Changeset in webkit [109605] by
-
- 5 edits3 adds2 deletes in trunk/Source
[GTK] [AC] Generalize WindowContextGL
https://bugs.webkit.org/show_bug.cgi?id=78969
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
No new tests. This should not change functionality.
- GNUmakefile.list.am: Added new files to source list.
- platform/graphics/cairo/GLContext.h: Added. An abstraction for all GL contexts.
- platform/graphics/glx/GLContextGLX.cpp: Added. This file is composed of very little
new code, as the logic for instantiating offscreen GL contexts is copied from
GraphicsContext3DPrivate. The code duplication will be removed in a followup patch.
(WebCore::GLContext::platformContext):
- platform/graphics/gtk/GLContextGtk.cpp: Added. This includes some helper factories
for creating and caching GL contexts for GTK+ widgets.
Source/WebKit/gtk:
Use GLContext instead of WindowContextGL. Remove a few unnecessary
namespace specifiers in the implementation of AcceleratedCompositingContext.
- WebCoreSupport/AcceleratedCompositingContext.h: Now we find the GLContext
of our widget, which is cached in WebCore. Remove m_initialized as it isn't needed.
(AcceleratedCompositingContext):
- WebCoreSupport/AcceleratedCompositingContextGL.cpp:
(WebKit::AcceleratedCompositingContext::AcceleratedCompositingContext): No longer initialize
m_initialized.
(WebKit::AcceleratedCompositingContext::glContext): Added.
(WebKit::AcceleratedCompositingContext::renderLayersToWindow): Use glContext() now.
(WebKit::AcceleratedCompositingContext::attachRootGraphicsLayer): Ditto.
(WebKit::AcceleratedCompositingContext::notifyAnimationStarted): Remove unnecessary namespace specifier.
(WebKit::AcceleratedCompositingContext::notifySyncRequired): Ditto.
(WebKit::AcceleratedCompositingContext::paintContents): Ditto.
(WebKit::AcceleratedCompositingContext::showDebugBorders): Ditto.
(WebKit::AcceleratedCompositingContext::showRepaintCounter): Ditto.
- 12:58 PM Changeset in webkit [109604] by
-
- 6 edits2 adds in trunk/LayoutTests
new baselines for Skia shadows
Unreviewed rebaselining.
- platform/chromium-win-vista/svg/css/group-with-shadow-expected.png:
- platform/chromium-win-xp/svg/css: Added.
- platform/chromium-win-xp/svg/css/group-with-shadow-expected.png: Added.
- platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
- platform/chromium-win/fast/transforms/shadows-expected.png:
- platform/chromium-win/svg/css/group-with-shadow-expected.png:
- platform/chromium/test_expectations.txt:
- 12:54 PM Changeset in webkit [109603] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Suppress an inspector test timing out after r109561.
- platform/chromium/test_expectations.txt:
- 12:45 PM Changeset in webkit [109602] by
-
- 7 edits40 adds13 deletes in trunk/LayoutTests
Unreviewed Chromium rebaselining.
Those tests have consistent results with other platforms and with the expected
result so unmark and rebaseline them.
- platform/chromium-linux-x86/fast/box-shadow: Added.
- platform/chromium-linux-x86/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
- platform/chromium-linux/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
- platform/chromium-linux/fast/forms/input-text-double-click-expected.txt:
- platform/chromium-mac-leopard/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
- platform/chromium-mac-leopard/fast/layers/remove-layer-with-nested-stacking-expected.png: Added.
- platform/chromium-mac-leopard/fast/repaint/overflow-delete-line-expected.png: Added.
- platform/chromium-mac-leopard/fast/repaint/repaint-resized-overflow-expected.png: Added.
- platform/chromium-mac-leopard/fast/repaint/subtree-layoutstate-transform-expected.png: Added.
- platform/chromium-mac-leopard/fast/repaint/subtree-root-skipped-expected.png: Added.
- platform/chromium-mac-leopard/fast/replaced/replaced-breaking-expected.png: Added.
- platform/chromium-mac-leopard/fast/text/textIteratorNilRenderer-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/box-shadow/shadow-buffer-partial-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/layers/remove-layer-with-nested-stacking-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/layers/remove-layer-with-nested-stacking-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/repaint/inline-relative-positioned-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/inline-relative-positioned-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/repaint/overflow-delete-line-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/overflow-delete-line-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/repaint/repaint-resized-overflow-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/repaint-resized-overflow-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-layoutstate-transform-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-layoutstate-transform-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-2-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-2-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-root-skipped-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/subtree-root-skipped-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.txt: Added.
- platform/chromium-mac/fast/box-shadow/shadow-buffer-partial-expected.png: Removed.
- platform/chromium-mac/fast/clip/008-expected.png: Removed.
- platform/chromium-mac/fast/clip/011-expected.png: Removed.
- platform/chromium-mac/fast/clip/012-expected.png: Removed.
- platform/chromium-win-vista/fast/box-shadow: Added.
- platform/chromium-win-vista/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
- platform/chromium-win-xp/fast/box-shadow: Added.
- platform/chromium-win-xp/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
- platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png:
- platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
- platform/chromium-win/fast/clip/008-expected.txt:
- platform/chromium-win/fast/clip/011-expected.txt:
- platform/chromium-win/fast/clip/012-expected.txt:
- platform/chromium/test_expectations.txt:
- platform/gtk/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
- platform/gtk/fast/repaint/subtree-root-clip-2-expected.txt: Removed.
- platform/gtk/fast/repaint/subtree-root-clip-expected.txt: Removed.
- platform/mac/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
- platform/mac/fast/repaint/subtree-root-clip-2-expected.txt: Removed.
- platform/mac/fast/repaint/subtree-root-clip-expected.txt: Removed.
- platform/qt/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
- platform/qt/fast/repaint/subtree-root-clip-2-expected.txt: Removed.
- platform/qt/fast/repaint/subtree-root-clip-expected.txt: Removed.
- 12:39 PM Changeset in webkit [109601] by
-
- 2 edits9 adds in trunk/LayoutTests
Rebaselining SVG foreignObject tests after r108494.
Unreviewed gardening.
- platform/chromium-linux/svg/foreignObject/fO-parent-display-changes-expected.png: Added.
- platform/chromium-mac-leopard/svg/foreignObject/fO-parent-display-changes-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/foreignObject/fO-parent-display-changes-expected.png: Added.
- platform/chromium-win/svg/foreignObject/fO-parent-display-changes-expected.png: Added.
- platform/chromium-win/svg/foreignObject/fO-parent-display-changes-expected.txt: Added.
- platform/chromium-win/svg/foreignObject/fO-parent-display-none-expected.txt: Added.
- platform/chromium-win/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt: Added.
- platform/chromium-win/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt: Added.
- platform/chromium-win/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 12:34 PM Changeset in webkit [109600] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Remove TRACE_EVENT from CCQuadCuller::cullOccludedQuads.
https://bugs.webkit.org/show_bug.cgi?id=80174
Reviewed by James Robinson.
Covered by existing chromium unit tests.
Firing TRACE_EVENT once per draw quad is overwhelming.
- platform/graphics/chromium/cc/CCQuadCuller.cpp:
(WebCore::CCQuadCuller::cullOccludedQuads):
- 12:30 PM Changeset in webkit [109599] by
-
- 3 edits2 adds in trunk
[V8] Make inline event attributes use evt for SVG and event otherwise
https://bugs.webkit.org/show_bug.cgi?id=80167
Reviewed by Ojan Vafai.
Source/WebCore:
Test: fast/dom/inline-event-attributes-event-param-name.html
- bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):
LayoutTests:
- fast/dom/inline-event-attributes-event-param-name-expected.txt: Added.
- fast/dom/inline-event-attributes-event-param-name.html: Added.
- 12:11 PM Changeset in webkit [109598] by
-
- 2 edits in trunk/Source/WebCore
Sync PageCache debugging with PageCache behaviour
https://bugs.webkit.org/show_bug.cgi?id=79943
Sync up the debug printing code in PageCache with the actual logic,
and clean up the debug printing at the same time.
Reviewed by Brady Eidson.
No new tests, as this is a refactor of debug only code.
- history/PageCache.cpp:
(WebCore):
(WebCore::logCanCacheFrameDecision):
(WebCore::logCanCachePageDecision):
- 12:07 PM Changeset in webkit [109597] by
-
- 2 edits in trunk/LayoutTests
Fix expectation for svg/foreignObject/fO-parent-display-changes.svg.
Unreviewed, expectations change.
- platform/chromium/test_expectations.txt:
- 12:05 PM Changeset in webkit [109596] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening, suppress some failures in shadow tests due to the skia roll.
- platform/chromium/test_expectations.txt:
- 12:01 PM Changeset in webkit [109595] by
-
- 2 edits in trunk/LayoutTests
[chromium] Layout test fast/events/overflow-events.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=52064
Reviewed by Simon Fraser.
Try to make the test less flaky.
- fast/events/overflow-events.html:
Ensure that the 'overflow' events arrive one at a time in order (there is no guarantee that they *do* dispatch
though). Also added a clearer message if we fail the test. That should help us if the test is still flaky.
- 11:58 AM Changeset in webkit [109594] by
-
- 6 edits4 adds in trunk
Source/WebCore: REGRESSION(r97353): Crash when accessing location or history properties inside a navigated window
https://bugs.webkit.org/show_bug.cgi?id=80133
<rdar://problem/10432233>
Reviewed by Antti Koivisto.
Test: fast/dom/Window/navigated-window-properties.html
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore): Remove custom getters for window.location and window.history; they
were unnecessary and did the wrong thing when DOMWindow returned null values
for these.
- page/DOMWindow.idl: ditto
- bindings/js/JSDOMBinding.cpp:
(WebCore::reportException): Remove assert about null values and update comment,
since this is now an expected state for navigated inner windows.
LayoutTests: REGRESSION(r97353): Crash when accessing location or history properties inside a navigated window
https://bugs.webkit.org/show_bug.cgi?id=80133
Reviewed by Antti Koivisto.
- fast/dom/Window/navigated-window-properties-expected.txt: Added.
- fast/dom/Window/navigated-window-properties.html: Added.
- fast/dom/Window/resources/navigated-window-prop-subframe1.html: Added.
- fast/dom/Window/resources/navigated-window-prop-subframe2.html: Added.
- 11:54 AM Changeset in webkit [109593] by
-
- 9 edits2 adds in trunk
REGRESSION(r74971): Can't select a line of RTL text on Facebook
https://bugs.webkit.org/show_bug.cgi?id=59435
Reviewed by Eric Seidel.
Source/WebCore:
The bug was caused by inline text boxes created by BRs being placed at the end of the line
according to the block's direction regardless of its unicode bidi-level. e.g. if we have
<div dir="rtl"><span dir="ltr">hello<br>world</span></div>
the inline box generated by the br has the bidi-level of 2 like the rest of text in the span.
This inline text box gives an illusion of having text on the left of "hello" to hit testing
and editing code and causes all sorts of problems.
Fixed the bug by replacing calls to nextLeafChild and prevLeafChild by newly introduced
nextLeafChildIgnoringLineBreak and prevLeafChildIgnoringLineBreak. These two functions will
return 0 when they hit the end of a line or inline text box that's a line break. In effect,
hit testing and editing code can ignore inline boxes generated by br's.
In the long term, we should move these two functions into RenderedPosition along with the rest
of code that converts a Position and an inline box, offset pair.
Test: editing/selection/select-line-break-with-opposite-directionality.html
- dom/Position.cpp:
(WebCore::Position::getInlineBoxAndOffset):
- editing/RenderedPosition.cpp:
(WebCore::RenderedPosition::prevLeafChild):
(WebCore::RenderedPosition::nextLeafChild):
- rendering/InlineBox.cpp:
(WebCore::InlineBox::nextLeafChildIgnoringLineBreak):
(WebCore::InlineBox::prevLeafChildIgnoringLineBreak):
- rendering/InlineBox.h:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::positionForPointWithInlineChildren):
- rendering/RenderText.cpp:
(WebCore::lineDirectionPointFitsInBox): If we're on the left of a RTL line, we should stay at
upstream position since we're at the end of a line.
(WebCore::createVisiblePositionAfterAdjustingOffsetForBiDi): Merge the two special cases into
the general loop as the comment suggests. Skip an inline text box for a line break at the left
edge when there are more line boxes on the line.
(WebCore::RenderText::positionForPoint):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::closestLeafChildForLogicalLeftPosition): Ignore line boxes created for
line boxes when there are other boxes on the line.
LayoutTests:
Add a regression test for selecting multiline bidirectional text.
- editing/selection/select-line-break-with-opposite-directionality-expected.txt: Added.
- editing/selection/select-line-break-with-opposite-directionality.html: Added.
- 11:48 AM Changeset in webkit [109592] by
-
- 7 edits in trunk/Source
https://bugs.webkit.org/show_bug.cgi?id=80161
PR: 141157
BlackBerryPlatformScreen.h API has been updated. Reflect those
changes in our usage.
Source/WebCore:
Patch by Adam Treat <atreat@rim.com> on 2012-03-02
Reviewed by Antonio Gomes.
Internally reviewed by Jakob Petsovits
- platform/blackberry/PlatformScreenBlackBerry.cpp:
(WebCore::screenAvailableRect):
(WebCore::screenRect):
Source/WebKit/blackberry:
Patch by Adam Treat <atreat@rim.com> on 2012-03-02
Reviewed by Antonio Gomes.
Internally reviewed by Jakob Petsovits.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::tileWidth):
(BlackBerry::WebKit::BackingStorePrivate::tileHeight):
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPagePrivate::transformedViewportSize):
(BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):
(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
(BlackBerry::WebKit::WebPagePrivate::setDefaultLayoutSize):
(BlackBerry::WebKit::WebPagePrivate::defaultMaxLayoutSize):
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::restoreViewState):
- WebKitSupport/SurfacePool.cpp:
(BlackBerry::WebKit::createCompositingSurface):
- 11:47 AM Changeset in webkit [109591] by
-
- 14 edits1 move7 adds2 deletes in trunk/LayoutTests
Chromium rebaselines after r109512.
Unreviewed gardening.
- platform/chromium-linux/fast/block/float/026-expected.png:
- platform/chromium-linux/fast/block/float/028-expected.png:
- platform/chromium-linux/fast/overflow/unreachable-overflow-rtl-bug-expected.png:
- platform/chromium-mac-leopard/fast/block/float/026-expected.png:
- platform/chromium-mac-leopard/fast/block/float/028-expected.png:
- platform/chromium-mac-leopard/fast/overflow/unreachable-overflow-rtl-bug-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/block/float/026-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/block/float/026-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/block/float/028-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/block/float/028-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/events/offsetX-offsetY-expected.txt: Renamed from LayoutTests/platform/chromium/fast/events/offsetX-offsetY-expected.txt.
- platform/chromium-mac-snowleopard/fast/overflow/unreachable-overflow-rtl-bug-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/overflow/unreachable-overflow-rtl-bug-expected.txt: Added.
- platform/chromium-mac/fast/block/float/026-expected.png: Removed.
- platform/chromium-mac/fast/block/float/028-expected.png: Removed.
- platform/chromium-win/fast/block/float/026-expected.png:
- platform/chromium-win/fast/block/float/026-expected.txt:
- platform/chromium-win/fast/block/float/028-expected.png:
- platform/chromium-win/fast/block/float/028-expected.txt:
- platform/chromium-win/fast/events/offsetX-offsetY-expected.txt:
- platform/chromium-win/fast/overflow/unreachable-overflow-rtl-bug-expected.png:
- platform/chromium-win/fast/overflow/unreachable-overflow-rtl-bug-expected.txt:
- platform/chromium/test_expectations.txt:
- 11:44 AM Changeset in webkit [109590] by
-
- 4 edits in trunk/Source/WebKit/chromium
[Chromium] Allow plugins to set opaque() on their platform layer
https://bugs.webkit.org/show_bug.cgi?id=80171
Patch by Dana Jansens <danakj@chromium.org> on 2012-03-02
Reviewed by James Robinson.
- public/WebPluginContainer.h:
(WebPluginContainer):
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::setOpaque):
(WebKit):
- src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
- 11:41 AM Changeset in webkit [109589] by
-
- 2 edits in trunk/Source/WebCore
Move the 'overflow' event dispatching logic out of RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=80090
Unreviewed build fix.
- rendering/RenderBlock.cpp:
(OverflowEventDispatcher): Removed the unused function.
- 11:28 AM Changeset in webkit [109588] by
-
- 111 edits3 adds29 deletes in trunk/LayoutTests
Unreviewed rebaselining of images affected by these changes:
https://bugs.webkit.org/show_bug.cgi?id=76556 ('Match style of platform error underline for misspellings')
https://bugs.webkit.org/show_bug.cgi?id=78117 ('[Skia Mac] Make misspelling underline dots unclipped')
- platform/chromium-mac-leopard/editing/deleting/delete-3928305-fix-expected.png:
[139 lines deleted]
- platform/chromium-mac-snowleopard/fast/dom/blur-contenteditable-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 11:24 AM Changeset in webkit [109587] by
-
- 6 edits2 adds in trunk
Move the 'overflow' event dispatching logic out of RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=80090
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/events/overflow-events-writing-mode.html
This moves the 'overflow' event dispatch from RenderLayer to an helper class
OverflowEventDispatcher. For now, the class lives in RenderBlock as it matches
the existing code but it may be moved later to its own class as FrameView could
benefit from it too or if we need to support 'overflow' events on RenderBoxes.
- rendering/RenderBlock.cpp:
(WebCore):
(OverflowEventDispatcher):
(WebCore::OverflowEventDispatcher::OverflowEventDispatcher):
(WebCore::OverflowEventDispatcher::~OverflowEventDispatcher):
(WebCore::OverflowEventDispatcher::computeOverflowStatus):
RAII dispatcher class that stores the information before layout and compare
them after to dispatch the right information.
(WebCore::RenderBlock::layout): Added an instance of OverflowEventDispatcher.
- rendering/RenderBox.h:
(WebCore::RenderBox::hasHorizontalLayoutOverflow):
(WebCore::RenderBox::hasVerticalLayoutOverflow):
Helper method to know if we have an horizontal / vertical layout overflow.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
- rendering/RenderLayer.h:
Removed the scroll tracking logic as we don't need it anymore. This removes
3 booleans from RenderLayer.
LayoutTests:
- fast/events/overflow-events-writing-mode.html: Added.
- fast/events/overflow-events-writing-mode-expected.txt: Added.
Added a test for overflow events in a vertical writing mode.
- 11:05 AM Changeset in webkit [109586] by
-
- 1 edit1 add in trunk/LayoutTests
Rebaseline a test on Leopard after expectation was removed in r109516.
Unreviewed gardening.
- platform/chromium-mac-leopard/fast/repaint/transform-absolute-in-positioned-container-expected.png: Added.
- 11:02 AM Changeset in webkit [109585] by
-
- 8 edits in trunk/Source/WebCore
Create a method in Element to compare attributes with other Element
https://bugs.webkit.org/show_bug.cgi?id=80169
Reviewed by Ryosuke Niwa.
Avoid manually peeking at attribute storage to get this information. This
simplify the callsites. The actual implementation of comparison was moved to
ElementAttributeData. The mapsEquivalent() function still exists for the sake
of DocumentType nodes.
- dom/Element.cpp:
(WebCore::Element::hasEquivalentAttributes):
(WebCore):
- dom/Element.h:
(Element):
- dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::isEquivalent):
(WebCore):
- dom/ElementAttributeData.h:
(ElementAttributeData):
- dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::mapsEquivalent):
- dom/Node.cpp:
(WebCore::Node::isEqualNode):
- editing/htmlediting.cpp:
(WebCore::areIdenticalElements): Use Element::hasTagName() instead of matching
directly to make code a bit clearer.
- 10:03 AM Changeset in webkit [109584] by
-
- 7 edits in trunk/Source
[GTK] Smooth scrolling support
https://bugs.webkit.org/show_bug.cgi?id=16123
Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-03-02
Reviewed by Martin Robinson.
Source/WebCore:
No new tests - no new functionality.
Add the ScrollAnimatorNone class to compilation and enable
the smooth scrolling feature by default at compilation time.
- GNUmakefile.am:
- GNUmakefile.list.am:
Source/WebKit/gtk:
Add a new settings option to enable smooth scrolling.
- webkit/webkitwebsettings.cpp:
(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):
- webkit/webkitwebsettingsprivate.h:
- webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):
- 9:40 AM Changeset in webkit [109583] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Set the devicePixelRatio from the results of computeViewportAttributes
https://bugs.webkit.org/show_bug.cgi?id=80160
Patch by Konrad Piascik <kpiascik@rim.com> on 2012-03-02
Reviewed by Antonio Gomes.
Tested by going to layout test fast/viewport/viewport-95.html and viewport-93.html
Previously when executing window.devicePixelRatio these two pages returned 1 now
they report the devicePixelRatio returned by computeViewportAttributes.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
- 8:55 AM Changeset in webkit [109582] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline after r109581.
- platform/gtk/security/block-test-expected.txt:
- 8:45 AM Changeset in webkit [109581] by
-
- 4 edits1 add in trunk
[GTK] security/block-test.html baselines differ from mac
https://bugs.webkit.org/show_bug.cgi?id=78343
Reviewed by Martin Robinson.
Tools:
Improved the FrameLoader error heuristics to match mac behavior a
bit more.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(pathFromSoupURI): Handle ftp urls the same as http urls.
(descriptionSuitableForTestResult): Map WebKitPolicyError to WebKitErrorDomain.
LayoutTests:
GTK baselines updates for two security tests. They're closer to
the mac baselines now.
- platform/gtk/security/block-test-expected.txt: Added.
- platform/gtk/security/block-test-no-port-expected.txt:
- 8:40 AM WebKitGTK/1.8.x edited by
- (diff)
- 8:38 AM Changeset in webkit [109580] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] media/media-can-play-flac-audio.html fails
https://bugs.webkit.org/show_bug.cgi?id=80124
Reviewed by Martin Robinson.
Handle audio/x-flac in the mimeTypeCache() function so that we
advertize both audio/flac and audio/x-flac.
No new tests, this is covered already by media/media-can-play-flac-audio.html.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
- 8:37 AM WebKitGTK/1.8.x edited by
- (diff)
- 8:37 AM Changeset in webkit [109579] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit2
Merging r109578
- 8:30 AM Changeset in webkit [109578] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Invalid check in webkit_web_view_set_zoom_level() when zoom-text-only is enabled
https://bugs.webkit.org/show_bug.cgi?id=80150
Reviewed by Philippe Normand.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_set_zoom_level): Use
webkit_web_view_get_zoom_level() instead of
WKPageGetPageZoomFactor() to get the current effective zoom level
depending on zoom-text-only setting.
- 8:21 AM Changeset in webkit [109577] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: fix fronted compilation.
https://bugs.webkit.org/show_bug.cgi?id=80154
Reviewed by Yury Semikhatsky.
- inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.scriptForSourceID):
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
- inspector/front-end/ScriptsSearchScope.js:
(WebInspector.ScriptsSearchResultsPane.prototype.createAnchor):
- 7:36 AM Changeset in webkit [109576] by
-
- 2 edits in trunk/Tools
[Qt][WK2] Fix typo in patch committed in r109575
Unreviewed typo fix.
- MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::notify): Cache the position
in floating point coordinates.
- 7:27 AM Changeset in webkit [109575] by
-
- 5 edits in trunk/Tools
[Qt][WK2] Infinite loop on history navigation, when panning
https://bugs.webkit.org/show_bug.cgi?id=79119
Reviewed by Simon Hausmann.
Make the touch mocking more robust by creating touch events
directly and sending them synchronously to the browser window.
If the sent touch event was not accepted we propagate the
original mouse event to its target.
This way we make sure we only send either a touch or a mouse
event and do not end up in an infinite loop between our mocking
code and the Qt5 automatic mouse event synthesizing.
- MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::updateVisualMockTouchPoints):
- MiniBrowser/qt/BrowserWindow.h:
(BrowserWindow):
- MiniBrowser/qt/MiniBrowserApplication.cpp:
(touchRectForPosition):
(MiniBrowserApplication::notify):
(MiniBrowserApplication::sendTouchEvent):
- MiniBrowser/qt/MiniBrowserApplication.h:
(MiniBrowserApplication):
- 7:14 AM Changeset in webkit [109574] by
-
- 14 edits in trunk
Rename DOMURL to URL in the bindings
https://bugs.webkit.org/show_bug.cgi?id=78214
Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2012-03-02
Reviewed by Kentaro Hara.
Source/WebCore:
No new tests. Interface name change.
- html/DOMURL.idl: Added InterfaceName attribute to DOMURL.
LayoutTests:
- fast/files/domurl-script-execution-context-crash-expected.txt:
- fast/files/domurl-script-execution-context-crash.html:
- fast/js/constructor-length.html:
- platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
- platform/gtk/fast/js/constructor-length-expected.txt:
- platform/gtk/fast/js/global-constructors-expected.txt:
- platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
- platform/mac/fast/js/constructor-length-expected.txt:
- platform/mac/fast/js/global-constructors-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
- 6:26 AM Changeset in webkit [109573] by
-
- 5 edits2 adds in trunk
Add :scope pseudo-class
https://bugs.webkit.org/show_bug.cgi?id=79077
Source/WebCore:
Add :scope pseudo class name & pseudoId
Add selector check for the new pseudo-class
Reviewed by Antti Koivisto.
Test: fast/css/style-scoped/scope-pseudo.html
- css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):
- css/CSSSelector.h:
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector):
LayoutTests:
Test new :scope pseudo-class
Reviewed by Antti Koivisto.
- fast/css/style-scoped/scope-pseudo-expected.txt: Added.
- fast/css/style-scoped/scope-pseudo.html: Added.
- 6:25 AM Changeset in webkit [109572] by
-
- 11 edits in trunk/Source/WebKit/qt
[Qt] Documentation cleanup
https://bugs.webkit.org/show_bug.cgi?id=80131
Patch by Casper van Donderen <casper.vandonderen@nokia.com> on 2012-03-02
Reviewed by Simon Hausmann.
QDoc uses different commands to do bold, lists, and italics.
This change updates the documentation accordingly.
QTBUG-24578
- Api/qwebframe.cpp:
- Api/qwebhistory.cpp:
- Api/qwebinspector.cpp:
- Api/qwebpage.cpp:
- Api/qwebpluginfactory.cpp:
- Api/qwebsettings.cpp:
- declarative/qdeclarativewebview.cpp:
- docs/qtwebkit-bridge.qdoc:
- docs/qtwebkit.qdoc:
- docs/qtwebkit.qdocconf:
- 6:16 AM Changeset in webkit [109571] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip new failing tests.
- platform/qt/Skipped:
- 6:07 AM Changeset in webkit [109570] by
-
- 18 edits in trunk/Source
Make parser code not depend on NamedNodeMap
https://bugs.webkit.org/show_bug.cgi?id=79963
Reviewed by Adam Barth.
Source/WebCore:
Instead of creating Element-less NamedNodeMaps, the parsing code now creates
AttributeVectors, that are used to fill Element via the parserSetAttributes()
method. This allows us to remove even more methods from the NamedNodeMap.
The AttributeVector class contains convenience methods that take the attribute's
QualifiedName as parameter. This class is also used inside ElementAttributeData.
- dom/Attr.h:
(Attr):
- dom/Element.cpp:
(WebCore::Element::getAttribute):
(WebCore::Element::parserSetAttributes): Now we have to create the attribute
storage, and fill it (by Vector::swap()) with the passed attributes. Also use an
early return to reduce indentation.
(WebCore::Element::insertedIntoDocument):
(WebCore::Element::removedFromDocument):
(WebCore::Element::getURLAttribute):
(WebCore::Element::getNonEmptyURLAttribute):
- dom/Element.h:
(Element):
(WebCore::Element::fastHasAttribute):
(WebCore::Element::fastGetAttribute):
(WebCore::Element::hasAttributesWithoutUpdate):
(WebCore::Element::attributeItem):
(WebCore::Element::getAttributeItem):
- dom/ElementAttributeData.cpp:
(WebCore::AttributeVector::removeAttribute):
(WebCore):
- dom/ElementAttributeData.h:
(AttributeVector):
(WebCore::AttributeVector::create):
(WebCore::AttributeVector::attributeItem):
(WebCore::AttributeVector::AttributeVector):
(WebCore):
(WebCore::AttributeVector::getAttributeItem):
(WebCore::AttributeVector::getAttributeItemIndex):
(WebCore::AttributeVector::insertAttribute): Boolean parameter isn't necessary
since all the callers used 'false', indicating that duplicates were not allowed.
(WebCore::ElementAttributeData::attributeItem):
(WebCore::ElementAttributeData::getAttributeItem):
(WebCore::ElementAttributeData::getAttributeItemIndex):
(ElementAttributeData):
- dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::getNamedItem):
(WebCore::NamedNodeMap::setNamedItem):
(WebCore::NamedNodeMap::removeNamedItem):
(WebCore::NamedNodeMap::mapsEquivalent):
- dom/NamedNodeMap.h:
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):
(WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement):
(WebCore::HTMLConstructionSite::insertScriptElement):
(WebCore::HTMLConstructionSite::createElement):
(WebCore::HTMLConstructionSite::createHTMLElement):
(WebCore):
- html/parser/HTMLToken.h:
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processFakeStartTag):
(WebCore::HTMLTreeBuilder::attributesForIsindexInput):
(WebCore):
- html/parser/HTMLTreeBuilder.h:
- html/parser/TextDocumentParser.cpp:
(WebCore::TextDocumentParser::insertFakePreElement):
- xml/parser/MarkupTokenBase.h:
(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):
(WebCore::AtomicMarkupTokenBase::attributes):
(WebCore::AtomicMarkupTokenBase::takeAttributes):
(AtomicMarkupTokenBase):
(WebCore::::initializeAttributes):
- xml/parser/XMLToken.h:
(WebCore::AtomicXMLToken::AtomicXMLToken):
- xml/parser/XMLTreeBuilder.cpp:
(WebCore::XMLTreeBuilder::processNamespaces):
(WebCore::XMLTreeBuilder::processAttributes):
Source/WebKit/chromium:
- src/WebNamedNodeMap.cpp:
(WebKit::WebNamedNodeMap::attributeItem):
- 5:53 AM Changeset in webkit [109569] by
-
- 2 edits in trunk/Tools
[Qt] Use 'all' as default target when debug_and_release is in effect
When debug_and_release is enabled, in combination with build_all,
qmake will generate an aggregate makefile that calls make on both
the debug and the release makefiles, but with the 'all' target.
In this case we can't use 'first' as the default target, as the
extra targets would then not be run, so we append extra targets
to 'all' instead.
Reviewed by Simon Hausmann.
- 5:48 AM Changeset in webkit [109568] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: assertion failure in JSMainThreadExecState::instrumentedCall
https://bugs.webkit.org/show_bug.cgi?id=80152
Extracted common code of JS call instrumentation into instrumentFunctionCall method
and call it directly where the instrumentation is needed instead of calling
JSMainThreadExecState::instrumentedCall which works on the main thread only.
Reviewed by Pavel Feldman.
- bindings/js/JSCallbackData.cpp:
(WebCore::JSCallbackData::invokeCallback):
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
- bindings/js/JSMainThreadExecState.h:
(WebCore::JSMainThreadExecState::instrumentFunctionCall):
- 5:46 AM Changeset in webkit [109567] by
-
- 2 edits in trunk/Tools
[Qt] Make sure activeBuildConfig() returns the right config
Using isActiveConfig fails, as that only checks if the given
argument is in CONFIG, not the order.
Reviewed by Simon Hausmann.
- 5:35 AM Changeset in webkit [109566] by
-
- 6 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, update expected files.
- platform/qt/Skipped: Unskip non-existent files.
- platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.png:
- platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.txt:
- platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.png:
- platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
- 5:31 AM Changeset in webkit [109565] by
-
- 2 edits in trunk/Source/WebCore
[Forms] Make order of attribute/method in HTMLTextAreaElement.idl as same as specification
https://bugs.webkit.org/show_bug.cgi?id=80101
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-02
Reviewed by Kent Tamura.
No new tests. No behavior changes.
- html/HTMLTextAreaElement.idl: Reorder attribute/method position.
- 5:30 AM Changeset in webkit [109564] by
-
- 3 edits in trunk/Source/WebCore
Build fix after r109538.
- CMakeLists.txt:
- Modules/websockets/WebSocketDeflater.cpp:
- 5:27 AM Changeset in webkit [109563] by
-
- 10 edits2 adds in trunk
Scoped stylesheets don't appear to work in Shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=79549
Source/WebCore:
Make the scope stack in CSSStyleSelector use ContainerNode* instead of Element*.
Adapt using sites accordingly.
Push the ShadowRoot to the scope stack in the same way that elements are pushed.
Fix an issue with removedFromDocument() on destruction.
Reviewed by Antti Koivisto.
Test: fast/css/style-scoped/style-scoped-in-shadow.html
- css/CSSStyleSelector.cpp:
(RuleSet):
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::determineScope):
(WebCore::CSSStyleSelector::ruleSetForScope):
(WebCore::CSSStyleSelector::appendAuthorStylesheets):
(WebCore::CSSStyleSelector::setupScopeStack):
(WebCore::CSSStyleSelector::pushScope):
(WebCore):
(WebCore::CSSStyleSelector::popScope):
(WebCore::CSSStyleSelector::pushParentElement):
(WebCore::CSSStyleSelector::popParentElement):
(WebCore::CSSStyleSelector::pushParentShadowRoot):
(WebCore::CSSStyleSelector::popParentShadowRoot):
(WebCore::CSSStyleSelector::matchScopedAuthorRules):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- css/CSSStyleSelector.h:
(CSSStyleSelector):
(WebCore::CSSStyleSelector::pushScope):
(WebCore::CSSStyleSelector::popScope):
(WebCore::CSSStyleSelector::MatchOptions::MatchOptions):
(MatchOptions):
(WebCore::CSSStyleSelector::scopeStackIsConsistent):
(WebCore::CSSStyleSelector::ScopeStackFrame::ScopeStackFrame):
(ScopeStackFrame):
- css/SelectorChecker.h:
(SelectorCheckingContext):
- dom/Element.cpp:
(WebCore::StyleSelectorParentPusher::push):
(WebCore::StyleSelectorParentPusher::~StyleSelectorParentPusher):
(WebCore::Element::beginParsingChildren):
(WebCore::Element::finishParsingChildren):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::attach):
(WebCore):
- dom/ShadowRoot.h:
(ShadowRoot):
- dom/ShadowTree.cpp:
(WebCore::ShadowTree::recalcShadowTreeStyle):
- html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::removedFromDocument):
LayoutTests:
Test that <style scoped> works in shadow DOM as direct child of the ShadowRoot
Reviewed by Antti Koivisto.
- fast/css/style-scoped/style-scoped-in-shadow-expected.txt: Added.
- fast/css/style-scoped/style-scoped-in-shadow.html: Added.
- 5:24 AM Changeset in webkit [109562] by
-
- 2 edits in trunk/Source/WebCore
[Forms] Make order of attribute/method in HTMLSelectElement.idl as same as specification
https://bugs.webkit.org/show_bug.cgi?id=80097
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-02
Reviewed by Kent Tamura.
No new tests. No behavior changes.
- html/HTMLSelectElement.idl: Reorder attribute/method position.
- 5:22 AM Changeset in webkit [109561] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: limit RawSourceCode usages to DebuggerPresentationModel.
https://bugs.webkit.org/show_bug.cgi?id=80146
Reviewed by Vsevolod Vlasov.
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.uiLocationToRawLocation):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyRawLocation):
- inspector/front-end/ObjectPopoverHelper.js:
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover.showObjectPopover.):
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):
- inspector/front-end/ScriptsSearchScope.js:
(WebInspector.ScriptsSearchResultsPane.prototype.createAnchor):
- 5:15 AM Changeset in webkit [109560] by
-
- 3 edits in trunk
Web Inspector: update execution line using LiveLocation.
https://bugs.webkit.org/show_bug.cgi?id=80143
Reviewed by Vsevolod Vlasov.
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._uiSourceCodeListChanged):
(WebInspector.DebuggerPresentationModel.prototype._debuggerResumed):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame.updateExecutionLine):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
- 5:06 AM WebKitGTK/1.8.x edited by
- (diff)
- 4:59 AM Changeset in webkit [109559] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Build fix for LocalizedStringsBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=80099
Unreviewed build fix.
- platform/blackberry/LocalizedStringsBlackBerry.cpp:
- 4:58 AM Changeset in webkit [109558] by
-
- 4 edits in trunk/Source
Fix build on AppleWebKit after 109548.
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-02
Source/WebCore:
- WebCore.exp.in:
Source/WebKit2:
- mac/WebKit2.order:
- 4:47 AM Changeset in webkit [109557] by
-
- 2 edits in trunk/Source/WebCore
[Forms] Make order of attribute/method in HTMLOptionElement.idl as same as specification
https://bugs.webkit.org/show_bug.cgi?id=80095
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-02
Reviewed by Kentaro Hara.
No new tests. No behavior changes.
- html/HTMLOptionElement.idl: Reorder attribute/method position.
- 4:45 AM Changeset in webkit [109556] by
-
- 12 edits3 adds in trunk/Source/WebCore
WorkerContext shouldn't know about IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=80094
Reviewed by Kentaro Hara.
There are still a couple IndexedDB stragglers we should clean up in
WebCore proper. This patch moves some IndexedDB logic from
WorkerContext into the indexeddb module.
In the process of writing this patch, I noticed that some IndexedDB
files were missing from various build systems, so I added them. I
suspect that means IndexedDB is only enabled by default on Chromium.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Modules/indexeddb/WorkerContextIndexedDatabase.cpp: Added.
(WebCore):
(WebCore::WorkerContextIndexedDatabase::WorkerContextIndexedDatabase):
(WebCore::WorkerContextIndexedDatabase::~WorkerContextIndexedDatabase):
(WebCore::WorkerContextIndexedDatabase::from):
(WebCore::WorkerContextIndexedDatabase::webkitIndexedDB):
- Modules/indexeddb/WorkerContextIndexedDatabase.h: Added.
(WebCore):
(WorkerContextIndexedDatabase):
- Modules/indexeddb/WorkerContextIndexedDatabase.idl: Added.
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- workers/WorkerContext.cpp:
(WebCore):
- workers/WorkerContext.h:
(WebCore):
(WorkerContext):
- workers/WorkerContext.idl:
- 4:45 AM Changeset in webkit [109555] by
-
- 5 edits in trunk
[Qt] Fix tests run with WTR not using QStyle theme
https://bugs.webkit.org/show_bug.cgi?id=80147
Reviewed by Csaba Osztrogonác.
Source/WebKit2:
Use an environment variable (set by WTR) to select the QStyle theme.
This is a temporary kludge until we rebase the layout tests to use the
QStyle independent "mobile" theme. This also temporarily breaks the
force_static_libs_as_shared build.
- Target.pri:
- WebProcess/qt/WebProcessMainQt.cpp:
(WebKit::WebProcessMainQt):
Tools:
- WebKitTestRunner/qt/main.cpp:
(main): Set environment variable for web process to use QStyle theme.
- 4:29 AM Changeset in webkit [109554] by
-
- 4 edits1 delete in trunk
Tools: Unreviewed, remove debug print call.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(descriptionSuitableForTestResult):
LayoutTests: Unreviewed, unskip security/block-test.html and remove its GTK
baseline, the platform-agnostic baseline match.
- platform/gtk/Skipped:
- platform/gtk/security/block-test-expected.txt: Removed.
- 4:23 AM Changeset in webkit [109553] by
-
- 4 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, update expected files.
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
- 4:16 AM Changeset in webkit [109552] by
-
- 8 edits in trunk
[Qt] Compile WebCore without QtWidgets
https://bugs.webkit.org/show_bug.cgi?id=80141
Reviewed by Tor Arne Vestbø.
.:
- Source/api.pri: Use QT += opengl for the WebKit1 bits, such as the QGLWidget
usage in PageClientQt.cpp. Previously this dependency came implicitly through WebCore.pri.
Source/WebCore:
- Target.pri: Don't add widgets to QT.
- WebCore.pri: Use QT += opengl only with Qt 4, because it has an implicit QtWidgets
dependency. With Qt 5 all necessary OpenGL API is part of QtGui (with a QOpenGL* prefix).
Source/WebKit2:
- Shared/qt/WebEventFactoryQt.cpp: Removed unnecessary include.
- Target.pri: Require widgets for WK2 for the moment, until bug #79458
is fixed.
- 3:57 AM Changeset in webkit [109551] by
-
- 2 edits in trunk/Source/WebCore
[Forms] Make order of attribute/method in HTMLFormElement.idl as same as specification
https://bugs.webkit.org/show_bug.cgi?id=80093
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-02
Reviewed by Kentaro Hara.
No new tests. No behavior changes
- html/HTMLFormElement.idl: Reorder attribute/method position.
- 3:54 AM Changeset in webkit [109550] by
-
- 2 edits in trunk/Source/WebCore
[Forms] Make order of attribute/method in HTMLButtonElement.idl as same as specification
https://bugs.webkit.org/show_bug.cgi?id=80091
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-02
Reviewed by Kentaro Hara.
No new tests. No behavior changes.
- html/HTMLButtonElement.idl: Reorder attribute/method position.
- 3:43 AM Changeset in webkit [109549] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Build system cleanup
Rubber-stamped by Antti Koivisto.
- tests/MIMESniffing/MIMESniffing.pro: Don't link in WTFAssertions.cpp for ASSERT, now
that the symbols are properly exported with export macros from the DLL.
- 3:40 AM Changeset in webkit [109548] by
-
- 15 edits in trunk/Source
Suspend/Resume API for pausing timers and animations.
https://bugs.webkit.org/show_bug.cgi?id=76063
Source/WebCore:
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-02
Reviewed by Kenneth Rohde Christiansen.
- dom/ActiveDOMObject.h:
New ReasonForSuspension: PageWillBePaused.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::suspend): Handle new ReasonForSuspension.
- page/Frame.cpp:
(WebCore::Frame::Frame):
(WebCore::Frame::setDocument):
(WebCore::Frame::suspendActiveDOMObjectsAndAnimations):
(WebCore::Frame::resumeActiveDOMObjectsAndAnimations):
- page/Frame.h:
(WebCore::Frame::activeDOMObjectsAndAnimationsSuspended):
Frame now maintains a state of suspending animation and ActiveDOMObjects,
which is inherited to all child-frames.
- page/Page.cpp:
(WebCore::Page::suspendActiveDOMObjectsAndAnimations):
(WebCore::Page::resumeActiveDOMObjectsAndAnimations):
- page/Page.h:
Functions for suspending and resuming active DOM objects and animations in all frames.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::willRenderImage):
WillRenderImage now checks for suspension. This causes animated images to pause
together with all other types of animations.
Source/WebKit2:
Based on the initial work of Zalan Bujtas <zalan.bujtas@nokia.com>,
Adds suspend and resume API for WebKit2 and uses it in Qt to
suspend animations and DOM timers during panning and zoom.
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-02
Reviewed by Kenneth Rohde Christiansen.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewFlickablePrivate::_q_suspend):
(QQuickWebViewFlickablePrivate::_q_resume):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::resumeActiveDOMObjectsAndAnimations):
(WebKit::WebPageProxy::suspendActiveDOMObjectsAndAnimations):
(WebKit::WebPageProxy::processDidCrash):
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::suspendActiveDOMObjectsAndAnimations):
(WebKit::WebPage::resumeActiveDOMObjectsAndAnimations):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- 3:33 AM Changeset in webkit [109547] by
-
- 2 edits in trunk/Source/WebCore
[Forms] Make order of attribute/method in HTMLFieldSetElement.idl as same as specification
https://bugs.webkit.org/show_bug.cgi?id=80092
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-02
Reviewed by Kentaro Hara.
No new tests. No behavior changes.
- html/HTMLFieldSetElement.idl: Reorder attribute/method position.
- 3:28 AM Changeset in webkit [109546] by
-
- 3 edits in trunk/Source/WebCore
possible regression: r104060 maybe causing crashes
https://bugs.webkit.org/show_bug.cgi?id=75676
Rubber-stamped by Simon Hausmann.
Remove the speculative fix (the problem was elsewhere, http://trac.webkit.org/changeset/104845).
Also remove the debugging code added for this bug.
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::clearStyleSelector):
(WebCore::Document::updateActiveStylesheets):
- dom/Document.h:
(Document):
- 3:16 AM Changeset in webkit [109545] by
-
- 11 edits in trunk
Web Inspector: Implement suggestions in Watch Expressions
https://bugs.webkit.org/show_bug.cgi?id=79912
Source/WebCore:
Drive-by: make subproperties in ObjectPropertySections editable
Reviewed by Pavel Feldman.
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView):
(WebInspector.ConsoleView.prototype.completionsForTextPrompt):
- inspector/front-end/DatabaseQueryView.js:
- inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype.onpopulate.callback):
(WebInspector.ObjectPropertyTreeElement.prototype.onpopulate):
(WebInspector.ObjectPropertyTreeElement.prototype.ondblclick):
(WebInspector.ObjectPropertyTreeElement.prototype.renderPromptAsBlock):
(WebInspector.ObjectPropertyTreeElement.prototype.elementAndValueToEdit):
(WebInspector.ObjectPropertyTreeElement.prototype.startEditing.blurListener):
(WebInspector.ObjectPropertyTreeElement.prototype.startEditing):
(WebInspector.ObjectPropertyTreeElement.prototype.editingEnded):
(WebInspector.ObjectPropertyTreeElement.prototype.editingCancelled):
(WebInspector.ObjectPropertyTreeElement.prototype.editingCommitted):
(WebInspector.ObjectPropertyTreeElement.prototype._promptKeyDown):
(WebInspector.ObjectPropertyPrompt):
- inspector/front-end/StylesSidebarPane.js:
- inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.complete):
- inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionTreeElement.prototype.renderPromptAsBlock):
(WebInspector.WatchExpressionTreeElement.prototype.elementAndValueToEdit):
(WebInspector.WatchExpressionTreeElement.prototype.editingCancelled):
- inspector/front-end/inspector.css:
(.watch-expressions > li.editing-sub-part .text-prompt):
LayoutTests:
Reviewed by Pavel Feldman.
- http/tests/inspector/console-cd-completions.html:
- inspector/debugger/debugger-completions-on-call-frame.html:
- 2:55 AM Changeset in webkit [109544] by
-
- 4 edits in trunk
[EFL] Build warning : comparison between signed and unsigned integer expressions.
https://bugs.webkit.org/show_bug.cgi?id=79860
Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-03-02
Reviewed by Hajime Morita.
Fixed build warnings which are getting generated when comparing signed
and unsigned integer expressions.
- Source/WebCore/bindings/js/JSDocumentCustom.cpp:
- Source/WebCore/platform/ContextMenu.cpp:
- Source/WebKit/efl/ewk/ewk_view_single.cpp:
- 2:46 AM Changeset in webkit [109543] by
-
- 3 edits3 adds in trunk
REGRESSION (r104060): Page contents not painted if inserting a new stylesheet and temporary body node
https://bugs.webkit.org/show_bug.cgi?id=76590
Reviewed by Maciej Stachowiak.
Source/WebCore:
Test: fast/css/pending-stylesheet-repaint.html
If there has been a style recalc with a pending stylesheet, the forced repaint will need to be triggered even
if the stylesheet doesn't affect the rendering. Otherwise we may end up never painting at all.
- dom/Document.cpp:
(WebCore::Document::styleSelectorChanged):
LayoutTests:
- fast/css/pending-stylesheet-repaint-expected.png: Added.
- fast/css/pending-stylesheet-repaint-expected.txt: Added.
- fast/css/pending-stylesheet-repaint.html: Added.
- 2:43 AM Changeset in webkit [109542] by
-
- 11 edits1 copy3 moves in trunk
[Qt] Move QStyle theming code out of WebCore into WebKit1
https://bugs.webkit.org/show_bug.cgi?id=80128
Reviewed by Kenneth Rohde Christiansen.
.:
- Source/api.pri: Adjust to moving source files.
Source/WebCore:
Moved QStyle dependant code into WebKit1, where it's okay to depend on
QtWidgets/QStyle. Added factory hooks into RenderThemeQt to allow changing
the default "mobile" style to QStyle on start-up.
- Target.pri:
- platform/qt/RenderThemeQt.cpp:
(WebCore):
(WebCore::RenderThemeQt::setCustomTheme):
(WebCore::RenderThemeQt::customScrollbarTheme):
(WebCore::createTheme):
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeQt::extraDefaultStyleSheet):
- platform/qt/RenderThemeQt.h:
(WebCore):
(RenderThemeQt):
- platform/qt/RenderThemeQtMobile.cpp:
- platform/qt/ScrollbarThemeQt.cpp:
(WebCore::ScrollbarTheme::nativeTheme):
Source/WebKit/qt:
Moved the bulk of the QStyle dependant code here, where it's okay to depend on QtWidgets/QStyle.
Install the QStyle factory functions in initWebCoreQt.cpp.
- Api/qwebpage.cpp:
(QWebPage::swallowContextMenuEvent):
- WebCoreSupport/InitWebCoreQt.cpp:
(WebCore::initializeWebCoreQt):
- WebCoreSupport/RenderThemeQStyle.cpp: Renamed from Source/WebCore/platform/qt/RenderThemeQStyle.cpp.
(WebCore):
(WebCore::initStyleOption):
(WebCore::RenderThemeQStyle::getStylePainter):
(WebCore::StylePainterQStyle::StylePainterQStyle):
(WebCore::StylePainterQStyle::init):
(WebCore::RenderThemeQStyle::create):
(WebCore::RenderThemeQStyle::RenderThemeQStyle):
(WebCore::RenderThemeQStyle::~RenderThemeQStyle):
(WebCore::RenderThemeQStyle::fallbackStyle):
(WebCore::RenderThemeQStyle::qStyle):
(WebCore::RenderThemeQStyle::findFrameLineWidth):
(WebCore::RenderThemeQStyle::inflateButtonRect):
(WebCore::RenderThemeQStyle::computeSizeBasedOnStyle):
(WebCore::RenderThemeQStyle::adjustButtonStyle):
(WebCore::RenderThemeQStyle::setButtonPadding):
(WebCore::RenderThemeQStyle::paintButton):
(WebCore::RenderThemeQStyle::paintTextField):
(WebCore::RenderThemeQStyle::adjustTextAreaStyle):
(WebCore::RenderThemeQStyle::paintTextArea):
(WebCore::RenderThemeQStyle::setPopupPadding):
(WebCore::RenderThemeQStyle::paintMenuList):
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
(WebCore::RenderThemeQStyle::paintMenuListButton):
(WebCore::RenderThemeQStyle::animationDurationForProgressBar):
(WebCore::RenderThemeQStyle::paintProgressBar):
(WebCore::RenderThemeQStyle::paintSliderTrack):
(WebCore::RenderThemeQStyle::adjustSliderTrackStyle):
(WebCore::RenderThemeQStyle::paintSliderThumb):
(WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
(WebCore::RenderThemeQStyle::paintSearchField):
(WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldDecoration):
(WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeQStyle::paintInnerSpinButton):
(WebCore::RenderThemeQStyle::initializeCommonQStyleOptions):
(WebCore::RenderThemeQStyle::adjustSliderThumbSize):
- WebCoreSupport/RenderThemeQStyle.h: Renamed from Source/WebCore/platform/qt/RenderThemeQStyle.h.
(WebCore):
(RenderThemeQStyle):
(StylePainterQStyle):
(WebCore::StylePainterQStyle::isValid):
(WebCore::StylePainterQStyle::drawPrimitive):
(WebCore::StylePainterQStyle::drawControl):
(WebCore::StylePainterQStyle::drawComplexControl):
- WebCoreSupport/ScrollbarThemeQStyle.cpp: Copied from Source/WebCore/platform/qt/ScrollbarThemeQt.cpp.
(WebCore):
(WebCore::ScrollbarThemeQStyle::~ScrollbarThemeQStyle):
(WebCore::scPart):
(WebCore::scrollbarPart):
(WebCore::styleOptionSlider):
(WebCore::ScrollbarThemeQStyle::paint):
(WebCore::ScrollbarThemeQStyle::hitTest):
(WebCore::ScrollbarThemeQStyle::shouldCenterOnThumb):
(WebCore::ScrollbarThemeQStyle::invalidatePart):
(WebCore::ScrollbarThemeQStyle::scrollbarThickness):
(WebCore::ScrollbarThemeQStyle::thumbPosition):
(WebCore::ScrollbarThemeQStyle::thumbLength):
(WebCore::ScrollbarThemeQStyle::trackPosition):
(WebCore::ScrollbarThemeQStyle::trackLength):
(WebCore::ScrollbarThemeQStyle::paintScrollCorner):
(WebCore::ScrollbarThemeQStyle::style):
- WebCoreSupport/ScrollbarThemeQStyle.h: Renamed from Source/WebCore/platform/qt/ScrollbarThemeQt.h.
(WebCore):
(ScrollbarThemeQStyle):
- 2:40 AM Changeset in webkit [109541] by
-
- 3 edits in trunk/Source/WebCore
Handle CSSPropertyWebkitColumnRuleStyle in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=80085
Reviewed by Eric Seidel.
No new tests / refactoring only.
- css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- 2:39 AM Changeset in webkit [109540] by
-
- 16 edits in trunk/Source/WebCore
Web Inspector: enable Timeline panel for workers
https://bugs.webkit.org/show_bug.cgi?id=80130
Enabled Timeline panel for worker inspector. Refactored
JS function calls instrumentation to work for both
worker contexts and documents.
Reviewed by Pavel Feldman.
- bindings/js/JSCallbackData.cpp:
(WebCore::JSCallbackData::invokeCallback):
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
- bindings/js/JSMainThreadExecState.h:
(WebCore):
(WebCore::JSMainThreadExecState::instrumentedCall):
- bindings/js/ScriptState.cpp:
(WebCore::scriptExecutionContextFromScriptState):
(WebCore):
- bindings/js/ScriptState.h:
(WebCore):
- bindings/v8/ScriptState.cpp:
(WebCore::ScriptState::scriptExecutionContext):
(WebCore):
(WebCore::scriptExecutionContextFromScriptState):
- bindings/v8/ScriptState.h:
(WebCore):
(ScriptState):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::instrumentedCallFunction):
- bindings/v8/V8WorkerContextEventListener.cpp:
(WebCore::V8WorkerContextEventListener::callListenerFunction):
- inspector/InjectedScript.cpp:
(WebCore::InjectedScript::callFunctionWithEvalEnabled):
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::instrumentingAgentsForNonDocumentContext):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willCallFunction):
(WebCore):
(WebCore::InspectorInstrumentation::instrumentingAgentsForContext):
- inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
(WebCore::WorkerInspectorController::connectFrontend):
(WebCore::WorkerInspectorController::disconnectFrontend):
(WebCore::WorkerInspectorController::restoreInspectorStateFromCookie):
- inspector/WorkerInspectorController.h:
(WebCore):
(WorkerInspectorController):
- inspector/front-end/inspector.js:
(WebInspector._createPanels):
- 2:37 AM Changeset in webkit [109539] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, GTK tests expectations update.
- platform/gtk/Skipped:
- platform/gtk/test_expectations.txt:
- 2:24 AM Changeset in webkit [109538] by
-
- 18 edits1 copy12 adds in trunk
Adding WebSocket per-frame DEFLATE extension
https://bugs.webkit.org/show_bug.cgi?id=77522
Source/JavaScriptCore:
Added USE(ZLIB) flag.
Reviewed by Kent Tamura.
- wtf/Platform.h:
Source/WebCore:
Add WebSocketDeflateFramer class which handles deflate-frame extension.
This class encapsulates WebSocketDeflater and WebSocketInflater classes,
which depend on zlib, so that WebSocketChannel is not necessary to aware
zlib dependency.
Reviewed by Kent Tamura.
Tests: http/tests/websocket/tests/hybi/compressed-control-frame.html
http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff.html
http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter.html
http/tests/websocket/tests/hybi/deflate-frame-parameter.html
- CMakeLists.txt: Added WebSocketDeflateFramer.(cpp|h)
- GNUmakefile.list.am: Ditto.
- Target.pri: Ditto.
- WebCore.gypi: Ditto.
- WebCore.gyp/WebCore.gyp: Added zlib dependency.
- WebCore.vcproj/WebCore.vcproj: Added WebSocketDeflateFramer.(cpp|h)
- WebCore.xcodeproj/project.pbxproj: Ditto.
- websockets/WebSocket.cpp:
(WebCore::WebSocket::didConnect): Set m_extensions.
- websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::connect): Add deflate-frame extension processor to WebSocketHanshake if deflate can use.
(WebCore::WebSocketChannel::fail): Call m_deflateFramer.didFail().
(WebCore::WebSocketChannel::processFrame): Decompress frames if needed.
(WebCore::WebSocketChannel::sendFrame): Compress frames if possible.
- websockets/WebSocketChannel.h:
- websockets/WebSocketDeflateFramer.cpp: Added.
(WebCore):
(WebSocketExtensionDeflateFrame):
(WebCore::WebSocketExtensionDeflateFrame::create):
(WebCore::WebSocketExtensionDeflateFrame::~WebSocketExtensionDeflateFrame):
(WebCore::WebSocketExtensionDeflateFrame::WebSocketExtensionDeflateFrame):
(WebCore::WebSocketExtensionDeflateFrame::handshakeString):
(WebCore::WebSocketExtensionDeflateFrame::processResponse):
(WebCore::DeflateResultHolder::DeflateResultHolder):
(WebCore::DeflateResultHolder::~DeflateResultHolder):
(WebCore::DeflateResultHolder::fail):
(WebCore::InflateResultHolder::InflateResultHolder):
(WebCore::InflateResultHolder::~InflateResultHolder):
(WebCore::InflateResultHolder::fail):
(WebCore::WebSocketDeflateFramer::WebSocketDeflateFramer):
(WebCore::WebSocketDeflateFramer::createExtensionProcessor):
(WebCore::WebSocketDeflateFramer::canDeflate):
(WebCore::WebSocketDeflateFramer::enableDeflate):
(WebCore::WebSocketDeflateFramer::deflate):
(WebCore::WebSocketDeflateFramer::resetDeflateContext):
(WebCore::WebSocketDeflateFramer::inflate):
(WebCore::WebSocketDeflateFramer::resetInflateContext):
(WebCore::WebSocketDeflateFramer::didFail):
- websockets/WebSocketDeflateFramer.h: Added.
(WebCore):
(DeflateResultHolder):
(WebCore::DeflateResultHolder::succeeded):
(WebCore::DeflateResultHolder::failureReason):
(InflateResultHolder):
(WebCore::InflateResultHolder::succeeded):
(WebCore::InflateResultHolder::failureReason):
(WebSocketDeflateFramer):
(WebCore::WebSocketDeflateFramer::enabled):
LayoutTests:
Added tests for WebSocket deflate-frame extension. Also updated some
tests to follow the change.
Reviewed by Kent Tamura.
- http/tests/websocket/tests/hybi/compressed-control-frame-expected.txt: Added.
- http/tests/websocket/tests/hybi/compressed-control-frame.html: Added.
- http/tests/websocket/tests/hybi/compressed-control-frame_wsh.py: Added.
(web_socket_do_extra_handshake):
(web_socket_transfer_data):
- http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff-expected.txt: Added.
- http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff.html: Added.
- http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter-expected.txt: Added.
- http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter.html: Added.
- http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter_wsh.py: Added.
(web_socket_do_extra_handshake):
(web_socket_transfer_data):
- http/tests/websocket/tests/hybi/deflate-frame-parameter-expected.txt: Added.
- http/tests/websocket/tests/hybi/deflate-frame-parameter.html: Added.
- http/tests/websocket/tests/hybi/deflate-frame_wsh.py: Added.
(_get_deflate_frame_extension_processor):
(web_socket_do_extra_handshake):
(web_socket_transfer_data):
- http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header-expected.txt:
- http/tests/websocket/tests/hybi/send-file-blob_wsh.py:
(_retrieve_frame):
(web_socket_transfer_data):
- platform/efl/Skipped: Skips tests rely on zlib
- platform/qt/Skipped: Ditto.
- 2:21 AM Changeset in webkit [109537] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, gardening.
- platform/chromium/test_expectations.txt:
- 1:59 AM Changeset in webkit [109536] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: [InspectorIndexedDB] Show meaningful description for object store items values.
https://bugs.webkit.org/show_bug.cgi?id=79691
Reviewed by Pavel Feldman.
- inspector/front-end/IndexedDBModel.js:
(WebInspector.IndexedDBModel.idbKeyFromKey):
- inspector/front-end/IndexedDBViews.js:
(WebInspector.IDBDataView.prototype._updateData.callback):
(WebInspector.IDBDataView.prototype._updateData):
(WebInspector.IDBDataGridNode.prototype.createCell):
(WebInspector.IDBDataGridNode.prototype._formatValue):
- inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype.onpopulate.callback):
(WebInspector.ObjectPropertyTreeElement.prototype.onpopulate):
- inspector/front-end/RemoteObject.js:
(WebInspector.LocalJSONObject.prototype.get subtype):
- inspector/front-end/indexedDBViews.css:
(.indexed-db-data-view .data-grid .data-container td):
(.indexed-db-data-view .data-grid .data-container td.primaryKey-column):
(.indexed-db-data-view .data-grid .data-container td.primaryKey-column div.primitive-value):
(.indexed-db-data-view .data-grid .data-container td .section .header .title):
- 1:57 AM Changeset in webkit [109535] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, mark
fast/frames/flattening/frameset-flattening-advanced.html as flaky in GTK.
- platform/gtk/test_expectations.txt:
- 1:50 AM Changeset in webkit [109534] by
-
- 2 edits in trunk/Tools
Updated EventSender to send complete gesture events.
https://bugs.webkit.org/show_bug.cgi?id=80075
Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-02
Reviewed by Adam Barth.
- DumpRenderTree/chromium/EventSender.cpp:
(EventSender::gestureEvent): set additional parameters in sent events.
- 1:35 AM Changeset in webkit [109533] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed. Fix WebKit2 GTK+ build.
- GNUmakefile.am: allow WebKitWebProcess to link with zlib properly.
- 1:32 AM Changeset in webkit [109532] by
-
- 7 edits in trunk
[Chromium] Layout Test webaudio/audiobuffersource-channels.html is failing
https://bugs.webkit.org/show_bug.cgi?id=79765
Patch by Wei James <james.wei@intel.com> on 2012-03-02
Reviewed by Chris Rogers.
Source/WebCore:
- webaudio/AudioBuffer.cpp:
(WebCore::AudioBuffer::create):
- webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::setBuffer):
- webaudio/AudioContext.h:
(WebCore):
(AudioContext):
(WebCore::AudioContext::maxNumberOfChannels):
- webaudio/AudioNodeOutput.cpp:
(WebCore::AudioNodeOutput::AudioNodeOutput):
(WebCore::AudioNodeOutput::setNumberOfChannels):
LayoutTests:
- platform/chromium/test_expectations.txt:
- 1:30 AM Changeset in webkit [109531] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, gardening.
- platform/chromium/test_expectations.txt:
- 1:22 AM Changeset in webkit [109530] by
-
- 3 edits in trunk/Source/WebCore
Handle CSSPropertyWebkitRegionBreakAfter, CSSPropertyWebkitRegionBreakBefore and CSSPropertyWebkitRegionBreakInside in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=80066
Reviewed by Eric Seidel.
No new tests / refactoring only.
- css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- 1:20 AM Changeset in webkit [109529] by
-
- 8 edits2 adds in trunk
Implement DefaultParagraphSeparator execCommand, to let authors choose the default block element
https://bugs.webkit.org/show_bug.cgi?id=59961
Patch by Pablo Flouret <pablof@motorola.com> on 2012-03-02
Reviewed by Ryosuke Niwa.
Source/WebCore:
http://dvcs.w3.org/hg/editing/raw-file/tip/editing.html#the-defaultparagraphseparator-command
Test: editing/execCommand/default-paragraph-separator.html
- editing/Editor.cpp:
(WebCore::Editor::Editor):
- editing/Editor.h:
(WebCore::Editor::defaultParagraphSeparator):
(WebCore::Editor::setDefaultParagraphSeparator):
(Editor):
- editing/EditorCommand.cpp:
(WebCore::executeDefaultParagraphSeparator):
(WebCore):
(WebCore::valueDefaultParagraphSeparator):
(WebCore::createCommandMap):
- editing/htmlediting.cpp:
(WebCore::createDefaultParagraphElement):
- html/HTMLParagraphElement.cpp:
(WebCore::HTMLParagraphElement::create):
(WebCore):
- html/HTMLParagraphElement.h:
(HTMLParagraphElement):
Added create(Document*) method that defaults to pTag as the QualifiedName.
LayoutTests:
- editing/execCommand/default-paragraph-separator-expected.txt: Added.
- editing/execCommand/default-paragraph-separator.html: Added.
- 1:12 AM Changeset in webkit [109528] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Fix errors in LayerRendererChromium cleanup
https://bugs.webkit.org/show_bug.cgi?id=80064
Reviewed by James Robinson.
Tested manually by forcing lost context while rendering Flash on
Mac OS in a Debug build.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::cleanupSharedObjects):
- 1:05 AM Changeset in webkit [109527] by
-
- 3 edits in trunk/Source/WebCore
Fix errors found when building the Mac port with ICONDATABASE disabled.
https://bugs.webkit.org/show_bug.cgi?id=80059
Reviewed by Brady Eidson.
- WebCore.exp.in: Only export IconDatabase symbols when the feature is
enabled.
- loader/icon/IconDatabase.h:
(WebCore::IconDatabase::create): WebKit calls this static method, so it
should be defined on the stub class.
(WebCore::IconDatabase::allowDatabaseCleanup): Ditto.
(WebCore::IconDatabase::checkIntegrityBeforeOpening): Ditto.
- 12:55 AM Changeset in webkit [109526] by
-
- 2 edits in trunk/Source/WebKit/blackberry
Fix a warning in InputHandler::learnText()
https://bugs.webkit.org/show_bug.cgi?id=80049
Patch by Jacky Jiang <zhajiang@rim.com> on 2012-03-02
Reviewed by Antonio Gomes.
Fix a warning of the comparison "textInField.length() <=
MaxLearnTextDataSize" in InputHandler::learnText().
Rubber-stamped internally by Mike Fenton.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::learnText):
- 12:50 AM Changeset in webkit [109525] by
-
- 3 edits in trunk/Source/WebCore
Handle CSSPropertyWebkitColorCorrection in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=80056
Reviewed by Eric Seidel.
No new tests / refactoring only.
- css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- 12:33 AM Changeset in webkit [109524] by
-
- 3 edits in trunk/Source/WebKit/efl
[EFL] Enabling 'Inspect Element' in Ewk_Context_Menu_Action.
https://bugs.webkit.org/show_bug.cgi?id=79646
Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2012-03-02
Reviewed by Andreas Kling.
INSPECTOR feature is already enabled for WebKit-Efl port (OptionsEfl.cmake).
As a result WebCore's ContextMenuAction contains ContextMenuItemTagInspectElement
and enums order has been changed. WebKit-Efl has to synchronize ContextMenuAction
with Ewk_Context_Menu_Action.
To avoid similar case in the feature I added checks between WebCore and
WebKit-EFL's enums by using COMPILE_ASSERT_MATCHING_ENUM.
- WebCoreSupport/AssertMatchingEnums.cpp:
- ewk/ewk_contextmenu.h:
- 12:22 AM WebKitGTK/1.8.x edited by
- Added r109509 as proposed merge (diff)
- 12:15 AM Changeset in webkit [109523] by
-
- 1 edit2 adds in trunk/LayoutTests
reflection computed style test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75902
Reviewed by Ojan Vafai.
Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)
These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.
- css3/calc/reflection-computed-style-expected.txt: Added.
- css3/calc/reflection-computed-style.html: Added.
- 12:15 AM Changeset in webkit [109522] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed build fix for platforms that have DFG_JIT disabled but PARALLEL_GC enabled.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
- 12:11 AM Changeset in webkit [109521] by
-
- 3 edits in trunk/Source/WebCore
[chromium] Send didCommitAndDrawFrame after swap
https://bugs.webkit.org/show_bug.cgi?id=80052
Patch by John Bauman <jbauman@chromium.org> on 2012-03-02
Reviewed by James Robinson.
Sending didCommitAndDrawFrame before the swap was causing plugins to
redraw themselves between compositing and the swap, which reduces
opportunities for optimization.
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::compositeAndReadback):
(WebCore::CCSingleThreadProxy::compositeImmediately):
(WebCore::CCSingleThreadProxy::doComposite):
(WebCore):
(WebCore::CCSingleThreadProxy::didSwapFrame):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(CCSingleThreadProxy):
- 12:06 AM Changeset in webkit [109520] by
-
- 8 edits in trunk/LayoutTests
Unreviewed, GTK gardening.
- platform/gtk/Skipped: Skip 2 new failing tests and unskip a new
media test that should pass on GTK.
- platform/gtk/editing/inserting/5994480-2-expected.txt:
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
- platform/gtk/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
- platform/gtk/fast/js/global-constructors-expected.txt:
- platform/gtk/fast/multicol/span/clone-summary-expected.txt:
- 12:04 AM Changeset in webkit [109519] by
-
- 4 edits in trunk/Source/JavaScriptCore
DFGCodeBlocks should not trace CodeBlocks that are also going to be traced by
virtue of being in the transitive closure
https://bugs.webkit.org/show_bug.cgi?id=80098
Reviewed by Anders Carlsson.
If DFGCodeBlocks traces a CodeBlock that might also be traced via its owner Executable,
then you might have the visitAggregate() method called concurrently by multiple threads.
This is benign on 64-bit -- visitAggregate() and everything it calls turns out to be
racy and slightly imprecise but not unsound. But on 32-bit, visitAggregate() may crash
due to word tearing in ValueProfile bucket updates inside of computeUpdatedPrediction().
It would seem that the fix is just to have DFGCodeBlocks not trace CodeBlocks that are
not jettisoned. But CodeBlocks may be jettisoned later during the GC, so it must trace
any CodeBlock that it knows to be live by virtue of it being reachable from the stack.
Hence the real fix is to make sure that concurrent calls into CodeBlock::visitAggregate()
don't lead to two threads racing over each other as they clobber state. This patch
achieves this with a simple CAS loop: whichever thread wins the CAS race (which is
trivially linearizable) will get to trace the CodeBlock; all other threads give up and
go home.
Unfortunately there will be no new tests. It's possible to reproduce this maybe 1/10
times by running V8-v6's raytrace repeatedly, using the V8 harness hacked to rerun it
even when it's gotten sufficient counts. But that takes a while - sometimes up to a
minute to get a crash. I have no other reliable repro case.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
- bytecode/CodeBlock.h:
(DFGData):
- heap/DFGCodeBlocks.cpp:
(JSC::DFGCodeBlocks::clearMarks):
- 12:01 AM Changeset in webkit [109518] by
-
- 7 edits8 adds in trunk
AudioParam needs tests for the parameter automation routines.
https://bugs.webkit.org/show_bug.cgi?id=77666
Patch by Raymond Toy <Raymond Toy> on 2012-03-02
Reviewed by Chris Rogers.
Source/WebCore:
Tests: webaudio/audioparam-linearRampToValueAtTime.html
webaudio/audioparam-setTargetValueAtTime.html
webaudio/audioparam-setValueAtTime.html
webaudio/audioparam-setValueCurveAtTime.html
- webaudio/AudioParamTimeline.cpp:
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl): Round the
curveIndex to fix timing issue in setValueCurveAtTime.
LayoutTests:
- webaudio/audioparam-exponentialRampToValueAtTime.html:
- webaudio/audioparam-linearRampToValueAtTime-expected.txt: Added.
- webaudio/audioparam-linearRampToValueAtTime.html: Added.
- webaudio/audioparam-setTargetValueAtTime-expected.txt: Added.
- webaudio/audioparam-setTargetValueAtTime.html: Added.
- webaudio/audioparam-setValueAtTime-expected.txt: Added.
- webaudio/audioparam-setValueAtTime.html: Added.
- webaudio/audioparam-setValueCurveAtTime-expected.txt: Added.
- webaudio/audioparam-setValueCurveAtTime.html: Added.
- webaudio/resources/audioparam-testing.js:
(renderLength):
(createConstantArray):
(createLinearRampArray):
(discreteTimeConstantForSampleRate):
(createExponentialApproachArray):
(createSineWaveArray):
(endValueDelta):
(valueUpdate):
(comparePartialSignals):
(verifyDiscontinuities):
(compareSignals):
(checkResultFunction.return.var):
(checkResultFunction):
(doAutomation):
(createAudioGraphAndTest):
- webaudio/resources/audio-testing.js: Moved isValidNumber from
biquad-testing.js to here.
- webaudio/resources/biquad-testing.js: Moved isValidNumber from
here to audio-testing.js.
Mar 1, 2012:
- 11:33 PM Changeset in webkit [109517] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK] Simplify the code to adjust font sizes depending on screen DPI
https://bugs.webkit.org/show_bug.cgi?id=80032
Reviewed by Martin Robinson.
- webkit/webkitwebview.cpp:
(screenDPI): Helper function to get the DPI of a given
GdkScreen. Added also fallback code when gdk_screen_resolution
returns -1.
(webViewGetDPI): Use screenDPI() from WebCore.
(webViewConvertFontSizeToPixels): This is the existing
pixelsFromSize(), renamed and moved to be used also in
webkit_web_view_screen_changed().
(webkit_web_view_screen_changed): Use
webViewConvertFontSizeToPixels() instead of duplicating the code.
(webkit_web_view_settings_notify): Use
webViewConvertFontSizeToPixels() instead of pixelsFromSize().
- 10:50 PM Changeset in webkit [109516] by
-
- 2 edits in trunk/LayoutTests
Moar tightening of expectations (mac this time).
Unreviewed, expectations change.
- platform/chromium/test_expectations.txt:
- 10:50 PM Changeset in webkit [109515] by
-
- 11 edits in trunk/Source/WebCore
Fix code generators to correctly guard header declarations that have a [Conditional] attribute.
https://bugs.webkit.org/show_bug.cgi?id=79375
Patch by Pablo Flouret <pablof@motorola.com> on 2012-03-01
Reviewed by Kentaro Hara.
In most cases code generators weren't checking the Conditional attribute
when generating code in headers for function/attribute/constants, they
were just guarding against the Conditional for the whole interface.
- bindings/scripts/CodeGeneratorCPP.pm:
(GenerateHeader):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
- bindings/scripts/CodeGeneratorObjC.pm:
(GenerateHeader):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
- bindings/scripts/test/CPP/WebDOMTestInterface.h:
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- bindings/scripts/test/JS/JSTestInterface.h:
(JSTestInterface):
(WebCore):
- bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
- bindings/scripts/test/ObjC/DOMTestInterface.h:
- bindings/scripts/test/ObjC/DOMTestObj.h:
- 10:47 PM Changeset in webkit [109514] by
-
- 8 edits5 adds in trunk
[chromium] Make opaque paint tracker aware of SkCanvas layers
https://bugs.webkit.org/show_bug.cgi?id=79145
Patch by Dana Jansens <danakj@chromium.org> on 2012-03-01
Reviewed by Stephen White.
Source/WebCore:
The current opaque paint tracker ignored SkCanvas layers entirely. But
SkCanvas layers can be used to apply things like alpha. So we make it
know about layers, and apply any clipping and SkPaint objects for layers
when tracking a paint.
Image clipping is done via a layer, so we can now also remove the
special-case code around image clipping in PlatformContextSkia and
OpaqueRegionSkia.
Unit test: PlatformContextSkiaTest.contextTransparencyLayerTest
Test: compositing/culling/clear-fixed-iframe.html
- platform/graphics/skia/OpaqueRegionSkia.cpp:
(WebCore::OpaqueRegionSkia::didDrawRect):
(WebCore::OpaqueRegionSkia::didDrawPath):
(WebCore::OpaqueRegionSkia::didDrawPoints):
(WebCore::OpaqueRegionSkia::didDrawBounded):
(WebCore::OpaqueRegionSkia::didDraw):
(WebCore):
- platform/graphics/skia/OpaqueRegionSkia.h:
(OpaqueRegionSkia):
- platform/graphics/skia/PlatformContextSkia.cpp:
- platform/graphics/skia/PlatformContextSkia.h:
(PlatformContextSkia):
Source/WebKit/chromium:
- tests/PlatformContextSkiaTest.cpp:
(WebCore::TEST):
(WebCore):
LayoutTests:
- compositing/culling/clear-fixed-iframe-expected.png: Added.
- compositing/culling/clear-fixed-iframe-expected.txt: Added.
- compositing/culling/clear-fixed-iframe.html: Added.
- compositing/culling/resources/clear-fixed-iframe-content.html: Added.
- 10:43 PM Changeset in webkit [109513] by
-
- 3 edits2 adds in trunk/Source/WebCore
Add HTML-capable popup API to ChromeClient
https://bugs.webkit.org/show_bug.cgi?id=79078
Reviewed by Dimitri Glazkov.
This API will be used to implement a calendar picker of <input type=date>.
The code is enclosed with ENABLE_PAGE_POPUP, and doesn't change any
behavior for now.
- page/ChromeClient.h: Added declarations of openPagePopup() and closePagePopup().
- loader/EmptyClients.h:
(EmptyChromeClient): Add empty implementations of new ChromeClient functions.
- page/PagePopup.h: Added.
(PagePopup): Define an empty interface
- page/PagePopupClient.h: Added.
(PagePopupClient): Define an interface to provide various information to HTMLPopup.
- 10:33 PM Changeset in webkit [109512] by
-
- 9 edits2 adds in trunk
Render overflow controls of an RTL element to its left-side.
https://bugs.webkit.org/show_bug.cgi?id=54623
This change adds a new flag WTF_USE_RTL_SCROLLBAR and render the
vertical scrollbars and resizers of RTL elements to their left side if
this new flag is enabled.
Patch by Hironori Bono <hbono@chromium.org> on 2012-03-01
Reviewed by Ryosuke Niwa.
Source/WebCore:
Test: platform/chromium/fast/events/rtl-scrollbar.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addOverflowFromPositionedObjects): Move child elements right.
(WebCore::RenderBlock::determineLogicalLeftPositionForChild): ditto.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::overflowClipRect): Move the content rectangle right.
- rendering/RenderLayer.cpp:
(WebCore::cornerStart): Added a function that calculates the X position of a resizer.
(WebCore):
(WebCore::cornerRect): Use cornerStart to move a resizer.
(WebCore::RenderLayer::verticalScrollbarStart): Added a function that calculates
the X position of a vertical scrollbar.
(WebCore::RenderLayer::horizontalScrollbarStart): Added a function that calculates
the X position of a horizontal scrollbar.
(WebCore::RenderLayer::scrollbarOffset): Render a vertical scrollbar to the left side
and move a horizontal scrollbar right by the width of the vertical scrollbar.
(WebCore::RenderLayer::invalidateScrollbarRect): ditto.
(WebCore::RenderLayer::positionOverflowControls): ditto.
(WebCore::RenderLayer::hitTestOverflowControls): ditto.
- rendering/RenderLayer.h:
(RenderLayer):
- rendering/style/RenderStyle.h: Added shouldPlaceBlockDirectionScrollbarOnLogicalLeft,
which returns if we need to move a left scrollbar to its right side.
Source/WebKit/chromium:
- features.gypi: Set WTF_USE_RTL_SCROLLBAR to 1 on Chromium.
LayoutTests:
- platform/chromium/fast/events/rtl-scrollbar-expected.txt: Added.
- platform/chromium/fast/events/rtl-scrollbar.html: Added.
- 10:28 PM Changeset in webkit [109511] by
-
- 2 edits in trunk/Source/JavaScriptCore
The JIT should not crash the entire process just because there is not enough executable
memory, if the LLInt is enabled
https://bugs.webkit.org/show_bug.cgi?id=79962
Patch by Filip Pizlo <fpizlo@apple.com> on 2012-03-01
Reviewed by Csaba Osztrogonác.
Fix for ARM, SH4.
- assembler/AssemblerBufferWithConstantPool.h:
(JSC::AssemblerBufferWithConstantPool::executableCopy):
- 10:28 PM Changeset in webkit [109510] by
-
- 2 edits in trunk/LayoutTests
Tighten various expectations to be more accurate.
Unreviewed, expectations change.
(This means fewer "unexpected pass" results).
- platform/chromium/test_expectations.txt:
- 10:26 PM Changeset in webkit [109509] by
-
- 2 edits in trunk/Tools
WebKitTestRunner: Explicitly include unistd.h for gcc 4.7
https://bugs.webkit.org/show_bug.cgi?id=80033
Patch by Kalev Lember <kalevlember@gmail.com> on 2012-03-01
Reviewed by Gustavo Noronha Silva.
GCC 4.7 no longer includes unistd.h from most of the standard C++
header files, so we need to explicitly include it for getcwd().
- WebKitTestRunner/TestInvocation.cpp: Make sure unistd.h gets included
not only on Mac, but on all Unix platforms.
- 10:13 PM Changeset in webkit [109508] by
-
- 3 edits in trunk/Websites/webkit.org
Add a link to the EFL wiki page
https://bugs.webkit.org/show_bug.cgi?id=79439
Patch by Seo Sanghyeon <sh4.seo@samsung.com> on 2012-03-01
Reviewed by Adam Barth.
- building/tools.html:
- css/main.css: Cross-browser border-radius.
- 10:11 PM Changeset in webkit [109507] by
-
- 2 edits in trunk/LayoutTests
fast/forms/textfield-overflow.html is no longer failing.
Unreviewed, expectations change.
- platform/chromium/test_expectations.txt:
- 10:10 PM Changeset in webkit [109506] by
-
- 10 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Implement features for find-in-page
https://bugs.webkit.org/show_bug.cgi?id=79820
Patch by Andy Chen <andchen@rim.com> on 2012-03-01
Reviewed by Antonio Gomes.
- Make it be able to search text around the whole page instead of single frame.
- Make it be able to start new search from active selection and last active match.
No new tests as this patch doesn't change behavior.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::frameUnloaded):
- Api/WebPage_p.h:
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchWillClose):
(WebCore::FrameLoaderClientBlackBerry::detachedFromParent2):
- WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::incrementFrame):
- WebKitSupport/DOMSupport.h:
- WebKitSupport/InPageSearchManager.cpp:
(BlackBerry::WebKit::InPageSearchManager::findNextString):
(BlackBerry::WebKit::InPageSearchManager::shouldSearchForText):
(BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
(BlackBerry::WebKit::InPageSearchManager::setMarkerActive):
(BlackBerry::WebKit::InPageSearchManager::frameUnloaded):
- WebKitSupport/InPageSearchManager.h:
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::frameUnloaded):
- WebKitSupport/InputHandler.h:
- 9:56 PM Changeset in webkit [109505] by
-
- 1 edit9 moves1 add in trunk/LayoutTests
Fix paths to mac baselines for virtual/gpu/canvas/philip tests.
Unreveiwed, baselines update.
- platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.cone.cylinder-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.gradient.radial.cone.cylinder-expected.txt.
- platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.line.width.basic-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.line.width.basic-expected.txt.
- platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.line.width.transformed-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.line.width.transformed-expected.txt.
- platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.path.arcTo.shape.curve1-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.path.arcTo.shape.curve1-expected.txt.
- platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.path.arcTo.shape.curve2-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.path.arcTo.shape.curve2-expected.txt.
- platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.shadow.enable.blur-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.shadow.enable.blur-expected.txt.
- platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.fontface.notinpage-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.text.draw.fontface.notinpage-expected.txt.
- platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.transformation.setTransform.skewed-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.transformation.setTransform.skewed-expected.txt.
- platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.transformation.transform.skewed-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.transformation.transform.skewed-expected.txt.
- 9:45 PM Changeset in webkit [109504] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, gardening.
- platform/chromium/test_expectations.txt:
- 9:43 PM Changeset in webkit [109503] by
-
- 4 edits3 adds in trunk
REGRESSION(90089): Input type='search' text shakes up and down when the style is changed.
https://bugs.webkit.org/show_bug.cgi?id=79445
Reviewed by Dimitri Glazkov.
Source/WebCore:
If the inner text height of a search field is smaller than the
content box height of the <input>, the height of the container
element should be same as the content box height.
When the element style is changed, the RenderStyle height of the
container element is cleared, but the renderer height of the
container element remains. We had a bug that layout() didn't set
the RenderStyle height in a case that the renderer height was the
desired height. It shrunk the renderer height as the result of
layout for children.
Tests: fast/forms/search/search-shaking-text.html
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::layout):
Always set the RenderStyle height explicitly.
LayoutTests:
- fast/forms/search/search-shaking-text-expected.html: Added.
- fast/forms/search/search-shaking-text.html: Added.
- platform/chromium/test_expectations.txt: This change might need a rebaseline of fast/repaint/search-field-cancel.html
- 9:40 PM Changeset in webkit [109502] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rebaselined run-bindings-tests results.
- bindings/scripts/test/CPP/WebDOMTestObj.cpp:
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- 9:37 PM Changeset in webkit [109501] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed, gardening.
- platform/chromium/fast/js/mozilla/strict/13.1-expected.txt: Removed.
- 9:35 PM Changeset in webkit [109500] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed, gardening.
- platform/chromium/fast/js/mozilla/strict/12.14.1-expected.txt: Removed.
- 9:26 PM Changeset in webkit [109499] by
-
- 1 edit2 adds1 delete in trunk/LayoutTests
Unreviewed, gardening.
- platform/chromium-linux/fast/frames/transparent-scrollbar-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/frames/transparent-scrollbar-expected.png: Added.
- platform/chromium-win/fast/frames/transparent-scrollbar-expected.png: Added.
- 9:25 PM Changeset in webkit [109498] by
-
- 2 edits in trunk/Tools
Actually look at the args in driver_input :(.
Unreviewed, build fix.
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver.run_test):
- 8:54 PM Changeset in webkit [109497] by
-
- 2 edits in trunk/Source/WebCore
<rdar://problem/10942540> REGRESSION (r108956): Safari Webpage Preview Fetcher crashes in WebCore::localizedString() when using a WebKit nightly build
https://bugs.webkit.org/show_bug.cgi?id=80034
Reviewed by Benjamin Poulain.
Safari Webpage Preview Fetcher can’t access the WebCore framework when launched from a WebKit
nightly build. After r108956, this causes it to crash.
- platform/mac/LocalizedStringsMac.cpp:
(WebCore::localizedString): Added a null-check for the value returned from
CFBundleGetBundleWithIdentifier(CFSTR("com.apple.WebCore")).
- 8:49 PM Changeset in webkit [109496] by
-
- 2 edits in trunk/Tools
Fix typo in flag used to run gpu virtual suites.
Unreviewed, build fix.
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.virtual_test_suites):
- 8:31 PM Changeset in webkit [109495] by
-
- 3 edits in trunk/Tools
Unreviewed, rolling out r109317.
http://trac.webkit.org/changeset/109317
Let's try watchlists again now that we're using a pure git
working copy
- Scripts/webkitpy/tool/bot/stylequeuetask.py:
(StyleQueueTask.run):
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- 8:26 PM Changeset in webkit [109494] by
-
- 5 edits3 adds in trunk
[BlackBerry]Array of Cookies in HTTP request header are not in order.
https://bugs.webkit.org/show_bug.cgi?id=79870
Std::sort and HashMap are not stable. So cookies with the same creating
time sometimes are sent disorder.
Change std::sort with std::stable-sort.
We don't need using HashMap to save so few cookies for one domain.
It is a wast of time to create HashMap, too.
So change it with vector.
Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-03-01
Reviewed by George Staikos.
Test: http/tests/cookies/resources/setArraycookies.php
- platform/blackberry/CookieManager.cpp:
(WebCore::cookieSorter):
(WebCore::CookieManager::getRawCookies):
(WebCore::CookieManager::checkAndTreatCookie):
(WebCore::CookieManager::addCookieToMap):
- platform/blackberry/CookieManager.h:
- platform/blackberry/CookieMap.cpp:
(WebCore::CookieMap::addOrReplaceCookie):
(WebCore::CookieMap::removeCookieAtIndex):
(WebCore::CookieMap::removeCookie):
(WebCore):
(WebCore::CookieMap::getAllCookies):
(WebCore::CookieMap::updateOldestCookie):
(WebCore::CookieMap::deleteAllCookiesAndDomains):
- platform/blackberry/CookieMap.h:
(WebCore::CookieMap::count):
(CookieMap):
- 8:23 PM Changeset in webkit [109493] by
-
- 15 edits84 moves in trunk/Source/WebCore
Move WebCore/storage/IDB* files into WebCore/Modules/indexeddb
https://bugs.webkit.org/show_bug.cgi?id=80071
Reviewed by Kentaro Hara.
Now that we've removed all the ENABLE(INDEXED_DATABASE) ifdefs from
WebCore proper, we can move IndexedDB into its own module.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Modules/indexeddb/IDBAny.cpp: Copied from Source/WebCore/storage/IDBAny.cpp.
- Modules/indexeddb/IDBAny.h: Copied from Source/WebCore/storage/IDBAny.h.
- Modules/indexeddb/IDBAny.idl: Copied from Source/WebCore/storage/IDBAny.idl.
- Modules/indexeddb/IDBBackingStore.h: Copied from Source/WebCore/storage/IDBBackingStore.h.
- Modules/indexeddb/IDBCallbacks.h: Copied from Source/WebCore/storage/IDBCallbacks.h.
- Modules/indexeddb/IDBCursor.cpp: Copied from Source/WebCore/storage/IDBCursor.cpp.
- Modules/indexeddb/IDBCursor.h: Copied from Source/WebCore/storage/IDBCursor.h.
- Modules/indexeddb/IDBCursor.idl: Copied from Source/WebCore/storage/IDBCursor.idl.
- Modules/indexeddb/IDBCursorBackendImpl.cpp: Copied from Source/WebCore/storage/IDBCursorBackendImpl.cpp.
- Modules/indexeddb/IDBCursorBackendImpl.h: Copied from Source/WebCore/storage/IDBCursorBackendImpl.h.
- Modules/indexeddb/IDBCursorBackendInterface.h: Copied from Source/WebCore/storage/IDBCursorBackendInterface.h.
- Modules/indexeddb/IDBCursorWithValue.cpp: Copied from Source/WebCore/storage/IDBCursorWithValue.cpp.
- Modules/indexeddb/IDBCursorWithValue.h: Copied from Source/WebCore/storage/IDBCursorWithValue.h.
- Modules/indexeddb/IDBCursorWithValue.idl: Copied from Source/WebCore/storage/IDBCursorWithValue.idl.
- Modules/indexeddb/IDBDatabase.cpp: Copied from Source/WebCore/storage/IDBDatabase.cpp.
- Modules/indexeddb/IDBDatabase.h: Copied from Source/WebCore/storage/IDBDatabase.h.
- Modules/indexeddb/IDBDatabase.idl: Copied from Source/WebCore/storage/IDBDatabase.idl.
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp: Copied from Source/WebCore/storage/IDBDatabaseBackendImpl.cpp.
- Modules/indexeddb/IDBDatabaseBackendImpl.h: Copied from Source/WebCore/storage/IDBDatabaseBackendImpl.h.
- Modules/indexeddb/IDBDatabaseBackendInterface.h: Copied from Source/WebCore/storage/IDBDatabaseBackendInterface.h.
- Modules/indexeddb/IDBDatabaseCallbacks.h: Copied from Source/WebCore/storage/IDBDatabaseCallbacks.h.
- Modules/indexeddb/IDBDatabaseCallbacksImpl.cpp: Copied from Source/WebCore/storage/IDBDatabaseCallbacksImpl.cpp.
- Modules/indexeddb/IDBDatabaseCallbacksImpl.h: Copied from Source/WebCore/storage/IDBDatabaseCallbacksImpl.h.
- Modules/indexeddb/IDBDatabaseError.h: Copied from Source/WebCore/storage/IDBDatabaseError.h.
- Modules/indexeddb/IDBDatabaseError.idl: Copied from Source/WebCore/storage/IDBDatabaseError.idl.
- Modules/indexeddb/IDBDatabaseException.cpp: Copied from Source/WebCore/storage/IDBDatabaseException.cpp.
- Modules/indexeddb/IDBDatabaseException.h: Copied from Source/WebCore/storage/IDBDatabaseException.h.
- Modules/indexeddb/IDBDatabaseException.idl: Copied from Source/WebCore/storage/IDBDatabaseException.idl.
- Modules/indexeddb/IDBEventDispatcher.cpp: Copied from Source/WebCore/storage/IDBEventDispatcher.cpp.
- Modules/indexeddb/IDBEventDispatcher.h: Copied from Source/WebCore/storage/IDBEventDispatcher.h.
- Modules/indexeddb/IDBFactory.cpp: Copied from Source/WebCore/storage/IDBFactory.cpp.
- Modules/indexeddb/IDBFactory.h: Copied from Source/WebCore/storage/IDBFactory.h.
- Modules/indexeddb/IDBFactory.idl: Copied from Source/WebCore/storage/IDBFactory.idl.
- Modules/indexeddb/IDBFactoryBackendImpl.cpp: Copied from Source/WebCore/storage/IDBFactoryBackendImpl.cpp.
- Modules/indexeddb/IDBFactoryBackendImpl.h: Copied from Source/WebCore/storage/IDBFactoryBackendImpl.h.
- Modules/indexeddb/IDBFactoryBackendInterface.cpp: Copied from Source/WebCore/storage/IDBFactoryBackendInterface.cpp.
- Modules/indexeddb/IDBFactoryBackendInterface.h: Copied from Source/WebCore/storage/IDBFactoryBackendInterface.h.
- Modules/indexeddb/IDBIndex.cpp: Copied from Source/WebCore/storage/IDBIndex.cpp.
- Modules/indexeddb/IDBIndex.h: Copied from Source/WebCore/storage/IDBIndex.h.
- Modules/indexeddb/IDBIndex.idl: Copied from Source/WebCore/storage/IDBIndex.idl.
- Modules/indexeddb/IDBIndexBackendImpl.cpp: Copied from Source/WebCore/storage/IDBIndexBackendImpl.cpp.
- Modules/indexeddb/IDBIndexBackendImpl.h: Copied from Source/WebCore/storage/IDBIndexBackendImpl.h.
- Modules/indexeddb/IDBIndexBackendInterface.h: Copied from Source/WebCore/storage/IDBIndexBackendInterface.h.
- Modules/indexeddb/IDBKey.cpp: Copied from Source/WebCore/storage/IDBKey.cpp.
- Modules/indexeddb/IDBKey.h: Copied from Source/WebCore/storage/IDBKey.h.
- Modules/indexeddb/IDBKey.idl: Copied from Source/WebCore/storage/IDBKey.idl.
- Modules/indexeddb/IDBKeyPath.cpp: Copied from Source/WebCore/storage/IDBKeyPath.cpp.
- Modules/indexeddb/IDBKeyPath.h: Copied from Source/WebCore/storage/IDBKeyPath.h.
- Modules/indexeddb/IDBKeyPathBackendImpl.cpp: Copied from Source/WebCore/storage/IDBKeyPathBackendImpl.cpp.
- Modules/indexeddb/IDBKeyPathBackendImpl.h: Copied from Source/WebCore/storage/IDBKeyPathBackendImpl.h.
- Modules/indexeddb/IDBKeyRange.cpp: Copied from Source/WebCore/storage/IDBKeyRange.cpp.
- Modules/indexeddb/IDBKeyRange.h: Copied from Source/WebCore/storage/IDBKeyRange.h.
- Modules/indexeddb/IDBKeyRange.idl: Copied from Source/WebCore/storage/IDBKeyRange.idl.
- Modules/indexeddb/IDBLevelDBBackingStore.cpp: Copied from Source/WebCore/storage/IDBLevelDBBackingStore.cpp.
- Modules/indexeddb/IDBLevelDBBackingStore.h: Copied from Source/WebCore/storage/IDBLevelDBBackingStore.h.
- Modules/indexeddb/IDBLevelDBCoding.cpp: Copied from Source/WebCore/storage/IDBLevelDBCoding.cpp.
- Modules/indexeddb/IDBLevelDBCoding.h: Copied from Source/WebCore/storage/IDBLevelDBCoding.h.
- Modules/indexeddb/IDBObjectStore.cpp: Copied from Source/WebCore/storage/IDBObjectStore.cpp.
- Modules/indexeddb/IDBObjectStore.h: Copied from Source/WebCore/storage/IDBObjectStore.h.
- Modules/indexeddb/IDBObjectStore.idl: Copied from Source/WebCore/storage/IDBObjectStore.idl.
- Modules/indexeddb/IDBObjectStoreBackendImpl.cpp: Copied from Source/WebCore/storage/IDBObjectStoreBackendImpl.cpp.
- Modules/indexeddb/IDBObjectStoreBackendImpl.h: Copied from Source/WebCore/storage/IDBObjectStoreBackendImpl.h.
- Modules/indexeddb/IDBObjectStoreBackendInterface.h: Copied from Source/WebCore/storage/IDBObjectStoreBackendInterface.h.
- Modules/indexeddb/IDBPendingTransactionMonitor.cpp: Copied from Source/WebCore/storage/IDBPendingTransactionMonitor.cpp.
- Modules/indexeddb/IDBPendingTransactionMonitor.h: Copied from Source/WebCore/storage/IDBPendingTransactionMonitor.h.
- Modules/indexeddb/IDBRequest.cpp: Copied from Source/WebCore/storage/IDBRequest.cpp.
- Modules/indexeddb/IDBRequest.h: Copied from Source/WebCore/storage/IDBRequest.h.
- Modules/indexeddb/IDBRequest.idl: Copied from Source/WebCore/storage/IDBRequest.idl.
- Modules/indexeddb/IDBTracing.h: Copied from Source/WebCore/storage/IDBTracing.h.
- Modules/indexeddb/IDBTransaction.cpp: Copied from Source/WebCore/storage/IDBTransaction.cpp.
- Modules/indexeddb/IDBTransaction.h: Copied from Source/WebCore/storage/IDBTransaction.h.
- Modules/indexeddb/IDBTransaction.idl: Copied from Source/WebCore/storage/IDBTransaction.idl.
- Modules/indexeddb/IDBTransactionBackendImpl.cpp: Copied from Source/WebCore/storage/IDBTransactionBackendImpl.cpp.
- Modules/indexeddb/IDBTransactionBackendImpl.h: Copied from Source/WebCore/storage/IDBTransactionBackendImpl.h.
- Modules/indexeddb/IDBTransactionBackendInterface.h: Copied from Source/WebCore/storage/IDBTransactionBackendInterface.h.
- Modules/indexeddb/IDBTransactionCallbacks.h: Copied from Source/WebCore/storage/IDBTransactionCallbacks.h.
- Modules/indexeddb/IDBTransactionCoordinator.cpp: Copied from Source/WebCore/storage/IDBTransactionCoordinator.cpp.
- Modules/indexeddb/IDBTransactionCoordinator.h: Copied from Source/WebCore/storage/IDBTransactionCoordinator.h.
- Modules/indexeddb/IDBVersionChangeEvent.cpp: Copied from Source/WebCore/storage/IDBVersionChangeEvent.cpp.
- Modules/indexeddb/IDBVersionChangeEvent.h: Copied from Source/WebCore/storage/IDBVersionChangeEvent.h.
- Modules/indexeddb/IDBVersionChangeEvent.idl: Copied from Source/WebCore/storage/IDBVersionChangeEvent.idl.
- Modules/indexeddb/IDBVersionChangeRequest.cpp: Copied from Source/WebCore/storage/IDBVersionChangeRequest.cpp.
- Modules/indexeddb/IDBVersionChangeRequest.h: Copied from Source/WebCore/storage/IDBVersionChangeRequest.h.
- Modules/indexeddb/IDBVersionChangeRequest.idl: Copied from Source/WebCore/storage/IDBVersionChangeRequest.idl.
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- storage/IDBAny.cpp: Removed.
- storage/IDBAny.h: Removed.
- storage/IDBAny.idl: Removed.
- storage/IDBBackingStore.h: Removed.
- storage/IDBCallbacks.h: Removed.
- storage/IDBCursor.cpp: Removed.
- storage/IDBCursor.h: Removed.
- storage/IDBCursor.idl: Removed.
- storage/IDBCursorBackendImpl.cpp: Removed.
- storage/IDBCursorBackendImpl.h: Removed.
- storage/IDBCursorBackendInterface.h: Removed.
- storage/IDBCursorWithValue.cpp: Removed.
- storage/IDBCursorWithValue.h: Removed.
- storage/IDBCursorWithValue.idl: Removed.
- storage/IDBDatabase.cpp: Removed.
- storage/IDBDatabase.h: Removed.
- storage/IDBDatabase.idl: Removed.
- storage/IDBDatabaseBackendImpl.cpp: Removed.
- storage/IDBDatabaseBackendImpl.h: Removed.
- storage/IDBDatabaseBackendInterface.h: Removed.
- storage/IDBDatabaseCallbacks.h: Removed.
- storage/IDBDatabaseCallbacksImpl.cpp: Removed.
- storage/IDBDatabaseCallbacksImpl.h: Removed.
- storage/IDBDatabaseError.h: Removed.
- storage/IDBDatabaseError.idl: Removed.
- storage/IDBDatabaseException.cpp: Removed.
- storage/IDBDatabaseException.h: Removed.
- storage/IDBDatabaseException.idl: Removed.
- storage/IDBEventDispatcher.cpp: Removed.
- storage/IDBEventDispatcher.h: Removed.
- storage/IDBFactory.cpp: Removed.
- storage/IDBFactory.h: Removed.
- storage/IDBFactory.idl: Removed.
- storage/IDBFactoryBackendImpl.cpp: Removed.
- storage/IDBFactoryBackendImpl.h: Removed.
- storage/IDBFactoryBackendInterface.cpp: Removed.
- storage/IDBFactoryBackendInterface.h: Removed.
- storage/IDBIndex.cpp: Removed.
- storage/IDBIndex.h: Removed.
- storage/IDBIndex.idl: Removed.
- storage/IDBIndexBackendImpl.cpp: Removed.
- storage/IDBIndexBackendImpl.h: Removed.
- storage/IDBIndexBackendInterface.h: Removed.
- storage/IDBKey.cpp: Removed.
- storage/IDBKey.h: Removed.
- storage/IDBKey.idl: Removed.
- storage/IDBKeyPath.cpp: Removed.
- storage/IDBKeyPath.h: Removed.
- storage/IDBKeyPathBackendImpl.cpp: Removed.
- storage/IDBKeyPathBackendImpl.h: Removed.
- storage/IDBKeyRange.cpp: Removed.
- storage/IDBKeyRange.h: Removed.
- storage/IDBKeyRange.idl: Removed.
- storage/IDBLevelDBBackingStore.cpp: Removed.
- storage/IDBLevelDBBackingStore.h: Removed.
- storage/IDBLevelDBCoding.cpp: Removed.
- storage/IDBLevelDBCoding.h: Removed.
- storage/IDBObjectStore.cpp: Removed.
- storage/IDBObjectStore.h: Removed.
- storage/IDBObjectStore.idl: Removed.
- storage/IDBObjectStoreBackendImpl.cpp: Removed.
- storage/IDBObjectStoreBackendImpl.h: Removed.
- storage/IDBObjectStoreBackendInterface.h: Removed.
- storage/IDBPendingTransactionMonitor.cpp: Removed.
- storage/IDBPendingTransactionMonitor.h: Removed.
- storage/IDBRequest.cpp: Removed.
- storage/IDBRequest.h: Removed.
- storage/IDBRequest.idl: Removed.
- storage/IDBTracing.h: Removed.
- storage/IDBTransaction.cpp: Removed.
- storage/IDBTransaction.h: Removed.
- storage/IDBTransaction.idl: Removed.
- storage/IDBTransactionBackendImpl.cpp: Removed.
- storage/IDBTransactionBackendImpl.h: Removed.
- storage/IDBTransactionBackendInterface.h: Removed.
- storage/IDBTransactionCallbacks.h: Removed.
- storage/IDBTransactionCoordinator.cpp: Removed.
- storage/IDBTransactionCoordinator.h: Removed.
- storage/IDBVersionChangeEvent.cpp: Removed.
- storage/IDBVersionChangeEvent.h: Removed.
- storage/IDBVersionChangeEvent.idl: Removed.
- storage/IDBVersionChangeRequest.cpp: Removed.
- storage/IDBVersionChangeRequest.h: Removed.
- storage/IDBVersionChangeRequest.idl: Removed.
- 7:45 PM Changeset in webkit [109492] by
-
- 2 edits in trunk/LayoutTests
Remove tests that now pass.
Unreviewed, expectations change.
- platform/chromium/test_expectations.txt:
- 7:37 PM Changeset in webkit [109491] by
-
- 2 edits in trunk/Tools
webkitpy: test_run_test_pause_before_testing is failing after r109482
https://bugs.webkit.org/show_bug.cgi?id=80084
Unreviewed, build fix.
Fixes the test string compare to ignore the time spent running
the tests.
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_run_test_pause_before_testing):
- 7:28 PM Changeset in webkit [109490] by
-
- 4 edits in trunk/Tools
nrwt: virtual tests aren't being run
https://bugs.webkit.org/show_bug.cgi?id=80083
Reviewed by Eric Seidel.
If we tried to run all of the tests by default (and
didn't specify any paths), the virtual tests weren't
picked up.
- Scripts/webkitpy/layout_tests/port/base.py:
(Port._virtual_tests):
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_tests):
- Scripts/webkitpy/layout_tests/port/test.py:
(TestPort.virtual_test_suites):
- 7:28 PM Changeset in webkit [109489] by
-
- 3 edits in trunk/LayoutTests
Fix test checking for incorrect results.
Rubber stamped by Sam Weinig.
- fast/js/mozilla/strict/function-name-arity-expected.txt:
- fast/js/mozilla/strict/script-tests/function-name-arity.js:
- This tests a non-existent, non-spec-defined property.
- 7:18 PM Changeset in webkit [109488] by
-
- 3 edits in trunk/Source/WebCore
Handle CSSPropertyWebkitBorderFit in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=79998
Reviewed by Andreas Kling.
No new tests / refactoring only.
- css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- 7:17 PM Changeset in webkit [109487] by
-
- 3 edits in trunk/LayoutTests
Fix test checking for incorrect results.
Rubber stamped by Sam Weinig.
- fast/js/mozilla/strict/12.14.1-expected.txt:
- fast/js/mozilla/strict/script-tests/12.14.1.js:
- This test uses destructuring, this didn't make it into ES5.
- 7:11 PM Changeset in webkit [109486] by
-
- 2 edits in trunk/Source/WebCore
Crash when doing repeated double-tap-to-zoom gesture on apple startpage
https://bugs.webkit.org/show_bug.cgi?id=80081
<rdar://problem/10966391>
Reviewed by Sam Weinig.
Setting the contents scale on the tile cache layer was creating a WebTileCacheLayer presentation layer copy with a null _tileCache.
Implement -[WebTileCacheLayer actionForKey:] and have it always return nil so we'll avoid implicit animations, and thus creating presentation layers.
- platform/graphics/ca/mac/WebTileCacheLayer.mm:
(-[WebTileCacheLayer initWithLayer:]):
Implement this and assert that it's never reached. We should never create presentation layers since we don't animate this layer.
(-[WebTileCacheLayer actionForKey:]):
Implement this and always return nil.
- 7:10 PM Changeset in webkit [109485] by
-
- 3 edits in trunk/LayoutTests
Fix test checking for incorrect results.
Rubber stamped by Sam Weinig.
- fast/js/mozilla/strict/13.1-expected.txt:
- fast/js/mozilla/strict/script-tests/13.1.js:
- This test uses destructuring, this didn't make it into ES5.
- 7:08 PM Changeset in webkit [109484] by
-
- 3 edits in trunk/LayoutTests
Fix typo in test, causing test to fail.
Rubber stamped by Sam Weinig.
- fast/js/number-parsing-crash-expected.txt:
- fast/js/script-tests/number-parsing-crash.js:
- 6:39 PM Changeset in webkit [109483] by
-
- 6 edits3 adds in trunk
Custom scrollbars do not support transparency
https://bugs.webkit.org/show_bug.cgi?id=50547
Source/WebCore:
Patch by Hajime Morrita <morrita@chromium.org> on 2012-03-01
Reviewed by James Robinson.
RenderScrollbar, which is used even for outermost frame when
-webkit-scrollbar is specified, assumes that its background is
painted by the enclosing container. But there is no such container
for outermost frame. This causes visual glitches when the
scrollbar has transparency.
This change clears background region for custom
outermostscrollbars to erase such glitches.
Test: fast/frames/transparent-scrollbar.html
- page/FrameView.cpp:
(WebCore::FrameView::paintScrollbar): The background is cleared here.
(WebCore):
- page/FrameView.h:
(FrameView):
- platform/ScrollView.cpp:
(WebCore::ScrollView::paintScrollbar): Added to hook in FrameView
(WebCore):
(WebCore::ScrollView::paintScrollbars):
- platform/ScrollView.h:
(ScrollView):
LayoutTests:
Reviewed by James Robinson.
- fast/frames/transparent-scrollbar.html: Added.
- fast/frames/transparent-scrollbar-expected.txt: Added.
- platform/chromium-linux/fast/frames/transparent-scrollbar-expected.png: Added.
- 6:35 PM Changeset in webkit [109482] by
-
- 2 edits in trunk/Tools
run-perf-tests should report the test runtime
https://bugs.webkit.org/show_bug.cgi?id=80078
Reviewed by Hajime Morita.
Record and output the aggreated test run time.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._run_single_test):
- 6:32 PM Changeset in webkit [109481] by
-
- 2 edits in trunk/Source/JavaScriptCore
Revert my change. Broke builds.
Source/JavaScriptCore/wtf/Atomics.h:188: error: redefinition of 'bool WTF::weakCompareAndSwap(volatile uintptr_t*, uintptr_t, uintptr_t)'
Source/JavaScriptCore/wtf/Atomics.h:122: error: 'bool WTF::weakCompareAndSwap(volatile unsigned int*, unsigned int, unsigned i
- wtf/Atomics.h:
(WTF):
(WTF::weakCompareAndSwap):
- 6:29 PM Changeset in webkit [109480] by
-
- 5 edits4 adds in trunk
REGRESSION(r106388): Form state is restored to a wrong document.
https://bugs.webkit.org/show_bug.cgi?id=79206
Reviewed by Brady Eidson.
Source/WebCore:
In some cases, the URL of the current HistoryItem and the document
URL are mismatched.
A form state should be restored only if the document was loaded
with a HistoryItem and the document is not loaded as a
redirection.
Test: fast/loader/form-state-restore-with-locked-back-forward-list.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkCompleted): Clear m_requestedHistoryItem.
(WebCore::FrameLoader::loadItem):
Save the requested HistoryItem for didLoadWithLodItem().
- loader/FrameLoader.h:
(WebCore::FrameLoader::requestedHistoryItem):
Added. Accessor for m_requestedHistoryItem.
- loader/HistoryController.cpp:
(WebCore::HistoryController::restoreDocumentState):
Restore a form state only if the current document was loaded with
FrameLoader::loadItem() and not redirection.
LayoutTests:
- fast/loader/form-state-restore-with-locked-back-forward-list-expected.txt: Added.
- fast/loader/form-state-restore-with-locked-back-forward-list.html: Added.
- fast/loader/resources/form-state-restore-with-locked-back-forward-list-2.html: Added.
- fast/loader/resources/form-state-restore-with-locked-back-forward-list-3.html: Added.
- 6:23 PM Changeset in webkit [109479] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 107726
BUG=114068
Review URL: https://chromiumcodereview.appspot.com/9570062
- 6:13 PM Changeset in webkit [109478] by
-
- 2 edits in trunk/Source/JavaScriptCore
Gcc build fix.
Rubber-stamped by Filip Pizlo.
- wtf/Atomics.h:
(WTF):
(WTF::weakCompareAndSwap):
- 6:04 PM Changeset in webkit [109477] by
-
- 1 edit2 copies in branches/chromium/963
Merge 107726
BUG=114068
Review URL: https://chromiumcodereview.appspot.com/9569051
- 6:00 PM Changeset in webkit [109476] by
-
- 2 edits in trunk/Source/WebCore
SSE optimization for vsvesq and vmaxmgv
https://bugs.webkit.org/show_bug.cgi?id=77950
Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-03-01
Reviewed by Chris Rogers.
Achieved the performance of 3.7x on vsvesq and 4.1x on vmaxmgv.
- platform/audio/VectorMath.cpp:
(WebCore::VectorMath::vsvesq):
(WebCore::VectorMath::vmaxmgv):
- 5:57 PM Changeset in webkit [109475] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Web Notification crashes the browser.
https://bugs.webkit.org/show_bug.cgi?id=79897
Patch by Charles Wei <charles.wei@torchmobile.com.cn> on 2012-03-01
Reviewed by Antonio Gomes.
The reason of the crash is that it still uses the iterator
after been removed from the container, which invalidates the
iterator.
We should stop processing after we have found the element
and removed from the container through the iterator.
This patch only fixes the crash issue, but not any notification
functionality issue, which is tracked seperatly.
Test case: http://sandbox.gtaero.net/chrome/notifications.php
- WebCoreSupport/NotificationPresenterImpl.cpp:
(WebKit::NotificationPresenterImpl::onPermission):
(WebKit::NotificationPresenterImpl::notificationClicked):
- 5:57 PM Changeset in webkit [109474] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 107761
BUG=112775
Review URL: https://chromiumcodereview.appspot.com/9570058
- 5:51 PM Changeset in webkit [109473] by
-
- 1 edit2 copies in branches/chromium/963
Merge 107761
BUG=112775
Review URL: https://chromiumcodereview.appspot.com/9570057
- 5:44 PM Changeset in webkit [109472] by
-
- 3 edits in trunk/Source/WebCore
Handle CSSPropertyBoxSizing in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=80001
Reviewed by Andreas Kling.
No new tests / refactoring only.
- css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- 5:26 PM Changeset in webkit [109471] by
-
- 1 edit8 copies in branches/chromium/1025
Merge 109299
BUG=116474
Review URL: https://chromiumcodereview.appspot.com/9569050
- 5:23 PM Changeset in webkit [109470] by
-
- 1 edit8 copies in branches/chromium/963
Merge 109299
BUG=116474
Review URL: https://chromiumcodereview.appspot.com/9568049
- 5:14 PM Changeset in webkit [109469] by
-
- 16 edits in trunk/Source
[chromium] LayerChromium::contentChanged is redundant with setNeedsDisplay
https://bugs.webkit.org/show_bug.cgi?id=79708
Reviewed by Adrienne Walker.
Some layer types need special handling when they receive damage. WebGL layers need to know if their texture is
updated for clear-on-swap behavior and both WebGL and canvas 2d layers have rate limiting mechanisms tied to
receiving invalidations. This mechanism was implemented by LayerChromium::contentChanged(), but this is
redundant with setNeedsDisplay().
Covered by existing tests.
- platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::setNeedsDisplay):
- platform/graphics/chromium/Canvas2DLayerChromium.h:
(Canvas2DLayerChromium):
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setContentsNeedsDisplay):
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setNeedsDisplay):
- platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
- platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::setNeedsDisplay):
- platform/graphics/chromium/VideoLayerChromium.h:
(VideoLayerChromium):
- platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::setNeedsDisplay):
- platform/graphics/chromium/WebGLLayerChromium.h:
(WebGLLayerChromium):
- 5:06 PM Changeset in webkit [109468] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Mark a JS strict mode test as failing in V8,
and link it to a semi-related V8 bug.
- platform/chromium/test_expectations.txt:
- 5:03 PM Changeset in webkit [109467] by
-
- 9 edits4 copies in branches/chromium/1025
Merge 109362
BUG=113755
Review URL: https://chromiumcodereview.appspot.com/9567036
- 4:47 PM Changeset in webkit [109466] by
-
- 9 edits in trunk/Source
[chromium] Rename LayerChromium::name to debugName to be more consistent with other debug properties, make threadsafe
https://bugs.webkit.org/show_bug.cgi?id=79723
Reviewed by Adrienne Walker.
Source/WebCore:
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::updateNames):
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::pushPropertiesTo):
(WebCore::LayerChromium::setDebugName):
(WebCore):
- platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::dumpLayer):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
(WebCore::CCLayerImpl::setDebugName):
(WebCore::CCLayerImpl::debugName):
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::name):
Source/WebKit/chromium:
- tests/LayerChromiumTest.cpp:
- 4:42 PM Changeset in webkit [109465] by
-
- 9 edits4 copies in branches/chromium/963
Merge 109362
BUG=113755
Review URL: https://chromiumcodereview.appspot.com/9569046
- 4:33 PM Changeset in webkit [109464] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Mark two media tests as flaky.
- platform/chromium/test_expectations.txt:
- 4:25 PM Changeset in webkit [109463] by
-
- 7 edits2 adds in trunk/Source/WebCore
Remove last ENABLED(INDEXED_DATABASE) ifdef from WebCore proper
https://bugs.webkit.org/show_bug.cgi?id=80061
Reviewed by Dimitri Glazkov.
This patch removes the last ENABLED(INDEXED_DATABASE) ifdef from
WebCore proper by moving the backend factory out of PageGroup and into
a supplement for PageGroup. After this patch, we're ready to move the
IDB code into Modules.
- Modules/indexeddb/DOMWindowIndexedDatabase.cpp:
(WebCore::DOMWindowIndexedDatabase::webkitIndexedDB):
- WebCore.gypi:
- inspector/InspectorIndexedDBAgent.cpp:
(WebCore::assertIDBFactory):
- page/PageGroup.cpp:
(WebCore):
- page/PageGroup.h:
(PageGroup):
- 4:25 PM Changeset in webkit [109462] by
-
- 2 edits in trunk/Tools
[chromium] Use webkit_support to create session storage namespaces in DRT.
https://bugs.webkit.org/show_bug.cgi?id=79933
Reviewed by Tony Chang.
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createSessionStorageNamespace):
- 4:12 PM Changeset in webkit [109461] by
-
- 7 edits in trunk
ES5.1-15.3.5.4. prohibits Function.caller from Get?ting a strict caller
https://bugs.webkit.org/show_bug.cgi?id=80011
Reviewed by Oliver Hunt.
Also, fix getting the caller from within a bound function, for within a getter,
or setter (make our implementation match other browsers).
Source/JavaScriptCore:
- interpreter/Interpreter.cpp:
(JSC::getCallerInfo):
- Allow this to get the caller of host functions.
(JSC::Interpreter::retrieveCallerFromVMCode):
- This should use getCallerInfo, and should skip over function bindings.
- runtime/JSFunction.cpp:
(JSC::JSFunction::callerGetter):
- This should never return a strict-mode function.
LayoutTests:
- fast/js/caller-property-expected.txt:
- fast/js/script-tests/caller-property.js:
- Add test cases covering permutations of caller/callee being strict/non-strict, And for callee being a getter/setter/bound.
- fast/js/stack-trace-expected.txt:
- Allow stack tracing over host functions.
- 4:11 PM Changeset in webkit [109460] by
-
- 3 edits in branches/chromium/1025/Source/WebCore
Merge 109406
BUG=116405
Review URL: https://chromiumcodereview.appspot.com/9564040
- 4:05 PM Changeset in webkit [109459] by
-
- 4 edits in trunk/Source
Remove deprecated FFmpeg build directories.
https://bugs.webkit.org/show_bug.cgi?id=79282
We've switched the layout of the FFmpeg repo in Chrome and these paths
are no longer needed or valid.
Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-03-01
Reviewed by Dirk Pranke.
Source/WebCore:
No new tests. It either compiles or not.
- WebCore.gyp/WebCore.gyp:
Source/WebKit/chromium:
- DEPS:
- 3:59 PM Changeset in webkit [109458] by
-
- 5 edits in trunk
Enable IPP for Biquad filter
https://bugs.webkit.org/show_bug.cgi?id=77509
Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-03-01
Reviewed by Chris Rogers.
Source/WebCore:
Use IIR filter in IPP and improve ~27% performance in linux.
Changes are covered by current tests.
- platform/audio/Biquad.cpp:
(WebCore::Biquad::Biquad):
(WebCore::Biquad::~Biquad):
(WebCore):
(WebCore::Biquad::process):
(WebCore::Biquad::reset):
(WebCore::Biquad::setLowpassParams):
(WebCore::Biquad::setHighpassParams):
(WebCore::Biquad::setNormalizedCoefficients):
(WebCore::Biquad::setZeroPolePairs):
- platform/audio/Biquad.h:
(Biquad):
LayoutTests:
Adjust a code format issue.
- webaudio/resources/biquad-testing.js:
(filterData):
- 3:52 PM Changeset in webkit [109457] by
-
- 3 edits in branches/chromium/963/Source/WebCore
Merge 109406
BUG=116405
Review URL: https://chromiumcodereview.appspot.com/9569043
- 3:46 PM Changeset in webkit [109456] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 109245
BUG=113415
Review URL: https://chromiumcodereview.appspot.com/9566040
- 3:45 PM Changeset in webkit [109455] by
-
- 1 edit1 move1 add in trunk/LayoutTests
Rebaseline fast/flexbox/010.html on Leopard after removing its suppression.
Unreviewed gardening.
- platform/chromium-mac-leopard/fast/flexbox/010-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/flexbox/010-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/flexbox/010-expected.png.
- 3:45 PM Changeset in webkit [109454] by
-
- 5 edits2 copies in branches/chromium/1025
Merge 108548
BUG=113415
Review URL: https://chromiumcodereview.appspot.com/9564039
- 3:43 PM Changeset in webkit [109453] by
-
- 10 edits2 moves8 adds5 deletes in trunk/LayoutTests
Rebaselining some old Chromium tests and removing test_expectations.
Unreviewed gardening.
- fast/writing-mode/block-level-images-expected.txt: Renamed from LayoutTests/platform/gtk/fast/writing-mode/block-level-images-expected.txt.
- platform/chromium-linux/fast/backgrounds/background-leakage-expected.png: Added.
- platform/chromium-linux/fast/backgrounds/background-leakage-transforms-expected.png: Added.
- platform/chromium-linux/fast/multicol/float-multicol-expected.png:
- platform/chromium-linux/fast/writing-mode/block-level-images-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.png:
- platform/chromium-mac-leopard/fast/backgrounds/background-leakage-transforms-expected.png: Removed.
- platform/chromium-mac-leopard/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png:
- platform/chromium-mac-leopard/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/multicol/float-multicol-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/multicol/float-multicol-expected.png.
- platform/chromium-mac-snowleopard/fast/writing-mode/block-level-images-expected.png: Added.
- platform/chromium-mac/fast/writing-mode/block-level-images-expected.png: Removed.
- platform/chromium-win/fast/backgrounds/background-leakage-expected.png: Added.
- platform/chromium-win/fast/backgrounds/background-leakage-expected.txt: Added.
- platform/chromium-win/fast/backgrounds/background-leakage-transforms-expected.png: Added.
- platform/chromium-win/fast/backgrounds/background-leakage-transforms-expected.txt: Added.
- platform/chromium-win/fast/multicol/float-multicol-expected.png:
- platform/chromium-win/fast/multicol/float-multicol-expected.txt:
- platform/chromium-win/fast/writing-mode/block-level-images-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
- platform/chromium/test_expectations.txt:
- platform/mac/fast/writing-mode/block-level-images-expected.txt: Removed.
- platform/qt/fast/writing-mode/block-level-images-expected.txt: Removed.
- 3:41 PM Changeset in webkit [109452] by
-
- 19 edits in branches/subpixellayout/Source/WebCore
Revert remaining border methods to ints for subpixel branch.
- 3:36 PM Changeset in webkit [109451] by
-
- 42 edits1 add in trunk/Source/WebCore
Decouple scrollbar painting from Scrollbar object
https://bugs.webkit.org/show_bug.cgi?id=78028
Patch by Peter Kotwicz <pkotwicz@google.com> on 2012-03-01
Reviewed by James Robinson.
Added interface ScrollbarThemeClient which Scrollbar inherits from.
This allows painting via ScrollbarTheme with a proxy to a Scrollbar
object.
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/Scrollbar.cpp:
(WebCore::Scrollbar::scrollbarOverlayStyle):
(WebCore):
(WebCore::Scrollbar::getTickmarks):
(WebCore::Scrollbar::isScrollableAreaActive):
(WebCore::Scrollbar::isScrollViewScrollbar):
(WebCore::Scrollbar::setFrameRect):
- platform/Scrollbar.h:
(Scrollbar):
(WebCore::Scrollbar::x):
(WebCore::Scrollbar::y):
(WebCore::Scrollbar::width):
(WebCore::Scrollbar::height):
(WebCore::Scrollbar::size):
(WebCore::Scrollbar::location):
(WebCore::Scrollbar::parent):
(WebCore::Scrollbar::root):
(WebCore::Scrollbar::frameRect):
(WebCore::Scrollbar::invalidate):
(WebCore::Scrollbar::convertFromContainingWindow):
(WebCore::Scrollbar::isCustomScrollbar):
(WebCore::Scrollbar::orientation):
(WebCore::Scrollbar::value):
(WebCore::Scrollbar::currentPos):
(WebCore::Scrollbar::visibleSize):
(WebCore::Scrollbar::totalSize):
(WebCore::Scrollbar::maximum):
(WebCore::Scrollbar::controlSize):
(WebCore::Scrollbar::lineStep):
(WebCore::Scrollbar::pageStep):
(WebCore::Scrollbar::pressedPart):
(WebCore::Scrollbar::hoveredPart):
(WebCore::Scrollbar::styleChanged):
(WebCore::Scrollbar::enabled):
- platform/ScrollbarTheme.h:
(WebCore):
(WebCore::ScrollbarTheme::updateEnabledState):
(WebCore::ScrollbarTheme::paint):
(WebCore::ScrollbarTheme::hitTest):
(WebCore::ScrollbarTheme::updateScrollbarOverlayStyle):
(WebCore::ScrollbarTheme::invalidateParts):
(WebCore::ScrollbarTheme::invalidatePart):
(WebCore::ScrollbarTheme::shouldCenterOnThumb):
(WebCore::ScrollbarTheme::shouldSnapBackToDragOrigin):
(WebCore::ScrollbarTheme::shouldDragDocumentInsteadOfThumb):
(WebCore::ScrollbarTheme::thumbPosition):
(WebCore::ScrollbarTheme::thumbLength):
(WebCore::ScrollbarTheme::trackPosition):
(WebCore::ScrollbarTheme::trackLength):
(WebCore::ScrollbarTheme::registerScrollbar):
(WebCore::ScrollbarTheme::unregisterScrollbar):
- platform/ScrollbarThemeClient.h: Added.
(WebCore):
(ScrollbarThemeClient):
(WebCore::ScrollbarThemeClient::~ScrollbarThemeClient):
- platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::paint):
(WebCore::ScrollbarThemeComposite::hitTest):
(WebCore::ScrollbarThemeComposite::invalidatePart):
(WebCore::ScrollbarThemeComposite::splitTrack):
(WebCore::usedTotalSize):
(WebCore::ScrollbarThemeComposite::thumbPosition):
(WebCore::ScrollbarThemeComposite::thumbLength):
(WebCore::ScrollbarThemeComposite::minimumThumbLength):
(WebCore::ScrollbarThemeComposite::trackPosition):
(WebCore::ScrollbarThemeComposite::trackLength):
- platform/ScrollbarThemeComposite.h:
(ScrollbarThemeComposite):
(WebCore::ScrollbarThemeComposite::paintScrollbarBackground):
(WebCore::ScrollbarThemeComposite::paintTrackBackground):
(WebCore::ScrollbarThemeComposite::paintTrackPiece):
(WebCore::ScrollbarThemeComposite::paintButton):
(WebCore::ScrollbarThemeComposite::paintThumb):
(WebCore::ScrollbarThemeComposite::paintTickmarks):
(WebCore::ScrollbarThemeComposite::constrainTrackRectToTrackPieces):
- platform/chromium/ScrollbarThemeChromium.cpp:
(WebCore::ScrollbarThemeChromium::hasThumb):
(WebCore::ScrollbarThemeChromium::backButtonRect):
(WebCore::ScrollbarThemeChromium::forwardButtonRect):
(WebCore::ScrollbarThemeChromium::trackRect):
(WebCore::ScrollbarThemeChromium::paintTrackBackground):
(WebCore::ScrollbarThemeChromium::paintTickmarks):
- platform/chromium/ScrollbarThemeChromium.h:
(WebCore::ScrollbarThemeChromium::hasButtons):
(ScrollbarThemeChromium):
- platform/chromium/ScrollbarThemeChromiumAndroid.cpp:
(WebCore::ScrollbarThemeChromiumAndroid::paintScrollbarBackground):
(WebCore::ScrollbarThemeChromiumAndroid::shouldCenterOnThumb):
(WebCore::ScrollbarThemeChromiumAndroid::buttonSize):
(WebCore::ScrollbarThemeChromiumAndroid::minimumThumbLength):
- platform/chromium/ScrollbarThemeChromiumAndroid.h:
(ScrollbarThemeChromiumAndroid):
- platform/chromium/ScrollbarThemeChromiumLinux.cpp:
(WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
(WebCore::ScrollbarThemeChromiumLinux::paintButton):
(WebCore::ScrollbarThemeChromiumLinux::paintThumb):
(WebCore::ScrollbarThemeChromiumLinux::shouldCenterOnThumb):
(WebCore::ScrollbarThemeChromiumLinux::buttonSize):
(WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):
- platform/chromium/ScrollbarThemeChromiumLinux.h:
(ScrollbarThemeChromiumLinux):
- platform/chromium/ScrollbarThemeChromiumMac.h:
(ScrollbarThemeChromiumMac):
- platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::scrollbarStateToThemeState):
(WebCore::ScrollbarThemeChromiumMac::paint):
(WebCore::ScrollbarThemeChromiumMac::paintGivenTickmarks):
- platform/chromium/ScrollbarThemeChromiumWin.cpp:
(WebCore::ScrollbarThemeChromiumWin::shouldSnapBackToDragOrigin):
(WebCore::ScrollbarThemeChromiumWin::paintTrackPiece):
(WebCore::ScrollbarThemeChromiumWin::paintButton):
(WebCore::ScrollbarThemeChromiumWin::paintThumb):
(WebCore::ScrollbarThemeChromiumWin::getThemeState):
(WebCore::ScrollbarThemeChromiumWin::getThemeArrowState):
(WebCore::ScrollbarThemeChromiumWin::getClassicThemeState):
(WebCore::ScrollbarThemeChromiumWin::shouldCenterOnThumb):
(WebCore::ScrollbarThemeChromiumWin::buttonSize):
- platform/chromium/ScrollbarThemeChromiumWin.h:
(ScrollbarThemeChromiumWin):
- platform/efl/ScrollbarThemeEfl.cpp:
(WebCore::ScrollbarThemeEfl::registerScrollbar):
(WebCore::ScrollbarThemeEfl::unregisterScrollbar):
- platform/efl/ScrollbarThemeEfl.h:
(ScrollbarThemeEfl):
- platform/gtk/ScrollbarThemeGtk.cpp:
(WebCore):
(WebCore::ScrollbarThemeGtk::registerScrollbar):
(WebCore::ScrollbarThemeGtk::unregisterScrollbar):
(WebCore::ScrollbarThemeGtk::updateScrollbarsFrameThickness):
(WebCore::ScrollbarThemeGtk::hasThumb):
(WebCore::ScrollbarThemeGtk::backButtonRect):
(WebCore::ScrollbarThemeGtk::forwardButtonRect):
(WebCore::ScrollbarThemeGtk::trackRect):
(WebCore::ScrollbarThemeGtk::thumbRect):
(WebCore::ScrollbarThemeGtk::paint):
(WebCore::ScrollbarThemeGtk::shouldCenterOnThumb):
(WebCore::ScrollbarThemeGtk::buttonSize):
(WebCore::ScrollbarThemeGtk::minimumThumbLength):
- platform/gtk/ScrollbarThemeGtk.h:
(WebCore::ScrollbarThemeGtk::hasButtons):
(ScrollbarThemeGtk):
- platform/gtk/ScrollbarThemeGtk2.cpp:
(WebCore::getWidgetForScrollbar):
(WebCore::ScrollbarThemeGtk::paintTrackBackground):
(WebCore::ScrollbarThemeGtk::paintScrollbarBackground):
(WebCore::ScrollbarThemeGtk::paintThumb):
(WebCore::ScrollbarThemeGtk::paintButton):
- platform/gtk/ScrollbarThemeGtk3.cpp:
(WebCore::ScrollbarThemeGtk::paintTrackBackground):
(WebCore::ScrollbarThemeGtk::paintScrollbarBackground):
(WebCore::ScrollbarThemeGtk::paintThumb):
(WebCore::ScrollbarThemeGtk::paintButton):
- platform/mac/ScrollbarThemeMac.h:
(ScrollbarThemeMac):
- platform/mac/ScrollbarThemeMac.mm:
(WebCore):
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::unregisterScrollbar):
(WebCore::ScrollbarThemeMac::setNewPainterForScrollbar):
(WebCore::ScrollbarThemeMac::painterForScrollbar):
(WebCore::ScrollbarThemeMac::updateScrollbarOverlayStyle):
(WebCore::ScrollbarThemeMac::hasButtons):
(WebCore::ScrollbarThemeMac::hasThumb):
(WebCore::ScrollbarThemeMac::backButtonRect):
(WebCore::ScrollbarThemeMac::forwardButtonRect):
(WebCore::ScrollbarThemeMac::trackRect):
(WebCore::ScrollbarThemeMac::minimumThumbLength):
(WebCore::ScrollbarThemeMac::shouldCenterOnThumb):
(WebCore::ScrollbarThemeMac::shouldDragDocumentInsteadOfThumb):
(WebCore::ScrollbarThemeMac::updateEnabledState):
(WebCore::ScrollbarThemeMac::paint):
- platform/mock/ScrollbarThemeMock.cpp:
(WebCore::ScrollbarThemeMock::trackRect):
(WebCore::ScrollbarThemeMock::paintTrackBackground):
(WebCore::ScrollbarThemeMock::paintThumb):
- platform/mock/ScrollbarThemeMock.h:
(WebCore::ScrollbarThemeMock::hasButtons):
(WebCore::ScrollbarThemeMock::hasThumb):
(WebCore::ScrollbarThemeMock::backButtonRect):
(WebCore::ScrollbarThemeMock::forwardButtonRect):
(ScrollbarThemeMock):
- platform/qt/ScrollbarThemeQt.cpp:
(WebCore::styleOptionSlider):
(WebCore::ScrollbarThemeQt::paint):
(WebCore::ScrollbarThemeQt::hitTest):
(WebCore::ScrollbarThemeQt::shouldCenterOnThumb):
(WebCore::ScrollbarThemeQt::invalidatePart):
(WebCore::ScrollbarThemeQt::thumbPosition):
(WebCore::ScrollbarThemeQt::thumbLength):
(WebCore::ScrollbarThemeQt::trackPosition):
(WebCore::ScrollbarThemeQt::trackLength):
- platform/qt/ScrollbarThemeQt.h:
(ScrollbarThemeQt):
- platform/win/ScrollbarThemeSafari.cpp:
(WebCore::ScrollbarThemeSafari::hasButtons):
(WebCore::ScrollbarThemeSafari::hasThumb):
(WebCore::ScrollbarThemeSafari::backButtonRect):
(WebCore::ScrollbarThemeSafari::forwardButtonRect):
(WebCore::ScrollbarThemeSafari::trackRect):
(WebCore::ScrollbarThemeSafari::minimumThumbLength):
(WebCore::ScrollbarThemeSafari::shouldCenterOnThumb):
(WebCore::ScrollbarThemeSafari::paintTrackBackground):
(WebCore::ScrollbarThemeSafari::paintButton):
(WebCore::ScrollbarThemeSafari::paintThumb):
- platform/win/ScrollbarThemeSafari.h:
(ScrollbarThemeSafari):
- platform/win/ScrollbarThemeWin.cpp:
(WebCore::ScrollbarThemeWin::hasThumb):
(WebCore::ScrollbarThemeWin::backButtonRect):
(WebCore::ScrollbarThemeWin::forwardButtonRect):
(WebCore::ScrollbarThemeWin::trackRect):
(WebCore::ScrollbarThemeWin::shouldCenterOnThumb):
(WebCore::ScrollbarThemeWin::shouldSnapBackToDragOrigin):
(WebCore::ScrollbarThemeWin::paintTrackBackground):
(WebCore::ScrollbarThemeWin::paintTrackPiece):
(WebCore::ScrollbarThemeWin::paintButton):
(WebCore::paintGripper):
(WebCore::ScrollbarThemeWin::paintThumb):
- platform/win/ScrollbarThemeWin.h:
(WebCore::ScrollbarThemeWin::hasButtons):
(ScrollbarThemeWin):
- platform/wx/ScrollbarThemeWx.cpp:
(WebCore::ScrollbarThemeWx::hasThumb):
(WebCore::ScrollbarThemeWx::minimumThumbLength):
(WebCore::ScrollbarThemeWx::buttonSize):
(WebCore::ScrollbarThemeWx::splitTrack):
(WebCore::ScrollbarThemeWx::backButtonRect):
(WebCore::ScrollbarThemeWx::forwardButtonRect):
(WebCore::ScrollbarThemeWx::trackRect):
(WebCore::ScrollbarThemeWx::paint):
- platform/wx/ScrollbarThemeWx.h:
(ScrollbarThemeWx):
(WebCore::ScrollbarThemeWx::hasButtons):
- rendering/RenderScrollbar.h:
(WebCore::toRenderScrollbar):
- rendering/RenderScrollbarTheme.cpp:
(WebCore::RenderScrollbarTheme::buttonSizesAlongTrackAxis):
(WebCore::RenderScrollbarTheme::hasButtons):
(WebCore::RenderScrollbarTheme::hasThumb):
(WebCore::RenderScrollbarTheme::minimumThumbLength):
(WebCore::RenderScrollbarTheme::backButtonRect):
(WebCore::RenderScrollbarTheme::forwardButtonRect):
(WebCore::RenderScrollbarTheme::trackRect):
(WebCore::RenderScrollbarTheme::constrainTrackRectToTrackPieces):
(WebCore::RenderScrollbarTheme::paintScrollbarBackground):
(WebCore::RenderScrollbarTheme::paintTrackBackground):
(WebCore::RenderScrollbarTheme::paintTrackPiece):
(WebCore::RenderScrollbarTheme::paintButton):
(WebCore::RenderScrollbarTheme::paintThumb):
- rendering/RenderScrollbarTheme.h:
(WebCore::RenderScrollbarTheme::shouldCenterOnThumb):
(WebCore::RenderScrollbarTheme::registerScrollbar):
(WebCore::RenderScrollbarTheme::unregisterScrollbar):
(RenderScrollbarTheme):
- 3:33 PM Changeset in webkit [109450] by
-
- 3 edits in trunk/Source/WebCore
Implement CSSPropertyImageRendering in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=79855
Reviewed by Eric Seidel.
No new tests / refactoring only.
- css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- 3:31 PM Changeset in webkit [109449] by
-
- 1 edit2 copies in branches/chromium/963
Merge 109245
BUG=113415
Review URL: https://chromiumcodereview.appspot.com/9570047
- 3:29 PM Changeset in webkit [109448] by
-
- 5 edits2 copies in branches/chromium/963
Merge 108548
BUG=113415
Review URL: https://chromiumcodereview.appspot.com/9562039
- 3:28 PM Changeset in webkit [109447] by
-
- 2 edits in trunk/LayoutTests
chromium: start running virtual gpu tests
https://bugs.webkit.org/show_bug.cgi?id=80050
Unreviewed, expectations change.
This patch un-SKIPs the platform/chromium/virtual/gpu tests
and copies their expectations from the GPU and generic
expectations for fast/canvas and canvas/philip. I
will re-sort the expectations in subsequent patches so
that the virtual expectations are next to the action ones,
for easier maintenance.
- platform/chromium/test_expectations.txt:
- 3:23 PM Changeset in webkit [109446] by
-
- 2 edits in trunk/LayoutTests
Mark fast/workers/stress-js-execution.html as flakily crashy on cr-win.
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 3:21 PM Changeset in webkit [109445] by
-
- 2 edits in trunk/Source/WebKit/chromium
Roll chromium DEPS to 124511
Unreviewed, DEPS change.
- DEPS:
- 3:20 PM Changeset in webkit [109444] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 109369
BUG=116224
Review URL: https://chromiumcodereview.appspot.com/9565031
- 3:17 PM Changeset in webkit [109443] by
-
- 1 edit2 copies in branches/chromium/963
Merge 109369
BUG=116224
Review URL: https://chromiumcodereview.appspot.com/9570045
- 3:17 PM Changeset in webkit [109442] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Partial texture updates not happening with accelerated painting path
https://bugs.webkit.org/show_bug.cgi?id=80040
Reviewed by James Robinson.
The order of y-flip and clip-rect was opposite of what it should be.
The clip rect was not properly transformed to account for y-flip and hence clipping everything.
- platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):
- 3:16 PM Changeset in webkit [109441] by
-
- 2 edits in trunk/LayoutTests
Remove outdated (mostly mac) test suppressions.
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 3:12 PM Changeset in webkit [109440] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 109142
BUG=113801
Review URL: https://chromiumcodereview.appspot.com/9570043
- 3:10 PM Changeset in webkit [109439] by
-
- 1 edit2 copies in branches/chromium/963
Merge 109142
BUG=113801
Review URL: https://chromiumcodereview.appspot.com/9566037
- 2:58 PM Changeset in webkit [109438] by
-
- 2 edits in branches/subpixellayout/Source/WebCore/rendering
Cleaning up some InlineFlowBox cruft and using static casts instead of explicit wrapping.
- 2:57 PM Changeset in webkit [109437] by
-
- 1 edit3 copies in branches/chromium/1025
Merge 109140
BUG=115028
Review URL: https://chromiumcodereview.appspot.com/9570040
- 2:56 PM Changeset in webkit [109436] by
-
- 1 edit3 copies in branches/chromium/963
Merge 109140
BUG=115028
Review URL: https://chromiumcodereview.appspot.com/9570038
- 2:50 PM Changeset in webkit [109435] by
-
- 2 edits in trunk/Source/WebCore
FileReader read speed is way too low
https://bugs.webkit.org/show_bug.cgi?id=77272
Reviewed by Oliver Hunt.
This brings performance to reasonable range, but certainly doesn't exhaust improvement opportunities.
- platform/network/BlobResourceHandle.cpp: Use a more appropriate block size. Performing cross-thread messaging for every 1024 bytes is slow.
- 2:48 PM Changeset in webkit [109434] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 109124
BUG=116027
Review URL: https://chromiumcodereview.appspot.com/9578001
- 2:48 PM Changeset in webkit [109433] by
-
- 2 edits in trunk/LayoutTests
Mark svg/W3C-SVG-1.1/animate-elem-32-t.svg as debug/crash after r109342.
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 2:47 PM Changeset in webkit [109432] by
-
- 1 edit2 copies in branches/chromium/963
Merge 109124
BUG=116027
Review URL: https://chromiumcodereview.appspot.com/9573003
- 2:42 PM Changeset in webkit [109431] by
-
- 2 edits in trunk/Source/WebCore
ScrollView::setFrameRect() calls contentsResized() even when the frame size is unchanged
https://bugs.webkit.org/show_bug.cgi?id=80047
Reviewed by Anders Carlsson.
- platform/ScrollView.cpp:
(WebCore::ScrollView::setFrameRect): Added a check that the new frame size differs from the
old one before calling contentsResized().
- 2:41 PM Changeset in webkit [109430] by
-
- 2 edits in trunk/Source/WebKit/blackberry
Autocomplete attribute should apply to textarea's.
https://bugs.webkit.org/show_bug.cgi?id=79929
Patch by Mike Fenton <mifenton@rim.com> on 2012-03-01
Reviewed by Antonio Gomes.
Add local static Qualified name for autocorrect attribute.
- WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::elementSupportsAutocorrect):
- 2:41 PM Changeset in webkit [109429] by
-
- 5 edits in trunk/Tools
nrwt: test_isfile, test_isdir, and test_exists don't work for virtual tests
https://bugs.webkit.org/show_bug.cgi?id=80048
Reviewed by Adam Barth.
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.test_isfile):
(Port.test_isdir):
(Port):
(Port.test_exists):
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_test_exists):
(PortTest):
(PortTest.test_test_isfile):
(PortTest.test_test_isdir):
- Scripts/webkitpy/layout_tests/port/test.py:
(TestPort.virtual_test_suites):
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_virtual):
- 2:41 PM Changeset in webkit [109428] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 109011
BUG=114144
Review URL: https://chromiumcodereview.appspot.com/9565029
- 2:39 PM Changeset in webkit [109427] by
-
- 1 edit2 copies in branches/chromium/963
Merge 109011
BUG=114144
Review URL: https://chromiumcodereview.appspot.com/9566033
- 2:30 PM Changeset in webkit [109426] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 108875
BUG=113800
Review URL: https://chromiumcodereview.appspot.com/9569037
- 2:28 PM Changeset in webkit [109425] by
-
- 1 edit2 copies in branches/chromium/963
Merge 108875
BUG=113800
Review URL: https://chromiumcodereview.appspot.com/9569036
- 2:24 PM Changeset in webkit [109424] by
-
- 5 edits in trunk/Source/WebCore
[chromium] Move pageScaleDirty logic from LayerChromium to GraphicsLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=79714
Patch by James Robinson <jamesr@chromium.org> on 2012-03-01
Reviewed by Adrienne Walker.
When the page scale changes on a composited layer we need to invalidate all of the contents on the layer in
order to repaint them at the new scale. The sequence of calls we get make this a bit tricky, since we first
receive a page scale changed notification and then receive the new layer bounds. The solution is to defer the
invalidation until we have the new layer bounds, which landed in r99774.
This moves that logic from LayerChromium into GraphicsLayerChromium since IMO this is pretty particular to the
way WebCore is passing us invalidations and not something fundamental to the compositor.
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::setSize):
(WebCore::GraphicsLayerChromium::deviceOrPageScaleFactorChanged):
- platform/graphics/chromium/GraphicsLayerChromium.h:
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setBounds):
- platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
- 2:14 PM Changeset in webkit [109423] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 108847
BUG=115681
Review URL: https://chromiumcodereview.appspot.com/9569034
- 2:13 PM Changeset in webkit [109422] by
-
- 1 edit2 copies in branches/chromium/963
Merge 108847
BUG=115681
Review URL: https://chromiumcodereview.appspot.com/9567024
- 2:07 PM Changeset in webkit [109421] by
-
- 1 edit7 copies in branches/chromium/1025
Merge 108543
BUG=113497
Review URL: https://chromiumcodereview.appspot.com/9564028
- 2:07 PM Changeset in webkit [109420] by
-
- 2 edits in trunk/LayoutTests
Remove lots of bogus flaky test suppressions, mark some others
as always failing and some others for rebaselining.
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 2:04 PM Changeset in webkit [109419] by
-
- 1 edit7 copies in branches/chromium/963
Merge 108543
BUG=113497
Review URL: https://chromiumcodereview.appspot.com/9562030
- 1:55 PM Changeset in webkit [109418] by
-
- 6 edits in trunk
Perf-o-matic: generate dashboard images for 30, 90, and 365 days
https://bugs.webkit.org/show_bug.cgi?id=80016
Reviewed by Eric Seidel.
Add the ability to generate graphs for 30, 90, and 365 day graphs but only occasionally
according to the heuristics in DashboardImage.needs_update.
Also fix a bug in Runs.chart_params that y-axis grid was set to an incorrect value.
- Websites/webkit-perf.appspot.com/controller.py:
(schedule_runs_update):
(RunsChartHandler.post):
- Websites/webkit-perf.appspot.com/json_generators.py:
(Runs.chart_params):
- Websites/webkit-perf.appspot.com/json_generators_unittest.py:
(RunsTest.test_chart_params_with_value):
- Websites/webkit-perf.appspot.com/models.py:
(DashboardImage):
(DashboardImage.needs_update):
- Websites/webkit-perf.appspot.com/models_unittest.py:
(HelperTests._assert_there_is_exactly_one_id_holder_and_matches):
(HelperTests.test_create_in_transaction_with_numeric_id_holder.execute):
(HelperTests.test_create_in_transaction_with_numeric_id_holder):
(HelperTests.test_failing_in_create_in_transaction_with_numeric_id_holder):
(HelperTests.test_raising_in_create_in_transaction_with_numeric_id_holder):
(HelperTests.test_delete_model_with_numeric_id_holder.execute):
(HelperTests.test_delete_model_with_numeric_id_holder):
(HelperTests.test_model_from_numeric_id.execute):
(HelperTests):
(HelperTests.test_model_from_numeric_id):
(BranchTests.test_create_if_possible):
(PlatformTests.test_create_if_possible):
(BuilderTests.test_create):
(BuilderTests.test_update_password):
(BuilderTests.test_hashed_password):
(BuilderTests.test_authenticate):
(_create_some_builder):
(_create_build):
(BuildTests.test_get_or_insert_from_log):
(TestModelTests.test_update_or_insert):
(TestModelTests.test_update_or_insert_to_update):
(TestModelTests.test_merge):
(TestResultTests.test_get_or_insert_value):
(TestResultTests.test_get_or_insert_stat_value):
(TestResultTests.test_replace_to_change_test_name):
(TestResultTests.test_replace_to_change_test_name_with_stat_value):
(TestResultTests.test_replace_to_change_test_name_overrides_conflicting_result):
(ReportLogTests._create_log_with_payload):
(ReportLogTests.test_builder):
(ReportLogTests.test_branch):
(ReportLogTests.test_platform):
(PersistentCacheTests._assert_persistent_cache):
(PersistentCacheTests.test_set):
(PersistentCacheTests.test_get):
(DashboardImageTests):
(DashboardImageTests.test_needs_update):
- 1:53 PM Changeset in webkit [109417] by
-
- 3 edits2 adds in trunk
:empty still applies to elements made non-empty via page dynamics.
https://bugs.webkit.org/show_bug.cgi?id=79734
Check for :empty style change should be made even if the RenderStyle for the element is NULL
as changes to the element's children can trigger a change in :empty state of the parent element.
Patch by Joe Thomas <joethomas@motorola.com> on 2012-03-01
Reviewed by Antti Koivisto.
Source/WebCore:
Test: fast/selectors/empty-element-made-non-empty.html
- dom/Element.cpp:
(WebCore::checkForSiblingStyleChanges):
LayoutTests:
- fast/selectors/empty-element-made-non-empty-expected.txt: Added.
- fast/selectors/empty-element-made-non-empty.html: Added.
- 1:52 PM Changeset in webkit [109416] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 108194
BUG=114924
Review URL: https://chromiumcodereview.appspot.com/9562027
- 1:51 PM Changeset in webkit [109415] by
-
- 3 edits in trunk/Source/WebKit2
[Qt][WK2] Make the interaction with the Flickable work on the N9
https://bugs.webkit.org/show_bug.cgi?id=80029
Reviewed by Simon Hausmann.
Because the WebView item accepts all touch events it receives and sends
them to the web process before propagating them to the gesture recognizers,
which is correct behaviour, we can not rely on the touch->mouse conversion
of Qt5 when controlling Flickable. Hence we need to convert the received
touch events to mouse events in the QtFlickProvider.
- UIProcess/qt/QtFlickProvider.cpp:
(QtFlickProvider::handleTouchFlickEvent):
Do the touch to mouse event conversion for the Flickable.
- UIProcess/qt/QtPanGestureRecognizer.cpp:
(WebKit::QtPanGestureRecognizer::recognize):
A touch begin event should cancel the previous pan gesture
and stop the ongoing flick animation.
- 1:50 PM Changeset in webkit [109414] by
-
- 1 edit2 copies in branches/chromium/963
Merge 108194
BUG=114924
Review URL: https://chromiumcodereview.appspot.com/9568037
- 1:46 PM Changeset in webkit [109413] by
-
- 2 edits6 copies in branches/chromium/1025
Merge 108606
BUG=113439
Review URL: https://chromiumcodereview.appspot.com/9568036
- 1:43 PM Changeset in webkit [109412] by
-
- 4 edits in tags/Safari-536.1/Source
Versioning.
- 1:42 PM Changeset in webkit [109411] by
-
- 14 edits in trunk/Source
[chromium] Move context lost control code from CCSingleThreadProxy to CCLayerTreeHost
https://bugs.webkit.org/show_bug.cgi?id=79964
Reviewed by James Robinson.
Source/WebCore:
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initializeLayerRenderer):
(WebCore::CCLayerTreeHost::recreateContext):
(WebCore::CCLayerTreeHost::createContext):
(WebCore::CCLayerTreeHost::didLoseContext):
(WebCore::CCLayerTreeHost::compositeAndReadback):
(WebCore::CCLayerTreeHost::loseContext):
(WebCore::CCLayerTreeHost::updateLayers):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHostClient):
(CCLayerTreeHost):
- platform/graphics/chromium/cc/CCProxy.h:
(CCProxy):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::CCSingleThreadProxy):
(WebCore::CCSingleThreadProxy::compositeAndReadback):
(WebCore::CCSingleThreadProxy::initializeContext):
(WebCore::CCSingleThreadProxy::recreateContext):
(WebCore):
(WebCore::CCSingleThreadProxy::loseContext):
(WebCore::CCSingleThreadProxy::compositeImmediately):
(WebCore::CCSingleThreadProxy::doComposite):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(CCSingleThreadProxy):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::initializeContext):
(WebCore::CCThreadProxy::recreateContext):
(WebCore):
(WebCore::CCThreadProxy::loseContext):
- platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
Source/WebKit/chromium:
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::loseCompositorContext):
- src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewImpl::createContext):
(WebKit::WebLayerTreeViewImpl::didRecreateContext):
- src/WebLayerTreeViewImpl.h:
(WebLayerTreeViewImpl):
- tests/CCLayerTreeHostTest.cpp:
(WTF::MockLayerTreeHostClient::createContext):
(WTF::MockLayerTreeHostClient::didRecreateContext):
- tests/FakeCCLayerTreeHostClient.h:
(WebCore::FakeCCLayerTreeHostClient::createContext):
(WebCore::FakeCCLayerTreeHostClient::didRecreateContext):
- 1:39 PM Changeset in webkit [109410] by
-
- 1 copy in tags/Safari-536.1
New Tag.
- 1:35 PM Changeset in webkit [109409] by
-
- 4 edits in trunk/Source
Versioning.
- 1:33 PM Changeset in webkit [109408] by
-
- 4 edits12 copies in branches/chromium/1025
Merge 108127
BUG=113439
Review URL: https://chromiumcodereview.appspot.com/9562026
- 1:31 PM Changeset in webkit [109407] by
-
- 2 edits6 copies in branches/chromium/963
Merge 108606
BUG=113439
Review URL: https://chromiumcodereview.appspot.com/9566030
- 1:27 PM Changeset in webkit [109406] by
-
- 4 edits in trunk/Source/WebCore
Prevent layout root to remain set on renderers getting destroyed.
https://bugs.webkit.org/show_bug.cgi?id=79953
Reviewed by Eric Seidel.
Implement Julien Chaffraix's idea.
- page/FrameView.h:
(WebCore::FrameView::clearLayoutRoot): helper to clear layout root.
- rendering/RenderObject.cpp:
(WebCore::clearLayoutRootIfNeeded): if we know we are going
away and we are the view's layout root, then we need to reset the layout
root to prevent being used.
(WebCore):
(WebCore::RenderObject::willBeDestroyed): call clearLayoutRootIfNeeded at end.
- 1:26 PM Changeset in webkit [109405] by
-
- 3 edits in trunk/Source/WebKit2
Assertion failure in pageContainsAnyHorizontalScrollbars() (scrollableArea->isOnActivePage()) when leaving pages with embedded PDFs
https://bugs.webkit.org/show_bug.cgi?id=80044
<rdar://problem/10919940>
Reviewed by Brady Eidson.
Remove the code that would add and remove wheel event handlers since that's not what we want to track.
Instead, dynamically add and remove the view as its scrollbars come and go.
- WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
(WebKit::BuiltInPDFView::updateScrollbars):
(WebKit::BuiltInPDFView::initialize):
- WebProcess/Plugins/PDF/BuiltInPDFView.h:
(BuiltInPDFView):
- 1:16 PM Changeset in webkit [109404] by
-
- 4 edits12 copies in branches/chromium/963
Merge 108127
BUG=113439
Review URL: https://chromiumcodereview.appspot.com/9568032
- 12:56 PM Changeset in webkit [109403] by
-
- 1 edit3 copies in branches/chromium/1025
Merge 108109
BUG=113707
Review URL: https://chromiumcodereview.appspot.com/9562024
- 12:55 PM Changeset in webkit [109402] by
-
- 12 edits in trunk
[DRT] Remove all PlainTextController usages in existing tests by adding internal API
https://bugs.webkit.org/show_bug.cgi?id=78570
Patch by Kangil Han <kangil.han@samsung.com> on 2012-03-01
Reviewed by Hajime Morita.
This patch will remove all PlainTextController usages
in existing DRT tests by adding internal API to WebCore/testing/Internals
.:
- Source/autotools/symbols.filter:
Source/WebCore:
Changed editing/text-iterator/script-tests/basic-iteration.js to use internals.rangeAsText
- testing/Internals.cpp:
(WebCore::Internals::rangeAsText):
(WebCore):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Source/WebKit2:
- win/WebKit2.def:
- win/WebKit2CFLite.def:
LayoutTests:
- editing/text-iterator/basic-iteration-expected.txt:
- editing/text-iterator/script-tests/basic-iteration.js:
- 12:54 PM Changeset in webkit [109401] by
-
- 1 edit3 copies in branches/chromium/963
Merge 108109
BUG=113707
Review URL: https://chromiumcodereview.appspot.com/9565026
- 12:50 PM Changeset in webkit [109400] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 107987
BUG=113799
Review URL: https://chromiumcodereview.appspot.com/9562023
- 12:49 PM Changeset in webkit [109399] by
-
- 1 edit2 copies in branches/chromium/963
Merge 107987
BUG=113799
Review URL: https://chromiumcodereview.appspot.com/9569026
- 12:45 PM Changeset in webkit [109398] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 107627
BUG=113690
Review URL: https://chromiumcodereview.appspot.com/9570026
- 12:44 PM WebKitGTK/1.8.x edited by
- Added 109396 as proposed merge (diff)
- 12:43 PM Changeset in webkit [109397] by
-
- 2 edits in trunk/LayoutTests
Rebaseline to remove quotes around font name after r109382.
Unreviewed gardening.
- editing/inserting/5994480-2-expected.txt:
- 12:37 PM Changeset in webkit [109396] by
-
- 2 edits in trunk/Tools
[GTK] Avoid building any parts of WebKitTestRunner when WK2 is disabled
https://bugs.webkit.org/show_bug.cgi?id=80031
Patch by Kalev Lember <kalevlember@gmail.com> on 2012-03-01
Reviewed by Gustavo Noronha Silva.
Only build the libTestRunnerInjectedBundle.la convenience library when
ENABLE_WEBKIT2 is defined.
- WebKitTestRunner/GNUmakefile.am:
- 12:36 PM Changeset in webkit [109395] by
-
- 1 edit2 copies in branches/chromium/963
Merge 107627
BUG=113690
Review URL: https://chromiumcodereview.appspot.com/9566026
- 12:35 PM Changeset in webkit [109394] by
-
- 2 edits in trunk/LayoutTests
Remove expectations for no-longer-flaky tests on Snow Leopard.
https://bugs.webkit.org/show_bug.cgi?id=54322
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 12:32 PM Changeset in webkit [109393] by
-
- 2 edits in trunk/Tools
Unreviewed, second attempt to fix GTK NRWT after r109242.
- Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkDriver._start):
- 12:29 PM Changeset in webkit [109392] by
-
- 5 edits in trunk/Source/WebCore
DOMWindow shouldn't have any INDEXED_DATABASE ifdefs
https://bugs.webkit.org/show_bug.cgi?id=80013
Reviewed by Kentaro Hara.
Before this patch, DOMWindow still knew about IDB because of the
database factory. This patch moves the factory to
DOMWindowIndexedDatabase.
- Modules/indexeddb/DOMWindowIndexedDatabase.cpp:
(WebCore::DOMWindowIndexedDatabase::DOMWindowIndexedDatabase):
(WebCore::DOMWindowIndexedDatabase::from):
(WebCore):
(WebCore::DOMWindowIndexedDatabase::disconnectFrame):
(WebCore::DOMWindowIndexedDatabase::webkitIndexedDB):
- Modules/indexeddb/DOMWindowIndexedDatabase.h:
(DOMWindowIndexedDatabase):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::clear):
(WebCore):
- page/DOMWindow.h:
(DOMWindow):
- 12:29 PM Changeset in webkit [109391] by
-
- 1 edit3 copies in branches/chromium/1025
Merge 109345
BUG=116093
Review URL: https://chromiumcodereview.appspot.com/9562022
- 12:28 PM Changeset in webkit [109390] by
-
- 1 edit3 copies in branches/chromium/963
Merge 109345
BUG=116093
Review URL: https://chromiumcodereview.appspot.com/9568029
- 12:20 PM Changeset in webkit [109389] by
-
- 5 edits in branches/subpixellayout/Source/WebCore/rendering
Cleaning up RenderBox. Removing unneeded integer flipForWritingMode functions.
- 12:15 PM Changeset in webkit [109388] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 108372
BUG=114219
Review URL: https://chromiumcodereview.appspot.com/9569024
- 12:13 PM Changeset in webkit [109387] by
-
- 1 edit2 copies in branches/chromium/963
Merge 108372
BUG=114219
Review URL: https://chromiumcodereview.appspot.com/9567020
- 12:04 PM Changeset in webkit [109386] by
-
- 3 edits in trunk/Source/WebCore
Glitchy scrolling on pages where the scroll layer needs to be updated on the main thread
https://bugs.webkit.org/show_bug.cgi?id=80038
<rdar://problem/10933831>
Reviewed by Simon Fraser.
When we need to update the scroll layer position on the main thread, we need to cache the
scroll position we sent to the main thread and assume that that's the correct scroll position.
- page/scrolling/mac/ScrollingTreeNodeMac.h:
(ScrollingTreeNodeMac):
- page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::update):
(WebCore::ScrollingTreeNodeMac::setScrollPosition):
(WebCore::ScrollingTreeNodeMac::scrollPosition):
- 12:01 PM Changeset in webkit [109385] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 108417
BUG=114054
Review URL: https://chromiumcodereview.appspot.com/9566023
- 12:00 PM Changeset in webkit [109384] by
-
- 1 edit2 copies in branches/chromium/963
Merge 108417
BUG=114054
Review URL: https://chromiumcodereview.appspot.com/9568027
- 11:58 AM Changeset in webkit [109383] by
-
- 17 edits in trunk
Unreviewed, rolling out r109367.
http://trac.webkit.org/changeset/109367
https://bugs.webkit.org/show_bug.cgi?id=75568
Some tests started to fail in a non obvious way.
Source/WebCore:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateScrollInfoAfterLayout):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::paint):
(WebCore::RenderBlock::isPointInOverflowControl):
- rendering/RenderBlock.h:
(RenderBlock):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::willBeDestroyed):
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::scrollHeight):
(WebCore::RenderBox::scrollLeft):
(WebCore::RenderBox::scrollTop):
(WebCore::RenderBox::setScrollLeft):
(WebCore::RenderBox::setScrollTop):
(WebCore::RenderBox::includeVerticalScrollbarSize):
(WebCore::RenderBox::includeHorizontalScrollbarSize):
(WebCore::RenderBox::scrolledContentOffset):
(WebCore::RenderBox::cachedSizeForOverflowClip):
(WebCore::RenderBox::pushContentsClip):
(WebCore::RenderBox::popContentsClip):
(WebCore::RenderBox::addLayoutOverflow):
- rendering/RenderBox.h:
(RenderBox):
(WebCore):
- rendering/RenderBoxModelObject.cpp:
(WebCore):
(WebCore::RenderBoxModelObject::styleDidChange):
- rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::requiresLayer):
(RenderBoxModelObject):
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
- rendering/RenderTableRow.h:
(WebCore::RenderTableRow::requiresLayer):
LayoutTests:
- platform/chromium-win/fast/repaint/iframe-scroll-repaint-expected.png:
- platform/chromium/test_expectations.txt:
- platform/efl/test_expectations.txt:
- platform/gtk/test_expectations.txt:
- platform/mac/test_expectations.txt:
- platform/qt/test_expectations.txt:
- platform/win/Skipped:
- 11:47 AM Changeset in webkit [109382] by
-
- 3 edits2 adds in trunk
REGRESSION: Outlook 2007 doesn't display fonts correctly on emails composed by WebKit
https://bugs.webkit.org/show_bug.cgi?id=79448
Reviewed by Ryosuke Niwa.
Source/WebCore:
Don't produce single quotes around face attribute of font elements.
Test: editing/style/font-face-unquote.html
- editing/EditingStyle.cpp:
(WebCore::StyleChange::extractTextStyles): Remove single quotes from m_applyFontFace.
LayoutTests:
Add a test that makes sure WebKit doesn't produce single quotes around
face attribute of font element.
- editing/style/font-face-unquote-expected.txt: Added.
- editing/style/font-face-unquote.html: Added.
- 11:40 AM Changeset in webkit [109381] by
-
- 2 edits2 copies in branches/chromium/1025
Merge 107613
BUG=113258
Review URL: https://chromiumcodereview.appspot.com/9562018
- 11:38 AM Changeset in webkit [109380] by
-
- 2 edits2 copies in branches/chromium/963
Merge 107613
BUG=116224
Review URL: https://chromiumcodereview.appspot.com/9568025
- 11:36 AM Changeset in webkit [109379] by
-
- 2 edits in trunk/Source/WebCore
Reviewed by Kevin Decker.
Part of https://bugs.webkit.org/show_bug.cgi?id=79705
Here's some of that tweaking promised in the comment. Adjusting
gMaximumUnpaintedAreaRatio down a bit.
- page/Page.cpp:
(WebCore):
- 11:33 AM Changeset in webkit [109378] by
-
- 13 edits in trunk/Source/WebCore
Add roundToInt method for LayoutUnits
https://bugs.webkit.org/show_bug.cgi?id=79283
Reviewed by Eric Seidel.
Adding a roundToInt method that rounds a LayoutUnit to the nearest integer. This
only has an effect once we switch to sub-pixel positioning. Points and offsets
are rounded for painting and hit testing.
No new tests. No change in behavior.
- dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::offsetX):
(WebCore::MouseRelatedEvent::offsetY):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateSizes):
- rendering/LayoutState.cpp:
(WebCore::LayoutState::computeLineGridPaginationOrigin):
- rendering/LayoutTypes.h:
(WebCore::roundToInt): Stub until we switch to sub-pixel LayoutUnits.
(WebCore):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::pageLogicalTopForOffset):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::pixelSnappedLogicalLeftOffsetForLine): Correcting to use the
pixel snapped methods on FloatingObjects and removing the fixme.
(WebCore::RenderBlock::pixelSnappedLogicalTopForFloat): Ditto.
(WebCore::RenderBlock::pixelSnappedLogicalBottomForFloat): Ditto.
(WebCore::RenderBlock::pixelSnappedLogicalLeftForFloat): Ditto.
(WebCore::RenderBlock::pixelSnappedLogicalRightForFloat): Ditto.
(WebCore::RenderBlock::pixelSnappedLogicalWidthForFloat): Ditto.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::updateAvailableWidth):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Using
pixelSnappedLogicalLeft/RightOffsetForLine convenience methods for line layout. When
we switch to sub-pixel positioning, we still pixel snap blocks before painting them,
but text is rendered using floats. We need to ensure the text is laid out using the
actual pixel width of the containing block to avoid bleeding out of the block.
- rendering/RenderBoxModelObject.h: Moving the fixme to pixelSnappedWidth/Height and
adding the necessary rounding for Left/Top.
(WebCore::RenderBoxModelObject::pixelSnappedOffsetLeft):
(WebCore::RenderBoxModelObject::pixelSnappedOffsetTop):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollRectToVisible):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::scrollHeight): Rounding the height for scrollHeight. Scrolling
always uses rounded values.
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::localToParentTransform): Similar to the line box tree, since
SVG renders using floats, we need to start with pixel snapped values from the render
tree or we'll end up with the contents not properly aligned to the rest of the page.
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::prepareToRenderSVGContent):
- 11:26 AM Changeset in webkit [109377] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 107729
BUG=113562
Review URL: https://chromiumcodereview.appspot.com/9570024
- 11:24 AM Changeset in webkit [109376] by
-
- 1 edit2 copies in branches/chromium/963
Merge 107729
BUG=113562
Review URL: https://chromiumcodereview.appspot.com/9568024
- 11:22 AM Changeset in webkit [109375] by
-
- 2 edits in trunk/LayoutTests
Mark use-same-database-in-page-and-workers.html as a TEXT failure.
Requested by dslomov on #webkit.
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 11:18 AM Changeset in webkit [109374] by
-
- 2 edits in branches/chromium/1025
Merge 108311
BUG=114911
Review URL: https://chromiumcodereview.appspot.com/9566019
- 11:14 AM Changeset in webkit [109373] by
-
- 2 edits in branches/chromium/963
Merge 108311
BUG=114911
Review URL: https://chromiumcodereview.appspot.com/9568022
- 11:12 AM Changeset in webkit [109372] by
-
- 8 edits2 adds in trunk
2012-03-01 Pavel Feldman <pfeldman@chromium.org>
Web Inspector: arrays in object properties sections do not scale.
https://bugs.webkit.org/show_bug.cgi?id=64596
Reviewed by Vsevolod Vlasov.
Test: inspector/console/console-big-array.html
- inspector/front-end/ConsoleMessage.js: (WebInspector.ConsoleMessageImpl.prototype._formatParameterAsArray): (WebInspector.ConsoleMessageImpl.prototype._printArray):
- inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertiesSection.prototype.updateProperties): (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate.callback): (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): (WebInspector.ObjectPropertyTreeElement.prototype.startEditing): (WebInspector.ArrayGroupingTreeElement): (WebInspector.ArrayGroupingTreeElement.populateAsArray): (WebInspector.ArrayGroupingTreeElement._populate.appendElement): (WebInspector.ArrayGroupingTreeElement._populate): (WebInspector.ArrayGroupingTreeElement.prototype.onpopulate):
- inspector/front-end/RemoteObject.js: (WebInspector.RemoteObject.prototype.release): (WebInspector.RemoteObject.prototype.arrayLength): (WebInspector.LocalJSONObject.prototype.isError): (WebInspector.LocalJSONObject.prototype.arrayLength):
- inspector/front-end/ScopeChainSidebarPane.js: (WebInspector.ScopeVariableTreeElement.prototype.get propertyPath):
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype._mouseDown):
- inspector/front-end/inspector.css: (.console-formatted-object, .console-formatted-node, .console-formatted-array): (.console-formatted-object .section, .console-formatted-node .section, .console-formatted-array .section):
2012-03-01 Pavel Feldman <pfeldman@chromium.org>
Web Inspector: arrays in object properties sections do not scale.
https://bugs.webkit.org/show_bug.cgi?id=64596
Reviewed by Vsevolod Vlasov.
- inspector/console/console-big-array-expected.txt: Added.
- inspector/console/console-big-array.html: Added.
- 11:05 AM Changeset in webkit [109371] by
-
- 1 edit2 deletes in branches/chromium/963
Revert 109368 - Merge 107761
BUG=112775
Review URL: https://chromiumcodereview.appspot.com/9564016
TBR=cevans@google.com
Review URL: https://chromiumcodereview.appspot.com/9565017
- 11:01 AM Changeset in webkit [109370] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed, rolling out r109336.
http://trac.webkit.org/changeset/109336
https://bugs.webkit.org/show_bug.cgi?id=80013
It's causing some crashes
- Modules/indexeddb/DOMWindowIndexedDatabase.cpp:
(WebCore::DOMWindowIndexedDatabase::DOMWindowIndexedDatabase):
(WebCore::DOMWindowIndexedDatabase::webkitIndexedDB):
- Modules/indexeddb/DOMWindowIndexedDatabase.h:
(DOMWindowIndexedDatabase):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::clear):
(WebCore):
(WebCore::DOMWindow::setIDBFactory):
- page/DOMWindow.h:
(DOMWindow):
(WebCore::DOMWindow::idbFactory):
- 10:57 AM Changeset in webkit [109369] by
-
- 3 edits2 adds in trunk
Move m_frame protector from FrameLoader::changeLocation to FrameLoader::urlSelected
https://bugs.webkit.org/show_bug.cgi?id=79882
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/frames/url-selected-crash.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::changeLocation):
(WebCore::FrameLoader::urlSelected):
LayoutTests:
- fast/frames/url-selected-crash-expected.txt: Added.
- fast/frames/url-selected-crash.html: Added.
- 10:56 AM Changeset in webkit [109368] by
-
- 1 edit2 copies in branches/chromium/963
Merge 107761
BUG=112775
Review URL: https://chromiumcodereview.appspot.com/9564016
- 10:46 AM Changeset in webkit [109367] by
-
- 17 edits in trunk
Lazily allocate overflow: hidden layers if we have overflowing content
https://bugs.webkit.org/show_bug.cgi?id=75568
Reviewed by David Hyatt.
Source/WebCore:
Change covered by the existing tests and the tons of rebaselines.
This change makes us lazily allocate our RenderLayer for overflow: hidden layers only.
Apart from saving some memory, it will also speed up the rendering as we don't need to
go through the layer's machinery when painting and hit testing.
On http://dglazkov.github.com/performance-tests/biggrid.html benchmark, this puts the
overflow: hidden case in par with the overflow: visible case when scrolling that is a
very-smooth scrolling vs a jerky one currently (mostly due to the painting speedup).
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateScrollInfoAfterLayout):
Changed this method to update our size cache if needed.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::paint):
(WebCore::RenderBlock::isPointInOverflowControl):
- rendering/RenderBlock.h:
(RenderBlock):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::scrollHeight):
(WebCore::RenderBox::scrollLeft):
(WebCore::RenderBox::scrollTop):
(WebCore::RenderBox::setScrollLeft):
(WebCore::RenderBox::setScrollTop):
(WebCore::RenderBox::includeVerticalScrollbarSize):
(WebCore::RenderBox::includeHorizontalScrollbarSize):
(WebCore::RenderBox::pushContentsClip):
(WebCore::RenderBox::popContentsClip):
(WebCore::RenderBox::addLayoutOverflow):
Added layer() check to the previous call sites.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::ensureLayer):
Added this function to create and add a new layer.
(WebCore::RenderBoxModelObject::willBeDestroyed):
(WebCore):
(WebCore::RenderBoxModelObject::styleDidChange):
Patched those method to handle updating / removing
cached size entries.
(WebCore::cachedSizeForOverflowClipMap):
(WebCore::RenderBoxModelObject::cachedSizeForOverflowClip):
(WebCore::RenderBoxModelObject::updateCachedSizeForOverflowClip):
(WebCore::RenderBoxModelObject::clearCachedSizeForOverflowClip):
This logic stores the size information for later repainting.
It is in practice replicating what RenderLayer is doing.
- rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::requiresLayer):
Updated to call requiresLayerForOverflowClip.
(WebCore::RenderBoxModelObject::requiresLayerForOverflowClip):
Added this method to check if we can lazily allocate the layer.
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
Removed some checks as they are part of updateScrollInfoAfterLayout.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::scrolledContentOffset):
Added a layer() check.
- rendering/RenderTableRow.h:
(RenderTableRow):
Added a comment about why we need a layout for table rows.
LayoutTests:
- platform/chromium-win/fast/repaint/iframe-scroll-repaint-expected.png:
This test really doesn't seem to test much on all platforms. The new expected result is as
good as the original from a correctness perspective. It just means we now do repaint the whole
iframe when scrolling.
- platform/chromium/test_expectations.txt:
- platform/efl/test_expectations.txt:
- platform/gtk/test_expectations.txt:
- platform/mac/test_expectations.txt:
- platform/qt/test_expectations.txt:
- platform/win/Skipped:
Disable gazillions tests that need a small rebaseline after losing some layers. The expectations are
updated to match each platform as best as I could but expect some breakage...
- 10:45 AM Changeset in webkit [109366] by
-
- 4 edits2 copies in branches/chromium/1025
Merge 108009
BUG=112542
Review URL: https://chromiumcodereview.appspot.com/9567016
- 10:43 AM Changeset in webkit [109365] by
-
- 4 edits2 copies in branches/chromium/963
Merge 108009
BUG=112542
Review URL: https://chromiumcodereview.appspot.com/9567015
- 10:26 AM Changeset in webkit [109364] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 107749
BUG=111748
Review URL: https://chromiumcodereview.appspot.com/9568019
- 10:24 AM Changeset in webkit [109363] by
-
- 1 edit2 copies in branches/chromium/963
Merge 107749
BUG=111748
Review URL: https://chromiumcodereview.appspot.com/9564014
- 10:19 AM Changeset in webkit [109362] by
-
- 10 edits4 adds in trunk
Protect functions using two container node function, each of which can fire mutation events.
https://bugs.webkit.org/show_bug.cgi?id=78397
Reviewed by Ryosuke Niwa.
Source/WebCore:
Tests: fast/dom/document-set-title-mutation-crash.html
fast/dom/option-text-mutation-crash.html
- dom/Node.cpp:
(WebCore::Node::setTextContent):
- dom/Text.cpp:
(WebCore::Text::replaceWholeText):
- editing/markup.cpp:
(WebCore::trimFragment):
(WebCore::replaceChildrenWithFragment):
(WebCore::replaceChildrenWithText):
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::setText):
- html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::setText):
- html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::insertRow):
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::setDefaultValue):
- html/HTMLTitleElement.cpp:
(WebCore::HTMLTitleElement::setText):
LayoutTests:
- fast/dom/document-set-title-mutation-crash-expected.txt: Added.
- fast/dom/document-set-title-mutation-crash.html: Added.
- fast/dom/option-text-mutation-crash-expected.txt: Added.
- fast/dom/option-text-mutation-crash.html: Added.
- 10:07 AM Changeset in webkit [109361] by
-
- 5 edits2 copies in branches/chromium/1025
Merge 108134
BUG=108037
Review URL: https://chromiumcodereview.appspot.com/9569016
- 10:06 AM Changeset in webkit [109360] by
-
- 6 edits in trunk/Source/WebCore
Some trivial file stream cleanup
https://bugs.webkit.org/show_bug.cgi?id=79955
Reviewed by Sam Weinig.
No change in functionality.
- fileapi/FileStreamProxy.cpp: Tweaked comment, and added copyright for earlier changes.
- fileapi/FileStreamProxy.h: Added a FIXME telling that this should be in platform.
- platform/AsyncFileStream.h: Tweaked includes and added a FIXME about this to stop being a subclass.
- platform/FileStreamClient.h: Removed obvious comments, and added ones explaing in-band error signals.
- platform/network/BlobResourceHandle.cpp: Removed an include outside of platform, and an unused constant.
- 10:05 AM Changeset in webkit [109359] by
-
- 9 edits2 adds in trunk
Appending ShadowRoot into an element should not cause crash.
https://bugs.webkit.org/show_bug.cgi?id=79620
Reviewed by Dimitri Glazkov.
Source/WebCore:
We should treat ShadowRoot as a document fragment.
Test: fast/dom/shadow/shadow-root-append.html
- dom/ContainerNode.cpp:
(WebCore::collectTargetNodes):
LayoutTests:
- fast/dom/shadow/shadow-root-append-expected.txt: Added.
- fast/dom/shadow/shadow-root-append.html: Added.
- platform/efl/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- platform/wk2/Skipped:
- 10:05 AM Changeset in webkit [109358] by
-
- 5 edits2 copies in branches/chromium/963
Merge 108134
BUG=108037
Review URL: https://chromiumcodereview.appspot.com/9568017
- 9:53 AM Changeset in webkit [109357] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 108415
BUG=105867
Review URL: https://chromiumcodereview.appspot.com/9570019
- 9:52 AM Changeset in webkit [109356] by
-
- 2 edits4 copies in branches/chromium/1025
Merge 108152
BUG=105867
Review URL: https://chromiumcodereview.appspot.com/9567012
- 9:50 AM Changeset in webkit [109355] by
-
- 1 edit2 copies in branches/chromium/963
Merge 108415
BUG=105867
Review URL: https://chromiumcodereview.appspot.com/9567011
- 9:49 AM Changeset in webkit [109354] by
-
- 2 edits4 copies in branches/chromium/963
Merge 108152
BUG=105867
Review URL: https://chromiumcodereview.appspot.com/9565015
- 9:42 AM Changeset in webkit [109353] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 107733
BUG=104266
Review URL: https://chromiumcodereview.appspot.com/9565014
- 9:41 AM Changeset in webkit [109352] by
-
- 1 edit2 copies in branches/chromium/963
Merge 107733
BUG=104266
Review URL: https://chromiumcodereview.appspot.com/9565013
- 9:30 AM Changeset in webkit [109351] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: use live location to update console message bubbles.
https://bugs.webkit.org/show_bug.cgi?id=80023
Reviewed by Vsevolod Vlasov.
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._uiSourceCodeListChanged):
(WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessageToScript.updateLocation):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessageToScript):
(WebInspector.DebuggerPresentationModel.prototype._addPendingConsoleMessage):
(WebInspector.DebuggerPresentationModel.prototype._addPendingConsoleMessagesToScript):
(WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
(WebInspector.DebuggerPresentationModel.prototype.messagesForUISourceCode):
(WebInspector.DebuggerPresentationModel.prototype._scriptForURLAndLocation):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
- inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode):
- 9:15 AM Changeset in webkit [109350] by
-
- 2 edits in trunk/Source/WebKit/chromium
REGRESSION(r109288): WebViewImpl::enableAutoResizeMode loops infinitely
https://bugs.webkit.org/show_bug.cgi?id=77452
Reviewed by Hajime Morita.
WebViewImpl::enableAutoResizeMode loops infinitely.
This patch fixes the following line:
enableAutoResizeMode(enable, minSize, maxSize);
to
enableAutoResizeMode(minSize, maxSize);
to avoid the infinite loop. I guess this is the change originally intended.
Test: webkit_unit_tests.WebViewTest.AutoResizeMinimumSize
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::enableAutoResizeMode):
- 8:34 AM Changeset in webkit [109349] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: [InspectorIndexedDB] Show tooltips with IndexedDB objects meta information
https://bugs.webkit.org/show_bug.cgi?id=80022
Reviewed by Pavel Feldman.
Added tooltips with meta information for IndexedDB databases, object stores and indexes.
Added keyPath: prefix to key columns in IndexedDB data grid.
- English.lproj/localizedStrings.js:
- inspector/front-end/IndexedDBViews.js:
(WebInspector.IDBDataView.prototype._createDataGrid):
(WebInspector.IDBDataView.prototype._keyPathHeader):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.IDBDatabaseTreeElement.prototype.update):
(WebInspector.IDBDatabaseTreeElement.prototype._updateTooltip):
(WebInspector.IDBObjectStoreTreeElement.prototype.update):
(WebInspector.IDBObjectStoreTreeElement.prototype._updateTooltip):
(WebInspector.IDBIndexTreeElement.prototype.update):
(WebInspector.IDBIndexTreeElement.prototype._updateTooltip):
- 8:16 AM Changeset in webkit [109348] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: hide color picker on Esc and Enter.
https://bugs.webkit.org/show_bug.cgi?id=79915
Reviewed by Vsevolod Vlasov.
- inspector/front-end/Spectrum.js:
(WebInspector.Spectrum.prototype.reposition):
(WebInspector.Spectrum.prototype.hide):
(WebInspector.Spectrum.prototype._onKeyDown):
- 8:13 AM Changeset in webkit [109347] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Fixed incorrect size pixmap creation for a new transparency layer.
https://bugs.webkit.org/show_bug.cgi?id=79658
If QPainter does not have clipping, beginPlatformTransparencyLayer can create
wrong size pixmap, so it causes incorrect rendering.
Patch by Huang Dongsung <luxtella@company100.net> on 2012-03-01
Reviewed by Simon Hausmann.
- platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
- 7:18 AM Changeset in webkit [109346] by
-
- 3 edits1 delete in trunk/Source/WebCore
[Qt] Remove dead style option code.
https://bugs.webkit.org/show_bug.cgi?id=80017
Reviewed by Kenneth Rohde Christiansen.
QtStyleOptionWebComboBox provides functionality (bool multiple()) that
is not called from anywhere (and the base class does not have it as a
virtual function).
- Target.pri:
- platform/qt/QtStyleOptionWebComboBox.h: Removed.
- platform/qt/RenderThemeQStyle.cpp:
(WebCore::RenderThemeQStyle::paintMenuList):
(WebCore::RenderThemeQStyle::paintMenuListButton):
- 7:04 AM Changeset in webkit [109345] by
-
- 3 edits3 adds in trunk
Crash in WebCore::SVGDocumentExtensions::removeAnimationElementFromTarget
https://bugs.webkit.org/show_bug.cgi?id=79831
Patch by Stephen Chenney <schenney@chromium.org> on 2012-03-01
Reviewed by Eric Seidel.
Out-of-order operations in the SVGSMILElement::removedFromDocument
method caused its target to be removed and then re-added due to a
later call. This led to the target being set on the animation while
the target element itself was unaware. At deletion time, this caused a
crash (or assert in debug builds). Thanks to Abhishek Arya for help
with the layout test.
Source/WebCore:
Test: svg/animations/smil-element-target-crash-main.html
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::removedFromDocument):
LayoutTests:
- svg/animations/resources/smil-element-target-crash.svg: Added.
- svg/animations/smil-element-target-crash-main-expected.txt: Added.
- svg/animations/smil-element-target-crash-main.html: Added.
- 6:46 AM Changeset in webkit [109344] by
-
- 2 edits in trunk/LayoutTests
2012-03-01 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Rebaseline another SVG test on SnowLeopard, now new-run-webkit-tests --tolerance 0 -p svg also passes w/o failures on SL.
- platform/mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- 6:15 AM Changeset in webkit [109343] by
-
- 5 edits in trunk
Web Inspector: move heap snapshot nodes data to external array.
https://bugs.webkit.org/show_bug.cgi?id=79911
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Tests:
heap-shapshot.html
heap-shapshot-loader.html
- inspector/front-end/HeapSnapshot.js:
(WebInspector.Int32Array):
(WebInspector.Int32Array.prototype.get array):
(WebInspector.HeapSnapshotLoader.prototype._parseNodes):
(WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
(WebInspector.HeapSnapshot):
(WebInspector.HeapSnapshot.prototype._init):
LayoutTests:
- inspector/profiler/heap-snapshot-loader.html:
- inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockRaw):
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMock):
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockWithDOM):
- 6:00 AM Changeset in webkit [109342] by
-
- 22 edits4 adds in trunk
Introduce SMIL overrideStyle, to make SVG stop mutating CSS styles directly
https://bugs.webkit.org/show_bug.cgi?id=79790
Reviewed by Zoltan Herczeg.
Source/WebCore:
Next step towards enabling animVal support for XML attribute animations.
When SVG CSS properties are animated using SMIL, we currently mutate
the target elements style, and have to keep a baseValue around as String
to be able to recover from the DOM mutations at the end, if fill!="freeze".
The approach required by SMIL is to keep around an override style declaration
set and apply it right after the inline style declarations. Implement that
finally, to avoid mutating styles directly.
Test: svg/animations/attributeTypes.html
- css/CSSStyleSelector.cpp: Model "SMIL animation style" applying just like "inline style" declarations.
(WebCore::CSSStyleSelector::addElementStyleProperties): Refactored common code from matchAllRules().
(WebCore::CSSStyleSelector::matchAllRules): Apply "SMIL animation style" after "inline style" declarations, as specified in SMIL2.
- css/CSSStyleSelector.h: Add new addElementStyleProperties() helper.
- svg/SVGAnimateElement.cpp: Keep track of animation state, if it's about to end, clear "SMIL animation style" upon next applyResultToTarget() call.
(WebCore::SVGAnimateElement::SVGAnimateElement):
(WebCore::SVGAnimateElement::applyResultsToTarget): Reset the CSS property we're animating int the "SMIL animation style", after animation ends.
(Instead of resetting target->style() properties to the old baseValue, as we used to do).
(WebCore::SVGAnimateElement::endedActiveInterval): Set m_aboutToStopAnimation to true, so next call to applyResultsToTarget() knows the animation ends.
- svg/SVGAnimateElement.h: Store bool m_aboutToSTopAnimation;
- svg/SVGAnimationElement.cpp:
(WebCore::setTargetAttributeAnimatedCSSValue):
(WebCore::setTargetAttributeAnimatedXMLValue):
Refactored both of these methods from setTargetAttributeAnimatedValue().
Changed the CSS part, to apply property changes to the "SMIL animation style" instead of the regular StylePropertySet.
(WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue): Refactored code, use shouldApplyAnimation() to determine whether this animation should run.
(WebCore::SVGAnimationElement::resetAnimationState): New helper calling setTargetAttributeAnimatedValue with a null-string for CSS attributes, when the animation ends.
This is used to detect that the CSS property should be removed from the "SMIL animation style".
(WebCore::SVGAnimationElement::shouldApplyAnimation): Refactored from existing code, and make it more obvious how attributeType influences the animation, all according to SVG 1.1/SMIL2.
- svg/SVGAnimationElement.h:
- svg/SVGElement.cpp: Manage the "SMIL animation style", in SVGElementRareData, if needed. Only gets created if SMIL animations on CSS properties run.
(WebCore::SVGElement::~SVGElement): Destroy SMIL animation style, upon destruction.
(WebCore::SVGElement::animatedSMILStyleProperties): Returns the StylePropertySet for the "SMIL animation style", if it's available.
(WebCore::SVGElement::ensureAnimatedSMILStyleProperties): Enforces creating the StylePropertySet for the "SMIL animation style".
- svg/SVGElement.h: Expose new methods.
- svg/SVGElementRareData.h: Stores the "SMIL animation style", actual managment is done by SVGElement, if needed.
(WebCore::SVGElementRareData::animatedSMILStyleProperties): Retrieve it.
(WebCore::SVGElementRareData::ensureAnimatedSMILStyleProperties): Create it.
(WebCore::SVGElementRareData::destroyAnimatedSMILStyleProperties): Destroy it.
- svg/animation/SVGSMILElement.h: Make endedActiveInterval() virtual again, its needed by SVGAnimateElement now.
LayoutTests:
SVG CSS property animations aren't leaked into the DOM anymore, update the tests.
- svg/animations/animate-color-transparent-expected.txt:
- svg/animations/animate-currentColor-expected.txt:
- svg/animations/animate-dynamic-update-attributeName-expected.txt:
- svg/animations/animate-inherit-css-property-expected.txt:
- svg/animations/attributeTypes-expected.txt: Added.
- svg/animations/attributeTypes.html: Added.
- svg/animations/resources/attributeTypes.svg: Added.
- svg/animations/script-tests/animate-color-transparent.js:
(expectTransparent):
(expectOtherColor):
- svg/animations/script-tests/animate-currentColor.js:
(sample1):
(sample2):
(sample3):
- svg/animations/script-tests/animate-dynamic-update-attributeName.js:
(sample1):
(sample3):
- svg/animations/script-tests/animate-inherit-css-property.js:
(sample1):
(sample2):
(sample3):
- svg/animations/script-tests/attributeTypes.js: Added.
(sample1):
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/svgstring-animation-fallback-to-discrete.js:
(sample1):
(sample2):
(sample3):
- svg/animations/svgstring-animation-fallback-to-discrete-expected.txt:
- 5:58 AM WebKitGTK/1.8.x edited by
- (diff)
- 5:56 AM Changeset in webkit [109341] by
-
- 3 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit2
Merging r109230
- 5:44 AM Changeset in webkit [109340] by
-
- 16 edits in trunk
Unreviewed, rolling out r109255.
http://trac.webkit.org/changeset/109255
https://bugs.webkit.org/show_bug.cgi?id=79932
Breaks rounded rects with dashed strokes in SVG
Source/WebCore:
- WebCore.exp.in:
- platform/graphics/Path.cpp:
(WebCore::Path::addRoundedRect):
- platform/graphics/Path.h:
(Path):
- platform/graphics/cg/PathCG.cpp:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
Source/WebKit/mac:
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Source/WebKit2:
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
WebKitLibraries:
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- 5:03 AM Changeset in webkit [109339] by
-
- 5 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit2
Merging r109229
- 4:51 AM Changeset in webkit [109338] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] [GTK] [libsoup] SoupSession should use system CA
https://bugs.webkit.org/show_bug.cgi?id=79657
Reviewed by Martin Robinson.
SoupSession sould use system CA list to validate SSL
certificates. Do not use strict certificate validation though as
we want clients to decide whether or not accept/decline invalid
certificates (API to be added later).
No new tests required as current behaviour does not change at all
as we continue to accept invalid certificates by default.
- WebProcess/gtk/WebProcessMainGtk.cpp:
(WebKit::WebProcessMainGtk):
- 4:40 AM Changeset in webkit [109337] by
-
- 2 edits in trunk/Tools
Unreviewed, GTK NRWT build fix attempt after r109242.
- Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkDriver._start):
- 4:39 AM Changeset in webkit [109336] by
-
- 5 edits in trunk/Source/WebCore
DOMWindow shouldn't have any INDEXED_DATABASE ifdefs
https://bugs.webkit.org/show_bug.cgi?id=80013
Reviewed by Kentaro Hara.
Before this patch, DOMWindow still knew about IDB because of the
database factory. This patch moves the factory to
DOMWindowIndexedDatabase.
- Modules/indexeddb/DOMWindowIndexedDatabase.cpp:
(WebCore::DOMWindowIndexedDatabase::DOMWindowIndexedDatabase):
(WebCore::DOMWindowIndexedDatabase::from):
(WebCore):
(WebCore::DOMWindowIndexedDatabase::disconnectFrame):
(WebCore::DOMWindowIndexedDatabase::webkitIndexedDB):
- Modules/indexeddb/DOMWindowIndexedDatabase.h:
(DOMWindowIndexedDatabase):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::clear):
(WebCore):
- page/DOMWindow.h:
(DOMWindow):
- 4:37 AM Changeset in webkit [109335] by
-
- 2 edits in trunk/Tools
REGRESSION(r109036): run-bindings-tests fails because resolve-supplemental.pl was renamed
https://bugs.webkit.org/show_bug.cgi?id=80008
Reviewed by Adam Barth.
In r109036, I forgot to rename "resolve-supplemental.pl" in run-bindings-tests
to "preprocess-idls.pl". This patch renames it.
Test: Confirm that run-bindings-tests runs.
- Scripts/webkitpy/bindings/main.py:
(BindingsTests.generate_supplemental_dependency):
- 4:28 AM Changeset in webkit [109334] by
-
- 7 edits in trunk/LayoutTests
2012-03-01 Florin Malita <fmalita@google.com>
Percent width/height SVG not always scaled on window resize
https://bugs.webkit.org/show_bug.cgi?id=79490
Reviewed by Nikolas Zimmermann.
Update tests to avoid the use of window.resize{To,By}.
- fast/repaint/percent-minheight-resize-expected.html:
- fast/repaint/percent-minheight-resize.html:
- svg/custom/svg-percent-scale-expected.html:
- svg/custom/svg-percent-scale-vonly-expected.html:
- svg/custom/svg-percent-scale-vonly.html:
- svg/custom/svg-percent-scale.html:
- 4:21 AM Changeset in webkit [109333] by
-
- 2 edits in trunk/Source/WebCore
SVG <use> element allows invalid contents
https://bugs.webkit.org/show_bug.cgi?id=77764
Reviewed by Zoltan Herczeg.
Unbreak the world after r109299 - dozens of SVGUseElement tests fail in trunk because:
- text nodes weren't allowed in SVG shadow subtrees
- tagName matching ignores any prefixes, thus svg:circle fails to identify as SVGCircleElement
- svg/SVGUseElement.cpp:
(WebCore::isDisallowedElement):
- 3:43 AM Changeset in webkit [109332] by
-
- 3 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit2
Merging r109228
- 3:43 AM Changeset in webkit [109331] by
-
- 3 edits in trunk/Source/WebCore
Handle CSSPropertyWebkitHyphens in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=80004
Reviewed by Eric Seidel.
No new tests / refactoring only.
- css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- 3:36 AM Changeset in webkit [109330] by
-
- 11 edits3 adds in releases/WebKitGTK/webkit-1.8/Source/WebKit2
Merging r109222
- 3:17 AM Changeset in webkit [109329] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed. Fix WebKit2 GTK+ build.
- UIProcess/API/gtk/WebKitDefines.h:
- UIProcess/API/gtk/WebKitWebView.h:
- 2:29 AM SettingUpDevelopmentEnvironmentForN9 edited by
- (diff)
- 2:28 AM Changeset in webkit [109328] by
-
- 6 edits in trunk
Web Inspector: abstract out the common pattern of creating auto-updated locations.
https://bugs.webkit.org/show_bug.cgi?id=79906
Reviewed by Vsevolod Vlasov.
Source/WebCore:
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.PresentationCallFrame.prototype.uiLocation):
(WebInspector.DebuggerPresentationModel.CallFramePlacard):
(WebInspector.DebuggerPresentationModel.CallFramePlacard.prototype.discard):
(WebInspector.DebuggerPresentationModel.CallFramePlacard.prototype._update):
(WebInspector.DebuggerPresentationModel.LinkifierFormatter.prototype.formatRawSourceCodeAnchor):
(WebInspector.DebuggerPresentationModel.DefaultLinkifierFormatter.prototype.formatRawSourceCodeAnchor):
(WebInspector.DebuggerPresentationModel.Linkifier):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyRawSourceCode):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.reset):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor):
- inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype.createLiveLocation):
(WebInspector.RawSourceCode.LiveLocation):
(WebInspector.RawSourceCode.LiveLocation.prototype.init):
(WebInspector.RawSourceCode.LiveLocation.prototype.dispose):
(WebInspector.RawSourceCode.LiveLocation.prototype._update):
LayoutTests:
- inspector/debugger/linkifier.html:
- 1:53 AM Changeset in webkit [109327] by
-
- 3 edits in trunk/Source/WebCore
Make the tiling code slightly smarter
https://bugs.webkit.org/show_bug.cgi?id=80015
Reviewed by Simon Hausmann.
Avoid doing the same tranformations all over in each call to
tileRectForCoordinate.
Do not resize tiles and then drop them because they are not out of
the keep rect; instead drop before resizing.
Rename dropTilesOutsideRect to setKeepRect as it now stored the keep
rect. This is used to avoid unneeded iteration of all tiles for
invalidates outside the keep rect.
- platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::invalidate):
(WebCore):
(WebCore::TiledBackingStore::commitScaleChange):
(WebCore::TiledBackingStore::coverageRatio):
(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::adjustForContentsRect):
(WebCore::TiledBackingStore::resizeEdgeTiles):
(WebCore::TiledBackingStore::setKeepRect):
(WebCore::TiledBackingStore::removeAllNonVisibleTiles):
(WebCore::TiledBackingStore::tileRectForCoordinate):
(WebCore::TiledBackingStore::setSupportsAlpha):
- platform/graphics/TiledBackingStore.h:
(TiledBackingStore):
- 1:32 AM Changeset in webkit [109326] by
-
- 6 edits in trunk
[Qt][WK2] QQuickWebView::event should lookup faster which events QQuickWebPage can handle
https://bugs.webkit.org/show_bug.cgi?id=78047
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
Replaced double-dispatch of events with direct forwarding of events from QQuickWebView::*Event to
QtWebPageEventHandler::handle*Event.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebView::keyPressEvent):
(QQuickWebView::keyReleaseEvent):
(QQuickWebView::inputMethodEvent):
(QQuickWebView::focusInEvent):
(QQuickWebView::focusOutEvent):
(QQuickWebView::touchEvent):
(QQuickWebView::mousePressEvent):
(QQuickWebView::mouseMoveEvent):
(QQuickWebView::mouseReleaseEvent):
(QQuickWebView::mouseDoubleClickEvent):
(QQuickWebView::wheelEvent):
(QQuickWebView::hoverEnterEvent):
(QQuickWebView::hoverMoveEvent):
(QQuickWebView::hoverLeaveEvent):
(QQuickWebView::dragMoveEvent):
(QQuickWebView::dragEnterEvent):
(QQuickWebView::dragLeaveEvent):
(QQuickWebView::dropEvent):
(QQuickWebView::event):
- UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::handleMouseMoveEvent):
(QtWebPageEventHandler::handleMousePressEvent):
(QtWebPageEventHandler::handleMouseReleaseEvent):
(QtWebPageEventHandler::handleWheelEvent):
(QtWebPageEventHandler::handleHoverLeaveEvent):
(QtWebPageEventHandler::handleHoverMoveEvent):
(QtWebPageEventHandler::handleDragEnterEvent):
(QtWebPageEventHandler::handleDragLeaveEvent):
(QtWebPageEventHandler::handleDragMoveEvent):
(QtWebPageEventHandler::handleDropEvent):
(QtWebPageEventHandler::handleKeyPressEvent):
(QtWebPageEventHandler::handleKeyReleaseEvent):
(QtWebPageEventHandler::handleFocusInEvent):
(QtWebPageEventHandler::handleFocusOutEvent):
(QtWebPageEventHandler::handleInputMethodEvent):
(QtWebPageEventHandler::handleTouchEvent):
- UIProcess/qt/QtWebPageEventHandler.h:
(QtWebPageEventHandler):
Tools:
Send events for the webview through the QQuickCanvas instead of directly to the item. Direct
sending to the item requires the QObject::event re-implementation to dispatch to the correct
event handling function. However QQuickItem::event doesn't do that. Instead QQuickCanvas calls
the event handlers directly, and with the removal of our own dispatching we need to go through
that code path.
- WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::sendEvent):
(WTR::PlatformWebView::postEvent):
- 1:31 AM Changeset in webkit [109325] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG local CSE for a node can be terminated earlier
https://bugs.webkit.org/show_bug.cgi?id=80014
Reviewed by Filip Pizlo.
When one of the node's childredn is met in the process of back traversing
the nodes, we don't need to traverse the remaining nodes.
This is performance neutral on SunSpider, V8 and Kraken.
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::pureCSE):
(JSC::DFG::CSEPhase::impureCSE):
(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::checkFunctionElimination):
(JSC::DFG::CSEPhase::checkStructureLoadElimination):
(JSC::DFG::CSEPhase::getByOffsetLoadElimination):
(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
- 1:18 AM Changeset in webkit [109324] by
-
- 14 edits in trunk/Source
Use the new createSnapshotFileAndReadMetadata API for FileEntry.file()
https://bugs.webkit.org/show_bug.cgi?id=79928
Reviewed by David Levin.
Source/WebCore:
No new tests: no functionality changes.
fast/filesystem/ tests should use the new code (they should pass once
the corresponding chromium change is rolled in).
- fileapi/DOMFileSystem.cpp:
(WebCore::DOMFileSystem::createFile): Updated to use the new API.
- fileapi/DOMFileSystemSync.cpp:
(WebCore::DOMFileSystemSync::createFile): Updated to use the new API.
- fileapi/FileSystemCallbacks.cpp:
- fileapi/FileSystemCallbacks.h:
(FileSystemCallbacksBase):
- platform/AsyncFileSystem.h:
(AsyncFileSystem):
- platform/AsyncFileSystemCallbacks.h: Added default implementation (which just calls ASSERT_NOTREACHED()) so that subclasses can focus only on the callback methods that they're interested in.
Source/WebKit/chromium:
In the new flow we first create an internal Blob URL for the
snapshot file and call the new createSnapshotFileAndReadMetadata()
WebKit API with the Blob URL.
The implementor of createSnapshotFileAndReadMetadata() (i.e. chromium)
registers the created snapshot file with the given internal Blob URL.
In the callback chain we call File::createWithName() to create a
new File using the returned platform path, and then call
unregisterBlobURL() to clean up the internal Blob URL.
- src/AsyncFileSystemChromium.cpp:
(WebCore::AsyncFileSystemChromium::createSnapshotFileAndReadMetadata): Added.
(WebCore::AsyncFileSystemChromium::createSnapshotFileCallback): Added.
- src/AsyncFileSystemChromium.h:
- src/WorkerAsyncFileSystemChromium.cpp:
(WebCore::WorkerAsyncFileSystemChromium::createSnapshotFileAndReadMetadata): Added.
- src/WorkerAsyncFileSystemChromium.h:
- src/WorkerFileSystemCallbacksBridge.cpp:
(WebKit::WorkerFileSystemCallbacksBridge::postCreateSnapshotFileToMainThread): Added.
(WebKit::WorkerFileSystemCallbacksBridge::createSnapshotFileOnMainThread): Added.
- src/WorkerFileSystemCallbacksBridge.h:
(WorkerFileSystemCallbacksBridge):
- 12:22 AM Changeset in webkit [109323] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: add UISourceCode.isEditable property.
https://bugs.webkit.org/show_bug.cgi?id=79909
Reviewed by Vsevolod Vlasov.
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource):
- inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype._createUISourceCode):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
- 12:05 AM Changeset in webkit [109322] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Unreviewed buildfix after r109277.
Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2012-03-01
- WebProcess/qt/QtBuiltinBundlePage.cpp:
(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):
Feb 29, 2012:
- 11:58 PM Changeset in webkit [109321] by
-
- 6 edits in trunk
Fallback elements in non-youngest shadow tree should not be rendered.
https://bugs.webkit.org/show_bug.cgi?id=80002
Reviewed by Hajime Morita.
Source/WebCore:
Fallback elements in non-youngest shadow tree should not be rendered, so its phase should be
AttachingNotDistributed instead of AttachingFallbacked.
Tests: multiple-shadowroot-rendering.html covers this patch.
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::NodeRenderingContext):
LayoutTests:
Since createContentWithSelect shadw-test-driver.js is not intuitive, fallback element
is not added in existing tests.
This change makes sure the existence of fallback elements.
- fast/dom/resources/shadow-test-driver.js:
(createContentWithSelect):
- fast/dom/shadow/content-element-move.html:
- fast/dom/shadow/multiple-shadowroot-rendering.html:
- 11:50 PM Changeset in webkit [109320] by
-
- 4 edits in trunk
Perf-o-matic build fix. Also toggle the switch to start using ping images on the dashboard after r109190.
- Websites/webkit-perf.appspot.com/controller.py:
(schedule_runs_update):
(schedule_report_process):
- Websites/webkit-perf.appspot.com/js/admin.js:
(bind):
- Websites/webkit-perf.appspot.com/js/config.js:
- 11:46 PM Changeset in webkit [109319] by
-
- 20 edits2 adds in trunk/Source
ScriptExecutionContext has too many ifdef ENABLE(SQL_DATABASE)
https://bugs.webkit.org/show_bug.cgi?id=79633
Reviewed by Eric Seidel.
Source/WebCore:
This class creates a DatabaseContext object to supplement the
ScriptExecutionContext with database-specific information. This new
object lets us remove a bunch of database-specific (and ifdefed) logic
from ScriptExecutionContext.(cpp|h).
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::ScriptExecutionContext):
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore):
- dom/ScriptExecutionContext.h:
(WebCore):
(ScriptExecutionContext):
- history/PageCache.cpp:
(WebCore::logCanCacheFrameDecision):
(WebCore::PageCache::canCachePageContainingThisFrame):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopLoading):
- platform/Supplementable.h:
(WebCore::Supplementable::provideSupplement):
(WebCore::Supplementable::requireSupplement):
(Supplementable):
- storage/AbstractDatabase.cpp:
(WebCore::AbstractDatabase::AbstractDatabase):
- storage/AbstractDatabase.h:
(WebCore):
(WebCore::AbstractDatabase::databaseContext):
(AbstractDatabase):
- storage/Database.cpp:
(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::openAndVerifyVersion):
(WebCore::Database::markAsDeletedAndClose):
(WebCore::Database::close):
(WebCore::Database::closeImmediately):
(WebCore::Database::performOpenAndVerify):
(WebCore::Database::scheduleTransaction):
(WebCore::Database::scheduleTransactionStep):
(WebCore::Database::transactionClient):
(WebCore::Database::transactionCoordinator):
(WebCore::Database::tableNames):
(WebCore::Database::securityOrigin):
- storage/DatabaseContext.cpp: Added.
(WebCore):
(WebCore::existingDatabaseContextFrom):
(WebCore::DatabaseContext::DatabaseContext):
(WebCore::DatabaseContext::~DatabaseContext):
(WebCore::DatabaseContext::from):
(WebCore::DatabaseContext::databaseThread):
(WebCore::DatabaseContext::hasOpenDatabases):
(WebCore::DatabaseContext::stopDatabases):
- storage/DatabaseContext.h: Added.
(WebCore):
(DatabaseContext):
(WebCore::DatabaseContext::setHasOpenDatabases):
- storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::checkAndHandleClosedOrInterruptedDatabase):
(WebCore::SQLTransaction::notifyDatabaseThreadIsShuttingDown):
- workers/WorkerThread.cpp:
(WebCore::WorkerThreadShutdownStartTask::performTask):
Source/WebKit/mac:
- WebView/WebFrame.mm:
(-[WebFrame _cacheabilityDictionary]):
- 11:39 PM Changeset in webkit [109318] by
-
- 15 edits in trunk/Source/JavaScriptCore
DFG BasicBlocks should not require that their nodes have continuous indices in the graph
https://bugs.webkit.org/show_bug.cgi?id=79899
Reviewed by Filip Pizlo.
This will make it more convenient to insert nodes into the DFG.
With this capability we now place the Phi nodes in the corresponding
blocks.
Local CSE is modified to not to rely on the assumption of continuous
node indices in a block.
This is performance neutral on SunSpider, V8 and Kraken.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::AbstractState):
(JSC::DFG::AbstractState::beginBasicBlock):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::clobberStructures):
(JSC::DFG::AbstractState::mergeToSuccessors):
(JSC::DFG::AbstractState::dump):
- dfg/DFGAbstractState.h:
(JSC::DFG::AbstractState::forNode):
(AbstractState):
- dfg/DFGArithNodeFlagsInferencePhase.cpp:
(ArithNodeFlagsInferencePhase):
- dfg/DFGBasicBlock.h:
(JSC::DFG::BasicBlock::BasicBlock):
(BasicBlock):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::addToGraph):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::insertPhiNode):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::linkBlock):
(JSC::DFG::ByteCodeParser::determineReachability):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
- dfg/DFGCFAPhase.cpp:
(JSC::DFG::CFAPhase::performBlockCFA):
(CFAPhase):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::CSEPhase):
(JSC::DFG::CSEPhase::endIndexForPureCSE):
(JSC::DFG::CSEPhase::pureCSE):
(JSC::DFG::CSEPhase::impureCSE):
(JSC::DFG::CSEPhase::globalVarLoadElimination):
(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::checkFunctionElimination):
(JSC::DFG::CSEPhase::checkStructureLoadElimination):
(JSC::DFG::CSEPhase::getByOffsetLoadElimination):
(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::getScopeChainLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
(JSC::DFG::CSEPhase::performBlockCSE):
(CSEPhase):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGPhase.cpp:
(JSC::DFG::Phase::beginPhase):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativeStrictEq):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::compileStrictEqForConstant):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
- dfg/DFGVirtualRegisterAllocationPhase.cpp:
(JSC::DFG::VirtualRegisterAllocationPhase::run):
- 11:34 PM Changeset in webkit [109317] by
-
- 3 edits in trunk/Tools
Disable watchlist. It's been spamming CCs.
- Scripts/webkitpy/tool/bot/stylequeuetask.py:
(StyleQueueTask.run):
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- 11:23 PM Changeset in webkit [109316] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, gardening.
- platform/chromium/test_expectations.txt:
- 11:10 PM Changeset in webkit [109315] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, rolling out r109309.
http://trac.webkit.org/changeset/109309
https://bugs.webkit.org/show_bug.cgi?id=80002
broke
- fast/dom/resources/shadow-test-driver.js:
(createContentWithSelect):
- fast/dom/shadow/content-element-move.html:
- 10:54 PM Changeset in webkit [109314] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
- DEPS:
- 10:39 PM Changeset in webkit [109313] by
-
- 11 edits in trunk/Source/WebCore
Refactoring: HTMLContentSelector should be InsertionPoint-aware.
https://bugs.webkit.org/show_bug.cgi?id=79901
Reviewed by Hajime Morita.
ContentSelectorQuery took HTMLContentElement as argument, but patch changes it to take InsertionPoint instead.
If InsertionPoint is not HTMLContentElement, ContentSelectorQuery will selects the rest of light children.
Now InsertionPoint has pure virtual method 'select'. <shadow> will implement this as a method returning empty string.
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::hasInsertionPoint):
- dom/ShadowRoot.h:
(ShadowRoot):
- dom/ShadowTree.cpp:
(WebCore::ShadowTree::needsReattachHostChildrenAndShadow):
(WebCore::ShadowTree::hostChildrenChanged):
- html/shadow/ContentSelectorQuery.cpp:
(WebCore::ContentSelectorQuery::ContentSelectorQuery):
(WebCore::ContentSelectorQuery::matches):
- html/shadow/ContentSelectorQuery.h:
(WebCore):
(ContentSelectorQuery):
- html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::detach):
- html/shadow/HTMLContentElement.h:
(WebCore::toHTMLContentElement):
(WebCore):
- html/shadow/HTMLContentSelector.cpp:
(WebCore::HTMLContentSelector::select):
- html/shadow/HTMLContentSelector.h:
(HTMLContentSelector):
- html/shadow/InsertionPoint.h:
(InsertionPoint):
- 10:36 PM Changeset in webkit [109312] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed, gardening.
- platform/chromium-mac-snowleopard/media/sources-fallback-codecs-expected.txt: Added.
- 10:22 PM Changeset in webkit [109311] by
-
- 4 edits in trunk/Source/WebCore
Handle CSSPropertySpeak in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=79879
Reviewed by Eric Seidel.
No new tests / refactoring only.
- css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- rendering/style/RenderStyle.h:
- 10:12 PM Changeset in webkit [109310] by
-
- 3 edits in trunk/Source/WebCore
Handle CSSPropertyWebkitColumnAxis in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=79869
Reviewed by Eric Seidel.
No new tests / refactoring only.
- css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- 9:57 PM Changeset in webkit [109309] by
-
- 3 edits in trunk/LayoutTests
createContentWithSelect in shadow-test-driver.js is not intuitive.
https://bugs.webkit.org/show_bug.cgi?id=80002
Reviewed by Hajime Morita.
createContentWithSelect takes an agument 'fallback', but it used to create a text node
if the argument is missing. This is not intuitive at all.
This patch changes the createContentWithSelect behavior to make it intuitive.
- fast/dom/resources/shadow-test-driver.js:
(createContentWithSelect):
- fast/dom/shadow/content-element-move.html:
- 9:47 PM Changeset in webkit [109308] by
-
- 1 edit1 add in trunk/Source/JavaScriptCore
The JIT should not crash the entire process just because there is not
enough executable memory, if the LLInt is enabled
https://bugs.webkit.org/show_bug.cgi?id=79962
<rdar://problem/10922215>
Unreviewed, adding forgotten file.
- jit/JITCompilationEffort.h: Added.
(JSC):
- 9:46 PM Changeset in webkit [109307] by
-
- 24 edits in trunk/Source/JavaScriptCore
The JIT should not crash the entire process just because there is not
enough executable memory, if the LLInt is enabled
https://bugs.webkit.org/show_bug.cgi?id=79962
<rdar://problem/10922215>
Reviewed by Gavin Barraclough.
Added the notion of JITCompilationEffort. If we're JIT'ing as a result of
a tier-up, then we set it to JITCompilationCanFail. Otherwise it's
JITCompilationMustSucceed. This preserves the old behavior of LLInt is
disabled or if we're compiling something that can't be interpreted (like
an OSR exit stub).
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::executableCopy):
- assembler/ARMAssembler.h:
(ARMAssembler):
- assembler/AssemblerBuffer.h:
(JSC::AssemblerBuffer::executableCopy):
- assembler/LinkBuffer.h:
(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::~LinkBuffer):
(LinkBuffer):
(JSC::LinkBuffer::didFailToAllocate):
(JSC::LinkBuffer::isValid):
(JSC::LinkBuffer::linkCode):
(JSC::LinkBuffer::performFinalization):
- assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::executableCopy):
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::executableCopy):
- assembler/X86Assembler.h:
(JSC::X86Assembler::executableCopy):
(JSC::X86Assembler::X86InstructionFormatter::executableCopy):
- bytecode/CodeBlock.cpp:
(JSC::ProgramCodeBlock::jitCompileImpl):
(JSC::EvalCodeBlock::jitCompileImpl):
(JSC::FunctionCodeBlock::jitCompileImpl):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::jitCompile):
(CodeBlock):
(ProgramCodeBlock):
(EvalCodeBlock):
(FunctionCodeBlock):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGJITCompiler.h:
(JITCompiler):
- jit/ExecutableAllocator.cpp:
(JSC::DemandExecutableAllocator::allocateNewSpace):
(JSC::ExecutableAllocator::allocate):
- jit/ExecutableAllocator.h:
(ExecutableAllocator):
- jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::ExecutableAllocator::allocate):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- jit/JIT.h:
(JSC::JIT::compile):
(JIT):
- jit/JITCompilationEffort.h: Added.
(JSC):
- jit/JITDriver.h:
(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):
- llint/LLIntSlowPaths.cpp:
(LLInt):
(JSC::LLInt::jitCompileAndSetHeuristics):
(JSC::LLInt::entryOSR):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- runtime/Executable.cpp:
(JSC::EvalExecutable::jitCompile):
(JSC::ProgramExecutable::jitCompile):
(JSC::FunctionExecutable::jitCompileForCall):
(JSC::FunctionExecutable::jitCompileForConstruct):
- runtime/Executable.h:
(EvalExecutable):
(ProgramExecutable):
(FunctionExecutable):
(JSC::FunctionExecutable::jitCompileFor):
- runtime/ExecutionHarness.h:
(JSC::prepareForExecution):
(JSC::prepareFunctionForExecution):
- 9:34 PM Changeset in webkit [109306] by
-
- 14 edits in trunk
Rename DOMSelection to Selection
https://bugs.webkit.org/show_bug.cgi?id=79688
Reviewed by Adam Barth.
Source/WebCore:
No new tests. Existing tests have been updated to cover this.
- page/DOMSelection.idl:
- page/DOMWindow.idl:
LayoutTests:
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/dom-constructors-expected.txt:
- fast/dom/dom-constructors.html:
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/mac/fast/dom/Window/window-properties-expected.txt:
- platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
- platform/qt-5.0-wk2/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/win/fast/dom/Window/window-properties-expected.txt:
- 9:22 PM Changeset in webkit [109305] by
-
- 6 edits2 adds in trunk
IndexedDB: IDBDatabase.objectStoreNames and IDObjectStore.indexNames results should be sorted
https://bugs.webkit.org/show_bug.cgi?id=79950
Reviewed by Tony Chang.
Source/WebCore:
Test: storage/indexeddb/list-ordering.html
- dom/DOMStringList.cpp: Added sort method, not exposed via IDL.
(WebCore::DOMStringList::sort):
(WebCore):
- dom/DOMStringList.h:
(DOMStringList):
- storage/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::objectStoreNames):
- storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::indexNames):
LayoutTests:
- storage/indexeddb/list-ordering-expected.txt: Added.
- storage/indexeddb/list-ordering.html: Added.
- 8:33 PM Changeset in webkit [109304] by
-
- 8 edits in trunk/Source
[chromium] Estimate pixel count for frame rate control
https://bugs.webkit.org/show_bug.cgi?id=74982
Reviewed by James Robinson.
Source/WebCore:
Value checks added to unit tests.
Adds mechanism to compute and collect statistics on pixel overdraw for selected frames.
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::optimizeRenderPasses):
- platform/graphics/chromium/cc/CCQuadCuller.cpp:
(WebCore::wedgeProduct):
(WebCore):
(WebCore::quadArea):
(WebCore::CCQuadCuller::cullOccludedQuads):
- platform/graphics/chromium/cc/CCQuadCuller.h:
(CCQuadCuller):
- platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::optimizeQuads):
- platform/graphics/chromium/cc/CCRenderPass.h:
(CCOverdrawCounts):
(WebCore):
(CCRenderPass):
Source/WebKit/chromium:
Adds mechanism to compute and collect statistics on pixel overdraw for selected frames.
- tests/CCQuadCullerTest.cpp:
(WebCore):
(WebCore::TEST):
- 8:26 PM Changeset in webkit [109303] by
-
- 1 edit3 adds in trunk/LayoutTests
Unreviewed, gardening.
- platform/chromium-linux/fast/workers/storage/use-same-database-in-page-and-workers-expected.txt: Added.
- 8:22 PM Changeset in webkit [109302] by
-
- 22 edits in trunk/Source
[Qt][WK2] Get rid of the #ifdef mess in LayerTreeHost[Proxy]
https://bugs.webkit.org/show_bug.cgi?id=79501
Source/JavaScriptCore:
Enable WTF_USE_UI_SIDE_COMPOSITING for Qt.
Reviewed by Kenneth Rohde Christiansen.
- wtf/Platform.h:
Source/WebKit2:
Use a new UI_SIDE_COMPOSITING flag instead of the several #ifdef flags we currently use.
Reviewed by Kenneth Rohde Christiansen.
- Shared/WebLayerTreeInfo.cpp:
- Shared/WebLayerTreeInfo.h:
- UIProcess/DrawingAreaProxy.cpp:
(WebKit):
- UIProcess/DrawingAreaProxy.h:
(DrawingAreaProxy):
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
(WebKit):
- UIProcess/DrawingAreaProxyImpl.h:
(DrawingAreaProxyImpl):
- UIProcess/LayerTreeHostProxy.h:
(LayerTreeHostProxy):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
- UIProcess/qt/LayerBackingStore.cpp:
- UIProcess/qt/LayerBackingStore.h:
- UIProcess/qt/LayerTreeHostProxyQt.cpp:
- WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
- WebProcess/WebCoreSupport/WebGraphicsLayer.h:
- WebProcess/WebPage/DrawingArea.h:
(DrawingArea):
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit):
- WebProcess/WebPage/DrawingAreaImpl.h:
(DrawingAreaImpl):
- WebProcess/WebPage/LayerTreeHost.cpp:
(WebKit::LayerTreeHost::create):
- WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::purgeBackingStores):
- WebProcess/WebPage/qt/LayerTreeHostQt.h:
(LayerTreeHostQt):
- 8:20 PM Changeset in webkit [109301] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry]Make about:cache feature available in release version.
https://bugs.webkit.org/show_bug.cgi?id=79866
Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-02-29
Reviewed by Antonio Gomes.
No tests.
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::handleAbout):
- 8:08 PM Changeset in webkit [109300] by
-
- 7 edits in trunk/Source
[chromium] Fix navigation start time on cross-renderer navigation
https://bugs.webkit.org/show_bug.cgi?id=75922
Reviewed by Darin Fisher.
Source/WebCore:
- loader/DocumentLoadTiming.cpp:
(WebCore::DocumentLoadTiming::setNavigationStart): Added.
- loader/DocumentLoadTiming.h:
Source/WebKit/chromium:
- public/WebDataSource.h:
- src/WebDataSource.cpp:
(WebKit::WebDataSource::setNavigationStartTime): Added.
- src/WebDataSource.h:
- 7:54 PM Changeset in webkit [109299] by
-
- 3 edits8 adds in trunk
SVG <use> element allows invalid contents
https://bugs.webkit.org/show_bug.cgi?id=77764
Patch by Stephen Chenney <schenney@chromium.org> on 2012-02-29
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Modify the isDisallowedElement method to disallow all of the
disallowed elements, instead of just a few. It is now a whitelist
implementation.
This also fixes bugs 78807, 78838 and 79798 related to memory
corruption issues.
Tests: svg/custom/bug78807.svg
svg/custom/bug78838.html
svg/custom/bug79798.html
- svg/SVGUseElement.cpp:
(WebCore::isDisallowedElement):
LayoutTests:
These test all use invalid elements in the <use> and crash in the absence
of this patch. Existing tests cover the valid elements in <use>, so no
additional tests for those.
- svg/custom/bug78807-expected.txt: Added.
- svg/custom/bug78807.svg: Added.
- svg/custom/bug78838-expected.txt: Added.
- svg/custom/bug78838.html: Added.
- svg/custom/bug79798-expected.txt: Added.
- svg/custom/bug79798.html: Added.
- svg/custom/resources/bug78838.svg: Added.
- svg/custom/resources/bug79798.svg: Added.
- 7:38 PM Changeset in webkit [109298] by
-
- 3 edits2 adds in trunk
Continue the search for playable mime types among <source> children of <video> even when using data: URLs
https://bugs.webkit.org/show_bug.cgi?id=79934
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/sources-fallback-codecs.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::selectNextSourceChild):
LayoutTests:
- media/sources-fallback-codecs-expected.txt: Added.
- media/sources-fallback-codecs.html: Added.
- 7:34 PM Changeset in webkit [109297] by
-
- 7 edits2 adds in trunk/Source
[chromium] Add impl-thread support for animation-timing-function
https://bugs.webkit.org/show_bug.cgi?id=79819
Patch by Ian Vollick <vollick@chromium.org> on 2012-02-29
Reviewed by James Robinson.
Source/WebCore:
- WebCore.gypi:
- platform/graphics/chromium/cc/CCKeyframedAnimationCurve.cpp:
(WebCore::CCKeyframe::CCKeyframe):
(WebCore):
(WebCore::CCKeyframe::~CCKeyframe):
(WebCore::CCKeyframe::time):
(WebCore::CCKeyframe::timingFunction):
(WebCore::CCFloatKeyframe::create):
(WebCore::CCFloatKeyframe::CCFloatKeyframe):
(WebCore::CCFloatKeyframe::~CCFloatKeyframe):
(WebCore::CCFloatKeyframe::value):
(WebCore::CCFloatKeyframe::clone):
(WebCore::CCTransformKeyframe::create):
(WebCore::CCTransformKeyframe::CCTransformKeyframe):
(WebCore::CCTransformKeyframe::~CCTransformKeyframe):
(WebCore::CCTransformKeyframe::value):
(WebCore::CCTransformKeyframe::clone):
(WebCore::CCKeyframedFloatAnimationCurve::create):
(WebCore::CCKeyframedFloatAnimationCurve::CCKeyframedFloatAnimationCurve):
(WebCore::CCKeyframedFloatAnimationCurve::addKeyframe):
(WebCore::CCKeyframedFloatAnimationCurve::duration):
(WebCore::CCKeyframedFloatAnimationCurve::clone):
(WebCore::CCKeyframedFloatAnimationCurve::getValue):
(WebCore::CCKeyframedTransformAnimationCurve::create):
(WebCore::CCKeyframedTransformAnimationCurve::CCKeyframedTransformAnimationCurve):
(WebCore::CCKeyframedTransformAnimationCurve::~CCKeyframedTransformAnimationCurve):
(WebCore::CCKeyframedTransformAnimationCurve::addKeyframe):
(WebCore::CCKeyframedTransformAnimationCurve::duration):
(WebCore::CCKeyframedTransformAnimationCurve::clone):
(WebCore::CCKeyframedTransformAnimationCurve::getValue):
- platform/graphics/chromium/cc/CCKeyframedAnimationCurve.h:
(CCKeyframe):
(CCFloatKeyframe):
(WebCore):
(CCTransformKeyframe):
(CCKeyframedFloatAnimationCurve):
(CCKeyframedTransformAnimationCurve):
- platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
- platform/graphics/chromium/cc/CCTimingFunction.cpp: Added.
(WebCore):
(WebCore::CCTimingFunction::CCTimingFunction):
(WebCore::CCTimingFunction::~CCTimingFunction):
(WebCore::CCTimingFunction::duration):
(WebCore::CCCubicBezierTimingFunction::create):
(WebCore::CCCubicBezierTimingFunction::CCCubicBezierTimingFunction):
(WebCore::CCCubicBezierTimingFunction::~CCCubicBezierTimingFunction):
(WebCore::CCCubicBezierTimingFunction::getValue):
(WebCore::CCCubicBezierTimingFunction::clone):
(WebCore::CCEaseTimingFunction::create):
(WebCore::CCEaseInTimingFunction::create):
(WebCore::CCEaseOutTimingFunction::create):
(WebCore::CCEaseInOutTimingFunction::create):
- platform/graphics/chromium/cc/CCTimingFunction.h: Added.
(WebCore):
(CCTimingFunction):
(CCCubicBezierTimingFunction):
(CCEaseTimingFunction):
(CCEaseInTimingFunction):
(CCEaseOutTimingFunction):
(CCEaseInOutTimingFunction):
Source/WebKit/chromium:
- tests/CCKeyframedAnimationCurveTest.cpp:
(WebCore::TEST):
(WebCore):
- 6:51 PM Changeset in webkit [109296] by
-
- 4 edits126 adds in trunk
need to clone the gpu baselines and expectations into the new "virtual" dir
https://bugs.webkit.org/show_bug.cgi?id=79956
Tools:
Reviewed by Adam Barth.
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.virtual_test_suites):
LayoutTests:
Unreviewed, expectations change and new baselines.
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/arc360-expected.png: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-before-css-expected.png: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-expected.png: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-expected.txt: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-resize-reset-expected.png: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-text-baseline-expected.png: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-transforms-during-path-expected.png: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvasDrawingIntoSelf-expected.png: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/drawImage-expected.png: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/fill-stroke-clip-reset-path-expected.png: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/fillrect-gradient-zero-stops-expected.png: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/image-pattern-rotate-expected.png: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/patternfill-repeat-expected.png: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/quadraticCurveTo-expected.png: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/setWidthResetAfterForcedRender-expected.png: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-1-expected.png: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-2-expected.png: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-3-expected.png: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-4-expected.png: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-5-expected.png: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-6-expected.png: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-7-expected.png: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/toDataURL-alpha-expected.png: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/zero-size-fill-rect-expected.png: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.gradient.radial.cone.cylinder-expected.txt: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.line.width.basic-expected.txt: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.line.width.transformed-expected.txt: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.path.arcTo.shape.curve1-expected.txt: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.path.arcTo.shape.curve2-expected.txt: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.shadow.enable.blur-expected.txt: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.text.draw.fontface.notinpage-expected.txt: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.transformation.setTransform.skewed-expected.txt: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.transformation.transform.skewed-expected.txt: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-as-image-expected.png: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-expected.png: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-zoom-expected.png: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-fill-repaint-expected.png: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-transformclip-expected.png: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-currentColor-expected.txt: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-fillPath-shadow-expected.txt: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-shadow-expected.txt: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-text-baseline-expected.png: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-transform-skewed-expected.png: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-transforms-during-path-expected.png: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/fillrect-gradient-zero-stops-expected.png: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/image-pattern-rotate-expected.png: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/patternfill-repeat-expected.png: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/quadraticCurveTo-expected.png: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/setWidthResetAfterForcedRender-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/arc360-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-as-image-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-as-image-expected.txt: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-as-image-incremental-repaint-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-as-image-incremental-repaint-expected.txt: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-before-css-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-expected.txt: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-zoom-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-zoom-expected.txt: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-fill-repaint-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-transformclip-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-empty-image-pattern-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-resize-reset-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-text-baseline-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-transform-identity-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-transform-infinity-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-transform-multiply-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-transform-nan-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-transform-non-invertible-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-transform-skewed-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-transforms-during-path-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvasDrawingIntoSelf-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/drawImage-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/fill-stroke-clip-reset-path-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/fillrect-gradient-zero-stops-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/gradient-add-second-start-end-stop-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/image-pattern-rotate-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/patternfill-repeat-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/quadraticCurveTo-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/setWidthResetAfterForcedRender-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-1-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-2-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-3-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-4-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-5-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-6-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/shadow-offset-7-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/toDataURL-alpha-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/zero-size-fill-rect-expected.png: Added.
- platform/chromium/test_expectations.txt:
- platform/chromium/virtual/gpu/README.txt: Added.
- platform/chromium/virtual/gpu/canvas/philip/README.txt: Added.
- platform/chromium/virtual/gpu/fast/canvas/README.txt: Added.
- 6:39 PM Changeset in webkit [109295] by
-
- 1 edit in trunk/ChangeLog
[CMake] Unreviewed, fix build on 64-bit platforms with SHARED_CORE=ON after r109197.
https://bugs.webkit.org/show_bug.cgi?id=79965
This partially reverts r66714, in that whether -fPIC is passed to
the compiler does not depend on the value of SHARED_CORE anymore:
since we always build WTF as a static library, it will always need
-fPIC because our shared libraries are built with it.
- Source/cmake/WebKitHelpers.cmake: Always pass -fPIC to
STATIC_LIBRARY targets.
- 6:38 PM Changeset in webkit [109294] by
-
- 2 edits in trunk/Tools
Switch to using json rather than simplejson now that the master is using Python 2.7.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(loadBuilderConfig):
- 6:28 PM Changeset in webkit [109293] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/fast/regions/select-in-region-crash-expected.txt: Added.
- 6:09 PM Changeset in webkit [109292] by
-
- 2 edits in trunk
[CMake] Unreviewed, fix build on 64-bit platforms with SHARED_CORE=ON after r109197.
This partially reverts r66714, in that whether -fPIC is passed to
the compiler does not depend on the value of SHARED_CORE anymore:
since we always build WTF as a static library, it will always need
-fPIC because our shared libraries are built with it.
- Source/cmake/WebKitHelpers.cmake: Always pass -fPIC to
STATIC_LIBRARY targets.
- 5:56 PM Changeset in webkit [109291] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, marking RegExp.html as FAIL in Chromium/V8
since it requires a fix in V8.
- platform/chromium/test_expectations.txt:
- 5:55 PM Changeset in webkit [109290] by
-
- 12 edits2 adds in trunk
Methods in ShadowTree and TreeScopeAdopter should be multiple shadow roots aware.
https://bugs.webkit.org/show_bug.cgi?id=79768
Reviewed by Hajime Morita.
Source/WebCore:
Some methods in ShadowTree and TreeScopeAdopter were not multiple shadow roots aware.
They should consider multiple shadow roots.
Test: fast/dom/shadow/multiple-shadowroot-adopt.html
- dom/ShadowTree.cpp:
(WebCore::ShadowTree::setParentTreeScope):
(WebCore):
(WebCore::ShadowTree::childNeedsStyleRecalc):
(WebCore::ShadowTree::needsStyleRecalc):
- dom/ShadowTree.h:
(WebCore):
(ShadowTree):
- dom/TreeScopeAdopter.cpp:
(WebCore::shadowTreeFor):
(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveTreeToNewDocument):
(WebCore::TreeScopeAdopter::moveShadowTreeToNewDocument):
(WebCore):
- dom/TreeScopeAdopter.h:
(TreeScopeAdopter):
LayoutTests:
- fast/dom/shadow/multiple-shadowroot-adopt-expected.txt: Added.
- fast/dom/shadow/multiple-shadowroot-adopt.html: Added.
- platform/efl/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- platform/wk2/Skipped:
- 5:34 PM Changeset in webkit [109289] by
-
- 4 edits in trunk/Source/JavaScriptCore
Rubber stamped by Oliver Hunt.
- tests/mozilla/ecma_2/RegExp/constructor-001.js:
- tests/mozilla/ecma_2/RegExp/function-001.js:
- tests/mozilla/ecma_2/RegExp/properties-001.js:
- Check in new test cases results.
- 5:29 PM Changeset in webkit [109288] by
-
- 10 edits2 adds in trunk
[chromium] Add the ability to turn off autoresize.
https://bugs.webkit.org/show_bug.cgi?id=77452
Reviewed by Darin Fisher.
Source/WebCore:
Test: fast/autoresize/turn-off-autoresize.html
- page/FrameView.cpp:
(WebCore::FrameView::enableAutoSizeMode): Fix the code
path for turning off autoresize to set the scrollbars to auto.
Source/WebKit/chromium:
- public/WebView.h:
(WebKit::WebViewImpl::enableAutoResizeMode): Cleaned up the api.
(WebKit::WebViewImpl::disableAutoResizeMode): Added the ability to disable auto-resize.
(WebKit::WebViewImpl::enableAutoResizeMode): Deprecated it.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::enableAutoResizeMode): Adjust for new api.
(WebKit::WebViewImpl::disableAutoResizeMode): Allow turning off autoresize.
(WebKit::WebViewImpl::enableAutoResizeMode): Call the other two apis, but
this api will be deleted shortly.
(WebKit::WebViewImpl::configureAutoResizeMode): Common code.
- src/WebViewImpl.h:
(WebViewImpl): Adjust to new public api.
Tools:
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController): Expose a way to turn off auto-resize.
(LayoutTestController::enableAutoResizeMode): Ditto and adjust to new WebKit api.
(LayoutTestController::disableAutoResizeMode): Ditto.
- DumpRenderTree/chromium/LayoutTestController.h: Ditto.
LayoutTests:
- fast/autoresize/turn-off-autoresize-expected.txt: Added.
- fast/autoresize/turn-off-autoresize.html: Added.
- 5:26 PM Changeset in webkit [109287] by
-
- 2 edits1 move1 delete in trunk/Source/JavaScriptCore
Stop installing JSCLLIntOffsetsExtractor.
Replace the separate TestRegExp and TestAPI xcconfig files with a single ToolExecutable xcconfig file
that derives the product name from the target name. We can then use that xcconfig file for JSCLLIntOffsetsExtractor.
This has the results of setting SKIP_INSTALL = YES for JSCLLIntOffsetsExtractor.
While I was doing this fiddling I noticed that the JSCLLIntOffsetsExtractor target had a custom value
for USER_HEADER_SEARCH_PATHS to allow it to find LLIntDesiredOffsets.h. A better way of doing that is
to add LLIntDesiredOffsets.h to the Xcode project so that it'll be included in the header map. That
allows us to remove the override of USER_HEADER_SEARCH_PATHS entirely. So I did that too!
Reviewed by Filip Pizlo.
- Configurations/TestRegExp.xcconfig: Removed.
- Configurations/ToolExecutable.xcconfig: Renamed from Source/JavaScriptCore/Configurations/TestAPI.xcconfig.
- JavaScriptCore.xcodeproj/project.pbxproj:
- 5:17 PM Changeset in webkit [109286] by
-
- 2 edits in trunk/Source/WebCore
<msubsup> setNeedsLayout() correction
https://bugs.webkit.org/show_bug.cgi?id=79856
Patch by David Barton <Dave Barton> on 2012-02-29
Reviewed by Julien Chaffraix.
m_scripts->setNeedsLayout(true, false); needs to be added to the fix for bug 79274.
No new tests. It's actually difficult to test the need for this with the current code,
because there are a lot of extra setNeedsLayout() calls right now. I caught this after
removing some of those calls that should be redundant, for a future patch. Actually
removing those calls now changes other behavior, due to other bugs, so I'll save all
that for future patches. We should land this fix now though I think, as it could
possibly matter in some cases.
- rendering/mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::layout):
- 5:03 PM Changeset in webkit [109285] by
-
- 6 edits in trunk/Source/WebCore
IsSynchronizingStyleAttributeFlag could be purged.
<http://webkit.org/b/79313>
Reviewed by Anders Carlsson.
We were using IsSynchronizingStyleAttributeFlag to prevent various things from
happening below setAttribute() when serializing the "style" attribute based on
an element's inline style.
Simplify the whole thing by adding a way to set an attribute without triggering
any callbacks (a 'notifyChanged' argument to Element::setAttribute().)
This removes the need for IsSynchronizingStyleAttributeFlag in the first place
and makes StyledElement::updateStyleAttribute() a bit cheaper to boot.
- dom/Element.cpp:
(WebCore::Element::setAttribute):
(WebCore::Element::setAttributeInternal):
(WebCore::Element::willModifyAttribute):
(WebCore::Element::didModifyAttribute):
(WebCore::Element::didRemoveAttribute):
- dom/Element.h:
- dom/Node.h:
- dom/StyledElement.cpp:
(WebCore::StyledElement::updateStyleAttribute):
(WebCore::StyledElement::attributeChanged):
- html/HTMLElement.cpp:
(WebCore::StyledElement::copyNonAttributeProperties):
- 4:33 PM Changeset in webkit [109284] by
-
- 4 edits in trunk/Source/WebKit/blackberry
Autocomplete attribute should apply to textarea's.
https://bugs.webkit.org/show_bug.cgi?id=79929
Patch by Mike Fenton <mifenton@rim.com> on 2012-02-29
Reviewed by Antonio Gomes.
Allow the autocomplete attribute to bubble back to the form setting.
Expand support to include checking autocorrect, autocomplete and
name/id matching to text areas.
Reviewed internally by Nima Ghanavatian and Gen Mak.
- WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::elementSupportsAutocorrect):
(BlackBerry::WebKit::DOMSupport::elementSupportsAutocomplete):
(BlackBerry::WebKit::DOMSupport::elementAttributeState):
- WebKitSupport/DOMSupport.h:
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::inputStyle):
- 4:33 PM Changeset in webkit [109283] by
-
- 1 edit6 adds in trunk/LayoutTests
Rebaseline line-grid tests for Chromium after r109267.
Unreviewed gardening.
- platform/chromium-linux/fast/line-grid/line-align-left-edges-expected.png: Added.
- platform/chromium-linux/fast/line-grid/line-align-right-edges-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/line-grid/line-align-left-edges-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/line-grid/line-align-right-edges-expected.png: Added.
- platform/chromium-win/fast/line-grid/line-align-left-edges-expected.png: Added.
- platform/chromium-win/fast/line-grid/line-align-right-edges-expected.png: Added.
- 4:33 PM Changeset in webkit [109282] by
-
- 2 edits in trunk/Tools
nrwt: make --print trace work with virtual tests
https://bugs.webkit.org/show_bug.cgi?id=79952
Reviewed by Adam Barth.
- Scripts/webkitpy/layout_tests/views/printing.py:
(Printer._print_test_trace):
(Printer._print_baseline):
- 4:27 PM Changeset in webkit [109281] by
-
- 2 edits in trunk/LayoutTests
Mark fast/js/kde/RegExp.html test as failing on Chromium due to
differing V8 behavior. Opened http://code.google.com/p/v8/issues/detail?id=1982
to track this issue in V8.
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 4:14 PM Changeset in webkit [109280] by
-
- 3 edits2 adds in trunk
[chromium] REGRESSION: Cannot drag a file out
https://bugs.webkit.org/show_bug.cgi?id=79817
Reviewed by Ryosuke Niwa.
Source/WebCore:
Temporary fix for file drag out. This change won't be needed once DataTransferItemList
support is better implemented.
Test: platform/chromium/fast/events/drag-downloadURL.html
- platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::types):
LayoutTests:
- platform/chromium/fast/events/drag-downloadURL-expected.txt: Added.
- platform/chromium/fast/events/drag-downloadURL.html: Added.
- 4:11 PM Changeset in webkit [109279] by
-
- 2 edits in trunk/Source/WebCore
Clean up CSSPrimitiveValue::computeLengthDouble().
https://bugs.webkit.org/show_bug.cgi?id=77065
Reviewed by Eric Seidel.
Refactoring only / no behavioral change.
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeLengthDouble):
- 3:59 PM Changeset in webkit [109278] by
-
- 2 edits in trunk/Source/WebCore
Speculative build-fix.
- rendering/RenderImage.cpp:
(WebCore::RenderImage::paintReplaced):
- 3:32 PM Changeset in webkit [109277] by
-
- 7 edits in trunk
Source/WebKit2: WebKit2: didNewFirstVisuallyNonEmptyLayout should be sent to injected bundle
https://bugs.webkit.org/show_bug.cgi?id=79849
Tell the injected bundle about didNewFirstVisuallyNonEmptyLayout (we currently
just tell the UI process).
Reviewed by Beth Dakin.
- WebProcess/InjectedBundle/API/c/WKBundlePage.h: Add didNewFirstVisuallyNonEmptyLayout to version 1.
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::didNewFirstVisuallyNonEmptyLayout): Call through to the
client.
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
(InjectedBundlePageLoaderClient):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidNewFirstVisuallyNonEmptyLayout): Tell the injected
bundle.
Tools: WebKit2: didNewFirstVisuallyNonEmptyLayout should be sent to injected bundle
https://bugs.webkit.org/show_bug.cgi?id=79849
Reviewed by Beth Dakin.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage): Add an entry to the struct.
- 3:28 PM Changeset in webkit [109276] by
-
- 2 edits in trunk/Tools
Removed unused Apple buildslaves from the master configuration
https://bugs.webkit.org/show_bug.cgi?id=79925
Reviewed by Stephanie Lewis.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 3:23 PM Changeset in webkit [109275] by
-
- 16 edits in trunk
Source/JavaScriptCore: RefCounted::deprecatedTurnOffVerifier() should not be deprecated
https://bugs.webkit.org/show_bug.cgi?id=79864
Patch by Filip Pizlo <fpizlo@apple.com> on 2012-02-28
Reviewed by Oliver Hunt.
Removed the word "deprecated" from the name of this method, since this method
should not be deprecated. It works just fine as it is, and there is simply no
alternative to calling this method for many interesting JSC classes.
- parser/SourceProvider.h:
(JSC::SourceProvider::SourceProvider):
- runtime/SymbolTable.h:
(JSC::SharedSymbolTable::SharedSymbolTable):
- wtf/MetaAllocator.cpp:
(WTF::MetaAllocatorHandle::MetaAllocatorHandle):
(WTF::MetaAllocator::allocate):
- wtf/RefCounted.h:
(RefCountedBase):
(WTF::RefCountedBase::turnOffVerifier):
LayoutTests: 'source' property of RegExp instance cannot be ""
https://bugs.webkit.org/show_bug.cgi?id=79938
Reviewed by Oliver Hunt.
15.10.6.4 specifies that RegExp.prototype.toString must return '/' + source + '/',
and also states that the result must be a valid RegularExpressionLiteral. '' is
not a valid RegularExpressionLiteral (since it is a single line comment), and hence
source cannot ever validly be "". If the source is empty, return a different Pattern
that would match the same thing.
- fast/js/kde/RegExp-expected.txt:
- fast/js/kde/script-tests/RegExp.js:
- fast/regex/script-tests/toString.js:
- fast/regex/toString-expected.txt:
- Update these tests to check for the correct result.
- sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A3_T1-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A3_T2-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A3_T3-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A3_T4-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A3_T5-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A4_T2-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A4_T3-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A4_T5-expected.txt:
- Check in failing results, these tests are all incorrect.
- 3:10 PM Changeset in webkit [109274] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-29
- DEPS:
- 3:10 PM Changeset in webkit [109273] by
-
- 14 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=79705
didNewFirstVisuallyNonEmptyLayout should be enhanced to look at size instead
of a raw tally
-and corresponding-
<rdar://problem/10821314>
Reviewed by Dave Hyatt.
Instead of firing didNewFirstVisuallyNonEmptyLayout() when a raw tally of
relevant painted objects has reached a port-defined threshold, this patch
looks at the size of those objects with respect to the view area. The patch
also looks at relevant objects that cannot yet be fully painted, such as
incrementally loading images.
We no longer need a HashSet for the relevant painted objects since Region can
do all of the heavy lifting. We now have a Region for the painted and
unpainted regions. We do need a HashSet for the unpainted objects though,
because we need to know if a painted object needs to be subtracted from the
unpainted region before being added to the painted region.
- page/Page.cpp:
(WebCore):
(WebCore::Page::isCountingRelevantRepaintedObjects):
(WebCore::Page::startCountingRelevantRepaintedObjects):
(WebCore::Page::resetRelevantPaintedObjectCounter):
(WebCore::Page::addRelevantRepaintedObject):
(WebCore::Page::addRelevantUnpaintedObject):
- page/Page.h:
(Page):
New function on Region iterates through the rects and calculates the total
area.
- platform/graphics/Region.cpp:
(WebCore::Region::totalArea):
(WebCore):
- platform/graphics/Region.h:
(Region):
Remove code from these classes since they are not actually relevant objects.
- rendering/InlineBox.cpp:
(WebCore::InlineBox::paint):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::paintReplaced):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint):
All of these other callers send a rect that actually represents their size
(usually the visualOverflowRect) instead of the paintInfo's paintRect, and
they call addRelevantUnpaintedObject when appropriate.
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::paint):
(WebCore::RenderEmbeddedObject::paintReplaced):
- rendering/RenderHTMLCanvas.cpp:
(WebCore::RenderHTMLCanvas::paintReplaced):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::paintReplaced):
- rendering/RenderVideo.cpp:
(WebCore::RenderVideo::paintReplaced):
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::paintReplaced):
- 3:08 PM Changeset in webkit [109272] by
-
- 2 edits2 copies in branches/chromium/1025
Merge 108668 - REGRESSION(r99076): WebKit pastes the trailing newline into a single-line text field
https://bugs.webkit.org/show_bug.cgi?id=79305
Reviewed by Tony Chang.
Source/WebCore:
The bug was caused by ReplacementFragment::m_hasInterchangeNewlineAtEnd not reset even when
text field's beforeTextInserted event handler removed interchange new lines at the end.
Because the event handler is responsible for trimming new lines, we need to recompute the values
for m_hasInterchangeNewlineAt* after the event dispatch.
Test: editing/input/paste-text-ending-with-interchange-newline.html
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::ReplacementFragment):
LayoutTests:
Add a regression test. Also make Markup.dump() dump the shadow DOM of the specififed node.
- editing/input/paste-text-ending-with-interchange-newline-expected.txt: Added.
- editing/input/paste-text-ending-with-interchange-newline.html: Added.
- resources/dump-as-markup.js:
(Markup._get):
(Markup._getShadowHostIfPossible):
Review URL: https://chromiumcodereview.appspot.com/9555006
- 3:03 PM Changeset in webkit [109271] by
-
- 10 edits in trunk
IndexedDB: Resource leak with IDBObjectStore.openCursor
https://bugs.webkit.org/show_bug.cgi?id=79835
Source/WebCore:
IDBCursor object that were never continue()'d to the end would leak due to a
reference cycle with IDBRequest. In addition, the IDBRequest would never be
marked "finished" which would prevent GC from reclaiming it. IDBTransactions
now track and notify IDBCursors to break these references when the transaction
can no longer not process requests.
Reviewed by Tony Chang.
Tests: storage/indexeddb/cursor-continue.html
- storage/IDBCursor.cpp:
(WebCore::IDBCursor::IDBCursor): Register with IDBTransaction bookkeeping.
(WebCore::IDBCursor::continueFunction): Early error if transaction has finished.
(WebCore::IDBCursor::close): Break the reference cycle with IDBRequest, and notify it
that the cursor is finished.
(WebCore):
- storage/IDBCursor.h:
(WebCore):
(IDBCursor):
- storage/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::finishCursor): If there is no request in flight, mark itself as
finished to allow GC.
(WebCore):
(WebCore::IDBRequest::dispatchEvent): Once an in-flight request has been processed,
mark the request as finished if the cursor is finished, to allow GC.
- storage/IDBRequest.h:
(IDBRequest):
- storage/IDBTransaction.cpp: Track open cursors, close them when finished.
(WebCore::IDBTransaction::OpenCursorNotifier::OpenCursorNotifier):
(WebCore):
(WebCore::IDBTransaction::OpenCursorNotifier::~OpenCursorNotifier):
(WebCore::IDBTransaction::registerOpenCursor):
(WebCore::IDBTransaction::unregisterOpenCursor):
(WebCore::IDBTransaction::closeOpenCursors):
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):
- storage/IDBTransaction.h:
(WebCore):
(OpenCursorNotifier):
(IDBTransaction):
LayoutTests:
Ensure that IDBCursor.continue() throws the right exception when transaction is finished.
Reviewed by Tony Chang.
- storage/indexeddb/cursor-continue-expected.txt:
- storage/indexeddb/cursor-continue.html:
- 2:51 PM Changeset in webkit [109270] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Remove suppressions for rubberbanding tests.
These tests were broken by r109183 and should be fixed by r109265.
- platform/chromium/test_expectations.txt:
- 2:47 PM Changeset in webkit [109269] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening, add MAC GPU expectations for 2d.transformation.*
(removed due to MAC CPU config passing in r109257).
- platform/chromium/test_expectations.txt:
- 2:47 PM Changeset in webkit [109268] by
-
- 5 edits in trunk/Source/JavaScriptCore
RefCounted::deprecatedTurnOffVerifier() should not be deprecated
https://bugs.webkit.org/show_bug.cgi?id=79864
Reviewed by Oliver Hunt.
Removed the word "deprecated" from the name of this method, since this method
should not be deprecated. It works just fine as it is, and there is simply no
alternative to calling this method for many interesting JSC classes.
- parser/SourceProvider.h:
(JSC::SourceProvider::SourceProvider):
- runtime/SymbolTable.h:
(JSC::SharedSymbolTable::SharedSymbolTable):
- wtf/MetaAllocator.cpp:
(WTF::MetaAllocatorHandle::MetaAllocatorHandle):
(WTF::MetaAllocator::allocate):
- wtf/RefCounted.h:
(RefCountedBase):
(WTF::RefCountedBase::turnOffVerifier):
- 2:44 PM Changeset in webkit [109267] by
-
- 3 edits6 adds in trunk
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=79940
<rdar://problem/10080189>
Add support in WebKit for an intra-line character grid for Japanese text layout.
Patch logicalLeftOffsetForLine and logicalRightOffsetForLine in order to get the
basic edge snapping grid functionality up and running. See all the FIXMEs in the function for
some of the issues that still have to be dealt with for it to really work well.
Reviewed by Dan Bernstein.
Added new tests in fast/line-grid.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=79940
<rdar://problem/10080189>
Add support in WebKit for an intra-line character grid for Japanese text layout.
New tests for basic left and right alignment of lines in the presence of
floating and positioned objects as well as objects with margins and borders.
Reviewed by Dan Bernstein.
- fast/line-grid/line-align-left-edges.html: Added.
- fast/line-grid/line-align-right-edges.html: Added.
- platform/mac/fast/line-grid/line-align-left-edges-expected.png: Added.
- platform/mac/fast/line-grid/line-align-left-edges-expected.txt: Added.
- platform/mac/fast/line-grid/line-align-right-edges-expected.png: Added.
- platform/mac/fast/line-grid/line-align-right-edges-expected.txt: Added.
- 2:43 PM Changeset in webkit [109266] by
-
- 6 edits in trunk/Tools
nrwt: implement simple 'virtual test suite' support
https://bugs.webkit.org/show_bug.cgi?id=79737
Reviewed by Adam Barth.
Add very basic support for 'virtual test suites' to NRWT:
a virtual suite is a directory that may contain new baselines,
contains a pointer to a "base" directory of tests, and an
optional list of command line arguments to pass to DRT;
it gives us a way to run all of the tests in a given directory
multiple times with multiple (potentially differing) sets of
results and baselines.
This patch implements the support needed for this feature, and
some basic tests, but no actual port will use the feature yet.
This is probably the simplest implementation possible - the
list of virtual suites will be hard-coded into the port's
implementation. One can imagine a more data-driven approach
where the suite instructions are stored in a manifest file
either in LayoutTests (all suites in one file), or per-port,
or per-directory. If this feature ends up being useful we
should probably add something like that so people don't have
to hunt around in the code to add suites.
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.init):
(Port.expected_filename):
(Port.tests):
(Port):
(Port._real_tests):
(Port._driver_class):
(Port.virtual_test_suites):
(Port.virtual_suite):
(Port.virtual_suite.VirtualTestSuite):
(Port.virtual_suite.VirtualTestSuite.init):
(Port.virtual_suite.VirtualTestSuite.repr):
(Port.populated_virtual_test_suites):
(Port._virtual_tests):
(Port.lookup_virtual_test_base):
(Port.lookup_virtual_test_args):
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_find_with_skipped_directories):
- Scripts/webkitpy/layout_tests/port/driver.py:
(DriverInput.init):
(DriverProxy.run_test):
- Scripts/webkitpy/layout_tests/port/test.py:
(TestPort.virtual_test_suites):
(TestDriver.run_test):
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_all):
(MainTest.test_virtual):
- 2:43 PM Changeset in webkit [109265] by
-
- 3 edits in trunk/Source/WebCore
[Chromium] Some Layout Tests in platform/chromium/rubberbanding and platform/chromium/compositing/rubberbanding are failing
https://bugs.webkit.org/show_bug.cgi?id=79878
Reviewed by James Robinson.
Make sure that ScrollableArea::setScrollOffsetFromAnimation doesn't end up
setting the ScrollAnimator's current scroll position by making a new function, scrollPositionChanged,
that both notifyScrollPositionChanged and setScrollOffsetFromAnimation call and move the call to update
the position to notifyScrollPositionChanged.
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::notifyScrollPositionChanged):
(WebCore):
(WebCore::ScrollableArea::scrollPositionChanged):
(WebCore::ScrollableArea::setScrollOffsetFromAnimation):
- platform/ScrollableArea.h:
(ScrollableArea):
- 2:40 PM Changeset in webkit [109264] by
-
- 2 edits in trunk/Tools
nrwt: support more than two drivers in DriverProxy
https://bugs.webkit.org/show_bug.cgi?id=79736
Reviewed by Adam Barth.
Now that we can support per-test command lines for
Drivers, modify DriverProxy to keep a map of running
drivers for each needed command-line; this will allow
us to transparently maintain a pool of appropriately
configured DRTs without having to constantly start and stop
them.
Note that this potentially raises a garbage collection
problem - the number of running DRTs will grow with the
number of different sets of command line args. For now
this is no worse than the current code - if you're running
with pixel tests, you will only need one DRT per worker,
and if you aren't, you'll need two (one for text-only tests,
and one for reftests).
An alternative would be to only ever have one running driver,
and restart the driver as the command line changes, but this
might (?) slow down execution in the text-only case - we
should benchmark this because it would be simpler and possibly
allow us to eliminate DriverProxy altogether.
- Scripts/webkitpy/layout_tests/port/driver.py:
(DriverProxy.init):
(DriverProxy):
(DriverProxy._make_driver):
(DriverProxy.run_test):
(DriverProxy.has_crashed):
(DriverProxy.stop):
(DriverProxy.cmd_line):
(DriverProxy._cmd_line_as_key):
- 2:35 PM Changeset in webkit [109263] by
-
- 5 edits in trunk/Source
[chromium] Don't let invalidation for next frame prevent tile upload
https://bugs.webkit.org/show_bug.cgi?id=79841
Patch by Dana Jansens <danakj@chromium.org> on 2012-02-29
Reviewed by James Robinson.
Source/WebCore:
We currently don't push dirty tiles to the impl thread so there are no
tiles with garbage data on the impl thread. However, this judgement is
overzealous and blocks tiles that get invalidated by WebKit for the
next frame during the paint of the current frame.
Instead, check if a tile is dirty and was not painted for the current
frame when deciding to push the tile to the impl thread. This requires
that we know if a tile was painted during the current frame, which we
can do if we always reset m_updateRect to be empty each frame.
New unit tests: TiledLayerChromiumTest.pushTilesMarkedDirtyDuringPaint
TiledLayerChromiumTest.pushTilesLayerMarkedDirtyDuringPaintOnNextLayer
TiledLayerChromiumTest.pushTilesLayerMarkedDirtyDuringPaintOnPreviousLayer
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::UpdatableTile::isDirtyForCurrentFrame):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::resetUpdateState):
(WebCore):
(WebCore::TiledLayerChromium::prepareToUpdate):
- platform/graphics/chromium/TiledLayerChromium.h:
(TiledLayerChromium):
Source/WebKit/chromium:
- tests/TiledLayerChromiumTest.cpp:
(WTF::TEST):
- 2:30 PM Changeset in webkit [109262] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening, remove some more stale expectations (mostly mac repaint tests).
- platform/chromium/test_expectations.txt:
- 2:13 PM Changeset in webkit [109261] by
-
- 4 edits2 adds in trunk
MediaStream API: MediaStreamTrackList out-of-bounds access fix
https://bugs.webkit.org/show_bug.cgi?id=79889
Reviewed by Adam Barth.
Out-of-bounds access to MediaStreamTrackList ASSERTS instead of returning 0,
this is not according to ecmascript standard. Also fixed a similar issue in MediaStreamList.
Source/WebCore:
Test: fast/mediastream/peerconnection-mediastreamlist.html
- Modules/mediastream/MediaStreamList.cpp:
(WebCore::MediaStreamList::item):
- Modules/mediastream/MediaStreamTrackList.cpp:
(WebCore::MediaStreamTrackList::item):
LayoutTests:
- fast/mediastream/peerconnection-mediastreamlist-expected.txt: Added.
- fast/mediastream/peerconnection-mediastreamlist.html: Added.
- 2:12 PM Changeset in webkit [109260] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening, mark a few more tests as passing.
- platform/chromium/test_expectations.txt:
- 2:11 PM Changeset in webkit [109259] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Upstream the BlackBerry change to platform/graphics/FloatSize.h
https://bugs.webkit.org/show_bug.cgi?id=79893
Reviewed by Antonio Gomes.
Add conversion convenience between WebCore::FloatSize and BlackBerry::Platform::FloatSize.
The porting can't be built yet, no new tests.
- platform/graphics/FloatSize.h:
(Platform):
(FloatSize):
- 2:05 PM Changeset in webkit [109258] by
-
- 2 edits in trunk/Tools
Unreviewed, add myself as a reviewer
- Scripts/webkitpy/common/config/committers.py:
- 1:49 PM Changeset in webkit [109257] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening, remove a bunch of expectations for now-passing tests.
- platform/chromium/test_expectations.txt:
- 1:41 PM Changeset in webkit [109256] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Upstream the BlackBerry change to platform/graphics/FloatRect.h
https://bugs.webkit.org/show_bug.cgi?id=79891
Reviewed by Antonio Gomes.
Add conversion convenience between WebCore::FloatRect and BlackBerry::Platform::FloatRect.
The porting can't be built yet, no new tests.
- platform/graphics/FloatRect.h:
(Platform):
(FloatRect):
- 1:36 PM Changeset in webkit [109255] by
-
- 16 edits in trunk
Make use of CG rounded-rect primitives
https://bugs.webkit.org/show_bug.cgi?id=79932
<rdar://problem/9274953>
Reviewed by Simon Fraser.
Dispatch to potentially platform-specific rounded rectangle path
construction from addPathForRoundedRect. Make use of this to call
wkCGPathAddRoundedRect on Lion and above, as long as the rounded
corners are all equivalent.
No new tests, as this is covered by many that use rounded corners,
and is only a performance improvement.
- WebCore.exp.in:
- platform/graphics/Path.cpp:
(WebCore::Path::addRoundedRect):
(WebCore):
(WebCore::Path::addPathForRoundedRect):
- platform/graphics/Path.h:
(Path):
- platform/graphics/cg/PathCG.cpp:
(WebCore::Path::addPathForRoundedRect):
(WebCore):
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
Add wkCGPathAddRoundedRect.
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- 1:28 PM Changeset in webkit [109254] by
-
- 2 edits in trunk/Source/WebKit/mac
Crash at -[WebFrame(WebInternal) _setTypingStyle:withUndoAction:]
https://bugs.webkit.org/show_bug.cgi?id=79937
<rdar://problem/10942936>
Reviewed by Dan Bernstein.
- WebView/WebFrame.mm:
(-[WebFrame _setTypingStyle:withUndoAction:]): Adding a null check.
- 1:27 PM Changeset in webkit [109253] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening, mark some tests as passing on GPU tests.
- platform/chromium/test_expectations.txt:
- 1:25 PM Changeset in webkit [109252] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Upstream the BlackBerry change to platform/graphics/FloatPoint.h
https://bugs.webkit.org/show_bug.cgi?id=79887
Reviewed by Antonio Gomes.
Add conversion convenience between WebCore::FloatPoint and BlackBerry::Platform::FloatPoint.
The porting can't be built yet, no new tests.
- platform/graphics/FloatPoint.h:
(Platform):
(FloatPoint):
- 1:17 PM Changeset in webkit [109251] by
-
- 13 edits2 adds in trunk
ShadowRoot need innerHTML
https://bugs.webkit.org/show_bug.cgi?id=78473
Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2012-02-29
Reviewed by Hajime Morita.
Source/WebCore:
Refactor code for sharing common code between HTMLElement & ShadowRoot.
Implement innerHTML attribute for ShadowRoot.
Test: fast/dom/shadow/shadow-root-innerHTML.html
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::cloneNode):
(WebCore):
(WebCore::ShadowRoot::innerHTML):
(WebCore::ShadowRoot::setInnerHTML):
- dom/ShadowRoot.h:
(ShadowRoot):
- dom/ShadowRoot.idl:
- editing/markup.cpp:
(WebCore::urlToMarkup):
(WebCore):
(WebCore::createFragmentFromSource):
(WebCore::hasOneChild):
(WebCore::hasOneTextChild):
(WebCore::replaceChildrenWithFragment):
(WebCore::replaceChildrenWithText):
- editing/markup.h:
- html/HTMLElement.cpp:
(WebCore):
LayoutTests:
Implement innerHTML attribute for ShadowRoot.
- fast/dom/shadow/shadow-root-innerHTML-expected.txt: Added.
- fast/dom/shadow/shadow-root-innerHTML.html: Added.
- platform/qt/Skipped: Added test case in Skipped as ShadowRoot is supported by Chromium only.
- platform/mac/Skipped: ditto.
- platform/win/Skipped: ditto.
- platform/wincairo/Skipped: ditto.
- platform/wk2/Skipped: ditto.
- 1:15 PM Changeset in webkit [109250] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening, mark a test as waiting for rebaselining after a skia update.
- platform/chromium/test_expectations.txt:
- 1:13 PM Changeset in webkit [109249] by
-
- 2 edits in trunk/Source/WebKit2
CFURLDownloadScheduleWithCurrentMessageQueue only exists on Windows
https://bugs.webkit.org/show_bug.cgi?id=79936
Reviewed by Brady Eidson.
CFURLDownloadScheduleWithCurrentMessageQueue only exists on Windows
platforms. Non-Windows platforms that use CFNetwork-based downloads
should omit this call.
- WebProcess/Downloads/cfnet/DownloadCFNet.cpp:
(WebKit::Download::start):
- 1:10 PM Changeset in webkit [109248] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed gardening, remove incorrect platform-specific expectation.
- platform/chromium-win/fast/events/message-port-multi-expected.txt: Removed.
- 1:03 PM Changeset in webkit [109247] by
-
- 3 edits in branches/subpixellayout/Source/WebCore/rendering
Fixing table border painting and moving the rounding of paint offsets to InlineTextBoxes from RenderBlock.
- 12:49 PM Changeset in webkit [109246] by
-
- 4 edits in trunk/Source/WebCore
Stop doubling maximalOutlineSize during painting
https://bugs.webkit.org/show_bug.cgi?id=79724
Reviewed by Tony Chang.
Refactoring only, covered by existing tests (mostly repaint ones).
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::shouldPaint):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintCollapsedBorders):
Introduce a local repaint rectangle that we inflate by the maximalOutlineSize
to simplify the comparison logic. Also tried to make it clearer what's going on
by tweaking the existing code.
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::paintObject):
Remove the doubling.
- 12:40 PM Changeset in webkit [109245] by
-
- 3 edits2 adds in trunk
Crash when changing list marker locations
https://bugs.webkit.org/show_bug.cgi?id=79681
Patch by Ken Buchanan <kenrb@chromium.org> on 2012-02-29
Reviewed by David Hyatt.
Source/WebCore:
This fixes a regression crash from r108548.
There are some conditions where removing the anonymous block
parent at that point can cause problems. One is when there is
a continuation from it, and another when it is a sibling of
lineBoxParent and it causes lineBoxParent to be deleted
incidentally. This patch delays the destruction until after
lineBoxParent has been used and makes an exception for
continuations.
- rendering/RenderListItem.cpp:
(WebCore::RenderListItem::updateMarkerLocation)
LayoutTests:
This test exercises the crashing condition for bug 79681 where an
anonymous block was being removed from the render tree inappropriately.
- fast/lists/remove-listmarker-from-anonblock-with-continuation-crash-expected.txt: Added
- fast/lists/remove-listmarker-from-anonblock-with-continuation-crash.html: Added
- 12:33 PM Changeset in webkit [109244] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening, further mark stop-animation-on-suspend.html as crashy on Windows.
- platform/chromium/test_expectations.txt:
- 12:20 PM Changeset in webkit [109243] by
-
- 6 edits in branches/subpixellayout/Source/WebCore/platform
Change RenderTheme internals back to int for mac and qt ports on branch.
- 12:04 PM Changeset in webkit [109242] by
-
- 12 edits in trunk/Tools
Add more tests for web intents
https://bugs.webkit.org/show_bug.cgi?id=79527
Patch by Greg Billock <gbillock@google.com> on 2012-02-29
Reviewed by Adam Barth.
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::sendWebIntentResponse):
- DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
(WebViewHost::currentIntentRequest):
- 12:02 PM Changeset in webkit [109241] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] We should not add NetscapeBrowserFuncs.cpp as header
https://bugs.webkit.org/show_bug.cgi?id=79847
Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-02-29
Reviewed by Alexey Proskuryakov.
- Target.pri: Fix typo, so we can add ".h" file instead.
- 11:59 AM Changeset in webkit [109240] by
-
- 7 edits in trunk
Writable attribute not set correctly when redefining an accessor to a data descriptor
https://bugs.webkit.org/show_bug.cgi?id=79931
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
- runtime/JSObject.cpp:
(JSC::JSObject::defineOwnProperty):
- use attributesOverridingCurrent instead of attributesWithOverride.
- runtime/PropertyDescriptor.cpp:
- runtime/PropertyDescriptor.h:
- remove attributesWithOverride - attributesOverridingCurrent does the same thing.
LayoutTests:
- fast/js/Object-defineProperty-expected.txt:
- fast/js/script-tests/Object-defineProperty.js:
- Added tests.
- 11:54 AM Changeset in webkit [109239] by
-
- 3011 edits834 copies352 adds138 deletes in branches/subpixellayout
Merging trunk changes up until r109226 into subpixel branch.
- 11:53 AM Changeset in webkit [109238] by
-
- 12 edits2 adds in trunk
[BlackBerry] Add support for FLAC audio and OGG/Vorbis audio
https://bugs.webkit.org/show_bug.cgi?id=79519
Patch by Max Feil <mfeil@rim.com> on 2012-02-29
Reviewed by Antonio Gomes.
Source/WebCore:
A layout test already exists for OGG. We do not support OGG
video at this time, only audio.
Test: media/media-can-play-flac-audio.html
- platform/blackberry/MIMETypeRegistryBlackBerry.cpp:
(WebCore):
Source/WebKit/blackberry:
- Api/WebSettings.cpp:
(BlackBerry::WebKit::mimeTypeAssociationMap):
LayoutTests:
A layout test already exists for OGG. We do not support OGG
video at this time, only audio.
- media/media-can-play-flac-audio-expected.txt: Added.
- media/media-can-play-flac-audio.html: Added.
- platform/chromium/test_expectations.txt:
- platform/efl/Skipped:
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- 11:51 AM Changeset in webkit [109237] by
-
- 9 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=79868
Overlay scrollbars should respond to AppKit's NSEventPhaseMayBegin
-and corresponding-
<rdar://problem/10688637>
Reviewed by Anders Carlsson.
Scrollbars are currently drawn on the main thread even when scrolling happens
on the scrolling thread, so we have to call back to the main thread for the
time being to make the right drawing calls for NSEventPhaseMayBegin.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::handleWheelEventPhase):
(WebCore):
- page/scrolling/ScrollingCoordinator.h:
(ScrollingCoordinator):
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::handleWheelEventPhase):
(WebCore):
- page/scrolling/ScrollingTree.h:
- page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::handleWheelEvent):
- platform/ScrollAnimator.h:
(WebCore::ScrollAnimator::handleWheelEventPhase):
(ScrollAnimator):
Call into AppKit on NSEventPhaseMayBegin.
- platform/mac/ScrollAnimatorMac.h:
(ScrollAnimatorMac):
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::mayBeginScrollGesture):
(WebCore):
(WebCore::ScrollAnimatorMac::handleWheelEventPhase):
(WebCore::ScrollAnimatorMac::handleWheelEvent):
- 11:51 AM Changeset in webkit [109236] by
-
- 6 edits7 adds in trunk
Add more tests for web intents
https://bugs.webkit.org/show_bug.cgi?id=79527
Patch by Greg Billock <gbillock@google.com> on 2012-02-29
Reviewed by Adam Barth.
Tools:
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::sendWebIntentResponse):
- DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
(WebViewHost::currentIntentRequest):
LayoutTests:
- webintents/resources/web-intents-testing.js: Added.
(onSuccess):
(onFailure):
(startIntentWithCallbacks):
(simulateButtonPress):
- webintents/web-intents-failure-expected.txt: Added.
- webintents/web-intents-failure.html: Added.
- webintents/web-intents-invoke-expected.txt: Added.
- webintents/web-intents-invoke.html: Added.
- webintents/web-intents-reload.html:
- webintents/web-intents-reply-expected.txt: Added.
- webintents/web-intents-reply.html: Added.
- 11:48 AM Changeset in webkit [109235] by
-
- 2 edits in trunk/Tools
perftestsrunner can call printer.write() after printer.cleanup()
https://bugs.webkit.org/show_bug.cgi?id=79872
Reviewed by Ryosuke Niwa.
This patch fixes a unittest that was incorrectly calling
PerfTestsRunner.run() twice (which led to a weird state in the
printer object).
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(MainTest.test_run_with_upload_json):
- 11:40 AM Changeset in webkit [109234] by
-
- 2 edits in trunk/Source/WebKit2
When invoking Lookup while zoomed in, the highlighted word renders out of line
<rdar://problem/10812527>
Reviewed by Simon Fraser.
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDictionaryLookupForRange):
Make sure to scale the ascent when determining the origin for the overlay.
- 11:08 AM Changeset in webkit [109233] by
-
- 2 edits1 add in trunk/LayoutTests
Unreviewed: updating expectations for chromium (error messages)
- platform/chromium/fast/events/message-port-multi-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 10:56 AM Changeset in webkit [109232] by
-
- 2 edits in trunk/Tools
[Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
https://bugs.webkit.org/show_bug.cgi?id=76546
Reviewed by Simon Hausmann.
Revert the workaround introduced in r107868 and reintroduce
the qml binding so we can test the code path that we are more
interested in. The reason that it did not work before is that
we don't have an active platform window which we now workaround
by propagating the resize through QWindowSystemInterface.
- WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::WrapperWindow::handleStatusChanged):
(WTR::PlatformWebView::resizeTo):
- 10:55 AM Changeset in webkit [109231] by
-
- 18 edits in trunk
Full screen video volume slider has "progress bar"
https://bugs.webkit.org/show_bug.cgi?id=79812
Reviewed by Eric Carlson.
Source/WebCore:
No new tests; strictly a platform-specific look-and-feel change.
The full-screen volume slider has a "media-slider"" appearance, which is rendering as if
the volume slider has a "progress". Make a concrete "media-fullscreen-volume-slider" appearance
which has the correct look-and-feel.
Add two new appearance keywords, media-fullscreen-volume-slider and thumb, and their associated
types and CSS keywords:
- css/CSSValueKeywords.in:
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- html/shadow/MediaControlElements.h:
- platform/ThemeTypes.h:
Handle the new slider and thumb types when rendering:
- rendering/RenderMediaControls.cpp:
(WebCore::RenderMediaControls::adjustMediaSliderThumbSize):
(WebCore::RenderMediaControls::paintMediaControlsPart):
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paint):
- rendering/RenderTheme.h:
(WebCore::RenderTheme::paintMediaFullScreenVolumeSliderTrack):
(WebCore::RenderTheme::paintMediaFullScreenVolumeSliderThumb):
- rendering/RenderThemeMac.h:
(RenderThemeMac):
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::adjustMediaSliderThumbSize):
(WebCore::RenderThemeMac::paintMediaFullScreenVolumeSliderTrack):
(WebCore::RenderThemeMac::paintMediaFullScreenVolumeSliderThumb):
- rendering/RenderMediaControlsChromium.cpp:
(WebCore::RenderMediaControlsChromium::paintMediaControlsPart):
- accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySlider::orientation): Mark the fullscreen volume slider as horizontal.
- html/shadow/SliderThumbElement.cpp:
(WebCore::RenderSliderThumb::updateAppearance): Give MediaFullScreenVolumeSliderParts
MediaFullScreenVolumeSliderThumbParts.
- css/fullscreenQuickTime.css: Change the styles for the fullscreen slider, min, and max buttons.
(video:-webkit-full-screen::-webkit-media-controls-fullscreen-volume-min-button):
(video:-webkit-full-screen::-webkit-media-controls-fullscreen-volume-slider):
(video:-webkit-full-screen::-webkit-media-controls-fullscreen-volume-max-button):
- html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::reset): Set the value of the fullscreen volume slider
when resetting.
WebKitLibraries:
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- win/include/WebKitSystemInterface/WebKitSystemInterface.h:
- win/lib/WebKitSystemInterface.lib:
- 10:53 AM WebKitGTK/1.8.x edited by
- Ad d zoom-text only patches (diff)
- 10:51 AM Changeset in webkit [109230] by
-
- 3 edits in trunk/Source/WebKit2
[GTK] Use text or page zoom factor in WebKitWebView depending on zoom-text-only
https://bugs.webkit.org/show_bug.cgi?id=75252
Reviewed by Gustavo Noronha Silva.
- UIProcess/API/gtk/WebKitWebView.cpp:
(zoomTextOnlyChanged): Update text/page zoom factor when
zoom-text-only setting changes.
(webkitWebViewSetSettings): Helper function to set the settings
object for the web view, initializing the settings for the page
and connecting to notify::zoom-text-only signal.
(webkitWebViewConstructed): Use webkitWebViewSetSettings().
(webkit_web_view_set_settings): Use webkitWebViewSetSettings() and
disconnect from the notify::zoom-text-only signal of the previous
settings object.
(webkit_web_view_set_zoom_level): Set text/page zoom factor
depending on WebKitSettings:zoom-text-only property.
(webkit_web_view_get_zoom_level): Get text/page zoom factor
depending on WebKitSettings:zoom-text-only property.
- UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewZoomLevel):
- 10:45 AM Changeset in webkit [109229] by
-
- 5 edits in trunk/Source/WebKit2
[GTK] Add zoom-text-only setting to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=75249
Reviewed by Gustavo Noronha Silva.
To set whether zoom level of web view should affect only the text
or all page contents. It's disabled by default.
- UIProcess/API/gtk/WebKitSettings.cpp:
(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init): Add WebKitSettings:zoom-text-only
property.
(webkit_settings_set_zoom_text_only): Set
WebKitSettings:zoom-text-only.
(webkit_settings_get_zoom_text_only): Get
WebKitSettings:zoom-text-only.
- UIProcess/API/gtk/WebKitSettings.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new
symbols.
- UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(testWebKitSettings):
- 10:29 AM WebKitGTK/1.8.x edited by
- Add fins api commits (diff)
- 10:15 AM Changeset in webkit [109228] by
-
- 3 edits in trunk/Source/WebKit2
DidFindString should be emitted even if FindOptionsShowOverlay is not enabled
https://bugs.webkit.org/show_bug.cgi?id=76522
Reviewed by Darin Adler.
DidFindString message should be issued always even if neither
FindOptionsShowOverlay or FindOptionsShowHighlight are
provided. The difference is that if any of those flags are present
the find operation will look for all the appearances of the text
in the web view, otherwise it will just look and report the next
occurrence.
This patch removes the temporary workaround added in r109222 to
the WebKitFindController unit tests.
- UIProcess/API/gtk/tests/TestWebKitFindController.cpp:
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::findString):
- 10:08 AM Changeset in webkit [109227] by
-
- 3 edits in trunk/Source/WebCore
Applying region style should not need to access parent rules
https://bugs.webkit.org/show_bug.cgi?id=79910
Reviewed by Andreas Kling.
Currently CSSStyleSelector::applyProperties looks into parent rules to see if a rule is
part of region style. The plan is to eliminate the rule parent pointer so this needs to be refactored.
Add a bit to RuleData to indicate if the StyleRule is part of a region style.
- css/CSSStyleSelector.cpp:
(RuleData):
(WebCore::RuleData::isInRegionRule):
(RuleSet):
(WebCore::CSSStyleSelector::addMatchedProperties):
(WebCore::CSSStyleSelector::sortAndTransferMatchedRules):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- css/CSSStyleSelector.h:
(CSSStyleSelector):
- 9:55 AM Changeset in webkit [109226] by
-
- 2 edits in trunk
Unreviewed. Bump WebKitGTK+ version number.
- configure.ac: Bump version number to 1.9.0 now that we branched
for 1.8.
- 9:51 AM Changeset in webkit [109225] by
-
- 2 edits in trunk
Unreviewed. Fix GTK+ build.
- Source/autotools/symbols.filter: Add symbol.
- 9:44 AM Changeset in webkit [109224] by
-
- 3 edits in trunk/Source/JavaScriptCore
Add JSCore symbol exports needed by wx port
https://bugs.webkit.org/show_bug.cgi?id=77280
Reviewed by Hajime Morita.
- 9:44 AM WebKitGTK/AddingNewWebKit2API edited by
- (diff)
- 9:40 AM Changeset in webkit [109223] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [InspectorIndexedDB] Add refresh to IndexedDB support.
https://bugs.webkit.org/show_bug.cgi?id=79695
Reviewed by Pavel Feldman.
- inspector/front-end/IndexedDBViews.js:
(WebInspector.IDBDataView):
(WebInspector.IDBDataView.prototype._refreshButtonClicked):
(WebInspector.IDBDataView.prototype.get statusBarItems):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.IndexedDBTreeElement):
(WebInspector.IndexedDBTreeElement.prototype.onattach):
(WebInspector.IndexedDBTreeElement.prototype._handleContextMenuEvent):
(WebInspector.IDBDatabaseTreeElement.prototype.onattach):
(WebInspector.IDBDatabaseTreeElement.prototype._handleContextMenuEvent):
(WebInspector.IDBDatabaseTreeElement.prototype._refreshIndexedDB):
- 9:37 AM Changeset in webkit [109222] by
-
- 11 edits3 adds in trunk/Source/WebKit2
[GTK] [WK2] Add Find API
https://bugs.webkit.org/show_bug.cgi?id=76070
Reviewed by Martin Robinson.
This patch adds a new public find API for the Gtk+ WK2 port. It
defines a new object called WebKitFindController owned by each
WebKitWebView. Clients will use this new object to search strings
in the WebKitWebView.
Changes include also documentation and unit tests for the new
public API.
- GNUmakefile.am:
- UIProcess/API/gtk/WebKitDefines.h:
- UIProcess/API/gtk/WebKitFindController.cpp: Added.
(didFindString): implementation of the WKPage Find interface.
(didFailToFindString): Ditto.
(didCountStringMatches): Ditto.
(webkit_find_controller_init):
(getWKPageFromWebKitWebView):
(webkitFindControllerConstructed):
(webkitFindControllerGetProperty):
(webkitFindControllerSetProperty):
(webkitFindControllerFinalize):
(webkit_find_controller_class_init):
(webkit_find_controller_get_search_text):
(webkit_find_controller_get_options):
(webkit_find_controller_get_max_match_count):
(webkit_find_controller_get_web_view):
(webKitFindControllerPerform):
(webKitFindControllerSetSearchData):
(webkit_find_controller_search): asynchronously looks for the
search string in the WebKitWebView.
(webkit_find_controller_search_finish): unhighlights text matches.
(webkit_find_controller_search_next):
(webkit_find_controller_search_previous):
(webkit_find_controller_count_matches): asynchronously counts the
number of matches of the search string in the WebKitWebView.
- UIProcess/API/gtk/WebKitFindController.h: Added.
- UIProcess/API/gtk/WebKitPrivate.h:
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_get_find_controller): returns the
WebKitFindController instance owned by the WebKitWebView.
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
- UIProcess/API/gtk/docs/webkit2gtk.types:
- UIProcess/API/gtk/tests/GNUmakefile.am:
- UIProcess/API/gtk/tests/TestWebKitFindController.cpp: Added.
(testFindControllerTextFound):
(testFindControllerTextNotFound):
(testFindControllerMatchCount):
(testFindControllerMaxMatchCount):
(testFindControllerNext):
(testFindControllerPrevious):
(testFindControllerCountedMatches):
(testFindControllerOptions):
(testFindControllerInstance):
(testFindControllerGetters):
(testFindControllerHide):
(beforeAll):
(afterAll):
- UIProcess/API/gtk/webkit2.h:
- 9:35 AM Changeset in webkit [109221] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: timeline markers are not shown on the timeline panel
https://bugs.webkit.org/show_bug.cgi?id=79921
Reviewed by Pavel Feldman.
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline.addTimestampRecords):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
- 9:07 AM Changeset in webkit [109220] by
-
- 2 edits in trunk/Source/WebCore
Align InlineBox::m_expansion to a byte boundary
https://bugs.webkit.org/show_bug.cgi?id=79761
Add a bit to m_expansion to align a byte boundary.
This will make valgrind memcheck happy.
I confirmed sizeof(InlineBox) is unchanged.
Reviewed by Hajime Morita.
No new tests. No behavior changes.
- rendering/InlineBox.h:
(InlineBox): Aligned m_expansion to a byte boundary.
- 8:51 AM Changeset in webkit [109219] by
-
- 3 edits in trunk/Source/WebCore
Do not iterate all tiles for resizing when the content didn't change
https://bugs.webkit.org/show_bug.cgi?id=79787
Reviewed by Simon Hausmann.
- platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::createTiles):
- 8:43 AM Changeset in webkit [109218] by
-
- 3 edits2 adds in trunk
Crash in WebCore::CompositeEditCommand::insertNodeAt
https://bugs.webkit.org/show_bug.cgi?id=67764
Patch by Parag Radke <parag@motorola.com> on 2012-02-29
Reviewed by Ryosuke Niwa.
Source/WebCore:
If caret position after deletion and destination position coincides then
removing the node will result in removing the destination node also. Hence crash.
Test: editing/deleting/delete-block-merge-contents-025.html
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::cleanupAfterDeletion):
If the caret position after delete and the destination position
renderes at the same place, pruning the node and making an early exit.
LayoutTests:
Added a test case to test deletion when caret position after deletion and
destination postion renders at the same place.
- editing/deleting/delete-block-merge-contents-025-expected.txt: Added.
- editing/deleting/delete-block-merge-contents-025.html: Added.
- 8:15 AM LayoutUnit edited by
- Link directly instead of using Google redirector (diff)
- 8:08 AM Changeset in webkit [109217] by
-
- 36 edits33 adds in trunk/LayoutTests
2012-02-29 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Final set of pixel tests for Snow Leopard, svg/ passes with tolerance 0 again,
despite one known flaky test and 2 known failures that affect Lion as well.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/linking-a-05-t-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/paths-data-02-t-expected.png:
- platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png: Added.
- platform/mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.png: Added.
- platform/mac-snowleopard/svg/css/group-with-shadow-expected.png:
- platform/mac-snowleopard/svg/custom/gradient-rotated-bbox-expected.png: Added.
- platform/mac-snowleopard/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.png: Added.
- platform/mac-snowleopard/svg/custom/marker-opacity-expected.png: Added.
- platform/mac-snowleopard/svg/custom/shapes-supporting-markers-expected.png:
- platform/mac-snowleopard/svg/custom/zero-path-square-cap-rendering2-expected.png: Added.
- platform/mac-snowleopard/svg/filters/filter-placement-issue-expected.png: Added.
- platform/mac-snowleopard/svg/filters/filter-refresh-expected.png: Added.
- platform/mac-snowleopard/svg/filters/filter-rounding-issues-expected.png: Added.
- platform/mac-snowleopard/svg/filters/filter-source-position-expected.png: Added.
- platform/mac-snowleopard/svg/filters/filter-width-update-expected.png:
- platform/mac-snowleopard/svg/filters/filterRes-expected.png: Added.
- platform/mac-snowleopard/svg/filters/filterRes1-expected.png: Added.
- platform/mac-snowleopard/svg/filters/filterRes2-expected.png: Added.
- platform/mac-snowleopard/svg/filters/filterRes3-expected.png: Added.
- platform/mac-snowleopard/svg/filters/filteredImage-expected.png: Added.
- platform/mac-snowleopard/svg/filters/parent-children-with-same-filter-expected.png: Added.
- platform/mac-snowleopard/svg/filters/shadow-on-filter-expected.png: Added.
- platform/mac-snowleopard/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
- platform/mac-snowleopard/svg/filters/subRegion-in-userSpace-expected.png: Added.
- platform/mac-snowleopard/svg/filters/subRegion-one-effect-expected.png:
- platform/mac-snowleopard/svg/filters/subRegion-two-effects-expected.png:
- platform/mac-snowleopard/svg/foreignObject/fO-parent-display-changes-expected.png: Added.
- platform/mac-snowleopard/svg/foreignObject/filter-expected.png: Added.
- platform/mac-snowleopard/svg/foreignObject/text-tref-02-b-expected.png:
- platform/mac-snowleopard/svg/hixie/perf/001-expected.png:
- platform/mac-snowleopard/svg/hixie/perf/002-expected.png:
- platform/mac-snowleopard/svg/hixie/perf/005-expected.png: Added.
- platform/mac-snowleopard/svg/hixie/perf/006-expected.png: Added.
- platform/mac-snowleopard/svg/hixie/perf/007-expected.png:
- platform/mac-snowleopard/svg/repaint/filter-child-repaint-expected.png: Added.
- platform/mac-snowleopard/svg/repaint/filter-repaint-expected.png:
- platform/mac-snowleopard/svg/repaint/image-href-change-expected.png: Added.
- platform/mac-snowleopard/svg/repaint/image-with-clip-path-expected.png: Added.
- platform/mac-snowleopard/svg/repaint/inner-svg-change-viewPort-relative-expected.png: Added.
- platform/mac-snowleopard/svg/text/select-textLength-spacing-squeeze-2-expected.png:
- platform/mac-snowleopard/svg/text/select-textLength-spacing-stretch-4-expected.png:
- platform/mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.png:
- platform/mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.png:
- platform/mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.png:
- platform/mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.png:
- platform/mac-snowleopard/svg/text/selection-background-color-expected.png: Added.
- platform/mac-snowleopard/svg/text/text-align-01-b-expected.png:
- platform/mac-snowleopard/svg/text/text-align-05-b-expected.png:
- platform/mac-snowleopard/svg/text/text-align-06-b-expected.png:
- platform/mac-snowleopard/svg/text/text-fill-opacity-expected.png: Added.
- platform/mac-snowleopard/svg/text/text-path-01-b-expected.png:
- platform/mac-snowleopard/svg/text/text-spacing-01-b-expected.png:
- platform/mac-snowleopard/svg/text/text-text-01-b-expected.png:
- platform/mac-snowleopard/svg/text/text-text-04-t-expected.png:
- platform/mac-snowleopard/svg/text/text-text-05-t-expected.png:
- platform/mac-snowleopard/svg/text/text-text-07-t-expected.png:
- platform/mac-snowleopard/svg/text/text-tselect-02-f-expected.png: Added.
- platform/mac-snowleopard/svg/text/tspan-dynamic-positioning-expected.png: Added.
- platform/mac-snowleopard/svg/transforms/animated-path-inside-transformed-html-expected.png:
- platform/mac-snowleopard/svg/transforms/text-with-mask-with-svg-transform-expected.png:
- platform/mac-snowleopard/svg/webarchive/svg-feimage-subresources-expected.png: Added.
- platform/mac-snowleopard/svg/wicd/test-rightsizing-b-expected.png:
- platform/mac-snowleopard/svg/zoom/page/zoom-background-images-expected.png: Added.
- platform/mac-snowleopard/svg/zoom/page/zoom-mask-with-percentages-expected.png:
- platform/mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
- platform/mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
- platform/mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- 7:59 AM Changeset in webkit [109216] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: remove calculator's updateBoundaries in the timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=79907
Reviewed by Yury Semikhatsky.
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkBaseCalculator.prototype.computeBarGraphLabels):
(WebInspector.NetworkBaseCalculator.prototype.formatTime):
(WebInspector.NetworkTimeCalculator.prototype.computeBarGraphLabels):
(WebInspector.NetworkTimeCalculator.prototype.formatTime):
(WebInspector.NetworkTransferTimeCalculator.prototype.formatTime):
(WebInspector.NetworkTransferDurationCalculator.prototype.formatTime):
- inspector/front-end/TimelineGrid.js:
(WebInspector.TimelineGrid.prototype.updateDividers):
- inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewCalculator.prototype.formatTime):
(WebInspector.TimelineStartAtZeroOverview):
(WebInspector.TimelineStartAtZeroOverview.prototype.update):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._toggleStartAtZeroButtonClicked):
(WebInspector.TimelinePanel.prototype._refresh):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelinePanel.prototype.get timelinePaddingLeft):
(WebInspector.TimelineCalculator):
(WebInspector.TimelineCalculator.prototype.setWindow):
(WebInspector.TimelineCalculator.prototype.setRecords):
(WebInspector.TimelineCalculator.prototype.formatTime):
(WebInspector.TimelineFitInWindowCalculator):
(WebInspector.TimelineFitInWindowCalculator.prototype.setWindow):
(WebInspector.TimelineFitInWindowCalculator.prototype.setRecords):
- inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.Record.prototype.generatePopupContent):
- 7:46 AM Changeset in webkit [109215] by
-
- 20 edits54 adds in trunk/LayoutTests
Add harness to sample W3C SVG animation tests
https://bugs.webkit.org/show_bug.cgi?id=79784
Reviewed by Hajime Morita.
Make it possible to load external SVG documents within the svg/animations testing harness,
to sample the vanilla testcases from W3C-SVG-1.1 at certain points, specific to each file.
The only thing we have to change is to give the <animate> elements an id, so that its start
time and duration can be queried. This is the only change needed in the *.svg files that we
want to sample.
We can now compare the animation in Opera/FF and WebKit, thus making automatized tests of
these SMIL testcases possible (baseVal/animVal dump at certain time, computedStyle etc.).
Add tests covering the first ~ 20 W3C animation tests. Already found one regresion:
- animate-elem-14-t.svg: <animate attributeName="width" calcMode="discrete" values="300;255;180;30" keyTimes="0;.2;.4;.6" begin="0s" dur="10s" fill="freeze"/>
- animate-elem-18-t.svg <animate attributeName="width" calcMode="discrete" values="300;255;180;30" keyTimes="0;.2;.6;.8" begin="0s" dur="10s" fill="freeze"/>
The last keyTime isn't correctly respected, seems to be equal to 1.0 - filed bug 79786.
The baseVal tests are still commented out, as we fail them all, as we animate the baseVal, instead of the animVal.
This will be fixed in the next follow-up patches.
- svg/W3C-SVG-1.1/animate-elem-03-t.svg:
- svg/W3C-SVG-1.1/animate-elem-04-t.svg:
- svg/W3C-SVG-1.1/animate-elem-05-t.svg:
- svg/W3C-SVG-1.1/animate-elem-06-t.svg:
- svg/W3C-SVG-1.1/animate-elem-07-t.svg:
- svg/W3C-SVG-1.1/animate-elem-08-t.svg:
- svg/W3C-SVG-1.1/animate-elem-09-t.svg:
- svg/W3C-SVG-1.1/animate-elem-10-t.svg:
- svg/W3C-SVG-1.1/animate-elem-11-t.svg:
- svg/W3C-SVG-1.1/animate-elem-12-t.svg:
- svg/W3C-SVG-1.1/animate-elem-13-t.svg:
- svg/W3C-SVG-1.1/animate-elem-14-t.svg:
- svg/W3C-SVG-1.1/animate-elem-15-t.svg:
- svg/W3C-SVG-1.1/animate-elem-16-t.svg:
- svg/W3C-SVG-1.1/animate-elem-17-t.svg:
- svg/W3C-SVG-1.1/animate-elem-18-t.svg:
- svg/W3C-SVG-1.1/animate-elem-19-t.svg:
- svg/animations/animate-elem-02-t-drt-expected.txt: Added.
- svg/animations/animate-elem-02-t-drt.html: Added.
- svg/animations/animate-elem-03-t-drt-expected.txt: Added.
- svg/animations/animate-elem-03-t-drt.html: Added.
- svg/animations/animate-elem-04-t-drt-expected.txt: Added.
- svg/animations/animate-elem-04-t-drt.html: Added.
- svg/animations/animate-elem-05-t-drt-expected.txt: Added.
- svg/animations/animate-elem-05-t-drt.html: Added.
- svg/animations/animate-elem-06-t-drt-expected.txt: Added.
- svg/animations/animate-elem-06-t-drt.html: Added.
- svg/animations/animate-elem-07-t-drt-expected.txt: Added.
- svg/animations/animate-elem-07-t-drt.html: Added.
- svg/animations/animate-elem-08-t-drt-expected.txt: Added.
- svg/animations/animate-elem-08-t-drt.html: Added.
- svg/animations/animate-elem-09-t-drt-expected.txt: Added.
- svg/animations/animate-elem-09-t-drt.html: Added.
- svg/animations/animate-elem-10-t-drt-expected.txt: Added.
- svg/animations/animate-elem-10-t-drt.html: Added.
- svg/animations/animate-elem-11-t-drt-expected.txt: Added.
- svg/animations/animate-elem-11-t-drt.html: Added.
- svg/animations/animate-elem-12-t-drt-expected.txt: Added.
- svg/animations/animate-elem-12-t-drt.html: Added.
- svg/animations/animate-elem-13-t-drt-expected.txt: Added.
- svg/animations/animate-elem-13-t-drt.html: Added.
- svg/animations/animate-elem-14-t-drt-expected.txt: Added.
- svg/animations/animate-elem-14-t-drt.html: Added.
- svg/animations/animate-elem-15-t-drt-expected.txt: Added.
- svg/animations/animate-elem-15-t-drt.html: Added.
- svg/animations/animate-elem-16-t-drt-expected.txt: Added.
- svg/animations/animate-elem-16-t-drt.html: Added.
- svg/animations/animate-elem-17-t-drt-expected.txt: Added.
- svg/animations/animate-elem-17-t-drt.html: Added.
- svg/animations/animate-elem-18-t-drt-expected.txt: Added.
- svg/animations/animate-elem-18-t-drt.html: Added.
- svg/animations/animate-elem-19-t-drt-expected.txt: Added.
- svg/animations/animate-elem-19-t-drt.html: Added.
- svg/animations/resources/SVGAnimationTestCase.js:
(expectMatrix):
(expectTranslationMatrix):
(moveAnimationTimelineAndSample):
- svg/animations/script-tests/animate-elem-02-t-drt.js: Added.
(sampleAfterBegin):
(sampleAfterMid):
(sampleAfterBeginOfFirstRepetition):
(sampleAfterMidOfFirstRepetition):
(executeTest):
- svg/animations/script-tests/animate-elem-03-t-drt.js: Added.
(sample1):
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/animate-elem-04-t-drt.js: Added.
(sample1):
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/animate-elem-05-t-drt.js: Added.
(sample1):
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/animate-elem-06-t-drt.js: Added.
(sample1):
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/animate-elem-07-t-drt.js: Added.
(sample1):
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/animate-elem-08-t-drt.js: Added.
(sample1):
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/animate-elem-09-t-drt.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):
- svg/animations/script-tests/animate-elem-10-t-drt.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):
- svg/animations/script-tests/animate-elem-11-t-drt.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):
- svg/animations/script-tests/animate-elem-12-t-drt.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):
- svg/animations/script-tests/animate-elem-13-t-drt.js: Added.
(sample1):
(sample2):
(sample3):
(executeTest):
- svg/animations/script-tests/animate-elem-14-t-drt.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):
- svg/animations/script-tests/animate-elem-15-t-drt.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):
- svg/animations/script-tests/animate-elem-16-t-drt.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):
- svg/animations/script-tests/animate-elem-17-t-drt.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):
- svg/animations/script-tests/animate-elem-18-t-drt.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):
- svg/animations/script-tests/animate-elem-19-t-drt.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):
- svg/dynamic-updates/resources/SVGTestCase.js:
(embedSVGTestCase):
(iframeLoaded):
- 7:42 AM Changeset in webkit [109214] by
-
- 11 edits in trunk/Source/WebCore
Web Inspector: enable Profiles panel for workers
https://bugs.webkit.org/show_bug.cgi?id=79908
Introduced worker profiler agent. Enabled script profiling for
workers.
Reviewed by Pavel Feldman.
- bindings/js/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::startForPage):
(WebCore):
(WebCore::ScriptProfiler::startForWorkerContext):
(WebCore::ScriptProfiler::stopForPage):
(WebCore::ScriptProfiler::stopForWorkerContext):
- bindings/js/ScriptProfiler.h:
(WebCore):
(ScriptProfiler):
- bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::startForPage):
(WebCore):
(WebCore::ScriptProfiler::startForWorkerContext):
(WebCore::ScriptProfiler::stopForPage):
(WebCore::ScriptProfiler::stopForWorkerContext):
- bindings/v8/ScriptProfiler.h:
(WebCore):
(ScriptProfiler):
- inspector/InspectorProfilerAgent.cpp:
(WebCore):
(PageProfilerAgent):
(WebCore::PageProfilerAgent::PageProfilerAgent):
(WebCore::PageProfilerAgent::~PageProfilerAgent):
(WebCore::PageProfilerAgent::startProfiling):
(WebCore::PageProfilerAgent::stopProfiling):
(WebCore::InspectorProfilerAgent::create):
(WorkerProfilerAgent):
(WebCore::WorkerProfilerAgent::WorkerProfilerAgent):
(WebCore::WorkerProfilerAgent::~WorkerProfilerAgent):
(WebCore::WorkerProfilerAgent::startProfiling):
(WebCore::WorkerProfilerAgent::stopProfiling):
(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
(WebCore::InspectorProfilerAgent::start):
(WebCore::InspectorProfilerAgent::stop):
- inspector/InspectorProfilerAgent.h:
(WebCore):
(InspectorProfilerAgent):
- inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
(WebCore::WorkerInspectorController::connectFrontend):
(WebCore::WorkerInspectorController::disconnectFrontend):
(WebCore::WorkerInspectorController::restoreInspectorStateFromCookie):
- inspector/WorkerInspectorController.h:
(WebCore):
(WorkerInspectorController):
- inspector/front-end/ProfilesPanel.js:
- inspector/front-end/inspector.js:
(WebInspector._createPanels):
- 7:36 AM Changeset in webkit [109213] by
-
- 64 edits38 adds in trunk/LayoutTests
2012-02-29 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Next chunk of SL pixel test updates.
- platform/mac-snowleopard/svg/dynamic-updates/SVGPatternElement-svgdom-height-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGPatternElement-svgdom-patternUnits-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGPatternElement-svgdom-width-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGRectElement-dom-height-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGRectElement-dom-requiredFeatures-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGRectElement-dom-width-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGRectElement-dom-x-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGRectElement-dom-y-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGRectElement-svgdom-height-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGRectElement-svgdom-width-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGRectElement-svgdom-x-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGRectElement-svgdom-y-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGTRefElement-dom-href-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-dom-dx-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-dom-dy-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-dom-requiredFeatures-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-dom-transform-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-dom-x-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-dom-y-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-svgdom-rotate-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-svgdom-transform-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-svgdom-x-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGTextElement-svgdom-y-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png:
- platform/mac-snowleopard/svg/filters/animate-fill-expected.png: Added.
- platform/mac-snowleopard/svg/filters/big-sized-filter-2-expected.png: Added.
- platform/mac-snowleopard/svg/filters/big-sized-filter-expected.png: Added.
- platform/mac-snowleopard/svg/filters/feColorMatrix-default-type-expected.png: Added.
- platform/mac-snowleopard/svg/filters/feColorMatrix-offset-expected.png: Added.
- platform/mac-snowleopard/svg/filters/feColorMatrix-saturate-expected.png: Added.
- platform/mac-snowleopard/svg/filters/feColorMatrix-values-expected.png: Added.
- platform/mac-snowleopard/svg/filters/feComposite-expected.png:
- platform/mac-snowleopard/svg/filters/feConvolveFilter-y-bounds-expected.png: Added.
- platform/mac-snowleopard/svg/filters/feDisplacementMap-expected.png: Added.
- platform/mac-snowleopard/svg/filters/feDropShadow-expected.png: Added.
- platform/mac-snowleopard/svg/filters/feGaussianBlur-expected.png: Added.
- platform/mac-snowleopard/svg/filters/feImage-animated-transform-on-target-rect-expected.png: Added.
- platform/mac-snowleopard/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png: Added.
- platform/mac-snowleopard/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png: Added.
- platform/mac-snowleopard/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png: Added.
- platform/mac-snowleopard/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png: Added.
- platform/mac-snowleopard/svg/filters/feImage-late-indirect-update-expected.png: Added.
- platform/mac-snowleopard/svg/filters/feImage-multiple-targets-id-change-expected.png: Added.
- platform/mac-snowleopard/svg/filters/feImage-position-expected.png: Added.
- platform/mac-snowleopard/svg/filters/feImage-preserveAspectratio-expected.png: Added.
- platform/mac-snowleopard/svg/filters/feImage-reference-invalidation-expected.png: Added.
- platform/mac-snowleopard/svg/filters/feImage-reference-svg-primitive-expected.png: Added.
- platform/mac-snowleopard/svg/filters/feImage-subregions-expected.png: Added.
- platform/mac-snowleopard/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png: Added.
- platform/mac-snowleopard/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png: Added.
- platform/mac-snowleopard/svg/filters/feImage-target-add-to-document-expected.png: Added.
- platform/mac-snowleopard/svg/filters/feImage-target-attribute-change-expected.png: Added.
- platform/mac-snowleopard/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png: Added.
- platform/mac-snowleopard/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png: Added.
- platform/mac-snowleopard/svg/filters/feImage-target-changes-id-expected.png: Added.
- platform/mac-snowleopard/svg/filters/feImage-target-id-change-expected.png: Added.
- platform/mac-snowleopard/svg/filters/feImage-target-inline-style-change-expected.png: Added.
- platform/mac-snowleopard/svg/filters/feImage-target-property-change-expected.png: Added.
- platform/mac-snowleopard/svg/filters/feImage-target-reappend-to-document-expected.png: Added.
- platform/mac-snowleopard/svg/filters/feImage-target-remove-from-document-expected.png: Added.
- platform/mac-snowleopard/svg/filters/feImage-target-style-change-expected.png: Added.
- platform/mac-snowleopard/svg/filters/feLighting-crash-expected.png:
- platform/mac-snowleopard/svg/filters/feMerge-expected.png: Added.
- platform/mac-snowleopard/svg/filters/feOffset-expected.png:
- platform/mac-snowleopard/svg/filters/feTile-expected.png:
- platform/mac-snowleopard/svg/filters/filter-clip-expected.png: Added.
- platform/mac-snowleopard/svg/filters/filter-on-tspan-expected.png:
- 7:28 AM Changeset in webkit [109212] by
-
- 5 edits in trunk
Web Inspector: Clicking relative links fails when query string contains a slash
https://bugs.webkit.org/show_bug.cgi?id=79905
Reviewed by Vsevolod Vlasov.
Source/WebCore:
- inspector/front-end/ResourceUtils.js:
(WebInspector.completeURL):
LayoutTests:
- inspector/styles/styles-url-linkify-expected.txt:
- inspector/styles/styles-url-linkify.html:
- 7:26 AM Changeset in webkit [109211] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Ctrl R should reload page from the console panel as well.
https://bugs.webkit.org/show_bug.cgi?id=79883
Reviewed by Vsevolod Vlasov.
- inspector/front-end/inspector.js:
(WebInspector.documentKeyDown):
- 7:24 AM Changeset in webkit [109210] by
-
- 8 edits in trunk/Source/WebCore
Extended attributes list should go before 'static' and 'const' modifiers in IDLs.
https://bugs.webkit.org/show_bug.cgi?id=79807
Reviewed by Kentaro Hara.
No new tests. Generated code isn't changed.
- bindings/scripts/IDLParser.pm:
(ParseInterface):
- bindings/scripts/IDLStructure.pm:
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/TestSupplemental.idl:
- html/DOMURL.idl:
- html/HTMLMediaElement.idl:
- html/HTMLTrackElement.idl:
- 7:13 AM Changeset in webkit [109209] by
-
- 111 edits in trunk/LayoutTests
2012-02-29 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Next chunk of SL pixel test updates.
- platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-dom-height-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-dom-width-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-dom-x-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-dom-y-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-svgdom-height-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-svgdom-width-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-svgdom-x-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-svgdom-y-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGForeignObjectElement-dom-height-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGForeignObjectElement-dom-width-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGForeignObjectElement-dom-x-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGForeignObjectElement-dom-y-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGForeignObjectElement-svgdom-height-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGForeignObjectElement-svgdom-width-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGForeignObjectElement-svgdom-x-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGForeignObjectElement-svgdom-y-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGGElement-dom-requiredFeatures-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-requiredFeatures-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGLineElement-dom-x1-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGLineElement-dom-x2-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGLineElement-dom-y1-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGLineElement-dom-y2-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGLineElement-svgdom-x1-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGLineElement-svgdom-x2-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGLineElement-svgdom-y1-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGLineElement-svgdom-y2-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGMarkerElement-dom-markerUnits-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGMarkerElement-dom-orient-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGMarkerElement-dom-refX-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGMarkerElement-dom-refY-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGMarkerElement-svgdom-markerUnits-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGMarkerElement-svgdom-orientAngle-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGMarkerElement-svgdom-orientType-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGMaskElement-dom-height-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGMaskElement-dom-width-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGMaskElement-dom-x-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGMaskElement-dom-y-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGPathElement-dom-requiredFeatures-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGPatternElement-dom-height-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGPatternElement-dom-patternUnits-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGPatternElement-dom-width-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.png:
- 6:39 AM Changeset in webkit [109208] by
-
- 198 edits4 adds in trunk/LayoutTests
2012-02-29 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Next chunk of SL pixel test updates.
- platform/mac-snowleopard/svg/carto.net/tabgroup-expected.png: Added.
- platform/mac-snowleopard/svg/carto.net/window-expected.png:
- platform/mac-snowleopard/svg/custom/circle-move-invalidation-expected.png:
- platform/mac-snowleopard/svg/custom/glyph-selection-arabic-forms-expected.png: Added.
- platform/mac-snowleopard/svg/custom/glyph-selection-non-bmp-expected.png: Added.
- platform/mac-snowleopard/svg/custom/js-late-clipPath-and-object-creation-expected.png:
- platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.png:
- platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.txt:
- platform/mac-snowleopard/svg/custom/use-instanceRoot-event-bubbling-expected.png:
- platform/mac-snowleopard/svg/custom/use-instanceRoot-event-listeners-expected.png:
- platform/mac-snowleopard/svg/dom/SVGLocatable-getCTM-svg-root-expected.png: Added.
- platform/mac-snowleopard/svg/dynamic-updates/SVGCircleElement-dom-cx-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGCircleElement-dom-cy-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGCircleElement-dom-r-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGCircleElement-svgdom-cx-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGCircleElement-svgdom-cy-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGCircleElement-svgdom-r-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGClipPathElement-css-transform-influences-hitTesting-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGClipPathElement-svgdom-clipPathUnits-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGEllipseElement-dom-cx-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGEllipseElement-dom-cy-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGEllipseElement-dom-rx-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGEllipseElement-dom-ry-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGEllipseElement-svgdom-cx-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGEllipseElement-svgdom-cy-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGEllipseElement-svgdom-rx-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGEllipseElement-svgdom-ry-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDistantLightElement-dom-azimuth-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDistantLightElement-dom-elevation-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-azimuth-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-elevation-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEOffsetElement-dom-dx-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEOffsetElement-dom-dy-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEOffsetElement-dom-in-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dx-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dy-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEOffsetElement-svgdom-in-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png:
- platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png:
- 4:41 AM Changeset in webkit [109207] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip more failing tests.
- platform/qt-5.0/Skipped:
- 4:33 AM Changeset in webkit [109206] by
-
- 2 edits in trunk/Tools
[GTK] Small fix for cross compilation to not generate gtkdoc.
Rubber-stamped by Csaba Osztrogonác.
- Scripts/webkitdirs.pm:
(isCrossCompilation):
- 12:58 AM Changeset in webkit [109205] by
-
- 12 edits in trunk/Source/WebKit/efl
[EFL] Replace malloc/calloc/free to new/delete.
https://bugs.webkit.org/show_bug.cgi?id=75848
Patch by Tomasz Morawski <t.morawski@samsung.com> on 2012-02-29
Reviewed by Hajime Morita.
Replaced almost all malloc/calloc/free to new/delete operator and where it was possible smart pointers were also
used. Left few c memory allocation by intention to not mix c and c++ memory managment. Left malloc for Ewk_Tile
object due to const fields present in Ewk_tile structure.
- ewk/ewk_auth_soup.cpp:
- ewk/ewk_contextmenu.cpp:
(ewk_context_menu_unref):
(ewk_context_menu_item_new):
(ewk_context_menu_item_free):
(ewk_context_menu_new):
- ewk/ewk_cookies.cpp:
(ewk_cookies_get_all):
(ewk_cookies_cookie_free):
- ewk/ewk_frame.cpp:
(ewk_frame_hit_test_free):
(ewk_frame_hit_test_new):
- ewk/ewk_history.cpp:
(ewk_history_item_new_from_core):
(_ewk_history_item_free):
(ewk_history_new):
(ewk_history_free):
- ewk/ewk_tiled_backing_store.cpp:
(_Ewk_Tiled_Backing_Store_Item):
(_ewk_tiled_backing_store_pre_render_request_add):
(_ewk_tiled_backing_store_pre_render_request_del):
(_ewk_tiled_backing_store_pre_render_request_flush):
(_ewk_tiled_backing_store_pre_render_request_clear):
(_ewk_tiled_backing_store_item_add):
(_ewk_tiled_backing_store_item_del):
- ewk/ewk_tiled_matrix.cpp:
(_ewk_tile_matrix_tile_free):
(ewk_tile_matrix_new):
(ewk_tile_matrix_zoom_level_set):
(ewk_tile_matrix_invalidate):
(ewk_tile_matrix_free):
- ewk/ewk_tiled_model.cpp:
(tile_account):
(ewk_tile_unused_cache_new):
(_ewk_tile_unused_cache_free):
(ewk_tile_unused_cache_clear):
(ewk_tile_unused_cache_flush):
(ewk_tile_unused_cache_tile_get):
(ewk_tile_unused_cache_tile_put):
- ewk/ewk_tiled_private.h:
- ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_core_frame_new):
(_ewk_view_priv_new):
(_ewk_view_priv_del):
(ewk_view_core_page_get):
(ewk_view_popup_new):
(ewk_view_popup_destroy):
(EWKPrivate::corePage):
- ewk/ewk_window_features.cpp:
(ewk_window_features_unref):
(ewk_window_features_new_from_core):
- 12:57 AM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 12:54 AM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 12:29 AM Changeset in webkit [109204] by
-
- 25 edits in trunk
2012-02-28 Yury Semikhatsky <yurys@chromium.org>
Web Inspector: move DOM counter graphs out of experimental
https://bugs.webkit.org/show_bug.cgi?id=79802
Enable DOM counter graphs by default.
Reveal nearest record from the left hand side when there is no
record containing the point where the user clicked.
Reviewed by Pavel Feldman.
- inspector/front-end/Settings.js: (WebInspector.ExperimentsSettings):
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype._endSplitterDragging): (WebInspector.TimelinePanel.prototype._onTimelineEventRecorded): (WebInspector.TimelinePanel.prototype.sidebarResized): (WebInspector.TimelinePanel.prototype._resetPanel): (WebInspector.TimelinePanel.prototype._refresh): (WebInspector.TimelinePanel.prototype.revealRecordAt):
2012-02-29 Yury Semikhatsky <yurys@chromium.org>
Web Inspector: move DOM counter graphs out of experimental
https://bugs.webkit.org/show_bug.cgi?id=79802
Enable DOM counter graphs by default. Rebase timeline tests so that
the records include counters field.
Reviewed by Pavel Feldman.
- inspector/timeline/timeline-dom-content-loaded-event-expected.txt:
- inspector/timeline/timeline-event-dispatch-expected.txt:
- inspector/timeline/timeline-injected-script-eval-expected.txt:
- inspector/timeline/timeline-layout-expected.txt:
- inspector/timeline/timeline-load-event-expected.txt:
- inspector/timeline/timeline-mark-timeline-expected.txt:
- inspector/timeline/timeline-network-resource-expected.txt:
- inspector/timeline/timeline-parse-html-expected.txt:
- inspector/timeline/timeline-recalculate-styles-expected.txt:
- inspector/timeline/timeline-script-tag-1-expected.txt:
- inspector/timeline/timeline-script-tag-2-expected.txt:
- inspector/timeline/timeline-test.js:
- inspector/timeline/timeline-time-stamp-expected.txt:
- platform/chromium/inspector/timeline/timeline-animation-frame-expected.txt:
- platform/chromium/inspector/timeline/timeline-event-dispatch-expected.txt:
- platform/chromium/inspector/timeline/timeline-layout-expected.txt:
- platform/chromium/inspector/timeline/timeline-mark-timeline-expected.txt:
- platform/chromium/inspector/timeline/timeline-network-resource-expected.txt:
- platform/chromium/inspector/timeline/timeline-paint-expected.txt:
- platform/chromium/inspector/timeline/timeline-parse-html-expected.txt:
- platform/chromium/inspector/timeline/timeline-time-stamp-expected.txt:
- 12:07 AM Changeset in webkit [109203] by
-
- 6 edits in trunk/Source/WebCore
[Refactoring] Shadow related attach paths should be in ShadowTree.
https://bugs.webkit.org/show_bug.cgi?id=79854
Reviewed by Ryosuke Niwa.
No new tests. No behavior change.
This change introduces ShadowTree::attachHost() and ShadowTree::detachHost()
and moves shadow-enabled attachment code from Element to ShadowRoot.
This also factored out small ContainerNode method to use it from ShadowTree.
Even after this change, the traveral order in ShadowTree
attachment has some unclear part. Coming changes will clarify
these. This change is aimed to be purely textural.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::attach):
(WebCore::ContainerNode::detach):
- dom/ContainerNode.h:
(ContainerNode):
(WebCore::ContainerNode::attachAsNode): Added.
(WebCore::ContainerNode::attachChildren): Added.
(WebCore::ContainerNode::attachChildrenIfNeeded): Added.
(WebCore::ContainerNode::attachChildrenLazily): Added.
(WebCore::ContainerNode::detachAsNode): Added.
(WebCore::ContainerNode::detachChildrenIfNeeded): Added.
(WebCore::ContainerNode::detachChildren): Added.
- dom/Element.cpp:
(WebCore::Element::attach):
(WebCore::Element::detach):
- dom/ShadowTree.cpp:
(WebCore::ShadowTree::addShadowRoot):
(WebCore::ShadowTree::removeAllShadowRoots):
(WebCore::ShadowTree::detachHost):
(WebCore):
(WebCore::ShadowTree::attachHost):
(WebCore::ShadowTree::reattachHostChildrenAndShadow):
- dom/ShadowTree.h:
(ShadowTree):
- 12:05 AM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 12:02 AM Changeset in webkit [109202] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed morning gardening, skip new failing tests.
- platform/qt/Skipped:
Feb 28, 2012:
- 11:31 PM Changeset in webkit [109201] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
Tests in platform/chromium/rubberbanding and
platform/chromium/compositing/rubberbanding are also failing on
Mac10.5.
- platform/chromium/test_expectations.txt:
- 11:25 PM Changeset in webkit [109200] by
-
- 6 edits6 adds in trunk
Microdata: Implement HTMLPropertiesCollection collection.namedItem().
https://bugs.webkit.org/show_bug.cgi?id=73156
Patch by Arko Saha <arko@motorola.com> on 2012-02-28
Reviewed by Kentaro Hara.
Source/WebCore:
Tests: fast/dom/MicroData/nameditem-must-be-case-sensitive.html
fast/dom/MicroData/nameditem-must-return-correct-item-properties.html
fast/dom/MicroData/properties-collection-nameditem-test.html
- bindings/scripts/CodeGeneratorJS.pm: Modified code generator to generate
JS bindings code for HTMLPropertiesCollection [NamedGetter] property.
(GenerateImplementation):
- html/HTMLPropertiesCollection.cpp:
(WebCore::HTMLPropertiesCollection::names):
(WebCore):
(WebCore::HTMLPropertiesCollection::namedItem): Returns a NodeList object
containing any elements that add a property named name.
(WebCore::HTMLPropertiesCollection::hasNamedItem): Checks if the items can
be retrieved or not based on the property named name.
- html/HTMLPropertiesCollection.h: Added namedItem(), hasProperty(),
hasNamedItem() methods.
(HTMLPropertiesCollection):
- html/HTMLPropertiesCollection.idl: Added namedItem() IDL method.
LayoutTests:
Added test-cases for collection.namedItem().
- fast/dom/MicroData/nameditem-must-be-case-sensitive-expected.txt: Added.
- fast/dom/MicroData/nameditem-must-be-case-sensitive.html: Added.
- fast/dom/MicroData/nameditem-must-return-correct-item-properties-expected.txt: Added.
- fast/dom/MicroData/nameditem-must-return-correct-item-properties.html: Added.
- fast/dom/MicroData/properties-collection-nameditem-test-expected.txt: Added.
- fast/dom/MicroData/properties-collection-nameditem-test.html: Added.
- 11:19 PM Changeset in webkit [109199] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update after r109183
Some tests in platform/chromium/rubberbanding and
platform/chromium/compositing/rubberbanding are failing.
- platform/chromium/test_expectations.txt:
- 10:51 PM Changeset in webkit [109198] by
-
- 8 edits in trunk
Add size field to Metadata in FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=79813
WebKit-svn/LayoutTests:
Changed fast/filesystem/op-get-metadata test to also test if
getMetadata returns correct file sizes.
Reviewed by David Levin.
- fast/filesystem/op-get-metadata-expected.txt:
- fast/filesystem/resources/op-get-metadata.js:
- fast/filesystem/resources/op-tests-helper.js:
(createTestEnvironment.Helper.this.createSuccessCallback.entry.createWriter): Added.
(createTestEnvironment.Helper.this.createSuccessCallback):
(createTestEnvironment.Helper.this.createNextEntry):
(runOperationTest.OperationTestHelper.this.testMetadataSuccessCallback):
WebKit-svn/Source/WebCore:
Reviewed by David Levin.
Test: fast/filesystem/op-get-metadata.html
- fileapi/FileSystemCallbacks.cpp:
(WebCore::MetadataCallbacks::didReadMetadata):
- fileapi/Metadata.h:
(WebCore::Metadata::create):
(WebCore::Metadata::modificationTime):
(WebCore::Metadata::size): Added.
(WebCore::Metadata::Metadata):
- fileapi/Metadata.idl:
- 10:49 PM Changeset in webkit [109197] by
-
- 4 edits in trunk
[CMake] Always build wtf as a static library.
https://bugs.webkit.org/show_bug.cgi?id=79857
Reviewed by Eric Seidel.
.:
- CMakeLists.txt: Put static libraries in ${CMAKE_BINARY_DIR} too
to have them grouped with the shared ones.
Source/JavaScriptCore:
To help the efforts in bug 75673 to move WTF out of
JavaScriptCore, act more like the other ports and remove the
possibility of building WTF as a shared library.
It does not make much sense to, for example, ship WTF as a
separate .so with webkit-efl packages, and it should be small
enough not to cause problems during linking.
- wtf/CMakeLists.txt:
- 10:40 PM Changeset in webkit [109196] by
-
- 22 edits in trunk
[JSC] Implement ArrayBuffer transfer
https://bugs.webkit.org/show_bug.cgi?id=73493.
Implement ArrayBuffer transfer, per Khronos spec: http://www.khronos.org/registry/typedarray/specs/latest/#9.
This brings parity with V8 implementation of transferable typed arrays.
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Extra export.
- wtf/ArrayBuffer.h:
(ArrayBuffer): Added extra export.
Source/WebCore:
Covered by existing tests.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::handlePostMessage):
- bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue):
- bindings/js/JSHistoryCustom.cpp:
(WebCore::JSHistory::pushState):
(WebCore::JSHistory::replaceState):
- bindings/js/JSMessageEventCustom.cpp:
(WebCore::handleInitMessageEvent):
- bindings/js/JSMessagePortCustom.cpp:
(WebCore::fillMessagePortArray):
- bindings/js/JSMessagePortCustom.h:
(WebCore):
(WebCore::handlePostMessage):
- bindings/js/ScriptValue.cpp:
(WebCore::ScriptValue::serialize):
- bindings/js/SerializedScriptValue.cpp:
(WebCore):
(WebCore::CloneSerializer::serialize):
(CloneSerializer):
(WebCore::CloneSerializer::CloneSerializer):
(WebCore::CloneSerializer::fillTransferMap):
(WebCore::CloneSerializer::dumpArrayBufferView):
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneDeserializer::deserialize):
(WebCore::CloneDeserializer::CloneDeserializer):
(WebCore::CloneDeserializer::readTerminal):
(CloneDeserializer):
(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::transferArrayBuffers):
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::deserialize):
- bindings/js/SerializedScriptValue.h:
(WebCore):
(SerializedScriptValue):
LayoutTests:
- fast/canvas/webgl/arraybuffer-transfer-of-control-expected.txt:
- fast/canvas/webgl/script-tests/arraybuffer-transfer-of-control.js: Added tests for Uint8ClampedArray
- fast/dom/Window/window-postmessage-args-expected.txt:
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- 10:36 PM Changeset in webkit [109195] by
-
- 5 edits in trunk/Source
[wx] Unreviewed. Build fixes for wx port.
- 10:28 PM Changeset in webkit [109194] by
-
- 2 edits in trunk/Source/JavaScriptCore
Refactor SpeculativeJIT::emitAllocateJSFinalObject
https://bugs.webkit.org/show_bug.cgi?id=79801
Reviewed by Filip Pizlo.
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::emitAllocateBasicJSObject): Split emitAllocateJSFinalObject out to form this
function, which is more generic in that it can allocate a variety of classes.
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::emitAllocateJSFinalObject): Changed to use the new helper function.
- 10:17 PM Changeset in webkit [109193] by
-
- 3 edits2 adds in trunk
[Forms] Spin button sometimes ignores Indeterminate of m_upDownState
https://bugs.webkit.org/show_bug.cgi?id=79754
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-02-28
Reviewed by Kent Tamura.
Source/WebCore:
This patch checks enum value Indeterminate before using m_upDownState. This make
sure Indeterminate state doesn't act like Down state.
m_upDownState can be Indeterminate at mousedown event if mouse pointer is on
spin button when it is displayed.
Test: fast/forms/number/spin-button-state.html
- html/shadow/TextControlInnerElements.cpp:
(WebCore::SpinButtonElement::defaultEventHandler):
(WebCore::SpinButtonElement::repeatingTimerFired):
LayoutTests:
- fast/forms/number/spin-button-state.html: Added.
- fast/forms/number/spin-button-state-expected.txt: Added.
- 10:13 PM Changeset in webkit [109192] by
-
- 261 edits2 adds4 deletes in trunk
[Refactoring] RenderSummary and RenderDetail is no longer needed.
https://bugs.webkit.org/show_bug.cgi?id=79641
Source/WebCore:
Reviewed by Kent Tamura.
Removed RenderDetails and RenderSummary because its only
modification they had is already handled by RenderBlock::styleWillChange().
These are just a historical artifact. We could have removed these
classes when they were switched to shadow-based implementations.
Tests: fast/html/details-inline-expected.html
fast/html/details-inline.html
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::createRenderer):
- html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::createRenderer):
(WebCore::HTMLSummaryElement::defaultEventHandler):
- rendering/RenderDetails.cpp: Removed.
- rendering/RenderDetails.h: Removed.
- rendering/RenderDetailsMarker.cpp:
(WebCore::RenderDetailsMarker::isOpen):
- rendering/RenderDetailsMarker.h:
(RenderDetailsMarker):
- rendering/RenderObject.h:
(RenderObject):
- rendering/RenderSummary.cpp: Removed.
- rendering/RenderSummary.h: Removed.
- rendering/RenderingAllInOne.cpp:
LayoutTests:
Reviewed by Kent Tamura.
- Replaced "RenderSummary" and "RenderDetails" with "RenderBlock".
- Added a test to ensure that summmary and details behave like a "inline-block" even when "inline" is given.
- fast/html/details-inline-expected.html: Added.
- fast/html/details-inline.html: Added.
- platform/chromium-linux/fast/html/details-replace-summary-child-expected.txt:
- platform/chromium-linux/fast/html/details-replace-text-expected.txt:
- platform/chromium-win/fast/html/details-add-child-1-expected.txt:
- platform/chromium-win/fast/html/details-add-child-2-expected.txt:
- platform/chromium-win/fast/html/details-add-details-child-1-expected.txt:
- platform/chromium-win/fast/html/details-add-details-child-2-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-1-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-10-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-2-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-3-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-4-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-5-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-6-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-7-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-8-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-9-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-child-1-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-child-2-expected.txt:
- platform/chromium-win/fast/html/details-nested-1-expected.txt:
- platform/chromium-win/fast/html/details-nested-2-expected.txt:
- platform/chromium-win/fast/html/details-no-summary1-expected.txt:
- platform/chromium-win/fast/html/details-no-summary2-expected.txt:
- platform/chromium-win/fast/html/details-no-summary3-expected.txt:
- platform/chromium-win/fast/html/details-no-summary4-expected.txt:
- platform/chromium-win/fast/html/details-open-javascript-expected.txt:
- platform/chromium-win/fast/html/details-open1-expected.txt:
- platform/chromium-win/fast/html/details-open2-expected.txt:
- platform/chromium-win/fast/html/details-open3-expected.txt:
- platform/chromium-win/fast/html/details-open4-expected.txt:
- platform/chromium-win/fast/html/details-open5-expected.txt:
- platform/chromium-win/fast/html/details-open6-expected.txt:
- platform/chromium-win/fast/html/details-position-expected.txt:
- platform/chromium-win/fast/html/details-remove-child-1-expected.txt:
- platform/chromium-win/fast/html/details-remove-child-2-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-1-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-2-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-3-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-4-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-5-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-6-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-child-1-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-child-2-expected.txt:
- platform/chromium-win/fast/html/details-replace-summary-child-expected.txt:
- platform/chromium-win/fast/html/details-replace-text-expected.txt:
- platform/chromium-win/fast/html/details-writing-mode-expected.txt:
- platform/gtk/fast/html/details-add-child-1-expected.txt:
- platform/gtk/fast/html/details-add-child-2-expected.txt:
- platform/gtk/fast/html/details-add-details-child-1-expected.txt:
- platform/gtk/fast/html/details-add-details-child-2-expected.txt:
- platform/gtk/fast/html/details-add-summary-1-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-1-expected.txt:
- platform/gtk/fast/html/details-add-summary-10-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-10-expected.txt:
- platform/gtk/fast/html/details-add-summary-2-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-2-expected.txt:
- platform/gtk/fast/html/details-add-summary-3-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-3-expected.txt:
- platform/gtk/fast/html/details-add-summary-4-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-4-expected.txt:
- platform/gtk/fast/html/details-add-summary-5-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-5-expected.txt:
- platform/gtk/fast/html/details-add-summary-6-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-6-expected.txt:
- platform/gtk/fast/html/details-add-summary-7-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-7-expected.txt:
- platform/gtk/fast/html/details-add-summary-8-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-8-expected.txt:
- platform/gtk/fast/html/details-add-summary-9-and-click-expected.txt:
- platform/gtk/fast/html/details-add-summary-9-expected.txt:
- platform/gtk/fast/html/details-add-summary-child-1-expected.txt:
- platform/gtk/fast/html/details-add-summary-child-2-expected.txt:
- platform/gtk/fast/html/details-nested-1-expected.txt:
- platform/gtk/fast/html/details-nested-2-expected.txt:
- platform/gtk/fast/html/details-no-summary1-expected.txt:
- platform/gtk/fast/html/details-no-summary2-expected.txt:
- platform/gtk/fast/html/details-no-summary3-expected.txt:
- platform/gtk/fast/html/details-no-summary4-expected.txt:
- platform/gtk/fast/html/details-open-javascript-expected.txt:
- platform/gtk/fast/html/details-open1-expected.txt:
- platform/gtk/fast/html/details-open2-expected.txt:
- platform/gtk/fast/html/details-open3-expected.txt:
- platform/gtk/fast/html/details-open4-expected.txt:
- platform/gtk/fast/html/details-open5-expected.txt:
- platform/gtk/fast/html/details-open6-expected.txt:
- platform/gtk/fast/html/details-position-expected.txt:
- platform/gtk/fast/html/details-remove-child-1-expected.txt:
- platform/gtk/fast/html/details-remove-child-2-expected.txt:
- platform/gtk/fast/html/details-remove-summary-1-and-click-expected.txt:
- platform/gtk/fast/html/details-remove-summary-1-expected.txt:
- platform/gtk/fast/html/details-remove-summary-2-and-click-expected.txt:
- platform/gtk/fast/html/details-remove-summary-2-expected.txt:
- platform/gtk/fast/html/details-remove-summary-3-and-click-expected.txt:
- platform/gtk/fast/html/details-remove-summary-3-expected.txt:
- platform/gtk/fast/html/details-remove-summary-4-and-click-expected.txt:
- platform/gtk/fast/html/details-remove-summary-4-expected.txt:
- platform/gtk/fast/html/details-remove-summary-5-and-click-expected.txt:
- platform/gtk/fast/html/details-remove-summary-5-expected.txt:
- platform/gtk/fast/html/details-remove-summary-6-and-click-expected.txt:
- platform/gtk/fast/html/details-remove-summary-6-expected.txt:
- platform/gtk/fast/html/details-remove-summary-child-1-expected.txt:
- platform/gtk/fast/html/details-remove-summary-child-2-expected.txt:
- platform/gtk/fast/html/details-replace-summary-child-expected.txt:
- platform/gtk/fast/html/details-replace-text-expected.txt:
- platform/gtk/fast/html/details-writing-mode-expected.txt:
- platform/mac/fast/html/details-add-child-1-expected.txt:
- platform/mac/fast/html/details-add-child-2-expected.txt:
- platform/mac/fast/html/details-add-details-child-1-expected.txt:
- platform/mac/fast/html/details-add-details-child-2-expected.txt:
- platform/mac/fast/html/details-add-summary-1-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-1-expected.txt:
- platform/mac/fast/html/details-add-summary-10-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-10-expected.txt:
- platform/mac/fast/html/details-add-summary-2-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-2-expected.txt:
- platform/mac/fast/html/details-add-summary-3-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-3-expected.txt:
- platform/mac/fast/html/details-add-summary-4-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-4-expected.txt:
- platform/mac/fast/html/details-add-summary-5-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-5-expected.txt:
- platform/mac/fast/html/details-add-summary-6-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-6-expected.txt:
- platform/mac/fast/html/details-add-summary-7-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-7-expected.txt:
- platform/mac/fast/html/details-add-summary-8-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-8-expected.txt:
- platform/mac/fast/html/details-add-summary-9-and-click-expected.txt:
- platform/mac/fast/html/details-add-summary-9-expected.txt:
- platform/mac/fast/html/details-add-summary-child-1-expected.txt:
- platform/mac/fast/html/details-add-summary-child-2-expected.txt:
- platform/mac/fast/html/details-nested-1-expected.txt:
- platform/mac/fast/html/details-nested-2-expected.txt:
- platform/mac/fast/html/details-no-summary1-expected.txt:
- platform/mac/fast/html/details-no-summary2-expected.txt:
- platform/mac/fast/html/details-no-summary3-expected.txt:
- platform/mac/fast/html/details-no-summary4-expected.txt:
- platform/mac/fast/html/details-open-javascript-expected.txt:
- platform/mac/fast/html/details-open1-expected.txt:
- platform/mac/fast/html/details-open2-expected.txt:
- platform/mac/fast/html/details-open3-expected.txt:
- platform/mac/fast/html/details-open4-expected.txt:
- platform/mac/fast/html/details-open5-expected.txt:
- platform/mac/fast/html/details-open6-expected.txt:
- platform/mac/fast/html/details-position-expected.txt:
- platform/mac/fast/html/details-remove-child-1-expected.txt:
- platform/mac/fast/html/details-remove-child-2-expected.txt:
- platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-1-expected.txt:
- platform/mac/fast/html/details-remove-summary-2-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-2-expected.txt:
- platform/mac/fast/html/details-remove-summary-3-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-3-expected.txt:
- platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-4-expected.txt:
- platform/mac/fast/html/details-remove-summary-5-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-5-expected.txt:
- platform/mac/fast/html/details-remove-summary-6-and-click-expected.txt:
- platform/mac/fast/html/details-remove-summary-6-expected.txt:
- platform/mac/fast/html/details-remove-summary-child-1-expected.txt:
- platform/mac/fast/html/details-remove-summary-child-2-expected.txt:
- platform/mac/fast/html/details-replace-summary-child-expected.txt:
- platform/mac/fast/html/details-replace-text-expected.txt:
- platform/mac/fast/html/details-writing-mode-expected.txt:
- platform/qt/fast/html/details-add-child-1-expected.txt:
- platform/qt/fast/html/details-add-child-2-expected.txt:
- platform/qt/fast/html/details-add-details-child-1-expected.txt:
- platform/qt/fast/html/details-add-details-child-2-expected.txt:
- platform/qt/fast/html/details-add-summary-1-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-1-expected.txt:
- platform/qt/fast/html/details-add-summary-10-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-10-expected.txt:
- platform/qt/fast/html/details-add-summary-2-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-2-expected.txt:
- platform/qt/fast/html/details-add-summary-3-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-3-expected.txt:
- platform/qt/fast/html/details-add-summary-4-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-4-expected.txt:
- platform/qt/fast/html/details-add-summary-5-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-5-expected.txt:
- platform/qt/fast/html/details-add-summary-6-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-6-expected.txt:
- platform/qt/fast/html/details-add-summary-7-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-7-expected.txt:
- platform/qt/fast/html/details-add-summary-8-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-8-expected.txt:
- platform/qt/fast/html/details-add-summary-9-and-click-expected.txt:
- platform/qt/fast/html/details-add-summary-9-expected.txt:
- platform/qt/fast/html/details-add-summary-child-1-expected.txt:
- platform/qt/fast/html/details-add-summary-child-2-expected.txt:
- platform/qt/fast/html/details-nested-1-expected.txt:
- platform/qt/fast/html/details-nested-2-expected.txt:
- platform/qt/fast/html/details-no-summary1-expected.txt:
- platform/qt/fast/html/details-no-summary2-expected.txt:
- platform/qt/fast/html/details-no-summary3-expected.txt:
- platform/qt/fast/html/details-no-summary4-expected.txt:
- platform/qt/fast/html/details-open-javascript-expected.txt:
- platform/qt/fast/html/details-open1-expected.txt:
- platform/qt/fast/html/details-open2-expected.txt:
- platform/qt/fast/html/details-open3-expected.txt:
- platform/qt/fast/html/details-open4-expected.txt:
- platform/qt/fast/html/details-open5-expected.txt:
- platform/qt/fast/html/details-open6-expected.txt:
- platform/qt/fast/html/details-position-expected.txt:
- platform/qt/fast/html/details-remove-child-1-expected.txt:
- platform/qt/fast/html/details-remove-child-2-expected.txt:
- platform/qt/fast/html/details-remove-summary-1-and-click-expected.txt:
- platform/qt/fast/html/details-remove-summary-1-expected.txt:
- platform/qt/fast/html/details-remove-summary-2-and-click-expected.txt:
- platform/qt/fast/html/details-remove-summary-2-expected.txt:
- platform/qt/fast/html/details-remove-summary-3-and-click-expected.txt:
- platform/qt/fast/html/details-remove-summary-3-expected.txt:
- platform/qt/fast/html/details-remove-summary-4-and-click-expected.txt:
- platform/qt/fast/html/details-remove-summary-4-expected.txt:
- platform/qt/fast/html/details-remove-summary-5-and-click-expected.txt:
- platform/qt/fast/html/details-remove-summary-5-expected.txt:
- platform/qt/fast/html/details-remove-summary-6-and-click-expected.txt:
- platform/qt/fast/html/details-remove-summary-6-expected.txt:
- platform/qt/fast/html/details-remove-summary-child-1-expected.txt:
- platform/qt/fast/html/details-remove-summary-child-2-expected.txt:
- platform/qt/fast/html/details-replace-summary-child-expected.txt:
- platform/qt/fast/html/details-replace-text-expected.txt:
- platform/qt/fast/html/details-writing-mode-expected.txt:
- 10:09 PM Changeset in webkit [109191] by
-
- 5 edits in trunk/LayoutTests
[Shadow DOM] Make createDOM() function used in testing Shadow DOM more flexible.
https://bugs.webkit.org/show_bug.cgi?id=79745
Reviewed by Dimitri Glazkov.
Replaces createDom and createShadow function defined in
LayoutTests/fast/dom/shadow/create-dom.js with more flexible
one. Now we can represent a shadow host which has both light
children and ShadowRoots in one expression.
- fast/dom/shadow/access-key.html:
- fast/dom/shadow/get-element-by-id-in-shadow-root.html:
- fast/dom/shadow/resources/create-dom.js:
(createShadowRoot):
(createDOM):
- fast/dom/shadow/shadow-boundary-events.html:
- 10:06 PM Changeset in webkit [109190] by
-
- 6 edits in trunk
perf-o-matic: generate dashboard images using Google Chart Tools
https://bugs.webkit.org/show_bug.cgi?id=79838
Reviewed by Hajime Morita.
Rename RunsJSONGenerator to Runs and added an ability to generate parameters for Google chart tool.
Also added RunsChartHandler to make url-fetches these images and DashboardImageHandler to serve them.
The image is stored in DashboardImage model.
We can't enable flip the switch to use images yet because we don't create images on fly (they're
generated when runs are updated; i.e. bots upload new results). We should be able to flip the switch
once this patch lands and all perf bots cycle.
We probably make way too many calls to Google chart tool's server with this preliminary design but we
can easily move this task into the backend and run it via a cron job once we know it works.
- Websites/webkit-perf.appspot.com/controller.py:
(schedule_runs_update):
(RunsUpdateHandler.post):
(RunsChartHandler):
(RunsChartHandler.get):
(RunsChartHandler.post):
(DashboardImageHandler):
(DashboardImageHandler.get):
(schedule_report_process):
- Websites/webkit-perf.appspot.com/json_generators.py:
(ManifestJSONGenerator.value):
(Runs):
(Runs.init):
(Runs.value):
(Runs.chart_params):
- Websites/webkit-perf.appspot.com/json_generators_unittest.py:
(RunsTest):
(RunsTest._create_results):
(RunsTest.test_generate_runs):
(RunsTest.test_value_without_results):
(RunsTest.test_value_with_results):
(RunsTest.test_run_from_build_and_result):
(RunsTest.test_chart_params_with_value):
(RunsTest.test_chart_params_with_value.split_as_int):
- Websites/webkit-perf.appspot.com/main.py:
- Websites/webkit-perf.appspot.com/models.py:
(PersistentCache.get_cache):
(DashboardImage):
(DashboardImage.key_name):
- 9:35 PM Changeset in webkit [109189] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed, rolling out r107917 and r109188.
http://trac.webkit.org/changeset/107917
http://trac.webkit.org/changeset/109188
https://bugs.webkit.org/show_bug.cgi?id=79865
Fix the chromium build. (Requested by dcheng on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-28
- src/WebDragData.cpp:
(WebKit::WebDragData::items):
- 9:16 PM Changeset in webkit [109188] by
-
- 2 edits in trunk/Source/WebKit/chromium
Chromium build fix attempt.
- src/WebDragData.cpp:
- 8:48 PM Changeset in webkit [109187] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update
svg/W3C-SVG-1.1/animate-elem-37-t.svg is failing on Win.
- platform/chromium/test_expectations.txt:
- 8:46 PM Changeset in webkit [109186] by
-
- 2 edits in trunk/Source/WebCore
Optimize the rects being drawn into compositing layers
https://bugs.webkit.org/show_bug.cgi?id=79852
Reviewed by Dan Bernstein.
Use the newly added WebKitSystemInterface method
to limit the area being painted in a CALayer
-drawInContext callback. This avoids redundant drawing,
for performance.
- platform/graphics/mac/WebLayer.mm:
(drawLayerContents):
- 8:25 PM Changeset in webkit [109185] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update after r109176
- platform/chromium/test_expectations.txt:
- 8:25 PM Changeset in webkit [109184] by
-
- 2 edits in trunk/Source/WebCore
Fix the SnowLeopard build.
- WebCore.exp.in:
- 6:36 PM Changeset in webkit [109183] by
-
- 4 edits in trunk/Source/WebCore
With tiled drawing enabled, pressing Down arrow after scrolling via mouse gesture causes page to jump back up to top
https://bugs.webkit.org/show_bug.cgi?id=79249
<rdar://problem/10866273>
Reviewed by Sam Weinig.
ScrollableArea::notifyScrollPositionChanged must make sure that the scroll animator position is kept up to date.
- platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::setCurrentPosition):
(WebCore):
- platform/ScrollAnimator.h:
(ScrollAnimator):
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::notifyScrollPositionChanged):
- 6:20 PM Changeset in webkit [109182] by
-
- 32 edits2 deletes in trunk
Unreviewed, rolling out r107894.
http://trac.webkit.org/changeset/107894
https://bugs.webkit.org/show_bug.cgi?id=30416
dataTransfer.types should be an Array since DOMStringList is deprecated.
Source/WebCore:
- bindings/js/JSClipboardCustom.cpp:
(WebCore::JSClipboard::types):
(WebCore):
- bindings/v8/custom/V8ClipboardCustom.cpp:
(WebCore::V8Clipboard::typesAccessorGetter):
(WebCore):
- dom/Clipboard.cpp:
(WebCore::Clipboard::hasStringOfType):
- dom/Clipboard.h:
(Clipboard):
- dom/Clipboard.idl:
- platform/blackberry/ClipboardBlackBerry.cpp:
(WebCore::ClipboardBlackBerry::types):
- platform/blackberry/ClipboardBlackBerry.h:
(ClipboardBlackBerry):
- platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::types):
- platform/chromium/ChromiumDataObject.h:
(ChromiumDataObject):
- platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::types):
(WebCore::ClipboardChromium::mayUpdateItems):
- platform/chromium/ClipboardChromium.h:
(ClipboardChromium):
- platform/chromium/DragDataChromium.cpp:
(WebCore::containsHTML):
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::containsPlainText):
(WebCore::DragData::canSmartReplace):
(WebCore::DragData::asFragment):
- platform/efl/ClipboardEfl.cpp:
(WebCore::ClipboardEfl::types):
- platform/efl/ClipboardEfl.h:
(ClipboardEfl):
- platform/gtk/ClipboardGtk.cpp:
(WebCore::ClipboardGtk::types):
- platform/gtk/ClipboardGtk.h:
(ClipboardGtk):
- platform/mac/ClipboardMac.h:
(ClipboardMac):
- platform/mac/ClipboardMac.mm:
(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::ClipboardMac::types):
- platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::types):
- platform/qt/ClipboardQt.h:
(ClipboardQt):
- platform/win/ClipboardWin.cpp:
(WebCore::addMimeTypesForFormat):
(WebCore::ClipboardWin::types):
- platform/win/ClipboardWin.h:
(ClipboardWin):
- platform/wx/ClipboardWx.cpp:
(WebCore::ClipboardWx::types):
- platform/wx/ClipboardWx.h:
(ClipboardWx):
LayoutTests:
- editing/pasteboard/clipboard-customData.html:
- editing/pasteboard/onpaste-text-html-types.html:
- fast/events/drag-and-drop-dataTransfer-types-nocrash.html:
- fast/events/drag-customData.html:
- fast/events/drag-dataTransfer-live-attributes-expected.txt: Removed.
- fast/events/drag-dataTransfer-live-attributes.html: Removed.
- http/tests/local/fileapi/resources/setup-file-input-element-for-drag.js:
- http/tests/security/clipboard/script-tests/clipboard-file-access.js:
(checkForEventTransferType):
- 6:03 PM Changeset in webkit [109181] by
-
- 13 edits in trunk
Update WebKitSystemInterface.
Source/WebCore:
Reviewed by Sam Weinig.
- WebCore.exp.in:
(drawLayerContents):
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
Source/WebKit/mac:
Reviewed by Sam Weinig.
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Source/WebKit2:
Reviewed by Sam Weinig.
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
WebKitLibraries:
Reviewed by Sam Weinig.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- 5:44 PM Changeset in webkit [109180] by
-
- 2 edits in trunk
Add new GPU builders to flakiness dashboard.
https://bugs.webkit.org/show_bug.cgi?id=79839
Patch by Dave Tu <dtu@chromium.org> on 2012-02-28
Reviewed by Ojan Vafai.
- Tools/TestResultServer/static-dashboards/builders.js:
- 5:43 PM Changeset in webkit [109179] by
-
- 14 edits2 adds in trunk
<content> element should behave as HTMLUnknownElement outside of a shadow DOM subtree
https://bugs.webkit.org/show_bug.cgi?id=79551
Reviewed by Dimitri Glazkov.
Source/WebCore:
The problem happened because HTMLContentElement doesn't create renderer anytime.
This change allows it to create a renderer unless the HTMLContentElement is shadowed.
Since this could happen not only on <content> but also on upcoming <shadow>,
the corresponding part of the code is pulled up to InsertionPoint.
Tests: fast/dom/shadow/content-element-outside-shadow-style-expected.html
fast/dom/shadow/content-element-outside-shadow-style.html
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::NodeRenderingContext):
- dom/ShadowRoot.h:
(WebCore):
(WebCore::TreeScope::isShadowRoot):
- dom/TreeScope.h:
(TreeScope):
- html/shadow/HTMLContentElement.h:
- html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::isShadowBoundary):
(WebCore):
- html/shadow/InsertionPoint.h:
(InsertionPoint):
(WebCore::isShadowBoundary):
(WebCore):
LayoutTests:
- fast/dom/shadow/content-element-outside-shadow-style-expected.html: Added.
- fast/dom/shadow/content-element-outside-shadow-style.html: Added.
- fast/dom/shadow/content-element-outside-shadow.html:
- platform/efl/Skipped:
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wk2/Skipped:
- 5:40 PM Changeset in webkit [109178] by
-
- 3 edits in branches/subpixellayout/Source
qt build fixes for branch post r109122.
- 5:39 PM Changeset in webkit [109177] by
-
- 13 edits in trunk
Get?/Put? for primitives should not wrap on strict accessor call
https://bugs.webkit.org/show_bug.cgi?id=79588
Reviewed by Oliver Hunt.
In the case of Get?, this is a pretty trivial bug - just don't wrap
primitives at the point you call a getter.
For setters, this is a little more involved, since we have already wrapped
the value up in a synthesized object. Stop doing so. There is also a further
subtely, that in strict mode all attempts to create a new data property on
the object should throw.
Source/JavaScriptCore:
- runtime/JSCell.cpp:
(JSC::JSCell::put):
- Put? to a string primitive should use JSValue::putToPrimitive.
- runtime/JSObject.cpp:
(JSC::JSObject::put):
- Remove static function called in one place.
- runtime/JSObject.h:
(JSC::JSValue::put):
- Put? to a non-cell JSValue should use JSValue::putToPrimitive.
- runtime/JSValue.cpp:
(JSC::JSValue::synthesizePrototype):
- Add support for synthesizing the prototype of strings.
(JSC::JSValue::putToPrimitive):
- Added, implements Put? for primitive bases, per 8.7.2.
- runtime/JSValue.h:
(JSValue):
- Add declaration for JSValue::putToPrimitive.
- runtime/PropertySlot.cpp:
(JSC::PropertySlot::functionGetter):
- Don't call ToObject on primitive this values.
LayoutTests:
- fast/js/mozilla/strict/15.5.5.1-expected.txt:
- fast/js/primitive-property-access-edge-cases-expected.txt:
- fast/js/read-modify-eval-expected.txt:
- fast/js/script-tests/primitive-property-access-edge-cases.js:
- fast/js/script-tests/read-modify-eval.js:
- Added new test cases & updated test results.
- 5:31 PM Changeset in webkit [109176] by
-
- 28 edits in trunk
Clipboard::getData should return an empty string instead of undefined
https://bugs.webkit.org/show_bug.cgi?id=79712
Reviewed by Tony Chang.
Source/WebCore:
Per the spec, an empty string should be returned when there is no data for the given typestring.
Test: fast/events/dataTransfer-getData-returns-empty-string.html
- bindings/js/JSClipboardCustom.cpp:
- bindings/v8/custom/V8ClipboardCustom.cpp:
- dom/Clipboard.h:
(Clipboard):
- dom/Clipboard.idl:
- platform/blackberry/ClipboardBlackBerry.cpp:
(WebCore::ClipboardBlackBerry::getData):
- platform/blackberry/ClipboardBlackBerry.h:
(ClipboardBlackBerry):
- platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::getData):
- platform/chromium/ClipboardChromium.h:
(ClipboardChromium):
- platform/efl/ClipboardEfl.cpp:
(WebCore::ClipboardEfl::getData):
- platform/efl/ClipboardEfl.h:
(ClipboardEfl):
- platform/gtk/ClipboardGtk.cpp:
(WebCore::ClipboardGtk::getData):
- platform/gtk/ClipboardGtk.h:
(ClipboardGtk):
- platform/mac/ClipboardMac.h:
(ClipboardMac):
- platform/mac/ClipboardMac.mm:
(WebCore::ClipboardMac::getData):
- platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::getData):
- platform/qt/ClipboardQt.h:
(ClipboardQt):
- platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::getFullCFHTML):
(WebCore::getURL):
(WebCore::getPlainText):
(WebCore::getTextHTML):
(WebCore::getCFHTML):
(WebCore::fragmentFromHTML):
- platform/win/ClipboardUtilitiesWin.h:
(WebCore):
- platform/win/ClipboardWin.cpp:
(WebCore::ClipboardWin::getData):
- platform/win/ClipboardWin.h:
(ClipboardWin):
- platform/wx/ClipboardWx.cpp:
(WebCore::ClipboardWx::getData):
- platform/wx/ClipboardWx.h:
(ClipboardWx):
LayoutTests:
- fast/events/dataTransfer-getData-returns-empty-string-expected.txt: Added.
- fast/events/dataTransfer-getData-returns-empty-string.html: Added.
- http/tests/local/drag-over-remote-content-expected.txt:
- http/tests/security/drag-over-remote-content-iframe-expected.txt:
- http/tests/security/drag-over-remote-content-iframe.html:
- 5:28 PM Changeset in webkit [109175] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] Uninitialized value in LocaleToScriptCodeForFontSelection
https://bugs.webkit.org/show_bug.cgi?id=79779
Set USCRIPT_COMMON to scriptCode as the initial value.
Reviewed by Kent Tamura.
No new tests. No behavior change.
- platform/text/LocaleToScriptMappingICU.cpp:
(WebCore::localeToScriptCodeForFontSelection):
- 5:26 PM Changeset in webkit [109174] by
-
- 2 edits in trunk/Source/JavaScriptCore
Re-enable parallel GC on Mac
https://bugs.webkit.org/show_bug.cgi?id=79837
Rubber stamped by Filip Pizlo.
- runtime/Options.cpp:
(JSC::Options::initializeOptions): We accidentally disabled parallel GC with this line,
so we removed it and things should go back to normal.
- 5:17 PM Changeset in webkit [109173] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Work around IOSurface-related corruption during readback
https://bugs.webkit.org/show_bug.cgi?id=79735
Reviewed by James Robinson.
Copy the compositor's IOSurface-backed output into a temporary
texture and perform the ReadPixels operation against that texture.
It is infeasible to write an automated test for this issue.
Tested manually by performing print preview multiple times against
pages containing WebGL content on 10.7 and observing that the
corruption in the output is no longer present.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::getFramebufferPixels):
- 5:13 PM Changeset in webkit [109172] by
-
- 3 edits in trunk/Source/JavaScriptCore
Some run-javascriptcore-tests broken for 32-bit debug
https://bugs.webkit.org/show_bug.cgi?id=79844
Rubber stamped by Oliver Hunt.
These assertions are just plain wrong for 32-bit. We could either have a massive
assertion that depends on value representation, that has to be changed every
time we change the JITs, resulting in a bug tail of debug-mode crashes, or we
could get rid of the assertions. I pick the latter.
- dfg/DFGOperations.cpp:
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- 5:12 PM Changeset in webkit [109171] by
-
- 4 edits in trunk/Source/WebCore
[chromium] Inform v8 about extra memory used for PatternSkia clamp mode
https://bugs.webkit.org/show_bug.cgi?id=79846
Reviewed by James Robinson.
For large images, creating a non-repeating Pattern in Skia can
allocate a lot of memory. Inform v8 about this so that it can
potentially garbage collect any Pattern objects that aren't being used
and that are holding onto large image copies.
- platform/graphics/Pattern.cpp:
(WebCore::Pattern::Pattern):
- platform/graphics/Pattern.h:
(Pattern):
- platform/graphics/skia/PatternSkia.cpp:
(WebCore::Pattern::platformDestroy):
(WebCore::Pattern::platformPattern):
- 4:38 PM Changeset in webkit [109170] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening, mark another compositing test as flaky.
https://bugs.webkit.org/show_bug.cgi?id=79823
- platform/chromium/test_expectations.txt:
- 4:37 PM Changeset in webkit [109169] by
-
- 4 edits in trunk
All mouse events after a right click are ignored when they came from WebkitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=77350
Patch by Hugo Parente Lima <Hugo Parente Lima> on 2012-02-28
Reviewed by Chang Shu.
Source/WebKit2:
Never ignore mouse events when using sync events, even if the context menu is being
show but the Ui did replied the ShowContextMenu event with a ContextMenuHidden.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::mouseEventSyncForTesting):
LayoutTests:
Unskip fast/events/mouse-click-events.html.
- platform/qt-5.0-wk2/Skipped:
- 4:27 PM Changeset in webkit [109168] by
-
- 4 edits in trunk/Source
[chromium] Reset damage tracker on visibility change.
https://bugs.webkit.org/show_bug.cgi?id=79267
Patch by Jonathan Backer <backer@chromium.org> on 2012-02-28
Reviewed by James Robinson.
Source/WebCore:
Unit tests: CCLayerTreeHostImplTest.cpp
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::setVisible):
Source/WebKit/chromium:
- tests/CCLayerTreeHostImplTest.cpp:
(WebKit::PartialSwapTrackerContext::getString):
(WebKit):
(WebKit::TEST_F):
- 4:14 PM Changeset in webkit [109167] by
-
- 5 edits136 adds in trunk/LayoutTests
[Qt] Unskip compositing & 3d-rendering tests
https://bugs.webkit.org/show_bug.cgi?id=78687
Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-02-28
Reviewed by Noam Rosenthal.
- platform/qt-4.8/Skipped:
- platform/qt-5.0-wk1/Skipped:
- platform/qt-5.0-wk2/Skipped:
- platform/qt-5.0-wk2/compositing/animation/busy-indicator-expected.png: Added.
- platform/qt-5.0-wk2/compositing/animation/state-at-end-event-transform-layer-expected.png: Added.
- platform/qt-5.0-wk2/compositing/animation/state-at-end-event-transform-layer-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/color-matching/image-color-matching-expected.png: Added.
- platform/qt-5.0-wk2/compositing/color-matching/image-color-matching-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/color-matching/pdf-image-match-expected.png: Added.
- platform/qt-5.0-wk2/compositing/color-matching/pdf-image-match-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/compositing-visible-descendant-expected.png: Added.
- platform/qt-5.0-wk2/compositing/compositing-visible-descendant-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/direct-image-compositing-expected.png: Added.
- platform/qt-5.0-wk2/compositing/direct-image-compositing-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/framesets/composited-frame-alignment-expected.png: Added.
- platform/qt-5.0-wk2/compositing/generated-content-expected.png: Added.
- platform/qt-5.0-wk2/compositing/generated-content-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/geometry/abs-position-inside-opacity-expected.png: Added.
- platform/qt-5.0-wk2/compositing/geometry/abs-position-inside-opacity-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/geometry/clipping-foreground-expected.png: Added.
- platform/qt-5.0-wk2/compositing/geometry/clipping-foreground-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/geometry/composited-html-size-expected.png: Added.
- platform/qt-5.0-wk2/compositing/geometry/composited-html-size-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/geometry/fixed-in-composited-expected.png: Added.
- platform/qt-5.0-wk2/compositing/geometry/fixed-in-composited-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/geometry/fixed-position-composited-page-scale-down-expected.png: Added.
- platform/qt-5.0-wk2/compositing/geometry/fixed-position-composited-page-scale-expected.png: Added.
- platform/qt-5.0-wk2/compositing/geometry/fixed-position-expected.png: Added.
- platform/qt-5.0-wk2/compositing/geometry/fixed-position-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
- platform/qt-5.0-wk2/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png: Added.
- platform/qt-5.0-wk2/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Added.
- platform/qt-5.0-wk2/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png: Added.
- platform/qt-5.0-wk2/compositing/geometry/foreground-layer-expected.png: Added.
- platform/qt-5.0-wk2/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
- platform/qt-5.0-wk2/compositing/geometry/horizontal-scroll-composited-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
- platform/qt-5.0-wk2/compositing/geometry/layer-due-to-layer-children-deep-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
- platform/qt-5.0-wk2/compositing/geometry/layer-due-to-layer-children-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png: Added.
- platform/qt-5.0-wk2/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/geometry/outline-change-expected.png: Added.
- platform/qt-5.0-wk2/compositing/geometry/outline-change-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/geometry/partial-layout-update-expected.png: Added.
- platform/qt-5.0-wk2/compositing/geometry/partial-layout-update-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/geometry/preserve-3d-switching-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/geometry/repaint-foreground-layer-expected.png: Added.
- platform/qt-5.0-wk2/compositing/geometry/root-layer-update-expected.png: Added.
- platform/qt-5.0-wk2/compositing/geometry/root-layer-update-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.png: Added.
- platform/qt-5.0-wk2/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/geometry/vertical-scroll-composited-expected.png: Added.
- platform/qt-5.0-wk2/compositing/geometry/vertical-scroll-composited-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/geometry/video-fixed-scrolling-expected.png: Added.
- platform/qt-5.0-wk2/compositing/geometry/video-fixed-scrolling-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/iframes/composited-iframe-alignment-expected.png: Added.
- platform/qt-5.0-wk2/compositing/iframes/composited-iframe-alignment-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/iframes/iframe-copy-on-scroll-expected.png: Added.
- platform/qt-5.0-wk2/compositing/iframes/iframe-copy-on-scroll-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/iframes/iframe-in-composited-layer-expected.png: Added.
- platform/qt-5.0-wk2/compositing/iframes/iframe-in-composited-layer-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/iframes/resizer-expected.png: Added.
- platform/qt-5.0-wk2/compositing/iframes/resizer-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/images/direct-image-background-color-expected.png: Added.
- platform/qt-5.0-wk2/compositing/images/direct-image-background-color-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/layer-creation/spanOverlapsCanvas-expected.png: Added.
- platform/qt-5.0-wk2/compositing/layers-inside-overflow-scroll-expected.png: Added.
- platform/qt-5.0-wk2/compositing/layers-inside-overflow-scroll-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/overflow/fixed-position-ancestor-clip-expected.png: Added.
- platform/qt-5.0-wk2/compositing/overflow/fixed-position-ancestor-clip-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/overflow/overflow-compositing-descendant-expected.png: Added.
- platform/qt-5.0-wk2/compositing/overflow/overflow-compositing-descendant-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/overflow/overflow-positioning-expected.png: Added.
- platform/qt-5.0-wk2/compositing/overflow/overflow-positioning-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Added.
- platform/qt-5.0-wk2/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/overflow/overflow-scroll-expected.png: Added.
- platform/qt-5.0-wk2/compositing/overflow/overflow-scroll-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/overflow/parent-overflow-expected.png: Added.
- platform/qt-5.0-wk2/compositing/overflow/parent-overflow-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/overflow/scroll-ancestor-update-expected.png: Added.
- platform/qt-5.0-wk2/compositing/overflow/scroll-ancestor-update-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/overflow/scrollbar-painting-expected.png: Added.
- platform/qt-5.0-wk2/compositing/overflow/scrollbar-painting-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/overflow/theme-affects-visual-overflow-expected.png: Added.
- platform/qt-5.0-wk2/compositing/overflow/theme-affects-visual-overflow-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/plugins/composited-plugin-expected.png: Added.
- platform/qt-5.0-wk2/compositing/plugins/composited-plugin-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/repaint/become-overlay-composited-layer-expected.png: Added.
- platform/qt-5.0-wk2/compositing/repaint/become-overlay-composited-layer-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/repaint/composited-document-element-expected.png: Added.
- platform/qt-5.0-wk2/compositing/repaint/composited-document-element-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/repaint/content-into-overflow-expected.png: Added.
- platform/qt-5.0-wk2/compositing/repaint/content-into-overflow-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/repaint/layer-repaint-expected.png: Added.
- platform/qt-5.0-wk2/compositing/repaint/layer-repaint-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/repaint/layer-repaint-rects-expected.png: Added.
- platform/qt-5.0-wk2/compositing/repaint/layer-repaint-rects-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/repaint/opacity-between-absolute-expected.png: Added.
- platform/qt-5.0-wk2/compositing/repaint/opacity-between-absolute-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/repaint/opacity-between-absolute2-expected.png: Added.
- platform/qt-5.0-wk2/compositing/repaint/opacity-between-absolute2-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/repaint/overflow-into-content-expected.png: Added.
- platform/qt-5.0-wk2/compositing/repaint/overflow-into-content-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/repaint/same-size-invalidation-expected.png: Added.
- platform/qt-5.0-wk2/compositing/scaling/tiled-layer-recursion-expected.png: Added.
- platform/qt-5.0-wk2/compositing/self-painting-layers-expected.png: Added.
- platform/qt-5.0-wk2/compositing/self-painting-layers-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/shadows/shadow-drawing-expected.png: Added.
- platform/qt-5.0-wk2/compositing/shadows/shadow-drawing-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/sibling-positioning-expected.png: Added.
- platform/qt-5.0-wk2/compositing/sibling-positioning-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/text-on-large-layer-expected.png: Added.
- platform/qt-5.0-wk2/compositing/text-on-large-layer-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/transitions/scale-transition-no-start-expected.png: Added.
- platform/qt-5.0-wk2/compositing/transitions/scale-transition-no-start-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/transitions/singular-scale-transition-expected.png: Added.
- platform/qt-5.0-wk2/compositing/transitions/singular-scale-transition-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/video/video-background-color-expected.png: Added.
- platform/qt-5.0-wk2/compositing/video/video-background-color-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/visibility/visibility-composited-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/visibility/visibility-composited-transforms-expected.txt: Added.
- platform/qt/Skipped:
- 4:10 PM Changeset in webkit [109166] by
-
- 2 edits in trunk/Tools
Fix a typo in config.json
linx -> linux
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 4:07 PM Changeset in webkit [109165] by
-
- 2 edits in trunk/LayoutTests
Remove suppressions of SVG crash flakiness on cr-mac
https://bugs.webkit.org/show_bug.cgi?id=79707
Unreviewed gardening.
The suspect cause of these failures was rolled out in r109164.
Removing the suppressions to see if the rollout fixes them.
- platform/chromium/test_expectations.txt:
- 4:03 PM Changeset in webkit [109164] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening, mark another compositing as flaky.
https://bugs.webkit.org/show_bug.cgi?id=79823
- platform/chromium/test_expectations.txt:
- 3:58 PM Changeset in webkit [109163] by
-
- 10 edits in trunk/LayoutTests
No extra silence needed in multi-channels support layout test cases
https://bugs.webkit.org/show_bug.cgi?id=79752
Patch by Wei James <james.wei@intel.com> on 2012-02-28
Reviewed by Chris Rogers.
- webaudio/audiobuffersource-multi-channels-expected.wav:
- webaudio/audiobuffersource-multi-channels.html:
- webaudio/resources/mix-testing.js:
- webaudio/up-mixing-mono-51-expected.wav:
- webaudio/up-mixing-mono-51.html:
- webaudio/up-mixing-mono-stereo-expected.wav:
- webaudio/up-mixing-mono-stereo.html:
- webaudio/up-mixing-stereo-51-expected.wav:
- webaudio/up-mixing-stereo-51.html:
- 3:53 PM Changeset in webkit [109162] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed, rolling out r108834.
http://trac.webkit.org/changeset/108834
https://bugs.webkit.org/show_bug.cgi?id=79840
Seems to cause a number of crashes under
FrameView::doDeferredRepaints (Requested by jamesr on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-28
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::draw):
- svg/graphics/SVGImage.h:
- svg/graphics/SVGImageCache.cpp:
(WebCore::SVGImageCache::imageContentChanged):
(WebCore::SVGImageCache::redrawTimerFired):
- svg/graphics/SVGImageCache.h:
(SVGImageCache):
- 3:44 PM Changeset in webkit [109161] by
-
- 3 edits in trunk/Source/WebCore
[GTK] Add support for nested event loops in RunLoop
https://bugs.webkit.org/show_bug.cgi?id=79499
Reviewed by Martin Robinson.
Run a new nested mainloop if the main event loop is already
running when calling to RunLoop::run(), and take care of stopping
the right main loop too when RunLoop::stop() is invoked.
- platform/RunLoop.h:
(RunLoop):
- platform/gtk/RunLoopGtk.cpp:
(WebCore::RunLoop::RunLoop):
(WebCore::RunLoop::~RunLoop):
(WebCore::RunLoop::run):
(WebCore::RunLoop::innermostLoop):
(WebCore::RunLoop::pushNestedMainLoop):
(WebCore::RunLoop::popNestedMainLoop):
(WebCore):
(WebCore::RunLoop::stop):
- 3:28 PM Changeset in webkit [109160] by
-
- 5 edits in branches/subpixellayout/Source
Revert absoluteCaretBounds to IntRect on branch.
- 3:16 PM Changeset in webkit [109159] by
-
- 2 edits in trunk/Source/WebKit2
More build fix.
- WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm: Check for build platform properly.
- 3:15 PM Changeset in webkit [109158] by
-
- 2 edits in trunk/Source/JavaScriptCore
Get rid of padding cruft in CopiedBlock
https://bugs.webkit.org/show_bug.cgi?id=79686
Reviewed by Filip Pizlo.
- heap/CopiedBlock.h:
(CopiedBlock): Removed the extra padding that was used for alignment purposes until
the calculation of the payload offset into CopiedBlocks was redone recently.
- 3:09 PM Changeset in webkit [109157] by
-
- 6 edits in trunk/Source/WebCore
Move RenderLayer::size() calls to a common function
https://bugs.webkit.org/show_bug.cgi?id=76972
Reviewed by Simon Fraser.
Refactoring only.
This change introduces RenderBox::cachedSizeForOverflowClip() that handles all the cached size
requests that currently goes through the RenderLayer. This indirection helps to decouple the need
for a RenderLayer so that we can lazily allocate RenderLayers as part of bug 75568.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::cachedSizeForOverflowClip):
Added this function to handle the calls to RenderLayer's size(). Unfortunately a lot of the
code calls RenderLayer::size() directly so I could not make it private.
- rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeRectForRepaint):
- rendering/RenderBox.h:
(RenderBox):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRectForRepaint):
(WebCore::RenderInline::computeRectForRepaint):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::computeRectForRepaint):
Fixed the call sites above.
- 3:08 PM Changeset in webkit [109156] by
-
- 6 edits32 moves10 adds4 deletes in trunk/LayoutTests
Move custom filter tests into subdir to make them easier to skip https://bugs.webkit.org/show_bug.cgi?id=79825
Reviewed by Simon Fraser.
Moved all CSS Shader tests into a 'custom' sub-directory. Added this directory
to the relevant skip lists.
- css3/filters/custom-filter-property-computed-style.html: Removed.
- css3/filters/custom-filter-property-parsing-invalid.html: Removed.
- css3/filters/custom-filter-property-parsing.html: Removed.
- css3/filters/custom/custom-filter-property-computed-style-expected.txt: Renamed from LayoutTests/css3/filters/custom-filter-property-computed-style-expected.txt.
- css3/filters/custom/custom-filter-property-computed-style.html: Added.
- css3/filters/custom/custom-filter-property-parsing-expected.txt: Renamed from LayoutTests/css3/filters/custom-filter-property-parsing-expected.txt.
- css3/filters/custom/custom-filter-property-parsing-invalid-expected.txt: Renamed from LayoutTests/css3/filters/custom-filter-property-parsing-invalid-expected.txt.
- css3/filters/custom/custom-filter-property-parsing-invalid.html: Added.
- css3/filters/custom/custom-filter-property-parsing.html: Added.
- css3/filters/custom/custom-filter-shader-cache-expected.png: Renamed from LayoutTests/css3/filters/custom-filter-shader-cache-expected.png.
- css3/filters/custom/custom-filter-shader-cache-expected.txt: Renamed from LayoutTests/css3/filters/custom-filter-shader-cache-expected.txt.
- css3/filters/custom/custom-filter-shader-cache.html: Renamed from LayoutTests/css3/filters/custom-filter-shader-cache.html.
- css3/filters/custom/effect-custom-combined-missing-expected.png: Renamed from LayoutTests/css3/filters/effect-custom-combined-missing-expected.png.
- css3/filters/custom/effect-custom-combined-missing-expected.txt: Renamed from LayoutTests/css3/filters/effect-custom-combined-missing-expected.txt.
- css3/filters/custom/effect-custom-combined-missing.html: Renamed from LayoutTests/css3/filters/effect-custom-combined-missing.html.
- css3/filters/custom/effect-custom-disabled-expected.txt: Renamed from LayoutTests/css3/filters/effect-custom-disabled-expected.txt.
- css3/filters/custom/effect-custom-disabled.html: Added.
- css3/filters/custom/effect-custom-expected.png: Renamed from LayoutTests/css3/filters/effect-custom-expected.png.
- css3/filters/custom/effect-custom-expected.txt: Renamed from LayoutTests/css3/filters/effect-custom-expected.txt.
- css3/filters/custom/effect-custom-parameters-expected.png: Renamed from LayoutTests/css3/filters/effect-custom-parameters-expected.png.
- css3/filters/custom/effect-custom-parameters-expected.txt: Renamed from LayoutTests/css3/filters/effect-custom-parameters-expected.txt.
- css3/filters/custom/effect-custom-parameters.html: Renamed from LayoutTests/css3/filters/effect-custom-parameters.html.
- css3/filters/custom/effect-custom.html: Renamed from LayoutTests/css3/filters/effect-custom.html.
- css3/filters/custom/missing-custom-filter-shader-expected.png: Renamed from LayoutTests/css3/filters/missing-custom-filter-shader-expected.png.
- css3/filters/custom/missing-custom-filter-shader-expected.txt: Renamed from LayoutTests/css3/filters/missing-custom-filter-shader-expected.txt.
- css3/filters/custom/missing-custom-filter-shader.html: Renamed from LayoutTests/css3/filters/missing-custom-filter-shader.html.
- css3/filters/effect-custom-disabled.html: Removed.
- platform/chromium-mac-leopard/css3/filters/custom/effect-custom-combined-missing-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/css3/filters/effect-custom-combined-missing-expected.png.
- platform/chromium-mac-leopard/css3/filters/custom/effect-custom-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/css3/filters/effect-custom-expected.png.
- platform/chromium-mac-leopard/css3/filters/custom/effect-custom-parameters-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/css3/filters/effect-custom-parameters-expected.png.
- platform/chromium-mac-snowleopard/css3/filters/custom/effect-custom-combined-missing-expected.png: Renamed from LayoutTests/platform/chromium-mac-snowleopard/css3/filters/effect-custom-combined-missing-expected.png.
- platform/chromium-win/css3/filters/custom/effect-custom-combined-missing-expected.png: Renamed from LayoutTests/platform/chromium-win/css3/filters/effect-custom-combined-missing-expected.png.
- platform/chromium-win/css3/filters/custom/effect-custom-expected.png: Renamed from LayoutTests/platform/chromium-win/css3/filters/effect-custom-expected.png.
- platform/chromium-win/css3/filters/custom/effect-custom-parameters-expected.png: Renamed from LayoutTests/platform/chromium-win/css3/filters/effect-custom-parameters-expected.png.
- platform/chromium/css3/filters/custom/effect-custom-combined-missing-expected.txt: Renamed from LayoutTests/platform/chromium/css3/filters/effect-custom-combined-missing-expected.txt.
- platform/chromium/css3/filters/custom/effect-custom-disabled-expected.txt: Renamed from LayoutTests/platform/chromium/css3/filters/effect-custom-disabled-expected.txt.
- platform/chromium/css3/filters/custom/effect-custom-expected.txt: Renamed from LayoutTests/platform/chromium/css3/filters/effect-custom-expected.txt.
- platform/chromium/css3/filters/custom/effect-custom-parameters-expected.txt: Renamed from LayoutTests/platform/chromium/css3/filters/effect-custom-parameters-expected.txt.
- platform/chromium/test_expectations.txt:
- platform/mac-snowleopard/css3/filters/custom/effect-custom-expected.png: Renamed from LayoutTests/platform/mac-snowleopard/css3/filters/effect-custom-expected.png.
- platform/mac-snowleopard/css3/filters/custom/effect-custom-parameters-expected.png: Renamed from LayoutTests/platform/mac-snowleopard/css3/filters/effect-custom-parameters-expected.png.
- platform/qt-5.0-wk2/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- 3:05 PM Changeset in webkit [109155] by
-
- 7 edits in trunk/Source
Provide DefaultDeviceScaleFactor though WebSettings
https://bugs.webkit.org/show_bug.cgi?id=79534
Patch by Tim Dresser <tdresser@chromium.org> on 2012-02-28
Reviewed by Darin Fisher.
Source/WebCore:
- page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setDefaultDeviceScaleFactor):
(WebCore):
- page/Settings.h:
(Settings):
(WebCore::Settings::defaultDeviceScaleFactor):
Source/WebKit/chromium:
- public/WebSettings.h:
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setDefaultDeviceScaleFactor):
(WebKit):
- src/WebSettingsImpl.h:
(WebSettingsImpl):
- 2:58 PM Changeset in webkit [109154] by
-
- 2 edits in trunk/Source/WebCore
Fix build.
- 2:55 PM Changeset in webkit [109153] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening, mark more SVG tests as flaky crashers on cr-mac.
https://bugs.webkit.org/show_bug.cgi?id=79707
- platform/chromium/test_expectations.txt:
- 2:28 PM Changeset in webkit [109152] by
-
- 2 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=79824
Unreviewed build fix for when ENABLE(CSS_FILTERS) is on
but ENABLE(CSS_SHADERS) is off.
- css/WebKitCSSFilterValue.cpp:
(WebCore::WebKitCSSFilterValue::typeUsesSpaceSeparator):
- 2:26 PM Changeset in webkit [109151] by
-
- 3 edits in trunk/Source/WebCore
Slow content causes choppy scrolling
https://bugs.webkit.org/show_bug.cgi?id=79403
Patch by Dave Moore <davemoore@chromium.org> on 2012-02-28
Reviewed by James Robinson.
This code helps make scrolling (via wheel or pad) less choppy
when the content takes a long time to respond to the fake mouse moves
generated during scrolls.
- page/EventHandler.cpp:
(WebCore):
(MaximumDurationTracker):
(WebCore::MaximumDurationTracker::MaximumDurationTracker):
(WebCore::MaximumDurationTracker::~MaximumDurationTracker):
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clear):
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::dispatchFakeMouseMoveEventSoon):
(WebCore::EventHandler::dispatchFakeMouseMoveEventSoonInQuad):
- page/EventHandler.h:
- 2:23 PM Changeset in webkit [109150] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Change the API to use std::string
https://bugs.webkit.org/show_bug.cgi?id=79818
Patch by Konrad Piascik <kpiascik@rim.com> on 2012-02-28
Reviewed by Antonio Gomes.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::dispatchInspectorMessage):
- Api/WebPage.h:
- 2:21 PM Changeset in webkit [109149] by
-
- 67 edits in trunk/Source/WebCore
StyledElement::isPresentationAttribute() only needs the attribute name.
<http://webkit.org/b/79828>
Reviewed by Anders Carlsson.
Pass the QualifiedName to isPresentationAttribute instead of the whole
Attribute. We only need the name to know what kind of attribute it is.
This makes the code a little less ugly and makes it possible to use
the function without having an Attribute object.
- dom/StyledElement.cpp:
(WebCore::StyledElement::attributeChanged):
- dom/StyledElement.h:
(WebCore::StyledElement::isPresentationAttribute):
- html/HTMLBRElement.cpp:
(WebCore::HTMLBRElement::isPresentationAttribute):
- html/HTMLBRElement.h:
- html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::isPresentationAttribute):
- html/HTMLBodyElement.h:
- html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::isPresentationAttribute):
- html/HTMLButtonElement.h:
- html/HTMLDivElement.cpp:
(WebCore::HTMLDivElement::isPresentationAttribute):
- html/HTMLDivElement.h:
- html/HTMLElement.cpp:
(WebCore::HTMLElement::isPresentationAttribute):
- html/HTMLElement.h:
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::isPresentationAttribute):
- html/HTMLEmbedElement.h:
- html/HTMLFontElement.cpp:
(WebCore::HTMLFontElement::isPresentationAttribute):
- html/HTMLFontElement.h:
- html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::isPresentationAttribute):
- html/HTMLFrameSetElement.h:
- html/HTMLHRElement.cpp:
(WebCore::HTMLHRElement::isPresentationAttribute):
- html/HTMLHRElement.h:
- html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::isPresentationAttribute):
- html/HTMLIFrameElement.h:
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::isPresentationAttribute):
- html/HTMLImageElement.h:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isPresentationAttribute):
- html/HTMLInputElement.h:
- html/HTMLLIElement.cpp:
(WebCore::HTMLLIElement::isPresentationAttribute):
- html/HTMLLIElement.h:
- html/HTMLMarqueeElement.cpp:
(WebCore::HTMLMarqueeElement::isPresentationAttribute):
- html/HTMLMarqueeElement.h:
- html/HTMLOListElement.cpp:
(WebCore::HTMLOListElement::isPresentationAttribute):
- html/HTMLOListElement.h:
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::isPresentationAttribute):
- html/HTMLObjectElement.h:
- html/HTMLParagraphElement.cpp:
(WebCore::HTMLParagraphElement::isPresentationAttribute):
- html/HTMLParagraphElement.h:
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::isPresentationAttribute):
- html/HTMLPlugInElement.h:
- html/HTMLPreElement.cpp:
(WebCore::HTMLPreElement::isPresentationAttribute):
- html/HTMLPreElement.h:
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::isPresentationAttribute):
- html/HTMLSelectElement.h:
- html/HTMLTableCaptionElement.cpp:
(WebCore::HTMLTableCaptionElement::isPresentationAttribute):
- html/HTMLTableCaptionElement.h:
- html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::isPresentationAttribute):
- html/HTMLTableCellElement.h:
- html/HTMLTableColElement.cpp:
(WebCore::HTMLTableColElement::isPresentationAttribute):
- html/HTMLTableColElement.h:
- html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::isPresentationAttribute):
- html/HTMLTableElement.h:
- html/HTMLTablePartElement.cpp:
(WebCore::HTMLTablePartElement::isPresentationAttribute):
- html/HTMLTablePartElement.h:
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::isPresentationAttribute):
- html/HTMLTextAreaElement.h:
- html/HTMLUListElement.cpp:
(WebCore::HTMLUListElement::isPresentationAttribute):
- html/HTMLUListElement.h:
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::isPresentationAttribute):
- html/HTMLVideoElement.h:
- mathml/MathMLElement.cpp:
(WebCore::MathMLElement::isPresentationAttribute):
- mathml/MathMLElement.h:
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::isPresentationAttribute):
- svg/SVGImageElement.h:
- svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::isPresentationAttribute):
- svg/SVGStyledElement.h:
- svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::isPresentationAttribute):
- svg/SVGTextContentElement.h:
- 2:20 PM Changeset in webkit [109148] by
-
- 2 edits in trunk/Source/WebKit2
Build fix.
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_GetValue): Check for build platform properly.
- 1:58 PM Changeset in webkit [109147] by
-
- 15 edits1 delete in trunk/Source
More Pasteboard code cleanup.
https://bugs.webkit.org/show_bug.cgi?id=79816
Source/WebCore:
Removing the last references to NSPasteboard.
Reviewed by Alexey Proskuryakov.
No new tests. No change in functionality.
- WebCore.xcodeproj/project.pbxproj:
- editing/mac/EditorMac.mm:
(WebCore::Editor::pasteWithPasteboard):
(WebCore::Editor::takeFindStringFromSelection):
- loader/EmptyClients.h:
(WebCore::EmptyEditorClient::setInsertionPasteboard):
- page/DragClient.h:
- page/EditorClient.h:
- platform/DragData.h:
- platform/Pasteboard.h:
- platform/mac/ClipboardMac.h:
- platform/mac/PasteboardHelper.h: Removed.
Source/WebKit/mac:
Removing the last references to NSPasteboard.
Reviewed by Alexey Proskuryakov.
- WebCoreSupport/WebEditorClient.h:
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::setInsertionPasteboard):
Source/WebKit2:
Removing the last references to NSPasteboard.
Reviewed by Alexey Proskuryakov.
- WebProcess/WebCoreSupport/WebEditorClient.h:
- WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
(WebKit::WebEditorClient::setInsertionPasteboard):
- 1:49 PM Changeset in webkit [109146] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r109137.
http://trac.webkit.org/changeset/109137
https://bugs.webkit.org/show_bug.cgi?id=79833
Broke cr-mac build (Requested by aklein on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-28
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore):
(WebCore::pathFromFont):
- 1:45 PM Changeset in webkit [109145] by
-
- 2 edits in branches/subpixellayout/Source
Fix chromium build on branch.
- 1:43 PM Changeset in webkit [109144] by
-
- 4 edits3 adds in trunk
Add a fallback path to LineBreakIteratorPoolICU when the locale
name from a web page is invalid and ICU fails to get a line break
iterator instance. Also add a null check to
TextBreakIteratorICU::acquireLineBreakIterator.
https://bugs.webkit.org/show_bug.cgi?id=67640
Reviewed by Dan Bernstein.
Source/WebCore:
Test: fast/text/invalid-locale.html
- platform/text/LineBreakIteratorPoolICU.h:
(WebCore::LineBreakIteratorPool::take):
- platform/text/TextBreakIteratorICU.cpp:
(WebCore::acquireLineBreakIterator):
LayoutTests:
- fast/text/invalid-locale-expected.txt: Added.
- fast/text/invalid-locale.html: Added.
- fast/text/resources/invalid-locale.html: Added.
- 1:16 PM Changeset in webkit [109143] by
-
- 4 edits3 adds in trunk/Source/WebKit2
[Mac] Add an experimental SPI for plug-ins to enter sandbox
https://bugs.webkit.org/show_bug.cgi?id=79709
Reviewed by Anders Carlsson.
- PluginProcess/PluginProcess.h: (WebKit::PluginProcess::pluginPath): Exposed plugin path.
- PluginProcess/mac/com.apple.WebKit.PluginProcess.sb: Added.
- WebKit2.xcodeproj/project.pbxproj: Added new files.
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_GetValue): Exposed
a function to access sandboxing functions when available.
- WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.h: Added.
- WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm: Added.
- 1:00 PM Changeset in webkit [109142] by
-
- 3 edits2 adds in trunk
Crash due to accessing removed continuation in multi-column layout.
https://bugs.webkit.org/show_bug.cgi?id=78417
Reviewed by David Hyatt.
Source/WebCore:
This patch addresses two problems:
- Run-in block got split due to addition of a column-span child.
The clone part was incorrectly intruding into the sibling block,
even when it was part of the continuation chain.
- Like r73296, we don't need to set continuation on an
anonymous block since we haven't split a real element.
Test: fast/multicol/span/runin-continuation-crash.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
(WebCore::RenderBlock::handleRunInChild):
LayoutTests:
- fast/multicol/span/runin-continuation-crash-expected.txt: Added.
- fast/multicol/span/runin-continuation-crash.html: Added.
- 12:46 PM Changeset in webkit [109141] by
-
- 5 edits in trunk/WebKitLibraries
[Mac] Add an experimental SPI for plug-ins to enter sandbox
https://bugs.webkit.org/show_bug.cgi?id=79709
This pulls a lot of WKSI changes at once, because the script that updates it didn't
work for a while.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- 12:46 PM Changeset in webkit [109140] by
-
- 3 edits3 adds in trunk
Incorrect before child parent calculation when adding new children
to anonymous column blocks.
https://bugs.webkit.org/show_bug.cgi?id=79755
Reviewed by David Hyatt.
Source/WebCore:
before child can be wrapped in anonymous containers, so need to
take care of that in before child parent calculation.
Test: fast/multicol/span/before-child-anonymous-column-block.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addChildToAnonymousColumnBlocks):
LayoutTests:
Test passes if you don't see the div block inside table and you see
two blocks in different columns in the pixel test.
- fast/multicol/span/before-child-anonymous-column-block-expected.png: Added.
- fast/multicol/span/before-child-anonymous-column-block-expected.txt: Added.
- fast/multicol/span/before-child-anonymous-column-block.html: Added.
- 12:43 PM Changeset in webkit [109139] by
-
- 2 edits in trunk/LayoutTests
Mark compositing/repaint/opacity-between-absolute.html as flaky.
Unreviewed gardening.
- platform/chromium/test_expectations.txt:
- 12:28 PM Changeset in webkit [109138] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix build with newer versions of clang.
Clang now warns since we're not passing a CFString literal to CFStringCreateWithFormatAndArguments,
but it's OK to ignore this warning since clang is also checking that the caller (vprintf_stderr_common)
takes a string literal.
- wtf/Assertions.cpp:
- 12:28 PM Changeset in webkit [109137] by
-
- 2 edits in trunk/Source/WebCore
Reimplement pathFromFont() in SimpleFontDataMac.mm
https://bugs.webkit.org/show_bug.cgi?id=79811
Patch by Ned Holbrook <nholbrook@apple.com> on 2012-02-28
Reviewed by Dan Bernstein.
Debug-only function, so no new tests.
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::pathFromFont): Reimplemented.
- 12:28 PM WebKitGTK/1.8.x edited by
- (diff)
- 12:25 PM Changeset in webkit [109136] by
-
- 26 edits in trunk
[Qt] Allow read/write to the WebView.url property
https://bugs.webkit.org/show_bug.cgi?id=77554
Reviewed by Tor Arne Vestbø.
Source/WebKit2:
Change QML API WebView.url to read/write to reflect either the url requested by the user.
Also removed WebView.load(url). Defers setting url (loading page) until onComponentComplete is triggered.
Fixed c++ and qml tests to reflect the new API.
- Target.pri:
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::onComponentComplete):
(QQuickWebView::setUrl):
- UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
- UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp:
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_itemSelector.qml:
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml:
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_messaging.qml:
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml:
- UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml:
- UIProcess/API/qt/tests/qmltests/WebView/tst_download.qml:
- UIProcess/API/qt/tests/qmltests/WebView/tst_favIconLoad.qml:
- UIProcess/API/qt/tests/qmltests/WebView/tst_geopermission.qml:
- UIProcess/API/qt/tests/qmltests/WebView/tst_javaScriptDialogs.qml:
- UIProcess/API/qt/tests/qmltests/WebView/tst_loadFail.qml:
- UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgress.qml:
- UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgressSignal.qml:
- UIProcess/API/qt/tests/qmltests/WebView/tst_loadUrl.qml:
- UIProcess/API/qt/tests/qmltests/WebView/tst_navigationHistory.qml:
- UIProcess/API/qt/tests/qmltests/WebView/tst_origin.qml:
- UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml:
- UIProcess/API/qt/tests/qmltests/WebView/tst_properties.qml:
- UIProcess/API/qt/tests/qmltests/WebView/tst_titleChanged.qml:
- UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView::loadEmptyPageViewHidden):
(tst_QQuickWebView::loadNonexistentFileUrl):
Tools:
Fix MiniBrowser to use WebView.url property and remove WebView.load usage.
- MiniBrowser/qt/qml/BrowserWindow.qml:
- 12:14 PM Modules edited by
- (diff)
- 12:06 PM Changeset in webkit [109135] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] x86 build fix after cleaning up WebPage.cpp
https://bugs.webkit.org/show_bug.cgi?id=79814
Patch by Jacky Jiang <zhajiang@rim.com> on 2012-02-28
Reviewed by Antonio Gomes.
x86 build fix, keep WebPage::destroyWebPageCompositor() method where it
was which was outside of USE(ACCELERATED_COMPOSITING).
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::destroyWebPageCompositor):
(WebKit):
- 12:00 PM WebKitGTK/1.8.x edited by
- Added r108540 as proposed merge (diff)
- 11:55 AM Changeset in webkit [109134] by
-
- 5 edits in trunk
getComputedStyle fails for 'first-line' pseudo-element
https://bugs.webkit.org/show_bug.cgi?id=57505
Reviewed by Tony Chang.
Source/WebCore:
Querying the selector with a pseudo-element using getComputedStyle should work
even if the selector was not declared in the stylesheet. When not declared, we need
to use the RenderStyle created to do the rendering as there is no pseudo-style.
This match the behavior of Firefox.
No new tests : Updated expectation and extended getComputedStyle-with-pseudo-element.html.
- dom/Element.cpp:
(WebCore::Element::computedStyle):
LayoutTests:
Update expected results to the new behavior. Also added some extra checks on
other pseudo-elements.
- fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt:
- fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html:
- 11:52 AM Changeset in webkit [109133] by
-
- 11 edits3 adds in trunk/Source/WebCore
Move FILE_SYSTEM code out of WorkerContext and into the fileapi folder
https://bugs.webkit.org/show_bug.cgi?id=79449
Patch by Ashod Nakashian <ashodnakashian@yahoo.com> on 2012-02-28
Reviewed by Adam Barth.
This moves FILE_SYSTEM code out of WorkerContext and into the fileapi/WorkerContextFileSystem.
None-functional changes, no new tests necessary.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- fileapi/WorkerContextFileSystem.cpp: Added.
(WebCore):
(WebCore::WorkerContextFileSystem::webkitRequestFileSystem):
(WebCore::WorkerContextFileSystem::webkitRequestFileSystemSync):
(WebCore::WorkerContextFileSystem::webkitResolveLocalFileSystemURL):
(WebCore::WorkerContextFileSystem::webkitResolveLocalFileSystemSyncURL):
- fileapi/WorkerContextFileSystem.h: Added.
(WebCore):
(WorkerContextFileSystem):
- fileapi/WorkerContextFileSystem.idl: Added.
- workers/WorkerContext.cpp:
(WebCore::WorkerContext::ensureEventTargetData):
- workers/WorkerContext.h:
(WebCore):
(WorkerContext):
- workers/WorkerContext.idl:
- 11:49 AM Changeset in webkit [109132] by
-
- 4 edits2 adds in trunk
FileReader crashes when file is not readable
https://bugs.webkit.org/show_bug.cgi?id=79715
Reviewed by Jian Li.
Source/WebCore:
Test: fast/files/file-reader-directory-crash.html
- platform/SharedBuffer.cpp: (WebCore::SharedBuffer::SharedBuffer): Crash early if a caller
mixed up in-band error signal with length again.
- platform/network/BlobResourceHandle.cpp:
(WebCore): Changed errors into an enum. Added a proper domain for blob errors.
(WebCore::BlobResourceHandle::didReceiveResponse): There is already a constant for INT_MAX
in C/C++.
(WebCore::BlobResourceHandle::didRead): Don't send "-1" for failure down the success path.
(WebCore::BlobResourceHandle::notifyFail): Use a proper domain for blob errors, and a non-
empty message.
LayoutTests:
- fast/files/file-reader-directory-crash-expected.txt: Added.
- fast/files/file-reader-directory-crash.html: Added.
- 11:47 AM Changeset in webkit [109131] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix cr-win build after r109119.
- platform/graphics/chromium/TransparencyWin.h:
(TransparencyWin):
- 11:40 AM Changeset in webkit [109130] by
-
- 10 edits in trunk/Source/WebKit2
[Qt] Signal and property cleanup in QQuickWebView
https://bugs.webkit.org/show_bug.cgi?id=78820
Reviewed by Noam Rosenthal.
- Remove parameters from property change notify signals: titleChanged, urlChanged, iconChanged, loadProgressChanged
- Rename the parameters of linkHovered to prevent shadoing properties of WebView
- Rename navigationStateChanged to navigationHistoryChanged
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::_q_onUrlChanged):
(QQuickWebViewPrivate::setIcon):
- UIProcess/API/qt/qquickwebview_p.h:
- UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
- UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp:
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml:
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml:
- UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView::loadProgress):
- UIProcess/qt/QtWebPageLoadClient.cpp:
(QtWebPageLoadClient::didCommitLoadForFrame):
(QtWebPageLoadClient::didSameDocumentNavigationForFrame):
(QtWebPageLoadClient::didReceiveTitleForFrame):
(QtWebPageLoadClient::setLoadProgress):
- UIProcess/qt/QtWebPageLoadClient.h:
(QtWebPageLoadClient):
- 11:35 AM Changeset in webkit [109129] by
-
- 13 edits in trunk/Source
[GTK] Add GMainLoop and GMainContext to be handled by GRefPtr
https://bugs.webkit.org/show_bug.cgi?id=79496
Reviewed by Martin Robinson.
Source/JavaScriptCore:
Handle GMainLoop and GMainContext in GRefPtr, by calling
g_main_loop_(un)ref and g_main_context_(un)ref in the
implementation of the refGPtr and derefGPtr template functions.
- wtf/gobject/GRefPtr.cpp:
(WTF::refGPtr):
(WTF):
(WTF::derefGPtr):
- wtf/gobject/GRefPtr.h:
(WTF):
- wtf/gobject/GTypedefs.h:
Source/WebCore:
Updated places where raw pointers to GMainLoop and GMainContext
were being used, replacing them with GRefPtr-based code.
- platform/RunLoop.h:
(RunLoop):
- platform/gtk/RunLoopGtk.cpp:
(WebCore::RunLoop::RunLoop):
(WebCore::RunLoop::~RunLoop):
(WebCore::RunLoop::mainLoop):
(WebCore::RunLoop::stop):
(WebCore::RunLoop::wakeUp):
(WebCore::RunLoop::TimerBase::start):
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCoreSynchronousLoader):
(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
(WebCore::WebCoreSynchronousLoader::~WebCoreSynchronousLoader):
(WebCore::WebCoreSynchronousLoader::didFinishLoading):
(WebCore::WebCoreSynchronousLoader::run):
Source/WebKit2:
Updated places where raw pointers to GMainLoop and GMainContext
were being used, replacing them with GRefPtr-based code.
- Platform/WorkQueue.h:
(WorkQueue):
- Platform/gtk/WorkQueueGtk.cpp:
(WorkQueue::platformInitialize):
(WorkQueue::platformInvalidate):
(WorkQueue::workQueueThreadBody):
(WorkQueue::registerEventSourceHandler):
(WorkQueue::dispatchOnSource):
- UIProcess/gtk/WebPopupMenuProxyGtk.cpp:
(WebKit::WebPopupMenuProxyGtk::WebPopupMenuProxyGtk):
(WebKit::WebPopupMenuProxyGtk::showPopupMenu):
(WebKit::WebPopupMenuProxyGtk::shutdownRunLoop):
- UIProcess/gtk/WebPopupMenuProxyGtk.h:
(WebPopupMenuProxyGtk):
- 11:32 AM Changeset in webkit [109128] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Set nativeKeyCode to include Windows scan code
https://bugs.webkit.org/show_bug.cgi?id=79289
Patch by Gary Kacmarcik <garykac@chromium.org> on 2012-02-28
Reviewed by Ryosuke Niwa.
Set the key event's nativeKeyCode on Windows Chromium so that it
actually includes the native scancode and other context bits.
Currently on Windows, the nativeKeyCode is set to be the same value as
the windowsKeyCode, which is redundant.
The actual native key information is required so that components (like
plugins) can reconstruct the original key event. The value stored in
the windowsKeyCode is a Windows virtual key code which does not provide
sufficient info to disambiguate the actual key being pressed (for
example, it cannot distinguish between the left and right shift keys).
All platforms except Windows currently send native key event info, so
this change will bring Windows in line with other platforms.
This change is part of our effort to send enhanced keycode information
to Pepper plugins in Chromium.
- src/win/WebInputEventFactory.cpp:
(WebKit::WebInputEventFactory::keyboardEvent):
- 11:26 AM Changeset in webkit [109127] by
-
- 2 edits in trunk/Tools
[GTK] make tests explicitly request GSettingsBackendMemory
https://bugs.webkit.org/show_bug.cgi?id=79788
Reviewed by Martin Robinson.
Explicitly request the fallback memory-based GSettings backend; if
other backends are available then we don't want to use them,
because they would make tests depend on the user's preferences.
And if other backends aren't available, we don't need glib to
print a warning about that fact.
- Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort.setup_environ_for_server):
- 11:24 AM Changeset in webkit [109126] by
-
- 3 edits in trunk/LayoutTests
Fix printing/zoomed-document.html for QT
https://bugs.webkit.org/show_bug.cgi?id=79808
Reviewed by Adam Barth.
Fix zoomed document test case to work on QT port and remove it from skip
list.
- platform/qt/Skipped:
- printing/zoomed-document.html:
- 11:15 AM Changeset in webkit [109125] by
-
- 3 edits2 adds in trunk
Heap-use-after-free in WebCore::RenderLayer::addChild
https://bugs.webkit.org/show_bug.cgi?id=79698
Reviewed by Simon Fraser.
Source/WebCore:
This patch fixes a regression introduced in r108659.
The reflection layer was moved to the parent by mistake. It was then
deleted and the parent was left holding on to a deleted pointer. This
patch restores the location where reflection layer is removed - before
moving the child layers.
Test: fast/reflections/toggle-reflection-crash.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::removeOnlyThisLayer):
LayoutTests:
- fast/reflections/toggle-reflection-crash-expected.txt: Added.
- fast/reflections/toggle-reflection-crash.html: Added.
- 11:12 AM Changeset in webkit [109124] by
-
- 3 edits2 adds in trunk
Crash from list marker having inline and block children
https://bugs.webkit.org/show_bug.cgi?id=79793
Patch by Ken Buchanan <kenrb@chromium.org> on 2012-02-28
Reviewed by Julien Chaffraix.
Source/WebCore:
Crashing condition in which an anonymous block was being collapsed
even though it had a block sibling. removeChild() was not checking
for siblings that might precede :before content renderers, such
as list items. This patch corrects that.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild)
LayoutTests:
Test to exercise crashing condition in bug 79793. This creates a list
marker that precedes a floating :before content renderer and then
modifies the render tree to remove a neighboring header element.
- fast/css-generated-content/floating-before-content-with-list-marker-crash-expected.txt: Added
- fast/css-generated-content/floating-before-content-with-list-marker-crash.html: Added
- 10:51 AM Changeset in webkit [109123] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Remove unused focusedNodeChange notifications from the Chrome client.
https://bugs.webkit.org/show_bug.cgi?id=79794
Patch by Mike Fenton <mifenton@rim.com> on 2012-02-28
Reviewed by Rob Buis.
Remove unused notification for focusedNodeChanged.
Internally reviewed by Gen Mak.
- Api/WebPageClient.h:
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::focusedNodeChanged):
- 10:48 AM Changeset in webkit [109122] by
-
- 31 edits in branches/subpixellayout/Source/WebCore
Reverting absoluteRects, addFocusRingRects, culledInlineAbsoluteRects, and drawFocusRing to IntRects. Also adding a pixelSnappedIntRect convenience function that takes a LayoutPoint and LayoutSize.
- 10:29 AM Changeset in webkit [109121] by
-
- 3 edits in trunk/Source/WebKit2
[Qt] Initialize QtWebContext as much as we can in its constructor.
https://bugs.webkit.org/show_bug.cgi?id=79809
Reviewed by Tor Arne Vestbø.
The icon database wouldn't be initialized on the QtWebContext while in WebKitTestRunner
since it doesn't call the initialize method on it after creating it.
Remove the initialize method, move the download manager and icon database initialization
in the constructor and call initializeContextInjectedBundleClient directly in
defaultContext to prevent overriding WKTR's injected bundle client.
- UIProcess/qt/QtWebContext.cpp:
(WebKit::QtWebContext::QtWebContext):
(WebKit::QtWebContext::defaultContext):
- UIProcess/qt/QtWebContext.h:
(QtWebContext):
- 10:24 AM Changeset in webkit [109120] by
-
- 5 edits in trunk/Source/WebKit2
[GTK] Inconsistent state of WebKitWebView when replacing content in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=79775
Reviewed by Martin Robinson.
Use an enum instead of a boolean to track the status of a
replace_content() load operation. We need to know when the load of
the replace content actually starts to not ignore valid load
events of a previous ongoing load operation.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewLoadChanged): Transit to new replace content state
when replacing content depending on the load event.
(webkitWebViewLoadFailed): Ignore load failed events when
replacing content.
(webkitWebViewSetEstimatedLoadProgress): Ignore load progress when
replacing content.
(webkit_web_view_replace_content): Set replace content status to
WillReplaceContent.
- UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(replaceContentLoadCallback):
(testWebViewReplaceContent):
- UIProcess/API/gtk/tests/WebViewTest.cpp:
(titleChanged):
(WebViewTest::waitUntilTitleChanged): Convenient method to wait
until title changes. Use with replaceConent() since load events
are not emitted when replacing content.
- UIProcess/API/gtk/tests/WebViewTest.h:
- 10:22 AM Changeset in webkit [109119] by
-
- 5 edits in trunk/Source
Unreviewed, speculative test fix after r109016.
Source/WebCore:
- platform/graphics/chromium/TransparencyWin.cpp:
(WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers): Explicitly pass a scale of 1 to ImageBuffer::create.
- platform/graphics/chromium/TransparencyWin.h:
(WebCore): Update names of re-enabled tests.
Source/WebKit/chromium:
- tests/TransparencyWinTest.cpp:
(WebCore::TEST): Update all ImageBuffer::create calls to include a scale of 1.
- 10:21 AM Changeset in webkit [109118] by
-
- 3 edits in trunk/Source/WebKit2
Add basic page overlay support to TiledCoreAnimationDrawingArea
https://bugs.webkit.org/show_bug.cgi?id=79716
<rdar://problem/10923079>
Reviewed by Sam Weinig.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
Make TiledCoreAnimationDrawingArea a GraphicsLayerClient.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::didInstallPageOverlay):
Create the page overlay layer.
(WebKit::TiledCoreAnimationDrawingArea::didUninstallPageOverlay):
Destroy the page overlay layer.
(WebKit::TiledCoreAnimationDrawingArea::setPageOverlayNeedsDisplay):
Mark the page overlay layer as needing display.
(WebKit::TiledCoreAnimationDrawingArea::notifyAnimationStarted):
(WebKit::TiledCoreAnimationDrawingArea::notifySyncRequired):
Add empty GraphisLayerClient member function implementations.
(WebKit::TiledCoreAnimationDrawingArea::paintContents):
Ask the page overlay to paint itself.
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
Flush the page overlay layer.
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
Resize the page overlay layer.
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
If we have a page overlay layer, add it as a sublayer of the root layer.
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):
Create the page overlay layer and add it as a sublayer of the root layer.
(WebKit::TiledCoreAnimationDrawingArea::destroyPageOverlayLayer):
Remove the page overlay layer and destroy it.
- 9:56 AM Changeset in webkit [109117] by
-
- 4 edits in trunk/Source/WebKit2
[GTK] Remove virtual methods of WebKitDownload signals in WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=79804
Reviewed by Martin Robinson.
That comes from the first patch that followed the approach of the
first LoaderClient implementation. With current implementation
download signals, except decide-destination, don't need to be
true_handled, and they won't have a default handler
implementation. Also the download object is not supposed to be
inheritable, since instances are created privately by the
WebContext, so it's not possible to override the virtual methods
in derived classes.
- UIProcess/API/gtk/WebKitDownload.cpp:
(webkit_download_class_init):
(webkitDownloadNotifyProgress):
(webkitDownloadFailed):
(webkitDownloadFinished):
- UIProcess/API/gtk/WebKitDownload.h:
(_WebKitDownloadClass):
- UIProcess/API/gtk/webkit2marshal.list:
- 9:44 AM Changeset in webkit [109116] by
-
- 18 edits2 copies in trunk/Source
Give StyleRule files of its own
https://bugs.webkit.org/show_bug.cgi?id=79778
Totally rubber-stamped by Andreas Kling.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSParser.cpp:
- css/CSSStyleRule.cpp:
(WebCore):
(WebCore::CSSStyleRule::style):
- css/CSSStyleRule.h:
(WebCore):
(CSSStyleRule):
- css/CSSStyleSelector.cpp:
- css/CSSStyleSheet.cpp:
- css/StyleRule.cpp: Copied from Source/WebCore/css/CSSStyleRule.cpp.
(WebCore):
- css/StyleRule.h: Copied from Source/WebCore/css/CSSStyleRule.h.
(WebCore):
- editing/EditingStyle.cpp:
- inspector/InspectorCSSAgent.cpp:
- inspector/InspectorInstrumentation.cpp:
- inspector/InspectorStyleSheet.cpp:
- page/PageSerializer.cpp:
- 9:20 AM Changeset in webkit [109115] by
-
- 4 edits in trunk/Tools
Unreviewed, rolling out r109110.
http://trac.webkit.org/changeset/109110
https://bugs.webkit.org/show_bug.cgi?id=79806
webkitpy makes it too easy to add wkb.ug URLs to ChangeLogs
(Requested by aroben on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-28
- Scripts/webkitpy/common/checkout/changelog.py:
(parse_bug_id):
(parse_bug_id_from_changelog):
- Scripts/webkitpy/common/checkout/changelog_unittest.py:
- Scripts/webkitpy/common/config/urls.py:
- 9:05 AM Changeset in webkit [109114] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: remove window aspects from the timeline presentation model.
https://bugs.webkit.org/show_bug.cgi?id=79803
Reviewed by Yury Semikhatsky.
- inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype.accept):
(WebInspector.TimelineOverviewPane.prototype._setWindowIndices):
(WebInspector.TimelineOverviewPane.prototype.windowLeft):
(WebInspector.TimelineOverviewPane.prototype.windowRight):
(WebInspector.TimelineOverviewPane.prototype._fireWindowChanged):
(WebInspector.TimelineOverviewWindow.prototype._dragWindow):
(WebInspector.TimelineOverviewPane.WindowSelector):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._onCategoryCheckboxClicked):
(WebInspector.TimelinePanel.prototype._updateBoundaries):
- inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.prototype.reset):
(WebInspector.TimelineCategory):
(WebInspector.TimelineCategory.prototype.get hidden):
(WebInspector.TimelineCategory.prototype.set hidden):
- 9:03 AM Changeset in webkit [109113] by
-
- 4 edits in trunk/Source/WebKit2
[Qt] Fix build for WK2, do not use enum type if values can be outside the enum
https://bugs.webkit.org/show_bug.cgi?id=79800
Reviewed by Csaba Osztrogonác.
We have two different enums called NavigationRequestAction. If we use one of them
to store the variables, compilers can rightfully warn about comparison with
values from other enums.
We might revisit the strategy of exposing different enumerations in experimental,
but for now, fallback to using int for the 'action' property in
QWebNavigationRequest.
- UIProcess/API/qt/qwebnavigationrequest.cpp:
(QWebNavigationRequestPrivate):
(QWebNavigationRequest::setAction):
(QWebNavigationRequest::action):
- UIProcess/API/qt/qwebnavigationrequest_p.h:
- UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp:
- 8:52 AM Changeset in webkit [109112] by
-
- 2 edits in trunk/Source/WebCore
Improve the visual of the tiling
https://bugs.webkit.org/show_bug.cgi?id=79648
Reviewed by Noam Rosenthal.
When we cover the view with tiles[1], we do so from the center
and out, in bigger and bigger cicles by finding the current minimum
covered distance.
This looks like painting a rect, then a cross, then a rect, ...
and can be noticed when a page blocks during tiling.
We can do this better by only covering with tiles in rects at a time.
The original code was done so that it gave preference to tiles in
vertical direction due to that being the most common scrolling
direction. This is not needed anymore as we are now using the
trajectory vector when panning, which always gives preference for
creating tiles in the panned direction.
[1] It should be noted that we always cover the visibleRect in one go,
and that we here are talking about covering the coverRect beyond
the visibleRect
- platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::tileDistance):
- 8:50 AM Changeset in webkit [109111] by
-
- 2 edits in trunk/Tools
Add my new email address
Fixes <http://wkb.ug/79797> Adam Roben's email address in webkitpy is soon to be incorrect
Reviewed by Anders Carlsson.
- Scripts/webkitpy/common/config/committers.py:
- 8:49 AM Changeset in webkit [109110] by
-
- 4 edits in trunk/Tools
Teach webkitpy about wkb.ug URLs
Fixes <http://wkb.ug/79799> webkit-patch can't find bug numbers from ChangeLog entries that
use wkb.ug URLs
Patch by Adam Roben <Adam Roben> on 2012-02-28
Reviewed by Anders Carlsson.
- Scripts/webkitpy/common/checkout/changelog.py:
(parse_bug_id):
(parse_bug_id_from_changelog):
Fall back to the tiny URL format if neither the short nor long URL formats work.
- Scripts/webkitpy/common/checkout/changelog_unittest.py:
(ChangeLogTest.test_parse_bug_id_from_changelog): Added tests for the above changes.
- Scripts/webkitpy/common/config/urls.py: Added bug_url_tiny, which can be used to match
wkb.ug URLs.
- 8:27 AM Changeset in webkit [109109] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: preserve memory counters size after frontend reopening
https://bugs.webkit.org/show_bug.cgi?id=79792
Clear collected counter values when timeline panel is reset. Persist
timeline grid/counters splitter position to restore it when front-end
is opened next time.
Reviewed by Pavel Feldman.
- inspector/front-end/MemoryStatistics.js:
(WebInspector.MemoryStatistics.prototype.reset):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._setSplitterPosition):
(WebInspector.TimelinePanel.prototype._resetPanel):
- inspector/front-end/timelinePanel.css:
(#counter-values-bar):
- 8:27 AM Changeset in webkit [109108] by
-
- 2 edits in trunk/Tools
[Qt] build-webkit does not detect the number of CPUs
https://bugs.webkit.org/show_bug.cgi?id=76445
Based on Seo Sanghyeon's work (modification:
Automatically determine the number of CPUs for make
only if -j make argument haven't already been specified.)
Patch by János Badics <dicska@gmail.com> on 2012-02-28
Reviewed by Csaba Osztrogonác.
- Scripts/webkitdirs.pm:
(buildQMakeProjects):
- 8:18 AM Changeset in webkit [109107] by
-
- 7 edits in trunk
Web Inspector: move filtering of the timeline records into the presentation model.
https://bugs.webkit.org/show_bug.cgi?id=79789
Reviewed by Yury Semikhatsky.
Source/WebCore:
- inspector/front-end/TimelineModel.js:
- inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype.setStartAtZero):
(WebInspector.TimelineOverviewPane.prototype.scrollWindow):
(WebInspector.TimelineOverviewPane.prototype.accept):
(WebInspector.TimelineOverviewPane.prototype._setWindowIndices):
(WebInspector.TimelineStartAtZeroOverview):
(WebInspector.TimelineStartAtZeroOverview.prototype._onWindowChanged):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._createStatusbarButtons):
(WebInspector.TimelinePanel.prototype._updateRecordsCounter):
(WebInspector.TimelinePanel.prototype._glueParentButtonClicked):
(WebInspector.TimelinePanel.prototype._toggleStartAtZeroButtonClicked):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype._resetPanel):
(WebInspector.TimelinePanel.prototype._refresh):
(WebInspector.TimelinePanel.prototype.revealRecordAt):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelineExpandableElement.prototype._update):
(WebInspector.TimelineCategoryFilter):
(WebInspector.TimelineCategoryFilter.prototype.accept):
(WebInspector.TimelineIsLongFilter):
(WebInspector.TimelineIsLongFilter.prototype.accept):
- inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel):
(WebInspector.TimelinePresentationModel.prototype.addFilter):
(WebInspector.TimelinePresentationModel.prototype.reset):
(WebInspector.TimelinePresentationModel.prototype.minimumRecordTime):
(WebInspector.TimelinePresentationModel.prototype.maximumRecordTime):
(WebInspector.TimelinePresentationModel.prototype.addRecord):
(WebInspector.TimelinePresentationModel.prototype._updateBoundaries):
(WebInspector.TimelinePresentationModel.prototype._findParentRecord):
(WebInspector.TimelinePresentationModel.prototype.setGlueRecords):
(WebInspector.TimelinePresentationModel.prototype.fireWindowChanged):
(WebInspector.TimelinePresentationModel.prototype.get _recordStyles):
(WebInspector.TimelinePresentationModel.prototype.filteredRecords):
(WebInspector.TimelinePresentationModel.prototype._filterRecords):
(WebInspector.TimelinePresentationModel.Record.prototype.get visibleChildrenCount):
(WebInspector.TimelinePresentationModel.Record.prototype.get invisibleChildrenCount):
(WebInspector.TimelinePresentationModel.Filter):
(WebInspector.TimelinePresentationModel.Filter.prototype.accept):
LayoutTests:
- inspector/timeline/timeline-enum-stability-expected.txt:
- 8:11 AM Changeset in webkit [109106] by
-
- 7 edits in trunk/Source/WebKit2
[Qt] API changes to QWebNavigationRequest
https://bugs.webkit.org/show_bug.cgi?id=78821
Reviewed by Kenneth Rohde Christiansen.
Changes discussed in API review at Szeged: rename 'button' to 'mouseButton',
rename 'modifiers' to 'keyboardModifiers', remove 'originatingUrl' and
use the enum type for 'action'.
- UIProcess/API/qt/qwebnavigationrequest.cpp:
(QWebNavigationRequestPrivate::QWebNavigationRequestPrivate):
(QWebNavigationRequestPrivate):
(QWebNavigationRequest::QWebNavigationRequest):
(QWebNavigationRequest::setAction):
(QWebNavigationRequest::mouseButton):
(QWebNavigationRequest::keyboardModifiers):
(QWebNavigationRequest::action):
- UIProcess/API/qt/qwebnavigationrequest_p.h:
- UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp:
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml:
- UIProcess/qt/QtWebPagePolicyClient.cpp:
(QtWebPagePolicyClient::decidePolicyForNavigationAction):
- UIProcess/qt/QtWebPagePolicyClient.h:
(QtWebPagePolicyClient):
- 8:02 AM Changeset in webkit [109105] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSString::resolveRope() should report extra memory cost to the heap.
https://bugs.webkit.org/show_bug.cgi?id=79555
Patch by Yong Li <yoli@rim.com> on 2012-02-28
Reviewed by Michael Saboff.
At the time a JSString is constructed with fibers, it doesn't report
extra memory cost, which is reasonable because it hasn't allocate
new memory. However when the rope is resolved, it should report meory
cost for the new buffer.
- runtime/JSString.cpp:
(JSC::JSString::resolveRope):
- 8:01 AM Changeset in webkit [109104] by
-
- 8 edits6 adds in trunk
Percent width/height SVG not always scaled on window resize
https://bugs.webkit.org/show_bug.cgi?id=79490
Patch by Florin Malita <fmalita@google.com> on 2012-02-28
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Tests: fast/repaint/percent-minheight-resize-expected.html
fast/repaint/percent-minheight-resize.html
svg/custom/svg-percent-scale-expected.html
svg/custom/svg-percent-scale-vonly-expected.html
svg/custom/svg-percent-scale-vonly.html
svg/custom/svg-percent-scale.html
Fix a couple of problems preventing correct SVG scaling on window resize:
- RenderReplaced::computePreferredLogicalWidths is not SVG attribute aware and computes
a non-zero m_minPreferredLogicalWidth even when the SVG widh/height are percentages.
- RenderBlock::layoutInlineChildren is also not SVG attribute aware and does not trigger
percent height child layouts on vertical-only resizes.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
Use hasRelativeDimensions() instead of direct width/height->isPercent tests. This also fixes
an HTML issue where percent {min,max}Height inline elements are not updated on vertical-only resizes.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::hasRelativeDimensions):
(WebCore):
- rendering/RenderBox.h:
(RenderBox):
Add virtual hasRelativeDimensions() method.
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computePreferredLogicalWidths):
Use hasRelativeDimensions() instead of direct width/height->isPercent tests.
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):
(WebCore::RenderSVGRoot::willBeDestroyed):
Register percent-height SVG elements with the gPercentHeightDescendantsMap, and clean-up on destruction
or height unit change.
(WebCore::RenderSVGRoot::hasRelativeDimensions):
(WebCore):
- rendering/svg/RenderSVGRoot.h:
(RenderSVGRoot):
SVG-aware hasRelativeDimensions() override.
LayoutTests:
- fast/repaint/percent-minheight-resize-expected.html: Added.
- fast/repaint/percent-minheight-resize.html: Added.
- svg/custom/svg-percent-scale-expected.html: Added.
- svg/custom/svg-percent-scale-vonly-expected.html: Added.
- svg/custom/svg-percent-scale-vonly.html: Added.
- svg/custom/svg-percent-scale.html: Added.
- 6:43 AM Changeset in webkit [109103] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-28
- DEPS:
- 6:22 AM Changeset in webkit [109102] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: show resource dividers on memory counter graphs
https://bugs.webkit.org/show_bug.cgi?id=79782
Resource dividers are drawn on the memory counter graphs.
Reviewed by Pavel Feldman.
- inspector/front-end/MemoryStatistics.js:
(WebInspector.MemoryStatistics.prototype.updateDividers):
(WebInspector.MemoryStatistics.prototype.setMainTimelineGrid):
(WebInspector.MemoryStatistics.prototype._updateSize):
(WebInspector.MemoryStatistics.prototype.show):
(WebInspector.MemoryStatistics.prototype.refresh):
(WebInspector.MemoryStatistics.prototype._refreshDividers):
- inspector/front-end/TimelineGrid.js:
(WebInspector.TimelineGrid.prototype.get dividersElement):
(WebInspector.TimelineGrid.prototype.updateDividers):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._timelinesOverviewModeChanged):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelinePanel.prototype.get timlinePaddingLeft):
- inspector/front-end/timelinePanel.css:
(#memory-graphs-canvas-container):
(#memory-graphs-canvas-container .resources-dividers):
- 5:30 AM Changeset in webkit [109101] by
-
- 3 edits in trunk/Source/WebKit/qt
[Qt] Move registration of experimental types to the proper plugin
https://bugs.webkit.org/show_bug.cgi?id=79706
Reviewed by Tor Arne Vestbø.
- declarative/experimental/plugin.cpp:
- declarative/plugin.cpp:
(WebKitQmlPlugin::registerTypes):
- 5:15 AM Changeset in webkit [109100] by
-
- 159 edits in trunk/LayoutTests
2012-02-28 Nikolas Zimmermann <nzimmermann@rim.com>
Rebaseline Gtk results after r109097.
- platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/struct-use-03-t-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/text-text-05-t-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
- platform/gtk/svg/batik/filters/feTile-expected.txt:
- platform/gtk/svg/batik/filters/filterRegions-expected.txt:
- platform/gtk/svg/batik/masking/maskRegions-expected.txt:
- platform/gtk/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
- platform/gtk/svg/batik/paints/patternRegionA-expected.txt:
- platform/gtk/svg/batik/paints/patternRegions-expected.txt:
- platform/gtk/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
- platform/gtk/svg/batik/text/longTextOnPath-expected.txt:
- platform/gtk/svg/batik/text/textAnchor-expected.txt:
- platform/gtk/svg/batik/text/textDecoration-expected.txt:
- platform/gtk/svg/batik/text/textEffect-expected.txt:
- platform/gtk/svg/batik/text/textEffect2-expected.txt:
- platform/gtk/svg/batik/text/textEffect3-expected.txt:
- platform/gtk/svg/batik/text/textFeatures-expected.txt:
- platform/gtk/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
- platform/gtk/svg/batik/text/textLayout-expected.txt:
- platform/gtk/svg/batik/text/textLayout2-expected.txt:
- platform/gtk/svg/batik/text/textLength-expected.txt:
- platform/gtk/svg/batik/text/textOnPath-expected.txt:
- platform/gtk/svg/batik/text/textOnPath2-expected.txt:
- platform/gtk/svg/batik/text/textOnPath3-expected.txt:
- platform/gtk/svg/batik/text/textOnPathSpaces-expected.txt:
- platform/gtk/svg/batik/text/textPosition-expected.txt:
- platform/gtk/svg/batik/text/textPosition2-expected.txt:
- platform/gtk/svg/batik/text/textProperties-expected.txt:
- platform/gtk/svg/batik/text/textProperties2-expected.txt:
- platform/gtk/svg/batik/text/textStyles-expected.txt:
- platform/gtk/svg/batik/text/verticalText-expected.txt:
- platform/gtk/svg/batik/text/verticalTextOnPath-expected.txt:
- platform/gtk/svg/carto.net/button-expected.txt:
- platform/gtk/svg/carto.net/colourpicker-expected.txt:
- platform/gtk/svg/carto.net/slider-expected.txt:
- platform/gtk/svg/carto.net/window-expected.txt:
- platform/gtk/svg/clip-path/clip-path-child-clipped-expected.txt:
- platform/gtk/svg/clip-path/clip-path-clipped-no-content-expected.txt:
- platform/gtk/svg/clip-path/clip-path-evenodd-expected.txt:
- platform/gtk/svg/clip-path/clip-path-evenodd-nonzero-expected.txt:
- platform/gtk/svg/clip-path/clip-path-nonzero-evenodd-expected.txt:
- platform/gtk/svg/clip-path/clip-path-nonzero-expected.txt:
- platform/gtk/svg/clip-path/clip-path-text-and-shape-expected.txt:
- platform/gtk/svg/clip-path/clip-path-use-as-child2-expected.txt:
- platform/gtk/svg/clip-path/clip-path-use-as-child3-expected.txt:
- platform/gtk/svg/clip-path/clip-path-use-as-child4-expected.txt:
- platform/gtk/svg/clip-path/clip-path-use-as-child5-expected.txt:
- platform/gtk/svg/clip-path/clip-path-with-container-expected.txt:
- platform/gtk/svg/clip-path/clip-path-with-invisibile-child-expected.txt:
- platform/gtk/svg/clip-path/clip-path-with-text-clipped-expected.txt:
- platform/gtk/svg/clip-path/clipper-placement-issue-expected.txt:
- platform/gtk/svg/css/clippath-with-shadow-expected.txt:
- platform/gtk/svg/css/mask-with-shadow-expected.txt:
- platform/gtk/svg/custom/broken-internal-references-expected.txt:
- platform/gtk/svg/custom/clip-path-referencing-use-expected.txt:
- platform/gtk/svg/custom/embedding-external-svgs-expected.txt:
- platform/gtk/svg/custom/path-textPath-simulation-expected.txt:
- platform/gtk/svg/custom/pattern-rotate-expected.txt:
- platform/gtk/svg/custom/recursive-clippath-expected.txt:
- platform/gtk/svg/custom/recursive-mask-expected.txt:
- platform/gtk/svg/custom/recursive-pattern-expected.txt:
- platform/gtk/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
- platform/gtk/svg/custom/relative-sized-shadow-tree-content-expected.txt:
- platform/gtk/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
- platform/gtk/svg/custom/relative-sized-use-on-symbol-expected.txt:
- platform/gtk/svg/custom/struct-use-09-b-expected.txt:
- platform/gtk/svg/custom/use-clipped-hit-expected.txt:
- platform/gtk/svg/custom/use-detach-expected.txt:
- platform/gtk/svg/custom/use-disappears-after-style-update-expected.txt:
- platform/gtk/svg/custom/use-dynamic-append-expected.txt:
- platform/gtk/svg/custom/use-elementInstance-event-target-expected.txt:
- platform/gtk/svg/custom/use-elementInstance-methods-expected.txt:
- platform/gtk/svg/custom/use-empty-reference-expected.txt:
- platform/gtk/svg/custom/use-event-handler-on-referenced-element-expected.txt:
- platform/gtk/svg/custom/use-event-handler-on-use-element-expected.txt:
- platform/gtk/svg/custom/use-events-crash-expected.txt:
- platform/gtk/svg/custom/use-instanceRoot-modifications-expected.txt:
- platform/gtk/svg/custom/use-modify-container-in-target-expected.txt:
- platform/gtk/svg/custom/use-modify-target-container-expected.txt:
- platform/gtk/svg/custom/use-modify-target-symbol-expected.txt:
- platform/gtk/svg/custom/use-nested-transform-expected.txt:
- platform/gtk/svg/custom/use-on-disallowed-foreign-object-1-expected.txt:
- platform/gtk/svg/custom/use-on-disallowed-foreign-object-2-expected.txt:
- platform/gtk/svg/custom/use-on-disallowed-foreign-object-3-expected.txt:
- platform/gtk/svg/custom/use-on-disallowed-foreign-object-4-expected.txt:
- platform/gtk/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
- platform/gtk/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
- platform/gtk/svg/custom/use-on-g-containing-symbol-expected.txt:
- platform/gtk/svg/custom/use-on-g-containing-use-expected.txt:
- platform/gtk/svg/custom/use-on-g-expected.txt:
- platform/gtk/svg/custom/use-on-non-svg-namespaced-element-expected.txt:
- platform/gtk/svg/custom/use-on-rect-expected.txt:
- platform/gtk/svg/custom/use-on-symbol-expected.txt:
- platform/gtk/svg/custom/use-on-text-expected.txt:
- platform/gtk/svg/custom/use-on-use-expected.txt:
- platform/gtk/svg/custom/use-property-changes-through-dom-expected.txt:
- platform/gtk/svg/custom/use-property-changes-through-svg-dom-expected.txt:
- platform/gtk/svg/custom/use-property-synchronization-crash-expected.txt:
- platform/gtk/svg/custom/use-recalcStyle-crash-expected.txt:
- platform/gtk/svg/custom/use-recursion-1-expected.txt:
- platform/gtk/svg/custom/use-recursion-2-expected.txt:
- platform/gtk/svg/custom/use-recursion-3-expected.txt:
- platform/gtk/svg/custom/use-recursion-4-expected.txt:
- platform/gtk/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
- platform/gtk/svg/custom/use-symbol-overflow-expected.txt:
- platform/gtk/svg/custom/use-transform-expected.txt:
- platform/gtk/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.txt:
- platform/gtk/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.txt:
- platform/gtk/svg/filters/filter-placement-issue-expected.txt:
- platform/gtk/svg/filters/filter-refresh-expected.txt:
- platform/gtk/svg/filters/filter-source-position-expected.txt:
- platform/gtk/svg/hixie/error/014-expected.txt:
- platform/gtk/svg/hixie/error/017-expected.txt:
- platform/gtk/svg/hixie/use/001-expected.txt:
- platform/gtk/svg/hixie/use/002-expected.txt:
- platform/gtk/svg/overflow/overflow-on-inner-svg-element-expected.txt:
- platform/gtk/svg/repaint/inner-svg-change-viewPort-relative-expected.txt:
- platform/gtk/svg/stroke/zero-length-path-linecap-rendering-expected.txt:
- platform/gtk/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt:
- platform/gtk/svg/text/text-gradient-positioning-expected.txt:
- platform/gtk/svg/text/text-path-01-b-expected.txt:
- platform/gtk/svg/text/text-text-04-t-expected.txt:
- platform/gtk/svg/text/text-text-05-t-expected.txt:
- platform/gtk/svg/text/text-text-06-t-expected.txt:
- platform/gtk/svg/transforms/svg-css-transforms-clip-path-expected.txt:
- platform/gtk/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
- svg/stroke/zero-length-arc-linecaps-rendering-expected.txt:
- 5:01 AM Changeset in webkit [109099] by
-
- 257 edits3 copies4 adds in trunk/LayoutTests
Integrate SVGUseElement within the new shadow root concept
https://bugs.webkit.org/show_bug.cgi?id=78902
Unreviewed gardening, update Qt specific expected files after r109097.
- platform/qt/svg/[...]: Updated.
- 4:53 AM SettingUpDevelopmentEnvironmentForN9 edited by
- (diff)
- 4:51 AM Changeset in webkit [109098] by
-
- 1 edit1 add in trunk/LayoutTests
2012-02-28 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Add missing Mac pixel test result.
- platform/mac/svg/carto.net/scrollbar-expected.png: Added.
- 4:13 AM Changeset in webkit [109097] by
-
- 233 edits4 deletes in trunk
Integrate SVGUseElement within the new shadow root concept
https://bugs.webkit.org/show_bug.cgi?id=78902
Reviewed by Zoltan Herczeg.
Source/WebCore:
Replace SVG shadow tree implementation with the new, modern #shadow-root implementation.
Current situation in trunk:
SVGUseElement doesn't create/hold the shadow tree, unlike its expected in
the modern #shadow-root concept, but its renderer RenderSVGShadowTreeRootContainer.
That creates a cycle, as the actual DOM tree is stored as RefPtr<SVGGElement> inside
a renderer - that's weak conceptually, and has lead to sublte security bugs in the past.
Whenever a target element of a <use> element changed, invalidateShadowTree() is called
which calls setNeedsStyleRecalc(), and sets m_needsShadodwTreeRecreation to true.
Once style recalculation happens, the RenderSVGShadowTreeRootContainer then eventually
built the shadow tree, by cloning the target node, building the SVGElementInstance tree
etc, -- all within the render tree.
To easy reviewing, here's a dump of the current render tree for a simple <use> example:
<defs><rect id="rect"/></defs><use xlink:href="#rect"/>
Dump of render tree:
RenderSVGHiddenContainer {defs} <defs> (SVGDefsElement)
RenderSVGRect {rect} <rect> (SVGRectElement)
RenderSVGShadowTreeRootContainer {use} <use> (SVGUseElement)
RenderSVGContainer {g} <g> (SVGShadowTreeRootElement)
RenderSVGRect {rect} <rect> (SVGRectElement, clone of <rect> in <defs>)
The SVGShadowTreeRootElement is created & stored by RenderSVGShadowTreeRootContainer,
the renderer of the <use> element. The RenderSVGTransformableContainer renderer created
for the SVGShadowTreeRootElement stores the x/y translation induced by the <use> attributes.
There are lots of places all over WebCore that assume the existance of a <g> renderer
as first child of the <use> element, representing the "SVG shadow tree root".
Summary of this patch:
Let SVGUseElement create&maintain a #shadow-root, and append the cloned target elements
into this shadow root. We no longer have to take care of attachment/detachment, style
recalculation, etc. - that's handled transparenly by ShadowRoot(List) now.
This makes SVGShadowTreeElements & RenderSVGShadowTreeRootContainer obsolete. Switch
SVGUseElement to create a RenderSVGTransformableContainer as its renderer, and make
it respect the translation induced by the x/y attributes, given for a <use> element.
Remove all occourences of SVGShadowRoot, remove all special cases it induced.
It's all covered by existing tests, took a while to make them all pass again.
- CMakeLists.txt: Remove SVGShadowTreeElements/RenderSVGShadowTreeRootContainer from build.
- GNUmakefile.list.am: Ditto.
- Target.pri: Ditto.
- WebCore.gypi: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList): Enable fast path for selector checking, now that special shadow tree rules are gone.
- css/SelectorChecker.cpp:
(WebCore::linkAttribute): No need to guard this code with ENABLE(SVG).
(WebCore::SelectorChecker::checkSelector): Remove obsolete SVG shadow root special case.
- dom/EventDispatcher.cpp:
(WebCore::eventTargetRespectingSVGTargetRules): Remove loop, simplify & cleanup this code.
(WebCore::EventDispatcher::adjustToShadowBoundaries): s/isShadowRootOrSVGShadowRoot/isShadowRoot/.
(WebCore::EventDispatcher::adjustRelatedTarget): Ditto.
(WebCore::EventDispatcher::ensureEventAncestors): Simplify logic for SVG, fixed a FIXME.
- dom/Node.cpp: Remove obsolete svgShadowHost().
(WebCore::Node::shadowTreeRootNode): Remove obsolete isSVGShadowRoot() checks.
(WebCore::Node::nonBoundaryShadowTreeRootNode): Ditto.
(WebCore::Node::isInShadowTree): Make it const.
- dom/Node.h: Remove isSVGShadowRoot/svgShadowHost.
(WebCore::Node::isShadowRoot): s/IsShadowRootOrSVGShadowRootFlag/isShadowRoot/.
(WebCore::Node::parentNode): Augment comments.
(WebCore::Node::parentNodeGuaranteedHostFree): Ditto.
- dom/Range.cpp:
(WebCore::Range::checkNodeBA): Remove obsolete SVG shadow root special case.
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::prepareScript): Ditto.
- rendering/RenderObject.h: Remove isSVGShadowTreeRootContainer.
(WebCore::RenderObject::isSVGTransformableContainer): Added.
- rendering/svg/RenderSVGAllInOne.cpp: Remove SVGShadowTreeElements/RenderSVGShadowTreeRootContainer from build.
- rendering/svg/RenderSVGModelObject.cpp:
(WebCore::isGraphicsElement): To check for <use>, a tag name comparision is needed now, as it no longer has a special renderer.
- rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage): Ditto.
(WebCore::RenderSVGResourceClipper::calculateClipContentRepaintRect): Ditto.
(WebCore::RenderSVGResourceClipper::hitTestClipContent): Ditto.
- rendering/svg/RenderSVGResourceContainer.cpp: Remove RenderSVGShadowTreeRootContainer.h include.
- rendering/svg/RenderSVGShadowTreeRootContainer.cpp: Removed.
- rendering/svg/RenderSVGShadowTreeRootContainer.h: Removed.
- rendering/svg/RenderSVGTransformableContainer.cpp: Keep track of last used additional x/y translation.
(WebCore::RenderSVGTransformableContainer::calculateLocalTransform): Handle x/y translation for <use> contains here, instead of storing it in the SVGShadowTreeRootElement.
- rendering/svg/RenderSVGTransformableContainer.h: Store last used x/y translation.
(WebCore::RenderSVGTransformableContainer::isSVGTransformableContainer): Return true.
(WebCore::toRenderSVGTransformableContainer): Add conversion helpers.
- rendering/svg/RenderSVGViewportContainer.cpp: Ditto.
(WebCore::RenderSVGViewportContainer::calcViewport): Handle width/height attributes inheritance from the <use> element, if we're a <svg> or <symbol> replacement in the shadow tree.
- rendering/svg/RenderSVGViewportContainer.h: Remove isSVGContainer() override which is not needed here (already present in RenderSVGContainer).
- rendering/svg/SVGShadowTreeElements.cpp: Removed.
- rendering/svg/SVGShadowTreeElements.h: Removed.
- svg/SVGAElement.cpp:
(WebCore::SVGAElement::createRenderer): Check if parentNode is really a SVGElement, before casting.
- svg/SVGElement.cpp:
(WebCore::SVGElement::isOutermostSVGSVGElement): Early exit if tag name isn't <svg>, or if we're in a shadow tree (can't be an outermost <svg> element then).
(WebCore::hasLoadListener): Deploy parentOrHostElement() usage to remove any special cases, related to shadow boundaries.
(WebCore::SVGElement::sendSVGLoadEventIfPossible): Ditto.
(WebCore::SVGElement::customStyleForRenderer): Ditto.
- svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::invalidateAllInstancesOfElement): Call updateStyleIfNeeded() instead of updateLayoutIgnorePendingStylesheets().
- svg/SVGGElement.cpp:
(WebCore::SVGGElement::rendererIsNeeded): s/parentNode/parentOrHostElement/ - we need to cross shadow boundaries now.
- svg/SVGGElement.h: Remove obsolete isShadowTreeContainerElement().
- svg/SVGLocatable.cpp:
(WebCore::SVGLocatable::nearestViewportElement): s/parentNode/parentOrHostElement/ - we need to cross shadow boundaries now.
(WebCore::SVGLocatable::farthestViewportElement): Ditto.
(WebCore::SVGLocatable::computeCTM): Ditto.
- svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::title): Ditto. (+ simplify code a lot, no need to walk the shadow tree to find its root anymore, use isInShadowTree() helper.)
(WebCore::SVGStyledElement::rendererIsNeeded): Ditto.
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::SVGUseElement): Remove no longer needed m_updatesBlocked.
(WebCore::SVGUseElement::create): Always call ensureShadowRoot(), to create a #shadow-root, upon creating a SVGUseElement.
(WebCore::SVGUseElement::insertedIntoDocument): Align with SVGFEImageElement/SVGTRefElement - call buildPendingResource() from insertedIntoDocument(), finally! (no renderer needed anymore to update the SVG shadow subtree).
(WebCore::SVGUseElement::removedFromDocument): Align with SVGFEImageElement/SVGTRefElement - immediately release the SVGElementInstance & shadow tree, once we're removed from the document.
(WebCore::SVGUseElement::svgAttributeChanged): Simplify code a lot, no longer need to deal with x/y/width/height attributes, the renderes in the shadow tree grab these values from their corresponding <use> elements automatically now.
(WebCore::SVGUseElement::willRecalcStyle):
New main part of the logic. invalidateShadowTree() calls setNeedsStyleRecalc, and sets m_needsShadowTreeRecreation=true. If we encounter this case, force rebuilding the SVG shadow tree
and the SVGElementInstance tree, immediately, before executing the actual style recalc. This allows us to lazily rebuild the SVG shadow tree for the <use> element. Consider:
<defs><rect id="rect"></defs> <use xlink:href="#rect"/>. Now from a script we change the rect x/y/width/height attributes:
rect.setAttribute("x", "10"); rect.setAttribute("y", "10")... each call will lead to a SVGUseElement::invalidateShadowTree() call by SVGElementInstance::invalidateAllInstancesOfElement, invoked after the <rect> element got parsed.
This won't update the shadow tree four times, but only once upon the next style recalculation - otherwise performance is a nightmare.
This will serve as future starting point, to explore partial SVG subtree re-clones, which should easily be doable now.
(WebCore::dumpInstanceTree): Add a 'static' to allow DUMP_INSTANCE_TREE to be used in clang builds.
(WebCore::SVGUseElement::clearResourceReferences): Added helper to release instance & shadow tree.
(WebCore::SVGUseElement::buildPendingResource): Modeled exactly like SVGFEImageElement/SVGTRefElement. It's possible to share more code between these in future.
(WebCore::SVGUseElement::buildShadowAndInstanceTree): Cleanup code, adapt to new shadow-root concept.
(WebCore::SVGUseElement::createRenderer): Create a RenderSVGTransformableContainer, no longer a <use> specific renderer.
(WebCore::removeDisallowedElementsFromSubtree): Use new replacedChild/appendChild variants, that don't require a ExceptionCode to be passed in.
(WebCore::SVGUseElement::buildShadowTree): Ditto.
(WebCore::SVGUseElement::expandUseElementsInShadowTree): Ditto.
(WebCore::SVGUseElement::expandSymbolElementsInShadowTree): Ditto.
(WebCore::SVGUseElement::invalidateShadowTree): Only trigger style recalculations if needed.
- svg/SVGUseElement.h: Remove lots of now unnecessary overrides: attach/detach/didRecalcStyle/updateContainerOffset/updateContainerSizes/etc..
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::insertedIntoDocument): No need to walk the shadow tree to find its root anymore, use isInShadowTree() helper.
LayoutTests:
Update results after the <use> rewrite. Lots of RendeSVGContainer lines are
gone in the expected results, as the artifical <g> element representing the
SVG shadow root is gone, replaced by a standar #shadow-root.
- platform/chromium/test_expectations.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/struct-use-03-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-text-05-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
- platform/mac/svg/batik/filters/feTile-expected.txt:
- platform/mac/svg/batik/filters/filterRegions-expected.txt:
- platform/mac/svg/batik/masking/maskRegions-expected.txt:
- platform/mac/svg/batik/paints/gradientLimit-expected.txt:
- platform/mac/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
- platform/mac/svg/batik/paints/patternRegionA-expected.txt:
- platform/mac/svg/batik/paints/patternRegions-expected.txt:
- platform/mac/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
- platform/mac/svg/batik/text/longTextOnPath-expected.txt:
- platform/mac/svg/batik/text/smallFonts-expected.txt:
- platform/mac/svg/batik/text/textAnchor-expected.txt:
- platform/mac/svg/batik/text/textDecoration-expected.txt:
- platform/mac/svg/batik/text/textEffect-expected.txt:
- platform/mac/svg/batik/text/textEffect2-expected.txt:
- platform/mac/svg/batik/text/textEffect3-expected.txt:
- platform/mac/svg/batik/text/textFeatures-expected.txt:
- platform/mac/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
- platform/mac/svg/batik/text/textLayout-expected.txt:
- platform/mac/svg/batik/text/textLayout2-expected.txt:
- platform/mac/svg/batik/text/textLength-expected.txt:
- platform/mac/svg/batik/text/textOnPath-expected.txt:
- platform/mac/svg/batik/text/textOnPath2-expected.txt:
- platform/mac/svg/batik/text/textOnPath3-expected.txt:
- platform/mac/svg/batik/text/textOnPathSpaces-expected.txt:
- platform/mac/svg/batik/text/textPosition-expected.txt:
- platform/mac/svg/batik/text/textPosition2-expected.txt:
- platform/mac/svg/batik/text/textProperties-expected.txt:
- platform/mac/svg/batik/text/textProperties2-expected.txt:
- platform/mac/svg/batik/text/textStyles-expected.txt:
- platform/mac/svg/batik/text/verticalText-expected.txt:
- platform/mac/svg/batik/text/verticalTextOnPath-expected.txt:
- platform/mac/svg/carto.net/button-expected.txt:
- platform/mac/svg/carto.net/colourpicker-expected.txt:
- platform/mac/svg/carto.net/slider-expected.txt:
- platform/mac/svg/carto.net/window-expected.txt:
- platform/mac/svg/clip-path/clip-path-child-clipped-expected.txt:
- platform/mac/svg/clip-path/clip-path-clipped-no-content-expected.txt:
- platform/mac/svg/clip-path/clip-path-evenodd-expected.txt:
- platform/mac/svg/clip-path/clip-path-evenodd-nonzero-expected.txt:
- platform/mac/svg/clip-path/clip-path-nonzero-evenodd-expected.txt:
- platform/mac/svg/clip-path/clip-path-nonzero-expected.txt:
- platform/mac/svg/clip-path/clip-path-text-and-shape-expected.txt:
- platform/mac/svg/clip-path/clip-path-use-as-child2-expected.txt:
- platform/mac/svg/clip-path/clip-path-use-as-child3-expected.txt:
- platform/mac/svg/clip-path/clip-path-use-as-child4-expected.txt:
- platform/mac/svg/clip-path/clip-path-use-as-child5-expected.txt:
- platform/mac/svg/clip-path/clip-path-with-container-expected.txt:
- platform/mac/svg/clip-path/clip-path-with-invisibile-child-expected.txt:
- platform/mac/svg/clip-path/clip-path-with-text-clipped-expected.txt:
- platform/mac/svg/clip-path/clipper-placement-issue-expected.txt:
- platform/mac/svg/css/clippath-with-shadow-expected.txt:
- platform/mac/svg/css/mask-with-shadow-expected.txt:
- platform/mac/svg/custom/broken-internal-references-expected.txt:
- platform/mac/svg/custom/clip-path-referencing-use-expected.txt:
- platform/mac/svg/custom/clip-path-referencing-use2-expected.txt:
- platform/mac/svg/custom/embedding-external-svgs-expected.txt:
- platform/mac/svg/custom/path-textPath-simulation-expected.txt:
- platform/mac/svg/custom/pattern-rotate-expected.txt:
- platform/mac/svg/custom/recursive-clippath-expected.txt:
- platform/mac/svg/custom/recursive-mask-expected.txt:
- platform/mac/svg/custom/recursive-pattern-expected.txt:
- platform/mac/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
- platform/mac/svg/custom/relative-sized-shadow-tree-content-expected.txt:
- platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
- platform/mac/svg/custom/relative-sized-use-on-symbol-expected.txt:
- platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
- platform/mac/svg/custom/struct-use-09-b-expected.txt:
- platform/mac/svg/custom/use-clipped-hit-expected.txt:
- platform/mac/svg/custom/use-css-events-expected.txt:
- platform/mac/svg/custom/use-detach-expected.txt:
- platform/mac/svg/custom/use-disappears-after-style-update-expected.png:
- platform/mac/svg/custom/use-disappears-after-style-update-expected.txt:
- platform/mac/svg/custom/use-dynamic-append-expected.txt:
- platform/mac/svg/custom/use-elementInstance-event-target-expected.txt:
- platform/mac/svg/custom/use-elementInstance-methods-expected.txt:
- platform/mac/svg/custom/use-empty-reference-expected.txt:
- platform/mac/svg/custom/use-event-handler-on-referenced-element-expected.txt:
- platform/mac/svg/custom/use-event-handler-on-use-element-expected.txt:
- platform/mac/svg/custom/use-events-crash-expected.txt:
- platform/mac/svg/custom/use-font-face-crash-expected.txt:
- platform/mac/svg/custom/use-instanceRoot-event-bubbling-expected.png:
- platform/mac/svg/custom/use-instanceRoot-event-listeners-expected.png:
- platform/mac/svg/custom/use-instanceRoot-modifications-expected.txt:
- platform/mac/svg/custom/use-modify-container-in-target-expected.txt:
- platform/mac/svg/custom/use-modify-target-container-expected.txt:
- platform/mac/svg/custom/use-modify-target-symbol-expected.txt:
- platform/mac/svg/custom/use-nested-transform-expected.txt:
- platform/mac/svg/custom/use-on-disallowed-foreign-object-1-expected.txt:
- platform/mac/svg/custom/use-on-disallowed-foreign-object-2-expected.txt:
- platform/mac/svg/custom/use-on-disallowed-foreign-object-3-expected.txt:
- platform/mac/svg/custom/use-on-disallowed-foreign-object-4-expected.txt:
- platform/mac/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
- platform/mac/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
- platform/mac/svg/custom/use-on-g-containing-symbol-expected.txt:
- platform/mac/svg/custom/use-on-g-containing-use-expected.txt:
- platform/mac/svg/custom/use-on-g-expected.txt:
- platform/mac/svg/custom/use-on-non-svg-namespaced-element-expected.txt:
- platform/mac/svg/custom/use-on-rect-expected.txt:
- platform/mac/svg/custom/use-on-symbol-expected.txt:
- platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt:
- platform/mac/svg/custom/use-on-text-expected.txt:
- platform/mac/svg/custom/use-on-use-expected.txt:
- platform/mac/svg/custom/use-property-changes-through-dom-expected.txt:
- platform/mac/svg/custom/use-property-changes-through-svg-dom-expected.txt:
- platform/mac/svg/custom/use-property-synchronization-crash-expected.txt:
- platform/mac/svg/custom/use-recalcStyle-crash-expected.txt:
- platform/mac/svg/custom/use-recursion-1-expected.txt:
- platform/mac/svg/custom/use-recursion-2-expected.txt:
- platform/mac/svg/custom/use-recursion-3-expected.txt:
- platform/mac/svg/custom/use-recursion-4-expected.png:
- platform/mac/svg/custom/use-recursion-4-expected.txt:
- platform/mac/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
- platform/mac/svg/custom/use-symbol-overflow-expected.txt:
- platform/mac/svg/custom/use-transform-expected.txt:
- platform/mac/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.txt:
- platform/mac/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.txt:
- platform/mac/svg/filters/filter-placement-issue-expected.txt:
- platform/mac/svg/filters/filter-refresh-expected.txt:
- platform/mac/svg/filters/filter-source-position-expected.txt:
- platform/mac/svg/hixie/error/014-expected.txt:
- platform/mac/svg/hixie/error/017-expected.txt:
- platform/mac/svg/hixie/use/001-expected.txt:
- platform/mac/svg/hixie/use/002-expected.txt:
- platform/mac/svg/overflow/overflow-on-inner-svg-element-expected.txt:
- platform/mac/svg/stroke/zero-length-arc-linecaps-rendering-expected.txt:
- platform/mac/svg/stroke/zero-length-path-linecap-rendering-expected.txt:
- platform/mac/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt:
- platform/mac/svg/text/text-gradient-positioning-expected.txt:
- platform/mac/svg/text/text-path-01-b-expected.txt:
- platform/mac/svg/text/text-text-04-t-expected.txt:
- platform/mac/svg/text/text-text-05-t-expected.txt:
- platform/mac/svg/text/text-text-06-t-expected.txt:
- platform/mac/svg/transforms/svg-css-transforms-clip-path-expected.txt:
- platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
- svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt:
- svg/clip-path/clip-path-childs-clipped-expected.txt:
- svg/clip-path/clip-path-clipped-evenodd-twice-expected.txt:
- svg/clip-path/clip-path-clipped-expected.txt:
- svg/clip-path/clip-path-clipped-nonzero-expected.txt:
- svg/clip-path/clip-path-on-clipped-use-expected.txt:
- svg/clip-path/clip-path-use-as-child-expected.txt:
- svg/css/circle-in-mask-with-shadow-expected.txt:
- svg/custom/deep-dynamic-updates-expected.txt:
- svg/custom/non-scaling-stroke-expected.txt:
- svg/custom/resource-client-removal-expected.txt:
- svg/custom/use-clipped-transform-expected.txt:
- svg/custom/use-css-no-effect-on-shadow-tree-expected.txt:
- svg/custom/use-forward-refs-expected.txt:
- svg/custom/use-image-in-g-expected.txt:
- svg/custom/use-in-symbol-with-offset-expected.txt:
- svg/custom/use-inherit-style-expected.txt:
- svg/custom/use-move-to-offset-expected.txt:
- svg/custom/use-multiple-on-nested-disallowed-font-expected.txt:
- svg/custom/use-on-clip-path-with-transformation-expected.txt:
- svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt:
- svg/custom/use-setAttribute-crash-expected.txt:
- svg/custom/use-transfer-width-height-properties-to-svg-expected.txt:
- svg/custom/use-transfer-width-height-properties-to-svg1-expected.txt:
- svg/custom/use-transfer-width-height-properties-to-svg2-expected.txt:
- svg/custom/use-transfer-width-height-properties-to-symbol-expected.txt:
- svg/custom/use-transfer-width-height-properties-to-symbol1-expected.txt:
- svg/custom/use-transfer-width-height-properties-to-symbol2-expected.txt:
- svg/repaint/inner-svg-change-viewPort-relative-expected.txt:
- 3:36 AM Changeset in webkit [109096] by
-
- 22 edits4 adds in trunk
Element should be able to have multiple shadow roots.
https://bugs.webkit.org/show_bug.cgi?id=77931
Reviewed by Hajime Morita.
.:
- Source/autotools/symbols.filter:
Source/WebCore:
This patch enables us to add multiple shadow subtrees into elements.
Note that multiple shadow subtrees are enabled
only if RuntimeEnabledFeatures::multipleShadowSubtrees is enabled.
Since we don't have <shadow> element yet, only the youngest shadow tree
will be rendered. This patch includes tests to confirm adding a new shadow
tree dynamically to confirm only the youngest shadow tree is renderered.
Tests: fast/dom/shadow/multiple-shadowroot-rendering.html
fast/dom/shadow/multiple-shadowroot.html
- WebCore.exp.in:
- dom/Element.cpp: Uses ShadowRootList interfaces directly instead of ShadowRootList emulation methods.
(WebCore::Element::~Element):
(WebCore::Element::attach):
(WebCore::Element::addShadowRoot):
(WebCore::Element::removeShadowRootList):
- dom/Element.h:
(Element):
- dom/NodeRenderingContext.cpp: Makes non-youngest shadow subtrees hidden.
(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::NodeRenderingContext::hostChildrenChanged):
Since non-youngest children may be changed, make sure host children are changed.
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::create):
- dom/ShadowRoot.h: Utility methods to make code intention clear are added.
(WebCore::ShadowRoot::youngerShadowRoot):
(WebCore::ShadowRoot::olderShadowRoot):
(ShadowRoot):
(WebCore::ShadowRoot::isYoungest):
(WebCore::ShadowRoot::isOldest):
- dom/ShadowRootList.cpp:
(WebCore::ShadowRootList::popShadowRoot):
(WebCore::ShadowRootList::attach):
(WebCore::ShadowRootList::detach):
Detaches shadow subtrees.
- testing/Internals.cpp:
(WebCore::Internals::address):
(WebCore):
(WebCore::Internals::youngerShadowRoot):
(WebCore::Internals::olderShadowRoot):
(WebCore::Internals::removeShadowRoot):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Source/WebKit2:
- win/WebKit2.def:
- win/WebKit2CFLite.def:
LayoutTests:
- fast/dom/resources/shadow-test-driver.js:
(createSpanWithText):
(doneTest):
(doTest):
- fast/dom/shadow/multiple-shadowroot-expected.txt: Added.
- fast/dom/shadow/multiple-shadowroot-rendering-expected.txt: Added.
- fast/dom/shadow/multiple-shadowroot-rendering.html: Added.
- fast/dom/shadow/multiple-shadowroot.html: Added.
- platform/efl/Skipped:
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- platform/wk2/Skipped:
- 2:55 AM Changeset in webkit [109095] by
-
- 2 edits in trunk/Tools
Update a pattern for forms files of watchlist
https://bugs.webkit.org/show_bug.cgi?id=79767
Reviewed by Kentaro Hara.
- Scripts/webkitpy/common/config/watchlist:
Catches the following files with the "Forms" pattern.
- HTMLDatListElement.*
- HTMLKeygenElement.*
- HTMLLegendElement.*
- HTMLOutputElement.*
- FormAssociatedElement.*
- SliderThumbElement.*
- TextControlInnerElements.*
- RenderFileUploadControl.*
- 2:42 AM Changeset in webkit [109094] by
-
- 5 edits in trunk/Source/WebKit2
[Qt][WK2] Use movementStarted/Ended signals instead of movingChanged on QtViewportInterationEngine
https://bugs.webkit.org/show_bug.cgi?id=79521
Patch by Hugo Parente Lima <Hugo Parente Lima> on 2012-02-28
Reviewed by Kenneth Rohde Christiansen.
movingChanged() signal is emitted many times, so the use of movementStarted() and
movementEnded() is a better choice.
- UIProcess/qt/QtFlickProvider.cpp:
(QtFlickProvider::QtFlickProvider):
- UIProcess/qt/QtFlickProvider.h:
(QtFlickProvider):
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
- UIProcess/qt/QtViewportInteractionEngine.h:
(QtViewportInteractionEngine):
- 2:21 AM Changeset in webkit [109093] by
-
- 4 edits in trunk/LayoutTests
[Chromium] We should reset mouse position before calling eventSender.mouseMove in LayoutTest
https://bugs.webkit.org/show_bug.cgi?id=79748
Calls eventSender.moveTo(0, 0) before other eventSender.moveTo call to make sure test scripts
get mousemove event.
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-02-28
Reviewed by Kent Tamura.
- fast/forms/number/input-number-events.html:
- fast/forms/number/input-number-large-padding.html:
- fast/forms/number/input-spinbutton-capturing.html:
- 2:06 AM Changeset in webkit [109092] by
-
- 2 edits in trunk/Source/WebKit/qt
Try to fix build.
Not reviewed.
- Api/qwebelement.cpp:
(QWebElement::styleProperty):
- 1:38 AM Changeset in webkit [109091] by
-
- 17 edits in trunk/Source/WebCore
Split CSSStyleRule into internal and CSSOM type
https://bugs.webkit.org/show_bug.cgi?id=79763
Reviewed by Andreas Kling.
- Split the data out as StyleRule
- Make CSSStyleSelector operate on StyleRule instead of CSSStyleRule
This is an intermediate step. Both CSSStyleRule and StyleRule are still always constructed so
the patch increases memory consumption by a few pointers per css rule. Upcoming
patches will make CSSStyleRules to be constructed on demand.
The patch does not yet move StyleRule to a file of its own.
- css/CSSPageRule.cpp:
(WebCore::CSSPageRule::CSSPageRule):
- css/CSSPageRule.h:
(WebCore::CSSPageRule::create):
(CSSPageRule):
- css/CSSParser.cpp:
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createPageRule):
- css/CSSRule.h:
(WebCore::CSSRule::CSSRule):
(CSSRule):
- css/CSSStyleRule.cpp:
(WebCore::StyleRule::StyleRule):
(WebCore):
(WebCore::StyleRule::~StyleRule):
(WebCore::StyleRule::addSubresourceStyleURLs):
(WebCore::StyleRule::ensureCSSStyleRule):
(WebCore::CSSStyleRule::CSSStyleRule):
(WebCore::CSSStyleRule::~CSSStyleRule):
(WebCore::CSSStyleRule::generateSelectorText):
(WebCore::CSSStyleRule::setSelectorText):
(WebCore::CSSStyleRule::cssText):
- css/CSSStyleRule.h:
(WebCore):
(StyleRule):
(WebCore::StyleRule::selectorList):
(WebCore::StyleRule::properties):
(WebCore::StyleRule::sourceLine):
(WebCore::StyleRule::adoptSelectorVector):
(WebCore::StyleRule::adoptSelectorList):
(WebCore::StyleRule::setProperties):
(WebCore::CSSStyleRule::create):
(WebCore::CSSStyleRule::style):
(CSSStyleRule):
(WebCore::CSSStyleRule::styleRule):
- css/CSSStyleSelector.cpp:
(RuleData):
(WebCore::RuleData::rule):
(RuleSet):
(WebCore::CSSStyleSelector::addMatchedProperties):
(WebCore::CSSStyleSelector::sortAndTransferMatchedRules):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::RuleSelectorPair::RuleSelectorPair):
(RuleSelectorPair):
(MatchResult):
(CSSStyleSelector):
- css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::addSubresourceStyleURLs):
- editing/EditingStyle.cpp:
(WebCore::styleFromMatchedRulesForElement):
- inspector/InspectorCSSAgent.cpp:
(WebCore::SelectorProfile::startSelector):
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willMatchRuleImpl):
(WebCore::InspectorInstrumentation::willProcessRuleImpl):
- inspector/InspectorInstrumentation.h:
(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willMatchRule):
(WebCore::InspectorInstrumentation::willProcessRule):
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::buildObjectForRule):
(WebCore::InspectorStyleSheet::revalidateStyle):
- page/PageSerializer.cpp:
(WebCore::PageSerializer::serializeFrame):
(WebCore::PageSerializer::serializeCSSStyleSheet):
(WebCore::PageSerializer::retrieveResourcesForRule):
(WebCore::PageSerializer::retrieveResourcesForProperties):
- page/PageSerializer.h:
(WebCore):
(PageSerializer):
- 1:36 AM Changeset in webkit [109090] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test expectations update.
webaudio/audiobuffersource-channels.html crashes on debug builds.
- platform/chromium/test_expectations.txt:
- 1:23 AM Changeset in webkit [109089] by
-
- 3 edits in trunk/Source/WebCore
RuntimeEnabledFeatures::setMultipleShadowSubtreesEnabled should not be inline
https://bugs.webkit.org/show_bug.cgi?id=79753
Moved the function implementation to the .cpp file.
Reviewed by Hajime Morita.
No new tests. (no functional change)
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::setMultipleShadowSubtreesEnabled):
(WebCore):
- bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
- 12:53 AM Changeset in webkit [109088] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, marking a media test flaky on GTK.
- platform/gtk/test_expectations.txt:
media/video-poster-blocked-by-willsendrequest.html is flaky.
- 12:22 AM Modules edited by
- (diff)
- 12:14 AM WebKitGTK/1.8.x edited by
- (diff)
- 12:13 AM Changeset in webkit [109087] by
-
- 1 edit22 adds in trunk/LayoutTests
Unreviewed, GTK baselines for 22 new tests.
- platform/gtk/fast/block/float/centered-float-avoidance-complexity-expected.txt: Added.
- platform/gtk/fast/block/float/shrink-to-avoid-float-complexity-expected.txt: Added.
- platform/gtk/fast/css/non-empty-span-expected.txt: Added.
- platform/gtk/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.txt: Added.
- platform/gtk/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.txt: Added.
- platform/gtk/fast/css/relative-positioned-block-nested-with-inline-parent-expected.txt: Added.
- platform/gtk/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.txt: Added.
- platform/gtk/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.txt: Added.
- platform/gtk/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.txt: Added.
- platform/gtk/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.txt: Added.
- platform/gtk/fast/css/relative-positioned-block-with-inline-ancestor-expected.txt: Added.
- platform/gtk/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.txt: Added.
- platform/gtk/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.txt: Added.
- platform/gtk/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.txt: Added.
- platform/gtk/fast/repaint/region-painting-invalidation-expected.txt: Added.
- platform/gtk/svg/foreignObject/fO-display-none-expected.txt: Added.
- platform/gtk/svg/foreignObject/fO-display-none-with-relative-pos-content-expected.txt: Added.
- platform/gtk/svg/foreignObject/fO-parent-display-changes-expected.txt: Added.
- platform/gtk/svg/foreignObject/fO-parent-display-none-expected.txt: Added.
- platform/gtk/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt: Added.
- platform/gtk/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt: Added.
- platform/gtk/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt: Added.
- 12:07 AM Changeset in webkit [109086] by
-
- 2 edits in trunk/Source/WebCore
Fix comment about RGB swizzle decoding and Adobe transform=0 images
https://bugs.webkit.org/show_bug.cgi?id=79457
Unreviewed. No new tests, comment change only.
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::JPEGImageReader::decode):
- 12:06 AM Changeset in webkit [109085] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK test_expectations update, skipping 2 new failing
ref tests.
- platform/gtk/test_expectations.txt:
- 12:05 AM Changeset in webkit [109084] by
-
- 14 edits in trunk
Element::removeShadowRoot() and setShadowRoot() should be moved into ShadowTree.
https://bugs.webkit.org/show_bug.cgi?id=78313
Reviewed by Hajime Morita.
.:
- Source/autotools/symbols.filter:
Source/WebCore:
This patch is for refactoring ShadowTree related code.
(1) Element::removeShadowRoot() and Element::setShadowRoot() are moved into ShadowTree.
(2) ShadowTree is now put on its own heap.
No new tests, no change in behavior.
- WebCore.exp.in:
- dom/Element.cpp:
(WebCore::Element::~Element):
(WebCore::Element::shadowTree):
(WebCore::Element::ensureShadowTree):
Ensure the existence of ShadowTree. This does not ensure ShadowRoot exists.
- dom/Element.h:
(Element):
- dom/ElementRareData.h: Makes ShadowTree on Heap.
(ElementRareData):
(WebCore::ElementRareData::~ElementRareData):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::create):
- dom/ShadowTree.cpp:
(WebCore::validateShadowRoot):
(WebCore):
(WebCore::ShadowTree::addShadowRoot):
(WebCore::ShadowTree::removeAllShadowRoots):
- dom/ShadowTree.h:
(ShadowTree):
- testing/Internals.cpp:
(WebCore::Internals::removeShadowRoot):
Source/WebKit2:
- win/WebKit2.def:
- win/WebKit2CFLite.def:
- 12:01 AM Modules edited by
- (diff)
- 12:01 AM Modules edited by
- (diff)
- 12:01 AM Modules edited by
- (diff)
Feb 27, 2012:
- 11:52 PM Modules edited by
- (diff)
- 11:46 PM Modules edited by
- (diff)
- 11:43 PM Modules edited by
- (diff)
- 11:43 PM Changeset in webkit [109083] by
-
- 10 edits7 adds in trunk/LayoutTests
Unreviewed, GTK rebaseline.
- platform/gtk/Skipped: Skip all dom/shadow tests, GTK doesn't
support this feature yet.
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/gtk/fast/js/constructor-length-expected.txt:
- platform/gtk/fast/multicol/span/clone-flexbox-expected.txt: Added.
- platform/gtk/fast/multicol/span/clone-summary-expected.txt: Added.
- platform/gtk/fast/runin/runin-div-before-child-expected.txt: Added.
- platform/gtk/fast/runin/runin-table-before-child-expected.txt: Added.
- platform/gtk/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
- platform/gtk/media/audio-repaint-expected.txt:
- platform/gtk/media/video-zoom-controls-expected.txt:
- platform/gtk/svg/css/getComputedStyle-basic-expected.txt: Added.
- platform/gtk/svg/repaint/inner-svg-change-viewPort-relative-expected.txt: Added.
- platform/gtk/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
- platform/gtk/svg/text/text-rescale-expected.txt: Added.
- platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
- 11:37 PM Modules edited by
- (diff)
- 11:32 PM Modules edited by
- (diff)
- 11:31 PM Modules edited by
- (diff)
- 11:28 PM Modules edited by
- (diff)
- 11:26 PM Modules edited by
- (diff)
- 11:19 PM Modules edited by
- (diff)
- 11:02 PM Changeset in webkit [109082] by
-
- 2 edits in trunk/LayoutTests
LayoutTests/fast/forms/number/input-number-events.html is failing since r108228
https://bugs.webkit.org/show_bug.cgi?id=79329
Remove trailing whitespace which makes test failure.
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-02-27
Reviewed by Kent Tamura.
- fast/forms/number/input-number-events-expected.txt: Remove trailing whitespace at line 11.
- 10:57 PM Changeset in webkit [109081] by
-
- 18 edits in trunk
Fix <msubsup> formatting, especially for a tall base, subscript, or superscript
https://bugs.webkit.org/show_bug.cgi?id=79274
Patch by David Barton <Dave Barton> on 2012-02-27
Reviewed by Julien Chaffraix.
Source/WebCore:
Move the <msubsup> formatting code in stretchToHeight() to layout(). Then revise the
combined code to produce more vertically accurate results, and without extra white
space. Finally, don't multiply msub/msup/msubsup operator stretching by 1.2.
Test: Added the bug report's attached test case to mathml/presentation/subsup.xhtml, and
it and 5 other test files in mathml/presentation now produce improved results. The
integral sign in mo-stretch.html is no longer scaled up by an extra 1.2, and baselines
are more accurate so the base is higher in msubsup-sub-changed.png. Several examples are
slightly tighter vertically, because their (somewhat) anonymous blocks wrapping
subscripts and superscripts now have the correct font size.
- rendering/mathml/RenderMathMLSubSup.cpp:
(WebCore):
(WebCore::RenderMathMLSubSup::addChild):
(WebCore::RenderMathMLSubSup::stretchToHeight):
(WebCore::RenderMathMLSubSup::layout):
- rendering/mathml/RenderMathMLSubSup.h:
(RenderMathMLSubSup):
- rendering/style/RenderStyle.h:
LayoutTests:
- mathml/presentation/subsup.xhtml:
- platform/mac/mathml/presentation/mo-stretch-expected.png: Added property svn:mime-type.
- platform/mac/mathml/presentation/mo-stretch-expected.txt:
- platform/mac/mathml/presentation/msubsup-base-changed-expected.png:
- platform/mac/mathml/presentation/msubsup-base-changed-expected.txt:
- platform/mac/mathml/presentation/msubsup-sub-changed-expected.png:
- platform/mac/mathml/presentation/msubsup-sub-changed-expected.txt:
- platform/mac/mathml/presentation/msubsup-sup-changed-expected.png:
- platform/mac/mathml/presentation/msubsup-sup-changed-expected.txt:
- platform/mac/mathml/presentation/sub-expected.png:
- platform/mac/mathml/presentation/sub-expected.txt:
- platform/mac/mathml/presentation/subsup-expected.png:
- platform/mac/mathml/presentation/subsup-expected.txt:
- 10:49 PM Changeset in webkit [109080] by
-
- 2 edits in trunk/Source/WebCore
kCTFontTableOptionExcludeSynthetic is unneeded
https://bugs.webkit.org/show_bug.cgi?id=79744
Patch by Ned Holbrook <nholbrook@apple.com> on 2012-02-27
Reviewed by Dan Bernstein.
The aforementioned option is a no-op, so no new tests.
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::fontHasVerticalGlyphs): Specify no options.
- 10:47 PM Changeset in webkit [109079] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed morning gardening.
- platform/qt/Skipped: Skip new failing tests.
- platform/qt/fast/dom/Window/window-properties-expected.txt: Updated.
- 10:34 PM Changeset in webkit [109078] by
-
- 2 edits in trunk/Source/WebKit/chromium
Add missing parameter to didCreateScriptContext() so it overrides base class again.
https://bugs.webkit.org/show_bug.cgi?id=79742
Reviewed by Kent Tamura.
- tests/WebFrameTest.cpp:
- 10:12 PM Changeset in webkit [109077] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Unreviewed gardening, Disable TransparencyWin.OpaqueCompositeLayerPixel
- tests/TransparencyWinTest.cpp:
(WebCore::TEST):
- 10:03 PM Changeset in webkit [109076] by
-
- 6 edits2 adds in trunk
Multi-Channel support in AudioBufferSourceNode
https://bugs.webkit.org/show_bug.cgi?id=79202
Patch by Wei James <james.wei@intel.com> on 2012-02-27
Reviewed by Chris Rogers.
Source/WebCore:
Test: webaudio/audiobuffersource-multi-channels.html
- webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::renderSilenceAndFinishIfNotLooping):
(WebCore::AudioBufferSourceNode::renderFromBuffer):
(WebCore::AudioBufferSourceNode::setBuffer):
- webaudio/AudioBufferSourceNode.h:
(AudioBufferSourceNode):
LayoutTests:
- webaudio/audiobuffersource-channels-expected.txt:
- webaudio/audiobuffersource-channels.html:
- webaudio/audiobuffersource-multi-channels-expected.wav: Added.
- webaudio/audiobuffersource-multi-channels.html: Added.
- 9:59 PM Changeset in webkit [109075] by
-
- 5 edits in tags/Safari-535.23.1/Source/JavaScriptCore
Merge r108888.
- 9:49 PM Changeset in webkit [109074] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Upstream the BlackBerry change to platform/graphics/IntRect.h
https://bugs.webkit.org/show_bug.cgi?id=79732
Reviewed by Antonio Gomes.
Add conversion convenience between WebCore::IntRect and BlackBerry::Platform::IntRect.
The porting can't be built yet, no new tests.
- platform/graphics/IntRect.h:
(Platform):
(IntRect):
- 9:42 PM Changeset in webkit [109073] by
-
- 3 edits2 adds in trunk
Printed font-size should not be dependant on zoom level
https://bugs.webkit.org/show_bug.cgi?id=79717
Reviewed by Adam Barth.
Ignore full page zoom level when printing a document.
Source/WebCore:
Test: printing/zoomed-document.html
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
LayoutTests:
- printing/zoomed-document-expected.txt: Added.
- printing/zoomed-document.html: Added.
- 9:29 PM Changeset in webkit [109072] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] Unreviewed gardening, further compile fixes for
TransparencyWinTest.
- platform/graphics/chromium/TransparencyWin.h:
(WebCore):
- 9:16 PM Changeset in webkit [109071] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] Unreviewed gardening, fix compile error after r109043
- platform/graphics/chromium/TransparencyWin.h:
(TransparencyWin):
- 8:59 PM Changeset in webkit [109070] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Add createSnapshotFile API to WebFileSystem to create File snapshots for filesystem files
https://bugs.webkit.org/show_bug.cgi?id=79394
Reviewed by Darin Fisher.
- public/platform/WebFileSystem.h:
(WebKit::WebFileSystem::createSnapshotFileAndReadMetadata): Added.
- 8:50 PM Changeset in webkit [109069] by
-
- 6 edits7 deletes in trunk
Unreviewed, rolling out r109041.
http://trac.webkit.org/changeset/109041
https://bugs.webkit.org/show_bug.cgi?id=79741
Broke Chromium Win build (Requested by bashi on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-27
Tools:
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
- DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
- DumpRenderTree/chromium/WebViewHost.h:
LayoutTests:
- webintents/resources/web-intents-testing.js: Removed.
- webintents/web-intents-failure-expected.txt: Removed.
- webintents/web-intents-failure.html: Removed.
- webintents/web-intents-invoke-expected.txt: Removed.
- webintents/web-intents-invoke.html: Removed.
- webintents/web-intents-reload.html:
- webintents/web-intents-reply-expected.txt: Removed.
- webintents/web-intents-reply.html: Removed.
- 8:41 PM Changeset in webkit [109068] by
-
- 8 edits1 move in trunk/Source/WebCore
EventFactory.in should be named EventNames.in
https://bugs.webkit.org/show_bug.cgi?id=79727
Reviewed by Kentaro Hara.
Originally EventFactory.in was just used to generate EventFactory.cpp,
but now we're able to generate a bunch of other Event-related code from
this "in" file.
In writing some documentation about how to use these mechanisms, the
name EventFactory.in didn't seem like the right name. This patch
renames EventFactory.in to EventNames.in, which more accurately
describes the role of this file (and matches the naming convention of
HTMLTagNames.in).
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.am:
- WebCore.gyp/WebCore.gyp:
- WebCore.gyp/scripts/action_makenames.py:
(main):
- WebCore.xcodeproj/project.pbxproj:
- dom/EventNames.in: Copied from Source/WebCore/dom/EventFactory.in.
- dom/EventFactory.in: Removed.
- 8:17 PM Changeset in webkit [109067] by
-
- 2 edits in trunk/Source/WebCore
[Forms] Make order of attribute/method in HTMLInputElement.idl as same as specification
https://bugs.webkit.org/show_bug.cgi?id=79622
For ease of maintainability, this patch reorders attributes and methods declaration
matching with specification.
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-02-27
Reviewed by Adam Barth.
No new tests. No behavior change.
- html/HTMLInputElement.idl: Reorder and remove obsolete comments.
- 7:52 PM Changeset in webkit [109066] by
-
- 3 edits in trunk/Tools
[chromium] Remove media tests from ChromiumGpu configurations
https://bugs.webkit.org/show_bug.cgi?id=79720
Patch by James Robinson <jamesr@chromium.org> on 2012-02-27
Reviewed by Adam Barth.
We no longer need to run the media/ tests in both GPU and non-GPU configurations since we can exercise the GPU
composited playback path via tests in the compositing/ directory.
- Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
(_default_tests_paths):
- Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
(ChromiumGpuTest.test_default_tests_paths):
(ChromiumGpuTest.test_test_files):
- 7:44 PM Changeset in webkit [109065] by
-
- 2 edits in trunk/Source/WebCore
Sort CSSStyleSelector property handler constructors by CSS property name.
https://bugs.webkit.org/show_bug.cgi?id=79713
Reviewed by Andreas Kling.
No new tests / refactoring only.
This patch is simply an automated sort of the property constructors.
Presently they are all over the place and it is difficult to know where to insert new rules.
This patch provides a clear pattern and should reduce future conflicts when adding properties.
- css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- 7:31 PM Changeset in webkit [109064] by
-
- 9 edits in trunk/Source
[chromium] Plumb extensionGroup into didCreateScriptContext().
https://bugs.webkit.org/show_bug.cgi?id=79072
Reviewed by Darin Fisher.
Source/WebCore:
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initContextIfNeeded):
- bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::V8IsolatedContext):
- loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::didCreateScriptContext):
- loader/FrameLoaderClient.h:
(FrameLoaderClient):
Source/WebKit/chromium:
- public/WebFrameClient.h:
(WebKit::WebFrameClient::didCreateScriptContext):
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::didCreateScriptContext):
- src/FrameLoaderClientImpl.h:
(FrameLoaderClientImpl):
- 7:29 PM Changeset in webkit [109063] by
-
- 2 edits in trunk
Update flakiness dashboard unit test.
https://bugs.webkit.org/show_bug.cgi?id=79711
Patch by Dave Tu <dtu@chromium.org> on 2012-02-27
Reviewed by Ojan Vafai.
- Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
- 7:17 PM Modules edited by
- (diff)
- 7:09 PM Modules edited by
- (diff)
- 7:09 PM Changeset in webkit [109062] by
-
- 6 edits in trunk
Fixed a typo in CanvasRenderingContext2D::drawImage(HTMLCanvasElement);
incorrect source and destination rect used.
https://bugs.webkit.org/show_bug.cgi?id=79566
Source/WebCore:
Pass dstRect and bufferSrcRect to
CanvasRenderingContext2D::fullCanvasCompositedDrawImage() for the destination
and source rect, respectively.
Patch by Huang Dongsung <luxtella@company100.net> on 2012-02-27
Reviewed by Daniel Bates.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
LayoutTests:
I amended canvas-composite-canvas to cover this bug, and I also amended
canvas-composite-image because I changed
LayoutTests/fast/canvas/resources/canvas-composite-image-common.js.
However, the change of canvas-composite-image is reasonable because
drawImage(HTMLImageElement) will be able to have a similar bug.
Patch by Huang Dongsung <luxtella@company100.net> on 2012-02-27
Reviewed by Daniel Bates.
- fast/canvas/canvas-composite-canvas.html:
- fast/canvas/canvas-composite-image.html:
- fast/canvas/resources/canvas-composite-image-common.js:
(setupContext):
- 7:09 PM Modules edited by
- (diff)
- 7:08 PM Modules edited by
- (diff)
- 7:05 PM Modules edited by
- (diff)
- 7:03 PM Modules edited by
- (diff)
- 7:01 PM Changeset in webkit [109061] by
-
- 1 edit2 adds in trunk/Source/WebCore
[EFL] Initial implementation of GraphicsContext3DPrivate
https://bugs.webkit.org/show_bug.cgi?id=62961
Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2012-02-27
Reviewed by Noam Rosenthal.
This patch adds the GraphicsContext3DPrivate class using Evas_GL.
GraphicsContext3DPrivate delegates all GL function calls to Evas_GL_API.
- platform/graphics/efl/GraphicsContext3DPrivate.cpp: Added.
(WebCore):
(WebCore::GraphicsContext3DPrivate::create):
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::initialize):
(WebCore::GraphicsContext3DPrivate::createSurface):
(WebCore::GraphicsContext3DPrivate::platformGraphicsContext3D):
(WebCore::GraphicsContext3DPrivate::makeContextCurrent):
(WebCore::GraphicsContext3DPrivate::isGLES2Compliant):
(WebCore::GraphicsContext3DPrivate::activeTexture):
(WebCore::GraphicsContext3DPrivate::attachShader):
(WebCore::GraphicsContext3DPrivate::bindAttribLocation):
(WebCore::GraphicsContext3DPrivate::bindBuffer):
(WebCore::GraphicsContext3DPrivate::bindFramebuffer):
(WebCore::GraphicsContext3DPrivate::bindRenderbuffer):
(WebCore::GraphicsContext3DPrivate::bindTexture):
(WebCore::GraphicsContext3DPrivate::blendColor):
(WebCore::GraphicsContext3DPrivate::blendEquation):
(WebCore::GraphicsContext3DPrivate::blendEquationSeparate):
(WebCore::GraphicsContext3DPrivate::blendFunc):
(WebCore::GraphicsContext3DPrivate::blendFuncSeparate):
(WebCore::GraphicsContext3DPrivate::bufferData):
(WebCore::GraphicsContext3DPrivate::bufferSubData):
(WebCore::GraphicsContext3DPrivate::checkFramebufferStatus):
(WebCore::GraphicsContext3DPrivate::clear):
(WebCore::GraphicsContext3DPrivate::clearColor):
(WebCore::GraphicsContext3DPrivate::clearDepth):
(WebCore::GraphicsContext3DPrivate::clearStencil):
(WebCore::GraphicsContext3DPrivate::colorMask):
(WebCore::GraphicsContext3DPrivate::compileShader):
(WebCore::GraphicsContext3DPrivate::copyTexImage2D):
(WebCore::GraphicsContext3DPrivate::copyTexSubImage2D):
(WebCore::GraphicsContext3DPrivate::cullFace):
(WebCore::GraphicsContext3DPrivate::depthFunc):
(WebCore::GraphicsContext3DPrivate::depthMask):
(WebCore::GraphicsContext3DPrivate::depthRange):
(WebCore::GraphicsContext3DPrivate::detachShader):
(WebCore::GraphicsContext3DPrivate::disable):
(WebCore::GraphicsContext3DPrivate::disableVertexAttribArray):
(WebCore::GraphicsContext3DPrivate::drawArrays):
(WebCore::GraphicsContext3DPrivate::drawElements):
(WebCore::GraphicsContext3DPrivate::enable):
(WebCore::GraphicsContext3DPrivate::enableVertexAttribArray):
(WebCore::GraphicsContext3DPrivate::finish):
(WebCore::GraphicsContext3DPrivate::flush):
(WebCore::GraphicsContext3DPrivate::framebufferRenderbuffer):
(WebCore::GraphicsContext3DPrivate::framebufferTexture2D):
(WebCore::GraphicsContext3DPrivate::frontFace):
(WebCore::GraphicsContext3DPrivate::generateMipmap):
(WebCore::GraphicsContext3DPrivate::getActiveAttrib):
(WebCore::GraphicsContext3DPrivate::getActiveUniform):
(WebCore::GraphicsContext3DPrivate::getAttachedShaders):
(WebCore::GraphicsContext3DPrivate::getAttribLocation):
(WebCore::GraphicsContext3DPrivate::getBooleanv):
(WebCore::GraphicsContext3DPrivate::getBufferParameteriv):
(WebCore::GraphicsContext3DPrivate::getContextAttributes):
(WebCore::GraphicsContext3DPrivate::getError):
(WebCore::GraphicsContext3DPrivate::getFloatv):
(WebCore::GraphicsContext3DPrivate::getFramebufferAttachmentParameteriv):
(WebCore::GraphicsContext3DPrivate::getIntegerv):
(WebCore::GraphicsContext3DPrivate::getProgramiv):
(WebCore::GraphicsContext3DPrivate::getProgramInfoLog):
(WebCore::GraphicsContext3DPrivate::getRenderbufferParameteriv):
(WebCore::GraphicsContext3DPrivate::getShaderiv):
(WebCore::GraphicsContext3DPrivate::getShaderInfoLog):
(WebCore::GraphicsContext3DPrivate::getShaderSource):
(WebCore::GraphicsContext3DPrivate::getString):
(WebCore::GraphicsContext3DPrivate::getTexParameterfv):
(WebCore::GraphicsContext3DPrivate::getTexParameteriv):
(WebCore::GraphicsContext3DPrivate::getUniformfv):
(WebCore::GraphicsContext3DPrivate::getUniformiv):
(WebCore::GraphicsContext3DPrivate::getUniformLocation):
(WebCore::GraphicsContext3DPrivate::getVertexAttribfv):
(WebCore::GraphicsContext3DPrivate::getVertexAttribiv):
(WebCore::GraphicsContext3DPrivate::getVertexAttribOffset):
(WebCore::GraphicsContext3DPrivate::hint):
(WebCore::GraphicsContext3DPrivate::isBuffer):
(WebCore::GraphicsContext3DPrivate::isEnabled):
(WebCore::GraphicsContext3DPrivate::isFramebuffer):
(WebCore::GraphicsContext3DPrivate::isProgram):
(WebCore::GraphicsContext3DPrivate::isRenderbuffer):
(WebCore::GraphicsContext3DPrivate::isShader):
(WebCore::GraphicsContext3DPrivate::isTexture):
(WebCore::GraphicsContext3DPrivate::lineWidth):
(WebCore::GraphicsContext3DPrivate::linkProgram):
(WebCore::GraphicsContext3DPrivate::pixelStorei):
(WebCore::GraphicsContext3DPrivate::polygonOffset):
(WebCore::GraphicsContext3DPrivate::readPixels):
(WebCore::GraphicsContext3DPrivate::renderbufferStorage):
(WebCore::GraphicsContext3DPrivate::sampleCoverage):
(WebCore::GraphicsContext3DPrivate::scissor):
(WebCore::GraphicsContext3DPrivate::shaderSource):
(WebCore::GraphicsContext3DPrivate::stencilFunc):
(WebCore::GraphicsContext3DPrivate::stencilFuncSeparate):
(WebCore::GraphicsContext3DPrivate::stencilMask):
(WebCore::GraphicsContext3DPrivate::stencilMaskSeparate):
(WebCore::GraphicsContext3DPrivate::stencilOp):
(WebCore::GraphicsContext3DPrivate::stencilOpSeparate):
(WebCore::GraphicsContext3DPrivate::texImage2D):
(WebCore::GraphicsContext3DPrivate::texParameterf):
(WebCore::GraphicsContext3DPrivate::texParameteri):
(WebCore::GraphicsContext3DPrivate::texSubImage2D):
(WebCore::GraphicsContext3DPrivate::uniform1f):
(WebCore::GraphicsContext3DPrivate::uniform1fv):
(WebCore::GraphicsContext3DPrivate::uniform1i):
(WebCore::GraphicsContext3DPrivate::uniform1iv):
(WebCore::GraphicsContext3DPrivate::uniform2f):
(WebCore::GraphicsContext3DPrivate::uniform2fv):
(WebCore::GraphicsContext3DPrivate::uniform2i):
(WebCore::GraphicsContext3DPrivate::uniform2iv):
(WebCore::GraphicsContext3DPrivate::uniform3f):
(WebCore::GraphicsContext3DPrivate::uniform3fv):
(WebCore::GraphicsContext3DPrivate::uniform3i):
(WebCore::GraphicsContext3DPrivate::uniform3iv):
(WebCore::GraphicsContext3DPrivate::uniform4f):
(WebCore::GraphicsContext3DPrivate::uniform4fv):
(WebCore::GraphicsContext3DPrivate::uniform4i):
(WebCore::GraphicsContext3DPrivate::uniform4iv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix2fv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix3fv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix4fv):
(WebCore::GraphicsContext3DPrivate::useProgram):
(WebCore::GraphicsContext3DPrivate::validateProgram):
(WebCore::GraphicsContext3DPrivate::vertexAttrib1f):
(WebCore::GraphicsContext3DPrivate::vertexAttrib1fv):
(WebCore::GraphicsContext3DPrivate::vertexAttrib2f):
(WebCore::GraphicsContext3DPrivate::vertexAttrib2fv):
(WebCore::GraphicsContext3DPrivate::vertexAttrib3f):
(WebCore::GraphicsContext3DPrivate::vertexAttrib3fv):
(WebCore::GraphicsContext3DPrivate::vertexAttrib4f):
(WebCore::GraphicsContext3DPrivate::vertexAttrib4fv):
(WebCore::GraphicsContext3DPrivate::vertexAttribPointer):
(WebCore::GraphicsContext3DPrivate::viewport):
(WebCore::GraphicsContext3DPrivate::createBuffer):
(WebCore::GraphicsContext3DPrivate::createFramebuffer):
(WebCore::GraphicsContext3DPrivate::createProgram):
(WebCore::GraphicsContext3DPrivate::createRenderbuffer):
(WebCore::GraphicsContext3DPrivate::createShader):
(WebCore::GraphicsContext3DPrivate::createTexture):
(WebCore::GraphicsContext3DPrivate::deleteBuffer):
(WebCore::GraphicsContext3DPrivate::deleteFramebuffer):
(WebCore::GraphicsContext3DPrivate::deleteProgram):
(WebCore::GraphicsContext3DPrivate::deleteRenderbuffer):
(WebCore::GraphicsContext3DPrivate::deleteShader):
(WebCore::GraphicsContext3DPrivate::deleteTexture):
(WebCore::GraphicsContext3DPrivate::synthesizeGLError):
(WebCore::GraphicsContext3DPrivate::getExtensions):
- platform/graphics/efl/GraphicsContext3DPrivate.h: Added.
(WebCore):
(GraphicsContext3DPrivate):
- 6:58 PM Modules edited by
- (diff)
- 6:36 PM Changeset in webkit [109060] by
-
- 5 edits3 adds in trunk
RenderLayer ClipRect not accounting for transforms
https://bugs.webkit.org/show_bug.cgi?id=76486
Reviewed by Simon Fraser.
Source/WebCore:
Test: compositing/layer-creation/overlap-transformed-and-clipped.html
This patch changes calculateClipRects() so that the clipRect
offset is allowed to be converted across layers with
transforms. This is necessary because the RenderLayerCompositor
needs clipRects in document space, rather than with respect to
some local clipping layer.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::localToContainerPoint):
(WebCore):
- rendering/RenderObject.h:
(RenderObject):
LayoutTests:
- compositing/layer-creation/overlap-transformed-and-clipped-expected.png: Added.
- compositing/layer-creation/overlap-transformed-and-clipped-expected.txt: Added.
- compositing/layer-creation/overlap-transformed-and-clipped.html: Added.
- 6:36 PM Modules edited by
- (diff)
- 6:35 PM Changeset in webkit [109059] by
-
- 2 edits in trunk/Source/JavaScriptCore
sputnik/Unicode/Unicode_500/S7.2_A1.6_T1.html crashes in the interpreter
https://bugs.webkit.org/show_bug.cgi?id=79728
Reviewed by Gavin Barraclough.
When initialising a chained get instruction we may end up in a state where
the instruction stream says we have a scopechain, but it has not yet been set
(eg. if allocating the StructureChain itself is what leads to the GC). We could
re-order the allocation, but it occurs in a couple of places, so it seems less
fragile simply to null check the scopechain slot before we actually visit the slot.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitStructures):
- 6:34 PM Changeset in webkit [109058] by
-
- 3 edits2 adds in trunk
[MutationObservers] Clear pending mutation records on disconnect()
https://bugs.webkit.org/show_bug.cgi?id=78639
Reviewed by Ojan Vafai.
Source/WebCore:
Test: fast/mutation/disconnect-cancel-pending.html
- dom/WebKitMutationObserver.cpp:
(WebCore::WebKitMutationObserver::disconnect): Clear pending records.
(WebCore::WebKitMutationObserver::deliver): Avoid calling the callback if no records are pending delivery.
LayoutTests:
- fast/mutation/disconnect-cancel-pending-expected.txt: Added.
- fast/mutation/disconnect-cancel-pending.html: Added.
- 6:25 PM Modules edited by
- (diff)
- 6:19 PM Modules edited by
- (diff)
- 6:14 PM Changeset in webkit [109057] by
-
- 8 edits1 add1 delete in trunk
Extract the logic to merge tests from MergeTestsHandler and add unit tests
https://bugs.webkit.org/show_bug.cgi?id=79602
Reviewed by Hajime Morita.
Extracted Test.merge and TestResult.replace_to_change_test_name out of MergeTestsHandler,
and moved MergeTestsHandler into admin_handlers.py where it belongs.
Added new backend "model-manipulator" to execute tasks to merge tests.
Also revive the inadvertently removed manual submission form on the admin page.
- Websites/webkit-perf.appspot.com/admin_handlers.py:
(AdminDashboardHandler.get_tests):
(MergeTestsHandler):
(MergeTestsHandler.post):
- Websites/webkit-perf.appspot.com/app.yaml:
- Websites/webkit-perf.appspot.com/backends.yaml: Added.
- Websites/webkit-perf.appspot.com/css/admin.css:
- Websites/webkit-perf.appspot.com/js/admin.js:
- Websites/webkit-perf.appspot.com/main.py:
- Websites/webkit-perf.appspot.com/merge_tests_handler.py: Removed.
- Websites/webkit-perf.appspot.com/models.py:
(Test):
(Test.merge):
(TestResult.replace_to_change_test_name):
- Websites/webkit-perf.appspot.com/models_unittest.py:
(DataStoreTestsBase.assertOnlyInstance):
(DataStoreTestsBase):
(DataStoreTestsBase.assertOnlyInstances):
(DataStoreTestsBase.assertEqualUnorderedModelList):
(DataStoreTestsBase.assertEqualUnorderedList):
(_create_build):
(TestModelTests.test_merge):
(TestResultTests):
(TestResultTests.test_get_or_insert_value):
(TestResultTests.test_get_or_insert_stat_value):
(TestResultTests.test_replace_to_change_test_name):
(TestResultTests.test_replace_to_change_test_name_with_stat_value):
(TestResultTests.test_replace_to_change_test_name_overrides_conflicting_result):
- 6:05 PM Changeset in webkit [109056] by
-
- 2 edits in trunk/Tools
nrwt: log multiline stderr/crash output properly
https://bugs.webkit.org/show_bug.cgi?id=79722
Reviewed by Adam Barth.
This cleans up some nits in the log output to make things
slightly easier to read (every line gets timestamped, etc.).
Also tweaks the log message for pixel hash mismatches.
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._handle_error):
(SingleTestRunner._compare_image):
- 5:59 PM Changeset in webkit [109055] by
-
- 4 edits in trunk
<rdar://problem/10924993> and https://bugs.webkit.org/show_bug.cgi?id=79725
<a ping> doesn't work in WebKit2
Reviewed by Alexey Proskuryakov.
Source/WebKit2:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Push the WK2 <a ping> setting to WebCore::Settings.
LayoutTests:
- platform/wk2/Skipped: Unskip some tests that now pass.
- 5:56 PM Modules edited by
- (diff)
- 5:51 PM Changeset in webkit [109054] by
-
- 3 edits2 adds in trunk
Always notify subtree of removal in ContainerNode::removeChildren
https://bugs.webkit.org/show_bug.cgi?id=79316
Reviewed by Ryosuke Niwa.
Source/WebCore:
In the inDocument case, Node::removedFromDocument is called.
In the out-of-document case, call ContainerNode::removedFromTree to ensure,
e.g., form-associated elements are properly disconnected.
Test: fast/forms/form-associated-element-removal.html
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChildren):
LayoutTests:
- fast/forms/form-associated-element-removal-expected.txt: Added.
- fast/forms/form-associated-element-removal.html: Added.
- 5:47 PM Changeset in webkit [109053] by
-
- 2 edits in trunk/Tools
Touch the master.cfg to force a reconfig.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(BuildAndTestLeaksFactory):
(NewBuildAndTestFactory):
- 5:44 PM Modules edited by
- (diff)
- 5:36 PM Changeset in webkit [109052] by
-
- 9 edits in trunk/Source/WebCore
Repair license blocks for files created during modularization
https://bugs.webkit.org/show_bug.cgi?id=79721
Reviewed by Eric Seidel.
We failed to copy the license blocks correctly when moving code into
these files. This patch restores the correct license blocks.
- Modules/geolocation/NavigatorGeolocation.cpp:
- Modules/geolocation/NavigatorGeolocation.h:
- Modules/mediastream/NavigatorMediaStream.cpp:
- Modules/mediastream/NavigatorMediaStream.h:
- bindings/js/JSDOMWindowWebAudioCustom.cpp:
- bindings/js/JSDOMWindowWebSocketCustom.cpp:
- storage/DOMWindowSQLDatabase.cpp:
- storage/DOMWindowSQLDatabase.h:
- 5:34 PM Changeset in webkit [109051] by
-
- 8 edits in trunk
[BlackBerry] Upstream BlackBerry API web page related files
https://bugs.webkit.org/show_bug.cgi?id=74380
Patch by Jacky Jiang <zhajiang@rim.com> on 2012-02-27
Reviewed by Antonio Gomes.
Source/WebKit/blackberry:
Clean up WebPage.{h, cpp} and WebPage_p.h.
- Remove WebPage::mainFrame() as it is bad to expose WebCore::Frame in the public API, adapt to the change by adding a new method WebPagePrivate::core(Const WebPage*) and expose it to DumpRenderTreeSupport.
- Rename WebPage::spellCheckingEnabled to WebPage::setSpellCheckingEnabled.
- Remove unused WebPage::focusNodeRect().
- Remove extra blank lines.
- Put WebPage methods and their associated WebPagePrivate methods together.
No new tests as this patch doesn't change behavior.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::WebPage):
(WebKit):
(BlackBerry::WebKit::WebPage::~WebPage):
(BlackBerry::WebKit::WebPagePrivate::core):
(BlackBerry::WebKit::WebPage::load):
(BlackBerry::WebKit::WebPage::loadExtended):
(BlackBerry::WebKit::WebPage::loadFile):
(BlackBerry::WebKit::WebPage::download):
(BlackBerry::WebKit::WebPage::loadString):
(BlackBerry::WebKit::WebPage::executeJavaScript):
(BlackBerry::WebKit::WebPage::executeJavaScriptInIsolatedWorld):
(BlackBerry::WebKit::WebPage::stopLoading):
(BlackBerry::WebKit::WebPage::prepareToDestroy):
(BlackBerry::WebKit::WebPage::setScrollPosition):
(BlackBerry::WebKit::WebPage::scrollBy):
(BlackBerry::WebKit::WebPage::notifyInRegionScrollStatusChanged):
(BlackBerry::WebKit::WebPage::zoomToFitScale):
(BlackBerry::WebKit::WebPage::initialScale):
(BlackBerry::WebKit::WebPage::maximumScale):
(BlackBerry::WebKit::WebPage::scrollPosition):
(BlackBerry::WebKit::WebPage::viewportSize):
(BlackBerry::WebKit::WebPage::activeNodeContext):
(BlackBerry::WebKit::WebPage::assignFocus):
(BlackBerry::WebKit::WebPage::blockZoomAnimationFinished):
(BlackBerry::WebKit::WebPage::onInputLocaleChanged):
(BlackBerry::WebKit::WebPage::setScreenOrientation):
(BlackBerry::WebKit::WebPage::applyPendingOrientationIfNeeded):
(BlackBerry::WebKit::WebPage::setViewportSize):
(BlackBerry::WebKit::WebPage::setDefaultLayoutSize):
(BlackBerry::WebKit::WebPage::setScrollOriginPoint):
(BlackBerry::WebKit::WebPage::textEncoding):
(BlackBerry::WebKit::WebPage::forcedTextEncoding):
(BlackBerry::WebKit::WebPage::setForcedTextEncoding):
(BlackBerry::WebKit::WebPage::setSpellCheckingEnabled):
(BlackBerry::WebKit::parentLayer):
(BlackBerry::WebKit::WebPagePrivate::inRegionScrollableAreasForPoint):
(BlackBerry::WebKit::WebPage::destroyWebPageCompositor):
- Api/WebPage.h:
(WebCore):
(WebKit):
- Api/WebPage_p.h:
(WebCore):
(WebKit):
- WebKitSupport/DumpRenderTreeSupport.cpp:
(DumpRenderTreeSupport::corePage):
(DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests):
(DumpRenderTreeSupport::resetGeolocationMock):
(DumpRenderTreeSupport::setMockGeolocationError):
(DumpRenderTreeSupport::setMockGeolocationPermission):
(DumpRenderTreeSupport::setMockGeolocationPosition):
(DumpRenderTreeSupport::scalePageBy):
- WebKitSupport/DumpRenderTreeSupport.h:
(WebCore):
(DumpRenderTreeSupport):
Tools:
Adapt to the removing of WebPage::mainFrame(), use
DumpRenderTreeSupport::corePage() and its mainFrame() instead.
No new tests as this patch doesn't change behavior.
- DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
(BlackBerry::WebKit::DumpRenderTree::runTests):
- 5:32 PM Changeset in webkit [109050] by
-
- 2 edits in trunk/Tools
Add Windows and Linux Chromium perf bots
https://bugs.webkit.org/show_bug.cgi?id=79418
Reviewed by Tony Chang.
Add Chromium Win and Linux perf bots. Also replace Chromium Mac by
the dedicated perf bot slave (uses the same hardware).
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 5:30 PM Changeset in webkit [109049] by
-
- 2 edits in trunk/Tools
Undefined variable 'current' when running chromium_android.py
https://bugs.webkit.org/show_bug.cgi?id=79696
Reviewed by Adam Barth.
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver._read_prompt):
- 5:24 PM Changeset in webkit [109048] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening, mark another svg test as flaky crasher
https://bugs.webkit.org/show_bug.cgi?id=79707
- platform/chromium/test_expectations.txt:
- 5:19 PM Changeset in webkit [109047] by
-
- 1 edit5 copies in branches/chromium/1025
Merge 108111 - REGRESSION: empty span creates renders with non-zero height
https://bugs.webkit.org/show_bug.cgi?id=76465
Reviewed by David Hyatt.
Source/WebCore:
Tests: fast/css/empty-span.html
fast/css/non-empty-span.html
Empty inlines with line-height, vertical-alignment or font metrics should only get a linebox if there is some
other content in the line. So only create line boxes for such elements on lines that are not empty.
This patch fixes a regression where an empty inline with line-height was propagating its height to an empty line.
It also fixes cases where lines with content that had a leading empty inline element weren't respecting the
vertical alignment or font-height of the empty inline.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::constructLine): only create line boxes for lines that are not empty.
(WebCore::requiresLineBoxForContent): an inline flow with line-height, vertical-alignment, or font-size
will need a linebox if the rest of the line is not empty.
(WebCore):
(WebCore::alwaysRequiresLineBox): rename from inlineFlowRequiresLineBox.
(WebCore::requiresLineBox):
(WebCore::RenderBlock::LineBreaker::nextLineBreak): if the inline flow definitely requires a line, mark
the line non-empty - otherwise hold off.
LayoutTests:
- fast/css/empty-span-expected.html: Added.
- fast/css/empty-span.html: Added.
- fast/css/non-empty-span.html: Added.
- platform/chromium/test_expectations.txt: Suppress result until rebaseline on MAC and WIN.
- platform/chromium-linux-x86/fast/css/non-empty-span-expected.png: Added.
- platform/chromium-linux-x86/fast/css/non-empty-span-expected.txt: Added.
TBR=robert@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9478022
- 5:16 PM Changeset in webkit [109046] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening, mark more svg tests as flaky crashers
https://bugs.webkit.org/show_bug.cgi?id=79707
- platform/chromium/test_expectations.txt:
- 5:12 PM Changeset in webkit [109045] by
-
- 1 edit2 adds in trunk/LayoutTests
Add test case for ::selection:window-inactive
https://bugs.webkit.org/show_bug.cgi?id=79623
Reviewed by Beth Dakin.
Add reftest to ensure that we don't regress inactive selection color.
For completeness, support for inactive selection color was added in
<http://trac.webkit.org/changeset/41094> (<rdar://problem/6077775>).
- fast/selectors/selection-window-inactive-expected.html: Added.
- fast/selectors/selection-window-inactive.html: Added.
- 5:10 PM Changeset in webkit [109044] by
-
- 4 edits2 copies in branches/chromium/1025
Merge 108724 - Don't clear IntentRequest callback pointers on stop()
This causes re-entry into ScriptExecutionContext when
the ActiveDOMCallback objects get deleted, which crashes.
Instead, just de-activate the object and wait for
context destruction to clean up.
Test crashes consistently without fix and passes with fix.
Added some test infrastructure to support this test.
https://bugs.webkit.org/show_bug.cgi?id=78638
Patch by Greg Billock <gbillock@google.com> on 2012-02-23
Reviewed by Adam Barth.
- Modules/intents/IntentRequest.cpp:
(WebCore::IntentRequest::IntentRequest):
(WebCore::IntentRequest::stop):
(WebCore::IntentRequest::postResult):
(WebCore::IntentRequest::postFailure):
- Modules/intents/IntentRequest.h:
(IntentRequest):
TBR=gbillock@google.com
Review URL: https://chromiumcodereview.appspot.com/9479030
- 5:05 PM Changeset in webkit [109043] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Unreviewed gardening, disable TransparencyWinTest unit tests
https://bugs.webkit.org/show_bug.cgi?id=79718
- tests/TransparencyWinTest.cpp:
- 5:05 PM Changeset in webkit [109042] by
-
- 3 edits in trunk/Source/WebCore
Extract the logic for computing the dirty rows / columns out of RenderTableSection::paintObject
https://bugs.webkit.org/show_bug.cgi?id=79580
Reviewed by Eric Seidel.
Refactoring only.
- rendering/RenderTableSection.h:
(CellSpan):
(WebCore::CellSpan::CellSpan):
(WebCore::CellSpan::start):
(WebCore::CellSpan::end):
Added this class to hold the span information.
(WebCore::RenderTableSection::fullTableRowSpan):
(WebCore::RenderTableSection::fullTableColumnSpan):
Those functions return the span corresponding to the full table.
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::dirtiedRows):
(WebCore::RenderTableSection::dirtiedColumns):
Those functions compute the rows / columns impacted by a |damageRect|. On the slow painting path, they
return the full table span.
(WebCore::RenderTableSection::paintObject):
Updated this function to call the new ones. Also we now inflate the local rectangle with the outlineSize.
This wasn't done previously and we had to manually patch some size comparison to account for the outline.
- 4:48 PM Changeset in webkit [109041] by
-
- 6 edits7 adds in trunk
Add more tests for web intents
https://bugs.webkit.org/show_bug.cgi?id=79527
Patch by Greg Billock <gbillock@google.com> on 2012-02-27
Reviewed by Adam Barth.
Tools:
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::sendWebIntentResponse):
- DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
(WebViewHost::currentIntentRequest):
LayoutTests:
- webintents/resources/web-intents-testing.js: Added.
- webintents/web-intents-failure-expected.txt: Added.
- webintents/web-intents-failure.html: Added.
- webintents/web-intents-invoke-expected.txt: Added.
- webintents/web-intents-invoke.html: Added.
- webintents/web-intents-reply-expected.txt: Added.
- webintents/web-intents-reply.html: Added.
- 4:37 PM Changeset in webkit [109040] by
-
- 7 edits in trunk/Source/JavaScriptCore
Old JIT's style of JSVALUE64 strict equality is subtly wrong
https://bugs.webkit.org/show_bug.cgi?id=79700
Reviewed by Oliver Hunt.
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::comparePtr):
(MacroAssemblerX86_64):
- dfg/DFGOperations.cpp:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeStrictEq):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
- jit/JITOpcodes.cpp:
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emitSlow_op_stricteq):
(JSC::JIT::emitSlow_op_nstricteq):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- 4:36 PM Changeset in webkit [109039] by
-
- 5 edits in trunk
[EFL] Support mutation observers
https://bugs.webkit.org/show_bug.cgi?id=79603
Patch by ChangSeok Oh <ChangSeok Oh> on 2012-02-27
Reviewed by Eric Seidel.
.:
Added a build-option for the mutation observers feature.
- Source/cmake/OptionsEfl.cmake:
- Source/cmakeconfig.h.cmake:
LayoutTests:
Rebased skipped tests regarding the mutation observers feature.
- platform/efl/Skipped:
- 4:31 PM Changeset in webkit [109038] by
-
- 21 edits in trunk/Source/JavaScriptCore
Implement support for op_negate and op_bitnot in the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=79617
Reviewed by Filip Pizlo.
Add an ArithNegate op to the DFG JIT, to implement op_negate.
This patch also adds support for op_negate to the JSVALUE64 baseline JIT
(JSVALUE32_64 already had this), so that we can profile the slowpath usage.
This is a 2.5%-3% Sunspider progression and a 1% win on Kraken.
- assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::sub_S):
- Added sub_S from immediate.
(ARMv7Assembler):
(JSC::ARMv7Assembler::vneg):
- Added double negate.
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::negateDouble):
- Added double negate.
(MacroAssemblerARMv7):
(JSC::MacroAssemblerARMv7::branchNeg32):
- Added.
- assembler/MacroAssemblerX86.h:
(MacroAssemblerX86):
- moved loadDouble, absDouble to common.
- assembler/MacroAssemblerX86Common.h:
(MacroAssemblerX86Common):
(JSC::MacroAssemblerX86Common::absDouble):
- implementation can be shared.
(JSC::MacroAssemblerX86Common::negateDouble):
- Added.
(JSC::MacroAssemblerX86Common::loadDouble):
- allow absDouble to have a common implementation.
- assembler/MacroAssemblerX86_64.h:
(MacroAssemblerX86_64):
- moved loadDouble, absDouble to common.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- support ArithNegate.
- dfg/DFGArithNodeFlagsInferencePhase.cpp:
(JSC::DFG::ArithNodeFlagsInferencePhase::propagate):
- support ArithNegate.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::makeSafe):
- support ArithNegate.
(JSC::DFG::ByteCodeParser::parseBlock):
- support op_negate.
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::performNodeCSE):
- support ArithNegate.
- dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
- support op_negate.
- dfg/DFGGraph.h:
(JSC::DFG::Graph::negateShouldSpeculateInteger):
- support ArithNegate.
- dfg/DFGNode.h:
(JSC::DFG::Node::hasArithNodeFlags):
- support ArithNegate.
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- support ArithNegate.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArithNegate):
- support ArithNegate.
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
- support ArithNegate.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- support ArithNegate.
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- support ArithNegate.
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
- Add support for op_negate in JSVALUE64.
- jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_negate):
(JSC::JIT::emitSlow_op_negate):
- Add support for op_negate in JSVALUE64.
- 4:17 PM Changeset in webkit [109037] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
Unreviewed, fixed wrong bug URL on the ChangeLog.
- 4:07 PM Changeset in webkit [109036] by
-
- 10 edits1 move in trunk/Source/WebCore
Rename resolve-supplemental.pl to preprocess-idls.pl
https://bugs.webkit.org/show_bug.cgi?id=79660
Reviewed by Adam Barth.
Due to r108322, resolve-supplemental.pl not only resolves supplemental
dependencies but also runs IDL attribute checker. For clarification,
this patch renames resolve-supplemental.pl to preprocess-idls.pl.
No tests. Confirm that all builds pass.
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.am:
- UseJSC.cmake:
- UseV8.cmake:
- WebCore.gyp/WebCore.gyp:
- WebCore.vcproj/MigrateScripts:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/scripts/preprocess-idls.pl: Renamed from Source/WebCore/bindings/scripts/resolve-supplemental.pl.
- 3:59 PM Changeset in webkit [109035] by
-
- 20 edits in trunk
[JSC] Add [ConstructorParameters=] to all custom constructors
https://bugs.webkit.org/show_bug.cgi?id=78221
Reviewed by Adam Barth.
Source/WebCore:
This patch adds [ConstructorParameters=X] to IDL files that have
custom constructors, where X is the maximum number of arguments
of the constructor. [ConstructorParameters=X] is needed for custom
constructors, because custom constructors do not have a signature
in IDL files and thus CodeGeneratorJS.pm cannot know the number of
constructor arguments.
Test: fast/js/constructor-length.html
- dom/WebKitMutationObserver.idl:
- html/DOMFormData.idl:
- html/canvas/ArrayBuffer.idl:
- html/canvas/DataView.idl:
- html/canvas/Float32Array.idl:
- html/canvas/Float64Array.idl:
- html/canvas/Int16Array.idl:
- html/canvas/Int32Array.idl:
- html/canvas/Int8Array.idl:
- html/canvas/Uint16Array.idl:
- html/canvas/Uint32Array.idl:
- html/canvas/Uint8Array.idl:
- html/canvas/Uint8ClampedArray.idl:
- webaudio/AudioContext.idl:
- bindings/scripts/test/TestTypedArray.idl:
- bindings/scripts/test/JS/JSFloat64Array.cpp: Updated run-bindings-tests results.
(WebCore::JSFloat64ArrayConstructor::finishCreation):
LayoutTests:
The added tests check the length property of the custom constructors.
- fast/js/constructor-length.html:
- platform/mac/fast/js/constructor-length-expected.txt:
- 3:56 PM Changeset in webkit [109034] by
-
- 2 edits in trunk/Source/JavaScriptCore
2012-02-27 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
Unreviewed. Build fix for linux-bot (qt) after r109021.
- runtime/Error.cpp:
- 3:48 PM Changeset in webkit [109033] by
-
- 5 edits in branches/chromium/1025/Source
Disable occlusion tracking and draw culling for Chromium m18
- 3:40 PM Changeset in webkit [109032] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening, mark many svg tests as flaky crashers
https://bugs.webkit.org/show_bug.cgi?id=79707
- platform/chromium/test_expectations.txt:
- 3:40 PM Changeset in webkit [109031] by
-
- 5 edits2 adds in trunk/Source/WebCore
[BlackBerry][EFL] Provide dummy RunLoop implementations.
https://bugs.webkit.org/show_bug.cgi?id=79398
Reviewed by Antonio Gomes.
r108067 fixed the EFL build by not building RunLoop.cpp on EFL and
BlackBerry, as both platforms lack an implementation that provides the
missing methods for the RunLoop class.
However, RunLoop.cpp is a generic file which should not be included
directly in PlatformWinCE.cmake (plus it helps in converting the
AppleWin port to CMake).
Fix this by providing a dummy implementation of the missing RunLoop
methods for both EFL and BlackBerry.
- CMakeLists.txt:
- PlatformBlackBerry.cmake:
- PlatformEfl.cmake:
- PlatformWinCE.cmake:
- platform/blackberry/RunLoopBlackBerry.cpp: Added.
(WebCore):
(WebCore::RunLoop::RunLoop):
(WebCore::RunLoop::~RunLoop):
(WebCore::RunLoop::wakeUp):
- platform/efl/RunLoopEfl.cpp: Added.
(WebCore):
(WebCore::RunLoop::RunLoop):
(WebCore::RunLoop::~RunLoop):
(WebCore::RunLoop::wakeUp):
- 3:32 PM Changeset in webkit [109030] by
-
- 3 edits in trunk/Source/WebCore
Build fix (on Lion at least).
- dom/Attr.cpp:
(WebCore::Attr::childrenChanged):
Removed names of unused parameters.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::childrenChanged):
Ditto.
- 3:29 PM Modules created by
- 3:22 PM Changeset in webkit [109029] by
-
- 7 edits in trunk/Source/WebCore
Remove [ConstructorParameters] from IDL files that have [Constructor]
https://bugs.webkit.org/show_bug.cgi?id=79643
Reviewed by Adam Barth.
This patch removes [ConstructorParameters] from IDL files that have [Constructor],
since CodeGeneratorJS.pm can automatically detect the number of constructor
arguments by the [Constructor(...)] signature.
Test: fast/js/constructor-length.html
- Modules/mediastream/PeerConnection.idl:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDefinition):
- css/WebKitCSSMatrix.idl:
- page/EventSource.idl:
- workers/SharedWorker.idl:
- workers/Worker.idl:
- 3:09 PM Changeset in webkit [109028] by
-
- 2 edits in trunk/Source/WebCore
Avoid doing 2 hash lookups if we override RenderBox's logical width / height
https://bugs.webkit.org/show_bug.cgi?id=79591
Reviewed by Antonio Gomes.
Refactoring only.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::clearOverrideSize):
Instead of doing one hash lookup as part of hasOverride{Height|Width}, let's
just directly call HashMap::remove that will do the lookup instead.
- 2:59 PM Changeset in webkit [109027] by
-
- 19 edits in branches/subpixellayout/Source
Build fix for Mac. Converting linesBoundingBox and borderBoundingBox, and ShadowData to integers. Removing a whitespace change to bring patch size down. Removing an extraneous printf.
- 2:53 PM Changeset in webkit [109026] by
-
- 5 edits in trunk/Source/WebCore
Move WebCore-internal DOM notification methods from Node to ContainerNode where appropriate
https://bugs.webkit.org/show_bug.cgi?id=79697
Reviewed by Ryosuke Niwa.
insertedIntoTree/removedFromTree are only used by subclasses of
ContainerNode. Moreover, attempting to make use of these notifications
in a non-container Node would currently not work, because
Node::removedFromDocument/insertedIntoDocument do not dispatch to these methods.
Rather than adding useless calls to an always-empty virtual method,
this patch moves these methods to ContainerNode.
Meanwhile, childrenChanged moves to ContainerNode for an obvious reason:
non-container Nodes have no children to change.
No new tests, refactoring only.
- dom/Attr.cpp:
(WebCore::Attr::childrenChanged): Remove call to now-nonexistent Node::childrenChanged.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChild): Check that the removed child is a container node before notifying it of removal.
(WebCore::ContainerNode::parserRemoveChild): ditto.
(WebCore::ContainerNode::insertedIntoTree): Remove call to now-nonexistent Node::insertedIntoTree.
(WebCore::ContainerNode::removedFromTree): Remove call to now-nonexistent Node::removedFromTree.
(WebCore::ContainerNode::childrenChanged): Remove call to now-nonexistent Node::childrenChanged.
(WebCore::notifyChildInserted): Check that the inserted child is a container node before notifying it of insertion.
- dom/ContainerNode.h:
(ContainerNode): Migrate comments from Node.h, point back at it for more notification methods.
- dom/Node.h:
(Node): Move methods, update comments to point at ContainerNode.h.
- 2:19 PM Changeset in webkit [109025] by
-
- 10 edits in branches/subpixellayout/Source
Fix a IntRect/LayoutRect usage to avoid unnecessary type conversions on branch.
- 2:19 PM Changeset in webkit [109024] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening, mark two fast/regex tests as failing
- platform/chromium/test_expectations.txt:
- 2:15 PM Changeset in webkit [109023] by
-
- 9 edits2 adds in trunk
Implement static compression curve parameters for DynamicsCompressorNode
https://bugs.webkit.org/show_bug.cgi?id=78937
Reviewed by Kenneth Russell.
Source/WebCore:
Test: webaudio/dynamicscompressor-basic.html
- platform/audio/DynamicsCompressor.cpp:
(WebCore::DynamicsCompressor::setParameterValue):
(WebCore):
(WebCore::DynamicsCompressor::initializeParameters):
(WebCore::DynamicsCompressor::process):
- platform/audio/DynamicsCompressor.h:
- platform/audio/DynamicsCompressorKernel.cpp:
(WebCore):
(WebCore::DynamicsCompressorKernel::DynamicsCompressorKernel):
(WebCore::DynamicsCompressorKernel::setPreDelayTime):
(WebCore::DynamicsCompressorKernel::kneeCurve):
(WebCore::DynamicsCompressorKernel::saturate):
(WebCore::DynamicsCompressorKernel::slopeAt):
(WebCore::DynamicsCompressorKernel::kAtSlope):
(WebCore::DynamicsCompressorKernel::updateStaticCurveParameters):
(WebCore::DynamicsCompressorKernel::process):
- platform/audio/DynamicsCompressorKernel.h:
(DynamicsCompressorKernel):
(WebCore::DynamicsCompressorKernel::meteringGain):
- webaudio/DynamicsCompressorNode.cpp:
(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
(WebCore::DynamicsCompressorNode::process):
- webaudio/DynamicsCompressorNode.h:
(WebCore):
(WebCore::DynamicsCompressorNode::create):
(DynamicsCompressorNode):
(WebCore::DynamicsCompressorNode::threshold):
(WebCore::DynamicsCompressorNode::knee):
(WebCore::DynamicsCompressorNode::ratio):
(WebCore::DynamicsCompressorNode::reduction):
- webaudio/DynamicsCompressorNode.idl:
LayoutTests:
- webaudio/dynamicscompressor-basic-expected.txt: Added.
- webaudio/dynamicscompressor-basic.html: Added.
- 2:03 PM Changeset in webkit [109022] by
-
- 7 edits in trunk/Source
WebKit2: implement platform strategy to access Pasteboard in the UI process.
https://bugs.webkit.org/show_bug.cgi?id=79253
<rdar://problem/9971876>
Reviewed by Alexey Proskuryakov.
Source/WebCore:
No new tests. No behavior change.
- platform/mac/PlatformPasteboardMac.mm:
(WebCore::PlatformPasteboard::bufferForType): There is no need
to create a SharedBuffer object if there is no NSData in the pasteboard
for the given pasteboard type.
Source/WebKit2:
- UIProcess/WebContext.h:
- UIProcess/WebContext.messages.in: Added messages to access NSPasteboard
in the UI process.
- UIProcess/mac/WebContextMac.mm: Added methods corresponding to the
new messages.
(WebKit::WebContext::getPasteboardTypes):
(WebKit::WebContext::getPasteboardPathnamesForType):
(WebKit::WebContext::getPasteboardStringForType):
(WebKit::WebContext::getPasteboardBufferForType):
(WebKit::WebContext::pasteboardCopy):
(WebKit::WebContext::getPasteboardChangeCount):
(WebKit::WebContext::getPasteboardUniqueName):
(WebKit::WebContext::getPasteboardColor):
(WebKit::WebContext::setPasteboardTypes):
(WebKit::WebContext::setPasteboardPathnamesForType):
(WebKit::WebContext::setPasteboardStringForType):
(WebKit::WebContext::setPasteboardBufferForType):
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: New implementation of the PasteboardStrategy using message exchange
with the UI process.
(WebKit::WebPlatformStrategies::getTypes):
(WebKit::WebPlatformStrategies::bufferForType):
(WebKit::WebPlatformStrategies::getPathnamesForType):
(WebKit::WebPlatformStrategies::stringForType):
(WebKit::WebPlatformStrategies::copy):
(WebKit::WebPlatformStrategies::changeCount):
(WebKit::WebPlatformStrategies::uniqueName):
(WebKit::WebPlatformStrategies::color):
(WebKit::WebPlatformStrategies::setTypes):
(WebKit::WebPlatformStrategies::setBufferForType):
(WebKit::WebPlatformStrategies::setPathnamesForType):
(WebKit::WebPlatformStrategies::setStringForType):
- 1:33 PM Changeset in webkit [109021] by
-
- 4 edits in trunk
REGRESSION (r108112): AWS Management Console at amazon.com fails to initialize
https://bugs.webkit.org/show_bug.cgi?id=79693
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Alas we can't provide the stack trace as an array, as despite everyone wanting
an array, everyone arbitrarily creates the array by calling split on the stack
trace. To create the array we would have provided them in the first place.
This changes the exception's stack property to a \n separated string. To get the
old array just do <exception>.stack.split("\n").
- runtime/Error.cpp:
(JSC::addErrorInfo):
LayoutTests:
Update test case to handle Error.stack being a string rather than an array.
- fast/js/script-tests/stack-trace.js:
(printStack):
- 1:24 PM Changeset in webkit [109020] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Unreviewed speculative Chromium win build fix.
mdelaney's http://trac.webkit.org/changeset/109016 changed the
interface on ImageBuffer, but didn't update TransparencyWin.
- platform/graphics/chromium/TransparencyWin.cpp:
(WebCore::TransparencyWin::OwnedBuffers::canHandleSize):
- 1:22 PM Changeset in webkit [109019] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Selection handling should be entirely directional
https://bugs.webkit.org/show_bug.cgi?id=79692
Patch by Mike Fenton <mifenton@rim.com> on 2012-02-27
Reviewed by Antonio Gomes.
Make all VisibleSelections directional.
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
(BlackBerry::WebKit::SelectionHandler::setSelection):
- 1:10 PM Changeset in webkit [109018] by
-
- 2 edits in trunk/LayoutTests
Cleanup Gesture requirement when exiting video-play-require-user-gesture test
https://bugs.webkit.org/show_bug.cgi?id=79690
Patch by Min Qin <qinmin@google.com> on 2012-02-27
Reviewed by Philippe Normand.
- media/video-play-require-user-gesture.html:
- 1:03 PM Changeset in webkit [109017] by
-
- 2 edits in trunk/Tools
Chromium-Android layout test script: the adb shell prompt is not always '# '
https://bugs.webkit.org/show_bug.cgi?id=79506
Reviewed by Adam Barth.
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver._start):
(ChromiumAndroidDriver._read_prompt):
- 12:43 PM Changeset in webkit [109016] by
-
- 26 edits in trunk/Source/WebCore
Add ImageBuffer support for having a hi-res backing store. This allows
ImageBuffer clients to specify a scale factor upon creation so that they
don't have to maintain that info themselves as they use/pass around the ImageBuffer.
https://bugs.webkit.org/show_bug.cgi?id=79395
Reviewed by Dan Bernstein.
No new tests. This patch doesn't change behavior.
- platform/graphics/ImageBuffer.h:
(WebCore::ImageBuffer::create): Scale the backing store by the resolution scale.
(WebCore::ImageBuffer::logicalSize): Differentiate the logical size from the backing store's size.
(WebCore::ImageBuffer::internalSize): The backing store's size.
- platform/graphics/cg/ImageBufferCG.cpp: Prefer the explicit use of logicalSize and internalSize.
Explicitly state a 1x scale for all ImageBuffer creation sites
since this is what they currently assume.
- html/HTMLCanvasElement.cpp:
- html/canvas/CanvasRenderingContext2D.cpp:
- html/canvas/WebGLRenderingContext.cpp:
- page/Frame.cpp:
- platform/graphics/CrossfadeGeneratedImage.cpp:
- platform/graphics/ShadowBlur.cpp:
- platform/graphics/filters/FEColorMatrix.cpp:
- platform/graphics/filters/FEDropShadow.cpp:
- platform/graphics/filters/FilterEffect.cpp:
- platform/mac/ScrollbarThemeMac.mm:
- rendering/FilterEffectRenderer.cpp:
- rendering/RenderThemeMac.mm:
- rendering/svg/SVGImageBufferTools.cpp:
- svg/graphics/SVGImage.cpp:
- svg/graphics/SVGImageCache.cpp:
Update ImageBuffer::size() calls to new versions.
- platform/graphics/GraphicsContext.cpp:
- platform/graphics/ImageBuffer.cpp:
- platform/graphics/skia/PlatformContextSkia.cpp:
- 12:36 PM Changeset in webkit [109015] by
-
- 20 edits in trunk
[CSSRegions]-webkit-flow-into initial value should be none instead of auto
https://bugs.webkit.org/show_bug.cgi?id=79670
Reviewed by Simon Fraser.
Source/WebCore:
No new tests, modified expectations for existing tests.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseFlowThread):
- css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
LayoutTests:
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- fast/regions/css-regions-disabled-expected.txt:
- fast/regions/script-tests/css-regions-disabled.js:
- fast/regions/script-tests/webkit-flow-parsing.js:
- fast/regions/webkit-flow-parsing-expected.txt:
- platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/qt/svg/css/getComputedStyle-basic-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 12:33 PM Changeset in webkit [109014] by
-
- 3 edits2 adds in trunk
implement display: -webkit-inline-flexbox
https://bugs.webkit.org/show_bug.cgi?id=77772
Reviewed by David Hyatt.
Source/WebCore:
Tests: css3/flexbox/inline-flexbox-expected.html
css3/flexbox/inline-flexbox.html
- rendering/style/RenderStyle.h:
-Add INLINE_FLEXBOX to the list of replaced display types.
-Restructure the isDisplayInline methods to avoid code duplication.
LayoutTests:
- css3/flexbox/inline-flexbox-expected.html: Added.
- css3/flexbox/inline-flexbox.html: Added.
- 12:03 PM Changeset in webkit [109013] by
-
- 5 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Dragging a selection handle outside of the content bounding box does not update the selection range correctly
https://bugs.webkit.org/show_bug.cgi?id=78608
Ensure that when selection handles leave the content bounding box that
the handle not being dragged remains fixed. Do not apply padding to a
direction that would cause the selection to shrink when performing the
handle direction detection.
Patch by Ed Baker <edbaker@rim.com> on 2012-02-27
Reviewed by Antonio Gomes.
- WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::convertPointToFrame):
- WebKitSupport/DOMSupport.h:
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::clamp):
(BlackBerry::WebKit::directionalVisiblePositionAtExtentOfBox):
(BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
(BlackBerry::WebKit::SelectionHandler::setSelection):
(BlackBerry::WebKit::SelectionHandler::clipPointToVisibleContainer):
- WebKitSupport/SelectionHandler.h:
- 11:58 AM Changeset in webkit [109012] by
-
- 4 edits2 copies in branches/chromium/963
REGRESSION(r99076): WebKit pastes the trailing newline into a single-line text field
https://bugs.webkit.org/show_bug.cgi?id=79305
Reviewed by Tony Chang.
LayoutTests:
Add a regression test. Also make Markup.dump() dump the shadow DOM of the specififed node.
- editing/input/paste-text-ending-with-interchange-newline-expected.txt: Added.
- editing/input/paste-text-ending-with-interchange-newline.html: Added.
- resources/dump-as-markup.js:
(Markup._get):
(Markup._getShadowHostIfPossible):
Source/WebCore:
The bug was caused by ReplacementFragment::m_hasInterchangeNewlineAtEnd not reset even when
text field's beforeTextInserted event handler removed interchange new lines at the end.
Because the event handler is responsible for trimming new lines, we need to recompute the values
for m_hasInterchangeNewlineAt* after the event dispatch.
Test: editing/input/paste-text-ending-with-interchange-newline.html
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::ReplacementFragment):
Merge 108668 - REGRESSION(r99076): WebKit pastes the trailing newline into a single-line text field
https://bugs.webkit.org/show_bug.cgi?id=79305
Reviewed by Tony Chang.
Source/WebCore:
The bug was caused by ReplacementFragment::m_hasInterchangeNewlineAtEnd not reset even when
text field's beforeTextInserted event handler removed interchange new lines at the end.
Because the event handler is responsible for trimming new lines, we need to recompute the values
for m_hasInterchangeNewlineAt* after the event dispatch.
Test: editing/input/paste-text-ending-with-interchange-newline.html
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::ReplacementFragment):
LayoutTests:
Add a regression test. Also make Markup.dump() dump the shadow DOM of the specififed node.
- editing/input/paste-text-ending-with-interchange-newline-expected.txt: Added.
- editing/input/paste-text-ending-with-interchange-newline.html: Added.
- resources/dump-as-markup.js:
(Markup._get):
(Markup._getShadowHostIfPossible):
TBR=rniwa@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9477008
- 11:48 AM Changeset in webkit [109011] by
-
- 3 edits2 adds in trunk
Absolute positioned elements with Inline Relative Positioned Container are not layout correctly
https://bugs.webkit.org/show_bug.cgi?id=78713
Patch by Ken Buchanan <kenrb@chromium.org> on 2012-02-27
Reviewed by David Hyatt.
Source/WebCore:
Test: fast/css/positioned-in-relative-position-inline-crash.html
Patch originally by Robin Cao.
This is a regression. r104183 changes containingBlock() so that it returns the container
of an anonymous block for positioned objects, not the anonymous block itself. We should
change markContainingBlocksForLayout() to match the change in containingBlock().
- rendering/RenderObject.cpp:
(WebCore::RenderObject::markContainingBlocksForLayout):
LayoutTests:
Test case originally by Robin Cao. This exercises the crashing
condition in bug 78713.
- fast/css/positioned-in-relative-position-inline-crash-expected.txt: Added.
- fast/css/positioned-in-relative-position-inline-crash.html: Added.
- 11:26 AM Changeset in webkit [109010] by
-
- 1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderLayer.cpp
Properly using pixel snapping to determing RenderLayer size on Layered Inlines.
- 11:14 AM Changeset in webkit [109009] by
-
- 8 edits in trunk
Web Inspector: move record formatting into the timeline presentation model.
https://bugs.webkit.org/show_bug.cgi?id=79684
Source/WebCore:
Drive-by: fix for stop recording in reset; cpu time restored.
Reviewed by Vsevolod Vlasov.
- inspector/front-end/TimelineModel.js:
(WebInspector.TimelineModel.prototype.reset):
- inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane.prototype.update.updateBoundaries):
(WebInspector.TimelineOverviewCalculator.prototype.updateBoundaries):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._rootRecord):
(WebInspector.TimelinePanel.prototype._updateRecordsCounter):
(WebInspector.TimelinePanel.prototype._repopulateRecords):
(WebInspector.TimelinePanel.prototype._onTimelineEventRecorded):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype._resetPanel):
(WebInspector.TimelinePanel.prototype._refresh):
(WebInspector.TimelinePanel.prototype._updateBoundaries):
(WebInspector.TimelinePanel.prototype._filterRecords):
(WebInspector.TimelinePanel.prototype.revealRecordAt):
(WebInspector.TimelinePanel.prototype._showPopover):
(WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages):
(WebInspector.TimelineCalculator.prototype.computeBarGraphWindowPosition):
(WebInspector.TimelineCalculator.prototype.updateBoundaries):
(WebInspector.TimelineStartAtZeroCalculator.prototype.computeBarGraphPercentages):
(WebInspector.TimelineRecordGraphRow):
(WebInspector.TimelineRecordGraphRow.prototype.update):
- inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel):
(WebInspector.TimelinePresentationModel.prototype.createFormattedRecord):
(WebInspector.TimelinePresentationModel.prototype._createRootRecord):
(WebInspector.TimelinePresentationModel.prototype.rootRecord):
(WebInspector.TimelinePresentationModel.prototype.reset):
(WebInspector.TimelinePresentationModel.prototype._findParentRecord):
(WebInspector.TimelinePresentationModel.prototype._resetWindow):
(WebInspector.TimelinePresentationModel.prototype._addCategory):
(WebInspector.TimelinePresentationModel.prototype.setCategoryVisibility):
(WebInspector.TimelinePresentationModel.prototype.get _recordStyles):
(WebInspector.TimelinePresentationModel.Record):
(WebInspector.TimelinePresentationModel.Record.prototype.get lastChildEndTime):
(WebInspector.TimelinePresentationModel.Record.prototype.set lastChildEndTime):
(WebInspector.TimelinePresentationModel.Record.prototype.get selfTime):
(WebInspector.TimelinePresentationModel.Record.prototype.set selfTime):
(WebInspector.TimelinePresentationModel.Record.prototype.get cpuTime):
(WebInspector.TimelinePresentationModel.Record.prototype.isLong):
(WebInspector.TimelinePresentationModel.Record.prototype.get children):
(WebInspector.TimelinePresentationModel.Record.prototype.containsTime):
(WebInspector.TimelinePresentationModel.Record.prototype._generateAggregatedInfo):
(WebInspector.TimelinePresentationModel.Record.prototype.generatePopupContent):
(WebInspector.TimelinePresentationModel.Record.prototype._refreshDetails):
(WebInspector.TimelinePresentationModel.Record.prototype._getRecordDetails):
(WebInspector.TimelinePresentationModel.Record.prototype._linkifyLocation):
(WebInspector.TimelinePresentationModel.Record.prototype._linkifyCallFrame):
(WebInspector.TimelinePresentationModel.Record.prototype._linkifyTopCallFrame):
(WebInspector.TimelinePresentationModel.Record.prototype._linkifyScriptLocation):
(WebInspector.TimelinePresentationModel.Record.prototype.calculateAggregatedStats):
(WebInspector.TimelinePresentationModel.Record.prototype.get aggregatedStats):
(WebInspector.TimelinePresentationModel.PopupContentHelper):
(WebInspector.TimelinePresentationModel.PopupContentHelper.prototype._createCell):
(WebInspector.TimelinePresentationModel.PopupContentHelper.prototype._appendTextRow):
(WebInspector.TimelinePresentationModel.PopupContentHelper.prototype._appendElementRow):
(WebInspector.TimelinePresentationModel.PopupContentHelper.prototype._appendStackTrace):
- inspector/front-end/timelinePanel.css:
(.timeline-graph-bar.cpu):
LayoutTests:
Reviewed by Vsevolod Vlasov.
- inspector/timeline/timeline-receive-response-event.html:
- 10:29 AM Changeset in webkit [109008] by
-
- 6 edits3 adds in trunk
RegExp lastIndex should behave as a regular property
https://bugs.webkit.org/show_bug.cgi?id=79446
Reviewed by Sam Weinig.
lastIndex should be a regular data descriptor, with the attributes configurable:false,
enumerable:false, writable:true. As such, it should be possible to reconfigure writable
as false. If the lastIndex property is reconfigured to be read-only, we should respect
this correctly.
Source/JavaScriptCore:
- runtime/CommonIdentifiers.h:
- Removed some unused identifiers, added lastIndex.
- runtime/RegExpObject.cpp:
(JSC::RegExpObject::getOwnPropertySlot):
- lastIndex is no longer a static value, provided specific handling.
(JSC::RegExpObject::getOwnPropertyDescriptor):
- lastIndex is no longer a static value, provided specific handling.
(JSC::RegExpObject::deleteProperty):
- lastIndex is no longer a static value, provided specific handling.
(JSC::RegExpObject::getOwnPropertyNames):
- lastIndex is no longer a static value, provided specific handling.
(JSC::RegExpObject::getPropertyNames):
- lastIndex is no longer a static value, provided specific handling.
(JSC::reject):
- helper function for defineOwnProperty.
(JSC::RegExpObject::defineOwnProperty):
- lastIndex is no longer a static value, provided specific handling.
(JSC::RegExpObject::put):
- lastIndex is no longer a static value, provided specific handling.
(JSC::RegExpObject::match):
- Pass setLastIndex an ExecState, so it can throw if read-only.
- runtime/RegExpObject.h:
(JSC::RegExpObject::setLastIndex):
- Pass setLastIndex an ExecState, so it can throw if read-only.
(RegExpObjectData):
- Added lastIndexIsWritable.
- runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncCompile):
- Pass setLastIndex an ExecState, so it can throw if read-only.
LayoutTests:
- fast/regex/lastIndex-expected.txt: Added.
- fast/regex/lastIndex.html: Added.
- fast/regex/script-tests/lastIndex.js: Added.
- Added test cases for correct handling of lastIndex.
- 10:26 AM Changeset in webkit [109007] by
-
- 22 edits in trunk/Source/JavaScriptCore
Implement support for op_negate and op_bitnot in the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=79617
Reviewed by Sam Weinig.
Remove op_bitnop - this is redundant, ~x === x-1.
This is a fractional (<1%) progression.
Remove not32(X) from the MacroAssemblers - make this an optimization to add32(-1, X).
Remove CanReuse from the result type - this was unused.
Remove op_bitnot.
- assembler/MacroAssemblerARM.h:
(MacroAssemblerARM):
(JSC::MacroAssemblerARM::xor32):
- assembler/MacroAssemblerARMv7.h:
(MacroAssemblerARMv7):
(JSC::MacroAssemblerARMv7::xor32):
- assembler/MacroAssemblerMIPS.h:
(MacroAssemblerMIPS):
(JSC::MacroAssemblerMIPS::xor32):
- assembler/MacroAssemblerSH4.h:
(MacroAssemblerSH4):
(JSC::MacroAssemblerSH4::xor32):
- assembler/MacroAssemblerX86Common.h:
(MacroAssemblerX86Common):
(JSC::MacroAssemblerX86Common::xor32):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
- bytecode/Opcode.h:
(JSC):
(JSC::padOpcodeName):
- bytecompiler/NodesCodegen.cpp:
(JSC):
(JSC::BitwiseNotNode::emitBytecode):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
(JIT):
- jit/JITArithmetic32_64.cpp:
(JSC):
- jit/JITOpcodes.cpp:
(JSC):
- jit/JITStubs.cpp:
(JSC):
- jit/JITStubs.h:
- llint/LLIntSlowPaths.cpp:
(LLInt):
- llint/LLIntSlowPaths.h:
(LLInt):
- llint/LowLevelInterpreter32_64.asm:
- parser/NodeConstructors.h:
(JSC::NegateNode::NegateNode):
(JSC::BitwiseNotNode::BitwiseNotNode):
(JSC::MultNode::MultNode):
(JSC::DivNode::DivNode):
(JSC::ModNode::ModNode):
(JSC::SubNode::SubNode):
(JSC::UnsignedRightShiftNode::UnsignedRightShiftNode):
- parser/Nodes.h:
(BitwiseNotNode):
(JSC::BitwiseNotNode::expr):
(JSC):
- parser/ResultType.h:
(ResultType):
(JSC::ResultType::numberTypeIsInt32):
(JSC::ResultType::stringOrNumberType):
(JSC::ResultType::forAdd):
(JSC::ResultType::forBitOp):
- 10:15 AM Changeset in webkit [109006] by
-
- 7 edits in trunk/Source/WebCore
Web Inspector: Scripts navigator overlay should not consume mouse actions.
https://bugs.webkit.org/show_bug.cgi?id=79674
Reviewed by Pavel Feldman.
- inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.registerShortcut):
(WebInspector.Panel.prototype.unregisterShortcut):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._editorClosed):
(WebInspector.ScriptsPanel.prototype._editorSelected):
(WebInspector.ScriptsPanel.prototype._fileSelected):
(WebInspector.ScriptsPanel.prototype._escDownWhileNavigatorOverlayOpen):
(WebInspector.ScriptsPanel.prototype.set _showNavigatorOverlay):
(WebInspector.ScriptsPanel.prototype._hideNavigatorOverlay):
(WebInspector.ScriptsPanel.prototype._navigatorOverlayWasShown):
- inspector/front-end/SidebarOverlay.js:
(WebInspector.SidebarOverlay):
(WebInspector.SidebarOverlay.prototype.show):
(WebInspector.SidebarOverlay.prototype._containingElementFocused):
(WebInspector.SidebarOverlay.prototype.position):
(WebInspector.SidebarOverlay.prototype.hide):
(WebInspector.SidebarOverlay.prototype._setWidth):
- inspector/front-end/dialog.css:
(.go-to-line-dialog button:active):
- inspector/front-end/scriptsPanel.css:
(#scripts-editor-view .sidebar-overlay):
- inspector/front-end/splitView.css:
(.split-view-resizer):
(.sidebar-overlay):
(.sidebar-overlay-resizer):
- 10:04 AM Changeset in webkit [109005] by
-
- 6 edits2 adds in trunk/Source/WebCore
[GStreamer] 0.11 support in MediaPlayerPrivateGStreamer
https://bugs.webkit.org/show_bug.cgi?id=77089
Reviewed by Martin Robinson.
Basic port to GStreamer 0.11 APIs. This patch excludes the video
painting changes and the GStreamerGWorld changes which are handled
in two other patches (bugs 77087 and 77088).
- GNUmakefile.list.am: Add GStreamerVersioning files to the build.
- Source/WebCore/PlatformEfl.cmake: Ditto.
- Source/WebCore/Target.pri: Ditto.
- platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
(WTF::GstElement):
(WTF::GstPad):
(WTF::GstPadTemplate):
(WTF::GstTask):
- platform/graphics/gstreamer/GStreamerVersioning.cpp: Added.
(webkit_gst_object_ref_sink):
(webkit_gst_element_get_pad_caps):
- platform/graphics/gstreamer/GStreamerVersioning.h: Added.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::isAvailable):
(WebCore::MediaPlayerPrivateGStreamer::duration):
(WebCore::MediaPlayerPrivateGStreamer::naturalSize):
- 10:00 AM Changeset in webkit [109004] by
-
- 4 edits2 adds in trunk
Source/WebKit2: <rdar://problem/9557598> REGRESSION (WebKit2): Non-activating links sometimes don’t work
https://bugs.webkit.org/show_bug.cgi?id=79607
Reviewed by Adele Peterson.
Test: TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm
This was caused by not mapping the mouse event coordinates from window coordinates to
document coordinates.
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDictionaryLookupAtLocation): Convert the point to main frame
coordinates when performing the hit test.
(WebKit::WebPage::shouldDelayWindowOrderingEvent): Convert the point to the main or focused
frame coordinates when perfomring the hit test.
(WebKit::WebPage::acceptsFirstMouse): Ditto.
Tools: Added a test for <rdar://problem/9557598> REGRESSION (WebKit2): Non-activating links sometimes don’t work
https://bugs.webkit.org/show_bug.cgi?id=79607
Reviewed by Adele Peterson.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
- TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm: Added.
(TestWebKitAPI::AcceptsFirstMouse::url):
(TestWebKitAPI::AcceptsFirstMouse::didLoadURL):
(TestWebKitAPI::AcceptsFirstMouse::runTest):
(TestWebKitAPI::TEST_F):
- TestWebKitAPI/Tests/mac/acceptsFirstMouse.html: Added.
- 9:57 AM Changeset in webkit [109003] by
-
- 2 edits in trunk/Source/WebCore
Stop recomputing SVG path data twice during layout
https://bugs.webkit.org/show_bug.cgi?id=79672
Patch by Philip Rogers <pdr@google.com> on 2012-02-27
Reviewed by Nikolas Zimmermann.
- rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::layout):
- 9:51 AM Changeset in webkit [109002] by
-
- 12 edits in trunk/Source
Add WKInspector API to know when the Web Inspector is the frontmost window.
Reviewed by John Sullivan.
Source/WebCore: Updated for WebKit2 string changes.
- English.lproj/Localizable.strings: Updated.
Source/WebKit2: Also makes the Safari Develop menu items work when the Web Inspector is frontmost.
- UIProcess/API/C/WKInspector.cpp:
(WKInspectorIsFront): Added. Call WebInspectorProxy::isFront.
- UIProcess/API/C/WKInspector.h:
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::isFront): Added. Call platformIsFront.
- UIProcess/WebInspectorProxy.h:
- UIProcess/efl/WebInspectorEfl.cpp:
(WebKit::WebInspectorProxy::platformIsFront): Added stub.
- UIProcess/gtk/WebInspectorGtk.cpp:
(WebKit::WebInspectorProxy::platformIsFront): Added stub.
- UIProcess/mac/WebInspectorProxyMac.mm:
(-[WKWebInspectorProxyObjCAdapter showWebInspector:]): Added. Makes the Develop menu items in Safari work when
the Web Inspector window is front.
(-[WKWebInspectorProxyObjCAdapter showErrorConsole:]): Added. Ditto.
(-[WKWebInspectorProxyObjCAdapter showResources:]): Added. Ditto.
(-[WKWebInspectorProxyObjCAdapter viewSource:]): Added. Ditto.
(-[WKWebInspectorProxyObjCAdapter toggleDebuggingJavaScript:]): Added. Ditto.
(-[WKWebInspectorProxyObjCAdapter toggleProfilingJavaScript:]): Added. Ditto.
(-[WKWebInspectorProxyObjCAdapter validateUserInterfaceItem:]): Added. Update the menu item titles.
(WebKit::WebInspectorProxy::platformIsFront): Added. Return if visible and the window is main.
- UIProcess/qt/WebInspectorProxyQt.cpp:
(WebKit::WebInspectorProxy::platformIsFront): Added stub.
- UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::platformIsFront): Added stub.
- 9:42 AM Changeset in webkit [109001] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening, mark getPutImageDataPair as slow
https://bugs.webkit.org/show_bug.cgi?id=79679
- platform/chromium/test_expectations.txt:
- 9:34 AM Changeset in webkit [109000] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Ctrl+K should not zoom in
https://bugs.webkit.org/show_bug.cgi?id=79676
Reviewed by Vsevolod Vlasov.
- inspector/front-end/inspector.js:
(WebInspector.documentKeyDown):
- 9:22 AM Changeset in webkit [108999] by
-
- 5 edits in trunk
Error check regexp min quantifier
https://bugs.webkit.org/show_bug.cgi?id=70648
Reviewed by Gavin Barraclough.
Source/JavaScriptCore:
Added checking for min or only quantifier being UINT_MAX.
When encountered this becomes a SyntaxError during parsing.
- yarr/YarrParser.h:
(JSC::Yarr::Parser::parseQuantifier):
(JSC::Yarr::Parser::parse):
(Parser):
LayoutTests:
New test added to check for newly generated SyntaxError.
- fast/regex/overflow-expected.txt:
- fast/regex/script-tests/overflow.js:
(quantifyMaxInt):
- 9:01 AM Changeset in webkit [108998] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk
Patch from Vincent Untz <vuntz@gnome.org> to fix gtk2 build
- 8:58 AM Changeset in webkit [108997] by
-
- 14 edits2 adds1 delete in trunk
Web Inspector: extract TimelineModel and TimelinePresentationModel into their own files.
https://bugs.webkit.org/show_bug.cgi?id=79675
Reviewed by Vsevolod Vlasov.
Source/WebCore:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.sh:
- inspector/front-end/TimelineAgent.js: Removed.
- inspector/front-end/TimelineModel.js: Added.
(WebInspector.TimelineModel):
(WebInspector.TimelineModel.prototype.startRecord):
(WebInspector.TimelineModel.prototype.stopRecord):
(WebInspector.TimelineModel.prototype.get records):
(WebInspector.TimelineModel.prototype._onRecordAdded):
(WebInspector.TimelineModel.prototype._addRecord):
(WebInspector.TimelineModel.prototype._loadNextChunk):
(WebInspector.TimelineModel.prototype._loadFromFile):
(WebInspector.TimelineModel.prototype._loadFromFile.onError):
(WebInspector.TimelineModel.prototype._saveToFile):
(WebInspector.TimelineModel.prototype._reset):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype.get _recordStyles):
(WebInspector.TimelinePanel.prototype._createEventDivider):
(WebInspector.TimelinePanel.prototype._findParentRecord):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
- inspector/front-end/TimelinePresentationModel.js: Added.
(WebInspector.TimelinePresentationModel):
(WebInspector.TimelinePresentationModel.prototype.reset):
(WebInspector.TimelinePresentationModel.prototype.get categories):
(WebInspector.TimelinePresentationModel.prototype.addCategory):
(WebInspector.TimelinePresentationModel.prototype.setWindowPosition):
(WebInspector.TimelinePresentationModel.prototype.setWindowIndices):
(WebInspector.TimelinePresentationModel.prototype.setCategoryVisibility):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
LayoutTests:
- inspector/timeline/timeline-enum-stability.html:
- inspector/timeline/timeline-network-resource.html:
- inspector/timeline/timeline-paint.html:
- inspector/timeline/timeline-script-tag-1.html:
- inspector/timeline/timeline-test.js:
(initialize_Timeline.InspectorTest.waitForRecordType.addRecord):
(initialize_Timeline.InspectorTest.waitForRecordType):
(initialize_Timeline.InspectorTest.printTimelineRecords):
(initialize_Timeline.InspectorTest.dumpTimelineRecord):
(initialize_Timeline.InspectorTest._timelineAgentTypeToString):
- 8:54 AM Changeset in webkit [108996] by
-
- 2 edits in trunk/Source/WebKit/gtk
Build fix for building with GTK+ 2.x.
Patch by Vincent Untz <vuntz@gnome.org>> and Gustavo Noronha Silva <Gustavo Noronha Silva> on 2012-02-27
- tests/testwebview.c:
- 8:49 AM SettingUpDevelopmentEnvironmentForN9 edited by
- (diff)
- 8:36 AM Changeset in webkit [108995] by
-
- 11 edits in trunk
Web Inspector: [Styles] Allow adding CSS properties anywhere in the style declaration, not only at the end
https://bugs.webkit.org/show_bug.cgi?id=79662
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleDeclaration.prototype.newBlankProperty):
(WebInspector.CSSProperty.prototype.setText):
(WebInspector.CSSProperty.prototype.setValue):
- inspector/front-end/MetricsSidebarPane.js:
(WebInspector.MetricsSidebarPane.prototype._applyUserInput):
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection):
(WebInspector.StylePropertiesSection.prototype._handleSelectorContainerClick):
(WebInspector.StylePropertiesSection.prototype.addNewBlankProperty):
(WebInspector.StylePropertyTreeElement.prototype):
(WebInspector.StylePropertyTreeElement.prototype.element.userInput.previousContent.context.moveDirection):
(WebInspector.StylePropertyTreeElement.prototype.styleText.updateInterface.majorChange.isRevert):
LayoutTests:
- inspector/styles/styles-add-blank-property-expected.txt:
- inspector/styles/styles-add-blank-property.html:
- inspector/styles/styles-formatting.html:
- inspector/styles/styles-history.html:
- inspector/styles/undo-add-property-expected.txt:
- inspector/styles/undo-add-property.html:
- 8:34 AM SettingUpDevelopmentEnvironmentForN9 edited by
- (diff)
- 7:49 AM Changeset in webkit [108994] by
-
- 2 edits in trunk/LayoutTests
Unreviewed fix for lint error after r108992.
- platform/chromium/test_expectations.txt:
- 7:22 AM Changeset in webkit [108993] by
-
- 15 edits in trunk
Source/WebCore: [Shadow]: Expose one ShadowRoot in the Elements panel (under experiment flag)
https://bugs.webkit.org/show_bug.cgi?id=78202
Reviewed by Yury Semikhatsky.
- dom/ShadowTree.cpp:
(WebCore::ShadowTree::pushShadowRoot):
(WebCore::ShadowTree::popShadowRoot):
- inspector/Inspector.json:
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::unbind):
(WebCore::InspectorDOMAgent::assertEditableNode):
(WebCore::InspectorDOMAgent::assertEditableElement):
(WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
(WebCore::InspectorDOMAgent::setAttributeValue):
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::removeAttribute):
(WebCore::InspectorDOMAgent::removeNode):
(WebCore::InspectorDOMAgent::setOuterHTML):
(WebCore::InspectorDOMAgent::setNodeValue):
(WebCore::InspectorDOMAgent::moveTo):
(WebCore::InspectorDOMAgent::buildObjectForNode):
(WebCore::InspectorDOMAgent::didPushShadowRoot):
(WebCore):
(WebCore::InspectorDOMAgent::willPopShadowRoot):
- inspector/InspectorDOMAgent.h:
(WebCore):
(InspectorDOMAgent):
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didPushShadowRootImpl):
(WebCore):
(WebCore::InspectorInstrumentation::willPopShadowRootImpl):
- inspector/InspectorInstrumentation.h:
(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didPushShadowRoot):
(WebCore::InspectorInstrumentation::willPopShadowRoot):
- inspector/PageConsoleAgent.cpp:
(WebCore::PageConsoleAgent::addInspectedNode):
- inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode):
(WebInspector.DOMNode.prototype.hasChildNodes):
(WebInspector.DOMNode.prototype.isInShadowTree):
(WebInspector.DOMNode.prototype._insertChild):
(WebInspector.DOMNode.prototype._setChildrenPayload):
(WebInspector.DOMDocument):
(WebInspector.DOMAgent.prototype._setDetachedRoot):
(WebInspector.DOMAgent.prototype._shadowRootPopped):
(WebInspector.DOMDispatcher.prototype.childNodeRemoved):
(WebInspector.DOMDispatcher.prototype.shadowRootPushed):
(WebInspector.DOMDispatcher.prototype.shadowRootPopped):
- inspector/front-end/ElementsTreeOutline.js:
- inspector/front-end/MemoryStatistics.js:
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
- inspector/front-end/inspector.css:
(.webkit-html-tag.shadow, .webkit-html-fragment.shadow):
LayoutTests: [Shadow]: Expose one ShadowRoot in the Elements panel
https://bugs.webkit.org/show_bug.cgi?id=78202
Reviewed by Yury Semikhatsky.
- inspector/console/console-dirxml-expected.txt:
- 7:13 AM Changeset in webkit [108992] by
-
- 1 edit4 deletes in trunk/LayoutTests
Web Inspector: drop protocol-level tests
https://bugs.webkit.org/show_bug.cgi?id=79671
Reviewed by Vsevolod Vlasov.
- inspector/protocol/console-agent-expected.txt: Removed.
- inspector/protocol/console-agent.html: Removed.
- inspector/protocol/runtime-agent-expected.txt: Removed.
- inspector/protocol/runtime-agent.html: Removed.
- 7:07 AM Changeset in webkit [108991] by
-
- 4 edits in trunk/Source/WebKit/efl
[EFL] Pairing up between evas_object_image_data_get and evas_object_image_data_set.
https://bugs.webkit.org/show_bug.cgi?id=79031
Patch by JungJik Lee <jungjik.lee@samsung.com> on 2012-02-27
Reviewed by Zoltan Herczeg.
- Get the pixel data when the cairo surface is created.
- evas_object_image_data_get increases the reference count and returns the image buffer pointer.
evas_object_image_data_set decreases the reference count and when the ref count become zero,
the function releases the cached image inside evas engine.
We should make a pair between evas_object_image_data_set/get to return evas resource.
- ewk/ewk_tiled_backing_store.h:
(_Ewk_Tile):
- ewk/ewk_tiled_model.cpp:
(tile_account):
(ewk_tile_new):
- ewk/ewk_view_tiled.cpp:
(_ewk_view_tiled_render_cb):
- 7:05 AM Changeset in webkit [108990] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [refactoring] remove dependencies from TimelinePanel from most of FormattedRecord
https://bugs.webkit.org/show_bug.cgi?id=79665
Reviewed by Pavel Feldman.
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyLocation):
(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyCallFrame):
(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyTopCallFrame):
(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyScriptLocation):
(WebInspector.TimelinePanel.PopupContentHelper):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):
- 6:56 AM Changeset in webkit [108989] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: reveal corresponding timeline record when user clicks on memory graph
https://bugs.webkit.org/show_bug.cgi?id=79669
When user clicks on DOM counter graph corresponding timeline record is
revealed in timelime grid and all its ancestors are expanded.
Reviewed by Pavel Feldman.
- inspector/front-end/MemoryStatistics.js:
(WebInspector.MemoryStatistics.prototype._onClick):
- inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane.prototype.update):
(WebInspector.HeapGraph.prototype.update):
(WebInspector.HeapGraph.prototype._clear):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype.revealRecordAt.recordFinder):
(WebInspector.TimelinePanel.prototype.revealRecordAt):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelinePanel.forAllRecords):
(WebInspector.TimelinePanel.FormattedRecord.prototype.containsTime):
- 6:46 AM QtWebKitBugs edited by
- Add the meta bug to fix crashes/assertions/timeouts (diff)
- 6:43 AM Changeset in webkit [108988] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed single line fix for r108983.
- inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.prototype.willHide):
- 6:41 AM QtWebKitBugs edited by
- Add the meta bug to fix regressions cause layout test failures (diff)
- 5:47 AM Changeset in webkit [108987] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: repaint counter graphs when timeline splitter moves
https://bugs.webkit.org/show_bug.cgi?id=79644
Immediately refresh timeline panel on splitter move.
Reviewed by Pavel Feldman.
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._splitterDragging):
- 5:14 AM Changeset in webkit [108986] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] Skip one more crashing test.
- platform/qt-5.0-wk2/Skipped:
- 4:28 AM Changeset in webkit [108985] by
-
- 7 edits in trunk
Unreviewed. Fix make distcheck.
Source/JavaScriptCore:
- GNUmakefile.list.am: Add missing files.
Source/WebCore:
- GNUmakefile.am: Add missing files.
- GNUmakefile.list.am: Ditto.
Tools:
- GNUmakefile.am: Fix typo.
- 4:04 AM Changeset in webkit [108984] by
-
- 2 edits in trunk/Source/WebCore
[CMake] Build fix after r108709.
- CMakeLists.txt: Move DOMWindowSVG.idl to the other IDL files.
- 3:56 AM Changeset in webkit [108983] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [chromium] Profiles - Tooltip with object/property types stays on screen when another tab selected
https://bugs.webkit.org/show_bug.cgi?id=79654
Reviewed by Yury Semikhatsky.
- inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.prototype.willHide):
- 3:38 AM Changeset in webkit [108982] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Remove page/PageSupplement.h from WebCore's Target.pri
The file itself was removed in r108958.
Reviewed by Kenneth Rohde Christiansen.
- 3:30 AM Changeset in webkit [108981] by
-
- 8 edits in trunk
[Qt] Use USE() macro instead of ENABLE() for using the Qt image decoder
Reviewed by Kenneth Rohde Christiansen.
- 3:13 AM Changeset in webkit [108980] by
-
- 7 edits2 adds in trunk
Source/WebCore: Removing <ul>, <li> inside shadow DOM triggers assertion in updateListMarkerNumbers
https://bugs.webkit.org/show_bug.cgi?id=79630
Reviewed by Ryosuke Niwa.
This problem was caused by the inconsistent detach order of DOM tree where
Element::detach() called ContainerNode::detach() before shadow tree is detached.
This resulted the renderer of the element being destroyed even if its children,
each of which came from an element in the shadow tree, are alive.
In principle, child renderers should be destroyed before its parent.
This change aligns the detach order with the attach order. The shadow tree is
now deatched before parent's ContainerNode::detach() is called.
Test: fast/dom/shadow/shadow-ul-li.html
- dom/Element.cpp:
(WebCore::Element::detach):
LayoutTests: Removing <ul>, <li> inside shadow DOM triggers assertion in updateListMarkerNumbers
https://bugs.webkit.org/show_bug.cgi?id=72440
Reviewed by Ryosuke Niwa.
- fast/dom/shadow/shadow-ul-li-expected.txt: Added.
- fast/dom/shadow/shadow-ul-li.html: Added.
- fast/dom/shadow/shadow-ul-li.html:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wk2/Skipped:
- 3:05 AM Changeset in webkit [108979] by
-
- 4 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/qt-5.0-wk1/Skipped: Skip a new timeouting test.
- platform/qt-5.0-wk2/Skipped: Skip a new _crashing_ test.
- platform/wk2/Skipped: Unskip non-existning tests, rename entries as real files renamed before.
- 2:42 AM Changeset in webkit [108978] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
Following tests are flaky:
- compositing/reflections/remove-add-reflection.html
- compositing/reflections/nested-reflection-transition.html
- platform/chromium/test_expectations.txt:
- 2:27 AM Changeset in webkit [108977] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, try to skip previous tests to avoid crashes.
- platform/qt/Skipped:
- 2:23 AM Changeset in webkit [108976] by
-
- 14 edits2 copies in trunk/Source/WebCore
Color input type should be clickable through keyboard
https://bugs.webkit.org/show_bug.cgi?id=79629
Reviewed by Kent Tamura.
Introduced BaseClickableWithKeyInputType that represents an input type
that can be clicked by pressing space/return keys.
ColorInputType, FileInputType directly inherit it because it doesn't
want the other methods(like appendFormData) in BaseButtonInputType.
- CMakeLists.txt: Added BaseClickableWithKeyInputType.cpp
- GNUmakefile.list.am: Added BaseClickableWithKeyInputType.{cpp,h}
- Target.pri: Added BaseClickableWithKeyInputType.{cpp,h}
- WebCore.gypi: Added BaseClickableWithKeyInputType.{cpp,h}
- WebCore.vcproj/WebCore.vcproj: Added BaseClickableWithKeyInputType.{cpp,h}
- WebCore.xcodeproj/project.pbxproj: Added BaseClickableWithKeyInputType.{cpp,h}
- html/BaseButtonInputType.cpp:
- html/BaseButtonInputType.h:
(WebCore::BaseButtonInputType::BaseButtonInputType): Inherits BaseClickableWithKeyInputType now.
(BaseButtonInputType):
- html/BaseCheckableInputType.cpp: Changed comment.
- html/BaseClickableWithKeyInputType.cpp:
(WebCore):
(WebCore::BaseClickableWithKeyInputType::handleKeydownEvent): Moved from BaseButtonInputType
(WebCore::BaseClickableWithKeyInputType::handleKeypressEvent): Moved from BaseButtonInputType
(WebCore::BaseClickableWithKeyInputType::handleKeyupEvent): Moved from BaseButtonInputType
(WebCore::BaseClickableWithKeyInputType::accessKeyAction): Moved from BaseButtonInputType
- html/BaseClickableWithKeyInputType.h:
(WebCore):
(BaseClickableWithKeyInputType): Input type that can be clicked by pressing space/return keys.
(WebCore::BaseClickableWithKeyInputType::BaseClickableWithKeyInputType):
- html/ColorInputType.h:
(WebCore::ColorInputType::ColorInputType): Inherits BaseClickableWithKeyInputType now.
- html/FileInputType.cpp:
(WebCore::FileInputType::FileInputType):
- html/FileInputType.h:
(FileInputType): Inherits BaseClickableWithKeyInputType now.
- html/RangeInputType.cpp: Changed comment.
(WebCore):
- 2:21 AM Changeset in webkit [108975] by
-
- 2 edits in trunk/Source/WebCore
Add missing include to ColorInputType.cpp
https://bugs.webkit.org/show_bug.cgi?id=79632
Reviewed by Kent Tamura.
- html/ColorInputType.cpp: Include ShadowTree.h
- 2:19 AM WebKitGTK/WebKit2Roadmap edited by
- Ad windowed plugins task (diff)
- 2:06 AM Changeset in webkit [108974] by
-
- 4 edits in trunk/Tools
Add a ChromiumGpuAndroid port.
https://bugs.webkit.org/show_bug.cgi?id=79628
Patch by Hao Zheng <zhenghao@chromium.org> on 2012-02-27
Reviewed by Adam Barth.
Android does have a gpu port, so revert r107697.
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.init):
- Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
(ChromiumGpuAndroidPort):
(ChromiumGpuAndroidPort.init):
(ChromiumGpuAndroidPort.baseline_search_path):
(ChromiumGpuAndroidPort.default_child_processes):
(ChromiumGpuAndroidPort.tests):
- Scripts/webkitpy/layout_tests/port/factory.py:
(PortFactory):
- 2:01 AM Changeset in webkit [108973] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
Following tests are flaky:
- compositing/reflections/reflection-ordering.html
- compositing/reflections/reflection-positioning.html
- compositing/reflections/nested-reflection-transformed.html
- compositing/reflections/nested-reflection-transformed2.html
- platform/chromium/test_expectations.txt:
- 1:44 AM Changeset in webkit [108972] by
-
- 2 edits in trunk/Source/WebCore
Use built-in bind in ExtensionAPI.js
Web Inspector: [Extensions API] get rid of custom bind() in favor of built-in
https://bugs.webkit.org/show_bug.cgi?id=79570
Reviewed by Pavel Feldman.
- inspector/front-end/ExtensionAPI.js:
(injectedExtensionAPI.EventSinkImpl.prototype.addListener):
(injectedExtensionAPI):
(injectedExtensionAPI.Panels.prototype.create):
(injectedExtensionAPI.AuditResultImpl):
(injectedExtensionAPI.ExtensionServerClient):
- 1:27 AM Changeset in webkit [108971] by
-
- 12 edits in trunk
Web Inspector: get rid of RawSourceCode.sourceMapping getter.
https://bugs.webkit.org/show_bug.cgi?id=79461
Reviewed by Yury Semikhatsky.
Source/WebCore:
- inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype.uiSourceCodeAdded):
(WebInspector.BreakpointManager.prototype.setBreakpoint):
(WebInspector.BreakpointManager.prototype._materializeBreakpoint):
(WebInspector.BreakpointManager.prototype._breakpointDebuggerLocationChanged):
- inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype.get location):
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.rawLocationToUILocation):
(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):
(WebInspector.DebuggerPresentationModel.prototype._handleUISourceCodeListChanged):
(WebInspector.DebuggerPresentationModel.prototype._uiSourceCodeListChanged):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype._restoreConsoleMessages):
(WebInspector.DebuggerPresentationModel.prototype._restoreExecutionLine):
(WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):
(WebInspector.DebuggerPresentationModel.prototype.continueToLine):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.PresentationCallFrame.prototype.uiLocation):
(WebInspector.DebuggerPresentationModel.CallFramePlacard):
(WebInspector.DebuggerPresentationModel.CallFramePlacard.prototype.discard):
(WebInspector.DebuggerPresentationModel.CallFramePlacard.prototype._update):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.setContent):
(WebInspector.DebuggerPresentationModel.DefaultLinkifierFormatter.prototype.formatRawSourceCodeAnchor):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyRawSourceCode):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.reset):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor):
- inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.prototype.uiSourceCodeList):
(WebInspector.RawSourceCode.prototype._saveSourceMapping):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._updateCallFrame):
- inspector/front-end/ScriptsSearchScope.js:
(WebInspector.ScriptsSearchResultsPane.prototype.createAnchor):
LayoutTests:
- inspector/debugger/breakpoint-manager.html:
- inspector/debugger/callstack-placards-discarded-expected.txt:
- inspector/debugger/callstack-placards-discarded.html:
- inspector/debugger/raw-source-code.html:
- 1:21 AM Changeset in webkit [108970] by
-
- 17 edits2 copies12 adds in trunk
[CSSRegions]Implement NamedFlow::getRegionsByContentNode
https://bugs.webkit.org/show_bug.cgi?id=77746
Reviewed by David Hyatt.
Source/WebCore:
Tests: fast/regions/get-regions-by-content-node-horiz-bt.html
fast/regions/get-regions-by-content-node-horiz-tb.html
fast/regions/get-regions-by-content-node-vert-lr.html
fast/regions/get-regions-by-content-node-vert-rl.html
fast/regions/get-regions-by-content-node.html
fast/regions/get-regions-by-content-node2.html
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/Node.cpp:
(WebCore::Node::removeCachedRegionNodeList):
(WebCore):
(WebCore::Node::getRegionsByContentNode):
(WebCore::NodeListsNodeData::invalidateCaches):
(WebCore::NodeListsNodeData::isEmpty):
- dom/Node.h:
(WebCore):
(Node):
- dom/NodeRareData.h:
(NodeListsNodeData):
- dom/RegionNodeList.cpp:
(WebCore):
(WebCore::RegionNodeList::RegionNodeList):
(WebCore::RegionNodeList::~RegionNodeList):
(WebCore::RegionNodeList::nodeMatches):
- dom/RegionNodeList.h:
(WebCore):
(RegionNodeList):
(WebCore::RegionNodeList::create):
- dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::getRegionsByContentNode):
(WebCore):
- dom/WebKitNamedFlow.h:
(WebCore):
(WebKitNamedFlow):
- dom/WebKitNamedFlow.idl:
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::regionInRange):
(WebCore):
(WebCore::RenderFlowThread::objectInFlowRegion):
- rendering/RenderFlowThread.h:
- rendering/RenderRegion.h:
(WebCore::RenderRegion::flowThread):
LayoutTests:
- fast/regions/get-regions-by-content-node-expected.txt: Added.
- fast/regions/get-regions-by-content-node-horiz-bt-expected.txt: Added.
- fast/regions/get-regions-by-content-node-horiz-bt.html: Added.
- fast/regions/get-regions-by-content-node-horiz-tb-expected.txt: Added.
- fast/regions/get-regions-by-content-node-horiz-tb.html: Added.
- fast/regions/get-regions-by-content-node-vert-lr-expected.txt: Added.
- fast/regions/get-regions-by-content-node-vert-lr.html: Added.
- fast/regions/get-regions-by-content-node-vert-rl-expected.txt: Added.
- fast/regions/get-regions-by-content-node-vert-rl.html: Added.
- fast/regions/get-regions-by-content-node.html: Added.
- fast/regions/get-regions-by-content-node2-expected.txt: Added.
- fast/regions/get-regions-by-content-node2.html: Added.
- 1:16 AM Changeset in webkit [108969] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectaion update.
- platform/chromium/test_expectations.txt: Changed expectation for http/tests/xmlhttprequest/xmlhttprequest-no-content-length-onProgress.html.
- 1:08 AM Changeset in webkit [108968] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=79642
Following tests time out:
- accessibility/aria-describedby-on-input.html
- fast/loader/subresource-willSendRequest-null.html
- http/tests/xmlhttprequest/xmlhttprequest-test-send-flag.html
- media/video-playbackrate.html
- platform/chromium/test_expectations.txt:
- 1:00 AM Changeset in webkit [108967] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: counter graphs should resize after console showing
https://bugs.webkit.org/show_bug.cgi?id=79640
Invoke Panel.doResize after showing drawer.
Reviewed by Pavel Feldman.
- inspector/front-end/Drawer.js:
(WebInspector.Drawer.prototype.show.animationFinished):
(WebInspector.Drawer.prototype.show):
- 12:51 AM Changeset in webkit [108966] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Close TabbedPanes on middle click of tab handle
https://bugs.webkit.org/show_bug.cgi?id=79518
Patch by Dan Beam <dbeam@chromium.org> on 2012-02-27
Reviewed by Pavel Feldman.
- inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPaneTab.prototype._createTabElement):
(WebInspector.TabbedPaneTab.prototype._tabClicked):
- 12:42 AM Changeset in webkit [108965] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: crash in fake workers
https://bugs.webkit.org/show_bug.cgi?id=79637
Notify front-end about worker creation/destruction synchronously instead of
posting a task.
Reviewed by Pavel Feldman.
- inspector/InspectorAgent.cpp:
(WebCore):
(WebCore::InspectorAgent::didCreateWorker):
(WebCore::InspectorAgent::didDestroyWorker):
- inspector/InspectorAgent.h:
(InspectorAgent):
- 12:40 AM Changeset in webkit [108964] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip the following crashing svg test.
- platform/qt/Skipped:
- 12:38 AM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 12:27 AM Changeset in webkit [108963] by
-
- 1 edit2 adds in trunk/Source/WebKit/blackberry
[BlackBerry] Upstream accelerated compositing helper class
https://bugs.webkit.org/show_bug.cgi?id=78448
Reviewed by Antonio Gomes.
Initial upstream, no new tests.
- WebKitSupport/FrameLayers.cpp: Added.
- WebKitSupport/FrameLayers.h: Added.
