Timeline


and

03/06/12:

23:54 Changeset [110028] by commit-queue@webkit.org
  • 5 edits in trunk

[EFL][DRT] Implements LayoutTestController's setPopupBlockingEnabled.
https://bugs.webkit.org/show_bug.cgi?id=80137

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2012-03-06
Reviewed by Eric Seidel.

Tools:

Adds implementation LayoutTestController's setPopupBlockingEnabled.
To pass popup-blocking-click-in-iframe.html EventSender should not
repeat click events in idler's function. EventSender allows to
asynchronously send click event through ecore_idler_add.
This event will be called repeatedly as long as it return true.
Click event should be called only once by returning ECORE_CALLBACK_CANCEL.

  • DumpRenderTree/efl/EventSender.cpp:

(sendMouseEvent): Changed return value from bool to void because it always returns true.
(sendClick): Idler is deleted by returning ECORE_CALLBACK_CANCEL.
(mouseDownCallback): Remove unnecessary checking of return value.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setPopupBlockingEnabled):

LayoutTests:

Enables tests connected with setPopupBlockingEnabled.

  • platform/efl/Skipped:
23:50 Changeset [110027] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update after r109934.

  • platform/gtk/test_expectations.txt:
23:48 Changeset [110026] by barraclough@apple.com
  • 11 edits in trunk

Array.prototype functions should throw if delete fails
https://bugs.webkit.org/show_bug.cgi?id=80467

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

All calls to Delete? from Array.prototype are specified to pass 'true' as the value of Throw.
In the case of shift/unshift, these are also missing a throw from the 'put' in the implementations
in JSArray.cpp. There are effectively three copies of each of the generic shift/unshift routines,
one in splice, one in ArrayPrototype's shift/unshift methods, and one in JSArray's shift/unshift
routines, for handling arrays with holes. These three copies should be unified.

  • runtime/ArrayPrototype.cpp:

(JSC::shift):
(JSC::unshift):

  • Added - shared copies of the shift/unshift functionality.

(JSC::arrayProtoFuncPop):

  • should throw if the delete fails.

(JSC::arrayProtoFuncReverse):

  • should throw if the delete fails.

(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):

  • use shift/unshift.
  • runtime/JSArray.cpp:

(JSC::JSArray::shiftCount):
(JSC::JSArray::unshiftCount):

  • Don't try to handle arrays with holes; return a value indicating the generic routine should be used instead.
  • runtime/JSArray.h:
    • declaration for shiftCount/unshiftCount changed.
  • tests/mozilla/js1_6/Array/regress-304828.js:
    • this was asserting incorrect behaviour.

LayoutTests:

  • fast/js/mozilla/strict/15.4.4.12-expected.txt:
  • fast/js/mozilla/strict/15.4.4.13-expected.txt:
  • fast/js/mozilla/strict/15.4.4.6-expected.txt:
  • fast/js/mozilla/strict/15.4.4.8-expected.txt:
  • fast/js/mozilla/strict/15.4.4.9-expected.txt:
    • check in passing test results.
23:46 Changeset [110025] by philn@webkit.org
  • 4 edits
    1 delete in trunk/LayoutTests

fullscreen/video-controls is too specific to the mac port
https://bugs.webkit.org/show_bug.cgi?id=73583

Reviewed by Eric Carlson.

Relax the test on the document's view height to not depend on the
mac port fullscreen controls stylesheet.

  • fullscreen/video-controls-override-expected.txt:
  • fullscreen/video-controls-override.html:
  • platform/gtk/Skipped:
23:37 Changeset [110024] by kubo@profusion.mobi
  • 10 edits in trunk

[CMake] Make the removal of transitive library dependencies work with CMake < 2.8.7.
https://bugs.webkit.org/show_bug.cgi?id=80469

Reviewed by Antonio Gomes.

.:

  • CMakeLists.txt: Do not set the CMAKE_LINK_INTERFACE_LIBRARIES

variable here; it was introduced in CMake 2.8.7 so we can't depend
on it as we actually support CMake >= 2.8.0.

Source/JavaScriptCore:

  • CMakeLists.txt: Manually set the LINK_INTERFACE_LIBRARIES target

property on the library being created.

Source/WebCore:

No new tests, this is a buildsystem change.

  • CMakeLists.txt: Manually set the LINK_INTERFACE_LIBRARIES target

property on the library being created.

Source/WebKit:

  • CMakeLists.txt: Manually set the LINK_INTERFACE_LIBRARIES target

property on the library being created.

Source/WebKit2:

  • CMakeLists.txt: Manually set the LINK_INTERFACE_LIBRARIES target

property on the library being created.

23:24 Changeset [110023] by commit-queue@webkit.org
  • 12 edits in trunk/Source

[BlackBerry] Set correct ResourceRequest target type.
https://bugs.webkit.org/show_bug.cgi?id=80430

Patch by Lianghui Chen <liachen@rim.com> on 2012-03-06
Reviewed by Rob Buis.

Source/WebCore:

For loads started by AppCache, they are based on the manifest file,
it is not definitely sure what target it is for, so we just guess
based on its mimetype or file extension.

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::createResourceHandle):

  • loader/cache/CachedResource.cpp:

(WebCore):
(WebCore::CachedResource::load):

  • platform/network/blackberry/ResourceRequest.h:

(ResourceRequest):

  • platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore):
(WebCore::mimeTypeRequestTypeMap):
(WebCore::ResourceRequest::targetTypeFromMimeType):

  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerScriptLoader::load):

  • workers/Worker.cpp:

(WebCore::Worker::create):

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::importScripts):

  • workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::createResourceRequest):

  • workers/WorkerScriptLoader.h:

(WorkerScriptLoader):

Source/WebKit/blackberry:

Removed unused code in dispatchWillSendRequest(). These codes are too
late as the target type has already been referred to when calling
ResourceRequest::initializePlatformRequest().

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):

23:19 Changeset [110022] by hayato@chromium.org
  • 5 edits
    1 add
    1 delete in trunk/LayoutTests

[Shadow DOM] Extend a 'path' notation in utility function so that we can specify arbitrary ShadowRoot.
https://bugs.webkit.org/show_bug.cgi?id=80405

Reviewed by Dimitri Glazkov.

Extract common utility function, getElementByIdInShadow(path), into a shadow-dom.js
(renamed from create-dom.js) and support 'consecutive slashes' notation so that
we can specify arbitrary ShadowRoot in shadow DOM tree. Until now, we can get an element
only from the youngest ShadowRoot.

  • fast/dom/shadow/access-key.html:
  • fast/dom/shadow/get-element-by-id-in-shadow-root-expected.txt:
  • fast/dom/shadow/get-element-by-id-in-shadow-root.html:
  • fast/dom/shadow/resources/shadow-dom.js: Renamed from LayoutTests/fast/dom/shadow/resources/create-dom.js.

(createShadowRoot):
(createDOM):
(isShadowRoot):
(getElementInShadowTreeStack):

  • fast/dom/shadow/shadow-boundary-events.html:
23:16 Changeset [110021] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations

  • platform/chromium/test_expectations.txt:
23:07 Changeset [110020] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[chromium] Add clipping to scissor rect to CCOcclusionTracker
https://bugs.webkit.org/show_bug.cgi?id=79927

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-06
Reviewed by Adrienne Walker.

Source/WebCore:

Adds logic to CCOcclusionTracker to occlude anything outside of the
current screen and target surface scissor rects. When tracking
damage for partial swaps, the scissor rects are bounded by the
tracked damage rects.

Unit tests: CCOcclusionTrackerTest.cpp

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::CCOcclusionTrackerBase):
(WebCore):
(WebCore::::markOccludedBehindLayer):
(WebCore::testContentRectOccluded):
(WebCore::::occluded):
(WebCore::computeUnoccludedContentRect):
(WebCore::::unoccludedContentRect):
(WebCore::::layerScissorRect):

  • platform/graphics/chromium/cc/CCOcclusionTracker.h:

(WebCore):
(CCOcclusionTrackerDamageClientBase):
(CCOcclusionTrackerBase):

Source/WebKit/chromium:

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore::TestCCOcclusionTracker::TestCCOcclusionTracker):
(TestCCOcclusionTracker):
(WebCore::TestCCOcclusionTracker::setLayerScissorRect):
(WebCore::TestCCOcclusionTracker::useDefaultLayerScissorRect):
(WebCore::TestCCOcclusionTracker::layerScissorRect):
(WebCore):
(TestDamageClient):
(WebCore::TestDamageClient::damageRect):
(WebCore::TestDamageClient::TestDamageClient):
(WebCore::TestDamageClient::setDamageRect):
(WebCore::TEST):

22:35 Changeset [110019] by haraken@chromium.org
  • 6 edits in trunk/Source/WebCore

Unreviewed, rolling out r110011.
http://trac.webkit.org/changeset/110011
https://bugs.webkit.org/show_bug.cgi?id=80376

layout tests crash

  • bindings/v8/V8HiddenPropertyName.cpp:

(WebCore):
(WebCore::V8HiddenPropertyName::hiddenReferenceName):

  • bindings/v8/V8HiddenPropertyName.h:

(WebCore):
(V8HiddenPropertyName):

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8DOMTokenListCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:

(WebCore::toV8):

22:33 Changeset [110018] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r110016.
http://trac.webkit.org/changeset/110016

layout tests crash

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:

(WebCore::toV8):

22:19 Changeset [110017] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, fix lint error

  • platform/chromium/test_expectations.txt:
22:05 Changeset [110016] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, fixed test crashes.

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:

(WebCore::toV8):

21:39 Changeset [110015] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectation.

  • platform/chromium/test_expectations.txt: update svg/W3C-SVG-1.1/animate-elem-77-t.svg
21:29 Changeset [110014] by commit-queue@webkit.org
  • 13 edits
    2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=79935
REGRESSION: <content> element is not HTMLUnknownElement when Shadow DOM API is disabled

Patch by Hajime Morrita <morrita@chromium.org> on 2012-03-06
Reviewed by Adam Barth.

.:

Added a newly exported symbol.

  • Source/autotools/symbols.filter:

Source/WebCore:

This change introduced "runtimeConditional" keyword to make_name.pl sources,
which allows HTMLElementFactory and HTMLElementWrapperFactory to check RuntimeEnabledFeatures
and treat any tag name as HTMLUnknownElement if its definition has runtimeConditional and
the flag given is turned off.

Test: fast/dom/shadow/content-shadow-unknown.html

  • WebCore.exp.in:
  • dom/make_names.pl:

(defaultTagPropertyHash):
(printConstructorInterior):
(printFactoryCppFile):
(printWrapperFunctions):
(printWrapperFactoryCppFile):

  • html/HTMLTagNames.in:
  • html/shadow/HTMLContentElement.cpp:

(WebCore::contentTagName):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::restoreTo):
(WebCore::InternalSettings::setShadowDOMEnabled):
(WebCore):

  • testing/InternalSettings.h:

(InternalSettings):

  • testing/InternalSettings.idl:

LayoutTests:

  • fast/dom/resources/shadow-test-driver.js:

(createContentWithText):

  • fast/dom/shadow/content-element-move.html: Replaced accidentaly used <content> using an Internals API.
  • fast/dom/shadow/content-shadow-unknown-expected.txt: Added.
  • fast/dom/shadow/content-shadow-unknown.html: Added.
21:25 Changeset [110013] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectation.

  • platform/chromium/test_expectations.txt:
21:13 Changeset [110012] by bashi@chromium.org
  • 11 edits in trunk/Source

[WebSocket] Introduce ThreadableWebSocketChannel::SendResult
https://bugs.webkit.org/show_bug.cgi?id=80356

Reviewed by Kent Tamura.

Source/WebCore:

Introduced ThreadableWebSocketChannel::SendResult type so that
WebSocketChannel can pass the validation result.

No new test. No changes in behavior.

  • Modules/websockets/ThreadableWebSocketChannel.h: Added SendResult.
  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
(WebCore::ThreadableWebSocketChannelClientWrapper::sendRequestResult): Use ThreadableWebSocketChannel::SendResult instead of bool.
(WebCore::ThreadableWebSocketChannelClientWrapper::setSendRequestResult): Ditto.

  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:

(ThreadableWebSocketChannelClientWrapper):

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::send): Use ThreadableWebSocketChannel::SendResult instead of bool. Pass Cstring to enqueTextFrame instead of String.
(WebCore::WebSocketChannel::enqueueTextFrame): Ditto.
(WebCore::WebSocketChannel::processOutgoingFrameQueue): Ditto.

  • Modules/websockets/WebSocketChannel.h:

(WebSocketChannel):
(QueuedFrame): Changed the type of stringData from String to CString.

  • Modules/websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::send): Use ThreadableWebSocketChannel::SendResult instead of bool.
(WebCore::workerContextDidSend): Ditto.
(WebCore::WorkerThreadableWebSocketChannel::Peer::send): Ditto.
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send): Ditto.

  • Modules/websockets/WorkerThreadableWebSocketChannel.h:

(WorkerThreadableWebSocketChannel): ditto.
(Bridge): Ditto.

Source/WebKit/chromium:

  • src/WebSocketImpl.cpp:

(WebKit::WebSocketImpl::sendText): Checks whether the return value of send() is ThreadableWebSocketChannel::SendSuccess.
(WebKit::WebSocketImpl::sendArrayBuffer): Ditto.

21:05 Changeset [110011] by haraken@chromium.org
  • 6 edits in trunk/Source/WebCore

[V8][Performance] Optimize V8 bindings for HTMLElement.classList,
Element.dataset and Node.attributes
https://bugs.webkit.org/show_bug.cgi?id=80376

Reviewed by Adam Barth.

This patch improves the performance of HTMLElement.classList, Element.dataset
and Node.attributes by 6.4 times, 7.1 times and 10.9 times, respectively.

Previously, a 'hiddenReferenceName' string was allocated on v8::Handle and
created every time the DOM attribute is accessed, in spite of the fact that
the 'hiddenReferenceName' string is static.

This patch moves the 'hiddenReferenceName' string to v8::Persistent and makes it static.
Also, this patch removes 'if (!elementValue.IsEmpty() && elementValue->IsObject())',
since if 'element' exists, it is guaranteed that 'elementValue' is not empty
and is an Object.

Performance tests: https://bugs.webkit.org/attachment.cgi?id=130283

AppleWebKit/JavaScriptCore:
div.classList : 382ms
div.classList.foo = 123 : 335ms
div.dataset : 403ms
div.dataset.foo = 123 : 5250ms
div.attributes : 183ms

Chromium/V8 (without this patch):
div.classList : 9140ms
div.classList.foo = 123 : 9086ms
div.dataset : 9930ms
div.dataset.foo = 123 : 49698ms
div.attributes : 13489ms

Chromium/V8 (with this patch):
div.classList : 1435ms
div.classList.foo = 123 : 1470ms
div.dataset : 1400ms
div.dataset.foo = 123 : 30396ms
div.attributes : 1242ms

No tests. No change in behavior.

  • bindings/v8/custom/V8DOMStringMapCustom.cpp: Modified as described above.

(WebCore::toV8):

  • bindings/v8/custom/V8DOMTokenListCustom.cpp: Ditto.

(WebCore::toV8):

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp: Ditto.

(WebCore::toV8):

  • bindings/v8/V8HiddenPropertyName.cpp: Defined a hidden property name string statically

to optimize the macro.
(WebCore):
(WebCore::V8HiddenPropertyName::hiddenReferenceName):

  • bindings/v8/V8HiddenPropertyName.h: Modified to switch two prefixes "WebCore::HiddenProperty::"

and "WebCore::HiddenReference::", depending on whether a given name represents a hidden property
or a hidden reference.
(WebCore):
(V8HiddenPropertyName):

20:58 Changeset [110010] by nduca@chromium.org
  • 25 edits in trunk/Source

[chromium] CCThreadProxy context lost support
https://bugs.webkit.org/show_bug.cgi?id=80100

Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::didLoseContext):
(WebCore):
(WebCore::CCScheduler::didRecreateContext):
(WebCore::CCScheduler::processScheduledActions):

  • platform/graphics/chromium/cc/CCScheduler.h:

(CCSchedulerClient):
(CCScheduler):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::nextAction):
(WebCore::CCSchedulerStateMachine::updateState):
(WebCore::CCSchedulerStateMachine::vsyncCallbackNeeded):
(WebCore::CCSchedulerStateMachine::didLoseContext):
(WebCore):
(WebCore::CCSchedulerStateMachine::didRecreateContext):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.h:

(CCSchedulerStateMachine):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::recreateContext):
(WebCore::CCThreadProxy::loseContext):
(WebCore::CCThreadProxy::scheduledActionBeginContextRecreation):
(WebCore):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwap):
(WebCore::CCThreadProxy::setAnimationEvents):
(WebCore::CCThreadProxy::beginContextRecreation):
(WebCore::CCThreadProxy::recreateContextOnImplThread):
(WebCore::CCThreadProxy::loseContextOnImplThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

  • tests/CCSchedulerStateMachineTest.cpp:
  • tests/CCSchedulerTest.cpp:

(WebKitTests::FakeCCSchedulerClient::scheduledActionBeginContextRecreation):
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::scheduledActionBeginContextRecreation):
(WebKitTests::SchedulerClientThatSetNeedsCommitInsideDraw::scheduledActionBeginContextRecreation):

20:56 Changeset [110009] by haraken@chromium.org
  • 2 edits in trunk/PerformanceTests

[Perf tests] Reduce the number of loops in dom-attributes.html
https://bugs.webkit.org/show_bug.cgi?id=80077

Reviewed by Ryosuke Niwa.

dom-attributes.html takes 100~ seconds in the perf bots. This patch reduces
the time by reducing the number of loops.

This is just a temporary fix. After more detailed investigation, I will reduce
the number of tests in dom-attributes.html, and revert back the number of loops
to guarantee the reliability of the perf test results.

  • Bindings/dom-attributes.html:
20:56 Changeset [110008] by yuqiang.xian@intel.com
  • 8 edits in trunk/Source/JavaScriptCore

DFG BasicBlock should group the Phi nodes together and separate them
from the other nodes
https://bugs.webkit.org/show_bug.cgi?id=80361

Reviewed by Filip Pizlo.

This would make it more efficient to remove the redundant Phi nodes or
insert new Phi nodes for SSA, besides providing a cleaner BasicBlock structure.
This is performance neutral on SunSpider, V8 and Kraken.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::clobberStructures):
(JSC::DFG::AbstractState::dump):

  • dfg/DFGBasicBlock.h:

(JSC::DFG::BasicBlock::BasicBlock):
(BasicBlock):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addToGraph):
(JSC::DFG::ByteCodeParser::insertPhiNode):

  • dfg/DFGCFAPhase.cpp:

(JSC::DFG::CFAPhase::performBlockCFA):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::pureCSE):
(JSC::DFG::CSEPhase::impureCSE):
(JSC::DFG::CSEPhase::globalVarLoadElimination):
(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::checkFunctionElimination):
(JSC::DFG::CSEPhase::checkStructureLoadElimination):
(JSC::DFG::CSEPhase::getByOffsetLoadElimination):
(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::getScopeChainLoadElimination):
(JSC::DFG::CSEPhase::performBlockCSE):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

20:39 Changeset [110007] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

refactor method names in RenderFlexibleBox to make them more consistent
https://bugs.webkit.org/show_bug.cgi?id=80446

Reviewed by Ojan Vafai.

No new tests, just renaming internal methods.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::flowAwareBorderAfter): New, used by layoutAndPlaceChildren
(WebCore::RenderFlexibleBox::flowAwarePaddingAfter): New, used by layoutAndPlaceChildren
(WebCore::RenderFlexibleBox::marginBoxAscentForChild): Add ForChild for consistency.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): We were adding the before padding+border twice (it's in the offset and
crossAxisBorderAndPaddingExtent() and subtracting it once. Instead, just add the after padding+border.
(WebCore::RenderFlexibleBox::alignChildren):

  • rendering/RenderFlexibleBox.h:

(RenderFlexibleBox): Reorder methods to match the .cpp file.

20:07 Changeset [110006] by mrobinson@webkit.org
  • 3 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk

Merging r110002

20:03 Changeset [110005] by mrobinson@webkit.org
  • 4 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk

Merging r109997

19:58 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
19:53 Changeset [110004] by haraken@chromium.org
  • 6 edits in trunk/Source/WebCore

Unreviewed, rolling out r109969.
http://trac.webkit.org/changeset/109969
https://bugs.webkit.org/show_bug.cgi?id=80376

layout tests crash

  • bindings/v8/V8HiddenPropertyName.cpp:

(WebCore):
(WebCore::V8HiddenPropertyName::hiddenReferenceName):

  • bindings/v8/V8HiddenPropertyName.h:

(WebCore):
(V8HiddenPropertyName):

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8DOMTokenListCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:

(WebCore::toV8):

19:52 Changeset [110003] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r109999.
http://trac.webkit.org/changeset/109999

layout tests crash

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8DOMTokenListCustom.cpp:

(WebCore::toV8):

19:50 Changeset [110002] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

Fix a compilation warning encountered during the GTK+ build.

Reviewed by Gustavo Noronha Silva.

  • tests/testcopyandpaste.c:

(test_copy_and_paste): Cast the WebKitWebView to a GtkWidget.

19:26 Changeset [110001] by enne@google.com
  • 7 edits in trunk/LayoutTests

Unreviewed, update mac text baselines after r109851

  • compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
  • compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
  • compositing/geometry/limit-layer-bounds-positioned-expected.txt:
  • compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
  • compositing/geometry/limit-layer-bounds-transformed-expected.txt:
  • compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
18:47 Changeset [110000] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Remove the no-longer-needed 'CPU' and 'GPU' modifiers.

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
18:45 Changeset [109999] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, fix crashes.

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8DOMTokenListCustom.cpp:

(WebCore::toV8):

18:40 Changeset [109998] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Re-sort the platform/chromium/virtual/gpu expectations next to the original expectations.

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
18:40 Changeset [109997] by mrobinson@webkit.org
  • 4 edits in trunk/Source/WebKit/gtk

[GTK] FrameLoader signals: gtk-doc fixes
https://bugs.webkit.org/show_bug.cgi?id=79495

Patch by Philippe Normand <pnormand@igalia.com> on 2012-03-06
Reviewed by Martin Robinson.

  • webkit/webkitwebframe.cpp:

(webkit_web_frame_class_init):

  • webkit/webkitwebresource.cpp:

(webkit_web_resource_class_init):

  • webkit/webkitwebview.cpp:

(webkit_web_view_class_init):

18:22 Changeset [109996] by dpranke@chromium.org
  • 1 edit
    3 deletes in trunk/Tools

rebaseline_chromium_webkit_tests is obsolete and should be removed
https://bugs.webkit.org/show_bug.cgi?id=80347

Reviewed by Tony Chang.

  • Scripts/rebaseline-chromium-webkit-tests: Removed.
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py: Removed.
  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py: Removed.
18:20 Changeset [109995] by dpranke@chromium.org
  • 2 edits in trunk/Tools

test_start_cmd (webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer) is broken
https://bugs.webkit.org/show_bug.cgi?id=80468

Unreviewed, build fix.

Fixing a bug revealed by r80443 when we fixed filesystem.copyfile().

  • Scripts/webkitpy/layout_tests/servers/http_server.py:

(Lighttpd._prepare_config):

18:17 Changeset [109994] by dpranke@chromium.org
  • 6 edits
    2 deletes in trunk/Tools

remove chromium_gpu ports
https://bugs.webkit.org/show_bug.cgi?id=80345

Reviewed by Ojan Vafai.

This change leaves in the 'graphics_type' distinction in the
test_expectations; removing that will require more updates and a
pass over test_expectations.txt, so I'm separating that out.

  • Scripts/webkitpy/layout_tests/port/builders.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort):

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py: Removed.
  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/port/factory.py:

(PortFactory):
(PortFactory.get):

  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:

(FactoryTest.test_qt):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaseline.test_rebaseline_expectations):

18:13 Changeset [109993] by jamesr@google.com
  • 3 edits in trunk/Source/WebCore

[chromium] Fix threaded compositing issues in WebGLLayerChromium (except for printing)
https://bugs.webkit.org/show_bug.cgi?id=80459

Reviewed by Kenneth Russell.

This fixes a few wrong-thread issues in WebGLLayerChromium for threaded compositing. The key requirements that
threaded compositing imposes on LayerChromium subclasses are that the compositor's context can only be used from
the compositor thread, meaning inside of updateCompositorResources() and pushPropertiesTo(), and that
non-compositor contexts can only be used from the main thread. This means specifically that we can't use the
DrawingBuffer's context in either of these two functions.

Summary of changes:
*) Move the publishToPlatformLayer() call and related logic inside of paintContentsIfDirty(), which is called
on the main thread.
*) Move lost context tracking outside of drawsContent(), since that function is called from both threads, to a
separate bool that is updated after each WebGL composite and setDrawingBuffer call.

Printing still doesn't work in threaded mode with this patch, I'll address that separately. Printing and lost
context recovery still work as they did in the single-threaded path.

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::WebGLLayerChromium):
(WebCore::WebGLLayerChromium::drawsContent):
(WebCore::WebGLLayerChromium::paintContentsIfDirty):
(WebCore::WebGLLayerChromium::updateCompositorResources):
(WebCore::WebGLLayerChromium::setDrawingBuffer):

  • platform/graphics/chromium/WebGLLayerChromium.h:

(WebGLLayerChromium):

18:04 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
17:58 Changeset [109992] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Cracks between tiles when zoomed in
https://bugs.webkit.org/show_bug.cgi?id=80460
<rdar://problem/10996688>

Use enclosingIntRect instead of enclosedIntRect when converting from FloatRect to IntRect.

  • platform/graphics/mac/WebLayer.mm:

(drawLayerContents):

17:45 Changeset [109991] by vangelis@chromium.org
  • 8 edits
    6 copies in branches/chromium/1025

Merge 109104 - Percent width/height SVG not always scaled on window resize
https://bugs.webkit.org/show_bug.cgi?id=79490

Patch by Florin Malita <fmalita@google.com> on 2012-02-28
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Tests: fast/repaint/percent-minheight-resize-expected.html

fast/repaint/percent-minheight-resize.html
svg/custom/svg-percent-scale-expected.html
svg/custom/svg-percent-scale-vonly-expected.html
svg/custom/svg-percent-scale-vonly.html
svg/custom/svg-percent-scale.html

Fix a couple of problems preventing correct SVG scaling on window resize:

  • RenderReplaced::computePreferredLogicalWidths is not SVG attribute aware and computes

a non-zero m_minPreferredLogicalWidth even when the SVG widh/height are percentages.

  • RenderBlock::layoutInlineChildren is also not SVG attribute aware and does not trigger

percent height child layouts on vertical-only resizes.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):
Use hasRelativeDimensions() instead of direct width/height->isPercent tests. This also fixes
an HTML issue where percent {min,max}Height inline elements are not updated on vertical-only resizes.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::hasRelativeDimensions):
(WebCore):

  • rendering/RenderBox.h:

(RenderBox):
Add virtual hasRelativeDimensions() method.

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computePreferredLogicalWidths):
Use hasRelativeDimensions() instead of direct width/height->isPercent tests.

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):
(WebCore::RenderSVGRoot::willBeDestroyed):
Register percent-height SVG elements with the gPercentHeightDescendantsMap, and clean-up on destruction
or height unit change.

(WebCore::RenderSVGRoot::hasRelativeDimensions):
(WebCore):

  • rendering/svg/RenderSVGRoot.h:

(RenderSVGRoot):
SVG-aware hasRelativeDimensions() override.

LayoutTests:

  • fast/repaint/percent-minheight-resize-expected.html: Added.
  • fast/repaint/percent-minheight-resize.html: Added.
  • svg/custom/svg-percent-scale-expected.html: Added.
  • svg/custom/svg-percent-scale-vonly-expected.html: Added.
  • svg/custom/svg-percent-scale-vonly.html: Added.
  • svg/custom/svg-percent-scale.html: Added.

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9617034

17:43 Changeset [109990] by cevans@google.com
  • 1 edit
    3 copies in branches/chromium/1025

Merge 107519
BUG=113837
Review URL: https://chromiumcodereview.appspot.com/9617035

17:35 Changeset [109989] by cevans@google.com
  • 1 edit in branches/chromium/1025/Source/WebCore/css/CSSParser.cpp

Merge 107999
BUG=113730
Review URL: https://chromiumcodereview.appspot.com/9615047

17:33 Changeset [109988] by vangelis@chromium.org
  • 2 edits in branches/chromium/1025/Source/WebCore

Merge 109973 - [chromium] Increase the accelerated canvas min size to 256 * 256
https://bugs.webkit.org/show_bug.cgi?id=80451

Reviewed by Stephen White.

Test: Manually

  • page/Settings.cpp:

(WebCore::Settings::Settings):

TBR=vangelis@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9618044

17:32 Changeset [109987] by cevans@google.com
  • 5 edits
    2 copies in branches/chromium/1025

Merge 107622
BUG=113567
Review URL: https://chromiumcodereview.appspot.com/9546037

17:25 Changeset [109986] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Tile cache layers should always be clipped to the view's bounds
https://bugs.webkit.org/show_bug.cgi?id=80456
<rdar://problem/10996174>

Reviewed by Simon Fraser.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::shouldClipCompositedBounds):
Factor this code out into a separate function for better clarity. Always return true if we have a tile cache layer.

(WebCore::RenderLayerBacking::updateCompositedBounds):
Call shouldClipCompositedBounds directly.

17:16 Changeset [109985] by jamesr@google.com
  • 4 edits in trunk/Source

[chromium] Null-check m_layerRenderer in CCLayerTreeHostImpl::finishAllRendering()
https://bugs.webkit.org/show_bug.cgi?id=80445

Reviewed by Adrienne Walker.

Source/WebCore:

Null-check CCLayerTreeHostImpl::m_layerRenderer since it won't be set if context initialiation failed for any
reason.

Covered by new unit test in CCLayerTreeHostImplTest.

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::finishAllRendering):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:

(FakeWebGraphicsContext3DMakeCurrentFails):
(WebKit::FakeWebGraphicsContext3DMakeCurrentFails::makeContextCurrent):
(WebKit):
(WebKit::TEST_F):

17:13 Changeset [109984] by rniwa@webkit.org
  • 5 edits in trunk

Can't select a line of RTL text on Facebook
https://bugs.webkit.org/show_bug.cgi?id=59435

Reviewed by Eric Seidel.

Source/WebCore:

Deploy prevLeafChildIgnoringLineBreak and nextLeafChildIgnoringLineBreak
in RenderedPosition::leftBoundaryOfBidiRun and RenderedPosition::rightBoundaryOfBidiRun.

Without this patch, WebKit extends selection from right to left when the user selects
<span dir="rtl">ABC<br></span> from left to right by a mouse drag.

Test: editing/selection/select-bidi-run.html

  • editing/RenderedPosition.cpp:

(WebCore::RenderedPosition::leftBoundaryOfBidiRun):
(WebCore::RenderedPosition::rightBoundaryOfBidiRun):

LayoutTests:

Added a regression test case.

  • editing/selection/select-bidi-run-expected.txt:
  • editing/selection/select-bidi-run.html:
17:11 Changeset [109983] by kubo@profusion.mobi
  • 7 edits in trunk

undefined reference to JSC::IdentifierTable::~IdentifierTable() on EFL port
https://bugs.webkit.org/show_bug.cgi?id=80282

Reviewed by Antonio Gomes.

.:

Remove transitive library dependencies; they are especially
dangerous when one ends up linking against WTF, JSC and then WTF
again, since some symbols will not be defined.

Passing --no-copy-dt-needed-entries and --as-needed to the linker
(which some recent Linux distros do by default) makes the issue
even more evident.

  • CMakeLists.txt: Set CMAKE_LINK_INTERFACE_LIBRARIES to an empty

list to prevent implicit transitive library dependencies from
being created by default.

Source/WebCore:

No new tests, this is a buildsystem change.

Remove transitive library dependencies; they are especially
dangerous when one ends up linking against WTF, JSC and then WTF
again, since some symbols will not be defined.

Passing --no-copy-dt-needed-entries and --as-needed to the linker
(which some recent Linux distros do by default) makes the issue
even more evident.

  • CMakeLists.txt: Explicitly link to WTF as WebCore uses symbols

from it.

  • PlatformEfl.cmake: Explicitly link against libjpeg and libpng.

Tools:

Remove transitive library dependencies; they are especially
dangerous when one ends up linking against WTF, JSC and then WTF
again, since some symbols will not be defined.

Passing --no-copy-dt-needed-entries and --as-needed to the linker
(which some recent Linux distros do by default) makes the issue
even more evident.

  • DumpRenderTree/efl/CMakeLists.txt: Do not link directly to WTF,

as the other libraries have the needed symbols. Explicitly link
against fontconfig.

17:08 Changeset [109982] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] REGRESSION(109469): WebGL printing busted
https://bugs.webkit.org/show_bug.cgi?id=80450

Reviewed by Kenneth Russell.

Avoid marking layers as needing display in setContentsTo...() since this breaks WebGL's damage tracking and is
unnecessary.

Tested WebGL printing manually.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setContentsToCanvas):
(WebCore::GraphicsLayerChromium::setContentsToMedia):

17:05 Changeset [109981] by enne@google.com
  • 3 edits
    2 adds in trunk

Overlap map for compositing should ignore empty layers
https://bugs.webkit.org/show_bug.cgi?id=63499

Reviewed by Simon Fraser.

Source/WebCore:

Test: compositing/layer-creation/overlap-empty-layer.html

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::addToOverlapMap):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):

LayoutTests:

  • compositing/layer-creation/overlap-empty-layer-expected.txt: Added.
  • compositing/layer-creation/overlap-empty-layer.html: Added.
17:02 Changeset [109980] by tkent@chromium.org
  • 9 edits in trunk/LayoutTests

[Chromium] Rebaseline of input-appearance-numberandspeech.html for r109876.
https://bugs.webkit.org/show_bug.cgi?id=78326

  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium/test_expectations.txt:
16:59 Changeset [109979] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] More test_expectations updates after the svg <use> change.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
16:45 Changeset [109978] by eae@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderThemeSafari.h

Fix typo in RenderThemeSafari.

16:42 Changeset [109977] by leviw@chromium.org
  • 37 edits in branches/subpixellayout/LayoutTests/platform/mac/mathml/presentation

Updating mac mathml expected results for our branch.

16:36 Changeset [109976] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp

Fixing MathML sub/sup layout, which corrects many subpixel rendering changes.

16:33 Changeset [109975] by dino@apple.com
  • 2 edits in trunk/Tools

filter-build-webkit needs more filters
https://bugs.webkit.org/show_bug.cgi?id=80440

Reviewed by Joseph Pecoraro.

Added as many missing filters as I could find for Apple
builds. Plus a few minor style updates.

  • Scripts/filter-build-webkit:

(printLine):

16:24 Changeset [109974] by eae@chromium.org
  • 7 edits in branches/subpixellayout/Source/WebCore/platform

Platform LayoutUnit/int fixes for subpixel branch.

16:16 Changeset [109973] by vangelis@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Increase the accelerated canvas min size to 256 * 256
https://bugs.webkit.org/show_bug.cgi?id=80451

Reviewed by Stephen White.

Test: Manually

  • page/Settings.cpp:

(WebCore::Settings::Settings):

16:12 Changeset [109972] by senorblanco@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

[chromium] Unreviewed gardening.

New text results for css3 filters tests.

  • platform/chromium-mac/css3/filters: Added.
  • platform/chromium-mac/css3/filters/composited-during-animation-layertree-expected.txt: Added.
  • platform/chromium-win/css3/filters/composited-during-animation-layertree-expected.txt: Added.
16:08 Changeset [109971] by leviw@chromium.org
  • 2 edits in branches/subpixellayout/Source/WebCore/rendering

Reverting LineWidth left and right to int, and fixing flex-hang by ignoring remaining space that's less than a pixel.

16:07 Changeset [109970] by eae@chromium.org
  • 39 edits in branches/subpixellayout/Source/WebCore

Change baselinePosition and InlineFlowBox::placeBoxesInBlockDirection on subpixel branch to use LayoutUnits for calculations.

15:54 Changeset [109969] by haraken@chromium.org
  • 6 edits in trunk/Source/WebCore

[V8][Performance] Optimize V8 bindings for HTMLElement.classList,
Element.dataset and Node.attributes
https://bugs.webkit.org/show_bug.cgi?id=80376

Reviewed by Adam Barth.

This patch improves the performance of HTMLElement.classList, Element.dataset
and Node.attributes by 6.4 times, 7.1 times and 10.9 times, respectively.

Previously, a 'hiddenReferenceName' string was allocated on v8::Handle and
created every time the DOM attribute is accessed, in spite of the fact that
the 'hiddenReferenceName' string is static.

This patch moves the 'hiddenReferenceName' string to v8::Persistent and makes it static.
Also, this patch removes 'if (!elementValue.IsEmpty() && elementValue->IsObject())',
since if 'element' exists, it is guaranteed that 'elementValue' is not empty
and is an Object.

Performance tests: https://bugs.webkit.org/attachment.cgi?id=130283

AppleWebKit/JavaScriptCore:
div.classList : 382ms
div.classList.foo = 123 : 335ms
div.dataset : 403ms
div.dataset.foo = 123 : 5250ms
div.attributes : 183ms

Chromium/V8 (without this patch):
div.classList : 9140ms
div.classList.foo = 123 : 9086ms
div.dataset : 9930ms
div.dataset.foo = 123 : 49698ms
div.attributes : 13489ms

Chromium/V8 (with this patch):
div.classList : 1435ms
div.classList.foo = 123 : 1470ms
div.dataset : 1400ms
div.dataset.foo = 123 : 30396ms
div.attributes : 1242ms

No tests. No change in behavior.

  • bindings/v8/custom/V8DOMStringMapCustom.cpp: Modified as described above.

(WebCore::toV8):

  • bindings/v8/custom/V8DOMTokenListCustom.cpp: Ditto.

(WebCore::toV8):

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp: Ditto.

(WebCore::toV8):

  • bindings/v8/V8HiddenPropertyName.cpp: Defined a hidden property name string statically

to optimize the macro.
(WebCore):
(WebCore::V8HiddenPropertyName::hiddenReferenceName):

  • bindings/v8/V8HiddenPropertyName.h: Modified to switch two prefixes "WebCore::HiddenProperty::"

and "WebCore::HiddenReference::", depending on whether a given name represents a hidden property
or a hidden reference.
(WebCore):
(V8HiddenPropertyName):

15:52 Changeset [109968] by alexis.menard@openbossa.org
  • 5 edits in trunk

getComputedStyle returns incorrect values for the width and height of pseudo-elements
https://bugs.webkit.org/show_bug.cgi?id=37835

Reviewed by Tony Chang.

Source/WebCore:

In case we are querying the computed style of an element with a pseudo-element we can't use
the renderer of the element as this one is not the one used to render the pseudo-element. We need
to use the one created to render the pseudo-element.

No new tests : Extend the existing getComputedStyle-with-pseudo-element.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Extend existing test to cover the bug.

  • fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt:
  • fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html:
15:50 Changeset [109967] by dglazkov@chromium.org
  • 2 edits in trunk/LayoutTests

REGRESSION(r109191): Shadow DOM tests stopped running on ports that do not have SHADOW_DOM flag enabled.
https://bugs.webkit.org/show_bug.cgi?id=80449

Reviewed by Ryosuke Niwa.

  • fast/dom/shadow/resources/create-dom.js:

(createDOM): Fixed a typo.

15:35 Changeset [109966] by senorblanco@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

[chromium] Unreviewed gardening.

  • platform/chromium-mac-snowleopard/css3/filters/composited-during-transition-layertree-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/css/circle-in-mask-with-shadow-expected.png: Added.
  • platform/chromium-win/css3/filters/composited-during-transition-layertree-expected.txt: Added.
15:09 Changeset [109965] by shawnsingh@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Make compositeAndReadback and damage tracking play nicely together
https://bugs.webkit.org/show_bug.cgi?id=80199

Reviewed by James Robinson.

Requires system-level testing (pixels on front-buffer should be
observed for correct behavior) that cannot be done by layout tests
or unit tests, have to rely on manual testing.

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::compositeAndReadback):

15:06 Changeset [109964] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

Make CSSStyleSelector::convertToLength() behave more like CSSPrimitiveValue::convertToLength().
https://bugs.webkit.org/show_bug.cgi?id=80375

Reviewed by Eric Seidel.

No new tests / cleanup only.

This patch removes the bool* ok parameter from CSSStyleSelector's convertToLength,
and instead uses the recently added Length(Undefined) value to indicate failure.
This paves the way for a future patch that will call primitiveValue->convertToLength directly.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

14:54 Common pixel differences between ports edited by ojan@chromium.org
(diff)
14:52 Changeset [109963] by ojan@chromium.org
  • 4 edits in trunk/Tools

Copying old baselines throws an error if the new directory doesn't exist
https://bugs.webkit.org/show_bug.cgi?id=80443

Reviewed by Adam Barth.

Existing tests cover the new code with the fix to filesystem_mock.

  • Scripts/webkitpy/common/system/filesystem_mock.py:

(MockFileSystem.copyfile):
Fix the mock to better match python's copyfile semantics.

  • Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:

(Rebaseliner._create_html_baseline_files):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineTest._copy_existing_baseline):

14:45 Changeset [109962] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Add state variable and ASSERTs to DocumentWriter to help track down
https://bugs.webkit.org/show_bug.cgi?id=80427 and prevent illegal usage
of DocumentWriter. This also makes endIfNotLoadingMainResource() private
as there is no external usage.

Patch by Raymes Khoury <raymes@chromium.org> on 2012-03-06
Reviewed by Adam Barth.

This only adds ASSERT/CRASH and does not change existing behaviour.

  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::DocumentWriter):
(WebCore::DocumentWriter::begin):
(WebCore::DocumentWriter::addData):
(WebCore::DocumentWriter::endIfNotLoadingMainResource):
(WebCore::DocumentWriter::setDocumentWasLoadedAsPartOfNavigation):

  • loader/DocumentWriter.h:

(DocumentWriter):

14:41 Changeset [109961] by mihnea@adobe.com
  • 5 edits in trunk

[CSSRegions][CSSOM]Restrict parsing of named flow name
https://bugs.webkit.org/show_bug.cgi?id=80359

Reviewed by Andreas Kling.

The function that does the parsing for flow thread name should restrict the
number of parsed properties to 1, otherwise it would allow parsing of
"-webkit-flow-into: flow; color: red;" constructions.

Source/WebCore:

Modified fast/regions/webkit-named-flow-invalid-name.html to include the above case.

  • css/CSSParser.cpp:

(WebCore::validFlowName):
(WebCore::CSSParser::parseFlowThread):

LayoutTests:

  • fast/regions/webkit-named-flow-invalid-name-expected.txt:
  • fast/regions/webkit-named-flow-invalid-name.html:
14:41 Changeset [109960] by mihaip@chromium.org
  • 1 edit
    3 copies in branches/chromium/1025

Merge 109543 - REGRESSION (r104060): Page contents not painted if inserting a new stylesheet and temporary body node
https://bugs.webkit.org/show_bug.cgi?id=76590

Reviewed by Maciej Stachowiak.

Source/WebCore:

Test: fast/css/pending-stylesheet-repaint.html

If there has been a style recalc with a pending stylesheet, the forced repaint will need to be triggered even
if the stylesheet doesn't affect the rendering. Otherwise we may end up never painting at all.

  • dom/Document.cpp:

(WebCore::Document::styleSelectorChanged):

LayoutTests:

  • fast/css/pending-stylesheet-repaint-expected.png: Added.
  • fast/css/pending-stylesheet-repaint-expected.txt: Added.
  • fast/css/pending-stylesheet-repaint.html: Added.

TBR=antti@apple.com
Review URL: https://chromiumcodereview.appspot.com/9618030

14:16 Changeset [109959] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove unused and unneeded WebPageClient::downloadRequested(NetworkRequest&)
https://bugs.webkit.org/show_bug.cgi?id=80438

Patch by Lianghui Chen <liachen@rim.com> on 2012-03-06
Reviewed by Antonio Gomes.

  • Api/WebPageClient.h:
13:59 Changeset [109958] by dgrogan@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Add OVERRIDEs to WebWorkerClientImpl.h
https://bugs.webkit.org/show_bug.cgi?id=80434

Reviewed by Tony Chang.

Tests: just that it compiles.

  • src/WebWorkerClientImpl.h:

(WebWorkerClientImpl):

13:43 Changeset [109957] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

MiniBrowser --window-size 480x800 www.nytimes.com doesn't paint bottom tiles.
https://bugs.webkit.org/show_bug.cgi?id=80313

Patch by Hugo Parente Lima <hugo.lima@openbossa.org> on 2012-03-06
Reviewed by Kenneth Rohde Christiansen.

Fix the math to get the visible rectangle and add a method to get it.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::visibleContentsRect):
(QQuickWebViewFlickablePrivate::_q_commitScaleChange):
(QQuickWebViewPrivate::_q_commitPositionChange):

  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

13:32 Changeset [109956] by mhahnenberg@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

GCActivityCallback timer should vary with the length of the previous GC
https://bugs.webkit.org/show_bug.cgi?id=80344

Reviewed by Geoffrey Garen.

  • heap/Heap.cpp: Gave Heap the ability to keep track of the length of its last

GC length so that the GC Activity Callback can use it.
(JSC::Heap::Heap):
(JSC::Heap::collect):

  • heap/Heap.h:

(JSC::Heap::lastGCLength):
(Heap):

  • runtime/GCActivityCallbackCF.cpp:

(JSC):
(JSC::DefaultGCActivityCallback::operator()): Use the length of the Heap's last
GC to determine the length of our timer trigger (currently set at 100x the duration
of the last GC).

13:32 Changeset [109955] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

Update Chromium/SVG expectations after the <use> rewrite
https://bugs.webkit.org/show_bug.cgi?id=79568

Unreviewed Chromium test_expectations update.

As expected, some tests are failing due to missing or incorrect baselines.

  • platform/chromium/test_expectations.txt:
13:11 Changeset [109954] by joepeck@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for minimal build after r109939.

Guard access to page->inspectorController with ENABLE(INSPECTOR).

  • page/FrameView.cpp:

(WebCore::FrameView::performPostLayoutTasks):

13:01 Changeset [109953] by dino@apple.com
  • 4 edits
    7 adds in trunk

Enable compositing when a CSS filter is animating
https://bugs.webkit.org/show_bug.cgi?id=79048

Reviewed by Simon Fraser.

Source/WebCore:

Now that some systems (e.g. OS X) have both hardware accelerated
CSS filters, and the ability to animate them via the hardware
compositor, all CSS filters should be composited when animating.

Tests: css3/filters/composited-during-animation-layertree.html

css3/filters/composited-during-animation.html
css3/filters/composited-during-transition-layertree.html

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore):
(WebCore::supportsAcceleratedFilterAnimations):

new method that returns true if the platform supports
hardware animations of filters.

(WebCore::GraphicsLayerCA::addAnimation):
(WebCore::GraphicsLayerCA::createAnimationFromKeyframes):

only create layer-animations if the platform supports it.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForAnimation):

create a compositing layer if animating a filter on a
supported platform.

LayoutTests:

  • platform/mac/css3/filters/composited-during-animation-expected.txt: Added.
  • platform/mac/css3/filters/composited-during-animation-layertree-expected.txt: Added.
  • css3/filters/composited-during-animation-layertree.html: Added.
  • css3/filters/composited-during-animation.html: Added.
  • platform/mac/css3/filters/composited-during-transition-layertree-expected.txt: Added.
  • css3/filters/composited-during-transition-layertree.html: Added.
12:50 Changeset [109952] by rwlbuis@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

BlackBerry] Fix cast-align gcc warnings when compiling JSC
https://bugs.webkit.org/show_bug.cgi?id=80420

Reviewed by Gavin Barraclough.

Fix warnings given in Blackberry build.

  • heap/CopiedBlock.h:

(JSC::CopiedBlock::CopiedBlock):

  • wtf/RefCountedArray.h:

(WTF::RefCountedArray::Header::fromPayload):

12:41 Common pixel differences between ports edited by ojan@chromium.org
(diff)
12:38 Common pixel differences between ports created by ojan@chromium.org
12:34 WikiStart edited by ojan@chromium.org
(diff)
12:30 Changeset [109951] by schenney@chromium.org
  • 73 edits
    50 adds
    2 deletes in trunk/LayoutTests

Update Chromium/SVG expectations after the <use> rewrite
https://bugs.webkit.org/show_bug.cgi?id=79568

Unreviewed Chromium expectation updates.

This covers the remaining text failures after r109097. There are no
image updates here (expect a missing one) because the flakiness board
indicated that no images were failing that were not already failing.
Of course, that may be incorrect but the best way to find out is to
try it.

  • platform/chromium-linux-x86/svg/filters/filter-refresh-expected.txt:
  • platform/chromium-linux-x86/svg/stroke: Added.
  • platform/chromium-linux-x86/svg/stroke/zero-length-path-linecap-rendering-expected.txt: Added.
  • platform/chromium-linux-x86/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-77-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-path-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-05-t-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/smallFonts-expected.png: Added.
  • platform/chromium-linux/svg/batik/text/textPosition-expected.txt:
  • platform/chromium-linux/svg/batik/text/textPosition2-expected.txt:
  • platform/chromium-linux/svg/carto.net/window-expected.txt: Removed.
  • platform/chromium-linux/svg/filters/filter-refresh-expected.txt:
  • platform/chromium-linux/svg/stroke/zero-length-path-linecap-rendering-expected.txt: Added.
  • platform/chromium-linux/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/batik/text/smallFonts-expected.png: Added.
  • platform/chromium-mac-leopard/svg/filters/filter-refresh-expected.txt:
  • platform/chromium-mac-leopard/svg/stroke: Added.
  • platform/chromium-mac-leopard/svg/stroke/zero-length-path-linecap-rendering-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/text-text-05-t-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/batik/paints/patternPreserveAspectRatioA-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/batik/text/longTextOnPath-expected.txt:
  • platform/chromium-mac-snowleopard/svg/batik/text/smallFonts-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/batik/text/textOnPath2-expected.txt:
  • platform/chromium-mac-snowleopard/svg/batik/text/textOnPath3-expected.txt:
  • platform/chromium-mac-snowleopard/svg/batik/text/textProperties-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/batik/text/textStyles-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/filters/filter-refresh-expected.txt:
  • platform/chromium-mac-snowleopard/svg/stroke/zero-length-path-linecap-rendering-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/text/text-text-05-t-expected.txt: Added.
  • platform/chromium-win-vista/svg/filters/filter-refresh-expected.txt:
  • platform/chromium-win-vista/svg/stroke: Added.
  • platform/chromium-win-vista/svg/stroke/zero-length-path-linecap-rendering-expected.txt: Added.
  • platform/chromium-win-vista/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Added.
  • platform/chromium-win-xp/svg/filters/filter-refresh-expected.txt:
  • platform/chromium-win-xp/svg/stroke: Added.
  • platform/chromium-win-xp/svg/stroke/zero-length-path-linecap-rendering-expected.txt: Added.
  • platform/chromium-win-xp/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Added.
  • platform/chromium-win-xp/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-use-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
  • platform/chromium-win/svg/batik/filters/feTile-expected.txt:
  • platform/chromium-win/svg/batik/filters/filterRegions-expected.txt:
  • platform/chromium-win/svg/batik/masking/maskRegions-expected.txt:
  • platform/chromium-win/svg/batik/paints/gradientLimit-expected.txt:
  • platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
  • platform/chromium-win/svg/batik/paints/patternRegionA-expected.txt:
  • platform/chromium-win/svg/batik/paints/patternRegions-expected.txt:
  • platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
  • platform/chromium-win/svg/batik/text/longTextOnPath-expected.txt:
  • platform/chromium-win/svg/batik/text/smallFonts-expected.png: Added.
  • platform/chromium-win/svg/batik/text/smallFonts-expected.txt: Added.
  • platform/chromium-win/svg/batik/text/textAnchor-expected.txt:
  • platform/chromium-win/svg/batik/text/textDecoration-expected.txt:
  • platform/chromium-win/svg/batik/text/textEffect-expected.txt:
  • platform/chromium-win/svg/batik/text/textEffect2-expected.txt:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.txt:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.txt:
  • platform/chromium-win/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
  • platform/chromium-win/svg/batik/text/textLayout-expected.txt:
  • platform/chromium-win/svg/batik/text/textLayout2-expected.txt:
  • platform/chromium-win/svg/batik/text/textLength-expected.txt:
  • platform/chromium-win/svg/batik/text/textOnPath-expected.txt:
  • platform/chromium-win/svg/batik/text/textOnPath2-expected.txt:
  • platform/chromium-win/svg/batik/text/textOnPath3-expected.txt:
  • platform/chromium-win/svg/batik/text/textOnPathSpaces-expected.txt:
  • platform/chromium-win/svg/batik/text/textPosition-expected.txt:
  • platform/chromium-win/svg/batik/text/textPosition2-expected.txt:
  • platform/chromium-win/svg/batik/text/textProperties-expected.txt:
  • platform/chromium-win/svg/batik/text/textProperties2-expected.txt:
  • platform/chromium-win/svg/batik/text/textStyles-expected.txt:
  • platform/chromium-win/svg/batik/text/verticalText-expected.txt:
  • platform/chromium-win/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/chromium-win/svg/carto.net/button-expected.txt:
  • platform/chromium-win/svg/carto.net/colourpicker-expected.txt:
  • platform/chromium-win/svg/carto.net/slider-expected.txt:
  • platform/chromium-win/svg/carto.net/window-expected.txt:
  • platform/chromium-win/svg/filters/filter-refresh-expected.txt:
  • platform/chromium-win/svg/hixie/error/017-expected.txt:
  • platform/chromium-win/svg/stroke/zero-length-path-linecap-rendering-expected.txt: Added.
  • platform/chromium-win/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Added.
  • platform/chromium-win/svg/text/text-gradient-positioning-expected.txt:
  • platform/chromium-win/svg/text/text-path-01-b-expected.txt:
  • platform/chromium-win/svg/text/text-text-04-t-expected.txt:
  • platform/chromium-win/svg/text/text-text-05-t-expected.txt:
  • platform/chromium-win/svg/text/text-text-06-t-expected.txt:
  • platform/chromium-win/svg/transforms/svg-css-transforms-clip-path-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Added.
  • platform/chromium/svg/stroke/zero-length-arc-linecaps-rendering-expected.txt: Replaced.
  • platform/chromium/test_expectations.txt:
12:23 Changeset [109950] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening.

  • platform/chromium-mac-leopard/svg/custom/use-on-text-expected.png:
12:20 Changeset [109949] by barraclough@apple.com
  • 12 edits in trunk

writable/configurable not respected for some properties of Function/String/Arguments
https://bugs.webkit.org/show_bug.cgi?id=80436

Reviewed by Oliver Hunt.

Special properties should behave like regular properties.

Source/JavaScriptCore:

  • runtime/Arguments.cpp:

(JSC::Arguments::defineOwnProperty):

  • Mis-nested logic for making read-only properties non-live.
  • runtime/JSFunction.cpp:

(JSC::JSFunction::put):

  • arguments/length/caller are non-writable, non-configurable - reject appropriately.

(JSC::JSFunction::deleteProperty):

  • Attempting to delete prototype/caller should fail.

(JSC::JSFunction::defineOwnProperty):

  • Ensure prototype is reified on attempt to reify it.
  • arguments/length/caller are non-writable, non-configurable - reject appropriately.
  • runtime/JSFunction.h:
    • added declaration for defineOwnProperty.

(JSFunction):

  • runtime/StringObject.cpp:

(JSC::StringObject::put):

  • length is non-writable, non-configurable - reject appropriately.

LayoutTests:

  • fast/js/mozilla/strict/10.6-expected.txt:
  • fast/js/mozilla/strict/15.3.5.1-expected.txt:
  • fast/js/mozilla/strict/15.3.5.2-expected.txt:
  • fast/js/mozilla/strict/15.5.5.1-expected.txt:
    • Check in passing test results.
  • fast/js/script-tests/arguments.js:
    • Fix test - this was asserting incorrect behaviour.
12:16 Changeset [109948] by dgrogan@chromium.org
  • 6 edits in trunk/Source/WebKit/chromium

IndexedDB: Check WebCommonWorkerClient::allowIndexedDB before proceeding from a shared worker
https://bugs.webkit.org/show_bug.cgi?id=79954

Tests: The 'allow' case will be tested once the patch at
http://webkit.org/b/80189 and
https://chromiumcodereview.appspot.com/9585031/ both land. Bug for
testing the 'deny' case is http://crbug.com/113738.

Reviewed by Tony Chang.

  • public/WebCommonWorkerClient.h:

(WebKit::WebCommonWorkerClient::allowDatabase):
(WebKit::WebCommonWorkerClient::allowFileSystem):
(WebKit::WebCommonWorkerClient::openFileSystem):
(WebCommonWorkerClient):
(WebKit::WebCommonWorkerClient::allowIndexedDB):

  • public/WebSharedWorkerClient.h:

(WebSharedWorkerClient):

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::AllowIndexedDBMainThreadBridge::create):
(WebKit::AllowIndexedDBMainThreadBridge::cancel):
(WebKit::AllowIndexedDBMainThreadBridge::signalCompleted):
(WebKit::AllowIndexedDBMainThreadBridge::AllowIndexedDBMainThreadBridge):
(WebKit::AllowIndexedDBMainThreadBridge::allowIndexedDBTask):
(AllowIndexedDBMainThreadBridge):
(WebKit::IDBFactoryBackendProxy::allowIDBFromWorkerThread):

  • src/WebWorkerClientImpl.cpp:

(WebKit):
(WebKit::WebWorkerClientImpl::allowIndexedDB):

  • src/WebWorkerClientImpl.h:

(WebWorkerClientImpl):

12:14 Changeset [109947] by leviw@chromium.org
  • 3 edits in branches/subpixellayout/Source/WebCore/rendering

Cleaning up RenderBlock* before merging changes to trunk. Also fixing an assert in RenderLayer because of an unecessary LayoutUnit.

12:13 Changeset [109946] by senorblanco@chromium.org
  • 6 edits
    1 delete in trunk/Source

Unreviewed, rolling out r109825.
http://trac.webkit.org/changeset/109825
https://bugs.webkit.org/show_bug.cgi?id=79413

Broke webkit_unit_tests on Chromium Win

Source/WebCore:

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::open):

  • platform/leveldb/LevelDBDatabase.cpp:

(WebCore):

  • platform/leveldb/LevelDBDatabase.h:

(LevelDBDatabase):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/LevelDBTest.cpp: Removed.
12:11 Changeset [109945] by ojan@chromium.org
  • 6 edits in trunk/Tools

Add a mechanism to rebaseline new ports
https://bugs.webkit.org/show_bug.cgi?id=80355

Reviewed by Adam Barth.

For a test that's only failing on a new port, we want
to first copy the existing result into the location for the
port it's replacing in order to not break that port.

For example, bringing up the chromium-lion port, if we just
stick the results in the chromium-mac directory, the snow leopard
will start failing. Instead, we first copy the existing result
to the chromium-mac-snowleopard directory.

  • Scripts/webkitpy/layout_tests/port/builders.py:

(builder_path_for_port_name):
(fallback_port_name_for_new_port):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineTest):
(RebaselineTest._copy_existing_baseline):
(RebaselineTest._rebaseline_test):
(RebaselineTest.execute):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaseline.test_rebaseline_test):
(TestRebaseline):
(TestRebaseline.test_rebaseline_and_copy_test):
(test_rebaseline_and_copy_test_no_existing_result):
(test_rebaseline_and_copy_test_with_lion_result):
(test_rebaseline_and_copy_no_overwrite_test):

  • Scripts/webkitpy/tool/servers/gardeningserver.py:

(GardeningHTTPRequestHandler.rebaseline):

  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:

(GardeningServerTest.test_rebaseline):
(GardeningServerTest):
(GardeningServerTest.test_rebaseline_new_port):

12:08 Changeset [109944] by bdakin@apple.com
  • 9 edits
    1 add in trunk

https://bugs.webkit.org/show_bug.cgi?id=80351
InlineTextBox is using the wrong origin when calling
addRelevantRepaintedObject
-and corresponding-
<rdar://problem/10970221>

Reviewed by Sam Weinig.

Source/WebCore:

boxOrigin represents the actual location of the text. The adjustedPaintOffset
(which I was using previously) will only correspond to the first line in a
block of lines.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint):

Tools:

This test has actually been broken since revision 109273. This change makes
the test pass again, and it makes it specifically exercise the fix for this
bug.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:

(TestWebKitAPI::TEST):

Adjust comments in the other tests to reflect the API changes from 109273.

  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:

(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):

  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:

(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):

  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:

(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage):

  • TestWebKitAPI/Tests/WebKit2/lots-of-text.html: Added.
11:59 Changeset [109943] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Disable border radius clips (r95239) for BlackBerry
https://bugs.webkit.org/show_bug.cgi?id=80416

Patch by Filip Spacek <fspacek@rim.com> on 2012-03-06
Reviewed by Antonio Gomes

The BlackBerry port suffers from the same performance
degradation when border radius clip is enabled as Chromium.

  • rendering/RenderLayer.cpp:
11:55 Changeset [109942] by senorblanco@chromium.org
  • 9 edits in trunk/Source/WebCore

Unreviewed, rolling out r109832.
http://trac.webkit.org/changeset/109832
https://bugs.webkit.org/show_bug.cgi?id=80356

Broke WebSocket tests on Chrome Mac and Linux

  • Modules/websockets/ThreadableWebSocketChannel.h:

(ThreadableWebSocketChannel):

  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
(WebCore::ThreadableWebSocketChannelClientWrapper::sendRequestResult):
(WebCore::ThreadableWebSocketChannelClientWrapper::setSendRequestResult):

  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:

(ThreadableWebSocketChannelClientWrapper):

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::send):

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::send):
(WebCore::WebSocketChannel::enqueueTextFrame):
(WebCore::WebSocketChannel::processOutgoingFrameQueue):

  • Modules/websockets/WebSocketChannel.h:

(WebSocketChannel):
(QueuedFrame):

  • Modules/websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::send):
(WebCore::workerContextDidSend):
(WebCore::WorkerThreadableWebSocketChannel::Peer::send):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):

  • Modules/websockets/WorkerThreadableWebSocketChannel.h:

(WorkerThreadableWebSocketChannel):
(Bridge):

11:50 Changeset [109941] by senorblanco@chromium.org
  • 6 edits
    4 deletes in trunk

Unreviewed, rolling out r109840.
http://trac.webkit.org/changeset/109840
https://bugs.webkit.org/show_bug.cgi?id=80103

Broke WebSocket tests on Chrome Mac and Linux

Source/WebCore:

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::send):
(WebCore::WebSocket::close):

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::send):

LayoutTests:

  • http/tests/websocket/tests/hybi/close-expected.txt:
  • http/tests/websocket/tests/hybi/unpaired-surrogates-in-close-reason-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/unpaired-surrogates-in-close-reason.html: Removed.
  • http/tests/websocket/tests/hybi/unpaired-surrogates-in-message-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/unpaired-surrogates-in-message.html: Removed.
  • http/tests/websocket/tests/hybi/workers/close-expected.txt:
11:44 Changeset [109940] by eae@chromium.org
  • 3 edits in branches/subpixellayout/Source/WebCore

Add size_t version of AppUnit::operator/ on branch.

11:33 Changeset [109939] by joepeck@webkit.org
  • 19 edits in trunk/Source

<http://webkit.org/b/78575> Web Inspector: Disable dock button when not allowed to dock

There are times when an undocked inspector frontend is not allowed to
attach to the main window. We can disable the dock button in those cases.

Reviewed by Pavel Feldman.

No new tests. This functionality is port specific right now.

  • page/FrameView.cpp:

(WebCore::FrameView::performPostLayoutTasks):
When the main frame is resized we let the inspector client know,
so that it can react to it as needed.

  • WebCore.exp.in:
  • inspector/InspectorClient.h:

(WebCore::InspectorClient::didResizeMainFrame):

  • inspector/InspectorController.cpp:
  • inspector/InspectorController.h:

(WebCore::InspectorController::inspectorClient):
Call up to the port though to the InspectorClient.

  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::frontendLoaded):
(WebCore::InspectorFrontendClientLocal::setDockingUnavailable):

  • inspector/InspectorFrontendClientLocal.h:

On ports where the inspector frontend client is local, provide a
setDockingUnavailable InspectorFrontendAPI to update the docking state.
Automatically update availability when the frontend completes loading.

  • inspector/front-end/InspectorFrontendAPI.js:

(InspectorFrontendAPI.setDockingUnavailable):

  • inspector/front-end/inspector.js:

(WebInspector._createGlobalStatusBarItems):
(WebInspector.setAttachedWindow):
(WebInspector.setDockingUnavailable):
(WebInspector.updateDockToggleButton):
Update the dock button's enabled/disabled state when its created,
when the attached state changes, when get a frontend API notification
that we cannot attach.

  • inspector/front-end/InspectorFrontendHostStub.js:

Remove unused canAttachWindow method.

Source/WebKit/mac: Web Inspector: Hide dock button when not allowed to dock
https://bugs.webkit.org/show_bug.cgi?id=78575

Reviewed by Pavel Feldman.

  • WebCoreSupport/WebInspectorClient.h:

(WebCore):
(WebInspectorClient):

  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorClient::didResizeMainFrame):

Source/WebKit2: Web Inspector: Hide dock button when not allowed to dock
https://bugs.webkit.org/show_bug.cgi?id=78575

Reviewed by Pavel Feldman.

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::didResizeMainFrame):

  • WebProcess/WebCoreSupport/WebInspectorClient.h:
  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::updateDockingAvailability):

  • WebProcess/WebPage/WebInspector.h:
11:23 Changeset [109938] by hans@chromium.org
  • 6 edits
    8 adds in trunk

Speech JavaScript API: add SpeechRecognitionError
https://bugs.webkit.org/show_bug.cgi?id=80410

Source/WebCore:

Reviewed by Adam Barth.

Add SpeechRecognitionError.

Test: fast/speech/scripted/speechrecognitionerror-basics.html

  • Modules/speech/DOMWindowSpeech.idl: Added.
  • Modules/speech/SpeechRecognitionError.cpp: Added.

(WebCore):
(WebCore::SpeechRecognitionError::create):
(WebCore::SpeechRecognitionError::SpeechRecognitionError):

  • Modules/speech/SpeechRecognitionError.h: Added.

(WebCore):
(SpeechRecognitionError):
(WebCore::SpeechRecognitionError::code):
(WebCore::SpeechRecognitionError::message):

  • Modules/speech/SpeechRecognitionError.idl: Added.
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:

Tools:

Chromium: enable the runtime flag for scripted speech so we can run
the layout tests for it.

Reviewed by Adam Barth.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

LayoutTests:

Add a test for SpeechRecognitionError.

Reviewed by Adam Barth.

  • fast/speech/scripted/speechrecognitionerror-basics.html: Added.
11:08 Changeset [109937] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Enable universal newlines in chromium android layout test runner
https://bugs.webkit.org/show_bug.cgi?id=80418

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-03-06
Reviewed by Adam Barth.

The Chromium Android layout test runner uses the 'adb' program to
communicate with the Android device. Adb uses CRLF ('\r\n') to delimit
output lines from the test runner, while the test expectation files are
written with LF ('\n') delimiters. This causes the results to have
spurious whitespace differences, making them more difficult to
interpret.

The fix is to enable universal newlines for the DumpRenderTree pipe,
causing the output to only contain LF newlines like on other platforms.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidDriver._start):

11:07 Changeset [109936] by cevans@google.com
  • 3 edits
    4 copies in branches/chromium/1025

Merge 109480
BUG=114513
Review URL: https://chromiumcodereview.appspot.com/9617017

11:01 Changeset [109935] by eae@chromium.org
  • 8 edits in branches/subpixellayout/Source/WebCore/rendering

Fix basline bug in RenderDeprecatedFlexibleBox on branch.

10:35 Changeset [109934] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

select-line-break-with-opposite-directionality.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=80227

Unreviewed test fix attempt.

  • editing/selection/select-line-break-with-opposite-directionality.html:
10:15 Changeset [109933] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreleased gst_object_reference to audio sink in MediaPlayerPrivateGStreamer
https://bugs.webkit.org/show_bug.cgi?id=79795

Bug fix: Used a GRefPtr to hold the reference to the audio sink instead of a GstElement*.
Code cleanup: Used the same pattern for webkit web source and removed explicit gst_unref in destructor.

Patch by David Corvoysier <david.corvoysier@orange.com> on 2012-03-06
Reviewed by Philippe Normand.

No new tests. No change in behavior.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer):

10:03 Changeset [109932] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

[CMake] Build fix for !ENABLE(WORKERS) after r109556 and r109833.

  • CMakeLists.txt:
09:57 Changeset [109931] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt][WK2] Crash in Frame.cpp when loading index.hu
https://bugs.webkit.org/show_bug.cgi?id=80165

Guard against possible null document, which can happen
when unsetting a document in a frame.

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-06
Reviewed by Kenneth Rohde Christiansen.

  • page/Frame.cpp:

(WebCore::Frame::setDocument):

09:54 Changeset [109930] by abecsi@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt] Interaction Engine suspends content during pageload.
https://bugs.webkit.org/show_bug.cgi?id=80294

Only suspend content when viewport updates are deferred
for a non-instantanious interaction.

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-06
Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::ViewportUpdateDeferrer::ViewportUpdateDeferrer):
(WebKit::ViewportUpdateDeferrer::~ViewportUpdateDeferrer):
(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::flickableMoveStarted):
(WebKit::QtViewportInteractionEngine::scaleAnimationStateChanged):

  • UIProcess/qt/QtViewportInteractionEngine.h:

(QtViewportInteractionEngine):

09:51 Changeset [109929] by jberlin@webkit.org
  • 2 edits
    4 adds in trunk/Source/WebCore

WebCore build exceeds address space on 32-bit Windows builds.
https://bugs.webkit.org/show_bug.cgi?id=80346

Patch by Lucas Forschler <lforschler@apple.com> on 2012-03-06
Reviewed by Jessie Berlin.

Patch by Lucas Forschler, landed by Jessie Berlin.

Add AllInOne.cpp files for a few projects.
This will only affect Production and Release builds.
Let VS rebuild the project file.

  • WebCore.vcproj/WebCore.vcproj:
  • css/MediaAllInOne.cpp: Added.
  • loader/appcache/ApplicationCacheAllInOne.cpp: Added.
  • mathml/MathMLAllInOne.cpp: Added.
  • platform/text/TextAllInOne.cpp: Added.
09:46 Changeset [109928] by philn@webkit.org
  • 4 edits in trunk/LayoutTests

[GTK] fullscreen/full-screen-iframe-legacy.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=74279

Reviewed by Eric Carlson.

  • fullscreen/full-screen-iframe-legacy.html: Wait for canplaythrough

event on the video and increase the timeout to 100ms to reduce
flakiness. Also set the iframe video url from the main frame
before installing the canplaythrough event listener.

09:17 Changeset [109927] by pfeldman@chromium.org
  • 9 edits in trunk

Web Inspector: add support for inspection of huge (1M elements) arrays.
https://bugs.webkit.org/show_bug.cgi?id=80421

Reviewed by Vsevolod Vlasov.

Source/WebCore:

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype.completionsForExpression.evaluated):

  • inspector/front-end/ElementsPanel.js:
  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertiesSection.prototype.update.callback):
(WebInspector.ObjectPropertiesSection.prototype.update):
(WebInspector.ObjectPropertiesSection.prototype.updateProperties):
(WebInspector.ObjectPropertyTreeElement.prototype.onpopulate.callback):
(WebInspector.ObjectPropertyTreeElement.prototype.onpopulate):
(WebInspector.ArrayGroupingTreeElement):
(WebInspector.ArrayGroupingTreeElement._populateArray):
(WebInspector.ArrayGroupingTreeElement._populateRanges):
(WebInspector.ArrayGroupingTreeElement._populateRanges.callback):
(WebInspector.ArrayGroupingTreeElement._populateAsFragment):
(WebInspector.ArrayGroupingTreeElement._populateAsFragment.processArrayFragment):
(WebInspector.ArrayGroupingTreeElement._populateAsFragment.processProperties):
(WebInspector.ArrayGroupingTreeElement._populateNonIndexProperties.buildObjectFragment):
(WebInspector.ArrayGroupingTreeElement._populateNonIndexProperties.processObjectFragment):
(WebInspector.ArrayGroupingTreeElement._populateNonIndexProperties.processProperties):
(WebInspector.ArrayGroupingTreeElement._populateNonIndexProperties):
(WebInspector.ArrayGroupingTreeElement.prototype.onpopulate):
(WebInspector.ArrayGroupingTreeElement.prototype.onattach):

  • inspector/front-end/PropertiesSidebarPane.js:

(WebInspector.PropertiesSidebarPane.prototype.update.nodeResolved):

  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject.prototype.callFunction):
(WebInspector.RemoteObject.prototype.callFunctionJSON):

LayoutTests:

  • http/tests/inspector/indexeddb/database-data.html:
  • inspector/console/console-big-array.html:
09:09 Changeset [109926] by jpetsovits@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Don't suspend accel comp when backgrounding a page.
https://bugs.webkit.org/show_bug.cgi?id=80369
RIM PR: 137609

Reviewed by Adam Treat.

Just because the page is in the background doesn't mean
it's invisible, doesn't mean it won't have to be redrawn
at some point - on rotation, for instance.

We still suspend accelerated compositing on setVisible(false).

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::notifyPageBackground):
(BlackBerry::WebKit::WebPage::notifyPageForeground):

08:58 Changeset [109925] by senorblanco@chromium.org
  • 8 edits
    2 adds
    2 deletes in trunk/LayoutTests

[chromium] Rebaseline some SVG tests now giving correct results.

Unreviewed gardening.

  • platform/chromium-linux/svg/custom/use-on-text-expected.png:
  • platform/chromium-linux/svg/custom/use-referencing-nonexisting-symbol-expected.png: Added.
  • platform/chromium-linux/svg/custom/use-setAttribute-crash-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/use-on-text-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/use-on-text-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/use-referencing-nonexisting-symbol-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/use-referencing-nonexisting-symbol-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/use-setAttribute-crash-expected.png:
  • platform/chromium-win/svg/custom/use-on-text-expected.png:
  • platform/chromium-win/svg/custom/use-referencing-nonexisting-symbol-expected.png:
  • platform/chromium-win/svg/custom/use-setAttribute-crash-expected.png:
08:34 Changeset [109924] by lforschler@apple.com
  • 2 edits in tags/Safari-536.2.1/Source/WebKit2

Merged r109826.

08:33 Changeset [109923] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Open link in resources panel only works the second time
https://bugs.webkit.org/show_bug.cgi?id=80407

Reviewed by Pavel Feldman.

  • inspector/front-end/inspector.js:

(WebInspector.openResource):

08:20 Changeset [109922] by yurys@chromium.org
  • 11 edits in trunk/Source/WebCore

Web Inspector: InspectorCounters mechanism should be thread-safe
https://bugs.webkit.org/show_bug.cgi?id=80166

Make InspectorCounters instance thread local so that it can be safely accessed
in workers.

Reviewed by Pavel Feldman.

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::~JSEventListener):

  • bindings/v8/V8AbstractEventListener.cpp:

(WebCore::V8AbstractEventListener::V8AbstractEventListener):
(WebCore::V8AbstractEventListener::~V8AbstractEventListener):

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::~Document):

  • dom/Document.h:

(WebCore::Node::Node):

  • dom/Node.cpp:

(WebCore::Node::~Node):

  • inspector/InspectorCounters.cpp:

(WebCore::InspectorCounters::InspectorCounters):
(WebCore::InspectorCounters::counterValue):
(WebCore):
(WebCore::InspectorCounters::current):

  • inspector/InspectorCounters.h:

(WebCore::InspectorCounters::incrementCounter):
(WebCore::InspectorCounters::decrementCounter):
(InspectorCounters):

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::setHeapSizeStatistic):

  • platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::destroy):

  • platform/ThreadGlobalData.h:

(WebCore):
(ThreadGlobalData):
(WebCore::ThreadGlobalData::inspectorCounters):

08:10 Changeset [109921] by philn@webkit.org
  • 4 edits in trunk/LayoutTests

[GStreamer] media/video-played-collapse.html
https://bugs.webkit.org/show_bug.cgi?id=36165

Reviewed by Eric Carlson.

Refactored the test to minimize flakiness risks.

  • media/video-played-collapse-expected.txt:
  • media/video-played-collapse.html:
  • platform/gtk/test_expectations.txt:
08:10 Changeset [109920] by mrobinson@webkit.org
  • 8 edits
    2 deletes in releases/WebKitGTK/webkit-1.8

Merging r109791

07:50 Changeset [109919] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Upstream typedef of NativeImageSourcePtr and NativeImagePtr
https://bugs.webkit.org/show_bug.cgi?id=80388

Reviewed by Antonio Gomes.

These are the BlackBerry typdefs of NativeImageSourcePtr and NativeImagePtr.

  • platform/graphics/ImageSource.h:

(WebCore):

07:46 WebKit Team edited by alexis.menard@openbossa.org
(diff)
07:30 Changeset [109918] by commit-queue@webkit.org
  • 5 edits in trunk

TypedArray subarray call for subarray does not clamp the end index parameter properly
https://bugs.webkit.org/show_bug.cgi?id=80285

Patch by Ulan Degenbaev <ulan@chromium.org> on 2012-03-06
Reviewed by Kenneth Russell.

Source/JavaScriptCore:

  • wtf/ArrayBufferView.h:

(WTF::ArrayBufferView::calculateOffsetAndLength):

LayoutTests:

  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:
07:17 Changeset [109917] by schenney@chromium.org
  • 80 edits
    18 adds
    14 deletes in trunk/LayoutTests

Update Chromium/SVG expectations after the <use> rewrite
https://bugs.webkit.org/show_bug.cgi?id=79568

Unreviewed Chromium expectations update.

Stage 1 of expectations updating for SVG <use> refactor. This covers the svg/custom directory.

  • platform/chromium-linux-x86/svg/custom/use-disappears-after-style-update-expected.txt:
  • platform/chromium-linux-x86/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/chromium-linux-x86/svg/custom/use-setAttribute-crash-expected.txt: Added.
  • platform/chromium-linux/svg/custom/use-disappears-after-style-update-expected.txt:
  • platform/chromium-linux/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/chromium-linux/svg/custom/use-on-text-expected.png:
  • platform/chromium-linux/svg/custom/use-referencing-nonexisting-symbol-expected.png: Removed.
  • platform/chromium-linux/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
  • platform/chromium-linux/svg/custom/use-setAttribute-crash-expected.png: Removed.
  • platform/chromium-linux/svg/custom/use-setAttribute-crash-expected.txt:
  • platform/chromium-mac-leopard/svg/custom/use-disappears-after-style-update-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/custom/use-font-face-crash-expected.txt:
  • platform/chromium-mac-leopard/svg/custom/use-on-text-expected.png:
  • platform/chromium-mac-leopard/svg/custom/use-setAttribute-crash-expected.txt:
  • platform/chromium-mac-snowleopard/svg/custom/broken-internal-references-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/clip-path-referencing-use2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/custom/recursive-clippath-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/recursive-mask-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/recursive-pattern-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/use-css-events-expected.txt:
  • platform/chromium-mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/custom/use-events-crash-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/use-on-disallowed-foreign-object-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/use-on-disallowed-foreign-object-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/use-on-disallowed-foreign-object-5-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/use-on-disallowed-foreign-object-6-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/use-on-non-svg-namespaced-element-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/chromium-mac-snowleopard/svg/custom/use-on-text-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/use-on-text-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/custom/use-referencing-nonexisting-symbol-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/use-referencing-nonexisting-symbol-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/custom/use-setAttribute-crash-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/use-setAttribute-crash-expected.txt:
  • platform/chromium-mac/svg/custom/broken-internal-references-expected.png: Removed.
  • platform/chromium-mac/svg/custom/clip-path-referencing-use2-expected.txt: Removed.
  • platform/chromium-mac/svg/custom/recursive-clippath-expected.png: Removed.
  • platform/chromium-mac/svg/custom/recursive-mask-expected.png: Removed.
  • platform/chromium-mac/svg/custom/recursive-pattern-expected.png: Removed.
  • platform/chromium-mac/svg/custom/use-events-crash-expected.png: Removed.
  • platform/chromium-mac/svg/custom/use-on-disallowed-foreign-object-1-expected.png: Removed.
  • platform/chromium-mac/svg/custom/use-on-disallowed-foreign-object-2-expected.png: Removed.
  • platform/chromium-mac/svg/custom/use-on-disallowed-foreign-object-5-expected.png: Removed.
  • platform/chromium-mac/svg/custom/use-on-disallowed-foreign-object-6-expected.png: Removed.
  • platform/chromium-mac/svg/custom/use-on-non-svg-namespaced-element-expected.png: Removed.
  • platform/chromium-win-vista/svg/custom/use-disappears-after-style-update-expected.txt:
  • platform/chromium-win-vista/svg/custom/use-setAttribute-crash-expected.txt:
  • platform/chromium-win-xp/svg/custom/use-disappears-after-style-update-expected.txt:
  • platform/chromium-win-xp/svg/custom/use-setAttribute-crash-expected.txt:
  • platform/chromium-win/svg/custom/broken-internal-references-expected.txt:
  • platform/chromium-win/svg/custom/clip-path-referencing-use-expected.txt:
  • platform/chromium-win/svg/custom/clip-path-referencing-use2-expected.txt:
  • platform/chromium-win/svg/custom/embedding-external-svgs-expected.txt:
  • platform/chromium-win/svg/custom/path-textPath-simulation-expected.txt:
  • platform/chromium-win/svg/custom/pattern-rotate-expected.txt:
  • platform/chromium-win/svg/custom/recursive-clippath-expected.txt:
  • platform/chromium-win/svg/custom/recursive-mask-expected.txt:
  • platform/chromium-win/svg/custom/recursive-pattern-expected.txt:
  • platform/chromium-win/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
  • platform/chromium-win/svg/custom/relative-sized-shadow-tree-content-expected.txt:
  • platform/chromium-win/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
  • platform/chromium-win/svg/custom/relative-sized-use-on-symbol-expected.txt:
  • platform/chromium-win/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
  • platform/chromium-win/svg/custom/struct-use-09-b-expected.txt:
  • platform/chromium-win/svg/custom/use-clipped-hit-expected.txt:
  • platform/chromium-win/svg/custom/use-css-events-expected.txt:
  • platform/chromium-win/svg/custom/use-disappears-after-style-update-expected.png:
  • platform/chromium-win/svg/custom/use-disappears-after-style-update-expected.txt:
  • platform/chromium-win/svg/custom/use-dynamic-append-expected.txt:
  • platform/chromium-win/svg/custom/use-elementInstance-event-target-expected.txt:
  • platform/chromium-win/svg/custom/use-elementInstance-methods-expected.txt:
  • platform/chromium-win/svg/custom/use-event-handler-on-referenced-element-expected.txt:
  • platform/chromium-win/svg/custom/use-event-handler-on-use-element-expected.txt:
  • platform/chromium-win/svg/custom/use-events-crash-expected.txt:
  • platform/chromium-win/svg/custom/use-font-face-crash-expected.txt:
  • platform/chromium-win/svg/custom/use-instanceRoot-modifications-expected.txt:
  • platform/chromium-win/svg/custom/use-modify-container-in-target-expected.txt:
  • platform/chromium-win/svg/custom/use-modify-target-container-expected.txt:
  • platform/chromium-win/svg/custom/use-modify-target-symbol-expected.txt:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-1-expected.txt:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-2-expected.txt:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-3-expected.txt:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-4-expected.txt:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
  • platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
  • platform/chromium-win/svg/custom/use-on-g-containing-symbol-expected.txt:
  • platform/chromium-win/svg/custom/use-on-g-containing-use-expected.txt:
  • platform/chromium-win/svg/custom/use-on-g-expected.txt:
  • platform/chromium-win/svg/custom/use-on-non-svg-namespaced-element-expected.txt:
  • platform/chromium-win/svg/custom/use-on-rect-expected.txt:
  • platform/chromium-win/svg/custom/use-on-symbol-expected.txt:
  • platform/chromium-win/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/chromium-win/svg/custom/use-on-text-expected.png:
  • platform/chromium-win/svg/custom/use-on-text-expected.txt:
  • platform/chromium-win/svg/custom/use-on-use-expected.txt:
  • platform/chromium-win/svg/custom/use-property-changes-through-dom-expected.txt:
  • platform/chromium-win/svg/custom/use-property-changes-through-svg-dom-expected.txt:
  • platform/chromium-win/svg/custom/use-recursion-1-expected.txt:
  • platform/chromium-win/svg/custom/use-recursion-2-expected.txt:
  • platform/chromium-win/svg/custom/use-recursion-3-expected.txt:
  • platform/chromium-win/svg/custom/use-recursion-4-expected.txt:
  • platform/chromium-win/svg/custom/use-referencing-nonexisting-symbol-expected.png:
  • platform/chromium-win/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
  • platform/chromium-win/svg/custom/use-setAttribute-crash-expected.png:
  • platform/chromium-win/svg/custom/use-setAttribute-crash-expected.txt:
  • platform/chromium-win/svg/custom/use-transform-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/mac-future/svg/custom: Added.
  • platform/mac-future/svg/custom/use-on-symbol-inside-pattern-expected.png: Added.
  • platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.png: Removed.
07:05 Changeset [109916] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

SVG transform-origin presentation attribute
https://bugs.webkit.org/show_bug.cgi?id=79678

Patch by Hans Muller <hmuller@adobe.com> on 2012-03-06
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Added the SVG transform-origin presentation attribute. Currently WebCore::mapAttributeToCSSProperty()
just maps it to -webkit-transform-origin. When the transform-origin CSS property is supported, this
part of the change can be removed.

Test: svg/transforms/transform-origin-presentation-attribute.xhtml

  • svg/SVGStyledElement.cpp:

(WebCore::mapAttributeToCSSProperty):
(WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName):

  • svg/svgattrs.in:

LayoutTests:

Test case just verifies that the transform-origin presentation attribute
changes an SVG element's getComputedStyle() as expected.

  • svg/transforms/transform-origin-presentation-attribute-expected.txt: Added.
  • svg/transforms/transform-origin-presentation-attribute.xhtml: Added.
07:02 Changeset [109915] by philn@webkit.org
  • 19 edits in trunk/Source

[GStreamer] disable GStreamerGWorld when building against 0.11
https://bugs.webkit.org/show_bug.cgi?id=77088

Source/WebCore:

Reviewed by Martin Robinson.

Don't build GStreamerGWorld and PlatformVideoWindow under
GStreamer 0.11. It's supposed to be removed soon anyway.

  • platform/graphics/gstreamer/GStreamerGWorld.cpp:
  • platform/graphics/gstreamer/GStreamerGWorld.h:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::totalBytes):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer):

  • platform/graphics/gstreamer/PlatformVideoWindow.h:
  • platform/graphics/gstreamer/PlatformVideoWindowEfl.cpp:
  • platform/graphics/gstreamer/PlatformVideoWindowGtk.cpp:
  • platform/graphics/gstreamer/PlatformVideoWindowMac.mm:
  • platform/graphics/gstreamer/PlatformVideoWindowQt.cpp:

Source/WebKit/gtk:

Disable the FullscreenVideoController if we build against
GStreamer 0.11. This code depends on GStreamerGWorld which wasn't
ported to 0.11 because it will soon be removed anyway.

Reviewed by Martin Robinson.

  • WebCoreSupport/FullscreenVideoController.cpp:
  • WebCoreSupport/FullscreenVideoController.h:
  • webkit/webkitwebview.cpp:

(webViewEnterFullscreen):
(webViewExitFullscreen):

  • webkit/webkitwebviewprivate.h:

(_WebKitWebViewPrivate):

Source/WebKit/qt:

Reviewed by Martin Robinson.

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::ChromeClientQt):
(WebCore::ChromeClientQt::~ChromeClientQt):
(WebCore):

  • WebCoreSupport/FullScreenVideoQt.cpp:

(WebCore):
(WebCore::FullScreenVideoQt::FullScreenVideoQt):
(WebCore::FullScreenVideoQt::~FullScreenVideoQt):
(WebCore::FullScreenVideoQt::enterFullScreenForNode):
(WebCore::FullScreenVideoQt::exitFullScreenForNode):
(WebCore::FullScreenVideoQt::isValid):

  • WebCoreSupport/FullScreenVideoQt.h:

(WebCore):

06:10 Changeset [109914] by ahf@0x90.dk
  • 3 edits in trunk/Source/WebCore

Rename m_tileCreationTimer in the tiled backing store https://bugs.webkit.org/show_bug.cgi?id=80414

Patch by Kenneth Rohde Christiansen and Alexander Færøy.

Reviewed by Tor Arne Vestbø.

The m_tileCreationTimer member is currently being used to represent a
timer that is fired when the backing store has been updated which is
confusing with its current name. This patch fixes this by renaming
the m_tileCreationTimer to m_backingStoreUpdateTimer.

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::TiledBackingStore):
(WebCore::TiledBackingStore::setTileSize):
(WebCore::TiledBackingStore::coverWithTilesIfNeeded):
(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::startBackingStoreUpdateTimer):
(WebCore::TiledBackingStore::backingStoreUpdateTimerFired):
(WebCore::TiledBackingStore::setContentsFrozen):

  • platform/graphics/TiledBackingStore.h:

(TiledBackingStore):

05:41 Changeset [109913] by loislo@chromium.org
  • 2 edits in trunk/PerformanceTests

Web Inspector: Heap Snapshot test: split overal time metric into separate metrics.
https://bugs.webkit.org/show_bug.cgi?id=80409

Reviewed by Yury Semikhatsky.

  • inspector/detailed-heapshots-smoke-test.html:
05:37 Changeset [109912] by hausmann@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Make QQuickWebView's url property work with a flickable webview

Reviewed by Tor Arne Vestbø.

QQuickWebViewPrivate::onComponentComplete implements the deferred url loading
when the url property is set in the component instantiation. QQuickWebViewFlickablePrivate
is the private sub-class used for a flickable webview, which re-implemented onComponentComplete
but forgot to call the base implementation.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewFlickablePrivate::onComponentComplete):

05:37 Changeset [109911] by kubo@profusion.mobi
  • 2 edits in trunk/Source/WebKit

[EFL] Unreviewed; fix the build after r109877.

  • CMakeLists.txt: Add WebCore/Modules/webdatabase to the list of

include directories so that #include'ing DatabaseDetails.h and
friends still works.

05:32 Changeset [109910] by ahf@0x90.dk
  • 3 edits in trunk/Source/WebCore

Remove TileTimer typedef from the tiled backing store https://bugs.webkit.org/show_bug.cgi?id=80408

Patch by Kenneth Rohde Christiansen and Alexander Færøy.

Reviewed by Tor Arne Vestbø.

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::tileBufferUpdateTimerFired):
(WebCore::TiledBackingStore::tileCreationTimerFired):

  • platform/graphics/TiledBackingStore.h:

(TiledBackingStore):

05:25 Changeset [109909] by vestbo@webkit.org
  • 5 edits in trunk/Tools

[Qt] Revert r109900, it was completly busted

HAVE_FOO does _not_ have a WTF_ prefix, go figure.

We still leave in the HAVE(FOO) in QtInitializeTestFonts.cpp, instead
of manual define checks.

Reviewed by Ossy.

05:15 Changeset [109908] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Source/WebCore

[BlackBerry] Upstream LayerRenderer.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=79874

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-03-06
Reviewed by Antonio Gomes.

Initial upstream, no new tests.

  • platform/graphics/blackberry/LayerRenderer.cpp: Added.

(WebCore):
(WebCore::checkGLError):
(WebCore::loadShader):
(WebCore::loadShaderProgram):
(WebCore::orthoMatrix):
(WebCore::rawPtrVectorFromRefPtrVector):
(WebCore::LayerRenderer::create):
(WebCore::LayerRenderer::LayerRenderer):
(WebCore::LayerRenderer::~LayerRenderer):
(WebCore::LayerRenderer::releaseLayerResources):
(WebCore::compareLayerZ):
(WebCore::LayerRenderer::drawLayers):
(WebCore::LayerRenderer::useSurface):
(WebCore::LayerRenderer::drawLayersOnSurfaces):
(WebCore::LayerRenderer::setRootLayer):
(WebCore::LayerRenderer::addLayer):
(WebCore::LayerRenderer::removeLayer):
(WebCore::LayerRenderer::addLayerToReleaseTextureResourcesList):
(WebCore::LayerRenderer::toOpenGLWindowCoordinates):
(WebCore::LayerRenderer::toWebKitWindowCoordinates):
(WebCore::LayerRenderer::toWebKitDocumentCoordinates):
(WebCore::LayerRenderer::drawDebugBorder):
(WebCore::LayerRenderer::drawHolePunchRect):
(WebCore::LayerRenderer::updateLayersRecursive):
(WebCore::hasRotationalComponent):
(WebCore::LayerRenderer::layerAlreadyOnSurface):
(WebCore::collect3DPreservingLayers):
(WebCore::LayerRenderer::compositeLayersRecursive):
(WebCore::LayerRenderer::updateScissorIfNeeded):
(WebCore::LayerRenderer::makeContextCurrent):
(WebCore::LayerRenderer::bindCommonAttribLocation):
(WebCore::LayerRenderer::initializeSharedGLObjects):
(WebCore::LayerRenderingResults::holePunchRect):
(WebCore::LayerRenderingResults::addHolePunchRect):
(WebCore::LayerRenderingResults::addDirtyRect):
(WebCore::LayerRenderingResults::isEmpty):

  • platform/graphics/blackberry/LayerRenderer.h: Added.

(WebCore):
(LayerRenderingResults):
(WebCore::LayerRenderingResults::LayerRenderingResults):
(WebCore::LayerRenderingResults::holePunchRectSize):
(WebCore::LayerRenderingResults::dirtyRect):
(LayerRenderer):
(WebCore::LayerRenderer::rootLayer):
(WebCore::LayerRenderer::hardwareCompositing):
(WebCore::LayerRenderer::setClearSurfaceOnDrawLayers):
(WebCore::LayerRenderer::clearSurfaceOnDrawLayers):
(WebCore::LayerRenderer::context):
(WebCore::LayerRenderer::lastRenderingResults):
(WebCore::LayerRenderer::setNeedsCommit):

04:59 Changeset [109907] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] function rename issue after MediaPlayerPrivateBlackBerry.[cpp\h] upstream
https://bugs.webkit.org/show_bug.cgi?id=80377

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-03-06
Reviewed by Rob Buis.

As some of the function names changed in class MediaPlayerPrivate
with the upstream of MediaPlayerPrivateBlackBerry.[cpp|h], we
should update WebKit/blackberry/Api/WebPage.cpp which uses these
functions accordingly.
Renamed functions in class MediaPlayerPrivate:
windowGet() -> getWindow()
windowPositionGet() -> getWindowPosition()
mmrContextNameGet() -> mmrContextName()

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::enterFullscreenForNode):

04:42 Changeset [109906] by rolandsteiner@chromium.org
  • 2 edits in trunk/Source/WebCore

r109563 caused perf regression
https://bugs.webkit.org/show_bug.cgi?id=80404

Add test for Element or ShadowRoot.

Reviewed by Antti Koivisto.

No new tests. (fix)

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::pushParentElement):

04:39 Changeset [109905] by podivilov@chromium.org
  • 5 edits in trunk

Web Inspector: prepare for extracting ScriptMapping implementation from DebuggerPresentationModel.
https://bugs.webkit.org/show_bug.cgi?id=80396

Source/WebCore:

Limit RawSourceCode usages to a subset of methods. This subset will be moved to ScriptMapping implementation in a separate change.

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.createPlacard):
(WebInspector.DebuggerPresentationModel.prototype.createLiveLocation):
(WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource.didEditScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._forceUpdateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessageToScript):
(WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
(WebInspector.PresentationCallFrame):
(WebInspector.PresentationCallFrame.prototype.uiLocation):
(WebInspector.DebuggerPresentationModel.CallFramePlacard):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.setContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype._uiSourceCodeForResource):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyRawLocation):

LayoutTests:

Reviewed by Vsevolod Vlasov.

  • inspector/debugger/callstack-placards-discarded.html:
  • inspector/debugger/linkifier.html:
04:34 Changeset [109904] by vestbo@webkit.org
  • 6 edits
    2 adds in trunk/Tools

[Qt] Use config test to determine if the compiler supports -MD

We used to assume that unix systems building against Qt5 would have
a compiler that supported -MD. Although this was usually the case,
we failed to take into account broken tools for distributed builds
(e.g. teambuilder or icecream) which would end up producing .d files
in the root of the build dir instead of along-side the object file.

Now that we use a config-test to determine the support, we'll capture
those cases, unless distributed builds are enabled after the initial
build-webkit run.

Reviewed by Csaba Osztrogonác.

04:28 Changeset [109903] by vsevik@chromium.org
  • 8 edits
    2 adds in trunk

Web Inspector: [Regression] Execution line is not revealed when debugger is stopped if scripts panel was not yet shown.
https://bugs.webkit.org/show_bug.cgi?id=80306

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/reveal-execution-line.html

  • inspector/front-end/ConsoleView.js:
  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.afterTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype.setExecutionLine):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._executionLineChanged):
(WebInspector.ScriptsPanel.prototype._revealExecutionLine):
(WebInspector.ScriptsPanel.prototype._callFrameSelected):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.willHide):
(WebInspector.SourceFrame.prototype.highlightLine):
(WebInspector.SourceFrame.prototype.revealLine):
(WebInspector.SourceFrame.prototype._clearLineToReveal):
(WebInspector.SourceFrame.prototype.setContent):

LayoutTests:

  • inspector/debugger/callstack-placards-discarded-expected.txt:
  • inspector/debugger/reveal-execution-line-expected.txt: Added.
  • inspector/debugger/reveal-execution-line.html: Added.
04:25 Changeset [109902] by ossy@webkit.org
  • 2 edits in trunk/Tools

REGRESSION(r109294): It broke the unittest of master.cfg
https://bugs.webkit.org/show_bug.cgi?id=80253

Reviewed by Tor Arne Vestbø.

  • BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Use json instead of simplejson.

(BuildBotConfigLoader._create_mock_passwords_dict):
(BuildBotConfigLoader._mock_open):
(BuildBotConfigLoader._add_dependant_modules_to_sys_modules):
(BuildBotConfigLoader.load_config):

04:24 Changeset [109901] by ossy@webkit.org
  • 2 edits in trunk/Tools

Qt API test buildstep throws exception after buildmaster update
https://bugs.webkit.org/show_bug.cgi?id=80249

This patch based on Peter Gal's work.

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2012-03-06
Reviewed by Csaba Osztrogonác.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunQtAPITests):
(BuildAndTestFactory.init): Enable API tests on the Qt platform again.

04:19 WebKit Team edited by ahf@0x90.dk
Add myself to the team list. (diff)
04:15 Changeset [109900] by vestbo@webkit.org
  • 6 edits in trunk/Tools

[Qt] Use correct define names for HAVE(FOO) style optional dependencies

Reviewed by Simon Hausmann.
Reviewed by Ossy.

04:11 Changeset [109899] by podivilov@chromium.org
  • 8 edits in trunk

Web Inspector: remove reference to RawSourceCode from UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=80395

Reviewed by Vsevolod Vlasov.

Source/WebCore:

  • inspector/compile-front-end.sh:
  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._handleUISourceCodeListChanged):
(WebInspector.DebuggerPresentationModel.prototype._uiSourceCodeListChanged):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource.didEditScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.continueToLine):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode.prototype._createUISourceCode):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):

LayoutTests:

  • inspector/debugger/raw-source-code.html:
  • inspector/debugger/ui-source-code.html:
04:09 Changeset [109898] by caseq@chromium.org
  • 8 edits in trunk/Source/WebCore

Web Inspector: move timeline panel overview mode toggle buttons to overview sidebar tree
https://bugs.webkit.org/show_bug.cgi?id=80304

Reviewed by Pavel Feldman.

  • inspector/front-end/Images/statusbarButtonGlyphs.png:
  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype._showTimelines):
(WebInspector.TimelineOverviewPane.prototype._showMemoryGraph):
(WebInspector.TimelineOverviewPane.prototype._setVerticalOverview):
(WebInspector.TimelineOverviewPane.prototype._onOverviewModeChanged):
(WebInspector.TimelineOverviewPane.prototype.update):
(WebInspector.TimelineOverviewPane.prototype.reset):
(WebInspector.TimelineOverviewPane.prototype._onWindowChanged):
(WebInspector.TimelineVerticalOverview):
(WebInspector.TimelineOverviewModeSelector):
(WebInspector.TimelineOverviewModeSelector.prototype.addButton):
(WebInspector.TimelineOverviewModeSelector.prototype.get value):
(WebInspector.TimelineOverviewModeSelector.prototype._createButton):
(WebInspector.TimelineOverviewModeSelector.prototype._select):
(WebInspector.TimelineOverviewModeSelector.prototype._onClick):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype.get statusBarItems):
(WebInspector.TimelinePanel.prototype._createStatusbarButtons):
(WebInspector.TimelinePanel.prototype._updateEventDividers):
(WebInspector.TimelinePanel.prototype._glueParentButtonClicked):
(WebInspector.TimelinePanel.prototype.revealRecordAt):

  • inspector/front-end/inspector.css:
  • inspector/front-end/timelinePanel.css:

(.timeline-vertical-overview #timeline-overview-grid):
(.timeline-vertical-overview .timeline-overview-window):
(.timeline-vertical-overview .timeline-overview-dividers-background):
(.timeline-vertical-overview #timeline-overview-memory):
(.timeline-vertical-overview-status-bar-item.toggled-on .glyph):
(.timeline-vertical-overview-bars):
(.timeline-vertical-overview-bars .padding):
(.timeline-vertical-overview-bars .timeline-bar-vertical):
(.timeline.timeline-vertical-overview .resources-divider):
(.sidebar-tree-item .timeline-vertical-overview-status-bar-item):
(.timeline-overview-mode-selector):
(.timeline-overview-mode-selector .glyph):
(.timeline-overview-mode-selector button):
(.timeline-overview-mode-selector button.toggled):
(.timeline-overview-mode-selector button:active):
(.sidebar-tree-item:not(.selected) .timeline-overview-mode-selector button):
(.sidebar-tree-item:not(.selected) .timeline-overview-mode-selector button.toggled):
(.timeline-overview-mode-selector button:first-of-type):
(.timeline-overview-mode-selector button:last-of-type):
(.timeline-mode-vertical-bars .glyph):
(.timeline-mode-horizontal-bars .glyph):

04:04 Changeset [109897] by ahf@0x90.dk
  • 3 edits in trunk/Source/WebCore

Make it explicit when we are allowing updates to the actual backing store or the tile buffers https://bugs.webkit.org/show_bug.cgi?id=80288

Patch by Kenneth Rohde Christiansen and Alexander Færøy.

Reviewed by Noam Rosenthal.

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::isBackingStoreUpdatesSuspended):
(WebCore):
(WebCore::TiledBackingStore::isTileBufferUpdatesSuspended):
(WebCore::TiledBackingStore::startTileBufferUpdateTimer):
(WebCore::TiledBackingStore::startTileCreationTimer):

  • platform/graphics/TiledBackingStore.h:

(TiledBackingStore):

04:03 Changeset [109896] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Don't add recursive qmake_all target if there are no subdirs to recurse

Reviewed by Ossy.

04:00 Changeset [109895] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix after r109877.

  • WebCore.xcodeproj/project.pbxproj: Ensure that headers are copied in to WebCore.framework so that

WebKit can still find them.

03:51 Changeset [109894] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Make sure clean builds are followed by make qmake && make if needed

On non-GNUmake systems we have to run make qmake so that the generated
sources are generated before we run qmake on the target pro files. This
is achieved by using the 'incremental' target.

Reviewed by Ossy.

03:50 WebKit Team edited by kling@webkit.org
(diff)
03:31 Changeset [109893] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove incorrect WTF::Vector traits for CSSProperty.
<http://webkit.org/b/53285>
<rdar://problem/10161286>

Reviewed by Antti Koivisto.

We shouldn't allow copying Vector<CSSProperty> contents around with memcpy()
as CSSProperty has a RefPtr member and this would muck up the refcount.
This was added to facilitate fast comparison of property vectors, and we no
longer use that, so there shouldn't be any performance concerns here.

  • css/CSSProperty.h:
02:56 Changeset [109892] by fpizlo@apple.com
  • 2 edits in trunk/Tools

DumpRenderTree should support preciseTime()
https://bugs.webkit.org/show_bug.cgi?id=80397

Reviewed by Gavin Barraclough.

  • DumpRenderTree/LayoutTestController.cpp:

(preciseTimeCallback):
(LayoutTestController::staticFunctions):

02:50 Changeset [109891] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Gardening, skip some failing tests.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-03-06
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
02:39 Changeset [109890] by ossy@webkit.org
  • 6 edits in trunk/Tools

Unreviewed, rolling out r109887.
http://trac.webkit.org/changeset/109887
https://bugs.webkit.org/show_bug.cgi?id=80402

It broke the build (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-06

  • DumpRenderTree/qt/DumpRenderTree.pro:
  • DumpRenderTree/qt/QtInitializeTestFonts.cpp:

(WebKit::initializeTestFonts):

  • QtTestBrowser/QtTestBrowser.pro:
  • WebKitTestRunner/InjectedBundle/Target.pri:
  • qmake/mkspecs/features/features.prf:
02:17 Changeset [109889] by toyoshim@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

[Chromium] [WebSocket] Add WebSocket extensions query WebKit API
https://bugs.webkit.org/show_bug.cgi?id=80190

Reviewed by Darin Fisher.

  • public/WebSocket.h: Add extensions() declaration.

(WebSocket):

  • src/WebSocketImpl.cpp: Implement extensions() bridge.

(WebKit::WebSocketImpl::extensions):
(WebKit):

  • src/WebSocketImpl.h: Add extensions() declaration.

(WebSocketImpl):

02:03 Changeset [109888] by commit-queue@webkit.org
  • 36 edits in trunk

Unreviewed, rolling out r109837.
http://trac.webkit.org/changeset/109837
https://bugs.webkit.org/show_bug.cgi?id=80399

breaks Mac Productions builds, too late to try and fix it
tonight (Requested by eseidel on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-06

Source/JavaScriptCore:

  • API/tests/JSNode.c:
  • API/tests/JSNodeList.c:
  • Configurations/Base.xcconfig:
  • JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/MacroAssemblerCodeRef.h:
  • bytecompiler/BytecodeGenerator.h:
  • dfg/DFGOperations.cpp:
  • heap/GCAssertions.h:
  • heap/HandleHeap.h:
  • heap/HandleStack.h:
  • heap/MarkedSpace.h:
  • heap/PassWeak.h:
  • heap/Strong.h:
  • heap/Weak.h:
  • jit/HostCallReturnValue.cpp:
  • jit/JIT.cpp:
  • jit/JITStubs.cpp:
  • jit/ThunkGenerators.cpp:
  • parser/Lexer.cpp:
  • runtime/Completion.cpp:
  • runtime/Executable.cpp:
  • runtime/Identifier.h:
  • runtime/InitializeThreading.cpp:
  • runtime/JSDateMath.cpp:
  • runtime/JSGlobalObjectFunctions.cpp:
  • runtime/JSStringBuilder.h:
  • runtime/JSVariableObject.h:
  • runtime/NumberPrototype.cpp:
  • runtime/WriteBarrier.h:
  • tools/CodeProfile.cpp:
  • tools/TieredMMapArray.h:
  • yarr/YarrJIT.cpp:

Tools:

  • Scripts/build-webkit:
02:00 Changeset [109887] by vestbo@webkit.org
  • 6 edits in trunk/Tools

[Qt] Use correct define names for HAVE(FOO) style optional dependencies

Reviewed by Simon Hausmann.

01:49 Changeset [109886] by haraken@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
01:44 Changeset [109885] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Attempt to fix the Qt minimal build.

  • Target.pri:
01:43 Changeset [109884] by rolandsteiner@chromium.org
  • 5 edits in trunk

:scope should behave as :root outside scoped style sheet
https://bugs.webkit.org/show_bug.cgi?id=80389

Source/WebCore:

Fall through to :root implementation if no scope is used.

Reviewed by Antti Koivisto.

Test: fast/css/style-scoped/scope-pseudo.html

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOneSelector):

LayoutTests:

Update test with :scope in global style sheet

Reviewed by Antti Koivisto.

  • fast/css/style-scoped/scope-pseudo-expected.txt:
  • fast/css/style-scoped/scope-pseudo.html:
01:36 Changeset [109883] by ossy@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[Qt][ARM] Speculative buildfix after r109834.

Patch by Zoltan Herczeg <zherczeg@webkit.org> on 2012-03-06
Reviewed by Csaba Osztrogonác.

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::and32):
(MacroAssemblerARM):

01:32 Changeset [109882] by vsevik@chromium.org
  • 6 edits in trunk

Web Inspector: [Regression] Message bubbles are not removed from scripts panel source frames after console was cleared.
https://bugs.webkit.org/show_bug.cgi?id=80275

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._consoleMessagesCleared):

  • inspector/front-end/utilities.js:

LayoutTests:

  • inspector/debugger/source-frame-expected.txt:
  • inspector/debugger/source-frame.html:
01:29 Changeset [109881] by carlosgc@webkit.org
  • 5 edits in trunk/Source/WebKit2

[GTK] Fix several documentation issues in WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=80281

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitFindController.cpp:
  • UIProcess/API/gtk/WebKitNavigationPolicyDecision.cpp:

(webkit_navigation_policy_decision_class_init):

  • UIProcess/API/gtk/WebKitPrintOperation.cpp:
  • UIProcess/API/gtk/WebKitWebView.h:
01:26 Changeset [109880] by carlosgc@webkit.org
  • 9 edits
    3 adds in trunk/Source/WebKit2

[GTK] Use a single signal for script dialogs in WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=80271

Reviewed by Martin Robinson.

Add a new signal WebKitWebView::script-dialog that passes a
WebKitScriptDialog boxed type that can be used to build the dialog
and set the responses. It simplifies the API and makes it bindings
friendly.

  • GNUmakefile.am:
  • UIProcess/API/gtk/WebKitScriptDialog.cpp: Added.

(webkitScriptDialogCopy): Copy method for boxed type.
(webkitScriptDialogFree): Free method for boxed type.
(webkit_script_dialog_get_dialog_type): Return the type of dialog:
alert, confirm or prompt.
(webkit_script_dialog_get_message): Return the message of the dialog.
(webkit_script_dialog_confirm_set_confirmed): Set whether user
confirmed the dialog, for confirm dialogs.
(webkit_script_dialog_prompt_get_default_text): Get the default
text of prompt dialogs.
(webkit_script_dialog_prompt_set_text): Set the text entered by
the user, for prompt dialogs.

  • UIProcess/API/gtk/WebKitScriptDialog.h: Added.
  • UIProcess/API/gtk/WebKitScriptDialogPrivate.h: Added.
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewScriptDialog): Default implementation of
WebKitWebView::script-dialog signal.
(webkit_web_view_class_init): Add WebKitWebView::script-dialog and
remove alert, confirm and propmpt.
(webkitWebViewRunJavaScriptAlert): Create a WebKitScriptDialog and
emit WebKitWebView::script-dialog signal.
(webkitWebViewRunJavaScriptConfirm): Ditto.
(webkitWebViewRunJavaScriptPrompt): Ditto.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new

symbols.

  • UIProcess/API/gtk/docs/webkit2gtk.types: Add webkit_script_dialog_get_type().
  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewJavaScriptDialogs): Update javascript dialog test to
use the new API.

  • UIProcess/API/gtk/webkit2marshal.list:
  • UIProcess/API/gtk/webkit2.h:
01:26 Changeset [109879] by haraken@chromium.org
  • 1 edit
    2 moves
    1 add in trunk/LayoutTests

Unreviewed, gardening.

  • platform/chromium-mac-snowleopard/fast/repaint/transform-rotate-and-remove-expected.png: Added.
  • platform/chromium-win/fast/repaint/transform-rotate-and-remove-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/repaint/transform-rotate-and-remove-expected.png.
  • platform/chromium/fast/repaint/transform-rotate-and-remove-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/repaint/transform-rotate-and-remove-expected.txt.
01:23 Changeset [109878] by kkristof@inf.u-szeged.hu
  • 4 edits in trunk/Tools

[Qt] Create EWS to build WebKit2
https://bugs.webkit.org/show_bug.cgi?id=80277

Reviewed by Csaba Osztrogonác.

  • QueueStatusServer/model/queues.py:

(Queue):

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(QtWK2EWS):

  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

(EarlyWarningSytemTest.test_builder_ewses):

01:22 Changeset [109877] by abarth@webkit.org
  • 14 edits
    77 adds
    75 deletes in trunk/Source/WebCore

Move SQLDatabase code into Modules/webdatabase
https://bugs.webkit.org/show_bug.cgi?id=80393

Reviewed by Kentaro Hara.

There are still a couple (minor) SQLDatabase references from WebCore
proper, but we've gotten this code to the point where it makes sense to
move it into the Modules directory. (This patch just moves code---no
behavior change.)

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • Modules/webdatabase: Added.
  • Modules/webdatabase/AbstractDatabase.cpp: Copied from Source/WebCore/storage/AbstractDatabase.cpp.
  • Modules/webdatabase/AbstractDatabase.h: Copied from Source/WebCore/storage/AbstractDatabase.h.
  • Modules/webdatabase/ChangeVersionWrapper.cpp: Copied from Source/WebCore/storage/ChangeVersionWrapper.cpp.
  • Modules/webdatabase/ChangeVersionWrapper.h: Copied from Source/WebCore/storage/ChangeVersionWrapper.h.
  • Modules/webdatabase/DOMWindowSQLDatabase.cpp: Copied from Source/WebCore/storage/DOMWindowSQLDatabase.cpp.
  • Modules/webdatabase/DOMWindowSQLDatabase.h: Copied from Source/WebCore/storage/DOMWindowSQLDatabase.h.
  • Modules/webdatabase/DOMWindowSQLDatabase.idl: Copied from Source/WebCore/storage/DOMWindowSQLDatabase.idl.
  • Modules/webdatabase/Database.cpp: Copied from Source/WebCore/storage/Database.cpp.
  • Modules/webdatabase/Database.h: Copied from Source/WebCore/storage/Database.h.
  • Modules/webdatabase/Database.idl: Copied from Source/WebCore/storage/Database.idl.
  • Modules/webdatabase/DatabaseAuthorizer.cpp: Copied from Source/WebCore/storage/DatabaseAuthorizer.cpp.
  • Modules/webdatabase/DatabaseAuthorizer.h: Copied from Source/WebCore/storage/DatabaseAuthorizer.h.
  • Modules/webdatabase/DatabaseCallback.h: Copied from Source/WebCore/storage/DatabaseCallback.h.
  • Modules/webdatabase/DatabaseCallback.idl: Copied from Source/WebCore/storage/DatabaseCallback.idl.
  • Modules/webdatabase/DatabaseContext.cpp: Copied from Source/WebCore/storage/DatabaseContext.cpp.
  • Modules/webdatabase/DatabaseContext.h: Copied from Source/WebCore/storage/DatabaseContext.h.
  • Modules/webdatabase/DatabaseDetails.h: Copied from Source/WebCore/storage/DatabaseDetails.h.
  • Modules/webdatabase/DatabaseSync.cpp: Copied from Source/WebCore/storage/DatabaseSync.cpp.
  • Modules/webdatabase/DatabaseSync.h: Copied from Source/WebCore/storage/DatabaseSync.h.
  • Modules/webdatabase/DatabaseSync.idl: Copied from Source/WebCore/storage/DatabaseSync.idl.
  • Modules/webdatabase/DatabaseTask.cpp: Copied from Source/WebCore/storage/DatabaseTask.cpp.
  • Modules/webdatabase/DatabaseTask.h: Copied from Source/WebCore/storage/DatabaseTask.h.
  • Modules/webdatabase/DatabaseThread.cpp: Copied from Source/WebCore/storage/DatabaseThread.cpp.
  • Modules/webdatabase/DatabaseThread.h: Copied from Source/WebCore/storage/DatabaseThread.h.
  • Modules/webdatabase/DatabaseTracker.cpp: Copied from Source/WebCore/storage/DatabaseTracker.cpp.
  • Modules/webdatabase/DatabaseTracker.h: Copied from Source/WebCore/storage/DatabaseTracker.h.
  • Modules/webdatabase/DatabaseTrackerClient.h: Copied from Source/WebCore/storage/DatabaseTrackerClient.h.
  • Modules/webdatabase/OriginQuotaManager.cpp: Copied from Source/WebCore/storage/OriginQuotaManager.cpp.
  • Modules/webdatabase/OriginQuotaManager.h: Copied from Source/WebCore/storage/OriginQuotaManager.h.
  • Modules/webdatabase/OriginUsageRecord.cpp: Copied from Source/WebCore/storage/OriginUsageRecord.cpp.
  • Modules/webdatabase/OriginUsageRecord.h: Copied from Source/WebCore/storage/OriginUsageRecord.h.
  • Modules/webdatabase/SQLCallbackWrapper.h: Copied from Source/WebCore/storage/SQLCallbackWrapper.h.
  • Modules/webdatabase/SQLError.h: Copied from Source/WebCore/storage/SQLError.h.
  • Modules/webdatabase/SQLError.idl: Copied from Source/WebCore/storage/SQLError.idl.
  • Modules/webdatabase/SQLException.cpp: Copied from Source/WebCore/storage/SQLException.cpp.
  • Modules/webdatabase/SQLException.h: Copied from Source/WebCore/storage/SQLException.h.
  • Modules/webdatabase/SQLException.idl: Copied from Source/WebCore/storage/SQLException.idl.
  • Modules/webdatabase/SQLResultSet.cpp: Copied from Source/WebCore/storage/SQLResultSet.cpp.
  • Modules/webdatabase/SQLResultSet.h: Copied from Source/WebCore/storage/SQLResultSet.h.
  • Modules/webdatabase/SQLResultSet.idl: Copied from Source/WebCore/storage/SQLResultSet.idl.
  • Modules/webdatabase/SQLResultSetRowList.cpp: Copied from Source/WebCore/storage/SQLResultSetRowList.cpp.
  • Modules/webdatabase/SQLResultSetRowList.h: Copied from Source/WebCore/storage/SQLResultSetRowList.h.
  • Modules/webdatabase/SQLResultSetRowList.idl: Copied from Source/WebCore/storage/SQLResultSetRowList.idl.
  • Modules/webdatabase/SQLStatement.cpp: Copied from Source/WebCore/storage/SQLStatement.cpp.
  • Modules/webdatabase/SQLStatement.h: Copied from Source/WebCore/storage/SQLStatement.h.
  • Modules/webdatabase/SQLStatementCallback.h: Copied from Source/WebCore/storage/SQLStatementCallback.h.
  • Modules/webdatabase/SQLStatementCallback.idl: Copied from Source/WebCore/storage/SQLStatementCallback.idl.
  • Modules/webdatabase/SQLStatementErrorCallback.h: Copied from Source/WebCore/storage/SQLStatementErrorCallback.h.
  • Modules/webdatabase/SQLStatementErrorCallback.idl: Copied from Source/WebCore/storage/SQLStatementErrorCallback.idl.
  • Modules/webdatabase/SQLStatementSync.cpp: Copied from Source/WebCore/storage/SQLStatementSync.cpp.
  • Modules/webdatabase/SQLStatementSync.h: Copied from Source/WebCore/storage/SQLStatementSync.h.
  • Modules/webdatabase/SQLTransaction.cpp: Copied from Source/WebCore/storage/SQLTransaction.cpp.
  • Modules/webdatabase/SQLTransaction.h: Copied from Source/WebCore/storage/SQLTransaction.h.
  • Modules/webdatabase/SQLTransaction.idl: Copied from Source/WebCore/storage/SQLTransaction.idl.
  • Modules/webdatabase/SQLTransactionCallback.h: Copied from Source/WebCore/storage/SQLTransactionCallback.h.
  • Modules/webdatabase/SQLTransactionCallback.idl: Copied from Source/WebCore/storage/SQLTransactionCallback.idl.
  • Modules/webdatabase/SQLTransactionClient.cpp: Copied from Source/WebCore/storage/SQLTransactionClient.cpp.
  • Modules/webdatabase/SQLTransactionClient.h: Copied from Source/WebCore/storage/SQLTransactionClient.h.
  • Modules/webdatabase/SQLTransactionCoordinator.cpp: Copied from Source/WebCore/storage/SQLTransactionCoordinator.cpp.
  • Modules/webdatabase/SQLTransactionCoordinator.h: Copied from Source/WebCore/storage/SQLTransactionCoordinator.h.
  • Modules/webdatabase/SQLTransactionErrorCallback.h: Copied from Source/WebCore/storage/SQLTransactionErrorCallback.h.
  • Modules/webdatabase/SQLTransactionErrorCallback.idl: Copied from Source/WebCore/storage/SQLTransactionErrorCallback.idl.
  • Modules/webdatabase/SQLTransactionSync.cpp: Copied from Source/WebCore/storage/SQLTransactionSync.cpp.
  • Modules/webdatabase/SQLTransactionSync.h: Copied from Source/WebCore/storage/SQLTransactionSync.h.
  • Modules/webdatabase/SQLTransactionSync.idl: Copied from Source/WebCore/storage/SQLTransactionSync.idl.
  • Modules/webdatabase/SQLTransactionSyncCallback.h: Copied from Source/WebCore/storage/SQLTransactionSyncCallback.h.
  • Modules/webdatabase/SQLTransactionSyncCallback.idl: Copied from Source/WebCore/storage/SQLTransactionSyncCallback.idl.
  • Modules/webdatabase/WorkerContextSQLDatabase.cpp: Copied from Source/WebCore/storage/WorkerContextSQLDatabase.cpp.
  • Modules/webdatabase/WorkerContextSQLDatabase.h: Copied from Source/WebCore/storage/WorkerContextSQLDatabase.h.
  • Modules/webdatabase/WorkerContextSQLDatabase.idl: Copied from Source/WebCore/storage/WorkerContextSQLDatabase.idl.
  • Modules/webdatabase/chromium: Added.
  • Modules/webdatabase/chromium/DatabaseObserver.h: Copied from Source/WebCore/storage/chromium/DatabaseObserver.h.
  • Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp: Copied from Source/WebCore/storage/chromium/DatabaseTrackerChromium.cpp.
  • Modules/webdatabase/chromium/QuotaTracker.cpp: Copied from Source/WebCore/storage/chromium/QuotaTracker.cpp.
  • Modules/webdatabase/chromium/QuotaTracker.h: Copied from Source/WebCore/storage/chromium/QuotaTracker.h.
  • Modules/webdatabase/chromium/SQLTransactionClientChromium.cpp: Copied from Source/WebCore/storage/chromium/SQLTransactionClientChromium.cpp.
  • Target.pri:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.vcproj/copyForwardingHeaders.cmd:
  • WebCore.xcodeproj/project.pbxproj:
  • storage/AbstractDatabase.cpp: Removed.
  • storage/AbstractDatabase.h: Removed.
  • storage/ChangeVersionWrapper.cpp: Removed.
  • storage/ChangeVersionWrapper.h: Removed.
  • storage/DOMWindowSQLDatabase.cpp: Removed.
  • storage/DOMWindowSQLDatabase.h: Removed.
  • storage/DOMWindowSQLDatabase.idl: Removed.
  • storage/Database.cpp: Removed.
  • storage/Database.h: Removed.
  • storage/Database.idl: Removed.
  • storage/DatabaseAuthorizer.cpp: Removed.
  • storage/DatabaseAuthorizer.h: Removed.
  • storage/DatabaseCallback.h: Removed.
  • storage/DatabaseCallback.idl: Removed.
  • storage/DatabaseContext.cpp: Removed.
  • storage/DatabaseContext.h: Removed.
  • storage/DatabaseDetails.h: Removed.
  • storage/DatabaseSync.cpp: Removed.
  • storage/DatabaseSync.h: Removed.
  • storage/DatabaseSync.idl: Removed.
  • storage/DatabaseTask.cpp: Removed.
  • storage/DatabaseTask.h: Removed.
  • storage/DatabaseThread.cpp: Removed.
  • storage/DatabaseThread.h: Removed.
  • storage/DatabaseTracker.cpp: Removed.
  • storage/DatabaseTracker.h: Removed.
  • storage/DatabaseTrackerClient.h: Removed.
  • storage/OriginQuotaManager.cpp: Removed.
  • storage/OriginQuotaManager.h: Removed.
  • storage/OriginUsageRecord.cpp: Removed.
  • storage/OriginUsageRecord.h: Removed.
  • storage/SQLCallbackWrapper.h: Removed.
  • storage/SQLError.h: Removed.
  • storage/SQLError.idl: Removed.
  • storage/SQLException.cpp: Removed.
  • storage/SQLException.h: Removed.
  • storage/SQLException.idl: Removed.
  • storage/SQLResultSet.cpp: Removed.
  • storage/SQLResultSet.h: Removed.
  • storage/SQLResultSet.idl: Removed.
  • storage/SQLResultSetRowList.cpp: Removed.
  • storage/SQLResultSetRowList.h: Removed.
  • storage/SQLResultSetRowList.idl: Removed.
  • storage/SQLStatement.cpp: Removed.
  • storage/SQLStatement.h: Removed.
  • storage/SQLStatementCallback.h: Removed.
  • storage/SQLStatementCallback.idl: Removed.
  • storage/SQLStatementErrorCallback.h: Removed.
  • storage/SQLStatementErrorCallback.idl: Removed.
  • storage/SQLStatementSync.cpp: Removed.
  • storage/SQLStatementSync.h: Removed.
  • storage/SQLTransaction.cpp: Removed.
  • storage/SQLTransaction.h: Removed.
  • storage/SQLTransaction.idl: Removed.
  • storage/SQLTransactionCallback.h: Removed.
  • storage/SQLTransactionCallback.idl: Removed.
  • storage/SQLTransactionClient.cpp: Removed.
  • storage/SQLTransactionClient.h: Removed.
  • storage/SQLTransactionCoordinator.cpp: Removed.
  • storage/SQLTransactionCoordinator.h: Removed.
  • storage/SQLTransactionErrorCallback.h: Removed.
  • storage/SQLTransactionErrorCallback.idl: Removed.
  • storage/SQLTransactionSync.cpp: Removed.
  • storage/SQLTransactionSync.h: Removed.
  • storage/SQLTransactionSync.idl: Removed.
  • storage/SQLTransactionSyncCallback.h: Removed.
  • storage/SQLTransactionSyncCallback.idl: Removed.
  • storage/WorkerContextSQLDatabase.cpp: Removed.
  • storage/WorkerContextSQLDatabase.h: Removed.
  • storage/WorkerContextSQLDatabase.idl: Removed.
  • storage/chromium/DatabaseObserver.h: Removed.
  • storage/chromium/DatabaseTrackerChromium.cpp: Removed.
  • storage/chromium/QuotaTracker.cpp: Removed.
  • storage/chromium/QuotaTracker.h: Removed.
  • storage/chromium/SQLTransactionClientChromium.cpp: Removed.
01:12 Changeset [109876] by tkent@chromium.org
  • 7 edits
    2 adds in trunk

Do not reformat strings in <input type=number> on platforms using LocalizedNumberICU.
https://bugs.webkit.org/show_bug.cgi?id=78326

Reviewed by Hajime Morita.

Source/WebCore:

We had bugs such as stripping leading zeros, dropping lower digits
of large numbers because we parse a user-input string to a double
value, and generate a string from the double value.

In order to avoid such reformatting, we converts number strings by
replacing standard digits to corresponding localized digits.

  • WebCore.gypi: Added LocalizedNumberICU.h
  • platform/text/LocalizedNumberICU.cpp:

(WebCore::ICULocale::ICULocale): Added.
(WebCore::ICULocale::create): A testing factory function.
(WebCore::ICULocale::createForCurrentLocale): A practical factory function.
(WebCore::ICULocale::setDecimalSymbol): Initialize a symbol table.
(WebCore::ICULocale::initializeDecimalFormat): Initialize ICU DecimalFormat.
(WebCore::ICULocale::convertToLocalizedNumber):

Replace characters to corresponding localized characters.

(WebCore::matches): A helper function for convertFromLocalizedNumber.
(WebCore::endsWith): ditto.
(WebCore::ICULocale::determineStartPosition): ditto.
(WebCore::ICULocale::matchedDecimalSymbolIndex): ditto.
(WebCore::ICULocale::convertFromLocalizedNumber):

Replace characters to corresponding standard characters.

(WebCore::currentLocale): Added.
(WebCore::convertToLocalizedNumber): Uses ICULocale::convertToLocalizedNumber.
(WebCore::convertFromLocalizedNumber): Uses ICULocale::convertFromLocalizedNumber.

  • platform/text/LocalizedNumberICU.h: Added.

(ICULocale): Added. This is exposed to WebKit/chromium/tests/LocalizedNumberICUTest.cpp.

Source/WebKit/chromium:

Add a test for WebCore/platform/text/LocalizedNumberICU.

  • WebKit.gypi: Added LocalizedNumberICUTest.cpp
  • tests/LocalizedNumberICUTest.cpp: Added.

LayoutTests:

  • platform/chromium/test_expectations.txt:

Need to do rebaseline for
fast/speech/input-appearance-numberandspeech.html because the
number rounding issue is fixed.

01:07 Changeset [109875] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

Attempt to fix the GTK minimal build
https://bugs.webkit.org/show_bug.cgi?id=80390

Reviewed by Csaba Osztrogonác.

Add some missing ifdefs.

  • Modules/geolocation/NavigatorGeolocation.cpp:
  • Modules/geolocation/NavigatorGeolocation.h:
01:06 Changeset [109874] by mikelawther@chromium.org
  • 3 edits in trunk/LayoutTests

CSS3 calc: rewrite margin test to use getComputedStyle
https://bugs.webkit.org/show_bug.cgi?id=80379

Note that parts of this test still fail, due to yet-to-be-landed CSS3 calc()
functionality (see http://wkb.ug/16662)

Reviewed by Kent Tamura.

  • css3/calc/margin-expected.txt:
  • css3/calc/margin.html:
00:48 Changeset [109873] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

REGRESSION (r109461): broke fast/js/function-dot-arguments-and-caller.html on GTK
https://bugs.webkit.org/show_bug.cgi?id=80117

Unreviewed, unskip the fixed test.

  • platform/gtk/Skipped:
00:10 Changeset [109872] by podivilov@chromium.org
  • 9 edits
    1 add in trunk

Web Inspector: stop using RawSourceCode in BreakpointManager.
https://bugs.webkit.org/show_bug.cgi?id=80286

Reviewed by Vsevolod Vlasov.

Source/WebCore:

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype.uiSourceCodeAdded):
(WebInspector.BreakpointManager.prototype.setBreakpoint):
(WebInspector.BreakpointManager.prototype._materializeBreakpoint):
(WebInspector.BreakpointManager.prototype._breakpointDebuggerLocationChanged):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):

  • inspector/front-end/ScriptMapping.js: Added.

(WebInspector.ScriptMapping):
(WebInspector.ScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ScriptMapping.prototype.uiLocationToRawLocation):
(WebInspector.ScriptMapping.prototype.createLiveLocation):
(WebInspector.ScriptMapping.prototype.uiSourceCodeList):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:

LayoutTests:

  • inspector/debugger/breakpoint-manager.html:
00:04 Changeset [109871] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed windows build fix pt 2.

03/05/12:

23:59 Changeset [109870] by philn@webkit.org
  • 4 edits in trunk/Source/WebCore

WebAudio JSC-related fixes
https://bugs.webkit.org/show_bug.cgi?id=80299

Reviewed by Adam Barth.

  • bindings/js/JSAudioContextCustom.cpp:

(WebCore::JSAudioContextConstructor::constructJSAudioContext):
Wrap the audio context in a DOM wrapper.

  • webaudio/AudioContext.idl: No need to protect EventTarget by V8

guards, I think.

  • webaudio/JavaScriptAudioNode.idl: Ditto.
23:40 Changeset [109869] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed windows build fix pt 1.

23:35 Changeset [109868] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip new crashing tests,
because crashes aren't bugs but features. :)

  • platform/qt-5.0-wk2/Skipped:
23:31 Changeset [109867] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

Element not fully repainted after application and removal of transform
https://bugs.webkit.org/show_bug.cgi?id=61338

Source/WebCore:

Patch by Kishore Bolisetty <kbolisetty@innominds.com> on 2012-03-05
Reviewed by Simon Fraser.
RenderLayer is created and removed when a transform is applied and removed to element.
To render the element properly after removal of transform on it, preferred widths and dimensions of
the element and its containing block needs to be recalculated.

Test: fast/repaint/transform-rotate-and-remove.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore):
(WebCore::RenderBoxModelObject::styleWillChange):
(WebCore::RenderBoxModelObject::styleDidChange):

  • rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):

LayoutTests:

Patch by Kishore Bolisetty <kbolisetty@innominds.com> on 2012-03-05
Reviewed by Simon Fraser.
Test to remove the transform property of an element upon onload event.

  • fast/repaint/transform-rotate-and-remove.html: Added.
  • platform/chromium-linux/fast/repaint/transform-rotate-and-remove-expected.png: Added.
  • platform/chromium-linux/fast/repaint/transform-rotate-and-remove-expected.txt: Added.
23:23 Changeset [109866] by barraclough@apple.com
  • 56 edits in trunk

putByIndex should throw in strict mode
https://bugs.webkit.org/show_bug.cgi?id=80335

Reviewed by Filip Pizlo.

Make the MethodTable PutByIndex trap take a boolean 'shouldThrow' parameter.

Source/JavaScriptCore:

This is a largely mechanical change, simply adding an extra parameter to a number
of functions. Some call sites need perform additional exception checks, and
operationPutByValBeyondArrayBounds needs to know whether it is strict or not.

This patch doesn't fix a missing throw from some cases of shift/unshift (this is
an existing bug), I'll follow up with a third patch to handle that.

  • API/JSObjectRef.cpp:

(JSObjectSetPropertyAtIndex):

  • JSCTypedArrayStubs.h:

(JSC):

  • dfg/DFGOperations.cpp:

(JSC::DFG::putByVal):

  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jsc.cpp:

(GlobalObject::finishCreation):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • runtime/Arguments.cpp:

(JSC::Arguments::putByIndex):

  • runtime/Arguments.h:

(Arguments):

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):

  • runtime/ClassInfo.h:

(MethodTable):

  • runtime/JSArray.cpp:

(JSC::SparseArrayValueMap::put):
(JSC::JSArray::put):
(JSC::JSArray::putByIndex):
(JSC::JSArray::putByIndexBeyondVectorLength):
(JSC::JSArray::push):
(JSC::JSArray::shiftCount):
(JSC::JSArray::unshiftCount):

  • runtime/JSArray.h:

(SparseArrayValueMap):
(JSArray):

  • runtime/JSByteArray.cpp:

(JSC::JSByteArray::putByIndex):

  • runtime/JSByteArray.h:

(JSByteArray):

  • runtime/JSCell.cpp:

(JSC::JSCell::putByIndex):

  • runtime/JSCell.h:

(JSCell):

  • runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::putByIndex):

  • runtime/JSNotAnObject.h:

(JSNotAnObject):

  • runtime/JSONObject.cpp:

(JSC::Walker::walk):

  • runtime/JSObject.cpp:

(JSC::JSObject::putByIndex):

  • runtime/JSObject.h:

(JSC::JSValue::putByIndex):

  • runtime/RegExpConstructor.cpp:

(JSC::RegExpMatchesArray::fillArrayInstance):

  • runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::putByIndex):

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncSplit):

Source/WebCore:

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneDeserializer::putProperty):

  • bindings/objc/WebScriptObject.mm:

(-[WebScriptObject setWebScriptValueAtIndex:value:]):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bridge/NP_jsobject.cpp:

(_NPN_SetProperty):

  • bridge/jni/jni_jsobject.mm:

(JavaJSObject::setSlot):

  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::putByIndex):

  • bridge/runtime_array.h:

(RuntimeArray):

Source/WebKit/mac:

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::setProperty):

Source/WebKit2:

  • WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::setProperty):

LayoutTests:

  • fast/js/Object-defineProperty-expected.txt:
  • fast/js/mozilla/strict/15.4.4.12-expected.txt:
  • fast/js/mozilla/strict/15.4.4.13-expected.txt:
  • fast/js/mozilla/strict/15.4.4.8-expected.txt:
  • fast/js/mozilla/strict/15.4.4.9-expected.txt:
  • fast/js/mozilla/strict/15.5.5.2-expected.txt:
  • fast/js/mozilla/strict/8.12.5-expected.txt:
  • fast/js/preventExtensions-expected.txt:
  • fast/js/primitive-property-access-edge-cases-expected.txt:
    • Checking in passing test results.
  • fast/js/script-tests/Object-defineProperty.js:
    • Added test cases for putting to numeric properties where property is read-only, length is read-only, or property is accessor with missing set function.
  • fast/js/script-tests/preventExtensions.js:
    • Added test case, putting numeric property to non-extensible array.
  • fast/js/script-tests/primitive-property-access-edge-cases.js:
    • Enabled test cases for putting numeric properties to primitive strings.
23:02 Changeset [109865] by yuqiang.xian@intel.com
  • 2 edits in trunk/Source/JavaScriptCore

PredictNone is incorrectly treated as isDoublePrediction
https://bugs.webkit.org/show_bug.cgi?id=80365

Reviewed by Filip Pizlo.

Also it is incorrectly treated as isFixedIndexedStorageObjectPrediction.

  • bytecode/PredictedType.h:

(JSC::isFixedIndexedStorageObjectPrediction):
(JSC::isDoublePrediction):

22:59 Changeset [109864] by shinyak@chromium.org
  • 3 edits in trunk/Source/WebCore

InsertionPoint::attach should be consistent with Element.
https://bugs.webkit.org/show_bug.cgi?id=80373

Reviewed by Hajime Morita.

This patch is preparation for coming <shadow> patches.

InsertionPoint used to attach fallback elements before attaching distributed elements.
To be consistent with Element::attach behavior, attaching distributed elements first is
natural, because Element attaches a shadow tree first.

Also, this patch extracts a few methods form InsretionPoint::attach() and detach()
to keep code clean. They will become messy without this refactoring when adding
<shadow> patch.

No new tests. Should be covered by existing tests.

  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::attach):
(WebCore::InsertionPoint::detach):
(WebCore::InsertionPoint::distributeHostChildren):
(WebCore):
(WebCore::InsertionPoint::clearDistribution):
(WebCore::InsertionPoint::attachDistributedNode):

  • html/shadow/InsertionPoint.h:

(InsertionPoint):

22:54 Changeset [109863] by fpizlo@apple.com
  • 16 edits in trunk/Source/JavaScriptCore

The LLInt should work even when the JIT is disabled
https://bugs.webkit.org/show_bug.cgi?id=80340
<rdar://problem/10922235>

Reviewed by Gavin Barraclough.

  • assembler/MacroAssemblerCodeRef.h:

(JSC::MacroAssemblerCodePtr::createLLIntCodePtr):
(MacroAssemblerCodeRef):
(JSC::MacroAssemblerCodeRef::createLLIntCodeRef):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::initialize):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):

  • jit/JIT.h:

(JSC::JIT::compileCTINativeCall):

  • jit/JITStubs.h:

(JSC::JITThunks::ctiNativeCall):
(JSC::JITThunks::ctiNativeConstruct):

  • llint/LLIntEntrypoints.cpp:

(JSC::LLInt::getFunctionEntrypoint):
(JSC::LLInt::getEvalEntrypoint):
(JSC::LLInt::getProgramEntrypoint):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(LLInt):

  • llint/LLIntSlowPaths.h:

(LLInt):

  • llint/LowLevelInterpreter.h:
  • llint/LowLevelInterpreter32_64.asm:
  • runtime/Executable.h:

(NativeExecutable):
(JSC::NativeExecutable::create):
(JSC::NativeExecutable::finishCreation):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSGlobalData):

  • runtime/Options.cpp:

(Options):
(JSC::Options::parse):
(JSC::Options::initializeOptions):

  • runtime/Options.h:

(Options):

  • wtf/Platform.h:
22:45 EWS edited by abarth@webkit.org
(diff)
22:40 EWS created by eric@webkit.org
22:31 Changeset [109862] by ossy@webkit.org
  • 6 edits
    2 deletes in trunk/Tools

Unreviewed, rolling out r109733.
http://trac.webkit.org/changeset/109733
https://bugs.webkit.org/show_bug.cgi?id=80378

It broke Qt5 build system (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-05

  • Tools.pro:
  • qmake/config.tests/gccdepends/empty.cpp: Removed.
  • qmake/config.tests/gccdepends/gccdepends.pro: Removed.
  • qmake/mkspecs/features/default_pre.prf:
  • qmake/mkspecs/features/features.prf:
  • qmake/mkspecs/features/unix/default_pre.prf:
  • qmake/sync.profile:
22:28 WikiStart edited by eric@webkit.org
Add a page about the EWS bots. (diff)
22:21 Changeset [109861] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Attempt to fix a number of GTK tests.

  • GNUmakefile.list.am:
22:16 Changeset [109860] by joepeck@webkit.org
  • 21 edits in trunk/Source

Unreviewed rollout of r109858 for restructuring.

22:11 Changeset [109859] by yuqiang.xian@intel.com
  • 2 edits in trunk/Source/JavaScriptCore

Checks for dead variables are not sufficient when fixing the expected
values in DFG OSR entry
https://bugs.webkit.org/show_bug.cgi?id=80371

Reviewed by Filip Pizlo.

A dead variable should be identified when there's no node referencing it.
But we currently failed to catch the case where there are some nodes
referencing a variable but those nodes are actually not referenced by
others so will be ignored in code generation. In such case we should
also consider that variable to be a dead variable in the block and fix
the expected values.
This is performance neutral on SunSpider, V8 and Kraken.

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::noticeOSREntry):

22:03 Changeset [109858] by joepeck@webkit.org
  • 21 edits in trunk/Source

<http://webkit.org/b/78575> Web Inspector: Hide dock button when not allowed to dock

Source/WebCore:

There are times when an undocked inspector frontend is not allowed to
attach to the main window. We can remove the dock button in those cases.

Reviewed by Timothy Hatcher.

No new tests. This functionality is port specific right now.

  • page/FrameView.cpp:

(WebCore::FrameView::performPostLayoutTasks):
When the main frame is resized we let the inspector frontend client
update its docked availability.

  • WebCore.exp.in:
  • inspector/InspectorInstrumentation.h:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didResizeMainFrameImpl):
(WebCore::InspectorInstrumentation::didResizeMainFrame):

  • inspector/InspectorClient.h:

(WebCore::InspectorClient::updateDockingAvailability):

  • inspector/InspectorController.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::resume):
(WebCore::InspectorController::updateDockingAvailability):
When the main frame is resized call up to the InspectorClient to let
it update docking availability of the inspector frontend.

  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendClientLocal.h:
  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::frontendLoaded):
(WebCore::InspectorFrontendClientLocal::setDockingUnavailable):
On ports where the inspector frontend client is local, provide a
setDockingUnavailable InspectorFrontendAPI to update the docking state.
Automatically update availablity when the frontend completes loading.

  • inspector/front-end/InspectorFrontendAPI.js:

(InspectorFrontendAPI.setDockingUnavailable):

  • inspector/front-end/inspector.js:

(WebInspector._createGlobalStatusBarItems):
(WebInspector.setAttachedWindow):
(WebInspector.setDockingUnavailable):
(WebInspector.updateDockToggleButtonVisibility):
Update the dock button's visibility when its created, when the attached
state changes, when get a frontend API notification that we cannot attach.

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.h:

(WebInspectorClient):

  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorClient::updateDockingAvailability):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::updateDockingAvailability):

  • WebProcess/WebCoreSupport/WebInspectorClient.h:
  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::updateDockingAvailability):

  • WebProcess/WebPage/WebInspector.h:
21:26 Changeset [109857] by lforschler@apple.com
  • 2 edits in tags/Safari-536.2.1/Source/WebCore

Merged r109847.

21:24 Changeset [109856] by lforschler@apple.com
  • 10 edits in tags/Safari-536.2.1/Source

Merged r109843.

21:23 Changeset [109855] by lforschler@apple.com
  • 7 edits in tags/Safari-536.2.1/Source

Merged r109812.

21:20 Changeset [109854] by lforschler@apple.com
  • 6 edits in tags/Safari-536.2.1/Source

Merged r109801.

21:19 Changeset [109853] by lforschler@apple.com
  • 12 edits in tags/Safari-536.2.1/Source/WebCore

Merged r109788.

21:15 Changeset [109852] by lforschler@apple.com
  • 6 edits
    4 copies in tags/Safari-536.2.1

Merged r109594.

21:13 Changeset [109851] by enne@google.com
  • 7 edits
    4 adds in trunk

Compositing overlap testing can throw layers into compositing when they should not be.
https://bugs.webkit.org/show_bug.cgi?id=50192

Reviewed by Simon Fraser.

Source/WebCore:

The previous overlap map behavior was that a non-composited query
layer would become composited due to overlap if and only if the query
layer's absolute bounds overlapped the absolute bounds of some other
layer which:

  • draws before the query layer
  • is or has a compositing ancestor

This behavior, while correct, was too permissive in throwing layers
into compositing, causing many layers to get their own backing when
they could have just gone into their compositing ancestor's backing.

The correct logic is that non-composited query layer needs to be
composited due to overlap if and only if the query layer's absolute
bounds overlap the absolute bounds of some other layer which:

  • draws before the query layer
  • has a different compositing ancestor than the query layer
  • is or has a compositing ancestor that is a descendent of the query layer's compositing ancestor

This patch changes the semantics of the overlap map to enable this
behavior.

Rather than having one global overlap map, there is now a stack of
overlap maps. New (empty) overlap maps are pushed onto the stack
whenever a layer becomes a compositing ancestor and popped after all
of the compositing requirements for that layer's children have been
computed.

The compositing ancestor and all of its non-composited children of a
compositing ancestor do not get considered for overlap until their
composited ancestor has been popped off the stack. If a compositing
ancestor has a compositing subtree, then any descendents of that
compositing ancestor that draw after that subtree will consider
everything in the compositing subtree for overlap.

Test: compositing/layer-creation/stacking-context-overlap.html

  • platform/graphics/Region.cpp:

(WebCore::Region::intersects):
(WebCore):

  • platform/graphics/Region.h:

(Region):

  • rendering/RenderLayerCompositor.cpp:

(RenderLayerCompositor::OverlapMap):
(WebCore::RenderLayerCompositor::OverlapMap::OverlapMap):
(WebCore::RenderLayerCompositor::OverlapMap::add):
(WebCore::RenderLayerCompositor::OverlapMap::contains):
(WebCore::RenderLayerCompositor::OverlapMap::overlapsLayers):
(WebCore::RenderLayerCompositor::OverlapMap::isEmpty):
(WebCore::RenderLayerCompositor::OverlapMap::popCompositingContainer):
(WebCore::RenderLayerCompositor::OverlapMap::pushCompositingContainer):
(WebCore::RenderLayerCompositor::addToOverlapMapRecursive):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

LayoutTests:

  • compositing/layer-creation/stacking-context-overlap-expected.txt: Added.
  • compositing/layer-creation/stacking-context-overlap.html: Added.
  • compositing/layer-creation/stacking-context-overlap-nested-expected.txt: Added.
  • compositing/layer-creation/stacking-context-overlap-nested.html: Added.
  • platform/chromium/test_expectations.txt:
21:09 Changeset [109850] by lforschler@apple.com
  • 2 edits in tags/Safari-536.2.1/Source/WebCore

Merged r109486.

21:07 Changeset [109849] by lforschler@apple.com
  • 4 edits in tags/Safari-536.2.1/Source

Versioning.

21:04 Changeset [109848] by lforschler@apple.com
  • 2 edits in tags/Safari-536.2.1/Source/WebCore

Merged r109379.

20:57 Changeset [109847] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Address review comments from https://bugs.webkit.org/show_bug.cgi?id=80368

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::setNeedsDisplayInRect):

20:54 Changeset [109846] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[Forms] HTMLFieldSetForms.idl doesn't have type attribute.
https://bugs.webkit.org/show_bug.cgi?id=80109

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-05
Reviewed by Hajime Morita.

Source/WebCore:

Test: fast/forms/fieldset/fieldset-type.html

  • html/HTMLFieldSetElement.idl: Add attribute "type"

LayoutTests:

  • fast/forms/fieldset/fieldset-type-expected.txt: Added.
  • fast/forms/fieldset/fieldset-type.html: Added.
20:54 Changeset [109845] by oliver@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Fix Qt build.

20:51 Changeset [109844] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix build.

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::setScale):

20:33 Changeset [109843] by andersca@apple.com
  • 10 edits in trunk/Source

pinch-to-zoom and double-tap flicker when using the new scrolling model
https://bugs.webkit.org/show_bug.cgi?id=80368
<rdar://problem/10866221>

Reviewed by Sam Weinig.

Source/WebCore:

In order to work better with zooming, make the tile cache undo the scale transformation
and handle the scaling manually. This avoids creating huge tile backing stores when zoomed in.

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::TileCache):
Initialize m_scale to 1.

(WebCore::TileCache::setNeedsDisplayInRect):
Scale the given rect appropriately.

(WebCore::TileCache::drawLayer):
Apply a scale context transform.

(WebCore::TileCache::setScale):
No longer set the contents scale. Instead, update the scale and revalidate the tiles.

(WebCore::TileCache::revalidateTiles):
Return early if the bounds are empty. This avoids showing a single tile if that happens due to a race condition.

(WebCore::TileCache::getTileIndexRangeForRect):
Apply the scale to the bounds.

(WebCore::TileCache::createTileLayer):
Don't set the contents scale.

  • platform/graphics/ca/mac/WebTileCacheLayer.mm:

(-[WebTileCacheLayer setContentsScale:]):
Call TileCache::setScale.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateCompositedBounds):
Make sure to give the tile cache layer sane composited bounds, even if the page has absolutely positioned
elements that are outside of the page.

Source/WebKit2:

Add a way for drawing areas to respond to callback based force repaint requests asynchronously.
This is currently needed for the tiled drawing area when there might be outstanding scroll updates
that are sent from the scrolling thread to the main thread and we need to ensure that they're processed
before sending a message back.

  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::forceRepaintAsync):
Add new member function.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::forceRepaint):
Try forceRepaintAsync first.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::forceRepaintAndSendMessage):
Force the repaint and send the message.

(WebKit::dispatchBackToMainThread):
Dispatch a call to forceRepaintAndSendMessage to the main thread.

(WebKit::TiledCoreAnimationDrawingArea::forceRepaintAsync):
Dispatch a function on the scrolling thread. Its sole purpose is to dispatch a function back to the
main thread, ensuring that all previously dispatched functions have been executed.

20:32 Changeset [109842] by lforschler@apple.com
  • 1 copy in tags/Safari-536.2.1

New Tag.

20:24 Changeset [109841] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

GraphicsContext3D.h should include RefCounted.h explicitly
https://bugs.webkit.org/show_bug.cgi?id=80251

Reviewed by Rob Buis.

GraphicsContext3D.h was using RefCounted but including RefCounted.h indirectly
through GraphicsLayer.h through Animation.h. However Animation.h is included
by GraphicsLayer.h only when ACCELERATED_COMPOSITING is on. For some configurations
that don't use ACCELERATED_COMPOSITING but use GraphicsContext3D, like the
BlackBerry x86 configuration, the indirect inclusion will fail.

This patch is adding explicit inclusion of RefCounted.h to avoid that kind of
problem.

  • platform/graphics/GraphicsContext3D.h:
20:20 Changeset [109840] by bashi@chromium.org
  • 6 edits
    4 adds in trunk

[WebSocket] Should raise SYNTAX_ERR when message contains unpaired surrogates
https://bugs.webkit.org/show_bug.cgi?id=80103

Reviewed by Kent Tamura.

Source/WebCore:

Add UTF8 validation checks for WebSocket message and close reason.

Tests: http/tests/websocket/tests/hybi/unpaired-surrogates-in-close-reason.html

http/tests/websocket/tests/hybi/unpaired-surrogates-in-message.html

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::send): Raise SYNTAX_ERR if the message is invalid.
(WebCore::WebSocket::close):Raise SYNTAX_ERR if the reason is invalid.

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::send): Check whether message is a valid UTF8 string.

LayoutTests:

Added tests for unpaired surrogates check for WebSocket message and close reason.
Updated two expectations for close() tests because further error message is added.

  • http/tests/websocket/tests/hybi/close-expected.txt: Updated.
  • http/tests/websocket/tests/hybi/unpaired-surrogates-in-close-reason-expected.txt: Added.
  • http/tests/websocket/tests/hybi/unpaired-surrogates-in-close-reason.html: Added.
  • http/tests/websocket/tests/hybi/unpaired-surrogates-in-message-expected.txt: Added.
  • http/tests/websocket/tests/hybi/unpaired-surrogates-in-message.html: Added.
  • http/tests/websocket/tests/hybi/workers/close-expected.txt: Updated.
20:15 Changeset [109839] by kbr@google.com
  • 10 edits in trunk/Source

[chromium] Notify CCLayerImpl tree of context loss and restoration
https://bugs.webkit.org/show_bug.cgi?id=80339

Reviewed by James Robinson.

Source/WebCore:

Tested by manually killing GPU process while playing Flash video.
Video continues to play after compositor restores its context.

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::didLoseAndRecreateGraphicsContext):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::sendContextLostAndRestoredNotification):
(WebCore):
(WebCore::CCLayerTreeHostImpl::sendContextLostAndRestoredNotificationRecursive):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:

(WebCore::CCPluginLayerImpl::didLoseAndRecreateGraphicsContext):
(WebCore):

  • platform/graphics/chromium/cc/CCPluginLayerImpl.h:

(CCPluginLayerImpl):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::recreateContext):

Source/WebKit/chromium:

Unit test for notification of context loss and restoration.

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit):
(ContextLostNotificationCheckLayer):
(WebKit::ContextLostNotificationCheckLayer::create):
(WebKit::ContextLostNotificationCheckLayer::didLoseAndRecreateGraphicsContext):
(WebKit::ContextLostNotificationCheckLayer::didLoseAndRecreateGraphicsContextCalled):
(WebKit::ContextLostNotificationCheckLayer::ContextLostNotificationCheckLayer):
(WebKit::TEST_F):

20:02 Changeset [109838] by commit-queue@webkit.org
  • 12 edits in trunk/Source

Change the argument orders to match OpenGL's in GraphicsContext3D functions
https://bugs.webkit.org/show_bug.cgi?id=80120

Patch by Changhun Kang <temoochin@company100.net> on 2012-03-05
Reviewed by Kenneth Russell.

No new tests because this patch just change the order of arguments.

Source/WebCore:

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::uniform1fv):
(WebCore::WebGLRenderingContext::uniform1iv):
(WebCore::WebGLRenderingContext::uniform2fv):
(WebCore::WebGLRenderingContext::uniform2iv):
(WebCore::WebGLRenderingContext::uniform3fv):
(WebCore::WebGLRenderingContext::uniform3iv):
(WebCore::WebGLRenderingContext::uniform4fv):
(WebCore::WebGLRenderingContext::uniform4iv):
(WebCore::WebGLRenderingContext::uniformMatrix2fv):
(WebCore::WebGLRenderingContext::uniformMatrix3fv):
(WebCore::WebGLRenderingContext::uniformMatrix4fv):

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawDebugBorderQuad):
(WebCore::LayerRendererChromium::drawTileQuad):
(WebCore::LayerRendererChromium::drawYUV):
(WebCore::LayerRendererChromium::drawStreamTexture):
(WebCore::LayerRendererChromium::drawTexturedQuad):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::drawSurface):

  • platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::uniform1fv):
(WebCore::GraphicsContext3D::uniform1iv):
(WebCore::GraphicsContext3D::uniform2fv):
(WebCore::GraphicsContext3D::uniform2iv):
(WebCore::GraphicsContext3D::uniform3fv):
(WebCore::GraphicsContext3D::uniform3iv):
(WebCore::GraphicsContext3D::uniform4fv):
(WebCore::GraphicsContext3D::uniform4iv):
(WebCore::GraphicsContext3D::uniformMatrix2fv):
(WebCore::GraphicsContext3D::uniformMatrix3fv):
(WebCore::GraphicsContext3D::uniformMatrix4fv):

  • platform/graphics/filters/FECustomFilter.cpp:

(WebCore::FECustomFilter::bindProgramAndBuffers):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::uniform1fv):
(WebCore::GraphicsContext3D::uniform2fv):
(WebCore::GraphicsContext3D::uniform3fv):
(WebCore::GraphicsContext3D::uniform4fv):
(WebCore::GraphicsContext3D::uniform1iv):
(WebCore::GraphicsContext3D::uniform2iv):
(WebCore::GraphicsContext3D::uniform3iv):
(WebCore::GraphicsContext3D::uniform4iv):
(WebCore::GraphicsContext3D::uniformMatrix2fv):
(WebCore::GraphicsContext3D::uniformMatrix3fv):
(WebCore::GraphicsContext3D::uniformMatrix4fv):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::uniform1fv):
(WebCore::GraphicsContext3D::uniform2fv):
(WebCore::GraphicsContext3D::uniform3fv):
(WebCore::GraphicsContext3D::uniform4fv):
(WebCore::GraphicsContext3D::uniform1iv):
(WebCore::GraphicsContext3D::uniform2iv):
(WebCore::GraphicsContext3D::uniform3iv):
(WebCore::GraphicsContext3D::uniform4iv):
(WebCore::GraphicsContext3D::uniformMatrix2fv):
(WebCore::GraphicsContext3D::uniformMatrix3fv):
(WebCore::GraphicsContext3D::uniformMatrix4fv):

Source/WebKit/chromium:

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DPrivate::uniform1fv):
(WebCore::GraphicsContext3DPrivate::uniform1iv):
(WebCore::GraphicsContext3DPrivate::uniform2fv):
(WebCore::GraphicsContext3DPrivate::uniform2iv):
(WebCore::GraphicsContext3DPrivate::uniform3fv):
(WebCore::GraphicsContext3DPrivate::uniform3iv):
(WebCore::GraphicsContext3DPrivate::uniform4fv):
(WebCore::GraphicsContext3DPrivate::uniform4iv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix2fv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix3fv):
(WebCore::GraphicsContext3DPrivate::uniformMatrix4fv):
(WebCore):

  • src/GraphicsContext3DPrivate.h:

(GraphicsContext3DPrivate):

19:37 Changeset [109837] by eric@webkit.org
  • 36 edits in trunk

Source/JavaScriptCore: Update JavaScriptCore files to use fully-qualified WTF include paths
https://bugs.webkit.org/show_bug.cgi?id=79960

Reviewed by Adam Barth.

This change does 5 small/related things:

  1. Updates JavaScriptCore.xcodeproj to install WTF headers into $BUILD/usr/local/include (WebCore, WebKit were already setup to look there, but JavaScriptCore.xcodeproj was not installing headers there.)
  2. Makes JavaScriptCore targets include $BUILD/usr/local/include in their header search path, as that's where the WTF headers will be installed.
  3. Similarly updates JavaScriptCore.vcproj/copy-files.cmd to copy WTF headers to PrivateHeaders/wtf/* in addition to the current behavior of flattening all headers to PrivateHeaders/*.h.
  4. Updates a bunch of JSC files to use #include <wtf/Foo.h> instead of #include "Foo.h" since soon the WTF headers will not be part of the JavaScriptCore Xcode project.
  5. Makes build-webkit build the WTF XCode project by default.
  • API/tests/JSNode.c:
  • API/tests/JSNodeList.c:
  • Configurations/Base.xcconfig:
  • assembler/MacroAssemblerCodeRef.h:
  • bytecompiler/BytecodeGenerator.h:
  • dfg/DFGOperations.cpp:
  • heap/GCAssertions.h:
  • heap/HandleHeap.h:
  • heap/HandleStack.h:
  • heap/MarkedSpace.h:
  • heap/PassWeak.h:
  • heap/Strong.h:
  • heap/Weak.h:
  • jit/HostCallReturnValue.cpp:
  • jit/JIT.cpp:
  • jit/JITStubs.cpp:
  • jit/ThunkGenerators.cpp:
  • parser/Lexer.cpp:
  • runtime/Completion.cpp:
  • runtime/Executable.cpp:
  • runtime/Identifier.h:
  • runtime/InitializeThreading.cpp:
  • runtime/JSDateMath.cpp:
  • runtime/JSGlobalObjectFunctions.cpp:
  • runtime/JSStringBuilder.h:
  • runtime/JSVariableObject.h:
  • runtime/NumberPrototype.cpp:
  • runtime/WriteBarrier.h:
  • tools/CodeProfile.cpp:
  • tools/TieredMMapArray.h:
  • yarr/YarrJIT.cpp:

Tools: Update JavaScriptCore files to use fully-qualified WTF include path
https://bugs.webkit.org/show_bug.cgi?id=79960

Reviewed by Adam Barth.

Build WTF/WTF.xcodeproj by default on Mac.

  • Scripts/build-webkit:
19:07 Changeset [109836] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Source/WebCore: [Forms] HTMLFieldSetForms.idl doesn't have name attribute.
https://bugs.webkit.org/show_bug.cgi?id=80108

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-05
Reviewed by Hajime Morita.

Test: fast/forms/fieldset/fieldset-name.html

  • html/HTMLFieldSetElement.idl: Add "name" attribute.

LayoutTests: [Forms] HTMLFieldSetForms.idl doesn't have name attribute.
https://bugs.webkit.org/show_bug.cgi?id=81008

Test read/write attribute "name" of fieldset element.

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-05
Reviewed by Hajime Morita.

  • fast/forms/fieldset/fieldset-name-expected.txt: Added.
  • fast/forms/fieldset/fieldset-name.html: Added.
18:42 Changeset [109835] by leviw@chromium.org
  • 6 edits in trunk/Source/WebCore

Update usage of LayoutUnits in RenderBox
https://bugs.webkit.org/show_bug.cgi?id=80039

Reviewed by Julien Chaffraix.

Updating the usage of integers versus LayoutUnits in RenderBox to mirror the
subpixellayout branch. This reverts absoluteRects, intrinsicSize, and focusRingRects
methods to use integers, and flipForWritingMode functions to LayoutUnits.

No new tests. No change in behavior.

  • platform/graphics/FractionalLayoutRect.h:

(WebCore::FractionalLayoutRect::pixelSnappedX): Convenience methods that only calculate
the needed values. This requires less computation than pixelSnappedIntRect(r).x().
(WebCore::FractionalLayoutRect::pixelSnappedY): Ditto.
(WebCore::FractionalLayoutRect::pixelSnappedWidth): Ditto.
(WebCore::FractionalLayoutRect::pixelSnappedHeight): Ditto.
(WebCore::FractionalLayoutRect::pixelSnappedMaxX): Ditto.
(WebCore::FractionalLayoutRect::pixelSnappedMaxY): Ditto.
(FractionalLayoutRect):

  • platform/graphics/IntRect.h:

(IntRect):
(WebCore::IntRect::pixelSnappedX): Stub methods to allow us to use IntRects like we do
FractionalLayoutRects.
(WebCore::IntRect::pixelSnappedY): Ditto.
(WebCore::IntRect::pixelSnappedMaxX): Ditto.
(WebCore::IntRect::pixelSnappedMaxY): Ditto.
(WebCore::IntRect::pixelSnappedWidth): Ditto.
(WebCore::IntRect::pixelSnappedHeight): Ditto.

  • rendering/LayoutTypes.h:

(WebCore::pixelSnappedIntRect): Convenience method for building a pixelSnappedIntRect from
a LayoutPoint and LayoutSize without constructing an intermediate LayoutRect.
(WebCore):
(WebCore::snapSizeToPixel): Stub method for snapping a LayoutUnit representing a size to
its pixel value using its location.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::pixelSnappedClientWidth): Changing to actually call snapSizeToPixel.
(WebCore::RenderBox::pixelSnappedClientHeight): Ditto.
(WebCore::RenderBox::absoluteRects): Switching to return IntRects that represent the actual
rendered location on screen.
(WebCore::RenderBox::addFocusRingRects): Ditto.
(WebCore::RenderBox::paintFillLayer): One-liner switching an IntSize() to LayoutSize() to
avoid unnecessary conversion.
(WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats): Preparing for the conversion by
replacing 0 with zeroLayoutUnit.
(WebCore::RenderBox::positionLineBox): Preparing for conversion by replacing lroundf
with roundedLayoutUnit.
(WebCore::RenderBox::flipForWritingMode): Switching to use LayoutUnits.

  • rendering/RenderBox.h:

(RenderBox):
(WebCore::RenderBox::pixelSnappedBorderBoxRect): Convenience method.
(WebCore::RenderBox::borderBoundingBox): Converting to a pixelSnappedIntRect.
(WebCore::RenderBox::intrinsicSize): Intrinsic sizes should always be integers.

18:40 Changeset [109834] by oliver@apple.com
  • 22 edits in trunk/Source/JavaScriptCore

Add basic support for constant blinding to the JIT
https://bugs.webkit.org/show_bug.cgi?id=80354

Reviewed by Filip Pizlo.

This patch adds basic constant blinding support to the JIT, at the
MacroAssembler level. This means all JITs in JSC (Yarr, baseline, and DFG)
get constant blinding. Woo!

This patch only introduces blinding for Imm32, a later patch will do similar
for ImmPtr. In order to make misuse of Imm32 as a trusted type essentially
impossible, we make TrustedImm32 a private parent of Imm32 and add an explicit
accessor that's needed to access the actual value. This also means you cannot
accidentally pass an untrusted value to a function that does not perform
blinding.

To make everything work sensibly, this patch also corrects some code that was using
Imm32 when TrustedImm32 could be used, and refactors a few callers that use
untrusted immediates, so that they call slightly different varaints of the functions
that they used previously. This is largely necessary to deal with x86-32 not having
sufficient registers to handle the additional work required when we choose to blind
a constant.

  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::Imm32::asTrustedImm32):
(Imm32):
(JSC::AbstractMacroAssembler::beginUninterruptedSequence):
(JSC::AbstractMacroAssembler::endUninterruptedSequence):
(JSC::AbstractMacroAssembler::AbstractMacroAssembler):
(AbstractMacroAssembler):
(JSC::AbstractMacroAssembler::inUninterruptedSequence):
(JSC::AbstractMacroAssembler::random):
(JSC::AbstractMacroAssembler::scratchRegisterForBlinding):
(JSC::AbstractMacroAssembler::shouldBlindForSpecificArch):

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::addressForPoke):
(MacroAssembler):
(JSC::MacroAssembler::poke):
(JSC::MacroAssembler::branchPtr):
(JSC::MacroAssembler::branch32):
(JSC::MacroAssembler::convertInt32ToDouble):
(JSC::MacroAssembler::shouldBlind):
(JSC::MacroAssembler::BlindedImm32::BlindedImm32):
(BlindedImm32):
(JSC::MacroAssembler::keyForConstant):
(JSC::MacroAssembler::xorBlindConstant):
(JSC::MacroAssembler::additionBlindedConstant):
(JSC::MacroAssembler::andBlindedConstant):
(JSC::MacroAssembler::orBlindedConstant):
(JSC::MacroAssembler::loadXorBlindedConstant):
(JSC::MacroAssembler::add32):
(JSC::MacroAssembler::addPtr):
(JSC::MacroAssembler::and32):
(JSC::MacroAssembler::andPtr):
(JSC::MacroAssembler::move):
(JSC::MacroAssembler::or32):
(JSC::MacroAssembler::store32):
(JSC::MacroAssembler::sub32):
(JSC::MacroAssembler::subPtr):
(JSC::MacroAssembler::xor32):
(JSC::MacroAssembler::branchAdd32):
(JSC::MacroAssembler::branchMul32):
(JSC::MacroAssembler::branchSub32):
(JSC::MacroAssembler::trustedImm32ForShift):
(JSC::MacroAssembler::lshift32):
(JSC::MacroAssembler::rshift32):
(JSC::MacroAssembler::urshift32):

  • assembler/MacroAssemblerARMv7.h:

(MacroAssemblerARMv7):
(JSC::MacroAssemblerARMv7::scratchRegisterForBlinding):
(JSC::MacroAssemblerARMv7::shouldBlindForSpecificArch):

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::branchSubPtr):
(MacroAssemblerX86_64):
(JSC::MacroAssemblerX86_64::scratchRegisterForBlinding):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::compileFunction):

  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::compileArithSub):
(JSC::DFG::SpeculativeJIT::compileStrictEqForConstant):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileDoubleCompare):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compileDoubleCompare):
(JSC::DFG::SpeculativeJIT::compile):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):

  • jit/JITArithmetic.cpp:

(JSC::JIT::compileBinaryArithOp):
(JSC::JIT::emit_op_add):
(JSC::JIT::emit_op_mul):
(JSC::JIT::emit_op_div):

  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emitAdd32Constant):
(JSC::JIT::emitSub32Constant):
(JSC::JIT::emitBinaryDoubleOp):
(JSC::JIT::emitSlow_op_mul):
(JSC::JIT::emit_op_div):

  • jit/JITCall.cpp:

(JSC::JIT::compileLoadVarargs):

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileLoadVarargs):

  • jit/JITInlineMethods.h:

(JSC::JIT::updateTopCallFrame):
(JSC::JIT::emitValueProfilingSite):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emitSlow_op_jfalse):
(JSC::JIT::emitSlow_op_jtrue):

  • jit/JITStubCall.h:

(JITStubCall):
(JSC::JITStubCall::addArgument):

  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::backtrack):

18:30 Changeset [109833] by abarth@webkit.org
  • 13 edits
    3 copies in trunk/Source/WebCore

WorkerContext shouldn't need to know about SQLDatabase
https://bugs.webkit.org/show_bug.cgi?id=80352

Reviewed by Eric Seidel.

This patch removes the SQLDatabase functions from WorkerContext in
preparation for moving the SQLDatabase code into a module. These
functions don't interact with the rest of WorkerContext.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • storage/DOMWindowSQLDatabase.cpp:
  • storage/WorkerContextSQLDatabase.cpp: Added.

(WebCore):
(WebCore::WorkerContextSQLDatabase::openDatabase):
(WebCore::WorkerContextSQLDatabase::openDatabaseSync):

  • storage/WorkerContextSQLDatabase.h: Added.

(WebCore):
(WorkerContextSQLDatabase):
(WebCore::WorkerContextSQLDatabase::WorkerContextSQLDatabase):
(WebCore::WorkerContextSQLDatabase::~WorkerContextSQLDatabase):

  • storage/WorkerContextSQLDatabase.idl: Added.
  • workers/WorkerContext.cpp:

(WebCore):

  • workers/WorkerContext.h:

(WebCore):
(WorkerContext):

  • workers/WorkerContext.idl:
18:11 Changeset [109832] by bashi@chromium.org
  • 9 edits in trunk/Source/WebCore

[WebSocket] Introduce ThreadableWebSocketChannel::SendResult
https://bugs.webkit.org/show_bug.cgi?id=80356

Reviewed by Kent Tamura.

Introduced ThreadableWebSocketChannel::SendResult type so that
WebSocketChannel can pass the validation result.

No new test. No changes in behavior.

  • Modules/websockets/ThreadableWebSocketChannel.h: Added SendResult.
  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
(WebCore::ThreadableWebSocketChannelClientWrapper::sendRequestResult): Use ThreadableWebSocketChannel::SendResult instead of bool.
(WebCore::ThreadableWebSocketChannelClientWrapper::setSendRequestResult): Ditto.

  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:

(ThreadableWebSocketChannelClientWrapper):

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::send): Use ThreadableWebSocketChannel::SendResult instead of bool. Pass Cstring to enqueTextFrame instead of String.
(WebCore::WebSocketChannel::enqueueTextFrame): Ditto.
(WebCore::WebSocketChannel::processOutgoingFrameQueue): Ditto.

  • Modules/websockets/WebSocketChannel.h:

(WebSocketChannel):
(QueuedFrame): Changed the type of stringData from String to CString.

  • Modules/websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::send): Use ThreadableWebSocketChannel::SendResult instead of bool.
(WebCore::workerContextDidSend): Ditto.
(WebCore::WorkerThreadableWebSocketChannel::Peer::send): Ditto.
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send): Ditto.

  • Modules/websockets/WorkerThreadableWebSocketChannel.h:

(WorkerThreadableWebSocketChannel): ditto.
(Bridge): Ditto.

18:04 Changeset [109831] by dpranke@chromium.org
  • 3 edits in trunk/Tools

There should be a way to disable optimizer in webkit-patch rebaseline-expectations
https://bugs.webkit.org/show_bug.cgi?id=69590

Reviewed by Ryosuke Niwa.

Adds a --no-optimize flag to webkit-patch rebaseline-expectations
to skip the 'optimize-expectations' step.

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineExpectations.init):
(RebaselineExpectations.execute):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
17:56 Changeset [109830] by tony@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

add tests for multiline flexbox and flex-pack
https://bugs.webkit.org/show_bug.cgi?id=80342

Reviewed by Ojan Vafai.

  • css3/flexbox/multiline-pack-expected.txt: Added.
  • css3/flexbox/multiline-pack.html: Added.
17:51 Changeset [109829] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[JSC] Cache the CSSPropertyID in JSCSSStyleDeclaration
https://bugs.webkit.org/show_bug.cgi?id=80250

Reviewed by Benjamin Poulain.

V8CSSStyleDeclaration caches the calculated CSSPropertyID.
Similarly, we can implement the cache in JSCSSStyleDeclaration.

In my local Mac environment, this optimization improves the performance
of CSS property getters by 35%, and the performance of CSS property setters
by 8%.

CSS property getter: for (var i = 0; i < 1000000; i++) span.style.fontWeight;
CSS property setter: for (var i = 0; i < 1000000; i++) span.style.fontWeight = "bold";

Tests: fast/dom/CSSStyleDeclaration/* (No change in test results)

  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(CSSPropertyInfo):
(WebCore):
(WebCore::cssPropertyIDForJSCSSPropertyName):
(WebCore::JSCSSStyleDeclaration::nameGetter):
(WebCore::JSCSSStyleDeclaration::putDelegate):

17:41 Changeset [109828] by dgrogan@chromium.org
  • 4 edits
    2 adds in trunk/LayoutTests

Basic IndexedDB shared worker test
https://bugs.webkit.org/show_bug.cgi?id=80189

Reviewed by Tony Chang.

  • fast/js/resources/js-test-pre.js:

(startWorker.worker.port.onmessage):

  • platform/chromium/test_expectations.txt:
  • storage/indexeddb/basics-shared-workers-expected.txt: Added.
  • storage/indexeddb/basics-shared-workers.html: Added.
  • storage/indexeddb/resources/shared.js:

(.self.postMessage):
(.self.onconnect.self.postMessage):
(.self.onconnect):
(done):
(unexpectedErrorCallback):

17:38 Changeset [109827] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] WebOptionElement should inherit WebElement instead of WebFormControlElement
https://bugs.webkit.org/show_bug.cgi?id=80089

Change class hierarchy of WebOptionElement to match with specification.

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-05
Reviewed by Darin Fisher.

  • public/WebOptionElement.h: Replace to WebElement from WebFormControlElement

(WebKit::WebOptionElement::WebOptionElement):
(WebKit::WebOptionElement::operator=):
(WebKit::WebOptionElement::assign):

  • src/WebOptionElement.cpp:

(WebKit::WebOptionElement::WebOptionElement):

17:35 Changeset [109826] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

Can't type on some websites (plug-ins steal key events).
<rdar://problem/10892291>

When the plugin is disabled, it is necessary to reset _pluginComplexTextInputIdentifier
in order to return the correct input context. Failure to do so results in the inputContext
method to return the plugin input context instead of the context of the browser view.

Reviewed by Sam Weinig.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _setPluginComplexTextInputState:]):
(-[WKView _handlePluginComplexTextInputKeyDown:]):

17:33 Changeset [109825] by jsbell@chromium.org
  • 6 edits
    1 add in trunk/Source

IndexedDB: Handle LevelDB database corruption
https://bugs.webkit.org/show_bug.cgi?id=79413

Source/WebCore:

Add LevelDBDatabase::destroy() method so that clients can retry if open() fails.

Reviewed by Tony Chang.

Test: webkit_unit_tests --gtest_filter='LevelDBDatabaseTest.CorruptionTest'

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp: Implement open/destroy/open strategy.

(WebCore::IDBLevelDBBackingStore::open):

  • platform/leveldb/LevelDBDatabase.cpp:

(WebCore::LevelDBDatabase::destroy):
(WebCore):

  • platform/leveldb/LevelDBDatabase.h:

(LevelDBDatabase):

Source/WebKit/chromium:

Reviewed by Tony Chang.

  • WebKit.gypi:
  • tests/LevelDBTest.cpp: Added.

(WebCore):
(SimpleComparator):
(WebCore::SimpleComparator::compare):
(WebCore::SimpleComparator::name):
(WebCore::encodeString):
(WebCore::TEST):

17:18 Changeset [109824] by barraclough@apple.com
  • 11 edits in trunk

putByIndex should throw in strict mode
https://bugs.webkit.org/show_bug.cgi?id=80335

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

We'll need to pass an additional parameter.

Part 1 - rename JSValue::put() for integer indices to JSValue::putByIndex()
to match the method in the MethodTable, make this take a parameter indicating
whether the put should throw. This fixes the cases where the base of the put
is a primitive.

  • dfg/DFGOperations.cpp:

(DFG):
(JSC::DFG::putByVal):
(JSC::DFG::operationPutByValInternal):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):
(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • runtime/JSObject.h:

(JSC::JSValue::putByIndex):

  • runtime/JSValue.cpp:

(JSC):

  • runtime/JSValue.h:

(JSValue):

LayoutTests:

  • fast/js/primitive-property-access-edge-cases-expected.txt:
  • fast/js/script-tests/primitive-property-access-edge-cases.js:

(checkNumericGet.Object.defineProperty):
(checkNumericSet.Object.defineProperty):
(checkNumericGetStrict.Object.defineProperty):
(checkNumericSetStrict.Object.defineProperty):
(checkNumericRead):
(checkNumericWrite):
(checkNumericReadStrict):
(checkNumericWriteStrict):

  • Added test cases.
17:18 Changeset [109823] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Enable context menu on android

For android, long press is converted into a right mouse down event
So we will use that to invoke the context menu
https://bugs.webkit.org/show_bug.cgi?id=80332

Patch by Min Qin <qinmin@google.com> on 2012-03-05
Reviewed by Adam Barth.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::mouseDown):

17:03 Changeset [109822] by leviw@chromium.org
  • 4 edits in branches/subpixellayout/Source/WebCore

Fixing an improper overloaded method in RenderThemeMac, cleaning up RenderBlock.cpp, and adding a size_t flavor of operator* in FractionalLayoutUnit for RenderBlock.

17:01 Changeset [109821] by rniwa@webkit.org
  • 4 edits in trunk

Perf-o-matic should memcache dashboard images
https://bugs.webkit.org/show_bug.cgi?id=80349

Reviewed by Eric Seidel.

Added DashboardImage.create and DashboardImage.get_image to encapsulate memcache.
Also replaced transaction in DashboardImage.set_cache by a single put since it duplicates
what put does by default.

Also removed redundant cache_* functions and merged them into handler code.

  • Websites/webkit-perf.appspot.com/controller.py:

(ManifestUpdateHandler.post):
(CachedManifestHandler.get):
(DashboardUpdateHandler.post):
(CachedDashboardHandler.get):
(RunsUpdateHandler):
(RunsUpdateHandler.post):
(RunsChartHandler):
(RunsChartHandler.post):
(DashboardImageHandler.get):

  • Websites/webkit-perf.appspot.com/models.py:

(PersistentCache.set_cache):
(DashboardImage):
(DashboardImage.create):
(DashboardImage.get_image):

  • Websites/webkit-perf.appspot.com/models_unittest.py:

(PersistentCacheTests.setUp):
(PersistentCacheTests.test_set_cache):
(PersistentCacheTests.test_get_cache):
(DashboardImageTests.setUp):
(DashboardImageTests):
(DashboardImageTests.test_create):
(DashboardImageTests.test_get):

17:00 Changeset [109820] by schenney@chromium.org
  • 7 edits
    2 adds in trunk

[Chromium] SVG Composite of Offset crashes
https://bugs.webkit.org/show_bug.cgi?id=77245

Reviewed by Stephen White.

The feComposite arithmetic mode filter could readily be made to
generate invalid pre-multiplied pixel values which would then go on to
pollute other filters and cause invalid final output pixels. This
patch checks for filters that require valid inputs, and checks that a
result is valid, and corrects the result if necessary. This matches
the behavior of FF and Opera while preventing crashes or other
undesirable behavior.

Source/WebCore:

Test: svg/filters/feComposite-arithmetic-invalid-rgba.svg

  • platform/graphics/filters/FEComposite.h: Override the default validity checks and image cleanup methods.
  • platform/graphics/filters/FEComposite.cpp:

(WebCore::FEComposite::correctFilterResultIfNeeded): Force valid pixels if this is an arithmetic filter

  • platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::apply): Check for validity status and correct
(WebCore::FilterEffect::forceValidPremultipliedPixels): Make an image valid
(WebCore):

  • platform/graphics/filters/FilterEffect.h: New virtual methods for image validity.

(FilterEffect):
(WebCore::FilterEffect::requiresValidPreMulultipliedPixels):
(WebCore::FilterEffect::forceValidPremultipliedPixels):
(WebCore::FilterEffect::correctFilterResultIfNeeded):

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::postApplyResource): Check that the final filter result is valid

LayoutTests:

  • svg/filters/feComposite-arithmetic-invalid-rgba-expected.svg: Added.
  • svg/filters/feComposite-arithmetic-invalid-rgba.svg: Added.
16:54 Changeset [109819] by timothy@apple.com
  • 2 edits in trunk/Source/WebKit2/UIProcess

Fix 32-bit builds.

16:51 Changeset [109818] by alexis.menard@openbossa.org
  • 10 edits
    2 adds in trunk

getComputedStyle gives incorrect information for 'height' property
https://bugs.webkit.org/show_bug.cgi?id=33593

Reviewed by David Hyatt.

Source/WebCore:

Make sure that the contentBoxRect doesn't take into account the
intrinsic padding when querying it. As stated by http://www.w3.org/TR/css3-box/#the-lsquo0
the height is the content area which doesn't include the intrinsic padding, the border, and
the padding.

Test: fast/css/getComputedStyle/getComputedStyle-height.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::removeNode):

  • rendering/RenderBox.h:

(WebCore::RenderBox::contentBoxRect):
(WebCore::RenderBox::contentWidth):
(WebCore::RenderBox::contentHeight):
(WebCore::RenderBox::contentLogicalWidth):
(WebCore::RenderBox::contentLogicalHeight):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paddingTop):
(WebCore::RenderBoxModelObject::paddingBottom):
(WebCore::RenderBoxModelObject::paddingLeft):
(WebCore::RenderBoxModelObject::paddingRight):
(WebCore::RenderBoxModelObject::paddingBefore):
(WebCore::RenderBoxModelObject::paddingAfter):
(WebCore::RenderBoxModelObject::paddingStart):
(WebCore::RenderBoxModelObject::paddingEnd):

  • rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paddingTop):
(WebCore::RenderTableCell::paddingBottom):
(WebCore::RenderTableCell::paddingLeft):
(WebCore::RenderTableCell::paddingRight):
(WebCore::RenderTableCell::paddingBefore):
(WebCore::RenderTableCell::paddingAfter):
(WebCore::RenderTableCell::cellBaselinePosition):

  • rendering/RenderTableCell.h:

(RenderTableCell):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::firstLineBoxBaseline):

LayoutTests:

Make sure that the contentBoxRect doesn't take into account the
intrinsic padding.

  • fast/css/getComputedStyle/getComputedStyle-height-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-height.html: Added.
16:47 Changeset [109817] by morrita@google.com
  • 4 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=80257
Lifecycle of InternalSettings should be simplified.

Reviewed by Ryosuke Niwa.

  • Moved settings update code to separate restoreTo() method.
  • Eliminated flags which indidate the changed field. Now these modifiable parameters are backed up at the initialization.

No new tests. Refactoring.

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::create):
(WebCore::InternalSettings::InternalSettings):
(WebCore):
(WebCore::InternalSettings::restoreTo):

  • testing/InternalSettings.h:

(InternalSettings):

  • testing/Internals.cpp:

(WebCore::Internals::reset):

16:45 Changeset [109816] by tkent@chromium.org
  • 5 edits
    2 copies in trunk

[Chromium] Add new popup type: PagePopup
https://bugs.webkit.org/show_bug.cgi?id=80106

Reviewed by Darin Fisher.

Source/WebKit/chromium:

This is a preparation of implementing ChromeClient::openPagePopup and
closePagePopup.

  • WebKit.gyp: Add WebPagePopup.h and WebPagePopupImpl.cpp.
  • public/WebPagePopup.h:

(WebPagePopup): Add WebPagePopup interface.

  • public/WebPopupType.h: Add WebPopupTypePage.
  • src/WebPagePopupImpl.cpp:

(WebKit::WebPagePopup::create): Temprary implementation which just returns 0.

Tools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createPopupMenu):

16:41 Changeset [109815] by jberlin@webkit.org
  • 2 edits in trunk/Tools

Add myself as a reviewer.

  • Scripts/webkitpy/common/config/committers.py:

Also, add my IRC nick so it is easier to find and yell at me.

16:31 Changeset [109814] by efidler@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

The minimum font size WebSetting should actually change the LOGICAL font size in WebCore.
https://bugs.webkit.org/show_bug.cgi?id=80312
RIM PR: 139874

Reviewed by George Staikos.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):

16:20 Changeset [109813] by commit-queue@webkit.org
  • 2 edits in trunk/Websites/bugs.webkit.org

The Bugzilla autocompleter doesn't support multiple Unicode characters per name
https://bugs.webkit.org/show_bug.cgi?id=80319

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2012-03-05
Reviewed by Adam Barth.

The current regular expression for matching Unicode characters uses
the global modifier, which means that it will never enter its second
iteration of the match-loop. This patch fixes this by removing the
global modifier from the regex.

  • committers-autocomplete.js:

(WebKitCommitters):

16:13 Changeset [109812] by andersca@apple.com
  • 7 edits in trunk/Source

Be more aggressive about repainting page overlays
https://bugs.webkit.org/show_bug.cgi?id=80336
<rdar://problem/10965943>

Reviewed by Simon Fraser.

Source/WebCore:

Add a way to find out if a given GraphicsLayer is going to be repainted.

  • WebCore.exp.in:
  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::needsDisplay):
(GraphicsLayer):

  • platform/graphics/ca/GraphicsLayerCA.h:

Source/WebKit2:

Whenever we're flushing layers and we have a page overlay, check if the main frame
has scrolled or if the main frame root content layer needs to be repainted and force the
overlay layer to be repainted if either of those conditions are true.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::shouldRepaintPageOverlayLayer):
(WebKit):

16:13 Changeset [109811] by commit-queue@webkit.org
  • 5 edits in trunk

Tools: Correctly compute the positions of GestureScroll* events on
Chromium.
https://bugs.webkit.org/show_bug.cgi?id=80075

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-05
Reviewed by Adam Barth.

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::reset):
(EventSender::gestureEvent):

  • DumpRenderTree/chromium/EventSender.h:

(EventSender):

LayoutTests: Correct a test to work the same on Gtk and non-Gtk chromium in
the presence of correctly synthesized GestureScroll* events.
https://bugs.webkit.org/show_bug.cgi?id=80075

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-05
Reviewed by Adam Barth.

  • fast/events/touch/gesture/gesture-scroll.html:
16:11 Changeset [109810] by dpranke@chromium.org
  • 3 edits in trunk/Tools

flakiness dashboard doesn't display baselines for virtual tests correctly
https://bugs.webkit.org/show_bug.cgi?id=80341

Reviewed by Ojan Vafai.

If the test is part of a virtual test suite, we need to look for
baselines in the underlying fallback path for the actual test
being run, as well as baselines for the virtual version.

This patch adds code to handle both branches and also pulls the
mapping of the test suites up into a constant.

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:

(testLookupVirtualTestSuite):
(testBaseTest):

15:50 Changeset [109809] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Source/WebCore

[BlackBerry] Upstream LayerRendererSurface.{cpp, h}
https://bugs.webkit.org/show_bug.cgi?id=80122

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-03-05
Reviewed by Rob Buis.

Initial upstream, no new tests.

  • PlatformBlackBerry.cmake:
  • platform/graphics/blackberry/LayerRendererSurface.cpp: Added.

(WebCore):
(WebCore::LayerRendererSurface::LayerRendererSurface):
(WebCore::LayerRendererSurface::~LayerRendererSurface):
(WebCore::LayerRendererSurface::setContentRect):
(WebCore::LayerRendererSurface::drawRect):
(WebCore::LayerRendererSurface::ensureTexture):
(WebCore::LayerRendererSurface::releaseTexture):

  • platform/graphics/blackberry/LayerRendererSurface.h: Added.

(WebCore):
(LayerRendererSurface):
(WebCore::LayerRendererSurface::size):
(WebCore::LayerRendererSurface::contentRect):
(WebCore::LayerRendererSurface::clipRect):
(WebCore::LayerRendererSurface::setClipRect):
(WebCore::LayerRendererSurface::setDrawTransform):
(WebCore::LayerRendererSurface::drawTransform):
(WebCore::LayerRendererSurface::setReplicaDrawTransform):
(WebCore::LayerRendererSurface::replicaDrawTransform):
(WebCore::LayerRendererSurface::texture):
(WebCore::LayerRendererSurface::drawOpacity):
(WebCore::LayerRendererSurface::setDrawOpacity):

15:45 Changeset [109808] by weinig@apple.com
  • 5 edits in trunk/WebKitLibraries

Fix the SnowLeoaprd build.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
15:31 Changeset [109807] by mihnea@adobe.com
  • 5 edits
    2 adds in trunk

[CSSRegions][CSSOM]Prevent creation of NamedFlow object for invalid flow name
https://bugs.webkit.org/show_bug.cgi?id=79685

Reviewed by David Hyatt.

Asking for a named flow with an invalid flow name should return a null object.

Source/WebCore:

Test: fast/regions/webkit-named-flow-invalid-name.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFlowThread):
(WebCore):

  • css/CSSParser.h:
  • dom/Document.cpp:

(WebCore::validFlowName):
(WebCore):
(WebCore::Document::webkitGetFlowByName):

LayoutTests:

  • fast/regions/webkit-named-flow-invalid-name-expected.txt: Added.
  • fast/regions/webkit-named-flow-invalid-name.html: Added.
15:09 Changeset [109806] by rniwa@webkit.org
  • 14 edits
    4 adds in trunk

unicode-bidi should support isolate override and override isolate
https://bugs.webkit.org/show_bug.cgi?id=73164

Reviewed by Eric Seidel.

Source/WebCore:

Updated CSS parser and CSS style selector to support the union of bidi-override and isolate in
unicode-bidi property. Added OverrideIsolate to EUnicodeBidi instead of turning Override and Isolate
into bit flags to avoid increasing the number of bits required to store the unicodeBidi flag.

Also fixed a bug in RenderBlock::constructTextRun to actually check whether an isolated run's direction
is overridden or not when constructing one.

Tests: fast/css/unicode-bidi-computed-value.html

fast/text/bidi-override-isolate.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::renderUnicodeBidiFlagsToCSSValue): Added; Create a CSSValueList when unicode-bidi has both
isolate and bidi-override specified.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Calls renderUnicodeBidiFlagsToCSSValue.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Support parsing combinations of -webkit-isolate and bidi-override;
Create a CSSValueList in such cases.

  • css/CSSPrimitiveValueMappings.h:

(WebCore):

  • css/CSSStyleApplyProperty.cpp:

(ApplyPropertyUnicodeBidi):
(WebCore::ApplyPropertyUnicodeBidi::applyValue): Support combinations of -webkit-isolate and
bidi-override. Set the unicodeBidi flag to OverrideIsolate in such cases.
(WebCore::ApplyPropertyUnicodeBidi::createHandler):
(WebCore):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawTextInternal):

  • platform/text/UnicodeBidi.h: Added OverrideIsolate. We don't use bit flags to avoid increasing the

number of bits required to store flags especially because isolate and bidi-override are only values
that can be combined.
(WebCore::isIsolated):
(WebCore):
(WebCore::isOverride):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::constructTextRun):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::statusWithDirection): Takes isOverride; we used to assume it's always false.
(WebCore::constructBidiRuns): Instantiate isolatedResolver with a proper value of isOverride.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::determineStartPosition):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::paintItemForeground):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::itemStyle):
(WebCore::RenderMenuList::menuStyle):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::menuStyle):

  • rendering/svg/SVGTextMetrics.cpp:

(WebCore::SVGTextMetrics::constructTextRun):

LayoutTests:

Added a test for retrieving computed value of unicode-bidi property
and also added a test to render "unicode-bidi: -webkit-isolate bidi-override".

  • fast/css/unicode-bidi-computed-value-expected.txt: Added.
  • fast/css/unicode-bidi-computed-value.html: Added.
  • fast/text/bidi-override-isolate-expected.html: Added.
  • fast/text/bidi-override-isolate.html: Added.
14:58 Changeset [109805] by eae@chromium.org
  • 13 edits in trunk/Source/WebCore

Replace uses of x(), y() and width(), height() pairs with locationOffset and size()
https://bugs.webkit.org/show_bug.cgi?id=80196

Reviewed by Julien Chaffraix.

Replace IntSize(x(), y()) with locationOffset()
Replace IntSize(width(), height()) with size()
Replace IntRect(0, 0, width(), height()) with IntRect(IntPoint(), size())
Replace IntRect::move(x(), y()) with IntRect::move(locationOffset())

No new tests.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::createImageBuffer):
(WebCore::HTMLCanvasElement::baseTransform):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::simplifiedLayout):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::mapLocalToContainer):
(WebCore::RenderBox::computeRectForRepaint):

  • rendering/RenderBox.h:

(WebCore::RenderBox::borderBoxRect):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):

  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::localSelectionRect):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::localSelectionRect):

  • rendering/RenderScrollbar.cpp:

(WebCore::RenderScrollbar::updateScrollbarParts):
(WebCore::RenderScrollbar::buttonRect):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::setCellLogicalWidths):
(WebCore::RenderTableSection::layoutRows):

  • rendering/RenderView.cpp:

(WebCore::RenderView::viewRect):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::layout):

14:53 Changeset [109804] by weinig@apple.com
  • 35 edits
    2 moves in trunk/Source

Add support for hosting layers in the window server in WebKit2
<rdar://problem/10400246>
https://bugs.webkit.org/show_bug.cgi?id=80310

Reviewed by Anders Carlsson.

Source/JavaScriptCore:

  • wtf/Platform.h:

Add HAVE_LAYER_HOSTING_IN_WINDOW_SERVER.

Source/WebKit2:

This currently only works if you are using TiledCoreAnimation drawing model.

  • Platform/mac/LayerHostingContext.h: Renamed from Source/WebKit2/Platform/mac/RemoteLayerClient.h.
  • Platform/mac/LayerHostingContext.mm: Renamed from Source/WebKit2/Platform/mac/RemoteLayerClient.mm.

(WebKit::LayerHostingContext::createForPort):
(WebKit::LayerHostingContext::LayerHostingContext):
(WebKit::LayerHostingContext::createForWindowServer):
(WebKit::LayerHostingContext::~LayerHostingContext):
(WebKit::LayerHostingContext::setRootLayer):
(WebKit::LayerHostingContext::rootLayer):
(WebKit::LayerHostingContext::contextID):
(WebKit::LayerHostingContext::invalidate):
Renamed RemoteLayerClient to LayerHostingContext and add ability to use the window server
as the remote context.

  • PluginProcess/PluginControllerProxy.cpp:
  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/mac/PluginControllerProxyMac.mm:

Update for new names.

  • Shared/LayerTreeContext.h:

Add LayerHostingMode enum.

  • UIProcess/PageClient.h:
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::layerHostingMode):
(WebKit::PageClientImpl::updateAcceleratedCompositingMode):
Add PageClient access points to get the current layer hosting mode,
and a hook to tell the underlying view that the layer hosting context
has changed.

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView _updateAcceleratedCompositingMode:WebKit::]):
Implement responding to a new layer hosting context as a simple
exit and re-entrance of compositing.

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::layerHostingModeDidChange):
(WebKit::DrawingAreaProxy::updateAcceleratedCompositingMode):

  • UIProcess/DrawingAreaProxy.messages.in:
  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:

(TiledCoreAnimationDrawingAreaProxy):

  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::layerHostingModeDidChange):
(WebKit::TiledCoreAnimationDrawingAreaProxy::updateAcceleratedCompositingMode):
Pipe layer hosting changes around.

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::layerHostingMode):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::viewStateDidChange):
Cache the current layer hosting mode so we don't overzealously
tell the WebProcess to reset its context. Re-check layer hosting
mode each time we are added/removed from a window.

  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.h:
  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:

Update for new names.

  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::setDeviceScaleFactor):
(WebKit::DrawingArea::setLayerHostingMode):

  • WebProcess/WebPage/DrawingArea.messages.in:

Pipe layer hosting changes around.

  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h:
  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:

(WebKit::LayerTreeHostCAMac::~LayerTreeHostCAMac):
(WebKit::LayerTreeHostCAMac::platformInitialize):
(WebKit::LayerTreeHostCAMac::invalidate):
Update for new names.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::setLayerHostingMode):
Respond to a change in the layer hosting mode by invalidating our old context,
making a new one of the right type, and informing the UIProcess of our new context.

  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

14:33 Changeset [109803] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Add missing method to PasteboardBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=80326

Reviewed by Antonio Gomes.

Add missing method.

  • platform/blackberry/PasteboardBlackBerry.cpp:

(WebCore::Pasteboard::writeClipboard):
(WebCore):

14:10 Changeset [109802] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed, attempted build fix for !ENABLE(JIT) after r109705.

  • bytecode/ExecutionCounter.cpp:

(JSC::ExecutionCounter::applyMemoryUsageHeuristics):

  • bytecode/ExecutionCounter.h:
14:01 Changeset [109801] by andersca@apple.com
  • 6 edits in trunk/Source

Always update the scroll layer position on the main thread when we have an overlay
https://bugs.webkit.org/show_bug.cgi?id=80324

Reviewed by Sam Weinig.

Source/WebCore:

Add a way to ensure that scroll layer position updates happen on the main thread.

  • WebCore.exp.in:
  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::ScrollingCoordinator):
(WebCore::ScrollingCoordinator::updateShouldUpdateScrollLayerPositionOnMainThread):
(WebCore):
(WebCore::ScrollingCoordinator::setForceMainThreadScrollLayerPositionUpdates):

  • page/scrolling/ScrollingCoordinator.h:

(ScrollingCoordinator):

Source/WebKit2:

Call setForceMainThreadScrollLayerPositionUpdates when installing and uninstalling page overlays,
so we'll be able to synchronize painting between the tile cache and the page overlays.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::didInstallPageOverlay):
(WebKit::TiledCoreAnimationDrawingArea::didUninstallPageOverlay):

13:59 Changeset [109800] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderBlockLineLayout.cpp

Cleaning up RenderBlockLineLayout before attempting to land changes in trunk.

13:59 Changeset [109799] by tony@chromium.org
  • 5 edits
    4 adds in trunk

Implement flex-wrap: wrap
https://bugs.webkit.org/show_bug.cgi?id=79930

Reviewed by David Hyatt.

Source/WebCore:

Tests: css3/flexbox/multiline-align.html

css3/flexbox/multiline.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::sizesToIntrinsicLogicalWidth): Don't apply column+stretch optimization to multiline.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::FlexOrderIterator::FlexOrderIterator):
(WebCore::RenderFlexibleBox::FlexOrderIterator::currentChild): Expose the current child so we can pause
in the middle of iteration and resume later.
(RenderFlexibleBox::FlexOrderIterator):
(WebCore::RenderFlexibleBox::isMultiline):
(WebCore):
(WebCore::RenderFlexibleBox::layoutFlexItems): Loop per line.
(WebCore::RenderFlexibleBox::availableAlignmentSpaceForChild): Use the line space, not the whole container space.
(WebCore::RenderFlexibleBox::computeFlexOrder): Return true for each line.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Use the line offset. Also compute the line height as we go.
(WebCore::RenderFlexibleBox::layoutColumnReverse): Use the line offset.
(WebCore::RenderFlexibleBox::alignChildren): Align based on the line height. For multiline + column, we have to relayout
since the width may change (same as the row case above). We'll have to do something smarter when we implement flex-line-pack.

  • rendering/RenderFlexibleBox.h:

(RenderFlexibleBox):

LayoutTests:

  • css3/flexbox/multiline-align-expected.txt: Added.
  • css3/flexbox/multiline-align.html: Added.
  • css3/flexbox/multiline-expected.txt: Added.
  • css3/flexbox/multiline.html: Added.
13:52 Changeset [109798] by commit-queue@webkit.org
  • 16 edits
    3 copies in trunk/Source/WebCore

Implement WebGL extension EXT_texture_filter_anisotropic
https://bugs.webkit.org/show_bug.cgi?id=79541

This exports the EXT_texture_filter_anisotropic extension with the WEBKIT_ prefix as defined at
https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/extensions/proposals/EXT_texture_filter_anisotropic/index.html

Patch by Ben Vanik <benvanik@google.com> on 2012-03-05
Reviewed by Kenneth Russell.

Tested with the Khronos conformance test for the extension, available at https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/tests/conformance/extensions/ext-texture-filter-anisotropic.html

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):

  • html/canvas/EXTTextureFilterAnisotropic.cpp: Copied from Source/WebCore/html/canvas/WebGLExtension.h.

(WebCore):
(WebCore::EXTTextureFilterAnisotropic::EXTTextureFilterAnisotropic):
(WebCore::EXTTextureFilterAnisotropic::~EXTTextureFilterAnisotropic):
(WebCore::EXTTextureFilterAnisotropic::getName):
(WebCore::EXTTextureFilterAnisotropic::create):

  • html/canvas/EXTTextureFilterAnisotropic.h: Copied from Source/WebCore/html/canvas/WebGLExtension.h.

(WebCore):
(EXTTextureFilterAnisotropic):

  • html/canvas/EXTTextureFilterAnisotropic.idl: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
  • html/canvas/WebGLExtension.h:
  • html/canvas/WebGLObject.cpp:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::getTexParameter):
(WebCore::WebGLRenderingContext::texParameter):

  • html/canvas/WebGLRenderingContext.h:

(WebCore):
(WebGLRenderingContext):

  • platform/graphics/Extensions3D.h:

(Extensions3D):

  • platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::supports):

13:49 Changeset [109797] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[chromim] Mark http/tests/incremental/partial-jpeg.html as failing.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
13:47 Changeset [109796] by eae@chromium.org
  • 1537 edits
    554 copies
    145 deletes in branches/subpixellayout

Merge trunk changes up until 109755 into subpixel branch.

13:45 Changeset [109795] by timothy@apple.com
  • 3 edits
    1 move in trunk/Source/WebKit2

Change how the Web Inspector Develop menu actions work.

This removes the methods used by Safari's Develop menu. They can now be implemented in Safari.

https://webkit.org/b/80308

Reviewed by John Sullivan.

  • UIProcess/API/C/mac/WKInspectorPrivateMac.h: Renamed from Source/WebKit2/UIProcess/API/C/mac/WKInspectorMac.h.
  • UIProcess/mac/WebInspectorProxyMac.mm:

(-[WKWebInspectorProxyObjCAdapter inspectorRef]): Added.

  • WebKit2.xcodeproj/project.pbxproj: Renamed WKInspectorPrivateMac.h to better reflect its private nature.
13:44 Changeset [109794] by shawnsingh@chromium.org
  • 3 edits
    3 copies in branches/chromium/1025

Merge 109060 - RenderLayer ClipRect not accounting for transforms
https://bugs.webkit.org/show_bug.cgi?id=76486

Reviewed by Simon Fraser.

Source/WebCore:

Test: compositing/layer-creation/overlap-transformed-and-clipped.html

This patch changes calculateClipRects() so that the clipRect
offset is allowed to be converted across layers with
transforms. This is necessary because the RenderLayerCompositor
needs clipRects in document space, rather than with respect to
some local clipping layer.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::localToContainerPoint):
(WebCore):

  • rendering/RenderObject.h:

(RenderObject):

LayoutTests:

  • compositing/layer-creation/overlap-transformed-and-clipped-expected.png: Added.
  • compositing/layer-creation/overlap-transformed-and-clipped-expected.txt: Added.
  • compositing/layer-creation/overlap-transformed-and-clipped.html: Added.

TBR=shawnsingh@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9599025

13:42 Changeset [109793] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, marking a test that is passing on linux as such.

platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html
is passing on the flakiness dashboard.

  • platform/chromium/test_expectations.txt:
13:40 Changeset [109792] by ap@apple.com
  • 2 edits in trunk/LayoutTests

FileReader crashes when file is not readable
https://bugs.webkit.org/show_bug.cgi?id=79715

Unreviewed follow-up - skip the test as uses unimplemented beginDragWithFiles.

  • platform/wk2/Skipped:
13:33 Changeset [109791] by commit-queue@webkit.org
  • 8 edits
    2 deletes in trunk

Unreviewed, rolling out r109760.
http://trac.webkit.org/changeset/109760
https://bugs.webkit.org/show_bug.cgi?id=80320

Caused many GTK+ tests to crash (Requested by mrobinson on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-05

.:

  • configure.ac:

Source/WebCore:

  • platform/network/ResourceHandleClient.h:
  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCoreSynchronousLoader):
(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
(WebCore):
(WebCore::WebCoreSynchronousLoader::~WebCoreSynchronousLoader):
(WebCore::WebCoreSynchronousLoader::didReceiveResponse):
(WebCore::WebCoreSynchronousLoader::didReceiveData):
(WebCore::WebCoreSynchronousLoader::didFinishLoading):
(WebCore::WebCoreSynchronousLoader::didFail):
(WebCore::WebCoreSynchronousLoader::run):
(WebCore::closeCallback):
(WebCore::readCallback):
(WebCore::ResourceHandle::defaultSession):

Tools:

  • gtk/jhbuild.modules:

LayoutTests:

  • http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers-expected.txt: Removed.
  • http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers.html: Removed.
13:29 Changeset [109790] by adamk@chromium.org
  • 4 edits
    2 adds in trunk

Never dispatch mutation events in shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=79278

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/dom/shadow/suppress-mutation-events-in-shadow.html

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChildren): Move allowEventDispatch() call later,
now that childrenChanged won't trigger mutation events in shadow dom.
(WebCore::dispatchChildInsertionEvents): Bail out if in shadow tree.
(WebCore::dispatchChildRemovalEvents): ditto.

  • dom/Node.cpp:

(WebCore::Node::dispatchSubtreeModifiedEvent): ditto.

LayoutTests:

  • fast/dom/shadow/suppress-mutation-events-in-shadow-expected.txt: Added.
  • fast/dom/shadow/suppress-mutation-events-in-shadow.html: Added.
13:16 Changeset [109789] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

BlobResourceHandle should keep a reference to itself when calling client code.
https://bugs.webkit.org/show_bug.cgi?id=80318

Reviewed by Brady Eidson.

  • platform/network/BlobResourceHandle.cpp: (WebCore::BlobResourceHandle::doStart): (WebCore::BlobResourceHandle::getSizeForNext): (WebCore::BlobResourceHandle::readSync): (WebCore::BlobResourceHandle::readDataAsync): (WebCore::BlobResourceHandle::consumeData): (WebCore::BlobResourceHandle::failed): Added RefPtrs in functions that can result in calling client code, and use "this" object afterwards.
13:10 Changeset [109788] by andersca@apple.com
  • 12 edits in trunk/Source/WebCore

Let RenderLayerCompositor set the tile cache visible rect
https://bugs.webkit.org/show_bug.cgi?id=80317

Reviewed by Simon Fraser.

We can't compute the visible rect from CALayers, because that breaks when we're updating
the scroll layer position on the main thread (since by the time visibleRectChanged() is called,
the CALayers won't yet have been updated).

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::visibleRectChanged):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::visibleRectChanged):

  • platform/graphics/ca/GraphicsLayerCA.h:

(GraphicsLayerCA):

  • platform/graphics/ca/PlatformCALayer.h:

(PlatformCALayer):

  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::visibleRectChanged):

  • platform/graphics/ca/mac/TileCache.h:

(TileCache):

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::visibleRectChanged):
(WebCore::TileCache::revalidateTiles):

  • platform/graphics/ca/mac/WebTileCacheLayer.h:

(WebCore):

  • platform/graphics/ca/mac/WebTileCacheLayer.mm:

(-[WebTileCacheLayer visibleRectChanged:]):

  • platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayer::visibleRectChanged):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::frameViewDidScroll):

13:02 Changeset [109787] by paroga@webkit.org
  • 6 edits in trunk

[CMake][DRT] Add WebCoreTestSupport.
https://bugs.webkit.org/show_bug.cgi?id=79896

Patch by Kangil Han <kangil.han@samsung.com> on 2012-03-05
Reviewed by Daniel Bates.

Add WebCoreTestSupport library for DRT in CMake.
We will use internals object by linking this library on DRT.

.:

  • CMakeLists.txt:

Source/WebCore:

  • CMakeLists.txt:
  • UseJSC.cmake:
  • UseV8.cmake:
13:00 Changeset [109786] by weinig@apple.com
  • 5 edits in trunk/WebKitLibraries

Update WebKitSystemInterface for WKCAContext additions.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
12:44 Changeset [109785] by commit-queue@webkit.org
  • 40 edits
    14 deletes in trunk

Unreviewed, rolling out r109656.
http://trac.webkit.org/changeset/109656
https://bugs.webkit.org/show_bug.cgi?id=80316

This seems to have regressed Parser/html5-full-render by about
10% (Requested by anttik on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-05

Source/WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::getPositionOffsetValue):
(WebCore::getBorderRadiusCornerValues):
(WebCore::getBorderRadiusCornerValue):
(WebCore::getBorderRadiusShorthandValue):
(WebCore::lineHeightFromStyle):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSGrammar.y:
  • css/CSSParser.cpp:

(WebCore::CSSParser::validUnit):
(WebCore::CSSParser::createPrimitiveNumericValue):
(WebCore::unitFromString):
(WebCore::CSSParser::parseValidPrimitive):
(WebCore::CSSParser::detectNumberToken):

  • css/CSSPrimitiveValue.cpp:

(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::unitCategory):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::canonicalUnitTypeForCategory):
(WebCore::CSSPrimitiveValue::customCssText):

  • css/CSSPrimitiveValue.h:

(CSSPrimitiveValue):

  • css/CSSPrimitiveValue.idl:
  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • dom/Document.cpp:

(WebCore::Document::pageSizeAndMarginsInPixels):
(WebCore):

  • dom/Document.h:

(Document):

  • html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::getRegion):

  • platform/Length.h:

(WebCore::Length::calcValue):
(WebCore::Length::calcMinValue):
(WebCore::Length::calcFloatValue):
(WebCore::Length::blend):

  • rendering/RenderBR.cpp:

(WebCore::RenderBR::lineHeight):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::lineHeight):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::reflectionOffset):
(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::clipRect):
(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::computeLogicalHeightUsing):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::computeBlockDirectionMargins):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::relativePositionOffsetX):
(WebCore::RenderBoxModelObject::relativePositionOffsetY):
(WebCore::RenderBoxModelObject::paddingTop):
(WebCore::RenderBoxModelObject::paddingBottom):
(WebCore::RenderBoxModelObject::paddingLeft):
(WebCore::RenderBoxModelObject::paddingRight):
(WebCore::RenderBoxModelObject::paddingBefore):
(WebCore::RenderBoxModelObject::paddingAfter):
(WebCore::RenderBoxModelObject::paddingStart):
(WebCore::RenderBoxModelObject::paddingEnd):
(WebCore::RenderBoxModelObject::getBackgroundRoundedRect):
(WebCore::RenderBoxModelObject::calculateFillTileSize):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
(WebCore::computeBorderImageSide):
(WebCore::RenderBoxModelObject::paintNinePieceImage):
(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::RenderBoxModelObject::paintBoxShadow):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithm):

  • rendering/RenderInline.cpp:

(WebCore::computeMargin):
(WebCore::RenderInline::lineHeight):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::updateOptionsWidth):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::repaintAfterLayoutIfNeeded):

  • rendering/RenderObject.h:

(RenderObject):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::paint):

  • rendering/RenderScrollbarPart.cpp:

(WebCore::calcScrollbarThicknessUsing):
(WebCore::RenderScrollbarPart::computeScrollbarWidth):
(WebCore::RenderScrollbarPart::computeScrollbarHeight):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth):
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::logicalHeightForRowSizing):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):

  • rendering/RenderText.h:

(WebCore::RenderText::marginLeft):
(WebCore::RenderText::marginRight):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMenuListButtonGradients):

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::paint):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::verticalPositionForBox):

  • rendering/style/RenderStyle.cpp:

(WebCore::calcRadiiFor):
(WebCore::RenderStyle::getRoundedBorderFor):

  • rendering/style/RenderStyle.h:
  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::resolveLengthAttributeForSVG):
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):

LayoutTests:

  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle-expected.txt: Removed.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle.html: Removed.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute-expected.html: Removed.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute.html: Removed.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-expected.html: Removed.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh.html: Removed.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute-expected.html: Removed.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute.html: Removed.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-expected.html: Removed.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin.html: Removed.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute-expected.html: Removed.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute.html: Removed.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-expected.html: Removed.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw.html: Removed.
  • fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/win/fast/dom/Window/window-properties-expected.txt:
12:35 Changeset [109784] by paroga@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed. Build fix for !ENABLE(JIT) after r109705.

  • bytecode/ExecutionCounter.cpp:
  • bytecode/ExecutionCounter.h:
12:28 Changeset [109783] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] UTF chars printed back from cookie through php shows as ???
https://bugs.webkit.org/show_bug.cgi?id=80307

Reviewed by Antonio Gomes.

PR: 130055

we need to check the cookies encoding first and encode the cookie header data
to pass to the request.

  • platform/network/blackberry/NetworkManager.cpp:

(WebCore::NetworkManager::startJob):

12:15 Changeset [109782] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Use a proper closing tag for shadow element layout test
https://bugs.webkit.org/show_bug.cgi?id=80305

Reviewed by Adam Barth.

  • fast/dom/shadow/shadow-element.html:
12:05 Changeset [109781] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

[chromium] Remove old cleanupResources() code
https://bugs.webkit.org/show_bug.cgi?id=80290

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-05
Reviewed by Adrienne Walker.

cleanupResources() is only called by destructors, and adds no
value, any more, beyond the destructors themselves, but complicates
the code path.

Covered by existing tests.

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:
  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):

  • platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:

(WebCore::CCPluginLayerImpl::~CCPluginLayerImpl):

  • platform/graphics/chromium/cc/CCPluginLayerImpl.h:
  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::~CCRenderSurface):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(CCRenderSurface):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::~CCVideoLayerImpl):

11:59 Changeset [109780] by inferno@chromium.org
  • 1 edit in branches/chromium/963/Source/WebCore/dom/StyledElement.cpp

getElementsByClassName result list no longer changes on class changes on m17 branch.

BUG=114068, 116789
Review URL: https://chromiumcodereview.appspot.com/9602021

11:54 Changeset [109779] by commit-queue@webkit.org
  • 3 edits
    5 adds in trunk

Partially loaded JPEGs should have alpha channel
https://bugs.webkit.org/show_bug.cgi?id=78239

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-03-05
Reviewed by Kenneth Russell.

Source/WebCore:

While a JPEG image is loading, the area outside the decoded region
should be fully transparent. Since currently all JPEG frames are marked
as opaque, a renderer respecting this flag will draw the partially
loaded image with garbage outside the valid image region.

Hence, a partially loaded JPEG image should be marked as having an alpha
channel while decoding is in progress. For performance reasons we mark
the image opaque after decoding has finished.

Graphics corruption caused by this bug was recently observed on
Chromium (http://code.google.com/p/chromium/issues/detail?id=113171). A
recent Skia change (r3036) changed SkBitmap::extractSubset() to produce
a bitmap with the same opaqueness flag as the parent. This meant that
the renderer was now seeing an opaque image from the JPEG decoder, and
drawing it appropriately resulted in garbage outside the decoded region.

Test: http/tests/incremental/partial-jpeg.html

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageDecoder::outputScanlines):
(WebCore::JPEGImageDecoder::jpegComplete):

LayoutTests:

While a JPEG image is being loaded, the parts which have not been
decoded yet should show whatever is behind the image. This tests
verifies this by displaying a JPEG which never fully completes
loading. This is achieved by serving the JPEG from a PHP script that
strips the end of image marker (ff d9) from the data.

The test image is 32x32 pixels, so compresses to 4x4 JPEG MCU blocks.
The expected result is that the final row of MCU blocks (32x4 pixels)
never finishes loading due to the missing end of image marker and the
indicator div is shown through this area.

  • http/tests/incremental/partial-jpeg-expected.png: Added.
  • http/tests/incremental/partial-jpeg-expected.txt: Added.
  • http/tests/incremental/partial-jpeg.html: Added.
  • http/tests/incremental/resources/checkerboard.jpg: Added.
  • http/tests/incremental/resources/partial-jpeg.php: Added.
11:50 Changeset [109778] by commit-queue@webkit.org
  • 8 edits in trunk

[chromium] Pass WebNavigationPolicy to WebViewClient::createView
https://bugs.webkit.org/show_bug.cgi?id=80057

Patch by Charlie Reis <creis@chromium.org> on 2012-03-05
Reviewed by Darin Fisher.

Source/WebKit/chromium:

  • public/WebViewClient.h:

(WebViewClient):
(WebKit::WebViewClient::createView):

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::ChromeClientImpl):
(WebKit::ChromeClientImpl::createWindow):
(WebKit::ChromeClientImpl::getNavigationPolicy):
(WebKit):
(WebKit::ChromeClientImpl::show):
(WebKit::ChromeClientImpl::setNewWindowNavigationPolicy):

  • src/ChromeClientImpl.h:

(ChromeClientImpl):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchCreatePage):
(WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNewWindowAction):

Tools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createView):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

11:47 Changeset [109777] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[chromium] Initialize CCOverdrawCounts struct to zero
https://bugs.webkit.org/show_bug.cgi?id=80204

Patch by James Robinson <jamesr@chromium.org> on 2012-03-05
Reviewed by Adrienne Walker.

Source/WebCore:

CCOverdrawCounts is stack allocated but not explicitly initialized, so the values are garbage. This adds a c'tor
to zero out the fields, which is the desired behavior. Bug was initially caught by valgrind, see
http://crbug.com/116475

  • platform/graphics/chromium/cc/CCRenderPass.h:

(WebCore::CCOverdrawCounts::CCOverdrawCounts):

Source/WebKit/chromium:

Update test to use c'tor instead of {} struct initialization.

  • tests/CCQuadCullerTest.cpp:

(WebCore):

11:38 Changeset [109776] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk/Source/WebCore

Add media control css for chromium on android
https://bugs.webkit.org/show_bug.cgi?id=79550

Patch by Min Qin <qinmin@google.com> on 2012-03-05
Reviewed by Adam Barth.

This should not change the any test results as it does not affect the any current bots. New test expectations will be added if we have a android bot on webkit.

  • WebCore.gyp/WebCore.gyp:
  • css/mediaControlsChromiumAndroid.css: Added.

(body:-webkit-full-page-media):
(audio):
(audio:-webkit-full-page-media, video:-webkit-full-page-media):
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
(video:-webkit-full-page-media::-webkit-media-controls-panel):
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
(audio::-webkit-media-controls-timeline-container):
(video::-webkit-media-controls-timeline-container):
(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
(audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
(video::-webkit-media-controls-fullscreen-button):
(audio::-webkit-media-controls-fullscreen-button):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
(audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):

  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::paintMediaFullscreenButton):
(WebCore):
(WebCore::RenderMediaControlsChromium::paintMediaControlsPart):

  • rendering/RenderThemeChromiumAndroid.cpp:

(WebCore::RenderThemeChromiumAndroid::extraMediaControlsStyleSheet):
(WebCore):
(WebCore::RenderThemeChromiumAndroid::paintMediaFullscreenButton):

  • rendering/RenderThemeChromiumAndroid.h:
11:26 Changeset [109775] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix crash in ScrollingCoordinator::updateMainFrameScrollPositionAndScrollLayerPosition
https://bugs.webkit.org/show_bug.cgi?id=80303
<rdar://problem/10953682>

Reviewed by Beth Dakin.

Add the same null checks that already exist in updateMainFrameScrollPosition.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::updateMainFrameScrollPositionAndScrollLayerPosition):

11:15 Changeset [109774] by enne@google.com
  • 3 edits in branches/chromium/1025/Source/WebCore/platform/graphics

Merge 109171 - [chromium] Inform v8 about extra memory used for PatternSkia clamp mode
https://bugs.webkit.org/show_bug.cgi?id=79846

Reviewed by James Robinson.

For large images, creating a non-repeating Pattern in Skia can
allocate a lot of memory. Inform v8 about this so that it can
potentially garbage collect any Pattern objects that aren't being used
and that are holding onto large image copies.

  • platform/graphics/Pattern.cpp:

(WebCore::Pattern::Pattern):

  • platform/graphics/Pattern.h:

(Pattern):

  • platform/graphics/skia/PatternSkia.cpp:

(WebCore::Pattern::platformDestroy):
(WebCore::Pattern::platformPattern):

TBR=enne@google.com
Review URL: https://chromiumcodereview.appspot.com/9599019

11:00 Changeset [109773] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed test expectations update: widen slowness of jquery/offset.html.

  • platform/chromium/test_expectations.txt:
10:57 Changeset [109772] by apavlov@chromium.org
  • 4 edits
    2 adds in trunk

Web Inspector: CSS inactive property check should account for vendor prefixes
https://bugs.webkit.org/show_bug.cgi?id=80225

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/styles/vendor-prefixes.html

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::populateObjectWithStyleProperties):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.alteredHexNumber):
(WebInspector.StylesSidebarPane.canonicalPropertyName):
(WebInspector.StylesSidebarPane.prototype._markUsedProperties):
(WebInspector.StylePropertiesSection.prototype.isPropertyOverloaded):

LayoutTests:

  • inspector/styles/vendor-prefixes-expected.txt: Added.
  • inspector/styles/vendor-prefixes.html: Added.
10:57 Changeset [109771] by toyoshim@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] [WebSocket] use OVERRIDE in WebSocketImpl.h
https://bugs.webkit.org/show_bug.cgi?id=80192

Reviewed by Kent Tamura.

  • src/WebSocketImpl.h: use OVERRIDE macro.

(WebSocketImpl):

10:57 Changeset [109770] by lforschler@apple.com
  • 4 edits in trunk/Source

Versioning.

10:56 Changeset [109769] by wingo@igalia.com
  • 4 edits in trunk/Source/JavaScriptCore

Lexer: Specialize character predicates for LChar, UChar
https://bugs.webkit.org/show_bug.cgi?id=79677

Reviewed by Oliver Hunt.

This patch specializes isIdentStart, isIdentPart, isWhiteSpace,
and isLineTerminator to perform a more limited number of checks if
the lexer is being instantiated to work on LChar sequences. This
is about a 1.5% win on the --parse-only suite, here.

  • parser/Lexer.cpp:

(JSC::isLatin1): New static helper, specialized for LChar and
UChar.
(JSC::typesOfLatin1Characters): Rename from
typesOfASCIICharacters, and expand to the range of the LChar
type. All uses of isASCII are changed to use isLatin1. Generated
using libunistring.
(JSC::isNonLatin1IdentStart):
(JSC::isIdentStart):
(JSC::isNonLatin1IdentPart):
(JSC::isIdentPart):
(JSC::Lexer::shiftLineTerminator):
(JSC::Lexer::parseIdentifier):
(JSC::Lexer::parseIdentifierSlowCase):
(JSC::Lexer::parseStringSlowCase):
(JSC::Lexer::parseMultilineComment):
(JSC::Lexer::lex):
(JSC::Lexer::scanRegExp):
(JSC::Lexer::skipRegExp): Sprinkle static_cast<T>(_) around.

  • parser/Lexer.h:

(JSC::Lexer::isWhiteSpace):
(JSC::Lexer::isLineTerminator):

  • KeywordLookupGenerator.py:

(Trie.printAsC): Declare specialized isIdentPart static functions.

10:51 WebKit Team edited by aroben@webkit.org
(diff)
10:50 Changeset [109768] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Removed the svn:executable properties from a couple of expected test results

10:36 Changeset [109767] by mitz@apple.com
  • 2 edits
    1 copy in trunk/LayoutTests

fast/text/international/spaces-combined-in-vertical-text.html has incorrect expected results
https://bugs.webkit.org/show_bug.cgi?id=80284

Reviewed by Alexey Proskuryakov.

The test was added in r104322 with results from the Chromium port, which are incorrect. This
is the subject of <https://bugs.webkit.org/show_bug.cgi?id=80293>.

  • fast/text/international/spaces-combined-in-vertical-text-expected.txt:
  • platform/chromium/fast/text/international/spaces-combined-in-vertical-text-expected.txt: Copied from LayoutTests/fast/text/international/spaces-combined-in-vertical-text-expected.txt.
10:34 Changeset [109766] by jonlee@apple.com
  • 14 edits in trunk/Source

Add support for notification replaceId in Mac WebKit and WK2
https://bugs.webkit.org/show_bug.cgi?id=80206
<rdar://problem/10965574>

Reviewed by Sam Weinig.

Source/WebKit/mac:

  • WebView/WebNotification.h: Add replaceID method.
  • WebView/WebNotification.mm:

(-[WebNotification replaceID]):

Source/WebKit2:

  • UIProcess/API/C/WKNotification.cpp: Add WK API.

(WKNotificationCopyReplaceID):

  • UIProcess/API/C/WKNotification.h:
  • UIProcess/Notifications/WebNotification.cpp:

(WebKit::WebNotification::WebNotification):

  • UIProcess/Notifications/WebNotification.h: Add replaceID member.

(WebKit::WebNotification::create):
(WebKit::WebNotification::replaceID):
(WebNotification):

  • UIProcess/Notifications/WebNotificationManagerProxy.cpp:

(WebKit::WebNotificationManagerProxy::show):

  • UIProcess/Notifications/WebNotificationManagerProxy.h:

(WebNotificationManagerProxy):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showNotification):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in: Add replaceID to the showNotification message.
  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::show):

10:28 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
10:26 Changeset [109765] by mrobinson@webkit.org
  • 8 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merging r109760

10:25 Changeset [109764] by mrobinson@webkit.org
  • 13 edits in releases/WebKitGTK/webkit-1.8/Source

Merging r109129

10:23 Changeset [109763] by japhet@chromium.org
  • 1 edit
    3 copies in branches/chromium/1025

Merge 106476 - Source/WebCore: preventDefault() in a mousedown in a subframe should not
prevent the scrollbar from handling mouse movements if the
cursor leaves the subframe.
https://bugs.webkit.org/show_bug.cgi?id=73097

Reviewed by Darin Adler.

Test: fast/events/scroll-div-with-prevent-default-in-subframe.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEvent):

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=73097.
Test adapted from repro case provided by zacklloyd@google.com.

Reviewed by Darin Adler.

  • fast/events/resources/subframe-with-scrollable-div.html: Added.
  • fast/events/scroll-div-with-prevent-default-in-subframe-expected.txt: Added.
  • fast/events/scroll-div-with-prevent-default-in-subframe.html: Added.

TBR=japhet@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9600027

10:22 Changeset [109762] by mitz@apple.com
  • 2 edits
    1 delete in trunk/LayoutTests

fast/regions/select-in-region-crash.html has incorrect expected results
https://bugs.webkit.org/show_bug.cgi?id=80289

Reviewed by Alexey Proskuryakov.

  • fast/regions/select-in-region-crash-expected.txt: Updated.
  • platform/chromium/fast/regions/select-in-region-crash-expected.txt: Removed.
10:17 Changeset [109761] by abarth@webkit.org
  • 13 edits in trunk/Source

Geolocation should use a ScriptExecutionContext as its context object
https://bugs.webkit.org/show_bug.cgi?id=80248

Reviewed by Kentaro Hara.

Source/WebCore:

This patch updates Geolocation to use some more modern WebCore
mechanisms. Previously, Geolocation used a Frame as a context object,
which required a bunch of manual integration with the PageCache as well
as custom signaling for Geolocation::reset(). After this patch,
Geolocation subclasses ActiveDOMObject, which does all this work
automatically.

  • Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::create):
(WebCore):
(WebCore::Geolocation::Geolocation):
(WebCore::Geolocation::~Geolocation):
(WebCore::Geolocation::document):
(WebCore::Geolocation::frame):
(WebCore::Geolocation::page):
(WebCore::Geolocation::stop):
(WebCore::Geolocation::getCurrentPosition):
(WebCore::Geolocation::watchPosition):
(WebCore::Geolocation::requestPermission):
(WebCore::Geolocation::clearWatch):
(WebCore::Geolocation::setIsAllowed):

  • Modules/geolocation/Geolocation.h:

(WebCore):
(Geolocation):

  • Modules/geolocation/NavigatorGeolocation.cpp:

(WebCore):
(WebCore::NavigatorGeolocation::geolocation):

  • Modules/geolocation/NavigatorGeolocation.h:

(NavigatorGeolocation):

  • dom/Document.cpp:

(WebCore::Document::Document):

  • dom/Document.h:

(Document):

  • history/PageCache.cpp:

(WebCore::logCanCacheFrameDecision):
(WebCore::PageCache::canCachePageContainingThisFrame):

Source/WebKit/chromium:

Rather than indirecting through the Frame to get the SecurityOrigin, we
should get the SecurityOrigin directly from ScriptExecutionContext.

  • src/WebGeolocationPermissionRequest.cpp:

(WebKit::WebGeolocationPermissionRequest::securityOrigin):

Source/WebKit/mac:

  • WebView/WebFrame.mm:

(-[WebFrame _cacheabilityDictionary]):

  • We no longer special-case Geolocation.
10:15 Changeset [109760] by mrobinson@webkit.org
  • 8 edits
    2 adds in trunk

[soup] Crash while loading http://www.jusco.cn
https://bugs.webkit.org/show_bug.cgi?id=68238

Reviewed by Philippe Normand.

.:

  • configure.ac: Bumped the libsoup dependency to 2.37.90.

Source/WebCore:

Test: http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers.html

When running synchronous XMLHttpRequests, push a new inner thread default
context, so that other sources from timers and network activity do not run.
This will make synchronous requests truly synchronous with the rest of
WebCore.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCoreSynchronousLoader): Clean up the method definitions a bit by writing them inline.
(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): Push a new thread default
context to prevent other sources from running.
(WebCore::WebCoreSynchronousLoader::~WebCoreSynchronousLoader): Pop the inner thread default context.
(WebCore::closeCallback): If the client is synchronous call didFinishLoading now.
(WebCore::readCallback): Only call didFinishLoading if the client isn't synchronous.
(WebCore::ResourceHandle::defaultSession): Activate use-thread-context so that the soup session
respects the inner thread context.
(ResourceHandleClient):
(WebCore::ResourceHandleClient::isSynchronousClient): Added this virtual method.

Tools:

  • gtk/jhbuild.modules: Bumped the libsoup and glib dependencies

in the jhbuild file.

LayoutTests:

  • http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers.html: Added.
10:00 Changeset [109759] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit2

Merging r109754

09:47 Changeset [109758] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merging r109722

09:47 Changeset [109757] by mrobinson@webkit.org
  • 4 edits in releases/WebKitGTK/webkit-1.8

Merging r109270

09:44 Changeset [109756] by mrobinson@webkit.org
  • 5 edits in releases/WebKitGTK/webkit-1.8

Merging r109719

09:15 Changeset [109755] by commit-queue@webkit.org
  • 10 edits
    2 deletes in trunk

Unreviewed, rolling out r109748.
http://trac.webkit.org/changeset/109748
https://bugs.webkit.org/show_bug.cgi?id=80296

Made some tests crash, will fix and recommit (Requested by
noamr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-05

Source/WebKit2:

  • Target.pri:
  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPagePrivate::paintToCurrentGLContext):
(PageProxyNode::PageProxyNode):
(PageProxyNode):
(PageProxyNode::changedStates):
(PageProxyNode::render):
(PageProxyNode::~PageProxyNode):
(QQuickWebPage::updatePaintNode):
(QQuickWebPagePrivate::updateSize):
(QQuickWebPagePrivate::resetPaintNode):
(QQuickWebPagePrivate::~QQuickWebPagePrivate):

  • UIProcess/API/qt/qquickwebpage_p_p.h:

(QQuickWebPagePrivate):

  • UIProcess/DrawingAreaProxy.h:

(WebKit):
(WebKit::DrawingAreaProxy::layerTreeHostProxy):
(DrawingAreaProxy):

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):

  • UIProcess/LayerTreeHostProxy.h:

(LayerTreeHostProxy):

  • UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::syncAnimations):
(WebKit::LayerTreeHostProxy::updateViewport):
(WebKit::LayerTreeHostProxy::syncLayerParameters):
(WebKit::LayerTreeHostProxy::flushLayerChanges):
(WebKit::LayerTreeHostProxy::ensureRootLayer):
(WebKit::LayerTreeHostProxy::syncRemoteContent):
(WebKit::LayerTreeHostProxy::dispatchUpdate):
(WebKit):
(WebKit::LayerTreeHostProxy::createDirectlyCompositedImage):
(WebKit::LayerTreeHostProxy::purgeGLResources):

  • UIProcess/qt/QtWebPageSGNode.cpp: Removed.
  • UIProcess/qt/QtWebPageSGNode.h: Removed.

Tools:

  • MiniBrowser/qt/main.cpp:

(main):

08:55 Changeset [109754] by joone.hur@collabora.co.uk
  • 2 edits in trunk/Source/WebKit2

[GTK] zlib link error with --enable-webkit2
https://bugs.webkit.org/show_bug.cgi?id=79877

Reviewed by Martin Robinson.

zlib should be linked properly.

  • GNUmakefile.am: Link $(ZLIB_LIBS) with libwebkit2gtk instead of

linking it with WebKitWebProcess.

08:54 Changeset [109753] by commit-queue@webkit.org
  • 7 edits in trunk

[GTK] plugins/netscape-plugin-page-cache-works.html fails
https://bugs.webkit.org/show_bug.cgi?id=74409

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-03-05
Reviewed by Martin Robinson.

Source/WebKit/gtk:

Add a method to override page-cache-for-plugins preference.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::setPageCacheSupportsPlugins):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Tools:

Add support for overriding the page-cache-for-plugins preference
through DumpRenderTreeSupport.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(booleanFromValue): A helper function to convert a string to boolean.
(LayoutTestController::overridePreference):

LayoutTests:

Unskip one new passing test and reclassify one failure.

  • platform/gtk/Skipped:
08:52 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
08:40 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
08:38 Changeset [109752] by ossy@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

[Qt] Unreviewed gardening.

08:37 Changeset [109751] by jpetsovits@rim.com
  • 7 edits in trunk/Source/WebKit/blackberry

Make accelerated compositing work again with direct rendering.
https://bugs.webkit.org/show_bug.cgi?id=80181
RIM PR: 139110

Reviewed by Antonio Gomes.
Internally reviewed by Arvid Nilsson.

The significant amount of refactoring and optimization work
that has gone into accelerated compositing missed out on
some of the code paths that are being used in direct rendering.

Animations were relying on blitVisibleContents() only (which
is a no-op in direct rendering mode). There were early returns
which are suitable to determine whether screen contents need
to be updated at all; however, when we're already forcing a
re-render then those checks would cause the composition surface
not to appear at all, or avoid drawing new animation frames.

We went through dispatchMessage(), potentially causing
mismatches between rendered (but not yet posted) back content
and layers composited on top of it. As we're rendering onto
the sole target surface (the window) directly and posting
from the same thread, we have to wait for compositing on the
UI thread to finish before posting the window.

In turn, this patch combines both drawSubLayers() and
blendCompositingSurface() calls into one method, reducing
the number of messages to the UI thread within
renderDirectToWindow() to one.

blendCompositingMessage() in renderDirectToScreen() was called
with contents coordinates rather than viewport coordinates.
That caused some of the composited content to be cut off when
the scroll position wasn't (0, 0).

We called copyPreviousContentsToBackSurfaceOfWindow() twice for
one frame, in both renderDirectToWindow() and invalidateWindow().
Only one of those (the latter one) is necessary.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::renderDirectToWindow):
(BlackBerry::WebKit::BackingStorePrivate::drawSubLayers):
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::drawAndBlendLayersForDirectRendering):

  • Api/BackingStore.h:

(WebKit):

  • Api/BackingStore_p.h:

(BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::isDirectRenderingAnimationMessageScheduled):
(BlackBerry::WebKit::BackingStorePrivate::setDirectRenderingAnimationMessageScheduled):

  • Api/WebPage_p.h:

(BlackBerry::WebKit::WebPagePrivate::isAcceleratedCompositingActive):
(WebPagePrivate):

  • WebKitSupport/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
(BlackBerry::WebKit::WebPageCompositor::~WebPageCompositor):
(BlackBerry::WebKit::WebPageCompositor::drawLayers):
(BlackBerry::WebKit::WebPageCompositor::animationTimerFired):

  • WebKitSupport/WebPageCompositor.h:

(WebPageCompositor):

08:34 Changeset [109750] by carlosgc@webkit.org
  • 14 edits
    1 delete in trunk/Source/WebKit2

[WK2] WKPageGetContextMenuFromProposedContextMenuCallback should pass a HitTestResult
https://bugs.webkit.org/show_bug.cgi?id=77208

Reviewed by Anders Carlsson.

A HitTestResultData is now passed to ShowContextMenu WebPageProxy
message instead of the ContextMenuState. ContextMenu client has
been updated to pass the HitTestResult to the
getContextMenuFromProposedMenu callback.

  • GNUmakefile.am: Remove ContextMenuState.h.
  • Shared/APIClientTraits.h:
  • Shared/ContextMenuState.h: Removed.
  • Shared/WebHitTestResult.h:

(WebKit::WebHitTestResult::Data::Data): Add constructor that takes
a WebCore::HitTestResult.

  • UIProcess/API/C/WKPage.h: Add HitTestResult parameter to

getContextMenuFromProposedMenu callback and deprecate the old
version.

  • UIProcess/WebPageContextMenuClient.cpp:

(WebKit::WebPageContextMenuClient::getContextMenuFromProposedMenu):
Pass a HitTestResult to getContextMenuFromProposedMenu or use the
deprecated one if client version is an old one.

  • UIProcess/WebPageContextMenuClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showContextMenu):
(WebKit::WebPageProxy::internalShowContextMenu): Save the
WebHitTestResult::Data to use it for handling context menu actions.
(WebKit::WebPageProxy::contextMenuItemSelected): Use the saved
WebHitTestResult::Data.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebKit2.xcodeproj/project.pbxproj: Remove ContextMenuState.h.
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::mouseDidMoveOverElement): Use the new
WebHitTestResult::Data constructor that takes a WebCore::HitTestResult.

  • WebProcess/WebPage/WebContextMenu.cpp:

(WebKit::WebContextMenu::show): Create a WebHitTestResult::Data
instead of a ContextMenuState and pass it to ShowContextMenu message.

  • win/WebKit2.vcproj: ContextMenuState.h.
08:26 Changeset [109749] by rwlbuis@webkit.org
  • 6 edits in trunk/Tools

[BlackBerry] Update Tools/DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=80287

Reviewed by Antonio Gomes.

Update so we are sure we can build our implementation of DRT.

  • DumpRenderTree/DumpRenderTree.h: include DumpRenderTreeBlackBerry.h.
  • DumpRenderTree/PixelDumpSupport.cpp: include PixelDumpSupportBlackBerry.h.
  • DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp:

(AccessibilityController::addNotificationListener): add missing hook.
(AccessibilityController::removeNotificationListener): add missing hook.

  • DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:

(AccessibilityUIElement::isSelectedOptionActive): add missing hook.

  • DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:

(LayoutTestController::setMockSpeechInputDumpRect): add missing hook.
(LayoutTestController::simulateDesktopNotificationClick): add missing hook.

07:52 Changeset [109748] by noam.rosenthal@nokia.com
  • 10 edits
    2 adds in trunk

[Qt] [WK2] Support threaded renderer in WK2
https://bugs.webkit.org/show_bug.cgi?id=76661

Source/WebKit2:

Made the appropriate fixes in the UI process code to make rendering thread-safe.

  • Separated the scenegraph node code to QtWebPageSGNode. QtWebPageSGNode has direct access to LayerTreeHostProxy.
  • Each function in LayerTreeHostProxy can be either called from the main thread (handling messages from the web process), or from the renderer thread (handling the GL context). The render-queue is locked with a mutex, and messages back to the web process are sent via callOnMainThread.
  • LayerTreeHostProxy is now ThreadSafeRefCounted. That is done to make sure that the GL resources it creates are only freed when the QtWebPageSGNode is deleted, which can be before or after the owning DrawingAreaProxy is deleted. This ensures that the class is deleted only after its GL resources are freed, otherwise those resources may leak.

Based on a patch by Viatcheslav Ostapenko.

Reviewed by Kenneth Rohde Christiansen.

  • Target.pri: Added new files.
  • UIProcess/API/qt/qquickwebpage.cpp: Moved QtWebPageSGNode out.

(QQuickWebPage::updatePaintNode): Call QtWebPageSGNode
(QQuickWebPagePrivate::updateSize): Call QtWebPageSGNode
(QQuickWebPagePrivate::didDeleteSGWebPageNode): Override QtWebPageSGNode::Client
(QQuickWebPagePrivate::~QQuickWebPagePrivate):

  • UIProcess/API/qt/qquickwebpage_p_p.h:

(QQuickWebPagePrivate):

  • UIProcess/DrawingAreaProxy.h:

(WebKit):
(WebKit::DrawingAreaProxy::layerTreeHostProxy): Made LayerTreeHostProxy ref-counted.
(DrawingAreaProxy):

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):

  • UIProcess/LayerTreeHostProxy.h:

(WebKit):
(WebKit::LayerTreeHostProxy::create):
(LayerTreeHostProxy):

  • UIProcess/qt/LayerTreeHostProxyQt.cpp:

(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit):
(MainThreadGuardedInvoker):

A class that allows invoking functions in the main thread, while guarding a ref-
counted object.

(WebKit::MainThreadGuardedInvoker::call):
(WebKit::MainThreadGuardedInvoker::MainThreadGuardedInvoker):
(WebKit::MainThreadGuardedInvoker::invoke):
(WebKit::LayerTreeHostProxy::syncAnimations):
(WebKit::LayerTreeHostProxy::updateViewport):
(WebKit::LayerTreeHostProxy::detachDrawingArea):
(WebKit::LayerTreeHostProxy::syncLayerParameters):
(WebKit::LayerTreeHostProxy::setShouldRenderNextFrame):
(WebKit::LayerTreeHostProxy::flushLayerChanges):
(WebKit::LayerTreeHostProxy::ensureRootLayer):
(WebKit::LayerTreeHostProxy::syncRemoteContent):
(WebKit::LayerTreeHostProxy::dispatchUpdate):
(WebKit::LayerTreeHostProxy::createDirectlyCompositedImage):
(WebKit::LayerTreeHostProxy::purgeGLResources):

  • UIProcess/qt/QtWebPageSGNode.cpp: Added.
  • UIProcess/qt/QtWebPageSGNode.h: Added.

Tools:

Remove the QML_NO_THREADED_RENDERER environment variable from MiniBrowser.

Reviewed by Kenneth Rohde Christiansen.

  • MiniBrowser/qt/main.cpp:

(main):

07:37 Changeset [109747] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] DOMSupport visibleSelectionForRangeInputElement incorrectly dereferences a null range.
https://bugs.webkit.org/show_bug.cgi?id=80274

Patch by George Staikos <gstaikos@rim.com> on 2012-03-05
Reviewed by Antonio Gomes.

A null range can be returned so we should not blindly deref it.
Reviewed Internally by Mike Fenton.

  • WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::visibleSelectionForRangeInputElement):

07:36 Changeset [109746] by ahf@0x90.dk
  • 3 edits in trunk/Source/WebCore

Remove pointer to timer and use the timers directly in the tiled backing store https://bugs.webkit.org/show_bug.cgi?id=80283

Patch by Kenneth Rohde Christiansen and Alexander Færøy.

Reviewed by Simon Hausmann.

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::TiledBackingStore):
(WebCore::TiledBackingStore::~TiledBackingStore):
(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::startTileBufferUpdateTimer):
(WebCore::TiledBackingStore::startTileCreationTimer):

  • platform/graphics/TiledBackingStore.h:

(TiledBackingStore):

07:35 Changeset [109745] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Styles] Tabbing an empty new property in the middle of style moves the editor to the next section
https://bugs.webkit.org/show_bug.cgi?id=80264

Reviewed by Pavel Feldman.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertyTreeElement.prototype.element.userInput.previousContent.context.moveDirection.alreadyNew):
(WebInspector.StylePropertyTreeElement.prototype):

07:30 Changeset [109744] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Update LocalizedStringsBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=80278

Reviewed by Antonio Gomes.

Update LocalizedStringsBlackBerry.cpp to current HEAD.

  • platform/blackberry/LocalizedStringsBlackBerry.cpp:

(WebCore::inputElementAltText): fall back to "Submit".
(WebCore::imageTitle): choose the format "filename(widthxheight)" like Chrome does.
(WebCore::fileButtonNoFilesSelectedLabel): fall back to "No File Chosen" translation like Chrome does.
(WebCore):

07:24 Changeset [109743] by loislo@chromium.org
  • 3 edits
    1 add in trunk

Web Inspector: [chromium] introduce HeapSnapshot performance test.
https://bugs.webkit.org/show_bug.cgi?id=80280

Reviewed by Pavel Feldman.

PerformanceTests:

  • inspector/detailed-heapshots-smoke-test.html: Added.

Source/WebCore:

  • inspector/front-end/HeapSnapshotProxy.js:

(WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading.updateStaticData):
(WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading):
(WebInspector.HeapSnapshotLoaderProxy.prototype._callLoadCallbacks):

07:14 Changeset [109742] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: cannot be launched when localStorage is disabled
https://bugs.webkit.org/show_bug.cgi?id=80252

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/Settings.js:
07:07 Changeset [109741] by pfeldman@chromium.org
  • 4 edits
    2 adds in trunk

Web Inspector: check for the number of parsed css properties.
https://bugs.webkit.org/show_bug.cgi?id=80268

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: inspector/styles/set-property-boundaries.html

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::didRemoveDOMNode):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::setPropertyText):

LayoutTests:

  • inspector/styles/set-property-boundaries-expected.txt: Added.
  • inspector/styles/set-property-boundaries.html: Added.
07:00 Changeset [109740] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Tabbed pane should redraw tab elements when tab is closed.
https://bugs.webkit.org/show_bug.cgi?id=80273

Reviewed by Pavel Feldman.

  • inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPane.prototype.closeTab):

06:55 WebKitGTK/WebKit2Roadmap edited by carlosgc@webkit.org
1.8 milestones done! (diff)
06:54 Changeset [109739] by ahf@0x90.dk
  • 2 edits in trunk/Source/WebCore

Improve comments in the tiled backing store https://bugs.webkit.org/show_bug.cgi?id=80279

Patch by Kenneth Rohde Christiansen and Alexander Færøy.

Reviewed by Simon Hausmann.

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::createTiles):

06:26 Changeset [109738] by ahf@0x90.dk
  • 3 edits in trunk/Source/WebCore

TiledBackingStore.{h,cpp} contains unclear variable names https://bugs.webkit.org/show_bug.cgi?id=80276

Patch by Kenneth Rohde Christiansen and Alexander Færøy.

Reviewed by Simon Hausmann.

This patch renames some of the variables in TiledBackingStore.cpp to
enhance the clearity and for consistence.

The visibleContentsRect is renamed to visibleRect as it is not in
contents coordinates.

The panningTrajectoryVector and m_visibleRectTrajectoryVector are
renamed to just *[m_]trajectoryVector, as that is descriptive enough.

The previous prefix has also been removed, as it is being used as the
current one in the code. This avoids confusion.

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::coverWithTilesIfNeeded):
(WebCore::TiledBackingStore::visibleRect):
(WebCore::TiledBackingStore::visibleAreaIsCovered):
(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::computeCoverAndKeepRect):
(WebCore::TiledBackingStore::removeAllNonVisibleTiles):

  • platform/graphics/TiledBackingStore.h:

(TiledBackingStore):

06:16 Changeset [109737] by hausmann@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Fix build with Qt 5 and OpenGL ES 2.0

Reviewed by Noam Rosenthal.

  • platform/graphics/texmap/TextureMapper.h: Since we don't do QT += opengl with Qt 5 anymore

here in WebCore, we cannot check for QT_OPENGL_LIB. But since this is Qt5, we know that the
GLES setting comes qconfig.h and we can rely on it.

06:00 Changeset [109736] by ahf@0x90.dk
  • 2 edits in trunk/Source/WebCore

Whitespace clean-up of TiledBackingStore.cpp.

Rubber-stamped by Kenneth Rohde Christiansen.

Already covered by existing tests.

  • platform/graphics/TiledBackingStore.cpp:

(WebCore):
(WebCore::TiledBackingStore::updateTileBuffers):
(WebCore::TiledBackingStore::paint):

05:57 Changeset [109735] by carlosgc@webkit.org
  • 4 edits in trunk/Source

Unreviewed. Fix make distcheck.

Source/JavaScriptCore:

  • GNUmakefile.list.am: Add missing header file.

Source/WebCore:

  • GNUmakefile.list.am: Add missing header file.
05:29 Changeset [109734] by ahf@0x90.dk
  • 2 edits in trunk/Tools

Unreviewed. Add myself to committer list.

  • Scripts/webkitpy/common/config/committers.py:
05:28 WebKitGTK/1.8.x edited by carlosgc@webkit.org
(diff)
05:00 Changeset [109733] by vestbo@webkit.org
  • 6 edits
    3 adds in trunk/Tools

[Qt] Use config test to determine if the compiler supports -MD

We used to assume that unix systems building against Qt5 would have
a compiler that supported -MD. Although this was usually the case,
we failed to take into account broken tools for distributed builds
(e.g. teambuilder or icecream) which would end up producing .d files
in the root of the build dir instead of along-side the object file.

Now that we use a config-test to determine the support, we'll capture
those cases, unless distributed builds are enabled after the initial
build-webkit run.

Reviewed by Csaba Osztrogonác.

04:03 Changeset [109732] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Incorrect appropriateSelectorFor() suggestion for when a DOMNode has more than 2 CSS classes
https://bugs.webkit.org/show_bug.cgi?id=80258

Reviewed by Pavel Feldman.

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode.prototype.appropriateSelectorFor):

03:55 Changeset [109731] by wingo@igalia.com
  • 3 edits in trunk/Source/JavaScriptCore

WTF: Micro-optimize cleanup of empty vectors and hash tables
https://bugs.webkit.org/show_bug.cgi?id=79903

Reviewed by Michael Saboff and Geoffrey Garen.

This patch speeds up cleanup of vectors and hash tables whose
backing store was never allocated. This is the case by default
for most vectors / hash tables that never had any entries added.

The result for me is that calling checkSyntax 1000 times on
concat-jquery-mootools-prototype.js goes from 6.234s to 6.068s, a
2.4% speedup.

  • wtf/HashTable.h:

(WTF::HashTable::~HashTable):
(WTF::::clear): Don't deallocate the storage or frob member
variables if there is no backing storage.

  • wtf/Vector.h:

(WTF::VectorBufferBase::deallocateBuffer): Likewise.

02:44 Changeset [109730] by apavlov@chromium.org
  • 7 edits
    2 adds in trunk

Web Inspector: [Styles] [CRASH] Handle rule addition and inline style editing failure due to Content-Security-Policy in the page
https://bugs.webkit.org/show_bug.cgi?id=80024

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/styles/add-new-rule-inline-style-csp.html

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):

  • inspector/InspectorCSSAgent.h:

(InlineStyleOverrideScope):
(WebCore::InspectorCSSAgent::InlineStyleOverrideScope::InlineStyleOverrideScope):
(WebCore::InspectorCSSAgent::InlineStyleOverrideScope::~InlineStyleOverrideScope):
(InspectorCSSAgent):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheetForInlineStyle::setStyleText):

  • page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
(WebCore::ContentSecurityPolicy::allowInlineStyle):
(WebCore::ContentSecurityPolicy::setOverrideAllowInlineStyle):
(WebCore):

  • page/ContentSecurityPolicy.h:

(ContentSecurityPolicy):

LayoutTests:

  • inspector/styles/add-new-rule-inline-style-csp-expected.txt: Added.
  • inspector/styles/add-new-rule-inline-style-csp.html: Added.
02:26 Changeset [109729] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[Forms] The "optgroup" element should not be a form-associated element
https://bugs.webkit.org/show_bug.cgi?id=80234

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-05
Reviewed by Kent Tamura.

This patch changes base class of HTMLOptGroup to HTMLElement from
HTMLFormControlElement to avoid the "optgroup" element in form-associate
elements collection.

This patch doesn't affect HTMLOptionElement::disabled's static_cast. However,
it doesn't good at coding style. This patch also fix it.

No new tests. No behavior changes.

  • html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::HTMLOptGroupElement): Remove "form" parameter.
(WebCore::HTMLOptGroupElement::create): Remove "form" parameter.
(WebCore::HTMLOptGroupElement::childrenChanged): Replace base method call.
(WebCore::HTMLOptGroupElement::parseAttribute): Replace base method call.
(WebCore::HTMLOptGroupElement::attach): Replace base method call.
(WebCore::HTMLOptGroupElement::detach): Replace base method call.

  • html/HTMLOptGroupElement.h:

(HTMLOptGroupElement): Change base class to HTMLElement.

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::disabled): Replace static_cast<HTMLFormControlElement*> to static_cast<HTMLElement*> with checking isHTMLElement.

  • html/HTMLTagNames.in: Remove "constructorNeedsFormElement" for not passing "form" parameter in HTMLElementFactory.
02:01 Changeset [109728] by podivilov@chromium.org
  • 4 edits in trunk

Web Inspector: fix extensions-resource.html test.
https://bugs.webkit.org/show_bug.cgi?id=80183

Reviewed by Vsevolod Vlasov.

Source/WebCore:

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor):

LayoutTests:

  • platform/chromium/test_expectations.txt:
01:49 Changeset [109727] by tkent@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

[Chromium] Rebaseline search-field-cancel.html for r109503.
Fix an error of the previous rebaseline.

  • platform/chromium-mac-snowleopard/fast/repaint/search-field-cancel-expected.txt: Removed.
  • platform/chromium-win/fast/repaint/search-field-cancel-expected.txt:
01:24 Changeset [109726] by ossy@webkit.org
  • 2 edits in trunk/Tools

Qt API test buildstep throws exception after buildmaster update
https://bugs.webkit.org/show_bug.cgi?id=80249

Reviewed by Zoltan Herczeg.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Disable API tests on the Qt bot temporarily.

(BuildAndTestFactory.init):

01:05 Changeset [109725] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, skip a new failing test.

  • platform/qt/Skipped:
00:48 Changeset [109724] by caseq@chromium.org
  • 17 edits in trunk

Add instrumentation for frame start/end on timeline.

Web Inspector: add timeline instrumentation for frame events
https://bugs.webkit.org/show_bug.cgi?id=80127

Reviewed by Pavel Feldman.

Source/WebCore:

  • display frame boundaries when vertical overview mode is on
  • aggregate by frame in vertical overview mode
  • switched event filtering criteria from index to time in vertical overview mode
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didBeginFrameImpl):
(WebCore):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didBeginFrame):
(WebCore):

  • inspector/InspectorTimelineAgent.cpp:

(TimelineRecordType):
(WebCore::InspectorTimelineAgent::didBeginFrame):
(WebCore):

  • inspector/InspectorTimelineAgent.h:

(InspectorTimelineAgent):

  • inspector/front-end/TimelineModel.js:
  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype._showMemoryGraph):
(WebInspector.TimelineOverviewPane.prototype.setStartAtZero):
(WebInspector.TimelineOverviewPane.prototype.updateEventDividers):
(WebInspector.TimelineOverviewPane.prototype.sidebarResized):
(WebInspector.TimelineOverviewPane.prototype.reset):
(WebInspector.TimelineOverviewPane.prototype.accept):
(WebInspector.TimelineOverviewPane.prototype.windowStartTime):
(WebInspector.TimelineOverviewPane.prototype.windowEndTime):
(WebInspector.TimelineOverviewPane.prototype._onWindowChanged):
(WebInspector.TimelineStartAtZeroOverview):
(WebInspector.TimelineStartAtZeroOverview.prototype.reset):
(WebInspector.TimelineStartAtZeroOverview.prototype.update):
(WebInspector.TimelineStartAtZeroOverview.prototype._aggregateFrames):
(WebInspector.TimelineStartAtZeroOverview.prototype._aggregateFrameStatistics):
(WebInspector.TimelineStartAtZeroOverview.prototype._aggregateRecords):
(WebInspector.TimelineStartAtZeroOverview.prototype._buildBar):
(WebInspector.TimelineStartAtZeroOverview.prototype.getWindowTimes):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._updateEventDividers):
(WebInspector.TimelinePanel.prototype._createEventDivider):
(WebInspector.TimelinePanel.prototype._toggleStartAtZeroButtonClicked):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline.addTimestampRecords):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype._refresh):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelineCategoryFilter.prototype.accept):

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.prototype.get _recordStyles):

  • inspector/front-end/inspectorCommon.css:
  • inspector/front-end/timelinePanel.css:

(#timeline-container):
(.timeline .resources-event-divider):
(.timeline.timeline-start-at-zero .resources-divider):
(.timeline .resources-event-divider.timeline-frame-divider):

Source/WebKit/chromium:

  • expose an instrumentation method from WebWidget to mark frame update start
  • public/WebWidget.h:

(WebWidget):
(WebKit::WebWidget::instrumentBeginFrame):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::instrumentBeginFrame):
(WebKit):

  • src/WebViewImpl.h:

(WebViewImpl):

LayoutTests:

  • inspector/timeline/timeline-enum-stability-expected.txt:
00:44 Changeset [109723] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for !ENABLE(SHADOW_DOM).

  • html/shadow/HTMLContentElement.cpp:

(WebCore::contentTagName):

00:42 Changeset [109722] by mrobinson@webkit.org
  • 2 edits in trunk/Tools

[GTK] Unit tests are noisy when run under jhbuild
https://bugs.webkit.org/show_bug.cgi?id=80241

Reviewed by Philippe Normand.

Force the 'memory' backend in GSettings so that each unit
test doesn't produce a warning when it's forced to fall back
to the 'memory' backend.

  • Scripts/run-gtk-tests:

(TestRunner.run): Force the 'memory' backend.

00:37 Changeset [109721] by morrita@google.com
  • 14 edits
    2 adds in trunk

Internally used HTMLContentElement subclasses should have correct wrapper.
https://bugs.webkit.org/show_bug.cgi?id=80237

Reviewed by Kent Tamura.

Source/WebCore:

DetailsContentElement and DetailsSummaryElement used to use
<div> as their tag name. But this means they are wrapped by
wrapper objects for HTMLDivElement, which is wrong. This happened
to work though because HTMLDivElement has no extra state or API.

This change introduces "noConstructor" keyword for make_name.pl
sources. This keyword allows a tag name to specify its own
wrapper without making the tag name visible from the parser, or
HTMLElementFactory in precise.

Following this addition, this change also adds a new tag name
"webkitShadowContent" for DetailsContentElement and DetailsSummaryElement,
which has no constructor, and whose wrapper type is HTMLElement.

This change isn't visible from the page author and only matters for testing.

Test: fast/dom/shadow/content-element-user-agent-shadow.html

  • dom/make_names.pl:

(defaultTagPropertyHash):
(buildConstructorMap):
(printConstructors):
(printFunctionInits):

  • html/HTMLDetailsElement.cpp:

(WebCore::DetailsContentElement::DetailsContentElement):
(WebCore::DetailsSummaryElement::DetailsSummaryElement):

  • html/HTMLTagNames.in:
  • html/shadow/HTMLContentElement.cpp:

(WebCore::contentTagName):

LayoutTests:

  • fast/dom/shadow/content-element-user-agent-shadow-expected.txt: Added.
  • fast/dom/shadow/content-element-user-agent-shadow.html: Added.
  • platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/gtk/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/qt/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/qt/fast/html/details-remove-summary-4-and-click-expected.txt:
00:35 Changeset [109720] by mrobinson@webkit.org
  • 4 edits in trunk

[GTK] "Console: undefined @0: ReferenceError: Can't find variable: WebInspector" during testwebinspector
https://bugs.webkit.org/show_bug.cgi?id=80235

Reviewed by Philippe Normand.

Source/WebKit/gtk:

Wait to inspect the WebView until the page has finished loading. Also
clean up some minor style errors.

  • tests/testwebinspector.c:

(closeInspector): Small style fixes.
(showInspector): Ditto.
(loadFinished): Ditto.
(test_webkit_web_inspector_close_and_inspect): Wait to inspect until the page has loaded.
(test_webkit_web_inspector_destroy_inspected_web_view): Ditto.
(main): Small style fixes.

Tools:

  • Scripts/run-gtk-tests:

(TestRunner.run): Use the WEBKIT_INSPECTOR_PATH environment variable so that
inspector resources path determination is shared by all tests.

00:28 Changeset [109719] by mrobinson@webkit.org
  • 7 edits in trunk

[GTK] REGRESSION: r108278 broke some tests that expect focus
https://bugs.webkit.org/show_bug.cgi?id=79084

Reviewed by Philippe Normand.

Source/WebKit/gtk:

Grab focus before running the test. This ensures that if the
WebView lost focus, it has it before sending events.

  • tests/testcopyandpaste.c:

(test_copy_and_paste): Grab focus.

Tools:

Grab focus when dumping test results and also when sending
events. During the course of testing, the WebView may lose
focus and this seems to snap it back when tests demand it.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(dump): Grab focus.

  • DumpRenderTree/gtk/EventSender.cpp:

(dispatchEvent): Ditto.

LayoutTests:

  • platform/gtk/Skipped: Unskip passing tests.
00:22 Changeset [109718] by shinyak@chromium.org
  • 5 edits in trunk/Source/WebCore

Refactoring: Move HTMLContentElement::attach to InsertionPoint::attach.
https://bugs.webkit.org/show_bug.cgi?id=80243

Reviewed by Hajime Morita.

Since the current code in HTMLContentElement::attach() will be used for coming <shadow>
elements, it is natural that InsertionPoint::attach() has such code.

No new tests, no change in behavior.

  • html/shadow/HTMLContentElement.cpp:
  • html/shadow/HTMLContentElement.h:

(HTMLContentElement):

  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::attach):
(WebCore):
(WebCore::InsertionPoint::detach):

  • html/shadow/InsertionPoint.h:

(InsertionPoint):

00:18 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
00:18 Changeset [109717] by tkent@chromium.org
  • 5 edits
    3 adds in trunk/LayoutTests

[Chromium] Rebaseline search-field-cancel.html for r109503.

  • platform/chromium-linux/fast/repaint/search-field-cancel-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/search-field-cancel-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/search-field-cancel-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/search-field-cancel-expected.txt: Added.
  • platform/chromium-win/fast/repaint/search-field-cancel-expected.png:
  • platform/chromium-win/fast/repaint/search-field-cancel-expected.txt:
  • platform/chromium/test_expectations.txt:
00:13 Changeset [109716] by abarth@webkit.org
  • 12 edits in trunk/Source/WebCore

allowDatabaseAccess and databaseExceededQuota should be part of DatabaseContext not ScriptExecutionContext
https://bugs.webkit.org/show_bug.cgi?id=80178

Reviewed by Eric Seidel.

These functions are only used by SQLDatabase, which means we can move
them to DatabaseContext, removing one more tendril of the SQLDatabase
code.

  • dom/Document.cpp:

(WebCore):

  • dom/Document.h:

(Document):

  • dom/ScriptExecutionContext.h:

(ScriptExecutionContext):

  • storage/DatabaseContext.cpp:

(WebCore::DatabaseContext::DatabaseContext):
(WebCore::DatabaseContext::from):
(WebCore::DatabaseContext::allowDatabaseAccess):
(WebCore):
(WebCore::DatabaseContext::databaseExceededQuota):

  • storage/DatabaseContext.h:

(DatabaseContext):

  • storage/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::canEstablishDatabase):

  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::executeSQL):

  • storage/SQLTransactionClient.cpp:

(WebCore::SQLTransactionClient::didExceedQuota):

  • storage/SQLTransactionSync.cpp:

(WebCore::SQLTransactionSync::executeSQL):

  • workers/WorkerContext.cpp:

(WebCore):

  • workers/WorkerContext.h:

(WorkerContext):

00:08 Changeset [109715] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore

Merging r109580

00:07 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
00:07 Changeset [109714] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merging r109509

00:05 Changeset [109713] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merging r109396

00:03 Changeset [109712] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, mark two tests as flaky in GTK.

  • platform/gtk/test_expectations.txt:

editing/selection/select-line-break-with-opposite-directionality.html
and fast/css/hover-update.html are flaky.

00:02 Changeset [109711] by mrobinson@webkit.org
  • 13 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore

Merging 109515

03/04/12:

23:58 Changeset [109710] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Tools

Merging r108540

23:57 Changeset [109709] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r107551.
http://trac.webkit.org/changeset/107551
https://bugs.webkit.org/show_bug.cgi?id=80245

caused incorrect style sharing (Requested by kling on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-04

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

23:56 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
23:56 Changeset [109708] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit2

Merging r108760

23:50 Changeset [109707] by mrobinson@webkit.org
  • 4 edits in releases/WebKitGTK/webkit-1.8/Source

Merging r108631

23:47 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
22:57 Changeset [109706] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove unused macro HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE_WITH_VALUE.
https://bugs.webkit.org/show_bug.cgi?id=80236

Reviewed by Eric Seidel.

No new tests / unused code deletion only.

  • css/CSSStyleSelector.cpp:

(WebCore):

22:52 Changeset [109705] by fpizlo@apple.com
  • 21 edits
    4 adds in trunk/Source

JIT heuristics should be hyperbolic
https://bugs.webkit.org/show_bug.cgi?id=80055
<rdar://problem/10922260>

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Added tracking of the amount of executable memory typically used for a bytecode
instruction. Modified the execution counter scheme to use this, and the amount
of free memory, to determine how long to wait before invoking the JIT.

The result is that even if we bomb the VM with more code than can fit in our
executable memory pool, we still keep running and almost never run out of
executable memory - which ensures that if we have to JIT something critical, then
we'll likely have enough memory to do so. This also does not regress performance
on the three main benchmarks.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::predictedMachineCodeSize):
(JSC):
(JSC::CodeBlock::usesOpcode):

  • bytecode/CodeBlock.h:

(CodeBlock):
(JSC::CodeBlock::checkIfJITThresholdReached):
(JSC::CodeBlock::dontJITAnytimeSoon):
(JSC::CodeBlock::jitAfterWarmUp):
(JSC::CodeBlock::jitSoon):
(JSC::CodeBlock::llintExecuteCounter):
(JSC::CodeBlock::counterValueForOptimizeAfterWarmUp):
(JSC::CodeBlock::counterValueForOptimizeAfterLongWarmUp):
(JSC::CodeBlock::addressOfJITExecuteCounter):
(JSC::CodeBlock::offsetOfJITExecuteCounter):
(JSC::CodeBlock::offsetOfJITExecutionActiveThreshold):
(JSC::CodeBlock::offsetOfJITExecutionTotalCount):
(JSC::CodeBlock::jitExecuteCounter):
(JSC::CodeBlock::checkIfOptimizationThresholdReached):
(JSC::CodeBlock::optimizeNextInvocation):
(JSC::CodeBlock::dontOptimizeAnytimeSoon):
(JSC::CodeBlock::optimizeAfterWarmUp):
(JSC::CodeBlock::optimizeAfterLongWarmUp):
(JSC::CodeBlock::optimizeSoon):

  • bytecode/ExecutionCounter.cpp: Added.

(JSC):
(JSC::ExecutionCounter::ExecutionCounter):
(JSC::ExecutionCounter::checkIfThresholdCrossedAndSet):
(JSC::ExecutionCounter::setNewThreshold):
(JSC::ExecutionCounter::deferIndefinitely):
(JSC::ExecutionCounter::applyMemoryUsageHeuristics):
(JSC::ExecutionCounter::applyMemoryUsageHeuristicsAndConvertToInt):
(JSC::ExecutionCounter::hasCrossedThreshold):
(JSC::ExecutionCounter::setThreshold):
(JSC::ExecutionCounter::reset):

  • bytecode/ExecutionCounter.h: Added.

(JSC):
(ExecutionCounter):
(JSC::ExecutionCounter::formattedTotalCount):

  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • jit/ExecutableAllocator.cpp:

(JSC::DemandExecutableAllocator::allocateNewSpace):
(JSC::ExecutableAllocator::underMemoryPressure):
(JSC):
(JSC::ExecutableAllocator::memoryPressureMultiplier):

  • jit/ExecutableAllocator.h:
  • jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::ExecutableAllocator::memoryPressureMultiplier):
(JSC):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::jitCompileAndSetHeuristics):

  • llint/LowLevelInterpreter32_64.asm:
  • runtime/JSGlobalData.h:

(JSGlobalData):

  • runtime/Options.cpp:

(Options):
(JSC::Options::initializeOptions):

  • runtime/Options.h:

(Options):

  • wtf/SimpleStats.h: Added.

(WTF):
(SimpleStats):
(WTF::SimpleStats::SimpleStats):
(WTF::SimpleStats::add):
(WTF::SimpleStats::operator!):
(WTF::SimpleStats::count):
(WTF::SimpleStats::sum):
(WTF::SimpleStats::sumOfSquares):
(WTF::SimpleStats::mean):
(WTF::SimpleStats::variance):
(WTF::SimpleStats::standardDeviation):

Source/WebCore:

Reviewed by Oliver Hunt.

No new tests, since there's no new functionality.

  • ForwardingHeaders/wtf/SimpleStats.h: Added.
22:30 Changeset [109704] by shinyak@chromium.org
  • 5 edits in trunk

Source/WebCore: Methods like firstRendererOf of NodeRenderingContext should be extracted.
https://bugs.webkit.org/show_bug.cgi?id=79902

Reviewed by Hajime Morita.

firstRendererOfInsertionPoint should return the first renderer of its child, however
it returns next renderer of parent. The same thing happens lastRendererOfInsertionPoint.

Test: content-element-move.html has another test case.

  • dom/NodeRenderingContext.cpp:

(WebCore):
(WebCore::nextRendererOfInsertionPoint):
(WebCore::previousRendererOfInsertionPoint):
(WebCore::firstRendererOfInsertionPoint):
(WebCore::lastRendererOfInsertionPoint):
(WebCore::firstRendererOf):
(WebCore::lastRendererOf):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):

LayoutTests: Refactoring: Methods like firstRendererOf of NodeRenderingContext should be extracted.
https://bugs.webkit.org/show_bug.cgi?id=79902

Reviewed by Hajime Morita.

Added a new test case.

  • fast/dom/shadow/content-element-move-expected.txt:
  • fast/dom/shadow/content-element-move.html:
20:43 Changeset [109703] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for ENABLE(MATHML).

  • mathml/MathMLElement.h:

(WebCore):

20:09 Changeset [109702] by morrita@google.com
  • 6 edits in trunk/Source/WebCore

WebKit needs toHTMLUnknownElement() and isUnknown() for sanity check.
https://bugs.webkit.org/show_bug.cgi?id=80229

Reviewed by Kent Tamura.

The code generator has naked static_cast<> which could be unsafe.
We can turn it into toHTMLUnknownElement() and the like.

No new tests. Just added a sanity check.

  • dom/make_names.pl:

(printWrapperFactoryCppFile):

  • html/HTMLElement.h:

(HTMLElement):
(WebCore::HTMLElement::isHTMLUnknownElement):

  • html/HTMLUnknownElement.h:

(HTMLUnknownElement):
(WebCore::toHTMLUnknownElement):
(WebCore):

  • mathml/MathMLElement.h:

(toMathMLElement):

  • svg/SVGElement.h:

(WebCore::toSVGElement):
(WebCore):

20:02 Changeset [109701] by charles.wei@torchmobile.com.cn
  • 2 edits in trunk/Tools

Unreviewed, Add myself to committer list.
https://bugs.webkit.org/show_bug.cgi?id=80232

  • Scripts/webkitpy/common/config/committers.py:
19:44 Changeset [109700] by yuzo@google.com
  • 6 edits
    3 copies in branches/chromium/1025

Merge 108574 - REGRESSION (r104060): Web font is not loaded if specified by link element dynamically inserted
https://bugs.webkit.org/show_bug.cgi?id=79186

Reviewed by Andreas Kling.

Source/WebCore:

Test: fast/css/font-face-insert-link.html

If a dynamically inserted stylesheet contains @font-face rules, we may fail to update the rendering.

Before r104060 the style selector was destroyed on every style change, and the font selector along with it.
This is no longer the case and we can't rely on comparing font selector pointers when comparing Fonts
for equality. This patch adds version number to the font selector and checks it in Font::operator==.
The version number is incremented when new font-face rules are added to the font selector.

FontFallbackList is an object shared between Fonts so the extra field shouldn't matter much in terms
of memory.

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::CSSFontSelector):
(WebCore::CSSFontSelector::addFontFaceRule):

  • css/CSSFontSelector.h:

(CSSFontSelector):

  • platform/graphics/Font.cpp:

(WebCore::Font::operator==):

  • platform/graphics/FontFallbackList.cpp:

(WebCore::FontFallbackList::FontFallbackList):
(WebCore::FontFallbackList::invalidate):

  • platform/graphics/FontFallbackList.h:

(FontFallbackList):
(WebCore::FontFallbackList::fontSelectorVersion):

  • platform/graphics/FontSelector.h:

(FontSelector):

LayoutTests:

  • fast/css/font-face-insert-link-expected.txt: Added.
  • fast/css/font-face-insert-link.html: Added.
  • fast/css/resources/ahem.css: Added.

(@font-face):

TBR=karen@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9595009

19:38 Changeset [109699] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Handle CSSPropertyWebkitColumnBreakAfter, CSSPropertyWebkitColumnBreakBefore and CSSPropertyWebkitColumnBreakInside in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=80226

Reviewed by Eric Seidel.

No new tests / refactoring only.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

19:29 Changeset [109698] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk/Source/WebKit

[BlackBerry] upstream CredentialManager and CredentialTransformData implementation
https://bugs.webkit.org/show_bug.cgi?id=80107

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-03-04
Reviewed by Antonio Gomes.

Initial upstream of CredentialManager.[h|cpp] and
CredentialTransformData.[h|cpp].
No new test.

Source/WebKit:

  • PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

  • WebCoreSupport/CredentialManager.cpp: Added.

(WebCore):
(WebCore::CredentialManager::CredentialManager):
(WebCore::CredentialManager::autofillAuthenticationChallenge):
(WebCore::CredentialManager::autofillPasswordForms):
(WebCore::CredentialManager::saveCredentialIfConfirmed):

  • WebCoreSupport/CredentialManager.h: Added.

(WebKit):
(WebCore):
(CredentialManager):

  • WebCoreSupport/CredentialTransformData.cpp: Added.

(WebCore::CredentialTransformData::CredentialTransformData):
(WebCore):
(WebCore::CredentialTransformData::url):
(WebCore::CredentialTransformData::credential):
(WebCore::CredentialTransformData::setCredential):
(WebCore::CredentialTransformData::findPasswordFormFields):

  • WebCoreSupport/CredentialTransformData.h: Added.

(WebCore):
(CredentialTransformData):
(WebCore::CredentialTransformData::isValid):
(WebCore::CredentialTransformData::protectionSpace):

19:23 Changeset [109697] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Credential backing store implementation
https://bugs.webkit.org/show_bug.cgi?id=79650

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-03-04
Reviewed by Antonio Gomes.

Opened Credential database in CedentialBackingStore::instance().
Added never_remember table and associated sql statment
members to store the never remember sites.
Removed CredentialStorage initialize codes because that
won't give users a chance to re-enter the new credential
information for an already stored site.
Changed login update and has statement to support
autofill feature of multiple credential forms in the
same page; Also added url as a parameter of hasLogin() function.
Added calling reset() after each statement calls step(),
to make it work correctly next time.
Also fixed a macro typo in HANDLE_SQL_EXEC_FAILURE.

No new tests.

  • platform/network/blackberry/CredentialBackingStore.cpp:

(WebCore::CredentialBackingStore::instance):
(WebCore::CredentialBackingStore::CredentialBackingStore):
(WebCore::CredentialBackingStore::open):
(WebCore::CredentialBackingStore::close):
(WebCore::CredentialBackingStore::addLogin):
(WebCore::CredentialBackingStore::updateLogin):
(WebCore::CredentialBackingStore::hasLogin):
(WebCore::CredentialBackingStore::getLogin):
(WebCore):
(WebCore::CredentialBackingStore::removeLogin):
(WebCore::CredentialBackingStore::addNeverRemember):
(WebCore::CredentialBackingStore::hasNeverRemember):
(WebCore::CredentialBackingStore::getNeverRemember):
(WebCore::CredentialBackingStore::removeNeverRemember):
(WebCore::CredentialBackingStore::clearLogins):
(WebCore::CredentialBackingStore::clearNeverRemember):

  • platform/network/blackberry/CredentialBackingStore.h:

(CredentialBackingStore):

19:15 Changeset [109696] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[EFL] Evas_GL initialization and destruction in GraphicsContext3DPrivate
https://bugs.webkit.org/show_bug.cgi?id=80211

Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2012-03-04
Reviewed by Noam Rosenthal.

This patch adds initialization and destruction codes using Evas_GL APIs to GC3DPrivate.

No new tests. No behavior change.

  • platform/graphics/efl/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::create):
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::initialize):
(WebCore::GraphicsContext3DPrivate::createSurface):
(WebCore::GraphicsContext3DPrivate::makeContextCurrent):

  • platform/graphics/efl/GraphicsContext3DPrivate.h:

(GraphicsContext3DPrivate):

19:01 Changeset [109695] by kubo@profusion.mobi
  • 10 edits in trunk

[CMake] Libraries are installed to /usr/lib and not /usr/lib64 on x86_64
https://bugs.webkit.org/show_bug.cgi?id=71507

Reviewed by Antonio Gomes.

.:

  • Source/cmake/OptionsCommon.cmake: Provide two variables which

can be changed via CMake: LIB_SUFFIX, which is often used in CMake
projects to let the user choose whether a suffix should be added
to the library installation directory (such as 32 or 64), and
LIB_INSTALL_DIR, which takes LIB_SUFFIX into account to determine
whether to install libraries.

Source/JavaScriptCore:

  • CMakeLists.txt: Use ${LIB_INSTALL_DIR} instead of hardcoding "lib".

Source/WebCore:

No new tests, buildsystem change.

  • CMakeLists.txt: Use ${LIB_INSTALL_DIR} instead of hardcoding "lib".

Source/WebKit:

  • CMakeLists.txt: Use ${LIB_INSTALL_DIR} instead of hardcoding "lib".

Source/WebKit2:

  • CMakeLists.txt: Use ${LIB_INSTALL_DIR} instead of hardcoding "lib".
18:43 Changeset [109694] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Implementation of missing functions in GraphicsContext3DPrivate
https://bugs.webkit.org/show_bug.cgi?id=79759

Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2012-03-04
Reviewed by Noam Rosenthal.

The initial patch (Bug 62961) only contains implementations for simple functions
which call GL functions through Evas_GL_API.
This patch implements a little complicated functions such as getActiveAttrib(),
getShaderSource() and so on.

No new tests. No behavior change.

  • platform/graphics/efl/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::getActiveAttrib):
(WebCore::GraphicsContext3DPrivate::getActiveUniform):
(WebCore::GraphicsContext3DPrivate::getError):
(WebCore::GraphicsContext3DPrivate::getIntegerv):
(WebCore::GraphicsContext3DPrivate::getProgramInfoLog):
(WebCore::GraphicsContext3DPrivate::getShaderInfoLog):
(WebCore::GraphicsContext3DPrivate::getShaderSource):

18:33 Changeset [109693] by haraken@chromium.org
  • 8 edits
    1 delete in trunk/Source/WebCore

Revert SVG-related APIs from DOMWindowSVG.idl back to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=80139

Reviewed by Adam Barth.

Based on the discussion on webkit-dev@
(http://markmail.org/message/kagvswmah67zmrry#query:+page:1+mid:h34vzbiu5suub3ld+state:results),
this patch reverts SVG-related APIs from DOMWindowSVG.idl back to DOMWindow.idl.

No tests. No change in behavior.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • page/DOMWindow.idl:
  • svg/DOMWindowSVG.idl: Removed.
18:32 Changeset [109692] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] We should reset mouse position before calling eventSender.mouseMove in LayoutTest
https://bugs.webkit.org/show_bug.cgi?id=79748

  • platform/chromium/test_expectations.txt: Removed flaky expectations.
18:24 Changeset [109691] by haraken@chromium.org
  • 7 edits
    1 delete in trunk/Source/WebCore

Revert WebGL-related APIs from DOMWindowWebGL.idl back to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=80144

Reviewed by Adam Barth.

Based on the discussion on webkit-dev@
(http://markmail.org/message/kagvswmah67zmrry#query:+page:1+mid:h34vzbiu5suub3ld+state:results),
this patch reverts WebGL-related APIs from DOMWindowWebGL.idl back to DOMWindow.idl.

No tests. No change in behavior.

  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • html/canvas/DOMWindowWebGL.idl: Removed.
  • page/DOMWindow.idl:
18:01 Changeset [109690] by haraken@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, gardening.

  • platform/chromium/fast/files/xhr-response-blob-expected.txt:
17:59 Changeset [109689] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix.

  • rendering/RenderButton.cpp:

(WebCore::RenderButton::canHaveGeneratedChildren):

17:39 Changeset [109688] by morrita@google.com
  • 7 edits
    2 adds in trunk

REGRESSION(r108758): Assertion failure in WebCore::RenderMenuList::addChild
https://bugs.webkit.org/show_bug.cgi?id=80096

Reviewed by Dimitri Glazkov.

Source/WebCore:

After r108758 RenderBlock allowed <select> to have generated
contents. But it shouldn't. This change stops allowing it again by
replacing some canHaveChildren() invocations with
less permissive canHaveGeneratedChildren().

This change also pulls back original canHaveChildren() logic to
RenderButton to allow <button> to have generated contents.

Then RenderDeprecatedFlexibleBox::buttonText() is morphed to
more intention revealing canHaveGeneratedChildren().

Test: fast/forms/select-generated-content.html

  • rendering/RenderBlock.cpp:

(WebCore):
(WebCore::canHaveGeneratedChildren):
(WebCore::RenderBlock::styleDidChange):
(WebCore::findFirstLetterBlock):
(WebCore::RenderBlock::updateFirstLetter):

  • rendering/RenderButton.cpp:
  • rendering/RenderButton.h:

(RenderButton):

  • rendering/RenderDeprecatedFlexibleBox.h:

(WebCore::RenderDeprecatedFlexibleBox::canHaveGeneratedChildren):

  • rendering/RenderMenuList.h:

LayoutTests:

  • fast/forms/select-generated-content-expected.txt: Added.
  • fast/forms/select-generated-content.html: Added.
17:34 Changeset [109687] by tonikitoo@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

2012-03-04 Antonio Gomes <agomes@rim.com>

Fixed positioned element not correctly positioned after orientation change,
when viewport metatag is used with "initial-scale=1" MKS_2992596
PR #138865

Reviewed by George Staikos.

Viewport size changes in two main scenarios:

  • orientation changes;
  • virtual keyboard pop up/hide.

When we are setting a new viewport size, we need to
update the FixedReportedSize of the mainframe. This size
is used to return innerWidth|Heigth as well as to calculate
the fixed position elements height relative to the RenderView [1].

[1] RenderBox::containingBlockLogicalHeightForPositioned.

When we are rotating, we need to delay setting the new FixedReportedSize
till we layout and are able to figure out the new contents size. At this
time we call setFixedReportedSize, but we do not reposition the fixed elemts
afterwards.

Patch adds a call to FrameView::repaintFixedElementsAfterScrolling, after
setting the new size.

Source/WebKit/blackberry:

  • Api/WebPage.cpp: (BlackBerry::WebKit::WebPagePrivate::setViewportSize):

Source/WebCore:

  • manual-tests/blackberry/meta-viewport-fixed-position-preserved-on-rotation.html: Added.
17:09 Changeset [109686] by haraken@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, gardening.

  • platform/chromium-mac-leopard/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt: Added.
16:44 Changeset [109685] by haraken@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

Unreviewed, gardening.

  • platform/chromium-mac-leopard/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt: Added.
16:30 Changeset [109684] by haraken@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
16:23 Changeset [109683] by haraken@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed, gardening.

  • platform/chromium/fast/js/function-dot-arguments-and-caller-expected.txt: Removed.
13:35 Changeset [109682] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Source/WebCore

[BlackBerry] Upstream two helper files from platform/graphics/blackberry
https://bugs.webkit.org/show_bug.cgi?id=80125

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-03-04
Reviewed by Antonio Gomes.

Initial upstream, no new tests.

  • platform/graphics/blackberry/InstrumentedPlatformCanvas.h: Added.

(WebCore):
(InstrumentedPlatformCanvas):
(WebCore::InstrumentedPlatformCanvas::InstrumentedPlatformCanvas):
(WebCore::InstrumentedPlatformCanvas::~InstrumentedPlatformCanvas):
(WebCore::InstrumentedPlatformCanvas::isSolidColor):
(WebCore::InstrumentedPlatformCanvas::solidColor):
(WebCore::InstrumentedPlatformCanvas::save):
(WebCore::InstrumentedPlatformCanvas::saveLayer):
(WebCore::InstrumentedPlatformCanvas::restore):
(WebCore::InstrumentedPlatformCanvas::translate):
(WebCore::InstrumentedPlatformCanvas::scale):
(WebCore::InstrumentedPlatformCanvas::rotate):
(WebCore::InstrumentedPlatformCanvas::skew):
(WebCore::InstrumentedPlatformCanvas::concat):
(WebCore::InstrumentedPlatformCanvas::setMatrix):
(WebCore::InstrumentedPlatformCanvas::clipRect):
(WebCore::InstrumentedPlatformCanvas::clipPath):
(WebCore::InstrumentedPlatformCanvas::clipRegion):
(WebCore::InstrumentedPlatformCanvas::clear):
(WebCore::InstrumentedPlatformCanvas::drawPaint):
(WebCore::InstrumentedPlatformCanvas::drawPoints):
(WebCore::InstrumentedPlatformCanvas::drawRect):
(WebCore::InstrumentedPlatformCanvas::drawPath):
(WebCore::InstrumentedPlatformCanvas::drawBitmap):
(WebCore::InstrumentedPlatformCanvas::drawBitmapRect):
(WebCore::InstrumentedPlatformCanvas::drawBitmapMatrix):
(WebCore::InstrumentedPlatformCanvas::drawSprite):
(WebCore::InstrumentedPlatformCanvas::drawText):
(WebCore::InstrumentedPlatformCanvas::drawPosText):
(WebCore::InstrumentedPlatformCanvas::drawPosTextH):
(WebCore::InstrumentedPlatformCanvas::drawTextOnPath):
(WebCore::InstrumentedPlatformCanvas::drawPicture):
(WebCore::InstrumentedPlatformCanvas::drawVertices):
(WebCore::InstrumentedPlatformCanvas::drawData):

  • platform/graphics/blackberry/LayerMessage.h: Added.

(WebCore):
(WebCore::isCompositingThread):
(WebCore::compositingThread):
(WebCore::isWebKitThread):
(WebCore::webKitThread):
(WebCore::dispatchCompositingMessage):
(WebCore::dispatchSyncCompositingMessage):
(WebCore::dispatchWebKitMessage):

12:46 Changeset [109681] by andersca@apple.com
  • 6 edits in trunk/Tools

Newer versions of clang fail to compile WebKit.

Fix build.

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(descriptionOfValue):
(AccessibilityUIElement::rowIndexRange):
(AccessibilityUIElement::columnIndexRange):
(AccessibilityUIElement::selectedTextRange):

  • DumpRenderTree/mac/EditingDelegate.mm:

(-[DOMRange dump]):

  • DumpRenderTree/mac/PolicyDelegate.mm:

(-[PolicyDelegate webView:unableToImplementPolicyWithError:frame:]):

  • DumpRenderTree/mac/ResourceLoadDelegate.mm:

(-[NSError _drt_descriptionSuitableForTestResult]):

  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::descriptionOfValue):
(WTR::AccessibilityUIElement::rowIndexRange):
(WTR::AccessibilityUIElement::columnIndexRange):
(WTR::AccessibilityUIElement::selectedTextRange):

12:43 Changeset [109680] by mikelawther@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

table tests for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75898

Reviewed by Julien Chaffraix.

Tests CSS3 calc() (see http://webkit.org/b/16662) on some simple examples with tables.

  • css3/calc/table-calcs-expected.txt: Added.
  • css3/calc/table-calcs.html: Added.
  • css3/calc/table-empty-cells-expected.html: Added.
  • css3/calc/table-empty-cells.html: Added.
11:07 Changeset [109679] by zimmermann@webkit.org
  • 7 edits in trunk

Introduce SMIL overrideStyle, to make SVG stop mutating CSS styles directly
https://bugs.webkit.org/show_bug.cgi?id=79790

Reviewed by Dirk Schulze.

Source/WebCore:

Restore SMIL animation behavior back to pre-r109342.
1) Always animate presentation attributes as CSS properties, regardless of the
attributeTypes value. Matches Opera/FF, and makes the attribute optional again
as specified in both SMIL & SVG.

Extend existing svg/animations/attributesTypes.html to verify this.

2) Switch setInstancesUpdatesBlocked calls to the right locations again, to
avoid chromium assertions (and/or extra work being done). Fixing that reveals another
problem: in the instance updating code path, we always called setTargetAttributeAnimatedCSSValue
even for XML animations.

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::shouldApplyAnimation): Restore old logic.
(WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue): Fix typo, move setInstancesUpdatesBlocked calls.

LayoutTests:

Extended attributesTypes.html test case to check that presentation attributes are
always animated as CSS properties, regardless of their attributeTypes value.

  • platform/chromium/test_expectations.txt: Remove animate-elem-32-t.svg suppression.
  • svg/animations/attributeTypes-expected.txt: Updated expectations.
  • svg/animations/resources/attributeTypes.svg: Fix comment.
  • svg/animations/script-tests/attributeTypes.js: Extend test.

(sample1):
(sample2):
(sample3):

10:53 Changeset [109678] by ddkilzer@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Fix build when the classic interpreter is enabled

Reviewed by Gavin Barraclough.

Fixes the following build error when running the "Generate
Derived Sources" build phase script:

offlineasm: Parsing JavaScriptCore/llint/LowLevelInterpreter.asm and ../../JSCLLIntOffsetsExtractor and creating assembly file LLIntAssembly.h.
./JavaScriptCore/offlineasm/offsets.rb:145:in `offsetsAndConfigurationIndex': unhandled exception

from JavaScriptCore/offlineasm/asm.rb:131

Command /bin/sh failed with exit code 1

Gavin's fix in r109674 avoided the #error statement in
JITStubs.h when compiling LLIntOffsetsExtractor.cpp, but it
caused the "Generate Derived Sources" build phase script to fail
when JavaScriptCore/offlineasm/asm.rb was run. The solution is
to detect when the classic interpreter is being built and simply
exit early from asm.rb in that case.

  • llint/LLIntOffsetsExtractor.cpp:

(JSC::LLIntOffsetsExtractor::dummy): Return NULL pointer if the
JIT is disabled. Note that offsets.rb doesn't care about the
return value here, but instead it cares about finding the magic
values in the binary. The magic values are no longer present
when the JIT is disabled.

  • offlineasm/asm.rb: Catch MissingMagicValuesException and exit

early with a status message.

  • offlineasm/offsets.rb:

(MissingMagicValuesException): Add new exception class.
(offsetsAndConfigurationIndex): Throw
MissingMagicValuesException when no magic values are found.

09:11 Changeset [109677] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Source/WebCore

[BlackBerry] upstream MediaPlayerPrivateBlackBerry.[cpp|h]
https://bugs.webkit.org/show_bug.cgi?id=79729

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-03-04
Reviewed by Rob Buis and Antonio Gomes.

Implementation of MediaPlayerPrivate for BlackBerry porting.
Initial upstream, No new tests.

  • PlatformBlackBerry.cmake:
  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp: Added.

(WebCore):
(WebCore::MediaPlayerPrivate::create):
(WebCore::MediaPlayerPrivate::registerMediaEngine):
(WebCore::MediaPlayerPrivate::getSupportedTypes):
(WebCore::MediaPlayerPrivate::supportsType):
(WebCore::MediaPlayerPrivate::notifyAppActivatedEvent):
(WebCore::MediaPlayerPrivate::setCertificatePath):
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::load):
(WebCore::MediaPlayerPrivate::cancelLoad):
(WebCore::MediaPlayerPrivate::prepareToPlay):
(WebCore::MediaPlayerPrivate::play):
(WebCore::MediaPlayerPrivate::pause):
(WebCore::MediaPlayerPrivate::supportsFullscreen):
(WebCore::MediaPlayerPrivate::naturalSize):
(WebCore::MediaPlayerPrivate::hasVideo):
(WebCore::MediaPlayerPrivate::hasAudio):
(WebCore::MediaPlayerPrivate::setVisible):
(WebCore::MediaPlayerPrivate::duration):
(WebCore::MediaPlayerPrivate::currentTime):
(WebCore::MediaPlayerPrivate::seek):
(WebCore::MediaPlayerPrivate::userDrivenSeekTimerFired):
(WebCore::MediaPlayerPrivate::seeking):
(WebCore::MediaPlayerPrivate::setRate):
(WebCore::MediaPlayerPrivate::paused):
(WebCore::MediaPlayerPrivate::setVolume):
(WebCore::MediaPlayerPrivate::networkState):
(WebCore::MediaPlayerPrivate::readyState):
(WebCore::MediaPlayerPrivate::maxTimeSeekable):
(WebCore::MediaPlayerPrivate::buffered):
(WebCore::MediaPlayerPrivate::bytesLoaded):
(WebCore::MediaPlayerPrivate::setSize):
(WebCore::MediaPlayerPrivate::paint):
(WebCore::MediaPlayerPrivate::hasAvailableVideoFrame):
(WebCore::MediaPlayerPrivate::hasSingleSecurityOrigin):
(WebCore::MediaPlayerPrivate::movieLoadType):
(WebCore::MediaPlayerPrivate::userAgent):
(WebCore::MediaPlayerPrivate::resizeSourceDimensions):
(WebCore::MediaPlayerPrivate::setFullscreenWebPageClient):
(WebCore::MediaPlayerPrivate::getWindow):
(WebCore::MediaPlayerPrivate::getPeerWindow):
(WebCore::MediaPlayerPrivate::getWindowPosition):
(WebCore::MediaPlayerPrivate::mmrContextName):
(WebCore::MediaPlayerPrivate::percentLoaded):
(WebCore::MediaPlayerPrivate::sourceWidth):
(WebCore::MediaPlayerPrivate::sourceHeight):
(WebCore::MediaPlayerPrivate::setAllowPPSVolumeUpdates):
(WebCore::MediaPlayerPrivate::updateStates):
(WebCore::MediaPlayerPrivate::onStateChanged):
(WebCore::MediaPlayerPrivate::onMediaStatusChanged):
(WebCore::MediaPlayerPrivate::onError):
(WebCore::MediaPlayerPrivate::onDurationChanged):
(WebCore::MediaPlayerPrivate::onTimeChanged):
(WebCore::MediaPlayerPrivate::onPauseStateChanged):
(WebCore::MediaPlayerPrivate::onRateChanged):
(WebCore::MediaPlayerPrivate::onVolumeChanged):
(WebCore::MediaPlayerPrivate::onRepaint):
(WebCore::MediaPlayerPrivate::onSizeChanged):
(WebCore::MediaPlayerPrivate::onPlayNotified):
(WebCore::MediaPlayerPrivate::onPauseNotified):
(WebCore::MediaPlayerPrivate::onBuffering):
(WebCore::MediaPlayerPrivate::showErrorDialog):
(WebCore::MediaPlayerPrivate::frameView):
(WebCore::MediaPlayerPrivate::platformWindow):
(WebCore::MediaPlayerPrivate::isFullscreen):
(WebCore::MediaPlayerPrivate::platformMedia):
(WebCore::MediaPlayerPrivate::platformLayer):
(WebCore::loadBufferingImageData):
(WebCore::MediaPlayerPrivate::bufferingTimerFired):
(WebCore::MediaPlayerPrivate::setBuffering):
(WebCore::allocateTextureId):
(WebCore::MediaPlayerPrivate::drawBufferingAnimation):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h: Added.

(WebKit):
(WebCore):
(MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::supportsAcceleratedRendering):
(WebCore::MediaPlayerPrivate::acceleratedRenderingStateChanged):

07:57 Changeset [109676] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/JavaScriptCore

Merging http://trac.webkit.org/changeset/109675

07:42 Changeset [109675] by kov@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

SPARC also needs aligned accesses.

Patch by Jurij Smakov <jurij@wooyd.org> on 2012-03-04
Rubber-stamped by Gustavo Noronha Silva.

  • wtf/Platform.h:
07:26 BuildingGtk edited by omar.belkhodja@gmail.com
Added gobject-introspection to jhbuild dependencies (diff)
01:04 Changeset [109674] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix.

  • jit/JITStubs.h:
    • Move ENABLE(JIT) to head of file.

03/03/12:

21:56 Changeset [109673] by barraclough@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Split JSArray's Put? & DefineOwnProperty? traps.
https://bugs.webkit.org/show_bug.cgi?id=80217

Reviewed by Filip Pizlo.

putByIndex() provides similar behavior to put(), but for indexed property names.
Many places in ArrayPrototype call putByIndex() where they really mean to call
DefineOwnProperty?. This is only okay due to a bug – putByIndex should be
calling numeric accessors (& respecting numeric read only properties) on the
prototype chain, but isn't. Add a new putDirectIndex (matching JSObject's
putDirect* methods), to correctly provide a fast DefineOwnProperty? interface.

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):

  • runtime/JSArray.cpp:

(JSC):
(JSC::reject):
(JSC::SparseArrayValueMap::putDirect):
(JSC::JSArray::defineOwnNumericProperty):
(JSC::JSArray::putByIndexBeyondVectorLength):
(JSC::JSArray::putDirectIndexBeyondVectorLength):

  • runtime/JSArray.h:

(SparseArrayValueMap):
(JSArray):
(JSC::JSArray::putDirectIndex):

21:04 Changeset [109672] by benjamin@webkit.org
  • 4 edits in trunk/Source/WebCore

Remove the unused function WebCore::protocolIsInHTTPFamily()
https://bugs.webkit.org/show_bug.cgi?id=80218

Reviewed by Anders Carlsson.

  • WebCore.order:
  • platform/KURL.cpp:
  • platform/KURL.h:

(WebCore):

19:49 Changeset [109671] by benjamin@webkit.org
  • 6 edits in trunk/Source

Implement the basis of KURLWTFURL
https://bugs.webkit.org/show_bug.cgi?id=79600

Reviewed by Adam Barth.

Source/JavaScriptCore:

Add an API to know if a ParsedURL is valid.

  • wtf/url/api/ParsedURL.cpp:

(WTF::ParsedURL::ParsedURL):
(WTF):
(WTF::ParsedURL::isolatedCopy): This is needed by APIs moving URL objects between thread
and by KURL's detach() on write.
(WTF::ParsedURL::baseAsString):
(WTF::ParsedURL::segment):
Add a stronger constraint on accessors: the client of this API should never ask for the segments
on an invalid URL.

  • wtf/url/api/ParsedURL.h:

(WTF):
(WTF::ParsedURL::ParsedURL):
(ParsedURL):
(WTF::ParsedURL::isValid):

Source/WebCore:

Add a simple, non-optimized, implementation for the main methods of KURL based
on ParsedURL.

  • platform/KURLWTFURL.cpp:

(WebCore):
(WebCore::detach):
(WebCore::KURL::KURL):
(WebCore::KURL::copy):
(WebCore::KURL::isEmpty):
(WebCore::KURL::isValid):
(WebCore::KURL::string):
(WebCore::KURL::protocol):
(WebCore::KURL::host):
(WebCore::KURL::hasPort):
(WebCore::KURL::port):
(WebCore::KURL::user):
(WebCore::KURL::pass):
(WebCore::KURL::hasPath):
(WebCore::KURL::path):
(WebCore::KURL::lastPathComponent):
(WebCore::KURL::query):
(WebCore::KURL::hasFragmentIdentifier):
(WebCore::KURL::fragmentIdentifier):
(WebCore::KURL::baseAsString):
(WebCore::KURL::fileSystemPath):
(WebCore::KURL::protocolIs):
(WebCore::KURL::protocolIsInHTTPFamily):
(WebCore::KURL::setProtocol):
(WebCore::KURL::setHost):
(WebCore::KURL::removePort):
(WebCore::KURL::setPort):
(WebCore::KURL::setHostAndPort):
(WebCore::KURL::setUser):
(WebCore::KURL::setPass):
(WebCore::KURL::setPath):
(WebCore::KURL::setQuery):
(WebCore::KURL::setFragmentIdentifier):
(WebCore::KURL::removeFragmentIdentifier):
(WebCore::protocolHostAndPortAreEqual):

  • platform/KURLWTFURLImpl.h:

(KURLWTFURLImpl):
(WebCore::KURLWTFURLImpl::copy):
(WebCore):

19:26 Changeset [109670] by benjamin@webkit.org
  • 24 edits in trunk/Source

Remove the redundant method KURL::protocolInHTTPFamily()
https://bugs.webkit.org/show_bug.cgi?id=80216

Reviewed by Anders Carlsson.

Source/WebCore:

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::open):
(WebCore::FrameLoader::addExtraFieldsToRequest):

  • loader/ResourceLoadScheduler.cpp:

(WebCore::ResourceLoadScheduler::hostForURL):
(WebCore::ResourceLoadScheduler::scheduleLoad):

  • loader/appcache/ApplicationCache.cpp:

(WebCore::ApplicationCache::requestIsHTTPOrHTTPSGet):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::freshnessLifetime):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::removeFragmentIdentifierIfNeeded):

  • loader/icon/IconController.cpp:

(WebCore::IconController::defaultURL):

  • platform/KURL.h:

(KURL):

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
  • platform/network/CredentialStorage.cpp:

(WebCore::CredentialStorage::set):
(WebCore::findDefaultProtectionSpaceForURL):

  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::setCachePolicy):
(WebCore::ResourceRequestBase::setTimeoutInterval):
(WebCore::ResourceRequestBase::setHTTPMethod):
(WebCore::ResourceRequestBase::setHTTPHeaderField):
(WebCore::ResourceRequestBase::clearHTTPAuthorization):
(WebCore::ResourceRequestBase::clearHTTPReferrer):
(WebCore::ResourceRequestBase::clearHTTPOrigin):
(WebCore::ResourceRequestBase::setResponseContentDispositionEncodingFallbackArray):
(WebCore::ResourceRequestBase::setHTTPBody):
(WebCore::ResourceRequestBase::setAllowCookies):
(WebCore::ResourceRequestBase::setPriority):
(WebCore::ResourceRequestBase::addHTTPHeaderField):

  • platform/network/blackberry/NetworkManager.cpp:

(WebCore::NetworkManager::startJob):

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::createCFURLConnection):

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::createNSURLConnection):

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::send):

Source/WebKit/chromium:

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchWillPerformClientRedirect):

  • src/WebPageSerializer.cpp:

(WebCore::retrieveResourcesForElement):

Source/WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::createPlugin):

Source/WebKit/win:

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::dispatchDidFailToStartPlugin):

  • WebHistory.cpp:

(WebHistory::visitedURL):

19:08 Changeset [109669] by commit-queue@webkit.org
  • 9 edits in trunk

[Qt] Fix static_libs_as_shared build
https://bugs.webkit.org/show_bug.cgi?id=80214

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-03-03
Reviewed by Tor Arne Vestbø.

Source/WebKit/qt:

Add helper function to be called by WebProcess main
to potentially initialize the QStyle theme.

  • WebCoreSupport/InitWebCoreQt.cpp:

(WebKit):
(WebKit::initializeWebKit2Theme):

Source/WebKit2:

Replace (static) link time dependency to WK1 with entrypoint
in the separate WebProcess for activating the QStyle theme if
necessary.

  • Target.pri:
  • UIProcess/Launcher/ProcessLauncher.h:
  • WebProcess/qt/WebProcessMainQt.cpp:

(WebKit::WebProcessMainQt):

  • qt/MainQt.cpp:

(WebKit):
(main):

Tools:

  • WebKitTestRunner/qt/main.cpp:

(main): Set the correct environment variable for choosing the theme in the
web process.

19:04 Changeset [109668] by commit-queue@webkit.org
  • 1 edit
    9 adds in trunk/Source/WebCore

[BlackBerry] Upstream LayerWebKitThread and its derived classes
https://bugs.webkit.org/show_bug.cgi?id=79871

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-03-03
Reviewed by Antonio Gomes.

Initial upstream, no new tests.

  • platform/graphics/blackberry/CanvasLayerWebKitThread.cpp: Added.

(WebCore):
(WebCore::CanvasLayerWebKitThread::CanvasLayerWebKitThread):
(WebCore::CanvasLayerWebKitThread::~CanvasLayerWebKitThread):
(WebCore::CanvasLayerWebKitThread::setCanvas):
(WebCore::CanvasLayerWebKitThread::setNeedsDisplay):
(WebCore::CanvasLayerWebKitThread::updateTextureContentsIfNeeded):

  • platform/graphics/blackberry/CanvasLayerWebKitThread.h: Added.

(WebCore):
(CanvasLayerWebKitThread):
(WebCore::CanvasLayerWebKitThread::create):

  • platform/graphics/blackberry/LayerData.h: Added.

(WebCore):
(LayerData):
(WebCore::LayerData::LayerData):
(WebCore::LayerData::~LayerData):
(WebCore::LayerData::anchorPoint):
(WebCore::LayerData::anchorPointZ):
(WebCore::LayerData::backgroundColor):
(WebCore::LayerData::borderColor):
(WebCore::LayerData::borderWidth):
(WebCore::LayerData::bounds):
(WebCore::LayerData::doubleSided):
(WebCore::LayerData::frame):
(WebCore::LayerData::masksToBounds):
(WebCore::LayerData::opacity):
(WebCore::LayerData::opaque):
(WebCore::LayerData::position):
(WebCore::LayerData::sublayerTransform):
(WebCore::LayerData::transform):
(WebCore::LayerData::preserves3D):
(WebCore::LayerData::getTextureID):
(WebCore::LayerData::setTextureID):
(WebCore::LayerData::needsTexture):
(WebCore::LayerData::layerProgramShader):
(WebCore::LayerData::isFixedPosition):
(WebCore::LayerData::hasFixedContainer):
(WebCore::LayerData::hasFixedAncestorInDOMTree):
(WebCore::LayerData::pluginView):
(WebCore::LayerData::holePunchRect):
(WebCore::LayerData::hasHolePunchRect):
(WebCore::LayerData::mediaPlayer):
(WebCore::LayerData::canvas):
(WebCore::LayerData::replicate):
(WebCore::LayerData::layerType):
(WebCore::LayerData::includeVisibility):

  • platform/graphics/blackberry/LayerWebKitThread.cpp: Added.

(WebCore):
(WebCore::LayerWebKitThread::create):
(WebCore::LayerWebKitThread::LayerWebKitThread):
(WebCore::LayerWebKitThread::~LayerWebKitThread):
(WebCore::LayerWebKitThread::paintContents):
(WebCore::LayerWebKitThread::contentsVisible):
(WebCore::LayerWebKitThread::createFrontBufferLock):
(WebCore::LayerWebKitThread::updateTextureContentsIfNeeded):
(WebCore::LayerWebKitThread::setContents):
(WebCore::LayerWebKitThread::setDrawable):
(WebCore::LayerWebKitThread::setNeedsCommit):
(WebCore::LayerWebKitThread::notifyAnimationStarted):
(WebCore::LayerWebKitThread::commitOnWebKitThread):
(WebCore::LayerWebKitThread::startAnimations):
(WebCore::LayerWebKitThread::updateTextureContents):
(WebCore::LayerWebKitThread::commitOnCompositingThread):
(WebCore::LayerWebKitThread::addSublayer):
(WebCore::LayerWebKitThread::insertSublayer):
(WebCore::LayerWebKitThread::removeFromSuperlayer):
(WebCore::LayerWebKitThread::removeSublayer):
(WebCore::LayerWebKitThread::replaceSublayer):
(WebCore::LayerWebKitThread::indexOfSublayer):
(WebCore::LayerWebKitThread::setBounds):
(WebCore::LayerWebKitThread::setFrame):
(WebCore::LayerWebKitThread::rootLayer):
(WebCore::LayerWebKitThread::removeAllSublayers):
(WebCore::LayerWebKitThread::setSublayers):
(WebCore::LayerWebKitThread::setNeedsDisplayInRect):
(WebCore::LayerWebKitThread::setNeedsDisplay):
(WebCore::LayerWebKitThread::updateLayerHierarchy):
(WebCore::LayerWebKitThread::setIsMask):

  • platform/graphics/blackberry/LayerWebKitThread.h: Added.

(WebCore):
(LayerWebKitThread):
(WebCore::LayerWebKitThread::setAnchorPoint):
(WebCore::LayerWebKitThread::setAnchorPointZ):
(WebCore::LayerWebKitThread::setBackgroundColor):
(WebCore::LayerWebKitThread::setBorderColor):
(WebCore::LayerWebKitThread::setBorderWidth):
(WebCore::LayerWebKitThread::setDoubleSided):
(WebCore::LayerWebKitThread::setMasksToBounds):
(WebCore::LayerWebKitThread::setMaskLayer):
(WebCore::LayerWebKitThread::maskLayer):
(WebCore::LayerWebKitThread::setReplicaLayer):
(WebCore::LayerWebKitThread::replicaLayer):
(WebCore::LayerWebKitThread::setNeedsDisplayOnBoundsChange):
(WebCore::LayerWebKitThread::setOpacity):
(WebCore::LayerWebKitThread::setOpaque):
(WebCore::LayerWebKitThread::setPosition):
(WebCore::LayerWebKitThread::getSublayers):
(WebCore::LayerWebKitThread::setSublayerTransform):
(WebCore::LayerWebKitThread::superlayer):
(WebCore::LayerWebKitThread::setTransform):
(WebCore::LayerWebKitThread::setPreserves3D):
(WebCore::LayerWebKitThread::setFixedPosition):
(WebCore::LayerWebKitThread::setHasFixedContainer):
(WebCore::LayerWebKitThread::setHasFixedAncestorInDOMTree):
(WebCore::LayerWebKitThread::contents):
(WebCore::LayerWebKitThread::setOwner):
(WebCore::LayerWebKitThread::drawsContent):
(WebCore::LayerWebKitThread::layerCompositingThread):
(WebCore::LayerWebKitThread::setAbsoluteOffset):
(WebCore::LayerWebKitThread::contentsScale):
(WebCore::LayerWebKitThread::setRunningAnimations):
(WebCore::LayerWebKitThread::setSuspendedAnimations):
(WebCore::LayerWebKitThread::setNeedsTexture):
(WebCore::LayerWebKitThread::setLayerProgramShader):
(WebCore::LayerWebKitThread::isDrawable):
(WebCore::LayerWebKitThread::boundsChanged):
(WebCore::LayerWebKitThread::setSuperlayer):
(WebCore::LayerWebKitThread::numSublayers):

  • platform/graphics/blackberry/PluginLayerWebKitThread.cpp: Added.

(WebCore):
(WebCore::PluginLayerWebKitThread::PluginLayerWebKitThread):
(WebCore::PluginLayerWebKitThread::~PluginLayerWebKitThread):
(WebCore::PluginLayerWebKitThread::setPluginView):
(WebCore::PluginLayerWebKitThread::setHolePunchRect):
(WebCore::PluginLayerWebKitThread::setNeedsDisplay):
(WebCore::PluginLayerWebKitThread::updateTextureContentsIfNeeded):

  • platform/graphics/blackberry/PluginLayerWebKitThread.h: Added.

(WebCore):
(PluginLayerWebKitThread):
(WebCore::PluginLayerWebKitThread::create):

  • platform/graphics/blackberry/VideoLayerWebKitThread.cpp: Added.

(WebCore):
(WebCore::VideoLayerWebKitThread::VideoLayerWebKitThread):
(WebCore::VideoLayerWebKitThread::~VideoLayerWebKitThread):
(WebCore::VideoLayerWebKitThread::setMediaPlayer):
(WebCore::VideoLayerWebKitThread::setHolePunchRect):
(WebCore::VideoLayerWebKitThread::setNeedsDisplay):
(WebCore::VideoLayerWebKitThread::boundsChanged):
(WebCore::VideoLayerWebKitThread::updateTextureContentsIfNeeded):

  • platform/graphics/blackberry/VideoLayerWebKitThread.h: Added.

(WebCore):
(VideoLayerWebKitThread):
(WebCore::VideoLayerWebKitThread::create):

17:06 Changeset [109667] by hans@chromium.org
  • 24 edits in trunk

Implement Speech JavaScript API
https://bugs.webkit.org/show_bug.cgi?id=80019

Reviewed by Adam Barth.

.:

Add ENABLE_SCRIPTED_SPEECH.

  • configure.ac:

Source/JavaScriptCore:

Add ENABLE_SCRIPTED_SPEECH.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Add ENABLE_SCRIPTED_SPEECH and runtime flag.

No functionality yet, so no new tests.

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • Target.pri:
  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::setScriptedSpeechEnabled):
(WebCore::RuntimeEnabledFeatures::scriptedSpeechEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechRecognitionEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechRecognitionErrorEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechGrammarEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechGrammarListEnabled):

Source/WebKit/chromium:

Add ENABLE_SCRIPTED_SPEECH and runtime flag.

  • features.gypi:
  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableScriptedSpeech):
(WebKit):
(WebKit::WebRuntimeFeatures::isScriptedSpeechEnabled):

Source/WebKit/mac:

Add ENABLE_SCRIPTED_SPEECH.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Add ENABLE_SCRIPTED_SPEECH.

  • Configurations/FeatureDefines.xcconfig:

Tools:

Add ENABLE_SCRIPTED_SPEECH.

  • Scripts/build-webkit:
  • qmake/mkspecs/features/features.prf:

WebKitLibraries:

Add ENABLE_SCRIPTED_SPEECH.

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
14:48 Changeset [109666] by commit-queue@webkit.org
  • 13 edits
    1 copy
    1 add in trunk

DelayNode has a fixed one second max delay time
https://bugs.webkit.org/show_bug.cgi?id=78758

Source/WebCore:

Change DelayNode to accept an optional parameter to specify the
maximum delay allowed. If not specified, the default is 1 sec.

Patch by Raymond Toy <rtoy@google.com> on 2012-03-03
Reviewed by Chris Rogers.

Test: webaudio/delaynode-maxdelay.html

webaudio/delaynode-maxdelay-expected.txt

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::createDelayNode): Allow maxDelayTime
parameter to specify max delay.

  • webaudio/AudioContext.h: Allow maxDelayTime

parameter to specify max delay but default to 1.
(AudioContext):

  • webaudio/AudioContext.idl: createDelayNode takes optional max

delay time parameter.

  • webaudio/DelayDSPKernel.cpp:

(WebCore::DelayDSPKernel::DelayDSPKernel): Remove unused
DefaultMaxDelayTime. Set m_maxDelayTime from processor
maxDelayTime.

  • webaudio/DelayNode.cpp:

(WebCore::DelayNode::DelayNode): Add maxDelayTime parameter.

  • webaudio/DelayNode.h:

(WebCore::DelayNode::create): Add maxDelayTime parameter.
(DelayNode): Add maxDelayTime parameter.

  • webaudio/DelayProcessor.cpp:

(WebCore::DelayProcessor::DelayProcessor): Add maxDelayTime
parameter.

  • webaudio/DelayProcessor.h:

(DelayProcessor): Add maxDelayTime parameter.
(WebCore::DelayProcessor::maxDelayTime): New slot to hold
maxDelayTime.

LayoutTests:

Patch by Raymond Toy <rtoy@google.com> on 2012-03-03
Reviewed by Chris Rogers.

  • webaudio/resources/delay-testing.js: Added more informative

messages.

  • webaudio/delaynode-expected.txt: Updated result for more

informative messages

  • webaudio/delaynode-scheduling-expected.txt: Updated result for

more informative messages.

  • webaudio/delaynode-maxdelay-expected.txt: Added
  • webaudio/delaynode-maxdelay.html: Added
14:30 Changeset [109665] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Simplified discreteTimeConstantForSampleRate
https://bugs.webkit.org/show_bug.cgi?id=78051

Remove hardcoded constant and simplify computation of discrete
time constant.

Patch by Raymond Toy <rtoy@google.com> on 2012-03-03
Reviewed by Chris Rogers.

No new tests needed. Covered by existing AudioParam tests.

  • platform/audio/AudioUtilities.cpp:

(WebCore::AudioUtilities::discreteTimeConstantForSampleRate):
Simplify formula.

  • platform/audio/AudioUtilities.h:

(AudioUtilities): Update function signature.

  • platform/audio/DynamicsCompressorKernel.cpp:

(WebCore::DynamicsCompressorKernel::DynamicsCompressorKernel):
cast to float to avoid warnings.

  • webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::valuesForTimeRangeImpl): cast to
float to avoid warnings.

11:26 Changeset [109664] by noam.rosenthal@nokia.com
  • 3 edits in trunk/Source/WebKit2

[Qt] Use the existing inheritedOpacity/matrix properties of QSGNode
https://bugs.webkit.org/show_bug.cgi?id=79543

Use QSGNode::inheritedOpacity() and QSGNode::matrix().
Also, remove flags from changedStates() that we don't actually touch.
This is covered by existing API tests.

Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPagePrivate::paintToCurrentGLContext):
(PageProxyNode::changedStates):
(PageProxyNode::render):

  • UIProcess/API/qt/qquickwebpage_p_p.h:

(QQuickWebPagePrivate):

11:13 Changeset [109663] by andersca@apple.com
  • 11 edits in trunk/Source

Fix build with newer versions of clang.

Source/WebCore:

  • bindings/objc/DOM.mm:

(-[DOMNode description]):
Remove an unused parameter.

  • bridge/objc/objc_instance.mm:

(ObjcInstance::getClass):
Use object_getClass instead of accessing isa directly.

  • platform/LocalizedStrings.cpp:

(WebCore::formatLocalizedString):
Disable the -Wformat-nonliteral warning around the call to CFStringCreateWithFormatAndArguments.

  • platform/graphics/mac/WebLayer.mm:

(-[CALayer _descriptionWithPrefix:]):
Use %p for the CALayer pointer, and use %lu for the number of sublayers.

  • platform/mac/HTMLConverter.mm:

(-[WebHTMLConverter _addAttachmentForElement:URL:needsParagraph:usePlaceholder:]):
Cast the NSAttachmentCharacte enum to unichar.

Source/WebKit/mac:

  • Panels/WebAuthenticationPanel.m:

(-[WebAuthenticationPanel setUpForChallenge:]):
Use %ld and cast to long.

  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView getVariable:value:]):
Cast the switch parameter to unsigned to prevent warnings about case values not being part of the enum type.

Source/WebKit2:

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue):
Cast the switch parameter to unsigned to prevent warnings about case values not being part of the enum type.

10:55 Changeset [109662] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Biquad getFrequencyResponse needs a layout test.
https://bugs.webkit.org/show_bug.cgi?id=79503

Add simple test for getFrequencyResponse.

Patch by Raymond Toy <rtoy@google.com> on 2012-03-03
Reviewed by Chris Rogers.

  • webaudio/biquad-getFrequencyResponse-expected.txt: Added.
  • webaudio/biquad-getFrequencyResponse.html: Added.
10:49 Changeset [109661] by bbudge@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

Fixes AssociatedURLLoader support for Access-Control-Expose-Headers field in response.
https://bugs.webkit.org/show_bug.cgi?id=80198

Reviewed by Adam Barth.

  • src/AssociatedURLLoader.cpp:
  • tests/AssociatedURLLoaderTest.cpp:
04:34 Changeset [109660] by commit-queue@webkit.org
  • 5 edits in trunk

Unreviewed, rolling out r109343.
http://trac.webkit.org/changeset/109343
https://bugs.webkit.org/show_bug.cgi?id=80212

Int32array can't handle values for native nodes because they
have int64 ids (Requested by loislo1 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-03

Source/WebCore:

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotLoader.prototype._parseNodes):
(WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
(WebInspector.HeapSnapshot):
(WebInspector.HeapSnapshot.prototype._init):

LayoutTests:

  • inspector/profiler/heap-snapshot-loader.html:
  • inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMock):
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockWithDOM):
(initialize_HeapSnapshotTest):

01:16 Changeset [109659] by philn@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed, GTK tests_expectations update.

  • platform/gtk/Skipped:
  • platform/gtk/test_expectations.txt:
01:12 Changeset [109658] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Free up a bit in RenderObject.
http://webkit.org/b/80208

Patch by Andreas Kling <awesomekling@apple.com> on 2012-03-03
Reviewed by Anders Carlsson.

Move m_hasMarkupTruncation to RenderBlock, stealing one bit from m_lineHeight.
This flag is only used by RenderBlock.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::RenderBlock):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::setHasMarkupTruncation):
(WebCore::RenderBlock::hasMarkupTruncation):
(RenderBlock):

  • rendering/RenderObject.h:

(RenderObject):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
(RenderObjectBitfields):

01:09 Changeset [109657] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rebaseline after r109623.

  • editing/selection/select-line-break-with-opposite-directionality-expected.txt:
00:35 Changeset [109656] by commit-queue@webkit.org
  • 40 edits
    15 adds in trunk

Implement vw/vh/vmin (viewport sizes) from CSS 3 Values and Units
https://bugs.webkit.org/show_bug.cgi?id=27160

The specification related to this implementation is located at http://dev.w3.org/csswg/css3-values/#viewport-relative-lengths.
vw/vh/vmin are implemented as primitive length units. Added the parsing logic for these new units and creation of primitive values.

Added new Length types such as ViewportRelativeWidth, ViewportRelativeHeight and ViewportRelativeMin for viewport-relative lengths
and included the support for fetching the value of these relative length units based on the current viewport size.

Patch by Joe Thomas <joethomas@motorola.com> on 2012-03-03
Reviewed by Antti Koivisto.

Source/WebCore:

Tests: css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle.html

css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute.html
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh.html
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute.html
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin.html
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute.html
css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw.html

  • css/CSSComputedStyleDeclaration.cpp: Modified to support viewport relative Length types.

(WebCore::getPositionOffsetValue): Ditto.
(WebCore::getBorderRadiusCornerValues): Ditto.
(WebCore::getBorderRadiusCornerValue): Ditto.
(WebCore::getBorderRadiusShorthandValue): Ditto.
(WebCore::lineHeightFromStyle): Ditto.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Ditto.

  • css/CSSGrammar.y: Added vw/vh/vmin support.
  • css/CSSParser.cpp: Parsing of relative units and creation of CSSPrimitiveValue.

(WebCore::CSSParser::validUnit): Added vw/vh/vmin to the valid units.
(WebCore::CSSParser::createPrimitiveNumericValue): Added vw/vh/vmin as valid primitive units.
(WebCore::unitFromString):
(WebCore::CSSParser::parseValidPrimitive): Creation of CSSPrimitiveValue for vw/vh/vmin.
(WebCore::CSSParser::detectNumberToken): Parsing the vw/vh/vmin tokens.

  • css/CSSPrimitiveValue.cpp:

(WebCore::isValidCSSUnitTypeForDoubleConversion): Added support for vw/vh/vmin.
(WebCore::unitCategory): Ditto.
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::canonicalUnitTypeForCategory): Added support for vw/vh/vmin.
(WebCore::CSSPrimitiveValue::customCssText): Ditto.
(WebCore::CSSPrimitiveValue::viewportRelativeLength): Function to create the Length structure for the viewport-relative unit types.
(WebCore):

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::isViewportRelativeLength): Checks whether the primitive value is ViewportRelative Lengths.
(CSSPrimitiveValue):

  • css/CSSPrimitiveValue.idl: Added support for vw/vh/vmin.
  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyLength::applyValue): Applying relative viewport length units to the specific CSS property.
(WebCore::ApplyPropertyBorderRadius::applyValue): Ditto.
(WebCore::ApplyPropertyFontSize::applyValue): Ditto.
(WebCore::ApplyPropertyLineHeight::applyValue): Ditto.
(WebCore::ApplyPropertyVerticalAlign::applyValue): Ditto.

  • css/CSSStyleSelector.cpp:

(WebCore::convertToLength): Added support for viewport relative units.
(WebCore::createGridTrackBreadth): Ditto.
(WebCore::CSSStyleSelector::mapFillSize): Ditto.
(WebCore::CSSStyleSelector::mapFillXPosition): Ditto.
(WebCore::CSSStyleSelector::mapFillYPosition): Ditto.

  • dom/Document.cpp:

(WebCore::Document::pageSizeAndMarginsInPixels): Modified to support viewport relative Length types.
(WebCore::Document::viewportSize): New function to fetch the current viewport size.
(WebCore):

  • dom/Document.h: Ditto.

(Document):

  • html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::getRegion): Modified to support viewport relative Length types.

  • platform/Length.h: New LengthTypes such as ViewportRelativeWidth, ViewportRelativeHeight and ViewportRelativeMin added.

(WebCore::Length::calcValue): Modified to support viewport relative Length types.
(WebCore::Length::calcMinValue): Ditto.
(WebCore::Length::calcFloatValue): Ditto.
(Length):
(WebCore::Length::isViewportRelative): To check the Length is of type ViewportRelative.
(WebCore::Length::viewportRelativeLength): To get the relative value.

  • rendering/RenderBR.cpp:

(WebCore::RenderBR::lineHeight): Modified to support viewport relative Length types.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::lineHeight): Ditto.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::reflectionOffset): Ditto.
(WebCore::RenderBox::paintBoxDecorations): Ditto.
(WebCore::RenderBox::clipRect): Ditto.
(WebCore::RenderBox::computeLogicalWidthInRegion): Ditto.
(WebCore::RenderBox::computeLogicalWidthInRegionUsing): Ditto.
(WebCore::RenderBox::computeInlineDirectionMargins): Ditto.
(WebCore::RenderBox::computeLogicalHeightUsing): Ditto.
(WebCore::RenderBox::computePercentageLogicalHeight): Ditto.
(WebCore::RenderBox::computeReplacedLogicalHeightUsing): Ditto.
(WebCore::RenderBox::computeBlockDirectionMargins): Ditto.
(WebCore::RenderBox::computePositionedLogicalWidthUsing): Ditto.
(WebCore::RenderBox::computePositionedLogicalHeightUsing): Ditto.
(WebCore::RenderBox::computePositionedLogicalWidthReplaced): Ditto.
(WebCore::RenderBox::computePositionedLogicalHeightReplaced): Ditto.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::relativePositionOffsetX): Ditto.
(WebCore::RenderBoxModelObject::relativePositionOffsetY): Ditto.
(WebCore::RenderBoxModelObject::paddingTop): Ditto.
(WebCore::RenderBoxModelObject::paddingBottom): Ditto.
(WebCore::RenderBoxModelObject::paddingLeft): Ditto.
(WebCore::RenderBoxModelObject::paddingRight): Ditto.
(WebCore::RenderBoxModelObject::paddingBefore): Ditto.
(WebCore::RenderBoxModelObject::paddingAfter): Ditto.
(WebCore::RenderBoxModelObject::paddingStart): Ditto.
(WebCore::RenderBoxModelObject::paddingEnd): Ditto.
(WebCore::RenderBoxModelObject::getBackgroundRoundedRect): Ditto.
(WebCore::RenderBoxModelObject::calculateFillTileSize): Ditto.
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): Ditto.
(WebCore::computeBorderImageSide): Ditto.
(WebCore::RenderBoxModelObject::paintNinePieceImage): Ditto.
(WebCore::RenderBoxModelObject::paintBorder): Ditto.
(WebCore::RenderBoxModelObject::paintBoxShadow): Ditto.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild): Ditto.
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes): Ditto.
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithm): Ditto.

  • rendering/RenderInline.cpp:

(WebCore::computeMargin): Ditto.
(WebCore::RenderInline::lineHeight): Ditto.

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::updateOptionsWidth): Ditto.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::repaintAfterLayoutIfNeeded): Ditto.

  • rendering/RenderObject.h:

(WebCore::RenderObject::viewportSize): New function to fetch the current viewport size.
(RenderObject):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::paint): Modified to support viewport relative Length types.

  • rendering/RenderScrollbarPart.cpp:

(WebCore::calcScrollbarThicknessUsing): Ditto.
(WebCore::RenderScrollbarPart::computeScrollbarWidth): Ditto.
(WebCore::RenderScrollbarPart::computeScrollbarHeight): Ditto.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth): Ditto.
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth): Ditto.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::logicalHeightForRowSizing): Ditto.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight): Ditto.

  • rendering/RenderText.h:

(WebCore::RenderText::marginLeft): Ditto.
(WebCore::RenderText::marginRight): Ditto.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMenuListButtonGradients): Ditto.

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::paint): Ditto.

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::verticalPositionForBox): Ditto.

  • rendering/style/RenderStyle.cpp:

(WebCore::calcRadiiFor): Ditto.
(WebCore::RenderStyle::getRoundedBorderFor): Ditto.

  • rendering/style/RenderStyle.h: Ditto.
  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::resolveLengthAttributeForSVG): Ditto.
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth): Ditto.
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight): Ditto.

LayoutTests:

  • css3/viewport-relative-lengths: Added.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle-expected.txt: Added.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle.html: Added.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute-expected.html: Added.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute.html: Added.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-expected.html: Added.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh.html: Added.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute-expected.html: Added.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute.html: Added.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-expected.html: Added.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin.html: Added.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute-expected.html: Added.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute.html: Added.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-expected.html: Added.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw.html: Added.
  • fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/win/fast/dom/Window/window-properties-expected.txt:

03/02/12:

23:43 Changeset [109655] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip a new crashing test.

  • platform/qt-5.0-wk2/Skipped:
23:34 Changeset [109654] by ossy@webkit.org
  • 3 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening, updated expected files.

  • platform/qt/editing/selection/select-line-break-with-opposite-directionality-expected.png: Added.
  • platform/qt/editing/selection/select-line-break-with-opposite-directionality-expected.txt: Added.
  • platform/qt/fast/dom/prototype-inheritance-2-expected.png:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
21:48 Changeset [109653] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk

Editor's default paragraph separator is not reset when a frame's document is changed
https://bugs.webkit.org/show_bug.cgi?id=80065

Patch by Pablo Flouret <pablof@motorola.com> on 2012-03-02
Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: editing/execCommand/reset-values-after-navigation.html

  • editing/Editor.cpp:

(WebCore::Editor::clear):

LayoutTests:

  • editing/execCommand/default-paragraph-separator.html: Last line of the test did a manual reset of the value to work around this problem. Removed.
  • editing/execCommand/reset-values-after-navigation-expected.txt: Added.
  • editing/execCommand/reset-values-after-navigation.html: Added.
  • editing/execCommand/resources/reset-default-values-helper-1.html: Added.
  • editing/execCommand/resources/reset-default-values-helper-2.html: Added.
21:31 Changeset [109652] by ap@apple.com
  • 2 edits
    1 add in trunk/Source/WebCore

Have a copy of plug-in sandboxing API header in WebCore
https://bugs.webkit.org/show_bug.cgi?id=80185
<rdar://problem/8242128>

Reviewed by Anders Carlsson.

  • plugins/npapi-sandbox.h: Added.
  • WebCore.xcodeproj/project.pbxproj: Added as unused file.
19:28 Changeset [109651] by noel.gordon@gmail.com
  • 1 edit
    2 adds in trunk/LayoutTests

:empty should apply to elements made empty via page dynamics
https://bugs.webkit.org/show_bug.cgi?id=79734

Reviewed by Antonio Gomes.

  • fast/css/pseudo-empty-dynamic-empty-expected.txt: Added.
  • fast/css/pseudo-empty-dynamic-empty.html: Added.
19:18 Changeset [109650] by lforschler@apple.com
  • 16 edits in tags/Safari-536.2

Merged r109340.

19:18 Changeset [109649] by ap@apple.com
  • 2 edits in trunk/Tools

Fix commit queue, remove duplicate entry.

  • Scripts/webkitpy/common/config/committers.py:
19:16 Changeset [109648] by lforschler@apple.com
  • 4 edits in tags/Safari-536.2/Source

Versioning.

19:13 Changeset [109647] by lforschler@apple.com
  • 1 copy in tags/Safari-536.2

New Tag.

18:41 Changeset [109646] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Expose WebInspector state to client and clean up WebSettings
https://bugs.webkit.org/show_bug.cgi?id=80177

Patch by Mike Fenton <mifenton@rim.com> on 2012-03-02
Reviewed by Antonio Gomes.

Expose the Web Inspector state to WebPage client's and
re-order initialization of WebSettings to be alphabetical
matching their definitions.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::isWebInspectorEnabled):

  • Api/WebPage.h:
  • Api/WebSettings.cpp:

(BlackBerry::WebKit::WebSettings::standardSettings):

18:35 Changeset [109645] by schenney@chromium.org
  • 2 edits in trunk/Tools

Unreviewed, add myself as a committer * Scripts/webkitpy/common/config/committers.py:

17:52 Changeset [109644] by barraclough@apple.com
  • 3 edits in trunk/LayoutTests

ES5.1-15.3.5.4. prohibits Function.caller from Get?ting a strict caller
https://bugs.webkit.org/show_bug.cgi?id=80011

We now support getting the caller from within an accessor.

Reviewed by Sam Weinig.

  • fast/js/function-dot-arguments-and-caller.html:
  • platform/qt/Skipped:
17:48 Changeset [109643] by eric@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Chrome 18 fails html5test.com XHR Blob response test
https://bugs.webkit.org/show_bug.cgi?id=76760

Unreviewed rebaselining. Cr-Linux returns
application/javascript for .js files instead of text/javascript.

  • platform/chromium-linux/fast/files/xhr-response-blob-expected.txt: Added.
17:47 Changeset [109642] by eae@chromium.org
  • 7 edits in trunk/Source/WebCore

Revert borders to integers for subpixel layout
https://bugs.webkit.org/show_bug.cgi?id=80175

Reviewed by Eric Seidel.

Change border representation and calculation back to integers to ensure
that borders given the same width are rendered with the same actual width.

This will also avoid unnecessary type conversions when we switch over
to subpixel precision.

No new tests.

  • rendering/LayoutTypes.h:

(WebCore::pixelSnappedIntRect):
(WebCore):

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::borderTop):
(WebCore::RenderBoxModelObject::borderBottom):
(WebCore::RenderBoxModelObject::borderLeft):
(WebCore::RenderBoxModelObject::borderRight):
(WebCore::RenderBoxModelObject::borderBefore):
(WebCore::RenderBoxModelObject::borderAfter):
(WebCore::RenderBoxModelObject::borderStart):
(WebCore::RenderBoxModelObject::borderEnd):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
(WebCore::RenderTable::calcBorderStart):
(WebCore::RenderTable::calcBorderEnd):
(WebCore::RenderTable::borderBefore):
(WebCore::RenderTable::borderAfter):
(WebCore::RenderTable::outerBorderBefore):
(WebCore::RenderTable::outerBorderAfter):
(WebCore::RenderTable::outerBorderStart):
(WebCore::RenderTable::outerBorderEnd):

  • rendering/RenderTable.h:

(WebCore::RenderTable::borderStart):
(WebCore::RenderTable::borderEnd):
(RenderTable):
(WebCore::RenderTable::borderLeft):
(WebCore::RenderTable::borderRight):
(WebCore::RenderTable::borderTop):
(WebCore::RenderTable::borderBottom):
(WebCore::RenderTable::outerBorderLeft):
(WebCore::RenderTable::outerBorderRight):
(WebCore::RenderTable::outerBorderTop):
(WebCore::RenderTable::outerBorderBottom):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
(WebCore::RenderTableCell::borderLeft):
(WebCore::RenderTableCell::borderRight):
(WebCore::RenderTableCell::borderTop):
(WebCore::RenderTableCell::borderBottom):
(WebCore::RenderTableCell::borderStart):
(WebCore::RenderTableCell::borderEnd):
(WebCore::RenderTableCell::borderBefore):
(WebCore::RenderTableCell::borderAfter):
(WebCore::RenderTableCell::borderHalfLeft):
(WebCore::RenderTableCell::borderHalfRight):
(WebCore::RenderTableCell::borderHalfTop):
(WebCore::RenderTableCell::borderHalfBottom):
(WebCore::RenderTableCell::borderHalfStart):
(WebCore::RenderTableCell::borderHalfEnd):
(WebCore::RenderTableCell::borderHalfBefore):
(WebCore::RenderTableCell::borderHalfAfter):
(WebCore::RenderTableCell::paintCollapsedBorders):

  • rendering/RenderTableCell.h:

(RenderTableCell):

17:32 Changeset [109641] by michaeln@google.com
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed, remove an erroneous expected result that showed up in r109303.

  • platform/chromium-linux/fast/workers/storage/use-same-database-in-page-and-workers-expected.txt: Removed.
17:24 Changeset [109640] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Mark a few tests as flaky on Leopard debug.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
17:22 Changeset [109639] by eae@chromium.org
  • 8 edits in branches/subpixellayout/Source

Change RenderBox::borderBoundingBox to return pixel snapped values and get rid of pixelSnapped version of same.

17:22 Changeset [109638] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

Accelerated compositing: Checkerboard never goes away
https://bugs.webkit.org/show_bug.cgi?id=79020
RIM PR #134164

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-03-02
Reviewed by Adam Treat.

Checkerboard appears in accelerated compositing layers when there's no
texture for (part of) a layer. The layer renderer queues up some render
jobs and schedules a commit to make the WebKit thread process those
jobs. Render jobs performed during commit cause texture upload jobs to
be scheduled on the UI thread. Texture uploads are performed when next
drawing the layers.

Unfortunately, sometimes commit operation happens without a subsequent
call draw the layers.

In order to implement one-shot drawing sync, I added a call to
commitRootLayerIfNeeded() in BackingStore::renderContents(), and
I was lucky that most of the time, renderContents() is followed by
blit(Visible)Contents() which in turn draws the layers.
However, render is not always followed by a blit, for example when
rendering offscreen tiles in BackingStore::renderOnIdle(), and in
direct rendering mode.

Fixed by making sure that every call to commitRootLayerIfNeeded() that
returns true is followed by a call to drawLayersOnCommit(), unless a
blit was requested already.

Also tweak the logic for one-shot drawing sync to make the code in
drawLayersOnCommit() reusable outside of rootLayerCommitTimerFired().

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::renderOnTimer):
(BlackBerry::WebKit::BackingStorePrivate::renderOnIdle):
(BlackBerry::WebKit::BackingStorePrivate::willFireTimer):
(BlackBerry::WebKit::BackingStorePrivate::renderDirectToWindow):
(BlackBerry::WebKit::BackingStorePrivate::render):
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
(BlackBerry::WebKit::BackingStorePrivate::blitContents):
(BlackBerry::WebKit::BackingStorePrivate::renderContents):
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::drawLayersOnCommitIfNeeded):

  • Api/BackingStore_p.h:

(BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::willDrawLayersOnCommit):

17:03 Changeset [109637] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Another test fix after r109593. Remove the extra start body tag.

  • editing/selection/select-line-break-with-opposite-directionality.html:
16:59 Changeset [109636] by adamk@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed rebaseline for Leopard.

  • platform/chromium-mac-leopard/fast/dom/scroll-reveal-left-overflow-expected.png: Added.
16:57 Changeset [109635] by eric@webkit.org
  • 4 edits
    5 adds in trunk

Chrome 18 fails html5test.com XHR Blob response test
https://bugs.webkit.org/show_bug.cgi?id=76760

Reviewed by Adam Barth.

Source/WebCore:

Most of the code was already there, this just fixes the FIXME
which was causing this feature not to work. Chromium already
had this #ifdef enabled, but other ports (at least Mac) do not.

Test: fast/files/xhr-response-blob.html

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::didFinishLoading):

LayoutTests:

  • fast/files/script-tests/xhr-response-blob.js: Added.

(xhr.onreadystatechange):

  • fast/files/xhr-response-blob-expected.txt: Added.
  • fast/files/xhr-response-blob.html: Added.
  • platform/chromium/fast/files/xhr-response-blob-expected.txt: Added.
16:50 Changeset [109634] by haraken@chromium.org
  • 7 edits
    1 delete in trunk/Source/WebCore

Revert Worker-related APIs from DOMWindowWorker.idl back to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=80151

Reviewed by Adam Barth.

Based on the discussion on webkit-dev@
(http://markmail.org/message/kagvswmah67zmrry#query:+page:1+mid:h34vzbiu5suub3ld+state:results),
this patch reverts Worker-related APIs from DOMWindowWorker.idl back to DOMWindow.idl.

No tests. No change in behavior.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • page/DOMWindow.idl:
  • workers/DOMWindowWorker.idl: Removed.
16:39 Changeset [109633] by aestes@apple.com
  • 9 edits
    2 adds in trunk/Source/WebKit2

Move nsStringFromWebCoreString out of PageClientImpl
https://bugs.webkit.org/show_bug.cgi?id=80202

Reviewed by Sam Weinig.

nsStringFromWebCoreString() doesn't really belong in PageClientImpl.mm,
and it makes us include PageClientImpl.h in places where we shouldn't.
Move this function into StringUtilities.{h, mm}.

  • Platform/mac/StringUtilities.h: Added.
  • Platform/mac/StringUtilities.mm: Added.

(WebKit::nsStringFromWebCoreString):

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:
  • UIProcess/API/mac/WKView.mm:
  • UIProcess/mac/WebContextMenuProxyMac.mm:
  • UIProcess/mac/WebPageProxyMac.mm:
  • UIProcess/mac/WebPopupMenuProxyMac.mm:
  • UIProcess/mac/WebPreferencesMac.mm:
  • WebKit2.xcodeproj/project.pbxproj:
16:29 Changeset [109632] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed test expectations cleanup.
Marked a bunch of flakiness as happening only in DEBUG,
and removed a whole set of tests that are no longer flaky.

  • platform/chromium/test_expectations.txt:
16:19 Changeset [109631] by adamk@chromium.org
  • 2 edits
    33 adds in trunk/LayoutTests

Unreviewed rebaseline of SVG feImage tests after r105612 and r106113.

  • platform/chromium-linux/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png: Added.
  • platform/chromium-linux/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png: Added.
  • platform/chromium-linux/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png: Added.
  • platform/chromium-linux/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png: Added.
  • platform/chromium-mac-leopard/svg/filters/feImage-subregions-expected.png: Added.
  • platform/chromium-mac-leopard/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png: Added.
  • platform/chromium-mac-leopard/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-position-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-subregions-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-target-add-to-document-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-target-changes-id-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-target-id-change-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-target-reappend-to-document-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-target-remove-from-document-expected.png: Added.
  • platform/chromium-win/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png: Added.
  • platform/chromium-win/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png: Added.
  • platform/chromium-win/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png: Added.
  • platform/chromium-win/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png: Added.
  • platform/chromium-win/svg/filters/feImage-position-expected.png: Added.
  • platform/chromium-win/svg/filters/feImage-subregions-expected.png: Added.
  • platform/chromium-win/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png: Added.
  • platform/chromium-win/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png: Added.
  • platform/chromium-win/svg/filters/feImage-target-add-to-document-expected.png: Added.
  • platform/chromium-win/svg/filters/feImage-target-changes-id-expected.png: Added.
  • platform/chromium-win/svg/filters/feImage-target-id-change-expected.png: Added.
  • platform/chromium-win/svg/filters/feImage-target-reappend-to-document-expected.png: Added.
  • platform/chromium-win/svg/filters/feImage-target-remove-from-document-expected.png: Added.
  • platform/chromium/test_expectations.txt:
16:15 Changeset [109630] by haraken@chromium.org
  • 8 edits
    1 delete in trunk/Source/WebCore

Revert HTML-related APIs from DOMWindowHTML.idl back to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=80140

Reviewed by Adam Barth.

Based on the discussion on webkit-dev@
(http://markmail.org/message/kagvswmah67zmrry#query:+page:1+mid:h34vzbiu5suub3ld+state:results),
we should revert HTML-related APIs from DOMWindowHTML.idl back to DOMWindow.idl.

No tests. No change in behavior.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • html/DOMWindowHTML.idl: Removed.
  • page/DOMWindow.idl:
16:08 Changeset [109629] by adamk@chromium.org
  • 9 edits
    1 add
    1 delete in trunk/LayoutTests

Unreviewed, rebaseline some SVG tests after r105612.

  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
  • platform/chromium-linux/svg/filters/feImage-reference-svg-primitive-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/feImage-reference-invalidation-expected.png:
  • platform/chromium-mac-snowleopard/svg/filters/feImage-reference-svg-primitive-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
  • platform/chromium-win/svg/filters/feImage-reference-invalidation-expected.png:
  • platform/chromium-win/svg/filters/feImage-reference-svg-primitive-expected.png:
  • platform/chromium/test_expectations.txt:
15:59 Changeset [109628] by haraken@chromium.org
  • 8 edits
    1 delete in trunk/Source/WebCore

Revert XML-related APIs from DOMWindowXML.idl back to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=80148

Reviewed by Adam Barth.

Based on the discussion on webkit-dev@
(http://markmail.org/message/kagvswmah67zmrry#query:+page:1+mid:h34vzbiu5suub3ld+state:results),
this patch reverts XML-related APIs from DOMWindowXML.idl back to DOMWindow.idl.

No tests. No change in behavior.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • page/DOMWindow.idl:
  • xml/DOMWindowXML.idl: Removed.
15:57 Changeset [109627] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

When getting the line number of a call into a call frame with no code block, it's
incorrect to rely on the returnPC
https://bugs.webkit.org/show_bug.cgi?id=80195

Reviewed by Oliver Hunt.

  • interpreter/Interpreter.cpp:

(JSC::getCallerInfo):

  • jit/JITCall.cpp:

(JSC::JIT::compileLoadVarargs):

15:49 Changeset [109626] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, widen flaky crash expectations for FileWriter test.

  • platform/chromium/test_expectations.txt:
15:42 Changeset [109625] by adamk@chromium.org
  • 2 edits
    1 move
    12 adds
    1 delete in trunk/LayoutTests

Unreviewed rebaselining, update a bunch of old results for Snow Leopard.

  • platform/chromium-linux/css2.1/t1605-c545-txttrans-00-b-ag-expected.png: Added.
  • platform/chromium-mac-snowleopard/css1/text_properties/text_transform-expected.png: Added.
  • platform/chromium-mac-snowleopard/css1/text_properties/text_transform-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css2.1/t1605-c545-txttrans-00-b-ag-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t1605-c545-txttrans-00-b-ag-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/canvas/arc360-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/transform-default-parameter-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/scroll-reveal-left-overflow-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/scroll-reveal-left-overflow-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/dom/scroll-reveal-left-overflow-expected.txt.
  • platform/chromium-mac-snowleopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
  • platform/chromium-mac-snowleopard/fonts/monospace-expected.png: Added.
  • platform/chromium-mac-snowleopard/transitions/move-after-transition-expected.png: Added.
  • platform/chromium-mac/fast/dom/scroll-reveal-left-overflow-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
15:42 Changeset [109624] by eae@chromium.org
  • 5 edits in branches/subpixellayout/Source/WebCore/rendering

Clean up paintInfo and absoluteBoundingBox calling code on branch.

15:34 Changeset [109623] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed test fix. Don't add an event listener for interactive debugging
when the test is ran inside a DumpRenderTree / WebKitTestRunner.

  • editing/selection/select-line-break-with-opposite-directionality.html:
15:24 Changeset [109622] by aestes@apple.com
  • 1 edit in trunk/Source/WebKit2/ChangeLog

Fix a ChangeLog typo.

15:23 Changeset [109621] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

Remove com.apple.WebKit.PluginProcess.sb from WebKit2.xcodeproj's Headers build phase
https://bugs.webkit.org/show_bug.cgi?id=80197

Reviewed by Alexey Proskuryakov.

It doesn't belong there, and it makes the Xcode consider the project to
be invalid, triggering assertions in some builds of Xcode.

  • WebKit2.xcodeproj/project.pbxproj:
15:10 Changeset [109620] by commit-queue@webkit.org
  • 4 edits in trunk

Make webkit-gtk translations respect LINGUAS
https://bugs.webkit.org/show_bug.cgi?id=79605

Patch by Alexandre Rostovtsev <tetromino@gentoo.org> on 2012-03-02
Reviewed by Martin Robinson.

.:

PO_LINGUAS, USER_LINGUAS, and USE_LINGUAS added to root
GNUmakefile.am to ensure that they can be used in the definition of
MOFILES that will be generated by automake.

  • GNUmakefile.am:

Source/WebKit/gtk/po:

  • GNUmakefile.am:
14:48 Changeset [109619] by caio.oliveira@openbossa.org
  • 4 edits in trunk/Source/WebCore

Implement NamedNodeMap::setNamedItem() in terms of Element::setAttributeNode() instead of the other way round
https://bugs.webkit.org/show_bug.cgi?id=80188

Reviewed by Ryosuke Niwa.

Using setNamedItem() in setAttributeNode() implementation made us do unnecessary
checks like whether the element existed or whether the given node was an
attribute. So now setAttributeNode() do less work.

No new tests were added, functionality should be unchanged.

  • dom/Element.cpp:

(WebCore::Element::setAttributeNode):
(WebCore::Element::setAttributeNodeNS):

  • dom/Element.h:

(Element):
(WebCore::Element::attributes): We got rid of ensureUpdatedAttributes(), next in
line will be updatedAttributes().

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::setNamedItem):

14:44 Changeset [109618] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Expected results updated for checking type conversion
https://bugs.webkit.org/show_bug.cgi?id=80138

Patch by Han Hojong <hojong.han@samsung.com> on 2012-03-02
Reviewed by Gavin Barraclough.

  • tests/mozilla/ecma/TypeConversion/9.3.1-3.js:
14:41 Changeset [109617] by commit-queue@webkit.org
  • 7 edits
    6 copies
    3 moves
    4 adds
    34 deletes in trunk/LayoutTests

Unreviewed, rolling out r109602.
http://trac.webkit.org/changeset/109602
https://bugs.webkit.org/show_bug.cgi?id=80194

some TEXT baselines were wrong and some baselines were wrongly
removed (Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-02

  • platform/chromium-linux-x86/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
  • platform/chromium-linux/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/input-text-double-click-expected.txt:
  • platform/chromium-mac-leopard/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/layers/remove-layer-with-nested-stacking-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/repaint/overflow-delete-line-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/repaint/repaint-resized-overflow-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/repaint/subtree-layoutstate-transform-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/repaint/subtree-root-skipped-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/replaced/replaced-breaking-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/text/textIteratorNilRenderer-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/box-shadow/shadow-buffer-partial-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/layers/remove-layer-with-nested-stacking-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/layers/remove-layer-with-nested-stacking-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/inline-relative-positioned-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/inline-relative-positioned-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/overflow-delete-line-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/overflow-delete-line-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/repaint-resized-overflow-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/repaint-resized-overflow-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/subtree-layoutstate-transform-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/subtree-layoutstate-transform-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-2-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/subtree-root-skipped-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/subtree-root-skipped-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.txt: Removed.
  • platform/chromium-mac/fast/box-shadow/shadow-buffer-partial-expected.png: Added.
  • platform/chromium-mac/fast/clip/008-expected.png: Added.
  • platform/chromium-mac/fast/clip/011-expected.png: Added.
  • platform/chromium-mac/fast/clip/012-expected.png: Added.
  • platform/chromium-win-vista/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
  • platform/chromium-win-xp/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
  • platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png:
  • platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
  • platform/chromium-win/fast/clip/008-expected.txt:
  • platform/chromium-win/fast/clip/011-expected.txt:
  • platform/chromium-win/fast/clip/012-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/layers/add-layer-with-nested-stacking-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.txt.
  • platform/gtk/fast/repaint/subtree-root-clip-2-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-2-expected.txt.
  • platform/gtk/fast/repaint/subtree-root-clip-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-expected.txt.
  • platform/mac/fast/layers/add-layer-with-nested-stacking-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.txt.
  • platform/mac/fast/repaint/subtree-root-clip-2-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-2-expected.txt.
  • platform/mac/fast/repaint/subtree-root-clip-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-expected.txt.
  • platform/qt/fast/layers/add-layer-with-nested-stacking-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.txt.
  • platform/qt/fast/repaint/subtree-root-clip-2-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-2-expected.txt.
  • platform/qt/fast/repaint/subtree-root-clip-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-expected.txt.
14:34 Changeset [109616] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Widen/correct a few chromium expectations.

  • platform/chromium/test_expectations.txt:
14:25 Changeset [109615] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

DOM tests take too long to run
https://bugs.webkit.org/show_bug.cgi?id=80082

Reviewed by Eric Seidel.

Reduce benchmark.timeToRun from 500ms to 100ms. Doesn't seem to affect test results much
(except DOM/DOMTable.html) but significantly reduces the runtime of tests.

  • DOM/resources/dom-perf.js:

(BenchmarkSuite.prototype.RunSingle):

14:16 Changeset [109614] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Rebaseline an inspector test after r109599.
"evt" was changed to "event", lengthening it by two characters.

Unreviewed gardening.

  • platform/chromium/inspector/debugger/debugger-scripts-expected.txt:
14:00 Changeset [109613] by ojan@chromium.org
  • 2 edits in trunk/Tools

Add the Chromium Lion canary bot to the flakiness dashboard.

  • TestResultServer/static-dashboards/builders.js:
13:59 Changeset [109612] by dpranke@chromium.org
  • 4 edits
    3 adds in trunk

Layout issue with fieldset legend element
https://bugs.webkit.org/show_bug.cgi?id=78684

Patch by SravanKumar Sandela <ssandela@innominds.com> on 2012-03-02
Reviewed by Dirk Pranke.

Source/WebCore:

The clipping logic for legend element was incorrect and now it has been corrected by taking correct offset in to consideration.

Test: fast/forms/fieldset-legend-padding-unclipped-fieldset-border.html

  • rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::paintBoxDecorations):

LayoutTests:

  • fast/forms/fieldset-legend-padding-unclipped-fieldset-border.html: Added.

Test case to check un-clipped border logic

  • platform/chromium/test_expectations.txt:
  • platform/win/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png: Added.
  • platform/win/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt: Added.
13:45 Changeset [109611] by arv@chromium.org
  • 12 edits in trunk/Source/WebCore

[V8] Bindings for node always check if they are a Document.
https://bugs.webkit.org/show_bug.cgi?id=79947

Reviewed by Adam Barth.

This changes the generated bindings code to only generate the Document code for the Document wrappers.

No new tests. Covered by existing tests.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateToV8Converters):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::V8Float64Array::wrapSlow):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::wrapSlow):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::wrapSlow):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::wrapSlow):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::V8TestEventTarget::wrapSlow):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::wrapSlow):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::wrapSlow):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::wrapSlow):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::wrapSlow):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):

13:40 Changeset [109610] by igor.o@sisa.samsung.com
  • 3 edits
    2 adds in trunk

animation-timing-function falls back to ease when overriding animation-name
https://bugs.webkit.org/show_bug.cgi?id=71623

Source/WebCore:

In this patch the animation name needs to be the first value declared, if
a different value is found, we do not check for the animation name again.

Reviewed by Dean Jackson.

Test: animations/animation-shorthand-overriding.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseAnimationShorthand):

LayoutTests:

Add a test to verify if the override the animation-name property works when the parent
animation did not set the animation name.

Reviewed by Dean Jackson.

  • animations/animation-shorthand-overriding-expected.txt: Added.
  • animations/animation-shorthand-overriding.html: Added.
13:37 Changeset [109609] by mrobinson@webkit.org
  • 6 edits
    1 move
    1 add
    1 delete in trunk/Source/WebCore

[GTK] [AC] Connect WebGL to the TextureMapperGL code
https://bugs.webkit.org/show_bug.cgi?id=78968

Reviewed by Gustavo Noronha Silva.

No new tests. This is covered by existing accelerated compositing and
WebGL tests.

Rely on the shared version of GL acquisition from GLContext. This reduces
a lot of code and now allows us to connect WebGL into the accelerated compositing
rendering path.

  • GNUmakefile.list.am: GLContext should be included for all X11 builds now.

There are no longer GTK+ specific versions of GraphicsContext3D.

  • platform/graphics/GraphicsContext3D.h: Add a default argument for

resolveMultisamplingIfNecessary. This will resolve the entire texture.

  • platform/graphics/cairo/GraphicsContext3DCairo.cpp: GraphicsContext3D is

now responsible for creating GraphicsContext3DPrivate in the constructor.
(WebCore::GraphicsContext3D::platformLayer): Now return m_private.

  • platform/graphics/cairo/GraphicsContext3DPrivate.cpp: Added.
  • platform/graphics/cairo/GraphicsContext3DPrivate.h: Renamed from Source/WebCore/platform/graphics/glx/GraphicsContext3DPrivate.h.
  • platform/graphics/glx/GraphicsContext3DPrivate.cpp: Removed.
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::resolveMultisamplingIfNecessary): Properly
handle the default argument.

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::prepareTexture): Use the new default argument now.
(WebCore::GraphicsContext3D::readRenderingResults): Ditto.

13:33 Changeset [109608] by vestbo@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Fix spelling mistake in header guard

Reviewed by Noam Rosenthal.

13:32 Changeset [109607] by vestbo@webkit.org
  • 2 edits in trunk

[Qt] Remove deleted file from api.pro

Reviewed by Noam Rosenthal.

13:13 Changeset [109606] by dpranke@chromium.org
  • 3 edits in trunk/Tools

links for virtual tests are broken in the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=80180

Reviewed by Ojan Vafai.

  • TestResultServer/static-dashboards/flakiness_dashboard.html:

(linkHTMLToOpenWindow):

  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:

(testLinkHTMLToOpenWindow): added.

13:08 Changeset [109605] by mrobinson@webkit.org
  • 5 edits
    3 adds
    2 deletes in trunk/Source

[GTK] [AC] Generalize WindowContextGL
https://bugs.webkit.org/show_bug.cgi?id=78969

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

No new tests. This should not change functionality.

  • GNUmakefile.list.am: Added new files to source list.
  • platform/graphics/cairo/GLContext.h: Added. An abstraction for all GL contexts.
  • platform/graphics/glx/GLContextGLX.cpp: Added. This file is composed of very little

new code, as the logic for instantiating offscreen GL contexts is copied from
GraphicsContext3DPrivate. The code duplication will be removed in a followup patch.
(WebCore::GLContext::platformContext):

  • platform/graphics/gtk/GLContextGtk.cpp: Added. This includes some helper factories

for creating and caching GL contexts for GTK+ widgets.

Source/WebKit/gtk:

Use GLContext instead of WindowContextGL. Remove a few unnecessary
namespace specifiers in the implementation of AcceleratedCompositingContext.

  • WebCoreSupport/AcceleratedCompositingContext.h: Now we find the GLContext

of our widget, which is cached in WebCore. Remove m_initialized as it isn't needed.
(AcceleratedCompositingContext):

  • WebCoreSupport/AcceleratedCompositingContextGL.cpp:

(WebKit::AcceleratedCompositingContext::AcceleratedCompositingContext): No longer initialize
m_initialized.
(WebKit::AcceleratedCompositingContext::glContext): Added.
(WebKit::AcceleratedCompositingContext::renderLayersToWindow): Use glContext() now.
(WebKit::AcceleratedCompositingContext::attachRootGraphicsLayer): Ditto.
(WebKit::AcceleratedCompositingContext::notifyAnimationStarted): Remove unnecessary namespace specifier.
(WebKit::AcceleratedCompositingContext::notifySyncRequired): Ditto.
(WebKit::AcceleratedCompositingContext::paintContents): Ditto.
(WebKit::AcceleratedCompositingContext::showDebugBorders): Ditto.
(WebKit::AcceleratedCompositingContext::showRepaintCounter): Ditto.

12:58 Changeset [109604] by caryclark@google.com
  • 6 edits
    2 adds in trunk/LayoutTests

new baselines for Skia shadows

Unreviewed rebaselining.

  • platform/chromium-win-vista/svg/css/group-with-shadow-expected.png:
  • platform/chromium-win-xp/svg/css: Added.
  • platform/chromium-win-xp/svg/css/group-with-shadow-expected.png: Added.
  • platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-win/fast/transforms/shadows-expected.png:
  • platform/chromium-win/svg/css/group-with-shadow-expected.png:
  • platform/chromium/test_expectations.txt:
12:54 Changeset [109603] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Suppress an inspector test timing out after r109561.

  • platform/chromium/test_expectations.txt:
12:45 Changeset [109602] by jchaffraix@webkit.org
  • 7 edits
    40 adds
    13 deletes in trunk/LayoutTests

Unreviewed Chromium rebaselining.

Those tests have consistent results with other platforms and with the expected
result so unmark and rebaseline them.

  • platform/chromium-linux-x86/fast/box-shadow: Added.
  • platform/chromium-linux-x86/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
  • platform/chromium-linux/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
  • platform/chromium-linux/fast/forms/input-text-double-click-expected.txt:
  • platform/chromium-mac-leopard/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/layers/remove-layer-with-nested-stacking-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/overflow-delete-line-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/repaint-resized-overflow-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/subtree-layoutstate-transform-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/subtree-root-skipped-expected.png: Added.
  • platform/chromium-mac-leopard/fast/replaced/replaced-breaking-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/textIteratorNilRenderer-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/box-shadow/shadow-buffer-partial-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/layers/remove-layer-with-nested-stacking-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/layers/remove-layer-with-nested-stacking-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/inline-relative-positioned-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/inline-relative-positioned-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/overflow-delete-line-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/overflow-delete-line-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/repaint-resized-overflow-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/repaint-resized-overflow-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/subtree-layoutstate-transform-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/subtree-layoutstate-transform-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/subtree-root-skipped-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/subtree-root-skipped-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.txt: Added.
  • platform/chromium-mac/fast/box-shadow/shadow-buffer-partial-expected.png: Removed.
  • platform/chromium-mac/fast/clip/008-expected.png: Removed.
  • platform/chromium-mac/fast/clip/011-expected.png: Removed.
  • platform/chromium-mac/fast/clip/012-expected.png: Removed.
  • platform/chromium-win-vista/fast/box-shadow: Added.
  • platform/chromium-win-vista/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
  • platform/chromium-win-xp/fast/box-shadow: Added.
  • platform/chromium-win-xp/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
  • platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png:
  • platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
  • platform/chromium-win/fast/clip/008-expected.txt:
  • platform/chromium-win/fast/clip/011-expected.txt:
  • platform/chromium-win/fast/clip/012-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
  • platform/gtk/fast/repaint/subtree-root-clip-2-expected.txt: Removed.
  • platform/gtk/fast/repaint/subtree-root-clip-expected.txt: Removed.
  • platform/mac/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
  • platform/mac/fast/repaint/subtree-root-clip-2-expected.txt: Removed.
  • platform/mac/fast/repaint/subtree-root-clip-expected.txt: Removed.
  • platform/qt/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
  • platform/qt/fast/repaint/subtree-root-clip-2-expected.txt: Removed.
  • platform/qt/fast/repaint/subtree-root-clip-expected.txt: Removed.
12:39 Changeset [109601] by adamk@chromium.org
  • 2 edits
    9 adds in trunk/LayoutTests

Rebaselining SVG foreignObject tests after r108494.

Unreviewed gardening.

  • platform/chromium-linux/svg/foreignObject/fO-parent-display-changes-expected.png: Added.
  • platform/chromium-mac-leopard/svg/foreignObject/fO-parent-display-changes-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/foreignObject/fO-parent-display-changes-expected.png: Added.
  • platform/chromium-win/svg/foreignObject/fO-parent-display-changes-expected.png: Added.
  • platform/chromium-win/svg/foreignObject/fO-parent-display-changes-expected.txt: Added.
  • platform/chromium-win/svg/foreignObject/fO-parent-display-none-expected.txt: Added.
  • platform/chromium-win/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt: Added.
  • platform/chromium-win/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt: Added.
  • platform/chromium-win/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
12:34 Changeset [109600] by wjmaclean@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Remove TRACE_EVENT from CCQuadCuller::cullOccludedQuads.
https://bugs.webkit.org/show_bug.cgi?id=80174

Reviewed by James Robinson.

Covered by existing chromium unit tests.

Firing TRACE_EVENT once per draw quad is overwhelming.

  • platform/graphics/chromium/cc/CCQuadCuller.cpp:

(WebCore::CCQuadCuller::cullOccludedQuads):

12:30 Changeset [109599] by arv@chromium.org
  • 3 edits
    2 adds in trunk

[V8] Make inline event attributes use evt for SVG and event otherwise
https://bugs.webkit.org/show_bug.cgi?id=80167

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/dom/inline-event-attributes-event-param-name.html

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

LayoutTests:

  • fast/dom/inline-event-attributes-event-param-name-expected.txt: Added.
  • fast/dom/inline-event-attributes-event-param-name.html: Added.
12:11 Changeset [109598] by gavinp@chromium.org
  • 2 edits in trunk/Source/WebCore

Sync PageCache debugging with PageCache behaviour
https://bugs.webkit.org/show_bug.cgi?id=79943

Sync up the debug printing code in PageCache with the actual logic,
and clean up the debug printing at the same time.

Reviewed by Brady Eidson.

No new tests, as this is a refactor of debug only code.

  • history/PageCache.cpp:

(WebCore):
(WebCore::logCanCacheFrameDecision):
(WebCore::logCanCachePageDecision):

12:07 Changeset [109597] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Fix expectation for svg/foreignObject/fO-parent-display-changes.svg.

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
12:05 Changeset [109596] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, suppress some failures in shadow tests due to the skia roll.

  • platform/chromium/test_expectations.txt:
12:01 Changeset [109595] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

[chromium] Layout test fast/events/overflow-events.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=52064

Reviewed by Simon Fraser.

Try to make the test less flaky.

  • fast/events/overflow-events.html:

Ensure that the 'overflow' events arrive one at a time in order (there is no guarantee that they *do* dispatch
though). Also added a clearer message if we fail the test. That should help us if the test is still flaky.

11:58 Changeset [109594] by mjs@apple.com
  • 6 edits
    4 adds in trunk

Source/WebCore: REGRESSION(r97353): Crash when accessing location or history properties inside a navigated window
https://bugs.webkit.org/show_bug.cgi?id=80133
<rdar://problem/10432233>

Reviewed by Antti Koivisto.

Test: fast/dom/Window/navigated-window-properties.html

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore): Remove custom getters for window.location and window.history; they
were unnecessary and did the wrong thing when DOMWindow returned null values
for these.

  • page/DOMWindow.idl: ditto
  • bindings/js/JSDOMBinding.cpp:

(WebCore::reportException): Remove assert about null values and update comment,
since this is now an expected state for navigated inner windows.

LayoutTests: REGRESSION(r97353): Crash when accessing location or history properties inside a navigated window
https://bugs.webkit.org/show_bug.cgi?id=80133

Reviewed by Antti Koivisto.

  • fast/dom/Window/navigated-window-properties-expected.txt: Added.
  • fast/dom/Window/navigated-window-properties.html: Added.
  • fast/dom/Window/resources/navigated-window-prop-subframe1.html: Added.
  • fast/dom/Window/resources/navigated-window-prop-subframe2.html: Added.
11:54 Changeset [109593] by rniwa@webkit.org
  • 9 edits
    2 adds in trunk

REGRESSION(r74971): Can't select a line of RTL text on Facebook
https://bugs.webkit.org/show_bug.cgi?id=59435

Reviewed by Eric Seidel.

Source/WebCore:

The bug was caused by inline text boxes created by BRs being placed at the end of the line
according to the block's direction regardless of its unicode bidi-level. e.g. if we have
<div dir="rtl"><span dir="ltr">hello<br>world</span></div>
the inline box generated by the br has the bidi-level of 2 like the rest of text in the span.
This inline text box gives an illusion of having text on the left of "hello" to hit testing
and editing code and causes all sorts of problems.

Fixed the bug by replacing calls to nextLeafChild and prevLeafChild by newly introduced
nextLeafChildIgnoringLineBreak and prevLeafChildIgnoringLineBreak. These two functions will
return 0 when they hit the end of a line or inline text box that's a line break. In effect,
hit testing and editing code can ignore inline boxes generated by br's.

In the long term, we should move these two functions into RenderedPosition along with the rest
of code that converts a Position and an inline box, offset pair.

Test: editing/selection/select-line-break-with-opposite-directionality.html

  • dom/Position.cpp:

(WebCore::Position::getInlineBoxAndOffset):

  • editing/RenderedPosition.cpp:

(WebCore::RenderedPosition::prevLeafChild):
(WebCore::RenderedPosition::nextLeafChild):

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::nextLeafChildIgnoringLineBreak):
(WebCore::InlineBox::prevLeafChildIgnoringLineBreak):

  • rendering/InlineBox.h:
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::positionForPointWithInlineChildren):

  • rendering/RenderText.cpp:

(WebCore::lineDirectionPointFitsInBox): If we're on the left of a RTL line, we should stay at
upstream position since we're at the end of a line.
(WebCore::createVisiblePositionAfterAdjustingOffsetForBiDi): Merge the two special cases into
the general loop as the comment suggests. Skip an inline text box for a line break at the left
edge when there are more line boxes on the line.
(WebCore::RenderText::positionForPoint):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::closestLeafChildForLogicalLeftPosition): Ignore line boxes created for
line boxes when there are other boxes on the line.

LayoutTests:

Add a regression test for selecting multiline bidirectional text.

  • editing/selection/select-line-break-with-opposite-directionality-expected.txt: Added.
  • editing/selection/select-line-break-with-opposite-directionality.html: Added.
11:48 Changeset [109592] by commit-queue@webkit.org
  • 7 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=80161
PR: 141157

BlackBerryPlatformScreen.h API has been updated. Reflect those
changes in our usage.

Source/WebCore:

Patch by Adam Treat <atreat@rim.com> on 2012-03-02
Reviewed by Antonio Gomes.
Internally reviewed by Jakob Petsovits

  • platform/blackberry/PlatformScreenBlackBerry.cpp:

(WebCore::screenAvailableRect):
(WebCore::screenRect):

Source/WebKit/blackberry:

Patch by Adam Treat <atreat@rim.com> on 2012-03-02
Reviewed by Antonio Gomes.
Internally reviewed by Jakob Petsovits.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::tileWidth):
(BlackBerry::WebKit::BackingStorePrivate::tileHeight):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPagePrivate::transformedViewportSize):
(BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):
(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
(BlackBerry::WebKit::WebPagePrivate::setDefaultLayoutSize):
(BlackBerry::WebKit::WebPagePrivate::defaultMaxLayoutSize):

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::restoreViewState):

  • WebKitSupport/SurfacePool.cpp:

(BlackBerry::WebKit::createCompositingSurface):

11:47 Changeset [109591] by adamk@chromium.org
  • 14 edits
    1 move
    7 adds
    2 deletes in trunk/LayoutTests

Chromium rebaselines after r109512.

Unreviewed gardening.

  • platform/chromium-linux/fast/block/float/026-expected.png:
  • platform/chromium-linux/fast/block/float/028-expected.png:
  • platform/chromium-linux/fast/overflow/unreachable-overflow-rtl-bug-expected.png:
  • platform/chromium-mac-leopard/fast/block/float/026-expected.png:
  • platform/chromium-mac-leopard/fast/block/float/028-expected.png:
  • platform/chromium-mac-leopard/fast/overflow/unreachable-overflow-rtl-bug-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/float/026-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/float/026-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/block/float/028-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/float/028-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/events/offsetX-offsetY-expected.txt: Renamed from LayoutTests/platform/chromium/fast/events/offsetX-offsetY-expected.txt.
  • platform/chromium-mac-snowleopard/fast/overflow/unreachable-overflow-rtl-bug-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/overflow/unreachable-overflow-rtl-bug-expected.txt: Added.
  • platform/chromium-mac/fast/block/float/026-expected.png: Removed.
  • platform/chromium-mac/fast/block/float/028-expected.png: Removed.
  • platform/chromium-win/fast/block/float/026-expected.png:
  • platform/chromium-win/fast/block/float/026-expected.txt:
  • platform/chromium-win/fast/block/float/028-expected.png:
  • platform/chromium-win/fast/block/float/028-expected.txt:
  • platform/chromium-win/fast/events/offsetX-offsetY-expected.txt:
  • platform/chromium-win/fast/overflow/unreachable-overflow-rtl-bug-expected.png:
  • platform/chromium-win/fast/overflow/unreachable-overflow-rtl-bug-expected.txt:
  • platform/chromium/test_expectations.txt:
11:44 Changeset [109590] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

[Chromium] Allow plugins to set opaque() on their platform layer
https://bugs.webkit.org/show_bug.cgi?id=80171

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-02
Reviewed by James Robinson.

  • public/WebPluginContainer.h:

(WebPluginContainer):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::setOpaque):
(WebKit):

  • src/WebPluginContainerImpl.h:

(WebPluginContainerImpl):

11:41 Changeset [109589] by jchaffraix@webkit.org
  • 2 edits in trunk/Source/WebCore

Move the 'overflow' event dispatching logic out of RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=80090

Unreviewed build fix.

  • rendering/RenderBlock.cpp:

(OverflowEventDispatcher): Removed the unused function.

11:28 Changeset [109588] by caryclark@google.com
  • 111 edits
    3 adds
    29 deletes in trunk/LayoutTests

Unreviewed rebaselining of images affected by these changes:
https://bugs.webkit.org/show_bug.cgi?id=76556 ('Match style of platform error underline for misspellings')
https://bugs.webkit.org/show_bug.cgi?id=78117 ('[Skia Mac] Make misspelling underline dots unclipped')

  • platform/chromium-mac-leopard/editing/deleting/delete-3928305-fix-expected.png:

[139 lines deleted]

  • platform/chromium-mac-snowleopard/fast/dom/blur-contenteditable-expected.png: Added.
  • platform/chromium/test_expectations.txt:
11:24 Changeset [109587] by jchaffraix@webkit.org
  • 6 edits
    2 adds in trunk

Move the 'overflow' event dispatching logic out of RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=80090

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/events/overflow-events-writing-mode.html

This moves the 'overflow' event dispatch from RenderLayer to an helper class
OverflowEventDispatcher. For now, the class lives in RenderBlock as it matches
the existing code but it may be moved later to its own class as FrameView could
benefit from it too or if we need to support 'overflow' events on RenderBoxes.

  • rendering/RenderBlock.cpp:

(WebCore):
(OverflowEventDispatcher):
(WebCore::OverflowEventDispatcher::OverflowEventDispatcher):
(WebCore::OverflowEventDispatcher::~OverflowEventDispatcher):
(WebCore::OverflowEventDispatcher::computeOverflowStatus):
RAII dispatcher class that stores the information before layout and compare
them after to dispatch the right information.

(WebCore::RenderBlock::layout): Added an instance of OverflowEventDispatcher.

  • rendering/RenderBox.h:

(WebCore::RenderBox::hasHorizontalLayoutOverflow):
(WebCore::RenderBox::hasVerticalLayoutOverflow):
Helper method to know if we have an horizontal / vertical layout overflow.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):

  • rendering/RenderLayer.h:

Removed the scroll tracking logic as we don't need it anymore. This removes
3 booleans from RenderLayer.

LayoutTests:

  • fast/events/overflow-events-writing-mode.html: Added.
  • fast/events/overflow-events-writing-mode-expected.txt: Added.

Added a test for overflow events in a vertical writing mode.

11:05 Changeset [109586] by adamk@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Rebaseline a test on Leopard after expectation was removed in r109516.

Unreviewed gardening.

  • platform/chromium-mac-leopard/fast/repaint/transform-absolute-in-positioned-container-expected.png: Added.
11:02 Changeset [109585] by caio.oliveira@openbossa.org
  • 8 edits in trunk/Source/WebCore

Create a method in Element to compare attributes with other Element
https://bugs.webkit.org/show_bug.cgi?id=80169

Reviewed by Ryosuke Niwa.

Avoid manually peeking at attribute storage to get this information. This
simplify the callsites. The actual implementation of comparison was moved to
ElementAttributeData. The mapsEquivalent() function still exists for the sake
of DocumentType nodes.

  • dom/Element.cpp:

(WebCore::Element::hasEquivalentAttributes):
(WebCore):

  • dom/Element.h:

(Element):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::isEquivalent):
(WebCore):

  • dom/ElementAttributeData.h:

(ElementAttributeData):

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::mapsEquivalent):

  • dom/Node.cpp:

(WebCore::Node::isEqualNode):

  • editing/htmlediting.cpp:

(WebCore::areIdenticalElements): Use Element::hasTagName() instead of matching
directly to make code a bit clearer.

10:03 Changeset [109584] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[GTK] Smooth scrolling support
https://bugs.webkit.org/show_bug.cgi?id=16123

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-03-02
Reviewed by Martin Robinson.

Source/WebCore:

No new tests - no new functionality.

Add the ScrollAnimatorNone class to compilation and enable
the smooth scrolling feature by default at compilation time.

  • GNUmakefile.am:
  • GNUmakefile.list.am:

Source/WebKit/gtk:

Add a new settings option to enable smooth scrolling.

  • webkit/webkitwebsettings.cpp:

(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):

  • webkit/webkitwebsettingsprivate.h:
  • webkit/webkitwebview.cpp:

(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):

09:40 Changeset [109583] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Set the devicePixelRatio from the results of computeViewportAttributes
https://bugs.webkit.org/show_bug.cgi?id=80160

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-03-02
Reviewed by Antonio Gomes.

Tested by going to layout test fast/viewport/viewport-95.html and viewport-93.html
Previously when executing window.devicePixelRatio these two pages returned 1 now
they report the devicePixelRatio returned by computeViewportAttributes.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):

08:55 Changeset [109582] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r109581.

  • platform/gtk/security/block-test-expected.txt:
08:45 Changeset [109581] by philn@webkit.org
  • 4 edits
    1 add in trunk

[GTK] security/block-test.html baselines differ from mac
https://bugs.webkit.org/show_bug.cgi?id=78343

Reviewed by Martin Robinson.

Tools:

Improved the FrameLoader error heuristics to match mac behavior a
bit more.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(pathFromSoupURI): Handle ftp urls the same as http urls.
(descriptionSuitableForTestResult): Map WebKitPolicyError to WebKitErrorDomain.

LayoutTests:

GTK baselines updates for two security tests. They're closer to
the mac baselines now.

  • platform/gtk/security/block-test-expected.txt: Added.
  • platform/gtk/security/block-test-no-port-expected.txt:
08:40 WebKitGTK/1.8.x edited by philn@webkit.org
(diff)
08:38 Changeset [109580] by philn@webkit.org
  • 2 edits in trunk/Source/WebCore

[GStreamer] media/media-can-play-flac-audio.html fails
https://bugs.webkit.org/show_bug.cgi?id=80124

Reviewed by Martin Robinson.

Handle audio/x-flac in the mimeTypeCache() function so that we
advertize both audio/flac and audio/x-flac.

No new tests, this is covered already by media/media-can-play-flac-audio.html.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
08:37 WebKitGTK/1.8.x edited by carlosgc@webkit.org
(diff)
08:37 Changeset [109579] by carlosgc@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit2

Merging r109578

08:30 Changeset [109578] by carlosgc@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Invalid check in webkit_web_view_set_zoom_level() when zoom-text-only is enabled
https://bugs.webkit.org/show_bug.cgi?id=80150

Reviewed by Philippe Normand.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_set_zoom_level): Use
webkit_web_view_get_zoom_level() instead of
WKPageGetPageZoomFactor() to get the current effective zoom level
depending on zoom-text-only setting.

08:21 Changeset [109577] by podivilov@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: fix fronted compilation.
https://bugs.webkit.org/show_bug.cgi?id=80154

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.prototype.scriptForSourceID):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):

  • inspector/front-end/ScriptsSearchScope.js:

(WebInspector.ScriptsSearchResultsPane.prototype.createAnchor):

07:36 Changeset [109576] by abecsi@webkit.org
  • 2 edits in trunk/Tools

[Qt][WK2] Fix typo in patch committed in r109575

Unreviewed typo fix.

  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::notify): Cache the position
in floating point coordinates.

07:27 Changeset [109575] by abecsi@webkit.org
  • 5 edits in trunk/Tools

[Qt][WK2] Infinite loop on history navigation, when panning
https://bugs.webkit.org/show_bug.cgi?id=79119

Reviewed by Simon Hausmann.

Make the touch mocking more robust by creating touch events
directly and sending them synchronously to the browser window.
If the sent touch event was not accepted we propagate the
original mouse event to its target.
This way we make sure we only send either a touch or a mouse
event and do not end up in an infinite loop between our mocking
code and the Qt5 automatic mouse event synthesizing.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::updateVisualMockTouchPoints):

  • MiniBrowser/qt/BrowserWindow.h:

(BrowserWindow):

  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(touchRectForPosition):
(MiniBrowserApplication::notify):
(MiniBrowserApplication::sendTouchEvent):

  • MiniBrowser/qt/MiniBrowserApplication.h:

(MiniBrowserApplication):

07:14 Changeset [109574] by commit-queue@webkit.org
  • 14 edits in trunk

Rename DOMURL to URL in the bindings
https://bugs.webkit.org/show_bug.cgi?id=78214

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2012-03-02
Reviewed by Kentaro Hara.

Source/WebCore:

No new tests. Interface name change.

  • html/DOMURL.idl: Added InterfaceName attribute to DOMURL.

LayoutTests:

  • fast/files/domurl-script-execution-context-crash-expected.txt:
  • fast/files/domurl-script-execution-context-crash.html:
  • fast/js/constructor-length.html:
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/gtk/fast/js/constructor-length-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
  • platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/mac/fast/js/constructor-length-expected.txt:
  • platform/mac/fast/js/global-constructors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
06:26 Changeset [109573] by rolandsteiner@chromium.org
  • 5 edits
    2 adds in trunk

Add :scope pseudo-class
https://bugs.webkit.org/show_bug.cgi?id=79077

Source/WebCore:

Add :scope pseudo class name & pseudoId
Add selector check for the new pseudo-class

Reviewed by Antti Koivisto.

Test: fast/css/style-scoped/scope-pseudo.html

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):

  • css/CSSSelector.h:
  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOneSelector):

LayoutTests:

Test new :scope pseudo-class

Reviewed by Antti Koivisto.

  • fast/css/style-scoped/scope-pseudo-expected.txt: Added.
  • fast/css/style-scoped/scope-pseudo.html: Added.
06:25 Changeset [109572] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebKit/qt

[Qt] Documentation cleanup
https://bugs.webkit.org/show_bug.cgi?id=80131

Patch by Casper van Donderen <casper.vandonderen@nokia.com> on 2012-03-02
Reviewed by Simon Hausmann.

QDoc uses different commands to do bold, lists, and italics.
This change updates the documentation accordingly.
QTBUG-24578

  • Api/qwebframe.cpp:
  • Api/qwebhistory.cpp:
  • Api/qwebinspector.cpp:
  • Api/qwebpage.cpp:
  • Api/qwebpluginfactory.cpp:
  • Api/qwebsettings.cpp:
  • declarative/qdeclarativewebview.cpp:
  • docs/qtwebkit-bridge.qdoc:
  • docs/qtwebkit.qdoc:
  • docs/qtwebkit.qdocconf:
06:16 Changeset [109571] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip new failing tests.

  • platform/qt/Skipped:
06:07 Changeset [109570] by caio.oliveira@openbossa.org
  • 18 edits in trunk/Source

Make parser code not depend on NamedNodeMap
https://bugs.webkit.org/show_bug.cgi?id=79963

Reviewed by Adam Barth.

Source/WebCore:

Instead of creating Element-less NamedNodeMaps, the parsing code now creates
AttributeVectors, that are used to fill Element via the parserSetAttributes()
method. This allows us to remove even more methods from the NamedNodeMap.

The AttributeVector class contains convenience methods that take the attribute's
QualifiedName as parameter. This class is also used inside ElementAttributeData.

  • dom/Attr.h:

(Attr):

  • dom/Element.cpp:

(WebCore::Element::getAttribute):
(WebCore::Element::parserSetAttributes): Now we have to create the attribute
storage, and fill it (by Vector::swap()) with the passed attributes. Also use an
early return to reduce indentation.
(WebCore::Element::insertedIntoDocument):
(WebCore::Element::removedFromDocument):
(WebCore::Element::getURLAttribute):
(WebCore::Element::getNonEmptyURLAttribute):

  • dom/Element.h:

(Element):
(WebCore::Element::fastHasAttribute):
(WebCore::Element::fastGetAttribute):
(WebCore::Element::hasAttributesWithoutUpdate):
(WebCore::Element::attributeItem):
(WebCore::Element::getAttributeItem):

  • dom/ElementAttributeData.cpp:

(WebCore::AttributeVector::removeAttribute):
(WebCore):

  • dom/ElementAttributeData.h:

(AttributeVector):
(WebCore::AttributeVector::create):
(WebCore::AttributeVector::attributeItem):
(WebCore::AttributeVector::AttributeVector):
(WebCore):
(WebCore::AttributeVector::getAttributeItem):
(WebCore::AttributeVector::getAttributeItemIndex):
(WebCore::AttributeVector::insertAttribute): Boolean parameter isn't necessary
since all the callers used 'false', indicating that duplicates were not allowed.
(WebCore::ElementAttributeData::attributeItem):
(WebCore::ElementAttributeData::getAttributeItem):
(WebCore::ElementAttributeData::getAttributeItemIndex):
(ElementAttributeData):

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::getNamedItem):
(WebCore::NamedNodeMap::setNamedItem):
(WebCore::NamedNodeMap::removeNamedItem):
(WebCore::NamedNodeMap::mapsEquivalent):

  • dom/NamedNodeMap.h:
  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):
(WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement):
(WebCore::HTMLConstructionSite::insertScriptElement):
(WebCore::HTMLConstructionSite::createElement):
(WebCore::HTMLConstructionSite::createHTMLElement):
(WebCore):

  • html/parser/HTMLToken.h:

(WebCore::AtomicHTMLToken::AtomicHTMLToken):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processFakeStartTag):
(WebCore::HTMLTreeBuilder::attributesForIsindexInput):
(WebCore):

  • html/parser/HTMLTreeBuilder.h:
  • html/parser/TextDocumentParser.cpp:

(WebCore::TextDocumentParser::insertFakePreElement):

  • xml/parser/MarkupTokenBase.h:

(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):
(WebCore::AtomicMarkupTokenBase::attributes):
(WebCore::AtomicMarkupTokenBase::takeAttributes):
(AtomicMarkupTokenBase):
(WebCore::::initializeAttributes):

  • xml/parser/XMLToken.h:

(WebCore::AtomicXMLToken::AtomicXMLToken):

  • xml/parser/XMLTreeBuilder.cpp:

(WebCore::XMLTreeBuilder::processNamespaces):
(WebCore::XMLTreeBuilder::processAttributes):

Source/WebKit/chromium:

  • src/WebNamedNodeMap.cpp:

(WebKit::WebNamedNodeMap::attributeItem):

05:53 Changeset [109569] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Use 'all' as default target when debug_and_release is in effect

When debug_and_release is enabled, in combination with build_all,
qmake will generate an aggregate makefile that calls make on both
the debug and the release makefiles, but with the 'all' target.

In this case we can't use 'first' as the default target, as the
extra targets would then not be run, so we append extra targets
to 'all' instead.

Reviewed by Simon Hausmann.

05:48 Changeset [109568] by yurys@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: assertion failure in JSMainThreadExecState::instrumentedCall
https://bugs.webkit.org/show_bug.cgi?id=80152

Extracted common code of JS call instrumentation into instrumentFunctionCall method
and call it directly where the instrumentation is needed instead of calling
JSMainThreadExecState::instrumentedCall which works on the main thread only.

Reviewed by Pavel Feldman.

  • bindings/js/JSCallbackData.cpp:

(WebCore::JSCallbackData::invokeCallback):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

  • bindings/js/JSMainThreadExecState.h:

(WebCore::JSMainThreadExecState::instrumentFunctionCall):

05:46 Changeset [109567] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Make sure activeBuildConfig() returns the right config

Using isActiveConfig fails, as that only checks if the given
argument is in CONFIG, not the order.

Reviewed by Simon Hausmann.

05:35 Changeset [109566] by ossy@webkit.org
  • 6 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, update expected files.

  • platform/qt/Skipped: Unskip non-existent files.
  • platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.png:
  • platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.txt:
  • platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.png:
  • platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
05:31 Changeset [109565] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Forms] Make order of attribute/method in HTMLTextAreaElement.idl as same as specification
https://bugs.webkit.org/show_bug.cgi?id=80101

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-02
Reviewed by Kent Tamura.

No new tests. No behavior changes.

  • html/HTMLTextAreaElement.idl: Reorder attribute/method position.
05:30 Changeset [109564] by paroga@webkit.org
  • 3 edits in trunk/Source/WebCore

Build fix after r109538.

  • CMakeLists.txt:
  • Modules/websockets/WebSocketDeflater.cpp:
05:27 Changeset [109563] by rolandsteiner@chromium.org
  • 10 edits
    2 adds in trunk

Scoped stylesheets don't appear to work in Shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=79549

Source/WebCore:

Make the scope stack in CSSStyleSelector use ContainerNode* instead of Element*.
Adapt using sites accordingly.
Push the ShadowRoot to the scope stack in the same way that elements are pushed.
Fix an issue with removedFromDocument() on destruction.

Reviewed by Antti Koivisto.

Test: fast/css/style-scoped/style-scoped-in-shadow.html

  • css/CSSStyleSelector.cpp:

(RuleSet):
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::determineScope):
(WebCore::CSSStyleSelector::ruleSetForScope):
(WebCore::CSSStyleSelector::appendAuthorStylesheets):
(WebCore::CSSStyleSelector::setupScopeStack):
(WebCore::CSSStyleSelector::pushScope):
(WebCore):
(WebCore::CSSStyleSelector::popScope):
(WebCore::CSSStyleSelector::pushParentElement):
(WebCore::CSSStyleSelector::popParentElement):
(WebCore::CSSStyleSelector::pushParentShadowRoot):
(WebCore::CSSStyleSelector::popParentShadowRoot):
(WebCore::CSSStyleSelector::matchScopedAuthorRules):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • css/CSSStyleSelector.h:

(CSSStyleSelector):
(WebCore::CSSStyleSelector::pushScope):
(WebCore::CSSStyleSelector::popScope):
(WebCore::CSSStyleSelector::MatchOptions::MatchOptions):
(MatchOptions):
(WebCore::CSSStyleSelector::scopeStackIsConsistent):
(WebCore::CSSStyleSelector::ScopeStackFrame::ScopeStackFrame):
(ScopeStackFrame):

  • css/SelectorChecker.h:

(SelectorCheckingContext):

  • dom/Element.cpp:

(WebCore::StyleSelectorParentPusher::push):
(WebCore::StyleSelectorParentPusher::~StyleSelectorParentPusher):
(WebCore::Element::beginParsingChildren):
(WebCore::Element::finishParsingChildren):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::attach):
(WebCore):

  • dom/ShadowRoot.h:

(ShadowRoot):

  • dom/ShadowTree.cpp:

(WebCore::ShadowTree::recalcShadowTreeStyle):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::removedFromDocument):

LayoutTests:

Test that <style scoped> works in shadow DOM as direct child of the ShadowRoot

Reviewed by Antti Koivisto.

  • fast/css/style-scoped/style-scoped-in-shadow-expected.txt: Added.
  • fast/css/style-scoped/style-scoped-in-shadow.html: Added.
05:24 Changeset [109562] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Forms] Make order of attribute/method in HTMLSelectElement.idl as same as specification
https://bugs.webkit.org/show_bug.cgi?id=80097

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-02
Reviewed by Kent Tamura.

No new tests. No behavior changes.

  • html/HTMLSelectElement.idl: Reorder attribute/method position.
05:22 Changeset [109561] by podivilov@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: limit RawSourceCode usages to DebuggerPresentationModel.
https://bugs.webkit.org/show_bug.cgi?id=80146

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.uiLocationToRawLocation):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyRawLocation):

  • inspector/front-end/ObjectPopoverHelper.js:

(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover.showObjectPopover.):
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):

  • inspector/front-end/ScriptsSearchScope.js:

(WebInspector.ScriptsSearchResultsPane.prototype.createAnchor):

05:15 Changeset [109560] by podivilov@chromium.org
  • 3 edits in trunk

Web Inspector: update execution line using LiveLocation.
https://bugs.webkit.org/show_bug.cgi?id=80143

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype._uiSourceCodeListChanged):
(WebInspector.DebuggerPresentationModel.prototype._debuggerResumed):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame.updateExecutionLine):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):

05:06 WebKitGTK/1.8.x edited by carlosgc@webkit.org
(diff)
04:59 Changeset [109559] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Build fix for LocalizedStringsBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=80099

Unreviewed build fix.

  • platform/blackberry/LocalizedStringsBlackBerry.cpp:
04:58 Changeset [109558] by haraken@chromium.org
  • 4 edits in trunk/Source

Fix build on AppleWebKit after 109548.

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-02

Source/WebCore:

  • WebCore.exp.in:

Source/WebKit2:

  • mac/WebKit2.order:
04:47 Changeset [109557] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Forms] Make order of attribute/method in HTMLOptionElement.idl as same as specification
https://bugs.webkit.org/show_bug.cgi?id=80095

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-02
Reviewed by Kentaro Hara.

No new tests. No behavior changes.

  • html/HTMLOptionElement.idl: Reorder attribute/method position.
04:45 Changeset [109556] by abarth@webkit.org
  • 12 edits
    3 adds in trunk/Source/WebCore

WorkerContext shouldn't know about IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=80094

Reviewed by Kentaro Hara.

There are still a couple IndexedDB stragglers we should clean up in
WebCore proper. This patch moves some IndexedDB logic from
WorkerContext into the indexeddb module.

In the process of writing this patch, I noticed that some IndexedDB
files were missing from various build systems, so I added them. I
suspect that means IndexedDB is only enabled by default on Chromium.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Modules/indexeddb/WorkerContextIndexedDatabase.cpp: Added.

(WebCore):
(WebCore::WorkerContextIndexedDatabase::WorkerContextIndexedDatabase):
(WebCore::WorkerContextIndexedDatabase::~WorkerContextIndexedDatabase):
(WebCore::WorkerContextIndexedDatabase::from):
(WebCore::WorkerContextIndexedDatabase::webkitIndexedDB):

  • Modules/indexeddb/WorkerContextIndexedDatabase.h: Added.

(WebCore):
(WorkerContextIndexedDatabase):

  • Modules/indexeddb/WorkerContextIndexedDatabase.idl: Added.
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • workers/WorkerContext.cpp:

(WebCore):

  • workers/WorkerContext.h:

(WebCore):
(WorkerContext):

  • workers/WorkerContext.idl:
04:45 Changeset [109555] by hausmann@webkit.org
  • 5 edits in trunk

[Qt] Fix tests run with WTR not using QStyle theme
https://bugs.webkit.org/show_bug.cgi?id=80147

Reviewed by Csaba Osztrogonác.

Source/WebKit2:

Use an environment variable (set by WTR) to select the QStyle theme.
This is a temporary kludge until we rebase the layout tests to use the
QStyle independent "mobile" theme. This also temporarily breaks the
force_static_libs_as_shared build.

  • Target.pri:
  • WebProcess/qt/WebProcessMainQt.cpp:

(WebKit::WebProcessMainQt):

Tools:

  • WebKitTestRunner/qt/main.cpp:

(main): Set environment variable for web process to use QStyle theme.

04:29 Changeset [109554] by philn@webkit.org
  • 4 edits
    1 delete in trunk

Tools: Unreviewed, remove debug print call.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(descriptionSuitableForTestResult):

LayoutTests: Unreviewed, unskip security/block-test.html and remove its GTK
baseline, the platform-agnostic baseline match.

  • platform/gtk/Skipped:
  • platform/gtk/security/block-test-expected.txt: Removed.
04:23 Changeset [109553] by ossy@webkit.org
  • 4 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, update expected files.

  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
04:16 Changeset [109552] by hausmann@webkit.org
  • 8 edits in trunk

[Qt] Compile WebCore without QtWidgets
https://bugs.webkit.org/show_bug.cgi?id=80141

Reviewed by Tor Arne Vestbø.

.:

  • Source/api.pri: Use QT += opengl for the WebKit1 bits, such as the QGLWidget

usage in PageClientQt.cpp. Previously this dependency came implicitly through WebCore.pri.

Source/WebCore:

  • Target.pri: Don't add widgets to QT.
  • WebCore.pri: Use QT += opengl only with Qt 4, because it has an implicit QtWidgets

dependency. With Qt 5 all necessary OpenGL API is part of QtGui (with a QOpenGL* prefix).

Source/WebKit2:

  • Shared/qt/WebEventFactoryQt.cpp: Removed unnecessary include.
  • Target.pri: Require widgets for WK2 for the moment, until bug #79458

is fixed.

03:57 Changeset [109551] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Forms] Make order of attribute/method in HTMLFormElement.idl as same as specification
https://bugs.webkit.org/show_bug.cgi?id=80093

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-02
Reviewed by Kentaro Hara.

No new tests. No behavior changes

  • html/HTMLFormElement.idl: Reorder attribute/method position.
03:54 Changeset [109550] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Forms] Make order of attribute/method in HTMLButtonElement.idl as same as specification
https://bugs.webkit.org/show_bug.cgi?id=80091

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-02
Reviewed by Kentaro Hara.

No new tests. No behavior changes.

  • html/HTMLButtonElement.idl: Reorder attribute/method position.
03:43 Changeset [109549] by hausmann@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Build system cleanup

Rubber-stamped by Antti Koivisto.

  • tests/MIMESniffing/MIMESniffing.pro: Don't link in WTFAssertions.cpp for ASSERT, now

that the symbols are properly exported with export macros from the DLL.

03:40 Changeset [109548] by zoltan@webkit.org
  • 15 edits in trunk/Source

Suspend/Resume API for pausing timers and animations.
https://bugs.webkit.org/show_bug.cgi?id=76063

Source/WebCore:

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-02
Reviewed by Kenneth Rohde Christiansen.

  • dom/ActiveDOMObject.h:

New ReasonForSuspension: PageWillBePaused.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::suspend): Handle new ReasonForSuspension.

  • page/Frame.cpp:

(WebCore::Frame::Frame):
(WebCore::Frame::setDocument):
(WebCore::Frame::suspendActiveDOMObjectsAndAnimations):
(WebCore::Frame::resumeActiveDOMObjectsAndAnimations):

  • page/Frame.h:

(WebCore::Frame::activeDOMObjectsAndAnimationsSuspended):

Frame now maintains a state of suspending animation and ActiveDOMObjects,
which is inherited to all child-frames.

  • page/Page.cpp:

(WebCore::Page::suspendActiveDOMObjectsAndAnimations):
(WebCore::Page::resumeActiveDOMObjectsAndAnimations):

  • page/Page.h:

Functions for suspending and resuming active DOM objects and animations in all frames.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::willRenderImage):

WillRenderImage now checks for suspension. This causes animated images to pause
together with all other types of animations.

Source/WebKit2:

Based on the initial work of Zalan Bujtas <zalan.bujtas@nokia.com>,

Adds suspend and resume API for WebKit2 and uses it in Qt to
suspend animations and DOM timers during panning and zoom.

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-02
Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewFlickablePrivate::_q_suspend):
(QQuickWebViewFlickablePrivate::_q_resume):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::resumeActiveDOMObjectsAndAnimations):
(WebKit::WebPageProxy::suspendActiveDOMObjectsAndAnimations):
(WebKit::WebPageProxy::processDidCrash):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::suspendActiveDOMObjectsAndAnimations):
(WebKit::WebPage::resumeActiveDOMObjectsAndAnimations):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
03:33 Changeset [109547] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Forms] Make order of attribute/method in HTMLFieldSetElement.idl as same as specification
https://bugs.webkit.org/show_bug.cgi?id=80092

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-02
Reviewed by Kentaro Hara.

No new tests. No behavior changes.

  • html/HTMLFieldSetElement.idl: Reorder attribute/method position.
03:28 Changeset [109546] by antti@apple.com
  • 3 edits in trunk/Source/WebCore

possible regression: r104060 maybe causing crashes
https://bugs.webkit.org/show_bug.cgi?id=75676

Rubber-stamped by Simon Hausmann.

Remove the speculative fix (the problem was elsewhere, http://trac.webkit.org/changeset/104845).

Also remove the debugging code added for this bug.

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::clearStyleSelector):
(WebCore::Document::updateActiveStylesheets):

  • dom/Document.h:

(Document):

03:16 Changeset [109545] by apavlov@chromium.org
  • 11 edits in trunk

Web Inspector: Implement suggestions in Watch Expressions
https://bugs.webkit.org/show_bug.cgi?id=79912

Source/WebCore:

Drive-by: make subproperties in ObjectPropertySections editable

Reviewed by Pavel Feldman.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView):
(WebInspector.ConsoleView.prototype.completionsForTextPrompt):

  • inspector/front-end/DatabaseQueryView.js:
  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.prototype.onpopulate.callback):
(WebInspector.ObjectPropertyTreeElement.prototype.onpopulate):
(WebInspector.ObjectPropertyTreeElement.prototype.ondblclick):
(WebInspector.ObjectPropertyTreeElement.prototype.renderPromptAsBlock):
(WebInspector.ObjectPropertyTreeElement.prototype.elementAndValueToEdit):
(WebInspector.ObjectPropertyTreeElement.prototype.startEditing.blurListener):
(WebInspector.ObjectPropertyTreeElement.prototype.startEditing):
(WebInspector.ObjectPropertyTreeElement.prototype.editingEnded):
(WebInspector.ObjectPropertyTreeElement.prototype.editingCancelled):
(WebInspector.ObjectPropertyTreeElement.prototype.editingCommitted):
(WebInspector.ObjectPropertyTreeElement.prototype._promptKeyDown):
(WebInspector.ObjectPropertyPrompt):

  • inspector/front-end/StylesSidebarPane.js:
  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.complete):

  • inspector/front-end/WatchExpressionsSidebarPane.js:

(WebInspector.WatchExpressionTreeElement.prototype.renderPromptAsBlock):
(WebInspector.WatchExpressionTreeElement.prototype.elementAndValueToEdit):
(WebInspector.WatchExpressionTreeElement.prototype.editingCancelled):

  • inspector/front-end/inspector.css:

(.watch-expressions > li.editing-sub-part .text-prompt):

LayoutTests:

Reviewed by Pavel Feldman.

  • http/tests/inspector/console-cd-completions.html:
  • inspector/debugger/debugger-completions-on-call-frame.html:
02:55 Changeset [109544] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] Build warning : comparison between signed and unsigned integer expressions.
https://bugs.webkit.org/show_bug.cgi?id=79860

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-03-02
Reviewed by Hajime Morita.

Fixed build warnings which are getting generated when comparing signed
and unsigned integer expressions.

  • Source/WebCore/bindings/js/JSDocumentCustom.cpp:
  • Source/WebCore/platform/ContextMenu.cpp:
  • Source/WebKit/efl/ewk/ewk_view_single.cpp:
02:46 Changeset [109543] by antti@apple.com
  • 3 edits
    3 adds in trunk

REGRESSION (r104060): Page contents not painted if inserting a new stylesheet and temporary body node
https://bugs.webkit.org/show_bug.cgi?id=76590

Reviewed by Maciej Stachowiak.

Source/WebCore:

Test: fast/css/pending-stylesheet-repaint.html

If there has been a style recalc with a pending stylesheet, the forced repaint will need to be triggered even
if the stylesheet doesn't affect the rendering. Otherwise we may end up never painting at all.

  • dom/Document.cpp:

(WebCore::Document::styleSelectorChanged):

LayoutTests:

  • fast/css/pending-stylesheet-repaint-expected.png: Added.
  • fast/css/pending-stylesheet-repaint-expected.txt: Added.
  • fast/css/pending-stylesheet-repaint.html: Added.
02:43 Changeset [109542] by hausmann@webkit.org
  • 11 edits
    1 copy
    3 moves in trunk

[Qt] Move QStyle theming code out of WebCore into WebKit1
https://bugs.webkit.org/show_bug.cgi?id=80128

Reviewed by Kenneth Rohde Christiansen.

.:

  • Source/api.pri: Adjust to moving source files.

Source/WebCore:

Moved QStyle dependant code into WebKit1, where it's okay to depend on
QtWidgets/QStyle. Added factory hooks into RenderThemeQt to allow changing
the default "mobile" style to QStyle on start-up.

  • Target.pri:
  • platform/qt/RenderThemeQt.cpp:

(WebCore):
(WebCore::RenderThemeQt::setCustomTheme):
(WebCore::RenderThemeQt::customScrollbarTheme):
(WebCore::createTheme):
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeQt::extraDefaultStyleSheet):

  • platform/qt/RenderThemeQt.h:

(WebCore):
(RenderThemeQt):

  • platform/qt/RenderThemeQtMobile.cpp:
  • platform/qt/ScrollbarThemeQt.cpp:

(WebCore::ScrollbarTheme::nativeTheme):

Source/WebKit/qt:

Moved the bulk of the QStyle dependant code here, where it's okay to depend on QtWidgets/QStyle.
Install the QStyle factory functions in initWebCoreQt.cpp.

  • Api/qwebpage.cpp:

(QWebPage::swallowContextMenuEvent):

  • WebCoreSupport/InitWebCoreQt.cpp:

(WebCore::initializeWebCoreQt):

  • WebCoreSupport/RenderThemeQStyle.cpp: Renamed from Source/WebCore/platform/qt/RenderThemeQStyle.cpp.

(WebCore):
(WebCore::initStyleOption):
(WebCore::RenderThemeQStyle::getStylePainter):
(WebCore::StylePainterQStyle::StylePainterQStyle):
(WebCore::StylePainterQStyle::init):
(WebCore::RenderThemeQStyle::create):
(WebCore::RenderThemeQStyle::RenderThemeQStyle):
(WebCore::RenderThemeQStyle::~RenderThemeQStyle):
(WebCore::RenderThemeQStyle::fallbackStyle):
(WebCore::RenderThemeQStyle::qStyle):
(WebCore::RenderThemeQStyle::findFrameLineWidth):
(WebCore::RenderThemeQStyle::inflateButtonRect):
(WebCore::RenderThemeQStyle::computeSizeBasedOnStyle):
(WebCore::RenderThemeQStyle::adjustButtonStyle):
(WebCore::RenderThemeQStyle::setButtonPadding):
(WebCore::RenderThemeQStyle::paintButton):
(WebCore::RenderThemeQStyle::paintTextField):
(WebCore::RenderThemeQStyle::adjustTextAreaStyle):
(WebCore::RenderThemeQStyle::paintTextArea):
(WebCore::RenderThemeQStyle::setPopupPadding):
(WebCore::RenderThemeQStyle::paintMenuList):
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
(WebCore::RenderThemeQStyle::paintMenuListButton):
(WebCore::RenderThemeQStyle::animationDurationForProgressBar):
(WebCore::RenderThemeQStyle::paintProgressBar):
(WebCore::RenderThemeQStyle::paintSliderTrack):
(WebCore::RenderThemeQStyle::adjustSliderTrackStyle):
(WebCore::RenderThemeQStyle::paintSliderThumb):
(WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
(WebCore::RenderThemeQStyle::paintSearchField):
(WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldDecoration):
(WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeQStyle::paintInnerSpinButton):
(WebCore::RenderThemeQStyle::initializeCommonQStyleOptions):
(WebCore::RenderThemeQStyle::adjustSliderThumbSize):

  • WebCoreSupport/RenderThemeQStyle.h: Renamed from Source/WebCore/platform/qt/RenderThemeQStyle.h.

(WebCore):
(RenderThemeQStyle):
(StylePainterQStyle):
(WebCore::StylePainterQStyle::isValid):
(WebCore::StylePainterQStyle::drawPrimitive):
(WebCore::StylePainterQStyle::drawControl):
(WebCore::StylePainterQStyle::drawComplexControl):

  • WebCoreSupport/ScrollbarThemeQStyle.cpp: Copied from Source/WebCore/platform/qt/ScrollbarThemeQt.cpp.

(WebCore):
(WebCore::ScrollbarThemeQStyle::~ScrollbarThemeQStyle):
(WebCore::scPart):
(WebCore::scrollbarPart):
(WebCore::styleOptionSlider):
(WebCore::ScrollbarThemeQStyle::paint):
(WebCore::ScrollbarThemeQStyle::hitTest):
(WebCore::ScrollbarThemeQStyle::shouldCenterOnThumb):
(WebCore::ScrollbarThemeQStyle::invalidatePart):
(WebCore::ScrollbarThemeQStyle::scrollbarThickness):
(WebCore::ScrollbarThemeQStyle::thumbPosition):
(WebCore::ScrollbarThemeQStyle::thumbLength):
(WebCore::ScrollbarThemeQStyle::trackPosition):
(WebCore::ScrollbarThemeQStyle::trackLength):
(WebCore::ScrollbarThemeQStyle::paintScrollCorner):
(WebCore::ScrollbarThemeQStyle::style):

  • WebCoreSupport/ScrollbarThemeQStyle.h: Renamed from Source/WebCore/platform/qt/ScrollbarThemeQt.h.

(WebCore):
(ScrollbarThemeQStyle):

02:40 Changeset [109541] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Handle CSSPropertyWebkitColumnRuleStyle in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=80085

Reviewed by Eric Seidel.

No new tests / refactoring only.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

02:39 Changeset [109540] by yurys@chromium.org
  • 16 edits in trunk/Source/WebCore

Web Inspector: enable Timeline panel for workers
https://bugs.webkit.org/show_bug.cgi?id=80130

Enabled Timeline panel for worker inspector. Refactored
JS function calls instrumentation to work for both
worker contexts and documents.

Reviewed by Pavel Feldman.

  • bindings/js/JSCallbackData.cpp:

(WebCore::JSCallbackData::invokeCallback):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

  • bindings/js/JSMainThreadExecState.h:

(WebCore):
(WebCore::JSMainThreadExecState::instrumentedCall):

  • bindings/js/ScriptState.cpp:

(WebCore::scriptExecutionContextFromScriptState):
(WebCore):

  • bindings/js/ScriptState.h:

(WebCore):

  • bindings/v8/ScriptState.cpp:

(WebCore::ScriptState::scriptExecutionContext):
(WebCore):
(WebCore::scriptExecutionContextFromScriptState):

  • bindings/v8/ScriptState.h:

(WebCore):
(ScriptState):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::instrumentedCallFunction):

  • bindings/v8/V8WorkerContextEventListener.cpp:

(WebCore::V8WorkerContextEventListener::callListenerFunction):

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::callFunctionWithEvalEnabled):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::instrumentingAgentsForNonDocumentContext):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willCallFunction):
(WebCore):
(WebCore::InspectorInstrumentation::instrumentingAgentsForContext):

  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):
(WebCore::WorkerInspectorController::connectFrontend):
(WebCore::WorkerInspectorController::disconnectFrontend):
(WebCore::WorkerInspectorController::restoreInspectorStateFromCookie):

  • inspector/WorkerInspectorController.h:

(WebCore):
(WorkerInspectorController):

  • inspector/front-end/inspector.js:

(WebInspector._createPanels):

02:37 Changeset [109539] by philn@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed, GTK tests expectations update.

  • platform/gtk/Skipped:
  • platform/gtk/test_expectations.txt:
02:24 Changeset [109538] by bashi@chromium.org
  • 18 edits
    1 copy
    12 adds in trunk

Adding WebSocket per-frame DEFLATE extension
https://bugs.webkit.org/show_bug.cgi?id=77522

Source/JavaScriptCore:

Added USE(ZLIB) flag.

Reviewed by Kent Tamura.

  • wtf/Platform.h:

Source/WebCore:

Add WebSocketDeflateFramer class which handles deflate-frame extension.
This class encapsulates WebSocketDeflater and WebSocketInflater classes,
which depend on zlib, so that WebSocketChannel is not necessary to aware
zlib dependency.

Reviewed by Kent Tamura.

Tests: http/tests/websocket/tests/hybi/compressed-control-frame.html

http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff.html
http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter.html
http/tests/websocket/tests/hybi/deflate-frame-parameter.html

  • CMakeLists.txt: Added WebSocketDeflateFramer.(cpp|h)
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.gyp/WebCore.gyp: Added zlib dependency.
  • WebCore.vcproj/WebCore.vcproj: Added WebSocketDeflateFramer.(cpp|h)
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • websockets/WebSocket.cpp:

(WebCore::WebSocket::didConnect): Set m_extensions.

  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::connect): Add deflate-frame extension processor to WebSocketHanshake if deflate can use.
(WebCore::WebSocketChannel::fail): Call m_deflateFramer.didFail().
(WebCore::WebSocketChannel::processFrame): Decompress frames if needed.
(WebCore::WebSocketChannel::sendFrame): Compress frames if possible.

  • websockets/WebSocketChannel.h:
  • websockets/WebSocketDeflateFramer.cpp: Added.

(WebCore):
(WebSocketExtensionDeflateFrame):
(WebCore::WebSocketExtensionDeflateFrame::create):
(WebCore::WebSocketExtensionDeflateFrame::~WebSocketExtensionDeflateFrame):
(WebCore::WebSocketExtensionDeflateFrame::WebSocketExtensionDeflateFrame):
(WebCore::WebSocketExtensionDeflateFrame::handshakeString):
(WebCore::WebSocketExtensionDeflateFrame::processResponse):
(WebCore::DeflateResultHolder::DeflateResultHolder):
(WebCore::DeflateResultHolder::~DeflateResultHolder):
(WebCore::DeflateResultHolder::fail):
(WebCore::InflateResultHolder::InflateResultHolder):
(WebCore::InflateResultHolder::~InflateResultHolder):
(WebCore::InflateResultHolder::fail):
(WebCore::WebSocketDeflateFramer::WebSocketDeflateFramer):
(WebCore::WebSocketDeflateFramer::createExtensionProcessor):
(WebCore::WebSocketDeflateFramer::canDeflate):
(WebCore::WebSocketDeflateFramer::enableDeflate):
(WebCore::WebSocketDeflateFramer::deflate):
(WebCore::WebSocketDeflateFramer::resetDeflateContext):
(WebCore::WebSocketDeflateFramer::inflate):
(WebCore::WebSocketDeflateFramer::resetInflateContext):
(WebCore::WebSocketDeflateFramer::didFail):

  • websockets/WebSocketDeflateFramer.h: Added.

(WebCore):
(DeflateResultHolder):
(WebCore::DeflateResultHolder::succeeded):
(WebCore::DeflateResultHolder::failureReason):
(InflateResultHolder):
(WebCore::InflateResultHolder::succeeded):
(WebCore::InflateResultHolder::failureReason):
(WebSocketDeflateFramer):
(WebCore::WebSocketDeflateFramer::enabled):

LayoutTests:

Added tests for WebSocket deflate-frame extension. Also updated some
tests to follow the change.

Reviewed by Kent Tamura.

  • http/tests/websocket/tests/hybi/compressed-control-frame-expected.txt: Added.
  • http/tests/websocket/tests/hybi/compressed-control-frame.html: Added.
  • http/tests/websocket/tests/hybi/compressed-control-frame_wsh.py: Added.

(web_socket_do_extra_handshake):
(web_socket_transfer_data):

  • http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff-expected.txt: Added.
  • http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff.html: Added.
  • http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter-expected.txt: Added.
  • http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter.html: Added.
  • http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter_wsh.py: Added.

(web_socket_do_extra_handshake):
(web_socket_transfer_data):

  • http/tests/websocket/tests/hybi/deflate-frame-parameter-expected.txt: Added.
  • http/tests/websocket/tests/hybi/deflate-frame-parameter.html: Added.
  • http/tests/websocket/tests/hybi/deflate-frame_wsh.py: Added.

(_get_deflate_frame_extension_processor):
(web_socket_do_extra_handshake):
(web_socket_transfer_data):

  • http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header-expected.txt:
  • http/tests/websocket/tests/hybi/send-file-blob_wsh.py:

(_retrieve_frame):
(web_socket_transfer_data):

  • platform/efl/Skipped: Skips tests rely on zlib
  • platform/qt/Skipped: Ditto.
02:21 Changeset [109537] by haraken@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
01:59 Changeset [109536] by vsevik@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: [InspectorIndexedDB] Show meaningful description for object store items values.
https://bugs.webkit.org/show_bug.cgi?id=79691

Reviewed by Pavel Feldman.

  • inspector/front-end/IndexedDBModel.js:

(WebInspector.IndexedDBModel.idbKeyFromKey):

  • inspector/front-end/IndexedDBViews.js:

(WebInspector.IDBDataView.prototype._updateData.callback):
(WebInspector.IDBDataView.prototype._updateData):
(WebInspector.IDBDataGridNode.prototype.createCell):
(WebInspector.IDBDataGridNode.prototype._formatValue):

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.prototype.onpopulate.callback):
(WebInspector.ObjectPropertyTreeElement.prototype.onpopulate):

  • inspector/front-end/RemoteObject.js:

(WebInspector.LocalJSONObject.prototype.get subtype):

  • inspector/front-end/indexedDBViews.css:

(.indexed-db-data-view .data-grid .data-container td):
(.indexed-db-data-view .data-grid .data-container td.primaryKey-column):
(.indexed-db-data-view .data-grid .data-container td.primaryKey-column div.primitive-value):
(.indexed-db-data-view .data-grid .data-container td .section .header .title):

01:57 Changeset [109535] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, mark
fast/frames/flattening/frameset-flattening-advanced.html as flaky in GTK.

  • platform/gtk/test_expectations.txt:
01:50 Changeset [109534] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Updated EventSender to send complete gesture events.
https://bugs.webkit.org/show_bug.cgi?id=80075

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-02
Reviewed by Adam Barth.

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::gestureEvent): set additional parameters in sent events.

01:35 Changeset [109533] by joone.hur@collabora.co.uk
  • 2 edits in trunk/Source/WebKit2

Unreviewed. Fix WebKit2 GTK+ build.

  • GNUmakefile.am: allow WebKitWebProcess to link with zlib properly.
01:32 Changeset [109532] by commit-queue@webkit.org
  • 7 edits in trunk

[Chromium] Layout Test webaudio/audiobuffersource-channels.html is failing
https://bugs.webkit.org/show_bug.cgi?id=79765

Patch by Wei James <james.wei@intel.com> on 2012-03-02
Reviewed by Chris Rogers.

Source/WebCore:

  • webaudio/AudioBuffer.cpp:

(WebCore::AudioBuffer::create):

  • webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::setBuffer):

  • webaudio/AudioContext.h:

(WebCore):
(AudioContext):
(WebCore::AudioContext::maxNumberOfChannels):

  • webaudio/AudioNodeOutput.cpp:

(WebCore::AudioNodeOutput::AudioNodeOutput):
(WebCore::AudioNodeOutput::setNumberOfChannels):

LayoutTests:

  • platform/chromium/test_expectations.txt:
01:30 Changeset [109531] by haraken@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, gardening.

  • platform/chromium/test_expectations.txt:
01:22 Changeset [109530] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Handle CSSPropertyWebkitRegionBreakAfter, CSSPropertyWebkitRegionBreakBefore and CSSPropertyWebkitRegionBreakInside in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=80066

Reviewed by Eric Seidel.

No new tests / refactoring only.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

01:20 Changeset [109529] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

Implement DefaultParagraphSeparator execCommand, to let authors choose the default block element
https://bugs.webkit.org/show_bug.cgi?id=59961

Patch by Pablo Flouret <pablof@motorola.com> on 2012-03-02
Reviewed by Ryosuke Niwa.

Source/WebCore:

http://dvcs.w3.org/hg/editing/raw-file/tip/editing.html#the-defaultparagraphseparator-command

Test: editing/execCommand/default-paragraph-separator.html

  • editing/Editor.cpp:

(WebCore::Editor::Editor):

  • editing/Editor.h:

(WebCore::Editor::defaultParagraphSeparator):
(WebCore::Editor::setDefaultParagraphSeparator):
(Editor):

  • editing/EditorCommand.cpp:

(WebCore::executeDefaultParagraphSeparator):
(WebCore):
(WebCore::valueDefaultParagraphSeparator):
(WebCore::createCommandMap):

  • editing/htmlediting.cpp:

(WebCore::createDefaultParagraphElement):

  • html/HTMLParagraphElement.cpp:

(WebCore::HTMLParagraphElement::create):
(WebCore):

  • html/HTMLParagraphElement.h:

(HTMLParagraphElement):

Added create(Document*) method that defaults to pTag as the QualifiedName.

LayoutTests:

  • editing/execCommand/default-paragraph-separator-expected.txt: Added.
  • editing/execCommand/default-paragraph-separator.html: Added.
01:12 Changeset [109528] by kbr@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] Fix errors in LayerRendererChromium cleanup
https://bugs.webkit.org/show_bug.cgi?id=80064

Reviewed by James Robinson.

Tested manually by forcing lost context while rendering Flash on
Mac OS in a Debug build.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::cleanupSharedObjects):

01:05 Changeset [109527] by aestes@apple.com
  • 3 edits in trunk/Source/WebCore

Fix errors found when building the Mac port with ICONDATABASE disabled.
https://bugs.webkit.org/show_bug.cgi?id=80059

Reviewed by Brady Eidson.

  • WebCore.exp.in: Only export IconDatabase symbols when the feature is

enabled.

  • loader/icon/IconDatabase.h:

(WebCore::IconDatabase::create): WebKit calls this static method, so it
should be defined on the stub class.
(WebCore::IconDatabase::allowDatabaseCleanup): Ditto.
(WebCore::IconDatabase::checkIntegrityBeforeOpening): Ditto.

00:55 Changeset [109526] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

Fix a warning in InputHandler::learnText()
https://bugs.webkit.org/show_bug.cgi?id=80049

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-03-02
Reviewed by Antonio Gomes.

Fix a warning of the comparison "textInField.length() <=
MaxLearnTextDataSize" in InputHandler::learnText().

Rubber-stamped internally by Mike Fenton.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::learnText):

00:50 Changeset [109525] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Handle CSSPropertyWebkitColorCorrection in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=80056

Reviewed by Eric Seidel.

No new tests / refactoring only.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

00:33 Changeset [109524] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Enabling 'Inspect Element' in Ewk_Context_Menu_Action.
https://bugs.webkit.org/show_bug.cgi?id=79646

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2012-03-02
Reviewed by Andreas Kling.

INSPECTOR feature is already enabled for WebKit-Efl port (OptionsEfl.cmake).
As a result WebCore's ContextMenuAction contains ContextMenuItemTagInspectElement
and enums order has been changed. WebKit-Efl has to synchronize ContextMenuAction
with Ewk_Context_Menu_Action.
To avoid similar case in the feature I added checks between WebCore and
WebKit-EFL's enums by using COMPILE_ASSERT_MATCHING_ENUM.

  • WebCoreSupport/AssertMatchingEnums.cpp:
  • ewk/ewk_contextmenu.h:
00:22 WebKitGTK/1.8.x edited by kalevlember@gmail.com
Added r109509 as proposed merge (diff)
00:15 Changeset [109523] by mikelawther@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

reflection computed style test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75902

Reviewed by Ojan Vafai.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

  • css3/calc/reflection-computed-style-expected.txt: Added.
  • css3/calc/reflection-computed-style.html: Added.
00:15 Changeset [109522] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix for platforms that have DFG_JIT disabled but PARALLEL_GC enabled.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitAggregate):

00:11 Changeset [109521] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[chromium] Send didCommitAndDrawFrame after swap
https://bugs.webkit.org/show_bug.cgi?id=80052

Patch by John Bauman <jbauman@chromium.org> on 2012-03-02
Reviewed by James Robinson.

Sending didCommitAndDrawFrame before the swap was causing plugins to
redraw themselves between compositing and the swap, which reduces
opportunities for optimization.

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::compositeAndReadback):
(WebCore::CCSingleThreadProxy::compositeImmediately):
(WebCore::CCSingleThreadProxy::doComposite):
(WebCore):
(WebCore::CCSingleThreadProxy::didSwapFrame):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(CCSingleThreadProxy):

00:06 Changeset [109520] by philn@webkit.org
  • 8 edits in trunk/LayoutTests

Unreviewed, GTK gardening.

  • platform/gtk/Skipped: Skip 2 new failing tests and unskip a new

media test that should pass on GTK.

  • platform/gtk/editing/inserting/5994480-2-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/gtk/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
  • platform/gtk/fast/multicol/span/clone-summary-expected.txt:
00:04 Changeset [109519] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

DFGCodeBlocks should not trace CodeBlocks that are also going to be traced by
virtue of being in the transitive closure
https://bugs.webkit.org/show_bug.cgi?id=80098

Reviewed by Anders Carlsson.

If DFGCodeBlocks traces a CodeBlock that might also be traced via its owner Executable,
then you might have the visitAggregate() method called concurrently by multiple threads.
This is benign on 64-bit -- visitAggregate() and everything it calls turns out to be
racy and slightly imprecise but not unsound. But on 32-bit, visitAggregate() may crash
due to word tearing in ValueProfile bucket updates inside of computeUpdatedPrediction().

It would seem that the fix is just to have DFGCodeBlocks not trace CodeBlocks that are
not jettisoned. But CodeBlocks may be jettisoned later during the GC, so it must trace
any CodeBlock that it knows to be live by virtue of it being reachable from the stack.
Hence the real fix is to make sure that concurrent calls into CodeBlock::visitAggregate()
don't lead to two threads racing over each other as they clobber state. This patch
achieves this with a simple CAS loop: whichever thread wins the CAS race (which is
trivially linearizable) will get to trace the CodeBlock; all other threads give up and
go home.

Unfortunately there will be no new tests. It's possible to reproduce this maybe 1/10
times by running V8-v6's raytrace repeatedly, using the V8 harness hacked to rerun it
even when it's gotten sufficient counts. But that takes a while - sometimes up to a
minute to get a crash. I have no other reliable repro case.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitAggregate):

  • bytecode/CodeBlock.h:

(DFGData):

  • heap/DFGCodeBlocks.cpp:

(JSC::DFGCodeBlocks::clearMarks):

00:01 Changeset [109518] by commit-queue@webkit.org
  • 7 edits
    8 adds in trunk

AudioParam needs tests for the parameter automation routines.
https://bugs.webkit.org/show_bug.cgi?id=77666

Patch by Raymond Toy <rtoy@google.com> on 2012-03-02
Reviewed by Chris Rogers.

Source/WebCore:

Tests: webaudio/audioparam-linearRampToValueAtTime.html

webaudio/audioparam-setTargetValueAtTime.html
webaudio/audioparam-setValueAtTime.html
webaudio/audioparam-setValueCurveAtTime.html

  • webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::valuesForTimeRangeImpl): Round the
curveIndex to fix timing issue in setValueCurveAtTime.

LayoutTests:

  • webaudio/audioparam-exponentialRampToValueAtTime.html:
  • webaudio/audioparam-linearRampToValueAtTime-expected.txt: Added.
  • webaudio/audioparam-linearRampToValueAtTime.html: Added.
  • webaudio/audioparam-setTargetValueAtTime-expected.txt: Added.
  • webaudio/audioparam-setTargetValueAtTime.html: Added.
  • webaudio/audioparam-setValueAtTime-expected.txt: Added.
  • webaudio/audioparam-setValueAtTime.html: Added.
  • webaudio/audioparam-setValueCurveAtTime-expected.txt: Added.
  • webaudio/audioparam-setValueCurveAtTime.html: Added.
  • webaudio/resources/audioparam-testing.js:

(renderLength):
(createConstantArray):
(createLinearRampArray):
(discreteTimeConstantForSampleRate):
(createExponentialApproachArray):
(createSineWaveArray):
(endValueDelta):
(valueUpdate):
(comparePartialSignals):
(verifyDiscontinuities):
(compareSignals):
(checkResultFunction.return.var):
(checkResultFunction):
(doAutomation):
(createAudioGraphAndTest):

  • webaudio/resources/audio-testing.js: Moved isValidNumber from

biquad-testing.js to here.

  • webaudio/resources/biquad-testing.js: Moved isValidNumber from

here to audio-testing.js.

Note: See TracTimeline for information about the timeline view.