Timeline


and

03/12/12:

23:42 Changeset [110541] by commit-queue@webkit.org

Switch Chromium from LocaleToScriptMappingICU.cpp to LocaleToScriptMappingDefault.cpp
https://bugs.webkit.org/show_bug.cgi?id=80935

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-03-12
Reviewed by Kent Tamura.

ICU seems to have issues with non-well-formed locale strings.
Currently, the only port that uses LocaleToScriptMappingICU.cpp is
Chromium.

No new tests. LocaleToScriptMappingDefault.cpp is already used by
other ports and covered by existing tests.

  • WebCore.gyp/WebCore.gyp:
23:15 Changeset [110540] by commit-queue@webkit.org

Fix test cases for RegExp multiline
https://bugs.webkit.org/show_bug.cgi?id=80822

Patch by Hojong Han <hojong.han@samsung.com> on 2012-03-12
Reviewed by Gavin Barraclough.

  • tests/mozilla/js1_2/regexp/RegExp_multiline.js:
  • tests/mozilla/js1_2/regexp/RegExp_multiline_as_array.js:
  • tests/mozilla/js1_2/regexp/beginLine.js:
  • tests/mozilla/js1_2/regexp/endLine.js:
22:38 Changeset [110539] by commit-queue@webkit.org

Fix IndexedDB build with JSC
https://bugs.webkit.org/show_bug.cgi?id=80207

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-12
Reviewed by Adam Barth.

This fixes the build of WebKit when IndexedDB is enabled. Most functions were added
empty implementation, it compiles but IndexedDB is not working.

  • DerivedSources.make: Added missing IDL files.
  • Modules/indexeddb/IDBDatabaseBackendImpl.h: Fix warnings and build errors.

(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBDatabaseCallbacksImpl.cpp: ditto.

(WebCore::IDBDatabaseCallbacksImpl::unregisterDatabase): ditto.

  • Modules/indexeddb/IDBFactoryBackendImpl.cpp: ditto.

(WebCore::IDBFactoryBackendImpl::openBackingStore):

  • Modules/indexeddb/IDBIndexBackendImpl.cpp: ditto.

(WebCore::IDBIndexBackendImpl::countInternal):

  • Modules/indexeddb/IDBKeyPathBackendImpl.cpp: Fix the method signature and add

an empty implementation.
(WebCore):
(WebCore::IDBKeyPathBackendImpl::createIDBKeysFromSerializedValuesAndKeyPath):
(WebCore::IDBKeyPathBackendImpl::injectIDBKeyIntoSerializedValue):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp: Fix warnings.

(WebCore::IDBObjectStoreBackendImpl::countInternal):

  • Modules/indexeddb/IDBPendingTransactionMonitor.cpp: ditto.

(WebCore::transactions):

  • Modules/indexeddb/IDBRequest.cpp: ditto.

(WebCore::IDBRequest::resetReadyState):

  • Modules/indexeddb/IDBRequest.h: ditto.

(WebCore::IDBRequest::onSuccessWithPrefetch):
(WebCore):
(WebCore::JSIDBVersionChangeRequest::visitChildren):

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/IDBBindingUtilities.cpp:

(WebCore::createIDBKeyFromValue): Fix the creation of IDBKeys.
(WebCore::createOptionsObjectFromValue): Add an empty implementation of
the handling of database options (IDBObjectStoreParameters).
(WebCore):

  • bindings/js/IDBBindingUtilities.h:

(WebCore):

  • bindings/js/JSIDBAnyCustom.cpp:

(WebCore::toJS): Add the missing IDBAny's types.

  • bindings/js/JSIDBKeyCustom.cpp:

(WebCore::toJS): Add the missing IDBKey's types.

  • bindings/js/JSIDBVersionChangeRequestCustom.cpp: Added.

IDBVersionChangeRequest has the attribute EventTarget so it requires
the visitChildren() function. An empty implementation was added.

  • bindings/js/OptionsObject.h: Add an empty implementation.

(WebCore):
(OptionsObject):
(WebCore::OptionsObject::OptionsObject):
(WebCore::OptionsObject::isObject):
(WebCore::OptionsObject::isUndefinedOrNull):
(WebCore::OptionsObject::get):
(WebCore::OptionsObject::getWithUndefinedOrNullCheck):

  • bindings/js/SerializedScriptValue.cpp: Add the missing functions needed by IndexedDB.

(WebCore):
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::toWireString):
(WebCore::SerializedScriptValue::createFromWire):
(WebCore::SerializedScriptValue::numberValue):
(WebCore::SerializedScriptValue::deserialize):

  • bindings/js/SerializedScriptValue.h:

(SerializedScriptValue):

  • bindings/scripts/CodeGeneratorJS.pm: Modify the code generator to:

-Support the IDBKey type correctly.
-Support the OptionsObject type.
-Generate valid function call for static functions.
(GenerateImplementationFunctionCall):
(JSValueToNative):
(NativeToJSValue):

  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):

22:36 Changeset [110538] by morrita@google.com

Unreviewed, rolling out r110529.
http://trac.webkit.org/changeset/110529
https://bugs.webkit.org/show_bug.cgi?id=80969

breaks mac build (Requested by morrita on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-12

Source/WebCore:

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::computeUnoccludedContentRect):

Source/WebKit/chromium:

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore):

22:03 Changeset [110537] by morrita@google.com

Unreviewed, rolling out r110524.
http://trac.webkit.org/changeset/110524
https://bugs.webkit.org/show_bug.cgi?id=80936

breaks chromium win build. (Requested by morrita on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-12

Source/WebCore:

  • Target.pri:
  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateNamedConstructorCallback):
(GenerateImplementation):

  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):

  • bindings/v8/NPV8Object.cpp:

(WebCore::npObjectTypeInfo):

  • bindings/v8/V8GCController.cpp:

(WebCore::GrouperVisitor::visitDOMWrapper):

  • bindings/v8/WrapperTypeInfo.h:

(WebCore):
(WrapperTypeInfo):

  • bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Copied from Source/WebCore/bindings/v8/custom/V8StyleSheetCustom.cpp.

(WebCore):
(WebCore::toV8):

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::toV8):
(WebCore):

  • bindings/v8/custom/V8DOMTokenListCustom.cpp: Copied from Source/WebCore/bindings/v8/custom/V8StyleSheetCustom.cpp.

(WebCore):
(WebCore::toV8):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore):

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:

(WebCore::toV8):
(WebCore):

  • bindings/v8/custom/V8StyleSheetCustom.cpp:

(WebCore::toV8):

  • css/CSSStyleSheet.idl:
  • css/StyleSheet.idl:
  • dom/DOMStringMap.idl:
  • dom/NamedNodeMap.idl:
  • html/DOMTokenList.idl:
  • html/track/TextTrackList.idl:

LayoutTests:

  • platform/chromium/test_expectations.txt:
21:20 Changeset [110536] by haraken@chromium.org

[V8][Refactoring] Remove getCachedWrapperSlow() from V8Bindings.cpp
https://bugs.webkit.org/show_bug.cgi?id=80924

Reviewed by Adam Barth.

getCachedWrapperSlow() is called by getCachedWrapper() only,
and getCachedWrapperSlow() just calls getCachedWrapperInline().
Thus, this patch expands getCachedWrapperInline() into getCachedWrapper(),
and removes getCachedWrapperSlow().

No tests. No change in behavior.

  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getCachedWrapper):

21:03 Changeset [110535] by haraken@chromium.org

[V8][Refactoring] Remove existingWrapper() from generated code
https://bugs.webkit.org/show_bug.cgi?id=80927

Reviewed by Adam Barth.

Currently wrap() calls existingWrapper(), and existingWrapper()
just calls getCachedWrapper(). We can remove existingWrapper() from the generated code.

Test: bindings/scripts/test/*

  • bindings/scripts/CodeGeneratorV8.pm: Removed existingWrapper().

(GenerateHeader):
(GenerateNormalAttrGetter):

  • bindings/scripts/test/V8/V8Float64Array.h: Updated run-bindings-tests results.

(V8Float64Array):
(WebCore::V8Float64Array::wrap):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):
(WebCore::V8TestActiveDOMObject::wrap):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):
(WebCore::V8TestCustomNamedGetter::wrap):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):
(WebCore::V8TestEventConstructor::wrap):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):
(WebCore::V8TestEventTarget::wrap):

  • bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):
(WebCore::V8TestInterface::wrap):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):
(WebCore::V8TestMediaQueryListListener::wrap):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):
(WebCore::V8TestNamedConstructor::wrap):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::readOnlyTestObjAttrAttrGetter):
(WebCore::TestObjInternal::cachedAttribute1AttrGetter):
(WebCore::TestObjInternal::cachedAttribute2AttrGetter):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):
(WebCore::V8TestObj::wrap):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):
(WebCore::V8TestSerializedScriptValueInterface::wrap):

20:33 Changeset [110534] by commit-queue@webkit.org

[chromium] Use tileRect instead of pointer derefs
https://bugs.webkit.org/show_bug.cgi?id=80919

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-12
Reviewed by Adrienne Walker.

Covered by existing tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawTileQuad):

20:14 Changeset [110533] by ojan@chromium.org

webkit-patch optimize-baselines sometimes creates a mac-future result
https://bugs.webkit.org/show_bug.cgi?id=80717

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/checkout/baselineoptimizer.py:

(_baseline_search_hypergraph):
(BaselineOptimizer._find_optimal_result_placement):
(BaselineOptimizer._filter_virtual_ports):

  • Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:

(BaselineOptimizerTest.test_no_add_mac_future):

19:45 Changeset [110532] by commit-queue@webkit.org

SVG should support transform-origin and relative values
https://bugs.webkit.org/show_bug.cgi?id=79068

Patch by Hans Muller <hmuller@adobe.com> on 2012-03-12
Reviewed by Dirk Schulze.

Source/WebCore:

Added SVG support for the CSS 'transform-origin' property and for percentage
values in the transform translate function. The changes conform to
http://dev.w3.org/csswg/css3-transforms/.

Tests: svg/transforms/percent-transform-values.xhtml

svg/transforms/transform-origin-css-property.xhtml

  • css/svg.css:

(*):
(html|* > svg):
Default transform-origin for SVG elements is 0 0.

  • platform/Length.h:

(WebCore::Length::calcFloatValue):
Added a calcFloatValue overload whose max parameter (for percent lengths) is a float.
The original version will be obsolete when the sub-pixel layout support is completed.

  • rendering/style/RenderStyle.cpp:
  • rendering/style/RenderStyle.h:

(WebCore):
(WebCore::requireTransformOrigin):
Transforms that only include translations don't depend on the transform-origin.

(WebCore::RenderStyle::applyTransform):
SVG elements interpret non-percentage/keyword transform-origin values relative to their viewport,
unlike HTML which interprets all transform-origin values relative to the element's origin.
The new FloatRect applyTransform() function handles SVG semantics. Similarly, SVG elements interpret
percentage/keyword transform-origin values relative to the origin of their objectBoundingBox(), HTML
uses the borderBox. All this per http://dev.w3.org/csswg/css3-transforms/.

  • svg/SVGStyledTransformableElement.cpp:

(WebCore::SVGStyledTransformableElement::animatedLocalTransform):

LayoutTests:

Added tests for SVG CSS transform-origin property support and for
CSS translations specified with percentages and applied to an SVG element.

  • svg/transforms/change-transform-origin-css-expected.xhtml: Added.
  • svg/transforms/change-transform-origin-css.xhtml: Added.
  • svg/transforms/change-transform-origin-presentation-attribute-expected.xhtml: Added.
  • svg/transforms/change-transform-origin-presentation-attribute.xhtml: Added.
  • svg/transforms/percent-transform-values-expected.txt: Added.
  • svg/transforms/percent-transform-values.xhtml: Added.
  • svg/transforms/transform-origin-css-property-expected.xhtml: Added.
  • svg/transforms/transform-origin-css-property.xhtml: Added.
19:42 Changeset [110531] by morrita@google.com

Unreviewed Windows build fix.

  • src/WebViewImpl.cpp:
19:29 Changeset [110530] by weinig@apple.com

Fix assert seen in DRT due to not calling EventSender.mouseUp in a previous test
https://bugs.webkit.org/show_bug.cgi?id=80925

Reviewed by Maciej Stachowiak.

  • fast/events/input-element-display-none-in-dragleave-crash.html:

Add call to eventSender.mouseUp().

19:27 Changeset [110529] by commit-queue@webkit.org

[chromium] Use projectQuad to apply inverse mapRect
https://bugs.webkit.org/show_bug.cgi?id=80741

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-12
Reviewed by Adrienne Walker.

Source/WebCore:

Unit test: CCOcclusionTrackerTest3dTransform

CCOcclusionTrackerTestPerspectiveTransform
CCOcclusionTrackerTestPerspectiveTransformBehindCamera

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::projectQuad):
(WebCore):
(WebCore::computeUnoccludedContentRect):

Source/WebKit/chromium:

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore):
(CCOcclusionTrackerTest3dTransform):
(WebCore::CCOcclusionTrackerTest3dTransform::runMyTest):
(CCOcclusionTrackerTestPerspectiveTransform):
(WebCore::CCOcclusionTrackerTestPerspectiveTransform::runMyTest):
(CCOcclusionTrackerTestPerspectiveTransformBehindCamera):
(WebCore::CCOcclusionTrackerTestPerspectiveTransformBehindCamera::runMyTest):

19:17 Changeset [110528] by leo.yang@torchmobile.com.cn

[BlackBerry] Upstream the BlackBerry change to platform/graphics/FontPlatformData.h
https://bugs.webkit.org/show_bug.cgi?id=80820

Reviewed by Rob Buis.

The BlackBerry is using the FontPlatformData from Chromium porting.

  • platform/graphics/FontPlatformData.h:
18:58 Changeset [110527] by jberlin@webkit.org

More Windows build fixing.

  • DumpRenderTree/win/WorkQueueItemWin.cpp:
18:52 Changeset [110526] by zmo@google.com

After webgl canvas resize, bindings might be lost
https://bugs.webkit.org/show_bug.cgi?id=80895

Reviewed by Stephen White.

Source/WebCore:

Test: fast/canvas/webgl/texture-bindings-uneffected-on-resize.html

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::reshape): recover bindings after reshape.

LayoutTests:

  • fast/canvas/webgl/texture-bindings-uneffected-on-resize-expected.txt: Added.
  • fast/canvas/webgl/texture-bindings-uneffected-on-resize.html: Added.
18:38 Changeset [110525] by haraken@chromium.org

[V8][Refactoring] Remove getWrapper() and getWrapperSlow()
https://bugs.webkit.org/show_bug.cgi?id=80920

Reviewed by Adam Barth.

Now getWrapper() is the same as getExistingWrapper().
getWrapperSlow() is the same as getExistingWrapperSlow().
This patch removes getWrapper() and getWrapperSlow().
Also this patch renames getExistingWrapper() to getCachedWrapper().

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::getWrapperSlow):

  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getWrapper):
(V8DOMWrapper):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::toV8Slow):

18:37 Changeset [110524] by arv@chromium.org

[V8] Use v8::V8::AddHiddenReferences instead of SetHiddenValue
https://bugs.webkit.org/show_bug.cgi?id=80880

Reviewed by Adam Barth.

Source/WebCore:

We used to add a hidden property in the getter to the returned wrapper.
With this patch we instead handle the liveness of the wrapper in the GC phase by
calling v8::V8::AddHiddenReference.

To reduce the amount of custom code we need, the V8 code generator now supports
GenerateIsReachable (as well as CustomIsReachable) which, even though different
from the JSC attribute, is used in the same cases and takes the same values (even though
at the moment not all JSC values are supported by V8).

No new tests. Covered by existing tests.

  • Target.pri:
  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorJS.pm:

(GetGenerateIsReachable):
(GetCustomIsReachable):
(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(NeedsToVisitDOMWrapper):
(GetGenerateIsReachable):
(GetCustomIsReachable):
(GenerateVisitDOMWrapper):
(GenerateHeader):
(GenerateNamedConstructorCallback):
(GenerateImplementation):

  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):

  • bindings/v8/NPV8Object.cpp:

(WebCore::npObjectTypeInfo):

  • bindings/v8/V8GCController.cpp:

(WebCore::GrouperVisitor::visitDOMWrapper):

  • bindings/v8/WrapperTypeInfo.h:

(WebCore):
(WrapperTypeInfo):

  • bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Removed.
  • bindings/v8/custom/V8DOMStringMapCustom.cpp:
  • bindings/v8/custom/V8DOMTokenListCustom.cpp: Removed.
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore):

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:
  • bindings/v8/custom/V8StyleSheetCustom.cpp:

(WebCore::toV8):

  • css/CSSStyleSheet.idl:
  • css/StyleSheet.idl:
  • dom/DOMStringMap.idl:
  • dom/NamedNodeMap.idl:
  • html/DOMTokenList.idl:
  • html/track/TextTrackList.idl:

LayoutTests:

  • platform/chromium/test_expectations.txt:
18:31 Changeset [110523] by jberlin@webkit.org

More Windows build fixing.

  • DumpRenderTree/win/AccessibilityControllerWin.cpp:
  • DumpRenderTree/win/EditingDelegate.cpp:
  • DumpRenderTree/win/EventSender.cpp:
  • DumpRenderTree/win/FrameLoadDelegate.cpp:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp:
  • DumpRenderTree/win/UIDelegate.cpp:
18:29 Changeset [110522] by dpranke@chromium.org

Remove obsolete 'CPU' modifier.

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
18:27 LayoutUnit edited by leviw@chromium.org
(diff)
18:16 Changeset [110521] by barraclough@apple.com

Object.defineProperty doesn't respect attributes when applied to the Global Object
https://bugs.webkit.org/show_bug.cgi?id=38636
Object.defineProperty doesn't create property on Global Object in the presence of a setter in the prototype chain
https://bugs.webkit.org/show_bug.cgi?id=48911

Rubber stamped by Michael Saboff.

  • fast/js/Object-defineProperty-expected.txt:
  • fast/js/script-tests/Object-defineProperty.js:
    • Added test cases for bugs #38636 & #48911.
18:13 Changeset [110520] by jberlin@webkit.org

More Windows build fixing.

  • MarshallingHelpers.cpp:
  • WebDatabaseManager.cpp:
18:10 Changeset [110519] by haraken@chromium.org

[V8][Refactoring] Make getWrapperSlow() and getExistingWrapperSlow() same
https://bugs.webkit.org/show_bug.cgi?id=80916

Reviewed by Adam Barth.

This is one of the steps for fixing bug 80841.
This patch makes getWrapperSlow() and getExistingWrapperSlow() same.
In the next patch, we will remove getExistingWrapper() and getExistingWrapperSlow().

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::getWrapperSlow):

18:05 Changeset [110518] by fpizlo@apple.com

Arithmetic use inference should be procedure-global and should run in tandem
with type propagation
https://bugs.webkit.org/show_bug.cgi?id=80819
<rdar://problem/11034006>

Reviewed by Gavin Barraclough.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • dfg/DFGArithNodeFlagsInferencePhase.cpp: Removed.
  • dfg/DFGArithNodeFlagsInferencePhase.h: Removed.
  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::isNotNegZero):
(PredictionPropagationPhase):
(JSC::DFG::PredictionPropagationPhase::isNotZero):
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::mergeDefaultArithFlags):

  • dfg/DFGVariableAccessData.h:

(JSC::DFG::VariableAccessData::VariableAccessData):
(JSC::DFG::VariableAccessData::flags):
(VariableAccessData):
(JSC::DFG::VariableAccessData::mergeFlags):

18:02 Changeset [110517] by dpranke@chromium.org

Remove obsolete chromium-gpu-* platform directories for LayoutTests baselines.

Unreviewed, baselines change.

All of the baselines are now in platform/chromium-*/platform/chromium/virtual/gpu/*.

  • platform/chromium-gpu-linux/fast/canvas/arc360-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/canvas-before-css-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/canvas-bg-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/canvas-bg-expected.txt: Removed.
  • platform/chromium-gpu-linux/fast/canvas/canvas-composite-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/canvas-resize-reset-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/canvas-text-baseline-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/canvas-transforms-during-path-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/canvasDrawingIntoSelf-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/drawImage-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/fill-stroke-clip-reset-path-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/fillrect-gradient-zero-stops-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/fillrect_gradient-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/image-pattern-rotate-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/patternfill-repeat-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/quadraticCurveTo-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/setWidthResetAfterForcedRender-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-1-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-2-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-3-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-4-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-5-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-6-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-7-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/toDataURL-alpha-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/zero-size-fill-rect-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/media/mq-transform-02-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/media/mq-transform-02-expected.txt: Removed.
  • platform/chromium-gpu-linux/fast/media/mq-transform-03-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/media/mq-transform-03-expected.txt: Removed.
  • platform/chromium-gpu-linux/fast/repaint/canvas-putImageData-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/repaint/canvas-putImageData-expected.txt: Removed.
  • platform/chromium-gpu-linux/media/audio-controls-rendering-expected.png: Removed.
  • platform/chromium-gpu-linux/media/controls-after-reload-expected.png: Removed.
  • platform/chromium-gpu-linux/media/controls-strict-expected.png: Removed.
  • platform/chromium-gpu-linux/media/controls-styling-expected.png: Removed.
  • platform/chromium-gpu-linux/media/controls-without-preload-expected.png: Removed.
  • platform/chromium-gpu-linux/media/media-controls-clone-expected.png: Removed.
  • platform/chromium-gpu-linux/media/media-document-audio-repaint-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-aspect-ratio-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-canvas-alpha-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-colorspace-yuv420-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-colorspace-yuv422-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-controls-rendering-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-display-toggle-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-frame-accurate-seek-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-layer-crash-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-no-audio-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-playing-and-pause-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-transformed-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-volume-slider-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-zoom-controls-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-zoom-expected.png: Removed.
  • platform/chromium-gpu-mac/canvas/philip/tests/2d.gradient.radial.cone.cylinder-expected.txt: Removed.
  • platform/chromium-gpu-mac/canvas/philip/tests/2d.line.width.basic-expected.txt: Removed.
  • platform/chromium-gpu-mac/canvas/philip/tests/2d.line.width.transformed-expected.txt: Removed.
  • platform/chromium-gpu-mac/canvas/philip/tests/2d.path.arcTo.shape.curve1-expected.txt: Removed.
  • platform/chromium-gpu-mac/canvas/philip/tests/2d.path.arcTo.shape.curve2-expected.txt: Removed.
  • platform/chromium-gpu-mac/canvas/philip/tests/2d.shadow.enable.blur-expected.txt: Removed.
  • platform/chromium-gpu-mac/canvas/philip/tests/2d.text.draw.fontface.notinpage-expected.txt: Removed.
  • platform/chromium-gpu-mac/canvas/philip/tests/2d.transformation.setTransform.skewed-expected.txt: Removed.
  • platform/chromium-gpu-mac/canvas/philip/tests/2d.transformation.transform.skewed-expected.txt: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-as-image-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-bg-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-bg-zoom-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-composite-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-composite-fill-repaint-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-composite-transformclip-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-currentColor-expected.txt: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-fillPath-shadow-expected.txt: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-shadow-expected.txt: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-text-alignment-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-text-baseline-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-transform-skewed-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-transforms-during-path-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/fillrect-gradient-zero-stops-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/fillrect_gradient-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/image-object-in-canvas-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/image-pattern-rotate-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/patternfill-repeat-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/quadraticCurveTo-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/setWidthResetAfterForcedRender-expected.png: Removed.
  • platform/chromium-gpu-mac/media/controls-after-reload-expected.png: Removed.
  • platform/chromium-gpu-mac/media/controls-strict-expected.png: Removed.
  • platform/chromium-gpu-mac/media/controls-styling-expected.png: Removed.
  • platform/chromium-gpu-mac/media/controls-without-preload-expected.png: Removed.
  • platform/chromium-gpu-mac/media/video-aspect-ratio-expected.png: Removed.
  • platform/chromium-gpu-mac/media/video-controls-rendering-expected.png: Removed.
  • platform/chromium-gpu-mac/media/video-display-toggle-expected.png: Removed.
  • platform/chromium-gpu-mac/media/video-layer-crash-expected.png: Removed.
  • platform/chromium-gpu-mac/media/video-no-audio-expected.png: Removed.
  • platform/chromium-gpu-mac/media/video-playing-and-pause-expected.png: Removed.
  • platform/chromium-gpu-mac/media/video-transformed-expected.png: Removed.
  • platform/chromium-gpu-mac/media/video-volume-slider-expected.png: Removed.
  • platform/chromium-gpu-mac/media/video-zoom-controls-expected.png: Removed.
  • platform/chromium-gpu-mac/media/video-zoom-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/arc360-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-as-image-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-as-image-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-as-image-incremental-repaint-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-as-image-incremental-repaint-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-before-css-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-bg-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-bg-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-bg-zoom-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-bg-zoom-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-composite-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-composite-fill-repaint-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-composite-transformclip-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-empty-image-pattern-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-resize-reset-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-text-baseline-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-identity-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-infinity-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-multiply-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-nan-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-non-invertible-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-skewed-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-transforms-during-path-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvasDrawingIntoSelf-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/drawImage-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/fill-stroke-clip-reset-path-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/fillrect-gradient-zero-stops-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/fillrect_gradient-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/gradient-add-second-start-end-stop-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/image-object-in-canvas-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/image-pattern-rotate-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/patternfill-repeat-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/quadraticCurveTo-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/setWidthResetAfterForcedRender-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-1-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-2-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-3-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-4-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-5-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-6-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-7-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/toDataURL-alpha-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/zero-size-fill-rect-expected.png: Removed.
  • platform/chromium-gpu-win/media/controls-after-reload-expected.png: Removed.
  • platform/chromium-gpu-win/media/controls-strict-expected.png: Removed.
  • platform/chromium-gpu-win/media/controls-styling-expected.png: Removed.
  • platform/chromium-gpu-win/media/controls-without-preload-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-aspect-ratio-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-canvas-alpha-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-colorspace-yuv420-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-colorspace-yuv422-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-controls-rendering-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-display-toggle-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-frame-accurate-seek-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-layer-crash-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-no-audio-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-playing-and-pause-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-transformed-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-volume-slider-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-zoom-controls-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-zoom-expected.png: Removed.
  • platform/chromium-gpu/media/video-colorspace-yuv420-expected.png: Removed.
  • platform/chromium-gpu/media/video-colorspace-yuv422-expected.png: Removed.
  • platform/chromium-gpu/media/video-frame-accurate-seek-expected.png: Removed.
17:55 Changeset [110516] by dpranke@chromium.org

remove the 'gpu' group from the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=80353

Reviewed by Adam Barth.

Since those bots are obsolete, we don't need this any more.

  • TestResultServer/static-dashboards/builders.js:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:

(testPlatformAndBuildType):
(testHtmlForTestTypeSwitcherGroup):

17:53 Changeset [110515] by haraken@chromium.org

[V8] Refactor some header includes in V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=80913

Reviewed by Adam Barth.

This patch refactors some header includes in V8 bindings
required for fixing bug 80841.

No tests. No change in behavior.

  • bindings/v8/DOMDataStore.h:

(DOMDataStore):

  • bindings/v8/V8DOMMap.h:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8IsolatedContext.cpp:

(WebCore::V8IsolatedContext::isolatedContext):

  • bindings/v8/V8IsolatedContext.h:

(WebCore::V8IsolatedContext::getEntered):
(V8IsolatedContext):

  • bindings/v8/WorldContextHandle.cpp:
17:50 Changeset [110514] by dpranke@chromium.org

remove graphics_type from webkitpy.layout_tests.models.test_configuration
https://bugs.webkit.org/show_bug.cgi?id=80643

Reviewed by Ojan Vafai.

Now that the chromium-gpu ports are gone, there's no need for
the graphics_type CPU/GPU distinction. Most of this change is
just updating tests accordingly.

  • Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:

(TestExpectationEditorTests):

  • Scripts/webkitpy/layout_tests/models/test_configuration.py:

(TestConfiguration.init):
(TestConfiguration.category_order):
(TestConfiguration.str):
(TestConfiguration.repr):
(TestConfiguration.hash):
(TestConfigurationConverter.to_specifiers_list):

  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:

(make_mock_all_test_configurations_set):
(TestConfigurationTest.test_items):
(TestConfigurationTest.test_keys):
(TestConfigurationTest.test_str):
(TestConfigurationTest.test_repr):
(TestConfigurationTest.test_hash):
(TestConfigurationTest.test_hash.query_unknown_key):
(TestConfigurationTest.test_eq):
(TestConfigurationTest.test_values):
(SpecifierSorterTest.test_specifier_priority):
(SpecifierSorterTest.test_sort_specifiers):
(TestConfigurationConverterTest.test_to_config_set):
(TestConfigurationConverterTest.test_macro_expansion):
(TestConfigurationConverterTest.test_to_specifier_lists):
(TestConfigurationConverterTest.test_converter_macro_collapsing):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(test_error_on_different_build_type):
(TestExpectationSerializerTests.test_parsed_to_string):
(TestExpectationSerializerTests.test_reconstitute_only_these):

  • Scripts/webkitpy/layout_tests/port/apple.py:

(ApplePort._generate_all_test_configurations):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.init):
(Port.name):
(Port.version):
(Port.test_configuration):

  • Scripts/webkitpy/layout_tests/port/builders.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort):
(ChromiumPort._generate_all_test_configurations):

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:

(ChromiumLinuxPort.init):

  • Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:

(ChromiumLinuxPortTest.test_check_illegal_port_names):

  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:

(ChromiumMacPortTest.test_baseline_path):

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumPortTest.test_all_test_configurations):

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort._generate_all_test_configurations):

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort._generate_all_test_configurations):

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort._generate_all_test_configurations):

  • Scripts/webkitpy/layout_tests/port/test.py:

(TestPort.all_test_configurations):
(TestPort._all_build_types):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:

(BuildCoverageExtrapolatorTest.test_extrapolate):
(GardeningExpectationsUpdaterTest.test_unknown_failure_type):
(GardeningExpectationsUpdaterTest.test_add_new_expectation):
(GardeningExpectationsUpdaterTest.test_replace_old_expectation):
(GardeningExpectationsUpdaterTest.test_pass_expectation):
(GardeningExpectationsUpdaterTest.test_supplement_old_expectation):
(GardeningExpectationsUpdaterTest.test_spurious_updates):

17:43 Changeset [110513] by dpranke@chromium.org

_runtime_feature_list isn't supported on Apple Mac DRT
https://bugs.webkit.org/show_bug.cgi?id=80906

Reviewed by Eric Seidel.

It looks like this feature is actually only supported on the Win
DRT port, so this patch reworks the code to make that clearer
and reduce unnecessary overrides.

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort._path_to_webcore_library):

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort._path_to_webcore_library):

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort._skipped_file_search_paths):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._runtime_feature_list):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(TestWebKitPort.init):
(TestWebKitPort.all_test_configurations):
(test_skipped_directories_for_features):

  • Scripts/webkitpy/layout_tests/port/win.py:

(WinPort):
(WinPort._runtime_feature_list):

  • Scripts/webkitpy/layout_tests/port/win_unittest.py:

(WinPortTest.test_operating_system):
(WinPortTest):
(WinPortTest.test_runtime_feature_list):

17:31 Changeset [110512] by weinig@apple.com

Fix typo in PageClientImpl where we were overriding viewLayerHostingMode with
a function called layerHostingMode.

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::viewLayerHostingMode):
Update name and add OVERRIDE to catch this in the future.

17:22 Changeset [110511] by commit-queue@webkit.org

Unreviewed, rolling out r110501.
http://trac.webkit.org/changeset/110501
https://bugs.webkit.org/show_bug.cgi?id=80908

Broke the Apple-Win build (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-12

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.xcodeproj/project.pbxproj:
  • fileapi/DirectoryEntry.cpp: Renamed from Source/WebCore/Modules/filesystem/DirectoryEntry.cpp.

(WebCore):
(WebCore::DirectoryEntry::DirectoryEntry):
(WebCore::DirectoryEntry::createReader):
(WebCore::DirectoryEntry::getFile):
(WebCore::DirectoryEntry::getDirectory):
(WebCore::DirectoryEntry::removeRecursively):

  • fileapi/DirectoryEntry.h: Renamed from Source/WebCore/Modules/filesystem/DirectoryEntry.h.

(WebCore):
(DirectoryEntry):
(WebCore::DirectoryEntry::create):
(WebCore::DirectoryEntry::isDirectory):

  • fileapi/DirectoryEntry.idl: Renamed from Source/WebCore/Modules/filesystem/DirectoryEntry.idl.
  • fileapi/DirectoryEntrySync.cpp: Renamed from Source/WebCore/Modules/filesystem/DirectoryEntrySync.cpp.

(WebCore):
(WebCore::DirectoryEntrySync::DirectoryEntrySync):
(WebCore::DirectoryEntrySync::createReader):
(WebCore::DirectoryEntrySync::getFile):
(WebCore::DirectoryEntrySync::getDirectory):
(WebCore::DirectoryEntrySync::removeRecursively):

  • fileapi/DirectoryEntrySync.h: Renamed from Source/WebCore/Modules/filesystem/DirectoryEntrySync.h.

(WebCore):
(DirectoryEntrySync):
(WebCore::DirectoryEntrySync::create):
(WebCore::DirectoryEntrySync::isDirectory):

  • fileapi/DirectoryEntrySync.idl: Renamed from Source/WebCore/Modules/filesystem/DirectoryEntrySync.idl.
  • fileapi/DirectoryReader.cpp: Renamed from Source/WebCore/Modules/filesystem/DirectoryReader.cpp.

(WebCore):
(WebCore::DirectoryReader::DirectoryReader):
(WebCore::DirectoryReader::readEntries):

  • fileapi/DirectoryReader.h: Renamed from Source/WebCore/Modules/filesystem/DirectoryReader.h.

(WebCore):
(DirectoryReader):
(WebCore::DirectoryReader::create):
(WebCore::DirectoryReader::filesystem):

  • fileapi/DirectoryReader.idl: Renamed from Source/WebCore/Modules/filesystem/DirectoryReader.idl.
  • fileapi/DirectoryReaderBase.h: Renamed from Source/WebCore/Modules/filesystem/DirectoryReaderBase.h.

(WebCore):
(DirectoryReaderBase):
(WebCore::DirectoryReaderBase::filesystem):
(WebCore::DirectoryReaderBase::setHasMoreEntries):
(WebCore::DirectoryReaderBase::DirectoryReaderBase):

  • fileapi/DirectoryReaderSync.cpp: Renamed from Source/WebCore/Modules/filesystem/DirectoryReaderSync.cpp.

(WebCore):
(WebCore::DirectoryReaderSync::DirectoryReaderSync):
(WebCore::DirectoryReaderSync::readEntries):

  • fileapi/DirectoryReaderSync.h: Renamed from Source/WebCore/Modules/filesystem/DirectoryReaderSync.h.

(WebCore):
(DirectoryReaderSync):
(WebCore::DirectoryReaderSync::create):

  • fileapi/DirectoryReaderSync.idl: Renamed from Source/WebCore/Modules/filesystem/DirectoryReaderSync.idl.
17:15 Changeset [110510] by thakis@chromium.org

[chromium/mac] Make sure libWebKitSystemInterface.a doesn't contain ppc object files.
https://bugs.webkit.org/show_bug.cgi?id=80902

Reviewed by Adam Barth.

Follow-up to http://codereview.chromium.org/9638015/

No intended behavior change.

  • WebCore.gyp/mac/adjust_visibility.sh:
17:14 Changeset [110509] by leviw@chromium.org

Fixing/cleaning up rounding in RenderReplaced classes, and removing an unnecessary static_cast in RenderFrameSet.

17:09 Changeset [110508] by eae@chromium.org

Qt build fixes for branch.

17:09 Changeset [110507] by jer.noble@apple.com

WebCore: Add support for AudioNode "tailTime()" and "latencyTime()"
https://bugs.webkit.org/show_bug.cgi?id=74750

Reviewed by Chris Rogers.

No new tests; optimization of existing code path, so covered by existing tests.

To account for AudioNodes which may generate non-silent audio when fed silent input
for a certain amount of time after the last non-silent audio data, add two new virtual
functions tailTime() and latencyTime().

  • webaudio/AudioNode.h:

(WebCore::AudioNode::tailTime): Added. Pure virtual.
(WebCore::AudioNode::latencyTime): Added. Pure virtual.

  • platform/audio/AudioProcessor.h:

(WebCore::AudioProcessor::tailTime): Added. Pure virtual.
(WebCore::AudioProcessor::latencyTime): Added. Pure virtual.

  • platform/audio/AudioDSPKernel.h:

(WebCore::AudioDSPKernel::tailTime): Added. Pure virtual.
(WebCore::AudioDSPKernel::latencyTime): Added. Pure virtual.

Added tailTime() and latencyTime() overrides to the following classes:

  • platform/audio/AudioDSPKernelProcessor.cpp:

(WebCore::AudioDSPKernelProcessor::tailTime):
(WebCore::AudioDSPKernelProcessor::latencyTime):

  • platform/audio/AudioDSPKernelProcessor.h:
  • platform/audio/DynamicsCompressor.h:

(WebCore::DynamicsCompressor::tailTime):
(WebCore::DynamicsCompressor::latencyTime):

  • platform/audio/EqualPowerPanner.h:
  • platform/audio/HRTFPanner.cpp:

(WebCore::HRTFPanner::tailTime):
(WebCore::HRTFPanner::latencyTime):

  • platform/audio/HRTFPanner.h:
  • platform/audio/Panner.h:
  • webaudio/AudioBasicProcessorNode.cpp:

(WebCore::AudioBasicProcessorNode::tailTime):
(WebCore::AudioBasicProcessorNode::latencyTime):

  • webaudio/AudioBasicProcessorNode.h:
  • webaudio/AudioChannelMerger.h:
  • webaudio/AudioChannelSplitter.h:
  • webaudio/AudioDestinationNode.h:
  • webaudio/AudioGainNode.h:
  • webaudio/AudioPannerNode.h:
  • webaudio/AudioSourceNode.h:
  • webaudio/BiquadDSPKernel.cpp:

(WebCore::BiquadDSPKernel::tailTime):
(WebCore::BiquadDSPKernel::latencyTime):

  • webaudio/BiquadDSPKernel.h:
  • webaudio/BiquadFilterNode.h:
  • webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::tailTime):
(WebCore::ConvolverNode::latencyTime):

  • webaudio/ConvolverNode.h:
  • webaudio/DelayDSPKernel.cpp:

(WebCore::DelayDSPKernel::tailTime):
(WebCore::DelayDSPKernel::latencyTime):

  • webaudio/DelayDSPKernel.h:
  • webaudio/DelayProcessor.h:
  • webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::tailTime):
(WebCore::DynamicsCompressorNode::latencyTime):

  • webaudio/DynamicsCompressorNode.h:
  • webaudio/JavaScriptAudioNode.cpp:

(WebCore::JavaScriptAudioNode::tailTime):
(WebCore::JavaScriptAudioNode::latencyTime):

  • webaudio/JavaScriptAudioNode.h:
  • webaudio/RealtimeAnalyserNode.h:
  • webaudio/WaveShaperDSPKernel.h:

The following functions were added as support for the new AudioNode and AudioProcessor functions:

  • platform/audio/Biquad.cpp:

(WebCore::Biquad::latencyFrames):

  • platform/audio/Biquad.h:
  • platform/audio/Reverb.cpp:

(WebCore::Reverb::latencyFrames):

  • platform/audio/ReverbConvolver.h:

(WebCore::ReverbConvolver::latencyFrames):

The following functions were made const-correct:

  • platform/audio/HRTFPanner.h:

(WebCore::HRTFPanner::fftSize):

  • platform/audio/Reverb.h:

(WebCore::Reverb::impulseResponseLength):

17:07 Changeset [110506] by andersca@apple.com

WebTileLayers should be opaque
https://bugs.webkit.org/show_bug.cgi?id=80907
<rdar://problem/11034390>

Reviewed by Andreas Kling.

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::createTileLayer):
Call -[CALayer setOpaque:] on the newly created WebTileLayer.

17:05 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
16:51 Changeset [110505] by eae@chromium.org

Fix rounding in scrollbar rect calculations
https://bugs.webkit.org/show_bug.cgi?id=80894

Reviewed by Eric Seidel.

Fix usage of subpixel units in RenderScrollbar::buttonRect and
RenderScrollbar::trackRect.

No new tests, no new functionality.

  • rendering/LayoutTypes.h:

(WebCore::isIntegerValue):
Add dummy isIntegerValue function, will be replaced with actual
implementation once LayoutUnit is remapped to FractionalLayoutUnit.

  • rendering/RenderScrollbar.cpp:

(WebCore::RenderScrollbar::buttonRect):
(WebCore::RenderScrollbar::trackRect):
Change rect calculations to use pixel snapped values.

  • rendering/RenderScrollbarPart.h:

(RenderScrollbarPart):
(WebCore::RenderScrollbarPart::marginTop):
(WebCore::RenderScrollbarPart::marginBottom):
(WebCore::RenderScrollbarPart::marginLeft):
(WebCore::RenderScrollbarPart::marginRight):
Add ASSERT to ensure that scrollbar parts are always aligned to device
pixels.

16:46 Changeset [110504] by commit-queue@webkit.org

[GObject IDL Parser] STRING argument should be HASHREF
https://bugs.webkit.org/show_bug.cgi?id=78877

Patch by C Anthony Risinger <anthony@xtfx.me> on 2012-03-12
Reviewed by Kentaro Hara.

  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateFunctions): extendedAttributes are hashes, not strings

16:43 Changeset [110503] by jberlin@webkit.org

More Windows build fixing.

Use fully qualified paths for WTF headers.

  • platform/graphics/cg/ImageSourceCGWin.cpp:
  • platform/graphics/win/UniscribeController.h:
  • platform/win/DragImageCGWin.cpp:
  • platform/win/DragImageCairoWin.cpp:
  • platform/win/DragImageWin.cpp:
  • rendering/RenderThemeSafari.cpp:
16:40 Changeset [110502] by abarth@webkit.org

This baseline also applies to chromium-mac-snowleopard, so we can move
it up the fallback chain.

  • platform/chromium-mac-leopard/fast/events/scrollbar-double-click-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/events/scrollbar-double-click-expected.txt: Added.
16:38 Changeset [110501] by commit-queue@webkit.org

Move DirectoryEntry and DirectoryReader to new Modules/filesystem/ directory
https://bugs.webkit.org/show_bug.cgi?id=80625

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-03-12
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • Modules/filesystem: Added.
  • Modules/filesystem/DirectoryEntry.cpp: Copied from Source/WebCore/fileapi/DirectoryEntry.cpp.
  • Modules/filesystem/DirectoryEntry.h: Copied from Source/WebCore/fileapi/DirectoryEntry.h.
  • Modules/filesystem/DirectoryEntry.idl: Copied from Source/WebCore/fileapi/DirectoryEntry.idl.
  • Modules/filesystem/DirectoryEntrySync.cpp: Copied from Source/WebCore/fileapi/DirectoryEntrySync.cpp.
  • Modules/filesystem/DirectoryEntrySync.h: Copied from Source/WebCore/fileapi/DirectoryEntrySync.h.
  • Modules/filesystem/DirectoryEntrySync.idl: Copied from Source/WebCore/fileapi/DirectoryEntrySync.idl.
  • Modules/filesystem/DirectoryReader.cpp: Copied from Source/WebCore/fileapi/DirectoryReader.cpp.
  • Modules/filesystem/DirectoryReader.h: Copied from Source/WebCore/fileapi/DirectoryReader.h.
  • Modules/filesystem/DirectoryReader.idl: Copied from Source/WebCore/fileapi/DirectoryReader.idl.
  • Modules/filesystem/DirectoryReaderBase.h: Copied from Source/WebCore/fileapi/DirectoryReaderBase.h.
  • Modules/filesystem/DirectoryReaderSync.cpp: Copied from Source/WebCore/fileapi/DirectoryReaderSync.cpp.
  • Modules/filesystem/DirectoryReaderSync.h: Copied from Source/WebCore/fileapi/DirectoryReaderSync.h.
  • Modules/filesystem/DirectoryReaderSync.idl: Copied from Source/WebCore/fileapi/DirectoryReaderSync.idl.
  • Target.pri:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.xcodeproj/project.pbxproj:
  • fileapi/DirectoryEntry.cpp: Removed.
  • fileapi/DirectoryEntry.h: Removed.
  • fileapi/DirectoryEntry.idl: Removed.
  • fileapi/DirectoryEntrySync.cpp: Removed.
  • fileapi/DirectoryEntrySync.h: Removed.
  • fileapi/DirectoryEntrySync.idl: Removed.
  • fileapi/DirectoryReader.cpp: Removed.
  • fileapi/DirectoryReader.h: Removed.
  • fileapi/DirectoryReader.idl: Removed.
  • fileapi/DirectoryReaderBase.h: Removed.
  • fileapi/DirectoryReaderSync.cpp: Removed.
  • fileapi/DirectoryReaderSync.h: Removed.
  • fileapi/DirectoryReaderSync.idl: Removed.
16:34 Changeset [110500] by beidson@apple.com

https://bugs.webkit.org/show_bug.cgi?id=80903 InspectorDOMStorageAgent creates a Storage object which is a DOMWindowProperty - Should use the StorageArea directly

Reviewed by Tim Hatcher.

No new tests. (No behavior change)

Changed to hold the StorageArea directly and added a Frame* accessor:

  • inspector/InspectorDOMStorageResource.h:

(WebCore::InspectorDOMStorageResource::create):
(WebCore::InspectorDOMStorageResource::storageArea):
(WebCore::InspectorDOMStorageResource::frame):
(InspectorDOMStorageResource):

  • inspector/InspectorDOMStorageResource.cpp:

(WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource):

  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::didUseDOMStorage):

16:23 Changeset [110499] by abarth@webkit.org

[Skia] Release CGImage used to apply color space conversion to SkBitmap
https://bugs.webkit.org/show_bug.cgi?id=80892

Patch by Brian Salomon <bsalomon@google.com> on 2012-03-12
Reviewed by Adam Barth.

Regressions should be covered by any test that does image decode on the mac.

  • platform/image-decoders/skia/ImageDecoderSkia.cpp:

(WebCore::resolveColorSpace):

16:15 Changeset [110498] by fpizlo@apple.com

Node::op and Node::flags should be private
https://bugs.webkit.org/show_bug.cgi?id=80824
<rdar://problem/11033435>

Reviewed by Gavin Barraclough.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::mergeStateAtTail):
(JSC::DFG::AbstractState::mergeToSuccessors):

  • dfg/DFGArithNodeFlagsInferencePhase.cpp:

(JSC::DFG::ArithNodeFlagsInferencePhase::propagate):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::injectLazyOperandPrediction):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::flushArgument):
(JSC::DFG::ByteCodeParser::toInt32):
(JSC::DFG::ByteCodeParser::isJSConstant):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::linkBlock):

  • dfg/DFGCFAPhase.cpp:

(JSC::DFG::CFAPhase::performBlockCFA):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::canonicalize):
(JSC::DFG::CSEPhase::endIndexForPureCSE):
(JSC::DFG::CSEPhase::pureCSE):
(JSC::DFG::CSEPhase::byValIsPure):
(JSC::DFG::CSEPhase::clobbersWorld):
(JSC::DFG::CSEPhase::impureCSE):
(JSC::DFG::CSEPhase::globalVarLoadElimination):
(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::checkFunctionElimination):
(JSC::DFG::CSEPhase::checkStructureLoadElimination):
(JSC::DFG::CSEPhase::getByOffsetLoadElimination):
(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::getScopeChainLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(DFG):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::addShouldSpeculateInteger):
(JSC::DFG::Graph::negateShouldSpeculateInteger):
(JSC::DFG::Graph::methodOfGettingAValueProfileFor):

  • dfg/DFGNode.cpp: Removed.
  • dfg/DFGNode.h:

(DFG):
(JSC::DFG::Node::Node):
(Node):
(JSC::DFG::Node::op):
(JSC::DFG::Node::flags):
(JSC::DFG::Node::setOp):
(JSC::DFG::Node::setFlags):
(JSC::DFG::Node::mergeFlags):
(JSC::DFG::Node::filterFlags):
(JSC::DFG::Node::clearFlags):
(JSC::DFG::Node::setOpAndDefaultFlags):
(JSC::DFG::Node::mustGenerate):
(JSC::DFG::Node::isConstant):
(JSC::DFG::Node::isWeakConstant):
(JSC::DFG::Node::valueOfJSConstant):
(JSC::DFG::Node::hasVariableAccessData):
(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::resolveGlobalDataIndex):
(JSC::DFG::Node::hasArithNodeFlags):
(JSC::DFG::Node::arithNodeFlags):
(JSC::DFG::Node::setArithNodeFlag):
(JSC::DFG::Node::mergeArithNodeFlags):
(JSC::DFG::Node::hasConstantBuffer):
(JSC::DFG::Node::hasRegexpIndex):
(JSC::DFG::Node::hasVarNumber):
(JSC::DFG::Node::hasScopeChainDepth):
(JSC::DFG::Node::hasResult):
(JSC::DFG::Node::hasInt32Result):
(JSC::DFG::Node::hasNumberResult):
(JSC::DFG::Node::hasJSResult):
(JSC::DFG::Node::hasBooleanResult):
(JSC::DFG::Node::isJump):
(JSC::DFG::Node::isBranch):
(JSC::DFG::Node::isTerminal):
(JSC::DFG::Node::hasHeapPrediction):
(JSC::DFG::Node::hasFunctionCheckData):
(JSC::DFG::Node::hasStructureTransitionData):
(JSC::DFG::Node::hasStructureSet):
(JSC::DFG::Node::hasStorageAccessData):
(JSC::DFG::Node::hasFunctionDeclIndex):
(JSC::DFG::Node::hasFunctionExprIndex):
(JSC::DFG::Node::child1):
(JSC::DFG::Node::child2):
(JSC::DFG::Node::child3):
(JSC::DFG::Node::firstChild):
(JSC::DFG::Node::numChildren):

  • dfg/DFGNodeFlags.cpp: Copied from Source/JavaScriptCore/dfg/DFGNode.cpp.
  • dfg/DFGNodeFlags.h: Added.

(DFG):
(JSC::DFG::nodeUsedAsNumber):
(JSC::DFG::nodeCanTruncateInteger):
(JSC::DFG::nodeCanIgnoreNegativeZero):
(JSC::DFG::nodeMayOverflow):
(JSC::DFG::nodeCanSpeculateInteger):

  • dfg/DFGNodeType.h: Added.

(DFG):
(JSC::DFG::defaultFlags):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::vote):
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):
(JSC::DFG::PredictionPropagationPhase::fixupNode):

  • dfg/DFGRedundantPhiEliminationPhase.cpp:

(JSC::DFG::RedundantPhiEliminationPhase::run):
(JSC::DFG::RedundantPhiEliminationPhase::replacePhiChild):
(JSC::DFG::RedundantPhiEliminationPhase::updateBlockVariableInformation):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::useChildren):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
(JSC::DFG::SpeculativeJIT::compileUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compare):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGVirtualRegisterAllocationPhase.cpp:

(JSC::DFG::VirtualRegisterAllocationPhase::run):

16:10 Changeset [110497] by eae@chromium.org

Fix scrollbar rect calculations on branch.

15:59 Changeset [110496] by leviw@chromium.org

Update LayoutUnit usage in RenderMathML* classes
https://bugs.webkit.org/show_bug.cgi?id=77916

Reviewed by Eric Seidel.

The purpose of this patch is to ensure MathML rendering does not regress when
we switch to sub-pixel layout. A subsequent patch can likely improve MathML's
rendering when zoom is applied.

To accomplish this without changing the current heuristics for positioning,
we continue to use integers for sizes and locations, using pixel snapping
when communicating with other Rendering classes.

No new tests. No change in behavior.

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::paint): Cleaning up debug painting to be on
pixel boundaries instead of subpixel.

  • rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::paint): Reverting to integers for determining
the vertical offset.
(WebCore::RenderMathMLFraction::baselinePosition):

  • rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::paint): Using integers for height and width
and only accumulating pixel snapped values.
(WebCore::RenderMathMLRoot::layout): Setting padding with integers to
avoid inconsistent rounding based on the root's location.

  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::layout):

  • rendering/mathml/RenderMathMLSquareRoot.cpp:

(WebCore::RenderMathMLSquareRoot::paint): See RenderMathMLRoot.
(WebCore::RenderMathMLSquareRoot::layout): Ditto.

  • rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore::getOffsetHeight):
(WebCore::RenderMathMLUnderOver::layout):

15:57 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
15:48 Changeset [110495] by andersca@apple.com

Use smaller tiles for right and bottom edges
https://bugs.webkit.org/show_bug.cgi?id=80893
<rdar://problem/11032873>

Reviewed by Sam Weinig.

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::rectForTileIndex):
Intersect the rect with the tile cache bounds.

(WebCore::TileCache::revalidateTiles):
Resize already existing tiles if needed.

(WebCore::TileCache::createTileLayer):
This now takes a tile rect. Use setFrame instead of setting the bounds and position separately.

15:45 Changeset [110494] by enrica@apple.com

Source/WebCore: WebKit2: remove NSPasteboard access for promised data from the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=80073

Reviewed by Alexey Proskuryakov.

  • WebCore.exp.in: Added two exported methods.
  • platform/mac/FileSystemMac.mm:

(WebCore::setMetaData): Last parameter in the call to wkSetMetadataURL
needs to be wrapped in String before casting to NSString.

Source/WebKit2: WebKit2: remove NSPasteboard access for promised data from the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=80073

Reviewed by Alexey Proskuryakov.

This patch removes the last remaining access to NSPasteboard from the WebProcess.
The code in WebDragClient::declareAndWriteDragImage now packages all the data
required for the drag and the promised drag types and sends one request to the UI
process that will place the data in the NSPasteboard when appropriate.

  • UIProcess/API/mac/PageClientImpl.h: Added setPromisedData method.
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setPromisedData):

  • UIProcess/API/mac/WKView.mm:

(matchesExtensionOrEquivalent): Added.
(fileExists): Added.
(pathWithUniqueFilenameForPath): Added.
(-[WKView _setPromisedData:WebCore::withFileName:withExtension:withTitle:withURL:withVisibleURL:withArchive:WebCore::forPasteboard:]):
(-[WKView pasteboardChangedOwner:]):
(-[WKView pasteboard:provideDataForType:]):
(-[WKView namesOfPromisedFilesDroppedAtDestination:]):

  • UIProcess/API/mac/WKViewInternal.h: Added _setPromisedData.
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h: Added method for the new message.
  • UIProcess/WebPageProxy.messages.in: Added setPromisedData message.
  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::setPromisedData):

  • WebProcess/WebCoreSupport/WebDragClient.cpp:
  • WebProcess/WebCoreSupport/WebDragClient.h:
  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::WebDragClient::declareAndWriteDragImage):

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Added SetMetadataURL.

WebKitLibraries: WebKit2: remove NSPasteboard access for promised data from the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=80073

  • WebKitSystemInterface.h: Touched the file to make build system happy.
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
15:40 Changeset [110493] by abarth@webkit.org

Update expected results after http://trac.webkit.org/changeset/110480.
These results are very similar to our previous results and seem
slightly improved AFAICT.

  • platform/chromium-mac-leopard/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-disabled-color-expected.png:
  • platform/chromium-mac-leopard/fast/forms/text-style-color-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug99948-expected.png:
  • platform/chromium-mac-snowleopard/fast/block/float/032-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-disabled-color-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/text-style-color-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug99948-expected.png:
15:38 Changeset [110492] by commit-queue@webkit.org

[Blackberry] Make the process of marking all matches interruptible and asynchronous for find-in-page
https://bugs.webkit.org/show_bug.cgi?id=80831

Patch by Andy Chen <andchen@rim.com> on 2012-03-12
Reviewed by Antonio Gomes.

  • WebKitSupport/InPageSearchManager.cpp:

(BlackBerry::WebKit::InPageSearchManager::DeferredScopeStringMatches::DeferredScopeStringMatches):
(BlackBerry::WebKit::InPageSearchManager::DeferredScopeStringMatches::doTimeout):
(BlackBerry::WebKit::InPageSearchManager::InPageSearchManager):
(BlackBerry::WebKit::InPageSearchManager::~InPageSearchManager):
(BlackBerry::WebKit::InPageSearchManager::findNextString):
(BlackBerry::WebKit::InPageSearchManager::shouldSearchForText):
(BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
(BlackBerry::WebKit::InPageSearchManager::clearTextMatches):
(BlackBerry::WebKit::InPageSearchManager::frameUnloaded):
(BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
(BlackBerry::WebKit::InPageSearchManager::scopeStringMatchesSoon):
(BlackBerry::WebKit::InPageSearchManager::callScopeStringMatches):
(BlackBerry::WebKit::InPageSearchManager::cancelPendingScopingEffort):

  • WebKitSupport/InPageSearchManager.h:
15:37 Changeset [110491] by abarth@webkit.org

Restore previous expecation for chromium-mac-leopard. rniwa says this
is the right thing to do.

  • platform/chromium-mac-leopard/fast/events/scrollbar-double-click-expected.txt: Added.
15:28 Changeset [110490] by rniwa@webkit.org

Yet another Mac rebaseline.

  • editing/pasteboard/dataTransfer-setData-getData-expected.txt:
  • platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
15:24 Changeset [110489] by commit-queue@webkit.org

Convert some fast/regions pixel tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=79132

Patch by Rebecca Hauck <rhauck@adobe.com> on 2012-03-12
Reviewed by Dirk Schulze.

  • fast/regions/floats-basic-in-variable-width-regions-expected.html: Added.
  • fast/regions/floats-basic-in-variable-width-regions.html:
  • platform/chromium/test_expectations.txt:
  • platform/efl/fast/regions/floats-basic-in-variable-width-regions-expected.png: Removed.
  • platform/efl/fast/regions/floats-basic-in-variable-width-regions-expected.txt: Removed.
  • platform/mac/fast/regions/floats-basic-in-variable-width-regions-expected.png: Removed.
  • platform/mac/fast/regions/floats-basic-in-variable-width-regions-expected.txt: Removed.
15:22 Changeset [110488] by ap@apple.com

clang build fix

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::convertToLength): Reorder
boolean operators, so that a warning about "use of logical
with constant operand" doesn't

appear.

15:17 Changeset [110487] by inferno@chromium.org

Crash in Text::splitText due to mutation events.
https://bugs.webkit.org/show_bug.cgi?id=80828

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/text/split-text-crash.xhtml

  • dom/Range.cpp:

(WebCore::Range::insertNode): replace m_start.container() calls with ref protected node.

LayoutTests:

  • fast/text/split-text-crash-expected.txt: Added.
  • fast/text/split-text-crash.xhtml: Added.
14:59 Changeset [110486] by abarth@webkit.org

[chromium] Fix clang build for CCOcclusionTracker tests
https://bugs.webkit.org/show_bug.cgi?id=80891

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-12
Reviewed by Adam Barth.

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore::CCOcclusionTrackerTest::createRoot):
(WebCore::CCOcclusionTrackerTest::createLayer):
(WebCore::CCOcclusionTrackerTest::createDrawingLayer):

14:59 Changeset [110485] by kbr@google.com

Null argument to texSubImage2D crashes
https://bugs.webkit.org/show_bug.cgi?id=80778

Reviewed by Dean Jackson.

Source/WebCore:

Generate INVALID_VALUE OpenGL error upon receiving null argument.
Final behavior still being decided on public-webgl mailing list.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::texImage2D):
(WebCore::WebGLRenderingContext::texSubImage2D):
(WebCore::WebGLRenderingContext::validateTexFuncData):

  • html/canvas/WebGLRenderingContext.h:

LayoutTests:

Updated tex-sub-image-2d-bad-args test to verify new behavior.

  • fast/canvas/webgl/tex-sub-image-2d-bad-args-expected.txt:
  • fast/canvas/webgl/tex-sub-image-2d-bad-args.html:
14:54 Changeset [110484] by macpherson@chromium.org

Remove CSSStyleSelector's convertToLength method and use CSSPrimitiveValue's version directly.
https://bugs.webkit.org/show_bug.cgi?id=80484

Reviewed by Julien Chaffraix.

No new tests / code cleanup only.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::convertToLength):

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyClip::convertToLength):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

14:52 Changeset [110483] by senorblanco@chromium.org

[chromium] Restore canvas2D acceleration after context loss.
https://bugs.webkit.org/show_bug.cgi?id=80629

Reviewed by James Robinson.

Covered by existing canvas tests, and manual testing (killing the GPU
process).

Source/WebCore:

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::create):
(WebCore::Canvas2DLayerChromium::Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::setNeedsDisplayRect):
(WebCore::Canvas2DLayerChromium::drawsContent):
(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/Canvas2DLayerChromium.h:

(Canvas2DLayerChromium):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::applyFilters):

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp:

(SharedGraphicsContext3DImpl):
(WebCore::SharedGraphicsContext3DImpl::SharedGraphicsContext3DImpl):
(WebCore::SharedGraphicsContext3DImpl::get):
(WebCore):
(WebCore::SharedGraphicsContext3D::get):

  • platform/graphics/gpu/SharedGraphicsContext3D.h:

(SharedGraphicsContext3D):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::createAcceleratedCanvas):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::PlatformContextSkia):
(WebCore):

  • platform/graphics/skia/PlatformContextSkia.h:

(WebCore):
(WebCore::PlatformContextSkia::isAccelerated):
(WebCore::PlatformContextSkia::setAccelerated):
(PlatformContextSkia):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::sharedGraphicsContext3D):

14:51 Changeset [110482] by leviw@chromium.org

Fixing misaligned painting in RenderListBox and RenderFileUploadControl. Correcting width calculations for platform code in RenderFileUploadControl. Changing RenderLayer::absoluteBoundingBox to a pixel snapped IntRect, which simplifies platform code.

14:36 Changeset [110481] by staikos@webkit.org

It doesn't make sense to return const unsigned, and GCC warns about it.
Remove const.
https://bugs.webkit.org/show_bug.cgi?id=80790

Reviewed by Antonio Gomes.

  • platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.h:

(WebCore::ComplexTextController::length):
(WebCore::ComplexTextController::numCodePoints):
(WebCore::ComplexTextController::offsetX):

14:33 Changeset [110480] by bdakin@apple.com

https://bugs.webkit.org/show_bug.cgi?id=80888
Clear background for NSTextFieldCell is unreliable and not necessary
-and corresponding-
<rdar://problem/10663710>

Reviewed by Dan Bernstein.

With http://trac.webkit.org/changeset/104240 I thought it was necessary to
make NSTextFieldCells draw with a clear background in order to allow styled
text fields. That is not actually necessary; we just had a different bug
where isControlStyled() was only checking for styled borders on text fields.
Text fields can also be styled with backgrounds, so they need the full check.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::isControlStyled):
(WebCore::RenderThemeMac::textField):

14:28 Changeset [110479] by cevans@google.com

Merge 110111
BUG=117226
Review URL: https://chromiumcodereview.appspot.com/9689032

14:17 Changeset [110478] by commit-queue@webkit.org

Cleanup obsolete files.
https://bugs.webkit.org/show_bug.cgi?id=80737

Patch by Scott Byer <scottbyer@chromium.org> on 2012-03-12
Reviewed by James Robinson.

.:

  • wscript:

Source/WebCore:

No new code.

  • GNUmakefile.list.am:
  • PlatformWinCE.cmake:
  • Target.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • platform/ScrollAnimatorWin.cpp: Removed.
  • platform/ScrollAnimatorWin.h: Removed.
14:15 Changeset [110477] by commit-queue@webkit.org

Make texImage2D error for wrong size ArrayBufferView more helpful
https://bugs.webkit.org/show_bug.cgi?id=80868

It took me about 30 minutes to figure out my texImage2D was failing
not because my ArrayBufferView was too small but because the default
alignment is 4. A better error message might help devs find this issue
faster.

Patch by Gregg Tavares <gman@google.com> on 2012-03-12
Reviewed by Kenneth Russell.

No new tests as no new functionality.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::validateTexFuncData):

14:08 Changeset [110476] by dglazkov@chromium.org

4 shadow DOM tests fail on Mac port
https://bugs.webkit.org/show_bug.cgi?id=80869

Reviewed by Ryosuke Niwa.

  • fast/dom/shadow/content-element-move.html: Changed to use ensureShadowRoot.
  • fast/dom/shadow/iframe-shadow.html: Changed to use WebKitShadowRoot polyfil.
  • fast/dom/shadow/resources/polyfill.js: Added.
  • fast/dom/shadow/shadow-on-image.html: Changed to use WebKitShadowRoot polyfil.
  • platform/wk2/Skipped: Added a test that should have been skipped when landed.
14:07 Changeset [110475] by alexis.menard@openbossa.org

Update include path of the test scripts after r110470.

Reviewed by Philippe Normand.

  • fast/dom/HTMLSelectElement/select-selectedIndex-multiple.html:
  • fast/dom/HTMLSelectElement/select-selectedIndex.html:
  • fast/dom/HTMLSelectElement/select-selectedOptions.html:
14:04 Changeset [110474] by adamk@chromium.org

Add test expectations accidentally left out of r110465.

  • fast/mutation/delivery-order-expected.txt: Added.
14:01 Changeset [110473] by cevans@google.com

Merge 110139
BUG=117226

13:47 Changeset [110472] by rniwa@webkit.org

Mac rebaseline. Offset is always 700px now.

  • platform/mac/fast/events/scrollbar-double-click-expected.txt: Removed.
  • platform/win/fast/events/scrollbar-double-click-expected.txt: Removed.
13:43 Changeset [110471] by eae@chromium.org

Merge trunk changes up intil r110435 into subpixel branch.

13:33 Changeset [110470] by alexis.menard@openbossa.org

Move <select> related layout tests in the place they should be.

Reviewed by Andreas Kling.

  • fast/dom/HTMLSelectElement/select-selectedIndex-bug-12942-expected.txt: Added.
  • fast/dom/HTMLSelectElement/select-selectedIndex-bug-12942.html: Added.
  • fast/dom/HTMLSelectElement/select-selectedIndex-expected.txt: Added.
  • fast/dom/HTMLSelectElement/select-selectedIndex-multiple-expected.txt: Added.
  • fast/dom/HTMLSelectElement/select-selectedIndex-multiple.html: Added.
  • fast/dom/HTMLSelectElement/select-selectedIndex.html: Added.
  • fast/dom/HTMLSelectElement/select-selectedOptions-expected.txt: Added.
  • fast/dom/HTMLSelectElement/select-selectedOptions.html: Added.
  • fast/dom/select-selectedIndex-bug-12942-expected.txt: Removed.
  • fast/dom/select-selectedIndex-bug-12942.html: Removed.
  • fast/dom/select-selectedIndex-expected.txt: Removed.
  • fast/dom/select-selectedIndex-multiple-expected.txt: Removed.
  • fast/dom/select-selectedIndex-multiple.html: Removed.
  • fast/dom/select-selectedIndex.html: Removed.
  • fast/dom/select-selectedOptions-expected.txt: Removed.
  • fast/dom/select-selectedOptions.html: Removed.
13:26 Changeset [110469] by timothy_horton@apple.com

Infinite repaint loop with SVGImageCache and deferred repaint timers
https://bugs.webkit.org/show_bug.cgi?id=78315
<rdar://problem/10651634>

Reviewed by Nikolas Zimmermann.

Only defer image redraw on a timer if we're in layout. This breaks
the repaint loop while still preventing us from drawing inside layout.

Completely disable repaint during relayout inside SVGImage::drawSVGToImageBuffer,
preventing deferred repaint timers from being started during that process.

No new tests, as the problem only occurs in a nonstandard configuration.

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::endDeferredRepaints):
(WebCore::FrameView::startDeferredRepaintTimer):
(WebCore):
(WebCore::FrameView::doDeferredRepaints):
(WebCore::FrameView::deferredRepaintTimerFired):
(WebCore::FrameView::beginDisableRepaints):
(WebCore::FrameView::endDisableRepaints):

  • page/FrameView.h:

(FrameView):
(WebCore::FrameView::repaintsDisabled):

  • rendering/RenderView.cpp:

(WebCore::RenderView::shouldRepaint):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawSVGToImageBuffer):
(WebCore::SVGImage::draw):
(WebCore::SVGImage::frameView):
(WebCore):

  • svg/graphics/SVGImage.h:

(WebCore):

  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::imageContentChanged):
(WebCore::SVGImageCache::redraw):
(WebCore::SVGImageCache::redrawTimerFired):
(WebCore):

  • svg/graphics/SVGImageCache.h:

(SVGImageCache):

13:26 Changeset [110468] by dgrogan@chromium.org

IndexedDB: layout test style update
https://bugs.webkit.org/show_bug.cgi?id=80555

Change layoutTestController.waitUntilDone to var jsTestIsAsync = true
and idb-specific done() to finishJSTest();

Following the uniform style results in less overall code and makes
them easier to convert to worker layout tests.

Reviewed by Tony Chang.

  • storage/indexeddb/constants.html:
  • storage/indexeddb/create-and-remove-object-store.html:
  • storage/indexeddb/create-object-store-options.html:
  • storage/indexeddb/createObjectStore-name-argument-required.html:
  • storage/indexeddb/createObjectStore-null-name.html:
  • storage/indexeddb/cursor-continue.html:
  • storage/indexeddb/cursor-delete.html:
  • storage/indexeddb/cursor-inconsistency.html:
  • storage/indexeddb/cursor-index-delete.html:
  • storage/indexeddb/cursor-key-order.html:
  • storage/indexeddb/cursor-primary-key-order.html:
  • storage/indexeddb/cursor-reverse-bug.html:
  • storage/indexeddb/cursor-skip-deleted.html:
  • storage/indexeddb/cursor-update-value-argument-required.html:
  • storage/indexeddb/cursor-update.html:
  • storage/indexeddb/data-corruption.html:
  • storage/indexeddb/database-basics.html:
  • storage/indexeddb/database-name-undefined.html:
  • storage/indexeddb/database-odd-names.html:
  • storage/indexeddb/database-quota.html:
  • storage/indexeddb/delete-closed-database-object.html:
  • storage/indexeddb/delete-range.html:
  • storage/indexeddb/deleteIndex.html:
  • storage/indexeddb/deleteObjectStore-name-argument-required.html:
  • storage/indexeddb/deleteObjectStore-null-name.html:
  • storage/indexeddb/duplicates.html:
  • storage/indexeddb/error-causes-abort-by-default.html:
  • storage/indexeddb/exception-in-event-aborts-expected.txt:
  • storage/indexeddb/exception-in-event-aborts.html:
  • storage/indexeddb/factory-basics.html:
  • storage/indexeddb/factory-cmp.html:
  • storage/indexeddb/factory-deletedatabase-interactions.html:
  • storage/indexeddb/factory-deletedatabase.html:
  • storage/indexeddb/index-count.html:
  • storage/indexeddb/index-cursor.html:
  • storage/indexeddb/index-get-key-argument-required.html:
  • storage/indexeddb/index-multientry.html:
  • storage/indexeddb/index-unique.html:
  • storage/indexeddb/invalid-keys.html:
  • storage/indexeddb/key-generator.html:
  • storage/indexeddb/key-sort-order-across-types.html:
  • storage/indexeddb/key-sort-order-date.html:
  • storage/indexeddb/key-type-array.html:
  • storage/indexeddb/key-type-infinity.html:
  • storage/indexeddb/keypath-basics.html:
  • storage/indexeddb/keypath-edges.html:
  • storage/indexeddb/keypath-fetch-key.html:
  • storage/indexeddb/keyrange-required-arguments.html:
  • storage/indexeddb/keyrange.html:
  • storage/indexeddb/list-ordering.html:
  • storage/indexeddb/mozilla/add-twice-failure.html:
  • storage/indexeddb/mozilla/autoincrement-indexes.html:
  • storage/indexeddb/mozilla/bad-keypath.html:
  • storage/indexeddb/mozilla/clear.html:
  • storage/indexeddb/mozilla/create-index-unique.html:
  • storage/indexeddb/mozilla/create-index-with-integer-keys.html:
  • storage/indexeddb/mozilla/create-objectstore-basics.html:
  • storage/indexeddb/mozilla/create-objectstore-null-name.html:
  • storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html:
  • storage/indexeddb/mozilla/cursor-mutation.html:
  • storage/indexeddb/mozilla/cursor-update-updates-indexes.html:
  • storage/indexeddb/mozilla/cursors.html:
  • storage/indexeddb/mozilla/delete-result.html:
  • storage/indexeddb/mozilla/event-source.html:
  • storage/indexeddb/mozilla/global-data.html:
  • storage/indexeddb/mozilla/indexes.html:
  • storage/indexeddb/mozilla/key-requirements-delete-null-key.html:
  • storage/indexeddb/mozilla/key-requirements-inline-and-passed.html:
  • storage/indexeddb/mozilla/key-requirements-put-no-key.html:
  • storage/indexeddb/mozilla/key-requirements-put-null-key.html:
  • storage/indexeddb/mozilla/key-requirements.html:
  • storage/indexeddb/mozilla/object-cursors.html:
  • storage/indexeddb/mozilla/object-identity.html:
  • storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put.html:
  • storage/indexeddb/mozilla/object-store-remove-values.html:
  • storage/indexeddb/mozilla/objectstorenames.html:
  • storage/indexeddb/mozilla/odd-result-order.html:
  • storage/indexeddb/mozilla/open-database-null-name.html:
  • storage/indexeddb/mozilla/put-get-values.html:
  • storage/indexeddb/mozilla/readonly-transactions.html:
  • storage/indexeddb/mozilla/readwrite-transactions.html:
  • storage/indexeddb/mozilla/readyState.html:
  • storage/indexeddb/mozilla/remove-index.html:
  • storage/indexeddb/mozilla/remove-objectstore.html:
  • storage/indexeddb/mozilla/versionchange-abort.html:
  • storage/indexeddb/mozilla/versionchange.html:
  • storage/indexeddb/mutating-cursor.html:
  • storage/indexeddb/objectStore-required-arguments.html:
  • storage/indexeddb/objectstore-autoincrement.html:
  • storage/indexeddb/objectstore-clear.html:
  • storage/indexeddb/objectstore-count.html:
  • storage/indexeddb/objectstore-cursor.html:
  • storage/indexeddb/objectstore-removeobjectstore.html:
  • storage/indexeddb/odd-strings.html:
  • storage/indexeddb/open-close-version.html:
  • storage/indexeddb/open-cursor.html:
  • storage/indexeddb/open-during-transaction.html:
  • storage/indexeddb/queued-commands.html:
  • storage/indexeddb/readonly-properties.html:
  • storage/indexeddb/readonly.html:
  • storage/indexeddb/request-event-propagation.html:
  • storage/indexeddb/resources/shared.js:

(unexpectedSuccessCallback):
(unexpectedErrorCallback):
(unexpectedAbortCallback):
(unexpectedCompleteCallback):
(unexpectedBlockedCallback):

  • storage/indexeddb/setVersion-null.html:
  • storage/indexeddb/setVersion-undefined.html:
  • storage/indexeddb/set_version_blocked.html:
  • storage/indexeddb/set_version_queue.html:
  • storage/indexeddb/structured-clone.html:
  • storage/indexeddb/transaction-abort-with-js-recursion-cross-frame.html:
  • storage/indexeddb/transaction-abort-with-js-recursion.html:
  • storage/indexeddb/transaction-abort.html:
  • storage/indexeddb/transaction-after-close.html:
  • storage/indexeddb/transaction-and-objectstore-calls.html:
  • storage/indexeddb/transaction-crash-on-abort.html:
  • storage/indexeddb/transaction-event-propagation.html:
  • storage/indexeddb/transaction-read-only.html:
  • storage/indexeddb/transaction-rollback.html:
  • storage/indexeddb/transaction-storeNames-required.html:
  • storage/indexeddb/two-version-changes.html:
  • storage/indexeddb/value-undefined.html:
  • storage/indexeddb/values-odd-types.html:
  • storage/indexeddb/version-change-abort-expected.txt:
  • storage/indexeddb/version-change-abort.html:
  • storage/indexeddb/version-change-exclusive.html:
  • storage/indexeddb/versionchangerequest-activedomobject.html:
13:25 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
13:24 Changeset [110467] by jamesr@google.com

Merge 109263 - [chromium] Don't let invalidation for next frame prevent tile upload
https://bugs.webkit.org/show_bug.cgi?id=79841

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-29
Reviewed by James Robinson.

Source/WebCore:

We currently don't push dirty tiles to the impl thread so there are no
tiles with garbage data on the impl thread. However, this judgement is
overzealous and blocks tiles that get invalidated by WebKit for the
next frame during the paint of the current frame.

Instead, check if a tile is dirty and was not painted for the current
frame when deciding to push the tile to the impl thread. This requires
that we know if a tile was painted during the current frame, which we
can do if we always reset m_updateRect to be empty each frame.

New unit tests: TiledLayerChromiumTest.pushTilesMarkedDirtyDuringPaint

TiledLayerChromiumTest.pushTilesLayerMarkedDirtyDuringPaintOnNextLayer
TiledLayerChromiumTest.pushTilesLayerMarkedDirtyDuringPaintOnPreviousLayer

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::UpdatableTile::isDirtyForCurrentFrame):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::resetUpdateState):
(WebCore):
(WebCore::TiledLayerChromium::prepareToUpdate):

  • platform/graphics/chromium/TiledLayerChromium.h:

(TiledLayerChromium):

Source/WebKit/chromium:

  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9697001

13:21 Changeset [110466] by rniwa@webkit.org

Mac rebaseline.

  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
13:11 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
13:11 Changeset [110465] by adamk@chromium.org

[MutationObservers] Enforce a consistent order of MutationRecord delivery
https://bugs.webkit.org/show_bug.cgi?id=80549

Reviewed by Ojan Vafai.

Source/WebCore:

Mutations should be delivered in order of creation.

Tests: fast/mutation/create-during-delivery.html

fast/mutation/delivery-order.html
fast/mutation/mutate-during-delivery.html

  • dom/WebKitMutationObserver.cpp:

(WebCore):
(WebCore::WebKitMutationObserver::ObserverLessThan::operator()): Functor for use with std::sort.
(WebCore::WebKitMutationObserver::create):
(WebCore::WebKitMutationObserver::WebKitMutationObserver):
(WebCore::WebKitMutationObserver::deliverAllMutations): Move observers into a sorted vector before delivery.

  • dom/WebKitMutationObserver.h: Add a "priority" member which monotonically increases with each construction.

LayoutTests:

  • fast/mutation/create-during-delivery-expected.txt: Added.
  • fast/mutation/create-during-delivery.html: Added.
  • fast/mutation/delivery-order.html: Added.
  • fast/mutation/mutate-during-delivery-expected.txt: Added.
  • fast/mutation/mutate-during-delivery.html: Added.
13:08 Changeset [110464] by nduca@chromium.org

[Chromium] Force compositeAndReadback through regular scheduling flow
https://bugs.webkit.org/show_bug.cgi?id=77049

Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/cc/CCFrameRateController.cpp:

(WebCore::CCFrameRateController::onTimerTick):

  • platform/graphics/chromium/cc/CCFrameRateController.h:

(CCFrameRateControllerClient):

  • platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::setNeedsForcedCommit):
(WebCore):
(WebCore::CCScheduler::vsyncTick):

  • platform/graphics/chromium/cc/CCScheduler.h:

(CCScheduler):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::nextAction):
(WebCore::CCSchedulerStateMachine::updateState):
(WebCore::CCSchedulerStateMachine::setNeedsForcedCommit):
(WebCore):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.h:

(CCSchedulerStateMachine):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::requestReadbackOnImplThread):
(WebCore::CCThreadProxy::forceBeginFrameOnImplThread):
(WebCore::CCThreadProxy::scheduledActionBeginFrame):
(WebCore::CCThreadProxy::beginFrame):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):
(WebCore::CCThreadProxy::BeginFrameAndCommitState::BeginFrameAndCommitState):
(BeginFrameAndCommitState):

Source/WebKit/chromium:

  • tests/CCFrameRateControllerTest.cpp:

(WebKitTests::FakeCCFrameRateControllerClient::reset):
(WebKitTests::FakeCCFrameRateControllerClient::vsyncTicked):
(WebKitTests::FakeCCFrameRateControllerClient::vsyncTick):
(FakeCCFrameRateControllerClient):
(WebKitTests::TEST):

  • tests/CCLayerTreeHostTest.cpp:

(WTF):
(CCLayerTreeHostTestCompositeAndReadbackWhileInvisible):
(WTF::CCLayerTreeHostTestCompositeAndReadbackWhileInvisible::CCLayerTreeHostTestCompositeAndReadbackWhileInvisible):
(WTF::CCLayerTreeHostTestCompositeAndReadbackWhileInvisible::beginTest):
(WTF::CCLayerTreeHostTestCompositeAndReadbackWhileInvisible::didCommitAndDrawFrame):
(WTF::CCLayerTreeHostTestCompositeAndReadbackWhileInvisible::afterTest):
(WTF::TEST_F):

  • tests/CCSchedulerStateMachineTest.cpp:

(WebCore::StateMachine::setNeedsForcedCommit):
(WebCore::StateMachine::needsForcedCommit):
(StateMachine):
(WebCore::TEST):
(WebCore):

12:57 Changeset [110463] by jsbell@chromium.org

IndexedDB: Handle LevelDB database corruption
https://bugs.webkit.org/show_bug.cgi?id=79413

Source/WebCore:

Add LevelDBDatabase::destroy() method so that clients can retry if open() fails.

Reviewed by Tony Chang.

Test: webkit_unit_tests --gtest_filter='LevelDBDatabaseTest.CorruptionTest'

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp: Implement open/destroy/open strategy.

(WebCore::IDBLevelDBBackingStore::open):

  • platform/leveldb/LevelDBDatabase.cpp:

(WebCore::LevelDBDatabase::destroy):
(WebCore):

  • platform/leveldb/LevelDBDatabase.h:

(LevelDBDatabase):

Source/WebKit/chromium:

Reviewed by Tony Chang.

  • WebKit.gyp: Skip LevelDBTest.cpp in shared component builds due to webkit_support dependency
  • WebKit.gypi: Add LevelDBTest.cpp
  • tests/LevelDBTest.cpp: Added.

(WebCore):
(SimpleComparator):
(WebCore::SimpleComparator::compare):
(WebCore::SimpleComparator::name):
(WebCore::encodeString):
(WebCore::TEST):

12:55 Changeset [110462] by cevans@google.com

Merge 110332
BUG=114056
Review URL: https://chromiumcodereview.appspot.com/9689022

12:52 Changeset [110461] by cevans@google.com

Merge 110324
BUG=116746
Review URL: https://chromiumcodereview.appspot.com/9693006

12:50 Changeset [110460] by peter@chromium.org

[Chromium] Temporary build-fix for the Android bot
https://bugs.webkit.org/show_bug.cgi?id=80862

Reviewed by Adam Barth.

Manually set the environmental variables required to compile source
files through the Android NDK instead of relying on the envsetup.sh
script. A proper fix will be landed to Chromium ASAP, and following
a Chromium roll into WebKit this code will be removed.

  • Scripts/webkitdirs.pm:

(buildChromiumMakefile):

12:47 Changeset [110459] by cevans@google.com

Merge 110323
BUG=113902
Review URL: https://chromiumcodereview.appspot.com/9695005

12:44 Changeset [110458] by vestbo@webkit.org

[Qt] Use right construct to detect config_test_gccdepends

Reviewed by Andreas Kling.

12:44 Changeset [110457] by vestbo@webkit.org

[Qt] Expose location of WebKit's bin and imports dir through module file

Reviewed by Andreas Kling.

12:24 Changeset [110456] by shawnsingh@chromium.org

Fix regression on fast/table/table-row-compositing-repaint-crash.html
https://bugs.webkit.org/show_bug.cgi?id=80804

Reviewed by Simon Fraser.

Covered by existing tests.

http://trac.webkit.org/changeset/110401/ accidentally caused
fast/table/table-row-compositing-repaint-crash.html to fail.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateBacking):

12:20 Changeset [110455] by mikelawther@chromium.org

CSS3 calc: enable mixed percent/absolute for font
https://bugs.webkit.org/show_bug.cgi?id=80813

Reviewed by Ojan Vafai.

Source/WebCore:

Add support for mixed percent/absolute expressions to the font handling class.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyFontSize::applyValue):

LayoutTests:

  • css3/calc/font-expected.txt:
  • css3/calc/font-size-expected.txt:
12:19 Changeset [110454] by cevans@google.com

Merge 110326
BUG=116461
Review URL: https://chromiumcodereview.appspot.com/9677005

12:18 Changeset [110453] by laszlo.1.gombos@nokia.com

Minor DataLog fixes
https://bugs.webkit.org/show_bug.cgi?id=80826

Reviewed by Andreas Kling.

  • bytecode/ExecutionCounter.cpp:

Do not include DataLog.h, it is not used.

  • jit/ExecutableAllocator.cpp:

Ditto.

  • wtf/DataLog.cpp:

(WTF::initializeLogFileOnce):
Add missing semi-colon to the code path where DATA_LOG_FILENAME is defined.

  • wtf/HashTable.cpp:

Include DataLog as it is used.

12:00 Changeset [110452] by cevans@google.com

Merge 108084
BUG=112411
Review URL: https://chromiumcodereview.appspot.com/9694004

11:58 Changeset [110451] by reed@google.com

update expectations in preparation for bitmap-sampling fix in skia
https://bugs.webkit.org/show_bug.cgi?id=80837

Unreviewed

  • platform/chromium/test_expectations.txt:
11:51 Changeset [110450] by kling@webkit.org

Restore Attr::style() functionality.
<http://webkit.org/b/80678>
<rdar://problem/10933904>

Reviewed by Antti Koivisto.

The neutering of Attr::style() in r106740 broke some internal clients of the Obj-C API,
so this was definitely premature.

Since we no longer have a per-Attribute style object, synthesize one in style() and
hang it off of the Attr. This grows Attr by one pointer, but it's a low-volume object
so it shouldn't matter much.

We recreate the StylePropertySet object on every call to style(), to avoid complicating
things with custom invalidation code.

  • dom/Attr.cpp:

(WebCore::Attr::style):

  • dom/Attr.h:
  • dom/StyledElement.h:

(WebCore::StyledElement::collectStyleForAttribute):

11:38 Changeset [110449] by rniwa@webkit.org

REGRESSION(r109285): Crash in WebCore::Document::nodeChildrenWillBeRemoved
https://bugs.webkit.org/show_bug.cgi?id=80578

Reviewed by Andreas Kling.

Source/WebCore:

Test: svg/css/style-change-crash.html

  • dom/Element.cpp:

(WebCore::Element::setAttribute):
(WebCore::Element::setAttributeInternal):

  • dom/Element.h:

(Element):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::addAttribute):
(WebCore::ElementAttributeData::removeAttribute):

  • dom/ElementAttributeData.h:

(ElementAttributeData):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::updateStyleAttribute):

LayoutTests:

  • fast/regions/select-in-region-crash-expected.txt: Rebaselined.
  • svg/css/style-change-crash-expected.txt: Added.
  • svg/css/style-change-crash.html: Added.
11:28 Changeset [110448] by commit-queue@webkit.org

Touch event handler count is not updated when adding handlers to the window.
https://bugs.webkit.org/show_bug.cgi?id=80756

Source/WebCore:

Touch event handlers added to the window needs to be included when counting the number of touch event
handlers. This makes touch event handler counting identical to wheel event handler counting.

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-03-12
Reviewed by Anders Carlsson.

Test: fast/events/touch/touch-handler-count.html

  • dom/EventNames.h:

(EventNames):
(WebCore::EventNames::isTouchEventType):

  • dom/Node.cpp:

(WebCore):
(WebCore::tryAddEventListener):
(WebCore::tryRemoveEventListener):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):

  • testing/Internals.cpp:

(WebCore::Internals::touchEventHandlerCount):
(WebCore):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

LayoutTests:

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-03-12
Reviewed by Anders Carlsson.

The new layout tests add and remove touch event handlers on the window, document, and a div in the
document, and tests that the count is updated correctly when handlers are added and/or removed.

  • fast/events/touch/touch-handler-count-expected.txt: Added.
  • fast/events/touch/touch-handler-count.html: Added.
11:02 Changeset [110447] by abecsi@webkit.org

[Qt][WK2] Add support for rudimentary scroll indicators in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=80832

Reviewed by Tor Arne Vestbø.

Source/WebKit2:

Since the ScrollDecorator QML component requires a Flickable in its API
we need to expose the Flickable in QML for now and we also need to add
a notifier because we instantiate the internal Flickable only when the
WebView component completes construction.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebViewExperimental::flickable):

  • UIProcess/API/qt/qquickwebview_p.h:

Tools:

Add a basic scroll indicator component to MiniBrowser so that it
behaves similar to the ScrollDecorator QML component.

  • MiniBrowser/qt/MiniBrowser.qrc:
  • MiniBrowser/qt/qml/BrowserWindow.qml:
  • MiniBrowser/qt/qml/ScrollIndicator.qml: Added.
10:50 Changeset [110446] by commit-queue@webkit.org

[GTK] r110296 included an extra $ in @$(AM_V_GEN)
https://bugs.webkit.org/show_bug.cgi?id=80809

Patch by C Anthony Risinger <anthony@xtfx.me> on 2012-03-12
Reviewed by Philippe Normand.

  • GNUmakefile.am: Add $ to @(AM_V_GEN), else /bin/sh syntax error
10:43 Changeset [110445] by podivilov@chromium.org

Web Inspector: extract ResourceScriptMapping from MainScriptMapping.
https://bugs.webkit.org/show_bug.cgi?id=80834

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/ScriptMapping.js:

(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeListChanged):
(WebInspector.ResourceScriptMapping.prototype.reset):
(WebInspector.MainScriptMapping):
(WebInspector.MainScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.MainScriptMapping.prototype.createLiveLocation):
(WebInspector.MainScriptMapping.prototype._registerLiveLocation):
(WebInspector.MainScriptMapping.prototype._unregisterLiveLocation):
(WebInspector.MainScriptMapping.prototype._updateLiveLocations):
(WebInspector.MainScriptMapping.prototype.uiSourceCodeList):
(WebInspector.MainScriptMapping.prototype.addScript):
(WebInspector.MainScriptMapping.prototype._handleUISourceCodeListChanged):
(WebInspector.MainScriptMapping.prototype.setFormatSource):
(WebInspector.MainScriptMapping.prototype.forceUpdateSourceMapping):
(WebInspector.MainScriptMapping.prototype.reset):

10:42 Changeset [110444] by ericu@chromium.org

[Chromium] fast/filesystem/op-restricted-chars.html fails on Windows
https://bugs.webkit.org/show_bug.cgi?id=75110

Reviewed by Ryosuke Niwa.

Remove expectation now that it's fixed.

  • platform/chromium/test_expectations.txt:
10:31 Changeset [110443] by commit-queue@webkit.org

Integer overflow check code in arithmetic operation in classic interpreter
https://bugs.webkit.org/show_bug.cgi?id=80465

Patch by SangGyu Lee <sg5.lee@samsung.com> on 2012-03-12
Reviewed by Gavin Barraclough.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

10:17 Changeset [110442] by philn@webkit.org

Unreviewed, unskip a media test in GTK.

  • platform/gtk/Skipped: media/video-volume-slider.html was fixed

in r86535.

  • platform/gtk/media/video-volume-slider-expected.txt:
10:14 Changeset [110441] by pfeldman@chromium.org

Web Inspector: recognize Float*Array and Int*Array as arrays.
https://bugs.webkit.org/show_bug.cgi?id=80850

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: inspector/console/console-external-array.html

  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::type):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::typeCallback):

LayoutTests:

  • inspector/console/console-external-array-expected.txt: Added.
  • inspector/console/console-external-array.html: Added.
10:13 Changeset [110440] by commit-queue@webkit.org

Add tests for dynamic attribute changes for mapping of lang/xml:lang to -webkit-locale
https://bugs.webkit.org/show_bug.cgi?id=80658

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-03-12
Reviewed by Alexey Proskuryakov.

  • fast/text/lang-mapped-to-webkit-locale-dynamic-expected.txt: Added.
  • fast/text/lang-mapped-to-webkit-locale-dynamic.xhtml: Added.
10:09 Changeset [110439] by jocelyn.turcotte@nokia.com

[TexMapGL] Pixel-align the transform of textures that fit pixel-for-pixel on the frame buffer.
https://bugs.webkit.org/show_bug.cgi?id=80848

Reviewed by Noam Rosenthal.

When rendering a transformed texture on the screen with a fractional
coordinate with linear filtering, the resulting pixel will be blended from
the texels around this fractional position according to their cover ratio.
This produces a slight blur of pixels which give no benefit when rendering
a texture that isn't scaled.

This patch offsets the transform by rounding the translation part of the
layer's transform to align the result to integer coordinates.
Applying the adjustment on the layer transform makes sure that all the tiles
get the same adjustment.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::drawTexture):

  • platform/graphics/texmap/TextureMapperGL.h:

(WebCore::BitmapTextureGL::textureSize):

10:08 Changeset [110438] by jocelyn.turcotte@nokia.com

[TexMapGL] Use textures sized exactly to their contents.
https://bugs.webkit.org/show_bug.cgi?id=80845

Reviewed by Noam Rosenthal.

This fixes a regression introduced in r108273 as well as the bug it fixed.
The regressing behavior was that textures were rendered shrunk by 1 pixel
and thus would appear blurry on the screen.
The original problem was that garbage contents would appear on filtered
textures since we would reuse textures of different sizes by giving them
a slightly bigger size.

This patch will reuse the texture only if the size matches exactly to allow
edge clamping to work properly when redering with linear filtering.
Reusing textures would only saves us the allocation of graphic memory
anyway, which is negligeable compared to texture upload.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::drawTexture):
(WebCore::BitmapTextureGL::didReset):

  • platform/graphics/texmap/TextureMapperGL.h:

(BitmapTextureGL):

  • platform/graphics/texmap/TextureMapperShaderManager.cpp:

(WebCore::TextureMapperShaderProgramOpacityAndMask::TextureMapperShaderProgramOpacityAndMask):
(WebCore::TextureMapperShaderProgramOpacityAndMask::prepare):

  • platform/graphics/texmap/TextureMapperShaderManager.h:

(TextureMapperShaderProgramOpacityAndMask):

10:06 Changeset [110437] by jocelyn.turcotte@nokia.com

[TexMap] Remove BitmapTexture::destroy.
https://bugs.webkit.org/show_bug.cgi?id=80844

Reviewed by Noam Rosenthal.

Use the destructor directly instead.

  • platform/graphics/texmap/TextureMapper.h:
  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::~BitmapTextureGL):

  • platform/graphics/texmap/TextureMapperGL.h:

(BitmapTextureGL):

  • platform/graphics/texmap/TextureMapperImageBuffer.h:

(WebCore::BitmapTextureImageBuffer::~BitmapTextureImageBuffer):

09:50 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
09:39 Changeset [110436] by vestbo@webkit.org

[Qt] Make sure we set the right library version for Qt 4

r110272 accedentally pruned the variable that ensures this.

Reviewed by Simon Hausmann.

09:06 Changeset [110435] by philn@webkit.org

Unreviewed, slight Skipped list reorganization and unskip a bunch
of inspector tests on GTK.

  • platform/gtk/Skipped:
08:56 Changeset [110434] by podivilov@chromium.org

Web Inspector: DebuggerModel.Location should have scriptId property.
https://bugs.webkit.org/show_bug.cgi?id=80830

Reviewed by Vsevolod Vlasov.

Source/WebCore:

  • inspector/front-end/CompilerSourceMapping.js:

(WebInspector.ClosureCompilerSourceMapping.prototype.sourceLocationToCompiledLocation):

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype.location):

  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.Location):
(WebInspector.DebuggerModel.prototype._failedToParseScriptSource):
(WebInspector.DebuggerModel.prototype.createRawLocation):
(WebInspector.DebuggerModel.prototype.createRawLocationByURL):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessageToScript):
(WebInspector.DebuggerPresentationModel.prototype._addPendingConsoleMessagesToScript):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype._uiSourceCodeForResource):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode.PlainSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.CompilerSourceMapping.prototype.uiLocationToRawLocation):

  • inspector/front-end/ScriptFormatter.js:

(WebInspector.ScriptFormatter.locationToPosition):
(WebInspector.ScriptFormatter.positionToLocation):
(WebInspector.FormattedSourceMapping.prototype.originalToFormatted):
(WebInspector.FormattedSourceMapping.prototype.formattedToOriginal):

LayoutTests:

  • http/tests/inspector/compiler-source-mapping.html:
  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • http/tests/inspector/search/search-in-concatenated-script.html:
  • http/tests/inspector/search/search-in-script.html:
  • inspector/debugger/debugger-scripts.html:
  • inspector/debugger/linkifier.html:
  • inspector/debugger/raw-source-code.html:
  • inspector/debugger/script-formatter.html:
08:50 Changeset [110433] by commit-queue@webkit.org

[chromium] Clean up culling tests and templatize to test impl constructs
https://bugs.webkit.org/show_bug.cgi?id=80613

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-12
Reviewed by Adrienne Walker.

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore::TestContentLayerChromium::TestContentLayerChromium):
(WebCore::TestContentLayerChromium::opaqueContentsRegion):
(WebCore::TestContentLayerChromium::setOpaqueContentsRect):
(TestContentLayerChromium):
(TestContentLayerImpl):
(WebCore::TestContentLayerImpl::TestContentLayerImpl):
(WebCore::TestContentLayerImpl::opaqueContentsRegion):
(WebCore::TestContentLayerImpl::setOpaqueContentsRect):
(WebCore):
(WebCore::TestCCOcclusionTrackerBase::TestCCOcclusionTrackerBase):
(WebCore::TestCCOcclusionTrackerBase::occlusionInScreenSpace):
(WebCore::TestCCOcclusionTrackerBase::occlusionInTargetSurface):
(WebCore::TestCCOcclusionTrackerBase::setOcclusionInScreenSpace):
(WebCore::TestCCOcclusionTrackerBase::setOcclusionInTargetSurface):
(WebCore::TestCCOcclusionTrackerBase::layerScissorRectInTargetSurface):
(WebCore::TestDamageClient::damageRect):
(CCOcclusionTrackerTestMainThreadTypes):
(WebCore::CCOcclusionTrackerTestMainThreadTypes::createLayer):
(WebCore::CCOcclusionTrackerTestMainThreadTypes::createContentLayer):
(CCOcclusionTrackerTestImplThreadTypes):
(WebCore::CCOcclusionTrackerTestImplThreadTypes::createLayer):
(WebCore::CCOcclusionTrackerTestImplThreadTypes::createContentLayer):
(CCOcclusionTrackerTest):
(WebCore::CCOcclusionTrackerTest::TearDown):
(WebCore::CCOcclusionTrackerTest::createRoot):
(WebCore::CCOcclusionTrackerTest::createLayer):
(WebCore::CCOcclusionTrackerTest::createSurface):
(WebCore::CCOcclusionTrackerTest::createDrawingLayer):
(WebCore::CCOcclusionTrackerTest::createDrawingSurface):
(WebCore::CCOcclusionTrackerTest::calcDrawEtc):
(WebCore::CCOcclusionTrackerTest::setBaseProperties):
(WebCore::CCOcclusionTrackerTest::setProperties):
(CCOcclusionTrackerTestIdentityTransforms):
(WebCore::CCOcclusionTrackerTestIdentityTransforms::runMyTest):
(CCOcclusionTrackerTestRotatedChild):
(WebCore::CCOcclusionTrackerTestRotatedChild::runMyTest):
(CCOcclusionTrackerTestTranslatedChild):
(WebCore::CCOcclusionTrackerTestTranslatedChild::runMyTest):
(CCOcclusionTrackerTestChildInRotatedChild):
(WebCore::CCOcclusionTrackerTestChildInRotatedChild::runMyTest):
(CCOcclusionTrackerTestVisitTargetTwoTimes):
(WebCore::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest):
(CCOcclusionTrackerTestSurfaceRotatedOffAxis):
(WebCore::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest):
(CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren):
(WebCore::CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren::runMyTest):
(CCOcclusionTrackerTestOverlappingSurfaceSiblings):
(WebCore::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
(CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms):
(WebCore::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
(CCOcclusionTrackerTestFilters):
(WebCore::CCOcclusionTrackerTestFilters::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectOutsideChild):
(WebCore::CCOcclusionTrackerTestLayerScissorRectOutsideChild::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectOutsideChild):
(WebCore::CCOcclusionTrackerTestScreenScissorRectOutsideChild::runMyTest):
(CCOcclusionTrackerTestDamageRectOutsideChild):
(WebCore::CCOcclusionTrackerTestDamageRectOutsideChild::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectOverChild):
(WebCore::CCOcclusionTrackerTestLayerScissorRectOverChild::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectOverChild):
(WebCore::CCOcclusionTrackerTestScreenScissorRectOverChild::runMyTest):
(CCOcclusionTrackerTestDamageRectOverChild):
(WebCore::CCOcclusionTrackerTestDamageRectOverChild::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectPartlyOverChild):
(WebCore::CCOcclusionTrackerTestLayerScissorRectPartlyOverChild::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectPartlyOverChild):
(WebCore::CCOcclusionTrackerTestScreenScissorRectPartlyOverChild::runMyTest):
(CCOcclusionTrackerTestDamageRectPartlyOverChild):
(WebCore::CCOcclusionTrackerTestDamageRectPartlyOverChild::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectOverNothing):
(WebCore::CCOcclusionTrackerTestLayerScissorRectOverNothing::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectOverNothing):
(WebCore::CCOcclusionTrackerTestScreenScissorRectOverNothing::runMyTest):
(CCOcclusionTrackerTestDamageRectOverNothing):
(WebCore::CCOcclusionTrackerTestDamageRectOverNothing::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectForLayerOffOrigin):
(WebCore::CCOcclusionTrackerTestLayerScissorRectForLayerOffOrigin::runMyTest):
(CCOcclusionTrackerTestOpaqueContentsRegionEmpty):
(WebCore::CCOcclusionTrackerTestOpaqueContentsRegionEmpty::runMyTest):
(CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty):
(WebCore::CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty::runMyTest):

08:47 Changeset [110432] by commit-queue@webkit.org

[chromium] A couple early-outs for occlusion tracker
https://bugs.webkit.org/show_bug.cgi?id=80742

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-12
Reviewed by Adrienne Walker.

Covered by existing tests.

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::occluded):
(WebCore::::unoccludedContentRect):

08:45 Changeset [110431] by zeno.albisser@nokia.com

[Qt][Mac] Build fails after adding WebCoreCFAutorelease(CFTypeRef) (r110360).
https://bugs.webkit.org/show_bug.cgi?id=80840

CoreFoundation/CFBase.h needs to be included to define the type CFTypeRef.

Reviewed by Tor Arne Vestbø.

  • platform/mac/WebCoreObjCExtras.h:
08:34 Changeset [110430] by zeno.albisser@nokia.com

[Qt][Mac] Build fails after enabling LLINT when JIT is disabled (r109863)
https://bugs.webkit.org/show_bug.cgi?id=80827

Qt on Mac uses OS(DARWIN) as well, but we do not want to enable LLINT.

Reviewed by Simon Hausmann.

  • wtf/Platform.h:
08:32 Changeset [110429] by staikos@webkit.org

Remove unused global static variable for BlackBerry.
https://bugs.webkit.org/show_bug.cgi?id=80790

Reviewed by Alexey Proskuryakov.

  • platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore):

08:28 Changeset [110428] by staikos@webkit.org

Correct usage of NDEBUG to fix warnings on BlackBerry.
https://bugs.webkit.org/show_bug.cgi?id=80790

Reviewed by Alexey Proskuryakov.

  • platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:

(WebCore::CookieDatabaseBackingStore::sendChangesToDatabase):

  • platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::initiateCookieLimitCleanUp):

07:52 Changeset [110427] by commit-queue@webkit.org

[BlackBerry] build-webkit doesn't recognize "--cmakearg" for the BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=80812

Patch by Ming Xie <mxie@rim.com> on 2012-03-12
Reviewed by Rob Buis.

  • Scripts/build-webkit: Add $cmakeArgs to buildCMakeProjectOrExit()
  • Scripts/webkitdirs.pm:

(blackberryCMakeArguments): Remove "PUBLIC_BUILD=0" define

07:43 Changeset [110426] by hausmann@webkit.org

Unreviewed prospective Qt/Mac build fix

  • runtime/JSGlobalData.cpp: use #USE(CF) instead of PLATFORM(MAC) to determine

whether to include CoreFoundation headers, used for JIT configuration in JSGlobalData
constructor.

07:36 Changeset [110425] by timothy@apple.com

Update how the Web Inspector resources are loaded.

https://bugs.webkit.org/show_bug.cgi?id=80814
rdar://problem/10359959

Reviewed by John Sullivan.

  • Shared/WebPreferencesStore.h:

(WebKit): Added InspectorUsesWebKitUserInterface.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode): Removed webInspectorLocalizedStringsPath.
(WebKit::WebProcessCreationParameters::decode): Ditto.

  • Shared/WebProcessCreationParameters.h: Ditto.

(WebProcessCreationParameters): Ditto.

  • UIProcess/API/C/WKContext.cpp:
  • UIProcess/API/C/WKContextPrivate.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetInspectorUsesWebKitUserInterface): Added.
(WKPreferencesGetInspectorUsesWebKitUserInterface): Added.

  • UIProcess/API/C/WKPreferencesPrivate.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureWebProcess): Removed webInspectorLocalizedStringsPath.

  • UIProcess/WebContext.h:

(WebContext): Ditto.

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::inspectorReallyUsesWebKitUserInterface): Added.
(WebKit::WebInspectorProxy::createInspectorWindow): Use inspectorReallyUsesWebKitUserInterface
to determine if texture should be used.
(WebKit::WebInspectorProxy::inspectorPageURL): Choose the right path.
(WebKit::WebInspectorProxy::inspectorBaseURL): Ditto.

  • WebProcess/WebPage/WebInspector.h:
  • WebProcess/WebPage/mac/WebInspectorMac.mm:

(WebKit::inspectorReallyUsesWebKitUserInterface):
(WebKit::WebInspector::setInspectorUsesWebKitUserInterface): Added.
(WebKit::WebInspector::localizedStringsURL):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformPreferencesDidChange): Call WebInspector::setInspectorUsesWebKitUserInterface.

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::platformInitializeWebProcess): Removed call to WebInspector::setLocalizedStringsPath.

07:33 Changeset [110424] by ossy@webkit.org

[Qt] REGRESSION(r110401): fast/table/table-row-compositing-repaint-crash.html asserts
https://bugs.webkit.org/show_bug.cgi?id=80833

Unreviewed gardening.

  • platform/qt/Skipped: Skip fast/table/table-row-compositing-repaint-crash.html to paint the bot green.
07:24 WebKit Team edited by yi.4.shen@nokia.com
(diff)
06:59 Changeset [110423] by loislo@chromium.org

Re-apply the patch after v8 roll to r11000.

Web Inspector: move heap snapshot nodes data to external array.
https://bugs.webkit.org/show_bug.cgi?id=79911

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Tests:
heap-shapshot.html
heap-shapshot-loader.html

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.Int32Array):
(WebInspector.Int32Array.prototype.get array):
(WebInspector.HeapSnapshotLoader.prototype._parseNodes):
(WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
(WebInspector.HeapSnapshot):
(WebInspector.HeapSnapshot.prototype._init):

LayoutTests:

  • inspector/profiler/heap-snapshot-loader.html:
  • inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockRaw):
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMock):
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockWithDOM):

05:57 Changeset [110422] by hausmann@webkit.org

[Qt] Fix build with newer Qt 5.

Reviewed by Tor Arne Vestbø.

Source/WebCore:

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::fileListNameForWidth): Use DefaultCodec instead of the
deprecated CodecForTR.

Tools:

Newer Qt 5 renames QDeclarativeFoo to QQmlFoo and provides backwards compatible
renames, which however do trigger a #warning. Until we _require_ a newer Qt 5
we should disable -Werror.

Also load(moc) for the availability of QMAKE_MOC in various derived sources. The
implicit load was removed recently.

  • qmake/mkspecs/features/default_pre.prf:
  • qmake/mkspecs/features/unix/default_post.prf:
05:31 Changeset [110421] by loislo@chromium.org

Web Inspector: chromium: increase heap snapshot performance coverage.
https://bugs.webkit.org/show_bug.cgi?id=80829

Reviewed by Yury Semikhatsky.

  • inspector/detailed-heapshots-smoke-test.html:
  • inspector/performance-test.js:

(initialize_TimeTracker.InspectorTest.measureFunction):

04:27 Changeset [110420] by hans@chromium.org

Speech JavaScript API: SpeechRecognitionEvent
https://bugs.webkit.org/show_bug.cgi?id=80513

Reviewed by Adam Barth.

Source/WebCore:

Implement SpeechRecognitionEvent.
(Spec: http://speech-javascript-api-spec.googlecode.com/git/speechapi.html)

Test: fast/events/constructors/speech-recognition-event-constructor.html

  • Modules/speech/DOMWindowSpeech.idl:
  • Modules/speech/SpeechRecognitionEvent.cpp: Added.

(WebCore):
(WebCore::SpeechRecognitionEventInit::SpeechRecognitionEventInit):
(WebCore::SpeechRecognitionEvent::create):
(WebCore::SpeechRecognitionEvent::createResult):
(WebCore::SpeechRecognitionEvent::createNoMatch):
(WebCore::SpeechRecognitionEvent::createResultDeleted):
(WebCore::SpeechRecognitionEvent::createError):
(WebCore::SpeechRecognitionEvent::interfaceName):
(WebCore::SpeechRecognitionEvent::SpeechRecognitionEvent):

  • Modules/speech/SpeechRecognitionEvent.h: Added.

(WebCore):
(SpeechRecognitionEventInit):
(SpeechRecognitionEvent):
(WebCore::SpeechRecognitionEvent::result):
(WebCore::SpeechRecognitionEvent::error):
(WebCore::SpeechRecognitionEvent::resultIndex):
(WebCore::SpeechRecognitionEvent::resultHistory):

  • Modules/speech/SpeechRecognitionEvent.idl:
  • WebCore.gypi:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitSpeechRecognitionEventEnabled):

  • bindings/v8/OptionsObject.cpp:

(WebCore::OptionsObject::get):
(WebCore):

  • bindings/v8/OptionsObject.h:

(WebCore):
(OptionsObject):

  • dom/EventNames.h:

(WebCore):

  • dom/EventNames.in:

LayoutTests:

Add test for SpeechRecognitionEvent.
Update Skipped files for all ports except Chromium.

  • fast/events/constructors/speech-recognition-event-constructor-expected.txt: Added.
  • fast/events/constructors/speech-recognition-event-constructor.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
02:50 Changeset [110419] by fpizlo@apple.com

All DFG nodes should have a mutable set of flags
https://bugs.webkit.org/show_bug.cgi?id=80779
<rdar://problem/11026218>

Reviewed by Gavin Barraclough.

Got rid of NodeId, and placed all of the flags that distinguished NodeId
from NodeType into a separate Node::flags field. Combined what was previously
ArithNodeFlags into Node::flags.

In the process of debugging, I found that the debug support in the virtual
register allocator was lacking, so I improved it. I also realized that the
virtual register allocator was assuming that the nodes in a basic block were
contiguous, which is no longer the case. So I fixed that. The fix also made
it natural to have more extreme assertions, so I added them. I suspect this
will make it easier to catch virtual register allocation bugs in the future.

This is mostly performance neutral; if anything it looks like a slight
speed-up.

This patch does leave some work for future refactorings; for example, Node::op
is unencapsulated. This was already the case, though now it feels even more
like it should be. I avoided doing that because this patch has already grown
way bigger than I wanted.

Finally, this patch creates a DFGNode.cpp file and makes a slight effort to
move some unnecessarily inline stuff out of DFGNode.h.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • dfg/DFGArithNodeFlagsInferencePhase.cpp:

(JSC::DFG::ArithNodeFlagsInferencePhase::propagate):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addToGraph):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCFAPhase.cpp:

(JSC::DFG::CFAPhase::performBlockCFA):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::endIndexForPureCSE):
(JSC::DFG::CSEPhase::pureCSE):
(JSC::DFG::CSEPhase::clobbersWorld):
(JSC::DFG::CSEPhase::impureCSE):
(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::eliminate):
(JSC::DFG::CSEPhase::performNodeCSE):
(JSC::DFG::CSEPhase::performBlockCSE):
(CSEPhase):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::opName):
(JSC::DFG::Graph::dump):
(DFG):

  • dfg/DFGNode.cpp: Added.

(DFG):
(JSC::DFG::arithNodeFlagsAsString):

  • dfg/DFGNode.h:

(DFG):
(JSC::DFG::nodeUsedAsNumber):
(JSC::DFG::nodeCanTruncateInteger):
(JSC::DFG::nodeCanIgnoreNegativeZero):
(JSC::DFG::nodeMayOverflow):
(JSC::DFG::nodeCanSpeculateInteger):
(JSC::DFG::defaultFlags):
(JSC::DFG::Node::Node):
(Node):
(JSC::DFG::Node::setOpAndDefaultFlags):
(JSC::DFG::Node::mustGenerate):
(JSC::DFG::Node::arithNodeFlags):
(JSC::DFG::Node::setArithNodeFlag):
(JSC::DFG::Node::mergeArithNodeFlags):
(JSC::DFG::Node::hasResult):
(JSC::DFG::Node::hasInt32Result):
(JSC::DFG::Node::hasNumberResult):
(JSC::DFG::Node::hasJSResult):
(JSC::DFG::Node::hasBooleanResult):
(JSC::DFG::Node::isJump):
(JSC::DFG::Node::isBranch):
(JSC::DFG::Node::isTerminal):
(JSC::DFG::Node::child1):
(JSC::DFG::Node::child2):
(JSC::DFG::Node::child3):
(JSC::DFG::Node::firstChild):
(JSC::DFG::Node::numChildren):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::vote):
(JSC::DFG::PredictionPropagationPhase::fixupNode):

  • dfg/DFGScoreBoard.h:

(ScoreBoard):
(JSC::DFG::ScoreBoard::~ScoreBoard):
(JSC::DFG::ScoreBoard::assertClear):
(JSC::DFG::ScoreBoard::use):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::useChildren):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGVirtualRegisterAllocationPhase.cpp:

(JSC::DFG::VirtualRegisterAllocationPhase::run):

02:19 Changeset [110418] by caseq@chromium.org

Unreviewed, remove flakiness flags for timeline-start-time.html following a fix in r100417.
https://bugs.webkit.org/show_bug.cgi?id=80803

  • platform/chromium/test_expectations.txt:
02:02 Changeset [110417] by caseq@chromium.org

Unreviewed flakiness fix.

  • inspector/timeline/timeline-start-time.html:
01:59 Changeset [110416] by philn@webkit.org

Unreviewed, GTK rebaseline after r110409. And skip a new GTK
layout test failing after r110371.

  • platform/gtk/Skipped:
  • platform/gtk/fast/hidpi/video-controls-in-hidpi-expected.txt:
  • platform/gtk/fast/layers/video-layer-expected.txt:
  • platform/gtk/media/audio-controls-rendering-expected.txt:
  • platform/gtk/media/audio-repaint-expected.txt:
  • platform/gtk/media/controls-strict-expected.txt:
  • platform/gtk/media/controls-styling-expected.txt:
  • platform/gtk/media/controls-without-preload-expected.txt:
  • platform/gtk/media/media-controls-clone-expected.txt:
  • platform/gtk/media/media-document-audio-repaint-expected.txt:
  • platform/gtk/media/video-controls-rendering-expected.txt:
  • platform/gtk/media/video-empty-source-expected.txt:
  • platform/gtk/media/video-no-audio-expected.txt:
  • platform/gtk/media/video-zoom-controls-expected.txt:
01:52 Changeset [110415] by rolandsteiner@chromium.org

Unreviewed: Fix typos in fast/css/style-scoped/style-scoped-basic.html layout test.

  • fast/css/style-scoped/style-scoped-basic.html:
01:38 Changeset [110414] by tkent@chromium.org

Use ICU C API instead of C++ API in LocalizedNumberICU
https://bugs.webkit.org/show_bug.cgi?id=80815
https://bugs.gentoo.org/show_bug.cgi?id=407401

Reviewed by Hajime Morita.

ICU 4.8 doesn't have kNumberStyle. We had better to use ICU C API in
general to avoid such issues.

This patch should not make any behavior change.

  • platform/text/LocalizedNumberICU.cpp:

(WebCore::ICULocale::ICULocale):
Change the argument type: icu::Locale -> const char*
(WebCore::ICULocale::~ICULocale): Delete m_numberFormat with unum_close().
(WebCore::ICULocale::create): Do not create icu::Locale.
(WebCore::ICULocale::createForCurrentLocale): ditto.
(WebCore::ICULocale::setDecimalSymbol):
Use unum_getSymbol() instead of DecimalFormatSymbols::getSymbol().
(WebCore::ICULocale::setDecimalTextAttribute):
Added. A utility function to store prefixes and suffixes.
(WebCore::ICULocale::initializeDecimalFormat):

  • unum_open(), instead of NumberFormat::createInstance().
  • Use C API symbols.
  • Cache positive/negative prefixes/suffixes.

(WebCore::ICULocale::convertToLocalizedNumber): Use cached prefixes and suffixes.
(WebCore::matches): Stop using template because we don't use UString anymore.
(WebCore::ICULocale::detectSignAndGetDigitRange):

  • Use cached prefixes and suffixes.
  • Use String::startsWith() and endsWith().

(WebCore::ICULocale::convertFromLocalizedNumber):

  • platform/text/LocalizedNumberICU.h:

(ICULocale):

01:32 Changeset [110413] by podivilov@chromium.org

Web Inspector: decouple LiveLocation from RawSourceCode.
https://bugs.webkit.org/show_bug.cgi?id=80785

Reviewed by Vsevolod Vlasov.

Source/WebCore:

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.createPlacard):
(WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
(WebInspector.PresentationCallFrame):
(WebInspector.PresentationCallFrame.prototype.uiLocation):
(WebInspector.DebuggerPresentationModel.CallFramePlacard):

  • inspector/front-end/RawSourceCode.js:
  • inspector/front-end/ScriptMapping.js:

(WebInspector.MainScriptMapping):
(WebInspector.MainScriptMapping.prototype.createLiveLocation):
(WebInspector.MainScriptMapping.prototype._registerLiveLocation):
(WebInspector.MainScriptMapping.prototype._unregisterLiveLocation):
(WebInspector.MainScriptMapping.prototype._updateLiveLocations):
(WebInspector.MainScriptMapping.prototype._uiSourceCodeListChanged):
(WebInspector.MainScriptMapping.prototype.reset):
(WebInspector.LiveLocation):
(WebInspector.LiveLocation.prototype.init):
(WebInspector.LiveLocation.prototype.dispose):
(WebInspector.LiveLocation.prototype._update):

LayoutTests:

  • inspector/debugger/callstack-placards-discarded-expected.txt:
  • inspector/debugger/callstack-placards-discarded.html:
  • inspector/debugger/linkifier.html:
00:14 Changeset [110412] by aestes@apple.com

Remove unnecessary call to NSSizeToCGSize().
https://bugs.webkit.org/show_bug.cgi?id=80817

Reviewed by Dan Bernstein.

There is no need to call NSSizeToCGSize() to convert an IntSize to a
CGSize. IntSize defines a conversion function to CGSize that will do
this for us implicitly.

  • UIProcess/mac/BackingStoreMac.mm:

(WebKit::BackingStore::backingStoreContext): Do not call NSSizeToCGSize().

03/11/12:

23:07 Changeset [110411] by ukai@chromium.org

Unreviewed, update chromium test expectations.

  • platform/chromium/test_expectations.txt:
22:59 Changeset [110410] by ukai@chromium.org

Unreviewed, update chromium test expectations.

  • platform/chromium/test_expectations.txt:
21:47 Changeset [110409] by commit-queue@webkit.org

Source/WebCore: The main code structure for placing future text track cue rendering
code and main outer rendering steps.
https://bugs.webkit.org/show_bug.cgi?id=79746

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-03-11
Reviewed by Eric Carlson.

No new tests. Only refactoring, but some chromium tests require rebaselining
and have been marked accordingly.

  • css/mediaControls.css:

(::-webkit-media-controls): Changed the default display to -webkit-box, as
captions need to always be rendered on top of the controls, if they are visible.
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
Default position attribute is now relative, handled by the parent -webkit-box
(video::-webkit-media-text-track-container): The position of the container is
now relative, handled by -webkit-box.
(video::-webkit-media-text-track-display): Adjusted text color to match
the color required in the WebVTT spec (section 3.5.1 'color' property)

  • css/mediaControlsChromium.css:

(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
Default position attribute is now relative, handled by the parent -webkit-box

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::MediaControlPanelElement): Added a timer
for the webkit fade out transition event. This timer is required for setting
the display property to 'none', when the fade out transition is over. Otherwise,
captions would not be displayed at the bottom of the video.
(WebCore::MediaControlPanelElement::startTimer): Added.
(WebCore):
(WebCore::MediaControlPanelElement::stopTimer): Added.
(WebCore::MediaControlPanelElement::transitionTimerFired): Added. If the current
state of the controls is transparent, the display property is set to 'none'.
(WebCore::MediaControlPanelElement::makeOpaque): The inline display:'none' property
is removed before the fade in transition.
(WebCore::MediaControlPanelElement::makeTransparent): Added the timer start.
(WebCore::MediaControlTextTrackContainerElement::MediaControlTextTrackContainerElement):
Removed m_bottom as it is not needed anymore.
(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Added. Main
function for the rendering rules.
(WebCore::MediaControlTextTrackContainerElement::updateSizes): The bottom position
needs not to be set anymore.

  • html/shadow/MediaControlElements.h:

(MediaControlPanelElement): Added timer internals.
(MediaControlTextTrackContainerElement): Added updateDisplay() and removed unused
variables.

(WebCore):

  • html/shadow/MediaControlRootElement.cpp: Removed m_textTrackDisplay

and duplicated code with MediaControlRootElementChromium (only minimum
function calls to the main text track container)
(WebCore::MediaControlRootElement::MediaControlRootElement):
(WebCore::MediaControlRootElement::setMediaController):
(WebCore::MediaControlRootElement::createTextTrackDisplay):
(WebCore::MediaControlRootElement::updateTextTrackDisplay):

  • html/shadow/MediaControlRootElementChromium.cpp: Removed m_textTrackDisplay

and duplicate code with MediaControlRootElement (only minimum function calls
to the main text track container remained)
(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
(WebCore::MediaControlRootElementChromium::setMediaController):
(WebCore::MediaControlRootElementChromium::createTextTrackDisplay):
(WebCore::MediaControlRootElementChromium::updateTextTrackDisplay):

(WebCore):

  • html/track/TextTrackCue.cpp: Enhanced structure for supporting more complex

rendering required by the WebVTT spec.
(WebCore::TextTrackCue::TextTrackCue):
(WebCore::TextTrackCue::cueDidChange): Mark the display tree as obsolete, so that
it needs to be re-computed.
(WebCore::TextTrackCue::setIsActive): The display tree needs to be removed as
soon as the cue becomes inactive. Adjusted this method to support the functionality.
(WebCore):
(WebCore::TextTrackCue::determineDisplayParameters): Added. This method will hold
main positioning parameter computations for a TextTrackCue
(WebCore):
(WebCore::TextTrackCue::getDisplayTree): Added. This method returns the root node
of the CSS boxes that need to be displayed on top of the video, for the current
instance.

  • html/track/TextTrackCue.h:

(WebCore):
(TextTrackCue):

LayoutTests: Updated layout tests for basic rendering of cues.
Some Chromium tests require rebaselining and have been marked accordingly.

https://bugs.webkit.org/show_bug.cgi?id=79746

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-03-11
Reviewed by Eric Carlson.

  • media/media-controls.js: Adjusted helper function.

(mediaControlsElement):
(textTrackDisplayElement): If the method is called with only
one parameter, it returns the text track container instead of
a specific cue.

  • media/track/track-cue-mutable-text-expected.txt: Adjusted.
  • media/track/track-cue-nothing-to-render-expected.txt: Adjusted.
  • media/track/track-cue-rendering-expected.txt: Adjusted.
  • media/track/track-cue-rendering.html: Adjusted.
  • platform/chromium/test_expectations.txt: Marked tests that need to

be rebaselined accordingly.

21:04 Changeset [110408] by noel.gordon@gmail.com

Unreviewed gardening. Rebaseline svg/text/foreignObject-repaint.xml to close
out http://crbug.com/11483

  • platform/chromium-linux/svg/text/foreignObject-repaint-expected.png: Added.
  • platform/chromium/test_expectations.txt:
20:57 Changeset [110407] by ukai@chromium.org

Unreviewed, update chromium test expectations

  • platform/chromium/test_expectations.txt:
19:26 Changeset [110406] by ukai@chromium.org

Unreviewed, update chromium test expectations.

  • platform/chromium/test_expectations.txt:
18:29 Changeset [110405] by commit-queue@webkit.org

Unreviewed, rolling out r110359.
http://trac.webkit.org/changeset/110359
https://bugs.webkit.org/show_bug.cgi?id=80799

SelectPopupMenuTest.ClickItem failure (Requested by ukai on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-11

Source/WebCore:

  • platform/chromium/PopupListBox.cpp:

(WebCore::PopupListBox::paint):
(WebCore::PopupListBox::paintRow):
(WebCore::PopupListBox::getRowHeight):

  • platform/chromium/PopupListBox.h:

(PopupContainerSettings):

  • platform/chromium/PopupMenuChromium.cpp:

(WebCore):
(WebCore::PopupMenuChromium::show):

  • platform/chromium/PopupMenuChromium.h:

(PopupMenuChromium):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::showPopup):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::gestureEvent):
(WebKit::WebViewImpl::applyAutofillSuggestions):

18:29 Changeset [110404] by timothy@apple.com

Mac build fix.

18:14 Changeset [110403] by timothy@apple.com

Update how the Web Inspector resources are loaded.

https://bugs.webkit.org/show_bug.cgi?id=80798
rdar://problem/10359959

Reviewed by Brian Weinstein.

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj: Add a framework.

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.mm:

(useWebKitWebInspector): Return if we are using the WebCore resources for compatibility
with local and nightly builds.
(WebInspectorFrontendClient::localizedStringsURL): Decide what path to use.
(-[WebInspectorWindowController init]): Ditto.
(-[WebInspectorWindowController window]): Decide if the window is textured or not.

17:40 Changeset [110402] by timothy@apple.com

Fix a crash opening the Web Inspector in WebKit1 clients.

The call to InspectorFrontendClientLocal::setAttachedWindow is preformed really early in the process,
causing it to crash almost every time. It should use evaluateOnLoad instead of evaluateAsBoolean.

<rdar://problem/10951109> Crash when bringing up Web Inspector in WebKit1 client
https://bugs.webkit.org/show_bug.cgi?id=80796

Reviewed by Brian Weinstein.

  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::setAttachedWindow): Use evaluateOnLoad instead of evaluateAsBoolean.

15:17 Changeset [110401] by shawnsingh@chromium.org

REGRESSION (r93614): scrolling div does not repaint
https://bugs.webkit.org/show_bug.cgi?id=80641

Reviewed by Simon Fraser.

Source/WebCore:

Test: compositing/repaint/newly-composited-repaint-rect.html

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateBacking): When a layer
becomes newly composited and creates its backing, the repaintRect
may become invalid. This patch recomputes repaintRects in this
case.

LayoutTests:

  • compositing/repaint/newly-composited-repaint-rect-expected.png: Added.
  • compositing/repaint/newly-composited-repaint-rect-expected.txt: Added.
  • compositing/repaint/newly-composited-repaint-rect.html: Added.
15:07 Changeset [110400] by jochen@chromium.org

Merge 108780 - [v8] when a named item on document goes out of scope, actually remove it
https://bugs.webkit.org/show_bug.cgi?id=79409

Reviewed by Adam Barth.

Source/WebCore:

The original change already included the code, but it led to some
problems, so it was reverted in http://trac.webkit.org/changeset/63845.
However, not removing the items leaks a considerable amount of memory,
so I'm adding the code back. The bug that led to the revert was that
the accessor was removed unconditionally. I'm now only removing it,
when the last item with that name is removed.

Test: fast/dom/HTMLDocument/named-item.html

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::namedItemRemoved):

LayoutTests:

  • fast/dom/HTMLDocument/named-item-expected.txt: Added.
  • fast/dom/HTMLDocument/named-item.html: Added.

TBR=jochen@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9667038

13:12 Changeset [110399] by staikos@webkit.org

Enable JPEG encoding for BlackBerry.
https://bugs.webkit.org/show_bug.cgi?id=80792

Reviewed by Antonio Gomes.

  • PlatformBlackBerry.cmake:
12:52 Changeset [110398] by barraclough@apple.com

Inconsistent SyntaxError from new Function(...)
https://bugs.webkit.org/show_bug.cgi?id=59795

Rubber stamped by Oliver Hunt.

  • fast/js/function-constructor-error-expected.txt: Added.
  • fast/js/function-constructor-error.html: Added.
  • fast/js/script-tests/function-constructor-error.js: Added.
    • Adding test cases.
12:50 Changeset [110397] by mitz@apple.com

WebKit2 lacks API for obtaining a representation of the RenderLayer tree of a page, like WebRenderLayer
<http://webkit.org/b/80791>

Reviewed by Anders Carlsson.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • Shared/API/c/WKBase.h: Added a type definition of WKRenderLayerRef.
  • Shared/API/c/WKRenderLayer.cpp: Added.

(WKRenderLayerGetTypeID): Added. Returns the WKRenderLayer type ID.
(WKRenderLayerCopyRendererName): Added this getter wrapper.
(WKRenderLayerCopyElementTagName): Ditto.
(WKRenderLayerCopyElementID): Ditto.
(WKRenderLayerGetElementClassNames): Ditto.
(WKRenderLayerGetAbsoluteBounds): Ditto.
(WKRenderLayerIsClipping): Ditto.
(WKRenderLayerIsClipped): Ditto.
(WKRenderLayerIsReflection): Ditto.
(WKRenderLayerGetCompositingLayerType): Ditto.
(WKRenderLayerGetNegativeZOrderList): Ditto.
(WKRenderLayerGetNormalFlowList): Ditto.
(WKRenderLayerGetPositiveZOrderList): Ditto.

  • Shared/API/c/WKRenderLayer.h: Added.
  • Shared/APIObject.h: Added TypeRenderLayer to the APIObject::Type enum.
  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode): Added WebRenderLayer encoding.
(WebKit::UserMessageDecoder::baseDecode): Added WebRenderLayer decoding.

  • Shared/WebRenderLayer.cpp: Added.

(WebKit::WebRenderLayer::create): Added. Creates a WebRenderLayer for the page’s main
frame’s root layer.
(WebKit::WebRenderLayer::createArrayFromLayerList): Added this helper function.
(WebKit::WebRenderLayer::WebRenderLayer): Added. Constructs a WebRenderLayer with the
renderer name, element tag, ID and class names, metrics, child lists, and compositing
layer properties of the given RenderLayer.

  • Shared/WebRenderLayer.h: Added.

(WebKit::WebRenderLayer::create):
(WebKit::WebRenderLayer::negativeZOrderList):
(WebKit::WebRenderLayer::normalFlowList):
(WebKit::WebRenderLayer::positiveZOrderList):
(WebKit::WebRenderLayer::renderObjectName):
(WebKit::WebRenderLayer::elementTagName):
(WebKit::WebRenderLayer::elementID):
(WebKit::WebRenderLayer::elementClassNames):
(WebKit::WebRenderLayer::isReflection):
(WebKit::WebRenderLayer::isClipping):
(WebKit::WebRenderLayer::isClipped):
(WebKit::WebRenderLayer::compositingLayerType):
(WebKit::WebRenderLayer::absoluteBoundingBox):
(WebKit::WebRenderLayer::WebRenderLayer):

  • Target.pri
  • UIProcess/API/C/WKAPICast.h: Added a mapping between WKRenderLayerRef and WebRenderLayer.
  • WebKit2.xcodeproj/project.pbxproj: Added WebRenderLayer.{cpp,h} and WKRenderLayer.{cpp,h}.
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageCopyRenderLayerTree): Added this bundle API for getting the layer tree.

  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
  • win/WebKit2.vcproj:
11:58 Changeset [110396] by barraclough@apple.com

Source/JavaScriptCore: LLInt should support JSVALUE64
https://bugs.webkit.org/show_bug.cgi?id=79609
<rdar://problem/10063437>

Patch by Filip Pizlo <fpizlo@apple.com> on 2012-03-10
Reviewed by Gavin Barraclough and Oliver Hunt.

Ported the LLInt, which previously only worked on 32-bit, to 64-bit. This
patch moves a fair bit of code from LowLevelInterpreter32_64.asm to the common
file, LowLevelInterpreter.asm. About 1/3 of the LLInt did not have to be
specialized for value representation.

Also made some minor changes to offlineasm and the slow-paths.

  • llint/LLIntData.cpp:

(JSC::LLInt::Data::performAssertions):

  • llint/LLIntEntrypoints.cpp:
  • llint/LLIntSlowPaths.cpp:

(LLInt):
(JSC::LLInt::llint_trace_value):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::jitCompileAndSetHeuristics):

  • llint/LLIntSlowPaths.h:

(LLInt):
(SlowPathReturnType):
(JSC::LLInt::SlowPathReturnType::SlowPathReturnType):
(JSC::LLInt::encodeResult):

  • llint/LLIntThunks.cpp:
  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • offlineasm/armv7.rb:
  • offlineasm/asm.rb:
  • offlineasm/ast.rb:
  • offlineasm/backends.rb:
  • offlineasm/instructions.rb:
  • offlineasm/parser.rb:
  • offlineasm/registers.rb:
  • offlineasm/transform.rb:
  • offlineasm/x86.rb:
  • wtf/Platform.h:

LayoutTests: Object.freeze broken on latest Nightly
https://bugs.webkit.org/show_bug.cgi?id=80577

Reviewed by Oliver Hunt.

  • fast/js/preventExtensions-expected.txt:
  • fast/js/script-tests/preventExtensions.js:
    • Added test cases.
10:34 Changeset [110395] by pfeldman@chromium.org

Web Inspector: console.log attempts to substitute any "%" character in the message.
https://bugs.webkit.org/show_bug.cgi?id=80504

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: inspector/console/console-string-format.html

  • inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):

  • inspector/front-end/ProfileDataGridTree.js:
  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):

  • inspector/front-end/utilities.js:

LayoutTests:

  • inspector/console/console-string-format-expected.txt: Added.
  • inspector/console/console-string-format.html: Added.
09:35 Changeset [110394] by caseq@chromium.org

Web Inspector: use monotonically increasing time in timeline agent
https://bugs.webkit.org/show_bug.cgi?id=80786

Reviewed by Pavel Feldman.

  • bindings/v8/ScriptGCEvent.cpp:

(WebCore::ScriptGCEvent::gcPrologueCallback):
(WebCore::ScriptGCEvent::gcEpilogueCallback):

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::pushGCEventRecords):
(WebCore::InspectorTimelineAgent::willSendResourceRequest):
(WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
(WebCore::InspectorTimelineAgent::appendRecord):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):
(WebCore::InspectorTimelineAgent::timestamp):
(WebCore):

  • inspector/InspectorTimelineAgent.h:

(InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::timestamp):

08:09 Changeset [110393] by vsevik@chromium.org

Web Inspector: Network panel does not show responses for application/json data
https://bugs.webkit.org/show_bug.cgi?id=80684

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/network/async-xhr-json-mime-type.html

  • inspector/InspectorPageAgent.cpp:

(WebCore::createXHRTextDecoder):
(WebCore::InspectorPageAgent::cachedResourceContent):

  • inspector/InspectorPageAgent.h:
  • inspector/NetworkResourcesData.cpp:

(WebCore::createOtherResourceTextDecoder):
(WebCore):
(WebCore::NetworkResourcesData::responseReceived):

LayoutTests:

  • http/tests/inspector/network/async-xhr-json-mime-type-expected.txt: Added.
  • http/tests/inspector/network/async-xhr-json-mime-type.html: Added.
  • http/tests/inspector/network/resources/json.php: Added.
07:59 Changeset [110392] by vsevik@chromium.org

Web Inspector: CSS content is not shown when stylesheet is loaded with invalid mime type in quirks mode.
https://bugs.webkit.org/show_bug.cgi?id=80528

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/resource-tree/resource-tree-invalid-mime-type-css-content.html

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::cachedResourceContent):

LayoutTests:

  • http/tests/inspector/resource-tree/resource-tree-invalid-mime-type-css-content-expected.txt: Added.
  • http/tests/inspector/resource-tree/resource-tree-invalid-mime-type-css-content.html: Added.
  • http/tests/inspector/resource-tree/resources/stylesheet-text-plain.php: Added.
06:15 Changeset [110391] by pfeldman@chromium.org

Web Inspector: [chromium] add provisional test for the downstream sanity test.
https://bugs.webkit.org/show_bug.cgi?id=80784

Reviewed by Yury Semikhatsky.

  • src/js/Tests.js:

(.TestSuite.prototype.checkLogAndErrorMessages.validMessage):
(.TestSuite.prototype.checkLogAndErrorMessages.onConsoleMessage):
(.TestSuite.prototype.checkLogAndErrorMessages):

03:11 Changeset [110390] by commit-queue@webkit.org

<http://webkit.org/b/80782> Web Inspector: Crash using released frontendClient when resizing window with closed inspector

The WebInspectorFrontendClient reference should be cleared when the
WebInspectorClient::closeInspectorFrontend is called. This adds a
destroyInspectorPage to mirror createInspectorPage and clear the weak
pointers that are no longer valid.

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-03-11
Reviewed by Pavel Feldman.

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::closeInspectorFrontend):
(WebKit::WebInspectorClient::didResizeMainFrame):

  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::destroyInspectorPage):

  • WebProcess/WebPage/WebInspector.h:
01:11 Changeset [110389] by mjs@apple.com

Add --instruments option to sunspider to profile with Instruments
https://bugs.webkit.org/show_bug.cgi?id=80783

Reviewed by Filip Pizlo.

PerformanceTests/SunSpider:

  • resources/TimeProfile20us.tracetemplate: Added.
  • sunspider:

(runTestsOnce):

Tools:

  • Scripts/run-sunspider:
00:26 Changeset [110388] by ostapenko.viatcheslav@nokia.com

[Qt] [WK2] Support threaded renderer in WK2
https://bugs.webkit.org/show_bug.cgi?id=76661

Source/WebCore:

Reviewed by Noam Rosenthal.

Add TransformationMatrix conversions from/to Qt QMatrix4x4. Used by Qt WebKit2
rendering and tested by Qt WebKit2 API tests.

  • platform/graphics/qt/TransformationMatrixQt.cpp:

(WebCore::TransformationMatrix::operator QMatrix4x4):
(WebCore):
(WebCore::TransformationMatrix::TransformationMatrix):

  • platform/graphics/transforms/TransformationMatrix.h:

(TransformationMatrix):

Source/WebKit2:

Reviewed by Noam Rosenthal.

Implement Qt5 threaded rendering support for Qt WebKit2.
Parts of LayerTreeHostProxy which contain layer tree and layer painting objects
are moved to separate class called WebLayerTreeRenderer. WebLayerTreeRenderer is
thread safe ref counted and referenced by LayerTreeHostProxy and paint node.
All layer tree and graphics objects are created, accessed and deallocated from Qt
Scenegraph's paint thread only.
Layer tree updates from render queue are fetched in updatePaintNode call stack when
main thread is locked.
Messages from paint thread to web process are passed through MainThreadGuardedInvoker
call gate (implemented by Noam Rosenthal and previously reviewed by Kenneth Rohde
Christiansen).

  • Target.pri:
  • UIProcess/API/qt/qquickwebpage.cpp:

(PageProxyNode::PageProxyNode):
(PageProxyNode::render):
(PageProxyNode::~PageProxyNode):
(PageProxyNode::layerTreeRenderer):
(PageProxyNode):
(PageProxyNode::setScale):
(QQuickWebPage::updatePaintNode):
(QQuickWebPagePrivate::~QQuickWebPagePrivate):

  • UIProcess/LayerTreeHostProxy.cpp: Added.

(WebKit):
(WebKit::LayerTreeHostProxy::LayerTreeHostProxy):
(WebKit::LayerTreeHostProxy::~LayerTreeHostProxy):
(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit::LayerTreeHostProxy::paintToGraphicsContext):
(WebKit::LayerTreeHostProxy::updateViewport):
(WebKit::LayerTreeHostProxy::dispatchUpdate):
(WebKit::LayerTreeHostProxy::createTileForLayer):
(WebKit::LayerTreeHostProxy::updateTileForLayer):
(WebKit::LayerTreeHostProxy::removeTileForLayer):
(WebKit::LayerTreeHostProxy::deleteCompositingLayer):
(WebKit::LayerTreeHostProxy::setRootCompositingLayer):
(WebKit::LayerTreeHostProxy::syncCompositingLayerState):
(WebKit::LayerTreeHostProxy::didRenderFrame):
(WebKit::LayerTreeHostProxy::createDirectlyCompositedImage):
(WebKit::LayerTreeHostProxy::destroyDirectlyCompositedImage):
(WebKit::LayerTreeHostProxy::setVisibleContentsRectForPanning):
(WebKit::LayerTreeHostProxy::setVisibleContentsRectForScaling):
(WebKit::LayerTreeHostProxy::renderNextFrame):
(WebKit::LayerTreeHostProxy::purgeBackingStores):

  • UIProcess/LayerTreeHostProxy.h:

(WebKit):
(LayerTreeHostProxy):
(WebKit::LayerTreeHostProxy::layerTreeRenderer):

  • UIProcess/WebLayerTreeRenderer.cpp: Renamed from Source/WebKit2/UIProcess/qt/LayerTreeHostProxyQt.cpp.

(WebKit):
(MainThreadGuardedInvoker):
(WebKit::MainThreadGuardedInvoker::call):
(WebKit::MainThreadGuardedInvoker::MainThreadGuardedInvoker):
(WebKit::MainThreadGuardedInvoker::invoke):
(WebKit::WebLayerTreeRenderer::callOnMainTread):
(WebKit::WebLayerTreeRenderer::WebLayerTreeRenderer):
(WebKit::WebLayerTreeRenderer::~WebLayerTreeRenderer):
(WebKit::WebLayerTreeRenderer::createLayer):
(WebKit::WebLayerTreeRenderer::paintToCurrentGLContext):
(WebKit::WebLayerTreeRenderer::syncAnimations):
(WebKit::WebLayerTreeRenderer::paintToGraphicsContext):
(WebKit::WebLayerTreeRenderer::setVisibleContentsRectForScaling):
(WebKit::WebLayerTreeRenderer::updateViewport):
(WebKit::WebLayerTreeRenderer::syncLayerParameters):
(WebKit::WebLayerTreeRenderer::deleteLayer):
(WebKit::WebLayerTreeRenderer::ensureLayer):
(WebKit::WebLayerTreeRenderer::setRootLayerID):
(WebKit::WebLayerTreeRenderer::getBackingStore):
(WebKit::WebLayerTreeRenderer::createTile):
(WebKit::WebLayerTreeRenderer::removeTile):
(WebKit::WebLayerTreeRenderer::updateTile):
(WebKit::WebLayerTreeRenderer::createImage):
(WebKit::WebLayerTreeRenderer::destroyImage):
(WebKit::WebLayerTreeRenderer::assignImageToLayer):
(WebKit::WebLayerTreeRenderer::swapBuffers):
(WebKit::WebLayerTreeRenderer::flushLayerChanges):
(WebKit::WebLayerTreeRenderer::renderNextFrame):
(WebKit::WebLayerTreeRenderer::ensureRootLayer):
(WebKit::WebLayerTreeRenderer::syncRemoteContent):
(WebKit::WebLayerTreeRenderer::purgeGLResources):
(WebKit::WebLayerTreeRenderer::purgeBackingStores):
(WebKit::WebLayerTreeRenderer::detach):
(WebKit::WebLayerTreeRenderer::appendUpdate):

  • UIProcess/WebLayerTreeRenderer.h: Copied from Source/WebKit2/UIProcess/LayerTreeHostProxy.h.

(WebKit):
(WebLayerTreeRenderer):
(WebKit::WebLayerTreeRenderer::layerByID):
(WebKit::WebLayerTreeRenderer::rootLayer):
(WebKit::WebLayerTreeRenderer::notifyAnimationStarted):
(WebKit::WebLayerTreeRenderer::notifySyncRequired):
(WebKit::WebLayerTreeRenderer::showDebugBorders):
(WebKit::WebLayerTreeRenderer::showRepaintCounter):
(WebKit::WebLayerTreeRenderer::paintContents):

Tools:

Remove disabling of threaded rendering.

Reviewed by Noam Rosenthal.

  • MiniBrowser/qt/main.cpp:

(main):

03/10/12:

20:48 Changeset [110387] by dbates@webkit.org

Switch from HTTP to HTTPS for Xcode developer.apple.com hyperlinks

The Debugging and Analyzing Your Code page cannot be viewed at <http://developer.apple.com/library/mac/#documentation/ToolsLanguages/Conceptual/Xcode4UserGuide/Debugging/Debugging.html#//apple_ref/doc/uid/TP40010215-CH3-SW1> (1) as this URL redirects to the Mac OS X Developer Library <https://developer.apple.com/library/mac/navigation/>.
Substituting https for http in (1) returns the expected page.

  • building/debug-mac-uiprocess.html:
  • building/debug.html:
20:23 Changeset [110386] by commit-queue@webkit.org

Unreviewed, rolling out r110384.
http://trac.webkit.org/changeset/110384
https://bugs.webkit.org/show_bug.cgi?id=80774

compile failed on Chromium Win Release (Requested by ukai_home
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-10

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore::LayerChromiumWithForcedDrawsContent::LayerChromiumWithForcedDrawsContent):
(WebCore::LayerChromiumWithForcedDrawsContent::opaqueContentsRegion):
(WebCore::LayerChromiumWithForcedDrawsContent::setOpaquePaintRect):
(LayerChromiumWithForcedDrawsContent):
(WebCore::setLayerPropertiesForTesting):
(WebCore):
(WebCore::TestCCOcclusionTracker::TestCCOcclusionTracker):
(WebCore::TestCCOcclusionTracker::occlusionInScreenSpace):
(WebCore::TestCCOcclusionTracker::occlusionInTargetSurface):
(WebCore::TestCCOcclusionTracker::setOcclusionInScreenSpace):
(WebCore::TestCCOcclusionTracker::setOcclusionInTargetSurface):
(WebCore::TestCCOcclusionTracker::layerScissorRectInTargetSurface):
(WebCore::TestDamageClient::damageRect):
(WebCore::layerAddedToOccludedRegion):
(WebCore::layerAddedToOccludedRegionWithRotation):
(WebCore::layerAddedToOccludedRegionWithTranslation):
(WebCore::layerAddedToOccludedRegionWithRotatedSurface):
(WebCore::layerAddedToOccludedRegionWithSurfaceAlreadyOnStack):
(WebCore::layerAddedToOccludedRegionWithRotatedOffAxisSurface):
(WebCore::layerAddedToOccludedRegionWithMultipleOpaqueLayers):
(WebCore::surfaceOcclusionWithOverlappingSiblingSurfaces):
(WebCore::surfaceOcclusionInScreenSpace):
(WebCore::surfaceOcclusionInScreenSpaceDifferentTransforms):
(WebCore::occlusionInteractionWithFilters):
(WebCore::layerScissorRectOverTile):
(WebCore::screenScissorRectOverTile):
(WebCore::layerScissorRectOverCulledTile):
(WebCore::screenScissorRectOverCulledTile):
(WebCore::layerScissorRectOverPartialTiles):
(WebCore::screenScissorRectOverPartialTiles):
(WebCore::layerScissorRectOverNoTiles):
(WebCore::screenScissorRectOverNoTiles):
(WebCore::layerScissorRectForLayerOffOrigin):
(WebCore::damageRectOverTile):
(WebCore::damageRectOverCulledTile):
(WebCore::damageRectOverPartialTiles):
(WebCore::damageRectOverNoTiles):
(WebCore::TEST):

19:56 Changeset [110385] by rniwa@webkit.org

Increment the perf-o-matic app version.

  • Websites/webkit-perf.appspot.com/app.yaml:
18:37 Changeset [110384] by commit-queue@webkit.org

[chromium] Clean up culling tests and templatize to test impl constructs
https://bugs.webkit.org/show_bug.cgi?id=80613

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-10
Reviewed by Adrienne Walker.

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore::TestContentLayerChromium::TestContentLayerChromium):
(WebCore::TestContentLayerChromium::opaqueContentsRegion):
(WebCore::TestContentLayerChromium::setOpaqueContentsRect):
(TestContentLayerChromium):
(TestContentLayerImpl):
(WebCore::TestContentLayerImpl::TestContentLayerImpl):
(WebCore::TestContentLayerImpl::opaqueContentsRegion):
(WebCore::TestContentLayerImpl::setOpaqueContentsRect):
(WebCore):
(WebCore::TestCCOcclusionTrackerBase::TestCCOcclusionTrackerBase):
(WebCore::TestCCOcclusionTrackerBase::occlusionInScreenSpace):
(WebCore::TestCCOcclusionTrackerBase::occlusionInTargetSurface):
(WebCore::TestCCOcclusionTrackerBase::setOcclusionInScreenSpace):
(WebCore::TestCCOcclusionTrackerBase::setOcclusionInTargetSurface):
(WebCore::TestCCOcclusionTrackerBase::layerScissorRectInTargetSurface):
(WebCore::TestDamageClient::damageRect):
(CCOcclusionTrackerTestMainThreadTypes):
(WebCore::CCOcclusionTrackerTestMainThreadTypes::createLayer):
(WebCore::CCOcclusionTrackerTestMainThreadTypes::createContentLayer):
(CCOcclusionTrackerTestImplThreadTypes):
(WebCore::CCOcclusionTrackerTestImplThreadTypes::createLayer):
(WebCore::CCOcclusionTrackerTestImplThreadTypes::createContentLayer):
(CCOcclusionTrackerTest):
(WebCore::CCOcclusionTrackerTest::TearDown):
(WebCore::CCOcclusionTrackerTest::createRoot):
(WebCore::CCOcclusionTrackerTest::createLayer):
(WebCore::CCOcclusionTrackerTest::createSurface):
(WebCore::CCOcclusionTrackerTest::createDrawingLayer):
(WebCore::CCOcclusionTrackerTest::createDrawingSurface):
(WebCore::CCOcclusionTrackerTest::calcDrawEtc):
(WebCore::CCOcclusionTrackerTest::setBaseProperties):
(WebCore::CCOcclusionTrackerTest::setProperties):
(CCOcclusionTrackerTestIdentityTransforms):
(WebCore::CCOcclusionTrackerTestIdentityTransforms::runMyTest):
(CCOcclusionTrackerTestRotatedChild):
(WebCore::CCOcclusionTrackerTestRotatedChild::runMyTest):
(CCOcclusionTrackerTestTranslatedChild):
(WebCore::CCOcclusionTrackerTestTranslatedChild::runMyTest):
(CCOcclusionTrackerTestChildInRotatedChild):
(WebCore::CCOcclusionTrackerTestChildInRotatedChild::runMyTest):
(CCOcclusionTrackerTestVisitTargetTwoTimes):
(WebCore::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest):
(CCOcclusionTrackerTestSurfaceRotatedOffAxis):
(WebCore::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest):
(CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren):
(WebCore::CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren::runMyTest):
(CCOcclusionTrackerTestOverlappingSurfaceSiblings):
(WebCore::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
(CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms):
(WebCore::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
(CCOcclusionTrackerTestFilters):
(WebCore::CCOcclusionTrackerTestFilters::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectOutsideChild):
(WebCore::CCOcclusionTrackerTestLayerScissorRectOutsideChild::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectOutsideChild):
(WebCore::CCOcclusionTrackerTestScreenScissorRectOutsideChild::runMyTest):
(CCOcclusionTrackerTestDamageRectOutsideChild):
(WebCore::CCOcclusionTrackerTestDamageRectOutsideChild::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectOverChild):
(WebCore::CCOcclusionTrackerTestLayerScissorRectOverChild::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectOverChild):
(WebCore::CCOcclusionTrackerTestScreenScissorRectOverChild::runMyTest):
(CCOcclusionTrackerTestDamageRectOverChild):
(WebCore::CCOcclusionTrackerTestDamageRectOverChild::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectPartlyOverChild):
(WebCore::CCOcclusionTrackerTestLayerScissorRectPartlyOverChild::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectPartlyOverChild):
(WebCore::CCOcclusionTrackerTestScreenScissorRectPartlyOverChild::runMyTest):
(CCOcclusionTrackerTestDamageRectPartlyOverChild):
(WebCore::CCOcclusionTrackerTestDamageRectPartlyOverChild::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectOverNothing):
(WebCore::CCOcclusionTrackerTestLayerScissorRectOverNothing::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectOverNothing):
(WebCore::CCOcclusionTrackerTestScreenScissorRectOverNothing::runMyTest):
(CCOcclusionTrackerTestDamageRectOverNothing):
(WebCore::CCOcclusionTrackerTestDamageRectOverNothing::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectForLayerOffOrigin):
(WebCore::CCOcclusionTrackerTestLayerScissorRectForLayerOffOrigin::runMyTest):
(CCOcclusionTrackerTestOpaqueContentsRegionEmpty):
(WebCore::CCOcclusionTrackerTestOpaqueContentsRegionEmpty::runMyTest):
(CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty):
(WebCore::CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty::runMyTest):

16:33 Changeset [110383] by fpizlo@apple.com

LLInt should support JSVALUE64
https://bugs.webkit.org/show_bug.cgi?id=79609
<rdar://problem/10063437>

Reviewed by Gavin Barraclough and Oliver Hunt.

Ported the LLInt, which previously only worked on 32-bit, to 64-bit. This
patch moves a fair bit of code from LowLevelInterpreter32_64.asm to the common
file, LowLevelInterpreter.asm. About 1/3 of the LLInt did not have to be
specialized for value representation.

Also made some minor changes to offlineasm and the slow-paths.

  • llint/LLIntData.cpp:

(JSC::LLInt::Data::performAssertions):

  • llint/LLIntEntrypoints.cpp:
  • llint/LLIntSlowPaths.cpp:

(LLInt):
(JSC::LLInt::llint_trace_value):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::jitCompileAndSetHeuristics):

  • llint/LLIntSlowPaths.h:

(LLInt):
(SlowPathReturnType):
(JSC::LLInt::SlowPathReturnType::SlowPathReturnType):
(JSC::LLInt::encodeResult):

  • llint/LLIntThunks.cpp:
  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • offlineasm/armv7.rb:
  • offlineasm/asm.rb:
  • offlineasm/ast.rb:
  • offlineasm/backends.rb:
  • offlineasm/instructions.rb:
  • offlineasm/parser.rb:
  • offlineasm/registers.rb:
  • offlineasm/transform.rb:
  • offlineasm/x86.rb:
  • wtf/Platform.h:
10:44 Changeset [110382] by mrobinson@webkit.org

[WK2] run-perf-tests should be able to run with WTR
https://bugs.webkit.org/show_bug.cgi?id=80042

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-03-09
Reviewed by Martin Robinson.

Add an option to PerfTestRunner to use WebKitTestRunner instead of
DumpRenderTree and add the '--no-timeout' flag to WebKitTestRunner
to avoid timing out when running performance tests.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._parse_args):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::InjectedBundle): Initialize m_useWaitToDumpWatchdogTimer
to true.
(WTR::InjectedBundle::didReceiveMessage): Unpack the 'BeginTest' message
as a dictionary containing DumpPixels and UseWaitToDumpWatchdogTimer keys.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(WTR::InjectedBundle::useWaitToDumpWatchdogTimer): Make m_useWaitToDumpWatchdogTimer
publicly accessible.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::waitUntilDone): Only initialize the watchdog if it
is required.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController): Initialize m_useWaitToDumpWatchdogTimer
to true.
(WTR::TestController::initialize): Set m_useWaitToDumpWatchdogTimer to false
if '--no-timeout' option is present.
(WTR::TestController::runUntil): Translate TimeoutDuration to a proper timeout
value, or -1.0 if timeout should not occur.

  • WebKitTestRunner/TestController.h:

(WTR::TestController::useWaitToDumpWatchdogTimer): Make m_useWaitToDumpWatchdogTimer
publicly accessible.

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::invoke): Pack the 'BeginTest' message as a dictionary,
containing DumpPixels and UseWaitToDumpWatchdogTimer keys and corresponding values.
Waiting for final message should not time out if not necessary.

  • WebKitTestRunner/gtk/TestControllerGtk.cpp:

(WTR::TestController::platformRunUntil): Only set up a timeout if necessary.

  • WebKitTestRunner/qt/TestControllerQt.cpp:

(WTR::TestController::platformRunUntil): Ditto.

  • WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::platformRunUntil): Add a FIXME, indicating functionality
is missing.

  • WebKitTestRunner/win/TestControllerWin.cpp:

(WTR::TestController::platformRunUntil): Ditto.

10:42 Changeset [110381] by jonlee@apple.com

Rename NotificationPresenter to NotificationClient
https://bugs.webkit.org/show_bug.cgi?id=80488
<rdar://problem/10965558>

Reviewed by Kentaro Hara.

Source/WebCore:

  • notifications/NotificationCenter.h: Renamed from notifications/NotificationPresenter.h.

Refactor to use renamed WebCore::NotificationClient.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • notifications/Notification.cpp:

(WebCore::Notification::Notification):
(WebCore::Notification::show):
(WebCore::Notification::cancel):
(WebCore::Notification::contextDestroyed):
(WebCore::Notification::finishLoading):

  • notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::create):
(WebCore::NotificationCenter::NotificationCenter):
(WebCore::NotificationCenter::checkPermission):
(WebCore::NotificationCenter::requestPermission):
(WebCore::NotificationCenter::disconnectFrame):

  • notifications/NotificationController.cpp:

(WebCore::NotificationController::NotificationController):
(WebCore::NotificationController::create):
(WebCore::NotificationController::clientFrom):
(WebCore::provideNotification):

  • notifications/NotificationController.h:

(WebCore):
(NotificationController):
(WebCore::NotificationController::client):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::webkitNotifications):

  • page/DOMWindow.h:

(DOMWindow):

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::webkitNotifications):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::WorkerThread):

  • workers/WorkerThread.h:

(WebCore):
(WebCore::WorkerThread::getNotificationClient):
(WebCore::WorkerThread::setNotificationClient):
(WorkerThread):

Source/WebKit/blackberry:

Refactor to use renamed WebCore::NotificationClient.

  • WebCoreSupport/NotificationPresenterImpl.cpp:

(WebCore::NotificationPresenterImpl::instance):
(WebCore::NotificationPresenterImpl::show):
(WebCore::NotificationPresenterImpl::checkPermission):

  • WebCoreSupport/NotificationPresenterImpl.h:

(NotificationPresenterImpl):

Source/WebKit/chromium:

Refactor to use renamed WebCore::NotificationClient.

  • src/AssertMatchingEnums.cpp:
  • src/NotificationPresenterImpl.cpp:

(WebKit::NotificationPresenterImpl::checkPermission):

  • src/NotificationPresenterImpl.h:

(NotificationPresenterImpl):

Source/WebKit/efl:

Refactor to use renamed WebCore::NotificationClient.

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::notificationPresenter):

  • WebCoreSupport/ChromeClientEfl.h:

(ChromeClientEfl):

Source/WebKit/mac:

Refactor to use renamed WebCore::NotificationClient.

  • WebCoreSupport/WebNotificationClient.h:
  • WebCoreSupport/WebNotificationClient.mm:

(WebNotificationClient::checkPermission):

  • WebView/WebViewPrivate.h:

Source/WebKit/qt:

Refactor to use renamed WebCore::NotificationClient.

  • WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationPresenterClientQt::checkPermission):
(WebCore::NotificationPresenterClientQt::allowNotificationForFrame):

  • WebCoreSupport/NotificationPresenterClientQt.h:

(NotificationPresenterClientQt):

Source/WebKit/win:

Refactor to use renamed WebCore::NotificationClient.

  • WebCoreSupport/WebChromeClient.h:

(WebChromeClient::notificationPresenter):

  • WebCoreSupport/WebDesktopNotificationsDelegate.cpp:

(WebDesktopNotificationsDelegate::checkPermission):

  • WebCoreSupport/WebDesktopNotificationsDelegate.h:

(WebDesktopNotificationsDelegate):

Source/WebKit/wince:

Refactor to use renamed WebCore::NotificationClient.

  • WebCoreSupport/ChromeClientWinCE.h:

(ChromeClientWinCE):

Source/WebKit2:

Refactor to use renamed WebCore::NotificationClient.

  • UIProcess/Notifications/WebNotificationManagerProxy.h:
  • WebProcess/Notifications/NotificationPermissionRequestManager.cpp:

(WebKit::NotificationPermissionRequestManager::startRequest):
(WebKit::NotificationPermissionRequestManager::permissionLevel):

  • WebProcess/Notifications/NotificationPermissionRequestManager.h:

(NotificationPermissionRequestManager):

  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::policyForOrigin):

  • WebProcess/Notifications/WebNotificationManager.h:

(WebNotificationManager):

  • WebProcess/WebCoreSupport/WebNotificationClient.cpp:

(WebKit::WebNotificationClient::checkPermission):

  • WebProcess/WebCoreSupport/WebNotificationClient.h:

(WebNotificationClient):

Tools:

Refactor to use renamed WebCore::NotificationClient.

  • DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:

(DRTDesktopNotificationPresenter::checkNotificationPermission):

10:21 Changeset [110380] by jchaffraix@webkit.org

RenderObject with 'resize' different from 'none' should have a RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=80738

Reviewed by James Robinson.

Source/WebCore:

Covered by fast/css/resize-single-axis.html.

  • rendering/RenderBox.h:

(WebCore::RenderBox::requiresLayerForOverflowClip):
The resizer logic is tied to RenderLayer so force a RenderLayer to be allocated if resize() != RESIZE_NONE.

LayoutTests:

  • platform/chromium/test_expectations.txt:
  • platform/efl/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/win/Skipped:

Unskip the test on most platform but Qt. Qt has a bug about the test timing out
which may be related.

09:38 Changeset [110379] by commit-queue@webkit.org

Web Worker crashes with WX_EXCLUSIVE
https://bugs.webkit.org/show_bug.cgi?id=80532

Let each JS global object own a meta allocator
for WX_EXCLUSIVE to avoid conflicts from Web Worker.
Also fix a mutex leak in MetaAllocator's dtor.

Patch by Yong Li <yoli@rim.com> on 2012-03-10
Reviewed by Filip Pizlo.

  • jit/ExecutableAllocator.cpp:

(JSC::DemandExecutableAllocator::DemandExecutableAllocator):
(JSC::DemandExecutableAllocator::~DemandExecutableAllocator):
(JSC::DemandExecutableAllocator::bytesAllocatedByAllAllocators):
(DemandExecutableAllocator):
(JSC::DemandExecutableAllocator::bytesCommittedByAllocactors):
(JSC::DemandExecutableAllocator::dumpProfileFromAllAllocators):
(JSC::DemandExecutableAllocator::allocateNewSpace):
(JSC::DemandExecutableAllocator::allocators):
(JSC::DemandExecutableAllocator::allocatorsMutex):
(JSC):
(JSC::ExecutableAllocator::initializeAllocator):
(JSC::ExecutableAllocator::ExecutableAllocator):
(JSC::ExecutableAllocator::underMemoryPressure):
(JSC::ExecutableAllocator::memoryPressureMultiplier):
(JSC::ExecutableAllocator::allocate):
(JSC::ExecutableAllocator::committedByteCount):
(JSC::ExecutableAllocator::dumpProfile):

  • jit/ExecutableAllocator.h:

(JSC):
(ExecutableAllocator):
(JSC::ExecutableAllocator::allocator):

  • wtf/MetaAllocator.h:

(WTF::MetaAllocator::~MetaAllocator): Finalize the spin lock.

  • wtf/TCSpinLock.h:

(TCMalloc_SpinLock::Finalize): Add empty Finalize() to some implementations.

09:08 Changeset [110378] by senorblanco@chromium.org

Unreviewed, rolling out r110358.
http://trac.webkit.org/changeset/110358
https://bugs.webkit.org/show_bug.cgi?id=80706

No improvement on specified benchmarks.

  • dom/ContainerNode.cpp:

(WebCore::collectNodes):
(WebCore::collectTargetNodes):

08:01 Changeset [110377] by zimmermann@webkit.org

2012-03-10 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Final chunk of SL rebaselines with Generic RGB profile for svg/.

  • platform/mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/mac-snowleopard/svg/filters/animate-fill-expected.png:
  • platform/mac-snowleopard/svg/filters/big-sized-filter-2-expected.png:
  • platform/mac-snowleopard/svg/filters/big-sized-filter-expected.png:
  • platform/mac-snowleopard/svg/filters/feColorMatrix-default-type-expected.png:
  • platform/mac-snowleopard/svg/filters/feColorMatrix-offset-expected.png:
  • platform/mac-snowleopard/svg/filters/feColorMatrix-saturate-expected.png:
  • platform/mac-snowleopard/svg/filters/feColorMatrix-values-expected.png:
  • platform/mac-snowleopard/svg/filters/feComposite-expected.png:
  • platform/mac-snowleopard/svg/filters/feConvolveFilter-y-bounds-expected.png:
  • platform/mac-snowleopard/svg/filters/feDisplacementMap-expected.png:
  • platform/mac-snowleopard/svg/filters/feDropShadow-expected.png:
  • platform/mac-snowleopard/svg/filters/feGaussianBlur-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-animated-transform-on-target-rect-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-late-indirect-update-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-multiple-targets-id-change-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-position-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-preserveAspectratio-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-reference-invalidation-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-reference-svg-primitive-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-subregions-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-target-add-to-document-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-target-attribute-change-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-target-changes-id-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-target-id-change-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-target-inline-style-change-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-target-property-change-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-target-reappend-to-document-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-target-remove-from-document-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-target-style-change-expected.png:
  • platform/mac-snowleopard/svg/filters/feLighting-crash-expected.png:
  • platform/mac-snowleopard/svg/filters/feMerge-expected.png:
  • platform/mac-snowleopard/svg/filters/feOffset-expected.png:
  • platform/mac-snowleopard/svg/filters/feTile-expected.png:
  • platform/mac-snowleopard/svg/filters/filter-clip-expected.png:
  • platform/mac-snowleopard/svg/filters/filter-on-tspan-expected.png:
  • platform/mac-snowleopard/svg/filters/filter-placement-issue-expected.png:
  • platform/mac-snowleopard/svg/filters/filter-refresh-expected.png:
  • platform/mac-snowleopard/svg/filters/filter-rounding-issues-expected.png:
  • platform/mac-snowleopard/svg/filters/filter-source-position-expected.png:
  • platform/mac-snowleopard/svg/filters/filter-width-update-expected.png:
  • platform/mac-snowleopard/svg/filters/filterRes-expected.png:
  • platform/mac-snowleopard/svg/filters/filterRes1-expected.png:
  • platform/mac-snowleopard/svg/filters/filterRes2-expected.png:
  • platform/mac-snowleopard/svg/filters/filterRes3-expected.png:
  • platform/mac-snowleopard/svg/filters/filteredImage-expected.png:
  • platform/mac-snowleopard/svg/filters/parent-children-with-same-filter-expected.png:
  • platform/mac-snowleopard/svg/filters/shadow-on-filter-expected.png:
  • platform/mac-snowleopard/svg/filters/shadow-on-rect-with-filter-expected.png:
  • platform/mac-snowleopard/svg/filters/subRegion-in-userSpace-expected.png:
  • platform/mac-snowleopard/svg/filters/subRegion-one-effect-expected.png:
  • platform/mac-snowleopard/svg/filters/subRegion-two-effects-expected.png:
  • platform/mac-snowleopard/svg/foreignObject/filter-expected.png:
  • platform/mac-snowleopard/svg/repaint/filter-child-repaint-expected.png:
  • platform/mac-snowleopard/svg/repaint/filter-repaint-expected.png:
  • platform/mac-snowleopard/svg/repaint/image-href-change-expected.png:
  • platform/mac-snowleopard/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/mac-snowleopard/svg/webarchive/svg-feimage-subresources-expected.png:
  • platform/mac-snowleopard/svg/wicd/test-rightsizing-b-expected.png:
  • platform/mac-snowleopard/svg/zoom/page/zoom-background-images-expected.png:
  • platform/mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
07:34 Changeset [110376] by zimmermann@webkit.org

2012-03-10 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Next chunk of SL rebaselines with Generic RGB profile for svg/.

  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDistantLightElement-dom-azimuth-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDistantLightElement-dom-elevation-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-azimuth-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-elevation-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEOffsetElement-dom-dx-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEOffsetElement-dom-dy-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEOffsetElement-dom-in-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dx-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dy-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEOffsetElement-svgdom-in-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-dom-height-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-dom-width-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-dom-x-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-dom-y-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-svgdom-height-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-svgdom-width-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-svgdom-x-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-svgdom-y-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
06:52 Changeset [110375] by zimmermann@webkit.org

2012-03-10 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. First chunk of SL rebaselines with Generic RGB profile for svg/.

  • platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-light-04-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-image-04-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-image-06-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-image-07-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-image-08-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-use-01-t-expected.png:
  • platform/mac-snowleopard/svg/as-border-image/svg-as-border-image-2-expected.png:
  • platform/mac-snowleopard/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/mac-snowleopard/svg/batik/filters/feTile-expected.png:
  • platform/mac-snowleopard/svg/batik/filters/filterRegions-expected.png:
  • platform/mac-snowleopard/svg/batik/text/textEffect-expected.png:
  • platform/mac-snowleopard/svg/batik/text/textEffect3-expected.png:
  • platform/mac-snowleopard/svg/carto.net/selectionlist-expected.png:
  • platform/mac-snowleopard/svg/css/path-gradient-stroke-shadow-expected.png:
  • platform/mac-snowleopard/svg/css/rect-gradient-stroke-shadow-expected.png:
  • platform/mac-snowleopard/svg/custom/convolution-crash-expected.png:
  • platform/mac-snowleopard/svg/custom/createImageElement-expected.png:
  • platform/mac-snowleopard/svg/custom/createImageElement2-expected.png:
  • platform/mac-snowleopard/svg/custom/empty-merge-expected.png:
  • platform/mac-snowleopard/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/mac-snowleopard/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/mac-snowleopard/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/mac-snowleopard/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/mac-snowleopard/svg/custom/feDisplacementMap-01-expected.png:
  • platform/mac-snowleopard/svg/custom/focus-ring-expected.png:
  • platform/mac-snowleopard/svg/custom/grayscale-gradient-mask-2-expected.png:
  • platform/mac-snowleopard/svg/custom/group-opacity-expected.png:
  • platform/mac-snowleopard/svg/custom/image-parent-translation-expected.png:
  • platform/mac-snowleopard/svg/custom/image-small-width-height-expected.png:
  • platform/mac-snowleopard/svg/custom/image-with-prefix-in-webarchive-expected.png:
  • platform/mac-snowleopard/svg/custom/image-with-transform-clip-filter-expected.png:
  • platform/mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/mac-snowleopard/svg/custom/js-update-image-and-display-expected.png:
  • platform/mac-snowleopard/svg/custom/js-update-image-and-display2-expected.png:
  • platform/mac-snowleopard/svg/custom/js-update-image-and-display3-expected.png:
  • platform/mac-snowleopard/svg/custom/js-update-image-expected.png:
  • platform/mac-snowleopard/svg/custom/non-opaque-filters-expected.png:
  • platform/mac-snowleopard/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png:
  • platform/mac-snowleopard/svg/custom/pointer-events-image-css-transform-expected.png:
  • platform/mac-snowleopard/svg/custom/pointer-events-image-expected.png:
  • platform/mac-snowleopard/svg/custom/recursive-filter-expected.png:
  • platform/mac-snowleopard/svg/custom/relative-sized-image-expected.png:
  • platform/mac-snowleopard/svg/custom/resource-invalidate-on-target-update-expected.png:
  • platform/mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/mac-snowleopard/svg/custom/text-filter-expected.png:
  • platform/mac-snowleopard/svg/custom/text-image-opacity-expected.png:
  • platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.png:
  • platform/mac-snowleopard/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png:
  • platform/mac-snowleopard/svg/custom/visibility-override-filter-expected.png:
06:28 Changeset [110374] by morrita@google.com

ShadowTree uses weak iteration patterns
https://bugs.webkit.org/show_bug.cgi?id=80572

Reviewed by Dimitri Glazkov.

This patch moves various ShadowTree to using a better iteration pattern
in which we collect all the ShadowRoots we're planning to iterate into
a vector and then iterate over them.

  • dom/ShadowTree.cpp:

(ShadowRootVector):
(WebCore::ShadowRootVector::ShadowRootVector):
(WebCore):
(WebCore::ShadowTree::removeAllShadowRoots):
(WebCore::ShadowTree::insertedIntoDocument):
(WebCore::ShadowTree::removedFromDocument):
(WebCore::ShadowTree::insertedIntoTree):
(WebCore::ShadowTree::removedFromTree):
(WebCore::ShadowTree::willRemove):

05:26 Changeset [110373] by commit-queue@webkit.org

Unreviewed, rolling out r110363.
http://trac.webkit.org/changeset/110363
https://bugs.webkit.org/show_bug.cgi?id=80757

link error in chromium: unresolved external symbol
webkit_support::CreateScopedTempDirectory(void) (Requested by
ukai_home on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-10

Source/WebCore:

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::open):

  • platform/leveldb/LevelDBDatabase.cpp:
  • platform/leveldb/LevelDBDatabase.h:

(LevelDBDatabase):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/LevelDBTest.cpp: Removed.
02:27 Changeset [110372] by commit-queue@webkit.org

Unreviewed, rolling out r110353.
http://trac.webkit.org/changeset/110353
https://bugs.webkit.org/show_bug.cgi?id=80752

copmile failed on Chromium (Requested by ukai_home on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-10

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore::LayerChromiumWithForcedDrawsContent::LayerChromiumWithForcedDrawsContent):
(WebCore::LayerChromiumWithForcedDrawsContent::opaqueContentsRegion):
(WebCore::LayerChromiumWithForcedDrawsContent::setOpaquePaintRect):
(LayerChromiumWithForcedDrawsContent):
(WebCore::setLayerPropertiesForTesting):
(WebCore):
(WebCore::TestCCOcclusionTracker::TestCCOcclusionTracker):
(WebCore::TestCCOcclusionTracker::occlusionInScreenSpace):
(WebCore::TestCCOcclusionTracker::occlusionInTargetSurface):
(WebCore::TestCCOcclusionTracker::setOcclusionInScreenSpace):
(WebCore::TestCCOcclusionTracker::setOcclusionInTargetSurface):
(WebCore::TestCCOcclusionTracker::layerScissorRectInTargetSurface):
(WebCore::TestDamageClient::damageRect):
(WebCore::layerAddedToOccludedRegion):
(WebCore::layerAddedToOccludedRegionWithRotation):
(WebCore::layerAddedToOccludedRegionWithTranslation):
(WebCore::layerAddedToOccludedRegionWithRotatedSurface):
(WebCore::layerAddedToOccludedRegionWithSurfaceAlreadyOnStack):
(WebCore::layerAddedToOccludedRegionWithRotatedOffAxisSurface):
(WebCore::layerAddedToOccludedRegionWithMultipleOpaqueLayers):
(WebCore::surfaceOcclusionWithOverlappingSiblingSurfaces):
(WebCore::surfaceOcclusionInScreenSpace):
(WebCore::surfaceOcclusionInScreenSpaceDifferentTransforms):
(WebCore::occlusionInteractionWithFilters):
(WebCore::layerScissorRectOverTile):
(WebCore::screenScissorRectOverTile):
(WebCore::layerScissorRectOverCulledTile):
(WebCore::screenScissorRectOverCulledTile):
(WebCore::layerScissorRectOverPartialTiles):
(WebCore::screenScissorRectOverPartialTiles):
(WebCore::layerScissorRectOverNoTiles):
(WebCore::screenScissorRectOverNoTiles):
(WebCore::layerScissorRectForLayerOffOrigin):
(WebCore::damageRectOverTile):
(WebCore::damageRectOverCulledTile):
(WebCore::damageRectOverPartialTiles):
(WebCore::damageRectOverNoTiles):
(WebCore::TEST):

03/09/12:

21:45 Changeset [110371] by commit-queue@webkit.org

Source/WebCore: Handle more Gesture* events by performing scrolls on the correct target ScrollableArea
https://bugs.webkit.org/show_bug.cgi?id=80311

Implement GestureScroll* events via re-use of WheelEvent dispatch.

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-09
Reviewed by James Robinson.

Layout tests previously submited as https://bugs.webkit.org/show_bug.cgi?id=80201 and unit
test added as part of this patch.

  • page/EventHandler.cpp:

(WebCore::wheelGranularityToScrollGranularity): Refactoring.
(WebCore):
(WebCore::scrollNode):
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::defaultWheelEventHandler):
(WebCore::EventHandler::handleGestureEvent): Added GestureScrollBegin & End.
(WebCore::EventHandler::handleGestureTap):
(WebCore::EventHandler::handleGestureScrollUpdate):
(WebCore::EventHandler::handleGestureScrollCore): Refactoring.

  • page/EventHandler.h:

(EventHandler):

  • platform/PlatformWheelEvent.h: Added additional scroll type.
  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::handleWheelEvent): Forward additional scroll type.

  • platform/ScrollAnimator.h:

(WebCore):

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::ScrollAnimatorNone): Handle additional scroll type.
(WebCore::ScrollAnimatorNone::fireUpAnAnimation):
(WebCore):
(WebCore::ScrollAnimatorNone::scroll):

  • platform/ScrollAnimatorNone.h:

(ScrollAnimatorNone):

  • platform/ScrollTypes.h: Added an additional scroll type.
  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::scroll):

Source/WebKit/chromium: Handle more Gesture* events by performing scrolls on the correct target ScrollableArea
https://bugs.webkit.org/show_bug.cgi?id=80311

Added a unit test for the changes to ScrollAnimatorNone to make sure that the two-call
transport of fling parameters is correctly delivered.

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-09
Reviewed by James Robinson.

  • tests/ScrollAnimatorNoneTest.cpp:

(MockScrollAnimatorNone):
(MockScrollAnimatorNone::reset):
(MockScrollAnimatorNone::fireUpAnAnimation):
(TEST):

LayoutTests: Handle more Gesture* events by performing scrolls on the correct target ScrollableArea
https://bugs.webkit.org/show_bug.cgi?id=80311

Rebaselined to reflect corrected behaviour of gesture events targeting a div removed
from the DOM during dispatch.

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-09
Reviewed by James Robinson.

  • fast/events/touch/gesture/touch-gesture-scroll-shy-target.html:
  • platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-shy-target-expected.txt:
21:40 Changeset [110370] by mrowe@apple.com

Merge r110303.

21:04 Changeset [110369] by arv@chromium.org

[V8] Fix a fixme in v8 bindings
https://bugs.webkit.org/show_bug.cgi?id=80734

Reviewed by Kentaro Hara.

No new tests. Covered by existing tests.

  • bindings/v8/V8Binding.cpp:

(WebCore::toInt32):
(WebCore::toUInt32):

20:50 Changeset [110368] by ostapenko.viatcheslav@nokia.com

[Qt] [WK2] Shouldn't use item for clipping rect calculation in paint node.
https://bugs.webkit.org/show_bug.cgi?id=80714

Reviewed by Noam Rosenthal.

Replace item based clip-rect calculation with clipping-nodes based calculation.
This is required for threaded rendering, since we don't have access to the QSGItems
from the render thread.

  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPage::QQuickWebPage):
(QQuickWebPagePrivate::paintToCurrentGLContext):
(PageProxyNode::render):
(PageProxyNode::clipRect):
(PageProxyNode):

  • UIProcess/API/qt/qquickwebpage_p_p.h:

(QQuickWebPagePrivate):

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebView::QQuickWebView):

20:35 Changeset [110367] by commit-queue@webkit.org

[Qt] WebCore/Target.pri contains obsolete FileStreamProxy.h reference.
https://bugs.webkit.org/show_bug.cgi?id=80730

Patch by Lauro Neto <lauro.neto@openbossa.org> on 2012-03-09
Reviewed by Tor Arne Vestbø.

Build fix. Target.pri was still including old FileStreamProxy.h.

  • Target.pri:
19:53 Changeset [110366] by commit-queue@webkit.org

Pan scroll icon is painted at incorrect coordinates in frames
https://bugs.webkit.org/show_bug.cgi?id=79378

Convert client coordinates to parent ScrollView coordinates

Patch by Cem Kocagil <cem.kocagil@gmail.com> on 2012-03-05
Reviewed by Antonio Gomes

  • platform/ScrollView.cpp:

(WebCore::ScrollView::paintPanScrollIcon):

19:19 Changeset [110365] by ojan@chromium.org

Chromium-Lion rebaselines. Getting close to done. :(

19:11 Changeset [110364] by jamesr@google.com

[chromium] Deprecate renderDirectlyToWebView parameter of WebViewClient::createGraphicsContext3D()
https://bugs.webkit.org/show_bug.cgi?id=80523

Reviewed by Darin Fisher.

Source/WebKit/chromium:

  • public/WebViewClient.h:

(WebViewClient):
(WebKit::WebViewClient::createGraphicsContext3D):

  • public/platform/WebKitPlatformSupport.h:

(WebKit):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::createCompositorGraphicsContext3D):

Tools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createGraphicsContext3D):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

19:10 Changeset [110363] by jsbell@chromium.org

IndexedDB: Handle LevelDB database corruption
https://bugs.webkit.org/show_bug.cgi?id=79413

Source/WebCore:

Add LevelDBDatabase::destroy() method so that clients can retry if open() fails.

Reviewed by Tony Chang.

Test: webkit_unit_tests --gtest_filter='LevelDBDatabaseTest.CorruptionTest'

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp: Implement open/destroy/open strategy.

(WebCore::IDBLevelDBBackingStore::open):

  • platform/leveldb/LevelDBDatabase.cpp:

(WebCore::LevelDBDatabase::destroy):
(WebCore):

  • platform/leveldb/LevelDBDatabase.h:

(LevelDBDatabase):

Source/WebKit/chromium:

Reviewed by Tony Chang.

  • WebKit.gypi:
  • tests/LevelDBTest.cpp: Added.

(WebCore):
(SimpleComparator):
(WebCore::SimpleComparator::compare):
(WebCore::SimpleComparator::name):
(WebCore::encodeString):
(WebCore::TEST):

18:58 Changeset [110362] by jberlin@webkit.org

Fix one of the Windows build warnings.

  • html/track/TextTrackCueList.idl:

Add a newline to the end of the file.

18:55 Changeset [110361] by commit-queue@webkit.org

BlackBerry PlayBook doesn't sniff mime types
https://bugs.webkit.org/show_bug.cgi?id=73869

Patch by Tyler Abbott <tabbott@rim.com> on 2012-03-09
Reviewed by Rob Buis.

Hook up MIMESniffing for BlackBerry. Override Content-Types will
not be overriden. File extensions will be trusted when content
is loaded from disk.

No tests, BlackBerry tests are not yet present in webkit.org codebase.

  • PlatformBlackBerry.cmake:
  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::NetworkJob):
(WebCore::NetworkJob::initialize):
(WebCore::NetworkJob::handleNotifyDataReceived):
(WebCore::NetworkJob::sendResponseIfNeeded):

  • platform/network/blackberry/NetworkJob.h:

(NetworkJob):

18:53 Changeset [110360] by enrica@apple.com

Move WebNSURLExtras code down to WebCore.
https://bugs.webkit.org/show_bug.cgi?id=80611

Reviewed by Alexey Proskuryakov.

Source/WebCore:

  • WebCore.exp.in: Added new exported functions.
  • WebCore.xcodeproj/project.pbxproj: Added WebCoreNSURLExtras.*
  • platform/FileSystem.h: Added setMetadataURL.
  • platform/mac/FileSystemMac.mm:

(WebCore::setMetaData): Added.
(WebCore::setMetadataURL): Added.

  • platform/mac/WebCoreNSStringExtras.h:
  • platform/mac/WebCoreNSStringExtras.mm:

(hasCaseInsensitivePrefix): Added.

  • platform/mac/WebCoreNSURLExtras.h: Added.
  • platform/mac/WebCoreNSURLExtras.mm: Added.
  • platform/mac/WebCoreObjCExtras.h:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

Changed the implementation to use newly moved WebCore functions.

  • Misc/WebKitNSStringExtras.mm:

(-[NSString _webkit_hasCaseInsensitivePrefix:]):

  • Misc/WebNSURLExtras.mm:

(+[NSURL _web_URLWithUserTypedString:]):
(+[NSURL _web_URLWithDataAsString:relativeToURL:]):
(+[NSURL _web_URLWithData:]):
(+[NSURL _web_URLWithData:relativeToURL:]):
(-[NSURL _web_originalData]):
(-[NSURL _web_originalDataAsString]):
(-[NSURL _web_userVisibleString]):
(-[NSURL _web_isEmpty]):
(-[NSURL _web_URLCString]):
(-[NSURL _web_URLByTruncatingOneCharacterBeforeComponent:]):
(-[NSURL _webkit_URLByRemovingFragment]):
(-[NSURL _webkit_URLByRemovingResourceSpecifier]):
(-[NSURL _web_URLByRemovingUserInfo]):
(-[NSURL _web_dataForURLComponentType:]):
(-[NSURL _web_schemeData]):
(-[NSURL _web_hostData]):
(-[NSString _web_isUserVisibleURL]):
(-[NSString _web_hostNameNeedsDecodingWithRange:]):
(-[NSString _web_hostNameNeedsEncodingWithRange:]):
(-[NSString _web_decodeHostNameWithRange:]):
(-[NSString _web_encodeHostNameWithRange:]):
(-[NSString _web_decodeHostName]):
(-[NSString _web_encodeHostName]):

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

18:40 Changeset [110359] by commit-queue@webkit.org

[chromium] Increase size of Combo Box Options for touch and high DPI devices
https://bugs.webkit.org/show_bug.cgi?id=80027

Patch by Tim Dresser <tdresser@chromium.org> on 2012-03-09
Reviewed by Darin Fisher.

Source/WebCore:

Scale Combo box popups by defaultDeviceScaleFactor, and add padding to
<option> elements when touch is enabled.

Manually tested with --default-device-scale-factor=1,2 and unset.
Each of these were tested with RuntimeEnabledFeatures::touchEnabled
set to true and false.

  • platform/chromium/PopupListBox.cpp:

(WebCore::PopupListBox::paint):
(WebCore::PopupListBox::paintRow):
(WebCore::PopupListBox::getRowHeight):

  • platform/chromium/PopupListBox.h:

(PopupContainerSettings):

  • platform/chromium/PopupMenuChromium.cpp:

(WebCore):
(WebCore::PopupMenuChromium::show):

  • platform/chromium/PopupMenuChromium.h:

(WebCore::PopupMenuChromium::optionPaddingForTouch):
(WebCore::PopupMenuChromium::setOptionPaddingForTouch):
(PopupMenuChromium):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::showPopup):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::gestureEvent):
(WebKit::WebViewImpl::applyAutofillSuggestions):

18:22 Changeset [110358] by senorblanco@chromium.org

Improve ContainerNode collectNode() performance by reserving vector
capacity up front.
https://bugs.webkit.org/show_bug.cgi?id=80706

Reviewed by Ryosuke Niwa.

Covered by existing tests. Performance will be evaluated based on
Chromium's page_cycler_bloat-http, page_cycler_intl1, and
dromaeo_domcore suites.

  • dom/ContainerNode.cpp:

(WebCore::collectNodes):

18:11 Changeset [110357] by commit-queue@webkit.org

[chromium] Roll chromium DEPS to r125600
https://bugs.webkit.org/show_bug.cgi?id=80722

Unreviewed

Patch by James Robinson <jamesr@chromium.org> on 2012-03-09

  • DEPS:
18:09 Changeset [110356] by mitz@apple.com

<rdar://problem/11018851> Crash in DisplayRefreshMonitor::notifyClients()
https://bugs.webkit.org/show_bug.cgi?id=80740

Reviewed by Sam Weinig.

No test, since this race condition cannot be reproduced reliably.

  • platform/graphics/mac/DisplayRefreshMonitorMac.cpp:

(WebCore::DisplayRefreshMonitor::~DisplayRefreshMonitor): Changed to stop the display link
first, then cancel any outstanding calls to refreshDisplayOnMainThread(). When doing things
the other way around, the display link can fire after outstanding calls have been canceled,
and enqueue new calls on the main thread, which will be dispatched after monitor destruction.

18:04 Changeset [110355] by jeffm@apple.com

Add WKPageEndPrinting() to balance WKPageBeginPrinting()
https://bugs.webkit.org/show_bug.cgi?id=80739

Reviewed by Dan Bernstein.

  • UIProcess/API/C/WKPage.cpp:

(WKPageEndPrinting): Added.

  • UIProcess/API/C/WKPagePrivate.h: Added WKPageEndPrinting().
18:02 Changeset [110354] by abarth@webkit.org

Update baseline after http://trac.webkit.org/changeset/110352 to show
the new passing subtest.

  • platform/chromium/fast/js/array-prototype-properties-expected.txt:
17:24 Changeset [110353] by commit-queue@webkit.org

[chromium] Clean up culling tests and templatize to test impl constructs
https://bugs.webkit.org/show_bug.cgi?id=80613

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-09
Reviewed by Adrienne Walker.

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore::TestContentLayerChromium::TestContentLayerChromium):
(WebCore::TestContentLayerChromium::opaqueContentsRegion):
(WebCore::TestContentLayerChromium::setOpaqueContentsRect):
(TestContentLayerChromium):
(TestContentLayerImpl):
(WebCore::TestContentLayerImpl::TestContentLayerImpl):
(WebCore::TestContentLayerImpl::opaqueContentsRegion):
(WebCore::TestContentLayerImpl::setOpaqueContentsRect):
(WebCore):
(WebCore::TestCCOcclusionTrackerBase::TestCCOcclusionTrackerBase):
(WebCore::TestCCOcclusionTrackerBase::occlusionInScreenSpace):
(WebCore::TestCCOcclusionTrackerBase::occlusionInTargetSurface):
(WebCore::TestCCOcclusionTrackerBase::setOcclusionInScreenSpace):
(WebCore::TestCCOcclusionTrackerBase::setOcclusionInTargetSurface):
(WebCore::TestCCOcclusionTrackerBase::layerScissorRectInTargetSurface):
(WebCore::TestDamageClient::damageRect):
(CCOcclusionTrackerTestMainThreadTypes):
(WebCore::CCOcclusionTrackerTestMainThreadTypes::createLayer):
(WebCore::CCOcclusionTrackerTestMainThreadTypes::createContentLayer):
(CCOcclusionTrackerTestImplThreadTypes):
(WebCore::CCOcclusionTrackerTestImplThreadTypes::createLayer):
(WebCore::CCOcclusionTrackerTestImplThreadTypes::createContentLayer):
(CCOcclusionTrackerTest):
(WebCore::CCOcclusionTrackerTest::TearDown):
(WebCore::CCOcclusionTrackerTest::createRoot):
(WebCore::CCOcclusionTrackerTest::createLayer):
(WebCore::CCOcclusionTrackerTest::createSurface):
(WebCore::CCOcclusionTrackerTest::createDrawingLayer):
(WebCore::CCOcclusionTrackerTest::createDrawingSurface):
(WebCore::CCOcclusionTrackerTest::calcDrawEtc):
(WebCore::CCOcclusionTrackerTest::setBaseProperties):
(WebCore::CCOcclusionTrackerTest::setProperties):
(CCOcclusionTrackerTestIdentityTransforms):
(WebCore::CCOcclusionTrackerTestIdentityTransforms::runMyTest):
(CCOcclusionTrackerTestRotatedChild):
(WebCore::CCOcclusionTrackerTestRotatedChild::runMyTest):
(CCOcclusionTrackerTestTranslatedChild):
(WebCore::CCOcclusionTrackerTestTranslatedChild::runMyTest):
(CCOcclusionTrackerTestChildInRotatedChild):
(WebCore::CCOcclusionTrackerTestChildInRotatedChild::runMyTest):
(CCOcclusionTrackerTestVisitTargetTwoTimes):
(WebCore::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest):
(CCOcclusionTrackerTestSurfaceRotatedOffAxis):
(WebCore::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest):
(CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren):
(WebCore::CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren::runMyTest):
(CCOcclusionTrackerTestOverlappingSurfaceSiblings):
(WebCore::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
(CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms):
(WebCore::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
(CCOcclusionTrackerTestFilters):
(WebCore::CCOcclusionTrackerTestFilters::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectOutsideChild):
(WebCore::CCOcclusionTrackerTestLayerScissorRectOutsideChild::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectOutsideChild):
(WebCore::CCOcclusionTrackerTestScreenScissorRectOutsideChild::runMyTest):
(CCOcclusionTrackerTestDamageRectOutsideChild):
(WebCore::CCOcclusionTrackerTestDamageRectOutsideChild::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectOverChild):
(WebCore::CCOcclusionTrackerTestLayerScissorRectOverChild::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectOverChild):
(WebCore::CCOcclusionTrackerTestScreenScissorRectOverChild::runMyTest):
(CCOcclusionTrackerTestDamageRectOverChild):
(WebCore::CCOcclusionTrackerTestDamageRectOverChild::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectPartlyOverChild):
(WebCore::CCOcclusionTrackerTestLayerScissorRectPartlyOverChild::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectPartlyOverChild):
(WebCore::CCOcclusionTrackerTestScreenScissorRectPartlyOverChild::runMyTest):
(CCOcclusionTrackerTestDamageRectPartlyOverChild):
(WebCore::CCOcclusionTrackerTestDamageRectPartlyOverChild::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectOverNothing):
(WebCore::CCOcclusionTrackerTestLayerScissorRectOverNothing::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectOverNothing):
(WebCore::CCOcclusionTrackerTestScreenScissorRectOverNothing::runMyTest):
(CCOcclusionTrackerTestDamageRectOverNothing):
(WebCore::CCOcclusionTrackerTestDamageRectOverNothing::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectForLayerOffOrigin):
(WebCore::CCOcclusionTrackerTestLayerScissorRectForLayerOffOrigin::runMyTest):
(CCOcclusionTrackerTestOpaqueContentsRegionEmpty):
(WebCore::CCOcclusionTrackerTestOpaqueContentsRegionEmpty::runMyTest):
(CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty):
(WebCore::CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty::runMyTest):

17:20 Changeset [110352] by barraclough@apple.com

Array.prototype.toLocaleString visits elements in wrong order under certain conditions
https://bugs.webkit.org/show_bug.cgi?id=80663

Reviewed by Michael Saboff.

The bug here is actually that we're continuing to process the array after an exception
has been thrown, and that the second value throw is overriding the first.

Source/JavaScriptCore:

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToLocaleString):

LayoutTests:

  • fast/js/array-prototype-properties-expected.txt:
  • fast/js/script-tests/array-prototype-properties.js:
17:03 Changeset [110351] by eric@webkit.org

build-webkit should build Source/WTF on Mac
https://bugs.webkit.org/show_bug.cgi?id=80728

Reviewed by Adam Barth.

We'll add other ports to this list in future commits.

  • Scripts/build-webkit:
17:01 Changeset [110350] by ojan@chromium.org

So many Chromium-Lion rebaselines. :(

16:44 Changeset [110349] by psolanki@apple.com

Assertion failure in ResourceHandle::setDefersLoading(): d->m_defersLoading != defers
https://bugs.webkit.org/show_bug.cgi?id=80543

Reviewed by Geoffrey Garen.

Reset m_defersLoading flag to the value from Page::defersCallbacks() in
ResourceLoader::init(). This is because the resource could have been in the pending requests
queue in ResourceLoadScheduler and would have missed out on state changes to this flag
happening from DocumentLoader::setDefersCallbacks().

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::init):

16:36 Changeset [110348] by eae@chromium.org

Add roundedPoint to HitTestResult and change platform code to use it
https://bugs.webkit.org/show_bug.cgi?id=80715

Reviewed by James Robinson.

Change ports to use roundedPoint to avoid exposing subpixel types to
platform code.

Source/WebCore:

No new tests.

  • rendering/HitTestResult.h:

(WebCore::HitTestResult::roundedPoint):

Source/WebKit/chromium:

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::mouseDidMoveOverElement):

  • src/ContextMenuClientImpl.cpp:

(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

Source/WebKit/mac:

  • WebCoreSupport/WebContextMenuClient.mm:

(WebContextMenuClient::showContextMenu):

Source/WebKit/qt:

  • Api/qwebframe.cpp:

(QWebHitTestResultPrivate::QWebHitTestResultPrivate):

Source/WebKit/win:

  • WebView.cpp:

(WebView::handleContextMenuEvent):

Source/WebKit2:

  • WebProcess/WebPage/WebContextMenu.cpp:

(WebKit::WebContextMenu::show):

16:13 Changeset [110347] by haraken@chromium.org

[V8][Performance] Inline hot methods in V8Bindings.h
https://bugs.webkit.org/show_bug.cgi?id=80685

Reviewed by Adam Barth.

This patch slightly improves DOM binding performance by inlining hot
methods in V8Binding.cpp, e.g. isUndefinedOrNull(), v8StringOrNull(), v8Boolean().
For example, this patch improves div.nodeName by 5.0%, and div.nodeValue by 4.1%.

Performance tests: https://bugs.webkit.org/attachment.cgi?id=131006

The performance test results in my Mac environment are as follows:

Chromium/V8 without this patch:
div.nodeName : 3417.4 ms
div.nodeValue : 2069.6 ms

Chromium/V8 with this patch:
div.nodeName : 3245.6 ms
div.nodeValue : 1983.1 ms

No tests. No change in behavior.

  • bindings/v8/V8Binding.cpp:
  • bindings/v8/V8Binding.h:

(WebCore::toWebCoreString):
(WebCore::isUndefinedOrNull):
(WebCore::isHostObject):
(WebCore::v8Boolean):
(WebCore::toWebCoreStringWithNullCheck):
(WebCore::toAtomicWebCoreStringWithNullCheck):
(WebCore::toWebCoreStringWithNullOrUndefinedCheck):
(WebCore::v8UndetectableString):
(WebCore::v8StringOrNull):
(WebCore::v8StringOrUndefined):
(WebCore::v8StringOrFalse):
(WebCore::toWebCoreDate):
(WebCore::v8DateOrNull):

15:49 Changeset [110346] by ap@apple.com

[Mac] Pass sandbox profiles through preprocessor
https://bugs.webkit.org/show_bug.cgi?id=80651

Reviewed by Mark Rowe.

  • DerivedSources.make: Preprocess sandbox profiles.
  • PluginProcess/mac/com.apple.WebKit.PluginProcess.sb: Removed.
  • PluginProcess/mac/com.apple.WebKit.PluginProcess.sb.in: Copied from Source/WebKit2/PluginProcess/mac/com.apple.WebKit.PluginProcess.sb.
  • WebProcess/com.apple.WebProcess.sb: Removed.
  • WebProcess/com.apple.WebProcess.sb.in: Copied from Source/WebKit2/WebProcess/com.apple.WebProcess.sb. Renamed to avoid make finding the wrong original in default paths.
  • WebKit2.xcodeproj/project.pbxproj: Copy preprocessed files to Resources, not originals. Also, changed DerivedSources target to use BaseTarget.xcconfig to have correct include paths.
15:45 Changeset [110345] by arv@chromium.org

Rebaseline inspector/debugger/debugger-scripts.html

[chromium] Unreviewed gardening.

  • platform/chromium-win/inspector/debugger/debugger-scripts-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/debugger/debugger-scripts-expected.txt.
15:34 Changeset [110344] by wjmaclean@chromium.org

[chromium] Implement scroll physics architecture for impl/main thread
https://bugs.webkit.org/show_bug.cgi?id=79827

Reviewed by James Robinson.

Source/WebCore:

Unittests added, plus follow-on patch from rjkroege will add layout tests.

PlatformGestureCurve is a framework to separate the physical simulation from for gesture
animation from control concerns. This allows the physics to be reused in alternate places.
At present, the framework will be applied in ScrollAnimatorNone and the Chrome Compositor.

  • WebCore.gypi:
  • platform/ActivePlatformGestureAnimation.cpp: Added.

(WebCore):
(WebCore::ActivePlatformGestureAnimation::create):
(WebCore::ActivePlatformGestureAnimation::~ActivePlatformGestureAnimation):
(WebCore::ActivePlatformGestureAnimation::ActivePlatformGestureAnimation):
(WebCore::ActivePlatformGestureAnimation::animate):

  • platform/ActivePlatformGestureAnimation.h: Added.

(WebCore):
(ActivePlatformGestureAnimation):

  • platform/PlatformGestureCurve.h: Added.

(WebCore):
(PlatformGestureCurve):
(WebCore::PlatformGestureCurve::~PlatformGestureCurve):

  • platform/PlatformGestureCurveTarget.h: Added.

(WebCore):
(PlatformGestureCurveTarget):
(WebCore::PlatformGestureCurveTarget::~PlatformGestureCurveTarget):

  • platform/TouchFlingPlatformGestureCurve.cpp: Added.

(WebCore):
(WebCore::TouchFlingPlatformGestureCurve::create):
(WebCore::TouchFlingPlatformGestureCurve::TouchFlingPlatformGestureCurve):
(WebCore::TouchFlingPlatformGestureCurve::~TouchFlingPlatformGestureCurve):
(WebCore::TouchFlingPlatformGestureCurve::apply):

  • platform/TouchFlingPlatformGestureCurve.h: Added.

(WebCore):
(TouchFlingPlatformGestureCurve):

  • platform/WheelFlingPlatformGestureCurve.cpp: Added.

(WebCore):
(WebCore::WheelFlingPlatformGestureCurve::create):
(WebCore::WheelFlingPlatformGestureCurve::WheelFlingPlatformGestureCurve):
(WebCore::WheelFlingPlatformGestureCurve::~WheelFlingPlatformGestureCurve):
(WebCore::WheelFlingPlatformGestureCurve::apply):

  • platform/WheelFlingPlatformGestureCurve.h: Added.

(WebCore):
(WheelFlingPlatformGestureCurve):

  • platform/graphics/chromium/cc/CCActiveGestureAnimation.cpp: Added.

(WebCore):
(WebCore::CCActiveGestureAnimation::create):
(WebCore::CCActiveGestureAnimation::CCActiveGestureAnimation):
(WebCore::CCActiveGestureAnimation::~CCActiveGestureAnimation):
(WebCore::CCActiveGestureAnimation::animate):

  • platform/graphics/chromium/cc/CCActiveGestureAnimation.h: Added.

(WebCore):
(CCActiveGestureAnimation):

  • platform/graphics/chromium/cc/CCGestureCurve.h: Added.

(WebCore):
(CCGestureCurveTarget):
(WebCore::CCGestureCurveTarget::~CCGestureCurveTarget):
(CCGestureCurve):
(WebCore::CCGestureCurve::~CCGestureCurve):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/PlatformGestureCurveTest.cpp: Added.
15:27 Changeset [110343] by ojan@chromium.org

More Chromium-Lion rebaselines.

15:25 Changeset [110342] by rniwa@webkit.org

WebKit compiled by gcc (Xcode 3.2.6) hangs while running DOM/Accessors.html
https://bugs.webkit.org/show_bug.cgi?id=80080

Reviewed by Filip Pizlo.

  • bytecode/SamplingTool.cpp:

(JSC::SamplingRegion::Locker::Locker):
(JSC::SamplingRegion::Locker::~Locker):

  • bytecode/SamplingTool.h:

(JSC::SamplingRegion::exchangeCurrent):

  • wtf/Atomics.h:

(WTF):
(WTF::weakCompareAndSwap):
(WTF::weakCompareAndSwapUIntPtr):

15:25 Changeset [110341] by leviw@chromium.org

Fixing a paint at a non-rounded LayoutPoint.

15:11 Changeset [110340] by alexis.menard@openbossa.org

Implement selectedOptions attribute of <select>.
https://bugs.webkit.org/show_bug.cgi?id=80631

Reviewed by Benjamin Poulain.

Source/WebCore:

Add a new collection as a member of HTMLSelectElement which is
used to store the selected elements. Extend HTMLCollection to
support the new collection type needed by this feature.

Reference : http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#dom-select-selectedoptions

Test: fast/dom/select-selectedOptions.html

  • html/CollectionType.h:
  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::shouldIncludeChildren):
(WebCore::HTMLCollection::isAcceptableElement):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::selectedOptions):
(WebCore):

  • html/HTMLSelectElement.h:

(HTMLSelectElement):

  • html/HTMLSelectElement.idl:

LayoutTests:

New tests to cover the feature.

  • fast/dom/select-selectedOptions-expected.txt: Added.
  • fast/dom/select-selectedOptions.html: Added.
15:06 Changeset [110339] by leviw@chromium.org

Fixing integer truncation issue around contentWidth/Height, a duplicated FractionalLayoutSize.cpp reference in cmake, and unnecessary layout units in RenderEmbeddedObject.

15:04 Changeset [110338] by jamesr@google.com

[chromium] ScrollbarLayerChromium/CCScrollbarLayerImpl for CC-side scrollbar painting
https://bugs.webkit.org/show_bug.cgi?id=78872

Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-03-09
Reviewed by James Robinson.

Source/WebCore:

New test ScrollbarLayerChromiumTest.resolveScrollLayerPointer

  • WebCore.gypi:
  • page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::scrollLayerForFrameView):
(WebCore::scrollbarLayerDidChange):
(WebCore):
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::invalidateScrollbar):

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(WebCore::GraphicsLayerChromium::hasContentsLayer):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore):
(WebCore::LayerChromium::toScrollbarLayerChromium):
(LayerChromium):

  • platform/graphics/chromium/ScrollbarLayerChromium.cpp: Added.

(WebCore):
(WebCore::ScrollbarLayerChromium::createCCLayerImpl):
(WebCore::ScrollbarLayerChromium::create):
(WebCore::ScrollbarLayerChromium::ScrollbarLayerChromium):
(WebCore::ScrollbarLayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/ScrollbarLayerChromium.h: Added.

(WebCore):
(ScrollbarLayerChromium):
(WebCore::ScrollbarLayerChromium::scrollLayerId):
(WebCore::ScrollbarLayerChromium::toScrollbarLayerChromium):

  • platform/graphics/chromium/TreeSynchronizer.cpp:

(WebCore::TreeSynchronizer::synchronizeTrees):
(WebCore::TreeSynchronizer::collectExistingCCLayerImplRecursive):
(WebCore::TreeSynchronizer::reuseOrCreateCCLayerImpl):
(WebCore::TreeSynchronizer::synchronizeTreeRecursive):
(WebCore::TreeSynchronizer::updateScrollbarLayerPointersRecursive):
(WebCore):

  • platform/graphics/chromium/TreeSynchronizer.h:

(TreeSynchronizer):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::updateMaxScrollPosition):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp: Added.

(WebCore):
(WebCore::CCScrollbarLayerImpl::create):
(WebCore::CCScrollbarLayerImpl::CCScrollbarLayerImpl):
(WebCore::CCScrollbarLayerImpl::willDraw):
(WebCore::CCScrollbarLayerImpl::appendQuads):
(WebCore::CCScrollbarLayerImpl::didDraw):
(WebCore::CCScrollbarLayerImpl::paint):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::x):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::y):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::width):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::height):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::size):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::location):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::parent):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::root):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::setFrameRect):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::frameRect):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::invalidate):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::invalidateRect):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::scrollbarOverlayStyle):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::getTickmarks):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::isScrollableAreaActive):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::isScrollViewScrollbar):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::convertFromContainingWindow):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::isCustomScrollbar):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::orientation):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::value):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::currentPos):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::visibleSize):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::totalSize):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::maximum):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::controlSize):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::lineStep):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::pageStep):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::pressedPart):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::hoveredPart):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::styleChanged):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::enabled):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::setEnabled):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.h: Added.

(WebCore):
(CCScrollbarLayerImpl):
(WebCore::CCScrollbarLayerImpl::setScrollbarOverlayStyle):
(WebCore::CCScrollbarLayerImpl::setTickmarks):
(WebCore::CCScrollbarLayerImpl::setIsScrollableAreaActive):
(WebCore::CCScrollbarLayerImpl::setIsScrollViewScrollbar):
(WebCore::CCScrollbarLayerImpl::setOrientation):
(WebCore::CCScrollbarLayerImpl::setControlSize):
(WebCore::CCScrollbarLayerImpl::setPressedPart):
(WebCore::CCScrollbarLayerImpl::setHoveredPart):
(WebCore::CCScrollbarLayerImpl::setEnabled):
(WebCore::CCScrollbarLayerImpl::scrollLayer):
(WebCore::CCScrollbarLayerImpl::setScrollLayer):
(CCScrollbar):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::CCScrollbar):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/ScrollbarLayerChromiumTest.cpp: Added.

(WebCore):
(MockScrollbar):
(WebCore::MockScrollbar::x):
(WebCore::MockScrollbar::y):
(WebCore::MockScrollbar::width):
(WebCore::MockScrollbar::height):
(WebCore::MockScrollbar::size):
(WebCore::MockScrollbar::location):
(WebCore::MockScrollbar::parent):
(WebCore::MockScrollbar::root):
(WebCore::MockScrollbar::setFrameRect):
(WebCore::MockScrollbar::frameRect):
(WebCore::MockScrollbar::invalidate):
(WebCore::MockScrollbar::invalidateRect):
(WebCore::MockScrollbar::scrollbarOverlayStyle):
(WebCore::MockScrollbar::getTickmarks):
(WebCore::MockScrollbar::isScrollableAreaActive):
(WebCore::MockScrollbar::isScrollViewScrollbar):
(WebCore::MockScrollbar::convertFromContainingWindow):
(WebCore::MockScrollbar::isCustomScrollbar):
(WebCore::MockScrollbar::orientation):
(WebCore::MockScrollbar::value):
(WebCore::MockScrollbar::currentPos):
(WebCore::MockScrollbar::visibleSize):
(WebCore::MockScrollbar::totalSize):
(WebCore::MockScrollbar::maximum):
(WebCore::MockScrollbar::controlSize):
(WebCore::MockScrollbar::lineStep):
(WebCore::MockScrollbar::pageStep):
(WebCore::MockScrollbar::pressedPart):
(WebCore::MockScrollbar::hoveredPart):
(WebCore::MockScrollbar::styleChanged):
(WebCore::MockScrollbar::enabled):
(WebCore::MockScrollbar::setEnabled):
(WebCore::MockScrollbar::MockScrollbar):
(WebCore::MockScrollbar::~MockScrollbar):
(WebCore::TEST):

15:03 Changeset [110337] by mrowe@apple.com

Versioning.

14:58 Changeset [110336] by jchaffraix@webkit.org

Split the extra logical height distribution logic out of RenderTableSection::layoutRows
https://bugs.webkit.org/show_bug.cgi?id=80671

Reviewed by Adrienne Walker.

Refactoring only, no change in behavior expected.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):
Split the logic from here...

(WebCore::RenderTableSection::distributeExtraLogicalHeightToPercentRows):
(WebCore::RenderTableSection::distributeExtraLogicalHeightToAutoRows):
(WebCore::RenderTableSection::distributeRemainingExtraLogicalHeight):
(WebCore::RenderTableSection::distributeExtraLogicalHeightToRows):
... to those functions. Cleaned up the variable naming while at it and
made them follow the same signature as this may be useful to fix another
bug I have.

  • rendering/RenderTableSection.h:

(RenderTableSection):
Added the previous 4 new functions.

14:53 Changeset [110335] by mrowe@apple.com

New tag.

14:52 Changeset [110334] by rwlbuis@webkit.org

Remove unused file FrameBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=80731

Reviewed by Antonio Gomes.

This is not needed anymore since there is an implementation elsewhere.

  • PlatformBlackBerry.cmake:
  • page/blackberry/FrameBlackBerry.cpp: Removed.
14:43 Changeset [110333] by abarth@webkit.org

Unreviewed, rolling out r110309.
http://trac.webkit.org/changeset/110309
https://bugs.webkit.org/show_bug.cgi?id=80732

Seems to have caused a number of SVG crashes (thorton will
investigate further) (Requested by abarth|gardener on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-09

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::deferredRepaintTimerFired):

  • page/FrameView.h:

(FrameView):

  • rendering/RenderView.cpp:

(WebCore::RenderView::shouldRepaint):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawSVGToImageBuffer):
(WebCore::SVGImage::draw):

  • svg/graphics/SVGImage.h:
  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::imageContentChanged):
(WebCore::SVGImageCache::redrawTimerFired):

  • svg/graphics/SVGImageCache.h:

(SVGImageCache):

14:36 Changeset [110332] by commit-queue@webkit.org

Crash due to inserting letter into div with first-letter
https://bugs.webkit.org/show_bug.cgi?id=78534

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-03-09
Reviewed by David Hyatt.

Source/WebCore:

This fixes an issue in RenderTextFragment with setTextInternal
getting called with different intents. While most calls to it
are intended to change the underlying DOM node string, it can
also be called as a result of styleDidChange just for transforms
on the substring text fragment. This adds a mechanism for internal
callers to specify if the internal text is being updated without
a DOM node text change.

  • rendering/RenderTextFragment.cpp:

(WebCore::RenderTextFragment::styleDidChange)
(WebCore::RenderTextFragment::setTextInternal)

  • rendering/RenderTextFragment.h:

(WebCore::RenderTextFragment)

LayoutTests:

Test case to exercise the crashing condition in bug 78534. It inserts
a character in a first-letter div to induce an invalid RenderTextFragment
state.

  • editing/inserting/insert-character-in-first-letter-crash-expected.txt: Added
  • editing/inserting/insert-character-in-first-letter-crash.html: Added
14:31 Changeset [110331] by barraclough@apple.com

REGRESSION: Date.parse("Tue Nov 23 20:40:05 2010 GMT") returns NaN
https://bugs.webkit.org/show_bug.cgi?id=49989

Reviewed by Oliver Hunt.

Patch originally by chris reiss <christopher.reiss@nokia.com>,
allow the year to appear before the timezone in date strings.

Source/JavaScriptCore:

  • wtf/DateMath.cpp:

(WTF::parseDateFromNullTerminatedCharacters):

LayoutTests:

  • fast/js/date-parse-test-expected.txt:
  • fast/js/script-tests/date-parse-test.js:
14:24 Changeset [110330] by crogers@google.com

Fix uninitialized variable in DynamicsCompressor
https://bugs.webkit.org/show_bug.cgi?id=80724

Reviewed by James Robinson.

  • platform/audio/DynamicsCompressor.cpp:

(WebCore::DynamicsCompressor::DynamicsCompressor):

14:04 Changeset [110329] by ojan@chromium.org

Move some results from mac-future to mac. mac-future should not exist.
See https://bugs.webkit.org/show_bug.cgi?id=80717 for how these got there
in the first place.

  • platform/mac-future/svg/W3C-I18N/g-dirLTR-ubNone-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-no-markup-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/tspan-direction-rtl-expected.png: Removed.
  • platform/mac-future/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png: Removed.
  • platform/mac-future/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Removed.
  • platform/mac-future/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Removed.
  • platform/mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/mac/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Renamed from LayoutTests/platform/mac-future/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
13:50 Changeset [110328] by arv@chromium.org

[V8] Undo text position adjustment for attribute event handlers
https://bugs.webkit.org/show_bug.cgi?id=80725

Reviewed by Adam Barth.

No new tests. Needs rebaseline.

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

13:34 Changeset [110327] by mrowe@apple.com

Ensure that the WTF headers are copied at installhdrs time.

Reviewed by Dan Bernstein and Jessie Berlin.

  • Configurations/JavaScriptCore.xcconfig: Set INSTALLHDRS_SCRIPT_PHASE = YES

so that our script phases are invoked at installhdrs time. The only one that
does any useful work at that time is the one that installs WTF headers.

13:34 Changeset [110326] by tsepez@chromium.org

Hold cached images with a CachedResourceHandle rather than a raw pointer for CSSCrossfadeValue
https://bugs.webkit.org/show_bug.cgi?id=80186

Reviewed by Simon Fraser.

Source/WebCore:

Test: http/tests/css/cross-fade-reload.html

  • css/CSSCrossfadeValue.h:

(CSSCrossfadeValue):

LayoutTests:

  • http/tests/css/cross-fade-reload-expected.txt: Added.
  • http/tests/css/cross-fade-reload.html: Added.
  • http/tests/css/resources/abe.png: Added.
13:32 Changeset [110325] by jamesr@google.com

[chromium] Expose the shared graphics context on WebView so callers can allocate resources on the main thread for the compositor to use
https://bugs.webkit.org/show_bug.cgi?id=80670

Reviewed by Stephen White.

This exposes a context on WebView that is in the compositor's share group and can be used directly from the main
thread. This is useful for content that needs to allocate resources for the compositor to use, but cannot
directly use the compositor's context either because it cannot access the correct thread or because it needs to
initialize in situations where we cannot initialize a compositor (view) context - for instance before the native
window is created.

  • public/WebView.h:

(WebView):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::sharedGraphicsContext3D):
(WebKit):

  • src/WebViewImpl.h:

(WebViewImpl):

13:14 Changeset [110324] by inferno@chromium.org

Crash when splitting an anonymous block in multi-column layout.
https://bugs.webkit.org/show_bug.cgi?id=80432

Reviewed by David Hyatt.

Source/WebCore:

Calculating currChild->nextSibling() is risky after destroying :after content
because it can blow away currChild if it is a left over empty anonymous block.
We need to calculate next sibling upfront, using the same trick, we do in
RenderBlock::addChildIgnoringAnonymousColumnBlock to reset beforeChild (check
out the line before splitFlow call).

Test: fast/multicol/anonymous-block-split-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::splitBlocks):

LayoutTests:

  • fast/multicol/anonymous-block-split-crash-expected.txt: Added.
  • fast/multicol/anonymous-block-split-crash.html: Added.
13:12 Changeset [110323] by inferno@chromium.org

Crash due to accessing removed parent lineboxes when clearing selection.
https://bugs.webkit.org/show_bug.cgi?id=79264

Reviewed by Dave Hyatt.

Source/WebCore:

Test: editing/selection/first-letter-selection-crash.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::setSelectionState):

  1. No need of checking if we are being set to same selection state.

Now tested by setSelectionStateIfNeeded. Rename 's' with 'state' and
'cb' with 'containingBlock'.

  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::setSelectionState):

  1. Add check to canUpdateSelectionOnRootLineBoxes to make sure our

root line boxes are still valid before setting them.

  1. No need of calling setSelectionState on containing block since our base

class call to RenderBox::setSelectionState covers it. Added a comment to indicate that.

  1. Use m_inlineBoxWrapper variable directly to simplify the ifs.
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::canUpdateSelectionOnRootLineBoxes):
(WebCore): helper function to tell if we can update selection information
on our root line boxes. This returns false if our containing block is pending layout.

  • rendering/RenderObject.h:

(RenderObject):
(WebCore::RenderObject::setSelectionStateIfNeeded):
(WebCore): helper to set selection state only if it is different from our
current selection state.

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::setSelectionState):

  1. Rename 's' to 'state', 'line' to 'root' and use m_inlineBoxWrapper directly

to simplify ifs.

  1. Add check to canUpdateSelectionOnRootLineBoxes to make sure our

root line boxes are still valid before setting them.

  • rendering/RenderText.cpp:

(WebCore::RenderText::setSelectionState):

  1. Add check to canUpdateSelectionOnRootLineBoxes to make sure our

root line boxes are still valid before setting them.

  1. Rename 'cb' to 'containingBlock', 'line' to 'root', move InlineTextBox

declaration to local.

  • rendering/RenderView.cpp:

(WebCore::RenderView::setSelection): Replace all calls to setSelectionState
with setSelectionStateIfNeeded.

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::setSelectionState):

  1. No need of checking if we are being set to same selection state.

Now tested by setSelectionStateIfNeeded.

LayoutTests:

  • editing/selection/first-letter-selection-crash-expected.txt: Added.
  • editing/selection/first-letter-selection-crash.html: Added.
13:04 Changeset [110322] by leviw@chromium.org

Move TransformationMatrix and TransformState to LayoutUnits.
https://bugs.webkit.org/show_bug.cgi?id=80632

Reviewed by Simon Fraser.

When we move layout to sub-pixel precision, we want to preserve that precision through
transformations. This change readies TransformState and TransformationMatrix to make
use of this additional precision in accumulating transforms, and in returning rects that
preserve it.

No new tests. No change in behavior.

  • platform/graphics/transforms/TransformState.cpp:

(WebCore::TransformState::move): Changed to pass along LayoutUnits to the contained
TransformationMatrix. The values of the LayoutUnits will be implicitly converted to
floats to be applied.

  • platform/graphics/transforms/TransformState.h:

(WebCore::TransformState::move): Ditto.
(TransformState):

  • platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::clampEdgeValue): Limiting edges to the maximum LayoutUnit value to prevent
overflow..
(WebCore::TransformationMatrix::clampedBoundsOfProjectedQuad): Same as above, but also
returning a LayoutRect which preserves additional precision than the previous IntRect.
(WebCore::TransformationMatrix::mapRect): Adding a version of this method that operates
specifically on FractionalLayoutRects.
(WebCore):

  • platform/graphics/transforms/TransformationMatrix.h:

(WebCore):
(TransformationMatrix):

  • rendering/LayoutTypes.h:

(WebCore::clampToLayoutUnit):
(WebCore):

12:53 Changeset [110321] by rniwa@webkit.org

Remove a bogus assertion. This condition is no longer true for non-document tree scopes.

  • dom/TreeScope.cpp:

(WebCore::TreeScope::activeElement):

12:34 Changeset [110320] by rniwa@webkit.org

Cleanup incDOMTreeVersion callers
https://bugs.webkit.org/show_bug.cgi?id=80452

Reviewed by Andreas Kling.

Unify various calls to incDOMTreeVersion and namely remove the call inside dispatchSubtreeModifiedEvent.
There should be no behavioral change and therefore there is no new test.

  • dom/CharacterData.cpp:

(WebCore::CharacterData::parserAppendData):
(WebCore::CharacterData::setDataAndUpdate):

  • dom/ContainerNode.cpp:

(WebCore::willRemoveChild):
(WebCore::willRemoveChildren):
(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::childrenChanged):
(WebCore::notifyChildInserted):

  • dom/Element.cpp:

(WebCore::Element::attributeChanged):
(WebCore::Element::parserSetAttributes):
(WebCore::Element::willModifyAttribute):

  • dom/Node.cpp:

(WebCore::Node::dispatchSubtreeModifiedEvent):

  • html/HTMLOutputElement.cpp:

(WebCore::HTMLOutputElement::childrenChanged):

  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::childrenChanged):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::childrenChanged):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::childrenChanged):

  • html/HTMLTitleElement.cpp:

(WebCore::HTMLTitleElement::childrenChanged):

  • svg/SVGScriptElement.cpp:

(WebCore::SVGScriptElement::childrenChanged):

  • svg/SVGStyleElement.cpp:

(WebCore::SVGStyleElement::childrenChanged):

12:29 Changeset [110319] by paroga@webkit.org

Build fix for !ENABLE(FILTERS) after r110285.

  • rendering/svg/SVGRenderingContext.h:

(WebCore::SVGRenderingContext::SVGRenderingContext):

12:27 Changeset [110318] by dbates@webkit.org

Bash scripts should support LF endings only
https://bugs.webkit.org/show_bug.cgi?id=79509

Actually commit the changes that should have been landed in <http://trac.webkit.org/changeset/110306>.
For some reason, webkit-patch land only committed the changes to the ChangeLog files.

12:22 Changeset [110317] by commit-queue@webkit.org

[chromium] Use opaque paints in CCOcclusionTracker
https://bugs.webkit.org/show_bug.cgi?id=80173

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-09
Reviewed by Adrienne Walker.

Source/WebCore:

Use tracked opaque paints in the tiles when tracking occlusion in
CCOcclusionTracker. Moves the Tile::m_opaqueRect up to the super-
class in CCLayerTilingData rather than having it declared in both
TiledLayerChromium and CCTiledLayerImpl. This lets the CCLayerTilingData
class compute the opaque region for its tiles, sharing code between the
two tiled layer implementations.

Use of this feature is guarded behind a runtime flag and turned off for
paint culling. We will enable it in the future once we're comfortable
with the paint culling.

Unit test: CCOcclusionTrackerTest.opaqueContentsRegionEmpty

CCOcclusionTrackerTest.opaqueContentsRegionNonEmpty
TiledLayerChromiumTest.opaqueContentsRegion

All existing CCOcclusionTrackerTest.* duplicated with opaque painted
rects.

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::opaqueContentsRegion):
(LayerChromium):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(UpdatableTile):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::addSelfToOccludedScreenSpace):
(WebCore::TiledLayerChromium::opaqueContentsRegion):
(WebCore):

  • platform/graphics/chromium/TiledLayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::opaqueContentsRegion):
(CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTilingData.cpp:

(WebCore::CCLayerTilingData::opaqueRegionInLayerRect):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerTilingData.h:

(WebCore):
(Tile):
(WebCore::CCLayerTilingData::Tile::opaqueRect):
(WebCore::CCLayerTilingData::Tile::setOpaqueRect):
(CCLayerTilingData):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::CCOcclusionTrackerBase):
(WebCore::computeOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):

  • platform/graphics/chromium/cc/CCOcclusionTracker.h:

(CCOcclusionTrackerBase):
(WebCore::CCOcclusionTrackerBase::setUsePaintTracking):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(DrawableTile):
(WebCore::CCTiledLayerImpl::opaqueContentsRegion):
(WebCore):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:

(CCTiledLayerImpl):

Source/WebKit/chromium:

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore::LayerChromiumWithForcedDrawsContent::opaqueContentsRegion):
(LayerChromiumWithForcedDrawsContent):
(WebCore::LayerChromiumWithForcedDrawsContent::setOpaquePaintRect):
(WebCore::setLayerPropertiesForTesting):
(WebCore):
(WebCore::layerAddedToOccludedRegion):
(WebCore::layerAddedToOccludedRegionWithRotation):
(WebCore::layerAddedToOccludedRegionWithTranslation):
(WebCore::layerAddedToOccludedRegionWithRotatedSurface):
(WebCore::layerAddedToOccludedRegionWithSurfaceAlreadyOnStack):
(WebCore::layerAddedToOccludedRegionWithRotatedOffAxisSurface):
(WebCore::layerAddedToOccludedRegionWithMultipleOpaqueLayers):
(WebCore::surfaceOcclusionWithOverlappingSiblingSurfaces):
(WebCore::surfaceOcclusionInScreenSpace):
(WebCore::surfaceOcclusionInScreenSpaceDifferentTransforms):
(WebCore::occlusionInteractionWithFilters):
(WebCore::layerScissorRectOverTile):
(WebCore::screenScissorRectOverTile):
(WebCore::layerScissorRectOverCulledTile):
(WebCore::screenScissorRectOverCulledTile):
(WebCore::layerScissorRectOverPartialTiles):
(WebCore::screenScissorRectOverPartialTiles):
(WebCore::layerScissorRectOverNoTiles):
(WebCore::screenScissorRectOverNoTiles):
(WebCore::layerScissorRectForLayerOffOrigin):
(WebCore::damageRectOverTile):
(WebCore::damageRectOverCulledTile):
(WebCore::damageRectOverPartialTiles):
(WebCore::damageRectOverNoTiles):
(WebCore::TEST):

  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):
(WTF):

12:16 Changeset [110316] by antti@apple.com

Presentation attribute cache
https://bugs.webkit.org/show_bug.cgi?id=80707

Reviewed by Andreas Kling.

It is common for the same presentation attribute values repeat. We should introduce a cache that uses
presentation attribute names and values as key. This will help to avoid repeated parsing of the
same attribute values, reduce memory consumption and speed up the style resolve.

This patch introduces a simple and small (128 entries) global cache. In general web browsing it seems
to give sharing rate of >75% (an average presentation attribute property set is shared between >4 elements).

  • dom/StyledElement.cpp:

(WebCore::PresentationAttributeCacheKey::PresentationAttributeCacheKey):
(PresentationAttributeCacheKey):
(WebCore):
(WebCore::operator!=):
(PresentationAttributeCacheEntry):
(WebCore::presentationAttributeCache):
(WebCore::attributeNameSort):
(WebCore::StyledElement::makePresentationAttributeCacheKey):
(WebCore::computePresentationAttributeCacheHash):
(WebCore::StyledElement::updateAttributeStyle):

  • dom/StyledElement.h:

(WebCore):
(StyledElement):

12:12 Changeset [110315] by arv@chromium.org

[V8] Fix object scope for inline event attribute handlers
https://bugs.webkit.org/show_bug.cgi?id=80329

Reviewed by Ojan Vafai.

Source/WebCore:

We now create the funciton inside the with-statements with the current scope objects.
This is important for a few reasons:

  • We need to use the real objects and not just lookup the JS properties because these might have been overridden.
  • We need to use the node, form and document at the time of the preparation and not at the time of calling.
  • We need to ensure that event/evt is bound closer than a property with the same name in the object environment created by the with-statements.

Tests: fast/dom/inline-event-attributes-lookup-removed-form.html

fast/dom/inline-event-attributes-lookup-removed.html
fast/dom/inline-event-attributes-lookup.html

  • bindings/v8/ScriptEventListener.cpp:

(WebCore::eventParameterName):
(WebCore):
(WebCore::createAttributeEventListener):

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::V8LazyEventListener):
(WebCore):
(WebCore::toObjectWrapper):
(WebCore::V8LazyEventListener::callListenerFunction):
(WebCore::V8LazyEventListener::prepareListenerObject):

  • bindings/v8/V8LazyEventListener.h:

(WebCore):
(WebCore::V8LazyEventListener::create):
(V8LazyEventListener):

LayoutTests:

  • fast/dom/inline-event-attributes-lookup-expected.txt: Added.
  • fast/dom/inline-event-attributes-lookup-removed-expected.txt: Added.
  • fast/dom/inline-event-attributes-lookup-removed-form-expected.txt: Added.
  • fast/dom/inline-event-attributes-lookup-removed-form.html: Added.
  • fast/dom/inline-event-attributes-lookup-removed.html: Added.
  • fast/dom/inline-event-attributes-lookup.html: Added.
  • fast/forms/lazy-event-listener-scope-chain-expected.txt:
  • fast/forms/lazy-event-listener-scope-chain.html:
12:07 Changeset [110314] by schenney@chromium.org

Crash in WebCore::SVGUseElement::instanceForShadowTreeElement
https://bugs.webkit.org/show_bug.cgi?id=80406

Reviewed by Nikolas Zimmermann.

Code assumes that an object that is an SVG Element and in a shadow
tree must be in an SVG use shadow tree, and casts the shadow host with
a static_cast. It may be that an SVG element appears in a non-use
shadow tree, in which case bad things happen. While it appears that
the current code prevents such a situation from arising (checks are
made within the shadow tree code to prevent it) there are also
indications that the situation may change.

No new tests. I believe that the problem here cannot currently be
reproduced. That is, other code prevents SVG elements from appearing
in non-svg shadow trees.

  • dom/EventDispatcher.cpp:

(WebCore::eventTargetRespectingSVGTargetRules):

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::title):

12:06 Changeset [110313] by ojan@chromium.org

2012-03-09 Ojan Vafai <ojan@chromium.org (:ojan) (r)>

Add image/png svn:mime-type to all png images that currently lack
an svn:mime-type. Correctly this time.

12:00 Changeset [110312] by ojan@chromium.org

Add image/png svn:mime-type to all png images that currently lack
and svn:mime-type.

11:41 Changeset [110311] by jonlee@apple.com

Add support for ENABLE(LEGACY_NOTIFICATIONS)
https://bugs.webkit.org/show_bug.cgi?id=80497

Reviewed by Adam Barth.

.:

Prep for b80472: Update API for Web Notifications

  • Source/cmake/OptionsBlackBerry.cmake:
  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsWinCE.cmake:
  • Source/cmakeconfig.h.cmake:
  • configure.ac:

Source/JavaScriptCore:

Prep for b80472: Update API for Web Notifications

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Prep for b80472: Update API for Web Notifications

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:

Source/WebKit/chromium:

Prep for b80472: Update API for Web Notifications

  • features.gypi:

Source/WebKit/mac:

Prep for b80472: Update API for Web Notifications

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/qt:

Prep for b80472: Update API for Web Notifications

  • examples/platformplugin/platformplugin.pro:

Source/WebKit2:

Prep for b80472: Update API for Web Notifications

  • Configurations/FeatureDefines.xcconfig:

Tools:

Prep for b80472: Update API for Web Notifications

  • Scripts/build-webkit:
  • qmake/mkspecs/features/features.prf:

WebKitLibraries:

Prep for b80472: Update API for Web Notifications

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
11:38 Changeset [110310] by commit-queue@webkit.org

ShadowRoot should implement activeElement.
https://bugs.webkit.org/show_bug.cgi?id=79886

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2012-03-09
Reviewed by Ryosuke Niwa.

Source/WebCore:

Implement the activeElement attribute for ShadowRoot to return the
currently focused element in the shadow DOM subtree.

Test: fast/dom/shadow/shadow-root-activeElement.html

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::activeElement):
(WebCore):

  • dom/ShadowRoot.h:

(ShadowRoot):

  • dom/ShadowRoot.idl:
  • dom/TreeScope.cpp:

(WebCore::TreeScope::adoptIfNeeded):
(WebCore):
(WebCore::focusedFrameOwnerElement):
(WebCore::TreeScope::activeElement):

  • dom/TreeScope.h:

(TreeScope):

  • html/HTMLDocument.cpp:

(WebCore):
(WebCore::HTMLDocument::activeElement):

LayoutTests:

Added test case for activeElement attribute of ShadowRoot.

  • fast/dom/shadow/shadow-root-activeElement-expected.txt: Added.
  • fast/dom/shadow/shadow-root-activeElement.html: Added.
  • platform/mac/Skipped: Added test case in Skipped as ShadowRoot is supported by Chromium only.
  • platform/qt/Skipped: ditto.
  • platform/win/Skipped: ditto.
  • platform/wincairo/Skipped: ditto.
  • platform/wk2/Skipped: ditto.
11:21 Changeset [110309] by timothy_horton@apple.com

Infinite repaint loop with SVGImageCache and deferred repaint timers
https://bugs.webkit.org/show_bug.cgi?id=78315
<rdar://problem/10651634>

Reviewed by Nikolas Zimmermann.

Only defer image redraw on a timer if we're in layout. This breaks
the repaint loop while still preventing us from drawing inside layout.

Completely disable repaint during relayout inside SVGImage::drawSVGToImageBuffer,
preventing deferred repaint timers from being started during that process.

No new tests, as the problem only occurs in a nonstandard configuration.

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::draw):
(WebCore::SVGImage::frameView):
(WebCore):

  • svg/graphics/SVGImage.h:

(WebCore):

  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::imageContentChanged):
(WebCore::SVGImageCache::redraw):
(WebCore::SVGImageCache::redrawTimerFired):
(WebCore):

  • svg/graphics/SVGImageCache.h:

(SVGImageCache):

11:16 Changeset [110308] by commit-queue@webkit.org

Source/WebCore: The method TextTrackCue::getCueAsHTML() should return different
fragments on different calls.

https://bugs.webkit.org/show_bug.cgi?id=80701

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-03-09
Reviewed by Eric Carlson.

Test: media/track/track-cue-mutable-fragment.html

  • html/track/TextTrackCue.cpp: Removed setCueHTML(), since it is sufficient

to create apply the DOM rules only when the fragment is first requested.
(WebCore::TextTrackCue::getCueAsHTML): Changed the method such that a
a clone of the cached document fragment is returned.

  • html/track/TextTrackCue.h: Removed setCueHTML() as the document fragment

of the cue should be created only within the class, from the cue text.
(TextTrackCue):

  • html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::createNewCue): removed usage of setCueHTML()

LayoutTests: Added relevant layout tests to verify that the fragment can be appended
multiple times to the DOM and modified correctly.

https://bugs.webkit.org/show_bug.cgi?id=80701

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-03-09
Reviewed by Eric Carlson.

  • media/track/captions-webvtt/captions-html.vtt: Added. This file could

be used later for more complex html / css rendering tests.

  • media/track/track-cue-mutable-fragment-expected.txt: Added.
  • media/track/track-cue-mutable-fragment.html: Added.
11:13 Changeset [110307] by timothy_horton@apple.com

Crash in SVGTextLayoutAttributesBuilder::fillCharacterDataMap
https://bugs.webkit.org/show_bug.cgi?id=78949
<rdar://problem/10889440>

Reviewed by Nikolas Zimmermann.

Invalidate the text positioning cache when the children of an SVGAElement change,
so that we regenerate the list the next time it's needed instead of using stale values.

Test: svg/text/text-positioning-remove-child-crash.svg

  • rendering/svg/SVGAElement.cpp:

(WebCore::SVGAElement::childrenChanged):

Add a test ensuring that we don't crash when removing a child of <a> inside a <text> block.

  • svg/text/text-positioning-remove-child-crash-expected.txt: Added.
  • svg/text/text-positioning-remove-child-crash.svg: Added.
11:09 Changeset [110306] by dbates@webkit.org

Bash scripts should support LF endings only
https://bugs.webkit.org/show_bug.cgi?id=79509

Patch by Ashod Nakashian <ashodnakashian@yahoo.com> on 2012-03-09
Reviewed by David Kilzer.

Source/JavaScriptCore:

  • gyp/generate-derived-sources.sh: Added property svn:eol-style.
  • gyp/run-if-exists.sh: Added property svn:eol-style.
  • gyp/update-info-plist.sh: Added property svn:eol-style.

Source/ThirdParty:

  • gtest/xcode/Samples/FrameworkSample/runtests.sh: Added property svn:executable.
  • gtest/xcode/Scripts/runtests.sh: Added property svn:executable.

Source/ThirdParty/ANGLE:

  • src/compiler/generate_parser.sh: Added property svn:eol-style.

Source/WebCore:

  • WebCore.gyp/mac/adjust_visibility.sh: Added property svn:eol-style.
  • WebCore.vcproj/build-generated-files.sh: Added property svn:executable.
  • WebCore.vcproj/migrate-scripts.sh: Added property svn:executable.
  • gyp/copy-forwarding-and-icu-headers.sh: Added property svn:eol-style.
  • gyp/copy-inspector-resources.sh: Added property svn:eol-style.
  • gyp/generate-derived-sources.sh: Added property svn:eol-style.
  • gyp/generate-webcore-export-file-generator.sh: Added property svn:eol-style.
  • gyp/run-if-exists.sh: Added property svn:eol-style.
  • gyp/streamline-inspector-source.sh: Added property svn:eol-style.
  • gyp/update-info-plist.sh: Added property svn:eol-style.

Source/WebKit2:

  • win/build-generated-files.sh: Added properties svn:executable and svn:eol-style.

Tools:

  • EWSTools/boot.sh: Added properties svn:executable and svn:eol-style.
  • EWSTools/start-queue.sh: Added property svn:eol-style.
  • Scripts/webkit-tools-completion.sh: Added properties svn:executable and svn:eol-style.
  • WebKitTestRunner/win/build-generated-files.sh: Added properties svn:executable and svn:eol-style.
  • iExploder/iexploder-1.7.2/tools/release_src.sh: Added property svn:eol-style.
  • iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added property svn:eol-style.

WebKitLibraries:

  • win/tools/scripts/feature-defines.sh: Modified property svn:eol-style.

Websites/bugs.webkit.org:

  • contrib/yp_nomail.sh: Added property svn:executable.

LayoutTests:

  • platform/mac/fast/loader/resources/mimeTypeExamples/example-sh.sh: Added property svn:executable.
11:05 Changeset [110305] by kling@webkit.org

CSSParser: Use Vector for intermediate property storage.
<http://webkit.org/b/80653>

Reviewed by Antti Koivisto.

Remove the custom memory management for intermediate CSSProperties in CSSParser
and replace it by a Vector<CSSProperty, 256>.
This avoids heap allocations and removes a bunch of unnecessary complexity.

Remove WTF_MAKE_FAST_ALLOCATED from CSSProperty since they are only created on
the stack now.

  • css/CSSGrammar.y:
  • css/CSSParser.cpp:

(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::~CSSParser):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseColor):
(WebCore::CSSParser::parseDeclaration):
(WebCore::CSSParser::addProperty):
(WebCore::CSSParser::rollbackLastProperties):
(WebCore::CSSParser::clearProperties):
(WebCore::CSSParser::parse4Values):
(WebCore::CSSParser::parseFlowThread):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createMarginAtRule):
(WebCore::CSSParser::startDeclarationsForMarginBox):
(WebCore::CSSParser::endDeclarationsForMarginBox):
(WebCore::CSSParser::deleteFontFaceOnlyValues):
(WebCore::CSSParser::createKeyframeRule):

  • css/CSSParser.h:

(WebCore::CSSParser::hasProperties):
(CSSParser):

  • css/CSSProperty.h:
  • css/SVGCSSParser.cpp:

(WebCore::CSSParser::parseSVGValue):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::addParsedProperties):

  • css/StylePropertySet.h:

(WebCore::StylePropertySet::create):
(StylePropertySet):

10:02 Changeset [110304] by abarth@webkit.org

Note that fast/events/input-image-scrolled-x-y.html is flaky.

  • platform/chromium/test_expectations.txt:
09:59 Changeset [110303] by enrica@apple.com

REGRESSION (r109022): Files dragged onto input controls cannot be read due to sandbox violation.
https://bugs.webkit.org/show_bug.cgi?id=80203
<rdar://problem/10976643>

Reviewed by Alexey Proskuryakov.

This patch reverts a small part fo r109022, leaving access to
NSPasteboard in the WebProcess when retrieving pathnames for
files being dragged. This avoid the sandbox violation until we
implement a mechanism to provide a sandbox extension to the WebProcess.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::getPathnamesForType):

09:56 Changeset [110302] by jberlin@webkit.org

Windows debug build fix.

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::shouldBlind):
Fix unreachable code warnings (which we treat as errors).

09:36 Changeset [110301] by japhet@chromium.org

2012-03-09 Nate Chapin <japhet@chromium.org>

CachedRawResource breaks when trying to load
a resource with an empty response body from cache.

Reviewed by Alexey Proskuryakov.

Test: http/tests/cache/zero-length-xhr.html

  • loader/cache/CachedRawResource.cpp: (WebCore::CachedRawResource::didAddClient): Don't exit early

if m_data is empty, we may still need to notifyFinished().

09:30 Changeset [110300] by commit-queue@webkit.org

[BlackBerry] Upstream classes that handle layer tiling
https://bugs.webkit.org/show_bug.cgi?id=79875

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-03-09
Reviewed by Rob Buis.

Initial upstreaming, no new tests.

  • platform/graphics/blackberry/LayerTile.cpp: Added.

(WebCore):
(WebCore::LayerTile::LayerTile):
(WebCore::LayerTile::~LayerTile):
(WebCore::LayerTile::setContents):
(WebCore::LayerTile::setContentsToColor):
(WebCore::LayerTile::updateContents):
(WebCore::LayerTile::discardContents):
(WebCore::LayerTile::setVisible):
(WebCore::LayerTile::setTexture):

  • platform/graphics/blackberry/LayerTile.h: Added.

(WebCore):
(LayerTileData):
(WebCore::LayerTileData::LayerTileData):
(WebCore::LayerTileData::isVisible):
(LayerTile):
(WebCore::LayerTile::texture):
(WebCore::LayerTile::isVisible):
(WebCore::LayerTile::isDirty):
(WebCore::LayerTile::hasTexture):
(WebCore::LayerTile::setContentsDirty):

  • platform/graphics/blackberry/LayerTileIndex.h: Added.

(WebCore):
(TileIndex):
(WebCore::TileIndex::TileIndex):
(WebCore::TileIndex::~TileIndex):
(WebCore::TileIndex::i):
(WebCore::TileIndex::j):
(WebCore::TileIndex::setIndex):
(WebCore::operator==):
(WebCore::operator!=):
(WTF):

  • platform/graphics/blackberry/LayerTiler.cpp: Added.

(WebCore):
(WebCore::transformPoint):
(WebCore::defaultTileSize):
(WebCore::LayerTiler::LayerTiler):
(WebCore::LayerTiler::~LayerTiler):
(WebCore::LayerTiler::layerWebKitThreadDestroyed):
(WebCore::LayerTiler::layerCompositingThreadDestroyed):
(WebCore::LayerTiler::setNeedsDisplay):
(WebCore::LayerTiler::updateTextureContentsIfNeeded):
(WebCore::LayerTiler::shouldPerformRenderJob):
(WebCore::LayerTiler::addTextureJob):
(WebCore::LayerTiler::clearTextureJobs):
(WebCore::LayerTiler::commitPendingTextureUploads):
(WebCore::LayerTiler::layerVisibilityChanged):
(WebCore::LayerTiler::uploadTexturesIfNeeded):
(WebCore::LayerTiler::processTextureJob):
(WebCore::LayerTiler::addTileJob):
(WebCore::LayerTiler::performTileJob):
(WebCore::LayerTiler::drawTextures):
(WebCore::LayerTiler::drawMissingTextures):
(WebCore::LayerTiler::drawTexturesInternal):
(WebCore::LayerTiler::addRenderJob):
(WebCore::LayerTiler::removeRenderJob):
(WebCore::LayerTiler::deleteTextures):
(WebCore::LayerTiler::pruneTextures):
(WebCore::LayerTiler::updateTileSize):
(WebCore::LayerTiler::disableTiling):
(WebCore::LayerTiler::shouldPrefillTile):
(WebCore::LayerTiler::indexOfTile):
(WebCore::LayerTiler::originOfTile):
(WebCore::LayerTiler::rectForTile):
(WebCore::LayerTiler::hasDirtyTiles):
(WebCore::LayerTiler::bindContentsTexture):

  • platform/graphics/blackberry/LayerTiler.h: Added.

(WebCore):
(LayerTiler):
(WebCore::LayerTiler::create):
(WebCore::LayerTiler::layer):
(WebCore::LayerTiler::hasMissingTextures):
(WebCore::LayerTiler::TextureJob::TextureJob):
(TextureJob):
(WebCore::LayerTiler::TextureJob::setContents):
(WebCore::LayerTiler::TextureJob::setContentsToColor):
(WebCore::LayerTiler::TextureJob::updateContents):
(WebCore::LayerTiler::TextureJob::discardContents):
(WebCore::LayerTiler::TextureJob::resizeContents):
(WebCore::LayerTiler::TextureJob::dirtyContents):
(WebCore::LayerTiler::TextureJob::isNull):
(WebCore::LayerTiler::tileSize):
(WebCore::LayerTiler::removeUpdateContentsJobs):

08:49 Changeset [110299] by commit-queue@webkit.org

[chromium] Ensure we use the correct time when notifying animation started
https://bugs.webkit.org/show_bug.cgi?id=79537

Patch by Ian Vollick <vollick@chromium.org> on 2012-03-09
Reviewed by James Robinson

Source/WebCore:

Tested in CCLayerTreeHostTestAddAnimation

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setAnimationEvent):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):

  • platform/graphics/chromium/cc/CCAnimationEvents.cpp:

(WebCore::CCAnimationStartedEvent::create):
(WebCore::CCAnimationStartedEvent::CCAnimationStartedEvent):

  • platform/graphics/chromium/cc/CCAnimationEvents.h:

(CCAnimationEvent):
(CCAnimationStartedEvent):

  • platform/graphics/chromium/cc/CCInputHandler.h:

(CCInputHandler):

  • platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.cpp:

(WebCore::CCLayerAnimationControllerImpl::animate):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForNextTick):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForStartTime):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForTargetAvailability):
(WebCore::CCLayerAnimationControllerImpl::resolveConflicts):
(WebCore::CCLayerAnimationControllerImpl::tickAnimations):

  • platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.h:

(CCLayerAnimationControllerImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::setAnimationEvents):
(WebCore::CCLayerTreeHost::setAnimationEventsRecursive):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::animate):
(WebCore::CCLayerTreeHostImpl::startPageScaleAnimation):
(WebCore::CCLayerTreeHostImpl::animateLayersRecursive):
(WebCore::CCLayerTreeHostImpl::animatePageScale):
(WebCore::CCLayerTreeHostImpl::animateLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImplClient):
(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCPageScaleAnimation.cpp:

(WebCore::CCPageScaleAnimation::create):
(WebCore::CCPageScaleAnimation::CCPageScaleAnimation):
(WebCore::CCPageScaleAnimation::zoomTo):
(WebCore::CCPageScaleAnimation::zoomWithAnchor):
(WebCore::CCPageScaleAnimation::scrollOffsetAtTime):
(WebCore::CCPageScaleAnimation::pageScaleAtTime):
(WebCore::CCPageScaleAnimation::isAnimationCompleteAtTime):
(WebCore::CCPageScaleAnimation::progressRatioForTime):

  • platform/graphics/chromium/cc/CCPageScaleAnimation.h:

(CCPageScaleAnimation):
(WebCore::CCPageScaleAnimation::startTime):
(WebCore::CCPageScaleAnimation::duration):
(WebCore::CCPageScaleAnimation::endTime):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::startPageScaleAnimation):
(WebCore::CCSingleThreadProxy::postAnimationEventsToMainThreadOnImplThread):
(WebCore::CCSingleThreadProxy::doComposite):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(CCSingleThreadProxy):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::startPageScaleAnimation):
(WebCore::CCThreadProxy::requestStartPageScaleAnimationOnImplThread):
(WebCore::CCThreadProxy::postAnimationEventsToMainThreadOnImplThread):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwap):
(WebCore::CCThreadProxy::setAnimationEvents):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

  • src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::willDraw):

  • src/WebCompositorInputHandlerImpl.h:

(WebCompositorInputHandlerImpl):

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::CCLayerTreeHostImplTest::postAnimationEventsToMainThreadOnImplThread):
(WebKit::TEST_F):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::TestHooks::animateLayers):
(WTF::TestHooks::updateAnimations):
(WTF::MockLayerTreeHostImpl::animateLayers):
(WTF::MockLayerTreeHostClient::updateAnimations):
(WTF::CCLayerTreeHostTestAddAnimation::CCLayerTreeHostTestAddAnimation):
(WTF::CCLayerTreeHostTestAddAnimation::animateLayers):
(WTF::CCLayerTreeHostTestAddAnimation::notifyAnimationStarted):
(CCLayerTreeHostTestAddAnimation):

07:45 Changeset [110298] by senorblanco@chromium.org

[chromium] Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
07:25 Changeset [110297] by ossy@webkit.org

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Skip flaky svg tests.
07:22 Changeset [110296] by commit-queue@webkit.org

[BUILD] use detected python to run generate-gtkdoc
https://bugs.webkit.org/show_bug.cgi?id=80695

Patch by Ionut Biru <ibiru@archlinux.org> on 2012-03-09
Reviewed by Gustavo Noronha Silva.

  • GNUmakefile.am: Use $(PYTHON) instead of plain python
07:13 Changeset [110295] by ossy@webkit.org

[Qt] Unreviewed gardening.

  • platform/qt/Skipped:
  • platform/qt/editing/selection/3690703-2-expected.png:
  • platform/qt/editing/selection/3690703-2-expected.txt:
  • platform/qt/editing/selection/3690703-expected.png:
  • platform/qt/editing/selection/3690703-expected.txt:
  • platform/qt/editing/selection/3690719-expected.png:
  • platform/qt/editing/selection/3690719-expected.txt:
  • platform/qt/fast/css/text-overflow-input-expected.txt: Added.
  • platform/qt/fast/forms/basic-inputs-expected.png: Added.
  • platform/qt/fast/forms/basic-inputs-expected.txt:
  • platform/qt/fast/replaced/replaced-breaking-expected.png:
  • platform/qt/fast/replaced/replaced-breaking-expected.txt:
  • platform/qt/fast/text/textIteratorNilRenderer-expected.png:
  • platform/qt/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/qt/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/qt/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1188-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug18359-expected.png:
  • platform/qt/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2479-4-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug28928-expected.png:
  • platform/qt/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug4382-expected.png:
  • platform/qt/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug44505-expected.png:
  • platform/qt/tables/mozilla/bugs/bug44505-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug4527-expected.png:
  • platform/qt/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug51037-expected.png:
  • platform/qt/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug7342-expected.png:
  • platform/qt/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/qt/tables/mozilla/dom/tableDom-expected.png:
  • platform/qt/tables/mozilla/dom/tableDom-expected.txt:
  • platform/qt/tables/mozilla/other/move_row-expected.png:
  • platform/qt/tables/mozilla/other/move_row-expected.txt:
  • platform/qt/test_expectations.txt:
07:08 Changeset [110294] by commit-queue@webkit.org

Layout test for window.devicePixelRatio
https://bugs.webkit.org/show_bug.cgi?id=80292

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-03-09
Reviewed by Philippe Normand.

Update the skipped list for ports where fast/viewport/viewport-133.html is failing.

  • platform/efl/Skipped:
  • platform/gtk/Skipped:
07:08 WebKitGTK/1.8.x edited by kov@webkit.org
Adding "[BUILD] use detected python to run generate-gtkdoc" to on track (diff)
06:25 Changeset [110293] by ossy@webkit.org

[Qt] Rebaseline some tests on qt platfrom

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-03-09
Reviewed by Csaba Osztrogonác.

  • platform/qt/ [...]: Update expected files.
  • platform/qt/test_expectations.txt: Unskip now passing tests.
05:59 Changeset [110292] by zimmermann@webkit.org

2012-03-09 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Rebaseline some Mac results that needed rebaselining - using Lion, and a Generic RGB Color profile.
Had to manually switch to this, until this is done automatically, see bug 80571.

Re-add several results that got deleted or moved to mac-future. I guess this is garden-o-matic
misusage? Not sure, anyhow, there are clearly a dozen of missing SVG pixel tests before this patch.

Reviewed by NOBODY (OOPS!).

  • platform/mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png: Added.
  • platform/mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png: Added.
  • platform/mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Added.
  • platform/mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-no-markup-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-direction-rtl-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
  • platform/mac/svg/batik/filters/feTile-expected.png:
  • platform/mac/svg/batik/filters/filterRegions-expected.png:
  • platform/mac/svg/batik/masking/maskRegions-expected.png: Added.
  • platform/mac/svg/batik/text/textEffect-expected.png:
  • platform/mac/svg/batik/text/textEffect3-expected.png:
  • platform/mac/svg/batik/text/textGlyphOrientationHorizontal-expected.png: Added.
  • platform/mac/svg/carto.net/scrollbar-expected.png: Added.
  • platform/mac/svg/css/composite-shadow-with-opacity-expected.png:
  • platform/mac/svg/css/path-gradient-stroke-shadow-expected.png:
  • platform/mac/svg/css/rect-gradient-stroke-shadow-expected.png:
  • platform/mac/svg/custom/convolution-crash-expected.png:
  • platform/mac/svg/custom/empty-merge-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/mac/svg/custom/feDisplacementMap-01-expected.png:
  • platform/mac/svg/custom/grayscale-gradient-mask-2-expected.png:
  • platform/mac/svg/custom/image-with-transform-clip-filter-expected.png:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/mac/svg/custom/non-opaque-filters-expected.png:
  • platform/mac/svg/custom/recursive-filter-expected.png:
  • platform/mac/svg/custom/resource-invalidate-on-target-update-expected.png:
  • platform/mac/svg/custom/root-container-opacity-clip-viewBox-expected.png:
  • platform/mac/svg/custom/text-filter-expected.png:
  • platform/mac/svg/custom/use-disappears-after-style-update-expected.png:
  • platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.png: Added.
  • platform/mac/svg/custom/visibility-override-filter-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDistantLightElement-dom-azimuth-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDistantLightElement-dom-elevation-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-azimuth-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-elevation-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEOffsetElement-dom-dx-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEOffsetElement-dom-dy-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEOffsetElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dx-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dy-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEOffsetElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-dom-height-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-dom-width-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-dom-x-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-dom-y-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-height-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-width-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-x-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-y-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.png:
  • platform/mac/svg/filters/big-sized-filter-2-expected.png:
  • platform/mac/svg/filters/big-sized-filter-expected.png:
  • platform/mac/svg/filters/feColorMatrix-default-type-expected.png:
  • platform/mac/svg/filters/feColorMatrix-offset-expected.png:
  • platform/mac/svg/filters/feColorMatrix-values-expected.png:
  • platform/mac/svg/filters/feComposite-expected.png:
  • platform/mac/svg/filters/feConvolveFilter-y-bounds-expected.png:
  • platform/mac/svg/filters/feDisplacementMap-expected.png:
  • platform/mac/svg/filters/feDropShadow-expected.png:
  • platform/mac/svg/filters/feGaussianBlur-expected.png:
  • platform/mac/svg/filters/feImage-animated-transform-on-target-rect-expected.png:
  • platform/mac/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png:
  • platform/mac/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png:
  • platform/mac/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png:
  • platform/mac/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png:
  • platform/mac/svg/filters/feImage-late-indirect-update-expected.png:
  • platform/mac/svg/filters/feImage-multiple-targets-id-change-expected.png:
  • platform/mac/svg/filters/feImage-position-expected.png:
  • platform/mac/svg/filters/feImage-preserveAspectratio-expected.png:
  • platform/mac/svg/filters/feImage-subregions-expected.png:
  • platform/mac/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png:
  • platform/mac/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png:
  • platform/mac/svg/filters/feImage-target-add-to-document-expected.png:
  • platform/mac/svg/filters/feImage-target-attribute-change-expected.png:
  • platform/mac/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png:
  • platform/mac/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png:
  • platform/mac/svg/filters/feImage-target-changes-id-expected.png:
  • platform/mac/svg/filters/feImage-target-id-change-expected.png:
  • platform/mac/svg/filters/feImage-target-inline-style-change-expected.png:
  • platform/mac/svg/filters/feImage-target-property-change-expected.png:
  • platform/mac/svg/filters/feImage-target-reappend-to-document-expected.png:
  • platform/mac/svg/filters/feImage-target-remove-from-document-expected.png:
  • platform/mac/svg/filters/feImage-target-style-change-expected.png:
  • platform/mac/svg/filters/feLighting-crash-expected.png:
  • platform/mac/svg/filters/feMerge-expected.png:
  • platform/mac/svg/filters/feOffset-expected.png:
  • platform/mac/svg/filters/feTile-expected.png:
  • platform/mac/svg/filters/filter-clip-expected.png:
  • platform/mac/svg/filters/filter-on-tspan-expected.png:
  • platform/mac/svg/filters/filter-placement-issue-expected.png:
  • platform/mac/svg/filters/filter-refresh-expected.png:
  • platform/mac/svg/filters/filter-rounding-issues-expected.png:
  • platform/mac/svg/filters/filter-source-position-expected.png:
  • platform/mac/svg/filters/filter-width-update-expected.png:
  • platform/mac/svg/filters/filterRes-expected.png:
  • platform/mac/svg/filters/filterRes1-expected.png:
  • platform/mac/svg/filters/filterRes2-expected.png:
  • platform/mac/svg/filters/filterRes3-expected.png:
  • platform/mac/svg/filters/filteredImage-expected.png:
  • platform/mac/svg/filters/parent-children-with-same-filter-expected.png:
  • platform/mac/svg/filters/shadow-on-filter-expected.png:
  • platform/mac/svg/filters/shadow-on-rect-with-filter-expected.png:
  • platform/mac/svg/filters/subRegion-in-userSpace-expected.png:
  • platform/mac/svg/filters/subRegion-one-effect-expected.png:
  • platform/mac/svg/filters/subRegion-two-effects-expected.png:
  • platform/mac/svg/hixie/mixed/003-expected.png:
  • platform/mac/svg/hixie/mixed/003-expected.txt:
  • platform/mac/svg/repaint/filter-child-repaint-expected.png:
  • platform/mac/svg/repaint/filter-repaint-expected.png:
  • platform/mac/svg/webarchive/svg-feimage-subresources-expected.png:
  • platform/mac/test_expectations.txt:
  • svg/filters/animate-fill-expected.png:
  • svg/filters/feColorMatrix-saturate-expected.png:
  • svg/filters/feImage-reference-invalidation-expected.png:
  • svg/filters/feImage-reference-svg-primitive-expected.png:
  • svg/foreignObject/filter-expected.png:
05:13 Changeset [110291] by ossy@webkit.org

[Qt] Fix compilation without QtQuick1
https://bugs.webkit.org/show_bug.cgi?id=80503

Qt 4.8 API test fix after r110050.

Reviewed by Zoltan Herczeg.

  • declarative/public.pri: Add load(features) to ensure HAVE_QQUICK1=1 is set.
05:11 Changeset [110290] by charles.wei@torchmobile.com.cn

[BlackBerry] Web Notification not working after rebase
https://bugs.webkit.org/show_bug.cgi?id=80690

Reviewed by George Staikos.

  1. NotificationPresenterImpl should be in namespace WebCore
  2. Need to connect NotificationPresenterImpl to webcore the new way: WebCore::provideNotification(Page*, NotificationPresenter*)
  3. Remove the old way of connecting the Notification: ChromeClientBlackBerry::notificationPresenter()
  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore):

  • WebCoreSupport/ChromeClientBlackBerry.h:

(ChromeClientBlackBerry):

  • WebCoreSupport/NotificationPresenterImpl.cpp:
  • WebCoreSupport/NotificationPresenterImpl.h:
04:45 Changeset [110289] by commit-queue@webkit.org

Patch by Thouraya ANDOLSI <thouraya.andolsi@st.com> on 2012-03-09
Reviewed by Zoltan Herczeg.

[Qt] Fix the SH4 build after r109834
https://bugs.webkit.org/show_bug.cgi?id=80492

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::branchAdd32):
(JSC::MacroAssemblerSH4::branchSub32):

04:16 Changeset [110288] by ossy@webkit.org

[Qt] Disable WebGL performance tests temporarily.
https://bugs.webkit.org/show_bug.cgi?id=80503

Rubber-stamped by Simon Hausmann.

  • Source/tests.pri:
04:06 Changeset [110287] by wingo@igalia.com

Refactor code feature analysis in the parser
https://bugs.webkit.org/show_bug.cgi?id=79112

Reviewed by Geoffrey Garen.

This commit refactors the parser to more uniformly propagate flag
bits down and up the parse process, as the parser descends and
returns into nested blocks. Some flags get passed town to
subscopes, some apply to specific scopes only, and some get
unioned up after parsing subscopes.

The goal is to eventually be very precise with scoping
information, once we have block scopes: one block scope might use
`eval', which would require the emission of a symbol table within
that block and containing blocks, whereas another block in the
same function might not, allowing us to not emit a symbol table.

  • parser/Nodes.h:

(JSC::ScopeFlags): Rename from CodeFeatures.
(JSC::ScopeNode::addScopeFlags):
(JSC::ScopeNode::scopeFlags): New accessors for m_scopeFlags.
(JSC::ScopeNode::isStrictMode):
(JSC::ScopeNode::usesEval):
(JSC::ScopeNode::usesArguments):
(JSC::ScopeNode::setUsesArguments):
(JSC::ScopeNode::usesThis):
(JSC::ScopeNode::needsActivationForMoreThanVariables):
(JSC::ScopeNode::needsActivation): Refactor these accessors to
operate on the m_scopeFlags member.
(JSC::ScopeNode::source):
(JSC::ScopeNode::sourceURL):
(JSC::ScopeNode::sourceID): Shuffle these definitions around; no
semantic change.
(JSC::ScopeNode::ScopeNode)
(JSC::ProgramNode::ProgramNode)
(JSC::EvalNode::EvalNode)
(JSC::FunctionBodyNode::FunctionBodyNode): Have these constructors
take a ScopeFlags as an argument, instead of a bool inStrictContext.

  • parser/Nodes.cpp:

(JSC::ScopeNode::ScopeNode):
(JSC::ProgramNode::ProgramNode):
(JSC::ProgramNode::create):
(JSC::EvalNode::EvalNode):
(JSC::EvalNode::create):
(JSC::FunctionBodyNode::FunctionBodyNode):
(JSC::FunctionBodyNode::create): Adapt constructors to change.

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::ASTBuilder):
(JSC::ASTBuilder::thisExpr):
(JSC::ASTBuilder::createResolve):
(JSC::ASTBuilder::createFunctionBody):
(JSC::ASTBuilder::createFuncDeclStatement):
(JSC::ASTBuilder::createTryStatement):
(JSC::ASTBuilder::createWithStatement):
(JSC::ASTBuilder::addVar):
(JSC::ASTBuilder::Scope::Scope):
(Scope):
(ASTBuilder):
(JSC::ASTBuilder::makeFunctionCallNode): Don't track scope
features here. Instead rely on the base Parser mechanism to track
features.

  • parser/NodeInfo.h (NodeInfo, NodeDeclarationInfo): "ScopeFlags".
  • parser/Parser.h:

(JSC::Scope::Scope): Manage scope through flags, not
bit-booleans. This lets us uniformly propagate them up and down.
(JSC::Scope::declareWrite):
(JSC::Scope::declareParameter):
(JSC::Scope::useVariable):
(JSC::Scope::collectFreeVariables):
(JSC::Scope::getCapturedVariables):
(JSC::Scope::saveFunctionInfo):
(JSC::Scope::restoreFunctionInfo):
(JSC::Parser::pushScope): Adapt to use scope flags and their
accessors instead of bit-booleans.

  • parser/Parser.cpp:

(JSC::::Parser):
(JSC::::parseInner):
(JSC::::didFinishParsing):
(JSC::::parseSourceElements):
(JSC::::parseVarDeclarationList):
(JSC::::parseConstDeclarationList):
(JSC::::parseWithStatement):
(JSC::::parseTryStatement):
(JSC::::parseFunctionBody):
(JSC::::parseFunctionInfo):
(JSC::::parseFunctionDeclaration):
(JSC::::parsePrimaryExpression): Hoist some of the flag handling
out of the "context" (ASTBuilder or SyntaxChecker) and to here.
Does not seem to have a performance impact.

  • parser/SourceProviderCacheItem.h (SourceProviderCacheItem):

Cache the scopeflags.

  • parser/SyntaxChecker.h: Remove evalCount() decl.
  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::produceCodeBlockFor):

  • runtime/Executable.h:

(JSC::ScriptExecutable::ScriptExecutable):
(JSC::ScriptExecutable::usesEval):
(JSC::ScriptExecutable::usesArguments):
(JSC::ScriptExecutable::needsActivation):
(JSC::ScriptExecutable::isStrictMode):
(JSC::ScriptExecutable::recordParse):
(ScriptExecutable): ScopeFlags, not features.

04:03 Changeset [110286] by ossy@webkit.org

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Skip new tests without expected files, need investigation.
  • platform/qt/http/tests/navigation/javascriptlink-frames-expected.png: Updated.
  • platform/qt/http/tests/navigation/javascriptlink-frames-expected.txt: Updated.
04:02 Changeset [110285] by zherczeg@webkit.org

Add SVGRenderingContext and move there the context related code from SVGRenderSupport
https://bugs.webkit.org/show_bug.cgi?id=80413

Reviewed by Nikolas Zimmermann.

This is the first step of refactoring the rendering context for SVG. The
previous context was stateless before, which means the cleanup phase
needed to do a lot of checks to revert the initialization part and
was unaware of failed inititalization. Future code can also add
new local variables to the context.

This patch add a new SVGRenderingContext class, and moves there the context
initialization / cleanup code from SVGRenderSupport. All build systems were
updated.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/svg/RenderSVGAllInOne.cpp:
  • rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::paint):

  • rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::paint):

  • rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::paint):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::paintReplaced):

  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::paint):

  • rendering/svg/SVGInlineFlowBox.cpp:

(WebCore::SVGInlineFlowBox::paint):

  • rendering/svg/SVGRenderSupport.cpp:
  • rendering/svg/SVGRenderSupport.h:
  • rendering/svg/SVGRenderingContext.cpp: Added.

(WebCore):
(WebCore::isRenderingMaskImage):
(WebCore::SVGRenderingContext::~SVGRenderingContext):
(WebCore::SVGRenderingContext::prepareToRenderSVGContent):

  • rendering/svg/SVGRenderingContext.h: Added.

(WebCore):
(SVGRenderingContext):
(WebCore::SVGRenderingContext::SVGRenderingContext):
(WebCore::SVGRenderingContext::isRenderingPrepared):

  • rendering/svg/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::paint):

03:52 CommitterTips edited by ossy@webkit.org
Add some more tips for unreviewed buildfixes (diff)
03:45 Changeset [110284] by ossy@webkit.org

[Qt] Gardening, skip 3 failing tests.

Patch by Nándor Huszka <huszka.nandor@stud.u-szeged.hu> on 2012-03-09
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
03:16 Changeset [110283] by ossy@webkit.org

Unreviewed, rolling out r110191, r110202, and r110279.
http://trac.webkit.org/changeset/110191
http://trac.webkit.org/changeset/110202
http://trac.webkit.org/changeset/110279
https://bugs.webkit.org/show_bug.cgi?id=80694

They broke !ENABLE(INSPECTOR) builds (Requested by Ossy on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-09

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

  • WebCore.exp.in:
  • testing/Internals.cpp:
  • testing/Internals.h:

(WebCore):
(Internals):

  • testing/Internals.idl:

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

  • inspector/elements/highlight-node-expected.txt: Removed.
  • inspector/elements/highlight-node.html: Removed.
03:13 Changeset [110282] by nduca@chromium.org

Make check-webkit-style complain about "no new tests" lines in changelogs
https://bugs.webkit.org/show_bug.cgi?id=80582

Reviewed by David Levin.

  • Scripts/webkitpy/style/checkers/changelog.py:

(ChangeLogChecker.check_entry):

  • Scripts/webkitpy/style/checkers/changelog_unittest.py:

(ChangeLogCheckerTest.test_no_new_tests):

02:56 Changeset [110281] by hans@chromium.org

Speech JavaScript API: add SpeechGrammar and SpeechGrammarList
https://bugs.webkit.org/show_bug.cgi?id=80417

Reviewed by Adam Barth.

Source/WebCore:

Implement SpeechGrammar and SpeechGrammarList.
(Spec: http://speech-javascript-api-spec.googlecode.com/git/speechapi.html)

Test: fast/speech/scripted/speechgrammar-basics.html

  • Modules/speech/DOMWindowSpeech.idl:
  • Modules/speech/SpeechGrammar.cpp:

(WebCore):
(WebCore::SpeechGrammar::create):
(WebCore::SpeechGrammar::SpeechGrammar):

  • Modules/speech/SpeechGrammar.h:

(WebCore):
(SpeechGrammar):
(WebCore::SpeechGrammar::src):
(WebCore::SpeechGrammar::setSrc):
(WebCore::SpeechGrammar::weight):
(WebCore::SpeechGrammar::setWeight):

  • Modules/speech/SpeechGrammar.idl:
  • Modules/speech/SpeechGrammarList.cpp:

(WebCore):
(WebCore::SpeechGrammarList::create):
(WebCore::SpeechGrammarList::item):
(WebCore::SpeechGrammarList::addFromUri):
(WebCore::SpeechGrammarList::addFromString):
(WebCore::SpeechGrammarList::SpeechGrammarList):

  • Modules/speech/SpeechGrammarList.h:

(WebCore):
(SpeechGrammarList):
(WebCore::SpeechGrammarList::length):

  • Modules/speech/SpeechGrammarList.idl:
  • WebCore.gypi:

LayoutTests:

Add a test for SpeechGrammar and SpeechGrammarList.

  • fast/speech/scripted/speechgrammar-basics-expected.txt: Added.
  • fast/speech/scripted/speechgrammar-basics.html: Added.
02:39 Changeset [110280] by ossy@webkit.org

Unreviewed, rolling out r110269.
http://trac.webkit.org/changeset/110269
https://bugs.webkit.org/show_bug.cgi?id=80688

It made inspector/elements/highlight-node.html fail everywhere
(Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-09

  • testing/Internals.idl:
01:55 Changeset [110279] by apavlov@chromium.org

[chromium] Unreviewed, build fix after r110191

  • features.gypi:
01:51 Changeset [110278] by apavlov@chromium.org

Web Inspector: [Styles] Click in the first line of rule while editing property starts a new property
https://bugs.webkit.org/show_bug.cgi?id=80507

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection):
(WebInspector.StylePropertiesSection.prototype._checkWillCancelEditing):
(WebInspector.StylePropertiesSection.prototype._handleSelectorContainerClick):
(WebInspector.StylePropertiesSection.prototype._handleEmptySpaceClick):
(WebInspector.StylePropertyTreeElement.prototype.onattach):
(WebInspector.StylePropertyTreeElement.prototype):

01:33 Changeset [110277] by mrowe@apple.com

<rdar://problem/11012024> Fix the build by working around <rdar://problem/10710970>.

  • platform/mac/RunLoopMac.mm:

(WebCore::RunLoop::stop):

01:27 Changeset [110276] by ossy@webkit.org

[Qt] Gardening, skip two failing tests and a timeouting one.

Patch by Nándor Huszka <huszka.nandor@stud.u-szeged.hu> on 2012-03-09
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
01:01 Changeset [110275] by commit-queue@webkit.org

FileInputType doesn't support (save|restore)FormControlState
https://bugs.webkit.org/show_bug.cgi?id=80145

Patch by Marja Hölttä <marja@google.com> on 2012-03-09
Reviewed by Kent Tamura.

Source/WebCore:

This enables saving and restoring the state of file upload elements in
unsubmitted forms.

Test: fast/forms/file/recover-file-input-in-unposted-form.html

  • html/BaseCheckableInputType.cpp:

(WebCore::BaseCheckableInputType::restoreFormControlState): non-const

  • html/BaseCheckableInputType.h:

(BaseCheckableInputType): restoreFormControlState non-const

  • html/FileInputType.cpp:

(WebCore::FileInputType::saveFormControlState): save chosen files
(WebCore):
(WebCore::FileInputType::restoreFormControlState): restore chosen files

  • html/FileInputType.h:

(FileInputType): overwrite (save|restore)FormControlState

  • html/HiddenInputType.cpp:

(WebCore::HiddenInputType::restoreFormControlState): non-const

  • html/HiddenInputType.h:

(HiddenInputType): restoreFormControlState non-const

  • html/InputType.cpp:

(WebCore::InputType::restoreFormControlState): non-const

  • html/InputType.h:

(InputType): restoreFormControlState non-const

  • html/PasswordInputType.cpp:

(WebCore::PasswordInputType::restoreFormControlState): non-const

  • html/PasswordInputType.h:

(PasswordInputType): restoreFormControlState non-const

LayoutTests:

Tests for saving and restoring the state of file upload elements in unsubmitted forms.

  • fast/forms/file/recover-file-input-in-unposted-form-expected.txt: Added.
  • fast/forms/file/recover-file-input-in-unposted-form.html: Added.
  • platform/wk2/Skipped: The added test needs eventSender.beginDragWithFiles.
00:48 Changeset [110274] by toyoshim@chromium.org

[WebSocket] Add a layout test where server force to disable all extensions
https://bugs.webkit.org/show_bug.cgi?id=80650

Reviewed by Kent Tamura.

  • http/tests/websocket/tests/hybi/echo-with-no-extension-expected.txt: Added.
  • http/tests/websocket/tests/hybi/echo-with-no-extension.html: Check if extension property is always empty string.
  • http/tests/websocket/tests/hybi/echo-with-no-extension_wsh.py: Added a handler which disable all extensions.

(web_socket_do_extra_handshake):
(web_socket_transfer_data):

  • http/tests/websocket/tests/hybi/extensions-expected.txt: Updated.
  • http/tests/websocket/tests/hybi/extensions.html: Added the case after connection is established.
00:42 Changeset [110273] by ossy@webkit.org

Unreviewed, rolling out r110250.
http://trac.webkit.org/changeset/110250
https://bugs.webkit.org/show_bug.cgi?id=80682

It made NRWT ignore test_expectations.txt on Qt-WK2 and ignore
qt-linux at all. (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-09

  • Scripts/old-run-webkit-tests:
  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort):
(QtPort.determine_full_port_name):
(QtPort.baseline_search_path):

  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:

(QtPortTest):
(QtPortTest._assert_search_path):
(QtPortTest.test_baseline_search_path):

03/08/12:

23:39 Changeset [110272] by vestbo@webkit.org

[Qt] Use Qt's module system for install rules and depending on QtWebKit

Instead of rolling our own install rules we now use the same approach as
every other Qt module, by loading qt_module.prf and qt_module_config.prf.

This ensures that we follow the same semantics as the rest of Qt on
what sort of config options are enabled by default (create_cmake eg.).
It also allows us to use QT += webkit instead of the workaround we had
with CONFIG += qtwebkit.

We do however force Qt to always treat our build as a non-developer build,
so the libraries will end up in the WebKit lib directory instead of the
qtbase directory (as with a normal developer-build). This allows us to
keep the webkit-build self-contained. If Qt is a developer build we still
copy the module file manually to Qt, so that you don't have to install
WebKit to make it available.

For non-developer builds of Qt, it is still possible to use the built
WebKit libraries without having to install them, by having the variable
QMAKE_EXTRA_MODULE_FORWARDS set in the project's .qmake.cache file,
pointing to $WEBKITOUTUTDIR/$CONFIGURATION/modules.

https://bugs.webkit.org/show_bug.cgi?id=80590

Reviewed by Simon Hausmann.

23:33 Changeset [110271] by commit-queue@webkit.org

Base the access to CSSStyleDeclaration on the CSSPropertyID instead of the PropertyName
https://bugs.webkit.org/show_bug.cgi?id=80461

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-08
Reviewed by Geoffrey Garen.

Previously, the acces to CSS Style properties was done through a NamedGetter. This caused
the (slow) mapping between CSSPropertyName and CSSPropertyID to be done twice for every acess:
1) canGetItemsForName() prior to the definition of the slot.
2) nameGetter() called from the slot with CSSPropertyName to get the actual value.

This patch changes the access to be based on CSSPropertyID. The slot is defined with the
CSSPropertyID as the customIndex, and the value can be accessed directly when the slot is
called.

To handle the differences create by hadPixelOrPosPrefix, two nearly identical callback are defined,
one for hadPixelOrPosPrefix, the other for !hadPixelOrPosPrefix.

The performance gain is about 19% when accessing CSS properties.

  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::getPropertyValueFallback):
(WebCore::cssPropertyGetterPixelOrPosPrefix):
(WebCore):
(WebCore::cssPropertyGetterPixelOrPosPrefixCallback):
(WebCore::cssPropertyGetter):
(WebCore::cssPropertyGetterCallback):
(WebCore::JSCSSStyleDeclaration::getOwnPropertySlotDelegate):
(WebCore::JSCSSStyleDeclaration::getOwnPropertyDescriptorDelegate):

  • css/CSSStyleDeclaration.idl:
23:33 Changeset [110270] by commit-queue@webkit.org

[Texmap][EFL] Implementation of AcceleratedCompositingContext for EFL port
https://bugs.webkit.org/show_bug.cgi?id=80266

Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2012-03-08
Reviewed by Noam Rosenthal.

This patch adds EFL's implementation of AcceleratedCompositingContext to WebCoreSupport.

  • WebCoreSupport/AcceleratedCompositingContextEfl.cpp: Added.

(WebCore):
(WebCore::AcceleratedCompositingContext::create):
(WebCore::AcceleratedCompositingContext::AcceleratedCompositingContext):
(WebCore::AcceleratedCompositingContext::~AcceleratedCompositingContext):
(WebCore::AcceleratedCompositingContext::initialize):
(WebCore::AcceleratedCompositingContext::syncLayersNow):
(WebCore::AcceleratedCompositingContext::renderLayers):
(WebCore::AcceleratedCompositingContext::attachRootGraphicsLayer):
(WebCore::AcceleratedCompositingContext::context):

  • WebCoreSupport/AcceleratedCompositingContextEfl.h: Added.

(WebCore):
(AcceleratedCompositingContext):

23:30 Changeset [110269] by vestbo@webkit.org

[Qt] Fix Qt minimal build

23:21 Changeset [110268] by benjamin@webkit.org

Build fix for MSVC after r110266

Unreviewed. A #ifdef for MSVC was left over in r110266.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-08

  • runtime/RegExpObject.h:

(RegExpObject):

23:16 Changeset [110267] by commit-queue@webkit.org

[chromium] Remove dead CoreGraphics code from chromium compositor implementation
https://bugs.webkit.org/show_bug.cgi?id=80470

Patch by James Robinson <jamesr@chromium.org> on 2012-03-08
Reviewed by Adam Barth.

We haven't supported CoreGraphics as a raster backend in chromium for a few months and do not plan to do so, so
it's time to remove the USE(CG) #ifdefs from our compositor and just rely on USE(SKIA) being set. This also
slightly simplifies how PlatformCanvas works.

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:
  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::createTextureUpdaterIfNeeded):

  • platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):

  • platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.h:
  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.cpp:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/PlatformCanvas.cpp:

(WebCore::PlatformCanvas::createBackingCanvas):
(WebCore::PlatformCanvas::AutoLocker::AutoLocker):
(WebCore::PlatformCanvas::AutoLocker::~AutoLocker):
(WebCore):
(WebCore::PlatformCanvas::AutoLocker::pixels):
(WebCore::PlatformCanvas::Painter::Painter):

  • platform/graphics/chromium/PlatformCanvas.h:

(WebCore):
(AutoLocker):
(Painter):
(PlatformCanvas):

  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp:
  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h:
22:49 Changeset [110266] by benjamin@webkit.org

Allocate the RegExpObject's data with the Cell
https://bugs.webkit.org/show_bug.cgi?id=80654

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-08
Reviewed by Gavin Barraclough.

This patch removes the creation of RegExpObject's data to avoid the overhead
create by the allocation and destruction.

We RegExp are created repeatedly, this provides some performance improvment.
The PeaceKeeper test stringDetectBrowser improves by 10%.

  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::RegExpObject):
(JSC::RegExpObject::visitChildren):
(JSC::RegExpObject::getOwnPropertyDescriptor):
(JSC::RegExpObject::defineOwnProperty):
(JSC::RegExpObject::match):

  • runtime/RegExpObject.h:

(JSC::RegExpObject::setRegExp):
(JSC::RegExpObject::regExp):
(JSC::RegExpObject::setLastIndex):
(JSC::RegExpObject::getLastIndex):
(RegExpObject):

22:20 Changeset [110265] by igor.o@sisa.samsung.com

Unreviewed. Update my email.

  • Scripts/webkitpy/common/config/committers.py:
22:19 Changeset [110264] by sfalken@apple.com

Source/JavaScriptCore: Separate WTF parts of JavaScriptCoreGenerated into WTFGenerated for Windows build
https://bugs.webkit.org/show_bug.cgi?id=80657

Preparation for WTF separation from JavaScriptCore.
The "Generated" vcproj files on Windows are necessary so Visual Studio can calculate correct
dependencies for generated files.

This also removes the PGO build targets from the WTF code, since we can't build instrumentation/optimization
versions of the WTF code independent of the JavaScriptCore code.

Reviewed by Jessie Berlin.

  • JavaScriptCore.vcproj/JavaScriptCore.sln: Add WTFGenerated, update dependent projects.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Removed WTF specific parts.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Removed WTF specific parts.
  • JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh: Removed WTF specific parts.
  • JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd: Removed WTF specific parts.
  • JavaScriptCore.vcproj/JavaScriptCore/work-around-vs-dependency-tracking-bugs.py: Removed.
  • JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln: Add WTFGenerated, update dependent projects.
  • JavaScriptCore.vcproj/WTF/WTF.vcproj: Remove PGO targets from WTF.
  • JavaScriptCore.vcproj/WTF/WTFGenerated.make: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
  • JavaScriptCore.vcproj/WTF/WTFGenerated.vcproj: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj.
  • JavaScriptCore.vcproj/WTF/WTFGeneratedCommon.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedCommon.vsprops.
  • JavaScriptCore.vcproj/WTF/WTFGeneratedDebug.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedDebug.vsprops.
  • JavaScriptCore.vcproj/WTF/WTFGeneratedDebugAll.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedDebugAll.vsprops.
  • JavaScriptCore.vcproj/WTF/WTFGeneratedDebugCairoCFLite.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedDebugCairoCFLite.vsprops.
  • JavaScriptCore.vcproj/WTF/WTFGeneratedProduction.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedProduction.vsprops.
  • JavaScriptCore.vcproj/WTF/WTFGeneratedRelease.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedRelease.vsprops.
  • JavaScriptCore.vcproj/WTF/WTFGeneratedReleaseCairoCFLite.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedReleaseCairoCFLite.vsprops.
  • JavaScriptCore.vcproj/WTF/WTFReleasePGO.vsprops: Removed.
  • JavaScriptCore.vcproj/WTF/build-generated-files.sh: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh.
  • JavaScriptCore.vcproj/WTF/copy-files.cmd: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd.
  • JavaScriptCore.vcproj/WTF/work-around-vs-dependency-tracking-bugs.py: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/work-around-vs-dependency-tracking-bugs.py.

Source/WebKit/win: Separate WTF parts of JavaScriptCoreGenerated into WTFGenerated for Windows build
https://bugs.webkit.org/show_bug.cgi?id=80657

Preparation for WTF separation from JavaScriptCore.
The "Generated" vcproj files on Windows are necessary so Visual Studio can calculate correct
dependencies for generated files.

Reviewed by Jessie Berlin.

  • WebKit.vcproj/WebKit.sln: Add WTFGenerated, update dependent projects.
22:08 Changeset [110263] by rniwa@webkit.org

Get rid of itemTypeAttributeChanged
https://bugs.webkit.org/show_bug.cgi?id=80666

Reviewed by Adam Barth.

This function is unnecessay as we can invalidate m_microDataItemListCaches
in invalidateCachesThatDependOnAttributes as done for other node lists.

  • dom/Node.cpp:

(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanged):
(WebCore::NodeListsNodeData::invalidateCachesThatDependOnAttributes):

  • dom/Node.h:
  • dom/NodeRareData.h:

(NodeListsNodeData):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseAttribute):

21:55 Changeset [110262] by simon.fraser@apple.com

Unreviewed, rolling out r108616.
http://trac.webkit.org/changeset/108616
https://bugs.webkit.org/show_bug.cgi?id=80676

breaks animation on Safari welcome page (Requested by smfr on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-08

  • page/animation/AnimationController.cpp:

(WebCore::AnimationController::updateAnimations):

  • page/animation/AnimationControllerPrivate.h:

(AnimationControllerPrivate):

21:52 Changeset [110261] by benjamin@webkit.org

Fix the build of WebKit with WTFURL following the removal of ForwardingHeaders/wtf
https://bugs.webkit.org/show_bug.cgi?id=80652

Reviewed by Eric Seidel.

Source/JavaScriptCore:

Fix the header, URLSegments.h is not part of the API.

  • wtf/url/api/ParsedURL.h:

Source/WebCore:

The fowarding headers have been removed, we must now use the full path to the header.

  • platform/KURLWTFURLImpl.h:
21:00 Changeset [110260] by eae@chromium.org

Change calcRadiiFor to IntSize
https://bugs.webkit.org/show_bug.cgi?id=80655

Reviewed by Simon Fraser.

Borders and RoundedRect are both represented with pixel precision. As
such it doesn't make sense for calcRadiiFor to use subpixel units, it
just adds unnecessary type conversions.

No new tests, no new functionality.

  • rendering/style/RenderStyle.cpp:

(WebCore::calcRadiiFor):

20:43 Changeset [110259] by enne@google.com

[chromium] Encapsulate mask layer settings in LayerChromium
https://bugs.webkit.org/show_bug.cgi?id=80646

Reviewed by James Robinson.

If a WebLayer sets a mask layer, the setIsMask flag will not get set
properly and the mask layer will not turn off tiling. This was only
being set through GraphicsLayerChromium. Move this flag into
LayerChromium so that it always gets set.

Test: LayoutTests/compositing/

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setMaskLayer):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setMaskLayer):

20:28 Changeset [110258] by wangxianzhu@chromium.org

Recent changes to chromium.py etc. broke chromium_android.py
https://bugs.webkit.org/show_bug.cgi?id=80623

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidDriver.init):
(ChromiumAndroidDriver._start):

20:27 Changeset [110257] by tony@chromium.org

margins on flex-align: baseline are double counted
https://bugs.webkit.org/show_bug.cgi?id=80645

Reviewed by Ojan Vafai.

Source/WebCore:

Fix a bug where we're counting the margins on baseline aligned
children twice. Also add some test cases to make sure we handle
wrap-reverse baseline alignment properly.

Tests: css3/flexbox/multiline-reverse-wrap-baseline-expected.html

css3/flexbox/multiline-reverse-wrap-baseline.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):

LayoutTests:

  • css3/flexbox/multiline-reverse-wrap-baseline-expected.html: Added.
  • css3/flexbox/multiline-reverse-wrap-baseline.html: Added.
20:07 Changeset [110256] by wangxianzhu@chromium.org

[Chromium] Exception running reftest with --no-pixel-tests
https://bugs.webkit.org/show_bug.cgi?id=80642

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumDriver.init):
(ChromiumDriver._wrapper_options):

19:52 Changeset [110255] by nduca@chromium.org

[chromium] Pass setVisibility to CCLayerTreeHostImpl regardless of LRC initialization status
https://bugs.webkit.org/show_bug.cgi?id=80584

Reviewed by James Robinson.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::setVisible):
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):

19:43 Changeset [110254] by noam.rosenthal@nokia.com

[Qt][WK2] Allow transparent WebViews
https://bugs.webkit.org/show_bug.cgi?id=80608

Reviewed by Tor Arne Vestbø.

Added support for transparentBackground in QQuickWebViewExperimental.
This uses the existing drawsTransparentBackground property in WebKit2.
Also, changed LayerTreeHostQt to set the contentsOpaque flag when the root layer changes,
otherwise the change doesn't take effect.

A new API test was added.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::setTransparentBackground):
(QQuickWebViewPrivate::transparentBackground):
(QQuickWebViewExperimental::transparentBackground):
(QQuickWebViewExperimental::setTransparentBackground):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView):
(tst_QQuickWebView::transparentWebViews):

  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::LayerTreeHostQt):
(WebKit::LayerTreeHostQt::setRootCompositingLayer):

19:35 Changeset [110253] by tony@chromium.org

rename flexbox tests to describe what is actually being tested
https://bugs.webkit.org/show_bug.cgi?id=80636

Reviewed by Ojan Vafai.

  • css3/flexbox/flex-algorithm-expected.txt: Renamed from LayoutTests/css3/flexbox/001-expected.txt.
  • css3/flexbox/flex-algorithm-min-max-expected.txt: Renamed from LayoutTests/css3/flexbox/003-expected.txt.
  • css3/flexbox/flex-algorithm-min-max.html: Renamed from LayoutTests/css3/flexbox/003.html.
  • css3/flexbox/flex-algorithm-with-margins-expected.txt: Renamed from LayoutTests/css3/flexbox/002-expected.txt.
  • css3/flexbox/flex-algorithm-with-margins.html: Renamed from LayoutTests/css3/flexbox/002.html.
  • css3/flexbox/flex-algorithm.html: Renamed from LayoutTests/css3/flexbox/001.html.
  • css3/flexbox/flex-pack-expected.txt: Renamed from LayoutTests/css3/flexbox/004-expected.txt.
  • css3/flexbox/flex-pack.html: Renamed from LayoutTests/css3/flexbox/004.html.
19:25 Changeset [110252] by commit-queue@webkit.org

[chromium] Ensure that the cc thread animation framework continues to tick when the tab is backgrounded
https://bugs.webkit.org/show_bug.cgi?id=77668

Patch by Ian Vollick <vollick@chromium.org> on 2012-03-08
Reviewed by James Robinson.

Source/WebCore:

Tested in CCLayerTreeHostTestTickAnimationWhileBackgrounded

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(CCLayerTreeHostImplTimeSourceAdapter):
(WebCore::CCLayerTreeHostImplTimeSourceAdapter::create):
(WebCore::CCLayerTreeHostImplTimeSourceAdapter::~CCLayerTreeHostImplTimeSourceAdapter):
(WebCore::CCLayerTreeHostImplTimeSourceAdapter::onTimerTick):
(WebCore::CCLayerTreeHostImplTimeSourceAdapter::setActive):
(WebCore::CCLayerTreeHostImplTimeSourceAdapter::CCLayerTreeHostImplTimeSourceAdapter):
(WebCore):
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::setVisible):
(WebCore::CCLayerTreeHostImpl::animateLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore):
(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCProxy.cpp:

(WebCore::CCProxy::currentThread):
(WebCore):
(WebCore::CCProxy::isMainThread):
(WebCore::CCProxy::isImplThread):
(WebCore::CCProxy::setCurrentThreadIsImplThread):

  • platform/graphics/chromium/cc/CCProxy.h:

(CCProxy):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::postAddInstantAnimationToMainThread):
(CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::dispatchAddInstantAnimation):
(WTF::CCLayerTreeHostTest::dispatchAddAnimation):
(WTF::CCLayerTreeHostTestAddAnimation::beginTest):
(WTF):
(CCLayerTreeHostTestTickAnimationWhileBackgrounded):
(WTF::CCLayerTreeHostTestTickAnimationWhileBackgrounded::CCLayerTreeHostTestTickAnimationWhileBackgrounded):
(WTF::CCLayerTreeHostTestTickAnimationWhileBackgrounded::beginTest):
(WTF::CCLayerTreeHostTestTickAnimationWhileBackgrounded::animateLayers):
(WTF::CCLayerTreeHostTestTickAnimationWhileBackgrounded::afterTest):
(WTF::TEST_F):

19:21 Changeset [110251] by thakis@chromium.org

[chromium] Only build NEON files if target_arch=="arm"
https://bugs.webkit.org/show_bug.cgi?id=80626

Currently, webcore_arm_neon will compile a bunch of files
whose contents are completely ifdef'd away on non-arm, and
then bundle all the generated empty .o files into a useless
libwebcore_arm_neon.a. Don't do this.

Reviewed by Tony Chang.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
19:07 Changeset [110250] by commit-queue@webkit.org

[NRWT] Fix --platform=qt-5.0 --new-baseline combo
https://bugs.webkit.org/show_bug.cgi?id=72489

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-03-08
Reviewed by Dirk Pranke.

NRWT: The default platform name for Qt combined with --webkit-test-runner is now
"qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests.
--platform will override the platform name and then we'll use it.

ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower
than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will
override it in the end.

  • Scripts/old-run-webkit-tests:
  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort):
(QtPort.determine_full_port_name):
(QtPort.baseline_search_path):

  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:

(QtPortTest):
(QtPortTest._assert_search_path):
(QtPortTest.test_baseline_search_path):

19:05 Changeset [110249] by commit-queue@webkit.org

[BlackBerry] Fix warning in PlatformTouchEventBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=80621

Fixes a warning seen when control reaches the end of a
non-void function. Return TouchCancel in the 'default' case.

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-03-08
Reviewed by Rob Buis.

  • platform/blackberry/PlatformTouchEventBlackBerry.cpp:

(WebCore::touchEventType):

18:53 Changeset [110248] by kov@webkit.org

GTK+ build fix. Only try to get the backing from the layer in when
ACCELERATED_COMPOSITING is enabled.

Rubber-stamped by Ryosuke Niwa.

  • WebProcess/FullScreen/WebFullScreenManager.cpp:

(WebKit::screenRectOfContents):

18:50 Changeset [110247] by commit-queue@webkit.org

[chromium] Using wrong scissor rect for draw culling
https://bugs.webkit.org/show_bug.cgi?id=80624

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-08
Reviewed by Adrienne Walker.

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::optimizeRenderPasses):

18:33 Changeset [110246] by ukai@chromium.org

Unreviewed, update chromium test expectations.

  • platform/chromium/test_expectations.txt:
18:30 Changeset [110245] by commit-queue@webkit.org

[chromium] Force the Canvas2D GPU texture cache to 0 bytes for backgrounded tabs.
https://bugs.webkit.org/show_bug.cgi?id=79948

Patch by Jeff Timanus <twiz@chromium.org> on 2012-03-08
Reviewed by Stephen White.

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GrMemoryAllocationChangedCallback::onGpuMemoryAllocationChanged):
(WebCore::GraphicsContext3DPrivate::grContext):
(WebCore::GraphicsContext3DPrivate::setVisibilityCHROMIUM):

18:25 Changeset [110244] by ojan@chromium.org

Fix some Leopard tests that broke with r110229.

  • platform/chromium-mac-leopard/fast/table/cell-coalescing-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/floating-th-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/complex-text-opacity-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/text/international/bidi-AN-after-L-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/text/international/bidi-CS-after-AN-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/text/international/thai-baht-space-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/text/wbr-pre-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/whitespace/001-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/whitespace/019-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/whitespace/023-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/whitespace/028-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/whitespace/029-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/whitespace/pre-newline-box-test-expected.png: Added.
  • platform/chromium-mac-leopard/fast/writing-mode/border-vertical-lr-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/xsl/xslt-enc-cyr-expected.png: Added.
  • platform/chromium-mac-leopard/fast/xsl/xslt-enc-expected.png: Added.
  • platform/chromium-mac-leopard/fast/xsl/xslt-enc16-expected.png: Added.
  • platform/chromium-mac-leopard/fast/xsl/xslt-enc16to16-expected.png: Added.
  • platform/chromium-mac-leopard/fast/xsl/xslt-extra-content-at-end-expected.png: Added.
  • platform/chromium-mac-leopard/fast/xsl/xslt_unicode-expected.png: Added.
18:24 Changeset [110243] by aestes@apple.com

REGRESSION (r105396): Dragging an iWork document into icloud.com opens it in the Mac app instead of uploading it to icloud.com
https://bugs.webkit.org/show_bug.cgi?id=79443

Reviewed by Ryosuke Niwa.

Source/WebCore:

icloud.com registers a drop event handler that sets display:none on the
file input element receiving the drop. After dispatching the drop event,
DragController hit tests the position under the mouse to see if it is a
file input element in need of receiving files. Since the file input
element has lost its renderer, it cannot be found by hit testing, so
the dropped file is never attached to the file input element, no change
event fires, and no upload commences. We want these things to happen
even if the element is no longer visible.

Since we already keep track of the file input element under the mouse
via m_fileInputElementUnderMouse, this additional hit test is
unnecessary. Use m_fileInputElementUnderMouse in concludeEditDrag()
when dropping files.

Test: fast/events/file-input-hidden-in-ondrop.html

  • page/DragController.cpp:

(WebCore::DragController::concludeEditDrag): Use
m_fileInputElementUnderMouse instead of the element returned by hit
testing. Assert that m_fileInputElementUnderMouse equals the hit tested
element unless m_fileInputElementUnderMouse doesn't have a renderer.

LayoutTests:

  • fast/events/file-input-hidden-in-ondrop-expected.txt: Added.
  • fast/events/file-input-hidden-in-ondrop.html: Added.
  • platform/wk2/Skipped: WebKitTestRunner doesn't support

EventSender.beginDragWithFiles().

18:19 Changeset [110242] by commit-queue@webkit.org

[chromium] Replace completelyContains with Region::contains()
https://bugs.webkit.org/show_bug.cgi?id=80617

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-08
Reviewed by James Robinson.

  • tests/CCLayerTestCommon.cpp:

(CCLayerTestCommon):
(CCLayerTestCommon::verifyQuadsExactlyCoverRect):

  • tests/CCLayerTestCommon.h:

(CCLayerTestCommon):

17:53 Changeset [110241] by ojan@chromium.org

Moar Chromium Lion rebaselines.

17:27 Changeset [110240] by commit-queue@webkit.org

[chromium] more comprehensive tests for gesture scrolling
https://bugs.webkit.org/show_bug.cgi?id=80201

Prior to landing some changes to EventHandler::handleGestureEvent, add
some tests to ensure that the behaviour of handleGestureEvent and
handleWheelEvent don't regress.

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-08
Reviewed by Dimitri Glazkov.

  • fast/events/touch/gesture/resources/gesture-helpers.js: Added: utility functions.

(recordWheel):
(recordScroll):
(exitIfNecessary):
(checkTestDependencies):
(checkScrollOffset):

  • fast/events/touch/gesture/resources/scroll-inside-iframe.html: Added.
  • fast/events/touch/gesture/touch-gesture-scroll-div-expected.txt: Added.
  • fast/events/touch/gesture/touch-gesture-scroll-div.html: Added.
  • fast/events/touch/gesture/touch-gesture-scroll-iframe-expected.txt: Added.
  • fast/events/touch/gesture/touch-gesture-scroll-iframe.html: Added.
  • fast/events/touch/gesture/touch-gesture-scroll-page-expected.txt: Added.
  • fast/events/touch/gesture/touch-gesture-scroll-page.html: Added.
  • fast/events/touch/gesture/touch-gesture-scroll-shy-target-expected.txt: Added.
  • fast/events/touch/gesture/touch-gesture-scroll-shy-target.html: Added.
  • platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-div-expected.txt: Added.
  • platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-iframe-expected.txt: Added.
  • platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-page-expected.txt: Added.
  • platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-shy-target-expected.txt: Added.
17:22 Changeset [110239] by eae@chromium.org

Fix alignment in RenderDeprecatedFlexibleBox on branch.

17:22 Changeset [110238] by rniwa@webkit.org

Mac build fix for micro data API.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:

(WebCore::Document::removeCachedMicroDataItemList):

  • html/HTMLElement.idl:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
17:13 Changeset [110237] by senorblanco@chromium.org

[chromium] Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
17:11 Changeset [110236] by senorblanco@chromium.org

[chromium] Unreviewed gardening.

  • platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Removed.
17:07 Changeset [110235] by senorblanco@chromium.org

[chromium] Unreviewed gardening.

Mark a bunch of tests as failing on Leopard.

  • platform/chromium/test_expectations.txt:
16:59 Changeset [110234] by eae@chromium.org

More int/layoutunit fixes for subpixel branch.

16:49 Changeset [110233] by barraclough@apple.com

String.prototype.match and replace do not clear global regexp lastIndex per ES5.1 15.5.4.10
https://bugs.webkit.org/show_bug.cgi?id=26890

Reviewed by Oliver Hunt.

Per 15.10.6.2 step 9.a.1 called via the action of the last iteration of 15.5.4.10 8.f.i.

Source/JavaScriptCore:

  • runtime/StringPrototype.cpp:

(JSC::replaceUsingRegExpSearch):
(JSC::stringProtoFuncMatch):

  • added calls to setLastIndex.

LayoutTests:

  • fast/js/script-tests/string-match.js: Added.
  • fast/js/string-match-expected.txt: Added.
  • fast/js/string-match.html: Added.
    • Added test case for match.
  • fast/js/script-tests/string-replace-2.js:
  • fast/js/string-replace-2-expected.txt:
    • Added tests for update correct lastIndex handling.
16:46 Changeset [110232] by jonlee@apple.com

Support [Custom] for static functions
https://bugs.webkit.org/show_bug.cgi?id=80573

Reviewed by Kentaro Hara.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader): If the function is static, add static qualifier to cpp function.
(GenerateImplementation): Reorganize the function to split out based on the static
attribute, instead of checking for it at every line we output.

If the function is static and not custom, the listed code should be the code in

the rest of the function that did not have the static check. If it is custom, then
we check the number of arguments, and then call the static impl function directly.

If the function is not static, all of the "unless ($function->isStatic)" checks

are removed since it is not necessary.

  • bindings/scripts/test/TestObj.idl: Added new test case.
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):
(WebCore::jsTestObjConstructorFunctionClassMethod2):

  • bindings/scripts/test/JS/JSTestObj.h:

(JSTestObj):
(WebCore):

  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj classMethod2]):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::ConfigureV8TestObjTemplate):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

16:41 Changeset [110231] by commit-queue@webkit.org

Collapse ENABLE(BLOB)|ENABLE(FILE_SYSTEM) to just ENABLE(BLOB)
https://bugs.webkit.org/show_bug.cgi?id=80592

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-03-08
Reviewed by Adam Barth.

In anticipation of moving FILE_SYSTEM-related code to Modules/, we
are collapsing combination BLOB/FILE_SYSTEM ifdefs to just
BLOB. In other words, it is assumed from now on that you can not
have FILE_SYSTEM support without BLOB support.

No new tests, all existing tests pass.

  • CMakeLists.txt:
  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore):
(WebCore::ScriptExecutionContext::fileThread):

  • dom/ScriptExecutionContext.h:

(WebCore):
(ScriptExecutionContext):

  • fileapi/AsyncFileStream.cpp:
  • fileapi/AsyncFileStream.h:
  • fileapi/FileError.h:
  • fileapi/FileException.cpp:
  • fileapi/FileException.h:
  • fileapi/FileThread.cpp:
  • fileapi/FileThread.h:
  • fileapi/OperationNotAllowedException.cpp:
  • fileapi/OperationNotAllowedException.h:
  • platform/FileStream.cpp:
  • platform/FileStream.h:
  • platform/FileStreamClient.h:
  • platform/SchemeRegistry.cpp:

(WebCore::canDisplayOnlyIfCanRequestSchemes):
(WebCore::CORSEnabledSchemes):
(WebCore::SchemeRegistry::registerURLSchemeAsNotAllowingJavascriptURLs):

16:31 Changeset [110230] by commit-queue@webkit.org

[BlackBerry] Always use the current focused node when processing focus changes
https://bugs.webkit.org/show_bug.cgi?id=80594

Patch by Mike Fenton <mifenton@rim.com> on 2012-03-08
Reviewed by Antonio Gomes.

Guard against toRange or fromRange being null when called
as part of a clear event.

  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):

16:19 Changeset [110229] by ojan@chromium.org

NULL renderer possible in WebCore::HTMLInputElement::setCanReceiveDroppedFiles()
https://bugs.webkit.org/show_bug.cgi?id=80648

Patch by Andy Estes <aestes@apple.com> on 2012-03-08
Reviewed by Simon Fraser.

  • fast/events/input-element-display-none-in-dragleave-crash-expected.txt: Added.
  • fast/events/input-element-display-none-in-dragleave-crash.html: Added.
  • platform/wk2/Skipped: WebKitTestRunner doesn't support

EventSender.beginDragWithFiles().

16:13 Changeset [110228] by jer.noble@apple.com

Unreviewed Snow Leopard build fix.

On Leopard and Snow Leopard, provide an implementation for -[NSWindow convertRectToScreen:].

Source/WebKit/mac:

  • WebView/WebFullScreenController.mm:

(-[NSWindow convertRectToScreen:]):

Source/WebKit2:

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[NSWindow convertRectToScreen:]):

15:52 Changeset [110227] by jamesr@google.com

Use an explicit attribute to signal that a context prefers to use a discrete GPU
https://bugs.webkit.org/show_bug.cgi?id=80639

Reviewed by Stephen White.

Source/Platform:

Adds preferDiscreteGPU attribute to WebGraphicsContext3D::Attributes. Also remove the forUseOnAnotherThread
attribute, this has been dead code for a while now.

  • chromium/public/WebGraphicsContext3D.h:

(WebKit::WebGraphicsContext3D::Attributes::Attributes):
(Attributes):

Source/WebCore:

On platforms that support both integrated and discrete GPUs and can dynamically switch between the two, we
sometimes have a specific preference for a given context. Specifically, contexts used for WebGL and canvas 2d
acceleration should use the discrete GPU if available, but compositor contexts can run fine on an integrated
GPU. Instead of attempting to infer the intent from examining other context attributes, this adds an explicit
attribute to control this behavior.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::create):

  • platform/graphics/GraphicsContext3D.h:

(WebCore::GraphicsContext3D::Attributes::Attributes):
(Attributes):

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp:

(WebCore::SharedGraphicsContext3D::get):

Source/WebKit/chromium:

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3DPrivate::getContextAttributes):
(WebCore::GraphicsContext3D::create):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::createCompositorGraphicsContext3D):

15:47 Changeset [110226] by aestes@apple.com

NULL renderer possible in WebCore::HTMLInputElement::setCanReceiveDroppedFiles()
https://bugs.webkit.org/show_bug.cgi?id=80648

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/events/input-element-display-none-in-dragleave-crash.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setCanReceiveDroppedFiles): NULL-check renderer().

LayoutTests:

  • fast/events/input-element-display-none-in-dragleave-crash-expected.txt: Added.
  • fast/events/input-element-display-none-in-dragleave-crash.html: Added.
  • platform/wk2/Skipped: WebKitTestRunner doesn't support

EventSender.beginDragWithFiles().

15:46 Changeset [110225] by jer.noble@apple.com

Yet another unreviewed build fix.

Remove an unneeded and Lion-defined window constant from WebCoreFullScreenWindow.

  • platform/mac/WebCoreFullScreenWindow.mm:

(-[WebCoreFullScreenWindow initWithContentRect:styleMask:backing:defer:]):

15:41 Changeset [110224] by leviw@chromium.org

Switch absoluteRects, culledInlineAbsoluteRects, absoluteBoundingBoxRect, and addFocusRingRects back to integers
https://bugs.webkit.org/show_bug.cgi?id=80545

Reviewed by Simon Fraser.

Converting the above functions, all of which return rects that represent on-screen rects, to IntRects from
LayoutRects.

addFocusRingsRects generates a vector of rects that is handed off directly to the GraphicsContext to be
drawn. Snapping the rects before adding them to the vector saves an extra pass through the vector.

absoluteRects and culledInlineAbsoluteRects are only used by addFocusRingRects, hasNonEmptyBoundingBox (only
to check if they're empty), and absoluteBoundingBoxRect, which is exposed from WebCore and thus should be an
IntRect anyways.

No new tests. No change in behavior.

  • dom/Node.cpp:

(WebCore::Node::hasNonEmptyBoundingBox):

  • dom/Range.cpp:

(WebCore::Range::boundingBox):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::absoluteRects):
(WebCore::RenderBlock::addFocusRingRects):

  • rendering/RenderBlock.h:

(RenderBlock):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::absoluteRects):
(WebCore::RenderInline::culledInlineAbsoluteRects):
(WebCore::RenderInline::addFocusRingRects):

  • rendering/RenderInline.h:

(RenderInline):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::addFocusRingRects):

  • rendering/RenderListBox.h:

(RenderListBox):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::paintFocusRing):
(WebCore::RenderObject::absoluteBoundingBoxRect):
(WebCore::RenderObject::absoluteFocusRingQuads):

  • rendering/RenderObject.h:

(WebCore::RenderObject::absoluteRects):
(RenderObject):
(WebCore::RenderObject::absoluteBoundingBoxRectIgnoringTransforms):
(WebCore::RenderObject::addFocusRingRects):

  • rendering/RenderText.cpp:

(WebCore::RenderText::absoluteRects):
(WebCore::RenderText::absoluteRectsForRange):

  • rendering/RenderText.h:

(RenderText):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::addFocusRingRects):

  • rendering/RenderTextControl.h:

(RenderTextControl):

  • rendering/RenderView.cpp:

(WebCore::RenderView::absoluteRects):

  • rendering/RenderView.h:

(RenderView):

  • rendering/svg/RenderSVGBlock.cpp:

(WebCore::RenderSVGBlock::absoluteRects):

  • rendering/svg/RenderSVGBlock.h:

(RenderSVGBlock):

  • rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::addFocusRingRects):

  • rendering/svg/RenderSVGContainer.h:

(RenderSVGContainer):

  • rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::addFocusRingRects):

  • rendering/svg/RenderSVGImage.h:

(RenderSVGImage):

  • rendering/svg/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::absoluteRects):

  • rendering/svg/RenderSVGModelObject.h:

(RenderSVGModelObject):

  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::addFocusRingRects):

  • rendering/svg/RenderSVGShape.h:

(RenderSVGShape):

15:38 Changeset [110223] by jer.noble@apple.com

Further unreviewed build fix.

Add in the WebCore namespace, so that IntRect is pulled in.

  • UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp:
  • UIProcess/qt/WebFullScreenManagerProxyQt.cpp:
  • UIProcess/win/WebFullScreenManagerProxyWin.cpp:
15:35 Changeset [110222] by arv@chromium.org

[V8] Use EventNames instead of strings
https://bugs.webkit.org/show_bug.cgi?id=80649

Reviewed by Ojan Vafai.

No new tests. Covered by existing tests.

  • bindings/v8/V8AbstractEventListener.cpp:

(WebCore::V8AbstractEventListener::invokeEventHandler):

15:32 Changeset [110221] by timothy_horton@apple.com

No-op filter changes color output because of colorspace issues
https://bugs.webkit.org/show_bug.cgi?id=72411
<rdar://problem/10588374>

Reviewed by Dean Jackson.

Redefine "linear RGB" color space on Mac to mean linearized sRGB, instead of linear
Generic RGB. This makes existing CG color matching equivalent to what other ports do via
ImageBuffer::transformColorSpace (which only adjusts gamma, as we will now). Previously,
we were also causing actual (non-gamma) color adjustments which were not reversible.

No new tests, covered by all existing SVG and CSS filter tests.

  • Resources/linearSRGB.icc: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::linearRGBColorSpaceRef):

15:28 Changeset [110220] by jer.noble@apple.com

Unreviewed build fix.

Add stub implementations of beganEnterFullScreen and beganExitFullScreen
to platform-specific WebFullScreenManagerProxy implementations.

  • UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp:

(WebKit::WebFullScreenManagerProxy::beganEnterFullScreen):
(WebKit::WebFullScreenManagerProxy::beganExitFullScreen):

  • UIProcess/qt/WebFullScreenManagerProxyQt.cpp:

(WebKit::WebFullScreenManagerProxy::beganEnterFullScreen):
(WebKit::WebFullScreenManagerProxy::beganExitFullScreen):

  • UIProcess/win/WebFullScreenManagerProxyWin.cpp:

(WebKit::WebFullScreenManagerProxy::beganEnterFullScreen):
(WebKit::WebFullScreenManagerProxy::beganExitFullScreen):

15:24 Changeset [110219] by leviw@chromium.org

Fixing asoluteRectsForRange, a misspelling in MathML, and various other small changes.

15:24 Changeset [110218] by bdakin@apple.com

https://bugs.webkit.org/show_bug.cgi?id=80463
RenderImage is using the wrong origin when calling addRelevantRepaintedObject
-and corresponding-
<rdar://problem/10970221>

Reviewed by Dan Bernstein.

Source/WebCore:

Use the exact same rect that we paint with instead of the
visualOverflowRect() which does not always have a correct x and y.

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::paintReplaced):

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::paintReplaced):

Tools:

New test!

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp: Added.

(TestWebKitAPI):
(TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp: Added.

(TestWebKitAPI):
(NewFirstVisuallyNonEmptyLayoutForImagesTest):
(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::NewFirstVisuallyNonEmptyLayoutForImagesTest):
(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::didCreatePage):

  • TestWebKitAPI/Tests/WebKit2/lots-of-images.html: Added.
15:20 Changeset [110217] by jonlee@apple.com

Add support for ENABLE(LEGACY_NOTIFICATIONS)
https://bugs.webkit.org/show_bug.cgi?id=80497

Reviewed by Adam Barth.

Source/JavaScriptCore:

Prep for b80472: Update API for Web Notifications

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Prep for b80472: Update API for Web Notifications

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:

Source/WebKit/mac:

Prep for b80472: Update API for Web Notifications

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Prep for b80472: Update API for Web Notifications

  • Configurations/FeatureDefines.xcconfig:
15:15 Changeset [110216] by jer.noble@apple.com

Full Screen Refactor Part 4: Animate into Full Screen mode using new animation classes, WebKit edition.
https://bugs.webkit.org/show_bug.cgi?id=78930

Reviewed by Anders Carlsson.

Revise WebFullScreenController to have the same general functionality and code path as WKFullScreenWindowController
in WebKit2. As such, the following functions are copies of their equivalents in WKFullScreenWindowController:

  • WebView/WebFullScreenController.mm:

(-[WebFullScreenController init]):
(-[WebFullScreenController dealloc]):
(-[WebFullScreenController windowDidLoad]):
(-[WebFullScreenController cancelOperation:]):
(-[WebFullScreenController applicationDidResignActive:]):
(-[WebFullScreenController applicationDidChangeScreenParameters:]):
(-[WebFullScreenController finishedEnterFullScreenAnimation:]):
(-[WebFullScreenController finishedExitFullScreenAnimation:]):
(-[WebFullScreenController close]):
(-[WebFullScreenController animationDidEnd:]):
(-[WebFullScreenController _updateMenuAndDockForFullScreen]):
(-[WebFullScreenController _swapView:with:]):
(createBackgroundFullscreenWindow):
(windowFrameFromApparentFrames):
(-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
(-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):

The following is a copy of the equivalent function in WebFullScreenManager:

  • WebView/WebFullScreenController.mm:

(screenRectOfContents):

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::fullScreenRendererChanged): No longer tell the WebView the renderer changed (as it doesn't care.)

  • WebView/WebFullScreenController.h:
  • WebView/WebFullScreenController.mm:

(-[WebFullScreenController setElement:]): No need to add event listeners to the media element.
(-[WebFullScreenController enterFullScreen:]): Same as WKFullScreenWindowController, but not asynchronous.
(-[WebFullScreenController exitFullScreen]): Ditto.

  • WebView/WebView.mm:

(-[WebView _enterFullScreenForElement:WebCore::]): Fullscreen -> FullScreen.
(-[WebView _exitFullScreenForElement:WebCore::]): Ditto.

15:15 Changeset [110215] by jer.noble@apple.com

Full Screen Refactor Part 3: Animate into Full Screen mode using new animation classes.
https://bugs.webkit.org/show_bug.cgi?id=78928

Reviewed by Anders Carlsson.

Source/WebCore:

Move WKFullScreenWindow from WebKit2 into WebCore to be shared by WebKit2 and WebKit.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/WebCoreFullScreenWindow.h:
  • platform/mac/WebCoreFullScreenWindow.mm:

Add symbols for the following classes and functions to the export list:

WebCoreFullScreenWindow
WebWindowScaleAnimation
WebWindowFadeAnimation
ScrollView::contentsToScreen()
RenderObject::localToContainerQuad()
Document::setAnimatingFullScreen()

  • WebCore.exp.in:

Source/WebKit2:

Boilerplate changes to WebKit2 IPC messages and supporting functions.

  • UIProcess/WebFullScreenManagerProxy.cpp:

(WebKit::WebFullScreenManagerProxy::setAnimatingFullScreen): Added boilerplate.

  • UIProcess/WebFullScreenManagerProxy.h:
  • UIProcess/WebFullScreenManagerProxy.messages.in:
  • UIProcess/mac/WebFullScreenManagerProxyMac.mm:

(WebKit::WebFullScreenManagerProxy::beganEnterFullScreen): Added boilerplate.
(WebKit::WebFullScreenManagerProxy::beganExitFullScreen): Added boilerplate.

  • WebProcess/FullScreen/WebFullScreenManager.cpp:

(WebKit::screenRectOfContents): Added. Calculates the screen rect of an element's contents.
(WebKit::WebFullScreenManager::enterFullScreenForElement): Use screenRectOfContents()
(WebKit::WebFullScreenManager::willEnterFullScreen): Ditto. Do not set the background color. Call new BeganEnterFullScreen

XPC message.

(WebKit::WebFullScreenManager::didEnterFullScreen): Do not set the background color.
(WebKit::WebFullScreenManager::willExitFullScreen): Use screenRectOfContents. Do not set the background color. Call new

BeganExitFullScreen XPC message.

(WebKit::WebFullScreenManager::didExitFullScreen): Do not set the background color.
(WebKit::WebFullScreenManager::setAnimatingFullScreen): Added boilerplate.

  • WebProcess/FullScreen/WebFullScreenManager.h:
  • WebProcess/FullScreen/WebFullScreenManager.messages.in:
  • UIProcess/mac/WKFullScreenWindowController.h:
  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController cancelOperation:]): Renamed from _requestExitWithAnimation:.
(-[WKFullScreenWindowController applicationDidResignActive:]): Call cancelOperation: instead

of _requestExitWithAnimation.

(-[WKFullScreenWindowController applicationDidChangeScreenParameters:]): Set the frame of

both the full screen window and the background window.

(-[WKFullScreenWindowController enterFullScreen:]): Save a rendered image of the current

page to use in the placeholder.

(-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:WebCore::finalFrame:WebCore::]): Renamed from

beganEnterFullScreenAnimation.

(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): No need to swap

placeholder views here, as they were already swapped in beganEnter...:.

(-[WKFullScreenWindowController exitFullScreen]):
(-[WKFullScreenWindowController beganExitFullScreenWithInitialFrame:WebCore::finalFrame:WebCore::]): Renamed from

beganExitFullScreenAnimation.

(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]): Swap web view back into place.
(-[WKFullScreenWindowController close]):
(-[WKFullScreenWindowController animationDidEnd:]): Added.
(createBackgroundFullscreenWindow): Added.
(windowFrameFromApparentFrames): Added.
(-[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]): Added.
(-[WKFullScreenWindowController _startExitFullScreenAnimationWithDuration:]): Added.

15:14 Changeset [110214] by jer.noble@apple.com

Full Screen Refactor Part 2: Remove unnecessary WebKit2 APIs for Full Screen made
https://bugs.webkit.org/show_bug.cgi?id=78926

Reviewed by John Sullivan.

The following functions (and also their Proxy versions) were removed completely:
WebFullScreenManager::enterAcceleratedCompositingMode(const LayerTreeContext&)
WebFullScreenManager::exitAcceleratedCompositingMode()
WebFullScreenManager::beganEnterFullScreenAnimation()
WebFullScreenManager::finishedEnterFullScreenAnimation(bool)
WebFullScreenManager::beganExitFullScreenAnimation()
WebFullScreenManager::finishedExitFullScreenAnimation(bool)
WebFullScreenManager::getFullScreenRect(WebCore::IntRect&)

  • UIProcess/WebFullScreenManagerProxy.cpp:
  • UIProcess/WebFullScreenManagerProxy.h:

(WebKit::WebFullScreenManagerProxy::beginEnterFullScreenAnimation):
(WebKit::WebFullScreenManagerProxy::beginExitFullScreenAnimation):
(WebKit::WebFullScreenManagerProxy::disposeOfLayerClient):
(WebFullScreenManagerProxy):

  • UIProcess/WebFullScreenManagerProxy.messages.in:
  • UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp:
  • UIProcess/mac/WebFullScreenManagerProxyMac.mm:
  • UIProcess/qt/WebFullScreenManagerProxyQt.cpp:
  • UIProcess/win/WebFullScreenManagerProxyWin.cpp:

(WebKit::WebFullScreenManagerProxy::finishedExitFullScreenAnimation):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/FullScreen/WebFullScreenManager.cpp:

(WebKit::WebFullScreenManager::create):
(WebKit::WebFullScreenManager::~WebFullScreenManager):

  • WebProcess/FullScreen/WebFullScreenManager.h:

(WebFullScreenManager):

  • WebProcess/FullScreen/WebFullScreenManager.messages.in:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::exitFullScreenForElement):

  • WebProcess/WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

Additionally, the platform-specific WebFullScreenManager subclasses were removed, as no
platform-specific implementations remained after the above functions were removed:

  • GNUmakefile.am:
  • Target.pri:
  • win/WebKit2.vcproj:
  • WebProcess/FullScreen/gtk/WebFullScreenManagerGtk.cpp: Removed.
  • WebProcess/FullScreen/gtk/WebFullScreenManagerGtk.h: Removed.
  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.h: Removed.
  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: Removed.
  • WebProcess/FullScreen/qt/WebFullScreenManagerQt.cpp: Removed.
  • WebProcess/FullScreen/qt/WebFullScreenManagerQt.h: Removed.
  • WebProcess/FullScreen/win/WebFullScreenManagerWin.cpp: Removed.
  • WebProcess/FullScreen/win/WebFullScreenManagerWin.h: Removed.
15:14 Changeset [110213] by jer.noble@apple.com

Full Screen Refactor Part 1: Remove special-case rendering code for Full Screen animation.
https://bugs.webkit.org/show_bug.cgi?id=78925

Reviewed by John Sullivan.

No new tests; no net change in functionality so covered by existing tests.

The following functions had special case code for rendering full-screen elements removed:

  • dom/Document.cpp:

(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidEnterFullScreenForElement):
(WebCore::Document::webkitWillExitFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):
(WebCore::Document::setAnimatingFullScreen):

  • page/FrameView.cpp:

(WebCore):
(WebCore::FrameView::updateCompositingLayers):
(WebCore::FrameView::syncCompositingStateForThisFrame):

  • rendering/RenderLayerBacking.cpp:

(WebCore::layerOrAncestorIsTransformed):
(WebCore::RenderLayerBacking::updateCompositedBounds):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
(WebCore::RenderLayerCompositor::requiresCompositingLayer):

  • rendering/RenderLayerCompositor.h:
15:08 Changeset [110212] by mlilek@apple.com

Don't enable VIDEO_TRACK on all OS X platforms
https://bugs.webkit.org/show_bug.cgi?id=80635

Reviewed by Eric Carlson.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
15:05 Changeset [110211] by ojan@chromium.org

Moar Chromium Lion rebaselines.

14:58 Changeset [110210] by rniwa@webkit.org

perf-o-matic should incrementally update JSON responses
https://bugs.webkit.org/show_bug.cgi?id=79898

Reviewed by Eric Seidel.

Now that Runs object store test_runs and averages separately,
we can update JSON data incrementally without degrading values.

Also fixed the order of arguments passed to DashboardImage.needs_update
in schedule_runs_update. This bug had caused all chart images to be
updated on every new report.

  • Websites/webkit-perf.appspot.com/controller.py:

(schedule_runs_update):

  • Websites/webkit-perf.appspot.com/models.py:

(Runs.update_or_insert):
(Runs.update_incrementally):
(Runs):
(Runs.get_by_objects):

  • Websites/webkit-perf.appspot.com/models_unittest.py:

(RunsTest._create_results):
(RunsTest.test_generate_runs):
(RunsTest.test_update_or_insert):
(RunsTest.test_update_incrementally):
(RunsTest.test_to_json_with_results):

  • Websites/webkit-perf.appspot.com/report_process_handler.py:

(ReportProcessHandler.post):

14:55 Changeset [110209] by tony@chromium.org

implement flexbox wrap-reverse
https://bugs.webkit.org/show_bug.cgi?id=80552

Reviewed by Ojan Vafai.

Source/WebCore:

No new tests, but additional coverage in:

css3/flexbox/multiline-align.html
css3/flexbox/multiline-pack.html
css3/flexbox/multiline.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::WrapReverseContext::WrapReverseContext): Helper struct to hold information needed for reversing
the order of lines.
(RenderFlexibleBox::WrapReverseContext):
(WebCore::RenderFlexibleBox::WrapReverseContext::addCrossAxisOffset):
(WebCore::RenderFlexibleBox::WrapReverseContext::addNumberOfChildrenOnLine):
(WebCore::RenderFlexibleBox::WrapReverseContext::lineCrossAxisDelta): Computes the number of pixels to move a line.
(WebCore):
(WebCore::RenderFlexibleBox::layoutFlexItems): Call flipForWrapReverse if needed. This happens
before flipForRightToLeftColumn because otherwise the crossAxisOffsets will be wrong.
(WebCore::flexAlignForChild):
(WebCore::RenderFlexibleBox::alignChildren): Flip alignment in wrap-reverse because the cross directions are flipped.
(WebCore::RenderFlexibleBox::flipForWrapReverse): Flip each line.

  • rendering/RenderFlexibleBox.h:

(RenderFlexibleBox):

LayoutTests:

  • css3/flexbox/multiline-align-expected.txt:
  • css3/flexbox/multiline-align.html:
  • css3/flexbox/multiline-expected.txt:
  • css3/flexbox/multiline-pack-expected.txt:
  • css3/flexbox/multiline-pack.html:
  • css3/flexbox/multiline.html:
14:53 Changeset [110208] by oliver@apple.com

Build fix. That day is not today.

14:47 Changeset [110207] by adamk@chromium.org

Remove InDocumentFlag manipulation methods from Node interface
https://bugs.webkit.org/show_bug.cgi?id=80612

Reviewed by Ryosuke Niwa.

This is a first step towards tightening up Node::inDocument() to match
the actual in-document-tree state (see r108152 for the sort of bug
resulting from those not matching).

No new tests, refactoring only.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::removedFromDocument): Remove duplicate call to clearInDocument:
the call to Node::removedFromDocument three lines above will clear the flag.

  • dom/Document.cpp:

(WebCore::Document::Document): Call ContainerNode constructor with InDocumentFlag always set
instead of calling setInDocument.

  • dom/Node.cpp:

(WebCore::Node::insertedIntoDocument): Inline setInDocument (now the only caller).
(WebCore::Node::removedFromDocument): Inline clearInDocument (now the only caller).

  • dom/Node.h: Remove setInDocument & clearInDocument, add new CreateDocument ConstructionType.
14:29 Changeset [110206] by oliver@apple.com

Build fix. One of these days I'll manage to commit something that works everywhere.

14:28 LayoutUnit edited by leviw@chromium.org
(diff)
14:09 Changeset [110205] by vestbo@webkit.org

[Qt] Try to fix the Snow Leopard build

If the build is running under sh, echo -n does not empty the file.

14:03 Changeset [110204] by commit-queue@webkit.org

Update MIPS patchOffsetGetByIdSlowCaseCall
https://bugs.webkit.org/show_bug.cgi?id=80302

Patch by Chao-ying Fu <fu@mips.com> on 2012-03-08
Reviewed by Oliver Hunt.

  • jit/JIT.h:

(JIT):

14:01 Changeset [110203] by eae@chromium.org

Merge baseline changes up until r110176 into subpixel branch.

14:00 Changeset [110202] by vestbo@webkit.org

Prospective build fix for Qt minimal after r110191

https://bugs.webkit.org/show_bug.cgi?id=80338

  • testing/Internals.cpp:

(WebCore):

  • testing/Internals.h:

(Internals):

14:00 Changeset [110201] by ojan@chromium.org

More Chromium Lion rebaselines as well as some fixes for
Chromium Leopard/SnowLeopard from previous Lion rebaselines.

13:58 Changeset [110200] by oliver@apple.com

Missing some places where we should be blinding 64bit values (and blinding something we shouldn't)
https://bugs.webkit.org/show_bug.cgi?id=80633

Reviewed by Gavin Barraclough.

Add 64-bit trap for shouldBlindForSpecificArch, so that we always blind
if there isn't a machine specific implementation (otherwise the 64bit value
got truncated and 32bit checks were used -- leaving 32bits untested).
Also add a bit of logic to ensure that we don't try to blind a few common
constants that go through the ImmPtr paths -- encoded numeric JSValues and
unencoded doubles with common "safe" values.

  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::shouldBlindForSpecificArch):

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::shouldBlindDouble):
(MacroAssembler):
(JSC::MacroAssembler::shouldBlind):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::shouldBlindForSpecificArch):

13:49 Changeset [110199] by vestbo@webkit.org

[Qt] Prospective Windows build fix

Don't assume that windows-builds will always run inside a cmd.exe shell.

13:40 Changeset [110198] by commit-queue@webkit.org

Web Inspector: Creating a selector for class names with trailing spaces results with two dots instead of one
https://bugs.webkit.org/show_bug.cgi?id=80529

Trim the className before replacing the whitespaces with dot "."

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-03-08
Reviewed by Pavel Feldman.

No new tests.

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode.prototype.appropriateSelectorFor):

13:23 Changeset [110197] by commit-queue@webkit.org

Layout test for window.devicePixelRatio
https://bugs.webkit.org/show_bug.cgi?id=80292

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-03-08
Reviewed by Rob Buis.

  • fast/viewport/viewport-133-expected.txt: Added.
  • fast/viewport/viewport-133.html: Added.
13:20 Changeset [110196] by mitz@apple.com

<rdar://problem/10981173> Dashboard regions should not be in device space

Reviewed by John Sullivan.

Source/WebCore:

Test: TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::addDashboardRegions): Stop applying the device scale factor to
Dashboard regions.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::addDashboardRegions): Ditto.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm: Added.

(-[DeviceScaleFactorInDashboardRegionsUIDelegate webView:dashboardRegionsChanged:]):
(TestWebKitAPI):
(TestWebKitAPI::TEST):

13:03 Changeset [110195] by dpranke@chromium.org

webkit-patch works oddly on local Git branches
https://bugs.webkit.org/show_bug.cgi?id=76958

Reviewed by Ojan Vafai.

This change makes the '-g' flag to webkit-patch behave a
little more consistently with git. The 'HEAD..' syntax
is changed to 'HEAD....' (four dots), so as to not
collide with the underlying git syntax. We also generalize
the syntax to support any refname, so 'foo....' means
diff against foo and include working copy changes.

This change also adds the 'UPSTREAM' shortcut to identify
whatever the current upstream/tracking branch is; this is
useful if you have multiple local branches stacked up.

  • Scripts/webkitpy/common/checkout/scm/git.py:

(Git._branch_from_ref):
(Git):
(Git._current_branch):
(Git._upstream_branch):
(Git.merge_base):
(Git._commit_on_branch):

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:

(GitSVNTest._second_local_commit):
(GitSVNTest._two_local_commits):
(GitSVNTest.test_commit_with_message_git_commit_range):
(GitSVNTest.test_upstream_branch):
(GitSVNTest.test_create_patch_working_copy_only):
(GitSVNTest.test_changed_files_local_plus_working_copy):
(GitSVNTest.test_changed_files_working_copy_only):
(GitSVNTest.test_changed_files_upstream):

  • Scripts/webkitpy/tool/steps/options.py:

(Options):

12:49 Changeset [110194] by lforschler@apple.com

Merged r110193.

12:43 Changeset [110193] by mrowe@apple.com

<rdar://problem/11012572> Ensure that the staged frameworks path is in the search path for JavaScriptCore

Reviewed by Dan Bernstein.

  • Configurations/Base.xcconfig:
12:34 Changeset [110192] by commit-queue@webkit.org

Web Inspector: Cannot insert right curly bracket on some keyboards
https://bugs.webkit.org/show_bug.cgi?id=80474

Make sure other modifiers are not pressed

Patch by Cem Kocagil <cem.kocagil@gmail.com> on 2012-03-08
Reviewed by Pavel Feldman

  • inspector/front-end/inspector.js:

(WebInspector.documentKeyDown):

12:32 Changeset [110191] by commit-queue@webkit.org

Add a method to window.internals to enable testing of inspector highlight rects
https://bugs.webkit.org/show_bug.cgi?id=80338

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-03-08
Reviewed by Pavel Feldman.

.:

  • Source/autotools/symbols.filter: Export symbols for GTK.

Source/WebCore:

Add window.internals.inspectorHighlightRects, a method which makes it possible to test the
positions and sizes of inspector highlight rects.

Test: inspector/elements/highlight-node.html

  • WebCore.exp.in: Export symbols.
  • testing/Internals.cpp:

(WebCore::Internals::inspectorHighlightRects): Call InspectorController::getHighlight and
return the highlight's quads as a ClientRectList.
(WebCore):

  • testing/Internals.h:

(WebCore):
(Internals):

  • testing/Internals.idl:

Add inspectorHighlightRects to the window.internals interface.

Source/WebKit2:

  • win/WebKit2.def: Export symbols for win.
  • win/WebKit2CFLite.def: Same as above.

LayoutTests:

  • inspector/elements/highlight-node-expected.txt: Added.
  • inspector/elements/highlight-node.html: Added.
12:17 Changeset [110190] by antti@apple.com

https://bugs.webkit.org/show_bug.cgi?id=80370
Enable matched declaration caching for elements with a style attribute

Reviewed by Andreas Kling

  • Api/qwebelement.cpp:

(QWebElement::styleProperty):
(QWebElement::setStyleProperty):

12:16 Changeset [110189] by ojan@chromium.org

More Chromium Lion rebaselines.

12:15 Changeset [110188] by antti@apple.com

https://bugs.webkit.org/show_bug.cgi?id=80370
Enable matched declaration caching for elements with a style attribute

Reviewed by Andreas Kling

Make the property set for style attribute immutable as long as there is no CSSOM
wrapper for it. If the style attribute changes we create a new property set instead
of recycling the old one. This way the property sets can be made cacheable as long
as there is no CSSOM wrapper that would allow uncontrolled modifications. Constructing
the wrapper disables caching.

Made StyledElement::inlineStyle() and StyledElement::ensureInlineStyle() return a const
StylePropertySet so making accidental modifications difficult. Also dropped *Decl from
the names.

Fixed two unrelated bugs that this exposed.

  • css/CSSStyleSelector.cpp:


Don't allow caching of document element style if writingModeSetOnDocumentElement() bit is set.
Tested by fast/multicol/vertical-rl/break-properties.html.


(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • css/StylePropertySet.h:

(StylePropertySet):
(WebCore::StylePropertySet::hasCSSOMWrapper):

  • dom/Element.cpp:

(WebCore::Element::recalcStyle):

Invalidate the matched properties cache if the document has rem units and the root font changes.
Tested by fast/css/rem-dynamic-scaling.html.


  • dom/ElementAttributeData.cpp:

(WebCore):
(WebCore::ElementAttributeData::ensureInlineStyle):
(WebCore::ElementAttributeData::ensureMutableInlineStyle):
(WebCore::ElementAttributeData::updateInlineStyleAvoidingMutation):
(WebCore::ElementAttributeData::destroyInlineStyle):

  • dom/ElementAttributeData.h:

(WebCore::ElementAttributeData::inlineStyle):
(ElementAttributeData):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::updateStyleAttribute):
(WebCore::StyledElement::~StyledElement):
(WebCore):
(WebCore::StyledElement::style):
(WebCore::StyledElement::parseAttribute):
(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::removeInlineStyleProperty):
(WebCore::StyledElement::addSubresourceAttributeURLs):

  • dom/StyledElement.h:

(WebCore::StyledElement::inlineStyle):
(WebCore::StyledElement::ensureInlineStyle):
(StyledElement):
(WebCore::StyledElement::destroyInlineStyle):

  • editing/ApplyStyleCommand.cpp:

(WebCore::hasNoAttributeOrOnlyStyleAttribute):
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
(WebCore::ApplyStyleCommand::removeCSSStyle):
(WebCore::ApplyStyleCommand::applyInlineStyleToPushDown):
(WebCore::ApplyStyleCommand::addBlockStyle):
(WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):

  • editing/EditingStyle.cpp:

(WebCore::HTMLElementEquivalent::propertyExistsInStyle):
(HTMLTextDecorationEquivalent):
(WebCore::HTMLTextDecorationEquivalent::propertyExistsInStyle):
(WebCore::EditingStyle::conflictsWithInlineStyleOfElement):
(WebCore::EditingStyle::elementIsStyledSpanOrHTMLEquivalent):
(WebCore::EditingStyle::mergeInlineStyleOfElement):
(WebCore::elementMatchesAndPropertyIsNotInInlineStyleDecl):
(WebCore::EditingStyle::mergeStyle):

  • editing/EditingStyle.h:

(EditingStyle):

  • editing/RemoveCSSPropertyCommand.cpp:

(WebCore::RemoveCSSPropertyCommand::doApply):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
(WebCore::ReplaceSelectionCommand::handleStyleSpans):

  • editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::appendElement):
(WebCore::styleFromMatchedRulesAndInlineDecl):

  • html/HTMLElement.cpp:

(WebCore::StyledElement::copyNonAttributeProperties):

  • html/canvas/CanvasStyle.cpp:

(WebCore::currentColor):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeFrame):
(WebCore::PageSerializer::retrieveResourcesForProperties):

  • page/PageSerializer.h:

(PageSerializer):

  • rendering/RenderTreeAsText.cpp:

(WebCore::isEmptyOrUnstyledAppleStyleSpan):

12:06 Changeset [110187] by senorblanco@chromium.org

[chromium] Unreviewed gardening.

Fallout from r110179.

  • platform/chromium-mac-snowleopard/fast/forms/search-rtl-expected.txt: Removed.
11:59 Changeset [110186] by commit-queue@webkit.org

[BlackBerry] Block file-to-file access by default
https://bugs.webkit.org/show_bug.cgi?id=80605

Patch by Yong Li <yoli@rim.com> on 2012-03-08
Reviewed by Rob Buis.

Turn off allowFileAccessFromFileURLs() by default.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

11:44 Common pixel differences between ports edited by ojan@chromium.org
(diff)
11:37 Changeset [110185] by commit-queue@webkit.org

Have ScrollAnimatorNone use requestAnimationFrame
https://bugs.webkit.org/show_bug.cgi?id=78938

Patch by Scott Byer <scottbyer@chromium.org> on 2012-03-08
Reviewed by James Robinson.

Source/WebCore:

No new tests. Passes Chromium webkit_unit_tests.

  • page/FrameView.cpp:

(WebCore::FrameView::serviceScriptedAnimations):

  • platform/ScrollAnimator.h:

(WebCore::ScrollAnimator::serviceScrollAnimations):

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::scroll):
(WebCore::ScrollAnimatorNone::cancelAnimations):
(WebCore):
(WebCore::ScrollAnimatorNone::serviceScrollAnimations):
(WebCore::ScrollAnimatorNone::animationTimerFired):
(WebCore::ScrollAnimatorNone::startNextTimer):
(WebCore::ScrollAnimatorNone::animationTimerActive):
(WebCore::ScrollAnimatorNone::stopAnimationTimerIfNeeded):

  • platform/ScrollAnimatorNone.h:

(ScrollAnimatorNone):

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::serviceScrollAnimations):
(WebCore):

  • platform/ScrollableArea.h:

(WebCore):
(ScrollableArea):

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::hostWindow):
(RenderLayer):

  • rendering/RenderListBox.h:

(WebCore::RenderListBox::hostWindow):
(RenderListBox):

Source/WebKit/chromium:

  • src/ScrollbarGroup.h:

(WebCore):
(WebKit::ScrollbarGroup::hostWindow):
(ScrollbarGroup):

  • tests/ScrollAnimatorNoneTest.cpp:

(MockScrollableArea::hostWindow):

11:33 Changeset [110184] by lforschler@apple.com

Merged r109992.

11:33 Common pixel differences between ports edited by ojan@chromium.org
(diff)
11:31 Changeset [110183] by lforschler@apple.com

Merge 109986.

11:27 Changeset [110182] by lforschler@apple.com

Versioning.

11:25 Changeset [110181] by lforschler@apple.com

New Tag.

11:18 Changeset [110180] by mitz@apple.com

REGRESSION (r109964): Assertion failure (!isUndefined()) in Length::getIntValue() when a Dashboard region is specified without offsets
https://bugs.webkit.org/show_bug.cgi?id=80614

Reviewed by Beth Dakin.

Source/WebCore:

Test: fast/css/dashboard-regions-undefined-length-assertion.html

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList): Reverted to setting zero lengths,
rather than Undefined ones, in the RenderStyle when offsets are not given.

LayoutTests:

  • fast/css/dashboard-regions-undefined-length-assertion-expected.txt: Added.
  • fast/css/dashboard-regions-undefined-length-assertion.html: Added.
11:18 Changeset [110179] by senorblanco@chromium.org

[chromium] Unreviewed gardening.

Rebaseline all TEXT results affected by r110072.

  • fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Removed.
  • fast/block/float/float-overflow-hidden-containing-block-width-expected.txt: Added.
  • fast/block/float/in-margin-expected.txt: Added.
  • fast/clip/017-expected.txt: Added.
  • fast/dynamic/subtree-boundary-percent-height-expected.txt: Added.
  • fast/dynamic/subtree-no-common-root-static-y-expected.txt: Added.
  • fast/dynamic/subtree-table-cell-height-expected.txt: Added.
  • platform/chromium-linux-x86/compositing/overflow: Removed.
  • platform/chromium-linux-x86/fast/layers: Added.
  • platform/chromium-linux-x86/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
  • platform/chromium-linux-x86/fast/layers/self-painting-outline-expected.txt: Added.
  • platform/chromium-linux-x86/fast/overflow: Removed.
  • platform/chromium-linux-x86/fast/repaint/overflow-clip-subtree-layout-expected.txt: Added.
  • platform/chromium-linux-x86/fast/repaint/subtree-root-clip-2-expected.txt: Added.
  • platform/chromium-linux-x86/fast/repaint/subtree-root-clip-3-expected.txt: Added.
  • platform/chromium-linux-x86/fast/repaint/subtree-root-clip-expected.txt: Added.
  • platform/chromium-linux-x86/fast/replaced: Removed.
  • platform/chromium-linux-x86/fast/text: Added.
  • platform/chromium-linux-x86/fast/text/selection-painted-separately-expected.txt: Added.
  • platform/chromium-linux-x86/tables/mozilla/bugs: Removed.
  • platform/chromium-linux/editing/selection/3690703-2-expected.txt:
  • platform/chromium-linux/editing/selection/3690703-expected.txt:
  • platform/chromium-linux/editing/selection/3690719-expected.txt:
  • platform/chromium-linux/fast/block/margin-collapse/103-expected.txt:
  • platform/chromium-linux/fast/css/input-search-padding-expected.txt:
  • platform/chromium-linux/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-linux/fast/forms/form-element-geometry-expected.txt:
  • platform/chromium-linux/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-linux/fast/forms/input-baseline-expected.txt:
  • platform/chromium-linux/fast/forms/input-text-double-click-expected.txt:
  • platform/chromium-linux/fast/forms/input-value-expected.txt:
  • platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/chromium-linux/fast/forms/search-styled-expected.txt:
  • platform/chromium-linux/fast/forms/searchfield-heights-expected.txt:
  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-linux/fast/invalid/residual-style-expected.txt:
  • platform/chromium-linux/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
  • platform/chromium-linux/fast/layers/self-painting-outline-expected.txt: Added.
  • platform/chromium-linux/fast/repaint/overflow-clip-subtree-layout-expected.txt: Added.
  • platform/chromium-linux/fast/repaint/subtree-root-clip-2-expected.txt: Added.
  • platform/chromium-linux/fast/repaint/subtree-root-clip-3-expected.txt: Added.
  • platform/chromium-linux/fast/repaint/subtree-root-clip-expected.txt: Added.
  • platform/chromium-linux/fast/replaced/replaced-breaking-expected.txt:
  • platform/chromium-linux/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-linux/fast/text/selection-painted-separately-expected.txt: Added.
  • platform/chromium-linux/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/chromium-linux/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug44505-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/chromium-linux/tables/mozilla/dom/tableDom-expected.txt:
  • platform/chromium-linux/tables/mozilla/other/move_row-expected.txt:
  • platform/chromium-mac-leopard/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/layers/self-painting-outline-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/repaint/overflow-clip-subtree-layout-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/repaint/subtree-root-clip-2-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/repaint/subtree-root-clip-3-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/repaint/subtree-root-clip-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/text/selection-painted-separately-expected.txt: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/before-after-input-element-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/pasteboard/4806874-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/pasteboard/input-field-1-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/3690703-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/3690719-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/4895428-3-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/4975120-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/drag-select-1-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/expanding-selections-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/leave-requested-block-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-1-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-2-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-3-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-4-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-5-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/editing/spelling/inline_spelling_markers-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/block/float/032-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/block/float/033-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/block/float/shrink-to-avoid-float-complexity-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/block/lineboxcontain/block-font-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/block/lineboxcontain/block-glyphs-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/block/lineboxcontain/font-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/block/lineboxcontain/glyphs-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/block/lineboxcontain/parsing-invalid-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/block/margin-collapse/103-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/css/text-input-with-webkit-border-radius-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/text-overflow-input-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/basic-inputs-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/encoding-test-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/fieldset-align-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/floating-textfield-relayout-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-align-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-default-bkcolor-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-disabled-expected.txt:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-focus-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-readonly-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-visibility-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-width-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-baseline-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-double-click-selection-gap-bug-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-field-text-truncated-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-empty-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-spaces-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-table-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-click-inside-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-click-outside-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-option-delete-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-self-emptying-click-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-width-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-position-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/chromium-mac-snowleopard/fast/forms/plaintext-mode-2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/search-cancel-button-style-sharing-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/search-display-none-cancel-button-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/search-rtl-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/search-styled-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/search-vertical-alignment-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/searchfield-heights-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/tabbing-input-iframe-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/text-style-color-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/textfield-focus-ring-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-mac-snowleopard/fast/forms/visual-hebrew-text-field-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/frames/take-focus-from-iframe-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/html/details-no-summary4-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/html/details-open-javascript-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/html/details-open2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/html/details-open4-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/invalid: Added.
  • platform/chromium-mac-snowleopard/fast/invalid/residual-style-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/layers/remove-layer-with-nested-stacking-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/layers/self-painting-outline-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/lists/dynamic-marker-crash-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/layers-split-across-columns-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/overflow/004-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/overflow/clip-rects-fixed-ancestor-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/overflow/line-clamp-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/overflow/overflow-focus-ring-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/inline-relative-positioned-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/layer-outline-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/layer-outline-horizontal-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/lines-with-layout-delta-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/opacity-change-on-overflow-float-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/overflow-clip-subtree-layout-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/overflow-delete-line-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/repaint-resized-overflow-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/subtree-layoutstate-transform-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-3-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/subtree-root-skipped-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-mixture-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-searchfield-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-textfield-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/table/003-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/table/029-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/table/colspanMinWidth-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/table/colspanMinWidth-vertical-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/table/overflowHidden-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/table/spanOverlapRepaint-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/table/text-field-baseline-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/selection-painted-separately-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/selection-rect-rounding-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/transforms/transformed-focused-text-input-expected.txt: Added.
  • platform/chromium-mac-snowleopard/plugins/mouse-click-plugin-clears-selection-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/mixed/003-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/45621-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug12384-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug154780-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug24200-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-4-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4382-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug44505-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-1-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51037-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug55545-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug99948-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/dom/tableDom-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/other/move_row-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug45621-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt: Added.
  • platform/chromium-mac/compositing/overflow/ancestor-overflow-expected.txt: Added.
  • platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.txt: Added.
  • platform/chromium-mac/fast/block/float/033-expected.txt: Removed.
  • platform/chromium-mac/fast/clip/008-expected.txt: Added.
  • platform/chromium-mac/fast/clip/011-expected.txt: Added.
  • platform/chromium-mac/fast/clip/012-expected.txt: Added.
  • platform/chromium-mac/fast/css/input-search-padding-expected.txt: Added.
  • platform/chromium-mac/fast/css/invalidation-errors-2-expected.txt: Added.
  • platform/chromium-mac/fast/css/invalidation-errors-expected.txt: Added.
  • platform/chromium-mac/fast/css/line-height-expected.txt: Added.
  • platform/chromium-mac/fast/css/nested-layers-with-hover-expected.txt: Added.
  • platform/chromium-mac/fast/dom/isindex-001-expected.txt: Added.
  • platform/chromium-mac/fast/dom/isindex-002-expected.txt: Added.
  • platform/chromium-mac/fast/events/context-no-deselect-expected.txt: Added.
  • platform/chromium-mac/fast/forms/basic-inputs-expected.txt: Added.
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-mac/fast/forms/number/input-appearance-number-rtl-expected.txt: Added.
  • platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Added.
  • platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Added.
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.txt: Added.
  • platform/chromium-win-vista/compositing/overflow: Removed.
  • platform/chromium-win-vista/fast/layers: Added.
  • platform/chromium-win-vista/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
  • platform/chromium-win-vista/fast/layers/self-painting-outline-expected.txt: Added.
  • platform/chromium-win-vista/fast/multicol: Removed.
  • platform/chromium-win-vista/fast/repaint: Added.
  • platform/chromium-win-vista/fast/repaint/overflow-clip-subtree-layout-expected.txt: Added.
  • platform/chromium-win-vista/fast/repaint/subtree-root-clip-2-expected.txt: Added.
  • platform/chromium-win-vista/fast/repaint/subtree-root-clip-3-expected.txt: Added.
  • platform/chromium-win-vista/fast/repaint/subtree-root-clip-expected.txt: Added.
  • platform/chromium-win-vista/fast/text/selection-painted-separately-expected.txt: Added.
  • platform/chromium-win-vista/http/tests/navigation: Removed.
  • platform/chromium-win-vista/tables/mozilla/bugs: Added.
  • platform/chromium-win-xp/compositing/overflow: Removed.
  • platform/chromium-win-xp/fast/forms/search-styled-expected.txt:
  • platform/chromium-win-xp/fast/layers: Added.
  • platform/chromium-win-xp/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
  • platform/chromium-win-xp/fast/layers/self-painting-outline-expected.txt: Added.
  • platform/chromium-win-xp/fast/repaint/overflow-clip-subtree-layout-expected.txt: Added.
  • platform/chromium-win-xp/fast/repaint/subtree-root-clip-2-expected.txt: Added.
  • platform/chromium-win-xp/fast/repaint/subtree-root-clip-3-expected.txt: Added.
  • platform/chromium-win-xp/fast/repaint/subtree-root-clip-expected.txt: Added.
  • platform/chromium-win-xp/fast/replaced: Removed.
  • platform/chromium-win-xp/fast/text/selection-painted-separately-expected.txt: Added.
  • platform/chromium-win/compositing/overflow/ancestor-overflow-expected.txt:
  • platform/chromium-win/editing/inserting/before-after-input-element-expected.txt:
  • platform/chromium-win/editing/pasteboard/4806874-expected.txt:
  • platform/chromium-win/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/chromium-win/editing/pasteboard/input-field-1-expected.txt:
  • platform/chromium-win/editing/selection/3690703-2-expected.txt:
  • platform/chromium-win/editing/selection/3690703-expected.txt:
  • platform/chromium-win/editing/selection/3690719-expected.txt:
  • platform/chromium-win/editing/selection/4895428-3-expected.txt:
  • platform/chromium-win/editing/selection/4975120-expected.txt:
  • platform/chromium-win/editing/selection/drag-select-1-expected.txt:
  • platform/chromium-win/editing/selection/expanding-selections-expected.txt:
  • platform/chromium-win/editing/selection/leave-requested-block-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-2-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-3-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/chromium-win/editing/spelling/inline_spelling_markers-expected.txt:
  • platform/chromium-win/fast/block/float/032-expected.txt:
  • platform/chromium-win/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt:
  • platform/chromium-win/fast/block/float/shrink-to-avoid-float-complexity-expected.txt:
  • platform/chromium-win/fast/block/lineboxcontain/block-font-expected.txt:
  • platform/chromium-win/fast/block/lineboxcontain/block-glyphs-expected.txt:
  • platform/chromium-win/fast/block/lineboxcontain/font-expected.txt:
  • platform/chromium-win/fast/block/lineboxcontain/parsing-invalid-expected.txt:
  • platform/chromium-win/fast/block/margin-collapse/103-expected.txt:
  • platform/chromium-win/fast/css/input-search-padding-expected.txt:
  • platform/chromium-win/fast/css/invalidation-errors-2-expected.txt:
  • platform/chromium-win/fast/css/invalidation-errors-expected.txt:
  • platform/chromium-win/fast/css/line-height-expected.txt:
  • platform/chromium-win/fast/css/nested-layers-with-hover-expected.txt:
  • platform/chromium-win/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/chromium-win/fast/css/text-overflow-input-expected.txt:
  • platform/chromium-win/fast/dom/isindex-001-expected.txt:
  • platform/chromium-win/fast/dom/isindex-002-expected.txt:
  • platform/chromium-win/fast/events/autoscroll-expected.txt:
  • platform/chromium-win/fast/events/context-no-deselect-expected.txt:
  • platform/chromium-win/fast/forms/basic-inputs-expected.txt:
  • platform/chromium-win/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-win/fast/forms/encoding-test-expected.txt:
  • platform/chromium-win/fast/forms/fieldset-align-expected.txt:
  • platform/chromium-win/fast/forms/floating-textfield-relayout-expected.txt:
  • platform/chromium-win/fast/forms/form-element-geometry-expected.txt:
  • platform/chromium-win/fast/forms/input-align-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-bkcolor-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-default-bkcolor-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-disabled-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-focus-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-readonly-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-selection-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-visibility-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-width-expected.txt:
  • platform/chromium-win/fast/forms/input-baseline-expected.txt:
  • platform/chromium-win/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/chromium-win/fast/forms/input-field-text-truncated-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/chromium-win/fast/forms/input-readonly-empty-expected.txt:
  • platform/chromium-win/fast/forms/input-spaces-expected.txt:
  • platform/chromium-win/fast/forms/input-table-expected.txt:
  • platform/chromium-win/fast/forms/input-text-click-inside-expected.txt:
  • platform/chromium-win/fast/forms/input-text-click-outside-expected.txt:
  • platform/chromium-win/fast/forms/input-text-option-delete-expected.txt:
  • platform/chromium-win/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/chromium-win/fast/forms/input-value-expected.txt:
  • platform/chromium-win/fast/forms/input-width-expected.txt:
  • platform/chromium-win/fast/forms/number/input-appearance-number-rtl-expected.txt:
  • platform/chromium-win/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/chromium-win/fast/forms/number/input-appearance-spinbutton-layer-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-position-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/chromium-win/fast/forms/plaintext-mode-2-expected.txt:
  • platform/chromium-win/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/chromium-win/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/chromium-win/fast/forms/search-rtl-expected.txt:
  • platform/chromium-win/fast/forms/search-styled-expected.txt:
  • platform/chromium-win/fast/forms/search-vertical-alignment-expected.txt:
  • platform/chromium-win/fast/forms/searchfield-heights-expected.txt:
  • platform/chromium-win/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/chromium-win/fast/forms/text-style-color-expected.txt:
  • platform/chromium-win/fast/forms/textfield-focus-ring-expected.txt:
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-win/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/chromium-win/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/chromium-win/fast/html/details-no-summary4-expected.txt:
  • platform/chromium-win/fast/html/details-open-javascript-expected.txt:
  • platform/chromium-win/fast/html/details-open2-expected.txt:
  • platform/chromium-win/fast/html/details-open4-expected.txt:
  • platform/chromium-win/fast/invalid/residual-style-expected.txt:
  • platform/chromium-win/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
  • platform/chromium-win/fast/layers/remove-layer-with-nested-stacking-expected.txt:
  • platform/chromium-win/fast/layers/self-painting-outline-expected.txt: Added.
  • platform/chromium-win/fast/lists/dynamic-marker-crash-expected.txt:
  • platform/chromium-win/fast/multicol/layers-split-across-columns-expected.txt:
  • platform/chromium-win/fast/overflow/004-expected.txt:
  • platform/chromium-win/fast/overflow/clip-rects-fixed-ancestor-expected.txt:
  • platform/chromium-win/fast/overflow/line-clamp-expected.txt:
  • platform/chromium-win/fast/overflow/overflow-focus-ring-expected.txt:
  • platform/chromium-win/fast/repaint/inline-relative-positioned-expected.txt:
  • platform/chromium-win/fast/repaint/layer-outline-expected.txt:
  • platform/chromium-win/fast/repaint/layer-outline-horizontal-expected.txt:
  • platform/chromium-win/fast/repaint/lines-with-layout-delta-expected.txt:
  • platform/chromium-win/fast/repaint/opacity-change-on-overflow-float-expected.txt:
  • platform/chromium-win/fast/repaint/overflow-clip-subtree-layout-expected.txt: Added.
  • platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/chromium-win/fast/repaint/repaint-resized-overflow-expected.txt:
  • platform/chromium-win/fast/repaint/subtree-layoutstate-transform-expected.txt:
  • platform/chromium-win/fast/repaint/subtree-root-clip-2-expected.txt: Added.
  • platform/chromium-win/fast/repaint/subtree-root-clip-3-expected.txt: Added.
  • platform/chromium-win/fast/repaint/subtree-root-clip-expected.txt: Added.
  • platform/chromium-win/fast/repaint/subtree-root-skipped-expected.txt:
  • platform/chromium-win/fast/replaced/replaced-breaking-expected.txt:
  • platform/chromium-win/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/chromium-win/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/chromium-win/fast/replaced/width100percent-textfield-expected.txt:
  • platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-win/fast/speech/speech-bidi-rendering-expected.txt:
  • platform/chromium-win/fast/table/003-expected.txt:
  • platform/chromium-win/fast/table/029-expected.txt:
  • platform/chromium-win/fast/table/colspanMinWidth-expected.txt:
  • platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/chromium-win/fast/table/overflowHidden-expected.txt:
  • platform/chromium-win/fast/table/spanOverlapRepaint-expected.txt:
  • platform/chromium-win/fast/table/text-field-baseline-expected.txt:
  • platform/chromium-win/fast/text/selection-painted-separately-expected.txt: Added.
  • platform/chromium-win/fast/text/selection-rect-rounding-expected.txt:
  • platform/chromium-win/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/chromium-win/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/chromium-win/plugins/mouse-click-plugin-clears-selection-expected.txt:
  • platform/chromium-win/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/chromium-win/svg/hixie/mixed/003-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/45621-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug12384-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug154780-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug24200-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug44505-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug55545-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug99948-expected.txt:
  • platform/chromium-win/tables/mozilla/dom/tableDom-expected.txt:
  • platform/chromium-win/tables/mozilla/other/move_row-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug45621-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
  • platform/chromium/fast/block/float/033-expected.txt: Added.
  • platform/chromium/fast/block/float/avoidance-rtl-expected.txt: Added.
  • platform/chromium/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Added.
  • platform/chromium/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt: Added.
  • platform/chromium/fast/block/float/in-margin-expected.txt: Added.
  • platform/chromium/fast/clip: Added.
  • platform/chromium/fast/clip/017-expected.txt: Added.
  • platform/chromium/fast/dynamic: Added.
  • platform/chromium/fast/dynamic/subtree-boundary-percent-height-expected.txt: Added.
  • platform/chromium/fast/dynamic/subtree-no-common-root-static-y-expected.txt: Added.
  • platform/chromium/fast/dynamic/subtree-table-cell-height-expected.txt: Added.
  • platform/chromium/fast/invalid/residual-style-expected.txt: Removed.
  • platform/chromium/fast/speech: Removed.
  • platform/chromium/fast/speech/input-appearance-searchandspeech-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
11:15 Changeset [110178] by commit-queue@webkit.org

WebKitGtk+ fails to build on win32 against GTK3
https://bugs.webkit.org/show_bug.cgi?id=63919

Patch by Mikkel Kruse Johnsen <mikkel@linet.dk> on 2012-03-08
Reviewed by Gustavo Noronha Silva.

  • plugins/gtk/PluginViewGtk.cpp: Don't use gtk_socket_new with GTK3 on Win32

(WebCore::PluginView::platformStart):

11:13 Changeset [110177] by sfalken@apple.com

Fix line endings for copy-files.cmd.

If a cmd file doesn't have Windows line endings, it doesn't work properly.
In this case, the label :clean wasn't found, breaking the clean build.

Reviewed by Jessie Berlin.

11:01 Changeset [110176] by commit-queue@webkit.org

[BlackBerry]New feature: support about:cookie for internal build.
https://bugs.webkit.org/show_bug.cgi?id=80367

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-03-08
Reviewed by Antonio Gomes.

No new tests.

  • platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::generateHtmlFragmentForCookies):
(WebCore):

  • platform/blackberry/CookieManager.h:
  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::handleAbout):

10:21 Changeset [110175] by commit-queue@webkit.org

[BlackBerry] Always use the current focused node when processing focus changes
https://bugs.webkit.org/show_bug.cgi?id=80594

Patch by Mike Fenton <mifenton@rim.com> on 2012-03-08
Reviewed by Antonio Gomes.

Update InputHandler focused node handling to strictly use
the currently focused node. This prevents a handling loop
when JS is modifying the focus and we get a late notification
of a past change from ChromeClientBlackBerry with the previously
unfocused node.

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::focusedNodeChanged):

  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):
(WebCore::EditorClientBlackBerry::setInputMethodState):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::focusedNodeChanged):

  • WebKitSupport/InputHandler.h:
10:09 Changeset [110174] by jberlin@webkit.org

More Windows build fixing.

  • gtest/msvc/gtest-md.vcproj:
09:48 Changeset [110173] by sullivan@apple.com

Made extract-localizable-strings ignore NSLocalizedFileSizeDescription

Reviewed by Eric Carlson.

  • Scripts/extract-localizable-strings:

Added NSLocalizedFileSizeDescription to allowed list of tokens that start
with NSLocalized. Also improved an error message to include the troublesome token.

09:42 Changeset [110172] by caio.oliveira@openbossa.org

Make elements with attributes smaller by eliminating the m_element back pointer in NamedNodeMap
https://bugs.webkit.org/show_bug.cgi?id=75069

Reviewed by Ryosuke Niwa.

Source/WebCore:

NamedNodeMap is an exposed DOM representation of an element's attribute storage. As part of
its implementation it keeps a pointer to its associated Element plus all the attribute
storage.

This commit separate the two things: NamedNodeMap is now a wrapper to Element, containing
only the pointer, and the attribute storage is now owned by Element directly. Since usage
of NamedNodeMap is not very common, it can be stored in ElementRareData. As a result, most
elements with attributes now don't need to allocate memory for that extra pointer in
NamedNodeMap.

One consequence of this implementation is that now we explicitly don't support
DocumentType.notations and DocumentType.entities. They weren't supported before, a
NamedNodeMap was never created for those attributes -- and some NamedNodeMap functions
wouldn't work correctly without an associated Element.

NamedNodeMap itself was cleaned up, as well as unnecessary references to it removed in the
code and comments.

No new tests and should not change results for existing tests.

  • dom/Attribute.h:

(WebCore):

  • dom/DocumentType.h:

(DocumentType): Point out that we don't support does attributes yet.

  • dom/Element.cpp:

(WebCore::Element::~Element): Detaching the NamedNodeMap is no longer necessary because it
will be destroyed. We still detach the potential Attrs inside our Attributes by using
clearAttributes().
(WebCore::Element::attributes): Looks in ElementRareData now. Note we ensure the creation
of the attribute storage.
(WebCore):
(WebCore::Element::getAttribute):
(WebCore::Element::setAttributeInternal):
(WebCore::Element::parserSetAttributes):
(WebCore::Element::hasAttributes):
(WebCore::Element::createAttributeData):
(WebCore::Element::insertedIntoDocument):
(WebCore::Element::removedFromDocument):
(WebCore::Element::getURLAttribute):
(WebCore::Element::getNonEmptyURLAttribute):
(WebCore::Element::hasNamedNodeMap): Helper function for Node::dumpStatistics().

  • dom/Element.h:

(Element):
(WebCore::Element::attributeData):
(WebCore::Element::ensureAttributeData):
(WebCore::Element::fastHasAttribute):
(WebCore::Element::fastGetAttribute):
(WebCore::Element::hasAttributesWithoutUpdate):
(WebCore::Element::idForStyleResolution):
(WebCore::Element::attributeCount):
(WebCore::Element::attributeItem):
(WebCore::Element::getAttributeItem):

  • dom/ElementAttributeData.h:

(WebCore::ElementAttributeData::create):
(ElementAttributeData):

  • dom/ElementRareData.h:

(ElementRareData):

  • dom/NamedNodeMap.cpp: Rewriting now that m_attributeData is not a member, using m_element

methods when possible.
(WebCore::NamedNodeMap::ref):
(WebCore::NamedNodeMap::deref):
(WebCore::NamedNodeMap::getNamedItem):
(WebCore::NamedNodeMap::getNamedItemNS):
(WebCore::NamedNodeMap::removeNamedItem):
(WebCore::NamedNodeMap::removeNamedItemNS):
(WebCore::NamedNodeMap::setNamedItem):
(WebCore::NamedNodeMap::item):
(WebCore::NamedNodeMap::length):

  • dom/NamedNodeMap.h:

(WebCore):
(WebCore::NamedNodeMap::create):
(NamedNodeMap):
(WebCore::NamedNodeMap::NamedNodeMap): Instead of asserting m_element in every function, we
now assert only in the constructor.

  • dom/Node.cpp:

(WebCore::Node::dumpStatistics): Add a counter for elements with rare data, this allows us
compare more clearly the impact of moving NamedNodeMap there.
(WebCore::Node::isEqualNode): Remove use of mapsEquivalent(). It was dead code, because
both entities and notations were always NULL.
(WebCore::Node::compareDocumentPosition):

  • inspector/DOMPatchSupport.h:

(WebCore):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::attributeChanged):

Source/WebKit/chromium:

  • src/WebElement.cpp: Include NamedNodeMap.h since Element.h doesn't include it anymore.
09:03 Moving to Git edited by rniwa@webkit.org
(diff)
08:53 Changeset [110171] by commit-queue@webkit.org

[BlackBerry] Upstream WebGL related files from platform/graphics
https://bugs.webkit.org/show_bug.cgi?id=79876

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-03-08
Reviewed by Rob Buis.

Initial upstream, no new tests.

  • platform/graphics/blackberry/DrawingBufferBlackBerry.cpp: Added.

(WebCore):
(DrawingBufferInternal):
(WebCore::generateColorTexture):
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::~DrawingBuffer):
(WebCore::DrawingBuffer::publishToPlatformLayer):
(WebCore::DrawingBuffer::reset):
(WebCore::DrawingBuffer::platformLayer):

  • platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp: Added.

(WebCore):
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::paintsIntoCanvasBuffer):
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::isGLES2Compliant):
(WebCore::GraphicsContext3D::isGLES2NPOTStrict):
(WebCore::GraphicsContext3D::isErrorGeneratedOnOutOfBoundsAccesses):
(WebCore::GraphicsContext3D::platformTexture):
(WebCore::GraphicsContext3D::platformLayer):
(WebCore::GraphicsContext3D::paintToCanvas):
(WebCore::GraphicsContext3D::setContextLostCallback):

  • platform/graphics/blackberry/WebGLLayerWebKitThread.cpp: Added.

(WebCore):
(WebCore::WebGLLayerWebKitThread::WebGLLayerWebKitThread):
(WebCore::WebGLLayerWebKitThread::~WebGLLayerWebKitThread):
(WebCore::WebGLLayerWebKitThread::setNeedsDisplay):
(WebCore::WebGLLayerWebKitThread::updateTextureContentsIfNeeded):

  • platform/graphics/blackberry/WebGLLayerWebKitThread.h: Added.

(WebCore):
(WebGLLayerWebKitThread):
(WebCore::WebGLLayerWebKitThread::create):
(WebCore::WebGLLayerWebKitThread::setWebGLContext):

08:43 WebKitGTK/1.8.x edited by plaes@plaes.org
Dropping the invalid changeset (diff)
08:42 Changeset [110170] by commit-queue@webkit.org

[BlackBerry] LayerRender should turn off stencil/scissor after drawing layers
https://bugs.webkit.org/show_bug.cgi?id=80598

Patch by Yong Li <yoli@rim.com> on 2012-03-08
Reviewed by Rob Buis.

Turn off stencil/scissor after using them to avoid affecting later GL operation
accidentally.

  • platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::drawLayers):

08:05 Changeset [110169] by commit-queue@webkit.org

[Qt WK2] Remove duplicate code related to dialog handling in QQuickWebView
https://bugs.webkit.org/show_bug.cgi?id=80557

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-03-08
Reviewed by Simon Hausmann.

Move common code related to running QtDialogRunner into a separate function

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::runJavaScriptAlert):
(QQuickWebViewPrivate::runJavaScriptConfirm):
(QQuickWebViewPrivate::runJavaScriptPrompt):
(QQuickWebViewPrivate::handleAuthenticationRequiredRequest):
(QQuickWebViewPrivate::handleProxyAuthenticationRequiredRequest):
(QQuickWebViewPrivate::handleCertificateVerificationRequest):
(QQuickWebViewPrivate::execDialogRunner):

  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

07:50 Changeset [110168] by commit-queue@webkit.org

Fix flaky test by decreasing granularity of cues (cues cover longer time
intervals). The flakiness seems to appear because the video is paused
synchronously, while missed events events are dispatched asynchronously.

It can happen that multiple cues are actually missed cues, hence more exit
events are dispatched together, but the video was paused before the actual
dispatch.

https://bugs.webkit.org/show_bug.cgi?id=80067

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-03-08
Reviewed by Eric Carlson.

  • media/track/captions-webvtt/simple-captions.vtt:
  • media/track/track-cues-pause-on-exit-expected.txt:
  • media/track/track-cues-pause-on-exit.html:
07:28 Changeset [110167] by ossy@webkit.org

[Qt] Rebaseline after r110072.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-03-08
Reviewed by Csaba Osztrogonác.

  • platform/qt/css3/selectors3/html/css3-modsel-23-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-23-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-24-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-24-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-68-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-68-expected.txt:
  • platform/qt/css3/selectors3/html/css3-modsel-69-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-69-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-23-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-23-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-24-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-68-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-69-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-69-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-23-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-23-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-24-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-24-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-68-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-68-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-69-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-69-expected.txt:
  • platform/qt/fast/clip/008-expected.png:
  • platform/qt/fast/clip/008-expected.txt:
  • platform/qt/fast/clip/011-expected.png:
  • platform/qt/fast/clip/011-expected.txt:
  • platform/qt/fast/clip/012-expected.png:
  • platform/qt/fast/clip/012-expected.txt:
  • platform/qt/fast/forms/input-text-double-click-expected.txt:
  • platform/qt/fast/forms/textfield-overflow-expected.txt:
  • platform/qt/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/qt/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/qt/test_expectations.txt:
07:08 Changeset [110166] by hausmann@webkit.org

[Qt] Windows build fix.

Reviewed by Tor Arne Vestbø.

  • DerivedSources.pri: Replace commandline that is too long for Windows with

separate lines to be executed in the Makefile for the IDL preprocessing.

06:09 Changeset [110165] by senorblanco@chromium.org

[chromium] Unreviewed gardening.

Mark compositing/reflections/nested-reflection-opacity.html as flaky.

  • platform/chromium/test_expectations.txt:
06:06 Changeset [110164] by loislo@chromium.org

Web Inspector: The function had to return a hash but it returned just address.
https://bugs.webkit.org/show_bug.cgi?id=80591

Reviewed by Yury Semikhatsky.

  • bindings/v8/RetainedDOMInfo.cpp:

(WebCore::RetainedDOMInfo::GetHash):

05:24 Changeset [110163] by loislo@chromium.org

Unreviewed single line fix. The function had to return a hash but it returned just address.

  • bindings/v8/V8GCController.cpp:

(WebCore::UnspecifiedGroup::GetHash):

04:41 Changeset [110162] by senorblanco@chromium.org

[chromium] Unreviewed gardening.

Mark some tests failing on Leopard after the Lion rebaselines.

  • platform/chromium/test_expectations.txt:
03:25 Changeset [110161] by shinyak@chromium.org

<shadow> should be rendered correctly.
https://bugs.webkit.org/show_bug.cgi?id=78596

Reviewed by Hajime Morita.

Source/WebCore:

This patch supports <shadow> element rendering.

When attaching <shadow> element, if it is in the oldest shadow tree, it runs a part of
distribution algorithm. If it is in non-oldest shadow tree, it runs tree a part of
tree composition algorithm to assign a older shadow root. In this patch, InsertionPonit
try to treat the distributed host children and the assigned shadow children similarly.

NodeRenderingContext supports rendering <shadow> element. Since the assigned shadow children
are treated like distributed host children, that change is to consider non-youngest shadow
tree basically also.

Tests: fast/dom/shadow/shadow-element-rendering-multiple.html

fast/dom/shadow/shadow-element-rendering-single.html

  • dom/NodeRenderingContext.cpp:

(WebCore):
(WebCore::NodeRenderingContext::NodeRenderingContext):

Does not ignore non-youngest shadow tree.

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::ShadowRoot):

  • dom/ShadowRoot.h:

(ShadowRoot):
(WebCore::ShadowRoot::assignedTo):
(WebCore):
(WebCore::ShadowRoot::setAssignedTo):
(WebCore::ShadowRoot::isUsedForRendering):

Returns true if ShadowRoot is youngest or assigned to some InsertionPoint.

(WebCore::toShadowRoot):

  • dom/ShadowTree.cpp:

(WebCore::ShadowTree::insertionPointFor):

Returns InsertionPoint to which node is distributed.

  • dom/ShadowTree.h:

(ShadowTree):

  • html/shadow/HTMLContentElement.h:

(WebCore::HTMLContentElement::doesSelectFromHostChildren):
(HTMLContentElement):

  • html/shadow/HTMLShadowElement.cpp:

(WebCore::HTMLShadowElement::HTMLShadowElement):
(WebCore::HTMLShadowElement::select):
(WebCore::HTMLShadowElement::doesSelectFromHostChildren):
(WebCore):

  • html/shadow/HTMLShadowElement.h:

(HTMLShadowElement):

  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::attach):
(WebCore::InsertionPoint::detach):
(WebCore::InsertionPoint::assignedFrom):
(WebCore):
(WebCore::InsertionPoint::assignShadowRoot):
(WebCore::InsertionPoint::clearAssignment):

  • html/shadow/InsertionPoint.h:

(InsertionPoint):

LayoutTests:

Contains tests both in case <shadow> appears in the oldest shadow root and
non-olderst shadow tree.

  • fast/dom/shadow/shadow-element-rendering-multiple-expected.txt: Added.
  • fast/dom/shadow/shadow-element-rendering-multiple.html: Added.
  • fast/dom/shadow/shadow-element-rendering-single-expected.txt: Added.
  • fast/dom/shadow/shadow-element-rendering-single.html: Added.
  • platform/efl/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
03:22 Changeset [110160] by hans@chromium.org

Speech JavaScript API: SpeechRecognitionAlternative, Result and ResultList
https://bugs.webkit.org/show_bug.cgi?id=80424

Reviewed by Adam Barth.

Implement the SpeechRecognitionAlternative,
SpeechRecognitionResult and SpeechRecognitionResultList.
(Spec: http://speech-javascript-api-spec.googlecode.com/git/speechapi.html)

No new tests because these interfaces don't have constructors.
They will be tested as more of the API gets implemented.

  • Modules/speech/SpeechRecognitionAlternative.cpp: Added.

(WebCore):
(WebCore::SpeechRecognitionAlternative::create):
(WebCore::SpeechRecognitionAlternative::SpeechRecognitionAlternative):

  • Modules/speech/SpeechRecognitionAlternative.h: Added.

(WebCore):
(SpeechRecognitionAlternative):
(WebCore::SpeechRecognitionAlternative::transcript):
(WebCore::SpeechRecognitionAlternative::confidence):

  • Modules/speech/SpeechRecognitionAlternative.idl: Added.
  • Modules/speech/SpeechRecognitionResult.cpp: Added.

(WebCore):
(WebCore::SpeechRecognitionResult::create):
(WebCore::SpeechRecognitionResult::item):
(WebCore::SpeechRecognitionResult::SpeechRecognitionResult):

  • Modules/speech/SpeechRecognitionResult.h: Added.

(WebCore):
(SpeechRecognitionResult):
(WebCore::SpeechRecognitionResult::length):
(WebCore::SpeechRecognitionResult::final):

  • Modules/speech/SpeechRecognitionResult.idl: Added.
  • Modules/speech/SpeechRecognitionResultList.cpp: Added.

(WebCore):
(WebCore::SpeechRecognitionResultList::create):
(WebCore::SpeechRecognitionResultList::item):
(WebCore::SpeechRecognitionResultList::SpeechRecognitionResultList):

  • Modules/speech/SpeechRecognitionResultList.h: Added.

(WebCore):
(SpeechRecognitionResultList):
(WebCore::SpeechRecognitionResultList::length):

  • Modules/speech/SpeechRecognitionResultList.idl: Added.
  • WebCore.gypi:
02:01 Changeset [110159] by fpizlo@apple.com

DFG CFA incorrectly handles ValueToInt32
https://bugs.webkit.org/show_bug.cgi?id=80568

Reviewed by Gavin Barraclough.

Changed it match exactly the decision pattern used in
DFG::SpeculativeJIT::compileValueToInt32

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

01:57 Changeset [110158] by ostapenko.viatcheslav@nokia.com

[Qt] [WK2] Webkit fails to link when compiled with force_static_libs_as_shared
https://bugs.webkit.org/show_bug.cgi?id=80524

Reviewed by Simon Hausmann.

Move IdentifierTable methods defintion to WTFThreadData.cpp to fix linking
of WTF library.

  • runtime/Identifier.cpp:
  • wtf/WTFThreadData.cpp:

(JSC):
(JSC::IdentifierTable::~IdentifierTable):
(JSC::IdentifierTable::add):

01:51 Changeset [110157] by commit-queue@webkit.org

Unreviewed, rolling out r110115.
http://trac.webkit.org/changeset/110115
https://bugs.webkit.org/show_bug.cgi?id=80581

broke test-webkitpy (Requested by philn-tp on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-08

  • Scripts/old-run-webkit-tests:
  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort):
(QtPort.determine_full_port_name):
(QtPort.baseline_search_path):

01:45 Changeset [110156] by commit-queue@webkit.org

[BlackBerry] Upstream GraphicsLayerBlackBerry.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=79867

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-03-08
Reviewed by Rob Buis.

Initial upstream, no new tests.

  • platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp: Added.

(WebCore):
(WebCore::setLayerBorderColor):
(WebCore::clearBorderColor):
(WebCore::setLayerBackgroundColor):
(WebCore::clearLayerBackgroundColor):
(WebCore::GraphicsLayer::create):
(WebCore::GraphicsLayerBlackBerry::GraphicsLayerBlackBerry):
(WebCore::GraphicsLayerBlackBerry::~GraphicsLayerBlackBerry):
(WebCore::GraphicsLayerBlackBerry::setName):
(WebCore::GraphicsLayerBlackBerry::setChildren):
(WebCore::GraphicsLayerBlackBerry::addChild):
(WebCore::GraphicsLayerBlackBerry::addChildAtIndex):
(WebCore::GraphicsLayerBlackBerry::addChildBelow):
(WebCore::GraphicsLayerBlackBerry::addChildAbove):
(WebCore::GraphicsLayerBlackBerry::replaceChild):
(WebCore::GraphicsLayerBlackBerry::removeFromParent):
(WebCore::GraphicsLayerBlackBerry::setPosition):
(WebCore::GraphicsLayerBlackBerry::setAnchorPoint):
(WebCore::GraphicsLayerBlackBerry::setSize):
(WebCore::GraphicsLayerBlackBerry::setTransform):
(WebCore::GraphicsLayerBlackBerry::setChildrenTransform):
(WebCore::GraphicsLayerBlackBerry::setPreserves3D):
(WebCore::GraphicsLayerBlackBerry::setMasksToBounds):
(WebCore::GraphicsLayerBlackBerry::setDrawsContent):
(WebCore::GraphicsLayerBlackBerry::setContentsVisible):
(WebCore::GraphicsLayerBlackBerry::setMaskLayer):
(WebCore::GraphicsLayerBlackBerry::setReplicatedByLayer):
(WebCore::GraphicsLayerBlackBerry::setFixedPosition):
(WebCore::GraphicsLayerBlackBerry::setHasFixedContainer):
(WebCore::GraphicsLayerBlackBerry::setHasFixedAncestorInDOMTree):
(WebCore::GraphicsLayerBlackBerry::setBackgroundColor):
(WebCore::GraphicsLayerBlackBerry::clearBackgroundColor):
(WebCore::GraphicsLayerBlackBerry::setContentsOpaque):
(WebCore::GraphicsLayerBlackBerry::setBackfaceVisibility):
(WebCore::GraphicsLayerBlackBerry::setOpacity):
(WebCore::GraphicsLayerBlackBerry::setContentsNeedsDisplay):
(WebCore::GraphicsLayerBlackBerry::setNeedsDisplay):
(WebCore::GraphicsLayerBlackBerry::setNeedsDisplayInRect):
(WebCore::GraphicsLayerBlackBerry::setContentsRect):
(WebCore::removeAnimationByIdAndProperty):
(WebCore::removeAnimationByName):
(WebCore::GraphicsLayerBlackBerry::addAnimation):
(WebCore::GraphicsLayerBlackBerry::pauseAnimation):
(WebCore::GraphicsLayerBlackBerry::removeAnimation):
(WebCore::GraphicsLayerBlackBerry::suspendAnimations):
(WebCore::GraphicsLayerBlackBerry::resumeAnimations):
(WebCore::GraphicsLayerBlackBerry::setContentsToImage):
(WebCore::GraphicsLayerBlackBerry::updateContentsImage):
(WebCore::GraphicsLayerBlackBerry::setContentsToCanvas):
(WebCore::GraphicsLayerBlackBerry::setContentsToMedia):
(WebCore::GraphicsLayerBlackBerry::hostLayerForSublayers):
(WebCore::GraphicsLayerBlackBerry::layerForSuperlayer):
(WebCore::GraphicsLayerBlackBerry::platformLayer):
(WebCore::GraphicsLayerBlackBerry::setDebugBackgroundColor):
(WebCore::GraphicsLayerBlackBerry::setDebugBorder):
(WebCore::GraphicsLayerBlackBerry::updateSublayerList):
(WebCore::GraphicsLayerBlackBerry::updateLayerPosition):
(WebCore::GraphicsLayerBlackBerry::updateLayerSize):
(WebCore::GraphicsLayerBlackBerry::updateAnchorPoint):
(WebCore::GraphicsLayerBlackBerry::updateTransform):
(WebCore::GraphicsLayerBlackBerry::updateChildrenTransform):
(WebCore::GraphicsLayerBlackBerry::updateMasksToBounds):
(WebCore::GraphicsLayerBlackBerry::updateContentsOpaque):
(WebCore::GraphicsLayerBlackBerry::updateBackfaceVisibility):
(WebCore::GraphicsLayerBlackBerry::updateLayerPreserves3D):
(WebCore::GraphicsLayerBlackBerry::updateLayerIsDrawable):
(WebCore::GraphicsLayerBlackBerry::updateFixedPosition):
(WebCore::GraphicsLayerBlackBerry::updateHasFixedContainer):
(WebCore::GraphicsLayerBlackBerry::updateHasFixedAncestorInDOMTree):
(WebCore::GraphicsLayerBlackBerry::updateLayerBackgroundColor):
(WebCore::GraphicsLayerBlackBerry::updateAnimations):
(WebCore::GraphicsLayerBlackBerry::updateContentsVideo):
(WebCore::GraphicsLayerBlackBerry::updateContentsRect):
(WebCore::GraphicsLayerBlackBerry::setupContentsLayer):
(WebCore::GraphicsLayerBlackBerry::updateOpacityOnLayer):
(WebCore::GraphicsLayerBlackBerry::contentsVisible):

  • platform/graphics/blackberry/GraphicsLayerBlackBerry.h: Added.

(WebCore):
(GraphicsLayerBlackBerry):
(WebCore::GraphicsLayerBlackBerry::notifySyncRequired):
(WebCore::GraphicsLayerBlackBerry::notifyAnimationStarted):
(WebCore::GraphicsLayerBlackBerry::primaryLayer):
(WebCore::GraphicsLayerBlackBerry::contentsLayer):

01:31 Changeset [110155] by commit-queue@webkit.org

[Forms] Re-organize test files of label element
https://bugs.webkit.org/show_bug.cgi?id=80575

There are 988 files under LayoutTests/fast/forms. It is hard to find
a file from UI. To improve discoverability of file, it is better to
organize files based on element as some test files did.

This patch moves test files of "label" element to fast/forms/label and
adjusts path of JavaScript files.

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-08
Reviewed by Kentaro Hara.

  • fast/forms/label/labels-add-htmlFor-label-expected.txt: Renamed from LayoutTests/fast/forms/labels-add-htmlFor-label-expected.txt.
  • fast/forms/label/labels-add-htmlFor-label.html: Renamed from LayoutTests/fast/forms/labels-add-htmlFor-label.html.
  • fast/forms/label/labels-add-parent-label-expected.txt: Renamed from LayoutTests/fast/forms/labels-add-parent-label-expected.txt.
  • fast/forms/label/labels-add-parent-label.html: Renamed from LayoutTests/fast/forms/labels-add-parent-label.html.
  • fast/forms/label/labels-change-htmlFor-attribute-expected.txt: Renamed from LayoutTests/fast/forms/labels-change-htmlFor-attribute-expected.txt.
  • fast/forms/label/labels-change-htmlFor-attribute.html: Renamed from LayoutTests/fast/forms/labels-change-htmlFor-attribute.html.
  • fast/forms/label/labels-custom-property-expected.txt: Renamed from LayoutTests/fast/forms/labels-custom-property-expected.txt.
  • fast/forms/label/labels-custom-property.html: Renamed from LayoutTests/fast/forms/labels-custom-property.html.
  • fast/forms/label/labels-item-index-expected.txt: Renamed from LayoutTests/fast/forms/labels-item-index-expected.txt.
  • fast/forms/label/labels-item-index.html: Renamed from LayoutTests/fast/forms/labels-item-index.html.
  • fast/forms/label/labels-remove-htmlFor-attribute-expected.txt: Renamed from LayoutTests/fast/forms/labels-remove-htmlFor-attribute-expected.txt.
  • fast/forms/label/labels-remove-htmlFor-attribute.html: Renamed from LayoutTests/fast/forms/labels-remove-htmlFor-attribute.html.
  • fast/forms/label/labels-remove-htmlFor-label-expected.txt: Renamed from LayoutTests/fast/forms/labels-remove-htmlFor-label-expected.txt.
  • fast/forms/label/labels-remove-htmlFor-label.html: Renamed from LayoutTests/fast/forms/labels-remove-htmlFor-label.html.
  • fast/forms/label/labels-remove-parent-label-expected.txt: Renamed from LayoutTests/fast/forms/labels-remove-parent-label-expected.txt.
  • fast/forms/label/labels-remove-parent-label.html: Renamed from LayoutTests/fast/forms/labels-remove-parent-label.html.
  • fast/forms/label/labels-set-htmlFor-attribute-expected.txt: Renamed from LayoutTests/fast/forms/labels-set-htmlFor-attribute-expected.txt.
  • fast/forms/label/labels-set-htmlFor-attribute.html: Renamed from LayoutTests/fast/forms/labels-set-htmlFor-attribute.html.
01:06 Changeset [110154] by fpizlo@apple.com

DFG instruction count threshold should be lifted to 10000
https://bugs.webkit.org/show_bug.cgi?id=80579

Reviewed by Gavin Barraclough.

  • runtime/Options.cpp:

(JSC::Options::initializeOptions):

01:02 Changeset [110153] by fpizlo@apple.com

Incorrect tracking of abstract values of variables forced double
https://bugs.webkit.org/show_bug.cgi?id=80566
<rdar://problem/11001442>

Reviewed by Gavin Barraclough.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::mergeStateAtTail):

00:35 Changeset [110152] by haraken@chromium.org

Unreviewed. Added myself to watchlist.

  • Scripts/webkitpy/common/config/watchlist:
00:22 Changeset [110151] by shinyak@chromium.org

Refactoring: Remove Node::isContentElement and Node::isShadowElement.
https://bugs.webkit.org/show_bug.cgi?id=80501

Reviewed by Hajime Morita.

Removes Node::isContentElement and Node::isShadowElement. These methods are replaced
by hasTagName. However the tag name of HTMLContentElement was not consistent,
this patch make them consistent.

No new tests. Should be covered by existing tests.

  • dom/Node.h:
  • html/HTMLElement.h:

(WebCore::HTMLElement::isInsertionPoint):
(HTMLElement):

  • html/HTMLSummaryElement.cpp:

(WebCore::SummaryContentElement::SummaryContentElement):

It uses HTMLNames::divTag as tagname. It should use HTMLNames::webkitShadowTagName.

  • html/shadow/HTMLContentElement.h:

(HTMLContentElement):

  • html/shadow/InsertionPoint.h:

(InsertionPoint):
(WebCore::InsertionPoint::isInsertionPoint):
(WebCore::isInsertionPoint):

  • testing/Internals.cpp:

(WebCore::Internals::isValidContentSelect):

  • testing/Internals.h:

(Internals):

03/07/12:

23:46 HackingGtk edited by carlosgc@webkit.org
Update lik to api ref (diff)
23:34 Changeset [110150] by abarth@webkit.org

ContainerNode::insertedIntoDocument and removedFromDocument use weak iteration patterns
https://bugs.webkit.org/show_bug.cgi?id=80569

Reviewed by Ryosuke Niwa.

This patch moves ContainerNode::insertedIntoDocument and
removedFromDocument to using a better iteration pattern in which we
collect all the nodes we're planning to iterate into a vector and then
iterate over them.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::insertedIntoDocument):
(WebCore::ContainerNode::removedFromDocument):

23:08 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
Note: See TracTimeline for information about the timeline view.