Timeline


and

03/13/12:

23:54 Changeset [110665] by commit-queue@webkit.org
  • 19 edits in trunk

Source/WebCore: [Forms] Hidden input element should not have labels.
https://bugs.webkit.org/show_bug.cgi?id=80403

Patch by Yosifumi Inoue <yosin@chromium.org> on 2012-03-13
Reviewed by Kent Tamura.

This patch changes "labels" attribute behavior for hidden input type.
It returns null instead of NodeList of labels or empty node list.

Note: The HTML5 specification isn't clear for non-labelable element's "labels"
attribute return value. Firefox and Opera return empty node list. IE returns null.

No new tests. Existing tests are updated.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::isLabelable): Added. Dispatch to InputType.

  • html/HiddenInputType.h: Added isLabelable returning false.
  • html/InputType.cpp:

(WebCore::InputType::isLabelable): Added. Returning true for all input types except for "hidden" type.
(WebCore):

  • html/InputType.h:

(InputType): Added isLabelable declaration.

LayoutTests: [Forms] Hidden input element should not have labels.
https://bugs.webkit.org/show_bug.cgi?id=80403

Patch by Yosifumi Inoue <yosin@chromium.org> on 2012-03-13
Reviewed by Kent Tamura.

This patch changes expected text for null value of labels attribute
of hidden input type and labelable-elements to check null value for
the labels attribute of input type.

  • fast/forms/label/labelable-elements-expected.txt:
  • fast/forms/label/labelable-elements.html:
  • fast/forms/label/labels-add-htmlFor-label-expected.txt:
  • fast/forms/label/labels-add-parent-label-expected.txt:
  • fast/forms/label/labels-change-htmlFor-attribute-expected.txt:
  • fast/forms/label/labels-multiple-sibling-labels-expected.txt:
  • fast/forms/label/labels-parent-and-sibling-labels-expected.txt:
  • fast/forms/label/labels-remove-htmlFor-attribute-expected.txt:
  • fast/forms/label/labels-remove-htmlFor-label-expected.txt:
  • fast/forms/label/labels-remove-parent-label-expected.txt:
  • fast/forms/label/labels-set-htmlFor-attribute-expected.txt:
  • platform/chromium/fast/forms/label/labelable-elements-expected.txt:
  • platform/mac/fast/forms/label/labelable-elements-expected.txt:
23:35 Changeset [110664] by commit-queue@webkit.org
  • 15 edits in trunk

[Forms] The "output" element should have labels.
https://bugs.webkit.org/show_bug.cgi?id=80466

Patch by Yosifumi Inoue <yosin@chromium.org> on 2012-03-13
Reviewed by Kent Tamura.

Source/WebCore:

This patch enables functionality of "labels" attribute for
HTMLOutputElement implemented in LabelableElement which use
isLabelable predicate whether an element can have label or not.

Update existing tests in fast/forms/label/ directory to cover
the "output" element with the "labels" attribute.

  • html/HTMLOutputElement.h: Implement virtual method isLabelable.

LayoutTests:

This patch updates expectation for functioning the "labels"
attribute of the "output" elements which was not working
so far.

  • fast/forms/label/labelable-elements-expected.txt:
  • fast/forms/label/labels-add-htmlFor-label-expected.txt:
  • fast/forms/label/labels-add-parent-label-expected.txt:
  • fast/forms/label/labels-change-htmlFor-attribute-expected.txt:
  • fast/forms/label/labels-multiple-sibling-labels-expected.txt:
  • fast/forms/label/labels-parent-and-sibling-labels-expected.txt:
  • fast/forms/label/labels-remove-htmlFor-attribute-expected.txt:
  • fast/forms/label/labels-remove-htmlFor-label-expected.txt:
  • fast/forms/label/labels-remove-parent-label-expected.txt:
  • fast/forms/label/labels-set-htmlFor-attribute-expected.txt:
  • platform/chromium/fast/forms/label/labelable-elements-expected.txt:
  • platform/mac/fast/forms/label/labelable-elements-expected.txt
23:24 Changeset [110663] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, marking some tests flaky.

  • platform/chromium/test_expectations.txt:
20:19 Changeset [110662] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Move opacity clamping into RenderStyle setter.
https://bugs.webkit.org/show_bug.cgi?id=76966

Reviewed by Eric Seidel.

Covered by existing tests.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyleBitfields::setOpacity):

19:54 Changeset [110661] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

ValueToInt32 speculation will cause OSR exits even when it does not have to
https://bugs.webkit.org/show_bug.cgi?id=81068
<rdar://problem/11043926>

Reviewed by Anders Carlsson.

Two related changes:
1) ValueToInt32 will now always just defer to the non-speculative path, instead

of exiting, if it doesn't know what speculations to perform.

2) ValueToInt32 will speculate boolean if it sees this to be profitable.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGNode.h:

(JSC::DFG::Node::shouldSpeculateBoolean):
(Node):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileValueToInt32):

19:47 Changeset [110660] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

More Windows build fixing

19:40 Changeset [110659] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix

19:28 Changeset [110658] by cevans@google.com
  • 3 edits
    3 copies in branches/chromium/1025

Merge 110593
BUG=112317
Review URL: https://chromiumcodereview.appspot.com/9703008

19:12 Changeset [110657] by mhahnenberg@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

Type conversion of exponential part failed
https://bugs.webkit.org/show_bug.cgi?id=80673

Reviewed by Geoffrey Garen.

  • parser/Lexer.cpp:

(JSC::::lex):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::parseInt):
(JSC):
(JSC::jsStrDecimalLiteral): Added another template argument that exposes whether or not
we accept trailing junk to clients of jsStrDecimalLiteral. Also added additional template
parameter for strtod to allow trailing spaces.
(JSC::toDouble):
(JSC::parseFloat): Accept trailing junk, as per the ECMA 262 spec (15.1.2.3).

  • runtime/LiteralParser.cpp:

(JSC::::Lexer::lexNumber):

  • tests/mozilla/expected.html: Update the expected page for run-javascriptcore-tests so that

we will run ecma/TypeConversion/9.3.1-3.js as a regression test now.

  • wtf/dtoa.cpp:

(WTF):
(WTF::strtod): We also needed to sometimes accept trailing spaces to pass a few other tests that were
broken by changing the default allowance of trailing junk in jsStrDecimalLiteral.

  • wtf/dtoa.h:
  • wtf/dtoa/double-conversion.cc: When the AdvanceToNonspace function was lifted out of the

Chromium codebase, the person porting it only thought to check for spaces when skipping whitespace.
A few of our JSC tests check for other types of trailing whitespace, so I've added checks for those
here to cover those cases (horizontal tab, vertical tab, carriage return, form feed, and line feed).

  • wtf/text/WTFString.cpp:

(WTF::toDoubleType): Disallow trailing spaces, as this breaks form input verification stuff.

18:38 Changeset [110656] by igor.o@sisa.samsung.com
  • 3 edits in trunk/Source/WebCore

Split the extra logic out of RenderObjectChildList::updateBeforeAfterContent
https://bugs.webkit.org/show_bug.cgi?id=80856

Extra part of the generated content handling logic out of RenderObjectChildList::updateBeforeAfterContent

Reviewed by Julien Chaffraix.

No change in behavior expected.

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::updateBeforeAfterStyle):
(WebCore::createRenderForBeforeAfterContent):
(WebCore::RenderObjectChildList::updateBeforeAfterContent):

  • rendering/RenderObjectChildList.h:

(WebCore):
(RenderObjectChildList):

18:37 Changeset [110655] by ojan@chromium.org
  • 131 edits
    112 copies
    18 moves
    54 adds
    23 deletes in trunk/LayoutTests

FREEEEEDOOM!!! Last set of bulk Chromium-Lion rebaselines.

18:26 Changeset [110654] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed, build fix since is_pod<> includes some header that I didn't know about.
Removing the assert for now.

  • dfg/DFGOperations.h:
  • llint/LLIntSlowPaths.h:
18:09 Changeset [110653] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Find bouncy doesn’t hide when a subframe is scrolled
https://bugs.webkit.org/show_bug.cgi?id=81060
<rdar://problem/9365329>

Reviewed by Andreas Kling.

Instead of hiding the find indicator when pageDidScroll is called, add a check to FindController::drawRect and hide
the find indicator there if the find selection bounds have changed since the last call to drawRect.

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::updateFindIndicator):
(WebKit::FindController::drawRect):

  • WebProcess/WebPage/FindController.h:

(FindController):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::pageDidScroll):

18:07 Changeset [110652] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

WebKitTestRunner needs a more-complete implementation of eventSender.
https://bugs.webkit.org/show_bug.cgi?id=42194

Skip yet another test that uses eventSender.

  • platform/wk2/Skipped:
17:46 Changeset [110651] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Functions with C linkage should return POD types
https://bugs.webkit.org/show_bug.cgi?id=81061

Reviewed by Mark Rowe.

  • dfg/DFGOperations.h:
  • llint/LLIntSlowPaths.h:

(LLInt):
(SlowPathReturnType):
(JSC::LLInt::encodeResult):

17:36 Changeset [110650] by arv@chromium.org
  • 14 edits in trunk/LayoutTests

Remove duplicate GC functions from layout tests
https://bugs.webkit.org/show_bug.cgi?id=81047

Reviewed by Ojan Vafai.

  • fast/canvas/webgl/shader-deleted-by-accessor.html:
  • fast/dom/Window/customized-property-survives-gc.html:
  • fast/dom/inline-event-attributes-lookup-removed-form.html:
  • fast/dom/inline-event-attributes-lookup-removed.html:
  • fast/dom/shadow/gc-shadow.html:
  • fast/filesystem/resources/file-writer-gc-blob.js:
  • fast/forms/input-image-submit.html:
  • fast/forms/interactive-validation-remove-node-in-handler.html:
  • fast/forms/select-set-length-with-mutation-remove.html:
  • fast/js/resources/js-test-pre.js:

(gc.else.gcRec):
(gc):

  • http/tests/websocket/tests/hixie76/close-on-unload-and-force-gc.html:
  • http/tests/websocket/tests/hybi/close-on-unload-and-force-gc.html:
  • webaudio/mediaelementaudiosourcenode-gc.html:
17:31 Changeset [110649] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

WebKitTestRunner needs layoutTestController.setEditingBehavior
https://bugs.webkit.org/show_bug.cgi?id=42689

Add more tests that use setEditingBehavior to the wk2 Skipped list.

  • platform/wk2/Skipped:
17:28 Changeset [110648] by enne@google.com
  • 3 edits in trunk/LayoutTests

[chromium] Unreviewed, rebaseline fast/canvas/canvas-text-alignment
https://bugs.webkit.org/show_bug.cgi?id=78529

After r110620, root layer scrollbars are drawn opaque, so they no
longer differ between debug and release due to alpha values.
Rebaselining this test.

  • platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium/test_expectations.txt:
17:27 Changeset [110647] by ap@apple.com
  • 2 edits in trunk/LayoutTests
  • platform/mac/fast/js/global-constructors-expected.txt: Added Selection.toString and WebKitMutationObserver.toString. Selection got exposed in <http://trac.webkit.org/changeset/109306>, and WebKitMutationObserver was probably failing for even longer.
17:18 Changeset [110646] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebCore

Fix potential crash when loading test results
https://bugs.webkit.org/show_bug.cgi?id=81062
<rdar://problem/11041732>

Reviewed by Dean Jackson.

If RenderLayerBacking::isSimpleContainerCompositingLayer() is called early,
before the document has a documentElement(), then it crashes. Fix with
a null check on documentElement().

No test because it's timing dependent.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):

17:08 Changeset [110645] by timothy_horton@apple.com
  • 3 edits in trunk/LayoutTests

platform/mac/fast/forms/input-appearance-spinbutton(-up) fail on Lion
https://bugs.webkit.org/show_bug.cgi?id=81058

Add unreviewed expected failing result (which may actually be correct) for mac.

  • platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
17:06 Changeset [110644] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

MediaStream is not enabled on Mac. Skip all related tests.

  • platform/mac/Skipped:
16:58 Changeset [110643] by mitz@apple.com
  • 3 edits
    1 add in trunk
<rdar://problem/11025225> Assertion failure in RenderView::computeRectForRepaint() (!repaintContainer
repaintContainer == this) at store.apple.com

https://bugs.webkit.org/show_bug.cgi?id=81051

Reviewed by Simon Fraser.

.:

  • ManualTests/inline-repaint-container.html: Added.

Source/WebCore:

Test: ManualTests/inline-repaint-container.html.

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::clippedOverflowRectForRepaint): This function was not handling the
case of the repaint container being a descendant of the containing block correctly, leading
to the assertion failure, but also to a correctness bug seen in the new test. If the repaint
container is a descendant of the containing block, just return the rect in the repaint
container coordinates.

16:57 Changeset [110642] by mitz@apple.com
  • 4 edits
    2 adds in trunk

<rdar://problem/11025217> [Mac] Assertion failure in collectComplexTextRunsForCharactersCoreText
https://bugs.webkit.org/show_bug.cgi?id=77044

Reviewed by Sam Weinig.

Source/WebCore:

Test: platform/mac/fast/text/core-text-fallback-to-unknown-font.html

Handle the case of Core Text choosing a fallback font that NSFontManager cannot find by name.

  • platform/graphics/FontCache.h:

(FontCache): Made ComplexTextController a friend class.

  • platform/graphics/mac/ComplexTextControllerCoreText.mm:

(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): Removed the
failing assertion, which was not true, and added code to handle the case where a font
cannot be found by name by using the font as returned from Core Text.

LayoutTests:

  • platform/mac/fast/text/core-text-fallback-to-unknown-font-expected.txt: Added.
  • platform/mac/fast/text/core-text-fallback-to-unknown-font.html: Added.
16:56 Changeset [110641] by arv@chromium.org
  • 43 edits
    2 deletes in trunk

[V8] Use v8::V8::AddImplicitReferences instead of SetHiddenValue
https://bugs.webkit.org/show_bug.cgi?id=80880

Reviewed by Adam Barth.

Source/WebCore:

We used to add a hidden property in the getter to the returned wrapper.
With this patch we instead handle the liveness of the wrapper in the GC phase by
calling v8::V8::AddHiddenReference.

To reduce the amount of custom code we need, the V8 code generator now supports
GenerateIsReachable (as well as CustomIsReachable) which, even though different
from the JSC attribute, is used in the same cases and takes the same values (even though
at the moment not all JSC values are supported by V8). Interfaces that have *IsReachable
also have a dependent life time (just like if V8DependentLifetime was present).

Second try. This time with an added include in TextTrackList.cpp.

No new tests. Covered by existing tests.

  • Target.pri:
  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorJS.pm:

(GetGenerateIsReachable):
(GetCustomIsReachable):
(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(NeedsToVisitDOMWrapper):
(GetGenerateIsReachable):
(GetCustomIsReachable):
(GenerateVisitDOMWrapper):
(GenerateHeader):
(GenerateNamedConstructorCallback):
(GenerateImplementation):

  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):

  • bindings/v8/NPV8Object.cpp:

(WebCore::npObjectTypeInfo):

  • bindings/v8/V8GCController.cpp:

(WebCore::GrouperVisitor::visitDOMWrapper):

  • bindings/v8/WrapperTypeInfo.h:

(WebCore):
(WrapperTypeInfo):

  • bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Removed.
  • bindings/v8/custom/V8DOMStringMapCustom.cpp:
  • bindings/v8/custom/V8DOMTokenListCustom.cpp: Removed.
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore):

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:
  • bindings/v8/custom/V8StyleSheetCustom.cpp:

(WebCore::toV8):

  • css/CSSStyleSheet.idl:
  • css/StyleSheet.idl:
  • dom/DOMStringMap.idl:
  • dom/NamedNodeMap.idl:
  • html/DOMTokenList.idl:
  • html/track/TextTrackList.cpp:
  • html/track/TextTrackList.idl:

LayoutTests:

  • platform/chromium/test_expectations.txt:
16:45 Changeset [110640] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

MathML crash in WebCore::Node::previousSibling()
https://bugs.webkit.org/show_bug.cgi?id=80773

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-03-13
Reviewed by Julien Chaffraix.

Source/WebCore:

When adding child for msub render, if the child is mtr or mtd render,
we will creat an anonymous render as the container. As the anonymous
render's node is 0, accessing it directly can cause crash.
We should do a valid check of the node before using. In addition to
that, for msub, attach the anonymous render and it's children to render
tree. For msubsup, such kind of situation should never happen based on
the current codebase.

Test: mathml/msub-anonymous-child-render-crash.html

  • rendering/mathml/RenderMathMLSubSup.cpp:

(WebCore::RenderMathMLSubSup::addChild):

LayoutTests:

  • mathml/msub-anonymous-child-render-crash-expected.txt: Added.
  • mathml/msub-anonymous-child-render-crash.html: Added.
16:43 Changeset [110639] by mihnea@adobe.com
  • 17 edits
    14 deletes in trunk

[CSSRegions]NamedFlow::getRegionsByContentNode should not return a live NodeList
https://bugs.webkit.org/show_bug.cgi?id=81021

Reviewed by Ryosuke Niwa.

Reverting the original patch as we need a better solution.

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Node.cpp:

(WebCore::NodeListsNodeData::invalidateCaches):
(WebCore::NodeListsNodeData::isEmpty):

  • dom/Node.h:

(Node):

  • dom/NodeRareData.h:

(NodeListsNodeData):

  • dom/RegionNodeList.cpp: Removed.
  • dom/RegionNodeList.h: Removed.
  • dom/WebKitNamedFlow.cpp:
  • dom/WebKitNamedFlow.h:

(WebKitNamedFlow):

  • dom/WebKitNamedFlow.idl:
  • rendering/RenderFlowThread.cpp:
  • rendering/RenderFlowThread.h:
  • rendering/RenderRegion.h:

(RenderRegion):

LayoutTests:

  • fast/regions/get-regions-by-content-node-expected.txt: Removed.
  • fast/regions/get-regions-by-content-node-horiz-bt-expected.txt: Removed.
  • fast/regions/get-regions-by-content-node-horiz-bt.html: Removed.
  • fast/regions/get-regions-by-content-node-horiz-tb-expected.txt: Removed.
  • fast/regions/get-regions-by-content-node-horiz-tb.html: Removed.
  • fast/regions/get-regions-by-content-node-vert-lr-expected.txt: Removed.
  • fast/regions/get-regions-by-content-node-vert-lr.html: Removed.
  • fast/regions/get-regions-by-content-node-vert-rl-expected.txt: Removed.
  • fast/regions/get-regions-by-content-node-vert-rl.html: Removed.
  • fast/regions/get-regions-by-content-node.html: Removed.
  • fast/regions/get-regions-by-content-node2-expected.txt: Removed.
  • fast/regions/get-regions-by-content-node2.html: Removed.
16:39 Changeset [110638] by jeffm@apple.com
  • 8 edits in trunk/Source/WebKit2

Support loading a WKPage from web archive data
https://bugs.webkit.org/show_bug.cgi?id=81044

This code was written by Jessie Berlin.

Reviewed by Brady Eidson.

  • UIProcess/API/C/WKPage.cpp:

(WKPageLoadWebArchiveData): Added.

  • UIProcess/API/C/WKPage.h: Added WKPageLoadWebArchiveData().


  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadWebArchiveData): Added.

  • UIProcess/WebPageProxy.h: Added loadWebArchiveData().
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadWebArchiveData): Added.

  • WebProcess/WebPage/WebPage.h: Added loadWebArchiveData().
  • WebProcess/WebPage/WebPage.messages.in: Added LoadWebArchiveData message.
16:31 Changeset [110637] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Note that this test is flaky. The flakiness dashboard says that this
test has been flaky for a while.

  • platform/chromium/test_expectations.txt:
16:28 Changeset [110636] by abarth@webkit.org
  • 1 edit
    2 adds
    2 deletes in trunk/LayoutTests

Add a Leopard-specific baseline for
fast/forms/file/file-input-pressed-state and generalize the
chromium-win-vista baseline to include all of windows.

  • platform/chromium-mac-leopard/fast/forms/file/file-input-pressed-state-expected.png: Added.
  • platform/chromium-win-vista/fast/forms/file: Removed.
  • platform/chromium-win-vista/fast/forms/file/file-input-pressed-state-expected.png: Removed.
  • platform/chromium-win-xp/fast/forms/file: Removed.
  • platform/chromium-win/fast/forms/file/file-input-pressed-state-expected.png: Added.
16:28 Changeset [110635] by shawnsingh@chromium.org
  • 6 edits in trunk/Source

[chromium] wrong transform causing incorrect culling
https://bugs.webkit.org/show_bug.cgi?id=80471

Reviewed by James Robinson.

Source/WebCore:

Unit test added to CCRenderSurfaceTest.cpp

In addition to using originTransform() instead of drawTransform(),
this patch shuffles a bit of code so that a unit test can be
easily added.

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::appendQuadsForRenderSurfaceLayer):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::createSharedQuadState):
(WebCore):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(CCRenderSurface):

Source/WebKit/chromium:

  • tests/CCRenderSurfaceTest.cpp:

(WebCore::TEST):
(WebCore):

16:18 Changeset [110634] by tony@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

more multiline flexbox tests
https://bugs.webkit.org/show_bug.cgi?id=81025

Reviewed by Ojan Vafai.

Add a test case for wrap-reverse to verify that we align with the end of the flexbox.

  • css3/flexbox/multiline-reverse-wrap-overflow-expected.txt: Added.
  • css3/flexbox/multiline-reverse-wrap-overflow.html: Added.
16:11 Changeset [110633] by darin@chromium.org
  • 2 edits in trunk/LayoutTests

fast/loader/form-submission-after-beforeunload-cancel.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=81024

Reviewed by Andy Estes.

  • fast/loader/form-submission-after-beforeunload-cancel.html:

Give the form post a better chance of loading before the FAIL timer.

16:00 Changeset [110632] by tomz@codeaurora.org
  • 4 edits
    2 adds in trunk

Alternate xml-stylesheets with no title are loaded, in violation of the CSSOM draft
https://bugs.webkit.org/show_bug.cgi?id=77549

Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-03-13
Reviewed by David Hyatt.

Source/WebCore:

Amended code to ignore alternate stylesheets that do not have a title attribute.

Test: fast/css/xml-stylesheet-alternate-no-title.xhtml

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::checkStyleSheet):

LayoutTests:

Added new text test, modified existing test: added title attribute to alternate stylesheet.

  • fast/css/xml-stylesheet-alternate-no-title-expected.txt: Added.
  • fast/css/xml-stylesheet-alternate-no-title.xhtml: Added.
  • fast/css/xml-stylesheet-alternate-processing.xhtml:
15:59 Changeset [110631] by fpizlo@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Loads from UInt32Arrays should not result in a double up-convert if it isn't necessary
https://bugs.webkit.org/show_bug.cgi?id=80979
<rdar://problem/11036848>

Reviewed by Oliver Hunt.

Also improved DFG IR dumping to include type information in a somewhat more
intuitive way.

  • bytecode/PredictedType.cpp:

(JSC::predictionToAbbreviatedString):
(JSC):

  • bytecode/PredictedType.h:

(JSC):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::forwardSpeculationCheck):

15:57 Changeset [110630] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Input focus state should unfocus the frame selection instead of the field.
https://bugs.webkit.org/show_bug.cgi?id=81023

Patch by Mike Fenton <mifenton@rim.com> on 2012-03-13
Reviewed by Antonio Gomes.

PR 137400.

Prevent cursor drawing by unfocusing the frame selection
when input mode is not ready.

Greatly simplify the decision to focus input fields by removing
all ties to the page load state and base it on input. Input mode
is disabled when a page load begins and enabled on any user input.

The field is focused and ready for input immediately, only the
frame selection (or cursor) is unfocused.

Reviewed Internally by Gen Mak, Antonio Gomes and Nima Ghanavatian.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):

  • Api/WebPageClient.h:
  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::shouldBeginEditing):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::InputHandler):
(BlackBerry::WebKit::InputHandler::setElementUnfocused):
(BlackBerry::WebKit::InputHandler::enableInputMode):
(BlackBerry::WebKit::InputHandler::setElementFocused):
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
(BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):
(BlackBerry::WebKit::InputHandler::handleKeyboardInput):
(BlackBerry::WebKit::InputHandler::setComposingText):

  • WebKitSupport/InputHandler.h:

(InputHandler):

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):

15:53 Changeset [110629] by leviw@chromium.org
  • 4 edits in trunk/Source/WebCore

Revert RenderLayer::absoluteBoundingBox to an IntRect
https://bugs.webkit.org/show_bug.cgi?id=81017

Reviewed by Eric Seidel.

Reverting RenderLayer::absoluteBoundingBox to an (pixel snapped) IntRect. Whenever
possible, we use integers representing for absolute coordinates. This is especially
relevant for methods, such as this one, that are exported and used in platform code.

No new tests. No change in behavior.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::absoluteBoundingBox):

  • rendering/RenderLayer.h:

(RenderLayer):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForPosition): This intersects
the absolute bounding box with the FrameView, which uses all integer values. It's
the only use of absoluteBoundingBox in WebCore.

15:51 Changeset [110628] by ap@apple.com
  • 1 edit
    7 adds in trunk/LayoutTests

Adding missing results.

  • platform/mac/media/audio-repaint-expected.txt: Added.
  • platform/mac/media/controls-strict-expected.txt: Added.
  • platform/mac/media/video-controls-rendering-expected.txt: Added.
  • platform/mac/media/video-no-audio-expected.txt: Added.
  • platform/mac/media/video-display-toggle-expected.txt: Added. These already had PNG results, but no text results for platform/mac.
  • platform/mac/media/controls-layout-direction-expected.png: Added.
  • platform/mac/media/video-playing-and-pause-expected.png: Added. These had text results, but no pixel ones.
15:50 Changeset [110627] by nduca@chromium.org
  • 4 edits in trunk/Source

[chromium] vsync ticks are needed in invisible tabs when we are still updating resources
https://bugs.webkit.org/show_bug.cgi?id=80910

Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::vsyncCallbackNeeded):

Source/WebKit/chromium:

  • tests/CCSchedulerStateMachineTest.cpp:

(WebCore::TEST):
(WebCore):

15:40 Changeset [110626] by commit-queue@webkit.org
  • 3 edits
    14 adds in trunk

Alternate stylesheets (without title attribute) are loaded on refresh
https://bugs.webkit.org/show_bug.cgi?id=24354

Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-03-13
Reviewed by David Hyatt.

Source/WebCore:

Alternate stylesheets are now ignored in <link> tags if
they have no title attribute (per spec).

Tests: fast/css/link-alternate-stylesheet-1.html

fast/css/link-alternate-stylesheet-2.html
fast/css/link-alternate-stylesheet-3.html
fast/css/link-alternate-stylesheet-4.html
fast/css/link-alternate-stylesheet-5.html

  • dom/Document.cpp:

(WebCore::Document::collectActiveStylesheets):

LayoutTests:

Addapted alternate stylesheet tests from http://robballou.com/switcher/sandbox/alternate1.php

  • fast/css/link-alternate-stylesheet-1-expected.txt: Added.
  • fast/css/link-alternate-stylesheet-1.html: Added.
  • fast/css/link-alternate-stylesheet-2-expected.txt: Added.
  • fast/css/link-alternate-stylesheet-2.html: Added.
  • fast/css/link-alternate-stylesheet-3-expected.txt: Added.
  • fast/css/link-alternate-stylesheet-3.html: Added.
  • fast/css/link-alternate-stylesheet-4-expected.txt: Added.
  • fast/css/link-alternate-stylesheet-4.html: Added.
  • fast/css/link-alternate-stylesheet-5-expected.txt: Added.
  • fast/css/link-alternate-stylesheet-5.html: Added.
  • fast/css/resources/basic.css: Added.

(body):
(code):
(#source):

  • fast/css/resources/high.css: Added.

(body):
(h1):

  • fast/css/resources/normal.css: Added.

(body):
(h1):

  • fast/css/resources/small.css: Added.

(body):

15:36 Changeset [110625] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

WKTR needs an implementation of setAsynchronousSpellCheckingEnabled.
https://bugs.webkit.org/show_bug.cgi?id=81042

Skip some tests on Mac WK2 that use setAsynchronousSpellCheckingEnabled.

  • platform/mac-wk2/Skipped:
15:35 Changeset [110624] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/Source

Region::contains(IntPoint) is slow
https://bugs.webkit.org/show_bug.cgi?id=81008

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-13
Reviewed by Anders Carlsson.

Source/WebCore:

Speed up Region::contains(IntPoint) by directly testing if the point
is inside the Region's shape, rather than using a temporary 1x1 Region
for the test.

Unit test: RegionTest.containsPoint

  • platform/graphics/Region.cpp:

(WebCore::Region::contains):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/RegionTest.cpp: Added.

(WebCore):
(WebCore::TEST):

15:32 Changeset [110623] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Copy the platform-independent result for this test to chromium-mac to
hide the failing result added to apple-mac in
http://trac.webkit.org/changeset/110614.

  • platform/chromium/fast/forms/label: Added.
  • platform/chromium/fast/forms/label/labelable-elements-expected.txt: Added.
15:21 Changeset [110622] by abarth@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

For some reason chromium-win and chromium-linux have a different number
of spaces in the expected results file.

  • platform/chromium-win/media/sources-fallback-codecs-expected.txt: Added.
15:13 Changeset [110621] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Merge expectations for
svg/as-background-image/svg-as-background-6.html. Previously, Snow
Leopard had different expectations than every other platform, but the
behavior seems to match the expectations for other platforms.

Really what's going on is that this is a bad test for the reasons
explained in the test_expectations.txt file. I'm not entirely sure how
to fix the test to have repeatable results.

This patch also notes some more compositing reflection tests as flaky,
similar to the failures in
https://bugs.webkit.org/show_bug.cgi?id=79823. These tests have been
flaky for a while, but they seem to be failing more frequently now. I
couldn't find any recent changes to explain why that might be.

  • platform/chromium/test_expectations.txt:
15:06 Changeset [110620] by enne@google.com
  • 4 edits in trunk

[chromium] Mark root layer scrollbars as always opaque to disable blending
https://bugs.webkit.org/show_bug.cgi?id=79951

Reviewed by James Robinson.

Source/WebCore:

Now that scrollbar layers exist, mark non-overlay root scrollbars as
opaque. This disables blending for correctness and performance.

  • page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::scrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawTileQuad):

LayoutTests:

Mark canvas-text-alignment.html as failing on Linux in general, not
just in debug. I believe that with this change, the same image will
pass on both release and debug, but will land that change separately.

  • platform/chromium/test_expectations.txt:
14:59 Changeset [110619] by commit-queue@webkit.org
  • 5 edits in trunk

[EFL][DRT] Expose window.internals object
https://bugs.webkit.org/show_bug.cgi?id=79900

Exposes window.internals for EFL's DRT. Makes possible to
remove some tests from the skip list.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-03-13
Reviewed by Antonio Gomes.

Tools:

  • DumpRenderTree/efl/CMakeLists.txt:
  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::onWindowObjectCleared):

LayoutTests:

  • platform/efl/Skipped:
14:59 Changeset [110618] by gavinp@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove vestigal abortEvent from image attribute.
https://bugs.webkit.org/show_bug.cgi?id=80795

Reviewed by Adam Barth.

It seems we installed a listener for the abort event on images,
but never ever raised them. So this patch removes it. This could
cause different behaviour if the user sends abort events directly
at an image element, although addEventListener will still work.

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute):

14:52 Changeset [110617] by staikos@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

The callback is only used if SA_RESTART is defined. Compile it out
otherwise to avoid a warning.
https://bugs.webkit.org/show_bug.cgi?id=80926

Reviewed by Alexey Proskuryakov.

  • heap/MachineStackMarker.cpp:

(JSC):

14:51 Changeset [110616] by abarth@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Add a mac-specific baseline for this new test introduced in
http://trac.webkit.org/changeset/110593. This test is interested in
whether it crashes, not in a 1px difference in text metrics.

  • platform/chromium-mac-snowleopard/svg/custom/delete-text-crash-expected.txt: Added.
14:48 Changeset [110615] by abarth@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

Remove bogus expectation.

  • platform/chromium-mac/fast/dom/nodesFromRect-basic-expected.txt: Removed.
14:43 Changeset [110614] by jberlin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

r110542: New fast/forms/label/labelable-elements.html fails.
https://bugs.webkit.org/show_bug.cgi?id=80985

Add failing expected results for Mac to get the bots green.

  • platform/mac/fast/forms/label/labelable-elements-expected.txt: Added.
14:42 Changeset [110613] by abarth@webkit.org
  • 1 edit
    3 adds
    1 delete in trunk/LayoutTests

Add image baselines after http://trac.webkit.org/changeset/110598.
These tests show the platform-specific file chooser UI.

  • platform/chromium-linux-x86/fast/forms/file: Removed.
  • platform/chromium-linux/fast/forms/file/file-input-pressed-state-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/file/file-input-pressed-state-expected.png: Added.
  • platform/chromium-win-vista/fast/forms/file/file-input-pressed-state-expected.png: Added.
14:37 Changeset [110612] by timothy_horton@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

css3/filters/custom/custom-filter-property-computed-style.html passes in browser, fails in DRT
https://bugs.webkit.org/show_bug.cgi?id=81029
<rdar://problem/11040673>

Add unreviewed expected failing result for mac.

  • platform/mac/css3/filters/custom/custom-filter-property-computed-style-expected.txt:
14:36 Changeset [110611] by ojan@chromium.org
  • 279 edits
    180 copies
    32 moves
    117 adds
    1 delete in trunk/LayoutTests

Chromium-Lion rebaselines.

14:30 Changeset [110610] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

Attempt to fix QtMinimal bot after r110595

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-13

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):

14:22 Changeset [110609] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

Another attempt at fixing QtMinimal bot after r110595

Blind fix, unreviewed.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-13

  • WebCoreSupport/GeolocationClientQt.h:
14:18 Changeset [110608] by japhet@chromium.org
  • 5 edits
    3 adds in trunk

Source/WebCore: Rework how a CachedRawResource decides if it can be reused
for a given ResourceRequest. Ensure method, body, cookie policy,
and all headers match.
http://bugs.webkit.org/show_bug.cgi?id=79325

Reviewed by Oliver Hunt.

Test: http/tests/cache/xhr-body.html

  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::canReuse):

  • loader/cache/CachedRawResource.h: Take a ResourceRequest in canReuse().
  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::determineRevalidationPolicy): Remove Range header

check, since it is now redundant.

LayoutTests: Test for http://bugs.webkit.org/show_bug.cgi?id=79325.

Reviewed by Oliver Hunt.

  • http/tests/cache/resources/body.php: Added.
  • http/tests/cache/xhr-body-expected.txt: Added.
  • http/tests/cache/xhr-body.html: Added.
14:15 Changeset [110607] by ap@apple.com
  • 6 edits
    1 delete in trunk/LayoutTests

Updating some Mac results in media directory.

  • platform/chromium-mac/media/sources-fallback-codecs-expected.txt: Removed.
  • media/sources-fallback-codecs-expected.txt: Chromium result just matched what actually happened on Mac, so merging it into cross-platform.
  • platform/mac/media/audio-controls-rendering-expected.txt:
  • platform/mac/media/controls-after-reload-expected.txt:
  • platform/mac/media/media-controls-clone-expected.txt:
  • platform/mac/media/video-playing-and-pause-expected.txt: Updated for render tree changes. I'm getting the same results locally as buildbot does.
14:12 Changeset [110606] by timothy_horton@apple.com
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed rebaseline of fast/css/getComputedStyle/computed-style(without-renderer).html for mac, adding -webkit-grid-*

  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt: Added.
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
14:10 Changeset [110605] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Dump the generated code for ARM_TRADITIONAL
https://bugs.webkit.org/show_bug.cgi?id=80975

Patch by Hojong Han <hojong.han@samsung.com> on 2012-03-13
Reviewed by Gavin Barraclough.

  • assembler/LinkBuffer.h:

(JSC::LinkBuffer::dumpCode):

14:06 Changeset [110604] by benjamin@webkit.org
  • 4 edits in trunk/Source/WebKit/qt

Attempt to fix QtMinimal bot after r110595

Blind fix, unreviewed.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-13

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::resetGeolocationMock):
(DumpRenderTreeSupportQt::setMockGeolocationPermission):
(DumpRenderTreeSupportQt::setMockGeolocationPosition):
(DumpRenderTreeSupportQt::setMockGeolocationError):
(DumpRenderTreeSupportQt::numberOfPendingGeolocationPermissionRequests):

  • WebCoreSupport/GeolocationPermissionClientQt.h:
14:03 Changeset [110603] by philn@webkit.org
  • 6 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r110587.

  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/call-a-constructor-as-a-function-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
14:02 Changeset [110602] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix cast-align GCC warning
https://bugs.webkit.org/show_bug.cgi?id=80790

Reviewed by Dan Bates.

This touches unpackOneRowOfBGRA8ToRGBA8.

  • platform/graphics/GraphicsContext3D.cpp:

(WebCore):

13:59 Changeset [110601] by simon.fraser@apple.com
  • 3 edits in trunk/Source/WebCore

Refactor some code that is used to check whether a layer needs backing store
https://bugs.webkit.org/show_bug.cgi?id=80917

Reviewed by Dean Jackson.

Move some code out of isSimpleContainerCompositingLayer() in two new
methods to make the code more self-descriptive.

No behavior change, so no tests.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintsBoxDecorations):
(WebCore::RenderLayerBacking::paintsChildren):
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):

  • rendering/RenderLayerBacking.h:

(RenderLayerBacking):

13:47 Changeset [110600] by gavinp@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Implement ApplicationCacheHost::canCacheInPageCache() for chromium.
https://bugs.webkit.org/show_bug.cgi?id=80905

Reviewed by Eric Seidel.

This won't cause chrome to use the PageCache, but it will cause our histogram statistics
describing PageCache use to be more accurate.

  • src/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::canCacheInPageCache):

13:30 Changeset [110599] by jchaffraix@webkit.org
  • 8 edits in trunk/LayoutTests

Too many tests (200+ on SL, 80+ on Lion) tests are failing on Mac port
https://bugs.webkit.org/show_bug.cgi?id=80447

Unreviewed test rebaseline after r110072.

  • platform/mac/test_expectations.txt:
  • platform/mac/Skipped:

Moved an entry from test_expectations.txt to Skipped as it was failing differently
that expected (same image, different text baseline).

  • platform/mac/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt:
  • platform/mac/fast/block/lineboxcontain/glyphs-expected.txt:
  • platform/mac/fast/clip/008-expected.txt:
  • platform/mac/fast/forms/input-text-double-click-expected.txt:
  • platform/mac/fast/repaint/overflow-delete-line-expected.txt:

Rebaselined those tests.

13:15 Changeset [110598] by dbates@webkit.org
  • 4 edits
    3 adds in trunk

REGRESSION(r99369): File input button doesn't highlight when pressed
https://bugs.webkit.org/show_bug.cgi?id=79385

Reviewed by Kent Tamura.

Source/WebCore:

Fixes an issue where the file input button doesn't highlight on mouse press.

Currently we always override the active state of the button with whether
a dragged file is being hovered over the file input control (i.e. can the control
receive a dropped file; HTMLInputElement::canReceiveDroppedFiles()).
Instead, we should only override the active state of the button when the state
changes for whether we can receive dropped files (e.g. during a drag) so that
we honor the active state of the button when it is pressed.

Test: fast/forms/file/file-input-pressed-state.html

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::RenderFileUploadControl):
(WebCore::RenderFileUploadControl::updateFromElement):

  • rendering/RenderFileUploadControl.h:

(RenderFileUploadControl):

LayoutTests:

Add test to ensure that the file input button visually changes when pressed.

  • fast/forms/file/file-input-pressed-state-expected.txt: Added.
  • fast/forms/file/file-input-pressed-state.html: Added.
  • platform/mac/fast/forms/file/file-input-pressed-state-expected.png: Added.
13:15 Changeset [110597] by thakis@chromium.org
  • 2 edits in branches/chromium/1025/Source/WebCore

Merge 110499 - [Skia] Release CGImage used to apply color space conversion to SkBitmap
https://bugs.webkit.org/show_bug.cgi?id=80892

Patch by Brian Salomon <bsalomon@google.com> on 2012-03-12
Reviewed by Adam Barth.

Regressions should be covered by any test that does image decode on the mac.

  • platform/image-decoders/skia/ImageDecoderSkia.cpp:

(WebCore::resolveColorSpace):

TBR=abarth@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9689079

13:14 Changeset [110596] by commit-queue@webkit.org
  • 34 edits
    1 add in trunk

[chromium] Use CCOcclusionTracker for draw culling
https://bugs.webkit.org/show_bug.cgi?id=80743

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-13
Reviewed by Adrienne Walker.

Source/WebCore:

In this CL we enable the use of CCOcclusionTracker for draw-side
culling. This means moving from a per-quad culling model to a
per-layer model.

When calculating RenderPasses, we construct the set of passes,
then iterate over layers in front-to-back order. We make
CCQuadCuller instantiable, and pass it to the layer
appendQuads() methods instead of the bare list, where it can
filter quads before the end up in the list.

Covered by existing tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawRenderPass):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:

(WebCore::CCCanvasLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCCanvasLayerImpl.h:

(CCCanvasLayerImpl):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::appendQuads):
(WebCore::CCLayerImpl::appendGutterQuads):
(WebCore::CCLayerImpl::appendDebugBorderQuad):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore):
(CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::drawLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:

(WebCore::CCPluginLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCPluginLayerImpl.h:

(CCPluginLayerImpl):

  • platform/graphics/chromium/cc/CCQuadCuller.cpp:

(WebCore::CCQuadCuller::CCQuadCuller):
(WebCore::CCQuadCuller::append):

  • platform/graphics/chromium/cc/CCQuadCuller.h:

(WebCore):
(CCQuadCuller):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::appendQuadsForLayer):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(WebCore):
(CCQuadList):
(WebCore::CCQuadList::backToFrontBegin):
(WebCore::CCQuadList::backToFrontEnd):
(CCRenderPass):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:

(WebCore::CCScrollbarLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:

(CCScrollbarLayerImpl):

  • platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp:

(WebCore::CCSolidColorLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCSolidColorLayerImpl.h:

(CCSolidColorLayerImpl):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:

(CCTiledLayerImpl):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:

(CCVideoLayerImpl):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::BlendStateCheckLayer::appendQuads):

  • tests/CCQuadCullerTest.cpp:

(TestCCOcclusionTrackerImpl):
(WebCore::TestCCOcclusionTrackerImpl::TestCCOcclusionTrackerImpl):
(WebCore::TestCCOcclusionTrackerImpl::layerScissorRectInTargetSurface):
(WebCore::makeLayer):
(WebCore::appendQuads):
(WebCore):
(WebCore::TEST):

  • tests/CCSolidColorLayerImplTest.cpp:

(CCLayerTestCommon::TEST):

  • tests/CCTiledLayerImplTest.cpp:

(CCLayerTestCommon::TEST):
(CCLayerTestCommon::getQuads):

  • tests/MockCCQuadCuller.h: Added.

(WebCore):
(MockCCQuadCuller):
(WebCore::MockCCQuadCuller::MockCCQuadCuller):
(WebCore::MockCCQuadCuller::append):
(WebCore::MockCCQuadCuller::quadList):

LayoutTests:

  • platform/chromium-linux/compositing/direct-image-compositing-expected.png:
  • platform/chromium-linux/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-linux/platform/chromium/compositing/huge-layer-rotated-expected.png:
  • platform/chromium/test_expectations.txt:
13:10 Changeset [110595] by benjamin@webkit.org
  • 90 edits
    4 deletes in trunk

Always enable ENABLE(CLIENT_BASED_GEOLOCATION)
https://bugs.webkit.org/show_bug.cgi?id=78853

Patch by Adam Barth <abarth@webkit.org> && Benjamin Poulain <bpoulain@apple.com> on 2012-03-13
Reviewed by Adam Barth.

.:

  • Source/cmake/OptionsBlackBerry.cmake:
  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsWinCE.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:
  • wtf/Platform.h:

Source/WebCore:

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • Modules/geolocation/Geolocation.cpp:

(WebCore):
(WebCore::createPositionError):
(WebCore::Geolocation::Geolocation):
(WebCore::Geolocation::stop):
(WebCore::Geolocation::lastPosition):
(WebCore::Geolocation::requestPermission):
(WebCore::Geolocation::startUpdating):
(WebCore::Geolocation::stopUpdating):

  • Modules/geolocation/Geolocation.h:

(WebCore):
(Geolocation):

  • Modules/geolocation/GeolocationController.cpp:
  • Modules/geolocation/GeolocationController.h:
  • Modules/geolocation/GeolocationError.h:
  • Modules/geolocation/GeolocationPosition.h:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • bindings/js/JSGeolocationCustom.cpp:
  • loader/EmptyClients.h:

(EmptyChromeClient):

  • page/ChromeClient.h:

(ChromeClient):

  • page/Page.cpp:

(WebCore::Page::Page):

  • page/Page.h:

(Page):

  • platform/GeolocationService.cpp: Removed.
  • platform/GeolocationService.h: Removed.
  • platform/mock/GeolocationClientMock.cpp:
  • platform/mock/GeolocationClientMock.h:
  • platform/mock/GeolocationServiceMock.cpp: Removed.
  • platform/mock/GeolocationServiceMock.h: Removed.

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

  • WebCoreSupport/AboutDataEnableFeatures.in:
  • WebCoreSupport/ChromeClientBlackBerry.cpp:
  • WebCoreSupport/ChromeClientBlackBerry.h:

(ChromeClientBlackBerry):

  • WebKitSupport/DumpRenderTreeSupport.cpp:

(toGeolocationClientMock):
(DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests):
(DumpRenderTreeSupport::resetGeolocationMock):
(DumpRenderTreeSupport::setMockGeolocationError):
(DumpRenderTreeSupport::setMockGeolocationPermission):
(DumpRenderTreeSupport::setMockGeolocationPosition):

Source/WebKit/chromium:

  • features.gypi:
  • src/ChromeClientImpl.cpp:
  • src/ChromeClientImpl.h:

(ChromeClientImpl):

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore):

  • WebCoreSupport/ChromeClientEfl.h:

(ChromeClientEfl):

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit):

  • WebCoreSupport/ChromeClientGtk.h:

(WebKit::ChromeClient::scrollRectIntoView):

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::resetGeolocationClientMock):
(DumpRenderTreeSupportGtk::setMockGeolocationPermission):
(DumpRenderTreeSupportGtk::setMockGeolocationPosition):
(DumpRenderTreeSupportGtk::setMockGeolocationError):
(DumpRenderTreeSupportGtk::numberOfPendingGeolocationPermissionRequests):

  • WebCoreSupport/GeolocationClientGtk.cpp:

(WebKit::GeolocationClient::requestPermission):
(WebKit::GeolocationClient::cancelPermissionRequest):

  • WebCoreSupport/GeolocationClientGtk.h:

(WebKit):

  • webkit/webkitwebview.cpp:

(webkit_web_view_init):

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:
  • WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

  • WebCoreSupport/WebGeolocationClient.mm:

(WebGeolocationClient::lastPosition):

  • WebView/WebGeolocationPosition.mm:

(-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
(core):
(-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):

  • WebView/WebGeolocationPositionInternal.h:
  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _geolocationDidChangePosition:]):
(-[WebView _geolocationDidFailWithError:]):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):

  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(toGeolocationClientMock):
(DumpRenderTreeSupportQt::resetGeolocationMock):
(DumpRenderTreeSupportQt::setMockGeolocationPermission):
(DumpRenderTreeSupportQt::setMockGeolocationPosition):
(DumpRenderTreeSupportQt::setMockGeolocationError):
(DumpRenderTreeSupportQt::numberOfPendingGeolocationPermissionRequests):

  • WebCoreSupport/GeolocationClientQt.h:

(WebCore):

Source/WebKit/win:

  • WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

  • WebCoreSupport/WebGeolocationClient.cpp:

(WebGeolocationClient::lastPosition):

  • WebGeolocationPosition.cpp:

(WebGeolocationPosition::initWithTimestamp):
(core):

  • WebGeolocationPosition.h:

(WebGeolocationPosition):
(WebGeolocationPosition::impl):

  • WebView.cpp:

(WebView::initWithFrame):
(WebView::geolocationDidChangePosition):
(WebView::geolocationDidFailWithError):

Source/WebKit/wince:

  • WebCoreSupport/ChromeClientWinCE.cpp:
  • WebCoreSupport/ChromeClientWinCE.h:

(ChromeClientWinCE):

Source/WebKit/wx:

  • WebKitSupport/ChromeClientWx.cpp:
  • WebKitSupport/ChromeClientWx.h:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
  • WebProcess/Geolocation/WebGeolocationManager.cpp:

(WebKit::WebGeolocationManager::registerWebPage):
(WebKit::WebGeolocationManager::unregisterWebPage):
(WebKit::WebGeolocationManager::didChangePosition):
(WebKit::WebGeolocationManager::didFailToDeterminePosition):

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setGeoLocationPermission):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit):

  • WebProcess/WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

  • WebProcess/WebCoreSupport/WebGeolocationClient.cpp:
  • WebProcess/WebCoreSupport/WebGeolocationClient.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

  • mac/WebKit2.order:

Tools:

  • Scripts/build-webkit:
  • qmake/mkspecs/features/features.prf:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
13:05 Changeset [110594] by tonikitoo@webkit.org
  • 29 edits in trunk

Convert nodesFromRect tests to use Internals interface
https://bugs.webkit.org/show_bug.cgi?id=80886

Reviewed by Ryosuke Niwa.
Patch by Antonio Gomes <agomes@rim.com>

Source/WebCore:

Add Internals::nodesFromRect implementation to unify
the codepath for testing Document::nodesFromRect in a
cross port way.

No new tests, since we are improving here the infra-structure
for testing a specific method.

  • testing/Internals.cpp:

(WebCore::Internals::nodesFromRect):
(WebCore):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit/gtk:

Removed DRTSupportGtk::nodesFromRect support, since
it can work in the cross-port way through the
Internals interface.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Source/WebKit/mac:

Removed mac specific support for nodesFromRect for testing purposes only,
since it can work in a cross-port way through the Internals interface.

  • WebKit.order:
  • WebView/WebView.mm:
  • WebView/WebViewPrivate.h:

Source/WebKit/qt:

Removed DRTSupportQt::nodesFromRect support, since
it can work in the cross-port way through the
Internals interface.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

This clean up allows to remove port specific bits of each
DRT implementation that supports testing Document::nodesFromRect,
in favor of making use of the 'Internals' interface to test it.

This makes its code conveniently more expansible and cleaner.

Also removed stubs from Win and EFL, Wn and BlackBerry DRTs.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  • DumpRenderTree/qt/LayoutTestControllerQt.h:

(LayoutTestController):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

LayoutTests:

Adjust nodesFromRect tests to use Internals
instead of LayoutTestController interface.

  • fast/dom/resources/nodesFromRect.js:

(check):

12:48 Changeset [110593] by schenney@chromium.org
  • 5 edits
    3 adds in trunk

Fix the use of stale text fragments
https://bugs.webkit.org/show_bug.cgi?id=80729

Patch by Philip Rogers <pdr@google.com> on 2012-03-13
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Previously, we were allowing SVGTextFragments to get out of sync with the
actual text in RenderSVGInlineTextBox. This patch reuses the dirty line
box code in RenderText::setTextWithOffset to force
clearTextFragments() when setTextWithOffset is called, preventing the use
of stale SVGTextFragments.

Test: svg/custom/delete-text-crash.html

  • rendering/InlineBox.h:

(InlineBox):

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::dirtyLineBoxes):
(WebCore):

  • rendering/svg/SVGInlineTextBox.h:

(SVGInlineTextBox):

LayoutTests:

  • svg/custom/delete-text-crash-expected.png: Added.
  • svg/custom/delete-text-crash-expected.txt: Added.
  • svg/custom/delete-text-crash.html: Added.
12:33 Changeset [110592] by ojan@chromium.org
  • 4 edits
    6 copies
    30 adds in trunk/LayoutTests

Fix some broken layout test rebaselines from the various chromium-lion
rebaselining patches. The bugs in the rebaseline tool that caused the breakages
are now fixed.

  • platform/chromium-mac-leopard/css2.1/t1202-counter-04-b-expected.txt: Added.
  • platform/chromium-mac-leopard/css2.1/t1202-counters-04-b-expected.txt: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/paste-table-cells-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/basic/014-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/basic/020-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/dynamic-unfloat-pref-width-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-mac-leopard/fast/block/margin-collapse/044-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-mac-leopard/fast/block/margin-collapse/045-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/positioning/054-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/pseudo-element-line-break-expected.png: Added.
  • platform/chromium-mac-leopard/fast/events/onload-re-entry-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/disabled-select-change-index-expected.txt:
  • platform/chromium-mac-leopard/fast/forms/select-writing-direction-natural-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/select-writing-direction-natural-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/inline/002-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-mac-leopard/fast/inline/vertical-align-text-bottom-expected.png: Added.
  • platform/chromium-mac-leopard/fast/invalid/002-expected.png: Added.
  • platform/chromium-mac-leopard/fast/invalid/005-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-mac-leopard/fast/invalid/007-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-mac-leopard/fast/invalid/020-expected.png: Added.
  • platform/chromium-mac-leopard/fast/invalid/missing-end-tag-expected.png: Added.
  • platform/chromium-mac-leopard/fast/lists/006-expected.png: Added.
  • platform/chromium-mac-leopard/fast/loader/text-document-wrapping-expected.png: Added.
  • platform/chromium-mac-leopard/fast/parser/tabs-in-scripts-expected.png: Added.
  • platform/chromium-mac-leopard/fast/parser/xhtml-alternate-entities-expected.png: Added.
  • platform/chromium-mac-leopard/fast/replaced/three-selects-break-expected.png: Added.
  • platform/chromium-mac-leopard/fast/selectors/002-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/001-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/010-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/013-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/015-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-mac-leopard/fast/table/022-expected.png: Added.
  • platform/chromium-mac-leopard/scrollbars/basic-scrollbar-expected.png: Added.
  • platform/chromium-mac-leopard/scrollbars/disabled-scrollbar-expected.png: Added.
  • platform/chromium-mac-leopard/scrollbars/scrollbar-buttons-expected.png: Added.
  • platform/chromium-mac-leopard/scrollbars/scrollbar-orientation-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/chromium/test_expectations.txt:
12:27 Changeset [110591] by zimmermann@webkit.org
  • 4 edits in trunk/Source/WebCore

SVG Animations update baseVal instead of animVal
https://bugs.webkit.org/show_bug.cgi?id=12437

Reviewed by Dirk Schulze.

Blind fix for some GC related assertions firing on v8.

Assure that animationStarted/animationEnded calls are happening
on the same SVGAnimatedProperty. Always call animationEnded(),
even if we shouldn't do anything for the target element, as its
destructed, as we still have to reset m_isAnimating.

  • svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::SVGAnimateElement):
(WebCore::SVGAnimateElement::resetToBaseValue):
(WebCore::SVGAnimateElement::targetElementWillChange):

  • svg/SVGAnimateElement.h:

(SVGAnimateElement):

  • svg/properties/SVGAnimatedPropertyTearOff.h:

(WebCore::SVGAnimatedPropertyTearOff::animationEnded):

12:19 Changeset [110590] by ojan@chromium.org
  • 208 edits
    137 copies
    56 moves
    97 adds
    8 deletes in trunk/LayoutTests

Chromium-Lion rebaselines.

12:12 Changeset [110589] by commit-queue@webkit.org
  • 12 edits
    13 moves in trunk/Source/WebCore

Move DirectoryEntry and DirectoryReader to new Modules/filesystem/ directory
https://bugs.webkit.org/show_bug.cgi?id=80625

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-03-13
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • Modules/filesystem: Added.
  • Modules/filesystem/DirectoryEntry.cpp: Copied from Source/WebCore/fileapi/DirectoryEntry.cpp.
  • Modules/filesystem/DirectoryEntry.h: Copied from Source/WebCore/fileapi/DirectoryEntry.h.
  • Modules/filesystem/DirectoryEntry.idl: Copied from Source/WebCore/fileapi/DirectoryEntry.idl.
  • Modules/filesystem/DirectoryEntrySync.cpp: Copied from Source/WebCore/fileapi/DirectoryEntrySync.cpp.
  • Modules/filesystem/DirectoryEntrySync.h: Copied from Source/WebCore/fileapi/DirectoryEntrySync.h.
  • Modules/filesystem/DirectoryEntrySync.idl: Copied from Source/WebCore/fileapi/DirectoryEntrySync.idl.
  • Modules/filesystem/DirectoryReader.cpp: Copied from Source/WebCore/fileapi/DirectoryReader.cpp.
  • Modules/filesystem/DirectoryReader.h: Copied from Source/WebCore/fileapi/DirectoryReader.h.
  • Modules/filesystem/DirectoryReader.idl: Copied from Source/WebCore/fileapi/DirectoryReader.idl.
  • Modules/filesystem/DirectoryReaderBase.h: Copied from Source/WebCore/fileapi/DirectoryReaderBase.h.
  • Modules/filesystem/DirectoryReaderSync.cpp: Copied from Source/WebCore/fileapi/DirectoryReaderSync.cpp.
  • Modules/filesystem/DirectoryReaderSync.h: Copied from Source/WebCore/fileapi/DirectoryReaderSync.h.
  • Modules/filesystem/DirectoryReaderSync.idl: Copied from Source/WebCore/fileapi/DirectoryReaderSync.idl.
  • Target.pri:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • fileapi/DirectoryEntry.cpp: Removed.
  • fileapi/DirectoryEntry.h: Removed.
  • fileapi/DirectoryEntry.idl: Removed.
  • fileapi/DirectoryEntrySync.cpp: Removed.
  • fileapi/DirectoryEntrySync.h: Removed.
  • fileapi/DirectoryEntrySync.idl: Removed.
  • fileapi/DirectoryReader.cpp: Removed.
  • fileapi/DirectoryReader.h: Removed.
  • fileapi/DirectoryReader.idl: Removed.
  • fileapi/DirectoryReaderBase.h: Removed.
  • fileapi/DirectoryReaderSync.cpp: Removed.
  • fileapi/DirectoryReaderSync.h: Removed.
  • fileapi/DirectoryReaderSync.idl: Removed.
12:06 Changeset [110588] by igor.o@sisa.samsung.com
  • 9 edits
    4 adds in trunk

animation-iteration-count does not handle floating point values correctly.
https://bugs.webkit.org/show_bug.cgi?id=69531

Source/WebCore:

Implements support for non-integers animation-iteration-count numbers.
Non-integer numbers will cause the animation to end part-way through a cycle.

Reviewed by Dean Jackson.

Tests: animations/fill-mode-iteration-count-non-integer.html

animations/keyframes-iteration-count-non-integer.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseAnimationIterationCount):

  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::fractionalTime):
(WebCore::AnimationBase::progress):

  • page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::pauseAnimationAtTime):

  • platform/animation/Animation.h:

(WebCore::Animation::iterationCount):
(WebCore::Animation::setIterationCount):
(Animation):
(WebCore::Animation::initialAnimationIterationCount):

LayoutTests:

Reviewed by Dean Jackson.

  • animations/fill-mode-iteration-count-non-integer-expected.txt: Added.
  • animations/fill-mode-iteration-count-non-integer.html: Added.
  • animations/keyframes-iteration-count-non-integer-expected.txt: Added.
  • animations/keyframes-iteration-count-non-integer.html: Added.
11:51 Changeset [110587] by tommyw@google.com
  • 25 edits
    10 moves in trunk

MediaStream API: Rename PeerConnection to DeprecatedPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=80692

Reviewed by Adam Barth.

First patch in a series of patches to change the PeerConnection from ROAP to JSEP,
see bug 80589 for more information.

Source/WebCore:

Patch covered by modified existing tests.

  • GNUmakefile.list.am:
  • Modules/mediastream/DOMWindowMediaStream.idl:
  • Modules/mediastream/DeprecatedPeerConnection.cpp: Renamed from Source/WebCore/Modules/mediastream/PeerConnection.cpp.

(WebCore):
(WebCore::DeprecatedPeerConnection::create):
(WebCore::DeprecatedPeerConnection::DeprecatedPeerConnection):
(WebCore::DeprecatedPeerConnection::~DeprecatedPeerConnection):
(WebCore::DeprecatedPeerConnection::processSignalingMessage):
(WebCore::DeprecatedPeerConnection::readyState):
(WebCore::DeprecatedPeerConnection::send):
(WebCore::DeprecatedPeerConnection::addStream):
(WebCore::DeprecatedPeerConnection::removeStream):
(WebCore::DeprecatedPeerConnection::localStreams):
(WebCore::DeprecatedPeerConnection::remoteStreams):
(WebCore::DeprecatedPeerConnection::close):
(WebCore::DeprecatedPeerConnection::didCompleteICEProcessing):
(WebCore::DeprecatedPeerConnection::didGenerateSDP):
(WebCore::DeprecatedPeerConnection::didReceiveDataStreamMessage):
(WebCore::DeprecatedPeerConnection::didAddRemoteStream):
(WebCore::DeprecatedPeerConnection::didRemoveRemoteStream):
(WebCore::DeprecatedPeerConnection::interfaceName):
(WebCore::DeprecatedPeerConnection::scriptExecutionContext):
(WebCore::DeprecatedPeerConnection::stop):
(WebCore::DeprecatedPeerConnection::eventTargetData):
(WebCore::DeprecatedPeerConnection::ensureEventTargetData):
(WebCore::DeprecatedPeerConnection::scheduleInitialNegotiation):
(WebCore::DeprecatedPeerConnection::initialNegotiationTimerFired):
(WebCore::DeprecatedPeerConnection::ensureStreamChangeScheduled):
(WebCore::DeprecatedPeerConnection::streamChangeTimerFired):
(WebCore::DeprecatedPeerConnection::scheduleReadyStateChange):
(WebCore::DeprecatedPeerConnection::readyStateChangeTimerFired):
(WebCore::DeprecatedPeerConnection::changeReadyState):

  • Modules/mediastream/DeprecatedPeerConnection.h: Renamed from Source/WebCore/Modules/mediastream/PeerConnection.h.

(WebCore):
(DeprecatedPeerConnection):
(WebCore::DeprecatedPeerConnection::didChangeState):
(WebCore::DeprecatedPeerConnection::refEventTarget):
(WebCore::DeprecatedPeerConnection::derefEventTarget):

  • Modules/mediastream/DeprecatedPeerConnection.idl: Renamed from Source/WebCore/Modules/mediastream/PeerConnection.idl.
  • Modules/mediastream/SignalingCallback.h:

(WebCore):
(SignalingCallback):

  • Modules/mediastream/SignalingCallback.idl:
  • WebCore.gypi:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitDeprecatedPeerConnectionEnabled):

  • bindings/js/JSDeprecatedPeerConnectionCustom.cpp: Renamed from Source/WebCore/bindings/js/JSPeerConnectionCustom.cpp.

(WebCore):
(WebCore::JSDeprecatedPeerConnectionConstructor::constructJSDeprecatedPeerConnection):

  • dom/EventTarget.h:

(WebCore):

  • dom/EventTargetFactory.in:
  • platform/mediastream/DeprecatedPeerConnectionHandler.h: Renamed from Source/WebCore/platform/mediastream/PeerConnectionHandler.h.

(WebCore):
(DeprecatedPeerConnectionHandler):

  • platform/mediastream/DeprecatedPeerConnectionHandlerClient.h: Renamed from Source/WebCore/platform/mediastream/PeerConnectionHandlerClient.h.

(WebCore):
(DeprecatedPeerConnectionHandlerClient):
(WebCore::DeprecatedPeerConnectionHandlerClient::~DeprecatedPeerConnectionHandlerClient):

  • platform/mediastream/gstreamer/DeprecatedPeerConnectionHandler.cpp: Renamed from Source/WebCore/platform/mediastream/gstreamer/PeerConnectionHandler.cpp.

(WebCore):
(WebCore::DeprecatedPeerConnectionHandler::create):
(WebCore::DeprecatedPeerConnectionHandler::DeprecatedPeerConnectionHandler):
(WebCore::DeprecatedPeerConnectionHandler::~DeprecatedPeerConnectionHandler):
(WebCore::DeprecatedPeerConnectionHandler::produceInitialOffer):
(WebCore::DeprecatedPeerConnectionHandler::handleInitialOffer):
(WebCore::DeprecatedPeerConnectionHandler::processSDP):
(WebCore::DeprecatedPeerConnectionHandler::processPendingStreams):
(WebCore::DeprecatedPeerConnectionHandler::sendDataStreamMessage):
(WebCore::DeprecatedPeerConnectionHandler::stop):

Source/WebKit/chromium:

  • WebKit.gyp:
  • bridge/DeprecatedPeerConnectionHandler.cpp: Renamed from Source/WebKit/chromium/bridge/PeerConnectionHandler.cpp.

(WebCore):
(WebCore::DeprecatedPeerConnectionHandler::create):
(WebCore::DeprecatedPeerConnectionHandler::DeprecatedPeerConnectionHandler):
(WebCore::DeprecatedPeerConnectionHandler::~DeprecatedPeerConnectionHandler):
(WebCore::DeprecatedPeerConnectionHandler::produceInitialOffer):
(WebCore::DeprecatedPeerConnectionHandler::handleInitialOffer):
(WebCore::DeprecatedPeerConnectionHandler::processSDP):
(WebCore::DeprecatedPeerConnectionHandler::processPendingStreams):
(WebCore::DeprecatedPeerConnectionHandler::sendDataStreamMessage):
(WebCore::DeprecatedPeerConnectionHandler::stop):

  • bridge/DeprecatedPeerConnectionHandlerInternal.cpp: Renamed from Source/WebKit/chromium/bridge/PeerConnectionHandlerInternal.cpp.

(WebCore):
(WebCore::DeprecatedPeerConnectionHandlerInternal::DeprecatedPeerConnectionHandlerInternal):
(WebCore::DeprecatedPeerConnectionHandlerInternal::~DeprecatedPeerConnectionHandlerInternal):
(WebCore::DeprecatedPeerConnectionHandlerInternal::produceInitialOffer):
(WebCore::DeprecatedPeerConnectionHandlerInternal::handleInitialOffer):
(WebCore::DeprecatedPeerConnectionHandlerInternal::processSDP):
(WebCore::DeprecatedPeerConnectionHandlerInternal::processPendingStreams):
(WebCore::DeprecatedPeerConnectionHandlerInternal::sendDataStreamMessage):
(WebCore::DeprecatedPeerConnectionHandlerInternal::stop):
(WebCore::DeprecatedPeerConnectionHandlerInternal::didCompleteICEProcessing):
(WebCore::DeprecatedPeerConnectionHandlerInternal::didGenerateSDP):
(WebCore::DeprecatedPeerConnectionHandlerInternal::didReceiveDataStreamMessage):
(WebCore::DeprecatedPeerConnectionHandlerInternal::didAddRemoteStream):
(WebCore::DeprecatedPeerConnectionHandlerInternal::didRemoveRemoteStream):

  • bridge/DeprecatedPeerConnectionHandlerInternal.h: Renamed from Source/WebKit/chromium/bridge/PeerConnectionHandlerInternal.h.

(WebKit):
(WebCore):
(DeprecatedPeerConnectionHandlerInternal):

LayoutTests:

  • fast/dom/call-a-constructor-as-a-function.html:
  • fast/mediastream/peerconnection-Attributes-expected.txt:
  • fast/mediastream/peerconnection-addstream-expected.txt:
  • fast/mediastream/peerconnection-argument-types-expected.txt:
  • fast/mediastream/peerconnection-eventlistener-optional-argument.html:
  • fast/mediastream/peerconnection-mediastreamlist.html:
  • fast/mediastream/peerconnection-removestream-expected.txt:
  • fast/mediastream/script-tests/Attributes.js:
  • fast/mediastream/script-tests/argument-types.js:
  • fast/mediastream/script-tests/peerconnection-addstream.js:
  • fast/mediastream/script-tests/peerconnection-removestream.js:
  • platform/chromium/fast/dom/call-a-constructor-as-a-function-expected.txt:
  • platform/gtk/fast/dom/call-a-constructor-as-a-function-expected.txt:
11:49 Changeset [110586] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Remove a nonexistent WebUIDelegate method from WebUIDelegatePrivate.h
https://bugs.webkit.org/show_bug.cgi?id=81014

Reviewed by Sam Weinig.

Remove a plug-in halter related WebUIDelegate method.

  • WebView/WebUIDelegatePrivate.h:
11:34 Changeset [110585] by ojan@chromium.org
  • 6 edits in trunk/Tools

Rebaselining for a new port doesn't work right with multiple fallback ports
https://bugs.webkit.org/show_bug.cgi?id=80932

Reviewed by Adam Barth.

Since chromium-leopard also falls back to mac-leopard, we need to
copy the existing result for both chromium-leopard and chromium-snowleopard
before doing lion rebaselines.

  • Scripts/webkitpy/layout_tests/port/builders.py:

(fallback_port_names_for_new_port):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineTest):
(RebaselineTest._copy_existing_baseline):
(RebaselineTest._rebaseline_test):
(RebaselineTest.execute):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  • Scripts/webkitpy/tool/servers/gardeningserver.py:

(GardeningHTTPRequestHandler.rebaseline):

  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:

(GardeningServerTest.test_rebaseline_new_port):

11:21 Changeset [110584] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: front-end compilation was broken while supporting large arrays.
https://bugs.webkit.org/show_bug.cgi?id=81013

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/ExtensionPanel.js:
  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ArrayGroupingTreeElement._populateNonIndexProperties.buildObjectFragment):

  • inspector/front-end/RemoteObject.js:
11:17 Changeset [110583] by tony@chromium.org
  • 7 edits
    2 adds in trunk

flexbox's computePreferredLogicalWidth needs to take multiline into account
https://bugs.webkit.org/show_bug.cgi?id=80931

Reviewed by Ojan Vafai.

Source/WebCore:

Tests: css3/flexbox/multiline-shrink-to-fit-expected.html

css3/flexbox/multiline-shrink-to-fit.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computePreferredLogicalWidths): Set min/max preferredLogicalWidth based on always breaking or never breaking.
(WebCore::RenderFlexibleBox::computeNextFlexLine): Add a FIXME.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Don't change the width after computePreferredWidth has been called.

LayoutTests:

  • css3/flexbox/cross-axis-scrollbar.html:
  • css3/flexbox/multiline-align.html:
  • css3/flexbox/multiline-pack.html:
  • css3/flexbox/multiline-shrink-to-fit-expected.html: Added.
  • css3/flexbox/multiline-shrink-to-fit.html: Added.
  • css3/flexbox/multiline.html:
11:10 Changeset [110582] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Remove SlotVisitor::copy() method.
https://bugs.webkit.org/show_bug.cgi?id=80973

Patch by Kwonjin Jeong <gram@company100.net> on 2012-03-13
Reviewed by Geoffrey Garen.

SlotVisitor::copy() method isn't called anywhere.

  • heap/MarkStack.cpp: Remove definition of SlotVisitor::copy() method.
  • heap/SlotVisitor.h: Remove declaration of SlotVisitor::copy() method.
11:05 Changeset [110581] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

Unreviewed, rolling out r110469.
http://trac.webkit.org/changeset/110469
https://bugs.webkit.org/show_bug.cgi?id=81010

This patch still appears to crash (Requested by abarth on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-13

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::repaintContentRectangle):
(WebCore):
(WebCore::FrameView::endDeferredRepaints):
(WebCore::FrameView::doDeferredRepaints):
(WebCore::FrameView::deferredRepaintTimerFired):

  • page/FrameView.h:

(FrameView):

  • rendering/RenderView.cpp:

(WebCore::RenderView::shouldRepaint):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawSVGToImageBuffer):
(WebCore::SVGImage::draw):

  • svg/graphics/SVGImage.h:
  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::imageContentChanged):
(WebCore::SVGImageCache::redrawTimerFired):

  • svg/graphics/SVGImageCache.h:

(SVGImageCache):

11:02 Changeset [110580] by commit-queue@webkit.org
  • 11 edits
    2 adds in trunk

Add a method to window.internals to enable testing of inspector highlight rects
https://bugs.webkit.org/show_bug.cgi?id=80338

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-03-13
Reviewed by Pavel Feldman.

.:

  • Source/autotools/symbols.filter: Export symbols for GTK.

Source/WebCore:

Add window.internals.inspectorHighlightRects, a method which makes it possible to test the
positions and sizes of inspector highlight rects.

Test: inspector/elements/highlight-node.html

  • WebCore.exp.in: Export symbols.
  • testing/Internals.cpp:

(WebCore::Internals::inspectorHighlightRects): Call InspectorController::getHighlight and
return the highlight's quads as a ClientRectList.
(WebCore):

  • testing/Internals.h:

(WebCore):
(Internals):

  • testing/Internals.idl:

Add inspectorHighlightRects to the window.internals interface.

Source/WebKit2:

  • win/WebKit2.def: Export symbols for win.
  • win/WebKit2CFLite.def: Same as above.

LayoutTests:

  • inspector/elements/highlight-node-expected.txt: Added.
  • inspector/elements/highlight-node.html: Added.
10:57 Changeset [110579] by mitz@apple.com
  • 2 edits in trunk/Websites/webkit.org

Working With Code > Installing Developer Tools needs to be updated with OS X Lion & App Store details
https://bugs.webkit.org/show_bug.cgi?id=80429

Patch by Rebecca Hauck <rhauck@adobe.com> on 2012-03-13
Reviewed by Dan Bernstein.

  • building/tools.html:
10:30 Changeset [110578] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Remove sublayers before clamping just in case the layer already exists
https://bugs.webkit.org/show_bug.cgi?id=80989

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-03-13
Reviewed by Antonio Gomes.

Discovered when trying to add a highlight sublayer for web inspector. Since that layer
may already exist in the tree we need to see if it will be pruned before we clamp on the
size.

This was manually tested during the writing of another patch to add web inspector highlights
to accelrated compositing.

  • platform/graphics/blackberry/LayerWebKitThread.cpp:

(WebCore::LayerWebKitThread::insertSublayer):

10:25 Changeset [110577] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Note that fast/loader/window-properties-restored-from-page-cache.html
depends on the page cache.

  • platform/chromium/test_expectations.txt:
09:37 Changeset [110576] by vsevik@chromium.org
  • 9 edits
    3 adds in trunk

Web Inspector: Add snippets model.
https://bugs.webkit.org/show_bug.cgi?id=80863

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/debugger/snippets-model.html

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/SnippetsModel.js: Added.
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

LayoutTests:

  • inspector/debugger/snippets-model-expected.txt: Added.
  • inspector/debugger/snippets-model.html: Added.
09:33 Changeset [110575] by vestbo@webkit.org
  • 3 edits in trunk/Tools

[Qt] Tweak minibrowser UI

Add some margins to the scroll indicators, and set a dark background
color so you see the page dimensions.

Reviewed by Antonio Gomes.

09:11 Changeset [110574] by zimmermann@webkit.org
  • 111 edits in trunk/LayoutTests

[Qt] svg/animations tests are very flaky
https://bugs.webkit.org/show_bug.cgi?id=80703

Reviewed by Rob Buis.

Overhaul the svg/animation frameworks, to be more stable.
Especially discrete animations were flaky on Qt, because some tests still sampled
at integral times like 2.0s, instead of 1.999s (before change), and 2.001s (after change).

Always use shouldBeCloseEnough() when comparing font-sizes/color values/, as there's
always an uncertainity about the actual sampling time (low but may lead to 40.01px values, instead of 40px).

This makes these tests also stable in Firefox/Opera, which was the ultimate goal!

  • platform/qt/Skipped: Unskip svg/animation tests.
  • svg/animations/additive-values-width-animation-expected.txt:
  • svg/animations/animate-color-calcMode-discrete-expected.txt:
  • svg/animations/animate-color-fill-currentColor-expected.txt:
  • svg/animations/animate-color-fill-from-by-expected.txt:
  • svg/animations/animate-color-rgba-calcMode-discrete-expected.txt:
  • svg/animations/animate-color-transparent-expected.txt:
  • svg/animations/animate-currentColor-expected.txt:
  • svg/animations/animate-dynamic-update-attributeName-expected.txt:
  • svg/animations/animate-elem-03-t-drt-expected.txt:
  • svg/animations/animate-end-attribute-expected.txt:
  • svg/animations/animate-from-to-keyTimes-expected.txt:
  • svg/animations/animate-inherit-css-property-expected.txt:
  • svg/animations/animate-keySplines-expected.txt:
  • svg/animations/animate-number-calcMode-discrete-expected.txt:
  • svg/animations/animate-number-calcMode-discrete-keyTimes-expected.txt:
  • svg/animations/attributeTypes-expected.txt:
  • svg/animations/resources/SVGAnimationTestCase.js:

(expectColor):
(expectFillColor):
(moveAnimationTimelineAndSample):

  • svg/animations/script-tests/additive-values-width-animation.js:

(executeTest):

  • svg/animations/script-tests/animVal-basics.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/animate-calcMode-spline-by.js:

(sample1):
(executeTest):

  • svg/animations/script-tests/animate-calcMode-spline-from-by.js:

(sample1):
(executeTest):

  • svg/animations/script-tests/animate-calcMode-spline-from-to.js:

(sample1):
(executeTest):

  • svg/animations/script-tests/animate-calcMode-spline-to.js:

(sample1):
(executeTest):

  • svg/animations/script-tests/animate-calcMode-spline-values.js:

(sample1):
(executeTest):

  • svg/animations/script-tests/animate-color-calcMode-discrete.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/animate-color-fill-currentColor.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/animate-color-fill-from-by.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/animate-color-rgba-calcMode-discrete.js:

(parseAlphaFromColor):
(red):

  • svg/animations/script-tests/animate-color-transparent.js:

(expectTransparent):
(expectOtherColor):

  • svg/animations/script-tests/animate-currentColor.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/animate-dynamic-update-attributeName.js:

(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):

  • svg/animations/script-tests/animate-elem-03-t-drt.js:

(parseFontSizeFromString):
(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/animate-end-attribute.js:

(sample1):
(sample2):

  • svg/animations/script-tests/animate-endElement-beginElement.js:

(sample1):

  • svg/animations/script-tests/animate-from-to-keyTimes.js:
  • svg/animations/script-tests/animate-gradient-transform.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/animate-inherit-css-property.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/animate-insert-begin.js:

(sample1):
(sample2):

  • svg/animations/script-tests/animate-insert-no-begin.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/animate-keySplines.js:

(sample3):
(sample4):
(executeTest):

  • svg/animations/script-tests/animate-number-calcMode-discrete-keyTimes.js:

(executeTest):

  • svg/animations/script-tests/animate-number-calcMode-discrete.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/animate-path-animation-Cc-Ss.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/animate-path-animation-Ll-Vv-Hh.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/animate-path-animation-Qq-Tt.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/animate-path-animation-cC-sS-inverse.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/animate-path-animation-lL-vV-hH-inverse.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/animate-path-animation-qQ-tT-inverse.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/animate-path-to-animation.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/animateTransform-pattern-transform.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/attributeTypes.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/multiple-animations-fill-freeze.js:

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(sample6):
(sample7):
(sample8):

  • svg/animations/script-tests/svgPreserveAspectRatio-animation-1.js:

(executeTest):

  • svg/animations/script-tests/svgangle-animation-deg-to-grad.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgangle-animation-deg-to-rad.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgangle-animation-grad-to-deg.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgangle-animation-grad-to-rad.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgangle-animation-rad-to-deg.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgangle-animation-rad-to-grad.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgboolean-animation-1.js:

(executeTest):

  • svg/animations/script-tests/svginteger-animation-1.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglength-animation-LengthModeHeight.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglength-animation-LengthModeOther.js:

(sample1):
(executeTest):

  • svg/animations/script-tests/svglength-animation-LengthModeWidth.js:

(sample1):
(executeTest):

  • svg/animations/script-tests/svglength-animation-invalid-value-1.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglength-animation-invalid-value-2.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglength-animation-invalid-value-3.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglength-animation-number-to-number.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglength-animation-px-to-cm.js:

(sample1):
(executeTest):

  • svg/animations/script-tests/svglength-animation-px-to-ems.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglength-animation-px-to-exs.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglength-animation-px-to-in.js:

(sample1):
(executeTest):

  • svg/animations/script-tests/svglength-animation-px-to-number.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglength-animation-px-to-pc.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglength-animation-px-to-percentage.js:

(sample1):
(executeTest):

  • svg/animations/script-tests/svglength-animation-px-to-pt.js:

(sample1):
(executeTest):

  • svg/animations/script-tests/svglength-animation-px-to-px.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglength-animation-unitType.js:

(executeTest):

  • svg/animations/script-tests/svglength-animation-values.js:

(sample1):
(sample2):
(sample4):
(executeTest):

  • svg/animations/script-tests/svglengthlist-animation-1.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglengthlist-animation-2.js:

(sample1):
(executeTest):

  • svg/animations/script-tests/svglengthlist-animation-3.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglengthlist-animation-4.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglengthlist-animation-5.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgnumber-animation-1.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/svgnumber-animation-2.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/svgnumber-animation-3.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/svgnumberlist-animation-1.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgnumberlist-animation-2.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgnumberoptionalnumber-animation-1.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgnumberoptionalnumber-animation-2.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgnumberoptionalnumber-animation-3.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgnumberoptionalnumber-animation-4.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgpath-animation-1.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgpointlist-animation-1.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/svgpointlist-animation-2.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/svgrect-animation-1.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgrect-animation-2.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgstring-animation-fallback-to-discrete.js:

(executeTest):

  • svg/animations/script-tests/svgtransform-animation-1.js:

(sample1):
(sample2):

  • svg/animations/script-tests/svgtransform-animation-discrete.js:

(sample1):
(executeTest):

  • svg/animations/svglength-animation-invalid-value-1-expected.txt:
  • svg/animations/svglength-animation-invalid-value-2-expected.txt:
  • svg/animations/svglength-animation-invalid-value-3-expected.txt:
  • svg/animations/svglength-animation-unitType-expected.txt:
  • svg/animations/svgnumber-animation-1-expected.txt:
  • svg/animations/svgnumber-animation-2-expected.txt:
  • svg/animations/svgnumber-animation-3-expected.txt:
  • svg/animations/svgtransform-animation-discrete-expected.txt:
09:08 Changeset [110573] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Not reviewed: chromium build fix.

  • history/CachedFrame.cpp:
09:03 Changeset [110572] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: refactor copy-paste getter methods
https://bugs.webkit.org/show_bug.cgi?id=80923

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-03-13
Reviewed by Yury Semikhatsky.

Several methods are combined in one using C++ templates.

  • inspector/CodeGeneratorInspector.py:
09:00 Changeset [110571] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Fix cast-align warning in QuotesData.cpp
https://bugs.webkit.org/show_bug.cgi?id=80601

Reviewed by Nikolas Zimmermann.

Fix warning by adding variable of correct return type.

  • rendering/style/QuotesData.cpp:

(WebCore::QuotesData::create):

08:57 Changeset [110570] by beidson@apple.com
  • 12 edits
    2 adds in trunk

<rdar://problem/7908830> and https://bugs.webkit.org/show_bug.cgi?id=34679 Location and other objects are dysfunctional after a document gets restored from page cache

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/loader/window-properties-restored-from-page-cache.html

Give DOMWindowProperties the ability to reconnect to their Frame:

  • page/DOMWindowProperty.cpp:

(WebCore::DOMWindowProperty::reconnectFrame):

  • page/DOMWindowProperty.h:

(DOMWindowProperty):

Let ApplicationCache do some extra work when reconnecting:

  • loader/appcache/DOMApplicationCache.cpp:

(WebCore::DOMApplicationCache::reconnectFrame):
(WebCore):

  • loader/appcache/DOMApplicationCache.h:

(DOMApplicationCache):

Let IndexDB do some extra work when reconnecting:

  • Modules/indexeddb/DOMWindowIndexedDatabase.cpp:

(WebCore::DOMWindowIndexedDatabase::disconnectFrame):
(WebCore::DOMWindowIndexedDatabase::reconnectFrame):
(WebCore::DOMWindowIndexedDatabase::webkitIndexedDB):

  • Modules/indexeddb/DOMWindowIndexedDatabase.h:

(DOMWindowIndexedDatabase):

Tell the DOMWindow to suspend to the page cache:

  • history/CachedFrame.cpp:

(WebCore::CachedFrame::CachedFrame):

Tell the DOMWindow to resume from the page cache:

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::open):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::DOMWindow):
(WebCore::DOMWindow::~DOMWindow): Call clearDOMWindowProperties directly instead of clear()
(WebCore::DOMWindow::frameDestroyed): Ditto.
(WebCore::DOMWindow::clear): Only clear if the DOMWindow is not suspended for the page cache.
(WebCore::DOMWindow::suspendForPageCache): Disconnect properties and set the page cache flag.
(WebCore::DOMWindow::resumeFromPageCache): Reconnect properties and revert the page cache flag.
(WebCore::DOMWindow::disconnectDOMWindowProperties): Only disconnect the registered properties.
(WebCore::DOMWindow::reconnectDOMWindowProperties):
(WebCore::DOMWindow::clearDOMWindowProperties): Disconnect the registered properties then clear them out.

For all of the following, if the DOMWindow is not displayed in a frame (i.e., it is suspended), do nothing:
(WebCore::DOMWindow::screen):
(WebCore::DOMWindow::history):
(WebCore::DOMWindow::crypto):
(WebCore::DOMWindow::locationbar):
(WebCore::DOMWindow::menubar):
(WebCore::DOMWindow::personalbar):
(WebCore::DOMWindow::scrollbars):
(WebCore::DOMWindow::statusbar):
(WebCore::DOMWindow::toolbar):
(WebCore::DOMWindow::console):
(WebCore::DOMWindow::applicationCache):
(WebCore::DOMWindow::navigator):
(WebCore::DOMWindow::performance):
(WebCore::DOMWindow::location):
(WebCore::DOMWindow::sessionStorage):
(WebCore::DOMWindow::localStorage):
(WebCore::DOMWindow::webkitNotifications):
(WebCore::DOMWindow::postMessageTimerFired):
(WebCore::DOMWindow::getSelection):
(WebCore::DOMWindow::styleMedia):
(WebCore::DOMWindow::webkitStorageInfo):

  • page/DOMWindow.h:

LayoutTests:

  • fast/loader/window-properties-restored-from-page-cache-expected.txt: Added.
  • fast/loader/window-properties-restored-from-page-cache.html: Added.
08:43 Changeset [110569] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[chromium] Use projectQuad to apply inverse mapRect
https://bugs.webkit.org/show_bug.cgi?id=80741

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-13
Reviewed by Adrienne Walker.

Source/WebCore:

Unit test: CCOcclusionTrackerTest3dTransform

CCOcclusionTrackerTestPerspectiveTransform
CCOcclusionTrackerTestPerspectiveTransformBehindCamera

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::projectQuad):
(WebCore):
(WebCore::computeUnoccludedContentRect):

Source/WebKit/chromium:

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore):
(CCOcclusionTrackerTest3dTransform):
(WebCore::CCOcclusionTrackerTest3dTransform::runMyTest):
(CCOcclusionTrackerTestPerspectiveTransform):
(WebCore::CCOcclusionTrackerTestPerspectiveTransform::runMyTest):
(CCOcclusionTrackerTestPerspectiveTransformBehindCamera):
(WebCore::CCOcclusionTrackerTestPerspectiveTransformBehindCamera::runMyTest):

08:40 Changeset [110568] by commit-queue@webkit.org
  • 7 edits in trunk

[EFL] [DRT] Implement scheduleAsynchronousKeyDown.
https://bugs.webkit.org/show_bug.cgi?id=79601

Patch by ChangSeok Oh <shivamidow@gmail.com> on 2012-03-13
Reviewed by Gustavo Noronha Silva.

Source/WebKit/efl:

Added a new API to deliver all mutations explicitly.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::deliverAllMutationsIfNecessary):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Extracted shareable code from keyDownCallback and then added createKeyEventInfo.
createKeyEventInfo creates a new structure KeyEventInfo that has keyName and modifiers
and is taken over to sendKeyDown.
Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.

  • DumpRenderTree/efl/EventSender.cpp:

(KeyEventInfo::KeyEventInfo):
(KeyEventInfo):
(createKeyEventInfo):
(sendKeyDown):
(keyDownCallback):
(sendAsynchronousKeyDown):
(scheduleAsynchronousKeyDownCallback):

LayoutTests:

Removed following two skipped tests.
fast/mutation/end-of-task-delivery.html
fast/mutation/inline-event-listener.html

  • platform/efl/Skipped:
08:28 Changeset [110567] by gavinp@chromium.org
  • 2 edits in trunk/Source/WebCore

New PageCache histogram which counts failures ignoring Settings.
https://bugs.webkit.org/show_bug.cgi?id=80864

Reviewed by Brady Eidson.

Chrome has a command line switch to turn on the page cache.
Currently it doesn't work, but it can cause the PageCache reasons
for failure count to read lower than it should. Add a new
histogram to report the corrected value.

  • history/PageCache.cpp:

(WebCore::logCanCachePageDecision):

08:24 Changeset [110566] by staikos@webkit.org
  • 3 edits in trunk/Source/WebCore

Fix signed/unsigned mismatch compiler warnings.
https://bugs.webkit.org/show_bug.cgi?id=80790

Reviewed by Alexey Proskuryakov.

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::synchronousLoadDecisionForIconURL):

  • platform/network/MIMESniffing.cpp:
08:21 Changeset [110565] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r110510.
http://trac.webkit.org/changeset/110510
https://bugs.webkit.org/show_bug.cgi?id=80987

depends on chromium r 125700, which isn't rolled into webkit
yet :-/ (Requested by thakis_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-13

  • WebCore.gyp/mac/adjust_visibility.sh:
08:18 Changeset [110564] by gavinp@chromium.org
  • 5 edits in trunk/Source

Make ApplicationCacheHost::canCacheInPageCache() non-const.
https://bugs.webkit.org/show_bug.cgi?id=80904

Reviewed by Alexey Proskuryakov.

A const pointer to a large object like ApplicationCacheHost is not our standard
practice; so remove this (implicit) one. See also https://bugs.webkit.org/show_bug.cgi?id=80898

Source/WebCore:

  • loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::canCacheInPageCache):

  • loader/appcache/ApplicationCacheHost.h:

(ApplicationCacheHost):

Source/WebKit/chromium:

  • src/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::canCacheInPageCache):

08:14 Changeset [110563] by schenney@chromium.org
  • 7 edits
    2 adds in trunk

Crash in WebCore::GraphicsContext::paintingDisabled
https://bugs.webkit.org/show_bug.cgi?id=80669

Reviewed by Nikolas Zimmermann.

Source/WebCore:

The SVGImageBufferTools::clipToImageBuffer method deletes the clip
image when it thinks it is not needed. However, there are cases when
it is in fact still needed, particularly when the clip buffer is
coming from higher up in the stack where it may be needed again.

So this patch adds a flag to only allow deletion of the image buffer
if it was created at the most recent call site.

Tests: svg/custom/circular-clip-path-references-crash-expected.svg

svg/custom/circular-clip-path-references-crash.svg

  • rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::applyClippingToContext):

  • rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::clipToTextMask):

  • rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::applyResource):

  • rendering/svg/SVGImageBufferTools.cpp:

(WebCore::SVGImageBufferTools::clipToImageBuffer):

  • rendering/svg/SVGImageBufferTools.h:

(SVGImageBufferTools):

LayoutTests:

  • svg/custom/circular-clip-path-references-crash-expected.svg: Added.
  • svg/custom/circular-clip-path-references-crash.svg: Added.
08:02 Changeset [110562] by commit-queue@webkit.org
  • 4 edits
    1 delete in trunk/Source/WebKit/blackberry

Remove ActiveNodeContext in favour of BlackBerry::Platform::WebContext
https://bugs.webkit.org/show_bug.cgi?id=80984

Remove ActiveNodeContext, and switch the implementation to
provide a BlackBerry::Platform::WebContext. The new object
adds an explicit IsImage flag, as well as IsAudio and IsVideo
for the HTML5 elements.

Note that for many videos both IsVideo and IsAudio will be true,
as videos typically have audio streams as well.

Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-03-13
Reviewed by George Staikos.

  • Api/ActiveNodeContext.h: Removed.
  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPage::webContext):

  • Api/WebPage.h:
  • Api/WebPage_p.h:
07:57 Changeset [110561] by gavinp@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix an enumeration name in ReasonsFrameCannotBeInPageCache.
https://bugs.webkit.org/show_bug.cgi?id=80849

Reviewed by Brady Eidson.

It seems that somebody goofed, and named one of the
ReasonsFrameCannotBeInPageCache antonymically.

  • history/PageCache.cpp:

(WebCore::logCanCacheFrameDecision):

07:38 Changeset [110560] by kinuko@chromium.org
  • 10 edits in trunk/Source/WebCore

File upload control should use File.name() rather than File.path() to show chosen filenames
https://bugs.webkit.org/show_bug.cgi?id=80970

In some rare cases (e.g. files from FileSystem API or files created
using the newly added WebKit API) File.name has different displayName
from the basename of file.path, and in the file uploader controller we
should use File.name rather than File.path.

Reviewed by Kent Tamura.

No new tests: existing tests should pass as this should not change
behavior in regular use cases. (New behavior where File.name differs
from File.path can be only tested in chromeos environment, therefore
not adding new tests for that)

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::fileListNameForWidth): Updated to handle FileList.

  • platform/gtk/RenderThemeGtk.h:
  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::fileListNameForWidth): Updated to handle FileList.

  • platform/qt/RenderThemeQt.h:
  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::fileTextValue): Changed to pass FileList rather than FileList->paths().

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::fileListNameForWidth): Updated to handle FileList and use File.name for displaying the file name.

  • rendering/RenderTheme.h:
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::fileListNameForWidth): Updated to handle FileList.

07:09 Changeset [110559] by haraken@chromium.org
  • 2 edits in trunk/PerformanceTests

Dromaeo perf-tests results are wrong
https://bugs.webkit.org/show_bug.cgi?id=80974

Reviewed by Hajime Morita.

Dromaeo perf-tests had reported the sum of runs/seconds as "ms".
This patch fixes them to report the execution time per run.

At present, they report "0.0ms" for "stdev". This is because
dromaeorunner.js can just know stdev of "runs/seconds"
and cannot calculate stdev of "ms" from that. We can fix it later.

  • Dromaeo/resources/dromaeorunner.js:

(.):

07:09 Changeset [110558] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Skip some tests until fix.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-03-13
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
07:06 Changeset [110557] by kinuko@chromium.org
  • 13 edits in trunk/Source

Allow WebFileChooser to return extra file info (like displayName) in addition to mere file paths
https://bugs.webkit.org/show_bug.cgi?id=80719

Reviewed by Kent Tamura.

Source/WebCore:

No new tests: this change itself shouldn't change existing behavior.

  • fileapi/File.cpp:

(WebCore::createBlobDataForFileWithName): Renamed from createBlobDataForFileSystemFile.

  • fileapi/File.h:
  • html/FileInputType.cpp:

(WebCore::FileInputType::saveFormControlState): Updated to handle File.name.
(WebCore::FileInputType::restoreFormControlState): Ditto.
(WebCore::FileInputType::setFileList): Changed the signature to take
FileChooserFileInfo.
(WebCore::FileInputType::filesChosen): Ditto.
(WebCore::FileInputType::receiveDroppedFiles):

  • html/FileInputType.h:

(FileInputType):

  • platform/FileChooser.cpp:

(WebCore::FileChooser::chooseFiles): Added an overloaded method that
takes FileChooserFileInfo.
(WebCore):

  • platform/FileChooser.h:

(WebCore::FileChooserFileInfo::FileChooserFileInfo): Added.

  • platform/MIMETypeRegistry.cpp:

(WebCore::MIMETypeRegistry::getWellKnownMIMETypeForExtension): Removed surrouonding ifdefs as this function is now used even if FILE_SYSTEM is not enabled.

  • platform/MIMETypeRegistry.h:

(MIMETypeRegistry):

Source/WebKit/chromium:

  • public/WebFileChooserCompletion.h:

(SelectedFileInfo): Added.
(WebFileChooserCompletion):
(WebKit::WebFileChooserCompletion::didChooseFile): Added an overloaded
method that takes SelectedFileInfo.

  • src/WebFileChooserCompletionImpl.cpp:

(WebKit::WebFileChooserCompletionImpl::didChooseFile): Ditto.
(WebKit):

  • src/WebFileChooserCompletionImpl.h:

(WebFileChooserCompletionImpl):

05:38 Changeset [110556] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/efl

[EFL] Remove a duplicate allocation of matrix entry.
https://bugs.webkit.org/show_bug.cgi?id=79362

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2012-03-13
Reviewed by Zoltan Herczeg.

A matrix entry is created when calling ewk_matrix_new.
Another matrix is created inside ewk_tile_matrix_zoom_level_set.
This patch is for getting rid of a duplicated creation of the matrix.

  • ewk/ewk_tiled_backing_store.cpp:

(_Ewk_Tiled_Backing_Store_Item):
(_ewk_tiled_backing_store_zoom_set_internal):

  • ewk/ewk_tiled_matrix.cpp:

(ewk_tile_matrix_new):
(ewk_tile_matrix_zoom_level_set):
(ewk_tile_matrix_entry_new):
(ewk_tile_matrix_size_get):

  • ewk/ewk_tiled_matrix.h:
05:28 Changeset [110555] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, skipping some more failing tests.

  • platform/chromium/test_expectations.txt:
05:25 Changeset [110554] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed inspector compilation module name fix after r110550.

  • inspector/compile-front-end.py:
05:24 Changeset [110553] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Set correct device width and height.
https://bugs.webkit.org/show_bug.cgi?id=80980

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-13
Reviewed by Tor Arne Vestbø.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewFlickablePrivate::computeViewportConstraints):

03:00 Changeset [110552] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, skip new failing test on GTK.

  • platform/gtk/Skipped:
02:57 Changeset [110551] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, marking a test as fail which needs reaseline.

  • platform/chromium/test_expectations.txt:
02:47 Changeset [110550] by vsevik@chromium.org
  • 2 edits
    1 add in trunk/Source/WebCore

Web Inspector: Changes to the list of scripts for front-end compilation should not require update of number of scripts in module.
https://bugs.webkit.org/show_bug.cgi?id=80872

Reviewed by Pavel Feldman.

  • inspector/compile-front-end.py: Added.
  • inspector/compile-front-end.sh:
02:10 Changeset [110549] by podivilov@chromium.org
  • 7 edits
    1 copy in trunk/Source/WebCore

Web Inspector: move ResourceScriptMapping to a separate file.
https://bugs.webkit.org/show_bug.cgi?id=80859

Reviewed by Vsevolod Vlasov.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.sh:
  • inspector/front-end/ResourceScriptMapping.js: Copied from Source/WebCore/inspector/front-end/ScriptMapping.js.

(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype.uiSourceCodeList):
(WebInspector.ResourceScriptMapping.prototype._handleUISourceCodeListChanged):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeListChanged):
(WebInspector.ResourceScriptMapping.prototype._bindScriptToRawSourceCode):
(WebInspector.ResourceScriptMapping.prototype.setFormatSource):
(WebInspector.ResourceScriptMapping.prototype.forceUpdateSourceMapping):
(WebInspector.ResourceScriptMapping.prototype.reset):

  • inspector/front-end/ScriptMapping.js:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
01:56 Changeset [110548] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, skipping some failing tests.

  • platform/chromium/test_expectations.txt:
01:48 Changeset [110547] by haraken@chromium.org
  • 29 edits
    3 moves in trunk/Source/WebCore

Rename OptionsObject to Dictionary
https://bugs.webkit.org/show_bug.cgi?id=80802

Reviewed by Adam Barth.

For clarification, rename OptionsObject.{h,cpp} to Dictionary.{h,cpp}.
This patch just renames and sorts alphabetically.

No tests. No change in behavior.

  • GNUmakefile.list.am:
  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::createObjectStore):

  • Modules/indexeddb/IDBDatabase.h:

(WebCore::IDBDatabase::createObjectStore):
(IDBDatabase):

  • Modules/indexeddb/IDBDatabase.idl:
  • Modules/indexeddb/IDBKeyRange.h:
  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::createIndex):

  • Modules/indexeddb/IDBObjectStore.h:

(WebCore::IDBObjectStore::createIndex):
(IDBObjectStore):

  • Modules/indexeddb/IDBObjectStore.idl:
  • Target.pri:
  • UseV8.cmake:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • bindings/js/Dictionary.h: Renamed from Source/WebCore/bindings/js/OptionsObject.h.

(WebCore):
(Dictionary):
(WebCore::Dictionary::Dictionary):
(WebCore::Dictionary::isObject):
(WebCore::Dictionary::isUndefinedOrNull):
(WebCore::Dictionary::get):
(WebCore::Dictionary::getWithUndefinedOrNullCheck):

  • bindings/js/IDBBindingUtilities.cpp:

(WebCore::createDictionaryFromValue):

  • bindings/js/IDBBindingUtilities.h:

(WebCore):

  • bindings/scripts/CodeGeneratorJS.pm:

(JSValueToNative):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateParametersCheck):
(GenerateEventConstructorCallback):
(GetNativeType):
(JSValueToNative):

  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:

(WebDOMTestObj::optionsObject):

  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_options_object):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionIdbKey):
(WebCore::jsTestObjPrototypeFunctionOptionsObject):

  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj optionsObject:ooo:]):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::constructorCallback):
(WebCore::fillTestEventConstructorInit):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::optionsObjectCallback):

  • bindings/v8/Dictionary.cpp: Renamed from Source/WebCore/bindings/v8/OptionsObject.cpp.

(WebCore):
(WebCore::Dictionary::Dictionary):
(WebCore::Dictionary::~Dictionary):
(WebCore::Dictionary::operator=):
(WebCore::Dictionary::isObject):
(WebCore::Dictionary::isUndefinedOrNull):
(WebCore::Dictionary::getKey):
(WebCore::Dictionary::get):
(WebCore::Dictionary::getWithUndefinedOrNullCheck):

  • bindings/v8/Dictionary.h: Renamed from Source/WebCore/bindings/v8/OptionsObject.h.

(WebCore):
(Dictionary):

  • bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:

(WebCore::V8WebKitMutationObserver::observeCallback):

01:38 Changeset [110546] by shinyak@chromium.org
  • 5 edits in trunk

REGRESSION: Spellcheck tests hit assertions on Mac.
https://bugs.webkit.org/show_bug.cgi?id=80883

Reviewed by Ryosuke Niwa.

Source/WebKit/mac:

The bug was caused by the closure object created in requestCheckingOfString accessing
request's member variables even though the request object is not an NSObject or allocated
in stack. This resulted in the closure not being able to access those variables when invoked.

Fixed the bug by making local copies of those member variables.

  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::requestCheckingOfString):

LayoutTests:

Some words used in spellcheck-paste.js are considered as correct spellings in Mac's spellchecker.
This patch changes them into 'zz' so that Mac's spellchecker can make them as misspelling.

  • editing/spelling/script-tests/spellcheck-paste.js:

(pasteAndVerify.trial):
(pasteAndVerify):
(tests):

  • editing/spelling/spellcheck-paste-expected.txt:
01:27 Changeset [110545] by zimmermann@webkit.org
  • 110 edits
    37 adds in trunk

SVG Animations update baseVal instead of animVal
https://bugs.webkit.org/show_bug.cgi?id=12437

Reviewed by Dirk Schulze.

Source/WebCore:

Begin implementing the last missing core piece of the SVG DOM: proper animVal support.
Most SVG DOM interfaces exposing eg. lengths use SVGAnimatedLength. eg. from SVGRectElement:
"readonly attribute SVGAnimatedLength x;" SVGAnimatedXXX contains following methods:
"readonly attribute SVGLength baseVal; readonly attribute SVGLength animVal;"
From SVG DOM perspective, animVal and baseVal are two distinctive objects, animVal != baseVal.
Its underlying value is the same though, if no animation is running on that attribute.

As soon as a SMIL animation starts animating an SVGAnimated* target attribute, its
baseVal and animVal may begin to differ. The animVal always reflect the current animated
value (including all effects of additive/accumulated animations) which is shown on screen
when eg animating the width of a <rect>. The baseVal is is equal to the underlying XML
property value / SVG DOM value, but may be influenced through dynamic changes.
(Consider changing rect1.width.baseVal.value while 'width' is animated)

During the last year we prepared our animation code to turn on animVal support.
This patch adds the last missing pieces to turn on animVal support for the SVGLength.
SVGLengthList and all other types will follow, one after the other.

I've decided to write an exhaustive ChangeLog, as this as the base for any future
work in this area - hopefully making this more reviewable.

Tests: svg/animations/additive-from-to-width-animation.html

svg/animations/additive-values-width-animation.html
svg/animations/change-baseVal-while-animating-fill-freeze-2.html
svg/animations/change-baseVal-while-animating-fill-freeze.html
svg/animations/change-baseVal-while-animating-fill-remove-2.html
svg/animations/change-baseVal-while-animating-fill-remove.html
svg/animations/change-target-while-animating-SVG-property.html
svg/animations/multiple-animations-fill-freeze.html
svg/animations/remove-animation-element-while-animation-is-running.html
svg/repaint/repainting-after-animation-element-removal.svg

  • svg/SVGAnimateElement.cpp: Remove unnecessary std namespace inclusion.

(WebCore::SVGAnimateElement::SVGAnimateElement): Remove now-obsolete m_aboutToStopAnimation.
(WebCore::SVGAnimateElement::calculateAnimatedValue): Swap assertion order, to test hasTagName() _before_ casting.
(WebCore::SVGAnimateElement::resetToBaseValue):

Stop relying on the cached baseValue (breaking additive="sum"+values animation) for SVG DOM primitive animations.
Avoid any string roundtrips previously needed to reset the SVGAnimatedType to the base value. Just grab the
currentBaseValue() from the associated SVGAnimatedProperty, which includes all dynamic changes to the baseVal
either by SVG DOM or setAttribute() calls - this way we don't need to utilize the buggy cache in SMILTimeContainer,
which can be removed once all SVG DOM primitive types switched to the new animVal concept.

NOTE: When multiple animations of the same attribute are applied to a target element, resetToBaseValue() will be called
for the highest priority SVGSMILElement, on every animation step! Consider two <animate> elements, applied to a target
<rect> which both animate the 'x' attribute, one from 0s to 2s, the other from 4s to 6s. The last <animate> element
will reuse the SVGAnimatedType m_animatedType from the first <animate> element, and never create an own m_animatedType.
When the animation starts the first time at 0s, we update the rect.x.animVals SVGLength* pointer, to point to the
SVGAnimatedType of the first <animate> element, owning the m_animatedType. From that point on each call to rect.x.animVal
will always return the same value as the SVGAnimatedType of the first <animate> element holds. Now after 2s the first
<animate> element becomes inactive, but its m_animatedType remains alive. The bindings don't notice this change at all.
Now at 4s, the second animation element gets active. It reuses the SVGAnimatedType of the first <animate> element, and
applies its animation changes to that SVGAnimatedType, which is immediately reflected in the bindings w/o any additional
work. It's very important for the understanding when animationStarted/animationEnded need to be called.

(WebCore::SVGAnimateElement::applyResultsToTarget): Remove now-obsolete m_aboutToStopAnimation logic. No need to know it at this point.
(WebCore::SVGAnimateElement::targetElementWillChange):

Renamed from targetElementDidChange(). This method is called from SVGSMILElement for following conditions:

  • animation element is destructed
  • animation element is removed from document
  • target element of animation is destructed
  • target element of animation is removed from document
  • target element of animation changes id

Whenever any of this happens, we need to reset the animVal. Resetting the animVal involves resetting the PropertyType* pointer,
eg. SVGLength*, from the animVal property tear off, belonging to a certain SVGAnimatedProperty (eg. rect.x) to the initial
value again, which is the 'm_x' of the SVGRectElement. This is needed as the SVGAnimatedType the animVal currently points to,
if an animation is/was running, is destructed in targetElementWillChange(), to reset the SVGAnimateElement to the initial
state before it received a target. This is the only place which destructed the m_animatedType, and thus the only place that
needs to take care of resetting the animVal pointers.

  • svg/SVGAnimatedLength.cpp:

(WebCore::SVGAnimatedLengthAnimator::constructFromCopy):

Add a new constructFromCopy(SVGGenericAnimatedType) function to SVGAnimatedLengthAnimator.
It takes a type-unsafe SVGGenericAnimatedType - the caller has to guarantee the type matches.
This is strictly enforced for the single caller of constructFromCopy, and guaranteed to be safe.

  • svg/SVGAnimatedLength.h: Add new constructFromCopy method, which is used to avoid string-roundtrips when resetting to base values.
  • svg/SVGAnimatedType.cpp:

(WebCore::SVGAnimatedType::supportsAnimVal): Only returns true for AnimatedLength, for now.
(WebCore::SVGAnimatedType::setVariantValue): Takes a SVGGenericAnimatedType, assuming the type matches. Callers have to guarantee type-safety!

  • svg/SVGAnimatedType.h:

(SVGAnimatedType): Add new static supportsAnimVal(AnimatedPropertyType) function.
(WebCore::SVGAnimatedType::variantValue): Add a generic accessor for all animated types, called variant(). Only one place uses this.

  • svg/SVGAnimatedTypeAnimator.h:

(WebCore::SVGAnimatedTypeAnimator::constructFromCopy):

New method to construct an eg. SVGAnimatedLengthAnimator right from a SVGLength, instead of a String.
In that case the SVGAnimatedType just stores a pointer to the underlying SVGLength, no copying and or other roundtrips involved.

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::svgAttributeChanged):

Implement this instead of attributeChanged. The previous implementation reset the animation state to Inactive, causing a full
rebuild, whenever any attribute changes, even though it might not be related for the animation element, eg.
animate.setAttribute("stdDeviationX", "foobar"). Fix that by checking if we support the attribute (keyTimes/keySplines/etc..)
, if not pass it on to SVGSMILElement (which supports begin/end/etc..) to check if it can handle that.

(WebCore::SVGAnimationElement::animationAttributeChanged):

Called from our svgAttributeChanged, and/or from SVGSMILElement::svgAttributeChanged, whenever a _known_ attribute has changed.
This sledgehammer should be used with care, instead of each time attributeChanged() is called :-)

(WebCore::setTargetAttributeAnimatedCSSValue):

Remove support for removing properties from the override style sheet. I've added this optimization too early, we should reevaluate
this once more types support animVal. It currently complexifies the logic too much, requiring setAttributeAnimatedValue to know
if the animation ends (and that's not easy to figure out, at least not using started/endedActiveInterval, as I anticipated).

(WebCore::findMatchingAnimatedProperty):

Add helper functions which retrieves a SVGAnimatedProperty* for a given SVGElement* targetElement, an attributeName, and an attribute
type. eg. findMatchingAnimatedProperty(myRectElement, SVGNames::xAttr, AnimatedLength) returns the SVGAnimatedProperty which is
exposed to JS, that holds: SVGProperty* baseVal, and SVGProperty* animVal. (Lazily created if they got accessed from JS.). This is
used to update the animVal pointing to a new eg. SVGLength* value, once animation has started, to make rect->x() return that new
SVGLength* value (internally), and to reflect the current animated value in rect.x.animVal.value from JS.

(WebCore::SVGAnimationElement::applyAnimatedValue): Refactored from setTargetAttributeAnimatedValue, to simplify the code.
(WebCore::notifyAnimatedPropertyAboutAnimationBeginEnd):

Helper function to share code betweeen animationStarted/animationEnded.
It takes a SVGAnimatedProperty* and a SVGAnimatedType* which may be zero, indicating that the animation ended.
It calls animationStarted/animationEnded on the given SVGAnimatedProperty, to update the animVal state.
It also figures out all instances of the target element, and their SVGAnimatedProperties that may need updating.

(WebCore::SVGAnimationElement::animationStarted): Uses the helper above, passing on the given animatedType.
(WebCore::SVGAnimationElement::animationEnded): Uses the helper above, passing 0 as animatedType.
(WebCore::InstanceUpdateBlocker::InstanceUpdateBlocker):

Added new helper struct, doing element->setInstancesUpdatedBlock(true) on construction and setInstancesUpdatesBlocked(false) on
destruction, making it impossible to forget one. If we ever rewrite svgAttributeChanged & co to auto-update the cloned instances,
this can go away.

(WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):

Now takes an SVGAnimatedType* instead of a String parameter. In order to avoid string-roundtrips for animVal support, let us
decide if we need to construct a String out of it, or not. For animations supporting animVal (only SVGLength) we don't need
to update any attribute or animVal pointer here, that happens automatically! We only need to notify the targetElement eg,
that its xAttr changed! Previously we had to call targetElement->setAttribute("x", "...") on every animation step for
SVGLength animations - that's gone now! The SVGAnimatedType pointers remains the same during the whole animation, so there's
no need to call animationStarted() at each animated step!

(WebCore::SVGAnimationElement::animatedPropertyForType):

Helper function returning a SVGAnimatedProperty* for the current target element & current target attribute, if the
current animation is running on a type supporting animVal (SVGLength), or returning 0. This is needed for SVGAnimateElement.
Reuses the existing findMatchingAnimatedProperty code.

  • svg/SVGAnimationElement.h:
  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::updateAnimations):

Add comment to clarify why caching baseValues is just wrong. For SVGLength animations the problem is now gone.
This is exercised using the new additive-from-to-width-animation.html & additive-values-width-animation.html tests.

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::removedFromDocument):

Since animVal requires that the SVGAnimatedProperties are correctly reset if an animation element is removed from the document,
we have to call targetElementWillChange(0) from here. That requires to move the "m_attributeName = anyQName()" line down,
otherwise targetElementWillChange() would early exit, as no valid attributeName was specified.

This is verified using the new svg/animations/remove-animation-element-while-animation-is-running.html
and svg/repaint/repainting-after-animation-element-removal.svg tests.

(WebCore::SVGSMILElement::isSupportedAttribute): Add function like all SVG*Elements have identifying their supported attributes.
(WebCore::SVGSMILElement::svgAttributeChanged):

Implement svgAttributeChanged instead of attributeChanged. Only take action if the attribute is actually supported.
If one of the common attributes like begin/end/etc. changed, be sure to call animationAttributeChanged() so that our
ancestor-classes get notified about this and can take action as well. NOTE: This is not about animating begin/end attributes,
but about pure DOM changes. begin/end/et.. are not exposed to the SVG DOM, we still reuse the svgAttributeChanged logic
for consistency. (This does NOT make those attributes animatable, nothing this here as it came up while reviewing).

(WebCore::SVGSMILElement::targetElement): Adapt logic to targetElementDidChange -> targetElementWillChange change.
(WebCore::SVGSMILElement::targetElementWillChange):

Renamed from targetElementDidChange. Added "oldTarget" as parameter as well. Our ancestor-classes like SVGAnimateElement
use this to properly deregister the animVal in the old target, before resetting the SVGAnimatedType, otherwise we'd leave
dangling pointers around (verified manually by guard malloc runs, that none of this happens).

Also add a default implementation here in targetElementWillChange, that ancestor classes have to call.
Now we properly call endedActiveInterval() if the m_activeState is currently Active, so that animations are shut-down
just like if the animation properly ends (use the same cleanup routines, etc.). Not doing that now leads to assertions.

(WebCore::SVGSMILElement::resetTargetElement):

Instead of forcing m_activeState to be inactive, use the standard methods to end the animation.
targetElementWillChange(m_targetElement, 0) and animationAttributeChanged().

resetTargetElement() is only called by SVGDocumentExtensions::removeAllAnimationElementsFromTarget() for following conditions:

  • targetElement gets destructed
  • targetElement gets removed from the document
  • targetElement id changes

If the targetElement gets destructed or removed, no actions need to be taken, as the SVGAnimatedPropertys are teared down
as well. But if only the id changes, we still have to properly disconnect the animVals - this is all handled through
targetElementWillChange now - that's why this has to be called from here as well.
That explains why targetElementWillChange() now needs to check if the targetElement is destructing or not.

  • svg/properties/SVGAnimatedEnumerationPropertyTearOff.h:

Pass the AnimatedPropertyType from the SVGPropertyInfo to the SVGAnimatedProperties.
Requires mechanic changes in all SVGAnimated* classes. We need acccess to the AnimatedPropertyType
to verify the SVGAnimatedType objects, passed to animationStarted, match our type. This is to enforce
strict type-checking, whenever SVGGenericAnimatedTypes are passed around.

(WebCore::SVGAnimatedEnumerationPropertyTearOff::create):
(WebCore::SVGAnimatedEnumerationPropertyTearOff::SVGAnimatedEnumerationPropertyTearOff):

  • svg/properties/SVGAnimatedListPropertyTearOff.h: Ditto.

(WebCore::SVGAnimatedListPropertyTearOff::create):
(WebCore::SVGAnimatedListPropertyTearOff::SVGAnimatedListPropertyTearOff):

  • svg/properties/SVGAnimatedPathSegListPropertyTearOff.h: Ditto.

(WebCore::SVGAnimatedPathSegListPropertyTearOff::create):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::SVGAnimatedPathSegListPropertyTearOff):

  • svg/properties/SVGAnimatedProperty.h: Store AnimatedPropertyType, add accessors.

(WebCore::SVGAnimatedProperty::animatedPropertyType): Add accessor.
(WebCore::SVGAnimatedProperty::animationValueChanged): New animVal related functions to be implemented in the animated tear offs.
(WebCore::SVGAnimatedProperty::animationStarted): Ditto.
(WebCore::SVGAnimatedProperty::animationEnded): Ditto.
(WebCore::SVGAnimatedProperty::currentBaseValue):

Generic accessor for the baseVal: returns a SVGGenericAnimatedType.
It takes an AnimatedPropertyType as input, that's only needed to verify that the type we're returning matches
the expectation of the caller. If not, return 0 to avoid any potential casting mistakes, which would lead to crashes.

(WebCore::SVGAnimatedProperty::SVGAnimatedProperty): Store m_animatedPropertyType.

  • svg/properties/SVGAnimatedPropertyTearOff.h:

(WebCore::SVGAnimatedPropertyTearOff::create): Same changes as in the other tear offs: pass around AnimatedPropertyType.
(WebCore::SVGAnimatedPropertyTearOff::currentBaseValue): Returns &m_property, if the type matches (see above).
(SVGAnimatedPropertyTearOff): Pass around AnimatedPropertyType.
(WebCore::SVGAnimatedPropertyTearOff::animationValueChanged): No-op for non list types, don't need to do anything here.
(WebCore::SVGAnimatedPropertyTearOff::animationStarted):
(WebCore::SVGAnimatedPropertyTearOff::animationEnded):

Store the currently animated value in the animVal() property tear off, that's also re-used as-is for the JS bindings.
As this is important, here's an example of how this affects methods like rect->x() used in the renderers.

Setting m_isAnimating to true, redirects any rect->x() calls that previously returned rect->m_x, to
rect->xAnimated()->animVal()->propertyReference() (which returns the same SVGLength& that the SVGAnimatedElement
m_animatedType contains). Calling rect->setXBaseValue() still modifies rect->m_x, and is used by all parseAttribute()
methods in svg/ as setAttribute() calls only ever modify the "baseValue", never the current animated value.
rect.x.baseVal will return a SVGLength object corresponding to rect->m_x.
rect.x.animVal will return a SVGLength object corresponding to rect->xAnimated()->animVal()->propertyReference().

These implementation details are all hidden in the SVGAnimatedPropertyMacros. Here's an example from SVGRectElement:
DECLARE_ANIMATED_LENGTH(X, x) -> Replace PropertyType with 'SVGLength', LowerProperty with 'x', and UpperProperty with 'X'.

PropertyType& LowerProperty() const
{

if (TearOffType* wrapper = SVGAnimatedProperty::lookupWrapper<UseOwnerType, TearOffType, IsDerivedFromSVGElement<UseOwnerType>::value>(this, LowerProperty##PropertyInfo())) {

if (wrapper->isAnimating())

return wrapper->currentAnimatedValue();

}
return m_##LowerProperty.value;

}

PropertyType& LowerProperty##BaseValue() const
{

return m_##LowerProperty.value;

}

void set##UpperProperty##BaseValue(const PropertyType& type)
{

m_##LowerProperty.value = type;

}

Any code outside of svg/, eg. in rendering/svg, does not need to care about any baseVal/animVal differences.
During layout eg. RenderSVGRect calls rect->x().value(someLengthContext) to get the current 'x' as float. If an animation
is running on that rect element it will automatically retrieve the last set animated value here - all under the hood.
I hope that sheds some light in those myserious functions, they were designed with animVal in mind, but we never had that until now :-)

(WebCore::SVGAnimatedPropertyTearOff::SVGAnimatedPropertyTearOff): Pass around AnimatedPropertyType.
(WebCore::SVGAnimatedPropertyTearOff::~SVGAnimatedPropertyTearOff): Add destructor to debug builds veryifing that m_isAnimating is false.

  • svg/properties/SVGAnimatedStaticPropertyTearOff.h: Ditto.

(WebCore::SVGAnimatedStaticPropertyTearOff::create):
(WebCore::SVGAnimatedStaticPropertyTearOff::SVGAnimatedStaticPropertyTearOff):

  • svg/properties/SVGAnimatedTransformListPropertyTearOff.h: Ditto.

(WebCore::SVGAnimatedTransformListPropertyTearOff::create):
(WebCore::SVGAnimatedTransformListPropertyTearOff::SVGAnimatedTransformListPropertyTearOff):

  • svg/properties/SVGPropertyInfo.h: Add SVGGenericAnimatedType definition.
  • svg/properties/SVGPropertyTearOff.h: Remove obsolete updateAnimVal method - switched to using setValue directly.

LayoutTests:

Update test expectations after turning on animVal support for SVGLength, the first primitive now support animVal.
Added several new tests, checking additive behaviour with SVGLength objects, removing animation elements
while animations are running (+ test repainting of those cases), etc.

  • platform/mac/svg/repaint/repainting-after-animation-element-removal-expected.png: Added.
  • platform/mac/svg/repaint/repainting-after-animation-element-removal-expected.txt: Added.
  • svg/animations/additive-from-to-width-animation-expected.txt: Added.
  • svg/animations/additive-from-to-width-animation.html: Added.
  • svg/animations/additive-values-width-animation-expected.txt: Added.
  • svg/animations/additive-values-width-animation.html: Added.
  • svg/animations/animVal-basics-expected.txt:
  • svg/animations/animate-calcMode-spline-by-expected.txt:
  • svg/animations/animate-calcMode-spline-from-by-expected.txt:
  • svg/animations/animate-calcMode-spline-from-to-expected.txt:
  • svg/animations/animate-calcMode-spline-to-expected.txt:
  • svg/animations/animate-calcMode-spline-values-expected.txt:
  • svg/animations/animate-elem-02-t-drt-expected.txt:
  • svg/animations/animate-elem-09-t-drt-expected.txt:
  • svg/animations/animate-elem-10-t-drt-expected.txt:
  • svg/animations/animate-elem-11-t-drt-expected.txt:
  • svg/animations/animate-elem-12-t-drt-expected.txt:
  • svg/animations/animate-elem-13-t-drt-expected.txt:
  • svg/animations/animate-elem-14-t-drt-expected.txt:
  • svg/animations/animate-elem-15-t-drt-expected.txt:
  • svg/animations/animate-elem-16-t-drt-expected.txt:
  • svg/animations/animate-elem-17-t-drt-expected.txt:
  • svg/animations/animate-elem-18-t-drt-expected.txt:
  • svg/animations/animate-elem-19-t-drt-expected.txt:
  • svg/animations/animate-end-attribute-expected.txt:
  • svg/animations/animate-endElement-beginElement-expected.txt:
  • svg/animations/animate-from-to-keyTimes-expected.txt:
  • svg/animations/animate-insert-begin-expected.txt:
  • svg/animations/animate-insert-no-begin-expected.txt:
  • svg/animations/animate-keySplines-expected.txt:
  • svg/animations/animate-number-calcMode-discrete-keyTimes-expected.txt:
  • svg/animations/attributeTypes-expected.txt:
  • svg/animations/change-baseVal-while-animating-fill-freeze-2-expected.txt: Added.
  • svg/animations/change-baseVal-while-animating-fill-freeze-2.html: Added.
  • svg/animations/change-baseVal-while-animating-fill-freeze-expected.txt: Added.
  • svg/animations/change-baseVal-while-animating-fill-freeze.html: Added.
  • svg/animations/change-baseVal-while-animating-fill-remove-2-expected.txt: Added.
  • svg/animations/change-baseVal-while-animating-fill-remove-2.html: Added.
  • svg/animations/change-baseVal-while-animating-fill-remove-expected.txt: Added.
  • svg/animations/change-baseVal-while-animating-fill-remove.html: Added.
  • svg/animations/change-target-while-animating-SVG-property-expected.txt: Added.
  • svg/animations/change-target-while-animating-SVG-property.html: Added.
  • svg/animations/multiple-animations-fill-freeze-expected.txt: Added.
  • svg/animations/multiple-animations-fill-freeze.html: Added.
  • svg/animations/remove-animation-element-while-animation-is-running-expected.txt: Added.
  • svg/animations/remove-animation-element-while-animation-is-running.html: Added.
  • svg/animations/resources/additive-from-to-width-animation.svg: Added.
  • svg/animations/resources/additive-values-width-animation.svg: Added.
  • svg/animations/resources/change-baseVal-while-animating-fill-freeze.svg: Added.
  • svg/animations/resources/change-baseVal-while-animating-fill-remove.svg: Added.
  • svg/animations/resources/change-target-while-animating-SVG-property.svg: Added.
  • svg/animations/resources/multiple-animations-fill-freeze.svg: Added.
  • svg/animations/resources/remove-animation-element-while-animation-is-running.svg: Added.
  • svg/animations/script-tests/additive-from-to-width-animation.js: Added.

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/additive-values-width-animation.js: Added.

(sample1):
(sample2):
(sample3):
(changeBaseVal):
(sample4):
(sample5):
(executeTest):

  • svg/animations/script-tests/animVal-basics.js:

(sample2):
(sample3):

  • svg/animations/script-tests/animate-calcMode-spline-by.js:

(sample2):
(sample3):

  • svg/animations/script-tests/animate-calcMode-spline-from-by.js:

(sample2):
(sample3):

  • svg/animations/script-tests/animate-calcMode-spline-from-to.js:

(sample2):
(sample3):

  • svg/animations/script-tests/animate-calcMode-spline-to.js:

(sample2):
(sample3):

  • svg/animations/script-tests/animate-calcMode-spline-values.js:

(sample2):
(sample3):

  • svg/animations/script-tests/animate-elem-02-t-drt.js:

(sampleAfterBegin):
(sampleAfterMid):
(sampleAfterBeginOfFirstRepetition):
(sampleAfterMidOfFirstRepetition):

  • svg/animations/script-tests/animate-elem-09-t-drt.js:

(sample1):
(sample2):
(sample3):
(sample4):

  • svg/animations/script-tests/animate-elem-10-t-drt.js:

(sample1):
(sample2):
(sample3):
(sample4):

  • svg/animations/script-tests/animate-elem-11-t-drt.js:

(sample1):
(sample2):
(sample3):
(sample4):

  • svg/animations/script-tests/animate-elem-12-t-drt.js:

(sample1):
(sample2):
(sample3):
(sample4):

  • svg/animations/script-tests/animate-elem-13-t-drt.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/animate-elem-14-t-drt.js:

(sample1):
(sample2):
(sample3):
(sample4):

  • svg/animations/script-tests/animate-elem-15-t-drt.js:

(sample1):
(sample2):
(sample3):
(sample4):

  • svg/animations/script-tests/animate-elem-16-t-drt.js:

(sample1):
(sample2):
(sample3):
(sample4):

  • svg/animations/script-tests/animate-elem-17-t-drt.js:

(sample1):
(sample2):
(sample3):
(sample4):

  • svg/animations/script-tests/animate-elem-18-t-drt.js:

(sample1):
(sample2):
(sample3):
(sample4):

  • svg/animations/script-tests/animate-elem-19-t-drt.js:

(sample1):
(sample2):
(sample3):
(sample4):

  • svg/animations/script-tests/animate-end-attribute.js:

(sample2):
(sample3):

  • svg/animations/script-tests/animate-endElement-beginElement.js:

(sample1):

  • svg/animations/script-tests/animate-from-to-keyTimes.js:

(sample1):
(sample2):

  • svg/animations/script-tests/animate-insert-begin.js:

(sample1):
(sample2):

  • svg/animations/script-tests/animate-insert-no-begin.js:

(sample1):
(sample2):

  • svg/animations/script-tests/animate-keySplines.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/animate-number-calcMode-discrete-keyTimes.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/attributeTypes.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/change-baseVal-while-animating-fill-freeze-2.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(executeTest):

  • svg/animations/script-tests/change-baseVal-while-animating-fill-freeze.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(executeTest):

  • svg/animations/script-tests/change-baseVal-while-animating-fill-remove-2.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(executeTest):

  • svg/animations/script-tests/change-baseVal-while-animating-fill-remove.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(executeTest):

  • svg/animations/script-tests/change-target-while-animating-SVG-property.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(executeTest):

  • svg/animations/script-tests/multiple-animations-fill-freeze.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(sample6):
(sample7):
(sample8):
(executeTest):

  • svg/animations/script-tests/remove-animation-element-while-animation-is-running.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):

  • svg/animations/script-tests/svglength-animation-LengthModeHeight.js:

(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-LengthModeOther.js:

(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-LengthModeWidth.js:

(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-invalid-value-1.js:

(sample2):

  • svg/animations/script-tests/svglength-animation-invalid-value-2.js:

(sample2):

  • svg/animations/script-tests/svglength-animation-invalid-value-3.js:

(sample2):

  • svg/animations/script-tests/svglength-animation-number-to-number.js:

(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-px-to-cm.js:

(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-px-to-ems.js:

(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-px-to-exs.js:

(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-px-to-in.js:

(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-px-to-number.js:

(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-px-to-pc.js:

(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-px-to-percentage.js:

(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-px-to-pt.js:

(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-px-to-px.js:

(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-unitType.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-values.js:

(sample2):
(sample3):
(sample4):
(sample5):

  • svg/animations/svglength-animation-LengthModeHeight-expected.txt:
  • svg/animations/svglength-animation-LengthModeOther-expected.txt:
  • svg/animations/svglength-animation-LengthModeWidth-expected.txt:
  • svg/animations/svglength-animation-invalid-value-1-expected.txt:
  • svg/animations/svglength-animation-invalid-value-2-expected.txt:
  • svg/animations/svglength-animation-invalid-value-3-expected.txt:
  • svg/animations/svglength-animation-number-to-number-expected.txt:
  • svg/animations/svglength-animation-px-to-cm-expected.txt:
  • svg/animations/svglength-animation-px-to-ems-expected.txt:
  • svg/animations/svglength-animation-px-to-exs-expected.txt:
  • svg/animations/svglength-animation-px-to-in-expected.txt:
  • svg/animations/svglength-animation-px-to-number-expected.txt:
  • svg/animations/svglength-animation-px-to-pc-expected.txt:
  • svg/animations/svglength-animation-px-to-percentage-expected.txt:
  • svg/animations/svglength-animation-px-to-pt-expected.txt:
  • svg/animations/svglength-animation-px-to-px-expected.txt:
  • svg/animations/svglength-animation-unitType-expected.txt:
  • svg/animations/svglength-animation-values-expected.txt:
  • svg/repaint/repainting-after-animation-element-removal.svg: Added.
01:12 Changeset [110544] by macpherson@chromium.org
  • 3 edits in trunk/Source/WebCore

Implement CSSPropertyTextOverflow in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=80934

Reviewed by Andreas Kling.

No new tests / refactoring only.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

00:28 Changeset [110543] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, inspector test rebaseline after r110532.

  • inspector/styles/svg-style-expected.txt:
00:24 Changeset [110542] by commit-queue@webkit.org
  • 16 edits
    7 adds in trunk/LayoutTests

[Forms] Re-factor label.for tests for extending test coverage
https://bugs.webkit.org/show_bug.cgi?id=80574

Patch by Yosifumi Inoue <yosin@chromium.org> on 2012-03-13
Reviewed by Kent Tamura.

This patch changes label.labels attribute testing with using shared
utility functions, createFormControlDataSet for representing form
related information of HTML5 specification and setupLabelsTeset for
populating test sample dom tree and data set.

This patch extends coverage of existing label.labels test to cover
defined in the specification, labelable-elements.html, and adds
multiple label entries tests, labels-multiple-*.html.

Note: test failure of hidden input type will be fixed by
https://bugs.webkit.org/show_bug.cgi?id=80403

Note: test failure of output element will be fixed by
https://bugs.webkit.org/show_bug.cgi?id=80466

  • fast/forms/label/labelable-elements-expected.txt: Added.
  • fast/forms/label/labelable-elements.html: Added.
  • fast/forms/label/labels-add-htmlFor-label-expected.txt:
  • fast/forms/label/labels-add-htmlFor-label.html:
  • fast/forms/label/labels-add-parent-label-expected.txt:
  • fast/forms/label/labels-add-parent-label.html:
  • fast/forms/label/labels-change-htmlFor-attribute-expected.txt:
  • fast/forms/label/labels-change-htmlFor-attribute.html:
  • fast/forms/label/labels-multiple-sibling-labels-expected.txt: Added.
  • fast/forms/label/labels-multiple-sibling-labels.html: Added.
  • fast/forms/label/labels-parent-and-sibling-labels-expected.txt: Added.
  • fast/forms/label/labels-parent-and-sibling-labels.html: Added.
  • fast/forms/label/labels-remove-htmlFor-attribute-expected.txt:
  • fast/forms/label/labels-remove-htmlFor-attribute.html:
  • fast/forms/label/labels-remove-htmlFor-label-expected.txt:
  • fast/forms/label/labels-remove-htmlFor-label.html:
  • fast/forms/label/labels-remove-parent-label-expected.txt:
  • fast/forms/label/labels-remove-parent-label.html:
  • fast/forms/label/labels-set-htmlFor-attribute-expected.txt:
  • fast/forms/label/labels-set-htmlFor-attribute.html:
  • fast/forms/resources/common.js:

(createFormControlDataSet): Returns form control data set for providing
labelable elements and supported elements information.

  • fast/forms/resources/label-test-util.js: Added.

(setupLabelsTest.return.dataSet.dataSet.getLabelableElementData):
(setupLabelsTest): Populate dom tree for unit tests.

03/12/12:

23:42 Changeset [110541] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Switch Chromium from LocaleToScriptMappingICU.cpp to LocaleToScriptMappingDefault.cpp
https://bugs.webkit.org/show_bug.cgi?id=80935

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-03-12
Reviewed by Kent Tamura.

ICU seems to have issues with non-well-formed locale strings.
Currently, the only port that uses LocaleToScriptMappingICU.cpp is
Chromium.

No new tests. LocaleToScriptMappingDefault.cpp is already used by
other ports and covered by existing tests.

  • WebCore.gyp/WebCore.gyp:
23:15 Changeset [110540] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

Fix test cases for RegExp multiline
https://bugs.webkit.org/show_bug.cgi?id=80822

Patch by Hojong Han <hojong.han@samsung.com> on 2012-03-12
Reviewed by Gavin Barraclough.

  • tests/mozilla/js1_2/regexp/RegExp_multiline.js:
  • tests/mozilla/js1_2/regexp/RegExp_multiline_as_array.js:
  • tests/mozilla/js1_2/regexp/beginLine.js:
  • tests/mozilla/js1_2/regexp/endLine.js:
22:38 Changeset [110539] by commit-queue@webkit.org
  • 21 edits
    1 add in trunk/Source/WebCore

Fix IndexedDB build with JSC
https://bugs.webkit.org/show_bug.cgi?id=80207

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-12
Reviewed by Adam Barth.

This fixes the build of WebKit when IndexedDB is enabled. Most functions were added
empty implementation, it compiles but IndexedDB is not working.

  • DerivedSources.make: Added missing IDL files.
  • Modules/indexeddb/IDBDatabaseBackendImpl.h: Fix warnings and build errors.

(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBDatabaseCallbacksImpl.cpp: ditto.

(WebCore::IDBDatabaseCallbacksImpl::unregisterDatabase): ditto.

  • Modules/indexeddb/IDBFactoryBackendImpl.cpp: ditto.

(WebCore::IDBFactoryBackendImpl::openBackingStore):

  • Modules/indexeddb/IDBIndexBackendImpl.cpp: ditto.

(WebCore::IDBIndexBackendImpl::countInternal):

  • Modules/indexeddb/IDBKeyPathBackendImpl.cpp: Fix the method signature and add

an empty implementation.
(WebCore):
(WebCore::IDBKeyPathBackendImpl::createIDBKeysFromSerializedValuesAndKeyPath):
(WebCore::IDBKeyPathBackendImpl::injectIDBKeyIntoSerializedValue):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp: Fix warnings.

(WebCore::IDBObjectStoreBackendImpl::countInternal):

  • Modules/indexeddb/IDBPendingTransactionMonitor.cpp: ditto.

(WebCore::transactions):

  • Modules/indexeddb/IDBRequest.cpp: ditto.

(WebCore::IDBRequest::resetReadyState):

  • Modules/indexeddb/IDBRequest.h: ditto.

(WebCore::IDBRequest::onSuccessWithPrefetch):
(WebCore):
(WebCore::JSIDBVersionChangeRequest::visitChildren):

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/IDBBindingUtilities.cpp:

(WebCore::createIDBKeyFromValue): Fix the creation of IDBKeys.
(WebCore::createOptionsObjectFromValue): Add an empty implementation of
the handling of database options (IDBObjectStoreParameters).
(WebCore):

  • bindings/js/IDBBindingUtilities.h:

(WebCore):

  • bindings/js/JSIDBAnyCustom.cpp:

(WebCore::toJS): Add the missing IDBAny's types.

  • bindings/js/JSIDBKeyCustom.cpp:

(WebCore::toJS): Add the missing IDBKey's types.

  • bindings/js/JSIDBVersionChangeRequestCustom.cpp: Added.

IDBVersionChangeRequest has the attribute EventTarget so it requires
the visitChildren() function. An empty implementation was added.

  • bindings/js/OptionsObject.h: Add an empty implementation.

(WebCore):
(OptionsObject):
(WebCore::OptionsObject::OptionsObject):
(WebCore::OptionsObject::isObject):
(WebCore::OptionsObject::isUndefinedOrNull):
(WebCore::OptionsObject::get):
(WebCore::OptionsObject::getWithUndefinedOrNullCheck):

  • bindings/js/SerializedScriptValue.cpp: Add the missing functions needed by IndexedDB.

(WebCore):
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::toWireString):
(WebCore::SerializedScriptValue::createFromWire):
(WebCore::SerializedScriptValue::numberValue):
(WebCore::SerializedScriptValue::deserialize):

  • bindings/js/SerializedScriptValue.h:

(SerializedScriptValue):

  • bindings/scripts/CodeGeneratorJS.pm: Modify the code generator to:

-Support the IDBKey type correctly.
-Support the OptionsObject type.
-Generate valid function call for static functions.
(GenerateImplementationFunctionCall):
(JSValueToNative):
(NativeToJSValue):

  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):

22:36 Changeset [110538] by morrita@google.com
  • 4 edits in trunk/Source

Unreviewed, rolling out r110529.
http://trac.webkit.org/changeset/110529
https://bugs.webkit.org/show_bug.cgi?id=80969

breaks mac build (Requested by morrita on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-12

Source/WebCore:

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::computeUnoccludedContentRect):

Source/WebKit/chromium:

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore):

22:03 Changeset [110537] by morrita@google.com
  • 42 edits
    2 copies in trunk

Unreviewed, rolling out r110524.
http://trac.webkit.org/changeset/110524
https://bugs.webkit.org/show_bug.cgi?id=80936

breaks chromium win build. (Requested by morrita on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-12

Source/WebCore:

  • Target.pri:
  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateNamedConstructorCallback):
(GenerateImplementation):

  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):

  • bindings/v8/NPV8Object.cpp:

(WebCore::npObjectTypeInfo):

  • bindings/v8/V8GCController.cpp:

(WebCore::GrouperVisitor::visitDOMWrapper):

  • bindings/v8/WrapperTypeInfo.h:

(WebCore):
(WrapperTypeInfo):

  • bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Copied from Source/WebCore/bindings/v8/custom/V8StyleSheetCustom.cpp.

(WebCore):
(WebCore::toV8):

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::toV8):
(WebCore):

  • bindings/v8/custom/V8DOMTokenListCustom.cpp: Copied from Source/WebCore/bindings/v8/custom/V8StyleSheetCustom.cpp.

(WebCore):
(WebCore::toV8):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore):

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:

(WebCore::toV8):
(WebCore):

  • bindings/v8/custom/V8StyleSheetCustom.cpp:

(WebCore::toV8):

  • css/CSSStyleSheet.idl:
  • css/StyleSheet.idl:
  • dom/DOMStringMap.idl:
  • dom/NamedNodeMap.idl:
  • html/DOMTokenList.idl:
  • html/track/TextTrackList.idl:

LayoutTests:

  • platform/chromium/test_expectations.txt:
21:20 Changeset [110536] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[V8][Refactoring] Remove getCachedWrapperSlow() from V8Bindings.cpp
https://bugs.webkit.org/show_bug.cgi?id=80924

Reviewed by Adam Barth.

getCachedWrapperSlow() is called by getCachedWrapper() only,
and getCachedWrapperSlow() just calls getCachedWrapperInline().
Thus, this patch expands getCachedWrapperInline() into getCachedWrapper(),
and removes getCachedWrapperSlow().

No tests. No change in behavior.

  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getCachedWrapper):

21:03 Changeset [110535] by haraken@chromium.org
  • 13 edits in trunk/Source/WebCore

[V8][Refactoring] Remove existingWrapper() from generated code
https://bugs.webkit.org/show_bug.cgi?id=80927

Reviewed by Adam Barth.

Currently wrap() calls existingWrapper(), and existingWrapper()
just calls getCachedWrapper(). We can remove existingWrapper() from the generated code.

Test: bindings/scripts/test/*

  • bindings/scripts/CodeGeneratorV8.pm: Removed existingWrapper().

(GenerateHeader):
(GenerateNormalAttrGetter):

  • bindings/scripts/test/V8/V8Float64Array.h: Updated run-bindings-tests results.

(V8Float64Array):
(WebCore::V8Float64Array::wrap):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):
(WebCore::V8TestActiveDOMObject::wrap):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):
(WebCore::V8TestCustomNamedGetter::wrap):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):
(WebCore::V8TestEventConstructor::wrap):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):
(WebCore::V8TestEventTarget::wrap):

  • bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):
(WebCore::V8TestInterface::wrap):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):
(WebCore::V8TestMediaQueryListListener::wrap):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):
(WebCore::V8TestNamedConstructor::wrap):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::readOnlyTestObjAttrAttrGetter):
(WebCore::TestObjInternal::cachedAttribute1AttrGetter):
(WebCore::TestObjInternal::cachedAttribute2AttrGetter):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):
(WebCore::V8TestObj::wrap):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):
(WebCore::V8TestSerializedScriptValueInterface::wrap):

20:33 Changeset [110534] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Use tileRect instead of pointer derefs
https://bugs.webkit.org/show_bug.cgi?id=80919

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-12
Reviewed by Adrienne Walker.

Covered by existing tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawTileQuad):

20:14 Changeset [110533] by ojan@chromium.org
  • 3 edits in trunk/Tools

webkit-patch optimize-baselines sometimes creates a mac-future result
https://bugs.webkit.org/show_bug.cgi?id=80717

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/checkout/baselineoptimizer.py:

(_baseline_search_hypergraph):
(BaselineOptimizer._find_optimal_result_placement):
(BaselineOptimizer._filter_virtual_ports):

  • Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:

(BaselineOptimizerTest.test_no_add_mac_future):

19:45 Changeset [110532] by commit-queue@webkit.org
  • 8 edits
    8 adds in trunk

SVG should support transform-origin and relative values
https://bugs.webkit.org/show_bug.cgi?id=79068

Patch by Hans Muller <hmuller@adobe.com> on 2012-03-12
Reviewed by Dirk Schulze.

Source/WebCore:

Added SVG support for the CSS 'transform-origin' property and for percentage
values in the transform translate function. The changes conform to
http://dev.w3.org/csswg/css3-transforms/.

Tests: svg/transforms/percent-transform-values.xhtml

svg/transforms/transform-origin-css-property.xhtml

  • css/svg.css:

(*):
(html|* > svg):
Default transform-origin for SVG elements is 0 0.

  • platform/Length.h:

(WebCore::Length::calcFloatValue):
Added a calcFloatValue overload whose max parameter (for percent lengths) is a float.
The original version will be obsolete when the sub-pixel layout support is completed.

  • rendering/style/RenderStyle.cpp:
  • rendering/style/RenderStyle.h:

(WebCore):
(WebCore::requireTransformOrigin):
Transforms that only include translations don't depend on the transform-origin.

(WebCore::RenderStyle::applyTransform):
SVG elements interpret non-percentage/keyword transform-origin values relative to their viewport,
unlike HTML which interprets all transform-origin values relative to the element's origin.
The new FloatRect applyTransform() function handles SVG semantics. Similarly, SVG elements interpret
percentage/keyword transform-origin values relative to the origin of their objectBoundingBox(), HTML
uses the borderBox. All this per http://dev.w3.org/csswg/css3-transforms/.

  • svg/SVGStyledTransformableElement.cpp:

(WebCore::SVGStyledTransformableElement::animatedLocalTransform):

LayoutTests:

Added tests for SVG CSS transform-origin property support and for
CSS translations specified with percentages and applied to an SVG element.

  • svg/transforms/change-transform-origin-css-expected.xhtml: Added.
  • svg/transforms/change-transform-origin-css.xhtml: Added.
  • svg/transforms/change-transform-origin-presentation-attribute-expected.xhtml: Added.
  • svg/transforms/change-transform-origin-presentation-attribute.xhtml: Added.
  • svg/transforms/percent-transform-values-expected.txt: Added.
  • svg/transforms/percent-transform-values.xhtml: Added.
  • svg/transforms/transform-origin-css-property-expected.xhtml: Added.
  • svg/transforms/transform-origin-css-property.xhtml: Added.
19:42 Changeset [110531] by morrita@google.com
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed Windows build fix.

  • src/WebViewImpl.cpp:
19:29 Changeset [110530] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Fix assert seen in DRT due to not calling EventSender.mouseUp in a previous test
https://bugs.webkit.org/show_bug.cgi?id=80925

Reviewed by Maciej Stachowiak.

  • fast/events/input-element-display-none-in-dragleave-crash.html:

Add call to eventSender.mouseUp().

19:27 Changeset [110529] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[chromium] Use projectQuad to apply inverse mapRect
https://bugs.webkit.org/show_bug.cgi?id=80741

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-12
Reviewed by Adrienne Walker.

Source/WebCore:

Unit test: CCOcclusionTrackerTest3dTransform

CCOcclusionTrackerTestPerspectiveTransform
CCOcclusionTrackerTestPerspectiveTransformBehindCamera

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::projectQuad):
(WebCore):
(WebCore::computeUnoccludedContentRect):

Source/WebKit/chromium:

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore):
(CCOcclusionTrackerTest3dTransform):
(WebCore::CCOcclusionTrackerTest3dTransform::runMyTest):
(CCOcclusionTrackerTestPerspectiveTransform):
(WebCore::CCOcclusionTrackerTestPerspectiveTransform::runMyTest):
(CCOcclusionTrackerTestPerspectiveTransformBehindCamera):
(WebCore::CCOcclusionTrackerTestPerspectiveTransformBehindCamera::runMyTest):

19:17 Changeset [110528] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Upstream the BlackBerry change to platform/graphics/FontPlatformData.h
https://bugs.webkit.org/show_bug.cgi?id=80820

Reviewed by Rob Buis.

The BlackBerry is using the FontPlatformData from Chromium porting.

  • platform/graphics/FontPlatformData.h:
18:58 Changeset [110527] by jberlin@webkit.org
  • 2 edits in trunk/Tools

More Windows build fixing.

  • DumpRenderTree/win/WorkQueueItemWin.cpp:
18:52 Changeset [110526] by zmo@google.com
  • 3 edits
    2 adds in trunk

After webgl canvas resize, bindings might be lost
https://bugs.webkit.org/show_bug.cgi?id=80895

Reviewed by Stephen White.

Source/WebCore:

Test: fast/canvas/webgl/texture-bindings-uneffected-on-resize.html

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::reshape): recover bindings after reshape.

LayoutTests:

  • fast/canvas/webgl/texture-bindings-uneffected-on-resize-expected.txt: Added.
  • fast/canvas/webgl/texture-bindings-uneffected-on-resize.html: Added.
18:38 Changeset [110525] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8][Refactoring] Remove getWrapper() and getWrapperSlow()
https://bugs.webkit.org/show_bug.cgi?id=80920

Reviewed by Adam Barth.

Now getWrapper() is the same as getExistingWrapper().
getWrapperSlow() is the same as getExistingWrapperSlow().
This patch removes getWrapper() and getWrapperSlow().
Also this patch renames getExistingWrapper() to getCachedWrapper().

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::getWrapperSlow):

  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getWrapper):
(V8DOMWrapper):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::toV8Slow):

18:37 Changeset [110524] by arv@chromium.org
  • 42 edits
    2 deletes in trunk

[V8] Use v8::V8::AddHiddenReferences instead of SetHiddenValue
https://bugs.webkit.org/show_bug.cgi?id=80880

Reviewed by Adam Barth.

Source/WebCore:

We used to add a hidden property in the getter to the returned wrapper.
With this patch we instead handle the liveness of the wrapper in the GC phase by
calling v8::V8::AddHiddenReference.

To reduce the amount of custom code we need, the V8 code generator now supports
GenerateIsReachable (as well as CustomIsReachable) which, even though different
from the JSC attribute, is used in the same cases and takes the same values (even though
at the moment not all JSC values are supported by V8).

No new tests. Covered by existing tests.

  • Target.pri:
  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorJS.pm:

(GetGenerateIsReachable):
(GetCustomIsReachable):
(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(NeedsToVisitDOMWrapper):
(GetGenerateIsReachable):
(GetCustomIsReachable):
(GenerateVisitDOMWrapper):
(GenerateHeader):
(GenerateNamedConstructorCallback):
(GenerateImplementation):

  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):

  • bindings/v8/NPV8Object.cpp:

(WebCore::npObjectTypeInfo):

  • bindings/v8/V8GCController.cpp:

(WebCore::GrouperVisitor::visitDOMWrapper):

  • bindings/v8/WrapperTypeInfo.h:

(WebCore):
(WrapperTypeInfo):

  • bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Removed.
  • bindings/v8/custom/V8DOMStringMapCustom.cpp:
  • bindings/v8/custom/V8DOMTokenListCustom.cpp: Removed.
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore):

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:
  • bindings/v8/custom/V8StyleSheetCustom.cpp:

(WebCore::toV8):

  • css/CSSStyleSheet.idl:
  • css/StyleSheet.idl:
  • dom/DOMStringMap.idl:
  • dom/NamedNodeMap.idl:
  • html/DOMTokenList.idl:
  • html/track/TextTrackList.idl:

LayoutTests:

  • platform/chromium/test_expectations.txt:
18:31 Changeset [110523] by jberlin@webkit.org
  • 7 edits in trunk/Tools

More Windows build fixing.

  • DumpRenderTree/win/AccessibilityControllerWin.cpp:
  • DumpRenderTree/win/EditingDelegate.cpp:
  • DumpRenderTree/win/EventSender.cpp:
  • DumpRenderTree/win/FrameLoadDelegate.cpp:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp:
  • DumpRenderTree/win/UIDelegate.cpp:
18:29 Changeset [110522] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Remove obsolete 'CPU' modifier.

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
18:27 LayoutUnit edited by leviw@chromium.org
(diff)
18:16 Changeset [110521] by barraclough@apple.com
  • 3 edits in trunk/LayoutTests

Object.defineProperty doesn't respect attributes when applied to the Global Object
https://bugs.webkit.org/show_bug.cgi?id=38636
Object.defineProperty doesn't create property on Global Object in the presence of a setter in the prototype chain
https://bugs.webkit.org/show_bug.cgi?id=48911

Rubber stamped by Michael Saboff.

  • fast/js/Object-defineProperty-expected.txt:
  • fast/js/script-tests/Object-defineProperty.js:
    • Added test cases for bugs #38636 & #48911.
18:13 Changeset [110520] by jberlin@webkit.org
  • 3 edits in trunk/Source/WebKit/win

More Windows build fixing.

  • MarshallingHelpers.cpp:
  • WebDatabaseManager.cpp:
18:10 Changeset [110519] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[V8][Refactoring] Make getWrapperSlow() and getExistingWrapperSlow() same
https://bugs.webkit.org/show_bug.cgi?id=80916

Reviewed by Adam Barth.

This is one of the steps for fixing bug 80841.
This patch makes getWrapperSlow() and getExistingWrapperSlow() same.
In the next patch, we will remove getExistingWrapper() and getExistingWrapperSlow().

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::getWrapperSlow):

18:05 Changeset [110518] by fpizlo@apple.com
  • 8 edits
    2 deletes in trunk/Source/JavaScriptCore

Arithmetic use inference should be procedure-global and should run in tandem
with type propagation
https://bugs.webkit.org/show_bug.cgi?id=80819
<rdar://problem/11034006>

Reviewed by Gavin Barraclough.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • dfg/DFGArithNodeFlagsInferencePhase.cpp: Removed.
  • dfg/DFGArithNodeFlagsInferencePhase.h: Removed.
  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::isNotNegZero):
(PredictionPropagationPhase):
(JSC::DFG::PredictionPropagationPhase::isNotZero):
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::mergeDefaultArithFlags):

  • dfg/DFGVariableAccessData.h:

(JSC::DFG::VariableAccessData::VariableAccessData):
(JSC::DFG::VariableAccessData::flags):
(VariableAccessData):
(JSC::DFG::VariableAccessData::mergeFlags):

18:02 Changeset [110517] by dpranke@chromium.org
  • 1 edit
    165 deletes in trunk/LayoutTests

Remove obsolete chromium-gpu-* platform directories for LayoutTests baselines.

Unreviewed, baselines change.

All of the baselines are now in platform/chromium-*/platform/chromium/virtual/gpu/*.

  • platform/chromium-gpu-linux/fast/canvas/arc360-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/canvas-before-css-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/canvas-bg-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/canvas-bg-expected.txt: Removed.
  • platform/chromium-gpu-linux/fast/canvas/canvas-composite-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/canvas-resize-reset-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/canvas-text-baseline-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/canvas-transforms-during-path-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/canvasDrawingIntoSelf-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/drawImage-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/fill-stroke-clip-reset-path-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/fillrect-gradient-zero-stops-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/fillrect_gradient-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/image-pattern-rotate-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/patternfill-repeat-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/quadraticCurveTo-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/setWidthResetAfterForcedRender-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-1-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-2-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-3-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-4-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-5-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-6-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-7-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/toDataURL-alpha-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/zero-size-fill-rect-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/media/mq-transform-02-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/media/mq-transform-02-expected.txt: Removed.
  • platform/chromium-gpu-linux/fast/media/mq-transform-03-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/media/mq-transform-03-expected.txt: Removed.
  • platform/chromium-gpu-linux/fast/repaint/canvas-putImageData-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/repaint/canvas-putImageData-expected.txt: Removed.
  • platform/chromium-gpu-linux/media/audio-controls-rendering-expected.png: Removed.
  • platform/chromium-gpu-linux/media/controls-after-reload-expected.png: Removed.
  • platform/chromium-gpu-linux/media/controls-strict-expected.png: Removed.
  • platform/chromium-gpu-linux/media/controls-styling-expected.png: Removed.
  • platform/chromium-gpu-linux/media/controls-without-preload-expected.png: Removed.
  • platform/chromium-gpu-linux/media/media-controls-clone-expected.png: Removed.
  • platform/chromium-gpu-linux/media/media-document-audio-repaint-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-aspect-ratio-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-canvas-alpha-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-colorspace-yuv420-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-colorspace-yuv422-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-controls-rendering-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-display-toggle-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-frame-accurate-seek-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-layer-crash-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-no-audio-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-playing-and-pause-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-transformed-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-volume-slider-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-zoom-controls-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-zoom-expected.png: Removed.
  • platform/chromium-gpu-mac/canvas/philip/tests/2d.gradient.radial.cone.cylinder-expected.txt: Removed.
  • platform/chromium-gpu-mac/canvas/philip/tests/2d.line.width.basic-expected.txt: Removed.
  • platform/chromium-gpu-mac/canvas/philip/tests/2d.line.width.transformed-expected.txt: Removed.
  • platform/chromium-gpu-mac/canvas/philip/tests/2d.path.arcTo.shape.curve1-expected.txt: Removed.
  • platform/chromium-gpu-mac/canvas/philip/tests/2d.path.arcTo.shape.curve2-expected.txt: Removed.
  • platform/chromium-gpu-mac/canvas/philip/tests/2d.shadow.enable.blur-expected.txt: Removed.
  • platform/chromium-gpu-mac/canvas/philip/tests/2d.text.draw.fontface.notinpage-expected.txt: Removed.
  • platform/chromium-gpu-mac/canvas/philip/tests/2d.transformation.setTransform.skewed-expected.txt: Removed.
  • platform/chromium-gpu-mac/canvas/philip/tests/2d.transformation.transform.skewed-expected.txt: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-as-image-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-bg-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-bg-zoom-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-composite-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-composite-fill-repaint-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-composite-transformclip-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-currentColor-expected.txt: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-fillPath-shadow-expected.txt: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-shadow-expected.txt: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-text-alignment-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-text-baseline-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-transform-skewed-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-transforms-during-path-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/fillrect-gradient-zero-stops-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/fillrect_gradient-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/image-object-in-canvas-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/image-pattern-rotate-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/patternfill-repeat-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/quadraticCurveTo-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/setWidthResetAfterForcedRender-expected.png: Removed.
  • platform/chromium-gpu-mac/media/controls-after-reload-expected.png: Removed.
  • platform/chromium-gpu-mac/media/controls-strict-expected.png: Removed.
  • platform/chromium-gpu-mac/media/controls-styling-expected.png: Removed.
  • platform/chromium-gpu-mac/media/controls-without-preload-expected.png: Removed.
  • platform/chromium-gpu-mac/media/video-aspect-ratio-expected.png: Removed.
  • platform/chromium-gpu-mac/media/video-controls-rendering-expected.png: Removed.
  • platform/chromium-gpu-mac/media/video-display-toggle-expected.png: Removed.
  • platform/chromium-gpu-mac/media/video-layer-crash-expected.png: Removed.
  • platform/chromium-gpu-mac/media/video-no-audio-expected.png: Removed.
  • platform/chromium-gpu-mac/media/video-playing-and-pause-expected.png: Removed.
  • platform/chromium-gpu-mac/media/video-transformed-expected.png: Removed.
  • platform/chromium-gpu-mac/media/video-volume-slider-expected.png: Removed.
  • platform/chromium-gpu-mac/media/video-zoom-controls-expected.png: Removed.
  • platform/chromium-gpu-mac/media/video-zoom-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/arc360-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-as-image-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-as-image-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-as-image-incremental-repaint-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-as-image-incremental-repaint-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-before-css-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-bg-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-bg-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-bg-zoom-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-bg-zoom-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-composite-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-composite-fill-repaint-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-composite-transformclip-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-empty-image-pattern-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-resize-reset-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-text-baseline-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-identity-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-infinity-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-multiply-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-nan-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-non-invertible-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-skewed-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-transforms-during-path-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvasDrawingIntoSelf-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/drawImage-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/fill-stroke-clip-reset-path-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/fillrect-gradient-zero-stops-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/fillrect_gradient-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/gradient-add-second-start-end-stop-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/image-object-in-canvas-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/image-pattern-rotate-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/patternfill-repeat-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/quadraticCurveTo-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/setWidthResetAfterForcedRender-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-1-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-2-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-3-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-4-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-5-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-6-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-7-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/toDataURL-alpha-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/zero-size-fill-rect-expected.png: Removed.
  • platform/chromium-gpu-win/media/controls-after-reload-expected.png: Removed.
  • platform/chromium-gpu-win/media/controls-strict-expected.png: Removed.
  • platform/chromium-gpu-win/media/controls-styling-expected.png: Removed.
  • platform/chromium-gpu-win/media/controls-without-preload-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-aspect-ratio-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-canvas-alpha-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-colorspace-yuv420-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-colorspace-yuv422-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-controls-rendering-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-display-toggle-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-frame-accurate-seek-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-layer-crash-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-no-audio-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-playing-and-pause-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-transformed-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-volume-slider-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-zoom-controls-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-zoom-expected.png: Removed.
  • platform/chromium-gpu/media/video-colorspace-yuv420-expected.png: Removed.
  • platform/chromium-gpu/media/video-colorspace-yuv422-expected.png: Removed.
  • platform/chromium-gpu/media/video-frame-accurate-seek-expected.png: Removed.
17:55 Changeset [110516] by dpranke@chromium.org
  • 3 edits in trunk/Tools

remove the 'gpu' group from the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=80353

Reviewed by Adam Barth.

Since those bots are obsolete, we don't need this any more.

  • TestResultServer/static-dashboards/builders.js:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:

(testPlatformAndBuildType):
(testHtmlForTestTypeSwitcherGroup):

17:53 Changeset [110515] by haraken@chromium.org
  • 7 edits in trunk/Source/WebCore

[V8] Refactor some header includes in V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=80913

Reviewed by Adam Barth.

This patch refactors some header includes in V8 bindings
required for fixing bug 80841.

No tests. No change in behavior.

  • bindings/v8/DOMDataStore.h:

(DOMDataStore):

  • bindings/v8/V8DOMMap.h:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8IsolatedContext.cpp:

(WebCore::V8IsolatedContext::isolatedContext):

  • bindings/v8/V8IsolatedContext.h:

(WebCore::V8IsolatedContext::getEntered):
(V8IsolatedContext):

  • bindings/v8/WorldContextHandle.cpp:
17:50 Changeset [110514] by dpranke@chromium.org
  • 19 edits in trunk/Tools

remove graphics_type from webkitpy.layout_tests.models.test_configuration
https://bugs.webkit.org/show_bug.cgi?id=80643

Reviewed by Ojan Vafai.

Now that the chromium-gpu ports are gone, there's no need for
the graphics_type CPU/GPU distinction. Most of this change is
just updating tests accordingly.

  • Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:

(TestExpectationEditorTests):

  • Scripts/webkitpy/layout_tests/models/test_configuration.py:

(TestConfiguration.init):
(TestConfiguration.category_order):
(TestConfiguration.str):
(TestConfiguration.repr):
(TestConfiguration.hash):
(TestConfigurationConverter.to_specifiers_list):

  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:

(make_mock_all_test_configurations_set):
(TestConfigurationTest.test_items):
(TestConfigurationTest.test_keys):
(TestConfigurationTest.test_str):
(TestConfigurationTest.test_repr):
(TestConfigurationTest.test_hash):
(TestConfigurationTest.test_hash.query_unknown_key):
(TestConfigurationTest.test_eq):
(TestConfigurationTest.test_values):
(SpecifierSorterTest.test_specifier_priority):
(SpecifierSorterTest.test_sort_specifiers):
(TestConfigurationConverterTest.test_to_config_set):
(TestConfigurationConverterTest.test_macro_expansion):
(TestConfigurationConverterTest.test_to_specifier_lists):
(TestConfigurationConverterTest.test_converter_macro_collapsing):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(test_error_on_different_build_type):
(TestExpectationSerializerTests.test_parsed_to_string):
(TestExpectationSerializerTests.test_reconstitute_only_these):

  • Scripts/webkitpy/layout_tests/port/apple.py:

(ApplePort._generate_all_test_configurations):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.init):
(Port.name):
(Port.version):
(Port.test_configuration):

  • Scripts/webkitpy/layout_tests/port/builders.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort):
(ChromiumPort._generate_all_test_configurations):

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:

(ChromiumLinuxPort.init):

  • Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:

(ChromiumLinuxPortTest.test_check_illegal_port_names):

  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:

(ChromiumMacPortTest.test_baseline_path):

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumPortTest.test_all_test_configurations):

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort._generate_all_test_configurations):

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort._generate_all_test_configurations):

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort._generate_all_test_configurations):

  • Scripts/webkitpy/layout_tests/port/test.py:

(TestPort.all_test_configurations):
(TestPort._all_build_types):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:

(BuildCoverageExtrapolatorTest.test_extrapolate):
(GardeningExpectationsUpdaterTest.test_unknown_failure_type):
(GardeningExpectationsUpdaterTest.test_add_new_expectation):
(GardeningExpectationsUpdaterTest.test_replace_old_expectation):
(GardeningExpectationsUpdaterTest.test_pass_expectation):
(GardeningExpectationsUpdaterTest.test_supplement_old_expectation):
(GardeningExpectationsUpdaterTest.test_spurious_updates):

17:43 Changeset [110513] by dpranke@chromium.org
  • 8 edits in trunk/Tools

_runtime_feature_list isn't supported on Apple Mac DRT
https://bugs.webkit.org/show_bug.cgi?id=80906

Reviewed by Eric Seidel.

It looks like this feature is actually only supported on the Win
DRT port, so this patch reworks the code to make that clearer
and reduce unnecessary overrides.

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort._path_to_webcore_library):

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort._path_to_webcore_library):

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort._skipped_file_search_paths):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._runtime_feature_list):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(TestWebKitPort.init):
(TestWebKitPort.all_test_configurations):
(test_skipped_directories_for_features):

  • Scripts/webkitpy/layout_tests/port/win.py:

(WinPort):
(WinPort._runtime_feature_list):

  • Scripts/webkitpy/layout_tests/port/win_unittest.py:

(WinPortTest.test_operating_system):
(WinPortTest):
(WinPortTest.test_runtime_feature_list):

17:31 Changeset [110512] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

Fix typo in PageClientImpl where we were overriding viewLayerHostingMode with
a function called layerHostingMode.

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::viewLayerHostingMode):
Update name and add OVERRIDE to catch this in the future.

17:22 Changeset [110511] by commit-queue@webkit.org
  • 11 edits
    13 moves in trunk/Source/WebCore

Unreviewed, rolling out r110501.
http://trac.webkit.org/changeset/110501
https://bugs.webkit.org/show_bug.cgi?id=80908

Broke the Apple-Win build (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-12

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.xcodeproj/project.pbxproj:
  • fileapi/DirectoryEntry.cpp: Renamed from Source/WebCore/Modules/filesystem/DirectoryEntry.cpp.

(WebCore):
(WebCore::DirectoryEntry::DirectoryEntry):
(WebCore::DirectoryEntry::createReader):
(WebCore::DirectoryEntry::getFile):
(WebCore::DirectoryEntry::getDirectory):
(WebCore::DirectoryEntry::removeRecursively):

  • fileapi/DirectoryEntry.h: Renamed from Source/WebCore/Modules/filesystem/DirectoryEntry.h.

(WebCore):
(DirectoryEntry):
(WebCore::DirectoryEntry::create):
(WebCore::DirectoryEntry::isDirectory):

  • fileapi/DirectoryEntry.idl: Renamed from Source/WebCore/Modules/filesystem/DirectoryEntry.idl.
  • fileapi/DirectoryEntrySync.cpp: Renamed from Source/WebCore/Modules/filesystem/DirectoryEntrySync.cpp.

(WebCore):
(WebCore::DirectoryEntrySync::DirectoryEntrySync):
(WebCore::DirectoryEntrySync::createReader):
(WebCore::DirectoryEntrySync::getFile):
(WebCore::DirectoryEntrySync::getDirectory):
(WebCore::DirectoryEntrySync::removeRecursively):

  • fileapi/DirectoryEntrySync.h: Renamed from Source/WebCore/Modules/filesystem/DirectoryEntrySync.h.

(WebCore):
(DirectoryEntrySync):
(WebCore::DirectoryEntrySync::create):
(WebCore::DirectoryEntrySync::isDirectory):

  • fileapi/DirectoryEntrySync.idl: Renamed from Source/WebCore/Modules/filesystem/DirectoryEntrySync.idl.
  • fileapi/DirectoryReader.cpp: Renamed from Source/WebCore/Modules/filesystem/DirectoryReader.cpp.

(WebCore):
(WebCore::DirectoryReader::DirectoryReader):
(WebCore::DirectoryReader::readEntries):

  • fileapi/DirectoryReader.h: Renamed from Source/WebCore/Modules/filesystem/DirectoryReader.h.

(WebCore):
(DirectoryReader):
(WebCore::DirectoryReader::create):
(WebCore::DirectoryReader::filesystem):

  • fileapi/DirectoryReader.idl: Renamed from Source/WebCore/Modules/filesystem/DirectoryReader.idl.
  • fileapi/DirectoryReaderBase.h: Renamed from Source/WebCore/Modules/filesystem/DirectoryReaderBase.h.

(WebCore):
(DirectoryReaderBase):
(WebCore::DirectoryReaderBase::filesystem):
(WebCore::DirectoryReaderBase::setHasMoreEntries):
(WebCore::DirectoryReaderBase::DirectoryReaderBase):

  • fileapi/DirectoryReaderSync.cpp: Renamed from Source/WebCore/Modules/filesystem/DirectoryReaderSync.cpp.

(WebCore):
(WebCore::DirectoryReaderSync::DirectoryReaderSync):
(WebCore::DirectoryReaderSync::readEntries):

  • fileapi/DirectoryReaderSync.h: Renamed from Source/WebCore/Modules/filesystem/DirectoryReaderSync.h.

(WebCore):
(DirectoryReaderSync):
(WebCore::DirectoryReaderSync::create):

  • fileapi/DirectoryReaderSync.idl: Renamed from Source/WebCore/Modules/filesystem/DirectoryReaderSync.idl.
17:15 Changeset [110510] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium/mac] Make sure libWebKitSystemInterface.a doesn't contain ppc object files.
https://bugs.webkit.org/show_bug.cgi?id=80902

Reviewed by Adam Barth.

Follow-up to http://codereview.chromium.org/9638015/

No intended behavior change.

  • WebCore.gyp/mac/adjust_visibility.sh:
17:14 Changeset [110509] by leviw@chromium.org
  • 4 edits in branches/subpixellayout/Source/WebCore/rendering

Fixing/cleaning up rounding in RenderReplaced classes, and removing an unnecessary static_cast in RenderFrameSet.

17:09 Changeset [110508] by eae@chromium.org
  • 2 edits in branches/subpixellayout/Source

Qt build fixes for branch.

17:09 Changeset [110507] by jer.noble@apple.com
  • 37 edits in trunk/Source/WebCore

WebCore: Add support for AudioNode "tailTime()" and "latencyTime()"
https://bugs.webkit.org/show_bug.cgi?id=74750

Reviewed by Chris Rogers.

No new tests; optimization of existing code path, so covered by existing tests.

To account for AudioNodes which may generate non-silent audio when fed silent input
for a certain amount of time after the last non-silent audio data, add two new virtual
functions tailTime() and latencyTime().

  • webaudio/AudioNode.h:

(WebCore::AudioNode::tailTime): Added. Pure virtual.
(WebCore::AudioNode::latencyTime): Added. Pure virtual.

  • platform/audio/AudioProcessor.h:

(WebCore::AudioProcessor::tailTime): Added. Pure virtual.
(WebCore::AudioProcessor::latencyTime): Added. Pure virtual.

  • platform/audio/AudioDSPKernel.h:

(WebCore::AudioDSPKernel::tailTime): Added. Pure virtual.
(WebCore::AudioDSPKernel::latencyTime): Added. Pure virtual.

Added tailTime() and latencyTime() overrides to the following classes:

  • platform/audio/AudioDSPKernelProcessor.cpp:

(WebCore::AudioDSPKernelProcessor::tailTime):
(WebCore::AudioDSPKernelProcessor::latencyTime):

  • platform/audio/AudioDSPKernelProcessor.h:
  • platform/audio/DynamicsCompressor.h:

(WebCore::DynamicsCompressor::tailTime):
(WebCore::DynamicsCompressor::latencyTime):

  • platform/audio/EqualPowerPanner.h:
  • platform/audio/HRTFPanner.cpp:

(WebCore::HRTFPanner::tailTime):
(WebCore::HRTFPanner::latencyTime):

  • platform/audio/HRTFPanner.h:
  • platform/audio/Panner.h:
  • webaudio/AudioBasicProcessorNode.cpp:

(WebCore::AudioBasicProcessorNode::tailTime):
(WebCore::AudioBasicProcessorNode::latencyTime):

  • webaudio/AudioBasicProcessorNode.h:
  • webaudio/AudioChannelMerger.h:
  • webaudio/AudioChannelSplitter.h:
  • webaudio/AudioDestinationNode.h:
  • webaudio/AudioGainNode.h:
  • webaudio/AudioPannerNode.h:
  • webaudio/AudioSourceNode.h:
  • webaudio/BiquadDSPKernel.cpp:

(WebCore::BiquadDSPKernel::tailTime):
(WebCore::BiquadDSPKernel::latencyTime):

  • webaudio/BiquadDSPKernel.h:
  • webaudio/BiquadFilterNode.h:
  • webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::tailTime):
(WebCore::ConvolverNode::latencyTime):

  • webaudio/ConvolverNode.h:
  • webaudio/DelayDSPKernel.cpp:

(WebCore::DelayDSPKernel::tailTime):
(WebCore::DelayDSPKernel::latencyTime):

  • webaudio/DelayDSPKernel.h:
  • webaudio/DelayProcessor.h:
  • webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::tailTime):
(WebCore::DynamicsCompressorNode::latencyTime):

  • webaudio/DynamicsCompressorNode.h:
  • webaudio/JavaScriptAudioNode.cpp:

(WebCore::JavaScriptAudioNode::tailTime):
(WebCore::JavaScriptAudioNode::latencyTime):

  • webaudio/JavaScriptAudioNode.h:
  • webaudio/RealtimeAnalyserNode.h:
  • webaudio/WaveShaperDSPKernel.h:

The following functions were added as support for the new AudioNode and AudioProcessor functions:

  • platform/audio/Biquad.cpp:

(WebCore::Biquad::latencyFrames):

  • platform/audio/Biquad.h:
  • platform/audio/Reverb.cpp:

(WebCore::Reverb::latencyFrames):

  • platform/audio/ReverbConvolver.h:

(WebCore::ReverbConvolver::latencyFrames):

The following functions were made const-correct:

  • platform/audio/HRTFPanner.h:

(WebCore::HRTFPanner::fftSize):

  • platform/audio/Reverb.h:

(WebCore::Reverb::impulseResponseLength):

17:07 Changeset [110506] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

WebTileLayers should be opaque
https://bugs.webkit.org/show_bug.cgi?id=80907
<rdar://problem/11034390>

Reviewed by Andreas Kling.

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::createTileLayer):
Call -[CALayer setOpaque:] on the newly created WebTileLayer.

17:05 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
16:51 Changeset [110505] by eae@chromium.org
  • 4 edits in trunk/Source/WebCore

Fix rounding in scrollbar rect calculations
https://bugs.webkit.org/show_bug.cgi?id=80894

Reviewed by Eric Seidel.

Fix usage of subpixel units in RenderScrollbar::buttonRect and
RenderScrollbar::trackRect.

No new tests, no new functionality.

  • rendering/LayoutTypes.h:

(WebCore::isIntegerValue):
Add dummy isIntegerValue function, will be replaced with actual
implementation once LayoutUnit is remapped to FractionalLayoutUnit.

  • rendering/RenderScrollbar.cpp:

(WebCore::RenderScrollbar::buttonRect):
(WebCore::RenderScrollbar::trackRect):
Change rect calculations to use pixel snapped values.

  • rendering/RenderScrollbarPart.h:

(RenderScrollbarPart):
(WebCore::RenderScrollbarPart::marginTop):
(WebCore::RenderScrollbarPart::marginBottom):
(WebCore::RenderScrollbarPart::marginLeft):
(WebCore::RenderScrollbarPart::marginRight):
Add ASSERT to ensure that scrollbar parts are always aligned to device
pixels.

16:46 Changeset [110504] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GObject IDL Parser] STRING argument should be HASHREF
https://bugs.webkit.org/show_bug.cgi?id=78877

Patch by C Anthony Risinger <anthony@xtfx.me> on 2012-03-12
Reviewed by Kentaro Hara.

  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateFunctions): extendedAttributes are hashes, not strings

16:43 Changeset [110503] by jberlin@webkit.org
  • 7 edits in trunk/Source/WebCore

More Windows build fixing.

Use fully qualified paths for WTF headers.

  • platform/graphics/cg/ImageSourceCGWin.cpp:
  • platform/graphics/win/UniscribeController.h:
  • platform/win/DragImageCGWin.cpp:
  • platform/win/DragImageCairoWin.cpp:
  • platform/win/DragImageWin.cpp:
  • rendering/RenderThemeSafari.cpp:
16:40 Changeset [110502] by abarth@webkit.org
  • 1 edit
    1 add
    1 delete in trunk/LayoutTests

This baseline also applies to chromium-mac-snowleopard, so we can move
it up the fallback chain.

  • platform/chromium-mac-leopard/fast/events/scrollbar-double-click-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/events/scrollbar-double-click-expected.txt: Added.
16:38 Changeset [110501] by commit-queue@webkit.org
  • 11 edits
    13 moves
    1 add in trunk/Source/WebCore

Move DirectoryEntry and DirectoryReader to new Modules/filesystem/ directory
https://bugs.webkit.org/show_bug.cgi?id=80625

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-03-12
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • Modules/filesystem: Added.
  • Modules/filesystem/DirectoryEntry.cpp: Copied from Source/WebCore/fileapi/DirectoryEntry.cpp.
  • Modules/filesystem/DirectoryEntry.h: Copied from Source/WebCore/fileapi/DirectoryEntry.h.
  • Modules/filesystem/DirectoryEntry.idl: Copied from Source/WebCore/fileapi/DirectoryEntry.idl.
  • Modules/filesystem/DirectoryEntrySync.cpp: Copied from Source/WebCore/fileapi/DirectoryEntrySync.cpp.
  • Modules/filesystem/DirectoryEntrySync.h: Copied from Source/WebCore/fileapi/DirectoryEntrySync.h.
  • Modules/filesystem/DirectoryEntrySync.idl: Copied from Source/WebCore/fileapi/DirectoryEntrySync.idl.
  • Modules/filesystem/DirectoryReader.cpp: Copied from Source/WebCore/fileapi/DirectoryReader.cpp.
  • Modules/filesystem/DirectoryReader.h: Copied from Source/WebCore/fileapi/DirectoryReader.h.
  • Modules/filesystem/DirectoryReader.idl: Copied from Source/WebCore/fileapi/DirectoryReader.idl.
  • Modules/filesystem/DirectoryReaderBase.h: Copied from Source/WebCore/fileapi/DirectoryReaderBase.h.
  • Modules/filesystem/DirectoryReaderSync.cpp: Copied from Source/WebCore/fileapi/DirectoryReaderSync.cpp.
  • Modules/filesystem/DirectoryReaderSync.h: Copied from Source/WebCore/fileapi/DirectoryReaderSync.h.
  • Modules/filesystem/DirectoryReaderSync.idl: Copied from Source/WebCore/fileapi/DirectoryReaderSync.idl.
  • Target.pri:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.xcodeproj/project.pbxproj:
  • fileapi/DirectoryEntry.cpp: Removed.
  • fileapi/DirectoryEntry.h: Removed.
  • fileapi/DirectoryEntry.idl: Removed.
  • fileapi/DirectoryEntrySync.cpp: Removed.
  • fileapi/DirectoryEntrySync.h: Removed.
  • fileapi/DirectoryEntrySync.idl: Removed.
  • fileapi/DirectoryReader.cpp: Removed.
  • fileapi/DirectoryReader.h: Removed.
  • fileapi/DirectoryReader.idl: Removed.
  • fileapi/DirectoryReaderBase.h: Removed.
  • fileapi/DirectoryReaderSync.cpp: Removed.
  • fileapi/DirectoryReaderSync.h: Removed.
  • fileapi/DirectoryReaderSync.idl: Removed.
16:34 Changeset [110500] by beidson@apple.com
  • 4 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=80903 InspectorDOMStorageAgent creates a Storage object which is a DOMWindowProperty - Should use the StorageArea directly

Reviewed by Tim Hatcher.

No new tests. (No behavior change)

Changed to hold the StorageArea directly and added a Frame* accessor:

  • inspector/InspectorDOMStorageResource.h:

(WebCore::InspectorDOMStorageResource::create):
(WebCore::InspectorDOMStorageResource::storageArea):
(WebCore::InspectorDOMStorageResource::frame):
(InspectorDOMStorageResource):

  • inspector/InspectorDOMStorageResource.cpp:

(WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource):

  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::didUseDOMStorage):

16:23 Changeset [110499] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

[Skia] Release CGImage used to apply color space conversion to SkBitmap
https://bugs.webkit.org/show_bug.cgi?id=80892

Patch by Brian Salomon <bsalomon@google.com> on 2012-03-12
Reviewed by Adam Barth.

Regressions should be covered by any test that does image decode on the mac.

  • platform/image-decoders/skia/ImageDecoderSkia.cpp:

(WebCore::resolveColorSpace):

16:15 Changeset [110498] by fpizlo@apple.com
  • 20 edits
    1 move
    2 adds in trunk/Source/JavaScriptCore

Node::op and Node::flags should be private
https://bugs.webkit.org/show_bug.cgi?id=80824
<rdar://problem/11033435>

Reviewed by Gavin Barraclough.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::mergeStateAtTail):
(JSC::DFG::AbstractState::mergeToSuccessors):

  • dfg/DFGArithNodeFlagsInferencePhase.cpp:

(JSC::DFG::ArithNodeFlagsInferencePhase::propagate):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::injectLazyOperandPrediction):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::flushArgument):
(JSC::DFG::ByteCodeParser::toInt32):
(JSC::DFG::ByteCodeParser::isJSConstant):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::linkBlock):

  • dfg/DFGCFAPhase.cpp:

(JSC::DFG::CFAPhase::performBlockCFA):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::canonicalize):
(JSC::DFG::CSEPhase::endIndexForPureCSE):
(JSC::DFG::CSEPhase::pureCSE):
(JSC::DFG::CSEPhase::byValIsPure):
(JSC::DFG::CSEPhase::clobbersWorld):
(JSC::DFG::CSEPhase::impureCSE):
(JSC::DFG::CSEPhase::globalVarLoadElimination):
(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::checkFunctionElimination):
(JSC::DFG::CSEPhase::checkStructureLoadElimination):
(JSC::DFG::CSEPhase::getByOffsetLoadElimination):
(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::getScopeChainLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(DFG):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::addShouldSpeculateInteger):
(JSC::DFG::Graph::negateShouldSpeculateInteger):
(JSC::DFG::Graph::methodOfGettingAValueProfileFor):

  • dfg/DFGNode.cpp: Removed.
  • dfg/DFGNode.h:

(DFG):
(JSC::DFG::Node::Node):
(Node):
(JSC::DFG::Node::op):
(JSC::DFG::Node::flags):
(JSC::DFG::Node::setOp):
(JSC::DFG::Node::setFlags):
(JSC::DFG::Node::mergeFlags):
(JSC::DFG::Node::filterFlags):
(JSC::DFG::Node::clearFlags):
(JSC::DFG::Node::setOpAndDefaultFlags):
(JSC::DFG::Node::mustGenerate):
(JSC::DFG::Node::isConstant):
(JSC::DFG::Node::isWeakConstant):
(JSC::DFG::Node::valueOfJSConstant):
(JSC::DFG::Node::hasVariableAccessData):
(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::resolveGlobalDataIndex):
(JSC::DFG::Node::hasArithNodeFlags):
(JSC::DFG::Node::arithNodeFlags):
(JSC::DFG::Node::setArithNodeFlag):
(JSC::DFG::Node::mergeArithNodeFlags):
(JSC::DFG::Node::hasConstantBuffer):
(JSC::DFG::Node::hasRegexpIndex):
(JSC::DFG::Node::hasVarNumber):
(JSC::DFG::Node::hasScopeChainDepth):
(JSC::DFG::Node::hasResult):
(JSC::DFG::Node::hasInt32Result):
(JSC::DFG::Node::hasNumberResult):
(JSC::DFG::Node::hasJSResult):
(JSC::DFG::Node::hasBooleanResult):
(JSC::DFG::Node::isJump):
(JSC::DFG::Node::isBranch):
(JSC::DFG::Node::isTerminal):
(JSC::DFG::Node::hasHeapPrediction):
(JSC::DFG::Node::hasFunctionCheckData):
(JSC::DFG::Node::hasStructureTransitionData):
(JSC::DFG::Node::hasStructureSet):
(JSC::DFG::Node::hasStorageAccessData):
(JSC::DFG::Node::hasFunctionDeclIndex):
(JSC::DFG::Node::hasFunctionExprIndex):
(JSC::DFG::Node::child1):
(JSC::DFG::Node::child2):
(JSC::DFG::Node::child3):
(JSC::DFG::Node::firstChild):
(JSC::DFG::Node::numChildren):

  • dfg/DFGNodeFlags.cpp: Copied from Source/JavaScriptCore/dfg/DFGNode.cpp.
  • dfg/DFGNodeFlags.h: Added.

(DFG):
(JSC::DFG::nodeUsedAsNumber):
(JSC::DFG::nodeCanTruncateInteger):
(JSC::DFG::nodeCanIgnoreNegativeZero):
(JSC::DFG::nodeMayOverflow):
(JSC::DFG::nodeCanSpeculateInteger):

  • dfg/DFGNodeType.h: Added.

(DFG):
(JSC::DFG::defaultFlags):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::vote):
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):
(JSC::DFG::PredictionPropagationPhase::fixupNode):

  • dfg/DFGRedundantPhiEliminationPhase.cpp:

(JSC::DFG::RedundantPhiEliminationPhase::run):
(JSC::DFG::RedundantPhiEliminationPhase::replacePhiChild):
(JSC::DFG::RedundantPhiEliminationPhase::updateBlockVariableInformation):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::useChildren):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
(JSC::DFG::SpeculativeJIT::compileUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compare):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGVirtualRegisterAllocationPhase.cpp:

(JSC::DFG::VirtualRegisterAllocationPhase::run):

16:10 Changeset [110497] by eae@chromium.org
  • 6 edits in branches/subpixellayout/Source

Fix scrollbar rect calculations on branch.

15:59 Changeset [110496] by leviw@chromium.org
  • 7 edits in trunk/Source/WebCore

Update LayoutUnit usage in RenderMathML* classes
https://bugs.webkit.org/show_bug.cgi?id=77916

Reviewed by Eric Seidel.

The purpose of this patch is to ensure MathML rendering does not regress when
we switch to sub-pixel layout. A subsequent patch can likely improve MathML's
rendering when zoom is applied.

To accomplish this without changing the current heuristics for positioning,
we continue to use integers for sizes and locations, using pixel snapping
when communicating with other Rendering classes.

No new tests. No change in behavior.

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::paint): Cleaning up debug painting to be on
pixel boundaries instead of subpixel.

  • rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::paint): Reverting to integers for determining
the vertical offset.
(WebCore::RenderMathMLFraction::baselinePosition):

  • rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::paint): Using integers for height and width
and only accumulating pixel snapped values.
(WebCore::RenderMathMLRoot::layout): Setting padding with integers to
avoid inconsistent rounding based on the root's location.

  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::layout):

  • rendering/mathml/RenderMathMLSquareRoot.cpp:

(WebCore::RenderMathMLSquareRoot::paint): See RenderMathMLRoot.
(WebCore::RenderMathMLSquareRoot::layout): Ditto.

  • rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore::getOffsetHeight):
(WebCore::RenderMathMLUnderOver::layout):

15:57 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
15:48 Changeset [110495] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Use smaller tiles for right and bottom edges
https://bugs.webkit.org/show_bug.cgi?id=80893
<rdar://problem/11032873>

Reviewed by Sam Weinig.

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::rectForTileIndex):
Intersect the rect with the tile cache bounds.

(WebCore::TileCache::revalidateTiles):
Resize already existing tiles if needed.

(WebCore::TileCache::createTileLayer):
This now takes a tile rect. Use setFrame instead of setting the bounds and position separately.

15:45 Changeset [110494] by enrica@apple.com
  • 21 edits in trunk

Source/WebCore: WebKit2: remove NSPasteboard access for promised data from the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=80073

Reviewed by Alexey Proskuryakov.

  • WebCore.exp.in: Added two exported methods.
  • platform/mac/FileSystemMac.mm:

(WebCore::setMetaData): Last parameter in the call to wkSetMetadataURL
needs to be wrapped in String before casting to NSString.

Source/WebKit2: WebKit2: remove NSPasteboard access for promised data from the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=80073

Reviewed by Alexey Proskuryakov.

This patch removes the last remaining access to NSPasteboard from the WebProcess.
The code in WebDragClient::declareAndWriteDragImage now packages all the data
required for the drag and the promised drag types and sends one request to the UI
process that will place the data in the NSPasteboard when appropriate.

  • UIProcess/API/mac/PageClientImpl.h: Added setPromisedData method.
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setPromisedData):

  • UIProcess/API/mac/WKView.mm:

(matchesExtensionOrEquivalent): Added.
(fileExists): Added.
(pathWithUniqueFilenameForPath): Added.
(-[WKView _setPromisedData:WebCore::withFileName:withExtension:withTitle:withURL:withVisibleURL:withArchive:WebCore::forPasteboard:]):
(-[WKView pasteboardChangedOwner:]):
(-[WKView pasteboard:provideDataForType:]):
(-[WKView namesOfPromisedFilesDroppedAtDestination:]):

  • UIProcess/API/mac/WKViewInternal.h: Added _setPromisedData.
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h: Added method for the new message.
  • UIProcess/WebPageProxy.messages.in: Added setPromisedData message.
  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::setPromisedData):

  • WebProcess/WebCoreSupport/WebDragClient.cpp:
  • WebProcess/WebCoreSupport/WebDragClient.h:
  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::WebDragClient::declareAndWriteDragImage):

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Added SetMetadataURL.

WebKitLibraries: WebKit2: remove NSPasteboard access for promised data from the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=80073

  • WebKitSystemInterface.h: Touched the file to make build system happy.
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
15:40 Changeset [110493] by abarth@webkit.org
  • 10 edits in trunk/LayoutTests

Update expected results after http://trac.webkit.org/changeset/110480.
These results are very similar to our previous results and seem
slightly improved AFAICT.

  • platform/chromium-mac-leopard/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-disabled-color-expected.png:
  • platform/chromium-mac-leopard/fast/forms/text-style-color-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug99948-expected.png:
  • platform/chromium-mac-snowleopard/fast/block/float/032-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-disabled-color-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/text-style-color-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug99948-expected.png:
15:38 Changeset [110492] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[Blackberry] Make the process of marking all matches interruptible and asynchronous for find-in-page
https://bugs.webkit.org/show_bug.cgi?id=80831

Patch by Andy Chen <andchen@rim.com> on 2012-03-12
Reviewed by Antonio Gomes.

  • WebKitSupport/InPageSearchManager.cpp:

(BlackBerry::WebKit::InPageSearchManager::DeferredScopeStringMatches::DeferredScopeStringMatches):
(BlackBerry::WebKit::InPageSearchManager::DeferredScopeStringMatches::doTimeout):
(BlackBerry::WebKit::InPageSearchManager::InPageSearchManager):
(BlackBerry::WebKit::InPageSearchManager::~InPageSearchManager):
(BlackBerry::WebKit::InPageSearchManager::findNextString):
(BlackBerry::WebKit::InPageSearchManager::shouldSearchForText):
(BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
(BlackBerry::WebKit::InPageSearchManager::clearTextMatches):
(BlackBerry::WebKit::InPageSearchManager::frameUnloaded):
(BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
(BlackBerry::WebKit::InPageSearchManager::scopeStringMatchesSoon):
(BlackBerry::WebKit::InPageSearchManager::callScopeStringMatches):
(BlackBerry::WebKit::InPageSearchManager::cancelPendingScopingEffort):

  • WebKitSupport/InPageSearchManager.h:
15:37 Changeset [110491] by abarth@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Restore previous expecation for chromium-mac-leopard. rniwa says this
is the right thing to do.

  • platform/chromium-mac-leopard/fast/events/scrollbar-double-click-expected.txt: Added.
15:28 Changeset [110490] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

Yet another Mac rebaseline.

  • editing/pasteboard/dataTransfer-setData-getData-expected.txt:
  • platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
15:24 Changeset [110489] by commit-queue@webkit.org
  • 3 edits
    1 add
    4 deletes in trunk/LayoutTests

Convert some fast/regions pixel tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=79132

Patch by Rebecca Hauck <rhauck@adobe.com> on 2012-03-12
Reviewed by Dirk Schulze.

  • fast/regions/floats-basic-in-variable-width-regions-expected.html: Added.
  • fast/regions/floats-basic-in-variable-width-regions.html:
  • platform/chromium/test_expectations.txt:
  • platform/efl/fast/regions/floats-basic-in-variable-width-regions-expected.png: Removed.
  • platform/efl/fast/regions/floats-basic-in-variable-width-regions-expected.txt: Removed.
  • platform/mac/fast/regions/floats-basic-in-variable-width-regions-expected.png: Removed.
  • platform/mac/fast/regions/floats-basic-in-variable-width-regions-expected.txt: Removed.
15:22 Changeset [110488] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

clang build fix

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::convertToLength): Reorder
boolean operators, so that a warning about "use of logical
with constant operand" doesn't

appear.

15:17 Changeset [110487] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash in Text::splitText due to mutation events.
https://bugs.webkit.org/show_bug.cgi?id=80828

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/text/split-text-crash.xhtml

  • dom/Range.cpp:

(WebCore::Range::insertNode): replace m_start.container() calls with ref protected node.

LayoutTests:

  • fast/text/split-text-crash-expected.txt: Added.
  • fast/text/split-text-crash.xhtml: Added.
14:59 Changeset [110486] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Fix clang build for CCOcclusionTracker tests
https://bugs.webkit.org/show_bug.cgi?id=80891

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-12
Reviewed by Adam Barth.

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore::CCOcclusionTrackerTest::createRoot):
(WebCore::CCOcclusionTrackerTest::createLayer):
(WebCore::CCOcclusionTrackerTest::createDrawingLayer):

14:59 Changeset [110485] by kbr@google.com
  • 6 edits in trunk

Null argument to texSubImage2D crashes
https://bugs.webkit.org/show_bug.cgi?id=80778

Reviewed by Dean Jackson.

Source/WebCore:

Generate INVALID_VALUE OpenGL error upon receiving null argument.
Final behavior still being decided on public-webgl mailing list.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::texImage2D):
(WebCore::WebGLRenderingContext::texSubImage2D):
(WebCore::WebGLRenderingContext::validateTexFuncData):

  • html/canvas/WebGLRenderingContext.h:

LayoutTests:

Updated tex-sub-image-2d-bad-args test to verify new behavior.

  • fast/canvas/webgl/tex-sub-image-2d-bad-args-expected.txt:
  • fast/canvas/webgl/tex-sub-image-2d-bad-args.html:
14:54 Changeset [110484] by macpherson@chromium.org
  • 4 edits in trunk/Source/WebCore

Remove CSSStyleSelector's convertToLength method and use CSSPrimitiveValue's version directly.
https://bugs.webkit.org/show_bug.cgi?id=80484

Reviewed by Julien Chaffraix.

No new tests / code cleanup only.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::convertToLength):

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyClip::convertToLength):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

14:52 Changeset [110483] by senorblanco@chromium.org
  • 11 edits in trunk/Source

[chromium] Restore canvas2D acceleration after context loss.
https://bugs.webkit.org/show_bug.cgi?id=80629

Reviewed by James Robinson.

Covered by existing canvas tests, and manual testing (killing the GPU
process).

Source/WebCore:

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::create):
(WebCore::Canvas2DLayerChromium::Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::setNeedsDisplayRect):
(WebCore::Canvas2DLayerChromium::drawsContent):
(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/Canvas2DLayerChromium.h:

(Canvas2DLayerChromium):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::applyFilters):

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp:

(SharedGraphicsContext3DImpl):
(WebCore::SharedGraphicsContext3DImpl::SharedGraphicsContext3DImpl):
(WebCore::SharedGraphicsContext3DImpl::get):
(WebCore):
(WebCore::SharedGraphicsContext3D::get):

  • platform/graphics/gpu/SharedGraphicsContext3D.h:

(SharedGraphicsContext3D):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::createAcceleratedCanvas):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::PlatformContextSkia):
(WebCore):

  • platform/graphics/skia/PlatformContextSkia.h:

(WebCore):
(WebCore::PlatformContextSkia::isAccelerated):
(WebCore::PlatformContextSkia::setAccelerated):
(PlatformContextSkia):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::sharedGraphicsContext3D):

14:51 Changeset [110482] by leviw@chromium.org
  • 7 edits in branches/subpixellayout/Source

Fixing misaligned painting in RenderListBox and RenderFileUploadControl. Correcting width calculations for platform code in RenderFileUploadControl. Changing RenderLayer::absoluteBoundingBox to a pixel snapped IntRect, which simplifies platform code.

14:36 Changeset [110481] by staikos@webkit.org
  • 2 edits in trunk/Source/WebCore

It doesn't make sense to return const unsigned, and GCC warns about it.
Remove const.
https://bugs.webkit.org/show_bug.cgi?id=80790

Reviewed by Antonio Gomes.

  • platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.h:

(WebCore::ComplexTextController::length):
(WebCore::ComplexTextController::numCodePoints):
(WebCore::ComplexTextController::offsetX):

14:33 Changeset [110480] by bdakin@apple.com
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=80888
Clear background for NSTextFieldCell is unreliable and not necessary
-and corresponding-
<rdar://problem/10663710>

Reviewed by Dan Bernstein.

With http://trac.webkit.org/changeset/104240 I thought it was necessary to
make NSTextFieldCells draw with a clear background in order to allow styled
text fields. That is not actually necessary; we just had a different bug
where isControlStyled() was only checking for styled borders on text fields.
Text fields can also be styled with backgrounds, so they need the full check.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::isControlStyled):
(WebCore::RenderThemeMac::textField):

14:28 Changeset [110479] by cevans@google.com
  • 1 edit in branches/chromium/1025/Source/WebCore/xml/XMLErrors.cpp

Merge 110111
BUG=117226
Review URL: https://chromiumcodereview.appspot.com/9689032

14:17 Changeset [110478] by commit-queue@webkit.org
  • 7 edits
    2 deletes in trunk

Cleanup obsolete files.
https://bugs.webkit.org/show_bug.cgi?id=80737

Patch by Scott Byer <scottbyer@chromium.org> on 2012-03-12
Reviewed by James Robinson.

.:

  • wscript:

Source/WebCore:

No new code.

  • GNUmakefile.list.am:
  • PlatformWinCE.cmake:
  • Target.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • platform/ScrollAnimatorWin.cpp: Removed.
  • platform/ScrollAnimatorWin.h: Removed.
14:15 Changeset [110477] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Make texImage2D error for wrong size ArrayBufferView more helpful
https://bugs.webkit.org/show_bug.cgi?id=80868

It took me about 30 minutes to figure out my texImage2D was failing
not because my ArrayBufferView was too small but because the default
alignment is 4. A better error message might help devs find this issue
faster.

Patch by Gregg Tavares <gman@google.com> on 2012-03-12
Reviewed by Kenneth Russell.

No new tests as no new functionality.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::validateTexFuncData):

14:08 Changeset [110476] by dglazkov@chromium.org
  • 5 edits
    1 add in trunk/LayoutTests

4 shadow DOM tests fail on Mac port
https://bugs.webkit.org/show_bug.cgi?id=80869

Reviewed by Ryosuke Niwa.

  • fast/dom/shadow/content-element-move.html: Changed to use ensureShadowRoot.
  • fast/dom/shadow/iframe-shadow.html: Changed to use WebKitShadowRoot polyfil.
  • fast/dom/shadow/resources/polyfill.js: Added.
  • fast/dom/shadow/shadow-on-image.html: Changed to use WebKitShadowRoot polyfil.
  • platform/wk2/Skipped: Added a test that should have been skipped when landed.
14:07 Changeset [110475] by alexis.menard@openbossa.org
  • 4 edits in trunk/LayoutTests

Update include path of the test scripts after r110470.

Reviewed by Philippe Normand.

  • fast/dom/HTMLSelectElement/select-selectedIndex-multiple.html:
  • fast/dom/HTMLSelectElement/select-selectedIndex.html:
  • fast/dom/HTMLSelectElement/select-selectedOptions.html:
14:04 Changeset [110474] by adamk@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Add test expectations accidentally left out of r110465.

  • fast/mutation/delivery-order-expected.txt: Added.
14:01 Changeset [110473] by cevans@google.com
  • 1 edit in branches/chromium/1025/Source/WebCore/dom/ContainerNode.cpp

Merge 110139
BUG=117226

13:47 Changeset [110472] by rniwa@webkit.org
  • 1 edit
    2 deletes in trunk/LayoutTests

Mac rebaseline. Offset is always 700px now.

  • platform/mac/fast/events/scrollbar-double-click-expected.txt: Removed.
  • platform/win/fast/events/scrollbar-double-click-expected.txt: Removed.
13:43 Changeset [110471] by eae@chromium.org
  • 5168 edits
    3892 copies
    731 deletes in branches/subpixellayout

Merge trunk changes up intil r110435 into subpixel branch.

13:33 Changeset [110470] by alexis.menard@openbossa.org
  • 1 edit
    8 adds
    8 deletes in trunk/LayoutTests

Move <select> related layout tests in the place they should be.

Reviewed by Andreas Kling.

  • fast/dom/HTMLSelectElement/select-selectedIndex-bug-12942-expected.txt: Added.
  • fast/dom/HTMLSelectElement/select-selectedIndex-bug-12942.html: Added.
  • fast/dom/HTMLSelectElement/select-selectedIndex-expected.txt: Added.
  • fast/dom/HTMLSelectElement/select-selectedIndex-multiple-expected.txt: Added.
  • fast/dom/HTMLSelectElement/select-selectedIndex-multiple.html: Added.
  • fast/dom/HTMLSelectElement/select-selectedIndex.html: Added.
  • fast/dom/HTMLSelectElement/select-selectedOptions-expected.txt: Added.
  • fast/dom/HTMLSelectElement/select-selectedOptions.html: Added.
  • fast/dom/select-selectedIndex-bug-12942-expected.txt: Removed.
  • fast/dom/select-selectedIndex-bug-12942.html: Removed.
  • fast/dom/select-selectedIndex-expected.txt: Removed.
  • fast/dom/select-selectedIndex-multiple-expected.txt: Removed.
  • fast/dom/select-selectedIndex-multiple.html: Removed.
  • fast/dom/select-selectedIndex.html: Removed.
  • fast/dom/select-selectedOptions-expected.txt: Removed.
  • fast/dom/select-selectedOptions.html: Removed.
13:26 Changeset [110469] by timothy_horton@apple.com
  • 8 edits in trunk/Source/WebCore

Infinite repaint loop with SVGImageCache and deferred repaint timers
https://bugs.webkit.org/show_bug.cgi?id=78315
<rdar://problem/10651634>

Reviewed by Nikolas Zimmermann.

Only defer image redraw on a timer if we're in layout. This breaks
the repaint loop while still preventing us from drawing inside layout.

Completely disable repaint during relayout inside SVGImage::drawSVGToImageBuffer,
preventing deferred repaint timers from being started during that process.

No new tests, as the problem only occurs in a nonstandard configuration.

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::endDeferredRepaints):
(WebCore::FrameView::startDeferredRepaintTimer):
(WebCore):
(WebCore::FrameView::doDeferredRepaints):
(WebCore::FrameView::deferredRepaintTimerFired):
(WebCore::FrameView::beginDisableRepaints):
(WebCore::FrameView::endDisableRepaints):

  • page/FrameView.h:

(FrameView):
(WebCore::FrameView::repaintsDisabled):

  • rendering/RenderView.cpp:

(WebCore::RenderView::shouldRepaint):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawSVGToImageBuffer):
(WebCore::SVGImage::draw):
(WebCore::SVGImage::frameView):
(WebCore):

  • svg/graphics/SVGImage.h:

(WebCore):

  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::imageContentChanged):
(WebCore::SVGImageCache::redraw):
(WebCore::SVGImageCache::redrawTimerFired):
(WebCore):

  • svg/graphics/SVGImageCache.h:

(SVGImageCache):

13:26 Changeset [110468] by dgrogan@chromium.org
  • 125 edits in trunk/LayoutTests

IndexedDB: layout test style update
https://bugs.webkit.org/show_bug.cgi?id=80555

Change layoutTestController.waitUntilDone to var jsTestIsAsync = true
and idb-specific done() to finishJSTest();

Following the uniform style results in less overall code and makes
them easier to convert to worker layout tests.

Reviewed by Tony Chang.

  • storage/indexeddb/constants.html:
  • storage/indexeddb/create-and-remove-object-store.html:
  • storage/indexeddb/create-object-store-options.html:
  • storage/indexeddb/createObjectStore-name-argument-required.html:
  • storage/indexeddb/createObjectStore-null-name.html:
  • storage/indexeddb/cursor-continue.html:
  • storage/indexeddb/cursor-delete.html:
  • storage/indexeddb/cursor-inconsistency.html:
  • storage/indexeddb/cursor-index-delete.html:
  • storage/indexeddb/cursor-key-order.html:
  • storage/indexeddb/cursor-primary-key-order.html:
  • storage/indexeddb/cursor-reverse-bug.html:
  • storage/indexeddb/cursor-skip-deleted.html:
  • storage/indexeddb/cursor-update-value-argument-required.html:
  • storage/indexeddb/cursor-update.html:
  • storage/indexeddb/data-corruption.html:
  • storage/indexeddb/database-basics.html:
  • storage/indexeddb/database-name-undefined.html:
  • storage/indexeddb/database-odd-names.html:
  • storage/indexeddb/database-quota.html:
  • storage/indexeddb/delete-closed-database-object.html:
  • storage/indexeddb/delete-range.html:
  • storage/indexeddb/deleteIndex.html:
  • storage/indexeddb/deleteObjectStore-name-argument-required.html:
  • storage/indexeddb/deleteObjectStore-null-name.html:
  • storage/indexeddb/duplicates.html:
  • storage/indexeddb/error-causes-abort-by-default.html:
  • storage/indexeddb/exception-in-event-aborts-expected.txt:
  • storage/indexeddb/exception-in-event-aborts.html:
  • storage/indexeddb/factory-basics.html:
  • storage/indexeddb/factory-cmp.html:
  • storage/indexeddb/factory-deletedatabase-interactions.html:
  • storage/indexeddb/factory-deletedatabase.html:
  • storage/indexeddb/index-count.html:
  • storage/indexeddb/index-cursor.html:
  • storage/indexeddb/index-get-key-argument-required.html:
  • storage/indexeddb/index-multientry.html:
  • storage/indexeddb/index-unique.html:
  • storage/indexeddb/invalid-keys.html:
  • storage/indexeddb/key-generator.html:
  • storage/indexeddb/key-sort-order-across-types.html:
  • storage/indexeddb/key-sort-order-date.html:
  • storage/indexeddb/key-type-array.html:
  • storage/indexeddb/key-type-infinity.html:
  • storage/indexeddb/keypath-basics.html:
  • storage/indexeddb/keypath-edges.html:
  • storage/indexeddb/keypath-fetch-key.html:
  • storage/indexeddb/keyrange-required-arguments.html:
  • storage/indexeddb/keyrange.html:
  • storage/indexeddb/list-ordering.html:
  • storage/indexeddb/mozilla/add-twice-failure.html:
  • storage/indexeddb/mozilla/autoincrement-indexes.html:
  • storage/indexeddb/mozilla/bad-keypath.html:
  • storage/indexeddb/mozilla/clear.html:
  • storage/indexeddb/mozilla/create-index-unique.html:
  • storage/indexeddb/mozilla/create-index-with-integer-keys.html:
  • storage/indexeddb/mozilla/create-objectstore-basics.html:
  • storage/indexeddb/mozilla/create-objectstore-null-name.html:
  • storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html:
  • storage/indexeddb/mozilla/cursor-mutation.html:
  • storage/indexeddb/mozilla/cursor-update-updates-indexes.html:
  • storage/indexeddb/mozilla/cursors.html:
  • storage/indexeddb/mozilla/delete-result.html:
  • storage/indexeddb/mozilla/event-source.html:
  • storage/indexeddb/mozilla/global-data.html:
  • storage/indexeddb/mozilla/indexes.html:
  • storage/indexeddb/mozilla/key-requirements-delete-null-key.html:
  • storage/indexeddb/mozilla/key-requirements-inline-and-passed.html:
  • storage/indexeddb/mozilla/key-requirements-put-no-key.html:
  • storage/indexeddb/mozilla/key-requirements-put-null-key.html:
  • storage/indexeddb/mozilla/key-requirements.html:
  • storage/indexeddb/mozilla/object-cursors.html:
  • storage/indexeddb/mozilla/object-identity.html:
  • storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put.html:
  • storage/indexeddb/mozilla/object-store-remove-values.html:
  • storage/indexeddb/mozilla/objectstorenames.html:
  • storage/indexeddb/mozilla/odd-result-order.html:
  • storage/indexeddb/mozilla/open-database-null-name.html:
  • storage/indexeddb/mozilla/put-get-values.html:
  • storage/indexeddb/mozilla/readonly-transactions.html:
  • storage/indexeddb/mozilla/readwrite-transactions.html:
  • storage/indexeddb/mozilla/readyState.html:
  • storage/indexeddb/mozilla/remove-index.html:
  • storage/indexeddb/mozilla/remove-objectstore.html:
  • storage/indexeddb/mozilla/versionchange-abort.html:
  • storage/indexeddb/mozilla/versionchange.html:
  • storage/indexeddb/mutating-cursor.html:
  • storage/indexeddb/objectStore-required-arguments.html:
  • storage/indexeddb/objectstore-autoincrement.html:
  • storage/indexeddb/objectstore-clear.html:
  • storage/indexeddb/objectstore-count.html:
  • storage/indexeddb/objectstore-cursor.html:
  • storage/indexeddb/objectstore-removeobjectstore.html:
  • storage/indexeddb/odd-strings.html:
  • storage/indexeddb/open-close-version.html:
  • storage/indexeddb/open-cursor.html:
  • storage/indexeddb/open-during-transaction.html:
  • storage/indexeddb/queued-commands.html:
  • storage/indexeddb/readonly-properties.html:
  • storage/indexeddb/readonly.html:
  • storage/indexeddb/request-event-propagation.html:
  • storage/indexeddb/resources/shared.js:

(unexpectedSuccessCallback):
(unexpectedErrorCallback):
(unexpectedAbortCallback):
(unexpectedCompleteCallback):
(unexpectedBlockedCallback):

  • storage/indexeddb/setVersion-null.html:
  • storage/indexeddb/setVersion-undefined.html:
  • storage/indexeddb/set_version_blocked.html:
  • storage/indexeddb/set_version_queue.html:
  • storage/indexeddb/structured-clone.html:
  • storage/indexeddb/transaction-abort-with-js-recursion-cross-frame.html:
  • storage/indexeddb/transaction-abort-with-js-recursion.html:
  • storage/indexeddb/transaction-abort.html:
  • storage/indexeddb/transaction-after-close.html:
  • storage/indexeddb/transaction-and-objectstore-calls.html:
  • storage/indexeddb/transaction-crash-on-abort.html:
  • storage/indexeddb/transaction-event-propagation.html:
  • storage/indexeddb/transaction-read-only.html:
  • storage/indexeddb/transaction-rollback.html:
  • storage/indexeddb/transaction-storeNames-required.html:
  • storage/indexeddb/two-version-changes.html:
  • storage/indexeddb/value-undefined.html:
  • storage/indexeddb/values-odd-types.html:
  • storage/indexeddb/version-change-abort-expected.txt:
  • storage/indexeddb/version-change-abort.html:
  • storage/indexeddb/version-change-exclusive.html:
  • storage/indexeddb/versionchangerequest-activedomobject.html:
13:25 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
13:24 Changeset [110467] by jamesr@google.com
  • 5 edits in branches/chromium/1025/Source

Merge 109263 - [chromium] Don't let invalidation for next frame prevent tile upload
https://bugs.webkit.org/show_bug.cgi?id=79841

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-29
Reviewed by James Robinson.

Source/WebCore:

We currently don't push dirty tiles to the impl thread so there are no
tiles with garbage data on the impl thread. However, this judgement is
overzealous and blocks tiles that get invalidated by WebKit for the
next frame during the paint of the current frame.

Instead, check if a tile is dirty and was not painted for the current
frame when deciding to push the tile to the impl thread. This requires
that we know if a tile was painted during the current frame, which we
can do if we always reset m_updateRect to be empty each frame.

New unit tests: TiledLayerChromiumTest.pushTilesMarkedDirtyDuringPaint

TiledLayerChromiumTest.pushTilesLayerMarkedDirtyDuringPaintOnNextLayer
TiledLayerChromiumTest.pushTilesLayerMarkedDirtyDuringPaintOnPreviousLayer

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::UpdatableTile::isDirtyForCurrentFrame):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::resetUpdateState):
(WebCore):
(WebCore::TiledLayerChromium::prepareToUpdate):

  • platform/graphics/chromium/TiledLayerChromium.h:

(TiledLayerChromium):

Source/WebKit/chromium:

  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9697001

13:21 Changeset [110466] by rniwa@webkit.org
  • 4 edits in trunk/LayoutTests

Mac rebaseline.

  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
13:11 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
13:11 Changeset [110465] by adamk@chromium.org
  • 4 edits
    5 adds in trunk

[MutationObservers] Enforce a consistent order of MutationRecord delivery
https://bugs.webkit.org/show_bug.cgi?id=80549

Reviewed by Ojan Vafai.

Source/WebCore:

Mutations should be delivered in order of creation.

Tests: fast/mutation/create-during-delivery.html

fast/mutation/delivery-order.html
fast/mutation/mutate-during-delivery.html

  • dom/WebKitMutationObserver.cpp:

(WebCore):
(WebCore::WebKitMutationObserver::ObserverLessThan::operator()): Functor for use with std::sort.
(WebCore::WebKitMutationObserver::create):
(WebCore::WebKitMutationObserver::WebKitMutationObserver):
(WebCore::WebKitMutationObserver::deliverAllMutations): Move observers into a sorted vector before delivery.

  • dom/WebKitMutationObserver.h: Add a "priority" member which monotonically increases with each construction.

LayoutTests:

  • fast/mutation/create-during-delivery-expected.txt: Added.
  • fast/mutation/create-during-delivery.html: Added.
  • fast/mutation/delivery-order.html: Added.
  • fast/mutation/mutate-during-delivery-expected.txt: Added.
  • fast/mutation/mutate-during-delivery.html: Added.
13:08 Changeset [110464] by nduca@chromium.org
  • 13 edits in trunk/Source

[Chromium] Force compositeAndReadback through regular scheduling flow
https://bugs.webkit.org/show_bug.cgi?id=77049

Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/cc/CCFrameRateController.cpp:

(WebCore::CCFrameRateController::onTimerTick):

  • platform/graphics/chromium/cc/CCFrameRateController.h:

(CCFrameRateControllerClient):

  • platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::setNeedsForcedCommit):
(WebCore):
(WebCore::CCScheduler::vsyncTick):

  • platform/graphics/chromium/cc/CCScheduler.h:

(CCScheduler):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::nextAction):
(WebCore::CCSchedulerStateMachine::updateState):
(WebCore::CCSchedulerStateMachine::setNeedsForcedCommit):
(WebCore):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.h:

(CCSchedulerStateMachine):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::requestReadbackOnImplThread):
(WebCore::CCThreadProxy::forceBeginFrameOnImplThread):
(WebCore::CCThreadProxy::scheduledActionBeginFrame):
(WebCore::CCThreadProxy::beginFrame):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):
(WebCore::CCThreadProxy::BeginFrameAndCommitState::BeginFrameAndCommitState):
(BeginFrameAndCommitState):

Source/WebKit/chromium:

  • tests/CCFrameRateControllerTest.cpp:

(WebKitTests::FakeCCFrameRateControllerClient::reset):
(WebKitTests::FakeCCFrameRateControllerClient::vsyncTicked):
(WebKitTests::FakeCCFrameRateControllerClient::vsyncTick):
(FakeCCFrameRateControllerClient):
(WebKitTests::TEST):

  • tests/CCLayerTreeHostTest.cpp:

(WTF):
(CCLayerTreeHostTestCompositeAndReadbackWhileInvisible):
(WTF::CCLayerTreeHostTestCompositeAndReadbackWhileInvisible::CCLayerTreeHostTestCompositeAndReadbackWhileInvisible):
(WTF::CCLayerTreeHostTestCompositeAndReadbackWhileInvisible::beginTest):
(WTF::CCLayerTreeHostTestCompositeAndReadbackWhileInvisible::didCommitAndDrawFrame):
(WTF::CCLayerTreeHostTestCompositeAndReadbackWhileInvisible::afterTest):
(WTF::TEST_F):

  • tests/CCSchedulerStateMachineTest.cpp:

(WebCore::StateMachine::setNeedsForcedCommit):
(WebCore::StateMachine::needsForcedCommit):
(StateMachine):
(WebCore::TEST):
(WebCore):

12:57 Changeset [110463] by jsbell@chromium.org
  • 7 edits
    1 add in trunk/Source

IndexedDB: Handle LevelDB database corruption
https://bugs.webkit.org/show_bug.cgi?id=79413

Source/WebCore:

Add LevelDBDatabase::destroy() method so that clients can retry if open() fails.

Reviewed by Tony Chang.

Test: webkit_unit_tests --gtest_filter='LevelDBDatabaseTest.CorruptionTest'

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp: Implement open/destroy/open strategy.

(WebCore::IDBLevelDBBackingStore::open):

  • platform/leveldb/LevelDBDatabase.cpp:

(WebCore::LevelDBDatabase::destroy):
(WebCore):

  • platform/leveldb/LevelDBDatabase.h:

(LevelDBDatabase):

Source/WebKit/chromium:

Reviewed by Tony Chang.

  • WebKit.gyp: Skip LevelDBTest.cpp in shared component builds due to webkit_support dependency
  • WebKit.gypi: Add LevelDBTest.cpp
  • tests/LevelDBTest.cpp: Added.

(WebCore):
(SimpleComparator):
(WebCore::SimpleComparator::compare):
(WebCore::SimpleComparator::name):
(WebCore::encodeString):
(WebCore::TEST):

12:55 Changeset [110462] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1025

Merge 110332
BUG=114056
Review URL: https://chromiumcodereview.appspot.com/9689022

12:52 Changeset [110461] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1025

Merge 110324
BUG=116746
Review URL: https://chromiumcodereview.appspot.com/9693006

12:50 Changeset [110460] by peter@chromium.org
  • 2 edits in trunk/Tools

[Chromium] Temporary build-fix for the Android bot
https://bugs.webkit.org/show_bug.cgi?id=80862

Reviewed by Adam Barth.

Manually set the environmental variables required to compile source
files through the Android NDK instead of relying on the envsetup.sh
script. A proper fix will be landed to Chromium ASAP, and following
a Chromium roll into WebKit this code will be removed.

  • Scripts/webkitdirs.pm:

(buildChromiumMakefile):

12:47 Changeset [110459] by cevans@google.com
  • 8 edits
    2 copies in branches/chromium/1025

Merge 110323
BUG=113902
Review URL: https://chromiumcodereview.appspot.com/9695005

12:44 Changeset [110458] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Use right construct to detect config_test_gccdepends

Reviewed by Andreas Kling.

12:44 Changeset [110457] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Expose location of WebKit's bin and imports dir through module file

Reviewed by Andreas Kling.

12:24 Changeset [110456] by shawnsingh@chromium.org
  • 4 edits in trunk

Fix regression on fast/table/table-row-compositing-repaint-crash.html
https://bugs.webkit.org/show_bug.cgi?id=80804

Reviewed by Simon Fraser.

Covered by existing tests.

http://trac.webkit.org/changeset/110401/ accidentally caused
fast/table/table-row-compositing-repaint-crash.html to fail.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateBacking):

12:20 Changeset [110455] by mikelawther@chromium.org
  • 5 edits in trunk

CSS3 calc: enable mixed percent/absolute for font
https://bugs.webkit.org/show_bug.cgi?id=80813

Reviewed by Ojan Vafai.

Source/WebCore:

Add support for mixed percent/absolute expressions to the font handling class.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyFontSize::applyValue):

LayoutTests:

  • css3/calc/font-expected.txt:
  • css3/calc/font-size-expected.txt:
12:19 Changeset [110454] by cevans@google.com
  • 1 edit
    3 copies in branches/chromium/1025

Merge 110326
BUG=116461
Review URL: https://chromiumcodereview.appspot.com/9677005

12:18 Changeset [110453] by laszlo.1.gombos@nokia.com
  • 5 edits in trunk/Source/JavaScriptCore

Minor DataLog fixes
https://bugs.webkit.org/show_bug.cgi?id=80826

Reviewed by Andreas Kling.

  • bytecode/ExecutionCounter.cpp:

Do not include DataLog.h, it is not used.

  • jit/ExecutableAllocator.cpp:

Ditto.

  • wtf/DataLog.cpp:

(WTF::initializeLogFileOnce):
Add missing semi-colon to the code path where DATA_LOG_FILENAME is defined.

  • wtf/HashTable.cpp:

Include DataLog as it is used.

12:00 Changeset [110452] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1025

Merge 108084
BUG=112411
Review URL: https://chromiumcodereview.appspot.com/9694004

11:58 Changeset [110451] by reed@google.com
  • 2 edits in trunk/LayoutTests

update expectations in preparation for bitmap-sampling fix in skia
https://bugs.webkit.org/show_bug.cgi?id=80837

Unreviewed

  • platform/chromium/test_expectations.txt:
11:51 Changeset [110450] by kling@webkit.org
  • 4 edits in trunk/Source/WebCore

Restore Attr::style() functionality.
<http://webkit.org/b/80678>
<rdar://problem/10933904>

Reviewed by Antti Koivisto.

The neutering of Attr::style() in r106740 broke some internal clients of the Obj-C API,
so this was definitely premature.

Since we no longer have a per-Attribute style object, synthesize one in style() and
hang it off of the Attr. This grows Attr by one pointer, but it's a low-volume object
so it shouldn't matter much.

We recreate the StylePropertySet object on every call to style(), to avoid complicating
things with custom invalidation code.

  • dom/Attr.cpp:

(WebCore::Attr::style):

  • dom/Attr.h:
  • dom/StyledElement.h:

(WebCore::StyledElement::collectStyleForAttribute):

11:38 Changeset [110449] by rniwa@webkit.org
  • 8 edits
    2 adds in trunk

REGRESSION(r109285): Crash in WebCore::Document::nodeChildrenWillBeRemoved
https://bugs.webkit.org/show_bug.cgi?id=80578

Reviewed by Andreas Kling.

Source/WebCore:

Test: svg/css/style-change-crash.html

  • dom/Element.cpp:

(WebCore::Element::setAttribute):
(WebCore::Element::setAttributeInternal):

  • dom/Element.h:

(Element):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::addAttribute):
(WebCore::ElementAttributeData::removeAttribute):

  • dom/ElementAttributeData.h:

(ElementAttributeData):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::updateStyleAttribute):

LayoutTests:

  • fast/regions/select-in-region-crash-expected.txt: Rebaselined.
  • svg/css/style-change-crash-expected.txt: Added.
  • svg/css/style-change-crash.html: Added.
11:28 Changeset [110448] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

Touch event handler count is not updated when adding handlers to the window.
https://bugs.webkit.org/show_bug.cgi?id=80756

Source/WebCore:

Touch event handlers added to the window needs to be included when counting the number of touch event
handlers. This makes touch event handler counting identical to wheel event handler counting.

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-03-12
Reviewed by Anders Carlsson.

Test: fast/events/touch/touch-handler-count.html

  • dom/EventNames.h:

(EventNames):
(WebCore::EventNames::isTouchEventType):

  • dom/Node.cpp:

(WebCore):
(WebCore::tryAddEventListener):
(WebCore::tryRemoveEventListener):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):

  • testing/Internals.cpp:

(WebCore::Internals::touchEventHandlerCount):
(WebCore):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

LayoutTests:

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-03-12
Reviewed by Anders Carlsson.

The new layout tests add and remove touch event handlers on the window, document, and a div in the
document, and tests that the count is updated correctly when handlers are added and/or removed.

  • fast/events/touch/touch-handler-count-expected.txt: Added.
  • fast/events/touch/touch-handler-count.html: Added.
11:02 Changeset [110447] by abecsi@webkit.org
  • 6 edits
    1 add in trunk

[Qt][WK2] Add support for rudimentary scroll indicators in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=80832

Reviewed by Tor Arne Vestbø.

Source/WebKit2:

Since the ScrollDecorator QML component requires a Flickable in its API
we need to expose the Flickable in QML for now and we also need to add
a notifier because we instantiate the internal Flickable only when the
WebView component completes construction.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebViewExperimental::flickable):

  • UIProcess/API/qt/qquickwebview_p.h:

Tools:

Add a basic scroll indicator component to MiniBrowser so that it
behaves similar to the ScrollDecorator QML component.

  • MiniBrowser/qt/MiniBrowser.qrc:
  • MiniBrowser/qt/qml/BrowserWindow.qml:
  • MiniBrowser/qt/qml/ScrollIndicator.qml: Added.
10:50 Changeset [110446] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] r110296 included an extra $ in @$(AM_V_GEN)
https://bugs.webkit.org/show_bug.cgi?id=80809

Patch by C Anthony Risinger <anthony@xtfx.me> on 2012-03-12
Reviewed by Philippe Normand.

  • GNUmakefile.am: Add $ to @(AM_V_GEN), else /bin/sh syntax error
10:43 Changeset [110445] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: extract ResourceScriptMapping from MainScriptMapping.
https://bugs.webkit.org/show_bug.cgi?id=80834

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/ScriptMapping.js:

(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeListChanged):
(WebInspector.ResourceScriptMapping.prototype.reset):
(WebInspector.MainScriptMapping):
(WebInspector.MainScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.MainScriptMapping.prototype.createLiveLocation):
(WebInspector.MainScriptMapping.prototype._registerLiveLocation):
(WebInspector.MainScriptMapping.prototype._unregisterLiveLocation):
(WebInspector.MainScriptMapping.prototype._updateLiveLocations):
(WebInspector.MainScriptMapping.prototype.uiSourceCodeList):
(WebInspector.MainScriptMapping.prototype.addScript):
(WebInspector.MainScriptMapping.prototype._handleUISourceCodeListChanged):
(WebInspector.MainScriptMapping.prototype.setFormatSource):
(WebInspector.MainScriptMapping.prototype.forceUpdateSourceMapping):
(WebInspector.MainScriptMapping.prototype.reset):

10:42 Changeset [110444] by ericu@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] fast/filesystem/op-restricted-chars.html fails on Windows
https://bugs.webkit.org/show_bug.cgi?id=75110

Reviewed by Ryosuke Niwa.

Remove expectation now that it's fixed.

  • platform/chromium/test_expectations.txt:
10:31 Changeset [110443] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Integer overflow check code in arithmetic operation in classic interpreter
https://bugs.webkit.org/show_bug.cgi?id=80465

Patch by SangGyu Lee <sg5.lee@samsung.com> on 2012-03-12
Reviewed by Gavin Barraclough.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

10:17 Changeset [110442] by philn@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed, unskip a media test in GTK.

  • platform/gtk/Skipped: media/video-volume-slider.html was fixed

in r86535.

  • platform/gtk/media/video-volume-slider-expected.txt:
10:14 Changeset [110441] by pfeldman@chromium.org
  • 4 edits
    2 adds in trunk

Web Inspector: recognize Float*Array and Int*Array as arrays.
https://bugs.webkit.org/show_bug.cgi?id=80850

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: inspector/console/console-external-array.html

  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::type):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::typeCallback):

LayoutTests:

  • inspector/console/console-external-array-expected.txt: Added.
  • inspector/console/console-external-array.html: Added.
10:13 Changeset [110440] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add tests for dynamic attribute changes for mapping of lang/xml:lang to -webkit-locale
https://bugs.webkit.org/show_bug.cgi?id=80658

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-03-12
Reviewed by Alexey Proskuryakov.

  • fast/text/lang-mapped-to-webkit-locale-dynamic-expected.txt: Added.
  • fast/text/lang-mapped-to-webkit-locale-dynamic.xhtml: Added.
10:09 Changeset [110439] by jocelyn.turcotte@nokia.com
  • 4 edits in trunk/Source/WebCore

[TexMapGL] Pixel-align the transform of textures that fit pixel-for-pixel on the frame buffer.
https://bugs.webkit.org/show_bug.cgi?id=80848

Reviewed by Noam Rosenthal.

When rendering a transformed texture on the screen with a fractional
coordinate with linear filtering, the resulting pixel will be blended from
the texels around this fractional position according to their cover ratio.
This produces a slight blur of pixels which give no benefit when rendering
a texture that isn't scaled.

This patch offsets the transform by rounding the translation part of the
layer's transform to align the result to integer coordinates.
Applying the adjustment on the layer transform makes sure that all the tiles
get the same adjustment.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::drawTexture):

  • platform/graphics/texmap/TextureMapperGL.h:

(WebCore::BitmapTextureGL::textureSize):

10:08 Changeset [110438] by jocelyn.turcotte@nokia.com
  • 6 edits in trunk/Source/WebCore

[TexMapGL] Use textures sized exactly to their contents.
https://bugs.webkit.org/show_bug.cgi?id=80845

Reviewed by Noam Rosenthal.

This fixes a regression introduced in r108273 as well as the bug it fixed.
The regressing behavior was that textures were rendered shrunk by 1 pixel
and thus would appear blurry on the screen.
The original problem was that garbage contents would appear on filtered
textures since we would reuse textures of different sizes by giving them
a slightly bigger size.

This patch will reuse the texture only if the size matches exactly to allow
edge clamping to work properly when redering with linear filtering.
Reusing textures would only saves us the allocation of graphic memory
anyway, which is negligeable compared to texture upload.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::drawTexture):
(WebCore::BitmapTextureGL::didReset):

  • platform/graphics/texmap/TextureMapperGL.h:

(BitmapTextureGL):

  • platform/graphics/texmap/TextureMapperShaderManager.cpp:

(WebCore::TextureMapperShaderProgramOpacityAndMask::TextureMapperShaderProgramOpacityAndMask):
(WebCore::TextureMapperShaderProgramOpacityAndMask::prepare):

  • platform/graphics/texmap/TextureMapperShaderManager.h:

(TextureMapperShaderProgramOpacityAndMask):

10:06 Changeset [110437] by jocelyn.turcotte@nokia.com
  • 5 edits in trunk/Source/WebCore

[TexMap] Remove BitmapTexture::destroy.
https://bugs.webkit.org/show_bug.cgi?id=80844

Reviewed by Noam Rosenthal.

Use the destructor directly instead.

  • platform/graphics/texmap/TextureMapper.h:
  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::~BitmapTextureGL):

  • platform/graphics/texmap/TextureMapperGL.h:

(BitmapTextureGL):

  • platform/graphics/texmap/TextureMapperImageBuffer.h:

(WebCore::BitmapTextureImageBuffer::~BitmapTextureImageBuffer):

09:50 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
09:39 Changeset [110436] by vestbo@webkit.org
  • 2 edits in trunk

[Qt] Make sure we set the right library version for Qt 4

r110272 accedentally pruned the variable that ensures this.

Reviewed by Simon Hausmann.

09:06 Changeset [110435] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, slight Skipped list reorganization and unskip a bunch
of inspector tests on GTK.

  • platform/gtk/Skipped:
08:56 Changeset [110434] by podivilov@chromium.org
  • 16 edits in trunk

Web Inspector: DebuggerModel.Location should have scriptId property.
https://bugs.webkit.org/show_bug.cgi?id=80830

Reviewed by Vsevolod Vlasov.

Source/WebCore:

  • inspector/front-end/CompilerSourceMapping.js:

(WebInspector.ClosureCompilerSourceMapping.prototype.sourceLocationToCompiledLocation):

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype.location):

  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.Location):
(WebInspector.DebuggerModel.prototype._failedToParseScriptSource):
(WebInspector.DebuggerModel.prototype.createRawLocation):
(WebInspector.DebuggerModel.prototype.createRawLocationByURL):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessageToScript):
(WebInspector.DebuggerPresentationModel.prototype._addPendingConsoleMessagesToScript):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype._uiSourceCodeForResource):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode.PlainSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.CompilerSourceMapping.prototype.uiLocationToRawLocation):

  • inspector/front-end/ScriptFormatter.js:

(WebInspector.ScriptFormatter.locationToPosition):
(WebInspector.ScriptFormatter.positionToLocation):
(WebInspector.FormattedSourceMapping.prototype.originalToFormatted):
(WebInspector.FormattedSourceMapping.prototype.formattedToOriginal):

LayoutTests:

  • http/tests/inspector/compiler-source-mapping.html:
  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • http/tests/inspector/search/search-in-concatenated-script.html:
  • http/tests/inspector/search/search-in-script.html:
  • inspector/debugger/debugger-scripts.html:
  • inspector/debugger/linkifier.html:
  • inspector/debugger/raw-source-code.html:
  • inspector/debugger/script-formatter.html:
08:50 Changeset [110433] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Clean up culling tests and templatize to test impl constructs
https://bugs.webkit.org/show_bug.cgi?id=80613

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-12
Reviewed by Adrienne Walker.

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore::TestContentLayerChromium::TestContentLayerChromium):
(WebCore::TestContentLayerChromium::opaqueContentsRegion):
(WebCore::TestContentLayerChromium::setOpaqueContentsRect):
(TestContentLayerChromium):
(TestContentLayerImpl):
(WebCore::TestContentLayerImpl::TestContentLayerImpl):
(WebCore::TestContentLayerImpl::opaqueContentsRegion):
(WebCore::TestContentLayerImpl::setOpaqueContentsRect):
(WebCore):
(WebCore::TestCCOcclusionTrackerBase::TestCCOcclusionTrackerBase):
(WebCore::TestCCOcclusionTrackerBase::occlusionInScreenSpace):
(WebCore::TestCCOcclusionTrackerBase::occlusionInTargetSurface):
(WebCore::TestCCOcclusionTrackerBase::setOcclusionInScreenSpace):
(WebCore::TestCCOcclusionTrackerBase::setOcclusionInTargetSurface):
(WebCore::TestCCOcclusionTrackerBase::layerScissorRectInTargetSurface):
(WebCore::TestDamageClient::damageRect):
(CCOcclusionTrackerTestMainThreadTypes):
(WebCore::CCOcclusionTrackerTestMainThreadTypes::createLayer):
(WebCore::CCOcclusionTrackerTestMainThreadTypes::createContentLayer):
(CCOcclusionTrackerTestImplThreadTypes):
(WebCore::CCOcclusionTrackerTestImplThreadTypes::createLayer):
(WebCore::CCOcclusionTrackerTestImplThreadTypes::createContentLayer):
(CCOcclusionTrackerTest):
(WebCore::CCOcclusionTrackerTest::TearDown):
(WebCore::CCOcclusionTrackerTest::createRoot):
(WebCore::CCOcclusionTrackerTest::createLayer):
(WebCore::CCOcclusionTrackerTest::createSurface):
(WebCore::CCOcclusionTrackerTest::createDrawingLayer):
(WebCore::CCOcclusionTrackerTest::createDrawingSurface):
(WebCore::CCOcclusionTrackerTest::calcDrawEtc):
(WebCore::CCOcclusionTrackerTest::setBaseProperties):
(WebCore::CCOcclusionTrackerTest::setProperties):
(CCOcclusionTrackerTestIdentityTransforms):
(WebCore::CCOcclusionTrackerTestIdentityTransforms::runMyTest):
(CCOcclusionTrackerTestRotatedChild):
(WebCore::CCOcclusionTrackerTestRotatedChild::runMyTest):
(CCOcclusionTrackerTestTranslatedChild):
(WebCore::CCOcclusionTrackerTestTranslatedChild::runMyTest):
(CCOcclusionTrackerTestChildInRotatedChild):
(WebCore::CCOcclusionTrackerTestChildInRotatedChild::runMyTest):
(CCOcclusionTrackerTestVisitTargetTwoTimes):
(WebCore::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest):
(CCOcclusionTrackerTestSurfaceRotatedOffAxis):
(WebCore::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest):
(CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren):
(WebCore::CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren::runMyTest):
(CCOcclusionTrackerTestOverlappingSurfaceSiblings):
(WebCore::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
(CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms):
(WebCore::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
(CCOcclusionTrackerTestFilters):
(WebCore::CCOcclusionTrackerTestFilters::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectOutsideChild):
(WebCore::CCOcclusionTrackerTestLayerScissorRectOutsideChild::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectOutsideChild):
(WebCore::CCOcclusionTrackerTestScreenScissorRectOutsideChild::runMyTest):
(CCOcclusionTrackerTestDamageRectOutsideChild):
(WebCore::CCOcclusionTrackerTestDamageRectOutsideChild::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectOverChild):
(WebCore::CCOcclusionTrackerTestLayerScissorRectOverChild::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectOverChild):
(WebCore::CCOcclusionTrackerTestScreenScissorRectOverChild::runMyTest):
(CCOcclusionTrackerTestDamageRectOverChild):
(WebCore::CCOcclusionTrackerTestDamageRectOverChild::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectPartlyOverChild):
(WebCore::CCOcclusionTrackerTestLayerScissorRectPartlyOverChild::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectPartlyOverChild):
(WebCore::CCOcclusionTrackerTestScreenScissorRectPartlyOverChild::runMyTest):
(CCOcclusionTrackerTestDamageRectPartlyOverChild):
(WebCore::CCOcclusionTrackerTestDamageRectPartlyOverChild::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectOverNothing):
(WebCore::CCOcclusionTrackerTestLayerScissorRectOverNothing::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectOverNothing):
(WebCore::CCOcclusionTrackerTestScreenScissorRectOverNothing::runMyTest):
(CCOcclusionTrackerTestDamageRectOverNothing):
(WebCore::CCOcclusionTrackerTestDamageRectOverNothing::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectForLayerOffOrigin):
(WebCore::CCOcclusionTrackerTestLayerScissorRectForLayerOffOrigin::runMyTest):
(CCOcclusionTrackerTestOpaqueContentsRegionEmpty):
(WebCore::CCOcclusionTrackerTestOpaqueContentsRegionEmpty::runMyTest):
(CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty):
(WebCore::CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty::runMyTest):

08:47 Changeset [110432] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] A couple early-outs for occlusion tracker
https://bugs.webkit.org/show_bug.cgi?id=80742

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-12
Reviewed by Adrienne Walker.

Covered by existing tests.

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::occluded):
(WebCore::::unoccludedContentRect):

08:45 Changeset [110431] by zeno.albisser@nokia.com
  • 2 edits in trunk/Source/WebCore

[Qt][Mac] Build fails after adding WebCoreCFAutorelease(CFTypeRef) (r110360).
https://bugs.webkit.org/show_bug.cgi?id=80840

CoreFoundation/CFBase.h needs to be included to define the type CFTypeRef.

Reviewed by Tor Arne Vestbø.

  • platform/mac/WebCoreObjCExtras.h:
08:34 Changeset [110430] by zeno.albisser@nokia.com
  • 2 edits in trunk/Source/JavaScriptCore

[Qt][Mac] Build fails after enabling LLINT when JIT is disabled (r109863)
https://bugs.webkit.org/show_bug.cgi?id=80827

Qt on Mac uses OS(DARWIN) as well, but we do not want to enable LLINT.

Reviewed by Simon Hausmann.

  • wtf/Platform.h:
08:32 Changeset [110429] by staikos@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unused global static variable for BlackBerry.
https://bugs.webkit.org/show_bug.cgi?id=80790

Reviewed by Alexey Proskuryakov.

  • platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore):

08:28 Changeset [110428] by staikos@webkit.org
  • 3 edits in trunk/Source/WebCore

Correct usage of NDEBUG to fix warnings on BlackBerry.
https://bugs.webkit.org/show_bug.cgi?id=80790

Reviewed by Alexey Proskuryakov.

  • platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:

(WebCore::CookieDatabaseBackingStore::sendChangesToDatabase):

  • platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::initiateCookieLimitCleanUp):

07:52 Changeset [110427] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[BlackBerry] build-webkit doesn't recognize "--cmakearg" for the BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=80812

Patch by Ming Xie <mxie@rim.com> on 2012-03-12
Reviewed by Rob Buis.

  • Scripts/build-webkit: Add $cmakeArgs to buildCMakeProjectOrExit()
  • Scripts/webkitdirs.pm:

(blackberryCMakeArguments): Remove "PUBLIC_BUILD=0" define

07:43 Changeset [110426] by hausmann@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed prospective Qt/Mac build fix

  • runtime/JSGlobalData.cpp: use #USE(CF) instead of PLATFORM(MAC) to determine

whether to include CoreFoundation headers, used for JIT configuration in JSGlobalData
constructor.

07:36 Changeset [110425] by timothy@apple.com
  • 15 edits in trunk/Source/WebKit2

Update how the Web Inspector resources are loaded.

https://bugs.webkit.org/show_bug.cgi?id=80814
rdar://problem/10359959

Reviewed by John Sullivan.

  • Shared/WebPreferencesStore.h:

(WebKit): Added InspectorUsesWebKitUserInterface.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode): Removed webInspectorLocalizedStringsPath.
(WebKit::WebProcessCreationParameters::decode): Ditto.

  • Shared/WebProcessCreationParameters.h: Ditto.

(WebProcessCreationParameters): Ditto.

  • UIProcess/API/C/WKContext.cpp:
  • UIProcess/API/C/WKContextPrivate.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetInspectorUsesWebKitUserInterface): Added.
(WKPreferencesGetInspectorUsesWebKitUserInterface): Added.

  • UIProcess/API/C/WKPreferencesPrivate.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureWebProcess): Removed webInspectorLocalizedStringsPath.

  • UIProcess/WebContext.h:

(WebContext): Ditto.

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::inspectorReallyUsesWebKitUserInterface): Added.
(WebKit::WebInspectorProxy::createInspectorWindow): Use inspectorReallyUsesWebKitUserInterface
to determine if texture should be used.
(WebKit::WebInspectorProxy::inspectorPageURL): Choose the right path.
(WebKit::WebInspectorProxy::inspectorBaseURL): Ditto.

  • WebProcess/WebPage/WebInspector.h:
  • WebProcess/WebPage/mac/WebInspectorMac.mm:

(WebKit::inspectorReallyUsesWebKitUserInterface):
(WebKit::WebInspector::setInspectorUsesWebKitUserInterface): Added.
(WebKit::WebInspector::localizedStringsURL):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformPreferencesDidChange): Call WebInspector::setInspectorUsesWebKitUserInterface.

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::platformInitializeWebProcess): Removed call to WebInspector::setLocalizedStringsPath.

07:33 Changeset [110424] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] REGRESSION(r110401): fast/table/table-row-compositing-repaint-crash.html asserts
https://bugs.webkit.org/show_bug.cgi?id=80833

Unreviewed gardening.

  • platform/qt/Skipped: Skip fast/table/table-row-compositing-repaint-crash.html to paint the bot green.
07:24 WebKit Team edited by yi.4.shen@nokia.com
(diff)
06:59 Changeset [110423] by loislo@chromium.org
  • 6 edits in trunk

Re-apply the patch after v8 roll to r11000.

Web Inspector: move heap snapshot nodes data to external array.
https://bugs.webkit.org/show_bug.cgi?id=79911

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Tests:
heap-shapshot.html
heap-shapshot-loader.html

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.Int32Array):
(WebInspector.Int32Array.prototype.get array):
(WebInspector.HeapSnapshotLoader.prototype._parseNodes):
(WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
(WebInspector.HeapSnapshot):
(WebInspector.HeapSnapshot.prototype._init):

LayoutTests:

  • inspector/profiler/heap-snapshot-loader.html:
  • inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockRaw):
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMock):
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockWithDOM):

05:57 Changeset [110422] by hausmann@webkit.org
  • 5 edits in trunk

[Qt] Fix build with newer Qt 5.

Reviewed by Tor Arne Vestbø.

Source/WebCore:

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::fileListNameForWidth): Use DefaultCodec instead of the
deprecated CodecForTR.

Tools:

Newer Qt 5 renames QDeclarativeFoo to QQmlFoo and provides backwards compatible
renames, which however do trigger a #warning. Until we _require_ a newer Qt 5
we should disable -Werror.

Also load(moc) for the availability of QMAKE_MOC in various derived sources. The
implicit load was removed recently.

  • qmake/mkspecs/features/default_pre.prf:
  • qmake/mkspecs/features/unix/default_post.prf:
05:31 Changeset [110421] by loislo@chromium.org
  • 3 edits in trunk/PerformanceTests

Web Inspector: chromium: increase heap snapshot performance coverage.
https://bugs.webkit.org/show_bug.cgi?id=80829

Reviewed by Yury Semikhatsky.

  • inspector/detailed-heapshots-smoke-test.html:
  • inspector/performance-test.js:

(initialize_TimeTracker.InspectorTest.measureFunction):

04:27 Changeset [110420] by hans@chromium.org
  • 14 edits
    1 copy
    4 adds in trunk

Speech JavaScript API: SpeechRecognitionEvent
https://bugs.webkit.org/show_bug.cgi?id=80513

Reviewed by Adam Barth.

Source/WebCore:

Implement SpeechRecognitionEvent.
(Spec: http://speech-javascript-api-spec.googlecode.com/git/speechapi.html)

Test: fast/events/constructors/speech-recognition-event-constructor.html

  • Modules/speech/DOMWindowSpeech.idl:
  • Modules/speech/SpeechRecognitionEvent.cpp: Added.

(WebCore):
(WebCore::SpeechRecognitionEventInit::SpeechRecognitionEventInit):
(WebCore::SpeechRecognitionEvent::create):
(WebCore::SpeechRecognitionEvent::createResult):
(WebCore::SpeechRecognitionEvent::createNoMatch):
(WebCore::SpeechRecognitionEvent::createResultDeleted):
(WebCore::SpeechRecognitionEvent::createError):
(WebCore::SpeechRecognitionEvent::interfaceName):
(WebCore::SpeechRecognitionEvent::SpeechRecognitionEvent):

  • Modules/speech/SpeechRecognitionEvent.h: Added.

(WebCore):
(SpeechRecognitionEventInit):
(SpeechRecognitionEvent):
(WebCore::SpeechRecognitionEvent::result):
(WebCore::SpeechRecognitionEvent::error):
(WebCore::SpeechRecognitionEvent::resultIndex):
(WebCore::SpeechRecognitionEvent::resultHistory):

  • Modules/speech/SpeechRecognitionEvent.idl:
  • WebCore.gypi:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitSpeechRecognitionEventEnabled):

  • bindings/v8/OptionsObject.cpp:

(WebCore::OptionsObject::get):
(WebCore):

  • bindings/v8/OptionsObject.h:

(WebCore):
(OptionsObject):

  • dom/EventNames.h:

(WebCore):

  • dom/EventNames.in:

LayoutTests:

Add test for SpeechRecognitionEvent.
Update Skipped files for all ports except Chromium.

  • fast/events/constructors/speech-recognition-event-constructor-expected.txt: Added.
  • fast/events/constructors/speech-recognition-event-constructor.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
02:50 Changeset [110419] by fpizlo@apple.com
  • 17 edits
    1 add in trunk/Source/JavaScriptCore

All DFG nodes should have a mutable set of flags
https://bugs.webkit.org/show_bug.cgi?id=80779
<rdar://problem/11026218>

Reviewed by Gavin Barraclough.

Got rid of NodeId, and placed all of the flags that distinguished NodeId
from NodeType into a separate Node::flags field. Combined what was previously
ArithNodeFlags into Node::flags.

In the process of debugging, I found that the debug support in the virtual
register allocator was lacking, so I improved it. I also realized that the
virtual register allocator was assuming that the nodes in a basic block were
contiguous, which is no longer the case. So I fixed that. The fix also made
it natural to have more extreme assertions, so I added them. I suspect this
will make it easier to catch virtual register allocation bugs in the future.

This is mostly performance neutral; if anything it looks like a slight
speed-up.

This patch does leave some work for future refactorings; for example, Node::op
is unencapsulated. This was already the case, though now it feels even more
like it should be. I avoided doing that because this patch has already grown
way bigger than I wanted.

Finally, this patch creates a DFGNode.cpp file and makes a slight effort to
move some unnecessarily inline stuff out of DFGNode.h.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • dfg/DFGArithNodeFlagsInferencePhase.cpp:

(JSC::DFG::ArithNodeFlagsInferencePhase::propagate):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addToGraph):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCFAPhase.cpp:

(JSC::DFG::CFAPhase::performBlockCFA):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::endIndexForPureCSE):
(JSC::DFG::CSEPhase::pureCSE):
(JSC::DFG::CSEPhase::clobbersWorld):
(JSC::DFG::CSEPhase::impureCSE):
(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::eliminate):
(JSC::DFG::CSEPhase::performNodeCSE):
(JSC::DFG::CSEPhase::performBlockCSE):
(CSEPhase):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::opName):
(JSC::DFG::Graph::dump):
(DFG):

  • dfg/DFGNode.cpp: Added.

(DFG):
(JSC::DFG::arithNodeFlagsAsString):

  • dfg/DFGNode.h:

(DFG):
(JSC::DFG::nodeUsedAsNumber):
(JSC::DFG::nodeCanTruncateInteger):
(JSC::DFG::nodeCanIgnoreNegativeZero):
(JSC::DFG::nodeMayOverflow):
(JSC::DFG::nodeCanSpeculateInteger):
(JSC::DFG::defaultFlags):
(JSC::DFG::Node::Node):
(Node):
(JSC::DFG::Node::setOpAndDefaultFlags):
(JSC::DFG::Node::mustGenerate):
(JSC::DFG::Node::arithNodeFlags):
(JSC::DFG::Node::setArithNodeFlag):
(JSC::DFG::Node::mergeArithNodeFlags):
(JSC::DFG::Node::hasResult):
(JSC::DFG::Node::hasInt32Result):
(JSC::DFG::Node::hasNumberResult):
(JSC::DFG::Node::hasJSResult):
(JSC::DFG::Node::hasBooleanResult):
(JSC::DFG::Node::isJump):
(JSC::DFG::Node::isBranch):
(JSC::DFG::Node::isTerminal):
(JSC::DFG::Node::child1):
(JSC::DFG::Node::child2):
(JSC::DFG::Node::child3):
(JSC::DFG::Node::firstChild):
(JSC::DFG::Node::numChildren):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::vote):
(JSC::DFG::PredictionPropagationPhase::fixupNode):

  • dfg/DFGScoreBoard.h:

(ScoreBoard):
(JSC::DFG::ScoreBoard::~ScoreBoard):
(JSC::DFG::ScoreBoard::assertClear):
(JSC::DFG::ScoreBoard::use):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::useChildren):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGVirtualRegisterAllocationPhase.cpp:

(JSC::DFG::VirtualRegisterAllocationPhase::run):

02:19 Changeset [110418] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, remove flakiness flags for timeline-start-time.html following a fix in r100417.
https://bugs.webkit.org/show_bug.cgi?id=80803

  • platform/chromium/test_expectations.txt:
02:02 Changeset [110417] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed flakiness fix.

  • inspector/timeline/timeline-start-time.html:
01:59 Changeset [110416] by philn@webkit.org
  • 15 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r110409. And skip a new GTK
layout test failing after r110371.

  • platform/gtk/Skipped:
  • platform/gtk/fast/hidpi/video-controls-in-hidpi-expected.txt:
  • platform/gtk/fast/layers/video-layer-expected.txt:
  • platform/gtk/media/audio-controls-rendering-expected.txt:
  • platform/gtk/media/audio-repaint-expected.txt:
  • platform/gtk/media/controls-strict-expected.txt:
  • platform/gtk/media/controls-styling-expected.txt:
  • platform/gtk/media/controls-without-preload-expected.txt:
  • platform/gtk/media/media-controls-clone-expected.txt:
  • platform/gtk/media/media-document-audio-repaint-expected.txt:
  • platform/gtk/media/video-controls-rendering-expected.txt:
  • platform/gtk/media/video-empty-source-expected.txt:
  • platform/gtk/media/video-no-audio-expected.txt:
  • platform/gtk/media/video-zoom-controls-expected.txt:
01:52 Changeset [110415] by rolandsteiner@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed: Fix typos in fast/css/style-scoped/style-scoped-basic.html layout test.

  • fast/css/style-scoped/style-scoped-basic.html:
01:38 Changeset [110414] by tkent@chromium.org
  • 3 edits in trunk/Source/WebCore

Use ICU C API instead of C++ API in LocalizedNumberICU
https://bugs.webkit.org/show_bug.cgi?id=80815
https://bugs.gentoo.org/show_bug.cgi?id=407401

Reviewed by Hajime Morita.

ICU 4.8 doesn't have kNumberStyle. We had better to use ICU C API in
general to avoid such issues.

This patch should not make any behavior change.

  • platform/text/LocalizedNumberICU.cpp:

(WebCore::ICULocale::ICULocale):
Change the argument type: icu::Locale -> const char*
(WebCore::ICULocale::~ICULocale): Delete m_numberFormat with unum_close().
(WebCore::ICULocale::create): Do not create icu::Locale.
(WebCore::ICULocale::createForCurrentLocale): ditto.
(WebCore::ICULocale::setDecimalSymbol):
Use unum_getSymbol() instead of DecimalFormatSymbols::getSymbol().
(WebCore::ICULocale::setDecimalTextAttribute):
Added. A utility function to store prefixes and suffixes.
(WebCore::ICULocale::initializeDecimalFormat):

  • unum_open(), instead of NumberFormat::createInstance().
  • Use C API symbols.
  • Cache positive/negative prefixes/suffixes.

(WebCore::ICULocale::convertToLocalizedNumber): Use cached prefixes and suffixes.
(WebCore::matches): Stop using template because we don't use UString anymore.
(WebCore::ICULocale::detectSignAndGetDigitRange):

  • Use cached prefixes and suffixes.
  • Use String::startsWith() and endsWith().

(WebCore::ICULocale::convertFromLocalizedNumber):

  • platform/text/LocalizedNumberICU.h:

(ICULocale):

01:32 Changeset [110413] by podivilov@chromium.org
  • 8 edits in trunk

Web Inspector: decouple LiveLocation from RawSourceCode.
https://bugs.webkit.org/show_bug.cgi?id=80785

Reviewed by Vsevolod Vlasov.

Source/WebCore:

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.createPlacard):
(WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
(WebInspector.PresentationCallFrame):
(WebInspector.PresentationCallFrame.prototype.uiLocation):
(WebInspector.DebuggerPresentationModel.CallFramePlacard):

  • inspector/front-end/RawSourceCode.js:
  • inspector/front-end/ScriptMapping.js:

(WebInspector.MainScriptMapping):
(WebInspector.MainScriptMapping.prototype.createLiveLocation):
(WebInspector.MainScriptMapping.prototype._registerLiveLocation):
(WebInspector.MainScriptMapping.prototype._unregisterLiveLocation):
(WebInspector.MainScriptMapping.prototype._updateLiveLocations):
(WebInspector.MainScriptMapping.prototype._uiSourceCodeListChanged):
(WebInspector.MainScriptMapping.prototype.reset):
(WebInspector.LiveLocation):
(WebInspector.LiveLocation.prototype.init):
(WebInspector.LiveLocation.prototype.dispose):
(WebInspector.LiveLocation.prototype._update):

LayoutTests:

  • inspector/debugger/callstack-placards-discarded-expected.txt:
  • inspector/debugger/callstack-placards-discarded.html:
  • inspector/debugger/linkifier.html:
00:14 Changeset [110412] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

Remove unnecessary call to NSSizeToCGSize().
https://bugs.webkit.org/show_bug.cgi?id=80817

Reviewed by Dan Bernstein.

There is no need to call NSSizeToCGSize() to convert an IntSize to a
CGSize. IntSize defines a conversion function to CGSize that will do
this for us implicitly.

  • UIProcess/mac/BackingStoreMac.mm:

(WebKit::BackingStore::backingStoreContext): Do not call NSSizeToCGSize().

03/11/12:

23:07 Changeset [110411] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

  • platform/chromium/test_expectations.txt:
22:59 Changeset [110410] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

  • platform/chromium/test_expectations.txt:
21:47 Changeset [110409] by commit-queue@webkit.org
  • 16 edits in trunk

Source/WebCore: The main code structure for placing future text track cue rendering
code and main outer rendering steps.
https://bugs.webkit.org/show_bug.cgi?id=79746

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-03-11
Reviewed by Eric Carlson.

No new tests. Only refactoring, but some chromium tests require rebaselining
and have been marked accordingly.

  • css/mediaControls.css:

(::-webkit-media-controls): Changed the default display to -webkit-box, as
captions need to always be rendered on top of the controls, if they are visible.
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
Default position attribute is now relative, handled by the parent -webkit-box
(video::-webkit-media-text-track-container): The position of the container is
now relative, handled by -webkit-box.
(video::-webkit-media-text-track-display): Adjusted text color to match
the color required in the WebVTT spec (section 3.5.1 'color' property)

  • css/mediaControlsChromium.css:

(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
Default position attribute is now relative, handled by the parent -webkit-box

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::MediaControlPanelElement): Added a timer
for the webkit fade out transition event. This timer is required for setting
the display property to 'none', when the fade out transition is over. Otherwise,
captions would not be displayed at the bottom of the video.
(WebCore::MediaControlPanelElement::startTimer): Added.
(WebCore):
(WebCore::MediaControlPanelElement::stopTimer): Added.
(WebCore::MediaControlPanelElement::transitionTimerFired): Added. If the current
state of the controls is transparent, the display property is set to 'none'.
(WebCore::MediaControlPanelElement::makeOpaque): The inline display:'none' property
is removed before the fade in transition.
(WebCore::MediaControlPanelElement::makeTransparent): Added the timer start.
(WebCore::MediaControlTextTrackContainerElement::MediaControlTextTrackContainerElement):
Removed m_bottom as it is not needed anymore.
(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Added. Main
function for the rendering rules.
(WebCore::MediaControlTextTrackContainerElement::updateSizes): The bottom position
needs not to be set anymore.

  • html/shadow/MediaControlElements.h:

(MediaControlPanelElement): Added timer internals.
(MediaControlTextTrackContainerElement): Added updateDisplay() and removed unused
variables.

(WebCore):

  • html/shadow/MediaControlRootElement.cpp: Removed m_textTrackDisplay

and duplicated code with MediaControlRootElementChromium (only minimum
function calls to the main text track container)
(WebCore::MediaControlRootElement::MediaControlRootElement):
(WebCore::MediaControlRootElement::setMediaController):
(WebCore::MediaControlRootElement::createTextTrackDisplay):
(WebCore::MediaControlRootElement::updateTextTrackDisplay):

  • html/shadow/MediaControlRootElementChromium.cpp: Removed m_textTrackDisplay

and duplicate code with MediaControlRootElement (only minimum function calls
to the main text track container remained)
(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
(WebCore::MediaControlRootElementChromium::setMediaController):
(WebCore::MediaControlRootElementChromium::createTextTrackDisplay):
(WebCore::MediaControlRootElementChromium::updateTextTrackDisplay):

(WebCore):

  • html/track/TextTrackCue.cpp: Enhanced structure for supporting more complex

rendering required by the WebVTT spec.
(WebCore::TextTrackCue::TextTrackCue):
(WebCore::TextTrackCue::cueDidChange): Mark the display tree as obsolete, so that
it needs to be re-computed.
(WebCore::TextTrackCue::setIsActive): The display tree needs to be removed as
soon as the cue becomes inactive. Adjusted this method to support the functionality.
(WebCore):
(WebCore::TextTrackCue::determineDisplayParameters): Added. This method will hold
main positioning parameter computations for a TextTrackCue
(WebCore):
(WebCore::TextTrackCue::getDisplayTree): Added. This method returns the root node
of the CSS boxes that need to be displayed on top of the video, for the current
instance.

  • html/track/TextTrackCue.h:

(WebCore):
(TextTrackCue):

LayoutTests: Updated layout tests for basic rendering of cues.
Some Chromium tests require rebaselining and have been marked accordingly.

https://bugs.webkit.org/show_bug.cgi?id=79746

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-03-11
Reviewed by Eric Carlson.

  • media/media-controls.js: Adjusted helper function.

(mediaControlsElement):
(textTrackDisplayElement): If the method is called with only
one parameter, it returns the text track container instead of
a specific cue.

  • media/track/track-cue-mutable-text-expected.txt: Adjusted.
  • media/track/track-cue-nothing-to-render-expected.txt: Adjusted.
  • media/track/track-cue-rendering-expected.txt: Adjusted.
  • media/track/track-cue-rendering.html: Adjusted.
  • platform/chromium/test_expectations.txt: Marked tests that need to

be rebaselined accordingly.

21:04 Changeset [110408] by noel.gordon@gmail.com
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed gardening. Rebaseline svg/text/foreignObject-repaint.xml to close
out http://crbug.com/11483

  • platform/chromium-linux/svg/text/foreignObject-repaint-expected.png: Added.
  • platform/chromium/test_expectations.txt:
20:57 Changeset [110407] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations

  • platform/chromium/test_expectations.txt:
19:26 Changeset [110406] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium test expectations.

  • platform/chromium/test_expectations.txt:
18:29 Changeset [110405] by commit-queue@webkit.org
  • 8 edits in trunk/Source

Unreviewed, rolling out r110359.
http://trac.webkit.org/changeset/110359
https://bugs.webkit.org/show_bug.cgi?id=80799

SelectPopupMenuTest.ClickItem failure (Requested by ukai on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-11

Source/WebCore:

  • platform/chromium/PopupListBox.cpp:

(WebCore::PopupListBox::paint):
(WebCore::PopupListBox::paintRow):
(WebCore::PopupListBox::getRowHeight):

  • platform/chromium/PopupListBox.h:

(PopupContainerSettings):

  • platform/chromium/PopupMenuChromium.cpp:

(WebCore):
(WebCore::PopupMenuChromium::show):

  • platform/chromium/PopupMenuChromium.h:

(PopupMenuChromium):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::showPopup):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::gestureEvent):
(WebKit::WebViewImpl::applyAutofillSuggestions):

18:29 Changeset [110404] by timothy@apple.com
  • 3 edits in trunk/Source

Mac build fix.

18:14 Changeset [110403] by timothy@apple.com
  • 4 edits in trunk/Source/WebKit

Update how the Web Inspector resources are loaded.

https://bugs.webkit.org/show_bug.cgi?id=80798
rdar://problem/10359959

Reviewed by Brian Weinstein.

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj: Add a framework.

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.mm:

(useWebKitWebInspector): Return if we are using the WebCore resources for compatibility
with local and nightly builds.
(WebInspectorFrontendClient::localizedStringsURL): Decide what path to use.
(-[WebInspectorWindowController init]): Ditto.
(-[WebInspectorWindowController window]): Decide if the window is textured or not.

17:40 Changeset [110402] by timothy@apple.com
  • 2 edits in trunk/Source/WebCore

Fix a crash opening the Web Inspector in WebKit1 clients.

The call to InspectorFrontendClientLocal::setAttachedWindow is preformed really early in the process,
causing it to crash almost every time. It should use evaluateOnLoad instead of evaluateAsBoolean.

<rdar://problem/10951109> Crash when bringing up Web Inspector in WebKit1 client
https://bugs.webkit.org/show_bug.cgi?id=80796

Reviewed by Brian Weinstein.

  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::setAttachedWindow): Use evaluateOnLoad instead of evaluateAsBoolean.

15:17 Changeset [110401] by shawnsingh@chromium.org
  • 3 edits
    3 adds in trunk

REGRESSION (r93614): scrolling div does not repaint
https://bugs.webkit.org/show_bug.cgi?id=80641

Reviewed by Simon Fraser.

Source/WebCore:

Test: compositing/repaint/newly-composited-repaint-rect.html

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateBacking): When a layer
becomes newly composited and creates its backing, the repaintRect
may become invalid. This patch recomputes repaintRects in this
case.

LayoutTests:

  • compositing/repaint/newly-composited-repaint-rect-expected.png: Added.
  • compositing/repaint/newly-composited-repaint-rect-expected.txt: Added.
  • compositing/repaint/newly-composited-repaint-rect.html: Added.
15:07 Changeset [110400] by jochen@chromium.org
  • 1 edit
    2 copies in branches/chromium/1025

Merge 108780 - [v8] when a named item on document goes out of scope, actually remove it
https://bugs.webkit.org/show_bug.cgi?id=79409

Reviewed by Adam Barth.

Source/WebCore:

The original change already included the code, but it led to some
problems, so it was reverted in http://trac.webkit.org/changeset/63845.
However, not removing the items leaks a considerable amount of memory,
so I'm adding the code back. The bug that led to the revert was that
the accessor was removed unconditionally. I'm now only removing it,
when the last item with that name is removed.

Test: fast/dom/HTMLDocument/named-item.html

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::namedItemRemoved):

LayoutTests:

  • fast/dom/HTMLDocument/named-item-expected.txt: Added.
  • fast/dom/HTMLDocument/named-item.html: Added.

TBR=jochen@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9667038

13:12 Changeset [110399] by staikos@webkit.org
  • 2 edits in trunk/Source/WebCore

Enable JPEG encoding for BlackBerry.
https://bugs.webkit.org/show_bug.cgi?id=80792

Reviewed by Antonio Gomes.

  • PlatformBlackBerry.cmake:
12:52 Changeset [110398] by barraclough@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

Inconsistent SyntaxError from new Function(...)
https://bugs.webkit.org/show_bug.cgi?id=59795

Rubber stamped by Oliver Hunt.

  • fast/js/function-constructor-error-expected.txt: Added.
  • fast/js/function-constructor-error.html: Added.
  • fast/js/script-tests/function-constructor-error.js: Added.
    • Adding test cases.
12:50 Changeset [110397] by mitz@apple.com
  • 12 edits
    4 adds in trunk/Source/WebKit2

WebKit2 lacks API for obtaining a representation of the RenderLayer tree of a page, like WebRenderLayer
<http://webkit.org/b/80791>

Reviewed by Anders Carlsson.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • Shared/API/c/WKBase.h: Added a type definition of WKRenderLayerRef.
  • Shared/API/c/WKRenderLayer.cpp: Added.

(WKRenderLayerGetTypeID): Added. Returns the WKRenderLayer type ID.
(WKRenderLayerCopyRendererName): Added this getter wrapper.
(WKRenderLayerCopyElementTagName): Ditto.
(WKRenderLayerCopyElementID): Ditto.
(WKRenderLayerGetElementClassNames): Ditto.
(WKRenderLayerGetAbsoluteBounds): Ditto.
(WKRenderLayerIsClipping): Ditto.
(WKRenderLayerIsClipped): Ditto.
(WKRenderLayerIsReflection): Ditto.
(WKRenderLayerGetCompositingLayerType): Ditto.
(WKRenderLayerGetNegativeZOrderList): Ditto.
(WKRenderLayerGetNormalFlowList): Ditto.
(WKRenderLayerGetPositiveZOrderList): Ditto.

  • Shared/API/c/WKRenderLayer.h: Added.
  • Shared/APIObject.h: Added TypeRenderLayer to the APIObject::Type enum.
  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode): Added WebRenderLayer encoding.
(WebKit::UserMessageDecoder::baseDecode): Added WebRenderLayer decoding.

  • Shared/WebRenderLayer.cpp: Added.

(WebKit::WebRenderLayer::create): Added. Creates a WebRenderLayer for the page’s main
frame’s root layer.
(WebKit::WebRenderLayer::createArrayFromLayerList): Added this helper function.
(WebKit::WebRenderLayer::WebRenderLayer): Added. Constructs a WebRenderLayer with the
renderer name, element tag, ID and class names, metrics, child lists, and compositing
layer properties of the given RenderLayer.

  • Shared/WebRenderLayer.h: Added.

(WebKit::WebRenderLayer::create):
(WebKit::WebRenderLayer::negativeZOrderList):
(WebKit::WebRenderLayer::normalFlowList):
(WebKit::WebRenderLayer::positiveZOrderList):
(WebKit::WebRenderLayer::renderObjectName):
(WebKit::WebRenderLayer::elementTagName):
(WebKit::WebRenderLayer::elementID):
(WebKit::WebRenderLayer::elementClassNames):
(WebKit::WebRenderLayer::isReflection):
(WebKit::WebRenderLayer::isClipping):
(WebKit::WebRenderLayer::isClipped):
(WebKit::WebRenderLayer::compositingLayerType):
(WebKit::WebRenderLayer::absoluteBoundingBox):
(WebKit::WebRenderLayer::WebRenderLayer):

  • Target.pri
  • UIProcess/API/C/WKAPICast.h: Added a mapping between WKRenderLayerRef and WebRenderLayer.
  • WebKit2.xcodeproj/project.pbxproj: Added WebRenderLayer.{cpp,h} and WKRenderLayer.{cpp,h}.
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageCopyRenderLayerTree): Added this bundle API for getting the layer tree.

  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
  • win/WebKit2.vcproj:
11:58 Changeset [110396] by barraclough@apple.com
  • 5 edits in trunk

Source/JavaScriptCore: LLInt should support JSVALUE64
https://bugs.webkit.org/show_bug.cgi?id=79609
<rdar://problem/10063437>

Patch by Filip Pizlo <fpizlo@apple.com> on 2012-03-10
Reviewed by Gavin Barraclough and Oliver Hunt.

Ported the LLInt, which previously only worked on 32-bit, to 64-bit. This
patch moves a fair bit of code from LowLevelInterpreter32_64.asm to the common
file, LowLevelInterpreter.asm. About 1/3 of the LLInt did not have to be
specialized for value representation.

Also made some minor changes to offlineasm and the slow-paths.

  • llint/LLIntData.cpp:

(JSC::LLInt::Data::performAssertions):

  • llint/LLIntEntrypoints.cpp:
  • llint/LLIntSlowPaths.cpp:

(LLInt):
(JSC::LLInt::llint_trace_value):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::jitCompileAndSetHeuristics):

  • llint/LLIntSlowPaths.h:

(LLInt):
(SlowPathReturnType):
(JSC::LLInt::SlowPathReturnType::SlowPathReturnType):
(JSC::LLInt::encodeResult):

  • llint/LLIntThunks.cpp:
  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • offlineasm/armv7.rb:
  • offlineasm/asm.rb:
  • offlineasm/ast.rb:
  • offlineasm/backends.rb:
  • offlineasm/instructions.rb:
  • offlineasm/parser.rb:
  • offlineasm/registers.rb:
  • offlineasm/transform.rb:
  • offlineasm/x86.rb:
  • wtf/Platform.h:

LayoutTests: Object.freeze broken on latest Nightly
https://bugs.webkit.org/show_bug.cgi?id=80577

Reviewed by Oliver Hunt.

  • fast/js/preventExtensions-expected.txt:
  • fast/js/script-tests/preventExtensions.js:
    • Added test cases.
10:34 Changeset [110395] by pfeldman@chromium.org
  • 6 edits
    2 adds in trunk

Web Inspector: console.log attempts to substitute any "%" character in the message.
https://bugs.webkit.org/show_bug.cgi?id=80504

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: inspector/console/console-string-format.html

  • inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):

  • inspector/front-end/ProfileDataGridTree.js:
  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):

  • inspector/front-end/utilities.js:

LayoutTests:

  • inspector/console/console-string-format-expected.txt: Added.
  • inspector/console/console-string-format.html: Added.
09:35 Changeset [110394] by caseq@chromium.org
  • 6 edits
    2 adds in trunk

Web Inspector: use monotonically increasing time in timeline agent
https://bugs.webkit.org/show_bug.cgi?id=80786

Reviewed by Pavel Feldman.

  • bindings/v8/ScriptGCEvent.cpp:

(WebCore::ScriptGCEvent::gcPrologueCallback):
(WebCore::ScriptGCEvent::gcEpilogueCallback):

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::pushGCEventRecords):
(WebCore::InspectorTimelineAgent::willSendResourceRequest):
(WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
(WebCore::InspectorTimelineAgent::appendRecord):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):
(WebCore::InspectorTimelineAgent::timestamp):
(WebCore):

  • inspector/InspectorTimelineAgent.h:

(InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::timestamp):

08:09 Changeset [110393] by vsevik@chromium.org
  • 5 edits
    3 adds in trunk

Web Inspector: Network panel does not show responses for application/json data
https://bugs.webkit.org/show_bug.cgi?id=80684

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/network/async-xhr-json-mime-type.html

  • inspector/InspectorPageAgent.cpp:

(WebCore::createXHRTextDecoder):
(WebCore::InspectorPageAgent::cachedResourceContent):

  • inspector/InspectorPageAgent.h:
  • inspector/NetworkResourcesData.cpp:

(WebCore::createOtherResourceTextDecoder):
(WebCore):
(WebCore::NetworkResourcesData::responseReceived):

LayoutTests:

  • http/tests/inspector/network/async-xhr-json-mime-type-expected.txt: Added.
  • http/tests/inspector/network/async-xhr-json-mime-type.html: Added.
  • http/tests/inspector/network/resources/json.php: Added.
07:59 Changeset [110392] by vsevik@chromium.org
  • 3 edits
    3 adds in trunk

Web Inspector: CSS content is not shown when stylesheet is loaded with invalid mime type in quirks mode.
https://bugs.webkit.org/show_bug.cgi?id=80528

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/resource-tree/resource-tree-invalid-mime-type-css-content.html

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::cachedResourceContent):

LayoutTests:

  • http/tests/inspector/resource-tree/resource-tree-invalid-mime-type-css-content-expected.txt: Added.
  • http/tests/inspector/resource-tree/resource-tree-invalid-mime-type-css-content.html: Added.
  • http/tests/inspector/resource-tree/resources/stylesheet-text-plain.php: Added.
06:15 Changeset [110391] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Web Inspector: [chromium] add provisional test for the downstream sanity test.
https://bugs.webkit.org/show_bug.cgi?id=80784

Reviewed by Yury Semikhatsky.

  • src/js/Tests.js:

(.TestSuite.prototype.checkLogAndErrorMessages.validMessage):
(.TestSuite.prototype.checkLogAndErrorMessages.onConsoleMessage):
(.TestSuite.prototype.checkLogAndErrorMessages):

03:11 Changeset [110390] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

<http://webkit.org/b/80782> Web Inspector: Crash using released frontendClient when resizing window with closed inspector

The WebInspectorFrontendClient reference should be cleared when the
WebInspectorClient::closeInspectorFrontend is called. This adds a
destroyInspectorPage to mirror createInspectorPage and clear the weak
pointers that are no longer valid.

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-03-11
Reviewed by Pavel Feldman.

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::closeInspectorFrontend):
(WebKit::WebInspectorClient::didResizeMainFrame):

  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::destroyInspectorPage):

  • WebProcess/WebPage/WebInspector.h:
01:11 Changeset [110389] by mjs@apple.com
  • 4 edits
    1 add in trunk

Add --instruments option to sunspider to profile with Instruments
https://bugs.webkit.org/show_bug.cgi?id=80783

Reviewed by Filip Pizlo.

PerformanceTests/SunSpider:

  • resources/TimeProfile20us.tracetemplate: Added.
  • sunspider:

(runTestsOnce):

Tools:

  • Scripts/run-sunspider:
00:26 Changeset [110388] by ostapenko.viatcheslav@nokia.com
  • 9 edits
    1 copy
    1 move
    1 add in trunk

[Qt] [WK2] Support threaded renderer in WK2
https://bugs.webkit.org/show_bug.cgi?id=76661

Source/WebCore:

Reviewed by Noam Rosenthal.

Add TransformationMatrix conversions from/to Qt QMatrix4x4. Used by Qt WebKit2
rendering and tested by Qt WebKit2 API tests.

  • platform/graphics/qt/TransformationMatrixQt.cpp:

(WebCore::TransformationMatrix::operator QMatrix4x4):
(WebCore):
(WebCore::TransformationMatrix::TransformationMatrix):

  • platform/graphics/transforms/TransformationMatrix.h:

(TransformationMatrix):

Source/WebKit2:

Reviewed by Noam Rosenthal.

Implement Qt5 threaded rendering support for Qt WebKit2.
Parts of LayerTreeHostProxy which contain layer tree and layer painting objects
are moved to separate class called WebLayerTreeRenderer. WebLayerTreeRenderer is
thread safe ref counted and referenced by LayerTreeHostProxy and paint node.
All layer tree and graphics objects are created, accessed and deallocated from Qt
Scenegraph's paint thread only.
Layer tree updates from render queue are fetched in updatePaintNode call stack when
main thread is locked.
Messages from paint thread to web process are passed through MainThreadGuardedInvoker
call gate (implemented by Noam Rosenthal and previously reviewed by Kenneth Rohde
Christiansen).

  • Target.pri:
  • UIProcess/API/qt/qquickwebpage.cpp:

(PageProxyNode::PageProxyNode):
(PageProxyNode::render):
(PageProxyNode::~PageProxyNode):
(PageProxyNode::layerTreeRenderer):
(PageProxyNode):
(PageProxyNode::setScale):
(QQuickWebPage::updatePaintNode):
(QQuickWebPagePrivate::~QQuickWebPagePrivate):

  • UIProcess/LayerTreeHostProxy.cpp: Added.

(WebKit):
(WebKit::LayerTreeHostProxy::LayerTreeHostProxy):
(WebKit::LayerTreeHostProxy::~LayerTreeHostProxy):
(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit::LayerTreeHostProxy::paintToGraphicsContext):
(WebKit::LayerTreeHostProxy::updateViewport):
(WebKit::LayerTreeHostProxy::dispatchUpdate):
(WebKit::LayerTreeHostProxy::createTileForLayer):
(WebKit::LayerTreeHostProxy::updateTileForLayer):
(WebKit::LayerTreeHostProxy::removeTileForLayer):
(WebKit::LayerTreeHostProxy::deleteCompositingLayer):
(WebKit::LayerTreeHostProxy::setRootCompositingLayer):
(WebKit::LayerTreeHostProxy::syncCompositingLayerState):
(WebKit::LayerTreeHostProxy::didRenderFrame):
(WebKit::LayerTreeHostProxy::createDirectlyCompositedImage):
(WebKit::LayerTreeHostProxy::destroyDirectlyCompositedImage):
(WebKit::LayerTreeHostProxy::setVisibleContentsRectForPanning):
(WebKit::LayerTreeHostProxy::setVisibleContentsRectForScaling):
(WebKit::LayerTreeHostProxy::renderNextFrame):
(WebKit::LayerTreeHostProxy::purgeBackingStores):

  • UIProcess/LayerTreeHostProxy.h:

(WebKit):
(LayerTreeHostProxy):
(WebKit::LayerTreeHostProxy::layerTreeRenderer):

  • UIProcess/WebLayerTreeRenderer.cpp: Renamed from Source/WebKit2/UIProcess/qt/LayerTreeHostProxyQt.cpp.

(WebKit):
(MainThreadGuardedInvoker):
(WebKit::MainThreadGuardedInvoker::call):
(WebKit::MainThreadGuardedInvoker::MainThreadGuardedInvoker):
(WebKit::MainThreadGuardedInvoker::invoke):
(WebKit::WebLayerTreeRenderer::callOnMainTread):
(WebKit::WebLayerTreeRenderer::WebLayerTreeRenderer):
(WebKit::WebLayerTreeRenderer::~WebLayerTreeRenderer):
(WebKit::WebLayerTreeRenderer::createLayer):
(WebKit::WebLayerTreeRenderer::paintToCurrentGLContext):
(WebKit::WebLayerTreeRenderer::syncAnimations):
(WebKit::WebLayerTreeRenderer::paintToGraphicsContext):
(WebKit::WebLayerTreeRenderer::setVisibleContentsRectForScaling):
(WebKit::WebLayerTreeRenderer::updateViewport):
(WebKit::WebLayerTreeRenderer::syncLayerParameters):
(WebKit::WebLayerTreeRenderer::deleteLayer):
(WebKit::WebLayerTreeRenderer::ensureLayer):
(WebKit::WebLayerTreeRenderer::setRootLayerID):
(WebKit::WebLayerTreeRenderer::getBackingStore):
(WebKit::WebLayerTreeRenderer::createTile):
(WebKit::WebLayerTreeRenderer::removeTile):
(WebKit::WebLayerTreeRenderer::updateTile):
(WebKit::WebLayerTreeRenderer::createImage):
(WebKit::WebLayerTreeRenderer::destroyImage):
(WebKit::WebLayerTreeRenderer::assignImageToLayer):
(WebKit::WebLayerTreeRenderer::swapBuffers):
(WebKit::WebLayerTreeRenderer::flushLayerChanges):
(WebKit::WebLayerTreeRenderer::renderNextFrame):
(WebKit::WebLayerTreeRenderer::ensureRootLayer):
(WebKit::WebLayerTreeRenderer::syncRemoteContent):
(WebKit::WebLayerTreeRenderer::purgeGLResources):
(WebKit::WebLayerTreeRenderer::purgeBackingStores):
(WebKit::WebLayerTreeRenderer::detach):
(WebKit::WebLayerTreeRenderer::appendUpdate):

  • UIProcess/WebLayerTreeRenderer.h: Copied from Source/WebKit2/UIProcess/LayerTreeHostProxy.h.

(WebKit):
(WebLayerTreeRenderer):
(WebKit::WebLayerTreeRenderer::layerByID):
(WebKit::WebLayerTreeRenderer::rootLayer):
(WebKit::WebLayerTreeRenderer::notifyAnimationStarted):
(WebKit::WebLayerTreeRenderer::notifySyncRequired):
(WebKit::WebLayerTreeRenderer::showDebugBorders):
(WebKit::WebLayerTreeRenderer::showRepaintCounter):
(WebKit::WebLayerTreeRenderer::paintContents):

Tools:

Remove disabling of threaded rendering.

Reviewed by Noam Rosenthal.

  • MiniBrowser/qt/main.cpp:

(main):

03/10/12:

20:48 Changeset [110387] by dbates@webkit.org
  • 3 edits in trunk/Websites/webkit.org

Switch from HTTP to HTTPS for Xcode developer.apple.com hyperlinks

The Debugging and Analyzing Your Code page cannot be viewed at <http://developer.apple.com/library/mac/#documentation/ToolsLanguages/Conceptual/Xcode4UserGuide/Debugging/Debugging.html#//apple_ref/doc/uid/TP40010215-CH3-SW1> (1) as this URL redirects to the Mac OS X Developer Library <https://developer.apple.com/library/mac/navigation/>.
Substituting https for http in (1) returns the expected page.

  • building/debug-mac-uiprocess.html:
  • building/debug.html:
20:23 Changeset [110386] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r110384.
http://trac.webkit.org/changeset/110384
https://bugs.webkit.org/show_bug.cgi?id=80774

compile failed on Chromium Win Release (Requested by ukai_home
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-10

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore::LayerChromiumWithForcedDrawsContent::LayerChromiumWithForcedDrawsContent):
(WebCore::LayerChromiumWithForcedDrawsContent::opaqueContentsRegion):
(WebCore::LayerChromiumWithForcedDrawsContent::setOpaquePaintRect):
(LayerChromiumWithForcedDrawsContent):
(WebCore::setLayerPropertiesForTesting):
(WebCore):
(WebCore::TestCCOcclusionTracker::TestCCOcclusionTracker):
(WebCore::TestCCOcclusionTracker::occlusionInScreenSpace):
(WebCore::TestCCOcclusionTracker::occlusionInTargetSurface):
(WebCore::TestCCOcclusionTracker::setOcclusionInScreenSpace):
(WebCore::TestCCOcclusionTracker::setOcclusionInTargetSurface):
(WebCore::TestCCOcclusionTracker::layerScissorRectInTargetSurface):
(WebCore::TestDamageClient::damageRect):
(WebCore::layerAddedToOccludedRegion):
(WebCore::layerAddedToOccludedRegionWithRotation):
(WebCore::layerAddedToOccludedRegionWithTranslation):
(WebCore::layerAddedToOccludedRegionWithRotatedSurface):
(WebCore::layerAddedToOccludedRegionWithSurfaceAlreadyOnStack):
(WebCore::layerAddedToOccludedRegionWithRotatedOffAxisSurface):
(WebCore::layerAddedToOccludedRegionWithMultipleOpaqueLayers):
(WebCore::surfaceOcclusionWithOverlappingSiblingSurfaces):
(WebCore::surfaceOcclusionInScreenSpace):
(WebCore::surfaceOcclusionInScreenSpaceDifferentTransforms):
(WebCore::occlusionInteractionWithFilters):
(WebCore::layerScissorRectOverTile):
(WebCore::screenScissorRectOverTile):
(WebCore::layerScissorRectOverCulledTile):
(WebCore::screenScissorRectOverCulledTile):
(WebCore::layerScissorRectOverPartialTiles):
(WebCore::screenScissorRectOverPartialTiles):
(WebCore::layerScissorRectOverNoTiles):
(WebCore::screenScissorRectOverNoTiles):
(WebCore::layerScissorRectForLayerOffOrigin):
(WebCore::damageRectOverTile):
(WebCore::damageRectOverCulledTile):
(WebCore::damageRectOverPartialTiles):
(WebCore::damageRectOverNoTiles):
(WebCore::TEST):

19:56 Changeset [110385] by rniwa@webkit.org
  • 2 edits in trunk

Increment the perf-o-matic app version.

  • Websites/webkit-perf.appspot.com/app.yaml:
18:37 Changeset [110384] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Clean up culling tests and templatize to test impl constructs
https://bugs.webkit.org/show_bug.cgi?id=80613

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-10
Reviewed by Adrienne Walker.

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore::TestContentLayerChromium::TestContentLayerChromium):
(WebCore::TestContentLayerChromium::opaqueContentsRegion):
(WebCore::TestContentLayerChromium::setOpaqueContentsRect):
(TestContentLayerChromium):
(TestContentLayerImpl):
(WebCore::TestContentLayerImpl::TestContentLayerImpl):
(WebCore::TestContentLayerImpl::opaqueContentsRegion):
(WebCore::TestContentLayerImpl::setOpaqueContentsRect):
(WebCore):
(WebCore::TestCCOcclusionTrackerBase::TestCCOcclusionTrackerBase):
(WebCore::TestCCOcclusionTrackerBase::occlusionInScreenSpace):
(WebCore::TestCCOcclusionTrackerBase::occlusionInTargetSurface):
(WebCore::TestCCOcclusionTrackerBase::setOcclusionInScreenSpace):
(WebCore::TestCCOcclusionTrackerBase::setOcclusionInTargetSurface):
(WebCore::TestCCOcclusionTrackerBase::layerScissorRectInTargetSurface):
(WebCore::TestDamageClient::damageRect):
(CCOcclusionTrackerTestMainThreadTypes):
(WebCore::CCOcclusionTrackerTestMainThreadTypes::createLayer):
(WebCore::CCOcclusionTrackerTestMainThreadTypes::createContentLayer):
(CCOcclusionTrackerTestImplThreadTypes):
(WebCore::CCOcclusionTrackerTestImplThreadTypes::createLayer):
(WebCore::CCOcclusionTrackerTestImplThreadTypes::createContentLayer):
(CCOcclusionTrackerTest):
(WebCore::CCOcclusionTrackerTest::TearDown):
(WebCore::CCOcclusionTrackerTest::createRoot):
(WebCore::CCOcclusionTrackerTest::createLayer):
(WebCore::CCOcclusionTrackerTest::createSurface):
(WebCore::CCOcclusionTrackerTest::createDrawingLayer):
(WebCore::CCOcclusionTrackerTest::createDrawingSurface):
(WebCore::CCOcclusionTrackerTest::calcDrawEtc):
(WebCore::CCOcclusionTrackerTest::setBaseProperties):
(WebCore::CCOcclusionTrackerTest::setProperties):
(CCOcclusionTrackerTestIdentityTransforms):
(WebCore::CCOcclusionTrackerTestIdentityTransforms::runMyTest):
(CCOcclusionTrackerTestRotatedChild):
(WebCore::CCOcclusionTrackerTestRotatedChild::runMyTest):
(CCOcclusionTrackerTestTranslatedChild):
(WebCore::CCOcclusionTrackerTestTranslatedChild::runMyTest):
(CCOcclusionTrackerTestChildInRotatedChild):
(WebCore::CCOcclusionTrackerTestChildInRotatedChild::runMyTest):
(CCOcclusionTrackerTestVisitTargetTwoTimes):
(WebCore::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest):
(CCOcclusionTrackerTestSurfaceRotatedOffAxis):
(WebCore::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest):
(CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren):
(WebCore::CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren::runMyTest):
(CCOcclusionTrackerTestOverlappingSurfaceSiblings):
(WebCore::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
(CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms):
(WebCore::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
(CCOcclusionTrackerTestFilters):
(WebCore::CCOcclusionTrackerTestFilters::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectOutsideChild):
(WebCore::CCOcclusionTrackerTestLayerScissorRectOutsideChild::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectOutsideChild):
(WebCore::CCOcclusionTrackerTestScreenScissorRectOutsideChild::runMyTest):
(CCOcclusionTrackerTestDamageRectOutsideChild):
(WebCore::CCOcclusionTrackerTestDamageRectOutsideChild::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectOverChild):
(WebCore::CCOcclusionTrackerTestLayerScissorRectOverChild::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectOverChild):
(WebCore::CCOcclusionTrackerTestScreenScissorRectOverChild::runMyTest):
(CCOcclusionTrackerTestDamageRectOverChild):
(WebCore::CCOcclusionTrackerTestDamageRectOverChild::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectPartlyOverChild):
(WebCore::CCOcclusionTrackerTestLayerScissorRectPartlyOverChild::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectPartlyOverChild):
(WebCore::CCOcclusionTrackerTestScreenScissorRectPartlyOverChild::runMyTest):
(CCOcclusionTrackerTestDamageRectPartlyOverChild):
(WebCore::CCOcclusionTrackerTestDamageRectPartlyOverChild::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectOverNothing):
(WebCore::CCOcclusionTrackerTestLayerScissorRectOverNothing::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectOverNothing):
(WebCore::CCOcclusionTrackerTestScreenScissorRectOverNothing::runMyTest):
(CCOcclusionTrackerTestDamageRectOverNothing):
(WebCore::CCOcclusionTrackerTestDamageRectOverNothing::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectForLayerOffOrigin):
(WebCore::CCOcclusionTrackerTestLayerScissorRectForLayerOffOrigin::runMyTest):
(CCOcclusionTrackerTestOpaqueContentsRegionEmpty):
(WebCore::CCOcclusionTrackerTestOpaqueContentsRegionEmpty::runMyTest):
(CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty):
(WebCore::CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty::runMyTest):

16:33 Changeset [110383] by fpizlo@apple.com
  • 19 edits in trunk/Source/JavaScriptCore

LLInt should support JSVALUE64
https://bugs.webkit.org/show_bug.cgi?id=79609
<rdar://problem/10063437>

Reviewed by Gavin Barraclough and Oliver Hunt.

Ported the LLInt, which previously only worked on 32-bit, to 64-bit. This
patch moves a fair bit of code from LowLevelInterpreter32_64.asm to the common
file, LowLevelInterpreter.asm. About 1/3 of the LLInt did not have to be
specialized for value representation.

Also made some minor changes to offlineasm and the slow-paths.

  • llint/LLIntData.cpp:

(JSC::LLInt::Data::performAssertions):

  • llint/LLIntEntrypoints.cpp:
  • llint/LLIntSlowPaths.cpp:

(LLInt):
(JSC::LLInt::llint_trace_value):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::jitCompileAndSetHeuristics):

  • llint/LLIntSlowPaths.h:

(LLInt):
(SlowPathReturnType):
(JSC::LLInt::SlowPathReturnType::SlowPathReturnType):
(JSC::LLInt::encodeResult):

  • llint/LLIntThunks.cpp:
  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • offlineasm/armv7.rb:
  • offlineasm/asm.rb:
  • offlineasm/ast.rb:
  • offlineasm/backends.rb:
  • offlineasm/instructions.rb:
  • offlineasm/parser.rb:
  • offlineasm/registers.rb:
  • offlineasm/transform.rb:
  • offlineasm/x86.rb:
  • wtf/Platform.h:
10:44 Changeset [110382] by mrobinson@webkit.org
  • 12 edits in trunk/Tools

[WK2] run-perf-tests should be able to run with WTR
https://bugs.webkit.org/show_bug.cgi?id=80042

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-03-09
Reviewed by Martin Robinson.

Add an option to PerfTestRunner to use WebKitTestRunner instead of
DumpRenderTree and add the '--no-timeout' flag to WebKitTestRunner
to avoid timing out when running performance tests.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._parse_args):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::InjectedBundle): Initialize m_useWaitToDumpWatchdogTimer
to true.
(WTR::InjectedBundle::didReceiveMessage): Unpack the 'BeginTest' message
as a dictionary containing DumpPixels and UseWaitToDumpWatchdogTimer keys.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(WTR::InjectedBundle::useWaitToDumpWatchdogTimer): Make m_useWaitToDumpWatchdogTimer
publicly accessible.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::waitUntilDone): Only initialize the watchdog if it
is required.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController): Initialize m_useWaitToDumpWatchdogTimer
to true.
(WTR::TestController::initialize): Set m_useWaitToDumpWatchdogTimer to false
if '--no-timeout' option is present.
(WTR::TestController::runUntil): Translate TimeoutDuration to a proper timeout
value, or -1.0 if timeout should not occur.

  • WebKitTestRunner/TestController.h:

(WTR::TestController::useWaitToDumpWatchdogTimer): Make m_useWaitToDumpWatchdogTimer
publicly accessible.

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::invoke): Pack the 'BeginTest' message as a dictionary,
containing DumpPixels and UseWaitToDumpWatchdogTimer keys and corresponding values.
Waiting for final message should not time out if not necessary.

  • WebKitTestRunner/gtk/TestControllerGtk.cpp:

(WTR::TestController::platformRunUntil): Only set up a timeout if necessary.

  • WebKitTestRunner/qt/TestControllerQt.cpp:

(WTR::TestController::platformRunUntil): Ditto.

  • WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::platformRunUntil): Add a FIXME, indicating functionality
is missing.

  • WebKitTestRunner/win/TestControllerWin.cpp:

(WTR::TestController::platformRunUntil): Ditto.

10:42 Changeset [110381] by jonlee@apple.com
  • 50 edits
    1 move in trunk

Rename NotificationPresenter to NotificationClient
https://bugs.webkit.org/show_bug.cgi?id=80488
<rdar://problem/10965558>

Reviewed by Kentaro Hara.

Source/WebCore:

  • notifications/NotificationCenter.h: Renamed from notifications/NotificationPresenter.h.

Refactor to use renamed WebCore::NotificationClient.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • notifications/Notification.cpp:

(WebCore::Notification::Notification):
(WebCore::Notification::show):
(WebCore::Notification::cancel):
(WebCore::Notification::contextDestroyed):
(WebCore::Notification::finishLoading):

  • notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::create):
(WebCore::NotificationCenter::NotificationCenter):
(WebCore::NotificationCenter::checkPermission):
(WebCore::NotificationCenter::requestPermission):
(WebCore::NotificationCenter::disconnectFrame):

  • notifications/NotificationController.cpp:

(WebCore::NotificationController::NotificationController):
(WebCore::NotificationController::create):
(WebCore::NotificationController::clientFrom):
(WebCore::provideNotification):

  • notifications/NotificationController.h:

(WebCore):
(NotificationController):
(WebCore::NotificationController::client):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::webkitNotifications):

  • page/DOMWindow.h:

(DOMWindow):

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::webkitNotifications):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::WorkerThread):

  • workers/WorkerThread.h:

(WebCore):
(WebCore::WorkerThread::getNotificationClient):
(WebCore::WorkerThread::setNotificationClient):
(WorkerThread):

Source/WebKit/blackberry:

Refactor to use renamed WebCore::NotificationClient.

  • WebCoreSupport/NotificationPresenterImpl.cpp:

(WebCore::NotificationPresenterImpl::instance):
(WebCore::NotificationPresenterImpl::show):
(WebCore::NotificationPresenterImpl::checkPermission):

  • WebCoreSupport/NotificationPresenterImpl.h:

(NotificationPresenterImpl):

Source/WebKit/chromium:

Refactor to use renamed WebCore::NotificationClient.

  • src/AssertMatchingEnums.cpp:
  • src/NotificationPresenterImpl.cpp:

(WebKit::NotificationPresenterImpl::checkPermission):

  • src/NotificationPresenterImpl.h:

(NotificationPresenterImpl):

Source/WebKit/efl:

Refactor to use renamed WebCore::NotificationClient.

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::notificationPresenter):

  • WebCoreSupport/ChromeClientEfl.h:

(ChromeClientEfl):

Source/WebKit/mac:

Refactor to use renamed WebCore::NotificationClient.

  • WebCoreSupport/WebNotificationClient.h:
  • WebCoreSupport/WebNotificationClient.mm:

(WebNotificationClient::checkPermission):

  • WebView/WebViewPrivate.h:

Source/WebKit/qt:

Refactor to use renamed WebCore::NotificationClient.

  • WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationPresenterClientQt::checkPermission):
(WebCore::NotificationPresenterClientQt::allowNotificationForFrame):

  • WebCoreSupport/NotificationPresenterClientQt.h:

(NotificationPresenterClientQt):

Source/WebKit/win:

Refactor to use renamed WebCore::NotificationClient.

  • WebCoreSupport/WebChromeClient.h:

(WebChromeClient::notificationPresenter):

  • WebCoreSupport/WebDesktopNotificationsDelegate.cpp:

(WebDesktopNotificationsDelegate::checkPermission):

  • WebCoreSupport/WebDesktopNotificationsDelegate.h:

(WebDesktopNotificationsDelegate):

Source/WebKit/wince:

Refactor to use renamed WebCore::NotificationClient.

  • WebCoreSupport/ChromeClientWinCE.h:

(ChromeClientWinCE):

Source/WebKit2:

Refactor to use renamed WebCore::NotificationClient.

  • UIProcess/Notifications/WebNotificationManagerProxy.h:
  • WebProcess/Notifications/NotificationPermissionRequestManager.cpp:

(WebKit::NotificationPermissionRequestManager::startRequest):
(WebKit::NotificationPermissionRequestManager::permissionLevel):

  • WebProcess/Notifications/NotificationPermissionRequestManager.h:

(NotificationPermissionRequestManager):

  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::policyForOrigin):

  • WebProcess/Notifications/WebNotificationManager.h:

(WebNotificationManager):

  • WebProcess/WebCoreSupport/WebNotificationClient.cpp:

(WebKit::WebNotificationClient::checkPermission):

  • WebProcess/WebCoreSupport/WebNotificationClient.h:

(WebNotificationClient):

Tools:

Refactor to use renamed WebCore::NotificationClient.

  • DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:

(DRTDesktopNotificationPresenter::checkNotificationPermission):

10:21 Changeset [110380] by jchaffraix@webkit.org
  • 8 edits in trunk

RenderObject with 'resize' different from 'none' should have a RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=80738

Reviewed by James Robinson.

Source/WebCore:

Covered by fast/css/resize-single-axis.html.

  • rendering/RenderBox.h:

(WebCore::RenderBox::requiresLayerForOverflowClip):
The resizer logic is tied to RenderLayer so force a RenderLayer to be allocated if resize() != RESIZE_NONE.

LayoutTests:

  • platform/chromium/test_expectations.txt:
  • platform/efl/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/win/Skipped:

Unskip the test on most platform but Qt. Qt has a bug about the test timing out
which may be related.

09:38 Changeset [110379] by commit-queue@webkit.org
  • 6 edits in trunk/Source/JavaScriptCore

Web Worker crashes with WX_EXCLUSIVE
https://bugs.webkit.org/show_bug.cgi?id=80532

Let each JS global object own a meta allocator
for WX_EXCLUSIVE to avoid conflicts from Web Worker.
Also fix a mutex leak in MetaAllocator's dtor.

Patch by Yong Li <yoli@rim.com> on 2012-03-10
Reviewed by Filip Pizlo.

  • jit/ExecutableAllocator.cpp:

(JSC::DemandExecutableAllocator::DemandExecutableAllocator):
(JSC::DemandExecutableAllocator::~DemandExecutableAllocator):
(JSC::DemandExecutableAllocator::bytesAllocatedByAllAllocators):
(DemandExecutableAllocator):
(JSC::DemandExecutableAllocator::bytesCommittedByAllocactors):
(JSC::DemandExecutableAllocator::dumpProfileFromAllAllocators):
(JSC::DemandExecutableAllocator::allocateNewSpace):
(JSC::DemandExecutableAllocator::allocators):
(JSC::DemandExecutableAllocator::allocatorsMutex):
(JSC):
(JSC::ExecutableAllocator::initializeAllocator):
(JSC::ExecutableAllocator::ExecutableAllocator):
(JSC::ExecutableAllocator::underMemoryPressure):
(JSC::ExecutableAllocator::memoryPressureMultiplier):
(JSC::ExecutableAllocator::allocate):
(JSC::ExecutableAllocator::committedByteCount):
(JSC::ExecutableAllocator::dumpProfile):

  • jit/ExecutableAllocator.h:

(JSC):
(ExecutableAllocator):
(JSC::ExecutableAllocator::allocator):

  • wtf/MetaAllocator.h:

(WTF::MetaAllocator::~MetaAllocator): Finalize the spin lock.

  • wtf/TCSpinLock.h:

(TCMalloc_SpinLock::Finalize): Add empty Finalize() to some implementations.

09:08 Changeset [110378] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r110358.
http://trac.webkit.org/changeset/110358
https://bugs.webkit.org/show_bug.cgi?id=80706

No improvement on specified benchmarks.

  • dom/ContainerNode.cpp:

(WebCore::collectNodes):
(WebCore::collectTargetNodes):

08:01 Changeset [110377] by zimmermann@webkit.org
  • 72 edits in trunk/LayoutTests

2012-03-10 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Final chunk of SL rebaselines with Generic RGB profile for svg/.

  • platform/mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/mac-snowleopard/svg/filters/animate-fill-expected.png:
  • platform/mac-snowleopard/svg/filters/big-sized-filter-2-expected.png:
  • platform/mac-snowleopard/svg/filters/big-sized-filter-expected.png:
  • platform/mac-snowleopard/svg/filters/feColorMatrix-default-type-expected.png:
  • platform/mac-snowleopard/svg/filters/feColorMatrix-offset-expected.png:
  • platform/mac-snowleopard/svg/filters/feColorMatrix-saturate-expected.png:
  • platform/mac-snowleopard/svg/filters/feColorMatrix-values-expected.png:
  • platform/mac-snowleopard/svg/filters/feComposite-expected.png:
  • platform/mac-snowleopard/svg/filters/feConvolveFilter-y-bounds-expected.png:
  • platform/mac-snowleopard/svg/filters/feDisplacementMap-expected.png:
  • platform/mac-snowleopard/svg/filters/feDropShadow-expected.png:
  • platform/mac-snowleopard/svg/filters/feGaussianBlur-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-animated-transform-on-target-rect-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-late-indirect-update-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-multiple-targets-id-change-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-position-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-preserveAspectratio-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-reference-invalidation-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-reference-svg-primitive-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-subregions-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-target-add-to-document-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-target-attribute-change-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-target-changes-id-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-target-id-change-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-target-inline-style-change-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-target-property-change-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-target-reappend-to-document-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-target-remove-from-document-expected.png:
  • platform/mac-snowleopard/svg/filters/feImage-target-style-change-expected.png:
  • platform/mac-snowleopard/svg/filters/feLighting-crash-expected.png:
  • platform/mac-snowleopard/svg/filters/feMerge-expected.png:
  • platform/mac-snowleopard/svg/filters/feOffset-expected.png:
  • platform/mac-snowleopard/svg/filters/feTile-expected.png:
  • platform/mac-snowleopard/svg/filters/filter-clip-expected.png:
  • platform/mac-snowleopard/svg/filters/filter-on-tspan-expected.png:
  • platform/mac-snowleopard/svg/filters/filter-placement-issue-expected.png:
  • platform/mac-snowleopard/svg/filters/filter-refresh-expected.png:
  • platform/mac-snowleopard/svg/filters/filter-rounding-issues-expected.png:
  • platform/mac-snowleopard/svg/filters/filter-source-position-expected.png:
  • platform/mac-snowleopard/svg/filters/filter-width-update-expected.png:
  • platform/mac-snowleopard/svg/filters/filterRes-expected.png:
  • platform/mac-snowleopard/svg/filters/filterRes1-expected.png:
  • platform/mac-snowleopard/svg/filters/filterRes2-expected.png:
  • platform/mac-snowleopard/svg/filters/filterRes3-expected.png:
  • platform/mac-snowleopard/svg/filters/filteredImage-expected.png:
  • platform/mac-snowleopard/svg/filters/parent-children-with-same-filter-expected.png:
  • platform/mac-snowleopard/svg/filters/shadow-on-filter-expected.png:
  • platform/mac-snowleopard/svg/filters/shadow-on-rect-with-filter-expected.png:
  • platform/mac-snowleopard/svg/filters/subRegion-in-userSpace-expected.png:
  • platform/mac-snowleopard/svg/filters/subRegion-one-effect-expected.png:
  • platform/mac-snowleopard/svg/filters/subRegion-two-effects-expected.png:
  • platform/mac-snowleopard/svg/foreignObject/filter-expected.png:
  • platform/mac-snowleopard/svg/repaint/filter-child-repaint-expected.png:
  • platform/mac-snowleopard/svg/repaint/filter-repaint-expected.png:
  • platform/mac-snowleopard/svg/repaint/image-href-change-expected.png:
  • platform/mac-snowleopard/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/mac-snowleopard/svg/webarchive/svg-feimage-subresources-expected.png:
  • platform/mac-snowleopard/svg/wicd/test-rightsizing-b-expected.png:
  • platform/mac-snowleopard/svg/zoom/page/zoom-background-images-expected.png:
  • platform/mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
07:34 Changeset [110376] by zimmermann@webkit.org
  • 197 edits in trunk/LayoutTests

2012-03-10 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Next chunk of SL rebaselines with Generic RGB profile for svg/.

  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDistantLightElement-dom-azimuth-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDistantLightElement-dom-elevation-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-azimuth-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-elevation-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEOffsetElement-dom-dx-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEOffsetElement-dom-dy-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEOffsetElement-dom-in-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dx-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dy-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEOffsetElement-svgdom-in-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-dom-height-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-dom-width-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-dom-x-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-dom-y-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-svgdom-height-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-svgdom-width-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-svgdom-x-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterElement-svgdom-y-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
  • platform/mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
06:52 Changeset [110375] by zimmermann@webkit.org
  • 73 edits in trunk/LayoutTests

2012-03-10 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. First chunk of SL rebaselines with Generic RGB profile for svg/.

  • platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-light-04-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-image-04-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-image-06-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-image-07-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-image-08-t-expected.png:
  • platform/mac-snowleopard/svg/W3C-SVG-1.1/struct-use-01-t-expected.png:
  • platform/mac-snowleopard/svg/as-border-image/svg-as-border-image-2-expected.png:
  • platform/mac-snowleopard/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/mac-snowleopard/svg/batik/filters/feTile-expected.png:
  • platform/mac-snowleopard/svg/batik/filters/filterRegions-expected.png:
  • platform/mac-snowleopard/svg/batik/text/textEffect-expected.png:
  • platform/mac-snowleopard/svg/batik/text/textEffect3-expected.png:
  • platform/mac-snowleopard/svg/carto.net/selectionlist-expected.png:
  • platform/mac-snowleopard/svg/css/path-gradient-stroke-shadow-expected.png:
  • platform/mac-snowleopard/svg/css/rect-gradient-stroke-shadow-expected.png:
  • platform/mac-snowleopard/svg/custom/convolution-crash-expected.png:
  • platform/mac-snowleopard/svg/custom/createImageElement-expected.png:
  • platform/mac-snowleopard/svg/custom/createImageElement2-expected.png:
  • platform/mac-snowleopard/svg/custom/empty-merge-expected.png:
  • platform/mac-snowleopard/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/mac-snowleopard/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/mac-snowleopard/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/mac-snowleopard/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/mac-snowleopard/svg/custom/feDisplacementMap-01-expected.png:
  • platform/mac-snowleopard/svg/custom/focus-ring-expected.png:
  • platform/mac-snowleopard/svg/custom/grayscale-gradient-mask-2-expected.png:
  • platform/mac-snowleopard/svg/custom/group-opacity-expected.png:
  • platform/mac-snowleopard/svg/custom/image-parent-translation-expected.png:
  • platform/mac-snowleopard/svg/custom/image-small-width-height-expected.png:
  • platform/mac-snowleopard/svg/custom/image-with-prefix-in-webarchive-expected.png:
  • platform/mac-snowleopard/svg/custom/image-with-transform-clip-filter-expected.png:
  • platform/mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/mac-snowleopard/svg/custom/js-update-image-and-display-expected.png:
  • platform/mac-snowleopard/svg/custom/js-update-image-and-display2-expected.png:
  • platform/mac-snowleopard/svg/custom/js-update-image-and-display3-expected.png:
  • platform/mac-snowleopard/svg/custom/js-update-image-expected.png:
  • platform/mac-snowleopard/svg/custom/non-opaque-filters-expected.png:
  • platform/mac-snowleopard/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png:
  • platform/mac-snowleopard/svg/custom/pointer-events-image-css-transform-expected.png:
  • platform/mac-snowleopard/svg/custom/pointer-events-image-expected.png:
  • platform/mac-snowleopard/svg/custom/recursive-filter-expected.png:
  • platform/mac-snowleopard/svg/custom/relative-sized-image-expected.png:
  • platform/mac-snowleopard/svg/custom/resource-invalidate-on-target-update-expected.png:
  • platform/mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/mac-snowleopard/svg/custom/text-filter-expected.png:
  • platform/mac-snowleopard/svg/custom/text-image-opacity-expected.png:
  • platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.png:
  • platform/mac-snowleopard/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png:
  • platform/mac-snowleopard/svg/custom/visibility-override-filter-expected.png:
06:28 Changeset [110374] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

ShadowTree uses weak iteration patterns
https://bugs.webkit.org/show_bug.cgi?id=80572

Reviewed by Dimitri Glazkov.

This patch moves various ShadowTree to using a better iteration pattern
in which we collect all the ShadowRoots we're planning to iterate into
a vector and then iterate over them.

  • dom/ShadowTree.cpp:

(ShadowRootVector):
(WebCore::ShadowRootVector::ShadowRootVector):
(WebCore):
(WebCore::ShadowTree::removeAllShadowRoots):
(WebCore::ShadowTree::insertedIntoDocument):
(WebCore::ShadowTree::removedFromDocument):
(WebCore::ShadowTree::insertedIntoTree):
(WebCore::ShadowTree::removedFromTree):
(WebCore::ShadowTree::willRemove):

05:26 Changeset [110373] by commit-queue@webkit.org
  • 6 edits
    1 delete in trunk/Source

Unreviewed, rolling out r110363.
http://trac.webkit.org/changeset/110363
https://bugs.webkit.org/show_bug.cgi?id=80757

link error in chromium: unresolved external symbol
webkit_support::CreateScopedTempDirectory(void) (Requested by
ukai_home on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-10

Source/WebCore:

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::open):

  • platform/leveldb/LevelDBDatabase.cpp:
  • platform/leveldb/LevelDBDatabase.h:

(LevelDBDatabase):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/LevelDBTest.cpp: Removed.
02:27 Changeset [110372] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r110353.
http://trac.webkit.org/changeset/110353
https://bugs.webkit.org/show_bug.cgi?id=80752

copmile failed on Chromium (Requested by ukai_home on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-10

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore::LayerChromiumWithForcedDrawsContent::LayerChromiumWithForcedDrawsContent):
(WebCore::LayerChromiumWithForcedDrawsContent::opaqueContentsRegion):
(WebCore::LayerChromiumWithForcedDrawsContent::setOpaquePaintRect):
(LayerChromiumWithForcedDrawsContent):
(WebCore::setLayerPropertiesForTesting):
(WebCore):
(WebCore::TestCCOcclusionTracker::TestCCOcclusionTracker):
(WebCore::TestCCOcclusionTracker::occlusionInScreenSpace):
(WebCore::TestCCOcclusionTracker::occlusionInTargetSurface):
(WebCore::TestCCOcclusionTracker::setOcclusionInScreenSpace):
(WebCore::TestCCOcclusionTracker::setOcclusionInTargetSurface):
(WebCore::TestCCOcclusionTracker::layerScissorRectInTargetSurface):
(WebCore::TestDamageClient::damageRect):
(WebCore::layerAddedToOccludedRegion):
(WebCore::layerAddedToOccludedRegionWithRotation):
(WebCore::layerAddedToOccludedRegionWithTranslation):
(WebCore::layerAddedToOccludedRegionWithRotatedSurface):
(WebCore::layerAddedToOccludedRegionWithSurfaceAlreadyOnStack):
(WebCore::layerAddedToOccludedRegionWithRotatedOffAxisSurface):
(WebCore::layerAddedToOccludedRegionWithMultipleOpaqueLayers):
(WebCore::surfaceOcclusionWithOverlappingSiblingSurfaces):
(WebCore::surfaceOcclusionInScreenSpace):
(WebCore::surfaceOcclusionInScreenSpaceDifferentTransforms):
(WebCore::occlusionInteractionWithFilters):
(WebCore::layerScissorRectOverTile):
(WebCore::screenScissorRectOverTile):
(WebCore::layerScissorRectOverCulledTile):
(WebCore::screenScissorRectOverCulledTile):
(WebCore::layerScissorRectOverPartialTiles):
(WebCore::screenScissorRectOverPartialTiles):
(WebCore::layerScissorRectOverNoTiles):
(WebCore::screenScissorRectOverNoTiles):
(WebCore::layerScissorRectForLayerOffOrigin):
(WebCore::damageRectOverTile):
(WebCore::damageRectOverCulledTile):
(WebCore::damageRectOverPartialTiles):
(WebCore::damageRectOverNoTiles):
(WebCore::TEST):

03/09/12:

21:45 Changeset [110371] by commit-queue@webkit.org
  • 15 edits in trunk

Source/WebCore: Handle more Gesture* events by performing scrolls on the correct target ScrollableArea
https://bugs.webkit.org/show_bug.cgi?id=80311

Implement GestureScroll* events via re-use of WheelEvent dispatch.

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-09
Reviewed by James Robinson.

Layout tests previously submited as https://bugs.webkit.org/show_bug.cgi?id=80201 and unit
test added as part of this patch.

  • page/EventHandler.cpp:

(WebCore::wheelGranularityToScrollGranularity): Refactoring.
(WebCore):
(WebCore::scrollNode):
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::defaultWheelEventHandler):
(WebCore::EventHandler::handleGestureEvent): Added GestureScrollBegin & End.
(WebCore::EventHandler::handleGestureTap):
(WebCore::EventHandler::handleGestureScrollUpdate):
(WebCore::EventHandler::handleGestureScrollCore): Refactoring.

  • page/EventHandler.h:

(EventHandler):

  • platform/PlatformWheelEvent.h: Added additional scroll type.
  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::handleWheelEvent): Forward additional scroll type.

  • platform/ScrollAnimator.h:

(WebCore):

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::ScrollAnimatorNone): Handle additional scroll type.
(WebCore::ScrollAnimatorNone::fireUpAnAnimation):
(WebCore):
(WebCore::ScrollAnimatorNone::scroll):

  • platform/ScrollAnimatorNone.h:

(ScrollAnimatorNone):

  • platform/ScrollTypes.h: Added an additional scroll type.
  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::scroll):

Source/WebKit/chromium: Handle more Gesture* events by performing scrolls on the correct target ScrollableArea
https://bugs.webkit.org/show_bug.cgi?id=80311

Added a unit test for the changes to ScrollAnimatorNone to make sure that the two-call
transport of fling parameters is correctly delivered.

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-09
Reviewed by James Robinson.

  • tests/ScrollAnimatorNoneTest.cpp:

(MockScrollAnimatorNone):
(MockScrollAnimatorNone::reset):
(MockScrollAnimatorNone::fireUpAnAnimation):
(TEST):

LayoutTests: Handle more Gesture* events by performing scrolls on the correct target ScrollableArea
https://bugs.webkit.org/show_bug.cgi?id=80311

Rebaselined to reflect corrected behaviour of gesture events targeting a div removed
from the DOM during dispatch.

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-09
Reviewed by James Robinson.

  • fast/events/touch/gesture/touch-gesture-scroll-shy-target.html:
  • platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-shy-target-expected.txt:
21:40 Changeset [110370] by mrowe@apple.com
  • 2 edits in tags/Safari-536.2.3/Source/WebKit2

Merge r110303.

21:04 Changeset [110369] by arv@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Fix a fixme in v8 bindings
https://bugs.webkit.org/show_bug.cgi?id=80734

Reviewed by Kentaro Hara.

No new tests. Covered by existing tests.

  • bindings/v8/V8Binding.cpp:

(WebCore::toInt32):
(WebCore::toUInt32):

20:50 Changeset [110368] by ostapenko.viatcheslav@nokia.com
  • 4 edits in trunk/Source/WebKit2

[Qt] [WK2] Shouldn't use item for clipping rect calculation in paint node.
https://bugs.webkit.org/show_bug.cgi?id=80714

Reviewed by Noam Rosenthal.

Replace item based clip-rect calculation with clipping-nodes based calculation.
This is required for threaded rendering, since we don't have access to the QSGItems
from the render thread.

  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPage::QQuickWebPage):
(QQuickWebPagePrivate::paintToCurrentGLContext):
(PageProxyNode::render):
(PageProxyNode::clipRect):
(PageProxyNode):

  • UIProcess/API/qt/qquickwebpage_p_p.h:

(QQuickWebPagePrivate):

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebView::QQuickWebView):

20:35 Changeset [110367] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] WebCore/Target.pri contains obsolete FileStreamProxy.h reference.
https://bugs.webkit.org/show_bug.cgi?id=80730

Patch by Lauro Neto <lauro.neto@openbossa.org> on 2012-03-09
Reviewed by Tor Arne Vestbø.

Build fix. Target.pri was still including old FileStreamProxy.h.

  • Target.pri:
19:53 Changeset [110366] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Pan scroll icon is painted at incorrect coordinates in frames
https://bugs.webkit.org/show_bug.cgi?id=79378

Convert client coordinates to parent ScrollView coordinates

Patch by Cem Kocagil <cem.kocagil@gmail.com> on 2012-03-05
Reviewed by Antonio Gomes

  • platform/ScrollView.cpp:

(WebCore::ScrollView::paintPanScrollIcon):

19:19 Changeset [110365] by ojan@chromium.org
  • 244 edits
    154 copies
    69 moves
    100 adds
    2 deletes in trunk/LayoutTests

Chromium-Lion rebaselines. Getting close to done. :(

19:11 Changeset [110364] by jamesr@google.com
  • 7 edits in trunk

[chromium] Deprecate renderDirectlyToWebView parameter of WebViewClient::createGraphicsContext3D()
https://bugs.webkit.org/show_bug.cgi?id=80523

Reviewed by Darin Fisher.

Source/WebKit/chromium:

  • public/WebViewClient.h:

(WebViewClient):
(WebKit::WebViewClient::createGraphicsContext3D):

  • public/platform/WebKitPlatformSupport.h:

(WebKit):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::createCompositorGraphicsContext3D):

Tools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createGraphicsContext3D):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

19:10 Changeset [110363] by jsbell@chromium.org
  • 6 edits
    1 add in trunk/Source

IndexedDB: Handle LevelDB database corruption
https://bugs.webkit.org/show_bug.cgi?id=79413

Source/WebCore:

Add LevelDBDatabase::destroy() method so that clients can retry if open() fails.

Reviewed by Tony Chang.

Test: webkit_unit_tests --gtest_filter='LevelDBDatabaseTest.CorruptionTest'

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp: Implement open/destroy/open strategy.

(WebCore::IDBLevelDBBackingStore::open):

  • platform/leveldb/LevelDBDatabase.cpp:

(WebCore::LevelDBDatabase::destroy):
(WebCore):

  • platform/leveldb/LevelDBDatabase.h:

(LevelDBDatabase):

Source/WebKit/chromium:

Reviewed by Tony Chang.

  • WebKit.gypi:
  • tests/LevelDBTest.cpp: Added.

(WebCore):
(SimpleComparator):
(WebCore::SimpleComparator::compare):
(WebCore::SimpleComparator::name):
(WebCore::encodeString):
(WebCore::TEST):

18:58 Changeset [110362] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix one of the Windows build warnings.

  • html/track/TextTrackCueList.idl:

Add a newline to the end of the file.

18:55 Changeset [110361] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

BlackBerry PlayBook doesn't sniff mime types
https://bugs.webkit.org/show_bug.cgi?id=73869

Patch by Tyler Abbott <tabbott@rim.com> on 2012-03-09
Reviewed by Rob Buis.

Hook up MIMESniffing for BlackBerry. Override Content-Types will
not be overriden. File extensions will be trusted when content
is loaded from disk.

No tests, BlackBerry tests are not yet present in webkit.org codebase.

  • PlatformBlackBerry.cmake:
  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::NetworkJob):
(WebCore::NetworkJob::initialize):
(WebCore::NetworkJob::handleNotifyDataReceived):
(WebCore::NetworkJob::sendResponseIfNeeded):

  • platform/network/blackberry/NetworkJob.h:

(NetworkJob):

18:53 Changeset [110360] by enrica@apple.com
  • 16 edits
    2 adds in trunk/Source

Move WebNSURLExtras code down to WebCore.
https://bugs.webkit.org/show_bug.cgi?id=80611

Reviewed by Alexey Proskuryakov.

Source/WebCore:

  • WebCore.exp.in: Added new exported functions.
  • WebCore.xcodeproj/project.pbxproj: Added WebCoreNSURLExtras.*
  • platform/FileSystem.h: Added setMetadataURL.
  • platform/mac/FileSystemMac.mm:

(WebCore::setMetaData): Added.
(WebCore::setMetadataURL): Added.

  • platform/mac/WebCoreNSStringExtras.h:
  • platform/mac/WebCoreNSStringExtras.mm:

(hasCaseInsensitivePrefix): Added.

  • platform/mac/WebCoreNSURLExtras.h: Added.
  • platform/mac/WebCoreNSURLExtras.mm: Added.
  • platform/mac/WebCoreObjCExtras.h:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

Changed the implementation to use newly moved WebCore functions.

  • Misc/WebKitNSStringExtras.mm:

(-[NSString _webkit_hasCaseInsensitivePrefix:]):

  • Misc/WebNSURLExtras.mm:

(+[NSURL _web_URLWithUserTypedString:]):
(+[NSURL _web_URLWithDataAsString:relativeToURL:]):
(+[NSURL _web_URLWithData:]):
(+[NSURL _web_URLWithData:relativeToURL:]):
(-[NSURL _web_originalData]):
(-[NSURL _web_originalDataAsString]):
(-[NSURL _web_userVisibleString]):
(-[NSURL _web_isEmpty]):
(-[NSURL _web_URLCString]):
(-[NSURL _web_URLByTruncatingOneCharacterBeforeComponent:]):
(-[NSURL _webkit_URLByRemovingFragment]):
(-[NSURL _webkit_URLByRemovingResourceSpecifier]):
(-[NSURL _web_URLByRemovingUserInfo]):
(-[NSURL _web_dataForURLComponentType:]):
(-[NSURL _web_schemeData]):
(-[NSURL _web_hostData]):
(-[NSString _web_isUserVisibleURL]):
(-[NSString _web_hostNameNeedsDecodingWithRange:]):
(-[NSString _web_hostNameNeedsEncodingWithRange:]):
(-[NSString _web_decodeHostNameWithRange:]):
(-[NSString _web_encodeHostNameWithRange:]):
(-[NSString _web_decodeHostName]):
(-[NSString _web_encodeHostName]):

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

18:40 Changeset [110359] by commit-queue@webkit.org
  • 8 edits in trunk/Source

[chromium] Increase size of Combo Box Options for touch and high DPI devices
https://bugs.webkit.org/show_bug.cgi?id=80027

Patch by Tim Dresser <tdresser@chromium.org> on 2012-03-09
Reviewed by Darin Fisher.

Source/WebCore:

Scale Combo box popups by defaultDeviceScaleFactor, and add padding to
<option> elements when touch is enabled.

Manually tested with --default-device-scale-factor=1,2 and unset.
Each of these were tested with RuntimeEnabledFeatures::touchEnabled
set to true and false.

  • platform/chromium/PopupListBox.cpp:

(WebCore::PopupListBox::paint):
(WebCore::PopupListBox::paintRow):
(WebCore::PopupListBox::getRowHeight):

  • platform/chromium/PopupListBox.h:

(PopupContainerSettings):

  • platform/chromium/PopupMenuChromium.cpp:

(WebCore):
(WebCore::PopupMenuChromium::show):

  • platform/chromium/PopupMenuChromium.h:

(WebCore::PopupMenuChromium::optionPaddingForTouch):
(WebCore::PopupMenuChromium::setOptionPaddingForTouch):
(PopupMenuChromium):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::showPopup):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::gestureEvent):
(WebKit::WebViewImpl::applyAutofillSuggestions):

18:22 Changeset [110358] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebCore

Improve ContainerNode collectNode() performance by reserving vector
capacity up front.
https://bugs.webkit.org/show_bug.cgi?id=80706

Reviewed by Ryosuke Niwa.

Covered by existing tests. Performance will be evaluated based on
Chromium's page_cycler_bloat-http, page_cycler_intl1, and
dromaeo_domcore suites.

  • dom/ContainerNode.cpp:

(WebCore::collectNodes):

18:11 Changeset [110357] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Roll chromium DEPS to r125600
https://bugs.webkit.org/show_bug.cgi?id=80722

Unreviewed

Patch by James Robinson <jamesr@chromium.org> on 2012-03-09

  • DEPS:
18:09 Changeset [110356] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/11018851> Crash in DisplayRefreshMonitor::notifyClients()
https://bugs.webkit.org/show_bug.cgi?id=80740

Reviewed by Sam Weinig.

No test, since this race condition cannot be reproduced reliably.

  • platform/graphics/mac/DisplayRefreshMonitorMac.cpp:

(WebCore::DisplayRefreshMonitor::~DisplayRefreshMonitor): Changed to stop the display link
first, then cancel any outstanding calls to refreshDisplayOnMainThread(). When doing things
the other way around, the display link can fire after outstanding calls have been canceled,
and enqueue new calls on the main thread, which will be dispatched after monitor destruction.

18:04 Changeset [110355] by jeffm@apple.com
  • 3 edits in trunk/Source/WebKit2

Add WKPageEndPrinting() to balance WKPageBeginPrinting()
https://bugs.webkit.org/show_bug.cgi?id=80739

Reviewed by Dan Bernstein.

  • UIProcess/API/C/WKPage.cpp:

(WKPageEndPrinting): Added.

  • UIProcess/API/C/WKPagePrivate.h: Added WKPageEndPrinting().
18:02 Changeset [110354] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Update baseline after http://trac.webkit.org/changeset/110352 to show
the new passing subtest.

  • platform/chromium/fast/js/array-prototype-properties-expected.txt:
17:24 Changeset [110353] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Clean up culling tests and templatize to test impl constructs
https://bugs.webkit.org/show_bug.cgi?id=80613

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-09
Reviewed by Adrienne Walker.

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore::TestContentLayerChromium::TestContentLayerChromium):
(WebCore::TestContentLayerChromium::opaqueContentsRegion):
(WebCore::TestContentLayerChromium::setOpaqueContentsRect):
(TestContentLayerChromium):
(TestContentLayerImpl):
(WebCore::TestContentLayerImpl::TestContentLayerImpl):
(WebCore::TestContentLayerImpl::opaqueContentsRegion):
(WebCore::TestContentLayerImpl::setOpaqueContentsRect):
(WebCore):
(WebCore::TestCCOcclusionTrackerBase::TestCCOcclusionTrackerBase):
(WebCore::TestCCOcclusionTrackerBase::occlusionInScreenSpace):
(WebCore::TestCCOcclusionTrackerBase::occlusionInTargetSurface):
(WebCore::TestCCOcclusionTrackerBase::setOcclusionInScreenSpace):
(WebCore::TestCCOcclusionTrackerBase::setOcclusionInTargetSurface):
(WebCore::TestCCOcclusionTrackerBase::layerScissorRectInTargetSurface):
(WebCore::TestDamageClient::damageRect):
(CCOcclusionTrackerTestMainThreadTypes):
(WebCore::CCOcclusionTrackerTestMainThreadTypes::createLayer):
(WebCore::CCOcclusionTrackerTestMainThreadTypes::createContentLayer):
(CCOcclusionTrackerTestImplThreadTypes):
(WebCore::CCOcclusionTrackerTestImplThreadTypes::createLayer):
(WebCore::CCOcclusionTrackerTestImplThreadTypes::createContentLayer):
(CCOcclusionTrackerTest):
(WebCore::CCOcclusionTrackerTest::TearDown):
(WebCore::CCOcclusionTrackerTest::createRoot):
(WebCore::CCOcclusionTrackerTest::createLayer):
(WebCore::CCOcclusionTrackerTest::createSurface):
(WebCore::CCOcclusionTrackerTest::createDrawingLayer):
(WebCore::CCOcclusionTrackerTest::createDrawingSurface):
(WebCore::CCOcclusionTrackerTest::calcDrawEtc):
(WebCore::CCOcclusionTrackerTest::setBaseProperties):
(WebCore::CCOcclusionTrackerTest::setProperties):
(CCOcclusionTrackerTestIdentityTransforms):
(WebCore::CCOcclusionTrackerTestIdentityTransforms::runMyTest):
(CCOcclusionTrackerTestRotatedChild):
(WebCore::CCOcclusionTrackerTestRotatedChild::runMyTest):
(CCOcclusionTrackerTestTranslatedChild):
(WebCore::CCOcclusionTrackerTestTranslatedChild::runMyTest):
(CCOcclusionTrackerTestChildInRotatedChild):
(WebCore::CCOcclusionTrackerTestChildInRotatedChild::runMyTest):
(CCOcclusionTrackerTestVisitTargetTwoTimes):
(WebCore::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest):
(CCOcclusionTrackerTestSurfaceRotatedOffAxis):
(WebCore::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest):
(CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren):
(WebCore::CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren::runMyTest):
(CCOcclusionTrackerTestOverlappingSurfaceSiblings):
(WebCore::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
(CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms):
(WebCore::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
(CCOcclusionTrackerTestFilters):
(WebCore::CCOcclusionTrackerTestFilters::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectOutsideChild):
(WebCore::CCOcclusionTrackerTestLayerScissorRectOutsideChild::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectOutsideChild):
(WebCore::CCOcclusionTrackerTestScreenScissorRectOutsideChild::runMyTest):
(CCOcclusionTrackerTestDamageRectOutsideChild):
(WebCore::CCOcclusionTrackerTestDamageRectOutsideChild::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectOverChild):
(WebCore::CCOcclusionTrackerTestLayerScissorRectOverChild::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectOverChild):
(WebCore::CCOcclusionTrackerTestScreenScissorRectOverChild::runMyTest):
(CCOcclusionTrackerTestDamageRectOverChild):
(WebCore::CCOcclusionTrackerTestDamageRectOverChild::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectPartlyOverChild):
(WebCore::CCOcclusionTrackerTestLayerScissorRectPartlyOverChild::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectPartlyOverChild):
(WebCore::CCOcclusionTrackerTestScreenScissorRectPartlyOverChild::runMyTest):
(CCOcclusionTrackerTestDamageRectPartlyOverChild):
(WebCore::CCOcclusionTrackerTestDamageRectPartlyOverChild::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectOverNothing):
(WebCore::CCOcclusionTrackerTestLayerScissorRectOverNothing::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectOverNothing):
(WebCore::CCOcclusionTrackerTestScreenScissorRectOverNothing::runMyTest):
(CCOcclusionTrackerTestDamageRectOverNothing):
(WebCore::CCOcclusionTrackerTestDamageRectOverNothing::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectForLayerOffOrigin):
(WebCore::CCOcclusionTrackerTestLayerScissorRectForLayerOffOrigin::runMyTest):
(CCOcclusionTrackerTestOpaqueContentsRegionEmpty):
(WebCore::CCOcclusionTrackerTestOpaqueContentsRegionEmpty::runMyTest):
(CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty):
(WebCore::CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty::runMyTest):

17:20 Changeset [110352] by barraclough@apple.com
  • 5 edits in trunk

Array.prototype.toLocaleString visits elements in wrong order under certain conditions
https://bugs.webkit.org/show_bug.cgi?id=80663

Reviewed by Michael Saboff.

The bug here is actually that we're continuing to process the array after an exception
has been thrown, and that the second value throw is overriding the first.

Source/JavaScriptCore:

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToLocaleString):

LayoutTests:

  • fast/js/array-prototype-properties-expected.txt:
  • fast/js/script-tests/array-prototype-properties.js:
17:03 Changeset [110351] by eric@webkit.org
  • 2 edits in trunk/Tools

build-webkit should build Source/WTF on Mac
https://bugs.webkit.org/show_bug.cgi?id=80728

Reviewed by Adam Barth.

We'll add other ports to this list in future commits.

  • Scripts/build-webkit:
17:01 Changeset [110350] by ojan@chromium.org
  • 204 edits
    135 copies
    111 moves
    66 adds in trunk/LayoutTests

So many Chromium-Lion rebaselines. :(

16:44 Changeset [110349] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

Assertion failure in ResourceHandle::setDefersLoading(): d->m_defersLoading != defers
https://bugs.webkit.org/show_bug.cgi?id=80543

Reviewed by Geoffrey Garen.

Reset m_defersLoading flag to the value from Page::defersCallbacks() in
ResourceLoader::init(). This is because the resource could have been in the pending requests
queue in ResourceLoadScheduler and would have missed out on state changes to this flag
happening from DocumentLoader::setDefersCallbacks().

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::init):

16:36 Changeset [110348] by eae@chromium.org
  • 13 edits in trunk/Source

Add roundedPoint to HitTestResult and change platform code to use it
https://bugs.webkit.org/show_bug.cgi?id=80715

Reviewed by James Robinson.

Change ports to use roundedPoint to avoid exposing subpixel types to
platform code.

Source/WebCore:

No new tests.

  • rendering/HitTestResult.h:

(WebCore::HitTestResult::roundedPoint):

Source/WebKit/chromium:

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::mouseDidMoveOverElement):

  • src/ContextMenuClientImpl.cpp:

(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

Source/WebKit/mac:

  • WebCoreSupport/WebContextMenuClient.mm:

(WebContextMenuClient::showContextMenu):

Source/WebKit/qt:

  • Api/qwebframe.cpp:

(QWebHitTestResultPrivate::QWebHitTestResultPrivate):

Source/WebKit/win:

  • WebView.cpp:

(WebView::handleContextMenuEvent):

Source/WebKit2:

  • WebProcess/WebPage/WebContextMenu.cpp:

(WebKit::WebContextMenu::show):

16:13 Changeset [110347] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[V8][Performance] Inline hot methods in V8Bindings.h
https://bugs.webkit.org/show_bug.cgi?id=80685

Reviewed by Adam Barth.

This patch slightly improves DOM binding performance by inlining hot
methods in V8Binding.cpp, e.g. isUndefinedOrNull(), v8StringOrNull(), v8Boolean().
For example, this patch improves div.nodeName by 5.0%, and div.nodeValue by 4.1%.

Performance tests: https://bugs.webkit.org/attachment.cgi?id=131006

The performance test results in my Mac environment are as follows:

Chromium/V8 without this patch:
div.nodeName : 3417.4 ms
div.nodeValue : 2069.6 ms

Chromium/V8 with this patch:
div.nodeName : 3245.6 ms
div.nodeValue : 1983.1 ms

No tests. No change in behavior.

  • bindings/v8/V8Binding.cpp:
  • bindings/v8/V8Binding.h:

(WebCore::toWebCoreString):
(WebCore::isUndefinedOrNull):
(WebCore::isHostObject):
(WebCore::v8Boolean):
(WebCore::toWebCoreStringWithNullCheck):
(WebCore::toAtomicWebCoreStringWithNullCheck):
(WebCore::toWebCoreStringWithNullOrUndefinedCheck):
(WebCore::v8UndetectableString):
(WebCore::v8StringOrNull):
(WebCore::v8StringOrUndefined):
(WebCore::v8StringOrFalse):
(WebCore::toWebCoreDate):
(WebCore::v8DateOrNull):

15:49 Changeset [110346] by ap@apple.com
  • 3 edits
    2 moves in trunk/Source/WebKit2

[Mac] Pass sandbox profiles through preprocessor
https://bugs.webkit.org/show_bug.cgi?id=80651

Reviewed by Mark Rowe.

  • DerivedSources.make: Preprocess sandbox profiles.
  • PluginProcess/mac/com.apple.WebKit.PluginProcess.sb: Removed.
  • PluginProcess/mac/com.apple.WebKit.PluginProcess.sb.in: Copied from Source/WebKit2/PluginProcess/mac/com.apple.WebKit.PluginProcess.sb.
  • WebProcess/com.apple.WebProcess.sb: Removed.
  • WebProcess/com.apple.WebProcess.sb.in: Copied from Source/WebKit2/WebProcess/com.apple.WebProcess.sb. Renamed to avoid make finding the wrong original in default paths.
  • WebKit2.xcodeproj/project.pbxproj: Copy preprocessed files to Resources, not originals. Also, changed DerivedSources target to use BaseTarget.xcconfig to have correct include paths.
15:45 Changeset [110345] by arv@chromium.org
  • 1 edit
    1 move in trunk/LayoutTests

Rebaseline inspector/debugger/debugger-scripts.html

[chromium] Unreviewed gardening.

  • platform/chromium-win/inspector/debugger/debugger-scripts-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/debugger/debugger-scripts-expected.txt.
15:34 Changeset [110344] by wjmaclean@chromium.org
  • 4 edits
    12 adds in trunk/Source

[chromium] Implement scroll physics architecture for impl/main thread
https://bugs.webkit.org/show_bug.cgi?id=79827

Reviewed by James Robinson.

Source/WebCore:

Unittests added, plus follow-on patch from rjkroege will add layout tests.

PlatformGestureCurve is a framework to separate the physical simulation from for gesture
animation from control concerns. This allows the physics to be reused in alternate places.
At present, the framework will be applied in ScrollAnimatorNone and the Chrome Compositor.

  • WebCore.gypi:
  • platform/ActivePlatformGestureAnimation.cpp: Added.

(WebCore):
(WebCore::ActivePlatformGestureAnimation::create):
(WebCore::ActivePlatformGestureAnimation::~ActivePlatformGestureAnimation):
(WebCore::ActivePlatformGestureAnimation::ActivePlatformGestureAnimation):
(WebCore::ActivePlatformGestureAnimation::animate):

  • platform/ActivePlatformGestureAnimation.h: Added.

(WebCore):
(ActivePlatformGestureAnimation):

  • platform/PlatformGestureCurve.h: Added.

(WebCore):
(PlatformGestureCurve):
(WebCore::PlatformGestureCurve::~PlatformGestureCurve):

  • platform/PlatformGestureCurveTarget.h: Added.

(WebCore):
(PlatformGestureCurveTarget):
(WebCore::PlatformGestureCurveTarget::~PlatformGestureCurveTarget):

  • platform/TouchFlingPlatformGestureCurve.cpp: Added.

(WebCore):
(WebCore::TouchFlingPlatformGestureCurve::create):
(WebCore::TouchFlingPlatformGestureCurve::TouchFlingPlatformGestureCurve):
(WebCore::TouchFlingPlatformGestureCurve::~TouchFlingPlatformGestureCurve):
(WebCore::TouchFlingPlatformGestureCurve::apply):

  • platform/TouchFlingPlatformGestureCurve.h: Added.

(WebCore):
(TouchFlingPlatformGestureCurve):

  • platform/WheelFlingPlatformGestureCurve.cpp: Added.

(WebCore):
(WebCore::WheelFlingPlatformGestureCurve::create):
(WebCore::WheelFlingPlatformGestureCurve::WheelFlingPlatformGestureCurve):
(WebCore::WheelFlingPlatformGestureCurve::~WheelFlingPlatformGestureCurve):
(WebCore::WheelFlingPlatformGestureCurve::apply):

  • platform/WheelFlingPlatformGestureCurve.h: Added.

(WebCore):
(WheelFlingPlatformGestureCurve):

  • platform/graphics/chromium/cc/CCActiveGestureAnimation.cpp: Added.

(WebCore):
(WebCore::CCActiveGestureAnimation::create):
(WebCore::CCActiveGestureAnimation::CCActiveGestureAnimation):
(WebCore::CCActiveGestureAnimation::~CCActiveGestureAnimation):
(WebCore::CCActiveGestureAnimation::animate):

  • platform/graphics/chromium/cc/CCActiveGestureAnimation.h: Added.

(WebCore):
(CCActiveGestureAnimation):

  • platform/graphics/chromium/cc/CCGestureCurve.h: Added.

(WebCore):
(CCGestureCurveTarget):
(WebCore::CCGestureCurveTarget::~CCGestureCurveTarget):
(CCGestureCurve):
(WebCore::CCGestureCurve::~CCGestureCurve):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/PlatformGestureCurveTest.cpp: Added.
15:27 Changeset [110343] by ojan@chromium.org
  • 103 edits
    76 copies
    134 moves
    177 adds
    16 deletes in trunk/LayoutTests

More Chromium-Lion rebaselines.

15:25 Changeset [110342] by rniwa@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

WebKit compiled by gcc (Xcode 3.2.6) hangs while running DOM/Accessors.html
https://bugs.webkit.org/show_bug.cgi?id=80080

Reviewed by Filip Pizlo.

  • bytecode/SamplingTool.cpp:

(JSC::SamplingRegion::Locker::Locker):
(JSC::SamplingRegion::Locker::~Locker):

  • bytecode/SamplingTool.h:

(JSC::SamplingRegion::exchangeCurrent):

  • wtf/Atomics.h:

(WTF):
(WTF::weakCompareAndSwap):
(WTF::weakCompareAndSwapUIntPtr):

15:25 Changeset [110341] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderListBox.cpp

Fixing a paint at a non-rounded LayoutPoint.

15:11 Changeset [110340] by alexis.menard@openbossa.org
  • 7 edits
    2 adds in trunk

Implement selectedOptions attribute of <select>.
https://bugs.webkit.org/show_bug.cgi?id=80631

Reviewed by Benjamin Poulain.

Source/WebCore:

Add a new collection as a member of HTMLSelectElement which is
used to store the selected elements. Extend HTMLCollection to
support the new collection type needed by this feature.

Reference : http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#dom-select-selectedoptions

Test: fast/dom/select-selectedOptions.html

  • html/CollectionType.h:
  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::shouldIncludeChildren):
(WebCore::HTMLCollection::isAcceptableElement):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::selectedOptions):
(WebCore):

  • html/HTMLSelectElement.h:

(HTMLSelectElement):

  • html/HTMLSelectElement.idl:

LayoutTests:

New tests to cover the feature.

  • fast/dom/select-selectedOptions-expected.txt: Added.
  • fast/dom/select-selectedOptions.html: Added.
15:06 Changeset [110339] by leviw@chromium.org
  • 5 edits in branches/subpixellayout/Source/WebCore

Fixing integer truncation issue around contentWidth/Height, a duplicated FractionalLayoutSize.cpp reference in cmake, and unnecessary layout units in RenderEmbeddedObject.

15:04 Changeset [110338] by jamesr@google.com
  • 11 edits
    5 adds in trunk/Source

[chromium] ScrollbarLayerChromium/CCScrollbarLayerImpl for CC-side scrollbar painting
https://bugs.webkit.org/show_bug.cgi?id=78872

Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-03-09
Reviewed by James Robinson.

Source/WebCore:

New test ScrollbarLayerChromiumTest.resolveScrollLayerPointer

  • WebCore.gypi:
  • page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::scrollLayerForFrameView):
(WebCore::scrollbarLayerDidChange):
(WebCore):
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::invalidateScrollbar):

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(WebCore::GraphicsLayerChromium::hasContentsLayer):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore):
(WebCore::LayerChromium::toScrollbarLayerChromium):
(LayerChromium):

  • platform/graphics/chromium/ScrollbarLayerChromium.cpp: Added.

(WebCore):
(WebCore::ScrollbarLayerChromium::createCCLayerImpl):
(WebCore::ScrollbarLayerChromium::create):
(WebCore::ScrollbarLayerChromium::ScrollbarLayerChromium):
(WebCore::ScrollbarLayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/ScrollbarLayerChromium.h: Added.

(WebCore):
(ScrollbarLayerChromium):
(WebCore::ScrollbarLayerChromium::scrollLayerId):
(WebCore::ScrollbarLayerChromium::toScrollbarLayerChromium):

  • platform/graphics/chromium/TreeSynchronizer.cpp:

(WebCore::TreeSynchronizer::synchronizeTrees):
(WebCore::TreeSynchronizer::collectExistingCCLayerImplRecursive):
(WebCore::TreeSynchronizer::reuseOrCreateCCLayerImpl):
(WebCore::TreeSynchronizer::synchronizeTreeRecursive):
(WebCore::TreeSynchronizer::updateScrollbarLayerPointersRecursive):
(WebCore):

  • platform/graphics/chromium/TreeSynchronizer.h:

(TreeSynchronizer):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::updateMaxScrollPosition):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp: Added.

(WebCore):
(WebCore::CCScrollbarLayerImpl::create):
(WebCore::CCScrollbarLayerImpl::CCScrollbarLayerImpl):
(WebCore::CCScrollbarLayerImpl::willDraw):
(WebCore::CCScrollbarLayerImpl::appendQuads):
(WebCore::CCScrollbarLayerImpl::didDraw):
(WebCore::CCScrollbarLayerImpl::paint):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::x):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::y):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::width):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::height):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::size):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::location):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::parent):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::root):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::setFrameRect):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::frameRect):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::invalidate):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::invalidateRect):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::scrollbarOverlayStyle):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::getTickmarks):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::isScrollableAreaActive):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::isScrollViewScrollbar):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::convertFromContainingWindow):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::isCustomScrollbar):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::orientation):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::value):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::currentPos):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::visibleSize):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::totalSize):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::maximum):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::controlSize):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::lineStep):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::pageStep):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::pressedPart):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::hoveredPart):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::styleChanged):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::enabled):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::setEnabled):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.h: Added.

(WebCore):
(CCScrollbarLayerImpl):
(WebCore::CCScrollbarLayerImpl::setScrollbarOverlayStyle):
(WebCore::CCScrollbarLayerImpl::setTickmarks):
(WebCore::CCScrollbarLayerImpl::setIsScrollableAreaActive):
(WebCore::CCScrollbarLayerImpl::setIsScrollViewScrollbar):
(WebCore::CCScrollbarLayerImpl::setOrientation):
(WebCore::CCScrollbarLayerImpl::setControlSize):
(WebCore::CCScrollbarLayerImpl::setPressedPart):
(WebCore::CCScrollbarLayerImpl::setHoveredPart):
(WebCore::CCScrollbarLayerImpl::setEnabled):
(WebCore::CCScrollbarLayerImpl::scrollLayer):
(WebCore::CCScrollbarLayerImpl::setScrollLayer):
(CCScrollbar):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::CCScrollbar):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/ScrollbarLayerChromiumTest.cpp: Added.

(WebCore):
(MockScrollbar):
(WebCore::MockScrollbar::x):
(WebCore::MockScrollbar::y):
(WebCore::MockScrollbar::width):
(WebCore::MockScrollbar::height):
(WebCore::MockScrollbar::size):
(WebCore::MockScrollbar::location):
(WebCore::MockScrollbar::parent):
(WebCore::MockScrollbar::root):
(WebCore::MockScrollbar::setFrameRect):
(WebCore::MockScrollbar::frameRect):
(WebCore::MockScrollbar::invalidate):
(WebCore::MockScrollbar::invalidateRect):
(WebCore::MockScrollbar::scrollbarOverlayStyle):
(WebCore::MockScrollbar::getTickmarks):
(WebCore::MockScrollbar::isScrollableAreaActive):
(WebCore::MockScrollbar::isScrollViewScrollbar):
(WebCore::MockScrollbar::convertFromContainingWindow):
(WebCore::MockScrollbar::isCustomScrollbar):
(WebCore::MockScrollbar::orientation):
(WebCore::MockScrollbar::value):
(WebCore::MockScrollbar::currentPos):
(WebCore::MockScrollbar::visibleSize):
(WebCore::MockScrollbar::totalSize):
(WebCore::MockScrollbar::maximum):
(WebCore::MockScrollbar::controlSize):
(WebCore::MockScrollbar::lineStep):
(WebCore::MockScrollbar::pageStep):
(WebCore::MockScrollbar::pressedPart):
(WebCore::MockScrollbar::hoveredPart):
(WebCore::MockScrollbar::styleChanged):
(WebCore::MockScrollbar::enabled):
(WebCore::MockScrollbar::setEnabled):
(WebCore::MockScrollbar::MockScrollbar):
(WebCore::MockScrollbar::~MockScrollbar):
(WebCore::TEST):

15:03 Changeset [110337] by mrowe@apple.com
  • 4 edits in tags/Safari-536.2.3/Source

Versioning.

14:58 Changeset [110336] by jchaffraix@webkit.org
  • 3 edits in trunk/Source/WebCore

Split the extra logical height distribution logic out of RenderTableSection::layoutRows
https://bugs.webkit.org/show_bug.cgi?id=80671

Reviewed by Adrienne Walker.

Refactoring only, no change in behavior expected.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):
Split the logic from here...

(WebCore::RenderTableSection::distributeExtraLogicalHeightToPercentRows):
(WebCore::RenderTableSection::distributeExtraLogicalHeightToAutoRows):
(WebCore::RenderTableSection::distributeRemainingExtraLogicalHeight):
(WebCore::RenderTableSection::distributeExtraLogicalHeightToRows):
... to those functions. Cleaned up the variable naming while at it and
made them follow the same signature as this may be useful to fix another
bug I have.

  • rendering/RenderTableSection.h:

(RenderTableSection):
Added the previous 4 new functions.

14:53 Changeset [110335] by mrowe@apple.com
  • 1 copy in tags/Safari-536.2.3

New tag.

14:52 Changeset [110334] by rwlbuis@webkit.org
  • 2 edits
    1 delete in trunk/Source/WebCore

Remove unused file FrameBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=80731

Reviewed by Antonio Gomes.

This is not needed anymore since there is an implementation elsewhere.

  • PlatformBlackBerry.cmake:
  • page/blackberry/FrameBlackBerry.cpp: Removed.
14:43 Changeset [110333] by abarth@webkit.org
  • 8 edits in trunk/Source/WebCore

Unreviewed, rolling out r110309.
http://trac.webkit.org/changeset/110309
https://bugs.webkit.org/show_bug.cgi?id=80732

Seems to have caused a number of SVG crashes (thorton will
investigate further) (Requested by abarth|gardener on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-09

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::deferredRepaintTimerFired):

  • page/FrameView.h:

(FrameView):

  • rendering/RenderView.cpp:

(WebCore::RenderView::shouldRepaint):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawSVGToImageBuffer):
(WebCore::SVGImage::draw):

  • svg/graphics/SVGImage.h:
  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::imageContentChanged):
(WebCore::SVGImageCache::redrawTimerFired):

  • svg/graphics/SVGImageCache.h:

(SVGImageCache):

14:36 Changeset [110332] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Crash due to inserting letter into div with first-letter
https://bugs.webkit.org/show_bug.cgi?id=78534

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-03-09
Reviewed by David Hyatt.

Source/WebCore:

This fixes an issue in RenderTextFragment with setTextInternal
getting called with different intents. While most calls to it
are intended to change the underlying DOM node string, it can
also be called as a result of styleDidChange just for transforms
on the substring text fragment. This adds a mechanism for internal
callers to specify if the internal text is being updated without
a DOM node text change.

  • rendering/RenderTextFragment.cpp:

(WebCore::RenderTextFragment::styleDidChange)
(WebCore::RenderTextFragment::setTextInternal)

  • rendering/RenderTextFragment.h:

(WebCore::RenderTextFragment)

LayoutTests:

Test case to exercise the crashing condition in bug 78534. It inserts
a character in a first-letter div to induce an invalid RenderTextFragment
state.

  • editing/inserting/insert-character-in-first-letter-crash-expected.txt: Added
  • editing/inserting/insert-character-in-first-letter-crash.html: Added
14:31 Changeset [110331] by barraclough@apple.com
  • 5 edits in trunk

REGRESSION: Date.parse("Tue Nov 23 20:40:05 2010 GMT") returns NaN
https://bugs.webkit.org/show_bug.cgi?id=49989

Reviewed by Oliver Hunt.

Patch originally by chris reiss <christopher.reiss@nokia.com>,
allow the year to appear before the timezone in date strings.

Source/JavaScriptCore:

  • wtf/DateMath.cpp:

(WTF::parseDateFromNullTerminatedCharacters):

LayoutTests:

  • fast/js/date-parse-test-expected.txt:
  • fast/js/script-tests/date-parse-test.js:
14:24 Changeset [110330] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

Fix uninitialized variable in DynamicsCompressor
https://bugs.webkit.org/show_bug.cgi?id=80724

Reviewed by James Robinson.

  • platform/audio/DynamicsCompressor.cpp:

(WebCore::DynamicsCompressor::DynamicsCompressor):

14:04 Changeset [110329] by ojan@chromium.org
  • 32 edits
    1 move
    31 deletes in trunk/LayoutTests

Move some results from mac-future to mac. mac-future should not exist.
See https://bugs.webkit.org/show_bug.cgi?id=80717 for how these got there
in the first place.

  • platform/mac-future/svg/W3C-I18N/g-dirLTR-ubNone-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-anchor-no-markup-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png: Removed.
  • platform/mac-future/svg/W3C-I18N/tspan-direction-rtl-expected.png: Removed.
  • platform/mac-future/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png: Removed.
  • platform/mac-future/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Removed.
  • platform/mac-future/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Removed.
  • platform/mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/mac/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/mac/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Renamed from LayoutTests/platform/mac-future/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
13:50 Changeset [110328] by arv@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Undo text position adjustment for attribute event handlers
https://bugs.webkit.org/show_bug.cgi?id=80725

Reviewed by Adam Barth.

No new tests. Needs rebaseline.

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

13:34 Changeset [110327] by mrowe@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Ensure that the WTF headers are copied at installhdrs time.

Reviewed by Dan Bernstein and Jessie Berlin.

  • Configurations/JavaScriptCore.xcconfig: Set INSTALLHDRS_SCRIPT_PHASE = YES

so that our script phases are invoked at installhdrs time. The only one that
does any useful work at that time is the one that installs WTF headers.

13:34 Changeset [110326] by tsepez@chromium.org
  • 3 edits
    3 adds in trunk

Hold cached images with a CachedResourceHandle rather than a raw pointer for CSSCrossfadeValue
https://bugs.webkit.org/show_bug.cgi?id=80186

Reviewed by Simon Fraser.

Source/WebCore:

Test: http/tests/css/cross-fade-reload.html

  • css/CSSCrossfadeValue.h:

(CSSCrossfadeValue):

LayoutTests:

  • http/tests/css/cross-fade-reload-expected.txt: Added.
  • http/tests/css/cross-fade-reload.html: Added.
  • http/tests/css/resources/abe.png: Added.
13:32 Changeset [110325] by jamesr@google.com
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Expose the shared graphics context on WebView so callers can allocate resources on the main thread for the compositor to use
https://bugs.webkit.org/show_bug.cgi?id=80670

Reviewed by Stephen White.

This exposes a context on WebView that is in the compositor's share group and can be used directly from the main
thread. This is useful for content that needs to allocate resources for the compositor to use, but cannot
directly use the compositor's context either because it cannot access the correct thread or because it needs to
initialize in situations where we cannot initialize a compositor (view) context - for instance before the native
window is created.

  • public/WebView.h:

(WebView):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::sharedGraphicsContext3D):
(WebKit):

  • src/WebViewImpl.h:

(WebViewImpl):

13:14 Changeset [110324] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash when splitting an anonymous block in multi-column layout.
https://bugs.webkit.org/show_bug.cgi?id=80432

Reviewed by David Hyatt.

Source/WebCore:

Calculating currChild->nextSibling() is risky after destroying :after content
because it can blow away currChild if it is a left over empty anonymous block.
We need to calculate next sibling upfront, using the same trick, we do in
RenderBlock::addChildIgnoringAnonymousColumnBlock to reset beforeChild (check
out the line before splitFlow call).

Test: fast/multicol/anonymous-block-split-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::splitBlocks):

LayoutTests:

  • fast/multicol/anonymous-block-split-crash-expected.txt: Added.
  • fast/multicol/anonymous-block-split-crash.html: Added.
13:12 Changeset [110323] by inferno@chromium.org
  • 10 edits
    2 adds in trunk

Crash due to accessing removed parent lineboxes when clearing selection.
https://bugs.webkit.org/show_bug.cgi?id=79264

Reviewed by Dave Hyatt.

Source/WebCore:

Test: editing/selection/first-letter-selection-crash.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::setSelectionState):

  1. No need of checking if we are being set to same selection state.

Now tested by setSelectionStateIfNeeded. Rename 's' with 'state' and
'cb' with 'containingBlock'.

  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::setSelectionState):

  1. Add check to canUpdateSelectionOnRootLineBoxes to make sure our

root line boxes are still valid before setting them.

  1. No need of calling setSelectionState on containing block since our base

class call to RenderBox::setSelectionState covers it. Added a comment to indicate that.

  1. Use m_inlineBoxWrapper variable directly to simplify the ifs.
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::canUpdateSelectionOnRootLineBoxes):
(WebCore): helper function to tell if we can update selection information
on our root line boxes. This returns false if our containing block is pending layout.

  • rendering/RenderObject.h:

(RenderObject):
(WebCore::RenderObject::setSelectionStateIfNeeded):
(WebCore): helper to set selection state only if it is different from our
current selection state.

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::setSelectionState):

  1. Rename 's' to 'state', 'line' to 'root' and use m_inlineBoxWrapper directly

to simplify ifs.

  1. Add check to canUpdateSelectionOnRootLineBoxes to make sure our

root line boxes are still valid before setting them.

  • rendering/RenderText.cpp:

(WebCore::RenderText::setSelectionState):

  1. Add check to canUpdateSelectionOnRootLineBoxes to make sure our

root line boxes are still valid before setting them.

  1. Rename 'cb' to 'containingBlock', 'line' to 'root', move InlineTextBox

declaration to local.

  • rendering/RenderView.cpp:

(WebCore::RenderView::setSelection): Replace all calls to setSelectionState
with setSelectionStateIfNeeded.

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::setSelectionState):

  1. No need of checking if we are being set to same selection state.

Now tested by setSelectionStateIfNeeded.

LayoutTests:

  • editing/selection/first-letter-selection-crash-expected.txt: Added.
  • editing/selection/first-letter-selection-crash.html: Added.
13:04 Changeset [110322] by leviw@chromium.org
  • 9 edits in trunk/Source/WebCore

Move TransformationMatrix and TransformState to LayoutUnits.
https://bugs.webkit.org/show_bug.cgi?id=80632

Reviewed by Simon Fraser.

When we move layout to sub-pixel precision, we want to preserve that precision through
transformations. This change readies TransformState and TransformationMatrix to make
use of this additional precision in accumulating transforms, and in returning rects that
preserve it.

No new tests. No change in behavior.

  • platform/graphics/transforms/TransformState.cpp:

(WebCore::TransformState::move): Changed to pass along LayoutUnits to the contained
TransformationMatrix. The values of the LayoutUnits will be implicitly converted to
floats to be applied.

  • platform/graphics/transforms/TransformState.h:

(WebCore::TransformState::move): Ditto.
(TransformState):

  • platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::clampEdgeValue): Limiting edges to the maximum LayoutUnit value to prevent
overflow..
(WebCore::TransformationMatrix::clampedBoundsOfProjectedQuad): Same as above, but also
returning a LayoutRect which preserves additional precision than the previous IntRect.
(WebCore::TransformationMatrix::mapRect): Adding a version of this method that operates
specifically on FractionalLayoutRects.
(WebCore):

  • platform/graphics/transforms/TransformationMatrix.h:

(WebCore):
(TransformationMatrix):

  • rendering/LayoutTypes.h:

(WebCore::clampToLayoutUnit):
(WebCore):

12:53 Changeset [110321] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove a bogus assertion. This condition is no longer true for non-document tree scopes.

  • dom/TreeScope.cpp:

(WebCore::TreeScope::activeElement):

12:34 Changeset [110320] by rniwa@webkit.org
  • 12 edits in trunk/Source/WebCore

Cleanup incDOMTreeVersion callers
https://bugs.webkit.org/show_bug.cgi?id=80452

Reviewed by Andreas Kling.

Unify various calls to incDOMTreeVersion and namely remove the call inside dispatchSubtreeModifiedEvent.
There should be no behavioral change and therefore there is no new test.

  • dom/CharacterData.cpp:

(WebCore::CharacterData::parserAppendData):
(WebCore::CharacterData::setDataAndUpdate):

  • dom/ContainerNode.cpp:

(WebCore::willRemoveChild):
(WebCore::willRemoveChildren):
(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::childrenChanged):
(WebCore::notifyChildInserted):

  • dom/Element.cpp:

(WebCore::Element::attributeChanged):
(WebCore::Element::parserSetAttributes):
(WebCore::Element::willModifyAttribute):

  • dom/Node.cpp:

(WebCore::Node::dispatchSubtreeModifiedEvent):

  • html/HTMLOutputElement.cpp:

(WebCore::HTMLOutputElement::childrenChanged):

  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::childrenChanged):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::childrenChanged):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::childrenChanged):

  • html/HTMLTitleElement.cpp:

(WebCore::HTMLTitleElement::childrenChanged):

  • svg/SVGScriptElement.cpp:

(WebCore::SVGScriptElement::childrenChanged):

  • svg/SVGStyleElement.cpp:

(WebCore::SVGStyleElement::childrenChanged):

12:29 Changeset [110319] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix for !ENABLE(FILTERS) after r110285.

  • rendering/svg/SVGRenderingContext.h:

(WebCore::SVGRenderingContext::SVGRenderingContext):

12:27 Changeset [110318] by dbates@webkit.org
  • 26 edits in trunk

Bash scripts should support LF endings only
https://bugs.webkit.org/show_bug.cgi?id=79509

Actually commit the changes that should have been landed in <http://trac.webkit.org/changeset/110306>.
For some reason, webkit-patch land only committed the changes to the ChangeLog files.

12:22 Changeset [110317] by commit-queue@webkit.org
  • 15 edits in trunk/Source

[chromium] Use opaque paints in CCOcclusionTracker
https://bugs.webkit.org/show_bug.cgi?id=80173

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-09
Reviewed by Adrienne Walker.

Source/WebCore:

Use tracked opaque paints in the tiles when tracking occlusion in
CCOcclusionTracker. Moves the Tile::m_opaqueRect up to the super-
class in CCLayerTilingData rather than having it declared in both
TiledLayerChromium and CCTiledLayerImpl. This lets the CCLayerTilingData
class compute the opaque region for its tiles, sharing code between the
two tiled layer implementations.

Use of this feature is guarded behind a runtime flag and turned off for
paint culling. We will enable it in the future once we're comfortable
with the paint culling.

Unit test: CCOcclusionTrackerTest.opaqueContentsRegionEmpty

CCOcclusionTrackerTest.opaqueContentsRegionNonEmpty
TiledLayerChromiumTest.opaqueContentsRegion

All existing CCOcclusionTrackerTest.* duplicated with opaque painted
rects.

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::opaqueContentsRegion):
(LayerChromium):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(UpdatableTile):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::addSelfToOccludedScreenSpace):
(WebCore::TiledLayerChromium::opaqueContentsRegion):
(WebCore):

  • platform/graphics/chromium/TiledLayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::opaqueContentsRegion):
(CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTilingData.cpp:

(WebCore::CCLayerTilingData::opaqueRegionInLayerRect):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerTilingData.h:

(WebCore):
(Tile):
(WebCore::CCLayerTilingData::Tile::opaqueRect):
(WebCore::CCLayerTilingData::Tile::setOpaqueRect):
(CCLayerTilingData):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::CCOcclusionTrackerBase):
(WebCore::computeOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):

  • platform/graphics/chromium/cc/CCOcclusionTracker.h:

(CCOcclusionTrackerBase):
(WebCore::CCOcclusionTrackerBase::setUsePaintTracking):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(DrawableTile):
(WebCore::CCTiledLayerImpl::opaqueContentsRegion):
(WebCore):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:

(CCTiledLayerImpl):

Source/WebKit/chromium:

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore::LayerChromiumWithForcedDrawsContent::opaqueContentsRegion):
(LayerChromiumWithForcedDrawsContent):
(WebCore::LayerChromiumWithForcedDrawsContent::setOpaquePaintRect):
(WebCore::setLayerPropertiesForTesting):
(WebCore):
(WebCore::layerAddedToOccludedRegion):
(WebCore::layerAddedToOccludedRegionWithRotation):
(WebCore::layerAddedToOccludedRegionWithTranslation):
(WebCore::layerAddedToOccludedRegionWithRotatedSurface):
(WebCore::layerAddedToOccludedRegionWithSurfaceAlreadyOnStack):
(WebCore::layerAddedToOccludedRegionWithRotatedOffAxisSurface):
(WebCore::layerAddedToOccludedRegionWithMultipleOpaqueLayers):
(WebCore::surfaceOcclusionWithOverlappingSiblingSurfaces):
(WebCore::surfaceOcclusionInScreenSpace):
(WebCore::surfaceOcclusionInScreenSpaceDifferentTransforms):
(WebCore::occlusionInteractionWithFilters):
(WebCore::layerScissorRectOverTile):
(WebCore::screenScissorRectOverTile):
(WebCore::layerScissorRectOverCulledTile):
(WebCore::screenScissorRectOverCulledTile):
(WebCore::layerScissorRectOverPartialTiles):
(WebCore::screenScissorRectOverPartialTiles):
(WebCore::layerScissorRectOverNoTiles):
(WebCore::screenScissorRectOverNoTiles):
(WebCore::layerScissorRectForLayerOffOrigin):
(WebCore::damageRectOverTile):
(WebCore::damageRectOverCulledTile):
(WebCore::damageRectOverPartialTiles):
(WebCore::damageRectOverNoTiles):
(WebCore::TEST):

  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):
(WTF):

12:16 Changeset [110316] by antti@apple.com
  • 3 edits in trunk/Source/WebCore

Presentation attribute cache
https://bugs.webkit.org/show_bug.cgi?id=80707

Reviewed by Andreas Kling.

It is common for the same presentation attribute values repeat. We should introduce a cache that uses
presentation attribute names and values as key. This will help to avoid repeated parsing of the
same attribute values, reduce memory consumption and speed up the style resolve.

This patch introduces a simple and small (128 entries) global cache. In general web browsing it seems
to give sharing rate of >75% (an average presentation attribute property set is shared between >4 elements).

  • dom/StyledElement.cpp:

(WebCore::PresentationAttributeCacheKey::PresentationAttributeCacheKey):
(PresentationAttributeCacheKey):
(WebCore):
(WebCore::operator!=):
(PresentationAttributeCacheEntry):
(WebCore::presentationAttributeCache):
(WebCore::attributeNameSort):
(WebCore::StyledElement::makePresentationAttributeCacheKey):
(WebCore::computePresentationAttributeCacheHash):
(WebCore::StyledElement::updateAttributeStyle):

  • dom/StyledElement.h:

(WebCore):
(StyledElement):

12:12 Changeset [110315] by arv@chromium.org
  • 7 edits
    6 adds in trunk

[V8] Fix object scope for inline event attribute handlers
https://bugs.webkit.org/show_bug.cgi?id=80329

Reviewed by Ojan Vafai.

Source/WebCore:

We now create the funciton inside the with-statements with the current scope objects.
This is important for a few reasons:

  • We need to use the real objects and not just lookup the JS properties because these might have been overridden.
  • We need to use the node, form and document at the time of the preparation and not at the time of calling.
  • We need to ensure that event/evt is bound closer than a property with the same name in the object environment created by the with-statements.

Tests: fast/dom/inline-event-attributes-lookup-removed-form.html

fast/dom/inline-event-attributes-lookup-removed.html
fast/dom/inline-event-attributes-lookup.html

  • bindings/v8/ScriptEventListener.cpp:

(WebCore::eventParameterName):
(WebCore):
(WebCore::createAttributeEventListener):

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::V8LazyEventListener):
(WebCore):
(WebCore::toObjectWrapper):
(WebCore::V8LazyEventListener::callListenerFunction):
(WebCore::V8LazyEventListener::prepareListenerObject):

  • bindings/v8/V8LazyEventListener.h:

(WebCore):
(WebCore::V8LazyEventListener::create):
(V8LazyEventListener):

LayoutTests:

  • fast/dom/inline-event-attributes-lookup-expected.txt: Added.
  • fast/dom/inline-event-attributes-lookup-removed-expected.txt: Added.
  • fast/dom/inline-event-attributes-lookup-removed-form-expected.txt: Added.
  • fast/dom/inline-event-attributes-lookup-removed-form.html: Added.
  • fast/dom/inline-event-attributes-lookup-removed.html: Added.
  • fast/dom/inline-event-attributes-lookup.html: Added.
  • fast/forms/lazy-event-listener-scope-chain-expected.txt:
  • fast/forms/lazy-event-listener-scope-chain.html:
12:07 Changeset [110314] by schenney@chromium.org
  • 3 edits in trunk/Source/WebCore

Crash in WebCore::SVGUseElement::instanceForShadowTreeElement
https://bugs.webkit.org/show_bug.cgi?id=80406

Reviewed by Nikolas Zimmermann.

Code assumes that an object that is an SVG Element and in a shadow
tree must be in an SVG use shadow tree, and casts the shadow host with
a static_cast. It may be that an SVG element appears in a non-use
shadow tree, in which case bad things happen. While it appears that
the current code prevents such a situation from arising (checks are
made within the shadow tree code to prevent it) there are also
indications that the situation may change.

No new tests. I believe that the problem here cannot currently be
reproduced. That is, other code prevents SVG elements from appearing
in non-svg shadow trees.

  • dom/EventDispatcher.cpp:

(WebCore::eventTargetRespectingSVGTargetRules):

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::title):

12:06 Changeset [110313] by ojan@chromium.org
  • 1647 edits in trunk/LayoutTests

2012-03-09 Ojan Vafai <ojan@chromium.org (:ojan) (r)>

Add image/png svn:mime-type to all png images that currently lack
an svn:mime-type. Correctly this time.

12:00 Changeset [110312] by ojan@chromium.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Add image/png svn:mime-type to all png images that currently lack
and svn:mime-type.

11:41 Changeset [110311] by jonlee@apple.com
  • 25 edits in trunk

Add support for ENABLE(LEGACY_NOTIFICATIONS)
https://bugs.webkit.org/show_bug.cgi?id=80497

Reviewed by Adam Barth.

.:

Prep for b80472: Update API for Web Notifications

  • Source/cmake/OptionsBlackBerry.cmake:
  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsWinCE.cmake:
  • Source/cmakeconfig.h.cmake:
  • configure.ac:

Source/JavaScriptCore:

Prep for b80472: Update API for Web Notifications

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Prep for b80472: Update API for Web Notifications

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:

Source/WebKit/chromium:

Prep for b80472: Update API for Web Notifications

  • features.gypi:

Source/WebKit/mac:

Prep for b80472: Update API for Web Notifications

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/qt:

Prep for b80472: Update API for Web Notifications

  • examples/platformplugin/platformplugin.pro:

Source/WebKit2:

Prep for b80472: Update API for Web Notifications

  • Configurations/FeatureDefines.xcconfig:

Tools:

Prep for b80472: Update API for Web Notifications

  • Scripts/build-webkit:
  • qmake/mkspecs/features/features.prf:

WebKitLibraries:

Prep for b80472: Update API for Web Notifications

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
11:38 Changeset [110310] by commit-queue@webkit.org
  • 12 edits
    2 adds in trunk

ShadowRoot should implement activeElement.
https://bugs.webkit.org/show_bug.cgi?id=79886

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2012-03-09
Reviewed by Ryosuke Niwa.

Source/WebCore:

Implement the activeElement attribute for ShadowRoot to return the
currently focused element in the shadow DOM subtree.

Test: fast/dom/shadow/shadow-root-activeElement.html

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::activeElement):
(WebCore):

  • dom/ShadowRoot.h:

(ShadowRoot):

  • dom/ShadowRoot.idl:
  • dom/TreeScope.cpp:

(WebCore::TreeScope::adoptIfNeeded):
(WebCore):
(WebCore::focusedFrameOwnerElement):
(WebCore::TreeScope::activeElement):

  • dom/TreeScope.h:

(TreeScope):

  • html/HTMLDocument.cpp:

(WebCore):
(WebCore::HTMLDocument::activeElement):

LayoutTests:

Added test case for activeElement attribute of ShadowRoot.

  • fast/dom/shadow/shadow-root-activeElement-expected.txt: Added.
  • fast/dom/shadow/shadow-root-activeElement.html: Added.
  • platform/mac/Skipped: Added test case in Skipped as ShadowRoot is supported by Chromium only.
  • platform/qt/Skipped: ditto.
  • platform/win/Skipped: ditto.
  • platform/wincairo/Skipped: ditto.
  • platform/wk2/Skipped: ditto.
11:21 Changeset [110309] by timothy_horton@apple.com
  • 8 edits in trunk/Source/WebCore

Infinite repaint loop with SVGImageCache and deferred repaint timers
https://bugs.webkit.org/show_bug.cgi?id=78315
<rdar://problem/10651634>

Reviewed by Nikolas Zimmermann.

Only defer image redraw on a timer if we're in layout. This breaks
the repaint loop while still preventing us from drawing inside layout.

Completely disable repaint during relayout inside SVGImage::drawSVGToImageBuffer,
preventing deferred repaint timers from being started during that process.

No new tests, as the problem only occurs in a nonstandard configuration.

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::draw):
(WebCore::SVGImage::frameView):
(WebCore):

  • svg/graphics/SVGImage.h:

(WebCore):

  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::imageContentChanged):
(WebCore::SVGImageCache::redraw):
(WebCore::SVGImageCache::redrawTimerFired):
(WebCore):

  • svg/graphics/SVGImageCache.h:

(SVGImageCache):

11:16 Changeset [110308] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

Source/WebCore: The method TextTrackCue::getCueAsHTML() should return different
fragments on different calls.

https://bugs.webkit.org/show_bug.cgi?id=80701

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-03-09
Reviewed by Eric Carlson.

Test: media/track/track-cue-mutable-fragment.html

  • html/track/TextTrackCue.cpp: Removed setCueHTML(), since it is sufficient

to create apply the DOM rules only when the fragment is first requested.
(WebCore::TextTrackCue::getCueAsHTML): Changed the method such that a
a clone of the cached document fragment is returned.

  • html/track/TextTrackCue.h: Removed setCueHTML() as the document fragment

of the cue should be created only within the class, from the cue text.
(TextTrackCue):

  • html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::createNewCue): removed usage of setCueHTML()

LayoutTests: Added relevant layout tests to verify that the fragment can be appended
multiple times to the DOM and modified correctly.

https://bugs.webkit.org/show_bug.cgi?id=80701

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-03-09
Reviewed by Eric Carlson.

  • media/track/captions-webvtt/captions-html.vtt: Added. This file could

be used later for more complex html / css rendering tests.

  • media/track/track-cue-mutable-fragment-expected.txt: Added.
  • media/track/track-cue-mutable-fragment.html: Added.
11:13 Changeset [110307] by timothy_horton@apple.com
  • 5 edits
    2 adds in trunk

Crash in SVGTextLayoutAttributesBuilder::fillCharacterDataMap
https://bugs.webkit.org/show_bug.cgi?id=78949
<rdar://problem/10889440>

Reviewed by Nikolas Zimmermann.

Invalidate the text positioning cache when the children of an SVGAElement change,
so that we regenerate the list the next time it's needed instead of using stale values.

Test: svg/text/text-positioning-remove-child-crash.svg

  • rendering/svg/SVGAElement.cpp:

(WebCore::SVGAElement::childrenChanged):

Add a test ensuring that we don't crash when removing a child of <a> inside a <text> block.

  • svg/text/text-positioning-remove-child-crash-expected.txt: Added.
  • svg/text/text-positioning-remove-child-crash.svg: Added.
11:09 Changeset [110306] by dbates@webkit.org
  • 9 edits in trunk

Bash scripts should support LF endings only
https://bugs.webkit.org/show_bug.cgi?id=79509

Patch by Ashod Nakashian <ashodnakashian@yahoo.com> on 2012-03-09
Reviewed by David Kilzer.

Source/JavaScriptCore:

  • gyp/generate-derived-sources.sh: Added property svn:eol-style.
  • gyp/run-if-exists.sh: Added property svn:eol-style.
  • gyp/update-info-plist.sh: Added property svn:eol-style.

Source/ThirdParty:

  • gtest/xcode/Samples/FrameworkSample/runtests.sh: Added property svn:executable.
  • gtest/xcode/Scripts/runtests.sh: Added property svn:executable.

Source/ThirdParty/ANGLE:

  • src/compiler/generate_parser.sh: Added property svn:eol-style.

Source/WebCore:

  • WebCore.gyp/mac/adjust_visibility.sh: Added property svn:eol-style.
  • WebCore.vcproj/build-generated-files.sh: Added property svn:executable.
  • WebCore.vcproj/migrate-scripts.sh: Added property svn:executable.
  • gyp/copy-forwarding-and-icu-headers.sh: Added property svn:eol-style.
  • gyp/copy-inspector-resources.sh: Added property svn:eol-style.
  • gyp/generate-derived-sources.sh: Added property svn:eol-style.
  • gyp/generate-webcore-export-file-generator.sh: Added property svn:eol-style.
  • gyp/run-if-exists.sh: Added property svn:eol-style.
  • gyp/streamline-inspector-source.sh: Added property svn:eol-style.
  • gyp/update-info-plist.sh: Added property svn:eol-style.

Source/WebKit2:

  • win/build-generated-files.sh: Added properties svn:executable and svn:eol-style.

Tools:

  • EWSTools/boot.sh: Added properties svn:executable and svn:eol-style.
  • EWSTools/start-queue.sh: Added property svn:eol-style.
  • Scripts/webkit-tools-completion.sh: Added properties svn:executable and svn:eol-style.
  • WebKitTestRunner/win/build-generated-files.sh: Added properties svn:executable and svn:eol-style.
  • iExploder/iexploder-1.7.2/tools/release_src.sh: Added property svn:eol-style.
  • iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added property svn:eol-style.

WebKitLibraries:

  • win/tools/scripts/feature-defines.sh: Modified property svn:eol-style.

Websites/bugs.webkit.org:

  • contrib/yp_nomail.sh: Added property svn:executable.

LayoutTests:

  • platform/mac/fast/loader/resources/mimeTypeExamples/example-sh.sh: Added property svn:executable.
11:05 Changeset [110305] by kling@webkit.org
  • 9 edits in trunk/Source/WebCore

CSSParser: Use Vector for intermediate property storage.
<http://webkit.org/b/80653>

Reviewed by Antti Koivisto.

Remove the custom memory management for intermediate CSSProperties in CSSParser
and replace it by a Vector<CSSProperty, 256>.
This avoids heap allocations and removes a bunch of unnecessary complexity.

Remove WTF_MAKE_FAST_ALLOCATED from CSSProperty since they are only created on
the stack now.

  • css/CSSGrammar.y:
  • css/CSSParser.cpp:

(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::~CSSParser):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseColor):
(WebCore::CSSParser::parseDeclaration):
(WebCore::CSSParser::addProperty):
(WebCore::CSSParser::rollbackLastProperties):
(WebCore::CSSParser::clearProperties):
(WebCore::CSSParser::parse4Values):
(WebCore::CSSParser::parseFlowThread):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createMarginAtRule):
(WebCore::CSSParser::startDeclarationsForMarginBox):
(WebCore::CSSParser::endDeclarationsForMarginBox):
(WebCore::CSSParser::deleteFontFaceOnlyValues):
(WebCore::CSSParser::createKeyframeRule):

  • css/CSSParser.h:

(WebCore::CSSParser::hasProperties):
(CSSParser):

  • css/CSSProperty.h:
  • css/SVGCSSParser.cpp:

(WebCore::CSSParser::parseSVGValue):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::addParsedProperties):

  • css/StylePropertySet.h:

(WebCore::StylePropertySet::create):
(StylePropertySet):

10:02 Changeset [110304] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

Note that fast/events/input-image-scrolled-x-y.html is flaky.

  • platform/chromium/test_expectations.txt:
09:59 Changeset [110303] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r109022): Files dragged onto input controls cannot be read due to sandbox violation.
https://bugs.webkit.org/show_bug.cgi?id=80203
<rdar://problem/10976643>

Reviewed by Alexey Proskuryakov.

This patch reverts a small part fo r109022, leaving access to
NSPasteboard in the WebProcess when retrieving pathnames for
files being dragged. This avoid the sandbox violation until we
implement a mechanism to provide a sandbox extension to the WebProcess.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::getPathnamesForType):

09:56 Changeset [110302] by jberlin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Windows debug build fix.

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::shouldBlind):
Fix unreachable code warnings (which we treat as errors).

09:36 Changeset [110301] by japhet@chromium.org
  • 3 edits
    3 adds in trunk

2012-03-09 Nate Chapin <japhet@chromium.org>

CachedRawResource breaks when trying to load
a resource with an empty response body from cache.

Reviewed by Alexey Proskuryakov.

Test: http/tests/cache/zero-length-xhr.html

  • loader/cache/CachedRawResource.cpp: (WebCore::CachedRawResource::didAddClient): Don't exit early

if m_data is empty, we may still need to notifyFinished().

09:30 Changeset [110300] by commit-queue@webkit.org
  • 1 edit
    5 adds in trunk/Source/WebCore

[BlackBerry] Upstream classes that handle layer tiling
https://bugs.webkit.org/show_bug.cgi?id=79875

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-03-09
Reviewed by Rob Buis.

Initial upstreaming, no new tests.

  • platform/graphics/blackberry/LayerTile.cpp: Added.

(WebCore):
(WebCore::LayerTile::LayerTile):
(WebCore::LayerTile::~LayerTile):
(WebCore::LayerTile::setContents):
(WebCore::LayerTile::setContentsToColor):
(WebCore::LayerTile::updateContents):
(WebCore::LayerTile::discardContents):
(WebCore::LayerTile::setVisible):
(WebCore::LayerTile::setTexture):

  • platform/graphics/blackberry/LayerTile.h: Added.

(WebCore):
(LayerTileData):
(WebCore::LayerTileData::LayerTileData):
(WebCore::LayerTileData::isVisible):
(LayerTile):
(WebCore::LayerTile::texture):
(WebCore::LayerTile::isVisible):
(WebCore::LayerTile::isDirty):
(WebCore::LayerTile::hasTexture):
(WebCore::LayerTile::setContentsDirty):

  • platform/graphics/blackberry/LayerTileIndex.h: Added.

(WebCore):
(TileIndex):
(WebCore::TileIndex::TileIndex):
(WebCore::TileIndex::~TileIndex):
(WebCore::TileIndex::i):
(WebCore::TileIndex::j):
(WebCore::TileIndex::setIndex):
(WebCore::operator==):
(WebCore::operator!=):
(WTF):

  • platform/graphics/blackberry/LayerTiler.cpp: Added.

(WebCore):
(WebCore::transformPoint):
(WebCore::defaultTileSize):
(WebCore::LayerTiler::LayerTiler):
(WebCore::LayerTiler::~LayerTiler):
(WebCore::LayerTiler::layerWebKitThreadDestroyed):
(WebCore::LayerTiler::layerCompositingThreadDestroyed):
(WebCore::LayerTiler::setNeedsDisplay):
(WebCore::LayerTiler::updateTextureContentsIfNeeded):
(WebCore::LayerTiler::shouldPerformRenderJob):
(WebCore::LayerTiler::addTextureJob):
(WebCore::LayerTiler::clearTextureJobs):
(WebCore::LayerTiler::commitPendingTextureUploads):
(WebCore::LayerTiler::layerVisibilityChanged):
(WebCore::LayerTiler::uploadTexturesIfNeeded):
(WebCore::LayerTiler::processTextureJob):
(WebCore::LayerTiler::addTileJob):
(WebCore::LayerTiler::performTileJob):
(WebCore::LayerTiler::drawTextures):
(WebCore::LayerTiler::drawMissingTextures):
(WebCore::LayerTiler::drawTexturesInternal):
(WebCore::LayerTiler::addRenderJob):
(WebCore::LayerTiler::removeRenderJob):
(WebCore::LayerTiler::deleteTextures):
(WebCore::LayerTiler::pruneTextures):
(WebCore::LayerTiler::updateTileSize):
(WebCore::LayerTiler::disableTiling):
(WebCore::LayerTiler::shouldPrefillTile):
(WebCore::LayerTiler::indexOfTile):
(WebCore::LayerTiler::originOfTile):
(WebCore::LayerTiler::rectForTile):
(WebCore::LayerTiler::hasDirtyTiles):
(WebCore::LayerTiler::bindContentsTexture):

  • platform/graphics/blackberry/LayerTiler.h: Added.

(WebCore):
(LayerTiler):
(WebCore::LayerTiler::create):
(WebCore::LayerTiler::layer):
(WebCore::LayerTiler::hasMissingTextures):
(WebCore::LayerTiler::TextureJob::TextureJob):
(TextureJob):
(WebCore::LayerTiler::TextureJob::setContents):
(WebCore::LayerTiler::TextureJob::setContentsToColor):
(WebCore::LayerTiler::TextureJob::updateContents):
(WebCore::LayerTiler::TextureJob::discardContents):
(WebCore::LayerTiler::TextureJob::resizeContents):
(WebCore::LayerTiler::TextureJob::dirtyContents):
(WebCore::LayerTiler::TextureJob::isNull):
(WebCore::LayerTiler::tileSize):
(WebCore::LayerTiler::removeUpdateContentsJobs):

08:49 Changeset [110299] by commit-queue@webkit.org
  • 23 edits in trunk/Source

[chromium] Ensure we use the correct time when notifying animation started
https://bugs.webkit.org/show_bug.cgi?id=79537

Patch by Ian Vollick <vollick@chromium.org> on 2012-03-09
Reviewed by James Robinson

Source/WebCore:

Tested in CCLayerTreeHostTestAddAnimation

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setAnimationEvent):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):

  • platform/graphics/chromium/cc/CCAnimationEvents.cpp:

(WebCore::CCAnimationStartedEvent::create):
(WebCore::CCAnimationStartedEvent::CCAnimationStartedEvent):

  • platform/graphics/chromium/cc/CCAnimationEvents.h:

(CCAnimationEvent):
(CCAnimationStartedEvent):

  • platform/graphics/chromium/cc/CCInputHandler.h:

(CCInputHandler):

  • platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.cpp:

(WebCore::CCLayerAnimationControllerImpl::animate):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForNextTick):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForStartTime):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForTargetAvailability):
(WebCore::CCLayerAnimationControllerImpl::resolveConflicts):
(WebCore::CCLayerAnimationControllerImpl::tickAnimations):

  • platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.h:

(CCLayerAnimationControllerImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::setAnimationEvents):
(WebCore::CCLayerTreeHost::setAnimationEventsRecursive):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::animate):
(WebCore::CCLayerTreeHostImpl::startPageScaleAnimation):
(WebCore::CCLayerTreeHostImpl::animateLayersRecursive):
(WebCore::CCLayerTreeHostImpl::animatePageScale):
(WebCore::CCLayerTreeHostImpl::animateLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImplClient):
(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCPageScaleAnimation.cpp:

(WebCore::CCPageScaleAnimation::create):
(WebCore::CCPageScaleAnimation::CCPageScaleAnimation):
(WebCore::CCPageScaleAnimation::zoomTo):
(WebCore::CCPageScaleAnimation::zoomWithAnchor):
(WebCore::CCPageScaleAnimation::scrollOffsetAtTime):
(WebCore::CCPageScaleAnimation::pageScaleAtTime):
(WebCore::CCPageScaleAnimation::isAnimationCompleteAtTime):
(WebCore::CCPageScaleAnimation::progressRatioForTime):

  • platform/graphics/chromium/cc/CCPageScaleAnimation.h:

(CCPageScaleAnimation):
(WebCore::CCPageScaleAnimation::startTime):
(WebCore::CCPageScaleAnimation::duration):
(WebCore::CCPageScaleAnimation::endTime):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::startPageScaleAnimation):
(WebCore::CCSingleThreadProxy::postAnimationEventsToMainThreadOnImplThread):
(WebCore::CCSingleThreadProxy::doComposite):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(CCSingleThreadProxy):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::startPageScaleAnimation):
(WebCore::CCThreadProxy::requestStartPageScaleAnimationOnImplThread):
(WebCore::CCThreadProxy::postAnimationEventsToMainThreadOnImplThread):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwap):
(WebCore::CCThreadProxy::setAnimationEvents):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

  • src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::willDraw):

  • src/WebCompositorInputHandlerImpl.h:

(WebCompositorInputHandlerImpl):

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::CCLayerTreeHostImplTest::postAnimationEventsToMainThreadOnImplThread):
(WebKit::TEST_F):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::TestHooks::animateLayers):
(WTF::TestHooks::updateAnimations):
(WTF::MockLayerTreeHostImpl::animateLayers):
(WTF::MockLayerTreeHostClient::updateAnimations):
(WTF::CCLayerTreeHostTestAddAnimation::CCLayerTreeHostTestAddAnimation):
(WTF::CCLayerTreeHostTestAddAnimation::animateLayers):
(WTF::CCLayerTreeHostTestAddAnimation::notifyAnimationStarted):
(CCLayerTreeHostTestAddAnimation):

07:45 Changeset [110298] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
07:25 Changeset [110297] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Skip flaky svg tests.
07:22 Changeset [110296] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[BUILD] use detected python to run generate-gtkdoc
https://bugs.webkit.org/show_bug.cgi?id=80695

Patch by Ionut Biru <ibiru@archlinux.org> on 2012-03-09
Reviewed by Gustavo Noronha Silva.

  • GNUmakefile.am: Use $(PYTHON) instead of plain python
07:13 Changeset [110295] by ossy@webkit.org
  • 46 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/Skipped:
  • platform/qt/editing/selection/3690703-2-expected.png:
  • platform/qt/editing/selection/3690703-2-expected.txt:
  • platform/qt/editing/selection/3690703-expected.png:
  • platform/qt/editing/selection/3690703-expected.txt:
  • platform/qt/editing/selection/3690719-expected.png:
  • platform/qt/editing/selection/3690719-expected.txt:
  • platform/qt/fast/css/text-overflow-input-expected.txt: Added.
  • platform/qt/fast/forms/basic-inputs-expected.png: Added.
  • platform/qt/fast/forms/basic-inputs-expected.txt:
  • platform/qt/fast/replaced/replaced-breaking-expected.png:
  • platform/qt/fast/replaced/replaced-breaking-expected.txt:
  • platform/qt/fast/text/textIteratorNilRenderer-expected.png:
  • platform/qt/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/qt/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/qt/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1188-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug18359-expected.png:
  • platform/qt/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2479-4-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug28928-expected.png:
  • platform/qt/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug4382-expected.png:
  • platform/qt/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug44505-expected.png:
  • platform/qt/tables/mozilla/bugs/bug44505-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug4527-expected.png:
  • platform/qt/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug51037-expected.png:
  • platform/qt/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug7342-expected.png:
  • platform/qt/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/qt/tables/mozilla/dom/tableDom-expected.png:
  • platform/qt/tables/mozilla/dom/tableDom-expected.txt:
  • platform/qt/tables/mozilla/other/move_row-expected.png:
  • platform/qt/tables/mozilla/other/move_row-expected.txt:
  • platform/qt/test_expectations.txt:
07:08 Changeset [110294] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Layout test for window.devicePixelRatio
https://bugs.webkit.org/show_bug.cgi?id=80292

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-03-09
Reviewed by Philippe Normand.

Update the skipped list for ports where fast/viewport/viewport-133.html is failing.

  • platform/efl/Skipped:
  • platform/gtk/Skipped:
07:08 WebKitGTK/1.8.x edited by kov@webkit.org
Adding "[BUILD] use detected python to run generate-gtkdoc" to on track (diff)
06:25 Changeset [110293] by ossy@webkit.org
  • 224 edits
    2 copies
    7 adds in trunk/LayoutTests

[Qt] Rebaseline some tests on qt platfrom

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-03-09
Reviewed by Csaba Osztrogonác.

  • platform/qt/ [...]: Update expected files.
  • platform/qt/test_expectations.txt: Unskip now passing tests.
05:59 Changeset [110292] by zimmermann@webkit.org
  • 296 edits
    35 adds in trunk/LayoutTests

2012-03-09 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Rebaseline some Mac results that needed rebaselining - using Lion, and a Generic RGB Color profile.
Had to manually switch to this, until this is done automatically, see bug 80571.

Re-add several results that got deleted or moved to mac-future. I guess this is garden-o-matic
misusage? Not sure, anyhow, there are clearly a dozen of missing SVG pixel tests before this patch.

Reviewed by NOBODY (OOPS!).

  • platform/mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png: Added.
  • platform/mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png: Added.
  • platform/mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Added.
  • platform/mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-no-markup-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-direction-rtl-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
  • platform/mac/svg/batik/filters/feTile-expected.png:
  • platform/mac/svg/batik/filters/filterRegions-expected.png:
  • platform/mac/svg/batik/masking/maskRegions-expected.png: Added.
  • platform/mac/svg/batik/text/textEffect-expected.png:
  • platform/mac/svg/batik/text/textEffect3-expected.png:
  • platform/mac/svg/batik/text/textGlyphOrientationHorizontal-expected.png: Added.
  • platform/mac/svg/carto.net/scrollbar-expected.png: Added.
  • platform/mac/svg/css/composite-shadow-with-opacity-expected.png:
  • platform/mac/svg/css/path-gradient-stroke-shadow-expected.png:
  • platform/mac/svg/css/rect-gradient-stroke-shadow-expected.png:
  • platform/mac/svg/custom/convolution-crash-expected.png:
  • platform/mac/svg/custom/empty-merge-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/mac/svg/custom/feDisplacementMap-01-expected.png:
  • platform/mac/svg/custom/grayscale-gradient-mask-2-expected.png:
  • platform/mac/svg/custom/image-with-transform-clip-filter-expected.png:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/mac/svg/custom/non-opaque-filters-expected.png:
  • platform/mac/svg/custom/recursive-filter-expected.png:
  • platform/mac/svg/custom/resource-invalidate-on-target-update-expected.png:
  • platform/mac/svg/custom/root-container-opacity-clip-viewBox-expected.png:
  • platform/mac/svg/custom/text-filter-expected.png:
  • platform/mac/svg/custom/use-disappears-after-style-update-expected.png:
  • platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.png: Added.
  • platform/mac/svg/custom/visibility-override-filter-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDistantLightElement-dom-azimuth-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDistantLightElement-dom-elevation-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-azimuth-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-elevation-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEOffsetElement-dom-dx-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEOffsetElement-dom-dy-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEOffsetElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dx-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dy-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEOffsetElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-dom-height-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-dom-width-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-dom-x-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-dom-y-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-height-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-width-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-x-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-y-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.png:
  • platform/mac/svg/filters/big-sized-filter-2-expected.png:
  • platform/mac/svg/filters/big-sized-filter-expected.png:
  • platform/mac/svg/filters/feColorMatrix-default-type-expected.png:
  • platform/mac/svg/filters/feColorMatrix-offset-expected.png:
  • platform/mac/svg/filters/feColorMatrix-values-expected.png:
  • platform/mac/svg/filters/feComposite-expected.png:
  • platform/mac/svg/filters/feConvolveFilter-y-bounds-expected.png:
  • platform/mac/svg/filters/feDisplacementMap-expected.png:
  • platform/mac/svg/filters/feDropShadow-expected.png:
  • platform/mac/svg/filters/feGaussianBlur-expected.png:
  • platform/mac/svg/filters/feImage-animated-transform-on-target-rect-expected.png:
  • platform/mac/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png:
  • platform/mac/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png:
  • platform/mac/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png:
  • platform/mac/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png:
  • platform/mac/svg/filters/feImage-late-indirect-update-expected.png:
  • platform/mac/svg/filters/feImage-multiple-targets-id-change-expected.png:
  • platform/mac/svg/filters/feImage-position-expected.png:
  • platform/mac/svg/filters/feImage-preserveAspectratio-expected.png:
  • platform/mac/svg/filters/feImage-subregions-expected.png:
  • platform/mac/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png:
  • platform/mac/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png:
  • platform/mac/svg/filters/feImage-target-add-to-document-expected.png:
  • platform/mac/svg/filters/feImage-target-attribute-change-expected.png:
  • platform/mac/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png:
  • platform/mac/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png:
  • platform/mac/svg/filters/feImage-target-changes-id-expected.png:
  • platform/mac/svg/filters/feImage-target-id-change-expected.png:
  • platform/mac/svg/filters/feImage-target-inline-style-change-expected.png:
  • platform/mac/svg/filters/feImage-target-property-change-expected.png:
  • platform/mac/svg/filters/feImage-target-reappend-to-document-expected.png:
  • platform/mac/svg/filters/feImage-target-remove-from-document-expected.png:
  • platform/mac/svg/filters/feImage-target-style-change-expected.png:
  • platform/mac/svg/filters/feLighting-crash-expected.png:
  • platform/mac/svg/filters/feMerge-expected.png:
  • platform/mac/svg/filters/feOffset-expected.png:
  • platform/mac/svg/filters/feTile-expected.png:
  • platform/mac/svg/filters/filter-clip-expected.png:
  • platform/mac/svg/filters/filter-on-tspan-expected.png:
  • platform/mac/svg/filters/filter-placement-issue-expected.png:
  • platform/mac/svg/filters/filter-refresh-expected.png:
  • platform/mac/svg/filters/filter-rounding-issues-expected.png:
  • platform/mac/svg/filters/filter-source-position-expected.png:
  • platform/mac/svg/filters/filter-width-update-expected.png:
  • platform/mac/svg/filters/filterRes-expected.png:
  • platform/mac/svg/filters/filterRes1-expected.png:
  • platform/mac/svg/filters/filterRes2-expected.png:
  • platform/mac/svg/filters/filterRes3-expected.png:
  • platform/mac/svg/filters/filteredImage-expected.png:
  • platform/mac/svg/filters/parent-children-with-same-filter-expected.png:
  • platform/mac/svg/filters/shadow-on-filter-expected.png:
  • platform/mac/svg/filters/shadow-on-rect-with-filter-expected.png:
  • platform/mac/svg/filters/subRegion-in-userSpace-expected.png:
  • platform/mac/svg/filters/subRegion-one-effect-expected.png:
  • platform/mac/svg/filters/subRegion-two-effects-expected.png:
  • platform/mac/svg/hixie/mixed/003-expected.png:
  • platform/mac/svg/hixie/mixed/003-expected.txt:
  • platform/mac/svg/repaint/filter-child-repaint-expected.png:
  • platform/mac/svg/repaint/filter-repaint-expected.png:
  • platform/mac/svg/webarchive/svg-feimage-subresources-expected.png:
  • platform/mac/test_expectations.txt:
  • svg/filters/animate-fill-expected.png:
  • svg/filters/feColorMatrix-saturate-expected.png:
  • svg/filters/feImage-reference-invalidation-expected.png:
  • svg/filters/feImage-reference-svg-primitive-expected.png:
  • svg/foreignObject/filter-expected.png:
05:13 Changeset [110291] by ossy@webkit.org
  • 3 edits in trunk/Source/WebKit/qt

[Qt] Fix compilation without QtQuick1
https://bugs.webkit.org/show_bug.cgi?id=80503

Qt 4.8 API test fix after r110050.

Reviewed by Zoltan Herczeg.

  • declarative/public.pri: Add load(features) to ensure HAVE_QQUICK1=1 is set.
05:11 Changeset [110290] by charles.wei@torchmobile.com.cn
  • 6 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Web Notification not working after rebase
https://bugs.webkit.org/show_bug.cgi?id=80690

Reviewed by George Staikos.

  1. NotificationPresenterImpl should be in namespace WebCore
  2. Need to connect NotificationPresenterImpl to webcore the new way: WebCore::provideNotification(Page*, NotificationPresenter*)
  3. Remove the old way of connecting the Notification: ChromeClientBlackBerry::notificationPresenter()
  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore):

  • WebCoreSupport/ChromeClientBlackBerry.h:

(ChromeClientBlackBerry):

  • WebCoreSupport/NotificationPresenterImpl.cpp:
  • WebCoreSupport/NotificationPresenterImpl.h:
04:45 Changeset [110289] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Patch by Thouraya ANDOLSI <thouraya.andolsi@st.com> on 2012-03-09
Reviewed by Zoltan Herczeg.

[Qt] Fix the SH4 build after r109834
https://bugs.webkit.org/show_bug.cgi?id=80492

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::branchAdd32):
(JSC::MacroAssemblerSH4::branchSub32):

04:16 Changeset [110288] by ossy@webkit.org
  • 2 edits in trunk

[Qt] Disable WebGL performance tests temporarily.
https://bugs.webkit.org/show_bug.cgi?id=80503

Rubber-stamped by Simon Hausmann.

  • Source/tests.pri:
04:06 Changeset [110287] by wingo@igalia.com
  • 11 edits in trunk/Source/JavaScriptCore

Refactor code feature analysis in the parser
https://bugs.webkit.org/show_bug.cgi?id=79112

Reviewed by Geoffrey Garen.

This commit refactors the parser to more uniformly propagate flag
bits down and up the parse process, as the parser descends and
returns into nested blocks. Some flags get passed town to
subscopes, some apply to specific scopes only, and some get
unioned up after parsing subscopes.

The goal is to eventually be very precise with scoping
information, once we have block scopes: one block scope might use
`eval', which would require the emission of a symbol table within
that block and containing blocks, whereas another block in the
same function might not, allowing us to not emit a symbol table.

  • parser/Nodes.h:

(JSC::ScopeFlags): Rename from CodeFeatures.
(JSC::ScopeNode::addScopeFlags):
(JSC::ScopeNode::scopeFlags): New accessors for m_scopeFlags.
(JSC::ScopeNode::isStrictMode):
(JSC::ScopeNode::usesEval):
(JSC::ScopeNode::usesArguments):
(JSC::ScopeNode::setUsesArguments):
(JSC::ScopeNode::usesThis):
(JSC::ScopeNode::needsActivationForMoreThanVariables):
(JSC::ScopeNode::needsActivation): Refactor these accessors to
operate on the m_scopeFlags member.
(JSC::ScopeNode::source):
(JSC::ScopeNode::sourceURL):
(JSC::ScopeNode::sourceID): Shuffle these definitions around; no
semantic change.
(JSC::ScopeNode::ScopeNode)
(JSC::ProgramNode::ProgramNode)
(JSC::EvalNode::EvalNode)
(JSC::FunctionBodyNode::FunctionBodyNode): Have these constructors
take a ScopeFlags as an argument, instead of a bool inStrictContext.

  • parser/Nodes.cpp:

(JSC::ScopeNode::ScopeNode):
(JSC::ProgramNode::ProgramNode):
(JSC::ProgramNode::create):
(JSC::EvalNode::EvalNode):
(JSC::EvalNode::create):
(JSC::FunctionBodyNode::FunctionBodyNode):
(JSC::FunctionBodyNode::create): Adapt constructors to change.

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::ASTBuilder):
(JSC::ASTBuilder::thisExpr):
(JSC::ASTBuilder::createResolve):
(JSC::ASTBuilder::createFunctionBody):
(JSC::ASTBuilder::createFuncDeclStatement):
(JSC::ASTBuilder::createTryStatement):
(JSC::ASTBuilder::createWithStatement):
(JSC::ASTBuilder::addVar):
(JSC::ASTBuilder::Scope::Scope):
(Scope):
(ASTBuilder):
(JSC::ASTBuilder::makeFunctionCallNode): Don't track scope
features here. Instead rely on the base Parser mechanism to track
features.

  • parser/NodeInfo.h (NodeInfo, NodeDeclarationInfo): "ScopeFlags".
  • parser/Parser.h:

(JSC::Scope::Scope): Manage scope through flags, not
bit-booleans. This lets us uniformly propagate them up and down.
(JSC::Scope::declareWrite):
(JSC::Scope::declareParameter):
(JSC::Scope::useVariable):
(JSC::Scope::collectFreeVariables):
(JSC::Scope::getCapturedVariables):
(JSC::Scope::saveFunctionInfo):
(JSC::Scope::restoreFunctionInfo):
(JSC::Parser::pushScope): Adapt to use scope flags and their
accessors instead of bit-booleans.

  • parser/Parser.cpp:

(JSC::::Parser):
(JSC::::parseInner):
(JSC::::didFinishParsing):
(JSC::::parseSourceElements):
(JSC::::parseVarDeclarationList):
(JSC::::parseConstDeclarationList):
(JSC::::parseWithStatement):
(JSC::::parseTryStatement):
(JSC::::parseFunctionBody):
(JSC::::parseFunctionInfo):
(JSC::::parseFunctionDeclaration):
(JSC::::parsePrimaryExpression): Hoist some of the flag handling
out of the "context" (ASTBuilder or SyntaxChecker) and to here.
Does not seem to have a performance impact.

  • parser/SourceProviderCacheItem.h (SourceProviderCacheItem):

Cache the scopeflags.

  • parser/SyntaxChecker.h: Remove evalCount() decl.
  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::produceCodeBlockFor):

  • runtime/Executable.h:

(JSC::ScriptExecutable::ScriptExecutable):
(JSC::ScriptExecutable::usesEval):
(JSC::ScriptExecutable::usesArguments):
(JSC::ScriptExecutable::needsActivation):
(JSC::ScriptExecutable::isStrictMode):
(JSC::ScriptExecutable::recordParse):
(ScriptExecutable): ScopeFlags, not features.

04:03 Changeset [110286] by ossy@webkit.org
  • 4 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Skip new tests without expected files, need investigation.
  • platform/qt/http/tests/navigation/javascriptlink-frames-expected.png: Updated.
  • platform/qt/http/tests/navigation/javascriptlink-frames-expected.txt: Updated.
04:02 Changeset [110285] by zherczeg@webkit.org
  • 17 edits
    2 adds in trunk/Source/WebCore

Add SVGRenderingContext and move there the context related code from SVGRenderSupport
https://bugs.webkit.org/show_bug.cgi?id=80413

Reviewed by Nikolas Zimmermann.

This is the first step of refactoring the rendering context for SVG. The
previous context was stateless before, which means the cleanup phase
needed to do a lot of checks to revert the initialization part and
was unaware of failed inititalization. Future code can also add
new local variables to the context.

This patch add a new SVGRenderingContext class, and moves there the context
initialization / cleanup code from SVGRenderSupport. All build systems were
updated.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/svg/RenderSVGAllInOne.cpp:
  • rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::paint):

  • rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::paint):

  • rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::paint):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::paintReplaced):

  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::paint):

  • rendering/svg/SVGInlineFlowBox.cpp:

(WebCore::SVGInlineFlowBox::paint):

  • rendering/svg/SVGRenderSupport.cpp:
  • rendering/svg/SVGRenderSupport.h:
  • rendering/svg/SVGRenderingContext.cpp: Added.

(WebCore):
(WebCore::isRenderingMaskImage):
(WebCore::SVGRenderingContext::~SVGRenderingContext):
(WebCore::SVGRenderingContext::prepareToRenderSVGContent):

  • rendering/svg/SVGRenderingContext.h: Added.

(WebCore):
(SVGRenderingContext):
(WebCore::SVGRenderingContext::SVGRenderingContext):
(WebCore::SVGRenderingContext::isRenderingPrepared):

  • rendering/svg/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::paint):

03:52 CommitterTips edited by ossy@webkit.org
Add some more tips for unreviewed buildfixes (diff)
03:45 Changeset [110284] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Gardening, skip 3 failing tests.

Patch by Nándor Huszka <huszka.nandor@stud.u-szeged.hu> on 2012-03-09
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
03:16 Changeset [110283] by ossy@webkit.org
  • 13 edits
    2 deletes in trunk

Unreviewed, rolling out r110191, r110202, and r110279.
http://trac.webkit.org/changeset/110191
http://trac.webkit.org/changeset/110202
http://trac.webkit.org/changeset/110279
https://bugs.webkit.org/show_bug.cgi?id=80694

They broke !ENABLE(INSPECTOR) builds (Requested by Ossy on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-09

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

  • WebCore.exp.in:
  • testing/Internals.cpp:
  • testing/Internals.h:

(WebCore):
(Internals):

  • testing/Internals.idl:

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

  • inspector/elements/highlight-node-expected.txt: Removed.
  • inspector/elements/highlight-node.html: Removed.
03:13 Changeset [110282] by nduca@chromium.org
  • 3 edits in trunk/Tools

Make check-webkit-style complain about "no new tests" lines in changelogs
https://bugs.webkit.org/show_bug.cgi?id=80582

Reviewed by David Levin.

  • Scripts/webkitpy/style/checkers/changelog.py:

(ChangeLogChecker.check_entry):

  • Scripts/webkitpy/style/checkers/changelog_unittest.py:

(ChangeLogCheckerTest.test_no_new_tests):

02:56 Changeset [110281] by hans@chromium.org
  • 4 edits
    6 copies
    2 adds in trunk

Speech JavaScript API: add SpeechGrammar and SpeechGrammarList
https://bugs.webkit.org/show_bug.cgi?id=80417

Reviewed by Adam Barth.

Source/WebCore:

Implement SpeechGrammar and SpeechGrammarList.
(Spec: http://speech-javascript-api-spec.googlecode.com/git/speechapi.html)

Test: fast/speech/scripted/speechgrammar-basics.html

  • Modules/speech/DOMWindowSpeech.idl:
  • Modules/speech/SpeechGrammar.cpp:

(WebCore):
(WebCore::SpeechGrammar::create):
(WebCore::SpeechGrammar::SpeechGrammar):

  • Modules/speech/SpeechGrammar.h:

(WebCore):
(SpeechGrammar):
(WebCore::SpeechGrammar::src):
(WebCore::SpeechGrammar::setSrc):
(WebCore::SpeechGrammar::weight):
(WebCore::SpeechGrammar::setWeight):

  • Modules/speech/SpeechGrammar.idl:
  • Modules/speech/SpeechGrammarList.cpp:

(WebCore):
(WebCore::SpeechGrammarList::create):
(WebCore::SpeechGrammarList::item):
(WebCore::SpeechGrammarList::addFromUri):
(WebCore::SpeechGrammarList::addFromString):
(WebCore::SpeechGrammarList::SpeechGrammarList):

  • Modules/speech/SpeechGrammarList.h:

(WebCore):
(SpeechGrammarList):
(WebCore::SpeechGrammarList::length):

  • Modules/speech/SpeechGrammarList.idl:
  • WebCore.gypi:

LayoutTests:

Add a test for SpeechGrammar and SpeechGrammarList.

  • fast/speech/scripted/speechgrammar-basics-expected.txt: Added.
  • fast/speech/scripted/speechgrammar-basics.html: Added.
02:39 Changeset [110280] by ossy@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r110269.
http://trac.webkit.org/changeset/110269
https://bugs.webkit.org/show_bug.cgi?id=80688

It made inspector/elements/highlight-node.html fail everywhere
(Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-09

  • testing/Internals.idl:
01:55 Changeset [110279] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Unreviewed, build fix after r110191

  • features.gypi:
01:51 Changeset [110278] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Styles] Click in the first line of rule while editing property starts a new property
https://bugs.webkit.org/show_bug.cgi?id=80507

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection):
(WebInspector.StylePropertiesSection.prototype._checkWillCancelEditing):
(WebInspector.StylePropertiesSection.prototype._handleSelectorContainerClick):
(WebInspector.StylePropertiesSection.prototype._handleEmptySpaceClick):
(WebInspector.StylePropertyTreeElement.prototype.onattach):
(WebInspector.StylePropertyTreeElement.prototype):

01:33 Changeset [110277] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/11012024> Fix the build by working around <rdar://problem/10710970>.

  • platform/mac/RunLoopMac.mm:

(WebCore::RunLoop::stop):

01:27 Changeset [110276] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Gardening, skip two failing tests and a timeouting one.

Patch by Nándor Huszka <huszka.nandor@stud.u-szeged.hu> on 2012-03-09
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
01:01 Changeset [110275] by commit-queue@webkit.org
  • 13 edits
    4 adds in trunk

FileInputType doesn't support (save|restore)FormControlState
https://bugs.webkit.org/show_bug.cgi?id=80145

Patch by Marja Hölttä <marja@google.com> on 2012-03-09
Reviewed by Kent Tamura.

Source/WebCore:

This enables saving and restoring the state of file upload elements in
unsubmitted forms.

Test: fast/forms/file/recover-file-input-in-unposted-form.html

  • html/BaseCheckableInputType.cpp:

(WebCore::BaseCheckableInputType::restoreFormControlState): non-const

  • html/BaseCheckableInputType.h:

(BaseCheckableInputType): restoreFormControlState non-const

  • html/FileInputType.cpp:

(WebCore::FileInputType::saveFormControlState): save chosen files
(WebCore):
(WebCore::FileInputType::restoreFormControlState): restore chosen files

  • html/FileInputType.h:

(FileInputType): overwrite (save|restore)FormControlState

  • html/HiddenInputType.cpp:

(WebCore::HiddenInputType::restoreFormControlState): non-const

  • html/HiddenInputType.h:

(HiddenInputType): restoreFormControlState non-const

  • html/InputType.cpp:

(WebCore::InputType::restoreFormControlState): non-const

  • html/InputType.h:

(InputType): restoreFormControlState non-const

  • html/PasswordInputType.cpp:

(WebCore::PasswordInputType::restoreFormControlState): non-const

  • html/PasswordInputType.h:

(PasswordInputType): restoreFormControlState non-const

LayoutTests:

Tests for saving and restoring the state of file upload elements in unsubmitted forms.

  • fast/forms/file/recover-file-input-in-unposted-form-expected.txt: Added.
  • fast/forms/file/recover-file-input-in-unposted-form.html: Added.
  • platform/wk2/Skipped: The added test needs eventSender.beginDragWithFiles.
00:48 Changeset [110274] by toyoshim@chromium.org
  • 3 edits
    3 adds in trunk/LayoutTests

[WebSocket] Add a layout test where server force to disable all extensions
https://bugs.webkit.org/show_bug.cgi?id=80650

Reviewed by Kent Tamura.

  • http/tests/websocket/tests/hybi/echo-with-no-extension-expected.txt: Added.
  • http/tests/websocket/tests/hybi/echo-with-no-extension.html: Check if extension property is always empty string.
  • http/tests/websocket/tests/hybi/echo-with-no-extension_wsh.py: Added a handler which disable all extensions.

(web_socket_do_extra_handshake):
(web_socket_transfer_data):

  • http/tests/websocket/tests/hybi/extensions-expected.txt: Updated.
  • http/tests/websocket/tests/hybi/extensions.html: Added the case after connection is established.
00:42 Changeset [110273] by ossy@webkit.org
  • 4 edits in trunk/Tools

Unreviewed, rolling out r110250.
http://trac.webkit.org/changeset/110250
https://bugs.webkit.org/show_bug.cgi?id=80682

It made NRWT ignore test_expectations.txt on Qt-WK2 and ignore
qt-linux at all. (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-09

  • Scripts/old-run-webkit-tests:
  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort):
(QtPort.determine_full_port_name):
(QtPort.baseline_search_path):

  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:

(QtPortTest):
(QtPortTest._assert_search_path):
(QtPortTest.test_baseline_search_path):

03/08/12:

23:39 Changeset [110272] by vestbo@webkit.org
  • 35 edits
    1 add
    2 deletes in trunk

[Qt] Use Qt's module system for install rules and depending on QtWebKit

Instead of rolling our own install rules we now use the same approach as
every other Qt module, by loading qt_module.prf and qt_module_config.prf.

This ensures that we follow the same semantics as the rest of Qt on
what sort of config options are enabled by default (create_cmake eg.).
It also allows us to use QT += webkit instead of the workaround we had
with CONFIG += qtwebkit.

We do however force Qt to always treat our build as a non-developer build,
so the libraries will end up in the WebKit lib directory instead of the
qtbase directory (as with a normal developer-build). This allows us to
keep the webkit-build self-contained. If Qt is a developer build we still
copy the module file manually to Qt, so that you don't have to install
WebKit to make it available.

For non-developer builds of Qt, it is still possible to use the built
WebKit libraries without having to install them, by having the variable
QMAKE_EXTRA_MODULE_FORWARDS set in the project's .qmake.cache file,
pointing to $WEBKITOUTUTDIR/$CONFIGURATION/modules.

https://bugs.webkit.org/show_bug.cgi?id=80590

Reviewed by Simon Hausmann.

23:33 Changeset [110271] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Base the access to CSSStyleDeclaration on the CSSPropertyID instead of the PropertyName
https://bugs.webkit.org/show_bug.cgi?id=80461

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-08
Reviewed by Geoffrey Garen.

Previously, the acces to CSS Style properties was done through a NamedGetter. This caused
the (slow) mapping between CSSPropertyName and CSSPropertyID to be done twice for every acess:
1) canGetItemsForName() prior to the definition of the slot.
2) nameGetter() called from the slot with CSSPropertyName to get the actual value.

This patch changes the access to be based on CSSPropertyID. The slot is defined with the
CSSPropertyID as the customIndex, and the value can be accessed directly when the slot is
called.

To handle the differences create by hadPixelOrPosPrefix, two nearly identical callback are defined,
one for hadPixelOrPosPrefix, the other for !hadPixelOrPosPrefix.

The performance gain is about 19% when accessing CSS properties.

  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::getPropertyValueFallback):
(WebCore::cssPropertyGetterPixelOrPosPrefix):
(WebCore):
(WebCore::cssPropertyGetterPixelOrPosPrefixCallback):
(WebCore::cssPropertyGetter):
(WebCore::cssPropertyGetterCallback):
(WebCore::JSCSSStyleDeclaration::getOwnPropertySlotDelegate):
(WebCore::JSCSSStyleDeclaration::getOwnPropertyDescriptorDelegate):

  • css/CSSStyleDeclaration.idl:
23:33 Changeset [110270] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/Source/WebKit/efl

[Texmap][EFL] Implementation of AcceleratedCompositingContext for EFL port
https://bugs.webkit.org/show_bug.cgi?id=80266

Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2012-03-08
Reviewed by Noam Rosenthal.

This patch adds EFL's implementation of AcceleratedCompositingContext to WebCoreSupport.

  • WebCoreSupport/AcceleratedCompositingContextEfl.cpp: Added.

(WebCore):
(WebCore::AcceleratedCompositingContext::create):
(WebCore::AcceleratedCompositingContext::AcceleratedCompositingContext):
(WebCore::AcceleratedCompositingContext::~AcceleratedCompositingContext):
(WebCore::AcceleratedCompositingContext::initialize):
(WebCore::AcceleratedCompositingContext::syncLayersNow):
(WebCore::AcceleratedCompositingContext::renderLayers):
(WebCore::AcceleratedCompositingContext::attachRootGraphicsLayer):
(WebCore::AcceleratedCompositingContext::context):

  • WebCoreSupport/AcceleratedCompositingContextEfl.h: Added.

(WebCore):
(AcceleratedCompositingContext):

23:30 Changeset [110269] by vestbo@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Fix Qt minimal build

23:21 Changeset [110268] by benjamin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Build fix for MSVC after r110266

Unreviewed. A #ifdef for MSVC was left over in r110266.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-08

  • runtime/RegExpObject.h:

(RegExpObject):

23:16 Changeset [110267] by commit-queue@webkit.org
  • 16 edits in trunk/Source/WebCore

[chromium] Remove dead CoreGraphics code from chromium compositor implementation
https://bugs.webkit.org/show_bug.cgi?id=80470

Patch by James Robinson <jamesr@chromium.org> on 2012-03-08
Reviewed by Adam Barth.

We haven't supported CoreGraphics as a raster backend in chromium for a few months and do not plan to do so, so
it's time to remove the USE(CG) #ifdefs from our compositor and just rely on USE(SKIA) being set. This also
slightly simplifies how PlatformCanvas works.

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:
  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::createTextureUpdaterIfNeeded):

  • platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):

  • platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.h:
  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.cpp:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/PlatformCanvas.cpp:

(WebCore::PlatformCanvas::createBackingCanvas):
(WebCore::PlatformCanvas::AutoLocker::AutoLocker):
(WebCore::PlatformCanvas::AutoLocker::~AutoLocker):
(WebCore):
(WebCore::PlatformCanvas::AutoLocker::pixels):
(WebCore::PlatformCanvas::Painter::Painter):

  • platform/graphics/chromium/PlatformCanvas.h:

(WebCore):
(AutoLocker):
(Painter):
(PlatformCanvas):

  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp:
  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h:
Note: See TracTimeline for information about the timeline view.