Timeline


and

03/15/12:

23:56 Changeset [110951] by commit-queue@webkit.org

Expose attack, release as DynamicsCompressorNode's attributes.
https://bugs.webkit.org/show_bug.cgi?id=81221

Patch by Gao Chun <chun.gao@intel.com> on 2012-03-15
Reviewed by Chris Rogers.

Source/WebCore:

Test: webaudio/dynamicscompressor-basic.html

  • platform/audio/DynamicsCompressor.h:

(DynamicsCompressor):

  • webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
(WebCore::DynamicsCompressorNode::process):

  • webaudio/DynamicsCompressorNode.h:

(WebCore::DynamicsCompressorNode::attack):
(WebCore::DynamicsCompressorNode::release):
(DynamicsCompressorNode):

  • webaudio/DynamicsCompressorNode.idl:

LayoutTests:

  • webaudio/dynamicscompressor-basic-expected.txt:
  • webaudio/dynamicscompressor-basic.html:
23:35 Changeset [110950] by hans@chromium.org

Speech JavaScript API: SpeechRecognition, Controller and Client
https://bugs.webkit.org/show_bug.cgi?id=81096

Reviewed by Adam Barth.

Source/WebCore:

Add implementation stub for SpeechRecognition. Add the
SpeechRecognitionController class and SpeechRecognitionClient
interface.

Test: fast/speech/scripted/basics.html

  • Modules/speech/DOMWindowSpeech.idl:
  • Modules/speech/SpeechRecognition.cpp: Added.

(WebCore):
(WebCore::SpeechRecognition::create):
(WebCore::SpeechRecognition::start):
(WebCore::SpeechRecognition::stopFunction):
(WebCore::SpeechRecognition::abort):
(WebCore::SpeechRecognition::audioStartCallback):
(WebCore::SpeechRecognition::soundStartCallback):
(WebCore::SpeechRecognition::speechStartCallback):
(WebCore::SpeechRecognition::speechEndCallback):
(WebCore::SpeechRecognition::audioEndCallback):
(WebCore::SpeechRecognition::resultCallback):
(WebCore::SpeechRecognition::noMatchCallback):
(WebCore::SpeechRecognition::resultDeletedCallback):
(WebCore::SpeechRecognition::errorCallback):
(WebCore::SpeechRecognition::startCallback):
(WebCore::SpeechRecognition::endCallback):
(WebCore::SpeechRecognition::interfaceName):
(WebCore::SpeechRecognition::scriptExecutionContext):
(WebCore::SpeechRecognition::SpeechRecognition):
(WebCore::SpeechRecognition::~SpeechRecognition):

  • Modules/speech/SpeechRecognition.h: Added.

(WebCore):
(SpeechRecognition):
(WebCore::SpeechRecognition::grammars):
(WebCore::SpeechRecognition::setGrammars):
(WebCore::SpeechRecognition::lang):
(WebCore::SpeechRecognition::setLang):
(WebCore::SpeechRecognition::continuous):
(WebCore::SpeechRecognition::setContinuous):

  • Modules/speech/SpeechRecognition.idl:
  • Modules/speech/SpeechRecognitionClient.h:

(WebCore):
(SpeechRecognitionClient):
(WebCore::SpeechRecognitionClient::~SpeechRecognitionClient):

  • Modules/speech/SpeechRecognitionController.cpp:

(WebCore):
(WebCore::SpeechRecognitionController::supplementName):
(WebCore::SpeechRecognitionController::SpeechRecognitionController):
(WebCore::SpeechRecognitionController::~SpeechRecognitionController):
(WebCore::SpeechRecognitionController::create):
(WebCore::provideSpeechRecognitionTo):

  • Modules/speech/SpeechRecognitionController.h: Added.

(WebCore):
(SpeechRecognitionController):
(WebCore::SpeechRecognitionController::start):
(WebCore::SpeechRecognitionController::stop):
(WebCore::SpeechRecognitionController::abort):
(WebCore::SpeechRecognitionController::visibilityHidden):
(WebCore::SpeechRecognitionController::unregisterSpeechRecognition):
(WebCore::SpeechRecognitionController::from):

  • WebCore.gypi:
  • dom/EventTargetFactory.in:

Source/WebKit/chromium:

Provide a SpeechRecognitionController to Page, with a NULL client for
now.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

LayoutTests:

Add tests for the basics of the SpeechRecognition interface.

  • fast/speech/scripted/basics-expected.txt: Added.
  • fast/speech/scripted/basics.html: Added.
23:18 Changeset [110949] by morrita@google.com

[chromium] Fix some assertions in occlusion tracker unit tests
https://bugs.webkit.org/show_bug.cgi?id=81308

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-15
Reviewed by James Robinson.

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest):
(WebCore::CCOcclusionTrackerTestDamageRectOutsideChild::runMyTest):
(WebCore::CCOcclusionTrackerTest3dTransform::runMyTest):
(WebCore::CCOcclusionTrackerTestPerspectiveTransform::runMyTest):

23:18 Changeset [110948] by eric@webkit.org

Move parse_bug_id into config/urls in preparation for re-use elsewhere.
https://bugs.webkit.org/show_bug.cgi?id=81313

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/checkout/changelog.py:

(parse_bug_id_from_changelog):

  • Scripts/webkitpy/common/config/urls.py:

(parse_bug_id):

  • Scripts/webkitpy/common/config/urls_unittest.py: Copied from Tools/Scripts/webkitpy/common/config/urls.py.

(URLsTest):
(URLsTest.test_parse_bug_id):

  • Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:

(test_parse_bug_id):

  • Scripts/webkitpy/tool/bot/irc_command.py:

(_post_error_and_check_for_bug_url):

  • Scripts/webkitpy/tool/bot/sheriff.py:

(Sheriff.post_rollout_patch):
(Sheriff.post_chromium_deps_roll):

23:09 Changeset [110947] by tkent@chromium.org

Update the expectation of labelable-elements.html.

The expectation in the common place should be one for platforms with
ENABLE_DATALIST, was for platform without ENABLE_DATALIST.
https://bugs.webkit.org/show_bug.cgi?id=80985

  • fast/forms/label/labelable-elements-expected.txt:
  • platform/gtk/Skipped:
  • platform/mac/fast/forms/label/labelable-elements-expected.txt: Removed.
  • platform/qt/Skipped:
22:50 Changeset [110946] by commit-queue@webkit.org

[EFL] Sets alpha channel for new buffers.
https://bugs.webkit.org/show_bug.cgi?id=77101

Patch by Michal Ciepielski <m.ciepielski@samsung.com> on 2012-03-15
Reviewed by Hajime Morita.

No new tests.

By default EFL creates buffers without alpha channel.
This causes improper rendering of HTML controls (i.e. radio buttons, checkboxes).
This commits sets alpha channel for all newly created buffers by EFL.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::cacheThemePartNew):

22:47 Changeset [110945] by commit-queue@webkit.org

Unreviewed, rolling out r110941.
http://trac.webkit.org/changeset/110941
https://bugs.webkit.org/show_bug.cgi?id=81307

the revert looks innocent. (Requested by morrita on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-15

Source/WebCore:

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/Canvas2DLayerChromium.h:

(Canvas2DLayerChromium):

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::paintContentsIfDirty):
(WebCore::ContentLayerChromium::idlePaintContentsIfDirty):

  • platform/graphics/chromium/ContentLayerChromium.h:

(WebCore):
(ContentLayerChromium):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/ImageLayerChromium.h:

(WebCore):
(ImageLayerChromium):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::paintContentsIfDirty):
(WebCore::LayerChromium::idlePaintContentsIfDirty):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::prepareToUpdate):
(WebCore::TiledLayerChromium::prepareToUpdateIdle):

  • platform/graphics/chromium/TiledLayerChromium.h:

(TiledLayerChromium):

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/WebGLLayerChromium.h:

(WebGLLayerChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintContentsIfDirty):
(WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF::ContentLayerChromiumWithUpdateTracking::paintContentsIfDirty):
(WTF::ContentLayerChromiumWithUpdateTracking::idlePaintContentsIfDirty):
(WTF::TestLayerChromium::paintContentsIfDirty):

  • tests/Canvas2DLayerChromiumTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:

(TestCCOcclusionTracker):
(WTF::TestCCOcclusionTracker::TestCCOcclusionTracker):
(WTF::TestCCOcclusionTracker::setOcclusion):
(WTF::TestCCOcclusionTracker::layerScissorRectInTargetSurface):
(WTF):
(WTF::FakeTiledLayerChromium::prepareToUpdate):
(WTF::FakeTiledLayerChromium::prepareToUpdateIdle):
(WTF::FakeTiledLayerChromium::paintContentsIfDirty):
(WTF::TEST):

21:20 Changeset [110944] by abarth@webkit.org

The commit-queue should fast-track patches that have already passed the testing EWS bots
https://bugs.webkit.org/show_bug.cgi?id=81305

Reviewed by Eric Seidel.

If a patch has already passed the testing EWS bots (currently only the
chromium-ews bot), we should be able to land the patch without running
the tests again. This patch is somewhat risky in that the tests might
have been broken between when the EWS bots ran and when the
commit-queue is processing the patch. If that turns out to be a
problem in practice, we'll tighten up this fast-track in some way,
likely by making sure that the pass status is recent.

  • Scripts/webkitpy/tool/bot/commitqueuetask.py:

(CommitQueueTaskDelegate.did_pass_testing_ews):
(CommitQueueTask._did_pass_tests_recently):
(CommitQueueTask.run):

  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:

(MockCommitQueue.did_pass_testing_ews):
(test_fast_success_case):

  • Scripts/webkitpy/tool/commands/queues.py:

(CommitQueue.did_pass_testing_ews):

  • Scripts/webkitpy/tool/commands/queues_unittest.py:

(test_did_pass_testing_ews):

21:19 Changeset [110943] by tommyw@google.com

MediaStream API (JSEP): Introducing SessionDescription
https://bugs.webkit.org/show_bug.cgi?id=81206

Reviewed by Adam Barth.

Patch #3 in a series of patches to change the PeerConnection from ROAP to JSEP,
see bug 80589 for more information.
Adding the SessionDescription JS object and its platform counterpart SessionDescriptionDescriptor.

Not possible to test until the entire JSEP feature is commited.

  • GNUmakefile.list.am:
  • Modules/mediastream/SessionDescription.cpp: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.cpp.

(WebCore):
(WebCore::SessionDescription::create):
(WebCore::SessionDescription::SessionDescription):
(WebCore::SessionDescription::~SessionDescription):
(WebCore::SessionDescription::addCandidate):
(WebCore::SessionDescription::toSdp):
(WebCore::SessionDescription::descriptor):

  • Modules/mediastream/SessionDescription.h: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.cpp.

(WebCore):
(SessionDescription):

  • Modules/mediastream/SessionDescription.idl: Added.
  • WebCore.gypi:
  • platform/mediastream/MediaStreamCenter.cpp:

(WebCore::MediaStreamCenter::constructSdp):
(WebCore):

  • platform/mediastream/MediaStreamCenter.h:

(WebCore):
(MediaStreamCenter):

  • platform/mediastream/SessionDescriptionDescriptor.cpp: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.cpp.

(WebCore):
(WebCore::SessionDescriptionDescriptor::create):
(WebCore::SessionDescriptionDescriptor::SessionDescriptionDescriptor):
(WebCore::SessionDescriptionDescriptor::~SessionDescriptionDescriptor):
(WebCore::SessionDescriptionDescriptor::addCandidate):
(WebCore::SessionDescriptionDescriptor::toSdp):
(WebCore::SessionDescriptionDescriptor::numberOfAddedCandidates):
(WebCore::SessionDescriptionDescriptor::candidate):
(WebCore::SessionDescriptionDescriptor::initialSdp):

  • platform/mediastream/SessionDescriptionDescriptor.h: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.cpp.

(WebCore):
(SessionDescriptionDescriptor):

21:13 Changeset [110942] by lforschler@apple.com

Versioning.

21:07 Changeset [110941] by commit-queue@webkit.org

Unreviewed, rolling out r110929.
http://trac.webkit.org/changeset/110929
https://bugs.webkit.org/show_bug.cgi?id=81306

breaking webkit_unit_tests (Requested by morrita on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-15

Source/WebCore:

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/Canvas2DLayerChromium.h:

(Canvas2DLayerChromium):

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::paintContentsIfDirty):
(WebCore::ContentLayerChromium::idlePaintContentsIfDirty):

  • platform/graphics/chromium/ContentLayerChromium.h:

(WebCore):
(ContentLayerChromium):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/ImageLayerChromium.h:

(WebCore):
(ImageLayerChromium):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::paintContentsIfDirty):
(WebCore::LayerChromium::idlePaintContentsIfDirty):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore):
(WebCore::contentToLayerTransform):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::prepareToUpdate):
(WebCore::TiledLayerChromium::prepareToUpdateIdle):

  • platform/graphics/chromium/TiledLayerChromium.h:

(WebCore):
(TiledLayerChromium):

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/WebGLLayerChromium.h:

(WebGLLayerChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintContentsIfDirty):
(WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF::ContentLayerChromiumWithUpdateTracking::paintContentsIfDirty):
(WTF::ContentLayerChromiumWithUpdateTracking::idlePaintContentsIfDirty):
(WTF::TestLayerChromium::paintContentsIfDirty):

  • tests/Canvas2DLayerChromiumTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:

(WTF::FakeTiledLayerChromium::prepareToUpdate):
(WTF::FakeTiledLayerChromium::prepareToUpdateIdle):
(WTF::FakeTiledLayerChromium::paintContentsIfDirty):
(WTF::TEST):

21:07 Changeset [110940] by lforschler@apple.com

New Tag.

21:05 Changeset [110939] by commit-queue@webkit.org

Change per-script font tests to use InternalSettings
https://bugs.webkit.org/show_bug.cgi?id=81202

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-03-15
Reviewed by Hajime Morita.

  • fast/text/international/content-language-font-selection.html:
  • fast/text/international/content-language-with-subtags.html:
  • platform/efl/Skipped: Remove tests from Skipped since that no longer rely on overridePreference.
  • platform/gtk-wk2/Skipped: Ditto.
  • platform/gtk/Skipped: Ditto.
  • platform/mac/Skipped: Ditto.
  • platform/qt/Skipped: Ditto.
  • platform/win/Skipped: Ditto.
  • platform/wincairo/Skipped: Ditto.
  • platform/wk2/Skipped: Ditto.
21:03 Changeset [110938] by commit-queue@webkit.org

REGRESSION(r106232): The resize handler is always called after loading.
https://bugs.webkit.org/show_bug.cgi?id=80242

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-15
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Ensure resize-events are not emitted when layout-size changes due to added
scrollbars. For fixed layout, scrollbars are never subtracted or added, so
we can compare fixedLayoutSize directly. For normal layout, use the full
visible rect size which is the same as layout size plus scrollbars.

Test: fast/events/resize-events.html

  • page/FrameView.cpp:

(WebCore::FrameView::reset):
(WebCore::FrameView::layout):
(WebCore::FrameView::performPostLayoutTasks):

  • page/FrameView.h:

(FrameView):

LayoutTests:

Tests that no resize events are emitted during page creation,
even if the page overflows and adds a scrollbar.

  • fast/events/resize-events-expected.txt: Added.
  • fast/events/resize-events.html: Added.
20:45 Changeset [110937] by tommyw@google.com

MediaStream API (JSEP): Introducing MediaHints and IceOptions
https://bugs.webkit.org/show_bug.cgi?id=81207

Reviewed by Adam Barth.

Patch #4 in a series of patches to change the PeerConnection from ROAP to JSEP,
see bug 80589 for more information.
Introducing the platform MediaHints and IceOptions helper classes.

Not possible to test until the entire JSEP feature is commited.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • platform/mediastream/IceOptions.cpp: Added.

(WebCore):
(WebCore::IceOptions::create):

  • platform/mediastream/IceOptions.h: Added.

(WebCore):
(IceOptions):
(WebCore::IceOptions::~IceOptions):
(WebCore::IceOptions::useCandidates):
(WebCore::IceOptions::IceOptions):

  • platform/mediastream/MediaHints.cpp: Added.

(WebCore):
(WebCore::MediaHints::create):
(WebCore::MediaHints::audio):
(WebCore::MediaHints::video):

  • platform/mediastream/MediaHints.h: Added.

(WebCore):
(MediaHints):
(WebCore::MediaHints::~MediaHints):
(WebCore::MediaHints::MediaHints):

20:39 Changeset [110936] by commit-queue@webkit.org

Add layout tests for font selection based on lang/xml:lang
https://bugs.webkit.org/show_bug.cgi?id=81203

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-03-15
Reviewed by Hajime Morita.

  • fast/text/international/lang-sensitive-fonts-expected.html: Added.
  • fast/text/international/lang-sensitive-fonts-xml-expected.html: Added.
  • fast/text/international/lang-sensitive-fonts-xml.xhtml: Added.
  • fast/text/international/lang-sensitive-fonts.html: Added.
20:20 Changeset [110935] by shinyak@chromium.org

[Crash] Adding <content> into a ShadowRoot causes crash.
https://bugs.webkit.org/show_bug.cgi?id=80020

Reviewed by Hajime Morita.

Source/WebCore:

The problem is <content> tries to select host children though it is not prepared.
Since populating host children for insertion points is performed just before
attaching a shadow tree, we should recalculate whole shadow tree if <content> is
appended as a child.

However, element->appendChild() does not know the element is in a shadow tree or not.
We have to ensure reattaching whole shadow tree here.

So this patch adds some phases to HTMLContentSelector so that we can check node
distribution algorihm is begin processed or not. If not we cannot select anything,
but we have to enable a flag to reattach whole shadow tree.

Tests: fast/dom/shadow/shadow-content-crash-expected.html

fast/dom/shadow/shadow-content-crash.html

  • dom/ShadowTree.cpp:

(WebCore::ShadowTree::attach):
(WebCore::ShadowTree::insertionPointFor):

  • dom/ShadowTree.h:

(WebCore):
(ShadowTree):
(WebCore::ShadowTree::selector):

  • html/shadow/HTMLContentSelector.cpp:

(WebCore::HTMLContentSelector::HTMLContentSelector):
(WebCore::HTMLContentSelector::select):
(WebCore::HTMLContentSelector::willSelect):
(WebCore):
(WebCore::HTMLContentSelector::didSelect):
(WebCore::HTMLContentSelector::populateIfNecessary):

  • html/shadow/HTMLContentSelector.h:

(HTMLContentSelector):
(WebCore::HTMLContentSelector::isSelecting):
(WebCore):
(WebCore::HTMLContentSelector::hasPopulated):

  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::distributeHostChildren):
(WebCore::InsertionPoint::clearDistribution):

LayoutTests:

  • fast/dom/shadow/shadow-content-crash-expected.html: Added.
  • fast/dom/shadow/shadow-content-crash.html: Added.
20:14 Changeset [110934] by mikelawther@chromium.org

CSS3 calc: mixed percent/absolute expressions for gradients
https://bugs.webkit.org/show_bug.cgi?id=81182

Reviewed by Ojan Vafai.

Source/WebCore:

  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::addStops):
(WebCore::positionFromValue):

LayoutTests:

Add new tests for mixed percent/absolute expressions.

  • css3/calc/css3-radial-gradients-expected.html:
  • css3/calc/css3-radial-gradients.html:
  • css3/calc/gradient-color-stops-expected.html:
  • css3/calc/gradient-color-stops.html:
20:13 Changeset [110933] by haraken@chromium.org

[PerformanceTests] run-perf-tests should output correct units
https://bugs.webkit.org/show_bug.cgi?id=78303

Reviewed by Ryosuke Niwa.

Previously run-perf-tests just supported "ms" for units.
Consequently, Dromaeo perf tests had been reporting runs/s as "ms".
This patch fixes run-perf-tests so that they can support custom units.
The default unit is "ms".

The test result looks like this:

$ ./Tools/Scripts/run-perf-tests Dromaeo/dom-attr.html
RESULT Dromaeo: dom-attr= 6465.9525483 runs/s
median= 0.0 runs/s, stdev= 24.2983433436 runs/s, min= 6435.87649402 runs/s, max= 6515.63693392 runs/s

PerformanceTests:

  • Dromaeo/resources/dromaeorunner.js:

(.):

  • resources/runner.js:

(PerfTestRunner.computeStatistics):
(PerfTestRunner.printStatistics):

Tools:

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._process_parser_test_result):

20:00 Changeset [110932] by leo.yang@torchmobile.com.cn

[BlackBerry] Sync up MIMETypeRegistry.cpp
https://bugs.webkit.org/show_bug.cgi?id=81191

Reviewed by Rob Buis.

Add png and jpeg to supportedImageMIMETypesForEncoding for BlackBerry.

  • platform/MIMETypeRegistry.cpp:

(WebCore::initializeSupportedImageMIMETypesForEncoding):

19:54 Changeset [110931] by dgrogan@chromium.org

IndexedDB Tests: use self instead of window
https://bugs.webkit.org/show_bug.cgi?id=81043

'window' is meaningless in a worker; these tests will soon be run from
a worker context.

Reviewed by Tony Chang.

  • storage/indexeddb/create-and-remove-object-store.html:
  • storage/indexeddb/createObjectStore-name-argument-required.html:
  • storage/indexeddb/createObjectStore-null-name.html:
  • storage/indexeddb/cursor-continue.html:
  • storage/indexeddb/cursor-delete.html:
  • storage/indexeddb/cursor-inconsistency.html:
  • storage/indexeddb/cursor-index-delete.html:
  • storage/indexeddb/cursor-key-order.html:
  • storage/indexeddb/cursor-primary-key-order.html:
  • storage/indexeddb/cursor-skip-deleted.html:
  • storage/indexeddb/cursor-update-value-argument-required.html:
  • storage/indexeddb/cursor-update.html:
  • storage/indexeddb/data-corruption.html:
  • storage/indexeddb/database-basics.html:
  • storage/indexeddb/database-quota.html:
  • storage/indexeddb/delete-closed-database-object-expected.txt:
  • storage/indexeddb/delete-closed-database-object.html:
  • storage/indexeddb/deleteObjectStore-name-argument-required.html:
  • storage/indexeddb/deleteObjectStore-null-name.html:
  • storage/indexeddb/duplicates.html:
  • storage/indexeddb/error-causes-abort-by-default.html:
  • storage/indexeddb/exception-in-event-aborts.html:
  • storage/indexeddb/factory-cmp-expected.txt:
  • storage/indexeddb/factory-cmp.html:
  • storage/indexeddb/factory-deletedatabase-interactions-expected.txt:
  • storage/indexeddb/factory-deletedatabase-interactions.html:
  • storage/indexeddb/factory-deletedatabase.html:
  • storage/indexeddb/index-count.html:
  • storage/indexeddb/index-cursor.html:
  • storage/indexeddb/index-get-key-argument-required.html:
  • storage/indexeddb/index-population.html:
  • storage/indexeddb/index-unique.html:
  • storage/indexeddb/invalid-keys-expected.txt:
  • storage/indexeddb/invalid-keys.html:
  • storage/indexeddb/key-generator.html:
  • storage/indexeddb/key-sort-order-across-types.html:
  • storage/indexeddb/key-sort-order-date.html:
  • storage/indexeddb/key-type-array-expected.txt:
  • storage/indexeddb/key-type-array.html:
  • storage/indexeddb/key-type-infinity.html:
  • storage/indexeddb/keypath-basics.html:
  • storage/indexeddb/keypath-fetch-key.html:
  • storage/indexeddb/mozilla/add-twice-failure.html:
  • storage/indexeddb/mozilla/autoincrement-indexes.html:
  • storage/indexeddb/mozilla/bad-keypath.html:
  • storage/indexeddb/mozilla/clear.html:
  • storage/indexeddb/mozilla/create-index-unique.html:
  • storage/indexeddb/mozilla/create-index-with-integer-keys.html:
  • storage/indexeddb/mozilla/create-objectstore-basics.html:
  • storage/indexeddb/mozilla/create-objectstore-null-name.html:
  • storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html:
  • storage/indexeddb/mozilla/cursor-update-updates-indexes.html:
  • storage/indexeddb/mozilla/cursors.html:
  • storage/indexeddb/mozilla/delete-result.html:
  • storage/indexeddb/mozilla/event-source.html:
  • storage/indexeddb/mozilla/global-data.html:
  • storage/indexeddb/mozilla/indexes.html:
  • storage/indexeddb/mozilla/key-requirements-delete-null-key.html:
  • storage/indexeddb/mozilla/key-requirements-inline-and-passed.html:
  • storage/indexeddb/mozilla/key-requirements-put-no-key.html:
  • storage/indexeddb/mozilla/key-requirements-put-null-key.html:
  • storage/indexeddb/mozilla/key-requirements.html:
  • storage/indexeddb/mozilla/object-cursors.html:
  • storage/indexeddb/mozilla/object-identity.html:
  • storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put.html:
  • storage/indexeddb/mozilla/object-store-remove-values.html:
  • storage/indexeddb/mozilla/objectstorenames.html:
  • storage/indexeddb/mozilla/odd-result-order.html:
  • storage/indexeddb/mozilla/put-get-values.html:
  • storage/indexeddb/mozilla/readonly-transactions.html:
  • storage/indexeddb/mozilla/readwrite-transactions.html:
  • storage/indexeddb/mozilla/readyState.html:
  • storage/indexeddb/mozilla/remove-index.html:
  • storage/indexeddb/mozilla/remove-objectstore.html:
  • storage/indexeddb/mozilla/versionchange-abort.html:
  • storage/indexeddb/mozilla/versionchange.html:
  • storage/indexeddb/mutating-cursor.html:
  • storage/indexeddb/objectStore-required-arguments.html:
  • storage/indexeddb/objectstore-autoincrement.html:
  • storage/indexeddb/objectstore-clear.html:
  • storage/indexeddb/objectstore-count.html:
  • storage/indexeddb/objectstore-cursor.html:
  • storage/indexeddb/objectstore-removeobjectstore.html:
  • storage/indexeddb/open-close-version-expected.txt:
  • storage/indexeddb/open-close-version.html:
  • storage/indexeddb/open-cursor.html:
  • storage/indexeddb/prefetch-bugfix-108071.html:
  • storage/indexeddb/queued-commands.html:
  • storage/indexeddb/request-event-propagation.html:
  • storage/indexeddb/setVersion-null.html:
  • storage/indexeddb/setVersion-undefined.html:
  • storage/indexeddb/structured-clone-expected.txt:
  • storage/indexeddb/structured-clone.html:
  • storage/indexeddb/transaction-abort.html:
  • storage/indexeddb/transaction-after-close.html:
  • storage/indexeddb/transaction-and-objectstore-calls.html:
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-basics.html:
  • storage/indexeddb/transaction-crash-on-abort-expected.txt:
  • storage/indexeddb/transaction-crash-on-abort.html:
  • storage/indexeddb/transaction-event-propagation.html:
  • storage/indexeddb/transaction-read-only.html:
  • storage/indexeddb/transaction-rollback.html:
  • storage/indexeddb/transaction-storeNames-required.html:
  • storage/indexeddb/two-version-changes-expected.txt:
  • storage/indexeddb/two-version-changes.html:
  • storage/indexeddb/value-undefined.html:
  • storage/indexeddb/values-odd-types.html:
  • storage/indexeddb/version-change-abort.html:
  • storage/indexeddb/version-change-exclusive-expected.txt:
  • storage/indexeddb/version-change-exclusive.html:
  • storage/indexeddb/versionchangerequest-activedomobject-expected.txt:
  • storage/indexeddb/versionchangerequest-activedomobject.html:
19:50 Changeset [110930] by timothy_horton@apple.com

Unreviewed mac rebaseline for fast/clip/{011,012}.html after http://trac.webkit.org/changeset/110072

There was a similar Chromium rebaseline in http://trac.webkit.org/changeset/110179

  • platform/mac/fast/clip/011-expected.txt:
  • platform/mac/fast/clip/012-expected.txt:
19:41 Changeset [110929] by commit-queue@webkit.org

[chromium] Decide occlusion in paint culling with CCOcclusionTracker
https://bugs.webkit.org/show_bug.cgi?id=81181

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-15
Reviewed by Adrienne Walker.

Source/WebCore:

Plumb a CCOcclusionTracker* around instead of a bare Region, so that it
can make a more informed decision if a tile is occluded or not during
paint.

Covered by existing tests.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/Canvas2DLayerChromium.h:

(Canvas2DLayerChromium):

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::paintContentsIfDirty):
(WebCore::ContentLayerChromium::idlePaintContentsIfDirty):

  • platform/graphics/chromium/ContentLayerChromium.h:

(WebCore):
(ContentLayerChromium):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/ImageLayerChromium.h:

(WebCore):
(ImageLayerChromium):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::paintContentsIfDirty):
(WebCore::LayerChromium::idlePaintContentsIfDirty):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::prepareToUpdate):
(WebCore::TiledLayerChromium::prepareToUpdateIdle):

  • platform/graphics/chromium/TiledLayerChromium.h:

(TiledLayerChromium):

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/WebGLLayerChromium.h:

(WebGLLayerChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintContentsIfDirty):
(WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF::ContentLayerChromiumWithUpdateTracking::paintContentsIfDirty):
(WTF::ContentLayerChromiumWithUpdateTracking::idlePaintContentsIfDirty):
(WTF::TestLayerChromium::paintContentsIfDirty):

  • tests/Canvas2DLayerChromiumTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:

(TestCCOcclusionTracker):
(WTF::TestCCOcclusionTracker::TestCCOcclusionTracker):
(WTF::TestCCOcclusionTracker::setOcclusion):
(WTF::TestCCOcclusionTracker::layerScissorRectInTargetSurface):
(WTF):
(WTF::FakeTiledLayerChromium::prepareToUpdate):
(WTF::FakeTiledLayerChromium::prepareToUpdateIdle):
(WTF::FakeTiledLayerChromium::paintContentsIfDirty):
(WTF::TEST):

19:36 Changeset [110928] by jberlin@webkit.org

WebKitTestRunner layoutTestController.pathToLocalResource needs to be updated to work with
NRWT
https://bugs.webkit.org/show_bug.cgi?id=81299

Add failing expected results for mac-wk2 to get the bots green.

  • platform/mac-wk2/fast/loader/local-CSS-from-local-expected.txt: Added.
  • platform/mac-wk2/fast/loader/local-JavaScript-from-local-expected.txt: Added.
  • platform/mac-wk2/fast/loader/local-image-from-local-expected.txt: Added.
18:49 Changeset [110927] by commit-queue@webkit.org

[Forms] The "meter" element should not be a form-associated element.
https://bugs.webkit.org/show_bug.cgi?id=80380

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-15
Reviewed by Kent Tamura.

Source/WebCore:

This patch changes base class of HTMLMeterElement to LabelableElement from
HTMLFormControlElement for saving memory space and iteration time of
extra "meter" elements in HTMLFormElement::m_formAssociatedElements
and matching the HTML5 specification for ease of maintenance.

This patch renames isLabelable method to supportLabels and makes isLabelable
as predicate of an instance of LabelableElement or not.

Changes of TextIterator is lead by usage of isFormControlElement. This
changes will be replaced with more meaningful predicate as part of
https://bugs.webkit.org/show_bug.cgi?id=80381

No new tests. Update existing tests to cover this change.

  • editing/TextIterator.cpp:

(WebCore::TextIterator::advance): Check HTMLMeterElement in addition to isFormControlElement. This change is for text dump in LayoutTests implemented by document.innerText attribute.

  • html/HTMLButton.h:

(WebCore::HTMLButtonElement::supportLabels): Renamed from isLabelable

  • html/HTMLElement.h:

(WebCore::HTMLElement::isLabelable): Added. A predicate for an instance of LabelableElement.

  • html/HTMLInputElement.h:

(WebCore::HTMLInputElement::supportLabels): Renamed from isLabelable

  • html/HTMLKeygenElement.h:

(WebCore::HTMLKeygenElement::supportLabels): Renamed from isLabelable

  • html/HTMLLabelElement.cpp:

(WebCore::nodeAsLabelableElement): Changed to return LabelableElement instead of HTMLFormControlElement.
(WebCore::HTMLLabelElement::control): Changed to return LabelableElement instead of HTMLFormControlElement.

  • html/HTMLLabelElement.h:

(HTMLLabelElement):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::HTMLMeterElement): Changed base class to LabelableElement.
(WebCore::HTMLMeterElement::create): Remove form parameter.
(WebCore::HTMLMeterElement::formControlType): Remove implementation of virtual method declared in HTMLFormControlElement.
(WebCore::HTMLMeterElement::parseAttribute): Replace HTMLFormControlElement to LabelableElement
(WebCore::HTMLMeterElement::attach): Replace HTMLFormControlElement to LabelableElement

  • html/HTMLMeterElement.idl: Remove the "form" attribute which isn't listed in the HTML5 specification.
  • html/HTMLMeterElement.h:

(HTMLMeterElement):
(WebCore::HTMLMeterElement::supportLabels): Renamed from isLabelable

  • html/HTMLOutputElement.h:

(WebCore::HTMLOutputElement::supportLabels): Renamed from isLabelable

  • html/HTMLProgressElement.h:

(WebCore::HTMLProgressElement::supportLabels): Renamed from isLabelable

  • html/HTMLSelectElement.h:

(WebCore::HTMLSelectElement::supportLabels): Renamed from isLabelable

  • html/HTMLTextAreaElement.h:

(WebCore::HTMLTextAreaElement::supportLabels): Renamed from isLabelable

  • html/HiddenInputType.h:

(WebCore::HiddenInputType::supportLabels): Renamed from isLabelable

  • html/InputType.h:

(WebCore::InputType::supportLabels): Renamed from isLabelable

  • html/HTMLTagNames.in: Remove "constructorNeedsFormElement" for not passing "form" parameter in HTMLElementFactory.
  • html/LabelableElement.cpp:

(WebCore::LabelableElement::labels): Replace isLabelable to supportLabels

  • html/LabelableElement.h:

(LabelableElement):

LayoutTests:

This patch removes tests which checks non-existent "form" attribute
of the "meter" element. The "form" attribute is available only for
form-associated elements. However, the "meter" element isn't a
form-associated element.

  • fast/dom/HTMLMeterElement/meter-element-form-expected.txt: Updated expectation for test output changes.
  • fast/dom/HTMLMeterElement/meter-element-form.html: Changed for the "meter" element doesn't have IDL attribute "form".
  • fast/forms/form-attribute-expected.txt: Updated expectation for test output changes.
  • fast/forms/form-attribute.html: Removed lines for the "meter" element.
18:39 Changeset [110926] by timothy_horton@apple.com

canvas/philip/tests/2d.line.cap.round.html fails on Mac Lion WK1
https://bugs.webkit.org/show_bug.cgi?id=81289
<rdar://problem/11059777>

Unreviewed skip of two more similarly flaky tests:

canvas/philip/tests/2d.shadow.canvas.transparent.2.html
canvas/philip/tests/2d.shadow.image.transparent.2.html

18:24 Changeset [110925] by adamk@chromium.org

REGRESSION(r103452): 100% CPU usage and 5s pause after clicking on a link in Yahoo Mail
https://bugs.webkit.org/show_bug.cgi?id=81141

Reviewed by Ojan Vafai.

Source/WebCore:

Revert the behavior change from r103452: don't fire DOMSubtreeModified
events when an attribute value merely changes. Still fire that event
when an attribute is added or removed from an element.

Though this contradicts the DOM3 spec, it matches legacy WebKit behavior,
and given that Mutation Events are deprecated, it seems unwise to make
any additions to WebKit's implementation of them.

Test: fast/dom/subtree-modified-attributes.html

  • dom/Element.cpp:

(WebCore::Element::didAddAttribute): Renamed from didModifyAttribute.
(WebCore::Element::didModifyAttribute): Remove the call to dispatchSubtreeModifiedEvent.
(WebCore):

  • dom/Element.h:

(Element):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::addAttribute): Call didAddAttribute instead of didModifyAttribute.

LayoutTests:

  • fast/dom/subtree-modified-attributes-expected.txt: Added.
  • fast/dom/subtree-modified-attributes.html: Added.
18:08 Changeset [110924] by leviw@chromium.org

Unreviewed gardening. Fixing Chromium expectations after we began falling back to the failing
expectation checked in in r110911.

  • platform/chromium/platform/chromium/virtual: Added.
  • platform/chromium/platform/chromium/virtual/gpu: Added.
  • platform/chromium/platform/chromium/virtual/gpu/fast: Added.
  • platform/chromium/platform/chromium/virtual/gpu/fast/canvas: Added.
  • platform/chromium/platform/chromium/virtual/gpu/fast/canvas/webgl: Added.
  • platform/chromium/platform/chromium/virtual/gpu/fast/canvas/webgl/context-lost-expected.txt: Added.
17:55 Changeset [110923] by bfulgham@webkit.org

[WinCairo] Unreviewed build change after wtf path changes.

  • DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Updated include

directories to look at the private header directory to find 'wtf'.

17:52 Changeset [110922] by tkent@chromium.org

REGRESSION(r110595): webkit-patch suggest-reviewers doesn't work
https://bugs.webkit.org/show_bug.cgi?id=81293

Reviewed by Adam Barth.

r110595 introduced new format of the author field of ChangeLog entry:
"Adam Barth <abarth@webkit.org> && Benjamin Poulain <bpoulain@apple.com>"
Updte chanelog.py to support it.

  • Scripts/webkitpy/common/checkout/changelog.py:

(ChangeLogEntry._split_contributor_names):

  • Scripts/webkitpy/common/checkout/changelog_unittest.py:

(test_parse_authors):

17:45 Changeset [110921] by commit-queue@webkit.org

[chromium] Move overdraw metrics into a templated class for both paint and draw metrics.
https://bugs.webkit.org/show_bug.cgi?id=81156

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-15
Reviewed by Adrienne Walker.

Source/WebCore:

Creates CCOverdrawMetrics which can be called to inform it about
draws/paints. At the end of the frame, the CCOverdrawMetrics
recordMetrics() method will put its data into histograms, a
TRACE_COUNTER for culling information, and a TRACE_EVENT for details
about the number of opaque/translucent pixels.

Covered by existing tests.

  • WebCore.gypi:
  • platform/chromium/TraceEvent.h:

(TraceEvent):
(WebCore::TraceEvent::addTraceEvent):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):

  • platform/graphics/chromium/cc/CCOverdrawMetrics.cpp: Added.

(WebCore):
(WebCore::CCOverdrawMetrics::CCOverdrawMetrics):
(WebCore::wedgeProduct):
(WebCore::quadArea):
(WebCore::CCOverdrawMetrics::didDraw):
(WebCore::CCOverdrawMetrics::recordMetrics):
(WebCore::CCOverdrawMetrics::recordMetricsInternal):

  • platform/graphics/chromium/cc/CCOverdrawMetrics.h: Added.

(WebCore):
(CCOverdrawMetrics):
(WebCore::CCOverdrawMetrics::pixelsDrawnOpaque):
(WebCore::CCOverdrawMetrics::pixelsDrawnTranslucent):
(WebCore::CCOverdrawMetrics::pixelsCulled):

  • platform/graphics/chromium/cc/CCQuadCuller.cpp:

(WebCore::CCQuadCuller::CCQuadCuller):
(WebCore::CCQuadCuller::append):

  • platform/graphics/chromium/cc/CCQuadCuller.h:

(WebCore):
(CCQuadCuller):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::appendQuadsForLayer):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(WebCore):
(CCRenderPass):

Source/WebKit/chromium:

  • tests/CCQuadCullerTest.cpp:

(WebCore::appendQuads):
(WebCore):
(WebCore::TEST):

17:30 Changeset [110920] by jberlin@webkit.org

fast/events/pagehide-timeout.html, pageshow-pagehide-on-back-cached-with-frames.html, and
pageshow-pagehide-on-back-cached.html flakey on Lion Intel Debug WebKit testers
https://bugs.webkit.org/show_bug.cgi?id=81291

Skip these tests on mac-wk2 to get the bots green.

  • platform/mac-wk2/Skipped:
17:29 UsingGitHub edited by abarth@webkit.org
(diff)
17:28 Changeset [110919] by jamesr@google.com

[chromium] RateLimiter should hold a reference to its context
https://bugs.webkit.org/show_bug.cgi?id=80761

Reviewed by Stephen White.

  • platform/graphics/chromium/RateLimiter.h:

(RateLimiter):

17:27 UsingGitHub edited by abarth@webkit.org
(diff)
17:27 UsingGitHub edited by abarth@webkit.org
(diff)
17:20 Changeset [110918] by adamk@chromium.org

Share code in FormAssociatedElement by resetting the form owner whenever insertedIntoTree is called
https://bugs.webkit.org/show_bug.cgi?id=81160

Reviewed by Kent Tamura.

Source/WebCore:

The only difference between the previous insertedIntoTree method and
resetFormOwner was a missing element->inDocument() check in the
former. But that check is actually important, as seen by the included test case.

Test: fast/forms/form-attribute-not-in-document.html

  • html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::insertedIntoTree):

LayoutTests:

  • fast/forms/form-attribute-not-in-document-expected.txt: Added.
  • fast/forms/form-attribute-not-in-document.html: Added.
17:17 Changeset [110917] by dino@apple.com

webgl/framebuffer-object-attachment failing on lion
https://bugs.webkit.org/show_bug.cgi?id=81290

Unreviewed. Adding the failing results to platform/mac.

  • platform/mac-snowleopard/fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Added.
  • platform/mac/fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Added.
17:16 Changeset [110916] by timothy_horton@apple.com

canvas/philip/tests/2d.line.cap.round.html fails on Mac Lion WK1
https://bugs.webkit.org/show_bug.cgi?id=81289
<rdar://problem/11059777>

Unreviewed skip of flaky test canvas/philip/tests/2d.line.cap.round.html.

  • platform/mac/Skipped:
17:13 UsingGitHub edited by abarth@webkit.org
(diff)
17:12 UsingGitHub edited by abarth@webkit.org
(diff)
17:11 Changeset [110915] by haraken@chromium.org

[Refactoring] Rename StringBuilder variables in MarkupAccumulator.{h,cpp}
https://bugs.webkit.org/show_bug.cgi?id=81288

Reviewed by Adam Barth.

This is a refactoring for fixing bug 81214. Currently MarkupAccumulator mixes
'out' and 'result' for variable names of StringBuilder. This patch unifies them
to 'result'.

No tests. No change in behavior.

  • editing/MarkupAccumulator.cpp: Renamed 'out' to 'result'.

(WebCore::appendCharactersReplacingEntities):
(WebCore::MarkupAccumulator::serializeNodes): Renamed 'node' to 'targetNode' for clarification
(and for avoiding style check error in MarkupAccumulator.h).
(WebCore::MarkupAccumulator::concatenateMarkup):
(WebCore::MarkupAccumulator::appendNodeValue):
(WebCore::MarkupAccumulator::shouldAddNamespaceAttribute):
(WebCore::MarkupAccumulator::appendNamespace):
(WebCore::MarkupAccumulator::entityMaskForText):
(WebCore::MarkupAccumulator::appendText):
(WebCore::MarkupAccumulator::appendComment):
(WebCore::MarkupAccumulator::appendProcessingInstruction):
(WebCore::MarkupAccumulator::appendElement):
(WebCore::MarkupAccumulator::appendOpenTag):
(WebCore::MarkupAccumulator::appendCloseTag):
(WebCore::MarkupAccumulator::appendAttribute):
(WebCore::MarkupAccumulator::appendCDATASection):
(WebCore::MarkupAccumulator::elementCannotHaveEndTag):

  • editing/MarkupAccumulator.h: Removed redundant variable names.

(MarkupAccumulator):
(WebCore):

17:11 Changeset [110914] by lforschler@apple.com

Merged r110818.

17:10 UsingGitHub edited by abarth@webkit.org
(diff)
17:09 UsingGitHub edited by abarth@webkit.org
(diff)
17:07 UsingGitHub edited by abarth@webkit.org
(diff)
17:06 UsingGitHub edited by abarth@webkit.org
(diff)
17:05 UsingGitHub edited by abarth@webkit.org
(diff)
16:58 Changeset [110913] by commit-queue@webkit.org

Make the array pointer parameters in the Typed Array create() methods const.
https://bugs.webkit.org/show_bug.cgi?id=81147

Patch by David Dorwin <ddorwin@chromium.org> on 2012-03-15
Reviewed by Kenneth Russell.

This allows const arrays to be passed to these methods.
They use PassRefPtr<Subclass> create(), which already has a const parameter.

  • wtf/Int16Array.h:

(Int16Array):
(WTF::Int16Array::create):

  • wtf/Int32Array.h:

(Int32Array):
(WTF::Int32Array::create):

  • wtf/Int8Array.h:

(Int8Array):
(WTF::Int8Array::create):

  • wtf/Uint16Array.h:

(Uint16Array):
(WTF::Uint16Array::create):

  • wtf/Uint32Array.h:

(Uint32Array):
(WTF::Uint32Array::create):

  • wtf/Uint8Array.h:

(Uint8Array):
(WTF::Uint8Array::create):

  • wtf/Uint8ClampedArray.h:

(Uint8ClampedArray):
(WTF::Uint8ClampedArray::create):

16:54 Changeset [110912] by andersca@apple.com

Try to fix the Snow Leopard build.

  • UIProcess/API/mac/PDFViewController.mm:

(WebKit::PDFViewController::pdfKitBundle):

16:54 Changeset [110911] by dino@apple.com

webgl/context-lost failing on Lion
https://bugs.webkit.org/show_bug.cgi?id=81284

Unreviewed. Adding the failing results to platform/mac.

  • platform/mac-snowleopard/fast/canvas/webgl/context-lost-expected.txt: Added.
  • platform/mac/fast/canvas/webgl/context-lost-expected.txt: Added.
16:47 Changeset [110910] by bfulgham@webkit.org

[WinCairo] Correct <wtf/*.h> include paths.
https://bugs.webkit.org/show_bug.cgi?id=81278

Reviewed by Eric Seidel.

Modify the #include declarations for several Cairo-related files
so that the wtf types are included using the full path.

  • platform/graphics/FontPlatformData.h:
  • platform/graphics/cairo/OwnPtrCairo.h:
  • platform/graphics/cairo/RefPtrCairo.h:
16:44 UsingGitHub edited by abarth@webkit.org
(diff)
16:44 Changeset [110909] by commit-queue@webkit.org

Implement LayoutTestController::setValueForUser on Windows https://bugs.webkit.org/show_bug.cgi?id=55834

Tools:

Implemented setValueForUser in both DumpRenderTree and WebKitTestRunner.

Patch by Lynn Neir <lynn.neir@skype.net> on 2012-03-15
Reviewed by Jessie Berlin.

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::setValueForUser):

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::setValueForUser):
(WTR):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(LayoutTestController):

LayoutTests:

removed test, no longer needed as test passes and matches baseline expected results and also updated wk2 skipped file to no longer skip this test.

Patch by Lynn Neir <lynn.neir@skype.net> on 2012-03-15
Reviewed by Jessie Berlin.

  • platform/win/fast/forms/onchange-setvalueforuser-expected.txt: Removed.
  • platform/wk2/Skipped:
16:42 UsingGitHub edited by abarth@webkit.org
(diff)
16:39 UsingGitHub edited by abarth@webkit.org
(diff)
16:30 Changeset [110908] by andersca@apple.com

only some tiles rendered when zoomed in
https://bugs.webkit.org/show_bug.cgi?id=81282
<rdar://problem/11058898>

Reviewed by Andreas Kling.

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::rectForTileIndex):
Make sure that the tile cache bounds are scaled accordingly.

16:28 Changeset [110907] by zeno.albisser@nokia.com

[Qt] RenderThemeQt::fileListNameForWidth should override function in base class RenderTheme. (r110560)
https://bugs.webkit.org/show_bug.cgi?id=81107

Add "bool multipleFilesAllowed" to the parameter list of RenderThemeQt::fileListNameForWidth.
This way the base class function is properly overridden.
The need for this change became obvious after r110560 where the OVERRIDE keyword had been
added to the function signature.

Reviewed by Simon Hausmann.

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::fileListNameForWidth):

  • platform/qt/RenderThemeQt.h:

(RenderThemeQt):

16:27 UsingGitHub edited by abarth@webkit.org
(diff)
16:27 UsingGitHub edited by abarth@webkit.org
(diff)
16:26 UsingGitHub created by abarth@webkit.org
16:21 Changeset [110906] by jberlin@webkit.org

Selection is not collapsed in some WK2 editing tests
https://bugs.webkit.org/show_bug.cgi?id=69889

Add some expected failing results for mac-wk2 to get the bots green.

  • platform/mac-wk2/editing/selection/caret-ltr-right-expected.txt: Added.
  • platform/mac-wk2/editing/selection/caret-rtl-right-expected.txt: Added.
16:17 Changeset [110905] by yutak@chromium.org

[Qt] Change default WebSocket protocol to the latest one
https://bugs.webkit.org/show_bug.cgi?id=73630

Reviewed by Simon Hausmann.

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):
Use RFC6455 WebSocket protocol by default.

16:11 Changeset [110904] by abarth@webkit.org

Update the start-queue.sh script to match what we're using on the bots
https://bugs.webkit.org/show_bug.cgi?id=81277

Reviewed by Eric Seidel.

Over time we've added more magic git commands to clean up the local repo after
it has been borked in various ways. The idea behind this sequence is to clear
out any changes in the working copy and then to rebuild the master branch from
origin/master.

This patch also removes the watchdog timer that we've stopped using on the
bots.

This patch was reviewed on <https://github.com/eseidel/webkit/pull/1>.
Note: Eric and I are experimenting with GitHub to see if it might be
useful for WebKit. If you have thoughts on this topic, please feel
free to grab Eric or me on #webkit to chat. I assume that he and I are
the only ones who care about this file so using this alternative
process for this patch shouldn't cause any trouble.

  • EWSTools/start-queue.sh:
16:07 Changeset [110903] by jonlee@apple.com

Move NotificationContents into Notification
https://bugs.webkit.org/show_bug.cgi?id=80487
<rdar://problem/10965519>

Reviewed by Jian Li.

Source/WebCore:

  • notifications/Notification.cpp: Alter signature of constructor to take the fields directly instead of

a NotificationContents instance.
(WebCore::Notification::Notification): Derive KURL from string representation of icon.
(WebCore::Notification::create):

  • notifications/Notification.h:

(Notification): Remove contents() accessor and replace with get for title and body. iconURL()
already existed, but use local variable instead of going through NotificationContents.
(WebCore::Notification::iconURL):
(WebCore::Notification::title):
(WebCore::Notification::body):

  • notifications/NotificationCenter.h:

(WebCore::NotificationCenter::createNotification): Refactor to use new constructor.

  • notifications/NotificationContents.h: Removed.

Remove NotificationContents.h from project files

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit/chromium:

Refactor to use accessor methods on Notification.

  • src/WebNotification.cpp:

(WebKit::WebNotification::title):
(WebKit::WebNotification::body):

Source/WebKit/mac:

  • WebView/WebNotification.mm: Refactor to use accessor methods on Notification.

(-[WebNotification title]):
(-[WebNotification body]):

Source/WebKit/qt:

Refactor to use accessor methods on Notification.

  • WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationWrapper::title):
(WebCore::NotificationWrapper::message):
(WebCore::NotificationPresenterClientQt::displayNotification):
(WebCore::NotificationPresenterClientQt::cancel):
(WebCore::NotificationPresenterClientQt::notificationClicked):
(WebCore::NotificationPresenterClientQt::dumpReplacedIdText):
(WebCore::NotificationPresenterClientQt::dumpShowText):

Source/WebKit2:

  • UIProcess/Notifications/WebNotificationManagerProxy.cpp: Remove extraneous include.
  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::show): Refactor to use accessor methods on Notification.

16:04 Changeset [110902] by commit-queue@webkit.org

CopiedSpace::tryAllocateOversize assumes system page size
https://bugs.webkit.org/show_bug.cgi?id=80615

Patch by Myles Maxfield <mmaxfield@google.com> on 2012-03-15
Reviewed by Geoffrey Garen.

  • heap/CopiedSpace.cpp:

(JSC::CopiedSpace::tryAllocateOversize):

  • heap/CopiedSpace.h:

(CopiedSpace):

  • heap/CopiedSpaceInlineMethods.h:

(JSC::CopiedSpace::oversizeBlockFor):

  • wtf/BumpPointerAllocator.h:

(WTF::BumpPointerPool::create):

  • wtf/StdLibExtras.h:

(WTF::roundUpToMultipleOf):

15:50 Changeset [110901] by mhahnenberg@apple.com

Fixing Windows build breakage

15:48 Changeset [110900] by abarth@webkit.org

The commit-queue can hang when the test_expectations.txt style check fails during commit
https://bugs.webkit.org/show_bug.cgi?id=81251

Reviewed by Eric Seidel.

We forgot to check the --non-interactive flag, so we end up prompting
the "user" who doesn't exist on the bot. We might consider teaching
the User class about non-interactive if we have this sort of bug again.

  • Scripts/webkitpy/tool/steps/commit.py:

(Commit.options):
(Commit._check_test_expectations):
(Commit.run):

  • Scripts/webkitpy/tool/steps/commit_unittest.py:

(CommitTest.test_check_test_expectations):

15:44 Changeset [110899] by jonlee@apple.com

Deprecate ondisplay()
https://bugs.webkit.org/show_bug.cgi?id=80483
<rdar://problem/10912432>

Reviewed by Jian Li.

Source/WebCore:

The appropriate event listener for notifications is onshow().

  • notifications/Notification.h: Wrap ondisplay in ENABLE(LEGACY_NOTIFICATIONS).
  • notifications/Notification.idl: Wrap ondisplay in ENABLE_LEGACY_NOTIFICATIONS.

Source/WebKit/chromium:

  • src/WebNotification.cpp:

(WebKit::WebNotification::dispatchDisplayEvent): Dispatch the show event.

15:31 Changeset [110898] by wjmaclean@chromium.org

[chromium] Wire up PlatformGestureCurves for CC, ScrollAnimatorNone.
https://bugs.webkit.org/show_bug.cgi?id=80607

Reviewed by James Robinson.

Source/WebCore:

Unit tests added. Layout tests to follow.

Provides implementation of PlatformGestureCurves in Chrome Compositor, and basic
support in ScrollAnimatorNone, for fling gestures.

  • GNUmakefile.list.am:
  • platform/ActivePlatformGestureAnimation.cpp:

(WebCore::ActivePlatformGestureAnimation::create):
(WebCore::ActivePlatformGestureAnimation::ActivePlatformGestureAnimation):
(WebCore::ActivePlatformGestureAnimation::animate):

  • platform/ActivePlatformGestureAnimation.h:

(ActivePlatformGestureAnimation):

  • platform/PlatformGestureCurveTarget.h:

(PlatformGestureCurveTarget):

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::cancelAnimations):
(WebCore::ScrollAnimatorNone::animationTimerFired):
(WebCore::ScrollAnimatorNone::scrollBy):
(WebCore):

  • platform/ScrollAnimatorNone.h:

(WebCore):
(ScrollAnimatorNone):

  • platform/TouchFlingPlatformGestureCurve.cpp:

(WebCore::TouchFlingPlatformGestureCurve::apply):

  • platform/WheelFlingPlatformGestureCurve.cpp:

(WebCore::WheelFlingPlatformGestureCurve::apply):

  • platform/graphics/chromium/cc/CCActiveGestureAnimation.cpp:

(WebCore::CCActiveGestureAnimation::create):
(WebCore::CCActiveGestureAnimation::CCActiveGestureAnimation):
(WebCore::CCActiveGestureAnimation::animate):

  • platform/graphics/chromium/cc/CCActiveGestureAnimation.h:

(CCActiveGestureAnimation):

  • platform/graphics/chromium/cc/CCGestureCurve.h:

(CCGestureCurveTarget):

  • platform/graphics/chromium/cc/CCInputHandler.h:

(WebCore):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::animate):
(WebCore::CCLayerTreeHostImpl::setActiveGestureAnimation):
(WebCore):
(WebCore::CCLayerTreeHostImpl::animateGestures):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore):
(WebCore::CCLayerTreeHostImpl::activeGestureAnimation):
(CCLayerTreeHostImpl):

Source/WebKit/chromium:

  • public/WebInputEvent.h:

(WebKit::WebInputEvent::isScrollGestureEventType):

  • src/WebCompositorInputHandlerImpl.cpp:

(PlatformGestureToCCGestureAdapter):
(WebCore::PlatformGestureToCCGestureAdapter::create):
(WebCore::PlatformGestureToCCGestureAdapter::apply):
(WebCore::PlatformGestureToCCGestureAdapter::scrollBy):
(WebCore::PlatformGestureToCCGestureAdapter::PlatformGestureToCCGestureAdapter):
(WebCore):
(WebKit::WebCompositorInputHandlerImpl::handleInputEvent):
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
(WebKit):
(WebKit::WebCompositorInputHandlerImpl::scrollBy):

  • src/WebCompositorInputHandlerImpl.h:

(WebCore):
(WebCompositorInputHandlerImpl):

  • tests/PlatformGestureCurveTest.cpp:
  • tests/WebCompositorInputHandlerImplTest.cpp:
15:22 Changeset [110897] by bfulgham@webkit.org

Unreviewed build correction. WinCairo export definitions
file was not updated when the main Apple file was changed.

  • win/WebKit2CFLite.def: Revise export declarations to match

new symbol names.

15:17 Changeset [110896] by paroga@webkit.org

[EFL] Make zlib a general build requirement
https://bugs.webkit.org/show_bug.cgi?id=80153

Reviewed by Hajime Morita.

After r109538 WebSocket module needs zlib to support deflate-frame extension.

.:

  • Source/cmake/OptionsEfl.cmake:

Source/JavaScriptCore:

  • wtf/Platform.h:

Source/WebCore:

  • PlatformEfl.cmake:
15:16 Changeset [110895] by schenney@chromium.org

[Chromium] Cleanup of outdated test expectations
https://bugs.webkit.org/show_bug.cgi?id=81253

Unreviewed chromium expectations.

  • platform/chromium/test_expectations.txt: Adding Linux svg/text/text-tselect-02.f.svg
15:14 Changeset [110894] by rwlbuis@webkit.org

[BlackBerry] Remove some features that we do not have anymore
https://bugs.webkit.org/show_bug.cgi?id=81274

Reviewed by Antonio Gomes.

Remove some features that we do not have anymore, code was removed some time ago.

  • Source/cmake/OptionsBlackBerry.cmake:
15:13 Changeset [110893] by commit-queue@webkit.org

REGRESSION (r110371): broke platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html
https://bugs.webkit.org/show_bug.cgi?id=80825

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-15
Reviewed by James Robinson.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleWheelEvent): Corrected a typo.

15:09 Changeset [110892] by timothy_horton@apple.com

Remove mac-future results
https://bugs.webkit.org/show_bug.cgi?id=81275

There should never be anything in LayoutTests/platform/mac-future.
Please don't put anything there in the future.

Rubber-stamped by Alexey Proskuryakov.

  • platform/mac-future/css1: Removed.
  • platform/mac-future/css1/font_properties: Removed.
  • platform/mac-future/css1/font_properties/font-expected.png: Removed.
  • platform/mac-future/css2.1: Removed.
  • platform/mac-future/css2.1/t1508-c527-font-05-b-expected.png: Removed.
  • platform/mac-future/css2.1/t1508-c527-font-10-c-expected.png: Removed.
  • platform/mac-future/fast: Removed.
  • platform/mac-future/fast/css: Removed.
  • platform/mac-future/fast/css/font-family-pictograph-expected.png: Removed.
  • platform/mac-future/fast/css/font-family-pictograph-expected.txt: Removed.
  • platform/mac-future/fast/dom: Removed.
  • platform/mac-future/fast/dom/52776-expected.txt: Removed.
  • platform/mac-future/fast/forms: Removed.
  • platform/mac-future/fast/forms/listbox-bidi-align-expected.png: Removed.
  • platform/mac-future/fast/repaint: Removed.
  • platform/mac-future/fast/repaint/canvas-putImageData-expected.txt: Removed.
  • platform/mac-future/fast/text: Removed.
  • platform/mac-future/fast/text/capitalize-boundaries-expected.png: Removed.
  • platform/mac-future/fast/writing-mode: Removed.
  • platform/mac-future/fast/writing-mode/fallback-orientation-expected.png: Removed.
  • platform/mac-future/media: Removed.
  • platform/mac-future/media/video-display-toggle-expected.txt: Removed.
  • platform/mac-future/media/video-no-audio-expected.txt: Removed.
  • platform/mac-future/svg: Removed.
  • platform/mac-future/svg/W3C-I18N: Removed.
  • platform/mac-future/svg/W3C-SVG-1.1-SE: Removed.
  • platform/mac-future/svg/batik: Removed.
  • platform/mac-future/svg/batik/masking: Removed.
  • platform/mac-future/svg/batik/text: Removed.
  • platform/mac-future/svg/batik/text/textGlyphOrientationHorizontal-expected.png: Removed.
  • platform/mac-future/svg/carto.net: Removed.
  • platform/mac-future/svg/carto.net/scrollbar-expected.png: Removed.
  • platform/mac-future/svg/custom: Removed.
14:54 Changeset [110891] by benjamin@webkit.org

NumericStrings should be inlined
https://bugs.webkit.org/show_bug.cgi?id=81183

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-15
Reviewed by Gavin Barraclough.

NumericStrings is not always inlined. When it is not, the class is not faster
than using UString::number() directly.

  • runtime/NumericStrings.h:

(JSC::NumericStrings::add):
(JSC::NumericStrings::lookupSmallString):

14:46 Changeset [110890] by ap@apple.com

Move test results from mac-lion to mac
https://bugs.webkit.org/show_bug.cgi?id=81266

Reviewed by Jessie Berlin.

  • platform/mac-lion/canvas: Removed.
  • platform/mac-lion/canvas/philip: Removed.
  • platform/mac-lion/canvas/philip/tests: Removed.
  • platform/mac-lion/editing: Removed.
  • platform/mac-lion/editing/inserting: Removed.
  • platform/mac-lion/editing/inserting/break-blockquote-after-delete-expected.png: Removed.
  • platform/mac-lion/fast: Removed.
  • platform/mac-lion/fast/css: Removed.
  • platform/mac-lion/fast/css/font-family-pictograph-expected.txt: Removed.
  • platform/mac-lion/svg: Removed.
  • platform/mac-lion/svg/W3C-SVG-1.1-SE: Removed.
  • platform/mac-lion/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Removed.
  • platform/mac/editing/inserting/break-blockquote-after-delete-expected.png:
  • platform/mac/fast/css/font-family-pictograph-expected.txt: Copied from LayoutTests/platform/mac-lion/fast/css/font-family-pictograph-expected.txt.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
14:39 Changeset [110889] by jamesr@google.com

Fix crbug 117957 - get settings scrolling with the wheel again.
https://bugs.webkit.org/show_bug.cgi?id=81247

Patch by Scott Byer <scottbyer@chromium.org> on 2012-03-15
Reviewed by James Robinson.

Tests to follow.

  • page/FrameView.cpp:

(WebCore::FrameView::serviceScriptedAnimations):

14:33 Changeset [110888] by andersca@apple.com

REGRESSION(r107168?): Assertion failures under pageContainsAnyHorizontalScrollbars causing multiple "crashes" on the Lion Intel Debug WebKit2 testers
https://bugs.webkit.org/show_bug.cgi?id=81162
<rdar://problem/11050423>

Reviewed by Beth Dakin and Jessie Berlin.

Downgrade the ASSERT to a simple if check since scrollableArea->isOnActivePage() can return false when layout happens during page transitions.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::pageContainsAnyHorizontalScrollbars):

14:30 Changeset [110887] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=81258

Add a preference for enabling the new multi-column layout code that will be based on regions.

Reviewed by Beth Dakin.

Source/WebCore:

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setRegionBasedColumnsEnabled):
(WebCore::Settings::regionBasedColumnsEnabled):
(Settings):

Source/WebKit/mac:

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences setRegionBasedColumnsEnabled:]):
(-[WebPreferences regionBasedColumnsEnabled]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

  • Shared/WebPreferencesStore.h:

(WebKit):

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetRegionBasedColumnsEnabled):
(WKPreferencesGetRegionBasedColumnsEnabled):

  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

14:24 Changeset [110886] by kling@webkit.org

RenderStyle: Return Color objects by value instead of as const references.
<http://webkit.org/b/81180>

Reviewed by Antti Koivisto.

Make RenderStyle getters return "Color" rather than "const Color&". This is preparation
for storing some color values in a more space-efficient fashion.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyColor::applyInheritValue):

  • page/animation/AnimationBase.cpp:

(PropertyWrapperColor):
(WebCore::PropertyWrapperColor::PropertyWrapperColor):
(WebCore::PropertyWrapperColor::blend):
(WebCore::PropertyWrapperMaybeInvalidColor::PropertyWrapperMaybeInvalidColor):
(PropertyWrapperMaybeInvalidColor):
(WebCore::PropertyWrapperVisitedAffectedColor::PropertyWrapperVisitedAffectedColor):
(WebCore::PropertyWrapperSVGPaint::PropertyWrapperSVGPaint):
(PropertyWrapperSVGPaint):

  • platform/graphics/Color.h:

(WebCore::Color::Color):

  • rendering/style/RenderStyle.h:
14:16 Changeset [110885] by andersca@apple.com

Can't swipe to go back/forward when the current page is a PDF document
https://bugs.webkit.org/show_bug.cgi?id=81194
<rdar://problem/6954125>

Reviewed by Sam Weinig.

Override -[PDFViewScrollView scrollWheel:] and have the new implementation call
-[WKPDFView forwardScrollWheelEvent:] when the PDF is pinned to either the left or right side.
WKPDFView will then call PDFController::forwardScrollWheelEvent which checks if we can go back or forward,
and passes the event along to the WKView which ends up triggering the swiping machinery in Safari.

  • UIProcess/API/mac/PDFViewController.h:
  • UIProcess/API/mac/PDFViewController.mm:

(-[WKPDFView forwardScrollWheelEvent:]):
(WebKit):
(WebKit::PDFViewController::forwardScrollWheelEvent):
(WebKit::findEnclosingWKPDFView):
(WebKit::PDFViewScrollView_scrollWheel):
(WebKit::PDFViewController::pdfKitBundle):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didCommitLoadForFrame):

14:07 Changeset [110884] by jberlin@webkit.org

Assertion failures in WebCore::Page::goBackOrForward causing multiple "crashes" on Lion Intel
Debug WebKit2 testers
https://bugs.webkit.org/show_bug.cgi?id=81159

Rubber-stamped by Brady Eidson.

It is plausible that history could change in between the time a navigation request is
scheduled and the timer is fired, so the request index could be out of the b/f list range.
Hence, the assertion is invalid and should be removed.

  • page/Page.cpp:

(WebCore::Page::goBackOrForward):

14:07 Changeset [110883] by jberlin@webkit.org

fast/dom/Window/window-properties.html and fast/dom/prototype-inheritance-2.html failing on
Mac WK2 because WebAudio is not enabled
https://bugs.webkit.org/show_bug.cgi?id=81259

Reviewed by Dan Bernstein.

Enable WebAudio so that it appears in the window object in the tests.
The webaudio tests are all still skipped in the Mac Skipped list.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

14:07 Changeset [110882] by ap@apple.com

Assertion failures in checkEncodedString when running WebKit2 tests
https://bugs.webkit.org/show_bug.cgi?id=67425
<rdar://problem/11043492>

Reviewed by Anders Carlsson.

  • platform/network/cf/ResourceErrorCF.cpp: (WebCore::ResourceError::cfError):
  • platform/network/mac/ResourceErrorMac.mm: (WebCore::ResourceError::nsError): The failing URL is certainly not guaranteed to be valid, so it's not correct to put it back into a URL as if it's been normalized by KURL.
13:39 Changeset [110881] by abecsi@webkit.org

Fix ARM build after r110792.

Unreviewed build fix.

  • jit/ExecutableAllocator.h:

(JSC::ExecutableAllocator::cacheFlush):
Remove superfluous curly brackets.

13:23 Changeset [110880] by beidson@apple.com

<rdar://problem/11036900> and https://bugs.webkit.org/show_bug.cgi?id=81079 REGRESSION(r107844): Clipboard API only remembers most recent data set on clipboard

Reviewed by Sam Weinig.

Source/WebCore:

Test: editing/pasteboard/copy-two-pasteboard-types-both-work.html

Add the non-destructive "addTypes" to supplement the destructive "setTypes"

  • platform/PasteboardStrategy.h:

(PasteboardStrategy):

  • platform/PlatformPasteboard.h:

(PlatformPasteboard):

  • platform/mac/PlatformPasteboardMac.mm:

(WebCore::PlatformPasteboard::addTypes):

  • WebCore.exp.in:
  • platform/mac/ClipboardMac.mm:

(WebCore::ClipboardMac::setData): Call the non-destructive "addTypes" instead of

the destructive "setTypes"

Source/WebKit/mac:

Add the non-destructive "addTypes" to supplement the destructive "setTypes"

  • WebCoreSupport/WebPlatformStrategies.h:
  • WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::addTypes):

Source/WebKit2:

Add the non-destructive "addTypes" to supplement the destructive "setTypes"

  • UIProcess/WebContext.h:
  • UIProcess/WebContext.messages.in:
  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::addPasteboardTypes):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::addTypes):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:

LayoutTests:

  • editing/pasteboard/copy-two-pasteboard-types-both-work-expected.txt: Added.
  • editing/pasteboard/copy-two-pasteboard-types-both-work.html: Added.
13:09 Changeset [110879] by leviw@chromium.org

Unreviewed gardening. New flaky tests and new failure modes for old flaky tests.

  • platform/chromium/test_expectations.txt:
13:06 Changeset [110878] by commit-queue@webkit.org

[Chromium] REGRESSION(r110596) CCQuadCullerTest.verifyCullChildLinesUpTopLeft fails on Windows
https://bugs.webkit.org/show_bug.cgi?id=81083

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-15
Reviewed by Adrienne Walker.

Source/WebCore:

The surface pointer on the occlusion tracker stack is uninitialized, and
can be non-null, but the layer's target surface is null, causing asserts
to fail. Fixes the TestCCOcclusionTrackerImpl to initialize the stack's
surface to be null.

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::enterTargetRenderSurface):
(WebCore::::unoccludedContentRect):

  • platform/graphics/chromium/cc/CCOcclusionTracker.h:

(WebCore::CCOcclusionTrackerBase::StackObject::StackObject):

Source/WebKit/chromium:

  • tests/CCQuadCullerTest.cpp:

(WebCore::TEST):

13:06 Changeset [110877] by barraclough@apple.com

ARMv7: prefer vmov(gpr,gpr->double) over vmov(gpr->single)
https://bugs.webkit.org/show_bug.cgi?id=81256

Reviewed by Oliver Hunt.

This is a 0.5% sunspider progression.

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::convertInt32ToDouble):

  • switch which form of vmov we use.
12:55 Changeset [110876] by commit-queue@webkit.org

[EFL] Add OwnPtr specialization for Ecore_Timer.
https://bugs.webkit.org/show_bug.cgi?id=80119

Patch by YoungTaeck Song <youngtaeck.song@samsung.com> on 2012-03-15
Reviewed by Hajime Morita.

Add an overload for deleteOwnedPtr(Ecore_Timer*) on EFL port.

  • wtf/OwnPtrCommon.h:

(WTF):

  • wtf/efl/OwnPtrEfl.cpp:

(WTF::deleteOwnedPtr):
(WTF):

12:54 Changeset [110875] by levin@chromium.org

Various autoresize fixes.
https://bugs.webkit.org/show_bug.cgi?id=81199

Reviewed by Darin Fisher.

Source/WebCore:

Tested by WebViewTest additions.

  • page/FrameView.cpp:

(WebCore::FrameView::autoSizeIfEnabled): Fixed a bug that caused a horizontal
scrollbar to appear when the size was width was fixed and height overflowed which
is one of the tests that was added.

Source/WebKit/chromium:

  • public/WebView.h:

(WebView): Remove a deprecated api.

  • src/WebViewImpl.cpp: Ditto.
  • src/WebViewImpl.h: Ditto.
  • tests/FrameTestHelpers.cpp:

(WebKit::FrameTestHelpers::registerMockedURLLoad): Added an overload with more flexibility.
The previous api didn't allow one to request a url with a search string.
(FrameTestHelpers):

  • tests/FrameTestHelpers.h:

(FrameTestHelpers): Ditto.

  • tests/WebViewTest.cpp: Fix the test because calling javascript:

was working. Make the test generic and added a lot more tests to cover
various possibilities. I avoided using a layout test because there wasn't
a way to get the scrollbar state, so I just generalized a test that was already there.

  • tests/data/specify_size.html: Allow the test to take its size from the search string.

Tools:

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::reset): Stop using the deprecated api that was removed.

12:54 Changeset [110874] by commit-queue@webkit.org

Linux has madvise enough to support OSAllocator::commit/decommit
https://bugs.webkit.org/show_bug.cgi?id=80505

Patch by Hojong Han <hojong.han@samsung.com> on 2012-03-15
Reviewed by Geoffrey Garen.

  • wtf/OSAllocatorPosix.cpp:

(WTF::OSAllocator::reserveUncommitted):
(WTF::OSAllocator::commit):
(WTF::OSAllocator::decommit):

12:33 Changeset [110873] by caseq@chromium.org

Web Inspector: normalize vertical overview bars by longest bar, not by longest frame
https://bugs.webkit.org/show_bug.cgi?id=81231

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype.reset):
(WebInspector.TimelineOverviewPane.prototype.accept):
(WebInspector.TimelineOverviewPane.prototype.windowEndTime):
(WebInspector.TimelineVerticalOverview.prototype.reset):
(WebInspector.TimelineVerticalOverview.prototype.update):
(WebInspector.TimelineVerticalOverview.prototype._aggregateFrames):
(WebInspector.TimelineVerticalOverview.prototype._aggregateRecords):
(WebInspector.TimelineVerticalOverview.prototype.getWindowTimes):

12:29 Changeset [110872] by caseq@chromium.org

Web Inspector: crash in InspectorTimelineAgent when trying to add children to cancelable records
https://bugs.webkit.org/show_bug.cgi?id=81245

Reviewed by Vsevolod Vlasov.

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::addRecordToTimeline):
(WebCore):
(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
(WebCore::InspectorTimelineAgent::appendRecord):
(WebCore::InspectorTimelineAgent::commitCancelableRecords):

  • inspector/InspectorTimelineAgent.h:

(InspectorTimelineAgent):

12:17 Changeset [110871] by sfalken@apple.com

Windows build fix.

12:16 Changeset [110870] by schenney@chromium.org

Temporarily skip svg/custom/delete-text-crash.html on mac and win
https://bugs.webkit.org/show_bug.cgi?id=81006

Unreviewed update of expectations.

Patch by Philip Rogers <pdr@google.com> on 2012-03-15

  • platform/mac/Skipped:
  • platform/win/Skipped:
12:10 Changeset [110869] by schenney@chromium.org

[Chromium] Cleanup of outdated test expectations
https://bugs.webkit.org/show_bug.cgi?id=81253

Unreviewed chromium test expectations update.

  • platform/chromium/test_expectations.txt: Updated bug numbers or removed several SVG-related expectations.
11:55 Changeset [110868] by podivilov@chromium.org

Web Inspector: live locations could be disposed twice.
https://bugs.webkit.org/show_bug.cgi?id=81249

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/ScriptMapping.js:

(WebInspector.MainScriptMapping.prototype._unregisterLiveLocation):

11:45 Changeset [110867] by timothy_horton@apple.com

Unreviewed rebaseline of canvas/philip/tests/2d.line.cap.round; the platform
independent results are correct for mac now, so remove the specific ones.

  • platform/mac-snowleopard/canvas/philip/tests/2d.line.cap.round-expected.txt: Removed.
  • platform/mac/canvas/philip/tests/2d.line.cap.round-expected.txt: Removed.
11:31 Changeset [110866] by carlosgc@webkit.org

[GTK] Actually use --release and --debug command line options in run-gtk-test
https://bugs.webkit.org/show_bug.cgi?id=81234

Reviewed by Philippe Normand.

Actually handle --release and --debug command line options to
create the build directory, falling back to current hack to detect
whether it's a Release or Debug build when both options are missed.

  • Scripts/run-gtk-tests:

(TestRunner.init): Receive options too.
(TestRunner._get_top_level_directory): Helper function to get the
top level directory.
(TestRunner._get_build_directory): Helper function to get the
build directory depending on --release/--debug command line
options or gessing it if both options are missing.
(TestRunner._ensure_accessibility_daemon_is_running): Use
self-options now.
(TestRunner.run): Ditto.
(TestRunner.run.run_tests): Pass options to the constructor
instead of run().

11:28 Changeset [110865] by carlosgc@webkit.org

[GTK] Implement unicode submenu items
https://bugs.webkit.org/show_bug.cgi?id=81117

Reviewed by Martin Robinson.

Source/WebCore:

  • loader/EmptyClients.h:

(WebCore::EmptyEditorClient::shouldShowUnicodeMenu): Just return
false.

  • page/ContextMenuController.cpp:

(WebCore::insertUnicodeCharacter): Helper function to insert a
unicode character.
(WebCore::ContextMenuController::contextMenuItemSelected):
Implement unicode menu items using insertUnicodeCharacter() to
insert the apropriate unicode character.
(WebCore::ContextMenuController::createAndAppendUnicodeSubMenu):
Create the unicode submenu.
(WebCore::ContextMenuController::populate): Add unicode submenu
item for editable content.
(WebCore::ContextMenuController::checkOrEnableIfNeeded): Add
unicode submenu items to the switch.

  • page/ContextMenuController.h:
  • page/EditorClient.h:

(EditorClient): Add shouldShowUnicodeMenu() for GTK platform.

  • platform/ContextMenuItem.h:
  • platform/LocalizedStrings.h:
  • platform/gtk/LocalizedStringsGtk.cpp:

(WebCore::contextMenuItemTagUnicodeInsertLRMMark): Add localized
string for the unicode menu item.
(WebCore::contextMenuItemTagUnicodeInsertRLMMark): Ditto.
(WebCore::contextMenuItemTagUnicodeInsertLREMark): Ditto.
(WebCore::contextMenuItemTagUnicodeInsertRLEMark): Ditto.
(WebCore::contextMenuItemTagUnicodeInsertLROMark): Ditto.
(WebCore::contextMenuItemTagUnicodeInsertRLOMark): Ditto.
(WebCore::contextMenuItemTagUnicodeInsertPDFMark): Ditto.
(WebCore::contextMenuItemTagUnicodeInsertZWSMark): Ditto.
(WebCore::contextMenuItemTagUnicodeInsertZWJMark): Ditto.
(WebCore::contextMenuItemTagUnicodeInsertZWNJMark): Ditto.

Source/WebKit/gtk:

  • WebCoreSupport/ContextMenuClientGtk.cpp:

(WebKit::getUnicodeMenuItemPosition): Helper function to get the
position of the unicode menu item in the default context menu.
(WebKit::ContextMenuClient::getCustomMenuFromDefaultItems): Remove
code to build the unicode menu, since it's now built by WebCore.

  • WebCoreSupport/EditorClientGtk.cpp:

(WebKit::EditorClient::shouldShowUnicodeMenu): Check whether
unicode menu should be shown based on gtk-show-unicode-menu GtkSetting.

  • WebCoreSupport/EditorClientGtk.h:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebEditorClient.h:
  • WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:

(WebKit::WebEditorClient::shouldShowUnicodeMenu): Implement
shouldShowUnicodeMenu() returning always true. When ContextMenu
API is implemented for GTK+ the UI process will decide whether to
show the unicode menu or not.

11:26 Changeset [110864] by vsevik@chromium.org

Web Inspector: MainScriptMapping should detect snippet scripts by means of sourceURL set before evaluation.
https://bugs.webkit.org/show_bug.cgi?id=81031

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/SnippetsModel.js:

(WebInspector.SnippetsModel):
(WebInspector.SnippetsModel.prototype._saveSettings):
(WebInspector.SnippetsModel.prototype.deleteSnippet):
(WebInspector.SnippetsModel.prototype._snippetAdded):
(WebInspector.SnippetsModel.prototype._sourceURLForSnippet):
(WebInspector.SnippetsModel.prototype.snippetIdForSourceURL):
(WebInspector.SnippetsModel.prototype.snippetForSourceURL):
(WebInspector.Snippet.prototype.evaluate):
(WebInspector.SnippetsScriptMapping):
(WebInspector.SnippetsScriptMapping.prototype.uiLocationToRawLocation.get if):
(WebInspector.SnippetsScriptMapping.prototype.uiLocationToRawLocation):
(WebInspector.SnippetsScriptMapping.prototype._releasedUISourceCodes):
(WebInspector.SnippetsScriptMapping.prototype._snippetAdded):
(WebInspector.SnippetsScriptMapping.prototype._snippetWillBeEvaluated):
(WebInspector.SnippetsScriptMapping.prototype._snippetRemoved.get this):
(WebInspector.SnippetsScriptMapping.prototype._snippetRemoved):

LayoutTests:

  • inspector/debugger/snippets-model-expected.txt:
  • inspector/debugger/snippets-model.html:
11:24 Changeset [110863] by sfalken@apple.com

Windows build fix.

11:24 Changeset [110862] by alexis.menard@openbossa.org

Fix the test failing with run-perf-tests.

Rubber stamped by Ryosuke Niwa.

  • CSS/CSSPropertySetterGetter.html:
11:15 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
10:51 WebKitGTK/1.8.x edited by sergio@webkit.org
(diff)
10:37 Changeset [110861] by carlosgc@webkit.org

[GTK] Run unit tests with --verbose in the bots
https://bugs.webkit.org/show_bug.cgi?id=81230

Reviewed by Martin Robinson.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunGtkAPITests): Add --verbose to run-gtk-test command.

10:32 Changeset [110860] by caryclark@google.com

migrate Yang Guo's expectations from chromium to webkit
https://bugs.webkit.org/show_bug.cgi?id=81026

Unreviewed test_expectations.

Patch by Elliot Poger <epoger@google.com> on 2012-03-15

  • platform/chromium/test_expectations.txt:
10:28 Changeset [110859] by kevino@webkit.org

Unreviewed. Fix typos in ChangeLog dates.

10:25 Changeset [110858] by kevino@webkit.org

Move wx port to using export macros
https://bugs.webkit.org/show_bug.cgi?id=77279

Reviewed by Hajime Morita.

10:14 Changeset [110857] by kevino@webkit.org

[wx] Unreviewed. Build fixes for Mac and DOM bindings.

09:55 Changeset [110856] by podivilov@chromium.org

Web Inspector: extract CompilerScriptMapping from RawSourceCode.
https://bugs.webkit.org/show_bug.cgi?id=81088

Reviewed by Vsevolod Vlasov.

Source/WebCore:

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/CompilerScriptMapping.js: Added.

(WebInspector.CompilerScriptMapping):
(WebInspector.CompilerScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.CompilerScriptMapping.prototype.get uiSourceCodeList):
(WebInspector.CompilerScriptMapping.prototype.addScript.get this):
(WebInspector.CompilerScriptMapping.prototype.addScript):
(WebInspector.CompilerScriptMapping.prototype.loadSourceMapForScript):
(WebInspector.CompilerScriptMapping.prototype.reset):

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.setFormatted):
(WebInspector.RawSourceCode.prototype._resourceFinished):
(WebInspector.RawSourceCode.prototype._createUISourceCode):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.rawLocationToUILocation):

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype.addScript):

  • inspector/front-end/ScriptMapping.js:

(WebInspector.MainScriptMapping):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:

LayoutTests:

  • http/tests/inspector/compiler-source-mapping-expected.txt:
  • http/tests/inspector/compiler-source-mapping.html:
  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest.):
(initialize_DebuggerTest):

  • inspector/debugger/raw-source-code-expected.txt:
  • inspector/debugger/raw-source-code.html:
09:52 Changeset [110855] by jberlin@webkit.org

css3/filters/custom/custom-filter-property-computed-style.html passes in browser, fails in DRT.
https://bugs.webkit.org/show_bug.cgi?id=81029

Land expected passing results for WKTR.

  • platform/mac-wk2/css3/filters/custom/custom-filter-property-computed-style-expected.txt: Added.
09:44 Changeset [110854] by yurys@chromium.org

Web Inspector: Move all includes behind ENABLE(INSPECTOR) guards
https://bugs.webkit.org/show_bug.cgi?id=81132

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-03-15
Reviewed by Yury Semikhatsky.

Include directives are moved several lines down in .cpp files and in
generator templates.

  • inspector/CodeGeneratorInspector.py:
  • inspector/ContentSearchUtils.cpp:
  • inspector/DOMEditor.cpp:
  • inspector/DOMNodeHighlighter.cpp:
  • inspector/DOMPatchSupport.cpp:
  • inspector/IdentifiersFactory.cpp:
  • inspector/InjectedScript.cpp:
  • inspector/InjectedScriptHost.cpp:
  • inspector/InjectedScriptManager.cpp:
  • inspector/InspectorAgent.cpp:
  • inspector/InspectorApplicationCacheAgent.cpp:
  • inspector/InspectorBaseAgent.cpp:
  • inspector/InspectorCSSAgent.cpp:
  • inspector/InspectorClient.cpp:
  • inspector/InspectorConsoleAgent.cpp:
  • inspector/InspectorController.cpp:
  • inspector/InspectorCounters.cpp:
  • inspector/InspectorDOMAgent.cpp:
  • inspector/InspectorDOMDebuggerAgent.cpp:
  • inspector/InspectorDOMStorageAgent.cpp:
  • inspector/InspectorDatabaseAgent.cpp:
  • inspector/InspectorDatabaseResource.cpp:
  • inspector/InspectorDebuggerAgent.cpp:
  • inspector/InspectorFileSystemAgent.cpp:
  • inspector/InspectorFrontendClientLocal.cpp:
  • inspector/InspectorFrontendHost.cpp:
  • inspector/InspectorHistory.cpp:
  • inspector/InspectorIndexedDBAgent.cpp:
  • inspector/InspectorInstrumentation.cpp:
  • inspector/InspectorMemoryAgent.cpp:
  • inspector/InspectorPageAgent.cpp:
  • inspector/InspectorProfilerAgent.cpp:
  • inspector/InspectorResourceAgent.cpp:
  • inspector/InspectorRuntimeAgent.cpp:
  • inspector/InspectorState.cpp:
  • inspector/InspectorStyleSheet.cpp:
  • inspector/InspectorStyleTextEditor.cpp:
  • inspector/InspectorTimelineAgent.cpp:
  • inspector/InspectorValues.cpp:
  • inspector/InstrumentingAgents.cpp:
  • inspector/NetworkResourcesData.cpp:
  • inspector/PageConsoleAgent.cpp:
  • inspector/PageDebuggerAgent.cpp:
  • inspector/PageRuntimeAgent.cpp:
  • inspector/TimelineRecordFactory.cpp:
  • inspector/WorkerConsoleAgent.cpp:
  • inspector/WorkerDebuggerAgent.cpp:
  • inspector/WorkerRuntimeAgent.cpp:
09:39 Changeset [110853] by yurys@chromium.org

Web Inspector: improve HeapSnapshot._buildReversIndex performance
https://bugs.webkit.org/show_bug.cgi?id=81224

Caching node indexes and node count in local variables instead of
calling getters each time reduces the method run time by
factor of 1.5

Reviewed by Pavel Feldman.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype._buildReverseIndex):

09:35 Changeset [110852] by leviw@chromium.org

Unreviewed gardening.

Updating slightly changed SVG animation text expectations post-110545.

  • platform/chromium-linux-x86/fast/repaint/moving-shadow-on-path-expected.txt: Removed.
  • platform/chromium-linux-x86/svg/css/stars-with-shadow-expected.txt: Removed.
  • platform/chromium-linux/fast/repaint/moving-shadow-on-container-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/css/stars-with-shadow-expected.txt: Added.
  • platform/chromium-mac/svg/css/stars-with-shadow-expected.txt: Added.
  • platform/chromium-win-vista/fast/repaint: Removed.
  • platform/chromium-win-xp/fast/repaint/moving-shadow-on-container-expected.txt: Added.
  • platform/chromium-win/fast/repaint/moving-shadow-on-container-expected.txt: Added.
  • platform/chromium/fast/repaint/moving-shadow-on-path-expected.txt: Replaced.
  • platform/chromium/svg/css/stars-with-shadow-expected.txt: Replaced.
09:03 Changeset [110851] by zimmermann@webkit.org

2012-03-15 Nikolas Zimmermann <nzimmermann@rim.com>

SVG Animations update baseVal instead of animVal
https://bugs.webkit.org/show_bug.cgi?id=12437

Rubber-stamped by Rob Buis.

Rename constructFromCopy to constructFromVariant, and currentBaseValue to currentBaseValueVariant, to clarify what it actually does.

  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::resetToBaseValue):
  • svg/SVGAnimatedLength.cpp: (WebCore::SVGAnimatedLengthAnimator::constructFromVariant):
  • svg/SVGAnimatedLength.h: (SVGAnimatedLengthAnimator):
  • svg/SVGAnimatedLengthList.cpp: (WebCore::SVGAnimatedLengthListAnimator::constructFromVariant):
  • svg/SVGAnimatedLengthList.h: (SVGAnimatedLengthListAnimator):
  • svg/SVGAnimatedNumber.cpp: (WebCore::SVGAnimatedNumberAnimator::constructFromVariant):
  • svg/SVGAnimatedNumber.h: (SVGAnimatedNumberAnimator):
  • svg/SVGAnimatedNumberList.cpp: (WebCore::SVGAnimatedNumberListAnimator::constructFromVariant):
  • svg/SVGAnimatedNumberList.h: (SVGAnimatedNumberListAnimator):
  • svg/SVGAnimatedTransformList.cpp: (WebCore::SVGAnimatedTransformListAnimator::constructFromVariant):
  • svg/SVGAnimatedTransformList.h: (SVGAnimatedTransformListAnimator):
  • svg/SVGAnimatedTypeAnimator.h: (WebCore::SVGAnimatedTypeAnimator::constructFromVariant):
  • svg/properties/SVGAnimatedListPropertyTearOff.h: (WebCore::SVGAnimatedListPropertyTearOff::currentBaseValueVariant):
  • svg/properties/SVGAnimatedProperty.h: (SVGAnimatedProperty):
  • svg/properties/SVGAnimatedPropertyTearOff.h: (WebCore::SVGAnimatedPropertyTearOff::currentBaseValueVariant):
  • svg/properties/SVGAnimatedStaticPropertyTearOff.h: (WebCore::SVGAnimatedStaticPropertyTearOff::currentBaseValueVariant):
08:58 Changeset [110850] by abecsi@webkit.org

[Qt][WK2] Fix bounce-back behaviour for panning
https://bugs.webkit.org/show_bug.cgi?id=81144

Reviewed by Kenneth Rohde Christiansen.

Move the content back to boundaries immediately
in response to a tap gesture during the bounce-back
animation after panning.

  • UIProcess/qt/QtPanGestureRecognizer.cpp:

(WebKit::QtPanGestureRecognizer::recognize):

  • UIProcess/qt/QtViewportInteractionEngine.h:

Make the ensureContentWithinViewportBoundary function public.
(QtViewportInteractionEngine):

08:36 Changeset [110849] by senorblanco@chromium.org

[chromium] Unreviewed gardening.

Updated Lion baselines for css3/filters. Skipped all custom tests,
and removed all baselines, since support is not currently compiled in.

  • platform/chromium-mac-leopard/css3/filters/custom: Removed.
  • platform/chromium-mac-leopard/css3/filters/custom/effect-custom-combined-missing-expected.png: Removed.
  • platform/chromium-mac-leopard/css3/filters/custom/effect-custom-expected.png: Removed.
  • platform/chromium-mac-leopard/css3/filters/custom/effect-custom-parameters-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/composited-during-transition-layertree-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/custom: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/custom/effect-custom-combined-missing-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-brightness-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-brightness-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-brightness-hw-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-combined-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-combined-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-contrast-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-contrast-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-grayscale-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-grayscale-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-hue-rotate-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-hue-rotate-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-invert-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-invert-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-invert-hw-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-opacity-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-opacity-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-saturate-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-saturate-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-saturate-hw-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-sepia-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-sepia-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-sepia-hw-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/filter-repaint-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/filter-with-transform-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/nested-filter-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/nested-filters-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/regions-expanding-expected.png: Removed.
  • platform/chromium-mac/css3/filters/composited-during-transition-layertree-expected.txt: Added.
  • platform/chromium-mac/css3/filters/effect-brightness-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-brightness-expected.txt: Added.
  • platform/chromium-mac/css3/filters/effect-brightness-hw-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-combined-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-combined-expected.txt: Added.
  • platform/chromium-mac/css3/filters/effect-contrast-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-contrast-expected.txt: Added.
  • platform/chromium-mac/css3/filters/effect-grayscale-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-grayscale-expected.txt: Added.
  • platform/chromium-mac/css3/filters/effect-hue-rotate-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-hue-rotate-expected.txt: Added.
  • platform/chromium-mac/css3/filters/effect-invert-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-invert-expected.txt: Added.
  • platform/chromium-mac/css3/filters/effect-invert-hw-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-opacity-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-opacity-expected.txt: Added.
  • platform/chromium-mac/css3/filters/effect-saturate-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-saturate-expected.txt: Added.
  • platform/chromium-mac/css3/filters/effect-saturate-hw-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-sepia-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-sepia-expected.txt: Added.
  • platform/chromium-mac/css3/filters/effect-sepia-hw-expected.png: Added.
  • platform/chromium-mac/css3/filters/filter-repaint-expected.png: Added.
  • platform/chromium-mac/css3/filters/filter-with-transform-expected.png: Added.
  • platform/chromium-mac/css3/filters/nested-filter-expected.png: Added.
  • platform/chromium-mac/css3/filters/nested-filters-expected.png: Added.
  • platform/chromium-mac/css3/filters/regions-expanding-expected.png: Added.
  • platform/chromium-win/css3/filters/custom: Removed.
  • platform/chromium-win/css3/filters/custom/effect-custom-combined-missing-expected.png: Removed.
  • platform/chromium-win/css3/filters/custom/effect-custom-expected.png: Removed.
  • platform/chromium-win/css3/filters/custom/effect-custom-parameters-expected.png: Removed.
  • platform/chromium/css3/filters/custom: Removed.
  • platform/chromium/css3/filters/custom/effect-custom-combined-missing-expected.txt: Removed.
  • platform/chromium/css3/filters/custom/effect-custom-disabled-expected.txt: Removed.
  • platform/chromium/css3/filters/custom/effect-custom-expected.txt: Removed.
  • platform/chromium/css3/filters/custom/effect-custom-parameters-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
08:27 Changeset [110848] by zimmermann@webkit.org

Enable animVal support for SVGNumberList
https://bugs.webkit.org/show_bug.cgi?id=81219

Reviewed by Rob Buis.

Source/WebCore:

Enable animVal support for SVGNumberList. Easy patch, we just need to add the missing
constructFromCopy() method to SVGAnumatedNumberListAnimator and report AnimatedNumberList
as supporting animVal.

Covered by existing tests.

  • svg/SVGAnimatedNumberList.cpp:

(WebCore::SVGAnimatedNumberListAnimator::constructFromCopy):
(WebCore):

  • svg/SVGAnimatedNumberList.h:

(WebCore):
(SVGAnimatedNumberListAnimator):

  • svg/SVGAnimatedType.cpp:

(WebCore::SVGAnimatedType::supportsAnimVal):
(WebCore::SVGAnimatedType::setVariantValue):

LayoutTests:

Extend SVGNumberList tests to cover animVal/baseVal at the same time.

  • platform/chromium/test_expectations.txt:
  • svg/animations/script-tests/svgnumberlist-animation-1.js:

(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):

  • svg/animations/script-tests/svgnumberlist-animation-2.js:

(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):

  • svg/animations/svgnumberlist-animation-1-expected.txt:
  • svg/animations/svgnumberlist-animation-2-expected.txt:
  • svg/filters/feColorMatrix-invalid-animation-expected.txt: We no longer mutate the DOM, thus the dump is now correct.
08:12 Changeset [110847] by philn@webkit.org

Unreviewed, GTK build fix attempt after r110845.

  • Scripts/run-gtk-tests: Added --release and --debug options.
07:58 Changeset [110846] by kubo@profusion.mobi

Parametrize run-with-jhbuild and update-webkitgtk-libs with platform --gtk/--efl
https://bugs.webkit.org/show_bug.cgi?id=79673

Preparatory work for bringing jhbuild enabled build to EFL port.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-03-15
Reviewed by Philippe Normand.

  • Scripts/update-webkit-libs-jhbuild: Copied from Tools/Scripts/update-webkitgtk-libs.
  • Scripts/update-webkitgtk-libs:
  • gtk/run-with-jhbuild:
  • jhbuild/jhbuild-wrapper: Copied from Tools/gtk/run-with-jhbuild.

(top_level_path):
(jhbuild_installed):
(jhbuild_cloned):
(jhbuild_at_expected_revision):
(update_jhbuild):
(clone_jhbuild):
(install_jhbuild):
(update_webkit_libs_jhbuild):
(determine_platform):
(ensure_jhbuild):

07:44 Changeset [110845] by carlosgc@webkit.org

[GTK] Add command line options to run-gtk-tests script
https://bugs.webkit.org/show_bug.cgi?id=81218

Reviewed by Philippe Normand.

Following command line options have been added:

-v, --verbose: to run gtester with --verbose. That would be used
by the bots to make it easier to know which test case it failing.

--display: to use a different display for Xvfb

It's also possible to pass one or more tests as arguments.

  • Scripts/run-gtk-tests:

(TestRunner.init): Receive command line arguments.
(TestRunner._get_tests): Get all the tests or the ones passed by
command line arguments.
(TestRunner._ensure_accessibility_daemon_is_running): Use display
command line argument.
(TestRunner.run): Pas command line options.
(TestRunner.run.run_tests): Pass command line arguments.

07:34 Changeset [110844] by rwlbuis@webkit.org

Fix cast-align GCC warnings
https://bugs.webkit.org/show_bug.cgi?id=80790

Reviewed by Nikolas Zimmermann.

  • platform/graphics/WOFFFileFormat.cpp:

(WebCore::writeUInt32):
(WebCore::writeUInt16):
(WebCore::convertWOFFToSfnt):

07:17 Changeset [110843] by peter@chromium.org

Unreviewed. Rolled DEPS.

  • DEPS:
07:15 Changeset [110842] by zimmermann@webkit.org

2012-03-15 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Forgot to preserve copyrights, per reviewer comment.

  • svg/SVGAnimatedTransformList.cpp:
07:12 Changeset [110841] by zimmermann@webkit.org

Enable animVal support for SVGNumber
https://bugs.webkit.org/show_bug.cgi?id=81212

Reviewed by Rob Buis.

Source/WebCore:

Enable animVal support for SVGNumber. This aligns SVGAnimatedStaticPropertyTearOff,
with the other SVGListPropertyTearOff & SVGPropertyTearOff, as all support animVal now.
Converting the rest of the types can be done in small patches now.

Test: svg/animations/svgnumber-animation-4.html

  • svg/SVGAnimatedNumber.cpp:

(WebCore::SVGAnimatedNumberAnimator::constructFromCopy):
(WebCore):

  • svg/SVGAnimatedNumber.h:

(WebCore):
(SVGAnimatedNumberAnimator):

  • svg/SVGAnimatedType.cpp:

(WebCore::SVGAnimatedType::supportsAnimVal):
(WebCore::SVGAnimatedType::setVariantValue):

  • svg/properties/SVGAnimatedProperty.h:

(SVGAnimatedProperty):

  • svg/properties/SVGAnimatedStaticPropertyTearOff.h:

(WebCore::SVGAnimatedStaticPropertyTearOff::animVal):
(WebCore::SVGAnimatedStaticPropertyTearOff::currentAnimatedValue):
(SVGAnimatedStaticPropertyTearOff):
(WebCore::SVGAnimatedStaticPropertyTearOff::currentBaseValue):
(WebCore::SVGAnimatedStaticPropertyTearOff::animationStarted):
(WebCore::SVGAnimatedStaticPropertyTearOff::animationEnded):
(WebCore::SVGAnimatedStaticPropertyTearOff::animationValueWillChange):
(WebCore::SVGAnimatedStaticPropertyTearOff::animationValueDidChange):
(WebCore::SVGAnimatedStaticPropertyTearOff::SVGAnimatedStaticPropertyTearOff):

LayoutTests:

Add new test covering animVal support for SVGNumber.

  • svg/animations/script-tests/svgnumber-animation-4.js: Added.

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/svgnumber-animation-4-expected.txt: Added.
  • svg/animations/svgnumber-animation-4.html: Added.
07:00 Changeset [110840] by carlosgc@webkit.org

[GTK] WebKit2APITests/TestPrinting timeout in the bots
https://bugs.webkit.org/show_bug.cgi?id=81211

Reviewed by Philippe Normand.

Add gtk+ patch to fix timeout in the bots. A similar patch has
already landed in updatream gtk+, see
http://git.gnome.org/browse/gtk+/commit/?id=5ebfad5d091f4c9d9c6e60364fad4c60842f027f

  • gtk/jhbuild.modules:
  • gtk/patches/gtk+-3.0.12-gtkprinter.patch: Added.
06:34 Changeset [110839] by zimmermann@webkit.org

2012-03-15 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix typo introduced in my last patch leading to flakiness.

  • svg/animations/script-tests/animateTransform-pattern-transform.js: (executeTest):
06:09 Changeset [110838] by zimmermann@webkit.org

Enable animVal support for SVGTransformList
https://bugs.webkit.org/show_bug.cgi?id=80758

Reviewed by Antti Koivisto.

Source/WebCore:

Enable animVal support for SVGTransformList. SVGTransformLists are only animatable
via <animateTransform>, not via <animate> directly. Still we can handle it in the
same framework as all other types used for <animate>, as we also need proper animVal
support for <animateTransform>.

This patch removes the special <animateTransform> implementation, and lets
SVGAnimateTransformElement inherit from SVGAnimateElement, just like its done
for SVGAnimateColorElement & SVGSetElement.

All existing code (calculateFromAndToValues/FromAndByValues/etc..) are moved from
SVGAnimateTransform right into the SVGAnimatedTransformListAnimator.

This doesn't change <animateTransform> behavior, it just simplies the code
and enables animVal support for SVGTransformLists - all covered by existing tests.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • svg/SVGAllInOne.cpp:
  • svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::SVGAnimateElement):
(WebCore::SVGAnimateElement::determineAnimatedPropertyType):
(WebCore::SVGAnimateElement::calculateAnimatedValue):
(WebCore::SVGAnimateElement::applyResultsToTarget):

  • svg/SVGAnimateTransformElement.cpp:

(WebCore::SVGAnimateTransformElement::SVGAnimateTransformElement):
(WebCore::SVGAnimateTransformElement::hasValidAttributeType):
(WebCore::SVGAnimateTransformElement::parseAttribute):

  • svg/SVGAnimateTransformElement.h:

(WebCore::SVGAnimateTransformElement::transformType):
(SVGAnimateTransformElement):

  • svg/SVGAnimatedTransformList.cpp: Added.

(WebCore):
(WebCore::SVGAnimatedTransformListAnimator::SVGAnimatedTransformListAnimator):
(WebCore::SVGAnimatedTransformListAnimator::constructFromString):
(WebCore::SVGAnimatedTransformListAnimator::constructFromCopy):
(WebCore::SVGAnimatedTransformListAnimator::calculateFromAndToValues):
(WebCore::SVGAnimatedTransformListAnimator::calculateFromAndByValues):
(WebCore::SVGAnimatedTransformListAnimator::calculateAnimatedValue):
(WebCore::SVGAnimatedTransformListAnimator::calculateDistance):

  • svg/SVGAnimatedTransformList.h:

(WebCore):
(SVGAnimatedTransformListAnimator):
(WebCore::SVGAnimatedTransformListAnimator::~SVGAnimatedTransformListAnimator):

  • svg/SVGAnimatedType.cpp:

(WebCore::SVGAnimatedType::~SVGAnimatedType):
(WebCore::SVGAnimatedType::createTransformList):
(WebCore):
(WebCore::SVGAnimatedType::transformList):
(WebCore::SVGAnimatedType::valueAsString):
(WebCore::SVGAnimatedType::setValueAsString):
(WebCore::SVGAnimatedType::supportsAnimVal):
(WebCore::SVGAnimatedType::setVariantValue):

  • svg/SVGAnimatedType.h:

(WebCore):
(SVGAnimatedType):

  • svg/SVGAnimatorFactory.h:

(WebCore::SVGAnimatorFactory::create):

  • svg/SVGGradientElement.cpp:

(WebCore::SVGGradientElement::parseAttribute):

  • svg/SVGPatternElement.cpp:

(WebCore::SVGPatternElement::parseAttribute):

  • svg/SVGStyledTransformableElement.cpp:

(WebCore::SVGStyledTransformableElement::parseAttribute):

  • svg/SVGTextElement.cpp:

(WebCore::SVGTextElement::parseAttribute):

  • svg/SVGTransform.cpp:

(WebCore::SVGTransform::transformTypePrefixForParsing):
(WebCore):
(WebCore::SVGTransform::valueAsString):

  • svg/SVGTransform.h:

(SVGTransform):

  • svg/SVGTransformList.cpp:

(WebCore::SVGTransformList::parse):
(WebCore):

  • svg/SVGTransformList.h:

(SVGTransformList):

  • svg/SVGTransformable.cpp:

(WebCore::SVGTransformable::parseTransformType):

  • svg/SVGTransformable.h:

(WebCore):

  • svg/SVGViewSpec.cpp:

(WebCore::SVGViewSpec::setTransform):

LayoutTests:

Rebaseline tests after enabling animVal support SVGAnimateTransformElement/SVGTransformList.

  • svg/animations/animate-gradient-transform-expected.txt:
  • svg/animations/animateTransform-pattern-transform-expected.txt:
  • svg/animations/script-tests/animate-gradient-transform.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/animateTransform-pattern-transform.js:

(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):

05:50 Changeset [110837] by kov@webkit.org

sheriffbot should also be addressable with a comma in addition to colon
https://bugs.webkit.org/show_bug.cgi?id=81101

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/net/irc/ircbot.py:

(IRCBot.on_pubmsg):

05:06 Changeset [110836] by ahf@0x90.dk

[Qt] MiniBrowser scroll indicators should not scroll out of view https://bugs.webkit.org/show_bug.cgi?id=81131

Reviewed by Kenneth Rohde Christiansen.

  • MiniBrowser/qt/qml/ScrollIndicator.qml:
05:04 FeatureFlags edited by tkent@chromium.org
(diff)
04:59 FeatureFlags edited by tkent@chromium.org
(diff)
03:00 Changeset [110835] by zimmermann@webkit.org

Enable animVal support for SVGLengthList
https://bugs.webkit.org/show_bug.cgi?id=80750

Reviewed by Zoltan Herczeg.

Source/WebCore:

Introduce animVal support for generic SVGList types. This aligns SVGListProperty with SVGProperty
in terms of animVal/baseVal support. Use this to turn on animVal support for SVGLengthList.

Extend all existing SVGLengthList tests to correctly differentiate between baseVal/animVal.

  • svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::calculateAnimatedValue):

  • svg/SVGAnimateTransformElement.cpp:

(WebCore::SVGAnimateTransformElement::resetToBaseValue):
(WebCore::SVGAnimateTransformElement::calculateAnimatedValue):
(WebCore::SVGAnimateTransformElement::applyResultsToTarget):

  • svg/SVGAnimatedLengthList.cpp:

(WebCore::SVGAnimatedLengthListAnimator::constructFromCopy):
(WebCore):

  • svg/SVGAnimatedLengthList.h:

(WebCore):
(SVGAnimatedLengthListAnimator):

  • svg/SVGAnimatedType.cpp:

(WebCore::SVGAnimatedType::supportsAnimVal):
(WebCore::SVGAnimatedType::setVariantValue):

  • svg/SVGAnimatedType.h:
  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::applyAnimatedValue):

  • svg/properties/SVGAnimatedListPropertyTearOff.h:

(SVGAnimatedListPropertyTearOff):
(WebCore::SVGAnimatedListPropertyTearOff::baseVal):
(WebCore::SVGAnimatedListPropertyTearOff::animVal):
(WebCore::SVGAnimatedListPropertyTearOff::removeItemFromList):
(WebCore::SVGAnimatedListPropertyTearOff::detachListWrappers):
(WebCore::SVGAnimatedListPropertyTearOff::currentAnimatedValue):
(WebCore::SVGAnimatedListPropertyTearOff::currentBaseValue):
(WebCore::SVGAnimatedListPropertyTearOff::animationStarted):
(WebCore::SVGAnimatedListPropertyTearOff::animationEnded):
(WebCore::SVGAnimatedListPropertyTearOff::synchronizeWrappersIfNeeded):
(WebCore::SVGAnimatedListPropertyTearOff::animationValueWillChange):
(WebCore::SVGAnimatedListPropertyTearOff::animationValueDidChange):

  • svg/properties/SVGAnimatedPathSegListPropertyTearOff.h:

(WebCore::SVGAnimatedPathSegListPropertyTearOff::baseVal):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::animVal):

  • svg/properties/SVGAnimatedProperty.h:

(WebCore::SVGAnimatedProperty::isAnimating):
(SVGAnimatedProperty):
(WebCore::SVGAnimatedProperty::animationValueWillChange):
(WebCore::SVGAnimatedProperty::animationValueDidChange):
(WebCore::SVGAnimatedProperty::~SVGAnimatedProperty):
(WebCore::SVGAnimatedProperty::SVGAnimatedProperty):

  • svg/properties/SVGAnimatedPropertyTearOff.h:

(SVGAnimatedPropertyTearOff):
(WebCore::SVGAnimatedPropertyTearOff::baseVal):
(WebCore::SVGAnimatedPropertyTearOff::animVal):
(WebCore::SVGAnimatedPropertyTearOff::currentAnimatedValue):
(WebCore::SVGAnimatedPropertyTearOff::animationStarted):
(WebCore::SVGAnimatedPropertyTearOff::animationEnded):
(WebCore::SVGAnimatedPropertyTearOff::animationValueWillChange):
(WebCore::SVGAnimatedPropertyTearOff::animationValueDidChange):
(WebCore::SVGAnimatedPropertyTearOff::SVGAnimatedPropertyTearOff):

  • svg/properties/SVGAnimatedTransformListPropertyTearOff.h:

(WebCore::SVGAnimatedTransformListPropertyTearOff::baseVal):
(WebCore::SVGAnimatedTransformListPropertyTearOff::animVal):

  • svg/properties/SVGListProperty.h:

(WebCore::SVGListProperty::detachListWrappers):
(SVGListProperty):
(WebCore::SVGListProperty::setValuesAndWrappers):
(WebCore::SVGListProperty::clearValues):
(WebCore::SVGListProperty::clearValuesAndWrappers):
(WebCore::SVGListProperty::numberOfItems):
(WebCore::SVGListProperty::initializeValues):
(WebCore::SVGListProperty::initializeValuesAndWrappers):
(WebCore::SVGListProperty::canGetItem):
(WebCore::SVGListProperty::getItemValues):
(WebCore::SVGListProperty::getItemValuesAndWrappers):
(WebCore::SVGListProperty::insertItemBeforeValues):
(WebCore::SVGListProperty::insertItemBeforeValuesAndWrappers):
(WebCore::SVGListProperty::canReplaceItem):
(WebCore::SVGListProperty::replaceItemValues):
(WebCore::SVGListProperty::replaceItemValuesAndWrappers):
(WebCore::SVGListProperty::canRemoveItem):
(WebCore::SVGListProperty::removeItemValues):
(WebCore::SVGListProperty::removeItemValuesAndWrappers):
(WebCore::SVGListProperty::appendItemValues):
(WebCore::SVGListProperty::appendItemValuesAndWrappers):
(WebCore::SVGListProperty::values):
(WebCore::SVGListProperty::wrappers):
(WebCore::SVGListProperty::SVGListProperty):

  • svg/properties/SVGListPropertyTearOff.h:

(SVGListPropertyTearOff):
(WebCore::SVGListPropertyTearOff::create):
(WebCore::SVGListPropertyTearOff::removeItemFromList):
(WebCore::SVGListPropertyTearOff::clear):
(WebCore::SVGListPropertyTearOff::initialize):
(WebCore::SVGListPropertyTearOff::insertItemBefore):
(WebCore::SVGListPropertyTearOff::replaceItem):
(WebCore::SVGListPropertyTearOff::appendItem):
(WebCore::SVGListPropertyTearOff::SVGListPropertyTearOff):
(WebCore::SVGListPropertyTearOff::commitChange):

  • svg/properties/SVGPathSegListPropertyTearOff.cpp:

(WebCore::SVGPathSegListPropertyTearOff::clear):
(WebCore::SVGPathSegListPropertyTearOff::getItem):
(WebCore::SVGPathSegListPropertyTearOff::removeItem):

  • svg/properties/SVGPathSegListPropertyTearOff.h:

(WebCore::SVGPathSegListPropertyTearOff::create):
(WebCore::SVGPathSegListPropertyTearOff::removeItemFromList):
(SVGPathSegListPropertyTearOff):
(WebCore::SVGPathSegListPropertyTearOff::initialize):
(WebCore::SVGPathSegListPropertyTearOff::insertItemBefore):
(WebCore::SVGPathSegListPropertyTearOff::replaceItem):
(WebCore::SVGPathSegListPropertyTearOff::appendItem):
(WebCore::SVGPathSegListPropertyTearOff::SVGPathSegListPropertyTearOff):
(WebCore::SVGPathSegListPropertyTearOff::commitChange):

  • svg/properties/SVGPropertyInfo.h:
  • svg/properties/SVGStaticListPropertyTearOff.h:

(SVGStaticListPropertyTearOff):
(WebCore::SVGStaticListPropertyTearOff::clear):
(WebCore::SVGStaticListPropertyTearOff::initialize):
(WebCore::SVGStaticListPropertyTearOff::getItem):
(WebCore::SVGStaticListPropertyTearOff::insertItemBefore):
(WebCore::SVGStaticListPropertyTearOff::replaceItem):
(WebCore::SVGStaticListPropertyTearOff::removeItem):
(WebCore::SVGStaticListPropertyTearOff::appendItem):
(WebCore::SVGStaticListPropertyTearOff::SVGStaticListPropertyTearOff):
(WebCore::SVGStaticListPropertyTearOff::commitChange):

  • svg/properties/SVGTransformListPropertyTearOff.h:

(WebCore::SVGTransformListPropertyTearOff::create):
(WebCore::SVGTransformListPropertyTearOff::createSVGTransformFromMatrix):
(WebCore::SVGTransformListPropertyTearOff::consolidate):
(WebCore::SVGTransformListPropertyTearOff::SVGTransformListPropertyTearOff):

LayoutTests:

Update test expectations after turning on animVal support for SVGLengthList.

  • svg/animations/script-tests/svglengthlist-animation-1.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/svglengthlist-animation-2.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/svglengthlist-animation-3.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/svglengthlist-animation-4.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/svglengthlist-animation-5.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/svglengthlist-animation-1-expected.txt:
  • svg/animations/svglengthlist-animation-2-expected.txt:
  • svg/animations/svglengthlist-animation-3-expected.txt:
  • svg/animations/svglengthlist-animation-4-expected.txt:
  • svg/animations/svglengthlist-animation-5-expected.txt:
02:08 Changeset [110834] by carlosgc@webkit.org

[WK2] WebPageProxy::activeURL should return unreachableURL() when it's not empty
https://bugs.webkit.org/show_bug.cgi?id=75465

Reviewed by Philippe Normand.

  • UIProcess/API/gtk/tests/WebViewTest.cpp:

(WebViewTest::replaceContent): Return the main frame
unreachableURL if it's not empty.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::activeURL):

01:57 Changeset [110833] by alexis.menard@openbossa.org

Add a new perf test to benchmark setting and reading CSS properties from JS.
https://bugs.webkit.org/show_bug.cgi?id=81155

Reviewed by Ryosuke Niwa.

This benchmark read and set CSS properties from JS. It contains a list
of common CSS properties.

  • CSS/CSSPropertySetterGetter.html: Added.
01:04 Changeset [110832] by morrita@google.com

Unreviewed, GTK baselines for new fast/css test.

Patch by Philippe Normand <pnormand@igalia.com> on 2012-03-15

  • platform/gtk/fast/css/pseudo-first-line-border-width-expected.txt: Added.
00:44 Changeset [110831] by philn@webkit.org

Unreviewed, GTK baselines for new fast/css test.

  • platform/gtk/fast/css/pseudo-first-line-border-width-expected.txt: Added.
00:30 Changeset [110830] by morrita@google.com

Unreviewed expectations update.

  • platform/chromium-linux/compositing/culling/filter-occlusion-blur-expected.png: Added.
  • platform/chromium-linux/compositing/culling/filter-occlusion-blur-large-expected.png: Added.
00:04 Changeset [110829] by morrita@google.com

Unreviewed expectations update.

  • platform/chromium-mac-leopard/svg/batik/filters/filterRegions-expected.txt: Removed.

03/14/12:

23:32 Changeset [110828] by cfleizach@apple.com

Source/WebCore: AXDescription for HTML5 footer
https://bugs.webkit.org/show_bug.cgi?id=78967

Return a unique role description for the footer element.

Reviewed by Beth Dakin.

Test: platform/mac/accessibility/footer-roledescription.html

  • English.lproj/Localizable.strings:+
  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(createAccessibilityRoleMap):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper roleDescription]):

  • platform/LocalizedStrings.cpp:

(WebCore::AXFooterRoleDescriptionText):
(WebCore):

  • platform/LocalizedStrings.h:

(WebCore):

  • platform/blackberry/LocalizedStringsBlackBerry.cpp:

(WebCore::AXFooterRoleDescriptionText):
(WebCore):

  • platform/efl/LocalizedStringsEfl.cpp:

(WebCore::AXFooterRoleDescriptionText):
(WebCore):

  • platform/gtk/LocalizedStringsGtk.cpp:

(WebCore::AXFooterRoleDescriptionText):
(WebCore):

Source/WebKit/chromium: AXDescription for HTML5 footer and ARIA role contentinfo incorrect
https://bugs.webkit.org/show_bug.cgi?id=78967

Reviewed by Beth Dakin.

  • src/LocalizedStrings.cpp:

LayoutTests: AXDescription for HTML5 footer and ARIA role contentinfo incorrect
https://bugs.webkit.org/show_bug.cgi?id=78967

Reviewed by Beth Dakin.

  • platform/mac/accessibility/footer-roledescription-expected.txt: Added.
  • platform/mac/accessibility/footer-roledescription.html: Added.
23:31 Changeset [110827] by morrita@google.com

Unreviewed expectation update for Chrome-Lion.

  • platform/chromium/test_expectations.txt:
23:22 FeatureFlags edited by tkent@chromium.org
(diff)
23:19 Changeset [110826] by mrowe@apple.com

<http://webkit.org/b/81193> Ensure libWebCoreTestSupport.dylib's library identifier is set appropriately for all configurations.

Reviewed by Dan Bernstein.

  • Configurations/WebCoreTestSupport.xcconfig: Switch to setting DYLIB_INSTALL_NAME_BASE

rather than LD_DYLIB_INSTALL_NAME. The latter is derived from the former. Ensure that
DYLIB_INSTALL_NAME_BASE is also set for the Production configuration.

23:01 Changeset [110825] by cfleizach@apple.com

AXDescription for ARIA role contentinfo incorrect
https://bugs.webkit.org/show_bug.cgi?id=78967

Reviewed by Beth Dakin.

Source/WebCore:

Test: platform/mac/accessibility/aria-grouping-roles.html

  • English.lproj/Localizable.strings:
  • platform/LocalizedStrings.cpp:

(WebCore::AXARIAContentGroupText):

LayoutTests:

  • platform/mac/accessibility/aria-grouping-roles-expected.txt:
  • platform/mac/accessibility/aria-grouping-roles.html:
22:43 FeatureFlags edited by tkent@chromium.org
(diff)
22:31 FeatureFlags edited by tkent@chromium.org
Move PURGEABLE_MEMORY (diff)
22:19 Changeset [110824] by morrita@google.com

Unreviewed expectation update.

  • platform/chromium-win-xp/accessibility/aria-checkbox-sends-notification-expected.txt: Added.
  • platform/chromium/canvas/philip/tests/2d.gradient.interpolate.colouralpha-expected.txt: Renamed from LayoutTests/platform/chromium-win/canvas/philip/tests/2d.gradient.interpolate.colouralpha-expected.txt.
  • platform/win/canvas/philip/tests/2d.gradient.interpolate.colouralpha-expected.txt: Removed.
22:12 Changeset [110823] by cfleizach@apple.com

AX: ARIA tables need to support selected rows attribute/select rows changed notification
https://bugs.webkit.org/show_bug.cgi?id=79821

Reviewed by Beth Dakin.

Source/WebCore:

Test: platform/mac/accessibility/selected-rows-table.html

  • accessibility/AccessibilityARIAGrid.h:

(WebCore::AccessibilityARIAGrid::isMultiSelectable):
(AccessibilityARIAGrid):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::ariaSelectedRows):

  • accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::observableObject):
(WebCore):

  • accessibility/AccessibilityTableRow.h:

(AccessibilityTableRow):

  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postPlatformNotification):

Tools:

  • DumpRenderTree/AccessibilityUIElement.cpp:

(rowAtIndexCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:

(AccessibilityUIElement):

  • DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:

(AccessibilityUIElement::rowAtIndex):

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::rowAtIndex):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::rowAtIndex):

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::rowAtIndex):

LayoutTests:

  • platform/mac/accessibility/selected-rows-table-expected.txt: Added.
  • platform/mac/accessibility/selected-rows-table.html: Added.
22:12 FeatureFlags edited by tkent@chromium.org
(diff)
22:10 Changeset [110822] by benjamin@webkit.org

Avoid StringImpl::getData16SlowCase() when sorting array
https://bugs.webkit.org/show_bug.cgi?id=81070

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-14
Reviewed by Geoffrey Garen.

The function codePointCompare() is used intensively when sorting strings.
This patch improves its performance by:
-Avoiding character conversion.
-Inlining the function.

This makes Peacekeeper's arrayCombined test 30% faster.

  • wtf/text/StringImpl.cpp:
  • wtf/text/StringImpl.h:

(WTF):
(WTF::codePointCompare):
(WTF::codePointCompare8):
(WTF::codePointCompare16):
(WTF::codePointCompare8To16):

22:07 Changeset [110821] by jamesr@google.com

Platforms without USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) don't need to query the page's displayID
https://bugs.webkit.org/show_bug.cgi?id=81187

Reviewed by Simon Fraser.

  • dom/Document.cpp:

(WebCore::Document::webkitRequestAnimationFrame):

21:59 FeatureFlags edited by tkent@chromium.org
(diff)
21:50 FeatureFlags edited by tkent@chromium.org
(diff)
21:44 FeatureFlags edited by tkent@chromium.org
Add some comments (diff)
21:39 Changeset [110820] by andersca@apple.com

java/java-and-plugins.html test failing
https://bugs.webkit.org/show_bug.cgi?id=81188
<rdar://problem/11048657>

Reviewed by Sam Weinig.

Source/WebKit/mac:

When we're marshaling JSObjects that wrap plug-in objects, make sure to check that the
current plug-in instance is the same as the plug-in instance the object came from and don't
pass the unwrapped object ID if that is the case.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::getObjectID):
(WebKit::NetscapePluginInstanceProxy::addValueToArray):
(WebKit::NetscapePluginInstanceProxy::marshalValues):

  • Plugins/Hosted/ProxyInstance.h:

(ProxyInstance):
(WebKit::ProxyInstance::instanceProxy):

Source/WebKit2:

When we're marshaling NPObjects that wrap plug-in objects, make sure to check that the
current plug-in instance is the same as the plug-in instance the object came from and don't
pass the unwrapped object ID if that is the case.

  • Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::remoteNPObjectID):
(WebKit::NPRemoteObjectMap::npVariantToNPVariantData):

LayoutTests:

Remove part of this test that tested trying to call a java method on an NPObject; on Snow Leopard
and newer the Java plug-in is also a NPAPI plug-in so the two removed tests would fail.

  • java/java-and-plugins-expected.txt:
  • java/java-and-plugins.html:
21:35 FeatureFlags edited by tkent@chromium.org
More JSC flags (diff)
21:28 FeatureFlags edited by tkent@chromium.org
categorize JSC (diff)
21:18 Changeset [110819] by cfleizach@apple.com

AX: embedded attachments do not report their parents correctly
https://bugs.webkit.org/show_bug.cgi?id=80132

When a WebHTMLView has embedded attachments in it, the AXParent of those attachments is wrong.
It usually points to the AXScrollView of the web area. That's because there has been no way for WebCore to
communicate that this attachment view should actually make believe that it's parent is within the WebCore AX tree.

We can fix that by overriding the AXParent in overriden attributes for items that are attachments.

Reviewed by Beth Dakin.

Not able to construct a layout test because the problem only manifests itself when an AX client connects to WebKit
through the IPC mechanism.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::detachFromParent):

  • accessibility/AccessibilityObject.h:

(AccessibilityObject):
(WebCore::AccessibilityObject::overrideAttachmentParent):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::updateAttachmentViewParents):
(WebCore::AccessibilityRenderObject::addChildren):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

  • accessibility/mac/AccessibilityObjectMac.mm:

(WebCore::AccessibilityObject::overrideAttachmentParent):

21:11 FeatureFlags created by tkent@chromium.org
Just listing
20:58 Changeset [110818] by fpizlo@apple.com

Fix for possible problems compiling with old versions of gcc
<rdar://problem/11043680>

Rubber stamped by Mark Rowe.

  • Configurations/Base.xcconfig:
20:57 WikiStart edited by tkent@chromium.org
(diff)
20:51 Changeset [110817] by rniwa@webkit.org

Improve ContainerNode's collectNodes() performance
https://bugs.webkit.org/show_bug.cgi?id=80706

Reviewed by Antti Koivisto.

Bump up the size of stack allocated buffer from 1 to 11. According to the rough study I conducted,
this would cover 99.5% of all node collection.

Note: the actual code change was made in r110797 but I somehow mangled my patches.

  • dom/ContainerNode.cpp:

(WebCore):

20:43 Changeset [110816] by commit-queue@webkit.org

Cleanup semicolons in IDLs
https://bugs.webkit.org/show_bug.cgi?id=81129

Patch by Seo Sanghyeon <sh4.seo@samsung.com> on 2012-03-14
Reviewed by Kentaro Hara.

No tests. No change in behavior.

  • svg/SVGAnimateColorElement.idl:
  • svg/SVGAnimateElement.idl:
  • svg/SVGAnimateTransformElement.idl:
  • svg/SVGAnimatedRect.idl:
20:29 Changeset [110815] by jberlin@webkit.org

Mac rebaseline after r110667.

  • platform/mac/fast/dom/Window/window-properties-expected.txt:
20:11 Changeset [110814] by jamesr@google.com

[chromium] More compositing baseline updates. Unreviewed.

  • platform/chromium-mac-snowleopard/compositing/reflections/masked-reflection-on-composited-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-mask-change-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-size-change-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/reflections/reflection-ordering-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/reflections/reflection-positioning-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/reflections/reflection-positioning2-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/reflections/simple-composited-reflections-expected.png: Added.
  • platform/chromium-mac/compositing/culling/filter-occlusion-blur-expected.png:
  • platform/chromium-mac/compositing/culling/filter-occlusion-blur-large-expected.png:
  • platform/chromium-mac/compositing/overflow/ancestor-overflow-expected.png:
  • platform/chromium-mac/compositing/repaint/opacity-between-absolute-expected.png:
  • platform/chromium-win/compositing/culling/filter-occlusion-blur-expected.png:
  • platform/chromium-win/compositing/culling/filter-occlusion-blur-large-expected.png:
20:08 Changeset [110813] by jberlin@webkit.org

[Mac Intel WebKit2 Release Tests] canvas/philip/tests/2d.text.draw.fontface.notinpage.html
failing since r83550
https://bugs.webkit.org/show_bug.cgi?id=58332

Add expected failing results to get the bots green.

  • platform/mac-wk2/canvas/philip/tests/2d.text.draw.fontface.notinpage-expected.txt: Added.
20:08 Changeset [110812] by jberlin@webkit.org

Rebaseline some mac canvas philip expected failing results to get the bots green.

  • platform/mac/canvas/philip/tests/2d.text.font.parse.invalid-expected.txt:
20:08 Changeset [110811] by jberlin@webkit.org

canvas/philip/tests/2d.gradient.interpolate.colouralpha failing on Lion Intel Debug (WK1 and WK2)
https://bugs.webkit.org/show_bug.cgi?id=81185

Land some expected failing results to get the bots green.

  • platform/mac/canvas/philip/tests/2d.gradient.interpolate.colouralpha-expected.txt: Added.
20:06 Changeset [110810] by hayato@chromium.org

Make ShadowRoot.activeElement return null if it does not contain a focused element.
https://bugs.webkit.org/show_bug.cgi?id=81097

Reviewed by Dimitri Glazkov.

Source/WebCore:

  • dom/TreeScope.cpp:

(WebCore::TreeScope::activeElement):

LayoutTests:

  • fast/dom/shadow/shadow-root-activeElement-expected.txt:
  • fast/dom/shadow/shadow-root-activeElement.html:
19:49 Changeset [110809] by commit-queue@webkit.org

[EFL] Remove nodesFromRect tests from the skip list
https://bugs.webkit.org/show_bug.cgi?id=81116

Support for internals.nodesFromRect was recently added for the EFL
port. These tests are now fine.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-03-14
Reviewed by Kenneth Rohde Christiansen.

  • platform/efl/Skipped:
19:12 Changeset [110808] by commit-queue@webkit.org

Allow per-script font settings to be specified in layout tests
https://bugs.webkit.org/show_bug.cgi?id=78184

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-03-14
Reviewed by Hajime Morita.

This adds per-script font settings to InternalSettings, so it can be used in layout tests instead of
the per-script font settings support in DumpRenderTree overridePreference, which has only been implemented
for Chromium so far.

.:

  • Source/autotools/symbols.filter: Added symbols.

Source/WebCore:

Test: changed fast/text/international/locale-sensitive-fonts.html to use InternalSettings
instead of overridePreference.

  • WebCore.exp.in: Added symbols.
  • platform/text/LocaleToScriptMapping.h: Added scriptNameToCode used by InternalSettings.

(WebCore):

  • platform/text/LocaleToScriptMappingDefault.cpp:

(WebCore::scriptNameToCode):
(WebCore::localeToScriptCodeForFontSelection):

  • platform/text/LocaleToScriptMappingICU.cpp:

(WebCore::scriptNameToCode):
(WebCore):

  • testing/InternalSettings.cpp: Added per-script font settings.

(WebCore):
(WebCore::setFontFamily):
(WebCore::InternalSettings::setStandardFontFamily):
(WebCore::InternalSettings::setSerifFontFamily):
(WebCore::InternalSettings::setSansSerifFontFamily):
(WebCore::InternalSettings::setFixedFontFamily):
(WebCore::InternalSettings::setCursiveFontFamily):
(WebCore::InternalSettings::setFantasyFontFamily):
(WebCore::InternalSettings::setPictographFontFamily):

  • testing/InternalSettings.h:

(InternalSettings):

  • testing/InternalSettings.idl:

Source/WebKit2:

  • win/WebKit2.def: Added symbols.
  • win/WebKit2CFLite.def: Added symbols.

LayoutTests:

  • fast/text/international/locale-sensitive-fonts-expected.html: Added. Changed test to a reftest.
  • fast/text/international/locale-sensitive-fonts.html: Changed to use InternalSettings.
  • platform/chromium-win/fast/text/international/locale-sensitive-fonts-expected.png: Removed.
  • platform/chromium/fast/text/international/locale-sensitive-fonts-expected.png: Removed.
  • platform/chromium/fast/text/international/locale-sensitive-fonts-expected.txt: Removed.
  • platform/efl/Skipped: Removed locale-sensitive-fonts.html since it no longer relies on overridePreference.
  • platform/gtk-wk2/Skipped: Ditto.
  • platform/gtk/Skipped: Ditto.
  • platform/mac/Skipped: Ditto.
  • platform/qt/Skipped: Ditto.
  • platform/win/Skipped: Ditto.
  • platform/wincairo/Skipped: Ditto.
  • platform/wk2/Skipped: Ditto.
19:09 Changeset [110807] by commit-queue@webkit.org

Remove obsolete constructors of CSSPrimitiveValue class.
https://bugs.webkit.org/show_bug.cgi?id=80971

Remove constructors of CSSPrimitiveValue that can't be
reached.

Patch by Kwonjin Jeong <gram@company100.net> on 2012-03-14
Reviewed by Andreas Kling.

  • css/CSSPrimitiveValueMappings.h:
18:48 Changeset [110806] by commit-queue@webkit.org

[BlackBerry] Make sure WebPage and BackingStore don't crash without a Window
https://bugs.webkit.org/show_bug.cgi?id=81099

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-03-14
Reviewed by Rob Buis.

Also rename the "compositing/blitting to main window" variables to
instead refer to OpenGL compositing. The code paths it triggers are
related to the BackingStore using OpenGL compositing, and can be useful
even when there's no window.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::isOpenGLCompositing):
(BlackBerry::WebKit::BackingStorePrivate::render):
(BlackBerry::WebKit::BackingStorePrivate::copyPreviousContentsToBackSurfaceOfWindow):
(BlackBerry::WebKit::BackingStorePrivate::paintDefaultBackground):
(BlackBerry::WebKit::BackingStorePrivate::blitContents):
(BlackBerry::WebKit::BackingStorePrivate::blitTileRect):
(BlackBerry::WebKit::BackingStorePrivate::blendCompositingSurface):
(BlackBerry::WebKit::BackingStorePrivate::renderContents):
(BlackBerry::WebKit::BackingStorePrivate::blitToWindow):
(BlackBerry::WebKit::BackingStorePrivate::checkerWindow):
(BlackBerry::WebKit::BackingStorePrivate::invalidateWindow):
(BlackBerry::WebKit::BackingStorePrivate::clearWindow):
(BlackBerry::WebKit::BackingStorePrivate::drawSubLayers):
(BlackBerry::WebKit::BackingStorePrivate::surfaceSize):
(BlackBerry::WebKit::BackingStorePrivate::buffer):

  • Api/BackingStore_p.h:
  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::didPluginEnterFullScreen):
(BlackBerry::WebKit::WebPagePrivate::didPluginExitFullScreen):
(BlackBerry::WebKit::WebPagePrivate::drawLayersOnCommit):
(BlackBerry::WebKit::WebPagePrivate::drawSubLayers):
(BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::windowRect):
(WebCore::ChromeClientBlackBerry::screenToWindow):
(WebCore::ChromeClientBlackBerry::windowToScreen):

  • WebKitSupport/GLES2Context.cpp:

(BlackBerry::WebKit::GLES2Context::GLES2Context):

  • WebKitSupport/TouchEventHandler.h:
  • WebKitSupport/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
(BlackBerry::WebKit::WebPageCompositor::setBackingStoreUsesOpenGL):
(BlackBerry::WebKit::WebPageCompositor::drawLayers):

  • WebKitSupport/WebPageCompositor.h:
18:30 Changeset [110805] by commit-queue@webkit.org

Fix memory allocation failed by fastmalloc
https://bugs.webkit.org/show_bug.cgi?id=79614

Patch by Hojong Han <hojong.han@samsung.com> on 2012-03-14
Reviewed by Geoffrey Garen.

Memory allocation failed even if the heap grows successfully.
It is wrong to get the span only from the large list after the heap grows,
because new span could be added in the normal list.

  • wtf/FastMalloc.cpp:

(WTF::TCMalloc_PageHeap::New):

18:28 Changeset [110804] by msaboff@apple.com

REGRESSION(r110383): ASSERTION failures in JSCell::finishCreation causing multiple tests to "crash" on the Lion Intel Debug Bots
https://bugs.webkit.org/show_bug.cgi?id=80993

Reviewed by Mark Rowe.

Moved $(BUILT_PRODUCTS_DIR)/usr/local/include to the front of HEADER_SEARCH_PATH
to fix builds given the wtf move.

Source/WebKit/mac:

  • Configurations/WebKit.xcconfig:

Source/WebKit2:

  • Configurations/BaseTarget.xcconfig:
18:20 Changeset [110803] by aestes@apple.com

Stop shadowing the argument to drawRect: with a local variable.

Reviewed by Sam Weinig.

  • UIProcess/API/mac/WKView.mm:

(-[WKView drawRect:]):

18:18 Changeset [110802] by igor.o@sisa.samsung.com

Split the extra logic out of RenderBlock::updateFirstLetter
https://bugs.webkit.org/show_bug.cgi?id=80772

Reviewed by Julien Chaffraix.

No change in behavior expected.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetterStyle):
(WebCore::RenderBlock::createFirstLetterRenderer):
(WebCore::RenderBlock::updateFirstLetter):
(WebCore):

  • rendering/RenderBlock.h:

(RenderBlock):

18:07 Changeset [110801] by achicu@adobe.com

Layout/floats.html should be runnable by run-perf-tests
https://bugs.webkit.org/show_bug.cgi?id=77051

Reviewed by Ryosuke Niwa.

I've split Layout/floats.html into multiple tests for each button in the original manual test.
Some tests take longer to run and I've changed the number of iterations, so that each tests finishes under 30s per run.

  • DOM/resources/dom-perf.js:
  • Layout/floats.html: Removed.
  • Layout/floats_100_100.html: Added.
  • Layout/floats_100_100_nested.html: Added.
  • Layout/floats_20_100.html: Added.
  • Layout/floats_20_100_nested.html: Added.
  • Layout/floats_2_100.html: Added.
  • Layout/floats_2_100_nested.html: Added.
  • Layout/floats_50_100.html: Added.
  • Layout/floats_50_100_nested.html: Added.
  • Layout/resources/floats.css: Added.

(.container):
(.float):
(.big):
(.float-end):

  • Layout/resources/floats.js: Added.

(.):

  • Skipped:
  • resources/runner.js:

(PerfTestRunner.resetRandomSeed):
(PerfTestRunner.random):
(Math.random):

Moved the Math.random to runner.js to be used by all tests.
Added resetRandomSeed to bring the randomizer back to initial seed.
It is useful to get the same results at every run and minimize the
differences between runs.

17:44 Changeset [110800] by andersca@apple.com

Fix build.

  • html/track/TextTrackList.cpp:
17:34 Changeset [110799] by jberlin@webkit.org

fullscreen/video-controls-drag.html failing on Mac
https://bugs.webkit.org/show_bug.cgi?id=81176

Land expected failing results to get the bots green.

  • platform/mac/fullscreen/video-controls-drag-expected.txt: Added.
17:26 Changeset [110798] by rniwa@webkit.org

Build fix.

  • dom/DynamicNodeList.h:

(DynamicSubtreeNodeList):

17:10 Changeset [110797] by rniwa@webkit.org

(register|unregister)DynamicSubtreeNodeList should be called only for labels and regions node lists
https://bugs.webkit.org/show_bug.cgi?id=80900

Reviewed by Antti Koivisto.

Cleaned up invalidation code for dynamic node lists. It seems like the existing code was utterly confused
about the lifetime of node lists and caches within them. First, register/unregsiterDynamicSubtreeNodeList
are called for all dynamic node lists even though it's only useful for labels and region node lists since
it's a mechanism to allow node lists to be invalidated at a node to which the node list doesn't belong.

Second, some node lists had dedicated member functions on Node to explicitly invalidate caches in
parsedAttribute. However, this is redundant because invalidateNodeListsCacheAfterAttributeChanged should be
able to invalidate caches when the attribute value changes. This patch gets rid of the last instance of such
function in HTMLLabelElement.

And finally, this patch restricts the callers of DynamicSubtreeNodeList::invalidateCache to be member
functions of NodeListsNodeData (now friends of DynamicSubtreeNodeList) to allow futher refactoring.

  • dom/DynamicNodeList.cpp:

(WebCore::DynamicSubtreeNodeList::DynamicSubtreeNodeList): Don't register the node list since it's only
useful for labels and region node lists.
(WebCore::DynamicSubtreeNodeList::~DynamicSubtreeNodeList): Ditto.

  • dom/DynamicNodeList.h:

(DynamicSubtreeNodeList):

  • dom/Node.cpp:

(WebCore):
(WebCore::Node::registerDynamicSubtreeNodeList): The comment about now we have to invalidate caches
when there had no caches is incorrect because registerDynamicSubtreeNodeList is called when a node list
is initially created. Also, if the tree scope didn't have any caches, then this is the first node list
to be added to the list, so there's no point in calling InvalidateCaches (no-op).
(WebCore::Node::unregisterDynamicSubtreeNodeList):
(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanged): Take care of "for" content attribute.
Also remove the redundant call to removeNodeListCacheIfPossible since we only invalidates node lists
and never remove entries from NodeListsNodeData in this function.
(WebCore::Node::invalidateNodeListsCacheAfterChildrenChanged): The call to removeNodeListCacheIfPossible
is also redundant here. Also removed the invalidation of m_listsWithCaches since it's already done in
invalidateCaches via invalidateCachesThatDependOnAttributes.
(WebCore::NodeListsNodeData::invalidateCaches): Removed the invalidation of m_labelsNodeListCache. It's
done in invalidateCachesThatDependOnAttributes.
(WebCore::NodeListsNodeData::invalidateCachesThatDependOnAttributes): Invalidate
m_listsInvalidatedAtDocument, which is renamed from m_listsWithCaches.
(WebCore::NodeListsNodeData::isEmpty):

  • dom/Node.h:

(Node):

  • dom/NodeRareData.h:

(NodeListsNodeData):

  • html/HTMLLabelElement.cpp:

(WebCore): Removed parseAttribute since the invalidation labels node list is now done by
invalidateNodeListsCacheAfterAttributeChanged and invalidateNodeListsCacheAfterChildrenChanged.

  • html/HTMLLabelElement.h:

(HTMLLabelElement):

  • html/LabelsNodeList.cpp:

(WebCore::LabelsNodeList::LabelsNodeList):
(WebCore::LabelsNodeList::~LabelsNodeList):

17:10 Changeset [110796] by abarth@webkit.org

More fun with repainting-after-animation-element-removal. These
results differ by only one pixel.

  • platform/chromium-linux/svg/repaint/repainting-after-animation-element-removal-expected.png: Added.
  • platform/chromium-mac-leopard/svg/repaint/repainting-after-animation-element-removal-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/repaint/repainting-after-animation-element-removal-expected.png: Removed.
17:10 Changeset [110795] by timothy_horton@apple.com

NRWT should respect --additional-platform-directory's Skipped list
https://bugs.webkit.org/show_bug.cgi?id=81172

Reviewed by Timothy Hatcher.

Respect the Skipped file inside all paths included via the --additional-platform-directory option. Test results
from said path are already used, but the Skipped file is ignored.

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._skipped_file_search_paths):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(test_skipped_file_search_paths):

17:08 Changeset [110794] by jamesr@google.com

[chromium] Fix a few more compositing baselines. Unreviewed.

  • platform/chromium-win/compositing/absolute-position-changed-with-composited-parent-layer-expected.png:
  • platform/chromium-win/compositing/culling/filter-occlusion-blur-expected.png:
  • platform/chromium-win/compositing/culling/filter-occlusion-blur-large-expected.png:
17:07 Changeset [110793] by abarth@webkit.org

Add some chromium-mac-leopard overrides for tests I rebaselined earlier.

  • platform/chromium-mac-leopard/css2.1/20110323/border-collapse-offset-002-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/filter-empty-element-crash-expected.png: Added.
17:06 Changeset [110792] by commit-queue@webkit.org

Run cacheFlush page by page to assure of flushing all the requested ranges
https://bugs.webkit.org/show_bug.cgi?id=77712

Patch by Hojong Han <hojong.han@samsung.com> on 2012-03-14
Reviewed by Geoffrey Garen.

Current MetaAllocator concept, always coalesces adjacent free spaces,
doesn't meet memory management of Linux kernel.
In a certain case Linux kernel doesn't regard contiguous virtual memory areas as one but two.
Therefore cacheFlush page by page guarantees a flush-requested range.

  • jit/ExecutableAllocator.h:

(JSC::ExecutableAllocator::cacheFlush):

17:02 Changeset [110791] by abarth@webkit.org

Add missing image baselines for new test added in <http://trac.webkit.org/changeset/110769>.

  • platform/chromium-linux/fast/css/pseudo-first-line-border-width-expected.png: Added.
  • platform/chromium-mac/fast/css/pseudo-first-line-border-width-expected.png: Added.
  • platform/chromium-win/fast/css/pseudo-first-line-border-width-expected.png: Added.
  • platform/chromium/fast/css/pseudo-first-line-border-width-expected.txt: Added.
17:02 Changeset [110790] by commit-queue@webkit.org

Unreviewed, rolling out r110565.
http://trac.webkit.org/changeset/110565
https://bugs.webkit.org/show_bug.cgi?id=81173

chromium deps are now far enough along that the original cl
should work (Requested by thakis on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-14

  • WebCore.gyp/mac/adjust_visibility.sh:
17:01 Changeset [110789] by ojan@chromium.org

Unreviewed, rolling out r110783.
http://trac.webkit.org/changeset/110783
https://bugs.webkit.org/show_bug.cgi?id=81054

Caused existing test expectation lines to expand to one for
each test configuration.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations.has_warnings):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(test_macro_overrides):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineTest._save_baseline):
(RebaselineTest._rebaseline_test):
(RebaselineTest.execute):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaseline.test_tests_to_update):

16:57 Changeset [110788] by abarth@webkit.org

Unreviewed, rolling out r110641.
http://trac.webkit.org/changeset/110641
https://bugs.webkit.org/show_bug.cgi?id=81170

Causes an ASAN failure (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-14

Source/WebCore:

  • Target.pri:
  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateNamedConstructorCallback):
(GenerateImplementation):

  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):

  • bindings/v8/NPV8Object.cpp:

(WebCore::npObjectTypeInfo):

  • bindings/v8/V8GCController.cpp:

(WebCore::GrouperVisitor::visitDOMWrapper):

  • bindings/v8/WrapperTypeInfo.h:

(WebCore):
(WrapperTypeInfo):

  • bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Copied from Source/WebCore/bindings/v8/custom/V8StyleSheetCustom.cpp.

(WebCore):
(WebCore::toV8):

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::toV8):
(WebCore):

  • bindings/v8/custom/V8DOMTokenListCustom.cpp: Copied from Source/WebCore/bindings/v8/custom/V8StyleSheetCustom.cpp.

(WebCore):
(WebCore::toV8):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore):

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:

(WebCore::toV8):
(WebCore):

  • bindings/v8/custom/V8StyleSheetCustom.cpp:

(WebCore::toV8):

  • css/CSSStyleSheet.idl:
  • css/StyleSheet.idl:
  • dom/DOMStringMap.idl:
  • dom/NamedNodeMap.idl:
  • html/DOMTokenList.idl:
  • html/track/TextTrackList.cpp:
  • html/track/TextTrackList.idl:

LayoutTests:

  • platform/chromium/test_expectations.txt:
16:54 Changeset [110787] by jamesr@google.com

[chromium] Unreviewed. Update many compositing baselines and expectations now that one major cause of flake is
fixed by r110741.

Filelist trimmed.

16:48 Changeset [110786] by abarth@webkit.org

Update chromium-mac-lion expectations after <http://trac.webkit.org/changeset/110763>.

  • platform/chromium-mac/media/audio-repaint-expected.png: Added.
  • platform/chromium-mac/media/audio-repaint-expected.txt: Added.
  • platform/chromium-mac/media/controls-layout-direction-expected.png: Added.
  • platform/chromium-mac/media/media-document-audio-repaint-expected.png: Added.
  • platform/chromium-mac/media/media-document-audio-repaint-expected.txt: Added.
16:41 Changeset [110785] by leviw@chromium.org

Correcting flooredLayoutPoint/Size to not floor on our branch (these preserve precision instead). Rounding image sizes inline with our RenderReplaced strategy. Fixing a pixel snapping bug in RenderListBox. Shuffling code in InlineTextBox for precision.

16:41 Changeset [110784] by jonlee@apple.com

Separate NOTIFICATIONS and LEGACY_NOTIFICATIONS
https://bugs.webkit.org/show_bug.cgi?id=80922
<rdar://problem/11035082>

Reviewed by Jian Li.

You can include either NOTIFICATIONS or LEGACY_NOTIFICATIONS and have a complete API.
LEGACY_NOTIFICATIONS should cover all of the previous functionality, and NOTIFICATIONS will cover the
new API. Therefore, APIs that are common between the two will have:

#if ENABLE(NOTIFICATIONS)
ENABLE(LEGACY_NOTIFICATIONS)

This patch initially sets both to be exactly the same. As other bugs with patches begin to migrate to
the new API, the defines will begin to split. This allows ports to decide which set of APIs to include.

Source/WebCore:

  • bindings/scripts/InFilesCompiler.pm: Update the script to handle the "|" flag in a conditional.

(preferredConditional):
(conditionalStringFromAttributeValue):
(generateInterfacesHeader):
(generateHeadersHeader):

Update everything to be #if ENABLE(NOTIFICATIONS)
ENABLE(LEGACY_NOTIFICATIONS)
  • WebCore.exp.in:
  • bindings/cpp/WebDOMEventTarget.cpp:

(toWebKit):

  • bindings/js/JSDesktopNotificationsCustom.cpp:
  • bindings/v8/custom/V8NotificationCenterCustom.cpp:
  • dom/EventTargetFactory.in:
  • notifications/Notification.cpp:
  • notifications/Notification.h:
  • notifications/Notification.idl:
  • notifications/NotificationCenter.cpp:
  • notifications/NotificationCenter.h:
  • notifications/NotificationCenter.idl:
  • notifications/NotificationContents.h:
  • notifications/NotificationController.cpp:
  • notifications/NotificationController.h:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::willDetachPage):
(WebCore::DOMWindow::disconnectDOMWindowProperties):
(WebCore::DOMWindow::clearDOMWindowProperties):
(WebCore):

  • page/DOMWindow.h:

(DOMWindow):

  • page/DOMWindow.idl:
  • page/Frame.cpp:

(WebCore::Frame::willDetachPage):
(WebCore::Frame::transferChildFrameToNewDocument):

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::~WorkerContext):
(WebCore):

  • workers/WorkerContext.h:

(WorkerContext):

  • workers/WorkerContext.idl:
  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::WorkerThread):

  • workers/WorkerThread.h:

(WorkerThread):

Source/WebKit/blackberry:

Update everything to be #if ENABLE(NOTIFICATIONS)
ENABLE(LEGACY_NOTIFICATIONS)
  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

  • WebCoreSupport/NotificationPresenterImpl.cpp:
  • WebCoreSupport/NotificationPresenterImpl.h:

Source/WebKit/chromium:

Update everything to be #if ENABLE(NOTIFICATIONS)
ENABLE(LEGACY_NOTIFICATIONS)
  • src/AssertMatchingEnums.cpp:
  • src/NotificationPresenterImpl.cpp:
  • src/NotificationPresenterImpl.h:
  • src/WebNotification.cpp:
  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableNotifications):
(WebKit::WebRuntimeFeatures::isNotificationsEnabled):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit):

  • src/WebViewImpl.h:

(WebViewImpl):

Source/WebKit/efl:

Update everything to be #if ENABLE(NOTIFICATIONS)
ENABLE(LEGACY_NOTIFICATIONS)
  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore):

  • WebCoreSupport/ChromeClientEfl.h:

(ChromeClientEfl):

  • WebCoreSupport/NotificationPresenterClientEfl.cpp:
  • WebCoreSupport/NotificationPresenterClientEfl.h:

Source/WebKit/mac:

Update everything to be #if ENABLE(NOTIFICATIONS)
ENABLE(LEGACY_NOTIFICATIONS)
  • WebCoreSupport/WebNotificationClient.h:
  • WebCoreSupport/WebNotificationClient.mm:

(WebNotificationClient::show):
(WebNotificationClient::cancel):
(WebNotificationClient::clearNotifications):
(WebNotificationClient::notificationObjectDestroyed):
(WebNotificationClient::notificationControllerDestroyed):
(WebNotificationClient::requestPermission):
(WebNotificationClient::checkPermission):

  • WebView/WebNotification.mm:

(-[WebNotification title]):
(-[WebNotification body]):
(-[WebNotification replaceID]):
(-[WebNotification origin]):
(-[WebNotification notificationID]):
(-[WebNotification dispatchShowEvent]):
(-[WebNotification dispatchCloseEvent]):
(-[WebNotification dispatchClickEvent]):
(-[WebNotification dispatchErrorEvent]):

  • WebView/WebNotificationInternal.h:
  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):

Source/WebKit/qt:

Update everything to be #if ENABLE(NOTIFICATIONS)
ENABLE(LEGACY_NOTIFICATIONS)
  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):
(QWebPagePrivate::~QWebPagePrivate):
(QWebPage::setFeaturePermission):

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::dumpNotification):
(DumpRenderTreeSupportQt::simulateDesktopNotificationClick):

  • WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore):
(WebCore::NotificationWrapper::NotificationWrapper):
(WebCore::NotificationWrapper::close):
(WebCore::NotificationWrapper::title):
(WebCore::NotificationWrapper::message):
(WebCore::NotificationWrapper::iconData):
(WebCore::NotificationWrapper::openerPageUrl):
(WebCore::NotificationWrapper::notificationClicked):
(WebCore::NotificationWrapper::notificationClosed):

  • WebCoreSupport/NotificationPresenterClientQt.h:

(WebCore):

Source/WebKit/win:

Update everything to be #if ENABLE(NOTIFICATIONS)
ENABLE(LEGACY_NOTIFICATIONS)
  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::WebChromeClient):

  • WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

  • WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
  • WebCoreSupport/WebDesktopNotificationsDelegate.h:

Source/WebKit/wince:

Update everything to be #if ENABLE(NOTIFICATIONS)
ENABLE(LEGACY_NOTIFICATIONS)
  • WebCoreSupport/ChromeClientWinCE.h:

(ChromeClientWinCE):

Source/WebKit2:

Update everything to be #if ENABLE(NOTIFICATIONS)
ENABLE(LEGACY_NOTIFICATIONS)
  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

(WebProcessCreationParameters):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureWebProcess):

  • WebProcess/Notifications/NotificationPermissionRequestManager.cpp:

(WebKit):
(WebKit::NotificationPermissionRequestManager::startRequest):
(WebKit::NotificationPermissionRequestManager::cancelRequest):
(WebKit::NotificationPermissionRequestManager::permissionLevel):
(WebKit::NotificationPermissionRequestManager::didReceiveNotificationPermissionDecision):

  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit):
(WebKit::WebNotificationManager::initialize):
(WebKit::WebNotificationManager::didUpdateNotificationDecision):
(WebKit::WebNotificationManager::didRemoveNotificationDecisions):
(WebKit::WebNotificationManager::policyForOrigin):
(WebKit::WebNotificationManager::show):
(WebKit::WebNotificationManager::cancel):
(WebKit::WebNotificationManager::clearNotifications):
(WebKit::WebNotificationManager::didDestroyNotification):
(WebKit::WebNotificationManager::didShowNotification):
(WebKit::WebNotificationManager::didClickNotification):
(WebKit::WebNotificationManager::didCloseNotifications):

  • WebProcess/Notifications/WebNotificationManager.h:

(WebNotificationManager):

  • WebProcess/WebCoreSupport/WebNotificationClient.cpp:
  • WebProcess/WebCoreSupport/WebNotificationClient.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::updatePreferences):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::didReceiveMessage):

  • WebProcess/WebProcess.h:

(WebProcess):

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

Tools:

Update everything to be #if ENABLE(NOTIFICATIONS)
ENABLE(LEGACY_NOTIFICATIONS)
  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::grantDesktopNotificationPermission):
(LayoutTestController::simulateDesktopNotificationClick):

  • DumpRenderTree/chromium/NotificationPresenter.cpp:
  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::resetTestController):

  • DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:

(DRTDesktopNotificationPresenter::checkNotificationPermission):

16:36 Changeset [110783] by ojan@chromium.org

Have webkit-patch rebaseline-test update test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=81054

Reviewed by Dirk Pranke.

This will allow us to use the All Failures tab in garden-o-matic
to rebaseline tests without making test_expectations.txt stale.

It's conservative and only removes lines if the test is
not flaky and fails in a way the rebaseline would fix (e.g.
CRASH/TIMEOUT will not be touched).

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations.remove_configuration_from_test):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(RemoveConfigurationsTest):
(RemoveConfigurationsTest.test_remove):
(test_remove_line):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineTest._is_supported_port):
(RebaselineTest):
(RebaselineTest._update_expectations_file):
(RebaselineTest._rebaseline_test_and_update_expectations):
(RebaselineTest.execute):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaseline.test_rebaseline_updates_expectations_file):

16:34 Changeset [110782] by abarth@webkit.org

Unreviewed, rolling out r110744.
http://trac.webkit.org/changeset/110744
https://bugs.webkit.org/show_bug.cgi?id=81168

Causes many WebAudio tests to crash in debug (Requested by
abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-14

  • platform/audio/Biquad.cpp:

(WebCore::Biquad::process):

16:29 Changeset [110781] by commit-queue@webkit.org

[Qt][WK2] Move code common to both ProxyAuthentication and Authentication context objects into a base class
https://bugs.webkit.org/show_bug.cgi?id=80627

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-03-14
Reviewed by Kenneth Rohde Christiansen.

No impact to QML API.

  • UIProcess/qt/QtDialogRunner.cpp:

(BaseAuthenticationContextObject):
(BaseAuthenticationContextObject::BaseAuthenticationContextObject):
(HttpAuthenticationDialogContextObject):
(HttpAuthenticationDialogContextObject::HttpAuthenticationDialogContextObject):
(HttpAuthenticationDialogContextObject::realm):
(ProxyAuthenticationDialogContextObject):
(ProxyAuthenticationDialogContextObject::ProxyAuthenticationDialogContextObject):
(QtDialogRunner::initForAuthentication):

16:27 Changeset [110780] by andersca@apple.com

With tiled drawing enabled, clicking a link to a PDF causes a cross-fade
https://bugs.webkit.org/show_bug.cgi?id=79247
<rdar://problem/10910808>

Reviewed by Sam Weinig.

Instead of creating a new CALayer for the WKView when we're in tiled mode, re-use the existing layer that AppKit makes for us.
This way, we won't get any implicit animations when we change layer properties (such as sublayers in this case).

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:contextRef:pageGroupRef:]):
(-[WKView wantsUpdateLayer]):
(-[WKView updateLayer]):

16:25 Changeset [110779] by jamesr@google.com

[chromium] Unreviewed. Update a few compositing baselines for tests that were marked flaky.

  • platform/chromium-mac-snowleopard/compositing/masks/masked-ancestor-expected.png: Added.
  • platform/chromium-mac/compositing/masks/masked-ancestor-expected.png:
  • platform/chromium-mac/compositing/reflections/masked-reflection-on-composited-expected.png:
  • platform/chromium-mac/compositing/reflections/reflection-positioning2-expected.png:
  • platform/chromium-win/compositing/masks/masked-ancestor-expected.png:
16:21 Changeset [110778] by abarth@webkit.org

Promote a number of chromium-mac-snowleopard results to chromium-mac.
Also, fix a wrong chromium-mac-leopard expectation. (The new
expectation show the drop shadow, like other platforms.)

  • platform/chromium-mac-leopard/css3/filters/effect-drop-shadow-hw-expected.png:
  • platform/chromium-mac-snowleopard/css3/filters/effect-combined-hw-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-drop-shadow-hw-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-hue-rotate-hw-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/effect-opacity-hw-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/filtered-compositing-descendant-expected.png: Removed.
  • platform/chromium-mac/css3/filters/effect-combined-hw-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-drop-shadow-hw-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-hue-rotate-hw-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-opacity-hw-expected.png: Added.
  • platform/chromium-mac/css3/filters/filtered-compositing-descendant-expected.png: Added.
16:14 Changeset [110777] by jberlin@webkit.org

Crash in WKTR under addChromeInputField due to using 0 as a key in a HashMap
https://bugs.webkit.org/show_bug.cgi?id=81167

Reviewed by Sam Weinig.

Do not use 0 as a key in a HashMap.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

cacheLayoutTestControllerCallback uses the enum as keys for the callback map.

16:08 Changeset [110776] by beidson@apple.com

<rdar://problem/11045584> and https://bugs.webkit.org/show_bug.cgi?id=81166 Repro crash in compositing/iframes/page-cache-layer-tree.html

Reviewed by Sam Weinig.

No new tests. (Discovered from and covered by existing test)

ScriptCachedFrameData doesn't need to keep a DOMWindow:

  • bindings/js/ScriptCachedFrameData.cpp:

(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):

  • bindings/js/ScriptCachedFrameData.h:

(ScriptCachedFrameData):

CachedFrame should grab it off the Frame directly and store it locally:

  • history/CachedFrame.cpp:

(WebCore::CachedFrame::CachedFrame):

  • history/CachedFrame.h:

(WebCore::CachedFrameBase::domWindow):
(CachedFrameBase):

16:01 Changeset [110775] by abarth@webkit.org

I've already updated the baselines for this test.

  • platform/chromium/test_expectations.txt:
15:58 Changeset [110774] by abarth@webkit.org

Update baselines for a number of svg/repaint tests and for some
tables/mozilla tests. These results all appear to be correct.

  • platform/chromium-linux-x86/tables/mozilla: Removed.
  • platform/chromium-linux/svg/repaint/filter-repaint-expected.png: Added.
  • platform/chromium-linux/svg/repaint/inner-svg-change-viewPort-relative-expected.png: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug86708-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/97619-expected.png:
  • platform/chromium-mac-leopard/svg/repaint/image-href-change-expected.png: Added.
  • platform/chromium-mac-leopard/svg/repaint/inner-svg-change-viewPort-relative-expected.png: Added.
  • platform/chromium-mac-leopard/svg/repaint/repainting-after-animation-element-removal-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug53690-1-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug178855-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/repaint/inner-svg-change-viewPort-relative-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/repaint/repainting-after-animation-element-removal-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug53690-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug178855-expected.png: Added.
  • platform/chromium-mac/svg/repaint/image-href-change-expected.png: Added.
  • platform/chromium-mac/svg/repaint/inner-svg-change-viewBox-contract-expected.png: Added.
  • platform/chromium-mac/svg/repaint/inner-svg-change-viewPort-relative-expected.png: Added.
  • platform/chromium-mac/svg/repaint/repainting-after-animation-element-removal-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug53690-1-expected.png: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug178855-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla/bugs: Removed.
  • platform/chromium-win/svg/repaint/filter-repaint-expected.png: Added.
  • platform/chromium-win/svg/repaint/filter-repaint-expected.txt: Added.
  • platform/chromium-win/svg/repaint/inner-svg-change-viewPort-relative-expected.png: Added.
  • platform/chromium-win/svg/repaint/inner-svg-change-viewPort-relative-expected.txt: Added.
  • platform/chromium-win/svg/repaint/repainting-after-animation-element-removal-expected.png: Added.
  • platform/chromium-win/tables/mozilla/bugs/bug86708-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug86708-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/97619-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/97619-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug178855-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug178855-expected.txt: Added.
  • platform/mac-snowleopard/svg/repaint/image-href-change-expected.png: Removed.
  • platform/mac/svg/repaint/inner-svg-change-viewPort-relative-expected.txt: Added.
  • svg/repaint/inner-svg-change-viewPort-relative-expected.txt: Removed.
15:58 Changeset [110773] by jamesr@google.com

[chromium] Deprecate renderDirectlyToWebView parameter of WebViewClient::createGraphicsContext3D()
https://bugs.webkit.org/show_bug.cgi?id=80523

Reviewed by Darin Fisher.

  • public/WebViewClient.h:

(WebViewClient):
(WebKit::WebViewClient::createGraphicsContext3D):

  • public/platform/WebKitPlatformSupport.h:

(WebKit):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::createCompositorGraphicsContext3D):

15:56 Changeset [110772] by tony@chromium.org

fix negative flexing in auto sized columns
https://bugs.webkit.org/show_bug.cgi?id=80069

Reviewed by Ojan Vafai.

Source/WebCore:

New test cases in css3/flexbox/columns-auto-size.html.

  • rendering/RenderFlexibleBox.cpp:

(WebCore):
(WebCore::RenderFlexibleBox::computeAvailableFreeSpace): Properly compute this for auto sizing columns. Previously, we would always return 0.
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithm): Drop an unnecessary check against undefined. isSpecified covers this for us.

  • rendering/RenderFlexibleBox.h:

(RenderFlexibleBox):

LayoutTests:

  • css3/flexbox/columns-auto-size-expected.txt:
  • css3/flexbox/columns-auto-size.html:
15:44 Changeset [110771] by abarth@webkit.org

Update baselines for these URL tests. These tests exist to document
differnces in behavior between KURL and GURL.

  • platform/chromium-linux/fast/url/file-http-base-expected.txt: Added.
  • platform/chromium-linux/fast/url/segments-expected.txt:
  • platform/chromium-linux/fast/url/segments-from-data-url-expected.txt:
  • platform/chromium-win/fast/url/file-http-base-expected.txt: Added.
  • platform/chromium-win/fast/url/segments-expected.txt:
  • platform/chromium-win/fast/url/segments-from-data-url-expected.txt:
  • platform/chromium/fast/url/anchor-expected.txt: Added.
  • platform/chromium/fast/url/file-http-base-expected.txt: Added.
  • platform/chromium/fast/url/ipv4-expected.txt: Added.
  • platform/chromium/fast/url/segments-expected.txt: Added.
  • platform/chromium/fast/url/segments-from-data-url-expected.txt: Added.
15:39 Changeset [110770] by abarth@webkit.org

These baselines all either look very similar to their expectations or
like improvements.

  • platform/chromium-linux/css3/unicode-bidi-isolate-aharon-failing-expected.png: Added.
  • platform/chromium-mac-leopard/css1/box_properties/acid_test-expected.png: Added.
  • platform/chromium-mac-leopard/css1/font_properties/font_family-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/t09-c5526c-display-00-e-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/t1503-c522-font-family-00-b-expected.png: Added.
  • platform/chromium-mac-leopard/css3/unicode-bidi-isolate-aharon-failing-expected.png: Added.
  • platform/chromium-mac-leopard/fast/xsl/mozilla-tests-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css1/box_properties/acid_test-expected.png: Added.
  • platform/chromium-mac-snowleopard/css1/font_properties/font_family-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t09-c5526c-display-00-e-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t0905-c414-flt-01-d-g-expected.png:
  • platform/chromium-mac-snowleopard/css3/unicode-bidi-isolate-aharon-failing-expected.png: Added.
  • platform/chromium-mac/css1/box_properties/acid_test-expected.png: Added.
  • platform/chromium-mac/css1/font_properties/font_family-expected.png: Added.
  • platform/chromium-mac/css1/text_properties/text_transform-expected.png: Added.
  • platform/chromium-mac/css1/text_properties/text_transform-expected.txt: Added.
  • platform/chromium-mac/css2.1/t09-c5526c-display-00-e-expected.png: Added.
  • platform/chromium-mac/css3/unicode-bidi-isolate-aharon-failing-expected.png: Added.
  • platform/chromium-win/css3/unicode-bidi-isolate-aharon-failing-expected.png: Added.
  • platform/chromium-win/fast/xsl/transform-xhr-doc-expected.txt: Removed.
  • platform/chromium/fast/xsl/transform-xhr-doc-expected.txt: Added.
15:24 Changeset [110769] by commit-queue@webkit.org

Incorrect handling of sizes in "em" when first-line changes font size
https://bugs.webkit.org/show_bug.cgi?id=79526

Patch by Grace Ku <gracek@codeaurora.org> on 2012-03-14
Reviewed by Eric Seidel.

Source/WebCore:

When a first-line pseudo class changes the font size, the "em" unit is handled incorrectly.
It uses the paragraph's original font size (the size of the rest of the paragraph) rather than
the font-size of the first-line of the paragraph.

This was corrected by checking if the InlineFlowBox was the first line using the existing
InlineFlowBox::isFirstLineStyle() function. The corrected behaviour matches Gecko and Presto.
Trident seems to get it half-wrong in the use case we are testing, painting the correct width for
the border but leaving the wrong amount of space.

The CSS specification doc at the time of this patch specifies that ':first-line' should only support
certain properties, though UAs may choose to apply more properties. Furthermore, the spec does not
define the exact rendering of all cases of ':first-line'. It notes that a more precise definition
may appear in future revisions.

Test: fast/css/pseudo-first-line-border-width.html

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paintBoxDecorations):

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::borderLogicalLeft):
(WebCore::InlineFlowBox::borderLogicalRight):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::RenderBoxModelObject::getBorderEdgeInfo):
(WebCore::RenderBoxModelObject::borderObscuresBackgroundEdge):
(WebCore::RenderBoxModelObject::borderObscuresBackground):

  • rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):

LayoutTests:

Checks that the width of the left-border of the span is the desired 10px
rather than 100px. The expect file is somewhat misleading since the computed
border width is still printed as 100px. The true test is in the position of the
RenderText box beside the left-border.

  • fast/css/pseudo-first-line-border-width.html: Added.
  • fast/css/pseudo-first-line-border-width-expected.txt: Added.
15:17 Changeset [110768] by abarth@webkit.org

Update some compositing baselines. These look correct. They just differ in scrollbars, etc.

  • platform/chromium-mac-leopard/compositing/direct-image-compositing-expected.png:
  • platform/chromium-mac-snowleopard/compositing/direct-image-compositing-expected.png:
  • platform/chromium-mac/compositing/direct-image-compositing-expected.png:
  • platform/chromium-win/compositing/absolute-position-changed-with-composited-parent-layer-expected.png: Added.
  • platform/chromium-win/compositing/direct-image-compositing-expected.png:
15:15 Changeset [110767] by lforschler@apple.com

Merged r110196.

15:13 Changeset [110766] by jberlin@webkit.org

WebKitTestRunner needs layoutTestController.displayInvalidatedRegion

Add a test that uses it to the wk2 Skipped list.

  • platform/wk2/Skipped:
15:06 Changeset [110765] by abarth@webkit.org

Add results for transforms/3d/general/background-visibility-layers.html.

  • platform/chromium-mac/transforms/3d: Added.
  • platform/chromium-mac/transforms/3d/general: Added.
  • platform/chromium-mac/transforms/3d/general/background-visibility-layers-expected.png: Added.
  • platform/chromium-win/transforms/3d/general: Added.
  • platform/chromium-win/transforms/3d/general/background-visibility-layers-expected.png: Added.
  • platform/chromium/transforms: Added.
  • platform/chromium/transforms/3d: Added.
  • platform/chromium/transforms/3d/general: Added.
  • platform/chromium/transforms/3d/general/background-visibility-layers-expected.txt: Added.
15:05 Changeset [110764] by mrobinson@webkit.org

Fix the TextureMapper build for GTK+.

No new tests. This is just a build fix.

  • platform/graphics/cairo/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):

  • platform/graphics/texmap/TextureMapper.h:
15:05 Changeset [110763] by commit-queue@webkit.org

Display attribute for video controls changed from display:block
to display:-webkit-box. Tests need to be rebaselined.

https://bugs.webkit.org/show_bug.cgi?id=80727

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-03-14
Reviewed by Eric Carlson.

  • platform/chromium-linux-x86/media/video-empty-source-expected.txt:
  • platform/chromium-linux/media/audio-repaint-expected.png:
  • platform/chromium-linux/media/media-document-audio-repaint-expected.png:
  • platform/chromium-linux/media/video-empty-source-expected.txt:
  • platform/chromium-mac-leopard/media/audio-repaint-expected.png:
  • platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac-leopard/media/video-empty-source-expected.txt:
  • platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
  • platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac-snowleopard/media/video-empty-source-expected.txt:
  • platform/chromium-mac/fast/layers/video-layer-expected.txt:
  • platform/chromium-mac/media/audio-controls-rendering-expected.txt:
  • platform/chromium-mac/media/audio-repaint-expected.png: Added.
  • platform/chromium-mac/media/audio-repaint-expected.txt: Renamed from LayoutTests/platform/chromium/media/audio-repaint-expected.txt.
  • platform/chromium-mac/media/controls-after-reload-expected.txt:
  • platform/chromium-mac/media/controls-layout-direction-expected.png: Added.
  • platform/chromium-mac/media/controls-strict-expected.png: Added.
  • platform/chromium-mac/media/controls-strict-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/media/controls-strict-expected.txt.
  • platform/chromium-mac/media/controls-styling-expected.txt:
  • platform/chromium-mac/media/controls-without-preload-expected.png: Added.
  • platform/chromium-mac/media/controls-without-preload-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/media/controls-without-preload-expected.txt.
  • platform/chromium-mac/media/media-controls-clone-expected.txt:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.png: Added.
  • platform/chromium-mac/media/media-document-audio-repaint-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.txt.
  • platform/chromium-mac/media/video-controls-rendering-expected.png: Added.
  • platform/chromium-mac/media/video-controls-rendering-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/media/video-controls-rendering-expected.txt.
  • platform/chromium-mac/media/video-display-toggle-expected.txt:
  • platform/chromium-mac/media/video-empty-source-expected.txt:
  • platform/chromium-mac/media/video-no-audio-expected.txt:
  • platform/chromium-mac/media/video-playing-and-pause-expected.txt:
  • platform/chromium-mac/media/video-volume-slider-expected.png: Added.
  • platform/chromium-mac/media/video-volume-slider-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/media/video-volume-slider-expected.txt.
  • platform/chromium-mac/media/video-zoom-controls-expected.txt:
  • platform/chromium-win-vista/media/video-empty-source-expected.txt:
  • platform/chromium-win-xp/media/video-empty-source-expected.txt:
  • platform/chromium-win/fast/layers/video-layer-expected.txt:
  • platform/chromium-win/media/audio-controls-rendering-expected.txt:
  • platform/chromium-win/media/audio-repaint-expected.png:
  • platform/chromium-win/media/audio-repaint-expected.txt:
  • platform/chromium-win/media/controls-after-reload-expected.txt:
  • platform/chromium-win/media/controls-strict-expected.txt:
  • platform/chromium-win/media/controls-styling-expected.txt:
  • platform/chromium-win/media/controls-without-preload-expected.txt:
  • platform/chromium-win/media/media-controls-clone-expected.txt:
  • platform/chromium-win/media/media-document-audio-repaint-expected.png:
  • platform/chromium-win/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-win/media/video-controls-rendering-expected.txt:
  • platform/chromium-win/media/video-display-toggle-expected.txt:
  • platform/chromium-win/media/video-empty-source-expected.txt:
  • platform/chromium-win/media/video-no-audio-expected.txt:
  • platform/chromium-win/media/video-playing-and-pause-expected.txt:
  • platform/chromium-win/media/video-volume-slider-expected.txt:
  • platform/chromium-win/media/video-zoom-controls-expected.txt:
  • platform/chromium/test_expectations.txt:
15:04 Changeset [110762] by mrobinson@webkit.org

[GTK] Menulist buttons have separators even when the theme turns them off
https://bugs.webkit.org/show_bug.cgi?id=80668

Reviewed by Daniel Bates.

No new tests. GTK+ theme differences are notoriously difficult
to test, because consistent results depend on having certain themes
and certain versions of themes installed.

Instead of using the GTK_TYPE_BUTTON and GTK_TYPE_SEPARATOR tags to get the
style context, use GTK_TYPE_COMBO_BOX which should provide more accurate theme settings.

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore::getComboBoxMetrics): Get metrics from a GTK_TYPE_COMBO_BOX style context.
(WebCore::RenderThemeGtk::paintMenuList): Get separator settings from the GTK_TYPE_COMBO_BOX style context.

15:02 Changeset [110761] by leviw@chromium.org

Implement proper sub-pixel support in RenderFileUploadControl
https://bugs.webkit.org/show_bug.cgi?id=80881

Reviewed by Dimitri Glazkov.

Correcting improper usage of LayoutUnits when interacting with the graphics context
and platform code. Specifically:

  • pixel snapping the clip rect and paint offsets before sending values to the graphics context in paintObject.
  • using on-screen (pixel snapped) values to pass off to platform code to determine the max length of the filename to be drawn.

No new tests. No change in behavior.

  • rendering/RenderFileUploadControl.cpp:

(WebCore::nodeWidth):
(WebCore::RenderFileUploadControl::maxFilenameWidth):
(WebCore::RenderFileUploadControl::paintObject):

14:56 Changeset [110760] by commit-queue@webkit.org

[JSC] Web Inspector: CRASH running $0, $1, etc before they are set
https://bugs.webkit.org/show_bug.cgi?id=81082

Source/WebCore:

Don't return an invalid JSValue. Check if the ScriptValue
has no value and return undefined in that case.

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-03-14
Reviewed by Pavel Feldman.

Updated test: inspector/console/command-line-api.html

  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::inspectedObject):

LayoutTests:

Test for an undefined inspectedObject.

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-03-14
Reviewed by Pavel Feldman.

  • inspector/console/command-line-api-expected.txt:
  • inspector/console/command-line-api.html:
14:43 Changeset [110759] by enne@google.com

[chromium] Unreviewed, mark two compositing tests as passing.
https://bugs.webkit.org/show_bug.cgi?id=75568

  • platform/chromium/test_expectations.txt:
14:43 Changeset [110758] by lforschler@apple.com

Merged r107307.

14:42 Changeset [110757] by jamesr@google.com

[chromium] Remove canRecoverFromContextLoss attribute, it's unused
https://bugs.webkit.org/show_bug.cgi?id=81158

Reviewed by Stephen White.

Source/WebCore:

Canvas accelerated no longer depends on the canRecoverFromContextLoss attribute after r110716.

  • platform/graphics/GraphicsContext3D.h:

(WebCore::GraphicsContext3D::Attributes::Attributes):
(Attributes):

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp:

(WebCore::SharedGraphicsContext3DImpl::get):

Source/WebKit/chromium:

Deletes the canRecoverFromContextLoss attribute from WebCore::GraphicsContext3D::Attributes. This is still left in
WebGraphicsContext3D::Attributes, since chromium-side code still references it.

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3D::create):

14:40 Changeset [110756] by lforschler@apple.com

Merged r107267.

14:35 Changeset [110755] by lforschler@apple.com

Merged r110480.

14:34 Changeset [110754] by jer.noble@apple.com

Opening a URL in a MediaDocument does not propagate MIME type info to media element
https://bugs.webkit.org/show_bug.cgi?id=81148

Reviewed by Eric Carlson.

Source/WebCore:

Test: http/tests/media/media-document.html

Pass through the mime type from the DocumentLoader into the <source type=""> attribute of the
generated video element.

  • html/MediaDocument.cpp:

(WebCore::MediaDocumentParser::createDocumentStructure):

LayoutTests:

  • http/tests/media/media-document-expected.txt: Added.
  • http/tests/media/media-document.html: Added.
14:27 Changeset [110753] by senorblanco@chromium.org

[chromium] Fix accelerated Canvas2D with threaded compositing.
https://bugs.webkit.org/show_bug.cgi?id=80998

Reviewed by James Robinson.

Source/WebCore:

Covered by unit tests Canvas2DLayerChromiumTest and
TreeSynchronizerTest.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):
(WebCore):
Delay creation of the front texture for double-buffering until the
first call to paintContentsIfDirty().

  • platform/graphics/chromium/Canvas2DLayerChromium.h:

(Canvas2DLayerChromium):
Remove setTextureManager() and setLayerTreeHost(), since their job
has been subsumed by paintContentsIfDirty().

  • platform/graphics/chromium/TreeSynchronizer.cpp:

(WebCore::TreeSynchronizer::updateScrollbarLayerPointersRecursive):
Perform an early-out if the passed-in layer is NULL.

Source/WebKit/chromium:

  • tests/Canvas2DLayerChromiumTest.cpp:

Instantiate a CCLayerTreeHost, so that Canvas2DLayerChromium can
retrieve its texture manager. Also move the test into the unnamed
namespace -- since it's already using WebCore, there's little reason for
it to also be in the namespace.

  • tests/TreeSynchronizerTest.cpp:

(WebKitTests):
(WebKitTests::TEST):
Add a new test for trying to synchronize NULL tree.

14:24 Changeset [110752] by lforschler@apple.com

Merged r104240.

14:21 Changeset [110751] by oliver@apple.com

Make ARMv7 work again
https://bugs.webkit.org/show_bug.cgi?id=81157

Reviewed by Geoffrey Garen.

We were trying to use the ARMv7 dataRegister as a scratch register in a scenario
where we the ARMv7MacroAssembler would also try to use dataRegister for its own
nefarious purposes.

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::store32):

  • assembler/MacroAssemblerARMv7.h:

(MacroAssemblerARMv7):

14:20 Changeset [110750] by dgrogan@chromium.org

IndexedDB layout tests: factor out prefix-handling-code
https://bugs.webkit.org/show_bug.cgi?id=80664

This makes our tests vendor neutral so that we can load them in any
browser to check what that browser does.

Also changed some instances of 'window' to 'self' so that they are more
worker friendly.

Reviewed by Tony Chang.

  • storage/indexeddb/basics-expected.txt:
  • storage/indexeddb/basics-shared-workers-expected.txt:
  • storage/indexeddb/basics-workers-expected.txt:
  • storage/indexeddb/constants-expected.txt:
  • storage/indexeddb/constants.html:
  • storage/indexeddb/create-and-remove-object-store-expected.txt:
  • storage/indexeddb/create-and-remove-object-store.html:
  • storage/indexeddb/create-object-store-options-expected.txt:
  • storage/indexeddb/create-object-store-options.html:
  • storage/indexeddb/createObjectStore-name-argument-required-expected.txt:
  • storage/indexeddb/createObjectStore-name-argument-required.html:
  • storage/indexeddb/createObjectStore-null-name-expected.txt:
  • storage/indexeddb/createObjectStore-null-name.html:
  • storage/indexeddb/cursor-continue-expected.txt:
  • storage/indexeddb/cursor-continue.html:
  • storage/indexeddb/cursor-delete-expected.txt:
  • storage/indexeddb/cursor-delete.html:
  • storage/indexeddb/cursor-inconsistency-expected.txt:
  • storage/indexeddb/cursor-inconsistency.html:
  • storage/indexeddb/cursor-index-delete-expected.txt:
  • storage/indexeddb/cursor-index-delete.html:
  • storage/indexeddb/cursor-key-order-expected.txt:
  • storage/indexeddb/cursor-key-order.html:
  • storage/indexeddb/cursor-primary-key-order-expected.txt:
  • storage/indexeddb/cursor-primary-key-order.html:
  • storage/indexeddb/cursor-reverse-bug-expected.txt:
  • storage/indexeddb/cursor-reverse-bug.html:
  • storage/indexeddb/cursor-skip-deleted-expected.txt:
  • storage/indexeddb/cursor-skip-deleted.html:
  • storage/indexeddb/cursor-update-expected.txt:
  • storage/indexeddb/cursor-update-value-argument-required-expected.txt:
  • storage/indexeddb/cursor-update-value-argument-required.html:
  • storage/indexeddb/cursor-update.html:
  • storage/indexeddb/data-corruption-expected.txt:
  • storage/indexeddb/data-corruption.html:
  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/database-basics.html:
  • storage/indexeddb/database-name-undefined-expected.txt:
  • storage/indexeddb/database-name-undefined.html:
  • storage/indexeddb/database-odd-names-expected.txt:
  • storage/indexeddb/database-odd-names.html:
  • storage/indexeddb/database-quota-expected.txt:
  • storage/indexeddb/database-quota.html:
  • storage/indexeddb/delete-closed-database-object-expected.txt:
  • storage/indexeddb/delete-closed-database-object.html:
  • storage/indexeddb/delete-range-expected.txt:
  • storage/indexeddb/delete-range.html:
  • storage/indexeddb/deleteIndex-expected.txt:
  • storage/indexeddb/deleteIndex.html:
  • storage/indexeddb/deleteObjectStore-name-argument-required-expected.txt:
  • storage/indexeddb/deleteObjectStore-name-argument-required.html:
  • storage/indexeddb/deleteObjectStore-null-name-expected.txt:
  • storage/indexeddb/deleteObjectStore-null-name.html:
  • storage/indexeddb/duplicates-expected.txt:
  • storage/indexeddb/duplicates.html:
  • storage/indexeddb/error-causes-abort-by-default-expected.txt:
  • storage/indexeddb/error-causes-abort-by-default.html:
  • storage/indexeddb/exception-in-event-aborts-expected.txt:
  • storage/indexeddb/exception-in-event-aborts.html:
  • storage/indexeddb/factory-basics-expected.txt:
  • storage/indexeddb/factory-basics.html:
  • storage/indexeddb/factory-cmp-expected.txt:
  • storage/indexeddb/factory-cmp.html:
  • storage/indexeddb/factory-deletedatabase-expected.txt:
  • storage/indexeddb/factory-deletedatabase-interactions-expected.txt:
  • storage/indexeddb/factory-deletedatabase-interactions.html:
  • storage/indexeddb/factory-deletedatabase.html:
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics-workers-expected.txt:
  • storage/indexeddb/index-count-expected.txt:
  • storage/indexeddb/index-count.html:
  • storage/indexeddb/index-cursor-expected.txt:
  • storage/indexeddb/index-cursor.html:
  • storage/indexeddb/index-get-key-argument-required-expected.txt:
  • storage/indexeddb/index-get-key-argument-required.html:
  • storage/indexeddb/index-multientry-expected.txt:
  • storage/indexeddb/index-multientry.html:
  • storage/indexeddb/index-population-expected.txt:
  • storage/indexeddb/index-population.html:
  • storage/indexeddb/index-unique-expected.txt:
  • storage/indexeddb/index-unique.html:
  • storage/indexeddb/invalid-keys-expected.txt:
  • storage/indexeddb/invalid-keys.html:
  • storage/indexeddb/key-generator-expected.txt:
  • storage/indexeddb/key-generator.html:
  • storage/indexeddb/key-sort-order-across-types-expected.txt:
  • storage/indexeddb/key-sort-order-across-types.html:
  • storage/indexeddb/key-sort-order-date-expected.txt:
  • storage/indexeddb/key-sort-order-date.html:
  • storage/indexeddb/key-type-array-expected.txt:
  • storage/indexeddb/key-type-array.html:
  • storage/indexeddb/key-type-infinity-expected.txt:
  • storage/indexeddb/key-type-infinity.html:
  • storage/indexeddb/keypath-basics-expected.txt:
  • storage/indexeddb/keypath-basics.html:
  • storage/indexeddb/keypath-edges-expected.txt:
  • storage/indexeddb/keypath-edges.html:
  • storage/indexeddb/keypath-fetch-key-expected.txt:
  • storage/indexeddb/keypath-fetch-key.html:
  • storage/indexeddb/keyrange-expected.txt:
  • storage/indexeddb/keyrange-required-arguments-expected.txt:
  • storage/indexeddb/keyrange-required-arguments.html:
  • storage/indexeddb/keyrange.html:
  • storage/indexeddb/list-ordering-expected.txt:
  • storage/indexeddb/list-ordering.html:
  • storage/indexeddb/mozilla/add-twice-failure-expected.txt:
  • storage/indexeddb/mozilla/add-twice-failure.html:
  • storage/indexeddb/mozilla/autoincrement-indexes-expected.txt:
  • storage/indexeddb/mozilla/autoincrement-indexes.html:
  • storage/indexeddb/mozilla/bad-keypath-expected.txt:
  • storage/indexeddb/mozilla/bad-keypath.html:
  • storage/indexeddb/mozilla/clear-expected.txt:
  • storage/indexeddb/mozilla/clear.html:
  • storage/indexeddb/mozilla/create-index-unique-expected.txt:
  • storage/indexeddb/mozilla/create-index-unique.html:
  • storage/indexeddb/mozilla/create-index-with-integer-keys-expected.txt:
  • storage/indexeddb/mozilla/create-index-with-integer-keys.html:
  • storage/indexeddb/mozilla/create-objectstore-basics-expected.txt:
  • storage/indexeddb/mozilla/create-objectstore-basics.html:
  • storage/indexeddb/mozilla/create-objectstore-null-name-expected.txt:
  • storage/indexeddb/mozilla/create-objectstore-null-name.html:
  • storage/indexeddb/mozilla/cursor-mutation-expected.txt:
  • storage/indexeddb/mozilla/cursor-mutation-objectstore-only-expected.txt:
  • storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html:
  • storage/indexeddb/mozilla/cursor-mutation.html:
  • storage/indexeddb/mozilla/cursor-update-updates-indexes-expected.txt:
  • storage/indexeddb/mozilla/cursor-update-updates-indexes.html:
  • storage/indexeddb/mozilla/cursors-expected.txt:
  • storage/indexeddb/mozilla/cursors.html:
  • storage/indexeddb/mozilla/delete-result-expected.txt:
  • storage/indexeddb/mozilla/delete-result.html:
  • storage/indexeddb/mozilla/event-source-expected.txt:
  • storage/indexeddb/mozilla/event-source.html:
  • storage/indexeddb/mozilla/global-data-expected.txt:
  • storage/indexeddb/mozilla/global-data.html:
  • storage/indexeddb/mozilla/indexes-expected.txt:
  • storage/indexeddb/mozilla/indexes.html:
  • storage/indexeddb/mozilla/key-requirements-delete-null-key-expected.txt:
  • storage/indexeddb/mozilla/key-requirements-delete-null-key.html:
  • storage/indexeddb/mozilla/key-requirements-expected.txt:
  • storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt:
  • storage/indexeddb/mozilla/key-requirements-inline-and-passed.html:
  • storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt:
  • storage/indexeddb/mozilla/key-requirements-put-no-key.html:
  • storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt:
  • storage/indexeddb/mozilla/key-requirements-put-null-key.html:
  • storage/indexeddb/mozilla/key-requirements.html:
  • storage/indexeddb/mozilla/object-cursors-expected.txt:
  • storage/indexeddb/mozilla/object-cursors.html:
  • storage/indexeddb/mozilla/object-identity-expected.txt:
  • storage/indexeddb/mozilla/object-identity.html:
  • storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put-expected.txt:
  • storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put.html:
  • storage/indexeddb/mozilla/object-store-remove-values-expected.txt:
  • storage/indexeddb/mozilla/object-store-remove-values.html:
  • storage/indexeddb/mozilla/objectstorenames-expected.txt:
  • storage/indexeddb/mozilla/objectstorenames.html:
  • storage/indexeddb/mozilla/odd-result-order-expected.txt:
  • storage/indexeddb/mozilla/odd-result-order.html:
  • storage/indexeddb/mozilla/open-database-null-name-expected.txt:
  • storage/indexeddb/mozilla/open-database-null-name.html:
  • storage/indexeddb/mozilla/put-get-values-expected.txt:
  • storage/indexeddb/mozilla/put-get-values.html:
  • storage/indexeddb/mozilla/readonly-transactions-expected.txt:
  • storage/indexeddb/mozilla/readonly-transactions.html:
  • storage/indexeddb/mozilla/readwrite-transactions-expected.txt:
  • storage/indexeddb/mozilla/readwrite-transactions.html:
  • storage/indexeddb/mozilla/readyState-expected.txt:
  • storage/indexeddb/mozilla/readyState.html:
  • storage/indexeddb/mozilla/remove-index-expected.txt:
  • storage/indexeddb/mozilla/remove-index.html:
  • storage/indexeddb/mozilla/remove-objectstore-expected.txt:
  • storage/indexeddb/mozilla/remove-objectstore.html:
  • storage/indexeddb/mozilla/versionchange-abort-expected.txt:
  • storage/indexeddb/mozilla/versionchange-abort.html:
  • storage/indexeddb/mozilla/versionchange-expected.txt:
  • storage/indexeddb/mozilla/versionchange.html:
  • storage/indexeddb/mutating-cursor-expected.txt:
  • storage/indexeddb/mutating-cursor.html:
  • storage/indexeddb/objectStore-required-arguments-expected.txt:
  • storage/indexeddb/objectStore-required-arguments.html:
  • storage/indexeddb/objectstore-autoincrement-expected.txt:
  • storage/indexeddb/objectstore-autoincrement.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics-workers-expected.txt:
  • storage/indexeddb/objectstore-clear-expected.txt:
  • storage/indexeddb/objectstore-clear.html:
  • storage/indexeddb/objectstore-count-expected.txt:
  • storage/indexeddb/objectstore-count.html:
  • storage/indexeddb/objectstore-cursor-expected.txt:
  • storage/indexeddb/objectstore-cursor.html:
  • storage/indexeddb/objectstore-removeobjectstore-expected.txt:
  • storage/indexeddb/objectstore-removeobjectstore.html:
  • storage/indexeddb/odd-strings-expected.txt:
  • storage/indexeddb/odd-strings.html:
  • storage/indexeddb/open-close-version-expected.txt:
  • storage/indexeddb/open-close-version.html:
  • storage/indexeddb/open-cursor-expected.txt:
  • storage/indexeddb/open-cursor.html:
  • storage/indexeddb/open-during-transaction-expected.txt:
  • storage/indexeddb/open-during-transaction.html:
  • storage/indexeddb/prefetch-bugfix-108071-expected.txt:
  • storage/indexeddb/prefetch-bugfix-108071.html:
  • storage/indexeddb/queued-commands-expected.txt:
  • storage/indexeddb/queued-commands.html:
  • storage/indexeddb/readonly-expected.txt:
  • storage/indexeddb/readonly-properties-expected.txt:
  • storage/indexeddb/readonly-properties.html:
  • storage/indexeddb/readonly.html:
  • storage/indexeddb/request-event-propagation-expected.txt:
  • storage/indexeddb/request-event-propagation.html:
  • storage/indexeddb/resources/basics.js:

(test):
(openCallback):

  • storage/indexeddb/resources/index-basics.js:

(test):

  • storage/indexeddb/resources/objectstore-basics.js:

(test):
(setVersionSuccess):
(createIndex):
(addData):
(addAgainFailure):
(removeSuccessButNotThere):
(testPreConditions.request.onsuccess):
(testPreConditions):

  • storage/indexeddb/resources/shared.js:

(removeVendorPrefixes):

  • storage/indexeddb/resources/transaction-abort-workers.js:

(transactionAborted):
(transactionCompleted):
(timeoutTest.transaction.onabort):
(timeoutTest):
(errorTransactionAborted):

  • storage/indexeddb/setVersion-null-expected.txt:
  • storage/indexeddb/setVersion-null.html:
  • storage/indexeddb/setVersion-undefined-expected.txt:
  • storage/indexeddb/setVersion-undefined.html:
  • storage/indexeddb/set_version_blocked-expected.txt:
  • storage/indexeddb/set_version_blocked.html:
  • storage/indexeddb/set_version_queue-expected.txt:
  • storage/indexeddb/set_version_queue.html:
  • storage/indexeddb/structured-clone-expected.txt:
  • storage/indexeddb/structured-clone.html:
  • storage/indexeddb/transaction-abort-expected.txt:
  • storage/indexeddb/transaction-abort-with-js-recursion-cross-frame-expected.txt:
  • storage/indexeddb/transaction-abort-with-js-recursion-cross-frame.html:
  • storage/indexeddb/transaction-abort-with-js-recursion-expected.txt:
  • storage/indexeddb/transaction-abort-with-js-recursion.html:
  • storage/indexeddb/transaction-abort-workers-expected.txt:
  • storage/indexeddb/transaction-abort.html:
  • storage/indexeddb/transaction-after-close-expected.txt:
  • storage/indexeddb/transaction-after-close.html:
  • storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
  • storage/indexeddb/transaction-and-objectstore-calls.html:
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-basics.html:
  • storage/indexeddb/transaction-crash-on-abort-expected.txt:
  • storage/indexeddb/transaction-crash-on-abort.html:
  • storage/indexeddb/transaction-event-propagation-expected.txt:
  • storage/indexeddb/transaction-event-propagation.html:
  • storage/indexeddb/transaction-read-only-expected.txt:
  • storage/indexeddb/transaction-read-only.html:
  • storage/indexeddb/transaction-rollback-expected.txt:
  • storage/indexeddb/transaction-rollback.html:
  • storage/indexeddb/transaction-storeNames-required-expected.txt:
  • storage/indexeddb/transaction-storeNames-required.html:
  • storage/indexeddb/two-version-changes-expected.txt:
  • storage/indexeddb/two-version-changes.html:
  • storage/indexeddb/value-undefined-expected.txt:
  • storage/indexeddb/value-undefined.html:
  • storage/indexeddb/values-odd-types-expected.txt:
  • storage/indexeddb/values-odd-types.html:
  • storage/indexeddb/version-change-abort-expected.txt:
  • storage/indexeddb/version-change-abort.html:
  • storage/indexeddb/version-change-exclusive-expected.txt:
  • storage/indexeddb/version-change-exclusive.html:
  • storage/indexeddb/versionchangerequest-activedomobject-expected.txt:
  • storage/indexeddb/versionchangerequest-activedomobject.html:
14:20 Changeset [110749] by commit-queue@webkit.org

Move EntriesCallback to Modules/filesystem/
https://bugs.webkit.org/show_bug.cgi?id=81032

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-03-14
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Modules/filesystem/EntriesCallback.h: Copied from Source/WebCore/fileapi/EntriesCallback.h.
  • Modules/filesystem/EntriesCallback.idl: Copied from Source/WebCore/fileapi/EntriesCallback.idl.
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • fileapi/EntriesCallback.h: Removed.
  • fileapi/EntriesCallback.idl: Removed.
14:14 Changeset [110748] by mhahnenberg@apple.com

Heap::destroy leaks CopiedSpace
https://bugs.webkit.org/show_bug.cgi?id=81055

Reviewed by Geoffrey Garen.

Added a destroy() function to CopiedSpace that moves all normal size
CopiedBlocks from the CopiedSpace to the Heap's list of free blocks
as well as deallocates all of the oversize blocks in the CopiedSpace.
This function is now called in Heap::destroy().

  • heap/CopiedSpace.cpp:

(JSC::CopiedSpace::destroy):
(JSC):

  • heap/CopiedSpace.h:

(CopiedSpace):

  • heap/Heap.cpp:

(JSC::Heap::destroy):

14:10 Changeset [110747] by tony@chromium.org

multiline column flexbox with auto height wrap too much
https://bugs.webkit.org/show_bug.cgi?id=80929

Reviewed by David Hyatt.

Source/WebCore:

Test: css3/flexbox/multiline-column-auto.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalHeightUsing):
(WebCore):
(WebCore::RenderBox::computeContentLogicalHeightUsing): Pull out into a separate method.

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::lineBreakLength): Compute the value based on height & max-height for column layout.
(WebCore):
(WebCore::RenderFlexibleBox::computeNextFlexLine):

  • rendering/RenderFlexibleBox.h:

(RenderFlexibleBox):

LayoutTests:

  • css3/flexbox/multiline-column-auto-expected.txt: Added.
  • css3/flexbox/multiline-column-auto.html: Added.
  • css3/flexbox/multiline-shrink-to-fit-expected.html:
  • css3/flexbox/multiline-shrink-to-fit.html:
14:04 Changeset [110746] by commit-queue@webkit.org

Unreviewed, rolling out r110559.
http://trac.webkit.org/changeset/110559
https://bugs.webkit.org/show_bug.cgi?id=81142

Broke Dromaeo tests (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-14

  • Dromaeo/resources/dromaeorunner.js:

(.):

14:04 Changeset [110745] by jberlin@webkit.org

PeerConnection was renamed to DeprecatedPeerConnection in r110587. Update the expected
results.

The rebaseline landed for Qt in 110685 should actually have been landed for all ports.
Land it for all ports, and remove the Qt specific expected results.

  • fast/dom/call-a-constructor-as-a-function-expected.txt:
  • platform/qt/fast/dom/call-a-constructor-as-a-function-expected.txt: Removed.
14:01 Changeset [110744] by commit-queue@webkit.org

Optimize the multiply-add in Biquad.cpp::process
https://bugs.webkit.org/show_bug.cgi?id=75528

Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-03-14
Reviewed by Chris Rogers.

Pipeline the multiply-add with SSE2 instructions and get about 20% improvement for the function.

  • platform/audio/Biquad.cpp:

(WebCore::Biquad::process):

13:59 Changeset [110743] by ap@apple.com

WebProcess sometimes hits an assertion in SandboxExtensionTracker::didCommitProvisionalLoad after running regression tests
https://bugs.webkit.org/show_bug.cgi?id=81150
<rdar://problem/11002254>

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::SandboxExtensionTracker::didCommitProvisionalLoad): (WebKit::WebPage::SandboxExtensionTracker::didFailProvisionalLoad): It's not great, but for now we need to handle this case. Hopefully, some day we'll make both WebKit2 processes better aware of what's going on with loading in WebCore.
13:57 Changeset [110742] by abarth@webkit.org

Clean up a few more baseline.

  • platform/chromium-mac-snowleopard/css2.1/20110323/border-collapse-offset-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/filter-empty-element-crash-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/unicode-variation-selector-expected.png:
  • platform/chromium-win-xp/svg/dynamic-updates: Removed.
  • platform/chromium-win-xp/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Removed.
13:52 Changeset [110741] by jamesr@google.com

[Chromium] Layout Test compositing/repaint/opacity-between-absolute.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=79823

Reviewed by Adrienne Walker.

Source/WebCore:

LayerRendererChromium was storing a weak pointer to the current render surface in m_currentRenderSurface and
using this in useRenderSurface() to avoid rebinding if we called useRenderSurface() multiple times in a row on
the same surface. This pointer was never cleared, so if any subsequent surface landed at the same address this
caching would misbehave and we'd fail to correctly initialize the new render surface. The caching wasn't
actually buying us anything anyway since we only call useRenderSurface() once per surface per frame and we
always set the viewport for the default render surface.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::beginDrawingFrame):
(WebCore::LayerRendererChromium::useRenderSurface):

LayoutTests:

  • platform/chromium/test_expectations.txt:
13:38 Changeset [110740] by jberlin@webkit.org

WKTR doesn't have an implemenation of hasSpellingMarker yet.

Add more tests that rely on it to the WK2 Skipped list.

  • platform/wk2/Skipped:
13:30 Changeset [110739] by ojan@chromium.org

Add the chromium lion bot to garden-o-matic and remove
the platform_move_to in builders.py since the Chromium Lion
port is now a normal port.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  • Scripts/webkitpy/layout_tests/port/builders.py:
13:22 Changeset [110738] by commit-queue@webkit.org

Frame flattening ASSERT(!needsLayout()) in FrameView::paintContents()
https://bugs.webkit.org/show_bug.cgi?id=80155

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-03-14
Reviewed by Antti Koivisto.

Source/WebCore:

This patch ensures that an iframe only schedules and calls parent's layout,
when it is going to be flattened. Non-flattened iframe does not affect
parent's layout, so normal layout flow applies. isInSubframeLayoutWithFrameFlattening()
function has been added to test whether a particular child frame is changing
parent's layout. This function also ensures that scheduleRelayout() and layout()
are in sync of checking againts frame flattening.

Test: fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-with-js-forced-layout.html

  • page/FrameView.cpp:

(WebCore::FrameView::avoidScrollbarCreation):
(WebCore::FrameView::layout):
(WebCore::FrameView::scheduleRelayout):
(WebCore::FrameView::isInChildFrameWithFrameFlattening):
(WebCore):
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):

  • page/FrameView.h:

(FrameView):

  • rendering/RenderIFrame.h:

(RenderIFrame):
(WebCore::RenderIFrame::renderName):

LayoutTests:

  • fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-with-js-forced-layout-expected.txt: Added.
  • fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-with-js-forced-layout.html: Added.
13:07 Changeset [110737] by andersca@apple.com

Don't cap the scroll position if layout happens when a FrameView's overhangAmount is non-zero
https://bugs.webkit.org/show_bug.cgi?id=81146
<rdar://problem/10850075>

Reviewed by Beth Dakin.

If layout happens when a page has a non-zero overhang amount, we shouldn't cap the scroll position
to be inside of the valid maximum/minimum scroll offsets because that will cause the page to jump back, which
can look really bad if layout happens in response to the page being scrolled.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars):

12:58 Changeset [110736] by ojan@chromium.org

Add Lion failures in order to green the lion bot.

  • platform/chromium/test_expectations.txt:
12:53 Changeset [110735] by tommyw@google.com

MediaStream API (JSEP): Introducing IceCandidate
https://bugs.webkit.org/show_bug.cgi?id=80699

Reviewed by Adam Barth.

Patch #2 in a series of patches to change the PeerConnection from ROAP to JSEP,
see bug 80589 for more information.
Adding the JS object IceCandidate and its WebCore/platform sibling IceCandidateDescriptor.
This object will be created both from JS and the embedder.

Not possible to test until the entire JSEP feature is commited.

  • GNUmakefile.list.am:
  • Modules/mediastream/IceCandidate.cpp: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.cpp.

(WebCore):
(WebCore::IceCandidate::create):
(WebCore::IceCandidate::IceCandidate):
(WebCore::IceCandidate::~IceCandidate):
(WebCore::IceCandidate::label):
(WebCore::IceCandidate::candidateLine):
(WebCore::IceCandidate::toSdp):
(WebCore::IceCandidate::descriptor):

  • Modules/mediastream/IceCandidate.h: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.cpp.

(WebCore):
(IceCandidate):

  • Modules/mediastream/IceCandidate.idl: Added.
  • WebCore.gypi:
  • platform/mediastream/IceCandidateDescriptor.cpp: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.cpp.

(WebCore):
(WebCore::IceCandidateDescriptor::create):
(WebCore::IceCandidateDescriptor::IceCandidateDescriptor):
(WebCore::IceCandidateDescriptor::~IceCandidateDescriptor):
(WebCore::IceCandidateDescriptor::toSdp):

  • platform/mediastream/IceCandidateDescriptor.h: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.cpp.

(WebCore):
(IceCandidateDescriptor):
(WebCore::IceCandidateDescriptor::label):
(WebCore::IceCandidateDescriptor::candidateLine):

  • platform/mediastream/MediaStreamCenter.cpp:

(WebCore::MediaStreamCenter::constructSdp):
(WebCore):

  • platform/mediastream/MediaStreamCenter.h:

(WebCore):
(MediaStreamCenter):

12:52 Changeset [110734] by tsepez@chromium.org

Merge 108881 - XSS Auditor targeting legitimate frames as false positives.
https://bugs.webkit.org/show_bug.cgi?id=79397

Reviewed by Adam Barth.

TBR=tsepez@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9701035

12:51 Changeset [110733] by dpranke@chromium.org

Fix regression/crash introduced in r110724 - bad type passed from skipped_tests() by default.

Unreviewed, build fix.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.skipped_tests):

12:50 Changeset [110732] by simon.fraser@apple.com

background-visibility:hidden should create a RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=81134

Source/WebCore:

Reviewed by Dean Jackson.

Background-visibility:hidden has to create RenderLayers, because it's implemented
via compositing and/or paint short-circuiting in RenderLayer code.

Test: transforms/3d/general/background-visibility-layers.html

  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::requiresLayer):

  • rendering/RenderObject.h:

(WebCore::RenderObject::hasHiddenBackface):

  • rendering/RenderTableRow.h:

LayoutTests:

Reviewed by Dean Jackson.

Test for background-visibility: hidden making a RenderLayer.

  • transforms/3d/general/background-visibility-layers-actual.png: Added.
  • transforms/3d/general/background-visibility-layers-actual.txt: Added.
  • transforms/3d/general/background-visibility-layers.html: Added.
12:48 Changeset [110731] by commit-queue@webkit.org

[CSSRegions][CSSOM] Implement regionLayoutEvent
https://bugs.webkit.org/show_bug.cgi?id=78882

Patch by Raul Hudea <rhudea@adobe.com> on 2012-03-14
Reviewed by David Hyatt.

Source/WebCore:

Adding the regionLayoutEvent that is dispatch for all regions after each flow-thread layout.

Tests: fast/regions/region-event-add-to-flow.html

fast/regions/region-event-remove-from-dom.html
fast/regions/region-event-remove-from-flow.html
fast/regions/region-event.html

  • dom/Document.cpp:

(WebCore::Document::addListenerTypeIfNeeded): Added check for regionLayoutUpdate listeners

  • dom/Document.h:
  • dom/EventNames.h:

(WebCore):

  • dom/Node.cpp:

(WebCore::Node::dispatchRegionLayoutUpdateEvent):
(WebCore):

  • dom/Node.h:

(Node):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::layout): Start the event dispatch timer but only if there are regionLayoutUpdate listeners and there is at least one region that had its layout updated.
(WebCore::RenderFlowThread::computeOverflowStateForRegions): Mark regions that might had a layout update
(WebCore::RenderFlowThread::regionLayoutUpdateEventTimerFired):
(WebCore):

  • rendering/RenderFlowThread.h:
  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::RenderRegion):

  • rendering/RenderRegion.h:

(WebCore::RenderRegion::setDispatchRegionLayoutUpdateEvent):
(WebCore::RenderRegion::shouldDispatchRegionLayoutUpdateEvent):
(RenderRegion):

LayoutTests:

  • fast/regions/region-event-add-to-flow-expected.txt: Added.
  • fast/regions/region-event-add-to-flow.html: Added.
  • fast/regions/region-event-expected.txt: Added.
  • fast/regions/region-event-remove-from-dom-expected.txt: Added.
  • fast/regions/region-event-remove-from-dom.html: Added.
  • fast/regions/region-event-remove-from-flow-expected.txt: Added.
  • fast/regions/region-event-remove-from-flow.html: Added.
  • fast/regions/region-event.html: Added.
12:45 Changeset [110730] by pierre.rossi@gmail.com

[Qt] Add support for vertical sliders in mobile theme
https://bugs.webkit.org/show_bug.cgi?id=80179

This makes sliders using the "slider-vertical" appearance more sensible.

Reviewed by Simon Hausmann.

No new tests, since the mobile theme still isn't used in layout tests.

  • platform/qt/RenderThemeQtMobile.cpp:

(WebCore):
(WebCore::StylePainterMobile::drawProgress):
(WebCore::RenderThemeQtMobile::paintSliderTrack):

  • platform/qt/RenderThemeQtMobile.h:

(StylePainterMobile):

12:30 Changeset [110729] by ojan@chromium.org

Rebaseline chromium-lion tests that have "MISSING" results.

12:26 Changeset [110728] by andersca@apple.com

Fix UI process crash when a plug-in process crashes with a modal dialog showing
https://bugs.webkit.org/show_bug.cgi?id=81139
<rdar://problem/9641197>

Reviewed by Dan Bernstein.

When a plug-in process crashes, its corresponding PluginProcessProxy object is deleted immediately,
which is bad if we're currently running a nested run loop.

Fix this by making PluginProcessProxy ref-counted and protecting it before the call to -[NSApp runModalForWindow:].

  • UIProcess/Plugins/PluginProcessManager.cpp:

(WebKit::PluginProcessManager::pluginProcessWithPath):
(WebKit::PluginProcessManager::getOrCreatePluginProcess):

  • UIProcess/Plugins/PluginProcessManager.h:

(PluginProcessManager):

  • UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::create):
(WebKit::PluginProcessProxy::pluginProcessCrashedOrFailedToLaunch):

  • UIProcess/Plugins/PluginProcessProxy.h:

(PluginProcessProxy):

  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::PluginProcessProxy::setModalWindowIsShowing):
(WebKit::PluginProcessProxy::beginModal):

12:24 Changeset [110727] by jer.noble@apple.com

WebProcess spins beneath [QTMovie movieFileTypes:]
https://bugs.webkit.org/show_bug.cgi?id=81133

Reviewed by Eric Carlson.

No new tests; speculative fix for top WebProcess spin.

When checking to see if a given mime type is supported by QuickTime,
immediately exclude all types that do not begin with 'audio/' or 'video/'.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::supportsType):

12:12 Changeset [110726] by leviw@chromium.org

We cannot size blocks from the line tree using sub-pixel precision since we don't paint blocks using sub-pixels. We must always grow to contain the lines.

12:10 Changeset [110725] by abarth@webkit.org

Update SVG baseline after work on <use> element. These results all
seem to be minor differences or progressions.

  • platform/chromium-linux/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png:
  • platform/chromium-mac-leopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png:
  • platform/chromium-mac-leopard/svg/batik/filters/filterRegions-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png:
  • platform/chromium-win-xp/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt:
  • platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-win/svg/batik/filters/filterRegions-expected.txt:
  • platform/chromium-win/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png:
  • platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
11:55 Changeset [110724] by dpranke@chromium.org

Please add a way to manually skip some tests in NRWT
https://bugs.webkit.org/show_bug.cgi?id=81019

Reviewed by Ojan Vafai.

This patch implements the -i / --ignore-tests flag from ORWT
and refactors the test_expectations.py code slightly to handle
it.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.parse_expectations):

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations.init):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(test_add_skipped_tests):
(test_add_skipped_tests_duplicate):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_ignore_tests):
(MainTest.test_ignore_tests.assert_ignored):

11:54 Changeset [110723] by lforschler@apple.com

Versioning.

11:53 Changeset [110722] by dpranke@chromium.org

nrwt: run with no args on lion, is putting baselines in platform/mac-lion, not platform/mac
https://bugs.webkit.org/show_bug.cgi?id=81028

Reviewed by Ojan Vafai.

The mac port had incorrect lookups for 'mac-lion' and
'mac-future' in some places. This patch fixes that and adds a
bunch of tests.

  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.baseline_path):

  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:

(MacTest.assert_skipped_file_search_paths):
(MacTest.test_skipped_file_search_paths):
(_assert_search_path):
(test_baseline_search_path):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._skipped_file_search_paths):

11:46 WebKit Team edited by jberlin@webkit.org
Moving myself to the reviewers section (diff)
11:45 Changeset [110721] by lforschler@apple.com

New branch.

11:37 Changeset [110720] by jberlin@webkit.org

WK2: Spelling tests that rely on getting the marked range or the marked count synchronously fail
https://bugs.webkit.org/show_bug.cgi?id=81138

Add some expected failing results for such tests to get the bots green.

  • platform/mac-wk2/editing/spelling/markers-expected.txt: Added.
  • platform/mac-wk2/editing/spelling/spelling-insert-html-expected.txt: Added.
  • platform/mac-wk2/editing/spelling/spelling-unified-emulation-expected.txt: Added.
11:33 Changeset [110719] by enne@google.com

[Chromium] Unreviewed, remove expectations for non-crashing tests
https://bugs.webkit.org/show_bug.cgi?id=78038

  • platform/chromium/test_expectations.txt:
11:29 Changeset [110718] by commit-queue@webkit.org

Make RenderIFrame::flattenFrame() return earlier, when frame flattening is disabled.
https://bugs.webkit.org/show_bug.cgi?id=80301

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-03-14
Reviewed by Antti Koivisto.

Reorganize RenderIFrame flattenFrame() code, so that it returns
earlier for the normal use case, when frame flattening is disabled.
It also removes leftover null check.

No new tests, since there's no new functionality.

  • rendering/RenderIFrame.cpp:

(WebCore::RenderIFrame::flattenFrame):

11:16 Changeset [110717] by eae@chromium.org

Pixel snapping fixes for RenderInline and RenderBoxModelObject on branch.

11:12 Changeset [110716] by jamesr@google.com

[chromium] Provide explicit polling API to check if the platform is capable of accelerated 2d canvas
https://bugs.webkit.org/show_bug.cgi?id=80667

Reviewed by Darin Fisher.

Source/WebCore:

Query the platform to see if we can instantiate a context suitable for accelerating 2d canvas. If we can't, for
instance if we're on a system that can't preserve a context when the screensaver comes up, then immediately fall
back to software.

Covered by canvas layout tests in the virtual-gpu mode.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::shouldAccelerate):

  • platform/chromium/PlatformSupport.h:

Source/WebKit/chromium:

  • public/platform/WebKitPlatformSupport.h:

(WebKit::WebKitPlatformSupport::canAccelerate2dCanvas):
(WebKitPlatformSupport):

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::canAccelerate2dCanvas):
(WebCore):

11:03 Changeset [110715] by jberlin@webkit.org

Support drag in mouse events for WebKit2 EventSender
https://bugs.webkit.org/show_bug.cgi?id=68552
https://bugs.webkit.org/show_bug.cgi?id=69946

Add some tests that use eventSender.dragMode to the WK2 Skipped list.

  • platform/wk2/Skipped:
10:56 Changeset [110714] by carlosgc@webkit.org

[GTK] Handle printing errors in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=77197

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

  • platform/gtk/ErrorsGtk.cpp:

(WebCore::printError): Create a generic print error.
(WebCore::printerNotFoundError): Create a print error to notify
that the selected printer could not be found.
(WebCore::invalidPageRangeToPrint): Create a print error when the
selected page range is invalid and there are no pages to print.

  • platform/gtk/ErrorsGtk.h:

(WebCore): Add print error doamin.

Source/WebKit2:

  • UIProcess/API/gtk/WebKitError.cpp:

(webkit_print_error_quark): Add new error domain for print
errors.

  • UIProcess/API/gtk/WebKitError.h: Ad print errors.
  • UIProcess/API/gtk/WebKitPrintOperation.cpp:

(webkit_print_operation_class_init): Add
WebKitPrintOperation::failed signal.
(drawPagesForPrintingCompleted): Emit WebKitPrintOperation::failed
when the print operation failed with the given error.
(webkitPrintOperationPrintPagesForFrame): Use
PrintFinishedCallback instead of a VoidCallback.

  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
  • UIProcess/API/gtk/tests/TestPrinting.cpp:

(testPrintOperationPrint):
(testPrintOperationErrors): Test different print errors are
correctly reported.
(beforeAll):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close): Invalidate print finished callbacks
map.
(WebKit::WebPageProxy::printFinishedCallback): Callback called
when the print operation has finished in the web process.
(WebKit::WebPageProxy::processDidCrash): Invalidate print finished
callbacks map.
(WebKit::WebPageProxy::drawPagesForPrinting): Use a
PrintFinishedCallback instead of a VoidCallback.

  • UIProcess/WebPageProxy.h:

(WebKit): Delcare PrintFinishedCallback as a generic callback.
(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in: Use PrintFinishedCallback

instead of VoidCallback as callback argument of
DrawPagesForPrinting message.

  • WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:

(WebKit::PrintPagesData::PrintPagesData): Mark the data as invalid
when there are no pages to print.
(PrintPagesData): Add isValid parameter to mark the data struct as
invalid.
(WebKit::WebPrintOperationGtk::printPagesIdleDone): Call
printPagesDone() instead of printDone().
(WebKit::WebPrintOperationGtk::printPagesDone): Renamed.
(WebKit::WebPrintOperationGtk::printDone): Notify the UI process
that the print operation has finsihed.
(WebKit::WebPrintOperationGtk::print): Finish the print if the
PrintPagesData struct is not valid.

  • WebProcess/WebPage/gtk/WebPrintOperationGtk.h:
10:32 Changeset [110713] by commit-queue@webkit.org

[EFL] Enable HTML5 Summary and Details elements
https://bugs.webkit.org/show_bug.cgi?id=81027

Enabling Summary and Details elements by default and removing related
tests from skip list since they should pass now.

.:

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-03-14
Reviewed by Antonio Gomes.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmakeconfig.h.cmake:

LayoutTests:

Tests expectations from Ubuntu 11.10 using EFL from SVN. Hopefully the
same as the build bot.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-03-14
Reviewed by Antonio Gomes.

  • platform/efl/Skipped:
  • platform/efl/fast/html/details-add-child-1-expected.txt: Added.
  • platform/efl/fast/html/details-add-child-2-expected.txt: Added.
  • platform/efl/fast/html/details-add-details-child-1-expected.txt: Added.
  • platform/efl/fast/html/details-add-details-child-2-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-1-and-click-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-1-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-10-and-click-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-10-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-2-and-click-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-2-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-3-and-click-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-3-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-4-and-click-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-4-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-5-and-click-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-5-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-6-and-click-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-6-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-7-and-click-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-7-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-8-and-click-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-8-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-9-and-click-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-9-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-child-1-expected.txt: Added.
  • platform/efl/fast/html/details-add-summary-child-2-expected.txt: Added.
  • platform/efl/fast/html/details-nested-1-expected.txt: Added.
  • platform/efl/fast/html/details-nested-2-expected.txt: Added.
  • platform/efl/fast/html/details-no-summary1-expected.txt: Added.
  • platform/efl/fast/html/details-no-summary2-expected.txt: Added.
  • platform/efl/fast/html/details-no-summary3-expected.txt: Added.
  • platform/efl/fast/html/details-no-summary4-expected.txt: Added.
  • platform/efl/fast/html/details-open-javascript-expected.txt: Added.
  • platform/efl/fast/html/details-open1-expected.txt: Added.
  • platform/efl/fast/html/details-open2-expected.txt: Added.
  • platform/efl/fast/html/details-open3-expected.txt: Added.
  • platform/efl/fast/html/details-open4-expected.txt: Added.
  • platform/efl/fast/html/details-open5-expected.txt: Added.
  • platform/efl/fast/html/details-open6-expected.txt: Added.
  • platform/efl/fast/html/details-position-expected.txt: Added.
  • platform/efl/fast/html/details-remove-child-1-expected.txt: Added.
  • platform/efl/fast/html/details-remove-child-2-expected.txt: Added.
  • platform/efl/fast/html/details-remove-summary-1-and-click-expected.txt: Added.
  • platform/efl/fast/html/details-remove-summary-1-expected.txt: Added.
  • platform/efl/fast/html/details-remove-summary-2-and-click-expected.txt: Added.
  • platform/efl/fast/html/details-remove-summary-2-expected.txt: Added.
  • platform/efl/fast/html/details-remove-summary-3-and-click-expected.txt: Added.
  • platform/efl/fast/html/details-remove-summary-3-expected.txt: Added.
  • platform/efl/fast/html/details-remove-summary-4-and-click-expected.txt: Added.
  • platform/efl/fast/html/details-remove-summary-4-expected.txt: Added.
  • platform/efl/fast/html/details-remove-summary-5-and-click-expected.txt: Added.
  • platform/efl/fast/html/details-remove-summary-5-expected.txt: Added.
  • platform/efl/fast/html/details-remove-summary-6-and-click-expected.txt: Added.
  • platform/efl/fast/html/details-remove-summary-6-expected.txt: Added.
  • platform/efl/fast/html/details-remove-summary-child-1-expected.txt: Added.
  • platform/efl/fast/html/details-remove-summary-child-2-expected.txt: Added.
  • platform/efl/fast/html/details-replace-summary-child-expected.txt: Added.
  • platform/efl/fast/html/details-replace-text-expected.txt: Added.
  • platform/efl/fast/html/details-writing-mode-expected.txt: Added.
10:05 Changeset [110712] by commit-queue@webkit.org

[BlackBerry] Syncing up left over bits in Api from our local branch to upstream
https://bugs.webkit.org/show_bug.cgi?id=81105

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-03-14
Reviewed by Rob Buis.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::renderContents):
(BlackBerry::WebKit::BackingStorePrivate::isActive):
(BlackBerry::WebKit::BackingStore::createBackingStoreMemory):
(WebKit):
(BlackBerry::WebKit::BackingStore::releaseBackingStoreMemory):

  • Api/BackingStore.h:
  • Api/WebPage.cpp:

(BlackBerry::WebKit::toWebCoreMouseEventType):
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::activeNodeContext):
(BlackBerry::WebKit::WebPage::activeNodeContext):
(BlackBerry::WebKit::WebPagePrivate::updateCursor):
(BlackBerry::WebKit::WebPagePrivate::contextNode):
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):

  • Api/WebPage.h:
  • Api/WebPage_p.h:

(WebPagePrivate):

09:59 Changeset [110711] by zimmermann@webkit.org

Make SVGUseElement respect & support externalResourcesRequired
https://bugs.webkit.org/show_bug.cgi?id=81109

Reviewed by Rob Buis.

Source/WebCore:

Generalize the existing externalResourcesRequired support from SVGScriptElement
into SVGExternalResourcesRequired, so it can be shared with SVGUseElement, which
was lacking proper externalResourcesRequired support.

<use xlink:href="external.svg" onload="alert('hi')" externalResourcesRequired="true"/>
The onload handler now fires _after_ the external resources loaded, making it possible
to write reliable tests that switch from internal to external resources or the other
way around. Converted the new tests in svg/dynamic-updates/SVGUseElement* to listen
to SVGLoad events, to make them reliable.

We may be able to generalize this to cover SVGImageElement as well (the only other class which
is currently supporting externalResourcesRequired - but that's more involved, so I left it TODO).

Covered by existing tests and the changes to the new SVGUseElement tests.

  • svg/SVGElement.h:

(SVGElement): Make haveLoadedRequiredResources() public so SVGExternalResourcesRequired can call it.

  • svg/SVGExternalResourcesRequired.cpp: Refactored code from SVGScriptElement, 1:1 copies w/o changes.

(WebCore::SVGExternalResourcesRequired::handleAttributeChange):
(WebCore::SVGExternalResourcesRequired::dispatchLoadEvent):
(WebCore::SVGExternalResourcesRequired::insertedIntoDocument):
(WebCore::SVGExternalResourcesRequired::finishParsingChildren):
(WebCore::SVGExternalResourcesRequired::haveLoadedRequiredResources):

  • svg/SVGExternalResourcesRequired.h: Add new virtual functions, that must be available in classes that inherit from SVGExternalResourcesRequired.

(WebCore::SVGExternalResourcesRequired::setHaveFiredLoadEvent):
(WebCore::SVGExternalResourcesRequired::isParserInserted):
(WebCore::SVGExternalResourcesRequired::haveFiredLoadEvent):

  • svg/SVGScriptElement.cpp: Refactored externalResourcesRequired handling into SVGExternalResourcesRequired.

(WebCore::SVGScriptElement::svgAttributeChanged):
(WebCore::SVGScriptElement::insertedIntoDocument):
(WebCore::SVGScriptElement::finishParsingChildren):

  • svg/SVGScriptElement.h: Ditto.

(WebCore::SVGScriptElement::haveLoadedRequiredResources):
(WebCore::SVGScriptElement::dispatchLoadEvent):
(WebCore::SVGScriptElement::setHaveFiredLoadEvent):
(WebCore::SVGScriptElement::isParserInserted):
(WebCore::SVGScriptElement::haveFiredLoadEvent):

  • svg/SVGTests.cpp: Fix obvious typo, that leads to an assertion. Always return true if we know the attributeName.

(WebCore::SVGTests::handleAttributeChange):

  • svg/SVGTests.h:
  • svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::insertedIntoDocument): Remove ambigous call warning.

  • svg/SVGUseElement.cpp: Support externalResourcesRequired="true/false" + dynamic changes of it. Covered by existing tests.

(WebCore::SVGUseElement::SVGUseElement):
(WebCore::SVGUseElement::create):
(WebCore::SVGUseElement::insertedIntoDocument):
(WebCore::SVGUseElement::svgAttributeChanged):
(WebCore::SVGUseElement::notifyFinished):
(WebCore::SVGUseElement::finishParsingChildren):
(WebCore):

  • svg/SVGUseElement.h: Ditto.

(WebCore::SVGUseElement::haveLoadedRequiredResources):
(WebCore::SVGUseElement::setHaveFiredLoadEvent):
(WebCore::SVGUseElement::isParserInserted):
(WebCore::SVGUseElement::haveFiredLoadEvent):

  • svg/svgtags.in: Pass "bool wasInsertedByParser" to SVGUseElement constructor.

LayoutTests:

Fix flakiness of new external <use> tests introduced in r110676.

  • platform/mac/svg/batik/masking/maskRegions-expected.png:
  • platform/mac/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png:
  • svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.txt:
  • svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.txt:
  • svg/dynamic-updates/script-tests/SVGUseElement-dom-href1-attr.js:

(repaintTest):

  • svg/dynamic-updates/script-tests/SVGUseElement-dom-href2-attr.js:

(repaintTest):
(externalLoadDone):

  • svg/dynamic-updates/script-tests/SVGUseElement-svgdom-href1-prop.js:

(repaintTest):

  • svg/dynamic-updates/script-tests/SVGUseElement-svgdom-href2-prop.js:

(repaintTest):
(externalLoadDone):

09:32 Changeset [110710] by jberlin@webkit.org

Mac WK2: editing/pasteboard/dataTransfer-setData-getData.html fails
https://bugs.webkit.org/show_bug.cgi?id=81125

Add expected failing results for Mac WK2 to get the bots green.

  • platform/mac-wk2/editing/pasteboard/dataTransfer-setData-getData-expected.txt: Added.
09:23 Changeset [110709] by commit-queue@webkit.org

[BlackBerry] Implement REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR using AnimationFrameRateController
https://bugs.webkit.org/show_bug.cgi?id=81000

Source/JavaScriptCore:

Enable WTF_USE_REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR for BlackBerry.

Patch by Andrew Lo <anlo@rim.com> on 2012-03-14
Reviewed by Antonio Gomes.

  • wtf/Platform.h:

Source/WebCore:

Add BlackBerry port for DisplayRefreshMonitor using AnimationFrameRateController.
Moved refreshDisplayOnMainThread to platform independant part of header.

Patch by Andrew Lo <anlo@rim.com> on 2012-03-14
Reviewed by Antonio Gomes.

requestAnimationFrame already covered by tests in LayoutTests/fast/animation.

  • PlatformBlackBerry.cmake:
  • platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor):

  • platform/graphics/DisplayRefreshMonitor.h:

(WebCore):
(DisplayAnimationClient):
(WebCore::DisplayAnimationClient::~DisplayAnimationClient):
(DisplayRefreshMonitor):

  • platform/graphics/blackberry/DisplayRefreshMonitorBlackBerry.cpp: Added.

(WebCore):
(WebCore::DisplayAnimationClient::DisplayAnimationClient):
(WebCore::DisplayAnimationClient::animationFrameChanged):
(WebCore::DisplayRefreshMonitor::~DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::startAnimationClient):
(WebCore::DisplayRefreshMonitor::stopAnimationClient):
(WebCore::DisplayRefreshMonitor::requestRefreshCallback):
(WebCore::DisplayRefreshMonitor::displayLinkFired):

Source/WebKit/blackberry:

Set the platform display ID, needed for DisplayRefreshMonitor.

Patch by Andrew Lo <anlo@rim.com> on 2012-03-14
Reviewed by Antonio Gomes.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

09:21 Changeset [110708] by jer.noble@apple.com

Lion Intel Debug WebKit2 Tests crashing under [WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]
https://bugs.webkit.org/show_bug.cgi?id=81056

Reviewed by Jessie Berlin.

Source/WebKit2:

Give the InjectedBundlePageFullScreenClient a first crack at beganEnterFullScreen and beganExitFullScreen:

  • WebProcess/FullScreen/WebFullScreenManager.cpp:

(WebKit::WebFullScreenManager::willEnterFullScreen):
(WebKit::WebFullScreenManager::willExitFullScreen):

And call the client function if it exists; otherwise, continue to message the page:

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp:

(WebKit::InjectedBundlePageFullScreenClient::beganEnterFullScreen):
(WebKit::InjectedBundlePageFullScreenClient::beganExitFullScreen):

  • WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.h:

Add a custom APIClientTraits for InjectedBundlePageFullScreenClient to handle the API number change.

  • Shared/APIClientTraits.cpp:
  • Shared/APIClientTraits.h:

Tools:

Intercept beganEnterFullScreen and beganExitFullScreen and turn them into no-ops (plus logging).

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::beganEnterFullScreen):
(WTR::InjectedBundlePage::beganExitFullScreen):

09:20 Changeset [110707] by yurys@chromium.org

Web Inspector: use class name indexes instead of class names when evaluating aggregates
https://bugs.webkit.org/show_bug.cgi?id=81100

Class name and type name indexes are now used when calculating class aggregates
in heap snapshots instead of string lookup followed by a string comparison.

Class names like "Window / www.webkit.org" are now left as is in the UI (it used
to be trimed to just "Window").

Reviewed by Pavel Feldman.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.get classNameIndex):
(WebInspector.HeapSnapshotNode.prototype.hasType):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype._buildAggregates):

09:04 Changeset [110706] by caseq@chromium.org

Web Inspector: add didCancelFrame timeline event
https://bugs.webkit.org/show_bug.cgi?id=80994

Reviewed by Pavel Feldman.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

  • add an ability to cancel certain timeline events, unless they've been followed by other events.
  • implement didCancelFrame() event, fired when a platform decides not to render frame after didBeginFrame() was called.

Test: inspector/timeline/timeline-frames.html

  • WebCore.exp.in:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didCancelFrameImpl):
(WebCore):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCancelFrame):
(WebCore):

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didBeginFrame):
(WebCore):
(WebCore::InspectorTimelineAgent::didCancelFrame):
(WebCore::InspectorTimelineAgent::appendRecord):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):
(WebCore::InspectorTimelineAgent::pushCancelableRecord):
(WebCore::InspectorTimelineAgent::commitCancelableRecords):
(WebCore::InspectorTimelineAgent::cancelRecord):

  • inspector/InspectorTimelineAgent.h:

(InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry):
(TimelineRecordEntry):

  • testing/Internals.cpp:

(WebCore::Internals::emitInspectorDidBeginFrame):
(WebCore):
(WebCore::Internals::emitInspectorDidCancelFrame):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit/chromium:

  • add intrumentCanceFrame(), called when renderer decides not to

render frame after instrumentBeginFrame() was called.

  • public/WebWidget.h:

(WebWidget):
(WebKit::WebWidget::instrumentCancelFrame):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::instrumentCancelFrame):
(WebKit):

  • src/WebViewImpl.h:

(WebViewImpl):

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

  • added test for didBeginFrame()/didCancelFrame()
  • inspector/timeline/timeline-frames-expected.txt: Added.
  • inspector/timeline/timeline-frames.html: Added.
08:42 Changeset [110705] by ahf@0x90.dk

The width and height of the scroll indicators in the MiniBrowser does not consider the offset margins. https://bugs.webkit.org/show_bug.cgi?id=81112

Reviewed by Kenneth Rohde Christiansen.

This patch fixes the issue by withdrawing two times the anchor
margins.

  • MiniBrowser/qt/qml/ScrollIndicator.qml:
08:37 Changeset [110704] by commit-queue@webkit.org

Region can acquire an empty span by subtracting an empty Region
https://bugs.webkit.org/show_bug.cgi?id=81074

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-14
Reviewed by Anders Carlsson.

Source/WebCore:

Subtracting an empty Region B from a Region A can cause A to end
up with an empty span. This violates the rule that two Regions
that cover the exact same area should have equal spans and segments.

Unit test: RegionTest.emptySpan

  • platform/graphics/Region.cpp:

(WebCore::Region::subtract):

Source/WebKit/chromium:

  • tests/RegionTest.cpp:

(WebCore::TEST):
(WebCore):

08:31 Changeset [110703] by hausmann@webkit.org

[Textmap] Disable driver based BGRA swizzling for OpenGL/ES

Reviewed by Noam Rosenthal.

The current way of detecting swizzling support (check for GL_EXT_texture_format_BGRA8888)
is unfortunately not reliable. We need a better way of detection that (filed bug 81103).
In the meantime this patch reverts back to doing the swizzling in the texture mapper to
get pixels back onto the screen.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::driverSupportsBGRASwizzling):
(WebCore::BitmapTextureGL::updateContents):

08:28 Changeset [110702] by vestbo@webkit.org

[Qt] Deal with multiple paths in QMAKE_EXTRA_MODULE_FORWARDS

Reviewed by Simon Hausmann.

08:24 Changeset [110701] by leo.yang@torchmobile.com.cn

[BlackBerry] Upstream the BlackBerry change to platform/Cursor.h
https://bugs.webkit.org/show_bug.cgi?id=81086

Reviewed by Rob Buis.

Source/WebCore:

  • platform/Cursor.h:

(WebCore):
(WebCore::Cursor::Cursor):
Add the BlackBerry specific PlatformCursor.

  • platform/blackberry/PageClientBlackBerry.h:

There was an alias named PlatformCursorHandle for PlatformCursor
in the internal version of Cursor.h. But it's not necessary so it's
not included in the upstreaming version of Cursor.h. As a result,
use PlatformCursor directly in this file.
(PageClientBlackBerry):

Source/WebKit/blackberry:

There was an alias named PlatformCursorHandle for PlatformCursor
in the internal version of Cursor.h. But it's not necessary so it's
not included in the upstreaming version of Cursor.h. As a result,
use PlatformCursor directly.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setCursor):

  • Api/WebPage_p.h:

(WebPagePrivate):

08:15 Changeset [110700] by commit-queue@webkit.org

[EFL] Implement LayoutTestController::clearBackForwardList
https://bugs.webkit.org/show_bug.cgi?id=80142

Tools:

Adding missing implementation clearBackForwardList to EFL's
LayoutTestController. This implementation allows us to unskip
tests connected with history.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-14
Reviewed by Antonio Gomes.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::clearBackForwardList): Implemented.

LayoutTests:

Unskip tests connected with clearBackForwardList.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-14
Reviewed by Antonio Gomes.

  • platform/efl/Skipped:
08:02 Changeset [110699] by abecsi@webkit.org

[Qt] RunLoopQt is missing reentrancy guards
https://bugs.webkit.org/show_bug.cgi?id=80982

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-03-14
Reviewed by Tor Arne Vestbø.

Avoid recursive calls to RunLoop::performWork() with a simple
counting mechanism, to avoid out-of-order message dispatching.

  • platform/qt/RunLoopQt.cpp:

(WebCore::RunLoop::TimerObject::TimerObject):
(WebCore::RunLoop::TimerObject::performWork):
(RunLoop::TimerObject):

07:41 Changeset [110698] by loislo@chromium.org

Source/WebCore: Web Inspector: small improvement for HeapSnapshot performance ~12%.
https://bugs.webkit.org/show_bug.cgi?id=81033

Reviewed by Yury Semikhatsky.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype.get nodeCount):
(WebInspector.HeapSnapshot.prototype.get maxNodeId):
(WebInspector.HeapSnapshot.prototype._buildReverseIndex):
(WebInspector.HeapSnapshot.prototype.get nodeIndexes):
(WebInspector.HeapSnapshot.prototype._buildNodeIndex):

Source/WebKit/chromium: Unreviewed, mark verifyCullChildLinesUpTopLeft() as failed.

Patch by Hajime Morrita <morrita@chromium.org> on 2012-03-13

  • tests/CCQuadCullerTest.cpp:

(WebCore):
(WebCore::TEST):

LayoutTests: Return null when shouldAllowAccessToNode() fails
https://bugs.webkit.org/show_bug.cgi?id=80205

Patch by Kentaro Hara <haraken@chromium.org> on 2012-03-14
Reviewed by Adam Barth.

shouldAllowAccessToNode() is used for window.frameElement, HTMLFrameElement.contentDocument,
and getSVGDocument(). The spec of window.frameElement and HTMLFrameElement.contentDocument
requires that they should return null when the security check fails.
Thus this patch changes the return value from undefined to null.

http://www.whatwg.org/specs/web-apps/current-work/multipage/browsers.html#navigating-nested-browsing-contexts-in-the-dom
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#dom-iframe-contentdocument

  • http/tests/security/cross-frame-access-frameelement-expected.txt:
  • http/tests/security/local-iFrame-from-remote.html:
  • platform/chromium/http/tests/security/cross-frame-access-put-expected.txt:
  • platform/gtk/http/tests/security/cross-frame-access-put-expected.txt:
06:23 Changeset [110697] by commit-queue@webkit.org

Build error: DNSSoup.cpp:30: fatal error: CString.h: No such file or
directory
https://bugs.webkit.org/show_bug.cgi?id=81093

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-14
Reviewed by Philippe Normand.

Fix build error introduced by r110669.

  • platform/network/soup/DNSSoup.cpp:
06:01 Changeset [110696] by morrita@google.com

Unreviewed rebaseline update for <use> related SVG files.

  • platform/chromium-linux/svg/batik/filters/feTile-expected.txt: Removed.
  • platform/chromium-linux/svg/batik/masking/maskRegions-expected.png:
  • platform/chromium-linux/svg/batik/paints/gradientLimit-expected.txt: Removed.
  • platform/chromium-linux/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
  • platform/chromium-linux/svg/batik/paints/patternRegionA-expected.txt: Removed.
  • platform/chromium-linux/svg/batik/paints/patternRegions-expected.png:
  • platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.txt: Removed.
  • platform/chromium-linux/svg/batik/text/longTextOnPath-expected.txt: Removed.
  • platform/chromium-linux/svg/batik/text/smallFonts-expected.png:
  • platform/chromium-linux/svg/batik/text/textAnchor-expected.txt: Removed.
  • platform/chromium-linux/svg/batik/text/textDecoration-expected.png:
  • platform/chromium-linux/svg/batik/text/textEffect-expected.txt: Removed.
  • platform/chromium-linux/svg/batik/text/textEffect2-expected.png:
  • platform/chromium-linux/svg/batik/text/textEffect3-expected.txt: Removed.
  • platform/chromium-linux/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-linux/svg/batik/text/textLayout-expected.txt: Removed.
  • platform/chromium-linux/svg/batik/text/textLayout2-expected.png:
  • platform/chromium-linux/svg/batik/text/textLength-expected.txt: Removed.
  • platform/chromium-linux/svg/batik/text/textOnPath-expected.png:
  • platform/chromium-linux/svg/batik/text/textOnPathSpaces-expected.txt: Removed.
  • platform/chromium-linux/svg/batik/text/textPosition-expected.png:
  • platform/chromium-linux/svg/batik/text/textPosition-expected.txt:
  • platform/chromium-linux/svg/batik/text/textProperties-expected.png:
  • platform/chromium-linux/svg/batik/text/textProperties2-expected.txt: Removed.
  • platform/chromium-linux/svg/batik/text/textStyles-expected.png:
  • platform/chromium-linux/svg/batik/text/verticalText-expected.txt: Removed.
  • platform/chromium-linux/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png: Added.
  • platform/chromium-mac-leopard/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
  • platform/chromium-mac-leopard/svg/batik/paints/patternRegions-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/smallFonts-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/textDecoration-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/textEffect2-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/textLayout2-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/textOnPath-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/textProperties-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/textStyles-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/batik/masking/maskRegions-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/paints/patternPreserveAspectRatioA-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/batik/paints/patternRegions-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/smallFonts-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textDecoration-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textEffect2-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textLayout2-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textOnPath-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textPosition-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textProperties-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textProperties-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/batik/text/textStyles-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textStyles-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
  • platform/chromium-win-xp/svg/batik/text/verticalText-expected.png:
  • platform/chromium-win-xp/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added.
  • platform/chromium-win-xp/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Added.
  • platform/chromium-win/svg/batik/filters/feTile-expected.png:
  • platform/chromium-win/svg/batik/filters/feTile-expected.txt:
  • platform/chromium-win/svg/batik/masking/maskRegions-expected.png:
  • platform/chromium-win/svg/batik/masking/maskRegions-expected.txt:
  • platform/chromium-win/svg/batik/paints/gradientLimit-expected.png:
  • platform/chromium-win/svg/batik/paints/gradientLimit-expected.txt:
  • platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
  • platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
  • platform/chromium-win/svg/batik/paints/patternRegionA-expected.png:
  • platform/chromium-win/svg/batik/paints/patternRegionA-expected.txt:
  • platform/chromium-win/svg/batik/paints/patternRegions-expected.png:
  • platform/chromium-win/svg/batik/paints/patternRegions-expected.txt:
  • platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
  • platform/chromium-win/svg/batik/text/longTextOnPath-expected.png:
  • platform/chromium-win/svg/batik/text/longTextOnPath-expected.txt:
  • platform/chromium-win/svg/batik/text/smallFonts-expected.png:
  • platform/chromium-win/svg/batik/text/smallFonts-expected.txt:
  • platform/chromium-win/svg/batik/text/textAnchor-expected.png:
  • platform/chromium-win/svg/batik/text/textAnchor-expected.txt:
  • platform/chromium-win/svg/batik/text/textDecoration-expected.png:
  • platform/chromium-win/svg/batik/text/textDecoration-expected.txt:
  • platform/chromium-win/svg/batik/text/textEffect-expected.png:
  • platform/chromium-win/svg/batik/text/textEffect-expected.txt:
  • platform/chromium-win/svg/batik/text/textEffect2-expected.png:
  • platform/chromium-win/svg/batik/text/textEffect2-expected.txt:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.txt:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.txt:
  • platform/chromium-win/svg/batik/text/textLayout-expected.png:
  • platform/chromium-win/svg/batik/text/textLayout-expected.txt:
  • platform/chromium-win/svg/batik/text/textLayout2-expected.png:
  • platform/chromium-win/svg/batik/text/textLayout2-expected.txt:
  • platform/chromium-win/svg/batik/text/textLength-expected.png:
  • platform/chromium-win/svg/batik/text/textLength-expected.txt:
  • platform/chromium-win/svg/batik/text/textOnPath-expected.png:
  • platform/chromium-win/svg/batik/text/textOnPath-expected.txt:
  • platform/chromium-win/svg/batik/text/textOnPathSpaces-expected.png:
  • platform/chromium-win/svg/batik/text/textOnPathSpaces-expected.txt:
  • platform/chromium-win/svg/batik/text/textPosition-expected.png:
  • platform/chromium-win/svg/batik/text/textPosition-expected.txt:
  • platform/chromium-win/svg/batik/text/textPosition2-expected.png:
  • platform/chromium-win/svg/batik/text/textPosition2-expected.txt:
  • platform/chromium-win/svg/batik/text/textProperties-expected.png:
  • platform/chromium-win/svg/batik/text/textProperties-expected.txt:
  • platform/chromium-win/svg/batik/text/textProperties2-expected.png:
  • platform/chromium-win/svg/batik/text/textProperties2-expected.txt:
  • platform/chromium-win/svg/batik/text/textStyles-expected.png:
  • platform/chromium-win/svg/batik/text/textStyles-expected.txt:
  • platform/chromium-win/svg/batik/text/verticalText-expected.png:
  • platform/chromium-win/svg/batik/text/verticalText-expected.txt:
  • platform/chromium-win/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/chromium-win/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/chromium-win/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png: Added.
  • platform/mac-future/svg/batik/masking/maskRegions-expected.png: Removed.
  • platform/mac/svg/batik/masking/maskRegions-expected.png:
05:41 Changeset [110695] by commit-queue@webkit.org

WebHTTPBody: Keep track of whether the data includes passwords.
https://bugs.webkit.org/show_bug.cgi?id=81003

Patch by Marja Hölttä <marja@google.com> on 2012-03-14
Reviewed by Darin Fisher.

This change enables Chrome to save HTTP bodies selectively, only
if they don't contain passwords.

Source/WebCore:

  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::create): Check if the data contains passwords.

  • platform/network/FormData.cpp:

(WebCore::FormData::FormData): Added containsPasswordData, setContainsPasswordData.

  • platform/network/FormData.h:

(WebCore::FormData::containsPasswordData): Added.
(WebCore::FormData::setHasPasswordData): Added.
(FormData):

Source/WebKit/chromium:

  • public/platform/WebHTTPBody.h:

(WebHTTPBody): Added containsPasswordData, setContainsPasswordData.

  • src/WebHTTPBody.cpp:

(WebKit::WebHTTPBody::containsPasswordData): Added.
(WebKit):
(WebKit::WebHTTPBody::setContainsPasswordData): Added.

05:23 Changeset [110694] by vsevik@chromium.org

Web Inspector: Add snippets tab to scripts navigator.
https://bugs.webkit.org/show_bug.cgi?id=81018

Reviewed by Pavel Feldman.

Source/WebCore:

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator):
(WebInspector.ScriptsNavigator.prototype.get defaultFocusedElement):
(WebInspector.ScriptsNavigator.prototype.focus):
(WebInspector.ScriptsNavigator.prototype._showScriptFoldersSettingChanged):
(WebInspector.ScriptsNavigator.prototype.reset):
(WebInspector.ScriptsNavigator.prototype._getOrCreateFolderTreeElement):
(WebInspector.ScriptsNavigator.prototype._createFolderTreeElement):
(WebInspector.ScriptsNavigator.prototype._getOrCreateSnippetEvaluationsFolderTreeElement):
(WebInspector.ScriptsNavigator.prototype._scriptFolderIdentifier):
(WebInspector.NavigatorTreeOutline):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._revealExecutionLine):

  • inspector/front-end/SnippetsModel.js:

LayoutTests:

  • http/tests/inspector/debugger-test.js:
05:03 Changeset [110693] by pfeldman@chromium.org

Web Inspector: Copy on the Console gives a mangled result.
https://bugs.webkit.org/show_bug.cgi?id=81091

Reviewed by Vsevolod Vlasov.

Source/WebCore:

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._formatMessage):
(WebInspector.ConsoleMessageImpl.prototype._populateStackTraceTreeElement):

LayoutTests:

  • http/tests/inspector-enabled/console-clear-arguments-on-frame-remove-expected.txt:
  • http/tests/inspector/console-xhr-logging-async-expected.txt:
  • http/tests/inspector/console-xhr-logging-expected.txt:
  • inspector/console/console-assert-expected.txt:
  • inspector/console/console-big-array-expected.txt:
  • inspector/console/console-clear-expected.txt:
  • inspector/console/console-command-clear-expected.txt:
  • inspector/console/console-dir-expected.txt:
  • inspector/console/console-dirxml-expected.txt:
  • inspector/console/console-external-array-expected.txt:
  • inspector/console/console-format-collections-expected.txt:
  • inspector/console/console-format-expected.txt:
  • inspector/console/console-log-before-inspector-open-expected.txt:
  • inspector/console/console-log-document-proto-expected.txt:
  • inspector/console/console-log-syntax-error-expected.txt:
  • inspector/console/console-log-toString-object-expected.txt:
  • inspector/console/console-nested-group-expected.txt:
  • inspector/console/console-object-constructor-name-expected.txt:
  • inspector/console/console-repeat-count-expected.txt:
  • inspector/console/console-tests-expected.txt:
  • inspector/console/console-trace-expected.txt:
  • inspector/extensions/extensions-console-expected.txt:
  • platform/chromium/http/tests/inspector/console-cross-origin-iframe-logging-expected.txt:
  • platform/chromium/http/tests/inspector/console-resource-errors-expected.txt:
  • platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt:
  • platform/chromium/http/tests/inspector/network/script-as-text-loading-expected.txt:
  • platform/chromium/inspector/console/alert-toString-exception-expected.txt:
  • platform/chromium/inspector/console/console-dir-expected.txt:
  • platform/chromium/inspector/console/console-format-collections-expected.txt:
  • platform/chromium/inspector/console/console-format-expected.txt:
  • platform/chromium/inspector/console/console-log-document-proto-expected.txt:
  • platform/chromium/inspector/console/console-log-syntax-error-expected.txt:
  • platform/chromium/inspector/console/console-object-constructor-name-expected.txt:
  • platform/chromium/inspector/console/console-trace-in-eval-expected.txt:
  • platform/chromium/inspector/console/console-uncaught-exception-expected.txt:
  • platform/chromium/inspector/console/console-uncaught-exception-in-eval-expected.txt:
  • platform/qt/inspector/console/console-format-expected.png: Removed.
05:00 Changeset [110692] by zimmermann@webkit.org

2012-03-14 Nikolas Zimmermann <nzimmermann@rim.com>

External <use> xlink:href references do not work
https://bugs.webkit.org/show_bug.cgi?id=12499

Reviewed by Zoltan Herczeg.

Rebaseline tests after r110676 using Generic RGB Profile on Lion, and update them after my fixes.
Replace xml:id with id everywhere, to make the new tiny tests work.

  • platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt:
  • platform/mac/svg/batik/filters/feTile-expected.png:
  • platform/mac/svg/batik/filters/filterRegions-expected.png:
  • platform/mac/svg/batik/text/textEffect-expected.png:
  • platform/mac/svg/batik/text/textEffect3-expected.png:
  • platform/mac/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png:
  • svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t.svg:
  • svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t.svg:
  • svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t.svg:
  • svg/custom/use-external-crash-expected.txt: Added.
  • svg/custom/use-external-crash.svg: Added.

2012-03-14 Nikolas Zimmermann <nzimmermann@rim.com>

External <use> xlink:href references do not work
https://bugs.webkit.org/show_bug.cgi?id=12499

Reviewed by Zoltan Herczeg.

Follow-up fix after r110676.
Assertions are firing due last minute changes in isExternalURIReference.

Fix detecting local resources properly, when the given iri contains a /complex/path.
Use document->completeURL() instead, and compare with the document->url() to decide
if its a local reference or not.

If an external document load fails with an error (eg. file missing) don't assert
in debug builds, instead handle it gracefully.

I decided to clean the code up as well, to make it more safe & obvious.

Test: svg/custom/use-external-crash.svg

  • svg/SVGURIReference.cpp: (WebCore::SVGURIReference::targetElementFromIRIString):
  • svg/SVGURIReference.h: (WebCore::SVGURIReference::isExternalURIReference):
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::externalDocument): (WebCore::SVGUseElement::buildPendingResource):
04:56 Changeset [110691] by commit-queue@webkit.org

3D transformed surfaces with z>0 gets cropped
https://bugs.webkit.org/show_bug.cgi?id=81009

Patch by Lars Knudsen <lars.knudsen@nokia.com> on 2012-03-14
Reviewed by Noam Rosenthal.

The scissor clipping in TextureMapperGL didn't take 3D transforms
into account when calculating the clipping region.
Now, it will bail out early if the transform is not affine.

No new tests. Tested by current compositing layout tests.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::beginScissorClip):

04:47 Changeset [110690] by ossy@webkit.org

[Qt] Rebaseline after r110667.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-03-14
Reviewed by Csaba Osztrogonác.

  • platform/qt/http/tests/security/cross-frame-access-put-expected.txt:
04:43 Changeset [110689] by kkristof@inf.u-szeged.hu

[Qt] Unreviewed. Add platform specific expectaions after r110593

new file: LayoutTests/platform/qt/svg/custom/delete-text-crash-expected.png
new file: LayoutTests/platform/qt/svg/custom/delete-text-crash-expected.txt

04:39 Changeset [110688] by morrita@google.com

Unreviewed flakiness marking.

  • platform/chromium/test_expectations.txt:
04:06 Changeset [110687] by morrita@google.com

Unreviewed rebaselining expectations.

  • platform/chromium-linux/svg/batik/filters/feTile-expected.png:
  • platform/chromium-linux/svg/batik/filters/feTile-expected.txt: Added.
  • platform/chromium-linux/svg/batik/paints/gradientLimit-expected.png:
  • platform/chromium-linux/svg/batik/paints/gradientLimit-expected.txt: Added.
  • platform/chromium-linux/svg/batik/paints/patternRegionA-expected.png:
  • platform/chromium-linux/svg/batik/paints/patternRegionA-expected.txt: Added.
  • platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/longTextOnPath-expected.png:
  • platform/chromium-linux/svg/batik/text/longTextOnPath-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/textAnchor-expected.png:
  • platform/chromium-linux/svg/batik/text/textAnchor-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/textEffect-expected.png:
  • platform/chromium-linux/svg/batik/text/textEffect-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-linux/svg/batik/text/textEffect3-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/textLayout-expected.png:
  • platform/chromium-linux/svg/batik/text/textLayout-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/textLength-expected.png:
  • platform/chromium-linux/svg/batik/text/textLength-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/textOnPathSpaces-expected.png:
  • platform/chromium-linux/svg/batik/text/textOnPathSpaces-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/textPosition2-expected.png:
  • platform/chromium-linux/svg/batik/text/textPosition2-expected.txt:
  • platform/chromium-linux/svg/batik/text/textProperties2-expected.png:
  • platform/chromium-linux/svg/batik/text/textProperties2-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/verticalText-expected.png:
  • platform/chromium-linux/svg/batik/text/verticalText-expected.txt: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png: Added.
  • platform/chromium-mac-leopard/svg/batik/filters/feTile-expected.png:
  • platform/chromium-mac-leopard/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/textAnchor-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/textEffect-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/textLayout-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/textLength-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/textOnPathSpaces-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/textProperties2-expected.png:
  • platform/chromium-mac-leopard/svg/batik/text/verticalText-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/batik/filters/feTile-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/paints/gradientLimit-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/paints/patternRegionA-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/longTextOnPath-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/longTextOnPath-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/batik/text/textAnchor-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textEffect-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textLayout-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textLength-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textOnPathSpaces-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textPosition2-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textProperties2-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/verticalText-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png: Added.
03:44 Changeset [110686] by kkristof@inf.u-szeged.hu

[Qt] svg/animations tests are very flaky
https://bugs.webkit.org/show_bug.cgi?id=80703

Unreviewd, skipp svg/animations/animate-elem-08-t-drt.html

03:31 Changeset [110685] by kkristof@inf.u-szeged.hu

[Qt] Unreviewed, rebaseline after r110587.

03:11 Changeset [110684] by morrita@google.com

Unreviewed build fix.

  • html/track/TextTrackList.cpp:

(TextTrackList::append):
(TextTrackList::remove):
(TextTrackList::owner): Changed return type from HTMLMediaElement* to Node* and uninlined.

  • html/track/TextTrackList.h:

(TextTrackList):

03:04 Changeset [110683] by vsevik@chromium.org

Web Inspector: [InspectorIndexedDB] Remote object should be released when data view is removed/updated.
https://bugs.webkit.org/show_bug.cgi?id=81022

Reviewed by Pavel Feldman.

  • inspector/front-end/IndexedDBViews.js:

(WebInspector.IDBDataView):
(WebInspector.IDBDataView.prototype._updateData.callback):
(WebInspector.IDBDataView.prototype._updateData):
(WebInspector.IDBDataView.prototype.get statusBarItems):
(WebInspector.IDBDataView.prototype.clear):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.IndexedDBTreeElement.prototype._indexedDBRemoved):
(WebInspector.IDBDatabaseTreeElement.prototype.update):
(WebInspector.IDBDatabaseTreeElement.prototype.onselect):
(WebInspector.IDBDatabaseTreeElement.prototype._objectStoreRemoved):
(WebInspector.IDBDatabaseTreeElement.prototype.clear):
(WebInspector.IDBObjectStoreTreeElement.prototype.update):
(WebInspector.IDBObjectStoreTreeElement.prototype.onselect):
(WebInspector.IDBObjectStoreTreeElement.prototype._indexRemoved):
(WebInspector.IDBObjectStoreTreeElement.prototype.clear):
(WebInspector.IDBIndexTreeElement.prototype.onselect):
(WebInspector.IDBIndexTreeElement.prototype.clear):

03:02 Changeset [110682] by kkristof@inf.u-szeged.hu

[Qt] Unreviewed. Update expectaions after r110676

02:59 Changeset [110681] by vsevik@chromium.org

Web Inspector: Introduce SnippetsScriptMapping.
https://bugs.webkit.org/show_bug.cgi?id=80890

Reviewed by Pavel Feldman.

  • inspector/front-end/ScriptMapping.js:

(WebInspector.MainScriptMapping):
(WebInspector.MainScriptMapping.prototype.addScript):
(WebInspector.MainScriptMapping.prototype._mappingForScript):

  • inspector/front-end/SnippetsModel.js:

(WebInspector.SnippetsModel.prototype.snippetForId):
(WebInspector.SnippetsModel.prototype.snippetForSourceURL):
(WebInspector.SnippetsScriptMapping):
(WebInspector.SnippetsScriptMapping.prototype.uiSourceCodeList):
(WebInspector.SnippetsScriptMapping.prototype.addScript):
(WebInspector.SnippetsScriptMapping.prototype._snippetAdded):
(WebInspector.SnippetsScriptMapping.prototype._releaseSnippetScript.get if):
(WebInspector.SnippetsScriptMapping.prototype._releaseSnippetScript):
(WebInspector.SnippetsScriptMapping.prototype._snippetDeleted.get this):
(WebInspector.SnippetsScriptMapping.prototype._snippetDeleted):
(WebInspector.SnippetsScriptMapping.prototype.reset):
(WebInspector.SnippetContentProvider):

02:38 Changeset [110680] by philn@webkit.org

Unreviewed, GTK svg rebaseline after r110676.

  • platform/gtk/svg/batik/filters/feTile-expected.txt:
  • platform/gtk/svg/batik/filters/filterRegions-expected.txt:
  • platform/gtk/svg/batik/masking/maskRegions-expected.txt:
  • platform/gtk/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
  • platform/gtk/svg/batik/paints/patternRegionA-expected.txt:
  • platform/gtk/svg/batik/paints/patternRegions-expected.txt:
  • platform/gtk/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
  • platform/gtk/svg/batik/text/longTextOnPath-expected.txt:
  • platform/gtk/svg/batik/text/textAnchor-expected.txt:
  • platform/gtk/svg/batik/text/textDecoration-expected.txt:
  • platform/gtk/svg/batik/text/textEffect-expected.txt:
  • platform/gtk/svg/batik/text/textEffect2-expected.txt:
  • platform/gtk/svg/batik/text/textEffect3-expected.txt:
  • platform/gtk/svg/batik/text/textFeatures-expected.txt:
  • platform/gtk/svg/batik/text/textLayout-expected.txt:
  • platform/gtk/svg/batik/text/textLayout2-expected.txt:
  • platform/gtk/svg/batik/text/textLength-expected.txt:
  • platform/gtk/svg/batik/text/textOnPath-expected.txt:
  • platform/gtk/svg/batik/text/textOnPathSpaces-expected.txt:
  • platform/gtk/svg/batik/text/textPosition-expected.txt:
  • platform/gtk/svg/batik/text/textPosition2-expected.txt:
  • platform/gtk/svg/batik/text/textProperties-expected.txt:
  • platform/gtk/svg/batik/text/textProperties2-expected.txt:
  • platform/gtk/svg/batik/text/textStyles-expected.txt:
  • platform/gtk/svg/batik/text/verticalText-expected.txt:
  • platform/gtk/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/gtk/svg/hixie/error/014-expected.txt:
  • platform/gtk/svg/hixie/use/002-expected.txt:
02:08 Changeset [110679] by zimmermann@webkit.org

2012-03-14 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Update two pixel test results on Lion, now svg/ passes with --tolerance 0 again.

  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/mac/svg/hixie/mixed/003-expected.png:
02:01 Changeset [110678] by commit-queue@webkit.org

Unreviewed, rolling out r110673.
http://trac.webkit.org/changeset/110673
https://bugs.webkit.org/show_bug.cgi?id=81090

"Qt minimal build broken" (Requested by yurys on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-14

  • inspector/CodeGeneratorInspector.py:

(CommandReturnPassModel.ByPointer.get_set_return_condition):
(TypeModel.Enum.get_optional.EnumOptional.get_command_return_pass_model):
(TypeModel.ValueType.ValueOptional.get_command_return_pass_model):
(Generator.process_event):
(Generator.process_command):

  • inspector/ContentSearchUtils.cpp:

(WebCore::ContentSearchUtils::buildObjectForSearchMatch):
(WebCore::ContentSearchUtils::searchInTextByLines):

  • inspector/ContentSearchUtils.h:

(ContentSearchUtils):

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::evaluate):
(WebCore::InjectedScript::callFunctionOn):
(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::makeEvalCall):

  • inspector/InjectedScript.h:

(InjectedScript):

  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::didInvalidateStyleAttr):
(WebCore::InspectorDOMDebuggerAgent::willInsertDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willRemoveDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willModifyDOMAttr):
(WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::setScriptSource):
(WebCore::InspectorDebuggerAgent::getFunctionDetails):
(WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::didPause):
(WebCore::InspectorDebuggerAgent::breakProgram):
(WebCore::InspectorDebuggerAgent::clearBreakDetails):

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

  • inspector/InspectorPageAgent.cpp:

(WebCore::buildObjectForCookie):
(WebCore::buildArrayForCookies):
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::getResourceTree):
(WebCore::InspectorPageAgent::searchInResource):
(WebCore::InspectorPageAgent::searchInResources):
(WebCore::InspectorPageAgent::buildObjectForFrame):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):

  • inspector/InspectorPageAgent.h:
  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):

01:55 Changeset [110677] by ossy@webkit.org

Last buildfix for Qt after r110595. :)

Reviewed by Benjamin Poulain.

  • Api/qwebpage.cpp:
  • WebCoreSupport/GeolocationClientQt.h:
01:52 Changeset [110676] by reni@webkit.org

External <use> xlink:href references do not work
https://bugs.webkit.org/show_bug.cgi?id=12499

Reviewed by Nikolas Zimmermann.

Source/WebCore:

This is a follow-up patch after r108785.
In this patch we bind the previously introduced CachedSVGDocument class
into the caching mechanism of SVGUseElement. The mode how external resources
are handled is similar to the processing of internal ones. We build the instance
and shadow tree the same way but we have to keep in mind that the requested resources
maybe not loaded yet. We can check it with cachedDocumentIsStillLoading() function.

SVGURIReference::targetElementFromIRIString() also need to be extended. The baseURI
computation needs to take the referenced documents URL into account, instead of the current documents.

The patch affects a lot of tests which have external resources especially in svg/batik. Because
of the size of that test refactor they will be commited in a follow-up patch.

Tests: svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t.svg

svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t.svg
svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t.svg
svg/custom/use-extern-href.svg
svg/custom/use-referencing-an-image-expected.svg
svg/custom/use-referencing-an-image.svg
svg/custom/use-referencing-indirectly-itself-expected.svg
svg/custom/use-referencing-indirectly-itself.svg
svg/custom/use-referencing-itself-expected.svg
svg/custom/use-referencing-itself.svg
svg/dynamic-updates/SVGUseElement-dom-href1-attr.html
svg/dynamic-updates/SVGUseElement-dom-href2-attr.html
svg/dynamic-updates/SVGUseElement-svgdom-href1-prop.html
svg/dynamic-updates/SVGUseElement-svgdom-href2-prop.html

  • loader/cache/CachedResourceLoader.cpp:

(WebCore):
(WebCore::CachedResourceLoader::requestSVGDocument):

  • loader/cache/CachedResourceLoader.h:

(WebCore):
(CachedResourceLoader):

  • page/ContentSecurityPolicy.h:
  • platform/KURL.cpp:

(WebCore::equalIgnoringFragmentIdentifier):

  • platform/network/chromium/ResourceRequest.h:
  • svg/SVGURIReference.cpp:

(WebCore::urlFromIRIStringWithFragmentIdentifier):
(WebCore):
(WebCore::SVGURIReference::targetElementFromIRIString):

  • svg/SVGURIReference.h:

(SVGURIReference):
(WebCore::SVGURIReference::isExternalURIReference):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::SVGUseElement):
(WebCore::SVGUseElement::~SVGUseElement):
(WebCore):
(WebCore::SVGUseElement::referencedDocument):
(WebCore::SVGUseElement::externalDocument):
(WebCore::SVGUseElement::svgAttributeChanged):
(WebCore::dumpInstanceTree):
(WebCore::SVGUseElement::buildPendingResource):
(WebCore::SVGUseElement::buildShadowAndInstanceTree):
(WebCore::SVGUseElement::hasCycleUseReferencing):
(WebCore::SVGUseElement::expandUseElementsInShadowTree):
(WebCore::SVGUseElement::expandSymbolElementsInShadowTree):
(WebCore::SVGUseElement::notifyFinished):
(WebCore::SVGUseElement::cachedDocumentIsStillLoading):
(WebCore::SVGUseElement::instanceTreeIsLoading):

  • svg/SVGUseElement.h:

(WebCore):
(SVGUseElement):

LayoutTests:

Adding tests to check the new functionality of SVGUseElement what can use
sources from external URIs too. New tests in this patch cover the corner cases
of this feature: referencing resources directly and indirectly, changing
the referenced URI from an internal to an external one, handling
security issues like self referencing, self referencing across document, etc.
Furthermore the patch infer some rebaseline in svg/batik directory because
they use external resources.

  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Added.
  • platform/mac/svg/batik/filters/feTile-expected.png:
  • platform/mac/svg/batik/filters/feTile-expected.txt:
  • platform/mac/svg/batik/filters/filterRegions-expected.png:
  • platform/mac/svg/batik/filters/filterRegions-expected.txt:
  • platform/mac/svg/batik/masking/maskRegions-expected.png:
  • platform/mac/svg/batik/masking/maskRegions-expected.txt:
  • platform/mac/svg/batik/paints/gradientLimit-expected.png:
  • platform/mac/svg/batik/paints/gradientLimit-expected.txt:
  • platform/mac/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
  • platform/mac/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
  • platform/mac/svg/batik/paints/patternRegionA-expected.png:
  • platform/mac/svg/batik/paints/patternRegionA-expected.txt:
  • platform/mac/svg/batik/paints/patternRegions-expected.png:
  • platform/mac/svg/batik/paints/patternRegions-expected.txt:
  • platform/mac/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/mac/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
  • platform/mac/svg/batik/text/longTextOnPath-expected.png:
  • platform/mac/svg/batik/text/longTextOnPath-expected.txt:
  • platform/mac/svg/batik/text/smallFonts-expected.png:
  • platform/mac/svg/batik/text/smallFonts-expected.txt:
  • platform/mac/svg/batik/text/textAnchor-expected.png:
  • platform/mac/svg/batik/text/textAnchor-expected.txt:
  • platform/mac/svg/batik/text/textDecoration-expected.png:
  • platform/mac/svg/batik/text/textDecoration-expected.txt:
  • platform/mac/svg/batik/text/textEffect-expected.png:
  • platform/mac/svg/batik/text/textEffect-expected.txt:
  • platform/mac/svg/batik/text/textEffect2-expected.png:
  • platform/mac/svg/batik/text/textEffect2-expected.txt:
  • platform/mac/svg/batik/text/textEffect3-expected.png:
  • platform/mac/svg/batik/text/textEffect3-expected.txt:
  • platform/mac/svg/batik/text/textFeatures-expected.png:
  • platform/mac/svg/batik/text/textFeatures-expected.txt:
  • platform/mac/svg/batik/text/textLayout-expected.png:
  • platform/mac/svg/batik/text/textLayout-expected.txt:
  • platform/mac/svg/batik/text/textLayout2-expected.png:
  • platform/mac/svg/batik/text/textLayout2-expected.txt:
  • platform/mac/svg/batik/text/textLength-expected.png:
  • platform/mac/svg/batik/text/textLength-expected.txt:
  • platform/mac/svg/batik/text/textOnPath-expected.png:
  • platform/mac/svg/batik/text/textOnPath-expected.txt:
  • platform/mac/svg/batik/text/textOnPathSpaces-expected.png:
  • platform/mac/svg/batik/text/textOnPathSpaces-expected.txt:
  • platform/mac/svg/batik/text/textPosition-expected.png:
  • platform/mac/svg/batik/text/textPosition-expected.txt:
  • platform/mac/svg/batik/text/textPosition2-expected.png:
  • platform/mac/svg/batik/text/textPosition2-expected.txt:
  • platform/mac/svg/batik/text/textProperties-expected.png:
  • platform/mac/svg/batik/text/textProperties-expected.txt:
  • platform/mac/svg/batik/text/textProperties2-expected.png:
  • platform/mac/svg/batik/text/textProperties2-expected.txt:
  • platform/mac/svg/batik/text/textStyles-expected.png:
  • platform/mac/svg/batik/text/textStyles-expected.txt:
  • platform/mac/svg/batik/text/verticalText-expected.png:
  • platform/mac/svg/batik/text/verticalText-expected.txt:
  • platform/mac/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/mac/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/mac/svg/custom/use-extern-href-expected.png: Added.
  • platform/mac/svg/custom/use-extern-href-expected.txt: Added.
  • platform/mac/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png: Added.
  • platform/mac/svg/hixie/error/014-expected.txt:
  • platform/mac/svg/hixie/use/002-expected.png:
  • platform/mac/svg/hixie/use/002-expected.txt:
  • svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t.svg: Added.
  • svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t.svg: Added.
  • svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t.svg: Added.
  • svg/batik/filters/filterRegions.svg:
  • svg/batik/text/textProperties.svg:
  • svg/batik/text/textProperties2.svg:
  • svg/batik/text/textStyles.svg:
  • svg/custom/resources/rgb.svg:
  • svg/custom/use-extern-href.svg: Added.
  • svg/custom/use-referencing-an-image-expected.svg: Added.
  • svg/custom/use-referencing-an-image.svg: Added.
  • svg/custom/use-referencing-indirectly-itself-expected.svg: Added.
  • svg/custom/use-referencing-indirectly-itself.svg: Added.
  • svg/custom/use-referencing-itself-expected.svg: Added.
  • svg/custom/use-referencing-itself.svg: Added.
  • svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGUseElement-dom-href1-attr.html: Added.
  • svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGUseElement-dom-href2-attr.html: Added.
  • svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGUseElement-svgdom-href1-prop.html: Added.
  • svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGUseElement-svgdom-href2-prop.html: Added.
  • svg/dynamic-updates/script-tests/SVGUseElement-dom-href1-attr.js: Added.

(repaintTest):

  • svg/dynamic-updates/script-tests/SVGUseElement-dom-href2-attr.js: Added.

(repaintTest):

  • svg/dynamic-updates/script-tests/SVGUseElement-svgdom-href1-prop.js: Added.

(repaintTest):

  • svg/dynamic-updates/script-tests/SVGUseElement-svgdom-href2-prop.js: Added.

(repaintTest):

01:32 Changeset [110675] by philn@webkit.org

Unreviewed, skip a new failing inspector test in GTK and add new
baseline for a svg test.

  • platform/gtk/Skipped:
  • platform/gtk/svg/custom/delete-text-crash-expected.txt: Added.
01:18 Changeset [110674] by commit-queue@webkit.org

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-14

  • DEPS:
01:04 Changeset [110673] by commit-queue@webkit.org

Web Inspector: TypeBuilder: Introduce OptOutput class for optional output parameters
https://bugs.webkit.org/show_bug.cgi?id=80789

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-03-14
Reviewed by Yury Semikhatsky.

OptOutput class is added for optional return parameters.

Strict mode added to Generator that makes all parameter types strict
and drop pre-set default values for return parameters.

Debugger and Page domain is switched to strict mode.

  • inspector/CodeGeneratorInspector.py:

(CommandReturnPassModel.ByPointer):
(CommandReturnPassModel):
(CommandReturnPassModel.OptOutput):
(CommandReturnPassModel.OptOutput.init):
(CommandReturnPassModel.OptOutput.get_return_var_type):
(CommandReturnPassModel.OptOutput.get_output_argument_prefix):
(CommandReturnPassModel.OptOutput.get_output_to_raw_expression):
(CommandReturnPassModel.OptOutput.get_output_parameter_type):
(CommandReturnPassModel.OptOutput.get_set_return_condition):
(TypeModel.Enum.get_optional.EnumOptional.get_command_return_pass_model):
(TypeModel.ValueType.ValueOptional.get_command_return_pass_model):
(OptOutput):
(Generator.process_event):
(Generator.process_command):

  • inspector/ContentSearchUtils.cpp:

(WebCore::ContentSearchUtils::buildObjectForSearchMatch):
(WebCore::ContentSearchUtils::searchInTextByLines):

  • inspector/ContentSearchUtils.h:

(ContentSearchUtils):

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::evaluate):
(WebCore::InjectedScript::callFunctionOn):
(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::makeEvalCall):

  • inspector/InjectedScript.h:

(InjectedScript):

  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::setScriptSource):
(WebCore::InspectorDebuggerAgent::getFunctionDetails):
(WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::didPause):
(WebCore::InspectorDebuggerAgent::breakProgram):
(WebCore::InspectorDebuggerAgent::clearBreakDetails):

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

  • inspector/InspectorPageAgent.cpp:

(WebCore::buildObjectForCookie):
(WebCore::buildArrayForCookies):
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::getResourceTree):
(WebCore::InspectorPageAgent::searchInResource):
(WebCore::InspectorPageAgent::searchInResources):
(WebCore::InspectorPageAgent::buildObjectForFrame):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):

  • inspector/InspectorPageAgent.h:
  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):

01:04 Changeset [110672] by philn@webkit.org

Unreviewed, GTK rebaseline after r110667.

  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
00:32 Changeset [110671] by sergio@webkit.org

Unreviewed. Build fix for EFL after r110669.

  • PlatformEfl.cmake: added DNSSoup.cpp
00:31 Changeset [110670] by tkent@chromium.org

Merge 110226 - NULL renderer possible in WebCore::HTMLInputElement::setCanReceiveDroppedFiles()
https://bugs.webkit.org/show_bug.cgi?id=80648

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/events/input-element-display-none-in-dragleave-crash.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setCanReceiveDroppedFiles): NULL-check renderer().

LayoutTests:

  • fast/events/input-element-display-none-in-dragleave-crash-expected.txt: Added.
  • fast/events/input-element-display-none-in-dragleave-crash.html: Added.
  • platform/wk2/Skipped: WebKitTestRunner doesn't support

EventSender.beginDragWithFiles().

TBR=tkent@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9699014

00:23 Changeset [110669] by sergio@webkit.org

[GTK] Use the same DNS prefetching path than the other ports.
https://bugs.webkit.org/show_bug.cgi?id=80997

Reviewed by Martin Robinson.

This patch basically reverts r56128. There is no need to add an
special code path for GTK+ DNS pre-fetching because the main
reason to do that (some potential changes in libsoup) is not
going to happen. It also reduces the amount of DNS queries by
adding a NULL hostname check.

No need for new tests as this just moves code around.

  • GNUmakefile.list.am:
  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::parseAttribute):

  • html/HTMLLinkElement.cpp:
  • loader/LinkLoader.cpp:

(WebCore::LinkLoader::loadLink):

  • page/Chrome.cpp:

(WebCore::Chrome::mouseDidMoveOverElement):

  • platform/network/DNS.h:

(WebCore):

  • platform/network/ResourceHandle.cpp:
  • platform/network/ResourceHandle.h:

(ResourceHandle):

  • platform/network/chromium/DNSChromium.cpp:
  • platform/network/soup/DNSSoup.cpp: restored.

(WebCore):
(WebCore::prefetchDNS):

  • platform/network/soup/ResourceHandleSoup.cpp:
00:11 Changeset [110668] by commit-queue@webkit.org

GTK 32-bit Linux Release build failing after r110580 (from bug 80338)
https://bugs.webkit.org/show_bug.cgi?id=81063

Prospective build fix for GTK 32-bit Linux Release.

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-03-14
Reviewed by Martin Robinson.

  • Source/autotools/symbols.filter: Adding symbol for ClientRectList(Vector<FloatQuad>) for

GTK 32-bit.

00:06 Changeset [110667] by haraken@chromium.org

Return null when shouldAllowAccessToNode() fails
https://bugs.webkit.org/show_bug.cgi?id=80205

Reviewed by Adam Barth.

shouldAllowAccessToNode() is used for window.frameElement, HTMLFrameElement.contentDocument,
and getSVGDocument(). The spec of window.frameElement and HTMLFrameElement.contentDocument
requires that they should return null when the security check fails.
Thus this patch changes the return value from undefined to null.

http://www.whatwg.org/specs/web-apps/current-work/multipage/browsers.html#navigating-nested-browsing-contexts-in-the-dom
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#dom-iframe-contentdocument

Source/WebCore:

Tests: http/tests/security/local-iFrame-from-remote.html

http/tests/security/cross-frame-access-frameelement.html
http/tests/security/cross-frame-access-put.html

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateFunctionCallback):

  • bindings/scripts/test/JS/JSTestObj.cpp: Updated run-bindings-tests results.

(WebCore::jsTestObjContentDocument):
(WebCore::jsTestObjPrototypeFunctionGetSVGDocument):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::contentDocumentAttrGetter):
(WebCore::TestObjInternal::getSVGDocumentCallback):

LayoutTests:

  • http/tests/security/cross-frame-access-frameelement-expected.txt:
  • http/tests/security/local-iFrame-from-remote.html:
  • platform/chromium/http/tests/security/cross-frame-access-put-expected.txt:
  • platform/gtk/http/tests/security/cross-frame-access-put-expected.txt:
00:02 Changeset [110666] by morrita@google.com

Unreviewed, mark verifyCullChildLinesUpTopLeft() as failed.

  • tests/CCQuadCullerTest.cpp:

(WebCore):
(WebCore::TEST):

03/13/12:

23:54 Changeset [110665] by commit-queue@webkit.org

Source/WebCore: [Forms] Hidden input element should not have labels.
https://bugs.webkit.org/show_bug.cgi?id=80403

Patch by Yosifumi Inoue <yosin@chromium.org> on 2012-03-13
Reviewed by Kent Tamura.

This patch changes "labels" attribute behavior for hidden input type.
It returns null instead of NodeList of labels or empty node list.

Note: The HTML5 specification isn't clear for non-labelable element's "labels"
attribute return value. Firefox and Opera return empty node list. IE returns null.

No new tests. Existing tests are updated.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::isLabelable): Added. Dispatch to InputType.

  • html/HiddenInputType.h: Added isLabelable returning false.
  • html/InputType.cpp:

(WebCore::InputType::isLabelable): Added. Returning true for all input types except for "hidden" type.
(WebCore):

  • html/InputType.h:

(InputType): Added isLabelable declaration.

LayoutTests: [Forms] Hidden input element should not have labels.
https://bugs.webkit.org/show_bug.cgi?id=80403

Patch by Yosifumi Inoue <yosin@chromium.org> on 2012-03-13
Reviewed by Kent Tamura.

This patch changes expected text for null value of labels attribute
of hidden input type and labelable-elements to check null value for
the labels attribute of input type.

  • fast/forms/label/labelable-elements-expected.txt:
  • fast/forms/label/labelable-elements.html:
  • fast/forms/label/labels-add-htmlFor-label-expected.txt:
  • fast/forms/label/labels-add-parent-label-expected.txt:
  • fast/forms/label/labels-change-htmlFor-attribute-expected.txt:
  • fast/forms/label/labels-multiple-sibling-labels-expected.txt:
  • fast/forms/label/labels-parent-and-sibling-labels-expected.txt:
  • fast/forms/label/labels-remove-htmlFor-attribute-expected.txt:
  • fast/forms/label/labels-remove-htmlFor-label-expected.txt:
  • fast/forms/label/labels-remove-parent-label-expected.txt:
  • fast/forms/label/labels-set-htmlFor-attribute-expected.txt:
  • platform/chromium/fast/forms/label/labelable-elements-expected.txt:
  • platform/mac/fast/forms/label/labelable-elements-expected.txt:
23:35 Changeset [110664] by commit-queue@webkit.org

[Forms] The "output" element should have labels.
https://bugs.webkit.org/show_bug.cgi?id=80466

Patch by Yosifumi Inoue <yosin@chromium.org> on 2012-03-13
Reviewed by Kent Tamura.

Source/WebCore:

This patch enables functionality of "labels" attribute for
HTMLOutputElement implemented in LabelableElement which use
isLabelable predicate whether an element can have label or not.

Update existing tests in fast/forms/label/ directory to cover
the "output" element with the "labels" attribute.

  • html/HTMLOutputElement.h: Implement virtual method isLabelable.

LayoutTests:

This patch updates expectation for functioning the "labels"
attribute of the "output" elements which was not working
so far.

  • fast/forms/label/labelable-elements-expected.txt:
  • fast/forms/label/labels-add-htmlFor-label-expected.txt:
  • fast/forms/label/labels-add-parent-label-expected.txt:
  • fast/forms/label/labels-change-htmlFor-attribute-expected.txt:
  • fast/forms/label/labels-multiple-sibling-labels-expected.txt:
  • fast/forms/label/labels-parent-and-sibling-labels-expected.txt:
  • fast/forms/label/labels-remove-htmlFor-attribute-expected.txt:
  • fast/forms/label/labels-remove-htmlFor-label-expected.txt:
  • fast/forms/label/labels-remove-parent-label-expected.txt:
  • fast/forms/label/labels-set-htmlFor-attribute-expected.txt:
  • platform/chromium/fast/forms/label/labelable-elements-expected.txt:
  • platform/mac/fast/forms/label/labelable-elements-expected.txt
23:24 Changeset [110663] by morrita@google.com

Unreviewed, marking some tests flaky.

  • platform/chromium/test_expectations.txt:
20:19 Changeset [110662] by macpherson@chromium.org

Move opacity clamping into RenderStyle setter.
https://bugs.webkit.org/show_bug.cgi?id=76966

Reviewed by Eric Seidel.

Covered by existing tests.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyleBitfields::setOpacity):

19:54 Changeset [110661] by fpizlo@apple.com

ValueToInt32 speculation will cause OSR exits even when it does not have to
https://bugs.webkit.org/show_bug.cgi?id=81068
<rdar://problem/11043926>

Reviewed by Anders Carlsson.

Two related changes:
1) ValueToInt32 will now always just defer to the non-speculative path, instead

of exiting, if it doesn't know what speculations to perform.

2) ValueToInt32 will speculate boolean if it sees this to be profitable.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGNode.h:

(JSC::DFG::Node::shouldSpeculateBoolean):
(Node):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileValueToInt32):

19:47 Changeset [110660] by mhahnenberg@apple.com

More Windows build fixing

19:40 Changeset [110659] by mhahnenberg@apple.com

Windows build fix

19:28 Changeset [110658] by cevans@google.com

Merge 110593
BUG=112317
Review URL: https://chromiumcodereview.appspot.com/9703008

19:12 Changeset [110657] by mhahnenberg@apple.com

Type conversion of exponential part failed
https://bugs.webkit.org/show_bug.cgi?id=80673

Reviewed by Geoffrey Garen.

  • parser/Lexer.cpp:

(JSC::::lex):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::parseInt):
(JSC):
(JSC::jsStrDecimalLiteral): Added another template argument that exposes whether or not
we accept trailing junk to clients of jsStrDecimalLiteral. Also added additional template
parameter for strtod to allow trailing spaces.
(JSC::toDouble):
(JSC::parseFloat): Accept trailing junk, as per the ECMA 262 spec (15.1.2.3).

  • runtime/LiteralParser.cpp:

(JSC::::Lexer::lexNumber):

  • tests/mozilla/expected.html: Update the expected page for run-javascriptcore-tests so that

we will run ecma/TypeConversion/9.3.1-3.js as a regression test now.

  • wtf/dtoa.cpp:

(WTF):
(WTF::strtod): We also needed to sometimes accept trailing spaces to pass a few other tests that were
broken by changing the default allowance of trailing junk in jsStrDecimalLiteral.

  • wtf/dtoa.h:
  • wtf/dtoa/double-conversion.cc: When the AdvanceToNonspace function was lifted out of the

Chromium codebase, the person porting it only thought to check for spaces when skipping whitespace.
A few of our JSC tests check for other types of trailing whitespace, so I've added checks for those
here to cover those cases (horizontal tab, vertical tab, carriage return, form feed, and line feed).

  • wtf/text/WTFString.cpp:

(WTF::toDoubleType): Disallow trailing spaces, as this breaks form input verification stuff.

18:38 Changeset [110656] by igor.o@sisa.samsung.com

Split the extra logic out of RenderObjectChildList::updateBeforeAfterContent
https://bugs.webkit.org/show_bug.cgi?id=80856

Extra part of the generated content handling logic out of RenderObjectChildList::updateBeforeAfterContent

Reviewed by Julien Chaffraix.

No change in behavior expected.

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::updateBeforeAfterStyle):
(WebCore::createRenderForBeforeAfterContent):
(WebCore::RenderObjectChildList::updateBeforeAfterContent):

  • rendering/RenderObjectChildList.h:

(WebCore):
(RenderObjectChildList):

18:37 Changeset [110655] by ojan@chromium.org

FREEEEEDOOM!!! Last set of bulk Chromium-Lion rebaselines.

18:26 Changeset [110654] by fpizlo@apple.com

Unreviewed, build fix since is_pod<> includes some header that I didn't know about.
Removing the assert for now.

  • dfg/DFGOperations.h:
  • llint/LLIntSlowPaths.h:
18:09 Changeset [110653] by andersca@apple.com

Find bouncy doesn’t hide when a subframe is scrolled
https://bugs.webkit.org/show_bug.cgi?id=81060
<rdar://problem/9365329>

Reviewed by Andreas Kling.

Instead of hiding the find indicator when pageDidScroll is called, add a check to FindController::drawRect and hide
the find indicator there if the find selection bounds have changed since the last call to drawRect.

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::updateFindIndicator):
(WebKit::FindController::drawRect):

  • WebProcess/WebPage/FindController.h:

(FindController):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::pageDidScroll):

18:07 Changeset [110652] by jberlin@webkit.org

WebKitTestRunner needs a more-complete implementation of eventSender.
https://bugs.webkit.org/show_bug.cgi?id=42194

Skip yet another test that uses eventSender.

  • platform/wk2/Skipped:
17:46 Changeset [110651] by fpizlo@apple.com

Functions with C linkage should return POD types
https://bugs.webkit.org/show_bug.cgi?id=81061

Reviewed by Mark Rowe.

  • dfg/DFGOperations.h:
  • llint/LLIntSlowPaths.h:

(LLInt):
(SlowPathReturnType):
(JSC::LLInt::encodeResult):

17:36 Changeset [110650] by arv@chromium.org

Remove duplicate GC functions from layout tests
https://bugs.webkit.org/show_bug.cgi?id=81047

Reviewed by Ojan Vafai.

  • fast/canvas/webgl/shader-deleted-by-accessor.html:
  • fast/dom/Window/customized-property-survives-gc.html:
  • fast/dom/inline-event-attributes-lookup-removed-form.html:
  • fast/dom/inline-event-attributes-lookup-removed.html:
  • fast/dom/shadow/gc-shadow.html:
  • fast/filesystem/resources/file-writer-gc-blob.js:
  • fast/forms/input-image-submit.html:
  • fast/forms/interactive-validation-remove-node-in-handler.html:
  • fast/forms/select-set-length-with-mutation-remove.html:
  • fast/js/resources/js-test-pre.js:

(gc.else.gcRec):
(gc):

  • http/tests/websocket/tests/hixie76/close-on-unload-and-force-gc.html:
  • http/tests/websocket/tests/hybi/close-on-unload-and-force-gc.html:
  • webaudio/mediaelementaudiosourcenode-gc.html:
17:31 Changeset [110649] by jberlin@webkit.org

WebKitTestRunner needs layoutTestController.setEditingBehavior
https://bugs.webkit.org/show_bug.cgi?id=42689

Add more tests that use setEditingBehavior to the wk2 Skipped list.

  • platform/wk2/Skipped:
17:28 Changeset [110648] by enne@google.com

[chromium] Unreviewed, rebaseline fast/canvas/canvas-text-alignment
https://bugs.webkit.org/show_bug.cgi?id=78529

After r110620, root layer scrollbars are drawn opaque, so they no
longer differ between debug and release due to alpha values.
Rebaselining this test.

  • platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium/test_expectations.txt:
17:27 Changeset [110647] by ap@apple.com
  • platform/mac/fast/js/global-constructors-expected.txt: Added Selection.toString and WebKitMutationObserver.toString. Selection got exposed in <http://trac.webkit.org/changeset/109306>, and WebKitMutationObserver was probably failing for even longer.
17:18 Changeset [110646] by simon.fraser@apple.com

Fix potential crash when loading test results
https://bugs.webkit.org/show_bug.cgi?id=81062
<rdar://problem/11041732>

Reviewed by Dean Jackson.

If RenderLayerBacking::isSimpleContainerCompositingLayer() is called early,
before the document has a documentElement(), then it crashes. Fix with
a null check on documentElement().

No test because it's timing dependent.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):

17:08 Changeset [110645] by timothy_horton@apple.com

platform/mac/fast/forms/input-appearance-spinbutton(-up) fail on Lion
https://bugs.webkit.org/show_bug.cgi?id=81058

Add unreviewed expected failing result (which may actually be correct) for mac.

  • platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
17:06 Changeset [110644] by jberlin@webkit.org

MediaStream is not enabled on Mac. Skip all related tests.

  • platform/mac/Skipped:
16:58 Changeset [110643] by mitz@apple.com
<rdar://problem/11025225> Assertion failure in RenderView::computeRectForRepaint() (!repaintContainer
repaintContainer == this) at store.apple.com

https://bugs.webkit.org/show_bug.cgi?id=81051

Reviewed by Simon Fraser.

.:

  • ManualTests/inline-repaint-container.html: Added.

Source/WebCore:

Test: ManualTests/inline-repaint-container.html.

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::clippedOverflowRectForRepaint): This function was not handling the
case of the repaint container being a descendant of the containing block correctly, leading
to the assertion failure, but also to a correctness bug seen in the new test. If the repaint
container is a descendant of the containing block, just return the rect in the repaint
container coordinates.

16:57 Changeset [110642] by mitz@apple.com

<rdar://problem/11025217> [Mac] Assertion failure in collectComplexTextRunsForCharactersCoreText
https://bugs.webkit.org/show_bug.cgi?id=77044

Reviewed by Sam Weinig.

Source/WebCore:

Test: platform/mac/fast/text/core-text-fallback-to-unknown-font.html

Handle the case of Core Text choosing a fallback font that NSFontManager cannot find by name.

  • platform/graphics/FontCache.h:

(FontCache): Made ComplexTextController a friend class.

  • platform/graphics/mac/ComplexTextControllerCoreText.mm:

(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): Removed the
failing assertion, which was not true, and added code to handle the case where a font
cannot be found by name by using the font as returned from Core Text.

LayoutTests:

  • platform/mac/fast/text/core-text-fallback-to-unknown-font-expected.txt: Added.
  • platform/mac/fast/text/core-text-fallback-to-unknown-font.html: Added.
16:56 Changeset [110641] by arv@chromium.org

[V8] Use v8::V8::AddImplicitReferences instead of SetHiddenValue
https://bugs.webkit.org/show_bug.cgi?id=80880

Reviewed by Adam Barth.

Source/WebCore:

We used to add a hidden property in the getter to the returned wrapper.
With this patch we instead handle the liveness of the wrapper in the GC phase by
calling v8::V8::AddHiddenReference.

To reduce the amount of custom code we need, the V8 code generator now supports
GenerateIsReachable (as well as CustomIsReachable) which, even though different
from the JSC attribute, is used in the same cases and takes the same values (even though
at the moment not all JSC values are supported by V8). Interfaces that have *IsReachable
also have a dependent life time (just like if V8DependentLifetime was present).

Second try. This time with an added include in TextTrackList.cpp.

No new tests. Covered by existing tests.

  • Target.pri:
  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorJS.pm:

(GetGenerateIsReachable):
(GetCustomIsReachable):
(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(NeedsToVisitDOMWrapper):
(GetGenerateIsReachable):
(GetCustomIsReachable):
(GenerateVisitDOMWrapper):
(GenerateHeader):
(GenerateNamedConstructorCallback):
(GenerateImplementation):

  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):

  • bindings/v8/NPV8Object.cpp:

(WebCore::npObjectTypeInfo):

  • bindings/v8/V8GCController.cpp:

(WebCore::GrouperVisitor::visitDOMWrapper):

  • bindings/v8/WrapperTypeInfo.h:

(WebCore):
(WrapperTypeInfo):

  • bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Removed.
  • bindings/v8/custom/V8DOMStringMapCustom.cpp:
  • bindings/v8/custom/V8DOMTokenListCustom.cpp: Removed.
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore):

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:
  • bindings/v8/custom/V8StyleSheetCustom.cpp:

(WebCore::toV8):

  • css/CSSStyleSheet.idl:
  • css/StyleSheet.idl:
  • dom/DOMStringMap.idl:
  • dom/NamedNodeMap.idl:
  • html/DOMTokenList.idl:
  • html/track/TextTrackList.cpp:
  • html/track/TextTrackList.idl:

LayoutTests:

  • platform/chromium/test_expectations.txt:
16:45 Changeset [110640] by commit-queue@webkit.org

MathML crash in WebCore::Node::previousSibling()
https://bugs.webkit.org/show_bug.cgi?id=80773

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-03-13
Reviewed by Julien Chaffraix.

Source/WebCore:

When adding child for msub render, if the child is mtr or mtd render,
we will creat an anonymous render as the container. As the anonymous
render's node is 0, accessing it directly can cause crash.
We should do a valid check of the node before using. In addition to
that, for msub, attach the anonymous render and it's children to render
tree. For msubsup, such kind of situation should never happen based on
the current codebase.

Test: mathml/msub-anonymous-child-render-crash.html

  • rendering/mathml/RenderMathMLSubSup.cpp:

(WebCore::RenderMathMLSubSup::addChild):

LayoutTests:

  • mathml/msub-anonymous-child-render-crash-expected.txt: Added.
  • mathml/msub-anonymous-child-render-crash.html: Added.
16:43 Changeset [110639] by mihnea@adobe.com

[CSSRegions]NamedFlow::getRegionsByContentNode should not return a live NodeList
https://bugs.webkit.org/show_bug.cgi?id=81021

Reviewed by Ryosuke Niwa.

Reverting the original patch as we need a better solution.

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Node.cpp:

(WebCore::NodeListsNodeData::invalidateCaches):
(WebCore::NodeListsNodeData::isEmpty):

  • dom/Node.h:

(Node):

  • dom/NodeRareData.h:

(NodeListsNodeData):

  • dom/RegionNodeList.cpp: Removed.
  • dom/RegionNodeList.h: Removed.
  • dom/WebKitNamedFlow.cpp:
  • dom/WebKitNamedFlow.h:

(WebKitNamedFlow):

  • dom/WebKitNamedFlow.idl:
  • rendering/RenderFlowThread.cpp:
  • rendering/RenderFlowThread.h:
  • rendering/RenderRegion.h:

(RenderRegion):

LayoutTests:

  • fast/regions/get-regions-by-content-node-expected.txt: Removed.
  • fast/regions/get-regions-by-content-node-horiz-bt-expected.txt: Removed.
  • fast/regions/get-regions-by-content-node-horiz-bt.html: Removed.
  • fast/regions/get-regions-by-content-node-horiz-tb-expected.txt: Removed.
  • fast/regions/get-regions-by-content-node-horiz-tb.html: Removed.
  • fast/regions/get-regions-by-content-node-vert-lr-expected.txt: Removed.
  • fast/regions/get-regions-by-content-node-vert-lr.html: Removed.
  • fast/regions/get-regions-by-content-node-vert-rl-expected.txt: Removed.
  • fast/regions/get-regions-by-content-node-vert-rl.html: Removed.
  • fast/regions/get-regions-by-content-node.html: Removed.
  • fast/regions/get-regions-by-content-node2-expected.txt: Removed.
  • fast/regions/get-regions-by-content-node2.html: Removed.
16:39 Changeset [110638] by jeffm@apple.com

Support loading a WKPage from web archive data
https://bugs.webkit.org/show_bug.cgi?id=81044

This code was written by Jessie Berlin.

Reviewed by Brady Eidson.

  • UIProcess/API/C/WKPage.cpp:

(WKPageLoadWebArchiveData): Added.

  • UIProcess/API/C/WKPage.h: Added WKPageLoadWebArchiveData().


  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadWebArchiveData): Added.

  • UIProcess/WebPageProxy.h: Added loadWebArchiveData().
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadWebArchiveData): Added.

  • WebProcess/WebPage/WebPage.h: Added loadWebArchiveData().
  • WebProcess/WebPage/WebPage.messages.in: Added LoadWebArchiveData message.
16:31 Changeset [110637] by abarth@webkit.org

Note that this test is flaky. The flakiness dashboard says that this
test has been flaky for a while.

  • platform/chromium/test_expectations.txt:
16:28 Changeset [110636] by abarth@webkit.org

Add a Leopard-specific baseline for
fast/forms/file/file-input-pressed-state and generalize the
chromium-win-vista baseline to include all of windows.

  • platform/chromium-mac-leopard/fast/forms/file/file-input-pressed-state-expected.png: Added.
  • platform/chromium-win-vista/fast/forms/file: Removed.
  • platform/chromium-win-vista/fast/forms/file/file-input-pressed-state-expected.png: Removed.
  • platform/chromium-win-xp/fast/forms/file: Removed.
  • platform/chromium-win/fast/forms/file/file-input-pressed-state-expected.png: Added.
16:28 Changeset [110635] by shawnsingh@chromium.org

[chromium] wrong transform causing incorrect culling
https://bugs.webkit.org/show_bug.cgi?id=80471

Reviewed by James Robinson.

Source/WebCore:

Unit test added to CCRenderSurfaceTest.cpp

In addition to using originTransform() instead of drawTransform(),
this patch shuffles a bit of code so that a unit test can be
easily added.

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::appendQuadsForRenderSurfaceLayer):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::createSharedQuadState):
(WebCore):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(CCRenderSurface):

Source/WebKit/chromium:

  • tests/CCRenderSurfaceTest.cpp:

(WebCore::TEST):
(WebCore):

16:18 Changeset [110634] by tony@chromium.org

more multiline flexbox tests
https://bugs.webkit.org/show_bug.cgi?id=81025

Reviewed by Ojan Vafai.

Add a test case for wrap-reverse to verify that we align with the end of the flexbox.

  • css3/flexbox/multiline-reverse-wrap-overflow-expected.txt: Added.
  • css3/flexbox/multiline-reverse-wrap-overflow.html: Added.
16:11 Changeset [110633] by darin@chromium.org

fast/loader/form-submission-after-beforeunload-cancel.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=81024

Reviewed by Andy Estes.

  • fast/loader/form-submission-after-beforeunload-cancel.html:

Give the form post a better chance of loading before the FAIL timer.

16:00 Changeset [110632] by tomz@codeaurora.org

Alternate xml-stylesheets with no title are loaded, in violation of the CSSOM draft
https://bugs.webkit.org/show_bug.cgi?id=77549

Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-03-13
Reviewed by David Hyatt.

Source/WebCore:

Amended code to ignore alternate stylesheets that do not have a title attribute.

Test: fast/css/xml-stylesheet-alternate-no-title.xhtml

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::checkStyleSheet):

LayoutTests:

Added new text test, modified existing test: added title attribute to alternate stylesheet.

  • fast/css/xml-stylesheet-alternate-no-title-expected.txt: Added.
  • fast/css/xml-stylesheet-alternate-no-title.xhtml: Added.
  • fast/css/xml-stylesheet-alternate-processing.xhtml:
15:59 Changeset [110631] by fpizlo@apple.com

Loads from UInt32Arrays should not result in a double up-convert if it isn't necessary
https://bugs.webkit.org/show_bug.cgi?id=80979
<rdar://problem/11036848>

Reviewed by Oliver Hunt.

Also improved DFG IR dumping to include type information in a somewhat more
intuitive way.

  • bytecode/PredictedType.cpp:

(JSC::predictionToAbbreviatedString):
(JSC):

  • bytecode/PredictedType.h:

(JSC):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::forwardSpeculationCheck):

15:57 Changeset [110630] by commit-queue@webkit.org

[BlackBerry] Input focus state should unfocus the frame selection instead of the field.
https://bugs.webkit.org/show_bug.cgi?id=81023

Patch by Mike Fenton <mifenton@rim.com> on 2012-03-13
Reviewed by Antonio Gomes.

PR 137400.

Prevent cursor drawing by unfocusing the frame selection
when input mode is not ready.

Greatly simplify the decision to focus input fields by removing
all ties to the page load state and base it on input. Input mode
is disabled when a page load begins and enabled on any user input.

The field is focused and ready for input immediately, only the
frame selection (or cursor) is unfocused.

Reviewed Internally by Gen Mak, Antonio Gomes and Nima Ghanavatian.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):

  • Api/WebPageClient.h:
  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::shouldBeginEditing):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::InputHandler):
(BlackBerry::WebKit::InputHandler::setElementUnfocused):
(BlackBerry::WebKit::InputHandler::enableInputMode):
(BlackBerry::WebKit::InputHandler::setElementFocused):
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
(BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):
(BlackBerry::WebKit::InputHandler::handleKeyboardInput):
(BlackBerry::WebKit::InputHandler::setComposingText):

  • WebKitSupport/InputHandler.h:

(InputHandler):

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):

15:53 Changeset [110629] by leviw@chromium.org

Revert RenderLayer::absoluteBoundingBox to an IntRect
https://bugs.webkit.org/show_bug.cgi?id=81017

Reviewed by Eric Seidel.

Reverting RenderLayer::absoluteBoundingBox to an (pixel snapped) IntRect. Whenever
possible, we use integers representing for absolute coordinates. This is especially
relevant for methods, such as this one, that are exported and used in platform code.

No new tests. No change in behavior.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::absoluteBoundingBox):

  • rendering/RenderLayer.h:

(RenderLayer):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForPosition): This intersects
the absolute bounding box with the FrameView, which uses all integer values. It's
the only use of absoluteBoundingBox in WebCore.

15:51 Changeset [110628] by ap@apple.com

Adding missing results.

  • platform/mac/media/audio-repaint-expected.txt: Added.
  • platform/mac/media/controls-strict-expected.txt: Added.
  • platform/mac/media/video-controls-rendering-expected.txt: Added.
  • platform/mac/media/video-no-audio-expected.txt: Added.
  • platform/mac/media/video-display-toggle-expected.txt: Added. These already had PNG results, but no text results for platform/mac.
  • platform/mac/media/controls-layout-direction-expected.png: Added.
  • platform/mac/media/video-playing-and-pause-expected.png: Added. These had text results, but no pixel ones.
15:50 Changeset [110627] by nduca@chromium.org

[chromium] vsync ticks are needed in invisible tabs when we are still updating resources
https://bugs.webkit.org/show_bug.cgi?id=80910

Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::vsyncCallbackNeeded):

Source/WebKit/chromium:

  • tests/CCSchedulerStateMachineTest.cpp:

(WebCore::TEST):
(WebCore):

15:40 Changeset [110626] by commit-queue@webkit.org

Alternate stylesheets (without title attribute) are loaded on refresh
https://bugs.webkit.org/show_bug.cgi?id=24354

Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-03-13
Reviewed by David Hyatt.

Source/WebCore:

Alternate stylesheets are now ignored in <link> tags if
they have no title attribute (per spec).

Tests: fast/css/link-alternate-stylesheet-1.html

fast/css/link-alternate-stylesheet-2.html
fast/css/link-alternate-stylesheet-3.html
fast/css/link-alternate-stylesheet-4.html
fast/css/link-alternate-stylesheet-5.html

  • dom/Document.cpp:

(WebCore::Document::collectActiveStylesheets):

LayoutTests:

Addapted alternate stylesheet tests from http://robballou.com/switcher/sandbox/alternate1.php

  • fast/css/link-alternate-stylesheet-1-expected.txt: Added.
  • fast/css/link-alternate-stylesheet-1.html: Added.
  • fast/css/link-alternate-stylesheet-2-expected.txt: Added.
  • fast/css/link-alternate-stylesheet-2.html: Added.
  • fast/css/link-alternate-stylesheet-3-expected.txt: Added.
  • fast/css/link-alternate-stylesheet-3.html: Added.
  • fast/css/link-alternate-stylesheet-4-expected.txt: Added.
  • fast/css/link-alternate-stylesheet-4.html: Added.
  • fast/css/link-alternate-stylesheet-5-expected.txt: Added.
  • fast/css/link-alternate-stylesheet-5.html: Added.
  • fast/css/resources/basic.css: Added.

(body):
(code):
(#source):

  • fast/css/resources/high.css: Added.

(body):
(h1):

  • fast/css/resources/normal.css: Added.

(body):
(h1):

  • fast/css/resources/small.css: Added.

(body):

15:36 Changeset [110625] by jberlin@webkit.org

WKTR needs an implementation of setAsynchronousSpellCheckingEnabled.
https://bugs.webkit.org/show_bug.cgi?id=81042

Skip some tests on Mac WK2 that use setAsynchronousSpellCheckingEnabled.

  • platform/mac-wk2/Skipped:
15:35 Changeset [110624] by commit-queue@webkit.org

Region::contains(IntPoint) is slow
https://bugs.webkit.org/show_bug.cgi?id=81008

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-13
Reviewed by Anders Carlsson.

Source/WebCore:

Speed up Region::contains(IntPoint) by directly testing if the point
is inside the Region's shape, rather than using a temporary 1x1 Region
for the test.

Unit test: RegionTest.containsPoint

  • platform/graphics/Region.cpp:

(WebCore::Region::contains):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/RegionTest.cpp: Added.

(WebCore):
(WebCore::TEST):

15:32 Changeset [110623] by abarth@webkit.org

Copy the platform-independent result for this test to chromium-mac to
hide the failing result added to apple-mac in
http://trac.webkit.org/changeset/110614.

  • platform/chromium/fast/forms/label: Added.
  • platform/chromium/fast/forms/label/labelable-elements-expected.txt: Added.
15:21 Changeset [110622] by abarth@webkit.org

For some reason chromium-win and chromium-linux have a different number
of spaces in the expected results file.

  • platform/chromium-win/media/sources-fallback-codecs-expected.txt: Added.
15:13 Changeset [110621] by abarth@webkit.org

Merge expectations for
svg/as-background-image/svg-as-background-6.html. Previously, Snow
Leopard had different expectations than every other platform, but the
behavior seems to match the expectations for other platforms.

Really what's going on is that this is a bad test for the reasons
explained in the test_expectations.txt file. I'm not entirely sure how
to fix the test to have repeatable results.

This patch also notes some more compositing reflection tests as flaky,
similar to the failures in
https://bugs.webkit.org/show_bug.cgi?id=79823. These tests have been
flaky for a while, but they seem to be failing more frequently now. I
couldn't find any recent changes to explain why that might be.

  • platform/chromium/test_expectations.txt:
15:06 Changeset [110620] by enne@google.com

[chromium] Mark root layer scrollbars as always opaque to disable blending
https://bugs.webkit.org/show_bug.cgi?id=79951

Reviewed by James Robinson.

Source/WebCore:

Now that scrollbar layers exist, mark non-overlay root scrollbars as
opaque. This disables blending for correctness and performance.

  • page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::scrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawTileQuad):

LayoutTests:

Mark canvas-text-alignment.html as failing on Linux in general, not
just in debug. I believe that with this change, the same image will
pass on both release and debug, but will land that change separately.

  • platform/chromium/test_expectations.txt:
14:59 Changeset [110619] by commit-queue@webkit.org

[EFL][DRT] Expose window.internals object
https://bugs.webkit.org/show_bug.cgi?id=79900

Exposes window.internals for EFL's DRT. Makes possible to
remove some tests from the skip list.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-03-13
Reviewed by Antonio Gomes.

Tools:

  • DumpRenderTree/efl/CMakeLists.txt:
  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::onWindowObjectCleared):

LayoutTests:

  • platform/efl/Skipped:
14:59 Changeset [110618] by gavinp@chromium.org

Remove vestigal abortEvent from image attribute.
https://bugs.webkit.org/show_bug.cgi?id=80795

Reviewed by Adam Barth.

It seems we installed a listener for the abort event on images,
but never ever raised them. So this patch removes it. This could
cause different behaviour if the user sends abort events directly
at an image element, although addEventListener will still work.

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute):

14:52 Changeset [110617] by staikos@webkit.org

The callback is only used if SA_RESTART is defined. Compile it out
otherwise to avoid a warning.
https://bugs.webkit.org/show_bug.cgi?id=80926

Reviewed by Alexey Proskuryakov.

  • heap/MachineStackMarker.cpp:

(JSC):

14:51 Changeset [110616] by abarth@webkit.org

Add a mac-specific baseline for this new test introduced in
http://trac.webkit.org/changeset/110593. This test is interested in
whether it crashes, not in a 1px difference in text metrics.

  • platform/chromium-mac-snowleopard/svg/custom/delete-text-crash-expected.txt: Added.
14:48 Changeset [110615] by abarth@webkit.org

Remove bogus expectation.

  • platform/chromium-mac/fast/dom/nodesFromRect-basic-expected.txt: Removed.
14:43 Changeset [110614] by jberlin@webkit.org

r110542: New fast/forms/label/labelable-elements.html fails.
https://bugs.webkit.org/show_bug.cgi?id=80985

Add failing expected results for Mac to get the bots green.

  • platform/mac/fast/forms/label/labelable-elements-expected.txt: Added.
14:42 Changeset [110613] by abarth@webkit.org

Add image baselines after http://trac.webkit.org/changeset/110598.
These tests show the platform-specific file chooser UI.

  • platform/chromium-linux-x86/fast/forms/file: Removed.
  • platform/chromium-linux/fast/forms/file/file-input-pressed-state-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/file/file-input-pressed-state-expected.png: Added.
  • platform/chromium-win-vista/fast/forms/file/file-input-pressed-state-expected.png: Added.
14:37 Changeset [110612] by timothy_horton@apple.com

css3/filters/custom/custom-filter-property-computed-style.html passes in browser, fails in DRT
https://bugs.webkit.org/show_bug.cgi?id=81029
<rdar://problem/11040673>

Add unreviewed expected failing result for mac.

  • platform/mac/css3/filters/custom/custom-filter-property-computed-style-expected.txt:
14:36 Changeset [110611] by ojan@chromium.org

Chromium-Lion rebaselines.

14:30 Changeset [110610] by benjamin@webkit.org

Attempt to fix QtMinimal bot after r110595

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-13

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):

14:22 Changeset [110609] by benjamin@webkit.org

Another attempt at fixing QtMinimal bot after r110595

Blind fix, unreviewed.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-13

  • WebCoreSupport/GeolocationClientQt.h:
14:18 Changeset [110608] by japhet@chromium.org

Source/WebCore: Rework how a CachedRawResource decides if it can be reused
for a given ResourceRequest. Ensure method, body, cookie policy,
and all headers match.
http://bugs.webkit.org/show_bug.cgi?id=79325

Reviewed by Oliver Hunt.

Test: http/tests/cache/xhr-body.html

  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::canReuse):

  • loader/cache/CachedRawResource.h: Take a ResourceRequest in canReuse().
  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::determineRevalidationPolicy): Remove Range header

check, since it is now redundant.

LayoutTests: Test for http://bugs.webkit.org/show_bug.cgi?id=79325.

Reviewed by Oliver Hunt.

  • http/tests/cache/resources/body.php: Added.
  • http/tests/cache/xhr-body-expected.txt: Added.
  • http/tests/cache/xhr-body.html: Added.
14:15 Changeset [110607] by ap@apple.com

Updating some Mac results in media directory.

  • platform/chromium-mac/media/sources-fallback-codecs-expected.txt: Removed.
  • media/sources-fallback-codecs-expected.txt: Chromium result just matched what actually happened on Mac, so merging it into cross-platform.
  • platform/mac/media/audio-controls-rendering-expected.txt:
  • platform/mac/media/controls-after-reload-expected.txt:
  • platform/mac/media/media-controls-clone-expected.txt:
  • platform/mac/media/video-playing-and-pause-expected.txt: Updated for render tree changes. I'm getting the same results locally as buildbot does.
14:12 Changeset [110606] by timothy_horton@apple.com

Unreviewed rebaseline of fast/css/getComputedStyle/computed-style(without-renderer).html for mac, adding -webkit-grid-*

  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt: Added.
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
14:10 Changeset [110605] by commit-queue@webkit.org

Dump the generated code for ARM_TRADITIONAL
https://bugs.webkit.org/show_bug.cgi?id=80975

Patch by Hojong Han <hojong.han@samsung.com> on 2012-03-13
Reviewed by Gavin Barraclough.

  • assembler/LinkBuffer.h:

(JSC::LinkBuffer::dumpCode):

14:06 Changeset [110604] by benjamin@webkit.org

Attempt to fix QtMinimal bot after r110595

Blind fix, unreviewed.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-13

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::resetGeolocationMock):
(DumpRenderTreeSupportQt::setMockGeolocationPermission):
(DumpRenderTreeSupportQt::setMockGeolocationPosition):
(DumpRenderTreeSupportQt::setMockGeolocationError):
(DumpRenderTreeSupportQt::numberOfPendingGeolocationPermissionRequests):

  • WebCoreSupport/GeolocationPermissionClientQt.h:
14:03 Changeset [110603] by philn@webkit.org

Unreviewed, GTK rebaseline after r110587.

  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/call-a-constructor-as-a-function-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
14:02 Changeset [110602] by rwlbuis@webkit.org

Fix cast-align GCC warning
https://bugs.webkit.org/show_bug.cgi?id=80790

Reviewed by Dan Bates.

This touches unpackOneRowOfBGRA8ToRGBA8.

  • platform/graphics/GraphicsContext3D.cpp:

(WebCore):

13:59 Changeset [110601] by simon.fraser@apple.com

Refactor some code that is used to check whether a layer needs backing store
https://bugs.webkit.org/show_bug.cgi?id=80917

Reviewed by Dean Jackson.

Move some code out of isSimpleContainerCompositingLayer() in two new
methods to make the code more self-descriptive.

No behavior change, so no tests.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintsBoxDecorations):
(WebCore::RenderLayerBacking::paintsChildren):
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):

  • rendering/RenderLayerBacking.h:

(RenderLayerBacking):

13:47 Changeset [110600] by gavinp@chromium.org

Implement ApplicationCacheHost::canCacheInPageCache() for chromium.
https://bugs.webkit.org/show_bug.cgi?id=80905

Reviewed by Eric Seidel.

This won't cause chrome to use the PageCache, but it will cause our histogram statistics
describing PageCache use to be more accurate.

  • src/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::canCacheInPageCache):

13:30 Changeset [110599] by jchaffraix@webkit.org

Too many tests (200+ on SL, 80+ on Lion) tests are failing on Mac port
https://bugs.webkit.org/show_bug.cgi?id=80447

Unreviewed test rebaseline after r110072.

  • platform/mac/test_expectations.txt:
  • platform/mac/Skipped:

Moved an entry from test_expectations.txt to Skipped as it was failing differently
that expected (same image, different text baseline).

  • platform/mac/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt:
  • platform/mac/fast/block/lineboxcontain/glyphs-expected.txt:
  • platform/mac/fast/clip/008-expected.txt:
  • platform/mac/fast/forms/input-text-double-click-expected.txt:
  • platform/mac/fast/repaint/overflow-delete-line-expected.txt:

Rebaselined those tests.

13:15 Changeset [110598] by dbates@webkit.org

REGRESSION(r99369): File input button doesn't highlight when pressed
https://bugs.webkit.org/show_bug.cgi?id=79385

Reviewed by Kent Tamura.

Source/WebCore:

Fixes an issue where the file input button doesn't highlight on mouse press.

Currently we always override the active state of the button with whether
a dragged file is being hovered over the file input control (i.e. can the control
receive a dropped file; HTMLInputElement::canReceiveDroppedFiles()).
Instead, we should only override the active state of the button when the state
changes for whether we can receive dropped files (e.g. during a drag) so that
we honor the active state of the button when it is pressed.

Test: fast/forms/file/file-input-pressed-state.html

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::RenderFileUploadControl):
(WebCore::RenderFileUploadControl::updateFromElement):

  • rendering/RenderFileUploadControl.h:

(RenderFileUploadControl):

LayoutTests:

Add test to ensure that the file input button visually changes when pressed.

  • fast/forms/file/file-input-pressed-state-expected.txt: Added.
  • fast/forms/file/file-input-pressed-state.html: Added.
  • platform/mac/fast/forms/file/file-input-pressed-state-expected.png: Added.
13:15 Changeset [110597] by thakis@chromium.org

Merge 110499 - [Skia] Release CGImage used to apply color space conversion to SkBitmap
https://bugs.webkit.org/show_bug.cgi?id=80892

Patch by Brian Salomon <bsalomon@google.com> on 2012-03-12
Reviewed by Adam Barth.

Regressions should be covered by any test that does image decode on the mac.

  • platform/image-decoders/skia/ImageDecoderSkia.cpp:

(WebCore::resolveColorSpace):

TBR=abarth@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9689079

13:14 Changeset [110596] by commit-queue@webkit.org

[chromium] Use CCOcclusionTracker for draw culling
https://bugs.webkit.org/show_bug.cgi?id=80743

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-13
Reviewed by Adrienne Walker.

Source/WebCore:

In this CL we enable the use of CCOcclusionTracker for draw-side
culling. This means moving from a per-quad culling model to a
per-layer model.

When calculating RenderPasses, we construct the set of passes,
then iterate over layers in front-to-back order. We make
CCQuadCuller instantiable, and pass it to the layer
appendQuads() methods instead of the bare list, where it can
filter quads before the end up in the list.

Covered by existing tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawRenderPass):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:

(WebCore::CCCanvasLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCCanvasLayerImpl.h:

(CCCanvasLayerImpl):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::appendQuads):
(WebCore::CCLayerImpl::appendGutterQuads):
(WebCore::CCLayerImpl::appendDebugBorderQuad):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore):
(CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::drawLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:

(WebCore::CCPluginLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCPluginLayerImpl.h:

(CCPluginLayerImpl):

  • platform/graphics/chromium/cc/CCQuadCuller.cpp:

(WebCore::CCQuadCuller::CCQuadCuller):
(WebCore::CCQuadCuller::append):

  • platform/graphics/chromium/cc/CCQuadCuller.h:

(WebCore):
(CCQuadCuller):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::appendQuadsForLayer):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(WebCore):
(CCQuadList):
(WebCore::CCQuadList::backToFrontBegin):
(WebCore::CCQuadList::backToFrontEnd):
(CCRenderPass):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:

(WebCore::CCScrollbarLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:

(CCScrollbarLayerImpl):

  • platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp:

(WebCore::CCSolidColorLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCSolidColorLayerImpl.h:

(CCSolidColorLayerImpl):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:

(CCTiledLayerImpl):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:

(CCVideoLayerImpl):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::BlendStateCheckLayer::appendQuads):

  • tests/CCQuadCullerTest.cpp:

(TestCCOcclusionTrackerImpl):
(WebCore::TestCCOcclusionTrackerImpl::TestCCOcclusionTrackerImpl):
(WebCore::TestCCOcclusionTrackerImpl::layerScissorRectInTargetSurface):
(WebCore::makeLayer):
(WebCore::appendQuads):
(WebCore):
(WebCore::TEST):

  • tests/CCSolidColorLayerImplTest.cpp:

(CCLayerTestCommon::TEST):

  • tests/CCTiledLayerImplTest.cpp:

(CCLayerTestCommon::TEST):
(CCLayerTestCommon::getQuads):

  • tests/MockCCQuadCuller.h: Added.

(WebCore):
(MockCCQuadCuller):
(WebCore::MockCCQuadCuller::MockCCQuadCuller):
(WebCore::MockCCQuadCuller::append):
(WebCore::MockCCQuadCuller::quadList):

LayoutTests:

  • platform/chromium-linux/compositing/direct-image-compositing-expected.png:
  • platform/chromium-linux/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-linux/platform/chromium/compositing/huge-layer-rotated-expected.png:
  • platform/chromium/test_expectations.txt:
13:10 Changeset [110595] by benjamin@webkit.org

Always enable ENABLE(CLIENT_BASED_GEOLOCATION)
https://bugs.webkit.org/show_bug.cgi?id=78853

Patch by Adam Barth <abarth@webkit.org> && Benjamin Poulain <bpoulain@apple.com> on 2012-03-13
Reviewed by Adam Barth.

.:

  • Source/cmake/OptionsBlackBerry.cmake:
  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsWinCE.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:
  • wtf/Platform.h:

Source/WebCore:

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • Modules/geolocation/Geolocation.cpp:

(WebCore):
(WebCore::createPositionError):
(WebCore::Geolocation::Geolocation):
(WebCore::Geolocation::stop):
(WebCore::Geolocation::lastPosition):
(WebCore::Geolocation::requestPermission):
(WebCore::Geolocation::startUpdating):
(WebCore::Geolocation::stopUpdating):

  • Modules/geolocation/Geolocation.h:

(WebCore):
(Geolocation):

  • Modules/geolocation/GeolocationController.cpp:
  • Modules/geolocation/GeolocationController.h:
  • Modules/geolocation/GeolocationError.h:
  • Modules/geolocation/GeolocationPosition.h:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • bindings/js/JSGeolocationCustom.cpp:
  • loader/EmptyClients.h:

(EmptyChromeClient):

  • page/ChromeClient.h:

(ChromeClient):

  • page/Page.cpp:

(WebCore::Page::Page):

  • page/Page.h:

(Page):

  • platform/GeolocationService.cpp: Removed.
  • platform/GeolocationService.h: Removed.
  • platform/mock/GeolocationClientMock.cpp:
  • platform/mock/GeolocationClientMock.h:
  • platform/mock/GeolocationServiceMock.cpp: Removed.
  • platform/mock/GeolocationServiceMock.h: Removed.

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

  • WebCoreSupport/AboutDataEnableFeatures.in:
  • WebCoreSupport/ChromeClientBlackBerry.cpp:
  • WebCoreSupport/ChromeClientBlackBerry.h:

(ChromeClientBlackBerry):

  • WebKitSupport/DumpRenderTreeSupport.cpp:

(toGeolocationClientMock):
(DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests):
(DumpRenderTreeSupport::resetGeolocationMock):
(DumpRenderTreeSupport::setMockGeolocationError):
(DumpRenderTreeSupport::setMockGeolocationPermission):
(DumpRenderTreeSupport::setMockGeolocationPosition):

Source/WebKit/chromium:

  • features.gypi:
  • src/ChromeClientImpl.cpp:
  • src/ChromeClientImpl.h:

(ChromeClientImpl):

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore):

  • WebCoreSupport/ChromeClientEfl.h:

(ChromeClientEfl):

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit):

  • WebCoreSupport/ChromeClientGtk.h:

(WebKit::ChromeClient::scrollRectIntoView):

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::resetGeolocationClientMock):
(DumpRenderTreeSupportGtk::setMockGeolocationPermission):
(DumpRenderTreeSupportGtk::setMockGeolocationPosition):
(DumpRenderTreeSupportGtk::setMockGeolocationError):
(DumpRenderTreeSupportGtk::numberOfPendingGeolocationPermissionRequests):

  • WebCoreSupport/GeolocationClientGtk.cpp:

(WebKit::GeolocationClient::requestPermission):
(WebKit::GeolocationClient::cancelPermissionRequest):

  • WebCoreSupport/GeolocationClientGtk.h:

(WebKit):

  • webkit/webkitwebview.cpp:

(webkit_web_view_init):

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:
  • WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

  • WebCoreSupport/WebGeolocationClient.mm:

(WebGeolocationClient::lastPosition):

  • WebView/WebGeolocationPosition.mm:

(-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
(core):
(-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):

  • WebView/WebGeolocationPositionInternal.h:
  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _geolocationDidChangePosition:]):
(-[WebView _geolocationDidFailWithError:]):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):

  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(toGeolocationClientMock):
(DumpRenderTreeSupportQt::resetGeolocationMock):
(DumpRenderTreeSupportQt::setMockGeolocationPermission):
(DumpRenderTreeSupportQt::setMockGeolocationPosition):
(DumpRenderTreeSupportQt::setMockGeolocationError):
(DumpRenderTreeSupportQt::numberOfPendingGeolocationPermissionRequests):

  • WebCoreSupport/GeolocationClientQt.h:

(WebCore):

Source/WebKit/win:

  • WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

  • WebCoreSupport/WebGeolocationClient.cpp:

(WebGeolocationClient::lastPosition):

  • WebGeolocationPosition.cpp:

(WebGeolocationPosition::initWithTimestamp):
(core):

  • WebGeolocationPosition.h:

(WebGeolocationPosition):
(WebGeolocationPosition::impl):

  • WebView.cpp:

(WebView::initWithFrame):
(WebView::geolocationDidChangePosition):
(WebView::geolocationDidFailWithError):

Source/WebKit/wince:

  • WebCoreSupport/ChromeClientWinCE.cpp:
  • WebCoreSupport/ChromeClientWinCE.h:

(ChromeClientWinCE):

Source/WebKit/wx:

  • WebKitSupport/ChromeClientWx.cpp:
  • WebKitSupport/ChromeClientWx.h:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
  • WebProcess/Geolocation/WebGeolocationManager.cpp:

(WebKit::WebGeolocationManager::registerWebPage):
(WebKit::WebGeolocationManager::unregisterWebPage):
(WebKit::WebGeolocationManager::didChangePosition):
(WebKit::WebGeolocationManager::didFailToDeterminePosition):

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setGeoLocationPermission):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit):

  • WebProcess/WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

  • WebProcess/WebCoreSupport/WebGeolocationClient.cpp:
  • WebProcess/WebCoreSupport/WebGeolocationClient.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

  • mac/WebKit2.order:

Tools:

  • Scripts/build-webkit:
  • qmake/mkspecs/features/features.prf:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
13:05 Changeset [110594] by tonikitoo@webkit.org

Convert nodesFromRect tests to use Internals interface
https://bugs.webkit.org/show_bug.cgi?id=80886

Reviewed by Ryosuke Niwa.
Patch by Antonio Gomes <agomes@rim.com>

Source/WebCore:

Add Internals::nodesFromRect implementation to unify
the codepath for testing Document::nodesFromRect in a
cross port way.

No new tests, since we are improving here the infra-structure
for testing a specific method.

  • testing/Internals.cpp:

(WebCore::Internals::nodesFromRect):
(WebCore):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit/gtk:

Removed DRTSupportGtk::nodesFromRect support, since
it can work in the cross-port way through the
Internals interface.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Source/WebKit/mac:

Removed mac specific support for nodesFromRect for testing purposes only,
since it can work in a cross-port way through the Internals interface.

  • WebKit.order:
  • WebView/WebView.mm:
  • WebView/WebViewPrivate.h:

Source/WebKit/qt:

Removed DRTSupportQt::nodesFromRect support, since
it can work in the cross-port way through the
Internals interface.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

This clean up allows to remove port specific bits of each
DRT implementation that supports testing Document::nodesFromRect,
in favor of making use of the 'Internals' interface to test it.

This makes its code conveniently more expansible and cleaner.

Also removed stubs from Win and EFL, Wn and BlackBerry DRTs.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  • DumpRenderTree/qt/LayoutTestControllerQt.h:

(LayoutTestController):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

LayoutTests:

Adjust nodesFromRect tests to use Internals
instead of LayoutTestController interface.

  • fast/dom/resources/nodesFromRect.js:

(check):

12:48 Changeset [110593] by schenney@chromium.org

Fix the use of stale text fragments
https://bugs.webkit.org/show_bug.cgi?id=80729

Patch by Philip Rogers <pdr@google.com> on 2012-03-13
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Previously, we were allowing SVGTextFragments to get out of sync with the
actual text in RenderSVGInlineTextBox. This patch reuses the dirty line
box code in RenderText::setTextWithOffset to force
clearTextFragments() when setTextWithOffset is called, preventing the use
of stale SVGTextFragments.

Test: svg/custom/delete-text-crash.html

  • rendering/InlineBox.h:

(InlineBox):

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::dirtyLineBoxes):
(WebCore):

  • rendering/svg/SVGInlineTextBox.h:

(SVGInlineTextBox):

LayoutTests:

  • svg/custom/delete-text-crash-expected.png: Added.
  • svg/custom/delete-text-crash-expected.txt: Added.
  • svg/custom/delete-text-crash.html: Added.
12:33 Changeset [110592] by ojan@chromium.org

Fix some broken layout test rebaselines from the various chromium-lion
rebaselining patches. The bugs in the rebaseline tool that caused the breakages
are now fixed.

  • platform/chromium-mac-leopard/css2.1/t1202-counter-04-b-expected.txt: Added.
  • platform/chromium-mac-leopard/css2.1/t1202-counters-04-b-expected.txt: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/paste-table-cells-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/basic/014-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/basic/020-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/dynamic-unfloat-pref-width-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-mac-leopard/fast/block/margin-collapse/044-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-mac-leopard/fast/block/margin-collapse/045-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/positioning/054-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/pseudo-element-line-break-expected.png: Added.
  • platform/chromium-mac-leopard/fast/events/onload-re-entry-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/disabled-select-change-index-expected.txt:
  • platform/chromium-mac-leopard/fast/forms/select-writing-direction-natural-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/select-writing-direction-natural-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/inline/002-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-mac-leopard/fast/inline/vertical-align-text-bottom-expected.png: Added.
  • platform/chromium-mac-leopard/fast/invalid/002-expected.png: Added.
  • platform/chromium-mac-leopard/fast/invalid/005-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-mac-leopard/fast/invalid/007-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-mac-leopard/fast/invalid/020-expected.png: Added.
  • platform/chromium-mac-leopard/fast/invalid/missing-end-tag-expected.png: Added.
  • platform/chromium-mac-leopard/fast/lists/006-expected.png: Added.
  • platform/chromium-mac-leopard/fast/loader/text-document-wrapping-expected.png: Added.
  • platform/chromium-mac-leopard/fast/parser/tabs-in-scripts-expected.png: Added.
  • platform/chromium-mac-leopard/fast/parser/xhtml-alternate-entities-expected.png: Added.
  • platform/chromium-mac-leopard/fast/replaced/three-selects-break-expected.png: Added.
  • platform/chromium-mac-leopard/fast/selectors/002-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/001-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/010-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/013-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/015-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-mac-leopard/fast/table/022-expected.png: Added.
  • platform/chromium-mac-leopard/scrollbars/basic-scrollbar-expected.png: Added.
  • platform/chromium-mac-leopard/scrollbars/disabled-scrollbar-expected.png: Added.
  • platform/chromium-mac-leopard/scrollbars/scrollbar-buttons-expected.png: Added.
  • platform/chromium-mac-leopard/scrollbars/scrollbar-orientation-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
  • platform/chromium/test_expectations.txt:
12:27 Changeset [110591] by zimmermann@webkit.org

SVG Animations update baseVal instead of animVal
https://bugs.webkit.org/show_bug.cgi?id=12437

Reviewed by Dirk Schulze.

Blind fix for some GC related assertions firing on v8.

Assure that animationStarted/animationEnded calls are happening
on the same SVGAnimatedProperty. Always call animationEnded(),
even if we shouldn't do anything for the target element, as its
destructed, as we still have to reset m_isAnimating.

  • svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::SVGAnimateElement):
(WebCore::SVGAnimateElement::resetToBaseValue):
(WebCore::SVGAnimateElement::targetElementWillChange):

  • svg/SVGAnimateElement.h:

(SVGAnimateElement):

  • svg/properties/SVGAnimatedPropertyTearOff.h:

(WebCore::SVGAnimatedPropertyTearOff::animationEnded):

12:19 Changeset [110590] by ojan@chromium.org

Chromium-Lion rebaselines.

12:12 Changeset [110589] by commit-queue@webkit.org

Move DirectoryEntry and DirectoryReader to new Modules/filesystem/ directory
https://bugs.webkit.org/show_bug.cgi?id=80625

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-03-13
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • Modules/filesystem: Added.
  • Modules/filesystem/DirectoryEntry.cpp: Copied from Source/WebCore/fileapi/DirectoryEntry.cpp.
  • Modules/filesystem/DirectoryEntry.h: Copied from Source/WebCore/fileapi/DirectoryEntry.h.
  • Modules/filesystem/DirectoryEntry.idl: Copied from Source/WebCore/fileapi/DirectoryEntry.idl.
  • Modules/filesystem/DirectoryEntrySync.cpp: Copied from Source/WebCore/fileapi/DirectoryEntrySync.cpp.
  • Modules/filesystem/DirectoryEntrySync.h: Copied from Source/WebCore/fileapi/DirectoryEntrySync.h.
  • Modules/filesystem/DirectoryEntrySync.idl: Copied from Source/WebCore/fileapi/DirectoryEntrySync.idl.
  • Modules/filesystem/DirectoryReader.cpp: Copied from Source/WebCore/fileapi/DirectoryReader.cpp.
  • Modules/filesystem/DirectoryReader.h: Copied from Source/WebCore/fileapi/DirectoryReader.h.
  • Modules/filesystem/DirectoryReader.idl: Copied from Source/WebCore/fileapi/DirectoryReader.idl.
  • Modules/filesystem/DirectoryReaderBase.h: Copied from Source/WebCore/fileapi/DirectoryReaderBase.h.
  • Modules/filesystem/DirectoryReaderSync.cpp: Copied from Source/WebCore/fileapi/DirectoryReaderSync.cpp.
  • Modules/filesystem/DirectoryReaderSync.h: Copied from Source/WebCore/fileapi/DirectoryReaderSync.h.
  • Modules/filesystem/DirectoryReaderSync.idl: Copied from Source/WebCore/fileapi/DirectoryReaderSync.idl.
  • Target.pri:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • fileapi/DirectoryEntry.cpp: Removed.
  • fileapi/DirectoryEntry.h: Removed.
  • fileapi/DirectoryEntry.idl: Removed.
  • fileapi/DirectoryEntrySync.cpp: Removed.
  • fileapi/DirectoryEntrySync.h: Removed.
  • fileapi/DirectoryEntrySync.idl: Removed.
  • fileapi/DirectoryReader.cpp: Removed.
  • fileapi/DirectoryReader.h: Removed.
  • fileapi/DirectoryReader.idl: Removed.
  • fileapi/DirectoryReaderBase.h: Removed.
  • fileapi/DirectoryReaderSync.cpp: Removed.
  • fileapi/DirectoryReaderSync.h: Removed.
  • fileapi/DirectoryReaderSync.idl: Removed.
12:06 Changeset [110588] by igor.o@sisa.samsung.com

animation-iteration-count does not handle floating point values correctly.
https://bugs.webkit.org/show_bug.cgi?id=69531

Source/WebCore:

Implements support for non-integers animation-iteration-count numbers.
Non-integer numbers will cause the animation to end part-way through a cycle.

Reviewed by Dean Jackson.

Tests: animations/fill-mode-iteration-count-non-integer.html

animations/keyframes-iteration-count-non-integer.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseAnimationIterationCount):

  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::fractionalTime):
(WebCore::AnimationBase::progress):

  • page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::pauseAnimationAtTime):

  • platform/animation/Animation.h:

(WebCore::Animation::iterationCount):
(WebCore::Animation::setIterationCount):
(Animation):
(WebCore::Animation::initialAnimationIterationCount):

LayoutTests:

Reviewed by Dean Jackson.

  • animations/fill-mode-iteration-count-non-integer-expected.txt: Added.
  • animations/fill-mode-iteration-count-non-integer.html: Added.
  • animations/keyframes-iteration-count-non-integer-expected.txt: Added.
  • animations/keyframes-iteration-count-non-integer.html: Added.
11:51 Changeset [110587] by tommyw@google.com

MediaStream API: Rename PeerConnection to DeprecatedPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=80692

Reviewed by Adam Barth.

First patch in a series of patches to change the PeerConnection from ROAP to JSEP,
see bug 80589 for more information.

Source/WebCore:

Patch covered by modified existing tests.

  • GNUmakefile.list.am:
  • Modules/mediastream/DOMWindowMediaStream.idl:
  • Modules/mediastream/DeprecatedPeerConnection.cpp: Renamed from Source/WebCore/Modules/mediastream/PeerConnection.cpp.

(WebCore):
(WebCore::DeprecatedPeerConnection::create):
(WebCore::DeprecatedPeerConnection::DeprecatedPeerConnection):
(WebCore::DeprecatedPeerConnection::~DeprecatedPeerConnection):
(WebCore::DeprecatedPeerConnection::processSignalingMessage):
(WebCore::DeprecatedPeerConnection::readyState):
(WebCore::DeprecatedPeerConnection::send):
(WebCore::DeprecatedPeerConnection::addStream):
(WebCore::DeprecatedPeerConnection::removeStream):
(WebCore::DeprecatedPeerConnection::localStreams):
(WebCore::DeprecatedPeerConnection::remoteStreams):
(WebCore::DeprecatedPeerConnection::close):
(WebCore::DeprecatedPeerConnection::didCompleteICEProcessing):
(WebCore::DeprecatedPeerConnection::didGenerateSDP):
(WebCore::DeprecatedPeerConnection::didReceiveDataStreamMessage):
(WebCore::DeprecatedPeerConnection::didAddRemoteStream):
(WebCore::DeprecatedPeerConnection::didRemoveRemoteStream):
(WebCore::DeprecatedPeerConnection::interfaceName):
(WebCore::DeprecatedPeerConnection::scriptExecutionContext):
(WebCore::DeprecatedPeerConnection::stop):
(WebCore::DeprecatedPeerConnection::eventTargetData):
(WebCore::DeprecatedPeerConnection::ensureEventTargetData):
(WebCore::DeprecatedPeerConnection::scheduleInitialNegotiation):
(WebCore::DeprecatedPeerConnection::initialNegotiationTimerFired):
(WebCore::DeprecatedPeerConnection::ensureStreamChangeScheduled):
(WebCore::DeprecatedPeerConnection::streamChangeTimerFired):
(WebCore::DeprecatedPeerConnection::scheduleReadyStateChange):
(WebCore::DeprecatedPeerConnection::readyStateChangeTimerFired):
(WebCore::DeprecatedPeerConnection::changeReadyState):

  • Modules/mediastream/DeprecatedPeerConnection.h: Renamed from Source/WebCore/Modules/mediastream/PeerConnection.h.

(WebCore):
(DeprecatedPeerConnection):
(WebCore::DeprecatedPeerConnection::didChangeState):
(WebCore::DeprecatedPeerConnection::refEventTarget):
(WebCore::DeprecatedPeerConnection::derefEventTarget):

  • Modules/mediastream/DeprecatedPeerConnection.idl: Renamed from Source/WebCore/Modules/mediastream/PeerConnection.idl.
  • Modules/mediastream/SignalingCallback.h:

(WebCore):
(SignalingCallback):

  • Modules/mediastream/SignalingCallback.idl:
  • WebCore.gypi:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitDeprecatedPeerConnectionEnabled):

  • bindings/js/JSDeprecatedPeerConnectionCustom.cpp: Renamed from Source/WebCore/bindings/js/JSPeerConnectionCustom.cpp.

(WebCore):
(WebCore::JSDeprecatedPeerConnectionConstructor::constructJSDeprecatedPeerConnection):

  • dom/EventTarget.h:

(WebCore):

  • dom/EventTargetFactory.in:
  • platform/mediastream/DeprecatedPeerConnectionHandler.h: Renamed from Source/WebCore/platform/mediastream/PeerConnectionHandler.h.

(WebCore):
(DeprecatedPeerConnectionHandler):

  • platform/mediastream/DeprecatedPeerConnectionHandlerClient.h: Renamed from Source/WebCore/platform/mediastream/PeerConnectionHandlerClient.h.

(WebCore):
(DeprecatedPeerConnectionHandlerClient):
(WebCore::DeprecatedPeerConnectionHandlerClient::~DeprecatedPeerConnectionHandlerClient):

  • platform/mediastream/gstreamer/DeprecatedPeerConnectionHandler.cpp: Renamed from Source/WebCore/platform/mediastream/gstreamer/PeerConnectionHandler.cpp.

(WebCore):
(WebCore::DeprecatedPeerConnectionHandler::create):
(WebCore::DeprecatedPeerConnectionHandler::DeprecatedPeerConnectionHandler):
(WebCore::DeprecatedPeerConnectionHandler::~DeprecatedPeerConnectionHandler):
(WebCore::DeprecatedPeerConnectionHandler::produceInitialOffer):
(WebCore::DeprecatedPeerConnectionHandler::handleInitialOffer):
(WebCore::DeprecatedPeerConnectionHandler::processSDP):
(WebCore::DeprecatedPeerConnectionHandler::processPendingStreams):
(WebCore::DeprecatedPeerConnectionHandler::sendDataStreamMessage):
(WebCore::DeprecatedPeerConnectionHandler::stop):

Source/WebKit/chromium:

  • WebKit.gyp:
  • bridge/DeprecatedPeerConnectionHandler.cpp: Renamed from Source/WebKit/chromium/bridge/PeerConnectionHandler.cpp.

(WebCore):
(WebCore::DeprecatedPeerConnectionHandler::create):
(WebCore::DeprecatedPeerConnectionHandler::DeprecatedPeerConnectionHandler):
(WebCore::DeprecatedPeerConnectionHandler::~DeprecatedPeerConnectionHandler):
(WebCore::DeprecatedPeerConnectionHandler::produceInitialOffer):
(WebCore::DeprecatedPeerConnectionHandler::handleInitialOffer):
(WebCore::DeprecatedPeerConnectionHandler::processSDP):
(WebCore::DeprecatedPeerConnectionHandler::processPendingStreams):
(WebCore::DeprecatedPeerConnectionHandler::sendDataStreamMessage):
(WebCore::DeprecatedPeerConnectionHandler::stop):

  • bridge/DeprecatedPeerConnectionHandlerInternal.cpp: Renamed from Source/WebKit/chromium/bridge/PeerConnectionHandlerInternal.cpp.

(WebCore):
(WebCore::DeprecatedPeerConnectionHandlerInternal::DeprecatedPeerConnectionHandlerInternal):
(WebCore::DeprecatedPeerConnectionHandlerInternal::~DeprecatedPeerConnectionHandlerInternal):
(WebCore::DeprecatedPeerConnectionHandlerInternal::produceInitialOffer):
(WebCore::DeprecatedPeerConnectionHandlerInternal::handleInitialOffer):
(WebCore::DeprecatedPeerConnectionHandlerInternal::processSDP):
(WebCore::DeprecatedPeerConnectionHandlerInternal::processPendingStreams):
(WebCore::DeprecatedPeerConnectionHandlerInternal::sendDataStreamMessage):
(WebCore::DeprecatedPeerConnectionHandlerInternal::stop):
(WebCore::DeprecatedPeerConnectionHandlerInternal::didCompleteICEProcessing):
(WebCore::DeprecatedPeerConnectionHandlerInternal::didGenerateSDP):
(WebCore::DeprecatedPeerConnectionHandlerInternal::didReceiveDataStreamMessage):
(WebCore::DeprecatedPeerConnectionHandlerInternal::didAddRemoteStream):
(WebCore::DeprecatedPeerConnectionHandlerInternal::didRemoveRemoteStream):

  • bridge/DeprecatedPeerConnectionHandlerInternal.h: Renamed from Source/WebKit/chromium/bridge/PeerConnectionHandlerInternal.h.

(WebKit):
(WebCore):
(DeprecatedPeerConnectionHandlerInternal):

LayoutTests:

  • fast/dom/call-a-constructor-as-a-function.html:
  • fast/mediastream/peerconnection-Attributes-expected.txt:
  • fast/mediastream/peerconnection-addstream-expected.txt:
  • fast/mediastream/peerconnection-argument-types-expected.txt:
  • fast/mediastream/peerconnection-eventlistener-optional-argument.html:
  • fast/mediastream/peerconnection-mediastreamlist.html:
  • fast/mediastream/peerconnection-removestream-expected.txt:
  • fast/mediastream/script-tests/Attributes.js:
  • fast/mediastream/script-tests/argument-types.js:
  • fast/mediastream/script-tests/peerconnection-addstream.js:
  • fast/mediastream/script-tests/peerconnection-removestream.js:
  • platform/chromium/fast/dom/call-a-constructor-as-a-function-expected.txt:
  • platform/gtk/fast/dom/call-a-constructor-as-a-function-expected.txt:
11:49 Changeset [110586] by andersca@apple.com

Remove a nonexistent WebUIDelegate method from WebUIDelegatePrivate.h
https://bugs.webkit.org/show_bug.cgi?id=81014

Reviewed by Sam Weinig.

Remove a plug-in halter related WebUIDelegate method.

  • WebView/WebUIDelegatePrivate.h:
11:34 Changeset [110585] by ojan@chromium.org

Rebaselining for a new port doesn't work right with multiple fallback ports
https://bugs.webkit.org/show_bug.cgi?id=80932

Reviewed by Adam Barth.

Since chromium-leopard also falls back to mac-leopard, we need to
copy the existing result for both chromium-leopard and chromium-snowleopard
before doing lion rebaselines.

  • Scripts/webkitpy/layout_tests/port/builders.py:

(fallback_port_names_for_new_port):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineTest):
(RebaselineTest._copy_existing_baseline):
(RebaselineTest._rebaseline_test):
(RebaselineTest.execute):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  • Scripts/webkitpy/tool/servers/gardeningserver.py:

(GardeningHTTPRequestHandler.rebaseline):

  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:

(GardeningServerTest.test_rebaseline_new_port):

11:21 Changeset [110584] by pfeldman@chromium.org

Web Inspector: front-end compilation was broken while supporting large arrays.
https://bugs.webkit.org/show_bug.cgi?id=81013

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/ExtensionPanel.js:
  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ArrayGroupingTreeElement._populateNonIndexProperties.buildObjectFragment):

  • inspector/front-end/RemoteObject.js:
11:17 Changeset [110583] by tony@chromium.org

flexbox's computePreferredLogicalWidth needs to take multiline into account
https://bugs.webkit.org/show_bug.cgi?id=80931

Reviewed by Ojan Vafai.

Source/WebCore:

Tests: css3/flexbox/multiline-shrink-to-fit-expected.html

css3/flexbox/multiline-shrink-to-fit.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computePreferredLogicalWidths): Set min/max preferredLogicalWidth based on always breaking or never breaking.
(WebCore::RenderFlexibleBox::computeNextFlexLine): Add a FIXME.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Don't change the width after computePreferredWidth has been called.

LayoutTests:

  • css3/flexbox/cross-axis-scrollbar.html:
  • css3/flexbox/multiline-align.html:
  • css3/flexbox/multiline-pack.html:
  • css3/flexbox/multiline-shrink-to-fit-expected.html: Added.
  • css3/flexbox/multiline-shrink-to-fit.html: Added.
  • css3/flexbox/multiline.html:
11:10 Changeset [110582] by commit-queue@webkit.org

Remove SlotVisitor::copy() method.
https://bugs.webkit.org/show_bug.cgi?id=80973

Patch by Kwonjin Jeong <gram@company100.net> on 2012-03-13
Reviewed by Geoffrey Garen.

SlotVisitor::copy() method isn't called anywhere.

  • heap/MarkStack.cpp: Remove definition of SlotVisitor::copy() method.
  • heap/SlotVisitor.h: Remove declaration of SlotVisitor::copy() method.
11:05 Changeset [110581] by commit-queue@webkit.org

Unreviewed, rolling out r110469.
http://trac.webkit.org/changeset/110469
https://bugs.webkit.org/show_bug.cgi?id=81010

This patch still appears to crash (Requested by abarth on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-13

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::repaintContentRectangle):
(WebCore):
(WebCore::FrameView::endDeferredRepaints):
(WebCore::FrameView::doDeferredRepaints):
(WebCore::FrameView::deferredRepaintTimerFired):

  • page/FrameView.h:

(FrameView):

  • rendering/RenderView.cpp:

(WebCore::RenderView::shouldRepaint):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawSVGToImageBuffer):
(WebCore::SVGImage::draw):

  • svg/graphics/SVGImage.h:
  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::imageContentChanged):
(WebCore::SVGImageCache::redrawTimerFired):

  • svg/graphics/SVGImageCache.h:

(SVGImageCache):

11:02 Changeset [110580] by commit-queue@webkit.org

Add a method to window.internals to enable testing of inspector highlight rects
https://bugs.webkit.org/show_bug.cgi?id=80338

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-03-13
Reviewed by Pavel Feldman.

.:

  • Source/autotools/symbols.filter: Export symbols for GTK.

Source/WebCore:

Add window.internals.inspectorHighlightRects, a method which makes it possible to test the
positions and sizes of inspector highlight rects.

Test: inspector/elements/highlight-node.html

  • WebCore.exp.in: Export symbols.
  • testing/Internals.cpp:

(WebCore::Internals::inspectorHighlightRects): Call InspectorController::getHighlight and
return the highlight's quads as a ClientRectList.
(WebCore):

  • testing/Internals.h:

(WebCore):
(Internals):

  • testing/Internals.idl:

Add inspectorHighlightRects to the window.internals interface.

Source/WebKit2:

  • win/WebKit2.def: Export symbols for win.
  • win/WebKit2CFLite.def: Same as above.

LayoutTests:

  • inspector/elements/highlight-node-expected.txt: Added.
  • inspector/elements/highlight-node.html: Added.
10:57 Changeset [110579] by mitz@apple.com

Working With Code > Installing Developer Tools needs to be updated with OS X Lion & App Store details
https://bugs.webkit.org/show_bug.cgi?id=80429

Patch by Rebecca Hauck <rhauck@adobe.com> on 2012-03-13
Reviewed by Dan Bernstein.

  • building/tools.html:
10:30 Changeset [110578] by commit-queue@webkit.org

[BlackBerry] Remove sublayers before clamping just in case the layer already exists
https://bugs.webkit.org/show_bug.cgi?id=80989

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-03-13
Reviewed by Antonio Gomes.

Discovered when trying to add a highlight sublayer for web inspector. Since that layer
may already exist in the tree we need to see if it will be pruned before we clamp on the
size.

This was manually tested during the writing of another patch to add web inspector highlights
to accelrated compositing.

  • platform/graphics/blackberry/LayerWebKitThread.cpp:

(WebCore::LayerWebKitThread::insertSublayer):

10:25 Changeset [110577] by abarth@webkit.org

Note that fast/loader/window-properties-restored-from-page-cache.html
depends on the page cache.

  • platform/chromium/test_expectations.txt:
09:37 Changeset [110576] by vsevik@chromium.org

Web Inspector: Add snippets model.
https://bugs.webkit.org/show_bug.cgi?id=80863

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/debugger/snippets-model.html

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/SnippetsModel.js: Added.
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

LayoutTests:

  • inspector/debugger/snippets-model-expected.txt: Added.
  • inspector/debugger/snippets-model.html: Added.
09:33 Changeset [110575] by vestbo@webkit.org

[Qt] Tweak minibrowser UI

Add some margins to the scroll indicators, and set a dark background
color so you see the page dimensions.

Reviewed by Antonio Gomes.

09:11 Changeset [110574] by zimmermann@webkit.org

[Qt] svg/animations tests are very flaky
https://bugs.webkit.org/show_bug.cgi?id=80703

Reviewed by Rob Buis.

Overhaul the svg/animation frameworks, to be more stable.
Especially discrete animations were flaky on Qt, because some tests still sampled
at integral times like 2.0s, instead of 1.999s (before change), and 2.001s (after change).

Always use shouldBeCloseEnough() when comparing font-sizes/color values/, as there's
always an uncertainity about the actual sampling time (low but may lead to 40.01px values, instead of 40px).

This makes these tests also stable in Firefox/Opera, which was the ultimate goal!

  • platform/qt/Skipped: Unskip svg/animation tests.
  • svg/animations/additive-values-width-animation-expected.txt:
  • svg/animations/animate-color-calcMode-discrete-expected.txt:
  • svg/animations/animate-color-fill-currentColor-expected.txt:
  • svg/animations/animate-color-fill-from-by-expected.txt:
  • svg/animations/animate-color-rgba-calcMode-discrete-expected.txt:
  • svg/animations/animate-color-transparent-expected.txt:
  • svg/animations/animate-currentColor-expected.txt:
  • svg/animations/animate-dynamic-update-attributeName-expected.txt:
  • svg/animations/animate-elem-03-t-drt-expected.txt:
  • svg/animations/animate-end-attribute-expected.txt:
  • svg/animations/animate-from-to-keyTimes-expected.txt:
  • svg/animations/animate-inherit-css-property-expected.txt:
  • svg/animations/animate-keySplines-expected.txt:
  • svg/animations/animate-number-calcMode-discrete-expected.txt:
  • svg/animations/animate-number-calcMode-discrete-keyTimes-expected.txt:
  • svg/animations/attributeTypes-expected.txt:
  • svg/animations/resources/SVGAnimationTestCase.js:

(expectColor):
(expectFillColor):
(moveAnimationTimelineAndSample):

  • svg/animations/script-tests/additive-values-width-animation.js:

(executeTest):

  • svg/animations/script-tests/animVal-basics.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/animate-calcMode-spline-by.js:

(sample1):
(executeTest):

  • svg/animations/script-tests/animate-calcMode-spline-from-by.js:

(sample1):
(executeTest):

  • svg/animations/script-tests/animate-calcMode-spline-from-to.js:

(sample1):
(executeTest):

  • svg/animations/script-tests/animate-calcMode-spline-to.js:

(sample1):
(executeTest):

  • svg/animations/script-tests/animate-calcMode-spline-values.js:

(sample1):
(executeTest):

  • svg/animations/script-tests/animate-color-calcMode-discrete.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/animate-color-fill-currentColor.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/animate-color-fill-from-by.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/animate-color-rgba-calcMode-discrete.js:

(parseAlphaFromColor):
(red):

  • svg/animations/script-tests/animate-color-transparent.js:

(expectTransparent):
(expectOtherColor):

  • svg/animations/script-tests/animate-currentColor.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/animate-dynamic-update-attributeName.js:

(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):

  • svg/animations/script-tests/animate-elem-03-t-drt.js:

(parseFontSizeFromString):
(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/animate-end-attribute.js:

(sample1):
(sample2):

  • svg/animations/script-tests/animate-endElement-beginElement.js:

(sample1):

  • svg/animations/script-tests/animate-from-to-keyTimes.js:
  • svg/animations/script-tests/animate-gradient-transform.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/animate-inherit-css-property.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/animate-insert-begin.js:

(sample1):
(sample2):

  • svg/animations/script-tests/animate-insert-no-begin.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/animate-keySplines.js:

(sample3):
(sample4):
(executeTest):

  • svg/animations/script-tests/animate-number-calcMode-discrete-keyTimes.js:

(executeTest):

  • svg/animations/script-tests/animate-number-calcMode-discrete.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/animate-path-animation-Cc-Ss.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/animate-path-animation-Ll-Vv-Hh.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/animate-path-animation-Qq-Tt.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/animate-path-animation-cC-sS-inverse.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/animate-path-animation-lL-vV-hH-inverse.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/animate-path-animation-qQ-tT-inverse.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/animate-path-to-animation.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/animateTransform-pattern-transform.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/attributeTypes.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/multiple-animations-fill-freeze.js:

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(sample6):
(sample7):
(sample8):

  • svg/animations/script-tests/svgPreserveAspectRatio-animation-1.js:

(executeTest):

  • svg/animations/script-tests/svgangle-animation-deg-to-grad.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgangle-animation-deg-to-rad.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgangle-animation-grad-to-deg.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgangle-animation-grad-to-rad.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgangle-animation-rad-to-deg.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgangle-animation-rad-to-grad.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgboolean-animation-1.js:

(executeTest):

  • svg/animations/script-tests/svginteger-animation-1.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglength-animation-LengthModeHeight.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglength-animation-LengthModeOther.js:

(sample1):
(executeTest):

  • svg/animations/script-tests/svglength-animation-LengthModeWidth.js:

(sample1):
(executeTest):

  • svg/animations/script-tests/svglength-animation-invalid-value-1.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglength-animation-invalid-value-2.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglength-animation-invalid-value-3.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglength-animation-number-to-number.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglength-animation-px-to-cm.js:

(sample1):
(executeTest):

  • svg/animations/script-tests/svglength-animation-px-to-ems.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglength-animation-px-to-exs.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglength-animation-px-to-in.js:

(sample1):
(executeTest):

  • svg/animations/script-tests/svglength-animation-px-to-number.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglength-animation-px-to-pc.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglength-animation-px-to-percentage.js:

(sample1):
(executeTest):

  • svg/animations/script-tests/svglength-animation-px-to-pt.js:

(sample1):
(executeTest):

  • svg/animations/script-tests/svglength-animation-px-to-px.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglength-animation-unitType.js:

(executeTest):

  • svg/animations/script-tests/svglength-animation-values.js:

(sample1):
(sample2):
(sample4):
(executeTest):

  • svg/animations/script-tests/svglengthlist-animation-1.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglengthlist-animation-2.js:

(sample1):
(executeTest):

  • svg/animations/script-tests/svglengthlist-animation-3.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglengthlist-animation-4.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svglengthlist-animation-5.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgnumber-animation-1.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/svgnumber-animation-2.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/svgnumber-animation-3.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/svgnumberlist-animation-1.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgnumberlist-animation-2.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgnumberoptionalnumber-animation-1.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgnumberoptionalnumber-animation-2.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgnumberoptionalnumber-animation-3.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgnumberoptionalnumber-animation-4.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgpath-animation-1.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgpointlist-animation-1.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/svgpointlist-animation-2.js:

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/svgrect-animation-1.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgrect-animation-2.js:

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgstring-animation-fallback-to-discrete.js:

(executeTest):

  • svg/animations/script-tests/svgtransform-animation-1.js:

(sample1):
(sample2):

  • svg/animations/script-tests/svgtransform-animation-discrete.js:

(sample1):
(executeTest):

  • svg/animations/svglength-animation-invalid-value-1-expected.txt:
  • svg/animations/svglength-animation-invalid-value-2-expected.txt:
  • svg/animations/svglength-animation-invalid-value-3-expected.txt:
  • svg/animations/svglength-animation-unitType-expected.txt:
  • svg/animations/svgnumber-animation-1-expected.txt:
  • svg/animations/svgnumber-animation-2-expected.txt:
  • svg/animations/svgnumber-animation-3-expected.txt:
  • svg/animations/svgtransform-animation-discrete-expected.txt:
09:08 Changeset [110573] by pfeldman@chromium.org

Not reviewed: chromium build fix.

  • history/CachedFrame.cpp:
09:03 Changeset [110572] by commit-queue@webkit.org

Web Inspector: CodeGeneratorInspector.py: refactor copy-paste getter methods
https://bugs.webkit.org/show_bug.cgi?id=80923

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-03-13
Reviewed by Yury Semikhatsky.

Several methods are combined in one using C++ templates.

  • inspector/CodeGeneratorInspector.py:
09:00 Changeset [110571] by rwlbuis@webkit.org

[BlackBerry] Fix cast-align warning in QuotesData.cpp
https://bugs.webkit.org/show_bug.cgi?id=80601

Reviewed by Nikolas Zimmermann.

Fix warning by adding variable of correct return type.

  • rendering/style/QuotesData.cpp:

(WebCore::QuotesData::create):

08:57 Changeset [110570] by beidson@apple.com

<rdar://problem/7908830> and https://bugs.webkit.org/show_bug.cgi?id=34679 Location and other objects are dysfunctional after a document gets restored from page cache

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/loader/window-properties-restored-from-page-cache.html

Give DOMWindowProperties the ability to reconnect to their Frame:

  • page/DOMWindowProperty.cpp:

(WebCore::DOMWindowProperty::reconnectFrame):

  • page/DOMWindowProperty.h:

(DOMWindowProperty):

Let ApplicationCache do some extra work when reconnecting:

  • loader/appcache/DOMApplicationCache.cpp:

(WebCore::DOMApplicationCache::reconnectFrame):
(WebCore):

  • loader/appcache/DOMApplicationCache.h:

(DOMApplicationCache):

Let IndexDB do some extra work when reconnecting:

  • Modules/indexeddb/DOMWindowIndexedDatabase.cpp:

(WebCore::DOMWindowIndexedDatabase::disconnectFrame):
(WebCore::DOMWindowIndexedDatabase::reconnectFrame):
(WebCore::DOMWindowIndexedDatabase::webkitIndexedDB):

  • Modules/indexeddb/DOMWindowIndexedDatabase.h:

(DOMWindowIndexedDatabase):

Tell the DOMWindow to suspend to the page cache:

  • history/CachedFrame.cpp:

(WebCore::CachedFrame::CachedFrame):

Tell the DOMWindow to resume from the page cache:

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::open):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::DOMWindow):
(WebCore::DOMWindow::~DOMWindow): Call clearDOMWindowProperties directly instead of clear()
(WebCore::DOMWindow::frameDestroyed): Ditto.
(WebCore::DOMWindow::clear): Only clear if the DOMWindow is not suspended for the page cache.
(WebCore::DOMWindow::suspendForPageCache): Disconnect properties and set the page cache flag.
(WebCore::DOMWindow::resumeFromPageCache): Reconnect properties and revert the page cache flag.
(WebCore::DOMWindow::disconnectDOMWindowProperties): Only disconnect the registered properties.
(WebCore::DOMWindow::reconnectDOMWindowProperties):
(WebCore::DOMWindow::clearDOMWindowProperties): Disconnect the registered properties then clear them out.

For all of the following, if the DOMWindow is not displayed in a frame (i.e., it is suspended), do nothing:
(WebCore::DOMWindow::screen):
(WebCore::DOMWindow::history):
(WebCore::DOMWindow::crypto):
(WebCore::DOMWindow::locationbar):
(WebCore::DOMWindow::menubar):
(WebCore::DOMWindow::personalbar):
(WebCore::DOMWindow::scrollbars):
(WebCore::DOMWindow::statusbar):
(WebCore::DOMWindow::toolbar):
(WebCore::DOMWindow::console):
(WebCore::DOMWindow::applicationCache):
(WebCore::DOMWindow::navigator):
(WebCore::DOMWindow::performance):
(WebCore::DOMWindow::location):
(WebCore::DOMWindow::sessionStorage):
(WebCore::DOMWindow::localStorage):
(WebCore::DOMWindow::webkitNotifications):
(WebCore::DOMWindow::postMessageTimerFired):
(WebCore::DOMWindow::getSelection):
(WebCore::DOMWindow::styleMedia):
(WebCore::DOMWindow::webkitStorageInfo):

  • page/DOMWindow.h:

LayoutTests:

  • fast/loader/window-properties-restored-from-page-cache-expected.txt: Added.
  • fast/loader/window-properties-restored-from-page-cache.html: Added.
08:43 Changeset [110569] by commit-queue@webkit.org

[chromium] Use projectQuad to apply inverse mapRect
https://bugs.webkit.org/show_bug.cgi?id=80741

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-13
Reviewed by Adrienne Walker.

Source/WebCore:

Unit test: CCOcclusionTrackerTest3dTransform

CCOcclusionTrackerTestPerspectiveTransform
CCOcclusionTrackerTestPerspectiveTransformBehindCamera

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::projectQuad):
(WebCore):
(WebCore::computeUnoccludedContentRect):

Source/WebKit/chromium:

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore):
(CCOcclusionTrackerTest3dTransform):
(WebCore::CCOcclusionTrackerTest3dTransform::runMyTest):
(CCOcclusionTrackerTestPerspectiveTransform):
(WebCore::CCOcclusionTrackerTestPerspectiveTransform::runMyTest):
(CCOcclusionTrackerTestPerspectiveTransformBehindCamera):
(WebCore::CCOcclusionTrackerTestPerspectiveTransformBehindCamera::runMyTest):

08:40 Changeset [110568] by commit-queue@webkit.org

[EFL] [DRT] Implement scheduleAsynchronousKeyDown.
https://bugs.webkit.org/show_bug.cgi?id=79601

Patch by ChangSeok Oh <shivamidow@gmail.com> on 2012-03-13
Reviewed by Gustavo Noronha Silva.

Source/WebKit/efl:

Added a new API to deliver all mutations explicitly.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::deliverAllMutationsIfNecessary):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Extracted shareable code from keyDownCallback and then added createKeyEventInfo.
createKeyEventInfo creates a new structure KeyEventInfo that has keyName and modifiers
and is taken over to sendKeyDown.
Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.

  • DumpRenderTree/efl/EventSender.cpp:

(KeyEventInfo::KeyEventInfo):
(KeyEventInfo):
(createKeyEventInfo):
(sendKeyDown):
(keyDownCallback):
(sendAsynchronousKeyDown):
(scheduleAsynchronousKeyDownCallback):

LayoutTests:

Removed following two skipped tests.
fast/mutation/end-of-task-delivery.html
fast/mutation/inline-event-listener.html

  • platform/efl/Skipped:
08:28 Changeset [110567] by gavinp@chromium.org

New PageCache histogram which counts failures ignoring Settings.
https://bugs.webkit.org/show_bug.cgi?id=80864

Reviewed by Brady Eidson.

Chrome has a command line switch to turn on the page cache.
Currently it doesn't work, but it can cause the PageCache reasons
for failure count to read lower than it should. Add a new
histogram to report the corrected value.

  • history/PageCache.cpp:

(WebCore::logCanCachePageDecision):

08:24 Changeset [110566] by staikos@webkit.org

Fix signed/unsigned mismatch compiler warnings.
https://bugs.webkit.org/show_bug.cgi?id=80790

Reviewed by Alexey Proskuryakov.

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::synchronousLoadDecisionForIconURL):

  • platform/network/MIMESniffing.cpp:
08:21 Changeset [110565] by commit-queue@webkit.org

Unreviewed, rolling out r110510.
http://trac.webkit.org/changeset/110510
https://bugs.webkit.org/show_bug.cgi?id=80987

depends on chromium r 125700, which isn't rolled into webkit
yet :-/ (Requested by thakis_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-13

  • WebCore.gyp/mac/adjust_visibility.sh:
08:18 Changeset [110564] by gavinp@chromium.org

Make ApplicationCacheHost::canCacheInPageCache() non-const.
https://bugs.webkit.org/show_bug.cgi?id=80904

Reviewed by Alexey Proskuryakov.

A const pointer to a large object like ApplicationCacheHost is not our standard
practice; so remove this (implicit) one. See also https://bugs.webkit.org/show_bug.cgi?id=80898

Source/WebCore:

  • loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::canCacheInPageCache):

  • loader/appcache/ApplicationCacheHost.h:

(ApplicationCacheHost):

Source/WebKit/chromium:

  • src/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::canCacheInPageCache):

08:14 Changeset [110563] by schenney@chromium.org

Crash in WebCore::GraphicsContext::paintingDisabled
https://bugs.webkit.org/show_bug.cgi?id=80669

Reviewed by Nikolas Zimmermann.

Source/WebCore:

The SVGImageBufferTools::clipToImageBuffer method deletes the clip
image when it thinks it is not needed. However, there are cases when
it is in fact still needed, particularly when the clip buffer is
coming from higher up in the stack where it may be needed again.

So this patch adds a flag to only allow deletion of the image buffer
if it was created at the most recent call site.

Tests: svg/custom/circular-clip-path-references-crash-expected.svg

svg/custom/circular-clip-path-references-crash.svg

  • rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::applyClippingToContext):

  • rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::clipToTextMask):

  • rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::applyResource):

  • rendering/svg/SVGImageBufferTools.cpp:

(WebCore::SVGImageBufferTools::clipToImageBuffer):

  • rendering/svg/SVGImageBufferTools.h:

(SVGImageBufferTools):

LayoutTests:

  • svg/custom/circular-clip-path-references-crash-expected.svg: Added.
  • svg/custom/circular-clip-path-references-crash.svg: Added.
08:02 Changeset [110562] by commit-queue@webkit.org

Remove ActiveNodeContext in favour of BlackBerry::Platform::WebContext
https://bugs.webkit.org/show_bug.cgi?id=80984

Remove ActiveNodeContext, and switch the implementation to
provide a BlackBerry::Platform::WebContext. The new object
adds an explicit IsImage flag, as well as IsAudio and IsVideo
for the HTML5 elements.

Note that for many videos both IsVideo and IsAudio will be true,
as videos typically have audio streams as well.

Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-03-13
Reviewed by George Staikos.

  • Api/ActiveNodeContext.h: Removed.
  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPage::webContext):

  • Api/WebPage.h:
  • Api/WebPage_p.h:
07:57 Changeset [110561] by gavinp@chromium.org

Fix an enumeration name in ReasonsFrameCannotBeInPageCache.
https://bugs.webkit.org/show_bug.cgi?id=80849

Reviewed by Brady Eidson.

It seems that somebody goofed, and named one of the
ReasonsFrameCannotBeInPageCache antonymically.

  • history/PageCache.cpp:

(WebCore::logCanCacheFrameDecision):

07:38 Changeset [110560] by kinuko@chromium.org

File upload control should use File.name() rather than File.path() to show chosen filenames
https://bugs.webkit.org/show_bug.cgi?id=80970

In some rare cases (e.g. files from FileSystem API or files created
using the newly added WebKit API) File.name has different displayName
from the basename of file.path, and in the file uploader controller we
should use File.name rather than File.path.

Reviewed by Kent Tamura.

No new tests: existing tests should pass as this should not change
behavior in regular use cases. (New behavior where File.name differs
from File.path can be only tested in chromeos environment, therefore
not adding new tests for that)

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::fileListNameForWidth): Updated to handle FileList.

  • platform/gtk/RenderThemeGtk.h:
  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::fileListNameForWidth): Updated to handle FileList.

  • platform/qt/RenderThemeQt.h:
  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::fileTextValue): Changed to pass FileList rather than FileList->paths().

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::fileListNameForWidth): Updated to handle FileList and use File.name for displaying the file name.

  • rendering/RenderTheme.h:
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::fileListNameForWidth): Updated to handle FileList.

07:09 Changeset [110559] by haraken@chromium.org

Dromaeo perf-tests results are wrong
https://bugs.webkit.org/show_bug.cgi?id=80974

Reviewed by Hajime Morita.

Dromaeo perf-tests had reported the sum of runs/seconds as "ms".
This patch fixes them to report the execution time per run.

At present, they report "0.0ms" for "stdev". This is because
dromaeorunner.js can just know stdev of "runs/seconds"
and cannot calculate stdev of "ms" from that. We can fix it later.

  • Dromaeo/resources/dromaeorunner.js:

(.):

07:09 Changeset [110558] by ossy@webkit.org

[Qt] Skip some tests until fix.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-03-13
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
07:06 Changeset [110557] by kinuko@chromium.org

Allow WebFileChooser to return extra file info (like displayName) in addition to mere file paths
https://bugs.webkit.org/show_bug.cgi?id=80719

Reviewed by Kent Tamura.

Source/WebCore:

No new tests: this change itself shouldn't change existing behavior.

  • fileapi/File.cpp:

(WebCore::createBlobDataForFileWithName): Renamed from createBlobDataForFileSystemFile.

  • fileapi/File.h:
  • html/FileInputType.cpp:

(WebCore::FileInputType::saveFormControlState): Updated to handle File.name.
(WebCore::FileInputType::restoreFormControlState): Ditto.
(WebCore::FileInputType::setFileList): Changed the signature to take
FileChooserFileInfo.
(WebCore::FileInputType::filesChosen): Ditto.
(WebCore::FileInputType::receiveDroppedFiles):

  • html/FileInputType.h:

(FileInputType):

  • platform/FileChooser.cpp:

(WebCore::FileChooser::chooseFiles): Added an overloaded method that
takes FileChooserFileInfo.
(WebCore):

  • platform/FileChooser.h:

(WebCore::FileChooserFileInfo::FileChooserFileInfo): Added.

  • platform/MIMETypeRegistry.cpp:

(WebCore::MIMETypeRegistry::getWellKnownMIMETypeForExtension): Removed surrouonding ifdefs as this function is now used even if FILE_SYSTEM is not enabled.

  • platform/MIMETypeRegistry.h:

(MIMETypeRegistry):

Source/WebKit/chromium:

  • public/WebFileChooserCompletion.h:

(SelectedFileInfo): Added.
(WebFileChooserCompletion):
(WebKit::WebFileChooserCompletion::didChooseFile): Added an overloaded
method that takes SelectedFileInfo.

  • src/WebFileChooserCompletionImpl.cpp:

(WebKit::WebFileChooserCompletionImpl::didChooseFile): Ditto.
(WebKit):

  • src/WebFileChooserCompletionImpl.h:

(WebFileChooserCompletionImpl):

05:38 Changeset [110556] by commit-queue@webkit.org

[EFL] Remove a duplicate allocation of matrix entry.
https://bugs.webkit.org/show_bug.cgi?id=79362

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2012-03-13
Reviewed by Zoltan Herczeg.

A matrix entry is created when calling ewk_matrix_new.
Another matrix is created inside ewk_tile_matrix_zoom_level_set.
This patch is for getting rid of a duplicated creation of the matrix.

  • ewk/ewk_tiled_backing_store.cpp:

(_Ewk_Tiled_Backing_Store_Item):
(_ewk_tiled_backing_store_zoom_set_internal):

  • ewk/ewk_tiled_matrix.cpp:

(ewk_tile_matrix_new):
(ewk_tile_matrix_zoom_level_set):
(ewk_tile_matrix_entry_new):
(ewk_tile_matrix_size_get):

  • ewk/ewk_tiled_matrix.h:
05:28 Changeset [110555] by morrita@google.com

Unreviewed, skipping some more failing tests.

  • platform/chromium/test_expectations.txt:
05:25 Changeset [110554] by vsevik@chromium.org

Unreviewed inspector compilation module name fix after r110550.

  • inspector/compile-front-end.py:
05:24 Changeset [110553] by commit-queue@webkit.org

[Qt] Set correct device width and height.
https://bugs.webkit.org/show_bug.cgi?id=80980

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-13
Reviewed by Tor Arne Vestbø.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewFlickablePrivate::computeViewportConstraints):

03:00 Changeset [110552] by philn@webkit.org

Unreviewed, skip new failing test on GTK.

  • platform/gtk/Skipped:
02:57 Changeset [110551] by morrita@google.com

Unreviewed, marking a test as fail which needs reaseline.

  • platform/chromium/test_expectations.txt:
02:47 Changeset [110550] by vsevik@chromium.org

Web Inspector: Changes to the list of scripts for front-end compilation should not require update of number of scripts in module.
https://bugs.webkit.org/show_bug.cgi?id=80872

Reviewed by Pavel Feldman.

  • inspector/compile-front-end.py: Added.
  • inspector/compile-front-end.sh:
02:10 Changeset [110549] by podivilov@chromium.org

Web Inspector: move ResourceScriptMapping to a separate file.
https://bugs.webkit.org/show_bug.cgi?id=80859

Reviewed by Vsevolod Vlasov.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.sh:
  • inspector/front-end/ResourceScriptMapping.js: Copied from Source/WebCore/inspector/front-end/ScriptMapping.js.

(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype.uiSourceCodeList):
(WebInspector.ResourceScriptMapping.prototype._handleUISourceCodeListChanged):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeListChanged):
(WebInspector.ResourceScriptMapping.prototype._bindScriptToRawSourceCode):
(WebInspector.ResourceScriptMapping.prototype.setFormatSource):
(WebInspector.ResourceScriptMapping.prototype.forceUpdateSourceMapping):
(WebInspector.ResourceScriptMapping.prototype.reset):

  • inspector/front-end/ScriptMapping.js:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
01:56 Changeset [110548] by morrita@google.com

Unreviewed, skipping some failing tests.

  • platform/chromium/test_expectations.txt:
01:48 Changeset [110547] by haraken@chromium.org

Rename OptionsObject to Dictionary
https://bugs.webkit.org/show_bug.cgi?id=80802

Reviewed by Adam Barth.

For clarification, rename OptionsObject.{h,cpp} to Dictionary.{h,cpp}.
This patch just renames and sorts alphabetically.

No tests. No change in behavior.

  • GNUmakefile.list.am:
  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::createObjectStore):

  • Modules/indexeddb/IDBDatabase.h:

(WebCore::IDBDatabase::createObjectStore):
(IDBDatabase):

  • Modules/indexeddb/IDBDatabase.idl:
  • Modules/indexeddb/IDBKeyRange.h:
  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::createIndex):

  • Modules/indexeddb/IDBObjectStore.h:

(WebCore::IDBObjectStore::createIndex):
(IDBObjectStore):

  • Modules/indexeddb/IDBObjectStore.idl:
  • Target.pri:
  • UseV8.cmake:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • bindings/js/Dictionary.h: Renamed from Source/WebCore/bindings/js/OptionsObject.h.

(WebCore):
(Dictionary):
(WebCore::Dictionary::Dictionary):
(WebCore::Dictionary::isObject):
(WebCore::Dictionary::isUndefinedOrNull):
(WebCore::Dictionary::get):
(WebCore::Dictionary::getWithUndefinedOrNullCheck):

  • bindings/js/IDBBindingUtilities.cpp:

(WebCore::createDictionaryFromValue):

  • bindings/js/IDBBindingUtilities.h:

(WebCore):

  • bindings/scripts/CodeGeneratorJS.pm:

(JSValueToNative):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateParametersCheck):
(GenerateEventConstructorCallback):
(GetNativeType):
(JSValueToNative):

  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:

(WebDOMTestObj::optionsObject):

  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_options_object):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionIdbKey):
(WebCore::jsTestObjPrototypeFunctionOptionsObject):

  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj optionsObject:ooo:]):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::constructorCallback):
(WebCore::fillTestEventConstructorInit):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::optionsObjectCallback):

  • bindings/v8/Dictionary.cpp: Renamed from Source/WebCore/bindings/v8/OptionsObject.cpp.

(WebCore):
(WebCore::Dictionary::Dictionary):
(WebCore::Dictionary::~Dictionary):
(WebCore::Dictionary::operator=):
(WebCore::Dictionary::isObject):
(WebCore::Dictionary::isUndefinedOrNull):
(WebCore::Dictionary::getKey):
(WebCore::Dictionary::get):
(WebCore::Dictionary::getWithUndefinedOrNullCheck):

  • bindings/v8/Dictionary.h: Renamed from Source/WebCore/bindings/v8/OptionsObject.h.

(WebCore):
(Dictionary):

  • bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:

(WebCore::V8WebKitMutationObserver::observeCallback):

01:38 Changeset [110546] by shinyak@chromium.org

REGRESSION: Spellcheck tests hit assertions on Mac.
https://bugs.webkit.org/show_bug.cgi?id=80883

Reviewed by Ryosuke Niwa.

Source/WebKit/mac:

The bug was caused by the closure object created in requestCheckingOfString accessing
request's member variables even though the request object is not an NSObject or allocated
in stack. This resulted in the closure not being able to access those variables when invoked.

Fixed the bug by making local copies of those member variables.

  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::requestCheckingOfString):

LayoutTests:

Some words used in spellcheck-paste.js are considered as correct spellings in Mac's spellchecker.
This patch changes them into 'zz' so that Mac's spellchecker can make them as misspelling.

  • editing/spelling/script-tests/spellcheck-paste.js:

(pasteAndVerify.trial):
(pasteAndVerify):
(tests):

  • editing/spelling/spellcheck-paste-expected.txt:
01:27 Changeset [110545] by zimmermann@webkit.org

SVG Animations update baseVal instead of animVal
https://bugs.webkit.org/show_bug.cgi?id=12437

Reviewed by Dirk Schulze.

Source/WebCore:

Begin implementing the last missing core piece of the SVG DOM: proper animVal support.
Most SVG DOM interfaces exposing eg. lengths use SVGAnimatedLength. eg. from SVGRectElement:
"readonly attribute SVGAnimatedLength x;" SVGAnimatedXXX contains following methods:
"readonly attribute SVGLength baseVal; readonly attribute SVGLength animVal;"
From SVG DOM perspective, animVal and baseVal are two distinctive objects, animVal != baseVal.
Its underlying value is the same though, if no animation is running on that attribute.

As soon as a SMIL animation starts animating an SVGAnimated* target attribute, its
baseVal and animVal may begin to differ. The animVal always reflect the current animated
value (including all effects of additive/accumulated animations) which is shown on screen
when eg animating the width of a <rect>. The baseVal is is equal to the underlying XML
property value / SVG DOM value, but may be influenced through dynamic changes.
(Consider changing rect1.width.baseVal.value while 'width' is animated)

During the last year we prepared our animation code to turn on animVal support.
This patch adds the last missing pieces to turn on animVal support for the SVGLength.
SVGLengthList and all other types will follow, one after the other.

I've decided to write an exhaustive ChangeLog, as this as the base for any future
work in this area - hopefully making this more reviewable.

Tests: svg/animations/additive-from-to-width-animation.html

svg/animations/additive-values-width-animation.html
svg/animations/change-baseVal-while-animating-fill-freeze-2.html
svg/animations/change-baseVal-while-animating-fill-freeze.html
svg/animations/change-baseVal-while-animating-fill-remove-2.html
svg/animations/change-baseVal-while-animating-fill-remove.html
svg/animations/change-target-while-animating-SVG-property.html
svg/animations/multiple-animations-fill-freeze.html
svg/animations/remove-animation-element-while-animation-is-running.html
svg/repaint/repainting-after-animation-element-removal.svg

  • svg/SVGAnimateElement.cpp: Remove unnecessary std namespace inclusion.

(WebCore::SVGAnimateElement::SVGAnimateElement): Remove now-obsolete m_aboutToStopAnimation.
(WebCore::SVGAnimateElement::calculateAnimatedValue): Swap assertion order, to test hasTagName() _before_ casting.
(WebCore::SVGAnimateElement::resetToBaseValue):

Stop relying on the cached baseValue (breaking additive="sum"+values animation) for SVG DOM primitive animations.
Avoid any string roundtrips previously needed to reset the SVGAnimatedType to the base value. Just grab the
currentBaseValue() from the associated SVGAnimatedProperty, which includes all dynamic changes to the baseVal
either by SVG DOM or setAttribute() calls - this way we don't need to utilize the buggy cache in SMILTimeContainer,
which can be removed once all SVG DOM primitive types switched to the new animVal concept.

NOTE: When multiple animations of the same attribute are applied to a target element, resetToBaseValue() will be called
for the highest priority SVGSMILElement, on every animation step! Consider two <animate> elements, applied to a target
<rect> which both animate the 'x' attribute, one from 0s to 2s, the other from 4s to 6s. The last <animate> element
will reuse the SVGAnimatedType m_animatedType from the first <animate> element, and never create an own m_animatedType.
When the animation starts the first time at 0s, we update the rect.x.animVals SVGLength* pointer, to point to the
SVGAnimatedType of the first <animate> element, owning the m_animatedType. From that point on each call to rect.x.animVal
will always return the same value as the SVGAnimatedType of the first <animate> element holds. Now after 2s the first
<animate> element becomes inactive, but its m_animatedType remains alive. The bindings don't notice this change at all.
Now at 4s, the second animation element gets active. It reuses the SVGAnimatedType of the first <animate> element, and
applies its animation changes to that SVGAnimatedType, which is immediately reflected in the bindings w/o any additional
work. It's very important for the understanding when animationStarted/animationEnded need to be called.

(WebCore::SVGAnimateElement::applyResultsToTarget): Remove now-obsolete m_aboutToStopAnimation logic. No need to know it at this point.
(WebCore::SVGAnimateElement::targetElementWillChange):

Renamed from targetElementDidChange(). This method is called from SVGSMILElement for following conditions:

  • animation element is destructed
  • animation element is removed from document
  • target element of animation is destructed
  • target element of animation is removed from document
  • target element of animation changes id

Whenever any of this happens, we need to reset the animVal. Resetting the animVal involves resetting the PropertyType* pointer,
eg. SVGLength*, from the animVal property tear off, belonging to a certain SVGAnimatedProperty (eg. rect.x) to the initial
value again, which is the 'm_x' of the SVGRectElement. This is needed as the SVGAnimatedType the animVal currently points to,
if an animation is/was running, is destructed in targetElementWillChange(), to reset the SVGAnimateElement to the initial
state before it received a target. This is the only place which destructed the m_animatedType, and thus the only place that
needs to take care of resetting the animVal pointers.

  • svg/SVGAnimatedLength.cpp:

(WebCore::SVGAnimatedLengthAnimator::constructFromCopy):

Add a new constructFromCopy(SVGGenericAnimatedType) function to SVGAnimatedLengthAnimator.
It takes a type-unsafe SVGGenericAnimatedType - the caller has to guarantee the type matches.
This is strictly enforced for the single caller of constructFromCopy, and guaranteed to be safe.

  • svg/SVGAnimatedLength.h: Add new constructFromCopy method, which is used to avoid string-roundtrips when resetting to base values.
  • svg/SVGAnimatedType.cpp:

(WebCore::SVGAnimatedType::supportsAnimVal): Only returns true for AnimatedLength, for now.
(WebCore::SVGAnimatedType::setVariantValue): Takes a SVGGenericAnimatedType, assuming the type matches. Callers have to guarantee type-safety!

  • svg/SVGAnimatedType.h:

(SVGAnimatedType): Add new static supportsAnimVal(AnimatedPropertyType) function.
(WebCore::SVGAnimatedType::variantValue): Add a generic accessor for all animated types, called variant(). Only one place uses this.

  • svg/SVGAnimatedTypeAnimator.h:

(WebCore::SVGAnimatedTypeAnimator::constructFromCopy):

New method to construct an eg. SVGAnimatedLengthAnimator right from a SVGLength, instead of a String.
In that case the SVGAnimatedType just stores a pointer to the underlying SVGLength, no copying and or other roundtrips involved.

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::svgAttributeChanged):

Implement this instead of attributeChanged. The previous implementation reset the animation state to Inactive, causing a full
rebuild, whenever any attribute changes, even though it might not be related for the animation element, eg.
animate.setAttribute("stdDeviationX", "foobar"). Fix that by checking if we support the attribute (keyTimes/keySplines/etc..)
, if not pass it on to SVGSMILElement (which supports begin/end/etc..) to check if it can handle that.

(WebCore::SVGAnimationElement::animationAttributeChanged):

Called from our svgAttributeChanged, and/or from SVGSMILElement::svgAttributeChanged, whenever a _known_ attribute has changed.
This sledgehammer should be used with care, instead of each time attributeChanged() is called :-)

(WebCore::setTargetAttributeAnimatedCSSValue):

Remove support for removing properties from the override style sheet. I've added this optimization too early, we should reevaluate
this once more types support animVal. It currently complexifies the logic too much, requiring setAttributeAnimatedValue to know
if the animation ends (and that's not easy to figure out, at least not using started/endedActiveInterval, as I anticipated).

(WebCore::findMatchingAnimatedProperty):

Add helper functions which retrieves a SVGAnimatedProperty* for a given SVGElement* targetElement, an attributeName, and an attribute
type. eg. findMatchingAnimatedProperty(myRectElement, SVGNames::xAttr, AnimatedLength) returns the SVGAnimatedProperty which is
exposed to JS, that holds: SVGProperty* baseVal, and SVGProperty* animVal. (Lazily created if they got accessed from JS.). This is
used to update the animVal pointing to a new eg. SVGLength* value, once animation has started, to make rect->x() return that new
SVGLength* value (internally), and to reflect the current animated value in rect.x.animVal.value from JS.

(WebCore::SVGAnimationElement::applyAnimatedValue): Refactored from setTargetAttributeAnimatedValue, to simplify the code.
(WebCore::notifyAnimatedPropertyAboutAnimationBeginEnd):

Helper function to share code betweeen animationStarted/animationEnded.
It takes a SVGAnimatedProperty* and a SVGAnimatedType* which may be zero, indicating that the animation ended.
It calls animationStarted/animationEnded on the given SVGAnimatedProperty, to update the animVal state.
It also figures out all instances of the target element, and their SVGAnimatedProperties that may need updating.

(WebCore::SVGAnimationElement::animationStarted): Uses the helper above, passing on the given animatedType.
(WebCore::SVGAnimationElement::animationEnded): Uses the helper above, passing 0 as animatedType.
(WebCore::InstanceUpdateBlocker::InstanceUpdateBlocker):

Added new helper struct, doing element->setInstancesUpdatedBlock(true) on construction and setInstancesUpdatesBlocked(false) on
destruction, making it impossible to forget one. If we ever rewrite svgAttributeChanged & co to auto-update the cloned instances,
this can go away.

(WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):

Now takes an SVGAnimatedType* instead of a String parameter. In order to avoid string-roundtrips for animVal support, let us
decide if we need to construct a String out of it, or not. For animations supporting animVal (only SVGLength) we don't need
to update any attribute or animVal pointer here, that happens automatically! We only need to notify the targetElement eg,
that its xAttr changed! Previously we had to call targetElement->setAttribute("x", "...") on every animation step for
SVGLength animations - that's gone now! The SVGAnimatedType pointers remains the same during the whole animation, so there's
no need to call animationStarted() at each animated step!

(WebCore::SVGAnimationElement::animatedPropertyForType):

Helper function returning a SVGAnimatedProperty* for the current target element & current target attribute, if the
current animation is running on a type supporting animVal (SVGLength), or returning 0. This is needed for SVGAnimateElement.
Reuses the existing findMatchingAnimatedProperty code.

  • svg/SVGAnimationElement.h:
  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::updateAnimations):

Add comment to clarify why caching baseValues is just wrong. For SVGLength animations the problem is now gone.
This is exercised using the new additive-from-to-width-animation.html & additive-values-width-animation.html tests.

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::removedFromDocument):

Since animVal requires that the SVGAnimatedProperties are correctly reset if an animation element is removed from the document,
we have to call targetElementWillChange(0) from here. That requires to move the "m_attributeName = anyQName()" line down,
otherwise targetElementWillChange() would early exit, as no valid attributeName was specified.

This is verified using the new svg/animations/remove-animation-element-while-animation-is-running.html
and svg/repaint/repainting-after-animation-element-removal.svg tests.

(WebCore::SVGSMILElement::isSupportedAttribute): Add function like all SVG*Elements have identifying their supported attributes.
(WebCore::SVGSMILElement::svgAttributeChanged):

Implement svgAttributeChanged instead of attributeChanged. Only take action if the attribute is actually supported.
If one of the common attributes like begin/end/etc. changed, be sure to call animationAttributeChanged() so that our
ancestor-classes get notified about this and can take action as well. NOTE: This is not about animating begin/end attributes,
but about pure DOM changes. begin/end/et.. are not exposed to the SVG DOM, we still reuse the svgAttributeChanged logic
for consistency. (This does NOT make those attributes animatable, nothing this here as it came up while reviewing).

(WebCore::SVGSMILElement::targetElement): Adapt logic to targetElementDidChange -> targetElementWillChange change.
(WebCore::SVGSMILElement::targetElementWillChange):

Renamed from targetElementDidChange. Added "oldTarget" as parameter as well. Our ancestor-classes like SVGAnimateElement
use this to properly deregister the animVal in the old target, before resetting the SVGAnimatedType, otherwise we'd leave
dangling pointers around (verified manually by guard malloc runs, that none of this happens).

Also add a default implementation here in targetElementWillChange, that ancestor classes have to call.
Now we properly call endedActiveInterval() if the m_activeState is currently Active, so that animations are shut-down
just like if the animation properly ends (use the same cleanup routines, etc.). Not doing that now leads to assertions.

(WebCore::SVGSMILElement::resetTargetElement):

Instead of forcing m_activeState to be inactive, use the standard methods to end the animation.
targetElementWillChange(m_targetElement, 0) and animationAttributeChanged().

resetTargetElement() is only called by SVGDocumentExtensions::removeAllAnimationElementsFromTarget() for following conditions:

  • targetElement gets destructed
  • targetElement gets removed from the document
  • targetElement id changes

If the targetElement gets destructed or removed, no actions need to be taken, as the SVGAnimatedPropertys are teared down
as well. But if only the id changes, we still have to properly disconnect the animVals - this is all handled through
targetElementWillChange now - that's why this has to be called from here as well.
That explains why targetElementWillChange() now needs to check if the targetElement is destructing or not.

  • svg/properties/SVGAnimatedEnumerationPropertyTearOff.h:

Pass the AnimatedPropertyType from the SVGPropertyInfo to the SVGAnimatedProperties.
Requires mechanic changes in all SVGAnimated* classes. We need acccess to the AnimatedPropertyType
to verify the SVGAnimatedType objects, passed to animationStarted, match our type. This is to enforce
strict type-checking, whenever SVGGenericAnimatedTypes are passed around.

(WebCore::SVGAnimatedEnumerationPropertyTearOff::create):
(WebCore::SVGAnimatedEnumerationPropertyTearOff::SVGAnimatedEnumerationPropertyTearOff):

  • svg/properties/SVGAnimatedListPropertyTearOff.h: Ditto.

(WebCore::SVGAnimatedListPropertyTearOff::create):
(WebCore::SVGAnimatedListPropertyTearOff::SVGAnimatedListPropertyTearOff):

  • svg/properties/SVGAnimatedPathSegListPropertyTearOff.h: Ditto.

(WebCore::SVGAnimatedPathSegListPropertyTearOff::create):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::SVGAnimatedPathSegListPropertyTearOff):

  • svg/properties/SVGAnimatedProperty.h: Store AnimatedPropertyType, add accessors.

(WebCore::SVGAnimatedProperty::animatedPropertyType): Add accessor.
(WebCore::SVGAnimatedProperty::animationValueChanged): New animVal related functions to be implemented in the animated tear offs.
(WebCore::SVGAnimatedProperty::animationStarted): Ditto.
(WebCore::SVGAnimatedProperty::animationEnded): Ditto.
(WebCore::SVGAnimatedProperty::currentBaseValue):

Generic accessor for the baseVal: returns a SVGGenericAnimatedType.
It takes an AnimatedPropertyType as input, that's only needed to verify that the type we're returning matches
the expectation of the caller. If not, return 0 to avoid any potential casting mistakes, which would lead to crashes.

(WebCore::SVGAnimatedProperty::SVGAnimatedProperty): Store m_animatedPropertyType.

  • svg/properties/SVGAnimatedPropertyTearOff.h:

(WebCore::SVGAnimatedPropertyTearOff::create): Same changes as in the other tear offs: pass around AnimatedPropertyType.
(WebCore::SVGAnimatedPropertyTearOff::currentBaseValue): Returns &m_property, if the type matches (see above).
(SVGAnimatedPropertyTearOff): Pass around AnimatedPropertyType.
(WebCore::SVGAnimatedPropertyTearOff::animationValueChanged): No-op for non list types, don't need to do anything here.
(WebCore::SVGAnimatedPropertyTearOff::animationStarted):
(WebCore::SVGAnimatedPropertyTearOff::animationEnded):

Store the currently animated value in the animVal() property tear off, that's also re-used as-is for the JS bindings.
As this is important, here's an example of how this affects methods like rect->x() used in the renderers.

Setting m_isAnimating to true, redirects any rect->x() calls that previously returned rect->m_x, to
rect->xAnimated()->animVal()->propertyReference() (which returns the same SVGLength& that the SVGAnimatedElement
m_animatedType contains). Calling rect->setXBaseValue() still modifies rect->m_x, and is used by all parseAttribute()
methods in svg/ as setAttribute() calls only ever modify the "baseValue", never the current animated value.
rect.x.baseVal will return a SVGLength object corresponding to rect->m_x.
rect.x.animVal will return a SVGLength object corresponding to rect->xAnimated()->animVal()->propertyReference().

These implementation details are all hidden in the SVGAnimatedPropertyMacros. Here's an example from SVGRectElement:
DECLARE_ANIMATED_LENGTH(X, x) -> Replace PropertyType with 'SVGLength', LowerProperty with 'x', and UpperProperty with 'X'.

PropertyType& LowerProperty() const
{

if (TearOffType* wrapper = SVGAnimatedProperty::lookupWrapper<UseOwnerType, TearOffType, IsDerivedFromSVGElement<UseOwnerType>::value>(this, LowerProperty##PropertyInfo())) {

if (wrapper->isAnimating())

return wrapper->currentAnimatedValue();

}
return m_##LowerProperty.value;

}

PropertyType& LowerProperty##BaseValue() const
{

return m_##LowerProperty.value;

}

void set##UpperProperty##BaseValue(const PropertyType& type)
{

m_##LowerProperty.value = type;

}

Any code outside of svg/, eg. in rendering/svg, does not need to care about any baseVal/animVal differences.
During layout eg. RenderSVGRect calls rect->x().value(someLengthContext) to get the current 'x' as float. If an animation
is running on that rect element it will automatically retrieve the last set animated value here - all under the hood.
I hope that sheds some light in those myserious functions, they were designed with animVal in mind, but we never had that until now :-)

(WebCore::SVGAnimatedPropertyTearOff::SVGAnimatedPropertyTearOff): Pass around AnimatedPropertyType.
(WebCore::SVGAnimatedPropertyTearOff::~SVGAnimatedPropertyTearOff): Add destructor to debug builds veryifing that m_isAnimating is false.

  • svg/properties/SVGAnimatedStaticPropertyTearOff.h: Ditto.

(WebCore::SVGAnimatedStaticPropertyTearOff::create):
(WebCore::SVGAnimatedStaticPropertyTearOff::SVGAnimatedStaticPropertyTearOff):

  • svg/properties/SVGAnimatedTransformListPropertyTearOff.h: Ditto.

(WebCore::SVGAnimatedTransformListPropertyTearOff::create):
(WebCore::SVGAnimatedTransformListPropertyTearOff::SVGAnimatedTransformListPropertyTearOff):

  • svg/properties/SVGPropertyInfo.h: Add SVGGenericAnimatedType definition.
  • svg/properties/SVGPropertyTearOff.h: Remove obsolete updateAnimVal method - switched to using setValue directly.

LayoutTests:

Update test expectations after turning on animVal support for SVGLength, the first primitive now support animVal.
Added several new tests, checking additive behaviour with SVGLength objects, removing animation elements
while animations are running (+ test repainting of those cases), etc.

  • platform/mac/svg/repaint/repainting-after-animation-element-removal-expected.png: Added.
  • platform/mac/svg/repaint/repainting-after-animation-element-removal-expected.txt: Added.
  • svg/animations/additive-from-to-width-animation-expected.txt: Added.
  • svg/animations/additive-from-to-width-animation.html: Added.
  • svg/animations/additive-values-width-animation-expected.txt: Added.
  • svg/animations/additive-values-width-animation.html: Added.
  • svg/animations/animVal-basics-expected.txt:
  • svg/animations/animate-calcMode-spline-by-expected.txt:
  • svg/animations/animate-calcMode-spline-from-by-expected.txt:
  • svg/animations/animate-calcMode-spline-from-to-expected.txt:
  • svg/animations/animate-calcMode-spline-to-expected.txt:
  • svg/animations/animate-calcMode-spline-values-expected.txt:
  • svg/animations/animate-elem-02-t-drt-expected.txt:
  • svg/animations/animate-elem-09-t-drt-expected.txt:
  • svg/animations/animate-elem-10-t-drt-expected.txt:
  • svg/animations/animate-elem-11-t-drt-expected.txt:
  • svg/animations/animate-elem-12-t-drt-expected.txt:
  • svg/animations/animate-elem-13-t-drt-expected.txt:
  • svg/animations/animate-elem-14-t-drt-expected.txt:
  • svg/animations/animate-elem-15-t-drt-expected.txt:
  • svg/animations/animate-elem-16-t-drt-expected.txt:
  • svg/animations/animate-elem-17-t-drt-expected.txt:
  • svg/animations/animate-elem-18-t-drt-expected.txt:
  • svg/animations/animate-elem-19-t-drt-expected.txt:
  • svg/animations/animate-end-attribute-expected.txt:
  • svg/animations/animate-endElement-beginElement-expected.txt:
  • svg/animations/animate-from-to-keyTimes-expected.txt:
  • svg/animations/animate-insert-begin-expected.txt:
  • svg/animations/animate-insert-no-begin-expected.txt:
  • svg/animations/animate-keySplines-expected.txt:
  • svg/animations/animate-number-calcMode-discrete-keyTimes-expected.txt:
  • svg/animations/attributeTypes-expected.txt:
  • svg/animations/change-baseVal-while-animating-fill-freeze-2-expected.txt: Added.
  • svg/animations/change-baseVal-while-animating-fill-freeze-2.html: Added.
  • svg/animations/change-baseVal-while-animating-fill-freeze-expected.txt: Added.
  • svg/animations/change-baseVal-while-animating-fill-freeze.html: Added.
  • svg/animations/change-baseVal-while-animating-fill-remove-2-expected.txt: Added.
  • svg/animations/change-baseVal-while-animating-fill-remove-2.html: Added.
  • svg/animations/change-baseVal-while-animating-fill-remove-expected.txt: Added.
  • svg/animations/change-baseVal-while-animating-fill-remove.html: Added.
  • svg/animations/change-target-while-animating-SVG-property-expected.txt: Added.
  • svg/animations/change-target-while-animating-SVG-property.html: Added.
  • svg/animations/multiple-animations-fill-freeze-expected.txt: Added.
  • svg/animations/multiple-animations-fill-freeze.html: Added.
  • svg/animations/remove-animation-element-while-animation-is-running-expected.txt: Added.
  • svg/animations/remove-animation-element-while-animation-is-running.html: Added.
  • svg/animations/resources/additive-from-to-width-animation.svg: Added.
  • svg/animations/resources/additive-values-width-animation.svg: Added.
  • svg/animations/resources/change-baseVal-while-animating-fill-freeze.svg: Added.
  • svg/animations/resources/change-baseVal-while-animating-fill-remove.svg: Added.
  • svg/animations/resources/change-target-while-animating-SVG-property.svg: Added.
  • svg/animations/resources/multiple-animations-fill-freeze.svg: Added.
  • svg/animations/resources/remove-animation-element-while-animation-is-running.svg: Added.
  • svg/animations/script-tests/additive-from-to-width-animation.js: Added.

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/additive-values-width-animation.js: Added.

(sample1):
(sample2):
(sample3):
(changeBaseVal):
(sample4):
(sample5):
(executeTest):

  • svg/animations/script-tests/animVal-basics.js:

(sample2):
(sample3):

  • svg/animations/script-tests/animate-calcMode-spline-by.js:

(sample2):
(sample3):

  • svg/animations/script-tests/animate-calcMode-spline-from-by.js:

(sample2):
(sample3):

  • svg/animations/script-tests/animate-calcMode-spline-from-to.js:

(sample2):
(sample3):

  • svg/animations/script-tests/animate-calcMode-spline-to.js:

(sample2):
(sample3):

  • svg/animations/script-tests/animate-calcMode-spline-values.js:

(sample2):
(sample3):

  • svg/animations/script-tests/animate-elem-02-t-drt.js:

(sampleAfterBegin):
(sampleAfterMid):
(sampleAfterBeginOfFirstRepetition):
(sampleAfterMidOfFirstRepetition):

  • svg/animations/script-tests/animate-elem-09-t-drt.js:

(sample1):
(sample2):
(sample3):
(sample4):

  • svg/animations/script-tests/animate-elem-10-t-drt.js:

(sample1):
(sample2):
(sample3):
(sample4):

  • svg/animations/script-tests/animate-elem-11-t-drt.js:

(sample1):
(sample2):
(sample3):
(sample4):

  • svg/animations/script-tests/animate-elem-12-t-drt.js:

(sample1):
(sample2):
(sample3):
(sample4):

  • svg/animations/script-tests/animate-elem-13-t-drt.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/animate-elem-14-t-drt.js:

(sample1):
(sample2):
(sample3):
(sample4):

  • svg/animations/script-tests/animate-elem-15-t-drt.js:

(sample1):
(sample2):
(sample3):
(sample4):

  • svg/animations/script-tests/animate-elem-16-t-drt.js:

(sample1):
(sample2):
(sample3):
(sample4):

  • svg/animations/script-tests/animate-elem-17-t-drt.js:

(sample1):
(sample2):
(sample3):
(sample4):

  • svg/animations/script-tests/animate-elem-18-t-drt.js:

(sample1):
(sample2):
(sample3):
(sample4):

  • svg/animations/script-tests/animate-elem-19-t-drt.js:

(sample1):
(sample2):
(sample3):
(sample4):

  • svg/animations/script-tests/animate-end-attribute.js:

(sample2):
(sample3):

  • svg/animations/script-tests/animate-endElement-beginElement.js:

(sample1):

  • svg/animations/script-tests/animate-from-to-keyTimes.js:

(sample1):
(sample2):

  • svg/animations/script-tests/animate-insert-begin.js:

(sample1):
(sample2):

  • svg/animations/script-tests/animate-insert-no-begin.js:

(sample1):
(sample2):

  • svg/animations/script-tests/animate-keySplines.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/animate-number-calcMode-discrete-keyTimes.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/attributeTypes.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/change-baseVal-while-animating-fill-freeze-2.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(executeTest):

  • svg/animations/script-tests/change-baseVal-while-animating-fill-freeze.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(executeTest):

  • svg/animations/script-tests/change-baseVal-while-animating-fill-remove-2.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(executeTest):

  • svg/animations/script-tests/change-baseVal-while-animating-fill-remove.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(executeTest):

  • svg/animations/script-tests/change-target-while-animating-SVG-property.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(executeTest):

  • svg/animations/script-tests/multiple-animations-fill-freeze.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(sample6):
(sample7):
(sample8):
(executeTest):

  • svg/animations/script-tests/remove-animation-element-while-animation-is-running.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):

  • svg/animations/script-tests/svglength-animation-LengthModeHeight.js:

(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-LengthModeOther.js:

(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-LengthModeWidth.js:

(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-invalid-value-1.js:

(sample2):

  • svg/animations/script-tests/svglength-animation-invalid-value-2.js:

(sample2):

  • svg/animations/script-tests/svglength-animation-invalid-value-3.js:

(sample2):

  • svg/animations/script-tests/svglength-animation-number-to-number.js:

(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-px-to-cm.js:

(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-px-to-ems.js:

(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-px-to-exs.js:

(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-px-to-in.js:

(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-px-to-number.js:

(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-px-to-pc.js:

(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-px-to-percentage.js:

(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-px-to-pt.js:

(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-px-to-px.js:

(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-unitType.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/svglength-animation-values.js:

(sample2):
(sample3):
(sample4):
(sample5):

  • svg/animations/svglength-animation-LengthModeHeight-expected.txt:
  • svg/animations/svglength-animation-LengthModeOther-expected.txt:
  • svg/animations/svglength-animation-LengthModeWidth-expected.txt:
  • svg/animations/svglength-animation-invalid-value-1-expected.txt:
  • svg/animations/svglength-animation-invalid-value-2-expected.txt:
  • svg/animations/svglength-animation-invalid-value-3-expected.txt:
  • svg/animations/svglength-animation-number-to-number-expected.txt:
  • svg/animations/svglength-animation-px-to-cm-expected.txt:
  • svg/animations/svglength-animation-px-to-ems-expected.txt:
  • svg/animations/svglength-animation-px-to-exs-expected.txt:
  • svg/animations/svglength-animation-px-to-in-expected.txt:
  • svg/animations/svglength-animation-px-to-number-expected.txt:
  • svg/animations/svglength-animation-px-to-pc-expected.txt:
  • svg/animations/svglength-animation-px-to-percentage-expected.txt:
  • svg/animations/svglength-animation-px-to-pt-expected.txt:
  • svg/animations/svglength-animation-px-to-px-expected.txt:
  • svg/animations/svglength-animation-unitType-expected.txt:
  • svg/animations/svglength-animation-values-expected.txt:
  • svg/repaint/repainting-after-animation-element-removal.svg: Added.
01:12 Changeset [110544] by macpherson@chromium.org

Implement CSSPropertyTextOverflow in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=80934

Reviewed by Andreas Kling.

No new tests / refactoring only.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

00:28 Changeset [110543] by philn@webkit.org

Unreviewed, inspector test rebaseline after r110532.

  • inspector/styles/svg-style-expected.txt:
00:24 Changeset [110542] by commit-queue@webkit.org

[Forms] Re-factor label.for tests for extending test coverage
https://bugs.webkit.org/show_bug.cgi?id=80574

Patch by Yosifumi Inoue <yosin@chromium.org> on 2012-03-13
Reviewed by Kent Tamura.

This patch changes label.labels attribute testing with using shared
utility functions, createFormControlDataSet for representing form
related information of HTML5 specification and setupLabelsTeset for
populating test sample dom tree and data set.

This patch extends coverage of existing label.labels test to cover
defined in the specification, labelable-elements.html, and adds
multiple label entries tests, labels-multiple-*.html.

Note: test failure of hidden input type will be fixed by
https://bugs.webkit.org/show_bug.cgi?id=80403

Note: test failure of output element will be fixed by
https://bugs.webkit.org/show_bug.cgi?id=80466

  • fast/forms/label/labelable-elements-expected.txt: Added.
  • fast/forms/label/labelable-elements.html: Added.
  • fast/forms/label/labels-add-htmlFor-label-expected.txt:
  • fast/forms/label/labels-add-htmlFor-label.html:
  • fast/forms/label/labels-add-parent-label-expected.txt:
  • fast/forms/label/labels-add-parent-label.html:
  • fast/forms/label/labels-change-htmlFor-attribute-expected.txt:
  • fast/forms/label/labels-change-htmlFor-attribute.html:
  • fast/forms/label/labels-multiple-sibling-labels-expected.txt: Added.
  • fast/forms/label/labels-multiple-sibling-labels.html: Added.
  • fast/forms/label/labels-parent-and-sibling-labels-expected.txt: Added.
  • fast/forms/label/labels-parent-and-sibling-labels.html: Added.
  • fast/forms/label/labels-remove-htmlFor-attribute-expected.txt:
  • fast/forms/label/labels-remove-htmlFor-attribute.html:
  • fast/forms/label/labels-remove-htmlFor-label-expected.txt:
  • fast/forms/label/labels-remove-htmlFor-label.html:
  • fast/forms/label/labels-remove-parent-label-expected.txt:
  • fast/forms/label/labels-remove-parent-label.html:
  • fast/forms/label/labels-set-htmlFor-attribute-expected.txt:
  • fast/forms/label/labels-set-htmlFor-attribute.html:
  • fast/forms/resources/common.js:

(createFormControlDataSet): Returns form control data set for providing
labelable elements and supported elements information.

  • fast/forms/resources/label-test-util.js: Added.

(setupLabelsTest.return.dataSet.dataSet.getLabelableElementData):
(setupLabelsTest): Populate dom tree for unit tests.

03/12/12:

23:42 Changeset [110541] by commit-queue@webkit.org

Switch Chromium from LocaleToScriptMappingICU.cpp to LocaleToScriptMappingDefault.cpp
https://bugs.webkit.org/show_bug.cgi?id=80935

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-03-12
Reviewed by Kent Tamura.

ICU seems to have issues with non-well-formed locale strings.
Currently, the only port that uses LocaleToScriptMappingICU.cpp is
Chromium.

No new tests. LocaleToScriptMappingDefault.cpp is already used by
other ports and covered by existing tests.

  • WebCore.gyp/WebCore.gyp:
23:15 Changeset [110540] by commit-queue@webkit.org

Fix test cases for RegExp multiline
https://bugs.webkit.org/show_bug.cgi?id=80822

Patch by Hojong Han <hojong.han@samsung.com> on 2012-03-12
Reviewed by Gavin Barraclough.

  • tests/mozilla/js1_2/regexp/RegExp_multiline.js:
  • tests/mozilla/js1_2/regexp/RegExp_multiline_as_array.js:
  • tests/mozilla/js1_2/regexp/beginLine.js:
  • tests/mozilla/js1_2/regexp/endLine.js:
22:38 Changeset [110539] by commit-queue@webkit.org

Fix IndexedDB build with JSC
https://bugs.webkit.org/show_bug.cgi?id=80207

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-12
Reviewed by Adam Barth.

This fixes the build of WebKit when IndexedDB is enabled. Most functions were added
empty implementation, it compiles but IndexedDB is not working.

  • DerivedSources.make: Added missing IDL files.
  • Modules/indexeddb/IDBDatabaseBackendImpl.h: Fix warnings and build errors.

(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBDatabaseCallbacksImpl.cpp: ditto.

(WebCore::IDBDatabaseCallbacksImpl::unregisterDatabase): ditto.

  • Modules/indexeddb/IDBFactoryBackendImpl.cpp: ditto.

(WebCore::IDBFactoryBackendImpl::openBackingStore):

  • Modules/indexeddb/IDBIndexBackendImpl.cpp: ditto.

(WebCore::IDBIndexBackendImpl::countInternal):

  • Modules/indexeddb/IDBKeyPathBackendImpl.cpp: Fix the method signature and add

an empty implementation.
(WebCore):
(WebCore::IDBKeyPathBackendImpl::createIDBKeysFromSerializedValuesAndKeyPath):
(WebCore::IDBKeyPathBackendImpl::injectIDBKeyIntoSerializedValue):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp: Fix warnings.

(WebCore::IDBObjectStoreBackendImpl::countInternal):

  • Modules/indexeddb/IDBPendingTransactionMonitor.cpp: ditto.

(WebCore::transactions):

  • Modules/indexeddb/IDBRequest.cpp: ditto.

(WebCore::IDBRequest::resetReadyState):

  • Modules/indexeddb/IDBRequest.h: ditto.

(WebCore::IDBRequest::onSuccessWithPrefetch):
(WebCore):
(WebCore::JSIDBVersionChangeRequest::visitChildren):

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/IDBBindingUtilities.cpp:

(WebCore::createIDBKeyFromValue): Fix the creation of IDBKeys.
(WebCore::createOptionsObjectFromValue): Add an empty implementation of
the handling of database options (IDBObjectStoreParameters).
(WebCore):

  • bindings/js/IDBBindingUtilities.h:

(WebCore):

  • bindings/js/JSIDBAnyCustom.cpp:

(WebCore::toJS): Add the missing IDBAny's types.

  • bindings/js/JSIDBKeyCustom.cpp:

(WebCore::toJS): Add the missing IDBKey's types.

  • bindings/js/JSIDBVersionChangeRequestCustom.cpp: Added.

IDBVersionChangeRequest has the attribute EventTarget so it requires
the visitChildren() function. An empty implementation was added.

  • bindings/js/OptionsObject.h: Add an empty implementation.

(WebCore):
(OptionsObject):
(WebCore::OptionsObject::OptionsObject):
(WebCore::OptionsObject::isObject):
(WebCore::OptionsObject::isUndefinedOrNull):
(WebCore::OptionsObject::get):
(WebCore::OptionsObject::getWithUndefinedOrNullCheck):

  • bindings/js/SerializedScriptValue.cpp: Add the missing functions needed by IndexedDB.

(WebCore):
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::toWireString):
(WebCore::SerializedScriptValue::createFromWire):
(WebCore::SerializedScriptValue::numberValue):
(WebCore::SerializedScriptValue::deserialize):

  • bindings/js/SerializedScriptValue.h:

(SerializedScriptValue):

  • bindings/scripts/CodeGeneratorJS.pm: Modify the code generator to:

-Support the IDBKey type correctly.
-Support the OptionsObject type.
-Generate valid function call for static functions.
(GenerateImplementationFunctionCall):
(JSValueToNative):
(NativeToJSValue):

  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):

22:36 Changeset [110538] by morrita@google.com

Unreviewed, rolling out r110529.
http://trac.webkit.org/changeset/110529
https://bugs.webkit.org/show_bug.cgi?id=80969

breaks mac build (Requested by morrita on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-12

Source/WebCore:

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::computeUnoccludedContentRect):

Source/WebKit/chromium:

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore):

22:03 Changeset [110537] by morrita@google.com

Unreviewed, rolling out r110524.
http://trac.webkit.org/changeset/110524
https://bugs.webkit.org/show_bug.cgi?id=80936

breaks chromium win build. (Requested by morrita on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-12

Source/WebCore:

  • Target.pri:
  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateNamedConstructorCallback):
(GenerateImplementation):

  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):

  • bindings/v8/NPV8Object.cpp:

(WebCore::npObjectTypeInfo):

  • bindings/v8/V8GCController.cpp:

(WebCore::GrouperVisitor::visitDOMWrapper):

  • bindings/v8/WrapperTypeInfo.h:

(WebCore):
(WrapperTypeInfo):

  • bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Copied from Source/WebCore/bindings/v8/custom/V8StyleSheetCustom.cpp.

(WebCore):
(WebCore::toV8):

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::toV8):
(WebCore):

  • bindings/v8/custom/V8DOMTokenListCustom.cpp: Copied from Source/WebCore/bindings/v8/custom/V8StyleSheetCustom.cpp.

(WebCore):
(WebCore::toV8):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore):

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:

(WebCore::toV8):
(WebCore):

  • bindings/v8/custom/V8StyleSheetCustom.cpp:

(WebCore::toV8):

  • css/CSSStyleSheet.idl:
  • css/StyleSheet.idl:
  • dom/DOMStringMap.idl:
  • dom/NamedNodeMap.idl:
  • html/DOMTokenList.idl:
  • html/track/TextTrackList.idl:

LayoutTests:

  • platform/chromium/test_expectations.txt:
21:20 Changeset [110536] by haraken@chromium.org

[V8][Refactoring] Remove getCachedWrapperSlow() from V8Bindings.cpp
https://bugs.webkit.org/show_bug.cgi?id=80924

Reviewed by Adam Barth.

getCachedWrapperSlow() is called by getCachedWrapper() only,
and getCachedWrapperSlow() just calls getCachedWrapperInline().
Thus, this patch expands getCachedWrapperInline() into getCachedWrapper(),
and removes getCachedWrapperSlow().

No tests. No change in behavior.

  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getCachedWrapper):

21:03 Changeset [110535] by haraken@chromium.org

[V8][Refactoring] Remove existingWrapper() from generated code
https://bugs.webkit.org/show_bug.cgi?id=80927

Reviewed by Adam Barth.

Currently wrap() calls existingWrapper(), and existingWrapper()
just calls getCachedWrapper(). We can remove existingWrapper() from the generated code.

Test: bindings/scripts/test/*

  • bindings/scripts/CodeGeneratorV8.pm: Removed existingWrapper().

(GenerateHeader):
(GenerateNormalAttrGetter):

  • bindings/scripts/test/V8/V8Float64Array.h: Updated run-bindings-tests results.

(V8Float64Array):
(WebCore::V8Float64Array::wrap):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):
(WebCore::V8TestActiveDOMObject::wrap):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):
(WebCore::V8TestCustomNamedGetter::wrap):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):
(WebCore::V8TestEventConstructor::wrap):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):
(WebCore::V8TestEventTarget::wrap):

  • bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):
(WebCore::V8TestInterface::wrap):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):
(WebCore::V8TestMediaQueryListListener::wrap):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):
(WebCore::V8TestNamedConstructor::wrap):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::readOnlyTestObjAttrAttrGetter):
(WebCore::TestObjInternal::cachedAttribute1AttrGetter):
(WebCore::TestObjInternal::cachedAttribute2AttrGetter):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):
(WebCore::V8TestObj::wrap):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):
(WebCore::V8TestSerializedScriptValueInterface::wrap):

20:33 Changeset [110534] by commit-queue@webkit.org

[chromium] Use tileRect instead of pointer derefs
https://bugs.webkit.org/show_bug.cgi?id=80919

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-12
Reviewed by Adrienne Walker.

Covered by existing tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawTileQuad):

20:14 Changeset [110533] by ojan@chromium.org

webkit-patch optimize-baselines sometimes creates a mac-future result
https://bugs.webkit.org/show_bug.cgi?id=80717

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/checkout/baselineoptimizer.py:

(_baseline_search_hypergraph):
(BaselineOptimizer._find_optimal_result_placement):
(BaselineOptimizer._filter_virtual_ports):

  • Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:

(BaselineOptimizerTest.test_no_add_mac_future):

19:45 Changeset [110532] by commit-queue@webkit.org

SVG should support transform-origin and relative values
https://bugs.webkit.org/show_bug.cgi?id=79068

Patch by Hans Muller <hmuller@adobe.com> on 2012-03-12
Reviewed by Dirk Schulze.

Source/WebCore:

Added SVG support for the CSS 'transform-origin' property and for percentage
values in the transform translate function. The changes conform to
http://dev.w3.org/csswg/css3-transforms/.

Tests: svg/transforms/percent-transform-values.xhtml

svg/transforms/transform-origin-css-property.xhtml

  • css/svg.css:

(*):
(html|* > svg):
Default transform-origin for SVG elements is 0 0.

  • platform/Length.h:

(WebCore::Length::calcFloatValue):
Added a calcFloatValue overload whose max parameter (for percent lengths) is a float.
The original version will be obsolete when the sub-pixel layout support is completed.

  • rendering/style/RenderStyle.cpp:
  • rendering/style/RenderStyle.h:

(WebCore):
(WebCore::requireTransformOrigin):
Transforms that only include translations don't depend on the transform-origin.

(WebCore::RenderStyle::applyTransform):
SVG elements interpret non-percentage/keyword transform-origin values relative to their viewport,
unlike HTML which interprets all transform-origin values relative to the element's origin.
The new FloatRect applyTransform() function handles SVG semantics. Similarly, SVG elements interpret
percentage/keyword transform-origin values relative to the origin of their objectBoundingBox(), HTML
uses the borderBox. All this per http://dev.w3.org/csswg/css3-transforms/.

  • svg/SVGStyledTransformableElement.cpp:

(WebCore::SVGStyledTransformableElement::animatedLocalTransform):

LayoutTests:

Added tests for SVG CSS transform-origin property support and for
CSS translations specified with percentages and applied to an SVG element.

  • svg/transforms/change-transform-origin-css-expected.xhtml: Added.
  • svg/transforms/change-transform-origin-css.xhtml: Added.
  • svg/transforms/change-transform-origin-presentation-attribute-expected.xhtml: Added.
  • svg/transforms/change-transform-origin-presentation-attribute.xhtml: Added.
  • svg/transforms/percent-transform-values-expected.txt: Added.
  • svg/transforms/percent-transform-values.xhtml: Added.
  • svg/transforms/transform-origin-css-property-expected.xhtml: Added.
  • svg/transforms/transform-origin-css-property.xhtml: Added.
19:42 Changeset [110531] by morrita@google.com

Unreviewed Windows build fix.

  • src/WebViewImpl.cpp:
19:29 Changeset [110530] by weinig@apple.com

Fix assert seen in DRT due to not calling EventSender.mouseUp in a previous test
https://bugs.webkit.org/show_bug.cgi?id=80925

Reviewed by Maciej Stachowiak.

  • fast/events/input-element-display-none-in-dragleave-crash.html:

Add call to eventSender.mouseUp().

19:27 Changeset [110529] by commit-queue@webkit.org

[chromium] Use projectQuad to apply inverse mapRect
https://bugs.webkit.org/show_bug.cgi?id=80741

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-12
Reviewed by Adrienne Walker.

Source/WebCore:

Unit test: CCOcclusionTrackerTest3dTransform

CCOcclusionTrackerTestPerspectiveTransform
CCOcclusionTrackerTestPerspectiveTransformBehindCamera

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::projectQuad):
(WebCore):
(WebCore::computeUnoccludedContentRect):

Source/WebKit/chromium:

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore):
(CCOcclusionTrackerTest3dTransform):
(WebCore::CCOcclusionTrackerTest3dTransform::runMyTest):
(CCOcclusionTrackerTestPerspectiveTransform):
(WebCore::CCOcclusionTrackerTestPerspectiveTransform::runMyTest):
(CCOcclusionTrackerTestPerspectiveTransformBehindCamera):
(WebCore::CCOcclusionTrackerTestPerspectiveTransformBehindCamera::runMyTest):

19:17 Changeset [110528] by leo.yang@torchmobile.com.cn

[BlackBerry] Upstream the BlackBerry change to platform/graphics/FontPlatformData.h
https://bugs.webkit.org/show_bug.cgi?id=80820

Reviewed by Rob Buis.

The BlackBerry is using the FontPlatformData from Chromium porting.

  • platform/graphics/FontPlatformData.h:
18:58 Changeset [110527] by jberlin@webkit.org

More Windows build fixing.

  • DumpRenderTree/win/WorkQueueItemWin.cpp:
18:52 Changeset [110526] by zmo@google.com

After webgl canvas resize, bindings might be lost
https://bugs.webkit.org/show_bug.cgi?id=80895

Reviewed by Stephen White.

Source/WebCore:

Test: fast/canvas/webgl/texture-bindings-uneffected-on-resize.html

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::reshape): recover bindings after reshape.

LayoutTests:

  • fast/canvas/webgl/texture-bindings-uneffected-on-resize-expected.txt: Added.
  • fast/canvas/webgl/texture-bindings-uneffected-on-resize.html: Added.
18:38 Changeset [110525] by haraken@chromium.org

[V8][Refactoring] Remove getWrapper() and getWrapperSlow()
https://bugs.webkit.org/show_bug.cgi?id=80920

Reviewed by Adam Barth.

Now getWrapper() is the same as getExistingWrapper().
getWrapperSlow() is the same as getExistingWrapperSlow().
This patch removes getWrapper() and getWrapperSlow().
Also this patch renames getExistingWrapper() to getCachedWrapper().

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::getWrapperSlow):

  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getWrapper):
(V8DOMWrapper):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::toV8Slow):

18:37 Changeset [110524] by arv@chromium.org

[V8] Use v8::V8::AddHiddenReferences instead of SetHiddenValue
https://bugs.webkit.org/show_bug.cgi?id=80880

Reviewed by Adam Barth.

Source/WebCore:

We used to add a hidden property in the getter to the returned wrapper.
With this patch we instead handle the liveness of the wrapper in the GC phase by
calling v8::V8::AddHiddenReference.

To reduce the amount of custom code we need, the V8 code generator now supports
GenerateIsReachable (as well as CustomIsReachable) which, even though different
from the JSC attribute, is used in the same cases and takes the same values (even though
at the moment not all JSC values are supported by V8).

No new tests. Covered by existing tests.

  • Target.pri:
  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorJS.pm:

(GetGenerateIsReachable):
(GetCustomIsReachable):
(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(NeedsToVisitDOMWrapper):
(GetGenerateIsReachable):
(GetCustomIsReachable):
(GenerateVisitDOMWrapper):
(GenerateHeader):
(GenerateNamedConstructorCallback):
(GenerateImplementation):

  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):

  • bindings/v8/NPV8Object.cpp:

(WebCore::npObjectTypeInfo):

  • bindings/v8/V8GCController.cpp:

(WebCore::GrouperVisitor::visitDOMWrapper):

  • bindings/v8/WrapperTypeInfo.h:

(WebCore):
(WrapperTypeInfo):

  • bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Removed.
  • bindings/v8/custom/V8DOMStringMapCustom.cpp:
  • bindings/v8/custom/V8DOMTokenListCustom.cpp: Removed.
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore):

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:
  • bindings/v8/custom/V8StyleSheetCustom.cpp:

(WebCore::toV8):

  • css/CSSStyleSheet.idl:
  • css/StyleSheet.idl:
  • dom/DOMStringMap.idl:
  • dom/NamedNodeMap.idl:
  • html/DOMTokenList.idl:
  • html/track/TextTrackList.idl:

LayoutTests:

  • platform/chromium/test_expectations.txt:
18:31 Changeset [110523] by jberlin@webkit.org

More Windows build fixing.

  • DumpRenderTree/win/AccessibilityControllerWin.cpp:
  • DumpRenderTree/win/EditingDelegate.cpp:
  • DumpRenderTree/win/EventSender.cpp:
  • DumpRenderTree/win/FrameLoadDelegate.cpp:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp:
  • DumpRenderTree/win/UIDelegate.cpp:
18:29 Changeset [110522] by dpranke@chromium.org

Remove obsolete 'CPU' modifier.

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
18:27 LayoutUnit edited by leviw@chromium.org
(diff)
18:16 Changeset [110521] by barraclough@apple.com

Object.defineProperty doesn't respect attributes when applied to the Global Object
https://bugs.webkit.org/show_bug.cgi?id=38636
Object.defineProperty doesn't create property on Global Object in the presence of a setter in the prototype chain
https://bugs.webkit.org/show_bug.cgi?id=48911

Rubber stamped by Michael Saboff.

  • fast/js/Object-defineProperty-expected.txt:
  • fast/js/script-tests/Object-defineProperty.js:
    • Added test cases for bugs #38636 & #48911.
18:13 Changeset [110520] by jberlin@webkit.org

More Windows build fixing.

  • MarshallingHelpers.cpp:
  • WebDatabaseManager.cpp:
18:10 Changeset [110519] by haraken@chromium.org

[V8][Refactoring] Make getWrapperSlow() and getExistingWrapperSlow() same
https://bugs.webkit.org/show_bug.cgi?id=80916

Reviewed by Adam Barth.

This is one of the steps for fixing bug 80841.
This patch makes getWrapperSlow() and getExistingWrapperSlow() same.
In the next patch, we will remove getExistingWrapper() and getExistingWrapperSlow().

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::getWrapperSlow):

18:05 Changeset [110518] by fpizlo@apple.com

Arithmetic use inference should be procedure-global and should run in tandem
with type propagation
https://bugs.webkit.org/show_bug.cgi?id=80819
<rdar://problem/11034006>

Reviewed by Gavin Barraclough.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • dfg/DFGArithNodeFlagsInferencePhase.cpp: Removed.
  • dfg/DFGArithNodeFlagsInferencePhase.h: Removed.
  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::isNotNegZero):
(PredictionPropagationPhase):
(JSC::DFG::PredictionPropagationPhase::isNotZero):
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::mergeDefaultArithFlags):

  • dfg/DFGVariableAccessData.h:

(JSC::DFG::VariableAccessData::VariableAccessData):
(JSC::DFG::VariableAccessData::flags):
(VariableAccessData):
(JSC::DFG::VariableAccessData::mergeFlags):

18:02 Changeset [110517] by dpranke@chromium.org

Remove obsolete chromium-gpu-* platform directories for LayoutTests baselines.

Unreviewed, baselines change.

All of the baselines are now in platform/chromium-*/platform/chromium/virtual/gpu/*.

  • platform/chromium-gpu-linux/fast/canvas/arc360-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/canvas-before-css-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/canvas-bg-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/canvas-bg-expected.txt: Removed.
  • platform/chromium-gpu-linux/fast/canvas/canvas-composite-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/canvas-resize-reset-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/canvas-text-baseline-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/canvas-transforms-during-path-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/canvasDrawingIntoSelf-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/drawImage-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/fill-stroke-clip-reset-path-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/fillrect-gradient-zero-stops-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/fillrect_gradient-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/image-pattern-rotate-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/patternfill-repeat-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/quadraticCurveTo-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/setWidthResetAfterForcedRender-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-1-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-2-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-3-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-4-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-5-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-6-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/shadow-offset-7-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/toDataURL-alpha-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/canvas/zero-size-fill-rect-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/media/mq-transform-02-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/media/mq-transform-02-expected.txt: Removed.
  • platform/chromium-gpu-linux/fast/media/mq-transform-03-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/media/mq-transform-03-expected.txt: Removed.
  • platform/chromium-gpu-linux/fast/repaint/canvas-putImageData-expected.png: Removed.
  • platform/chromium-gpu-linux/fast/repaint/canvas-putImageData-expected.txt: Removed.
  • platform/chromium-gpu-linux/media/audio-controls-rendering-expected.png: Removed.
  • platform/chromium-gpu-linux/media/controls-after-reload-expected.png: Removed.
  • platform/chromium-gpu-linux/media/controls-strict-expected.png: Removed.
  • platform/chromium-gpu-linux/media/controls-styling-expected.png: Removed.
  • platform/chromium-gpu-linux/media/controls-without-preload-expected.png: Removed.
  • platform/chromium-gpu-linux/media/media-controls-clone-expected.png: Removed.
  • platform/chromium-gpu-linux/media/media-document-audio-repaint-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-aspect-ratio-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-canvas-alpha-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-colorspace-yuv420-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-colorspace-yuv422-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-controls-rendering-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-display-toggle-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-frame-accurate-seek-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-layer-crash-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-no-audio-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-playing-and-pause-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-transformed-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-volume-slider-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-zoom-controls-expected.png: Removed.
  • platform/chromium-gpu-linux/media/video-zoom-expected.png: Removed.
  • platform/chromium-gpu-mac/canvas/philip/tests/2d.gradient.radial.cone.cylinder-expected.txt: Removed.
  • platform/chromium-gpu-mac/canvas/philip/tests/2d.line.width.basic-expected.txt: Removed.
  • platform/chromium-gpu-mac/canvas/philip/tests/2d.line.width.transformed-expected.txt: Removed.
  • platform/chromium-gpu-mac/canvas/philip/tests/2d.path.arcTo.shape.curve1-expected.txt: Removed.
  • platform/chromium-gpu-mac/canvas/philip/tests/2d.path.arcTo.shape.curve2-expected.txt: Removed.
  • platform/chromium-gpu-mac/canvas/philip/tests/2d.shadow.enable.blur-expected.txt: Removed.
  • platform/chromium-gpu-mac/canvas/philip/tests/2d.text.draw.fontface.notinpage-expected.txt: Removed.
  • platform/chromium-gpu-mac/canvas/philip/tests/2d.transformation.setTransform.skewed-expected.txt: Removed.
  • platform/chromium-gpu-mac/canvas/philip/tests/2d.transformation.transform.skewed-expected.txt: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-as-image-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-bg-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-bg-zoom-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-composite-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-composite-fill-repaint-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-composite-transformclip-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-currentColor-expected.txt: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-fillPath-shadow-expected.txt: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-shadow-expected.txt: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-text-alignment-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-text-baseline-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-transform-skewed-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/canvas-transforms-during-path-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/fillrect-gradient-zero-stops-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/fillrect_gradient-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/image-object-in-canvas-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/image-pattern-rotate-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/patternfill-repeat-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/quadraticCurveTo-expected.png: Removed.
  • platform/chromium-gpu-mac/fast/canvas/setWidthResetAfterForcedRender-expected.png: Removed.
  • platform/chromium-gpu-mac/media/controls-after-reload-expected.png: Removed.
  • platform/chromium-gpu-mac/media/controls-strict-expected.png: Removed.
  • platform/chromium-gpu-mac/media/controls-styling-expected.png: Removed.
  • platform/chromium-gpu-mac/media/controls-without-preload-expected.png: Removed.
  • platform/chromium-gpu-mac/media/video-aspect-ratio-expected.png: Removed.
  • platform/chromium-gpu-mac/media/video-controls-rendering-expected.png: Removed.
  • platform/chromium-gpu-mac/media/video-display-toggle-expected.png: Removed.
  • platform/chromium-gpu-mac/media/video-layer-crash-expected.png: Removed.
  • platform/chromium-gpu-mac/media/video-no-audio-expected.png: Removed.
  • platform/chromium-gpu-mac/media/video-playing-and-pause-expected.png: Removed.
  • platform/chromium-gpu-mac/media/video-transformed-expected.png: Removed.
  • platform/chromium-gpu-mac/media/video-volume-slider-expected.png: Removed.
  • platform/chromium-gpu-mac/media/video-zoom-controls-expected.png: Removed.
  • platform/chromium-gpu-mac/media/video-zoom-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/arc360-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-as-image-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-as-image-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-as-image-incremental-repaint-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-as-image-incremental-repaint-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-before-css-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-bg-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-bg-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-bg-zoom-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-bg-zoom-expected.txt: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-composite-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-composite-fill-repaint-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-composite-transformclip-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-empty-image-pattern-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-resize-reset-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-text-baseline-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-identity-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-infinity-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-multiply-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-nan-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-non-invertible-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-skewed-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvas-transforms-during-path-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/canvasDrawingIntoSelf-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/drawImage-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/fill-stroke-clip-reset-path-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/fillrect-gradient-zero-stops-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/fillrect_gradient-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/gradient-add-second-start-end-stop-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/image-object-in-canvas-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/image-pattern-rotate-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/patternfill-repeat-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/quadraticCurveTo-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/setWidthResetAfterForcedRender-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-1-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-2-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-3-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-4-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-5-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-6-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/shadow-offset-7-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/toDataURL-alpha-expected.png: Removed.
  • platform/chromium-gpu-win/fast/canvas/zero-size-fill-rect-expected.png: Removed.
  • platform/chromium-gpu-win/media/controls-after-reload-expected.png: Removed.
  • platform/chromium-gpu-win/media/controls-strict-expected.png: Removed.
  • platform/chromium-gpu-win/media/controls-styling-expected.png: Removed.
  • platform/chromium-gpu-win/media/controls-without-preload-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-aspect-ratio-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-canvas-alpha-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-colorspace-yuv420-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-colorspace-yuv422-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-controls-rendering-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-display-toggle-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-frame-accurate-seek-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-layer-crash-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-no-audio-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-playing-and-pause-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-transformed-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-volume-slider-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-zoom-controls-expected.png: Removed.
  • platform/chromium-gpu-win/media/video-zoom-expected.png: Removed.
  • platform/chromium-gpu/media/video-colorspace-yuv420-expected.png: Removed.
  • platform/chromium-gpu/media/video-colorspace-yuv422-expected.png: Removed.
  • platform/chromium-gpu/media/video-frame-accurate-seek-expected.png: Removed.
17:55 Changeset [110516] by dpranke@chromium.org

remove the 'gpu' group from the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=80353

Reviewed by Adam Barth.

Since those bots are obsolete, we don't need this any more.

  • TestResultServer/static-dashboards/builders.js:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:

(testPlatformAndBuildType):
(testHtmlForTestTypeSwitcherGroup):

17:53 Changeset [110515] by haraken@chromium.org

[V8] Refactor some header includes in V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=80913

Reviewed by Adam Barth.

This patch refactors some header includes in V8 bindings
required for fixing bug 80841.

No tests. No change in behavior.

  • bindings/v8/DOMDataStore.h:

(DOMDataStore):

  • bindings/v8/V8DOMMap.h:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8IsolatedContext.cpp:

(WebCore::V8IsolatedContext::isolatedContext):

  • bindings/v8/V8IsolatedContext.h:

(WebCore::V8IsolatedContext::getEntered):
(V8IsolatedContext):

  • bindings/v8/WorldContextHandle.cpp:
17:50 Changeset [110514] by dpranke@chromium.org

remove graphics_type from webkitpy.layout_tests.models.test_configuration
https://bugs.webkit.org/show_bug.cgi?id=80643

Reviewed by Ojan Vafai.

Now that the chromium-gpu ports are gone, there's no need for
the graphics_type CPU/GPU distinction. Most of this change is
just updating tests accordingly.

  • Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:

(TestExpectationEditorTests):

  • Scripts/webkitpy/layout_tests/models/test_configuration.py:

(TestConfiguration.init):
(TestConfiguration.category_order):
(TestConfiguration.str):
(TestConfiguration.repr):
(TestConfiguration.hash):
(TestConfigurationConverter.to_specifiers_list):

  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:

(make_mock_all_test_configurations_set):
(TestConfigurationTest.test_items):
(TestConfigurationTest.test_keys):
(TestConfigurationTest.test_str):
(TestConfigurationTest.test_repr):
(TestConfigurationTest.test_hash):
(TestConfigurationTest.test_hash.query_unknown_key):
(TestConfigurationTest.test_eq):
(TestConfigurationTest.test_values):
(SpecifierSorterTest.test_specifier_priority):
(SpecifierSorterTest.test_sort_specifiers):
(TestConfigurationConverterTest.test_to_config_set):
(TestConfigurationConverterTest.test_macro_expansion):
(TestConfigurationConverterTest.test_to_specifier_lists):
(TestConfigurationConverterTest.test_converter_macro_collapsing):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(test_error_on_different_build_type):
(TestExpectationSerializerTests.test_parsed_to_string):
(TestExpectationSerializerTests.test_reconstitute_only_these):

  • Scripts/webkitpy/layout_tests/port/apple.py:

(ApplePort._generate_all_test_configurations):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.init):
(Port.name):
(Port.version):
(Port.test_configuration):

  • Scripts/webkitpy/layout_tests/port/builders.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort):
(ChromiumPort._generate_all_test_configurations):

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:

(ChromiumLinuxPort.init):

  • Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:

(ChromiumLinuxPortTest.test_check_illegal_port_names):

  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:

(ChromiumMacPortTest.test_baseline_path):

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumPortTest.test_all_test_configurations):

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort._generate_all_test_configurations):

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort._generate_all_test_configurations):

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort._generate_all_test_configurations):

  • Scripts/webkitpy/layout_tests/port/test.py:

(TestPort.all_test_configurations):
(TestPort._all_build_types):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:

(BuildCoverageExtrapolatorTest.test_extrapolate):
(GardeningExpectationsUpdaterTest.test_unknown_failure_type):
(GardeningExpectationsUpdaterTest.test_add_new_expectation):
(GardeningExpectationsUpdaterTest.test_replace_old_expectation):
(GardeningExpectationsUpdaterTest.test_pass_expectation):
(GardeningExpectationsUpdaterTest.test_supplement_old_expectation):
(GardeningExpectationsUpdaterTest.test_spurious_updates):

17:43 Changeset [110513] by dpranke@chromium.org

_runtime_feature_list isn't supported on Apple Mac DRT
https://bugs.webkit.org/show_bug.cgi?id=80906

Reviewed by Eric Seidel.

It looks like this feature is actually only supported on the Win
DRT port, so this patch reworks the code to make that clearer
and reduce unnecessary overrides.

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort._path_to_webcore_library):

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort._path_to_webcore_library):

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort._skipped_file_search_paths):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._runtime_feature_list):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(TestWebKitPort.init):
(TestWebKitPort.all_test_configurations):
(test_skipped_directories_for_features):

  • Scripts/webkitpy/layout_tests/port/win.py:

(WinPort):
(WinPort._runtime_feature_list):

  • Scripts/webkitpy/layout_tests/port/win_unittest.py:

(WinPortTest.test_operating_system):
(WinPortTest):
(WinPortTest.test_runtime_feature_list):

17:31 Changeset [110512] by weinig@apple.com

Fix typo in PageClientImpl where we were overriding viewLayerHostingMode with
a function called layerHostingMode.

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::viewLayerHostingMode):
Update name and add OVERRIDE to catch this in the future.

17:22 Changeset [110511] by commit-queue@webkit.org

Unreviewed, rolling out r110501.
http://trac.webkit.org/changeset/110501
https://bugs.webkit.org/show_bug.cgi?id=80908

Broke the Apple-Win build (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-12

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.xcodeproj/project.pbxproj:
  • fileapi/DirectoryEntry.cpp: Renamed from Source/WebCore/Modules/filesystem/DirectoryEntry.cpp.

(WebCore):
(WebCore::DirectoryEntry::DirectoryEntry):
(WebCore::DirectoryEntry::createReader):
(WebCore::DirectoryEntry::getFile):
(WebCore::DirectoryEntry::getDirectory):
(WebCore::DirectoryEntry::removeRecursively):

  • fileapi/DirectoryEntry.h: Renamed from Source/WebCore/Modules/filesystem/DirectoryEntry.h.

(WebCore):
(DirectoryEntry):
(WebCore::DirectoryEntry::create):
(WebCore::DirectoryEntry::isDirectory):

  • fileapi/DirectoryEntry.idl: Renamed from Source/WebCore/Modules/filesystem/DirectoryEntry.idl.
  • fileapi/DirectoryEntrySync.cpp: Renamed from Source/WebCore/Modules/filesystem/DirectoryEntrySync.cpp.

(WebCore):
(WebCore::DirectoryEntrySync::DirectoryEntrySync):
(WebCore::DirectoryEntrySync::createReader):
(WebCore::DirectoryEntrySync::getFile):
(WebCore::DirectoryEntrySync::getDirectory):
(WebCore::DirectoryEntrySync::removeRecursively):

  • fileapi/DirectoryEntrySync.h: Renamed from Source/WebCore/Modules/filesystem/DirectoryEntrySync.h.

(WebCore):
(DirectoryEntrySync):
(WebCore::DirectoryEntrySync::create):
(WebCore::DirectoryEntrySync::isDirectory):

  • fileapi/DirectoryEntrySync.idl: Renamed from Source/WebCore/Modules/filesystem/DirectoryEntrySync.idl.
  • fileapi/DirectoryReader.cpp: Renamed from Source/WebCore/Modules/filesystem/DirectoryReader.cpp.

(WebCore):
(WebCore::DirectoryReader::DirectoryReader):
(WebCore::DirectoryReader::readEntries):

  • fileapi/DirectoryReader.h: Renamed from Source/WebCore/Modules/filesystem/DirectoryReader.h.

(WebCore):
(DirectoryReader):
(WebCore::DirectoryReader::create):
(WebCore::DirectoryReader::filesystem):

  • fileapi/DirectoryReader.idl: Renamed from Source/WebCore/Modules/filesystem/DirectoryReader.idl.
  • fileapi/DirectoryReaderBase.h: Renamed from Source/WebCore/Modules/filesystem/DirectoryReaderBase.h.

(WebCore):
(DirectoryReaderBase):
(WebCore::DirectoryReaderBase::filesystem):
(WebCore::DirectoryReaderBase::setHasMoreEntries):
(WebCore::DirectoryReaderBase::DirectoryReaderBase):

  • fileapi/DirectoryReaderSync.cpp: Renamed from Source/WebCore/Modules/filesystem/DirectoryReaderSync.cpp.

(WebCore):
(WebCore::DirectoryReaderSync::DirectoryReaderSync):
(WebCore::DirectoryReaderSync::readEntries):

  • fileapi/DirectoryReaderSync.h: Renamed from Source/WebCore/Modules/filesystem/DirectoryReaderSync.h.

(WebCore):
(DirectoryReaderSync):
(WebCore::DirectoryReaderSync::create):

  • fileapi/DirectoryReaderSync.idl: Renamed from Source/WebCore/Modules/filesystem/DirectoryReaderSync.idl.
17:15 Changeset [110510] by thakis@chromium.org

[chromium/mac] Make sure libWebKitSystemInterface.a doesn't contain ppc object files.
https://bugs.webkit.org/show_bug.cgi?id=80902

Reviewed by Adam Barth.

Follow-up to http://codereview.chromium.org/9638015/

No intended behavior change.

  • WebCore.gyp/mac/adjust_visibility.sh:
17:14 Changeset [110509] by leviw@chromium.org

Fixing/cleaning up rounding in RenderReplaced classes, and removing an unnecessary static_cast in RenderFrameSet.

17:09 Changeset [110508] by eae@chromium.org

Qt build fixes for branch.

17:09 Changeset [110507] by jer.noble@apple.com

WebCore: Add support for AudioNode "tailTime()" and "latencyTime()"
https://bugs.webkit.org/show_bug.cgi?id=74750

Reviewed by Chris Rogers.

No new tests; optimization of existing code path, so covered by existing tests.

To account for AudioNodes which may generate non-silent audio when fed silent input
for a certain amount of time after the last non-silent audio data, add two new virtual
functions tailTime() and latencyTime().

  • webaudio/AudioNode.h:

(WebCore::AudioNode::tailTime): Added. Pure virtual.
(WebCore::AudioNode::latencyTime): Added. Pure virtual.

  • platform/audio/AudioProcessor.h:

(WebCore::AudioProcessor::tailTime): Added. Pure virtual.
(WebCore::AudioProcessor::latencyTime): Added. Pure virtual.

  • platform/audio/AudioDSPKernel.h:

(WebCore::AudioDSPKernel::tailTime): Added. Pure virtual.
(WebCore::AudioDSPKernel::latencyTime): Added. Pure virtual.

Added tailTime() and latencyTime() overrides to the following classes:

  • platform/audio/AudioDSPKernelProcessor.cpp:

(WebCore::AudioDSPKernelProcessor::tailTime):
(WebCore::AudioDSPKernelProcessor::latencyTime):

  • platform/audio/AudioDSPKernelProcessor.h:
  • platform/audio/DynamicsCompressor.h:

(WebCore::DynamicsCompressor::tailTime):
(WebCore::DynamicsCompressor::latencyTime):

  • platform/audio/EqualPowerPanner.h:
  • platform/audio/HRTFPanner.cpp:

(WebCore::HRTFPanner::tailTime):
(WebCore::HRTFPanner::latencyTime):

  • platform/audio/HRTFPanner.h:
  • platform/audio/Panner.h:
  • webaudio/AudioBasicProcessorNode.cpp:

(WebCore::AudioBasicProcessorNode::tailTime):
(WebCore::AudioBasicProcessorNode::latencyTime):

  • webaudio/AudioBasicProcessorNode.h:
  • webaudio/AudioChannelMerger.h:
  • webaudio/AudioChannelSplitter.h:
  • webaudio/AudioDestinationNode.h:
  • webaudio/AudioGainNode.h:
  • webaudio/AudioPannerNode.h:
  • webaudio/AudioSourceNode.h:
  • webaudio/BiquadDSPKernel.cpp:

(WebCore::BiquadDSPKernel::tailTime):
(WebCore::BiquadDSPKernel::latencyTime):

  • webaudio/BiquadDSPKernel.h:
  • webaudio/BiquadFilterNode.h:
  • webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::tailTime):
(WebCore::ConvolverNode::latencyTime):

  • webaudio/ConvolverNode.h:
  • webaudio/DelayDSPKernel.cpp:

(WebCore::DelayDSPKernel::tailTime):
(WebCore::DelayDSPKernel::latencyTime):

  • webaudio/DelayDSPKernel.h:
  • webaudio/DelayProcessor.h:
  • webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::tailTime):
(WebCore::DynamicsCompressorNode::latencyTime):

  • webaudio/DynamicsCompressorNode.h:
  • webaudio/JavaScriptAudioNode.cpp:

(WebCore::JavaScriptAudioNode::tailTime):
(WebCore::JavaScriptAudioNode::latencyTime):

  • webaudio/JavaScriptAudioNode.h:
  • webaudio/RealtimeAnalyserNode.h:
  • webaudio/WaveShaperDSPKernel.h:

The following functions were added as support for the new AudioNode and AudioProcessor functions:

  • platform/audio/Biquad.cpp:

(WebCore::Biquad::latencyFrames):

  • platform/audio/Biquad.h:
  • platform/audio/Reverb.cpp:

(WebCore::Reverb::latencyFrames):

  • platform/audio/ReverbConvolver.h:

(WebCore::ReverbConvolver::latencyFrames):

The following functions were made const-correct:

  • platform/audio/HRTFPanner.h:

(WebCore::HRTFPanner::fftSize):

  • platform/audio/Reverb.h:

(WebCore::Reverb::impulseResponseLength):

17:07 Changeset [110506] by andersca@apple.com

WebTileLayers should be opaque
https://bugs.webkit.org/show_bug.cgi?id=80907
<rdar://problem/11034390>

Reviewed by Andreas Kling.

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::createTileLayer):
Call -[CALayer setOpaque:] on the newly created WebTileLayer.

17:05 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
16:51 Changeset [110505] by eae@chromium.org

Fix rounding in scrollbar rect calculations
https://bugs.webkit.org/show_bug.cgi?id=80894

Reviewed by Eric Seidel.

Fix usage of subpixel units in RenderScrollbar::buttonRect and
RenderScrollbar::trackRect.

No new tests, no new functionality.

  • rendering/LayoutTypes.h:

(WebCore::isIntegerValue):
Add dummy isIntegerValue function, will be replaced with actual
implementation once LayoutUnit is remapped to FractionalLayoutUnit.

  • rendering/RenderScrollbar.cpp:

(WebCore::RenderScrollbar::buttonRect):
(WebCore::RenderScrollbar::trackRect):
Change rect calculations to use pixel snapped values.

  • rendering/RenderScrollbarPart.h:

(RenderScrollbarPart):
(WebCore::RenderScrollbarPart::marginTop):
(WebCore::RenderScrollbarPart::marginBottom):
(WebCore::RenderScrollbarPart::marginLeft):
(WebCore::RenderScrollbarPart::marginRight):
Add ASSERT to ensure that scrollbar parts are always aligned to device
pixels.

16:46 Changeset [110504] by commit-queue@webkit.org

[GObject IDL Parser] STRING argument should be HASHREF
https://bugs.webkit.org/show_bug.cgi?id=78877

Patch by C Anthony Risinger <anthony@xtfx.me> on 2012-03-12
Reviewed by Kentaro Hara.

  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateFunctions): extendedAttributes are hashes, not strings

16:43 Changeset [110503] by jberlin@webkit.org

More Windows build fixing.

Use fully qualified paths for WTF headers.

  • platform/graphics/cg/ImageSourceCGWin.cpp:
  • platform/graphics/win/UniscribeController.h:
  • platform/win/DragImageCGWin.cpp:
  • platform/win/DragImageCairoWin.cpp:
  • platform/win/DragImageWin.cpp:
  • rendering/RenderThemeSafari.cpp:
16:40 Changeset [110502] by abarth@webkit.org

This baseline also applies to chromium-mac-snowleopard, so we can move
it up the fallback chain.

  • platform/chromium-mac-leopard/fast/events/scrollbar-double-click-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/events/scrollbar-double-click-expected.txt: Added.
16:38 Changeset [110501] by commit-queue@webkit.org

Move DirectoryEntry and DirectoryReader to new Modules/filesystem/ directory
https://bugs.webkit.org/show_bug.cgi?id=80625

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-03-12
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • Modules/filesystem: Added.
  • Modules/filesystem/DirectoryEntry.cpp: Copied from Source/WebCore/fileapi/DirectoryEntry.cpp.
  • Modules/filesystem/DirectoryEntry.h: Copied from Source/WebCore/fileapi/DirectoryEntry.h.
  • Modules/filesystem/DirectoryEntry.idl: Copied from Source/WebCore/fileapi/DirectoryEntry.idl.
  • Modules/filesystem/DirectoryEntrySync.cpp: Copied from Source/WebCore/fileapi/DirectoryEntrySync.cpp.
  • Modules/filesystem/DirectoryEntrySync.h: Copied from Source/WebCore/fileapi/DirectoryEntrySync.h.
  • Modules/filesystem/DirectoryEntrySync.idl: Copied from Source/WebCore/fileapi/DirectoryEntrySync.idl.
  • Modules/filesystem/DirectoryReader.cpp: Copied from Source/WebCore/fileapi/DirectoryReader.cpp.
  • Modules/filesystem/DirectoryReader.h: Copied from Source/WebCore/fileapi/DirectoryReader.h.
  • Modules/filesystem/DirectoryReader.idl: Copied from Source/WebCore/fileapi/DirectoryReader.idl.
  • Modules/filesystem/DirectoryReaderBase.h: Copied from Source/WebCore/fileapi/DirectoryReaderBase.h.
  • Modules/filesystem/DirectoryReaderSync.cpp: Copied from Source/WebCore/fileapi/DirectoryReaderSync.cpp.
  • Modules/filesystem/DirectoryReaderSync.h: Copied from Source/WebCore/fileapi/DirectoryReaderSync.h.
  • Modules/filesystem/DirectoryReaderSync.idl: Copied from Source/WebCore/fileapi/DirectoryReaderSync.idl.
  • Target.pri:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.xcodeproj/project.pbxproj:
  • fileapi/DirectoryEntry.cpp: Removed.
  • fileapi/DirectoryEntry.h: Removed.
  • fileapi/DirectoryEntry.idl: Removed.
  • fileapi/DirectoryEntrySync.cpp: Removed.
  • fileapi/DirectoryEntrySync.h: Removed.
  • fileapi/DirectoryEntrySync.idl: Removed.
  • fileapi/DirectoryReader.cpp: Removed.
  • fileapi/DirectoryReader.h: Removed.
  • fileapi/DirectoryReader.idl: Removed.
  • fileapi/DirectoryReaderBase.h: Removed.
  • fileapi/DirectoryReaderSync.cpp: Removed.
  • fileapi/DirectoryReaderSync.h: Removed.
  • fileapi/DirectoryReaderSync.idl: Removed.
16:34 Changeset [110500] by beidson@apple.com

https://bugs.webkit.org/show_bug.cgi?id=80903 InspectorDOMStorageAgent creates a Storage object which is a DOMWindowProperty - Should use the StorageArea directly

Reviewed by Tim Hatcher.

No new tests. (No behavior change)

Changed to hold the StorageArea directly and added a Frame* accessor:

  • inspector/InspectorDOMStorageResource.h:

(WebCore::InspectorDOMStorageResource::create):
(WebCore::InspectorDOMStorageResource::storageArea):
(WebCore::InspectorDOMStorageResource::frame):
(InspectorDOMStorageResource):

  • inspector/InspectorDOMStorageResource.cpp:

(WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource):

  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::didUseDOMStorage):

16:23 Changeset [110499] by abarth@webkit.org

[Skia] Release CGImage used to apply color space conversion to SkBitmap
https://bugs.webkit.org/show_bug.cgi?id=80892

Patch by Brian Salomon <bsalomon@google.com> on 2012-03-12
Reviewed by Adam Barth.

Regressions should be covered by any test that does image decode on the mac.

  • platform/image-decoders/skia/ImageDecoderSkia.cpp:

(WebCore::resolveColorSpace):

16:15 Changeset [110498] by fpizlo@apple.com

Node::op and Node::flags should be private
https://bugs.webkit.org/show_bug.cgi?id=80824
<rdar://problem/11033435>

Reviewed by Gavin Barraclough.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::mergeStateAtTail):
(JSC::DFG::AbstractState::mergeToSuccessors):

  • dfg/DFGArithNodeFlagsInferencePhase.cpp:

(JSC::DFG::ArithNodeFlagsInferencePhase::propagate):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::injectLazyOperandPrediction):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::flushArgument):
(JSC::DFG::ByteCodeParser::toInt32):
(JSC::DFG::ByteCodeParser::isJSConstant):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::linkBlock):

  • dfg/DFGCFAPhase.cpp:

(JSC::DFG::CFAPhase::performBlockCFA):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::canonicalize):
(JSC::DFG::CSEPhase::endIndexForPureCSE):
(JSC::DFG::CSEPhase::pureCSE):
(JSC::DFG::CSEPhase::byValIsPure):
(JSC::DFG::CSEPhase::clobbersWorld):
(JSC::DFG::CSEPhase::impureCSE):
(JSC::DFG::CSEPhase::globalVarLoadElimination):
(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::checkFunctionElimination):
(JSC::DFG::CSEPhase::checkStructureLoadElimination):
(JSC::DFG::CSEPhase::getByOffsetLoadElimination):
(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::getScopeChainLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(DFG):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::addShouldSpeculateInteger):
(JSC::DFG::Graph::negateShouldSpeculateInteger):
(JSC::DFG::Graph::methodOfGettingAValueProfileFor):

  • dfg/DFGNode.cpp: Removed.
  • dfg/DFGNode.h:

(DFG):
(JSC::DFG::Node::Node):
(Node):
(JSC::DFG::Node::op):
(JSC::DFG::Node::flags):
(JSC::DFG::Node::setOp):
(JSC::DFG::Node::setFlags):
(JSC::DFG::Node::mergeFlags):
(JSC::DFG::Node::filterFlags):
(JSC::DFG::Node::clearFlags):
(JSC::DFG::Node::setOpAndDefaultFlags):
(JSC::DFG::Node::mustGenerate):
(JSC::DFG::Node::isConstant):
(JSC::DFG::Node::isWeakConstant):
(JSC::DFG::Node::valueOfJSConstant):
(JSC::DFG::Node::hasVariableAccessData):
(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::resolveGlobalDataIndex):
(JSC::DFG::Node::hasArithNodeFlags):
(JSC::DFG::Node::arithNodeFlags):
(JSC::DFG::Node::setArithNodeFlag):
(JSC::DFG::Node::mergeArithNodeFlags):
(JSC::DFG::Node::hasConstantBuffer):
(JSC::DFG::Node::hasRegexpIndex):
(JSC::DFG::Node::hasVarNumber):
(JSC::DFG::Node::hasScopeChainDepth):
(JSC::DFG::Node::hasResult):
(JSC::DFG::Node::hasInt32Result):
(JSC::DFG::Node::hasNumberResult):
(JSC::DFG::Node::hasJSResult):
(JSC::DFG::Node::hasBooleanResult):
(JSC::DFG::Node::isJump):
(JSC::DFG::Node::isBranch):
(JSC::DFG::Node::isTerminal):
(JSC::DFG::Node::hasHeapPrediction):
(JSC::DFG::Node::hasFunctionCheckData):
(JSC::DFG::Node::hasStructureTransitionData):
(JSC::DFG::Node::hasStructureSet):
(JSC::DFG::Node::hasStorageAccessData):
(JSC::DFG::Node::hasFunctionDeclIndex):
(JSC::DFG::Node::hasFunctionExprIndex):
(JSC::DFG::Node::child1):
(JSC::DFG::Node::child2):
(JSC::DFG::Node::child3):
(JSC::DFG::Node::firstChild):
(JSC::DFG::Node::numChildren):

  • dfg/DFGNodeFlags.cpp: Copied from Source/JavaScriptCore/dfg/DFGNode.cpp.
  • dfg/DFGNodeFlags.h: Added.

(DFG):
(JSC::DFG::nodeUsedAsNumber):
(JSC::DFG::nodeCanTruncateInteger):
(JSC::DFG::nodeCanIgnoreNegativeZero):
(JSC::DFG::nodeMayOverflow):
(JSC::DFG::nodeCanSpeculateInteger):

  • dfg/DFGNodeType.h: Added.

(DFG):
(JSC::DFG::defaultFlags):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::vote):
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):
(JSC::DFG::PredictionPropagationPhase::fixupNode):

  • dfg/DFGRedundantPhiEliminationPhase.cpp:

(JSC::DFG::RedundantPhiEliminationPhase::run):
(JSC::DFG::RedundantPhiEliminationPhase::replacePhiChild):
(JSC::DFG::RedundantPhiEliminationPhase::updateBlockVariableInformation):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::useChildren):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
(JSC::DFG::SpeculativeJIT::compileUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compare):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGVirtualRegisterAllocationPhase.cpp:

(JSC::DFG::VirtualRegisterAllocationPhase::run):

16:10 Changeset [110497] by eae@chromium.org

Fix scrollbar rect calculations on branch.

15:59 Changeset [110496] by leviw@chromium.org

Update LayoutUnit usage in RenderMathML* classes
https://bugs.webkit.org/show_bug.cgi?id=77916

Reviewed by Eric Seidel.

The purpose of this patch is to ensure MathML rendering does not regress when
we switch to sub-pixel layout. A subsequent patch can likely improve MathML's
rendering when zoom is applied.

To accomplish this without changing the current heuristics for positioning,
we continue to use integers for sizes and locations, using pixel snapping
when communicating with other Rendering classes.

No new tests. No change in behavior.

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::paint): Cleaning up debug painting to be on
pixel boundaries instead of subpixel.

  • rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::paint): Reverting to integers for determining
the vertical offset.
(WebCore::RenderMathMLFraction::baselinePosition):

  • rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::paint): Using integers for height and width
and only accumulating pixel snapped values.
(WebCore::RenderMathMLRoot::layout): Setting padding with integers to
avoid inconsistent rounding based on the root's location.

  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::layout):

  • rendering/mathml/RenderMathMLSquareRoot.cpp:

(WebCore::RenderMathMLSquareRoot::paint): See RenderMathMLRoot.
(WebCore::RenderMathMLSquareRoot::layout): Ditto.

  • rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore::getOffsetHeight):
(WebCore::RenderMathMLUnderOver::layout):

15:57 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
15:48 Changeset [110495] by andersca@apple.com

Use smaller tiles for right and bottom edges
https://bugs.webkit.org/show_bug.cgi?id=80893
<rdar://problem/11032873>

Reviewed by Sam Weinig.

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::rectForTileIndex):
Intersect the rect with the tile cache bounds.

(WebCore::TileCache::revalidateTiles):
Resize already existing tiles if needed.

(WebCore::TileCache::createTileLayer):
This now takes a tile rect. Use setFrame instead of setting the bounds and position separately.

15:45 Changeset [110494] by enrica@apple.com

Source/WebCore: WebKit2: remove NSPasteboard access for promised data from the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=80073

Reviewed by Alexey Proskuryakov.

  • WebCore.exp.in: Added two exported methods.
  • platform/mac/FileSystemMac.mm:

(WebCore::setMetaData): Last parameter in the call to wkSetMetadataURL
needs to be wrapped in String before casting to NSString.

Source/WebKit2: WebKit2: remove NSPasteboard access for promised data from the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=80073

Reviewed by Alexey Proskuryakov.

This patch removes the last remaining access to NSPasteboard from the WebProcess.
The code in WebDragClient::declareAndWriteDragImage now packages all the data
required for the drag and the promised drag types and sends one request to the UI
process that will place the data in the NSPasteboard when appropriate.

  • UIProcess/API/mac/PageClientImpl.h: Added setPromisedData method.
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setPromisedData):

  • UIProcess/API/mac/WKView.mm:

(matchesExtensionOrEquivalent): Added.
(fileExists): Added.
(pathWithUniqueFilenameForPath): Added.
(-[WKView _setPromisedData:WebCore::withFileName:withExtension:withTitle:withURL:withVisibleURL:withArchive:WebCore::forPasteboard:]):
(-[WKView pasteboardChangedOwner:]):
(-[WKView pasteboard:provideDataForType:]):
(-[WKView namesOfPromisedFilesDroppedAtDestination:]):

  • UIProcess/API/mac/WKViewInternal.h: Added _setPromisedData.
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h: Added method for the new message.
  • UIProcess/WebPageProxy.messages.in: Added setPromisedData message.
  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::setPromisedData):

  • WebProcess/WebCoreSupport/WebDragClient.cpp:
  • WebProcess/WebCoreSupport/WebDragClient.h:
  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::WebDragClient::declareAndWriteDragImage):

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Added SetMetadataURL.

WebKitLibraries: WebKit2: remove NSPasteboard access for promised data from the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=80073

  • WebKitSystemInterface.h: Touched the file to make build system happy.
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
15:40 Changeset [110493] by abarth@webkit.org

Update expected results after http://trac.webkit.org/changeset/110480.
These results are very similar to our previous results and seem
slightly improved AFAICT.

  • platform/chromium-mac-leopard/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-disabled-color-expected.png:
  • platform/chromium-mac-leopard/fast/forms/text-style-color-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug99948-expected.png:
  • platform/chromium-mac-snowleopard/fast/block/float/032-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-disabled-color-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/text-style-color-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug99948-expected.png:
15:38 Changeset [110492] by commit-queue@webkit.org

[Blackberry] Make the process of marking all matches interruptible and asynchronous for find-in-page
https://bugs.webkit.org/show_bug.cgi?id=80831

Patch by Andy Chen <andchen@rim.com> on 2012-03-12
Reviewed by Antonio Gomes.

  • WebKitSupport/InPageSearchManager.cpp:

(BlackBerry::WebKit::InPageSearchManager::DeferredScopeStringMatches::DeferredScopeStringMatches):
(BlackBerry::WebKit::InPageSearchManager::DeferredScopeStringMatches::doTimeout):
(BlackBerry::WebKit::InPageSearchManager::InPageSearchManager):
(BlackBerry::WebKit::InPageSearchManager::~InPageSearchManager):
(BlackBerry::WebKit::InPageSearchManager::findNextString):
(BlackBerry::WebKit::InPageSearchManager::shouldSearchForText):
(BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
(BlackBerry::WebKit::InPageSearchManager::clearTextMatches):
(BlackBerry::WebKit::InPageSearchManager::frameUnloaded):
(BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
(BlackBerry::WebKit::InPageSearchManager::scopeStringMatchesSoon):
(BlackBerry::WebKit::InPageSearchManager::callScopeStringMatches):
(BlackBerry::WebKit::InPageSearchManager::cancelPendingScopingEffort):

  • WebKitSupport/InPageSearchManager.h:
15:37 Changeset [110491] by abarth@webkit.org

Restore previous expecation for chromium-mac-leopard. rniwa says this
is the right thing to do.

  • platform/chromium-mac-leopard/fast/events/scrollbar-double-click-expected.txt: Added.
15:28 Changeset [110490] by rniwa@webkit.org

Yet another Mac rebaseline.

  • editing/pasteboard/dataTransfer-setData-getData-expected.txt:
  • platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
15:24 Changeset [110489] by commit-queue@webkit.org

Convert some fast/regions pixel tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=79132

Patch by Rebecca Hauck <rhauck@adobe.com> on 2012-03-12
Reviewed by Dirk Schulze.

  • fast/regions/floats-basic-in-variable-width-regions-expected.html: Added.
  • fast/regions/floats-basic-in-variable-width-regions.html:
  • platform/chromium/test_expectations.txt:
  • platform/efl/fast/regions/floats-basic-in-variable-width-regions-expected.png: Removed.
  • platform/efl/fast/regions/floats-basic-in-variable-width-regions-expected.txt: Removed.
  • platform/mac/fast/regions/floats-basic-in-variable-width-regions-expected.png: Removed.
  • platform/mac/fast/regions/floats-basic-in-variable-width-regions-expected.txt: Removed.
15:22 Changeset [110488] by ap@apple.com

clang build fix

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::convertToLength): Reorder
boolean operators, so that a warning about "use of logical
with constant operand" doesn't

appear.

15:17 Changeset [110487] by inferno@chromium.org

Crash in Text::splitText due to mutation events.
https://bugs.webkit.org/show_bug.cgi?id=80828

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/text/split-text-crash.xhtml

  • dom/Range.cpp:

(WebCore::Range::insertNode): replace m_start.container() calls with ref protected node.

LayoutTests:

  • fast/text/split-text-crash-expected.txt: Added.
  • fast/text/split-text-crash.xhtml: Added.
14:59 Changeset [110486] by abarth@webkit.org

[chromium] Fix clang build for CCOcclusionTracker tests
https://bugs.webkit.org/show_bug.cgi?id=80891

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-12
Reviewed by Adam Barth.

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore::CCOcclusionTrackerTest::createRoot):
(WebCore::CCOcclusionTrackerTest::createLayer):
(WebCore::CCOcclusionTrackerTest::createDrawingLayer):

14:59 Changeset [110485] by kbr@google.com

Null argument to texSubImage2D crashes
https://bugs.webkit.org/show_bug.cgi?id=80778

Reviewed by Dean Jackson.

Source/WebCore:

Generate INVALID_VALUE OpenGL error upon receiving null argument.
Final behavior still being decided on public-webgl mailing list.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::texImage2D):
(WebCore::WebGLRenderingContext::texSubImage2D):
(WebCore::WebGLRenderingContext::validateTexFuncData):

  • html/canvas/WebGLRenderingContext.h:

LayoutTests:

Updated tex-sub-image-2d-bad-args test to verify new behavior.

  • fast/canvas/webgl/tex-sub-image-2d-bad-args-expected.txt:
  • fast/canvas/webgl/tex-sub-image-2d-bad-args.html:
14:54 Changeset [110484] by macpherson@chromium.org

Remove CSSStyleSelector's convertToLength method and use CSSPrimitiveValue's version directly.
https://bugs.webkit.org/show_bug.cgi?id=80484

Reviewed by Julien Chaffraix.

No new tests / code cleanup only.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::convertToLength):

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyClip::convertToLength):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

14:52 Changeset [110483] by senorblanco@chromium.org

[chromium] Restore canvas2D acceleration after context loss.
https://bugs.webkit.org/show_bug.cgi?id=80629

Reviewed by James Robinson.

Covered by existing canvas tests, and manual testing (killing the GPU
process).

Source/WebCore:

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::create):
(WebCore::Canvas2DLayerChromium::Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::setNeedsDisplayRect):
(WebCore::Canvas2DLayerChromium::drawsContent):
(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):

  • platform/graphics/chromium/Canvas2DLayerChromium.h:

(Canvas2DLayerChromium):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::applyFilters):

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp:

(SharedGraphicsContext3DImpl):
(WebCore::SharedGraphicsContext3DImpl::SharedGraphicsContext3DImpl):
(WebCore::SharedGraphicsContext3DImpl::get):
(WebCore):
(WebCore::SharedGraphicsContext3D::get):

  • platform/graphics/gpu/SharedGraphicsContext3D.h:

(SharedGraphicsContext3D):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::createAcceleratedCanvas):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::PlatformContextSkia):
(WebCore):

  • platform/graphics/skia/PlatformContextSkia.h:

(WebCore):
(WebCore::PlatformContextSkia::isAccelerated):
(WebCore::PlatformContextSkia::setAccelerated):
(PlatformContextSkia):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::sharedGraphicsContext3D):

14:51 Changeset [110482] by leviw@chromium.org

Fixing misaligned painting in RenderListBox and RenderFileUploadControl. Correcting width calculations for platform code in RenderFileUploadControl. Changing RenderLayer::absoluteBoundingBox to a pixel snapped IntRect, which simplifies platform code.

14:36 Changeset [110481] by staikos@webkit.org

It doesn't make sense to return const unsigned, and GCC warns about it.
Remove const.
https://bugs.webkit.org/show_bug.cgi?id=80790

Reviewed by Antonio Gomes.

  • platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.h:

(WebCore::ComplexTextController::length):
(WebCore::ComplexTextController::numCodePoints):
(WebCore::ComplexTextController::offsetX):

14:33 Changeset [110480] by bdakin@apple.com

https://bugs.webkit.org/show_bug.cgi?id=80888
Clear background for NSTextFieldCell is unreliable and not necessary
-and corresponding-
<rdar://problem/10663710>

Reviewed by Dan Bernstein.

With http://trac.webkit.org/changeset/104240 I thought it was necessary to
make NSTextFieldCells draw with a clear background in order to allow styled
text fields. That is not actually necessary; we just had a different bug
where isControlStyled() was only checking for styled borders on text fields.
Text fields can also be styled with backgrounds, so they need the full check.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::isControlStyled):
(WebCore::RenderThemeMac::textField):

14:28 Changeset [110479] by cevans@google.com

Merge 110111
BUG=117226
Review URL: https://chromiumcodereview.appspot.com/9689032

14:17 Changeset [110478] by commit-queue@webkit.org

Cleanup obsolete files.
https://bugs.webkit.org/show_bug.cgi?id=80737

Patch by Scott Byer <scottbyer@chromium.org> on 2012-03-12
Reviewed by James Robinson.

.:

  • wscript:

Source/WebCore:

No new code.

  • GNUmakefile.list.am:
  • PlatformWinCE.cmake:
  • Target.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • platform/ScrollAnimatorWin.cpp: Removed.
  • platform/ScrollAnimatorWin.h: Removed.
14:15 Changeset [110477] by commit-queue@webkit.org

Make texImage2D error for wrong size ArrayBufferView more helpful
https://bugs.webkit.org/show_bug.cgi?id=80868

It took me about 30 minutes to figure out my texImage2D was failing
not because my ArrayBufferView was too small but because the default
alignment is 4. A better error message might help devs find this issue
faster.

Patch by Gregg Tavares <gman@google.com> on 2012-03-12
Reviewed by Kenneth Russell.

No new tests as no new functionality.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::validateTexFuncData):

14:08 Changeset [110476] by dglazkov@chromium.org

4 shadow DOM tests fail on Mac port
https://bugs.webkit.org/show_bug.cgi?id=80869

Reviewed by Ryosuke Niwa.

  • fast/dom/shadow/content-element-move.html: Changed to use ensureShadowRoot.
  • fast/dom/shadow/iframe-shadow.html: Changed to use WebKitShadowRoot polyfil.
  • fast/dom/shadow/resources/polyfill.js: Added.
  • fast/dom/shadow/shadow-on-image.html: Changed to use WebKitShadowRoot polyfil.
  • platform/wk2/Skipped: Added a test that should have been skipped when landed.
14:07 Changeset [110475] by alexis.menard@openbossa.org

Update include path of the test scripts after r110470.

Reviewed by Philippe Normand.

  • fast/dom/HTMLSelectElement/select-selectedIndex-multiple.html:
  • fast/dom/HTMLSelectElement/select-selectedIndex.html:
  • fast/dom/HTMLSelectElement/select-selectedOptions.html:
14:04 Changeset [110474] by adamk@chromium.org

Add test expectations accidentally left out of r110465.

  • fast/mutation/delivery-order-expected.txt: Added.
14:01 Changeset [110473] by cevans@google.com

Merge 110139
BUG=117226

13:47 Changeset [110472] by rniwa@webkit.org

Mac rebaseline. Offset is always 700px now.

  • platform/mac/fast/events/scrollbar-double-click-expected.txt: Removed.
  • platform/win/fast/events/scrollbar-double-click-expected.txt: Removed.
13:43 Changeset [110471] by eae@chromium.org

Merge trunk changes up intil r110435 into subpixel branch.

13:33 Changeset [110470] by alexis.menard@openbossa.org

Move <select> related layout tests in the place they should be.

Reviewed by Andreas Kling.

  • fast/dom/HTMLSelectElement/select-selectedIndex-bug-12942-expected.txt: Added.
  • fast/dom/HTMLSelectElement/select-selectedIndex-bug-12942.html: Added.
  • fast/dom/HTMLSelectElement/select-selectedIndex-expected.txt: Added.
  • fast/dom/HTMLSelectElement/select-selectedIndex-multiple-expected.txt: Added.
  • fast/dom/HTMLSelectElement/select-selectedIndex-multiple.html: Added.
  • fast/dom/HTMLSelectElement/select-selectedIndex.html: Added.
  • fast/dom/HTMLSelectElement/select-selectedOptions-expected.txt: Added.
  • fast/dom/HTMLSelectElement/select-selectedOptions.html: Added.
  • fast/dom/select-selectedIndex-bug-12942-expected.txt: Removed.
  • fast/dom/select-selectedIndex-bug-12942.html: Removed.
  • fast/dom/select-selectedIndex-expected.txt: Removed.
  • fast/dom/select-selectedIndex-multiple-expected.txt: Removed.
  • fast/dom/select-selectedIndex-multiple.html: Removed.
  • fast/dom/select-selectedIndex.html: Removed.
  • fast/dom/select-selectedOptions-expected.txt: Removed.
  • fast/dom/select-selectedOptions.html: Removed.
13:26 Changeset [110469] by timothy_horton@apple.com

Infinite repaint loop with SVGImageCache and deferred repaint timers
https://bugs.webkit.org/show_bug.cgi?id=78315
<rdar://problem/10651634>

Reviewed by Nikolas Zimmermann.

Only defer image redraw on a timer if we're in layout. This breaks
the repaint loop while still preventing us from drawing inside layout.

Completely disable repaint during relayout inside SVGImage::drawSVGToImageBuffer,
preventing deferred repaint timers from being started during that process.

No new tests, as the problem only occurs in a nonstandard configuration.

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::endDeferredRepaints):
(WebCore::FrameView::startDeferredRepaintTimer):
(WebCore):
(WebCore::FrameView::doDeferredRepaints):
(WebCore::FrameView::deferredRepaintTimerFired):
(WebCore::FrameView::beginDisableRepaints):
(WebCore::FrameView::endDisableRepaints):

  • page/FrameView.h:

(FrameView):
(WebCore::FrameView::repaintsDisabled):

  • rendering/RenderView.cpp:

(WebCore::RenderView::shouldRepaint):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawSVGToImageBuffer):
(WebCore::SVGImage::draw):
(WebCore::SVGImage::frameView):
(WebCore):

  • svg/graphics/SVGImage.h:

(WebCore):

  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::imageContentChanged):
(WebCore::SVGImageCache::redraw):
(WebCore::SVGImageCache::redrawTimerFired):
(WebCore):

  • svg/graphics/SVGImageCache.h:

(SVGImageCache):

13:26 Changeset [110468] by dgrogan@chromium.org

IndexedDB: layout test style update
https://bugs.webkit.org/show_bug.cgi?id=80555

Change layoutTestController.waitUntilDone to var jsTestIsAsync = true
and idb-specific done() to finishJSTest();

Following the uniform style results in less overall code and makes
them easier to convert to worker layout tests.

Reviewed by Tony Chang.

  • storage/indexeddb/constants.html:
  • storage/indexeddb/create-and-remove-object-store.html:
  • storage/indexeddb/create-object-store-options.html:
  • storage/indexeddb/createObjectStore-name-argument-required.html:
  • storage/indexeddb/createObjectStore-null-name.html:
  • storage/indexeddb/cursor-continue.html:
  • storage/indexeddb/cursor-delete.html:
  • storage/indexeddb/cursor-inconsistency.html:
  • storage/indexeddb/cursor-index-delete.html:
  • storage/indexeddb/cursor-key-order.html:
  • storage/indexeddb/cursor-primary-key-order.html:
  • storage/indexeddb/cursor-reverse-bug.html:
  • storage/indexeddb/cursor-skip-deleted.html:
  • storage/indexeddb/cursor-update-value-argument-required.html:
  • storage/indexeddb/cursor-update.html:
  • storage/indexeddb/data-corruption.html:
  • storage/indexeddb/database-basics.html:
  • storage/indexeddb/database-name-undefined.html:
  • storage/indexeddb/database-odd-names.html:
  • storage/indexeddb/database-quota.html:
  • storage/indexeddb/delete-closed-database-object.html:
  • storage/indexeddb/delete-range.html:
  • storage/indexeddb/deleteIndex.html:
  • storage/indexeddb/deleteObjectStore-name-argument-required.html:
  • storage/indexeddb/deleteObjectStore-null-name.html:
  • storage/indexeddb/duplicates.html:
  • storage/indexeddb/error-causes-abort-by-default.html:
  • storage/indexeddb/exception-in-event-aborts-expected.txt:
  • storage/indexeddb/exception-in-event-aborts.html:
  • storage/indexeddb/factory-basics.html:
  • storage/indexeddb/factory-cmp.html:
  • storage/indexeddb/factory-deletedatabase-interactions.html:
  • storage/indexeddb/factory-deletedatabase.html:
  • storage/indexeddb/index-count.html:
  • storage/indexeddb/index-cursor.html:
  • storage/indexeddb/index-get-key-argument-required.html:
  • storage/indexeddb/index-multientry.html:
  • storage/indexeddb/index-unique.html:
  • storage/indexeddb/invalid-keys.html:
  • storage/indexeddb/key-generator.html:
  • storage/indexeddb/key-sort-order-across-types.html:
  • storage/indexeddb/key-sort-order-date.html:
  • storage/indexeddb/key-type-array.html:
  • storage/indexeddb/key-type-infinity.html:
  • storage/indexeddb/keypath-basics.html:
  • storage/indexeddb/keypath-edges.html:
  • storage/indexeddb/keypath-fetch-key.html:
  • storage/indexeddb/keyrange-required-arguments.html:
  • storage/indexeddb/keyrange.html:
  • storage/indexeddb/list-ordering.html:
  • storage/indexeddb/mozilla/add-twice-failure.html:
  • storage/indexeddb/mozilla/autoincrement-indexes.html:
  • storage/indexeddb/mozilla/bad-keypath.html:
  • storage/indexeddb/mozilla/clear.html:
  • storage/indexeddb/mozilla/create-index-unique.html:
  • storage/indexeddb/mozilla/create-index-with-integer-keys.html:
  • storage/indexeddb/mozilla/create-objectstore-basics.html:
  • storage/indexeddb/mozilla/create-objectstore-null-name.html:
  • storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html:
  • storage/indexeddb/mozilla/cursor-mutation.html:
  • storage/indexeddb/mozilla/cursor-update-updates-indexes.html:
  • storage/indexeddb/mozilla/cursors.html:
  • storage/indexeddb/mozilla/delete-result.html:
  • storage/indexeddb/mozilla/event-source.html:
  • storage/indexeddb/mozilla/global-data.html:
  • storage/indexeddb/mozilla/indexes.html:
  • storage/indexeddb/mozilla/key-requirements-delete-null-key.html:
  • storage/indexeddb/mozilla/key-requirements-inline-and-passed.html:
  • storage/indexeddb/mozilla/key-requirements-put-no-key.html:
  • storage/indexeddb/mozilla/key-requirements-put-null-key.html:
  • storage/indexeddb/mozilla/key-requirements.html:
  • storage/indexeddb/mozilla/object-cursors.html:
  • storage/indexeddb/mozilla/object-identity.html:
  • storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put.html:
  • storage/indexeddb/mozilla/object-store-remove-values.html:
  • storage/indexeddb/mozilla/objectstorenames.html:
  • storage/indexeddb/mozilla/odd-result-order.html:
  • storage/indexeddb/mozilla/open-database-null-name.html:
  • storage/indexeddb/mozilla/put-get-values.html:
  • storage/indexeddb/mozilla/readonly-transactions.html:
  • storage/indexeddb/mozilla/readwrite-transactions.html:
  • storage/indexeddb/mozilla/readyState.html:
  • storage/indexeddb/mozilla/remove-index.html:
  • storage/indexeddb/mozilla/remove-objectstore.html:
  • storage/indexeddb/mozilla/versionchange-abort.html:
  • storage/indexeddb/mozilla/versionchange.html:
  • storage/indexeddb/mutating-cursor.html:
  • storage/indexeddb/objectStore-required-arguments.html:
  • storage/indexeddb/objectstore-autoincrement.html:
  • storage/indexeddb/objectstore-clear.html:
  • storage/indexeddb/objectstore-count.html:
  • storage/indexeddb/objectstore-cursor.html:
  • storage/indexeddb/objectstore-removeobjectstore.html:
  • storage/indexeddb/odd-strings.html:
  • storage/indexeddb/open-close-version.html:
  • storage/indexeddb/open-cursor.html:
  • storage/indexeddb/open-during-transaction.html:
  • storage/indexeddb/queued-commands.html:
  • storage/indexeddb/readonly-properties.html:
  • storage/indexeddb/readonly.html:
  • storage/indexeddb/request-event-propagation.html:
  • storage/indexeddb/resources/shared.js:

(unexpectedSuccessCallback):
(unexpectedErrorCallback):
(unexpectedAbortCallback):
(unexpectedCompleteCallback):
(unexpectedBlockedCallback):

  • storage/indexeddb/setVersion-null.html:
  • storage/indexeddb/setVersion-undefined.html:
  • storage/indexeddb/set_version_blocked.html:
  • storage/indexeddb/set_version_queue.html:
  • storage/indexeddb/structured-clone.html:
  • storage/indexeddb/transaction-abort-with-js-recursion-cross-frame.html:
  • storage/indexeddb/transaction-abort-with-js-recursion.html:
  • storage/indexeddb/transaction-abort.html:
  • storage/indexeddb/transaction-after-close.html:
  • storage/indexeddb/transaction-and-objectstore-calls.html:
  • storage/indexeddb/transaction-crash-on-abort.html:
  • storage/indexeddb/transaction-event-propagation.html:
  • storage/indexeddb/transaction-read-only.html:
  • storage/indexeddb/transaction-rollback.html:
  • storage/indexeddb/transaction-storeNames-required.html:
  • storage/indexeddb/two-version-changes.html:
  • storage/indexeddb/value-undefined.html:
  • storage/indexeddb/values-odd-types.html:
  • storage/indexeddb/version-change-abort-expected.txt:
  • storage/indexeddb/version-change-abort.html:
  • storage/indexeddb/version-change-exclusive.html:
  • storage/indexeddb/versionchangerequest-activedomobject.html:
13:25 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
13:24 Changeset [110467] by jamesr@google.com

Merge 109263 - [chromium] Don't let invalidation for next frame prevent tile upload
https://bugs.webkit.org/show_bug.cgi?id=79841

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-29
Reviewed by James Robinson.

Source/WebCore:

We currently don't push dirty tiles to the impl thread so there are no
tiles with garbage data on the impl thread. However, this judgement is
overzealous and blocks tiles that get invalidated by WebKit for the
next frame during the paint of the current frame.

Instead, check if a tile is dirty and was not painted for the current
frame when deciding to push the tile to the impl thread. This requires
that we know if a tile was painted during the current frame, which we
can do if we always reset m_updateRect to be empty each frame.

New unit tests: TiledLayerChromiumTest.pushTilesMarkedDirtyDuringPaint

TiledLayerChromiumTest.pushTilesLayerMarkedDirtyDuringPaintOnNextLayer
TiledLayerChromiumTest.pushTilesLayerMarkedDirtyDuringPaintOnPreviousLayer

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::UpdatableTile::isDirtyForCurrentFrame):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::resetUpdateState):
(WebCore):
(WebCore::TiledLayerChromium::prepareToUpdate):

  • platform/graphics/chromium/TiledLayerChromium.h:

(TiledLayerChromium):

Source/WebKit/chromium:

  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9697001

13:21 Changeset [110466] by rniwa@webkit.org

Mac rebaseline.

  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
13:11 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
13:11 Changeset [110465] by adamk@chromium.org

[MutationObservers] Enforce a consistent order of MutationRecord delivery
https://bugs.webkit.org/show_bug.cgi?id=80549

Reviewed by Ojan Vafai.

Source/WebCore:

Mutations should be delivered in order of creation.

Tests: fast/mutation/create-during-delivery.html

fast/mutation/delivery-order.html
fast/mutation/mutate-during-delivery.html

  • dom/WebKitMutationObserver.cpp:

(WebCore):
(WebCore::WebKitMutationObserver::ObserverLessThan::operator()): Functor for use with std::sort.
(WebCore::WebKitMutationObserver::create):
(WebCore::WebKitMutationObserver::WebKitMutationObserver):
(WebCore::WebKitMutationObserver::deliverAllMutations): Move observers into a sorted vector before delivery.

  • dom/WebKitMutationObserver.h: Add a "priority" member which monotonically increases with each construction.

LayoutTests:

  • fast/mutation/create-during-delivery-expected.txt: Added.
  • fast/mutation/create-during-delivery.html: Added.
  • fast/mutation/delivery-order.html: Added.
  • fast/mutation/mutate-during-delivery-expected.txt: Added.
  • fast/mutation/mutate-during-delivery.html: Added.
13:08 Changeset [110464] by nduca@chromium.org

[Chromium] Force compositeAndReadback through regular scheduling flow
https://bugs.webkit.org/show_bug.cgi?id=77049

Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/cc/CCFrameRateController.cpp:

(WebCore::CCFrameRateController::onTimerTick):

  • platform/graphics/chromium/cc/CCFrameRateController.h:

(CCFrameRateControllerClient):

  • platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::setNeedsForcedCommit):
(WebCore):
(WebCore::CCScheduler::vsyncTick):

  • platform/graphics/chromium/cc/CCScheduler.h:

(CCScheduler):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::nextAction):
(WebCore::CCSchedulerStateMachine::updateState):
(WebCore::CCSchedulerStateMachine::setNeedsForcedCommit):
(WebCore):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.h:

(CCSchedulerStateMachine):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::requestReadbackOnImplThread):
(WebCore::CCThreadProxy::forceBeginFrameOnImplThread):
(WebCore::CCThreadProxy::scheduledActionBeginFrame):
(WebCore::CCThreadProxy::beginFrame):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):
(WebCore::CCThreadProxy::BeginFrameAndCommitState::BeginFrameAndCommitState):
(BeginFrameAndCommitState):

Source/WebKit/chromium:

  • tests/CCFrameRateControllerTest.cpp:

(WebKitTests::FakeCCFrameRateControllerClient::reset):
(WebKitTests::FakeCCFrameRateControllerClient::vsyncTicked):
(WebKitTests::FakeCCFrameRateControllerClient::vsyncTick):
(FakeCCFrameRateControllerClient):
(WebKitTests::TEST):

  • tests/CCLayerTreeHostTest.cpp:

(WTF):
(CCLayerTreeHostTestCompositeAndReadbackWhileInvisible):
(WTF::CCLayerTreeHostTestCompositeAndReadbackWhileInvisible::CCLayerTreeHostTestCompositeAndReadbackWhileInvisible):
(WTF::CCLayerTreeHostTestCompositeAndReadbackWhileInvisible::beginTest):
(WTF::CCLayerTreeHostTestCompositeAndReadbackWhileInvisible::didCommitAndDrawFrame):
(WTF::CCLayerTreeHostTestCompositeAndReadbackWhileInvisible::afterTest):
(WTF::TEST_F):

  • tests/CCSchedulerStateMachineTest.cpp:

(WebCore::StateMachine::setNeedsForcedCommit):
(WebCore::StateMachine::needsForcedCommit):
(StateMachine):
(WebCore::TEST):
(WebCore):

12:57 Changeset [110463] by jsbell@chromium.org

IndexedDB: Handle LevelDB database corruption
https://bugs.webkit.org/show_bug.cgi?id=79413

Source/WebCore:

Add LevelDBDatabase::destroy() method so that clients can retry if open() fails.

Reviewed by Tony Chang.

Test: webkit_unit_tests --gtest_filter='LevelDBDatabaseTest.CorruptionTest'

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp: Implement open/destroy/open strategy.

(WebCore::IDBLevelDBBackingStore::open):

  • platform/leveldb/LevelDBDatabase.cpp:

(WebCore::LevelDBDatabase::destroy):
(WebCore):

  • platform/leveldb/LevelDBDatabase.h:

(LevelDBDatabase):

Source/WebKit/chromium:

Reviewed by Tony Chang.

  • WebKit.gyp: Skip LevelDBTest.cpp in shared component builds due to webkit_support dependency
  • WebKit.gypi: Add LevelDBTest.cpp
  • tests/LevelDBTest.cpp: Added.

(WebCore):
(SimpleComparator):
(WebCore::SimpleComparator::compare):
(WebCore::SimpleComparator::name):
(WebCore::encodeString):
(WebCore::TEST):

12:55 Changeset [110462] by cevans@google.com

Merge 110332
BUG=114056
Review URL: https://chromiumcodereview.appspot.com/9689022

12:52 Changeset [110461] by cevans@google.com

Merge 110324
BUG=116746
Review URL: https://chromiumcodereview.appspot.com/9693006

12:50 Changeset [110460] by peter@chromium.org

[Chromium] Temporary build-fix for the Android bot
https://bugs.webkit.org/show_bug.cgi?id=80862

Reviewed by Adam Barth.

Manually set the environmental variables required to compile source
files through the Android NDK instead of relying on the envsetup.sh
script. A proper fix will be landed to Chromium ASAP, and following
a Chromium roll into WebKit this code will be removed.

  • Scripts/webkitdirs.pm:

(buildChromiumMakefile):

12:47 Changeset [110459] by cevans@google.com

Merge 110323
BUG=113902
Review URL: https://chromiumcodereview.appspot.com/9695005

12:44 Changeset [110458] by vestbo@webkit.org

[Qt] Use right construct to detect config_test_gccdepends

Reviewed by Andreas Kling.

12:44 Changeset [110457] by vestbo@webkit.org

[Qt] Expose location of WebKit's bin and imports dir through module file

Reviewed by Andreas Kling.

12:24 Changeset [110456] by shawnsingh@chromium.org

Fix regression on fast/table/table-row-compositing-repaint-crash.html
https://bugs.webkit.org/show_bug.cgi?id=80804

Reviewed by Simon Fraser.

Covered by existing tests.

http://trac.webkit.org/changeset/110401/ accidentally caused
fast/table/table-row-compositing-repaint-crash.html to fail.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateBacking):

12:20 Changeset [110455] by mikelawther@chromium.org

CSS3 calc: enable mixed percent/absolute for font
https://bugs.webkit.org/show_bug.cgi?id=80813

Reviewed by Ojan Vafai.

Source/WebCore:

Add support for mixed percent/absolute expressions to the font handling class.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyFontSize::applyValue):

LayoutTests:

  • css3/calc/font-expected.txt:
  • css3/calc/font-size-expected.txt:
12:19 Changeset [110454] by cevans@google.com

Merge 110326
BUG=116461
Review URL: https://chromiumcodereview.appspot.com/9677005

12:18 Changeset [110453] by laszlo.1.gombos@nokia.com

Minor DataLog fixes
https://bugs.webkit.org/show_bug.cgi?id=80826

Reviewed by Andreas Kling.

  • bytecode/ExecutionCounter.cpp:

Do not include DataLog.h, it is not used.

  • jit/ExecutableAllocator.cpp:

Ditto.

  • wtf/DataLog.cpp:

(WTF::initializeLogFileOnce):
Add missing semi-colon to the code path where DATA_LOG_FILENAME is defined.

  • wtf/HashTable.cpp:

Include DataLog as it is used.

12:00 Changeset [110452] by cevans@google.com

Merge 108084
BUG=112411
Review URL: https://chromiumcodereview.appspot.com/9694004

11:58 Changeset [110451] by reed@google.com

update expectations in preparation for bitmap-sampling fix in skia
https://bugs.webkit.org/show_bug.cgi?id=80837

Unreviewed

  • platform/chromium/test_expectations.txt:
11:51 Changeset [110450] by kling@webkit.org

Restore Attr::style() functionality.
<http://webkit.org/b/80678>
<rdar://problem/10933904>

Reviewed by Antti Koivisto.

The neutering of Attr::style() in r106740 broke some internal clients of the Obj-C API,
so this was definitely premature.

Since we no longer have a per-Attribute style object, synthesize one in style() and
hang it off of the Attr. This grows Attr by one pointer, but it's a low-volume object
so it shouldn't matter much.

We recreate the StylePropertySet object on every call to style(), to avoid complicating
things with custom invalidation code.

  • dom/Attr.cpp:

(WebCore::Attr::style):

  • dom/Attr.h:
  • dom/StyledElement.h:

(WebCore::StyledElement::collectStyleForAttribute):

11:38 Changeset [110449] by rniwa@webkit.org

REGRESSION(r109285): Crash in WebCore::Document::nodeChildrenWillBeRemoved
https://bugs.webkit.org/show_bug.cgi?id=80578

Reviewed by Andreas Kling.

Source/WebCore:

Test: svg/css/style-change-crash.html

  • dom/Element.cpp:

(WebCore::Element::setAttribute):
(WebCore::Element::setAttributeInternal):

  • dom/Element.h:

(Element):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::addAttribute):
(WebCore::ElementAttributeData::removeAttribute):

  • dom/ElementAttributeData.h:

(ElementAttributeData):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::updateStyleAttribute):

LayoutTests:

  • fast/regions/select-in-region-crash-expected.txt: Rebaselined.
  • svg/css/style-change-crash-expected.txt: Added.
  • svg/css/style-change-crash.html: Added.
11:28 Changeset [110448] by commit-queue@webkit.org

Touch event handler count is not updated when adding handlers to the window.
https://bugs.webkit.org/show_bug.cgi?id=80756

Source/WebCore:

Touch event handlers added to the window needs to be included when counting the number of touch event
handlers. This makes touch event handler counting identical to wheel event handler counting.

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-03-12
Reviewed by Anders Carlsson.

Test: fast/events/touch/touch-handler-count.html

  • dom/EventNames.h:

(EventNames):
(WebCore::EventNames::isTouchEventType):

  • dom/Node.cpp:

(WebCore):
(WebCore::tryAddEventListener):
(WebCore::tryRemoveEventListener):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):

  • testing/Internals.cpp:

(WebCore::Internals::touchEventHandlerCount):
(WebCore):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

LayoutTests:

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-03-12
Reviewed by Anders Carlsson.

The new layout tests add and remove touch event handlers on the window, document, and a div in the
document, and tests that the count is updated correctly when handlers are added and/or removed.

  • fast/events/touch/touch-handler-count-expected.txt: Added.
  • fast/events/touch/touch-handler-count.html: Added.
11:02 Changeset [110447] by abecsi@webkit.org

[Qt][WK2] Add support for rudimentary scroll indicators in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=80832

Reviewed by Tor Arne Vestbø.

Source/WebKit2:

Since the ScrollDecorator QML component requires a Flickable in its API
we need to expose the Flickable in QML for now and we also need to add
a notifier because we instantiate the internal Flickable only when the
WebView component completes construction.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebViewExperimental::flickable):

  • UIProcess/API/qt/qquickwebview_p.h:

Tools:

Add a basic scroll indicator component to MiniBrowser so that it
behaves similar to the ScrollDecorator QML component.

  • MiniBrowser/qt/MiniBrowser.qrc:
  • MiniBrowser/qt/qml/BrowserWindow.qml:
  • MiniBrowser/qt/qml/ScrollIndicator.qml: Added.
10:50 Changeset [110446] by commit-queue@webkit.org

[GTK] r110296 included an extra $ in @$(AM_V_GEN)
https://bugs.webkit.org/show_bug.cgi?id=80809

Patch by C Anthony Risinger <anthony@xtfx.me> on 2012-03-12
Reviewed by Philippe Normand.

  • GNUmakefile.am: Add $ to @(AM_V_GEN), else /bin/sh syntax error
10:43 Changeset [110445] by podivilov@chromium.org

Web Inspector: extract ResourceScriptMapping from MainScriptMapping.
https://bugs.webkit.org/show_bug.cgi?id=80834

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/ScriptMapping.js:

(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeListChanged):
(WebInspector.ResourceScriptMapping.prototype.reset):
(WebInspector.MainScriptMapping):
(WebInspector.MainScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.MainScriptMapping.prototype.createLiveLocation):
(WebInspector.MainScriptMapping.prototype._registerLiveLocation):
(WebInspector.MainScriptMapping.prototype._unregisterLiveLocation):
(WebInspector.MainScriptMapping.prototype._updateLiveLocations):
(WebInspector.MainScriptMapping.prototype.uiSourceCodeList):
(WebInspector.MainScriptMapping.prototype.addScript):
(WebInspector.MainScriptMapping.prototype._handleUISourceCodeListChanged):
(WebInspector.MainScriptMapping.prototype.setFormatSource):
(WebInspector.MainScriptMapping.prototype.forceUpdateSourceMapping):
(WebInspector.MainScriptMapping.prototype.reset):

10:42 Changeset [110444] by ericu@chromium.org

[Chromium] fast/filesystem/op-restricted-chars.html fails on Windows
https://bugs.webkit.org/show_bug.cgi?id=75110

Reviewed by Ryosuke Niwa.

Remove expectation now that it's fixed.

  • platform/chromium/test_expectations.txt:
10:31 Changeset [110443] by commit-queue@webkit.org

Integer overflow check code in arithmetic operation in classic interpreter
https://bugs.webkit.org/show_bug.cgi?id=80465

Patch by SangGyu Lee <sg5.lee@samsung.com> on 2012-03-12
Reviewed by Gavin Barraclough.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

10:17 Changeset [110442] by philn@webkit.org

Unreviewed, unskip a media test in GTK.

  • platform/gtk/Skipped: media/video-volume-slider.html was fixed

in r86535.

  • platform/gtk/media/video-volume-slider-expected.txt:
10:14 Changeset [110441] by pfeldman@chromium.org

Web Inspector: recognize Float*Array and Int*Array as arrays.
https://bugs.webkit.org/show_bug.cgi?id=80850

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: inspector/console/console-external-array.html

  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::type):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::typeCallback):

LayoutTests:

  • inspector/console/console-external-array-expected.txt: Added.
  • inspector/console/console-external-array.html: Added.
10:13 Changeset [110440] by commit-queue@webkit.org

Add tests for dynamic attribute changes for mapping of lang/xml:lang to -webkit-locale
https://bugs.webkit.org/show_bug.cgi?id=80658

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-03-12
Reviewed by Alexey Proskuryakov.

  • fast/text/lang-mapped-to-webkit-locale-dynamic-expected.txt: Added.
  • fast/text/lang-mapped-to-webkit-locale-dynamic.xhtml: Added.
10:09 Changeset [110439] by jocelyn.turcotte@nokia.com

[TexMapGL] Pixel-align the transform of textures that fit pixel-for-pixel on the frame buffer.
https://bugs.webkit.org/show_bug.cgi?id=80848

Reviewed by Noam Rosenthal.

When rendering a transformed texture on the screen with a fractional
coordinate with linear filtering, the resulting pixel will be blended from
the texels around this fractional position according to their cover ratio.
This produces a slight blur of pixels which give no benefit when rendering
a texture that isn't scaled.

This patch offsets the transform by rounding the translation part of the
layer's transform to align the result to integer coordinates.
Applying the adjustment on the layer transform makes sure that all the tiles
get the same adjustment.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::drawTexture):

  • platform/graphics/texmap/TextureMapperGL.h:

(WebCore::BitmapTextureGL::textureSize):

10:08 Changeset [110438] by jocelyn.turcotte@nokia.com

[TexMapGL] Use textures sized exactly to their contents.
https://bugs.webkit.org/show_bug.cgi?id=80845

Reviewed by Noam Rosenthal.

This fixes a regression introduced in r108273 as well as the bug it fixed.
The regressing behavior was that textures were rendered shrunk by 1 pixel
and thus would appear blurry on the screen.
The original problem was that garbage contents would appear on filtered
textures since we would reuse textures of different sizes by giving them
a slightly bigger size.

This patch will reuse the texture only if the size matches exactly to allow
edge clamping to work properly when redering with linear filtering.
Reusing textures would only saves us the allocation of graphic memory
anyway, which is negligeable compared to texture upload.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::drawTexture):
(WebCore::BitmapTextureGL::didReset):

  • platform/graphics/texmap/TextureMapperGL.h:

(BitmapTextureGL):

  • platform/graphics/texmap/TextureMapperShaderManager.cpp:

(WebCore::TextureMapperShaderProgramOpacityAndMask::TextureMapperShaderProgramOpacityAndMask):
(WebCore::TextureMapperShaderProgramOpacityAndMask::prepare):

  • platform/graphics/texmap/TextureMapperShaderManager.h:

(TextureMapperShaderProgramOpacityAndMask):

10:06 Changeset [110437] by jocelyn.turcotte@nokia.com

[TexMap] Remove BitmapTexture::destroy.
https://bugs.webkit.org/show_bug.cgi?id=80844

Reviewed by Noam Rosenthal.

Use the destructor directly instead.

  • platform/graphics/texmap/TextureMapper.h:
  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::~BitmapTextureGL):

  • platform/graphics/texmap/TextureMapperGL.h:

(BitmapTextureGL):

  • platform/graphics/texmap/TextureMapperImageBuffer.h:

(WebCore::BitmapTextureImageBuffer::~BitmapTextureImageBuffer):

09:50 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
09:39 Changeset [110436] by vestbo@webkit.org

[Qt] Make sure we set the right library version for Qt 4

r110272 accedentally pruned the variable that ensures this.

Reviewed by Simon Hausmann.

09:06 Changeset [110435] by philn@webkit.org

Unreviewed, slight Skipped list reorganization and unskip a bunch
of inspector tests on GTK.

  • platform/gtk/Skipped:
08:56 Changeset [110434] by podivilov@chromium.org

Web Inspector: DebuggerModel.Location should have scriptId property.
https://bugs.webkit.org/show_bug.cgi?id=80830

Reviewed by Vsevolod Vlasov.

Source/WebCore:

  • inspector/front-end/CompilerSourceMapping.js:

(WebInspector.ClosureCompilerSourceMapping.prototype.sourceLocationToCompiledLocation):

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype.location):

  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.Location):
(WebInspector.DebuggerModel.prototype._failedToParseScriptSource):
(WebInspector.DebuggerModel.prototype.createRawLocation):
(WebInspector.DebuggerModel.prototype.createRawLocationByURL):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessageToScript):
(WebInspector.DebuggerPresentationModel.prototype._addPendingConsoleMessagesToScript):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype._uiSourceCodeForResource):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode.PlainSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.CompilerSourceMapping.prototype.uiLocationToRawLocation):

  • inspector/front-end/ScriptFormatter.js:

(WebInspector.ScriptFormatter.locationToPosition):
(WebInspector.ScriptFormatter.positionToLocation):
(WebInspector.FormattedSourceMapping.prototype.originalToFormatted):
(WebInspector.FormattedSourceMapping.prototype.formattedToOriginal):

LayoutTests:

  • http/tests/inspector/compiler-source-mapping.html:
  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • http/tests/inspector/search/search-in-concatenated-script.html:
  • http/tests/inspector/search/search-in-script.html:
  • inspector/debugger/debugger-scripts.html:
  • inspector/debugger/linkifier.html:
  • inspector/debugger/raw-source-code.html:
  • inspector/debugger/script-formatter.html:
08:50 Changeset [110433] by commit-queue@webkit.org

[chromium] Clean up culling tests and templatize to test impl constructs
https://bugs.webkit.org/show_bug.cgi?id=80613

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-12
Reviewed by Adrienne Walker.

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore::TestContentLayerChromium::TestContentLayerChromium):
(WebCore::TestContentLayerChromium::opaqueContentsRegion):
(WebCore::TestContentLayerChromium::setOpaqueContentsRect):
(TestContentLayerChromium):
(TestContentLayerImpl):
(WebCore::TestContentLayerImpl::TestContentLayerImpl):
(WebCore::TestContentLayerImpl::opaqueContentsRegion):
(WebCore::TestContentLayerImpl::setOpaqueContentsRect):
(WebCore):
(WebCore::TestCCOcclusionTrackerBase::TestCCOcclusionTrackerBase):
(WebCore::TestCCOcclusionTrackerBase::occlusionInScreenSpace):
(WebCore::TestCCOcclusionTrackerBase::occlusionInTargetSurface):
(WebCore::TestCCOcclusionTrackerBase::setOcclusionInScreenSpace):
(WebCore::TestCCOcclusionTrackerBase::setOcclusionInTargetSurface):
(WebCore::TestCCOcclusionTrackerBase::layerScissorRectInTargetSurface):
(WebCore::TestDamageClient::damageRect):
(CCOcclusionTrackerTestMainThreadTypes):
(WebCore::CCOcclusionTrackerTestMainThreadTypes::createLayer):
(WebCore::CCOcclusionTrackerTestMainThreadTypes::createContentLayer):
(CCOcclusionTrackerTestImplThreadTypes):
(WebCore::CCOcclusionTrackerTestImplThreadTypes::createLayer):
(WebCore::CCOcclusionTrackerTestImplThreadTypes::createContentLayer):
(CCOcclusionTrackerTest):
(WebCore::CCOcclusionTrackerTest::TearDown):
(WebCore::CCOcclusionTrackerTest::createRoot):
(WebCore::CCOcclusionTrackerTest::createLayer):
(WebCore::CCOcclusionTrackerTest::createSurface):
(WebCore::CCOcclusionTrackerTest::createDrawingLayer):
(WebCore::CCOcclusionTrackerTest::createDrawingSurface):
(WebCore::CCOcclusionTrackerTest::calcDrawEtc):
(WebCore::CCOcclusionTrackerTest::setBaseProperties):
(WebCore::CCOcclusionTrackerTest::setProperties):
(CCOcclusionTrackerTestIdentityTransforms):
(WebCore::CCOcclusionTrackerTestIdentityTransforms::runMyTest):
(CCOcclusionTrackerTestRotatedChild):
(WebCore::CCOcclusionTrackerTestRotatedChild::runMyTest):
(CCOcclusionTrackerTestTranslatedChild):
(WebCore::CCOcclusionTrackerTestTranslatedChild::runMyTest):
(CCOcclusionTrackerTestChildInRotatedChild):
(WebCore::CCOcclusionTrackerTestChildInRotatedChild::runMyTest):
(CCOcclusionTrackerTestVisitTargetTwoTimes):
(WebCore::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest):
(CCOcclusionTrackerTestSurfaceRotatedOffAxis):
(WebCore::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest):
(CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren):
(WebCore::CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren::runMyTest):
(CCOcclusionTrackerTestOverlappingSurfaceSiblings):
(WebCore::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
(CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms):
(WebCore::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
(CCOcclusionTrackerTestFilters):
(WebCore::CCOcclusionTrackerTestFilters::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectOutsideChild):
(WebCore::CCOcclusionTrackerTestLayerScissorRectOutsideChild::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectOutsideChild):
(WebCore::CCOcclusionTrackerTestScreenScissorRectOutsideChild::runMyTest):
(CCOcclusionTrackerTestDamageRectOutsideChild):
(WebCore::CCOcclusionTrackerTestDamageRectOutsideChild::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectOverChild):
(WebCore::CCOcclusionTrackerTestLayerScissorRectOverChild::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectOverChild):
(WebCore::CCOcclusionTrackerTestScreenScissorRectOverChild::runMyTest):
(CCOcclusionTrackerTestDamageRectOverChild):
(WebCore::CCOcclusionTrackerTestDamageRectOverChild::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectPartlyOverChild):
(WebCore::CCOcclusionTrackerTestLayerScissorRectPartlyOverChild::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectPartlyOverChild):
(WebCore::CCOcclusionTrackerTestScreenScissorRectPartlyOverChild::runMyTest):
(CCOcclusionTrackerTestDamageRectPartlyOverChild):
(WebCore::CCOcclusionTrackerTestDamageRectPartlyOverChild::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectOverNothing):
(WebCore::CCOcclusionTrackerTestLayerScissorRectOverNothing::runMyTest):
(CCOcclusionTrackerTestScreenScissorRectOverNothing):
(WebCore::CCOcclusionTrackerTestScreenScissorRectOverNothing::runMyTest):
(CCOcclusionTrackerTestDamageRectOverNothing):
(WebCore::CCOcclusionTrackerTestDamageRectOverNothing::runMyTest):
(CCOcclusionTrackerTestLayerScissorRectForLayerOffOrigin):
(WebCore::CCOcclusionTrackerTestLayerScissorRectForLayerOffOrigin::runMyTest):
(CCOcclusionTrackerTestOpaqueContentsRegionEmpty):
(WebCore::CCOcclusionTrackerTestOpaqueContentsRegionEmpty::runMyTest):
(CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty):
(WebCore::CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty::runMyTest):

08:47 Changeset [110432] by commit-queue@webkit.org

[chromium] A couple early-outs for occlusion tracker
https://bugs.webkit.org/show_bug.cgi?id=80742

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-12
Reviewed by Adrienne Walker.

Covered by existing tests.

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::occluded):
(WebCore::::unoccludedContentRect):

08:45 Changeset [110431] by zeno.albisser@nokia.com

[Qt][Mac] Build fails after adding WebCoreCFAutorelease(CFTypeRef) (r110360).
https://bugs.webkit.org/show_bug.cgi?id=80840

CoreFoundation/CFBase.h needs to be included to define the type CFTypeRef.

Reviewed by Tor Arne Vestbø.

  • platform/mac/WebCoreObjCExtras.h:
08:34 Changeset [110430] by zeno.albisser@nokia.com

[Qt][Mac] Build fails after enabling LLINT when JIT is disabled (r109863)
https://bugs.webkit.org/show_bug.cgi?id=80827

Qt on Mac uses OS(DARWIN) as well, but we do not want to enable LLINT.

Reviewed by Simon Hausmann.

  • wtf/Platform.h:
08:32 Changeset [110429] by staikos@webkit.org

Remove unused global static variable for BlackBerry.
https://bugs.webkit.org/show_bug.cgi?id=80790

Reviewed by Alexey Proskuryakov.

  • platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore):

08:28 Changeset [110428] by staikos@webkit.org

Correct usage of NDEBUG to fix warnings on BlackBerry.
https://bugs.webkit.org/show_bug.cgi?id=80790

Reviewed by Alexey Proskuryakov.

  • platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:

(WebCore::CookieDatabaseBackingStore::sendChangesToDatabase):

  • platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::initiateCookieLimitCleanUp):

07:52 Changeset [110427] by commit-queue@webkit.org

[BlackBerry] build-webkit doesn't recognize "--cmakearg" for the BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=80812

Patch by Ming Xie <mxie@rim.com> on 2012-03-12
Reviewed by Rob Buis.

  • Scripts/build-webkit: Add $cmakeArgs to buildCMakeProjectOrExit()
  • Scripts/webkitdirs.pm:

(blackberryCMakeArguments): Remove "PUBLIC_BUILD=0" define

07:43 Changeset [110426] by hausmann@webkit.org

Unreviewed prospective Qt/Mac build fix

  • runtime/JSGlobalData.cpp: use #USE(CF) instead of PLATFORM(MAC) to determine

whether to include CoreFoundation headers, used for JIT configuration in JSGlobalData
constructor.

07:36 Changeset [110425] by timothy@apple.com

Update how the Web Inspector resources are loaded.

https://bugs.webkit.org/show_bug.cgi?id=80814
rdar://problem/10359959

Reviewed by John Sullivan.

  • Shared/WebPreferencesStore.h:

(WebKit): Added InspectorUsesWebKitUserInterface.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode): Removed webInspectorLocalizedStringsPath.
(WebKit::WebProcessCreationParameters::decode): Ditto.

  • Shared/WebProcessCreationParameters.h: Ditto.

(WebProcessCreationParameters): Ditto.

  • UIProcess/API/C/WKContext.cpp:
  • UIProcess/API/C/WKContextPrivate.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetInspectorUsesWebKitUserInterface): Added.
(WKPreferencesGetInspectorUsesWebKitUserInterface): Added.

  • UIProcess/API/C/WKPreferencesPrivate.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureWebProcess): Removed webInspectorLocalizedStringsPath.

  • UIProcess/WebContext.h:

(WebContext): Ditto.

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::inspectorReallyUsesWebKitUserInterface): Added.
(WebKit::WebInspectorProxy::createInspectorWindow): Use inspectorReallyUsesWebKitUserInterface
to determine if texture should be used.
(WebKit::WebInspectorProxy::inspectorPageURL): Choose the right path.
(WebKit::WebInspectorProxy::inspectorBaseURL): Ditto.

  • WebProcess/WebPage/WebInspector.h:
  • WebProcess/WebPage/mac/WebInspectorMac.mm:

(WebKit::inspectorReallyUsesWebKitUserInterface):
(WebKit::WebInspector::setInspectorUsesWebKitUserInterface): Added.
(WebKit::WebInspector::localizedStringsURL):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformPreferencesDidChange): Call WebInspector::setInspectorUsesWebKitUserInterface.

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::platformInitializeWebProcess): Removed call to WebInspector::setLocalizedStringsPath.

07:33 Changeset [110424] by ossy@webkit.org

[Qt] REGRESSION(r110401): fast/table/table-row-compositing-repaint-crash.html asserts
https://bugs.webkit.org/show_bug.cgi?id=80833

Unreviewed gardening.

  • platform/qt/Skipped: Skip fast/table/table-row-compositing-repaint-crash.html to paint the bot green.
07:24 WebKit Team edited by yi.4.shen@nokia.com
(diff)
06:59 Changeset [110423] by loislo@chromium.org

Re-apply the patch after v8 roll to r11000.

Web Inspector: move heap snapshot nodes data to external array.
https://bugs.webkit.org/show_bug.cgi?id=79911

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Tests:
heap-shapshot.html
heap-shapshot-loader.html

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.Int32Array):
(WebInspector.Int32Array.prototype.get array):
(WebInspector.HeapSnapshotLoader.prototype._parseNodes):
(WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
(WebInspector.HeapSnapshot):
(WebInspector.HeapSnapshot.prototype._init):

LayoutTests:

  • inspector/profiler/heap-snapshot-loader.html:
  • inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockRaw):
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMock):
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockWithDOM):

05:57 Changeset [110422] by hausmann@webkit.org

[Qt] Fix build with newer Qt 5.

Reviewed by Tor Arne Vestbø.

Source/WebCore:

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::fileListNameForWidth): Use DefaultCodec instead of the
deprecated CodecForTR.

Tools:

Newer Qt 5 renames QDeclarativeFoo to QQmlFoo and provides backwards compatible
renames, which however do trigger a #warning. Until we _require_ a newer Qt 5
we should disable -Werror.

Also load(moc) for the availability of QMAKE_MOC in various derived sources. The
implicit load was removed recently.

  • qmake/mkspecs/features/default_pre.prf:
  • qmake/mkspecs/features/unix/default_post.prf:
05:31 Changeset [110421] by loislo@chromium.org

Web Inspector: chromium: increase heap snapshot performance coverage.
https://bugs.webkit.org/show_bug.cgi?id=80829

Reviewed by Yury Semikhatsky.

  • inspector/detailed-heapshots-smoke-test.html:
  • inspector/performance-test.js:

(initialize_TimeTracker.InspectorTest.measureFunction):

04:27 Changeset [110420] by hans@chromium.org

Speech JavaScript API: SpeechRecognitionEvent
https://bugs.webkit.org/show_bug.cgi?id=80513

Reviewed by Adam Barth.

Source/WebCore:

Implement SpeechRecognitionEvent.
(Spec: http://speech-javascript-api-spec.googlecode.com/git/speechapi.html)

Test: fast/events/constructors/speech-recognition-event-constructor.html

  • Modules/speech/DOMWindowSpeech.idl:
  • Modules/speech/SpeechRecognitionEvent.cpp: Added.

(WebCore):
(WebCore::SpeechRecognitionEventInit::SpeechRecognitionEventInit):
(WebCore::SpeechRecognitionEvent::create):
(WebCore::SpeechRecognitionEvent::createResult):
(WebCore::SpeechRecognitionEvent::createNoMatch):
(WebCore::SpeechRecognitionEvent::createResultDeleted):
(WebCore::SpeechRecognitionEvent::createError):
(WebCore::SpeechRecognitionEvent::interfaceName):
(WebCore::SpeechRecognitionEvent::SpeechRecognitionEvent):

  • Modules/speech/SpeechRecognitionEvent.h: Added.

(WebCore):
(SpeechRecognitionEventInit):
(SpeechRecognitionEvent):
(WebCore::SpeechRecognitionEvent::result):
(WebCore::SpeechRecognitionEvent::error):
(WebCore::SpeechRecognitionEvent::resultIndex):
(WebCore::SpeechRecognitionEvent::resultHistory):

  • Modules/speech/SpeechRecognitionEvent.idl:
  • WebCore.gypi:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitSpeechRecognitionEventEnabled):

  • bindings/v8/OptionsObject.cpp:

(WebCore::OptionsObject::get):
(WebCore):

  • bindings/v8/OptionsObject.h:

(WebCore):
(OptionsObject):

  • dom/EventNames.h:

(WebCore):

  • dom/EventNames.in:

LayoutTests:

Add test for SpeechRecognitionEvent.
Update Skipped files for all ports except Chromium.

  • fast/events/constructors/speech-recognition-event-constructor-expected.txt: Added.
  • fast/events/constructors/speech-recognition-event-constructor.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
02:50 Changeset [110419] by fpizlo@apple.com

All DFG nodes should have a mutable set of flags
https://bugs.webkit.org/show_bug.cgi?id=80779
<rdar://problem/11026218>

Reviewed by Gavin Barraclough.

Got rid of NodeId, and placed all of the flags that distinguished NodeId
from NodeType into a separate Node::flags field. Combined what was previously
ArithNodeFlags into Node::flags.

In the process of debugging, I found that the debug support in the virtual
register allocator was lacking, so I improved it. I also realized that the
virtual register allocator was assuming that the nodes in a basic block were
contiguous, which is no longer the case. So I fixed that. The fix also made
it natural to have more extreme assertions, so I added them. I suspect this
will make it easier to catch virtual register allocation bugs in the future.

This is mostly performance neutral; if anything it looks like a slight
speed-up.

This patch does leave some work for future refactorings; for example, Node::op
is unencapsulated. This was already the case, though now it feels even more
like it should be. I avoided doing that because this patch has already grown
way bigger than I wanted.

Finally, this patch creates a DFGNode.cpp file and makes a slight effort to
move some unnecessarily inline stuff out of DFGNode.h.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • dfg/DFGArithNodeFlagsInferencePhase.cpp:

(JSC::DFG::ArithNodeFlagsInferencePhase::propagate):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addToGraph):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCFAPhase.cpp:

(JSC::DFG::CFAPhase::performBlockCFA):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::endIndexForPureCSE):
(JSC::DFG::CSEPhase::pureCSE):
(JSC::DFG::CSEPhase::clobbersWorld):
(JSC::DFG::CSEPhase::impureCSE):
(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::eliminate):
(JSC::DFG::CSEPhase::performNodeCSE):
(JSC::DFG::CSEPhase::performBlockCSE):
(CSEPhase):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::opName):
(JSC::DFG::Graph::dump):
(DFG):

  • dfg/DFGNode.cpp: Added.

(DFG):
(JSC::DFG::arithNodeFlagsAsString):

  • dfg/DFGNode.h:

(DFG):
(JSC::DFG::nodeUsedAsNumber):
(JSC::DFG::nodeCanTruncateInteger):
(JSC::DFG::nodeCanIgnoreNegativeZero):
(JSC::DFG::nodeMayOverflow):
(JSC::DFG::nodeCanSpeculateInteger):
(JSC::DFG::defaultFlags):
(JSC::DFG::Node::Node):
(Node):
(JSC::DFG::Node::setOpAndDefaultFlags):
(JSC::DFG::Node::mustGenerate):
(JSC::DFG::Node::arithNodeFlags):
(JSC::DFG::Node::setArithNodeFlag):
(JSC::DFG::Node::mergeArithNodeFlags):
(JSC::DFG::Node::hasResult):
(JSC::DFG::Node::hasInt32Result):
(JSC::DFG::Node::hasNumberResult):
(JSC::DFG::Node::hasJSResult):
(JSC::DFG::Node::hasBooleanResult):
(JSC::DFG::Node::isJump):
(JSC::DFG::Node::isBranch):
(JSC::DFG::Node::isTerminal):
(JSC::DFG::Node::child1):
(JSC::DFG::Node::child2):
(JSC::DFG::Node::child3):
(JSC::DFG::Node::firstChild):
(JSC::DFG::Node::numChildren):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::vote):
(JSC::DFG::PredictionPropagationPhase::fixupNode):

  • dfg/DFGScoreBoard.h:

(ScoreBoard):
(JSC::DFG::ScoreBoard::~ScoreBoard):
(JSC::DFG::ScoreBoard::assertClear):
(JSC::DFG::ScoreBoard::use):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::useChildren):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGVirtualRegisterAllocationPhase.cpp:

(JSC::DFG::VirtualRegisterAllocationPhase::run):

02:19 Changeset [110418] by caseq@chromium.org

Unreviewed, remove flakiness flags for timeline-start-time.html following a fix in r100417.
https://bugs.webkit.org/show_bug.cgi?id=80803

  • platform/chromium/test_expectations.txt:
02:02 Changeset [110417] by caseq@chromium.org

Unreviewed flakiness fix.

  • inspector/timeline/timeline-start-time.html:
01:59 Changeset [110416] by philn@webkit.org

Unreviewed, GTK rebaseline after r110409. And skip a new GTK
layout test failing after r110371.

  • platform/gtk/Skipped:
  • platform/gtk/fast/hidpi/video-controls-in-hidpi-expected.txt:
  • platform/gtk/fast/layers/video-layer-expected.txt:
  • platform/gtk/media/audio-controls-rendering-expected.txt:
  • platform/gtk/media/audio-repaint-expected.txt:
  • platform/gtk/media/controls-strict-expected.txt:
  • platform/gtk/media/controls-styling-expected.txt:
  • platform/gtk/media/controls-without-preload-expected.txt:
  • platform/gtk/media/media-controls-clone-expected.txt:
  • platform/gtk/media/media-document-audio-repaint-expected.txt:
  • platform/gtk/media/video-controls-rendering-expected.txt:
  • platform/gtk/media/video-empty-source-expected.txt:
  • platform/gtk/media/video-no-audio-expected.txt:
  • platform/gtk/media/video-zoom-controls-expected.txt:
01:52 Changeset [110415] by rolandsteiner@chromium.org

Unreviewed: Fix typos in fast/css/style-scoped/style-scoped-basic.html layout test.

  • fast/css/style-scoped/style-scoped-basic.html:
01:38 Changeset [110414] by tkent@chromium.org

Use ICU C API instead of C++ API in LocalizedNumberICU
https://bugs.webkit.org/show_bug.cgi?id=80815
https://bugs.gentoo.org/show_bug.cgi?id=407401

Reviewed by Hajime Morita.

ICU 4.8 doesn't have kNumberStyle. We had better to use ICU C API in
general to avoid such issues.

This patch should not make any behavior change.

  • platform/text/LocalizedNumberICU.cpp:

(WebCore::ICULocale::ICULocale):
Change the argument type: icu::Locale -> const char*
(WebCore::ICULocale::~ICULocale): Delete m_numberFormat with unum_close().
(WebCore::ICULocale::create): Do not create icu::Locale.
(WebCore::ICULocale::createForCurrentLocale): ditto.
(WebCore::ICULocale::setDecimalSymbol):
Use unum_getSymbol() instead of DecimalFormatSymbols::getSymbol().
(WebCore::ICULocale::setDecimalTextAttribute):
Added. A utility function to store prefixes and suffixes.
(WebCore::ICULocale::initializeDecimalFormat):

  • unum_open(), instead of NumberFormat::createInstance().
  • Use C API symbols.
  • Cache positive/negative prefixes/suffixes.

(WebCore::ICULocale::convertToLocalizedNumber): Use cached prefixes and suffixes.
(WebCore::matches): Stop using template because we don't use UString anymore.
(WebCore::ICULocale::detectSignAndGetDigitRange):

  • Use cached prefixes and suffixes.
  • Use String::startsWith() and endsWith().

(WebCore::ICULocale::convertFromLocalizedNumber):

  • platform/text/LocalizedNumberICU.h:

(ICULocale):

01:32 Changeset [110413] by podivilov@chromium.org

Web Inspector: decouple LiveLocation from RawSourceCode.
https://bugs.webkit.org/show_bug.cgi?id=80785

Reviewed by Vsevolod Vlasov.

Source/WebCore:

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.createPlacard):
(WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
(WebInspector.PresentationCallFrame):
(WebInspector.PresentationCallFrame.prototype.uiLocation):
(WebInspector.DebuggerPresentationModel.CallFramePlacard):

  • inspector/front-end/RawSourceCode.js:
  • inspector/front-end/ScriptMapping.js:

(WebInspector.MainScriptMapping):
(WebInspector.MainScriptMapping.prototype.createLiveLocation):
(WebInspector.MainScriptMapping.prototype._registerLiveLocation):
(WebInspector.MainScriptMapping.prototype._unregisterLiveLocation):
(WebInspector.MainScriptMapping.prototype._updateLiveLocations):
(WebInspector.MainScriptMapping.prototype._uiSourceCodeListChanged):
(WebInspector.MainScriptMapping.prototype.reset):
(WebInspector.LiveLocation):
(WebInspector.LiveLocation.prototype.init):
(WebInspector.LiveLocation.prototype.dispose):
(WebInspector.LiveLocation.prototype._update):

LayoutTests:

  • inspector/debugger/callstack-placards-discarded-expected.txt:
  • inspector/debugger/callstack-placards-discarded.html:
  • inspector/debugger/linkifier.html:
00:14 Changeset [110412] by aestes@apple.com

Remove unnecessary call to NSSizeToCGSize().
https://bugs.webkit.org/show_bug.cgi?id=80817

Reviewed by Dan Bernstein.

There is no need to call NSSizeToCGSize() to convert an IntSize to a
CGSize. IntSize defines a conversion function to CGSize that will do
this for us implicitly.

  • UIProcess/mac/BackingStoreMac.mm:

(WebKit::BackingStore::backingStoreContext): Do not call NSSizeToCGSize().

03/11/12:

23:07 Changeset [110411] by ukai@chromium.org

Unreviewed, update chromium test expectations.

  • platform/chromium/test_expectations.txt:
22:59 Changeset [110410] by ukai@chromium.org

Unreviewed, update chromium test expectations.

  • platform/chromium/test_expectations.txt:
21:47 Changeset [110409] by commit-queue@webkit.org

Source/WebCore: The main code structure for placing future text track cue rendering
code and main outer rendering steps.
https://bugs.webkit.org/show_bug.cgi?id=79746

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-03-11
Reviewed by Eric Carlson.

No new tests. Only refactoring, but some chromium tests require rebaselining
and have been marked accordingly.

  • css/mediaControls.css:

(::-webkit-media-controls): Changed the default display to -webkit-box, as
captions need to always be rendered on top of the controls, if they are visible.
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
Default position attribute is now relative, handled by the parent -webkit-box
(video::-webkit-media-text-track-container): The position of the container is
now relative, handled by -webkit-box.
(video::-webkit-media-text-track-display): Adjusted text color to match
the color required in the WebVTT spec (section 3.5.1 'color' property)

  • css/mediaControlsChromium.css:

(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
Default position attribute is now relative, handled by the parent -webkit-box

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::MediaControlPanelElement): Added a timer
for the webkit fade out transition event. This timer is required for setting
the display property to 'none', when the fade out transition is over. Otherwise,
captions would not be displayed at the bottom of the video.
(WebCore::MediaControlPanelElement::startTimer): Added.
(WebCore):
(WebCore::MediaControlPanelElement::stopTimer): Added.
(WebCore::MediaControlPanelElement::transitionTimerFired): Added. If the current
state of the controls is transparent, the display property is set to 'none'.
(WebCore::MediaControlPanelElement::makeOpaque): The inline display:'none' property
is removed before the fade in transition.
(WebCore::MediaControlPanelElement::makeTransparent): Added the timer start.
(WebCore::MediaControlTextTrackContainerElement::MediaControlTextTrackContainerElement):
Removed m_bottom as it is not needed anymore.
(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Added. Main
function for the rendering rules.
(WebCore::MediaControlTextTrackContainerElement::updateSizes): The bottom position
needs not to be set anymore.

  • html/shadow/MediaControlElements.h:

(MediaControlPanelElement): Added timer internals.
(MediaControlTextTrackContainerElement): Added updateDisplay() and removed unused
variables.

(WebCore):

  • html/shadow/MediaControlRootElement.cpp: Removed m_textTrackDisplay

and duplicated code with MediaControlRootElementChromium (only minimum
function calls to the main text track container)
(WebCore::MediaControlRootElement::MediaControlRootElement):
(WebCore::MediaControlRootElement::setMediaController):
(WebCore::MediaControlRootElement::createTextTrackDisplay):
(WebCore::MediaControlRootElement::updateTextTrackDisplay):

  • html/shadow/MediaControlRootElementChromium.cpp: Removed m_textTrackDisplay

and duplicate code with MediaControlRootElement (only minimum function calls
to the main text track container remained)
(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
(WebCore::MediaControlRootElementChromium::setMediaController):
(WebCore::MediaControlRootElementChromium::createTextTrackDisplay):
(WebCore::MediaControlRootElementChromium::updateTextTrackDisplay):

(WebCore):

  • html/track/TextTrackCue.cpp: Enhanced structure for supporting more complex

rendering required by the WebVTT spec.
(WebCore::TextTrackCue::TextTrackCue):
(WebCore::TextTrackCue::cueDidChange): Mark the display tree as obsolete, so that
it needs to be re-computed.
(WebCore::TextTrackCue::setIsActive): The display tree needs to be removed as
soon as the cue becomes inactive. Adjusted this method to support the functionality.
(WebCore):
(WebCore::TextTrackCue::determineDisplayParameters): Added. This method will hold
main positioning parameter computations for a TextTrackCue
(WebCore):
(WebCore::TextTrackCue::getDisplayTree): Added. This method returns the root node
of the CSS boxes that need to be displayed on top of the video, for the current
instance.

  • html/track/TextTrackCue.h:

(WebCore):
(TextTrackCue):

LayoutTests: Updated layout tests for basic rendering of cues.
Some Chromium tests require rebaselining and have been marked accordingly.

https://bugs.webkit.org/show_bug.cgi?id=79746

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-03-11
Reviewed by Eric Carlson.

  • media/media-controls.js: Adjusted helper function.

(mediaControlsElement):
(textTrackDisplayElement): If the method is called with only
one parameter, it returns the text track container instead of
a specific cue.

  • media/track/track-cue-mutable-text-expected.txt: Adjusted.
  • media/track/track-cue-nothing-to-render-expected.txt: Adjusted.
  • media/track/track-cue-rendering-expected.txt: Adjusted.
  • media/track/track-cue-rendering.html: Adjusted.
  • platform/chromium/test_expectations.txt: Marked tests that need to

be rebaselined accordingly.

21:04 Changeset [110408] by noel.gordon@gmail.com

Unreviewed gardening. Rebaseline svg/text/foreignObject-repaint.xml to close
out http://crbug.com/11483

  • platform/chromium-linux/svg/text/foreignObject-repaint-expected.png: Added.
  • platform/chromium/test_expectations.txt:
20:57 Changeset [110407] by ukai@chromium.org

Unreviewed, update chromium test expectations

  • platform/chromium/test_expectations.txt:
19:26 Changeset [110406] by ukai@chromium.org

Unreviewed, update chromium test expectations.

  • platform/chromium/test_expectations.txt:
18:29 Changeset [110405] by commit-queue@webkit.org

Unreviewed, rolling out r110359.
http://trac.webkit.org/changeset/110359
https://bugs.webkit.org/show_bug.cgi?id=80799

SelectPopupMenuTest.ClickItem failure (Requested by ukai on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-11

Source/WebCore:

  • platform/chromium/PopupListBox.cpp:

(WebCore::PopupListBox::paint):
(WebCore::PopupListBox::paintRow):
(WebCore::PopupListBox::getRowHeight):

  • platform/chromium/PopupListBox.h:

(PopupContainerSettings):

  • platform/chromium/PopupMenuChromium.cpp:

(WebCore):
(WebCore::PopupMenuChromium::show):

  • platform/chromium/PopupMenuChromium.h:

(PopupMenuChromium):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::showPopup):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::gestureEvent):
(WebKit::WebViewImpl::applyAutofillSuggestions):

18:29 Changeset [110404] by timothy@apple.com

Mac build fix.

18:14 Changeset [110403] by timothy@apple.com

Update how the Web Inspector resources are loaded.

https://bugs.webkit.org/show_bug.cgi?id=80798
rdar://problem/10359959

Reviewed by Brian Weinstein.

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj: Add a framework.

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.mm:

(useWebKitWebInspector): Return if we are using the WebCore resources for compatibility
with local and nightly builds.
(WebInspectorFrontendClient::localizedStringsURL): Decide what path to use.
(-[WebInspectorWindowController init]): Ditto.
(-[WebInspectorWindowController window]): Decide if the window is textured or not.

17:40 Changeset [110402] by timothy@apple.com

Fix a crash opening the Web Inspector in WebKit1 clients.

The call to InspectorFrontendClientLocal::setAttachedWindow is preformed really early in the process,
causing it to crash almost every time. It should use evaluateOnLoad instead of evaluateAsBoolean.

<rdar://problem/10951109> Crash when bringing up Web Inspector in WebKit1 client
https://bugs.webkit.org/show_bug.cgi?id=80796

Reviewed by Brian Weinstein.

  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::setAttachedWindow): Use evaluateOnLoad instead of evaluateAsBoolean.

15:17 Changeset [110401] by shawnsingh@chromium.org

REGRESSION (r93614): scrolling div does not repaint
https://bugs.webkit.org/show_bug.cgi?id=80641

Reviewed by Simon Fraser.

Source/WebCore:

Test: compositing/repaint/newly-composited-repaint-rect.html

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateBacking): When a layer
becomes newly composited and creates its backing, the repaintRect
may become invalid. This patch recomputes repaintRects in this
case.

LayoutTests:

  • compositing/repaint/newly-composited-repaint-rect-expected.png: Added.
  • compositing/repaint/newly-composited-repaint-rect-expected.txt: Added.
  • compositing/repaint/newly-composited-repaint-rect.html: Added.
15:07 Changeset [110400] by jochen@chromium.org

Merge 108780 - [v8] when a named item on document goes out of scope, actually remove it
https://bugs.webkit.org/show_bug.cgi?id=79409

Reviewed by Adam Barth.

Source/WebCore:

The original change already included the code, but it led to some
problems, so it was reverted in http://trac.webkit.org/changeset/63845.
However, not removing the items leaks a considerable amount of memory,
so I'm adding the code back. The bug that led to the revert was that
the accessor was removed unconditionally. I'm now only removing it,
when the last item with that name is removed.

Test: fast/dom/HTMLDocument/named-item.html

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::namedItemRemoved):

LayoutTests:

  • fast/dom/HTMLDocument/named-item-expected.txt: Added.
  • fast/dom/HTMLDocument/named-item.html: Added.

TBR=jochen@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9667038

13:12 Changeset [110399] by staikos@webkit.org

Enable JPEG encoding for BlackBerry.
https://bugs.webkit.org/show_bug.cgi?id=80792

Reviewed by Antonio Gomes.

  • PlatformBlackBerry.cmake:
12:52 Changeset [110398] by barraclough@apple.com

Inconsistent SyntaxError from new Function(...)
https://bugs.webkit.org/show_bug.cgi?id=59795

Rubber stamped by Oliver Hunt.

  • fast/js/function-constructor-error-expected.txt: Added.
  • fast/js/function-constructor-error.html: Added.
  • fast/js/script-tests/function-constructor-error.js: Added.
    • Adding test cases.
12:50 Changeset [110397] by mitz@apple.com

WebKit2 lacks API for obtaining a representation of the RenderLayer tree of a page, like WebRenderLayer
<http://webkit.org/b/80791>

Reviewed by Anders Carlsson.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • Shared/API/c/WKBase.h: Added a type definition of WKRenderLayerRef.
  • Shared/API/c/WKRenderLayer.cpp: Added.

(WKRenderLayerGetTypeID): Added. Returns the WKRenderLayer type ID.
(WKRenderLayerCopyRendererName): Added this getter wrapper.
(WKRenderLayerCopyElementTagName): Ditto.
(WKRenderLayerCopyElementID): Ditto.
(WKRenderLayerGetElementClassNames): Ditto.
(WKRenderLayerGetAbsoluteBounds): Ditto.
(WKRenderLayerIsClipping): Ditto.
(WKRenderLayerIsClipped): Ditto.
(WKRenderLayerIsReflection): Ditto.
(WKRenderLayerGetCompositingLayerType): Ditto.
(WKRenderLayerGetNegativeZOrderList): Ditto.
(WKRenderLayerGetNormalFlowList): Ditto.
(WKRenderLayerGetPositiveZOrderList): Ditto.

  • Shared/API/c/WKRenderLayer.h: Added.
  • Shared/APIObject.h: Added TypeRenderLayer to the APIObject::Type enum.
  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode): Added WebRenderLayer encoding.
(WebKit::UserMessageDecoder::baseDecode): Added WebRenderLayer decoding.

  • Shared/WebRenderLayer.cpp: Added.

(WebKit::WebRenderLayer::create): Added. Creates a WebRenderLayer for the page’s main
frame’s root layer.
(WebKit::WebRenderLayer::createArrayFromLayerList): Added this helper function.
(WebKit::WebRenderLayer::WebRenderLayer): Added. Constructs a WebRenderLayer with the
renderer name, element tag, ID and class names, metrics, child lists, and compositing
layer properties of the given RenderLayer.

  • Shared/WebRenderLayer.h: Added.

(WebKit::WebRenderLayer::create):
(WebKit::WebRenderLayer::negativeZOrderList):
(WebKit::WebRenderLayer::normalFlowList):
(WebKit::WebRenderLayer::positiveZOrderList):
(WebKit::WebRenderLayer::renderObjectName):
(WebKit::WebRenderLayer::elementTagName):
(WebKit::WebRenderLayer::elementID):
(WebKit::WebRenderLayer::elementClassNames):
(WebKit::WebRenderLayer::isReflection):
(WebKit::WebRenderLayer::isClipping):
(WebKit::WebRenderLayer::isClipped):
(WebKit::WebRenderLayer::compositingLayerType):
(WebKit::WebRenderLayer::absoluteBoundingBox):
(WebKit::WebRenderLayer::WebRenderLayer):

  • Target.pri
  • UIProcess/API/C/WKAPICast.h: Added a mapping between WKRenderLayerRef and WebRenderLayer.
  • WebKit2.xcodeproj/project.pbxproj: Added WebRenderLayer.{cpp,h} and WKRenderLayer.{cpp,h}.
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageCopyRenderLayerTree): Added this bundle API for getting the layer tree.

  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
  • win/WebKit2.vcproj:
11:58 Changeset [110396] by barraclough@apple.com

Source/JavaScriptCore: LLInt should support JSVALUE64
https://bugs.webkit.org/show_bug.cgi?id=79609
<rdar://problem/10063437>

Patch by Filip Pizlo <fpizlo@apple.com> on 2012-03-10
Reviewed by Gavin Barraclough and Oliver Hunt.

Ported the LLInt, which previously only worked on 32-bit, to 64-bit. This
patch moves a fair bit of code from LowLevelInterpreter32_64.asm to the common
file, LowLevelInterpreter.asm. About 1/3 of the LLInt did not have to be
specialized for value representation.

Also made some minor changes to offlineasm and the slow-paths.

  • llint/LLIntData.cpp:

(JSC::LLInt::Data::performAssertions):

  • llint/LLIntEntrypoints.cpp:
  • llint/LLIntSlowPaths.cpp:

(LLInt):
(JSC::LLInt::llint_trace_value):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::jitCompileAndSetHeuristics):

  • llint/LLIntSlowPaths.h:

(LLInt):
(SlowPathReturnType):
(JSC::LLInt::SlowPathReturnType::SlowPathReturnType):
(JSC::LLInt::encodeResult):

  • llint/LLIntThunks.cpp:
  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • offlineasm/armv7.rb:
  • offlineasm/asm.rb:
  • offlineasm/ast.rb:
  • offlineasm/backends.rb:
  • offlineasm/instructions.rb:
  • offlineasm/parser.rb:
  • offlineasm/registers.rb:
  • offlineasm/transform.rb:
  • offlineasm/x86.rb:
  • wtf/Platform.h:

LayoutTests: Object.freeze broken on latest Nightly
https://bugs.webkit.org/show_bug.cgi?id=80577

Reviewed by Oliver Hunt.

  • fast/js/preventExtensions-expected.txt:
  • fast/js/script-tests/preventExtensions.js:
    • Added test cases.
10:34 Changeset [110395] by pfeldman@chromium.org

Web Inspector: console.log attempts to substitute any "%" character in the message.
https://bugs.webkit.org/show_bug.cgi?id=80504

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: inspector/console/console-string-format.html

  • inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):

  • inspector/front-end/ProfileDataGridTree.js:
  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):

  • inspector/front-end/utilities.js:

LayoutTests:

  • inspector/console/console-string-format-expected.txt: Added.
  • inspector/console/console-string-format.html: Added.
09:35 Changeset [110394] by caseq@chromium.org

Web Inspector: use monotonically increasing time in timeline agent
https://bugs.webkit.org/show_bug.cgi?id=80786

Reviewed by Pavel Feldman.

  • bindings/v8/ScriptGCEvent.cpp:

(WebCore::ScriptGCEvent::gcPrologueCallback):
(WebCore::ScriptGCEvent::gcEpilogueCallback):

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::pushGCEventRecords):
(WebCore::InspectorTimelineAgent::willSendResourceRequest):
(WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
(WebCore::InspectorTimelineAgent::appendRecord):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):
(WebCore::InspectorTimelineAgent::timestamp):
(WebCore):

  • inspector/InspectorTimelineAgent.h:

(InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::timestamp):

08:09 Changeset [110393] by vsevik@chromium.org

Web Inspector: Network panel does not show responses for application/json data
https://bugs.webkit.org/show_bug.cgi?id=80684

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/network/async-xhr-json-mime-type.html

  • inspector/InspectorPageAgent.cpp:

(WebCore::createXHRTextDecoder):
(WebCore::InspectorPageAgent::cachedResourceContent):

  • inspector/InspectorPageAgent.h:
  • inspector/NetworkResourcesData.cpp:

(WebCore::createOtherResourceTextDecoder):
(WebCore):
(WebCore::NetworkResourcesData::responseReceived):

LayoutTests:

  • http/tests/inspector/network/async-xhr-json-mime-type-expected.txt: Added.
  • http/tests/inspector/network/async-xhr-json-mime-type.html: Added.
  • http/tests/inspector/network/resources/json.php: Added.
07:59 Changeset [110392] by vsevik@chromium.org

Web Inspector: CSS content is not shown when stylesheet is loaded with invalid mime type in quirks mode.
https://bugs.webkit.org/show_bug.cgi?id=80528

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/resource-tree/resource-tree-invalid-mime-type-css-content.html

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::cachedResourceContent):

LayoutTests:

  • http/tests/inspector/resource-tree/resource-tree-invalid-mime-type-css-content-expected.txt: Added.
  • http/tests/inspector/resource-tree/resource-tree-invalid-mime-type-css-content.html: Added.
  • http/tests/inspector/resource-tree/resources/stylesheet-text-plain.php: Added.
06:15 Changeset [110391] by pfeldman@chromium.org

Web Inspector: [chromium] add provisional test for the downstream sanity test.
https://bugs.webkit.org/show_bug.cgi?id=80784

Reviewed by Yury Semikhatsky.

  • src/js/Tests.js:

(.TestSuite.prototype.checkLogAndErrorMessages.validMessage):
(.TestSuite.prototype.checkLogAndErrorMessages.onConsoleMessage):
(.TestSuite.prototype.checkLogAndErrorMessages):

03:11 Changeset [110390] by commit-queue@webkit.org

<http://webkit.org/b/80782> Web Inspector: Crash using released frontendClient when resizing window with closed inspector

The WebInspectorFrontendClient reference should be cleared when the
WebInspectorClient::closeInspectorFrontend is called. This adds a
destroyInspectorPage to mirror createInspectorPage and clear the weak
pointers that are no longer valid.

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-03-11
Reviewed by Pavel Feldman.

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::closeInspectorFrontend):
(WebKit::WebInspectorClient::didResizeMainFrame):

  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::destroyInspectorPage):

  • WebProcess/WebPage/WebInspector.h:
01:11 Changeset [110389] by mjs@apple.com

Add --instruments option to sunspider to profile with Instruments
https://bugs.webkit.org/show_bug.cgi?id=80783

Reviewed by Filip Pizlo.

PerformanceTests/SunSpider:

  • resources/TimeProfile20us.tracetemplate: Added.
  • sunspider:

(runTestsOnce):

Tools:

  • Scripts/run-sunspider:
00:26 Changeset [110388] by ostapenko.viatcheslav@nokia.com

[Qt] [WK2] Support threaded renderer in WK2
https://bugs.webkit.org/show_bug.cgi?id=76661

Source/WebCore:

Reviewed by Noam Rosenthal.

Add TransformationMatrix conversions from/to Qt QMatrix4x4. Used by Qt WebKit2
rendering and tested by Qt WebKit2 API tests.

  • platform/graphics/qt/TransformationMatrixQt.cpp:

(WebCore::TransformationMatrix::operator QMatrix4x4):
(WebCore):
(WebCore::TransformationMatrix::TransformationMatrix):

  • platform/graphics/transforms/TransformationMatrix.h:

(TransformationMatrix):

Source/WebKit2:

Reviewed by Noam Rosenthal.

Implement Qt5 threaded rendering support for Qt WebKit2.
Parts of LayerTreeHostProxy which contain layer tree and layer painting objects
are moved to separate class called WebLayerTreeRenderer. WebLayerTreeRenderer is
thread safe ref counted and referenced by LayerTreeHostProxy and paint node.
All layer tree and graphics objects are created, accessed and deallocated from Qt
Scenegraph's paint thread only.
Layer tree updates from render queue are fetched in updatePaintNode call stack when
main thread is locked.
Messages from paint thread to web process are passed through MainThreadGuardedInvoker
call gate (implemented by Noam Rosenthal and previously reviewed by Kenneth Rohde
Christiansen).

  • Target.pri:
  • UIProcess/API/qt/qquickwebpage.cpp:

(PageProxyNode::PageProxyNode):
(PageProxyNode::render):
(PageProxyNode::~PageProxyNode):
(PageProxyNode::layerTreeRenderer):
(PageProxyNode):
(PageProxyNode::setScale):
(QQuickWebPage::updatePaintNode):
(QQuickWebPagePrivate::~QQuickWebPagePrivate):

  • UIProcess/LayerTreeHostProxy.cpp: Added.

(WebKit):
(WebKit::LayerTreeHostProxy::LayerTreeHostProxy):
(WebKit::LayerTreeHostProxy::~LayerTreeHostProxy):
(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit::LayerTreeHostProxy::paintToGraphicsContext):
(WebKit::LayerTreeHostProxy::updateViewport):
(WebKit::LayerTreeHostProxy::dispatchUpdate):
(WebKit::LayerTreeHostProxy::createTileForLayer):
(WebKit::LayerTreeHostProxy::updateTileForLayer):
(WebKit::LayerTreeHostProxy::removeTileForLayer):
(WebKit::LayerTreeHostProxy::deleteCompositingLayer):
(WebKit::LayerTreeHostProxy::setRootCompositingLayer):
(WebKit::LayerTreeHostProxy::syncCompositingLayerState):
(WebKit::LayerTreeHostProxy::didRenderFrame):
(WebKit::LayerTreeHostProxy::createDirectlyCompositedImage):
(WebKit::LayerTreeHostProxy::destroyDirectlyCompositedImage):
(WebKit::LayerTreeHostProxy::setVisibleContentsRectForPanning):
(WebKit::LayerTreeHostProxy::setVisibleContentsRectForScaling):
(WebKit::LayerTreeHostProxy::renderNextFrame):
(WebKit::LayerTreeHostProxy::purgeBackingStores):

  • UIProcess/LayerTreeHostProxy.h:

(WebKit):
(LayerTreeHostProxy):
(WebKit::LayerTreeHostProxy::layerTreeRenderer):

  • UIProcess/WebLayerTreeRenderer.cpp: Renamed from Source/WebKit2/UIProcess/qt/LayerTreeHostProxyQt.cpp.

(WebKit):
(MainThreadGuardedInvoker):
(WebKit::MainThreadGuardedInvoker::call):
(WebKit::MainThreadGuardedInvoker::MainThreadGuardedInvoker):
(WebKit::MainThreadGuardedInvoker::invoke):
(WebKit::WebLayerTreeRenderer::callOnMainTread):
(WebKit::WebLayerTreeRenderer::WebLayerTreeRenderer):
(WebKit::WebLayerTreeRenderer::~WebLayerTreeRenderer):
(WebKit::WebLayerTreeRenderer::createLayer):
(WebKit::WebLayerTreeRenderer::paintToCurrentGLContext):
(WebKit::WebLayerTreeRenderer::syncAnimations):
(WebKit::WebLayerTreeRenderer::paintToGraphicsContext):
(WebKit::WebLayerTreeRenderer::setVisibleContentsRectForScaling):
(WebKit::WebLayerTreeRenderer::updateViewport):
(WebKit::WebLayerTreeRenderer::syncLayerParameters):
(WebKit::WebLayerTreeRenderer::deleteLayer):
(WebKit::WebLayerTreeRenderer::ensureLayer):
(WebKit::WebLayerTreeRenderer::setRootLayerID):
(WebKit::WebLayerTreeRenderer::getBackingStore):
(WebKit::WebLayerTreeRenderer::createTile):
(WebKit::WebLayerTreeRenderer::removeTile):
(WebKit::WebLayerTreeRenderer::updateTile):
(WebKit::WebLayerTreeRenderer::createImage):
(WebKit::WebLayerTreeRenderer::destroyImage):
(WebKit::WebLayerTreeRenderer::assignImageToLayer):
(WebKit::WebLayerTreeRenderer::swapBuffers):
(WebKit::WebLayerTreeRenderer::flushLayerChanges):
(WebKit::WebLayerTreeRenderer::renderNextFrame):
(WebKit::WebLayerTreeRenderer::ensureRootLayer):
(WebKit::WebLayerTreeRenderer::syncRemoteContent):
(WebKit::WebLayerTreeRenderer::purgeGLResources):
(WebKit::WebLayerTreeRenderer::purgeBackingStores):
(WebKit::WebLayerTreeRenderer::detach):
(WebKit::WebLayerTreeRenderer::appendUpdate):

  • UIProcess/WebLayerTreeRenderer.h: Copied from Source/WebKit2/UIProcess/LayerTreeHostProxy.h.

(WebKit):
(WebLayerTreeRenderer):
(WebKit::WebLayerTreeRenderer::layerByID):
(WebKit::WebLayerTreeRenderer::rootLayer):
(WebKit::WebLayerTreeRenderer::notifyAnimationStarted):
(WebKit::WebLayerTreeRenderer::notifySyncRequired):
(WebKit::WebLayerTreeRenderer::showDebugBorders):
(WebKit::WebLayerTreeRenderer::showRepaintCounter):
(WebKit::WebLayerTreeRenderer::paintContents):

Tools:

Remove disabling of threaded rendering.

Reviewed by Noam Rosenthal.

  • MiniBrowser/qt/main.cpp:

(main):

Note: See TracTimeline for information about the timeline view.