Timeline


and

03/20/12:

22:50 Changeset [111504] by eric@webkit.org

Move wtf/Platform.h from JavaScriptCore to Source/WTF/wtf
https://bugs.webkit.org/show_bug.cgi?id=80911

Reviewed by Adam Barth.

.:

  • CMakeLists.txt: Define WTF_DIR

Source/JavaScriptCore:

Update the various build systems to depend on Source/WTF headers
as well as remove references to Platform.h (since it's now moved).

Source/WebCore:

  • CMakeLists.txt:
    • Look for headers in Source/WTF as well.

Source/WebKit:

  • CMakeLists.txt: Look for headers in Source/WTF.

Source/WebKit/qt:

Fix WTF header include paths since although
Source/WTF is included, no longer are all the
subdirectories (thus "RefPtr.h" can't work).

  • Api/qwebdatabase_p.h:
  • Api/qwebscriptworld_p.h:
  • Api/qwebsecurityorigin_p.h:
  • WebCoreSupport/InspectorClientQt.h:
  • WebCoreSupport/QtFallbackWebPopup.h:
  • WebCoreSupport/QtWebComboBox.h:
  • declarative/experimental/experimental.pri:
  • declarative/public.pri:
  • tests/MIMESniffing/MIMESniffing.pro:

Source/WebKit2:

Update to not depend on "Foo.h" includes for WTF headers.

  • Shared/qt/QtNetworkReplyData.h:
  • Shared/qt/QtNetworkRequestData.cpp:
  • Shared/qt/QtNetworkRequestData.h:

Source/WTF:

Update build systems to account for the new location of Platform.h

  • GNUmakefile.list.am:
  • WTF.gypi:
  • WTF.pro:
  • WTF.vcproj/WTF.vcproj:
  • WTF.vcproj/work-around-vs-dependency-tracking-bugs.py:

(react_to_vsprops_changes):

  • WTF.xcodeproj/project.pbxproj:
  • config.h: I don't think this change is 100% correct (but seemed to be needed to make qt-wk2 build)
    • This dependency on JSC should be removed regardless (in a later patch).
  • wtf/Platform.h: Renamed from Source/JavaScriptCore/wtf/Platform.h.

Tools:

Update include paths for Source/WTF.

  • DumpRenderTree/efl/CMakeLists.txt:
  • DumpRenderTree/qt/DumpRenderTree.pro:
  • QtTestBrowser/QtTestBrowser.pro:
  • Scripts/build-webkit: Build Source/WTF on AppleWin as well.
22:45 Changeset [111503] by abarth@webkit.org

svn-apply should move inflight patches from WebCore/webaudio to WebCore/Modules/webaudio
https://bugs.webkit.org/show_bug.cgi?id=81567

Reviewed by Eric Seidel.

This temporary measure should help us avoid disrupting the folks
working on WebAudio when we move the webaudio directory to Modules.

  • Scripts/VCSUtils.pm:

(adjustPathForRecentRenamings):
(parseGitDiffHeader):
(parseSvnDiffHeader):

22:29 Changeset [111502] by commit-queue@webkit.org

[chromium] Use origin transform to transform occlusion from surface content space to its target content space
https://bugs.webkit.org/show_bug.cgi?id=81730

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-20
Reviewed by Adrienne Walker.

Source/WebCore:

Unit test: CCOcclusionTrackerTestSurfaceOcclusionTranslatesToParent

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::transformSurfaceOpaqueRegion):
(WebCore::::leaveToTargetRenderSurface):

Source/WebKit/chromium:

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore):
(CCOcclusionTrackerTestSurfaceOcclusionTranslatesToParent):
(WebCore::CCOcclusionTrackerTestSurfaceOcclusionTranslatesToParent::runMyTest):

22:26 Changeset [111501] by keishi@webkit.org

Adding MISSING to platform/qt for platform/qt/plugins/application-plugin-plugins-disabled.html

  • platform/chromium/test_expectations.txt:
22:12 Changeset [111500] by shinyak@chromium.org

[Crash] RenderMenuList::addChild() in Shadow DOM.
https://bugs.webkit.org/show_bug.cgi?id=81201

Reviewed by Dimitri Glazkov.

Source/WebCore:

<audio>, <video>, <meter>, <progress>, and <select> are implemented using
Shadow DOM having HTMLContentElement. Their renderer children basically should not
create a renderer unless they are on the upper shadow encapsulation boundary,
which means they are the direct children of the shadow root.

However, current implementation allows their renderer children to create a renderer
even if they are on a lower shadow encapsulation boundary, which means
they are distributed elements of HTMLContentElement.

This patch makes there renderer children not to create a renderer if they are on a lower shadow
encapsulation boudary.

Tests: fast/dom/shadow/content-element-in-media-element.html

fast/dom/shadow/content-element-in-meter-element.html
fast/dom/shadow/content-element-in-progress-element.html
fast/dom/shadow/content-element-in-select-element.html

  • dom/NodeRenderingContext.h:

(NodeRenderingContext):
(WebCore::NodeRenderingContext::isOnUpperEncapsulationBoundary):
(WebCore):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::childShouldCreateRenderer):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::childShouldCreateRenderer):

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::childShouldCreateRenderer):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::childShouldCreateRenderer):

LayoutTests:

Skipped these tests in non-chromium port since SHADOW_DOM flag is not enabled.

Marked 2 new tests FAIL. Their behavior is affected by this patch, but this patch
won't fix them completely. They have another bugs. See Bug 81310 and Bug 81311.

  • fast/dom/shadow/content-element-in-media-element-expected.txt: Added.
  • fast/dom/shadow/content-element-in-media-element.html: Added.
  • fast/dom/shadow/content-element-in-meter-element-expected.txt: Added.
  • fast/dom/shadow/content-element-in-meter-element.html: Added.
  • fast/dom/shadow/content-element-in-progress-element-expected.txt: Added.
  • fast/dom/shadow/content-element-in-progress-element.html: Added.
  • fast/dom/shadow/content-element-in-select-element-expected.txt: Added.
  • fast/dom/shadow/content-element-in-select-element.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
22:02 Changeset [111499] by commit-queue@webkit.org

[chromium] Store origin/screen space transforms for surface and replica in the surface
https://bugs.webkit.org/show_bug.cgi?id=81296

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-20
Reviewed by Adrienne Walker.

Source/WebCore:

Compute and save a number of transforms for render surfaces. The origin
tranform for the replica into its target surface. The origin transform
for the replica into the screen. And the origin transform for the surface
into the screen.

These transforms will allow us to detect occlusion of render surfaces,
allowing us to cull (or partially-cull) the render surface quad during
drawing.

This also fixes a subtle bug in the transforms used by the damage
tracking code.

Unit test: CCLayerTreeHostCommonTest.verifyTransformsForSingleRenderSurface

CCLayerTreeHostCommonTest.verifyTransformsForReplica
CCLayerTreeHostCommonTest.verifyTransformsForRenderSurfaceHierarchy

  • platform/graphics/chromium/RenderSurfaceChromium.h:

(WebCore::RenderSurfaceChromium::screenSpaceTransform):
(WebCore::RenderSurfaceChromium::setScreenSpaceTransform):
(RenderSurfaceChromium):
(WebCore::RenderSurfaceChromium::replicaOriginTransform):
(WebCore::RenderSurfaceChromium::setReplicaOriginTransform):
(WebCore::RenderSurfaceChromium::replicaScreenSpaceTransform):
(WebCore::RenderSurfaceChromium::setReplicaScreenSpaceTransform):

  • platform/graphics/chromium/cc/CCDamageTracker.cpp:

(WebCore::CCDamageTracker::extendDamageForRenderSurface):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsAndVisibilityInternal):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::damageInSurfaceSpace):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore::CCRenderSurface::setDrawTransform):
(WebCore::CCRenderSurface::drawTransform):
(WebCore::CCRenderSurface::setScreenSpaceTransform):
(WebCore::CCRenderSurface::screenSpaceTransform):
(CCRenderSurface):
(WebCore::CCRenderSurface::setReplicaDrawTransform):
(WebCore::CCRenderSurface::replicaDrawTransform):
(WebCore::CCRenderSurface::setReplicaOriginTransform):
(WebCore::CCRenderSurface::replicaOriginTransform):
(WebCore::CCRenderSurface::setReplicaScreenSpaceTransform):
(WebCore::CCRenderSurface::replicaScreenSpaceTransform):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostCommonTest.cpp:

(WebCore::TEST):

21:47 Changeset [111498] by mitz@apple.com

Skipped editing/selection/move-by-word-visually-crash-test-5.html in WebKit2 because of
<http://webkit.org/b/42689> WebKitTestRunner needs layoutTestController.setEditingBehavior

  • platform/wk2/Skipped:
21:46 Changeset [111497] by commit-queue@webkit.org

[Forms] The option element should not be form associated element.
https://bugs.webkit.org/show_bug.cgi?id=79764

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-20
Reviewed by Kent Tamura.

Source/WebCore:

This patch changes base class of HTMLOptionELement to HTMLElement
from HTMLFormControlElement for saving memory space and iteration
time of extra "option" elements in HTMLFormElement::m_formAssociatedElements
and matching the HTML5 specification for ease of maintenance.

This patch changes behavior of handling of CSS pseudo classes "invalid"
and "valid". The "option" elements no longer use these CSS pseudo classes
as HTML5 specification. This bug was filed in https://bugs.webkit.org/show_bug.cgi?id=80088

Changes of TextIterator is lead by usage of isFormControlElement. This
changes will be replaced with more meaningful predicate as part of
https://bugs.webkit.org/show_bug.cgi?id=80381

No new tests but updated select-live-pseudo-selectors.html test.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithElement): Added checking of the "option" element and returns false as HTMLFormControlElement.

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOneSelector): Removed isFormControlElement for PseudoDisabled and PseudoChecked.

  • html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::HTMLKeygenElement): Removed form parameter of call site of HTMLOptionElement::create.

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::HTMLOptionElement): Removed form parameter which no longer needed. Changed base class in initialization list. Added m_disabled initialization.
(WebCore::HTMLOptionElement::create): Removed form parameter which no longer needed.
(WebCore::HTMLOptionElement::attach): Changeid base class.
(WebCore::HTMLOptionElement::detach): Changed base class.
(WebCore::HTMLOptionElement::parseAttribute): Changed base class. Added "disabled" attribute handling.
(WebCore::HTMLOptionElement::childrenChanged): Changed base class.
(WebCore::HTMLOptionElement::insertedIntoTree): Changed base class.

  • html/HTMLOptionElement.h:

(HTMLOptionElement): Added new member variable m_disabled which was in HTMLFormControlElement.
(WebCore::HTMLOptionElement::ownElementDisabled): Changed for using m_disabled.

  • html/HTMLTagNames.in: Removed constructorNeedsFormElement for the "option" element, which was used for passing form parameter to create function.

LayoutTests:

This patch fixes a bug in select-live-pseudo-selectors.js, adds
assertions to improve coverage, and updates test expectation for
behavior changes (makes the "option" element uses CSS pseudo class
":valid".)

  • fast/forms/resources/select-live-pseudo-selectors.js:

(mouseDownOnSelect): Copied from listbox-selection.html for replacing broken simulateClick which used position and size of the "option" element, but these values are zero. Note: five files use mouseDownOnSelect. We'll share this function in future tracked by https://bugs.webkit.org/show_bug.cgi?id=81496.
(backgroundOf): Added String parameter support for ease of writing test case.

  • fast/forms/select-live-pseudo-selectors-expected.txt: Added check fo background color of the "selection" element. Changed expected color of the "option" element because the "option" element doesn't support CSS pseudo class ":valid". This also covers bug 80088.
21:33 Changeset [111496] by mitz@apple.com

Skipped fast/selectors/selection-window-inactive.html in WebKit2 because of
<http://webkit.org/b/81736> layoutTestController.setWindowIsKey() has no effect on the web process side in WebKit2

  • platform/wk2/Skipped:
21:23 Changeset [111495] by mitz@apple.com

Skipped fast/events/blur-focus-window-should-blur-focus-element.html in WebKit2 because of
<http://webkit.org/b/81736> layoutTestController.setWindowIsKey() has no effect on the web process side in WebKit2

  • platform/wk2/Skipped:
21:18 Changeset [111494] by keishi@webkit.org

[chromium] Marking canvas-toDataURL-webp.html as crashing and timing out.

  • platform/chromium/test_expectations.txt:
21:01 Changeset [111493] by andersca@apple.com

REGRESSION (r110780): Loading a PDF always makes the WKView layer backed
https://bugs.webkit.org/show_bug.cgi?id=81734
<rdar://problem/11088172>

Reviewed by Adele Peterson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _setPageHasCustomRepresentation:]):
Don't call -[NSView setWantsLayer:], the web process already takes care of entering and exiting
accelerated compositing mode for us.

20:56 Changeset [111492] by xji@chromium.org

Crash introduced in r110965.
https://bugs.webkit.org/show_bug.cgi?id=81720

Reviewed by Ryosuke Niwa.

Source/WebCore:

Since word break iterator just keeps a pointer to the UChar array given to the constructor,
we need to allocate the UChar array deeper in the stack than the iterator.

Test: editing/selection/move-by-word-visually-crash-test-5.html

  • editing/visible_units.cpp:

(WebCore::wordBreakIteratorForMinOffsetBoundary):
(WebCore::wordBreakIteratorForMaxOffsetBoundary):
(WebCore::visualWordPosition):

LayoutTests:

  • editing/selection/move-by-word-visually-crash-test-5-expected.txt: Added.
  • editing/selection/move-by-word-visually-crash-test-5.html: Added.
20:50 Changeset [111491] by cevans@google.com

Merge 110541
BUG=117545
Review URL: https://chromiumcodereview.appspot.com/9801010

20:46 Changeset [111490] by cevans@google.com

Merge 110563
BUG=117471
Review URL: https://chromiumcodereview.appspot.com/9802004

20:41 Changeset [111489] by keishi@webkit.org

[chromium] Marking integer-division-neg2tothe32-by-neg1.html as crashing.

  • platform/chromium/test_expectations.txt:
20:39 Changeset [111488] by lforschler@apple.com

Merged r111162.

19:31 Changeset [111487] by keishi@webkit.org

[chromium] Rebaselining font-family-pictograph.html on Mac.

  • fast/css/font-family-pictograph-expected.png: Renamed from LayoutTests/platform/efl/fast/css/font-family-pictograph-expected.png.
  • fast/css/font-family-pictograph-expected.txt: Copied from LayoutTests/platform/efl/fast/css/font-family-pictograph-expected.txt.
  • platform/chromium-mac/fast/css/font-family-pictograph-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/font-family-pictograph-expected.txt.
  • platform/gtk/fast/css/font-family-pictograph-expected.png: Removed.
19:31 Changeset [111486] by cevans@google.com

Merge 111108
BUG=117550
Review URL: https://chromiumcodereview.appspot.com/9768010

19:28 Changeset [111485] by keishi@webkit.org

[chromium] Rebaselining for Linux 32.

  • platform/chromium-linux-x86/fast/dom/error-to-string-stack-overflow-expected.txt: Added.
19:18 Changeset [111484] by adamk@chromium.org

Unskip the over one thousand dom/xhtml tests that pass
https://bugs.webkit.org/show_bug.cgi?id=81709

Reviewed by Tony Chang.

I recently ran into a case where a test in dom/xhtml caught a
regression in a patch (r111310). Seems like we should at least run
those tests that pass in this suite. I've left the other tests
skipped, though I'm open to rebaselining or running them with failing
expectations.

  • platform/chromium/test_expectations.txt:
19:06 Changeset [111483] by wjmaclean@chromium.org

[chromium] Convert TouchFlingPlatformGestureCurve to a 2-D Bezier for better control of curve shape.
https://bugs.webkit.org/show_bug.cgi?id=81713

Reviewed by Dirk Pranke.

Source/WebCore:

Exisiting unit test revised to cover this change.

Change the fling gesture animation curve to use a 2-D Bezier to obtain greater control
over the shape of the curve. Also, change time scaling code to be logarithmic for more
natural feel.

  • platform/TouchFlingPlatformGestureCurve.cpp:

(WebCore::TouchFlingPlatformGestureCurve::TouchFlingPlatformGestureCurve):
(WebCore::TouchFlingPlatformGestureCurve::apply):

Source/WebKit/chromium:

  • tests/PlatformGestureCurveTest.cpp:
19:00 Changeset [111482] by tkent@chromium.org

Revert 105710 - Introduce RadioButtonGroup class to keep track of the group members and required state
https://bugs.webkit.org/show_bug.cgi?id=74909

Reviewed by Darin Adler.

Source/WebCore:

RadioButtonGroup contains a set of member radio buttons in the group,
and "required" status of the group. This helps implementing correct
radio button validity, and improving performance of updating validity
status of radio buttons.

This change fixes the following bugs:

Tests: fast/forms/radio/radio-live-validation-style.html

perf/adding-radio-buttons.html

  • dom/CheckedRadioButtons.cpp:

(WebCore::RadioButtonGroup::isEmpty):
(WebCore::RadioButtonGroup::isRequired):
(WebCore::RadioButtonGroup::checkedButton):
(WebCore::RadioButtonGroup::RadioButtonGroup):
(WebCore::RadioButtonGroup::create):
(WebCore::RadioButtonGroup::isValid):
(WebCore::RadioButtonGroup::setCheckedButton):
(WebCore::RadioButtonGroup::add):
(WebCore::RadioButtonGroup::updateCheckedState):
(WebCore::RadioButtonGroup::requiredAttributeChanged):
(WebCore::RadioButtonGroup::remove):
(WebCore::RadioButtonGroup::setNeedsValidityCheckForAllButtons):
Add RadioButtonGroup class. It keeps track of pointers to member radio
buttons and required status of the group in addition to the checked
radio button pointer.

(WebCore::CheckedRadioButtons::CheckedRadioButtons):
(WebCore::CheckedRadioButtons::~CheckedRadioButtons):
Define empty constructor and destructor in order to avoid exposing
RadioButtonGroup class.

(WebCore::CheckedRadioButtons::addButton):
(WebCore::CheckedRadioButtons::updateCheckedState):
(WebCore::CheckedRadioButtons::requiredAttributeChanged):
(WebCore::CheckedRadioButtons::checkedButtonForGroup):
(WebCore::CheckedRadioButtons::isInRequiredGroup):
(WebCore::CheckedRadioButtons::removeButton):
Change the HashMap member of this class so that it maps a group name to
a RadioButtonGroup object. These functions just get a RadioButtonGroup
object and call a corresponding member function of RadioButtonGroup.

  • dom/CheckedRadioButtons.h: Update declarations.
  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::parseMappedAttribute):
(WebCore::HTMLFormControlElement::requiredAttributeChanged):
Move a part of parseMappedAttribute() into requiredAttributeChanged().

  • html/HTMLFormControlElement.h: Add requiredAttributeChanged().
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::valueMissing):
Move required check code to InputType::valueMissing implementations.
RadioInputType needs special handling for checking required state.
readOnly() and disabled() are unnecessary because willValidate() checks them.
(WebCore::HTMLInputElement::setChecked):
Call new function CheckedRadioButtons::updateCheckedState() instead of
removeButton() and updateCheckedRadioButtons().
(WebCore::HTMLInputElement::requiredAttributeChanged):
Override this to call CheckedRadioButtons::requiredAttributeChanged().

  • html/HTMLInputElement.h: Add requiredAttributeChanged().
  • html/RadioInputType.cpp:

(WebCore::RadioInputType::valueMissing):
Check required state by CheckedRadioButtons::isInRequiredGroup().

  • html/RadioInputType.h: Remove attach().
  • html/CheckboxInputType.cpp:

(WebCore::CheckboxInputType::valueMissing):

Move required check from HTMLInputElement::valueMissing().

  • html/FileInputType.cpp:

(WebCore::FileInputType::valueMissing): ditto.

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::valueMissing): ditto.

LayoutTests:

  • fast/forms/radio/radio-live-validation-style-expected.txt: Added.
  • fast/forms/radio/radio-live-validation-style.html: Added.
  • fast/forms/script-tests/ValidityState-valueMissing-radio.js:
  • Update the expectation for the behavior change of https://bugs.webkit.org/show_bug.cgi?id=76365
  • Add test cases for radio buttons not in a radio button group.
  • fast/forms/ValidityState-valueMissing-radio-expected.txt: ditto.
  • perf/adding-radio-buttons-expected.txt: Added.
  • perf/adding-radio-buttons.html: Added.

TBR=tkent@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9805002

18:29 Changeset [111481] by fpizlo@apple.com

op_mod fails on many interesting corner cases
https://bugs.webkit.org/show_bug.cgi?id=81648

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Removed most strength reduction for op_mod, and fixed the integer handling
to do the right thing for corner cases. Oddly, this revealed bugs in OSR,
which this patch also fixes.

This patch is performance neutral on all of the major benchmarks we track.

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.cpp:

(DFG):
(JSC::DFG::SpeculativeJIT::compileSoftModulo):
(JSC::DFG::SpeculativeJIT::compileArithMod):

  • jit/JIT.h:

(JIT):

  • jit/JITArithmetic.cpp:

(JSC):
(JSC::JIT::emit_op_mod):
(JSC::JIT::emitSlow_op_mod):

  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emit_op_mod):
(JSC::JIT::emitSlow_op_mod):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC):

  • jit/JITStubs.h:

(TrampolineStructure):
(JSC::JITThunks::ctiNativeConstruct):

  • llint/LowLevelInterpreter64.asm:
  • wtf/Platform.h:
  • wtf/SimpleStats.h:

(WTF::SimpleStats::variance):

LayoutTests:

Reviewed by Oliver Hunt.

  • fast/js/integer-division-neg2tothe32-by-neg1-expected.txt: Added.
  • fast/js/integer-division-neg2tothe32-by-neg1.html: Added.
  • fast/js/script-tests/integer-division-neg2tothe32-by-neg1.js: Added.

(myDiv):
(myDivByNeg1):
(myDivNeg2ToThe31):
(myMod):
(myModByNeg1):
(myModNeg2ToThe31):
(myOtherDiv):
(myOtherDivByNeg1):
(myOtherDivNeg2ToThe31):
(myOtherMod):
(myOtherModByNeg1):
(myOtherModNeg2ToThe31):

18:19 Changeset [111480] by morrita@google.com

Infinite repaint loop with SVGImageCache and deferred repaint timers
https://bugs.webkit.org/show_bug.cgi?id=78315
<rdar://problem/10651634>

Patch by Tim Horton <timothy_horton@apple.com> on 2012-03-18
Reviewed by Nikolas Zimmermann.

Only defer image redraw on a timer if we're in layout. This breaks
the repaint loop while still preventing us from drawing inside layout.

Completely disable repaint during relayout inside SVGImage::drawSVGToImageBuffer,
preventing deferred repaint timers from being started during that process.

No new tests, as the problem only occurs in a nonstandard configuration.

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::endDeferredRepaints):
(WebCore::FrameView::startDeferredRepaintTimer):
(WebCore):
(WebCore::FrameView::doDeferredRepaints):
(WebCore::FrameView::deferredRepaintTimerFired):
(WebCore::FrameView::beginDisableRepaints):
(WebCore::FrameView::endDisableRepaints):

  • page/FrameView.h:

(FrameView):
(WebCore::FrameView::repaintsDisabled):

  • rendering/RenderView.cpp:

(WebCore::RenderView::shouldRepaint):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawSVGToImageBuffer):
(WebCore::SVGImage::draw):
(WebCore::SVGImage::frameView):
(WebCore):

  • svg/graphics/SVGImage.h:

(WebCore):

  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::imageContentChanged):
(WebCore::SVGImageCache::redraw):
(WebCore::SVGImageCache::redrawTimerFired):
(WebCore):

  • svg/graphics/SVGImageCache.h:

(SVGImageCache):

18:01 Changeset [111479] by cevans@google.com

Merge 111108
BUG=117550
Review URL: https://chromiumcodereview.appspot.com/9766014

17:48 Changeset [111478] by adamk@chromium.org

Include fix for dom/xhtml test promised in r111449.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::replaceChild): Check against next instead of
prev when deciding there's no work to do.

17:36 Changeset [111477] by jonlee@apple.com

Unreviewed. Because we might short-circuit permission calls, some of these tests need to be rewritten
to take that factor into account. There's no mac support of notifications right now (see 79492),
so updating test expectations for now and tracking as a regression in 81697.

  • platform/chromium/test_expectations.txt:
17:34 Changeset [111476] by jonlee@apple.com

Restrict access to notifications for unique origins and file URLs with no local file access
https://bugs.webkit.org/show_bug.cgi?id=79704
<rdar://problem/10912430>

Reviewed by Adam Barth.

Source/WebCore:

Before checking or requesting permissions, we look at whether we can show notifications based on
the security context. If not, we short circuit and do not forward the request to the client.

  • notifications/Notification.cpp:

(WebCore::Notification::Notification): Fix a bug where creating a notification goes through slightly
different logic for checking permissions than when checking permissions through the
notification center.

  • notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::checkPermission): Check to see if the origin can show notifications.
(WebCore::NotificationCenter::requestPermission): If we know whether an origin can show notifications,
we asynchronously call the callback with that decision. Otherwise we ask the client.

Add new variable in the notification center to keep track of pending callbacks when we short-circuit
requestPermission().

  • notifications/NotificationCenter.h:

(NotificationRequestCallback): Add new private class encapsulating the callback.

  • notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::requestTimedOut): Remove the request from the set of pending callbacks.
(WebCore::NotificationCenter::NotificationRequest::createAndStartTimer): Because this is used when we already
know the decision, and are not asking the client to decide, we can immediately trigger a one-shot timer
to invoke the callback.
(WebCore::NotificationCenter::NotificationRequest::NotificationRequest):
(WebCore::NotificationCenter::NotificationRequest::startTimer):
(WebCore::NotificationCenter::NotificationRequest::timerFired): Invoke the callback and tell the notification
center.

  • page/SecurityOrigin.h: Add new toRawString() method to return the string representation of the origin,

regardless of any restrictions that might otherwise cause toString() to return "null".

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::canShowNotifications): Added to return a tri-state regarding whether we know
the origin can show notifications. If the origin is unique, we never let it show. If the origin has
universal access, we always let it show. Otherwise the client should be asked.
(WebCore::SecurityOrigin::toString): Refactor to use toRawString().
(WebCore::SecurityOrigin::toRawString):

Added FIXME's regarding the naming of enforceFilePathSeparation().

  • dom/Document.cpp:

(WebCore::Document::initSecurityContext): Also, tab reformatting.

  • WebCore.exp.in: Export toRawString().

Source/WebKit2:

In the specific case where a file URL has restricted file access and is denied universal access,
SecurityOrigin::canShowNotifications() returns Ask, since it is not considered a unique origin.
The cached table of permissions held by the notification manager will typically not have an entry for
the toString() representation of these file URLs, which is "null", since that can also cover unique
origins, and it is possible that the client will want different permissions between the two types.

It is reasonable, however, for there to be an entry for "file://", so we use toRawString() to do the lookup.

  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::policyForOrigin):

17:32 Changeset [111475] by abarth@webkit.org

Revert 105389 - [v8] Low efficiency of writing long string from web application to plugin.
https://bugs.webkit.org/show_bug.cgi?id=76592

The efficiency will be improved by 300 times in the best case, when the
size of string reaches 1MB.

Patch by Li Yin <li.yin@intel.com> on 2012-01-18
Reviewed by Adam Barth.

  • bindings/v8/V8NPUtils.cpp:

(WebCore::convertV8ObjectToNPVariant):

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9766013

17:30 Changeset [111474] by haraken@chromium.org

Move webaudio to Modules/webaudio/
https://bugs.webkit.org/show_bug.cgi?id=81541

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-03-20
Reviewed by Kentaro Hara.

No new tests, all existing tests pass.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • Modules/webaudio: Added.
  • Modules/webaudio/AsyncAudioDecoder.cpp: Copied from Source/WebCore/webaudio/AsyncAudioDecoder.cpp.
  • Modules/webaudio/AsyncAudioDecoder.h: Copied from Source/WebCore/webaudio/AsyncAudioDecoder.h.
  • Modules/webaudio/AudioBasicProcessorNode.cpp: Copied from Source/WebCore/webaudio/AudioBasicProcessorNode.cpp.
  • Modules/webaudio/AudioBasicProcessorNode.h: Copied from Source/WebCore/webaudio/AudioBasicProcessorNode.h.
  • Modules/webaudio/AudioBuffer.cpp: Copied from Source/WebCore/webaudio/AudioBuffer.cpp.
  • Modules/webaudio/AudioBuffer.h: Copied from Source/WebCore/webaudio/AudioBuffer.h.
  • Modules/webaudio/AudioBuffer.idl: Copied from Source/WebCore/webaudio/AudioBuffer.idl.
  • Modules/webaudio/AudioBufferCallback.h: Copied from Source/WebCore/webaudio/AudioBufferCallback.h.
  • Modules/webaudio/AudioBufferCallback.idl: Copied from Source/WebCore/webaudio/AudioBufferCallback.idl.
  • Modules/webaudio/AudioBufferSourceNode.cpp: Copied from Source/WebCore/webaudio/AudioBufferSourceNode.cpp.
  • Modules/webaudio/AudioBufferSourceNode.h: Copied from Source/WebCore/webaudio/AudioBufferSourceNode.h.
  • Modules/webaudio/AudioBufferSourceNode.idl: Copied from Source/WebCore/webaudio/AudioBufferSourceNode.idl.
  • Modules/webaudio/AudioChannelMerger.cpp: Copied from Source/WebCore/webaudio/AudioChannelMerger.cpp.
  • Modules/webaudio/AudioChannelMerger.h: Copied from Source/WebCore/webaudio/AudioChannelMerger.h.
  • Modules/webaudio/AudioChannelMerger.idl: Copied from Source/WebCore/webaudio/AudioChannelMerger.idl.
  • Modules/webaudio/AudioChannelSplitter.cpp: Copied from Source/WebCore/webaudio/AudioChannelSplitter.cpp.
  • Modules/webaudio/AudioChannelSplitter.h: Copied from Source/WebCore/webaudio/AudioChannelSplitter.h.
  • Modules/webaudio/AudioChannelSplitter.idl: Copied from Source/WebCore/webaudio/AudioChannelSplitter.idl.
  • Modules/webaudio/AudioContext.cpp: Copied from Source/WebCore/webaudio/AudioContext.cpp.
  • Modules/webaudio/AudioContext.h: Copied from Source/WebCore/webaudio/AudioContext.h.
  • Modules/webaudio/AudioContext.idl: Copied from Source/WebCore/webaudio/AudioContext.idl.
  • Modules/webaudio/AudioDestinationNode.cpp: Copied from Source/WebCore/webaudio/AudioDestinationNode.cpp.
  • Modules/webaudio/AudioDestinationNode.h: Copied from Source/WebCore/webaudio/AudioDestinationNode.h.
  • Modules/webaudio/AudioDestinationNode.idl: Copied from Source/WebCore/webaudio/AudioDestinationNode.idl.
  • Modules/webaudio/AudioGain.h: Copied from Source/WebCore/webaudio/AudioGain.h.
  • Modules/webaudio/AudioGain.idl: Copied from Source/WebCore/webaudio/AudioGain.idl.
  • Modules/webaudio/AudioGainNode.cpp: Copied from Source/WebCore/webaudio/AudioGainNode.cpp.
  • Modules/webaudio/AudioGainNode.h: Copied from Source/WebCore/webaudio/AudioGainNode.h.
  • Modules/webaudio/AudioGainNode.idl: Copied from Source/WebCore/webaudio/AudioGainNode.idl.
  • Modules/webaudio/AudioListener.cpp: Copied from Source/WebCore/webaudio/AudioListener.cpp.
  • Modules/webaudio/AudioListener.h: Copied from Source/WebCore/webaudio/AudioListener.h.
  • Modules/webaudio/AudioListener.idl: Copied from Source/WebCore/webaudio/AudioListener.idl.
  • Modules/webaudio/AudioNode.cpp: Copied from Source/WebCore/webaudio/AudioNode.cpp.
  • Modules/webaudio/AudioNode.h: Copied from Source/WebCore/webaudio/AudioNode.h.
  • Modules/webaudio/AudioNode.idl: Copied from Source/WebCore/webaudio/AudioNode.idl.
  • Modules/webaudio/AudioNodeInput.cpp: Copied from Source/WebCore/webaudio/AudioNodeInput.cpp.
  • Modules/webaudio/AudioNodeInput.h: Copied from Source/WebCore/webaudio/AudioNodeInput.h.
  • Modules/webaudio/AudioNodeOutput.cpp: Copied from Source/WebCore/webaudio/AudioNodeOutput.cpp.
  • Modules/webaudio/AudioNodeOutput.h: Copied from Source/WebCore/webaudio/AudioNodeOutput.h.
  • Modules/webaudio/AudioPannerNode.cpp: Copied from Source/WebCore/webaudio/AudioPannerNode.cpp.
  • Modules/webaudio/AudioPannerNode.h: Copied from Source/WebCore/webaudio/AudioPannerNode.h.
  • Modules/webaudio/AudioPannerNode.idl: Copied from Source/WebCore/webaudio/AudioPannerNode.idl.
  • Modules/webaudio/AudioParam.cpp: Copied from Source/WebCore/webaudio/AudioParam.cpp.
  • Modules/webaudio/AudioParam.h: Copied from Source/WebCore/webaudio/AudioParam.h.
  • Modules/webaudio/AudioParam.idl: Copied from Source/WebCore/webaudio/AudioParam.idl.
  • Modules/webaudio/AudioParamTimeline.cpp: Copied from Source/WebCore/webaudio/AudioParamTimeline.cpp.
  • Modules/webaudio/AudioParamTimeline.h: Copied from Source/WebCore/webaudio/AudioParamTimeline.h.
  • Modules/webaudio/AudioProcessingEvent.cpp: Copied from Source/WebCore/webaudio/AudioProcessingEvent.cpp.
  • Modules/webaudio/AudioProcessingEvent.h: Copied from Source/WebCore/webaudio/AudioProcessingEvent.h.
  • Modules/webaudio/AudioProcessingEvent.idl: Copied from Source/WebCore/webaudio/AudioProcessingEvent.idl.
  • Modules/webaudio/AudioSourceNode.h: Copied from Source/WebCore/webaudio/AudioSourceNode.h.
  • Modules/webaudio/AudioSourceNode.idl: Copied from Source/WebCore/webaudio/AudioSourceNode.idl.
  • Modules/webaudio/BiquadDSPKernel.cpp: Copied from Source/WebCore/webaudio/BiquadDSPKernel.cpp.
  • Modules/webaudio/BiquadDSPKernel.h: Copied from Source/WebCore/webaudio/BiquadDSPKernel.h.
  • Modules/webaudio/BiquadFilterNode.cpp: Copied from Source/WebCore/webaudio/BiquadFilterNode.cpp.
  • Modules/webaudio/BiquadFilterNode.h: Copied from Source/WebCore/webaudio/BiquadFilterNode.h.
  • Modules/webaudio/BiquadFilterNode.idl: Copied from Source/WebCore/webaudio/BiquadFilterNode.idl.
  • Modules/webaudio/BiquadProcessor.cpp: Copied from Source/WebCore/webaudio/BiquadProcessor.cpp.
  • Modules/webaudio/BiquadProcessor.h: Copied from Source/WebCore/webaudio/BiquadProcessor.h.
  • Modules/webaudio/ConvolverNode.cpp: Copied from Source/WebCore/webaudio/ConvolverNode.cpp.
  • Modules/webaudio/ConvolverNode.h: Copied from Source/WebCore/webaudio/ConvolverNode.h.
  • Modules/webaudio/ConvolverNode.idl: Copied from Source/WebCore/webaudio/ConvolverNode.idl.
  • Modules/webaudio/DOMWindowWebAudio.idl: Copied from Source/WebCore/webaudio/DOMWindowWebAudio.idl.
  • Modules/webaudio/DefaultAudioDestinationNode.cpp: Copied from Source/WebCore/webaudio/DefaultAudioDestinationNode.cpp.
  • Modules/webaudio/DefaultAudioDestinationNode.h: Copied from Source/WebCore/webaudio/DefaultAudioDestinationNode.h.
  • Modules/webaudio/DelayDSPKernel.cpp: Copied from Source/WebCore/webaudio/DelayDSPKernel.cpp.
  • Modules/webaudio/DelayDSPKernel.h: Copied from Source/WebCore/webaudio/DelayDSPKernel.h.
  • Modules/webaudio/DelayNode.cpp: Copied from Source/WebCore/webaudio/DelayNode.cpp.
  • Modules/webaudio/DelayNode.h: Copied from Source/WebCore/webaudio/DelayNode.h.
  • Modules/webaudio/DelayNode.idl: Copied from Source/WebCore/webaudio/DelayNode.idl.
  • Modules/webaudio/DelayProcessor.cpp: Copied from Source/WebCore/webaudio/DelayProcessor.cpp.
  • Modules/webaudio/DelayProcessor.h: Copied from Source/WebCore/webaudio/DelayProcessor.h.
  • Modules/webaudio/DynamicsCompressorNode.cpp: Copied from Source/WebCore/webaudio/DynamicsCompressorNode.cpp.
  • Modules/webaudio/DynamicsCompressorNode.h: Copied from Source/WebCore/webaudio/DynamicsCompressorNode.h.
  • Modules/webaudio/DynamicsCompressorNode.idl: Copied from Source/WebCore/webaudio/DynamicsCompressorNode.idl.
  • Modules/webaudio/HighPass2FilterNode.cpp: Copied from Source/WebCore/webaudio/HighPass2FilterNode.cpp.
  • Modules/webaudio/HighPass2FilterNode.h: Copied from Source/WebCore/webaudio/HighPass2FilterNode.h.
  • Modules/webaudio/HighPass2FilterNode.idl: Copied from Source/WebCore/webaudio/HighPass2FilterNode.idl.
  • Modules/webaudio/JavaScriptAudioNode.cpp: Copied from Source/WebCore/webaudio/JavaScriptAudioNode.cpp.
  • Modules/webaudio/JavaScriptAudioNode.h: Copied from Source/WebCore/webaudio/JavaScriptAudioNode.h.
  • Modules/webaudio/JavaScriptAudioNode.idl: Copied from Source/WebCore/webaudio/JavaScriptAudioNode.idl.
  • Modules/webaudio/LowPass2FilterNode.cpp: Copied from Source/WebCore/webaudio/LowPass2FilterNode.cpp.
  • Modules/webaudio/LowPass2FilterNode.h: Copied from Source/WebCore/webaudio/LowPass2FilterNode.h.
  • Modules/webaudio/LowPass2FilterNode.idl: Copied from Source/WebCore/webaudio/LowPass2FilterNode.idl.
  • Modules/webaudio/MediaElementAudioSourceNode.cpp: Copied from Source/WebCore/webaudio/MediaElementAudioSourceNode.cpp.
  • Modules/webaudio/MediaElementAudioSourceNode.h: Copied from Source/WebCore/webaudio/MediaElementAudioSourceNode.h.
  • Modules/webaudio/MediaElementAudioSourceNode.idl: Copied from Source/WebCore/webaudio/MediaElementAudioSourceNode.idl.
  • Modules/webaudio/OfflineAudioCompletionEvent.cpp: Copied from Source/WebCore/webaudio/OfflineAudioCompletionEvent.cpp.
  • Modules/webaudio/OfflineAudioCompletionEvent.h: Copied from Source/WebCore/webaudio/OfflineAudioCompletionEvent.h.
  • Modules/webaudio/OfflineAudioCompletionEvent.idl: Copied from Source/WebCore/webaudio/OfflineAudioCompletionEvent.idl.
  • Modules/webaudio/OfflineAudioDestinationNode.cpp: Copied from Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp.
  • Modules/webaudio/OfflineAudioDestinationNode.h: Copied from Source/WebCore/webaudio/OfflineAudioDestinationNode.h.
  • Modules/webaudio/RealtimeAnalyser.cpp: Copied from Source/WebCore/webaudio/RealtimeAnalyser.cpp.
  • Modules/webaudio/RealtimeAnalyser.h: Copied from Source/WebCore/webaudio/RealtimeAnalyser.h.
  • Modules/webaudio/RealtimeAnalyserNode.cpp: Copied from Source/WebCore/webaudio/RealtimeAnalyserNode.cpp.
  • Modules/webaudio/RealtimeAnalyserNode.h: Copied from Source/WebCore/webaudio/RealtimeAnalyserNode.h.
  • Modules/webaudio/RealtimeAnalyserNode.idl: Copied from Source/WebCore/webaudio/RealtimeAnalyserNode.idl.
  • Modules/webaudio/WaveShaperDSPKernel.cpp: Copied from Source/WebCore/webaudio/WaveShaperDSPKernel.cpp.
  • Modules/webaudio/WaveShaperDSPKernel.h: Copied from Source/WebCore/webaudio/WaveShaperDSPKernel.h.
  • Modules/webaudio/WaveShaperNode.cpp: Copied from Source/WebCore/webaudio/WaveShaperNode.cpp.
  • Modules/webaudio/WaveShaperNode.h: Copied from Source/WebCore/webaudio/WaveShaperNode.h.
  • Modules/webaudio/WaveShaperNode.idl: Copied from Source/WebCore/webaudio/WaveShaperNode.idl.
  • Modules/webaudio/WaveShaperProcessor.cpp: Copied from Source/WebCore/webaudio/WaveShaperProcessor.cpp.
  • Modules/webaudio/WaveShaperProcessor.h: Copied from Source/WebCore/webaudio/WaveShaperProcessor.h.
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.xcodeproj/project.pbxproj:
  • webaudio/AsyncAudioDecoder.cpp: Removed.
  • webaudio/AsyncAudioDecoder.h: Removed.
  • webaudio/AudioBasicProcessorNode.cpp: Removed.
  • webaudio/AudioBasicProcessorNode.h: Removed.
  • webaudio/AudioBuffer.cpp: Removed.
  • webaudio/AudioBuffer.h: Removed.
  • webaudio/AudioBuffer.idl: Removed.
  • webaudio/AudioBufferCallback.h: Removed.
  • webaudio/AudioBufferCallback.idl: Removed.
  • webaudio/AudioBufferSourceNode.cpp: Removed.
  • webaudio/AudioBufferSourceNode.h: Removed.
  • webaudio/AudioBufferSourceNode.idl: Removed.
  • webaudio/AudioChannelMerger.cpp: Removed.
  • webaudio/AudioChannelMerger.h: Removed.
  • webaudio/AudioChannelMerger.idl: Removed.
  • webaudio/AudioChannelSplitter.cpp: Removed.
  • webaudio/AudioChannelSplitter.h: Removed.
  • webaudio/AudioChannelSplitter.idl: Removed.
  • webaudio/AudioContext.cpp: Removed.
  • webaudio/AudioContext.h: Removed.
  • webaudio/AudioContext.idl: Removed.
  • webaudio/AudioDestinationNode.cpp: Removed.
  • webaudio/AudioDestinationNode.h: Removed.
  • webaudio/AudioDestinationNode.idl: Removed.
  • webaudio/AudioGain.h: Removed.
  • webaudio/AudioGain.idl: Removed.
  • webaudio/AudioGainNode.cpp: Removed.
  • webaudio/AudioGainNode.h: Removed.
  • webaudio/AudioGainNode.idl: Removed.
  • webaudio/AudioListener.cpp: Removed.
  • webaudio/AudioListener.h: Removed.
  • webaudio/AudioListener.idl: Removed.
  • webaudio/AudioNode.cpp: Removed.
  • webaudio/AudioNode.h: Removed.
  • webaudio/AudioNode.idl: Removed.
  • webaudio/AudioNodeInput.cpp: Removed.
  • webaudio/AudioNodeInput.h: Removed.
  • webaudio/AudioNodeOutput.cpp: Removed.
  • webaudio/AudioNodeOutput.h: Removed.
  • webaudio/AudioPannerNode.cpp: Removed.
  • webaudio/AudioPannerNode.h: Removed.
  • webaudio/AudioPannerNode.idl: Removed.
  • webaudio/AudioParam.cpp: Removed.
  • webaudio/AudioParam.h: Removed.
  • webaudio/AudioParam.idl: Removed.
  • webaudio/AudioParamTimeline.cpp: Removed.
  • webaudio/AudioParamTimeline.h: Removed.
  • webaudio/AudioProcessingEvent.cpp: Removed.
  • webaudio/AudioProcessingEvent.h: Removed.
  • webaudio/AudioProcessingEvent.idl: Removed.
  • webaudio/AudioSourceNode.h: Removed.
  • webaudio/AudioSourceNode.idl: Removed.
  • webaudio/BiquadDSPKernel.cpp: Removed.
  • webaudio/BiquadDSPKernel.h: Removed.
  • webaudio/BiquadFilterNode.cpp: Removed.
  • webaudio/BiquadFilterNode.h: Removed.
  • webaudio/BiquadFilterNode.idl: Removed.
  • webaudio/BiquadProcessor.cpp: Removed.
  • webaudio/BiquadProcessor.h: Removed.
  • webaudio/ConvolverNode.cpp: Removed.
  • webaudio/ConvolverNode.h: Removed.
  • webaudio/ConvolverNode.idl: Removed.
  • webaudio/DOMWindowWebAudio.idl: Removed.
  • webaudio/DefaultAudioDestinationNode.cpp: Removed.
  • webaudio/DefaultAudioDestinationNode.h: Removed.
  • webaudio/DelayDSPKernel.cpp: Removed.
  • webaudio/DelayDSPKernel.h: Removed.
  • webaudio/DelayNode.cpp: Removed.
  • webaudio/DelayNode.h: Removed.
  • webaudio/DelayNode.idl: Removed.
  • webaudio/DelayProcessor.cpp: Removed.
  • webaudio/DelayProcessor.h: Removed.
  • webaudio/DynamicsCompressorNode.cpp: Removed.
  • webaudio/DynamicsCompressorNode.h: Removed.
  • webaudio/DynamicsCompressorNode.idl: Removed.
  • webaudio/HighPass2FilterNode.cpp: Removed.
  • webaudio/HighPass2FilterNode.h: Removed.
  • webaudio/HighPass2FilterNode.idl: Removed.
  • webaudio/JavaScriptAudioNode.cpp: Removed.
  • webaudio/JavaScriptAudioNode.h: Removed.
  • webaudio/JavaScriptAudioNode.idl: Removed.
  • webaudio/LowPass2FilterNode.cpp: Removed.
  • webaudio/LowPass2FilterNode.h: Removed.
  • webaudio/LowPass2FilterNode.idl: Removed.
  • webaudio/MediaElementAudioSourceNode.cpp: Removed.
  • webaudio/MediaElementAudioSourceNode.h: Removed.
  • webaudio/MediaElementAudioSourceNode.idl: Removed.
  • webaudio/OfflineAudioCompletionEvent.cpp: Removed.
  • webaudio/OfflineAudioCompletionEvent.h: Removed.
  • webaudio/OfflineAudioCompletionEvent.idl: Removed.
  • webaudio/OfflineAudioDestinationNode.cpp: Removed.
  • webaudio/OfflineAudioDestinationNode.h: Removed.
  • webaudio/RealtimeAnalyser.cpp: Removed.
  • webaudio/RealtimeAnalyser.h: Removed.
  • webaudio/RealtimeAnalyserNode.cpp: Removed.
  • webaudio/RealtimeAnalyserNode.h: Removed.
  • webaudio/RealtimeAnalyserNode.idl: Removed.
  • webaudio/WaveShaperDSPKernel.cpp: Removed.
  • webaudio/WaveShaperDSPKernel.h: Removed.
  • webaudio/WaveShaperNode.cpp: Removed.
  • webaudio/WaveShaperNode.h: Removed.
  • webaudio/WaveShaperNode.idl: Removed.
  • webaudio/WaveShaperProcessor.cpp: Removed.
  • webaudio/WaveShaperProcessor.h: Removed.
17:30 Changeset [111473] by rniwa@webkit.org

Perf-o-matic: don't query datastore to generate chart API urls
https://bugs.webkit.org/show_bug.cgi?id=81499

Reviewed by Hajime Morita.

Parse json text to extract timestamps and test values instead of iterating
through the data store.

  • Websites/webkit-perf.appspot.com/create_handler.py:

(CreateHandler.post):

  • Websites/webkit-perf.appspot.com/models.py:

(Runs._timestamp_and_value_from_json_entry):
(Runs):
(Runs.to_json):
(Runs.chart_params):

17:24 Changeset [111472] by xji@chromium.org

Skip move-by-word-visually-crash-test-css-generated-content.html introduced in r111469
because isWordTextBreak or setEditingBehavior is not implemented.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/wk2/Skipped:
17:04 Changeset [111471] by andersca@apple.com

Add a per-ScrollableArea tile cache base class
https://bugs.webkit.org/show_bug.cgi?id=81694

Reviewed by Sam Weinig.

Add an abstract base class, TiledBacking, that can be used to inform tile caches about changed
state in scrollable areas (such as the currently visible rect, whether the page is active or not, etc).

Make TileCache inherit from TiledBacking and port updating the visible rect over to this new mechanism.

  • WebCore.xcodeproj/project.pbxproj:
  • page/FrameView.cpp:

(WebCore::FrameView::tiledBacking):
(WebCore):

  • page/FrameView.h:

(FrameView):

  • platform/ScrollableArea.h:

(WebCore):
(ScrollableArea):
(WebCore::ScrollableArea::tiledBacking):

  • platform/graphics/GraphicsLayer.h:

(WebCore):
(WebCore::GraphicsLayer::tiledBacking):

  • platform/graphics/TiledBacking.h: Added.

(WebCore):
(TiledBacking):
(WebCore::TiledBacking::~TiledBacking):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::tiledBacking):

  • platform/graphics/ca/GraphicsLayerCA.h:

(GraphicsLayerCA):

  • platform/graphics/ca/PlatformCALayer.h:

(PlatformCALayer):

  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::tiledBacking):

  • platform/graphics/ca/mac/TileCache.h:

(TileCache):

  • platform/graphics/ca/mac/WebTileCacheLayer.h:

(WebCore):

  • platform/graphics/ca/mac/WebTileCacheLayer.mm:

(-[WebTileCacheLayer WebCore::]):

  • platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayer::tiledBacking):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::frameViewDidScroll):

17:00 Changeset [111470] by dpranke@chromium.org

Unreviewed, rolling out r111453.
http://trac.webkit.org/changeset/111453
https://bugs.webkit.org/show_bug.cgi?id=81600

still broken

  • Scripts/webkitpy/layout_tests/port/server_process.py:

(ServerProcess._reset):
(ServerProcess.handle_interrupt):
(ServerProcess.write):
(ServerProcess._check_for_crash):
(ServerProcess._handle_timeout):
(ServerProcess._check_for_abort):
(ServerProcess._read):
(ServerProcess.stop):
(ServerProcess):
(ServerProcess.set_crashed):

  • Scripts/webkitpy/layout_tests/port/server_process_unittest.py:

(TrivialMockPort.is_crash_reporter):
(TestServerProcess.test_broken_pipe):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._read_image_diff):
(WebKitDriver.has_crashed):
(WebKitDriver._check_for_driver_crash):
(WebKitDriver):
(WebKitDriver._detected_crash):
(WebKitDriver._subprocess_crashed):
(WebKitDriver._crashed_process_name):
(WebKitDriver.run_test):
(WebKitDriver._read_block):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(MockServerProcess.init):

16:49 Changeset [111469] by xji@chromium.org

visual word movement: crashes on CSS generated content.
https://bugs.webkit.org/show_bug.cgi?id=81581

Reviewed by Ryosuke Niwa.

Source/WebCore:

Check for null pointer when referencing box->renderer()->node() in previousRootInlineBox and nextRootInlineBox.

Test: editing/selection/move-by-word-visually-crash-test-css-generated-content.html

  • editing/visible_units.cpp:

(WebCore::previousRootInlineBox):
(WebCore::nextRootInlineBox):

LayoutTests:

  • editing/selection/move-by-word-visually-crash-test-css-generated-content-expected.txt: Added.
  • editing/selection/move-by-word-visually-crash-test-css-generated-content.html: Added.
16:47 Changeset [111468] by mitz@apple.com

Updated expected results for this test after r110409.

  • platform/mac/fast/hidpi/video-controls-in-hidpi-expected.txt:
16:44 Changeset [111467] by leviw@chromium.org

[Chromium] Marking full-screen-restrictions as timing out on Windows. It was previously marked as slow,
but all recent tests either passed or timed out.

  • platform/chromium/test_expectations.txt:
16:37 Changeset [111466] by mitz@apple.com

Updated Mac expected results for this test. <http://webkit.org/b/81705> tracks the fact that
r111416 broke it.

  • platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
16:33 Changeset [111465] by sfalken@apple.com

Windows (make based) build fix.
<rdar://problem/11069015>

16:33 Changeset [111464] by ap@apple.com

Address review comment for WebProcess side, too.

  • WebProcess/mac/WebProcessMac.mm: (WebKit::initializeSandbox): There is no need for path to be in static storage, setenv will copy the value.
16:30 Changeset [111463] by ap@apple.com

Sandboxed PluginProcess should use private temporary and cache directories
https://bugs.webkit.org/show_bug.cgi?id=81702
<rdar://problem/10792047>

Reviewed by Anders Carlsson.

  • Platform/Module.h:
  • Platform/mac/ModuleMac.mm: (WebKit::Module::bundleIdentifier): Expose plug-in's bundle identifier.
  • PluginProcess/mac/com.apple.WebKit.PluginProcess.sb.in: Some unerlated fixes to make networking functional on my testing platforms. These serveices are already allowed for WebProcess.
  • WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm: (readSandboxProfile): Unrelated fix - I've been made to rename the profile file, but didn't update where it's read from! (WKN_EnterSandbox): Add a suffix to user directories.
16:27 Changeset [111462] by sfalken@apple.com

Disable LTCG on Windows to avoid out of process space errors while linking
https://bugs.webkit.org/show_bug.cgi?id=81714

Reviewed by Jessie Berlin.

  • win/tools/vsprops/production.vsprops:
16:20 Changeset [111461] by leviw@chromium.org

[Chromium] Updating and coalescing test expectations for nested-fragment-parser-crash.

  • platform/chromium-linux-x86/fast/parser: Removed.
  • platform/chromium-linux-x86/fast/parser/nested-fragment-parser-crash-expected.txt: Removed.
  • platform/chromium-linux/fast/parser/nested-fragment-parser-crash-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/parser/nested-fragment-parser-crash-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/parser/nested-fragment-parser-crash-expected.txt: Removed.
  • platform/chromium-win-vista/fast/parser: Removed.
  • platform/chromium-win-vista/fast/parser/nested-fragment-parser-crash-expected.txt: Removed.
  • platform/chromium-win-xp/fast/parser: Removed.
  • platform/chromium-win-xp/fast/parser/nested-fragment-parser-crash-expected.txt: Removed.
  • platform/chromium-win/fast/parser/nested-fragment-parser-crash-expected.txt: Removed.
  • platform/chromium/fast/parser/nested-fragment-parser-crash-expected.txt: Added.
16:18 Changeset [111460] by macpherson@chromium.org

Use CSSPrimitiveValue::convertToLength() to handle CSSPropertyWebkitBoxReflect and in createGridTrackBreadth.
https://bugs.webkit.org/show_bug.cgi?id=81633

Reviewed by Andreas Kling.

No new tests / refactoring only.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

16:15 Changeset [111459] by leviw@chromium.org

[Chromium] Adding additional possible test expectations for span-as-immediate-child-property-removal and
span-as-immediate-columns-child-removal, since the test expectations are now all over the board.

  • platform/chromium/test_expectations.txt:
16:03 Changeset [111458] by leviw@chromium.org

Unreviewed, rolling out r111442.
http://trac.webkit.org/changeset/111442
https://bugs.webkit.org/show_bug.cgi?id=81711

Causes crashes and image mismatches in canvas tests (Requested
by leviw on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-20

Source/WebCore:

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::HTMLCanvasElement):
(WebCore::HTMLCanvasElement::reset):
(WebCore::HTMLCanvasElement::createImageBuffer):
(WebCore::HTMLCanvasElement::clearCopiedImage):

  • html/HTMLCanvasElement.h:

(HTMLCanvasElement):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::unwindStateStack):
(WebCore::CanvasRenderingContext2D::reset):

LayoutTests:

  • fast/canvas/canvas-resize-after-paint-without-layout-expected.txt: Removed.
  • fast/canvas/canvas-resize-after-paint-without-layout.html: Removed.
  • platform/chromium-linux/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Removed.
  • platform/chromium-linux/fast/canvas/setWidthResetAfterForcedRender-expected.png:
  • platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Removed.
16:01 Changeset [111457] by lforschler@apple.com

New tag.

16:00 Changeset [111456] by enne@google.com

RenderLayerCompositor doesn't properly clip graphics layer sizes
https://bugs.webkit.org/show_bug.cgi?id=80372

Reviewed by Simon Fraser.

Source/WebCore:

To find the bounds for a composited layer, calculateCompositedBounds
iterates through all non-composited child layers using z-order and
normal flow lists. This does not preserve clipping from ancestor
layers, because a clipping ancestor layer can end up as a sibling to
its clipped descendent because it is not a stacking context.

Fix by explicitly checking cached clip roots.

Test: compositing/clip-child-by-non-stacking-ancestor.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::localClipRect):
(WebCore):

  • rendering/RenderLayer.h:

(RenderLayer):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::repaintOnCompositingChange):
(WebCore::RenderLayerCompositor::calculateCompositedBounds):

LayoutTests:

Update several baselines due to smaller backing sizes.

  • compositing/clip-child-by-non-stacking-ancestor-expected.txt: Added.
  • compositing/clip-child-by-non-stacking-ancestor.html: Added.
  • compositing/geometry/clip-expected.txt:
  • compositing/images/clip-on-directly-composited-image-expected.txt:
  • compositing/overflow/clip-descendents-expected.txt:
  • platform/chromium-win/compositing/images/clip-on-directly-composited-image-expected.txt: Removed.
  • platform/chromium-win/compositing/overflow/clip-descendents-expected.txt:
15:51 Changeset [111455] by ossy@webkit.org

Unreviewed, rolling out r111445 and r111446.
http://trac.webkit.org/changeset/111445
http://trac.webkit.org/changeset/111446
https://bugs.webkit.org/show_bug.cgi?id=81708

It broke Qt and GTK build intentionally (Requested by Ossy on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-20

Source/WebCore:

  • WebCore.exp.in:
  • dom/Document.cpp:

(WebCore::Document::initSecurityContext):

  • notifications/Notification.cpp:

(WebCore::Notification::Notification):

  • notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::checkPermission):
(WebCore::NotificationCenter::requestPermission):

  • notifications/NotificationCenter.h:

(NotificationCenter):

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::toString):

  • page/SecurityOrigin.h:

(SecurityOrigin):

Source/WebKit2:

  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::policyForOrigin):

LayoutTests:

  • platform/chromium/test_expectations.txt:
15:45 Changeset [111454] by eae@chromium.org

Merge trunk changes up until r111406 into subpixel branch.

15:42 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
15:40 Changeset [111453] by dpranke@chromium.org

webkitpy: get ServerProcess out of the reportcrash business
https://bugs.webkit.org/show_bug.cgi?id=81600

Unreviewed, build fix.

Re-land r111307 and r111293 with fix for crash in NRWT; I
was failing to set the crashing process name.

  • Scripts/webkitpy/layout_tests/port/server_process.py:

(ServerProcess._reset):
(ServerProcess._handle_possible_interrupt):
(ServerProcess.write):
(ServerProcess.read_stdout):
(ServerProcess.has_crashed):
(ServerProcess._read):
(ServerProcess.stop):

  • Scripts/webkitpy/layout_tests/port/server_process_unittest.py:

(TrivialMockPort.check_for_leaks):
(TestServerProcess.test_broken_pipe):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._read_image_diff):
(WebKitDriver.has_crashed):
(WebKitDriver._check_for_driver_crash):
(WebKitDriver.run_test):
(WebKitDriver._read_block):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(MockServerProcess.init):
(MockServerProcess):
(MockServerProcess.has_crashed):

15:32 Changeset [111452] by timothy_horton@apple.com

[mac] Restore color space switching code to run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=80571
<rdar://problem/11008529>

Reviewed by Simon Fraser.

http://trac.webkit.org/changeset/111429 broke tools build on Snow Leopard.

Use the old CM* API on Snow Leopard, since CGDisplayCreateUUIDFromDisplayID
didn't exist until Lion.

  • DumpRenderTree/mac/LayoutTestHelper.m:

(installLayoutTestColorProfile):
(restoreUserColorProfile):

15:24 Changeset [111451] by adamk@chromium.org

Unskip dom/xhtml test fixed in r111449.

  • platform/qt/Skipped:
15:19 Changeset [111450] by rafaelw@chromium.org

disabling Mutation Observers on Chromium branch 1025

15:10 Changeset [111449] by adamk@chromium.org

Refactor ContainerNode::replaceChild to match other mutation methods and share code
https://bugs.webkit.org/show_bug.cgi?id=81579

Reviewed by Ojan Vafai.

Originally landed as r111310, this fixes a bug in replaceChild
introduced when switching to the insert-before logic.

A future change will make use of the consistency among insertBefore/appendChild/replaceChild
to handle insertion of DocumentFragments more cleanly.

No new tests, no change in behavior.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::replaceChild): Use collectTargetNodes rather than walking through DocumentFragment children.
Insert before rather than inserting after. Dispatch to other methods to update parent/sibling pointers.
(WebCore::ContainerNode::appendChild): Call appendChildToContainer to update parent/sibling pointers.
(WebCore::ContainerNode::parserAddChild): Use type inference in call to appendChildToContainer.

15:07 Changeset [111448] by lforschler@apple.com

Merged r107647.

15:05 Changeset [111447] by lforschler@apple.com

Versioning.

15:04 Changeset [111446] by jonlee@apple.com

Unreviewed. Because we might short-circuit permission calls, some of these tests need to be rewritten
to take that factor into account. There's no mac support of notifications right now (see 79492),
so updating test expectations for now and tracking as a regression in 81697.

  • platform/chromium/test_expectations.txt:
15:02 Changeset [111445] by jonlee@apple.com

Restrict access to notifications for unique origins and file URLs with no local file access
https://bugs.webkit.org/show_bug.cgi?id=79704
<rdar://problem/10912430>

Reviewed by Adam Barth.

Source/WebCore:

Before checking or requesting permissions, we look at whether we can show notifications based on
the security context. If not, we short circuit and do not forward the request to the client.

  • notifications/Notification.cpp:

(WebCore::Notification::Notification): Fix a bug where creating a notification goes through slightly
different logic for checking permissions than when checking permissions through the
notification center.

  • notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::checkPermission): Check to see if the origin can show notifications.
(WebCore::NotificationCenter::requestPermission): If we know whether an origin can show notifications,
we asynchronously call the callback with that decision. Otherwise we ask the client.

Add new variable in the notification center to keep track of pending callbacks when we short-circuit
requestPermission().

  • notifications/NotificationCenter.h:

(NotificationRequestCallback): Add new private class encapsulating the callback.

  • notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::requestTimedOut): Remove the request from the set of pending callbacks.
(WebCore::NotificationCenter::NotificationRequest::createAndStartTimer): Because this is used when we already
know the decision, and are not asking the client to decide, we can immediately trigger a one-shot timer
to invoke the callback.
(WebCore::NotificationCenter::NotificationRequest::NotificationRequest):
(WebCore::NotificationCenter::NotificationRequest::startTimer):
(WebCore::NotificationCenter::NotificationRequest::timerFired): Invoke the callback and tell the notification
center.

  • page/SecurityOrigin.h: Add new toRawString() method to return the string representation of the origin,

regardless of any restrictions that might otherwise cause toString() to return "null".

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::canShowNotifications): Added to return a tri-state regarding whether we know
the origin can show notifications. If the origin is unique, we never let it show. If the origin has
universal access, we always let it show. Otherwise the client should be asked.
(WebCore::SecurityOrigin::toString): Refactor to use toRawString().
(WebCore::SecurityOrigin::toRawString):

Added FIXME's regarding the naming of enforceFilePathSeparation().

  • dom/Document.cpp:

(WebCore::Document::initSecurityContext): Also, tab reformatting.

  • WebCore.exp.in: Export toRawString().

Source/WebKit2:

In the specific case where a file URL has restricted file access and is denied universal access,
SecurityOrigin::canShowNotifications() returns Ask, since it is not considered a unique origin.
The cached table of permissions held by the notification manager will typically not have an entry for
the toString() representation of these file URLs, which is "null", since that can also cover unique
origins, and it is possible that the client will want different permissions between the two types.

It is reasonable, however, for there to be an entry for "file://", so we use toRawString() to do the lookup.

  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::policyForOrigin):

14:54 Changeset [111444] by kling@webkit.org

Remove unused CSSPrimitiveValue constructors.
<http://webkit.org/b/81695>

Reviewed by Antti Koivisto.

Kill off CSSPrimitiveValue constructors that aren't used anywhere.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSPrimitiveValue.h:

(CSSPrimitiveValueBase):
(WebCore::CSSPrimitiveValueBase::CSSPrimitiveValueBase):
(CSSPrimitiveValue):

  • css/CSSPrimitiveValueMappings.h:
14:42 Changeset [111443] by adele@apple.com

Update the last test to use EXPECT_WK_STREQ.

Reviewed by Dan Bernstein.

  • TestWebKitAPI/Tests/mac/AttributedString.mm: (TestWebKitAPI::TEST):
14:39 Changeset [111442] by commit-queue@webkit.org

Reuse buffer allocation if canvas size does not change
https://bugs.webkit.org/show_bug.cgi?id=80871

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-03-20
Reviewed by Stephen White.

Source/WebCore:

If the user changes the width or height attributes of a canvas element,
the contents of the canvas should be cleared and the context state
should be reset. This has become a common idiom to clear the canvas
"efficiently" at the start of a frame.

Previously, this code path triggered a full reallocation of the image
buffer backing the canvas, leading to reduced performance. This patch
implements an optimization where we reuse the previous image buffer
allocation if the size of the canvas did not change. Also, instead of
clearing the canvas every time its dimensions are touched, we only clear
if anything has been drawn into the canvas since it was previously
cleared.

Note that for now this optimization only applies for 2D canvases,
since it is not entirely clear how touching the dimensions of a WebGL
canvas should work.

Test: fast/canvas/canvas-resize-after-paint-without-layout.html +

existing layout tests for canvas resetting.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::HTMLCanvasElement):
(WebCore::HTMLCanvasElement::reset):
(WebCore::HTMLCanvasElement::createImageBuffer):
(WebCore::HTMLCanvasElement::clearImageBuffer):
(WebCore):
(WebCore::HTMLCanvasElement::clearCopiedImage):

  • html/HTMLCanvasElement.h:

(HTMLCanvasElement):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D): Save the
initial graphics context state so we can restore it without creating a
new context.
(WebCore::CanvasRenderingContext2D::unwindStateStack):
(WebCore::CanvasRenderingContext2D::reset): No need to notify the
compositor when the context is reset, because clearing the image buffer
does the same thing. We can also skip the notification if we did not
have an image buffer at the time of the reset, because the reset will
not have any visual impact in this case. Finally, if the canvas size
did change, the notification is also unnecessary because of the call
to RenderObject::repaint() from HTMLCanvasElement::reset().

LayoutTests:

Add layout test to check canvas resizing without changing its layout size.

We also update the expected image one canvas clearing test. The test
is setting the size of a canvas and expecting it to be cleared in the process.
With the optimization to retain the underlying ImageBuffer, we no longer call
RenderReplaced::repaint() as a part of this process. This function used to
repaint both the canvas itself (100x50) as well as its local selection
rectangle (100x54).

In this case the local selection rectangle is larger than the canvas because
the canvas is contained within an anonymous RenderBlock that also has two empty
text nodes. The extra 4 pixels are needed for drawing the selection rectangle
around any descenders in the the text of those nodes.

Since clearing the canvas has no effect on the selection rectangle, we only
need to repaint the area of the canvas itself.

  • fast/canvas/canvas-resize-after-paint-without-layout.html: Added.
  • fast/canvas/canvas-resize-after-paint-without-layout-expected.txt: Added.
  • platform/chromium-linux/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Added.
  • platform/chromium-linux/fast/canvas/setWidthResetAfterForcedRender-expected.png: Updated.
14:34 Changeset [111441] by commit-queue@webkit.org

[chromium] Allow us to disable overdraw metrics when tracing is off
https://bugs.webkit.org/show_bug.cgi?id=81431

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-20
Reviewed by Adrienne Walker.

Source/WebCore:

This change allows us to disable overdraw metrics conditionally in the
future with a one-line change in each LayerTreeHost class.

Unit test: CCQuadCullerTest.verifyWithoutMetrics

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintLayerContents):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::CCOcclusionTrackerBase):
(WebCore):

  • platform/graphics/chromium/cc/CCOcclusionTracker.h:

(CCOcclusionTrackerBase):

  • platform/graphics/chromium/cc/CCOverdrawMetrics.cpp:

(WebCore::CCOverdrawMetrics::CCOverdrawMetrics):
(WebCore::CCOverdrawMetrics::didCull):
(WebCore::CCOverdrawMetrics::didDraw):
(WebCore::CCOverdrawMetrics::recordMetrics):

  • platform/graphics/chromium/cc/CCOverdrawMetrics.h:

(WebCore::CCOverdrawMetrics::create):
(CCOverdrawMetrics):

Source/WebKit/chromium:

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore::TestCCOcclusionTrackerBase::TestCCOcclusionTrackerBase):

  • tests/CCQuadCullerTest.cpp:

(WebCore::TestCCOcclusionTrackerImpl::TestCCOcclusionTrackerImpl):
(WebCore::TEST):
(WebCore):

  • tests/TiledLayerChromiumTest.cpp:

(WTF::TestCCOcclusionTracker::TestCCOcclusionTracker):

14:33 Changeset [111440] by mitz@apple.com

Added Mac WebKit2 expected results for this test. <http://webkit.org/b/81700> tracks the
difference in results between WebKit1 and WebKit2 in this test.

  • platform/mac-wk2/fast/dom: Added.
  • platform/mac-wk2/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Added.
14:31 Changeset [111439] by robert@webkit.org

Use-after-free of continuation in RenderBlock::paintContinuationOutlines()
https://bugs.webkit.org/show_bug.cgi?id=81276

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/css/relative-positioned-block-crash.html

https://trac.webkit.org/changeset/108185/ allowed anonymous blocks to get their own layer (when they're
relatively positioned). This broke the dependency in addContinuationWithOutline() on the owner of the continuation
table and the renderer getting added to it always being in the same layer. When they're not in the same layer
there's no guarantee that the owner of the continuation table will get painted again and so avoid any stale pointers
in its continuation table should any of the renderers in there get destroyed.

Fix this for now by only adding renderers to the containing block's continuation table if we don't have our own layer.
This fix causes fast/inline/continuation-outlines-with-layers.html to regress as it uses blocks inside relatively positioned
inlines, so skip it on all platforms pending a medium-term fix.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintObject):

LayoutTests:

  • fast/css/relative-positioned-block-crash-expected.txt: Added.
  • fast/css/relative-positioned-block-crash.html: Added.
  • platform/chromium/test_expectations.txt: Skip fast/inline/continuation-outlines-with-layers.html for now.
  • platform/gtk/Skipped: ditto
  • platform/mac/Skipped: ditto
  • platform/qt/Skipped: ditto
  • platform/win/Skipped: ditto
14:25 Changeset [111438] by sfalken@apple.com

Source/JavaScriptCore: Move WTF-related Windows project files out of JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=80680

This change only moves the vcproj and related files from JavaScriptCore/JavaScriptCore.vcproj/WTF.
It does not move any source code. This is in preparation for the WTF source move out of
JavaScriptCore.

Reviewed by Jessie Berlin.

Source/WebKit/win: Move WTF-related Windows project files out of JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=80680

Reviewed by Jessie Berlin.

  • WebKit.vcproj/WebKit.sln:

Source/WTF: Move WTF-related Windows project files out of JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=80680

This change only moves the vcproj and related files from JavaScriptCore/JavaScriptCore.vcproj/WTF.
It does not move any source code. This is in preparation for the WTF source move out of
JavaScriptCore.

Reviewed by Jessie Berlin.

  • WTF.vcproj: Added.
  • WTF.vcproj/WTF.vcproj: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTF.vcproj.
  • WTF.vcproj/WTFCommon.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFCommon.vsprops.
  • WTF.vcproj/WTFDebug.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFDebug.vsprops.
  • WTF.vcproj/WTFDebugAll.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFDebugAll.vsprops.
  • WTF.vcproj/WTFDebugCairoCFLite.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFDebugCairoCFLite.vsprops.
  • WTF.vcproj/WTFGenerated.make: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGenerated.make.
  • WTF.vcproj/WTFGenerated.vcproj: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGenerated.vcproj.
  • WTF.vcproj/WTFGeneratedCommon.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGeneratedCommon.vsprops.
  • WTF.vcproj/WTFGeneratedDebug.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGeneratedDebug.vsprops.
  • WTF.vcproj/WTFGeneratedDebugAll.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGeneratedDebugAll.vsprops.
  • WTF.vcproj/WTFGeneratedDebugCairoCFLite.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGeneratedDebugCairoCFLite.vsprops.
  • WTF.vcproj/WTFGeneratedProduction.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGeneratedProduction.vsprops.
  • WTF.vcproj/WTFGeneratedRelease.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGeneratedRelease.vsprops.
  • WTF.vcproj/WTFGeneratedReleaseCairoCFLite.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGeneratedReleaseCairoCFLite.vsprops.
  • WTF.vcproj/WTFPostBuild.cmd: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFPostBuild.cmd.
  • WTF.vcproj/WTFPreBuild.cmd: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFPreBuild.cmd.
  • WTF.vcproj/WTFProduction.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFProduction.vsprops.
  • WTF.vcproj/WTFRelease.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFRelease.vsprops.
  • WTF.vcproj/WTFReleaseCairoCFLite.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFReleaseCairoCFLite.vsprops.
  • WTF.vcproj/build-generated-files.sh: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/build-generated-files.sh.
  • WTF.vcproj/copy-files.cmd: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/copy-files.cmd.
  • WTF.vcproj/work-around-vs-dependency-tracking-bugs.py: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/work-around-vs-dependency-tracking-bugs.py.
14:19 Changeset [111437] by mitz@apple.com

Work around the inconsistency in test results caused by <http://webkit.org/b/81696> in a few
tests, by appending a # character to the href attributes of links to other tests. This
ensures that they are never visited.

  • fast/block/margin-collapse/001.html:
  • fast/block/margin-collapse/005.html:
  • fast/block/margin-collapse/010.html:
  • fast/block/margin-collapse/011.html:
  • fast/block/margin-collapse/012.html:
  • fast/block/margin-collapse/015.html:
  • fast/block/margin-collapse/016.html:
  • fast/block/margin-collapse/017.html:
  • fast/block/margin-collapse/020.html:
  • fast/block/margin-collapse/056.html:
  • fast/block/margin-collapse/059.html:
  • fast/block/margin-collapse/block-inside-inline/001.html:
  • fast/block/margin-collapse/block-inside-inline/005.html:
  • fast/block/margin-collapse/block-inside-inline/010.html:
  • fast/block/margin-collapse/block-inside-inline/011.html:
  • fast/block/margin-collapse/block-inside-inline/012.html:
  • fast/block/margin-collapse/block-inside-inline/015.html:
  • fast/block/margin-collapse/block-inside-inline/016.html:
  • fast/block/margin-collapse/block-inside-inline/017.html:
  • fast/block/margin-collapse/block-inside-inline/020.html:
  • platform/mac/fast/block/margin-collapse/056-expected.txt:
14:05 Changeset [111436] by adele@apple.com

Source/WebCore: "Attempt to insert nil value " exception when calling attributed string APIs on content with a custom font
https://bugs.webkit.org/show_bug.cgi?id=81630
<rdar://problem/10650660>

Reviewed by Alexey Proskuryakov.

Test: TestWebKitAPI/Tests/mac/AttributedString.mm

If content is using a custom font, then the platform font will be nil and needs to be nil checked.

  • platform/mac/HTMLConverter.mm: (+[WebHTMLConverter editingAttributedStringFromRange:]):

Tools: "Attempt to insert nil value " exception when calling attributed string APIs on content with a custom font
https://bugs.webkit.org/show_bug.cgi?id=81630
<rdar://problem/10650660>

Reviewed by Alexey Proskuryakov.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/Ahem.ttf: Added.
  • TestWebKitAPI/Tests/mac/AttributedString.mm: Added.

(-[AttributedStringTest webView:didFinishLoadForFrame:]):
(TestWebKitAPI):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/mac/attributedStringCustomFont.html: Added.
14:02 Changeset [111435] by jchaffraix@webkit.org

Make distributeExtraLogicalHeightToRows return the consumed logical height
https://bugs.webkit.org/show_bug.cgi?id=81678

Reviewed by Tony Chang.

Small refactoring, no change in behavior.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::distributeExtraLogicalHeight):
Remove the consumed logical height from the available height.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::distributeExtraLogicalHeightToPercentRows):
(WebCore::RenderTableSection::distributeExtraLogicalHeightToAutoRows):
(WebCore::RenderTableSection::distributeRemainingExtraLogicalHeight):
Changed those method to not return anything but remove from the available width.

(WebCore::RenderTableSection::distributeExtraLogicalHeightToRows):
Return the consumed logical height.

  • rendering/RenderTableSection.h:

Updated the previous distribute functions signature and the comment about
the returned value from distributeExtraLogicalHeightToRows.

13:59 April 2012 Meeting edited by eric@webkit.org
(diff)
13:56 Changeset [111434] by commit-queue@webkit.org

[BlackBerry] Dijit crash WebCore::CookieManager::getRawCookies
https://bugs.webkit.org/show_bug.cgi?id=81686

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-03-20
Reviewed by Rob Buis.

Source/WebCore:

HTML plugin element with an empty src caused an ASSERT failure on debug
build and a crash on release build.
When getting cookie, url can be null, so we need to check for it to
avoid the crash.

No new tests as this is covered by
LayoutTests/fast/loader/empty-embed-src-attribute.html.

  • platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::ResourceRequest::initializePlatformRequest):

Source/WebKit/blackberry:

When deciding the policy for navigation action, if the url of the
request is null, ignore it to avoid the ASSERT failure in
MainResourceLoader::willSendRequest.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):

13:51 WikiStart edited by rniwa@webkit.org
Add a link to the 2012 meeting page (diff)
13:47 April 2012 Meeting edited by rniwa@webkit.org
Add some topics and hackathon ideas (diff)
13:26 April 2012 Meeting created by rniwa@webkit.org
Add 2012 contributor's meeting page
13:22 Changeset [111433] by benjamin@webkit.org

Cache the type string of JavaScript object
https://bugs.webkit.org/show_bug.cgi?id=81446

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-20
Reviewed by Geoffrey Garen.

Instead of creating the JSString every time, we create
lazily the strings in JSGlobalData.

This avoid the construction of the StringImpl and of the JSString,
which gives some performance improvements.

  • runtime/CommonIdentifiers.h:
  • runtime/JSValue.cpp:

(JSC::JSValue::toStringSlowCase):

  • runtime/Operations.cpp:

(JSC::jsTypeStringForValue):

  • runtime/SmallStrings.cpp:

(JSC::SmallStrings::SmallStrings):
(JSC::SmallStrings::finalizeSmallStrings):
(JSC::SmallStrings::initialize):
(JSC):

  • runtime/SmallStrings.h:

(SmallStrings):

13:07 Changeset [111432] by eric@webkit.org

Add link on queues.webkit.org to kov's fancy queue-depth graph
https://bugs.webkit.org/show_bug.cgi?id=81690

Reviewed by Adam Barth.

  • QueueStatusServer/templates/recentstatus.html:
13:02 Changeset [111431] by oliver@apple.com

Allow LLINT to work even when executable allocation fails.
https://bugs.webkit.org/show_bug.cgi?id=81693

Reviewed by Gavin Barraclough.

Don't crash if executable allocation fails if we can fall back on LLINT

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::FixedVMPoolExecutableAllocator::FixedVMPoolExecutableAllocator):

  • wtf/OSAllocatorPosix.cpp:

(WTF::OSAllocator::reserveAndCommit):

12:58 Changeset [111430] by vsevik@chromium.org

Web Inspector: Tabbed pane drop down should be sorted.
https://bugs.webkit.org/show_bug.cgi?id=81680

Reviewed by Pavel Feldman.

  • inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPane.prototype._populateDropDownFromIndex.compareFunction):
(WebInspector.TabbedPane.prototype._populateDropDownFromIndex):

12:58 Changeset [111429] by timothy_horton@apple.com

[mac] Restore color space switching code to run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=80571
<rdar://problem/11008529>

Reviewed by Simon Fraser.

Make use of the layout test helper hooks to restore the Mac system-wide
color profile switching code. This makes WkTR and DRT results match, and
causes the main display's color profile to not affect results on Lion.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/mac/LayoutTestHelper.m: Added.

(installLayoutTestColorProfile):
(restoreUserColorProfile):
(simpleSignalHandler):
(main):

  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.release_http_lock):
(MacPort):
(MacPort._path_to_helper):
(MacPort.start_helper):
(MacPort.stop_helper):

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::windowSnapshotImage):

12:53 Changeset [111428] by vsevik@chromium.org

Web Inspector: Open resource dialog scripts list should be sorted.
https://bugs.webkit.org/show_bug.cgi?id=81682

Reviewed by Pavel Feldman.

  • inspector/front-end/FilteredItemSelectionDialog.js:

(WebInspector.OpenResourceDialog.compareFunction):
(WebInspector.OpenResourceDialog):

12:52 Changeset [111427] by mitz@apple.com

Added Mac WebKit2 expected results for this test. <http://webkit.org/b/81679> tracks the
difference in results between WebKit1 and WebKit2 in this test.

  • platform/mac-wk2/compositing/geometry: Added.
  • platform/mac-wk2/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt: Copied from LayoutTests/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt.
12:51 Changeset [111426] by commit-queue@webkit.org

[chromium] Use opaque contents for paint culling
https://bugs.webkit.org/show_bug.cgi?id=81676

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-20
Reviewed by Adrienne Walker.

Source/WebCore:

UnitTest: CCLayerTreeHostTestContentLayerOcclusion

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintLayerContents):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF::TestLayerChromium::opaqueContentsRegion):
(WTF::TestLayerChromium::setOpaqueContentsRect):
(TestLayerChromium):
(CCLayerTreeHostTestContentLayerOcclusion):
(WTF::CCLayerTreeHostTestContentLayerOcclusion::CCLayerTreeHostTestContentLayerOcclusion):
(WTF::CCLayerTreeHostTestContentLayerOcclusion::beginTest):
(WTF::CCLayerTreeHostTestContentLayerOcclusion::afterTest):
(WTF):

12:49 Changeset [111425] by cevans@google.com

Merge 110324
BUG=116746
Review URL: https://chromiumcodereview.appspot.com/9771001

12:47 Changeset [111424] by leviw@chromium.org

[Chromium] Updating Chromium expectations following r111412.

  • platform/chromium-win/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt: Added.
12:08 Changeset [111423] by cevans@google.com

Merge 110323
BUG=113902
Review URL: https://chromiumcodereview.appspot.com/9762003

12:04 Changeset [111422] by mitz@apple.com

Build fix after r111419.

  • dom/WebKitNamedFlow.cpp:
  • dom/WebKitNamedFlow.h:
11:54 Changeset [111421] by cevans@google.com

Merge 110326
BUG=116461
Review URL: https://chromiumcodereview.appspot.com/9761002

11:47 Changeset [111420] by lforschler@apple.com

Remove incorrect tag.

11:37 Changeset [111419] by mitz@apple.com

REGRESSION (r111229): css1/basic/inheritance.html is failing
https://bugs.webkit.org/show_bug.cgi?id=81684

Reverted r111229.

Rubber-stamped by Dave Hyatt.

Source/WebCore:

  • dom/Document.cpp:

(WebCore::Document::webkitGetFlowByName):

  • dom/Document.h:

(Document):

  • dom/Element.cpp:

(WebCore::Element::detach):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):

  • dom/WebKitNamedFlow.cpp:

(WebCore):

  • dom/WebKitNamedFlow.h:

(WebCore):
(WebKitNamedFlow):

  • dom/WebKitNamedFlow.idl:

LayoutTests:

  • fast/regions/webkit-named-flow-content-nodes-expected.txt: Removed.
  • fast/regions/webkit-named-flow-content-nodes.html: Removed.
11:33 Changeset [111418] by lforschler@apple.com

New tag.

11:32 Changeset [111417] by lforschler@apple.com

New tag.

11:26 Changeset [111416] by commit-queue@webkit.org

https://bugs.webkit.org/show_bug.cgi?id=80696
Remove custom bindings for attribute type Array.

Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-03-20
Reviewed by Kentaro Hara.

No new tests.

  • bindings/js/JSConsoleCustom.cpp: Removed custom function.

(WebCore):

  • bindings/js/JSDOMBinding.h: Added template jsArray and toNativeArray.

(WebCore):
(WebCore::jsArray):
(WebCore::toNativeArray):

  • bindings/scripts/CodeGenerator.pm: Modified codegenerators to generate appropriate code.

(GetArrayType): Added GetArrayType to get return type of attribute interface.

  • bindings/scripts/CodeGeneratorGObject.pm: Modified codegenerators to generate appropriate code.

(SkipAttribute):

  • bindings/scripts/CodeGeneratorJS.pm: Modified codegenerators to generate appropriate code.

(AddIncludesForType):
(JSValueToNative):
(NativeToJSValue):

  • bindings/scripts/CodeGeneratorV8.pm: Modified codegenerators to generate appropriate code.

(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(JSValueToNative):
(NativeToJSValue):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Updated results from running binding tests.

(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
  • bindings/scripts/test/JS/JSTestObj.cpp: Ditto.

(WebCore::jsTestObjSequenceAttr):
(WebCore::setJSTestObjSequenceAttr):
(WebCore::jsTestObjPrototypeFunctionMethodReturningSequence):

  • bindings/scripts/test/V8/V8TestObj.cpp: Ditto.

(WebCore::TestObjInternal::sequenceAttrAttrGetter):
(WebCore::TestObjInternal::sequenceAttrAttrSetter):
(WebCore::TestObjInternal::methodReturningSequenceCallback):

  • bindings/v8/V8Binding.h: Added template v8Array and toNativeArray.

(WebCore):
(WebCore::v8Array):
(WebCore::toNativeArray):

  • bindings/v8/custom/V8ConsoleCustom.cpp: Removed custom function.

(WebCore):

  • page/Console.idl: Replaced attribute type Array to sequence<SriptProfile> to remove custom bindings.
11:18 Changeset [111415] by commit-queue@webkit.org

Unreviewed, rolling out r111310.
http://trac.webkit.org/changeset/111310
https://bugs.webkit.org/show_bug.cgi?id=81683

Broke layout test
dom/xhtml/level3/core/nodereplacechild30.xhtml (Requested by
aklein on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-20

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::appendChild):
(WebCore::ContainerNode::parserAddChild):

11:12 Changeset [111414] by darin@chromium.org

2012-02-24 Darin Fisher <darin@chromium.org>

Add more Chromium WebKit API reviewers
https://bugs.webkit.org/show_bug.cgi?id=81576

Reviewed by Adam Barth and David Levin.

Simplify watchlist to lump all WebKit API into one.

  • Scripts/webkitpy/common/config/watchlist:
11:08 Changeset [111413] by ap@apple.com

WebProcess should use private temporary and cache directories
https://bugs.webkit.org/show_bug.cgi?id=80876

Reviewed by Sam Weinig.

  • Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode): (WebKit::WebProcessCreationParameters::decode):
  • Shared/WebProcessCreationParameters.h: (WebProcessCreationParameters):
  • UIProcess/mac/WebContextMac.mm: (WebKit::WebContext::platformInitializeWebProcess): Always pass uiProcessBundleIdentifier to WebProcess on Mac, it's now used for more than CFURL sessions.
  • WebProcess/com.apple.WebProcess.sb.in: Limit old workaround to platforms that need it.
  • WebProcess/mac/WebProcessMac.mm: (WebKit::initializeSandbox): Tell confstr to use a suffix on user directories.
11:02 Changeset [111412] by mitz@apple.com

Updated expected results for a test, while <http://webkit.org/b/81679> is tracking this
possible regression.

  • compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
10:56 Changeset [111411] by commit-queue@webkit.org

Convert regions parsing test to use testharness.js
https://bugs.webkit.org/show_bug.cgi?id=80709

Patch by Jacob Goldstein <jacobg@adobe.com> on 2012-03-20
Reviewed by Ryosuke Niwa.

  • fast/regions/script-tests/webkit-flow-parsing.js:

(testParse):
(testComputedStyle):
(testNotInherited):
(test):

  • fast/regions/webkit-flow-parsing-expected.txt:
  • fast/regions/webkit-flow-parsing.html:
  • resources/testharness.js: Added.

(.):

  • resources/testharnessreport.js: Added.

(convertResult):

10:54 Changeset [111410] by eae@chromium.org

AnimationUtil::bend changes on branch

10:46 Changeset [111409] by vsevik@chromium.org

Unreviewed test fix and unskip.

  • inspector/debugger/snippets-model-expected.txt:
  • inspector/debugger/snippets-model.html:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
10:25 Changeset [111408] by leviw@chromium.org

[Chromium] Adding missing linux expectations for error-to-string-stack-overflow.

  • platform/chromium-linux/fast/dom/error-to-string-stack-overflow-expected.txt: Added.
10:21 Changeset [111407] by andersca@apple.com

Graphic distortion effect when launching with empty page Safari after reset
https://bugs.webkit.org/show_bug.cgi?id=81677
<rdar://problem/11065904>

Reviewed by Sam Weinig.

Don't set the redraw policy to never, since that was causing the WKView layer to never be updated. Instead,
let AppKit decide which redraw policy to use.

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:contextRef:pageGroupRef:]):

10:18 Changeset [111406] by leviw@chromium.org

[Chromium] Adding missing results for canvas-putImageData for Windows.

  • platform/chromium-win/fast/repaint/canvas-putImageData-expected.txt: Added.
09:59 Changeset [111405] by gyuyoung.kim@samsung.com

Convert hasSpellingMarker to use Internals interface.
https://bugs.webkit.org/show_bug.cgi?id=81300

Reviewed by Ryosuke Niwa.

.:

  • Source/autotools/symbols.filter: Export a symbol for hasSpellingMarker.

Source/WebCore:

Remove hasSpellingMarker functions, because it is able to work in the
cross-port way through the Internals interface.

No new tests, since we are improving here the infra-structure
for testing a specific method.

  • testing/Internals.cpp:

(WebCore::Internals::hasSpellingMarker):
(WebCore):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit/gtk:

Remove DumpRenderTreeSupportGtk::webkitWebFrameSelectionHasSpellingMarker support,
since it can support in the cross-port way through the Internals interface.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Source/WebKit/mac:

Remove hasSpellingMarker support, since it can support in the cross-port way
through the Internals interface.

  • WebKit.order:
  • WebView/WebFrame.mm:
  • WebView/WebFramePrivate.h:

Source/WebKit/win:

Remove hasSpellingMarker interface support, since it can support in the cross-port
way through the Internals interface.

  • Interfaces/IWebFramePrivate.idl:

Source/WebKit2:

  • win/WebKit2.def: Export a symbol for hasSpellingMarker.

Tools:

Remove hasSpellingMarker functions, because it is able to work in the
cross-port way through the Internals interface.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp:
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

LayoutTests:

Adjust hasSpellingMarker tests to use Internals instead of LayoutTestController
interface.

  • editing/spelling/design-mode-spellcheck-off.html:
  • editing/spelling/script-tests/spellcheck-paste.js:

(verifyMarker):

  • editing/spelling/script-tests/spelling-attribute-at-child.js:

(childHasSpellingMarker):

  • editing/spelling/script-tests/spelling-attribute-change.js:

(testSpellCheckingEnabled):

  • editing/spelling/script-tests/spelling-backspace-between-lines.js:

(testWithDelete):
(testWithForwardDelete):

  • editing/spelling/script-tests/spelling-hasspellingmarker.js:

(hasMarked):

  • editing/spelling/spellcheck-attribute.html:
  • editing/spelling/spelling-attribute-change-expected.txt:
  • editing/spelling/spelling-backspace-between-lines-expected.txt:
  • editing/spelling/spelling-hasspellingmarker-expected.txt:
  • editing/spelling/spelling-linebreak.html:
  • platform/chromium-mac-snowleopard/editing/spelling/spelling-backspace-between-lines-expected.txt:
  • platform/chromium-win/editing/spelling/spelling-backspace-between-lines-expected.txt:
  • platform/chromium/editing/spelling/spelling-backspace-between-lines-expected.txt:
  • platform/mac/editing/spelling/delete-into-misspelled-word.html:
  • platform/mac/editing/spelling/editing-multiple-words-with-markers.html:
  • platform/mac/editing/spelling/editing-word-with-marker-1.html:
  • platform/mac/editing/spelling/editing-word-with-marker-2.html:
  • platform/mac/editing/spelling/move-cursor-around-misspelled-word.html:
  • platform/win/editing/spelling/spelling-backspace-between-lines-expected.txt:
  • platform/wk2/Skipped:
09:40 Changeset [111404] by commit-queue@webkit.org

[BlackBerry] BlackBerry can clear cookies and cache from the Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=81670

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-03-20
Reviewed by Rob Buis.

  • WebCoreSupport/InspectorClientBlackBerry.h:

(WebCore::InspectorClientBlackBerry::canClearBrowserCache):
(WebCore::InspectorClientBlackBerry::canClearBrowserCookies):

09:33 Changeset [111403] by ossy@webkit.org

Add new Qt-WK2 performance tester bot to build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=80842

Reviewed by Ryosuke Niwa.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunAndUploadPerfTestsWebKit2):
(RunAndUploadPerfTestsWebKit2.start):
(BuildAndPerfTestWebKit2Factory):
(BuildAndPerfTestWebKit2Factory.init):
(DownloadAndPerfTestWebKit2Factory):
(DownloadAndPerfTestWebKit2Factory.init):

09:28 Changeset [111402] by mitz@apple.com

Build fix.

  • history/PageCache.cpp: Fixed an unused function warning introduced in r111391.
09:27 Changeset [111401] by kkristof@inf.u-szeged.hu

[Qt] Unreviewed. Added new platform expectations.

Skipped. https://bugs.webkit.org/show_bug.cgi?id=81671

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0-wk2/css1/basic/inheritance-expected.txt: Added after r111229.
  • platform/qt-5.0-wk2/platform/qt/plugins/application-plugin-plugins-disabled-expected.txt: Added after r111351.
09:17 Changeset [111400] by commit-queue@webkit.org

(r110063) m_mouseDownMayStartDrag is used without being behind the ENABLE(DRAG_SUPPORT) macro
https://bugs.webkit.org/show_bug.cgi?id=81666

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-03-20
Reviewed by Rob Buis.

Compiled with feature disabled and built.

  • page/EventHandler.cpp:

(WebCore::EventHandler::selectCursor):

08:38 Changeset [111399] by mrobinson@webkit.org

[GTK] [WK2] Add javascript clipboard functionality settings to WebKit2 GTK+ API.
https://bugs.webkit.org/show_bug.cgi?id=80981

Patch by Antaryami Pandia <antaryami.pandia@motorola.com> on 2012-03-20
Reviewed by Martin Robinson.

Add WebSettings to enable/disable javascript clipboard functionality.

  • UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_get_javascript_can_access_clipboard):
(webkit_settings_set_javascript_can_access_clipboard):

  • UIProcess/API/gtk/WebKitSettings.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings):

08:31 Changeset [111398] by commit-queue@webkit.org

[BlackBerry] Removing doubly defined methods in BackingStore.cpp
https://bugs.webkit.org/show_bug.cgi?id=81664

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-03-20
Reviewed by Rob Buis.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::drawAndBlendLayersForDirectRendering):

08:24 Changeset [111397] by leviw@chromium.org

[Chromium] Marking compositing/iframes/scrolling-iframe.html as flaky on Linux
as well.

  • platform/chromium/test_expectations.txt:
08:03 Changeset [111396] by charles.wei@torchmobile.com.cn

[BlackBerry] Remove OutOfMemoryHandler from the build system
https://bugs.webkit.org/show_bug.cgi?id=81649

Remove OutOfMemoryHandler, and change GLES2Context to WebKitSupport,
in the build system for BlackBerry porting.

Reviewed by Rob Buis.

  • PlatformBlackBerry.cmake:
07:51 Changeset [111395] by wjmaclean@chromium.org

[chromium] Tune fling physics curve. [Not for review yet]
https://bugs.webkit.org/show_bug.cgi?id=81398

Reviewed by James Robinson.

Source/WebCore:

Existing tests updated.

Tune physics of curve for better feel.

  • platform/TouchFlingPlatformGestureCurve.cpp:

(WebCore::TouchFlingPlatformGestureCurve::apply):

Source/WebKit/chromium:

  • tests/PlatformGestureCurveTest.cpp:
07:46 Changeset [111394] by alexis.menard@openbossa.org

Implement a fast path when setting CSS properties with keywords from JS.
https://bugs.webkit.org/show_bug.cgi?id=80874

Reviewed by Antti Koivisto.

The idea is to avoid the creation of the CSSParser instance and to run the parser on
a string we know it should be a keyword. When JS calls parseValue we try to check if we can
use the fast path and if the keyword is accepted then we just add it to the declaration directly.
For the sake of maintenance the parseValue function used by CSSGrammar.y is sharing some code with
the fast path (keyword matching mostly).

This patch improves this use case by 20%. Setting keyword properties from JS is used a lot in
Google Maps for example (when zooming or panning).

No new tests : it's a performance improvement, there shouldn't be any behavior change.

  • css/CSSParser.cpp:

(WebCore):
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::parseKeywordValue):
(WebCore::CSSParser::parseValue):

07:42 Changeset [111393] by commit-queue@webkit.org

[chromium] Infrastructure to allow animating layers to be only partially updated
https://bugs.webkit.org/show_bug.cgi?id=81106

Patch by Ian Vollick <vollick@chromium.org> on 2012-03-20
Reviewed by James Robinson

Source/WebCore:

Merged the controller tests in CCLayerAnimationControllerTest

  • WebCore.gypi:
  • platform/graphics/chromium/GraphicsLayerChromium.cpp:
  • platform/graphics/chromium/GraphicsLayerChromium.h:

(GraphicsLayerChromium):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::pushPropertiesTo):
(WebCore::LayerChromium::setOpacityFromAnimation):
(WebCore):
(WebCore::LayerChromium::setTransformFromAnimation):
(WebCore::LayerChromium::addAnimation):
(WebCore::LayerChromium::pauseAnimation):
(WebCore::LayerChromium::removeAnimation):
(WebCore::LayerChromium::suspendAnimations):
(WebCore::LayerChromium::resumeAnimations):
(WebCore::LayerChromium::setLayerAnimationController):
(WebCore::LayerChromium::hasActiveAnimation):
(WebCore::LayerChromium::setAnimationEvent):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore):
(LayerChromium):
(WebCore::LayerChromium::id):
(WebCore::LayerChromium::opacity):
(WebCore::LayerChromium::transform):
(WebCore::LayerChromium::bounds):

  • platform/graphics/chromium/cc/CCActiveAnimation.h:

(CCActiveAnimation):

  • platform/graphics/chromium/cc/CCAnimationEvents.cpp:

(WebCore::CCAnimationEvent::CCAnimationEvent):
(WebCore::CCAnimationEvent::toFloatAnimationFinishedEvent):
(WebCore::CCAnimationEvent::toTransformAnimationFinishedEvent):
(WebCore::CCAnimationStartedEvent::create):
(WebCore):
(WebCore::CCAnimationStartedEvent::CCAnimationStartedEvent):
(WebCore::CCFloatAnimationFinishedEvent::create):
(WebCore::CCFloatAnimationFinishedEvent::CCFloatAnimationFinishedEvent):
(WebCore::CCFloatAnimationFinishedEvent::~CCFloatAnimationFinishedEvent):
(WebCore::CCFloatAnimationFinishedEvent::type):
(WebCore::CCTransformAnimationFinishedEvent::create):
(WebCore::CCTransformAnimationFinishedEvent::CCTransformAnimationFinishedEvent):
(WebCore::CCTransformAnimationFinishedEvent::~CCTransformAnimationFinishedEvent):
(WebCore::CCTransformAnimationFinishedEvent::type):

  • platform/graphics/chromium/cc/CCAnimationEvents.h:

(WebCore):
(WebCore::CCAnimationEvent::targetProperty):
(CCAnimationEvent):
(CCAnimationStartedEvent):
(CCFloatAnimationFinishedEvent):
(WebCore::CCFloatAnimationFinishedEvent::finalValue):
(CCTransformAnimationFinishedEvent):
(WebCore::CCTransformAnimationFinishedEvent::finalValue):

  • platform/graphics/chromium/cc/CCLayerAnimationController.cpp:

(WebCore::CCLayerAnimationController::CCLayerAnimationController):
(WebCore::CCLayerAnimationController::create):
(WebCore::CCLayerAnimationController::pushAnimationUpdatesTo):
(WebCore::CCLayerAnimationController::animate):
(WebCore):
(WebCore::CCLayerAnimationController::add):
(WebCore::CCLayerAnimationController::getActiveAnimation):
(WebCore::CCLayerAnimationController::hasActiveAnimation):
(WebCore::CCLayerAnimationController::isAnimatingProperty):
(WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):
(WebCore::CCLayerAnimationController::removeAnimationsCompletedOnMainThread):
(WebCore::CCLayerAnimationController::startAnimationsWaitingForNextTick):
(WebCore::CCLayerAnimationController::startAnimationsWaitingForStartTime):
(WebCore::CCLayerAnimationController::startAnimationsWaitingForTargetAvailability):
(WebCore::CCLayerAnimationController::resolveConflicts):
(WebCore::CCLayerAnimationController::purgeFinishedAnimations):
(WebCore::CCLayerAnimationController::tickAnimations):

  • platform/graphics/chromium/cc/CCLayerAnimationController.h:

(WebCore):
(CCLayerAnimationControllerClient):
(WebCore::CCLayerAnimationControllerClient::~CCLayerAnimationControllerClient):
(CCLayerAnimationController):

  • platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.cpp: Removed.
  • platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.h: Removed.
  • platform/graphics/chromium/cc/CCLayerAnimationDelegate.h:

(CCLayerAnimationDelegate):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::setOpacityFromAnimation):
(WebCore):
(WebCore::CCLayerImpl::setTransformFromAnimation):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):
(WebCore::CCLayerImpl::id):
(WebCore::CCLayerImpl::layerAnimationController):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::updateAnimations):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):
(WebCore::CCLayerTreeHost::animateLayers):
(WebCore):
(WebCore::CCLayerTreeHost::animateLayersRecursive):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::animateLayersRecursive):
(WebCore::CCLayerTreeHostImpl::animateLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(WebCore::CCThreadProxy::BeginFrameAndCommitState::BeginFrameAndCommitState):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCAnimationTestCommon.cpp:

(WebKitTests::FakeLayerAnimationControllerClient::FakeLayerAnimationControllerClient):
(WebKitTests::FakeLayerAnimationControllerClient::~FakeLayerAnimationControllerClient):

  • tests/CCAnimationTestCommon.h:

(FakeLayerAnimationControllerClient):
(WebKitTests::FakeLayerAnimationControllerClient::setOpacityFromAnimation):
(WebKitTests::FakeLayerAnimationControllerClient::setTransformFromAnimation):

  • tests/CCLayerAnimationControllerImplTest.cpp: Removed.
  • tests/CCLayerAnimationControllerTest.cpp:

(WebKitTests::TEST):
(WebKitTests):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestAddAnimation::CCLayerTreeHostTestAddAnimation):
(WTF::CCLayerTreeHostTestAddAnimation::animateLayers):
(CCLayerTreeHostTestAddAnimation):

  • tests/TreeSynchronizerTest.cpp:

(WebKitTests::FakeLayerAnimationController::create):
(WebKitTests::FakeLayerAnimationController::FakeLayerAnimationController):
(WebKitTests::FakeLayerAnimationController::pushAnimationUpdatesTo):
(WebKitTests::TEST):

07:37 Changeset [111392] by loislo@chromium.org

Web Inspector: REGRESSION Detached DOM Nodes are not highlighted
https://bugs.webkit.org/show_bug.cgi?id=81662

Reviewed by Yury Semikhatsky.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.get isDetachedDOMTree):

07:31 Changeset [111391] by gavinp@chromium.org

New PageCache histogram for tracking the highest leverage frame reject reasons.
https://bugs.webkit.org/show_bug.cgi?id=81358

Reviewed by Adam Barth.

The current chromium FrameClientImpl always denies page cache; but
that's easily fixable. This histogram tracks which rejection
causes occur alone with that cause. I'm particularly interested
in knowing how many more pages would work in the page cache if we
could get plugins in.

  • history/PageCache.cpp:

(WebCore::logCanCachePageDecision):

07:24 Changeset [111390] by mifenton@rim.com

[BlackBerry] Crash when dragging the FCC caret over an invalid node.
https://bugs.webkit.org/show_bug.cgi?id=81654

Reviewed by Rob Buis.

PR 144505.

The position did not have a valid container node and was causing
a crash. Validate the node pointer before using it.

  • WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::DOMContainerNodeForPosition):

07:01 Changeset [111389] by podivilov@chromium.org

Web Inspector: support inline source maps.
https://bugs.webkit.org/show_bug.cgi?id=81248

Source/WebCore:

  • support optional map.sourcesContent array with sources content
  • support data: url as script sourceMapURL, e.g. "@ sourceMappingURL=data:application/json;base64,<base64-encoded map>"

Reviewed by Pavel Feldman.

  • inspector/front-end/CompilerSourceMapping.js:

(WebInspector.ClosureCompilerSourceMapping):
(WebInspector.ClosureCompilerSourceMapping.prototype.loadSourceCode):
(WebInspector.ClosureCompilerSourceMapping.prototype._parseMap):
(WebInspector.ClosureCompilerSourceMapping.prototype._canonicalizeURL):

LayoutTests:

Reviewed by Pavel Feldman.

  • http/tests/inspector/compiler-source-mapping-expected.txt:
  • http/tests/inspector/compiler-source-mapping.html:
05:57 Changeset [111388] by pfeldman@chromium.org

Web Inspector: treat Uint* external arrays as arrays in console.
https://bugs.webkit.org/show_bug.cgi?id=81653

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::type):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::typeCallback):

LayoutTests:

  • inspector/console/console-external-array-expected.txt:
  • inspector/console/console-external-array.html:
05:38 Changeset [111387] by kling@webkit.org

Let CSSImageValue inherit directly from CSSValue.
<http://webkit.org/b/81635>

Reviewed by Antti Koivisto.

Source/WebCore:

This removes the last of the CSSPrimitiveValue subclasses, which will
open up the class to heavier refactoring.

Those CSSImageValues that used to represent the 'none' value are now
simply created as CSSPrimitiveValue identifiers by the parser.

Test: fast/css/image-value-type.html

  • css/CSSCursorImageValue.cpp:

(WebCore::CSSCursorImageValue::~CSSCursorImageValue):
(WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
(WebCore::CSSCursorImageValue::cachedImage):

  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::CSSImageValue):
(WebCore::CSSImageValue::cachedOrPendingImage):
(WebCore::CSSImageValue::cachedImage):
(WebCore::CSSImageValue::customCssText):

  • css/CSSImageValue.h:

(WebCore::CSSImageValue::url):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFillImage):
(WebCore::CSSParser::parseBorderImage):

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyCursor::applyValue):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • css/CSSValue.h:

(WebCore::CSSValue::isPrimitiveValue):

LayoutTests:

Added a test to document the fact that image values are no longer CSSPrimitiveValues.
Updated setPrimitiveValue.html and expectation to reflect this as well.

  • fast/css/image-value-type-expected.txt: Added.
  • fast/css/image-value-type.html: Added.
  • fast/dom/setPrimitiveValue-expected.txt:
  • fast/dom/setPrimitiveValue.html:
05:27 Changeset [111386] by ossy@webkit.org

[Qt][Mac] Unreviewed gardening, skip new failing tests to paint the bot green.

  • platform/qt-mac/Skipped:
05:22 Changeset [111385] by pfeldman@chromium.org

Web Inspector: call .length as the last check when detecting arrays.
https://bugs.webkit.org/show_bug.cgi?id=81335

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/InjectedScriptSource.js:

LayoutTests:

  • inspector/console/console-format-collections-expected.txt:
  • inspector/console/console-format-collections.html:
05:17 Changeset [111384] by apavlov@chromium.org

Web Inspector: newly added CSS rules shouldn't rewrite HTML content in the resources panel
https://bugs.webkit.org/show_bug.cgi?id=81414

Reviewed by Vsevolod Vlasov.

Source/WebCore:

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModelResourceBinding.prototype._styleSheetChanged.setContent):
(WebInspector.CSSStyleModelResourceBinding.prototype._styleSheetChanged):

LayoutTests:

  • inspector/styles/styles-add-new-rule.html:
05:01 Changeset [111383] by yurys@chromium.org

Web Inspector: provide class name filter for "comparison" view in heap profiler
https://bugs.webkit.org/show_bug.cgi?id=81641

Class name filtering now works for both Summary and Comparison views.

Reviewed by Pavel Feldman.

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype._createToolbarWithClassNameFilter):
(WebInspector.DetailedHeapshotView.prototype._changeNameFilter):

  • inspector/front-end/heapProfiler.css:

(.detailed-heapshot-view .class-view-grid):
(.detailed-heapshot-view .class-view-toolbar):
(.detailed-heapshot-view .class-view-toolbar input.class-name-filter):

04:57 Changeset [111382] by peter@chromium.org

[Chromium] Update to Android NDK r7b
https://bugs.webkit.org/show_bug.cgi?id=81005

Reviewed by Adam Barth.

Update to version r7b of the Android NDK, release notes of which are
available on the following page:
http://developer.android.com/sdk/ndk/index.html

  • Scripts/update-webkit-chromium:
04:52 Changeset [111381] by ossy@webkit.org

Division optimizations fail to infer cases of truncated division and mishandle -2147483648/-1
https://bugs.webkit.org/show_bug.cgi?id=81428

32 bit buildfix after r111355.

2147483648 (231) isn't valid int literal in ISO C90, because 2147483647 (231-1) is the biggest int.
The smallest int is -2147483648 (-231) == -2147483647 - 1 == -INT32_MAX-1 == INT32_MIN (stdint.h).

Reviewed by Zoltan Herczeg.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileIntegerArithDivForX86):

04:47 Changeset [111380] by zimmermann@webkit.org

Make animVal support type-safe
https://bugs.webkit.org/show_bug.cgi?id=81640

Reviewed by Antti Koivisto.

Source/WebCore:

Test: svg/animations/force-use-shadow-tree-recreation-while-animating.html

Redesign animVal support in a type-safe fashion, avoiding the SVGGenericAnimatedType
and associated reinterpret_casts, which require all call-sites to assure that the
types are safe to cast, before actually calling the method.

Remove pure virtual animationStarted/Ended/ValueWillChange/ValueDidChange & currentBaseValueVariant methods from SVGAnimatedProperty,
and de-virtualize them in classes that inherit from SVGAnimatedProperty, like SVGAnimatedPropertyTearOff, etc.

Add startAnimValAnimation/stopAnimValAnimation/resetAnimValToBaseVal/animValWillChange/animVallDidChange methods to all
SVGAnimatedXXXAnimator classes that currently support animVal (SVGAnimatedLength/LengthList/Number(OptionalNumber)/NumberList/TransformList).
Those SVGAnimatedLengthAnimator can cast the generic SVGAnimatedProperty* associated with a certain SVG DOM property, to the real type
eg. SVGAnimatedLength (which is a SVGAnimatedPropertyTearOff<SVGLength>). This way we can call those methods, without relying on virtual
function calls. Also it makes the "SVGGenericAnimatedType* currentBaseValueVariant()" accessor needless, as we can just call the method
right on eg. the SVGAnimatedLength, which gives us the "const SVGLength&" object, instead of a generic pointer type, that we have to
reinterpret_cast to some hopefully-matching expected type. The new approach is truly type-safey, but needs a bit more boilerplate code.

To reduce the amount of copy&paste across the SVGAnimatedXXXAnimator classes, all code is placed in template functions in
SVGAnimatedTypeAnimator.h, which can be shared across all SVGAnimatedXXXAnimator classes, that inherit from SVGAnimatedTypeAnimator.

Test: svg/animations/force-use-shadow-tree-recreation-while-animating.html

  • svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::calculateAnimatedValue):
(WebCore::SVGAnimateElement::resetToBaseValue):
(WebCore::SVGAnimateElement::applyResultsToTarget):
(WebCore):
(WebCore::SVGAnimateElement::targetElementWillChange):

  • svg/SVGAnimatedLength.cpp:

(WebCore::SVGAnimatedLengthAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedLengthAnimator::stopAnimValAnimation):
(WebCore):
(WebCore::SVGAnimatedLengthAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedLengthAnimator::animValWillChange):
(WebCore::SVGAnimatedLengthAnimator::animValDidChange):

  • svg/SVGAnimatedLength.h:

(WebCore):
(SVGAnimatedLengthAnimator):

  • svg/SVGAnimatedLengthList.cpp:

(WebCore::SVGAnimatedLengthListAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedLengthListAnimator::stopAnimValAnimation):
(WebCore):
(WebCore::SVGAnimatedLengthListAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedLengthListAnimator::animValWillChange):
(WebCore::SVGAnimatedLengthListAnimator::animValDidChange):

  • svg/SVGAnimatedLengthList.h:

(WebCore):
(SVGAnimatedLengthListAnimator):

  • svg/SVGAnimatedNumber.cpp:

(WebCore::SVGAnimatedNumberAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedNumberAnimator::stopAnimValAnimation):
(WebCore):
(WebCore::SVGAnimatedNumberAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedNumberAnimator::animValWillChange):
(WebCore::SVGAnimatedNumberAnimator::animValDidChange):

  • svg/SVGAnimatedNumber.h:

(WebCore):
(SVGAnimatedNumberAnimator):

  • svg/SVGAnimatedNumberList.cpp:

(WebCore::SVGAnimatedNumberListAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedNumberListAnimator::stopAnimValAnimation):
(WebCore):
(WebCore::SVGAnimatedNumberListAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedNumberListAnimator::animValWillChange):
(WebCore::SVGAnimatedNumberListAnimator::animValDidChange):

  • svg/SVGAnimatedNumberList.h:

(WebCore):
(SVGAnimatedNumberListAnimator):

  • svg/SVGAnimatedNumberOptionalNumber.cpp:

(WebCore::SVGAnimatedNumberOptionalNumberAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::stopAnimValAnimation):
(WebCore):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::animValWillChange):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::animValDidChange):

  • svg/SVGAnimatedNumberOptionalNumber.h:

(WebCore):
(SVGAnimatedNumberOptionalNumberAnimator):

  • svg/SVGAnimatedTransformList.cpp:

(WebCore::SVGAnimatedTransformListAnimator::startAnimValAnimation):
(WebCore):
(WebCore::SVGAnimatedTransformListAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedTransformListAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedTransformListAnimator::animValWillChange):
(WebCore::SVGAnimatedTransformListAnimator::animValDidChange):

  • svg/SVGAnimatedTransformList.h:

(WebCore):
(SVGAnimatedTransformListAnimator):

  • svg/SVGAnimatedType.h:

(WebCore):

  • svg/SVGAnimatedTypeAnimator.h:

(WebCore):
(SVGAnimatedTypeAnimator):
(WebCore::SVGAnimatedTypeAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedTypeAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedTypeAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedTypeAnimator::animValWillChange):
(WebCore::SVGAnimatedTypeAnimator::animValDidChange):
(WebCore::SVGAnimatedTypeAnimator::findAnimatedPropertiesForAttributeName):
(WebCore::SVGAnimatedTypeAnimator::startAnimation):
(WebCore::SVGAnimatedTypeAnimator::stopAnimValAnimationForType):
(WebCore::SVGAnimatedTypeAnimator::animValDidChangeForType):
(WebCore::SVGAnimatedTypeAnimator::animValWillChangeForType):
(WebCore::SVGAnimatedTypeAnimator::constructFromOneBaseValue):
(WebCore::SVGAnimatedTypeAnimator::resetFromOneBaseValue):
(WebCore::SVGAnimatedTypeAnimator::constructFromTwoBaseValues):
(WebCore::SVGAnimatedTypeAnimator::resetFromTwoBaseValues):
(WebCore::SVGAnimatedTypeAnimator::castAnimatedPropertyToActualType):
(WebCore::SVGAnimatedTypeAnimator::collectAnimatedPropertiesFromInstances):

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::applyAnimatedValue):
(WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):

  • svg/SVGAnimationElement.h:

(SVGAnimationElement):

  • svg/SVGElementInstance.cpp:

(WebCore::SVGElementInstance::invalidateAllInstancesOfElement):
(WebCore::SVGElementInstance::InstanceUpdateBlocker::InstanceUpdateBlocker):
(WebCore):
(WebCore::SVGElementInstance::InstanceUpdateBlocker::~InstanceUpdateBlocker):

  • svg/SVGElementInstance.h:

(WebCore):
(InstanceUpdateBlocker):
(SVGElementInstance):

  • svg/properties/SVGAnimatedListPropertyTearOff.h:

(WebCore::SVGAnimatedListPropertyTearOff::currentBaseValue):
(WebCore::SVGAnimatedListPropertyTearOff::animationStarted):
(WebCore::SVGAnimatedListPropertyTearOff::animationEnded):
(WebCore::SVGAnimatedListPropertyTearOff::animValWillChange):
(WebCore::SVGAnimatedListPropertyTearOff::animValDidChange):

  • svg/properties/SVGAnimatedProperty.h:

(WebCore):

  • svg/properties/SVGAnimatedPropertyTearOff.h:

(WebCore::SVGAnimatedPropertyTearOff::currentBaseValue):
(WebCore::SVGAnimatedPropertyTearOff::animationStarted):
(WebCore::SVGAnimatedPropertyTearOff::animationEnded):
(WebCore::SVGAnimatedPropertyTearOff::animValWillChange):
(WebCore::SVGAnimatedPropertyTearOff::animValDidChange):

  • svg/properties/SVGAnimatedStaticPropertyTearOff.h:

(WebCore::SVGAnimatedStaticPropertyTearOff::currentBaseValue):
(WebCore::SVGAnimatedStaticPropertyTearOff::animationStarted):
(WebCore::SVGAnimatedStaticPropertyTearOff::animationEnded):
(WebCore::SVGAnimatedStaticPropertyTearOff::animValWillChange):
(WebCore::SVGAnimatedStaticPropertyTearOff::animValDidChange):

LayoutTests:

Add a new test which forces recreation of a <use> shadow tree while animation is running.

  • svg/animations/force-use-shadow-tree-recreation-while-animating-expected.txt: Added.
  • svg/animations/force-use-shadow-tree-recreation-while-animating.html: Added.
  • svg/animations/resources/force-use-shadow-tree-recreation-while-animating.svg: Added.
  • svg/animations/script-tests/force-use-shadow-tree-recreation-while-animating.js: Added.

(sample1):
(sample2):
(forceUseShadowTreeRecreation):
(sample3):
(executeTest):

04:26 Changeset [111379] by keishi@webkit.org

[chromium] Marking WebFrameTest.DivAutoZoomParamsTest as failing.

  • tests/WebFrameTest.cpp:

(WebKit::TEST_F):

03:24 Changeset [111378] by ossy@webkit.org

[Qt] Gardening, skip failing tests, add platform specific expected files.

Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-03-20
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
  • platform/qt/fast/events/touch/gesture/pad-gesture-cancel-expected.png: Added after r111182.
  • platform/qt/fast/events/touch/gesture/pad-gesture-cancel-expected.txt: Added after r111182.
03:21 Changeset [111377] by peter@chromium.org

[Chromium] Fix the Android build by building NEWWTF for host
https://bugs.webkit.org/show_bug.cgi?id=81643

Reviewed by Tony Gentilcore.

Chromium for Android builds the ImageDiff target for the host architecture,
so all dependencies it has need to be able to build for host as well.
r111258 added (new)WTF as a dependency instead of just including the
header files, so make it possible to build the newwtf target for host.

  • WTF.gyp/WTF.gyp:
03:08 Changeset [111376] by mihnea@adobe.com

[CSSRegions]Implement NamedFlow::getRegionsByContentNode
https://bugs.webkit.org/show_bug.cgi?id=77746

Reviewed by David Hyatt.

The list of regions returned is a static node list.

Source/WebCore:

Tests: fast/regions/get-regions-by-content-node-horiz-bt.html

fast/regions/get-regions-by-content-node-horiz-tb.html
fast/regions/get-regions-by-content-node-vert-lr.html
fast/regions/get-regions-by-content-node-vert-rl.html
fast/regions/get-regions-by-content-node.html
fast/regions/get-regions-by-content-node2.html

  • dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::getRegionsByContentNode):
(WebCore):

  • dom/WebKitNamedFlow.h:

(WebKitNamedFlow):

  • dom/WebKitNamedFlow.idl:
  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::regionInRange):
(WebCore):
(WebCore::RenderFlowThread::objectInFlowRegion):

  • rendering/RenderFlowThread.h:
  • rendering/RenderRegion.h:

(WebCore::RenderRegion::flowThread):

LayoutTests:

  • fast/regions/get-regions-by-content-node-expected.txt: Added.
  • fast/regions/get-regions-by-content-node-horiz-bt-expected.txt: Added.
  • fast/regions/get-regions-by-content-node-horiz-bt.html: Added.
  • fast/regions/get-regions-by-content-node-horiz-tb-expected.txt: Added.
  • fast/regions/get-regions-by-content-node-horiz-tb.html: Added.
  • fast/regions/get-regions-by-content-node-vert-lr-expected.txt: Added.
  • fast/regions/get-regions-by-content-node-vert-lr.html: Added.
  • fast/regions/get-regions-by-content-node-vert-rl-expected.txt: Added.
  • fast/regions/get-regions-by-content-node-vert-rl.html: Added.
  • fast/regions/get-regions-by-content-node.html: Added.
  • fast/regions/get-regions-by-content-node2-expected.txt: Added.
  • fast/regions/get-regions-by-content-node2.html: Added.
02:49 Changeset [111375] by ossy@webkit.org

x86 GCC bug triggers a compilation error in generated copy constructor of CollapsedBorderValue
https://bugs.webkit.org/show_bug.cgi?id=81502

Unreviewed.

  • qmake/mkspecs/features/unix/default_post.prf: Reenable Werror after r111171.
02:40 Changeset [111374] by keishi@webkit.org

[chromium] Fixing mime type for test expectation png files.

  • platform/chromium-linux-x86/fast/table/max-width-integer-overflow-expected.png: Added property svn:mime-type.
  • platform/chromium-linux/fast/clip/overflow-border-radius-fixed-position-expected.png: Modified property svn:mime-type.
  • platform/chromium-linux/fast/table/max-width-integer-overflow-expected.png: Added property svn:mime-type.
  • platform/chromium-mac-leopard/fast/clip/overflow-border-radius-fixed-position-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/compositing/geometry/video-opacity-overlay-expected.png: Added property svn:mime-type.
  • platform/chromium-mac-snowleopard/compositing/reflections/load-video-in-reflection-expected.png: Added property svn:mime-type.
  • platform/chromium-mac/fast/clip/overflow-border-radius-fixed-position-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Modified property svn:mime-type.
  • platform/chromium-win-vista/compositing/shadows/shadow-drawing-expected.png: Added property svn:mime-type.
  • platform/chromium-win-xp/fast/table/max-width-integer-overflow-expected.png: Added property svn:mime-type.
  • platform/chromium-win/compositing/layer-creation/fixed-position-scroll-expected.png: Added property svn:mime-type.
  • platform/chromium-win/fast/clip/overflow-border-radius-fixed-position-expected.png: Modified property svn:mime-type.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png: Modified property svn:mime-type.
02:09 Changeset [111373] by leviw@chromium.org

Unreviewed Chromium gardening.

Marking editing/selection/iframe.html as flaky on 10.6 debug. Occasionally the caret isn't painted for some reason.
Removing iframe-reparenting-new-page.html entry from test_expectations.txt since the test no longer exists.

  • platform/chromium/test_expectations.txt:
01:53 Changeset [111372] by slewis@apple.com

https://bugs.webkit.org/show_bug.cgi?id=81637 fast/dom/Window/timer-resume-on-navigation-back.html times out.
Skips a test that times out.

Unreviewed.

  • platform/mac-wk2/Skipped:
01:32 Changeset [111371] by macpherson@chromium.org

Remove min and max parameters from CSSPrimitiveValue's roundForImpreciseConversion function.
https://bugs.webkit.org/show_bug.cgi?id=81629

Reviewed by Andreas Kling.

No new tests / refactoring only.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::computeLength):

  • css/CSSPrimitiveValue.h:

(WebCore::roundForImpreciseConversion):

  • rendering/style/RenderStyle.h:

(WebCore::adjustForAbsoluteZoom):

01:24 Changeset [111370] by commit-queue@webkit.org

[BlackBerry]Cookies shouldn't be set into each of webcore's request and platform's request. And this makes a regression.
https://bugs.webkit.org/show_bug.cgi?id=80800

Source/WebCore:

FrameLoaderClientBlackBerry::dispatchWillSendRequest sets cookies to resourceRequest's header
list to show cookies in inspector. And NetworkManager::startJob will set cookies to platformRequest's
m_cookieData again. So cookies are set two times. This causes performance issue.

Moreover, platformRequest will copy cookies from the resourceRequest. And then platformRequest has
the same cookies in its header list and m_cookieData. Network will use header list's cookies which
are output as latin1 only. This causes the regression of https://bugs.webkit.org/show_bug.cgi?id=80307.

Now, set cookies in initializePlatformRequest to ensure setting cookies only once.

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-03-20
Reviewed by George Staikos.

Test: http/tests/cookies/resources/setUtf8Cookies.php

  • platform/network/blackberry/NetworkManager.cpp:

(WebCore::NetworkManager::startJob):

  • platform/network/blackberry/ResourceRequest.h:

(ResourceRequest):

  • platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::ResourceRequest::initializePlatformRequest):

Source/WebKit/blackberry:

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-03-20
Reviewed by George Staikos.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
(WebCore::FrameLoaderClientBlackBerry::decidePolicyForExternalLoad):

LayoutTests:

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-03-20
Reviewed by George Staikos.

  • http/tests/cookies/resources/setUtf8Cookies-expected.txt: Added.
  • http/tests/cookies/resources/setUtf8Cookies-result.php: Added.
  • http/tests/cookies/resources/setUtf8Cookies.php: Added.
01:20 Changeset [111369] by keishi@webkit.org

[chromium] Marking listbox-clear-restore.html on Linux as flaky.

  • platform/chromium/test_expectations.txt:
00:59 Changeset [111368] by slewis@apple.com

https://bugs.webkit.org/show_bug.cgi?id=81634 some SVG Zoom tests fail on Lion WK2 bots

Unreviewed.

Check in new expected (failing?) results.

  • platform/mac-wk2/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt:
  • platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:

03/19/12:

23:49 Changeset [111367] by ossy@webkit.org

[Qt] New test introduced in r110532 fails on 32 bit.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-03-19
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
23:48 Changeset [111366] by jochen@chromium.org

Split WTFReportBacktrace into WTFReportBacktrace and WTFPrintBacktrace
https://bugs.webkit.org/show_bug.cgi?id=80983

Reviewed by Darin Adler.

This allows printing a backtrace acquired by an earlier WTFGetBacktrace
call which is useful for local debugging.

  • wtf/Assertions.cpp:
  • wtf/Assertions.h:
23:43 Changeset [111365] by keishi@webkit.org

[chromium] Rebaselining nested-fragment-parser-crash.html again.

  • platform/chromium-linux-x86/fast/parser/nested-fragment-parser-crash-expected.txt: Added.
  • platform/chromium-linux/fast/parser/nested-fragment-parser-crash-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/parser/nested-fragment-parser-crash-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/parser/nested-fragment-parser-crash-expected.txt: Added.
  • platform/chromium-win-vista/fast/parser/nested-fragment-parser-crash-expected.txt: Added.
  • platform/chromium-win-xp/fast/parser/nested-fragment-parser-crash-expected.txt: Added.
  • platform/chromium-win/fast/parser/nested-fragment-parser-crash-expected.txt: Added.
23:37 Changeset [111364] by benjamin@webkit.org

Build fix for Debug build after r111358

Unreviewed.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-19

  • bindings/js/CachedScriptSourceProvider.h:
  • bindings/js/StringSourceProvider.h:
23:35 Changeset [111363] by ossy@webkit.org

fast/table/max-width-integer-overflow.html should be skipped because it gives
different results on 32- and 64-bit systems.

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-03-19
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
23:17 Changeset [111362] by eae@chromium.org

Add FractionalLayoutUnit version of blend to AnimationUtilities
https://bugs.webkit.org/show_bug.cgi?id=81572

Reviewed by Eric Seidel.

Add version of blend method that operates on FractionalLayoutUnits. This
will be used in place of the integer version in many places once we
enable support for subpixel layout.

No new tests.

  • platform/FractionalLayoutUnit.h:

Include math.h to make GTK build happy.

  • platform/animation/AnimationUtilities.h:

(WebCore::blend):

22:58 Changeset [111361] by abarth@webkit.org

Remove support for "magic" iframe
https://bugs.webkit.org/show_bug.cgi?id=81590

Reviewed by Eric Seidel.

Source/WebCore:

This patch removes support for "magic" iframe, which previously allowed
an iframe to be transfered from one document to another without
reloading the iframe. The idea behind this feature was to let sites
create "pop out" windows that could outlive their parents by
transfering state to these windows via these magic iframes.

Unforuntately, this feature was never implemented by other browsers and
has been the source of a series of security vulnerabilities. Although
we have fixed each vulnerability as it has been discovered, the feature
is still a complex corner case that isn't widely exercised on the web.
For that reason, it's likely to have more vulnerabilities in the
future.

I'm not aware of any web sites that use this feature anymore. There
were a handful of them, but we appear to have been successful in
evangalizing them to move away from "magic" iframe.

  • dom/Document.cpp:

(WebCore::Document::adoptNode):

  • html/HTMLFrameElementBase.cpp:

(WebCore):
(WebCore::HTMLFrameElementBase::HTMLFrameElementBase):
(WebCore::HTMLFrameElementBase::insertedIntoDocument):

  • html/HTMLFrameElementBase.h:

(HTMLFrameElementBase):

  • loader/DocumentLoader.cpp:

(WebCore):

  • loader/DocumentLoader.h:

(DocumentLoader):

  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::createFrame):

  • loader/FrameLoader.cpp:

(WebCore):

  • loader/FrameLoader.h:

(FrameLoader):

  • loader/FrameLoaderClient.h:

(FrameLoaderClient):

  • loader/ResourceLoadNotifier.cpp:

(WebCore):

  • loader/ResourceLoadNotifier.h:

(ResourceLoadNotifier):

  • page/Frame.cpp:

(WebCore):

  • page/Frame.h:

(Frame):

Source/WebKit/blackberry:

Remove FrameLoaderClient methods that no longer exist.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore):

  • WebCoreSupport/FrameLoaderClientBlackBerry.h:

(FrameLoaderClientBlackBerry):
(WebCore::FrameLoaderClientBlackBerry::didDetectXSS):

Source/WebKit/chromium:

Remove FrameLoaderClient methods that no longer exist.

  • public/WebFrameClient.h:

(WebFrameClient):

  • src/FrameLoaderClientImpl.cpp:

(WebKit):

  • src/FrameLoaderClientImpl.h:

(FrameLoaderClientImpl):

Source/WebKit/efl:

Remove FrameLoaderClient methods that no longer exist.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore):

  • WebCoreSupport/FrameLoaderClientEfl.h:

(FrameLoaderClientEfl):

Source/WebKit/gtk:

Remove FrameLoaderClient methods that no longer exist.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit):

  • WebCoreSupport/FrameLoaderClientGtk.h:

(FrameLoaderClient):

Source/WebKit/mac:

Remove FrameLoaderClient methods that no longer exist.

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

Source/WebKit/qt:

Remove FrameLoaderClient methods that no longer exist.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore):

  • WebCoreSupport/FrameLoaderClientQt.h:

(FrameLoaderClientQt):

Source/WebKit/win:

Remove FrameLoaderClient methods that no longer exist.

  • WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebCoreSupport/WebFrameLoaderClient.h:

(WebFrameLoaderClient):

Source/WebKit/wince:

Remove FrameLoaderClient methods that no longer exist.

  • WebCoreSupport/FrameLoaderClientWinCE.cpp:

(WebKit):

  • WebCoreSupport/FrameLoaderClientWinCE.h:

(FrameLoaderClientWinCE):

Source/WebKit/wx:

Remove FrameLoaderClient methods that no longer exist.

  • WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore):

  • WebKitSupport/FrameLoaderClientWx.h:

(FrameLoaderClientWx):

Source/WebKit2:

Remove FrameLoaderClient methods that no longer exist.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

LayoutTests:

Remove tests of magic iframe. These tests don't reall make sense to
keep without the feature.

  • fast/frames/adopt-iframe-into-itself-expected.txt: Added.
  • fast/frames/adopt-iframe-into-itself.html: Added.
    • I've added a test about adopting an iframe into itself. We might already have a test for this, but it covers a mistake I made in an earlier iteration of this patch.
  • fast/frames/iframe-reparenting-adopt-node-expected.txt: Removed.
  • fast/frames/iframe-reparenting-adopt-node.html: Removed.
  • fast/frames/iframe-reparenting-embed-elements-expected.txt: Removed.
  • fast/frames/iframe-reparenting-embed-elements.html: Removed.
  • fast/frames/iframe-reparenting-expected.txt: Removed.
  • fast/frames/iframe-reparenting-fail-load-expected.txt: Removed.
  • fast/frames/iframe-reparenting-fail-load.html: Removed.
  • fast/frames/iframe-reparenting-new-page-expected.txt: Removed.
  • fast/frames/iframe-reparenting-new-page.html: Removed.
  • fast/frames/iframe-reparenting-plugins-expected.txt: Removed.
  • fast/frames/iframe-reparenting-plugins.html: Removed.
  • fast/frames/iframe-reparenting.html: Removed.
  • fast/frames/resources/iframe-reparenting-adopt-node-iframe-content.html: Removed.
  • fast/frames/resources/iframe-reparenting-adopt-node-new-page.html: Removed.
  • fast/frames/resources/iframe-reparenting-embed-frame1.html: Removed.
  • fast/frames/resources/iframe-reparenting-embed-iframe.html: Removed.
  • fast/frames/resources/iframe-reparenting-frame1.html: Removed.
  • fast/frames/resources/iframe-reparenting-frame2.html: Removed.
  • fast/frames/resources/iframe-reparenting-iframe-content.html: Removed.
  • fast/frames/resources/iframe-reparenting-new-page-1.html: Removed.
  • fast/frames/resources/iframe-reparenting-new-page-2.html: Removed.
  • fast/frames/resources/iframe-reparenting-new-page-iframe.html: Removed.
  • fast/frames/resources/iframe-reparenting-plugins-iframe-content.html: Removed.
  • fast/frames/resources/iframe-reparenting-plugins-new-page.html: Removed.
  • fast/frames/script-tests/iframe-reparenting-new-page.js: Removed.
22:37 Changeset [111360] by jchaffraix@webkit.org

REGRESSION(r110072): Improper repainting on table with overflow: hidden
https://bugs.webkit.org/show_bug.cgi?id=81460

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/repaint/table-hover-on-link.html

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout): Add a call to RenderBlock::updateCachedSizeForOverflowClip
so that we properly keep our cached size up to date. This fixes the problem for now but the
real solution is to make sure it is called on all classes that needs to. This is tracked by
bug 81461.

LayoutTests:

  • fast/repaint/table-hover-on-link-expected.txt: Added.
  • fast/repaint/table-hover-on-link.html: Added.
  • platform/chromium-linux/fast/repaint/table-hover-on-link-expected.png: Added.
  • platform/chromium-mac/fast/repaint/table-hover-on-link-expected.png: Added.
  • platform/mac/fast/repaint/table-hover-on-link-expected.png: Added.

There seem to be some small color difference here (maybe color profile related).

22:29 Changeset [111359] by commit-queue@webkit.org

Add support for crossorigin attribute in script elements
https://bugs.webkit.org/show_bug.cgi?id=81438

Patch by Pablo Flouret <pablof@motorola.com> on 2012-03-19
Reviewed by Adam Barth.

Source/WebCore:

Works similarly to img and its crossorigin attribute. In the future it
could allow for things like showing full error messages in error
handlers, etc.

Tests: http/tests/security/script-crossorigin-loads-correctly.html

http/tests/security/script-crossorigin-loads-same-origin.html
http/tests/security/script-with-failed-cors-check-fails-to-load.html

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::ScriptElement):
(WebCore::ScriptElement::requestScript):
(WebCore::ScriptElement::notifyFinished):

  • dom/ScriptElement.h:

(ScriptElement):

  • html/HTMLScriptElement.idl:

LayoutTests:

  • http/tests/security/resources/alert-fail.js: Added.
  • http/tests/security/resources/cors-script.php: Added.
  • http/tests/security/script-crossorigin-loads-correctly-expected.txt: Added.
  • http/tests/security/script-crossorigin-loads-correctly.html: Added.
  • http/tests/security/script-crossorigin-loads-same-origin-expected.txt: Added.
  • http/tests/security/script-crossorigin-loads-same-origin.html: Added.
  • http/tests/security/script-with-failed-cors-check-fails-to-load-expected.txt: Added.
  • http/tests/security/script-with-failed-cors-check-fails-to-load.html: Added.
22:24 Changeset [111358] by benjamin@webkit.org

Do not copy the script source in the SourceProvider, just reference the existing string
https://bugs.webkit.org/show_bug.cgi?id=81466

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • parser/SourceCode.h: Remove the unused, and incorrect, function data().
  • parser/SourceProvider.h: Add OVERRIDE for clarity.

Source/WebCore:

Instead of creating a copy of the string with 16bits characters, we just return
a shared StringImpl.

  • bindings/js/CachedScriptSourceProvider.h:
  • bindings/js/StringSourceProvider.h:
22:21 Changeset [111357] by commit-queue@webkit.org

A quick early-out for Region::contains() test
https://bugs.webkit.org/show_bug.cgi?id=81625

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-19
Reviewed by Anders Carlsson.

If the bounds of region B include a row/column that is outside the bounds of
region A, then region B contains a pixel within that row/column that is
outside of region A.

  • platform/graphics/Region.cpp:

(WebCore::Region::contains):

22:20 Changeset [111356] by eric@webkit.org

Unreviewed attempt to fix the EFL build.

  • platform/graphics/efl/IconEfl.cpp:
22:15 Changeset [111355] by fpizlo@apple.com

Division optimizations fail to infer cases of truncated division and
mishandle -2147483648/-1
https://bugs.webkit.org/show_bug.cgi?id=81428
<rdar://problem/11067382>

Reviewed by Oliver Hunt.

If you're a division over integers and you're only used as an integer, then you're
an integer division and remainder checks become unnecessary. If you're dividing
-2147483648 by -1, don't crash.

  • assembler/MacroAssemblerX86Common.h:

(MacroAssemblerX86Common):
(JSC::MacroAssemblerX86Common::add32):

  • dfg/DFGSpeculativeJIT.cpp:

(DFG):
(JSC::DFG::SpeculativeJIT::compileIntegerArithDivForX86):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • llint/LowLevelInterpreter64.asm:
22:04 Changeset [111354] by eric@webkit.org

Fix more WTF header include paths in WebCore
https://bugs.webkit.org/show_bug.cgi?id=81602

Reviewed by Martin Robinson.

Chromium, Mac and Win already build w/o including wtf subdirectories
in their include paths for WebCore/WebKit. Gtk, Qt, and other ports
should eventually do the same. This patch fixes up a few loose
wtf includes in these ports using some search/replace across WebCore.
If the EWS bots pass this patch doesn't really need any other review.

  • accessibility/gtk/AXObjectCacheAtk.cpp:
  • accessibility/gtk/WebKitAccessibleInterfaceText.cpp:
  • platform/KURL.cpp:
  • platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
  • platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
  • platform/audio/gtk/AudioBusGtk.cpp:
  • platform/clutter/GRefPtrClutter.h:
  • platform/graphics/gstreamer/GRefPtrGStreamer.h:
  • platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
  • platform/graphics/gstreamer/ImageGStreamerQt.cpp:
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
  • platform/graphics/gtk/ImageBufferGtk.cpp:
  • platform/graphics/pango/FontPango.cpp:
  • platform/graphics/qt/ImageBufferDataQt.h:
  • platform/graphics/wx/ImageBufferDataWx.h:
  • platform/gtk/ContextMenuGtk.cpp:
  • platform/gtk/ContextMenuItemGtk.cpp:
  • platform/gtk/FileSystemGtk.cpp:
  • platform/gtk/GOwnPtrGtk.h:
  • platform/gtk/GtkAuthenticationDialog.h:
  • platform/gtk/GtkPopupMenu.cpp:
  • platform/gtk/LanguageGtk.cpp:
  • platform/gtk/LocalizedStringsGtk.cpp:
  • platform/gtk/PopupMenuGtk.cpp:
  • platform/gtk/RenderThemeGtk.cpp:
  • platform/gtk/RenderThemeGtk.h:
  • platform/network/soup/GOwnPtrSoup.h:
  • platform/network/soup/ResourceRequestSoup.cpp:
  • platform/network/soup/ResourceResponseSoup.cpp:
  • platform/network/soup/SocketStreamHandle.h:
  • platform/network/soup/SoupURIUtils.cpp:
  • platform/text/TextEncoding.cpp:
  • platform/text/gtk/TextBreakIteratorGtk.cpp:
  • platform/text/gtk/TextCodecGtk.cpp:
  • platform/text/gtk/TextCodecGtk.h:
21:53 Changeset [111353] by jchaffraix@webkit.org

Move the extra logical height distribution into RenderTable as a new step in our layout algorithm
https://bugs.webkit.org/show_bug.cgi?id=81548

Reviewed by Tony Chang.

Refactoring, no expected change in behavior.

Moving the distribution step into RenderTable is needed to implement a better distribution algorithm that would
span several RenderTableSection (which is what IE and FF are doing right now).

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::distributeExtraLogicalHeight):
(WebCore::RenderTable::layout):
Moved the distribution step into distributeExtraLogicalHeight. While at it, changed the code to make use of the helper
methods to iterate over the sections and explicitly floor the LayoutUnit before calling distributeExtraLogicalHeight.

  • rendering/RenderTable.h:

Added distributeExtraLogicalHeight.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):
Changed the method signature as it doesn't handle the distribution step anymore.

  • rendering/RenderTableSection.h:

Updated layoutRows signature and exposed distributeExtraLogicalHeightToRows for RenderTable use.

21:50 Changeset [111352] by andersca@apple.com

Another attempt at fixing the Windows build.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::LayerClient::platformCALayerDeviceScaleFactor):

21:48 Changeset [111351] by andersca@apple.com

plugins/application-plugin-plugins-disabled.html should be a Qt specific test
https://bugs.webkit.org/show_bug.cgi?id=81628

Reviewed by Jessie Berlin.

This test tests an "application specific plug-in" feature that only Qt has so this should be
a Qt specific test.

  • platform/chromium-linux/plugins/application-plugin-plugins-disabled-expected.png: Removed.
  • platform/chromium-mac-leopard/plugins/application-plugin-plugins-disabled-expected.png: Removed.
  • platform/chromium-mac-snowleopard/plugins/application-plugin-plugins-disabled-expected.png: Removed.
  • platform/chromium-mac/plugins/application-plugin-plugins-disabled-expected.png: Removed.
  • platform/chromium-win/plugins/application-plugin-plugins-disabled-expected.png: Removed.
  • platform/chromium-win/plugins/application-plugin-plugins-disabled-expected.txt: Removed.
  • platform/gtk/plugins/application-plugin-plugins-disabled-expected.txt: Removed.
  • platform/mac-snowleopard/plugins/application-plugin-plugins-disabled-expected.png: Removed.
  • platform/mac/plugins/application-plugin-plugins-disabled-expected.txt: Removed.
  • platform/qt/plugins/application-plugin-plugins-disabled.html: Renamed from LayoutTests/plugins/application-plugin-plugins-disabled.html.
  • platform/wk2/Skipped:
21:47 Changeset [111350] by commit-queue@webkit.org

[Chromium] Add registerURLSchemeAsEmptyDocument to WebSecurityPolicy
https://bugs.webkit.org/show_bug.cgi?id=81421

Patch by Charlie Reis <creis@chromium.org> on 2012-03-19
Reviewed by Adam Barth.

  • public/WebSecurityPolicy.h:

(WebSecurityPolicy):

  • src/WebSecurityPolicy.cpp:

(WebKit::WebSecurityPolicy::registerURLSchemeAsEmptyDocument):
(WebKit):

21:45 Changeset [111349] by keishi@webkit.org

[chromium] Rebaseline caused by r111334

  • platform/chromium-linux-x86/fast/repaint/canvas-putImageData-expected.txt: Added.
  • platform/chromium-linux/fast/repaint/canvas-putImageData-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/canvas-putImageData-expected.txt: Added.
21:39 Changeset [111348] by gyuyoung.kim@samsung.com

[EFL] Fix build break because of PlatformString.h
https://bugs.webkit.org/show_bug.cgi?id=81619

Unreviewed. Fix build break because of PlatformString.h.

  • platform/graphics/efl/IconEfl.cpp: Include PlatformString.h from text directory.
21:25 Changeset [111347] by eric@webkit.org

Fix CrWin build after r111258.
https://bugs.webkit.org/show_bug.cgi?id=81281

Unreviewed build fix.
I also fixed similarly incorrect wtf/ includes for other ports
(which aren't yet as strict as Chromium about wtf includes).

  • platform/blackberry/CookieManager.cpp:
  • platform/blackberry/CookieParser.cpp:
  • platform/blackberry/ParsedCookie.cpp:
  • platform/blackberry/SharedTimerBlackBerry.cpp:
  • platform/graphics/qt/GraphicsLayerQt.cpp:
  • platform/graphics/texmap/TextureMapperAnimation.cpp:
  • rendering/RenderThemeChromiumWin.cpp:

(WebCore):

21:04 Changeset [111346] by timothy_horton@apple.com

[WK2] Four http/tests/xmlhttprequest tests fail on mac-wk2
https://bugs.webkit.org/show_bug.cgi?id=81627

Unreviewed; skip failing http/tests/xmlhttprequest tests on mac-wk2.

  • platform/mac-wk2/Skipped:
20:51 Changeset [111345] by mrobinson@webkit.org

Update the NEWS and version for the WebKitGTK+ 1.7.92 release.

Reviewed by Gustavo Noronha Silva.

.:

  • configure.ac:

Source/WebKit/gtk:

  • NEWS:
20:48 Changeset [111344] by eric@webkit.org

Fix CrWin build after r111258.
https://bugs.webkit.org/show_bug.cgi?id=81281

Unreviewed build fix.

  • platform/graphics/chromium/FontCacheChromiumWin.cpp:
  • platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
  • platform/graphics/texmap/TextureMapperAnimation.h:
20:46 Changeset [111343] by jberlin@webkit.org

Unreviewed; roll out http://trac.webkit.org/changeset/111307 and http://trac.webkit.org/changeset/111293
because they broke running the layout tests on mac.

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitDriver._check_for_driver_crash):

20:32 Changeset [111342] by tony@chromium.org

add css parsing of flex-line-pack
https://bugs.webkit.org/show_bug.cgi?id=81427

Reviewed by Ojan Vafai.

Source/WebCore:

Spec: http://dev.w3.org/csswg/css3-flexbox/#flex-line-pack

Updated tests in css3/flexbox/css-properties.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore):
(WebCore::CSSPrimitiveValue::operator EFlexLinePack):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSStyleApplyProperty.cpp:

(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • css/CSSValueKeywords.in:
  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleFlexibleBoxData.cpp:

(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):

  • rendering/style/StyleFlexibleBoxData.h:

(StyleFlexibleBoxData):

LayoutTests:

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/script-tests/css-properties.js:
20:27 Changeset [111341] by slewis@apple.com

http://bugs.webkit.org/show_bug.cgi?id=81618

fast/workers/storage/use-same-database-in-page-and-workers.html times out on the lion bots
parser test that times out waiting for notifyDone

Unreviewed.

Skip test that times out on the Lion WK1 bots.

  • platform/mac/Skipped:
20:22 Changeset [111340] by kov@webkit.org

[GTK] libWebCore.la has become too big for make
https://bugs.webkit.org/show_bug.cgi?id=81582

Unreviewed build fix.

Source/WebCore:

  • GNUmakefile.am: build an intermediate library for modules, so that the list

of source files used to build WebCore can be split and not reach make's limits;
also try to force relinking libWebCore.la and libWebCoreModules.la when the
GNUmakefile.am or GNUmakefile.list.am change

Source/WebKit/gtk:

  • GNUmakefile.am: link-in the new libDerivedWebCore.la

Source/WebKit2:

  • GNUmakefile.am: link-in the new libWebCoreModules.la
20:17 Changeset [111339] by slewis@apple.com

https://bugs.webkit.org/show_bug.cgi?id=81620 tables/mozilla/bugs/bug27038-* fail on Lion Bots.

Unreviewed.

Check in new expected (failing?) results.

  • platform/mac/tables/mozilla/bugs/bug27038-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug27038-2-expected.txt:
20:14 Changeset [111338] by keishi@webkit.org

[chromium] Fixing build. Adding missing virtual.

  • src/GraphicsContext3DPrivate.h:

(GraphicsContext3DPrivate):

20:13 Changeset [111337] by timothy_horton@apple.com

[WK2] http/tests/websocket/tests/hixie76/frame-lengths.html times out on mac-wk2
https://bugs.webkit.org/show_bug.cgi?id=81624

Unreviewed; skip timing out http/tests/websocket/tests/hixie76/frame-lengths.html on mac-wk2

  • platform/mac-wk2/Skipped:
20:12 Changeset [111336] by slewis@apple.com

https://bugs.webkit.org/show_bug.cgi?id=81615
fast/parser/nested-fragment-parser-crash.html is failing on the lion bots

Unreviewed.

Check in new expected (failing?) results.

  • platform/mac/fast/parser/nested-fragment-parser-crash-expected.txt: Added.
20:10 Changeset [111335] by commit-queue@webkit.org

[chromium] Push culled tiles that are prepainted
https://bugs.webkit.org/show_bug.cgi?id=81552

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-19
Reviewed by Adrienne Walker.

Source/WebCore:

If a tile was culled during paint, but then prepainted in the following
idle paint pass, it was still marked as culled (and thus dirty) and not
pushed to the impl side.

Renames tile->m_updateCulled to tile->m_updated. This value is true if
the tile is updated any time during a commit, and remains false if it
is culled every time the layer is painted.

Unit test: TiledLayerChromiumTest.pushIdlePaintedOccludedTiles

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::UpdatableTile::isDirtyForCurrentFrame):
(UpdatableTile):
(WebCore::UpdatableTile::UpdatableTile):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::resetUpdateState):

Source/WebKit/chromium:

  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):
(WTF):

20:09 Changeset [111334] by slewis@apple.com

https://bugs.webkit.org/show_bug.cgi?id=81617 fast/repaint/canvas-putImageData.html fails on the Lion bots

Unreviewed.

Check in new expected (failing?) results.

  • platform/mac/fast/repaint/canvas-putImageData-expected.txt: Added.
  • platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/mac/transforms/3d/general/perspective-non-layer-expected.txt:
20:08 Changeset [111333] by keishi@webkit.org

[chromium] Rebaselining float-in-float-hit-testing and 056 in response
to r111281.

  • platform/chromium-mac/fast/block/float/float-in-float-hit-testing-expected.txt: Added.
  • platform/chromium-mac/fast/block/margin-collapse/056-expected.txt: Added.
20:05 Changeset [111332] by jberlin@webkit.org

A bunch of media tests failing on Lion Intel Debug WebKit1 and WebKit2 testers.
https://bugs.webkit.org/show_bug.cgi?id=81623

Rebaseline failing mac and mac-wk2 media tests.

  • platform/mac-wk2/media/no-auto-play-in-sandbox-expected.txt: Added.
  • platform/mac-wk2/media/video-playing-and-pause-expected.txt:
  • platform/mac/media/audio-controls-rendering-expected.png:
  • platform/mac/media/controls-after-reload-expected.png:
  • platform/mac/media/controls-after-reload-expected.txt:
  • platform/mac/media/controls-layout-direction-expected.png:
  • platform/mac/media/controls-strict-expected.png:
  • platform/mac/media/controls-strict-expected.txt:
  • platform/mac/media/media-controls-clone-expected.png:
  • platform/mac/media/video-colorspace-yuv420-expected.png: Added.
  • platform/mac/media/video-colorspace-yuv422-expected.png: Added.
  • platform/mac/media/video-controls-rendering-expected.png:
  • platform/mac/media/video-controls-rendering-expected.txt:
  • platform/mac/media/video-display-toggle-expected.png:
  • platform/mac/media/video-display-toggle-expected.txt:
  • platform/mac/media/video-layer-crash-expected.png:
  • platform/mac/media/video-no-audio-expected.png:
  • platform/mac/media/video-no-audio-expected.txt:
  • platform/mac/media/video-playing-and-pause-expected.png:
  • platform/mac/media/video-playing-and-pause-expected.txt:
  • platform/mac/media/video-size-intrinsic-scale-expected.txt: Added.
20:02 Changeset [111331] by andersca@apple.com

Fix Windows build.

  • FullscreenVideoController.cpp:

(FullscreenVideoController::LayerClient::platformCALayerDeviceScaleFactor):

19:57 Changeset [111330] by andersca@apple.com

Fix Snow Leopard build.

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::createTileLayer):

19:54 Changeset [111329] by jamesr@google.com

Unreviewed chromium compile fix - put all TRACE_*s in their own scope explicitly.

  • src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):

19:52 Changeset [111328] by timothy_horton@apple.com

[WK2] http/tests/security/contentSecurityPolicy/script-src-star-cross-scheme.html fails after r97360
https://bugs.webkit.org/show_bug.cgi?id=70245

Unreviewed; skip failing http/tests/security/contentSecurityPolicy/script-src-star-cross-scheme.html on mac-wk2.

  • platform/mac-wk2/Skipped:
19:48 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
19:47 Changeset [111327] by mrobinson@webkit.org

Merging r111316

19:47 Changeset [111326] by slewis@apple.com

https://bugs.webkit.org/show_bug.cgi?id=81610 fast/regions fail on Lion bots

Unreviewed.

Check in new expected (failing?) results.

  • platform/mac/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt:
  • platform/mac/fast/regions/overflow-size-change-with-stacking-context-expected.txt:
  • platform/mac/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt:
19:47 Changeset [111325] by mrobinson@webkit.org

Merging r110866

19:46 Changeset [111324] by mrobinson@webkit.org

Merging r110847

19:46 Changeset [111323] by mrobinson@webkit.org

Merging r110845

19:45 Changeset [111322] by mrobinson@webkit.org

Merging r110062

19:45 Changeset [111321] by tony@chromium.org

clean up gitignore
https://bugs.webkit.org/show_bug.cgi?id=81594

Reviewed by James Robinson.

  • .gitignore: .suo files are per-user files used by VS2010. .ninja

files are no longer generated in the tree-- they are generated in the
build directory.

19:45 Changeset [111320] by mrobinson@webkit.org

Merging r110060

19:44 Changeset [111319] by mrobinson@webkit.org

Merging r110059

19:44 Changeset [111318] by slewis@apple.com

https://bugs.webkit.org/show_bug.cgi?id=81608 fast/multicol/span/span-as-immediate… fail on Lion bots

Unreviewed.

Check in new expected (failing?) results.

  • platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
19:42 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
19:40 Changeset [111317] by timothy_horton@apple.com

[WK2] http/tests/navigation/https-in-page-cache.html times out on mac-wk2
https://bugs.webkit.org/show_bug.cgi?id=81622

Unreviewed; skip failing http/tests/navigation/https-in-page-cache.html on mac-wk2.

  • platform/mac-wk2/Skipped:
19:34 Changeset [111316] by mrobinson@webkit.org

Source/WebKit/gtk: [GTK] Allow running run-gtk-tests during 'make dist'
https://bugs.webkit.org/show_bug.cgi?id=81415

Reviewed by Philippe Normand.

  • GNUmakefile.am: Remove 'make check' rules from the makefile

Instead this functionality is now in the Tools makefile.

Tools: [GTK] Allow running run-gtk-tests during 'make distcheck'
https://bugs.webkit.org/show_bug.cgi?id=81415

Reviewed by Philippe Normand.

Modify the build and run-gtk-tests so that it can run during 'make distcheck'

  • GNUmakefile.am: Distribute run-gtk-tests during 'make dist' and make it the

main command run during 'make check.'

  • Scripts/run-gtk-tests: Refactored run-gtk-tests so that jhbuild is no longer

a requirement to run it. If jhbuild isn't around it will simply not start the
SPI daemons and skip the WebKit2 accessibility test. Remove test runs from the
main loop and simply use the main loop in a synchronous method to start SPI
daemons. Did a bunch of general cleanup around these tasks.

19:30 Changeset [111315] by timothy_horton@apple.com

[WK2] http/tests/navigation/anchor-frames-gbk.html fails
https://bugs.webkit.org/show_bug.cgi?id=76896
<rdar://problem/11078978>

Unreviewed; skip failing http/tests/navigation/anchor-frames-gbk.html on mac-wk2.

  • platform/mac-wk2/Skipped:
19:28 Changeset [111314] by commit-queue@webkit.org

[chromium] return true/false on GestureFlingCancel if a fling was stopped
https://bugs.webkit.org/show_bug.cgi?id=81563

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-19
Reviewed by James Robinson.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::gestureEvent):

19:27 Changeset [111313] by kubo@profusion.mobi

jhbuild: Use the multiprocessing module to get the number of CPUs.
https://bugs.webkit.org/show_bug.cgi?id=81585

Reviewed by Martin Robinson.

Now that support for Python 2.5 has been dropped, we can safely
use multiprocessing.cpu_count() to obtain the current number of
CPUs in the system instead of running a webkitperl script for
that.

  • efl/common.py:

(top_level_path):

  • efl/jhbuildrc:
  • gtk/common.py:

(build_path):

  • gtk/jhbuildrc:
19:25 Changeset [111312] by commit-queue@webkit.org

[chromium] Adding support for GL_EXT_discard_framebuffer.
https://bugs.webkit.org/show_bug.cgi?id=81383

Patch by Michal Mocny <mmocny@google.com> on 2012-03-19
Reviewed by James Robinson.

Source/Platform:

  • chromium/public/WebGraphicsContext3D.h:

(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::discardFramebufferEXT):
(WebKit::WebGraphicsContext3D::ensureFramebufferCHROMIUM):

Source/WebCore:

  • platform/graphics/chromium/Extensions3DChromium.h:

Source/WebKit/chromium:

  • src/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::discardFramebufferEXT):
(WebCore):
(WebCore::Extensions3DChromium::ensureFramebufferCHROMIUM):

  • src/GraphicsContext3DChromium.cpp:

(WebCore):

  • src/GraphicsContext3DPrivate.h:

(GraphicsContext3DPrivate):

  • tests/FakeWebGraphicsContext3D.h:

(WebKit::FakeWebGraphicsContext3D::discardFramebufferEXT):
(WebKit::FakeWebGraphicsContext3D::ensureFramebufferCHROMIUM):
(FakeWebGraphicsContext3D):

19:20 Changeset [111311] by ojan@chromium.org

We should only add a live event listener once, not once per TestSelector.
Adding one per TestSelector would cause accordion('option', 'active') to
incorrectly be "false" if you examine multiple sets of tests.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
19:19 Changeset [111310] by adamk@chromium.org

Refactor ContainerNode::replaceChild to match other mutation methods and share code
https://bugs.webkit.org/show_bug.cgi?id=81579

Reviewed by Ojan Vafai.

A future change will make use of the consistency among insertBefore/appendChild/replaceChild
to handle insertion of DocumentFragments more cleanly.

No new tests, no change in behavior.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::replaceChild): Use collectTargetNodes rather than walking through DocumentFragment children.
Insert before rather than inserting after. Dispatch to other methods to update parent/sibling pointers.
(WebCore::ContainerNode::appendChild): Call appendChildToContainer to update parent/sibling pointers.
(WebCore::ContainerNode::parserAddChild): Use type inference in call to appendChildToContainer.

19:19 Changeset [111309] by timothy_horton@apple.com

http/tests/misc/acid3.html fails on mac-lion-wk2
https://bugs.webkit.org/show_bug.cgi?id=81621
<rdar://problem/11078942>

Unreviewed; check in failing results for mac-wk2.

  • platform/mac-wk2/http/tests/misc/acid3-expected.png: Added.
  • platform/mac-wk2/http/tests/misc/acid3-expected.txt: Added.
19:15 Changeset [111308] by commit-queue@webkit.org

[chromium] Times in the cc should be expressed in seconds.
https://bugs.webkit.org/show_bug.cgi?id=80514

Patch by Ian Vollick <vollick@chromium.org> on 2012-03-19
Reviewed by James Robinson.

Source/WebCore:

Updated timer tests to use seconds.

  • platform/TouchFlingPlatformGestureCurve.h:

(TouchFlingPlatformGestureCurve):

  • platform/graphics/chromium/cc/CCActiveGestureAnimation.cpp:

(WebCore::CCActiveGestureAnimation::animate):

  • platform/graphics/chromium/cc/CCActiveGestureAnimation.h:

(CCActiveGestureAnimation):

  • platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp:

(WebCore::CCDelayBasedTimeSource::create):
(WebCore::CCDelayBasedTimeSource::CCDelayBasedTimeSource):
(WebCore::CCDelayBasedTimeSource::setActive):
(WebCore::CCDelayBasedTimeSource::onTimerFired):
(WebCore::CCDelayBasedTimeSource::monotonicallyIncreasingTime):
(WebCore):
(WebCore::CCDelayBasedTimeSource::postNextTickTask):

  • platform/graphics/chromium/cc/CCDelayBasedTimeSource.h:

(CCDelayBasedTimeSource):

  • platform/graphics/chromium/cc/CCGestureCurve.h:

(CCGestureCurve):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WTF):
(WebCore::CCThreadProxy::beginContextRecreation):
(WebCore::CCThreadProxy::tryToRecreateContext):
(WebCore::CCThreadProxy::initializeImplOnImplThread):

  • platform/graphics/chromium/cc/CCTimer.cpp:

(WebCore::CCTimer::startOneShot):

  • platform/graphics/chromium/cc/CCTimer.h:

(CCTimer):

Source/WebKit/chromium:

  • tests/CCDelayBasedTimeSourceTest.cpp:

(WebKitTests::TEST):

  • tests/CCFrameRateControllerTest.cpp:

(WebKitTests::TEST):

  • tests/CCSchedulerTestCommon.h:

(WebKitTests::FakeCCThread::pendingDelayMs):
(WebKitTests::FakeCCDelayBasedTimeSource::create):
(WebKitTests::FakeCCDelayBasedTimeSource::setMonotonicallyIncreasingTime):
(WebKitTests::FakeCCDelayBasedTimeSource::monotonicallyIncreasingTime):
(WebKitTests::FakeCCDelayBasedTimeSource::FakeCCDelayBasedTimeSource):
(FakeCCDelayBasedTimeSource):

  • tests/CCTimerTest.cpp:

(WebKitTests::TEST_F):

19:10 Changeset [111307] by dpranke@chromium.org

Fix typo introduced in r111293.

Unreviewed, build fix.

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitDriver._check_for_driver_crash):

19:09 Changeset [111306] by benjamin@webkit.org

Simplify SmallStrings
https://bugs.webkit.org/show_bug.cgi?id=81445

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-19
Reviewed by Gavin Barraclough.

SmallStrings had two methods that should not be public: count() and clear().

The method clear() is effectively replaced by finalizeSmallStrings(). The body
of the method was moved to the constructor since the code is obvious.

The method count() is unused.

  • runtime/SmallStrings.cpp:

(JSC::SmallStrings::SmallStrings):

  • runtime/SmallStrings.h:

(SmallStrings):

19:04 Changeset [111305] by timothy_horton@apple.com

[WK2] WebKitTestRunner needs to print frame load delegate information
https://bugs.webkit.org/show_bug.cgi?id=42705

Skip http/tests/loading/state-object-security-exception.html until WKTR prints frame load delegate information.

  • platform/wk2/Skipped:
19:04 Changeset [111304] by mrobinson@webkit.org

Merging r110999

19:01 Changeset [111303] by jberlin@webkit.org

fast/dom/Window/window-properties.html failing on Lion Intel Debug WebKit1 and WebKit2
testers.
https://bugs.webkit.org/show_bug.cgi?id=81612

Update the expected (failing?) results to get the bots green.

  • platform/mac/fast/dom/Window/window-properties-expected.txt:
19:01 Changeset [111302] by jberlin@webkit.org

fast/harness/page-cache-crash-on-data-urls.html and fast/harness/use-page-cache.html fail on
Lion Intel Debug WebKit2 testers.
https://bugs.webkit.org/show_bug.cgi?id=81616

Skip the flakey one and add expected failing results for the other.

  • platform/mac-wk2/fast/harness/use-page-cache-expected.txt: Added.
  • platform/wk2/Skipped:
19:00 Changeset [111301] by mrobinson@webkit.org

Merging r111110

18:52 Changeset [111300] by mrobinson@webkit.org

Merging 110762

18:51 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
18:45 Changeset [111299] by weinig@apple.com

Stop messing with the AppKit grow box on platforms that don't support it
<rdar://problem/10752048>
https://bugs.webkit.org/show_bug.cgi?id=81614

Reviewed by Dan Bernstein.

  • UIProcess/API/mac/WKView.mm:

(-[WKView viewWillMoveToWindow:]):
(-[WKView _didChangeScrollbarsForMainFrame]):
Snow Leopard was the last Mac OS to need a grow box.

18:45 Changeset [111298] by mrobinson@webkit.org

Merging r110478

18:41 Changeset [111297] by timothy_horton@apple.com

[WK2] Support layoutTestController.dumpProgressFinishedCallback() in WKTR
https://bugs.webkit.org/show_bug.cgi?id=81613

Unreviewed; skip http/tests/loading/progress-finished-callback.html on mac-wk2.

  • platform/mac-wk2/Skipped:
18:40 Changeset [111296] by mrobinson@webkit.org

Merging r111027

18:37 Changeset [111295] by mrobinson@webkit.org

Merging r110446

18:35 Changeset [111294] by mrobinson@webkit.org

Merging r110296

18:33 Changeset [111293] by dpranke@chromium.org

webkitpy: get ServerProcess out of the reportcrash business
https://bugs.webkit.org/show_bug.cgi?id=81600

Reviewed by Adam Barth.

ServerProcess was half-aware that ReportCrash might run
sometimes, and that the process ServerProcess was talking to
might have its own crashing subprocesses; neither of these
things really worked right and it made the logic convoluted, so
this change makes handling crashes completely separate from the
server_process code, so that it can focus on just I/O to the
subprocess.

There should be no functional changes resulting from this patch.

  • Scripts/webkitpy/layout_tests/port/server_process.py:

(ServerProcess._reset):
(ServerProcess._handle_possible_interrupt):
(ServerProcess.write):
(ServerProcess.read_stdout):
(ServerProcess.has_crashed):
(ServerProcess._read):
(ServerProcess.stop):

  • Scripts/webkitpy/layout_tests/port/server_process_unittest.py:

(TrivialMockPort.check_for_leaks):
(TestServerProcess.test_broken_pipe):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._read_image_diff):
(WebKitDriver.has_crashed):
(WebKitDriver._check_for_driver_crash):
(WebKitDriver.run_test):
(WebKitDriver._read_block):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(MockServerProcess.init):
(MockServerProcess):
(MockServerProcess.has_crashed):

18:29 Changeset [111292] by timothy_horton@apple.com

Unreviewed new mac baselines for fast/css/font-family-pictograph and fast/css/pseudo-first-line-border-width.

  • platform/mac/fast/css/font-family-pictograph-expected.png: Added.
  • platform/mac/fast/css/font-family-pictograph-expected.txt:
  • platform/mac/fast/css/pseudo-first-line-border-width-expected.png: Added.
  • platform/mac/fast/css/pseudo-first-line-border-width-expected.txt: Added.
18:28 Changeset [111291] by dpranke@chromium.org

webkitpy: crashlog parsing is broken
https://bugs.webkit.org/show_bug.cgi?id=81586

Reviewed by Adam Barth.

Seeking on a file opened through codecs() appears to not work
correctly (at least on SL).

The code was more complicated than it needed to be, so I have
revamped it to just read a full crashlog at once and then look
for matches.

I have also added the ability to optionally propagate
errors back (which can be helpful to debug races when ReportCrash is
still running and you need to see that you couldn't open some
files, rather than just ignoring them).

  • Scripts/webkitpy/common/system/crashlogs.py:

(CrashLogs.find_newest_log):
(CrashLogs._find_newest_log_darwin):

  • Scripts/webkitpy/common/system/crashlogs_unittest.py:

(CrashLogsTest.test_find_log_darwin):

18:28 Changeset [111290] by jberlin@webkit.org

fast/loader/window-properties-restored-from-page-cache.html timing out on Lion Intel Debug WebKit2 testers
https://bugs.webkit.org/show_bug.cgi?id=81609

Skip it to get the bots green.

  • platform/wk2/Skipped:
18:25 Changeset [111289] by dpranke@chromium.org

webkitpy: clean up some port._filesystem references to not reference private members
https://bugs.webkit.org/show_bug.cgi?id=81595

Reviewed by Eric Seidel.

There should be no functional changes in this patch, just some
refactoring. Also, fixes a minor nit in write_image_diff_files(()

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner.init):
(SingleTestRunner._run_compare_test):
(SingleTestRunner._run_rebaseline):
(SingleTestRunner._save_baseline_data):
(SingleTestRunner._handle_error):
(SingleTestRunner._run_reftest):

  • Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(write_test_result):
(TestResultWriter.init):
(TestResultWriter._make_output_directory):
(TestResultWriter.output_filename):
(TestResultWriter._output_testname):
(TestResultWriter.write_output_files):
(TestResultWriter.write_stderr):
(TestResultWriter.write_crash_report):
(TestResultWriter.create_text_diff_and_write_result):
(TestResultWriter.write_image_diff_files):
(copy_file):

  • Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:

(TestResultWriterTest.test_reftest_diff_image):

18:22 Changeset [111288] by dpranke@chromium.org

webkitpy: fix nit - incorrect reference to DRT in test_expectations.py
https://bugs.webkit.org/show_bug.cgi?id=81598

Reviewed by Eric Seidel.

"DumpRenderTree" shouldn't be hard-coded here, since some other
process may actually be crashing (WebKitTestRunner, WebProcess, etc.)

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations):

18:21 Changeset [111287] by dpranke@chromium.org

webkitpy: allow instance data in TestFailure objects
https://bugs.webkit.org/show_bug.cgi?id=81580

Reviewed by Tony Chang.

Current TestFailures are basically enums, but it would be nice,
especially for crashes, if they contained the name and pid of
the process that crashed.

  • Scripts/webkitpy/layout_tests/models/test_failures.py:

(TestFailure.message):
(FailureTimeout.message):
(FailureCrash):
(FailureCrash.init):
(FailureCrash.message):
(FailureMissingResult.message):
(FailureTextMismatch.message):
(FailureMissingImageHash.message):
(FailureMissingImage.message):
(FailureImageHashMismatch.message):
(FailureImageHashIncorrect.message):
(FailureReftestMismatch.message):
(FailureReftestMismatchDidNotOccur.message):
(FailureReftestNoImagesGenerated.message):
(FailureMissingAudio.message):
(FailureAudioMismatch.message):

  • Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:

(TestFailuresTest.test_equals):
(TestFailuresTest):
(TestFailuresTest.test_crashes):

18:16 Changeset [111286] by jberlin@webkit.org

A bunch of jquery tests are timing out on the Lion Intel Debug WebKit2 testers.
https://bugs.webkit.org/show_bug.cgi?id=81606

Skip them to get the bots green.

  • platform/wk2/Skipped:
18:13 Changeset [111285] by nduca@chromium.org

[chromium] Stop deriving WebCompositor from WebCompositorInputHandler
https://bugs.webkit.org/show_bug.cgi?id=80586

Reviewed by Darin Fisher.

  • public/WebCompositor.h:

(WebKit):

  • public/WebCompositorInputHandler.h:

(WebCompositorInputHandler):

  • public/WebWidgetClient.h:

(WebWidgetClient):
(WebKit::WebWidgetClient::didActivateCompositor):

  • src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandler::fromIdentifier):

  • src/WebCompositorInputHandlerImpl.h:

(WebCompositorInputHandlerImpl):

18:06 Changeset [111284] by jberlin@webkit.org

A bunch of media tests time out on the Lion Intel Debug WebKit1 and WebKit2 testers.
https://bugs.webkit.org/show_bug.cgi?id=81604

Skip them to get the bots green.

  • platform/mac/Skipped:
  • platform/wk2/Skipped:
18:02 Changeset [111283] by timothy_horton@apple.com

Unreviewed new mac baseline for compositing/repaint/become-overlay-composited-layer.html.

  • platform/mac/compositing/repaint/become-overlay-composited-layer-expected.png:
  • platform/mac/compositing/repaint/become-overlay-composited-layer-expected.txt:
17:53 Changeset [111282] by timothy_horton@apple.com

Unreviewed skip of canvas/philip/tests/2d.path.arc.scale.1.html as an addition to http://trac.webkit.org/changeset/111278

  • platform/mac/Skipped:
17:47 Changeset [111281] by timothy_horton@apple.com

Unreviewed mac baselines for some fast/block tests after http://trac.webkit.org/changeset/97596

  • platform/mac/fast/block/float/float-in-float-hit-testing-expected.png:
  • platform/mac/fast/block/float/float-in-float-hit-testing-expected.txt:
  • platform/mac/fast/block/margin-collapse/056-expected.txt:
17:40 Changeset [111280] by jberlin@webkit.org

A bunch of inspector tests time out on Lion Intel Debug WebKit2 testers.
https://bugs.webkit.org/show_bug.cgi?id=81601

Skip them on WK2 to get the bots green.

  • platform/wk2/Skipped:
17:37 Changeset [111279] by commit-queue@webkit.org

Relative-height block SVG root not layed out on container height change
https://bugs.webkit.org/show_bug.cgi?id=81513

Patch by Florin Malita <fmalita@google.com> on 2012-03-19
Reviewed by Dirk Schulze.

Source/WebCore:

Tests: svg/custom/svg-percent-scale-block-expected.html

svg/custom/svg-percent-scale-block.html

A couple of places still have style()->logical{Min,Max,}Height percent checks,
which do not work for SVG elements. This patch adds a virtual hasRelativeLogicalHeight()
RenderBox method to replace the explicit style checks.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlockChildren):
Use virtual hasRelativeLogicalHeight() instead of logical height style checks.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::hasRelativeLogicalHeight):
(WebCore):

  • rendering/RenderBox.h:

(RenderBox):
Add virtual hasRelativeLogicalHeight().

  • rendering/RenderView.cpp:

(WebCore::RenderView::layout):
Use virtual hasRelativeLogicalHeight() instead of logical height style checks, if possible.

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::hasRelativeLogicalHeight):
(WebCore):

  • rendering/svg/RenderSVGRoot.h:

(RenderSVGRoot):
Add hasRelativeLogicalHeight() override.

LayoutTests:

  • svg/custom/svg-percent-scale-block-expected.html: Added.
  • svg/custom/svg-percent-scale-block.html: Added.
17:33 Changeset [111278] by timothy_horton@apple.com

Four fast/canvas tests are flaky (fail on bots, not locally, or vice versa)
https://bugs.webkit.org/show_bug.cgi?id=81599
<rdar://problem/11078302>

Unreviewed skip of four flaky tests:

fast/canvas/canvas-createPattern-fillRect-shadow.html
fast/canvas/canvas-draw-canvas-on-canvas-shadow.html
fast/canvas/canvas-fillRect-gradient-shadow.html
fast/canvas/set-colors.html

  • platform/mac/Skipped:
17:20 Changeset [111277] by jer.noble@apple.com

Assertion failure in RenderBlock::addChildIgnoringAnonymousColumnBlocks when running fullscreen/full-screen-twice-crash.html
causing "crashes" on the Lion Intel Debug WebKit2 test bots.
https://bugs.webkit.org/show_bug.cgi?id=81171

Reviewed by Dan Bernstein.

No new tests; fixes fullscreen/* tests when running in WebKitTestRunner (WebKit2).

Add a special-case check if the parent anonymous container is a full screen renderer or placeholder.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):

17:12 Changeset [111276] by enrica@apple.com

WebKit2: create sandbox extensions for files that are dropped in an input control.
https://bugs.webkit.org/show_bug.cgi?id=81153
<rdar://problem/11031207>

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Now the pasteboard access is performed only in the UI process, it is
necessary to create sandbox extensions for each file that is dropped into
an input type=file element. The extensions are created at the time the files
are dropped and consumed immediately.

  • page/DragActions.h: Added new drag action to be used by the WebDragClient.
  • page/DragController.cpp:

(WebCore::DragController::concludeEditDrag): Added call to the drag client with the new action.

Source/WebKit/mac:

  • WebCoreSupport/WebDragClient.mm:

(WebDragClient::willPerformDragDestinationAction): Avoid calling the delegate with the new drag action.
We want to avoid any unwanted side effects for the WebKit clients.

Source/WebKit2:

Now the pasteboard access is performed only in the UI process, it is
necessary to create sandbox extensions for each file that is dropped into
an input type=file element. The extensions are created at the time the files
are dropped and consumed immediately.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::callMemberFunction): Added template that takes 8 arguments.

  • Shared/SandboxExtension.h:

(HandleArray): Added new class to handle an array of sandbox extension handles.
(WebKit::SandboxExtension::HandleArray::HandleArray):
(WebKit::SandboxExtension::HandleArray::~HandleArray):
(WebKit::SandboxExtension::HandleArray::resize):
(WebKit::SandboxExtension::HandleArray::operator[]):
(WebKit::SandboxExtension::HandleArray::size):
(WebKit::SandboxExtension::HandleArray::encode):
(WebKit::SandboxExtension::HandleArray::decode):

  • Shared/mac/SandboxExtensionMac.mm: Added new class implementation.

(WebKit::SandboxExtension::HandleArray::HandleArray):
(WebKit::SandboxExtension::HandleArray::~HandleArray):
(WebKit::SandboxExtension::HandleArray::resize):
(WebKit::SandboxExtension::HandleArray::operator[]):
(WebKit::SandboxExtension::HandleArray::size):
(WebKit::SandboxExtension::HandleArray::encode):
(WebKit::SandboxExtension::HandleArray::decode):

  • UIProcess/API/mac/WKView.mm:

(createSandboxExtensionsForFileUpload):
(-[WKView performDragOperation:]): Added logic to create the sandbox extensions for each
file/directory being dropped.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::dragEntered):
(WebKit::WebPageProxy::dragUpdated):
(WebKit::WebPageProxy::dragExited):
(WebKit::WebPageProxy::performDrag):
(WebKit::WebPageProxy::performDragControllerAction): Added the handle array parameter.

  • UIProcess/WebPageProxy.h:
  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::handleDropEvent):

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:
  • UIProcess/win/WebView.cpp:

(WebKit::WebView::Drop):

  • WebProcess/WebCoreSupport/WebDragClient.cpp:

(WebKit::WebDragClient::willPerformDragDestinationAction): Added handling of the new DragActionUpload.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::getPathnamesForType): Implemented using message to the UI process.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::performDragControllerAction):
(WebKit::WebPage::performUploadDragDestinationAction): Added method that consumes the received extensions.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
17:08 Changeset [111275] by eric@webkit.org

Fix Chromium Win
https://bugs.webkit.org/show_bug.cgi?id=81281

Unreviewed build fix.

  • platform/graphics/chromium/TransparencyWin.h:
17:02 Changeset [111274] by eric@webkit.org

Fix the chromium world.
https://bugs.webkit.org/show_bug.cgi?id=81281

Unreviewed build fix.

  • rendering/RenderThemeChromiumSkia.cpp:
16:59 Changeset [111273] by fpizlo@apple.com

DFG can no longer compile V8-v4/regexp in debug mode
https://bugs.webkit.org/show_bug.cgi?id=81592

Reviewed by Gavin Barraclough.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

16:59 Changeset [111272] by beidson@apple.com

<rdar://problem/10917120> and https://bugs.webkit.org/show_bug.cgi?id=81066
Crash in 3rd party WebKit apps under XHR/Cache code

Reviewed by Antti Koivisto.

Source/WebCore:

No new layout tests.
TestWebKitAPI test MemoryCachePruneWithinResourceLoadDelegate included

A CachedResource representing an XHR was being deleted by cache pruning during a delegate callback.
This worked until http://trac.webkit.org/changeset/98380

  • history/PageCache.cpp:

(WebCore::PageCache::releaseAutoreleasedPagesNow): Only trigger pruning after the page cache

autorelease if it was enabled before.

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::loadResource): Disable pruning before loading the resource and

re-enable it afterwards if necessary.

  • loader/cache/MemoryCache.h:

(WebCore::MemoryCache::pruneEnabled):

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.html: Added.
  • TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm: Added.

(-[MemoryCachePruneTestResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
(-[MemoryCachePruneTestResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
(-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
(-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
(TestWebKitAPI):
(TestWebKitAPI::TEST):

16:46 Changeset [111271] by andersca@apple.com

Fix Windows build.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::LayerClient::platformCALayerDeviceScaleFactor):

16:45 Changeset [111270] by jamesr@google.com

[chromium] Implement fling-by-wheel on compositor thread
https://bugs.webkit.org/show_bug.cgi?id=81462

Reviewed by Adrienne Walker.

Source/WebCore:

Adds compositor thread support for a fling type implemented as a sequence of wheel scrolls. Covered by new tests
in WebCompositorInputHandlerImplTests.

  • platform/graphics/chromium/cc/CCInputHandler.h:

(CCInputHandler):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::scheduleAnimation):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionDrawAndSwap):

Source/WebKit/chromium:

Implement fling-by-wheel and beef up existing unit test coverage considerably by using gmock instead of mocking
by hand.

  • src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::handleInputEvent):
(WebKit):
(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
(WebKit::WebCompositorInputHandlerImpl::animate):
(WebKit::WebCompositorInputHandlerImpl::cancelCurrentFling):
(WebKit::WebCompositorInputHandlerImpl::scrollBy):

  • src/WebCompositorInputHandlerImpl.h:

(WebCompositorInputHandlerImpl):

  • tests/WebCompositorInputHandlerImplTest.cpp:
16:36 Changeset [111269] by fpizlo@apple.com

Prediction propagation for UInt32ToNumber incorrectly assumes that outs outcome does not
change throughout the fixpoint
https://bugs.webkit.org/show_bug.cgi?id=81583

Reviewed by Michael Saboff.

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

16:33 Changeset [111268] by eae@chromium.org

Source/WebCore: [mac/chromium] Change platform code to use pixelSnappedRect methods
https://bugs.webkit.org/show_bug.cgi?id=81016

Reviewed by Eric Seidel.

Change platform code to use Node::getPixelSnappedRect,
pixelSnappedBoundingBoxRect and pixelSnappedAbsoluteClippedOverflowRect
to avoid exposing subpixel types to the platform layer.

No new tests.

  • WebCore.exp.in:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::pixelSnappedAbsoluteClippedOverflowRect):
Add pixelSnapped version of absoluteClippedOverflowRect

(WebCore):

  • rendering/RenderObject.h:

(RenderObject):

Source/WebKit/chromium: [mac/chromium] Change platform code to use pixelSnappedRect methods
https://bugs.webkit.org/show_bug.cgi?id=81016

Reviewed by Eric Seidel.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::computeBlockBounds):
(WebKit::WebViewImpl::applyAutofillSuggestions):
(WebKit::WebViewImpl::refreshAutofillPopup):

Source/WebKit/mac: [mac/chromium] Change platform code to use pixelSnappedRect methods
https://bugs.webkit.org/show_bug.cgi?id=81016

Reviewed by Eric Seidel.

  • Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView actualVisibleRectInWindow]):

  • WebView/WebFrame.mm:

(-[WebFrame _getVisibleRect:]):
(-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]):

  • WebView/WebView.mm:

(-[WebView _dashboardRegions]):
(-[WebView trackedRepaintRects]):

Source/WebKit/qt: [mac/qt/chromium] Change platform code to use pixelSnappedRect methods
https://bugs.webkit.org/show_bug.cgi?id=81016

Reviewed by Eric Seidel.

  • Api/qwebelement.cpp:

(QWebElement::geometry):
(QWebElement::render):

16:20 Changeset [111267] by beidson@apple.com

<rdar://problem/10848575> and https://bugs.webkit.org/show_bug.cgi?id=81516
REGRESSION (r107435) URLs copied from WebKit apps aren't in the right pasteboard format

Reviewed by Enrica Casucci.

Source/WebCore:

r107435 started saving/restoring URLs as strings.
We need to go back to setting the URL on the pasteboard using AppKit URL pasteboard APIs.

WebKit API test: ContextMenuCanCopyURL
No WebKit2 API test possible at this time.

  • platform/mac/PlatformPasteboardMac.mm:

(WebCore::PlatformPasteboard::setURL):

Tools:

Bring up a context menu on a link, copy the link, then verify the pasteboard contents
are in the correct format.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html: Added.
  • TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm: Added.

(-[ContextMenuCanCopyURLDelegate webView:didFinishLoadForFrame:]):
(TestWebKitAPI::contextMenuCopyLink):
(TestWebKitAPI::TEST):

16:14 PythonGuidelines edited by kubo@profusion.mobi
Python 2.6 is now the minimum supported version, see bug 71593 (diff)
16:11 Changeset [111266] by andersca@apple.com

Make the TileCache work with HiDPI again
https://bugs.webkit.org/show_bug.cgi?id=81569
<rdar://problem/11031542>

Reviewed by Sam Weinig.

Set the contentsScale of the individual tile layers to be the same as the device scale factor.
Also, take into account the fact that the value passed to TileCache::setScale is the product of the
page scale factor and the device scale factor, so divide it by the device scale factor before storing
it in m_scale.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::platformCALayerDeviceScaleFactor):
(WebCore):

  • platform/graphics/ca/GraphicsLayerCA.h:

(GraphicsLayerCA):

  • platform/graphics/ca/PlatformCALayerClient.h:

(PlatformCALayerClient):

  • platform/graphics/ca/mac/TileCache.h:

(TileCache):

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::TileCache):
(WebCore::TileCache::setScale):
(WebCore::TileCache::createTileLayer):

16:02 Changeset [111265] by jberlin@webkit.org

Shadow DOM is not enabled on Mac, so skip the whole directory instead of skipping the tests
one by one.

  • platform/mac/Skipped:
16:01 Changeset [111264] by fpizlo@apple.com

GC should not attempt to clear LLInt instruction inline caches for code blocks that are in
the process of being generated
https://bugs.webkit.org/show_bug.cgi?id=81565

Reviewed by Oliver Hunt.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finalizeUnconditionally):

15:53 Changeset [111263] by inferno@chromium.org

Crash due to layer tree information not updated when moving run-in children.
https://bugs.webkit.org/show_bug.cgi?id=81265

Reviewed by Julien Chaffraix.

Source/WebCore:

We need to do a full removal as the run-in child is getting inserted into
the neighbouring block and |blockRunIn| is going to be destroyed later
in the function.

Test: fast/runin/run-in-layer-not-removed-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::handleRunInChild):

LayoutTests:

  • fast/runin/run-in-layer-not-removed-crash-expected.txt: Added.
  • fast/runin/run-in-layer-not-removed-crash.html: Added.
15:52 Changeset [111262] by ojan@chromium.org

Make the selected item in the accordion a link to the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=81571

Reviewed by Dimitri Glazkov.

Also, make it so that you can select the text of the link, instead of the current behavior
of acting as if you had clicked on the accordion header.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
15:42 Changeset [111261] by dpranke@chromium.org

NRWT runs some tests that are skipped with -i command line option
https://bugs.webkit.org/show_bug.cgi?id=81535

Reviewed by Ojan Vafai.

This change modifies the interaction of Skipped files and
test_expectations files so that entries in Skipped files (and
the -i command line) override *everything* in the expectations
file.

Specifically, a directory in a Skipped file will cause all of
the tests in the dir to be skipped even if individual tests in
the dir are listed in the test_expectations.txt.

Skipped files also override anything in an overrides files.

This seems to make more intuitive sense, since if you list
something in the Skips file (and even more specify it on the
command line) you probably want it to be universally applied.

Theoretically we could add more precedence levels and have full
paths in an expectations file override dirs in a Skipped file
(but not the command line), but I don't know yet that that level
of complexity is justified.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations.init):
(TestExpectations._add_skipped_tests):
(TestExpectations._add_test):
(TestExpectations._add_expectations):
(TestExpectations._add_expectation_line):
(TestExpectations._already_seen_better_match):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(test_more_specific_override_resets_skip):
(SkippedTests):
(SkippedTests.get_exp):
(SkippedTests.assert_exp):
(SkippedTests.test_skipped_tests_work):
(SkippedTests.test_duplicate_skipped_test_fails_lint):
(SkippedTests.test_skipped_file_overrides_expectations):
(SkippedTests.test_skipped_dir_overrides_expectations):
(SkippedTests.test_skipped_file_overrides_overrides):
(SkippedTests.test_skipped_dir_overrides_overrides):

15:27 Changeset [111260] by commit-queue@webkit.org

[chromium] Remove misleading double-if
https://bugs.webkit.org/show_bug.cgi?id=81557

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-19
Reviewed by Adrienne Walker.

Simple code cleanup, no functionality change.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::prepareToUpdateTiles):

15:17 Changeset [111259] by commit-queue@webkit.org

[BlackBerry] speed up text selection for large selections
https://bugs.webkit.org/show_bug.cgi?id=81536

When selecting large disjoint areas of text the cost
of calculating the IntRectRegion union becomes very
expensive. Simply placing all of the text quads into
the IntRectRegion is faster despite the larger memory
footprint and the additional calculations at render
time.

Patch by Tyler Abbott <tabbott@rim.com> on 2012-03-19
Reviewed by Rob Buis.

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::getConsolidatedRegionOfTextQuadsForSelection):

15:16 Changeset [111258] by eric@webkit.org

Fix WTF header include discipline in Chromium WebKit
https://bugs.webkit.org/show_bug.cgi?id=81281

Reviewed by James Robinson.

Source/JavaScriptCore:

  • JavaScriptCore.gyp/JavaScriptCore.gyp:
  • wtf/unicode/icu/CollatorICU.cpp:

Source/WebCore:

I also fixed some bad include dicipline for other ports
as well. Those changes are not yet necessary for those ports
to keep building, but soon should be as those authors
remove all the extra WTF includes from WebCore and other non-WTF projects.

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:
  • bindings/scripts/test/CPP/WebDOMFloat64Array.cpp:
  • bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:
  • bindings/scripts/test/GObject/WebKitDOMFloat64ArrayPrivate.h:
  • bindings/scripts/test/ObjC/DOMFloat64Array.mm:
  • bindings/v8/NPV8Object.cpp:
  • bindings/v8/SerializedScriptValue.cpp:
  • bindings/v8/SerializedScriptValue.h:
  • bindings/v8/V8Binding.cpp:
  • bindings/v8/V8Binding.h:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8Utilities.cpp:
  • bindings/v8/custom/V8ArrayBufferCustom.cpp:
  • bindings/v8/custom/V8ArrayBufferViewCustom.h:
  • bindings/v8/custom/V8AudioContextCustom.cpp:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
  • bindings/v8/custom/V8Float32ArrayCustom.cpp:
  • bindings/v8/custom/V8Float64ArrayCustom.cpp:
  • bindings/v8/custom/V8Int16ArrayCustom.cpp:
  • bindings/v8/custom/V8Int32ArrayCustom.cpp:
  • bindings/v8/custom/V8Int8ArrayCustom.cpp:
  • bindings/v8/custom/V8MessagePortCustom.cpp:
  • bindings/v8/custom/V8Uint16ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint32ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint8ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp:
  • bindings/v8/custom/V8WorkerCustom.cpp:
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
  • bridge/qt/qt_runtime.cpp:
  • editing/gtk/FrameSelectionGtk.cpp:
  • loader/archive/mhtml/MHTMLArchive.cpp:
  • platform/ScrollAnimatorNone.cpp:
  • platform/blackberry/CookieMap.h:
  • platform/blackberry/CookieParser.h:
  • platform/blackberry/SSLKeyGeneratorBlackBerry.cpp:
  • platform/chromium/DragImageChromiumSkia.cpp:
  • platform/chromium/PlatformCursor.h:
  • platform/chromium/PlatformSupport.h:
  • platform/chromium/PopupMenuPrivate.h:
  • platform/chromium/TraceEvent.h:
  • platform/chromium/WidgetChromium.cpp:
  • platform/efl/RefPtrEfl.h:
  • platform/graphics/cairo/RefPtrCairo.h:
  • platform/graphics/chromium/RateLimiter.h:
  • platform/graphics/chromium/TiledLayerChromium.cpp:
  • platform/graphics/efl/IconEfl.cpp:
  • platform/graphics/gstreamer/GStreamerGWorld.h:
  • platform/graphics/gtk/IconGtk.cpp:
  • platform/graphics/skia/PlatformContextSkia.h:
  • platform/graphics/texmap/TextureMapperBackingStore.h:
  • platform/graphics/texmap/TextureMapperLayer.cpp:
  • platform/graphics/wx/TransformationMatrixWx.cpp:
  • platform/gtk/PlatformMouseEventGtk.cpp:
  • platform/leveldb/LevelDBSlice.h:
  • platform/mediastream/MediaStreamCenter.cpp:
  • platform/network/soup/SocketStreamHandleSoup.cpp:
  • platform/network/win/ResourceHandleWin.cpp:
  • platform/qt/RenderThemeQtMobile.cpp:
  • platform/wx/MouseEventWx.cpp:
  • platform/wx/wxcode/win/fontprops.cpp:

Source/WebKit/chromium:

  • src/CompositionUnderlineBuilder.h:
  • src/CompositionUnderlineVectorBuilder.h:
  • src/FrameLoaderClientImpl.cpp:
  • src/WebArrayBuffer.cpp:
  • src/WebArrayBufferView.cpp:
  • src/WebBindings.cpp:
  • src/WebColorName.cpp:
  • src/WebGeolocationClientMock.cpp:
  • src/WebPageSerializer.cpp:
  • src/WebSocketImpl.cpp:
  • src/WebViewImpl.cpp:
  • tests/FrameTestHelpers.cpp:

Tools:

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • Scripts/update-webkit-chromium: Made it possible to run this from a directory other than the root.
15:03 Changeset [111257] by lforschler@apple.com

Merged r111162.

15:03 Changeset [111256] by commit-queue@webkit.org

[BlackBerry] Add new layout test for text match marker
https://bugs.webkit.org/show_bug.cgi?id=81531

Tools:

Make the LayoutTestControllerBlackBerry::findString to test the
BlackBerry port implementation.

Patch by Andy Chen <andchen@rim.com> on 2012-03-19
Reviewed by Rob Buis.

  • DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:

(LayoutTestController::findString):

LayoutTests:

Patch by Andy Chen <andchen@rim.com> on 2012-03-19
Reviewed by Rob Buis.

Add a new layout test for text match marker for BlackBerry port

  • platform/blackberry/editing/text-iterator/findString-markers-expected.txt: Added.
  • platform/blackberry/editing/text-iterator/findString-markers.html: Added.
14:54 Changeset [111255] by jberlin@webkit.org

r109204 updated the chromium expected results for
inspector/timeline/timeline-animation-frame.html and timeline-paint.html, but did not update
the cross-platform results.

Update the cross-platform results.

  • inspector/timeline/timeline-animation-frame-expected.txt:
  • inspector/timeline/timeline-paint-expected.txt:
14:44 Changeset [111254] by fpizlo@apple.com

DFG NodeUse should be called Edge and NodeReferenceBlob should be called AdjacencyList
https://bugs.webkit.org/show_bug.cgi?id=81556

Rubber stamped by Gavin Barraclough.

  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • dfg/DFGAbstractState.h:

(JSC::DFG::AbstractState::forNode):

  • dfg/DFGAdjacencyList.h: Copied from Source/JavaScriptCore/dfg/DFGNodeReferenceBlob.h.

(JSC::DFG::AdjacencyList::AdjacencyList):
(JSC::DFG::AdjacencyList::child):
(JSC::DFG::AdjacencyList::setChild):
(JSC::DFG::AdjacencyList::child1):
(JSC::DFG::AdjacencyList::child2):
(JSC::DFG::AdjacencyList::child3):
(JSC::DFG::AdjacencyList::setChild1):
(JSC::DFG::AdjacencyList::setChild2):
(JSC::DFG::AdjacencyList::setChild3):
(JSC::DFG::AdjacencyList::child1Unchecked):
(JSC::DFG::AdjacencyList::initialize):
(AdjacencyList):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addVarArgChild):
(JSC::DFG::ByteCodeParser::processPhiStack):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::canonicalize):
(JSC::DFG::CSEPhase::performSubstitution):

  • dfg/DFGEdge.h: Copied from Source/JavaScriptCore/dfg/DFGNodeUse.h.

(DFG):
(JSC::DFG::Edge::Edge):
(JSC::DFG::Edge::operator==):
(JSC::DFG::Edge::operator!=):
(Edge):
(JSC::DFG::operator==):
(JSC::DFG::operator!=):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::operator[]):
(JSC::DFG::Graph::at):
(JSC::DFG::Graph::ref):
(JSC::DFG::Graph::deref):
(JSC::DFG::Graph::clearAndDerefChild1):
(JSC::DFG::Graph::clearAndDerefChild2):
(JSC::DFG::Graph::clearAndDerefChild3):
(Graph):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::getPrediction):

  • dfg/DFGNode.h:

(JSC::DFG::Node::Node):
(JSC::DFG::Node::child1):
(JSC::DFG::Node::child1Unchecked):
(JSC::DFG::Node::child2):
(JSC::DFG::Node::child3):
(Node):

  • dfg/DFGNodeFlags.cpp:

(JSC::DFG::arithNodeFlagsAsString):

  • dfg/DFGNodeFlags.h:

(DFG):
(JSC::DFG::nodeUsedAsNumber):

  • dfg/DFGNodeReferenceBlob.h: Removed.
  • dfg/DFGNodeUse.h: Removed.
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::mergeDefaultArithFlags):
(JSC::DFG::PredictionPropagationPhase::vote):
(JSC::DFG::PredictionPropagationPhase::fixupNode):

  • dfg/DFGScoreBoard.h:

(JSC::DFG::ScoreBoard::use):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::useChildren):
(JSC::DFG::SpeculativeJIT::writeBarrier):
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileStrictEqForConstant):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::at):
(JSC::DFG::SpeculativeJIT::canReuse):
(JSC::DFG::SpeculativeJIT::use):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
(JSC::DFG::IntegerOperand::IntegerOperand):
(JSC::DFG::DoubleOperand::DoubleOperand):
(JSC::DFG::JSValueOperand::JSValueOperand):
(JSC::DFG::StorageOperand::StorageOperand):
(JSC::DFG::SpeculateIntegerOperand::SpeculateIntegerOperand):
(JSC::DFG::SpeculateStrictInt32Operand::SpeculateStrictInt32Operand):
(JSC::DFG::SpeculateDoubleOperand::SpeculateDoubleOperand):
(JSC::DFG::SpeculateCellOperand::SpeculateCellOperand):
(JSC::DFG::SpeculateBooleanOperand::SpeculateBooleanOperand):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):

14:37 Changeset [111253] by commit-queue@webkit.org

[chromium] Invalidate/update evicted tiles during commit
https://bugs.webkit.org/show_bug.cgi?id=81529

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-19
Reviewed by Adrienne Walker.

Source/WebCore:

A previous change caused a regression where evicted (invalid) tiles
were no longer marked as dirty and updated. The regress was caused
in https://bugs.webkit.org/show_bug.cgi?id=81175 and is fixed here.

Unit test: TiledLayerChromiumTest.pushDeletedTiles

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::UpdatableTile::copyAndClearDirty):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):

Source/WebKit/chromium:

  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):
(WTF):

14:36 Changeset [111252] by eae@chromium.org

Revert unnecessary changes on branch.

14:35 Changeset [111251] by abarth@webkit.org

Remove PLATFORM(TORCHMOBILE) ifdef from MainResourceLoader.cpp
https://bugs.webkit.org/show_bug.cgi?id=81549

Reviewed by Eric Seidel.

This appears to be the only PLATFORM(TORCHMOBILE) ifdef in WebCore. I
don't believe this ifdef is needed anymore.

  • loader/MainResourceLoader.cpp:

(WebCore::shouldLoadAsEmptyDocument):
(WebCore):

14:34 Changeset [111250] by barraclough@apple.com

Object.freeze broken on latest Nightly
https://bugs.webkit.org/show_bug.cgi?id=80577

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • runtime/Arguments.cpp:

(JSC::Arguments::defineOwnProperty):

  • defineOwnProperty was checking for correct behaviour, provided that length/callee hadn't been overrridden. instead, just reify length/callee & rely on JSObject::defineOwnProperty.
  • runtime/JSFunction.cpp:

(JSC::JSFunction::defineOwnProperty):

  • for arguments/caller/length properties, defineOwnProperty was incorrectly asserting that the object must be extensible; this is incorrect since these properties should already exist on the object. In addition, it was asserting that the arguments/caller values must match the corresponding magic data properties, but for strict mode function this is incorrect. Instead, just reify the arguments/caller accessor & defer to JSObject::defineOwnProperty.

LayoutTests:

  • fast/js/preventExtensions-expected.txt:
  • fast/js/script-tests/preventExtensions.js:

(shouldBeTrue):
(shouldBeFalse.shouldBeFalse.preventExtensionsFreezeIsFrozen):

  • Added test cases.
14:30 Changeset [111249] by commit-queue@webkit.org

Unreviewed, rolling out r111207.
http://trac.webkit.org/changeset/111207
https://bugs.webkit.org/show_bug.cgi?id=81561

Causing chromium unit test failure (Requested by reveman on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-19

Source/Platform:

  • chromium/public/WebGraphicsContext3D.h:

Source/WebCore:

  • platform/graphics/chromium/Extensions3DChromium.h:

(Extensions3DChromium):

Source/WebKit/chromium:

  • src/Extensions3DChromium.cpp:
  • src/GraphicsContext3DChromium.cpp:

(WebCore):

  • src/GraphicsContext3DPrivate.h:

(GraphicsContext3DPrivate):

  • tests/FakeWebGraphicsContext3D.h:
14:30 Changeset [111248] by lforschler@apple.com

Versioning.

14:27 Changeset [111247] by tommyw@google.com

[chromium] MediaStream API (JSEP): Introducing WebMediaHints and WebIceOptions
https://bugs.webkit.org/show_bug.cgi?id=81341

Reviewed by Darin Fisher.

Simple WebKit representations of the WebCore/platform versions.

  • WebKit.gyp:
  • public/platform/WebICEOptions.h: Added.

(WebCore):
(WebKit):
(WebICEOptions):
(WebKit::WebICEOptions::WebICEOptions):
(WebKit::WebICEOptions::~WebICEOptions):
(WebKit::WebICEOptions::operator=):
(WebKit::WebICEOptions::isNull):

  • public/platform/WebMediaHints.h: Added.

(WebCore):
(WebKit):
(WebMediaHints):
(WebKit::WebMediaHints::WebMediaHints):
(WebKit::WebMediaHints::~WebMediaHints):
(WebKit::WebMediaHints::operator=):
(WebKit::WebMediaHints::isNull):

  • src/WebICEOptions.cpp: Added.

(WebKit):
(WebKit::WebICEOptions::WebICEOptions):
(WebKit::WebICEOptions::assign):
(WebKit::WebICEOptions::reset):
(WebKit::WebICEOptions::candidateTypeToUse):

  • src/WebMediaHints.cpp: Added.

(WebKit):
(WebKit::WebMediaHints::WebMediaHints):
(WebKit::WebMediaHints::assign):
(WebKit::WebMediaHints::reset):
(WebKit::WebMediaHints::audio):
(WebKit::WebMediaHints::video):

14:26 Changeset [111246] by jberlin@webkit.org

NPRuntime support for out-of-process plug-ins.
https://bugs.webkit.org/show_bug.cgi?id=48346

This issue was marked as fixed on 2011-01-11, but the tests that required that support were
never taken off the WK2 Skipped list.

Update the WK2 Skipped list to not skip the passing tests, and move the ones that still fail
to a separate section of the list.

  • platform/wk2/Skipped:
14:24 Changeset [111245] by andersca@apple.com

Remove unnecessary CALayer overrides from WebTileCacheLayer
https://bugs.webkit.org/show_bug.cgi?id=81562

Reviewed by Dan Bernstein.

  • platform/graphics/ca/mac/TileCache.h:

(TileCache):

  • platform/graphics/ca/mac/WebTileCacheLayer.mm:
14:18 Changeset [111244] by fpizlo@apple.com

LLInt get_by_pname slow path incorrectly assumes that the operands are not constants
https://bugs.webkit.org/show_bug.cgi?id=81559

Reviewed by Michael Saboff.

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

14:05 Changeset [111243] by eae@chromium.org

Correct usage of LayoutUnits in page code in preparation for turning on subpixel layout
https://bugs.webkit.org/show_bug.cgi?id=81538

Reviewed by Eric Seidel.

Fix usage of LayoutUnits and conversions between types in page code.

No new tests.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::innerHeight):
(WebCore::DOMWindow::innerWidth):
Explicitly cast long to int. InspectorInstrumentation requires a long and
FractionalLayoutUnit has no constructor that takes long.

  • page/EventHandler.cpp:

(WebCore::EventHandler::sendContextMenuEventForKey):
Pixel snap overflow rect as selection rects are integer based.

  • page/FrameView.cpp:

(WebCore::FrameView::scrollContentsFastPath):
Pixel snap repaint rects when computing update rect as all scrolling is
done on integer bounds.

  • page/GestureTapHighlighter.cpp:

Change rects vector to IntRect as addFocusRingRects operates on IntRects.

  • page/Page.cpp:

(WebCore::Page::addRelevantRepaintedObject):
(WebCore::Page::addRelevantUnpaintedObject):
Change paint methods to take a LayoutRect paint rect.

  • page/SpatialNavigation.cpp:

(WebCore::distanceDataForNode):
Change distance calculation to use floats instead of converting to float
at the end.

14:02 Changeset [111242] by lforschler@apple.com

Merged r110818.

14:00 Changeset [111241] by ojan@chromium.org

Don't show WONTFIX tests in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=81554

Reviewed by Dimitri Glazkov.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
13:59 Changeset [111240] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=81553

[New Multicolumn] Stub out classes to represent sets of column region boxes.

RenderRegionSet is an abstract class representing a set of contiguous anonymous
same-size regions.

RenderMultiColumnSet derives from RenderRegionSet and represents a set of contiguous
columns. It will also handle unique column behavior like column rule painting.

Eventually there will be a RenderPageSet derived class for printing/pages, but
that will come later after I finish rebuilding multi-column layout.

Reviewed by Dan Bernstein.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderMultiColumnSet.cpp: Added.

(WebCore):
(WebCore::RenderMultiColumnSet::RenderMultiColumnSet):
(WebCore::RenderMultiColumnSet::renderName):

  • rendering/RenderMultiColumnSet.h: Added.

(WebCore):
(RenderMultiColumnSet):

  • rendering/RenderRegionSet.cpp: Added.

(WebCore):
(WebCore::RenderRegionSet::RenderRegionSet):

  • rendering/RenderRegionSet.h: Added.

(WebCore):
(RenderRegionSet):

13:54 Changeset [111239] by commit-queue@webkit.org

Add playback state for AudioBufferSourceNode and add number of active nodes
https://bugs.webkit.org/show_bug.cgi?id=79701

Source/WebCore:

Add a playback state to AudioBufferSourceNode so that the user can
tell if the node is scheduled, playing, or finished.

For an AudioContext, add a count of the number of
AudioBufferSourceNode's that are active (playing audio).

Deleted m_isPlaying and m_hasFinished. For the record, m_isPlaying
is the same as a playbackState of SCHEDULED_STATE or PLAYING_STATE.
m_hasFinished is equivalent to a playbackState of FINISHED_STATE.

Patch by Raymond Toy <rtoy@google.com> on 2012-03-19
Reviewed by Chris Rogers.

Test: webaudio/audiobuffersource-playbackState.html

  • webaudio/AudioBufferSourceNode.cpp:

(WebCore):
(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
initialize playbackState, remove m_isPlaying, m_hasFinished.
(WebCore::AudioBufferSourceNode::process): Update playbackState
(WebCore::AudioBufferSourceNode::finish): Update playbackState
(WebCore::AudioBufferSourceNode::noteOn): Update playbackState
(WebCore::AudioBufferSourceNode::noteGrainOn): Update playbackState
(WebCore::AudioBufferSourceNode::noteOff): Use playbackState

  • webaudio/AudioBufferSourceNode.h:

(AudioBufferSourceNode): Define states, remove m_isPlaying, m_hasFinished.
(WebCore::AudioBufferSourceNode::playbackState): Added.

  • webaudio/AudioBufferSourceNode.idl: Define constants for the

playback state, add attribute playbackState.

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::activeSourceCount): Added.
(WebCore::AudioContext::incrementActiveSourceCount): Added.
(WebCore::AudioContext::decrementActiveSourceCount): Added.

  • webaudio/AudioContext.h:

(AudioContext):

  • webaudio/AudioContext.idl: Add attribute activeSourceCount.

LayoutTests:

Patch by Raymond Toy <rtoy@google.com> on 2012-03-19
Reviewed by Chris Rogers.

  • webaudio/audiobuffersource-playbackState-expected.txt: Added.
  • webaudio/audiobuffersource-playbackState.html: Added.
13:43 Changeset [111238] by lforschler@apple.com

New Branch.

13:43 Changeset [111237] by commit-queue@webkit.org

Unreviewed, rolling out r109014.
http://trac.webkit.org/changeset/109014
https://bugs.webkit.org/show_bug.cgi?id=81551

Causing crashes (Requested by inferno-sec on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-19

Source/WebCore:

  • rendering/style/RenderStyle.h:

LayoutTests:

  • css3/flexbox/inline-flexbox-expected.html: Removed.
  • css3/flexbox/inline-flexbox.html: Removed.
13:43 Changeset [111236] by lforschler@apple.com

Rollout 110818.

13:41 Changeset [111235] by ap@apple.com

Make WebFrameLoaderClient::createFrame more like WebKit1 version.
https://bugs.webkit.org/show_bug.cgi?id=81550

Covered by existing tests.

Reviewed by Jessie Berlin.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::createFrame):
13:39 Changeset [111234] by commit-queue@webkit.org

[BlackBerry] Implement OSAllocator::commit/decommit in the correct way
https://bugs.webkit.org/show_bug.cgi?id=77013

We should use mmap(PROT_NONE, MAP_LAZY) instead of posix_madvise() to
implement memory decommitting for QNX.

Patch by Yong Li <yoli@rim.com> on 2012-03-19
Reviewed by Rob Buis.

  • wtf/OSAllocatorPosix.cpp:

(WTF::OSAllocator::reserveUncommitted):
(WTF::OSAllocator::commit):
(WTF::OSAllocator::decommit):

13:29 Changeset [111233] by cfleizach@apple.com

platform/mac/accessibility/selected-rows-table.html failing on Lion Intel Debug WebKit2 testers
https://bugs.webkit.org/show_bug.cgi?id=81530

Reviewed by Jessie Berlin.

Tools:

Add rowAtIndex to WebKitTestRunner.

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR::AccessibilityUIElement::rowAtIndex):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:

(AccessibilityUIElement):

  • WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR):
(WTR::AccessibilityUIElement::rowAtIndex):

LayoutTests:

  • platform/mac-wk2/platform/mac/accessibility/selected-rows-table-expected.txt: Removed.
13:28 Changeset [111232] by jberlin@webkit.org

editing/input/reveal-edit-on-input-vertically.html and
editing/input/reveal-contenteditable-on-input-vertically.html timing out on Lion Intel Debug
WebKit2 testers

Add those tests to the WK2 Skipped list.

  • platform/wk2/Skipped:
13:26 Changeset [111231] by tony@chromium.org

Unreviewed, remove headers that no longer exist or moved in WebCore.gypi.

  • WebCore.gypi:
13:24 Changeset [111230] by eae@chromium.org

Fix type conversions on branch to match trunk.

13:24 Changeset [111229] by mihnea@adobe.com

[CSSRegions]Implement NamedFlow::contentNodes attribute
https://bugs.webkit.org/show_bug.cgi?id=80134

Reviewed by David Hyatt.

The named flow content nodes collection contains those nodes with webkitFlowInto property set to 'flow'.
In the list, the nodes are placed in document order. Nodes with display:none are also part of the list.
The list of nodes is returned as a static node list.

Source/WebCore:

Test: fast/regions/webkit-named-flow-content-nodes.html

  • dom/Document.cpp:

(WebCore::Document::webkitGetFlowByName):

  • dom/Document.h:
  • dom/Element.cpp:

(WebCore::Element::detach):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):

  • dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::contentNodes):
(WebCore):
(WebCore::WebKitNamedFlow::registerContentNode):

  • dom/WebKitNamedFlow.h:

(WebCore):
(WebKitNamedFlow):
(WebCore::WebKitNamedFlow::unregisterContentNode):

  • dom/WebKitNamedFlow.idl:

LayoutTests:

  • fast/regions/webkit-named-flow-content-nodes-expected.txt: Added.
  • fast/regions/webkit-named-flow-content-nodes.html: Added.
13:23 Changeset [111228] by ojan@chromium.org

Change garden-o-matic All Failures tab to Expected Failures
https://bugs.webkit.org/show_bug.cgi?id=81540

Reviewed by Dimitri Glazkov.

Also, fix some broken unittests that had just gotten stale.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
13:19 Changeset [111227] by commit-queue@webkit.org

ConvolverNode should not incur processing latency
https://bugs.webkit.org/show_bug.cgi?id=75564

Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-03-19
Reviewed by Chris Rogers.

Source/WebCore:

Add the DirectConvolver instead of FFTConvolver for the processing of the leading portion of impulse response.

  • WebCore.gypi:
  • platform/audio/DirectConvolver.cpp: Added.

(WebCore):
(WebCore::DirectConvolver::DirectConvolver):
(WebCore::DirectConvolver::process):
(WebCore::DirectConvolver::reset):

  • platform/audio/DirectConvolver.h: Added.

(WebCore):
(DirectConvolver):
(WebCore::DirectConvolver::convolveSize):

  • platform/audio/ReverbConvolver.cpp:

(WebCore::ReverbConvolver::ReverbConvolver):

  • platform/audio/ReverbConvolver.h:
  • platform/audio/ReverbConvolverStage.cpp:

(WebCore::ReverbConvolverStage::ReverbConvolverStage):
(WebCore::ReverbConvolverStage::process):
(WebCore::ReverbConvolverStage::reset):

  • platform/audio/ReverbConvolverStage.h:

(WebCore):
(ReverbConvolverStage):

LayoutTests:

No need to check the initial silent part because the latency issue of ConvolverNode is fixed.

  • webaudio/convolution-mono-mono-expected.txt:
  • webaudio/resources/convolution-testing.js:

(checkTriangularPulse):
(checkTail1):
(checkConvolvedResult.return.var):
(checkConvolvedResult):

13:13 Changeset [111226] by andersca@apple.com

Source/WebCore: Find in page highlights get out of place when scrolling
https://bugs.webkit.org/show_bug.cgi?id=81543

Reviewed by Sam Weinig.

Remove a now unused function from GraphicsLayer.

  • platform/graphics/GraphicsLayer.h:

(GraphicsLayer):

  • platform/graphics/ca/GraphicsLayerCA.h:

(GraphicsLayerCA):

Source/WebKit2: Find in page highlights get out of place when scrolling
https://bugs.webkit.org/show_bug.cgi?id=81543
<rdar://problem/10932590>

Reviewed by Sam Weinig.

When we have a page overlay layer, always force a full repaint of it whenever the page changes.
If this turns out to be a real performance problem (measurements suggest that it isn't), we could once
again try to figure out when a full page repaint is needed. Doing so could probably be more expensive than
simply repainting the page, given that a page overlay consists of a bunch of rect-fills mostly.

Also turn on accelerated drawing for the page overlay layer, since that cut CPU usage in half when scrolling
on a page that had a find overlay visible.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):

13:12 Changeset [111225] by jsbell@chromium.org

IndexedDB: Test cleanup - don't create transactions w/in transaction callback
https://bugs.webkit.org/show_bug.cgi?id=81532

The spec precludes creating transactions within a synchronous transaction callback;
for the current implementation, that's only the success callback for a setVersion()
call. This isn't enforced yet - see http://webkit.org/b/80547

Reviewed by Tony Chang.

  • storage/indexeddb/create-and-remove-object-store.html: Split out oncomplete handler.
  • storage/indexeddb/create-object-store-options.html: Split out oncomplete handler.
  • storage/indexeddb/factory-deletedatabase.html: Listen on complete event.
  • storage/indexeddb/mozilla/autoincrement-indexes.html: Split out oncomplete handler.
  • storage/indexeddb/mozilla/clear.html: Listen on complete event.
  • storage/indexeddb/mozilla/indexes.html: Split out oncomplete handler.
  • storage/indexeddb/mozilla/readonly-transactions.html: Split out oncomplete handler.
  • storage/indexeddb/mozilla/readwrite-transactions.html: Split out oncomplete handler.
  • storage/indexeddb/noblobs.html: Pass function reference, don't call function.
  • storage/indexeddb/objectstore-clear.html: Split out oncomplete handler.
  • storage/indexeddb/objectstore-removeobjectstore.html: Listen on complete event.
  • storage/indexeddb/transaction-abort-with-js-recursion-cross-frame.html: Split out oncomplete handler.
  • storage/indexeddb/transaction-abort-with-js-recursion.html: Split out oncomplete handler.
  • storage/indexeddb/transaction-crash-on-abort.html: Split out oncomplete handler.
  • storage/indexeddb/two-version-changes.html: Split out oncomplete handler.
13:09 Changeset [111224] by leviw@chromium.org

[Chromium] Marking fast/text/international/font-fallback-to-common-script.html as flaky for image
tests on all flavors of Chromium.

  • platform/chromium/test_expectations.txt:
12:59 Changeset [111223] by barraclough@apple.com

Unreviewed - revent a couple of files accidentally committed.

  • runtime/Arguments.cpp:

(JSC::Arguments::defineOwnProperty):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::defineOwnProperty):

12:58 Changeset [111222] by leviw@chromium.org

Marking css3/images/cross-fade-invalidation.html as flaky for image tests on Chromium Snowleopard.

  • platform/chromium/test_expectations.txt:
12:49 Changeset [111221] by jberlin@webkit.org

r98413 updated the platform/mac-wk2/plugins/contents-scale-factor test without updating the
expected results.

Update the expected results.

  • platform/mac-wk2/plugins/contents-scale-factor-expected.txt:
12:46 Changeset [111220] by commit-queue@webkit.org

[chromium] DRT crashes at shutdown.
https://bugs.webkit.org/show_bug.cgi?id=81504

Patch by Hao Zheng <zhenghao@chromium.org> on 2012-03-19
Reviewed by James Robinson.

WebCompositor must be destroyed after WebView is properly destroyed,
or some compositor objects like CCLayerTreeHost may not be destroyed.
However, it is really hard to make the destruction order correct
explicitly in ~TestShell. So move it out to DumpRenderTree.

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::~TestShell):

12:43 Changeset [111219] by andersca@apple.com

When Find overlay first appears and the page scrolls, the scrolling happens through a fade
https://bugs.webkit.org/show_bug.cgi?id=81539
<rdar://problem/11031093>

Reviewed by Dan Bernstein.

Disable implicit animations when adding the page overlay layer to its superlayer.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):

12:41 Changeset [111218] by leviw@chromium.org

[chromium] fast/events/touch/gesture/pad-gesture-fling.html fails on release builds
https://bugs.webkit.org/show_bug.cgi?id=81537

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-19

  • platform/chromium/test_expectations.txt:
12:28 Changeset [111217] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=81534

[New Multicolumn] Make the multi-column block re-layout its children when the column width/count change.
Cache the count/width on the multi-column block for easy access.

Reviewed by Antti Koivisto.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::recomputeLogicalWidth):
(WebCore::RenderBlock::layoutBlock):

  • rendering/RenderBlock.h:

Virtualize the code that recomputes the logical width for a block and sets relayoutChildren to true,
so that column code can subclass the method to also check for changes in the column width/count.

  • rendering/RenderMultiColumnBlock.cpp:

(WebCore::RenderMultiColumnBlock::computeColumnCountAndWidth):
The column count/width determination algorithm in one method on the RenderMultiColumnBlock. It's a copy
of the code from RenderBlock (which will be going away eventually).

(WebCore::RenderMultiColumnBlock::recomputeLogicalWidth):

  • rendering/RenderMultiColumnBlock.h:

(RenderMultiColumnBlock):
Subclassed method to also check for changes in the column width to set relayoutChildren to true.

12:19 Changeset [111216] by commit-queue@webkit.org

[chromium] Updating WebGraphicsContext3D MemoryAllocation callback to accept a struct with have backbuffer suggestion.
https://bugs.webkit.org/show_bug.cgi?id=81279

Patch by Michal Mocny <mmocny@google.com> on 2012-03-19
Reviewed by James Robinson.

Source/Platform:

Adding a suggestHaveBackbuffer hint to the WebGraphicsContext3D memory allocation callback.

  • chromium/public/WebGraphicsContext3D.h:

(WebGraphicsMemoryAllocationChangedCallbackCHROMIUM):
(WebKit::WebGraphicsContext3D::WebGraphicsMemoryAllocationChangedCallbackCHROMIUM::onMemoryAllocationChanged):

  • chromium/public/WebGraphicsMemoryAllocation.h: Added.

(WebKit):
(WebGraphicsMemoryAllocation):
(WebKit::WebGraphicsMemoryAllocation::WebGraphicsMemoryAllocation):

Source/WebCore:

  • platform/graphics/chromium/Extensions3DChromium.h:

(GpuMemoryAllocationCHROMIUM):
(WebCore::Extensions3DChromium::GpuMemoryAllocationCHROMIUM::GpuMemoryAllocationCHROMIUM):
(GpuMemoryAllocationChangedCallbackCHROMIUM):

Source/WebKit/chromium:

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GrMemoryAllocationChangedCallback::onGpuMemoryAllocationChanged):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::onMemoryAllocationChanged):
(GraphicsContext3DMemoryAllocationChangedCallbackAdapter):

12:14 Changeset [111215] by dpranke@chromium.org

add dpranke to webkitpy watchlist
https://bugs.webkit.org/show_bug.cgi?id=81433

Reviewed by Benjamin Poulain.

  • Scripts/webkitpy/common/config/watchlist:
12:11 Changeset [111214] by tony@chromium.org

flex-item-align: stretch should only grow, never shrink
https://bugs.webkit.org/show_bug.cgi?id=80882

Reviewed by Ojan Vafai.

Source/WebCore:

New test cases in css3/flexbox/flex-align-stretch.html.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::alignChildren): Move stretch code into a separate function.
(WebCore::RenderFlexibleBox::alignChildStretch): Add an early return if our height is shrinking.
(WebCore):

  • rendering/RenderFlexibleBox.h:

(RenderFlexibleBox):

LayoutTests:

  • css3/flexbox/child-overflow-expected.html:
  • css3/flexbox/child-overflow.html: For cases that overflow the height, we now just overflow rather than reducing the height.
  • css3/flexbox/flex-align-stretch-expected.txt:
  • css3/flexbox/flex-align-stretch.html: New test cases.
  • platform/chromium/test_expectations.txt: Mark as failing on Windows

because of mock scrollbar rendering bug.

12:08 Changeset [111213] by dpranke@chromium.org

test-webkitpy is failing on SL/Python 2.6.1
https://bugs.webkit.org/show_bug.cgi?id=81533

Reviewed by Ojan Vafai.

It appears that itertools.combinations() is buggy in 2.6.1; this
backports the implementation from 2.7.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py:

(TestConfigurationConverter.collapse_macros):
(TestConfigurationConverter):
(TestConfigurationConverter.combinations):

12:02 Changeset [111212] by vsevik@chromium.org

Web Inspector: Implement snippets evaluation.
https://bugs.webkit.org/show_bug.cgi?id=81334

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype.evaluateUsingTextPrompt):
(WebInspector.ConsoleView.prototype._enterKeyPressed):

  • inspector/front-end/ScriptMapping.js:

(WebInspector.MainScriptMapping):

  • inspector/front-end/SnippetsModel.js:
  • inspector/front-end/externs.js:

(WebInspector.evaluateInConsole):

  • inspector/front-end/inspector.js:

(WebInspector.evaluateInConsole):

LayoutTests:

  • inspector/debugger/snippets-model-expected.txt:
  • inspector/debugger/snippets-model.html:
11:39 Changeset [111211] by jsbell@chromium.org

IndexedDB: LayoutTests don't need explicit console div
https://bugs.webkit.org/show_bug.cgi?id=81370

Remove unneeded div and p tags (added by js-test-pre.js) and
unnecessary jsTestIsAsync = true (set by shared.js).

Reviewed by Tony Chang.

  • storage/indexeddb/basics-shared-workers.html:
  • storage/indexeddb/basics-workers.html:
  • storage/indexeddb/basics.html:
  • storage/indexeddb/constants.html:
  • storage/indexeddb/create-and-remove-object-store.html:
  • storage/indexeddb/create-object-store-options.html:
  • storage/indexeddb/createObjectStore-name-argument-required.html:
  • storage/indexeddb/createObjectStore-null-name.html:
  • storage/indexeddb/cursor-continue.html:
  • storage/indexeddb/cursor-delete.html:
  • storage/indexeddb/cursor-inconsistency.html:
  • storage/indexeddb/cursor-index-delete.html:
  • storage/indexeddb/cursor-key-order.html:
  • storage/indexeddb/cursor-primary-key-order.html:
  • storage/indexeddb/cursor-reverse-bug.html:
  • storage/indexeddb/cursor-skip-deleted.html:
  • storage/indexeddb/cursor-update-value-argument-required.html:
  • storage/indexeddb/cursor-update.html:
  • storage/indexeddb/data-corruption.html:
  • storage/indexeddb/database-basics.html:
  • storage/indexeddb/database-name-undefined.html:
  • storage/indexeddb/database-odd-names.html:
  • storage/indexeddb/database-quota.html:
  • storage/indexeddb/delete-closed-database-object.html:
  • storage/indexeddb/delete-range.html:
  • storage/indexeddb/deleteIndex.html:
  • storage/indexeddb/deleteObjectStore-name-argument-required.html:
  • storage/indexeddb/deleteObjectStore-null-name.html:
  • storage/indexeddb/duplicates.html:
  • storage/indexeddb/error-causes-abort-by-default.html:
  • storage/indexeddb/exception-in-event-aborts-expected.txt:
  • storage/indexeddb/exception-in-event-aborts.html:
  • storage/indexeddb/factory-basics.html:
  • storage/indexeddb/factory-cmp.html:
  • storage/indexeddb/factory-deletedatabase-interactions.html:
  • storage/indexeddb/factory-deletedatabase.html:
  • storage/indexeddb/index-basics-workers.html:
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/index-count.html:
  • storage/indexeddb/index-cursor.html:
  • storage/indexeddb/index-get-key-argument-required.html:
  • storage/indexeddb/index-multientry.html:
  • storage/indexeddb/index-population.html:
  • storage/indexeddb/index-unique.html:
  • storage/indexeddb/invalid-keys.html:
  • storage/indexeddb/key-generator.html:
  • storage/indexeddb/key-sort-order-across-types.html:
  • storage/indexeddb/key-sort-order-date.html:
  • storage/indexeddb/key-type-array.html:
  • storage/indexeddb/key-type-infinity.html:
  • storage/indexeddb/keypath-basics.html:
  • storage/indexeddb/keypath-edges.html:
  • storage/indexeddb/keypath-fetch-key.html:
  • storage/indexeddb/keyrange-required-arguments.html:
  • storage/indexeddb/keyrange.html:
  • storage/indexeddb/list-ordering-expected.txt:
  • storage/indexeddb/list-ordering.html:
  • storage/indexeddb/mozilla/add-twice-failure.html:
  • storage/indexeddb/mozilla/autoincrement-indexes.html:
  • storage/indexeddb/mozilla/bad-keypath.html:
  • storage/indexeddb/mozilla/clear.html:
  • storage/indexeddb/mozilla/create-index-unique.html:
  • storage/indexeddb/mozilla/create-index-with-integer-keys.html:
  • storage/indexeddb/mozilla/create-objectstore-basics.html:
  • storage/indexeddb/mozilla/create-objectstore-null-name.html:
  • storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html:
  • storage/indexeddb/mozilla/cursor-mutation.html:
  • storage/indexeddb/mozilla/cursor-update-updates-indexes.html:
  • storage/indexeddb/mozilla/cursors.html:
  • storage/indexeddb/mozilla/delete-result.html:
  • storage/indexeddb/mozilla/event-source.html:
  • storage/indexeddb/mozilla/global-data.html:
  • storage/indexeddb/mozilla/indexes.html:
  • storage/indexeddb/mozilla/key-requirements-delete-null-key.html:
  • storage/indexeddb/mozilla/key-requirements-inline-and-passed.html:
  • storage/indexeddb/mozilla/key-requirements-put-no-key.html:
  • storage/indexeddb/mozilla/key-requirements-put-null-key.html:
  • storage/indexeddb/mozilla/key-requirements.html:
  • storage/indexeddb/mozilla/object-cursors.html:
  • storage/indexeddb/mozilla/object-identity.html:
  • storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put.html:
  • storage/indexeddb/mozilla/object-store-remove-values.html:
  • storage/indexeddb/mozilla/objectstorenames.html:
  • storage/indexeddb/mozilla/odd-result-order.html:
  • storage/indexeddb/mozilla/open-database-null-name.html:
  • storage/indexeddb/mozilla/put-get-values.html:
  • storage/indexeddb/mozilla/readonly-transactions.html:
  • storage/indexeddb/mozilla/readwrite-transactions.html:
  • storage/indexeddb/mozilla/readyState.html:
  • storage/indexeddb/mozilla/remove-index.html:
  • storage/indexeddb/mozilla/remove-objectstore.html:
  • storage/indexeddb/mozilla/versionchange-abort.html:
  • storage/indexeddb/mozilla/versionchange.html:
  • storage/indexeddb/mutating-cursor.html:
  • storage/indexeddb/noblobs-expected.txt:
  • storage/indexeddb/noblobs.html:
  • storage/indexeddb/objectStore-required-arguments.html:
  • storage/indexeddb/objectstore-autoincrement.html:
  • storage/indexeddb/objectstore-basics-workers.html:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/objectstore-clear.html:
  • storage/indexeddb/objectstore-count.html:
  • storage/indexeddb/objectstore-cursor.html:
  • storage/indexeddb/objectstore-removeobjectstore.html:
  • storage/indexeddb/odd-strings.html:
  • storage/indexeddb/open-close-version.html:
  • storage/indexeddb/open-cursor.html:
  • storage/indexeddb/open-during-transaction.html:
  • storage/indexeddb/prefetch-bugfix-108071.html:
  • storage/indexeddb/queued-commands.html:
  • storage/indexeddb/readonly-properties.html:
  • storage/indexeddb/readonly.html:
  • storage/indexeddb/request-event-propagation.html:
  • storage/indexeddb/setVersion-null.html:
  • storage/indexeddb/setVersion-undefined.html:
  • storage/indexeddb/set_version_blocked.html:
  • storage/indexeddb/set_version_queue.html:
  • storage/indexeddb/structured-clone-expected.txt:
  • storage/indexeddb/structured-clone.html:
  • storage/indexeddb/transaction-abort-with-js-recursion-cross-frame.html:
  • storage/indexeddb/transaction-abort-with-js-recursion.html:
  • storage/indexeddb/transaction-abort-workers.html:
  • storage/indexeddb/transaction-abort.html:
  • storage/indexeddb/transaction-after-close.html:
  • storage/indexeddb/transaction-and-objectstore-calls.html:
  • storage/indexeddb/transaction-basics.html:
  • storage/indexeddb/transaction-crash-on-abort.html:
  • storage/indexeddb/transaction-event-propagation.html:
  • storage/indexeddb/transaction-read-only.html:
  • storage/indexeddb/transaction-rollback.html:
  • storage/indexeddb/transaction-storeNames-required.html:
  • storage/indexeddb/two-version-changes.html:
  • storage/indexeddb/value-undefined.html:
  • storage/indexeddb/values-odd-types.html:
  • storage/indexeddb/version-change-abort-expected.txt:
  • storage/indexeddb/version-change-abort.html:
  • storage/indexeddb/version-change-exclusive.html:
  • storage/indexeddb/versionchangerequest-activedomobject.html:
11:36 Changeset [111210] by jberlin@webkit.org

platform/mac/accessibility/selected-rows-table.html failing on Lion Intel Debug WebKit2 testers
https://bugs.webkit.org/show_bug.cgi?id=81530

Add expected failing results for mac-wk2 to get the bots green.

  • platform/mac-wk2/platform/mac/accessibility/selected-rows-table-expected.txt: Added.
11:36 Changeset [111209] by commit-queue@webkit.org

[BlackBerry] Use BlackBerry::Platform::DeviceInfo to generate UserAgent
https://bugs.webkit.org/show_bug.cgi?id=81269

Generate the UserAgent lazily, using it as the default for the
WebSettings object. BlackBerry::Platform::DeviceInfo is used
to ensure the information is accurate to the specific device.

Remove the !isEmpty() assert when fetching the UA from the
WebSettings object, as it will now always be properly initialized.

Add a static initializer block to ensure defaultUserAgent() is
thread-safe from that moment onward.

Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-03-19
Reviewed by Rob Buis.

  • Api/WebPage.cpp:

(WebKit):
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPagePrivate::defaultUserAgent):

  • Api/WebPage_p.h:

(WebPagePrivate):

  • Api/WebSettings.cpp:

(BlackBerry::WebKit::WebSettings::setUserAgentString):

  • Api/WebSettings.h:
11:33 Changeset [111208] by tommyw@google.com

MediaStream API (JSEP): Introducing PeerConnection00Handler
https://bugs.webkit.org/show_bug.cgi?id=81333

Reviewed by Adam Barth.

In preparation of the last WebCore patch that will introduce PeerConnection00 here's its platform representation.

Not possible to test until the entire JSEP feature is commited.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • platform/mediastream/PeerConnection00Handler.cpp: Added.

(WebCore):
(WebCore::PeerConnection00Handler::create):
(WebCore::PeerConnection00Handler::PeerConnection00Handler):
(WebCore::PeerConnection00Handler::~PeerConnection00Handler):
(WebCore::PeerConnection00Handler::createOffer):
(WebCore::PeerConnection00Handler::createAnswer):
(WebCore::PeerConnection00Handler::setLocalDescription):
(WebCore::PeerConnection00Handler::setRemoteDescription):
(WebCore::PeerConnection00Handler::localDescription):
(WebCore::PeerConnection00Handler::remoteDescription):
(WebCore::PeerConnection00Handler::startIce):
(WebCore::PeerConnection00Handler::processIceMessage):
(WebCore::PeerConnection00Handler::addStream):
(WebCore::PeerConnection00Handler::removeStream):
(WebCore::PeerConnection00Handler::stop):

  • platform/mediastream/PeerConnection00Handler.h: Added.

(WebCore):
(PeerConnection00Handler):

  • platform/mediastream/PeerConnection00HandlerClient.h: Added.

(WebCore):
(PeerConnection00HandlerClient):
(WebCore::PeerConnection00HandlerClient::~PeerConnection00HandlerClient):

11:27 Changeset [111207] by commit-queue@webkit.org

[Chromium] GL_EXT_occlusion_query_boolean and GL_CHROMIUM_command_buffer_query support.
https://bugs.webkit.org/show_bug.cgi?id=80988

Patch by David Reveman <reveman@chromium.org> on 2012-03-19
Reviewed by Adrienne Walker.

Source/Platform:

Add EXT_occlusion_query API to WebGraphicsContext3D.

  • chromium/public/WebGraphicsContext3D.h:

(WebGraphicsContext3D):

Source/WebCore:

Expose EXT_occlusion_query API to WebKit compositor. Add
GL_EXT_occlusion_query_boolean and GL_CHROMIUM_command_buffer_query
enums.

  • platform/graphics/chromium/Extensions3DChromium.h:

(Extensions3DChromium):

Source/WebKit/chromium:

Expose EXT_occlusion_query API to WebKit compositor.

  • src/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::createQueryEXT):
(WebCore):
(WebCore::Extensions3DChromium::deleteQueryEXT):
(WebCore::Extensions3DChromium::isQueryEXT):
(WebCore::Extensions3DChromium::beginQueryEXT):
(WebCore::Extensions3DChromium::endQueryEXT):
(WebCore::Extensions3DChromium::getQueryivEXT):
(WebCore::Extensions3DChromium::getQueryObjectuivEXT):

  • src/GraphicsContext3DChromium.cpp:

(WebCore):

  • src/GraphicsContext3DPrivate.h:

(GraphicsContext3DPrivate):

  • tests/FakeWebGraphicsContext3D.h:

(WebKit::FakeWebGraphicsContext3D::createQueryEXT):
(WebKit::FakeWebGraphicsContext3D::deleteQueryEXT):
(WebKit::FakeWebGraphicsContext3D::isQueryEXT):
(WebKit::FakeWebGraphicsContext3D::beginQueryEXT):
(WebKit::FakeWebGraphicsContext3D::endQueryEXT):
(WebKit::FakeWebGraphicsContext3D::getQueryivEXT):
(WebKit::FakeWebGraphicsContext3D::getQueryObjectuivEXT):
(FakeWebGraphicsContext3D):

11:16 Changeset [111206] by mifenton@rim.com

[BlackBerry] Input fields with id of e-mail and url should be styled as such.
https://bugs.webkit.org/show_bug.cgi?id=81364

Reviewed by Rob Buis.

Be less aggressive on matching url, and update as suggested by Rob.

  • WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::matchesReservedStringUrl):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::inputStyle):

11:02 Changeset [111205] by mikelawther@chromium.org

CSS3 calc: make mask images work with mixed percent/absolute
https://bugs.webkit.org/show_bug.cgi?id=81477

Reviewed by Ojan Vafai.

Source/WebCore:

Test: css3/calc/simple-composited-mask-expected.html

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

LayoutTests:

  • css3/calc/simple-composited-mask-expected.html: Renamed from LayoutTests/css3/calc/simple-composited-mask-expected-mismatch.html.
10:52 Changeset [111204] by abarth@webkit.org

Optimize the cleanup sequence in the start-queue.sh script
https://github.com/abarth/webkit/pull/1

Patch by David Michael Barr <davidbarr@google.com> on 2012-03-19
Reviewed by Adam Barth.

Updating the working copy is an expensive operation
for a repository the size of WebKit.
Attempt to reset only to the target revision.

  • EWSTools/start-queue.sh:
10:46 Changeset [111203] by commit-queue@webkit.org

Style cleanup in Modules/filesystem/
https://bugs.webkit.org/show_bug.cgi?id=81520

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-03-19
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • Modules/filesystem/AsyncFileWriter.h:

(WebCore::AsyncFileWriter::~AsyncFileWriter):

  • Modules/filesystem/AsyncFileWriterClient.h:

(WebCore::AsyncFileWriterClient::~AsyncFileWriterClient):

  • Modules/filesystem/DOMFilePath.cpp:

(WebCore::DOMFilePath::getDirectory):

  • Modules/filesystem/DOMFilePath.h:

(DOMFilePath):

  • Modules/filesystem/DOMFileSystemBase.h:

(DOMFileSystemBase):

  • Modules/filesystem/DirectoryEntry.h:
  • Modules/filesystem/DirectoryEntrySync.h:
  • Modules/filesystem/EntryArray.h:

(EntryArray):

  • Modules/filesystem/FileEntry.h:

(FileEntry):

  • Modules/filesystem/FileSystemCallbacks.h:

(FileSystemCallbacksBase):

  • Modules/filesystem/FileWriter.cpp:

(WebCore::FileWriter::abort):

10:37 Changeset [111202] by andersca@apple.com

Crash when closing an inspected web page with tiled drawing enabled
https://bugs.webkit.org/show_bug.cgi?id=81524
<rdar://problem/11062396>

Reviewed by Sam Weinig.

Guard against the WebPage's underlying WebCore Page being null, which can happen
when the inspector highlight overlay is uninstalled by the inspector when the inspected
page goes away.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::didUninstallPageOverlay):

10:37 Changeset [111201] by ap@apple.com

FAILED: m_loadState == LoadStateProvisional on http/tests/multipart/load-last-non-html-frame.php
https://bugs.webkit.org/show_bug.cgi?id=81365

  • platform/wk2/Skipped: Skipped the test.
10:34 Changeset [111200] by mikelawther@chromium.org

CSS3 calc: background positioning works with mixed percent/absolute expressions
https://bugs.webkit.org/show_bug.cgi?id=81478

Reviewed by Ojan Vafai.

Source/WebCore:

Test: css3/calc/background-position-parsing-expected.html

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

LayoutTests:

  • css3/calc/background-position-parsing-expected.html: Renamed from LayoutTests/css3/calc/background-position-parsing-expected-mismatch.html.
10:10 Changeset [111199] by kenneth@webkit.org

Merge _q_commitScaleChange and _q_commitPositionChange
https://bugs.webkit.org/show_bug.cgi?id=81511

Reviewed by Simon Hausmann.

Both methods were used for notifying WebCore of the new
viewport and re-tiling. The methods are merge into
_q_contentViewportChanged.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebViewFlickablePrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::_q_contentViewportChanged):
(QQuickWebViewFlickablePrivate::_q_resume):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate::_q_contentViewportChanged):
(QQuickWebViewFlickablePrivate):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::ViewportUpdateDeferrer::~ViewportUpdateDeferrer):
(WebKit::QtViewportInteractionEngine::flickableMovingPositionUpdate):
(WebKit::QtViewportInteractionEngine::wheelEvent):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):

  • UIProcess/qt/QtViewportInteractionEngine.h:

(QtViewportInteractionEngine):

10:09 Changeset [111198] by ahf@0x90.dk

Add NodeRenderStyle.h to TouchAdjustment.cpp

Unreviewed build fix after r111185.

  • page/TouchAdjustment.cpp:
09:57 Changeset [111197] by jberlin@webkit.org

Another Windows build fix after r111129.

09:53 Changeset [111196] by commit-queue@webkit.org

[chromium] Unit test fix, save the sharedQuadState while the quads hold a pointer to it
https://bugs.webkit.org/show_bug.cgi?id=81476

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-19
Reviewed by Adrienne Walker.

  • tests/CCQuadCullerTest.cpp:

(WebCore::appendQuads):
(WebCore):
(WebCore::TEST):

09:48 Changeset [111195] by kubo@profusion.mobi

Cross-platform processor core counter: fix build on FreeBSD.
https://bugs.webkit.org/show_bug.cgi?id=81482

Reviewed by Zoltan Herczeg.

The documentation of sysctl(3) shows that <sys/types.h> should be
included before <sys/sysctl.h> (sys/types.h tends to be the first
included header in general).

This should fix the build on FreeBSD and other systems where
sysctl.h really depends on types defined in types.h.

  • wtf/NumberOfCores.cpp:
09:46 Changeset [111194] by leo.yang@torchmobile.com.cn

[BlackBerry] Add PlatformMediaEngineClassName for blackberry in platform/graphics/MediaPlayer.cpp
https://bugs.webkit.org/show_bug.cgi?id=81489

Reviewed by Rob Buis.

  • platform/graphics/MediaPlayer.cpp:
09:43 Changeset [111193] by kubo@profusion.mobi

Adjust architecture type of the EFL build bot.
https://bugs.webkit.org/show_bug.cgi?id=81452

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2012-03-19
Reviewed by Tony Chang.

  • BuildSlaveSupport/build.webkit.org-config/config.json: The

buildslave is a 64-bit machine, therefore describe it as being
x86_64, not i386.

09:37 Changeset [111192] by mitz@apple.com

Set the svn:ignore property on the Xcode project.

  • WTF.xcodeproj: Added property svn:ignore.
09:23 Changeset [111191] by leo.yang@torchmobile.com.cn

[BlackBerry] Upstream the BlackBerry change to platform/PlatformKeyboardEvent.h
https://bugs.webkit.org/show_bug.cgi?id=81312

Reviewed by Rob Buis.

  • platform/PlatformKeyboardEvent.h:

(Platform):
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
(PlatformKeyboardEvent):
(WebCore::PlatformKeyboardEvent::unmodifiedCharacter):
Add BlackBerry specific constructor and member fields.

  • platform/blackberry/PlatformKeyboardEventBlackBerry.cpp:

(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
Change the parameter type to const reference type to adapt to the declaration.

09:22 Changeset [111190] by ahf@0x90.dk

[Qt] printLoadedUrls prints "Object" instead of the actual URL. https://bugs.webkit.org/show_bug.cgi?id=81514

Reviewed by Simon Hausmann.

  • MiniBrowser/qt/qml/BrowserWindow.qml:
09:21 Changeset [111189] by leviw@chromium.org

[chromium] Rebaselining fixed-position-scroll now that more bots have come in.

  • platform/chromium-mac-snowleopard/compositing/layer-creation: Removed.
  • platform/chromium-mac-snowleopard/compositing/layer-creation/fixed-position-scroll-expected.png: Removed.
  • platform/chromium-mac-snowleopard/compositing/layer-creation/fixed-position-scroll-expected.txt: Removed.
  • platform/chromium-mac/compositing/layer-creation/fixed-position-scroll-expected.png: Added.
  • platform/chromium-win/compositing/layer-creation/fixed-position-scroll-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/fixed-position-scroll-expected.txt: Added.
09:18 Changeset [111188] by jberlin@webkit.org

Windows build fix after r111129.

09:07 Changeset [111187] by kubo@profusion.mobi

[EFL] jhbuild: Set CMAKE_PREFIX_PATH in jhbuildrc.
https://bugs.webkit.org/show_bug.cgi?id=81491

Reviewed by Philippe Normand.

For the find_path(), find_library() etc CMake calls to find the
dependencies built with jhbuild, CMAKE_PREFIX_PATH must be properly
set, otherwise CMake cannot know the dependencies exist and will only
look in the standard directories.

  • efl/jhbuildrc: Set the CMAKE_PREFIX_PATH environment variable with

the jhbuild Root directory.

09:05 Changeset [111186] by kubo@profusion.mobi

[EFL] Add XDG env vars to jhbuildrc
https://bugs.webkit.org/show_bug.cgi?id=81510

Needed to ensure correct glib behaviour in jhbuild environment.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-03-19
Reviewed by Philippe Normand.

  • efl/jhbuildrc:
08:33 Changeset [111185] by commit-queue@webkit.org

Select best target for tap gesture.
https://bugs.webkit.org/show_bug.cgi?id=78801

Source/WebCore:

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-19
Reviewed by Kenneth Rohde Christiansen.
IntRect changes reviewed by Dave Hyatt.

The new API is available through EventHandler::bestClickableNodeForTouchPoint, but
implementation details have been placed in page/TouchAdjustment.

The default hit detection is performed by measuring the distance to the center
lines of the absolute rects of the hit nodes. Absolute rects are used instead
of bounding rects to make hit-detecting against links over line breaks. Distance
to center line is used to make it easier to hit small links next to large links.
For line-rects the distance to the center-line is a better expression of the distance
to a rectangles center than the distance to the center-point.

Tests: touchadjustment/event-triggered-widgets.html

touchadjustment/html-label.html
touchadjustment/nested-touch.html
touchadjustment/touch-inlines.html

  • Target.pri:
  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureTap):
(WebCore::EventHandler::bestClickableNodeForTouchPoint):

  • page/EventHandler.h:
  • page/TouchAdjustment.cpp: Added.

(WebCore::TouchAdjustment::QuadForHitTest::QuadForHitTest):
(WebCore::TouchAdjustment::QuadForHitTest::node):
(WebCore::TouchAdjustment::QuadForHitTest::quad):
(WebCore::TouchAdjustment::QuadForHitTest::boundingBox):
(WebCore::TouchAdjustment::nodeRespondsToTapGesture):
(WebCore::TouchAdjustment::appendAbsoluteQuadsForNodeToHitTestList):
(WebCore::TouchAdjustment::compileQuadsForHitTesting):
(WebCore::TouchAdjustment::distanceSquaredToQuadCenterLine):
(WebCore::TouchAdjustment::findNodeWithLowestMetric):
(WebCore::findBestClickableCandidate):

  • page/TouchAdjustment.h: Added.
  • platform/graphics/FloatQuad.h:

(WebCore::FloatQuad::center):

  • platform/graphics/IntPoint.h:

(WebCore::IntPoint::distanceSquaredToPoint):

  • platform/graphics/IntRect.cpp:

(WebCore::distanceToInterval):
(WebCore::IntRect::differenceToPoint):
(WebCore::IntRect::differenceFromCenterLineToPoint):

  • platform/graphics/IntRect.h:

(WebCore::IntRect::distanceSquaredToPoint):
(WebCore::IntRect::distanceSquaredFromCenterLineToPoint):

  • platform/graphics/IntSize.h:

(WebCore::IntSize::diagonalLengthSquared):

  • testing/Internals.cpp:

(WebCore::Internals::touchPositionAdjustedToBestClickableNode):
(WebCore::Internals::touchNodeAdjustedToBestClickableNode):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-19
Reviewed by Kenneth Rohde Christiansen.

Send radius to handlePotentialSingleTapEvent so it can do the same hit
detection the tap gesture later does.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::handlePotentialActivation):

  • UIProcess/WebPageProxy.h:
  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::handlePotentialSingleTapEvent):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::highlightPotentialActivation):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

Tools:

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-19
Reviewed by Kenneth Rohde Christiansen.

Add TOUCH_ADJUSTMENT to enabled features.

  • qmake/mkspecs/features/features.prf:

LayoutTests:

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-19
Reviewed by Kenneth Rohde Christiansen.

Test of touch adjustments. Tests several both normal and tricky cases.

  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/win/Skipped:
  • touchadjustment/event-triggered-widgets-expected.txt: Added.
  • touchadjustment/event-triggered-widgets.html: Added.
  • touchadjustment/html-label-expected.txt: Added.
  • touchadjustment/html-label.html: Added.
  • touchadjustment/nested-touch-expected.txt: Added.
  • touchadjustment/nested-touch.html: Added.
  • touchadjustment/touch-inlines-expected.txt: Added.
  • touchadjustment/touch-inlines.html: Added.
08:11 Changeset [111184] by commit-queue@webkit.org

Add ENABLED(FILE_SYSTEM) to DOMFilePath.h
https://bugs.webkit.org/show_bug.cgi?id=81393

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-03-19
Reviewed by Kentaro Hara.

No new tests, all existing tests pass.

  • Modules/filesystem/DOMFilePath.h:
07:54 Changeset [111183] by commit-queue@webkit.org

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-19

  • DEPS:
07:51 Changeset [111182] by commit-queue@webkit.org

[chromium] synthesize wheel events for fling on main thread
https://bugs.webkit.org/show_bug.cgi?id=81458

Source/WebKit/chromium:

Support track pad fling by generating a sequence of wheel events.

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-19
Reviewed by James Robinson.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::scrollBy): Call-back from PlatformGestureCurve to dispatch wheel event.
(WebKit):
(WebKit::WebViewImpl::gestureEvent): Handle GestureFlingStart and GestureFlingCancel.
(WebKit::WebViewImpl::updateAnimations): Requests a PlatformGestureCurve to animate forward.
(WebKit::WebViewImpl::didCommitLoad): Halt flings on navigations.

  • src/WebViewImpl.h:

(WebCore):
(WebViewImpl):

Tools:

Added the ability to dispatch GestureFlingStart and GestureFlingCancel from EventSender.

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-19
Reviewed by James Robinson.

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::EventSender):
(EventSender::gestureFlingCancel):
(EventSender::gestureFlingStart):

  • DumpRenderTree/chromium/EventSender.h:

(EventSender):

LayoutTests:

Show that the GestureFlingStart and GestureFlingEnd events are handled and
connect up with WebViewImpl

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-19
Reviewed by James Robinson.

  • fast/events/touch/gesture/pad-gesture-cancel-expected.txt: Added.
  • fast/events/touch/gesture/pad-gesture-cancel.html: Added.
  • fast/events/touch/gesture/pad-gesture-cancel.js: Added.

(recordWheelEvent):
(if):

  • fast/events/touch/gesture/pad-gesture-fling-expected.txt: Added.
  • fast/events/touch/gesture/pad-gesture-fling.html: Added.
  • fast/events/touch/gesture/pad-gesture-fling.js: Added.

(recordWheelEvent):
(if):

  • platform/chromium/fast/events/touch/gesture/pad-gesture-cancel-expected.txt: Added.
  • platform/chromium/fast/events/touch/gesture/pad-gesture-fling-expected.txt: Added.
07:47 Changeset [111181] by kkristof@inf.u-szeged.hu

[Qt] Unreviewed. Add new platform specific expectation after r110667.

  • platform/qt-4.8/fast/dom/Window/window-properties-expected.png: Added.
  • platform/qt-4.8/fast/dom/Window/window-properties-expected.txt: Added.
07:45 Changeset [111180] by commit-queue@webkit.org

[BlackBerry] Remove obsolete optimization in WebPageCompositorPrivate
https://bugs.webkit.org/show_bug.cgi?id=81115

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-03-19
Reviewed by Benjamin Poulain.

The compositor tried to avoid rendering the same stuff twice, using a
mechanism that didn't work properly and has been redundant since we
introduced deferred blits. Remove this code.

Reviewed internally by Robin Cao.

  • Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::commit):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):

  • Api/WebPageCompositor_p.h:
07:42 Changeset [111179] by ahf@0x90.dk

[Qt] Add command line option to set the user agent in the MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=81508

Reviewed by Simon Hausmann.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::webViewExperimental):

  • MiniBrowser/qt/BrowserWindow.h:

(BrowserWindow):

  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(printHelp):
(MiniBrowserApplication::handleUserOptions):

  • MiniBrowser/qt/MiniBrowserApplication.h:

(WindowOptions::WindowOptions):
(WindowOptions::setUserAgent):
(WindowOptions::userAgent):
(WindowOptions):

07:42 Changeset [111178] by ahf@0x90.dk

[Qt] Add experimental API for dynamically changing the UA string

Reviewed by Simon Hausmann.

This patch adds a new property named userAgent to the
QQuickWebViewExperimental type which allows us to dynamically change
the user agent string from the QML API.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewExperimental::userAgent):
(QQuickWebViewExperimental::setUserAgent):

  • UIProcess/API/qt/qquickwebview_p.h:
07:41 Changeset [111177] by ahf@0x90.dk

[Qt] Remove dead user agent code from the MiniBrowser.

Reviewed by Simon Hausmann.

  • MiniBrowser/qt/BrowserWindow.cpp:
  • MiniBrowser/qt/BrowserWindow.h:

(BrowserWindow):

  • MiniBrowser/qt/MiniBrowser.qrc:
  • MiniBrowser/qt/useragentlist.txt: Removed.
07:38 Changeset [111176] by commit-queue@webkit.org

inspector highlight of SVG root element with viewbox does not match dimensions of element
https://bugs.webkit.org/show_bug.cgi?id=78037

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-03-19
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Functions such as RenderBox::absoluteQuads and DOMNodeHighlighter::getOrDrawNodeHighlight
eventually call RenderSVGRoot::mapLocalToContainer, passing along local CSS box coordinates.

However, before this patch, RenderSVGRoot::mapLocalToContainer expected local SVG viewport
coordinates. This caused the inspector highlight to be incorrectly sized and positioned.

Now, RenderSVGRoot::mapLocalToContainer expects local CSS box coordinates, like other HTML
renderers.

Test: inspector/elements/highlight-svg-root.html

  • dom/Element.cpp:

(WebCore::Element::getBoundingClientRect):

Now, the SVG root element can use the code path for elements with CSS boxes to calculate
its bounding client rect.

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::mapLocalToContainer):

RenderSVGRoot::mapLocalToContainer no longer needs to apply the
localToBorderBoxTransform to convert from local SVG viewport coordinates to local CSS
box coordinates. Now, it receives local CSS box coordinates.

  • rendering/svg/RenderSVGRoot.h:

(WebCore::RenderSVGRoot::localToBorderBoxTransform):

RenderSVGRoot::localToBorderBoxTransform has been exposed for child elements in the SVG
namespace to use when mapping from local SVG viewport coordinates to local CSS box
coordinates.

(RenderSVGRoot):

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::mapLocalToContainer):

Elements in the SVG namespace should now apply the localToBorderBoxTransform at the
SVG/HTML boundary (aka RenderSVGRoot) when mapping their coordinates up the render tree.

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::localCoordinateSpaceTransform):

Same as above. This method is eventually used in the SVGLocatable::getScreenCTM
calculation.

LayoutTests:

  • inspector/elements/highlight-svg-root-expected.txt: Added.
  • inspector/elements/highlight-svg-root.html: Added.
07:35 Changeset [111175] by kubo@profusion.mobi

jhbuild: Call jhbuild's autogen.sh via bash.
https://bugs.webkit.org/show_bug.cgi?id=81485

Reviewed by Philippe Normand.

jhbuild's autogen.sh uses "/bin/bash" in the shebang line, however
this is usually true only on Linux systems, and even then bash for
some reason might not be available in that location. It is safer to
call bash directly and pass autogen.sh to it instead.

  • jhbuild/jhbuild-wrapper:

(install_jhbuild):

07:30 Changeset [111174] by commit-queue@webkit.org

[GTK] Prefix run-launcher with run-with-jhbuild
https://bugs.webkit.org/show_bug.cgi?id=81503

Patch by Philippe Normand <pnormand@igalia.com> on 2012-03-19
Reviewed by Hajime Morita.

  • Scripts/run-launcher:
03:47 Changeset [111173] by keishi@webkit.org

[chromium] Adding slow to full-screen-restrictions.html on WIN.

  • platform/chromium/test_expectations.txt:
03:47 Changeset [111172] by commit-queue@webkit.org

[EFL] Prefix run-launcher with run-with-jhbuild
https://bugs.webkit.org/show_bug.cgi?id=80026

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-03-19
Reviewed by Hajime Morita.

  • Scripts/run-launcher:
03:34 Changeset [111171] by hbono@chromium.org

Add a copy constructor to CollapsedBorderValue
https://bugs.webkit.org/show_bug.cgi?id=81502

Reviewed by Hajime Morita.

Due to the lack of this copy constructor, GCC (x86) creates a broken copy
constructor and it causes a build break on Google Chrome.

  • rendering/style/CollapsedBorderValue.h:

(WebCore::CollapsedBorderValue::CollapsedBorderValue):
(CollapsedBorderValue):

02:56 Changeset [111170] by ossy@webkit.org

[Qt] Gardening.

Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-03-19
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped: Skip a new failing test, remove a non-existent test, order entries.
  • platform/qt/fast/events/resize-events-expected.png: Added.
  • platform/qt/fast/events/resize-events-expected.txt: Added.
02:48 Changeset [111169] by keishi@webkit.org

[chromium] Rebaseline due to r111139

  • platform/chromium-linux-x86/fast/table/max-width-integer-overflow-expected.png: Added.
  • platform/chromium-linux-x86/fast/table/max-width-integer-overflow-expected.txt: Added.
  • platform/chromium-linux/fast/table/max-width-integer-overflow-expected.png: Added.
  • platform/chromium-linux/fast/table/max-width-integer-overflow-expected.txt: Added.
  • platform/chromium-win-xp/fast/table/max-width-integer-overflow-expected.png: Added.
02:10 Changeset [111168] by keishi@webkit.org

[chromium] Rebaseline due to r111156

  • platform/chromium-win/fast/borders/border-radius-huge-assert-expected.png:
01:59 Changeset [111167] by leviw@chromium.org

Unreviewed gardening. Adding missing cr-snowleopard layer creation expectations.

  • platform/chromium-mac-snowleopard/compositing/layer-creation: Added.
  • platform/chromium-mac-snowleopard/compositing/layer-creation/fixed-position-scroll-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/layer-creation/fixed-position-scroll-expected.txt: Added.
01:49 Changeset [111166] by philn@webkit.org

Unreviewed, GTK rebaseline after r110759 and r108185.

  • platform/gtk/editing/inserting/before-after-input-element-expected.txt:
  • platform/gtk/editing/pasteboard/4806874-expected.txt:
  • platform/gtk/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/gtk/editing/pasteboard/input-field-1-expected.txt:
  • platform/gtk/editing/selection/3690703-2-expected.txt:
  • platform/gtk/editing/selection/3690703-expected.txt:
  • platform/gtk/editing/selection/3690719-expected.txt:
  • platform/gtk/editing/selection/4895428-3-expected.txt:
  • platform/gtk/editing/selection/4975120-expected.txt:
  • platform/gtk/editing/selection/drag-select-1-expected.txt:
  • platform/gtk/editing/selection/expanding-selections-expected.txt:
  • platform/gtk/editing/selection/leave-requested-block-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-2-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-3-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/gtk/fast/block/float/032-expected.txt:
  • platform/gtk/fast/block/float/033-expected.txt: Added.
  • platform/gtk/fast/block/float/avoidance-rtl-expected.txt: Added.
  • platform/gtk/fast/block/float/float-not-removed-from-next-sibling3-expected.txt:
  • platform/gtk/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt:
  • platform/gtk/fast/block/float/in-margin-expected.txt:
  • platform/gtk/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt:
  • platform/gtk/fast/block/float/shrink-to-avoid-float-complexity-expected.txt:
  • platform/gtk/fast/block/lineboxcontain/block-font-expected.txt:
  • platform/gtk/fast/block/lineboxcontain/block-glyphs-expected.txt:
  • platform/gtk/fast/block/lineboxcontain/font-expected.txt:
  • platform/gtk/fast/block/lineboxcontain/parsing-invalid-expected.txt:
  • platform/gtk/fast/block/margin-collapse/103-expected.txt:
  • platform/gtk/fast/box-shadow/shadow-buffer-partial-expected.txt:
  • platform/gtk/fast/clip/017-expected.txt:
  • platform/gtk/fast/css/input-search-padding-expected.txt:
  • platform/gtk/fast/css/invalidation-errors-2-expected.txt:
  • platform/gtk/fast/css/invalidation-errors-expected.txt:
  • platform/gtk/fast/css/line-height-expected.txt:
  • platform/gtk/fast/css/nested-layers-with-hover-expected.txt:
  • platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/gtk/fast/css/text-overflow-input-expected.txt:
  • platform/gtk/fast/dom/isindex-001-expected.txt:
  • platform/gtk/fast/dom/isindex-002-expected.txt:
  • platform/gtk/fast/dynamic/subtree-boundary-percent-height-expected.txt:
  • platform/gtk/fast/dynamic/subtree-no-common-root-static-y-expected.txt:
  • platform/gtk/fast/dynamic/subtree-table-cell-height-expected.txt:
  • platform/gtk/fast/encoding/utf-16-big-endian-expected.txt:
  • platform/gtk/fast/encoding/utf-16-little-endian-expected.txt:
  • platform/gtk/fast/events/autoscroll-expected.txt:
  • platform/gtk/fast/events/context-no-deselect-expected.txt:
  • platform/gtk/fast/events/mouse-relative-position-expected.txt: Added.
  • platform/gtk/fast/forms/basic-inputs-expected.txt:
  • platform/gtk/fast/forms/box-shadow-override-expected.txt:
  • platform/gtk/fast/forms/encoding-test-expected.txt:
  • platform/gtk/fast/forms/fieldset-align-expected.txt:
  • platform/gtk/fast/forms/floating-textfield-relayout-expected.txt:
  • platform/gtk/fast/forms/form-element-geometry-expected.txt:
  • platform/gtk/fast/forms/input-align-expected.txt:
  • platform/gtk/fast/forms/input-appearance-bkcolor-expected.txt:
  • platform/gtk/fast/forms/input-appearance-default-bkcolor-expected.txt:
  • platform/gtk/fast/forms/input-appearance-disabled-expected.txt:
  • platform/gtk/fast/forms/input-appearance-focus-expected.txt:
  • platform/gtk/fast/forms/input-appearance-height-expected.txt:
  • platform/gtk/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/gtk/fast/forms/input-appearance-readonly-expected.txt:
  • platform/gtk/fast/forms/input-appearance-selection-expected.txt:
  • platform/gtk/fast/forms/input-appearance-visibility-expected.txt:
  • platform/gtk/fast/forms/input-appearance-width-expected.txt:
  • platform/gtk/fast/forms/input-baseline-expected.txt:
  • platform/gtk/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/gtk/fast/forms/input-field-text-truncated-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/gtk/fast/forms/input-readonly-empty-expected.txt:
  • platform/gtk/fast/forms/input-spaces-expected.txt:
  • platform/gtk/fast/forms/input-table-expected.txt:
  • platform/gtk/fast/forms/input-text-click-inside-expected.txt:
  • platform/gtk/fast/forms/input-text-click-outside-expected.txt:
  • platform/gtk/fast/forms/input-text-option-delete-expected.txt:
  • platform/gtk/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/gtk/fast/forms/input-value-expected.txt:
  • platform/gtk/fast/forms/input-width-expected.txt:
  • platform/gtk/fast/forms/number/input-appearance-number-rtl-expected.txt:
  • platform/gtk/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/gtk/fast/forms/number/input-appearance-spinbutton-layer-expected.txt:
  • platform/gtk/fast/forms/placeholder-position-expected.txt:
  • platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/gtk/fast/forms/search-rtl-expected.txt:
  • platform/gtk/fast/forms/search-styled-expected.txt:
  • platform/gtk/fast/forms/search-vertical-alignment-expected.txt:
  • platform/gtk/fast/forms/searchfield-heights-expected.txt:
  • platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/gtk/fast/forms/text-style-color-expected.txt:
  • platform/gtk/fast/forms/textfield-focus-ring-expected.txt:
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/gtk/fast/html/details-no-summary4-expected.txt:
  • platform/gtk/fast/html/details-open-javascript-expected.txt:
  • platform/gtk/fast/html/details-open2-expected.txt:
  • platform/gtk/fast/html/details-open4-expected.txt:
  • platform/gtk/fast/inline/continuation-outlines-with-layers-2-expected.txt:
  • platform/gtk/fast/inline/continuation-outlines-with-layers-expected.txt:
  • platform/gtk/fast/invalid/residual-style-expected.txt:
  • platform/gtk/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
  • platform/gtk/fast/layers/remove-layer-with-nested-stacking-expected.txt:
  • platform/gtk/fast/layers/self-painting-outline-expected.txt: Added.
  • platform/gtk/fast/lists/dynamic-marker-crash-expected.txt:
  • platform/gtk/fast/multicol/layers-split-across-columns-expected.txt:
  • platform/gtk/fast/overflow/004-expected.txt:
  • platform/gtk/fast/overflow/clip-rects-fixed-ancestor-expected.txt:
  • platform/gtk/fast/overflow/line-clamp-expected.txt:
  • platform/gtk/fast/overflow/overflow-focus-ring-expected.txt:
  • platform/gtk/fast/repaint/iframe-scroll-repaint-expected.txt:
  • platform/gtk/fast/repaint/inline-relative-positioned-expected.txt:
  • platform/gtk/fast/repaint/layer-outline-expected.txt:
  • platform/gtk/fast/repaint/layer-outline-horizontal-expected.txt:
  • platform/gtk/fast/repaint/lines-with-layout-delta-expected.txt:
  • platform/gtk/fast/repaint/opacity-change-on-overflow-float-expected.txt:
  • platform/gtk/fast/repaint/overflow-clip-subtree-layout-expected.txt: Added.
  • platform/gtk/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/gtk/fast/repaint/repaint-resized-overflow-expected.txt:
  • platform/gtk/fast/repaint/search-field-cancel-expected.txt:
  • platform/gtk/fast/repaint/subtree-layoutstate-transform-expected.txt:
  • platform/gtk/fast/repaint/subtree-root-clip-2-expected.txt: Added.
  • platform/gtk/fast/repaint/subtree-root-clip-3-expected.txt: Added.
  • platform/gtk/fast/repaint/subtree-root-clip-expected.txt: Added.
  • platform/gtk/fast/repaint/subtree-root-skipped-expected.txt:
  • platform/gtk/fast/repaint/transform-absolute-in-positioned-container-expected.txt:
  • platform/gtk/fast/replaced/replaced-breaking-expected.txt:
  • platform/gtk/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/gtk/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/gtk/fast/replaced/width100percent-textfield-expected.txt:
  • platform/gtk/fast/table/003-expected.txt:
  • platform/gtk/fast/table/029-expected.txt:
  • platform/gtk/fast/table/colspanMinWidth-expected.txt:
  • platform/gtk/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/gtk/fast/table/overflowHidden-expected.txt:
  • platform/gtk/fast/table/spanOverlapRepaint-expected.txt:
  • platform/gtk/fast/table/text-field-baseline-expected.txt:
  • platform/gtk/fast/text/selection-painted-separately-expected.txt:
  • platform/gtk/fast/text/selection-rect-rounding-expected.txt:
  • platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/gtk/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/gtk/plugins/mouse-click-plugin-clears-selection-expected.txt:
  • platform/gtk/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/gtk/svg/hixie/mixed/003-expected.txt:
  • platform/gtk/tables/mozilla/bugs/45621-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug12384-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug154780-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug24200-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug44505-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug55545-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug99948-expected.txt:
  • platform/gtk/tables/mozilla/dom/tableDom-expected.txt:
  • platform/gtk/tables/mozilla/other/move_row-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug45621-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
01:36 Changeset [111165] by leviw@chromium.org

Unreviewed gardening. Fixing expectations due to new Mac Lion baselines.

  • platform/chromium-linux-x86/css2.1/20110323: Removed.
  • platform/chromium-linux/css2.1/20110323/border-collapse-offset-002-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/border-collapse-offset-002-expected.txt: Removed.
  • platform/chromium-mac/css2.1/20110323/border-collapse-offset-002-expected.txt: Removed.
  • platform/chromium-win/css2.1/20110323/border-collapse-offset-002-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/border-collapse-offset-002-expected.txt: Added.
  • platform/mac-snowleopard/css2.1/20110323/border-collapse-offset-002-expected.txt: Removed.
01:24 Changeset [111164] by philn@webkit.org

Unreviewed, GTK gardening

  • platform/gtk/Skipped: Move the 2 http tests skipped in r111161

to the showModal section.

  • platform/gtk/test_expectations.txt: Unskip tests needing rebaseline.
01:21 Changeset [111163] by leviw@chromium.org

Unreviewed gardening: updating max-width-integer-overflow test expectations post 111156, which
eliminated code dealing with 28-bit lengths.

  • platform/chromium-win-vista/fast/table: Added.
  • platform/chromium-win-vista/fast/table/max-width-integer-overflow-expected.txt: Added.
  • platform/chromium-win-xp/fast/table/max-width-integer-overflow-expected.txt: Added.
  • platform/chromium-win/fast/table/max-width-integer-overflow-expected.png: Added.
  • platform/chromium-win/fast/table/max-width-integer-overflow-expected.txt: Added.
01:12 Changeset [111162] by barraclough@apple.com

JSCallbackFunction::toStringCallback/valueOfCallback do not handle 0 return value from convertToType
https://bugs.webkit.org/show_bug.cgi?id=81468 <rdar://problem/11034745>

Reviewed by Oliver Hunt.

The API specifies that convertToType may opt not to handle a conversion:

"@result The objects's converted value, or NULL if the object was not converted."

In which case, it would propagate first up the JSClass hierarchy, calling its superclass's
conversion functions, and failing that call the JSObject::defaultValue function.

Unfortunately this behaviour was removed in bug#69677/bug#69858, and instead we now rely on
the toStringCallback/valueOfCallback function introduced in bug#69156. Even after a fix in
bug#73368, these will return the result from the first convertToType they find, regardless
of whether this result is null, and if no convertToType method is found in the api class
hierarchy (possible if toStringCallback/valueOfCallback was accessed off the prototype
chain), they will also return a null pointer. This is unsafe.

It would be easy to make the approach based around toStringCallback/valueOfCallback continue
to walk the api class hierarchy, but making the fallback to defaultValue would be problematic
(since defaultValue calls toStringCallback/valueOfCallback, this would infinitely recurse).
Making the fallback work with toString/valueOf methods attached to api objects is probably
not the right thing to do – instead, we should just implement the defaultValue trap for api
objects.

In addition, this bug highlights that fact that JSCallbackFunction::call will allow a hard
null to be returned from C to JavaScript - this is not okay. Handle with an exception.

  • API/JSCallbackFunction.cpp:

(JSC::JSCallbackFunction::call):

  • Should be null checking the return value.

(JSC):

  • Remove toStringCallback/valueOfCallback.
  • API/JSCallbackFunction.h:

(JSCallbackFunction):

  • Remove toStringCallback/valueOfCallback.
  • API/JSCallbackObject.h:

(JSCallbackObject):

  • Add defaultValue mthods to JSCallbackObject.
  • API/JSCallbackObjectFunctions.h:

(JSC::::defaultValue):

  • Add defaultValue mthods to JSCallbackObject.
  • API/JSClassRef.cpp:

(OpaqueJSClass::prototype):

  • Remove toStringCallback/valueOfCallback.
  • API/tests/testapi.js:
    • Revert this test, now we no longer artificially introduce a toString method onto the api object.
01:01 Changeset [111161] by philn@webkit.org

Unreviewed, GTK rebaseline after r111156 and skip 2 new http tests.

  • platform/gtk/Skipped:
  • platform/gtk/fast/table/max-width-integer-overflow-expected.txt:
00:11 Changeset [111160] by keishi@webkit.org

[chromium] Fix build that was broken by r111137

Fixed was ambiguous because of MacTypes.h

  • tests/CCLayerTreeHostCommonTest.cpp:

(WebCore::addTransformAnimationToLayer):

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore::addTransformAnimationToLayer):

00:01 Changeset [111159] by timothy_horton@apple.com

Unreviewed new baselines of various tests for Mac.

03/18/12:

23:59 Changeset [111158] by ossy@webkit.org

[Qt] Unreviewed. Disable -Werror on x86 until proper fix.
https://bugs.webkit.org/show_bug.cgi?id=81498

  • qmake/mkspecs/features/unix/default_post.prf:
23:58 Changeset [111157] by commit-queue@webkit.org

Fallback to common script when per-script font setting is the empty string
https://bugs.webkit.org/show_bug.cgi?id=81329

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-03-18
Reviewed by Kent Tamura.

Source/WebCore:

Tests: fast/text/international/font-fallback-to-common-script.html

  • page/Settings.cpp:

(WebCore::setGenericFontFamilyForScript): Remove the setting when the per-script font family is the empty string.

LayoutTests:

  • fast/text/international/font-fallback-to-common-script-expected.html: Added.
  • fast/text/international/font-fallback-to-common-script.html: Added.
23:37 Changeset [111156] by macpherson@chromium.org

Remove remnants of code that assume Lengths are 28 bit integers.
https://bugs.webkit.org/show_bug.cgi?id=67976

Reviewed by Eric Seidel.

Source/WebCore:

Test: LayoutTests/fast/table/max-width-integer-overflow-expected.html

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::computeLength):
Bound by INT_MAX and INT_MIN instead of 28 bit bounds.

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyBorderRadius::applyValue):
Use PrimitiveValue::computeLength function directly.

  • platform/Length.h:

Remove 28 bit integer limit constants.

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::computePreferredLogicalWidths):
Use std::numeric_limits.

LayoutTests:

  • platform/mac/fast/table/max-width-integer-overflow-expected.png:
  • platform/mac/fast/table/max-width-integer-overflow-expected.txt:
23:16 Changeset [111155] by shinyak@chromium.org

Should remove RuntimeEnabledFeatures::multipleShadowSubtreesEnabled
https://bugs.webkit.org/show_bug.cgi?id=79307

Reviewed by Dimitri Glazkov.

Source/WebCore:

Since RuntimeEnabledFeatures::multipleShadowSubtreesEnabled was introduced for
temporal unstability of multiple shadow roots. We should remove it now, and
enable it by default.

Test: fast/dom/shadow/shadow-root-js-api.html should cover this change.
The other shadow related tests should also covers this change.

  • WebCore.exp.in:
  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::create):

  • dom/ShadowTree.cpp:

(WebCore::ShadowTree::addShadowRoot):

  • testing/Internals.cpp:
  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

LayoutTests:

Removed multipleShadowSubtresEnabled from tests.

  • fast/dom/shadow/get-element-by-id-in-shadow-root.html:
  • fast/dom/shadow/multiple-shadowroot-adopt.html:
  • fast/dom/shadow/multiple-shadowroot-rendering.html:
  • fast/dom/shadow/multiple-shadowroot.html:
  • fast/dom/shadow/shadow-element-rendering-multiple.html:
  • fast/dom/shadow/shadow-element-rendering-single.html:
  • fast/dom/shadow/shadow-root-js-api-expected.txt:
  • fast/dom/shadow/shadow-root-js-api.html:
23:07 Changeset [111154] by keishi@webkit.org

[chromium] Mark js-late-gradient-creation.svg as flaky

  • platform/chromium/test_expectations.txt:
22:23 Changeset [111153] by keishi@webkit.org

[chromium] Fix test that was broken by r111128

  • tests/ScrollAnimatorNoneTest.cpp:

(TEST): ScrollByPixel no longer animates.

21:45 Changeset [111152] by keishi@webkit.org

[chromium] Rebaseline aria-checkbox-sends-notification.html

  • platform/chromium-win-xp/accessibility/aria-checkbox-sends-notification-expected.txt: Removed.
21:35 Changeset [111151] by keishi@webkit.org

Skip fast/dom/shadow/get-element-id-in-shadow-roots on some ports where SHADOW_DOM flag is disabled.
https://bugs.webkit.org/show_bug.cgi?id=81336

Patch by Hayato Ito <hayato@chromium.org> on 2012-03-18
Reviewed by Dimitri Glazkov.

  • fast/dom/shadow/resources/shadow-dom.js:

(createDOM):
(isShadowRoot):

  • platform/efl/Skipped:
  • platform/mac/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
20:36 Changeset [111150] by kubo@profusion.mobi

[EFL] Include ICU_INCLUDE_DIRS when building.
https://bugs.webkit.org/show_bug.cgi?id=81483

Reviewed by Daniel Bates.

So far, only the ICU libraries were being included when building
JavaScriptCore, however the include path is also needed, otherwise the
build will fail when ICU is installed into a non-standard location.

  • PlatformEfl.cmake: Include ${ICU_INCLUDE_DIRS}.
19:40 Changeset [111149] by hayato@chromium.org

Skip fast/dom/shadow/get-element-id-in-shadow-roots on some ports where SHADOW_DOM flag is disabled.
https://bugs.webkit.org/show_bug.cgi?id=81336

Reviewed by Dimitri Glazkov.

  • fast/dom/shadow/resources/shadow-dom.js:

(createDOM):
(isShadowRoot):

  • platform/efl/Skipped:
  • platform/mac/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
19:21 Changeset [111148] by keishi@webkit.org

[chromium] Rebaseline SL results for video-opacity-overlay.html and load-video-in-reflection.html

  • platform/chromium-mac-snowleopard/compositing/geometry/video-opacity-overlay-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/reflections/load-video-in-reflection-expected.png: Added.
19:12 Changeset [111147] by keishi@webkit.org

[chromium] Rebaseline results for win shadow-drawing.html

  • platform/chromium-win-vista/compositing/shadows/shadow-drawing-expected.png: Added.
19:06 Changeset [111146] by keishi@webkit.org

[chromium] Rebaseline to add expected results for fixed-position-scroll.html

  • platform/chromium-win/compositing/layer-creation/fixed-position-scroll-expected.png: Renamed from LayoutTests/platform/chromium-linux/compositing/layer-creation/fixed-position-scroll-expected.png.
  • platform/chromium-win/compositing/layer-creation/fixed-position-scroll-expected.txt: Added.
18:07 Changeset [111145] by commit-queue@webkit.org

[chromium] Don't occlude on main-thread behind layers/surfaces with impl-thread animations
https://bugs.webkit.org/show_bug.cgi?id=81354

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-18
Reviewed by Adrienne Walker.

Source/WebCore:

Layers and surfaces can have an animating opacity or translation on the
impl thread. In this case, the main thread does not know their actual
values, and treats these values as "unknowns". This means we can't use
them for marking areas of the screen as occluded, and we can't consider
a part of a layer occluded in a space that we can not reliably transform
to.

Unit test: CCOcclusionTrackerTestAnimationOpacity0OnMainThread

CCOcclusionTrackerTestAnimationOpacity1OnMainThread
CCOcclusionTrackerTestAnimationTranslateOnMainThread

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::layerOpacityKnown):
(WebCore::layerTransformsToTargetKnown):
(WebCore::layerTransformsToScreenKnown):
(WebCore):
(WebCore::surfaceOpacityUnknown):
(WebCore::surfaceTransformsToTargetUnknown):
(WebCore::surfaceTransformsToScreenUnknown):
(WebCore::::finishedTargetRenderSurface):
(WebCore::contentToScreenSpaceTransform):
(WebCore::contentToTargetSurfaceTransform):
(WebCore::::markOccludedBehindLayer):
(WebCore::::occluded):
(WebCore::::unoccludedContentRect):

Source/WebKit/chromium:

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore):
(WebCore::addOpacityAnimationToLayer):
(WebCore::addTransformAnimationToLayer):
(CCOcclusionTrackerTestAnimationOpacity1OnMainThread):
(WebCore::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest):
(CCOcclusionTrackerTestAnimationOpacity0OnMainThread):
(WebCore::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest):
(CCOcclusionTrackerTestAnimationTranslateOnMainThread):
(WebCore::CCOcclusionTrackerTestAnimationTranslateOnMainThread::runMyTest):

17:58 Changeset [111144] by commit-queue@webkit.org

[chromium] Animating opacity is not opaque and should create a render surface on main thread
https://bugs.webkit.org/show_bug.cgi?id=81401

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-18
Reviewed by James Robinson.

Source/WebCore:

Unit test: CCLayerTreeHostCommonTest.verifyAnimationsForRenderSurfaceHierarchy

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::layerOpacityIsOpaque):
(WebCore):
(WebCore::subtreeShouldRenderToSeparateSurface):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostCommonTest.cpp:

(WebCore::TEST):

17:39 Changeset [111143] by weinig@apple.com

WebCore::BitmapImage::getCGImageRef should not be used off the main thread.
https://bugs.webkit.org/show_bug.cgi?id=81441

Reviewed by Anders Carlsson.

Covered by existing tests.

  • loader/cache/MemoryCache.cpp:

(WebCore::memoryCache):
(WebCore::MemoryCache::add):
(WebCore::MemoryCache::revalidationFailed):
(WebCore::MemoryCache::resourceForURL):
(WebCore::MemoryCache::evict):
Add back main thread assertions.

  • platform/graphics/cg/PatternCG.cpp:

(PatternCallbackData):
(WebCore::patternCallback):
(WebCore::patternReleaseOnMainThreadCallback):
(WebCore::Pattern::createPlatformPattern):
Instead of pulling out the CGImageRef in the pattern callback, do it upfront.

17:31 UsingGitHub edited by abarth@webkit.org
(diff)
17:23 Changeset [111142] by ahf@0x90.dk

[Qt] Don't prepare SQL statements when the database is not open https://bugs.webkit.org/show_bug.cgi?id=81470

Reviewed by Kenneth Rohde Christiansen.

Already covered by existing tests.

  • platform/qt/CookieJarQt.cpp:

(WebCore::SharedCookieJarQt::deleteCookiesForHostname):
(WebCore::SharedCookieJarQt::deleteAllCookies):
(WebCore::SharedCookieJarQt::setCookiesFromUrl):
(WebCore::SharedCookieJarQt::loadCookies):

16:50 Changeset [111141] by haraken@chromium.org

Unreviewed, rolling out r110994 due to Chromium crash

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • notifications/DOMWindowNotifications.cpp: Removed.
  • notifications/DOMWindowNotifications.h: Removed.
  • notifications/DOMWindowNotifications.idl: Removed.
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::willDetachPage):
(WebCore::DOMWindow::disconnectDOMWindowProperties):
(WebCore::DOMWindow::clearDOMWindowProperties):
(WebCore):
(WebCore::DOMWindow::webkitNotifications):
(WebCore::DOMWindow::resetNotifications):

  • page/DOMWindow.h:

(WebCore):
(DOMWindow):

  • page/DOMWindow.idl:
  • page/Frame.cpp:

(WebCore::Frame::willDetachPage):
(WebCore::Frame::transferChildFrameToNewDocument):

16:39 Changeset [111140] by haraken@chromium.org

Unreviewed, rolling out r111086.
http://trac.webkit.org/changeset/111086
https://bugs.webkit.org/show_bug.cgi?id=81374

Chromium crash

  • notifications/DOMWindowNotifications.cpp:

(WebCore::DOMWindowNotifications::disconnectFrame):

16:07 Changeset [111139] by commit-queue@webkit.org

Invalidation issue when creating backing layer for fixed positioned element.
https://bugs.webkit.org/show_bug.cgi?id=80647

Patch by David Reveman <reveman@chromium.org> on 2012-03-18
Reviewed by James Robinson.

Source/WebCore:

Ensure that root layer is correctly invalidated by handling scroll and
invalidation from movement of fixed position elements prior to creating
any backing layers.

Test: compositing/layer-creation/fixed-position-scroll.html

  • page/FrameView.cpp:

(WebCore::FrameView::repaintFixedElementsAfterScrolling):
(WebCore):
(WebCore::FrameView::updateFixedElementsAfterScrolling):

  • page/FrameView.h:

(FrameView):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::scrollTo):

  • platform/ScrollView.h:

(WebCore::ScrollView::repaintFixedElementsAfterScrolling):
(WebCore::ScrollView::updateFixedElementsAfterScrolling):

LayoutTests:

  • compositing/layer-creation/fixed-position-scroll.html: Added.
  • platform/chromium-linux/compositing/layer-creation/fixed-position-scroll-expected.png: Added.
15:52 Changeset [111138] by noam.rosenthal@nokia.com

[Qt][WK2] Avoid usage of manual scaling in the Qt scenegraph integration
https://bugs.webkit.org/show_bug.cgi?id=81368

Reviewed by Simon Hausmann.

Moved the QtScenegraph integration classes to a separate file,
QtWebPageSGNode. The nodes created for QQuickWebPage now include
a QSGTransformNode that controls the contentsScale, a
QSGSimpleRectNode that controls the background color, and a
QSGRenderNode subclass that renders the actual contents.

  • Target.pri:
  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPage::updatePaintNode):

  • UIProcess/qt/QtWebPageSGNode.cpp: Added.
  • UIProcess/qt/QtWebPageSGNode.h: Added.
14:58 Changeset [111137] by commit-queue@webkit.org

[chromium] Transform animation state should be inherited from parents
https://bugs.webkit.org/show_bug.cgi?id=81363

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-18
Reviewed by Adrienne Walker.

Source/WebCore:

Adds a drawTransformIsAnimating() and screenSpaceTransformIsAnimating()
to the layer classes, and similar to the surface classes. These inherit
the values from their parents in the same way that the transforms
themselves do, and reflect if the layer's transform is being affected
by some active animation.

These can be used in main-thread culling when determining if the layer's
position is static in the given coordinate space or being animated.

Unit test: CCLayerTreeHostCommonTest.verifyAnimationsForRenderSurfaceHierarchy

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):
(WebCore::LayerChromium::drawTransformIsAnimating):
(WebCore::LayerChromium::setDrawTransformIsAnimating):
(WebCore::LayerChromium::screenSpaceTransformIsAnimating):
(WebCore::LayerChromium::setScreenSpaceTransformIsAnimating):

  • platform/graphics/chromium/RenderSurfaceChromium.cpp:

(WebCore::RenderSurfaceChromium::RenderSurfaceChromium):

  • platform/graphics/chromium/RenderSurfaceChromium.h:

(WebCore::RenderSurfaceChromium::targetSurfaceTransformsAreAnimating):
(WebCore::RenderSurfaceChromium::setTargetSurfaceTransformsAreAnimating):
(WebCore::RenderSurfaceChromium::screenSpaceTransformsAreAnimating):
(WebCore::RenderSurfaceChromium::setScreenSpaceTransformsAreAnimating):
(RenderSurfaceChromium):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):
(WebCore::CCLayerImpl::drawTransformIsAnimating):
(WebCore::CCLayerImpl::setDrawTransformIsAnimating):
(WebCore::CCLayerImpl::screenSpaceTransformIsAnimating):
(WebCore::CCLayerImpl::setScreenSpaceTransformIsAnimating):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::subtreeShouldBeSkipped):
(WebCore::calculateDrawTransformsAndVisibilityInternal):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::CCRenderSurface):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore::CCRenderSurface::targetSurfaceTransformsAreAnimating):
(WebCore::CCRenderSurface::setTargetSurfaceTransformsAreAnimating):
(WebCore::CCRenderSurface::screenSpaceTransformsAreAnimating):
(WebCore::CCRenderSurface::setScreenSpaceTransformsAreAnimating):
(CCRenderSurface):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostCommonTest.cpp:

(WebCore::addOpacityAnimationToLayer):
(WebCore):
(WebCore::addTransformAnimationToLayer):
(WebCore::TEST):

12:28 Changeset [111136] by noam.rosenthal@nokia.com

[Qt] The background is visible for tiles inside the contents area which are not ready
https://bugs.webkit.org/show_bug.cgi?id=81349

Reviewed by Simon Hausmann.

Split PageProxyNode to BackgroundSGNode and ContentsSGNode.
BackgroundSGNode paints a solid background, either white or transparent
(depending on drawsTransparentBackground flag).

  • UIProcess/API/qt/qquickwebpage.cpp:

(ContentsSGNode):
(ContentsSGNode::ContentsSGNode):
(ContentsSGNode::changedStates):
(ContentsSGNode::~ContentsSGNode):
(BackgroundSGNode):
(BackgroundSGNode::BackgroundSGNode):
(BackgroundSGNode::contentsNode):
(QQuickWebPage::updatePaintNode):

12:17 Changeset [111135] by psolanki@apple.com

Fix compile when FULLSCREEN_API is not enabled on Mac
https://bugs.webkit.org/show_bug.cgi?id=81474

Reviewed by Ada Chan.

Guard the full screen api code inside ENABLE(FULLSCREEN_API).

No new tests because no functional changes.

  • platform/mac/WebCoreFullScreenWindow.h:
  • platform/mac/WebCoreFullScreenWindow.mm:
11:47 Changeset [111134] by lforschler@apple.com

New tag.

09:59 Changeset [111133] by haraken@chromium.org

Change the initial buffer size of a plain text
https://bugs.webkit.org/show_bug.cgi?id=81192

Reviewed by Dimitri Glazkov.

r111109 changed the initial buffer size of a plain text
from 1<<16 to 1<<15 in Chromium/Mac only, for the following reasons:

  • As far as I experimented locally, while 1<<15 is better than 1<<16 in Chromium/Mac,

1<<15 and 1<<16 are the same in AppleWebKit/Mac and Chromium/Linux (their performance
"gap" exists at between 1<<17 and 1<<18).

  • The reason why I changed 1<<16 to 1<<15 in Chromium/Mac only is that

the value highly depends on the underlying malloc system and I was a bit afraid
that changing to 1<<15 _might_ cause unintentional performance regression in some
platform.

That being said, it seems that 1<<15 would not be worse than 1<<16 in all platforms,
and we should just keep the value consistent. In the first place, according to anttik
(who wrote 1<<16 a long time ago), there was no strong reason for 1<<16.

Based on these observations (See https://bugs.webkit.org/show_bug.cgi?id=81192
for more details), this patch unifies the value to 1<<15 in all platforms.

No tests. No change in behavior.

  • editing/TextIterator.cpp:

(WebCore::plainTextToMallocAllocatedBuffer):

04:33 Changeset [111132] by robert@webkit.org

CSS 2.1 failure: eof-003.htm fails
https://bugs.webkit.org/show_bug.cgi?id=78538

Reviewed by Antti Koivisto.

Source/WebCore:

Tests: css2.1/20110323/eof-001.htm

css2.1/20110323/eof-003.htm
css2.1/20110323/eof-004.htm
css2.1/20110323/eof-005.htm
css2.1/20110323/eof-006.htm
css2.1/20110323/eof-007.htm

This patch fixes eof-003.htm, eof-005.htm and eof-006.htm. The other eof-* tests already pass.

  • css/CSSGrammar.y: Allow EOF as well as ';' to terminate import rules.

This should probably be done for other rules in a separate patch.

  • css/CSSParser.cpp:

(WebCore::CSSParser::checkAndSkipString): Allow strings to end with EOF.
(WebCore::CSSParser::parseString): ditto

LayoutTests:

  • css2.1/20110323/eof-001-expected.html: Added.
  • css2.1/20110323/eof-001.htm: Added.
  • css2.1/20110323/eof-003-expected.html: Added.
  • css2.1/20110323/eof-003.htm: Added.
  • css2.1/20110323/eof-004-expected.html: Added.
  • css2.1/20110323/eof-004.htm: Added.
  • css2.1/20110323/eof-005-expected.html: Added.
  • css2.1/20110323/eof-005.htm: Added.
  • css2.1/20110323/eof-006-expected.html: Added.
  • css2.1/20110323/eof-006.htm: Added.
  • css2.1/20110323/eof-007-expected.html: Added.
  • css2.1/20110323/eof-007.htm: Added.
  • css2.1/20110323/support/eof-green.css: Added.
01:18 FeatureFlags edited by tkent@chromium.org
(diff)

03/17/12:

22:24 WebKit Team edited by kubo@profusion.mobi
Update my affiliation (diff)
20:20 Changeset [111131] by commit-queue@webkit.org

[Chromium] PlatformContextSkia::m_drawingToImageBuffer is not correctly set when using per-tile painting.
https://bugs.webkit.org/show_bug.cgi?id=81463

Patch by David Reveman <reveman@chromium.org> on 2012-03-17
Reviewed by James Robinson.

Call PlatformContextSkia::setDrawingToImageBuffer() from
SkPictureCanvasLayerTextureUpdater::prepareToUpdate so that sub-pixel
text rendering is not used incorrectly with per-tile painting.

No new tests.

  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::SkPictureCanvasLayerTextureUpdater::prepareToUpdate):

18:57 Changeset [111130] by kubo@profusion.mobi

Unreviewed; switch to using my FreeBSD.org email address, the
other one is going to disappear soon.

  • Scripts/webkitpy/common/config/committers.py:
  • Scripts/webkitpy/common/config/watchlist:
18:08 Changeset [111129] by barraclough@apple.com

Strength reduction, RegExp.exec -> RegExp.test
https://bugs.webkit.org/show_bug.cgi?id=81459

Reviewed by Sam Weinig.

RegExp.prototype.exec & RegExp.prototype.test can both be used to test a regular
expression for a match against a string - however exec is more expensive, since
it allocates a matches array object. In cases where the result is consumed in a
boolean context the allocation of the matches array can be trivially elided.

For example:

function f()
{

for (i =0; i < 10000000; ++i)

if(!/a/.exec("a"))

err = true;

}

This is a 2.5x speedup on this example microbenchmark loop.

In a more advanced form of this optimization, we may be able to avoid allocating
the array where access to the array can be observed.

  • create_hash_table:
  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsic):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasHeapPrediction):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileRegExpExec):
(DFG):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jsc.cpp:

(GlobalObject::addConstructableFunction):

  • runtime/Intrinsic.h:
  • runtime/JSFunction.cpp:

(JSC::JSFunction::create):
(JSC):

  • runtime/JSFunction.h:

(JSFunction):

  • runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::exec):
(JSC::RegExpObject::match):

  • runtime/RegExpObject.h:

(RegExpObject):

  • runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncTest):
(JSC::regExpProtoFuncExec):

16:57 Changeset [111128] by commit-queue@webkit.org

[chromium] Make pixel-accurate wheel scrolling be unanimated
https://bugs.webkit.org/show_bug.cgi?id=81457

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-17
Reviewed by James Robinson.

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::scroll):

15:56 Changeset [111127] by rwlbuis@webkit.org

[BlackBerry] Implement openTemporaryFile in FileSystem
https://bugs.webkit.org/show_bug.cgi?id=81373

Reviewed by George Staikos.

Move the Efl implementation to Posix, this way BlackBerry port can reuse it.

  • platform/blackberry/FileSystemBlackBerry.cpp:
  • platform/efl/FileSystemEfl.cpp:
  • platform/posix/FileSystemPOSIX.cpp:

(WebCore::openTemporaryFile):
(WebCore):

12:54 Changeset [111126] by commit-queue@webkit.org

move calc*Value functions out from Length (and platform)
https://bugs.webkit.org/show_bug.cgi?id=80897

Moving the Length calc*Value functions out from Length structure and also from /WebCore/platform/ folder.
This helps to avoid the layering violation while length calculation. Otherwise layer violation can be avoided only by adding a virtual interface(bug 27160).

Patch by Joe Thomas <joethomas@motorola.com> on 2012-03-17
Reviewed by Antti Koivisto.

Source/WebCore:

  • GNUmakefile.list.am: Build system changes for adding new files.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • accessibility/gtk/WebKitAccessibleInterfaceText.cpp:

(getAttributeSetForAccessibilityObject):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/LengthFunctions.h: Added. Moved calc*Value functions of Length.

(WebCore):
(WebCore::calculateMinimumValue):
(WebCore::calculateValue):
(WebCore::calculateFloatValue):

  • dom/Document.cpp:

(WebCore::Document::pageSizeAndMarginsInPixels):

  • html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::getRegion):

  • platform/CalculationValue.h:

(WebCore::CalcExpressionLength::evaluate):

  • platform/Length.h: Removed the calc*Value functions from Length structure.

(Length):
(WebCore::Length::getFloatValue):
(WebCore::Length::getIntValue):

  • platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::setFilters):

  • platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:

(WebCore::CCRenderSurfaceFilters::apply):

  • platform/graphics/filters/FilterOperations.cpp:

(WebCore::FilterOperations::getOutsets):

  • platform/graphics/transforms/PerspectiveTransformOperation.cpp:

(WebCore::PerspectiveTransformOperation::blend):

  • platform/graphics/transforms/PerspectiveTransformOperation.h:

(WebCore::PerspectiveTransformOperation::isIdentity):
(WebCore::PerspectiveTransformOperation::apply):

  • platform/graphics/transforms/TranslateTransformOperation.h:

(WebCore::TranslateTransformOperation::x):
(WebCore::TranslateTransformOperation::y):
(WebCore::TranslateTransformOperation::z):
(WebCore::TranslateTransformOperation::isIdentity):

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::paint):

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::layout):

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::build):

  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::layout):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::textIndentOffset):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::reflectionOffset):
(WebCore::RenderBox::clipRect):
(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::availableLogicalHeightUsing):
(WebCore::RenderBox::computeBlockDirectionMargins):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::relativePositionOffsetX):
(WebCore::RenderBoxModelObject::relativePositionOffsetY):
(WebCore::RenderBoxModelObject::paddingTop):
(WebCore::RenderBoxModelObject::paddingBottom):
(WebCore::RenderBoxModelObject::paddingLeft):
(WebCore::RenderBoxModelObject::paddingRight):
(WebCore::RenderBoxModelObject::paddingBefore):
(WebCore::RenderBoxModelObject::paddingAfter):
(WebCore::RenderBoxModelObject::paddingStart):
(WebCore::RenderBoxModelObject::paddingEnd):
(WebCore::RenderBoxModelObject::calculateFillTileSize):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
(WebCore::computeBorderImageSide):
(WebCore::RenderBoxModelObject::paintNinePieceImage):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithm):

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::layOutAxis):

  • rendering/RenderInline.cpp:

(WebCore::computeMargin):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::perspectiveTransform):
(WebCore::RenderLayer::perspectiveOrigin):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::computeTransformOrigin):
(WebCore::RenderLayerBacking::computePerspectiveOrigin):

  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::timerFired):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::updateOptionsWidth):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::repaintAfterLayoutIfNeeded):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeReplacedLogicalWidth):

  • rendering/RenderScrollbarPart.cpp:

(WebCore::calcScrollbarThicknessUsing):
(WebCore::RenderScrollbarPart::computeScrollbarWidth):
(WebCore::RenderScrollbarPart::computeScrollbarHeight):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth):
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::logicalHeightForRowSizing):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):

  • rendering/RenderText.h:

(WebCore::RenderText::marginLeft):
(WebCore::RenderText::marginRight):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::verticalPositionForBox):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::applyTransform):
(WebCore::calcRadiiFor):

  • rendering/style/RenderStyle.h:
  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::computeIntrinsicRatioInformation):
(WebCore::resolveLengthAttributeForSVG):

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::currentViewBoxRect):
(WebCore::SVGSVGElement::currentViewportSize):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::computeIntrinsicDimensions):

Source/WebKit2:

  • WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:

(WebKit::WebPopupMenu::setUpPlatformData):

12:23 Changeset [111125] by mitz@apple.com

<rdar://problem/10263562> Crash in WebCore::Range::startPosition() when dismissing the Press and Hold panel by clicking in the menu bar
https://bugs.webkit.org/show_bug.cgi?id=81454

Reviewed by Ada Chan.

When the Press and Hold panel is dismissed by clicking in the menu bar,
-insertText:replacementRange: is called with an NSRange whose location is NSNotFound - 1
(see <rdar://problem/11069374>). Trying to convert this bogus range to a WebCore Range
returns 0, which leads to the crash.

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::insertText): Added a null check, to protect the code from bogus ranges.

11:53 Changeset [111124] by abarth@webkit.org

Merge 106874 - postMessage leaks MemoryEvent object
https://bugs.webkit.org/show_bug.cgi?id=77893

Patch by Greg Simon <gregsimon@chromium.org> on 2012-02-06
Reviewed by Adam Barth.

Changed from PassRefPtr().leakRef() to RefPtr.get() when
calling into FrameLoaderClient to stop +1 extra ref.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessageTimerFired):

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9717030

11:19 Changeset [111123] by jamesr@google.com

Merge 110821 - Platforms without USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) don't need to query the page's displayID
https://bugs.webkit.org/show_bug.cgi?id=81187

Reviewed by Simon Fraser.

  • dom/Document.cpp:

(WebCore::Document::webkitRequestAnimationFrame):

TBR=jamesr@google.com
BUG=118331
Review URL: https://chromiumcodereview.appspot.com/9716016

11:12 Changeset [111122] by kubo@profusion.mobi

Unreviewed; fix webkitpy unit test failures after r111116.

It turns out that cmd_line in the patch in bug 80025 had the right
signature when it was submitted, but r109242 added a few more
required parameters, and since the method (and EflDriver) did not
exist at the time we ended up committing a broken method.

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflDriver.cmd_line): Add the pixel_tests' and per_test_args'
arguments.

08:45 Changeset [111121] by charles.wei@torchmobile.com.cn

[BlackBerry] Enable Web Timing for performance profiling and improvement.
https://bugs.webkit.org/show_bug.cgi?id=81085

Reviewed by Rob Buis.

.:

  • Source/cmake/OptionsBlackBerry.cmake:
  • Source/cmakeconfig.h.cmake:

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

Tools:

  • Scripts/build-webkit:
05:13 Changeset [111120] by zimmermann@webkit.org

Enable animVal support for SVGNumberOptionalNumber
https://bugs.webkit.org/show_bug.cgi?id=81448

Reviewed by Antti Koivisto.

Source/WebCore:

Enable animVal support for SVGNumberOptionalNumber. Its a special case as two SVG DOM properties
eg. stdDeviationX/stdDeviationY are mapped to a single XML attribute: SVGNames::stdDeviationAttr.

When animating properties like this, both animVal wrappers need to reflect changes.
Generalize the current animVal code to support more than one SVGAnimatedProperty that gets
animated for a single attributeName. This allows us to remove SVGAnimatedType::variantValue/setVariantValue
which paves the way for removing SVGGenericAnimatedType from even more places.

Covered by existing tests.

  • svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::SVGAnimateElement):
(WebCore::SVGAnimateElement::calculateAnimatedValue):
(WebCore::SVGAnimateElement::resetToBaseValue):
(WebCore::SVGAnimateElement::targetElementWillChange):

  • svg/SVGAnimateElement.h:

(SVGAnimateElement):

  • svg/SVGAnimatedLength.cpp:

(WebCore::SVGAnimatedLengthAnimator::constructFromBaseValue):
(WebCore):
(WebCore::SVGAnimatedLengthAnimator::resetAnimatedTypeToBaseValue):

  • svg/SVGAnimatedLength.h:

(SVGAnimatedLengthAnimator):

  • svg/SVGAnimatedLengthList.cpp:

(WebCore::SVGAnimatedLengthListAnimator::constructFromBaseValue):
(WebCore):
(WebCore::SVGAnimatedLengthListAnimator::resetAnimatedTypeToBaseValue):

  • svg/SVGAnimatedLengthList.h:

(SVGAnimatedLengthListAnimator):

  • svg/SVGAnimatedNumber.cpp:

(WebCore::SVGAnimatedNumberAnimator::constructFromBaseValue):
(WebCore):
(WebCore::SVGAnimatedNumberAnimator::resetAnimatedTypeToBaseValue):

  • svg/SVGAnimatedNumber.h:

(SVGAnimatedNumberAnimator):

  • svg/SVGAnimatedNumberList.cpp:

(WebCore::SVGAnimatedNumberListAnimator::constructFromBaseValue):
(WebCore):
(WebCore::SVGAnimatedNumberListAnimator::resetAnimatedTypeToBaseValue):

  • svg/SVGAnimatedNumberList.h:

(SVGAnimatedNumberListAnimator):

  • svg/SVGAnimatedNumberOptionalNumber.cpp:

(WebCore::SVGAnimatedNumberOptionalNumberAnimator::constructFromBaseValue):
(WebCore):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::resetAnimatedTypeToBaseValue):

  • svg/SVGAnimatedNumberOptionalNumber.h:

(WebCore):
(SVGAnimatedNumberOptionalNumberAnimator):

  • svg/SVGAnimatedTransformList.cpp:

(WebCore::SVGAnimatedTransformListAnimator::constructFromBaseValue):
(WebCore::SVGAnimatedTransformListAnimator::resetAnimatedTypeToBaseValue):
(WebCore):

  • svg/SVGAnimatedTransformList.h:

(SVGAnimatedTransformListAnimator):

  • svg/SVGAnimatedType.cpp:

(WebCore::SVGAnimatedType::supportsAnimVal):

  • svg/SVGAnimatedType.h:

(SVGAnimatedType):

  • svg/SVGAnimatedTypeAnimator.h:

(SVGAnimatedTypeAnimator):
(WebCore::SVGAnimatedTypeAnimator::constructFromBaseValue):
(WebCore::SVGAnimatedTypeAnimator::resetAnimatedTypeToBaseValue):
(WebCore::SVGAnimatedTypeAnimator::currentBaseValueVariant):
(WebCore::SVGAnimatedTypeAnimator::constructFromOneBaseValue):
(WebCore::SVGAnimatedTypeAnimator::resetAnimatedTypeFromOneBaseValue):
(WebCore::SVGAnimatedTypeAnimator::constructFromTwoBaseValues):
(WebCore::SVGAnimatedTypeAnimator::resetAnimatedTypeFromTwoBaseValues):

  • svg/SVGAnimationElement.cpp:

(WebCore::findMatchingAnimatedProperties):
(WebCore::SVGAnimationElement::applyAnimatedValue):
(WebCore::notifyAnimatedPropertyAboutAnimationBeginEnd):
(WebCore::SVGAnimationElement::animationStarted):
(WebCore::SVGAnimationElement::animationEnded):
(WebCore::SVGAnimationElement::animatedPropertiesForType):

  • svg/SVGAnimationElement.h:
  • svg/properties/SVGAnimatedListPropertyTearOff.h:

(WebCore::SVGAnimatedListPropertyTearOff::currentBaseValueVariant):
(WebCore::SVGAnimatedListPropertyTearOff::animationStarted):

  • svg/properties/SVGAnimatedProperty.h:

(SVGAnimatedProperty):

  • svg/properties/SVGAnimatedPropertyTearOff.h:

(WebCore::SVGAnimatedPropertyTearOff::currentBaseValueVariant):
(WebCore::SVGAnimatedPropertyTearOff::animationStarted):

  • svg/properties/SVGAnimatedStaticPropertyTearOff.h:

(WebCore::SVGAnimatedStaticPropertyTearOff::currentBaseValueVariant):
(WebCore::SVGAnimatedStaticPropertyTearOff::animationStarted):

LayoutTests:

Extend SVGNumberOptionalNumber tests to cover animVal/baseVal at the same time.

  • svg/animations/script-tests/svgnumberoptionalnumber-animation-1.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/svgnumberoptionalnumber-animation-2.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/svgnumberoptionalnumber-animation-3.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/svgnumberoptionalnumber-animation-4.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/svgnumberoptionalnumber-animation-1-expected.txt:
  • svg/animations/svgnumberoptionalnumber-animation-2-expected.txt:
  • svg/animations/svgnumberoptionalnumber-animation-3-expected.txt:
  • svg/animations/svgnumberoptionalnumber-animation-4-expected.txt:
04:30 Changeset [111119] by philn@webkit.org

[GStreamer] run AudioFileReader in a nested loop
https://bugs.webkit.org/show_bug.cgi?id=80823

Reviewed by Martin Robinson.

Use a separate main loop for the file reader, this approach is
much cleaner than polling the default GLib main context.

  • platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(AudioFileReader):
(WebCore::enteredMainLoopCallback):
(WebCore):
(WebCore::AudioFileReader::AudioFileReader):
(WebCore::AudioFileReader::handleMessage):
(WebCore::AudioFileReader::start):
(WebCore::AudioFileReader::createBus):

03:48 Changeset [111118] by robert@webkit.org

CSS 2.1 failure: fixed-table-layout-013 and fixed-table-layout-015 fail
https://bugs.webkit.org/show_bug.cgi?id=78027

Reviewed by Julien Chaffraix.

Source/WebCore:

Both of these test the (slightly implicit) rule that width set on column-groups cannot
affect the width of columns in a fixed layout table: http://www.w3.org/TR/CSS21/tables.html#fixed-table-layout
FF, Opera and IE all pass these two tests.

Tests: css2.1/20110323/fixed-table-layout-013.htm

css2.1/20110323/fixed-table-layout-015.htm
fast/table/fixed-table-layout-toggle-colwidth.html

  • rendering/FixedTableLayout.cpp:

(WebCore::nextCol): A helper function for finding the next column along.
(WebCore::FixedTableLayout::calcWidthArray): Ignore width specified by column groups.

  • rendering/RenderTableCol.h:

(WebCore::RenderTableCol::isTableColGroup): Convenience function for identifying column groups.

LayoutTests:

  • css2.1/20110323/fixed-table-layout-013-expected.html: Added.
  • css2.1/20110323/fixed-table-layout-013.htm: Added.
  • css2.1/20110323/fixed-table-layout-015-expected.html: Added.
  • css2.1/20110323/fixed-table-layout-015.htm: Added.
  • fast/table/fixed-table-layout-toggle-colwidth-expected.txt: Added.
  • fast/table/fixed-table-layout-toggle-colwidth.html: Added.
00:45 Changeset [111117] by kubo@profusion.mobi

Add a dependencies installation step for EFL to buildbot master.cfg
https://bugs.webkit.org/show_bug.cgi?id=81337

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-03-17
Reviewed by Gustavo Noronha Silva.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(InstallEflDependencies):
(Factory.init):

00:33 Changeset [111116] by kubo@profusion.mobi

[EFL] Prefixing run-webkit-tests with run-with-jhbuild
https://bugs.webkit.org/show_bug.cgi?id=80025

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-03-17
Reviewed by Gustavo Noronha Silva.

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflDriver):
(EflDriver.cmd_line):
(EflPort._driver_class):

00:30 Changeset [111115] by kubo@profusion.mobi

[EFL] Add and use run-with-jhbuild and update-webkitefl-libs scripts for EFL
https://bugs.webkit.org/show_bug.cgi?id=79904

build-webkit --efl will use jhbuild for fetching and building dependencies.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-03-17
Reviewed by Gustavo Noronha Silva.

  • Scripts/update-webkitefl-libs: Added.
  • Scripts/webkitdirs.pm:

(jhbuildWrapperPrefixIfNeeded):
(generateBuildSystemFromCMakeProject):
(buildCMakeGeneratedProject):

  • efl/common.py: Added.

(script_path):
(top_level_path):
(number_of_cpus):

  • efl/jhbuild.modules: Added.
  • efl/jhbuildrc: Added.
  • efl/run-with-jhbuild: Added.

03/16/12:

23:42 Changeset [111114] by leo.yang@torchmobile.com.cn

[BlackBerry] Add BlackBerry to NavigatorBase.cpp
https://bugs.webkit.org/show_bug.cgi?id=81303

Reviewed by Rob Buis.

  • page/NavigatorBase.cpp:
23:39 Changeset [111113] by leo.yang@torchmobile.com.cn

[BlackBerry] Add typedef of DragDataRef for blackberry
https://bugs.webkit.org/show_bug.cgi?id=81301

Reviewed by Rob Buis.

  • platform/DragData.h:
21:15 Changeset [111112] by commit-queue@webkit.org

[chromium] Unify the drawing logic for different layer types that output textures to the compositor
https://bugs.webkit.org/show_bug.cgi?id=81286

Patch by James Robinson <jamesr@chromium.org> on 2012-03-16
Reviewed by Adrienne Walker.

Source/WebCore:

Currently canvas 2d, webgl, and plugin layers all export a texture to the compositor that then needs to be
drawn. There are a small set of operations that can be applied to the texture at draw time - do a Y flip,
stretch a subrect to the layer bounds, set the blend mode etc but they are fundamentally the same thing. This
collapses the nearly-redundant code into a single impl-side layer type for a texture-backed layer that can
handle the union of the bits needed for each layer type.

Canvas 2d, WebGL and plugin composited rendering are all covered by layout tests.

  • WebCore.gypi:
  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/CanvasLayerChromium.cpp:

(WebCore::CanvasLayerChromium::createCCLayerImpl):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawQuad):
(WebCore::TexStretchTextureProgramBinding::set):
(WebCore::TexTransformTextureProgramBinding::set):
(WebCore::LayerRendererChromium::drawTextureQuad):
(WebCore::LayerRendererChromium::textureLayerProgramFlip):
(WebCore::LayerRendererChromium::textureLayerProgramStretch):
(WebCore::LayerRendererChromium::textureLayerProgramStretchFlip):
(WebCore::LayerRendererChromium::textureLayerTexRectProgram):
(WebCore::LayerRendererChromium::textureLayerTexRectProgramFlip):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:

(WebCore):
(LayerRendererChromium):

  • platform/graphics/chromium/PluginLayerChromium.cpp:

(WebCore::PluginLayerChromium::PluginLayerChromium):
(WebCore::PluginLayerChromium::createCCLayerImpl):
(WebCore::PluginLayerChromium::setIOSurfaceProperties):
(WebCore::PluginLayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/PluginLayerChromium.h:

(PluginLayerChromium):

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/cc/CCCanvasDrawQuad.cpp: Removed.
  • platform/graphics/chromium/cc/CCCanvasDrawQuad.h: Removed.
  • platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp: Removed.
  • platform/graphics/chromium/cc/CCCanvasLayerImpl.h: Removed.
  • platform/graphics/chromium/cc/CCDrawQuad.cpp:

(WebCore::CCDrawQuad::toTextureDrawQuad):

  • platform/graphics/chromium/cc/CCDrawQuad.h:

(WebCore):
(CCDrawQuad):

  • platform/graphics/chromium/cc/CCTextureDrawQuad.cpp: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCPluginDrawQuad.cpp.

(WebCore):
(WebCore::CCTextureDrawQuad::create):
(WebCore::CCTextureDrawQuad::CCTextureDrawQuad):

  • platform/graphics/chromium/cc/CCTextureDrawQuad.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCPluginDrawQuad.h.

(WebCore):
(CCTextureDrawQuad):
(WebCore::CCTextureDrawQuad::textureId):
(WebCore::CCTextureDrawQuad::hasAlpha):
(WebCore::CCTextureDrawQuad::premultipliedAlpha):
(WebCore::CCTextureDrawQuad::uvRect):
(WebCore::CCTextureDrawQuad::flipped):
(WebCore::CCTextureDrawQuad::ioSurfaceSize):
(WebCore::CCTextureDrawQuad::ioSurfaceTextureId):

  • platform/graphics/chromium/cc/CCTextureLayerImpl.cpp: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCPluginLayerImpl.cpp.

(WebCore):
(WebCore::CCTextureLayerImpl::CCTextureLayerImpl):
(WebCore::CCTextureLayerImpl::~CCTextureLayerImpl):
(WebCore::CCTextureLayerImpl::willDraw):
(WebCore::CCTextureLayerImpl::appendQuads):
(WebCore::CCTextureLayerImpl::dumpLayerProperties):
(WebCore::CCTextureLayerImpl::didLoseContext):
(WebCore::CCTextureLayerImpl::setIOSurfaceProperties):

  • platform/graphics/chromium/cc/CCTextureLayerImpl.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCPluginLayerImpl.h.

(WebCore):
(CCTextureLayerImpl):
(WebCore::CCTextureLayerImpl::create):
(WebCore::CCTextureLayerImpl::textureId):
(WebCore::CCTextureLayerImpl::setTextureId):
(WebCore::CCTextureLayerImpl::setHasAlpha):
(WebCore::CCTextureLayerImpl::setPremultipliedAlpha):
(WebCore::CCTextureLayerImpl::setFlipped):
(WebCore::CCTextureLayerImpl::setUVRect):
(WebCore::CCTextureLayerImpl::layerTypeAsString):

Source/WebKit/chromium:

  • tests/Canvas2DLayerChromiumTest.cpp:
20:00 Changeset [111111] by kubo@profusion.mobi

[EFL] Unreviewed gardening after r111110.

  • platform/efl/Skipped: Unskip fast/canvas/fillText-shadow.html

just like GTK+ did.

19:55 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
19:54 Changeset [111110] by mrobinson@webkit.org

[Cairo] Text extent of shadowed text is calculated incorrectly
https://bugs.webkit.org/show_bug.cgi?id=65035

Source/WebCore:

Reviewed by Martin Robinson.

No new tests. This is already covered by fast/canvas/fillText-shadow.html.

Correct determine the size of rendered text using x and y bearing from the font
extents.

  • platform/graphics/cairo/FontCairo.cpp:

(WebCore::drawGlyphsShadow): Use the x and y bearing to calculate text extents.
This gives a more accurate sizing and avoids clipping the edges of the shadow.

LayoutTests:

Reviewed by Martin Robinson

  • platform/gtk/Skipped: Unskip a test that is now passing.
19:32 Changeset [111109] by haraken@chromium.org

[Chromium][Performance] Optimize innerText and outerText in Chromium/Mac
https://bugs.webkit.org/show_bug.cgi?id=81192

Reviewed by Dimitri Glazkov.

This patch makes innerText and outerText 4 times faster on Chromium/Mac.
A similar performance improvement will be also observed in APIs that are using
TextIterator::plainText() (e.g. Editting, SpellChecker, Clipboard, Pasteboard etc).

Performance test: https://bugs.webkit.org/attachment.cgi?id=131989

  • AppleWebKit/JavaScriptCore/Mac:

div.innerText : 2978.4ms
div.outerText : 2944.4ms

  • Chromium/V8/Mac without the patch:

div.innerText : 10050.8ms
div.outerText : 10072.2ms

  • Chromium/V8/Mac with the patch:

div.innerText: 2536.4ms
div.outerText: 2714ms

This patch just changes the initial buffer size of a plain text buffer on Chromium/Mac.
As shown below, in my local Chromium/Mac environment the performance changes
dramatically between 1<<15 and 1<<16, and in my local Chromium/Linux environment
the performance changes between 1<<17 and 1<<18. I am not yet sure what determines
these figures, but it seems there exists a performance gap at some point
depending on a malloc mechanism.

  • div.innerText results on Chromium/V8/Mac:

WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 14 ==> 2465.6 ms
WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 15 ==> 2447.2 ms <--- after this patch
WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 16 ==> 10250.8 ms <--- before this patch
WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 17 ==> 10278.2 ms

  • div.innerText results on Chromium/V8/Linux:

WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 14 ==> 1569.8 ms
WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 15 ==> 1531.8 ms
WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 16 ==> 1543.2 ms <--- before/after this patch
WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 17 ==> 1541.6 ms
WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 18 ==> 12540.8 ms
WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 19 ==> 12340.8 ms

  • editing/TextIterator.cpp:

(WebCore::plainTextToMallocAllocatedBuffer):

19:27 Changeset [111108] by dimich@chromium.org

HTMLFrameElementBase::m_remainsAliveOnRemovalFromTree can be cleared without unloading the frame.
https://bugs.webkit.org/show_bug.cgi?id=80766

Reviewed by Adam Barth.

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::insertedIntoDocument):
(WebCore::HTMLFrameElementBase::setRemainsAliveOnRemovalFromTree):
if adoptNode() is called on a detached iframe or with a detached document,
unload the iframe to avoid live iframe to hang around w/o being attached to
a document.

19:22 Changeset [111107] by commit-queue@webkit.org

Xcode project file is not sorted.
https://bugs.webkit.org/show_bug.cgi?id=81439

Sorted the project file entries using sort-Xcode-project-file script.

Patch by Joe Thomas <joethomas@motorola.com> on 2012-03-16
Reviewed by Eric Seidel.

  • WebCore.xcodeproj/project.pbxproj:
19:16 Changeset [111106] by yael.aharon@nokia.com

Unreviewed build fix after r111075.
Correct the path of WebKitBlobBuilder.idl.

  • DerivedSources.pri:
19:01 Changeset [111105] by levin@chromium.org

Fix for test runs for non-chromium platforms.

  • loader/cache/MemoryCache.cpp:

(WebCore::memoryCache):
(WebCore::MemoryCache::add):
(WebCore::MemoryCache::revalidationFailed):
(WebCore::MemoryCache::resourceForURL):
(WebCore::MemoryCache::evict):

18:55 Changeset [111104] by commit-queue@webkit.org

Rebaselines for compositing tests with video
https://bugs.webkit.org/show_bug.cgi?id=81430

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-03-16
Reviewed by James Robinson.

  • platform/chromium-linux/compositing/geometry/video-fixed-scrolling-expected.png:
  • platform/chromium-linux/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-linux/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-linux/compositing/self-painting-layers-expected.png:
  • platform/chromium-linux/compositing/visibility/visibility-simple-video-layer-expected.png:
  • platform/chromium-mac-leopard/compositing/geometry/video-fixed-scrolling-expected.png:
  • platform/chromium-mac-leopard/compositing/geometry/video-opacity-overlay-expected.png: Removed.
  • platform/chromium-mac-leopard/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-mac-leopard/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-mac-leopard/compositing/self-painting-layers-expected.png:
  • platform/chromium-mac-snowleopard/compositing/geometry/video-fixed-scrolling-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-mac-snowleopard/compositing/overflow/scroll-ancestor-update-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/self-painting-layers-expected.png: Added.
  • platform/chromium-mac/compositing/geometry/video-fixed-scrolling-expected.png: Added.
  • platform/chromium-mac/compositing/geometry/video-opacity-overlay-expected.png: Added.
  • platform/chromium-mac/compositing/layers-inside-overflow-scroll-expected.png: Added.
  • platform/chromium-mac/compositing/overflow/scroll-ancestor-update-expected.png: Added.
  • platform/chromium-mac/compositing/reflections/load-video-in-reflection-expected.png:
  • platform/chromium-mac/compositing/self-painting-layers-expected.png: Added.
  • platform/chromium-mac/compositing/visibility/visibility-simple-video-layer-expected.png: Added.
  • platform/chromium-win/compositing/geometry/video-fixed-scrolling-expected.png:
  • platform/chromium-win/compositing/layers-inside-overflow-scroll-expected.png:
  • platform/chromium-win/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-win/compositing/overflow/scroll-ancestor-update-expected.txt:
  • platform/chromium-win/compositing/self-painting-layers-expected.png:
  • platform/chromium-win/compositing/visibility/visibility-simple-video-layer-expected.png:
  • platform/chromium/compositing/geometry/video-fixed-scrolling-expected.png: Removed.
  • platform/chromium/compositing/geometry/video-opacity-overlay-expected.png: Removed.
  • platform/chromium/compositing/overflow/scroll-ancestor-update-expected.png: Removed.
  • platform/chromium/compositing/self-painting-layers-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
18:29 Changeset [111103] by tony@chromium.org

Unreviewed, rolling out r111094.
http://trac.webkit.org/changeset/111094
https://bugs.webkit.org/show_bug.cgi?id=80882

broke test on chromium-win

Source/WebCore:

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::alignChildren):

  • rendering/RenderFlexibleBox.h:

(RenderFlexibleBox):

LayoutTests:

  • css3/flexbox/child-overflow-expected.html:
  • css3/flexbox/child-overflow.html:
  • css3/flexbox/flex-align-stretch-expected.txt:
  • css3/flexbox/flex-align-stretch.html:
18:21 Changeset [111102] by andersca@apple.com

REGRESSION (r110737): Height element changes on scrolled page causes failure
https://bugs.webkit.org/show_bug.cgi?id=81381
<rdar://problem/11066006>

Reviewed by Sam Weinig.

Limit the fix made in r110737 to check if there's a rubber-band gesture in progress and only ignore the range if that is the case.

  • platform/ScrollAnimator.h:

(WebCore::ScrollAnimator::isRubberBandInProgress):
(ScrollAnimator):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars):

  • platform/mac/ScrollAnimatorMac.h:

(ScrollAnimatorMac):

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::isRubberBandInProgress):
(WebCore):

  • platform/mac/ScrollElasticityController.h:

(ScrollElasticityController):

  • platform/mac/ScrollElasticityController.mm:

(WebCore::ScrollElasticityController::isRubberBandInProgress):
(WebCore):

17:52 Changeset [111101] by commit-queue@webkit.org

GestureTapDown needs to pin in-progress flings
https://bugs.webkit.org/show_bug.cgi?id=80875

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-16
Reviewed by Adam Barth.

  • page/EventHandler.cpp:

(WebCore):
(WebCore::EventHandler::handleGestureTapDown):

  • page/EventHandler.h:

(EventHandler):

17:49 Changeset [111100] by crogers@google.com

Account for sample-rate in convolution normalization
https://bugs.webkit.org/show_bug.cgi?id=81432

Reviewed by James Robinson.

  • platform/audio/Reverb.cpp:

(WebCore):
(WebCore::calculateNormalizationScale):

  • webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::setBuffer):

17:41 Changeset [111099] by commit-queue@webkit.org

[BlackBerry] Rename the existing WebPageCompositor class to WebPageCompositorPrivate
https://bugs.webkit.org/show_bug.cgi?id=81108
RIM PR: 136687

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-03-16
Reviewed by Rob Buis.

This is done in anticipation of a new WebPageCompositor class in the
public API. The existing internal class will serve to d-pointerize the
new public API. In addition, it is and will be possible to create only
the private class, for cases where existing code paths require
OpenGL compositing (i.e. due to accelerated compositing layers being
added to the page).

Reviewed internally by Robin Cao.

  • Api/BackingStore.h:
  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setIsAcceleratedCompositingActive):

  • Api/WebPageCompositor.cpp: Renamed from Source/WebKit/blackberry/WebKitSupport/WebPageCompositor.cpp.

(BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::~WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::hardwareCompositing):
(BlackBerry::WebKit::WebPageCompositorPrivate::setRootLayer):
(BlackBerry::WebKit::WebPageCompositorPrivate::setBackingStoreUsesOpenGL):
(BlackBerry::WebKit::WebPageCompositorPrivate::commit):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
(BlackBerry::WebKit::WebPageCompositorPrivate::releaseLayerResources):
(BlackBerry::WebKit::WebPageCompositorPrivate::animationTimerFired):

  • Api/WebPageCompositor_p.h: Renamed from Source/WebKit/blackberry/WebKitSupport/WebPageCompositor.h.

(BlackBerry::WebKit::WebPageCompositorPrivate::layoutRectForCompositing):
(BlackBerry::WebKit::WebPageCompositorPrivate::setLayoutRectForCompositing):
(BlackBerry::WebKit::WebPageCompositorPrivate::contentsSizeForCompositing):
(BlackBerry::WebKit::WebPageCompositorPrivate::setContentsSizeForCompositing):
(BlackBerry::WebKit::WebPageCompositorPrivate::lastCompositingResults):
(BlackBerry::WebKit::WebPageCompositorPrivate::setLastCompositingResults):

  • Api/WebPage_p.h:
  • CMakeListsBlackBerry.txt:
17:31 Changeset [111098] by tsepez@chromium.org

Make V8 window.open.call(), window.open.showModalDialog() results more closely match JSC.
https://bugs.webkit.org/show_bug.cgi?id=81260
https://bugs.webkit.org/show_bug.cgi?id=39897

Reviewed by Adam Barth.

Source/WebCore:

Tested via http/tests/security/cross-frame-access-call.htm

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::showModalDialogCallback):
(WebCore::V8DOMWindow::openCallback):

LayoutTests:

  • http/tests/security/cross-frame-access-call-expected.txt:
  • http/tests/security/cross-frame-access-call.html:
  • http/tests/security/cross-frame-access-get-expected.txt:
  • http/tests/security/cross-frame-access-get.html:
  • platform/chromium/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
  • platform/chromium/http/tests/security/cross-frame-access-call-expected.txt:
17:29 Changeset [111097] by slewis@apple.com

Source/WebKit2: https://bugs.webkit.org/show_bug.cgi?id=81065
<rdar://problem/10944309> CrashTracer: [USER] 111 crashes in WebProcess at WebKitTestRunnerInjectedBundle: WTR::InjectedBundle::done + 142
Add some string function exports to Windows so the WebKitTestRunner can use them.

Reviewed by Geoff Garen.

  • win/WebKit2.def:

Tools: https://bugs.webkit.org/show_bug.cgi?id=81065
<rdar://problem/10944309> CrashTracer: [USER] 111 crashes in WebProcess at WebKitTestRunnerInjectedBundle: WTR::InjectedBundle::done + 142
Fix crash preventing WebKitTestRunner from working in Release.
WebKitTestRunner used ostringstream to collect output from the test. ostringstream is incompatible with our
FastMalloc overrides. When copying strings out ostringstream a new string is allocated with FastMalloc because
the allocation is inlined. When that string is freed is uses the system malloc because that call is not inlined.

I removed ostringstream in favor of StringBuilder.

Properly set NDEBUG on Release builds so we don't crash when when we free the strings StringBuilder created.

Reviewed by Geoff Garen.

Add DEBUG_DEFINES to set NDEBUG on release builds.

  • WebKitTestRunner/Configurations/Base.xcconfig:
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

Remove ostringstream member in favor of StringBuilder.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::initialize):
(WTR::InjectedBundle::beginTesting):
(WTR::InjectedBundle::done):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(WTF):
(WTR::InjectedBundle::stringBuilder):
(InjectedBundle):

Append output to StringBuilder.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::hasPrefix):
(WTR::dumpPath):
(WTR::rangeToStr):
(WTR::styleDecToStr):
(WTR::frameToStr):
(WTR::dumpFrameScrollPosition):
(WTR::dumpFrameText):
(WTR::dumpDescendantFramesText):
(WTR::InjectedBundlePage::dump):
(WTR::InjectedBundlePage::didReceiveTitleForFrame):
(WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
(WTR::InjectedBundlePage::willSendRequestForFrame):
(WTR::InjectedBundlePage::decidePolicyForNavigationAction):
(WTR::lastFileURLPathComponent):
(WTR::InjectedBundlePage::willAddMessageToConsole):
(WTR::InjectedBundlePage::willSetStatusbarText):
(WTR::InjectedBundlePage::willRunJavaScriptAlert):
(WTR::InjectedBundlePage::willRunJavaScriptConfirm):
(WTR::InjectedBundlePage::willRunJavaScriptPrompt):
(WTR::InjectedBundlePage::shouldBeginEditing):
(WTR::InjectedBundlePage::shouldEndEditing):
(WTR::InjectedBundlePage::shouldInsertNode):
(WTR::InjectedBundlePage::shouldInsertText):
(WTR::InjectedBundlePage::shouldDeleteRange):
(WTR::InjectedBundlePage::shouldChangeSelectedRange):
(WTR::InjectedBundlePage::shouldApplyStyle):
(WTR::InjectedBundlePage::didBeginEditing):
(WTR::InjectedBundlePage::didEndEditing):
(WTR::InjectedBundlePage::didChange):
(WTR::InjectedBundlePage::didChangeSelection):
(WTR::InjectedBundlePage::supportsFullScreen):
(WTR::InjectedBundlePage::enterFullScreenForElement):
(WTR::InjectedBundlePage::exitFullScreenForElement):
(WTR::InjectedBundlePage::beganEnterFullScreen):
(WTR::InjectedBundlePage::beganExitFullScreen):
(WTR::dumpBackForwardListItem):
(WTR::InjectedBundlePage::dumpBackForwardList):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::waitToDumpWatchdogTimerFired):
(WTR::LayoutTestController::dumpConfigurationForViewport):

Convert between WTF::String and WKStringRef.

  • WebKitTestRunner/StringFunctions.h:

(WTR::toWTFString):
(WTR):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

17:27 Changeset [111096] by mlilek@apple.com

Use modern NSNumberFormatter API in LocalizedNumberMac.mm
https://bugs.webkit.org/show_bug.cgi?id=81429

Reviewed by Dan Bernstein.

No new tests as no change in behavior.

  • platform/text/mac/LocalizedNumberMac.mm:

(WebCore::createFormatterForCurrentLocaleForDisplay):

17:19 Changeset [111095] by eric@webkit.org

Add a land-from-url command
https://bugs.webkit.org/show_bug.cgi?id=81411

Reviewed by Adam Barth.

Very basic so far. The goal is to make it landing smarter
so that users don't have to bother to parse out the ids out of the urls.

  • Scripts/webkitpy/common/config/urls.py:

(parse_bug_id):
(parse_attachment_id):

  • Scripts/webkitpy/common/config/urls_unittest.py:

(URLsTest.test_parse_bug_id):
(URLsTest):
(URLsTest.test_parse_attachment_id):

  • Scripts/webkitpy/tool/commands/download.py:

(ProcessURLsMixin):
(ProcessURLsMixin._fetch_list_of_patches_to_process):
(LandFromURL):

  • Scripts/webkitpy/tool/commands/download_unittest.py:

(test_land_from_bug):
(test_land_from_url):

17:16 Changeset [111094] by tony@chromium.org

flex-item-align: stretch should only grow, never shrink
https://bugs.webkit.org/show_bug.cgi?id=80882

Reviewed by Ojan Vafai.

Source/WebCore:

New test cases in css3/flexbox/flex-align-stretch.html.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::alignChildren): Move stretch code into a separate function.
(WebCore::RenderFlexibleBox::alignChildStretch): Add an early return if our height is shrinking.
(WebCore):

  • rendering/RenderFlexibleBox.h:

(RenderFlexibleBox):

LayoutTests:

  • css3/flexbox/child-overflow-expected.html:
  • css3/flexbox/child-overflow.html: For cases that overflow the height, we now just overflow rather than reducing the height.
  • css3/flexbox/flex-align-stretch-expected.txt:
  • css3/flexbox/flex-align-stretch.html: New test cases.
17:13 Changeset [111093] by commit-queue@webkit.org

build-webkit launcher instructions use wrong relative path for Qt
https://bugs.webkit.org/show_bug.cgi?id=81357

Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-03-16
Reviewed by Eric Seidel.

Ensure we are at the proper directory before generating run-launcher
instructions.

  • Scripts/build-webkit:
17:10 Changeset [111092] by lforschler@apple.com

Versioning.

17:10 Changeset [111091] by kubo@profusion.mobi

[EFL] Unreviewed, fix build after r111041.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::emitMediaButtonSignal): Rename
MediaFullscreenButton to MediaEnterFullscreenButton.
(WebCore::RenderThemeEfl::paintMediaFullscreenButton): Ditto.

16:49 Changeset [111090] by dcheng@chromium.org

Add layout tests that accidentally got left out of r111061

  • fast/events/clipboard-dataTransferItemList-expected.txt: Added.
  • fast/events/clipboard-dataTransferItemList.html: Added.
  • fast/events/drag-dataTransferItemList-expected.txt: Added.
  • fast/events/drag-dataTransferItemList.html: Added.
16:49 Changeset [111089] by dslomov@google.com

REGRESSION: DOMURL::revokeObjectURL accesses memoryCache on worker thread.
https://bugs.webkit.org/show_bug.cgi?id=80889
On worker threads, post a task to main thread to evict from cache.
ASSERT that MemoryCache is only accessed from main thread.

Reviewed by David Levin.

  • html/DOMURL.cpp:

(WebCore::DOMURL::revokeObjectURL):

  • loader/cache/MemoryCache.cpp:

(WebCore::memoryCache):
(WebCore::MemoryCache::add):
(WebCore::MemoryCache::revalidationFailed):
(WebCore::MemoryCache::resourceForURL):
(WebCore::MemoryCache::evict):
(WebCore):
(WebCore::MemoryCache::removeUrlFromCache):
(WebCore::MemoryCache::removeUrlFromCacheImpl):

  • loader/cache/MemoryCache.h:

(WebCore):
(MemoryCache):

16:47 Changeset [111088] by commit-queue@webkit.org

[BlackBerry] Upstream ScriptControllerBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=81397

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-03-16
Reviewed by Rob Buis.

Initial upstream, no new tests.

  • bindings/js/ScriptControllerBlackBerry.cpp: Added.
16:46 Changeset [111087] by commit-queue@webkit.org

[BlackBerry] Syncing up left over bits in WebKitSupport from our local branch to upstream
https://bugs.webkit.org/show_bug.cgi?id=81118

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-03-16
Reviewed by Rob Buis.

This is a consolidation of various changes that are in our local dev branch
but do not appear in our upstreamed port.

  • WebKitSupport/DumpRenderTreeSupport.cpp:

(DumpRenderTreeSupport::computedStyleIncludingVisitedInfo):

  • WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::isElementClickable):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::spannableTextInRange):

  • WebKitSupport/SurfacePool.cpp:

(BlackBerry::WebKit::SurfacePool::createBuffers):
(BlackBerry::WebKit::SurfacePool::releaseBuffers):

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
(BlackBerry::WebKit::TouchEventHandler::handleFatFingerPressed):

  • WebKitSupport/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):

  • WebKitSupport/WebPageCompositor.h:

(WebPageCompositor):

16:41 Changeset [111086] by abarth@webkit.org

remove-body-during-body-replacement2.html is triggering crashes on all platforms
https://bugs.webkit.org/show_bug.cgi?id=81374

Reviewed by Eric Seidel.

When overriding disconnectFrame, we need to call the base class version
of the method so that it can clear the m_frame pointer.

Tests: This patch fixes a large number of crashes in tests.

  • notifications/DOMWindowNotifications.cpp:

(WebCore::DOMWindowNotifications::disconnectFrame):

16:27 Changeset [111085] by leo.yang@torchmobile.com.cn

[BlackBerry] Upstream the BlackBerry change to platform/Widget.h
https://bugs.webkit.org/show_bug.cgi?id=81304

Reviewed by Rob Buis.

typedefs of PlatformWidget and PlatformPageClient for the BlackBerry.

  • platform/Widget.h:
16:22 Changeset [111084] by lforschler@apple.com

Merged r111081.

16:12 Changeset [111083] by commit-queue@webkit.org

MathML internals - factor code for almost anonymous blocks
https://bugs.webkit.org/show_bug.cgi?id=81387

Patch by David Barton <dbarton@mathscribe.com> on 2012-03-16
Reviewed by Eric Seidel.

Source/WebCore:

MathML uses "almost anonymous" blocks to layout parts of mathematical expressions. These
will be converted to true anonymous blocks in a later patch. Here we factor out the code
to create them into RenderMathMLBlock::createAlmostAnonymousBlock().

No new tests. Some tree dump output is modified for existing tests. <munder>, <mover>,
and <munderover> renderers already used true anonymous blocks, so we change them to call
RenderBlock::createAnonymousBlock(). In the other direction, <mroot>'s almost anonymous
blocks are now made RenderMathMLBlock not just RenderBlock, in agreement with other
current MathML renderers.

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::createAlmostAnonymousBlock):

  • rendering/mathml/RenderMathMLBlock.h:

(RenderMathMLBlock):
(WebCore::RenderMathMLBlock::getBoxModelObjectWidth):

  • rendering/mathml/RenderMathMLFenced.cpp:

(WebCore::RenderMathMLFenced::addChild):

  • rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::updateFromElement):

  • improve some variable names

(WebCore::RenderMathMLFraction::addChild):
(WebCore::RenderMathMLFraction::layout):
(WebCore::RenderMathMLFraction::paint):
(WebCore::RenderMathMLFraction::baselinePosition):

  • rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::addChild):

  • rendering/mathml/RenderMathMLSubSup.cpp:

(WebCore::RenderMathMLSubSup::addChild):

  • rendering/mathml/RenderMathMLSubSup.h:
  • rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore::RenderMathMLUnderOver::addChild):

LayoutTests:

  • platform/mac/mathml/presentation/mo-stretch-expected.txt:
  • platform/mac/mathml/presentation/over-expected.txt:
  • platform/mac/mathml/presentation/roots-expected.txt:
  • platform/mac/mathml/presentation/row-alignment-expected.txt:
  • platform/mac/mathml/presentation/under-expected.txt:
  • platform/mac/mathml/presentation/underover-expected.txt:
16:05 Changeset [111082] by leviw@chromium.org

Prepare RenderObject for FractionalLayoutUnits
https://bugs.webkit.org/show_bug.cgi?id=81178

Reviewed by Eric Seidel.

This readies RenderObject to deal with FractionalLayoutUnits as a backend for the
LayoutUnit abstraction.

No new tests. No change in behavior.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::pixelSnappedAbsoluteClippedOverflowRect): Convenience method to be
used instead of absouluteClippedOverflowRect in platform code. Platform updates will come
in a separate patch.
(WebCore):
(WebCore::RenderObject::repaintAfterLayoutIfNeeded): Borders remain ints when we move to
sub-pixel layout. This adjusts border variables for this, and adds compiler fixes when
using std::max and std::min with mixed int/LayoutUnits.
(WebCore::RenderObject::adjustRectForOutlineAndShadow): Outlines, like borders, remain
ints in the new sub-pixel world. Using variables that reflect that.

  • rendering/RenderObject.h:

(RenderObject):
(WebCore::adjustForAbsoluteZoom): Handles FractionalLayoutUnit values. Flooring is what
JavaScript requires since this is used with values that must return ints.
(WebCore): Adding FractionalLayoutUnit.h to support the new adjusteForAbsoluteZoom method.

16:04 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
15:52 Changeset [111081] by lforschler@apple.com

Remove a bogus assert that was merged in from ToT. It is not needed on this branch.

Reviewed by Filip Pizlo.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::addValueProfile):

15:29 Changeset [111080] by beidson@apple.com

<rdar://problem/11027997> and https://bugs.webkit.org/show_bug.cgi?id=81412 REGRESSION (r107435) Copy a link and paste to Mail: Nothing is pasted

Reviewed by Geoff Garen.

Source/WebCore:

WebKit API test WebViewCanPasteURL.mm added.

  • WebCore.exp.in:

Add a strategy method specifically for getting the URL:

  • platform/PasteboardStrategy.h:

Use that strategy method when creating the fragment for a URL:

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::documentFragment):

Add a platform pasteboard accessor to "do the right thing" for getting a URL:

  • platform/PlatformPasteboard.h:
  • platform/mac/PlatformPasteboardMac.mm:

(WebCore::PlatformPasteboard::url):

Source/WebKit/mac:

  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::setInsertionPasteboard):

  • WebCoreSupport/WebPlatformStrategies.h:

(WebPlatformStrategies):

  • WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::url):

Source/WebKit2:

Add new message so the WebProcess can ask the UIProcesses pasteboard for the URL:

  • UIProcess/WebContext.h:
  • UIProcess/WebContext.messages.in:
  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::getPasteboardURL):

Use that new message to implement the pasteboard strategy:

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::url):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:

(WebPlatformStrategies):

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/WebViewCanPasteURL.mm: Added.
15:26 Changeset [111079] by commit-queue@webkit.org

<http://webkit.org/b/81380> clang warning unused variable when ENABLE(TEXT_CARET) is disabled

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-03-16
Reviewed by Dan Bernstein.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::recomputeCaretRect):
Put the variable inside of a guard because it is only
used inside of a guard.

15:23 Changeset [111078] by ojan@chromium.org

Fix some tests that broke with r111042.

  • platform/chromium-linux-x86/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-linux/compositing/absolute-position-changed-with-composited-parent-layer-expected.png: Added.
  • platform/chromium-linux/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-mac-leopard/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-animated-expected.txt: Removed.
  • platform/chromium-win-vista/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.txt: Removed.
  • platform/chromium-win/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-win/compositing/reflections/nested-reflection-animated-expected.txt:
15:19 Changeset [111077] by ojan@chromium.org

Mark wontfix tests in full_results.json so we can ignore them in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=81407

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(summarize_results):

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ResultSummaryTest.summarized_results):
(ResultSummaryTest.test_no_svn_revision):
(ResultSummaryTest.test_svn_revision):
(ResultSummaryTest):
(ResultSummaryTest.test_summarized_results_wontfix):

15:03 Changeset [111076] by kling@webkit.org

Shrink BorderValue.
<http://webkit.org/b/69521>

Reviewed by Anders Carlsson.

Split BorderValue's Color member into RGBA32/bool buddies and stash the bool in
the BorderValue bitfield.

This shrinks BorderValue by 4 bytes, in turn shrinking BorderData by 16 bytes.
Altogether this yields ~800 kB in reduced memory consumption when viewing the full
HTML5 spec at <http://whatwg.org/c>

  • rendering/style/BorderValue.h:

(WebCore::BorderValue::BorderValue):
(WebCore::BorderValue::isTransparent):
(WebCore::BorderValue::operator==):
(BorderValue):
(WebCore::BorderValue::setColor):
(WebCore::BorderValue::color):

  • rendering/style/OutlineValue.h:

(WebCore::OutlineValue::operator==):

  • rendering/style/RenderStyle.cpp:

(SameSizeAsBorderValue):

  • rendering/style/RenderStyle.h:
15:00 Changeset [111075] by commit-queue@webkit.org

Moves remaining filesystem files to Modules/filesystem/
https://bugs.webkit.org/show_bug.cgi?id=81353

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-03-16
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Modules/filesystem/AsyncFileWriter.h: Copied from Source/WebCore/fileapi/AsyncFileWriter.h.
  • Modules/filesystem/AsyncFileWriterClient.h: Copied from Source/WebCore/fileapi/AsyncFileWriterClient.h.
  • Modules/filesystem/DOMFilePath.cpp: Copied from Source/WebCore/fileapi/DOMFilePath.cpp.
  • Modules/filesystem/DOMFilePath.h: Copied from Source/WebCore/fileapi/DOMFilePath.h.
  • Modules/filesystem/DOMFileSystem.cpp: Copied from Source/WebCore/fileapi/DOMFileSystem.cpp.
  • Modules/filesystem/DOMFileSystem.h: Copied from Source/WebCore/fileapi/DOMFileSystem.h.
  • Modules/filesystem/DOMFileSystem.idl: Copied from Source/WebCore/fileapi/DOMFileSystem.idl.
  • Modules/filesystem/DOMFileSystemBase.cpp: Copied from Source/WebCore/fileapi/DOMFileSystemBase.cpp.
  • Modules/filesystem/DOMFileSystemBase.h: Copied from Source/WebCore/fileapi/DOMFileSystemBase.h.
  • Modules/filesystem/DOMFileSystemSync.cpp: Copied from Source/WebCore/fileapi/DOMFileSystemSync.cpp.
  • Modules/filesystem/DOMFileSystemSync.h: Copied from Source/WebCore/fileapi/DOMFileSystemSync.h.
  • Modules/filesystem/DOMFileSystemSync.idl: Copied from Source/WebCore/fileapi/DOMFileSystemSync.idl.
  • Modules/filesystem/Entry.cpp: Copied from Source/WebCore/fileapi/Entry.cpp.
  • Modules/filesystem/Entry.h: Copied from Source/WebCore/fileapi/Entry.h.
  • Modules/filesystem/Entry.idl: Copied from Source/WebCore/fileapi/Entry.idl.
  • Modules/filesystem/EntryArray.cpp: Copied from Source/WebCore/fileapi/EntryArray.cpp.
  • Modules/filesystem/EntryArray.h: Copied from Source/WebCore/fileapi/EntryArray.h.
  • Modules/filesystem/EntryArray.idl: Copied from Source/WebCore/fileapi/EntryArray.idl.
  • Modules/filesystem/EntryArraySync.cpp: Copied from Source/WebCore/fileapi/EntryArraySync.cpp.
  • Modules/filesystem/EntryArraySync.h: Copied from Source/WebCore/fileapi/EntryArraySync.h.
  • Modules/filesystem/EntryArraySync.idl: Copied from Source/WebCore/fileapi/EntryArraySync.idl.
  • Modules/filesystem/EntryBase.cpp: Copied from Source/WebCore/fileapi/EntryBase.cpp.
  • Modules/filesystem/EntryBase.h: Copied from Source/WebCore/fileapi/EntryBase.h.
  • Modules/filesystem/EntryCallback.h: Copied from Source/WebCore/fileapi/EntryCallback.h.
  • Modules/filesystem/EntryCallback.idl: Copied from Source/WebCore/fileapi/EntryCallback.idl.
  • Modules/filesystem/EntrySync.cpp: Copied from Source/WebCore/fileapi/EntrySync.cpp.
  • Modules/filesystem/EntrySync.h: Copied from Source/WebCore/fileapi/EntrySync.h.
  • Modules/filesystem/EntrySync.idl: Copied from Source/WebCore/fileapi/EntrySync.idl.
  • Modules/filesystem/ErrorCallback.h: Copied from Source/WebCore/fileapi/ErrorCallback.h.
  • Modules/filesystem/ErrorCallback.idl: Copied from Source/WebCore/fileapi/ErrorCallback.idl.
  • Modules/filesystem/FileCallback.h: Copied from Source/WebCore/fileapi/FileCallback.h.
  • Modules/filesystem/FileCallback.idl: Copied from Source/WebCore/fileapi/FileCallback.idl.
  • Modules/filesystem/FileEntry.cpp: Copied from Source/WebCore/fileapi/FileEntry.cpp.
  • Modules/filesystem/FileEntry.h: Copied from Source/WebCore/fileapi/FileEntry.h.
  • Modules/filesystem/FileEntry.idl: Copied from Source/WebCore/fileapi/FileEntry.idl.
  • Modules/filesystem/FileEntrySync.cpp: Copied from Source/WebCore/fileapi/FileEntrySync.cpp.
  • Modules/filesystem/FileEntrySync.h: Copied from Source/WebCore/fileapi/FileEntrySync.h.
  • Modules/filesystem/FileEntrySync.idl: Copied from Source/WebCore/fileapi/FileEntrySync.idl.
  • Modules/filesystem/FileSystemCallback.h: Copied from Source/WebCore/fileapi/FileSystemCallback.h.
  • Modules/filesystem/FileSystemCallback.idl: Copied from Source/WebCore/fileapi/FileSystemCallback.idl.
  • Modules/filesystem/FileSystemCallbacks.cpp: Copied from Source/WebCore/fileapi/FileSystemCallbacks.cpp.
  • Modules/filesystem/FileSystemCallbacks.h: Copied from Source/WebCore/fileapi/FileSystemCallbacks.h.
  • Modules/filesystem/FileWriter.cpp: Copied from Source/WebCore/fileapi/FileWriter.cpp.
  • Modules/filesystem/FileWriter.h: Copied from Source/WebCore/fileapi/FileWriter.h.
  • Modules/filesystem/FileWriter.idl: Copied from Source/WebCore/fileapi/FileWriter.idl.
  • Modules/filesystem/FileWriterBase.cpp: Copied from Source/WebCore/fileapi/FileWriterBase.cpp.
  • Modules/filesystem/FileWriterBase.h: Copied from Source/WebCore/fileapi/FileWriterBase.h.
  • Modules/filesystem/FileWriterBaseCallback.h: Copied from Source/WebCore/fileapi/FileWriterBaseCallback.h.
  • Modules/filesystem/FileWriterCallback.h: Copied from Source/WebCore/fileapi/FileWriterCallback.h.
  • Modules/filesystem/FileWriterCallback.idl: Copied from Source/WebCore/fileapi/FileWriterCallback.idl.
  • Modules/filesystem/FileWriterSync.cpp: Copied from Source/WebCore/fileapi/FileWriterSync.cpp.
  • Modules/filesystem/FileWriterSync.h: Copied from Source/WebCore/fileapi/FileWriterSync.h.
  • Modules/filesystem/FileWriterSync.idl: Copied from Source/WebCore/fileapi/FileWriterSync.idl.
  • Modules/filesystem/LocalFileSystem.cpp: Copied from Source/WebCore/fileapi/LocalFileSystem.cpp.
  • Modules/filesystem/LocalFileSystem.h: Copied from Source/WebCore/fileapi/LocalFileSystem.h.
  • Modules/filesystem/Metadata.h: Copied from Source/WebCore/fileapi/Metadata.h.
  • Modules/filesystem/Metadata.idl: Copied from Source/WebCore/fileapi/Metadata.idl.
  • Modules/filesystem/MetadataCallback.h: Copied from Source/WebCore/fileapi/MetadataCallback.h.
  • Modules/filesystem/MetadataCallback.idl: Copied from Source/WebCore/fileapi/MetadataCallback.idl.
  • Modules/filesystem/SyncCallbackHelper.h: Copied from Source/WebCore/fileapi/SyncCallbackHelper.h.
  • Modules/filesystem/WebKitFlags.h: Copied from Source/WebCore/fileapi/WebKitFlags.h.
  • Modules/filesystem/WorkerContextFileSystem.cpp: Copied from Source/WebCore/fileapi/WorkerContextFileSystem.cpp.
  • Modules/filesystem/WorkerContextFileSystem.h: Copied from Source/WebCore/fileapi/WorkerContextFileSystem.h.
  • Modules/filesystem/WorkerContextFileSystem.idl: Copied from Source/WebCore/fileapi/WorkerContextFileSystem.idl.
  • Target.pri:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • fileapi/AsyncFileWriter.h: Removed.
  • fileapi/AsyncFileWriterClient.h: Removed.
  • fileapi/DOMFilePath.cpp: Removed.
  • fileapi/DOMFilePath.h: Removed.
  • fileapi/DOMFileSystem.cpp: Removed.
  • fileapi/DOMFileSystem.h: Removed.
  • fileapi/DOMFileSystem.idl: Removed.
  • fileapi/DOMFileSystemBase.cpp: Removed.
  • fileapi/DOMFileSystemBase.h: Removed.
  • fileapi/DOMFileSystemSync.cpp: Removed.
  • fileapi/DOMFileSystemSync.h: Removed.
  • fileapi/DOMFileSystemSync.idl: Removed.
  • fileapi/Entry.cpp: Removed.
  • fileapi/Entry.h: Removed.
  • fileapi/Entry.idl: Removed.
  • fileapi/EntryArray.cpp: Removed.
  • fileapi/EntryArray.h: Removed.
  • fileapi/EntryArray.idl: Removed.
  • fileapi/EntryArraySync.cpp: Removed.
  • fileapi/EntryArraySync.h: Removed.
  • fileapi/EntryArraySync.idl: Removed.
  • fileapi/EntryBase.cpp: Removed.
  • fileapi/EntryBase.h: Removed.
  • fileapi/EntryCallback.h: Removed.
  • fileapi/EntryCallback.idl: Removed.
  • fileapi/EntrySync.cpp: Removed.
  • fileapi/EntrySync.h: Removed.
  • fileapi/EntrySync.idl: Removed.
  • fileapi/ErrorCallback.h: Removed.
  • fileapi/ErrorCallback.idl: Removed.
  • fileapi/FileCallback.h: Removed.
  • fileapi/FileCallback.idl: Removed.
  • fileapi/FileEntry.cpp: Removed.
  • fileapi/FileEntry.h: Removed.
  • fileapi/FileEntry.idl: Removed.
  • fileapi/FileEntrySync.cpp: Removed.
  • fileapi/FileEntrySync.h: Removed.
  • fileapi/FileEntrySync.idl: Removed.
  • fileapi/FileSystemCallback.h: Removed.
  • fileapi/FileSystemCallback.idl: Removed.
  • fileapi/FileSystemCallbacks.cpp: Removed.
  • fileapi/FileSystemCallbacks.h: Removed.
  • fileapi/FileWriter.cpp: Removed.
  • fileapi/FileWriter.h: Removed.
  • fileapi/FileWriter.idl: Removed.
  • fileapi/FileWriterBase.cpp: Removed.
  • fileapi/FileWriterBase.h: Removed.
  • fileapi/FileWriterBaseCallback.h: Removed.
  • fileapi/FileWriterCallback.h: Removed.
  • fileapi/FileWriterCallback.idl: Removed.
  • fileapi/FileWriterSync.cpp: Removed.
  • fileapi/FileWriterSync.h: Removed.
  • fileapi/FileWriterSync.idl: Removed.
  • fileapi/LocalFileSystem.cpp: Removed.
  • fileapi/LocalFileSystem.h: Removed.
  • fileapi/Metadata.h: Removed.
  • fileapi/Metadata.idl: Removed.
  • fileapi/MetadataCallback.h: Removed.
  • fileapi/MetadataCallback.idl: Removed.
  • fileapi/SyncCallbackHelper.h: Removed.
  • fileapi/WebKitFlags.h: Removed.
  • fileapi/WorkerContextFileSystem.cpp: Removed.
  • fileapi/WorkerContextFileSystem.h: Removed.
  • fileapi/WorkerContextFileSystem.idl: Removed.
14:54 Changeset [111074] by commit-queue@webkit.org

Collapse ENABLE(BLOB)|ENABLE(FILE_SYSTEM) to just ENABLE(BLOB) in OperationNotAllowedException.idl
https://bugs.webkit.org/show_bug.cgi?id=81391

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-03-16
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • fileapi/OperationNotAllowedException.idl:
14:49 Changeset [111073] by timothy_horton@apple.com

scrollbars/scrollbar-middleclick-nopaste.html times out on mac WK1
https://bugs.webkit.org/show_bug.cgi?id=81410

Skip scrollbars/scrollbar-middleclick-nopaste.html on Mac.

  • platform/mac/Skipped:
14:47 Changeset [111072] by jberlin@webkit.org

plugins/netscape-plugin-setwindow-size-2.html and plugins/resize-from-plugin.html failing on Lion Intel Debug WebKit2 testers
https://bugs.webkit.org/show_bug.cgi?id=81405

Add expected failing results for mac-wk2 to get the bots green.

  • platform/mac-wk2/plugins/netscape-plugin-setwindow-size-2-expected.txt: Added.
  • platform/mac-wk2/plugins/resize-from-plugin-expected.txt: Added.
14:47 Changeset [111071] by jberlin@webkit.org

plugins/npruntime/browser-object-identity.html failing on Lion Intel Debug WebKit2 testers
https://bugs.webkit.org/show_bug.cgi?id=81403

Add expected failing results for mac-wk2 to get the bots green.

  • platform/mac-wk2/plugins/npruntime/browser-object-identity-expected.txt: Added.
14:47 Changeset [111070] by jberlin@webkit.org

plugins/refcount-leaks.html failing on Lion Intel Debug WebKit2 testers
https://bugs.webkit.org/show_bug.cgi?id=81400

Add expected failing results for mac-wk2 to get the bots green.

  • platform/mac-wk2/plugins/refcount-leaks-expected.txt: Added.
14:47 Changeset [111069] by jberlin@webkit.org

plugins/crash-restoring-plugin-page-from-page-cache.html and
plugins/netscape-plugin-page-cache-works.html timing out on Intel Debug WebKit2 testers
https://bugs.webkit.org/show_bug.cgi?id=81392

Skip these tests for WK2.

  • platform/wk2/Skipped:
14:40 Changeset [111068] by lforschler@apple.com

Merged r107102.

14:37 Changeset [111067] by lforschler@apple.com

Merge 106977.

14:30 Changeset [111066] by eae@chromium.org

Fix rounding and usage of LayoutUnits in RenderBoxModelObject
https://bugs.webkit.org/show_bug.cgi?id=81057

Reviewed by Julien Chaffraix.

No new tests.

(WebCore):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::pixelSnappedOffsetWidth):
(WebCore::RenderBoxModelObject::pixelSnappedOffsetHeight):
Fix implementation of pixelSnappedOffsetWidth/Height. The location
parameter will be ignored until we enable subpixel support.

(WebCore::RenderBoxModelObject::paintFillLayerExtended):
Use ints for border widths.

(WebCore::resolveWidthForRatio):
(WebCore::resolveHeightForRatio):
(WebCore::resolveAgainstIntrinsicWidthOrHeightAndRatio):
(WebCore::resolveAgainstIntrinsicRatio):
Change resolve*Ratio methods to operate on IntSizes as none of the
callers need subpixel precision.

(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
(WebCore::RenderBoxModelObject::paintNinePieceImage):
Pixel snap paintRect when computing image geometry.

14:19 Changeset [111065] by timothy_horton@apple.com

Unreviewed new mac baselines after http://trac.webkit.org/changeset/108185

  • platform/mac/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png: Added.
  • platform/mac/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.txt: Added.
  • platform/mac/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png: Added.
  • platform/mac/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.txt: Added.
  • platform/mac/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png: Added.
  • platform/mac/fast/css/relative-positioned-block-nested-with-inline-parent-expected.txt: Added.
  • platform/mac/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png: Added.
  • platform/mac/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.txt: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.txt: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.txt: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.txt: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-ancestor-expected.png: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-ancestor-expected.txt: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.txt: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.txt: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png: Added.
  • platform/mac/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.txt: Added.
14:15 Changeset [111064] by commit-queue@webkit.org

100% height elements to not respond to vertical browser rescaling
https://bugs.webkit.org/show_bug.cgi?id=43022

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-03-16
Reviewed by Julien Chaffraix.

Source/WebCore:

Test: fast/replaced/vertical-resize-100percent-element.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalHeightUsing):

For the case where a replaced element has a percentage height,
we update the entries in RenderBlock::gPercentHeightDescendantsMap
corresponding to all ancestors of the replaced element.

LayoutTests:

  • fast/replaced/resources/vertical-resize-100percent-contents.html: Added.
  • fast/replaced/vertical-resize-100percent-element-expected.txt: Added.
  • fast/replaced/vertical-resize-100percent-element.html: Added.

Layout test to ensure that an image with 100% height is resized when
its containing iframe is vertically resized to be larger or smaller.

  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:

Rebaseline for chromium. This patch causes a progression in this layout test. In the
diff, note that the viewport has height 585, which is 600 minus 15 pixels to account for
the horizontal scrollbar. In the old expected output the first image to be displayed
has height 600, which is incorrect because it should be 100% of the viewport height.
The new expected output shows the first image with the correct height of 585.

  • platform/chromium/test_expectations.txt:

WIN will need a regenerated image, and MAC will need a regenerated image+text.

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

Skip the rebaselined test on all other platforms.

14:08 Changeset [111063] by leviw@chromium.org

Unreviewed gardening. Marking media/track/track-active-cues.html as flaky timeout on windows.

  • platform/chromium/test_expectations.txt:
13:53 Changeset [111062] by lforschler@apple.com

Merged r103880.

13:53 Changeset [111061] by dcheng@chromium.org

[chromium] Refactor ClipboardChromium and DataTransferItemList/DataTransferItem to support HTML spec
https://bugs.webkit.org/show_bug.cgi?id=76598

Reviewed by Tony Chang.

Source/WebCore:

We no longer store drag/clipboard data in named fields. We used to maintain the data store
list separately, which resulted in a lot of complicated code to try to make sure that
ChromiumDataObject and this list stayed in sync. We now just store what is essentially a
list MIME type/data pairs directly in ChromiumDataObject. This has the benefit of letting us
easily add write support during dragstart/copy operations using DataTransferItemList.

Tests: fast/events/clipboard-dataTransferItemList.html

fast/events/drag-dataTransferItemList.html

  • platform/chromium/ChromiumDataObject.cpp:

(WebCore::findItem):
(WebCore::ChromiumDataObject::createFromPasteboard):
(WebCore::ChromiumDataObject::create):
(WebCore::ChromiumDataObject::copy):
(WebCore::ChromiumDataObject::items):
(WebCore::ChromiumDataObject::clearData):
(WebCore::ChromiumDataObject::clearAll):
(WebCore::ChromiumDataObject::clearAllExceptFiles):
(WebCore::ChromiumDataObject::types):
(WebCore::ChromiumDataObject::getData):
(WebCore::ChromiumDataObject::setData):
(WebCore::ChromiumDataObject::urlAndTitle):
(WebCore::ChromiumDataObject::setURLAndTitle):
(WebCore::ChromiumDataObject::htmlAndBaseURL):
(WebCore::ChromiumDataObject::setHTMLAndBaseURL):
(WebCore::ChromiumDataObject::containsFilenames):
(WebCore):
(WebCore::ChromiumDataObject::filenames):
(WebCore::ChromiumDataObject::addFilename):
(WebCore::ChromiumDataObject::addSharedBuffer):
(WebCore::ChromiumDataObject::ChromiumDataObject):

  • platform/chromium/ChromiumDataObject.h:

(WebCore):
(ChromiumDataObject):

  • platform/chromium/ClipboardChromium.cpp:

(WebCore::normalizeType):
(WebCore::ClipboardChromium::ClipboardChromium):
(WebCore::ClipboardChromium::clearData):
(WebCore::ClipboardChromium::clearAllData):
(WebCore::ClipboardChromium::getData):
(WebCore::ClipboardChromium::setData):
(WebCore::ClipboardChromium::types):
(WebCore::ClipboardChromium::files):
(WebCore::writeImageToDataObject):
(WebCore::ClipboardChromium::declareAndWriteDragImage):
(WebCore::ClipboardChromium::writeURL):
(WebCore::ClipboardChromium::writeRange):
(WebCore::ClipboardChromium::writePlainText):
(WebCore::ClipboardChromium::hasData):
(WebCore::ClipboardChromium::items):

  • platform/chromium/ClipboardChromium.h:

(WebCore):
(ClipboardChromium):
(WebCore::ClipboardChromium::frame):

  • platform/chromium/ClipboardUtilitiesChromium.cpp:

(WebCore::convertURIListToURL):
(WebCore):

  • platform/chromium/ClipboardUtilitiesChromium.h:

(WebCore):

  • platform/chromium/DataTransferItemChromium.cpp:

(WebCore::DataTransferItemChromium::createFromString):
(WebCore::DataTransferItemChromium::createFromFile):
(WebCore::DataTransferItemChromium::createFromURL):
(WebCore::DataTransferItemChromium::createFromHTML):
(WebCore):
(WebCore::DataTransferItemChromium::createFromSharedBuffer):
(WebCore::DataTransferItemChromium::createFromPasteboard):
(WebCore::DataTransferItemChromium::DataTransferItemChromium):
(WebCore::DataTransferItemChromium::getAsString):
(WebCore::DataTransferItemChromium::getAsFile):
(WebCore::DataTransferItemChromium::internalGetAsString):
(WebCore::DataTransferItemChromium::isFilename):

  • platform/chromium/DataTransferItemChromium.h:

(WebCore):
(DataTransferItemChromium):
(WebCore::DataTransferItemChromium::kind):
(WebCore::DataTransferItemChromium::type):
(WebCore::DataTransferItemChromium::sharedBuffer):
(WebCore::DataTransferItemChromium::title):
(WebCore::DataTransferItemChromium::baseURL):

  • platform/chromium/DataTransferItemListChromium.cpp:

(WebCore::DataTransferItemListChromium::create):
(WebCore::DataTransferItemListChromium::createFromPasteboard):
(WebCore):
(WebCore::DataTransferItemListChromium::DataTransferItemListChromium):
(WebCore::DataTransferItemListChromium::length):
(WebCore::DataTransferItemListChromium::item):
(WebCore::DataTransferItemListChromium::deleteItem):
(WebCore::DataTransferItemListChromium::clear):
(WebCore::DataTransferItemListChromium::add):
(WebCore::DataTransferItemListChromium::internalAddStringItem):
(WebCore::DataTransferItemListChromium::internalAddFileItem):

  • platform/chromium/DataTransferItemListChromium.h:

(WebCore):
(DataTransferItemListChromium):

  • platform/chromium/DragDataChromium.cpp:

(WebCore::DragData::asURL):
(WebCore::DragData::asPlainText):
(WebCore::DragData::asFragment):

Source/WebKit/chromium:

  • src/WebDragData.cpp:

(WebKit::WebDragData::items):
(WebKit::WebDragData::addItem):
(WebKit::WebDragData::assign):

LayoutTests:

  • fast/events/clipboard-dataTransferItemList-expected.txt: Added.
  • fast/events/clipboard-dataTransferItemList.html: Added.
  • fast/events/drag-dataTransferItemList-expected.txt: Added.
  • fast/events/drag-dataTransferItemList.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
13:49 Changeset [111060] by lforschler@apple.com

Merged r103843.

13:49 Changeset [111059] by ap@apple.com

ASSERTION FAILED: m_loadState == LoadStateCommitted in WebFrameProxy::didFinishLoad causing
"crashes" on Lion Intel Debug WebKit2 Tests
https://bugs.webkit.org/show_bug.cgi?id=81184
<rdar://problem/11052462>

Rubber-stamped by Anders Carlsson.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::finishedLoading): Don't leave a lingering m_pluginView after load is finished. When plug-in data was empty, we would create the plug-in here, but failed to finalize the load.
13:48 Changeset [111058] by mlilek@apple.com

Don't install libWebCoreTestSupport on OS X production builds
https://bugs.webkit.org/show_bug.cgi?id=81087

Reviewed by Mark Rowe.

  • Configurations/WebCoreTestSupport.xcconfig:
13:41 Changeset [111057] by xji@chromium.org

Skip move-by-word-visually-wrong-left-right.html added in r110965 in wk2 since SetEditingBehavior is not supported.

  • platform/wk2/Skipped:
13:32 Changeset [111056] by eae@chromium.org

Merge trunk changes up until r111035 into subpixel branch.

13:27 Changeset [111055] by arv@chromium.org

Fix layout test to output the same result for V8 and JSC
https://bugs.webkit.org/show_bug.cgi?id=81395

Reviewed by Nate Chapin.

  • fast/dom/inline-event-attributes-crash-expected.txt:
  • fast/dom/inline-event-attributes-crash.html:
13:25 Changeset [111054] by hyatt@apple.com

Add RenderMultiColumnBlock.cpp to RenderingAllInOne.cpp for Windows build.

13:16 Changeset [111053] by tony@chromium.org

incorrectly removing scrollbar height for auto height flexbox children
https://bugs.webkit.org/show_bug.cgi?id=81388

Reviewed by Ojan Vafai.

Source/WebCore:

In a column flexbox, when computing the preferred height of an auto
height child, we were subtracting out the horizontal scrollbar height.

New test case in css3/flexbox/columns-auto-size.html.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):

LayoutTests:

  • css3/flexbox/columns-auto-size-expected.txt:
  • css3/flexbox/columns-auto-size.html:
13:15 Changeset [111052] by lforschler@apple.com

Branch name update.

13:08 Changeset [111051] by adamk@chromium.org

Out-of-document radio buttons should be grouped when associated with a form
https://bugs.webkit.org/show_bug.cgi?id=81268

Reviewed by Kent Tamura.

Source/WebCore:

Per the HTML spec, and the behavior of Firefox and IE 8/9, radio buttons
with a form owner should be grouped, even if that form is not in the document.

r104668 added many inDocument() tests to radio button grouping code.
While those are necessary to avoid unattached <input type=radio>
elements being grouped together, it also kept them from being grouped
when associated with a form outside the document.

This patch changes the HTMLInputElement::checkedRadioButtons() method
to return either a pointer to the proper CheckedRadioButtons instance
(either the document's or a form's), but will return null if the
element should not be associated with any radio button group.

The main fallout of this was that the callers of checkedRadioButtons()
now have to check for null, resulting in the creation of a few helper
methods in HTMLInputElement to wrap the null checks.

This refactoring has the pleasant side-effect of exposing a cleaner API between
HTMLInputElement and RadioInputType, and making a clearer contract
between HTMLInputElement and CheckedRadioButtons (e.g., all
CheckedRadioButtons methods that take an element can now assume that
it is a radio button, where previously some checked for that and
others asserted it).

Test: fast/forms/radio/radio-group-in-detached-form.html

  • dom/CheckedRadioButtons.cpp:

(WebCore): Removed shouldMakeRadioGroup() helper function.
(WebCore::CheckedRadioButtons::addButton): Replace call to shouldMakeRadioGroup
with appropriate assert and name check.
(WebCore::CheckedRadioButtons::updateCheckedState): ditto.
(WebCore::CheckedRadioButtons::requiredAttributeChanged): ditto.
(WebCore::CheckedRadioButtons::isRequiredGroup): Renamed from isInRequiredGroup,
changed to take only a group name, not an element.
(WebCore::CheckedRadioButtons::removeButton): Replace call to shouldMakeRadioGroup.
with appropriate assert and name check.

  • dom/CheckedRadioButtons.h:

(CheckedRadioButtons):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::~HTMLInputElement): Added isRadioButton check
now that it's asserted in CheckedRadioButtons.
(WebCore::HTMLInputElement::updateType): Call helper method instead of
calling directly into CheckedRadioButtons.
(WebCore::HTMLInputElement::parseAttribute): ditto.
(WebCore::HTMLInputElement::setChecked): ditto.
(WebCore::HTMLInputElement::willChangeForm): ditto.
(WebCore::HTMLInputElement::didChangeForm): ditto.
(WebCore::HTMLInputElement::insertedIntoDocument): ditto.
(WebCore::HTMLInputElement::removedFromDocument): ditto.
(WebCore::HTMLInputElement::didMoveToNewDocument): Added isRadioButton check.
(WebCore::HTMLInputElement::requiredAttributeChanged): Check for membership in a group
before calling into CheckedRadioButtons.
(WebCore::HTMLInputElement::isInRequiredRadioButtonGroup): Added helper method for use by RadioInputType.
(WebCore):
(WebCore::HTMLInputElement::checkedRadioButtonForGroup): ditto.
(WebCore::HTMLInputElement::checkedRadioButtons): Changed to return a
pointer, only return non-null if actually a member of a group.
(WebCore::HTMLInputElement::addToRadioButtonGroup): Helper method for
use in HTMLInputElement.
(WebCore::HTMLInputElement::removeFromRadioButtonGroup): ditto.

  • html/HTMLInputElement.h:

(HTMLInputElement): Added/removed methods, removed outdated comment about visibility.

  • html/RadioInputType.cpp:

(WebCore::RadioInputType::valueMissing): Call new HTMLInputElement methods instead
of interacting directly with CheckedRadioButtons.
(WebCore::RadioInputType::isKeyboardFocusable): ditto.
(WebCore::RadioInputType::willDispatchClick): ditto.

LayoutTests:

  • fast/forms/radio/radio-group-expected.txt:
  • fast/forms/radio/radio-group-in-detached-form-expected.txt: Added.
  • fast/forms/radio/radio-group-in-detached-form.html: Added.
  • fast/forms/radio/radio-group.html: Updated to match new behavior.
13:00 Changeset [111050] by commit-queue@webkit.org

[BlackBerry] Syncing up left over bits in WebCoreSupport from our local branch to upstream
https://bugs.webkit.org/show_bug.cgi?id=81120

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-03-16
Reviewed by Rob Buis.

This is a consolidation of various changes that are in our local dev branch
but do not appear in our upstreamed port.

  • WebCoreSupport/AboutDataEnableFeatures.in:
  • WebCoreSupport/AboutDataHaveFeatures.in:
  • WebCoreSupport/AboutDataUseFeatures.in:
  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::hasOpenedPopup):
(WebCore):
(WebCore::ChromeClientBlackBerry::screenToRootView):
(WebCore::ChromeClientBlackBerry::rootViewToScreen):
(WebCore::ChromeClientBlackBerry::invalidateRootView):
(WebCore::ChromeClientBlackBerry::invalidateContentsAndRootView):
(WebCore::ChromeClientBlackBerry::invalidateContentsForSlowScroll):
(WebCore::ChromeClientBlackBerry::scrollableAreasDidChange):
(WebCore::ChromeClientBlackBerry::createColorChooser):

  • WebCoreSupport/ChromeClientBlackBerry.h:

(ChromeClientBlackBerry):
(WebCore::ChromeClientBlackBerry::numTouchEventHandlersChanged):

  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::registerUndoStep):
(WebCore::EditorClientBlackBerry::registerRedoStep):
(WebCore::EditorClientBlackBerry::undo):
(WebCore::EditorClientBlackBerry::redo):

  • WebCoreSupport/EditorClientBlackBerry.h:

(EditorClientBlackBerry):

  • WebCoreSupport/GeolocationControllerClientBlackBerry.cpp:

(GeolocationControllerClientBlackBerry::requestPermission):
(GeolocationControllerClientBlackBerry::cancelPermissionRequest):

  • WebCoreSupport/GeolocationControllerClientBlackBerry.h:
  • WebCoreSupport/InspectorClientBlackBerry.cpp:

(WebCore::InspectorClientBlackBerry::closeInspectorFrontend):
(WebCore):
(WebCore::InspectorClientBlackBerry::bringFrontendToFront):

  • WebCoreSupport/InspectorClientBlackBerry.h:

(InspectorClientBlackBerry):

  • WebCoreSupport/NotificationPresenterImpl.cpp:

(WebCore::NotificationPresenterImpl::show):

12:57 Changeset [111049] by hyatt@apple.com

Missed adding new files to Targets.pri

12:55 Changeset [111048] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=81366

Add RenderMultiColumnBlock subclass of RenderBlock. This new class will hold all of the multi-column
logic (as well as painting/hit testing). That way the column code can be kept out of the base class
and be more cleanly factored.

Patch Node::diff so that we detach and re-attach the renderer if column counts or widths change
from auto to non-auto (and vice versa) to ensure the right renderer gets made.

Patch RenderObject::createObject to make a RenderMultiColumnBlock if either the column count or
column width is non-auto.

Patch RenderBlock::calcColumnWidth to "turn off" the old implementation of columns if the pref to use
the new column implementation is set. This single chokepoint should be sufficient for disabling the old
columns in favor of the new.

Reviewed by Dan Bernstein.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:

(WebCore::Document::regionBasedColumnsEnabled):
(WebCore):
(WebCore::Document::recalcStyle):

  • dom/Document.h:

(Document):

  • dom/Element.cpp:

(WebCore::Element::recalcStyle):

  • dom/Node.cpp:

(WebCore::Node::diff):

  • dom/Node.h:
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::calcColumnWidth):
(WebCore::RenderBlock::updateFirstLetterStyle):

  • rendering/RenderMultiColumnBlock.cpp: Added.

(WebCore):
(WebCore::RenderMultiColumnBlock::RenderMultiColumnBlock):
(WebCore::RenderMultiColumnBlock::renderName):

  • rendering/RenderMultiColumnBlock.h: Added.

(WebCore):
(RenderMultiColumnBlock):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::updateBeforeAfterContent):

12:45 Changeset [111047] by senorblanco@chromium.org

[chromium] Improve CSS3 filter blur performance.
https://bugs.webkit.org/show_bug.cgi?id=81360

This change improves blur performance by 2-2.5X on blurred CSS
3D transforms and accelerated canvas demos by skipping an unnecessary
texture allocation and bitmap draw.

Reviewed by James Robinson.

Covered by existing layout tests in css3/filters.

  • platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:

(WebCore::CCRenderSurfaceFilters::apply):
Call SkCanvas::drawSprite() directly instead of using
saveLayer()/restore().

12:43 Changeset [111046] by jer.noble@apple.com

Rebaseline GTK expected results after r111041.

  • platform/gtk/accessibility/media-element-expected.txt:
12:41 Changeset [111045] by jberlin@webkit.org

plugins/keyboard-events.html, mouse-events-fixedpos.html, and mouse-events.html failing on Lion
Intel Debug WebKit2 testers
https://bugs.webkit.org/show_bug.cgi?id=81386

Add expected failing results for mac-wk2 to get the bots green.

  • platform/mac-wk2/plugins/keyboard-events-expected.txt: Added.
  • platform/mac-wk2/plugins/mouse-events-expected.txt: Added.
  • platform/mac-wk2/plugins/mouse-events-fixedpos-expected.txt: Added.
12:26 Changeset [111044] by jsbell@chromium.org

[Chromium] IndexedDB: Assertion failure when storing File objects
https://bugs.webkit.org/show_bug.cgi?id=76746

Source/WebCore:

The blob data in Blob/File/FileList objects is serialized "by reference" (the
internal URL) rather than "by value" (the actual data); this is sufficient for
postMessage() but not for IndexedDB since the referenced data is not retained
Expose a mechanism to enumerate the URLs so that SSVs can be rejected by IDB
until blob data serialization can is implemented (outside the SSV mechanism, and
potentially asynchronously).

Also, correct issue in V8DOMWrapper::instantiateV8Object where context is assumed
to be a Worker context if it's not a Window, which is incorrect for the
Chromium utility process; this is hit if Blobs are not blocked.

Reviewed by Tony Chang.

Test: storage/indexeddb/noblobs.html

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::update): Reject SSVs that contain blob references.

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::add): Reject SSVs that contain blob references.
(WebCore::IDBObjectStore::put): Reject SSVs that contain blob references.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::serialize):
(WebCore::CloneSerializer::CloneSerializer):
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneSerializer::write):
(CloneSerializer):
(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::undefinedValue):
(WebCore::SerializedScriptValue::booleanValue):

  • bindings/js/SerializedScriptValue.h: New API to enable the clients to be picky.
  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::SerializedScriptValue):

  • bindings/v8/SerializedScriptValue.h: New API to enable the clients to be picky.

(WebCore::SerializedScriptValue::blobURLs):
(SerializedScriptValue):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::instantiateV8Object): Ensure context is a worker context before treating it as such.

LayoutTests:

Ensure that Blob/File/FileList types are rejected in IDB values, to detect regressions.

Reviewed by Tony Chang.

  • storage/indexeddb/noblobs-expected.txt: Added.
  • storage/indexeddb/noblobs.html: Added.
12:23 Changeset [111043] by arv@chromium.org

[V8] Ensure that invalid syntax in inline event handlers does not cause a crash
https://bugs.webkit.org/show_bug.cgi?id=81385

Reviewed by Nate Chapin.

Source/WebCore:

The way that V8 does its inline event handler involves concatting strings and
if the attribute value is crafted in a special way this could cause a crash.

Test: fast/dom/inline-event-attributes-crash.html

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

LayoutTests:

  • fast/dom/inline-event-attributes-crash-expected.txt: Added.
  • fast/dom/inline-event-attributes-crash.html: Added.
12:22 Changeset [111042] by ojan@chromium.org

Chromium rebaselines for expected failures on garden-o-matic.

  • platform/chromium-linux-x86/compositing/reflections/animation-inside-reflection-expected.png: Added.
  • platform/chromium-linux-x86/compositing/reflections/nested-reflection-animated-expected.png: Added.
  • platform/chromium-linux/compositing/color-matching/pdf-image-match-expected.png: Added.
  • platform/chromium-linux/compositing/reflections/animation-inside-reflection-expected.png:
  • platform/chromium-linux/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-mac-leopard/compositing/reflections/animation-inside-reflection-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/reflections/nested-reflection-animated-expected.png: Added.
  • platform/chromium-mac-snowleopard/animations/cross-fade-border-image-source-expected.png:
  • platform/chromium-mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-animated-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-animated-expected.txt: Added.
  • platform/chromium-mac/compositing/reflections/animation-inside-reflection-expected.png:
  • platform/chromium-mac/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-mac/compositing/reflections/nested-reflection-transition-expected.png: Added.
  • platform/chromium-win-vista/compositing/reflections/animation-inside-reflection-expected.png: Added.
  • platform/chromium-win-vista/compositing/reflections/nested-reflection-animated-expected.png: Added.
  • platform/chromium-win-vista/compositing/shadows/shadow-drawing-expected.png: Removed.
  • platform/chromium-win-xp/compositing/reflections/animation-inside-reflection-expected.txt: Added.
  • platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.png: Added.
  • platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.txt: Copied from LayoutTests/platform/chromium-win/compositing/reflections/nested-reflection-animated-expected.txt.
  • platform/chromium-win/compositing/absolute-position-changed-with-composited-parent-layer-expected.png:
  • platform/chromium-win/compositing/color-matching/pdf-image-match-expected.png: Added.
  • platform/chromium-win/compositing/color-matching/pdf-image-match-expected.txt: Added.
  • platform/chromium-win/compositing/reflections/animation-inside-reflection-expected.png:
  • platform/chromium-win/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-win/compositing/reflections/nested-reflection-animated-expected.txt:
  • platform/chromium/test_expectations.txt:
12:21 Changeset [111041] by jer.noble@apple.com

Wrong icon to restore to windowed mode in full screen video panel
https://bugs.webkit.org/show_bug.cgi?id=70437

Reviewed by Eric Carlson.

Source/WebCore:

No new tests. Updated platform/mac/accessibility/media-element-expected.txt.

Renamed MediaFullscreenButton to MediaEnterFullscreenButton and added MediaExitFullscreenButton:

  • accessibility/AccessibilityMediaControls.cpp:

(WebCore::AccessibilityMediaControl::controlTypeName):
(WebCore::AccessibilityMediaControl::roleValue):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSValueKeywords.in:
  • platform/ThemeTypes.h:

Added setIsFullscreen which controls the display of the enter/exit fullscreen button:

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlFullscreenButtonElement::setIsFullscreen): Added.

  • html/shadow/MediaControlElements.h:
  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::enteredFullscreen):
(WebCore::MediaControlRootElement::exitedFullscreen):

Paint the enter/exit fullscreen button accordingly:

  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::RenderMediaControlsChromium::paintMediaControlsPart):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paint):

  • rendering/RenderThemeChromiumAndroid.cpp:

(WebCore::RenderThemeChromiumAndroid::paintMediaFullscreenButton):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMediaFullscreenButton):

  • rendering/RenderMediaControls.cpp:

(WebCore::RenderMediaControls::paintMediaControlsPart):

  • rendering/RenderThemeSafari.cpp:

(WebCore::RenderThemeSafari::paintMediaFullscreenButton):

Update the localized strings for the exit and enter fullscreen buttons:

  • English.lproj/Localizable.strings:
  • platform/LocalizedStrings.cpp:

(WebCore::localizedMediaControlElementString):

  • platform/gtk/LocalizedStringsGtk.cpp:

(WebCore::localizedMediaControlElementString):
(WebCore::localizedMediaControlElementHelpText):

  • platform/qt/LocalizedStringsQt.cpp:

(WebCore::localizedMediaControlElementString):
(WebCore::localizedMediaControlElementHelpText):

WebKitLibraries:

  • WebKitSystemInterface.h: Added WKMediaUIPartExitFullscreenButton.
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:

LayoutTests:

  • platform/mac/accessibility/media-element-expected.txt:
12:07 Changeset [111040] by leviw@chromium.org

Update LayoutUnit usage in RenderListBox
https://bugs.webkit.org/show_bug.cgi?id=81038

Reviewed by Julien Chaffraix.

Bringing RenderListBox in line with the rules listed in
https://trac.webkit.org/wiki/LayoutUnit

No new tests. No change in behavior.

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::paintScrollbar): Pixel snapping before handing off scrollbar
painting to the platform.
(WebCore::RenderListBox::paintItemForeground): Rounding the offset for text painting.
(WebCore::RenderListBox::paintItemBackground): Pixel snapping the background rect.
(WebCore::RenderListBox::panScroll): EventHandler::currentMousePosition is an IntPoint,
so it doesn't require additional rounding in RenderListBox.

12:02 Changeset [111039] by ojan@chromium.org

Have webkit-patch rebaseline-test update test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=81054

Recommit http://trac.webkit.org/changeset/110783 now that
http://trac.webkit.org/changeset/111034 has landed.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations.remove_configuration_from_test):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(RemoveConfigurationsTest):
(RemoveConfigurationsTest.test_remove):
(test_remove_line):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineTest._update_expectations_file):
(RebaselineTest._rebaseline_test_and_update_expectations):
(RebaselineTest):
(RebaselineTest.execute):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaseline.test_rebaseline_updates_expectations_file_noop):
(test_rebaseline_updates_expectations_file):

11:57 Changeset [111038] by jer.noble@apple.com

Rebaseline window-properties-expected on GTK; add two new tests
to the GTK Skipped list associated with existing bug:
https://bugs.webkit.org/show_bug.cgi?id=61118

  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
11:39 Changeset [111037] by commit-queue@webkit.org

[BlackBerry] Input fields with id of e-mail and url should be styled as such.
https://bugs.webkit.org/show_bug.cgi?id=81364

Patch by Mike Fenton <mifenton@rim.com> on 2012-03-16
Reviewed by Rob Buis.

Treat fields that have name/id's that match url or
email as url or email fields providing the appropriate
keyboard.

PR 137259.

Reviewed Internally by Gen Mak and Nima Ghanavatian.

  • WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::matchesReservedStringEmail):
(DOMSupport):
(BlackBerry::WebKit::DOMSupport::matchesReservedStringUrl):
(BlackBerry::WebKit::DOMSupport::elementIdOrNameIndicatesEmail):
(BlackBerry::WebKit::DOMSupport::elementIdOrNameIndicatesUrl):
(BlackBerry::WebKit::DOMSupport::matchesReservedStringPreventingAutocomplete):

  • WebKitSupport/DOMSupport.h:

(WebCore):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::convertInputType):
(BlackBerry::WebKit::inputStyle):

11:33 Changeset [111036] by adamk@chromium.org

Mark form-associated-element-crash3.html as flakily timing out, since it often passes.

  • platform/chromium/test_expectations.txt:
11:33 Changeset [111035] by pkasting@chromium.org

Unreviewed, rolling out r111020.
http://trac.webkit.org/changeset/111020
https://bugs.webkit.org/show_bug.cgi?id=81377

Broke Chromium Win compile (Requested by pkasting on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-16

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • platform/mediastream/PeerConnection00Handler.cpp: Removed.
  • platform/mediastream/PeerConnection00Handler.h: Removed.
  • platform/mediastream/PeerConnection00HandlerClient.h: Removed.
11:31 Changeset [111034] by ojan@chromium.org

Specifier collapsing when writing test expectations lines gets a number of cases wrong
https://bugs.webkit.org/show_bug.cgi?id=81309

Reviewed by Dimitri Glazkov.

I've run this over all the lines in the current Chromium test_expectations.txt file,
so I'm relatively confident we now cover all the cases.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py:

(TestConfigurationConverter.init):
(TestConfigurationConverter.collapse_macros):
(TestConfigurationConverter.collapse_macros.collapse_individual_specifier_set):
(TestConfigurationConverter):
(TestConfigurationConverter.intersect_combination):
(TestConfigurationConverter.symmetric_difference):
(TestConfigurationConverter.to_specifiers_list):
(TestConfigurationConverter.to_specifiers_list.try_collapsing):
(TestConfigurationConverter.to_specifiers_list.try_abbreviating):

  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:

(make_mock_all_test_configurations_set):
(TestConfigurationConverterTest.test_symmetric_difference):
(TestConfigurationConverterTest.test_to_config_set):
(TestConfigurationConverterTest.test_macro_expansion):
(TestConfigurationConverterTest.test_to_specifier_lists):
(TestConfigurationConverterTest.test_converter_macro_collapsing):

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort):

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.init):
The android port uses "arm" as it's architecture, which is technically correct,
but considerably complicates making collapsing work. We probably should kill
the concept of architecture entirely. The benefits are not worth the code
complexity.

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumPortTest.test_all_test_configurations):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaseline.test_rebaseline_updates_expectations_file_noop):
(test_rebaseline_updates_expectations_file):

11:27 Changeset [111033] by jberlin@webkit.org

6 platform/mac/editing/spelling autocorrect-related tests failing on Lion Intel Debug WebKit2
testers
https://bugs.webkit.org/show_bug.cgi?id=81375

Add expected failing results to get the bots green.

  • platform/mac-wk2/platform/mac/editing/spelling/autocorrection-contraction-expected.png: Added.
  • platform/mac-wk2/platform/mac/editing/spelling/autocorrection-contraction-expected.txt: Added.
  • platform/mac-wk2/platform/mac/editing/spelling/click-autocorrected-word-expected.png: Added.
  • platform/mac-wk2/platform/mac/editing/spelling/click-autocorrected-word-expected.txt: Added.
  • platform/mac-wk2/platform/mac/editing/spelling/delete-into-autocorrected-word-expected.png: Added.
  • platform/mac-wk2/platform/mac/editing/spelling/delete-into-autocorrected-word-expected.txt: Added.
  • platform/mac-wk2/platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.png: Added.
  • platform/mac-wk2/platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.txt: Added.
  • platform/mac-wk2/platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.png: Added.
  • platform/mac-wk2/platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.txt: Added.
  • platform/mac-wk2/platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.png: Added.
  • platform/mac-wk2/platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.txt: Added.
11:27 Changeset [111032] by jberlin@webkit.org

platform/mac/editing/spelling/editing-word-with-marker-1.html failing on Lion Intel Debug
testers
https://bugs.webkit.org/show_bug.cgi?id=81372

Add expected failing results to get the bots green.

  • platform/mac/editing/spelling/editing-word-with-marker-1-expected.txt:
11:27 Changeset [111031] by jberlin@webkit.org

platform/mac/editing/spelling/autocorrection-contraction.html fails on Lion Intel Debug testers.
https://bugs.webkit.org/show_bug.cgi?id=81369

Add expected failing results to get the bots green.

  • platform/mac/editing/spelling/autocorrection-contraction-expected.png:
  • platform/mac/editing/spelling/autocorrection-contraction-expected.txt:
11:23 Changeset [111030] by dmazzoni@google.com

File input control accessibility can cause a crash
https://bugs.webkit.org/show_bug.cgi?id=80896

Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/input-file-causes-crash.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::textUnderElement):

LayoutTests:

  • accessibility/input-file-causes-crash-expected.txt: Added.
  • accessibility/input-file-causes-crash.html: Added.
11:21 Changeset [111029] by commit-queue@webkit.org

[chromium] compositing tests with videos fail in chromium DumpRenderTree, seeking doesn't appear to work
https://bugs.webkit.org/show_bug.cgi?id=76511

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-03-16
Reviewed by Eric Carlson.

  • compositing/resources/media-testing.js:

(ensureFrameVisible.playingHandler):
(ensureFrameVisible.seekedHandler):
(ensureFrameVisible):

11:12 Changeset [111028] by jer.noble@apple.com

Support W3C Full Screen API proposal
https://bugs.webkit.org/show_bug.cgi?id=80660

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Tests: fullscreen/full-screen-element-stack.html

fullscreen/full-screen-enabled.html
fullscreen/full-screen-restrictions.html

The W3C proposal for taking arbitrary elements into full-screen mode is significantly
different than the Mozilla proposal. For example, the W3C has proposed a lower-case "s"
in "Fullscreen", which means the W3C and Mozilla "requestFullscreen" APIs differ only by
in that lower-case "s". Annoying as this is, it does allow us to retain the semantics for
the Mozilla case (har!).

A significant difficulty is obeying the new W3C spec rules is that we would like to apply the
fullscreen CSS rules while exiting fullscreen mode, though the W3C spec insists that the
webkitFullscreenElement returns the new value immediately. As such, we retain the m_fullScreenElement
variable (distinct from the top of the m_fullScreenElements stack) which is controlled by the
webkit{Will,Did}{Enter,Exit}FullScreen functions.

New APIs for the W3C Fullscreen spec:

  • dom/Document.h:

(WebCore::Document::webkitFullscreenElement):
(WebCore::Document::webkitFullscreenEnabled):

  • dom/Document.idl:
  • dom/Element.cpp:

(WebCore::Element::webkitRequestFullscreen):

  • dom/Element.h:
  • dom/Element.idl:
  • dom/Document.cpp:

(WebCore::Document::removedLastRef): Clear m_fullScreenElementStack.
(WebCore::Document::requestFullScreenForElement): Implement the W3C requirements.
(WebCore::Document::webkitExitFullscreen): Ditto.
(WebCore::Document::webkitCancelFullScreen): Implement in terms of webkitCancelFullscreen.
(WebCore::Document::webkitDidEnterFullScreenForElement):
(WebCore::Document::webkitWillExitFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):
(WebCore::Document::fullScreenChangeDelayTimerFired): Protect against items being

added to the event and error queue by swapping out empty queues before starting.

(WebCore::Document::clearFullscreenElementStack): Simple accessor.
(WebCore::Document::popFullscreenElementStack): Ditto.
(WebCore::Document::pushFullscreenElementStack): Ditto.

  • dom/Element.cpp:

(WebCore::Element::webkitRequestFullScreen):

Add new RuntimeEnabledFeatures functions for the added Document and Element functions.

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::webkitFullscreenEnabledEnabled):
(WebCore::RuntimeEnabledFeatures::webkitFullscreenElementEnabled):
(WebCore::RuntimeEnabledFeatures::webkitExitFullscreenEnabled):
(WebCore::RuntimeEnabledFeatures::webkitRequestFullscreenEnabled):

Source/WebKit/mac:

Allow full screen elements to access the keyboard.

  • WebView/WebView.mm:

(-[WebView _supportsFullScreenForElement:WebCore::withKeyboard:]):

Source/WebKit2:

Allow full screen elements to access the keyboard.

  • UIProcess/WebFullScreenManagerProxy.cpp:

(WebKit::WebFullScreenManagerProxy::supportsFullScreen):

  • WebProcess/FullScreen/WebFullScreenManager.cpp:

(WebKit::WebFullScreenManager::exitFullScreenForElement):

LayoutTests:

  • fullscreen/full-screen-element-stack-expected.txt: Added.
  • fullscreen/full-screen-element-stack.html: Added.
  • fullscreen/full-screen-enabled-expected.txt: Added.
  • fullscreen/full-screen-enabled.html: Added.
  • fullscreen/full-screen-request-rejected.html:
  • fullscreen/full-screen-request-removed.html:
  • fullscreen/full-screen-restrictions-expected.txt: Added.
  • fullscreen/full-screen-restrictions.html: Added.
  • fullscreen/full-screen-test.js:
11:00 Changeset [111027] by commit-queue@webkit.org

[GTK] WebKitWebResource::load-failed uses the wrong marshaller
https://bugs.webkit.org/show_bug.cgi?id=81229

Patch by Victor Lucero <victor.lucero@ipartner.cl> on 2012-03-16
Reviewed by Philippe Normand.

  • webkit/webkitwebresource.cpp:

(webkit_web_resource_class_init): load-failed signal in WebkitWebResource was using the wrong marshaller

10:58 Changeset [111026] by adamk@chromium.org

Make HTMLInputElement::isRadioButton non-virtual and remove unused HTMLFormControlElement::isRadioButton method
https://bugs.webkit.org/show_bug.cgi?id=81255

Reviewed by Kent Tamura.

No new tests, no change in behavior.

  • html/HTMLFormControlElement.h:
  • html/HTMLInputElement.h:

(HTMLInputElement):

10:43 Changeset [111025] by commit-queue@webkit.org

[BlackBerry] Update NetworkJob to accept batched headers
https://bugs.webkit.org/show_bug.cgi?id=81273

Batch up the headers into a vector before they come into
webkit to increase performance, and simplify the API.

Patch by Tay Grigg <tgrigg@rim.com> on 2012-03-16
Reviewed by George Staikos.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::notifyHeadersReceived):

  • platform/network/blackberry/NetworkJob.h:

(NetworkJob):

10:17 Changeset [111024] by commit-queue@webkit.org

[BlackBerry] Syncing up left over bits in Api from our local branch to upstream
https://bugs.webkit.org/show_bug.cgi?id=81105

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-03-16
Reviewed by Rob Buis.

This patches fixes up a previous sync done in this directory and adds some new bits
as well. This is accurate as of ddea1528b37b29925638fe1183318b3c3994f1f8 in our
local repo.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::drawAndBlendLayersForDirectRendering):
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::drawLayersOnCommitIfNeeded):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPage::webContext):
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):

  • Api/WebPage.h:
  • Api/WebPage_p.h:

(WebPagePrivate):

10:14 Changeset [111023] by commit-queue@webkit.org

[chromium] Add overdraw metrics for texture uploads
https://bugs.webkit.org/show_bug.cgi?id=81175

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-16
Reviewed by Adrienne Walker.

Source/WebCore:

Record texture upload metrics during paint. To properly record
the amount of pixels culled, we must compute the amount of pixels we
would have uploaded for a tile. This requires knowing the dirty rect of
the tile, but the dirty rect can be changed by WebKit during a paint, so
we always store the dirtyRect in the tile's updateRect. We add an
m_updateCulled bool to the UpdatableTile structure, to identify tiles
that were not updated, and know a tile was updated if updateRect is not
empty and updateCulled is false.

Tested by all TiledLayerChromiumTests that use occlusion tracker.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(UpdatableTile):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintLayerContents):

Source/WebKit/chromium:

  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):

10:07 Changeset [111022] by jer.noble@apple.com

Allow AudioContext::create() to emit an ExceptionCode.
https://bugs.webkit.org/show_bug.cgi?id=81049

Reviewed by Kentaro Hara.

No new tests; no change in functionality.

Pass through an ExceptionCode parameter to AudioContext::create(). It is currently
never modified, but exceptions will be added in the future.

  • bindings/js/JSAudioContextCustom.cpp:

(WebCore::JSAudioContextConstructor::constructJSAudioContext):

  • bindings/v8/custom/V8AudioContextCustom.cpp:

(WebCore::V8AudioContext::constructorCallback):

  • webaudio/AudioContext.cpp:

(WebCore::AudioContext::create):

  • webaudio/AudioContext.h:
09:59 Changeset [111021] by commit-queue@webkit.org

[chromium] Remove surface damage client from occlusion tracker
https://bugs.webkit.org/show_bug.cgi?id=81242

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-16
Reviewed by Adrienne Walker.

Source/WebCore:

Code was not used yet, so no new tests. Removing tests instead!

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::CCOcclusionTrackerBase):
(WebCore::::layerScissorRectInTargetSurface):
(WebCore):

  • platform/graphics/chromium/cc/CCOcclusionTracker.h:

(WebCore):
(CCOcclusionTrackerBase):

Source/WebKit/chromium:

  • tests/CCOcclusionTrackerTest.cpp:

(WebCore):

09:56 Changeset [111020] by tommyw@google.com

MediaStream API (JSEP): Introducing PeerConnection00Handler
https://bugs.webkit.org/show_bug.cgi?id=81333

Reviewed by Adam Barth.

In preparation of the last WebCore patch that will introduce PeerConnection00 here's its platform representation.

Not possible to test until the entire JSEP feature is commited.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • platform/mediastream/PeerConnection00Handler.cpp: Added.

(WebCore):
(WebCore::PeerConnection00Handler::create):
(WebCore::PeerConnection00Handler::PeerConnection00Handler):
(WebCore::PeerConnection00Handler::~PeerConnection00Handler):
(WebCore::PeerConnection00Handler::createOffer):
(WebCore::PeerConnection00Handler::createAnswer):
(WebCore::PeerConnection00Handler::setLocalDescription):
(WebCore::PeerConnection00Handler::setRemoteDescription):
(WebCore::PeerConnection00Handler::localDescription):
(WebCore::PeerConnection00Handler::remoteDescription):
(WebCore::PeerConnection00Handler::startIce):
(WebCore::PeerConnection00Handler::processIceMessage):
(WebCore::PeerConnection00Handler::addStream):
(WebCore::PeerConnection00Handler::removeStream):
(WebCore::PeerConnection00Handler::stop):

  • platform/mediastream/PeerConnection00Handler.h: Added.

(WebCore):
(PeerConnection00Handler):

  • platform/mediastream/PeerConnection00HandlerClient.h: Added.

(WebCore):
(PeerConnection00HandlerClient):
(WebCore::PeerConnection00HandlerClient::~PeerConnection00HandlerClient):

09:56 Changeset [111019] by commit-queue@webkit.org

[BlackBerry] Input processing mode should be cancelled when processing hot keys
https://bugs.webkit.org/show_bug.cgi?id=81348

Patch by Mike Fenton <mifenton@rim.com> on 2012-03-16
Reviewed by Rob Buis.

Don't suppress IMF notifications if we are handling
the event as a hotkey.

Reviewed Internally by Nima Ghanavatian.

  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::handleKeyboardEvent):

09:49 Changeset [111018] by podivilov@chromium.org

Web Inspector: fix exception when hovering over bound function in heap profiler.
https://bugs.webkit.org/show_bug.cgi?id=81362

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyRawLocation):

09:49 Changeset [111017] by sfalken@apple.com

Windows build fix.

09:49 Changeset [111016] by xji@chromium.org

Skip visual word movement tests in gtk and qt after r110965 since isWordTextBreak is not implemented.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
09:43 Changeset [111015] by abecsi@webkit.org

[Qt][WK2] Fix bounce-back behaviour for panning
https://bugs.webkit.org/show_bug.cgi?id=81144

Reviewed by Kenneth Rohde Christiansen.

If the pan gesture recognizer receives a touch begin event
during an ongoing kinetic scroll animation of a previous
pan gesture, the animation is stopped and the content is
immediately positioned back to valid boundaries.

  • UIProcess/qt/QtPanGestureRecognizer.cpp:

(WebKit::QtPanGestureRecognizer::recognize):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::cancelScrollAnimation):
(WebKit):

  • UIProcess/qt/QtViewportInteractionEngine.h:

(QtViewportInteractionEngine):

09:40 Changeset [111014] by mrobinson@webkit.org

WebKit/gtk/resources/error.html font-size error
https://bugs.webkit.org/show_bug.cgi?id=39232

Patch by Landry Breuil <landry@openbsd.org> on 2012-03-14
Reviewed by Martin Robinson.

Fix font-size in the 404 error page. Apparently the % is filtered out,
so 120% becomes 120 and the error message is huge. Experienced in epiphany.

  • resources/error.html: Double the % so it doesn't get filtered
09:26 Changeset [111013] by msaboff@apple.com

Improve diagnostic benefit of JSGlobalData::m_isInitializingObject
https://bugs.webkit.org/show_bug.cgi?id=81244

Rubber stamped by Filip Pizlo.

Changed type and name of JSGlobalData::m_isInitializingObject to
ClassInfo* and m_initializingObjectClass.
Changed JSGlobalData::setInitializingObject to
JSGlobalData::setInitializingObjectClass. This pointer can be used within
the debugger to determine what type of object is being initialized.

  • runtime/JSCell.h:

(JSC::JSCell::finishCreation):
(JSC::allocateCell):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSGlobalData):
(JSC::JSGlobalData::isInitializingObject):
(JSC::JSGlobalData::setInitializingObjectClass):

  • runtime/Structure.h:

(JSC::JSCell::finishCreation):

09:16 Changeset [111012] by commit-queue@webkit.org

[Qt][Wk2] Assertion Failure and crash on file upload
https://bugs.webkit.org/show_bug.cgi?id=80854

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-03-16
Reviewed by Simon Hausmann.

Source/WebKit2:

Crash resulted from attempting to create QFileDialog, a QtWidget based dialog from a
QGuiApplication. Replace QFileDialog with a QML implementable component.
Added a new property 'filePicker' to WebView experimental to set the QML component for
file upload triggered by an input file element.

Co-authored with Kasthuri Nallappasoundararajan <kasthuri.n-s@nokia.com>

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::chooseFiles):
(QQuickWebViewExperimental::filePicker):
(QQuickWebViewExperimental::setFilePicker):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

  • UIProcess/API/qt/tests/qmltests/DesktopBehavior.pro:
  • UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_singleFileUpload.qml: Added.
  • UIProcess/API/qt/tests/qmltests/common/singlefileupload.html: Added.
  • UIProcess/qt/QtDialogRunner.cpp:

(FilePickerContextObject):
(FilePickerContextObject::FilePickerContextObject):
(FilePickerContextObject::fileList):
(FilePickerContextObject::reject):
(FilePickerContextObject::accept):
(QtDialogRunner::initForFilePicker):

  • UIProcess/qt/QtDialogRunner.h:

(QtDialogRunner):
(QtDialogRunner::filePaths):
(QtDialogRunner::onFileSelected):

Tools:

Added filePicker to WebView using experimental API.

  • MiniBrowser/qt/MiniBrowser.qrc:
  • MiniBrowser/qt/icons/folder.png: Added.
  • MiniBrowser/qt/icons/titlebar.png: Added.
  • MiniBrowser/qt/icons/up.png: Added.
  • MiniBrowser/qt/qml/BrowserWindow.qml:
  • MiniBrowser/qt/qml/FilePicker.qml: Added.
09:04 Changeset [111011] by mahesh.kulkarni@nokia.com

Updating email for committer.py script.

  • Scripts/webkitpy/common/config/committers.py:
08:51 Changeset [111010] by commit-queue@webkit.org

[Qt][WK2] Build failure when using --no-touch-events
https://bugs.webkit.org/show_bug.cgi?id=81241

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-03-16
Reviewed by Simon Hausmann.

Fixed inconsistency in the use of ENABLE_TOUCH_EVENTS flag that caused build
failure when using --no-touch-events option

  • UIProcess/qt/QtPageClient.h:

(QtPageClient):

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::handlePotentialSingleTapEvent):

  • UIProcess/qt/QtWebPageEventHandler.h:

(QtWebPageEventHandler):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

  • WebProcess/WebPage/WebPage.messages.in:
08:01 Changeset [111009] by commit-queue@webkit.org

[Forms] The "progress" element should not be a form-associated element.
https://bugs.webkit.org/show_bug.cgi?id=80240

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-16
Reviewed by Kent Tamura.

Source/WebCore:

This patch changes base class of HTMLProgressElement to LabelableElement from
HTMLFormControlElement for saving memory space and iteration time of
extra "progress" elements in HTMLFormElement::m_formAssociatedElements
and matching the HTML5 specification for ease of maintenance.

Changes of TextIterator is lead by usage of isFormControlElement. This
changes will be replaced with more meaningful predicate as part of
https://bugs.webkit.org/show_bug.cgi?id=80381

No new tests. Update existing tests to cover this change.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithElement): Moved the "progress" element support code from canShareStyleWithControl.
(WebCore::CSSStyleSelector::canShareStyleWithControl):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOneSelector): Remove isFormControlElement check for PseudoIndeterminate.

  • editing/TextIterator.cpp:

(WebCore::TextIterator::advance): Check HTMLProgressElement in addition to isFormControlElement. This change is for text dump in LayoutTests implemented by document.innerText attribute.

  • html/HTMLProgressElement.cpp: Remove unused include file.

(WebCore::HTMLProgressElement::HTMLProgressElement): Changed base class to LabelableElement.
(WebCore::HTMLProgressElement::create): Remove form paraprogress.
(WebCore::HTMLProgressElement::parseAttribute): Replace HTMLFormControlElement to LabelableElement.
(WebCore::HTMLProgressElement::attach): Replace HTMLFormControlElement to LabelableElement.

  • html/HTMLProgressElement.h:

(HTMLProgressElement):

  • html/HTMLProgressElement.idl: Remove the "form" attribute which isn't listed in the HTML5 specification.
  • html/HTMLTagNames.in: Remove "constructorNeedsFormElement" for not passing "form" parameter in HTMLElementFactory.

LayoutTests:

This patch changes tests for non-existent "form" attribute of the
"progress" element. The "form" attribute is available only for
form-associate elements. However, the "progress" element isn't.

  • fast/dom/HTMLProgressElement/progress-element-form-expected.txt: Update expectation for test output changes.
  • fast/dom/HTMLProgressElement/progress-element-form.html: Changed for the "progress" element doesn't have IDL attribute "form".
  • fast/forms/form-attribute-expected.txt: Update expectation for test output changes.
  • fast/forms/form-attribute.html: Removed lines for the "progress" element.
07:54 Changeset [111008] by loislo@chromium.org

Web Inspector: Heap Snapshot: Unreviewed single line fix for isWindow getter.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.get isWindow):

07:53 Changeset [111007] by tommyw@google.com

MediaStream API (JSEP): Fixing a few nits
https://bugs.webkit.org/show_bug.cgi?id=81322

Reviewed by Adam Barth.

Addressing the nits from bugs 81206 and 81207.

Nothing to test.

  • Modules/mediastream/SessionDescription.idl:
  • platform/mediastream/IceOptions.h:

(WebCore::IceOptions::IceOptions):

  • platform/mediastream/SessionDescriptionDescriptor.h:

(SessionDescriptionDescriptor):

07:48 Changeset [111006] by commit-queue@webkit.org

[chromium] DRT: Add support for sending gesture scrolls without a begin
https://bugs.webkit.org/show_bug.cgi?id=81292

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-16
Reviewed by Kent Tamura.

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::EventSender):
(EventSender::gestureScrollFirstPoint):

  • DumpRenderTree/chromium/EventSender.h:

(EventSender):

07:44 Companies and Organizations that have contributed to WebKit edited by lfelipe@profusion.mobi
Adding ProFUSION to the list of companies that have contributed to WebKit (diff)
07:43 Changeset [111005] by yurys@chromium.org

Web Inspector: TypeBuilder: Introduce OptOutput class for optional output parameters
https://bugs.webkit.org/show_bug.cgi?id=80789

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-03-16
Reviewed by Yury Semikhatsky.

OptOutput class is added for optional return parameters.

Strict mode added to Generator that makes all parameter types strict
and drop pre-set default values for return parameters.

Debugger and Page domain is switched to strict mode.

  • inspector/CodeGeneratorInspector.py:

(CommandReturnPassModel.OptOutput):
(CommandReturnPassModel.OptOutput.init):
(CommandReturnPassModel.OptOutput.get_return_var_type):
(CommandReturnPassModel.OptOutput.get_output_argument_prefix):
(CommandReturnPassModel.OptOutput.get_output_to_raw_expression):
(CommandReturnPassModel.OptOutput.get_output_parameter_type):
(CommandReturnPassModel):
(CommandReturnPassModel.OptOutput.get_set_return_condition):
(TypeModel.Enum.get_optional.EnumOptional.get_command_return_pass_model):
(TypeModel.ValueType.ValueOptional.get_command_return_pass_model):
(OptOutput):
(Generator.process_event):
(Generator.process_command):

  • inspector/ContentSearchUtils.cpp:

(WebCore::ContentSearchUtils::buildObjectForSearchMatch):
(WebCore::ContentSearchUtils::searchInTextByLines):

  • inspector/ContentSearchUtils.h:

(ContentSearchUtils):

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::evaluate):
(WebCore::InjectedScript::callFunctionOn):
(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::makeEvalCall):

  • inspector/InjectedScript.h:

(InjectedScript):

  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::didInvalidateStyleAttr):
(WebCore::InspectorDOMDebuggerAgent::willInsertDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willRemoveDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willModifyDOMAttr):
(WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::setScriptSource):
(WebCore::InspectorDebuggerAgent::getFunctionDetails):
(WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::didPause):
(WebCore::InspectorDebuggerAgent::breakProgram):
(WebCore::InspectorDebuggerAgent::clearBreakDetails):

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

  • inspector/InspectorPageAgent.cpp:

(WebCore::buildObjectForCookie):
(WebCore::buildArrayForCookies):
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::getResourceTree):
(WebCore::InspectorPageAgent::searchInResource):
(WebCore::InspectorPageAgent::searchInResources):
(WebCore::InspectorPageAgent::buildObjectForFrame):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):

  • inspector/InspectorPageAgent.h:
  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):

07:01 Changeset [111004] by haraken@chromium.org

The IDL parser should support sequence<T> type
https://bugs.webkit.org/show_bug.cgi?id=81345

Reviewed by Adam Barth.

This patch makes the IDL parser support sequence<T> type.
This patch just makes sequence<T> parseable, and the generated code
for sequence<T> is wrong. This issue will be soon fixed in bug 80696.
This is a preparing patch for bug 80696.

Test: bindings/scripts/test/TestObj.idl

  • bindings/scripts/test/TestObj.idl: Added tests for sequence<T>.
  • bindings/scripts/IDLStructure.pm: Updated the regular expressions to support sequence<T>.
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated run-bindings-tests results.

(WebDOMTestObj::sequenceAttr):
(WebDOMTestObj::setSequenceAttr):
(WebDOMTestObj::methodWithSequenceArg):
(WebDOMTestObj::methodReturningSequence):

  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_method_with_sequence_arg):
(webkit_dom_test_obj_method_returning_sequence):
(webkit_dom_test_obj_get_sequence_attr):
(webkit_dom_test_obj_set_sequence_attr):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):
(WebCore::jsTestObjSequenceAttr):
(WebCore::setJSTestObjSequenceAttr):
(WebCore::jsTestObjPrototypeFunctionMethodWithSequenceArg):
(WebCore::jsTestObjPrototypeFunctionMethodReturningSequence):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj sequenceAttr]):
(-[DOMTestObj setSequenceAttr:]):
(-[DOMTestObj methodWithSequenceArg:]):
(-[DOMTestObj methodReturningSequence:]):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::sequenceAttrAttrGetter):
(TestObjInternal):
(WebCore::TestObjInternal::sequenceAttrAttrSetter):
(WebCore::TestObjInternal::methodWithSequenceArgCallback):
(WebCore::TestObjInternal::methodReturningSequenceCallback):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):

06:50 Changeset [111003] by loislo@chromium.org

Web Inspector: HeapSnapshot: merge two long operations into one.
https://bugs.webkit.org/show_bug.cgi?id=81347

Reviewed by Yury Semikhatsky.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype.aggregates):
(WebInspector.HeapSnapshot.prototype._buildAggregates):
(WebInspector.HeapSnapshot.prototype._buildAggregates.forDominatedNodes):

06:45 Changeset [111002] by commit-queue@webkit.org

[Qt] QtWebKit documentation missing a few since 4.6 information
https://bugs.webkit.org/show_bug.cgi?id=81328

Patch by Teemu Katajisto <teemu.katajisto@digia.com> on 2012-03-16
Reviewed by Simon Hausmann.

  • Api/qwebpage.cpp:
  • Api/qwebsettings.cpp:
06:42 Changeset [111001] by kenneth@webkit.org

Merge setVisibleContentsForScaling with setVisibleContentsRectForPanning
https://bugs.webkit.org/show_bug.cgi?id=81346

Reviewed by Simon Hausmann.

This cleans up the code path and is one step on the way to avoid
calling both methods in succession, for instance after ending pinch
zoom.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewLegacyPrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::_q_commitScaleChange):
(QQuickWebViewPrivate::_q_commitPositionChange):

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::setVisibleContentsRect):

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::setVisibleContentsRect):

  • UIProcess/DrawingAreaProxyImpl.h:

(DrawingAreaProxyImpl):

  • UIProcess/LayerTreeHostProxy.cpp:

(WebKit::LayerTreeHostProxy::setVisibleContentsRect):

  • UIProcess/LayerTreeHostProxy.h:

(LayerTreeHostProxy):

  • UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::WebLayerTreeRenderer::setVisibleContentsRect):

  • UIProcess/WebLayerTreeRenderer.h:

(WebLayerTreeRenderer):

  • WebProcess/WebPage/LayerTreeHost.h:

(WebKit::LayerTreeHost::setVisibleContentsRect):

  • WebProcess/WebPage/LayerTreeHost.messages.in:
  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::setVisibleContentsRect):

  • WebProcess/WebPage/qt/LayerTreeHostQt.h:

(LayerTreeHostQt):

06:35 Changeset [111000] by commit-queue@webkit.org

[BlackBerry] Can not open certain links from bridge applications
https://bugs.webkit.org/show_bug.cgi?id=81197

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-03-16
Reviewed by Rob Buis.

Currently, the engine asks the client to handle some type of requests externally.
But WebPageClient::handleStringPattern is not yet implemented and exposed to
the client. Before that, we still need to give the client a chance to decide
how to handle requests such as 'mailto:'.

To address this problem, r108763 introduced a change that ask the client to
decide how to handle the navigation in dispatchDecidePolicyForNewWindowAction().
This is not intuitive and will bring troubles, because this navigation will
happen in the new page. So the new page client is to decide how to handle
the navigation, not the old one.

This patch reverts r108763 and skips calling WebPageClient::handleStringPattern
since it's not implemented.

This way the new window action will continue, and the logic in
dispatchDecidePolicyForNavigationAction() will handle the navigation correctly.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNewWindowAction):
(WebCore::FrameLoaderClientBlackBerry::decidePolicyForExternalLoad):

06:34 Changeset [110999] by sergio@webkit.org

[GTK] WebKitIconDatabase doesn't keep icons cached
https://bugs.webkit.org/show_bug.cgi?id=56200

Reviewed by Martin Robinson.

Source/WebKit/gtk:

  • GNUmakefile.am: Added new files to compilation.
  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::registerForIconNotification): instruct
the WebView to listen to IconDatabase's notifications.
(WebKit::FrameLoaderClient::dispatchDidReceiveIcon): ask both
WebView and IconDatabase to issue notifications for a new icon.

  • docs/webkitgtk-docs.sgml: updated docs.
  • docs/webkitgtk-sections.txt: ditto.
  • docs/webkitgtk.types: ditto.
  • tests/testicondatabase.c: Added.

(server_callback):
(deleteDatabaseFileIfExists):
(testWebkitIconDatabaseSetPath):
(iconDatabaseGetIconValidCallback):
(iconDatabaseGetIconInvalidCallback):
(iconDatabaseGetIconCancelledCallback):
(mainLoopQuitIfLoadCompleted):
(idleQuitLoopCallback):
(webkitWebViewIconLoaded):
(loadURI):
(faviconDatabaseGetFaviconValidIdle):
(faviconDatabaseGetFaviconInvalidIdle):
(faviconDatabaseGetFaviconCancelledIdle):
(testWebKitFaviconDatabaseGetFavicon):
(testWebKitFaviconDatabaseGetFaviconURI):
(testWebKitFaviconDatabaseRemoveAll):
(testWebKitFaviconDatabaseCloseDatabase):
(main):

  • webkit/webkit.h: added new API.
  • webkit/webkitdefines.h: added WebKitFaviconDatabase.
  • webkit/webkitfavicondatabase.cpp:

(IconDatabaseClientGtk): IconDatabaseClient implementation.
(IconDatabaseClientGtk::performImport):
(IconDatabaseClientGtk::didRemoveAllIcons):
(IconDatabaseClientGtk::didImportIconURLForPageURL):
(IconDatabaseClientGtk::didImportIconDataForPageURL):
(IconDatabaseClientGtk::didChangeIconForPageURL):
(IconDatabaseClientGtk::didFinishURLImport):
(PendingIconRequest): machinery for asynchronous calls.
(PendingIconRequest::PendingIconRequest):
(PendingIconRequest::~PendingIconRequest):
(PendingIconRequest::pageURI):
(PendingIconRequest::asyncResult):
(PendingIconRequest::asyncResultCancel):
(PendingIconRequest::asyncResultCompleteInIdle):
(PendingIconRequest::asyncResultComplete):
(_WebKitIconDatabasePrivate):
(webkit_favicon_database_dispose): GObject stuff.
(webkit_favicon_database_set_property): ditto.
(webkit_favicon_database_get_property): ditto.
(webkit_favicon_database_class_init): ditto.
(webkit_favicon_database_init): ditto.
(webkitFaviconDatabaseNotifyAndUpdateExpiration): notify about new
icons and update expiration times.
(webkitFaviconDatabaseDispatchDidReceiveIcon): "protected" method
called by the FrameLoaderClient to inform about new icons.
(webkit_favicon_database_get_path): retrieves database path.
(selectQueryCallback): releases expired icons to let IconDatabase
prune them.
(webkitFaviconDatabasePruneExpiredIcons): selects the icons to be
pruned by the IconDatabase.
(webkitFaviconDatabaseClose): close the database.
(createExpirationTimesDatabaseTableIfNotExists): creates the
database used to control expiration times.
(webkit_favicon_database_set_path): opens the database delaying the
cleanup of icons until the import is complete.
(webkit_favicon_database_get_favicon_uri): returns the uri of the
favicon.
(getIconPixbufSynchronously): helper function to call
IconDatabase::synchronousIconURLForPageURL().
(webkit_favicon_database_try_get_favicon_pixbuf): returns the
favicon if exists and is loaded from disk.
(webkitFaviconDatabaseGetOrCreateRequests): helper function to get
the vector of pending requests for the given uri.
(webkitfavicondatabaseDeleteRequests): helper function to remove the
vector of pending requests for the given uri.
(getIconPixbufCancelled):
(webkitFaviconDatabaseGetIconPixbufCancelled):
(webkit_favicon_database_get_favicon_pixbuf): asynchronously
retrieve icons from the database.
(webkit_favicon_database_get_favicon_pixbuf_finish): finishes an
operation started with webkit_icon_database_get_icon_pixbuf().
(webkitFaviconDatabaseProcessPendingIconsForURI): process pending
requests once the import is finished.
(webkitFaviconDatabaseImportFinished): check pending requests and
delete those that ask for icons that do not exist in the database.
(webkit_favicon_database_clear): clears the database.

  • webkit/webkitfavicondatabase.h: added.

(_WebKitFaviconDatabase):
(_WebKitFaviconDatabaseClass):

  • webkit/webkitfavicondatabaseprivate.h: Added.
  • webkit/webkitglobals.cpp:

(webkit_get_favicon_database): retrieves the new
WebKitFaviconDatabase.
(webkitExit): unref icon database on exit.

  • webkit/webkitglobals.h: added new API.
  • webkit/webkiticondatabase.cpp: added deprecation documentation.

(webkit_icon_database_class_init):

  • webkit/webkitwebview.cpp:

(webkit_web_view_try_get_icon_pixbuf): new API that uses the new
WebKitFaviconDatabase API.
(webkitWebViewIconLoaded): dispatch the icon-loaded signal when
requested by the FrameLoaderClient.
(webkitWebViewRegisterForIconNotification): starts/stops listening
to icon database notifications.

  • webkit/webkitwebview.h: added new API.
  • webkit/webkitwebviewprivate.h: added some protected methods.

Tools:

Add support for favicons in GtkLauncher.

  • GtkLauncher/main.c:

(activateUriEntryCb):
(iconLoadedCb):
(createBrowser):

06:25 Changeset [110998] by gavinp@chromium.org

Add asserts and improve logging in PageCache.
https://bugs.webkit.org/show_bug.cgi?id=81179

Reviewed by Brady Eidson.

The early exits from logCanCacheFrameDecision had the potential to skew histogram data. Moving
the DocumentLoader check to the top, but eliminating the early exits is a compromise that keeps
the logged data mostly accurate.

  • history/PageCache.cpp:

(WebCore::logCanCacheFrameDecision):

06:13 Changeset [110997] by abarth@webkit.org

Remove sheriff-bot's last-green-revision command
https://bugs.webkit.org/show_bug.cgi?id=81314

Reviewed by Eric Seidel.

This command is a cruel joke. WebKit doesn't really ever have a
last-green-revision.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:

(BuildBot._find_green_revision):

  • Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:

(MockBuildBot.builder_statuses):

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

(test_find_green_revision):

  • Scripts/webkitpy/tool/bot/irc_command.py:

(IRCCommand.execute):

  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:

(SheriffIRCBotTest.test_help):

  • Scripts/webkitpy/tool/commands/queries.py:

(PatchesToReview.execute):

06:05 Changeset [110996] by commit-queue@webkit.org

[Forms] label.form attribute doesn't work
https://bugs.webkit.org/show_bug.cgi?id=80499

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-16
Reviewed by Kent Tamura.

Source/WebCore:

This patch changes implementation of label.form of IDL attribute to
compute it to the form element specified by the "form" HTML attribute
or form ancestor when the "form" HTML attribute isn't in HTML.

This patch introduces new function FormAssociatedElement::findAssociatedForm
for sharing code among FormAssociateElement::insertedIntoTree, resetFormOwner
and HTMLLabelElement::form.

No new tests. Update existing tests.

  • html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::findAssociatedForm): Added.
(WebCore):
(WebCore::FormAssociatedElement::insertedIntoTree):
(WebCore::FormAssociatedElement::resetFormOwner):

  • html/FormAssociatedElement.h:

(FormAssociatedElement):

  • html/HTMLLabelElement.cpp: Remove unused include files

(WebCore::HTMLLabelElement::form): Added.

LayoutTests:

This patch updates test cases and expectation for functional
"form" attribute of the "label" element.

  • fast/forms/form-attribute-expected.txt:
  • fast/forms/form-attribute-nonexistence-form-id-expected.txt:
  • fast/forms/form-attribute-nonexistence-form-id.html:
  • fast/forms/form-attribute.html:
06:00 Changeset [110995] by kenneth@webkit.org

Use the normalize method of FloatPoint instead of normalizing manually
https://bugs.webkit.org/show_bug.cgi?id=81343

Reviewed by Simon Hausmann.

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::coverWithTilesIfNeeded):
(WebCore::TiledBackingStore::computeCoverAndKeepRect):

05:54 UsingGitHub edited by jarred@sencha.com
(diff)
05:51 UsingGitHub edited by jarred@sencha.com
(diff)
05:50 Changeset [110994] by haraken@chromium.org

Move Notifications APIs from DOMWindow.idl to DOMWindowNotifications.idl
https://bugs.webkit.org/show_bug.cgi?id=79636

Reviewed by Adam Barth.

For WebKit modularization, this patch moves Notifications-related APIs
from DOMWindow.idl to DOMWindowNotifications.idl.

Tests: fast/notifications/* (No change in test results)

  • CMakeLists.txt: Added DOMWindowNotifications.{h,cpp,idl}.
  • DerivedSources.make: Ditto.
  • DerivedSources.pri: Ditto.
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.exp.in: Added mangled signatures of webkitNotifications().
  • notifications/DOMWindowNotifications.cpp: Added.

(WebCore):
(WebCore::DOMWindowNotifications::DOMWindowNotifications):
(WebCore::DOMWindowNotifications::~DOMWindowNotifications):
(WebCore::DOMWindowNotifications::from):
(WebCore::DOMWindowNotifications::webkitNotifications):
(WebCore::DOMWindowNotifications::ensureWebkitNotifications):
(WebCore::DOMWindowNotifications::disconnectFrame):

  • notifications/DOMWindowNotifications.h: Added.

(WebCore):
(DOMWindowNotifications):

  • notifications/DOMWindowNotifications.idl: Added.
  • page/DOMWindow.cpp: Removed ENABLE(NOTIFICATIONS).

(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::willDetachPage):
(WebCore::DOMWindow::clear):

  • page/DOMWindow.h: Ditto.

(WebCore):
(DOMWindow):

  • page/DOMWindow.idl: Ditto.
  • page/Frame.cpp: Ditto.

(WebCore::Frame::willDetachPage):
(WebCore::Frame::transferChildFrameToNewDocument):

05:49 UsingGitHub edited by jarred@sencha.com
(diff)
05:46 Changeset [110993] by vestbo@webkit.org

[Qt] Make gccdepends test aware of broken icecream deps generation

Icecream seems to build the files without passing -o to gcc with
the original destination path, which means the target name in the
dependency file is wrong.

Also, echo something to the final file instead of just touching it,
so it's not deleted on every build.

Reviewed by Simon Hausmann.

05:31 Changeset [110992] by haraken@chromium.org

[Performance] Optimize innerHTML and outerHTML
https://bugs.webkit.org/show_bug.cgi?id=81214

Reviewed by Adam Barth.

This patch makes innerHTML and outerHTML 2.4 times faster.

Performance test: https://bugs.webkit.org/attachment.cgi?id=132034
The performance test measures body.innerHTML for 3000 lines of HTML,
which is copied from the HTML spec.

  • Chromium/Mac without the patch

div.innerHTML: 1658.6 ms
div.outerHTML: 4859.6 ms
body.innerHTML: 640.2 ms
body.outerHTML: 641.8 ms

  • Chromium/Mac with the patch

div.innerHTML: 751.0 ms
div.outerHTML: 2096.0 ms
body.innerHTML: 271.2 ms
body.outerHTML: 271.2 ms

  • Chromium/Linux without the patch

div.innerHTML: 950.4 ms
div.outerHTML: 2257.8 ms
body.innerHTML: 452.8 ms
body.outerHTML: 457.6 ms

  • Chromium/Linux with the patch

div.innerHTML: 582.4 ms
div.outerHTML: 1283.0 ms
body.innerHTML: 233.0 ms
body.outerHTML: 233.4 ms

  • AppleWebKit/Mac without the patch

div.innerHTML: 900.6 ms
div.outerHTML: 2245.2 ms
body.innerHTML: 462.6 ms
body.outerHTML: 468.0 ms

  • AppleWebKit/Mac with the patch

div.innerHTML: 529.8 ms
div.outerHTML: 1090.2 ms
body.innerHTML: 239.2 ms
body.outerHTML: 239.2 ms

This patch applies the following two optimizations:

(a) Remove redundant copies between Vector<String> and StringBuilders
in MarkupAccumulator::serializeNodes(), MarkupAccumulator::appendStartTag(),
and MarkupAccumulator::appendEndTag().

(Previous behavior)

  • Create a StringBuilder for each tag.
  • Append a created string in each StringBuilder to Vector<String>, parsing the DOM tree.
  • After the parsing, allocate a StringBuilder whose size is the sum of all Strings in Vector<String>.
  • Append all Strings in Vector<String> to the StringBuilder. (New behavior)
  • Allocate a StringBuilder with a default buffer size.
  • Append created strings to the StringBuilder, incrementally parsing the DOM tree.

(b) Optimize stringBuilder.append().

(b-1) Replace stringBuilder.append("A") with stringBuilder.append('A').

stringBuilder.append("A") requires to cast the characters to LChar*,
and then call strlen("A"). stringBuilder.append('A') is faster.

(b-2) Replace stringBuilder.append("AB") with stringBuilder.append('A')

and stringBuilder.append('B'). In my experiment, appending characters
one by one is faster than appending the characters at a breath if the
number of characters is less than 3.

(b-3) Hard-code a string length; i.e. replace stringBuilder.append("ABCDE")

with stringBuilder.append("ABCDE", 5). While the former requires to call
strlen("ABCDE"), the latter does not.

(a) improves performance by 170% ~ 200%. (b) improves performance by 30 ~ 40%.

Tests: fast/dom/Range/range-extract-contents.html

fast/dom/serialize-nodes.xhtml
fast/dom/XMLSerializer.html
and all other tests that use innerHTML or outerHTML.
No change in the test results.

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::serializeNodes):
(WebCore::MarkupAccumulator::appendString):
(WebCore::MarkupAccumulator::appendStartTag):
(WebCore::MarkupAccumulator::appendEndTag):
(WebCore::MarkupAccumulator::concatenateMarkup):
(WebCore::MarkupAccumulator::appendQuotedURLAttributeValue):
(WebCore::MarkupAccumulator::appendComment):
(WebCore::MarkupAccumulator::appendDocumentType):
(WebCore::MarkupAccumulator::appendProcessingInstruction):
(WebCore::MarkupAccumulator::appendOpenTag):
(WebCore::MarkupAccumulator::appendAttribute):
(WebCore::MarkupAccumulator::appendCDATASection):

  • editing/MarkupAccumulator.h:

(MarkupAccumulator):

05:23 Changeset [110991] by commit-queue@webkit.org

.: Support for Battery Status API.
https://bugs.webkit.org/show_bug.cgi?id=62698

Enable BATTERY_STATUS for WebKit-Efl.
http://www.w3.org/TR/battery-status/

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-03-16
Reviewed by Adam Barth.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmakeconfig.h.cmake:

Source/WebCore: Support for Battery Status API
https://bugs.webkit.org/show_bug.cgi?id=62698

Battery Status API is implemented under the Navigator class.
Battery Status API has four types of events, and all events are operated based on a callback mechanism.

: onchargingchange, onchargingtimechange, ondischargingtimechange, onlevelchange.

The battery status can be accessed using BatteryManager(navigator.webkitBattery), and battery status is controlled by BatteryController which manages instances of BatteryManager.
When battery status event is raised, BatteryController calls all registered BatteryManager's event dispatcher.
http://www.w3.org/TR/battery-status/

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-03-16
Reviewed by Adam Barth.

Tests: batterystatus/add-listener-from-callback.html

batterystatus/basic-all-types-of-events.html
batterystatus/basic-operation.html
batterystatus/event-after-navigation.html
batterystatus/multiple-frames.html
batterystatus/updates.html
batterystatus/window-property.html

  • CMakeLists.txt:
  • Modules/battery/BatteryClient.h: Added.

(WebCore):
(BatteryClient):
(WebCore::BatteryClient::~BatteryClient):

  • Modules/battery/BatteryController.cpp: Added.

(WebCore):
(WebCore::BatteryController::BatteryController):
(WebCore::BatteryController::~BatteryController):
(WebCore::BatteryController::create):
(WebCore::BatteryController::addListener):
(WebCore::BatteryController::removeListener):
(WebCore::BatteryController::didChangeBatteryStatus):
(WebCore::BatteryController::supplementName):
(WebCore::BatteryController::isActive):
(WebCore::provideBatteryTo):

  • Modules/battery/BatteryController.h: Added.

(WebCore):
(BatteryController):
(WebCore::BatteryController::client):
(WebCore::BatteryController::from):

  • Modules/battery/BatteryManager.cpp: Added.

(WebCore):
(WebCore::BatteryManager::create):
(WebCore::BatteryManager::~BatteryManager):
(WebCore::BatteryManager::BatteryManager):
(WebCore::BatteryManager::charging):
(WebCore::BatteryManager::chargingTime):
(WebCore::BatteryManager::dischargingTime):
(WebCore::BatteryManager::level):
(WebCore::BatteryManager::didChangeBatteryStatus):
(WebCore::BatteryManager::suspend):
(WebCore::BatteryManager::resume):
(WebCore::BatteryManager::stop):

  • Modules/battery/BatteryManager.h: Added.

(WebCore):
(BatteryManager):
(WebCore::BatteryManager::interfaceName):
(WebCore::BatteryManager::scriptExecutionContext):
(WebCore::BatteryManager::batteryControllerDestroyed):
(WebCore::BatteryManager::canSuspend):
(WebCore::BatteryManager::eventTargetData):
(WebCore::BatteryManager::ensureEventTargetData):
(WebCore::BatteryManager::refEventTarget):
(WebCore::BatteryManager::derefEventTarget):

  • Modules/battery/BatteryManager.idl: Added.
  • Modules/battery/BatteryStatus.cpp: Added.

(WebCore):
(WebCore::BatteryStatus::create):
(WebCore::BatteryStatus::BatteryStatus):

  • Modules/battery/BatteryStatus.h: Added.

(WebCore):
(BatteryStatus):
(WebCore::BatteryStatus::charging):
(WebCore::BatteryStatus::chargingTime):
(WebCore::BatteryStatus::dischargingTime):
(WebCore::BatteryStatus::level):

  • Modules/battery/NavigatorBattery.cpp: Added.

(WebCore):
(WebCore::NavigatorBattery::NavigatorBattery):
(WebCore::NavigatorBattery::~NavigatorBattery):
(WebCore::NavigatorBattery::webkitBattery):
(WebCore::NavigatorBattery::from):
(WebCore::NavigatorBattery::batteryManager):

  • Modules/battery/NavigatorBattery.h: Added.

(WebCore):
(NavigatorBattery):

  • Modules/battery/NavigatorBattery.idl: Added.
  • dom/EventNames.h:

(WebCore):

  • dom/EventTargetFactory.in:
  • testing/Internals.cpp:

(WebCore::Internals::setBatteryStatus):
(WebCore):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit: Support for Battery Status API
https://bugs.webkit.org/show_bug.cgi?id=62698

Add include directory and file.
http://www.w3.org/TR/battery-status/

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-03-16
Reviewed by Adam Barth.

  • PlatformEfl.cmake:

Source/WebKit/efl: Support for Battery Status API
https://bugs.webkit.org/show_bug.cgi?id=62698

Add BatteryClientEfl class implementation for the layout tests now.
BatteryClientEfl class is not fully implemented in this patch.
(It will be completed by other patch as necessary in the Efl port.)
http://www.w3.org/TR/battery-status/

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-03-16
Reviewed by Adam Barth.

  • WebCoreSupport/BatteryClientEfl.cpp: Added.

(WebCore):
(WebCore::BatteryClientEfl::BatteryClientEfl):
(WebCore::BatteryClientEfl::setController):
(WebCore::BatteryClientEfl::startUpdating):
(WebCore::BatteryClientEfl::stopUpdating):
(WebCore::BatteryClientEfl::batteryControllerDestroyed):
(WebCore::BatteryClientEfl::setBatteryStatus):

  • WebCoreSupport/BatteryClientEfl.h: Added.

(WebCore):
(BatteryClientEfl):
(WebCore::BatteryClientEfl::~BatteryClientEfl):

  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):

Tools: Support for Battery Status API
https://bugs.webkit.org/show_bug.cgi?id=62698

Add include directory and file.
http://www.w3.org/TR/battery-status/

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-03-16
Reviewed by Adam Barth.

  • Scripts/build-webkit:

LayoutTests: Support for Battery Status API.
https://bugs.webkit.org/show_bug.cgi?id=62698

Add new test cases for Battery Status API.
http://www.w3.org/TR/battery-status/

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-03-16
Reviewed by Adam Barth.

  • batterystatus/add-listener-from-callback-expected.txt: Added.
  • batterystatus/add-listener-from-callback.html: Added.
  • batterystatus/basic-all-types-of-events-expected.txt: Added.
  • batterystatus/basic-all-types-of-events.html: Added.
  • batterystatus/basic-operation-expected.txt: Added.
  • batterystatus/basic-operation.html: Added.
  • batterystatus/event-after-navigation-expected.txt: Added.
  • batterystatus/event-after-navigation.html: Added.
  • batterystatus/multiple-frames-expected.txt: Added.
  • batterystatus/multiple-frames.html: Added.
  • batterystatus/resources/event-after-navigation-new.html: Added.
  • batterystatus/script-tests/add-listener-from-callback.js: Added.

(checkBatteryStatus):
(firstListener):
(secondListener):
(maybeFinishTest):

  • batterystatus/script-tests/basic-all-types-of-events.js: Added.

(checkBatteryStatus):
(battery):

  • batterystatus/script-tests/basic-operation.js: Added.
  • batterystatus/script-tests/event-after-navigation.js: Added.
  • batterystatus/script-tests/multiple-frames.js: Added.

(checkBatteryStatus):
(checkChildBatteryStatus):
(mainFrameListener):
(childFrameListener):
(maybeFinishTest):

  • batterystatus/script-tests/updates.js: Added.

(checkBatteryStatus):
(setBatteryStatus):
(firstListener):
(updateListener):

  • batterystatus/script-tests/window-property.js: Added.

(hasOnBatteryProperty):

  • batterystatus/updates-expected.txt: Added.
  • batterystatus/updates.html: Added.
  • batterystatus/window-property-expected.txt: Added.
  • batterystatus/window-property.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
05:14 Changeset [110990] by commit-queue@webkit.org

check-webkit-style fails on LayoutTests/platform/efl/test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=81007

Patch by Kishore Bolisetty <kbolisetty@innominds.com> on 2012-03-16
Reviewed by Adam Barth.

A dedidcated build slave is available for efl on build.webkit.org.
This change add's an entry for the elf port in list of available port builders.
This is required because test_expectations.py when triggered, looks for a valid port object for the specified port.

  • Scripts/webkitpy/layout_tests/port/builders.py:
04:55 Changeset [110989] by loislo@chromium.org

Web Inspector: HeapSnapshot: speedup buildReverseIndex.
https://bugs.webkit.org/show_bug.cgi?id=81327

Reviewed by Yury Semikhatsky.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype.get maxNodeId):
(WebInspector.HeapSnapshot.prototype._buildNodeIndex):
(WebInspector.HeapSnapshot.prototype._findNearestNodeIndex):
(WebInspector.HeapSnapshot.prototype._getRetainerIndex):
(WebInspector.HeapSnapshot.prototype._buildDominatedNodes):
(WebInspector.HeapSnapshot.prototype):

04:41 Changeset [110988] by commit-queue@webkit.org

[EFL][WK2] Add ProcessLauncherEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=75464

Patch by YoungTaeck Song <youngtaeck.song@samsung.com> on 2012-03-16
Reviewed by Hajime Morita.

Add first version of ProcessLauncherEfl.cpp including launchProcess() and terminateProcess().

  • UIProcess/Launcher/efl/ProcessLauncherEfl.cpp: Added.

(WebKit::ProcessLauncher::launchProcess):
(WebKit::ProcessLauncher::terminateProcess):
(WebKit::ProcessLauncher::platformInvalidate):

04:37 Changeset [110987] by abarth@webkit.org

[webkitpy] StatusServer.next_work_item has an incorrectly named local variable
https://bugs.webkit.org/show_bug.cgi?id=81302

Reviewed by Eric Seidel.

This is a trivial patch, but the variable name turned up in a grep of
webkitpy and looks like copy pasta.

  • Scripts/webkitpy/common/net/statusserver.py:

(StatusServer.next_work_item):

04:29 Changeset [110986] by commit-queue@webkit.org

Unreviewed, rolling out r110976.
http://trac.webkit.org/changeset/110976
https://bugs.webkit.org/show_bug.cgi?id=81330

webkit_unit_tests crashes. (Requested by morrita on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-16

  • loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::error):
(WebCore):

  • loader/cache/CachedCSSStyleSheet.h:

(CachedCSSStyleSheet):

  • loader/cache/CachedFont.cpp:

(WebCore):
(WebCore::CachedFont::error):

  • loader/cache/CachedFont.h:

(CachedFont):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::error):

  • loader/cache/CachedResource.h:

(CachedResource):

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::error):
(WebCore):

  • loader/cache/CachedScript.h:

(CachedScript):

  • loader/cache/CachedXSLStyleSheet.cpp:

(WebCore::CachedXSLStyleSheet::error):
(WebCore):

  • loader/cache/CachedXSLStyleSheet.h:

(CachedXSLStyleSheet):

04:25 Changeset [110985] by macpherson@chromium.org

Implement cast between CSSPrimitiveValue and LineClampValue.
https://bugs.webkit.org/show_bug.cgi?id=76806

Reviewed by Andreas Kling.

Covered by many existing LayoutTests.

This simplifies code in CSSStyleSelector and future mapping to CSSStyleApplyProperty.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator LineClampValue):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

04:03 Changeset [110984] by nduca@chromium.org

[chromium] Bump textureUpdatesPerFrame to 32 to favor updating the screen over jank prevention
https://bugs.webkit.org/show_bug.cgi?id=81298

Reviewed by James Robinson.

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WTF):

03:52 Changeset [110983] by leviw@chromium.org

Update usage of LayoutUnits in RenderBlock*
https://bugs.webkit.org/show_bug.cgi?id=80437

Reviewed by Julien Chaffraix.

Updating LayoutUnit usage in RenderBlock and RenderBlockLineLayout. This better readies trunk for
the transition to subpixel layout.

See https://trac.webkit.org/wiki/LayoutUnit for more details.

No new tests. No changed behavior.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint): Adding the paint offset rounding previously in RenderBlock::paint.

  • rendering/LayoutTypes.h:

(WebCore::floorToInt): Will floor a LayoutUnit to an integer once we switch to
FractionalLayoutUnits.
(WebCore::boundedMultiply): Method that will return the multiplied result of two LayoutUnits
or the max/min LayoutUnit if the result overflows. Only does a regular multiply while
LayoutUnits are integers instead of FractionalLayoutUnits.
(WebCore):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintContents): Rounding the paintOffset here didn't work for all
inline blocks. This rounding is actually only needed for InlineTextBoxes, so the logic has
been moved there.
(WebCore::RenderBlock::newLine): Use a LayoutUnit for the y position.
(WebCore::RenderBlock::isPointInOverflowControl): Points for hit testing need to be rounded.
(WebCore::RenderBlock::layoutColumns): Using boundedMultiply for a calculation prone to overflow.
(WebCore::updatePreferredWidth): Reverting back to using ceilf. ceiledLayoutUnit was to be ultimately
converted to just a straight LayoutUnit constructor to preserve precision. This precision doesn't work
for us here as we still paint Boxes/Blocks on pixel boundaries, so we need to expand to a pixel size
that encloses the contained text.
(WebCore::RenderBlock::setPageLogicalOffset): LogicalOffset should be a LayoutUnit.
(WebCore::RenderBlock::marginValuesForChild): Margins should have subpixel resolution.
(WebCore::RenderBlock::FloatingObjects::intervalForFloatingObject): Intervals for floating objects
need to use pixel snapped values to give the proper results.

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::pixelSnappedLogicalLeftOffsetForLine): Only moved.
(WebCore::RenderBlock::pixelSnappedLogicalRightOffsetForLine): While we can round the left offset,
columns add an extra offset at paint that can't currently be planned for at line-layout time. To
avoid laying out lines that run off the end of columns, we floor the right offset. The resulting
lines will be up to 1 pixel shorter than they potentially could be.
(RenderBlock):
(WebCore::RenderBlock::FloatingObject::pixelSnappedX): Using corresponding pixelSnappedX value from
LayoutRects.
(WebCore::RenderBlock::FloatingObject::pixelSnappedMaxX): Ditto.
(WebCore::RenderBlock::FloatingObject::pixelSnappedY): Ditto.
(WebCore::RenderBlock::FloatingObject::pixelSnappedMaxY): Ditto.
(WebCore::RenderBlock::FloatingObject::pixelSnappedWidth): Ditto.
(WebCore::RenderBlock::FloatingObject::pixelSnappedHeight): Ditto.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded): LogicalHeight is a LayoutUnit. Also
flooring textIndentOffset to an integer to match old behavior.
(WebCore::LineWidth::fitBelowFloats): Using LayoutUnits for float logical top and bottoms.
(WebCore::LineLayoutState::endLineLogicalTop): Changing to a LayoutUnit.
(WebCore::LineLayoutState::setEndLineLogicalTop): Ditto.
(LineLayoutState): Ditto.
(WebCore::RenderBlock::linkToEndLineIfNeeded): Calculating overflow with LayoutUnits.
(WebCore::RenderBlock::layoutInlineChildren): LowestAllowedPosition should be subpixel.
(WebCore::RenderBlock::checkLinesForTextOverflow): Reverting ellipsis width calculation to integers
as this value can be seen as representing pixels on screen.

03:39 Changeset [110982] by leo.yang@torchmobile.com.cn

[BlackBerry] Crash when going back from an xhtml document containing <img>
https://bugs.webkit.org/show_bug.cgi?id=81297

Reviewed by Rob Buis.

This is manually reverting the offending internal commit which checked-in before upstreaming.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::canCachePage):

03:34 Changeset [110981] by kenneth@webkit.org

Follow up to: window.innerWidth/Height should not include page scale https://bugs.webkit.org/show_bug.cgi?id=76555

Reviewed by Simon Hausmann.

Introduce mapping methods for converting between CSS and layout units.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::innerHeight):
(WebCore::DOMWindow::innerWidth):
(WebCore::DOMWindow::scrollX):
(WebCore::DOMWindow::scrollY):
(WebCore::DOMWindow::scrollTo):

  • page/FrameView.h:

(FrameView):
(WebCore::FrameView::mapFromLayoutToCSSUnits):
(WebCore):
(WebCore::FrameView::mapFromCSSToLayoutUnits):

03:29 Changeset [110980] by commit-queue@webkit.org

[chromium] Threaded opacity animation jump to opacity of 0
https://bugs.webkit.org/show_bug.cgi?id=80744

Patch by Ian Vollick <vollick@chromium.org> on 2012-03-16
Reviewed by James Robinson.

Source/WebCore:

Tested in CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::opacityIsAnimating):
(WebCore):
(WebCore::LayerChromium::transformIsAnimating):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):
(WebCore::LayerChromium::drawOpacityIsAnimating):
(WebCore::LayerChromium::setDrawOpacityIsAnimating):

  • platform/graphics/chromium/RenderSurfaceChromium.cpp:

(WebCore::RenderSurfaceChromium::RenderSurfaceChromium):

  • platform/graphics/chromium/RenderSurfaceChromium.h:

(WebCore::RenderSurfaceChromium::drawOpacityIsAnimating):
(WebCore::RenderSurfaceChromium::setDrawOpacityIsAnimating):
(RenderSurfaceChromium):

  • platform/graphics/chromium/cc/CCLayerAnimationController.cpp:

(WebCore::CCLayerAnimationController::isAnimatingProperty):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerAnimationController.h:

(CCLayerAnimationController):

  • platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.cpp:

(WebCore::CCLayerAnimationControllerImpl::isAnimatingProperty):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.h:

(CCLayerAnimationControllerImpl):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::opacityIsAnimating):
(WebCore):
(WebCore::CCLayerImpl::transformIsAnimating):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):
(WebCore::CCLayerImpl::drawOpacityIsAnimating):
(WebCore::CCLayerImpl::setDrawOpacityIsAnimating):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::layerShouldBeSkipped):
(WebCore::subtreeShouldBeSkipped):
(WebCore):
(WebCore::LayerChromium):
(WebCore::calculateDrawTransformsAndVisibilityInternal):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::CCRenderSurface):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore::CCRenderSurface::drawOpacityIsAnimating):
(WebCore::CCRenderSurface::setDrawOpacityIsAnimating):
(CCRenderSurface):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF):
(CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity):
(WTF::CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity::CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity):
(WTF::CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity::beginTest):
(WTF::CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity::animateLayers):
(WTF::CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestDoNotSkipLayersWithAnimatedOpacity::afterTest):
(WTF::TEST_F):

03:21 Changeset [110979] by jocelyn.turcotte@nokia.com

[TexMap] Reuse textures following the same rules as they do internally.
https://bugs.webkit.org/show_bug.cgi?id=80843

Reviewed by Noam Rosenthal.

BitmapTextures were recently changed to be the same size as their contents.
This would obsolete the logic in acquireTextureFromPool which would
assume that a BitmapTexture has good chances of being reused if its
size is bigger or equal to the new size.

This asks the texture instead if it can be reused which now simply
check for an exact size match.

  • platform/graphics/texmap/TextureMapper.cpp:

(WebCore::TextureMapper::acquireTextureFromPool):

  • platform/graphics/texmap/TextureMapper.h:

(WebCore::BitmapTexture::canReuseWith):
(WebCore::BitmapTexture::reset):
(WebCore::BitmapTexture::didReset):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::canReuseWith):
(WebCore):

  • platform/graphics/texmap/TextureMapperGL.h:

(BitmapTextureGL):

03:20 Changeset [110978] by commit-queue@webkit.org

Connect up fling event delivery to gesture curve animation framework
https://bugs.webkit.org/show_bug.cgi?id=80858

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-16
Reviewed by Adam Barth.

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::fireUpAnAnimation):

03:11 FeatureFlags edited by tkent@chromium.org
Add a comment on Hixie76 flag of WebSocket (diff)
02:48 Changeset [110977] by morrita@google.com

Unreviewed gardening, marking a failing test.

  • platform/chromium/test_expectations.txt:
02:40 Changeset [110976] by japhet@chromium.org

Remove duplicate error() impls in CachedResource subclasses
https://bugs.webkit.org/show_bug.cgi?id=81161

Reviewed by Alexey Proskuryakov.

No new tests, refactor only.

  • loader/cache/CachedCSSStyleSheet.cpp:
  • loader/cache/CachedCSSStyleSheet.h:
  • loader/cache/CachedFont.cpp:
  • loader/cache/CachedFont.h:
  • loader/cache/CachedImage.cpp:
  • loader/cache/CachedResource.h: Make checkNotify()

virtual, so the right checkNotify() gets called in error().

  • loader/cache/CachedScript.cpp:
  • loader/cache/CachedScript.h:
  • loader/cache/CachedXSLStyleSheet.cpp:
  • loader/cache/CachedXSLStyleSheet.h:
02:28 Changeset [110975] by philn@webkit.org

Unreviewed, GTK baselines for new tests.

  • platform/gtk/compositing/overflow/ancestor-overflow-expected.txt: Added.
  • platform/gtk/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt: Added.
  • platform/gtk/fast/line-grid/line-align-left-edges-expected.txt: Added.
  • platform/gtk/fast/line-grid/line-align-right-edges-expected.txt: Added.
  • platform/gtk/fast/repaint/transform-rotate-and-remove-expected.txt: Added.
  • platform/gtk/fast/speech/input-appearance-searchandspeech-expected.txt: Added.
  • platform/gtk/fast/speech/input-appearance-speechbutton-expected.txt: Added.
  • platform/gtk/fast/speech/speech-bidi-rendering-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Added.
  • platform/gtk/svg/custom/use-extern-href-expected.txt: Added.
  • platform/gtk/svg/repaint/repainting-after-animation-element-removal-expected.txt: Added.
02:20 Changeset [110974] by philn@webkit.org

Unreviewed, GTK gardening.

  • platform/gtk/Skipped: Skip a new failing editing test
  • platform/gtk/fast/events/resize-events-expected.txt: Added.
  • platform/gtk/test_expectations.txt: Mark

inspector/styles/svg-style.xhtml as flaky.

02:20 Changeset [110973] by commit-queue@webkit.org

[chromium] Changes to overdraw metrics to allow upload tracking
https://bugs.webkit.org/show_bug.cgi?id=81222

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-16
Reviewed by Adrienne Walker.

Source/WebCore:

Stick CCOverdrawMetrics into CCOcclusionTracker, so that it is available
everywhere that culling/drawing/painting is going on. Then we can stop
plumbing a metrics object through CCQuadCuller.

Rename the CCOverdrawMetrics "painting" stuff to "uploading" as this will
measure texture uploads rather than pixels painted in main memory.

Covered by existing tests.

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::CCOcclusionTrackerBase):

  • platform/graphics/chromium/cc/CCOcclusionTracker.h:

(CCOcclusionTrackerBase):
(WebCore::CCOcclusionTrackerBase::overdrawMetrics):

  • platform/graphics/chromium/cc/CCOverdrawMetrics.cpp:

(WebCore::CCOverdrawMetrics::didCull):
(WebCore):
(WebCore::CCOverdrawMetrics::didDraw):
(WebCore::CCOverdrawMetrics::recordMetrics):
(WebCore::CCOverdrawMetrics::recordMetricsInternal):

  • platform/graphics/chromium/cc/CCOverdrawMetrics.h:

(WebCore):
(WebCore::CCOverdrawMetrics::create):
(CCOverdrawMetrics):

  • platform/graphics/chromium/cc/CCQuadCuller.cpp:

(WebCore::CCQuadCuller::CCQuadCuller):
(WebCore::CCQuadCuller::append):

  • platform/graphics/chromium/cc/CCQuadCuller.h:

(CCQuadCuller):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::appendQuadsForLayer):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(WebCore):
(CCRenderPass):

Source/WebKit/chromium:

  • tests/CCQuadCullerTest.cpp:

(WebCore::appendQuads):
(WebCore):
(WebCore::TEST):

  • tests/MockCCQuadCuller.h:

(WebCore::MockCCQuadCuller::MockCCQuadCuller):

01:56 Changeset [110972] by commit-queue@webkit.org

Add TransferList IDL modifier, with support in V8 code gen.
https://bugs.webkit.org/show_bug.cgi?id=81127

Patch by Greg Billock <gbillock@google.com> on 2012-03-16
Reviewed by Adam Barth.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateFunctionCallback):
(GetIndexOf):
(GenerateParametersCheck):
(GenerateConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateFunctionCallString):

  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:

(WebDOMTestSerializedScriptValueInterface::acceptTransferList):

  • bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h:

(WebDOMTestSerializedScriptValueInterface):

  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:

(webkit_dom_test_serialized_script_value_interface_accept_transfer_list):

  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):
(WebCore):
(WebCore::JSTestSerializedScriptValueInterfacePrototype::getOwnPropertySlot):
(WebCore::JSTestSerializedScriptValueInterfacePrototype::getOwnPropertyDescriptor):
(WebCore::jsTestSerializedScriptValueInterfacePrototypeFunctionAcceptTransferList):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(JSTestSerializedScriptValueInterfacePrototype):
(WebCore):

  • bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h:
  • bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm:

(-[DOMTestSerializedScriptValueInterface acceptTransferList:transferList:]):

  • bindings/scripts/test/TestSerializedScriptValueInterface.idl:
  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceInternal::acceptTransferListCallback):
(TestSerializedScriptValueInterfaceInternal):
(WebCore):
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):

01:43 Changeset [110971] by mrowe@apple.com

Merge r110969.

01:43 Changeset [110970] by mrowe@apple.com

Versioning.

01:41 Changeset [110969] by mrowe@apple.com

Build fix. Do not preserve owner and group information when installing the WTF headers.

Source/JavaScriptCore:

Source/WTF:

  • WTF.xcodeproj/project.pbxproj:
01:39 Changeset [110968] by commit-queue@webkit.org

[chromium] Quads that become fully opaque after culling should not use blending
https://bugs.webkit.org/show_bug.cgi?id=81235

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-16
Reviewed by Adrienne Walker.

Source/WebCore:

Unit test: CCLayerTreeHostImplTest.blendingOffWhenDrawingOpaqueLayers

  • platform/graphics/chromium/cc/CCDrawQuad.h:

(WebCore::CCDrawQuad::needsBlending):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKit::BlendStateCheckLayer::appendQuads):
(WebKit::BlendStateCheckLayer::setQuadRect):
(WebKit::BlendStateCheckLayer::setQuadVisibleRect):
(WebKit::BlendStateCheckLayer::setOpaqueContents):
(WebKit::BlendStateCheckLayer::setOpaqueContentRect):
(WebKit::BlendStateCheckLayer::BlendStateCheckLayer):
(BlendStateCheckLayer):
(WebKit::TEST_F):

01:36 Changeset [110967] by mrowe@apple.com

New tag.

01:33 Changeset [110966] by commit-queue@webkit.org

[BlackBerry] viewportRect has changed to viewportSize
https://bugs.webkit.org/show_bug.cgi?id=81262

Patch by Genevieve Mak <gmak@rim.com> on 2012-03-16
Reviewed by Antonio Gomes.

Set size instead of rect in constructor.

  • WebKitSupport/InRegionScrollableArea.cpp:

(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

01:27 Changeset [110965] by xji@chromium.org

Using ICU break iterator to simplify visual word movement implementation.
https://bugs.webkit.org/show_bug.cgi?id=78856

Reviewed by Ryosuke Niwa.

Source/WebCore:

This patch relies on ICU word break iterator and cursor visual movement by character to get the word break
position in visual order. It reduces the complexity of old implementation.

Test: editing/selection/move-by-word-visually-wrong-left-right.html

  • editing/FrameSelection.cpp: Exclude WinCE from visual word movement since isWordTextBreak is not implemented.

(WebCore::FrameSelection::modifyMovingRight):
(WebCore::FrameSelection::modifyMovingLeft):

  • editing/visible_units.cpp:

(WebCore):
(WebCore::previousLeafWithSameEditability): Just moving to the top without functionality change.
(WebCore::enclosingNodeWithNonInlineRenderer): ditto.
(WebCore::nextLeafWithSameEditability): ditto.
(WebCore::previousRootInlineBox): return previous RootInlineBox which is in different renderer.
(WebCore::nextRootInlineBox): return next RootInlineBox which is in different renderer.
(WebCore::boxIndexInVector):
(WebCore::previousBoxInLine): returns logically previous box in one line.
(WebCore::logicallyPreviousBox): returns logically previous box.
(WebCore::nextBoxInLine): returns logically next box in one line.
(WebCore::logicallyNextBox): returns logically next box.
(WebCore::wordBreakIteratorForMinOffsetBoundary): create word break iterator for position that is a box's min offset.
(WebCore::wordBreakIteratorForMaxOffsetBoundary): create word break iterator for position that is a box's max offset.
(WebCore::isLogicalStartOfWord): return whether a position is logically start of word.
(WebCore::islogicalEndOfWord): return whether a position is logically end of word.
(WebCore::visualWordPosition): returns the visual left or right word position.
(WebCore::leftWordPosition):
(WebCore::rightWordPosition):

  • platform/text/TextBreakIterator.h: Add isWordTextBreak().

(WebCore):

  • platform/text/TextBreakIteratorICU.cpp:

(WebCore::isWordTextBreak):
(WebCore):

  • platform/text/gtk/TextBreakIteratorGtk.cpp:

(WebCore::isWordTextBreak):
(WebCore):

  • platform/text/qt/TextBreakIteratorQt.cpp:

(WebCore::isWordTextBreak):
(WebCore):

  • platform/text/wince/TextBreakIteratorWinCE.cpp:

(WebCore::isWordTextBreak):
(WebCore):

LayoutTests:

  • editing/selection/move-by-word-visually-inline-block-positioned-element-expected.txt:
  • editing/selection/move-by-word-visually-inline-block-positioned-element.html: The word break stops at the beginning of fixed positioned element, which is correct and consistent behavior.
  • editing/selection/move-by-word-visually-multi-line-expected.txt:
  • editing/selection/move-by-word-visually-multi-line.html: The word break does not stop at the end of a text if there is next line of text available under the same editable root, which is a consistent behavior cross the board. Add more test cases, including one with non InlineTextBox.
  • editing/selection/move-by-word-visually-single-space-inline-element-expected.txt: Fixing of previously missing or extra word break positions.
  • editing/selection/move-by-word-visually-single-space-one-element-expected.txt:
  • editing/selection/move-by-word-visually-single-space-one-element.html: Add a test case including bidi control character which renders wrong result since right-arrow could not reach a position which is the word break position. Add another test case containing non InlineTextBox.
  • editing/selection/move-by-word-visually-wrong-left-right-expected.txt: Added.
  • editing/selection/move-by-word-visually-wrong-left-right.html: Added. Add a test case which renders wrong result due to left/right-arrow returns wrong result.
  • editing/selection/resources/move-by-word-visually.js:

(moveByWordOnEveryChar): Handle a special case when left/right arrow missing certain position.

01:20 Changeset [110964] by commit-queue@webkit.org

[chromium] Don't create a quad for video layers without a frame (avoid use of uninitialized m_format)
https://bugs.webkit.org/show_bug.cgi?id=81250

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-16
Reviewed by James Robinson.

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::appendQuads):

01:19 Changeset [110963] by commit-queue@webkit.org

[BlackBerry] Enable PAGE_VISIBILITY_API
https://bugs.webkit.org/show_bug.cgi?id=81257

Source/WebKit/blackberry:

Set Page visibility state for BlackBerry port.

Patch by Andrew Lo <anlo@rim.com> on 2012-03-16
Reviewed by Rob Buis.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::setPageVisibilityState):
(BlackBerry::WebKit::WebPagePrivate::setVisible):
(BlackBerry::WebKit::WebPage::setVisible):
(BlackBerry::WebKit::WebPagePrivate::notifyAppActivationStateChange):
(BlackBerry::WebKit::WebPage::notifyAppActivationStateChange):

  • Api/WebPage_p.h:

(WebPagePrivate):

Tools:

Enable Page Visibility API for BlackBerry.

Patch by Andrew Lo <anlo@rim.com> on 2012-03-16
Reviewed by Rob Buis.

  • Scripts/build-webkit:
01:12 Changeset [110962] by morrita@google.com

Unreviewed attempt to fix Chromium windows build.

  • Modules/speech/SpeechRecognition.h:

(SpeechRecognition):

01:11 Changeset [110961] by reed@google.com

make test for rebaselining after skia 3398 lands
https://bugs.webkit.org/show_bug.cgi?id=81246

Unreviewed. expectations only

  • platform/chromium/test_expectations.txt:
01:00 Changeset [110960] by commit-queue@webkit.org

[Gtk] Add computedStyleIncludingVisitedInfo to DumpRenderTreeSupport
https://bugs.webkit.org/show_bug.cgi?id=81232

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-03-16
Reviewed by Philippe Normand.

Source/WebKit/gtk:

Add computedStyleIncludingVisitedInfo helper method to
DumpRenderTreeSupportGtk.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::computedStyleIncludingVisitedInfo):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Tools:

Use the newly-added helper method in DumpRenderTreeSupportGtk.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::computedStyleIncludingVisitedInfo):

LayoutTests:

Unskip now-passing tests.

  • platform/gtk/Skipped:
  • platform/gtk/fast/history/nested-visited-test-expected.txt: Removed.
  • platform/gtk/fast/history/self-is-visited-expected.txt: Removed.
  • platform/gtk/fast/history/sibling-visited-test-expected.txt: Removed.
00:57 Changeset [110959] by commit-queue@webkit.org

[Gtk] Properly set forms tests-specific settings
https://bugs.webkit.org/show_bug.cgi?id=81237

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-03-16
Reviewed by Philippe Normand.

Source/WebKit/gtk:

Call Settings::setInteractiveFormValidationEnabled and
Settings::setValidationMessageTimerMagnification with
proper values when in testing mode.

  • webkit/webkitwebview.cpp:

(webkit_web_view_init):

LayoutTests:

Unskip newly-passing tests.

  • platform/gtk/Skipped:
  • platform/gtk/fast/forms/validation-message-appearance-expected.txt: Added.
00:44 Changeset [110958] by morrita@google.com

Unreviewed expectations update.

  • platform/chromium-linux/fast/events/resize-events-expected.png: Added.
  • platform/chromium-mac-leopard/fast/events/resize-events-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/events/resize-events-expected.png: Added.
  • platform/chromium-mac/fast/events/resize-events-expected.png: Added.
  • platform/chromium-mac/fast/events/resize-events-expected.txt: Added.
  • platform/chromium-win/fast/events/resize-events-expected.png: Added.
  • platform/chromium-win/fast/events/resize-events-expected.txt: Added.
00:44 Changeset [110957] by commit-queue@webkit.org

Move DOMWindowFileSystem to Modules/filesystem/
https://bugs.webkit.org/show_bug.cgi?id=81030

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-03-16
Reviewed by Adam Barth.

No new tests, all existing tests pass.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • Modules/filesystem/DOMWindowFileSystem.cpp: Copied from Source/WebCore/fileapi/DOMWindowFileSystem.cpp.
  • Modules/filesystem/DOMWindowFileSystem.h: Copied from Source/WebCore/fileapi/DOMWindowFileSystem.h.
  • Modules/filesystem/DOMWindowFileSystem.idl: Copied from Source/WebCore/fileapi/DOMWindowFileSystem.idl.
  • Target.pri:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.vcproj/copyForwardingHeaders.cmd:
  • fileapi/DOMWindowFileSystem.cpp: Removed.
  • fileapi/DOMWindowFileSystem.h: Removed.
  • fileapi/DOMWindowFileSystem.idl: Removed.
00:34 Changeset [110956] by commit-queue@webkit.org

Unreviewed, rolling out r110951.
http://trac.webkit.org/changeset/110951
https://bugs.webkit.org/show_bug.cgi?id=81316

Does not build on apple-mac (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-16

Source/WebCore:

  • platform/audio/DynamicsCompressor.h:

(DynamicsCompressor):

  • webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
(WebCore::DynamicsCompressorNode::process):

  • webaudio/DynamicsCompressorNode.h:

(DynamicsCompressorNode):

  • webaudio/DynamicsCompressorNode.idl:

LayoutTests:

  • webaudio/dynamicscompressor-basic-expected.txt:
  • webaudio/dynamicscompressor-basic.html:
00:31 Changeset [110955] by reed@google.com

to be rebaselined after hairline clipping fix in skia lands
https://bugs.webkit.org/show_bug.cgi?id=81233

Unreviewed. expectations change only

  • platform/chromium/test_expectations.txt:
00:23 Changeset [110954] by eae@chromium.org

Merge trunk changes up until r110884 into subpixel branch.

00:17 Changeset [110953] by commit-queue@webkit.org

Cleanup empty attribute list in IDLs
https://bugs.webkit.org/show_bug.cgi?id=81228

Patch by Seo Sanghyeon <sh4.seo@samsung.com> on 2012-03-16
Reviewed by Adam Barth.

No tests. No change in behavior.

  • css/WebKitCSSRegionRule.idl:
00:05 Changeset [110952] by psolanki@apple.com

onorientationchange event should have JSWindowEventListener attribute
https://bugs.webkit.org/show_bug.cgi?id=79513

Reviewed by Kentaro Hara.

  • html/HTMLFrameSetElement.idl:
Note: See TracTimeline for information about the timeline view.