Timeline


and

04/01/12:

23:54 Changeset [112832] by abarth@webkit.org
  • 6 edits
    2 copies
    1 move
    2 adds in trunk/Source

[Chromium] Move thread-related APIs from WebKit into Platform
https://bugs.webkit.org/show_bug.cgi?id=82858

Reviewed by Eric Seidel.

Source/Platform:

  • Platform.gypi:
  • chromium/public/WebThread.h: Copied from Source/WebKit/chromium/public/platform/WebThread.h.
  • chromium/public/WebThreadSafeData.h: Copied from Source/WebKit/chromium/public/platform/WebThreadSafeData.h.

Source/WebCore:

This is part of the change discussed in
https://lists.webkit.org/pipermail/webkit-dev/2012-March/020166.html

  • WebCore.gypi:
  • platform/chromium/support/WebThreadSafeData.cpp: Copied from Source/WebKit/chromium/src/WebThreadSafeData.cpp.

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/platform/WebThread.h: Replaced.
  • public/platform/WebThreadSafeData.h: Replaced.
  • src/WebThreadSafeData.cpp: Removed.
22:21 Changeset [112831] by rniwa@webkit.org
  • 2 edits in trunk

Perf-o-matic build fix after 112829 for Chromium-style tests.

  • Websites/webkit-perf.appspot.com/report_process_handler.py:

(ReportProcessHandler.post):

22:07 Changeset [112830] by tkent@chromium.org
  • 5 edits in trunk/Source/WebCore

Fix some problems of text field decoration
https://bugs.webkit.org/show_bug.cgi?id=82693

Reviewed by Dimitri Glazkov.

  • Fix a problem that decorations are not removed when the input type is

changed.

  • Add a comment to the 'willDetach' callback.

No new tests because the behavior changes are not visible yet.

  • GNUMakefile.list.am: Add HTMLShadowElement.*.
  • html/InputType.cpp:

(WebCore::InputType::destroyShadowSubtree):
Remove all of ShadowRoot contents, and add a <shadow> element to each of
them. We don't remove ShadowRoots from the tree because it's not
supported well.

  • html/shadow/TextFieldDecorationElement.cpp:

(getDecorationRootAndDecoratedRoot): A helper function for decorate().
If the input element has a ShadowRoot with single <shadow> child, we
don't create new ShadowRoot and reuse it.
(WebCore::TextFieldDecorationElement::decorate):
Use getDecorationRootAndDecoratedRoot().

  • html/shadow/TextFieldDecorationElement.h:

(TextFieldDecorator): Add a comment to willDetach().

21:48 Changeset [112829] by rniwa@webkit.org
  • 7 edits in trunk

perf-o-matic should store test results' units
https://bugs.webkit.org/show_bug.cgi?id=82852

Reviewed by Kentaro Hara.

.:

  • Websites/webkit-perf.appspot.com/models.py:

(Test):
(Test.update_or_insert): Added "unit" to the argument list.
(Test.update_or_insert.execute): Store the unit.
(ReportLog.results_are_well_formed): Moved from ReportHandler.
(ReportLog.results_are_well_formed._is_float_convertible): Ditto.

  • Websites/webkit-perf.appspot.com/models_unittest.py:

(TestModelTests.test_update_or_insert): Added a test case for "unit" argument.
(TestModelTests.test_update_or_insert_to_update): Ditto.
(ReportLogTests.test_results_are_well_formed): Added.
(ReportLogTests.test_results_are_well_formed.assert_results_are_well_formed): Added.

  • Websites/webkit-perf.appspot.com/report_handler.py:

(ReportHandler.post): Calls ReportLog.results_are_well_formed.

  • Websites/webkit-perf.appspot.com/report_process_handler.py:

(ReportProcessHandler.post): Passes resultsunit? to Test.update_or_insert.

Tools:

Include units in the results JSON.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._process_chromium_style_test_result):
(PerfTestsRunner._process_parser_test_result):

21:36 Changeset [112828] by darin@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix incorrect path for libWTF.a in Mac project file.

  • JavaScriptCore.xcodeproj/project.pbxproj: Removed the "../Release" prefix that

would cause other configurations to try to link with the "Release" version of
libWTF.a instead of the correct version.

21:17 FeatureFlags edited by tkent@chromium.org
Rename INPUT_COLOR to INPUT_TYPE_COLOR (diff)
20:51 Changeset [112827] by abarth@webkit.org
  • 2 edits in trunk/Websites/bugs.webkit.org

Code review tool no longer needs to work around position:fixed handling on iPad
https://bugs.webkit.org/show_bug.cgi?id=82850

Reviewed by Eric Seidel.

We no longer need to avoid position:fixed on iPad because Mobile Safari
now does something reasonable with position:fixed elements.

  • code-review.js:
19:53 Changeset [112826] by commit-queue@webkit.org
  • 5 edits in trunk

[WebSocket]Reserved bits test case should cover both extension and no-extension scenarios
https://bugs.webkit.org/show_bug.cgi?id=82100

Patch by Li Yin <li.yin@intel.com> on 2012-04-01
Reviewed by Kent Tamura.

Source/WebCore:

When it had no negotiated deflate-frame extension, if browser received the frame with
setting compressed bit, it should fail the connection, and it should cover both
enabling ZLIB port and disabling ZLIB port.

Test: http/tests/websocket/tests/hybi/reserved-bits.html

  • Modules/websockets/WebSocketDeflateFramer.cpp:

(WebCore::WebSocketDeflateFramer::inflate):

LayoutTests:

Solve the problem that Qt Webkit failed when runing the reserved-bits.html
Support both enabled ZLIB and disabled ZLIB scenarios.

  • http/tests/websocket/tests/hybi/reserved-bits-expected.txt:
  • http/tests/websocket/tests/hybi/reserved-bits_wsh.py:

(_get_deflate_frame_extension_processor):
(web_socket_do_extra_handshake):

19:43 Changeset [112825] by abarth@webkit.org
  • 11 edits in trunk

Clean up Document::canNavigate
https://bugs.webkit.org/show_bug.cgi?id=82282

Reviewed by Eric Seidel.

Source/WebCore:

This patch is just a minor clean up to Document::canNavigate. Eric
asked me to clean up the function when I moved it from FrameLoader. I'm
not sure this patch is much of a win, but at least the comments say
things that are more sensible now.

  • dom/Document.cpp:

(WebCore::printNavigationErrorMessage):
(WebCore):
(WebCore::Document::canNavigate):

LayoutTests:

Update these test results to show that we're better at printing error
messages now.

  • http/tests/security/no-popup-from-sandbox-top-expected.txt:
  • http/tests/security/sandboxed-iframe-form-top-expected.txt:
19:12 Changeset [112824] by rniwa@webkit.org
  • 3 edits in trunk

Admin page should lexicologically sort tests
https://bugs.webkit.org/show_bug.cgi?id=82849

Rubber-stamped by Hajime Morita.

  • Websites/webkit-perf.appspot.com/js/admin.js:
  • Websites/webkit-perf.appspot.com/js/config.js:

(sortProperties):
(fetchDashboardManifest):

18:55 Changeset [112823] by rniwa@webkit.org
  • 2 edits in trunk

Revert an inadvertently committed change.

  • Websites/webkit-perf.appspot.com/app.yaml:
18:46 Changeset [112822] by rniwa@webkit.org
  • 11 edits in trunk

perf-o-matic should have a way to hide some platforms and tests
https://bugs.webkit.org/show_bug.cgi?id=82842

Reviewed by Hajime Morita.

  • Websites/webkit-perf.appspot.com/admin.html:
  • Websites/webkit-perf.appspot.com/admin_handlers.py:

(AdminDashboardHandler.get_branches): Change the json format to allow platforms and tests to have
"hidden" boolean states.
(AdminDashboardHandler.get_platforms): Ditto.
(AdminDashboardHandler.get_builders): Just a cleanup. There is no clean for it to have a limit.
(AdminDashboardHandler.get_tests): Change the json format to add "hidden" boolean states.
(ChangeVisibilityHandler): Added.
(ChangeVisibilityHandler.post): Added. Changes the hidden-state (visibility) of a platform and a test.

  • Websites/webkit-perf.appspot.com/app.yaml: Make sure everything under /admin/ requires admin privilege.
  • Websites/webkit-perf.appspot.com/create_handler.py:

(CreateHandler.post): Don't emit LF after 'OK'.

  • Websites/webkit-perf.appspot.com/css/admin.css: Added a bunch of rules for hide/show button.
  • Websites/webkit-perf.appspot.com/js/admin.js:

(submitXHR): Extracted.
(createKeyNameReloader): Added hide/show button on each item and the corresponding ajax request.

  • Websites/webkit-perf.appspot.com/json_generators.py:

(DashboardJSONGenerator.init): Skip hidden tests and platforms.
(ManifestJSONGenerator.init): Ditto.

  • Websites/webkit-perf.appspot.com/json_generators_unittest.py: Added tests to ensure perf-o-matic

doesn't include hidden tests and platforms in dashboard and manifest json responses.
(DashboardJSONGeneratorTest.test_value_with_hidden_platform_and_tesst):
(ManifestJSONGeneratorTest.test_value_two_tests):
(ManifestJSONGeneratorTest.test_value_with_hidden_platform_and_test):

  • Websites/webkit-perf.appspot.com/main.py:
  • Websites/webkit-perf.appspot.com/models.py:

(Platform): Added the "hidden" property.
(Test): Ditto. Also removed the comment about this class only exists for efficiency purposes since that's
no longer true.

17:27 April 2012 Meeting edited by rniwa@webkit.org
(diff)
17:26 April 2012 Meeting edited by rniwa@webkit.org
Add more hackathon ideas (diff)
16:15 Changeset [112821] by jonlee@apple.com
  • 21 edits in trunk/Source

Rename notification properties and functions
https://bugs.webkit.org/show_bug.cgi?id=80482
<rdar://problem/10912432>

Reviewed by Kentaro Hara.

Source/WebCore:

Change method name to close(), and set tag property on Notifications, based on discussions in WG:
http://lists.w3.org/Archives/Public/public-web-notification/2012Mar/0024.html
http://lists.w3.org/Archives/Public/public-web-notification/2012Mar/0013.html

  • notifications/Notification.cpp:

(WebCore::Notification::~Notification): Use close().
(WebCore::Notification::close):

  • notifications/Notification.h:

(Notification):
(WebCore::Notification::cancel): Wrap in ENABLE(LEGACY_NOTIFICATIONS), and use close().
(WebCore::Notification::replaceId): Wrap in ENABLE(LEGACY_NOTIFICATIONS), and use tag().
(WebCore::Notification::setReplaceId): Wrap in ENABLE(LEGACY_NOTIFICATIONS), and use setTag().
(WebCore::Notification::tag):
(WebCore::Notification::setTag):

  • notifications/Notification.idl: Preserve cancel() and replaceID in ENABLE(LEGACY_NOTIFICATIONS), and

close() and tag in ENABLE(NOTIFICATIONS).

Source/WebKit/chromium:

  • src/WebNotification.cpp:

(WebKit::WebNotification::replaceId): Refactor to call tag().

Source/WebKit/mac:

  • WebView/WebNotification.h: Rename replaceID to tag.
  • WebView/WebNotification.mm:

(-[WebNotification tag]):

Source/WebKit/qt:

  • WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationPresenterClientQt::show): Refactor to call tag().
(WebCore::NotificationPresenterClientQt::removeReplacedNotificationFromQueue): Refactor to call tag().

Source/WebKit2:

Rename APIs to use tag.

  • UIProcess/API/C/WKNotification.cpp:

(WKNotificationCopyTag):

  • UIProcess/API/C/WKNotification.h:
  • UIProcess/Notifications/WebNotification.cpp:

(WebKit::WebNotification::WebNotification):

  • UIProcess/Notifications/WebNotification.h:

(WebKit::WebNotification::create):
(WebKit::WebNotification::tag):
(WebNotification):

  • UIProcess/Notifications/WebNotificationManagerProxy.cpp:

(WebKit::WebNotificationManagerProxy::show):

  • UIProcess/Notifications/WebNotificationManagerProxy.h:

(WebNotificationManagerProxy):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showNotification):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::show):

16:12 Changeset [112820] by eric@webkit.org
  • 4 edits
    11 deletes in trunk

Unreviewed, rolling out r112760.
http://trac.webkit.org/changeset/112760
https://bugs.webkit.org/show_bug.cgi?id=82795

Revert addition of webkitseamless. I'll do this work on
GitHub instead to avoid any half-implemented feature concerns.

Source/WebCore:

  • html/HTMLAttributeNames.in:
  • html/HTMLIFrameElement.idl:

LayoutTests:

  • fast/frames/seamless/resources/css-cascade-child.html: Removed.
  • fast/frames/seamless/resources/nested-seamless.html: Removed.
  • fast/frames/seamless/resources/square.html: Removed.
  • fast/frames/seamless/seamless-basic-expected.txt: Removed.
  • fast/frames/seamless/seamless-basic.html: Removed.
  • fast/frames/seamless/seamless-css-cascade-expected.txt: Removed.
  • fast/frames/seamless/seamless-css-cascade.html: Removed.
  • fast/frames/seamless/seamless-nested-expected.txt: Removed.
  • fast/frames/seamless/seamless-nested.html: Removed.
  • fast/frames/seamless/seamless-sandbox-flag-expected.txt: Removed.
  • fast/frames/seamless/seamless-sandbox-flag.html: Removed.
14:22 Changeset [112819] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Simplify the code that gets accelerated compositing output onto the screen
https://bugs.webkit.org/show_bug.cgi?id=82845

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-04-01
Reviewed by Rob Buis.

RIM PR: 136381
The code accounted for a now obsolete setup where we used one OpenGL
window for accelerated compositing and one native window for backing
store output, and let the windowing system composite those two. In that
setup an optimization to try and only update the window that had
changed was viable.

Nowadays, we either use an offscreen surface for accelerated
compositing output, which we blend onto the window containing the
backing store output, or render both backing store and accelerated
compositing output directly to one OpenGL window. We always have to
blit the backingstore contents and draw the accelerated compositing
output every frame with these code paths, so don't try to be clever
about it.

Even when we use an OpenGL window, the compositing surface can be non-
null, so don't try to glFinish() and swap the compositing surface when
the GLES2Context is tied to a window.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
(BlackBerry::WebKit::BackingStorePrivate::blitContents):
(WebKit):

  • Api/BackingStore_p.h:

(BackingStorePrivate):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::drawLayersOnCommit):

  • WebKitSupport/GLES2Context.cpp:

(BlackBerry::WebKit::GLES2Context::swapBuffers):

13:23 Changeset [112818] by timothy@apple.com
  • 2 edits in trunk/Source/WebCore

Fix a crash when closing a tab/window while the Web Inspector is stopped in the debugger.

https://webkit.org/b/82846
rdar://problem/8133494

Reviewed by Yury Semikhatsky.

  • bindings/js/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::didPause): Added assert for page and early return. Also assert that
m_pausedPage is null.
(WebCore::PageScriptDebugServer::didContinue): Page can be null if we are continuing because the Page closed.
So add a null check before using it. Added an assert that the page is null or m_pausedPage.
(WebCore::PageScriptDebugServer::didRemoveLastListener): Added assert for page.

11:40 Changeset [112817] by mitz@apple.com
  • 3 edits in trunk/LayoutTests

Corrected the expected results for this test.

  • platform/mac/fast/text/international/text-spliced-font-expected.png:
  • platform/mac/fast/text/international/text-spliced-font-expected.txt:
11:21 Changeset [112816] by mitz@apple.com
  • 18 edits
    5 copies in trunk

Source/WebCore: Composite Font References is a new established standard (ISO/IEC 14496-28:2012) for specifying
composite fonts from existing physical fonts.
<rdar://problem/10717370>
https://bugs.webkit.org/show_bug.cgi?id=82810

CoreText have already the features enabled, here we added this to WebKit text layout and rendering.
A member function getCompositeFontReferenceFontData is added to the SimpleFontData class for the component font
correspond to the platformData, in this case, a NSFont. This is used when CoreText layout had resulted
a component of the Composite Font Reference and its corresponding SimpleFontData object is then cached
in the SimpleFontData object of the posting font (Composite Font Reference).

When glyphs are encoded to form the GlyphPage for rendering, the Composite Font Reference is handled throught
the CoreText layout path (using CTLine), here the resulting glyph is associated with a font which could
be not the original font request. In this case, these are the component fonts of the Composite Font
Reference. This is then identified and then added to the GlyphPage appropriately.

To support this feature, a member function isCompositeFontReference is added to FontPlatformData to
indicate a font is a Composite Font Reference. Also in order to pass the component font correctly a boolean
isPrinterFont is added to one the FontPlatformData constructors to describe the NSFont.

Patch by Tony Tseung <tseung@apple.com> on 2012-04-01
Reviewed by Dan Bernstein.

Added test LayoutTests/fast/text/international/text-spliced-font.html

  • WebCore.exp.in:

Replaced obsolete FontPlatformData constructor entry.

  • platform/graphics/FontPlatformData.cpp:

(WebCore::FontPlatformData::FontPlatformData):
Copy of the additional m_isCompositeFontReference and m_isPrinterFont data members.

(WebCore::FontPlatformData::operator=):
Assignment of the additional m_isCompositeFontReference and m_isPrinterFont data members.

  • platform/graphics/FontPlatformData.h:

(WebCore::FontPlatformData::FontPlatformData):
(FontPlatformData):
Default value of m_isCompositeFontReference and m_isPrinterFont data members are set to false in various constructors.

(WebCore::FontPlatformData::isCompositeFontReference):
Newly added for Composite Font Reference type font.

(WebCore::FontPlatformData::isPrinterFont):
Newly added for describing the NSFont parameter if is applicable.

(WebCore::FontPlatformData::operator==):
Comparison of the additional m_isCompositeFontReference and m_isPrinterFont data members.

  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::DerivedFontData::~DerivedFontData):
Clean up the cache for component fonts of the Composite Font References.

  • platform/graphics/SimpleFontData.h:

(SimpleFontData):
Added member function const SimpleFontData* getCompositeFontReferenceFontData(NSFont *key) const.

(DerivedFontData):
Added CFDictionary for caching the component font of Composite Font Reference.

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::FontPlatformData):
Data members m_isCompositeFontReference and m_isPrinterFont are initialised and their values are determined in the body of the contructor.

(WebCore::FontPlatformData::setFont):
Data members m_isCompositeFontReference and m_isPrinterFont are determined and set.

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::createFontPlatformData):
Boolean value isUsingPrinterFont is passed in the new FontPlatformData constructor.

  • platform/graphics/mac/GlyphPageTreeNodeMac.cpp:

(WebCore::shouldUseCoreText):
Added the condition for Composite Font Reference type font.

(WebCore::GlyphPage::fill):
In the case of Composite Font Reference, when iterate the runs, component font of Composite Font
Reference is used to fill the glyph index in the GlyphPage.

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::getCompositeFontReferenceFontData):
Newly added method for the component fonts correspond to the platformData, in this case, a NSFont.
This SimpleFontData is created and cached in this object and will only be deleted when the destructor
if this is called.

Tools: Composite Font References is a new established standard (ISO/IEC 14496-28:2012) for specifying
composite fonts from existing physical fonts.
<rdar://problem/10717370>
https://bugs.webkit.org/show_bug.cgi?id=82810

A new test font of this kind as been added to the test tools for running the webkit-tests

Patch by Tony Tseung <tseung@apple.com> on 2012-04-01
Reviewed by Dan Bernstein.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

Added new dependency SampleFont.sfont

  • DumpRenderTree/fonts/SampleFont.sfont: Added.


  • DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
  • DumpRenderTree/mac/DumpRenderTree.mm:

(allowedFontFamilySet):
Added the Composite Font Referene sample font "Hiragino Maru Gothic Monospaced" entry to the fonts white-list

(activateTestingFonts):
Added the registration of the Composite Font Referene sample font

  • WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:

(WTR::allowedFontFamilySet):
Added the Composite Font Referene sample font "Hiragino Maru Gothic Monospaced" entry to the fonts white-list

(WTR::activateFonts):
Added the registration of the Composite Font Referene sample font

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

Added new dependency SampleFont.sfont

  • WebKitTestRunner/fonts/SampleFont.sfont: Added.

LayoutTests: Composite Font References is a new established standard (ISO/IEC 14496-28:2012) for specifying
composite fonts from existing physical fonts.
<rdar://problem/10717370>
https://bugs.webkit.org/show_bug.cgi?id=82810

Added new LayoutTests/fast/text/international/text-spliced-font.html

Patch by Tony Tseung <tseung@apple.com> on 2012-04-01
Reviewed by Dan Bernstein.

  • fast/text/international/text-spliced-font.html: Added.
  • platform/mac/fast/text/international/text-spliced-font-expected.png: Added.
  • platform/mac/fast/text/international/text-spliced-font-expected.txt: Added.
08:09 Changeset [112815] by gyuyoung.kim@samsung.com
  • 22 edits
    39 adds in trunk

Support the Network Information API
https://bugs.webkit.org/show_bug.cgi?id=73528

Reviewed by Adam Barth.

.:

Add network information API feature.

  • Source/cmake/OptionsEfl.cmake: Add NETWORK_INFO feature.
  • Source/cmakeconfig.h.cmake: Add NETWORK_INFO feature.

Source/WebCore:

Network Information APIs is to provide an interface for Web Applications to access
the underlying network information of device. In Web Application case, they need to know
what current network interface it uses. Because, it is important to know current network
information(bandwidth, metered) in mobile domain. Thus, Web Application can let user know
whether current network information via this new functionality. In addition, in streaming
service case, Web Application can control content resolution according to kind of network.

http://dvcs.w3.org/hg/dap/raw-file/tip/network-api/index.html

Tests: networkinformation/add-listener-from-callback.html

networkinformation/basic-all-types-of-events.html
networkinformation/basic-operation.html
networkinformation/event-after-navigation.html
networkinformation/multiple-frames.html
networkinformation/updates.html
networkinformation/window-property.html

  • CMakeLists.txt:
  • Modules/networkinfo/NavigatorNetworkInfoConnection.cpp: Added.

(WebCore):
(WebCore::NavigatorNetworkInfoConnection::NavigatorNetworkInfoConnection):
(WebCore::NavigatorNetworkInfoConnection::~NavigatorNetworkInfoConnection):
(WebCore::NavigatorNetworkInfoConnection::from):
(WebCore::NavigatorNetworkInfoConnection::webkitConnection):

  • Modules/networkinfo/NavigatorNetworkInfoConnection.h: Added.

(WebCore):
(NavigatorNetworkInfoConnection):

  • Modules/networkinfo/NavigatorNetworkInfoConnection.idl: Added.
  • Modules/networkinfo/NetworkInfo.cpp: Added.

(WebCore):
(WebCore::NetworkInfo::NetworkInfo):

  • Modules/networkinfo/NetworkInfo.h: Added.

(WebCore):
(NetworkInfo):
(WebCore::NetworkInfo::create):
(WebCore::NetworkInfo::bandwidth):
(WebCore::NetworkInfo::metered):

  • Modules/networkinfo/NetworkInfoClient.h: Added.

(WebCore):
(NetworkInfoClient):
(WebCore::NetworkInfoClient::~NetworkInfoClient):

  • Modules/networkinfo/NetworkInfoConnection.cpp: Added.

(WebCore):
(WebCore::NetworkInfoConnection::create):
(WebCore::NetworkInfoConnection::NetworkInfoConnection):
(WebCore::NetworkInfoConnection::~NetworkInfoConnection):
(WebCore::NetworkInfoConnection::bandwidth):
(WebCore::NetworkInfoConnection::metered):
(WebCore::NetworkInfoConnection::didChangeNetworkInformation):
(WebCore::NetworkInfoConnection::addEventListener):
(WebCore::NetworkInfoConnection::removeEventListener):
(WebCore::NetworkInfoConnection::eventTargetData):
(WebCore::NetworkInfoConnection::ensureEventTargetData):
(WebCore::NetworkInfoConnection::interfaceName):
(WebCore::NetworkInfoConnection::suspend):
(WebCore::NetworkInfoConnection::resume):
(WebCore::NetworkInfoConnection::stop):

  • Modules/networkinfo/NetworkInfoConnection.h: Added.

(WebCore):
(NetworkInfoConnection):
(WebCore::NetworkInfoConnection::scriptExecutionContext):
(WebCore::NetworkInfoConnection::canSuspend):
(WebCore::NetworkInfoConnection::refEventTarget):
(WebCore::NetworkInfoConnection::derefEventTarget):

  • Modules/networkinfo/NetworkInfoConnection.idl: Added.
  • Modules/networkinfo/NetworkInfoController.cpp: Added.

(WebCore):
(WebCore::NetworkInfoController::NetworkInfoController):
(WebCore::NetworkInfoController::~NetworkInfoController):
(WebCore::NetworkInfoController::create):
(WebCore::NetworkInfoController::addListener):
(WebCore::NetworkInfoController::removeListener):
(WebCore::NetworkInfoController::didChangeNetworkInformation):
(WebCore::NetworkInfoController::isActive):
(WebCore::NetworkInfoController::supplementName):
(WebCore::provideNetworkInfoTo):

  • Modules/networkinfo/NetworkInfoController.h: Added.

(WebCore):
(NetworkInfoController):
(WebCore::NetworkInfoController::client):
(WebCore::NetworkInfoController::from):

  • dom/EventNames.h:

(WebCore):

  • dom/EventTargetFactory.in:
  • testing/Internals.cpp:

(WebCore::Internals::setNetworkInformation):
(WebCore):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit:

  • PlatformEfl.cmake: Add dummy NetworkInfoClientEfl.cpp files in order to support network information API.

Source/WebKit/efl:

Add NetworkInfoClientEfl to support network information API. However,
functions are not implemented yet.

  • WebCoreSupport/NetworkInfoClientEfl.cpp: Added.

(WebCore::NetworkInfoClientEfl::NetworkInfoClientEfl):
(WebCore):
(WebCore::NetworkInfoClientEfl::~NetworkInfoClientEfl):
(WebCore::NetworkInfoClientEfl::startUpdating):
(WebCore::NetworkInfoClientEfl::stopUpdating):
(WebCore::NetworkInfoClientEfl::bandwidth):
(WebCore::NetworkInfoClientEfl::metered):

  • WebCoreSupport/NetworkInfoClientEfl.h: Added.

(NetworkInfoClientEfl):

  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):

Tools:

Add network information API feature to build script.

  • Scripts/build-webkit:

LayoutTests:

Add new test cases for network information API specification.
And also, skip this test cases for other ports.

  • networkinformation/add-listener-from-callback-expected.txt: Added.
  • networkinformation/add-listener-from-callback.html: Added.
  • networkinformation/basic-all-types-of-events-expected.txt: Added.
  • networkinformation/basic-all-types-of-events.html: Added.
  • networkinformation/basic-operation-expected.txt: Added.
  • networkinformation/basic-operation.html: Added.
  • networkinformation/event-after-navigation-expected.txt: Added.
  • networkinformation/event-after-navigation.html: Added.
  • networkinformation/multiple-frames-expected.txt: Added.
  • networkinformation/multiple-frames.html: Added.
  • networkinformation/resources/event-after-navigation-new.html: Added.
  • networkinformation/script-tests/add-listener-from-callback.js: Added.

(checkNetworkInformation):
(firstListener):
(secondListener):
(maybeFinishTest):

  • networkinformation/script-tests/basic-all-types-of-events.js: Added.

(checkNetworkInformation):

  • networkinformation/script-tests/basic-operation.js: Added.
  • networkinformation/script-tests/event-after-navigation.js: Added.
  • networkinformation/script-tests/multiple-frames.js: Added.

(checkNetworkInformation):
(checkChildNetworkInformation):
(mainFrameListener):
(childFrameListener):
(maybeFinishTest):

  • networkinformation/script-tests/updates.js: Added.

(checkNetworkInformation):
(setNetworkInformation):
(firstListener):
(updateListener):

  • networkinformation/script-tests/window-property.js: Added.

(hasOnConnectionProperty):

  • networkinformation/updates-expected.txt: Added.
  • networkinformation/updates.html: Added.
  • networkinformation/window-property-expected.txt: Added.
  • networkinformation/window-property.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/wincairo/Skipped:
06:40 Changeset [112814] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Use GraphicsContext::fillPath() and strokePath instead of drawPath() in RenderThemeBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=81486

Reviewed by Rob Buis.

RenderThemeBlackBerry was using GraphicsContext::drawPath() that's added for BlackBerry internally.
But we already have fillPath() and strokePath() in GraphicsContext. So just substitute drawPath()
by them. Also fix a build issue by adding a #include line.

No functionalities changed, no new tests.

  • platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::paintTextFieldOrTextAreaOrSearchField):
(WebCore::RenderThemeBlackBerry::paintButton):

05:09 Changeset [112813] by zimmermann@webkit.org
  • 44 edits
    49 adds in trunk

Enable animVal support for SVGAnimatedEnumeration
https://bugs.webkit.org/show_bug.cgi?id=82459

Reviewed by Dirk Schulze.

Source/WebCore:

Enable animVal support for the last missing SVG DOM primitive: SVGAnimatedEnumeration.
It's a bit more involved than the others as we have to differentiate between the various
enumerations to use the correct SVGPropertyTraits<MyEnum>::fromString() code-path.

One SVGAnimatedEnumeration property in the SVG DOM is special: SVGAnimatedEnumeration orientType
from SVGMarkerElement. SVGMarkerElement exposes both the orientType and SVGAnimatedAngle orientAngle
SVG DOM properties and both get mapped to the same SVGNames::orientAttr ("orient" XML attribute).
That means that any animation of the orientAttr has to update both orientType & orientAngle.

This is a not a new requirement, we already support attributes like 'stdDeviation' from
SVGFEGaussianBlurElement, which get mapped to multiple SVG DOM objects: SVGAnimatedInteger stdDeviationX/Y.
The difference is that <integer-optional-integer> or <number-optional-number> animations use the
same type in the pair<xxx, xxx> (eg. both int, or both float). The 'orient' attribute needs to be
mapped to pair<xxx, yyy> types. Generalize the templates in SVGAnimatedTypeAnimator to support that.

Example:
<marker id="someMarkerElement" orient="45deg"/>
<animate fill="remove" begin="1s" dur="2s" from="90deg" to="auto" attributeName="orient" xlink:href="#someMarkerElement"/>

at 0s: someMarkerElement.orientType.animVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE

someMarkerElement.orientAngle.animVal.value = 45

someMarkerElement.orientType.baseVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE
someMarkerElement.orientAngle.baseVal.value = 45

at 1s: someMarkerElement.orientType.animVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE

someMarkerElement.orientAngle.animVal.value = 90

someMarkerElement.orientType.baseVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE
someMarkerElement.orientAngle.baseVal.value = 45

at 2s: someMarkerElement.orientType.animVal = SVGMarkerElement.SVG_MARKER_ORIENT_AUTO

someMarkerElement.orientAngle.animVal.value = 0

someMarkerElement.orientType.baseVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE
someMarkerElement.orientAngle.baseVal.value = 45

3s: someMarkerElement.orientType.animVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE

someMarkerElement.orientAngle.animVal.value = 45

someMarkerElement.orientType.baseVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE
someMarkerElement.orientAngle.baseVal.value = 45

We need to map the 'orient' attribute to a pair<SVGAngle, unsigned short> type, in order
to track both orientAngle & orientType at the same type. Fortunately SVGAnimatedAngle
is only used in the SVG DOM for SVGMarkerElements orientAngle property. We can directly
switch SVGAnimatedAngleAnimator to the new pair<SVGAngle, unsigned short> type instead
of having to introduce a special SVGAnimatedAngleAndEnumerationAnimator.

Added tests for all SVGAnimatedEnumeration properties in the SVG DOM, including an extensive set of tests
for the synchronization of the orientType / orientAngle properties, when they get animated.

Tests: svg/animations/animate-marker-orient-from-angle-to-angle.html

svg/animations/animate-marker-orient-from-angle-to-auto.html
svg/animations/animate-marker-orient-to-angle.html
svg/animations/svgenum-animation-1.html
svg/animations/svgenum-animation-10.html
svg/animations/svgenum-animation-11.html
svg/animations/svgenum-animation-12.html
svg/animations/svgenum-animation-13.html
svg/animations/svgenum-animation-2.html
svg/animations/svgenum-animation-3.html
svg/animations/svgenum-animation-4.html
svg/animations/svgenum-animation-5.html
svg/animations/svgenum-animation-6.html
svg/animations/svgenum-animation-7.html
svg/animations/svgenum-animation-8.html
svg/animations/svgenum-animation-9.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • svg/SVGAllInOne.cpp:
  • svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::determineAnimatedPropertyType):
(WebCore::SVGAnimateElement::calculateAnimatedValue):
(WebCore::propertyTypesAreConsistent):
(WebCore::SVGAnimateElement::applyResultsToTarget):

  • svg/SVGAnimatedAngle.cpp:

(WebCore::SVGAnimatedAngleAnimator::constructFromString):
(WebCore::SVGAnimatedAngleAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedAngleAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedAngleAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedAngleAnimator::animValWillChange):
(WebCore::SVGAnimatedAngleAnimator::animValDidChange):
(WebCore::SVGAnimatedAngleAnimator::calculateFromAndByValues):
(WebCore::SVGAnimatedAngleAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedAngle.h:

(WebCore):

  • svg/SVGAnimatedBoolean.cpp:

(WebCore::SVGAnimatedBooleanAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedBooleanAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedBooleanAnimator::resetAnimValToBaseVal):

  • svg/SVGAnimatedEnumeration.cpp: Added.

(WebCore):
(WebCore::enumerationValueForTargetAttribute):
(WebCore::SVGAnimatedEnumerationAnimator::SVGAnimatedEnumerationAnimator):
(WebCore::SVGAnimatedEnumerationAnimator::constructFromString):
(WebCore::SVGAnimatedEnumerationAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedEnumerationAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedEnumerationAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedEnumerationAnimator::animValWillChange):
(WebCore::SVGAnimatedEnumerationAnimator::animValDidChange):
(WebCore::SVGAnimatedEnumerationAnimator::calculateFromAndToValues):
(WebCore::SVGAnimatedEnumerationAnimator::calculateFromAndByValues):
(WebCore::SVGAnimatedEnumerationAnimator::calculateAnimatedValue):
(WebCore::SVGAnimatedEnumerationAnimator::calculateDistance):

  • svg/SVGAnimatedEnumeration.h:

(SVGAnimatedEnumerationAnimator):
(WebCore::SVGAnimatedEnumerationAnimator::~SVGAnimatedEnumerationAnimator):
(WebCore):

  • svg/SVGAnimatedInteger.cpp:

(WebCore::SVGAnimatedIntegerAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedIntegerAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedIntegerAnimator::resetAnimValToBaseVal):

  • svg/SVGAnimatedIntegerOptionalInteger.cpp:

(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::animValWillChange):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::animValDidChange):

  • svg/SVGAnimatedLength.cpp:

(WebCore::SVGAnimatedLengthAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedLengthAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedLengthAnimator::resetAnimValToBaseVal):

  • svg/SVGAnimatedLengthList.cpp:

(WebCore::SVGAnimatedLengthListAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedLengthListAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedLengthListAnimator::resetAnimValToBaseVal):

  • svg/SVGAnimatedNumber.cpp:

(WebCore::SVGAnimatedNumberAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedNumberAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedNumberAnimator::resetAnimValToBaseVal):

  • svg/SVGAnimatedNumberList.cpp:

(WebCore::SVGAnimatedNumberListAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedNumberListAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedNumberListAnimator::resetAnimValToBaseVal):

  • svg/SVGAnimatedNumberOptionalNumber.cpp:

(WebCore::SVGAnimatedNumberOptionalNumberAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::animValWillChange):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::animValDidChange):

  • svg/SVGAnimatedPreserveAspectRatio.cpp:

(WebCore::SVGAnimatedPreserveAspectRatioAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::resetAnimValToBaseVal):

  • svg/SVGAnimatedRect.cpp:

(WebCore::SVGAnimatedRectAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedRectAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedRectAnimator::resetAnimValToBaseVal):

  • svg/SVGAnimatedString.cpp:

(WebCore::SVGAnimatedStringAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedStringAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedStringAnimator::resetAnimValToBaseVal):

  • svg/SVGAnimatedTransformList.cpp:

(WebCore::SVGAnimatedTransformListAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedTransformListAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedTransformListAnimator::resetAnimValToBaseVal):

  • svg/SVGAnimatedType.cpp:

(WebCore::SVGAnimatedType::~SVGAnimatedType):
(WebCore::SVGAnimatedType::createAngleAndEnumeration):
(WebCore::SVGAnimatedType::createEnumeration):
(WebCore):
(WebCore::SVGAnimatedType::angleAndEnumeration):
(WebCore::SVGAnimatedType::enumeration):
(WebCore::SVGAnimatedType::valueAsString):
(WebCore::SVGAnimatedType::setValueAsString):
(WebCore::SVGAnimatedType::supportsAnimVal):

  • svg/SVGAnimatedType.h:

(SVGAnimatedType):

  • svg/SVGAnimatedTypeAnimator.h:

(WebCore::SVGAnimatedTypeAnimator::findAnimatedPropertiesForAttributeName):
(SVGAnimatedTypeAnimator):
(WebCore::SVGAnimatedTypeAnimator::constructFromBaseValue):
(WebCore::SVGAnimatedTypeAnimator::resetFromBaseValue):
(WebCore::SVGAnimatedTypeAnimator::stopAnimValAnimationForType):
(WebCore::SVGAnimatedTypeAnimator::animValDidChangeForType):
(WebCore::SVGAnimatedTypeAnimator::animValWillChangeForType):
(WebCore::SVGAnimatedTypeAnimator::constructFromBaseValues):
(WebCore::SVGAnimatedTypeAnimator::resetFromBaseValues):
(WebCore::SVGAnimatedTypeAnimator::stopAnimValAnimationForTypes):
(WebCore::SVGAnimatedTypeAnimator::animValDidChangeForTypes):
(WebCore::SVGAnimatedTypeAnimator::animValWillChangeForTypes):
(WebCore::SVGAnimatedTypeAnimator::castAnimatedPropertyToActualType):
(WebCore::SVGAnimatedTypeAnimator::executeAction):

  • svg/SVGAnimatorFactory.h:

(WebCore::SVGAnimatorFactory::create):

  • svg/SVGMarkerElement.cpp:

(WebCore):

  • svg/properties/SVGAnimatedListPropertyTearOff.h:

(SVGAnimatedListPropertyTearOff):

  • svg/properties/SVGAnimatedPropertyTearOff.h:

(SVGAnimatedPropertyTearOff):

  • svg/properties/SVGAnimatedStaticPropertyTearOff.h:

(SVGAnimatedStaticPropertyTearOff):

LayoutTests:

Add new tests for all SVGAnimatedEnumeration in the SVG DOM to proof they animate and update animVal correctly.

  • svg/animations/animate-marker-orient-from-angle-to-angle-expected.txt: Added.
  • svg/animations/animate-marker-orient-from-angle-to-angle.html: Added.
  • svg/animations/animate-marker-orient-from-angle-to-auto-expected.txt: Added.
  • svg/animations/animate-marker-orient-from-angle-to-auto.html: Added.
  • svg/animations/animate-marker-orient-to-angle-expected.txt: Added.
  • svg/animations/animate-marker-orient-to-angle.html: Added.
  • svg/animations/script-tests/animate-marker-orient-from-angle-to-angle.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):

  • svg/animations/script-tests/animate-marker-orient-from-angle-to-auto.js: Added.

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/animate-marker-orient-to-angle.js: Added.

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/svgangle-animation-deg-to-grad.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/svgangle-animation-deg-to-rad.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/svgangle-animation-grad-to-deg.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/svgangle-animation-grad-to-rad.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/svgangle-animation-rad-to-deg.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/svgangle-animation-rad-to-grad.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/script-tests/svgenum-animation-1.js: Added.

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgenum-animation-10.js: Added.

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgenum-animation-11.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(executeTest):

  • svg/animations/script-tests/svgenum-animation-12.js: Added.

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/svgenum-animation-13.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):

  • svg/animations/script-tests/svgenum-animation-2.js: Added.

(sample1):
(sample2):
(sample3):
(executeTest):

  • svg/animations/script-tests/svgenum-animation-3.js: Added.

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgenum-animation-4.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(sample6):
(executeTest):

  • svg/animations/script-tests/svgenum-animation-5.js: Added.

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgenum-animation-6.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):

  • svg/animations/script-tests/svgenum-animation-7.js: Added.

(sample1):
(sample2):
(executeTest):

  • svg/animations/script-tests/svgenum-animation-8.js: Added.

(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(executeTest):

  • svg/animations/script-tests/svgenum-animation-9.js: Added.

(sample1):
(sample2):
(executeTest):

  • svg/animations/svgangle-animation-deg-to-grad-expected.txt:
  • svg/animations/svgangle-animation-deg-to-rad-expected.txt:
  • svg/animations/svgangle-animation-grad-to-deg-expected.txt:
  • svg/animations/svgangle-animation-grad-to-rad-expected.txt:
  • svg/animations/svgangle-animation-rad-to-deg-expected.txt:
  • svg/animations/svgangle-animation-rad-to-grad-expected.txt:
  • svg/animations/svgenum-animation-1-expected.txt: Added.
  • svg/animations/svgenum-animation-1.html: Added.
  • svg/animations/svgenum-animation-10-expected.txt: Added.
  • svg/animations/svgenum-animation-10.html: Added.
  • svg/animations/svgenum-animation-11-expected.txt: Added.
  • svg/animations/svgenum-animation-11.html: Added.
  • svg/animations/svgenum-animation-12-expected.txt: Added.
  • svg/animations/svgenum-animation-12.html: Added.
  • svg/animations/svgenum-animation-13-expected.txt: Added.
  • svg/animations/svgenum-animation-13.html: Added.
  • svg/animations/svgenum-animation-2-expected.txt: Added.
  • svg/animations/svgenum-animation-2.html: Added.
  • svg/animations/svgenum-animation-3-expected.txt: Added.
  • svg/animations/svgenum-animation-3.html: Added.
  • svg/animations/svgenum-animation-4-expected.txt: Added.
  • svg/animations/svgenum-animation-4.html: Added.
  • svg/animations/svgenum-animation-5-expected.txt: Added.
  • svg/animations/svgenum-animation-5.html: Added.
  • svg/animations/svgenum-animation-6-expected.txt: Added.
  • svg/animations/svgenum-animation-6.html: Added.
  • svg/animations/svgenum-animation-7-expected.txt: Added.
  • svg/animations/svgenum-animation-7.html: Added.
  • svg/animations/svgenum-animation-8-expected.txt: Added.
  • svg/animations/svgenum-animation-8.html: Added.
  • svg/animations/svgenum-animation-9-expected.txt: Added.
  • svg/animations/svgenum-animation-9.html: Added.
01:25 Changeset [112812] by ossy@webkit.org
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r112799.

  • platform/qt/svg/custom/preserve-aspect-ratio-syntax-expected.png:
  • platform/qt/svg/custom/preserve-aspect-ratio-syntax-expected.txt:
01:23 Changeset [112811] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Do not generate custom signature for static methods.
https://bugs.webkit.org/show_bug.cgi?id=79222

Patch by Hao Zheng <zhenghao@chromium.org> on 2012-04-01
Reviewed by Kentaro Hara.

No new tests. Covered by existing tests when MEDIA_STREAM is disabled.

  • bindings/scripts/CodeGeneratorV8.pm:

(RequiresCustomSignature):

03/31/12:

20:27 Changeset [112810] by sfalken@apple.com
  • 3 edits in tags/Safari-536.5.1/Source/WebCore

Merge r112809.


2012-03-31 Steve Falkenburg <sfalken@apple.com>

Windows build fix.

  • WebCore.vcproj/WebCore.make:
20:03 Changeset [112809] by sfalken@apple.com
  • 2 edits in trunk/Source/WebCore

Windows build fix.

  • WebCore.vcproj/WebCore.make:
18:18 Changeset [112808] by timothy@apple.com
  • 5 edits in trunk/Source

Prevent opening external URLs in the Web Inspector's WebView.

All URLs not handled by the Inspector's JavaScript are now opened in the inspected WebView.

https://webkit.org/b/82812
rdar://problem/9488558

Reviewed by Joseph Pecoraro.

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.mm:

(-[WebInspectorWindowController init]): Factored the URL code out of here into inspectorPagePath.
(-[WebInspectorWindowController inspectorPagePath]): Added.
(-[WebInspectorWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]): Added.
Only allow non-main frame and the inspector page. All other URLs will be opened in the inspected page.

Source/WebKit2:

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::decidePolicyForNavigationAction): Added. Only allow non-main frame and the inspector page. All other URLs
will be opened in the inspected page.
(WebKit::WebInspectorProxy::createInspectorPage): Set the policy client and use decidePolicyForNavigationAction.

  • UIProcess/WebInspectorProxy.h: Made inspectorPageURL and inspectorBaseURL public for decidePolicyForNavigationAction.
16:33 Changeset [112807] by ojan@chromium.org
  • 7 edits in trunk/Tools

Generate the flakiness dashboard's list of webkit.org builders from the buildbot JSON
https://bugs.webkit.org/show_bug.cgi?id=82839

Reviewed by Adam Barth.

Also, update various hard-coded lists for WIN7 and Lion ports.
This is necessary since the new list of builders grabbed off the
buildbot includes Lion.

  • TestResultServer/static-dashboards/builders.js:

(generateWebkitBuildersFromBuilderList):
(xhr.onreadystatechange):
Don't use dashboard_base's request method to avoid layering violation.

  • TestResultServer/static-dashboards/dashboard_base.js:

(parseParameters):
(initBuilders):
(haveJsonFilesLoaded):
(g_handleBuildersListLoaded):
Block loading the JSON files for each builder until we actually have a list of builders.

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:

(testPlatformAndBuildType):
(testGenerateWebkitBuildersFromBuilderList):

  • TestResultServer/static-dashboards/timeline_explorer.html:
  • TestResultServer/static-dashboards/treemap.html:

Delay generating the page until the builder list has loaded.

16:09 Changeset [112806] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix complex strokes on CG platform
https://bugs.webkit.org/show_bug.cgi?id=80423

Patch by Philip Rogers <pdr@google.com> on 2012-03-31
Reviewed by Eric Seidel.

This change fixes a mistake in r112667 where the CG platform did not properly handle
complex strokes. The mistake was to check for complex fills instead of complex strokes,
which resulted in all complex strokes rendering as black.

No new tests, this change is covered by the following existing tests that were regressed:
1) svg/custom/gradient-stroke-width.svg
2) svg/custom/transform-with-shadow-and-gradient.svg

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::platformStrokeEllipse):

16:02 Changeset [112805] by ojan@chromium.org
  • 3 edits in trunk/Tools

If NRWT gets killed halfway through a run, it incorrectly reports tests that weren't run as passes
https://bugs.webkit.org/show_bug.cgi?id=82799

Reviewed by Eric Seidel.

If we don't run a test, mark it as skipped.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._mark_interrupted_tests_as_skipped):
(Manager._interrupt_if_at_failure_limits.interrupt_if_at_failure_limit):

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ManagerTest.test_interrupt_if_at_failure_limits):

14:37 Changeset [112804] by rniwa@webkit.org
  • 2 edits in trunk/Tools

One more build fix after r112781 for Chromium Windows.
Don't copy zip .idb files.

  • BuildSlaveSupport/built-product-archive:

(copyBuildFiles):

14:17 Changeset [112803] by jochen@chromium.org
  • 3 edits
    2 adds in trunk

Don't insert linebreaks into text input fields.
https://bugs.webkit.org/show_bug.cgi?id=81660

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/forms/textfield-no-linebreak.html

  • editing/TypingCommand.cpp:

(canAppendNewLineFeed): Only assume that a linefeed can be appended, if
after the BeforeTextInserted event the event text is still a newline.

LayoutTests:

  • fast/forms/textfield-no-linebreak.html: Added.
  • fast/forms/textfield-no-linebreak-expected.html: Added.
13:24 Changeset [112802] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Yet another build fix after r112781 for Chromium Windows.
Run webkit-build-directory by perl explicitly.

  • BuildSlaveSupport/built-product-archive:

(determineWebKitBuildDirectory):

13:03 Changeset [112801] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

32-bit plug-ins need to opt into magnified mode
https://bugs.webkit.org/show_bug.cgi?id=82837
<rdar://problem/9104840>

Reviewed by Simon Fraser.

  • PluginProcess/mac/PluginProcessMainMac.mm:

(WebKit::PluginProcessMain):

12:59 Changeset [112800] by mrobinson@webkit.org
  • 3 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk

[GTK] [Stable] --disable geolocation broken after recent merges
https://bugs.webkit.org/show_bug.cgi?id=82452

No review, as this is just a build fix.

Fix the geolocation build.

  • webkit/webkitgeolocationpolicydecision.cpp:

(webkit_geolocation_policy_decision_new): When gelocation is off, just return null.

  • webkit/webkitgeolocationpolicydecisionprivate.h: Activate webkit_geolocation_policy_decision_new

for non-Geolocation builds.

12:13 Changeset [112799] by zimmermann@webkit.org
  • 7 edits in trunk

LayoutTests: [r112391] Pixel test failure of svg/custom/preserve-aspect-ratio-syntax.svg
https://bugs.webkit.org/show_bug.cgi?id=82469

Source/WebCore:

Fix regression from r112391. The test excerising this code path is skipped on Lion, due to a libxml2 bug.
I didn't notice I broke preserveAspectRatio parsing for many corner cases, revert to old logic.

  • svg/SVGPreserveAspectRatio.cpp:

(WebCore::SVGPreserveAspectRatio::parse):

LayoutTests:

Reviewed by Dirk Schulze.

Unskip test, as the regression is fixed.

  • platform/qt/Skipped:
  • svg/custom/preserve-aspect-ratio-syntax.svg:

Remove one incorrect testcase (which was actually valid and thus doesn't result in a default pAR attribute value).
Can't rebaseline this on Mac Lion, as its skipped to a libxml2 bug, which will be addressed soon.

  • svg/dom/preserve-aspect-ratio-parser-expected.txt:
  • svg/dom/preserve-aspect-ratio-parser.html: Switch numbers to constants, so this test is actually readable.
11:02 Changeset [112798] by antti@apple.com
  • 15 edits in trunk/Source/WebCore

CSSStyleRules should own their CSSStyleDeclarations
https://bugs.webkit.org/show_bug.cgi?id=82832

Reviewed by Andreas Kling.

Move the rule properties CSSOM wrapper ownership from the StylePropertySet to the rule itself.
This is preparation for bug 82728 (Split remaining CSSRules into internal and CSSOM types). This
temporarily grows the size of CSSStyleRule by a pointer (82728 will give the memory back and more)

  • css/CSSFontFaceRule.cpp:

(WebCore::CSSFontFaceRule::~CSSFontFaceRule):
(WebCore):
(WebCore::CSSFontFaceRule::style):

  • css/CSSFontFaceRule.h:

(WebCore):
(CSSFontFaceRule):

  • css/CSSPageRule.cpp:

(WebCore::CSSPageRule::~CSSPageRule):
(WebCore):
(WebCore::CSSPageRule::style):

  • css/CSSPageRule.h:

(WebCore):
(CSSPageRule):

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::~CSSStyleRule):
(WebCore::CSSStyleRule::style):

  • css/CSSStyleRule.h:

(WebCore):
(CSSStyleRule):

Make the rules own the property CSSOM wrapper.


  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::StyleRuleCSSStyleDeclaration::ref):
(WebCore):
(WebCore::StyleRuleCSSStyleDeclaration::deref):
(WebCore::StyleRuleCSSStyleDeclaration::setNeedsStyleRecalc):
(WebCore::StyleRuleCSSStyleDeclaration::contextStyleSheet):
(WebCore::InlineCSSStyleDeclaration::ref):
(WebCore::InlineCSSStyleDeclaration::deref):

  • css/PropertySetCSSStyleDeclaration.h:

(WebCore::PropertySetCSSStyleDeclaration::parentElement):
(PropertySetCSSStyleDeclaration):
(WebCore::StyleRuleCSSStyleDeclaration::create):
(StyleRuleCSSStyleDeclaration):
(WebCore::StyleRuleCSSStyleDeclaration::clearParentRule):
(WebCore::StyleRuleCSSStyleDeclaration::StyleRuleCSSStyleDeclaration):
(WebCore::StyleRuleCSSStyleDeclaration::parentRule):

  • Rename RuleCSSStyleDeclaration -> StyleRuleCSSStyleDeclaration
  • Make StyleRuleCSSStyleDeclaration use regular refcounting since it is no longer owned by the wrapped object.
  • Rename hasCSSOMWrapper() -> isMutable(), m_hasCSSOMWrapper -> m_ownsCSSOMWrapper to match the purpose.


(InlineCSSStyleDeclaration):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::~StylePropertySet):
(WebCore::StylePropertySet::ensureCSSStyleDeclaration):
(WebCore):
(WebCore::StylePropertySet::ensureInlineCSSStyleDeclaration):
(WebCore::StylePropertySet::clearParentElement):

  • css/StylePropertySet.h:

(StylePropertySet):
(WebCore::StylePropertySet::isMutable):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::ensureMutableInlineStyle):
(WebCore::ElementAttributeData::updateInlineStyleAvoidingMutation):

10:48 Changeset [112797] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Fix the syntax error in master.cfg after r112734.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(unitTestsSupported):

07:14 Changeset [112796] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, remove suppressions due to the http://crrev.com/130034 revert.

  • platform/chromium/test_expectations.txt:
07:09 Changeset [112795] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Viewport-percentage Lengths: Layout test for vertical-align CSS property
https://bugs.webkit.org/show_bug.cgi?id=82811

Patch by Joe Thomas <joethomas@motorola.com> on 2012-03-31
Reviewed by Antti Koivisto.

Adding a layout test for vertical-align CSS property which takes Viewport-percentage length unit.

  • css3/viewport-percentage-lengths/viewport-percentage-vertical-align-expected.html: Added.
  • css3/viewport-percentage-lengths/viewport-percentage-vertical-align.html: Added.
06:34 Changeset [112794] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

[BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail
https://bugs.webkit.org/show_bug.cgi?id=80135

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-03-31
Reviewed by Rob Buis.

.:

RIM PR: 145660
Added manual test for testing the behavior of http authentication
challenge dialog. Both of these two files should be served over http.

  • ManualTests/blackberry/http-auth-challenge.html: Added.
  • ManualTests/blackberry/http-auth-challenge.php: Added.

Source/WebCore:

RIM PR: 145660
Fixed a regression introduced by r111810, we should cancel the new
request when user press cancel button in http authentication challenge
dialog, and we should also allow sending empty username and password
with the request.
Also removed redundant codes which checked the existence of the
FrameLoaderClient pointer, as we've already moved authenticationChallenge()
out of class FrameLoaderClient, it is not needed.

Manual test added. Testing http authentication dialog relies on user interaction.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::sendRequestWithCredentials):

Source/WebKit/blackberry:

RIM PR: 145660
Fixed a regression introduced by r111810, which used the wrong
credential object.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):

06:25 Changeset [112793] by apavlov@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

[Chromium] Unreviewed, update expectations for SNOWLEOPARD after r112755

  • platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
06:06 Changeset [112792] by charles.wei@torchmobile.com.cn
  • 4 edits in trunk/Source/WebCore

[BlackBerry] Upstream BlackBerry change to PlatformTouchEvent and PlatformTouchPoint
https://bugs.webkit.org/show_bug.cgi?id=82828

Reviewed by Rob Buis.

No new tests, just upstream BlackBerry-specific change to
PlatformTouchEvent and PlatformTouchPoint, to make it build
for BlackBerry.

  • platform/PlatformTouchEvent.h:

(Platform):
(WebCore::PlatformTouchEvent::PlatformTouchEvent):
(PlatformTouchEvent):
(WebCore::PlatformTouchEvent::rotation):
(WebCore::PlatformTouchEvent::scale):
(WebCore::PlatformTouchEvent::doubleTap):
(WebCore::PlatformTouchEvent::touchHold):

  • platform/PlatformTouchPoint.h:

(Platform):
(PlatformTouchPoint):

  • platform/blackberry/PlatformTouchEventBlackBerry.cpp:

(WebCore::PlatformTouchEvent::PlatformTouchEvent):

06:00 Changeset [112791] by apavlov@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

[Chromium] Unreviewed, rebaseline test on LEOPARD after r112755

  • platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt: Added.
05:37 Changeset [112790] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Refactor : NetworkJob::handleNotifyHeaderReceived.
https://bugs.webkit.org/show_bug.cgi?id=82825

We should use "else if" to decrease string's compare.

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-03-31
Reviewed by Rob Buis.

No new tests. Refactor.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::handleNotifyHeaderReceived):

05:32 Changeset [112789] by charles.wei@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Upstream local change of PlatformKeyboardEventBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=82721

Reviewed by Rob Buis.

No new tests, just upstreaming the local change to make the upstreaming
build for BlackBerry.

  • platform/blackberry/PlatformKeyboardEventBlackBerry.cpp:

(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

04:59 Changeset [112788] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash in HTMLFieldSetElement::disabledAttributeChanged.
https://bugs.webkit.org/show_bug.cgi?id=82814

Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/forms/fieldset/fieldset-crash.html

  • html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::disabledAttributeChanged):

LayoutTests:

  • fast/forms/fieldset/fieldset-crash-expected.txt: Added.
  • fast/forms/fieldset/fieldset-crash.html: Added.
04:46 Changeset [112787] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, suppress more failures after http://crrev.com/130034

  • platform/chromium/test_expectations.txt:
04:00 Changeset [112786] by apavlov@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, avoid the need for pixel results (reported for Chromium) for tests added in r112769.

  • svg/css/script-tests/svg-attribute-length-parsing.js:
  • svg/css/script-tests/svg-attribute-parser-mode.js:
03:40 Changeset [112785] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, suppress failures after http://crrev.com/130034

  • platform/chromium/test_expectations.txt:
00:44 Changeset [112784] by abarth@webkit.org
  • 8 edits
    24 copies
    7 moves
    15 adds
    1 delete in trunk/Source

[Chromium] Delete WebKit/chromium/bridge
https://bugs.webkit.org/show_bug.cgi?id=82677

Reviewed by James Robinson.

Source/Platform:

This patch moves all the MediaStream-related platform APIs from
WebKit/chromium/public/platform into Platform/chromium/public. This is
part of a larger project to more clearly separate the platform and
client portions of the Chromium WebKit API.

  • Platform.gypi:
  • chromium/public/Platform.h:

(WebKit):
(Platform):
(WebKit::Platform::createPeerConnectionHandler):
(WebKit::Platform::createPeerConnection00Handler):
(WebKit::Platform::createMediaStreamCenter):

  • chromium/public/WebICECandidateDescriptor.h: Copied from Source/WebKit/chromium/public/platform/WebICECandidateDescriptor.h.
  • chromium/public/WebICEOptions.h: Copied from Source/WebKit/chromium/public/platform/WebICEOptions.h.
  • chromium/public/WebMediaHints.h: Copied from Source/WebKit/chromium/public/platform/WebMediaHints.h.
  • chromium/public/WebMediaStreamCenter.h: Copied from Source/WebKit/chromium/public/platform/WebMediaStreamCenter.h.
  • chromium/public/WebMediaStreamCenterClient.h: Copied from Source/WebKit/chromium/public/platform/WebMediaStreamCenterClient.h.
  • chromium/public/WebMediaStreamComponent.h: Copied from Source/WebKit/chromium/public/platform/WebMediaStreamComponent.h.
  • chromium/public/WebMediaStreamDescriptor.h: Copied from Source/WebKit/chromium/public/platform/WebMediaStreamDescriptor.h.
  • chromium/public/WebMediaStreamSource.h: Copied from Source/WebKit/chromium/public/platform/WebMediaStreamSource.h.
  • chromium/public/WebMediaStreamSourcesRequest.h: Copied from Source/WebKit/chromium/public/platform/WebMediaStreamSourcesRequest.h.
  • chromium/public/WebPeerConnection00Handler.h: Copied from Source/WebKit/chromium/public/platform/WebPeerConnection00Handler.h.
  • chromium/public/WebPeerConnection00HandlerClient.h: Copied from Source/WebKit/chromium/public/platform/WebPeerConnection00HandlerClient.h.
  • chromium/public/WebPeerConnectionHandler.h: Copied from Source/WebKit/chromium/public/platform/WebPeerConnectionHandler.h.

(WebPeerConnectionHandler):

  • chromium/public/WebPeerConnectionHandlerClient.h: Copied from Source/WebKit/chromium/public/platform/WebPeerConnectionHandlerClient.h.
  • chromium/public/WebSessionDescriptionDescriptor.h: Copied from Source/WebKit/chromium/public/platform/WebSessionDescriptionDescriptor.h.
  • chromium/public/WebVector.h: Copied from Source/WebKit/chromium/public/platform/WebVector.h.

Source/WebCore:

These files are just moved from the WebKit layer with their include
directives adjusted.

  • WebCore.gypi:
  • platform/chromium/support/WebICECandidateDescriptor.cpp: Copied from Source/WebKit/chromium/src/WebICECandidateDescriptor.cpp.
  • platform/chromium/support/WebICEOptions.cpp: Copied from Source/WebKit/chromium/src/WebICEOptions.cpp.
  • platform/chromium/support/WebMediaHints.cpp: Copied from Source/WebKit/chromium/src/WebMediaHints.cpp.
  • platform/chromium/support/WebMediaStreamComponent.cpp: Copied from Source/WebKit/chromium/src/WebMediaStreamComponent.cpp.
  • platform/chromium/support/WebMediaStreamDescriptor.cpp: Copied from Source/WebKit/chromium/src/WebMediaStreamDescriptor.cpp.
  • platform/chromium/support/WebMediaStreamSource.cpp: Copied from Source/WebKit/chromium/src/WebMediaStreamSource.cpp.
  • platform/chromium/support/WebMediaStreamSourcesRequest.cpp: Copied from Source/WebKit/chromium/src/WebMediaStreamSourcesRequest.cpp.
  • platform/mediastream/chromium/DeprecatedPeerConnectionHandler.cpp: Copied from Source/WebKit/chromium/bridge/DeprecatedPeerConnectionHandler.cpp.
  • platform/mediastream/chromium/DeprecatedPeerConnectionHandlerInternal.cpp: Copied from Source/WebKit/chromium/bridge/DeprecatedPeerConnectionHandlerInternal.cpp.

(WebCore::DeprecatedPeerConnectionHandlerInternal::DeprecatedPeerConnectionHandlerInternal):

  • platform/mediastream/chromium/DeprecatedPeerConnectionHandlerInternal.h: Copied from Source/WebKit/chromium/bridge/DeprecatedPeerConnectionHandlerInternal.h.
  • platform/mediastream/chromium/MediaStreamCenterChromium.cpp: Copied from Source/WebKit/chromium/bridge/MediaStreamCenter.cpp.
  • platform/mediastream/chromium/MediaStreamCenterInternal.cpp: Copied from Source/WebKit/chromium/bridge/MediaStreamCenterInternal.cpp.

(WebCore::MediaStreamCenterInternal::MediaStreamCenterInternal):

  • platform/mediastream/chromium/MediaStreamCenterInternal.h: Copied from Source/WebKit/chromium/bridge/MediaStreamCenterInternal.h.
  • platform/mediastream/chromium/PeerConnection00Handler.cpp: Copied from Source/WebKit/chromium/bridge/PeerConnection00Handler.cpp.
  • platform/mediastream/chromium/PeerConnection00HandlerInternal.cpp: Copied from Source/WebKit/chromium/bridge/PeerConnection00HandlerInternal.cpp.

(WebCore::PeerConnection00HandlerInternal::PeerConnection00HandlerInternal):

  • platform/mediastream/chromium/PeerConnection00HandlerInternal.h: Copied from Source/WebKit/chromium/bridge/PeerConnection00HandlerInternal.h.

Source/WebKit/chromium:

Delete WebKit/chromium/bridge. This was a directory we were
experimenting with storing WebCore-namespaced code. Now we're able to
actually keep that code in WebCore itself, which is much more sensible.

  • WebKit.gyp:
  • bridge: Removed.
  • bridge/DeprecatedPeerConnectionHandler.cpp: Removed.
  • bridge/DeprecatedPeerConnectionHandlerInternal.cpp: Removed.
  • bridge/DeprecatedPeerConnectionHandlerInternal.h: Removed.
  • bridge/MediaStreamCenter.cpp: Removed.
  • bridge/MediaStreamCenterInternal.cpp: Removed.
  • bridge/MediaStreamCenterInternal.h: Removed.
  • bridge/PeerConnection00Handler.cpp: Removed.
  • bridge/PeerConnection00HandlerInternal.cpp: Removed.
  • bridge/PeerConnection00HandlerInternal.h: Removed.
  • public/platform/WebICECandidateDescriptor.h: Replaced.
  • public/platform/WebICEOptions.h: Replaced.
  • public/platform/WebKitPlatformSupport.h:

(WebKit):
(WebKitPlatformSupport):

  • public/platform/WebMediaHints.h: Replaced.
  • public/platform/WebMediaStreamCenter.h: Replaced.
  • public/platform/WebMediaStreamCenterClient.h: Replaced.
  • public/platform/WebMediaStreamComponent.h: Replaced.
  • public/platform/WebMediaStreamDescriptor.h: Replaced.
  • public/platform/WebMediaStreamSource.h: Replaced.
  • public/platform/WebMediaStreamSourcesRequest.h: Replaced.
  • public/platform/WebPeerConnection00Handler.h: Replaced.
  • public/platform/WebPeerConnection00HandlerClient.h: Replaced.
  • public/platform/WebPeerConnectionHandler.h: Replaced.
  • public/platform/WebPeerConnectionHandlerClient.h: Replaced.
  • public/platform/WebSessionDescriptionDescriptor.h: Replaced.
  • public/platform/WebVector.h: Replaced.
  • src/WebICECandidateDescriptor.cpp: Removed.
  • src/WebICEOptions.cpp: Removed.
  • src/WebMediaHints.cpp: Removed.
  • src/WebMediaStreamComponent.cpp: Removed.
  • src/WebMediaStreamDescriptor.cpp: Removed.
  • src/WebMediaStreamSource.cpp: Removed.
  • src/WebMediaStreamSourcesRequest.cpp: Removed.
00:15 Changeset [112783] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Another build fix after r112781.

  • BuildSlaveSupport/built-product-archive:

(createZip):

00:06 Changeset [112782] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Build fix after r112781.

  • BuildSlaveSupport/built-product-archive:

(createZipManually):
(createZip):

03/30/12:

23:50 Changeset [112781] by rniwa@webkit.org
  • 4 edits in trunk/Tools

Chromium bots should upload archived built files
https://bugs.webkit.org/show_bug.cgi?id=82666

Reviewed by Tony Chang.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • BuildSlaveSupport/built-product-archive:

(main):
(determineWebKitBuildDirectory): Instead of hard-coding WebKitBuild as the build outout directory,
call out to webkit-build-directory.
(removeDirectoryIfExists): Extracted.
(copyBuildFiles): Added to avoid archiving useless intermedinate files.
(createZipManually): Used in Chromium Windows where we don't execute python scripts inside cygwin.
(createZipManually.addToArchive):
(createZip): Extracted. Calls out to appropraite command line scripts or createZipManually.
(archiveBuiltProduct): Add support for Chromium port.

  • Scripts/webkit-build-directory: Add support for --platform options.
23:10 Changeset [112780] by abarth@webkit.org
  • 4 edits
    4 copies
    4 deletes in trunk/Source

[Chromium] Move ResourceHandle to WebCore/platform/network/chromium
https://bugs.webkit.org/show_bug.cgi?id=82657

Reviewed by James Robinson.

Source/WebCore:

We finally arive at our destination. This patch actually moves
WebCore::ResourceHandle from Source/WebKit/chromium/src to
Source/WebCore/network/chromium, matching its location in other ports.
To make this happen, we also need to move WrappedResourceRequest and
WrappedResourceResponse.

This patch is the last patch from
https://github.com/abarth/webkit/compare/master...webcore-platform

  • WebCore.gypi:
  • platform/chromium/support/WrappedResourceRequest.h: Copied from Source/WebCore/platform/chromium/support/WrappedResourceRequest.h.
  • platform/chromium/support/WrappedResourceResponse.h: Copied from Source/WebCore/platform/chromium/support/WrappedResourceResponse.h.
  • platform/network/chromium/ResourceHandle.cpp: Copied from Source/WebCore/platform/network/chromium/ResourceHandle.cpp.
  • platform/network/chromium/ResourceHandleInternal.h: Copied from Source/WebCore/platform/network/chromium/ResourceHandleInternal.h.

Source/WebKit/chromium:

  • WebKit.gyp:
  • src/ResourceHandle.cpp: Removed.
  • src/ResourceHandleInternal.h: Removed.
  • src/WrappedResourceRequest.h: Removed.
  • src/WrappedResourceResponse.h: Removed.
22:26 Changeset [112779] by mrowe@apple.com
  • 2 edits in tags/Safari-536.5.1/Source/JavaScriptCore

Merge r112678.

22:26 Changeset [112778] by mrowe@apple.com
  • 4 edits in tags/Safari-536.5.1/Source

Versioning.

22:20 Changeset [112777] by mrowe@apple.com
  • 1 copy in tags/Safari-536.5.1

New tag.

22:16 Changeset [112776] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Add a compile assert for the size of RenderText
https://bugs.webkit.org/show_bug.cgi?id=82780

Reviewed by Dirk Pranke.

Added an assertion. Also moved m_maxWidth, m_beginMinWidth, and m_endMinWidth
to right beneath m_minWidth so that gcc on GTK+ can pack floats properly.

  • rendering/RenderText.cpp:

(SameSizeAsRenderText):
(WebCore):

  • rendering/RenderText.h:

(RenderText):

22:16 Changeset [112775] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Two more link errors. This time it's v8 we're missing.

  • WebKitUnitTests.gyp:
22:04 Changeset [112774] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Add a compile assert for the size of ScrollableArea
https://bugs.webkit.org/show_bug.cgi?id=82822

Reviewed by Dirk Pranke.

Added the assertion. Also made m_scrollOriginChanged a bitfield so that it can be packed nicely.

  • platform/ScrollableArea.cpp:

(SameSizeAsScrollableArea):
(WebCore):

  • platform/ScrollableArea.h:

(ScrollableArea):

21:44 Changeset [112773] by timothy@apple.com
  • 2 edits in trunk/Source/WebKit2

Stop creating the Web Inspector's NSWindow when detaching on close.

This fixes a UI process crash that would happen when detaching because of a Web Process crash.

https://webkit.org/b/82820
rdar://problem/11085467

Reviewed by Dan Bernstein.

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformDetach): Moved the creation and showing code to the end
and added an early return if we are not visible in the middle.

21:35 Changeset [112772] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Attempt to fix the Windows component build. It seems we're just
missing GURL now.

  • WebKitUnitTests.gyp:
21:01 Changeset [112771] by mitz@apple.com
  • 17 edits
    5 deletes in trunk

Reverted r112767, because it caused many vertical text tests to fail.

Source/WebCore:

  • WebCore.exp.in:
  • platform/graphics/FontPlatformData.cpp:

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::operator=):

  • platform/graphics/FontPlatformData.h:

(WebCore::FontPlatformData::FontPlatformData):
(FontPlatformData):
(WebCore::FontPlatformData::isColorBitmapFont):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::operator==):

  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::DerivedFontData::~DerivedFontData):

  • platform/graphics/SimpleFontData.h:

(SimpleFontData):
(DerivedFontData):

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::setFont):

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::createFontPlatformData):

  • platform/graphics/mac/GlyphPageTreeNodeMac.cpp:

(WebCore::shouldUseCoreText):
(WebCore::GlyphPage::fill):

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore):

Tools:

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/fonts/SampleFont.sfont: Removed.
  • DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
  • DumpRenderTree/mac/DumpRenderTree.mm:

(allowedFontFamilySet):
(activateTestingFonts):

  • WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:

(WTR::allowedFontFamilySet):
(WTR::activateFonts):

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/fonts/SampleFont.sfont: Removed.

LayoutTests:

  • fast/text/international/text-spliced-font.html: Removed.
  • platform/mac/fast/text/international/text-spliced-font-expected.png: Removed.
  • platform/mac/fast/text/international/text-spliced-font-expected.txt: Removed.
20:44 Changeset [112770] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Tried to fix the Chromium Mac build after r112767.

  • platform/graphics/SimpleFontData.h:

(SimpleFontData):
(DerivedFontData):

20:36 Changeset [112769] by krit@webkit.org
  • 10 edits
    7 adds in trunk

Colors seem to be parsed using HTML quirks in SVG attributes
https://bugs.webkit.org/show_bug.cgi?id=46112

Source/WebCore:

Reviewed by Eric Seidel.

Finally move to SVGAttributeMode on parsing SVG presentation attributes. SVG attributes are
mainly parsed in the strict mode, which affects strict parsing of colors and no spaces between
values and units. Unit less values are still allowed.

Tests: svg/css/svg-attribute-length-parsing.html

svg/css/svg-attribute-parser-mode.html

  • css/CSSGrammar.y: No quirks mode for SVG.
  • css/CSSParser.h:

(WebCore::CSSParser::inStrictMode): SVGAttributeMode also implies strict parsing.
(WebCore::CSSParser::inQuirksMode): Remove SVGAttributeMode from quirks mode.

  • css/CSSParserMode.h:

(isStrictParserMode): Ditto.

  • dom/StyledElement.cpp:

(WebCore::StyledElement::updateAttributeStyle):

  • svg/SVGElementRareData.h:

(WebCore::SVGElementRareData::ensureAnimatedSMILStyleProperties):

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::SVGFontFaceElement):

  • svg/SVGStyledElement.cpp: Switch to SVGAttributeMode if we parse a SVG presentation attribute.

(WebCore::SVGStyledElement::getPresentationAttribute):

LayoutTests:

Test that values of SVG presentation attributes are parsed in strict mode. At the moment
this affects strict color parsing and no spaces between values and units.

Reviewed by Eric Seidel.

  • svg/animations/script-tests/animate-color-fill-from-by.js:
  • svg/css/script-tests/svg-attribute-length-parsing.js: Added.
  • svg/css/script-tests/svg-attribute-parser-mode.js: Added.
  • svg/css/svg-attribute-length-parsing-expected.txt: Added.
  • svg/css/svg-attribute-length-parsing.html: Added.
  • svg/css/svg-attribute-parser-mode-expected.txt: Added.
  • svg/css/svg-attribute-parser-mode.html: Added.
20:24 Changeset [112768] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Attempt to fix the Windows component build. The way we link the unit
tests in the component build is kind of nutty. Hopefully this approach
will eliminate the duplicate symbols we've been seeing.

  • WebKitUnitTests.gyp:
20:13 Changeset [112767] by mitz@apple.com
  • 17 edits
    5 adds in trunk

Source/WebCore: Composite Font References is a new established standard (ISO/IEC 14496-28:2012) for specifying
composite fonts from existing physical fonts.
<rdar://problem/10717370>
https://bugs.webkit.org/show_bug.cgi?id=82810

CoreText have already the features enabled, here we added this to WebKit text layout and rendering.
A member function getCompositeFontReferenceFontData is added to the SimpleFontData class for the component font
correspond to the platformData, in this case, a NSFont. This is used when CoreText layout had resulted
a component of the Composite Font Reference and its corresponding SimpleFontData object is then cached
in the SimpleFontData object of the posting font (Composite Font Reference).

When glyphs are encoded to form the GlyphPage for rendering, the Composite Font Reference is handled throught
the CoreText layout path (using CTLine), here the resulting glyph is associated with a font which could
be not the original font request. In this case, these are the component fonts of the Composite Font
Reference. This is then identified and then added to the GlyphPage appropriately.

To support this feature, a member function isCompositeFontReference is added to FontPlatformData to
indicate a font is a Composite Font Reference. Also in order to pass the component font correctly a boolean
isPrinterFont is added to one the FontPlatformData constructors to describe the NSFont.

Patch by Tony Tseung <tseung@apple.com> on 2012-03-30
Reviewed by Dan Bernstein.

Added test LayoutTests/fast/text/international/text-spliced-font.html

  • WebCore.exp.in:

Replaced obsolete FontPlatformData constructor entry.

  • platform/graphics/FontPlatformData.cpp:

(WebCore::FontPlatformData::FontPlatformData):
Copy of the additional m_isCompositeFontReference and m_isPrinterFont data members.

(WebCore::FontPlatformData::operator=):
Assignment of the additional m_isCompositeFontReference and m_isPrinterFont data members.

  • platform/graphics/FontPlatformData.h:

(WebCore::FontPlatformData::FontPlatformData):
(FontPlatformData):
Default value of m_isCompositeFontReference and m_isPrinterFont data members are set to false in various constructors.

(WebCore::FontPlatformData::isCompositeFontReference):
Newly added for Composite Font Reference type font.

(WebCore::FontPlatformData::isPrinterFont):
Newly added for describing the NSFont parameter if is applicable.

(WebCore::FontPlatformData::operator==):
Comparison of the additional m_isCompositeFontReference and m_isPrinterFont data members.

  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::DerivedFontData::~DerivedFontData):
Clean up the cache for component fonts of the Composite Font References.

  • platform/graphics/SimpleFontData.h:

(SimpleFontData):
Added member function const SimpleFontData* getCompositeFontReferenceFontData(NSFont *key) const.

(DerivedFontData):
Added CFDictionary for caching the component font of Composite Font Reference.

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::FontPlatformData):
Data members m_isCompositeFontReference and m_isPrinterFont are initialised and their values are determined in the body of the contructor.

(WebCore::FontPlatformData::setFont):
Data members m_isCompositeFontReference and m_isPrinterFont are determined and set.

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::createFontPlatformData):
Boolean value isUsingPrinterFont is passed in the new FontPlatformData constructor.

  • platform/graphics/mac/GlyphPageTreeNodeMac.cpp:

(WebCore::shouldUseCoreText):
Added the condition for Composite Font Reference type font.

(WebCore::GlyphPage::fill):
In the case of Composite Font Reference, when iterate the runs, component font of Composite Font
Reference is used to fill the glyph index in the GlyphPage.

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::getCompositeFontReferenceFontData):
Newly added method for the component fonts correspond to the platformData, in this case, a NSFont.
This SimpleFontData is created and cached in this object and will only be deleted when the destructor
if this is called.

Tools: Composite Font References is a new established standard (ISO/IEC 14496-28:2012) for specifying
composite fonts from existing physical fonts.
<rdar://problem/10717370>
https://bugs.webkit.org/show_bug.cgi?id=82810

A new test font of this kind as been added to the test tools for running the webkit-tests

Patch by Tony Tseung <tseung@apple.com> on 2012-03-30
Reviewed by Dan Bernstein.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

Added new dependency SampleFont.sfont

  • DumpRenderTree/fonts/SampleFont.sfont: Added.


  • DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
  • DumpRenderTree/mac/DumpRenderTree.mm:

(allowedFontFamilySet):
Added the Composite Font Referene sample font "Hiragino Maru Gothic Monospaced" entry to the fonts white-list

(activateTestingFonts):
Added the registration of the Composite Font Referene sample font

  • WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:

(WTR::allowedFontFamilySet):
Added the Composite Font Referene sample font "Hiragino Maru Gothic Monospaced" entry to the fonts white-list

(WTR::activateFonts):
Added the registration of the Composite Font Referene sample font

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

Added new dependency SampleFont.sfont

  • WebKitTestRunner/fonts/SampleFont.sfont: Added.

LayoutTests: Composite Font References is a new established standard (ISO/IEC 14496-28:2012) for specifying
composite fonts from existing physical fonts.
<rdar://problem/10717370>
https://bugs.webkit.org/show_bug.cgi?id=82810

Added new LayoutTests/fast/text/international/text-spliced-font.html

Patch by Tony Tseung <tseung@apple.com> on 2012-03-30
Reviewed by Dan Bernstein.

  • fast/text/international/text-spliced-font.html: Added.
  • platform/mac/fast/text/international/text-spliced-font-expected.png: Added.
  • platform/mac/fast/text/international/text-spliced-font-expected.txt: Added.
20:07 Changeset [112766] by charles.wei@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Use KURL::protocolIsInHTTPFamily() instead KURL::protocolInHTTPFamily()
https://bugs.webkit.org/show_bug.cgi?id=82707

Reviewed by Rob Buis.

No new tests, just BlackBerry build fix.

  • platform/network/blackberry/NetworkManager.cpp:

(WebCore::NetworkManager::startJob):

19:46 Changeset [112765] by eric@webkit.org
  • 9 edits in trunk/Source/WebCore

styleForElement() should use enums instead of bools so we can all understand what it's doing
https://bugs.webkit.org/show_bug.cgi?id=82807

Reviewed by Adam Barth.

No change in behavior, thus no tests.

Mostly this is just replacing true/false with the correct new enum value
or removing true/false from the callsites when they would have been default anyway.
I think this makes the code *way* more clear.

The old code was extra confusing because the defaults were "true, false". :)
The new defaults are AllowStyleSharing, MatchAllRules.
It's very uncommon for callers to want to override either of these behaviors.
I think most callers which specify DisallowStyleSharing likely don't actually need to
(our style-sharing code should be smart enough to only share when safe anyway).

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::CSSStyleSelector):

  • Use enums and remove bogus comment (m_rootDefaultStyle is a RefPtr!)

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • css/CSSStyleSelector.h:

(CSSStyleSelector):

  • css/MediaQueryMatcher.cpp:

(WebCore::MediaQueryMatcher::prepareEvaluator):

  • css/StyleMedia.cpp:

(WebCore::StyleMedia::matchMedium):

  • dom/Element.cpp:

(WebCore::Element::styleForRenderer):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::getUncachedPseudoStyle):

  • Updated to use enums
  • Also fixed this to use toElement and modern early-return styles.
  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::computeStyleInRegion):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::customStyleForRenderer):

19:36 Changeset [112764] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Headers with no content shouldn't be dropped by platform's request.
https://bugs.webkit.org/show_bug.cgi?id=82691

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-03-30
Reviewed by Rob Buis.

Test : http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html

  • platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::ResourceRequest::initializePlatformRequest):

19:27 Changeset [112763] by simon.fraser@apple.com
  • 2 edits in trunk/LayoutTests

Skip more tests. Tracking bugs are listed in the Skipped file.

  • platform/mac/Skipped:
19:21 Changeset [112762] by fpizlo@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

DFG should optimize a==b for a being an object and b being either an object or
null/undefined, and vice versa
https://bugs.webkit.org/show_bug.cgi?id=82656

Reviewed by Oliver Hunt.

Implements additional object equality optimizations for the case that one
operand is predicted to be an easily speculated object (like FinalObject or
Array) and the other is either an easily speculated object or Other, i.e.
Null or Undefined.

2-5% speed-up on V8/raytrace, leading to a sub-1% progression on V8.

I also took the opportunity to clean up the control flow for the speculation
decisions in the various Compare opcodes. And to fix a build bug in SamplingTool.
And to remove debug cruft I stupidly committed in my last patch.

  • bytecode/SamplingTool.h:

(SamplingRegion):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGOperations.cpp:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compare):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(DFG):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(DFG):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):

19:17 Changeset [112761] by simon.fraser@apple.com
  • 2 edits in trunk/LayoutTests

Skip two SVG tests that asserted. Tracked by
https://bugs.webkit.org/show_bug.cgi?id=82815

  • platform/mac/Skipped:
18:37 Changeset [112760] by eric@webkit.org
  • 4 edits
    13 adds in trunk

Add tests for iframe seamless and support for parsing webkitseamless attribute
https://bugs.webkit.org/show_bug.cgi?id=82795

Reviewed by Adam Barth.

Source/WebCore:

This just adds support for parsing/reflecting the "webkitseamess" attribute.
I'll add the actual CSS, navigation, security, and layout changes in
separate follow-up patches.

Tests: fast/frames/seamless/seamless-basic.html

fast/frames/seamless/seamless-css-cascade.html
fast/frames/seamless/seamless-nested.html
fast/frames/seamless/seamless-sandbox-flag.html

  • html/HTMLAttributeNames.in:
  • html/HTMLIFrameElement.idl:

LayoutTests:

  • fast/frames/seamless/resources/css-cascade-child.html: Added.
  • fast/frames/seamless/resources/nested-seamless.html: Added.
  • fast/frames/seamless/resources/square.html: Added.
  • fast/frames/seamless/seamless-basic-expected.txt: Added.
  • fast/frames/seamless/seamless-basic.html: Added.
  • fast/frames/seamless/seamless-css-cascade-expected.txt: Added.
  • fast/frames/seamless/seamless-css-cascade.html: Added.
  • fast/frames/seamless/seamless-nested-expected.txt: Added.
  • fast/frames/seamless/seamless-nested.html: Added.
  • fast/frames/seamless/seamless-sandbox-flag-expected.txt: Added.
  • fast/frames/seamless/seamless-sandbox-flag.html: Added.
18:15 Changeset [112759] by dpranke@chromium.org
  • 10 edits in trunk/LayoutTests

Unreviewed, fix Leopard/SL expectations for remaining SVG tests.
Also, mark zoom-img-preserveAspectRatio-support-1 as still failing.

  • platform/chromium-mac-snowleopard/fast/overflow/overflow-x-y-expected.txt:
  • platform/chromium-mac-snowleopard/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt:
  • platform/chromium-mac-snowleopard/svg/custom/mask-colorspace-expected.txt:
  • platform/chromium-mac-snowleopard/svg/custom/use-on-g-containing-use-expected.txt:
  • platform/chromium-mac-snowleopard/svg/custom/use-setAttribute-crash-expected.txt:
  • platform/chromium-mac-snowleopard/svg/filters/feImage-late-indirect-update-expected.txt:
  • platform/chromium-mac-snowleopard/svg/stroke/zero-length-path-linecap-rendering-expected.txt:
  • platform/chromium-mac-snowleopard/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt:
  • platform/chromium/test_expectations.txt:
17:57 Changeset [112758] by eae@chromium.org
  • 18 edits in trunk/Source

Change WebKit/WebKit2 platform code to use pixel snapped values
https://bugs.webkit.org/show_bug.cgi?id=82549

Source/WebCore:

Reviewed by Eric Seidel.

Change WebKit and WebKit2 platform code to use rounded locations and
pixel snapped rects and sizes. This largely avoids having to expose the
fractional layout types to the platform code.

No new tests. No change in functionality.

  • dom/Node.h:

(WebCore::Node::pixelSnappedRenderRect):
Add pixel snapped version of renderRect

  • rendering/RenderBox.h:

(WebCore::RenderBox::pixelSnappedFrameRect):
Add pixel snapped version of frameRect

Source/WebKit/chromium:

Reviewed by Eric Seidel.

  • src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::boundingBoxRect):
Use pixelSnappedBoundingBoxRect instead of boundingBoxRect which returns
a LayoutRect.

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::characterIndexForPoint):
Use roundedPoint instead of point for hit testing as ranges use screen
cordinates which are represented with pixel accuracy.

Source/WebKit/mac:

Change WebKit and WebKit2 platform code to use rounded locations and
pixel snapped rects and sizes. This largely avoids having to expose the
fractional layout types to the platform code.

Reviewed by Eric Seidel.

  • DOM/WebDOMOperations.mm:

(-[DOMNode _renderRect:]):

Source/WebKit/qt:

Reviewed by Eric Seidel.

  • Api/qwebelement.cpp:

(QWebElement::geometry):
Replace getRect with getPixelSnappedRect to avoid having to expose
subpixel types to the platform layer.

  • Api/qwebpage.cpp:

(QWebPagePrivate::TouchAdjuster::findCandidatePointForTouch):
Use pixel snapped element rect when comparing with the touch rect as the
touch rect use screen cordinates which are represented with pixel
accuracy.

  • WebCoreSupport/ChromeClientQt.h:

(WebCore::ChromeClientQt::scrollRectIntoView):
Change scrollRectIntoView to take a LayoutRect to match base class
interface.

Source/WebKit2:

Change WebKit and WebKit2 platform code to use rounded locations and
pixel snapped rects and sizes. This largely avoids having to expose the
fractional layout types to the platform code.

Reviewed by Eric Seidel.

  • Shared/WebRenderObject.cpp:

(WebKit::WebRenderObject::WebRenderObject):

  • UIProcess/win/WebPopupMenuProxyWin.cpp:

(WebKit::WebPopupMenuProxyWin::calculatePositionAndSize):

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::renderRect):

  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp:

(WebKit::BuiltInPDFView::invalidateScrollbarRect):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::characterIndexForPoint):

17:54 Changeset [112757] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=82761

Try to narrow down the cause of this assertion by adding
an assertion about m_frame.

  • editing/Editor.cpp:

(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):

17:52 Changeset [112756] by eae@chromium.org
  • 5 edits in trunk/Source/WebCore

Fix return type for virtual borderBoundingBox method
https://bugs.webkit.org/show_bug.cgi?id=82561

Reviewed by Eric Seidel.

No new tests, no change in functionality.

  • editing/DeleteButtonController.cpp:

(WebCore::isDeletableElement):

  • rendering/RenderBox.h:

(WebCore::RenderBox::borderBoxRect):
Rename pixelSnappedBorderBoxRect to borderBoxRect and remove LayoutRect
version of same as we always want to use the pixel snapped version to
ensure proper rounding and alignment to device pixels.
(The way this rect is pixel snapped, using the m_frameRect location,
makes it hard for calling code to take the subpixel rect and correctly
snap it).

(WebCore::RenderBox::borderBoundingBox):

  • rendering/RenderBoxModelObject.h:

Change pure virtual definition of borderBoundingBox to return an IntRect
to match implementation in RenderBox.

(RenderBoxModelObject):

  • rendering/RenderInline.h:

(WebCore::RenderInline::borderBoundingBox):
Change overloaded method to IntRect to match RenderBox implementation.

17:48 April 2012 Meeting edited by dbarton@mathscribe.com
(diff)
17:46 Changeset [112755] by commit-queue@webkit.org
  • 17 edits in trunk

shape-inside and shape-outside are not in the list of computed style properties
https://bugs.webkit.org/show_bug.cgi?id=82667

Patch by Bear Travis <betravis@adobe.com> on 2012-03-30
Reviewed by Ryosuke Niwa.

Source/WebCore:

Adding prefixed shape-inside and shape-outside to the list of computed style properties.
Added properties to existing tests for computed style results

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore): added -webkit-shape-inside and -webkit-shape-outside to computedProperties

LayoutTests:

Adding prefixed shape-inside and shape-outside to the list of computed style properties.
Updating tests that look at all properties on a computed style declaration.

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/efl/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/svg/css/getComputedStyle-basic-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
17:31 Changeset [112754] by abarth@webkit.org
  • 4 edits
    8 moves in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=82582
Move CPP files related to ResourceHandle to WebCore/platform

Reviewed by James Robinson.

Source/WebCore:

This patch moves a number of files that implement parts of the platform
portion of the Chromium WebKit API from the WebKit layer to
WebCore/platform. These files are in the dependency cone of
ResourceHandle and have no dependencies on anything outside
WebCore/platform.

  • WebCore.gypi:
  • platform/chromium/support/WebHTTPBody.cpp: Copied from Source/WebKit/chromium/src/WebHTTPBody.cpp.
  • platform/chromium/support/WebHTTPLoadInfo.cpp: Copied from Source/WebKit/chromium/src/WebHTTPLoadInfo.cpp.
  • platform/chromium/support/WebURL.cpp: Copied from Source/WebKit/chromium/src/WebURL.cpp.
  • platform/chromium/support/WebURLError.cpp: Copied from Source/WebKit/chromium/src/WebURLError.cpp.
  • platform/chromium/support/WebURLRequest.cpp: Copied from Source/WebKit/chromium/src/WebURLRequest.cpp.
  • platform/chromium/support/WebURLRequestPrivate.h: Copied from Source/WebKit/chromium/src/WebURLRequestPrivate.h.
  • platform/chromium/support/WebURLResponse.cpp: Copied from Source/WebKit/chromium/src/WebURLResponse.cpp.
  • platform/chromium/support/WebURLResponsePrivate.h: Copied from Source/WebKit/chromium/src/WebURLResponsePrivate.h.

Source/WebKit/chromium:

  • WebKit.gyp:
  • src/WebHTTPBody.cpp: Removed.
  • src/WebHTTPLoadInfo.cpp: Removed.
  • src/WebURL.cpp: Removed.
  • src/WebURLError.cpp: Removed.
  • src/WebURLRequest.cpp: Removed.
  • src/WebURLRequestPrivate.h: Removed.
  • src/WebURLResponse.cpp: Removed.
  • src/WebURLResponsePrivate.h: Removed.
17:25 Changeset [112753] by dpranke@chromium.org
  • 3 edits
    1 delete in trunk/LayoutTests

Unreviewed, expectations update.

  • platform/chromium-mac/svg/batik/masking/maskRegions-expected.png:
  • platform/chromium-win-xp/svg/batik/masking/maskRegions-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
17:13 Changeset [112752] by eae@chromium.org
  • 7 edits in trunk/Source/WebCore

Fix usage of LayoutUnits in table code.
https://bugs.webkit.org/show_bug.cgi?id=82765

Reviewed by Eric Seidel.

Clean up usage of ints and LayoutUnits in table code in preparation for
turning on subpixel layout.

No new tests, no change in functionality.

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::computePreferredLogicalWidths):
Cast maxWidth to int as all table layout is done on int bounds.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
Change borders to LayoutUnit as paddings can have subpixel precision.

  • rendering/RenderTable.h:

(WebCore::RenderTable::getColumnPos):
(WebCore::RenderTable::columnPositions):
Change getColumnPos and columnPositions to ints as the values are always
on pixel bounds.

(WebCore::RenderTable::bordersPaddingAndSpacingInRowDirection):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::styleOrColLogicalWidth):
Remove unnecessary cast.

(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
Use LayoutPoint instead of left/top.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):

  • rendering/RenderTableSection.h:

Change baseline and baselineDescent to int to avoid unnecessary type
conversion.

17:10 Changeset [112751] by mrowe@apple.com
  • 5 edits in branches/safari-534.56-branch/Source

Versioning.

17:09 Changeset [112750] by mrowe@apple.com
  • 1 copy in tags/Safari-534.56.4

New tag.

17:05 Changeset [112749] by commit-queue@webkit.org
  • 15 edits
    14 moves
    1 add in trunk

Spec renamed Viewport-relative lengths to Viewport-percentage lengths
https://bugs.webkit.org/show_bug.cgi?id=82773

Patch by Joe Thomas <joethomas@motorola.com> on 2012-03-30
Reviewed by Antti Koivisto.

As per the latest version of CSS Values and Units Module Level 3 specification released on 29 March 2012
(http://dev.w3.org/csswg/css3-values/#viewport-relative-lengths) Viewport-relative lengths is renamed to Viewport-percentage lengths.

Source/WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::getPositionOffsetValue):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSPrimitiveValue.cpp:

(WebCore::unitCategory):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::canonicalUnitTypeForCategory):
(WebCore::CSSPrimitiveValue::viewportPercentageLength):

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::isViewportPercentageLength):
(CSSPrimitiveValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::convertToLength):

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • css/LengthFunctions.cpp:

(WebCore::minimumValueForLength):
(WebCore::valueForLength):
(WebCore::floatValueForLength):

  • platform/Length.h:

(WebCore::Length::isViewportPercentage):
(WebCore::Length::viewportPercentageLength):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::textIndentOffset):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeContentLogicalHeightUsing):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paddingTop):
(WebCore::RenderBoxModelObject::paddingBottom):
(WebCore::RenderBoxModelObject::paddingLeft):
(WebCore::RenderBoxModelObject::paddingRight):
(WebCore::RenderBoxModelObject::paddingBefore):
(WebCore::RenderBoxModelObject::paddingAfter):
(WebCore::RenderBoxModelObject::paddingStart):
(WebCore::RenderBoxModelObject::paddingEnd):
(WebCore::RenderBoxModelObject::calculateFillTileSize):

  • rendering/RenderInline.cpp:

(WebCore::computeMargin):

  • rendering/style/RenderStyle.h:

LayoutTests:

  • css3/viewport-percentage-lengths: Added.
  • css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-getStyle-expected.txt: Added.
  • css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-getStyle.html: Added.
  • css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh-absolute-expected.html: Added.
  • css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh-absolute.html: Added.
  • css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh-expected.html: Added.
  • css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh.html: Added.
  • css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin-absolute-expected.html: Added.
  • css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin-absolute.html: Added.
  • css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin-expected.html: Added.
  • css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin.html: Added.
  • css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw-absolute-expected.html: Added.
  • css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw-absolute.html: Added.
  • css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw-expected.html: Added.
  • css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw.html: Added.
  • css3/viewport-relative-lengths: Removed.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle-expected.txt: Removed.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle.html: Removed.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute-expected.html: Removed.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute.html: Removed.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-expected.html: Removed.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh.html: Removed.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute-expected.html: Removed.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute.html: Removed.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-expected.html: Removed.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin.html: Removed.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute-expected.html: Removed.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute.html: Removed.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-expected.html: Removed.
  • css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw.html: Removed.
17:01 Changeset [112748] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Note more flaky crashes for bug 82505.

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
16:47 Changeset [112747] by simon.fraser@apple.com
  • 2 edits in trunk/LayoutTests

Skip two WebGL tests. Tracked by https://bugs.webkit.org/show_bug.cgi?id=82805

  • platform/mac/Skipped:
16:34 Changeset [112746] by kevino@webkit.org
  • 23 edits in trunk

[wx] Move wxWebKit API into WebKit namespace.
https://bugs.webkit.org/show_bug.cgi?id=82740

Reviewed by Kevin Ollivier.

16:30 Changeset [112745] by achicu@adobe.com
  • 12 edits
    24 adds in trunk

[CSS Filters] Drop Shadow is not repainting correctly when repaint area is smaller than the filtered element
https://bugs.webkit.org/show_bug.cgi?id=80323

Source/WebCore:

Reviewed by Dean Jackson.

The problem is that shadow and blur (and custom filters - although not treated in this patch) need the full source image of
the surface that needs to be filtered. Until now the filter was computed only using the area defined by the dirty repaint rectangle.
Those filters need full image source because they displace pixel positions, meaning that pixels in the current dirty rectangle
have a dependency on pixels from the RenderLayer outside the dirty rect. See the bug pictures for an example of how that could go wrong.

The fix is to always keep a copy of the RenderLayer representation in memory. When repaint is needed we still invalidate
only the parts that changed, but the filter is computed using the full source image and not only the dirty rectangle.

In order to make that work, we needed the full repaint rectangle of the current RenderLayer and not just the clipped version that
we get through the ::paint methods. Also, because filters sometime need to repaint more than just the dirty area (because of the
outsets of the filters - ie blur, drop-shadow), it makes it easier to just capture all the repaints in the RenderLayer itself in a
similar way WebKit does now for composited layers. As a result the repaint container can also be a filtered layer (not just composited ones), so
that we can catch all the filter repaints in one place in the RenderLayer. Also with this change I removed the need to add visual overflow to
the RenderBox and also there's no need to patch the repaintUsingContainer. By the way, repaintUsingContainer did not always work because of the
LayoutState optimizations, so repaints during layout would fail (I know that that could be fixed by disabling the LayoutState for filtered areas).

Also part of this patch I extracted a function from RenderLayerCompositor::calculateCompositedBounds, so that we can also use it from RenderLayer.
I called it RenderLayer::calculateLayerBounds and there should be no change in functionality. It now also includes the outsets of the filter. I've
added a different bug to avoid adding the outsets when the filter is computed in hardware. That's because some platforms do not support that yet:
https://bugs.webkit.org/show_bug.cgi?id=81239

Also the visual overflow doesn't include the child RenderLayers, meaning that the outsets would have been applied to the border and not to the bounding box
of the RenderLayer. The end result was that some child RenderLayers could be clipped out of the filtered area.

Tests: css3/filters/filter-repaint-blur.html

css3/filters/filter-repaint-child-layers.html
css3/filters/filter-repaint-composited-fallback-crash.html
css3/filters/filter-repaint-composited-fallback.html
css3/filters/filter-repaint-sepia.html
css3/filters/filter-repaint-shadow-clipped.html
css3/filters/filter-repaint-shadow-rotated.html
css3/filters/filter-repaint-shadow.html

  • platform/graphics/filters/FilterOperations.cpp:

(WebCore::FilterOperations::getOutsets): Drop shadow should only enlarge the outsets and never make them smaller.

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::FilterEffectRenderer):
(WebCore::FilterEffectRenderer::build): Caching the operations.hasFilterThatMovesPixels() in the FilterEffectRenderer.
(WebCore::FilterEffectRenderer::updateBackingStore): It now returns true when the backing store was recreated, so that we can repaint it all.
(WebCore):
(WebCore::FilterEffectRendererHelper::prepareFilterEffect): Separated beginFilterEffect into two methods. One that computed the rects
and one that prepares the draw context.
(WebCore::FilterEffectRendererHelper::beginFilterEffect):
(WebCore::FilterEffectRendererHelper::applyFilterEffect):

  • rendering/FilterEffectRenderer.h:

(FilterEffectRendererHelper):
(FilterEffectRenderer):
(WebCore::FilterEffectRenderer::hasFilterThatMovesPixels):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeRectForRepaint): No need to include the outsets in the repaint rect here, we will do it later in RenderLayer.
(WebCore::RenderBox::addVisualEffectOverflow): Removed outsets from the overflow.

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::computeRectForRepaint): Removed the outsets from this method. We now compute that in
RenderLayer::setFilterBackendNeedsRepaintingInRect.

  • rendering/RenderLayer.cpp:

(WebCore):
In this change I introduce a new dirty rectangle used by filters. It accumulates all the repaint requests inside the filtered layer,
so that we can invalidate the areas that are outside the clipping rectangle. Such cases include "overflow:scroll" and "overflow:hidden", when
we still want to blur or drop shadow based on content that is not actually displayed on screen (but the shadow for that content is visible). That rectangle
is called m_filterRepaintRect and resets back to zero when the next repaint is finished. All the filtered layers that apply blur and drop-shadow
will have an extra backing surface and only the invalidated areas are repainted in that surface. This is very similar to how composited layers work.

(WebCore::RenderLayer::requiresFullLayerImageForFilters): Returns true in CPU mode and only if the layer needs the full source image of
the layer to compute the filter. Otherwise GPU layers already have access to the full bakcing image.
(WebCore::RenderLayer::enclosingFilterLayer): Returns the enclosing layer that returns true on requiresFullLayerImageForFilters.
(WebCore::RenderLayer::enclosingFilterRepaintLayer): Returns the enclosing layer that can be used to repaint the current layer. Usually that
is the RenderView layer or the parent RenderLayer that is composited.
(WebCore::RenderLayer::setFilterBackendNeedsRepaintingInRect): Intercepts all the repaint queries for the filtered layers and uses
enclosingFilterRepaintLayer to enforce the repaint using the parent container.

(WebCore::RenderLayer::paintLayerContents): Consolidated the filters code in one single place. Also, it is now sending the bounding box and the
dirty rect to the FilterEffectRendererHelper::prepareFilterEffect to make sure the backing store is repainted accordingly. In some cases it might
rewrite the dirty rectangle used to paint the current layer, so that all the dirty areas in the backing store are covered.
(WebCore::RenderLayer::calculateLayerBounds): Extracted from RenderLayerCompositor::calculateCompositedBounds.
(WebCore::RenderLayer::updateOrRemoveFilterEffect): We should not create the filter builder when there's no filter specified.

  • rendering/RenderLayer.h:

(RenderLayer):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::calculateCompositedBounds): Now using the code from RenderLayer::calculateLayerBounds

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::containerForRepaint): Using RenderLayer::enclosingFilterLayer to also find the parent filtered area.
(WebCore::RenderObject::repaintUsingContainer): Removed the need to add filter outsets in this method. We now compute that in
RenderLayer::setFilterBackendNeedsRepaintingInRect.

LayoutTests:

Reviewed by Dean Jackson.

Added more tests to cover all the repaint issues on filtered RenderLayers.

  • css3/filters/filter-repaint-blur-expected.png: Added.
  • css3/filters/filter-repaint-blur-expected.txt: Added.
  • css3/filters/filter-repaint-blur.html: Added. Checking that the full image of the RenderLayer is used to compute

the blur, even if only a sub-section of the layer has repainted.

  • css3/filters/filter-repaint-child-layers-expected.png: Added.
  • css3/filters/filter-repaint-child-layers-expected.txt: Added.
  • css3/filters/filter-repaint-child-layers.html: Added. Checking that the bounding box of the RenderLayer

and all its children are taken into account when computing the filter box.

  • css3/filters/filter-repaint-composited-fallback-crash-expected.png: Added.
  • css3/filters/filter-repaint-composited-fallback-crash-expected.txt: Added.
  • css3/filters/filter-repaint-composited-fallback-crash.html: Added. There was a crash when filters changed from CPU to GPU.
  • css3/filters/filter-repaint-composited-fallback-expected.png: Added.
  • css3/filters/filter-repaint-composited-fallback-expected.txt: Added.
  • css3/filters/filter-repaint-composited-fallback.html: Added. Checking that repaint still works when platform GPU is not able to

compute the filter.

  • css3/filters/filter-repaint-sepia-expected.png: Added.
  • css3/filters/filter-repaint-sepia-expected.txt: Added.
  • css3/filters/filter-repaint-sepia.html: Added. Testing that repaint still works correctly on simple filter that do not need the full

source image of the RenderLayer (ie. they are not displacing pixels positions).

  • css3/filters/filter-repaint-shadow-clipped-expected.png: Added.
  • css3/filters/filter-repaint-shadow-clipped-expected.txt: Added.
  • css3/filters/filter-repaint-shadow-clipped.html: Added. Checking that an element that's out of view (clipped by the viewport) can

still drop a shadow that might be visible.

  • css3/filters/filter-repaint-shadow-expected.png: Added.
  • css3/filters/filter-repaint-shadow-expected.txt: Added.
  • css3/filters/filter-repaint-shadow-rotated-expected.png: Added.
  • css3/filters/filter-repaint-shadow-rotated-expected.txt: Added. Testing that transforms and clipping applied on filtered areas

work correctly with the new repaint methods.

  • css3/filters/filter-repaint-shadow-rotated.html: Added.
  • css3/filters/filter-repaint-shadow.html: Added. Checking that the full image of the RenderLayer is used to compute

the shadow, even if only a sub-section of the layer has repainted.

  • platform/chromium/test_expectations.txt: Chromium needs expected results for the tests. Also the old filter-repaint.html had incorrect

expected results.

16:28 Changeset [112744] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Remove expectations for tests that are now passing.

Unreviewed.

  • platform/chromium/test_expectations.txt:
16:28 Changeset [112743] by eae@chromium.org
  • 2264 edits
    655 copies
    63 deletes in branches/subpixellayout

Merge trunk changes up until 112729 into subpixel branch.

16:27 Changeset [112742] by rniwa@webkit.org
  • 4 edits in trunk/Source/WebCore

Add a compile assert for the size of BidiContext
https://bugs.webkit.org/show_bug.cgi?id=82793

Reviewed by Eric Seidel.

Added the assertion. Also reduced the number of bits used for bidi levels from
8 to 6 as done in InlineBox since bidi levels require exactly 6 bits.

  • rendering/InlineBox.h: Added a comment about why bidi level needs exactly 6 bits.
  • platform/text/BidiContext.cpp:

(SameSizeAsBidiContext):
(WebCore):

  • platform/text/BidiContext.h:

(BidiContext):

16:26 Changeset [112741] by efidler@rim.com
  • 6 edits in trunk

Enable OpenType Sanitizer for BlackBerry port.
https://bugs.webkit.org/show_bug.cgi?id=82782

Reviewed by Eric Seidel.

.:

  • Source/cmake/OptionsBlackBerry.cmake: define USE(OPENTYPE_SANITIZER)

Source/WebKit:

  • PlatformBlackBerry.cmake: add libots to link

Tools:

  • Scripts/webkitdirs.pm:

(blackberryCMakeArguments): add OTS to include path

16:04 Changeset [112740] by jsbell@chromium.org
  • 4 edits
    3 adds in trunk

IndexedDB: Race condition causes version change transaction to commit after onblocked
https://bugs.webkit.org/show_bug.cgi?id=82678

Source/WebCore:

For a version change event, the blocked and success events could both be queued
before either is dispatched. The transaction would erroneously be allowed to commit
after the blocked event was dispatched; it should not be, as the request was not
finished.

Reviewed by Tony Chang.

Test: storage/indexeddb/dont-commit-on-blocked.html

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::dispatchEvent):

LayoutTests:

Landing test marked PASS FAIL as WK82776 prevents it from running in DRT; will
run it as a Chromium browser test for now.

Reviewed by Tony Chang.

  • platform/chromium/test_expectations.txt:
  • storage/indexeddb/dont-commit-on-blocked.html: Added.
  • storage/indexeddb/resources/dont-commit-on-blocked-worker.js: Added.

(request.onsuccess):
(onSetVersionBlocked):
(onSetVersionSuccess):
(onTransactionComplete):

16:00 Changeset [112739] by simon.fraser@apple.com
  • 2 edits in trunk/Tools

run-webkit-tests needs to set DYLD_LIBRARY_PATH as well
as DYLD_FRAMEWORK_PATH, so that libWebCoreTestSupport.dylib
is found.

<rdar://problem/11158581>

Reviewed by Mark Rowe.

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitDriver._start):

16:00 Changeset [112738] by simon.fraser@apple.com
  • 2 edits in trunk/LayoutTests

Skip another cookie test. Tracked by
https://bugs.webkit.org/show_bug.cgi?id=82749

  • platform/mac/Skipped:
15:49 Changeset [112737] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Cleanup a bunch of useless junk that's accumulated over time.
Also delete comments that add no value.

  • platform/chromium/test_expectations.txt:
15:36 Changeset [112736] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Add a compile assert for the size of FontDescription
https://bugs.webkit.org/show_bug.cgi?id=82786

Reviewed by Eric Seidel.

Added the assertion. Also converted a couple of boolean bitfields to unsinged.
I've verified that the conversions are safe (they're only used in FontDescription.h/cpp).

  • platform/graphics/FontDescription.cpp:

(SameSizeAsFontDescription):
(WebCore):

  • platform/graphics/FontDescription.h:

(FontDescription):

15:32 Changeset [112735] by dpranke@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll chromium DEPS from 129593 to 129574.

Unreviewed.

  • DEPS:
15:27 Changeset [112734] by simon.fraser@apple.com
  • 2 edits in trunk/Tools

Disable run-api-tests on release mac builds
https://bugs.webkit.org/show_bug.cgi?id=82788

Reviewed by Ryosuke Niwa.

TestWebKitAPI crashes every time in release builds currently
(https://bugs.webkit.org/show_bug.cgi?id=82652) so disable
run-api-tests on mac release builders.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(unitTestsSupported):

15:26 Changeset [112733] by eae@chromium.org
  • 3 edits in branches/subpixellayout/Source/WebCore

subpixel branch cleanup

15:24 Changeset [112732] by paroga@webkit.org
  • 4 edits in trunk/Source/WebKit/efl

[EFL] Correct <wtf/*.h> include paths.
https://bugs.webkit.org/show_bug.cgi?id=82741

Reviewed by Andreas Kling.

Modify the #include declarations for several EFL-related files
so that the wtf types are included using the full path.

  • ewk/ewk_frame.cpp:
  • ewk/ewk_tiled_backing_store.cpp:

(_Ewk_Tiled_Backing_Store_Item):

  • ewk/ewk_tiled_matrix.cpp:
15:23 Changeset [112731] by abarth@webkit.org
  • 5 edits
    1 move in trunk/Source

Move CPP files related to ResourceHandle to WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=82582

Reviewed by James Robinson.

Source/WebCore:

Re-land a tiny piece of http://trac.webkit.org/changeset/112572 in the
hopes of not breaking the component build this time.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/chromium/support/WebData.cpp: Copied from Source/WebKit/chromium/src/WebData.cpp.

Source/WebKit/chromium:

  • WebKit.gyp:
  • src/WebData.cpp: Removed.
15:21 Changeset [112730] by kling@webkit.org
  • 4 edits in trunk/Source/WebCore

Kill CSSTimingFunctionValue.
<http://webkit.org/b/82787>

Reviewed by Antti Koivisto.

Remove CSSTimingFunctionValue and let the 3 subclasses inherit directly from CSSValue.
CSSTimingFunctionValue is a pointless middle-man class that adds nothing.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • css/CSSTimingFunctionValue.h:

(WebCore::CSSLinearTimingFunctionValue::CSSLinearTimingFunctionValue):
(WebCore::CSSCubicBezierTimingFunctionValue::CSSCubicBezierTimingFunctionValue):
(WebCore::CSSStepsTimingFunctionValue::CSSStepsTimingFunctionValue):

  • css/CSSValue.h:

(WebCore::CSSValue::isCubicBezierTimingFunctionValue):
(WebCore::CSSValue::isLinearTimingFunctionValue):
(WebCore::CSSValue::isStepsTimingFunctionValue):

14:44 Changeset [112729] by nduca@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Bump max texture updates per frame to 48
https://bugs.webkit.org/show_bug.cgi?id=82779

Reviewed by James Robinson.

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WTF):

14:42 Changeset [112728] by japhet@chromium.org
  • 5 edits in trunk/Source/WebCore

Merge FrameLoader::finishedLoading() into DocumentLoader::finishedLoading().
https://bugs.webkit.org/show_bug.cgi?id=82653

Reviewed by Adam Barth.

No new tests, no functionality change intended.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::finishedLoading):

  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h:
  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::didFinishLoading):

14:23 Changeset [112727] by antti@apple.com
  • 3 edits in trunk/Source/WebCore

Cache origin check result to RuleData
https://bugs.webkit.org/show_bug.cgi?id=82774

Reviewed by Andreas Kling.

You wan't be able to get back to the stylesheet from a css style rule soon.
We need to do the origin check when we know the sheet it came from.

  • css/CSSStyleSelector.cpp:

(RuleData):
(WebCore::RuleData::hasDocumentSecurityOrigin):
(RuleSet):
(WebCore::makeRuleSet):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • css/CSSStyleSelector.h:

(WebCore::CSSStyleSelector::RuleFeature::RuleFeature):
(RuleFeature):
(Features):

14:16 Changeset [112726] by reed@google.com
  • 2 edits in trunk/Source/WebCore

Remove deadcode behind "SafeSkia" flag
https://bugs.webkit.org/show_bug.cgi?id=82771

Reviewed by Stephen White.

Just removing dead code (behind obsolete build flag), existing webkit tests apply

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::addInnerRoundedRectClip):
(WebCore::GraphicsContext::clearRect):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::canvasClip):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::clipConvexPolygon):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::strokeArc):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::platformFillEllipse):
(WebCore::GraphicsContext::platformStrokeEllipse):

14:14 Changeset [112725] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Add a compile assert for the size of InlineFlowBox
https://bugs.webkit.org/show_bug.cgi?id=82767

Reviewed by Tony Chang.

Add a compile assert to ensure InlineFlowBox stays small.
Also make some of the member variables not used in RootInlineBox private.

Changing these booleans to unsigned is safe as I've audited all code that
uses these member variables (they're all in InlineFlowBox or RootInlineBox).

  • rendering/InlineFlowBox.cpp:

(SameSizeAsInlineFlowBox):
(WebCore):

  • rendering/InlineFlowBox.h:

(InlineFlowBox):

14:11 Changeset [112724] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, new baseline.

  • platform/chromium-win/svg/text/text-align-05-b-expected.txt:
  • platform/chromium/test_expectations.txt:
13:55 Changeset [112723] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk

Fix defective size_t overflow in GestureTapHighlighter.
https://bugs.webkit.org/show_bug.cgi?id=82605

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-03-30
Reviewed by Kenneth Rohde Christiansen.

.:

  • ManualTests/tap-gesture-in-iframe-with-tap-highlight-crash.html: Added.

Source/WebCore:

In pathForRenderer, the for loop has 'i < rects().size() - 1' as test expression,
where rects().size() returns with size_t.
In case of empty rect, it leads to unsigned int overflow. Overflow value makes
the associated for loop run with invalid values.
Fix it by making loop variable int and stop using size_t type in the test expression.
Also, return early, if no focus ring found.

Manual test added. Tap gesture highlighter is getting triggered by UI process.

  • page/GestureTapHighlighter.cpp:
13:55 Changeset [112722] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix Lion build.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):

13:51 Changeset [112721] by mifenton@rim.com
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Speed up processing of Selection region generation.
https://bugs.webkit.org/show_bug.cgi?id=82766

Reviewed by Rob Buis.

PR 136593.

Refactor generation of Selection IntRectRegion to avoid
the need for IntRectRegion's helper functions which were
not available when using it as a container without
unioning the rects.

This greatly speeds up rendering by maintaining the distinct
rects as the union operation was length with large numbers of
rects.

Reviewed Internally by Gen Mak, Mike Lattanzio and Tyler Abbott.

  • WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::visibleTextQuads):
(DOMSupport):

  • WebKitSupport/DOMSupport.h:
  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::clippingRectForVisibleContent):
(BlackBerry::WebKit::SelectionHandler::regionForTextQuads):
(BlackBerry::WebKit::SelectionHandler::setSelection):
(WebKit):
(BlackBerry::WebKit::regionRectListContainsPoint):
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
(BlackBerry::WebKit::SelectionHandler::caretPositionChanged):

  • WebKitSupport/SelectionHandler.h:

(WebCore):
(SelectionHandler):

13:50 Changeset [112720] by commit-queue@webkit.org
  • 31 edits in trunk/Source

GEOLOCATION should be implemented as Page Supplement
https://bugs.webkit.org/show_bug.cgi?id=82228

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-03-30
Reviewed by Adam Barth.

Source/WebCore:

Geolocation now uses the Supplement interface instead of
keeping an instance variable on Page. This allows us to
remove all geolocation-related functions, variables, and
ifdefs out of Page and into Modules/geolocation/.

  • Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::stop):
(WebCore::Geolocation::lastPosition):
(WebCore::Geolocation::requestPermission):
(WebCore::Geolocation::startUpdating):
(WebCore::Geolocation::stopUpdating):

  • Modules/geolocation/Geolocation.h:

(WebCore):

  • Modules/geolocation/GeolocationController.cpp:

(WebCore::GeolocationController::supplementName):
(WebCore):
(WebCore::provideGeolocationTo):

  • Modules/geolocation/GeolocationController.h:

(GeolocationController):
(WebCore::GeolocationController::from):

  • WebCore.exp.in:
  • page/GeolocationClient.h:

(WebCore):
(GeolocationClient):

  • page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::PageClients::PageClients):

  • page/Page.h:

(WebCore):
(PageClients):
(Page):

Source/WebKit/blackberry:

Geolocation is now a Supplement in Page so the interface
has changed for setting up the page's geolocation client
initially and accessing the controller later.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::init):

  • WebCoreSupport/GeolocationControllerClientBlackBerry.cpp:

(GeolocationControllerClientBlackBerry::onLocationUpdate):
(GeolocationControllerClientBlackBerry::onLocationError):

  • WebKitSupport/DumpRenderTreeSupport.cpp:

(DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests):
(DumpRenderTreeSupport::resetGeolocationMock):
(DumpRenderTreeSupport::setMockGeolocationError):
(DumpRenderTreeSupport::setMockGeolocationPermission):
(DumpRenderTreeSupport::setMockGeolocationPosition):

Source/WebKit/chromium:

Geolocation is now a Supplement in Page so the interface
has changed for setting up the page's geolocation client
initially and accessing the controller later.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

Source/WebKit/gtk:

Geolocation is now a Supplement in Page so the interface
has changed for setting up the page's geolocation client
initially and accessing the controller later.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::resetGeolocationClientMock):
(DumpRenderTreeSupportGtk::setMockGeolocationPermission):
(DumpRenderTreeSupportGtk::setMockGeolocationPosition):
(DumpRenderTreeSupportGtk::setMockGeolocationError):
(DumpRenderTreeSupportGtk::numberOfPendingGeolocationPermissionRequests):

  • WebCoreSupport/GeolocationClientGtk.cpp:

(WebKit::GeolocationClient::updatePosition):
(WebKit::GeolocationClient::errorOccured):

  • webkit/webkitwebview.cpp:

(webkit_web_view_init):

Source/WebKit/mac:

Geolocation is now a Supplement in Page so the interface
has changed for setting up the page's geolocation client
initially and accessing the controller later.

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _geolocationDidChangePosition:]):
(-[WebView _geolocationDidFailWithError:]):

Source/WebKit/qt:

Geolocation is now a Supplement in Page so the interface
has changed for setting up the page's geolocation client
initially and accessing the controller later.

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::resetGeolocationMock):
(DumpRenderTreeSupportQt::setMockGeolocationPermission):
(DumpRenderTreeSupportQt::setMockGeolocationPosition):
(DumpRenderTreeSupportQt::setMockGeolocationError):
(DumpRenderTreeSupportQt::numberOfPendingGeolocationPermissionRequests):

  • WebCoreSupport/GeolocationClientQt.cpp:

(WebCore::GeolocationClientQt::positionUpdated):
(WebCore::GeolocationClientQt::startUpdating):

Source/WebKit/win:

Geolocation is now a Supplement in Page so the interface
has changed for setting up the page's geolocation client
initially and accessing the controller later.

  • WebView.cpp:

(WebView::initWithFrame):
(WebView::geolocationDidChangePosition):
(WebView::geolocationDidFailWithError):

Source/WebKit2:

Geolocation is now a Supplement in Page so the interface
has changed for setting up the page's geolocation client
initially and accessing the controller later.

  • WebProcess/Geolocation/WebGeolocationManager.cpp:

(WebKit::WebGeolocationManager::didChangePosition):
(WebKit::WebGeolocationManager::didFailToDeterminePosition):

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setGeoLocationPermission):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

13:47 Changeset [112719] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

This is fun.

  • WebCore.xcodeproj/project.pbxproj:
13:38 Changeset [112718] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Rebaseline due to wkbug.com/80423
https://bugs.webkit.org/show_bug.cgi?id=82743

Patch by Philip Rogers <pdr@google.com> on 2012-03-30
Reviewed by Simon Fraser.

  • platform/mac/Skipped:
  • platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt:
13:33 Changeset [112717] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Yet another build fix attempt.

  • WebCore.xcodeproj/project.pbxproj:
13:29 Changeset [112716] by commit-queue@webkit.org
  • 2 edits
    83 adds in trunk/LayoutTests

Integrate IETC CSS : textshadow tests
https://bugs.webkit.org/show_bug.cgi?id=81936

Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-03-30
Reviewed by Adam Barth.

Adding expected pngs and render tree dumps for IETC text shadow tests.

  • platform/chromium-linux/ietestcenter/css3/text/textshadow-001-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/text/textshadow-002-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/text/textshadow-003-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/text/textshadow-004-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/text/textshadow-005-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/text/textshadow-006-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/text/textshadow-007-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/text/textshadow-008-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/text/textshadow-009-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/text/textshadow-010-expected.png: Added.
  • platform/chromium-mac-leopard/ietestcenter/css3/text/textshadow-001-expected.png: Added.
  • platform/chromium-mac-leopard/ietestcenter/css3/text/textshadow-002-expected.png: Added.
  • platform/chromium-mac-leopard/ietestcenter/css3/text/textshadow-003-expected.png: Added.
  • platform/chromium-mac-leopard/ietestcenter/css3/text/textshadow-004-expected.png: Added.
  • platform/chromium-mac-leopard/ietestcenter/css3/text/textshadow-005-expected.png: Added.
  • platform/chromium-mac-leopard/ietestcenter/css3/text/textshadow-006-expected.png: Added.
  • platform/chromium-mac-leopard/ietestcenter/css3/text/textshadow-007-expected.png: Added.
  • platform/chromium-mac-leopard/ietestcenter/css3/text/textshadow-008-expected.png: Added.
  • platform/chromium-mac-leopard/ietestcenter/css3/text/textshadow-009-expected.png: Added.
  • platform/chromium-mac-leopard/ietestcenter/css3/text/textshadow-010-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-004-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-005-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-006-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-007-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-008-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-009-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-010-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/text/textshadow-001-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/text/textshadow-001-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/text/textshadow-002-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/text/textshadow-002-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/text/textshadow-003-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/text/textshadow-003-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/text/textshadow-004-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/text/textshadow-004-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/text/textshadow-005-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/text/textshadow-005-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/text/textshadow-006-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/text/textshadow-006-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/text/textshadow-007-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/text/textshadow-007-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/text/textshadow-008-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/text/textshadow-008-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/text/textshadow-009-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/text/textshadow-009-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/text/textshadow-010-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/text/textshadow-010-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/text/textshadow-001-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/text/textshadow-001-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/text/textshadow-002-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/text/textshadow-002-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/text/textshadow-003-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/text/textshadow-003-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/text/textshadow-004-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/text/textshadow-004-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/text/textshadow-005-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/text/textshadow-005-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/text/textshadow-006-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/text/textshadow-006-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/text/textshadow-007-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/text/textshadow-007-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/text/textshadow-008-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/text/textshadow-008-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/text/textshadow-009-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/text/textshadow-009-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/text/textshadow-010-expected.png: Added.
  • platform/chromium-win/ietestcenter/css3/text/textshadow-010-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
13:21 Changeset [112715] by dpranke@chromium.org
  • 19 edits
    1 delete in trunk/LayoutTests

More SVG rebaselining.

Unreviewed, new baselines and expectations, for:

svg/W3C-SVG-1.1/animate-elem-37-t.svg
svg/W3C-SVG-1.1/animate-elem-81-t.svg
svg/W3C-SVG-1.1/animate-elem-82-t.svg
svg/W3C-SVG-1.1/animate-elem-83-t.svg
svg/W3C-SVG-1.1/struct-frag-02-t.svg
svg/W3C-SVG-1.1/text-align-05-b.svg
svg/text/text-align-05-b.svg
svg/zoom/page/zoom-coords-viewattr-01-b.svg
svg/zoom/text/zoom-coords-viewattr-01-b.svg
svg/W3C-SVG-1.1/types-basicDOM-01-b.svg

  • platform/chromium-linux/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Removed.
  • platform/chromium-mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-37-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-37-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-81-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-81-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-83-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-frag-02-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-align-05-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/chromium-win/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:
  • platform/chromium/test_expectations.txt:
13:19 Changeset [112714] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Make sure strings do not leak in PluginViewBlackberry.
https://bugs.webkit.org/show_bug.cgi?id=82764

Update PluginViewBlackBerry to follow the changes in
BlackBerry::Platform::Window which now returns std::string instead of char* for
strings. Also copy the windowGroup and rootGroup strings in PluginViewPrivate
instead of just saving a pointer to the returned memory, which could become
invalid at any time.

Patch by Joe Mason <jmason@rim.com> on 2012-03-30
Reviewed by Rob Buis.

  • plugins/blackberry/PluginViewBlackBerry.cpp:

(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::platformGetValue):
(WebCore::PluginView::platformDestroy):

  • plugins/blackberry/PluginViewPrivateBlackBerry.h:

(PluginViewPrivate):

13:03 Changeset [112713] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Another build fix.

  • WebCore.xcodeproj/project.pbxproj:
12:56 Changeset [112712] by ossy@webkit.org
  • 3 edits in trunk/LayoutTests

Add new renderer for circles and ellipses
https://bugs.webkit.org/show_bug.cgi?id=80423

One more unreviewed gardening after r112667.

  • platform/qt-5.0/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt:
12:31 Changeset [112711] by dpranke@chromium.org
  • 7 edits
    1 copy
    1 move
    6 adds
    10 deletes in trunk/LayoutTests

Unreviewed, expectations updates for Lion, Linux for some SVG tests.

  • platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Removed.
  • platform/chromium-mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Copied from LayoutTests/platform/chromium-win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt.
  • platform/chromium-mac/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt:
  • platform/chromium-mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Removed.
  • platform/chromium-mac/svg/custom/viewbox-syntax-expected.txt:
  • platform/chromium-mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/chromium-mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Removed.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Removed.
  • platform/chromium-win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt:
  • platform/chromium-win/svg/custom/viewbox-syntax-expected.txt:
  • platform/chromium/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt.
  • platform/chromium/test_expectations.txt:
12:22 Changeset [112710] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix build.

  • page/scrolling/mac/ScrollingTreeMac.mm:
12:06 Changeset [112709] by ojan@chromium.org
  • 21 edits
    3 copies
    3 moves
    234 adds
    6 deletes in trunk/LayoutTests

Chromium garden-o-matic rebaselines for expected failures.
Most of these are one of the following:
-text-rendering differences
-anti-aliasing differences
-form control/scrollbar rendering
-different error messages from V8 vs. JSC
-Mac bots paint repaint shadow at a slightly different shade

12:05 Changeset [112708] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Flaky animation unit test CCLayerTreeHostTestSynchronizeAnimationStartTimes
https://bugs.webkit.org/show_bug.cgi?id=82731

Patch by Ian Vollick <vollick@chromium.org> on 2012-03-30
Reviewed by James Robinson.

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestSynchronizeAnimationStartTimes::CCLayerTreeHostTestSynchronizeAnimationStartTimes):
(WTF::CCLayerTreeHostTestSynchronizeAnimationStartTimes::animateLayers):
(CCLayerTreeHostTestSynchronizeAnimationStartTimes):
(WTF::CCLayerTreeHostTestSynchronizeAnimationStartTimes::notifyAnimationStarted):

11:59 Changeset [112707] by andersca@apple.com
  • 11 edits
    1 add in trunk/Source

Show a scrolling indicator light when compositing borders are turned on
https://bugs.webkit.org/show_bug.cgi?id=82758
<rdar://problem/11143892>

Reviewed by Andreas Kling.

Source/WebCore:

With this change, turning on compositing borders also turn on a tiny indicator in the top left corner.
This indicator uses color coding to show where wheel events are handled and where the scroll layer position is updated:

  • Green means that both wheel events and scroll layer position updates are handled on the scrolling thread.
  • Yellow means that wheel events need to be dispatched to the main thread (due to wheel event handlers), but that scroll layer position updates still happen on the scrolling thread.
  • Red means that scroll layer position updates happen on the main thread (due to background-attachment: fixed or fixed position objects).
  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::commitNewTreeState):
Call updateDebugRootLayer().

  • page/scrolling/ScrollingTreeNode.h:

(WebCore::ScrollingTreeNode::shouldUpdateScrollLayerPositionOnMainThread):
Make this public.

(ScrollingTreeNode):

  • page/scrolling/mac/ScrollingTreeMac.mm: Added.

(WebCore::ScrollingTree::setDebugRootLayer):
Set up a new debug info sublayer.

(WebCore::ScrollingTree::updateDebugRootLayer):
Update the debug root layer background color based on the scrolling tree state.

Source/WebKit2:

  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::updatePreferences):
Add a hook for letting drawing area subclasses know when preferences change.

  • WebProcess/WebPage/WebPage.cpp:

Call DrawingArea::updatePreferences.

(WebKit::WebPage::updatePreferences):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
Call updatePreferences.

(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):
If compositing borders are enabled, create a debug root layer and tell the scrolling tree about it.

(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
If we have a debug root layer, make sure it's in front.

11:54 Changeset [112706] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: add missing runtime assert method for InspectorObject
https://bugs.webkit.org/show_bug.cgi?id=82753

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-03-30
Reviewed by Vsevolod Vlasov.

Type validator generator is extended to support missing InspectorObject type and
made more accurate for "int" type.

Strict types are enabled for 2 more domains.

  • inspector/CodeGeneratorInspector.py:

(RawTypes.BaseType.generate_validate_method):
(RawTypes.String.get_validate_method_params.ValidateMethodParams):
(RawTypes.Int):
(RawTypes.Int.generate_validate_method):
(RawTypes.Int.get_raw_validator_call_text):
(RawTypes.Number.get_validate_method_params.ValidateMethodParams):
(RawTypes.Bool.get_validate_method_params.ValidateMethodParams):
(RawTypes.Object.get_validate_method_params.ValidateMethodParams):
(RawTypes.Object.get_validate_method_params):
(TypeBindings.create_type_declaration_.ClassBinding.request_internal_runtime_cast):
(PlainObjectBinding.request_internal_runtime_cast):
(PlainObjectBinding.get_validator_call_text):
(ArrayBinding.request_internal_runtime_cast):

11:49 Changeset [112705] by simon.fraser@apple.com
  • 2 edits in trunk/LayoutTests

Fix a typo in the Skipped list.

  • platform/mac/Skipped:
11:45 Changeset [112704] by shawnsingh@chromium.org
  • 6 edits in branches/chromium/1084/LayoutTests/platform

Merge 112696 - Unreviewed rebaseline after r112436

  • platform/chromium-linux/compositing/reflections/nested-reflection-on-overflow-expected.png:
  • platform/chromium-mac-leopard/compositing/reflections/nested-reflection-on-overflow-expected.png:
  • platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-on-overflow-expected.png:
  • platform/chromium-mac/compositing/reflections/nested-reflection-on-overflow-expected.png:
  • platform/chromium-win/compositing/reflections/nested-reflection-on-overflow-expected.png:
  • platform/chromium/test_expectations.txt:

TBR=shawnsingh@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9956029

11:44 Changeset [112703] by simon.fraser@apple.com
  • 2 edits in trunk/LayoutTests

Skip some more failing/timing-out tests.

  • platform/mac/Skipped:
11:42 Changeset [112702] by shawnsingh@chromium.org
  • 8 edits in branches/chromium/1084

Merge 112436 - [chromium] layer->clipRect() is not initialized for layers that create a renderSurface.
https://bugs.webkit.org/show_bug.cgi?id=74147

Reviewed by Adrienne Walker.

Source/WebCore:

Added 3 additional unit tests; Modified existing unit tests and layout tests.

The layer's clipRect and usesLayerClipping information was not
being initialized for layers that created a renderSurface. (It
was, however, being initialized for the renderSurface itself.)
This patch adds a unit test that reproduces that this is an error,
other unit tests to tightly test the value of clipRect being
initialized, and adds the logic to properly initialize the
clipRect.

Before this patch, this bug was causing flashing on tab-switch on
the apple iphone page. Even worse, with partial swap enabled, the
layers would simply disappear, because the first frame the
clipRect is uninitialized and the layer is not drawn, and the
second frame onwards, the damage tracker correctly things nothing
is damaged, so it doesn't draw that layer again until other damage
causes it to be redrawn.

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsAndVisibilityInternal):

Source/WebKit/chromium:

Added 3 more unit tests. One reproduces the clipRect problem in an
integrated manner, the other two directly test that clipRects are
properly initialized.

  • tests/CCLayerTreeHostCommonTest.cpp:

(WebCore::TEST):
(WebCore):

  • tests/CCLayerTreeTestCommon.h:

(WebKitTests):

LayoutTests:

  • platform/chromium/test_expectations.txt: marked test as needing rebaselining

TBR=shawnsingh@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9958025

11:39 Changeset [112701] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[chromium] assertion being hit in CCLayerAnimationController
https://bugs.webkit.org/show_bug.cgi?id=82237

Patch by Ian Vollick <vollick@chromium.org> on 2012-03-30
Reviewed by James Robinson.

Source/WebCore:

Animations are no longer pushed to the impl thread if they have already completed.

Tested in CCLayerAnimationControllerTest.doNotSyncFinishedAnimation

  • platform/graphics/chromium/cc/CCLayerAnimationController.cpp:

(WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):

Source/WebKit/chromium:

  • tests/CCLayerAnimationControllerTest.cpp:

(WebKitTests::TEST):
(WebKitTests):

11:32 Changeset [112700] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix after r112699.

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::findPropertyWithId):

11:30 WebKit Team edited by chang.shu@nokia.com
(diff)
11:28 WebKit Team edited by chang.shu@nokia.com
(diff)
11:27 Changeset [112699] by rniwa@webkit.org
  • 4 edits in trunk/Source/WebCore

Add a compile assert for the size of CSSProperty
https://bugs.webkit.org/show_bug.cgi?id=82756

Reviewed by Andreas Kling.

Add a compile assert to ensure CSSProperty instances stay small.

Also make member variables of CSSProperty private as they should have been,
and extract wrapValueInCommaSeparatedList from createFontFaceRule.

  • css/CSSParser.cpp:

(WebCore::CSSParser::createFontFaceRule):

  • css/CSSProperty.cpp:

(SameSizeAsCSSProperty):
(WebCore):
(WebCore::CSSProperty::wrapValueInCommaSeparatedList):

  • css/CSSProperty.h:

(CSSProperty):

11:24 Changeset [112698] by chang.shu@nokia.com
  • 2 edits in trunk/Tools

2012-03-30 Chang Shu <cshu@webkit.org>

Unreviewed. Update my email.

  • Scripts/webkitpy/common/config/committers.py:
11:20 Changeset [112697] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Let there be a clean xcodeproj.

  • WebCore.xcodeproj/project.pbxproj:
11:13 Changeset [112696] by shawnsingh@chromium.org
  • 7 edits in trunk/LayoutTests

Unreviewed rebaseline after r112436

  • platform/chromium-linux/compositing/reflections/nested-reflection-on-overflow-expected.png:
  • platform/chromium-mac-leopard/compositing/reflections/nested-reflection-on-overflow-expected.png:
  • platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-on-overflow-expected.png:
  • platform/chromium-mac/compositing/reflections/nested-reflection-on-overflow-expected.png:
  • platform/chromium-win/compositing/reflections/nested-reflection-on-overflow-expected.png:
  • platform/chromium/test_expectations.txt:
11:09 Changeset [112695] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Unreviewed Chromium Mac build fix.

  • src/WebDevToolsAgentPrivate.h:

(WebKit):

11:07 Changeset [112694] by cfleizach@apple.com
  • 11 edits
    2 adds in trunk

AX: Crash at WebCore::renderObjectContainsPosition(WebCore::RenderObject*, WebCore::Position const&)
https://bugs.webkit.org/show_bug.cgi?id=82745

Reviewed by Simon Fraser.

Source/WebCore:

Test: platform/mac/accessibility/range-for-position.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::index):

Tools:

  • DumpRenderTree/AccessibilityUIElement.cpp:

(rangeForPositionCallback):
(AccessibilityUIElement::rangeForPosition):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:

(AccessibilityUIElement):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::rangeForPosition):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR::AccessibilityUIElement::rangeForPosition):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:

(AccessibilityUIElement):

  • WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::rangeForPosition):
(WTR):

LayoutTests:

  • platform/mac/accessibility/range-for-position-expected.txt: Added.
  • platform/mac/accessibility/range-for-position.html: Added.
11:04 Changeset [112693] by jamesr@google.com
  • 7 edits in branches/chromium/1084/Source

Merge 112568 - [chromium] Ensure framebuffer exists at the start of beginDrawingFrame.
https://bugs.webkit.org/show_bug.cgi?id=82569

Patch by Michal Mocny <mmocny@google.com> on 2012-03-29
Reviewed by James Robinson.

Source/WebCore:

Updated LayerRendererChromiumTest unittests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::setVisible):
(WebCore::LayerRendererChromium::beginDrawingFrame):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::compositeAndReadback):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::requestReadbackOnImplThread):

Source/WebKit/chromium:

  • tests/LayerRendererChromiumTest.cpp:

(FakeLayerRendererChromiumClient::FakeLayerRendererChromiumClient):
(FakeLayerRendererChromiumClient::rootLayer):
(FakeLayerRendererChromiumClient):
(TEST_F):

TBR=commit-queue@webkit.org
BUG=120589
Review URL: https://chromiumcodereview.appspot.com/9969020

11:02 Changeset [112692] by apavlov@chromium.org
  • 181 edits
    12 copies
    10 moves
    11 adds
    7 deletes in trunk/LayoutTests

[Chromium] Unreviewed, rebaseline part of expectations after r112667 using garden-o-matic (224 files affected).

  • platform/chromium-linux-x86/svg/: [...]
  • platform/chromium-linux/svg/: [...]
  • platform/chromium-mac-leopard/svg/: [...]
  • platform/chromium-mac-snowleopard/svg/: [...]
  • platform/chromium-mac/svg/: [...]
  • platform/chromium-win-vista/svg/: [...]
  • platform/chromium-win-xp/svg/: [...]
  • platform/chromium-win/svg/: [...]
  • platform/chromium/svg/hixie/shapes/path/001-expected.txt: Renamed from LayoutTests/platform/chromium-win/svg/hixie/shapes/path/001-expected.txt.
  • platform/chromium/svg/stroke/zero-length-arc-linecaps-rendering-expected.txt:
  • platform/gtk/svg/hixie/perf/001-expected.txt: Removed.
  • platform/gtk/svg/hixie/perf/002-expected.txt: Removed.
  • platform/gtk/svg/hixie/shapes/path/001-expected.txt: Removed.
  • platform/mac-snowleopard/svg/custom/object-sizing-no-width-height-expected.png: Removed.
  • svg/hixie/mixed/004-expected.txt: Renamed from LayoutTests/platform/qt/svg/hixie/mixed/004-expected.txt.
  • svg/hixie/mixed/005-expected.txt: Renamed from LayoutTests/platform/qt/svg/hixie/mixed/005-expected.txt.
  • svg/hixie/perf/001-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/001-expected.txt.
  • svg/hixie/perf/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/002-expected.txt.
  • svg/hixie/shapes/path/001-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/shapes/path/001-expected.txt.
11:00 Changeset [112691] by sullivan@apple.com
  • 2 edits in trunk/Source/WebCore

Certain emoji characters should not be displayed in user-visible URL strings.
<https://bugs.webkit.org/show_bug.cgi?id=82739>
<rdar://problem/9205643>

Reviewed by Alexey Proskuryakov

  • platform/mac/WebCoreNSURLExtras.mm:

(WebCore::isLookalikeCharacter):
Added five emoji characters to the list.

10:54 Changeset [112690] by apavlov@chromium.org
  • 9 edits in trunk/Source/WebKit/chromium

Web Inspector: [Chromium] Implement Chromium-specific part of the device metrics emulation
https://bugs.webkit.org/show_bug.cgi?id=82612

This change implements the Chromium-specific code for overriding the device metrics, such as screen size
(by setting the FrameView size) and font zoom factor (necessary for certain emulated devices,)
and for painting the gutter overlay covering the WebView area not occupied by the associated FrameView.

Reviewed by Pavel Feldman.

  • src/InspectorClientImpl.cpp:

(WebKit::InspectorClientImpl::canOverrideDeviceMetrics):
(WebKit):
(WebKit::InspectorClientImpl::overrideDeviceMetrics):
(WebKit::InspectorClientImpl::autoZoomPageToFitWidth):

  • src/InspectorClientImpl.h:

(InspectorClientImpl):

  • src/WebDevToolsAgentImpl.cpp:

(OverlayZOrders):
(DeviceMetricsSupport):
(WebKit::DeviceMetricsSupport::DeviceMetricsSupport):
(WebKit::DeviceMetricsSupport::~DeviceMetricsSupport):
(WebKit::DeviceMetricsSupport::setDeviceMetrics):
(WebKit::DeviceMetricsSupport::autoZoomPageToFitWidth):
(WebKit::DeviceMetricsSupport::applySizeOverrideIfNecessary):
(WebKit::DeviceMetricsSupport::restore):
(WebKit::DeviceMetricsSupport::applySizeOverrideInternal):
(WebKit::DeviceMetricsSupport::paintPageOverlay):
(WebKit::DeviceMetricsSupport::frameView):
(WebKit):
(WebKit::WebDevToolsAgentImpl::mainFrameViewCreated):
(WebKit::WebDevToolsAgentImpl::metricsOverridden):
(WebKit::WebDevToolsAgentImpl::overrideDeviceMetrics):
(WebKit::WebDevToolsAgentImpl::autoZoomPageToFitWidth):
(WebKit::WebDevToolsAgentImpl::highlight):

  • src/WebDevToolsAgentImpl.h:

(WebCore):
(WebKit):
(WebDevToolsAgentImpl):

  • src/WebDevToolsAgentPrivate.h:

(WebKit):
(WebDevToolsAgentPrivate):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::createFrameView):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::resize):
(WebKit::WebViewImpl::setZoomLevel):
(WebKit::WebViewImpl::setEmulatedTextZoomFactor):
(WebKit):
(WebKit::WebViewImpl::updateLayerTreeViewport):

  • src/WebViewImpl.h:

(WebViewImpl):
(WebKit::WebViewImpl::emulatedTextZoomFactor):

10:53 Changeset [112689] by simon.fraser@apple.com
  • 2 edits in trunk/LayoutTests

Skip some more failing tests.

  • platform/mac/Skipped:
10:37 Changeset [112688] by simon.fraser@apple.com
  • 2 edits in trunk/LayoutTests

Skip fast/css/font-face-data-uri.html which is flaky.
Tracked by https://bugs.webkit.org/show_bug.cgi?id=82744

  • platform/mac/Skipped:
10:35 Changeset [112687] by simon.fraser@apple.com
  • 2 edits in trunk/LayoutTests

Skip a test, tracked by https://bugs.webkit.org/show_bug.cgi?id=82743.

  • platform/mac/Skipped:
10:32 Changeset [112686] by vsevik@chromium.org
  • 3 edits in branches/chromium/1084

Merge 112379 - Web Inspector: breakpoints are not shown in sidebar pane after reload.
https://bugs.webkit.org/show_bug.cgi?id=82351

Reviewed by Pavel Feldman.

Source/WebCore:

When UISourceCode is added to ScriptsPanel, it could already have breakpoints.
We should iterate over existing breakpoints and add them to sidebar pane.

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):

LayoutTests:

  • inspector/debugger/set-breakpoint-expected.txt:
  • inspector/debugger/set-breakpoint.html:

TBR=podivilov@chromium.org
BUG=120853
Review URL: https://chromiumcodereview.appspot.com/9958020

10:31 Changeset [112685] by simon.fraser@apple.com
  • 2 edits in trunk/LayoutTests

Skip two lineboxcontain tests. Tracked by
https://bugs.webkit.org/show_bug.cgi?id=82742

  • platform/mac/Skipped:
10:27 Changeset [112684] by vsevik@chromium.org
  • 3 edits in branches/chromium/1084/Source/WebCore/inspector/front-end

Merge 112677 - Web Inspector: ScriptsNavigator scripts selection/focus polish.
https://bugs.webkit.org/show_bug.cgi?id=82732

Reviewed by Pavel Feldman.

Script could be selected by space in ScriptsNavigator now.
This patch also polishes focus behavior when using ScriptsNavigator.

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator.prototype._scriptSelected): Added focusSource param to give clients possibility to release focus.
(WebInspector.NavigatorScriptTreeElement.prototype.onspace): Added script selection on space pressed.
(WebInspector.NavigatorScriptTreeElement.prototype._onclick):
(WebInspector.NavigatorScriptTreeElement.prototype.onenter):

  • inspector/front-end/ScriptsPanel.js: _hideNavigatorOverlay moved to the end of events processing to set focus correctly.

(WebInspector.ScriptsPanel.prototype._editorSelected):
(WebInspector.ScriptsPanel.prototype._fileSelected):
(WebInspector.ScriptsPanel.prototype._hideNavigatorOverlay):

  • inspector/front-end/treeoutline.js:

(TreeOutline.prototype._treeKeyDown): onspace event added.

TBR=vsevik@chromium.org
BUG=121133
Review URL: https://chromiumcodereview.appspot.com/9956025

10:17 Changeset [112683] by commit-queue@webkit.org
  • 12 edits
    17 adds in trunk

Split up top-level .gitignore and .gitattributes
https://bugs.webkit.org/show_bug.cgi?id=82687

Patch by David Barr <davidbarr@chromium.org> on 2012-03-30
Reviewed by Tor Arne Vestbø.

.:

Jeff King <peff@peff.net> suggested this on the git mailing list.
http://article.gmane.org/gmane.comp.version-control.git/194294
He reported a 1.6 times speed up for 'git status'.

  • .gitattributes:
  • .gitignore:
  • ManualTests/.gitattributes: Added.
  • Source/.gitignore: Added.
  • Websites/.gitattributes: Added.

PerformanceTests:

  • .gitattributes: Added.

Source/JavaScriptCore:

Source/Platform:

  • Platform.gyp/.gitignore: Added.

Source/ThirdParty:

  • glu/.gitignore: Added.

Source/WebCore:

No new tests, source control administrivia.

  • .gitattributes: Added.
  • WebCore.gyp/.gitignore: Added.

Source/WebKit/chromium:

  • .gitignore: Added.

Source/WTF:

  • WTF.gyp/.gitignore: Added.

Tools:

  • .gitattributes: Added.
  • .gitignore: Added.
  • DumpRenderTree/DumpRenderTree.gyp/.gitignore: Added.
  • TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Added.

LayoutTests:

  • .gitattributes: Added.
  • .gitignore: Added.
10:08 Changeset [112682] by reed@google.com
  • 3 edits in trunk/Source/WebKit/chromium

pass alpha directly to player, rather than creating a layer (for performance)
https://bugs.webkit.org/show_bug.cgi?id=82360

Reviewed by Stephen White.

Performance change, existing webkit tests apply.

  • public/WebMediaPlayer.h:

(WebMediaPlayer):

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::paintCurrentFrameInContext):

10:01 Changeset [112681] by vsevik@chromium.org
  • 1 edit in branches/chromium/1084/Source/WebCore/inspector/front-end/ScriptsNavigator.js

Merge 112656 - Web Inspector: ScriptsNavigator should open scripts with single click (not double click).
https://bugs.webkit.org/show_bug.cgi?id=82723

Reviewed by Pavel Feldman.

This patch makes ScriptsNavigator open scripts with single click.

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.NavigatorScriptTreeElement.prototype.onattach):
(WebInspector.NavigatorScriptTreeElement.prototype._onclick):

TBR=vsevik@chromium.org
BUG=121087
Review URL: https://chromiumcodereview.appspot.com/9963015

09:53 Changeset [112680] by paroga@webkit.org
  • 5 edits in trunk/Source

[WinCE] Correct <wtf/*.h> include paths.
https://bugs.webkit.org/show_bug.cgi?id=82713

Reviewed by Eric Seidel.

Modify the #include declarations for several WinCE-related files
so that the wtf types are included using the full path.

Source/WebCore:

  • platform/graphics/wince/ImageBufferWinCE.cpp:

Source/WebKit/wince:

  • WebView.cpp:
  • WebView.h:
09:50 Changeset [112679] by vsevik@chromium.org
  • 1 edit in branches/chromium/1084/Source/WebCore/inspector/front-end/JavaScriptSourceFrame.js

Merge 112661 - Web Inspector: [Regression] Execution line is not revealed after pretty print.
https://bugs.webkit.org/show_bug.cgi?id=82727

Reviewed by Pavel Feldman.

This patch makes JavaScriptSourceFrame reveal execution line after pretty print.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.setExecutionLine):

TBR=vsevik@chromium.org
BUG=121091
Review URL: https://chromiumcodereview.appspot.com/9950021

09:47 Changeset [112678] by sfalken@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows (make based) build fix.

09:39 Changeset [112677] by vsevik@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: ScriptsNavigator scripts selection/focus polish.
https://bugs.webkit.org/show_bug.cgi?id=82732

Reviewed by Pavel Feldman.

Script could be selected by space in ScriptsNavigator now.
This patch also polishes focus behavior when using ScriptsNavigator.

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator.prototype._scriptSelected): Added focusSource param to give clients possibility to release focus.
(WebInspector.NavigatorScriptTreeElement.prototype.onspace): Added script selection on space pressed.
(WebInspector.NavigatorScriptTreeElement.prototype._onclick):
(WebInspector.NavigatorScriptTreeElement.prototype.onenter):

  • inspector/front-end/ScriptsPanel.js: _hideNavigatorOverlay moved to the end of events processing to set focus correctly.

(WebInspector.ScriptsPanel.prototype._editorSelected):
(WebInspector.ScriptsPanel.prototype._fileSelected):
(WebInspector.ScriptsPanel.prototype._hideNavigatorOverlay):

  • inspector/front-end/treeoutline.js:

(TreeOutline.prototype._treeKeyDown): onspace event added.

09:33 Changeset [112676] by reed@google.com
  • 2 edits in trunk/Source/WebCore

remove unneeded copies of SkPaths, remove unneeded save/restore
https://bugs.webkit.org/show_bug.cgi?id=82641

Reviewed by Stephen White.

Performance change, existing webkit tests apply.

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::strokePath):

09:31 Changeset [112675] by mihaip@chromium.org
  • 2 edits in trunk/Tools

Actually remove the ChromiumOS GTK builder, like r112673 said it would.

  • TestResultServer/static-dashboards/builders.js:
09:24 Changeset [112674] by pfeldman@chromium.org
  • 4 edits
    2 adds in trunk

Web Inspector: undo-ing edit that consists of a Tab does not work.
https://bugs.webkit.org/show_bug.cgi?id=82733

Reviewed by Vsevolod Vlasov.

Source/WebCore:

We should never modify the range returned by the edit operation manually.
And we should clone ranges that get into the model so that subsequent edits
don't mutate them.

Drive-by: restore selection after undo via selecting all the text that undo
operation produced.

Test: inspector/editor/text-editor-undo-redo.html

  • inspector/front-end/TextEditorModel.js:

(WebInspector.TextEditorModel.endsWithBracketRegex.):

  • inspector/front-end/TextViewer.js:

LayoutTests:

  • inspector/editor/text-editor-undo-redo-expected.txt: Added.
  • inspector/editor/text-editor-undo-redo.html: Added.
09:23 Changeset [112673] by mihaip@chromium.org
  • 2 edits in trunk/Tools

Update ChromiumOS bot names in builders.js to reflect changes made by
http://crrev.com/129835

Also removes the ChromiumOS GTK builder, which was removed by
http://crrev.com/129835

  • TestResultServer/static-dashboards/builders.js:
09:18 Changeset [112672] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Disable introspection build in the at-spi2-core module.
https://bugs.webkit.org/show_bug.cgi?id=82729

Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-03-30
Reviewed by Philippe Normand.

This change is a follow-up of bug 82395 which initially disabled for other modules of the set.

  • gtk/jhbuild.modules: Disable introspection.
09:00 Changeset [112671] by ossy@webkit.org
  • 177 edits in trunk/LayoutTests

Add new renderer for circles and ellipses
https://bugs.webkit.org/show_bug.cgi?id=80423

Unreviewed gardening after r112667.

  • platform/qt/svg/ [...] : Updated.
08:57 Changeset [112670] by kevino@webkit.org
  • 8 edits in trunk/Source/WebCore

[wx] Implement Gradient and ImageBuffer support.
https://bugs.webkit.org/show_bug.cgi?id=82710

Reviewed by Kevin Ollivier.

08:47 Changeset [112669] by commit-queue@webkit.org
  • 16 edits
    2 adds in trunk

[Qt] Find zoomable area using area-based hit-testing
https://bugs.webkit.org/show_bug.cgi?id=82609

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-30
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Implement API for calculating the best zoomable area for a
tap-to-zoom gesture.
It picks the area with the largest intersection with the touch. In most
cases this will be all areas fully containing the area, and returns the
smallest inner-most of these.

  • page/EventHandler.cpp:

(WebCore::EventHandler::bestZoomableAreaForTouchPoint):

  • page/EventHandler.h:
  • page/TouchAdjustment.cpp:

(WebCore::TouchAdjustment::nodeIsZoomTarget):
(WebCore::TouchAdjustment::appendZoomableSubtargets):
(WebCore::TouchAdjustment::compileZoomableSubtargets):
(WebCore::TouchAdjustment::areaOfIntersection):
(WebCore::TouchAdjustment::findAreaWithLargestIntersection):
(WebCore::findBestZoomableArea):

  • page/TouchAdjustment.h:
  • platform/graphics/IntSize.h:

(WebCore::IntSize::area):

Source/WebKit2:

Add area to findZoomableAreaForPoint and use new TOUCH_ADJUSTMENT
code-path to find the best zoomable area.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::findZoomableAreaForPoint):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::handleDoubleTapEvent):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit):
(WebKit::WebPage::findZoomableAreaForPoint):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

  • WebProcess/WebPage/WebPage.messages.in:
08:44 Changeset [112668] by pfeldman@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: do not issue attributes modified event if actual values were not changed.
https://bugs.webkit.org/show_bug.cgi?id=82726

Reviewed by Yury Semikhatsky.

Source/WebCore:

When style attribute is invalidated, we re-fetch the attributes values. There is no
point in further dispatching attrs modified event if model stays the same.

Test: inspector/elements/edit-style-attribute.html

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode.prototype._setAttributesPayload):
(WebInspector.DOMAgent.prototype._loadNodeAttributes):

LayoutTests:

  • inspector/elements/edit-style-attribute-expected.txt: Added.
  • inspector/elements/edit-style-attribute.html: Added.
08:37 Changeset [112667] by schenney@chromium.org
  • 251 edits
    6 adds in trunk

Add new renderer for circles and ellipses
https://bugs.webkit.org/show_bug.cgi?id=80423

Patch by Philip Rogers <pdr@google.com> on 2012-03-30
Reviewed by Eric Seidel.

Source/WebCore:

This patch introduces a special renderer for SVGCircleElements
and SVGEllipseElements to avoid having to use the slower path
rendering code. This patch includes optimized circle code for
the CG platform, and hooks (GC::fillEllipse, GC::strokeEllipse)
are available for other platforms as well.

Tests: svg/hittest/svg-ellipse-non-scale-stroke.xhtml

svg/hittest/svg-ellipse.xhtml

Added a test to exercise hit testing on an ellipse, and on
an ellipse's stroke, to make sure the formulae in this patch
are correct.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::fillEllipse):
(WebCore):
(WebCore::GraphicsContext::strokeEllipse):
(WebCore::GraphicsContext::fillEllipseAsPath):
(WebCore::GraphicsContext::strokeEllipseAsPath):
(WebCore::GraphicsContext::platformFillEllipse):
(WebCore::GraphicsContext::platformStrokeEllipse):

  • platform/graphics/GraphicsContext.h:

(GraphicsContext):

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::platformFillEllipse):
(WebCore):
(WebCore::GraphicsContext::platformStrokeEllipse):

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::platformFillEllipse):
(WebCore):
(WebCore::GraphicsContext::platformStrokeEllipse):

  • rendering/svg/RenderSVGAllInOne.cpp:
  • rendering/svg/RenderSVGEllipse.cpp: Added.

(WebCore):
(WebCore::RenderSVGEllipse::RenderSVGEllipse):
(WebCore::RenderSVGEllipse::~RenderSVGEllipse):
(WebCore::RenderSVGEllipse::createShape):
(WebCore::RenderSVGEllipse::calculateRadiiAndCenter):
(WebCore::RenderSVGEllipse::objectBoundingBox):
(WebCore::RenderSVGEllipse::strokeBoundingBox):
(WebCore::RenderSVGEllipse::fillShape):
(WebCore::RenderSVGEllipse::strokeShape):
(WebCore::RenderSVGEllipse::shapeDependentStrokeContains):
(WebCore::RenderSVGEllipse::shapeDependentFillContains):

  • rendering/svg/RenderSVGEllipse.h: Added.

(WebCore):
(RenderSVGEllipse):
(WebCore::RenderSVGEllipse::isSVGEllipse):
(WebCore::RenderSVGEllipse::renderName):
(WebCore::RenderSVGEllipse::isEmpty):

  • svg/SVGCircleElement.cpp:

(WebCore::SVGCircleElement::svgAttributeChanged):
(WebCore):
(WebCore::SVGCircleElement::createRenderer):

  • svg/SVGCircleElement.h:

(SVGCircleElement):

  • svg/SVGEllipseElement.cpp:

(WebCore::SVGEllipseElement::svgAttributeChanged):
(WebCore::SVGEllipseElement::createRenderer):
(WebCore):

  • svg/SVGEllipseElement.h:

(SVGEllipseElement):

LayoutTests:

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-32-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-37-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-44-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-81-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/color-prop-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/color-prop-02-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/color-prop-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-units-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/interact-order-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/interact-order-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/linking-a-04-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/linking-a-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/script-handle-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/script-handle-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/script-handle-04-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-04-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/styling-css-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/styling-css-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/styling-css-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt:
  • platform/mac/svg/as-image/img-preserveAspectRatio-support-1-expected.txt:
  • platform/mac/svg/as-image/img-preserveAspectRatio-support-2-expected.txt:
  • platform/mac/svg/as-object/object-box-sizing-no-width-height-expected.txt:
  • platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt:
  • platform/mac/svg/batik/masking/maskRegions-expected.txt:
  • platform/mac/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
  • platform/mac/svg/batik/paints/patternRegions-expected.txt:
  • platform/mac/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
  • platform/mac/svg/batik/text/verticalText-expected.txt:
  • platform/mac/svg/carto.net/button-expected.txt:
  • platform/mac/svg/clip-path/clip-in-mask-expected.txt:
  • platform/mac/svg/clip-path/clip-path-child-clipped-expected.txt:
  • platform/mac/svg/clip-path/clip-path-evenodd-nonzero-expected.txt:
  • platform/mac/svg/clip-path/clip-path-nonzero-evenodd-expected.txt:
  • platform/mac/svg/clip-path/clip-path-nonzero-expected.txt:
  • platform/mac/svg/clip-path/clip-path-pixelation-expected.txt:
  • platform/mac/svg/clip-path/clip-path-transform-1-expected.txt:
  • platform/mac/svg/clip-path/clip-path-use-as-child2-expected.txt:
  • platform/mac/svg/clip-path/clip-path-use-as-child3-expected.txt:
  • platform/mac/svg/clip-path/clip-path-use-as-child4-expected.txt:
  • platform/mac/svg/clip-path/clip-path-use-as-child5-expected.txt:
  • platform/mac/svg/clip-path/clip-path-with-different-unittypes-expected.txt:
  • platform/mac/svg/clip-path/clip-path-with-different-unittypes2-expected.txt:
  • platform/mac/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt:
  • platform/mac/svg/clip-path/deep-nested-clip-in-mask-expected.txt:
  • platform/mac/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt:
  • platform/mac/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.txt:
  • platform/mac/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.txt:
  • platform/mac/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.txt:
  • platform/mac/svg/css/shadow-changes-expected.txt:
  • platform/mac/svg/custom/absolute-sized-content-with-resources-expected.txt:
  • platform/mac/svg/custom/circle-move-invalidation-expected.txt:
  • platform/mac/svg/custom/circular-marker-reference-2-expected.txt:
  • platform/mac/svg/custom/clone-element-with-animated-svg-properties-expected.txt:
  • platform/mac/svg/custom/dasharrayOrigin-expected.txt:
  • platform/mac/svg/custom/focus-ring-expected.txt:
  • platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt:
  • platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt:
  • platform/mac/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/mac/svg/custom/invalid-css-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-all-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-preserveAspectRatio-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-transform-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-viewBox-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-viewBox-transform-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-viewTarget-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-zoomAndPan-expected.txt:
  • platform/mac/svg/custom/linking-uri-01-b-expected.txt:
  • platform/mac/svg/custom/marker-opacity-expected.txt:
  • platform/mac/svg/custom/mask-colorspace-expected.txt:
  • platform/mac/svg/custom/mask-on-multiple-objects-expected.txt:
  • platform/mac/svg/custom/mouse-move-on-svg-container-expected.txt:
  • platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
  • platform/mac/svg/custom/mouse-move-on-svg-root-expected.txt:
  • platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
  • platform/mac/svg/custom/non-circular-marker-reference-expected.txt:
  • platform/mac/svg/custom/object-sizing-expected.txt:
  • platform/mac/svg/custom/object-sizing-explicit-height-expected.txt:
  • platform/mac/svg/custom/object-sizing-explicit-width-expected.txt:
  • platform/mac/svg/custom/object-sizing-explicit-width-height-expected.txt:
  • platform/mac/svg/custom/object-sizing-no-width-height-expected.txt:
  • platform/mac/svg/custom/path-zero-strokewidth-expected.txt:
  • platform/mac/svg/custom/pattern-incorrect-tiling-expected.txt:
  • platform/mac/svg/custom/pattern-no-pixelation-expected.txt:
  • platform/mac/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.txt:
  • platform/mac/svg/custom/pattern-rotate-expected.txt:
  • platform/mac/svg/custom/relative-sized-content-with-resources-expected.txt:
  • platform/mac/svg/custom/shapes-supporting-markers-expected.txt:
  • platform/mac/svg/custom/stroked-pattern-expected.txt:
  • platform/mac/svg/custom/transform-with-shadow-and-gradient-expected.txt:
  • platform/mac/svg/custom/use-css-events-expected.txt:
  • platform/mac/svg/custom/use-detach-expected.txt:
  • platform/mac/svg/custom/use-elementInstance-methods-expected.txt:
  • platform/mac/svg/custom/use-instanceRoot-modifications-expected.txt:
  • platform/mac/svg/custom/use-modify-container-in-target-expected.txt:
  • platform/mac/svg/custom/use-modify-target-container-expected.txt:
  • platform/mac/svg/custom/use-on-g-containing-use-expected.txt:
  • platform/mac/svg/custom/use-on-g-expected.txt:
  • platform/mac/svg/custom/use-on-use-expected.txt:
  • platform/mac/svg/custom/use-transform-expected.txt:
  • platform/mac/svg/custom/width-full-percentage-expected.txt:
  • platform/mac/svg/filters/feDropShadow-expected.txt:
  • platform/mac/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.txt:
  • platform/mac/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.txt:
  • platform/mac/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.txt:
  • platform/mac/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.txt:
  • platform/mac/svg/filters/feImage-late-indirect-update-expected.txt:
  • platform/mac/svg/hixie/cascade/001-broken-expected.txt:
  • platform/mac/svg/hixie/cascade/002-expected.txt:
  • platform/mac/svg/hixie/error/001-expected.txt:
  • platform/mac/svg/hixie/error/003-expected.txt:
  • platform/mac/svg/hixie/error/017-expected.txt:
  • platform/mac/svg/hixie/mixed/003-expected.txt:
  • platform/mac/svg/hixie/mixed/004-expected.txt:
  • platform/mac/svg/hixie/mixed/005-expected.txt:
  • platform/mac/svg/hixie/mixed/006-expected.txt:
  • platform/mac/svg/hixie/mixed/008-expected.txt:
  • platform/mac/svg/hixie/mixed/011-expected.txt:
  • platform/mac/svg/hixie/perf/001-expected.txt:
  • platform/mac/svg/hixie/perf/002-expected.txt:
  • platform/mac/svg/hixie/perf/007-expected.txt:
  • platform/mac/svg/hixie/rendering-model/001-expected.txt:
  • platform/mac/svg/hixie/rendering-model/002-expected.txt:
  • platform/mac/svg/hixie/shapes/path/001-expected.txt:
  • platform/mac/svg/hixie/transform/001-expected.txt:
  • platform/mac/svg/in-html/circle-expected.txt:
  • platform/mac/svg/stroke/zero-length-arc-linecaps-rendering-expected.txt:
  • platform/mac/svg/stroke/zero-length-path-linecap-rendering-expected.txt:
  • platform/mac/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt:
  • platform/mac/svg/text/small-fonts-3-expected.txt:
  • platform/mac/svg/text/text-align-01-b-expected.txt:
  • platform/mac/svg/text/text-align-05-b-expected.txt:
  • platform/mac/svg/text/text-fill-opacity-expected.txt:
  • platform/mac/svg/transforms/svg-css-transforms-clip-path-expected.txt:
  • platform/mac/svg/wicd/rightsizing-grid-expected.txt:
  • platform/mac/svg/wicd/test-rightsizing-b-expected.txt:
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
  • platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • svg/clip-path/clip-in-mask-objectBoundingBox-expected.txt:
  • svg/clip-path/clip-in-mask-userSpaceOnUse-expected.txt:
  • svg/clip-path/clip-path-childs-clipped-expected.txt:
  • svg/clip-path/clip-path-clipped-evenodd-twice-expected.txt:
  • svg/clip-path/clip-path-clipped-expected.txt:
  • svg/clip-path/clip-path-clipped-nonzero-expected.txt:
  • svg/clip-path/clip-path-css-transform-1-expected.txt:
  • svg/clip-path/clip-path-css-transform-2-expected.txt:
  • svg/clip-path/clip-path-objectBoundingBox-expected.txt:
  • svg/clip-path/clip-path-on-clipped-use-expected.txt:
  • svg/clip-path/clip-path-on-g-and-child-expected.txt:
  • svg/clip-path/clip-path-on-g-expected.txt:
  • svg/clip-path/clip-path-on-svg-and-child-expected.txt:
  • svg/clip-path/clip-path-on-svg-expected.txt:
  • svg/clip-path/clip-path-transform-2-expected.txt:
  • svg/clip-path/clip-path-use-as-child-expected.txt:
  • svg/css/circle-in-mask-with-shadow-expected.txt:
  • svg/css/mask-with-shadow-expected.txt:
  • svg/custom/absolute-root-position-masking-expected.txt:
  • svg/custom/fill-opacity-update-expected.txt:
  • svg/custom/gradient-stroke-width-expected.txt:
  • svg/custom/js-late-marker-and-object-creation-expected.txt:
  • svg/custom/js-late-marker-creation-expected.txt:
  • svg/custom/js-update-bounce-expected.txt:
  • svg/custom/marker-changes-expected.txt:
  • svg/custom/marker-child-changes-css-expected.txt:
  • svg/custom/marker-child-changes-expected.txt:
  • svg/custom/marker-strokeWidth-changes-expected.txt:
  • svg/custom/marker-viewBox-changes-expected.txt:
  • svg/custom/object-sizing-no-width-height-change-content-box-size-expected.txt:
  • svg/custom/pattern-scaled-pattern-space-expected.txt:
  • svg/custom/resource-invalidate-on-target-update-expected.txt:
  • svg/custom/stroke-opacity-update-expected.txt:
  • svg/custom/use-setAttribute-crash-expected.txt:
  • svg/custom/viewBox-hit-expected.txt:
  • svg/filters/feImage-reference-svg-primitive-expected.txt:
  • svg/filters/filter-clip-expected.txt:
  • svg/filters/invalidate-on-child-layout-expected.txt:
  • svg/hittest/svg-ellipse-expected.txt: Added.
  • svg/hittest/svg-ellipse-non-scale-stroke-expected.txt: Added.
  • svg/hittest/svg-ellipse-non-scale-stroke.xhtml: Added.
  • svg/hittest/svg-ellipse.xhtml: Added.
  • svg/hixie/links/001-expected.txt:
08:32 Changeset [112666] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, update expectations for XP.

  • platform/chromium/test_expectations.txt:
07:51 Changeset [112665] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, more expectations for BUGWK82505.

  • platform/chromium/test_expectations.txt:
07:04 Changeset [112664] by commit-queue@webkit.org
  • 15 edits in trunk

Add a "preview" state to Page Visibility API implementation
https://bugs.webkit.org/show_bug.cgi?id=81355

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2012-03-30
Reviewed by Adam Barth.

Updating the Page Visibility API implementation to the current spec version.

Source/WebCore:

This change is covered by fast/events/page-visibility-transition-test.html,
so no new tests needed.

  • page/PageVisibilityState.cpp:

(WebCore::pageVisibilityStateString):

  • page/PageVisibilityState.h:

Source/WebKit/chromium:

  • public/WebPageVisibilityState.h:
  • src/AssertMatchingEnums.cpp:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setVisibilityState):

Source/WebKit/efl:

  • WebCoreSupport/AssertMatchingEnums.cpp:
  • ewk/ewk_view.h:

Tools:

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::setPageVisibility):

LayoutTests:

  • fast/events/page-visibility-transition-test-expected.txt:
  • fast/events/page-visibility-transition-test.html:
06:36 Changeset [112663] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, updated fast/frames/valid.html expectation for LEOPARD.

  • platform/chromium/test_expectations.txt:
06:35 Changeset [112662] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Skip another asserting test on debug build
https://bugs.webkit.org/show_bug.cgi?id=82052

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-03-30
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped: Skip asserting test.
06:31 Changeset [112661] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Regression] Execution line is not revealed after pretty print.
https://bugs.webkit.org/show_bug.cgi?id=82727

Reviewed by Pavel Feldman.

This patch makes JavaScriptSourceFrame reveal execution line after pretty print.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.setExecutionLine):

06:24 Changeset [112660] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: preload field values into local variables for better heap profiler performance
https://bugs.webkit.org/show_bug.cgi?id=82703

Reading from object fields takes a noticable time when the only other thing you do
is just manipulating on big(several million elements) Uint32Array array cells.

Reviewed by Pavel Feldman.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype._createContainmentEdgesArray):
(WebInspector.HeapSnapshot.prototype._buildRetainers):
(WebInspector.HeapSnapshot.prototype._bfs):

06:17 Changeset [112659] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r112489.
http://trac.webkit.org/changeset/112489
https://bugs.webkit.org/show_bug.cgi?id=82725

Tentatively introduces a lot of webfont-related test flakiness
on Snow Leopard (Requested by apavlov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-30

  • css/CSSSegmentedFontFace.cpp:

(WebCore::CSSSegmentedFontFace::getFontData):

06:15 Changeset [112658] by keishi@webkit.org
  • 53 edits in trunk

Change ENABLE_INPUT_COLOR to ENABLE_INPUT_TYPE_COLOR and enable it for chromium
https://bugs.webkit.org/show_bug.cgi?id=80972

Reviewed by Kent Tamura.

.:

  • Source/cmake/OptionsBlackBerry.cmake:
  • configure.ac:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • WebCore.exp.in:
  • css/html.css:
  • html/ColorInputType.cpp:
  • html/ColorInputType.h:
  • html/HTMLInputElement.cpp:

(WebCore):

  • html/HTMLInputElement.h:

(HTMLInputElement):

  • html/InputType.cpp:

(WebCore::createInputTypeFactoryMap):
(WebCore):
(InputTypeNames):

  • html/InputType.h:

(InputType):
(InputTypeNames):

  • loader/EmptyClients.h:

(EmptyChromeClient):

  • page/Chrome.cpp:

(WebCore):

  • page/Chrome.h:

(WebCore):
(Chrome):

  • page/ChromeClient.h:

(WebCore):
(ChromeClient):

  • platform/ColorChooser.h:
  • platform/ColorChooserClient.h:
  • testing/InternalSettings.cpp:
  • testing/Internals.cpp:

(WebCore):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit/blackberry:

  • WebCoreSupport/AboutDataEnableFeatures.in:
  • WebCoreSupport/ChromeClientBlackBerry.h:

(ChromeClientBlackBerry):

  • WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::isColorInputField):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::convertInputType):

Source/WebKit/chromium:

  • features.gypi:
  • src/ChromeClientImpl.cpp:

(WebKit):

  • src/ChromeClientImpl.h:

(WebCore):
(ChromeClientImpl):

  • src/ColorChooserProxy.cpp:
  • src/ColorChooserProxy.h:
  • src/WebColorChooserClientImpl.cpp:
  • src/WebColorChooserClientImpl.h:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/build-webkit:
  • qmake/mkspecs/features/features.prf:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

  • platform/efl/Skipped:
  • platform/qt/Skipped:
06:12 Changeset [112657] by charles.wei@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] EventLoop::platformInit() obsolete.
https://bugs.webkit.org/show_bug.cgi?id=82709

Reviewed by Rob Buis.

No new tests, build fix for BlackBerry porting.

  • platform/blackberry/EventLoopBlackBerry.cpp:
06:10 Changeset [112656] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: ScriptsNavigator should open scripts with single click (not double click).
https://bugs.webkit.org/show_bug.cgi?id=82723

Reviewed by Pavel Feldman.

This patch makes ScriptsNavigator open scripts with single click.

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.NavigatorScriptTreeElement.prototype.onattach):
(WebInspector.NavigatorScriptTreeElement.prototype._onclick):

05:50 Changeset [112655] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, update expectations.

  • platform/chromium/test_expectations.txt:
05:27 Changeset [112654] by charles.wei@torchmobile.com.cn
  • 3 edits in trunk

[BlackBerry] Add more ENABLERS to cmakeconfig.h.cmake
https://bugs.webkit.org/show_bug.cgi?id=82594

Reviewed by Rob Buis.

Upstreaming feature enablers in cmakeconfig.h.cmake for BlackBerry porting,
and clean up obsolete MACROs in OptionsBlackBerry.cmake.

  • Source/cmake/OptionsBlackBerry.cmake:
  • Source/cmakeconfig.h.cmake:
04:54 Changeset [112653] by commit-queue@webkit.org
  • 14 edits in trunk/Source/WebCore

IDLParser.pm should be able to parse sequence<T> as method argument.
https://bugs.webkit.org/show_bug.cgi?id=82599

Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-03-30
Reviewed by Kentaro Hara.

With this patch IDL parser should support sequence<T> as method argument.
Current behaviour is argument name is not parsed hence shows empty spaces instead.

Tests: bindings/scripts/test/TestObj.idl

  • bindings/scripts/CodeGeneratorCPP.pm:

(SkipFunction): Skip functions for specific type.
(SkipAttribute): Skip functions for specific type.
(AddIncludesForType): Skip header for sequence<T> type.
(GenerateHeader): Skip header and declaration for sequence<T> type.
(GenerateImplementation): Skip header and implementation for sequence<T> type.

  • bindings/scripts/CodeGeneratorGObject.pm:

(SkipFunction): Skip functions for sequence<T> type.

  • bindings/scripts/CodeGeneratorObjC.pm:

(SkipFunction): Skip functions for specific type.
(SkipAttribute): Skip functions for specific type.
(AddForwardDeclarationsForType): Skip header for sequence<T> type.
(AddIncludesForType): Skip header for sequence<T> type.
(GenerateHeader):Skip header and declaration for sequence<T> type.
(GenerateImplementation): Skip header and implementation for sequence<T> type.

  • bindings/scripts/CodeGeneratorV8.pm:

(CreateCustomSignature): Add appropriate headers.

  • bindings/scripts/IDLStructure.pm: Add support to parse sequence<T>.
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp: Modified results from run-binding-tests.

(WebDOMTestObj::objMethodWithArgs):

  • bindings/scripts/test/CPP/WebDOMTestObj.h: Ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.

(webkit_dom_test_obj_obj_method_with_args):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
  • bindings/scripts/test/JS/JSTestObj.cpp: Ditto.

(WebCore::jsTestObjPrototypeFunctionMethodWithSequenceArg):

  • bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.

(-[DOMTestObj objMethodWithArgs:strArg:objArg:]):

  • bindings/scripts/test/V8/V8TestObj.cpp: Ditto.

(WebCore::TestObjInternal::methodWithSequenceArgCallback):
(WebCore::ConfigureV8TestObjTemplate):

04:36 Changeset [112652] by pfeldman@chromium.org
  • 11 edits
    2 adds in trunk

Web Inspector: editing resets line-ending of the whole file
https://bugs.webkit.org/show_bug.cgi?id=82708

Reviewed by Yury Semikhatsky.

Source/WebCore:

This change splits TextEditorModel's setText into setText (for initialization) and
editRange (for editing). Distinguishing between the two allowed properly detecting
the preferred line endings.

Test: inspector/editor/text-editor-line-breaks.html

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.afterTextChanged):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.setContent):

  • inspector/front-end/TextEditorModel.js:

(WebInspector.TextEditorCommand):
(WebInspector.TextEditorModel):
(WebInspector.TextEditorModel.endsWithBracketRegex.):

  • inspector/front-end/TextViewer.js:

(WebInspector.TextViewer.prototype._textChanged):
(WebInspector.TextEditorMainPanel.prototype._unindentLines.get var):
(WebInspector.TextEditorMainPanel.prototype._unindentLines):
(WebInspector.TextEditorMainPanel.prototype.handleEnterKey.get var):
(WebInspector.TextEditorMainPanel.prototype.handleEnterKey):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
(WebInspector.TextEditorMainPanel.prototype._editRange):

LayoutTests:

  • inspector/editor/highlighter-basics.html:
  • inspector/editor/highlighter-long-line.html:
  • inspector/editor/highlighter-paste-in-comment.html:
  • inspector/editor/indentation.html:
  • inspector/editor/text-editor-line-breaks-expected.txt: Added.
  • inspector/editor/text-editor-line-breaks.html: Added.
  • inspector/editor/text-editor-model.html:
04:00 Changeset [112651] by kkristof@inf.u-szeged.hu
  • 21 edits in trunk

[Qt] Build fix by renameing QtDeclarative to QtQml in header calls.
https://bugs.webkit.org/show_bug.cgi?id=82195

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-03-29
Reviewed by Simon Hausmann.

Source/WebKit/qt:

  • declarative/experimental/plugin.cpp:
  • declarative/plugin.cpp:

(WebKitQmlPlugin::initializeEngine):

Source/WebKit2:

  • UIProcess/API/qt/qquicknetworkreply_p.h:
  • UIProcess/API/qt/qquicknetworkrequest_p.h:
  • UIProcess/API/qt/qquickwebview.cpp:
  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qwebiconimageprovider_p.h:
  • UIProcess/API/qt/qwebnavigationhistory.cpp:
  • UIProcess/API/qt/qwebnavigationhistory_p.h:
  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
  • UIProcess/qt/QtDialogRunner.cpp:

(QtDialogRunner::initForAlert):
(QtDialogRunner::initForConfirm):
(QtDialogRunner::initForPrompt):
(QtDialogRunner::initForAuthentication):
(QtDialogRunner::initForProxyAuthentication):
(QtDialogRunner::initForCertificateVerification):
(QtDialogRunner::initForFilePicker):
(QtDialogRunner::initForDatabaseQuotaDialog):
(QtDialogRunner::createDialog):

  • UIProcess/qt/QtFlickProvider.cpp:
  • UIProcess/qt/QtFlickProvider.h:

(QtFlickProvider):

  • UIProcess/qt/WebPopupMenuProxyQt.cpp:

(WebKit::WebPopupMenuProxyQt::createItem):
(WebKit::WebPopupMenuProxyQt::createContext):

Tools:

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::updateVisualMockTouchPoints):

  • MiniBrowser/qt/main.cpp:
  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::WrapperWindow::handleStatusChanged):

  • qmake/mkspecs/features/unix/default_post.prf:
03:14 Changeset [112650] by vsevik@chromium.org
  • 4 edits
    1 move in trunk

Web Inspector: Take IndexedDB support out of experiments.
https://bugs.webkit.org/show_bug.cgi?id=82635

Reviewed by Pavel Feldman.

Source/WebCore:

This patch takes inspector IndexedDB support out of experiments and enables tests.

Test: http/tests/inspector/indexeddb/resources-panel.html

  • inspector/front-end/ResourcesPanel.js:
  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

LayoutTests:

  • http/tests/inspector/indexeddb/resources-panel.html: Renamed from LayoutTests/http/tests/inspector/indexeddb/resources-panel.html_disabled.
03:06 Changeset [112649] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, more CRASH expectations for BUGWK82505 added.

  • platform/chromium/test_expectations.txt:
03:03 Changeset [112648] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix after r112482.

  • platform/network/cf/FormDataStreamCFNet.h: Added missing forward decleration.
02:46 Changeset [112647] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] Implement LayoutTestController::setMinimumTimerInterval
https://bugs.webkit.org/show_bug.cgi?id=81220

Tools:

Add missing implementation setMinimumTimerInterval to EFL's
LayoutTestController so that we can unskip related tests from the skip list.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-30
Reviewed by Philippe Normand.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setMinimumTimerInterval):

LayoutTests:

Unskip tests connected with setMinimumTimerInterval.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-30
Reviewed by Philippe Normand.

  • platform/efl/Skipped:
00:45 Changeset [112646] by philn@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] WebAudio channelSize issue
https://bugs.webkit.org/show_bug.cgi?id=81905

Reviewed by Martin Robinson.

  • platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::AudioFileReader::handleBuffer): Calculate the audio
buffer duration and frames number from the buffer and caps instead
of relying on the buffer offets that are not always correctly set
depending on the audio file format.

00:43 Changeset [112645] by philn@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r112582 and r112391.

  • platform/gtk/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt:
  • platform/gtk/svg/custom/preserve-aspect-ratio-syntax-expected.txt:

03/29/12:

23:29 April 2012 Meeting edited by rniwa@webkit.org
(diff)
23:28 April 2012 Meeting edited by rniwa@webkit.org
(diff)
22:07 Changeset [112644] by achicu@adobe.com
  • 10 edits
    6 adds in trunk

[CSS Filters] Trigger a repaint on elements with changed filter
https://bugs.webkit.org/show_bug.cgi?id=82521

Reviewed by Dean Jackson.

Source/WebCore:

I've added ContextSensitivePropertyFilter and changed RenderStyle::diff to use it when
the filter property is changed. In RenderObject::adjustStyleDifference the appropriate StyleDifferenceRepaintLayer
or StyleDifferenceRecompositeLayer is used depending on whether the layer is painting filters in software or in hardware
(composited).

Tests: css3/filters/filter-change-repaint-composited.html

css3/filters/filter-change-repaint.html

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::createFilterOperations): None was treated as an invalid value.

  • platform/graphics/ca/mac/PlatformCALayerMac.mm: Shadows were remaining behind. Fixed that.

(PlatformCALayer::setFilters):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::styleWillChange): Repaint the layer when there is a layout change and a filter change.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::styleChanged): Making sure that the backing store is repainted when filters fallback to hardware.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::adjustStyleDifference):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyleConstants.h:

LayoutTests:

Repaint was not triggered when the filter property was changed. I've added two
tests, one for software and one for composited mode. Both tests are triggering
all the possible scenarios of changing the filter property.

  • css3/filters/filter-change-repaint-composited-expected.png: Added.
  • css3/filters/filter-change-repaint-composited-expected.txt: Added.
  • css3/filters/filter-change-repaint-composited.html: Added.
  • css3/filters/filter-change-repaint-expected.png: Added.
  • css3/filters/filter-change-repaint-expected.txt: Added.
  • css3/filters/filter-change-repaint.html: Added.
  • platform/chromium/test_expectations.txt: Disabled the new tests on Chromium. They need rebaselining.
21:43 Changeset [112643] by bdakin@apple.com
  • 4 edits in branches/safari-534.56-branch/Source/WebCore

<rdar://problem/11008998> Branch: Shadow inside text field is blurry/blocky in
HiDPI

Reviewed by Dan Bernstein.

This patch merges the following changes to the branch:
http://trac.webkit.org/changeset/97032
http://trac.webkit.org/changeset/98520

This patch also adds branch-specific code that makes it so the regression tracked
by <rdar://problem/11115221> only affects the branch in HiDPI mode.

Essentially, this is a workaround for <rdar://problem/11150452>. With this
workaround, when the deviceScaleFactor is 1, we have an old-school gradient bezel
in text fields whether they are styled or not. This is good and matches shipping
Safari. When the deviceScaleFactor is greater than 1, text fields will have newer,
AppKit-matching gradients that look much more appropriate at the higher
resolutions. However, if the text field is styled in any way, we'll revert to the
old-school bezel, which doesn't look great in HiDPI, but it looks better than the
CSS border, which is the only alternative until 11150452 is resolved.

This is the merging of the changes listed above.

  • platform/mac/ThemeMac.mm:

(WebCore::ThemeMac::ensuredView):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSliderThumb):

isControlStyled() should treat text fields like it used to in order to avoid the
regression tracked by 11115221.

  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::isControlStyled):

Use the old gradient always unless we are an unstyled text field in HiDPI.
(WebCore::RenderThemeMac::paintTextField):
(WebCore::RenderThemeMac::textField):

20:44 Changeset [112642] by commit-queue@webkit.org
  • 7 edits
    3 adds in trunk/Source/WebCore

Vertical flow support for OpenType fonts with the least platform dependencies
https://bugs.webkit.org/show_bug.cgi?id=81326

Patch by Koji Ishii <kojiishi@gmail.com> on 2012-03-29
Reviewed by Dan Bernstein.

This patch introduces a new class OpenTypeVerticalData to read
vertical font metrics from OpenType fonts.

Currently, WebKit relies on platform APIs to do the work. However,
some platforms such as Windows lack support for all the capabilities
WebKit requires for vertical flow and the text-orientation property
to work correctly. Reading OpenType tables directly also gives
benefits in consistent behavior among the WebKit platforms.

This patch is for any platforms that want to parse OpenType tables
directly, but it's currently included only in CGWin and isn't on any
code path even on CGWin yet. Caller's side change for CGWin and
support for other platforms will be in separate bugs.

No new tests are required. No behavior changes.

  • WebCore.vcproj/WebCore.vcproj: Added OpenTypeTypes.h and OpenTypeVerticalData.h/cpp.
  • platform/SharedBuffer.cpp: Add create(size_t)

(WebCore::SharedBuffer::SharedBuffer):
(WebCore):

  • platform/SharedBuffer.h: Add create(size_t)

(WebCore::SharedBuffer::create):
(SharedBuffer):

  • platform/graphics/FontPlatformData.h: Added openTypeTable().

(WebCore):
(FontPlatformData):

  • platform/graphics/SimpleFontData.h: Added sizePerUnit().

(WebCore::SimpleFontData::sizePerUnit): size() / unitsPerEm() for less multiplication.

  • platform/graphics/opentype/OpenTypeTypes.h: Added OpenType basic type definitions.

(OpenType):
(WebCore::OpenType::BigEndianShort::operator short):
(WebCore::OpenType::BigEndianShort::BigEndianShort):
(BigEndianShort):
(WebCore::OpenType::BigEndianUShort::operator unsigned short):
(WebCore::OpenType::BigEndianUShort::BigEndianUShort):
(BigEndianUShort):
(WebCore::OpenType::BigEndianLong::operator int):
(WebCore::OpenType::BigEndianLong::BigEndianLong):
(BigEndianLong):
(WebCore::OpenType::BigEndianULong::operator unsigned):
(WebCore::OpenType::BigEndianULong::BigEndianULong):
(BigEndianULong):

  • platform/graphics/opentype/OpenTypeVerticalData.cpp: Added.

(OpenType):
(HheaTable):
(VheaTable):
(Entry):
(VORGTable):
(VertOriginYMetrics):
(WebCore::OpenType::VORGTable::requiredSize):
(WebCore):
(WebCore::validatedPtr):
(WebCore::OpenTypeVerticalData::OpenTypeVerticalData):
(WebCore::OpenTypeVerticalData::advanceHeight): Advance height for a glyph.
(WebCore::OpenTypeVerticalData::getVerticalTranslationsForGlyphs): Vertical origin.

  • platform/graphics/opentype/OpenTypeVerticalData.h: Added.

(WebCore):
(OpenTypeVerticalData): A new class to handle vertical flow data in OpenType.
(WebCore::OpenTypeVerticalData::isOpenType):
(WebCore::OpenTypeVerticalData::hasVerticalMetrics):
(WebCore::OpenTypeVerticalData::hasVORG):

  • platform/graphics/win/FontPlatformDataWin.cpp:

(WebCore):
(WebCore::FontPlatformData::openTypeTable): Implemented openTypeTable() for Win32.

20:31 Changeset [112641] by leo.yang@torchmobile.com.cn
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Sync up PlatformMouseEvent
https://bugs.webkit.org/show_bug.cgi?id=82567

Reviewed by Rob Buis.

This patch is adding blackberry specific members to PlatformMouseEvent.
Also re-base PlatformMouseEventBlackBerry to adapt to the re-factor
of PlatformMouseEvent.

  • platform/PlatformMouseEvent.h:

(PlatformMouseEvent): BlackBerry specific constructor.
(WebCore::PlatformMouseEvent::inputMethod): Input source of mouse event
for blackberry platform.

  • platform/blackberry/PlatformMouseEventBlackBerry.cpp:

(WebCore::PlatformMouseEvent::PlatformMouseEvent): Re-base the constructor
to adapt the re-factor of PlatformMouseEvent.

20:20 April 2012 Meeting edited by dtharp@codeaurora.org
(diff)
20:15 BuildingQtOnLinux edited by gram@company100.net
(diff)
20:13 BuildingQtOnLinux edited by gram@company100.net
(diff)
20:04 Changeset [112640] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Turn on STORE_FONT_CUSTOM_PLATFORM_DATA in CachedFont.cpp
https://bugs.webkit.org/show_bug.cgi?id=82573

Reviewed by Rob Buis.

Tests: covered by existing tests.

  • loader/cache/CachedFont.cpp:
20:02 Changeset [112639] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Attempt to fix the component build
https://bugs.webkit.org/show_bug.cgi?id=82676

Reviewed by Dirk Pranke.

Now that we're implementing some of the WEBKIT_EXPORT symbols in
WebCore/platform/chromium/support, we need to tell the build system
that we want to actually export these symbols.

  • WebCore.gyp/WebCore.gyp:
19:25 Changeset [112638] by inferno@chromium.org
  • 1 edit in branches/chromium/1084/Source/WebKit/chromium/src/WorkerFileSystemCallbacksBridge.cpp

Merge 112576 - [Chromium] WorkerFileSystemContextObserver can reference a deleted WorkerFileSystemCallbacksBridge.
BUG=120007
Review URL: https://chromiumcodereview.appspot.com/9939006

19:23 Changeset [112637] by inferno@chromium.org
  • 1 edit in branches/chromium/1084/Source/WebCore/rendering/RenderFullScreen.cpp

Merge 112596 - Heap-use-after-free in WebCore::InlineFlowBox::deleteLine due to fullscreen issues.

BUG=118853
Review URL: https://chromiumcodereview.appspot.com/9962002

19:21 Changeset [112636] by inferno@chromium.org
  • 4 edits in branches/chromium/1084/Source/WebCore

Merge 112623 - Crash in GenericEventQueue::~GenericEventQueue.

BUG=119281
Review URL: https://chromiumcodereview.appspot.com/9937009

18:57 Changeset [112635] by mitz@apple.com
  • 3 edits in trunk/Tools

Removed “Intel” from the Lion builders’ names.

Rubber-stamped by Mark Rowe.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:

(LeaksViewer._displayURLPrompt):

18:37 Changeset [112634] by abarth@webkit.org
  • 5 edits
    9 moves in trunk/Source

Unreviewed, rolling out r112572.
http://trac.webkit.org/changeset/112572
https://bugs.webkit.org/show_bug.cgi?id=82582

Does not compile in Windows component build

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:

Source/WebKit/chromium:

  • WebKit.gyp:
  • src/WebData.cpp: Renamed from Source/WebCore/platform/chromium/support/WebData.cpp.

(WebKit):
(WebKit::WebData::reset):
(WebKit::WebData::assign):
(WebKit::WebData::size):
(WebKit::WebData::data):
(WebKit::WebData::WebData):
(WebKit::WebData::operator=):
(WebKit::WebData::operator PassRefPtr<SharedBuffer>):

  • src/WebHTTPBody.cpp: Renamed from Source/WebCore/platform/chromium/support/WebHTTPBody.cpp.

(WebKit):
(WebKit::WebHTTPBody::initialize):
(WebKit::WebHTTPBody::reset):
(WebKit::WebHTTPBody::assign):
(WebKit::WebHTTPBody::elementCount):
(WebKit::WebHTTPBody::elementAt):
(WebKit::WebHTTPBody::appendData):
(WebKit::WebHTTPBody::appendFile):
(WebKit::WebHTTPBody::appendFileRange):
(WebKit::WebHTTPBody::appendBlob):
(WebKit::WebHTTPBody::identifier):
(WebKit::WebHTTPBody::setIdentifier):
(WebKit::WebHTTPBody::containsPasswordData):
(WebKit::WebHTTPBody::setContainsPasswordData):
(WebKit::WebHTTPBody::WebHTTPBody):
(WebKit::WebHTTPBody::operator=):
(WebKit::WebHTTPBody::operator PassRefPtr<FormData>):
(WebKit::WebHTTPBody::ensureMutable):

  • src/WebHTTPLoadInfo.cpp: Renamed from Source/WebCore/platform/chromium/support/WebHTTPLoadInfo.cpp.

(WebKit):
(WebKit::WebHTTPLoadInfo::initialize):
(WebKit::WebHTTPLoadInfo::reset):
(WebKit::WebHTTPLoadInfo::assign):
(WebKit::WebHTTPLoadInfo::WebHTTPLoadInfo):
(WebKit::WebHTTPLoadInfo::operator WTF::PassRefPtr<WebCore::ResourceLoadInfo>):
(WebKit::WebHTTPLoadInfo::httpStatusCode):
(WebKit::WebHTTPLoadInfo::setHTTPStatusCode):
(WebKit::WebHTTPLoadInfo::httpStatusText):
(WebKit::WebHTTPLoadInfo::setHTTPStatusText):
(WebKit::WebHTTPLoadInfo::encodedDataLength):
(WebKit::WebHTTPLoadInfo::setEncodedDataLength):
(WebKit::addHeader):
(WebKit::WebHTTPLoadInfo::addRequestHeader):
(WebKit::WebHTTPLoadInfo::addResponseHeader):
(WebKit::WebHTTPLoadInfo::requestHeadersText):
(WebKit::WebHTTPLoadInfo::setRequestHeadersText):
(WebKit::WebHTTPLoadInfo::responseHeadersText):
(WebKit::WebHTTPLoadInfo::setResponseHeadersText):

  • src/WebURL.cpp: Renamed from Source/WebCore/platform/chromium/support/WebURL.cpp.

(WebKit):
(WebKit::WebURL::WebURL):
(WebKit::WebURL::operator=):
(WebKit::WebURL::operator WebCore::KURL):

  • src/WebURLError.cpp: Renamed from Source/WebCore/platform/chromium/support/WebURLError.cpp.

(WebKit):
(WebKit::WebURLError::WebURLError):
(WebKit::WebURLError::operator=):
(WebKit::WebURLError::operator ResourceError):

  • src/WebURLRequest.cpp: Renamed from Source/WebCore/platform/chromium/support/WebURLRequest.cpp.

(WebURLRequestPrivateImpl):
(WebKit::WebURLRequestPrivateImpl::WebURLRequestPrivateImpl):
(WebKit::WebURLRequestPrivateImpl::dispose):
(WebKit::WebURLRequestPrivateImpl::~WebURLRequestPrivateImpl):
(WebKit):
(WebKit::WebURLRequest::initialize):
(WebKit::WebURLRequest::reset):
(WebKit::WebURLRequest::assign):
(WebKit::WebURLRequest::isNull):
(WebKit::WebURLRequest::url):
(WebKit::WebURLRequest::setURL):
(WebKit::WebURLRequest::firstPartyForCookies):
(WebKit::WebURLRequest::setFirstPartyForCookies):
(WebKit::WebURLRequest::allowCookies):
(WebKit::WebURLRequest::setAllowCookies):
(WebKit::WebURLRequest::allowStoredCredentials):
(WebKit::WebURLRequest::setAllowStoredCredentials):
(WebKit::WebURLRequest::cachePolicy):
(WebKit::WebURLRequest::setCachePolicy):
(WebKit::WebURLRequest::httpMethod):
(WebKit::WebURLRequest::setHTTPMethod):
(WebKit::WebURLRequest::httpHeaderField):
(WebKit::WebURLRequest::setHTTPHeaderField):
(WebKit::WebURLRequest::addHTTPHeaderField):
(WebKit::WebURLRequest::clearHTTPHeaderField):
(WebKit::WebURLRequest::visitHTTPHeaderFields):
(WebKit::WebURLRequest::httpBody):
(WebKit::WebURLRequest::setHTTPBody):
(WebKit::WebURLRequest::reportUploadProgress):
(WebKit::WebURLRequest::setReportUploadProgress):
(WebKit::WebURLRequest::reportLoadTiming):
(WebKit::WebURLRequest::setReportRawHeaders):
(WebKit::WebURLRequest::reportRawHeaders):
(WebKit::WebURLRequest::setReportLoadTiming):
(WebKit::WebURLRequest::targetType):
(WebKit::WebURLRequest::hasUserGesture):
(WebKit::WebURLRequest::setHasUserGesture):
(WebKit::WebURLRequest::setTargetType):
(WebKit::WebURLRequest::requestorID):
(WebKit::WebURLRequest::setRequestorID):
(WebKit::WebURLRequest::requestorProcessID):
(WebKit::WebURLRequest::setRequestorProcessID):
(WebKit::WebURLRequest::appCacheHostID):
(WebKit::WebURLRequest::setAppCacheHostID):
(WebKit::WebURLRequest::downloadToFile):
(WebKit::WebURLRequest::setDownloadToFile):
(WebKit::WebURLRequest::extraData):
(WebKit::WebURLRequest::setExtraData):
(WebKit::WebURLRequest::toMutableResourceRequest):
(WebKit::WebURLRequest::toResourceRequest):

  • src/WebURLRequestPrivate.h: Renamed from Source/WebCore/platform/chromium/support/WebURLRequestPrivate.h.

(WebKit):
(WebURLRequestPrivate):
(WebKit::WebURLRequestPrivate::WebURLRequestPrivate):

  • src/WebURLResponse.cpp: Renamed from Source/WebCore/platform/chromium/support/WebURLResponse.cpp.

(WebURLResponsePrivateImpl):
(WebKit::WebURLResponsePrivateImpl::WebURLResponsePrivateImpl):
(WebKit::WebURLResponsePrivateImpl::dispose):
(WebKit::WebURLResponsePrivateImpl::~WebURLResponsePrivateImpl):
(WebKit):
(WebKit::WebURLResponse::initialize):
(WebKit::WebURLResponse::reset):
(WebKit::WebURLResponse::assign):
(WebKit::WebURLResponse::isNull):
(WebKit::WebURLResponse::url):
(WebKit::WebURLResponse::setURL):
(WebKit::WebURLResponse::connectionID):
(WebKit::WebURLResponse::setConnectionID):
(WebKit::WebURLResponse::connectionReused):
(WebKit::WebURLResponse::setConnectionReused):
(WebKit::WebURLResponse::loadTiming):
(WebKit::WebURLResponse::setLoadTiming):
(WebKit::WebURLResponse::httpLoadInfo):
(WebKit::WebURLResponse::setHTTPLoadInfo):
(WebKit::WebURLResponse::responseTime):
(WebKit::WebURLResponse::setResponseTime):
(WebKit::WebURLResponse::mimeType):
(WebKit::WebURLResponse::setMIMEType):
(WebKit::WebURLResponse::expectedContentLength):
(WebKit::WebURLResponse::setExpectedContentLength):
(WebKit::WebURLResponse::textEncodingName):
(WebKit::WebURLResponse::setTextEncodingName):
(WebKit::WebURLResponse::suggestedFileName):
(WebKit::WebURLResponse::setSuggestedFileName):
(WebKit::WebURLResponse::httpStatusCode):
(WebKit::WebURLResponse::setHTTPStatusCode):
(WebKit::WebURLResponse::httpStatusText):
(WebKit::WebURLResponse::setHTTPStatusText):
(WebKit::WebURLResponse::httpHeaderField):
(WebKit::WebURLResponse::setHTTPHeaderField):
(WebKit::WebURLResponse::addHTTPHeaderField):
(WebKit::WebURLResponse::clearHTTPHeaderField):
(WebKit::WebURLResponse::visitHTTPHeaderFields):
(WebKit::WebURLResponse::lastModifiedDate):
(WebKit::WebURLResponse::setLastModifiedDate):
(WebKit::WebURLResponse::appCacheID):
(WebKit::WebURLResponse::setAppCacheID):
(WebKit::WebURLResponse::appCacheManifestURL):
(WebKit::WebURLResponse::setAppCacheManifestURL):
(WebKit::WebURLResponse::securityInfo):
(WebKit::WebURLResponse::setSecurityInfo):
(WebKit::WebURLResponse::toMutableResourceResponse):
(WebKit::WebURLResponse::toResourceResponse):
(WebKit::WebURLResponse::wasCached):
(WebKit::WebURLResponse::setWasCached):
(WebKit::WebURLResponse::wasFetchedViaSPDY):
(WebKit::WebURLResponse::setWasFetchedViaSPDY):
(WebKit::WebURLResponse::wasNpnNegotiated):
(WebKit::WebURLResponse::setWasNpnNegotiated):
(WebKit::WebURLResponse::wasAlternateProtocolAvailable):
(WebKit::WebURLResponse::setWasAlternateProtocolAvailable):
(WebKit::WebURLResponse::wasFetchedViaProxy):
(WebKit::WebURLResponse::setWasFetchedViaProxy):
(WebKit::WebURLResponse::isMultipartPayload):
(WebKit::WebURLResponse::setIsMultipartPayload):
(WebKit::WebURLResponse::downloadFilePath):
(WebKit::WebURLResponse::setDownloadFilePath):
(WebKit::WebURLResponse::remoteIPAddress):
(WebKit::WebURLResponse::setRemoteIPAddress):
(WebKit::WebURLResponse::remotePort):
(WebKit::WebURLResponse::setRemotePort):
(WebKit::WebURLResponse::extraData):
(WebKit::WebURLResponse::setExtraData):

  • src/WebURLResponsePrivate.h: Renamed from Source/WebCore/platform/chromium/support/WebURLResponsePrivate.h.

(WebKit):
(WebURLResponsePrivate):
(WebKit::WebURLResponsePrivate::WebURLResponsePrivate):

18:36 Changeset [112633] by abarth@webkit.org
  • 4 edits
    4 moves in trunk/Source

Unreviewed, rolling out r112579.
http://trac.webkit.org/changeset/112579
https://bugs.webkit.org/show_bug.cgi?id=82657

Does not compile in Windows component build

Source/WebCore:

  • WebCore.gypi:

Source/WebKit/chromium:

  • WebKit.gyp:
  • src/ResourceHandle.cpp: Renamed from Source/WebCore/platform/network/chromium/ResourceHandle.cpp.

(WebCore):
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
(WebCore::ResourceHandleInternal::start):
(WebCore::ResourceHandleInternal::cancel):
(WebCore::ResourceHandleInternal::setDefersLoading):
(WebCore::ResourceHandleInternal::allowStoredCredentials):
(WebCore::ResourceHandleInternal::willSendRequest):
(WebCore::ResourceHandleInternal::didSendData):
(WebCore::ResourceHandleInternal::didReceiveResponse):
(WebCore::ResourceHandleInternal::didDownloadData):
(WebCore::ResourceHandleInternal::didReceiveData):
(WebCore::ResourceHandleInternal::didReceiveCachedMetadata):
(WebCore::ResourceHandleInternal::didFinishLoading):
(WebCore::ResourceHandleInternal::didFail):
(WebCore::ResourceHandleInternal::FromResourceHandle):
(WebCore::ResourceHandle::ResourceHandle):
(WebCore::ResourceHandle::create):
(WebCore::ResourceHandle::firstRequest):
(WebCore::ResourceHandle::client):
(WebCore::ResourceHandle::setClient):
(WebCore::ResourceHandle::setDefersLoading):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::hasAuthenticationChallenge):
(WebCore::ResourceHandle::clearAuthentication):
(WebCore::ResourceHandle::cancel):
(WebCore::ResourceHandle::~ResourceHandle):
(WebCore::ResourceHandle::loadsBlocked):
(WebCore::ResourceHandle::loadResourceSynchronously):
(WebCore::ResourceHandle::willLoadFromCache):
(WebCore::ResourceHandle::cacheMetadata):

  • src/ResourceHandleInternal.h: Renamed from Source/WebCore/platform/network/chromium/ResourceHandleInternal.h.

(WebCore):
(ResourceHandleInternal):
(WebCore::ResourceHandleInternal::~ResourceHandleInternal):
(WebCore::ResourceHandleInternal::setOwner):
(WebCore::ResourceHandleInternal::request):
(WebCore::ResourceHandleInternal::client):
(WebCore::ResourceHandleInternal::setClient):
(WebCore::ResourceHandleInternal::loader):

  • src/WrappedResourceRequest.h: Renamed from Source/WebCore/platform/chromium/support/WrappedResourceRequest.h.

(WebKit):
(WrappedResourceRequest):
(WebKit::WrappedResourceRequest::~WrappedResourceRequest):
(WebKit::WrappedResourceRequest::WrappedResourceRequest):
(WebKit::WrappedResourceRequest::bind):
(Handle):
(WebKit::WrappedResourceRequest::Handle::dispose):

  • src/WrappedResourceResponse.h: Renamed from Source/WebCore/platform/chromium/support/WrappedResourceResponse.h.

(WebKit):
(WrappedResourceResponse):
(WebKit::WrappedResourceResponse::~WrappedResourceResponse):
(WebKit::WrappedResourceResponse::WrappedResourceResponse):
(WebKit::WrappedResourceResponse::bind):
(Handle):
(WebKit::WrappedResourceResponse::Handle::dispose):

18:34 Changeset [112632] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r112611.
http://trac.webkit.org/changeset/112611
https://bugs.webkit.org/show_bug.cgi?id=82676

Does not compile in Windows component build

  • WebCore.gyp/WebCore.gyp:
18:29 Changeset [112631] by cevans@google.com
  • 2 edits
    3 copies in branches/chromium/1025

Merge 112161
BUG=120189
Review URL: https://chromiumcodereview.appspot.com/9951003

18:22 Changeset [112630] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1025

Merge 112012
BUG=119525
Review URL: https://chromiumcodereview.appspot.com/9958002

18:17 Changeset [112629] by commit-queue@webkit.org
  • 12 edits in trunk

Update shape-inside/shape-outside CSS Exclusion properties
https://bugs.webkit.org/show_bug.cgi?id=82365

Patch by Bear Travis <betravis@adobe.com> on 2012-03-29
Reviewed by Ryosuke Niwa.

Source/WebCore:

Updating CSS property names for wrap-shape-inside and wrap-shape-outside
to shape-inside and shape-outside, per the current exclusions spec.
Renaming some parsing functions in CSSParser for clarity.
No new functionality.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseClipShape):
(WebCore::CSSParser::parseExclusionShapeRect):
(WebCore::CSSParser::parseExclusionShapeCircle):
(WebCore::CSSParser::parseExclusionShapeEllipse):
(WebCore::CSSParser::parseExclusionShapePolygon):
(WebCore::CSSParser::parseExclusionShape):

  • css/CSSParser.h:
  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

LayoutTests:

Renaming prefixed wrap-shape-inside and wrap-shape-outside
to prefixed shape-inside and shape-outside. Updating the
tests to reflect the change.

  • fast/exclusions/parsing-wrap-shape-inside-expected.txt:
  • fast/exclusions/parsing-wrap-shape-outside-expected.txt:
  • fast/exclusions/script-tests/parsing-wrap-shape-inside.js:

(testCSSText):
(testComputedStyle):
(testNotInherited):

  • fast/exclusions/script-tests/parsing-wrap-shape-outside.js:

(testCSSText):
(testComputedStyle):
(testNotInherited):

18:15 Changeset [112628] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Update paths in GYP files
https://bugs.webkit.org/show_bug.cgi?id=82663

Patch by Ryan Sleevi <rsleevi@chromium.org> on 2012-03-29
Reviewed by Adam Barth.

  • WebCore.gypi:

Remove PluginDataGtk.cpp following r112401

18:14 Changeset [112627] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1025

Merge 111912
BUG=119230
Review URL: https://chromiumcodereview.appspot.com/9933006

18:01 Changeset [112626] by cevans@google.com
  • 6 edits
    2 copies
    1 delete in branches/chromium/1025

Merge 111601
BUG=118009
Review URL: https://chromiumcodereview.appspot.com/9949002

17:44 Changeset [112625] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, expectations changes.

fast/block/lineboxcontain/glyphs.html and
fast/text/international/spaces-combined-in-vertical-text.html on
mac

  • platform/chromium/test_expectations.txt:
17:36 Changeset [112624] by mhahnenberg@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Refactor recompileAllJSFunctions() to be less expensive
https://bugs.webkit.org/show_bug.cgi?id=80330

Reviewed by Filip Pizlo.

This change is performance neutral on the JS benchmarks we track. It's mostly to improve page
load performance, which currently does at least a couple full GCs per navigation.

  • heap/Heap.cpp:

(JSC::Heap::discardAllCompiledCode): Rename recompileAllJSFunctions to discardAllCompiledCode
because the function doesn't actually recompile anything (and never did); it simply throws code
away for it to be recompiled later if we determine we should do so.
(JSC):
(JSC::Heap::collectAllGarbage):
(JSC::Heap::addFunctionExecutable): Adds a newly created FunctionExecutable to the Heap's list.
(JSC::Heap::removeFunctionExecutable): Removes the specified FunctionExecutable from the Heap's list.

  • heap/Heap.h:

(JSC):
(Heap):

  • runtime/Executable.cpp: Added next and prev fields to FunctionExecutables so that they can

be used in DoublyLinkedLists.
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::finalize): Removes the FunctionExecutable from the Heap's list.

  • runtime/Executable.h:

(FunctionExecutable):
(JSC::FunctionExecutable::create): Adds the FunctionExecutable to the Heap's list.

  • runtime/JSGlobalData.cpp: Remove recompileAllJSFunctions, as it's the Heap's job to own and manage

the list of FunctionExecutables.

  • runtime/JSGlobalData.h:

(JSGlobalData):

  • runtime/JSGlobalObject.cpp:

(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope): Use the new discardAllCompiledCode.

17:33 Changeset [112623] by inferno@chromium.org
  • 5 edits in trunk/Source/WebCore

Crash in GenericEventQueue::~GenericEventQueue.
https://bugs.webkit.org/show_bug.cgi?id=81976

Reviewed by Eric Carlson.

  • dom/GenericEventQueue.cpp:

(WebCore::GenericEventQueue::create):
(WebCore):
(WebCore::GenericEventQueue::GenericEventQueue):
(WebCore::GenericEventQueue::enqueueEvent):
(WebCore::GenericEventQueue::timerFired):

  • dom/GenericEventQueue.h:

(GenericEventQueue):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::scheduleEvent):
(WebCore::HTMLMediaElement::updateActiveTextTrackCues):
(WebCore::HTMLMediaElement::cancelPendingEventsAndCallbacks):
(WebCore::HTMLMediaElement::hasPendingActivity):

  • html/HTMLMediaElement.h:

(HTMLMediaElement):

17:31 Changeset [112622] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, expectations updates.

  • platform/chromium/test_expectations.txt:
17:29 Changeset [112621] by cevans@google.com
  • 5 edits
    2 copies in branches/chromium/1025

Merge 112119
BUG=118803
Review URL: https://chromiumcodereview.appspot.com/9933004

17:26 Changeset [112620] by simon.fraser@apple.com
  • 3 edits in trunk/LayoutTests

Move to the WK1 skipped list (which WK2 picks up). The
bug on the skipping is https://bugs.webkit.org/show_bug.cgi?id=82679.

  • platform/mac-wk2/Skipped:
  • platform/mac/Skipped:
17:25 Changeset [112619] by mihaip@chromium.org
  • 2 edits in trunk/Tools

[Chromium] Add sharded ChromiumOS debug bots to builders.js
https://bugs.webkit.org/show_bug.cgi?id=82639

Reviewed by Eric Seidel.

The bots were sharded by http://crrev.com/129613, update builders.js
to reflect this.

  • TestResultServer/static-dashboards/builders.js:
17:23 Changeset [112618] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/1025

Merge 110307
BUG=114960
Review URL: https://chromiumcodereview.appspot.com/9941003

17:21 Changeset [112617] by noam.rosenthal@nokia.com
  • 4 edits in trunk/Source/WebKit2

[Qt][WK2] Direct composited image assignment doesn't work
https://bugs.webkit.org/show_bug.cgi?id=82525

Reviewed by Kenneth Rohde Christiansen.

We don't need to check whether the image or contentsRect are updated,
since assignImageToLayer is a cheap operation after the LayerBackingStore
refactor.

  • UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::WebLayerTreeRenderer::setLayerChildren):
(WebKit::WebLayerTreeRenderer::setLayerState):
(WebKit::WebLayerTreeRenderer::renderNextFrame):

17:16 Changeset [112616] by simon.fraser@apple.com
  • 2 edits in trunk/LayoutTests

Skip three flaky storage tests.

  • platform/mac/Skipped:
17:16 Changeset [112615] by commit-queue@webkit.org
  • 2 edits in trunk

Add new chrome.webkit GPU bot to flakiness dashboard.
https://bugs.webkit.org/show_bug.cgi?id=82562

Patch by Dave Tu <dtu@chromium.org> on 2012-03-29
Reviewed by Ojan Vafai.

  • Tools/TestResultServer/static-dashboards/builders.js:
17:14 Changeset [112614] by jamesr@google.com
  • 13 edits
    1 copy in branches/chromium/1084/Source

Merge 112364 - [chromium] Transfer wheel fling via WebCompositorInputHandlerClient
https://bugs.webkit.org/show_bug.cgi?id=81740

Patch by James Robinson <jamesr@chromium.org> on 2012-03-27
Reviewed by Adrienne Walker.

Source/WebCore:

Adds the ability to construct an in-progress PlatformGestureAnimation.

  • platform/ActivePlatformGestureAnimation.cpp:

(WebCore::ActivePlatformGestureAnimation::create):
(WebCore):
(WebCore::ActivePlatformGestureAnimation::ActivePlatformGestureAnimation):

  • platform/ActivePlatformGestureAnimation.h:

(ActivePlatformGestureAnimation):

  • platform/TouchpadFlingPlatformGestureCurve.cpp:

(WebCore::TouchpadFlingPlatformGestureCurve::create):
(WebCore::TouchpadFlingPlatformGestureCurve::TouchpadFlingPlatformGestureCurve):

  • platform/TouchpadFlingPlatformGestureCurve.h:

(TouchpadFlingPlatformGestureCurve):

Source/WebKit/chromium:

Adds a path for transfering an active wheel fling animation out to the embedder from the compositor and back in
to a WebViewImpl via the embedder. This is used when we start a wheel fling animation on the compositor thread
but then hit a condition that we can't handle from the compositor, such as registered wheel event listeners or a
scrollable area we can't handle.

New tests added to WebCompositorInputHandlerTest for the transfering logic.

  • public/WebActiveWheelFlingParameters.h: Copied from Source/WebKit/chromium/public/WebCompositorInputHandlerClient.h.

(WebKit):
(WebActiveWheelFlingParameters):
(WebKit::WebActiveWheelFlingParameters::WebActiveWheelFlingParameters):

  • public/WebCompositorInputHandlerClient.h:

(WebKit):
(WebCompositorInputHandlerClient):
(WebKit::WebCompositorInputHandlerClient::transferActiveWheelFlingAnimation):

  • public/WebView.h:

(WebKit):
(WebView):

  • src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
(WebKit::WebCompositorInputHandlerImpl::animate):
(WebKit::WebCompositorInputHandlerImpl::cancelCurrentFling):
(WebKit::WebCompositorInputHandlerImpl::scrollBy):

  • src/WebCompositorInputHandlerImpl.h:

(WebCore):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::transferActiveWheelFlingAnimation):
(WebKit):

  • src/WebViewImpl.h:

(WebViewImpl):

  • tests/WebCompositorInputHandlerImplTest.cpp:

(WebKit::MockWebCompositorInputHandlerClient::MockWebCompositorInputHandlerClient):
(MockWebCompositorInputHandlerClient):
(WebKit::TEST):
(WebKit::WebCompositorInputHandlerImplTest::WebCompositorInputHandlerImplTest):
(WebKit::WebCompositorInputHandlerImplTest::~WebCompositorInputHandlerImplTest):
(WebCompositorInputHandlerImplTest):
(WebKit::TEST_F):
(WebKit):

TBR=commit-queue@webkit.org
BUG=118779
Review URL: https://chromiumcodereview.appspot.com/9931004

17:09 Changeset [112613] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[BlackBerry] DRT test case findString-markers is broken
https://bugs.webkit.org/show_bug.cgi?id=82661

Patch by Andy Chen <andchen@rim.com> on 2012-03-29
Reviewed by Rob Buis.

Fixed wrong paths to js libs for this test case.

  • platform/blackberry/editing/text-iterator/findString-markers.html:
17:09 Changeset [112612] by jamesr@google.com
  • 14 edits in branches/chromium/1084/Source

Merge 112360 - [chromium] Route monotonic clock up from compositor
https://bugs.webkit.org/show_bug.cgi?id=82154

Reviewed by James Robinson.

Source/Platform:

  • chromium/public/WebLayerTreeViewClient.h:

(WebLayerTreeViewClient):

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::updateAnimations):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionBeginFrame):
(WebCore::CCThreadProxy::beginFrame):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(WebCore::CCThreadProxy::BeginFrameAndCommitState::BeginFrameAndCommitState):
(BeginFrameAndCommitState):

Source/WebKit/chromium:

  • public/WebWidget.h:

(WebKit::WebWidget::animate):

  • src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::updateAnimations):

  • src/WebLayerTreeViewImpl.h:

(WebLayerTreeViewImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::animate):
(WebKit::WebViewImpl::updateAnimations):

  • src/WebViewImpl.h:

(WebViewImpl):

  • tests/FakeCCLayerTreeHostClient.h:

(WebCore::FakeCCLayerTreeHostClient::updateAnimations):

TBR=nduca@chromium.org
BUG=118779
Review URL: https://chromiumcodereview.appspot.com/9933003

17:00 Changeset [112611] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Attempt to fix the component build
https://bugs.webkit.org/show_bug.cgi?id=82676

Unreviewed.

Now that we're implementing some of the WEBKIT_EXPORT symbols in
WebCore/platform/chromium/support, we need to tell the build system
that we want to actually export these symbols.

  • WebCore.gyp/WebCore.gyp:
16:46 Changeset [112610] by cevans@google.com
  • 1 edit in branches/chromium/1025/Source/WebCore/svg/SVGTRefElement.cpp

Merge 111556
BUG=118593
Review URL: https://chromiumcodereview.appspot.com/9937002

16:45 Changeset [112609] by jamesr@google.com
  • 11 edits in branches/chromium/1084/Source

Merge 112446 - [chromium] Scheduler should not tell FrameRateController to begin a frame when we dont swap
https://bugs.webkit.org/show_bug.cgi?id=82516

Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::swapBuffers):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::swapBuffers):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::processScheduledActions):

  • platform/graphics/chromium/cc/CCScheduler.h:

(WebCore::CCScheduledActionDrawAndSwapResult::CCScheduledActionDrawAndSwapResult):
(CCScheduledActionDrawAndSwapResult):
(WebCore):
(CCSchedulerClient):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwapIfPossible):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwapForced):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

  • tests/CCSchedulerTest.cpp:

(WebKitTests::FakeCCSchedulerClient::reset):
(WebKitTests::FakeCCSchedulerClient::hasAction):
(FakeCCSchedulerClient):
(WebKitTests::FakeCCSchedulerClient::scheduledActionDrawAndSwapIfPossible):
(WebKitTests::FakeCCSchedulerClient::scheduledActionDrawAndSwapForced):
(WebKitTests::FakeCCSchedulerClient::setDrawWillHappen):
(WebKitTests::FakeCCSchedulerClient::setSwapWillHappenIfDrawHappens):
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::scheduledActionDrawAndSwapIfPossible):
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::scheduledActionDrawAndSwapForced):
(SchedulerClientThatSetNeedsDrawInsideDraw):
(WebKitTests::TEST):
(WebKitTests::SchedulerClientThatSetNeedsCommitInsideDraw::scheduledActionDrawAndSwapIfPossible):
(WebKitTests::SchedulerClientThatSetNeedsCommitInsideDraw::scheduledActionDrawAndSwapForced):
(SchedulerClientThatSetNeedsCommitInsideDraw):
(WebKitTests):

TBR=nduca@chromium.org
BUG=120406
Review URL: https://chromiumcodereview.appspot.com/9950004

16:45 Changeset [112608] by enrica@apple.com
  • 2 edits in trunk/LayoutTests

Skipping a failing test on Lion.
I filed https://bugs.webkit.org/show_bug.cgi?id=82675 to
track this issue.

  • platform/mac/Skipped:
16:38 Changeset [112607] by lforschler@apple.com
  • 4 edits in trunk/Source

Versioning.

16:38 Changeset [112606] by jamesr@google.com
  • 2 edits in branches/chromium/1084/Source/WebKit/chromium

Merge 112417 - [chromium] Compositor visibility setting must be updated even if not actively compositing
https://bugs.webkit.org/show_bug.cgi?id=82406

Patch by James Robinson <jamesr@chromium.org> on 2012-03-28
Reviewed by Adrienne Walker.

Propagate the visibility bit to the WebLayerTreeView even when compositing is inactive.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setVisibilityState):

TBR=commit-queue@webkit.org
BUG=120464, 119812
Review URL: https://chromiumcodereview.appspot.com/9951001

16:37 Changeset [112605] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1025

Merge 111899
BUG=117728
Review URL: https://chromiumcodereview.appspot.com/9930007

16:29 Changeset [112604] by dpranke@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, expectations and baselines updates.

  • platform/chromium-mac/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt:
  • platform/chromium/test_expectations.txt:
16:29 Changeset [112603] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1025

Merge 110487
BUG=117724
Review URL: https://chromiumcodereview.appspot.com/9948001

16:28 Changeset [112602] by lforschler@apple.com
  • 1 copy in tags/Safari-536.5

New Tag.

16:19 Changeset [112601] by jamesr@google.com
  • 2 edits in branches/chromium/1084/Source/WebKit/chromium

Merge 112363 - [chromium] Send wheel events to main thread even if we think nothing is scrollable
https://bugs.webkit.org/show_bug.cgi?id=82408

Patch by James Robinson <jamesr@chromium.org> on 2012-03-27
Reviewed by Adrienne Walker.

  • src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):

TBR=commit-queue@webkit.org
BUG=119984
Review URL: https://chromiumcodereview.appspot.com/9941001

16:18 Changeset [112600] by mitz@apple.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

Restored change log entries that were accidentally deleted in r104276

16:17 Changeset [112599] by japhet@chromium.org
  • 6 edits in trunk/Source/WebCore

Simplify reporting a main resource error to DocumentLoader and
FrameLoader.
https://bugs.webkit.org/show_bug.cgi?id=82649

Reviewed by Adam Barth.

No new tests, no functionality change intended.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::mainReceivedError): Remove isComplete parameter,

since it was always true. Call FrameLoader::receivedMainResourceError,
instead of the other way around.

  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::receivedMainResourceError): Remove isComplete parameter,

since it was always true. Merge in most of mainReceivedCompleteError().

  • loader/FrameLoader.h:
  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::receivedError):
(WebCore::MainResourceLoader::didCancel):

16:16 Changeset [112598] by dpranke@chromium.org
  • 3 edits in trunk/Tools

remove support for junit-style xml output from test-webkitpy
https://bugs.webkit.org/show_bug.cgi?id=82279

Reviewed by Eric Seidel.

This was added when we were looking into integrating w/ Jenkins
rather than buildbot, but I believe that project got shelved, so
this is unused. We can always add it back in later as necessary.

  • Scripts/webkitpy/test/main.py:

(Tester._parse_args):
(Tester._run_tests):

  • Scritps/webkitpy/thirdparty/init.py:
16:09 Changeset [112597] by cevans@google.com
  • 1 edit in branches/chromium/1025/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm

Merge 111813
BUG=118185
Review URL: https://chromiumcodereview.appspot.com/9939001

16:03 Changeset [112596] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Heap-use-after-free in WebCore::InlineFlowBox::deleteLine due to fullscreen issues.
https://bugs.webkit.org/show_bug.cgi?id=82055

Reviewed by David Hyatt.

No new tests; fixes fuzz test crasher which is not reproducible in DRT or WKTR.

When a RenderFullScreen object is inserted between a child and parent renderer, make sure the
parent renderer deletes its line boxes by calling setNeedsLayoutAndPrefWidthsRecalc(). This
forces its InlineBox renderers to be removed from the line boxes and their parents in the correct
order, fixing a double-delete crash.

The same is true when unwrapping the RenderFullScreen object, and when creating and inserting
the full screen placeholder.

  • rendering/RenderFullScreen.cpp:

(RenderFullScreen::wrapRenderer):
(RenderFullScreen::unwrapRenderer):
(RenderFullScreen::createPlaceholder):

16:01 Changeset [112595] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Unreviewed build fix for non-x86 platforms.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileSoftModulo):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emitSlow_op_mod):

15:53 Changeset [112594] by dpranke@chromium.org
  • 3 edits in trunk/Tools

new-run-webkit-tests: crashes when it fails to decode a stack trace
https://bugs.webkit.org/show_bug.cgi?id=82673

Unreviewed, build fix.

We are assuming the stdout/stderr output from the driver is utf-8
encoded when we get stack traces; this may not be a valid
assumption generally, but if we do get strings that aren't valid
utf-8, we would crash. Now we will ignore any decoding errors.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port._get_crash_log):

  • Scripts/webkitpy/layout_tests/port/port_testcase.py:

(PortTestCase.test_get_crash_log):

15:50 Changeset [112593] by enrica@apple.com
  • 2 edits in trunk/LayoutTests

Skipping http/tests/xmlhttprequest/range-test.html for Mac platforms.
I filed https://bugs.webkit.org/show_bug.cgi?id=82672

  • platform/mac/Skipped:
15:45 Changeset [112592] by benjamin@webkit.org
  • 4 edits in trunk/Source/WebCore

Get rid of Geolocation::positionChangedInternal(), use positionChanged() directly
https://bugs.webkit.org/show_bug.cgi?id=82543

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-29
Reviewed by Andreas Kling.

After the change to client based geolocation, the method positionChangedInternal()
is called only by positionChanged(). This patch remove this extra indirection.

  • Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::positionChanged):

  • Modules/geolocation/Geolocation.h:

(Geolocation):

  • WebCore.order:
15:44 Changeset [112591] by ojan@chromium.org
  • 6 edits
    7 copies
    1 move
    13 adds
    3 deletes in trunk/LayoutTests

Rebaseline fast/js tests for Chromium where the new results are
clearly more correct or the differences are just the error messages
V8 uses that are different from JSCs.

  • platform/chromium-linux-x86/fast/js/large-expressions-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/js/large-expressions-expected.txt.
  • platform/chromium-linux/fast/js/large-expressions-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/js/large-expressions-expected.txt.
  • platform/chromium-mac-leopard/fast/js/large-expressions-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/js/large-expressions-expected.txt.
  • platform/chromium-mac-snowleopard/fast/js/large-expressions-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/js/large-expressions-expected.txt.
  • platform/chromium-mac/fast/js/large-expressions-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/js/large-expressions-expected.txt.
  • platform/chromium-win-vista/fast/js/large-expressions-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/js/large-expressions-expected.txt.
  • platform/chromium-win-xp/fast/js/large-expressions-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/js/large-expressions-expected.txt.
  • platform/chromium-win/fast/js/large-expressions-expected.txt:
  • platform/chromium/fast/js/JSON-parse-expected.txt:
  • platform/chromium/fast/js/JSON-stringify-replacer-expected.txt: Added.
  • platform/chromium/fast/js/Object-create-expected.txt: Added.
  • platform/chromium/fast/js/Object-defineProperties-expected.txt: Added.
  • platform/chromium/fast/js/exception-codegen-crash-expected.txt: Removed.
  • platform/chromium/fast/js/function-apply-aliased-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/js/function-apply-aliased-expected.txt.
  • platform/chromium/fast/js/function-bind-expected.txt: Added.
  • platform/chromium/fast/js/kde/parse-expected.txt:
  • platform/chromium/fast/js/object-literal-syntax-expected.txt: Added.
  • platform/chromium/fast/js/object-prototype-properties-expected.txt: Added.
  • platform/chromium/fast/js/regexp-caching-expected.txt: Removed.
  • platform/chromium/fast/js/regexp-test-null-string-expected.txt: Removed.
  • platform/chromium/fast/js/reserved-words-as-property-expected.txt: Added.
  • platform/chromium/fast/js/reserved-words-strict-expected.txt:
  • platform/chromium/test_expectations.txt:
15:42 Changeset [112590] by enrica@apple.com
  • 2 edits in trunk/LayoutTests

Skipping 3 inspector tests on Mac.
I filed https://bugs.webkit.org/show_bug.cgi?id=82671

  • platform/mac/Skipped:
15:32 Changeset [112589] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

InputType attribute changed functions should happen after the attribute change
https://bugs.webkit.org/show_bug.cgi?id=82644

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-03-29
Reviewed by Benjamin Poulain.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::parseAttribute):

15:32 Changeset [112588] by dpranke@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

Update expectations w/ crash information after r129689 has landed.

Unreviewed, expectations change.

Also delete what appears to be a bad baseline for the fast/text test.

  • platform/chromium/fast/text/international/spaces-combined-in-vertical-text-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
15:21 Changeset [112587] by commit-queue@webkit.org
  • 9 edits in trunk

Update CSS Exclusion wrap-flow values left & right to start & end
https://bugs.webkit.org/show_bug.cgi?id=82366

Source/WebCore:

http://dev.w3.org/csswg/css3-exclusions/
-webkit-wrap-flow now takes the values start and end rather than
left and right. Updating the code to reflect this. Functionality
is covered by existing tests.

Patch by Bear Travis <betravis@adobe.com> on 2012-03-29
Reviewed by Andreas Kling.

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator WrapFlow):

  • rendering/style/RenderStyleConstants.h:

LayoutTests:

Updating test values for the wrap-flow and wrap shorthand property

Patch by Bear Travis <betravis@adobe.com> on 2012-03-29
Reviewed by Andreas Kling.

  • fast/exclusions/script-tests/wrap-flow-parsing.js:
  • fast/exclusions/script-tests/wrap-parsing.js:
  • fast/exclusions/wrap-flow-parsing-expected.txt:
  • fast/exclusions/wrap-parsing-expected.txt:
15:19 Changeset [112586] by enrica@apple.com
  • 2 edits in trunk/LayoutTests

Skipping plugin mouse events tests failing on Mac platforms.
The issue is tracked by https://bugs.webkit.org/show_bug.cgi?id=82668

  • platform/mac/Skipped:
15:11 Changeset [112585] by enrica@apple.com
  • 2 edits in trunk/LayoutTests

Skipping 5 failing webarchive tests.
I filed https://bugs.webkit.org/show_bug.cgi?id=82665

  • platform/mac/Skipped:
15:10 Changeset [112584] by dpranke@chromium.org
  • 9 edits
    2 deletes in trunk

Source/WebCore: rollout r112484, r112545, r112574
https://bugs.webkit.org/show_bug.cgi?id=82662

Unreviewed, build fix.

this appears to be producing some questionable differences on
the apple mac bots, and possibly one test on chromium linux.

  • css/mediaControls.css:

(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):

  • css/mediaControlsChromium.css:

(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):

  • html/shadow/MediaControlElements.cpp:

(RenderMediaVolumeSliderContainer):
(WebCore):
(WebCore::RenderMediaVolumeSliderContainer::RenderMediaVolumeSliderContainer):
(WebCore::RenderMediaVolumeSliderContainer::layout):
(WebCore::MediaControlVolumeSliderContainerElement::createRenderer):

  • html/shadow/MediaControlElements.h:

(MediaControlVolumeSliderContainerElement):

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::create):

LayoutTests: rollout r112484, r112545, r112574, r112575
https://bugs.webkit.org/show_bug.cgi?id=82662

Unreviewed, build fix.

  • media/video-controls-rendering-toggle-display-none-expected.txt: Removed.
  • media/video-controls-rendering-toggle-display-none.html: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac/Skipped.txt:
14:59 Changeset [112583] by enrica@apple.com
  • 2 edits in trunk/LayoutTests

Skipping crashing workers tests.
Filed https://bugs.webkit.org/show_bug.cgi?id=82660 to track the issue.

  • platform/mac/Skipped:
14:55 Changeset [112582] by jchaffraix@webkit.org
  • 14 edits
    8 adds in trunk

REGRESSION (r110065-r110080): Content drawing outside overflow: hidden at ynet.co.il
https://bugs.webkit.org/show_bug.cgi?id=82129

Reviewed by Ojan Vafai.

Source/WebCore:

Tests: fast/overflow/before-after-overflow-hidden-horizontal-writing-mode-tb-expected.html

fast/overflow/before-after-overflow-hidden-horizontal-writing-mode-tb.html
fast/overflow/before-after-overflow-hidden-vertical-writing-mode-rl-expected.html
fast/overflow/before-after-overflow-hidden-vertical-writing-mode-rl.html
fast/overflow/start-end-overflow-hidden-horizontal-writing-mode-tb-expected.html
fast/overflow/start-end-overflow-hidden-horizontal-writing-mode-tb.html
fast/overflow/start-end-overflow-hidden-vertical-writing-mode-rl-expected.html
fast/overflow/start-end-overflow-hidden-vertical-writing-mode-rl.html

This is a regression from r110072. I wrongly thought we should call ensureLayer if we create our RenderOverflow.
However the current overflow code removes the before and start overflows (like in horizontal writing mode with ltr direction,
we never have a top or a left overflow). Because of that we would not get a RenderLayer as expected and the overflow clip rects
would be wrong on our RenderLayer children.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::addLayoutOverflow):
Moved the ensureLayer() call after the check that we do have some overflow but before we remove the overflow in some directions.

LayoutTests:

  • fast/overflow/before-after-overflow-hidden-horizontal-writing-mode-tb-expected.html: Added.
  • fast/overflow/before-after-overflow-hidden-horizontal-writing-mode-tb.html: Added.
  • fast/overflow/before-after-overflow-hidden-vertical-writing-mode-rl-expected.html: Added.
  • fast/overflow/before-after-overflow-hidden-vertical-writing-mode-rl.html: Added.
  • fast/overflow/start-end-overflow-hidden-horizontal-writing-mode-tb-expected.html: Added.
  • fast/overflow/start-end-overflow-hidden-horizontal-writing-mode-tb.html: Added.
  • fast/overflow/start-end-overflow-hidden-vertical-writing-mode-rl-expected.html: Added.
  • fast/overflow/start-end-overflow-hidden-vertical-writing-mode-rl.html: Added.

Added 4 ref tests that should cover the 4 different values of (hasTopOverflow, hasLeftOverflow)
in RenderBox::addLayoutOverflow.

  • platform/chromium-linux/fast/box-shadow/shadow-buffer-partial-expected.txt:
  • platform/chromium-win/fast/block/lineboxcontain/block-font-expected.txt:
  • platform/chromium-win/fast/block/lineboxcontain/block-glyphs-expected.txt:
  • platform/chromium-win/fast/block/lineboxcontain/font-expected.txt:

Rebaselined those tests on Chromium linux (new layers).

  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wk2/Skipped:

Skipped the previous tests on the other platforms.

14:51 Changeset [112581] by cevans@google.com
  • 5 edits
    2 copies in branches/chromium/1025

Merge 111895
BUG=118273
Review URL: https://chromiumcodereview.appspot.com/9910031

14:48 Changeset [112580] by simon.fraser@apple.com
  • 2 edits in trunk/Tools

Scripts fail to detect when a tool crashes
https://bugs.webkit.org/show_bug.cgi?id=82659

Reviewed by Mark Rowe.

Have exitStatus() detect when the process fail to exit cleanly
(possibly because of a crash), and return a non-zero exit code
in that case.

  • Scripts/VCSUtils.pm:

(exitStatus):

14:44 Changeset [112579] by abarth@webkit.org
  • 4 edits
    4 moves in trunk/Source

[Chromium] Move ResourceHandle to WebCore/platform/network/chromium
https://bugs.webkit.org/show_bug.cgi?id=82657

Reviewed by James Robinson.

Source/WebCore:

We finally arive at our destination. This patch actually moves
WebCore::ResourceHandle from Source/WebKit/chromium/src to
Source/WebCore/network/chromium, matching its location in other ports.
To make this happen, we also need to move WrappedResourceRequest and
WrappedResourceResponse.

This patch is the last patch from
https://github.com/abarth/webkit/compare/master...webcore-platform

  • WebCore.gypi:
  • platform/chromium/support/WrappedResourceRequest.h: Copied from Source/WebKit/chromium/src/WrappedResourceRequest.h.
  • platform/chromium/support/WrappedResourceResponse.h: Copied from Source/WebKit/chromium/src/WrappedResourceResponse.h.
  • platform/network/chromium/ResourceHandle.cpp: Copied from Source/WebKit/chromium/src/ResourceHandle.cpp.

(WebCore::ResourceHandleInternal::ResourceHandleInternal):
(WebCore::ResourceHandleInternal::start):
(WebCore::ResourceHandle::loadResourceSynchronously):
(WebCore::ResourceHandle::cacheMetadata):

  • platform/network/chromium/ResourceHandleInternal.h: Copied from Source/WebKit/chromium/src/ResourceHandleInternal.h.

Source/WebKit/chromium:

  • WebKit.gyp:
  • src/ResourceHandle.cpp: Removed.
  • src/ResourceHandleInternal.h: Removed.
  • src/WrappedResourceRequest.h: Removed.
  • src/WrappedResourceResponse.h: Removed.
14:26 Changeset [112578] by tony@chromium.org
  • 3 edits in trunk/LayoutTests

remove ahem font from flexbox layout tests
https://bugs.webkit.org/show_bug.cgi?id=82633

Reviewed by Ojan Vafai.

These tests don't depend on the ahem font and after r112489, we seem
to be hitting a race condition on the Mac bots where we are checking
baselines while the font is still being loaded. Speculatively fix by
removing the webfont.

  • css3/flexbox/flex-align-vertical-writing-mode.html:
  • css3/flexbox/flex-align.html:
14:24 Changeset [112577] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix for WinCE after r112555.

  • platform/text/wince/TextCodecWinCE.cpp:

(WebCore::LanguageManager::LanguageManager):

14:20 Changeset [112576] by dslomov@google.com
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] WorkerFileSystemContextObserver can reference a deleted WorkerFileSystemCallbacksBridge.
https://bugs.webkit.org/show_bug.cgi?id=82565

WorkerFileSystemCallbacksBridge relies on a cleanUpAfterCallback being called
prior to the disposal of the bridge to ensure that WorkerFileSystemContextObserver
is unsubscribed and deleted. However cleanUpAfterCallback will only execute if the bridge's
callback has executed on the worker thread, and this might not be the case if the worker
terminates.

This patch fixes this by maintaining a RefPtr from WorkerFileSystemContextObserver to
WorkerFileSystemCallbacksBridge. This ensures that bridge is not deleted while observer is alive.

Reviewed by David Levin.

  • src/WorkerFileSystemCallbacksBridge.cpp:

(WebKit::WorkerFileSystemContextObserver::create):
(WebKit::WorkerFileSystemContextObserver::WorkerFileSystemContextObserver):
(WorkerFileSystemContextObserver):

14:16 Changeset [112575] by enrica@apple.com
  • 3 edits in trunk/LayoutTests

Moving test to skip from test-expectations.txt to Skipped
for Mac platform.

  • platform/mac/Skipped:
  • platform/mac/test_expectations.txt:
14:02 Changeset [112574] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Update expectations for media tests failing w/ slider change after r112484.

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
13:57 Changeset [112573] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Images that reload via media queries don't paint when device scale factor changes
https://bugs.webkit.org/show_bug.cgi?id=82648
<rdar://problem/11143637>

Reviewed by Beth Dakin.

Commit scale factor changes before dirty rect changes, since setting the scale factor
can lead to more rects being dirtied when using the tile cache.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):

13:52 Changeset [112572] by abarth@webkit.org
  • 5 edits
    9 moves
    1 add in trunk/Source

Move CPP files related to ResourceHandle to WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=82582

Reviewed by James Robinson.

Source/WebCore:

This patch moves a number of files that implement parts of the platform
portion of the Chromium WebKit API from the WebKit layer to
WebCore/platform. These files are in the dependency cone of
ResourceHandle and have no dependencies on anything outside
WebCore/platform.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/chromium/support: Added.
  • platform/chromium/support/WebData.cpp: Copied from Source/WebKit/chromium/src/WebData.cpp.
  • platform/chromium/support/WebHTTPBody.cpp: Copied from Source/WebKit/chromium/src/WebHTTPBody.cpp.
  • platform/chromium/support/WebHTTPLoadInfo.cpp: Copied from Source/WebKit/chromium/src/WebHTTPLoadInfo.cpp.
  • platform/chromium/support/WebURL.cpp: Copied from Source/WebKit/chromium/src/WebURL.cpp.
  • platform/chromium/support/WebURLError.cpp: Copied from Source/WebKit/chromium/src/WebURLError.cpp.
  • platform/chromium/support/WebURLRequest.cpp: Copied from Source/WebKit/chromium/src/WebURLRequest.cpp.
  • platform/chromium/support/WebURLRequestPrivate.h: Copied from Source/WebKit/chromium/src/WebURLRequestPrivate.h.
  • platform/chromium/support/WebURLResponse.cpp: Copied from Source/WebKit/chromium/src/WebURLResponse.cpp.
  • platform/chromium/support/WebURLResponsePrivate.h: Copied from Source/WebKit/chromium/src/WebURLResponsePrivate.h.

Source/WebKit/chromium:

  • WebKit.gyp:
  • src/WebData.cpp: Removed.
  • src/WebHTTPBody.cpp: Removed.
  • src/WebHTTPLoadInfo.cpp: Removed.
  • src/WebURL.cpp: Removed.
  • src/WebURLError.cpp: Removed.
  • src/WebURLRequest.cpp: Removed.
  • src/WebURLRequestPrivate.h: Removed.
  • src/WebURLResponse.cpp: Removed.
  • src/WebURLResponsePrivate.h: Removed.
13:46 Changeset [112571] by ap@apple.com
  • 3 edits in trunk/Source/WebKit/mac

[Mac] REGRESSION: Removing translation of local paths in KURL constructor broke some applications
https://bugs.webkit.org/show_bug.cgi?id=82548
<rdar://problem/11125355>
<rdar://problem/11142152>

Reviewed by Brady Eidson.

  • WebView/WebFrame.mm: (-[WebFrame loadRequest:]): Fixed this bug. (-[WebFrame loadHTMLString:baseURL:]): Also added translation to another API, so that I don't have to come back again. (-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]): Ditto.
  • WebView/WebView.mm: (-[WebView setMainFrameURL:]): Changed another place where clients used to pass file paths instead of URLs.
13:39 Changeset [112570] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

Unreviewed, rolling out r111259.
http://trac.webkit.org/changeset/111259
https://bugs.webkit.org/show_bug.cgi?id=82650

Caused selection regression in calculations due to
misconstructed IntRectRegion. (Requested by mfenton on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-29

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::getConsolidatedRegionOfTextQuadsForSelection):

13:37 Changeset [112569] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix p2.

13:36 Changeset [112568] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[chromium] Ensure framebuffer exists at the start of beginDrawingFrame.
https://bugs.webkit.org/show_bug.cgi?id=82569

Patch by Michal Mocny <mmocny@google.com> on 2012-03-29
Reviewed by James Robinson.

Source/WebCore:

Updated LayerRendererChromiumTest unittests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::setVisible):
(WebCore::LayerRendererChromium::beginDrawingFrame):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::compositeAndReadback):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::requestReadbackOnImplThread):

Source/WebKit/chromium:

  • tests/LayerRendererChromiumTest.cpp:

(FakeLayerRendererChromiumClient::FakeLayerRendererChromiumClient):
(FakeLayerRendererChromiumClient::rootLayer):
(FakeLayerRendererChromiumClient):
(TEST_F):

13:31 Changeset [112567] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK][EFL] run-javascriptcore-tests should be run through jhbuild
https://bugs.webkit.org/show_bug.cgi?id=82581

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-03-29
Reviewed by Martin Robinson.

Running Javascriptcore tests through jhbuild
for consistency with run-webkit-tests and in order to
avoid confusing libraries when facing regressions.

  • Scripts/run-javascriptcore-tests:
13:20 Changeset [112566] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Add a compile assert for the size of RenderBlock
https://bugs.webkit.org/show_bug.cgi?id=82586

Reviewed by Tony Chang.

Add compile asserts for the size of RenderBlock and RenderBlock::MarginValues.
We can't add asserts for FloatingObject and MarginInfo because they're private to RenderBlock.

  • rendering/RenderBlock.cpp:

(SameSizeAsRenderBlock):
(WebCore):
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::repaintOverhangingFloats):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::clearFloats):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::adjustForBorderFit):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::FloatingObject::shouldPaint):
(WebCore::RenderBlock::FloatingObject::setShouldPaint):
(WebCore::RenderBlock::FloatingObject::isDescendant):
(WebCore::RenderBlock::FloatingObject::setIsDescendant):
(FloatingObject):
(RenderBlock):

13:16 Changeset [112565] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix p1.

13:16 Changeset [112564] by barraclough@apple.com
  • 8 edits in trunk/Source

Template the Yarr::Interpreter on the character type
https://bugs.webkit.org/show_bug.cgi?id=82637

Reviewed by Sam Weinig.

We should be able to call to the interpreter after having already checked the character type,
without having to re-package the character pointer back up into a string!

../JavaScriptCore:

  • runtime/RegExp.cpp:

(JSC::RegExp::match):
(JSC::RegExp::matchCompareWithInterpreter):

  • Don't pass length.
  • yarr/Yarr.h:
    • moved function declarations to YarrInterpreter.h.
  • yarr/YarrInterpreter.cpp:

(Yarr):
(Interpreter):
(JSC::Yarr::Interpreter::InputStream::InputStream):
(InputStream):
(JSC::Yarr::Interpreter::Interpreter):
(JSC::Yarr::interpret):

  • templated Interpreter class on CharType.
  • yarr/YarrInterpreter.h:

(Yarr):

  • added function declarations.

../WebCore:

  • inspector/ContentSearchUtils.cpp:

(WebCore::ContentSearchUtils::findMagicComment):

  • platform/text/RegularExpression.cpp:

(WebCore::RegularExpression::match):

  • Don't pass length.
12:48 Changeset [112563] by abarth@webkit.org
  • 5 edits
    2 adds in trunk/Source

Source/Platform: [Chromium] Move createURLLoader() into Platform
https://bugs.webkit.org/show_bug.cgi?id=82587

Reviewed by James Robinson.

This patch introduces a base class for WebKitPlatformSupport that we
can use to incrementally more APIs from WebKit/chromium/public/platform
into Platform/chromium/public. Using this technique lets us avoid
making changes in the embedder during the transition.

This patch moves createURLLoader() because it's necessary for
ResourceHandle. This is the third patch in this sequence:
https://github.com/abarth/webkit/compare/master...webcore-platform

  • Platform.gypi:
  • chromium/public/Platform.h: Added.

(WebKit):
(Platform):
(WebKit::Platform::createURLLoader):
(WebKit::Platform::~Platform):

  • chromium/src/Platform.cpp: Added.

(WebKit):
(WebKit::Platform::initialize):
(WebKit::Platform::shutdown):
(WebKit::Platform::current):

Source/WebKit/chromium: Move createURLLoader() into Platform
https://bugs.webkit.org/show_bug.cgi?id=82587

Reviewed by James Robinson.

  • public/platform/WebKitPlatformSupport.h:

(WebKit):
(WebKitPlatformSupport):

  • src/WebKit.cpp:

(WebKit::initializeWithoutV8):
(WebKit::shutdown):

12:37 Changeset [112562] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Don't use a flattened framework path when building on OS X

Reviewed by Mark Rowe.

  • Configurations/ToolExecutable.xcconfig: Use REAL_PLATFORM_NAME

to select different INSTALL_PATH values.

12:29 Changeset [112561] by dpranke@chromium.org
  • 4 edits in trunk/Tools

test-webkitpy: add --timing
https://bugs.webkit.org/show_bug.cgi?id=82550

Reviewed by Eric Seidel.

This patch adds a --timing option that will display the time
each test takes. It also removes the --silent option, since
probably no one ever used it, and cleans up the logging
option parsing code to be easier to follow.

  • Scripts/webkitpy/test/main.py:

(Tester._parse_args):
(Tester._configure):

  • Scripts/webkitpy/test/runner.py:

(TestRunner.write_result):

  • Scripts/webkitpy/test/runner_unittest.py:

(RunnerTest.test_regular):
(RunnerTest.test_verbose):
(RunnerTest):
(RunnerTest.test_timing):

12:25 Changeset [112560] by kevino@webkit.org
  • 8 edits in trunk

[wx] Unreviewed. wxMSW build fixes.

12:25 Changeset [112559] by ossy@webkit.org
  • 31 edits in trunk/Source

Unreviewed, rolling out r112553.
http://trac.webkit.org/changeset/112553
https://bugs.webkit.org/show_bug.cgi?id=82638

It made all tests crash on Qt WK2 (Requested by Ossy_away on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-29

Source/WebCore:

  • Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::stop):
(WebCore::Geolocation::lastPosition):
(WebCore::Geolocation::requestPermission):
(WebCore::Geolocation::startUpdating):
(WebCore::Geolocation::stopUpdating):

  • Modules/geolocation/Geolocation.h:

(WebCore):

  • Modules/geolocation/GeolocationController.cpp:
  • Modules/geolocation/GeolocationController.h:
  • WebCore.exp.in:
  • page/GeolocationClient.h:

(WebCore):
(GeolocationClient):

  • page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::PageClients::PageClients):

  • page/Page.h:

(WebCore):
(PageClients):
(Page):
(WebCore::Page::geolocationController):

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::init):

  • WebCoreSupport/GeolocationControllerClientBlackBerry.cpp:

(GeolocationControllerClientBlackBerry::onLocationUpdate):
(GeolocationControllerClientBlackBerry::onLocationError):

  • WebKitSupport/DumpRenderTreeSupport.cpp:

(DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests):
(DumpRenderTreeSupport::resetGeolocationMock):
(DumpRenderTreeSupport::setMockGeolocationError):
(DumpRenderTreeSupport::setMockGeolocationPermission):
(DumpRenderTreeSupport::setMockGeolocationPosition):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

Source/WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::resetGeolocationClientMock):
(DumpRenderTreeSupportGtk::setMockGeolocationPermission):
(DumpRenderTreeSupportGtk::setMockGeolocationPosition):
(DumpRenderTreeSupportGtk::setMockGeolocationError):
(DumpRenderTreeSupportGtk::numberOfPendingGeolocationPermissionRequests):

  • WebCoreSupport/GeolocationClientGtk.cpp:

(WebKit::GeolocationClient::updatePosition):
(WebKit::GeolocationClient::errorOccured):

  • webkit/webkitwebview.cpp:

(webkit_web_view_init):

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _geolocationDidChangePosition:]):
(-[WebView _geolocationDidFailWithError:]):

Source/WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::resetGeolocationMock):
(DumpRenderTreeSupportQt::setMockGeolocationPermission):
(DumpRenderTreeSupportQt::setMockGeolocationPosition):
(DumpRenderTreeSupportQt::setMockGeolocationError):
(DumpRenderTreeSupportQt::numberOfPendingGeolocationPermissionRequests):

  • WebCoreSupport/GeolocationClientQt.cpp:

(WebCore::GeolocationClientQt::positionUpdated):
(WebCore::GeolocationClientQt::startUpdating):

Source/WebKit/win:

  • WebView.cpp:

(WebView::initWithFrame):
(WebView::geolocationDidChangePosition):
(WebView::geolocationDidFailWithError):

Source/WebKit2:

  • WebProcess/Geolocation/WebGeolocationManager.cpp:

(WebKit::WebGeolocationManager::didChangePosition):
(WebKit::WebGeolocationManager::didFailToDeterminePosition):

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setGeoLocationPermission):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

12:22 Changeset [112558] by kevino@webkit.org
  • 3 edits in trunk/Source/WTF

[wx] Unreviewed build fix. Add WTF_EXPORT_PRIVATE_NO_RTTI
so that ports not using RTTI can add symbol exports to
classes that RTTI ports export with WTF_EXPORT_PRIVATE_RTTI.

12:09 Changeset [112557] by aestes@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Remove an unused variable that breaks the build with newer versions of clang.

Rubber stamped by Gavin Barraclough.

  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::backtrackCharacterClassNonGreedy):

12:01 Changeset [112556] by enrica@apple.com
  • 4 edits in trunk/LayoutTests

Updating expected results. The output has an additional blank line.
No changes in the actual results.

  • platform/mac/editing/input/firstrectforcharacterrange-plain-expected.txt:
  • platform/mac/editing/input/firstrectforcharacterrange-styled-expected.txt:
  • platform/mac/fast/text/attributed-substring-from-range-002-expected.txt:
11:48 Changeset [112555] by caio.oliveira@openbossa.org
  • 129 edits in trunk

HashMap<>::add should return a more descriptive object
https://bugs.webkit.org/show_bug.cgi?id=71063

Reviewed by Ryosuke Niwa.

Source/JavaScriptCore:

Update code to use AddResult instead of a pair. Note that since WeakGCMap wraps
the iterator type, there's a need for its own AddResult type -- instantiated from
HashTableAddResult template class.

  • API/JSCallbackObject.h:

(JSC::JSCallbackObjectData::JSPrivatePropertyMap::setPrivateProperty):

  • API/JSClassRef.cpp:

(OpaqueJSClass::contextData):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::addVar):
(JSC::BytecodeGenerator::addGlobalVar):
(JSC::BytecodeGenerator::addConstant):
(JSC::BytecodeGenerator::addConstantValue):
(JSC::BytecodeGenerator::emitLoad):
(JSC::BytecodeGenerator::addStringConstant):
(JSC::BytecodeGenerator::emitLazyNewFunction):

  • bytecompiler/NodesCodegen.cpp:

(JSC::PropertyListNode::emitBytecode):

  • debugger/Debugger.cpp:
  • dfg/DFGAssemblyHelpers.cpp:

(JSC::DFG::AssemblyHelpers::decodedCodeMapFor):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::cellConstant):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • jit/JITStubs.cpp:

(JSC::JITThunks::ctiStub):
(JSC::JITThunks::hostFunctionStub):

  • parser/Parser.cpp:

(JSC::::parseStrictObjectLiteral):

  • parser/Parser.h:

(JSC::Scope::declareParameter):

  • runtime/Identifier.cpp:

(JSC::Identifier::add):
(JSC::Identifier::add8):
(JSC::Identifier::addSlowCase):

  • runtime/Identifier.h:

(JSC::Identifier::add):
(JSC::IdentifierTable::add):

  • runtime/JSArray.cpp:

(JSC::SparseArrayValueMap::add):
(JSC::SparseArrayValueMap::put):
(JSC::SparseArrayValueMap::putDirect):
(JSC::JSArray::enterDictionaryMode):
(JSC::JSArray::defineOwnNumericProperty):

  • runtime/JSArray.h:

(SparseArrayValueMap):

  • runtime/PropertyNameArray.cpp:

(JSC::PropertyNameArray::add):

  • runtime/StringRecursionChecker.h:

(JSC::StringRecursionChecker::performCheck):

  • runtime/Structure.cpp:

(JSC::StructureTransitionTable::add):

  • runtime/WeakGCMap.h:

(WeakGCMap):
(JSC::WeakGCMap::add):
(JSC::WeakGCMap::set):

  • tools/ProfileTreeNode.h:

(JSC::ProfileTreeNode::sampleChild):

Source/WebCore:

Update code to use AddResult instead of a pair. No new tests, just a refactoring.

  • Modules/webdatabase/SQLTransactionCoordinator.cpp:

(WebCore::SQLTransactionCoordinator::acquireLock):

  • Modules/webdatabase/chromium/QuotaTracker.cpp:

(WebCore::QuotaTracker::updateDatabaseSize):

  • bindings/js/DOMObjectHashTableMap.h:

(WebCore::DOMObjectHashTableMap::get):

  • bindings/js/JSDOMBinding.cpp:

(WebCore::cacheDOMStructure):

  • bindings/js/JSDOMBinding.h:

(WebCore::cacheWrapper):

  • bindings/js/JSDOMGlobalObject.h:

(WebCore::getDOMConstructor):

  • bindings/js/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::addListener):

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::setBreakpoint):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::startObjectInternal):
(WebCore::CloneSerializer::write):

  • bindings/v8/NPV8Object.cpp:

(WebCore::npCreateV8ScriptObject):

  • bridge/IdentifierRep.cpp:

(WebCore::IdentifierRep::get):

  • bridge/NP_jsobject.cpp:

(ObjectMap::add):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::logUnimplementedPropertyID):

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):
(WebCore::CSSFontSelector::getFontData):

  • css/CSSSegmentedFontFace.cpp:

(WebCore::CSSSegmentedFontFace::getFontData):

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyCounter::applyInheritValue):
(WebCore::ApplyPropertyCounter::applyValue):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::appendAuthorStylesheets):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • css/CSSValuePool.cpp:

(WebCore::CSSValuePool::createIdentifierValue):
(WebCore::CSSValuePool::createColorValue):
(WebCore::CSSValuePool::createValue):
(WebCore::CSSValuePool::createFontFamilyValue):
(WebCore::CSSValuePool::createFontFaceValue):

  • dom/CheckedRadioButtons.cpp:

(WebCore::RadioButtonGroup::add):
(WebCore::CheckedRadioButtons::addButton):

  • dom/ChildListMutationScope.cpp:

(WebCore::ChildListMutationScope::MutationAccumulationRouter::incrementScopingLevel):

  • dom/Document.cpp:

(WebCore::Document::windowNamedItems):
(WebCore::Document::documentNamedItems):
(WebCore::Document::getCSSCanvasElement):
(WebCore::Document::getItems):

  • dom/DocumentEventQueue.cpp:

(WebCore::DocumentEventQueue::enqueueEvent):
(WebCore::DocumentEventQueue::enqueueOrDispatchScrollEvent):
(WebCore::DocumentEventQueue::pendingEventTimerFired):

  • dom/DocumentOrderedMap.cpp:

(WebCore::DocumentOrderedMap::add):

  • dom/EventListenerMap.cpp:

(WebCore::EventListenerMap::add):

  • dom/Node.cpp:

(WebCore::Node::dumpStatistics):
(WebCore::Node::getElementsByTagName):
(WebCore::Node::getElementsByTagNameNS):
(WebCore::Node::getElementsByName):
(WebCore::Node::getElementsByClassName):
(WebCore::Node::collectMatchingObserversForMutation):

  • dom/QualifiedName.cpp:

(WebCore::QualifiedName::init):

  • dom/SpaceSplitString.cpp:

(WebCore::SpaceSplitStringData::create):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::updateAttributeStyle):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::append):

  • inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::diff):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::SelectorProfile::commitSelector):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::performSearch):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::resolveBreakpoint):

  • inspector/InspectorValues.h:

(WebCore::InspectorObject::setValue):
(WebCore::InspectorObject::setObject):
(WebCore::InspectorObject::setArray):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::addEntry):

  • loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::findOrCreateCacheGroup):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleTouchEvent):

  • page/PageGroup.cpp:

(WebCore::PageGroup::pageGroup):
(WebCore::PageGroup::addVisitedLink):
(WebCore::PageGroup::addUserScriptToWorld):
(WebCore::PageGroup::addUserStyleSheetToWorld):

  • page/SecurityPolicy.cpp:

(WebCore::SecurityPolicy::addOriginAccessWhitelistEntry):

  • page/TouchAdjustment.cpp:

(WebCore::TouchAdjustment::compileSubtargetList):

  • platform/cf/BinaryPropertyList.cpp:

(WebCore::BinaryPropertyListPlan::writeInteger):
(WebCore::BinaryPropertyListPlan::writeString):
(WebCore::BinaryPropertyListPlan::writeIntegerArray):

  • platform/graphics/blackberry/LayerTiler.cpp:

(WebCore::LayerTiler::addTileJob):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::findOrMakeClone):

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::revalidateTiles):

  • platform/graphics/ca/win/LayerChangesFlusher.cpp:

(WebCore::LayerChangesFlusher::flushPendingLayerChangesSoon):

  • platform/graphics/chromium/FontUtilsChromiumWin.cpp:

(WebCore::getDerivedFontData):

  • platform/graphics/chromium/cc/CCLayerAnimationController.cpp:

(WebCore::CCLayerAnimationController::startAnimationsWaitingForTargetAvailability):

  • platform/graphics/mac/ComplexTextControllerATSUI.cpp:

(WebCore::initializeATSUStyle):

  • platform/graphics/mac/SimpleFontDataCoreText.cpp:

(WebCore::SimpleFontData::getCFStringAttributes):

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::canRenderCombiningCharacterSequence):

  • platform/graphics/wince/FontPlatformData.cpp:

(WebCore::FixedSizeFontData::create):

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore::getStyleContext):

  • platform/mac/ThreadCheck.mm:

(WebCoreReportThreadViolation):

  • platform/network/HTTPHeaderMap.cpp:

(WebCore::HTTPHeaderMap::add):

  • platform/network/HTTPHeaderMap.h:

(HTTPHeaderMap):

  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::addHTTPHeaderField):

  • plugins/PluginDatabase.cpp:

(WebCore::PluginDatabase::add):
(WebCore::PluginDatabase::loadPersistentMetadataCache):

  • plugins/win/PluginDatabaseWin.cpp:

(WebCore::PluginDatabase::getPluginPathsInDirectories):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addPercentHeightDescendant):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::setLogicalWidthForTextRun):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::addDependencyOnFlowThread):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::setRenderBoxRegionInfo):

  • rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::RenderSVGResourceGradient::applyResource):

  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::applyResource):

  • storage/StorageMap.cpp:

(WebCore::StorageMap::setItem):
(WebCore::StorageMap::importItem):

  • svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::addPendingResource):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::setRequestHeaderInternal):

  • xml/XPathFunctions.cpp:

(WebCore::XPath::FunId::evaluate):

  • xml/XPathPath.cpp:

(WebCore::XPath::LocationPath::evaluate):

  • xml/XPathPredicate.cpp:

(WebCore::XPath::Union::evaluate):

Source/WebKit/chromium:

Update code to use AddResult instead of a pair.

  • src/WebHTTPLoadInfo.cpp:

(WebKit::addHeader):

  • src/WebURLResponse.cpp:

(WebKit::WebURLResponse::addHTTPHeaderField):

Source/WebKit/mac:

Update code to use AddResult instead of a pair.

  • Plugins/Hosted/NetscapePluginHostManager.mm:

(WebKit::NetscapePluginHostManager::hostForPlugin):

  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::methodsNamed):
(WebKit::ProxyInstance::fieldNamed):

  • WebCoreSupport/WebNotificationClient.mm:

(WebNotificationClient::show):

Source/WebKit/win:

Update code to use AddResult instead of a pair.

  • WebKitCOMAPI.cpp:

(classFactory):

Source/WebKit2:

Update code to use AddResult instead of a pair.

  • Platform/CoreIPC/ArgumentCoders.h:
  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::SyncMessageState::getOrCreate):

  • Shared/MutableDictionary.cpp:

(WebKit::MutableDictionary::add):
(WebKit::MutableDictionary::set):

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageDecoder::baseDecode):

  • Shared/mac/CommandLineMac.cpp:

(WebKit::CommandLine::parse):

  • UIProcess/API/mac/WKPrintingView.mm:

(pageDidDrawToPDF):

  • UIProcess/API/mac/WKView.mm:

(-[WKView validateUserInterfaceItem:]):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::addBackForwardItem):

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::getOrCreate):

  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:

(WebKit::InjectedBundleRangeHandle::getOrCreate):

  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::show):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::createWebPage):
(WebKit::WebProcess::webPageGroup):

Source/WTF:

Make HashTable<>::add() and derivate functions return an AddResult struct instead
of a pair. This struct contains contains 'iterator' and 'isNewEntry' members, that are
more readable at callsites than previous 'first' and 'second'.

  • wtf/HashCountedSet.h:

(HashCountedSet):
(WTF::::add):

  • wtf/HashMap.h:

(HashMap):
(WTF):
(WTF::::set):

  • wtf/HashSet.h:

(HashSet):
(WTF::::add):
(WTF):

  • wtf/HashTable.h:

(WTF::HashTableAddResult::HashTableAddResult):
(HashTableAddResult):
(WTF):
(HashTable):
(WTF::HashTable::add):
(WTF::::add):
(WTF::::addPassingHashCode):

  • wtf/ListHashSet.h:

(ListHashSet):
(WTF::::add):
(WTF::::insertBefore):

  • wtf/RefPtrHashMap.h:

(WTF):
(WTF::::set):

  • wtf/Spectrum.h:

(WTF::Spectrum::add):

  • wtf/WTFThreadData.cpp:

(JSC::IdentifierTable::add):

  • wtf/WTFThreadData.h:

(IdentifierTable):

  • wtf/text/AtomicString.cpp:

(WTF::addToStringTable):
(WTF::AtomicString::addSlowCase):

Tools:

Update code to use AddResult instead of a pair.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::evaluateScriptInIsolatedWorld):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::evaluateScriptInIsolatedWorld):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::evaluateScriptInIsolatedWorld):

11:35 Changeset [112554] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: improve window selection accuracy in vertical overview of timeline panel
https://bugs.webkit.org/show_bug.cgi?id=82625

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineVerticalOverview):
(WebInspector.TimelineVerticalOverview.prototype._renderBars): preserve actual padding used while rendering bars.
(WebInspector.TimelineVerticalOverview.prototype.getWindowTimes): account for outer and inter-bars padding when calculating bar offsets.

11:32 Changeset [112553] by commit-queue@webkit.org
  • 31 edits in trunk/Source

GEOLOCATION should be implemented as Page Supplement
https://bugs.webkit.org/show_bug.cgi?id=82228

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-03-29
Reviewed by Adam Barth.

Source/WebCore:

Geolocation now uses the Supplement interface instead of
keeping an instance variable on Page. This allows us to
remove all geolocation-related functions, variables, and
ifdefs out of Page and into Modules/geolocation/.

  • Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::stop):
(WebCore::Geolocation::lastPosition):
(WebCore::Geolocation::requestPermission):
(WebCore::Geolocation::startUpdating):
(WebCore::Geolocation::stopUpdating):

  • Modules/geolocation/Geolocation.h:

(WebCore):

  • Modules/geolocation/GeolocationController.cpp:

(WebCore::GeolocationController::supplementName):
(WebCore):
(WebCore::provideGeolocationTo):

  • Modules/geolocation/GeolocationController.h:

(GeolocationController):
(WebCore::GeolocationController::from):

  • WebCore.exp.in:
  • page/GeolocationClient.h:

(WebCore):
(GeolocationClient):

  • page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::PageClients::PageClients):

  • page/Page.h:

(WebCore):
(PageClients):
(Page):

Source/WebKit/blackberry:

Geolocation is now a Supplement in Page so the interface
has changed for setting up the page's geolocation client
initially and accessing the controller later.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::init):

  • WebCoreSupport/GeolocationControllerClientBlackBerry.cpp:

(GeolocationControllerClientBlackBerry::onLocationUpdate):
(GeolocationControllerClientBlackBerry::onLocationError):

  • WebKitSupport/DumpRenderTreeSupport.cpp:

(DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests):
(DumpRenderTreeSupport::resetGeolocationMock):
(DumpRenderTreeSupport::setMockGeolocationError):
(DumpRenderTreeSupport::setMockGeolocationPermission):
(DumpRenderTreeSupport::setMockGeolocationPosition):

Source/WebKit/chromium:

Geolocation is now a Supplement in Page so the interface
has changed for setting up the page's geolocation client
initially and accessing the controller later.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

Source/WebKit/gtk:

Geolocation is now a Supplement in Page so the interface
has changed for setting up the page's geolocation client
initially and accessing the controller later.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::resetGeolocationClientMock):
(DumpRenderTreeSupportGtk::setMockGeolocationPermission):
(DumpRenderTreeSupportGtk::setMockGeolocationPosition):
(DumpRenderTreeSupportGtk::setMockGeolocationError):
(DumpRenderTreeSupportGtk::numberOfPendingGeolocationPermissionRequests):

  • WebCoreSupport/GeolocationClientGtk.cpp:

(WebKit::GeolocationClient::updatePosition):
(WebKit::GeolocationClient::errorOccured):

  • webkit/webkitwebview.cpp:

(webkit_web_view_init):

Source/WebKit/mac:

Geolocation is now a Supplement in Page so the interface
has changed for setting up the page's geolocation client
initially and accessing the controller later.

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _geolocationDidChangePosition:]):
(-[WebView _geolocationDidFailWithError:]):

Source/WebKit/qt:

Geolocation is now a Supplement in Page so the interface
has changed for setting up the page's geolocation client
initially and accessing the controller later.

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::resetGeolocationMock):
(DumpRenderTreeSupportQt::setMockGeolocationPermission):
(DumpRenderTreeSupportQt::setMockGeolocationPosition):
(DumpRenderTreeSupportQt::setMockGeolocationError):
(DumpRenderTreeSupportQt::numberOfPendingGeolocationPermissionRequests):

  • WebCoreSupport/GeolocationClientQt.cpp:

(WebCore::GeolocationClientQt::positionUpdated):
(WebCore::GeolocationClientQt::startUpdating):

Source/WebKit/win:

Geolocation is now a Supplement in Page so the interface
has changed for setting up the page's geolocation client
initially and accessing the controller later.

  • WebView.cpp:

(WebView::initWithFrame):
(WebView::geolocationDidChangePosition):
(WebView::geolocationDidFailWithError):

Source/WebKit2:

Geolocation is now a Supplement in Page so the interface
has changed for setting up the page's geolocation client
initially and accessing the controller later.

  • WebProcess/Geolocation/WebGeolocationManager.cpp:

(WebKit::WebGeolocationManager::didChangePosition):
(WebKit::WebGeolocationManager::didFailToDeterminePosition):

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setGeoLocationPermission):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

11:27 Changeset [112552] by loislo@chromium.org
  • 2 edits in trunk/Tools

Web Inspector: chromium: DRT --no-timeout option doesn't work.
https://bugs.webkit.org/show_bug.cgi?id=82608

Initial value for m_timeout was initialized in constructor and was overwritten in DRT::main.
This was broken by r112354 and the sequence became opposite.

Reviewed by Yury Semikhatsky.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::initialize):

11:24 Changeset [112551] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Sync up WebKit TraceEvent.h with chromium trace_event.h
https://bugs.webkit.org/show_bug.cgi?id=82527

Patch by John Bates <jbates@google.com> on 2012-03-29
Reviewed by James Robinson.

  • platform/chromium/TraceEvent.h:
11:18 Changeset [112550] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk/Source/WebKit/chromium

[chromium] Split off tiled layer constructs for unit tests into a common header
https://bugs.webkit.org/show_bug.cgi?id=82425

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-29
Reviewed by Adrienne Walker.

  • WebKit.gypi:
  • tests/CCTiledLayerTestCommon.cpp: Added.

(WebKitTests):
(WebKitTests::FakeLayerTextureUpdater::Texture::Texture):
(WebKitTests::FakeLayerTextureUpdater::Texture::~Texture):
(WebKitTests::FakeLayerTextureUpdater::Texture::updateRect):
(WebKitTests::FakeLayerTextureUpdater::Texture::prepareRect):
(WebKitTests::FakeLayerTextureUpdater::FakeLayerTextureUpdater):
(WebKitTests::FakeLayerTextureUpdater::~FakeLayerTextureUpdater):
(WebKitTests::FakeLayerTextureUpdater::prepareToUpdate):
(WebKitTests::FakeLayerTextureUpdater::setRectToInvalidate):
(WebKitTests::FakeLayerTextureUpdater::createTexture):
(WebKitTests::FakeCCTiledLayerImpl::FakeCCTiledLayerImpl):
(WebKitTests::FakeCCTiledLayerImpl::~FakeCCTiledLayerImpl):
(WebKitTests::FakeTiledLayerChromium::FakeTiledLayerChromium):
(WebKitTests::FakeTiledLayerChromium::~FakeTiledLayerChromium):
(WebKitTests::FakeTiledLayerChromium::setNeedsDisplayRect):
(WebKitTests::FakeTiledLayerChromium::paintContentsIfDirty):
(WebKitTests::FakeTiledLayerWithScaledBounds::FakeTiledLayerWithScaledBounds):
(WebKitTests::FakeCCTextureUpdater::FakeCCTextureUpdater):

  • tests/CCTiledLayerTestCommon.h: Added.

(WebKitTests):
(FakeLayerTextureUpdater):
(Texture):
(WebKitTests::FakeLayerTextureUpdater::sampledTexelFormat):
(WebKitTests::FakeLayerTextureUpdater::lastUpdateRect):
(WebKitTests::FakeLayerTextureUpdater::prepareCount):
(WebKitTests::FakeLayerTextureUpdater::clearPrepareCount):
(WebKitTests::FakeLayerTextureUpdater::updateCount):
(WebKitTests::FakeLayerTextureUpdater::clearUpdateCount):
(WebKitTests::FakeLayerTextureUpdater::updateRect):
(WebKitTests::FakeLayerTextureUpdater::prepareRectCount):
(WebKitTests::FakeLayerTextureUpdater::clearPrepareRectCount):
(WebKitTests::FakeLayerTextureUpdater::prepareRect):
(WebKitTests::FakeLayerTextureUpdater::setOpaquePaintRect):
(FakeCCTiledLayerImpl):
(FakeTiledLayerChromium):
(WebKitTests::FakeTiledLayerChromium::tileSize):
(WebKitTests::FakeTiledLayerChromium::lastNeedsDisplayRect):
(WebKitTests::FakeTiledLayerChromium::textureManager):
(WebKitTests::FakeTiledLayerChromium::fakeLayerTextureUpdater):
(WebKitTests::FakeTiledLayerChromium::updateRect):
(WebKitTests::FakeTiledLayerChromium::textureUpdater):
(WebKitTests::FakeTiledLayerChromium::createTextureUpdaterIfNeeded):
(FakeTiledLayerWithScaledBounds):
(WebKitTests::FakeTiledLayerWithScaledBounds::setContentBounds):
(WebKitTests::FakeTiledLayerWithScaledBounds::contentBounds):
(FakeTextureAllocator):
(WebKitTests::FakeTextureAllocator::createTexture):
(WebKitTests::FakeTextureAllocator::deleteTexture):
(FakeTextureCopier):
(WebKitTests::FakeTextureCopier::copyTexture):
(FakeCCTextureUpdater):
(WebKitTests::FakeCCTextureUpdater::textureAllocator):

  • tests/TextureManagerTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:
11:17 Changeset [112549] by pfeldman@chromium.org
  • 3 edits
    5 adds in trunk

Web Inspector: subtree disapears from <iframe> after loading
https://bugs.webkit.org/show_bug.cgi?id=76552

Reviewed by Yury Semikhatsky.

Source/WebCore:

The problem was that content document subtree was not unbound upon iframe re-push.
Upon owner element refresh content document was not sent to the frontend
since backend assumed that front-end has already had the up-to-date version.

Test: inspector/elements/iframe-load-event.html

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::loadEventFired):

LayoutTests:

  • inspector/elements/iframe-load-event-expected.txt: Added.
  • inspector/elements/iframe-load-event.html: Added.
  • inspector/elements/resources/iframe-load-event-iframe-1.html: Added.
  • inspector/elements/resources/iframe-load-event-iframe-2.html: Added.
  • inspector/elements/resources/iframe-load-event-iframe.js: Added.

(loadSecondIFrame):
(test.step1.nodeInserted):
(test.step1):
(test.step2):
(test):

11:14 Changeset [112548] by commit-queue@webkit.org
  • 7 edits
    1 add in trunk/Source

[chromium] Remove unneeded code+fixmes from CCOcclusionTracker
https://bugs.webkit.org/show_bug.cgi?id=82380

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-29
Reviewed by Adrienne Walker.

Source/WebCore:

The current occlusion was exposed on the occlusion tracker for the
transition over to culling 2.0 which has landed, so we can remove
it now. It still had one use in unit tests which is moved to a
test subclass.

Above test subclass already existed in the occlusion tracker tests,
so pulled it out to a common file CCOcclusionTrackerTestCommon.h
so that other unit tests can use it to get at occlusion internals.

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore):

  • platform/graphics/chromium/cc/CCOcclusionTracker.h:

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCLayerTreeHostTest.cpp:

(WTF::TestLayerChromium::paintContentsIfDirty):

  • tests/CCOcclusionTrackerTest.cpp:

(WebKitTests::TestCCOcclusionTrackerWithScissor::TestCCOcclusionTrackerWithScissor):
(WebKitTests::CCOcclusionTrackerTestIdentityTransforms::runMyTest):
(WebKitTests::CCOcclusionTrackerTestRotatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestTranslatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestChildInRotatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
(WebKitTests::CCOcclusionTrackerTestFilters::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerScissorRectOutsideChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestScreenScissorRectOutsideChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerScissorRectOverChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestScreenScissorRectOverChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerScissorRectPartlyOverChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestScreenScissorRectPartlyOverChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerScissorRectOverNothing::runMyTest):
(WebKitTests::CCOcclusionTrackerTestScreenScissorRectOverNothing::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerScissorRectForLayerOffOrigin::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOpaqueContentsRegionEmpty::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty::runMyTest):
(WebKitTests::CCOcclusionTrackerTest3dTransform::runMyTest):
(WebKitTests::CCOcclusionTrackerTestPerspectiveTransform::runMyTest):
(WebKitTests::CCOcclusionTrackerTestPerspectiveTransformBehindCamera::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationTranslateOnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesToParent::runMyTest):

  • tests/CCOcclusionTrackerTestCommon.h: Added.

(WebKitTests):
(TestCCOcclusionTrackerBase):
(WebKitTests::TestCCOcclusionTrackerBase::TestCCOcclusionTrackerBase):
(WebKitTests::TestCCOcclusionTrackerBase::occlusionInScreenSpace):
(WebKitTests::TestCCOcclusionTrackerBase::occlusionInTargetSurface):
(WebKitTests::TestCCOcclusionTrackerBase::setOcclusionInScreenSpace):
(WebKitTests::TestCCOcclusionTrackerBase::setOcclusionInTargetSurface):

11:11 Changeset [112547] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

<http://webkit.org/b/82558> Toggling <input type="range"> readonly or disabled state while active breaks all click events

Source/WebCore:

Test: fast/forms/range/range-drag-when-toggled-disabled.html

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-03-29
Reviewed by Kent Tamura.

  • html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::defaultEventHandler):
A slider can toggle its readonly or disabled state while in the middle
of dragging, in those cases we should cancel the drag and perform cleanup.

LayoutTests:

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-03-29
Reviewed by Kent Tamura.

  • fast/forms/range/range-drag-when-toggled-disabled-expected.txt: Added.
  • fast/forms/range/range-drag-when-toggled-disabled.html: Added.
11:03 Changeset [112546] by adamk@chromium.org
  • 2 edits in trunk/Source/WebCore

Factor out common post-insertion logic in ContainerNode
https://bugs.webkit.org/show_bug.cgi?id=82544

Reviewed by Ryosuke Niwa.

appendChild, insertBefore, and replaceChild all share a great deal of logic.
This patch factors out the "post-insertion" logic that deals with
notifying parents that their children changed and notifying children
that they've been added to the tree.

Besides reducing code duplication, this is in preparation for moving
this post-insertion notification later in the insertion process.

No new tests, no change in behavior.

  • dom/ContainerNode.cpp:

(WebCore):
(WebCore::ContainerNode::insertBefore): Factor out shared logic, remove unnecessary "prev" variable.
(WebCore::ContainerNode::replaceChild): ditto.
(WebCore::ContainerNode::appendChild): ditto.
(WebCore::updateTreeAfterInsertion): New helper method encapsulating shared logic.

10:52 Changeset [112545] by enrica@apple.com
  • 2 edits in trunk/LayoutTests

Updating test_expectations with new failures after r112484.
The failing tests need a new baseline.
This is tracked by https://bugs.webkit.org/show_bug.cgi?id=82626

  • platform/mac/test_expectations.txt:
10:16 Changeset [112544] by tony@chromium.org
  • 10 edits
    4 adds in trunk

Need to implement flex-line-pack
https://bugs.webkit.org/show_bug.cgi?id=70794

Reviewed by Ojan Vafai.

Source/WebCore:

Tests: css3/flexbox/multiline-line-pack-horizontal-column.html

css3/flexbox/multiline-line-pack.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::repositionLogicalHeightDependentFlexItems):
(WebCore::initialLinePackingOffset): Similar to initialPackingOffset.
(WebCore):
(WebCore::linePackingSpaceBetweenChildren): Similar to packingSpaceBetweenChildren.
(WebCore::RenderFlexibleBox::packFlexLines): Move lines based on flex-line-pack.

Note that we don't need to relayout on stretch because
alignChildren will do that for us (only auto size needs stretching).

(WebCore::RenderFlexibleBox::flipForWrapReverse): Pull out the initial

cross axis offset before calling packFlexLines because we can
move the the line contexts.

  • rendering/RenderFlexibleBox.h:

LayoutTests:

Updated the old multiline tests to have -webkit-flex-line-pack: start,
which was the previous default behavior. The correct default behavior
is stretch.

  • css3/flexbox/multiline-align.html:
  • css3/flexbox/multiline-column-auto.html:
  • css3/flexbox/multiline-line-pack-expected.txt: Added.
  • css3/flexbox/multiline-line-pack-horizontal-column-expected.txt: Added.
  • css3/flexbox/multiline-line-pack-horizontal-column.html: Added.
  • css3/flexbox/multiline-line-pack.html: Added.
  • css3/flexbox/multiline-pack.html:
  • css3/flexbox/multiline-reverse-wrap-overflow.html:
  • css3/flexbox/multiline-shrink-to-fit.html:
  • css3/flexbox/multiline.html:
10:03 Changeset [112543] by kling@webkit.org
  • 2 edits in trunk/Source/WTF

String: Subscript operator shouldn't force conversion to 16-bit characters.
<http://webkit.org/b/82613>

Reviewed by Anders Carlsson.

Forward String::operator[] to StringImpl::operator[] instead of indexing into characters().
This avoid implicit conversion of 8-bit strings to 16-bit, and as an example, reduces memory
usage on http://www.allthingsd.com/ by 360kB.

  • wtf/text/WTFString.h:

(WTF::String::operator[]):

09:54 Changeset [112542] by krit@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Introduce CSSParserMode in all classes
https://bugs.webkit.org/show_bug.cgi?id=82335

Unreviewed build fix.

  • src/WebDocument.cpp:

(WebKit::WebDocument::insertUserStyleSheet):

09:45 Changeset [112541] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: SnippetsScriptMapping should process existing snippets on load.
https://bugs.webkit.org/show_bug.cgi?id=82619

Reviewed by Pavel Feldman.

SnippetsScriptMapping now loads existing snippets on creation.
Otherwise scripts panel shows snippets created during current session only.
Drive-by ScriptsNavigator closure compilation fix.

  • inspector/front-end/SnippetsModel.js:

(WebInspector.SnippetsModel.prototype.set get snippets):
(WebInspector.SnippetsScriptMapping):
(WebInspector.SnippetsScriptMapping.prototype._handleSnippetAdded):
(WebInspector.SnippetsScriptMapping.prototype._snippetAdded):

09:25 Changeset [112540] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: check more likely condition first in HeapSnapshot._buildAggregates
https://bugs.webkit.org/show_bug.cgi?id=82621

Reviewed by Pavel Feldman.

  • inspector/front-end/HeapSnapshot.js: selfSize === 0 is quite rare, moving this condition

to the first place saves 1 of 6 secs on the heap profiler perf test.
(WebInspector.HeapSnapshot.prototype._buildAggregates):
(WebInspector.HeapSnapshot.prototype._buildDominatedNodes): root node is always the first
one and is the only one that doesn't have dominator, so we may start iterating nodes from
the second node and avoid additional check in the loop.

09:22 Changeset [112539] by pfeldman@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: "go to the previous panel" shortcut is painful to maintain
https://bugs.webkit.org/show_bug.cgi?id=82602

Reviewed by Vsevolod Vlasov.

Present go to previous panel shortcut "Cmd - Left" is painful to support since we have
more and more free flow editing capabilities (where Cmd - Left is handled by the editor).
Remaping it to Cmd - Option - [ (]) / (Ctrl - Alt - [ (]) ).

Drive-by: de-capitalize captions from the settings panel.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._registerShortcuts):

  • inspector/front-end/InspectorView.js:

(WebInspector.InspectorView.prototype._keyDown):

  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._registerShortcuts):
(WebInspector.TimelinePanel.prototype._contextMenu):

  • inspector/front-end/inspector.js:

(WebInspector._registerShortcuts):

09:19 Changeset [112538] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r112531.
http://trac.webkit.org/changeset/112531
https://bugs.webkit.org/show_bug.cgi?id=82616

Broke timeline overview selection

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewWindow):

09:12 Changeset [112537] by krit@webkit.org
  • 34 edits in trunk/Source

Introduce CSSParserMode in all classes
https://bugs.webkit.org/show_bug.cgi?id=82335

Source/WebCore:

Reviewed by Ryosuke Niwa.

Introduce the new CSSParserMode enum to more classes. SVG classes make use of SVGAttributeMode for CSS parsing already.
But SVGAttributeMode does not differ from CSSQuirksMode at the moment. This will change with a followup patch on bug 46112.

No new tests. No change of functionality. Everything gets covered by existing tests.

  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::setCSSStyleSheet):

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::insertRule):

  • css/CSSParser.cpp: Move private functions away from strict boolean and make use of CSSParserMode instead.

(WebCore):
(WebCore::parseColorValue):
(WebCore::parseSimpleLengthValue):
(WebCore::CSSParser::parseFontFaceValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseColor):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createKeyframeRule):

  • css/CSSParser.h: Removed constructor with boolean argument. We just use the CSSParserMode enum now.

(CSSParser):

  • css/CSSParserMode.h:

(strictToCSSParserMode): New helper function to convert boolean to CSSParserMode.
(isStrictParserMode): Helper function that returns true if argument is CSSStrictMode.

  • css/CSSRule.h:

(WebCore::CSSRule::cssParserMode): Renamed useStrictParsing to cssParserMode since it returns CSSParserMode instead of a boolean now.

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::CSSStyleSheet):
(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::parseString):
(WebCore::CSSStyleSheet::parseStringAtLine):

  • css/CSSStyleSheet.h:

(CSSStyleSheet):
(WebCore::CSSStyleSheet::setCSSParserMode): Renamed setStrictParsing to setCSSParserMode since we set an enum now.
(WebCore::CSSStyleSheet::cssParserMode): Renamed useStrictParsing to cssParserMode since it returns CSSParserMode instead of a boolean now.

  • css/MediaList.cpp:

(WebCore::MediaQuerySet::parse):
(WebCore::MediaQuerySet::add):
(WebCore::MediaQuerySet::remove):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet::parseDeclaration):

  • css/StylePropertySet.h: Use unsigned member variables to store the parser mode.

(WebCore::StylePropertySet::create):
(WebCore::StylePropertySet::setCSSParserMode): Renamed setStrictParsing to setCSSParserMode since we get an enum now. This gets converted to unsigned internally.
(WebCore::StylePropertySet::cssParserMode): Renamed useStrictParsing to cssParserMode since it returns CSSParserMode instead of a boolean now.
(StylePropertySet):

  • css/StyleSheet.h:

(StyleSheet):

  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::insertRule):

  • css/WebKitCSSMatrix.cpp:

(WebCore::WebKitCSSMatrix::setMatrixValue):

  • dom/Document.cpp:

(WebCore::Document::webkitGetFlowByName):
(WebCore::Document::pageUserSheet):
(WebCore::Document::pageGroupUserSheets):

  • dom/Element.cpp:

(WebCore::Element::webkitMatchesSelector):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::ensureInlineStyle):
(WebCore::ElementAttributeData::ensureMutableInlineStyle):
(WebCore::ElementAttributeData::updateInlineStyleAvoidingMutation):

  • dom/Node.cpp:

(WebCore::Node::querySelector):
(WebCore::Node::querySelectorAll):

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::parseStyleSheet):

  • dom/StyleElement.cpp:

(WebCore::StyleElement::createSheet):

  • html/HTMLElement.cpp:

(WebCore::StyledElement::copyNonAttributeProperties):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::setCSSStyleSheet):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setFont):

  • html/shadow/ContentSelectorQuery.cpp:

(WebCore::ContentSelectorQuery::ContentSelectorQuery):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::reparseStyleSheet):

  • svg/SVGElementRareData.h:

(WebCore::SVGElementRareData::ensureAnimatedSMILStyleProperties):

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::SVGFontFaceElement):

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::getPresentationAttribute):

  • xml/XSLStyleSheet.h:

(XSLStyleSheet):

  • xml/XSLStyleSheetLibxslt.cpp:

(WebCore::XSLStyleSheet::parseString):

  • xml/XSLStyleSheetQt.cpp:

(WebCore::XSLStyleSheet::parseString):

Source/WebKit/chromium:

Use CSSParserMode for setting the parsing mode on parseValue.

  • src/WebDocument.cpp:

(WebKit::WebDocument::insertUserStyleSheet):

09:11 Changeset [112536] by paroga@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Build fix for !ENABLE(YARR_JIT) after r112454.

  • runtime/RegExp.cpp:

(JSC::RegExp::invalidateCode):

08:54 Changeset [112535] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the error type in JSAudioBufferSourceNodeCustom to pass layout test.
https://bugs.webkit.org/show_bug.cgi?id=81639

Patch by Sanghyun Park <sh919.park@samsung.com> on 2012-03-29
Reviewed by Eric Carlson.

Test : LayoutTest/webaudio/audiobuffersource-channels.html

  • bindings/js/JSAudioBufferSourceNodeCustom.cpp:
08:28 Changeset [112534] by ossy@webkit.org
  • 5 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r112514. Fix the accidental r112532 fix.

  • platform/qt-5.0/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/qt-5.0/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
  • platform/qt-5.0/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/qt-5.0/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
08:23 Changeset [112533] by vsevik@chromium.org
  • 6 edits in trunk

Web Inspector: Existing UISourceCode should be loaded on scripts panel creation/reset.
https://bugs.webkit.org/show_bug.cgi?id=82614

Reviewed by Pavel Feldman.

Source/WebCore:

UISourceCode are now loaded from DebuggerPresentationModel on scripts panel creation/reset.
This is needed to show snippets that are loaded before scripts panel creation and are not removed on navigation.

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._handleUISourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._loadUISourceCodes):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._reset):

  • inspector/front-end/SnippetsModel.js:

(WebInspector.SnippetsScriptMapping.prototype.uiSourceCodeList):

LayoutTests:

  • inspector/debugger/scripts-panel-expected.txt:
  • inspector/debugger/scripts-panel.html:
07:43 Changeset [112532] by ossy@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

[Qt] Unreviewed gardening after r112514. Add Qt5 specific expected files.

  • platform/qt-5.0/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png: Added.
  • platform/qt-5.0/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt: Added.
  • platform/qt-5.0/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/qt-5.0/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
07:43 Changeset [112531] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: on a single click in Timeline overview, make a minimal selection centered around cursor
https://bugs.webkit.org/show_bug.cgi?id=82616

Reviewed by Pavel Feldman.

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewWindow): Explicitly handle single click on overview by creating a minimal window around cursor.
(WebInspector.TimelineOverviewWindow.prototype._resizeWindowMinimum):

07:36 WebKitEFLLayoutTest edited by dominik.rottsches@intel.com
edit on ENABLE_DRT (diff)
07:35 WebKitEFLLayoutTest edited by dominik.rottsches@intel.com
ENABLE_DRT info (diff)
07:33 BuildBot edited by dominik.rottsches@intel.com
changing indentation (diff)
07:32 BuildBot edited by dominik.rottsches@intel.com
EFL buildbot gray hair avoidance (diff)
07:31 Changeset [112530] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unavailable pre-processor macro in non-Qt environments
https://bugs.webkit.org/show_bug.cgi?id=82042

Patch by Víctor Manuel Jáquez Leal <vjaquez@igalia.com> on 2012-03-29
Reviewed by Simon Hausmann.

This patch removes the use of the macro QT_VERSION_CHECK() because, in
non-Qt environments, the pre-processors raises an error. Instead of
calling the macro to generate the version number, the version is
expressed directly.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(SharedGLData): remove pre-processor macro for Qt version check.

07:06 Changeset [112529] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: event details popover in Timeline panel displays invalid time offset
https://bugs.webkit.org/show_bug.cgi?id=82611

Reviewed by Pavel Feldman.

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.prototype.addRecord): use time in seconds, not raw model time for minimumRecordTime.

06:44 Changeset [112528] by caseq@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: use canvas to render bars in "vertical overview" mode
https://bugs.webkit.org/show_bug.cgi?id=82606

Reviewed by Pavel Feldman.

  • inspector/front-end/TimelineOverviewPane.js: Use canvas instead of DOM for rendering vertical overview bars.

(WebInspector.TimelineVerticalOverview):
(WebInspector.TimelineVerticalOverview.prototype.update):
(WebInspector.TimelineVerticalOverview.prototype._renderBars):
(WebInspector.TimelineVerticalOverview.prototype._renderBar):
(WebInspector.TimelineVerticalOverview.prototype.getWindowTimes):

  • inspector/front-end/timelinePanel.css: Drop styles previously used for DOM-based vertical overview rendering.

(.timeline-vertical-overview-bars):

06:24 Changeset [112527] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: timeline overview window selection is not reset upon clear/record
https://bugs.webkit.org/show_bug.cgi?id=82603

Reviewed by Pavel Feldman.

  • TimelineOverviewPane.reset() -> _reset();
  • perform update() from reset();
  • perform reset() upon RecordsCleared event from the model.
  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype._reset):
(WebInspector.TimelineVerticalOverview):
(WebInspector.TimelineVerticalOverview.prototype.update):
(WebInspector.TimelineVerticalOverview.prototype._renderBars):
(WebInspector.TimelineVerticalOverview.prototype._renderBar):
(WebInspector.TimelineVerticalOverview.prototype.getWindowTimes):

  • inspector/front-end/timelinePanel.css:

(.timeline-vertical-overview-bars):

05:53 Changeset [112526] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk

Remove redundant updateViewportArguments() call when page is restored from page cache.
https://bugs.webkit.org/show_bug.cgi?id=82500

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-03-29
Reviewed by Kenneth Rohde Christiansen.

.:

Add manual test for history navigation with viewport width check.

  • ManualTests/viewport-width-test-after-history-navigation.html: Added.

Source/WebCore:

Document::updateViewportArguments() is called twice, while restoring a page from page cache.
First, it is called when the document is set on the mainframe and later, it is called
when page cache finished the restoration. Since viewport arguments don't change between
the 2 calls, it's safe to remove the second.

Manual test added. Viewport value updates heavily depend on UI process code.

  • dom/Document.cpp:

(WebCore::Document::documentDidResumeFromPageCache):

05:45 Changeset [112525] by charles.wei@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Add Internal test support for blackberry porting.
https://bugs.webkit.org/show_bug.cgi?id=82597

Reviewed by Rob Buis.

No new tests, just the build system enhancement for BlackBerry porting.

  • UseJSC.cmake:
05:40 Changeset [112524] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Diverging test results on 32/64 bit architectures
https://bugs.webkit.org/show_bug.cgi?id=82601

  • platform/qt/Skipped: Skip the remaining 6 failing test.
05:38 Changeset [112523] by yurys@chromium.org
  • 8 edits in trunk

Web Inspector: switch heap profiler front-end to separate storage of nodes and edges
https://bugs.webkit.org/show_bug.cgi?id=82453

PerformanceTests:

Updated heap profiler performance test after heap profiler front-end
changes.

Reviewed by Pavel Feldman.

  • inspector/detailed-heapshots-smoke-test.html:

Source/WebCore:

When heap snapshot is completely loaded move nodes and containment edges
into two separate arrays. This way we don't need _nodeIndex and _nodePosition
maps to go from node offset inside the raw snapshot to its index and back, instead
we may just divide node offset by the number of node fields to get node index. After
the nodes and containment edges are separated original array (_nodes) is dropped.
All front-end code was switched to the new representation.

Reviewed by Pavel Feldman.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotRetainerEdge):
(WebInspector.HeapSnapshotRetainerEdge.prototype.clone):
(WebInspector.HeapSnapshotRetainerEdge.prototype.set edgeIndex):
(WebInspector.HeapSnapshotRetainerEdge.prototype.get _edge):
(WebInspector.HeapSnapshotRetainerEdgeIterator.prototype.hasNext):
(WebInspector.HeapSnapshotNode.prototype.get edgesCount):
(WebInspector.HeapSnapshotNode.prototype.get rawEdges):
(WebInspector.HeapSnapshotNode.prototype.get retainers):
(WebInspector.HeapSnapshotNode.prototype.get _nodes):
(WebInspector.HeapSnapshotNode.prototype._firstEdgeIndex):
(WebInspector.HeapSnapshotNode.prototype._afterLastEdgeIndex):
(WebInspector.HeapSnapshotNode.prototype.get _nextNodeIndex):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype._splitNodesAndContainmentEdges):
(WebInspector.HeapSnapshot.prototype._createOnlyNodesArray):
(WebInspector.HeapSnapshot.prototype._createContainmentEdgesArray):
(WebInspector.HeapSnapshot.prototype._buildRetainers):
(WebInspector.HeapSnapshot.prototype.dispose):
(WebInspector.HeapSnapshot.prototype.get maxNodeId):
(WebInspector.HeapSnapshot.prototype._calculateObjectToWindowDistance):
(WebInspector.HeapSnapshot.prototype._bfs):
(WebInspector.HeapSnapshot.prototype._buildDominatedNodes):
(WebInspector.HeapSnapshot.prototype._getDominatedIndex):
(WebInspector.HeapSnapshot.prototype._markInvisibleEdges):
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):

LayoutTests:

Updated heap profiler test after switching heap profiler front-end
to the new representation of nodes and edges.

Reviewed by Pavel Feldman.

  • inspector/profiler/heap-snapshot-expected.txt:
  • inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockObject):

  • inspector/profiler/heap-snapshot.html:
05:33 Changeset [112522] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip the new fast/dom/shadow tests because ENABLE(SHADOW_DOM) is disabled.

  • platform/qt/Skipped: Skip the failing tests
05:31 Changeset [112521] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Add m_targetType to WorkerScriptLoader
https://bugs.webkit.org/show_bug.cgi?id=82574

Reviewed by Rob Buis.

Just as Chromium porting blackberry porting is using m_targetType also.

  • workers/WorkerScriptLoader.h:

(WorkerScriptLoader):

05:02 Changeset [112520] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Add an empty implementation of GraphicsContext3D::setErrorMessageCallback
https://bugs.webkit.org/show_bug.cgi?id=82570

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-03-29
Reviewed by Rob Buis.

No new tests, no change in functionality.

  • platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:

(WebCore::GraphicsContext3D::setErrorMessageCallback): Add an empty implementation.
(WebCore):

04:56 Changeset [112519] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Clean up ImageBufferData
https://bugs.webkit.org/show_bug.cgi?id=82444

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-03-29
Reviewed by Rob Buis.

No behavior changes, no new tests.

  • platform/graphics/blackberry/skia/ImageBufferDataSkia.h:

(ImageBufferData): Remove unused member variable m_buffer and change the type
of m_platformLayer from LayerWebKitThread to CanvasLayerWebKitThread.

04:47 Changeset [112518] by shinyak@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

Write a test for <base> and <link> are inert in ShadowDOM.
https://bugs.webkit.org/show_bug.cgi?id=82430

Reviewed by Dimitri Glazkov.

This test checks adding <base> or <link> in shadow root will not affect the
elements outside and inside the shadow tree.

  • fast/dom/shadow/base-in-shadow-tree-expected.txt: Added.
  • fast/dom/shadow/base-in-shadow-tree.html: Added.
  • fast/dom/shadow/link-in-shadow-tree-expected.txt: Added.
  • fast/dom/shadow/link-in-shadow-tree.html: Added.
  • fast/dom/shadow/resources/link-in-shadow-style.css: Added.
03:25 Changeset [112517] by tommyw@google.com
  • 2 edits in trunk/Source/WebKit/chromium

MediaStream API: Adding better comments for the WebRTC methods in WebKitPlatformSupport.h
https://bugs.webkit.org/show_bug.cgi?id=82588

Reviewed by Adam Barth.

  • public/platform/WebKitPlatformSupport.h:

(WebKitPlatformSupport):

03:17 Changeset [112516] by antti@apple.com
  • 13 edits in trunk/Source/WebCore

Split WebKitCSSKeyframeRule into internal and CSSOM types
https://bugs.webkit.org/show_bug.cgi?id=82490

Reviewed by Andreas Kling.

WebKitCSSKeyframeRule is a CSSOM type and should not be used internally.

  • Add StyleKeyframe as the internal data structure for keyframes.
  • WebKitCSSKeyframeRule becomes a wrapper for StyleKeyframe.
  • Use StyleKeyframe internally so WebKitCSSKeyframeRules are created on CSSOM access only.
  • css/CSSGrammar.y:


Use StyleKeyframes instead of WebKitCSSKeyframeRules.


  • css/CSSMediaRule.h:

(CSSMediaRule):
(WebCore::CSSMediaRule::length):
(WebCore::CSSMediaRule::item):

Adapt to LiveCSSRuleList changes.


  • css/CSSParser.cpp:

(WebCore::CSSParser::parseKeyframeRule):
(WebCore::CSSParser::createKeyframe):

  • css/CSSParser.h:

(WebCore):
(CSSParser):

Construct StyleKeyframes.


  • css/CSSRuleList.h:

(WebCore::LiveCSSRuleList::length):
(WebCore::LiveCSSRuleList::item):

Make LiveCSSRuleList call rule item()/length() to avoid accessor duplication.


  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • css/CSSStyleSelector.h:

(CSSStyleSelector):

  • css/WebKitCSSKeyframeRule.cpp:


Use StyleKeyframe.
Make 0% and 100% keyframes static.


(WebCore):
(WebCore::StyleKeyframe::setProperties):
(WebCore::StyleKeyframe::parseKeyString):
(WebCore::StyleKeyframe::cssText):
(WebCore::WebKitCSSKeyframeRule::WebKitCSSKeyframeRule):
(WebCore::WebKitCSSKeyframeRule::~WebKitCSSKeyframeRule):
(WebCore::WebKitCSSKeyframeRule::style):

  • css/WebKitCSSKeyframeRule.h:

(WebCore):
(WebCore::StyleKeyframe::create):
(WebCore::StyleKeyframe::keyText):
(WebCore::StyleKeyframe::setKeyText):
(StyleKeyframe):
(WebCore::StyleKeyframe::properties):
(WebCore::StyleKeyframe::StyleKeyframe):
(WebKitCSSKeyframeRule):
(WebCore::WebKitCSSKeyframeRule::keyText):
(WebCore::WebKitCSSKeyframeRule::setKeyText):
(WebCore::WebKitCSSKeyframeRule::cssText):

Split to internal and CSSOM wrapper type. The wrapper refs StyleKeyframe.


  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::~WebKitCSSKeyframesRule):
(WebCore::WebKitCSSKeyframesRule::parserAppendKeyframe):
(WebCore::WebKitCSSKeyframesRule::insertRule):
(WebCore::WebKitCSSKeyframesRule::deleteRule):
(WebCore::WebKitCSSKeyframesRule::findRule):
(WebCore::WebKitCSSKeyframesRule::findKeyframeIndex):
(WebCore::WebKitCSSKeyframesRule::cssText):
(WebCore):
(WebCore::WebKitCSSKeyframesRule::item):

  • css/WebKitCSSKeyframesRule.h:

(WebCore):
(WebCore::WebKitCSSKeyframesRule::keyframes):
(WebKitCSSKeyframesRule):
(WebCore::WebKitCSSKeyframesRule::length):

Keep StyleKeyframes and the wrappers (WebKitCSSKeyframeRules) in separate vectors.
Construct the wrapper vector and wrappers themselves on demand.
Keep the vectors in sync during mutations.


  • css/WebKitCSSRegionRule.h:


Adapt to LiveCSSRuleList changes.

03:14 Changeset [112515] by zeno.albisser@nokia.com
  • 7 edits
    2 adds in trunk

Fieldset disabled attribute does not work.
https://bugs.webkit.org/show_bug.cgi?id=58837

Source/WebCore:

Make HTMLFormControlElements inherit the disabled state
from HTMLFieldSetElement ancestors. Subordinates of the
first HTMLLegendElement in a fieldset will never be disabled.

Patch by Zeno Albisser <zeno@webkit.org>

Test: fast/forms/fieldset-disabled.html

Reviewed by Kent Tamura.

  • html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::disabledAttributeChanged):
(WebCore):
(WebCore::HTMLFieldSetElement::legend):

  • html/HTMLFieldSetElement.h:

(HTMLFieldSetElement):

  • html/HTMLFieldSetElement.idl:
  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::HTMLFormControlElement):
(WebCore::HTMLFormControlElement::updateFieldSetAndLegendAncestor):
(WebCore):
(WebCore::HTMLFormControlElement::parseAttribute):
(WebCore::HTMLFormControlElement::disabledAttributeChanged):
(WebCore::HTMLFormControlElement::removedFromTree):
(WebCore::HTMLFormControlElement::disabled):

  • html/HTMLFormControlElement.h:

(WebCore):
(HTMLFormControlElement):

LayoutTests:

Add a test case for fieldset disabled attribute.

Reviewed by Kent Tamura.

  • fast/forms/fieldset/fieldset-disabled-expected.txt: Added.
  • fast/forms/fieldset/fieldset-disabled.html: Added.
03:12 Changeset [112514] by ossy@webkit.org
  • 124 edits
    1 copy
    17 adds in trunk/LayoutTests

[Qt] Unreviewed gardening after r112397. Unskip tests, add new baselines.

  • platform/qt/Skipped:
  • platform/qt/fast/block/float/overhanging-tall-block-expected.png:
  • platform/qt/fast/repaint/moving-shadow-on-container-expected.png:
  • platform/qt/fast/repaint/moving-shadow-on-container-expected.txt:
  • platform/qt/fast/repaint/moving-shadow-on-path-expected.png:
  • platform/qt/fast/repaint/moving-shadow-on-path-expected.txt:
  • platform/qt/fast/table/max-width-integer-overflow-expected.png: Copied from LayoutTests/platform/qt/fast/block/float/overhanging-tall-block-expected.png.
  • platform/qt/fast/table/max-width-integer-overflow-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-06-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/paths-data-03-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/struct-frag-02-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/struct-frag-03-t-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/text-align-04-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-align-04-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/text-text-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
  • platform/qt/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/qt/svg/as-image/img-preserveAspectRatio-support-1-expected.txt:
  • platform/qt/svg/batik/masking/maskRegions-expected.png:
  • platform/qt/svg/batik/masking/maskRegions-expected.txt:
  • platform/qt/svg/batik/text/textAnchor-expected.png:
  • platform/qt/svg/batik/text/textAnchor-expected.txt:
  • platform/qt/svg/carto.net/tabgroup-expected.png:
  • platform/qt/svg/carto.net/tabgroup-expected.txt:
  • platform/qt/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png:
  • platform/qt/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt:
  • platform/qt/svg/css/stars-with-shadow-expected.png: Added.
  • platform/qt/svg/css/stars-with-shadow-expected.txt: Added.
  • platform/qt/svg/custom/circular-marker-reference-1-expected.png:
  • platform/qt/svg/custom/circular-marker-reference-1-expected.txt:
  • platform/qt/svg/custom/circular-marker-reference-2-expected.png:
  • platform/qt/svg/custom/circular-marker-reference-2-expected.txt: Added.
  • platform/qt/svg/custom/circular-marker-reference-3-expected.png:
  • platform/qt/svg/custom/circular-marker-reference-3-expected.txt: Added.
  • platform/qt/svg/custom/circular-marker-reference-4-expected.png:
  • platform/qt/svg/custom/circular-marker-reference-4-expected.txt: Added.
  • platform/qt/svg/custom/embedding-external-svgs-expected.png:
  • platform/qt/svg/custom/embedding-external-svgs-expected.txt:
  • platform/qt/svg/custom/empty-merge-expected.png:
  • platform/qt/svg/custom/empty-merge-expected.txt:
  • platform/qt/svg/custom/image-with-transform-clip-filter-expected.png:
  • platform/qt/svg/custom/image-with-transform-clip-filter-expected.txt:
  • platform/qt/svg/custom/non-circular-marker-reference-expected.png:
  • platform/qt/svg/custom/non-circular-marker-reference-expected.txt: Added.
  • platform/qt/svg/custom/non-scaling-stroke-markers-expected.png:
  • platform/qt/svg/custom/non-scaling-stroke-markers-expected.txt: Added.
  • platform/qt/svg/custom/object-sizing-explicit-width-height-expected.png:
  • platform/qt/svg/custom/object-sizing-explicit-width-height-expected.txt:
  • platform/qt/svg/custom/recursive-filter-expected.png:
  • platform/qt/svg/custom/recursive-filter-expected.txt:
  • platform/qt/svg/custom/relative-sized-inner-svg-expected.png:
  • platform/qt/svg/custom/relative-sized-inner-svg-expected.txt:
  • platform/qt/svg/custom/relative-sized-use-on-symbol-expected.png: Added.
  • platform/qt/svg/custom/relative-sized-use-on-symbol-expected.txt:
  • platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png:
  • platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
  • platform/qt/svg/custom/resource-invalidate-on-target-update-expected.png: Added.
  • platform/qt/svg/custom/resource-invalidate-on-target-update-expected.txt:
  • platform/qt/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/qt/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
  • platform/qt/svg/custom/stroked-pattern-expected.png:
  • platform/qt/svg/custom/stroked-pattern-expected.txt:
  • platform/qt/svg/custom/text-rotated-gradient-expected.png:
  • platform/qt/svg/custom/text-rotated-gradient-expected.txt:
  • platform/qt/svg/custom/use-css-events-expected.png:
  • platform/qt/svg/custom/use-css-events-expected.txt:
  • platform/qt/svg/custom/use-detach-expected.png:
  • platform/qt/svg/custom/use-detach-expected.txt:
  • platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.png: Added.
  • platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/qt/svg/dom/css-transforms-expected.png: Added.
  • platform/qt/svg/dom/css-transforms-expected.txt: Added.
  • platform/qt/svg/filters/feColorMatrix-saturate-expected.txt:
  • platform/qt/svg/filters/feColorMatrix-values-expected.png: Added.
  • platform/qt/svg/filters/feColorMatrix-values-expected.txt:
  • platform/qt/svg/filters/feImage-preserveAspectratio-expected.png:
  • platform/qt/svg/filters/filteredImage-expected.png: Added.
  • platform/qt/svg/filters/filteredImage-expected.txt:
  • platform/qt/svg/hixie/links/001-expected.txt: Added.
  • platform/qt/svg/hixie/perf/007-expected.png:
  • platform/qt/svg/hixie/perf/007-expected.txt:
  • platform/qt/svg/hixie/viewbox/preserveAspectRatio/001-expected.png:
  • platform/qt/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
  • platform/qt/svg/overflow/overflow-on-inner-svg-element-expected.png:
  • platform/qt/svg/overflow/overflow-on-inner-svg-element-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-1-expected.png:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-2-expected.png:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-3-expected.png:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-3-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-4-expected.png:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-4-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-stretch-1-expected.png:
  • platform/qt/svg/text/select-textLength-spacing-stretch-1-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-stretch-2-expected.png:
  • platform/qt/svg/text/select-textLength-spacing-stretch-2-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-stretch-3-expected.png:
  • platform/qt/svg/text/select-textLength-spacing-stretch-3-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-stretch-4-expected.png:
  • platform/qt/svg/text/select-textLength-spacing-stretch-4-expected.txt:
  • platform/qt/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.png:
  • platform/qt/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
  • platform/qt/svg/text/select-x-list-1-expected.png:
  • platform/qt/svg/text/select-x-list-1-expected.txt:
  • platform/qt/svg/text/select-x-list-2-expected.png:
  • platform/qt/svg/text/select-x-list-2-expected.txt:
  • platform/qt/svg/text/select-x-list-3-expected.png:
  • platform/qt/svg/text/select-x-list-3-expected.txt:
  • platform/qt/svg/text/select-x-list-4-expected.png:
  • platform/qt/svg/text/select-x-list-4-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-1-expected.png:
  • platform/qt/svg/text/select-x-list-with-tspans-1-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-2-expected.png:
  • platform/qt/svg/text/select-x-list-with-tspans-2-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-3-expected.png:
  • platform/qt/svg/text/select-x-list-with-tspans-3-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-4-expected.png:
  • platform/qt/svg/text/select-x-list-with-tspans-4-expected.txt:
  • platform/qt/svg/text/small-fonts-2-expected.png:
  • platform/qt/svg/text/small-fonts-2-expected.txt:
  • platform/qt/svg/text/text-align-05-b-expected.png:
  • platform/qt/svg/text/text-align-05-b-expected.txt:
  • platform/qt/svg/transforms/transform-origin-css-property-expected.png: Added.
  • platform/qt/svg/transforms/transform-origin-css-property-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/qt/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
03:06 Changeset [112513] by tommyw@google.com
  • 2 edits in trunk/Source/WebCore

MediaStream API: Adding two missing release() calls to PeerConnection00.cpp
https://bugs.webkit.org/show_bug.cgi?id=82584

Reviewed by Adam Barth.

No changes that affects functionality.

  • Modules/mediastream/PeerConnection00.cpp:

(WebCore::PeerConnection00::createOffer):
(WebCore::PeerConnection00::createAnswer):

02:48 Changeset [112512] by rniwa@webkit.org
  • 13 edits in trunk/Source/WebCore

Pack bitfields in InlineBox for Windows
https://bugs.webkit.org/show_bug.cgi?id=82578

Reviewed by Kent Tamura.

Unlike gcc and clang, MSVC pads each consecutive member variables of the same type in bitfields. e.g. if you have:
sturct AB {
unsigned m_1 : 31;
bool m_2 : 1;
}
then MSVC pads m_1 and allocates sizeof(unsigned) * 2 for AB whereas gcc and clang only allocate
sizeof(unsigned) * 1 for AB.

Fixed the bug by packing all bitfields in InlineBox into InlineBoxBitfields and always using either unsigned or int.

  • rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::paint):
(WebCore::EllipsisBox::selectionRect):
(WebCore::EllipsisBox::nodeAtPoint):

  • rendering/InlineBox.cpp:

(WebCore):
(SameSizeAsInlineBox):
(WebCore::InlineBox::logicalHeight):
(WebCore::InlineBox::baselinePosition): Moved from the header file since it's a virtual function.
(WebCore::InlineBox::lineHeight): Ditto.
(WebCore::InlineBox::deleteLine):
(WebCore::InlineBox::extractLine):
(WebCore::InlineBox::attachLine):
(WebCore::InlineBox::nextOnLineExists):
(WebCore::InlineBox::clearKnownToHaveNoOverflow):

  • rendering/InlineBox.h:

(WebCore::InlineBox::InlineBox):
(WebCore::InlineBox::isText):
(WebCore::InlineBox::setIsText):
(WebCore::InlineBox::hasVirtualLogicalHeight):
(WebCore::InlineBox::setHasVirtualLogicalHeight):
(WebCore::InlineBox::isHorizontal):
(WebCore::InlineBox::setIsHorizontal):
(WebCore::InlineBox::isConstructed):
(WebCore::InlineBox::setConstructed):
(WebCore::InlineBox::setExtracted):
(WebCore::InlineBox::setFirstLineStyleBit):
(WebCore::InlineBox::isFirstLineStyle):
(InlineBox):
(WebCore::InlineBox::bidiLevel):
(WebCore::InlineBox::setBidiLevel):
(WebCore::InlineBox::direction):
(WebCore::InlineBox::isDirty):
(WebCore::InlineBox::markDirty):
(WebCore::InlineBox::expansion):
(WebCore::InlineBox::verticalAlign):
(WebCore::InlineBox::knownToHaveNoOverflow):
(WebCore::InlineBox::dirOverride):
(WebCore::InlineBox::setDirOverride):
(InlineBoxBitfields):
(WebCore::InlineBox::InlineBoxBitfields::InlineBoxBitfields):
(WebCore::InlineBox::InlineBoxBitfields::bidiEmbeddingLevel):
(WebCore::InlineBox::InlineBoxBitfields::setBidiEmbeddingLevel):
(WebCore::InlineBox::InlineBoxBitfields::determinedIfNextOnLineExists):
(WebCore::InlineBox::InlineBoxBitfields::setDeterminedIfNextOnLineExists):
(WebCore::InlineBox::InlineBoxBitfields::nextOnLineExists):
(WebCore::InlineBox::InlineBoxBitfields::setNextOnLineExists):
(WebCore::InlineBox::InlineBoxBitfields::expansion):
(WebCore::InlineBox::InlineBoxBitfields::setExpansion):
(WebCore::InlineBox::endsWithBreak):
(WebCore::InlineBox::setEndsWithBreak):
(WebCore::InlineBox::hasEllipsisBox):
(WebCore::InlineBox::hasSelectedChildren):
(WebCore::InlineBox::setHasSelectedChildren):
(WebCore::InlineBox::setHasEllipsisBox):
(WebCore::InlineBox::hasHyphen):
(WebCore::InlineBox::setHasHyphen):
(WebCore::InlineBox::canHaveLeadingExpansion):
(WebCore::InlineBox::setCanHaveLeadingExpansion):
(WebCore::InlineBox::setExpansion):
(WebCore::InlineBox::extracted):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::addToLine):
(WebCore::InlineFlowBox::removeChild):
(WebCore::InlineFlowBox::extractLine):
(WebCore::InlineFlowBox::attachLine):
(WebCore::InlineFlowBox::placeBoxesInInlineDirection):
(WebCore::InlineFlowBox::requiresIdeographicBaseline):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::addBoxShadowVisualOverflow):
(WebCore::InlineFlowBox::addBorderOutsetVisualOverflow):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::computeOverAnnotationAdjustment):
(WebCore::InlineFlowBox::computeUnderAnnotationAdjustment):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::destroy):
(WebCore::InlineTextBox::logicalOverflowRect):
(WebCore::InlineTextBox::setLogicalOverflowRect):
(WebCore::InlineTextBox::baselinePosition):
(WebCore::InlineTextBox::lineHeight):
(WebCore::InlineTextBox::localSelectionRect):
(WebCore::InlineTextBox::extractLine):
(WebCore::InlineTextBox::attachLine):
(WebCore::InlineTextBox::placeEllipsisBox):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintDecoration):
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
(WebCore::InlineTextBox::paintCompositionUnderline):
(WebCore::InlineTextBox::offsetForPosition):
(WebCore::InlineTextBox::positionForOffset):
(WebCore::InlineTextBox::constructTextRun):

  • rendering/InlineTextBox.h:

(InlineTextBox):
(WebCore::InlineTextBox::setExpansion):
(WebCore::InlineTextBox::expansionBehavior):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::constructLine):

  • rendering/RenderTreeAsText.cpp:

(WebCore::writeTextRun):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::baselinePosition): Moved from the header file since it's a virtual function.
(WebCore::RootInlineBox::lineHeight): Ditto.
(WebCore::RootInlineBox::paint):
(WebCore::RootInlineBox::ascentAndDescentForBox):
(WebCore::RootInlineBox::verticalPositionForBox):

  • rendering/RootInlineBox.h:

(RootInlineBox):

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::constructTextRun):

  • rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::writeSVGInlineTextBox):

02:45 Changeset [112511] by hayato@chromium.org
  • 9 edits
    2 adds
    2 deletes in trunk

Let focus navigation be compliant with Shadow DOM spec.
https://bugs.webkit.org/show_bug.cgi?id=78588

Reviewed by Dimitri Glazkov.

Source/WebCore:

Re-landing r112500. Fixed an assertion failure on ReifiedTreeTraversal.

Sequential focus navigation now behaves exactly as specified in the Shadow DOM spec.

According to the Shadow DOM spec:
The shadow DOM navigation order sequence is inserted into the document navigation order:

  1. immediately after the shadow host, if the shadow host is focusable; or
  2. in place of the shadow host as if the shadow host were assigned the value of auto for determining its position.

Prior to this patch, sequential focus navigation goes into Shadow DOM, but it is incomplete
since insertion points, such as <content> elements or <shadow> elements, are not resolved at all.
Now focus navigation can traverse shadow DOM subtrees in 'reified tree order', resolving lower boundaries transparently.

Implementation notes:
Prior to this patch, sequential focus navigation does not go into Shadow DOM if a shadow host is non-focusable.
Now focus navigation must go into Shadow DOM subtrees even if a show host is not focusable as described in 2).
To support this behavior, this patch introduced adjustedTabIndex() locally in FocusController so that
it does not skip a non-focusable shadow host in current focus scope.
After finding a *pseudo* focusable element in current focus scope, it tries to resolve a focused element recursively,
considering a nested focus scope inside of a shadow host or iframe.
To traverse Shadow DOM subtrees, a FocusController makes use of ReifiedTreeTraversal APIs, which was introduced in r112055.

This change does not affect an existing behavior if a shadow dom is not involved.

Test: fast/dom/shadow/focus-navigation.html

  • dom/Element.cpp:

(WebCore::Element::focus):

  • dom/ReifiedTreeTraversal.cpp:

(WebCore::ReifiedTreeTraversal::parentNodeWithoutCrossingUpperBoundary):

  • page/FocusController.cpp:

(WebCore::isShadowHost):
(WebCore):
(WebCore::FocusScope::FocusScope):
(WebCore::FocusScope::rootNode):
(WebCore::FocusScope::owner):
(WebCore::FocusScope::focusScopeOf):
(WebCore::FocusScope::focusScopeOwnedByShadowHost):
(WebCore::FocusScope::focusScopeOwnedByIFrame):
(WebCore::hasCustomFocusLogic):
(WebCore::isNonFocusableShadowHost):
(WebCore::isFocusableShadowHost):
(WebCore::adjustedTabIndex):
(WebCore::shouldVisit):
(WebCore::FocusController::findFocusableNodeDecendingDownIntoFrameDocument):
(WebCore::FocusController::advanceFocusInDocumentOrder):
(WebCore::FocusController::findFocusableNodeAcrossFocusScope):
(WebCore::FocusController::findFocusableNodeRecursively):
(WebCore::FocusController::findFocusableNode):
(WebCore::FocusController::findNodeWithExactTabIndex):
(WebCore::nextNodeWithGreaterTabIndex):
(WebCore::previousNodeWithLowerTabIndex):
(WebCore::FocusController::nextFocusableNode):
(WebCore::FocusController::previousFocusableNode):

  • page/FocusController.h:

(WebCore):
(FocusScope):
(FocusController):

LayoutTests:

  • fast/dom/shadow/focus-navigation-expected.txt: Added.
  • fast/dom/shadow/focus-navigation.html: Added.
  • fast/dom/shadow/resources/shadow-dom.js:

(isShadowHost):
(isIframeElement):
(getNodeInShadowTreeStack):
(dumpNode):
(innermostActiveElement):
(isInnermostActiveElement):
(shouldNavigateFocus):
(navigateFocusForward):
(navigateFocusBackward):
(testFocusNavigationFowrad):
(testFocusNavigationBackward):

  • fast/dom/shadow/shadow-host-transfer-focus-expected.txt: Removed.
  • fast/dom/shadow/shadow-host-transfer-focus.html: Removed.
  • fast/dom/shadow/tab-order-iframe-and-shadow-expected.txt:
  • fast/dom/shadow/tab-order-iframe-and-shadow.html:
02:40 Changeset [112510] by kinuko@chromium.org
  • 9 edits in trunk/Source

[chromium] Add isolated filesystem type and WebDragData::filesystem_id for drag-and-drop using File/DirectoryEntry.
https://bugs.webkit.org/show_bug.cgi?id=76826

Source/WebCore:

Add two helper methods for creating isolated filesystem to the
PlatformSupport interface.

Reviewed by David Levin.

No new tests: tests will be added when app-facing code is added.

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

Source/WebKit/chromium:

As proposed on whatwg (http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2011-November/033814.html)
we are implementing better drag-and-drop support using File/Directory
Entry objects in FileSystem API, and for the purpose this patch adds
a new filesystem type: Isolated filesystem.

Each filesystem can be distinguished by a filesystem ID that is given
by chromium platform code via WebDragData when set of
files/directories are dropped.

This is all platform-specific implementation detail and all the changes
are in chromium directory.

Reviewed by David Levin.

  • public/platform/WebDragData.h:

(WebDragData):

  • public/platform/WebFileSystem.h: Added Isolated type.
  • src/AsyncFileSystemChromium.cpp:

(WebCore::AsyncFileSystemChromium::createIsolatedFileSystemName): Added.
(WebCore::AsyncFileSystemChromium::createIsolatedFileSystem): Added.
(WebCore::AsyncFileSystemChromium::toURL): Made it not to return URL
for isolated filesystem (as we do not support it for now).

  • src/AsyncFileSystemChromium.h:
  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::createIsolatedFileSystem): Added.

  • src/WebDragData.cpp:

(WebKit::WebDragData::filesystemId): Added.
(WebKit::WebDragData::setFilesystemId): Added.

02:11 Changeset [112509] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip some failing tests.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-03-29

  • platform/qt/Skipped:
01:46 Changeset [112508] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed rebaseline after r112444

  • platform/qt/editing/pasteboard/select-element-1-expected.txt:
01:45 Changeset [112507] by kinuko@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed; rolling chromium deps to 129583.

  • DEPS:
01:32 Changeset [112506] by commit-queue@webkit.org
  • 16 edits
    2 deletes in trunk

Remove custom bindings form Internals.idl of attribute type Array.
https://bugs.webkit.org/show_bug.cgi?id=82319

Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-03-29
Reviewed by Kentaro Hara.

Source/WebCore:

Remove custom bindings for Array type and replace Array type with sequence<String>.

No new tests. LayoutTests/fast/harness/user-preferred-language.html should pass
even after these changes.

  • Target.pri: Remove JSInternalsCustom.cpp and V8InternalsCustom.cpp.
  • UseJSC.cmake: Remove JSInternalsCustom.cpp.
  • UseV8.cmake: Remove V8InternalsCustom.cpp.
  • WebCore.gypi: Remove JSInternalsCustom.cpp and V8InternalsCustom.cpp.
  • WebCore.vcproj/WebCoreTestSupport.vcproj: Remove JSInternalsCustom.cpp and V8InternalsCustom.cpp.
  • WebCore.xcodeproj/project.pbxproj: Remove JSInternalsCustom.cpp and V8InternalsCustom.cpp.
  • bindings/js/JSDOMBinding.h:

(WebCore):
(WebCore::jsArray): Added new specialize function template for Strings.

  • bindings/scripts/CodeGeneratorJS.pm:

(JSValueToNative): Add jsArray<String>() to deduce return type.
(NativeToJSValue): Added check for type String.

  • bindings/scripts/CodeGeneratorV8.pm:

(JSValueToNative): Add v8Array<String>() to deduce return type.
(NativeToJSValue): Added check for type String.

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::setJSTestObjSequenceAttr): Modified results from run-binding-tests.

  • bindings/scripts/test/V8/V8TestObj.cpp: Modified results from run-binding-tests.

(WebCore::TestObjInternal::sequenceAttrAttrSetter):

  • bindings/v8/V8Binding.h: Added new specialize function template for Strings.

(WebCore):
(WebCore::v8Array):
(WebCore::toNativeArray):

  • testing/Internals.idl: Replace Array type with sequence<String>
  • testing/js/JSInternalsCustom.cpp: Removed.
  • testing/v8/V8InternalsCustom.cpp: Removed.

Tools:

Remove JSInternalsCustom.cpp and V8InternalsCustom.cpp as no longer required.

  • GNUmakefile.am:
00:18 Changeset [112505] by commit-queue@webkit.org
  • 8 edits
    2 adds
    2 deletes in trunk

Unreviewed, rolling out r112500.
http://trac.webkit.org/changeset/112500
https://bugs.webkit.org/show_bug.cgi?id=82576

assertion failed on fast/events/tab-test-not-visible-
imagemap.html on gtk/qt (Requested by hayato on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-29

Source/WebCore:

  • dom/Element.cpp:

(WebCore::Element::focus):

  • page/FocusController.cpp:

(WebCore):
(WebCore::shadowRoot):
(WebCore::isTreeScopeOwner):
(WebCore::FocusController::transferFocusToElementInShadowRoot):
(WebCore::hasCustomFocusLogic):
(WebCore::FocusController::findFocusableNodeDecendingDownIntoFrameDocumentOrShadowRoot):
(WebCore::FocusController::advanceFocusInDocumentOrder):
(WebCore::ownerOfTreeScope):
(WebCore::FocusController::findFocusableNodeAcrossTreeScope):
(WebCore::FocusController::findFocusableNode):
(WebCore::nextNodeWithExactTabIndex):
(WebCore::previousNodeWithExactTabIndex):
(WebCore::nextNodeWithGreaterTabIndex):
(WebCore::previousNodeWithLowerTabIndex):
(WebCore::FocusController::nextFocusableNode):
(WebCore::FocusController::previousFocusableNode):

  • page/FocusController.h:

(WebCore):
(FocusController):

LayoutTests:

  • fast/dom/shadow/focus-navigation-expected.txt: Removed.
  • fast/dom/shadow/focus-navigation.html: Removed.
  • fast/dom/shadow/resources/shadow-dom.js:

(getNodeInShadowTreeStack):

  • fast/dom/shadow/shadow-host-transfer-focus-expected.txt: Added.
  • fast/dom/shadow/shadow-host-transfer-focus.html: Added.
  • fast/dom/shadow/tab-order-iframe-and-shadow-expected.txt:
  • fast/dom/shadow/tab-order-iframe-and-shadow.html:

03/28/12:

23:52 Changeset [112504] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

DFG object equality speculations should be simplified
https://bugs.webkit.org/show_bug.cgi?id=82557

Reviewed by Gavin Barraclough.

  • dfg/DFGNode.h:

(JSC::DFG::Node::shouldSpeculateFinalObject):
(JSC::DFG::Node::shouldSpeculateArray):

23:00 Changeset [112503] by tkent@chromium.org
  • 4 edits in trunk/Source/WebCore

Add TextFieldDecorationElement::decorate()
https://bugs.webkit.org/show_bug.cgi?id=82572

Reviewed by Hajime Morita.

This change will be needed for Bug 82143.
No new tests because of no behavior changes yet. This code change
doesn't affect non-Chromium ports for now.

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::create):
Remove unnecessary assertion. We should allow multiple UA shadow roots.

  • html/shadow/TextFieldDecorationElement.cpp:

(WebCore::TextFieldDecorationElement::decorate):
Added.
This function adds another ShadowRoot, and it contains one flexible box container.
The container contains existin ShadowRoot content and the decoration element.

  • html/shadow/TextFieldDecorationElement.h:

(TextFieldDecorationElement): Add the declaration of decorate().

22:47 Changeset [112502] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Consider removal of removes jsNull()/v8::Null() from JSInternalsCustom.cpp/V8InternalsCustom.cpp
https://bugs.webkit.org/show_bug.cgi?id=82442

Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-03-28
Reviewed by Kentaro Hara.

No new tests. LayoutTests/fast/harness/user-preferred-language.html should pass
even after these changes.

  • testing/js/JSInternalsCustom.cpp: Remove jsNull() if Vector is empty.

(WebCore::JSInternals::userPreferredLanguages):

  • testing/v8/V8InternalsCustom.cpp: Remove v8::Null() if Vector is empty.

(WebCore::V8Internals::userPreferredLanguagesAccessorGetter):

22:29 Changeset [112501] by abarth@webkit.org
  • 3 edits
    12 copies
    12 adds in trunk/Source

[Chromium] Move APIs related to ResourceHandle into Platform
https://bugs.webkit.org/show_bug.cgi?id=82553

Reviewed by James Robinson.

Source/Platform:

This patch is the first patch in this series:
https://github.com/abarth/webkit/compare/master...webcore-platform

The goal of these patches is to move WebCore::ResourceHandle out of
Chromium's WebKit layer and into WebCore/platform, where it belongs.

This patch moves the Chromium-WebKit APIs used by ResourceHandle out of
the WebKit layer and into the Plaform layer. These are APIs that WebKit
uses to call "down" to manipulate the underlying platform (rather than
"up" to the client to make decisions). The long-term plan is to move
all of the headers in WebKit/chromium/public/platform into
Platform/chromium/public (although we'll likely need to clean up some
layering violations as we go).

  • Platform.gypi:
  • chromium/public/WebData.h: Added.

(WebKit):
(WebData):
(WebKit::WebData::~WebData):
(WebKit::WebData::WebData):
(WebKit::WebData::operator=):
(WebKit::WebData::isEmpty):
(WebKit::WebData::isNull):

  • chromium/public/WebHTTPBody.h: Added.

(WebKit):
(WebHTTPBody):
(WebKit::WebHTTPBody::~WebHTTPBody):
(WebKit::WebHTTPBody::WebHTTPBody):
(WebKit::WebHTTPBody::operator=):
(WebKit::WebHTTPBody::isNull):

  • chromium/public/WebHTTPHeaderVisitor.h: Added.

(WebKit):
(WebHTTPHeaderVisitor):
(WebKit::WebHTTPHeaderVisitor::~WebHTTPHeaderVisitor):

  • chromium/public/WebHTTPLoadInfo.h: Added.

(WebCore):
(WebKit):
(WebHTTPLoadInfo):
(WebKit::WebHTTPLoadInfo::WebHTTPLoadInfo):
(WebKit::WebHTTPLoadInfo::~WebHTTPLoadInfo):
(WebKit::WebHTTPLoadInfo::operator =):

  • chromium/public/WebPrivateOwnPtr.h: Added.

(WebKit):
(WebPrivateOwnPtr):
(WebKit::WebPrivateOwnPtr::WebPrivateOwnPtr):
(WebKit::WebPrivateOwnPtr::~WebPrivateOwnPtr):
(WebKit::WebPrivateOwnPtr::reset):
(WebKit::WebPrivateOwnPtr::get):
(WebKit::WebPrivateOwnPtr::operator->):

  • chromium/public/WebURL.h: Added.

(WebKit):
(WebURL):
(WebKit::WebURL::~WebURL):
(WebKit::WebURL::WebURL):
(WebKit::WebURL::operator=):
(WebKit::WebURL::assign):
(WebKit::WebURL::spec):
(WebKit::WebURL::parsed):
(WebKit::WebURL::isValid):
(WebKit::WebURL::isEmpty):
(WebKit::WebURL::isNull):
(WebKit::WebURL::operator GURL):
(WebKit::operator<):
(WebKit::operator==):
(WebKit::operator!=):

  • chromium/public/WebURLError.h: Added.

(WebKit):
(WebURLError):
(WebKit::WebURLError::WebURLError):

  • chromium/public/WebURLLoadTiming.h: Added.

(WebKit):
(WebURLLoadTiming):
(WebKit::WebURLLoadTiming::~WebURLLoadTiming):
(WebKit::WebURLLoadTiming::WebURLLoadTiming):
(WebKit::WebURLLoadTiming::operator=):
(WebKit::WebURLLoadTiming::isNull):

  • chromium/public/WebURLLoader.h: Added.

(WebKit):
(WebURLLoader):
(WebKit::WebURLLoader::~WebURLLoader):

  • chromium/public/WebURLLoaderClient.h: Added.

(WebKit):
(WebURLLoaderClient):
(WebKit::WebURLLoaderClient::willSendRequest):
(WebKit::WebURLLoaderClient::didSendData):
(WebKit::WebURLLoaderClient::didReceiveResponse):
(WebKit::WebURLLoaderClient::didDownloadData):
(WebKit::WebURLLoaderClient::didReceiveData):
(WebKit::WebURLLoaderClient::didReceiveCachedMetadata):
(WebKit::WebURLLoaderClient::didFinishLoading):
(WebKit::WebURLLoaderClient::didFail):
(WebKit::WebURLLoaderClient::~WebURLLoaderClient):

  • chromium/public/WebURLRequest.h: Added.

(WebKit):
(WebURLRequest):
(ExtraData):
(WebKit::WebURLRequest::ExtraData::~ExtraData):
(WebKit::WebURLRequest::~WebURLRequest):
(WebKit::WebURLRequest::WebURLRequest):
(WebKit::WebURLRequest::operator=):

  • chromium/public/WebURLResponse.h: Added.

(WebKit):
(WebURLResponse):
(ExtraData):
(WebKit::WebURLResponse::ExtraData::~ExtraData):
(WebKit::WebURLResponse::~WebURLResponse):
(WebKit::WebURLResponse::WebURLResponse):
(WebKit::WebURLResponse::operator=):

Source/WebKit/chromium:

These headers are now just forwarding headers to the new location of
these headers. These forwarding headers exist to avoid breaking
existing users of the API. They will likely be removed (or changed)
in the future once we've updated all folks using them.

  • public/platform/WebData.h:
  • public/platform/WebHTTPBody.h:
  • public/platform/WebHTTPHeaderVisitor.h:
  • public/platform/WebHTTPLoadInfo.h:
  • public/platform/WebPrivateOwnPtr.h:
  • public/platform/WebURL.h:
  • public/platform/WebURLError.h:
  • public/platform/WebURLLoadTiming.h:
  • public/platform/WebURLLoader.h:
  • public/platform/WebURLLoaderClient.h:
  • public/platform/WebURLRequest.h:
  • public/platform/WebURLResponse.h:
21:59 Changeset [112500] by hayato@chromium.org
  • 8 edits
    2 adds
    2 deletes in trunk

Source/WebCore: Let focus navigation be compliant with Shadow DOM spec.
https://bugs.webkit.org/show_bug.cgi?id=78588

Reviewed by Dimitri Glazkov.

Sequential focus navigation now behaves exactly as specified in the Shadow DOM spec.

According to the Shadow DOM spec:
The shadow DOM navigation order sequence is inserted into the document navigation order:

  1. immediately after the shadow host, if the shadow host is focusable; or
  2. in place of the shadow host as if the shadow host were assigned the value of auto for determining its position.

Prior to this patch, sequential focus navigation goes into Shadow DOM, but it is incomplete
since insertion points, such as <content> elements or <shadow> elements, are not resolved at all.
Now focus navigation can traverse shadow DOM subtrees in 'reified tree order', resolving lower boundaries transparently.

Implementation notes:
Prior to this patch, sequential focus navigation does not go into Shadow DOM if a shadow host is non-focusable.
Now focus navigation must go into Shadow DOM subtrees even if a show host is not focusable as described in 2).
To support this behavior, this patch introduced adjustedTabIndex() locally in FocusController so that
it does not skip a non-focusable shadow host in current focus scope.
After finding a *pseudo* focusable element in current focus scope, it tries to resolve a focused element recursively,
considering a nested focus scope inside of a shadow host or iframe.
To traverse Shadow DOM subtrees, a FocusController makes use of ReifiedTreeTraversal APIs, which was introduced in r112055.

This change does not affect an existing behavior if a shadow dom is not involved.

Test: fast/dom/shadow/focus-navigation.html

  • dom/Element.cpp:

(WebCore::Element::focus):

  • page/FocusController.cpp:

(WebCore::isShadowHost):
(WebCore):
(WebCore::FocusScope::FocusScope):
(WebCore::FocusScope::rootNode):
(WebCore::FocusScope::owner):
(WebCore::FocusScope::focusScopeOf):
(WebCore::FocusScope::focusScopeOwnedByShadowHost):
(WebCore::FocusScope::focusScopeOwnedByIFrame):
(WebCore::hasCustomFocusLogic):
(WebCore::isNonFocusableShadowHost):
(WebCore::isFocusableShadowHost):
(WebCore::adjustedTabIndex):
(WebCore::shouldVisit):
(WebCore::FocusController::findFocusableNodeDecendingDownIntoFrameDocument):
(WebCore::FocusController::advanceFocusInDocumentOrder):
(WebCore::FocusController::findFocusableNodeAcrossFocusScope):
(WebCore::FocusController::findFocusableNodeRecursively):
(WebCore::FocusController::findFocusableNode):
(WebCore::FocusController::findNodeWithExactTabIndex):
(WebCore::nextNodeWithGreaterTabIndex):
(WebCore::previousNodeWithLowerTabIndex):
(WebCore::FocusController::nextFocusableNode):
(WebCore::FocusController::previousFocusableNode):

  • page/FocusController.h:

(WebCore):
(FocusScope):
(FocusController):

LayoutTests: Make focus navigation be compliant with Shadow DOM spec.
https://bugs.webkit.org/show_bug.cgi?id=78588

Reviewed by Dimitri Glazkov.

  • fast/dom/shadow/focus-navigation-expected.txt: Added.
  • fast/dom/shadow/focus-navigation.html: Added.
  • fast/dom/shadow/resources/shadow-dom.js:

(isShadowHost):
(isIframeElement):
(getNodeInShadowTreeStack):
(dumpNode):
(innermostActiveElement):
(isInnermostActiveElement):
(shouldNavigateFocus):
(navigateFocusForward):
(navigateFocusBackward):
(testFocusNavigationFowrad):
(testFocusNavigationBackward):

  • fast/dom/shadow/shadow-host-transfer-focus-expected.txt: Removed.
  • fast/dom/shadow/shadow-host-transfer-focus.html: Removed.
  • fast/dom/shadow/tab-order-iframe-and-shadow-expected.txt:
  • fast/dom/shadow/tab-order-iframe-and-shadow.html:
21:22 Changeset [112499] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

[WebSocket]Browser must fail connection if Sec-WebSocket-Protocol mismatched.
https://bugs.webkit.org/show_bug.cgi?id=82307

Patch by Li Yin <li.yin@intel.com> on 2012-03-28
Reviewed by Kent Tamura.

Source/WebCore:

From RFC6455: http://tools.ietf.org/html/rfc6455#section-4.1
If the WebSocket openhanding respond included the mismatched
Sec-WebSocket-Protocol header field, the client must fail the WebSocket Connection.

Test: http/tests/websocket/tests/hybi/handshake-fail-by-mismatch-protocol-header.html

  • Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::checkResponseHeaders):

LayoutTests:

From RFC6455: http://tools.ietf.org/html/rfc6455#section-4.1
If the response includes a |Sec-WebSocket-Protocol| header field
and this header field indicates the use of a subprotocol that was
not present in the client's handshake (the server has indicated a
subprotocol not requested by the client), the client MUST _Fail
the WebSocket Connection_.

  • http/tests/websocket/tests/hybi/handshake-fail-by-mismatch-protocol-header-expected.txt: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-mismatch-protocol-header.html: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-mismatch-protocol-header_wsh.py: Added.

(web_socket_do_extra_handshake):
(web_socket_transfer_data):

21:08 Changeset [112498] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix Windows build after r112482.

  • platform/network/cf/FormDataStreamCFNet.cpp:

(WebCore::formOpen):
Do not attempt to use an OS X error code on Windows. Use the POSIX errno instead.

20:42 Changeset [112497] by achicu@adobe.com
  • 3 edits in trunk/Source/WebCore

[CSS Filters] Avoid rebuilding FEFilters when RenderLayer is destroyed
https://bugs.webkit.org/show_bug.cgi?id=82524

Reviewed by Dean Jackson.

RenderLayer::~RenderLayer is calling clearBacking which updated the m_filter with new filters,
even though they were to be deleted a couple of lines below. This change avoids updating the filters,
if we are in the "destroyed" state.

No new tests. This change has no visible results to HTML or JavaScript, so it cannot be tested without a debugger.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::~RenderLayer):
(WebCore::RenderLayer::clearBacking):

  • rendering/RenderLayer.h:

(RenderLayer):

20:00 Changeset [112496] by ddkilzer@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

minidom configurations should be based on ToolExecutable.xcconfig
<http://webkit.org/b/82513>

Reviewed by Mark Rowe.

Note that this patch changes minidom from being installed in
/usr/local/bin to JavaScriptCore.framework/Resources.

  • Configurations/ToolExecutable.xcconfig: Add semi-colon.
  • JavaScriptCore.xcodeproj/project.pbxproj: Base minidom

configurations on ToolExecutable.xcconfig. Remove redundant
PRODUCT_NAME and SKIP_INSTALL variables.

19:57 Changeset [112495] by gyuyoung.kim@samsung.com
  • 6 edits in trunk/Source/WebCore

Remove ScriptExecutionContext from NavigatorBattery.idl
https://bugs.webkit.org/show_bug.cgi?id=82556

Reviewed by Adam Barth.

As Bug 73528 comment #71, NavigatorBattery.idl doesn't need to have ScriptExecutionContext.
Document can be used instead of ScriptExecutionContext.

Tests: batterystatus/add-listener-from-callback.html

batterystatus/basic-all-types-of-events.html
batterystatus/basic-operation.html
batterystatus/event-after-navigation.html
batterystatus/multiple-frames.html
batterystatus/updates.html
batterystatus/window-property.html

  • Modules/battery/BatteryManager.cpp:

(WebCore::BatteryManager::create):
(WebCore::BatteryManager::BatteryManager):

  • Modules/battery/BatteryManager.h:

(BatteryManager):

  • Modules/battery/NavigatorBattery.cpp:

(WebCore::NavigatorBattery::webkitBattery):

  • Modules/battery/NavigatorBattery.h:

(NavigatorBattery):

  • Modules/battery/NavigatorBattery.idl:
19:32 Changeset [112494] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry]Missing cookies from HTTP response header in Network tab of Web Inspector.
https://bugs.webkit.org/show_bug.cgi?id=82041

We shouldn't overwrite cookies of response if there are more than one
header of Set-Cookie.

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-03-28
Reviewed by Rob Buis.

Test: http/tests/cookies/resources/setArraycookies.php

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::handleNotifyHeaderReceived):

19:18 Changeset [112493] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

JPEGImageDecoder: Set frame alpha state before marking a frame complete
https://bugs.webkit.org/show_bug.cgi?id=82428

Reviewed by Kenneth Russell.

r109779 changed JPEG alpha channel handling by marking a JPEG image frame
as having no alpha _after_ setting the image status frame-complete, which
prevents the application of image color profiles in some WebGL cases.

No new tests. The application of the color profile is not guaranteed for
images used as textures in WebGL. Refer to http://wkb.ug/76498.

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageDecoder::jpegComplete): Set the image frame alpha state
before marking the image frame status as frame-complete.

19:11 Changeset [112492] by eae@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix rounding in RenderInline::paintOutlineForLine
https://bugs.webkit.org/show_bug.cgi?id=82540

Reviewed by Eric Seidel.

No new tests, no change in functionality.

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::paintOutlineForLine):
Change paintOutlineForLine to pixel snap the left and right edges of the
lines instead of adding the offset to an already rounded number.

19:00 passwords.json attached to BuildBot by rniwa@webkit.org
passwords.json
18:50 Changeset [112491] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix a crash and an assertion when recovering from a web process crash
https://bugs.webkit.org/show_bug.cgi?id=82559
<rdar://problem/10902574>

Reviewed by Mark Rowe.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _processDidCrash]):
If we're currently in accelerated compositing mode, exit.

(-[WKView updateLayer]):
Guard against a null drawing area.

18:46 Changeset [112490] by dgrogan@chromium.org
  • 146 edits
    3 adds
    1 delete in trunk

IndexedDB: don't expose IDBDatabaseError to script
https://bugs.webkit.org/show_bug.cgi?id=82280

Source/WebCore:

It's not used anywhere and firefox doesn't expose it.

Reviewed by Tony Chang.

Test: storage/indexeddb/removed.html

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Modules/indexeddb/DOMWindowIndexedDatabase.idl:
  • Modules/indexeddb/IDBDatabaseError.idl: Removed.
  • Modules/indexeddb/WorkerContextIndexedDatabase.idl:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

LayoutTests:

Add layout test that ensures IDBDatabaseError is gone.

Also change shouldBeTrue to shouldBeTrueQuiet in the boilerplate idb
layout test preamble to remove a bunch of clutter from the
-expected.txt files.

Reviewed by Tony Chang.

  • storage/indexeddb/basics-expected.txt:
  • storage/indexeddb/basics-shared-workers-expected.txt:
  • storage/indexeddb/basics-workers-expected.txt:

... every indexeddb -expected.txt:
Remove output from check for IDBDatabaseError.

  • storage/indexeddb/removed-expected.txt: Added.
  • storage/indexeddb/removed.html: Added.
  • storage/indexeddb/request-event-propagation-expected.txt:
  • storage/indexeddb/resources/removed.js: Added.

(test):

  • storage/indexeddb/resources/shared.js:

(removeVendorPrefixes): Stop checking for existence of
window.IDBDatabaseError.

18:41 Changeset [112489] by bashi@chromium.org
  • 3 edits in trunk

Respects font fallback list during webfonts are loading
https://bugs.webkit.org/show_bug.cgi?id=76684

Reviewed by Dimitri Glazkov.

Source/WebCore:

For layout, use the rest of the fallback list while webfonts are loading.
If the webfont is loading, it will be given an invalid Unicode Range so that
font selection mechansim doesn't use the webfont for layout.

Test: http/tests/webfont/fallback-font-while-loading.html

  • css/CSSSegmentedFontFace.cpp:

(WebCore::appendFontDataWithInvalidUnicodeRangeIfLoading): Added.
(WebCore):
(WebCore::CSSSegmentedFontFace::getFontData):

LayoutTests:

Add a test that checks fallback fonts are used for layout while
webfonts are loading.

  • http/tests/webfont/fallback-font-while-loading-expected.txt: Added.
  • http/tests/webfont/fallback-font-while-loading.html: Added.
  • http/tests/webfont/getahem.cgi: Added.
  • http/tests/webfont/resources/Ahem.ttf: Added.
18:32 Changeset [112488] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

[WebSocket]Reserved bits test case should cover both extension and no-extension scenarios
https://bugs.webkit.org/show_bug.cgi?id=82100

Patch by Li Yin <li.yin@intel.com> on 2012-03-28
Reviewed by Kent Tamura.

The current reserved bits test case only support extension case,
Improve test case to cover both no-extension and extension scenarios.

  • http/tests/websocket/tests/hybi/reserved-bits-expected.txt:
  • http/tests/websocket/tests/hybi/reserved-bits.html:
  • http/tests/websocket/tests/hybi/reserved-bits_wsh.py:

(web_socket_do_extra_handshake):

18:29 Changeset [112487] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Update Localizable.strings.

  • English.lproj/Localizable.strings:
18:29 Changeset [112486] by mrowe@apple.com
  • 2 edits in trunk/Tools

Fix --no-saved-state.

Ignore the flag before Lion, rather than making it specific to Lion.

Rubber-stamped by Dan Bernstein.

  • Scripts/webkitdirs.pm:

(argumentsForRunAndDebugMacWebKitApp):

18:14 Changeset [112485] by bbudge@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

AssociatedURLLoader does not support Cross Origin Redirects when using
Access Control.
https://bugs.webkit.org/show_bug.cgi?id=82354

AssociatedURLLoader's internal adapter now overrides didFailRedirectCheck,
which cancels the load, causing didFail to notify the client that the
load failed. AssociatedURLLoaderTest adds test cases for CORS requests
that receive redirects and pass or fail the redirect access check.

Reviewed by Adam Barth.

  • src/AssociatedURLLoader.cpp:

(AssociatedURLLoader::ClientAdapter):
(WebKit::AssociatedURLLoader::ClientAdapter::didFailRedirectCheck):
(WebKit):

  • tests/AssociatedURLLoaderTest.cpp:

(WebKit):
(WebKit::TEST_F):

18:07 Changeset [112484] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

Source/WebCore: Removed particular rendering for the volume slider and used
css positioning instead (simpler and less prone to errors when
changes occur).
https://bugs.webkit.org/show_bug.cgi?id=82150

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-03-28
Reviewed by Eric Carlson.

Test: media/video-controls-rendering-toggle-display-none.html

  • css/mediaControls.css: Updated css to correctly render controls.

(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):

  • css/mediaControlsChromium.css: Updated css to correctly render controls.

(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):

  • html/shadow/MediaControlElements.cpp: Removed particular renderer.

(WebCore):

  • html/shadow/MediaControlElements.h: Removed particular renderer.

(MediaControlVolumeSliderContainerElement):

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::create): Added an anonymous div container
for the mute button and volume slider (to be displayed on top of each other)

LayoutTests: Added relevant test to support video controls display:none toggling.
https://bugs.webkit.org/show_bug.cgi?id=82150

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-03-28
Reviewed by Eric Carlson.

  • media/video-controls-rendering-toggle-display-none.html: Added.
  • platform/chromium-linux/media/video-controls-rendering-toggle-display-none-expected.png: Added.
  • platform/chromium-linux/media/video-controls-rendering-toggle-display-none-expected.txt: Added.
  • platform/chromium/test_expectations.txt: Updated expectations, more rebaselining is needed.
18:02 Changeset [112483] by slewis@apple.com
  • 4 edits in trunk

Unreviewed, rolling out r110064.
http://trac.webkit.org/changeset/110064
https://bugs.webkit.org/show_bug.cgi?id=82537

The patch leaks the DOM when audio elements are used
(Requested by sundiamonde on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-28

Source/WebCore:

  • bindings/js/JSNodeCustom.cpp:

(WebCore::isReachableFromDOM):

LayoutTests:

  • platform/gtk/test_expectations.txt:
17:58 Changeset [112482] by ap@apple.com
  • 8 edits in trunk/Source/WebCore

[Win] Some Blob tests crash in CFNetwork in advanceCurrentStream(FormStreamFields*)
https://bugs.webkit.org/show_bug.cgi?id=82386
<rdar://problem/11121501>

Reviewed by Brady Eidson.

Covered by existing tests.

  • platform/network/cf/FormDataStreamCFNet.cpp:
  • platform/network/cf/FormDataStreamCFNet.h:

Moved low level implementation from FormDataStreamMac, and exposed an additional function
to implement Foundation-based API on top of this.

  • platform/network/mac/FormDataStreamMac.h:
  • platform/network/mac/FormDataStreamMac.mm:

Rely on toll-free bridging and implementation details to make this work without duplicating
code.
Note that httpBodyFromStream is confusing - I don't see how it can work when sending serialized
requests across process boundary. We probably only get away with this because we don't attempt
to send requests to UI process once they already have streams associated with them.

  • WebCore.vcproj/WebCore.vcproj: Added missing platform/cf files.
  • platform/cf/FileSystemCF.cpp: Fixed include style.
  • platform/win/FileSystemWin.cpp: (WebCore::fileSystemRepresentation): Ifdef out a broken

implementation.

17:56 Changeset [112481] by enne@google.com
  • 12 edits in trunk/Source

[chromium] Fix tiled layer assert for huge layers
https://bugs.webkit.org/show_bug.cgi?id=82486

Reviewed by James Robinson.

Source/WebCore:

Test: TiledLayerChromiumTest.hugeLayerUpdateCrash

TilingData::numTiles() is calculated as the product of two ints and so
can potentially overflow, causing numTiles() to be incorrect. To avoid
calling code accidentally falling into this trap, remove this function
and all code that uses tile index from TilingData. This requires
fixing up a bunch of callers of TilingData and CCLayerTilingData.

Additionally, TilingData::numTiles() has long been a confusing
function name in some contexts, so rename to bool hasEmptyBounds().

Also, remove TilingData::intersectDrawQuad because there are no
clients of that function.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::drawsContent):
(WebCore::TiledLayerChromium::reserveTextures):
(WebCore::TiledLayerChromium::prepareToUpdate):
(WebCore::TiledLayerChromium::prepareToUpdateIdle):
(WebCore::TiledLayerChromium::needsIdlePaint):
(WebCore::TiledLayerChromium::idlePaintRect):

  • platform/graphics/chromium/cc/CCLayerTilingData.cpp:

(WebCore::CCLayerTilingData::tileRect):

  • platform/graphics/chromium/cc/CCLayerTilingData.h:

(WebCore::CCLayerTilingData::hasEmptyBounds):
(WebCore::CCLayerTilingData::tileBounds):
(WebCore::CCLayerTilingData::isEmpty):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::bindContentsTexture):
(WebCore::CCTiledLayerImpl::appendQuads):

  • platform/graphics/gpu/Texture.cpp:

(WebCore::Texture::create):
(WebCore::Texture::updateSubRect):

  • platform/graphics/gpu/TilingData.cpp:

(WebCore::TilingData::tileBounds):
(WebCore::TilingData::tileBoundsWithBorder):
(WebCore::TilingData::tileBoundsNormalized):

  • platform/graphics/gpu/TilingData.h:

(WebCore::TilingData::hasEmptyBounds):
(TilingData):
(WebCore::TilingData::assertTile):

Source/WebKit/chromium:

Add test for updating a huge layer that would assert prior to this
code. Fix up TilingData tests to use a testing class that provides a
safe version of numTiles().

  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):
(WTF):

  • tests/TilingDataTest.cpp:

(TestTiling):
(WebCore::TestTiling::TestTiling):
(WebCore::TestTiling::numTiles):
(WebCore):
(WebCore::TEST):

17:54 Changeset [112480] by enrica@apple.com
  • 2 edits in trunk/LayoutTests

editing/spelling/spellcheck-async-mutation.html is flakey.
https://bugs.webkit.org/show_bug.cgi?id=82555

Mark this test as flakey in test_expectations.

  • platform/mac/test_expectations.txt:
17:36 Changeset [112479] by enrica@apple.com
  • 2 edits in trunk/LayoutTests

Removed editing/pasteboard/drop-text-without-selection.html from test_expectations
since it now passes consistently.

  • platform/mac/test_expectations.txt:
17:31 Changeset [112478] by enrica@apple.com
  • 2 edits in trunk/LayoutTests

Added compositing/rtl/rtl-fixed-overflow-scrolled.html to the Mac skipped list, because of
<https://bugs.webkit.org/show_bug.cgi?id=82554> compositing/rtl/rtl-fixed-overflow-scrolled.html fails on
Lion and SnowLeopard.

  • platform/mac/Skipped:
17:29 Changeset [112477] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Add dtharp to contributors list
https://bugs.webkit.org/show_bug.cgi?id=82545

Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-03-28
Reviewed by Adam Barth.

Adding dtharp as Contributor.

  • Scripts/webkitpy/common/config/committers.py:
17:24 Changeset [112476] by simon.fraser@apple.com
  • 2 edits in trunk/LayoutTests

Rebaseline this test after the nodes were removed in r112299.

  • platform/mac/fast/dom/Window/window-properties-expected.txt:
16:57 Changeset [112475] by eae@chromium.org
  • 6 edits in trunk/Source/WebCore

Change FilterOperations::getOutsets to use integers
https://bugs.webkit.org/show_bug.cgi?id=82535

Reviewed by Eric Seidel.

FilterOperations::getOutsets calculates the outsets using integers and
the values are guranteed to be set to full-pixel values. By changing the
function signature we communicate this fact better and avoid unnecessary
type conversions in some cases.

No new tests.

  • platform/graphics/filters/FilterOperations.cpp:

(WebCore::FilterOperations::getOutsets):

  • platform/graphics/filters/FilterOperations.h:

(FilterOperations):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::addVisualEffectOverflow):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::computeRectForRepaint):

  • rendering/style/RenderStyle.h:
16:55 Changeset [112474] by japhet@chromium.org
  • 34 edits in trunk/Source

Remove dispatchDidLoadMainResource callback, since no
port implements it.
https://bugs.webkit.org/show_bug.cgi?id=82539

Reviewed by Alexey Proskuryakov.

Source/WebCore:

No new tests, just deleting dead code.

  • loader/EmptyClients.h:

(EmptyFrameLoaderClient):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::finishedLoading):
(WebCore::FrameLoader::mainReceivedCompleteError):

  • loader/FrameLoaderClient.h:

(FrameLoaderClient):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::receivedError):
(WebCore::MainResourceLoader::didCancel):

Source/WebKit/blackberry:

  • WebCoreSupport/FrameLoaderClientBlackBerry.h:

(FrameLoaderClientBlackBerry):

Source/WebKit/chromium:

  • src/FrameLoaderClientImpl.cpp:

(WebKit):

  • src/FrameLoaderClientImpl.h:

(FrameLoaderClientImpl):

Source/WebKit/efl:

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore):

  • WebCoreSupport/FrameLoaderClientEfl.h:

(FrameLoaderClientEfl):

Source/WebKit/gtk:

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit):

  • WebCoreSupport/FrameLoaderClientGtk.h:

(FrameLoaderClient):

Source/WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebKit.order:

Source/WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore):

  • WebCoreSupport/FrameLoaderClientQt.h:

(FrameLoaderClientQt):

Source/WebKit/win:

  • WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebCoreSupport/WebFrameLoaderClient.h:

(WebFrameLoaderClient):

Source/WebKit/wince:

  • WebCoreSupport/FrameLoaderClientWinCE.cpp:

(WebKit):

  • WebCoreSupport/FrameLoaderClientWinCE.h:

(FrameLoaderClientWinCE):

Source/WebKit/wx:

  • WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore):

  • WebKitSupport/FrameLoaderClientWx.h:

(FrameLoaderClientWx):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
16:43 Changeset [112473] by enrica@apple.com
  • 3 edits in trunk/Source/WebCore

REGRESSION: editing/pasteboard/dataTransfer-setData-getData.html fails on Mac platforms.
https://bugs.webkit.org/show_bug.cgi?id=82497
<rdar://problem/11140334>

Reviewed by Brady Eidson.

The revision causing this regression fixed the way data is written to the pasteboard for NSURLPboardType.
This change fixes the way data is read from the pasteboard for the same pasteboard type.

No new tests. Fixes the existing one that fails.

  • platform/mac/ClipboardMac.mm:

(WebCore::absoluteURLsFromPasteboard):

  • platform/mac/PlatformPasteboardMac.mm:

(WebCore::PlatformPasteboard::stringForType):

16:41 Changeset [112472] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

SL bot is hitting SHOULD NEVER BE REACHED in WebCore::valueForLength() on many tests
https://bugs.webkit.org/show_bug.cgi?id=82390

Patch by Joe Thomas <joethomas@motorola.com> on 2012-03-28
Reviewed by Simon Fraser.

This is an attempt to fix the MAC SL/Lion Bot issue as this issue is not reproducible locally.
The assertion happened when length type is Undefined in valueForLength() function but the assertion for Undefined length type
in RenderBox::computeLogicalWidthInRegionUsing which calls the above said function did not get hit.

This patch passes Length structure as const reference to Length calculation functions which avoids the call to the copy-constructor.
And it ensures that the Length structure is not getting modified during copy-construction.

  • css/LengthFunctions.cpp:

(WebCore::minimumValueForLength):
(WebCore::valueForLength):
(WebCore::floatValueForLength):

  • css/LengthFunctions.h:

(WebCore):

16:29 Changeset [112471] by eae@chromium.org
  • 4 edits in branches/subpixellayout/Source

Add Node::pixelSnappedRenderRect on subpixel branch.

16:26 Changeset [112470] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

build-webkit : the word "pass" is spelled incorrectly as "passs"
https://bugs.webkit.org/show_bug.cgi?id=82532

Patch by Stuart Eichert <stuart.eichert@palm.com> on 2012-03-28
Reviewed by Julien Chaffraix.

Corrected spelling of the word "pass" in build-webkit.

  • Scripts/build-webkit:
16:17 Changeset [112469] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Lion tweaks.

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
16:08 Changeset [112468] by simon.fraser@apple.com
  • 2 edits in trunk/LayoutTests

compositing/tiling/crash-reparent-tiled-layer.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=82546

Mark this test as flakey in test_expectations

  • platform/mac/test_expectations.txt:
16:06 Changeset [112467] by dpranke@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll chromium from 129300 to 129509.

Unreviewed, DEPS change.

  • DEPS:
16:05 Changeset [112466] by ojan@chromium.org
  • 17 edits
    4 moves
    49 adds
    7 deletes in trunk/LayoutTests

More Chromium rebaselines from the expected failures tab in garden-o-matic.
They all looked like straightforward text-rendering, form-control rendering or anti-aliasing issues,
except for some where the new results were clearly just more correct.

16:00 Changeset [112465] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1025

Merge 111263
BUG=117698
Review URL: https://chromiumcodereview.appspot.com/9887002

15:56 Changeset [112464] by simon.fraser@apple.com
  • 2 edits in trunk/LayoutTests

Remove some more tests from test_expectations.txt, since the pixel test pass.

  • platform/mac/test_expectations.txt:
15:54 Changeset [112463] by cevans@google.com
  • 1 edit
    3 copies in branches/chromium/1025

Merge 111714
BUG=116806
Review URL: https://chromiumcodereview.appspot.com/9896001

15:48 Changeset [112462] by simon.fraser@apple.com
  • 2 edits in trunk/LayoutTests

Remove some tests that now pass pixel tests from the list of failures.

  • platform/mac/test_expectations.txt:
15:43 Changeset [112461] by cevans@google.com
  • 7 edits in branches/chromium/1025

Merge 111098
BUG=118467
Review URL: https://chromiumcodereview.appspot.com/9895001

15:43 Changeset [112460] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix - some compiles generating NORETURN related warnings.

  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::setSubpatternStart):
(JSC::Yarr::YarrGenerator::setSubpatternEnd):
(JSC::Yarr::YarrGenerator::clearSubpatternStart):

15:34 Changeset [112459] by cevans@google.com
  • 2 edits in branches/chromium/1025/Source/WebCore

Merge 111775
BUG=117400
Review URL: https://chromiumcodereview.appspot.com/9892004

15:33 Changeset [112458] by dpranke@chromium.org
  • 2 edits in trunk/Tools

new-run-webkit-tests doesn't log correctly after retrying failures
https://bugs.webkit.org/show_bug.cgi?id=82541

Unreviewed, build fix.

r112189 introduced a regression where we would accidentally
delete the log handler after we retried any failing tests - that
meant that any log messages around uploading the results got
dropped.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._run_tests):

15:32 Changeset [112457] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

Massive lag opening a link in a new background tab
https://bugs.webkit.org/show_bug.cgi?id=82542
<rdar://problem/11004502>

Reviewed by Sam Weinig.

Defer waiting for the web process to update the page size until we're actually going to display the layer.
This matches what we do in the non-tiled code path.

  • UIProcess/API/mac/WKView.mm:

(-[WKView setFrameSize:]):
(-[WKView updateLayer]):

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::waitForPossibleGeometryUpdate):

  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:

(TiledCoreAnimationDrawingAreaProxy):

  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::sizeDidChange):
(WebKit):
(WebKit::TiledCoreAnimationDrawingAreaProxy::waitForPossibleGeometryUpdate):

15:24 Changeset [112456] by kevino@webkit.org
  • 6 edits in trunk

[wx] Unreviewed. Build fix, move WTF back into JSCore target
until issues with JSCore not linking in all WTF symbols are resolved.

15:20 Changeset [112455] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Yarr: if we're not using the output array, don't populate it!
https://bugs.webkit.org/show_bug.cgi?id=82519

Reviewed by Sam Weinig.

  • runtime/RegExp.cpp:

(JSC):

  • Missed review comment! - didn't fully remove RegExpRepresentation.
15:18 Changeset [112454] by barraclough@apple.com
  • 14 edits
    3 adds in trunk/Source

Yarr: if we're not using the output array, don't populate it!
https://bugs.webkit.org/show_bug.cgi?id=82519

Reviewed by Sam Weinig.

../JavaScriptCore:

Add a new variant of the match method to RegExp that returns a MatchResult,
and modify YarrJIT to be able to compile code that doesn't use an output vector.

This is a 3% progression on v8-regexp.

  • JavaScriptCore.xcodeproj/project.pbxproj:
    • Moved MatchResult into its own header.
  • assembler/AbstractMacroAssembler.h:
    • Added missing include.
  • runtime/MatchResult.h: Added.

(MatchResult::MatchResult):
(MatchResult):
(MatchResult::failed):
(MatchResult::operator bool):
(MatchResult::empty):

  • Moved MatchResult into its own header.
  • runtime/RegExp.cpp:

(JSC::RegExp::compile):
(JSC::RegExp::compileIfNecessary):
(JSC::RegExp::match):

  • Changed due to execute & representation changes.

(JSC::RegExp::compileMatchOnly):
(JSC::RegExp::compileIfNecessaryMatchOnly):

  • Added helper to compile MatchOnly code.

(JSC::RegExp::invalidateCode):
(JSC::RegExp::matchCompareWithInterpreter):
(JSC::RegExp::printTraceData):

  • Changed due representation changes.
  • runtime/RegExp.h:

(RegExp):
(JSC::RegExp::hasCode):

  • Made YarrCodeBlock a member.
  • runtime/RegExpConstructor.h:

(RegExpConstructor):
(JSC::RegExpConstructor::performMatch):

  • Added no-ovector form.
  • runtime/RegExpMatchesArray.cpp:

(JSC::RegExpMatchesArray::reifyAllProperties):

  • Match now takes a reference to ovector, not a pointer.
  • runtime/RegExpObject.h:

(JSC):

  • Moved MatchResult into its own header.
  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncSplit):

  • Match now takes a reference to ovector, not a pointer.
  • testRegExp.cpp:

(testOneRegExp):

  • Match now takes a reference to ovector, not a pointer.
  • yarr/YarrJIT.cpp:

(Yarr):
(YarrGenerator):
(JSC::Yarr::YarrGenerator::initCallFrame):
(JSC::Yarr::YarrGenerator::removeCallFrame):
(JSC::Yarr::YarrGenerator::setSubpatternStart):
(JSC::Yarr::YarrGenerator::setSubpatternEnd):
(JSC::Yarr::YarrGenerator::clearSubpatternStart):
(JSC::Yarr::YarrGenerator::setMatchStart):
(JSC::Yarr::YarrGenerator::getMatchStart):

  • Added helper functions to intermediate access to output.

(JSC::Yarr::YarrGenerator::generateDotStarEnclosure):
(JSC::Yarr::YarrGenerator::generate):
(JSC::Yarr::YarrGenerator::backtrack):
(JSC::Yarr::YarrGenerator::generateEnter):
(JSC::Yarr::YarrGenerator::compile):

  • Changed to use the new helpers, only generate subpatterns if IncludeSubpatterns.

(JSC::Yarr::jitCompile):

  • Needs to template of MatchOnly or IncludeSubpatterns.
  • yarr/YarrJIT.h:

(YarrCodeBlock):
(JSC::Yarr::YarrCodeBlock::set8BitCode):
(JSC::Yarr::YarrCodeBlock::set16BitCode):
(JSC::Yarr::YarrCodeBlock::has8BitCodeMatchOnly):
(JSC::Yarr::YarrCodeBlock::has16BitCodeMatchOnly):
(JSC::Yarr::YarrCodeBlock::set8BitCodeMatchOnly):
(JSC::Yarr::YarrCodeBlock::set16BitCodeMatchOnly):
(JSC::Yarr::YarrCodeBlock::execute):
(JSC::Yarr::YarrCodeBlock::clear):

  • Added a second set of CodeRefs, so that we can compile RexExps with/without subpattern matching.

../WebCore:

  • ForwardingHeaders/runtime/MatchResult.h: Added.
  • ForwardingHeaders/yarr/YarrJIT.h: Added.
    • Added forwarding headers.
15:15 Changeset [112453] by hyatt@apple.com
  • 71 edits
    4 adds in trunk

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=81685

[New Multicolumn] Add RenderMultiColumnFlowThread to hold the flow thread contents of a multi-column block.
It derives from RenderFlowThread.

Refactor RenderFlowThread to split out the stuff related to explicit naming into a subclass, RenderNamedFlowThread.
This allows RenderFlowThread to be a simple base class that involves maintaining the regions themselves.

Reviewed by Julien Chaffraix.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:
  • dom/NodeRenderingContext.cpp:
  • dom/NodeRenderingContext.h:

(WebCore):
(WebCore::NodeRenderingContext::parentFlowRenderer):

  • dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::WebKitNamedFlow):

  • dom/WebKitNamedFlow.h:

(WebCore):
(WebCore::WebKitNamedFlow::create):
(WebKitNamedFlow):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::collapseAnonymousBoxChild):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore):
(WebCore::RenderFlowThread::addRegionToThread):
(WebCore::RenderFlowThread::removeRegionFromThread):
(WebCore::RenderFlowThread::removeRenderBoxRegionInfo):

  • rendering/RenderFlowThread.h:

(WebCore):

  • rendering/RenderMultiColumnFlowThread.cpp: Added.

(WebCore):
(WebCore::RenderMultiColumnFlowThread::RenderMultiColumnFlowThread):
(WebCore::RenderMultiColumnFlowThread::renderName):

  • rendering/RenderMultiColumnFlowThread.h: Added.

(WebCore):
(RenderMultiColumnFlowThread):

  • rendering/RenderNamedFlowThread.cpp: Added.

(WebCore):
(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::renderName):
(WebCore::RenderNamedFlowThread::nextRendererForNode):
(WebCore::RenderNamedFlowThread::previousRendererForNode):
(WebCore::RenderNamedFlowThread::addFlowChild):
(WebCore::RenderNamedFlowThread::removeFlowChild):
(WebCore::RenderNamedFlowThread::dependsOn):
(WebCore::compareRenderRegions):
(WebCore::RenderNamedFlowThread::addRegionToThread):
(WebCore::RenderNamedFlowThread::removeRegionFromThread):
(WebCore::RenderNamedFlowThread::checkInvalidRegions):
(WebCore::RenderNamedFlowThread::addDependencyOnFlowThread):
(WebCore::RenderNamedFlowThread::removeDependencyOnFlowThread):
(WebCore::RenderNamedFlowThread::pushDependencies):
(WebCore::RenderNamedFlowThread::ensureNamedFlow):

  • rendering/RenderNamedFlowThread.h: Added.

(WebCore):
(RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::name):
(WebCore::RenderNamedFlowThread::hasChildren):
(WebCore::RenderNamedFlowThread::hasChild):
(WebCore::RenderNamedFlowThread::isRenderNamedFlowThread):
(WebCore::toRenderNamedFlowThread):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::willBeDestroyed):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isRenderNamedFlowThread):

  • rendering/RenderObjectChildList.cpp:

(WebCore::renderNamedFlowThreadContainer):
(WebCore::RenderObjectChildList::removeChildNode):
(WebCore::RenderObjectChildList::appendChildNode):
(WebCore::RenderObjectChildList::insertChildNode):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::attachRegion):

  • rendering/RenderRegion.h:

(WebCore):
(WebCore::RenderRegion::parentNamedFlowThread):
(RenderRegion):

  • rendering/RenderTreeAsText.cpp:

(WebCore::writeRenderNamedFlowThreads):
(WebCore::writeLayers):

  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):
(WebCore::RenderView::layout):
(WebCore::RenderView::styleDidChange):
(WebCore::RenderView::ensureRenderFlowThreadWithName):
(WebCore::RenderView::layoutRenderNamedFlowThreads):

  • rendering/RenderView.h:

(WebCore):
(RenderView):
(WebCore::RenderView::hasRenderNamedFlowThreads):
(WebCore::RenderView::isRenderNamedFlowThreadOrderDirty):
(WebCore::RenderView::setIsRenderNamedFlowThreadOrderDirty):
(WebCore::RenderView::renderNamedFlowThreadList):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=81685

[New Multicolumn] Add RenderMultiColumnFlowThread to hold the flow thread contents of a multi-column block.
It derives from RenderFlowThread.

Change layout test results to reflect the name change from RenderFlowThread to
RenderNamedFlowThread. Other platforms should update results accordingly.

Reviewed by Julien Chaffraix.

  • fast/repaint/inline-relative-positioned-expected.txt:
  • fast/repaint/overflow-clip-subtree-layout-expected.txt:
  • fast/repaint/subtree-root-clip-2-expected.txt:
  • fast/repaint/subtree-root-clip-3-expected.txt:
  • fast/repaint/subtree-root-clip-expected.txt:
  • platform/mac/fast/regions/bottom-overflow-out-of-first-region-expected.txt:
  • platform/mac/fast/regions/flow-content-basic-expected.txt:
  • platform/mac/fast/regions/flow-content-basic-vertical-expected.txt:
  • platform/mac/fast/regions/flow-content-basic-vertical-rl-expected.txt:
  • platform/mac/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt:
  • platform/mac/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt:
  • platform/mac/fast/regions/overflow-in-variable-width-regions-expected.txt:
  • platform/mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt:
  • platform/mac/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt:
  • platform/mac/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt:
  • platform/mac/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt:
  • platform/mac/fast/regions/overflow-size-change-with-stacking-context-expected.txt:
  • platform/mac/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt:
  • platform/mac/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.txt:
  • platform/mac/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.txt:
  • platform/mac/fast/regions/percentage-margins-rtl-variable-width-regions-expected.txt:
  • platform/mac/fast/regions/percentage-margins-variable-width-regions-expected.txt:
  • platform/mac/fast/regions/region-overflow-auto-overflow-hidden-expected.txt:
  • platform/mac/fast/regions/region-overflow-auto-overflow-visible-expected.txt:
  • platform/mac/fast/regions/region-overflow-break-expected.txt:
  • platform/mac/fast/regions/region-style-block-background-color-expected.txt:
  • platform/mac/fast/regions/region-style-block-background-color2-expected.txt:
  • platform/mac/fast/regions/region-style-image-background-color-expected.txt:
  • platform/mac/fast/regions/region-style-inline-background-color-expected.txt:
  • platform/mac/fast/regions/render-region-custom-style-mark-expected.txt:
  • platform/mac/fast/regions/text-region-split-small-pagination-expected.txt:
  • platform/mac/fast/regions/top-overflow-out-of-second-region-expected.txt:
  • platform/mac/fast/regions/webkit-flow-double-pagination-float-push-expected.txt:
  • platform/mac/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt:
  • platform/mac/fast/regions/webkit-flow-float-unable-to-push-expected.txt:
  • platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt:
  • platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt:
  • platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt:
  • platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt:
  • platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
  • platform/mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
  • platform/mac/fast/repaint/region-painting-invalidation-expected.txt:
  • platform/mac/fast/repaint/region-painting-via-layout-expected.txt:
  • platform/qt/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
  • platform/qt/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
  • platform/qt/fast/repaint/region-painting-invalidation-expected.txt:
  • platform/qt/fast/repaint/region-painting-via-layout-expected.txt:
  • platform/win/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
15:12 Changeset [112452] by eae@chromium.org
  • 2 edits in branches/subpixellayout/Source/WebCore

Cleanup RenderLayer and mac dom bindings on subpixel branch

15:11 Changeset [112451] by cevans@google.com
  • 1 edit in branches/chromium/1025/Source/WebCore/dom/ContainerNode.cpp

Merge 110150
BUG=117400
Review URL: https://chromiumcodereview.appspot.com/9854037

15:09 Changeset [112450] by eae@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove unnecessary rounding in RenderLayerBacking
https://bugs.webkit.org/show_bug.cgi?id=82529

Reviewed by Eric Seidel.

Remove rounding that is no longer required now that borderBoxRect returns
an IntRect.

No new tests.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::startTransition):

15:07 Changeset [112449] by enne@google.com
  • 12 edits in trunk/Source

Unreviewed, rolling out r112432.
http://trac.webkit.org/changeset/112432
https://bugs.webkit.org/show_bug.cgi?id=82536

Causes ccs3 layout test asserts (Requested by enne on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-28

Source/WebCore:

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::drawsContent):
(WebCore::TiledLayerChromium::reserveTextures):
(WebCore::TiledLayerChromium::prepareToUpdate):
(WebCore::TiledLayerChromium::prepareToUpdateIdle):
(WebCore::TiledLayerChromium::needsIdlePaint):
(WebCore::TiledLayerChromium::idlePaintRect):

  • platform/graphics/chromium/cc/CCLayerTilingData.cpp:

(WebCore::CCLayerTilingData::tileRect):

  • platform/graphics/chromium/cc/CCLayerTilingData.h:

(WebCore::CCLayerTilingData::numTiles):
(WebCore::CCLayerTilingData::tileBounds):
(WebCore::CCLayerTilingData::isEmpty):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::bindContentsTexture):
(WebCore::CCTiledLayerImpl::appendQuads):

  • platform/graphics/filters/FECustomFilter.cpp:

(WebCore::FECustomFilter::platformApplySoftware):

  • platform/graphics/gpu/Texture.cpp:

(WebCore::Texture::create):
(WebCore::Texture::updateSubRect):

  • platform/graphics/gpu/TilingData.cpp:

(WebCore::TilingData::tileBounds):
(WebCore::TilingData::tileBoundsWithBorder):
(WebCore::TilingData::tileBoundsNormalized):
(WebCore::TilingData::intersectDrawQuad):
(WebCore):

  • platform/graphics/gpu/TilingData.h:

(WebCore::TilingData::numTiles):
(WebCore::TilingData::tileIndex):
(WebCore::TilingData::tileXIndex):
(WebCore::TilingData::tileYIndex):
(TilingData):
(WebCore::TilingData::assertTile):

Source/WebKit/chromium:

  • tests/TiledLayerChromiumTest.cpp:
  • tests/TilingDataTest.cpp:

(WebCore::TEST):

15:03 Changeset [112448] by dcheng@chromium.org
  • 7 edits
    2 moves
    2 deletes in trunk/Source

[chromium] Merge ChromiumDataObject and DataTransferItemListChromium.
https://bugs.webkit.org/show_bug.cgi?id=82407

Reviewed by Tony Chang.

Source/WebCore:

Since ChromiumDataObject is just a very thin wrapper for DataTransferItemListChromium now,
combine the two and remove a layer of indirection.

No functionality change, should be covered by existing tests.

  • WebCore.gypi:
  • platform/chromium/ChromiumDataObject.cpp: Replacing DataTransferItemListChromium.

(WebCore::ChromiumDataObject::createFromPasteboard):
(WebCore::ChromiumDataObject::create):
(WebCore::ChromiumDataObject::length):
(WebCore):
(WebCore::ChromiumDataObject::item):
(WebCore::ChromiumDataObject::deleteItem):
(WebCore::ChromiumDataObject::clearAll):
(WebCore::ChromiumDataObject::add):
(WebCore::ChromiumDataObject::clearData):
(WebCore::ChromiumDataObject::clearAllExceptFiles):
(WebCore::ChromiumDataObject::types):
(WebCore::ChromiumDataObject::getData):
(WebCore::ChromiumDataObject::setData):
(WebCore::ChromiumDataObject::urlAndTitle):
(WebCore::ChromiumDataObject::setURLAndTitle):
(WebCore::ChromiumDataObject::htmlAndBaseURL):
(WebCore::ChromiumDataObject::setHTMLAndBaseURL):
(WebCore::ChromiumDataObject::containsFilenames):
(WebCore::ChromiumDataObject::filenames):
(WebCore::ChromiumDataObject::addFilename):
(WebCore::ChromiumDataObject::addSharedBuffer):
(WebCore::ChromiumDataObject::ChromiumDataObject):
(WebCore::ChromiumDataObject::findStringItem):
(WebCore::ChromiumDataObject::internalAddStringItem):
(WebCore::ChromiumDataObject::internalAddFileItem):

  • platform/chromium/ChromiumDataObject.h:

(WebCore):
(ChromiumDataObject):

  • platform/chromium/ChromiumDataObjectItem.cpp: Renamed from Source/WebCore/platform/chromium/DataTransferItemChromium.cpp.

(WebCore):
(WebCore::ChromiumDataObjectItem::createFromString):
(WebCore::ChromiumDataObjectItem::createFromFile):
(WebCore::ChromiumDataObjectItem::createFromURL):
(WebCore::ChromiumDataObjectItem::createFromHTML):
(WebCore::ChromiumDataObjectItem::createFromSharedBuffer):
(WebCore::ChromiumDataObjectItem::createFromPasteboard):
(WebCore::ChromiumDataObjectItem::ChromiumDataObjectItem):
(WebCore::ChromiumDataObjectItem::getAsString):
(WebCore::ChromiumDataObjectItem::getAsFile):
(WebCore::ChromiumDataObjectItem::internalGetAsString):
(WebCore::ChromiumDataObjectItem::isFilename):

  • platform/chromium/ChromiumDataObjectItem.h: Renamed from Source/WebCore/platform/chromium/DataTransferItemChromium.h.

(WebCore):
(ChromiumDataObjectItem):
(WebCore::ChromiumDataObjectItem::kind):
(WebCore::ChromiumDataObjectItem::type):
(WebCore::ChromiumDataObjectItem::sharedBuffer):
(WebCore::ChromiumDataObjectItem::title):
(WebCore::ChromiumDataObjectItem::baseURL):

  • platform/chromium/ClipboardChromium.cpp:

(WebCore::ClipboardChromium::files):
(WebCore::ClipboardChromium::hasData):
(WebCore::ClipboardChromium::items):

  • platform/chromium/DataTransferItemListChromium.cpp: Removed.
  • platform/chromium/DataTransferItemListChromium.h: Removed.

Source/WebKit/chromium:

  • src/WebDragData.cpp:

(WebKit::WebDragData::items):

15:00 Changeset [112447] by jam@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium-win/fast/workers/worker-context-multi-port-expected.txt

Unreviewed rebaseline

14:45 Changeset [112446] by nduca@chromium.org
  • 11 edits in trunk/Source

[chromium] Scheduler should not tell FrameRateController to begin a frame when we dont swap
https://bugs.webkit.org/show_bug.cgi?id=82516

Reviewed by James Robinson.

Source/WebCore:

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::swapBuffers):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::swapBuffers):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::processScheduledActions):

  • platform/graphics/chromium/cc/CCScheduler.h:

(WebCore::CCScheduledActionDrawAndSwapResult::CCScheduledActionDrawAndSwapResult):
(CCScheduledActionDrawAndSwapResult):
(WebCore):
(CCSchedulerClient):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwapIfPossible):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwapForced):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

  • tests/CCSchedulerTest.cpp:

(WebKitTests::FakeCCSchedulerClient::reset):
(WebKitTests::FakeCCSchedulerClient::hasAction):
(FakeCCSchedulerClient):
(WebKitTests::FakeCCSchedulerClient::scheduledActionDrawAndSwapIfPossible):
(WebKitTests::FakeCCSchedulerClient::scheduledActionDrawAndSwapForced):
(WebKitTests::FakeCCSchedulerClient::setDrawWillHappen):
(WebKitTests::FakeCCSchedulerClient::setSwapWillHappenIfDrawHappens):
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::scheduledActionDrawAndSwapIfPossible):
(WebKitTests::SchedulerClientThatSetNeedsDrawInsideDraw::scheduledActionDrawAndSwapForced):
(SchedulerClientThatSetNeedsDrawInsideDraw):
(WebKitTests::TEST):
(WebKitTests::SchedulerClientThatSetNeedsCommitInsideDraw::scheduledActionDrawAndSwapIfPossible):
(WebKitTests::SchedulerClientThatSetNeedsCommitInsideDraw::scheduledActionDrawAndSwapForced):
(SchedulerClientThatSetNeedsCommitInsideDraw):
(WebKitTests):

14:43 Changeset [112445] by ericu@chromium.org
  • 3 edits in trunk/Source/WebCore

FileWriter has two race conditions
https://bugs.webkit.org/show_bug.cgi?id=81861

Reviewed by David Levin.

Should make current tests less flaky.

  • Modules/filesystem/FileWriter.h:
  • Modules/filesystem/FileWriter.cpp:

Track the in-flight operation, whether it be an abort/write/truncate.
Whether an abort comes back as didWrite, didTruncate, or didFail, handle
it appropriately. Before this fix, the Chromium implementation would
assert in two cases:

If the user calls abort, then write, then abort before the backend
catches up, we'd send both aborts to the backend, even though it hadn't
received the write yet. Chromium's backend asserts if there's an abort
with no write in progress. We now record that we've sent an abort and
are waiting for the response.

If the user calls abort while a write/truncate is just finishing, on the
Chromium worker implementation, the completion message could be
thread-hopping back to WebCore at the
WorkerAsyncFileWriterCallbacksBridge while the abort is thread-hopping
in the other direction. Again, this leads to an abort call to the
backend with no write in progress, and an assert. We're now robust to
completions coming back when we're expecting an abort, and
https://chromiumcodereview.appspot.com/9764018/ will make the backend
robust to extra abort calls.

14:41 Changeset [112444] by rniwa@webkit.org
  • 14 edits
    2 moves
    2 deletes in trunk

Deleting a paragraph of text should not add elements for typing style
https://bugs.webkit.org/show_bug.cgi?id=82401

Reviewed by Enrica Casucci.

Source/WebCore:

This behavior was explicitly supported by DeleteSelectionCommand but it doesn't match TextEdit or Firefox.
We're changing our behavior to match TextEdit and Firefox in this patch.

The behavior is tested by an existing test, which was renamed to deleting-text-rests-typing-style.html in this patch.

Test: editing/execCommand/deleting-text-rests-typing-style.html

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete):

LayoutTests:

Rebaselined the tests per behavior changes. Also renamed 19653-3.html to deleting-text-rests-typing-style.html
which tests this behavioral change.

  • editing/deleting/delete-and-cleanup-expected.txt:
  • editing/deleting/delete-and-cleanup.html: Elements added for typing styles have been removed.
  • editing/deleting/delete-br-012-expected.txt: Ditto.
  • editing/deleting/delete-select-all-001-expected.txt: Ditto.
  • editing/execCommand/19653-3-expected.txt: Removed.
  • editing/execCommand/19653-3.html: Removed.
  • editing/execCommand/apply-style-text-decoration-crash-expected.txt:
  • editing/execCommand/delete-image-in-anchor-expected.txt: Ditto.
  • editing/execCommand/deleting-text-rests-typing-style-expected.txt: Copied from LayoutTests/editing/execCommand/19653-3-expected.txt.
  • editing/execCommand/deleting-text-rests-typing-style.html: Copied from LayoutTests/editing/execCommand/19653-3.html.
  • editing/inserting/5994480-2-expected.txt:
  • editing/inserting/5994480-2.html: Ditto; converted this test to a dump-as-markup test for clarity.
  • editing/pasteboard/paste-text-with-style-2-expected.txt: Elements added for typing styles have been removed.
  • editing/style/block-style-005-expected.txt: Ditto.
  • editing/pasteboard/select-element-1-expected.txt: Editing delegate dump changed but the final result remains intact.
14:33 Changeset [112443] by simon.fraser@apple.com
  • 3 edits in trunk/Tools

download-built-product build step should detect 404 errors
https://bugs.webkit.org/show_bug.cgi?id=82491

Reviewed by Ryosuke Niwa.

Pass --fail to curl so that it reports 404 errors.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(DownloadBuiltProduct): Pass --fail to curl so that it reports errors.

  • BuildSlaveSupport/built-product-archive:

(extractBuiltProduct): Remove trailing whitespace.

14:29 Changeset [112442] by dpranke@chromium.org
  • 2 edits in trunk/Tools

flakiness dashboard should only keep the last 500 runs
https://bugs.webkit.org/show_bug.cgi?id=82530

Reviewed by Ojan Vafai.

If a bot has an overly large amount of failing tests, then
storing 750 runs' worth takes a lot of memory and CPU time to
process and we end up getting killed by AppEngine; this cases
data corruption and confusion down the road when we have to
retry the upload of the data and the tests show up as multiple
runs.

  • TestResultServer/model/jsonresults.py:

(JsonResults.update_file):

14:26 Changeset [112441] by ojan@chromium.org
  • 15 edits
    2 copies
    4 moves
    28 adds in trunk/LayoutTests

More Chromium rebaselines from the expected failures tab in garden-o-matic.
They all looked like straightforward text-rendering or anti-aliasing issues,
except for some where the new results were clearly just more correct.

  • fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.png: Copied from LayoutTests/platform/efl/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.png.
  • platform/chromium-linux/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
  • platform/chromium-linux/fast/dynamic/containing-block-change-expected.png: Added.
  • platform/chromium-linux/fast/dynamic/first-letter-display-change-expected.png: Added.
  • platform/chromium-linux/fast/dynamic/window-resize-scrollbars-test-expected.png:
  • platform/chromium-linux/fast/events/updateLayoutForHitTest-expected.png: Renamed from LayoutTests/platform/efl/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.png.
  • platform/chromium-linux/fast/events/updateLayoutForHitTest-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/dom/HTMLInputElement/input-image-alt-text-expected.png: Added.
  • platform/chromium-mac-leopard/fast/dom/getElementsByClassName/011-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/dynamic/containing-block-change-expected.png: Added.
  • platform/chromium-mac-leopard/fast/dynamic/window-resize-scrollbars-test-expected.png: Added.
  • platform/chromium-mac-leopard/fast/events/updateLayoutForHitTest-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/52776-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom/52776-expected.txt:
  • platform/chromium-mac-snowleopard/fast/dom/HTMLInputElement/input-image-alt-text-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dynamic/containing-block-change-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dynamic/window-resize-scrollbars-test-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/encoding/utf-16-big-endian-expected.png:
  • platform/chromium-mac-snowleopard/fast/encoding/utf-16-little-endian-expected.png:
  • platform/chromium-mac-snowleopard/fast/events/reveal-link-when-focused-expected.png:
  • platform/chromium-mac-snowleopard/fast/events/updateLayoutForHitTest-expected.png: Added.
  • platform/chromium-mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.png: Added.
  • platform/chromium-mac/fast/dynamic/containing-block-change-expected.png: Added.
  • platform/chromium-mac/fast/dynamic/window-resize-scrollbars-test-expected.png: Added.
  • platform/chromium-mac/fast/dynamic/window-resize-scrollbars-test-expected.txt: Added.
  • platform/chromium-mac/fast/encoding/utf-16-big-endian-expected.png: Added.
  • platform/chromium-mac/fast/encoding/utf-16-big-endian-expected.txt: Added.
  • platform/chromium-mac/fast/encoding/utf-16-little-endian-expected.png: Added.
  • platform/chromium-mac/fast/encoding/utf-16-little-endian-expected.txt: Added.
  • platform/chromium-mac/fast/events/reveal-link-when-focused-expected.png: Added.
  • platform/chromium-mac/fast/events/updateLayoutForHitTest-expected.png: Added.
  • platform/chromium-mac/fast/events/updateLayoutForHitTest-expected.txt: Added.
  • platform/chromium-win/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
  • platform/chromium-win/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
  • platform/chromium-win/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.png: Renamed from LayoutTests/platform/gtk/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.png.
  • platform/chromium-win/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt: Added.
  • platform/chromium-win/fast/dynamic/containing-block-change-expected.png: Added.
  • platform/chromium-win/fast/dynamic/containing-block-change-expected.txt: Added.
  • platform/chromium-win/fast/dynamic/first-letter-display-change-expected.png: Added.
  • platform/chromium-win/fast/dynamic/window-resize-scrollbars-test-expected.png:
  • platform/chromium-win/fast/dynamic/window-resize-scrollbars-test-expected.txt:
  • platform/chromium/fast/dom/Window/get-set-properties-expected.txt:
  • platform/chromium/fast/dom/Window/window-property-descriptors-expected.txt: Copied from LayoutTests/fast/dom/Window/window-property-descriptors-expected.txt.
  • platform/chromium/fast/dom/Window/window-property-shadowing-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/efl/fast/dom/Window/window-property-descriptors-expected.txt: Renamed from LayoutTests/fast/dom/Window/window-property-descriptors-expected.txt.
  • platform/mac/fast/dynamic/first-letter-display-change-expected.txt: Renamed from LayoutTests/fast/dynamic/first-letter-display-change-expected.txt.
14:21 Changeset [112440] by rniwa@webkit.org
  • 2 edits in trunk/Tools

extract-built-product build step should fail if unzipping fails
https://bugs.webkit.org/show_bug.cgi?id=82493

Reviewed by Simon Fraser.

Forward non-zero exit code from subprocesses so that the master can detect any failures
and bail out early.

  • BuildSlaveSupport/built-product-archive:

(main):

14:18 Changeset [112439] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Add tracing events around CCLayerTreeHostImpl visibility.
https://bugs.webkit.org/show_bug.cgi?id=82501

Patch by Michal Mocny <mmocny@google.com> on 2012-03-28
Reviewed by James Robinson.

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::setVisible):

14:00 Changeset [112438] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Incorrect foreignObject hit test results when overlapping other SVG elements
https://bugs.webkit.org/show_bug.cgi?id=82059

Patch by Florin Malita <fmalita@google.com> on 2012-03-28
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Test: svg/hittest/foreign-object-background.svg

Foreign content needs to be hit-tested atomically due to the (pseudo)
stacking context established by FOs.

  • rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::nodeAtFloatPoint):
Hit test all phases on FO HitTestForeground.

LayoutTests:

  • svg/hittest/foreign-object-background-expected.txt: Added.
  • svg/hittest/foreign-object-background.svg: Added.
13:59 Changeset [112437] by dpranke@chromium.org
  • 5 edits in trunk/Tools

test-webkitpy should support files, directories, and packages as command line args
https://bugs.webkit.org/show_bug.cgi?id=76765

Reviewed by Adam Barth.

This patch adds support for specifying files, directories, and
packages to test-webkitpy along with the already existing
support for modules, test classes, and individual test names.

Also, fix a bug in filesystem_mock where we wouldn't normalize a
path containing a reference to the current directory properly,
for example, '/foo/./bar.py'.

  • Scripts/webkitpy/common/system/filesystem_mock.py:

(MockFileSystem.normpath):

  • Scripts/webkitpy/test/main.py:

(Tester._configure_logging):
(Tester._run_tests):

  • Scripts/webkitpy/test/test_finder.py:

(TestDirectoryTree.find_modules):
(TestDirectoryTree.subpath):
(TestFinder.is_dotted_name):
(TestFinder.find_names):
(TestFinder):
(TestFinder._find_names_for_arg):
(TestFinder._find_in_trees):
(TestFinder._default_names):

  • Scripts/webkitpy/test/test_finder_unittest.py:

(TestFinderTest.setUp):
(TestFinderTest.tearDown):
(TestFinderTest.check_names):
(TestFinderTest.test_default_names):
(TestFinderTest):
(TestFinderTest.test_paths):

13:42 Changeset [112436] by shawnsingh@chromium.org
  • 11 edits in trunk

[chromium] layer->clipRect() is not initialized for layers that create a renderSurface.
https://bugs.webkit.org/show_bug.cgi?id=74147

Reviewed by Adrienne Walker.

Source/WebCore:

Added 3 additional unit tests; Modified existing unit tests and layout tests.

The layer's clipRect and usesLayerClipping information was not
being initialized for layers that created a renderSurface. (It
was, however, being initialized for the renderSurface itself.)
This patch adds a unit test that reproduces that this is an error,
other unit tests to tightly test the value of clipRect being
initialized, and adds the logic to properly initialize the
clipRect.

Before this patch, this bug was causing flashing on tab-switch on
the apple iphone page. Even worse, with partial swap enabled, the
layers would simply disappear, because the first frame the
clipRect is uninitialized and the layer is not drawn, and the
second frame onwards, the damage tracker correctly things nothing
is damaged, so it doesn't draw that layer again until other damage
causes it to be redrawn.

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsAndVisibilityInternal):

Source/WebKit/chromium:

Added 3 more unit tests. One reproduces the clipRect problem in an
integrated manner, the other two directly test that clipRects are
properly initialized.

  • tests/CCLayerTreeHostCommonTest.cpp:

(WebCore::TEST):
(WebCore):

  • tests/CCLayerTreeTestCommon.h:

(WebKitTests):

LayoutTests:

  • platform/chromium/test_expectations.txt: marked test as needing rebaselining
13:41 Changeset [112435] by simon.fraser@apple.com
  • 3 edits in trunk/Tools

Fix inspector tests when running in internal builds.

<rdar://problem/11050694>

Reviewed by Tim Hatcher.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

13:36 Changeset [112434] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

"Sticky" or slow scrolling on some sites
https://bugs.webkit.org/show_bug.cgi?id=82512
<rdar://problem/11000372>

Reviewed by Andreas Kling.

When we're in the slow mode and have to update the scroll layer position on the main thread,
get it from the scrolling thread so we'll be in sync with the scrolling tree when the main thread is busy.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::updateMainFrameScrollPositionAndScrollLayerPosition):

  • page/scrolling/ScrollingCoordinator.h:

(ScrollingCoordinator):

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::mainFrameScrollPosition):
(WebCore):
(WebCore::ScrollingTree::updateMainFrameScrollPositionAndScrollLayerPosition):

  • page/scrolling/ScrollingTree.h:
13:29 Changeset [112433] by jam@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Update worker-multi-port-expected.txt.

https://bugs.webkit.org/show_bug.cgi?id=82499

Reviewed by James Robinson.

  • platform/chromium-win/fast/workers/worker-multi-port-expected.txt:
13:20 Changeset [112432] by enne@google.com
  • 12 edits in trunk/Source

[chromium] Fix tiled layer assert for huge layers
https://bugs.webkit.org/show_bug.cgi?id=82486

Reviewed by James Robinson.

Source/WebCore:

Test: TiledLayerChromiumTest.hugeLayerUpdateCrash

TilingData::numTiles() is calculated as the product of two ints and so
can potentially overflow, causing numTiles() to be incorrect. To avoid
calling code accidentally falling into this trap, remove this function
and all code that uses tile index from TilingData. This requires
fixing up a bunch of callers of TilingData and CCLayerTilingData.

Additionally, TilingData::numTiles() has long been a confusing
function name in some contexts, so rename to bool hasEmptyBounds().

Also, remove TilingData::intersectDrawQuad because there are no
clients of that function.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::drawsContent):
(WebCore::TiledLayerChromium::reserveTextures):
(WebCore::TiledLayerChromium::prepareToUpdate):
(WebCore::TiledLayerChromium::prepareToUpdateIdle):
(WebCore::TiledLayerChromium::needsIdlePaint):
(WebCore::TiledLayerChromium::idlePaintRect):

  • platform/graphics/chromium/cc/CCLayerTilingData.cpp:

(WebCore::CCLayerTilingData::tileRect):

  • platform/graphics/chromium/cc/CCLayerTilingData.h:

(WebCore::CCLayerTilingData::hasEmptyBounds):
(WebCore::CCLayerTilingData::tileBounds):
(WebCore::CCLayerTilingData::isEmpty):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::bindContentsTexture):
(WebCore::CCTiledLayerImpl::appendQuads):

  • platform/graphics/gpu/Texture.cpp:

(WebCore::Texture::create):
(WebCore::Texture::updateSubRect):

  • platform/graphics/gpu/TilingData.cpp:

(WebCore::TilingData::tileBounds):
(WebCore::TilingData::tileBoundsWithBorder):
(WebCore::TilingData::tileBoundsNormalized):

  • platform/graphics/gpu/TilingData.h:

(WebCore::TilingData::hasEmptyBounds):
(TilingData):
(WebCore::TilingData::assertTile):

Source/WebKit/chromium:

Add test for updating a huge layer that would assert prior to this
code. Fix up TilingData tests to use a testing class that provides a
safe version of numTiles().

  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):
(WTF):

  • tests/TilingDataTest.cpp:

(TestTiling):
(WebCore::TestTiling::TestTiling):
(WebCore::TestTiling::numTiles):
(WebCore):
(WebCore::TEST):

13:13 Changeset [112431] by ddkilzer@apple.com
  • 4 edits in trunk/Tools

Use xcrun to find nm and ranlib on OS X builds
<http://webkit.org/b/82466>

Reviewed by Dan Bernstein.

  • Scripts/build-webkit: Use xcrun to find ranlib.
  • Scripts/webkitdirs.pm:

(determineNmPath): Added. Use xcrun to find nm on OS X.
(nmPath): Added.

  • Scripts/webkitperl/features.pm:

(libraryContainsSymbol): Use nmPath().

12:58 Changeset [112430] by kerz@chromium.org
  • 1 copy in branches/chromium/1084/codereview.settings

Codereview settings for the branch.

12:56 Changeset [112429] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

More flaky tests.

Unreviewed, expectations update.

  • platform/chromium/test_expectations.txt:
12:44 Changeset [112428] by vsevik@chromium.org
  • 18 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: switch Runtime, Network and DOM domains to typed API
https://bugs.webkit.org/show_bug.cgi?id=81558

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-03-28
Reviewed by Pavel Feldman.

Client code is switched to typed API (all InspectorObject and InspectorArray types are
replaced with generated types from TypeBuilder according to Inspector.json).

Missing array of int specialization is added. Code generator now has a check against
misspelled (non-existing) domain names.

  • inspector/CodeGeneratorInspector.py:

(Generator.go): check against misspelled domain names added.

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::evaluate):
(WebCore::InjectedScript::callFunctionOn):
(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::getProperties):
(WebCore::InjectedScript::wrapObject):
(WebCore::InjectedScript::wrapNode):
(WebCore::InjectedScript::wrapSerializedObject):
(WebCore::InjectedScript::makeEvalCall):

  • inspector/InjectedScript.h:

(InjectedScript):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::getDocument):
(WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
(WebCore::InspectorDOMAgent::querySelectorAll):
(WebCore::InspectorDOMAgent::pushNodePathToFrontend):
(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::getSearchResults):
(WebCore::InspectorDOMAgent::resolveNode):
(WebCore::InspectorDOMAgent::getAttributes):
(WebCore::InspectorDOMAgent::buildObjectForNode):
(WebCore::InspectorDOMAgent::buildArrayForElementAttributes):
(WebCore::InspectorDOMAgent::buildArrayForContainerChildren):
(WebCore::InspectorDOMAgent::loadEventFired):
(WebCore::InspectorDOMAgent::didInsertDOMNode):
(WebCore::InspectorDOMAgent::styleAttributeInvalidated):
(WebCore::InspectorDOMAgent::pushNodeByPathToFrontend):

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::resourceTypeJson):
(WebCore::InspectorPageAgent::cachedResourceTypeJson):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):

  • inspector/InspectorPageAgent.h:
  • inspector/InspectorResourceAgent.cpp:

(WebCore::buildObjectForResourceRequest):
(WebCore::buildObjectForResourceResponse):
(WebCore::buildObjectForCachedResource):
(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::didReceiveResponse):
(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
(WebCore::InspectorResourceAgent::buildInitiatorObject):
(WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
(WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):

  • inspector/InspectorResourceAgent.h:

(InspectorResourceAgent):

  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):
(WebCore::InspectorRuntimeAgent::getProperties):

  • inspector/InspectorRuntimeAgent.h:

(InspectorRuntimeAgent):

  • inspector/InspectorValues.h:

(InspectorArray):
(WebCore::InspectorArray::pushInt):
(WebCore):

  • inspector/ScriptCallFrame.cpp:

(WebCore::ScriptCallFrame::buildInspectorObject):

  • inspector/ScriptCallFrame.h:

(ScriptCallFrame):

  • inspector/ScriptCallStack.cpp:

(WebCore::ScriptCallStack::buildInspectorArray):

  • inspector/ScriptCallStack.h:

(ScriptCallStack):

12:30 Changeset [112427] by jamesr@google.com
  • 11 edits in branches/chromium/1084/Source/WebCore

Revert 112163 - Use PassRefPtr in V8DOMWrapper interface to avoid explicit ref() calls
https://bugs.webkit.org/show_bug.cgi?id=82238

Reviewed by Adam Barth.

The setJSWrapper* methods previously featured a comment that asked
callers to ref the objects before passing them in. This change makes
that contract explicit (and allows the removal of the comment).

In addition, for ConstructorCallbacks, this change slightly reduces
refcount churn by passing on the initial ref via RefPtr::release().

No new tests, no change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateConstructorCallback): Use RefPtr::release() to avoid refcount churn and remove explicit ref() call.
(GenerateNamedConstructorCallback): ditto.

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::installDOMWindow): Cast to a PassRefPtr and remove explicit ref call.

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::setJSWrapperForDOMNode): Pass leaked refs into the DOMNodeMaps.

  • bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper): Make the setJSWrapperFor* methods take PassRefPtr<T>.
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject): Pass leaked ref into the DOMObjectMap.
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMObject): Pass leaked ref into the ActiveDOMObjectMap.

  • bindings/v8/V8Proxy.h:

(WebCore::toV8): Remove explicit ref.

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::initContextIfNeeded): Cast to a PassRefPTr and remove explicit ref call.

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::v8HTMLImageElementConstructorCallback): Use RefPtr::release() to avoid refcount churn and remove explicit ref.

  • bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:

(WebCore::V8WebKitMutationObserver::constructorCallback): ditto.

  • bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::constructorCallback): ditto.

  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:

(WebCore::V8XMLHttpRequest::constructorCallback): ditto.

TBR=adamk@chromium.org

12:29 April 2012 Meeting edited by rniwa@webkit.org
Add more topics (diff)
12:28 Changeset [112426] by jamesr@google.com
  • 14 edits in branches/chromium/1084/Source/WebCore

Revert http://trac.webkit.org/changeset/112318

12:25 Changeset [112425] by eric@webkit.org
  • 22 edits in trunk/Source/WebCore

setNeedsLayout(true, false) is super confusing to read and should use an enum instead
https://bugs.webkit.org/show_bug.cgi?id=82369

Reviewed by Julien Chaffraix.

I replaced all uses of the markParents bool with a MarkingBehavior
enum (which has two values: MarkContainingBlockChain and MarkOnlyThis).
I'm not sure the naming is perfect (as it's not clear to me if markParents is
used to mean the same thing in these 3 functions), but hopefully this code is more
clear. I welcome further suggested adjustment from layout experts.

  • page/FrameView.cpp:

(WebCore::FrameView::scheduleRelayout):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::adjustPositionedBlock):
(WebCore::RenderBlock::layoutBlockChildren):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::markForPaginationRelayoutIfNeeded):
(WebCore::RenderBlock::removePositionedObjects):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
(WebCore::RenderBlock::adjustBlockChildForPagination):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloats):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::positionNewFloatOnLine):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::positionLineBox):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
(WebCore::gatherFlexChildrenInfo):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::prepareChildForPositionedLayout):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateScrollInfoAfterLayout):

  • rendering/RenderMedia.cpp:

(WebCore::RenderMedia::layout):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::setPreferredLogicalWidthsDirty):

  • rendering/RenderObject.h:

(RenderObject):
(WebCore::RenderObject::setNeedsLayout):
(WebCore::RenderObject::setChildNeedsLayout):

  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::layoutSpecialExcludedChild):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::layout):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::layoutSpecialExcludedChild):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::layout):

  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):
(WebCore::RenderView::layout):

  • rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::layout):

  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::layout):

  • rendering/mathml/RenderMathMLSubSup.cpp:

(WebCore::RenderMathMLSubSup::layout):

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::layoutChildren):

12:22 Changeset [112424] by commit-queue@webkit.org
  • 9 edits in trunk/Source

<http://webkit.org/b/82419> Web Inspector: Create -[DOMNode inspect] from IDL

Source/WebCore:

Instead of manually creating the method in DOM.mm we can specify it in
Node.idl and autogenerate part of the interface.

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-03-28
Reviewed by Timothy Hatcher.

  • bindings/objc/DOM.mm:
  • bindings/objc/DOMPrivate.h:

Move the call to InspectorController::inspect from here ...

  • dom/Node.h:
  • dom/Node.idl: IDL only in an ObjC block.
  • dom/Node.cpp:

(WebCore::Node::inspect):
... to here.

  • WebCore.xcodeproj/project.pbxproj:

Add the new generated file so we can Copy it in the build phase.

Source/WebKit/mac:

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-03-28
Reviewed by Timothy Hatcher.

  • MigrateHeaders.make: Copy DOMNodePrivate.h to PrivateHeaders.
12:19 Changeset [112423] by ojan@chromium.org
  • 5 edits in trunk/Tools

Add history navigation to garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=82495

Reviewed by Dimitri Glazkov.

Also, maintain scroll offsets when returning to a tab. This makes addressing
expected failures considerably easier when dealing with below-the-fold tests.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:

-Store the scrollTop before switching to a new tab and restore the appropriate scrollTop after
switching.
-Modify window.location with the tabName in the hash. Can't use pushState because this is served
from a file URL and Chrome puts each different file URL in it's own origin.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:

Remove the href so that clicking on the accordion item does not modify window.location.hash.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
11:49 Changeset [112422] by kerz@chromium.org
  • 1 copy in branches/chromium/1084

Branching for 1084

11:44 Changeset [112421] by tommyw@google.com
  • 7 edits
    1 copy
    4 adds in trunk/Source

[chromium] MediaStream API (JSEP): Introducing WebPeerConnection00Handler
https://bugs.webkit.org/show_bug.cgi?id=82450

Reviewed by Adam Barth.

Source/WebCore:

This change removes the default PeerConnection00Handler.cpp from the Chromium build.

A major overhaul of the existing layout tests is forthcoming.

  • WebCore.gypi:
  • platform/mediastream/PeerConnection00Handler.h:

(WebCore):
(PeerConnection00Handler):

Source/WebKit/chromium:

Last patch to enable the PeerConnection00 functionality in Chromium introduces
WebPeerConnection00Handler and WebPeerConnection00HandlerClient, together with the necessary plumbing.

  • WebKit.gyp:
  • bridge/PeerConnection00Handler.cpp: Added.

(WebCore):
(WebCore::PeerConnection00Handler::create):
(WebCore::PeerConnection00Handler::PeerConnection00Handler):
(WebCore::PeerConnection00Handler::~PeerConnection00Handler):
(WebCore::PeerConnection00Handler::createOffer):
(WebCore::PeerConnection00Handler::createAnswer):
(WebCore::PeerConnection00Handler::setLocalDescription):
(WebCore::PeerConnection00Handler::setRemoteDescription):
(WebCore::PeerConnection00Handler::localDescription):
(WebCore::PeerConnection00Handler::remoteDescription):
(WebCore::PeerConnection00Handler::startIce):
(WebCore::PeerConnection00Handler::processIceMessage):
(WebCore::PeerConnection00Handler::addStream):
(WebCore::PeerConnection00Handler::removeStream):
(WebCore::PeerConnection00Handler::stop):

  • bridge/PeerConnection00HandlerInternal.cpp: Added.

(WebCore):
(WebCore::PeerConnection00HandlerInternal::PeerConnection00HandlerInternal):
(WebCore::PeerConnection00HandlerInternal::~PeerConnection00HandlerInternal):
(WebCore::PeerConnection00HandlerInternal::createOffer):
(WebCore::PeerConnection00HandlerInternal::createAnswer):
(WebCore::PeerConnection00HandlerInternal::setLocalDescription):
(WebCore::PeerConnection00HandlerInternal::setRemoteDescription):
(WebCore::PeerConnection00HandlerInternal::localDescription):
(WebCore::PeerConnection00HandlerInternal::remoteDescription):
(WebCore::PeerConnection00HandlerInternal::startIce):
(WebCore::PeerConnection00HandlerInternal::processIceMessage):
(WebCore::PeerConnection00HandlerInternal::addStream):
(WebCore::PeerConnection00HandlerInternal::removeStream):
(WebCore::PeerConnection00HandlerInternal::stop):
(WebCore::PeerConnection00HandlerInternal::didGenerateICECandidate):
(WebCore::PeerConnection00HandlerInternal::didChangeReadyState):
(WebCore::PeerConnection00HandlerInternal::didChangeICEState):
(WebCore::PeerConnection00HandlerInternal::didAddRemoteStream):
(WebCore::PeerConnection00HandlerInternal::didRemoveRemoteStream):

  • bridge/PeerConnection00HandlerInternal.h: Copied from Source/WebCore/platform/mediastream/PeerConnection00Handler.h.

(WebKit):
(WebCore):
(PeerConnection00HandlerInternal):

  • public/platform/WebKitPlatformSupport.h:

(WebKit):
(WebKit::WebKitPlatformSupport::createPeerConnection00Handler):

  • public/platform/WebPeerConnection00Handler.h: Added.

(WebKit):
(WebPeerConnection00Handler):
(WebKit::WebPeerConnection00Handler::~WebPeerConnection00Handler):

  • public/platform/WebPeerConnection00HandlerClient.h: Added.

(WebKit):
(WebPeerConnection00HandlerClient):
(WebKit::WebPeerConnection00HandlerClient::~WebPeerConnection00HandlerClient):

  • src/AssertMatchingEnums.cpp:
11:37 Changeset [112420] by eae@chromium.org
  • 4 edits in branches/subpixellayout/Source

Build fixes for chromium linux

11:32 Changeset [112419] by robert@webkit.org
  • 2 edits in trunk/Source/WebCore

[REGRESSION] Web Inspector: column caption delimiters are misaligned in DataGrid
https://bugs.webkit.org/show_bug.cgi?id=82193

Reviewed by Yury Semikhatsky.

Since r111742 column width in fixed layout tables is set to the width of the cell plus its left padding plus its right padding
plus half its left border plus half its right border in the collapsing border model. The layout of the panel
headers in the inspector depended on pre-r111742 behaviour, so ended up misaligned with the content below. To cater for the
new method of calculating column width enforce a fixed width for the corner column by removing padding and borders (except collapsed
borders from adjacent cells) and specify the expected width (15px) minus the expected width of the collapsed borders (1px).

  • inspector/front-end/dataGrid.css:

(.data-grid th.corner):

11:29 Changeset [112418] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

Increase code sharing between CSSProperty and CSSPropertyLonghand.
https://bugs.webkit.org/show_bug.cgi?id=82479

Reviewed by Antti Koivisto.

Use longhands declarations from CSSPropertyLonghand in CSSProperty to avoid
code duplication.

No new tests : refactoring only, we shouldn't have any behavior difference.

  • css/CSSProperty.cpp:

(WebCore::resolveToPhysicalProperty):
(WebCore::borderDirections):
(WebCore):
(WebCore::CSSProperty::resolveDirectionAwareProperty):

11:24 Changeset [112417] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Compositor visibility setting must be updated even if not actively compositing
https://bugs.webkit.org/show_bug.cgi?id=82406

Patch by James Robinson <jamesr@chromium.org> on 2012-03-28
Reviewed by Adrienne Walker.

Propagate the visibility bit to the WebLayerTreeView even when compositing is inactive.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setVisibilityState):

11:23 Changeset [112416] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Implement snippets renaming in scripts navigator.
https://bugs.webkit.org/show_bug.cgi?id=82477

Reviewed by Pavel Feldman.

Snippets renaming is implemented as editing of snippet name in scripts navigator.

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator.prototype._handleRenameSnippet):
(WebInspector.ScriptsNavigator.prototype._fileRenamed):
(WebInspector.ScriptsNavigator.prototype.rename.commitHandler):
(WebInspector.ScriptsNavigator.prototype.rename.cancelHandler):
(WebInspector.ScriptsNavigator.prototype.rename.afterEditing):
(WebInspector.BaseNavigatorTreeElement.prototype.set titleText):

  • inspector/front-end/scriptsPanel.css:

(#scripts-navigator-tabbed-pane .navigator .base-navigator-tree-element-title.editing):

11:20 Changeset [112415] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

REGRESSION (r109826): Can't type into Flash text fields
https://bugs.webkit.org/show_bug.cgi?id=82488
<rdar://problem/11022004>

Reviewed by Sam Weinig.

This was caused by the fix in r109826. Revert that change and fix the original bug by notifying the UI process
that the plug-in lost focus when it's destroyed. This will correctly reset the text input state (merely setting
the text input state to PluginComplexTextInputDisabled doesn't reset the state correctly).

  • UIProcess/API/mac/WKView.mm:

(-[WKView _setPluginComplexTextInputState:]):
(-[WKView _handlePluginComplexTextInputKeyDown:]):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::~PluginView):

11:13 Changeset [112414] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Add context menu for snippets control.
https://bugs.webkit.org/show_bug.cgi?id=82475

Reviewed by Pavel Feldman.

This is a preliminary implementation of snippets control using context menu.
We might want to add a more discoverable one before taking snippets out of experiments.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator.prototype._showScriptFoldersSettingChanged):
(WebInspector.ScriptsNavigator.prototype._createSnippetsTree):
(WebInspector.ScriptsNavigator.prototype._handleSnippetContextMenuEvent):
(WebInspector.ScriptsNavigator.prototype._showSnippetContextMenu):
(WebInspector.ScriptsNavigator.prototype._handleEvaluateSnippet):
(WebInspector.ScriptsNavigator.prototype._handleRenameSnippet):
(WebInspector.ScriptsNavigator.prototype._handleRemoveSnippet):
(WebInspector.ScriptsNavigator.prototype._handleCreateSnippet):
(WebInspector.NavigatorScriptTreeElement.prototype.get navigator):
(WebInspector.NavigatorScriptTreeElement.prototype.onattach):
(WebInspector.NavigatorScriptTreeElement.prototype.onenter):
(WebInspector.NavigatorScriptTreeElement.prototype._handleContextMenuEvent):

11:08 Changeset [112413] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: ScriptsNavigator should save scroll position when switching tabs.
https://bugs.webkit.org/show_bug.cgi?id=82472

Reviewed by Pavel Feldman.

WebInspector.View provides save/restore scroll position capabilities.
This patch makes them used in ScriptsNavigator.

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator):
(WebInspector.ScriptsNavigator.prototype._createSnippetsTree):

  • inspector/front-end/scriptsPanel.css:

(#scripts-navigator-tabbed-pane .tabbed-pane-content):
(#scripts-navigator-tabbed-pane .navigator-container):

11:00 Changeset [112412] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, skipping 3 tests timing out after the libsoup upgrade
to 2.37.92.

  • platform/gtk/Skipped:
10:55 Changeset [112411] by fsamuel@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Enable Viewport define by default
https://bugs.webkit.org/show_bug.cgi?id=79514

Reviewed by Darin Fisher.

  • features.gypi:
10:50 Changeset [112410] by eae@chromium.org
  • 6 edits in branches/subpixellayout/Source/WebCore

qt build fixes for branch.

10:17 Changeset [112409] by caseq@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: only update Timeline overview when really needed
https://bugs.webkit.org/show_bug.cgi?id=81909

Reviewed by Pavel Feldman.

Switch timeline overview to using raw records, thus removing dependency on instance members of
TimelinePresentationModel. This requires moving record styles/categories to static getters.

  • inspector/front-end/TimelineModel.js:

(WebInspector.TimelineModel):
(WebInspector.TimelineModel.startTime):
(WebInspector.TimelineModel.endTime):
(WebInspector.TimelineModel.duration):
(WebInspector.TimelineModel.prototype._addRecord):
(WebInspector.TimelineModel.prototype.reset):
(WebInspector.TimelineModel.prototype.minimumRecordTime):
(WebInspector.TimelineModel.prototype.maximumRecordTime):
(WebInspector.TimelineModel.prototype._updateBoundaries):

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype._showTimelines):
(WebInspector.TimelineOverviewPane.prototype._showMemoryGraph):
(WebInspector.TimelineOverviewPane.prototype._setVerticalOverview):
(WebInspector.TimelineOverviewPane.prototype._onCategoryVisibilityChanged):
(WebInspector.TimelineOverviewPane.prototype._update):
(WebInspector.TimelineOverviewPane.prototype._updateCategoryStrips.markPercentagesForRecord):
(WebInspector.TimelineOverviewPane.prototype._updateCategoryStrips):
(WebInspector.TimelineOverviewPane.prototype.windowStartTime):
(WebInspector.TimelineOverviewPane.prototype.windowEndTime):
(WebInspector.TimelineOverviewPane.prototype._onWindowChanged):
(WebInspector.TimelineOverviewPane.prototype.setShowShortEvents):
(WebInspector.TimelineOverviewPane.prototype._scheduleRefresh):
(WebInspector.TimelineOverviewCalculator.prototype.computeBarGraphPercentages):
(WebInspector.TimelineOverviewCalculator.prototype.setWindow):
(WebInspector.TimelineOverviewCalculator.prototype.reset):
(WebInspector.HeapGraph):
(WebInspector.HeapGraph.prototype.update):
(WebInspector.TimelineVerticalOverview):
(WebInspector.TimelineVerticalOverview.prototype.reset):
(WebInspector.TimelineVerticalOverview.prototype.update):
(WebInspector.TimelineVerticalOverview.prototype.wasShown):
(WebInspector.TimelineVerticalOverview.prototype.willHide):
(WebInspector.TimelineVerticalOverview.prototype._aggregateFrameStatistics):
(WebInspector.TimelineVerticalOverview.prototype._aggregateRecords):
(WebInspector.TimelineVerticalOverview.prototype.getWindowTimes):
(WebInspector.TimelineVerticalOverview.prototype._onRecordAdded):
(WebInspector.TimelineAggregatedRecord):
(WebInspector.TimelineAggregatedRecord.prototype._aggregateStatistics):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._createStatusbarButtons):
(WebInspector.TimelinePanel.prototype._toggleFilterButtonClicked):
(WebInspector.TimelinePanel.prototype._resetPanel):
(WebInspector.TimelinePanel.prototype._refresh):
(WebInspector.TimelineCalculator):
(WebInspector.TimelineCalculator.prototype.formatTime):

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel):
(WebInspector.TimelinePresentationModel.categories):
(WebInspector.TimelinePresentationModel.recordStyle):
(WebInspector.TimelinePresentationModel.categoryForRecord):
(WebInspector.TimelinePresentationModel.prototype.reset):
(WebInspector.TimelinePresentationModel.prototype.addRecord):
(WebInspector.TimelinePresentationModel.Record):
(WebInspector.TimelinePresentationModel.Record.prototype.generatePopupContent):

09:33 Changeset [112408] by philn@webkit.org
  • 3 edits in trunk/Tools

[GTK] generate-gtk-doc doesn't cope with custom build directory
https://bugs.webkit.org/show_bug.cgi?id=82448

Reviewed by Martin Robinson.

Pass the product directory in generate-gtkdoc arguments from
build-webkit.

  • Scripts/webkitdirs.pm:

(buildAutotoolsProject):

  • gtk/common.py:

(get_build_path):

09:03 Changeset [112407] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebCore

[BlackBerry] Plumb through GraphicsLayer::contentsOpaque() to LayerTiler
https://bugs.webkit.org/show_bug.cgi?id=82457

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-03-28
Reviewed by Rob Buis.

The LayerTiler already knows not to turn on GL_BLEND for opaque layers.
However, it only ever sets the opaque flag for image layers and color
layers, never for content layers.

This was no big deal, because contentsOpaque() is currently false for
all layers except the root layer, which we always drew using the
BlackBerry::WebKit::BackingStore anyway.

When we start using RenderLayerBacking::m_usingTiledCacheLayer=true on
the root layer in situations where the BackingStore is unavailable, we
can speed up rendering of the root layer by honouring the opaque flag.

Fixed by plumbing through the GraphicsLayer::contentsOpaque() flag all
the way to LayerTiler and on to Texture.

  • platform/graphics/blackberry/LayerData.h:

(WebCore::LayerData::LayerData):
(WebCore::LayerData::isOpaque):
(LayerData):

  • platform/graphics/blackberry/LayerTile.cpp:

(WebCore::LayerTile::updateContents):

  • platform/graphics/blackberry/LayerTile.h:

(LayerTile):

  • platform/graphics/blackberry/LayerTiler.cpp:

(WebCore::LayerTiler::updateTextureContentsIfNeeded):
(WebCore::LayerTiler::performTileJob):

  • platform/graphics/blackberry/LayerTiler.h:

(WebCore::LayerTiler::TextureJob::TextureJob):
(WebCore::LayerTiler::TextureJob::updateContents):

  • platform/graphics/blackberry/LayerWebKitThread.h:

(WebCore::LayerWebKitThread::setOpaque):

  • platform/graphics/blackberry/Texture.h:

(Texture):

  • platform/graphics/blackberry/TextureCacheCompositingThread.cpp:

(WebCore::TextureCacheCompositingThread::updateContents):

  • platform/graphics/blackberry/TextureCacheCompositingThread.h:

(TextureCacheCompositingThread):

08:53 Changeset [112406] by carlosgc@webkit.org
  • 2 edits in trunk/Tools

[GTK] Add --skipped command line option to Tools/Scripts/run-gtk-tests
https://bugs.webkit.org/show_bug.cgi?id=82341

Reviewed by Martin Robinson.

Add --skipped=skip|ignore|only command line option.

  • Scripts/run-gtk-tests:

(TestRunner._test_cases_to_skip): Return the list of test cases
to skip for the given test depending on the skipped action.
(TestRunner._should_run_test): Decide whether to run the test or
not depending on the skipped action.
(TestRunner.run_tests): Only show the list of skipped tests when
skipped action is 'skip'.

08:49 Changeset [112405] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed: updated chromium test expectations.

  • platform/chromium/test_expectations.txt:
08:47 Changeset [112404] by carlosgc@webkit.org
  • 2 edits in trunk/Tools

[GTK] Use gtester -s to skip individual test cases instead of unit tests as a whole
https://bugs.webkit.org/show_bug.cgi?id=82333

Reviewed by Martin Robinson.

  • Scripts/run-gtk-tests:

(TestRunner.SkippedTest): Add SkippedTest class to store more
information about skipped tests.
(TestRunner._setup_testing_environment): Use SkippedTest to add
TestWebKitAccessibility to the skipped list.
(TestRunner._find_skipped_test): Return the SkippedTest object for
a given test path.
(TestRunner._test_cases_to_skip): Returns the list of test cases
that should be skipped for a given test path.
(TestRunner._should_run_test): Helper funtion to decide whether
the given test path should be run or not. Tests in the skipped
list that don't have a list of failing test cases are not run at
all. Tests in the skipped list that contain a list of test cases
are run with gtester -s to skip the individual test cases.
(TestRunner._run_test): Helper funtion to run a given test.
(TestRunner.run_tests): Build the list of tests to run based on
_should_run_test() and use helper function _run_test() to run
every test.

08:36 Changeset [112403] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: nuke HeapGraph.setSize(), do it automagically on update
https://bugs.webkit.org/show_bug.cgi?id=82471

Reviewed by Yury Semikhatsky.

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane.prototype.update):
(WebInspector.HeapGraph.prototype.update):

08:33 WebKitGTK/1.8.x edited by sergio@webkit.org
(diff)
08:20 Changeset [112402] by podivilov@chromium.org
  • 7 edits in trunk

Web Inspector: dispatch console-message-added and console-messages-cleared events on UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=82463

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Those events are related to specific UISourceCode. See bug 82224 for more details.

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessageToScript):
(WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.UISourceCodeImpl):
(WebInspector.UISourceCodeImpl.prototype.consoleMessages):
(WebInspector.UISourceCodeImpl.prototype.consoleMessageAdded):
(WebInspector.UISourceCodeImpl.prototype.consoleMessagesCleared):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype._consoleMessageAdded):
(WebInspector.JavaScriptSourceFrame.prototype._consoleMessagesCleared):
(WebInspector.JavaScriptSourceFrame.prototype._onTextViewerContentLoaded):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.breakpoints):
(WebInspector.UISourceCode.prototype.consoleMessages):

LayoutTests:

  • inspector/debugger/scripts-panel.html:
08:13 Changeset [112401] by carlosgc@webkit.org
  • 7 edits
    2 adds
    1 delete in trunk/Source

[GTK] Implement PlatformStrategies
https://bugs.webkit.org/show_bug.cgi?id=82454

Reviewed by Xan Lopez.

Source/WebCore:

  • GNUmakefile.list.am: Remove PluginDataGtk.cpp. The same

functionality is now implemented using platform strategies.

  • plugins/gtk/PluginDataGtk.cpp: Removed.

Source/WebKit/gtk:

  • GNUmakefile.am: Add new files to compilation.
  • WebCoreSupport/PlatformStrategiesGtk.cpp: Added.

(PlatformStrategiesGtk::initialize): Initialize platform
strategies.
(PlatformStrategiesGtk::PlatformStrategiesGtk):
(PlatformStrategiesGtk::createCookiesStrategy): Return this.
(PlatformStrategiesGtk::createPluginStrategy): Ditto.
(PlatformStrategiesGtk::createVisitedLinkStrategy): Ditto.
(PlatformStrategiesGtk::createPasteboardStrategy): Return 0, since
PasteboardStrategy is only used by mac code for now.
(PlatformStrategiesGtk::notifyCookiesChanged):
(PlatformStrategiesGtk::refreshPlugins): Refresh the plugin
database.
(PlatformStrategiesGtk::getPluginInfo): Initialize plugins and
populate the given vector with plugins information.
(PlatformStrategiesGtk::isLinkVisited): Return whether the given
hash is a visited link of the page group.
(PlatformStrategiesGtk::addVisitedLink): Add the given hash to the
page group visited links.

  • WebCoreSupport/PlatformStrategiesGtk.h: Added.
  • webkit/webkitglobals.cpp:

(webkitInit): Initialize PlatformStrategiesGtk.

Source/WTF:

  • wtf/Platform.h: Define WTF_USE_PLATFORM_STRATEGIES for GTK+

platform too.

08:07 Changeset [112400] by vsevik@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: [Regression] TabIndex is not correctly restored after editing.
https://bugs.webkit.org/show_bug.cgi?id=82464

Reviewed by Pavel Feldman.

This fixes incorrect usage of isNaN that returns false for null value.
Drive-by javascript compilation fix.

  • inspector/front-end/CompilerScriptMapping.js:

(WebInspector.CompilerScriptMapping.prototype.addScript): compilation fix.

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeChanged): compilation fix.

  • inspector/front-end/SnippetsModel.js:

(WebInspector.SnippetsScriptMapping.prototype._createUISourceCodeForScript): compilation fix.

  • inspector/front-end/UIUtils.js:

(WebInspector.startEditing.cleanUpAfterEditing): incorrect usage of isNaN fix.

08:00 Changeset [112399] by yi.4.shen@nokia.com
  • 3 edits
    2 adds in trunk

An extra line break is inserted when pasting into a font element.
https://bugs.webkit.org/show_bug.cgi?id=71207

Reviewed by Ryosuke Niwa.

Fix an editing bug where inserting text into a font element would
create an extra div element in the dom tree. The
WebCore::positionAvoidingPrecedingNodes() tries to set the correct
destination position by checking the next visible position, however,
it causes the position moves into the child element in somecase.
Instead, we should only check the position in parent after node.

Source/WebCore:

Test: editing/inserting/insert-text-into-font.html

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::positionAvoidingPrecedingNodes):

LayoutTests:

  • editing/inserting/insert-text-into-font-expected.txt: Added.
  • editing/inserting/insert-text-into-font.html: Added.
07:57 WebKitGTK/1.8.x edited by sergio@webkit.org
(diff)
07:56 Changeset [112398] by commit-queue@webkit.org
  • 8 edits
    8 adds in trunk/LayoutTests

[CSS Regions] Add region styling tests for interaction between region styling and scoped styles
https://bugs.webkit.org/show_bug.cgi?id=82340

Patch by Mihai Balan <mibalan@adobe.com> on 2012-03-28
Reviewed by Antti Koivisto.

Adding tests for style interaction between region styling snd scoped style elements. Currently skipped,
since scoped style elements are not enabled by default.

  • fast/regions/style-scoped-in-flow-expected.html: Added.
  • fast/regions/style-scoped-in-flow-override-container-style-expected.html: Added.
  • fast/regions/style-scoped-in-flow-override-container-style.html: Added.
  • fast/regions/style-scoped-in-flow-override-region-styling-expected.html: Added.
  • fast/regions/style-scoped-in-flow-override-region-styling-multiple-regions-expected.html: Added.
  • fast/regions/style-scoped-in-flow-override-region-styling-multiple-regions.html: Added.
  • fast/regions/style-scoped-in-flow-override-region-styling.html: Added.
  • fast/regions/style-scoped-in-flow.html: Added.
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
07:54 Changeset [112397] by ossy@webkit.org
  • 2 edits in trunk/Tools

[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
https://bugs.webkit.org/show_bug.cgi?id=52810

Reviewed by Simon Hausmann.

Use SSE2 floating point math on 32 bit instead of the default
387 to make layout test result same on 32 and on 64 bit builds.

  • qmake/mkspecs/features/unix/default_post.prf:
07:45 Changeset [112396] by sergio@webkit.org
  • 13 edits
    1 copy
    1 add in trunk

[Soup] DNS prefetching spams resolver, shoots self in the foot
https://bugs.webkit.org/show_bug.cgi?id=41630

Reviewed by Martin Robinson.

.:

Bump libsoup and glib dependencies.

  • Source/cmake/OptionsEfl.cmake:
  • configure.ac:

Source/WebCore:

Added generic DNSResolveQueue class to throttle DNS
prefetches. It's an abstract refactoring of CFNET's
DNSResolveQueue. Platform specific methods implemented for soup
and CFNET backends.

No new tests required as we're just refactoring existing code to
be used by two different ports.

  • CMakeLists.txt: added new file.
  • GNUmakefile.list.am: ditto.
  • WebCore.vcproj/WebCore.vcproj: ditto.
  • WebCore.xcodeproj/project.pbxproj: ditto.
  • platform/network/DNSResolveQueue.cpp: Added.

(WebCore):
(WebCore::DNSResolveQueue::add): adds a new host to be prefetched.
(WebCore::DNSResolveQueue::fired): by using a delay we coalesce
several prefetch requests and try to resolve them all here.

  • platform/network/DNSResolveQueue.h: Added.

(WebCore):
(DNSResolveQueue): class that implements DNS prefetch
throttling using a template pattern.
(WebCore::DNSResolveQueue::shared):
(WebCore::DNSResolveQueue::decrementRequestCount):

  • platform/network/cf/DNSCFNet.cpp:

(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences):
(WebCore::DNSResolveQueue::platformResolve):

  • platform/network/soup/DNSSoup.cpp:

(WebCore):
(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences):
(WebCore::resolvedCallback):
(WebCore::DNSResolveQueue::platformResolve):
(WebCore::prefetchDNS):

Tools:

Bump libsoup and glib dependencies.

  • efl/jhbuild.modules:
  • gtk/jhbuild.modules:
07:37 Changeset [112395] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

window.scrollBy() scrolls incorrectly when zoomed in/out
https://bugs.webkit.org/show_bug.cgi?id=45228

Patch by Eugene Girard <girard@chromium.org> on 2012-03-28
Reviewed by Simon Fraser.

scrollBy now uses layout (not CSS) units. (As scrollTo does.)

Source/WebCore:

Test: fast/dom/zoom-scroll-page-test.html

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::scrollBy):

LayoutTests:

  • fast/dom/zoom-scroll-page-test-expected.txt: Added.
  • fast/dom/zoom-scroll-page-test.html: Added.
07:33 SettingUpDevelopmentEnvironmentForN9 edited by zarvai@inf.u-szeged.hu
(diff)
07:28 Changeset [112394] by schenney@chromium.org
  • 3 edits
    2 adds in trunk

Null dereference in SVGTextElement::animatedLocalTransform()
https://bugs.webkit.org/show_bug.cgi?id=82375

Reviewed by Nikolas Zimmermann.

Source/WebCore:

A poorly structured SVG file with a text element inside an
animatedTransform element leaves the text element placed outside of
the SVG root and it has no renderer(). Later attempts to use the
renderer in animatedLocalTransform fail.

Test: svg/custom/get-text-element-transform-crash.html

  • svg/SVGTextElement.cpp:

(WebCore::SVGTextElement::animatedLocalTransform): Added a check for null renderer, and do not check
for style transform if there is no renderer.

LayoutTests:

  • svg/custom/get-text-element-transform-crash-expected.txt: Added.
  • svg/custom/get-text-element-transform-crash.html: Added.
07:19 Changeset [112393] by xan@webkit.org
  • 2 edits in trunk

[GTK] Respect NOCONFIGURE option in autogen.sh
https://bugs.webkit.org/show_bug.cgi?id=82447

Reviewed by Philippe Normand.

Make autogen.sh follow the new build-api for GNOME, see
http://people.gnome.org/~walters/docs/build-api.txt

  • autogen.sh: respect the NOCONFIGURE environment flag, per the

new GNOME build-api.

07:11 Changeset [112392] by kov@webkit.org
  • 3 edits in trunk/Tools

[GTK] Disable introspection for jhbuild modules
https://bugs.webkit.org/show_bug.cgi?id=82395

Reviewed by Philippe Normand.

  • efl/jhbuild.modules: add --disable-introspection to all modules

that support it

  • gtk/jhbuild.modules: ditto.
06:14 Changeset [112391] by zimmermann@webkit.org
  • 15 edits in trunk

Enable animVal support for SVGAnimatedPreserveAspectRatio
https://bugs.webkit.org/show_bug.cgi?id=82326

Reviewed by Zoltan Herczeg.

Source/WebCore:

Enable animVal support for SVGAnimatedPreserveAspectRatio. Very simple now that everything is prepared.
All we have to do is add startAnimValAnimation/etc. methods to SVGAnimatedPreserveAspectRatioAnimator.

Modernize SVGPreserveAspectRatio, align parsing this object from String, with the other SVG DOM primitives,
who supply a "void parse(const String&)" method, for this task.

Extended existing tests to cover this.

  • svg/SVGAnimatedPreserveAspectRatio.cpp:

(WebCore::SVGAnimatedPreserveAspectRatioAnimator::constructFromString):
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::animValWillChange):
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::animValDidChange):

  • svg/SVGAnimatedPreserveAspectRatio.h:

(SVGAnimatedPreserveAspectRatioAnimator):

  • svg/SVGAnimatedType.cpp:

(WebCore::SVGAnimatedType::valueAsString):
(WebCore::SVGAnimatedType::setValueAsString):
(WebCore::SVGAnimatedType::supportsAnimVal):

  • svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::parseAttribute):

  • svg/SVGFitToViewBox.cpp:

(WebCore::SVGFitToViewBox::parseAttribute):

  • svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::parseAttribute):

  • svg/SVGPreserveAspectRatio.cpp:

(WebCore::SVGPreserveAspectRatio::parse):
(WebCore):

  • svg/SVGPreserveAspectRatio.h:

(SVGPreserveAspectRatio):

  • svg/SVGViewSpec.cpp:

(WebCore::SVGViewSpec::setPreserveAspectRatioString):
(WebCore::SVGViewSpec::parseViewSpec):

LayoutTests:

Extend SVGAnimatedPreserveAspectRatio tests to cover animVal support.

  • svg/animations/script-tests/svgPreserveAspectRatio-animation-1.js:

(sample1):
(sample2):
(sample3):

  • svg/animations/svgPreserveAspectRatio-animation-1-expected.txt:
  • svg/dom/preserve-aspect-ratio-parser-expected.txt:
  • svg/dom/preserve-aspect-ratio-parser.html: Parsing errors now yield to 'unknown' pAR values, as desired.
06:05 Changeset [112390] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [v8] inspection of CanvasPixelArray is slow.
https://bugs.webkit.org/show_bug.cgi?id=82455

Reviewed by Vsevolod Vlasov.

Added CanvasPixelArray to the list of classes that we consider
arrays.

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::typeCallback):

06:02 Changeset [112389] by leandrogracia@chromium.org
  • 6 edits
    2 adds in trunk/Source/WebCore

Selectively retrieve text content around a given position.
https://bugs.webkit.org/show_bug.cgi?id=78361

Reviewed by Ryosuke Niwa.

Tests: a new layout test will be introduced once the required WebKit API code is ready.

Introduce the DOMTextContentWalker class to selectively retrieve content
around a given VisiblePosition into a string in such a way that a text
Range can be extracted later from a pair of the string's positions.

A new boolean called m_shouldStop is also introduced in the TextIterator to force
it advancing under certain conditions. Although this is usually done by setting
m_positionNode to zero, it can't be applied in this case since by doing so the
iterator's range is lost.

  • WebCore.gypi:
  • editing/SurroundingText.cpp: Added.

(WebCore):
(WebCore::SurroundingText::SurroundingText):
(WebCore::SurroundingText::rangeFromContentOffsets):
(WebCore::SurroundingText::content):
(WebCore::SurroundingText::positionOffsetInContent):

  • editing/SurroundingText.h: Added.

(WebCore):
(SurroundingText):

  • editing/TextIterator.cpp:

(WebCore::TextIterator::TextIterator):
(WebCore::TextIterator::advance):
(WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
(WebCore::SimplifiedBackwardsTextIterator::advance):

  • editing/TextIterator.h:

(WebCore::TextIterator::atEnd):
(TextIterator):
(WebCore::SimplifiedBackwardsTextIterator::atEnd):
(SimplifiedBackwardsTextIterator):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::enclosingFormControlElement):
(WebCore):

  • html/HTMLFormControlElement.h:

(HTMLFormControlElement):

06:02 Changeset [112388] by ossy@webkit.org
  • 2 edits in trunk/Tools

[Qt] Unreviewed, fix API tests after adding full platforms. (r111658)

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(BuildAndTestFactory.init):

05:42 SettingUpDevelopmentEnvironmentForN9 edited by zarvai@inf.u-szeged.hu
(diff)
05:40 Changeset [112387] by alexis.menard@openbossa.org
  • 10 edits in trunk

Speed up updates of existing CSS properties from JS.
https://bugs.webkit.org/show_bug.cgi?id=82235

Reviewed by Andreas Kling.

Source/WebCore:

Improve the way we handle updating an existing CSS property by replacing its value
by the new one rather than removing the old value and then adding the new one. This
speed up by 35% PerformanceTests/CSS/CSSPropertyUpdateValue.html.

No new tests : Updating existing tests that were relying on the order of the properties
after modification. Each updated property is not appended to the list of properties of the
style therefore the cssText value is slightly different. It matches Firefox behavior but not
Opera.

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::addParsedProperty):

LayoutTests:

Updated expectations after behavior change on how we handle updates of
CSS properties from JS. We match now Firefox where the cssText keeps the
order of the properties (but modify its value) whereas before we were appending
the new value at the end of the list of properties.

  • editing/pasteboard/data-transfer-items-expected.txt:
  • editing/pasteboard/onpaste-text-html-expected.txt:
  • fast/dom/css-set-property-exception-expected.txt:
  • fast/events/ondrop-text-html-expected.txt:
  • fast/mutation/observe-attributes-expected.txt:
  • fast/mutation/observe-attributes.html:
  • inspector/styles/styles-new-API-expected.txt:
05:39 Changeset [112386] by ossy@webkit.org
  • 2 edits in trunk/Tools

[Qt] Unreviewed typo fix after r112383.

  • Scripts/run-qtwebkit-tests:

(Main.check_crash_occurences):

05:31 Changeset [112385] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Use WebCore::PlatformMouseEvent::globalPosition() instead of WebCore::PlatformMouseEvent::globalPos() in WebPage.cpp
https://bugs.webkit.org/show_bug.cgi?id=82420

Reviewed by Rob Buis.

In PlatformMouseEvent.h the blackberry porting added globalPos() (but not upstreamed yet)
for PlatformMouseEvent, but this method is same as globalPosition() that is available for
every porting. We should use globalPosition().

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::updateCursor):

05:26 Changeset [112384] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Remove PlatformMouseEvent::setClickCount for BlackBerry
https://bugs.webkit.org/show_bug.cgi?id=82422

Reviewed by Rob Buis.

PlatformMouseEvent::setClickCount() is never used by BlackBerry.
The declaration was added in PlatformMouseEvent.h internally for
BlackBerry porting, but it has not been upstreamed yet.

  • platform/blackberry/PlatformMouseEventBlackBerry.cpp:
05:11 Changeset [112383] by ossy@webkit.org
  • 4 edits in trunk/Tools

[Qt] run-qtwebkit-tests should report crashes
https://bugs.webkit.org/show_bug.cgi?id=76905

Added checking of crashing tests. Now final summary includes the total number of crashing tests too.
Made unit test for this modification by János Badics <jbadics@inf.u-szeged.hu>.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-03-28
Reviewed by Csaba Osztrogonác.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunQtAPITests.commandComplete):
(RunQtAPITests.evaluateCommand):

  • BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:

(RunQtAPITestsTest):
(test_failure):
(test_crash):

  • Scripts/run-qtwebkit-tests:

(Main.announce_results_html):
(Main):
(Main.check_crash_occurences):
(Main.convert_to_stdout):
(Main.convert_to_html):

03:41 Changeset [112382] by antti@apple.com
  • 4 edits in trunk/Source/WebCore

Separate @import rules from other rules in CSSStyleSheet
https://bugs.webkit.org/show_bug.cgi?id=82384

Reviewed by Andreas Kling.

Import rules always come before all other rules (except @charset). They currently live
in the generic child rule vector. They can be moved to a vector of their own for stronger
typing and more focused traversal. This will also make future refactoring easier.

  • @import rules go to m_importRules
  • the rest go to m_childRules


  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::parserAppendRule):
(WebCore::CSSStyleSheet::length):
(WebCore::CSSStyleSheet::item):
(WebCore::CSSStyleSheet::clearRules):
(WebCore::CSSStyleSheet::rules):
(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::deleteRule):
(WebCore::CSSStyleSheet::isLoading):
(WebCore::CSSStyleSheet::addSubresourceStyleURLs):

  • css/CSSStyleSheet.h:

(WebCore):
(CSSStyleSheet):
(WebCore::CSSStyleSheet::childRules):
(WebCore::CSSStyleSheet::importRules):

03:10 Changeset [112381] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: REGRESSION: Stack overflow on the page with > 100kloc
https://bugs.webkit.org/show_bug.cgi?id=82436

Reviewed by Yury Semikhatsky.

This change migrates to manual splice implementation that uses additional
information about the range being inserted to make it work faster / allocate
less memory.

  • inspector/front-end/TextEditorModel.js:

(WebInspector.TextEditorModel.endsWithBracketRegex.):

03:09 Changeset [112380] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Tools

Add support for Intel compiler on Linux QT port.
https://bugs.webkit.org/show_bug.cgi?id=81077

Patch by Kwonjin Jeong <gram@company100.net> on 2012-03-28
Reviewed by Tor Arne Vestbø.

  • qmake/mkspecs/features/default_post.prf:

Don't hide symbols when building with Intel compiler.
The symbols are needed when building QtWebKit tests.

  • qmake/mkspecs/features/unix/icc.prf:

Added to ignore icc-specific warnings.
This feature is used with command-line arguments for build-webkit script.

02:58 Changeset [112379] by podivilov@chromium.org
  • 5 edits in trunk

Web Inspector: breakpoints are not shown in sidebar pane after reload.
https://bugs.webkit.org/show_bug.cgi?id=82351

Reviewed by Pavel Feldman.

Source/WebCore:

When UISourceCode is added to ScriptsPanel, it could already have breakpoints.
We should iterate over existing breakpoints and add them to sidebar pane.

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):

LayoutTests:

  • inspector/debugger/set-breakpoint-expected.txt:
  • inspector/debugger/set-breakpoint.html:
02:56 Changeset [112378] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] REGRESSION(r111480): It made svg/as-image tests assert
https://bugs.webkit.org/show_bug.cgi?id=82052

It also made svg/as-object tests assert

Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped: Skip failing tests.
02:12 Changeset [112377] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

[WebSocket]The Sec-WebSocket-Protocol must not appear more than once in an HTTP response
https://bugs.webkit.org/show_bug.cgi?id=82432

Patch by Li Yin <li.yin@intel.com> on 2012-03-28
Reviewed by Kent Tamura.

Source/WebCore:

From RFC6455: http://tools.ietf.org/html/rfc6455#section-11.3.4
The |Sec-WebSocket-Protocol| header field must not appear
more than once in an HTTP response.

Test: http/tests/websocket/tests/hybi/handshake-fail-by-more-protocol-header.html

  • Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::readHTTPHeaders):

LayoutTests:

From RFC6455: http://tools.ietf.org/html/rfc6455#section-11.3.4
The |Sec-WebSocket-Protocol| header field must not appear
more than once in an HTTP response.

  • http/tests/websocket/tests/hybi/handshake-fail-by-more-protocol-header-expected.txt: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-more-protocol-header.html: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-more-protocol-header_wsh.py: Added.

(web_socket_do_extra_handshake):
(web_socket_transfer_data):

01:59 Changeset [112376] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

Fix QWARN in test_loadIgnoreEmptyUrl API test.

Rubber-stamped by Csaba Osztrogonác.

  • UIProcess/API/qt/tests/qmltests/WebView/tst_loadUrl.qml:

There is no load() API of the view, we have to use the url property.

01:54 Changeset [112375] by philn@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, trivial update-webkit-libs-jhbuild system call fix.

  • Scripts/update-webkitgtk-libs: This script is written in

Perl. Not Python. So use perl vocabulary to refer to command line arguments.

01:40 Changeset [112374] by philn@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r112254.

  • platform/gtk/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/gtk/fast/forms/input-readonly-autoscroll-expected.txt:
01:26 Changeset [112373] by rniwa@webkit.org
  • 2 edits in trunk/Tools

kill-old-processes doesn't do anything on linux
https://bugs.webkit.org/show_bug.cgi?id=82388

Reviewed by Tony Chang.

Kill cc1plus, ld, etc... on linux. Also ps aux + grep to kill old run-webkit-tests processes.
This should help stabilizing Chromium linux bots.

  • BuildSlaveSupport/kill-old-processes:
01:22 Changeset [112372] by philn@webkit.org
  • 2 edits in trunk/Tools

[GTK] jhbuild wrongly tricked into clean-up
https://bugs.webkit.org/show_bug.cgi?id=82216

Reviewed by Gustavo Noronha Silva.

Save jhbuild{rc,.modules}.md5sum in Dependencies instead of the
build tree. Also when checking if the jhbuild configuration
changed use absolute md5sum paths.

  • Scripts/webkitdirs.pm:

(runAutogenForAutotoolsProjectIfNecessary):
(jhbuildConfigurationChanged):
(buildAutotoolsProject):

01:16 Changeset [112371] by ossy@webkit.org
  • 2 edits in trunk/Tools

kill-old-processes doesn't do anything on linux
https://bugs.webkit.org/show_bug.cgi?id=82388

One more attempt to disable kill-old-processes on the Qt bots not to kill each others.

The platform in Factory comes from config.json, accordingly platform is fullplatform,
for example: qt-4.8, qt-5.0-wk2. We have to check only the prefix of platform.

Reviewed by Ryosuke Niwa.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(Factory.init):

00:36 Changeset [112370] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] REGRESSION(r111480): It made svg/as-image tests assert
https://bugs.webkit.org/show_bug.cgi?id=82052

  • platform/qt/Skipped: Skip failing tests.
00:25 Changeset [112369] by ossy@webkit.org
  • 1 edit
    2 moves
    1 add in trunk/LayoutTests

[Qt] One more unreviewed gardening after r112301.

  • platform/qt-5.0/fast/dom/Window/window-properties-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk1/fast/dom/Window/window-properties-expected.png.
  • platform/qt-5.0/fast/dom/Window/window-properties-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk1/fast/dom/Window/window-properties-expected.txt.
00:05 Changeset [112368] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Make Chromium port for Android use hardware gpu path default.
https://bugs.webkit.org/show_bug.cgi?id=82033

Patch by Hao Zheng <zhenghao@chromium.org> on 2012-03-28
Reviewed by Dirk Pranke.

Skip canvas tests, which are run in virtual gpu test suites.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.init):
(ChromiumAndroidPort.skipped_tests):

Note: See TracTimeline for information about the timeline view.