Timeline


and

04/10/12:

23:46 Changeset [113831] by carlosgc@webkit.org

Unreviewed. Fix make distcheck issues.

Source/JavaScriptCore:

  • GNUmakefile.list.am: Ad missing files.

Source/WebCore:

  • GNUmakefile.list.am: Add missing header file.

Source/WebKit2:

  • GNUmakefile.am: Add missing header file.
23:26 Changeset [113830] by enne@google.com

[chromium] Signedness issue with code informing v8 of PatternSkia memory use
https://bugs.webkit.org/show_bug.cgi?id=83642

Reviewed by James Robinson.

The unary negation of size_t is still a size_t, so clamp and cast to
an int instead when adjusting v8 memory limits.

  • platform/graphics/Pattern.h:

(Pattern):

  • platform/graphics/skia/PatternSkia.cpp:

(WebCore::Pattern::platformPattern):

22:39 Changeset [113829] by tkent@chromium.org

Unreviewed. Using tkent+wkapi@ for ChromiumPublicApi notifications.

  • Scripts/webkitpy/common/config/watchlist:
  • Scripts/webkitpy/common/config/committers.py: Add tkent+wkapi@ to pass the style checker.
22:35 Changeset [113828] by noel.gordon@gmail.com

[chromium] ImageBuffer minor style fix: remove compound declaration
https://bugs.webkit.org/show_bug.cgi?id=83660

Reviewed by Kent Tamura.

No new tests. Covered by existing fast/canvas/*toDataURL* tests.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageDataToDataURL):

22:23 Changeset [113827] by fischman@chromium.org

Roll Chromium DEPS to last-known good revision
https://bugs.webkit.org/show_bug.cgi?id=83652

Unreviewed, just a DEPS roll (131469:131684)

  • DEPS:
21:58 Changeset [113826] by commit-queue@webkit.org

Add gesture event enums for long-press and pinch
https://bugs.webkit.org/show_bug.cgi?id=83640

Patch by Alexandre Elias <aelias@google.com> on 2012-04-10
Reviewed by James Robinson.

Add new enum values GestureLongPress and GesturePinchBegin/End/Update,
along with no-op default handling.

Source/WebCore:

No new tests. (No-op change.)

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):

  • platform/PlatformEvent.h:

Source/WebKit/chromium:

  • public/WebInputEvent.h:
  • src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::gestureEvent):

21:48 Changeset [113825] by inferno@chromium.org

Crash due to intruding float not removed from next siblings.
https://bugs.webkit.org/show_bug.cgi?id=83301

Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/block/float/intruding-float-not-removed-from-next-sibling-crash.html

markSiblingsWithFloatsForLayout currently only handled overhanging floats and made
checks for those by checking if logicalBottomForFloat > our logicalHeight. We need
to take care of intruding floats as well, since these can intrude into the neighbouring
blocks too. So, generalized the function to check all our next siblings if they contains
that float (one getting removed) and if yes, mark it and all its descendants for layout.
This fixes the crash.

For performance, we change the looping condition to iterate over the next sibling
blocks first and finding which ones can contain floats and then check it against
our floating object list. Currently, it is the other way around and is less
performant due to repeated calls to isRenderBlock(), isFloatingOrPositioned()
and avoidFloats().

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::markSiblingsWithFloatsForLayout):

LayoutTests:

  • fast/block/float/intruding-float-not-removed-from-next-sibling-crash-expected.txt: Added.
  • fast/block/float/intruding-float-not-removed-from-next-sibling-crash.html: Added.
21:35 April 2012 Meeting edited by morrita@google.com
(diff)
21:19 Changeset [113824] by mikelawther@chromium.org

Prevent fallthrough to keep static analysis tools happy
https://bugs.webkit.org/show_bug.cgi?id=83639

Reviewed by Darin Adler.

No new tests - no new behaviour.

  • css/LengthFunctions.cpp:

(WebCore::valueForLength):

21:15 Changeset [113823] by jchaffraix@webkit.org

Don't expose the intrinsic padding concept to the code outside rendering
https://bugs.webkit.org/show_bug.cgi?id=83380

Reviewed by Eric Seidel.

No new tests, refactoring only.

The current code would expose the concept of intrinsic padding to every
object holding a renderer through an enum on the padding* functions.

This was very fragile as only the class using intrinsic padding should know about
its very existence, the rest of the code shouldn't have to special case for it.
There is one exception: the getComputedStyle logic needs the opposite value
rendering needs. To handle that, we make it more explicit what returns the
computed values vs the rendering values.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::sizingBox):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Updated those functions to use the new computedCSS* functions below.

  • rendering/RenderBox.h:

(RenderBox):
(WebCore::RenderBox::computedCSSContentBoxRect):
This is the computed content box. It includes the intrinsic padding.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::computedCSSPaddingTop):
(WebCore::RenderBoxModelObject::computedCSSPaddingBottom):
(WebCore::RenderBoxModelObject::computedCSSPaddingLeft):
(WebCore::RenderBoxModelObject::computedCSSPaddingRight):
(WebCore::RenderBoxModelObject::computedCSSPaddingBefore):
(WebCore::RenderBoxModelObject::computedCSSPaddingAfter):
(WebCore::RenderBoxModelObject::computedCSSPaddingStart):
(WebCore::RenderBoxModelObject::computedCSSPaddingEnd):
Renamed from padding* as they returned the CSS computed values.

  • rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):
Killed the enum paddingOptions!

(WebCore::RenderBoxModelObject::paddingTop):
(WebCore::RenderBoxModelObject::paddingBottom):
(WebCore::RenderBoxModelObject::paddingLeft):
(WebCore::RenderBoxModelObject::paddingRight):
(WebCore::RenderBoxModelObject::paddingBefore):
(WebCore::RenderBoxModelObject::paddingAfter):
(WebCore::RenderBoxModelObject::paddingStart):
(WebCore::RenderBoxModelObject::paddingEnd):
All padding* functions call the computedCSSPadding* ones above.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paddingTop):
(WebCore::RenderTableCell::paddingBottom):
(WebCore::RenderTableCell::paddingLeft):
(WebCore::RenderTableCell::paddingRight):
(WebCore::RenderTableCell::paddingBefore):
(WebCore::RenderTableCell::paddingAfter):
Updated these functions after the renaming.

  • rendering/RenderTableCell.h:

(RenderTableCell):
Updated the functions signature and decorated them with OVERRIDE.

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::paddingTop):
(WebCore::RenderMathMLBlock::paddingBottom):
(WebCore::RenderMathMLBlock::paddingLeft):
(WebCore::RenderMathMLBlock::paddingRight):
(WebCore::RenderMathMLBlock::paddingBefore):
(WebCore::RenderMathMLBlock::paddingAfter):
(WebCore::RenderMathMLBlock::paddingStart):
(WebCore::RenderMathMLBlock::paddingEnd):

  • rendering/mathml/RenderMathMLBlock.h:

(RenderMathMLBlock):
Updated these functions after the renaming.

  • rendering/mathml/RenderMathMLSquareRoot.cpp:

(WebCore::RenderMathMLSquareRoot::paint):
Updated this function to use computeCSSContentBoxRect.location().

20:35 Changeset [113822] by commit-queue@webkit.org

TextureMapperGL.cpp breaks build with OpenGL ES
https://bugs.webkit.org/show_bug.cgi?id=83622

Patch by Lauro Neto <lauro.neto@openbossa.org> on 2012-04-10
Reviewed by Noam Rosenthal.

Add !defined(TEXMAP_OPENGL_ES_2) guards as suggested by
No'am Rosenthal.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::updateContents):

20:33 Changeset [113821] by tkent@chromium.org

Calendar Picker: Initialize CalendarPickerElement::m_popup
https://bugs.webkit.org/show_bug.cgi?id=83656

Reviewed by Hajime Morita.

  • html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::CalendarPickerElement): Set 0 to m_popup.

20:26 Changeset [113820] by adamk@chromium.org

CodeGeneratorV8 cleanup: eliminate redundant calls to IsRefPtrType
https://bugs.webkit.org/show_bug.cgi?id=83623

Reviewed by Adam Barth.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader): Always emit toV8(PassRefPtr), as all wrapped types are RefCounted.
(GenerateImplementation): Always emit code for derefObject, as all wrapped types are RefCounted.

20:02 Changeset [113819] by jamesr@google.com

[chromium] Add OVERRIDE annotations for cc tree host and proxy interfaces
https://bugs.webkit.org/show_bug.cgi?id=83653

Reviewed by Adrienne Walker.

This adds OVERRIDE annotations to the implementations of the following interfaces:

  • CCLayerTreeHostClient
  • CCLayerTreeHostImplClient
  • CCProxy
  • LayerRendererChromiumClient

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
  • platform/graphics/chromium/cc/CCProxy.h:

(WebCore):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(CCSingleThreadProxy):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

  • src/WebLayerTreeViewImpl.h:

(WebLayerTreeViewImpl):

  • src/WebViewImpl.h:

(WebViewImpl):

  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:
  • tests/FakeCCLayerTreeHostClient.h:
  • tests/LayerRendererChromiumTest.cpp:
19:59 Changeset [113818] by dgrogan@chromium.org

Notify observers of WorkerRunLoop stopping before the V8 isolate dies.
https://bugs.webkit.org/show_bug.cgi?id=83104

Source/WebCore:

PlatformSupport::didStopWorkerRunLoop ultimately causes
~V8AbstractEventListener to call
v8::Local<v8::Object>::New(m_listener) after the V8 isolate has been
disposed, which manifests as a crash in V8.

The current code in trunk runs this at shutdown:
1) removeAllDOMObjects()
2) dispose of V8
3) didStopWorkerRunLoop() <-- problem

This patch changes the order to be:
1) removeAllDOMObjects()
2) didStopWorkerRunLoop()
3) dispose of V8

We put didStopWorkerRunLoop after removeAllDOMObjects because we don't
want chromium code that runs on a webcore worker to run after it
receives the didStopWorkerRunLoop signal. The destructors of some IDB
objects are run by removeAllDOMObjects, so putting
didStopWorkerRunLoop before removeAllDOMObjects would violate that
constraint.

It's possible that there's a lower layer fix available in V8 or the
bindings.

Reviewed by David Levin.

Test: storage/indexeddb/pending-version-change-on-exit.html

  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::~WorkerScriptController):
New location of didStopWorkerRunLoop. removeAllDOMObjects and V8
disposal are called here, to run something between them it also has
to go here.

  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::workerThread): Old location of
didStopWorkerRunLoop.

LayoutTests:

Reviewed by David Levin.

  • storage/indexeddb/pending-version-change-on-exit-expected.txt: Added.
  • storage/indexeddb/pending-version-change-on-exit.html: Added.
  • storage/indexeddb/resources/pending-version-change-on-exit.js: Added.

(test.request.onsuccess.request.onblocked):
(test.request.onsuccess):
(test):

19:57 Changeset [113817] by adamk@chromium.org

Break the association between form controls and their owner when the owner leaves the tree
https://bugs.webkit.org/show_bug.cgi?id=81420

Reviewed by Kent Tamura.

Source/WebCore:

When parsing malformed markup, it's possible for a form and a
form-associated element to not be in an ancestor/descendant relationship.
When that form is later removed from the tree, the relationship needs to be updated.

Test: fast/forms/parser-associated-form-removal.html

  • html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::FormAssociatedElement):
(WebCore::FormAssociatedElement::formRemovedFromTree): New method called when
by the form when it's being removed: handles either resetting the
owner or storing a bit to optimize away a second walk up the tree.

  • html/FormAssociatedElement.h:

(FormAssociatedElement):

  • html/HTMLFormElement.cpp:

(WebCore::findRoot): Simple helper method copied from FormAssociatedElement (this should probably live elsewhere).
(WebCore::HTMLFormElement::removedFromTree): Override removedFromTree to notify associated elements of the removal.

  • html/HTMLFormElement.h:

(HTMLFormElement):

LayoutTests:

  • fast/forms/parser-associated-form-removal-expected.txt: Added.
  • fast/forms/parser-associated-form-removal.html: Added.
19:55 Changeset [113816] by jamesr@google.com

[chromium] Add OVERRIDE annotations for cc scheduler-related client interfaces
https://bugs.webkit.org/show_bug.cgi?id=83646

Reviewed by Adrienne Walker.

This adds OVERRIDE annotations to the implementations of the following interfaces:

  • CCFrameRateControllerClient
  • CCSchedulerClient
  • CCTimeSource
  • CCTimeSourceClient
  • CCTimerClient

Source/WebCore:

  • platform/graphics/chromium/cc/CCDelayBasedTimeSource.h:
  • platform/graphics/chromium/cc/CCFrameRateController.cpp:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
  • platform/graphics/chromium/cc/CCScheduler.h:

(CCScheduler):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:
  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

  • tests/CCSchedulerTest.cpp:
  • tests/CCSchedulerTestCommon.h:
19:51 Changeset [113815] by commit-queue@webkit.org

[CSS Regions] Convert a fast/regions pixel test to a ref test
https://bugs.webkit.org/show_bug.cgi?id=83529

Patch by David Alcala <dalcala@adobe.com> on 2012-04-10
Reviewed by Ryosuke Niwa.

  • fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.html: Added.
  • platform/chromium-linux/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Removed.
  • platform/chromium-mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Removed.
  • platform/chromium-mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.txt: Removed.
  • platform/chromium-win/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Removed.
  • platform/chromium-win/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.txt: Removed.
  • platform/efl/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Removed.
  • platform/efl/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.txt: Removed.
  • platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Removed.
  • platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.txt: Removed.
19:49 Changeset [113814] by mrowe@apple.com

Attempt to fix the Windows build.

19:38 Changeset [113813] by dpranke@chromium.org

If NRWT gets killed halfway through a run, it incorrectly reports tests that weren't run as passes
https://bugs.webkit.org/show_bug.cgi?id=82799

Reviewed by Ojan Vafai.

The tests we were skipping in _mark_interrupted_tests_as_skipped
had incorrectly-constructed TestResults, and so they were not
being treated as failures. The JSON generator doesn't record
tests that are passed or skiped in incremental_results, so you
couldn't tell these tests were being skipped at all.

This change changes _mark_interrupted_tests_as_skipped() to
treat the skipped tests as failures; this is arguably still
incorrect but is minimally invasive for now. We probably need to
revisit how we are uploading information about tests that are
skipped and passed altogether in a separate change.

This change also cleans up a couple of other nits that were
unnecessary or broken in this same code path.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._mark_interrupted_tests_as_skipped):
(Manager._upload_json_files): Deletes the check for
chromium-mac-leopard (as it is no longer necessary).

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:

(JSONLayoutResultsGenerator.init): Here we were
recalculating the failure type unnecessarily.

  • Scripts/webkitpy/layout_tests/models/test_failures.py:

(determine_result_type):
(FailureEarlyExit): Adds a new failure type so we can tell what
happened.
(FailureEarlyExit.message):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_exit_after_n_failures_upload): Add more checks to
ensure that we are recording the SKIP correctly; this is less
than ideal, because we can't actually test the contents of
incremental_results.json. We should fix that at some point.

19:28 Changeset [113812] by bashi@chromium.org

Merge 113132 - [Chromium] Out-of-process font loading garbles text
https://bugs.webkit.org/show_bug.cgi?id=83002

Reviewed by Kent Tamura.

Initialize m_CTFont by using m_cgFont in FontPlatformData when we use
out-of-process font loading.

No new tests. This problem only occurs when the user uses a third party
font management software like Font Explorer so it is difficult to add
tests.

  • platform/graphics/chromium/CrossProcessFontLoading.mm:

(WebCore):
(WebCore::FontPlatformData::loadFont): If font loading fails, set null to outNSFont so that the FontPlatformData won't be used.

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::ctFont): Modified to return the appropriate NSFont object when the font from the browser process.

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::createFontPlatformData): Returns null when the generated FontPlatformData object doesn't have NSFont object.

TBR=bashi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10034005

19:27 Changeset [113811] by tkent@chromium.org

Add a function to set empty clients to a PageClients
https://bugs.webkit.org/show_bug.cgi?id=83555

Reviewed by Adam Barth.

No new tests because of no behavior change.

  • CMakeLists.txt: Add EmptyClients.cpp.
  • GNUmakefile.list.am: ditto.
  • Target.pri: ditto.
  • WebCore.gypi: ditto.
  • WebCore.vcproj/WebCore.vcproj: ditto.
  • WebCore.xcodeproj/project.pbxproj: ditto.
  • loader/EmptyClients.cpp: Added.

(WebCore::fillWithEmptyClients): Some code was moved from SVGImage::dataChanged().

  • loader/EmptyClients.h: Add the declaration of fillWithEmptyClients().
  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::dataChanged): Moved some code to fillWithEmptyClients().

19:25 FeatureFlags edited by tkent@chromium.org
add LEGACY_CSS_VENDOR_PREFIXES (diff)
19:19 Changeset [113810] by rakuco@webkit.org

[EFL] Garden fast/{backgrounds,dynamic,encoding}.

  • platform/efl/fast/backgrounds/svg-as-mask-expected.txt:
  • platform/efl/fast/dynamic/002-expected.png:
  • platform/efl/fast/dynamic/004-expected.png:
  • platform/efl/fast/dynamic/006-expected.png:
  • platform/efl/fast/dynamic/012-expected.png:
  • platform/efl/fast/dynamic/015-expected.png:
  • platform/efl/fast/dynamic/anchor-lock-expected.txt:
  • platform/efl/fast/dynamic/anonymous-block-orphaned-lines-expected.png:
  • platform/efl/fast/dynamic/containing-block-change-expected.png:
  • platform/efl/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-expected.png:
  • platform/efl/fast/dynamic/float-withdrawal-expected.png:
  • platform/efl/fast/dynamic/insert-before-table-part-in-continuation-expected.png:
  • platform/efl/fast/dynamic/noninlinebadness-expected.png:
  • platform/efl/fast/dynamic/outerHTML-doc-expected.png:
  • platform/efl/fast/dynamic/outerHTML-img-expected.png:
  • platform/efl/fast/dynamic/selection-highlight-adjust-expected.png:
  • platform/efl/fast/dynamic/staticY-marking-parents-regression-expected.png:
  • platform/efl/fast/dynamic/text-combine-expected.png:
  • platform/efl/fast/dynamic/text-combine-expected.txt:
  • platform/efl/fast/dynamic/view-overflow-expected.png:
  • platform/efl/fast/encoding/denormalised-voiced-japanese-chars-expected.png:
  • platform/efl/fast/encoding/invalid-UTF-8-expected.png:
  • platform/efl/fast/encoding/utf-16-big-endian-expected.png:
  • platform/efl/fast/encoding/utf-16-big-endian-expected.txt:
  • platform/efl/fast/encoding/utf-16-little-endian-expected.png:
  • platform/efl/fast/encoding/utf-16-little-endian-expected.txt:
  • platform/efl/fast/encoding/xmacroman-encoding-test-expected.png:
19:13 Changeset [113809] by jamesr@google.com

[chromium] Fold LayerChromium::updateCompositorResources into main update
https://bugs.webkit.org/show_bug.cgi?id=83530

Reviewed by Adrienne Walker.

Source/WebCore:

We used to update layer contents in two phases. The first, called paintContentsIfDirty() /
idlePaintContentsIfDirty(), ran on the main WebKit thread and took care of any main-thread work - primarily
WebCore painting as the name implies. The second, called updateCompositorResources(), ran on the compositor
thread with the main thread blocked and took care of any actions that required direct access to the compositor's
context - such as texture uploads into compositor-managed textures. Now that all compositor texture operations
are queued on a CCTextureUpdater, the compositor can take care of these operations on the correct thread at the
right time without needing layer-specific logic.

This folds both functions into one function called LayerChromium::update() (and idleUpdate() for idle
prepainting) and adds a CCTextureUpdater reference for queuing up texture operations.

The CCProxy is responsible for the lifetime of the CCTextureUpdater. In the threaded proxy, the updater is
tied to the lifetime of the beginFrame operation. Specifically it's constructed on the impl thread when the
beginFrame message is generated, is accessed by reference on the main thread during the commit, and then
destroyed by the proxy when the commit is complete. CCTextureUpdater::update should only be called on the impl
thread by the proxy. In the future, it might be worth exposing a more limited interface to layers.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::update):

  • platform/graphics/chromium/Canvas2DLayerChromium.h:

(Canvas2DLayerChromium):

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::update):
(WebCore::ContentLayerChromium::idleUpdate):

  • platform/graphics/chromium/ContentLayerChromium.h:

(ContentLayerChromium):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerTextureUpdater::updateLayerRect):
(WebCore::ImageLayerChromium::update):

  • platform/graphics/chromium/ImageLayerChromium.h:

(ImageLayerChromium):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::update):
(WebCore::LayerChromium::idleUpdate):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::UpdatableTile::isDirty):
(WebCore::UpdatableTile::copyAndClearDirty):
(WebCore::UpdatableTile::isDirtyForCurrentFrame):
(UpdatableTile):
(WebCore::UpdatableTile::UpdatableTile):
(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::createTile):
(WebCore::TiledLayerChromium::invalidateRect):
(WebCore::TiledLayerChromium::tileOnlyNeedsPartialUpdate):
(WebCore::TiledLayerChromium::updateTiles):
(WebCore::TiledLayerChromium::reserveTextures):
(WebCore::TiledLayerChromium::resetUpdateState):
(WebCore::TiledLayerChromium::updateLayerRect):
(WebCore::TiledLayerChromium::idleUpdateLayerRect):
(WebCore::TiledLayerChromium::needsIdlePaint):

  • platform/graphics/chromium/TiledLayerChromium.h:

(TiledLayerChromium):

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::update):

  • platform/graphics/chromium/WebGLLayerChromium.h:

(WebGLLayerChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
(WebCore::CCLayerTreeHost::commitComplete):
(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::CCLayerTreeHost::reserveTextures):
(WebCore::CCLayerTreeHost::update):
(WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::doCommit):
(WebCore::CCSingleThreadProxy::commitIfNeeded):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(CCSingleThreadProxy):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionBeginFrame):
(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
(WebCore::CCThreadProxy::scheduledActionCommit):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(WebCore::CCThreadProxy::BeginFrameAndCommitState::BeginFrameAndCommitState):
(BeginFrameAndCommitState):

Source/WebKit/chromium:

Update tests for interface changes.

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::runTest):
(WTF::ContentLayerChromiumWithUpdateTracking::update):
(WTF::ContentLayerChromiumWithUpdateTracking::idleUpdate):
(WTF::ContentLayerChromiumWithUpdateTracking::ContentLayerChromiumWithUpdateTracking):
(ContentLayerChromiumWithUpdateTracking):
(WTF::CCLayerTreeHostTestOpacityChange::afterTest):
(WTF::CCLayerTreeHostTestSetViewportSize::beginTest):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::commitCompleteOnCCThread):
(WTF::TestLayerChromium::update):
(WTF::CCLayerTreeHostTestLayerOcclusion::beginTest):
(WTF::CCLayerTreeHostTestContentLayerOcclusion::beginTest):
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):
(WTF::CCLayerTreeHostTestManySurfaces::beginTest):

  • tests/CCTiledLayerTestCommon.cpp:

(WebKitTests::FakeLayerTextureUpdater::updateLayerRect):
(WebKitTests::FakeTiledLayerChromium::update):

  • tests/CCTiledLayerTestCommon.h:

(FakeLayerTextureUpdater):
(FakeTiledLayerChromium):

  • tests/Canvas2DLayerChromiumTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):
(WTF::idlePaintRepeat):

19:07 Changeset [113808] by dglazkov@chromium.org

fast/forms/implicit-submission.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=39056

Speed up the test by removing unnecessary iframe and navigation,
make it less flaky by removing timeouts.

Reviewed by Hajime Morita.

  • fast/forms/implicit-submission.html: Deflakified and sped up.
19:05 Changeset [113807] by rakuco@webkit.org

[EFL] Garden fast/css.

Account for some changes related to the jhbuild and font commits
and adjust some wrong results with fonts that are too big.

  • platform/efl/fast/css/001-expected.png:
  • platform/efl/fast/css/003-expected.png:
  • platform/efl/fast/css/004-expected.png:
  • platform/efl/fast/css/005-expected.png:
  • platform/efl/fast/css/MarqueeLayoutTest-expected.png:
  • platform/efl/fast/css/ZeroOpacityLayers-expected.png:
  • platform/efl/fast/css/ZeroOpacityLayers2-expected.png:
  • platform/efl/fast/css/absolute-poition-in-rtl-parent-expected.png:
  • platform/efl/fast/css/acid2-pixel-expected.png:
  • platform/efl/fast/css/apple-prefix-expected.png:
  • platform/efl/fast/css/begin-end-contain-selector-empty-value-expected.png:
  • platform/efl/fast/css/bidi-override-in-anonymous-block-expected.png:
  • platform/efl/fast/css/bidi-override-in-anonymous-block-expected.txt:
  • platform/efl/fast/css/border-radius-outline-offset-expected.png:
  • platform/efl/fast/css/color-correction-backgrounds-and-text-expected.png:
  • platform/efl/fast/css/color-correction-expected.png:
  • platform/efl/fast/css/color-correction-on-text-expected.png:
  • platform/efl/fast/css/compare-content-style-expected.png:
  • platform/efl/fast/css/continuationCrash-expected.png:
  • platform/efl/fast/css/create_element_align-expected.png:
  • platform/efl/fast/css/css-imports-expected.png:
  • platform/efl/fast/css/css1_forward_compatible_parsing-expected.png:
  • platform/efl/fast/css/css2-system-fonts-expected.png:
  • platform/efl/fast/css/css3-modsel-22-expected.png:
  • platform/efl/fast/css/css3-nth-child-expected.png:
  • platform/efl/fast/css/css3-space-in-nth-and-lang-expected.png:
  • platform/efl/fast/css/empty-pseudo-class-expected.png:
  • platform/efl/fast/css/error-in-last-decl-expected.png:
  • platform/efl/fast/css/ex-after-font-variant-expected.png:
  • platform/efl/fast/css/fieldset-display-row-expected.png:
  • platform/efl/fast/css/find-next-layer-expected.png:
  • platform/efl/fast/css/first-child-pseudo-class-expected.png:
  • platform/efl/fast/css/first-letter-capitalized-expected.png:
  • platform/efl/fast/css/first-letter-detach-expected.png:
  • platform/efl/fast/css/first-letter-float-after-float-expected.png:
  • platform/efl/fast/css/first-letter-float-expected.png:
  • platform/efl/fast/css/first-letter-hover-expected.png:
  • platform/efl/fast/css/first-letter-punctuation-expected.png:
  • platform/efl/fast/css/first-letter-recalculation-expected.png:
  • platform/efl/fast/css/first-letter-skip-out-of-flow-expected.png:
  • platform/efl/fast/css/first-letter-visibility-expected.png:
  • platform/efl/fast/css/first-of-type-pseudo-class-expected.png:
  • platform/efl/fast/css/focus-ring-detached-expected.png:
  • platform/efl/fast/css/focus-ring-multiline-expected.png:
  • platform/efl/fast/css/focus-ring-multiline-writingmode-vertical-expected.png:
  • platform/efl/fast/css/focus-ring-outline-offset-expected.png:
  • platform/efl/fast/css/font-face-implicit-local-font-expected.png:
  • platform/efl/fast/css/font-face-locally-installed-expected.png:
  • platform/efl/fast/css/font-face-multiple-faces-expected.png:
  • platform/efl/fast/css/font-face-unicode-range-expected.png:
  • platform/efl/fast/css/font-weight-1-expected.png:
  • platform/efl/fast/css/font_property_normal-expected.png:
  • platform/efl/fast/css/h1-in-section-elements-expected.png:
  • platform/efl/fast/css/hover-subselector-expected.png:
  • platform/efl/fast/css/hsl-color-expected.png:
  • platform/efl/fast/css/import-rule-regression-11590-expected.png:
  • platform/efl/fast/css/import-rule-regression-11590-expected.txt:
  • platform/efl/fast/css/inline-element-line-break-expected.png:
  • platform/efl/fast/css/inline-element-line-break-expected.txt:
  • platform/efl/fast/css/inline-properties-important-expected.png:
  • platform/efl/fast/css/inline-properties-important-expected.txt:
  • platform/efl/fast/css/invalid-percentage-property-expected.png:
  • platform/efl/fast/css/invalid-percentage-property-expected.txt:
  • platform/efl/fast/css/invalidation-errors-2-expected.png:
  • platform/efl/fast/css/invalidation-errors-2-expected.txt:
  • platform/efl/fast/css/invalidation-errors-3-expected.png:
  • platform/efl/fast/css/invalidation-errors-3-expected.txt:
  • platform/efl/fast/css/invalidation-errors-expected.png:
  • platform/efl/fast/css/invalidation-errors-expected.txt:
  • platform/efl/fast/css/last-child-pseudo-class-expected.png:
  • platform/efl/fast/css/last-child-pseudo-class-expected.txt:
  • platform/efl/fast/css/last-of-type-pseudo-class-expected.png:
  • platform/efl/fast/css/last-of-type-pseudo-class-expected.txt:
  • platform/efl/fast/css/layerZOrderCrash-expected.png:
  • platform/efl/fast/css/layerZOrderCrash-expected.txt:
  • platform/efl/fast/css/line-height-expected.png:
  • platform/efl/fast/css/line-height-expected.txt:
  • platform/efl/fast/css/line-height-overflow-expected.png:
  • platform/efl/fast/css/line-height-overflow-expected.txt:
  • platform/efl/fast/css/list-outline-expected.png:
  • platform/efl/fast/css/list-outline-expected.txt:
  • platform/efl/fast/css/margin-bottom-form-element-quirk-expected.png:
  • platform/efl/fast/css/margin-bottom-form-element-quirk-expected.txt:
  • platform/efl/fast/css/margin-bottom-form-element-strict-expected.png:
  • platform/efl/fast/css/margin-bottom-form-element-strict-expected.txt:
  • platform/efl/fast/css/margin-top-bottom-dynamic-expected.png:
  • platform/efl/fast/css/margin-top-bottom-dynamic-expected.txt:
  • platform/efl/fast/css/namespaces/004-expected.png:
  • platform/efl/fast/css/namespaces/005-expected.png:
  • platform/efl/fast/css/namespaces/namespaces-comments-expected.png:
  • platform/efl/fast/css/namespaces/namespaces-empty-expected.png:
  • platform/efl/fast/css/namespaces/namespaces-escapes-expected.png:
  • platform/efl/fast/css/namespaces/namespaces-invalid-at-expected.png:
  • platform/efl/fast/css/negative-leading-expected.png:
  • platform/efl/fast/css/negative-leading-expected.txt:
  • platform/efl/fast/css/negative-nth-child-expected.png:
  • platform/efl/fast/css/negative-nth-child-expected.txt:
  • platform/efl/fast/css/nested-floating-relative-position-percentages-expected.png:
  • platform/efl/fast/css/nested-floating-relative-position-percentages-expected.txt:
  • platform/efl/fast/css/nested-layers-with-hover-expected.png:
  • platform/efl/fast/css/nested-layers-with-hover-expected.txt:
  • platform/efl/fast/css/nested-rounded-corners-expected.png:
  • platform/efl/fast/css/nth-child-dynamic-expected.png:
  • platform/efl/fast/css/nth-child-dynamic-expected.txt:
  • platform/efl/fast/css/only-child-pseudo-class-expected.png:
  • platform/efl/fast/css/only-child-pseudo-class-expected.txt:
  • platform/efl/fast/css/only-of-type-pseudo-class-expected.png:
  • platform/efl/fast/css/only-of-type-pseudo-class-expected.txt:
  • platform/efl/fast/css/outline-auto-location-expected.png:
  • platform/efl/fast/css/outline-auto-location-expected.txt:
  • platform/efl/fast/css/outline-narrowLine-expected.png:
  • platform/efl/fast/css/outline-narrowLine-expected.txt:
  • platform/efl/fast/css/percent-top-relative-container-height-unspecified-expected.png:
  • platform/efl/fast/css/percent-top-relative-container-height-unspecified-expected.txt:
  • platform/efl/fast/css/percentage-non-integer-expected.png:
  • platform/efl/fast/css/percentage-non-integer-expected.txt:
  • platform/efl/fast/css/positioned-overflow-scroll-expected.png:
  • platform/efl/fast/css/pseudo-element-line-break-expected.png:
  • platform/efl/fast/css/pseudo-element-line-break-expected.txt:
  • platform/efl/fast/css/pseudo-first-line-border-width-expected.png:
  • platform/efl/fast/css/pseudo-first-line-border-width-expected.txt: Added.
  • platform/efl/fast/css/quirk-orphaned-units-expected.png:
  • platform/efl/fast/css/quirk-orphaned-units-expected.txt:
  • platform/efl/fast/css/resize-corner-tracking-expected.png:
  • platform/efl/fast/css/resize-corner-tracking-expected.txt:
  • platform/efl/fast/css/resize-corner-tracking-transformed-expected.png:
  • platform/efl/fast/css/resize-corner-tracking-transformed-expected.txt:
  • platform/efl/fast/css/rtl-ordering-expected.png:
  • platform/efl/fast/css/rtl-ordering-expected.txt:
  • platform/efl/fast/css/selector-set-attribute-expected.png:
  • platform/efl/fast/css/selector-set-attribute-expected.txt:
  • platform/efl/fast/css/table-text-align-quirk-expected.png:
  • platform/efl/fast/css/table-text-align-quirk-expected.txt:
  • platform/efl/fast/css/table-text-align-strict-expected.png:
  • platform/efl/fast/css/table-text-align-strict-expected.txt:
  • platform/efl/fast/css/text-align-expected.png:
  • platform/efl/fast/css/text-align-expected.txt:
  • platform/efl/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/efl/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/efl/fast/css/text-overflow-ellipsis-bidi-expected.png:
  • platform/efl/fast/css/text-overflow-ellipsis-bidi-expected.txt:
  • platform/efl/fast/css/text-overflow-ellipsis-expected.png:
  • platform/efl/fast/css/text-overflow-ellipsis-expected.txt:
  • platform/efl/fast/css/text-overflow-ellipsis-strict-expected.png:
  • platform/efl/fast/css/text-overflow-ellipsis-strict-expected.txt:
  • platform/efl/fast/css/text-security-expected.png:
  • platform/efl/fast/css/text-security-expected.txt:
  • platform/efl/fast/css/text-transform-select-expected.png:
  • platform/efl/fast/css/text-transform-select-expected.txt:
  • platform/efl/fast/css/textCapitalizeEdgeCases-expected.png:
  • platform/efl/fast/css/textCapitalizeEdgeCases-expected.txt:
  • platform/efl/fast/css/transformed-mask-expected.png:
  • platform/efl/fast/css/transformed-mask-expected.txt:
  • platform/efl/fast/css/universal-hover-quirk-expected.png:
  • platform/efl/fast/css/universal-hover-quirk-expected.txt:
  • platform/efl/fast/css/value-list-out-of-bounds-crash-expected.png:
  • platform/efl/fast/css/value-list-out-of-bounds-crash-expected.txt:
  • platform/efl/fast/css/word-space-extra-expected.png:
  • platform/efl/fast/css/word-space-extra-expected.txt:
  • platform/efl/fast/css/zoom-font-size-expected.png:
  • platform/efl/fast/css/zoom-font-size-expected.txt:
18:57 Changeset [113806] by adamk@chromium.org

Store V8 SVGElementInstance wrappers in the regular DOMObjectMap
https://bugs.webkit.org/show_bug.cgi?id=83615

Reviewed by Adam Barth.

Historically, these wrappers had their own map, but there doesn't seem
to be any particular reason for this. The V8GCController doesn't
treat them specially (which is the reason you normally need a separate
wrapper map).

No new tests, no expected change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GetDomMapName):

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::DOMDataStore):
(WebCore::DOMDataStore::getDOMWrapperMap):

  • bindings/v8/DOMDataStore.h:

(DOMDataStore):

  • bindings/v8/ScopedDOMDataStore.cpp:

(WebCore::ScopedDOMDataStore::ScopedDOMDataStore):
(WebCore::ScopedDOMDataStore::~ScopedDOMDataStore):

  • bindings/v8/StaticDOMDataStore.cpp:

(WebCore::StaticDOMDataStore::StaticDOMDataStore):

  • bindings/v8/StaticDOMDataStore.h:

(StaticDOMDataStore):

  • bindings/v8/V8DOMMap.cpp:

(WebCore::removeAllDOMObjects):

  • bindings/v8/V8DOMMap.h:

(WebCore):

  • bindings/v8/V8DOMWrapper.cpp:
18:46 Changeset [113805] by noel.gordon@gmail.com

[Qt] Separate image encoding from dataURL construction
https://bugs.webkit.org/show_bug.cgi?id=83132

Reviewed by Noam Rosenthal.

Remove the implicit assumption that a dataURL is the only desired output format
of the image encoding phase.

No new tests, refactoring only, covered by existing canvas tests.

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::encodeImage): Output the encoded image to the provided QByteArray.
(WebCore):
(WebCore::ImageBuffer::toDataURL) Format the dataURL encoding of the mimeType
encoded image data here. Clarify the comment.

18:45 Changeset [113804] by dpranke@chromium.org

make chromium layout tests not depend on platform/win, platform/mac-leopard, or platform/mac-snowleopard
https://bugs.webkit.org/show_bug.cgi?id=83401

Reviewed by Adam Barth.

Last patch in the series - no longer look in mac-leopard,
mac-snowleopard, or mac-lion.

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumMacPort):

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
18:39 Changeset [113803] by paroga@webkit.org

Build fix for WinCE after r113730.

  • platform/FractionalLayoutUnit.h:

(WebCore::FractionalLayoutUnit::isInBounds):

18:37 Changeset [113802] by dpranke@chromium.org

webkit-patch: add a print-expectations command
https://bugs.webkit.org/show_bug.cgi?id=83347

Reviewed by Adam Barth.

This command will print the expected results for a given set of
tests on a given set of ports matching a given set of keywords.

Example output (printing all the tests not expected to pass, and their
expected results, on a Mac):

$ webkit-patch print-expectations -x pass fast/html
For mac-snowleopard
fast/html/details-open4.html = TEXT
fast/html/details-open2.html = TEXT
fast/html/details-no-summary4.html = TEXT
fast/html/details-open-javascript.html = TEXT
$

You can also print full test-expectatons.txt lines using --full and a
CSV-style report (which can be useful for post-processing) using --csv.

It will replace the 'skipped-files' command (which will be
removed in a subsequent patch) and is a more general (and
cleaner and properly layered) solution.

Also add an update() command to MockOptions() to make overriding keywords easier.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationSerializer.to_string):
(TestExpectationSerializer):
(TestExpectationSerializer.to_csv):
(TestExpectationSerializer._format_result):
(TestExpectationLine.create_passing_expectation):
(TestExpectationsModel.get_test_set_for_keyword):
(TestExpectationsModel.has_keyword):
(TestExpectations.model):

  • Scripts/webkitpy/tool/commands/queries.py:

(execute):
(PrintExpectations):
(PrintExpectations.init):
(PrintExpectations.execute):
(PrintExpectations._filter_tests):
(PrintExpectations._format_lines):
(PrintExpectations._model):

  • Scripts/webkitpy/tool/commands/queries_unittest.py:

(TestPrintExpectations): Added.

  • Scripts/webkitpy/tool/mocktool.py:

(MockOptions):
(MockOptions.init):
(MockOptions.update): Added.

18:30 Changeset [113801] by dpranke@chromium.org

webkitpy: refactor handling of --platform and related options
https://bugs.webkit.org/show_bug.cgi?id=83525

Reviewed by Adam Barth.

This change moves to centralize handling of --platform, --debug,
--gtk, and other similar flags into a central place next to the
code that actually uses those flags in PortFactory to get the
right Port object.

  • Scripts/webkitpy/layout_tests/port/init.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:

(port_options):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

  • Scripts/webkitpy/tool/commands/queries.py:

(PrintBaselines.init):

18:24 Changeset [113800] by mrowe@apple.com

<rdar://problem/10583749> WebKit2 should log to both ASL and stderr

Source/WebKit2:

Replace direct calls to fprintf stderr with calls to WTFLogAlways.

Reviewed by Sam Weinig.

  • PluginProcess/mac/PluginProcessMainMac.mm:

(WebKit::PluginProcessMain):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::checkURLReceivedFromWebProcess):
(WebKit::WebProcessProxy::didReceiveInvalidMessage):

  • WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:

(WebKit::InjectedBundle::load):

  • WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm:

(readSandboxProfile):
(WKN_EnterSandbox):

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::initializeSandbox):

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain):

Source/WTF:

Reviewed by Sam Weinig.

  • wtf/Assertions.cpp: Add a WTFLogAlways function that unconditionally logs the given message.
  • wtf/Assertions.h:
18:19 FeatureFlags edited by tkent@chromium.org
Add ENCRYPTED_MEDIA (diff)
18:15 Changeset [113799] by commit-queue@webkit.org

Add transfer map argument to Intent constructor
http://dvcs.w3.org/hg/web-intents/raw-file/tip/spec/Overview.html
This adds the ability to pass transferables (i.e. MessagePorts)
through web intents, and puts the calling convention in line
with the Web Messaging spec:
http://dev.w3.org/html5/postmsg/

Implementation in chromium API follows the port-passing method
of PlatformMessagePortChannel.

https://bugs.webkit.org/show_bug.cgi?id=80200

Patch by Greg Billock <gbillock@google.com> on 2012-04-10
Reviewed by Adam Barth.

  • Modules/intents/Intent.cpp:

(WebCore::Intent::create):

  • Modules/intents/Intent.idl:
  • WebCore.gypi:
  • bindings/v8/custom/V8IntentCustom.cpp: Added.

(WebCore):
(WebCore::V8Intent::constructorCallback):

18:09 Changeset [113798] by paroga@webkit.org

Cleanup wtf/Platform.h and config.h files
https://bugs.webkit.org/show_bug.cgi?id=83431

Reviewed by Eric Seidel.

The ENABLE() and USE() macros take care about the case when the flag
isn't defined. So there is no need to define anything with 0.

Also move duplicated code from the config.h files to Platform.h and
merge a few preprocessor commands to make the file more readable.

Source/JavaScriptCore:

  • config.h:

Source/WebCore:

  • config.h:

Source/WTF:

  • config.h:
  • wtf/Platform.h:
17:56 Changeset [113797] by simonjam@chromium.org

[Chromium] Unreviewed gardening.

  • platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/forms/basic-textareas-expected.txt.
  • platform/chromium-mac/fast/forms/basic-textareas-expected.png:
  • platform/chromium-mac/fast/forms/basic-textareas-expected.txt:
  • platform/chromium/test_expectations.txt:
17:37 Changeset [113796] by fpizlo@apple.com

DFG should flush SetLocals to arguments
https://bugs.webkit.org/show_bug.cgi?id=83554

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

This is necessary to match baseline JIT argument capture behavior.

But to make this work right we need to have a story for arguments into
which we store values of different formats. This patch introduces the
notion of an ArgumentPosition - i.e. an argument in a particular inline
call frame - and forces unification of all data pertinent to selecting
the argument's data format.

Also fixed an amusing bug in the handling of OSR on SetLocals if there
was any insertion/deletion of nodes in the basic block. This is benign
for now but won't be eventually since the DFG is getting smarter. So
better fix it now.

Also fixed an amusing bug in the handling of OSR on SetLocals if they
are immediately followed by a Flush. I think this bug might have always
been there but now it'll happen more commonly, and it's covered by the
run-javascriptcore-tests.

(JSC::DFG::AbstractState::execute):

  • dfg/DFGArgumentPosition.h: Added.

(DFG):
(ArgumentPosition):
(JSC::DFG::ArgumentPosition::ArgumentPosition):
(JSC::DFG::ArgumentPosition::addVariable):
(JSC::DFG::ArgumentPosition::mergeArgumentAwareness):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::setArgument):
(InlineStackEntry):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGDoubleFormatState.h: Added.

(DFG):
(JSC::DFG::mergeDoubleFormatStates):
(JSC::DFG::mergeDoubleFormatState):
(JSC::DFG::doubleFormatStateToString):

  • dfg/DFGGraph.h:

(Graph):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGVariableAccessData.h:

(JSC::DFG::VariableAccessData::VariableAccessData):
(JSC::DFG::VariableAccessData::predict):
(JSC::DFG::VariableAccessData::argumentAwarePrediction):
(VariableAccessData):
(JSC::DFG::VariableAccessData::mergeArgumentAwarePrediction):
(JSC::DFG::VariableAccessData::doubleFormatState):
(JSC::DFG::VariableAccessData::shouldUseDoubleFormat):
(JSC::DFG::VariableAccessData::tallyVotesForShouldUseDoubleFormat):
(JSC::DFG::VariableAccessData::mergeDoubleFormatState):
(JSC::DFG::VariableAccessData::makePredictionForDoubleFormat):

Source/WTF:

Reviewed by Gavin Barraclough.

Added an isRoot() method that is a faster shorthand for saying
find() == this.

  • wtf/UnionFind.h:

(WTF::UnionFind::isRoot):
(UnionFind):

LayoutTests:

Rubber stamped by Gavin Barraclough.

Added a variety of tests for reassigning arguments prior to function.arguments
retrieval.

  • fast/js/dfg-inline-arguments-become-double-expected.txt: Added.
  • fast/js/dfg-inline-arguments-become-double.html: Added.
  • fast/js/dfg-inline-arguments-become-int32-expected.txt: Added.
  • fast/js/dfg-inline-arguments-become-int32.html: Added.
  • fast/js/dfg-inline-arguments-reset-changetype-expected.txt: Added.
  • fast/js/dfg-inline-arguments-reset-changetype.html: Added.
  • fast/js/dfg-inline-arguments-reset-expected.txt: Added.
  • fast/js/dfg-inline-arguments-reset.html: Added.
  • fast/js/script-tests/dfg-inline-arguments-become-double.js: Added.

(foo):
(bar):
(baz):
(argsToStr):

  • fast/js/script-tests/dfg-inline-arguments-become-int32.js: Added.

(foo):
(bar):
(baz):
(argsToStr):

  • fast/js/script-tests/dfg-inline-arguments-reset-changetype.js: Added.

(foo):
(bar):
(baz):
(argsToStr):

  • fast/js/script-tests/dfg-inline-arguments-reset.js: Added.

(foo):
(bar):
(baz):
(argsToStr):

17:17 Changeset [113795] by abarth@webkit.org

Source/WebCore: Limit -apple- and -khtml- to ENABLE(DASHBOARD_SUPPORT)
https://bugs.webkit.org/show_bug.cgi?id=83256

Reviewed by Eric Seidel.

As recommended by David Hyatt in
<https://lists.webkit.org/pipermail/webkit-dev/2010-July/013536.html>,
we should phase out support for -khtml- and -apple- vendor prefixes in
CSS (in favor of -webkit-).

As noted in <https://bugs.webkit.org/show_bug.cgi?id=42093#c29>, Dave's
proposal is a bit too agressive. These prefixes appear to be needed
for a number of dashboard widgets. For that reason, this patch limits
the prefixes to ENABLE(LEGACY_CSS_VENDOR_PREFIXES).

This patch enables ENABLE(LEGACY_CSS_VENDOR_PREFIXES) on apple-mac and
apple-win, which will let us learn whether removing these prefixes
causes a compatibility problem on the broader web.

  • Configurations/FeatureDefines.xcconfig:
  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::getCSSPropertyNamePrefix):
(WebCore::cssPropertyIDForJSCSSPropertyName):

  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:

(WebCore::cssPropertyInfo):

  • css/CSSParser.cpp:

(WebCore::cssPropertyID):

Source/WebKit/chromium: Limit -apple- and -khtml- to ENABLE(DASHBOARD_SUPPORT)
https://bugs.webkit.org/show_bug.cgi?id=83256

Reviewed by Eric Seidel.

  • features.gypi:

WebKitLibraries: Limit -apple- and -khtml- to ENABLE(DASHBOARD_SUPPORT)
https://bugs.webkit.org/show_bug.cgi?id=83256

Reviewed by Eric Seidel.

  • win/tools/vsprops/FeatureDefines.vsprops:

LayoutTests: Limit -apple- and -khtml- to ENABLE(LEGACY_CSS_VENDOR_PREFIXES)
https://bugs.webkit.org/show_bug.cgi?id=83256

Reviewed by Eric Seidel.

Skip these two tests, which are testing that -apple- and -khtml- vendor
prefixes work correctly.

  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
17:15 Changeset [113794] by adamk@chromium.org

Remove unused NonNullPassRefPtr from WTF
https://bugs.webkit.org/show_bug.cgi?id=82389

Reviewed by Kentaro Hara.

Source/JavaScriptCore:

  • JavaScriptCore.order: Remove nonexistent symbols referencing NonNullPassRefPtr.

Source/WTF:

NonNullPassRefPtr seems to be unused since JSC allocation was
restructured in r84052.

If someone decides they need this later, they can always revert this patch.

  • wtf/PassRefPtr.h:
  • wtf/RefPtr.h:

(RefPtr):

17:09 Changeset [113793] by yael.aharon@nokia.com

Unreviewed build fix after r113791.

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::WebGraphicsLayer):

16:44 Changeset [113792] by leviw@chromium.org

Clean up multiple RenderedPosition::absoluteRect definitions and correct LayoutUnit usage
https://bugs.webkit.org/show_bug.cgi?id=83604

Reviewed by Julien Chaffraix.

Removing unnecessary definitions of absoluteRect and replacing them with a single public
version that's more explicit about its contract.

Also correcting a LayoutUnit misuse, as rects in absolute coordinates should be returned
using integers, not LayoutUnits. See https://trac.webkit.org/wiki/LayoutUnit for details.

No new tests. No change in behavior.

  • editing/Editor.cpp:

(WebCore::Editor::firstRectForRange):

  • editing/RenderedPosition.cpp:

(WebCore::RenderedPosition::absoluteRect): Pixel snapping the local rect before converting
to absolute coordinates.

  • editing/RenderedPosition.h:

(RenderedPosition):

16:40 Changeset [113791] by yael.aharon@nokia.com

Initial support for fixed position elements in Qt WebKit2
https://bugs.webkit.org/show_bug.cgi?id=81786

Reviewed by Noam Rosenthal.

.:

  • ManualTests/fixed-position.html: Added.

Source/WebCore:

When the setting acceleratedCompositingForFixedPositionEnabled is true, we update
the position of fixed layers, and send updates to the UI process as we scroll.
Before painting, TextureMapperLayer receives a delta of the scroll positions between the UI
and the web processes, and adjusts its transform position accordingly.

  • page/FrameView.cpp:

(WebCore::FrameView::setFixedVisibleContentRect):

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::setScrollPositionDelta):
(WebCore):

  • platform/graphics/texmap/TextureMapperLayer.h:

(TextureMapperLayer):

Source/WebKit2:

Turn on the flag acceleratedCompositingForFixedPositionEnabled when using fixed layout.
As we scroll, we keep track of the delta in scroll position between the UI and web processes,
and adjust the position of all the fixed layers by that delta.
When WebLayerTreeRenderer receives a new scroll position from the web process, it keeps it as pending,
and commit the new scroll position in flushLayerChanges.
This patch does not address scrolling overshoot and it does not fix the wrong positioning
that occurs when we zoom. These issues will be addressed in future patches.

  • Shared/WebLayerTreeInfo.h:
  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPagePrivate::updateSize):

  • UIProcess/LayerTreeHostProxy.cpp:

(WebKit::LayerTreeHostProxy::setContentsSize):
(WebKit):
(WebKit::LayerTreeHostProxy::renderNextFrame):
(WebKit::LayerTreeHostProxy::didChangeScrollPosition):

  • UIProcess/LayerTreeHostProxy.h:

(LayerTreeHostProxy):

  • UIProcess/LayerTreeHostProxy.messages.in:
  • UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::boundedScrollPosition):
(WebKit):
(WebKit::WebLayerTreeRenderer::paintToCurrentGLContext):
(WebKit::WebLayerTreeRenderer::setContentsSize):
(WebKit::WebLayerTreeRenderer::adjustPositionForFixedLayers):
(WebKit::WebLayerTreeRenderer::didChangeScrollPosition):
(WebKit::WebLayerTreeRenderer::syncLayerParameters):
(WebKit::WebLayerTreeRenderer::deleteLayer):
(WebKit::WebLayerTreeRenderer::flushLayerChanges):

  • UIProcess/WebLayerTreeRenderer.h:

(WebLayerTreeRenderer):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::WebGraphicsLayer):
(WebCore::WebGraphicsLayer::syncCompositingState):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:

(WebGraphicsLayerClient):
(WebCore::WebGraphicsLayer::fixedToViewport):
(WebCore::WebGraphicsLayer::setFixedToViewport):
(WebGraphicsLayer):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setResizesToContentsUsingLayoutSize):

  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::LayerTreeHostQt):
(WebKit::LayerTreeHostQt::didSyncCompositingStateForLayer):
(WebKit::updateOffsetFromViewportForSelf):
(WebKit):
(WebKit::updateOffsetFromViewportForLayer):
(WebKit::LayerTreeHostQt::syncFixedLayers):
(WebKit::LayerTreeHostQt::setVisibleContentsRect):

  • WebProcess/WebPage/qt/LayerTreeHostQt.h:

(LayerTreeHostQt):

16:34 Changeset [113790] by simonjam@chromium.org

[Chromium] Unreviewed gardening.

  • platform/chromium-linux/fast/multicol/cell-shrinkback-expected.png: Added.
  • platform/chromium-linux/scrollbars/scrollbars-on-positioned-content-expected.png:
  • platform/chromium-mac-leopard/fast/forms/basic-textareas-expected.png:
  • platform/chromium-mac-leopard/scrollbars/scrollbars-on-positioned-content-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/scrollbars/scrollbars-on-positioned-content-expected.png:
  • platform/chromium-mac/fast/overflow/hidden-scrollbar-resize-expected.txt: Removed.
  • platform/chromium-mac/scrollbars/scrollbars-on-positioned-content-expected.png:
  • platform/chromium-mac/scrollbars/scrollbars-on-positioned-content-expected.txt: Removed.
  • platform/chromium-win/fast/multicol/cell-shrinkback-expected.png: Added.
  • platform/chromium-win/fast/multicol/table-vertical-align-expected.txt:
  • platform/chromium-win/fast/overflow/hidden-scrollbar-resize-expected.txt:
  • platform/chromium-win/scrollbars/scrollbars-on-positioned-content-expected.png:
  • platform/chromium-win/scrollbars/scrollbars-on-positioned-content-expected.txt:
  • platform/chromium/test_expectations.txt:
16:16 Changeset [113789] by abarth@webkit.org

Remove empty directories.

16:10 Changeset [113788] by dpranke@chromium.org

Clone any baselines chromium is using from mac-leopard and mac-snowleopard into chromium dirs.
https://bugs.webkit.org/show_bug.cgi?id=83401

Unreviewed, baseline shuffling.

  • platform/chromium-mac-leopard/accessibility/aria-tables-expected.txt: Added.
  • platform/chromium-mac-leopard/accessibility/lists-expected.txt: Added.
  • platform/chromium-mac-leopard/accessibility/media-element-expected.txt: Added.
  • platform/chromium-mac-leopard/accessibility/table-attributes-expected.txt: Added.
  • platform/chromium-mac-leopard/accessibility/table-cell-spans-expected.txt: Added.
  • platform/chromium-mac-leopard/accessibility/table-cells-expected.txt: Added.
  • platform/chromium-mac-leopard/accessibility/table-detection-expected.txt: Added.
  • platform/chromium-mac-leopard/accessibility/table-sections-expected.txt: Added.
  • platform/chromium-mac-leopard/accessibility/table-with-rules-expected.txt: Added.
  • platform/chromium-mac-leopard/dom/xhtml/level3/core/documentgetinputencoding03-expected.png: Added.
  • platform/chromium-mac-leopard/dom/xhtml/level3/core/entitygetinputencoding02-expected.png: Added.
  • platform/chromium-mac-leopard/dom/xhtml/level3/core/entitygetxmlversion02-expected.png: Added.
  • platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri05-expected.png: Added.
  • platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri07-expected.png: Added.
  • platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri09-expected.png: Added.
  • platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri10-expected.png: Added.
  • platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri11-expected.png: Added.
  • platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri15-expected.png: Added.
  • platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri17-expected.png: Added.
  • platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri18-expected.png: Added.
  • platform/chromium-mac-leopard/dom/xhtml/level3/core/nodelookupnamespaceuri01-expected.png: Added.
  • platform/chromium-mac-leopard/dom/xhtml/level3/core/nodelookupprefix19-expected.png: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/paste-RTFD-expected.png: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/paste-TIFF-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/designmode-no-caret-expected.png: Added.
  • platform/chromium-mac-leopard/editing/spelling/grammar-expected.txt: Added.
  • platform/chromium-mac-leopard/editing/text-iterator/findString-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/backgrounds/animated-gif-as-background-expected.png: Added.
  • platform/chromium-mac-leopard/fast/backgrounds/solid-color-context-restore-expected.png: Added.
  • platform/chromium-mac-leopard/fast/canvas/fill-stroke-clip-reset-path-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/color-correction-on-box-shadow-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/color-correction-on-text-shadow-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/disabled-author-styles-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/font-weight-1-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/outline-auto-empty-rects-expected.png: Added.
  • platform/chromium-mac-leopard/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png: Added.
  • platform/chromium-mac-leopard/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
  • platform/chromium-mac-leopard/fast/dom/gc-10-expected.png: Added.
  • platform/chromium-mac-leopard/fast/events/keydown-1-expected.png: Added.
  • platform/chromium-mac-leopard/fast/fast-mobile-scrolling/fixed-position-element-expected.png: Added.
  • platform/chromium-mac-leopard/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.png: Added.
  • platform/chromium-mac-leopard/fast/frames/flattening/frameset-flattening-advanced-expected.png: Added.
  • platform/chromium-mac-leopard/fast/frames/flattening/frameset-flattening-grid-expected.png: Added.
  • platform/chromium-mac-leopard/fast/frames/flattening/frameset-flattening-simple-expected.png: Added.
  • platform/chromium-mac-leopard/fast/frames/flattening/frameset-flattening-subframe-resize-expected.png: Added.
  • platform/chromium-mac-leopard/fast/frames/flattening/frameset-flattening-subframesets-expected.png: Added.
  • platform/chromium-mac-leopard/fast/frames/flattening/iframe-flattening-fixed-height-expected.png: Added.
  • platform/chromium-mac-leopard/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.png: Added.
  • platform/chromium-mac-leopard/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.png: Added.
  • platform/chromium-mac-leopard/fast/frames/flattening/iframe-flattening-fixed-width-expected.png: Added.
  • platform/chromium-mac-leopard/fast/frames/flattening/iframe-flattening-offscreen-expected.png: Added.
  • platform/chromium-mac-leopard/fast/frames/flattening/iframe-flattening-simple-expected.png: Added.
  • platform/chromium-mac-leopard/fast/frames/inline-object-inside-frameset-expected.png: Added.
  • platform/chromium-mac-leopard/fast/images/pdf-as-image-landscape-expected.png: Added.
  • platform/chromium-mac-leopard/fast/reflections/inline-crash-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/fixed-child-move-after-scroll-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/fixed-move-after-scroll-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-in-scrolled-clipped-block-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/rel-positioned-inline-with-overflow-expected.png: Added.
  • platform/chromium-mac-leopard/fast/replaced/pdf-as-image-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/empty-section-crash-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/font-initial-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/text/international/bidi-neutral-run-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/text/international/bold-bengali-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/international/thai-baht-space-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/text/whitespace/normal-after-nowrap-breaking-expected.png: Added.
  • platform/chromium-mac-leopard/fast/writing-mode/border-vertical-lr-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/writing-mode/japanese-lr-selection-expected.png: Added.
  • platform/chromium-mac-leopard/fast/writing-mode/japanese-rl-selection-expected.png: Added.
  • platform/chromium-mac-leopard/http/tests/inspector/console-websocket-error-expected.txt: Added.
  • platform/chromium-mac-leopard/http/tests/misc/favicon-as-image-expected.png: Added.
  • platform/chromium-mac-leopard/http/tests/misc/slow-loading-image-in-pattern-expected.png: Added.
  • platform/chromium-mac-leopard/http/tests/misc/slow-loading-mask-expected.png: Added.
  • platform/chromium-mac-leopard/http/tests/navigation/error404-goback-expected.png: Added.
  • platform/chromium-mac-leopard/http/tests/navigation/error404-subframeload-expected.png: Added.
  • platform/chromium-mac-leopard/java/lc3/JavaObject/JavaObjectToDouble-001-expected.txt: Added.
  • platform/chromium-mac-leopard/media/video-replaces-poster-expected.png: Added.
  • platform/chromium-mac-leopard/platform/mac/editing/input/devanagari-ligature-expected.txt: Added.
  • platform/chromium-mac-leopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Added.
  • platform/chromium-mac-leopard/platform/mac/fast/loader/file-url-mimetypes-3-expected.txt: Added.
  • platform/chromium-mac-leopard/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Added.
  • platform/chromium-mac-leopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
  • platform/chromium-mac-leopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_500/S7.6_A3.1-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_500/S7.6_A3.2-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_500/S7.6_A5.3_T1-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_500/S7.6_A5.3_T2-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S15.5.4.16_A1-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S15.5.4.18_A1-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A1.1_T1-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A1.1_T2-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A1.1_T4-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A2.2_T1-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A2.2_T2-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A2.3-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A5.2_T1-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A5.2_T2-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A5.2_T4-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A5.2_T7-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A5.2_T8-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A5.2_T9-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/custom/image-with-prefix-in-webarchive-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/style-attribute-font-size-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dom/SVGTransformList-basics-expected.png: Added.
  • platform/chromium-mac-leopard/svg/hixie/error/012-expected.png: Added.
  • platform/chromium-mac-leopard/svg/hixie/error/012-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/hixie/mixed/007-expected.png: Added.
  • platform/chromium-mac-leopard/svg/text/font-size-below-point-five-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
  • platform/chromium-mac-leopard/svg/webarchive/svg-cursor-subresources-expected.png: Added.
  • platform/chromium-mac-leopard/svg/webarchive/svg-feimage-subresources-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/core/captions1-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/core/captions2-expected.png: Added.
  • platform/chromium-mac-leopard/transforms/2d/zoom-menulist-expected.png: Added.
  • platform/chromium-mac-leopard/transforms/3d/general/perspective-units-expected.png: Added.
  • platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-2-expected.png: Added.
  • platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Added.
  • platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Added.
  • platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-expected.png: Added.
  • platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png: Added.
  • platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.png: Added.
  • platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/masks/layer-mask-placement-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/video/video-background-color-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t1202-counter-09-b-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css2.1/t1202-counters-09-b-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/images/cross-fade-background-size-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/images/cross-fade-blending-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/images/cross-fade-simple-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/images/cross-fade-sizing-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-TIFF-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/canvas/set-colors-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/images/pdf-as-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/span/generated-child-split-flow-crash-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/preloader/document-write-2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/preloader/document-write-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/regions/region-overflow-break-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/regions/region-overflow-break-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/fallback-traits-fixup-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/hyphenate-character-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/hyphenate-limit-before-after-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/hyphenate-limit-lines-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/hyphenate-limit-lines-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/hyphenate-locale-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/hyphens-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-AN-after-empty-run-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-AN-after-empty-run-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-neutral-run-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-neutral-run-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bold-bengali-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bold-bengali-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/khmer-selection-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/midword-break-before-surrogate-pair-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/midword-break-before-surrogate-pair-2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/whitespace/normal-after-nowrap-breaking-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/mac/compositing/canvas/accelerated-canvas-compositing-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/mac/editing/selection/25228-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-3-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/mac/fast/text/combining-character-sequence-fallback-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/mac/fast/text/combining-character-sequence-fallback-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/mac/fast/text/line-break-locale-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/mac/fast/text/line-break-locale-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/mac/scrollbars/key-window-not-first-responder-expected.png: Added.
  • platform/chromium-mac-snowleopard/printing/compositing-layer-printing-expected.png: Added.
  • platform/chromium-mac-snowleopard/printing/media-queries-print-expected.png: Added.
  • platform/chromium-mac-snowleopard/printing/page-rule-in-media-query-expected.png: Added.
  • platform/chromium-mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt: Added.
  • platform/chromium-mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Added.
  • platform/chromium-mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/custom/image-with-prefix-in-webarchive-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/style-attribute-font-size-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/transform-with-shadow-and-gradient-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dom/SVGLocatable-getCTM-svg-root-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dom/SVGTransformList-basics-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGAElement-dom-href-attr-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGAElement-dom-target-attr-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGAElement-svgdom-href-prop-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGAElement-svgdom-target-prop-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/sourceAlpha-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/error/012-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/mixed/007-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/viewbox/001-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/viewbox/002-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/text/non-bmp-positioning-lists-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/text/text-intro-05-t-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/webarchive/svg-cursor-subresources-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/webarchive/svg-feimage-subresources-expected.png: Added.
  • platform/chromium-mac-snowleopard/transforms/2d/hindi-rotated-expected.png: Added.
  • platform/chromium-mac-snowleopard/transforms/3d/general/perspective-units-expected.png: Added.
  • platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Added.
  • platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-expected.png: Added.
  • platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png: Added.
  • platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png: Added.
  • platform/chromium-mac-snowleopard/webarchive/adopt-attribute-styled-body-webarchive-expected.png: Added.
  • platform/chromium-mac-snowleopard/webarchive/test-css-url-resources-in-stylesheets-expected.png: Added.
  • platform/chromium-mac-snowleopard/webarchive/test-link-rel-icon-beforeload-expected.png: Added.
15:59 Changeset [113787] by ojan@chromium.org

Add a chromeless view to the individual tests view
https://bugs.webkit.org/show_bug.cgi?id=83541

Reviewed by Daniel Bates.

This is the view suitable to inlining in other contexts (e.g. garden-o-matic).

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:

(testHtmlForIndividualTestOnAllBuilders):
(testHtmlForIndividualTestOnAllBuildersWithChromeNonexistant):
(testHtmlForIndividualTestOnAllBuildersWithChrome):
(testHtmlForIndividualTestOnAllBuildersWithChromeWebkitMaster):
(testHtmlForIndividualTests):
(htmlEscape):
(runTests):

15:59 Changeset [113786] by rakuco@webkit.org

[CMake] Do not pass -P to the preprocessor when running make_names.pl.
https://bugs.webkit.org/show_bug.cgi?id=83225

Reviewed by Rob Buis.

This is necessary to make CMake-based ports build with the
recently-released GCC 4.7.0, whose preprocessor seems to ignore
empty lines when -P is passed to it. Such behavior breaks
make_names.pl (in fact, InFilesParser.pm), which expects an empty
line to separate common and specific sections in .in files.

A fix for this same problem has been supposedly done in r84123,
but as the CMake-based ports always pass --preprocessor to the
Perl tools the fix never reached us.

The idea is to define CODE_GENERATOR_PREPROCESSOR_WITH_LINEMARKERS
for (!MSVC && !QNX) and use it in the macros which call
make_names.pl.

  • Source/cmake/OptionsCommon.cmake:
  • Source/cmake/WebKitMacros.cmake:
15:52 Changeset [113785] by tomz@codeaurora.org

Unreviewed update to test expectations

  • platform/efl/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
  • platform/win/test_expectations.txt:
15:41 Changeset [113784] by simonjam@chromium.org

[Chromium] Fix test_expectations.txt from r113776.

  • platform/chromium/test_expectations.txt:
15:39 Changeset [113783] by commit-queue@webkit.org

Web Inspector: CodeGeneratorInspector.py: do not expose raw methods from generated types
https://bugs.webkit.org/show_bug.cgi?id=83390

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-04-10
Reviewed by Yury Semikhatsky.

Intermediate classes InspectorObjectBase and InspectorArrayBase are created. They have all raw methos
protected. InspectorObject and InspectorArray now inherit the corresponding base classes with exposing
all their protected methods.

"Open types" are left inheriting from InspectorObject, plus field name constants are generated for
an easy random access to all properties.

All the client code is fixed to use type-safe API rather than raw access methods in function parameter
and return types and bodies.

  • inspector/CodeGeneratorInspector.py:

(RawTypes.Object):
(RawTypes.Object.get_setter_name):
(RawTypes.Array):
(RawTypes.Array.get_setter_name):
(TypeBindings.create_type_declaration_.ClassBinding.get_code_generator.CodeGenerator.generate_type_builder):
(Array):
(Generator):
(Generator.resolve_type_and_generate_ad_hoc.InterfaceGenerateContext):
(Generator.process_types.GenerateContext):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::querySelectorAll):
(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::buildObjectForEventListener):

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::descriptionForDOMEvent):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::didPause):

  • inspector/InspectorPageAgent.cpp:

(WebCore::buildObjectForSearchResult):
(WebCore::InspectorPageAgent::searchInResources):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::didReceiveResponse):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::fillMediaListChain):
(WebCore::InspectorStyle::styleWithProperties):

  • inspector/InspectorValues.cpp:

(WebCore::InspectorObjectBase::~InspectorObjectBase):
(WebCore::InspectorObjectBase::asObject):
(WebCore::InspectorObjectBase::openAccessors):
(WebCore):
(WebCore::InspectorObjectBase::getBoolean):
(WebCore::InspectorObjectBase::getString):
(WebCore::InspectorObjectBase::getObject):
(WebCore::InspectorObjectBase::getArray):
(WebCore::InspectorObjectBase::get):
(WebCore::InspectorObjectBase::remove):
(WebCore::InspectorObjectBase::writeJSON):
(WebCore::InspectorObjectBase::InspectorObjectBase):
(WebCore::InspectorArrayBase::~InspectorArrayBase):
(WebCore::InspectorArrayBase::asArray):
(WebCore::InspectorArrayBase::writeJSON):
(WebCore::InspectorArrayBase::InspectorArrayBase):
(WebCore::InspectorArrayBase::get):

  • inspector/InspectorValues.h:

(InspectorObjectBase):
(InspectorObject):
(WebCore::InspectorObject::create):
(WebCore):
(InspectorArrayBase):
(WebCore::InspectorArrayBase::length):
(InspectorArray):
(WebCore::InspectorArray::create):
(WebCore::InspectorObjectBase::find):
(WebCore::InspectorObjectBase::setBoolean):
(WebCore::InspectorObjectBase::setNumber):
(WebCore::InspectorObjectBase::setString):
(WebCore::InspectorObjectBase::setValue):
(WebCore::InspectorObjectBase::setObject):
(WebCore::InspectorObjectBase::setArray):
(WebCore::InspectorArrayBase::pushBoolean):
(WebCore::InspectorArrayBase::pushInt):
(WebCore::InspectorArrayBase::pushNumber):
(WebCore::InspectorArrayBase::pushString):
(WebCore::InspectorArrayBase::pushValue):
(WebCore::InspectorArrayBase::pushObject):
(WebCore::InspectorArrayBase::pushArray):

  • inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createGenericRecord):

15:37 Changeset [113782] by commit-queue@webkit.org

[Chromium] defaultDeviceScaleFactor != 0 should set deviceScaleFactor = defaultDeviceScaleFactor in the absence of a viewport tag for debugging purposes
https://bugs.webkit.org/show_bug.cgi?id=82757

Patch by Tim Dresser <tdresser@chromium.org> on 2012-04-10
Reviewed by Darin Fisher.

If there is no viewport tag, the deviceScaleFactor is set to the defaultDeviceScaleFactor.
Tested by: WebFrameTest.DeviceScaleFactorUsesDefaultWithoutViewportTag.

  • src/ChromeClientImpl.cpp:

(WebKit):
(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):

  • tests/WebFrameTest.cpp:

(WebKit):
(FixedLayoutTestWebViewClient):
(WebKit::TEST_F):

  • tests/data/no_viewport_tag.html: Added.
15:36 Changeset [113781] by pdr@google.com

Remove unnecessary calls to RenderSVGShape::createShape()
https://bugs.webkit.org/show_bug.cgi?id=83598

Reviewed by Rob Buis.

RenderSVGShape::strokeContains contains calls to fall back to path stroke hit detection
in several cases (dashed strokes, for example). One of these cases, a check for isStyled,
is not needed and is always true for Ellipses, Circles, and Rects (all styled elements).
This change removes the check for isStyled.

No new tests as this only affects performance, not test results.

  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::strokeContains):

15:33 Changeset [113780] by mitz@apple.com

<rdar://problem/10912486> CanvasRenderingContext2D does not expose its backing store resolution
https://bugs.webkit.org/show_bug.cgi?id=83619

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/canvas/2d.backingStorePixelRatio.html

Added a backingStorePixelRatio attribute to CanvasRenderingContext2D, as proposed in
<http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-March/035112.html>. The attribute
is prefixed with “webkit” for now.

  • html/HTMLCanvasElement.h:

(WebCore::HTMLCanvasElement::deviceScaleFactor): Added this getter.

  • html/canvas/CanvasRenderingContext2D.h:

(WebCore::CanvasRenderingContext2D::webkitBackingStorePixelRatio): Added. Returns the canvas
element’s device scale factor.
(CanvasRenderingContext2D):

  • html/canvas/CanvasRenderingContext2D.idl: Added webkitBackingStorePixelRatio as a

read-only attribute.

LayoutTests:

  • fast/canvas/2d.backingStorePixelRatio-expected.txt: Added.
  • fast/canvas/2d.backingStorePixelRatio.html: Added.
  • platform/mac/fast/canvas/2d.backingStorePixelRatio-expected.txt: Added.
  • platform/win/fast/canvas/2d.backingStorePixelRatio-expected.txt: Added.
15:26 Changeset [113779] by rakuco@webkit.org

[EFL][DRT] Top level SVG rebaselines
https://bugs.webkit.org/show_bug.cgi?id=83585

Unreviewed, EFL rebaseline.

Landing bug 83562 enables us to do a bigger rebaselining and
unskipping of EFL SVG testcases. This is part one.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-10

  • platform/efl/Skipped:
  • platform/efl/svg/as-object/object-box-sizing-no-width-height-expected.png: Added.
  • platform/efl/svg/as-object/object-box-sizing-no-width-height-expected.txt: Added.
  • platform/efl/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
  • platform/efl/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
  • platform/efl/svg/dom/SVGPathSegList-cloning-expected.png: Added.
  • platform/efl/svg/dom/SVGPathSegList-cloning-expected.txt: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.txt: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.txt: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.txt: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.txt: Added.
15:24 Changeset [113778] by commit-queue@webkit.org

Segmentation fault in JS drop-down menus in facebook.com
https://bugs.webkit.org/show_bug.cgi?id=82896

Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-04-10
Reviewed by Chris Fleizach.

Make sure changes introduced with r110819 affect to the Mac
platform only, since they depend on platform specific behaviour,
as not all the platforms treat attachments in the same way.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::updateChildrenIfNecessary):

  • accessibility/AccessibilityObject.h:

(AccessibilityObject):
(WebCore::AccessibilityObject::detachFromParent):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore):
(WebCore::AccessibilityRenderObject::addChildren):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

  • accessibility/mac/AccessibilityObjectMac.mm:

(WebCore::AccessibilityObject::detachFromParent):
(WebCore):

15:18 Changeset [113777] by andersca@apple.com

Fix fast/images/exif-orientation.html WebKitTestRunner failure
https://bugs.webkit.org/show_bug.cgi?id=83627

Reviewed by Sam Weinig.

Handle overriding the WebKitShouldRespectImageOrientation preference.

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

15:17 Changeset [113776] by jer.noble@apple.com

Layout Test webaudio/* is flaky
https://bugs.webkit.org/show_bug.cgi?id=83624

Add failing tests to skipped list.

  • platform/chromium/test_expectations.txt:
15:15 Changeset [113775] by dpranke@chromium.org

remove 'win' from chromium-win, chromium-linux fallback paths
https://bugs.webkit.org/show_bug.cgi?id=83613

Reviewed by Ojan Vafai.

The chromium ports no longer need to look at the apple 'win'
directory for baseline results.

Also remove the old '-gpu-' entries from the flakiness dashboard
map since I'm touching lines nearby.

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:

(ChromiumLinuxPort):

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:

(ChromiumWinPort):

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
14:57 Changeset [113774] by kling@webkit.org

REGRESSION(r113588): 15-30% perf. regression on CSS/CSSPropertySetterGetter.
<http://webkit.org/b/83540>

Reviewed by Antti Koivisto.

Changed the behavior of getPropertyCSSValueInternal() to actually return the internal
value rather than a cloned one. There is an assertion in the CSSValue bindings that
will catch anyone trying to expose these values to the web.

This avoids constructing "safe" CSSValue objects in the bindings layer, for the cases
where we only want to extract the cssText or numeric value. These cloned objects are
only needed when exposing fully-fledged CSSValues to the web, which must be tied to
a single document.

  • css/CSSStyleDeclaration.h:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValueInternal):

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal):

14:52 Changeset [113773] by noam.rosenthal@nokia.com

[Qt][WK2] Manage graphics buffers in the web process
https://bugs.webkit.org/show_bug.cgi?id=78675

Source/WebCore:

Added WebCore::GraphicsSurface, a wrapper class to a platform-dependant
surface that can be accessed efficiently by both the CPU and the GPU.
This will allow fast texture uploads for WebKit2, and in the future
fast copies for 2D canvas and WebGL.
The first implementation is for Mac using IOSurfaces.

TextureMapperGL had to be modified to use GL_UNSIGNED_INT_8_8_8_8_REV
for textures on Mac, since that's the native pixel format of BGRA
IOSurfaces.

Though this feature is not written in a Qt-specific way, it's currently
only enabled for Qt and is protected by USE(GRAPHICS_SURFACE).

Reviewed by Kenneth Rohde Christiansen.

Covered by existing API tests.

  • Target.pri:
  • WebCore.pri:
  • platform/graphics/surfaces/GraphicsSurface.cpp: Added.
  • platform/graphics/surfaces/GraphicsSurface.h: Added.
  • platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp: Added.
  • platform/graphics/surfaces/qt/GraphicsSurfaceQt.cpp: Added.

(WebCore::GraphicsSurface::didReleaseImage):
(WebCore):
(WebCore::GraphicsSurface::platformBeginPaint):
(WebCore::GraphicsSurface::createReadOnlyImage):

  • platform/graphics/texmap/TextureMapper.h:

(WebCore::BitmapTexture::isOpenGLBacked):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::toBitmapTextureGL):
(WebCore):
(WebCore::BitmapTextureGL::didReset):
(WebCore::BitmapTextureGL::updateContents):

  • platform/graphics/texmap/TextureMapperGL.h:

(WebCore::BitmapTextureGL::isOpenGLBacked):
(WebCore):

Source/WebKit2:

Added ShareableSurface, a class allowing the use of GPU-enabled
surfaces for bitmap transfer between the web and UI processes.
Since GraphicsSurfaces may not always be available, ShareableSurface
uses a standard ShareableBitmap as a fallback backend.

The necessary plumbing was added in WebKit2 for passing updates via
ShareableSurfaces instead of ShareableBitmaps. SurfaceUpdateInfo was
added, as to not make UpdateInfo more complicated.

Reviewed by Kenneth Rohde Christiansen.

  • Shared/ShareableSurface.cpp: Added.
  • Shared/ShareableSurface.h: Added.
  • Shared/SurfaceUpdateInfo.cpp: Added.
  • Shared/SurfaceUpdateInfo.h: Added.
  • Target.pri:
  • UIProcess/LayerTreeHostProxy.cpp:

(WebKit::LayerTreeHostProxy::createTileForLayer):
(WebKit::LayerTreeHostProxy::updateTileForLayer):

  • UIProcess/LayerTreeHostProxy.h:

(LayerTreeHostProxy):

  • UIProcess/LayerTreeHostProxy.messages.in:
  • UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::WebLayerTreeRenderer::updateTile):

  • UIProcess/WebLayerTreeRenderer.h:

(TileUpdate):
(WebKit::WebLayerTreeRenderer::TileUpdate::TileUpdate):

  • UIProcess/qt/LayerBackingStore.cpp:

(WebKit::LayerBackingStoreTile::swapBuffers):
(WebKit::LayerBackingStoreTile::setBackBuffer):
(WebKit::LayerBackingStore::updateTile):

  • UIProcess/qt/LayerBackingStore.h:

(LayerBackingStoreTile):
(LayerBackingStore):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::beginContentUpdate):
(WebCore::WebGraphicsLayer::createTile):
(WebCore::WebGraphicsLayer::updateTile):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:

(WebGraphicsLayerClient):
(WebGraphicsLayer):

  • WebProcess/WebPage/TiledBackingStoreRemoteTile.cpp:

(WebKit::TiledBackingStoreRemoteTile::updateBackBuffer):

  • WebProcess/WebPage/TiledBackingStoreRemoteTile.h:

(WebKit):
(TiledBackingStoreRemoteTileClient):

  • WebProcess/WebPage/UpdateAtlas.cpp:

(WebKit::UpdateAtlas::UpdateAtlas):
(WebKit::UpdateAtlas::beginPaintingOnAvailableBuffer):

  • WebProcess/WebPage/UpdateAtlas.h:

(WebKit::UpdateAtlas::surface):
(WebKit::UpdateAtlas::size):

  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::createTile):
(WebKit::LayerTreeHostQt::updateTile):
(WebKit::LayerTreeHostQt::beginContentUpdate):

  • WebProcess/WebPage/qt/LayerTreeHostQt.h:

(LayerTreeHostQt):

Tools:

Enable graphics surfaces on Mac for Qt.

Reviewed by Kenneth Rohde Christiansen.

  • qmake/mkspecs/features/features.prf:
14:52 Changeset [113772] by andersca@apple.com

Add fast/dom/inline-event-attributes-release.html to the Skipped list.

  • platform/mac/Skipped:
14:45 Changeset [113771] by commit-queue@webkit.org

Web Inspector: split nodes and edges array in heap profiler serialization.
https://bugs.webkit.org/show_bug.cgi?id=83465

Frontend is now able to read format when nodes and edges arrive
in two separate arrays.

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-04-10
Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotLoader.prototype._parseIntArray):
(WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
(WebInspector.HeapSnapshot):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):

LayoutTests:

  • inspector/profiler/heap-snapshot-loader-expected.txt:
  • inspector/profiler/heap-snapshot-loader.html:
  • inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotSplitNodesEdgesMockRaw):

14:41 Changeset [113770] by commit-queue@webkit.org

CSS box-shadow default color should be something other than transparent
https://bugs.webkit.org/show_bug.cgi?id=58511

Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-04-10
Reviewed by Simon Fraser.

Source/WebCore:

If box-shadow or text-shadow color is not specified, color defaults to
the value specified in the 'color' property of the element (as specified in W3C
spec).

Test: fast/text/text-shadow-no-default-color.html. Also existing
tests ietestcenter/css3/box-shadow-002 and ietestcenter/css3/box-shadow-003

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

LayoutTests:

Added new test for the case where no color is specified for text
shadow. This test and two others are marked as expected fail pending
rebaseline.

  • fast/text/text-shadow-no-default-color.html: Added.
  • platform/chromium/test_expectations.txt:
14:28 Changeset [113769] by crogers@google.com

AudioParam must support connections from audio-rate signals
https://bugs.webkit.org/show_bug.cgi?id=83524

Source/WebCore:

Reviewed by Eric Carlson.

In the Web Audio API, it's possible to connect one AudioNode to another AudioNode.
Similary we should allow an AudioNode to connect to an AudioParam, thus controlling
a parameter with an audio-rate signal. This is important in many audio processing
applications.

Test: webaudio/audioparam-connect-audioratesignal.html

Simple method name change of AudioParam::hasTimelineValues() to AudioParam::hasSampleAccurateValues().

  • Modules/webaudio/AudioGainNode.cpp:

(WebCore::AudioGainNode::process):

  • Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::connect): Add connect() method from AudioNode -> AudioParam.
(WebCore):
(WebCore::AudioNode::disconnect):
(WebCore::AudioNode::finishDeref):
Use AudioNodeOutput::disconnectAll() instead of AudioNodeOutput::disconnectAllInputs().

  • Modules/webaudio/AudioNode.h: Add connect() method from AudioNode -> AudioParam.

(WebCore):
(AudioNode):

  • Modules/webaudio/AudioNode.idl: Add connect() method from AudioNode -> AudioParam.

Implement support for an AudioNodeOutput to fanout to multiple AudioParams.

  • Modules/webaudio/AudioNodeOutput.cpp:

(WebCore::AudioNodeOutput::AudioNodeOutput):
(WebCore::AudioNodeOutput::updateRenderingState): Update rendering state related to AudioParams.
(WebCore::AudioNodeOutput::pull): pull() must now take into account fanout to AudioParams for in-place processing.
(WebCore::AudioNodeOutput::fanOutCount):
(WebCore):
(WebCore::AudioNodeOutput::paramFanOutCount): New method keeping track of number of connections to AudioParams.
(WebCore::AudioNodeOutput::renderingParamFanOutCount): New method keeping track of number of connections to AudioParams for rendering.
(WebCore::AudioNodeOutput::addParam): Add a connection to an AudioParam.
(WebCore::AudioNodeOutput::removeParam): Remove a connection to an AudioParam.
(WebCore::AudioNodeOutput::disconnectAllParams): Remove all connections to AudioParams.
(WebCore::AudioNodeOutput::disconnectAll): New method to disconnect all AudioNodeInputs and AudioParams.

  • Modules/webaudio/AudioNodeOutput.h:

(AudioNodeOutput):

Allow an AudioParam to accept a connection from an AudioNodeOutput, thus being controlled
by an audio-rate signal.

  • Modules/webaudio/AudioParam.cpp:

(WebCore::AudioParam::calculateSampleAccurateValues): Calculates sample-accurate values from timeline or an AudioNode.
(WebCore):
(WebCore::AudioParam::calculateAudioRateSignalValues): Calculates sample-accurate values from an AudioNode.
(WebCore::AudioParam::calculateTimelineValues): Calculates sample-accurate values scheduled on the timeline.
(WebCore::AudioParam::connect): Connect from an AudioNodeOutput for control from an audio-rate signal.
(WebCore::AudioParam::disconnect): Disconnect from an AudioNodeOutput.

  • Modules/webaudio/AudioParam.h:

(WebCore):
(WebCore::AudioParam::AudioParam):
(WebCore::AudioParam::hasSampleAccurateValues): Change name from hasTimelineValues() and return true
either if we have timeline values or if we've been connected from an AudioNode.
(AudioParam):

Simple method name change of AudioParam::hasTimelineValues() to AudioParam::hasSampleAccurateValues().

  • Modules/webaudio/Oscillator.cpp:

(WebCore::Oscillator::calculateSampleAccuratePhaseIncrements):
(WebCore::Oscillator::process):

LayoutTests:

Reviewed by Eric Carlson.

  • webaudio/audioparam-connect-audioratesignal-expected.txt: Added.
  • webaudio/audioparam-connect-audioratesignal.html: Added.
  • webaudio/resources/audio-testing.js:

(createLinearRampBuffer):
(createConstantBuffer):

14:25 Changeset [113768] by leviw@chromium.org

Fix that mirrors the change from Bug 83604. Cleaning up RenderedPosition::absoluteRect and its usage in Editor.

14:16 Changeset [113767] by paroga@webkit.org

[CMake][WIN] Add /MP flag when using a compiler with support for it
https://bugs.webkit.org/show_bug.cgi?id=83577

Reviewed by Daniel Bates.

  • Source/cmake/OptionsWindows.cmake:
14:14 Changeset [113766] by paroga@webkit.org

[CMake] Add missing DERIVED_SOURCES_WEBKIT_DIR variable
https://bugs.webkit.org/show_bug.cgi?id=83573

Reviewed by Daniel Bates.

We need this variable when ports want to generate files in the WebKit target.

  • CMakeLists.txt:
14:12 Changeset [113765] by darin@apple.com

Remove unused data member from Lexer class
https://bugs.webkit.org/show_bug.cgi?id=83429

Reviewed by Kentaro Hara.

I noticed that m_delimited was "write-only", so I deleted it.

  • parser/Lexer.cpp:

(JSC::Lexer::setCode): Removed code to set m_delimited.
(JSC::Lexer::parseIdentifier): Ditto.
(JSC::Lexer::parseIdentifierSlowCase): Ditto.
(JSC::Lexer::lex): Ditto.

  • parser/Lexer.h: Deleted m_delimited.
14:07 Changeset [113764] by paroga@webkit.org

[CMake] Enable USE_FOLDERS property
https://bugs.webkit.org/show_bug.cgi?id=83571

Reviewed by Daniel Bates.

.:

Setting the FOLDER property on targets gives more structure
to the generated Visual Studio solutions.
This does not affect other CMake generators.

  • Source/cmake/OptionsCommon.cmake:

Source/JavaScriptCore:

Setting the FOLDER property on targets gives more structure
to the generated Visual Studio solutions.
This does not affect other CMake generators.

  • CMakeLists.txt:
  • shell/CMakeLists.txt:

Source/WebCore:

Setting the FOLDER property on targets gives more structure
to the generated Visual Studio solutions.
This does not affect other CMake generators.

  • CMakeLists.txt:

Source/WebKit:

Setting the FOLDER property on targets gives more structure
to the generated Visual Studio solutions.
This does not affect other CMake generators.

  • CMakeLists.txt:

Source/WebKit2:

Setting the FOLDER property on targets gives more structure
to the generated Visual Studio solutions.
This does not affect other CMake generators.

  • CMakeLists.txt:

Source/WTF:

Setting the FOLDER property on targets gives more structure
to the generated Visual Studio solutions.
This does not affect other CMake generators.

  • wtf/CMakeLists.txt:

Tools:

Setting the FOLDER property on targets gives more structure
to the generated Visual Studio solutions.
This does not affect other CMake generators.

  • DumpRenderTree/efl/CMakeLists.txt:
  • EWebLauncher/CMakeLists.txt:
  • WinCELauncher/CMakeLists.txt:
14:05 Changeset [113763] by commit-queue@webkit.org

[CMake] CMake SVG Code Generation fails to generate code for extra defines
https://bugs.webkit.org/show_bug.cgi?id=83562

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-10
Reviewed by Rob Buis.

Fixing CMakeLists.txt to generate correct extra defines for SVG code generator.

  • CMakeLists.txt:
13:52 Changeset [113762] by lforschler@apple.com

Versioning.

13:50 Changeset [113761] by lforschler@apple.com

New tag.

13:40 BuildBot edited by rniwa@webkit.org
Update non-cygwin Windows instruction (diff)
13:34 Changeset [113760] by eae@chromium.org

chromium/linux and apple/win build fixes for branch.

13:32 Changeset [113759] by inferno@chromium.org

Crash due to captions list not updated after section recalc.
https://bugs.webkit.org/show_bug.cgi?id=83552

Reviewed by Julien Chaffraix.

Source/WebCore:

Test: fast/table/table-caption-not-removed-crash.html

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::addChild): no need to set the need for
section recalc. It was needed in old code when we had more than
one caption and we need to call section recalc to destroy the other
captions.
(WebCore::RenderTable::recalcSections): need to rebuild captions list.
This is how the old code worked before r100177. Basically, children can
moved without calling RenderTable::removeChild, so we should depend on
recalcSections to update our captions list. Also, fix a style nit of aligning
case labels with the switch statement.

LayoutTests:

  • fast/table/table-caption-not-removed-crash-expected.txt: Added.
  • fast/table/table-caption-not-removed-crash.html: Added.
13:09 Changeset [113758] by senorblanco@chromium.org

Merge 113373 - [chromium] Drawing an accelerated canvas onto itself is slow.
https://bugs.webkit.org/show_bug.cgi?id=83295

Fixed by using a GPU-side deepCopy() in skia, so we don't trigger a
readback and re-upload.

Reviewed by James Robinson.

Correctness is covered by existing tests. Performance is covered
by the test case attached to the bug.

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::BitmapImageSingleFrameSkia::create):

TBR=laforge@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9960076

12:55 Changeset [113757] by commit-queue@webkit.org

[BlackBerry] Crash when tearing down web page rendered using WebPageCompositor
https://bugs.webkit.org/show_bug.cgi?id=83567

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-04-10
Reviewed by Antonio Gomes.

Fixed by checking if there's a layer renderer before calling into it.

  • Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::releaseLayerResources):

12:48 Changeset [113756] by andersca@apple.com

Unreviewed, rolling out r113611.
http://trac.webkit.org/changeset/113611
https://bugs.webkit.org/show_bug.cgi?id=71541

Broke fast/forms/basic-textareas.html

Source/WebCore:

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hasHorizontalOverflow):
(WebCore::RenderLayer::hasVerticalOverflow):

LayoutTests:

  • fast/overflow/overflow-auto-destroy-scroll-after-resizing-expected.html: Removed.
  • fast/overflow/overflow-auto-destroy-scroll-after-resizing.html: Removed.
  • platform/efl/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
12:45 Changeset [113755] by commit-queue@webkit.org

Unreviewed, rolling out r113734.
http://trac.webkit.org/changeset/113734
https://bugs.webkit.org/show_bug.cgi?id=83606

causing a bunch of unrelated test failures (Requested by
simonjam on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-10

Source/WebCore:

  • Modules/battery/BatteryController.cpp:
  • Modules/battery/BatteryController.h:

(BatteryController):

  • Modules/battery/BatteryManager.cpp:

(WebCore::BatteryManager::charging):
(WebCore::BatteryManager::chargingTime):
(WebCore::BatteryManager::dischargingTime):
(WebCore::BatteryManager::level):

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:

Source/WebKit/chromium:

  • WebKit.gyp:
  • features.gypi:
  • public/WebBatteryStatus.h: Removed.
  • public/WebBatteryStatusClient.h: Removed.
  • public/WebView.h:

(WebKit):
(WebView):

  • public/WebViewClient.h:

(WebKit):

  • src/BatteryClientImpl.cpp: Removed.
  • src/BatteryClientImpl.h: Removed.
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

  • src/WebViewImpl.h:

(WebKit):
(WebViewImpl):

LayoutTests:

  • platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
  • platform/chromium/test_expectations.txt:
12:41 Changeset [113754] by adamk@chromium.org

Add setJSWrapperForActiveDOMNode and use it for Nodes that are also ActiveDOMObjects
https://bugs.webkit.org/show_bug.cgi?id=83528

Reviewed by Kentaro Hara.

Instead of using a run-time call to isActiveNode to determine which
map to put a Node wrapper in, generate the proper call in the CodeGenerator.

This was originally part of r112318, which got rolled out due to OOM concerns.
I'm splitting it into smaller pieces so that each can be landed and
watched for issues seperately.

No new tests, no change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateConstructorCallback): Use new GetDomMapName function to
figure out which setJSWrapper to call.
(GenerateNamedConstructorCallback): ditto.
(GetDomMapFunction): Delegate to GetDomMapName for logic.
(GetDomMapName): New helper factored out of GetDomMapFunction.

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::setJSWrapperForDOMNode): Assert !isActiveNode instead of branching on it.
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMNode): New method split ouf of the above.
Assert isActiveNode instead of branching on it.

  • bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):

12:36 Changeset [113753] by macpherson@chromium.org

Pass PropertyHandler by reference in CSSStyleApplyProperty.h.
https://bugs.webkit.org/show_bug.cgi?id=83551

Reviewed by Kentaro Hara.

No new tests / cleanup only.

  • css/CSSStyleApplyProperty.h:

(WebCore::CSSStyleApplyProperty::setPropertyHandler):

12:31 Changeset [113752] by macpherson@chromium.org

Pass FontDescription as const reference instead of by value in CSSStyleSelector.h.
https://bugs.webkit.org/show_bug.cgi?id=83548

Reviewed by Kentaro Hara.

FontDescription is relatively large, so pass-by-reference is preferred.

No new tests / code cleanup only.

  • css/CSSStyleSelector.h:

(WebCore::CSSStyleSelector::fontDescription):
(WebCore::CSSStyleSelector::parentFontDescription):
(WebCore::CSSStyleSelector::setFontDescription):

12:23 Changeset [113751] by adamk@chromium.org

Add TestNode.idl to run-binding-tests
https://bugs.webkit.org/show_bug.cgi?id=83599

Reviewed by Adam Barth.

TestNode.idl is a minimized version of Node.idl with enough attributes
to exercise CodeGenerator.pm's handling of Node subtypes.

  • bindings/scripts/test/CPP/WebDOMTestNode.cpp: Added.
  • bindings/scripts/test/CPP/WebDOMTestNode.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestNode.cpp: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestNode.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestNodePrivate.h: Added.
  • bindings/scripts/test/JS/JSTestNode.cpp: Added.
  • bindings/scripts/test/JS/JSTestNode.h: Added.
  • bindings/scripts/test/ObjC/DOMTestNode.h: Added.
  • bindings/scripts/test/ObjC/DOMTestNode.mm: Added.
  • bindings/scripts/test/ObjC/DOMTestNodeInternal.h: Added.
  • bindings/scripts/test/TestNode.idl: Added.
  • bindings/scripts/test/V8/V8TestNode.cpp: Added.
  • bindings/scripts/test/V8/V8TestNode.h: Added.
12:18 Changeset [113750] by eae@chromium.org

Fix style issues on branch.

12:15 Changeset [113749] by commit-queue@webkit.org

msqrt's implied mrow should do operator stretching
https://bugs.webkit.org/show_bug.cgi?id=82353

Patch by David Barton <dbarton@mathscribe.com> on 2012-04-10
Reviewed by Julien Chaffraix.

Source/WebCore:

An <msqrt> with more than one child is supposed to surround them with an implied <mrow>.
This patch does this, and thus includes vertical operator stretching. We also fix some
problems with the old RenderMathMLSquareRoot.cpp: possibly shared RenderStyles were
being modified, and layout() was using heights of children without checking whether they
needed layout themselves first.

To leave room for the radical sign, we use intrinsic padding. This is simpler and more
efficient than using anonymous RenderStyles.

Added tests to mo-stretch.html and style.xhtml. Regression tests are in roots.xhtml.

  • css/mathml.css:

(msqrt):

  • rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::RenderMathMLBlock):
(WebCore::RenderMathMLBlock::paddingTop):
(WebCore::RenderMathMLBlock::paddingBottom):
(WebCore::RenderMathMLBlock::paddingLeft):
(WebCore::RenderMathMLBlock::paddingRight):
(WebCore::RenderMathMLBlock::paddingBefore):
(WebCore::RenderMathMLBlock::paddingAfter):
(WebCore::RenderMathMLBlock::paddingStart):
(WebCore::RenderMathMLBlock::paddingEnd):

  • rendering/mathml/RenderMathMLBlock.h:

(RenderMathMLBlock):

  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::RenderMathMLRow):
(WebCore::RenderMathMLRow::createAnonymousWithParentRenderer):

  • rendering/mathml/RenderMathMLRow.h:

(RenderMathMLRow):

  • rendering/mathml/RenderMathMLSquareRoot.cpp:

(WebCore):
(WebCore::RenderMathMLSquareRoot::addChild):
(WebCore::RenderMathMLSquareRoot::computePreferredLogicalWidths):
(WebCore::RenderMathMLSquareRoot::computeLogicalHeight):
(WebCore::RenderMathMLSquareRoot::layout):
(WebCore::RenderMathMLSquareRoot::paint):

  • rendering/mathml/RenderMathMLSquareRoot.h:

(RenderMathMLSquareRoot):

LayoutTests:

  • mathml/presentation/mo-stretch.html:
  • mathml/presentation/style.xhtml:
  • platform/mac/mathml/presentation/attributes-expected.txt:
  • platform/mac/mathml/presentation/mo-stretch-expected.png:
  • platform/mac/mathml/presentation/mo-stretch-expected.txt:
  • platform/mac/mathml/presentation/roots-expected.txt:
  • platform/mac/mathml/presentation/style-expected.png:
  • platform/mac/mathml/presentation/style-expected.txt:
12:10 Changeset [113748] by macpherson@chromium.org

Don't allow fallthrough for CSSPropertyBaselineShift in CSSComputedStyleDeclaration::getSVGPropertyCSSValue().
https://bugs.webkit.org/show_bug.cgi?id=83536

Reviewed by Daniel Bates.

Add a return statement to the case CSSPropertyBaselineShift so that we don't fall through to the next case statement.

No new tests / code cleanup from coverity static analysis.

  • css/SVGCSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):

12:01 Changeset [113747] by adamk@chromium.org

Merge 113378 - Crash in MutationObservers due to an invalid HashSet iterator
https://bugs.webkit.org/show_bug.cgi?id=83304

Reviewed by Ojan Vafai.

Source/WebCore:

If the observed node has been GCed when we clear transient observers
from it, the HashSet iterator in WebKitMutationObserver::deliver would
be invalidated. This patch fixes that behavior by copying the relevant
registrations into a seperate vector first and operating on the copy.

This patch also fixes a bug: transient observers should be cleared
after every microtask, not just when delivering.

Tests: fast/mutation/clear-transient-without-delivery.html

fast/mutation/transient-gc-crash.html

  • dom/MutationObserverRegistration.cpp:

(WebCore::MutationObserverRegistration::observedSubtreeNodeWillDetach):
Notify the observer that it has a transient registration so it can be properly cleared.

  • dom/MutationObserverRegistration.h:

(WebCore::MutationObserverRegistration::hasTransientRegistrations):
Add an accessor for use when deliver() creates its vector of registrations.

  • dom/WebKitMutationObserver.cpp:

(WebCore::WebKitMutationObserver::setHasTransientRegistration): Add this to the active observer set
to allow transient registrations to be cleared appropriately.
(WebCore::WebKitMutationObserver::deliver): Avoid modifying m_registrations while iterating over it.
Clear registrations before checking for a lack of records to deliver.

  • dom/WebKitMutationObserver.h:

LayoutTests:

  • fast/mutation/clear-transient-without-delivery-expected.txt: Added.
  • fast/mutation/clear-transient-without-delivery.html: Added.
  • fast/mutation/transient-gc-crash-expected.txt: Added.
  • fast/mutation/transient-gc-crash.html: Added.

TBR=inferno@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9999033

11:56 Changeset [113746] by alex@webkit.org

2012-04-10 Alejandro G. Castro <alex@igalia.com>

[GTK] Build fix TextureMapper compilation and solve warning.

Reviewed by Martin Robinson.

  • platform/graphics/texmap/TextureMapperGL.cpp: (WebCore::BitmapTextureGL::updateContents):
  • platform/graphics/texmap/TextureMapperShaderManager.h: (WebCore::TextureMapperShaderManager::getShaderProgram):
11:52 Changeset [113745] by eae@chromium.org

Merge trunk changes up until 113730 into subpixel branch.

11:46 Changeset [113744] by andersca@apple.com

Add fast/events/drop-handler-should-not-stop-navigate.html.

Like fast/events/drop-with-file-paths.html, this expects eventSender.beginDragWithFiles to be implemented.

  • platform/wk2/Skipped:
11:44 Changeset [113743] by andersca@apple.com

Add fast/events/drop-with-file-paths.html to the WebKit2 Skipped list.

  • platform/wk2/Skipped:
11:29 Changeset [113742] by noel.gordon@gmail.com

[GTK] Separate image encoding from dataURL construction
https://bugs.webkit.org/show_bug.cgi?id=83152

Reviewed by Martin Robinson.

Remove the implicit assumption that a dataURL is the only desired output format
of the image encoding phase.

No new tests, refactoring only, covered by existing canvas tests.

  • platform/graphics/gtk/ImageBufferGtk.cpp:

(WebCore::encodeImage): Output the encoded image to the provided GOwnPtr<gchar>&
buffer. Update GTK document reference to a valid URL. Round the quality argument
to an int like the toDataURL() implementations of other ports. Ditch the success
variable; instead test the GError* error return to indicate success.
(WebCore):
(WebCore::ImageBuffer::toDataURL): Format the dataURL encoding of the mimeType
encoded image data buffer herein.

11:20 Changeset [113741] by antonm@chromium.org

Add test expectations for Mac debug builds.

Unreviewed.

  • platform/chromium-mac-snowleopard/fast/dom/shadow: Added.
  • platform/chromium-mac-snowleopard/fast/dom/shadow/selection-in-shadow-expected.txt: Added.
11:17 Changeset [113740] by jamesr@google.com

[chromium] Defer texture id allocation for copies until the actual copy executes
https://bugs.webkit.org/show_bug.cgi?id=83514

Reviewed by Adrienne Walker.

Source/WebCore:

This allows for queuing a texture copy operation into a ManagedTexture whose texture ID has not yet been
allocated. The ManagedTexture* serves as a promise that an ID will be available when the copy is executed.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::doCommit):

  • platform/graphics/chromium/cc/CCTextureUpdater.cpp:

(WebCore::CCTextureUpdater::CCTextureUpdater):
(WebCore::CCTextureUpdater::appendManagedCopy):
(WebCore):
(WebCore::CCTextureUpdater::hasMoreUpdates):
(WebCore::CCTextureUpdater::update):
(WebCore::CCTextureUpdater::clear):

  • platform/graphics/chromium/cc/CCTextureUpdater.h:

(CCTextureUpdater):
(ManagedCopyEntry):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):

Source/WebKit/chromium:

  • tests/CCTiledLayerTestCommon.cpp:
  • tests/CCTiledLayerTestCommon.h:
  • tests/Canvas2DLayerChromiumTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):

11:14 Changeset [113739] by hyatt@apple.com

Add ref test expected result.

11:14 Changeset [113738] by hyatt@apple.com

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=83595
<rdar://problem/10443278> Overlapping text in table cell across column break

If a cell's height changes such that it is taller than the overall row height because
of pagination, then grow the entire row height to enclose the cell instead of shrinking
the cell.

Reviewed by Dan Bernstein.

Added fast/multicol/cell-shrinkback.html

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=83595

Add new layout test for cells paginating across columns.

Reviewed by Dan Bernstein.

  • fast/multicol/cell-shrinkback.html: Added.
  • fast/multicol/cell-shrinkback-expected.html: Added.
  • platform/mac/fast/multicol/table-vertical-align-expected.txt:
11:10 Changeset [113737] by macpherson@chromium.org

Remove unnecessary null check in void SimplifyMarkupCommand::doApply().
https://bugs.webkit.org/show_bug.cgi?id=83535

Reviewed by Kentaro Hara.

No new tests / code cleanup only.

currentNode cannot be null within the loop body.
It is dereferenced before and after the removed line without checking.
Additionally I have added an assertion to express this loop invariant.

  • editing/SimplifyMarkupCommand.cpp:

(WebCore::SimplifyMarkupCommand::doApply):

10:47 Changeset [113736] by commit-queue@webkit.org

Add Encrypted Media Extensions methods to HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=82971

Patch by David Dorwin <ddorwin@chromium.org> on 2012-04-10
Reviewed by Adam Barth.

The extensions are behind the ENABLE(ENCRYPTED_MEDIA) feature define.
Implementation is based on v0.1 of the draft proposal at
http://dvcs.w3.org/hg/html-media/raw-file/tip/encrypted-media/encrypted-media.html.

Source/WebCore:

Tests: media/encrypted-media/encrypted-media-not-loaded.html

media/encrypted-media/encrypted-media-syntax.html

  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::webkitEncryptedMediaEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitEncryptedMediaEnabled):

  • html/HTMLMediaElement.cpp:

(WebCore):
(WebCore::exceptionCodeForMediaKeyException):
(WebCore::HTMLMediaElement::webkitGenerateKeyRequest):
(WebCore::HTMLMediaElement::webkitAddKey):
(WebCore::HTMLMediaElement::webkitCancelKeyRequest):
(WebCore::HTMLMediaElement::setVolume):
(WebCore::HTMLMediaElement::togglePlayState):
(WebCore::HTMLMediaElement::beginScrubbing):
(WebCore::HTMLMediaElement::addTextTrack):
(WebCore::HTMLMediaElement::textTracks):
(WebCore::HTMLMediaElement::showingTrackWithSameKind):
(WebCore::HTMLMediaElement::didAddTrack):

  • html/HTMLMediaElement.h:
  • html/HTMLMediaElement.idl:
  • platform/graphics/MediaPlayer.cpp:

(NullMediaPlayerPrivate):
(WebCore):
(WebCore::MediaPlayer::generateKeyRequest):
(WebCore::MediaPlayer::addKey):
(WebCore::MediaPlayer::cancelKeyRequest):

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(MediaPlayerPrivateInterface):
(WebCore::MediaPlayerPrivateInterface::addKey):
(WebCore::MediaPlayerPrivateInterface::generateKeyRequest):
(WebCore::MediaPlayerPrivateInterface::cancelKeyRequest):

Source/WebKit/chromium:

  • features.gypi:
  • public/WebMediaPlayer.h:

(WebKit):
(WebMediaPlayer):
(WebKit::WebMediaPlayer::generateKeyRequest):
(WebKit::WebMediaPlayer::addKey):
(WebKit::WebMediaPlayer::cancelKeyRequest):

  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

  • src/AssertMatchingEnums.cpp:
  • src/WebMediaPlayerClientImpl.cpp:

(WebKit):
(WebKit::WebMediaPlayerClientImpl::generateKeyRequest):
(WebKit::WebMediaPlayerClientImpl::addKey):
(WebKit::WebMediaPlayerClientImpl::cancelKeyRequest):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::isMediaStreamEnabled):
(WebKit::WebRuntimeFeatures::enableEncryptedMedia):
(WebKit):
(WebKit::WebRuntimeFeatures::isEncryptedMediaEnabled):

Tools:

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

LayoutTests:

  • media/encrypted-media/encrypted-media-not-loaded-expected.txt: Added.
  • media/encrypted-media/encrypted-media-not-loaded.html: Added.
  • media/encrypted-media/encrypted-media-syntax-expected.txt: Added.
  • media/encrypted-media/encrypted-media-syntax.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
10:33 Changeset [113735] by leviw@chromium.org

Build Fix for GTK.

10:28 Changeset [113734] by commit-queue@webkit.org

[chromium] Add Battery Status API support.

Source/WebCore:

Add Battery Status API support to chromium.
https://bugs.webkit.org/show_bug.cgi?id=83284

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-04-10
Reviewed by Adam Barth.

This change is covered by tests in batterystatus/.

  • Modules/battery/BatteryController.cpp:

(WebCore::BatteryController::updateBatteryStatus):
(WebCore):

  • Modules/battery/BatteryController.h:

(BatteryController):

  • Modules/battery/BatteryManager.cpp:

(WebCore::BatteryManager::charging):
(WebCore::BatteryManager::chargingTime):
(WebCore::BatteryManager::dischargingTime):
(WebCore::BatteryManager::level):

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:

Source/WebKit/chromium:

The battery-client (BatteryClientChromium) will notify the client (WebBatteryStatusClient) when to start or stop
sending battery status updates. The client, in response will send the notifications to WebViewImpl, which sends
this update information to the WebCore::BatteryClient, and it triggers the appropriate javascript-callbacks.
The spec is at http://www.w3.org/TR/2011/WD-battery-status-20111129/.
https://bugs.webkit.org/show_bug.cgi?id=83284

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-04-10
Reviewed by Adam Barth.

  • WebKit.gyp:
  • features.gypi:
  • public/WebBatteryStatus.h: Added.

(WebKit):
(WebBatteryStatus):
(WebKit::WebBatteryStatus::WebBatteryStatus):

  • public/WebBatteryStatusClient.h: Added.

(WebKit):
(WebBatteryStatusClient):
(WebKit::WebBatteryStatusClient::~WebBatteryStatusClient):

  • public/WebView.h:

(WebKit):
(WebView):
(WebKit::WebView::updateBatteryStatus):

  • public/WebViewClient.h:

(WebKit):
(WebViewClient):
(WebKit::WebViewClient::batteryStatusClient):

  • src/BatteryClientImpl.cpp: Added.

(WebKit):
(WebKit::BatteryClientImpl::BatteryClientImpl):
(WebKit::BatteryClientImpl::updateBatteryStatus):
(WebKit::BatteryClientImpl::setController):
(WebKit::BatteryClientImpl::startUpdating):
(WebKit::BatteryClientImpl::stopUpdating):
(WebKit::BatteryClientImpl::batteryControllerDestroyed):

  • src/BatteryClientImpl.h: Added.

(WebKit):
(BatteryClientImpl):
(WebKit::BatteryClientImpl::~BatteryClientImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit):
(WebKit::WebViewImpl::updateBatteryStatus):

  • src/WebViewImpl.h:

(WebKit):
(WebViewImpl):

LayoutTests:

Add Battery Status API support to chromium.
https://bugs.webkit.org/show_bug.cgi?id=83284

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-04-10
Reviewed by Adam Barth.

  • platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
  • platform/chromium/test_expectations.txt:
10:25 Changeset [113733] by zmo@google.com

getShaderFormatPrecision should return sensible values
https://bugs.webkit.org/show_bug.cgi?id=83520

Reviewed by Kenneth Russell.

Source/WebCore:

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: Fix getShaderPrecisionFormat values.

(WebCore::GraphicsContext3D::getShaderPrecisionFormat):

  • platform/graphics/qt/GraphicsContext3DQt.cpp: Ditto.

(WebCore::GraphicsContext3D::getShaderPrecisionFormat):

LayoutTests:

  • fast/canvas/webgl/shader-precision-format-expected.txt:
  • fast/canvas/webgl/shader-precision-format.html: Add tests to make sure getShaderPrecisionFormat returns sensible values.
10:20 Changeset [113732] by lforschler@apple.com

Merged r113654.

10:18 Changeset [113731] by apavlov@chromium.org

Web Inspector: Add Galaxy Nexus to the list of emulated user agents
https://bugs.webkit.org/show_bug.cgi?id=83589

The new record contains the device display metrics and the User Agent string.

Reviewed by Pavel Feldman.

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.get const):

10:11 Changeset [113730] by eae@chromium.org

Add missing methods and operators to FractionalLayoutUnit
https://bugs.webkit.org/show_bug.cgi?id=82403

Reviewed by Eric Seidel.

Add missing methods and operators and from branch version of
FractionalLayoutUnit. Also fix overflow assertion and add const keyword
to a couple of methods.

No new tests.

  • platform/FractionalLayoutUnit.h:

(WebCore::FractionalLayoutUnit::abs):
(FractionalLayoutUnit):
(WebCore::FractionalLayoutUnit::ceil):
(WebCore::FractionalLayoutUnit::round):
(WebCore::FractionalLayoutUnit::floor):
(WebCore::FractionalLayoutUnit::isInBounds):
(WebCore::operator<):
(WebCore):
(WebCore::operator-):

10:07 Changeset [113729] by zmo@google.com

2012-04-10 Zhenyao Mo <zmo@google.com>

Unreviewed, roll chromium to 131469

  • DEPS:
10:04 Changeset [113728] by jer.noble@apple.com

WebAudio: propagate a silence hint through the AudioNode graph.
https://bugs.webkit.org/show_bug.cgi?id=74553

Reviewed by Chris Rogers.

No new tests; optimization of existing code path, so covered by existing tests.

Introduce the concept of a "silent" channel:

  • platform/audio/AudioChannel.h:

(WebCore::AudioChannel::AudioChannel):
(WebCore::AudioChannel::set): Clear silent bit.
(WebCore::AudioChannel::zero): Set silent bit.
(WebCore::AudioChannel::clearSilentFlag): Clear silent bit.
(WebCore::AudioChannel::isSilent): Accessor.

Optimize a few channel operations when the source or destination channels are silent.

  • platform/audio/AudioChannel.cpp:

(WebCore::AudioChannel::scale): No-op on a silent channel.
(WebCore::AudioChannel::copyFrom): zero() when source is silent.
(WebCore::AudioChannel::copyFromRange): possibly zero() when source is silent.
(WebCore::AudioChannel::sumFrom): No-op when source is silent.
(WebCore::AudioChannel::maxAbsValue): 0 on a silent channel.

Optimize a few bus operations when the source or destination channels are silent.

  • platform/audio/AudioBus.cpp:

(WebCore::AudioBus::processWithGainFromMonoStereo): No-op if source is silent and either

the destination bus is silent, or the output is not summed to the destination.

(WebCore::AudioBus::copyWithSampleAccurateGainValuesFrom): zero() if the source is silent

and the lengths of the gain values, source, and destination match.

(WebCore::AudioBus::createBySampleRateConverting): Return an empty bus if the source is silent.
(WebCore::AudioBus::createByMixingToMono): Ditto; clear the destination's silent bit otherwise.
(WebCore::AudioBus::isSilent): Return whether all channels are silent.
(WebCore::AudioBus::clearSilentFlag): Clear silent bit of constituent channels.

  • platform/audio/AudioBus.h:

Make sure that classes which generate audio clear their busses' silent bit.

  • webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::process): Ditto.
(WebCore::AudioBufferSourceNode::renderFromBuffer): Ditto.
(WebCore::AudioBufferSourceNode::propagatesSilence): Propagate silence only when the source node

has nothing left to render.

  • webaudio/AudioBufferSourceNode.h:

(WebCore::AudioBufferSourceNode::playbackState): Made const correct.
(WebCore::AudioBufferSourceNode::isPlaying): Added simple accessor.
(WebCore::AudioBufferSourceNode::hasFinished): Ditto.

  • webaudio/AudioDestinationNode.h:

(WebCore::AudioDestinationNode::currentSampleFrame): Made const correct.
(WebCore::AudioDestinationNode::currentTime): Ditto.

Audio nodes should not process audio data when the input is silent and the nodes will propagate silences.

  • webaudio/AudioNode.cpp:

(WebCore::AudioNode::processIfNecessary):
(WebCore::AudioNode::inputsAreSilent): Convenience function which walk over the node's inputs.
(WebCore::AudioNode::silenceOutputs): Ditto.
(WebCore::AudioNode::unsilenceOutputs): Ditto.

  • webaudio/AudioNode.h:

(WebCore::AudioNode::propagatesSilence):

These Nodes can generate audio when given silent input, so return false from propagatesSilence.

  • Modules/webaudio/Oscillator.h:

(WebCore::Oscillator::propagatesSilence): Added.

09:40 Changeset [113727] by apavlov@chromium.org

[Chromium] Unreviewed, add baselines for fast/dom/shadow/selection-in-shadow.html

  • platform/chromium/fast/dom/shadow/selection-in-shadow-expected.txt: Added.
09:36 Changeset [113726] by fpizlo@apple.com

It should be possible to see why a code block was not compiled by the DFG
https://bugs.webkit.org/show_bug.cgi?id=83553

Reviewed by Geoff Garen.

If DFG_ENABLE(DEBUG_VERBOSE) and a code block is rejected, then print the
opcode that caused the rejection.

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::debugFail):
(DFG):
(JSC::DFG::canHandleOpcodes):

09:29 Changeset [113725] by zandobersek@gmail.com

Unreviewed - adding myself as a committer.

09:22 Changeset [113724] by commit-queue@webkit.org

[EFL][DRT] Catch the "title,changed" signal
https://bugs.webkit.org/show_bug.cgi?id=82174

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-04-10
Reviewed by Gustavo Noronha Silva.

Tools:

EFL's DumpRenderTree now catches the "title,changed" signal, and
prints out the needed information.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::onTitleChanged):

LayoutTests:

Unskip tests which requires EFL's DumpRenderTree to catch the
"title,changed" signal and print out information, now that it
is implemented.

  • platform/efl/Skipped:
09:19 Changeset [113723] by yi.4.shen@nokia.com

Pressing enter on blank line after bullet deletes entire bulleted line.
https://bugs.webkit.org/show_bug.cgi?id=82690

Reviewed by Enrica Casucci.

In CompositeEditCommand::breakOutOfEmptyListItem(), it checks the empty list item's renderer's siblings
to decide which empty part of the list should be removed. However, if the empty list item's renderer is
wrapped by an anonymous block, e.g. <ul><li>hello</li><br></ul>, the check may fail. So, we use isListItem
on the empty list node's siblings instead.

Source/WebCore:

No new tests : added new test case in the existing test (break-out-of-empty-list-item.html)

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::breakOutOfEmptyListItem):

LayoutTests:

  • editing/execCommand/break-out-of-empty-list-item-expected.txt:
  • editing/execCommand/script-tests/break-out-of-empty-list-item.js:
09:15 Changeset [113722] by commit-queue@webkit.org

[EFL] DRT should support LayoutTestController's willSendRequestReturnsNull()
https://bugs.webkit.org/show_bug.cgi?id=82443

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-04-10
Reviewed by Philippe Normand.

Tools:

EFL's DRT needs to support LayoutTestController's
willSendRequestReturnsNull() and return NULL when expected. This
allows for several tests to be removed from the skip list.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::onWillSendRequest):

LayoutTests:

Unskip tests which depend on EFL's DumpRenderTree support for
LayoutTestController's willSendRequestReturnsNull(), now that it is
implemented.

  • platform/efl/Skipped:
08:50 Changeset [113721] by apavlov@chromium.org

Web Inspector: Inspect Element - Edit as HTML - scrolling bug
https://bugs.webkit.org/show_bug.cgi?id=83563

mousedown in the scrollbar focuses the Elements tree outline container DIV element,
so the corresponding mousedown event should be consumed in the AT_TARGET phase.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype._startEditingAsHTML.consume):
(WebInspector.ElementsTreeElement.prototype._startEditingAsHTML.dispose):
(WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):

08:42 WebKit Team edited by pdr@google.com
Adding my team to the committers wiki page. (diff)
08:36 Changeset [113720] by commit-queue@webkit.org

[Qt][WK2] Assertion failure on loading new page after panning/zooming
https://bugs.webkit.org/show_bug.cgi?id=83049

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-04-10
Reviewed by Kenneth Rohde Christiansen.

When handling contents size change, set the visible content rectangle immediately,
instead of animating to it.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::itemSizeChanged):

08:35 Changeset [113719] by commit-queue@webkit.org

[EFL] LayoutTestController needs implementation of addUserStyleSheet
https://bugs.webkit.org/show_bug.cgi?id=82446

Source/WebKit/efl:

Add missing implementation addUserStyleSheet to EFL's
DumpRenderTreeSupport.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-10
Reviewed by Antonio Gomes.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::addUserStyleSheet):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Adding missing implementation addUserStyleSheet to EFL's LayoutTestController
so that we can unskip related tests from the skip list.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-10
Reviewed by Antonio Gomes.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::addUserStyleSheet): Implemented.

LayoutTests:

Unskipping the following test cases:
userscripts/mixed-case-stylesheet.html
userscripts/user-style-all-frames.html
userscripts/simple-stylesheet.html
userscripts/script-run-at-end.html

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-10
Reviewed by Antonio Gomes.

  • platform/efl/Skipped:
08:33 Changeset [113718] by pdr@google.com

Adding myself to committers.py!

Unreviewed update to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
08:33 Changeset [113717] by ossy@webkit.org

[Qt][WK2] Unreviewed gardening, skip a test to try to paint the bot greener.

  • platform/qt-5.0-wk2/Skipped:
08:32 Changeset [113716] by commit-queue@webkit.org

Remove the unused function WebCore::toIconIndex
https://bugs.webkit.org/show_bug.cgi?id=83037

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-04-10
Reviewed by Kentaro Hara.

  • WebCore.order:
  • dom/IconURL.cpp:
  • dom/IconURL.h:

(WebCore):

08:25 Changeset [113715] by commit-queue@webkit.org

[Qt][WK2] Title in MiniBrowser is not updated for a page with no title
https://bugs.webkit.org/show_bug.cgi?id=82483

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-04-10
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

titleChanged signal is not emitted on comitting a new load.

  • UIProcess/API/qt/tests/html/basic_page.html:
  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView):
(tst_QQuickWebView::titleUpdate):

  • UIProcess/qt/QtWebPageLoadClient.cpp:

(QtWebPageLoadClient::didCommitLoadForFrame):

Tools:

Set window title to default if there is no page title.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::onTitleChanged):

  • MiniBrowser/qt/BrowserWindow.h:

(BrowserWindow):

08:14 Changeset [113714] by jesus@webkit.org

[Qt][WK2] Implement PageClient::isViewWindowActive()
https://bugs.webkit.org/show_bug.cgi?id=81143

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

This patch implements PageClient::isViewWindowActive()
now that QQuickCanvas::isActive() is available (from QWindow).

  • UIProcess/qt/QtPageClient.cpp:

(QtPageClient::isViewWindowActive):

Tools:

Fix the WrapperWindow from our PlatformWebView
so it correctly creates the platform related
stuff for QWindow, which is not created unless
QWindow::setVisible() or QWindow::show() are called.

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::PlatformWebView):

07:42 Changeset [113713] by ossy@webkit.org

[Wk2] Gradening. Skip failing test.
https://bugs.webkit.org/show_bug.cgi?id=83581

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-04-10
Reviewed by Csaba Osztrogonác.

  • platform/wk2/Skipped:
06:52 Changeset [113712] by ossy@webkit.org

[Qt] Unreviewed gardening. Skip a failing, a timeouting and a crashing test to paint the bots green.

  • platform/qt-5.0-wk2/Skipped:
05:53 Changeset [113711] by pfeldman@chromium.org

Web Inspector: make error a string on the front-end side, not an object.
https://bugs.webkit.org/show_bug.cgi?id=83570

Reviewed by Yury Semikhatsky.

Source/WebCore:

We already expect it to be a string in all the code, we never use the error code in it.

  • inspector/front-end/InspectorBackend.js:

(InspectorBackendClass.prototype.dispatch):

LayoutTests:

  • inspector/debugger/debugger-set-breakpoint-regex-expected.txt:
  • inspector/debugger/debugger-set-breakpoint-regex.html:
  • inspector/elements/resolve-node-blocked-expected.txt:
  • inspector/elements/set-attribute.html:
  • inspector/profiler/heap-snapshot-inspect-dom-wrapper-expected.txt:
  • inspector/report-protocol-errors-expected.txt:
  • inspector/report-protocol-errors.html:
  • inspector/styles/set-property-boundaries-expected.txt:
05:34 Changeset [113710] by rwlbuis@webkit.org

getElementsByTagName unable to find SVG camelCase elements imported into HTML
https://bugs.webkit.org/show_bug.cgi?id=46800

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Implement getElementsByTagName according to the algorithm in
http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#concept-getelementsbytagname.
If the owner document of the element is html, the new class HTMLTagNodeList deals with
finding the match(es) based on this algorithm. If the owner document is non HTML, the existing
TagNodeList is used.

Implement getElementsByTagNameNS according to the algorithm in
http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#concept-getelementsbytagnamens.
The existing TagNodeList implements this algorithm.

Cached results may have less hits after this change. Tag names that are equal when case
insensitive but different when case sensitive can't share the result due to above algorithms, i.e.
they would match differently in the non html part of the document.

Tests: fast/dom/getElementsByTagName-localName-matching.html

fast/dom/getElementsByTagName-localName-matching2.xhtml
svg/dom/getElementsByTagName-localName-matching.html

  • dom/Node.cpp:

(WebCore::Node::getElementsByTagName): create TagNodeList depending on owner document type.
(WebCore::Node::getElementsByTagNameNS): do not lowercase localName for html.

  • dom/TagNodeList.cpp:

(WebCore::HTMLTagNodeList::HTMLTagNodeList): add specialized TagNodeList for html matching rules.
(WebCore):
(WebCore::HTMLTagNodeList::nodeMatches):

  • dom/TagNodeList.h:

(TagNodeList):
(HTMLTagNodeList):
(WebCore::HTMLTagNodeList::create):

LayoutTests:

Add tests for getElementsByTagName(NS) in html, xhtml, and svg documents.

  • fast/dom/getElementsByTagName-localName-matching-expected.txt: Added.
  • fast/dom/getElementsByTagName-localName-matching.html: Added.
  • fast/dom/getElementsByTagName-localName-matching2-expected.txt: Added.
  • fast/dom/getElementsByTagName-localName-matching2.xhtml: Added.
  • svg/dom/getElementsByTagName-localName-matching-expected.txt: Added.
  • svg/dom/getElementsByTagName-localName-matching.html: Added.
  • svg/dom/script-tests/getElementsByTagName-localName-matching.js: Added.
05:29 Changeset [113709] by apavlov@chromium.org

Web Inspector: [Device Metrics] Introduce the "Fit window" option
https://bugs.webkit.org/show_bug.cgi?id=83280

Source/WebCore:

This change adds the "Fit window" option to the Settings pane of Web Inspector, which lets users
resize the FrameView to fit the WebViewImpl size. When the user resizes the browser window
in the device metrics override mode with the option enabled, the FrameView follows
to match WebViewImpl by at least one dimension.

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/Inspector.json:
  • inspector/InspectorClient.h:

(WebCore::InspectorClient::overrideDeviceMetrics):
(WebCore::InspectorClient::autoZoomPageToFitWidth):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::shouldApplyScreenWidthOverrideImpl):
(WebCore):
(WebCore::InspectorInstrumentation::shouldApplyScreenHeightOverrideImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::shouldApplyScreenWidthOverride):
(WebCore):
(WebCore::InspectorInstrumentation::shouldApplyScreenHeightOverride):

  • inspector/InspectorPageAgent.cpp:

(PageAgentState):
(WebCore::InspectorPageAgent::restore):
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::setDeviceMetricsOverride):
(WebCore::InspectorPageAgent::updateViewMetrics):

  • inspector/InspectorPageAgent.h:
  • inspector/front-end/Settings.js:
  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen.prototype._createDeviceMetricsElement):

  • inspector/front-end/UserAgentSupport.js:
  • inspector/front-end/helpScreen.css:

(.help-content input[type=checkbox]):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::innerHeight):
(WebCore::DOMWindow::innerWidth):

Source/WebKit/chromium:

Implement the scaling of the FrameView to the WebViewImpl size, handle WebViewImpl resizes.

Reviewed by Pavel Feldman.

  • src/InspectorClientImpl.cpp:

(WebKit::InspectorClientImpl::overrideDeviceMetrics):

  • src/InspectorClientImpl.h:

(InspectorClientImpl):

  • src/WebDevToolsAgentImpl.cpp:

(WebKit::DeviceMetricsSupport::DeviceMetricsSupport):
(WebKit::DeviceMetricsSupport::setDeviceMetrics):
(WebKit::DeviceMetricsSupport::autoZoomPageToFitWidthOnNavigation):
(DeviceMetricsSupport):
(WebKit::DeviceMetricsSupport::autoZoomPageToFitWidth):
(WebKit::DeviceMetricsSupport::webViewResized):
(WebKit::DeviceMetricsSupport::applySizeOverrideIfNecessary):
(WebKit::DeviceMetricsSupport::ensureOriginalZoomFactor):
(WebKit::DeviceMetricsSupport::restore):
(WebKit::DeviceMetricsSupport::scaledEmulatedFrameSize):
(WebKit::DeviceMetricsSupport::forcedScrollbarDimensions):
(WebKit::DeviceMetricsSupport::applySizeOverrideInternal):
(WebKit::WebDevToolsAgentImpl::webViewResized):
(WebKit):
(WebKit::WebDevToolsAgentImpl::overrideDeviceMetrics):
(WebKit::WebDevToolsAgentImpl::autoZoomPageToFitWidth):

  • src/WebDevToolsAgentImpl.h:

(WebDevToolsAgentImpl):

  • src/WebDevToolsAgentPrivate.h:

(WebDevToolsAgentPrivate):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::resize):

LayoutTests:

Update the test to follow the protocol change and test the "Fit window" parameter.

Reviewed by Pavel Feldman.

  • inspector/styles/override-screen-size-expected.txt:
  • inspector/styles/override-screen-size.html:
04:34 Changeset [113708] by loislo@chromium.org

Web Inspector: use maxJSObjectId that is provided by back-end.
https://bugs.webkit.org/show_bug.cgi?id=82451

Summary view can filter objects in snapshot. It uses maxJSObjectId for this.
There was no such field in the profile header at the
moment but I've landed a patch in downstream.

Reviewed by Yury Semikhatsky.

  • bindings/js/ScriptHeapSnapshot.h:

(WebCore):
(WebCore::ScriptHeapSnapshot::maxSnapshotJSObjectId):

  • bindings/v8/ScriptHeapSnapshot.cpp:

(WebCore::ScriptHeapSnapshot::maxSnapshotJSObjectId):
(WebCore):

  • bindings/v8/ScriptHeapSnapshot.h:

(WebCore):
(ScriptHeapSnapshot):

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::createSnapshotHeader):

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.HeapSnapshotConstructorsDataGrid):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._filterSelectIndexChanged):
(WebInspector.DetailedHeapshotView.prototype._changeFilter):

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype.updateStaticData):

  • inspector/front-end/HeapSnapshotProxy.js:
04:26 Changeset [113707] by pfeldman@chromium.org

Web Inspector: annotate front-end for newer closure compiler.
https://bugs.webkit.org/show_bug.cgi?id=83478

Reviewed by Yury Semikhatsky.

This change mostly adds annotations to bound functions and !!bool expressions.
As a result, it makes closure compiler v20120305 happy.

  • inspector/Inspector.json:
  • inspector/front-end/BreakpointManager.js:
  • inspector/front-end/CSSStyleModel.js:
  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype.evalInInspectedWindow.evalCallback):
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode.prototype.removeAttribute):
(WebInspector.DOMAgent.prototype.pushNodeToFrontend):

  • inspector/front-end/DebuggerModel.js:
  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):

  • inspector/front-end/ElementsPanel.js:
  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):

  • inspector/front-end/ObjectPropertiesSection.js:
  • inspector/front-end/RemoteObject.js:
  • inspector/front-end/Resource.js:

(WebInspector.ResourceDomainModelBinding.prototype.canSetContent):

  • inspector/front-end/ResourceUtils.js:
  • inspector/front-end/ScopeChainSidebarPane.js:
  • inspector/front-end/Script.js:

(WebInspector.Script.prototype.editSource):

  • inspector/front-end/ScriptFormatter.js:

(WebInspector.ScriptFormatter.prototype.get _worker):

  • inspector/front-end/WorkerManager.js:
04:26 Changeset [113706] by kkristof@inf.u-szeged.hu

[Qt] Gardening after r113701.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-04-10
Reviewed by Csaba Osztrogonác.

  • platform/wk2/Skipped:
04:14 PrefixedAPIs edited by hans@chromium.org
add spec links for speech and speech input (diff)
03:56 Changeset [113705] by philn@webkit.org

Unreviewed, skip a failing test and rebaseline another one after r113611.

  • platform/gtk/Skipped:
  • platform/gtk/scrollbars/scrollbars-on-positioned-content-expected.txt:
03:55 PrefixedAPIs edited by tonyg@chromium.org
(diff)
03:38 Changeset [113704] by gyuyoung.kim@samsung.com

[EFL] Unreviewed. Gardening Add 19 missing expectations.

  • platform/efl/Skipped:
  • platform/efl/http/tests/loading/simple-subframe-expected.txt: Added.
  • platform/efl/http/tests/local/file-url-sent-as-referer-expected.txt: Added.
  • platform/efl/http/tests/misc/acid2-expected.txt: Added.
  • platform/efl/http/tests/misc/error404-expected.txt: Added.
  • platform/efl/http/tests/misc/favicon-as-image-expected.txt: Added.
  • platform/efl/http/tests/misc/frame-access-during-load-expected.txt: Added.
  • platform/efl/http/tests/misc/generated-content-inside-table-expected.txt: Added.
  • platform/efl/http/tests/misc/iframe404-expected.txt: Added.
  • platform/efl/http/tests/misc/location-replace-crossdomain-expected.txt: Added.
  • platform/efl/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt: Added.
  • platform/efl/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
  • platform/efl/http/tests/misc/slow-loading-image-in-pattern-expected.txt: Added.
  • platform/efl/http/tests/navigation/error404-basic-expected.txt: Added.
  • platform/efl/http/tests/navigation/error404-goback-expected.txt: Added.
  • platform/efl/http/tests/navigation/error404-subframeload-expected.txt: Added.
  • platform/efl/http/tests/navigation/javascriptlink-frames-expected.txt: Added.
  • platform/efl/http/tests/navigation/postredirect-basic-expected.txt: Added.
  • platform/efl/http/tests/navigation/postredirect-goback1-expected.txt: Added.
  • platform/efl/http/tests/uri/css-href-expected.txt: Added.
03:10 Changeset [113703] by kbalazs@webkit.org

[Qt][WK2] TestNetscapePlugin is broken
https://bugs.webkit.org/show_bug.cgi?id=83024

Reviewed by Csaba Osztrogonác.

Tools:

  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:

Fix X11 availability check. embedded is always true with QPA.

  • Tools.pro:

Build the test plugin if plugins are enabled for WebKit2.

  • qmake/mkspecs/features/features.prf:
  • qmake/mkspecs/features/functions.prf:

Added a convenience function to determine availability
of X11 libraries.

LayoutTests:

Remove plugins from skiplist and put the rest
of failing tests to their group.

  • platform/qt-5.0-wk2/Skipped:
02:52 Changeset [113702] by paroga@webkit.org

[WIN] Fix build without precompiled header.

  • DumpRenderTree/cg/ImageDiffCG.cpp: Define max as max as we do for min.
02:30 Changeset [113701] by ossy@webkit.org

[Qt] Gardening. Skip failing tests because of missing DnD support and ENABLE(SHADOW_DOM) is disabled.
[WK2] Skip tests because of missing layoutTestController.setAlwaysAcceptCookies().

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-04-10
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
  • platform/wk2/Skipped:
02:20 Changeset [113700] by pfeldman@chromium.org

Web Inspector: searching document with no documentElement results in 0x0 access.
https://bugs.webkit.org/show_bug.cgi?id=83483

Reviewed by Yury Semikhatsky.

Source/WebCore:

Added the null check.

Test: inspector/elements/dom-search-crash.html

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::performSearch):

LayoutTests:

  • inspector/elements/dom-search-crash-expected.txt: Added.
  • inspector/elements/dom-search-crash.html: Added.
  • inspector/elements/resources/dom-search-crash-iframe.html: Added.
02:13 Changeset [113699] by pfeldman@chromium.org

Merge 113585 - Web Inspector: [network panel] type column shows "undefined" instead of "(Pending)" upon load.
https://bugs.webkit.org/show_bug.cgi?id=83470

Reviewed by Yury Semikhatsky.

isPingRequest is tested for as a field, not a function return value.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkDataGridNode.prototype._refreshTypeCell):

TBR=pfeldman@chromium.org
BUG=122639
Review URL: https://chromiumcodereview.appspot.com/10031030

01:15 Changeset [113698] by philn@webkit.org

Unreviewed, GTK baselines for two new tests.

  • platform/gtk/fast/events/drop-with-file-paths-expected.txt: Added.
  • platform/gtk/media/nodesFromRect-shadowContent-expected.txt: Added.
00:40 Changeset [113697] by carlosgc@webkit.org

[WK2][GTK] FullScreen signals
https://bugs.webkit.org/show_bug.cgi?id=76166

Reviewed by Gustavo Noronha Silva.

  • GNUmakefile.am: Add new files to compilation.
  • UIProcess/API/C/gtk/WKFullScreenClientGtk.cpp:

(WKViewSetFullScreenClientGtk): Initialize WebKitWebViewBase
fullscreen client.

  • UIProcess/API/C/gtk/WKFullScreenClientGtk.h:
  • UIProcess/API/gtk/WebKitFullscreenClient.cpp: Added.

(willEnterFullScreen): Call webkitWebViewEnterFullScreen().
(willExitFullScreen): Call webkitWebViewLeaveFullScreen().
(attachFullScreenClientToView): Initialize FullScreenClient adding
implementations for willEnterFullScreen and willExitFullScreen callbacks.

  • UIProcess/API/gtk/WebKitFullscreenClient.h: Added.
  • UIProcess/API/gtk/WebKitPrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewConstructed): Attach fullscreen client to view.
(webkit_web_view_class_init): Add WebKitWebView::enter-fullscreen
and WebKitWebView::leave-fullscreen signals.
(webkitWebViewEnterFullScreen): Emit
WebKitWebView::enter-fullscreen signal.
(webkitWebViewLeaveFullScreen): Emit
WebKitWebView::leave-fullscreen signal.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseKeyPressEvent): Only return early when leaving
fullscreen, otherwise let the view process the key pressed.
(webkitWebViewBaseEnterFullScreen): Return early if
willEnterFullScreen callback is handled and returns false.
(webkitWebViewBaseExitFullScreen): Return early if
willExitFullScreen callback is handled and returns false.
(webkitWebViewBaseInitializeFullScreenClient): Initialize the
fullscreen client.

  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
  • UIProcess/API/gtk/WebKitWebViewPrivate.h:
  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewFullScreen):
(beforeAll):

  • UIProcess/API/gtk/tests/WebViewTest.cpp:

(WebViewTest::keyStroke): Helper function to synthesize key
press/release events.

  • UIProcess/API/gtk/tests/WebViewTest.h:
  • UIProcess/API/gtk/webkit2marshal.list:
  • UIProcess/gtk/WebFullScreenClientGtk.cpp:

(WebKit::WebFullScreenClientGtk::willEnterFullScreen): Call
willEnterFullScreen callback if defined.
(WebKit::WebFullScreenClientGtk::willExitFullScreen): Call
willExitFullScreen callback if defined.

  • UIProcess/gtk/WebFullScreenClientGtk.h:
00:38 Changeset [113696] by paroga@webkit.org

[CMake] Add missing source files to build system

Source/WebCore:

  • CMakeLists.txt:

Source/WebKit2:

  • CMakeLists.txt:
00:29 Changeset [113695] by haraken@chromium.org

Unreviewed. Fixed AppleWin and Chromium-win build failure.

Renamed 'exceptionNameDescription' to per-file variable name to avoid
name conflict.

  • Modules/indexeddb/IDBDatabaseException.cpp:

(WebCore::IDBDatabaseException::initializeDescription):

  • Modules/webdatabase/SQLException.cpp:

(WebCore::SQLException::initializeDescription):

  • dom/EventException.cpp:

(WebCore::EventException::initializeDescription):

  • dom/RangeException.cpp:

(WebCore::RangeException::initializeDescription):

  • fileapi/FileException.cpp:

(WebCore::FileException::initializeDescription):

  • fileapi/OperationNotAllowedException.cpp:

(WebCore::OperationNotAllowedException::initializeDescription):

  • svg/SVGException.cpp:

(WebCore::SVGException::initializeDescription):

  • xml/XPathException.cpp:

(WebCore::XPathException::initializeDescription):

00:18 Changeset [113694] by arko@motorola.com

Unreviewed: adding myself to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
00:11 Changeset [113693] by haraken@chromium.org

Unreviewed. Fixed AppleWin and Chromium-win build failure.

Renamed 'exceptions' to 'exceptionNameDescription' to avoid
variable name conflict.

  • Modules/indexeddb/IDBDatabaseException.cpp:

(WebCore::IDBDatabaseException::initializeDescription):

  • Modules/webdatabase/SQLException.cpp:

(WebCore::SQLException::initializeDescription):

  • dom/EventException.cpp:

(WebCore::EventException::initializeDescription):

  • dom/RangeException.cpp:

(WebCore::RangeException::initializeDescription):

  • fileapi/FileException.cpp:

(WebCore::FileException::initializeDescription):

  • fileapi/OperationNotAllowedException.cpp:

(WebCore::OperationNotAllowedException::initializeDescription):

  • svg/SVGException.cpp:

(WebCore::SVGException::initializeDescription):

  • xml/XPathException.cpp:

(WebCore::XPathException::initializeDescription):

00:05 Changeset [113692] by philn@webkit.org

Unreviewed, GTK rebaseline.

  • platform/gtk/editing/pasteboard/interchange-newline-2-expected.txt:
  • platform/gtk/editing/selection/editable-html-element-expected.txt:
  • platform/gtk/fast/overflow/hidden-scrollbar-resize-expected.txt:
  • platform/gtk/fast/repaint/overflow-outline-repaint-expected.txt:
  • platform/gtk/http/tests/xmlhttprequest/send-array-buffer-expected.txt:
  • platform/gtk/http/tests/xmlhttprequest/send-undefined-and-null-expected.txt:

04/09/12:

23:33 Changeset [113691] by kaustubh@motorola.com

Unreviewed: adding myself to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
23:24 Changeset [113690] by commit-queue@webkit.org

combine two arrays in XPathException into one
https://bugs.webkit.org/show_bug.cgi?id=83442

Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-04-09
Reviewed by Kentaro Hara.

No new tests required.

  • xml/XPathException.cpp:

(XPathExceptionNameDescription):
(WebCore):
(WebCore::XPathException::initializeDescription):

23:18 Changeset [113689] by commit-queue@webkit.org

combine exceptionNames and exceptionDescriptions in IDBDatabaseException.cpp into one array
https://bugs.webkit.org/show_bug.cgi?id=83433

Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-04-09
Reviewed by Kentaro Hara.

No new tests required.

  • Modules/indexeddb/IDBDatabaseException.cpp:

(IDBDatabaseExceptionNameDescription):
(WebCore):
(WebCore::IDBDatabaseException::initializeDescription):

23:07 Changeset [113688] by tkent@chromium.org

[Chromium] Remove unused variable, WebViewImpl::m_lastMousePosition.
https://bugs.webkit.org/show_bug.cgi?id=83550

Reviewed by Kentaro Hara.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::mouseMove):

  • src/WebViewImpl.h:
22:54 Changeset [113687] by commit-queue@webkit.org

combine two arrays in SQLException.cpp into one
https://bugs.webkit.org/show_bug.cgi?id=83452

Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-04-09
Reviewed by Kentaro Hara.

No new tests required.

  • Modules/webdatabase/SQLException.cpp:

(SQLExceptionNameDescription):
(WebCore):
(WebCore::SQLException::initializeDescription):

22:51 Changeset [113686] by commit-queue@webkit.org

combine two arrays in EventException.cpp into one
https://bugs.webkit.org/show_bug.cgi?id=83451

Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-04-09
Reviewed by Kentaro Hara.

No new tests required.

  • dom/EventException.cpp:

(EventExceptionNameDescription):
(WebCore):
(WebCore::EventException::initializeDescription):

22:50 Changeset [113685] by commit-queue@webkit.org

combine two arrays in RangeException.cpp into one
https://bugs.webkit.org/show_bug.cgi?id=83450

Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-04-09
Reviewed by Kentaro Hara.

No new tests required.

  • dom/RangeException.cpp:

(RangeExceptionNameDescription):
(WebCore):
(WebCore::RangeException::initializeDescription):

22:47 Changeset [113684] by noam.rosenthal@nokia.com

[Texmap] Improve TextureMapperGL readability
https://bugs.webkit.org/show_bug.cgi?id=83477

Change the debugging macros for TextureMapperGL, so that the GL_CMD call can include a semicolon.
Modify some if blocks to have an early return.

Reviewed by Martin Robinson.

No new functionality.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGLData::SharedGLData::scissorClip):
(WebCore::TextureMapperGLData::SharedGLData::applyCurrentClip):
(WebCore::TextureMapperGLData::SharedGLData::~SharedGLData):
(WebCore::TextureMapperGLData::initializeStencil):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::TextureMapperGL::endPainting):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::BitmapTextureGL::didReset):
(WebCore::BitmapTextureGL::updateContents):
(WebCore::BitmapTextureGL::initializeStencil):
(WebCore::BitmapTextureGL::bind):
(WebCore::BitmapTextureGL::~BitmapTextureGL):
(WebCore::TextureMapperGL::bindSurface):
(WebCore::TextureMapperGL::beginClip):

22:45 Changeset [113683] by commit-queue@webkit.org

combine two arrays in FileException.cpp into one
https://bugs.webkit.org/show_bug.cgi?id=83449

Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-04-09
Reviewed by Kentaro Hara.

No new tests required.

  • fileapi/FileException.cpp:

(FileExceptionNameDescription):
(WebCore):
(WebCore::FileException::initializeDescription):

22:43 Changeset [113682] by commit-queue@webkit.org

combine two arrays in OperationNotAllowedException.cpp into one
https://bugs.webkit.org/show_bug.cgi?id=83445

Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-04-09
Reviewed by Kentaro Hara.

No new tests required.

  • fileapi/OperationNotAllowedException.cpp:

(OperationNotAllowedExceptionNameDescription):
(WebCore):
(WebCore::OperationNotAllowedException::initializeDescription):

22:39 Changeset [113681] by shinyak@chromium.org

Assert triggers VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries.
https://bugs.webkit.org/show_bug.cgi?id=83118

Reviewed by Hajime Morita.

Source/WebCore:

VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries did not work correctly.
There was a case that selection crosses shadow boundaries.

This patch introduces a class TreeScopeAdjuster, which enables us to adjust Node or Position
into a specified tree scope.

Test: fast/dom/shadow/selections-in-shadow.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.ext.in:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/TreeScope.h:

(TreeScope):

  • dom/TreeScopeAdjuster.cpp: Added.

(WebCore):
(WebCore::TreeScopeAdjuster::TreeScopeAdjuster):
(WebCore::TreeScopeAdjuster::ancestorInThisScope):

Returns the node itself if it's in the same tree scope.
Otherwise, this method checks the shadow ancestor of the node recursively.
If no corresponding node is found, 0 will be returned.

(WebCore::TreeScopeAdjuster::adjustPositionBefore):
(WebCore::TreeScopeAdjuster::adjustPositionAfter):

  • dom/TreeScopeAdjuster.h: Added.

(WebCore):
(TreeScopeAdjuster):
(WebCore::TreeScopeAdjuster::treeScope):

  • editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries):

LayoutTests:

This tests checks all the combination of element not in a shadow tree, element in a shadow tree,
element in a nested shadow tree, element in a non-youngest shadow tree, element in a nested shadow tree
in non-youngest shadow treee.

  • fast/dom/resources/event-sender-util.js: Added.

(mouseMoveToElem):

  • fast/dom/shadow/selections-in-shadow-expected.txt: Added.
  • fast/dom/shadow/selections-in-shadow.html: Added.
22:36 Changeset [113680] by commit-queue@webkit.org

combine two arrays in SVGException.cpp into one
https://bugs.webkit.org/show_bug.cgi?id=83444

Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-04-09
Reviewed by Kentaro Hara.

No new tests required.

  • svg/SVGException.cpp:

(SVGExceptionNameDescription):
(WebCore):
(WebCore::SVGException::initializeDescription):

22:30 Changeset [113679] by commit-queue@webkit.org

combine two arrays in XMLHttpRequestException.cpp into one
https://bugs.webkit.org/show_bug.cgi?id=83443

Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-04-09
Reviewed by Kentaro Hara.

No new tests requied.

  • xml/XMLHttpRequestException.cpp:

(XMLHttpRequestExceptionNameDescription):
(WebCore):
(WebCore::XMLHttpRequestException::initializeDescription):

21:57 Changeset [113678] by noam.rosenthal@nokia.com

[WK2] Enable using a single ShareableBitmap for multiple updates
https://bugs.webkit.org/show_bug.cgi?id=83424

Source/WebCore:

Modify BitmapTexture::updateContents to include a source offset.
This allows us to update a texture from a sub-image.

Reviewed by Kenneth Rohde Christiansen.

Tested by existing API tests.

  • platform/graphics/texmap/TextureMapper.h:

(BitmapTexture):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::didReset):
(WebCore::driverSupportsBGRASwizzling):
(WebCore::BitmapTextureGL::updateContents):

  • platform/graphics/texmap/TextureMapperGL.h:

(WebCore::BitmapTextureGL::textureTarget):
(BitmapTextureGL):

  • platform/graphics/texmap/TextureMapperImageBuffer.cpp:

(WebCore::BitmapTextureImageBuffer::updateContents):

  • platform/graphics/texmap/TextureMapperImageBuffer.h:

(BitmapTextureImageBuffer):

Source/WebKit2:

Reviewed by Kenneth Rohde Christiansen.

Enabled creating a GraphicsContext that references a rect inside ShareableBitmap.
Added bitmapOffset to UpdateInfo, to allow updates to reference an offset inside the bitmap.
Added UpdateAtlas, a class that manages available rects in a larger ShareableBitmap.

In this iteration, UpdateAtlas has a simple behavior where a rect inside the bitmap is
either available or used. When the buffers are swapped, all used buffers become available
again. A future enhancement might allow triple-buffering, where available rects can be
updated while other rects from the same atlas are in use.

Added the necessary plumbing to allow Qt's UI-side compositing to take advantage of
UpdateAtlas. LayerTreeHostQt creates an atlas per type of bitmap (i.e. one opaque and one
alpha-enabled atlas). When a tile wants to update and there's no available scratch-buffer,
the update would be postponed to the next frame, creating a tiling-artifact in low memory
situations.

  • Shared/UpdateInfo.cpp:

(WebKit::UpdateInfo::encode):
(WebKit::UpdateInfo::decode):

  • Shared/UpdateInfo.h:

(UpdateInfo):

  • Target.pri:
  • UIProcess/LayerTreeHostProxy.cpp:

(WebKit::LayerTreeHostProxy::updateTileForLayer):

  • UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::WebLayerTreeRenderer::syncLayerParameters):
(WebKit::WebLayerTreeRenderer::updateTile):
(WebKit::WebLayerTreeRenderer::createImage):

  • UIProcess/WebLayerTreeRenderer.h:

(TileUpdate):
(WebKit::WebLayerTreeRenderer::TileUpdate::TileUpdate):
(WebLayerTreeRenderer):

  • UIProcess/qt/LayerBackingStore.cpp:

(WebKit::LayerBackingStoreTile::swapBuffers):
(WebKit::LayerBackingStoreTile::setBackBuffer):
(WebKit::LayerBackingStore::createTile):

  • UIProcess/qt/LayerBackingStore.h:

(LayerBackingStoreTile):
(LayerBackingStore):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::tiledBackingStoreBackgroundColor):
(WebCore::WebGraphicsLayer::beginContentUpdate):
(WebCore):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:

(WebGraphicsLayerClient):
(WebGraphicsLayer):

  • WebProcess/WebPage/TiledBackingStoreRemoteTile.cpp:

(WebKit::TiledBackingStoreRemoteTile::updateBackBuffer):

  • WebProcess/WebPage/TiledBackingStoreRemoteTile.h:

(TiledBackingStoreRemoteTileClient):

  • WebProcess/WebPage/UpdateAtlas.cpp: Added.

(WebKit):
(WebKit::UpdateAtlas::UpdateAtlas):
(WebKit::nextPowerOfTwo):
(WebKit::UpdateAtlas::buildLayoutIfNeeded):
(WebKit::UpdateAtlas::findAvailableIndex):
(WebKit::UpdateAtlas::didSwapBuffers):
(WebKit::UpdateAtlas::acquireScratchBuffer):
(WebKit::UpdateAtlas::offsetForIndex):

  • WebProcess/WebPage/UpdateAtlas.h: Added.

(WebCore):
(WebKit):
(UpdateAtlas):
(WebKit::UpdateAtlas::bitmap):
(WebKit::UpdateAtlas::size):
(WebKit::UpdateAtlas::flags):

  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::adoptImageBackingStore):
(WebKit::LayerTreeHostQt::renderNextFrame):
(WebKit::LayerTreeHostQt::purgeBackingStores):
(WebKit):
(WebKit::LayerTreeHostQt::getAtlas):
(WebKit::LayerTreeHostQt::beginContentUpdate):

  • WebProcess/WebPage/qt/LayerTreeHostQt.h:

(LayerTreeHostQt):

21:54 Changeset [113677] by danakj@chromium.org

[chromium] Viewport is not filled when out of texture memory on mac
https://bugs.webkit.org/show_bug.cgi?id=83351

Reviewed by Adrienne Walker.

Source/Platform:

  • chromium/public/WebLayerTreeView.h:

(WebLayerTreeView):

Source/WebCore:

Currently we add gutter quads on the NonCompositedContentHost layer,
which lies above another visible layer - the rubberband layer on mac.
For this reason, on mac, gutter quads were disabled, as well as forcing
the NCCH layer to draw, in order to make the rubberband layer appear.

We move the logic for adding gutter quads into CCRenderPass, and add
gutter quads for all pixels that are visible through the viewport.
This allows us to stop special-casing the NCCH layer, and allows us
to skip drawing the layer equally with other layers. We remove the
backgroundCoversViewport() flag entirely.

In order to do this, we fix a bug in the occlusion tracker, that
allowed opaque() layers with skipsDraw to occlude, by making
the visibleContentOpaqueRegion() method on the layer classes
also return the opaque region for non-tiled layers, always use
its value in the occlusion tracker.

Unit test: CCLayerTreeHostImplTest.viewportCovered

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::pushPropertiesTo):
(WebCore::LayerChromium::visibleContentOpaqueRegion):
(WebCore):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::visibleContentOpaqueRegion):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::visibleContentOpaqueRegion):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::appendQuads):
(CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeHost::setBackgroundColor):
(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore::CCLayerTreeHostImpl::backgroundColor):
(WebCore::CCLayerTreeHostImpl::setBackgroundColor):
(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::computeOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):

  • platform/graphics/chromium/cc/CCOcclusionTracker.h:

(CCOcclusionTrackerBase):
(WebCore::CCOcclusionTrackerBase::computeVisibleRegionInScreen):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::appendQuadsToFillScreen):
(WebCore):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(WebCore):
(CCRenderPass):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::appendQuads):
(WebCore::CCTiledLayerImpl::visibleContentOpaqueRegion):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:

(WebCore::CCTiledLayerImpl::skipsDraw):
(CCTiledLayerImpl):

Source/WebKit/chromium:

  • src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setBackgroundColor):

  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::setBackgroundColor):
(WebKit):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setBackgroundColor):
(WebKit):
(WebKit::WebViewImplContentPainter::paint):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • src/WebViewImpl.h:

(WebCore):
(WebViewImpl):

  • tests/CCLayerImplTest.cpp:

(WebCore::TEST):

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKitTests::BlendStateCheckLayer::appendQuads):
(WebKitTests::TEST_F):
(WebKitTests):

  • tests/CCLayerTreeHostTest.cpp:

(WTF):
(CCLayerTreeHostTestCommit):
(WTF::CCLayerTreeHostTestCommit::CCLayerTreeHostTestCommit):
(WTF::CCLayerTreeHostTestCommit::beginTest):
(WTF::CCLayerTreeHostTestCommit::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestCommit::afterTest):
(WTF::TEST_F):
(TestLayerChromium):

  • tests/CCOcclusionTrackerTest.cpp:

(WebKitTests::TestContentLayerChromium::TestContentLayerChromium):
(WebKitTests::TestContentLayerChromium::visibleContentOpaqueRegion):
(WebKitTests::TestContentLayerChromium::setOpaqueContentsRect):
(TestContentLayerChromium):
(WebKitTests::TestContentLayerImpl::TestContentLayerImpl):
(TestContentLayerImpl):
(WebKitTests::TestContentLayerImpl::visibleContentOpaqueRegion):
(WebKitTests::TestContentLayerImpl::setOpaqueContentsRect):

  • tests/CCTiledLayerImplTest.cpp:
  • tests/LayerChromiumTest.cpp:
21:47 Changeset [113676] by macpherson@chromium.org

Don't let CSSPropertyWebkitPerspective dereference primitiveValue without null check.
https://bugs.webkit.org/show_bug.cgi?id=83538

Reviewed by Daniel Bates.

No new tests / code cleanup only.

Coverity pointed out that we potentially dereference primitiveValue here without checking for null.
I've added an early out for that case to make sure it can't ever happen. I don't know if it's actually
possible to exercise that code path or not - probably the parser prevents it from being hit in practice.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

21:42 Changeset [113675] by commit-queue@webkit.org

<http://webkit.org/b/83539> Web Inspector: ASSERT attempting to unbind null contentDocument

Avoid calling unbind with a null object. The HTMLFrameOwnerElement's
contentDocument can be null.

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-04-09
Reviewed by Timothy Hatcher.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::unbind):

21:27 Changeset [113674] by commit-queue@webkit.org

[BlackBerry] Parsed Cookie's m_isMaxAgeSet is not needed.
https://bugs.webkit.org/show_bug.cgi?id=83457

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-09
Reviewed by Rob Buis.

When m_expiry is not -1, it must be set by setExpiry or setMaxAge. setExpiry will return when m_expiry
has been set. This ensures Max-Age's precedence.
And m_isMaxAgeSet is always false when the cookie is from database. This is not right.

So we use m_expiry instead of m_isMaxAgeSet.

No new tests. Refactor.

  • platform/blackberry/ParsedCookie.cpp:

(WebCore::ParsedCookie::ParsedCookie):
(WebCore::ParsedCookie::setExpiry):
(WebCore::ParsedCookie::setMaxAge):

  • platform/blackberry/ParsedCookie.h:

(ParsedCookie):

21:05 Changeset [113673] by commit-queue@webkit.org

Fixed ordering of deleting CCInputHandler and CCLayerTreeHostImpl in layerTreeHostClosedOnImplThread
https://bugs.webkit.org/show_bug.cgi?id=83488

Patch by Min Qin <qinmin@google.com> on 2012-04-09
Reviewed by James Robinson.

CCInputHandler(WebCompositorInputHandlerImpl) has a pointer to CCLayerTreeHostImpl.
So we should delete CCInputHandler earlier as otherwise that pointer could get misused after LayerTreeHostImpl is deleted.
Just fixing a potential NPE error, no behavior change.

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::layerTreeHostClosedOnImplThread):

20:59 Changeset [113672] by efidler@rim.com

[BlackBerry] Update about:config page
https://bugs.webkit.org/show_bug.cgi?id=83515

Reviewed by Rob Buis.

  • WebCoreSupport/AboutData.cpp:

(WebCore::configPage):

  • WebCoreSupport/AboutDataEnableFeatures.in:
  • WebCoreSupport/AboutDataHaveFeatures.in:
  • WebCoreSupport/AboutDataUseFeatures.in:
20:46 Changeset [113671] by commit-queue@webkit.org

Unreviewed, rolling out r113656.
http://trac.webkit.org/changeset/113656
https://bugs.webkit.org/show_bug.cgi?id=83542

test is broken on chromium-win (Requested by simonjam on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-09

Source/WebCore:

  • Modules/intents/Intent.cpp:

(WebCore::Intent::Intent):

  • Modules/intents/Intent.h:

(Intent):

  • Modules/intents/Intent.idl:
  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateParametersCheck):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

Source/WebKit/chromium:

  • public/WebIntent.h:

(WebIntent):

  • src/WebIntent.cpp:

Tools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::dispatchIntent):

LayoutTests:

  • webintents/web-intents-invoke-port-expected.txt: Removed.
  • webintents/web-intents-invoke-port.html: Removed.
20:41 Changeset [113670] by inferno@chromium.org

ASSERTION FAILED: !attached() in Node::attach.
https://bugs.webkit.org/show_bug.cgi?id=80726

Reviewed by Adam Barth.

Source/WebCore:

While parsing XML document, prevent attaching the leaf text node
back to document, if its parent is not attached.

Test: fast/dom/text-node-attach-crash.xhtml

  • xml/parser/XMLDocumentParser.cpp:

(WebCore::XMLDocumentParser::exitText):

LayoutTests:

  • fast/dom/text-node-attach-crash-expected.txt: Added.
  • fast/dom/text-node-attach-crash.xhtml: Added.
20:39 Changeset [113669] by simonjam@chromium.org

[Chromium] Unreviewed gardening.

  • platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.txt: Added.
  • platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
20:11 Changeset [113668] by danakj@chromium.org

[chromium] Replica layers are not drawn, so should not be painted
https://bugs.webkit.org/show_bug.cgi?id=83504

Reviewed by James Robinson.

We attempt to paint replica layers when we are painting the mask layers
in CCLayerTreeHost.cpp.

This is useless code, replica layers have drawsContent() == false, and
have an empty visibleLayerRect, so the paint functions end up early-
outting. But it is a waste of time to try, and confusing to have
this attempted in the code at all, since the replica layers are never
drawn. They exist only for their transforms.

Also the dimensions used for the replica mask are different from the
surface mask, which is confusing and unnecessary as well. The mask is
applied to the same surface contents as the surface mask would be, so
only the surface's contentBounds need to be painted in the replica
mask.

Covered by existing tests.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintMasksForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
20:05 Changeset [113667] by shinyak@chromium.org

ShadowRoot should have selection attribute.
https://bugs.webkit.org/show_bug.cgi?id=82429

Reviewed by Hajime Morita.

Source/WebCore:

This patch makes ShadowRoot have selection attribute. Currently the selection returns
the same object as what window.getSelection() returns.

We will extend DOMSelection to have TreeScope. It will adjust Node into TreeScope.
This will be tracked in Bug 82698.

Test: fast/dom/shadow/selection-in-shadow.html

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::selection):
(WebCore):

  • dom/ShadowRoot.h:

(WebCore):
(ShadowRoot):

  • dom/ShadowRoot.idl:

LayoutTests:

Checks ShadowRoot.selection returns the same selection as what window.getSelection() returns.

  • fast/dom/shadow/selection-in-shadow.html: Added.
20:02 Changeset [113666] by rakuco@webkit.org

[EFL] Gardening in fast/text/whitespace.

The last commit to these baselines had some weird fonts for some
reason, fix the expected sizes.

  • platform/efl/fast/text/whitespace/002-expected.png:
  • platform/efl/fast/text/whitespace/002-expected.txt:
  • platform/efl/fast/text/whitespace/003-expected.png:
  • platform/efl/fast/text/whitespace/003-expected.txt:
  • platform/efl/fast/text/whitespace/004-expected.png:
  • platform/efl/fast/text/whitespace/004-expected.txt:
  • platform/efl/fast/text/whitespace/005-expected.png:
  • platform/efl/fast/text/whitespace/005-expected.txt:
  • platform/efl/fast/text/whitespace/006-expected.png:
  • platform/efl/fast/text/whitespace/006-expected.txt:
  • platform/efl/fast/text/whitespace/007-expected.png:
  • platform/efl/fast/text/whitespace/007-expected.txt:
  • platform/efl/fast/text/whitespace/008-expected.png:
  • platform/efl/fast/text/whitespace/008-expected.txt:
  • platform/efl/fast/text/whitespace/009-expected.png:
  • platform/efl/fast/text/whitespace/009-expected.txt:
  • platform/efl/fast/text/whitespace/010-expected.png:
  • platform/efl/fast/text/whitespace/010-expected.txt:
  • platform/efl/fast/text/whitespace/011-expected.png:
  • platform/efl/fast/text/whitespace/011-expected.txt:
  • platform/efl/fast/text/whitespace/012-expected.png:
  • platform/efl/fast/text/whitespace/012-expected.txt:
  • platform/efl/fast/text/whitespace/013-expected.png:
  • platform/efl/fast/text/whitespace/013-expected.txt:
  • platform/efl/fast/text/whitespace/014-expected.png:
  • platform/efl/fast/text/whitespace/014-expected.txt:
  • platform/efl/fast/text/whitespace/015-expected.png:
  • platform/efl/fast/text/whitespace/015-expected.txt:
  • platform/efl/fast/text/whitespace/016-expected.png:
  • platform/efl/fast/text/whitespace/016-expected.txt:
  • platform/efl/fast/text/whitespace/018-expected.png:
  • platform/efl/fast/text/whitespace/018-expected.txt:
  • platform/efl/fast/text/whitespace/020-expected.png:
  • platform/efl/fast/text/whitespace/020-expected.txt:
  • platform/efl/fast/text/whitespace/021-expected.png:
  • platform/efl/fast/text/whitespace/021-expected.txt:
  • platform/efl/fast/text/whitespace/025-expected.png:
  • platform/efl/fast/text/whitespace/025-expected.txt:
  • platform/efl/fast/text/whitespace/027-expected.png:
  • platform/efl/fast/text/whitespace/027-expected.txt:
  • platform/efl/fast/text/whitespace/030-expected.png:
  • platform/efl/fast/text/whitespace/030-expected.txt:
  • platform/efl/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
  • platform/efl/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
  • platform/efl/fast/text/whitespace/pre-break-word-expected.png:
  • platform/efl/fast/text/whitespace/pre-break-word-expected.txt:
  • platform/efl/fast/text/whitespace/pre-wrap-last-char-expected.png:
  • platform/efl/fast/text/whitespace/pre-wrap-last-char-expected.txt:
  • platform/efl/fast/text/whitespace/pre-wrap-line-test-expected.png:
  • platform/efl/fast/text/whitespace/pre-wrap-line-test-expected.txt:
  • platform/efl/fast/text/whitespace/pre-wrap-overflow-selection-expected.png:
  • platform/efl/fast/text/whitespace/pre-wrap-overflow-selection-expected.txt:
  • platform/efl/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png:
  • platform/efl/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
19:54 Changeset [113665] by eae@chromium.org

Replace numeric_limits<LayoutUnit>::min/max with constants
https://bugs.webkit.org/show_bug.cgi?id=83497

Reviewed by Eric Seidel.

Replace all uses of numeric_limits<LayoutUnit>::min/max with
MIN_LAYOUT_UNIT and MAX_LAYOUT_UNIT respectively in preparation for the
switch to subpixel layout.

Also rename zeroLayoutUnit to ZERO_LAYOUT_UNIT to be consistent and
change it to be a define as to avoid global initializer warnings once we
change the definition of LayoutUnit from int to FractionalLayoutUnit.

No new tests, no change in functionality.

  • dom/ElementRareData.h:

(WebCore::defaultMinimumSizeForResizing):

  • editing/FrameSelection.cpp:

(WebCore::NoXPosForVerticalArrowNavigation):

  • platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::clampEdgeValue):
(WebCore::TransformationMatrix::clampedBoundsOfProjectedQuad):

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::computePreferredLogicalWidths):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::addBorderOutsetVisualOverflow):
(WebCore::InlineFlowBox::paintFillLayer):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):
(WebCore::InlineFlowBox::computeOverAnnotationAdjustment):

  • rendering/LayoutTypes.h:

(WebCore):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::computeInitialRegionRangeForBlock):
(WebCore::RenderBlock::adjustFloatingBlock):
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
(WebCore::RenderBlock::markLinesDirtyInBlockRange):
(WebCore::RenderBlock::clearFloats):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::getClearDelta):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
(WebCore::getHeightForLineCount):
(WebCore::RenderBlock::borderFitAdjust):
(WebCore::RenderBlock::adjustForUnsplittableChild):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::paginationStrut):
(WebCore::RenderBlock::pageLogicalOffset):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineLayoutState::updateRepaintRangeFromBox):
(WebCore::RenderBlock::checkFloatsInCleanLine):
(WebCore::RenderBlock::addOverflowFromInlineChildren):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats):
(WebCore::RenderBox::positionForPoint):

  • rendering/RenderBox.h:

(WebCore::RenderBox::minYVisualOverflow):
(WebCore::RenderBox::minXVisualOverflow):
(RenderBox):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::offsetLeft):
(WebCore::RenderBoxModelObject::offsetTop):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
(WebCore::RenderDeprecatedFlexibleBox::allowedChildFlex):

  • rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::paintBoxDecorations):
(WebCore::RenderFieldset::paintMask):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::repositionLogicalHeightDependentFlexItems):
(WebCore::RenderFlexibleBox::lineBreakLength):
(WebCore::RenderFlexibleBox::alignChildren):
(WebCore::RenderFlexibleBox::applyStretchAlignmentToChild):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::computeLogicalWidth):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::linesVisualOverflowBoundingBox):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::resize):

  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::updateMargins):

  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::computePosition):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::repaintAfterLayoutIfNeeded):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::computePreferredLogicalWidths):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
(WebCore::RenderTable::layout):

  • rendering/RenderTable.h:

(WebCore::RenderTable::bordersPaddingAndSpacingInRowDirection):

  • rendering/RenderText.cpp:

(WebCore::RenderText::linesVisualOverflowBoundingBox):

19:50 Changeset [113664] by rakuco@webkit.org

[EFL] Gardening in transforms/2d.

Mostly account for the changes caused by the jhbuild and font
commits.

  • platform/efl/transforms/2d/compound-transforms-vs-containers-expected.png:
  • platform/efl/transforms/2d/hindi-rotated-expected.png:
  • platform/efl/transforms/2d/transform-borderbox-expected.png:
  • platform/efl/transforms/2d/transform-fixed-container-expected.png:
  • platform/efl/transforms/2d/transform-origin-borderbox-expected.png:
19:32 Changeset [113663] by leviw@chromium.org

Clean up LayoutUnit usage in DOMNodeHighlighter
https://bugs.webkit.org/show_bug.cgi?id=83507

Reviewed by Eric Seidel.

Ensuring DOMNodeHighlighter uses pixel snapping that matches that done in the RenderTree. Changes include:

  • Reverting drawSubstring to use an IntPoint with pixel snapped values instead of a LayoutPoint.
  • Reverting borderBox to an IntRect since it's in absolute coordinates. See https://trac.webkit.org/wiki/LayoutUnit.
  • Frames are still laid out with integers. Cleaning up mainFrameOffset to reflect that.

No new tests. No change in behavior.

  • inspector/DOMNodeHighlighter.cpp:
19:26 Changeset [113662] by commit-queue@webkit.org

Add missing IndexedDB files to CMake build
https://bugs.webkit.org/show_bug.cgi?id=83495

Patch by Jeff Rogers <jrogers@rim.com> on 2012-04-09
Reviewed by Rob Buis.

  • CMakeLists.txt:
  • UseJSC.cmake:
19:13 Changeset [113661] by bdakin@apple.com

https://bugs.webkit.org/show_bug.cgi?id=83411

All Mac bots occasionally fail tons of media/ sputnik/ and svg/ tests

This is a speculative fix.

  • platform/mac/Skipped:
19:12 Changeset [113660] by barraclough@apple.com

If a callback constructor returns a C++ null, throw a type error.
https://bugs.webkit.org/show_bug.cgi?id=83537

Rubber Stamped by Geoff Garen.

  • API/JSCallbackConstructor.cpp:

(JSC::constructJSCallback):

  • If a callback constructor returns a C++ null, throw a type error.
  • API/tests/testapi.c:

(Base_returnHardNull):

  • API/tests/testapi.js:
    • Add a test case for callback constructors that return a C++ null.
19:06 Changeset [113659] by ap@apple.com

[Mac] WebProcess dies due to m_process->checkURLReceivedFromWebProcess(url) dropping a file URL
https://bugs.webkit.org/show_bug.cgi?id=83506
<rdar://problem/11171264>

Reviewed by Darin Adler.

Cannot test, because dragging within a single window never initiates a navigation, and dragging
across windows is too much for DRT and WTR.

  • platform/mac/DragDataMac.mm: (WebCore::DragData::asURL): Add the same checks that we had

for NSURLPboardType to NSStringPboardType case, preventing dropping of non-HTTP URLs.
String types cannot be sanitized when they are modified by JavaScript, and are thus less trusted.
String checks should be at least as restrictive as URL ones.

19:05 Changeset [113658] by jamesr@google.com

[chromium] More unreviewed OwnPtr<>::operator= related clang build fixes in unit tests.

  • tests/Canvas2DLayerChromiumTest.cpp:
  • tests/LayerChromiumTest.cpp:
18:53 Changeset [113657] by paroga@webkit.org

Port BinarySemaphoreWin.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=83502

Reviewed by Daniel Bates.

Replace WaitForSingleObjectEx with WaitForSingleObject since
the additonal parameter supported by the extended function
is not used anyway and the function does not exist on WinCE.

  • wtf/CMakeLists.txt:
  • wtf/PlatformWinCE.cmake:
  • wtf/threads/win/BinarySemaphoreWin.cpp:

(WTF::BinarySemaphore::wait):

18:46 Changeset [113656] by commit-queue@webkit.org

Add transfer map argument to Intent constructor
http://dvcs.w3.org/hg/web-intents/raw-file/tip/spec/Overview.html
This adds the ability to pass transferables (i.e. MessagePorts)
through web intents, and puts the calling convention in line
with the Web Messaging spec:
http://dev.w3.org/html5/postmsg/

Implementation in chromium API follows the port-passing method
of PlatformMessagePortChannel.

https://bugs.webkit.org/show_bug.cgi?id=80200

Patch by Greg Billock <gbillock@google.com> on 2012-04-09
Reviewed by Adam Barth.

  • Modules/intents/Intent.cpp:

(WebCore::Intent::create):

  • Modules/intents/Intent.idl:
  • WebCore.gypi:
  • bindings/v8/custom/V8IntentCustom.cpp: Added.

(WebCore):
(WebCore::V8Intent::constructorCallback):

18:44 Changeset [113655] by toyoshim@chromium.org

Update pywebsocket to 0.7.4.
https://bugs.webkit.org/show_bug.cgi?id=83461

Reviewed by Kent Tamura.

This version supports TLS by using ssl in addition to pyOpenSSL.
Other functional difrerences from 0.7.2 are:

  • strict Sec-WebSocket-Key validation conforming RFC 4648
  • compression ratio logging in debug
  • Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook._install_pywebsocket):

18:41 Changeset [113654] by barraclough@apple.com

If a callback function returns a C++ null, convert to undefined.
https://bugs.webkit.org/show_bug.cgi?id=83534

Reviewed by Geoff Garen.

  • API/JSCallbackFunction.cpp:
    • If a callback function returns a C++ null, convert to undefined.

(JSC::JSCallbackFunction::call):

  • API/tests/testapi.c:

(Base_returnHardNull):

  • API/tests/testapi.js:
    • Add a test case for callback functions that return a C++ null.
18:30 Changeset [113653] by simonjam@chromium.org

[Chromium] Unreviewed gardening.

  • platform/chromium-linux/media/media-document-audio-repaint-expected.png:
  • platform/chromium-linux/media/media-document-audio-repaint-expected.txt: Added.
  • platform/chromium-linux/scrollbars/scrollbars-on-positioned-content-expected.png:
  • platform/chromium-mac-leopard/scrollbars/scrollbars-on-positioned-content-expected.png:
  • platform/chromium-mac-snowleopard/scrollbars/scrollbars-on-positioned-content-expected.png:
  • platform/chromium-mac/fast/forms/basic-textareas-expected.png:
  • platform/chromium-mac/fast/overflow/hidden-scrollbar-resize-expected.txt: Added.
  • platform/chromium-mac/scrollbars/scrollbars-on-positioned-content-expected.png:
  • platform/chromium-mac/scrollbars/scrollbars-on-positioned-content-expected.txt: Copied from LayoutTests/platform/chromium-win/scrollbars/scrollbars-on-positioned-content-expected.txt.
  • platform/chromium-win/fast/overflow/hidden-scrollbar-resize-expected.txt:
  • platform/chromium-win/scrollbars/scrollbars-on-positioned-content-expected.png:
  • platform/chromium-win/scrollbars/scrollbars-on-positioned-content-expected.txt:
18:23 Changeset [113652] by danakj@chromium.org

[chromium] Cull occluded surface quads
https://bugs.webkit.org/show_bug.cgi?id=81227

Reviewed by Adrienne Walker.

Source/WebCore:

Cull render surface and replica quads during draw based on occlusion.

In order to compute occlusion for the surface or replica, it must not
consider occlusion found in the surface's own subtree. To do this, we
reorder the calls to the occlusion tracker, and add the surface and
replica quads before we "leaveToTargetRenderSurface" which merges
occlusion from the surface's subtree up into its parent.

Unit test: CCOcclusionTrackerTestReplicaOccluded

CCOcclusionTrackerTestSurfaceWithReplicaUnoccluded
CCOcclusionTrackerTestSurfaceAndReplicaOccludedDifferently
CCOcclusionTrackerTestSurfaceChildOfSurface
CCOcclusionTrackerTestSurfaceChildOfClippingSurface

And added some sanity checks to other CCOcclusionTracker tests that have
render surfaces.

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::leaveToTargetRenderSurface):
(WebCore::::unoccludedContributingSurfaceContentRect):
(WebCore):

  • platform/graphics/chromium/cc/CCOcclusionTracker.h:

(CCOcclusionTrackerBase):

  • platform/graphics/chromium/cc/CCQuadCuller.cpp:

(WebCore::CCQuadCuller::CCQuadCuller):
(WebCore::appendQuadInternal):
(WebCore::CCQuadCuller::append):
(WebCore):
(WebCore::CCQuadCuller::appendSurface):
(WebCore::CCQuadCuller::appendReplica):

  • platform/graphics/chromium/cc/CCQuadCuller.h:

(CCQuadCuller):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::appendQuadsForRenderSurfaceLayer):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(CCRenderPass):

Source/WebKit/chromium:

  • tests/CCOcclusionTrackerTest.cpp:

(WebKitTests::CCOcclusionTrackerTest::TearDown):
(WebKitTests::CCOcclusionTrackerTest::createReplicaLayer):
(CCOcclusionTrackerTest):
(WebKitTests::CCOcclusionTrackerTest::setReplica):
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationTranslateOnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesWithClipping::runMyTest):
(WebKitTests):
(CCOcclusionTrackerTestReplicaOccluded):
(WebKitTests::CCOcclusionTrackerTestReplicaOccluded::runMyTest):
(CCOcclusionTrackerTestSurfaceWithReplicaUnoccluded):
(WebKitTests::CCOcclusionTrackerTestSurfaceWithReplicaUnoccluded::runMyTest):
(CCOcclusionTrackerTestSurfaceAndReplicaOccludedDifferently):
(WebKitTests::CCOcclusionTrackerTestSurfaceAndReplicaOccludedDifferently::runMyTest):
(CCOcclusionTrackerTestSurfaceChildOfSurface):
(WebKitTests::CCOcclusionTrackerTestSurfaceChildOfSurface::runMyTest):

18:19 Changeset [113651] by rniwa@webkit.org

Update perf-o-matic config.js per upstream change.

  • Websites/webkit-perf.appspot.com/js/config.js:

(var):

18:10 Changeset [113650] by jamesr@google.com

[chromium] Unreviewed build fix. OwnPtr<>::operator = breaks the build on clang, but not gcc :(

  • tests/CCLayerTreeHostTest.cpp:

(WTF::MockLayerTreeHost::create):

  • tests/Canvas2DLayerChromiumTest.cpp:
  • tests/LayerChromiumTest.cpp:
18:02 Changeset [113649] by bdakin@apple.com

<rdar://problem/11214796>

New WKSI will hopefully fix a common crash seen by the bots in libRIP.A.dylib:
symmetric_convolve

Reviewed by Simon Fraser.

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
18:00 Changeset [113648] by fpizlo@apple.com

Classic interpreter's GC hooks shouldn't attempt to scan instructions for code blocks that
are currently being generated
https://bugs.webkit.org/show_bug.cgi?id=83531
<rdar://problem/11215200>

Reviewed by Gavin Barraclough.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::stronglyVisitStrongReferences):

17:44 Changeset [113647] by kling@webkit.org

Make CSSValuePool share values globally.
<http://webkit.org/b/77700>

Reviewed by Antti Koivisto.

Remove the per-Document CSSValuePool and have everyone use a global pool
accessed via "CSSValuePool& cssValuePool()".

This reduces memory usage by sharing cached CSSValues between all documents,
and relaxes heap churn since the common, persistenly cached values are held
by CSSValuePool forever.

No behavior change thanks to r113588 which introduced a mechanism that makes
sure we never expose internal CSSValue objects to bindings, but read-only
clones of those values.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForNinePieceImageSlice):
(WebCore::valueForNinePieceImageQuad):
(WebCore::valueForNinePieceImageRepeat):
(WebCore::valueForNinePieceImage):
(WebCore::zoomAdjustedPixelValue):
(WebCore::zoomAdjustedNumberValue):
(WebCore::zoomAdjustedPixelValueForLength):
(WebCore::valueForReflection):
(WebCore::getPositionOffsetValue):
(WebCore::CSSComputedStyleDeclaration::currentColorOrValidColor):
(WebCore::getBorderRadiusCornerValues):
(WebCore::getBorderRadiusCornerValue):
(WebCore::getBorderRadiusShorthandValue):
(WebCore::computedTransform):
(WebCore::CSSComputedStyleDeclaration::valueForCustomFilterNumberParameter):
(WebCore::CSSComputedStyleDeclaration::valueForFilter):
(WebCore::valueForGridTrackBreadth):
(WebCore::valueForGridTrackList):
(WebCore::valueForGridPosition):
(WebCore::getDelayValue):
(WebCore::getDurationValue):
(WebCore::createLineBoxContainValue):
(WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword):
(WebCore::CSSComputedStyleDeclaration::valueForShadow):
(WebCore::valueForFamily):
(WebCore::renderUnicodeBidiFlagsToCSSValue):
(WebCore::renderTextDecorationFlagsToCSSValue):
(WebCore::fillRepeatToCSSValue):
(WebCore::fillSizeToCSSValue):
(WebCore::contentToCSSValue):
(WebCore::counterToCSSValue):
(WebCore::fontFamilyFromStyle):
(WebCore::lineHeightFromStyle):
(WebCore::fontSizeFromStyle):
(WebCore::fontStyleFromStyle):
(WebCore::fontVariantFromStyle):
(WebCore::fontWeightFromStyle):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSComputedStyleDeclaration.h:

(WebCore):

  • css/CSSParser.cpp:

(WebCore::parseColorValue):
(WebCore::parseSimpleLengthValue):
(WebCore::parseKeywordValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseColor):
(WebCore::CSSParser::setStyleSheet):
(WebCore::CSSParser::createPrimitiveNumericValue):
(WebCore::CSSParser::createPrimitiveStringValue):
(WebCore::CSSParser::parseValidPrimitive):
(WebCore::parseBackgroundClip):
(WebCore::CSSParser::parseFillShorthand):
(WebCore::CSSParser::parseAnimationShorthand):
(WebCore::CSSParser::parseTransitionShorthand):
(WebCore::CSSParser::parseShorthand):
(WebCore::CSSParser::parsePage):
(WebCore::CSSParser::parseSizeParameter):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseAttr):
(WebCore::CSSParser::parseBackgroundColor):
(WebCore::CSSParser::parseFillImage):
(WebCore::CSSParser::parseFillPositionX):
(WebCore::CSSParser::parseFillPositionY):
(WebCore::CSSParser::parseFillPositionComponent):
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillRepeat):
(WebCore::CSSParser::parseFillSize):
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::parseAnimationDirection):
(WebCore::CSSParser::parseAnimationFillMode):
(WebCore::CSSParser::parseAnimationIterationCount):
(WebCore::CSSParser::parseAnimationName):
(WebCore::CSSParser::parseAnimationPlayState):
(WebCore::CSSParser::parseAnimationProperty):
(WebCore::CSSParser::parseAnimationTimingFunction):
(WebCore::CSSParser::parseGridTrackList):
(WebCore::CSSParser::parseDashboardRegions):
(WebCore::CSSParser::parseCounterContent):
(WebCore::CSSParser::parseClipShape):
(WebCore::CSSParser::parseExclusionShape):
(WebCore::CSSParser::parseFont):
(WebCore::FontFamilyValueBuilder::FontFamilyValueBuilder):
(WebCore::FontFamilyValueBuilder::commit):
(FontFamilyValueBuilder):
(WebCore::CSSParser::parseFontFamily):
(WebCore::CSSParser::parseFontVariant):
(WebCore::CSSParser::parseFontWeight):
(WebCore::ShadowParseContext::commitStyle):
(WebCore::CSSParser::parseShadow):
(WebCore::CSSParser::parseReflect):
(WebCore::CSSParser::parseFlex):
(WebCore::BorderImageParseContext::commitBorderImageProperty):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseBorderImageRepeat):
(WebCore::BorderImageSliceParseContext::commitBorderImageSlice):
(WebCore::BorderImageQuadParseContext::commitNumber):
(WebCore::BorderImageQuadParseContext::commitBorderImageQuad):
(WebCore::CSSParser::parseBorderRadius):
(WebCore::CSSParser::parseAspectRatio):
(WebCore::CSSParser::parseCounter):
(WebCore::parseDeprecatedGradientPoint):
(WebCore::parseDeprecatedGradientColorStop):
(WebCore::CSSParser::parseDeprecatedGradient):
(WebCore::valueFromSideKeyword):
(WebCore::parseGradientColorOrKeyword):
(WebCore::CSSParser::parseLinearGradient):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::parseCrossfade):
(WebCore::CSSParser::parseImageSet):
(WebCore::CSSParser::parseCustomFilter):
(WebCore::CSSParser::parseBuiltinFilterArguments):
(WebCore::CSSParser::parseFilter):
(WebCore::CSSParser::parseFlowThread):
(WebCore::CSSParser::parseRegionThread):
(WebCore::CSSParser::parseTextEmphasisStyle):
(WebCore::CSSParser::parseFontFeatureSettings):
(WebCore::CSSParser::parseFontVariantLigatures):

  • css/CSSParser.h:

(WebCore):
(CSSParser):

  • css/CSSValuePool.cpp:

(WebCore::cssValuePool):
(WebCore):

  • css/CSSValuePool.h:

(CSSValuePool):
(WebCore):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::setProperty):

  • css/StylePropertySet.h:

(StylePropertySet):

  • dom/Document.cpp:
  • dom/Document.h:

(WebCore):
(Document):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::addPropertyToAttributeStyle):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::addHTMLColorToStyle):

  • html/HTMLFontElement.cpp:

(WebCore::HTMLFontElement::collectStyleForAttribute):

  • html/HTMLHRElement.cpp:

(WebCore::HTMLHRElement::collectStyleForAttribute):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::createSharedCellStyle):

17:20 Changeset [113646] by simonjam@chromium.org

[Chromium] Unreviewed, roll out rebaselines for feature that was rolled out.

  • platform/chromium-linux-x86/media/video-empty-source-expected.txt: Copied from LayoutTests/platform/chromium-win/media/video-empty-source-expected.txt.
  • platform/chromium-linux/media/video-empty-source-expected.txt: Copied from LayoutTests/platform/chromium-win/media/video-empty-source-expected.txt.
  • platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/media/video-empty-source-expected.txt: Copied from LayoutTests/platform/chromium-mac/media/video-empty-source-expected.txt.
  • platform/chromium-mac/fast/forms/basic-textareas-expected.txt:
  • platform/chromium-mac/fast/layers/video-layer-expected.txt:
  • platform/chromium-mac/media/audio-controls-rendering-expected.txt:
  • platform/chromium-mac/media/audio-repaint-expected.txt:
  • platform/chromium-mac/media/controls-after-reload-expected.txt:
  • platform/chromium-mac/media/controls-strict-expected.txt:
  • platform/chromium-mac/media/controls-styling-expected.txt:
  • platform/chromium-mac/media/controls-without-preload-expected.txt:
  • platform/chromium-mac/media/media-controls-clone-expected.txt:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-mac/media/video-controls-rendering-expected.txt:
  • platform/chromium-mac/media/video-display-toggle-expected.txt:
  • platform/chromium-mac/media/video-empty-source-expected.txt:
  • platform/chromium-mac/media/video-no-audio-expected.txt:
  • platform/chromium-mac/media/video-playing-and-pause-expected.txt:
  • platform/chromium-mac/media/video-volume-slider-expected.txt:
  • platform/chromium-mac/media/video-zoom-controls-expected.txt:
  • platform/chromium-win-vista/media/video-empty-source-expected.txt: Copied from LayoutTests/platform/chromium-win/media/video-empty-source-expected.txt.
  • platform/chromium-win/fast/layers/video-layer-expected.txt:
  • platform/chromium-win/media/audio-controls-rendering-expected.txt:
  • platform/chromium-win/media/audio-repaint-expected.txt:
  • platform/chromium-win/media/controls-after-reload-expected.txt:
  • platform/chromium-win/media/controls-strict-expected.txt:
  • platform/chromium-win/media/controls-styling-expected.txt:
  • platform/chromium-win/media/controls-without-preload-expected.txt:
  • platform/chromium-win/media/media-controls-clone-expected.txt:
  • platform/chromium-win/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-win/media/video-controls-rendering-expected.txt:
  • platform/chromium-win/media/video-display-toggle-expected.txt:
  • platform/chromium-win/media/video-empty-source-expected.txt:
  • platform/chromium-win/media/video-no-audio-expected.txt:
  • platform/chromium-win/media/video-playing-and-pause-expected.txt:
  • platform/chromium-win/media/video-volume-slider-expected.txt:
  • platform/chromium-win/media/video-zoom-controls-expected.txt:
17:03 Changeset [113645] by leviw@chromium.org

Prepare html classes for sub-pixel LayoutUnits
https://bugs.webkit.org/show_bug.cgi?id=83491

Reviewed by Eric Seidel.

This patch brings the entire HTML folder up to the current state of the subpixellayout branch. Adding
an intValue flavor of Length that maps to the current value function was also necessary to get us
there. See https://trac.webkit.org/wiki/LayoutUnit and the descriptions below for details.

No new tests. No change in behavior.

  • html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::scrollAmount): Fixes a compiler error when length returns a float, as
we intend it to do when switching to sub-pixel layout.

  • html/ImageDocument.cpp:

(WebCore::ImageDocumentParser::finish): imageSize is always integral.

  • platform/Length.h:

(WebCore::Length::Length): Added a constructor that takes a FractionalLayoutUnit.
(Length):
(WebCore::Length::intValue): Currently maps directly to Length::value, but the current logic of value
will be migrated here when value is changed to return a float.
(WebCore::Length::setValue): Added a variant that takes a FractionalLayoutUnit.

17:01 Changeset [113644] by commit-queue@webkit.org

[BlackBerry] requestAnimationFrame performance choppy & inconsistent
https://bugs.webkit.org/show_bug.cgi?id=83499

Patch by Andrew Lo <anlo@rim.com> on 2012-04-09
Reviewed by Rob Buis.

Respect m_scheduled & m_previousFrameDone flags like the Mac port of
DisplayRefreshMonitor does.
Internal PR: 147826

requestAnimationFrame already covered by tests in LayoutTests/fast/animation.

  • platform/graphics/blackberry/DisplayRefreshMonitorBlackBerry.cpp:

(WebCore::DisplayRefreshMonitor::displayLinkFired):

16:58 Changeset [113643] by macpherson@chromium.org

Make CSSValueID's into an enum instead of a collection of integers.
https://bugs.webkit.org/show_bug.cgi?id=83246

Reviewed by Simon Fraser.

This patch simply converts the list of integers into an enum.
Follow-up patches will then convert existing code that uses integers to use the new enum.

No new tests / no functionality changed.

  • css/makevalues.pl:
16:54 Changeset [113642] by fpizlo@apple.com

Unreviewed, modernize and clean up uses of ARM assembly mnemonics in inline asm blocks.

  • dfg/DFGOperations.cpp:

(JSC):

  • offlineasm/armv7.rb:
16:49 Changeset [113641] by commit-queue@webkit.org

Unreviewed, rolling out r113609.
http://trac.webkit.org/changeset/113609
https://bugs.webkit.org/show_bug.cgi?id=83522

it broke tests (Requested by dethbakin on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-09

Source/WebCore:

  • css/mediaControlsChromium.css:

(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):

  • css/mediaControlsQuickTime.css:

(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
(audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):

  • html/shadow/MediaControlElements.cpp:

(RenderMediaVolumeSliderContainer):
(WebCore):
(WebCore::RenderMediaVolumeSliderContainer::RenderMediaVolumeSliderContainer):
(WebCore::RenderMediaVolumeSliderContainer::layout):
(WebCore::MediaControlVolumeSliderContainerElement::createRenderer):

  • html/shadow/MediaControlElements.h:

(MediaControlVolumeSliderContainerElement):

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::create):

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::create):

LayoutTests:

  • media/video-controls-rendering-toggle-display-none-expected.txt: Removed.
  • media/video-controls-rendering-toggle-display-none.html: Removed.
16:45 Changeset [113640] by noam.rosenthal@nokia.com

[Qt][WK2] Sync the layer's state and the layer's children separately
https://bugs.webkit.org/show_bug.cgi?id=82534

Reviewed by Kenneth Rohde Christiansen.

Switched the WebLayerInfo struct, which includes a single layer's state,
to use only POD types that can be serialized via SimpleArgumentCoder.
To allow POD-serialization, we serialize the children IDs in a seperate
message (SetLayerChildren), and only when the tree layout has actually
been modified.

  • Shared/WebLayerTreeInfo.cpp:

(WebKit::WebLayerInfo::encode):
(WebKit::WebLayerInfo::decode):

  • Shared/WebLayerTreeInfo.h:

(WebKit::WebLayerInfo::WebLayerInfo):

  • UIProcess/LayerTreeHostProxy.cpp:

(WebKit::LayerTreeHostProxy::setCompositingLayerState):
(WebKit):
(WebKit::LayerTreeHostProxy::setCompositingLayerChildren):

  • UIProcess/LayerTreeHostProxy.h:

(LayerTreeHostProxy):

  • UIProcess/LayerTreeHostProxy.messages.in:
  • UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::WebLayerTreeRenderer::setLayerChildren):
(WebKit):
(WebKit::WebLayerTreeRenderer::setLayerState):

  • UIProcess/WebLayerTreeRenderer.h:

(WebLayerTreeRenderer):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::didChangeLayerState):
(WebCore):
(WebCore::WebGraphicsLayer::didChangeChildren):
(WebCore::WebGraphicsLayer::didChangeGeometry):
(WebCore::WebGraphicsLayer::WebGraphicsLayer):
(WebCore::WebGraphicsLayer::setChildren):
(WebCore::WebGraphicsLayer::addChild):
(WebCore::WebGraphicsLayer::addChildAtIndex):
(WebCore::WebGraphicsLayer::addChildAbove):
(WebCore::WebGraphicsLayer::addChildBelow):
(WebCore::WebGraphicsLayer::replaceChild):
(WebCore::WebGraphicsLayer::removeFromParent):
(WebCore::WebGraphicsLayer::setDrawsContent):
(WebCore::WebGraphicsLayer::setContentsOpaque):
(WebCore::WebGraphicsLayer::setBackfaceVisibility):
(WebCore::WebGraphicsLayer::setOpacity):
(WebCore::WebGraphicsLayer::setContentsRect):
(WebCore::WebGraphicsLayer::setContentsToImage):
(WebCore::WebGraphicsLayer::setMaskLayer):
(WebCore::WebGraphicsLayer::setReplicatedByLayer):
(WebCore::WebGraphicsLayer::setNeedsDisplayInRect):
(WebCore::WebGraphicsLayer::id):
(WebCore::WebGraphicsLayer::syncChildren):
(WebCore::WebGraphicsLayer::syncLayerState):
(WebCore::WebGraphicsLayer::syncImageBackingStore):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
(WebCore::WebGraphicsLayer::setRootLayer):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:

(WebGraphicsLayerClient):
(WebGraphicsLayer):

  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::syncLayerState):
(WebKit):
(WebKit::LayerTreeHostQt::syncLayerChildren):

  • WebProcess/WebPage/qt/LayerTreeHostQt.h:

(LayerTreeHostQt):

16:28 Changeset [113639] by dpranke@chromium.org

add a webkit-patch print-baselines command
https://bugs.webkit.org/show_bug.cgi?id=83348

Reviewed by Adam Barth.

This adds a simple 'print-baselines' command to webkit-patch
that can be used in one of two forms: to print where the
baselines for a given test (or set of tests) on a single port
will be found, or to generate a report for multiple ports.

Example of the former:

$ webkit-patch print-baselines fast/html/keygen.html
For mac-snowleopard
platform/mac/fast/html/keygen-expected.txt
platform/mac/fast/html/keygen-expected.png
$

The latter is most useful for finding out which fallback dirs are
used by which ports for which tests, for example,
'chromium-mac-leopard' uses 100 results from 'platform/mac/leopard'.
No example output is given because the reports are pretty wordy :).

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.baseline_extensions): Added.
(Port.expected_baseline_dict): Added.

  • Scripts/webkitpy/tool/commands/queries.py:

(PrintBaselines):
(PrintBaselines.init):
(PrintBaselines.execute):
(PrintBaselines._print_baselines):
(PrintBaselines._platform_for_path):

16:20 Changeset [113638] by fmalita@chromium.org

Unreviewed: adding myself to committers.py.

Patch by Florin Malita <fmalita@chromium.org> on 2012-04-09

  • Scripts/webkitpy/common/config/committers.py:
15:52 Changeset [113637] by danakj@chromium.org

[chromium] Make culling work with clipped rects
https://bugs.webkit.org/show_bug.cgi?id=83494

Reviewed by Adrienne Walker.

Source/WebCore:

Use new CCMathUtil transformation methods to deal with rects that clip
the camera plane. This fixes three things:

  1. A layer completely behind the camera is not visible and should not

occlude.

  1. A layer that is clipped by the camera is treated like a

non-axis-aligned transform, as the result of a mapClippedRect() is a
bounding box and may contain pixels not in the original rect. This guards
our use of mapRect() when transforming occluded regions.

  1. A layer's occlusion must be clipped by its scissor rect. This scissor

rect exists in its target space, so occlusion in screen space is only
possible if its target also is axis aligned in the screen, such that
the layer's scissor rect remains a rect in screen space.

Unit tests: CCOcclusionTrackerTestLayerBehindCameraDoesNotOcclude

CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect

  • platform/graphics/chromium/cc/CCMathUtil.cpp:

(WebCore::CCMathUtil::mapQuad):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::transformSurfaceOpaqueRegion):
(WebCore::computeOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):
(WebCore::testContentRectOccluded):
(WebCore::computeUnoccludedContentRect):

Source/WebKit/chromium:

  • tests/CCOcclusionTrackerTest.cpp:

(CCOcclusionTrackerTestLayerBehindCameraDoesNotOcclude):
(WebKitTests::CCOcclusionTrackerTestLayerBehindCameraDoesNotOcclude::runMyTest):
(WebKitTests):
(CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect):
(WebKitTests::CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect::runMyTest):

  • tests/CCQuadCullerTest.cpp:

(WebCore::TestCCOcclusionTrackerImpl::TestCCOcclusionTrackerImpl):
(WebCore::makeLayer):
(WebCore::TEST):

15:49 Changeset [113636] by commit-queue@webkit.org

Remove unworkable video-buffering-repaints-controls test.
https://bugs.webkit.org/show_bug.cgi?id=83097

.:

Replaces the automated test for progress bar repaints during buffering
with a manual test entry.

Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-04-09
Reviewed by Eric Carlson.

  • ManualTests/media-controls.html:

LayoutTests:

Test has been broken in one way or another for some time now. I've
approached multiple people about possible solutions, but nothing ends
up being stable.

After discussion with fischman and trying a couple more solutions
today, we decided the best course of action is to remove the test.

Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-04-09
Reviewed by Eric Carlson.

  • http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
  • http/tests/media/video-buffering-repaints-controls.html: Removed.
  • platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
  • platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
  • platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
  • platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
  • platform/chromium-mac/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
  • platform/chromium-win/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png: Removed.
  • platform/mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
  • platform/mac/Skipped:
  • platform/mac/test_expectations.txt:
15:44 Changeset [113635] by commit-queue@webkit.org

Unreviewed, rolling out r113613.
http://trac.webkit.org/changeset/113613
https://bugs.webkit.org/show_bug.cgi?id=83509

crashing most chromium bots (Requested by simonjam on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-09

Source/WebCore:

  • Modules/battery/BatteryController.cpp:
  • Modules/battery/BatteryController.h:

(BatteryController):

  • Modules/battery/BatteryManager.cpp:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:

Source/WebKit/chromium:

  • WebKit.gyp:
  • features.gypi:
  • public/WebBatteryStatus.h: Removed.
  • public/WebBatteryStatusClient.h: Removed.
  • public/WebView.h:

(WebKit):
(WebView):

  • public/WebViewClient.h:

(WebKit):

  • src/BatteryClientImpl.cpp: Removed.
  • src/BatteryClientImpl.h: Removed.
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

  • src/WebViewImpl.h:

(WebKit):
(WebViewImpl):

LayoutTests:

  • platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
  • platform/chromium/test_expectations.txt:
15:40 Changeset [113634] by zmo@google.com

bindAttribLocation should check webgl reserved prefix
https://bugs.webkit.org/show_bug.cgi?id=83409

Reviewed by Kenneth Russell.

Source/WebCore:

  • html/canvas/WebGLRenderingContext.cpp: Check for invalid parameters for a few functions.

(WebCore):
(WebCore::WebGLRenderingContext::bindAttribLocation):
(WebCore::WebGLRenderingContext::getAttribLocation):
(WebCore::WebGLRenderingContext::getUniformLocation):

LayoutTests:

  • fast/canvas/webgl/webgl-specific-expected.txt: Added webgl prefix test case for bindAttribLocation.
  • fast/canvas/webgl/webgl-specific.html:
15:40 Changeset [113633] by commit-queue@webkit.org

[BlackBerry] Allow simulator to use GLES2 acceleration
https://bugs.webkit.org/show_bug.cgi?id=81672

Patch by Ming Xie <mxie@rim.com> on 2012-04-09
Reviewed by Rob Buis.

.:

  • Source/cmake/OptionsBlackBerry.cmake:

Tools:

  • Scripts/webkitdirs.pm:

(blackberryCMakeArguments):

15:17 Changeset [113632] by simonjam@chromium.org

[Chromium] Unreviewed gardening fix.

  • platform/chromium/virtual/threaded/compositing/visibility/README.txt: Added.
15:14 Changeset [113631] by timothy@apple.com

Fix the assertion in PageScriptDebugServer::didPause.

https://webkit.org/b/82943

Reviewed by Simon Fraser.

  • bindings/js/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::PageScriptDebugServer): Initialize m_pausedPage
to zero so the assert in didPause will not randomly fire the first time.

15:06 PrefixedAPIs edited by ericu@chromium.org
(diff)
15:05 Changeset [113630] by lforschler@apple.com

Merged r113501.

15:00 Changeset [113629] by lforschler@apple.com

Merged r113523.

14:59 Changeset [113628] by noam.rosenthal@nokia.com

[Qt][WK2] Accelerated and non-accelerated animations need to be synchronized
https://bugs.webkit.org/show_bug.cgi?id=75780

Reviewed by Kenneth Rohde Christiansen.

Remove the ui-side animation code, and return false from addAnimation so that web-side
animations kick in.

  • Shared/WebLayerTreeInfo.cpp:

(WebKit):

  • Shared/WebLayerTreeInfo.h:

(WebLayerInfo):

  • UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::WebLayerTreeRenderer::paintToCurrentGLContext):
(WebKit::WebLayerTreeRenderer::setLayerState):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::didChangeGeometry):
(WebCore::WebGraphicsLayer::syncLayerState):
(WebCore::WebGraphicsLayer::computeTransformedVisibleRect):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:

(WebGraphicsLayer):

14:58 Changeset [113627] by lforschler@apple.com

Versioning.

14:58 Changeset [113626] by simonjam@chromium.org

[Chromium] Unreviewed gardening.

  • platform/chromium-linux-x86/media/video-empty-source-expected.txt: Removed.
  • platform/chromium-linux/media/media-document-audio-repaint-expected.png:
  • platform/chromium-linux/media/video-empty-source-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/forms/basic-textareas-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/forms/basic-textareas-expected.txt.
  • platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
  • platform/chromium-mac-snowleopard/media/video-empty-source-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/basic-textareas-expected.png:
  • platform/chromium-mac/fast/forms/basic-textareas-expected.txt:
  • platform/chromium-mac/fast/layers/video-layer-expected.txt:
  • platform/chromium-mac/media/audio-controls-rendering-expected.txt:
  • platform/chromium-mac/media/audio-repaint-expected.txt:
  • platform/chromium-mac/media/controls-after-reload-expected.txt:
  • platform/chromium-mac/media/controls-strict-expected.txt:
  • platform/chromium-mac/media/controls-styling-expected.txt:
  • platform/chromium-mac/media/controls-without-preload-expected.txt:
  • platform/chromium-mac/media/media-controls-clone-expected.txt:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-mac/media/video-controls-rendering-expected.txt:
  • platform/chromium-mac/media/video-display-toggle-expected.txt:
  • platform/chromium-mac/media/video-empty-source-expected.txt:
  • platform/chromium-mac/media/video-no-audio-expected.txt:
  • platform/chromium-mac/media/video-playing-and-pause-expected.txt:
  • platform/chromium-mac/media/video-volume-slider-expected.txt:
  • platform/chromium-mac/media/video-zoom-controls-expected.txt:
  • platform/chromium-win-vista/media/video-empty-source-expected.txt: Removed.
  • platform/chromium-win/fast/layers/video-layer-expected.txt:
  • platform/chromium-win/media/audio-controls-rendering-expected.txt:
  • platform/chromium-win/media/audio-repaint-expected.txt:
  • platform/chromium-win/media/controls-after-reload-expected.txt:
  • platform/chromium-win/media/controls-strict-expected.txt:
  • platform/chromium-win/media/controls-styling-expected.txt:
  • platform/chromium-win/media/controls-without-preload-expected.txt:
  • platform/chromium-win/media/media-controls-clone-expected.txt:
  • platform/chromium-win/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-win/media/video-controls-rendering-expected.txt:
  • platform/chromium-win/media/video-display-toggle-expected.txt:
  • platform/chromium-win/media/video-empty-source-expected.txt:
  • platform/chromium-win/media/video-no-audio-expected.txt:
  • platform/chromium-win/media/video-playing-and-pause-expected.txt:
  • platform/chromium-win/media/video-volume-slider-expected.txt:
  • platform/chromium-win/media/video-zoom-controls-expected.txt:
  • platform/chromium/test_expectations.txt:
14:58 Changeset [113625] by wjmaclean@chromium.org

Mark myself as a committer
https://bugs.webkit.org/show_bug.cgi?id=83510

Reviewed by Adrienne Walker.

  • Scripts/webkitpy/common/config/committers.py:
14:46 Changeset [113624] by timothy_horton@apple.com

FrameData constructor zeroes all fields, causing ImageOrientation to be 0
https://bugs.webkit.org/show_bug.cgi?id=83416

Reviewed by Geoff Garen.

Reinstate SimpleClassVectorTraits on FrameData (which were removed by http://trac.webkit.org/changeset/113543)
with canInitializeWithMemset disabled, since two of the FrameData fields cannot be initialized to zero.

No new tests.

  • platform/graphics/BitmapImage.h:
14:40 Changeset [113623] by commit-queue@webkit.org

[chromium] CCLayerTreeHost / WebLayerTreeView should be single ownership, not RefCounted
https://bugs.webkit.org/show_bug.cgi?id=83413

Patch by James Robinson <jamesr@chromium.org> on 2012-04-09
Reviewed by Adrienne Walker.

Source/Platform:

This makes WebLayerTreeView noncopyable to better match the underlying semantics. There is no code currently
that attempts to copy WebLayerTreeView instances.

  • chromium/public/WebLayerTreeView.h:

(WebKit):
(WebLayerTreeView):

Source/WebCore:

CCLayerTreeHost always has a single logical owner, typically a WebLayerTreeView via either WebViewImpl or the
public API. It is currently refcounted for historical reasons but this isn't necessary and adds confusion.
CCLayerTreeHost instances and pointers are carefully managed currently to avoid leaks. In particular, while
LayerChromium instances hold RefPtr<CCLayerTreeHost>s, whenever we want to destroy a CCLayerTreeHost we
proactively clear out these references inside setRootLayer() to break the cycle.

Refactor covered by existing unit and layout tests.

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setMaskLayer):
(WebCore::LayerChromium::setReplicaLayer):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::layerTreeHost):
(LayerChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::create):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

Source/WebKit/chromium:

Updates tests and implementation for RefPtr->OwnPtr switch. One nice benefit is that since WebLayerTreeView is
explicitly owned by the user of the API we can safely rely on them managing the lifetime of the client and thus
don't have to null check the client all the time.

  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::reset):
(WebKit::WebLayerTreeView::isNull):
(WebKit::WebLayerTreeView::initialize):

  • src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::create):
(WebKit::WebLayerTreeViewImpl::willBeginFrame):
(WebKit::WebLayerTreeViewImpl::updateAnimations):
(WebKit::WebLayerTreeViewImpl::layout):
(WebKit::WebLayerTreeViewImpl::applyScrollAndScale):
(WebKit::WebLayerTreeViewImpl::createContext):
(WebKit::WebLayerTreeViewImpl::didRecreateContext):
(WebKit::WebLayerTreeViewImpl::didCommit):
(WebKit::WebLayerTreeViewImpl::didCommitAndDrawFrame):
(WebKit::WebLayerTreeViewImpl::didCompleteSwapBuffers):
(WebKit::WebLayerTreeViewImpl::scheduleComposite):

  • src/WebLayerTreeViewImpl.h:

(WebLayerTreeViewImpl):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::MockLayerTreeHost::create):
(CCLayerTreeHostTest):

  • tests/Canvas2DLayerChromiumTest.cpp:
  • tests/LayerChromiumTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):

14:37 Changeset [113622] by jsbell@chromium.org

Unreviewed, rolling out r113473.
http://trac.webkit.org/changeset/113473
https://bugs.webkit.org/show_bug.cgi?id=83074

Change does not handle cursor retention of LevelDB iterators

Source/WebCore:

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::~IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::loadObjectStores):

  • Modules/indexeddb/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::IDBIndexBackendImpl):
(WebCore::IDBIndexBackendImpl::openCursorInternal):
(WebCore::IDBIndexBackendImpl::countInternal):
(WebCore::IDBIndexBackendImpl::getInternal):
(WebCore::IDBIndexBackendImpl::addingKeyAllowed):

  • Modules/indexeddb/IDBIndexBackendImpl.h:

(WebCore::IDBIndexBackendImpl::create):
(IDBIndexBackendImpl):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl):
(WebCore::IDBObjectStoreBackendImpl::getInternal):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):
(WebCore::IDBObjectStoreBackendImpl::clearInternal):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
(WebCore::IDBObjectStoreBackendImpl::countInternal):
(WebCore::IDBObjectStoreBackendImpl::loadIndexes):
(WebCore::IDBObjectStoreBackendImpl::genAutoIncrementKey):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(WebCore):
(WebCore::IDBObjectStoreBackendImpl::create):
(WebCore::IDBObjectStoreBackendImpl::databaseId):
(IDBObjectStoreBackendImpl):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/IDBDatabaseBackendTest.cpp: Removed.
14:32 Changeset [113621] by leviw@chromium.org

Cleaning up LayoutUnit usage in DOMNodeHighlighter and removing unnecessary static_casts in ValidationMessage.

14:30 Changeset [113620] by lforschler@apple.com

New Tag.

14:26 Changeset [113619] by commit-queue@webkit.org

[CSS Regions] Convert a fast/regions pixel test to a ref test
https://bugs.webkit.org/show_bug.cgi?id=83398

Patch by David Alcala <dalcala@adobe.com> on 2012-04-09
Reviewed by Dirk Schulze.

  • fast/regions/position-writing-modes-in-variable-width-regions-expected.html: Added.
  • platform/chromium-linux/fast/regions/position-writing-modes-in-variable-width-regions-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/regions/position-writing-modes-in-variable-width-regions-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/regions/position-writing-modes-in-variable-width-regions-expected.png: Removed.
  • platform/chromium-mac/fast/regions/position-writing-modes-in-variable-width-regions-expected.png: Removed.
  • platform/chromium-mac/fast/regions/position-writing-modes-in-variable-width-regions-expected.txt: Removed.
  • platform/chromium-win/fast/regions/position-writing-modes-in-variable-width-regions-expected.png: Removed.
  • platform/chromium-win/fast/regions/position-writing-modes-in-variable-width-regions-expected.txt: Removed.
  • platform/efl/fast/regions/position-writing-modes-in-variable-width-regions-expected.png: Removed.
  • platform/efl/fast/regions/position-writing-modes-in-variable-width-regions-expected.txt: Removed.
  • platform/mac/fast/regions/position-writing-modes-in-variable-width-regions-expected.png: Removed.
  • platform/mac/fast/regions/position-writing-modes-in-variable-width-regions-expected.txt: Removed.
14:24 Changeset [113618] by jamesr@google.com

[chromium] Texture copies should happen after incremental updates to preserve commit atomicity
https://bugs.webkit.org/show_bug.cgi?id=83392

Reviewed by Adrienne Walker.

Source/WebCore:

This enqueues texture copy operations in the CCTextureUpdater's list instead of evaluating them immediately so
if the update is spread over multiple frames we can properly defer the texture copy until the end. Otherwise,
the texture copy for WebGL / Canvas 2D content happens before the commit completes and the compositor might pick
up a frame for the canvas that's "ahead" of the content around it.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/cc/CCTextureUpdater.cpp:

(WebCore::CCTextureUpdater::appendUpdate):
(WebCore::CCTextureUpdater::appendPartialUpdate):
(WebCore):
(WebCore::CCTextureUpdater::appendCopy):
(WebCore::CCTextureUpdater::hasMoreUpdates):
(WebCore::CCTextureUpdater::update):
(WebCore::CCTextureUpdater::clear):

  • platform/graphics/chromium/cc/CCTextureUpdater.h:

(CCTextureUpdater):
(UpdateEntry):
(CopyEntry):

Source/WebKit/chromium:

  • tests/Canvas2DLayerChromiumTest.cpp:
14:07 Changeset [113617] by dpranke@chromium.org

nrwt is failing to upload test results on the chromium-mac-leopard bots
https://bugs.webkit.org/show_bug.cgi?id=83230

Unreviewed, build fix.

It looks like the change in r113399 to use the per-request
timeout variable didn't actually work, so I am removing the
timeout code altogether and counting on the idea that upload
just isn't likely to take that long and the timeouts and
retransmits are largely unused and largely unnecessary. We'll
see if this breaks anywhere else.

  • Scripts/webkitpy/common/net/file_uploader.py:

(FileUploader.init):
(FileUploader._upload_data.callback):
(FileUploader):

13:59 Changeset [113616] by rwlbuis@webkit.org

[BlackBerry] Cleanup LayoutTestControllerBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=83469

Reviewed by Dirk Schulze.

Remove WTF:: prefixes and fix a warning with the length variable.

  • DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:

(jsStringRefToWebCoreString):
(LayoutTestController::execCommand):
(LayoutTestController::isCommandEnabled):
(LayoutTestController::setUserStyleSheetLocation):
(LayoutTestController::counterValueForElementById):
(LayoutTestController::overridePreference):
(LayoutTestController::setMockGeolocationError):
(LayoutTestController::findString):

13:57 Changeset [113615] by noam.rosenthal@nokia.com

[Qt][WK2] Don't synchronize WebGraphicsLayers to the UI process if the actual layer information wasn't changed
https://bugs.webkit.org/show_bug.cgi?id=82522

Reviewed by Kenneth Rohde Christiansen.

Currently we set the m_modified flags for all of the descendants of a layer
that has changed its geometry. This causes unnecessary layer sync messages.
Instead, we only sync when the actual layer has changed, and add a flag
called m_shouldUpdateVisibleRect that applies to descendants of a layer
that has a modified geometry.

  • Shared/WebLayerTreeInfo.h:
  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::didChangeChildren):
(WebCore):
(WebCore::WebGraphicsLayer::setShouldUpdateVisibleRect):
(WebCore::WebGraphicsLayer::didChangeGeometry):
(WebCore::WebGraphicsLayer::WebGraphicsLayer):
(WebCore::WebGraphicsLayer::setPosition):
(WebCore::WebGraphicsLayer::setAnchorPoint):
(WebCore::WebGraphicsLayer::setSize):
(WebCore::WebGraphicsLayer::setTransform):
(WebCore::WebGraphicsLayer::setChildrenTransform):
(WebCore::WebGraphicsLayer::setPreserves3D):
(WebCore::WebGraphicsLayer::setContentsToImage):
(WebCore::WebGraphicsLayer::setNeedsDisplayInRect):
(WebCore::WebGraphicsLayer::syncImageBackingStore):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
(WebCore::WebGraphicsLayer::tiledBackingStorePaintBegin):
(WebCore::WebGraphicsLayer::setRootLayer):
(WebCore::WebGraphicsLayer::setVisibleContentRectTrajectoryVector):
(WebCore::WebGraphicsLayer::setContentsScale):
(WebCore::WebGraphicsLayer::effectiveContentsScale):
(WebCore::WebGraphicsLayer::adjustContentsScale):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:

(WebGraphicsLayer):

13:50 Changeset [113614] by eae@chromium.org

Replace numeric_limits<LayoutUnit>::min/max with constants on branch.

13:43 Changeset [113613] by commit-queue@webkit.org

[chromium] Add Battery Status API support.

Source/WebCore:

Add Battery Status API support to chromium.
https://bugs.webkit.org/show_bug.cgi?id=83284

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-04-09
Reviewed by Adam Barth.

This change is covered by tests in batterystatus/.

  • Modules/battery/BatteryController.cpp:

(WebCore::BatteryController::updateBatteryStatus):
(WebCore):

  • Modules/battery/BatteryController.h:

(BatteryController):

  • Modules/battery/BatteryManager.cpp:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:

Source/WebKit/chromium:

The battery-client (BatteryClientChromium) will notify the client (WebBatteryStatusClient) when to start or stop
sending battery status updates. The client, in response will send the notifications to WebViewImpl, which sends
this update information to the WebCore::BatteryClient, and it triggers the appropriate javascript-callbacks.
The spec is at http://www.w3.org/TR/2011/WD-battery-status-20111129/.
https://bugs.webkit.org/show_bug.cgi?id=83284

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-04-09
Reviewed by Adam Barth.

  • WebKit.gyp:
  • features.gypi:
  • public/WebBatteryStatus.h: Added.

(WebKit):
(WebBatteryStatus):
(WebKit::WebBatteryStatus::WebBatteryStatus):

  • public/WebBatteryStatusClient.h: Added.

(WebKit):
(WebBatteryStatusClient):
(WebKit::WebBatteryStatusClient::~WebBatteryStatusClient):

  • public/WebView.h:

(WebKit):
(WebView):
(WebKit::WebView::updateBatteryStatus):

  • public/WebViewClient.h:

(WebKit):
(WebViewClient):
(WebKit::WebViewClient::batteryStatusClient):

  • src/BatteryClientImpl.cpp: Added.

(WebKit):
(WebKit::BatteryClientImpl::BatteryClientImpl):
(WebKit::BatteryClientImpl::updateBatteryStatus):
(WebKit::BatteryClientImpl::setController):
(WebKit::BatteryClientImpl::startUpdating):
(WebKit::BatteryClientImpl::stopUpdating):
(WebKit::BatteryClientImpl::batteryControllerDestroyed):

  • src/BatteryClientImpl.h: Added.

(WebKit):
(BatteryClientImpl):
(WebKit::BatteryClientImpl::~BatteryClientImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit):
(WebKit::WebViewImpl::updateBatteryStatus):

  • src/WebViewImpl.h:

(WebKit):
(WebViewImpl):

LayoutTests:

Add Battery Status API support to chromium.
https://bugs.webkit.org/show_bug.cgi?id=83284

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-04-09
Reviewed by Adam Barth.

  • platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
  • platform/chromium/test_expectations.txt:
13:31 Changeset [113612] by leviw@chromium.org

Adding more missing double overloads to avoid unnecessary static_casting.

13:31 Changeset [113611] by commit-queue@webkit.org

Unnecessary scroll bar after changing the dimensions of a DIV
https://bugs.webkit.org/show_bug.cgi?id=71541

Patch by SravanKumar Sandela <ssandela@innominds.com> on 2012-04-09
Reviewed by Julien Chaffraix.

Source/WebCore:

overflow: auto was being determined based on clientWidth and clientHeight, which during style change
scenarii will blindly exclude previous scrollbars while computing overflow. This is valid only for
overflow: scroll, but for other cases it wrongly reduces available area. Now it is taken care by
determining the overflow based on pixelSnappedPaddingBoxWidth/Height() which are newly added in RenderBox.

Tests: fast/overflow/overflow-auto-destroy-scroll-after-resizing-expected.html

fast/overflow/overflow-auto-destroy-scroll-after-resizing.html

  • rendering/RenderBox.h:

(WebCore::RenderBox::paddingBoxWidth):
(WebCore::RenderBox::paddingBoxHeight):
(WebCore::RenderBox::pixelSnappedPaddingBoxWidth):
(WebCore::RenderBox::pixelSnappedPaddingBoxHeight):
(RenderBox):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hasHorizontalOverflow):
(WebCore::RenderLayer::hasVerticalOverflow):

LayoutTests:

Ref tests to check scrollbar behaviour in overflow: auto, on resizing.

  • fast/overflow/overflow-auto-destroy-scroll-after-resizing-expected.html: Added.
  • fast/overflow/overflow-auto-destroy-scroll-after-resizing.html: Added.

scrollbars-on-positioned-content.html and hidden-scrollbar-resize.html needs to be rebaselined
as their expected values were buggy because of redundant scrollbars.

  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
13:26 Changeset [113610] by noam.rosenthal@nokia.com

[Qt][WK2] Remove all USE(TILED_BACKING_STORE) defines from code that contains UI_SIDE_COMPOSITING
https://bugs.webkit.org/show_bug.cgi?id=82533

Reviewed by Kenneth Rohde Christiansen.

No change in behavior, removing some #defines.

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::setShouldUpdateVisibleRect):
(WebCore::WebGraphicsLayer::adjustContentsScale):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:

(WebGraphicsLayer):

  • WebProcess/WebPage/LayerTreeHost.h:

(LayerTreeHost):

  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::LayerTreeHostQt):
(WebKit::LayerTreeHostQt::detachLayer):

13:10 Changeset [113609] by commit-queue@webkit.org

Source/WebCore: Simplified volume slider rendering.
https://bugs.webkit.org/show_bug.cgi?id=82150

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-04-09
Reviewed by Eric Carlson.

Test: media/video-controls-rendering-toggle-display-none.html

  • css/mediaControlsChromium.css: Update controls css for Chromium.

(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):

  • css/mediaControlsQuickTime.css: Update controls css for Safari.

(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):

  • html/shadow/MediaControlElements.cpp: Removed particular renderer.

(WebCore):

  • html/shadow/MediaControlElements.h:

(MediaControlVolumeSliderContainerElement): Removed particular renderer.

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::create): Added a div element as a container. Removed extra
unused mute button.

  • html/shadow/MediaControlRootElementChromium.cpp: Added an extra div element as a container for

the mute button and the volume slider to easily position them relative to each other.
(WebCore::MediaControlRootElementChromium::create):

LayoutTests: Simplified volume rendering.
https://bugs.webkit.org/show_bug.cgi?id=82150

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-04-09
Reviewed by Eric Carlson.

  • media/video-controls-rendering-toggle-display-none-expected.txt: Added.
  • media/video-controls-rendering-toggle-display-none.html: Added.
  • platform/chromium/test_expectations.txt: Marked tests for rebaseline.
13:01 Changeset [113608] by noam.rosenthal@nokia.com

[Qt][WK2] Disable the content-scaling and visible contents rect when the layer's transform is not affine
https://bugs.webkit.org/show_bug.cgi?id=82523

Reviewed by Kenneth Rohde Christiansen.

Always use contentsScale of 1 and a full visibleContentsRect when
the layer's transform is not affine. That's because layer's with
complex transform would not gain from the benefit of contents scaling,
and might also create unexpected layer content sizes.

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::createBackingStore):
(WebCore):
(WebCore::WebGraphicsLayer::tiledBackingStorePaint):
(WebCore::WebGraphicsLayer::tiledBackingStorePaintEnd):
(WebCore::WebGraphicsLayer::tiledBackingStoreVisibleRect):
(WebCore::WebGraphicsLayer::updateTile):
(WebCore::WebGraphicsLayer::removeTile):
(WebCore::WebGraphicsLayer::updateContentBuffers):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:

(WebGraphicsLayer):

12:46 Changeset [113607] by leviw@chromium.org

Correct some LayoutUnit misuse in FilterEffectRenderer, and RenderBlock
https://bugs.webkit.org/show_bug.cgi?id=83366

Reviewed by Eric Seidel.

Some more preparation of Render classes for FractionalLayoutUnits. See below for details
of each change.

No new tests. No change in behavior.

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRendererHelper::applyFilterEffect): Pixel snapping image rect before
drawing it.

  • rendering/RenderBlock.cpp:

(WebCore::::string): Pixel snapping outputted values for debug.

12:31 Changeset [113606] by shawnsingh@chromium.org

[chromium] Fix layer sorting perspective w if w becomes negative
https://bugs.webkit.org/show_bug.cgi?id=82997

Reviewed by Adrienne Walker.

Source/WebCore:

Unit test added to CCLayerSorterTest.cpp.

This is a follow-up patch after r113364. That other patch
implemented proper clipping so that perspective transforms do not
accidentally make geometry disappear. This patch fixes a similar
problem in the layer sorter code so that layers do not
accidentally get sorted incorrectly.

  • platform/graphics/chromium/cc/CCLayerSorter.cpp:

(WebCore::CCLayerSorter::LayerShape::LayerShape):

  • platform/graphics/chromium/cc/CCMathUtil.cpp:

(WebCore::computeEnclosingRect):
(WebCore::addVertexToClippedQuad):
(WebCore::CCMathUtil::mapClippedQuad):
(WebCore):
(WebCore::CCMathUtil::computeEnclosingRectOfVertices):

  • platform/graphics/chromium/cc/CCMathUtil.h:

(WebCore):
(CCMathUtil):

Source/WebKit/chromium:

  • tests/CCLayerSorterTest.cpp:

(WebCore::TEST):
(WebCore):

12:31 Changeset [113605] by commit-queue@webkit.org

[Qt][WK2] Fail to activate links after double tap gesture.
https://bugs.webkit.org/show_bug.cgi?id=83468

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-09
Reviewed by Kenneth Rohde Christiansen.

.:

  • ManualTests/link-activation-fails-after-double-tap-gesture.html: Added.

Source/WebKit2:

After a recognized double tap gesture, QtTapGestureRecognizer
gets stuck in the double-tap state. Only tapping outside of
the double tap radius cancels it.
Call reset() to set the default state back.

  • UIProcess/qt/QtTapGestureRecognizer.cpp:

(WebKit::QtTapGestureRecognizer::recognize):

ManualTests/link-activation-fails-after-double-tap-gesture.html: Added.

12:28 Changeset [113604] by commit-queue@webkit.org

[soup] Crash while loading http://www.jusco.cn
https://bugs.webkit.org/show_bug.cgi?id=68238

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-04-09
Reviewed by Philippe Normand.

.:

  • configure.ac: Bumped the libsoup dependency to 2.37.90.

Source/WebCore:

Test: http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers.html

When running synchronous XMLHttpRequests, push a new inner thread default
context, so that other sources from timers and network activity do not run.
This will make synchronous requests truly synchronous with the rest of
WebCore.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCoreSynchronousLoader): Clean up the method definitions a bit by writing them inline.
(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): Push a new thread default
context to prevent other sources from running.
(WebCore::WebCoreSynchronousLoader::~WebCoreSynchronousLoader): Pop the inner thread default context.
(WebCore::closeCallback): If the client is synchronous call didFinishLoading now.
(WebCore::readCallback): Only call didFinishLoading if the client isn't synchronous.
(WebCore::ResourceHandle::defaultSession): Activate use-thread-context so that the soup session
respects the inner thread context.

LayoutTests:

  • http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers.html: Added.
12:17 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
12:06 Changeset [113603] by leviw@chromium.org

Using FractionalLayoutUnit instead of LayoutUnit for overloaded functions in Length, and using static_cast's in html/ValidationMessage.cpp so the changes can be landed in trunk.

11:58 Changeset [113602] by commit-queue@webkit.org

[chromium] Flip transition painting delayed with threaded animations
https://bugs.webkit.org/show_bug.cgi?id=82571

Patch by Dana Jansens <danakj@chromium.org> on 2012-04-09
Reviewed by Adrienne Walker.

Source/WebCore:

This allows for prepainting to see and paint layers that are not facing
the camera but have animating transforms. This is needed to prepaint
animations that "flip" layers around to make the front visible.

The changes are to add a backFaceIsVisible() helper function in
CCLTHCommon. This is used like before to cull non-double sided
layers, but culling is prevented on main thread when the screen
space transform is unknown due to animation. We add new
helper methods transformToScreenIsKnown() to identify this.

However the layer is not actually visible, so we set the
visibleLayerRect to be empty in this case.

The calculateVisibleLayerRect needs to use the backFaceIsVisible()
helper, so we move it into the .cpp file where it belongs, and make
it static to the file since it is not used outide of CCLTHCommon.cpp
at all.

Unit test: CCLayerTreeHostCommonTest.verifyBackFaceCulling

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore):
(WebCore::backFaceIsVisible):
(WebCore::calculateVisibleLayerRect):
(WebCore::layerOpacityIsOpaque):
(WebCore::transformToParentIsKnown):
(WebCore::transformToScreenIsKnown):
(WebCore::layerShouldBeSkipped):
(WebCore::calculateDrawTransformsAndVisibilityInternal):
(WebCore::walkLayersAndCalculateVisibleLayerRects):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:

(WebCore):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostCommonTest.cpp:

(WebKitTests::TEST):
(WebKitTests):

11:56 Changeset [113601] by commit-queue@webkit.org

[GTK] Toggle buttons do not size appropriately in some themes
https://bugs.webkit.org/show_bug.cgi?id=82833

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-04-09
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Test: platform/gtk/fast/forms/large-toggle-elements.html

Instead of drawing a toggle button across the entire rectangle of
the WebCore control, draw a default-sized one cenetered in the rectangle.

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore::paintToggle): Draw default-sized toggles.

LayoutTests:

Add a test for this issue.

  • platform/gtk/fast/forms/large-toggle-elements-expected.png: Added.
  • platform/gtk/fast/forms/large-toggle-elements-expected.txt: Added.
  • platform/gtk/fast/forms/large-toggle-elements.html: Added.
11:50 PrefixedAPIs edited by kbr@google.com
Added links about postMessage prefixing and Transferables (diff)
11:49 Changeset [113600] by commit-queue@webkit.org

When create JavaScriptNode, do not ignore NumberOfOutputChannels parameter.
https://bugs.webkit.org/show_bug.cgi?id=83250

Patch by Raymond Liu <raymond.liu@intel.com> on 2012-04-09
Reviewed by Chris Rogers.

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::createJavaScriptNode):
(WebCore):

  • Modules/webaudio/AudioContext.h:

(AudioContext):

  • Modules/webaudio/AudioContext.idl:
  • Modules/webaudio/JavaScriptAudioNode.cpp:

(WebCore::JavaScriptAudioNode::create):
(WebCore):
(WebCore::JavaScriptAudioNode::JavaScriptAudioNode):
(WebCore::JavaScriptAudioNode::initialize):
(WebCore::JavaScriptAudioNode::process):

  • Modules/webaudio/JavaScriptAudioNode.h:

(JavaScriptAudioNode):

11:34 Changeset [113599] by eae@chromium.org

Remove size_t versions of methods and numeric_limits from FractionalLayoutUnit on branch.

11:29 Changeset [113598] by robert@webkit.org

Skip fast/css/align-positioned-object-on-resize.html on Mac platforms.
window.resizeTo() doesn't behave as expected in Mac DRT.

Unreviewed.

  • platform/mac/Skipped:
11:21 Changeset [113597] by inferno@chromium.org

Crash due to floats not cleared before starting SVG <text> layout.
https://bugs.webkit.org/show_bug.cgi?id=83021

Reviewed by Dirk Schulze.

.:

  • ManualTests/svg-text-float-not-removed-crash.html: Added.

Source/WebCore:

Manual Test - ManualTests/svg-text-float-not-removed-crash.html.
Can't reproduce the failure in DRT.

forceLayoutInlineChildren is used in SVG <text> layout and overrides
RenderBlock::layoutBlock. However, it missed the 'clearFloats' step,
which will cause a crash when trying to access removed renderers.

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::forceLayoutInlineChildren):

11:19 Changeset [113596] by jpfau@apple.com

Filter files from dataTransfer.getData on Mac
https://bugs.webkit.org/show_bug.cgi?id=38876

Reviewed by Enrica Casucci.

Source/WebCore:

The ClipboardMac class now keeps track of whether it was created for copy and paste, dragging and dropping
files or dragging and dropping generic data. This enables the class to block calls to set-/getData when the
clipboard is not operating on generic data, and vice-versa.

Test: fast/events/drop-with-file-paths.html

  • editing/mac/EditorMac.mm:

(WebCore::Editor::newGeneralClipboard):

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::createDraggingClipboard):

  • platform/mac/ClipboardMac.h:

(WebCore::ClipboardMac::create):
(ClipboardMac):

  • platform/mac/ClipboardMac.mm:

(WebCore::Clipboard::create):
(WebCore::ClipboardMac::ClipboardMac):
(WebCore::ClipboardMac::getData):
(WebCore::ClipboardMac::setData):
(WebCore::ClipboardMac::files):

LayoutTests:

  • fast/events/drop-with-file-paths-expected.txt: Added.
  • fast/events/drop-with-file-paths.html: Added.
  • fast/events/resources/file-for-drop-with-file-paths.html: Added.
11:13 Changeset [113595] by commit-queue@webkit.org

Unreviewed, rolling out r113561.
http://trac.webkit.org/changeset/113561
https://bugs.webkit.org/show_bug.cgi?id=83487

broke webkit_unit_tests (Requested by simonjam on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-09

Source/WebCore:

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::transformSurfaceOpaqueRegion):
(WebCore::computeOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):
(WebCore::testContentRectOccluded):
(WebCore::computeUnoccludedContentRect):

Source/WebKit/chromium:

  • tests/CCOcclusionTrackerTest.cpp:

(WebKitTests):

  • tests/CCQuadCullerTest.cpp:

(WebCore::TestCCOcclusionTrackerImpl::TestCCOcclusionTrackerImpl):

11:09 Changeset [113594] by leviw@chromium.org

Correct LayoutUnit usage in style functions getRoundedBorderFor
https://bugs.webkit.org/show_bug.cgi?id=83154

Reviewed by Julien Chaffraix.

Correcting LayoutUnit usage in getRoundedBorderFor and the calcRadiiFor helper function.

No new tests. No change in behavior.

  • rendering/style/RenderStyle.cpp:

(WebCore::calcRadiiFor): This is a static internal function that returns the radii based on a size.
It's only called from getRoundedBorderFor, so we're now pixel snapping the size before handing it
to this function.
(WebCore::RenderStyle::getRoundedBorderFor): Takes a LayoutRect and returns the pixel-snapped
resulting RoundedRect. Using a local IntRect to avoid snapping twice.

11:03 WebKitGTK/1.8.x edited by kov@webkit.org
(diff)
11:00 Changeset [113593] by kov@webkit.org

Merging 113019

10:37 Changeset [113592] by robert@webkit.org

Fix layout test for r113584 on Qt and Mac

Unreviewed.

  • fast/css/align-positioned-object-on-resize.html: Use layoutTestController.display() so that window.resizeTo() is honoured on all DRTs.
  • platform/qt/Skipped: Unskip the above test.
10:36 Changeset [113591] by caseq@chromium.org

Web Inspector: zoom on vertical mousewheel in Timeline overview
https://bugs.webkit.org/show_bug.cgi?id=83379

Reviewed by Pavel Feldman.

  • added support for zooming around mouse cursor upon mousewheel event;
  • handle mousewheel event by _onMouseWheel, not scrollWindow, so we only zoom on events internal to overview.
  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewWindow):
(WebInspector.TimelineOverviewWindow.prototype._endWindowSelectorDragging):
(WebInspector.TimelineOverviewWindow.prototype._onMouseWheel):
(WebInspector.TimelineOverviewWindow.prototype._zoom):

10:26 Changeset [113590] by leviw@chromium.org

Fix a bug in calculating pixelSnappedClientWidth/Height (thanks Julien), and cleaning up some style errors in LayoutTypes and Length.

10:17 Changeset [113589] by bbudge@chromium.org

Cross-origin preflight request should not include credentials.
https://bugs.webkit.org/show_bug.cgi?id=37676

Source/WebCore:

Modifies createAccessControlPreflightRequest so it never allows credentials.

Reviewed by Adam Barth.

http/tests/xmlhttprequest/access-control-preflight-credential-sync.html
http/tests/xmlhttprequest/access-control-preflight-credential-async.html

  • loader/CrossOriginAccessControl.cpp:

(WebCore::createAccessControlPreflightRequest):

  • loader/CrossOriginAccessControl.h:

(WebCore):

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequestWithPreflight):

LayoutTests:

Modifies preflight credential tests to make sure that cookies aren't sent along with the
CORS prefetch request.

Reviewed by Adam Barth.

  • http/tests/xmlhttprequest/access-control-preflight-credential-async-expected.txt:
  • http/tests/xmlhttprequest/access-control-preflight-credential-async.html:
  • http/tests/xmlhttprequest/access-control-preflight-credential-sync-expected.txt:
  • http/tests/xmlhttprequest/access-control-preflight-credential-sync.html:
  • http/tests/xmlhttprequest/resources/basic-auth/access-control-auth-basic.php:
10:01 Changeset [113588] by antti@apple.com

Don't expose internal CSSValues in API
https://bugs.webkit.org/show_bug.cgi?id=83426

Reviewed by Andreas Kling.

The CSSValues returned from functions like CSSStyleDeclaration.getPropertyCSSValue() are currently
the same instances we use internally. This creates various problems. The values can't be shared between
documents as the wrappers would be shared too. Having to maintain per-document CSSValuePools complicate
the architecture and increase memory usage. This also blocks sharing style sheet data structures
between documents.

This patch adds a concept of CSSOM-safe CSSValue. Only the safe values can be wrapped for JS access.
Values are unsafe by default. The CSSOM functions that return CSSValues create safe instances by
cloning the internal values.

The use of APIs that return CSSValues is very rare (the currect CSSOM draft deprecates them) and
cloning is cheap in any case. Future patches will eliminate the per-document value pool in favor
of a global one for a memory win.

In the future we want to replace internally used CSSValues with true internal types (StyleValues) and
use CSSValues exclusively as wrappers (similar to how CSSStyleRule wraps internal StyleRule).

  • bindings/js/JSCSSValueCustom.cpp:

(WebCore::toJS):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValueInternal):

  • css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::CSSImageSetValue):
(WebCore):
(WebCore::CSSImageSetValue::cloneForCSSOM):

  • css/CSSImageSetValue.h:

(CSSImageSetValue):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::cleanup):

Opportunistically fix a string leak for CSS_COUNTER_NAME values.
Add all cases, remove default.

(WebCore::CSSPrimitiveValue::cloneForCSSOM):
(WebCore):

  • css/CSSPrimitiveValue.h:

(CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::setCSSOMSafe):

  • css/CSSValue.cpp:

(WebCore):
(TextCloneCSSValue):
(WebCore::TextCloneCSSValue::create):
(WebCore::TextCloneCSSValue::cssText):
(WebCore::TextCloneCSSValue::TextCloneCSSValue):

Most non-primitive value types are not exposed in CSSOM. For those we create a dummy value
that contains only the data that is accessible though the base CSSValue interface.

(WebCore::CSSValue::addSubresourceStyleURLs):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
(WebCore::CSSValue::cloneForCSSOM):

  • css/CSSValue.h:

(WebCore):
(CSSValue):
(WebCore::CSSValue::isCSSOMSafe):
(WebCore::CSSValue::isSubtypeExposedToCSSOM):
(WebCore::CSSValue::CSSValue):

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::CSSValueList):
(WebCore):
(WebCore::CSSValueList::cloneForCSSOM):

  • css/CSSValueList.h:

(CSSValueList):

  • css/Counter.h:

(Counter):
(WebCore::Counter::cloneForCSSOM):

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
(WebCore::PropertySetCSSStyleDeclaration::didMutate):
(WebCore):
(WebCore::PropertySetCSSStyleDeclaration::cloneAndCacheForCSSOM):

Maintain a map of safe CSSValues so we can maintain object identity.

  • css/PropertySetCSSStyleDeclaration.h:

(WebCore::PropertySetCSSStyleDeclaration::setNeedsStyleRecalc):
(PropertySetCSSStyleDeclaration):

  • css/RGBColor.cpp:

(WebCore::RGBColor::red):
(WebCore::RGBColor::green):
(WebCore::RGBColor::blue):
(WebCore::RGBColor::alpha):

  • css/Rect.h:

(WebCore::RectBase::RectBase):
(RectBase):
(Rect):
(WebCore::Rect::cloneForCSSOM):
(WebCore::Rect::Rect):
(Quad):
(WebCore::Quad::cloneForCSSOM):
(WebCore::Quad::Quad):

  • css/WebKitCSSFilterValue.cpp:

(WebCore::WebKitCSSFilterValue::WebKitCSSFilterValue):
(WebCore):
(WebCore::WebKitCSSFilterValue::cloneForCSSOM):

  • css/WebKitCSSFilterValue.h:

(WebKitCSSFilterValue):

  • css/WebKitCSSTransformValue.cpp:

(WebCore::WebKitCSSTransformValue::WebKitCSSTransformValue):
(WebCore):
(WebCore::WebKitCSSTransformValue::cloneForCSSOM):

  • css/WebKitCSSTransformValue.h:

(WebKitCSSTransformValue):

  • svg/SVGColor.cpp:

(WebCore::SVGColor::SVGColor):
(WebCore):
(WebCore::SVGColor::cloneForCSSOM):

  • svg/SVGColor.h:

(SVGColor):

  • svg/SVGPaint.cpp:

(WebCore::SVGPaint::SVGPaint):
(WebCore):
(WebCore::SVGPaint::cloneForCSSOM):

  • svg/SVGPaint.h:

(SVGPaint):

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::getPresentationAttribute):

09:44 Changeset [113587] by pfeldman@chromium.org

Web Inspector: get rid of WebInspector.Resource.category, use WebInspector.Resource.type instead.
https://bugs.webkit.org/show_bug.cgi?id=83467

Reviewed by Yury Semikhatsky.

Source/WebCore:

WebInspector.Resource.category is derived from the WebInspector.Resource.type and there is no real need it maintaining both.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/AuditLauncherView.js:

(WebInspector.AuditLauncherView.prototype._onResourceStarted):
(WebInspector.AuditLauncherView.prototype._onResourceFinished):

  • inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.GzipRule.prototype._shouldCompress):
(WebInspector.AuditRules.CombineJsResourcesRule):
(WebInspector.AuditRules.CombineCssResourcesRule):
(WebInspector.AuditRules.ParallelizeDownloadRule.prototype.doRun):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
(WebInspector.AuditRules.CacheControlRule.prototype.isCompressible):
(WebInspector.AuditRules.StaticCookielessRule.prototype.processCookies):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModelResourceBinding):
(WebInspector.CSSStyleModelResourceBinding.prototype.setContent):
(WebInspector.CSSStyleModelResourceBinding.prototype._innerStyleSheetChanged):

  • inspector/front-end/ContentProviders.js:

(WebInspector.ResourceContentProvider):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModelResourceBinding):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype._getPopoverAnchor):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._makeResource):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkManager.get this):
(WebInspector.NetworkManager.get NetworkAgent):
(WebInspector.NetworkManager):
(WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
(WebInspector.NetworkDispatcher.prototype._mimeTypeIsConsistentWithType):
(WebInspector.NetworkDispatcher.prototype._updateResourceWithCachedResource):
(WebInspector.NetworkDispatcher.prototype.responseReceived):
(WebInspector.NetworkDispatcher.prototype.webSocketCreated):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._createFilterStatusBarItems):
(WebInspector.NetworkLogView.prototype._updateSummaryBar):
(WebInspector.NetworkDataGridNode.prototype.isFilteredOut):
(WebInspector.NetworkDataGridNode.prototype.refreshResource):
(WebInspector.NetworkDataGridNode.prototype._refreshNameCell):
(WebInspector.NetworkDataGridNode.prototype.refreshGraph):

  • inspector/front-end/Resource.js:

(WebInspector.Resource):
(WebInspector.Resource.registerDomainModelBinding):
(WebInspector.Resource.prototype.set type):
(WebInspector.Resource.prototype.isEditable):
(WebInspector.Resource.prototype.setContent):
(WebInspector.Resource.prototype.requestContent):

  • inspector/front-end/ResourceCategory.js: Removed.
  • inspector/front-end/ResourcePreviewView.js:

(WebInspector.ResourcePreviewView.prototype._createPreviewView):

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype.addScript):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype._onResourceUpdated):
(WebInspector.ResourceTreeModel.prototype._onResourceUpdateDropped):
(WebInspector.ResourceTreeModel.prototype._addFramesRecursively):

  • inspector/front-end/ResourceType.js: Added.

(WebInspector.ResourceType):
(WebInspector.ResourceType.prototype.name):
(WebInspector.ResourceType.prototype.title):
(WebInspector.ResourceType.prototype.categoryTitle):
(WebInspector.ResourceType.prototype.color):
(WebInspector.ResourceType.prototype.isTextType):
(WebInspector.ResourceType.prototype.toString):

  • inspector/front-end/ResourceView.js:

(WebInspector.ResourceView.hasTextContent):
(WebInspector.ResourceView.nonSourceViewForResource):
(WebInspector.EditableResourceSourceFrame.prototype.canEditSource):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameTreeElement.prototype.appendResource):
(WebInspector.FrameResourceTreeElement):
(WebInspector.FrameResourceTreeElement.prototype.onattach):
(WebInspector.ResourceRevisionTreeElement):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:

LayoutTests:

  • http/tests/inspector/network/async-xhr-json-mime-type-expected.txt:
  • http/tests/inspector/network/network-iframe-load-and-delete-expected.txt:
  • http/tests/inspector/network/network-xhr-async-expected.txt:
  • http/tests/inspector/network/network-xhr-same-url-as-main-resource.html:
  • http/tests/inspector/network/network-xhr-sync-expected.txt:
  • http/tests/inspector/resource-tree/resource-tree-invalid-mime-type-css-content.html:
  • http/tests/inspector/resource-tree/resource-tree-mimetype.html:
  • http/tests/inspector/resource-tree/resource-tree-test.js:

(initialize_ResourceTreeTest.InspectorTest.dumpResourceTreeEverything):
(initialize_ResourceTreeTest):

  • inspector/debugger/raw-source-code.html:
09:37 Changeset [113586] by alexis.menard@openbossa.org

Unreviewed, adding a missing header for the Qt port.

  • Target.pri:
09:35 Changeset [113585] by pfeldman@chromium.org

Web Inspector: [network panel] type column shows "undefined" instead of "(Pending)" upon load.
https://bugs.webkit.org/show_bug.cgi?id=83470

Reviewed by Yury Semikhatsky.

isPingRequest is tested for as a field, not a function return value.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkDataGridNode.prototype._refreshTypeCell):

09:34 Changeset [113584] by robert@webkit.org

REGRESSION (r94492): Incorrect initial layout of absolutely positioned <input> inside centering div
https://bugs.webkit.org/show_bug.cgi?id=77754

Reviewed by David Hyatt.

Source/WebCore:

The correct static position of an center-aligned, inline, absolutely positioned object with a block child can't be known
until the width of the child has been computed. This means that setStaticPositions() in RenderBlockLineLayout is setting
the position too early, before the width of the child has been finalised. To fix, adjust the static position of the inline
positioned object once its child's width has been calculated.

Test: fast/css/align-positioned-object-on-resize.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutPositionedObjects):

LayoutTests:

  • fast/css/align-positioned-object-on-resize-expected.txt: Added.
  • fast/css/align-positioned-object-on-resize.html: Added.
  • platform/qt/Skipped: Skipped on Qt as window.resizeTo() does not work properly in Qt DRT.
09:12 Changeset [113583] by eric.carlson@apple.com

WebVTT parser unnecessarily limits the value of a timestamp
https://bugs.webkit.org/show_bug.cgi?id=83422

Reviewed by Dan Bernstein.

Source/WebCore:

Test: media/track/track-large-timestamp.html

  • html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::collectTimeStamp): Make all constants double instead of int so

the maximum number of hours is increased and so we don't need any casts.

LayoutTests:

  • media/track/captions-webvtt/large-timestamp.vtt: Added.
  • media/track/track-large-timestamp-expected.txt: Added.
  • media/track/track-large-timestamp.html: Added.
09:05 Changeset [113582] by eae@chromium.org

Merge trunk changes up until 113577 into subpixel branch.

09:03 Changeset [113581] by inferno@chromium.org

Incorrect placement of new child to table when before child parent is not |this|.
https://bugs.webkit.org/show_bug.cgi?id=82630

Reviewed by Julien Chaffraix.

Source/WebCore:

Tests: fast/table/table-row-split2.html

fast/table/table-section-split2.html
fast/table/table-split.html
fast/table/table-split2.html

and tested by layouttests in commits r97180, r108127, and a few others.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addChildToAnonymousColumnBlocks): function rename, block->box.
(WebCore::RenderBlock::makeChildrenAnonymousColumnBlocks): ditto.
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks): ditto.

  • rendering/RenderBlock.h:

(RenderBlock):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::moveChildTo): move these functions from RenderBlock, needs to be
used in RenderBox::splitAnonymousBoxesAroundChild.
(WebCore):
(WebCore::RenderBox::moveChildrenTo): ditto.
(WebCore::markBoxForRelayoutAfterSplit): helper to mark a block or table part for complete relayout
after anonymous boxes are split around child.
(WebCore::RenderBox::splitAnonymousBoxesAroundChild): moved from RenderBlock to be able
to work with table parts.

  • rendering/RenderBox.h:

(RenderBox):
(WebCore::RenderBox::moveChildTo):
(WebCore::RenderBox::moveAllChildrenTo):
(WebCore::RenderBox::moveChildrenTo):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::addChild): no longer need the hack added in r95461.

  • rendering/RenderRubyBase.cpp:

(WebCore::RenderRubyBase::moveChildren): function rename, block->box.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::addChild): Use splitAnonymousBoxesAroundChild function when |beforeChild| != |this|.

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::addChild): ditto.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::addChild): ditto.

LayoutTests:

  • fast/table/cell-in-row-before-misnested-text-crash-css-expected.txt: rebaseline, corrects layout.
  • fast/table/cell-in-row-before-misnested-text-crash-expected.txt: rebaseline, corrects layout.
  • fast/table/row-in-tbody-before-misnested-text-crash-css-expected.txt: rebaseline, corrects layout.
  • fast/table/row-in-tbody-before-misnested-text-crash-expected.txt: rebaseline, corrects layout.
  • fast/table/table-row-split2-expected.png: Added.
  • fast/table/table-row-split2-expected.txt: Added.
  • fast/table/table-row-split2.html: Added.
  • fast/table/table-section-split2-expected.png: Added.
  • fast/table/table-section-split2-expected.txt: Added.
  • fast/table/table-section-split2.html: Added.
  • fast/table/table-split-expected.png: Added.
  • fast/table/table-split-expected.txt: Added.
  • fast/table/table-split.html: Added.
  • fast/table/table-split2-expected.png: Added.
  • fast/table/table-split2-expected.txt: Added.
  • fast/table/table-split2.html: Added.
08:52 PrefixedAPIs edited by jsbell@chromium.org
(diff)
08:51 PrefixedAPIs edited by jsbell@chromium.org
Added IndexedDB links (diff)
08:31 Changeset [113580] by jocelyn.turcotte@nokia.com

WebSocketServer: Honour WebSocketFrame::masked in makeFrameData
https://bugs.webkit.org/show_bug.cgi?id=83042

Reviewed by Kent Tamura.

Frames from the server should not be masked.
Currently, the flag is set to false, but the frames were masked anyway.
This causes clients with recent builds of WebKit to abort the connection to the
inspector server, refusing masked frames from the server as per the spec.
This doesn't change the behavior of WebSocket clients, which set the masked flag to true.

  • Modules/websockets/WebSocketFrame.cpp:

(WebCore::appendFramePayload):
(WebCore::WebSocketFrame::makeFrameData):

08:29 Changeset [113579] by schenney@chromium.org

Layout Test in svg are failing
https://bugs.webkit.org/show_bug.cgi?id=82232

Unreviewed Chromium expectations update.

All the tests covered by this bug ran without crashes over a five day
period. Given the previous crash rates, this suggests we've fixed the
problem.

  • platform/chromium/test_expectations.txt:
07:59 Changeset [113578] by eae@chromium.org

Revert abs changes from 113447 on branch as it broke linux builds.

06:43 Changeset [113577] by alexis.menard@openbossa.org

[Part 5] We should use CSSPropertyID rather than integers when manipulating CSS property ids.
https://bugs.webkit.org/show_bug.cgi?id=83466

Reviewed by Kentaro Hara.

CSSPropertyID enum holds all the CSS property ids but many parts of WebKit treat the ids
as integers, this patch should adress the last remaining occurences of ints rather than CSSPropertyIDs.

No new tests : There should be no behavior change in this patch.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • css/CSSStyleSelector.h:

(CSSStyleSelector):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::removePropertiesInSet):

  • page/animation/AnimationBase.cpp:

(WebCore::gatherEnclosingShorthandProperties):
(WebCore::AnimationBase::animatableShorthandsAffectingProperty):

  • page/animation/AnimationBase.h:

(AnimationBase):

  • page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::pauseTransitionAtTime):

  • page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::animate):
(WebCore::KeyframeAnimation::getAnimatedStyle):
(WebCore::KeyframeAnimation::overrideAnimations):
(WebCore::KeyframeAnimation::resumeOverriddenAnimations):
(WebCore::KeyframeAnimation::timeToNextService):

  • rendering/style/KeyframeList.cpp:

(WebCore::KeyframeList::insert):

  • rendering/style/KeyframeList.h:

(WebCore::KeyframeValue::addProperty):
(WebCore::KeyframeValue::containsProperty):
(WebCore::KeyframeValue::properties):
(KeyframeValue):
(WebCore::KeyframeList::addProperty):
(WebCore::KeyframeList::containsProperty):
(WebCore::KeyframeList::beginProperties):
(WebCore::KeyframeList::endProperties):
(KeyframeList):

06:34 Changeset [113576] by haraken@chromium.org

Unreviewed, rebaselined run-bindings-tests results.

  • bindings/scripts/test/JS/JSFloat64Array.cpp:

(WebCore::JSFloat64ArrayConstructor::getOwnPropertySlot):
(WebCore::JSFloat64ArrayConstructor::getOwnPropertyDescriptor):
(WebCore::jsFloat64ArrayConstructor):
(WebCore::JSFloat64Array::getConstructor):
(WebCore::jsFloat64ArrayPrototypeFunctionFoo):
(WebCore::toFloat64Array):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::JSTestActiveDOMObjectConstructor::getOwnPropertySlot):
(WebCore::JSTestActiveDOMObjectConstructor::getOwnPropertyDescriptor):
(WebCore::jsTestActiveDOMObjectExcitingAttr):
(WebCore::jsTestActiveDOMObjectConstructor):
(WebCore::JSTestActiveDOMObject::getConstructor):
(WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunction):
(WebCore::jsTestActiveDOMObjectPrototypeFunctionPostMessage):
(WebCore::JSTestActiveDOMObjectOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestActiveDOMObjectOwner::finalize):
(WebCore::toTestActiveDOMObject):

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore::JSTestCustomNamedGetterConstructor::getOwnPropertySlot):
(WebCore::JSTestCustomNamedGetterConstructor::getOwnPropertyDescriptor):
(WebCore::jsTestCustomNamedGetterConstructor):
(WebCore::JSTestCustomNamedGetter::getConstructor):
(WebCore::jsTestCustomNamedGetterPrototypeFunctionAnotherFunction):
(WebCore::JSTestCustomNamedGetterOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestCustomNamedGetterOwner::finalize):
(WebCore::toTestCustomNamedGetter):

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructorConstructor::getOwnPropertySlot):
(WebCore::JSTestEventConstructorConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestEventConstructorConstructor::constructJSTestEventConstructor):
(WebCore::jsTestEventConstructorAttr1):
(WebCore::jsTestEventConstructorAttr2):
(WebCore::jsTestEventConstructorConstructor):
(WebCore::JSTestEventConstructor::getConstructor):
(WebCore::JSTestEventConstructorOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestEventConstructorOwner::finalize):
(WebCore::toTestEventConstructor):

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::JSTestEventTargetConstructor::getOwnPropertySlot):
(WebCore::JSTestEventTargetConstructor::getOwnPropertyDescriptor):
(WebCore::jsTestEventTargetConstructor):
(WebCore::JSTestEventTarget::getConstructor):
(WebCore::jsTestEventTargetPrototypeFunctionItem):
(WebCore::jsTestEventTargetPrototypeFunctionAddEventListener):
(WebCore::jsTestEventTargetPrototypeFunctionRemoveEventListener):
(WebCore::jsTestEventTargetPrototypeFunctionDispatchEvent):
(WebCore::JSTestEventTarget::indexGetter):
(WebCore::JSTestEventTargetOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestEventTargetOwner::finalize):
(WebCore::toTestEventTarget):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::getOwnPropertySlot):
(WebCore::JSTestInterfaceConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestInterfaceConstructor::constructJSTestInterface):
(WebCore::jsTestInterfaceSupplementalStr1):
(WebCore::jsTestInterfaceSupplementalStr2):
(WebCore::jsTestInterfaceSupplementalStr3):
(WebCore::jsTestInterfaceSupplementalNode):
(WebCore::jsTestInterfaceConstructor):
(WebCore::setJSTestInterfaceSupplementalStr2):
(WebCore::setJSTestInterfaceSupplementalStr3):
(WebCore::setJSTestInterfaceSupplementalNode):
(WebCore::JSTestInterface::getConstructor):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod1):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod3):
(WebCore::JSTestInterfaceOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestInterfaceOwner::finalize):
(WebCore::toTestInterface):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListenerConstructor::getOwnPropertySlot):
(WebCore::JSTestMediaQueryListListenerConstructor::getOwnPropertyDescriptor):
(WebCore::jsTestMediaQueryListListenerConstructor):
(WebCore::JSTestMediaQueryListListener::getConstructor):
(WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):
(WebCore::JSTestMediaQueryListListenerOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestMediaQueryListListenerOwner::finalize):
(WebCore::toTestMediaQueryListListener):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorConstructor::getOwnPropertySlot):
(WebCore::JSTestNamedConstructorConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):
(WebCore::jsTestNamedConstructorConstructor):
(WebCore::JSTestNamedConstructor::getConstructor):
(WebCore::JSTestNamedConstructorOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestNamedConstructorOwner::finalize):
(WebCore::toTestNamedConstructor):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjConstructor::getOwnPropertySlot):
(WebCore::JSTestObjConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestObjConstructor::constructJSTestObj):
(WebCore::jsTestObjReadOnlyIntAttr):
(WebCore::jsTestObjReadOnlyStringAttr):
(WebCore::jsTestObjReadOnlyTestObjAttr):
(WebCore::jsTestObjShortAttr):
(WebCore::jsTestObjUnsignedShortAttr):
(WebCore::jsTestObjIntAttr):
(WebCore::jsTestObjLongLongAttr):
(WebCore::jsTestObjUnsignedLongLongAttr):
(WebCore::jsTestObjStringAttr):
(WebCore::jsTestObjTestObjAttr):
(WebCore::jsTestObjSequenceAttr):
(WebCore::jsTestObjXMLObjAttr):
(WebCore::jsTestObjCreate):
(WebCore::jsTestObjReflectedStringAttr):
(WebCore::jsTestObjReflectedIntegralAttr):
(WebCore::jsTestObjReflectedUnsignedIntegralAttr):
(WebCore::jsTestObjReflectedBooleanAttr):
(WebCore::jsTestObjReflectedURLAttr):
(WebCore::jsTestObjReflectedCustomIntegralAttr):
(WebCore::jsTestObjReflectedCustomBooleanAttr):
(WebCore::jsTestObjReflectedCustomURLAttr):
(WebCore::jsTestObjAttrWithGetterException):
(WebCore::jsTestObjAttrWithSetterException):
(WebCore::jsTestObjStringAttrWithGetterException):
(WebCore::jsTestObjStringAttrWithSetterException):
(WebCore::jsTestObjCustomAttr):
(WebCore::jsTestObjWithScriptStateAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAttribute):
(WebCore::jsTestObjWithScriptStateAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute):
(WebCore::jsTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::jsTestObjConditionalAttr1):
(WebCore::jsTestObjConditionalAttr2):
(WebCore::jsTestObjConditionalAttr3):
(WebCore::jsTestObjConditionalAttr4Constructor):
(WebCore::jsTestObjConditionalAttr5Constructor):
(WebCore::jsTestObjConditionalAttr6Constructor):
(WebCore::jsTestObjCachedAttribute1):
(WebCore::jsTestObjCachedAttribute2):
(WebCore::jsTestObjContentDocument):
(WebCore::jsTestObjMutablePoint):
(WebCore::jsTestObjImmutablePoint):
(WebCore::jsTestObjStrawberry):
(WebCore::jsTestObjStrictFloat):
(WebCore::jsTestObjDescription):
(WebCore::jsTestObjId):
(WebCore::jsTestObjHash):
(WebCore::jsTestObjConstructor):
(WebCore::setJSTestObjShortAttr):
(WebCore::setJSTestObjUnsignedShortAttr):
(WebCore::setJSTestObjIntAttr):
(WebCore::setJSTestObjLongLongAttr):
(WebCore::setJSTestObjUnsignedLongLongAttr):
(WebCore::setJSTestObjStringAttr):
(WebCore::setJSTestObjTestObjAttr):
(WebCore::setJSTestObjSequenceAttr):
(WebCore::setJSTestObjXMLObjAttr):
(WebCore::setJSTestObjCreate):
(WebCore::setJSTestObjReflectedStringAttr):
(WebCore::setJSTestObjReflectedIntegralAttr):
(WebCore::setJSTestObjReflectedUnsignedIntegralAttr):
(WebCore::setJSTestObjReflectedBooleanAttr):
(WebCore::setJSTestObjReflectedURLAttr):
(WebCore::setJSTestObjReflectedCustomIntegralAttr):
(WebCore::setJSTestObjReflectedCustomBooleanAttr):
(WebCore::setJSTestObjReflectedCustomURLAttr):
(WebCore::setJSTestObjAttrWithGetterException):
(WebCore::setJSTestObjAttrWithSetterException):
(WebCore::setJSTestObjStringAttrWithGetterException):
(WebCore::setJSTestObjStringAttrWithSetterException):
(WebCore::setJSTestObjCustomAttr):
(WebCore::setJSTestObjWithScriptStateAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAttribute):
(WebCore::setJSTestObjWithScriptStateAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute):
(WebCore::setJSTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::setJSTestObjConditionalAttr1):
(WebCore::setJSTestObjConditionalAttr2):
(WebCore::setJSTestObjConditionalAttr3):
(WebCore::setJSTestObjConditionalAttr4Constructor):
(WebCore::setJSTestObjConditionalAttr5Constructor):
(WebCore::setJSTestObjConditionalAttr6Constructor):
(WebCore::setJSTestObjMutablePoint):
(WebCore::setJSTestObjImmutablePoint):
(WebCore::setJSTestObjStrawberry):
(WebCore::setJSTestObjStrictFloat):
(WebCore::setJSTestObjId):
(WebCore::JSTestObj::getConstructor):
(WebCore::jsTestObjPrototypeFunctionVoidMethod):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionIntMethod):
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethod):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithSequenceArg):
(WebCore::jsTestObjPrototypeFunctionMethodReturningSequence):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionSerializedValue):
(WebCore::jsTestObjPrototypeFunctionIdbKey):
(WebCore::jsTestObjPrototypeFunctionOptionsObject):
(WebCore::jsTestObjPrototypeFunctionMethodWithException):
(WebCore::jsTestObjPrototypeFunctionCustomMethod):
(WebCore::jsTestObjPrototypeFunctionCustomMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionAddEventListener):
(WebCore::jsTestObjPrototypeFunctionRemoveEventListener):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoid):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObj):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoidException):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObjException):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContext):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptState):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateObjException):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateWithSpaces):
(WebCore::jsTestObjPrototypeFunctionWithScriptArgumentsAndCallStack):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalString):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsUndefined):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsNullString):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionConditionalMethod1):
(WebCore::jsTestObjPrototypeFunctionConditionalMethod2):
(WebCore::jsTestObjPrototypeFunctionConditionalMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod5):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod6):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod7):
(WebCore::jsTestObjPrototypeFunctionMethodWithUnsignedLongArray):
(WebCore::jsTestObjPrototypeFunctionGetSVGDocument):
(WebCore::jsTestObjPrototypeFunctionConvert1):
(WebCore::jsTestObjPrototypeFunctionConvert2):
(WebCore::jsTestObjPrototypeFunctionConvert3):
(WebCore::jsTestObjPrototypeFunctionConvert4):
(WebCore::jsTestObjPrototypeFunctionConvert5):
(WebCore::jsTestObjPrototypeFunctionMutablePointFunction):
(WebCore::jsTestObjPrototypeFunctionImmutablePointFunction):
(WebCore::jsTestObjPrototypeFunctionOrange):
(WebCore::jsTestObjPrototypeFunctionStrictFunction):
(WebCore::JSTestObjOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestObjOwner::finalize):
(WebCore::toTestObj):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::getOwnPropertySlot):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):
(WebCore::jsTestSerializedScriptValueInterfaceValue):
(WebCore::jsTestSerializedScriptValueInterfaceReadonlyValue):
(WebCore::jsTestSerializedScriptValueInterfaceCachedValue):
(WebCore::jsTestSerializedScriptValueInterfaceCachedReadonlyValue):
(WebCore::jsTestSerializedScriptValueInterfaceConstructor):
(WebCore::setJSTestSerializedScriptValueInterfaceValue):
(WebCore::setJSTestSerializedScriptValueInterfaceCachedValue):
(WebCore::JSTestSerializedScriptValueInterface::getConstructor):
(WebCore::jsTestSerializedScriptValueInterfacePrototypeFunctionAcceptTransferList):
(WebCore::jsTestSerializedScriptValueInterfacePrototypeFunctionMultiTransferList):
(WebCore::JSTestSerializedScriptValueInterfaceOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestSerializedScriptValueInterfaceOwner::finalize):
(WebCore::toTestSerializedScriptValueInterface):

06:24 Changeset [113575] by charles.wei@torchmobile.com.cn

[BlackBerry] Upstream BlackBerry change to WebCore::TouchEvent
https://bugs.webkit.org/show_bug.cgi?id=83454

Reviewed by Rob Buis.

BlackBerry-port enhances the TouchEvent by adding member variables
to indicate if the event is double-tap or touch-hold.

  • dom/TouchEvent.cpp:

(WebCore::TouchEvent::TouchEvent):
(WebCore::TouchEvent::initTouchEvent):

  • dom/TouchEvent.h:

(TouchEvent):
(WebCore::TouchEvent::setDoubleTap):
(WebCore::TouchEvent::isDoubleTap):
(WebCore::TouchEvent::setTouchHold):
(WebCore::TouchEvent::isTouchHold):

06:20 PrefixedAPIs edited by chutten@rim.com
CSS Properties added sourced from CSSProperty::isInheritedProperty (diff)
05:35 Changeset [113574] by paroga@webkit.org

[CMake] Build fix for USE_SYSTEM_MALLOC after r113570.

.:

  • Source/cmakeconfig.h.cmake:

Source/WTF:

  • wtf/CMakeLists.txt:
04:42 Changeset [113573] by commit-queue@webkit.org

Remove partially implemented per-Element visibility checks from requestAnimationFrame logic
https://bugs.webkit.org/show_bug.cgi?id=74232

Patch by James Robinson <jamesr@chromium.org> on 2012-04-09
Reviewed by Dean Jackson.

Source/WebCore:

The initial requestAnimationFrame implementation had an Element parameter as the second argument to the
function. This element was intended to convey the element associated with the animation so that when the element
was not visible the animation callback would not be run. The checked in implementation does a very limited check

  • testing for display:none and being detached from the tree - but does it in a way that does not work correctly

if an element's visibility is manipulated by a callback running from a different document. It also adds
significant complexity to the code, making it less hackable and easy to introduce subtle security bugs or
infinite loops.

This patch removes the parameter. Since it has always been marked optional, there is no web compat risk.

If this functionality is added back in the future it needs to be implemented in a way that considers all
callbacks within a Page and not only those within a single Document.

  • dom/Document.cpp:

(WebCore::Document::webkitRequestAnimationFrame):

  • dom/Document.h:
  • dom/RequestAnimationFrameCallback.h:
  • dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::registerCallback):
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):

  • dom/ScriptedAnimationController.h:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::webkitRequestAnimationFrame):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:

LayoutTests:

Remove tests for removed functionality.

  • fast/animation/request-animation-frame-display-expected.txt: Removed.
  • fast/animation/request-animation-frame-display.html: Removed.
  • fast/animation/script-tests/request-animation-frame-display.js: Removed.
03:58 Changeset [113572] by paroga@webkit.org

Build fix for WinCE after r113570.

  • Scripts/build-webkit: Do not use FastMalloc for WinCE.
03:49 Changeset [113571] by paroga@webkit.org

Remove HAVE_STDINT_H
https://bugs.webkit.org/show_bug.cgi?id=83434

Reviewed by Kentaro Hara.

HAVE_STDINT_H is defined with 1 all the time and we us stdint.h without HAVE(STDINT_H) already.

Source/JavaScriptCore:

  • config.h:

Source/WTF:

  • config.h:
  • wtf/FastMalloc.cpp:
  • wtf/TCPageMap.h:
  • wtf/TCSpinLock.h:
  • wtf/TCSystemAlloc.cpp:
03:45 Changeset [113570] by paroga@webkit.org

[CMake] Share build system options across ports
https://bugs.webkit.org/show_bug.cgi?id=72815

Reviewed by Daniel Bates.

Don't define the generic features for every port again.
Add a few macros for reusing the central defined options.

  • CMakeLists.txt:
  • Source/cmake/OptionsBlackBerry.cmake:
  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsWinCE.cmake:
  • Source/cmake/WebKitFeatures.cmake:
03:33 Changeset [113569] by commit-queue@webkit.org

[Blackberry] m_isRequestedByPlugin should be copied in ResourceRequest
https://bugs.webkit.org/show_bug.cgi?id=83447

Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-04-09
Reviewed by George Staikos.

It is an obvious error, We should copy m_isRequestedByPlugin in ResourceReuest.

No new tests, because those existing plugin test cases are enough.

  • platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::ResourceRequest::doPlatformCopyData):
(WebCore::ResourceRequest::doPlatformAdopt):

03:19 Changeset [113568] by eric.carlson@apple.com

Subscribe eric.carlson@apple.com to Media-related changes
https://bugs.webkit.org/show_bug.cgi?id=83421

Reviewed by Dan Bernstein.

  • Scripts/webkitpy/common/config/watchlist:
03:02 Changeset [113567] by fischman@chromium.org

Layout Test http/tests/media/media-document.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=83391

[Chromium] Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
02:50 Changeset [113566] by fischman@chromium.org

several http tests are flaky and crashing on win, debug
https://bugs.webkit.org/show_bug.cgi?id=82505

Remove the expectations of a crash now that the fix (http://crrev.com/131170)
has rolled into webkit in http://trac.webkit.org/changeset/113512

Reviewed by Tony Chang.

  • platform/chromium/test_expectations.txt:
02:48 Changeset [113565] by commit-queue@webkit.org

check-webkit-style should ignore NULL usage in gtk_style_context_get_style
https://bugs.webkit.org/show_bug.cgi?id=83412

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-04-09
Reviewed by David Levin.

Accept NULL as an argument for gtk_style_context_get_style, because it's
used as a sentinel in a variable argument list.

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_for_null): Add an exception.

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(WebKitStyleTest.test_null_false_zero): Add a test for the exception.

02:42 Changeset [113564] by pfeldman@chromium.org

Not reviewed: fixing inspector front-end compilation that has been broken by the
recent SaveAs and DOMStorage changes.

  • inspector/front-end/DOMStorage.js:
  • inspector/front-end/externs.js:

(WebInspector.isURLSaved):

02:39 Changeset [113563] by pfeldman@chromium.org

Web Inspector: remove ComboBoxFileSelector and SingleFileEditorContainer.
https://bugs.webkit.org/show_bug.cgi?id=83460

Reviewed by Yury Semikhatsky.

Source/WebCore:

We are now using scripts navigator and tabbed editor container, removing the old components.
This change removes the corresponding classes and the abstractions used during the
transition period.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator.prototype._scriptSelected):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.get this):
(WebInspector.ScriptsPanel.prototype.get defaultFocusedElement):
(WebInspector.ScriptsPanel.prototype._addUISourceCode):
(WebInspector.ScriptsPanel.prototype.setScriptSourceIsDirty):
(WebInspector.ScriptsPanel.prototype._reset):
(WebInspector.ScriptsPanel.prototype._showFile):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):
(WebInspector.ScriptsPanel.prototype._editorClosed):
(WebInspector.ScriptsPanel.prototype._scriptSelected):
(WebInspector.ScriptsPanel.prototype._hidePinnedNavigator):
(WebInspector.ScriptsPanel.prototype.set _pinNavigator):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen):

  • inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainerDelegate):
(WebInspector.TabbedEditorContainerDelegate.prototype.viewForFile):
(get WebInspector):
(WebInspector.TabbedEditorContainer.prototype._tabClosed):

  • inspector/front-end/scriptsPanel.css:

LayoutTests:

  • inspector/debugger/scripts-combobox-file-selector-history-expected.txt: Removed.
  • inspector/debugger/scripts-combobox-file-selector-history.html: Removed.
  • inspector/debugger/scripts-file-selector-expected.txt:
  • inspector/debugger/scripts-file-selector.html:
  • inspector/debugger/scripts-panel-expected.txt:
  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/scripts-sorting-expected.txt:
  • inspector/debugger/scripts-sorting.html:
  • inspector/debugger/source-frame-count.html:
02:22 Changeset [113562] by dpranke@chromium.org

webkitpy: use the filesystem object properly in fileuploader
https://bugs.webkit.org/show_bug.cgi?id=83326

Reviewed by Adam Barth.

We should be using the filesystem object rather than the codecs
object.

  • Scripts/webkitpy/common/net/file_uploader.py:

(FileUploader.upload_as_multipart_form_data):

02:05 Changeset [113561] by commit-queue@webkit.org

[chromium] Make culling work with clipped rects
https://bugs.webkit.org/show_bug.cgi?id=83217

Patch by Dana Jansens <danakj@chromium.org> on 2012-04-09
Reviewed by Adrienne Walker.

Source/WebCore:

Use new CCMathUtil transformation methods to deal with rects that clip
the camera plane. This fixes three things:

  1. A layer completely behind the camera is not visible and should not

occlude.

  1. A layer that is clipped by the camera is treated like a

non-axis-aligned transform, as the result of a mapClippedRect() is a
bounding box and may contain pixels not in the original rect. This guards
our use of mapRect() when transforming occluded regions.

  1. A layer's occlusion must be clipped by its scissor rect. This scissor

rect exists in its target space, so occlusion in screen space is only
possible if its target also is axis aligned in the screen, such that
the layer's scissor rect remains a rect in screen space.

Unit tests: CCOcclusionTrackerTestLayerBehindCameraDoesNotOcclude

CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::transformSurfaceOpaqueRegion):
(WebCore::computeOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):
(WebCore::testContentRectOccluded):
(WebCore::computeUnoccludedContentRect):

Source/WebKit/chromium:

  • tests/CCOcclusionTrackerTest.cpp:

(CCOcclusionTrackerTestLayerBehindCameraDoesNotOcclude):
(WebKitTests::CCOcclusionTrackerTestLayerBehindCameraDoesNotOcclude::runMyTest):
(WebKitTests):
(CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect):
(WebKitTests::CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect::runMyTest):

  • tests/CCQuadCullerTest.cpp:

(WebCore::TestCCOcclusionTrackerImpl::TestCCOcclusionTrackerImpl):

01:49 Changeset [113560] by commit-queue@webkit.org

[Gtk] Web Inspector noinst_DATA images are copied into innacurately named directory
https://bugs.webkit.org/show_bug.cgi?id=83423

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-04-09
Reviewed by Martin Robinson.

Copy Web Inspector images that are a part of the data not meant
for installation into a directory named 'Images' rather than
a lower-case version of that. This is required as until now,
when using these inspector resources (for example during layout
tests or manually pointing WEBKIT_INSPECTOR_PATH env to that
location), the images were not displayed as they were not loadable.

No new tests - no new functionality.

  • GNUmakefile.am:
00:55 Changeset [113559] by eric@webkit.org

Enable webkit_unit_tests for commit queue and EWS while tracking failures
https://bugs.webkit.org/show_bug.cgi?id=83329

Unreviewed. Add a missing import to unbreak all the Chromium EWS/CQ bots. :)

line 62, in _create_unit_test_results

return UnitTestResults.results_from_string(results_xml)
NameError: global name 'UnitTestResults' is not defined

  • Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
  • Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:

(LayoutTestResultsReaderTest.test_create_unit_test_results):

00:50 Changeset [113558] by pfeldman@chromium.org

Web Inspector: move breakpoints active state from scripts panel to debugger presentation model.
https://bugs.webkit.org/show_bug.cgi?id=83374

Reviewed by Yury Semikhatsky.

Source/WebCore:

Just moves the state and adds event to propagate it. This is needed to abstract
JavaScriptSourceFrame from the ScriptsPanel.

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpointsActive):
(WebInspector.DebuggerPresentationModel.prototype.breakpointsActive):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype._setBreakpoint):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._toggleBreakpointsClicked):
(WebInspector.ScriptsPanel.prototype._breakpointsActiveStateChanged):
(WebInspector.ScriptsPanel.prototype._createDebugToolbar):

LayoutTests:

  • http/tests/inspector/debugger-test.js:
  • inspector/debugger/debugger-breakpoints-not-activated-on-reload.html:
00:48 Changeset [113557] by fpizlo@apple.com

DFG should not load the property storage if it is inline.
https://bugs.webkit.org/show_bug.cgi?id=83455

Reviewed by Gavin Barraclough.

We had previously decided to have all property storage accesses go through
the property storage pointer even if they don't "really" have to, because
we were thinking this would help GC barriers somehow. Well, we never ended
up doing anything with that. Hence, doing these wasted loads of the
property storage pointer when the storage is inline is just a waste of CPU
cycles.

This change makes the DFG's inline property accesses (GetByOffset and
PutByOffset) go directly to the inline property storage if the structure(s)
tell us that it's OK.

This looks like an across-the-board 1% win.

  • bytecode/StructureSet.h:

(JSC):
(JSC::StructureSet::allAreUsingInlinePropertyStorage):
(StructureSet):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::fillStorage):

04/08/12:

22:25 Changeset [113556] by mitz@apple.com

[mac] REGRESSION (r113467): Some canvas tests are failing in WebKit1 when run after compositing/tiled-layers-hidpi.html
https://bugs.webkit.org/show_bug.cgi?id=83453

Reviewed by Sam Weinig.

  • WebView/WebView.mm:

(-[WebView _setCustomBackingScaleFactor:]): When the scale factor parameter was 0, meaning
no custom scale factor, this method was setting the Page scale factor to 0, and that value
was used by canvas. Changed it to correctly set the Page scale factor back to the device
scale factor.

21:59 Changeset [113555] by commit-queue@webkit.org

<content> in <meter> is not rendered correctly.
https://bugs.webkit.org/show_bug.cgi?id=81311

This code changes a code location where MeterValueElement's value
attribute is initialized. In the old code, HTMLMeterElement's attach
did. It is better to initialize the attribute just after creating
meter's shadow subtree.

Patch by Takashi Sakamoto <tasak@google.com> on 2012-04-08
Reviewed by Hajime Morita.

No new tests, because an existing test,
content-element-in-meter-element.html covers.
However test_expectations.txt is changed. Now the test passes.

  • html/HTMLMeterElement.cpp:
  • html/HTMLMeterElement.h:

(HTMLMeterElement):
(HTMLMeterElement::attach):
Removed attach method, because attach method is just calling
LabelableElement::attach after removing didElementStateChange.
(HTMLMeterElement::createShadowSubTree):
Added setWidthPercentage to initialize MeterValueElement's value
attribute.

  • LayoutTests/platform/chromium/test_expectations.txt:

Removed BUGWK81311 fast/dom/shadow/content-element-in-meter.html,
because now contentElementInMeterElement passes.

21:04 Changeset [113554] by abarth@webkit.org

The port object is missing unit_tests_results_path
https://bugs.webkit.org/show_bug.cgi?id=83448

Unreviewed.

This is causing the cr-linux-ews to throw an exception.

  • Scripts/webkitpy/common/config/ports.py:

(DeprecatedPort.unit_tests_results_path):

13:50 Changeset [113553] by fpizlo@apple.com

Command-line jsc's exception handling should be rationalized
https://bugs.webkit.org/show_bug.cgi?id=83437

Reviewed by Dan Bernstein.

  • If an exception is thrown during run() execution, it is now propagated, so that it will terminate program execution unless it is caught.


  • If program execution terminates with an exception, the exception is now always printed.


  • When printing the exception, the backtrace is now also printed if one is available. It will only not be available if you use something akin to my favorite line of code, 'throw "error"', since primitives don't have properties and hence we cannot attach a "stack" property to them.
  • jsc.cpp:

(functionRun):
(runWithScripts):

13:46 Changeset [113552] by fpizlo@apple.com

Forced OSR exits should lead to recompilation based on count, not rate
https://bugs.webkit.org/show_bug.cgi?id=83247
<rdar://problem/10720925>

Reviewed by Geoff Garen.

Track which OSR exits happen because of inadequate coverage. Count them
separately. If the count reaches a threshold, immediately trigger
reoptimization.

This is in contrast to the recompilation trigger for all other OSR exits.
Normally recomp is triggered when the exit rate exceeds a certain ratio.

Looks like a slight V8 speedup (sub 1%).

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::forcedOSRExitCounter):
(JSC::CodeBlock::addressOfForcedOSRExitCounter):
(JSC::CodeBlock::offsetOfForcedOSRExitCounter):
(JSC::CodeBlock::shouldReoptimizeNow):
(JSC::CodeBlock::shouldReoptimizeFromLoopNow):
(CodeBlock):

  • bytecode/DFGExitProfile.h:

(JSC::DFG::exitKindToString):

  • dfg/DFGOSRExitCompiler.cpp:

(JSC::DFG::OSRExitCompiler::handleExitCounts):
(DFG):

  • dfg/DFGOSRExitCompiler.h:

(OSRExitCompiler):

  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOperations.cpp:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • runtime/Options.cpp:

(Options):
(JSC::Options::initializeOptions):

  • runtime/Options.h:

(Options):

13:38 PrefixedAPIs edited by jhawkins@chromium.org
(diff)
11:35 Changeset [113551] by paroga@webkit.org

Build fix for !ENABLE(CSS_FILTERS) && ASSERT_DISABLED after r109953.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

04/07/12:

20:45 Changeset [113550] by scherkus@chromium.org

2012-04-07 Andrew Scherkus <scherkus@chromium.org>

[Chromium] Unreviewed, checking in baselines for video-frame-size-change.html.

  • platform/chromium-linux/platform/chromium/compositing/video-frame-size-change-expected.png: Added.
  • platform/chromium-linux/platform/chromium/media/video-frame-size-change-expected.png: Added.
  • platform/chromium-mac-leopard/platform/chromium/compositing/video-frame-size-change-expected.png: Added.
  • platform/chromium-mac-leopard/platform/chromium/media/video-frame-size-change-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/video-frame-size-change-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/media/video-frame-size-change-expected.png: Added.
  • platform/chromium-mac/platform/chromium/compositing/video-frame-size-change-expected.png: Added.
  • platform/chromium-mac/platform/chromium/compositing/video-frame-size-change-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/media/video-frame-size-change-expected.png: Added.
  • platform/chromium-mac/platform/chromium/media/video-frame-size-change-expected.txt: Added.
  • platform/chromium-win/platform/chromium/compositing/video-frame-size-change-expected.png: Added.
  • platform/chromium-win/platform/chromium/compositing/video-frame-size-change-expected.txt: Added.
  • platform/chromium-win/platform/chromium/media/video-frame-size-change-expected.png: Added.
  • platform/chromium-win/platform/chromium/media/video-frame-size-change-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:47 Changeset [113549] by jonlee@apple.com

Added fast/canvas/webgl/array-message-passing.html to skipped tests on mac.
Tracked by https://bugs.webkit.org/show_bug.cgi?id=83427

  • platform/mac/Skipped:
10:14 Changeset [113548] by paroga@webkit.org

[CMake] Cleanup WTF include directories
https://bugs.webkit.org/show_bug.cgi?id=82716

Reviewed by Eric Seidel.

Source/WebCore:

  • CMakeLists.txt:

Source/WebKit:

  • CMakeLists.txt:

Source/WebKit2:

  • CMakeLists.txt:

Tools:

  • DumpRenderTree/efl/CMakeLists.txt:
  • WinCELauncher/CMakeLists.txt:
08:48 PrefixedAPIs edited by simon.fraser@apple.com
(diff)
08:48 PrefixedAPIs edited by simon.fraser@apple.com
(diff)
08:30 Changeset [113547] by rwlbuis@webkit.org

[BlackBerry] Add Battery Status API support
https://bugs.webkit.org/show_bug.cgi?id=82615

Reviewed by George Staikos.

.:

Enable BATTERY_STATUS.

  • Source/cmake/OptionsBlackBerry.cmake:

Source/WebKit:

Add BatteryClientBlackBerry.cpp to the build.

  • PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

Add client implementation for Battery API.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init): initialize BatteryClient.

  • WebCoreSupport/BatteryClientBlackBerry.cpp: Added.

(WebCore):
(WebCore::BatteryClientBlackBerry::BatteryClientBlackBerry):
(WebCore::BatteryClientBlackBerry::setController):
(WebCore::BatteryClientBlackBerry::startUpdating):
(WebCore::BatteryClientBlackBerry::stopUpdating):
(WebCore::BatteryClientBlackBerry::batteryControllerDestroyed):
(WebCore::BatteryClientBlackBerry::onLevelChange):
(WebCore::BatteryClientBlackBerry::onChargingChange):
(WebCore::BatteryClientBlackBerry::onChargingTimeChange):
(WebCore::BatteryClientBlackBerry::onDischargingTimeChange):

  • WebCoreSupport/BatteryClientBlackBerry.h: Added.

(WebCore):
(BatteryClientBlackBerry):
(WebCore::BatteryClientBlackBerry::~BatteryClientBlackBerry):

Tools:

Enable BATTERY_STATUS.

  • Scripts/build-webkit:
07:31 Changeset [113546] by rwlbuis@webkit.org

Remove dead code in SVGCSSParser
https://bugs.webkit.org/show_bug.cgi?id=83404

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Remove code that was there to create a SVGColor representation for color, but was never reached. Since
SVGColor is deprecated now (also see bug 15012), this code has lost any potential. Should SVGColor come
back in SVG2 we can revisit this.

Add a test to confirm for SVG we follow the CSS3 handling of color="currentColor". This is something the
removed code never dealt with, but the existing code in CSSParser.cpp handles, make sure we stick to this
behaviour in the future using this test.

Test: svg/custom/currentColor-on-color.html

  • css/SVGCSSParser.cpp:

(WebCore::CSSParser::parseSVGValue):

LayoutTests:

Test that we support color="currentColor" in SVG. This follows from the CSS3 spec, see
http://www.w3.org/TR/css3-color/#currentcolor. This matches FF behaviour.

  • svg/custom/currentColor-on-color-expected.txt: Added.
  • svg/custom/currentColor-on-color.html: Added.
  • svg/custom/script-tests/currentColor-on-color.js: Added.
06:13 Changeset [113545] by ossy@webkit.org

[Qt] Unreviewed Easter gardening, skip new failing tests to paint the bots green.

  • platform/qt/Skipped:
01:21 Changeset [113544] by zimmermann@webkit.org

2012-04-07 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Rebaseline three results on Lion, so my baseline passes with tolerance 0 again.

  • platform/mac/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png: Images have wrong colorspace in those results.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png: Ditto.
  • platform/mac/svg/carto.net/selectionlist-expected.png: Ditto.
01:09 Changeset [113543] by zimmermann@webkit.org

2012-04-07 Nikolas Zimmermann <nzimmermann@rim.com>

FrameData constructor zeroes all fields, causing ImageOrientation to be 0
https://bugs.webkit.org/show_bug.cgi?id=83416

Inofficially rubber-stamped by Tim Horton.

Lots of svg/as-image/ crash on debug builds. FrameData is used in a Vector and currently
special VectorTraits force it to be initialized with memset(), nulling all members, instead
of properly initializing them causing the ImageOrientation bug. To be able to remove the
SimpleClassVectorTraits specialization, we have to allow FrameData to be copied.

  • platform/graphics/BitmapImage.h:
00:38 Changeset [113542] by zimmermann@webkit.org

2012-04-07 Nikolas Zimmermann <nzimmermann@rim.com>

Work around an entity parsing bug in libxml2 2.7.3 (supplied with Lion) and unskip tests
https://bugs.webkit.org/show_bug.cgi?id=82577

Reviewed by Filip Pizlo.

Unskip several tests on Lion, now that the libxml2 bug doesn't affect us anymore.

  • platform/mac-lion/Skipped:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
  • platform/mac/svg/custom/preserve-aspect-ratio-syntax-expected.png:
  • platform/mac/svg/custom/preserve-aspect-ratio-syntax-expected.txt:
  • platform/mac/svg/custom/viewbox-syntax-expected.png:
  • platform/mac/svg/custom/viewbox-syntax-expected.txt:
  • platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
  • platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
  • platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:

2012-04-07 Nikolas Zimmermann <nzimmermann@rim.com>

Work around an entity parsing bug in libxml2 2.7.3 (supplied with Lion) and unskip tests
https://bugs.webkit.org/show_bug.cgi?id=82577

Reviewed by Filip Pizlo.

Work-around entity expansion bug that affects several SVG tests on Lion.

Sample test document which is currently broken:
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE svg PUBLIC "-W3CDTD SVG 1.1 BasicEN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11-basic.dtd" [
<!ENTITY Smile "<rect x='.5' y='.5' width='29' height='39' fill='black' stroke='red'/>">
]>

<svg xmlns="http://www.w3.org/2000/svg">&Smile;</svg>

The expanded rect carries no namespace, thus an Element will be created for it, instead of a SVGRectElement.
libxml2 2.7.4 fixed this bug (https://bugzilla.gnome.org/show_bug.cgi?id=502960) in 2009 already, but Lion
still ships with 2.7.3, so we need to find a work-around for the problem. It works like this:

  • When an entity is requested (getEntityHandler) determine whether the entity is being declared (while the <!ENTITY.. parses) or wheter its references (when the &Smile; is parsed). If its referenced, record the current depth of the libxml2 parser.
  • When startElementNs is called while we're expanding entities, be sure to transfer the namespace of the parent node to the new node, but only do this if the current depth() is greater than the depth() at the time where entity expansion started. This way we only apply our workaround for elements inside entities, that get expanded at the insertion point.
  • When endElementNs is called, and our current depth() is less than our equal to the depth() where entity expansion started, clear the recorded detph(), and stop executing the workaround.

It requires storing an extra integer & boolean in XMLDocumentParser, which is only used for this work-around.

  • xml/parser/XMLDocumentParser.h: (XMLDocumentParser): (WebCore::XMLDocumentParser::isParsingEntityDeclaration): (WebCore::XMLDocumentParser::setIsParsingEntityDeclaration): (WebCore::XMLDocumentParser::depthTriggeringEntityExpansion): (WebCore::XMLDocumentParser::setDepthTriggeringEntityExpansion):
  • xml/parser/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::hackAroundLibXMLEntityParsingBug): (WebCore::XMLDocumentParser::startElementNs): (WebCore::XMLDocumentParser::endElementNs): (WebCore::entityDeclarationHandler): (WebCore::getEntityHandler): (WebCore::XMLDocumentParser::initializeParserContext):

04/06/12:

22:47 Changeset [113541] by mrowe@apple.com

Versioning.

22:38 Changeset [113540] by mrowe@apple.com

New tag.

20:28 Changeset [113539] by commit-queue@webkit.org

Unreviewed, rolling out r113526.
http://trac.webkit.org/changeset/113526
https://bugs.webkit.org/show_bug.cgi?id=83417

speculative rollout for broken chrome browser_test (Requested
by simonjam on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-06

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::stopLoading):
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::setupForReplaceByMIMEType):
(WebCore):
(WebCore::DocumentLoader::setParsedArchiveData):
(WebCore::DocumentLoader::scheduleArchiveLoad):
(WebCore::DocumentLoader::documentURL):

  • loader/DocumentLoader.h:

(DocumentLoader):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::receivedFirstData):
(WebCore::FrameLoader::loadArchive):
(WebCore::FrameLoader::stopAllLoaders):
(WebCore::FrameLoader::finishedLoadingDocument):
(WebCore):

  • loader/FrameLoader.h:

(FrameLoader):
(WebCore::FrameLoader::archive):

19:13 Changeset [113538] by commit-queue@webkit.org

[chromium] Avoid deleting impl tree when becoming invisible
https://bugs.webkit.org/show_bug.cgi?id=83396

Patch by James Robinson <jamesr@chromium.org> on 2012-04-06
Reviewed by Adrienne Walker.

This bit of code in CCLayerTreeHost::didBecomeInvisible..() was an attempt to drop resources when becoming
invisible. However, it's fairly confused - we drop textures via TextureManagers when going invisible and
CCLayerImpl destructors can't delete non-managed resources since they do not have access to a context - so this
code was never actually freeing up GPU resources. Having a sometimes-null CCLayerImpl tree when we still have a
valid LayerChromium tree has lead to various tricky bugs.

No new tests since this code wasn't doing anything useful in the first place.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):

19:06 Changeset [113537] by leo.yang@torchmobile.com.cn

LocalFileSystem::initializeLocalFileSystem should be static
https://bugs.webkit.org/show_bug.cgi?id=83356

Reviewed by Rob Buis.

LocalFileSystem::initializeLocalFileSystem should be static because
static LocalFileSystem::localFileSystem() requires initializeLocalFileSystem()
is called before it gets called.

No functionalities changed, no new tests.

  • Modules/filesystem/LocalFileSystem.h:

(LocalFileSystem):

19:04 Changeset [113536] by scherkus@chromium.org

2012-04-06 Andrew Scherkus <scherkus@chromium.org>

[chromium] Add layout tests that exercise rendering path for videos that have changing resolutions.
https://bugs.webkit.org/show_bug.cgi?id=83383

Reviewed by James Robinson.

  • platform/chromium/compositing/video-frame-size-change.html: Added.
  • platform/chromium/media/video-frame-size-change.html: Changed from dumpAsText() to pixel test
19:02 Changeset [113535] by dpranke@chromium.org

clone baselines from platform/win to platform/chromium-win
https://bugs.webkit.org/show_bug.cgi?id=83394

Unreviewed, baselines update.

Removes a bunch of "generic" baselines that were mistakenly
cloned in r113509. I forgot to filter out the baselines that
were for win-specific tests, as opposed to win-specific
baselines for generic tests.

  • platform/chromium-win/accessibility/detached-object-notification-crash-expected.txt: Removed.
  • platform/chromium-win/accessibility/document-enabled-state-expected.txt: Removed.
  • platform/chromium-win/accessibility/document-role-expected.txt: Removed.
  • platform/chromium-win/accessibility/focus-events-expected.txt: Removed.
  • platform/chromium-win/accessibility/heading-elements-expected.txt: Removed.
  • platform/chromium-win/accessibility/img-alt-attribute-expected.txt: Removed.
  • platform/chromium-win/accessibility/linked-elements-expected.txt: Removed.
  • platform/chromium-win/accessibility/list-item-role-expected.txt: Removed.
  • platform/chromium-win/accessibility/list-marker-role-expected.txt: Removed.
  • platform/chromium-win/accessibility/list-role-expected.txt: Removed.
  • platform/chromium-win/accessibility/multiple-select-element-role-expected.txt: Removed.
  • platform/chromium-win/accessibility/option-element-position-and-size-expected.txt: Removed.
  • platform/chromium-win/accessibility/option-element-selection-and-focus-events-expected.txt: Removed.
  • platform/chromium-win/accessibility/parent-element-expected.txt: Removed.
  • platform/chromium-win/accessibility/scroll-to-anchor-expected.txt: Removed.
  • platform/chromium-win/accessibility/select-element-role-expected.txt: Removed.
  • platform/chromium-win/accessibility/select-element-valuechange-event-expected.txt: Removed.
  • platform/chromium-win/accessibility/selection-and-focus-expected.txt: Removed.
  • platform/chromium-win/accessibility/single-select-children-changed-expected.txt: Removed.
  • platform/chromium-win/accessibility/single-select-children-expected.txt: Removed.
  • platform/chromium-win/accessibility/text-role-expected.txt: Removed.
  • platform/chromium-win/editing/selection/doubleclick-should-not-expand-across-lines-expected.txt: Removed.
  • platform/chromium-win/editing/selection/shift-page-up-down-expected.txt: Removed.
  • platform/chromium-win/fast/events/alt-numpad-expected.txt: Removed.
  • platform/chromium-win/fast/events/alt-space-scroll-expected.txt: Removed.
  • platform/chromium-win/fast/events/context-click-events-expected.txt: Removed.
  • platform/chromium-win/fast/events/double-dead-char-expected.txt: Removed.
  • platform/chromium-win/fast/events/keyLocation-numpad-expected.txt: Removed.
  • platform/chromium-win/fast/events/panScroll-correct-direction-expected.txt: Removed.
  • platform/chromium-win/fast/events/panScroll-event-fired-expected.txt: Removed.
  • platform/chromium-win/fast/events/panScroll-image-no-scroll-expected.txt: Removed.
  • platform/chromium-win/fast/events/panScroll-imageMap-href-no-scroll-expected.txt: Removed.
  • platform/chromium-win/fast/events/panScroll-imageMap-noHref-scroll-expected.txt: Removed.
  • platform/chromium-win/fast/events/panScroll-nested-divs-expected.txt: Removed.
  • platform/chromium-win/fast/events/panScroll-no-iframe-jump-expected.txt: Removed.
  • platform/chromium-win/fast/events/panScroll-preventDefault-expected.txt: Removed.
  • platform/chromium-win/fast/text/uniscribe-item-boundary-crash-expected.txt: Removed.
  • platform/chromium-win/fast/text/uniscribe-missing-glyph-expected.txt: Removed.
  • platform/chromium-win/inverted-colors/non-composited-expected.png: Removed.
  • platform/chromium-win/inverted-colors/non-composited-expected.txt: Removed.
  • platform/chromium-win/platform/win/plugins/draws-gradient-expected.png: Removed.
  • platform/chromium-win/platform/win/plugins/draws-gradient-expected.txt: Removed.
  • platform/chromium-win/plugins/call-javascript-that-destroys-plugin-expected.txt: Removed.
  • platform/chromium-win/plugins/get-value-netscape-window-expected.txt: Removed.
  • platform/chromium-win/plugins/iframe-inside-overflow-expected.txt: Removed.
  • platform/chromium-win/plugins/npn-invalidate-rect-invalidates-window-expected.txt: Removed.
  • platform/chromium-win/plugins/visibility-hidden-expected.png: Removed.
  • platform/chromium-win/plugins/visibility-hidden-expected.txt: Removed.
  • platform/chromium-win/plugins/window-geometry-initialized-before-set-window-expected.txt: Removed.
  • platform/chromium-win/plugins/window-region-is-set-to-clip-rect-expected.txt: Removed.
  • platform/chromium-win/plugins/windowless-paint-rect-coordinates-expected.txt: Removed.
18:59 PrefixedAPIs edited by dcheng@chromium.org
(diff)
18:54 Changeset [113534] by simonjam@chromium.org

[Chromium] Unreviewed gardening.

  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt: Added.
18:25 Changeset [113533] by commit-queue@webkit.org

[GTK] Accelerated compositing is broken after recent TextureMapper reorganizations
https://bugs.webkit.org/show_bug.cgi?id=83393

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-04-06
Reviewed by Noam Rosenthal.

Source/WebCore:

No new tests. This will be covered by existing accelerated compositing tests
once the implementation is complete.

The GTK+ implementation doesn't clip currently, so hold off enabling the
scissor test until necessary.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::beginPainting): Do not enable the scissor test.
(WebCore::TextureMapperGL::beginScissorClip): Enable the scissor test once
we know for sure we will be using scissored clipping.

Source/WebKit/gtk:

Ensure that the layer tree is synced when the root layer is resized.

  • WebCoreSupport/AcceleratedCompositingContextGL.cpp:

(WebKit::AcceleratedCompositingContext::resizeRootLayer): Ensure that the layer
tree is synced when the root layer resizes and remove a call to recomposite
the tree, as it happens anyway.

18:18 PrefixedAPIs edited by jamesr@google.com
(diff)
18:17 Changeset [113532] by keishi@webkit.org

Remove obsolete parts of <datalist> support code
https://bugs.webkit.org/show_bug.cgi?id=83117

Source/WebCore:

Removing HTMLInputElement::selectedOption because it was removed from the specification.
Removing -webkit-appearance:list-button and -webkit-input-list-button pseudo selector
related code because we decided not to use it.

Reviewed by Kent Tamura.

  • WebCore.order:
  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):

  • css/CSSSelector.h:
  • css/CSSValueKeywords.in:
  • css/html.css:

(datalist):

  • html/HTMLInputElement.cpp:
  • html/HTMLInputElement.h:

(HTMLInputElement):

  • html/HTMLInputElement.idl:
  • inspector/front-end/SourceCSSTokenizer.js:

(WebInspector.SourceCSSTokenizer):

  • inspector/front-end/SourceCSSTokenizer.re2js:
  • inspector/front-end/StylesSidebarPane.js:
  • platform/ThemeTypes.h:
  • platform/chromium/ThemeChromiumMac.mm:

(WebCore::setupButtonCell):
(WebCore::paintButton):
(WebCore::ThemeChromiumMac::controlSize):
(WebCore::ThemeChromiumMac::minimumControlSize):
(WebCore::ThemeChromiumMac::controlBorder):
(WebCore::ThemeChromiumMac::paint):

  • platform/mac/ThemeMac.mm:

(WebCore::setUpButtonCell):
(WebCore::paintButton):
(WebCore::ThemeMac::controlSize):
(WebCore::ThemeMac::minimumControlSize):
(WebCore::ThemeMac::controlBorder):
(WebCore::ThemeMac::paint):

  • platform/qt/RenderThemeQtMobile.cpp:

(WebCore::RenderThemeQtMobile::computeSizeBasedOnStyle):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::paintBorderOnly):
(WebCore::RenderTheme::paintDecorations):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::adjustRepaintRect):

LayoutTests:

Removed tests for HTMLInputElement.selectedOption and -webkit-appearance:list-button.

Reviewed by Kent Tamura.

  • fast/forms/datalist/input-selectedoption-expected.txt: Removed.
  • fast/forms/datalist/input-selectedoption.html: Removed.
  • platform/chromium-linux/fast/forms/datalist/input-selectedoption-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/datalist/input-selectedoption-expected.png: Removed.
  • platform/chromium-mac/fast/forms/datalist/input-selectedoption-expected.png: Removed.
  • platform/chromium-mac/fast/forms/datalist/input-selectedoption-expected.txt: Removed.
  • platform/chromium-win/fast/forms/datalist/input-selectedoption-expected.png: Removed.
  • platform/chromium-win/fast/forms/datalist/input-selectedoption-expected.txt: Removed.
  • platform/chromium-win/platform/mac/fast/forms/input-list-button-size-expected.png: Removed.
  • platform/gtk/fast/forms/input-selectedoption-expected.txt: Removed.
  • platform/mac-leopard/fast/forms/input-list-button-size-expected.png: Removed.
  • platform/mac/Skipped:
  • platform/mac/fast/forms/input-list-button-size-expected.png: Removed.
  • platform/mac/fast/forms/input-list-button-size-expected.txt: Removed.
  • platform/mac/fast/forms/input-list-button-size.html: Removed.
18:16 PrefixedAPIs edited by rniwa@webkit.org
Add specifications for mutation observers API and drag & drop API (diff)
18:12 Changeset [113531] by fischman@chromium.org

Subscribe feature-media-reviews@c.o to Media-related changes.
https://bugs.webkit.org/show_bug.cgi?id=83397

Reviewed by David Levin.

  • Scripts/webkitpy/common/config/committers.py:
  • Scripts/webkitpy/common/config/watchlist:
18:12 Changeset [113530] by benjamin@webkit.org

Do not abuse ArrayStorage's m_length for testing array consistency
https://bugs.webkit.org/show_bug.cgi?id=83403

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-06
Reviewed by Geoffrey Garen.

Array creation from a list of values is a 3 steps process:
-JSArray::tryCreateUninitialized()
-JSArray::initializeIndex() for each values
-JSArray::completeInitialization()

Previously, the attribute m_length was not set to the final size
JSArray::tryCreateUninitialized() because it was used to test the array
consistency JSArray::initializeIndex().

This caused the initialization loop using JSArray::initializeIndex() maintain
two counters:
-index of the loop
-storage->m_length++

This patch fixes this by using the index of the initialization loop for the indinces of
JSArray::initializeIndex(). For testing consistency, the variable m_initializationIndex
is introduced if CHECK_ARRAY_CONSISTENCY is defined.

The patch also fixes minor unrelated build issue when CHECK_ARRAY_CONSISTENCY is defined.

This improves the performance of JSArray creation from literals by 8%.

  • runtime/JSArray.cpp:

(JSC::JSArray::tryFinishCreationUninitialized):
(JSC::JSArray::checkConsistency):

  • runtime/JSArray.h:

(ArrayStorage):
(JSC::JSArray::initializeIndex):
(JSC::JSArray::completeInitialization):

18:09 Changeset [113529] by enne@google.com

[chromium] Add virtual test suite for threaded compositing
https://bugs.webkit.org/show_bug.cgi?id=82263

Reviewed by James Robinson.

Add compositing/visibility as a virtual test suites to test threaded
compositing with. This is a reasonable smoke test of 9 tests, none of
which have any expectations in the non-threaded case.

To fix many of the remaining tests in this virtual test suite, there
will need to be some serious refactoring to merge the conflict between
the way CCScheduler wants to draw frames and the way DRT also wants to
control things. So, in the short term, enable a few simple tests that
are known to be passing.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.virtual_test_suites):

18:03 Changeset [113528] by oliver@apple.com

Accessing the returnValue of a modal dialog should be performed directly on the global object.
https://bugs.webkit.org/show_bug.cgi?id=83414

Reviewed by Gavin Barraclough.

Presumably during the mass-devirtualising of JSObject, this deliberate use of
the GlobalObject's property lookup logic directly was replaced with a dynamic
call. That results in the DOMWindow filtering out the lookup. This regression
was masked by r93567.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::DialogHandler::returnValue):

17:58 PrefixedAPIs edited by abarth@webkit.org
(diff)
17:57 Changeset [113527] by jonlee@apple.com

Build fix for Windows bots.

Source/JavaScriptCore:

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: export missing symbol.

Source/WebKit2:

  • win/WebKit2.def: Add missing export symbol.
17:53 PrefixedAPIs edited by abarth@webkit.org
(diff)
17:49 PrefixedAPIs edited by abarth@webkit.org
(diff)
17:43 Changeset [113526] by japhet@chromium.org

Move Archive processing to DocumentLoader, instead of FrameLoader.
https://bugs.webkit.org/show_bug.cgi?id=83055

Reviewed by Adam Barth.

No new tests, no functionality change intended.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::setupForReplaceByMIMEType):
(WebCore::DocumentLoader::maybeCreateArchive): Renamed from

FrameLoader::finishedLoadingDocument(). Returns true if an archive
was created.

(WebCore::DocumentLoader::setArchive):
(WebCore::DocumentLoader::scheduleArchiveLoad):
(WebCore::DocumentLoader::documentURL): Add a check for whether an archive url

should be returned, so that we don't need special handling in Document and
FrameLoader for overriding the document url later.

  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::receivedFirstData): Remove archive special cases, since

DocumentLoader::documentURL() will return the right thing for legacy archives
and maybeCreateArchive() will override the base url for mhtml.

(WebCore::FrameLoader::loadArchive):

  • loader/FrameLoader.h:
17:41 PrefixedAPIs edited by abarth@webkit.org
(diff)
17:37 PrefixedAPIs edited by abarth@webkit.org
(diff)
17:36 PrefixedAPIs edited by abarth@webkit.org
(diff)
17:34 PrefixedAPIs edited by abarth@webkit.org
(diff)
17:33 Changeset [113525] by charles.wei@torchmobile.com.cn

[BlackBerry] Build fix to match the latest WebCore change
https://bugs.webkit.org/show_bug.cgi?id=83358

Reviewed by Rob Buis.

Source/WebCore:

Update the BlackBerry cmake file to reflect the fact that:
1.VDMXParser.cpp moved from graphics/skia to graphics/chromium.
2.geolocation moved to Modules/geolocation
3.websockets moved to Modules/websockets

  • PlatformBlackBerry.cmake:

Source/WebKit:

  • PlatformBlackBerry.cmake:
17:32 PrefixedAPIs edited by abarth@webkit.org
(diff)
17:30 PrefixedAPIs edited by abarth@webkit.org
(diff)
17:30 Changeset [113524] by charles.wei@torchmobile.com.cn

[BlackBerry] Restore some code which was deleted by accident.
https://bugs.webkit.org/show_bug.cgi?id=83357

Reviewed by Rob Buis.

No new tests, just BlackBerry build fix.

  • platform/network/blackberry/ResourceRequest.h:

(ResourceRequest):

  • platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore):
(WebCore::mimeTypeRequestTypeMap):
(WebCore::ResourceRequest::targetTypeFromMimeType):

17:29 PrefixedAPIs edited by abarth@webkit.org
(diff)
17:24 PrefixedAPIs created by abarth@webkit.org
17:14 Changeset [113523] by hbono@chromium.org

REGRESSION: Cannot write a word with Korean double consonant
https://bugs.webkit.org/show_bug.cgi?id=81186

Reviewed by Dan Bernstein.

WebKit change r103859 posts fake mouse-move events when the keyboard status is
changed. Unfortunately, these mouse events go to input methods and confuse a
Korean input method. This change directly calls handleMouseEvent() instead of
-mouseMoved: to prevent sending these fake events to input methods.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _postFakeMouseMovedEventForFlagsChangedEvent:]):

17:13 Changeset [113522] by simonjam@chromium.org

[Chromium] Unreviewed gardening.

  • platform/chromium-linux/fast/text/atsui-partial-selection-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/text/atsui-partial-selection-expected.png.
  • platform/chromium-mac-snowleopard/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/text/non-bmp-positioning-lists-expected.txt: Removed.
  • platform/chromium-mac/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-mac/svg/custom/shape-rendering-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
17:06 Changeset [113521] by jamesr@google.com

Unreviewed gardening.

Explicitly position canvases for these tests to avoid cross-platform differences.

  • fast/canvas/webgl/webgl-composite-modes-expected.png:
  • fast/canvas/webgl/webgl-composite-modes-repaint-expected.png:
  • fast/canvas/webgl/webgl-composite-modes-repaint.html:
  • fast/canvas/webgl/webgl-composite-modes.html:
17:03 Changeset [113520] by commit-queue@webkit.org

Fix bug in ContainerNode::getRect with scale transforms
https://bugs.webkit.org/show_bug.cgi?id=83385

Patch by Alexandre Elias <aelias@google.com> on 2012-04-06
Reviewed by Simon Fraser.

The bottom-right corner calculation for non-inline and replaced
elements in ContainerNode::getRect was incorrect in the presence of
scaling, because the untransformed element size was added after the
transformation is applied. The rest of the calculations are careful
to always apply the transformation as the last step, but this had been
forgotten in this codepath. The fix is just to make sure the size is
included in the localToAbsolute call.

One bug caused by this was that a scaled element would be cut off
when scrollIntoView(false) is called to scroll its parent container
to make it bottom-visible.

New layout test case in fast/transforms/scrollIntoView-transformed.html

Source/WebCore:

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::getLowerRightCorner):

LayoutTests:

  • fast/transforms/scrollIntoView-transformed-expected.txt:
  • fast/transforms/scrollIntoView-transformed.html:
16:41 Changeset [113519] by timothy_horton@apple.com

m_shouldRespectImageOrientation is used uninitialized
https://bugs.webkit.org/show_bug.cgi?id=83410

Reviewed by Simon Fraser.

Initialize Settings's m_shouldRespectImageOrientation to false.

  • page/Settings.cpp:

(WebCore::Settings::Settings):

16:26 Changeset [113518] by ap@apple.com

[Mac] Adopt a different method of telling AppKit when inline input isn't supported
https://bugs.webkit.org/show_bug.cgi?id=83408
<rdar://problem/9205734>

Reviewed by Adele Peterson.

16:09 Changeset [113517] by jamesr@google.com

[chromium] Clear values in combinedClear path not respected in WebGLRenderingContext::clearIfComposited()
https://bugs.webkit.org/show_bug.cgi?id=83407

Source/WebCore:

Reviewed by Kenneth Russell.

When doing a combined clear in the drawing buffer path, we have to use the user specified values for the clear
color / mask / depth and not all 0s.

Covered by slight modification to fast/canvas/webgl/canvas-test.html

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::clearIfComposited):

  • platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore::DrawingBuffer::clearFramebuffers):
(WebCore::DrawingBuffer::reset):

  • platform/graphics/gpu/DrawingBuffer.h:

LayoutTests:

Force a composite on each tick to more closely match the test's behavior in an actual browser.

  • fast/canvas/webgl/canvas-test.html:
16:02 Changeset [113516] by tony@chromium.org

[chromium] Unreviewed gardening.

This test is passing on Chromium Linux, but we have a different expectation
checked in for Chromium Win which uses lighttpd.

  • platform/chromium-linux/http/tests/xmlhttprequest/cache-override-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
15:57 Changeset [113515] by tony@chromium.org

[chromium] merge redundant conditions in WebCore.gyp
https://bugs.webkit.org/show_bug.cgi?id=83319

Reviewed by Adam Barth.

There were duplicate conditions in some of the targets (e.g., 2
OS=="win" sections) so I merged them and if possible, used an else
block of an existing condition.

No new tests, just refactoring the build file.

  • WebCore.gyp/WebCore.gyp:
15:55 Changeset [113514] by simon.fraser@apple.com

Rename paintingGoesToWindow() to paintsIntoWindow()
https://bugs.webkit.org/show_bug.cgi?id=83406

Reviewed by Dirk Schulze.

Rename paintingGoesToWindow() to paintsIntoWindow() to be consistent
with some future refactoring.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::setFilterBackendNeedsRepaintingInRect):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintsWithTransform):
(WebCore::RenderLayer::setBackingNeedsRepaint):
(WebCore::RenderLayer::setBackingNeedsRepaintInRect):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::containsPaintedContent):
(WebCore::RenderLayerBacking::paintsIntoWindow):
(WebCore::RenderLayerBacking::paintIntoLayer):

  • rendering/RenderLayerBacking.h:

(RenderLayerBacking):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::rootLayerAttachmentChanged):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::repaintUsingContainer):

  • rendering/RenderView.cpp:

(WebCore::RenderView::paintBoxDecorations):

15:53 Changeset [113513] by simonjam@chromium.org

Roll out change to HTMLParserIdioms.cpp from 82857
https://bugs.webkit.org/show_bug.cgi?id=83402

Change 82857 causes a DCHECK on fast/forms/number/ValidityState-typeMismatch-number.html

Darin suggested we roll out this file here: https://bugs.webkit.org/show_bug.cgi?id=82857#c20

Unreviewed, rolling out change that broke tests.

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::parseToDoubleForNumberType):

15:49 Changeset [113512] by fischman@chromium.org

Roll Chromium DEPS
https://bugs.webkit.org/show_bug.cgi?id=83389

Unreviewed, just a DEPS roll (130110:131183)

  • DEPS:
15:48 Changeset [113511] by isherman@chromium.org

Allow site authors to override autofilled fields' colors.
https://bugs.webkit.org/show_bug.cgi?id=66032
http://code.google.com/p/chromium/issues/detail?id=46543

Reviewed by Simon Fraser.

Source/WebCore:

  • css/html.css:

(input:-webkit-autofill): Remove !important declarations.

LayoutTests:

  • fast/forms/input-autofilled-expected.txt:
  • fast/forms/input-autofilled.html:
15:44 Changeset [113510] by enrica@apple.com

Provide Obj-C private API to simplify markup.
https://bugs.webkit.org/show_bug.cgi?id=83334
<rdar://problem/11033861>

Reviewed by Sam Weinig.

Source/WebCore:

Added test in TestWebKitAPI

  • WebCore.exp.in:
  • editing/Editor.cpp:

(WebCore::Editor::simplifyMarkup): Exposing the new command through the editor.

  • editing/Editor.h:

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _simplifyMarkup:endNode:]): Added.

  • WebView/WebViewPrivate.h:

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/SimplifyMarkup.mm: Added.

(-[SimplifyMarkupTest webView:didFinishLoadForFrame:]):

  • TestWebKitAPI/Tests/mac/verboseMarkup.html: Added.
15:43 Changeset [113509] by dpranke@chromium.org

clone baselines from platform/win to platform/chromium-win
https://bugs.webkit.org/show_bug.cgi?83394

Unreviewed, expectations change.

Copies the win baselines that chromium depends on into a
chromium dir, so that we can remove the dependency on win down
the road.

  • platform/chromium-win/accessibility/aria-fallback-roles-expected.txt: Added.
  • platform/chromium-win/accessibility/detached-object-notification-crash-expected.txt: Added.
  • platform/chromium-win/accessibility/document-enabled-state-expected.txt: Added.
  • platform/chromium-win/accessibility/document-role-expected.txt: Added.
  • platform/chromium-win/accessibility/focus-events-expected.txt: Added.
  • platform/chromium-win/accessibility/heading-elements-expected.txt: Added.
  • platform/chromium-win/accessibility/img-alt-attribute-expected.txt: Added.
  • platform/chromium-win/accessibility/linked-elements-expected.txt: Added.
  • platform/chromium-win/accessibility/list-item-role-expected.txt: Added.
  • platform/chromium-win/accessibility/list-marker-role-expected.txt: Added.
  • platform/chromium-win/accessibility/list-role-expected.txt: Added.
  • platform/chromium-win/accessibility/multiple-select-element-role-expected.txt: Added.
  • platform/chromium-win/accessibility/option-element-position-and-size-expected.txt: Added.
  • platform/chromium-win/accessibility/option-element-selection-and-focus-events-expected.txt: Added.
  • platform/chromium-win/accessibility/parent-element-expected.txt: Added.
  • platform/chromium-win/accessibility/scroll-to-anchor-expected.txt: Added.
  • platform/chromium-win/accessibility/select-element-role-expected.txt: Added.
  • platform/chromium-win/accessibility/select-element-valuechange-event-expected.txt: Added.
  • platform/chromium-win/accessibility/selection-and-focus-expected.txt: Added.
  • platform/chromium-win/accessibility/single-select-children-changed-expected.txt: Added.
  • platform/chromium-win/accessibility/single-select-children-expected.txt: Added.
  • platform/chromium-win/accessibility/text-role-expected.txt: Added.
  • platform/chromium-win/compositing/plugins/composited-plugin-expected.txt: Added.
  • platform/chromium-win/compositing/plugins/small-to-large-composited-plugin-expected.txt: Added.
  • platform/chromium-win/editing/selection/anchor-focus2-expected.txt: Added.
  • platform/chromium-win/editing/selection/anchor-focus3-expected.txt: Added.
  • platform/chromium-win/editing/selection/collapse-selection-in-bidi-expected.txt: Added.
  • platform/chromium-win/editing/selection/doubleclick-should-not-expand-across-lines-expected.txt: Added.
  • platform/chromium-win/editing/selection/drag-text-delay-expected.txt: Added.
  • platform/chromium-win/editing/selection/extend-selection-home-end-expected.txt: Added.
  • platform/chromium-win/editing/selection/mixed-editability-10-expected.txt: Added.
  • platform/chromium-win/editing/selection/shift-page-up-down-expected.txt: Added.
  • platform/chromium-win/editing/selection/transformed-selection-rects-expected.txt: Added.
  • platform/chromium-win/fast/css/zoom-body-scroll-expected.txt: Added.
  • platform/chromium-win/fast/dom/Element/id-in-deletebutton-expected.txt: Added.
  • platform/chromium-win/fast/dom/Window/window-properties-expected.txt: Added.
  • platform/chromium-win/fast/dom/prototype-inheritance-2-expected.txt: Added.
  • platform/chromium-win/fast/events/alt-numpad-expected.txt: Added.
  • platform/chromium-win/fast/events/alt-space-scroll-expected.txt: Added.
  • platform/chromium-win/fast/events/context-click-events-expected.txt: Added.
  • platform/chromium-win/fast/events/double-dead-char-expected.txt: Added.
  • platform/chromium-win/fast/events/keyLocation-numpad-expected.txt: Added.
  • platform/chromium-win/fast/events/panScroll-click-hyperlink-expected.txt: Added.
  • platform/chromium-win/fast/events/panScroll-correct-direction-expected.txt: Added.
  • platform/chromium-win/fast/events/panScroll-event-fired-expected.txt: Added.
  • platform/chromium-win/fast/events/panScroll-image-no-scroll-expected.txt: Added.
  • platform/chromium-win/fast/events/panScroll-imageMap-href-no-scroll-expected.txt: Added.
  • platform/chromium-win/fast/events/panScroll-imageMap-noHref-scroll-expected.txt: Added.
  • platform/chromium-win/fast/events/panScroll-nested-divs-expected.txt: Added.
  • platform/chromium-win/fast/events/panScroll-no-iframe-jump-expected.txt: Added.
  • platform/chromium-win/fast/events/panScroll-preventDefault-expected.txt: Added.
  • platform/chromium-win/fast/forms/cursor-at-editable-content-boundary-expected.txt: Added.
  • platform/chromium-win/fast/forms/select-popup-pagekeys-expected.txt: Added.
  • platform/chromium-win/fast/images/support-broken-image-delegate-expected.txt: Added.
  • platform/chromium-win/fast/js/global-constructors-expected.txt: Added.
  • platform/chromium-win/fast/loader/stateobjects/state-url-sets-links-visited-expected.txt: Added.
  • platform/chromium-win/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
  • platform/chromium-win/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
  • platform/chromium-win/fast/replaced/table-percent-height-text-controls-expected.txt: Added.
  • platform/chromium-win/fast/text/capitalize-boundaries-expected.txt: Added.
  • platform/chromium-win/fast/text/emphasis-combined-text-expected.txt: Added.
  • platform/chromium-win/fast/text/emphasis-expected.png: Added.
  • platform/chromium-win/fast/text/emphasis-expected.txt: Added.
  • platform/chromium-win/fast/text/emphasis-vertical-expected.png: Added.
  • platform/chromium-win/fast/text/emphasis-vertical-expected.txt: Added.
  • platform/chromium-win/fast/text/fallback-traits-fixup-expected.txt: Added.
  • platform/chromium-win/fast/text/international/hindi-whitespace-expected.png: Added.
  • platform/chromium-win/fast/text/international/hindi-whitespace-expected.txt: Added.
  • platform/chromium-win/fast/text/international/text-combine-image-test-expected.png: Added.
  • platform/chromium-win/fast/text/international/text-combine-image-test-expected.txt: Added.
  • platform/chromium-win/fast/text/international/vertical-text-glyph-test-expected.png: Added.
  • platform/chromium-win/fast/text/international/vertical-text-glyph-test-expected.txt: Added.
  • platform/chromium-win/fast/text/international/vertical-text-metrics-test-expected.txt: Added.
  • platform/chromium-win/fast/text/justify-ideograph-complex-expected.txt: Added.
  • platform/chromium-win/fast/text/justify-ideograph-simple-expected.txt: Added.
  • platform/chromium-win/fast/text/justify-ideograph-vertical-expected.txt: Added.
  • platform/chromium-win/fast/text/uniscribe-item-boundary-crash-expected.txt: Added.
  • platform/chromium-win/fast/text/uniscribe-missing-glyph-expected.txt: Added.
  • platform/chromium-win/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
  • platform/chromium-win/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
  • platform/chromium-win/fast/writing-mode/border-vertical-lr-expected.png: Added.
  • platform/chromium-win/fast/writing-mode/border-vertical-lr-expected.txt: Added.
  • platform/chromium-win/fast/writing-mode/japanese-lr-selection-expected.png: Added.
  • platform/chromium-win/fast/writing-mode/japanese-lr-selection-expected.txt: Added.
  • platform/chromium-win/fast/writing-mode/japanese-rl-selection-expected.png: Added.
  • platform/chromium-win/fast/writing-mode/japanese-rl-selection-expected.txt: Added.
  • platform/chromium-win/fast/writing-mode/text-orientation-basic-expected.png: Added.
  • platform/chromium-win/fast/writing-mode/text-orientation-basic-expected.txt: Added.
  • platform/chromium-win/fast/writing-mode/vertical-font-fallback-expected.txt: Added.
  • platform/chromium-win/inverted-colors/non-composited-expected.png: Added.
  • platform/chromium-win/inverted-colors/non-composited-expected.txt: Added.
  • platform/chromium-win/platform/win/plugins/draws-gradient-expected.png: Added.
  • platform/chromium-win/platform/win/plugins/draws-gradient-expected.txt: Added.
  • platform/chromium-win/plugins/call-javascript-that-destroys-plugin-expected.txt: Added.
  • platform/chromium-win/plugins/get-value-netscape-window-expected.txt: Added.
  • platform/chromium-win/plugins/iframe-inside-overflow-expected.txt: Added.
  • platform/chromium-win/plugins/npn-invalidate-rect-invalidates-window-expected.txt: Added.
  • platform/chromium-win/plugins/npp-set-window-called-during-destruction-expected.txt: Added.
  • platform/chromium-win/plugins/plugin-javascript-access-expected.txt: Added.
  • platform/chromium-win/plugins/resize-from-plugin-expected.txt: Added.
  • platform/chromium-win/plugins/visibility-hidden-expected.png: Added.
  • platform/chromium-win/plugins/visibility-hidden-expected.txt: Added.
  • platform/chromium-win/plugins/window-geometry-initialized-before-set-window-expected.txt: Added.
  • platform/chromium-win/plugins/window-region-is-set-to-clip-rect-expected.txt: Added.
  • platform/chromium-win/plugins/windowless-paint-rect-coordinates-expected.txt: Added.
  • platform/chromium-win/printing/page-rule-in-media-query-expected.txt: Added.
  • platform/chromium-win/sputnik/Conformance/11_Expressions/11.5_Multiplicative_Operators/11.5.3_Percent/S11.5.3_A4_T6-expected.txt: Added.
  • platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
15:35 Changeset [113508] by ggaren@apple.com

Renamed

WeakHeap => WeakSet
HandleHeap => HandleSet

Reviewed by Sam Weinig.

These sets do have internal allocators, but it's confusing to call them
heaps because they're sub-objects of an object called "heap".

  • heap/HandleHeap.cpp: Removed.
  • heap/HandleHeap.h: Removed.
  • heap/HandleSet.cpp: Copied from JavaScriptCore/heap/HandleHeap.cpp.
  • heap/WeakHeap.cpp: Removed.
  • heap/WeakHeap.h: Removed.
  • heap/WeakSet.cpp: Copied from JavaScriptCore/heap/WeakHeap.cpp.
  • heap/WeakSet.h: Copied from JavaScriptCore/heap/WeakHeap.h.

Plus global rename using grep.

15:30 Changeset [113507] by dpranke@chromium.org

new-run-webkit-tests: fix bugs in 'mock' drt implementation
https://bugs.webkit.org/show_bug.cgi?id=83341

Reviewed by Eric Seidel.

The current implementation crashed in some circumstances for
reference tests and files that were missing expected results.
This patch fixes those cases and adds more unit tests; it is a
precursor to adding unit tests each port that actually uses this
code, in order to get better coverage of the port/*
implementations.

  • Scripts/webkitpy/layout_tests/port/mock_drt.py:

(parse_options):
(MockDRT.input_from_line):
(MockDRT.output_for_test):
(MockDRT.run_one_test):
(MockChromiumDRT.input_from_line):
(MockChromiumDRT.output_for_test):
(MockChromiumDRT.run_one_test):

  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:

(MockDRTTest.make_input_output):
(MockDRTTest.expected_output):
(MockDRTTest):
(MockDRTTest.assertTest):
(MockDRTTest.test_missing_image):
(MockDRTTest.test_missing_text):
(MockDRTTest.test_reftest_match):
(MockDRTTest.test_reftest_mismatch):
(MockChromiumDRTTest.expected_output):

15:24 Changeset [113506] by tony@chromium.org

[chromium] Unreviewed gardening. This test is passing on chromium win and linux.

  • platform/chromium-linux-x86/fast/text/atsui-partial-selection-expected.png: Added.
  • platform/chromium-win/fast/text/atsui-partial-selection-expected.png:
  • platform/chromium/test_expectations.txt:
15:23 Changeset [113505] by benjamin@webkit.org

Get rid of the useless flag PREEMPT_GEOLOCATION_PERMISSION
https://bugs.webkit.org/show_bug.cgi?id=83325

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-06
Reviewed by Ryosuke Niwa.

Source/WebCore:

The flag WTF_USE_PREEMPT_GEOLOCATION_PERMISSION was added in r63742 but
was never disabled by anyone. Supporting this feature added complexity by
introducing two authorization scheme.

This patch removes WTF_USE_PREEMPT_GEOLOCATION_PERMISSION and the code supporting
granting the authorization after startUpdating().

  • Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::GeoNotifier::runSuccessCallback): With the simplified
authorization code, we ensure stronger constraint on GeoNotifier::runSuccessCallback().
(WebCore::Geolocation::stop):
(WebCore::Geolocation::startRequest):
(WebCore::Geolocation::clearWatch):
(WebCore::Geolocation::setIsAllowed):
(WebCore::Geolocation::positionChanged): The case (!isAllowed()) was there
to support granting the authorization for WTF_USE_PREEMPT_GEOLOCATION_PERMISSION.
(WebCore::Geolocation::handlePendingPermissionNotifiers):

  • Modules/geolocation/Geolocation.h:

(Geolocation):

Source/WebKit/blackberry:

  • WebCoreSupport/AboutDataUseFeatures.in:

Source/WTF:

  • wtf/Platform.h: Remove the flag.
15:16 Changeset [113504] by tony@chromium.org

[chromium] Unreviewed, rebaseline a test on Vista/Win7.

  • platform/chromium-linux/fast/encoding/invalid-UTF-8-expected.txt: Removed.
  • platform/chromium-win/fast/encoding/invalid-UTF-8-expected.png:
  • platform/chromium-win/fast/encoding/invalid-UTF-8-expected.txt:
  • platform/chromium/test_expectations.txt:
15:15 Changeset [113503] by tsepez@chromium.org

Block cross-origin iframe scroll to fragment.
https://bugs.webkit.org/show_bug.cgi?id=73083

Reviewed by Adam Barth.

Add a restriction similar to what FF has done for all iframes for over a
year now. Our change is less disruptive in that it only does this in the
cross-orgin case, which is where the fragment scrolling is problematic.

Source/WebCore:

Test: http/tests/navigation/anchor-frames-cross-origin.html

  • dom/Document.cpp:

(WebCore::Document::canBeAccessedByEveryAncestorFrame):
(WebCore):

  • dom/Document.h:

(Document):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::finishedParsing):
(WebCore::FrameLoader::loadInSameDocument):
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::shouldPerformFragmentNavigation):
(WebCore::FrameLoader::scrollToFragmentIfAllowed):
(WebCore):

  • loader/FrameLoader.h:

(FrameLoader):

LayoutTests:

  • http/tests/inspector/resource-parameters-expected.txt:
  • http/tests/navigation/anchor-frames-cross-origin-expected.txt: Added.
  • http/tests/navigation/anchor-frames-cross-origin.html: Added.
  • http/tests/navigation/resources/frame-with-anchor-cross-origin.html: Added.
  • http/tests/security/xssAuditor/anchor-url-dom-write-location-expected.txt:
  • http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-expected.txt:
  • http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-null-char-expected.txt:
  • http/tests/security/xssAuditor/anchor-url-dom-write-location-javascript-URL-expected.txt:
  • http/tests/security/xssAuditor/anchor-url-dom-write-location2-expected.txt:
  • http/tests/security/xssAuditor/dom-write-location-inline-event-expected.txt:
14:49 Changeset [113502] by jsbell@chromium.org

Merge 112740 - IndexedDB: Race condition causes version change transaction to commit after onblocked
https://bugs.webkit.org/show_bug.cgi?id=82678

Source/WebCore:

For a version change event, the blocked and success events could both be queued
before either is dispatched. The transaction would erroneously be allowed to commit
after the blocked event was dispatched; it should not be, as the request was not
finished.

Reviewed by Tony Chang.

Test: storage/indexeddb/dont-commit-on-blocked.html

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::dispatchEvent):

LayoutTests:

Landing test marked PASS FAIL as WK82776 prevents it from running in DRT; will
run it as a Chromium browser test for now.

Reviewed by Tony Chang.

  • platform/chromium/test_expectations.txt:
  • storage/indexeddb/dont-commit-on-blocked.html: Added.
  • storage/indexeddb/resources/dont-commit-on-blocked-worker.js: Added.

(request.onsuccess):
(onSetVersionBlocked):
(onSetVersionSuccess):
(onTransactionComplete):

TBR=jsbell@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10007047

14:49 Changeset [113501] by jer.noble@apple.com

WebFullScreenManagerProxy::isFullScreen() will create an empty full screen window; steal focus.
https://bugs.webkit.org/show_bug.cgi?id=83388

Reviewed by Geoffrey Garen.

Calling WebFullScreenManagerProxy::isFullScreen() will create a WKFullScreenWindowController if
one does not already exist, since the -[WKView fullScreenWindowController] method will create-on-access.
Add a new call, -[WKView hasFullScreenWindowController], which does not auto-create the controller
and add that check to WebFullScreenManagerProxy::isFullScreen().

  • UIProcess/API/mac/WKView.mm:

(-[WKView hasFullScreenWindowController]):

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/mac/WebFullScreenManagerProxyMac.mm:

(WebKit::WebFullScreenManagerProxy::isFullScreen):

14:48 Changeset [113500] by tony@chromium.org

[chromium] Unreviewed, remove a passing test.
tables/mozilla/bugs/bug9024.html is passing on Leopard.

  • platform/chromium/test_expectations.txt:
14:45 Changeset [113499] by jamesr@google.com

Enable webkit_unit_tests for commit queue and EWS while tracking failures
https://bugs.webkit.org/show_bug.cgi?id=83329

Reviewed by Adam Barth.

This adds a step to parse XML output from webkit_unit_tests and consider regressions in the PatchAnalysisTask so
the commit queue and EWS can reject patches that cause regressions.

  • Scripts/webkitpy/common/config/ports.py:

(ChromiumPort.run_webkit_unit_tests_command):

  • Scripts/webkitpy/common/config/ports_mock.py:

(MockPort.unit_tests_results_path):

  • Scripts/webkitpy/common/net/layouttestresults.py:

(LayoutTestResults.init):
(LayoutTestResults.failing_tests):
(LayoutTestResults):
(LayoutTestResults.add_unit_test_failures):

  • Scripts/webkitpy/common/net/unittestresults.py: Copied from Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py.

(UnitTestResults):
(UnitTestResults.results_from_string):

  • Scripts/webkitpy/common/net/unittestresults_unittest.py: Added.

(UnitTestResultsTest):
(UnitTestResultsTest.test_nostring):
(UnitTestResultsTest.test_emptystring):
(UnitTestResultsTest.test_nofailures):
(test_onefailure):
(test_multiple_failures_per_test):

  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:

(MockCommitQueue.test_results):
(MockCommitQueue.archive_last_test_results):
(FailingTestCommitQueue.test_results):
(test_flaky_test_failure):
(test_failed_archive):

  • Scripts/webkitpy/tool/bot/layouttestresultsreader.py:

(LayoutTestResultsReader._create_unit_test_results):
(LayoutTestResultsReader.results):

  • Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:

(LayoutTestResultsReaderTest.test_missing_layout_test_results):

  • Scripts/webkitpy/tool/bot/patchanalysistask.py:

(PatchAnalysisTaskDelegate.test_results):
(PatchAnalysisTaskDelegate.archive_last_test_results):
(PatchAnalysisTask._test):
(PatchAnalysisTask._build_and_test_without_patch):
(PatchAnalysisTask._test_patch):

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(AbstractEarlyWarningSystem.test_results):
(AbstractEarlyWarningSystem.archive_last_test_results):

  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

(EarlyWarningSytemTest._test_testing_ews):

  • Scripts/webkitpy/tool/commands/queues.py:

(CommitQueue.test_results):
(CommitQueue.archive_last_test_results):

  • Scripts/webkitpy/tool/commands/queues_unittest.py:

(CommitQueueTest.test_commit_queue):
(test_rollout):
(test_manual_reject_during_processing):

  • Scripts/webkitpy/tool/steps/runtests.py:

(RunTests.run):

  • Scripts/webkitpy/tool/steps/runtests_unittest.py:

(RunTestsTest.test_webkit_run_unit_tests):

14:38 Changeset [113498] by jer.noble@apple.com

Foreground of apple.com/iphone video page visible during full screen animation.
https://bugs.webkit.org/show_bug.cgi?id=83080

Reviewed by Simon Fraser.

Source/WebCore:

No new tests; updated fullscreen/full-screen-stacking-context.html

The apple.com/iphone video page uses a -webkit-mask: CSS style, which creates a stacking
context and causes the page to pop in front of the full screen renderer. Add all the
styles suggested by the W3C full screen spec to the -webkit-full-screen-ancestor rule
to keep these stacking contexts from being created.

  • css/fullscreen.css:

(:-webkit-full-screen-ancestor:not(iframe)):

LayoutTests:

  • fullscreen/full-screen-stacking-context.html:
  • platform/mac/fullscreen/full-screen-stacking-context-expected.png:
14:32 Changeset [113497] by inferno@chromium.org

Virtualize createAnonymousBoxWithSameTypeAs.
https://bugs.webkit.org/show_bug.cgi?id=83229

Reviewed by Julien Chaffraix.

This helps to use the same function to create anonymous
table parts and in the future extend to more classes
derived from RenderBox.

The current switch case situation was going to be messy as
we will need to mix cases that were very dependent on the
class, so it made sense to add a virtual function.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::splitAnonymousBlocksAroundChild):
(WebCore::RenderBlock::createAnonymousBoxWithSameTypeAs):

  • rendering/RenderBlock.h:

(RenderBlock):

  • rendering/RenderBox.h:

(WebCore::RenderBox::createAnonymousBoxWithSameTypeAs):
(RenderBox):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::splitFlow):

  • rendering/RenderTable.h:

(WebCore::RenderTable::createAnonymousBoxWithSameTypeAs):

  • rendering/RenderTableCell.h:

(WebCore::RenderTableCell::createAnonymousBoxWithSameTypeAs):

  • rendering/RenderTableRow.h:

(WebCore::RenderTableRow::createAnonymousBoxWithSameTypeAs):

  • rendering/RenderTableSection.h:

(WebCore::RenderTableSection::createAnonymousBoxWithSameTypeAs):

14:31 Changeset [113496] by timothy_horton@apple.com

[cg] REGRESSION (r101517): Animating the transform of a <rect> with shape-rendering: crispEdges leaves behind garbage
https://bugs.webkit.org/show_bug.cgi?id=82963
<rdar://problem/11170476>

Reviewed by Simon Fraser.

CoreGraphics can inflate the stroke by 1px when drawing a rectangle
with antialiasing disabled at non-integer coordinates, we need to
compensate by inflating the RenderSVGRect repaint bounds by 1px.

No new tests, as this is not reproducible in DRT or WKTR.

  • rendering/svg/RenderSVGRect.cpp:

(WebCore::RenderSVGRect::createShape):
(WebCore::RenderSVGRect::strokeBoundingBox):

  • rendering/svg/RenderSVGRect.h:

(RenderSVGRect):

New Mac baselines for two tests which have SVG <rect>s with shape-rendering: crispEdges.

  • platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
  • platform/mac/svg/custom/shape-rendering-expected.txt:
14:19 Changeset [113495] by commit-queue@webkit.org

Tools: Enable MediaSource feature for DumpRenderTree so
MediaSource LayoutTests will pass for Chromium.
https://bugs.webkit.org/show_bug.cgi?id=83053

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-04-06
Reviewed by Dimitri Glazkov.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

LayoutTests: Fix MediaSource LayoutTests to work with the new XHR behavior
that requires asynchronous requests for the 'arraybuffer'
responseType.
https://bugs.webkit.org/show_bug.cgi?id=83053

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-04-06
Reviewed by Dimitri Glazkov.

  • http/tests/media/media-source/webm/video-media-source-errors.html:
  • http/tests/media/media-source/webm/video-media-source-play.html:
  • http/tests/media/media-source/webm/video-media-source-seek.html:
  • http/tests/media/media-source/webm/video-media-source-state-changes.html:
  • http/tests/media/media-source/webm/webm-media-source.js:

(getData.request.onload):
(createClusterGetFunction.return.if):
(createClusterGetFunction):
(loadWebMData):
(getCluster):
(appendCluster):
(getReadyStateName):
(expectSourceState):
(expectReadyState):

  • platform/chromium/test_expectations.txt:
14:17 Changeset [113494] by simon.fraser@apple.com

Avoid trying to set filters on transform layers
https://bugs.webkit.org/show_bug.cgi?id=83344

Reviewed by Dean Jackson.

Return early from GraphicsLayerCA::setFilters() when the filters
haven't changed. This avoids trying to clear filters on CALayers
which never had them, which should both help performance, and avoids
console spew related to setting shadow properties on transform layers.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setFilters):

14:15 Changeset [113493] by jamesr@google.com

WebGL content swapped at wrong time in threaded compositing mode
https://bugs.webkit.org/show_bug.cgi?id=82275

Reviewed by Kenneth Russell.

Source/WebCore:

When using threaded compositing, we need to defer touching the texture ID being used by the compositor until the
appropriate point in the synchronization routine and not before. Specifically, there is no time at which it is
safe to manipulate the texture the compositor may be using from the main thread. This breaks up the presentation
path into a few pieces (depending on the context attributes) in order to maintain these invariants.

Depending on the context attributes and if we're in threaded mode, there are a few different possible back/front
buffer combinations:

  • When the context is antialiased, we have a multisampled renderbuffer and associated framebuffer.
  • In all cases, we have a color texture back buffer.
  • When preserveDrawingBuffer is set or threaded compositing is enabled, we have a separate color texture as a

front buffer.

The resource update is in two phases. First, on the main thread, we prepare the back buffer. This resolves from
the multisampled FBO into the back color buffer if multisampled and swaps the front / back color buffer textures
if preserveDrawingBuffer is false and we're using separate front / back color buffers. Second, on the compositor
thread, we do a texture copy from the back to the front color buffer if preserveDrawingBuffer is true. After
these steps are complete the main thread is free to manipulate the back buffer color texture without affecting
any resources the compositor is using.

One incidental cleanup this patch also does is remove all state queries from DrawingBuffer::clearFramebuffer().

Tests: fast/canvas/webgl/webgl-composite-modes-repaint.html

fast/canvas/webgl/webgl-composite-modes.html

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::WebGLRenderingContext):
(WebCore::WebGLRenderingContext::clearIfComposited):
(WebCore::WebGLRenderingContext::restoreStateAfterClear):
(WebCore::WebGLRenderingContext::reshape):
(WebCore::WebGLRenderingContext::maybeRestoreContext):

  • html/canvas/WebGLRenderingContext.h:

(WebGLRenderingContext):

  • platform/graphics/blackberry/DrawingBufferBlackBerry.cpp:

(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore):
(WebCore::DrawingBuffer::prepareBackBuffer):
(WebCore::DrawingBuffer::requiresCopyFromBackToFrontBuffer):
(WebCore::DrawingBuffer::frontColorBuffer):

  • platform/graphics/cairo/DrawingBufferCairo.cpp:

(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore):
(WebCore::DrawingBuffer::prepareBackBuffer):
(WebCore::DrawingBuffer::requiresCopyFromBackToFrontBuffer):
(WebCore::DrawingBuffer::frontColorBuffer):

  • platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::generateColorTexture):
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::initialize):
(WebCore::DrawingBuffer::prepareBackBuffer):
(WebCore):
(WebCore::DrawingBuffer::requiresCopyFromBackToFrontBuffer):
(WebCore::DrawingBuffer::frontColorBuffer):
(WebCore::DrawingBuffer::platformLayer):

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::WebGLLayerChromium):
(WebCore::WebGLLayerChromium::paintContentsIfDirty):
(WebCore::WebGLLayerChromium::updateCompositorResources):
(WebCore::WebGLLayerChromium::paintRenderedResultsToCanvas):
(WebCore::WebGLLayerChromium::setNeedsDisplayRect):
(WebCore::WebGLLayerChromium::setDrawingBuffer):

  • platform/graphics/chromium/WebGLLayerChromium.h:

(WebGLLayerChromium):

  • platform/graphics/clutter/DrawingBufferClutter.cpp:

(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore):
(WebCore::DrawingBuffer::prepareBackBuffer):
(WebCore::DrawingBuffer::requiresCopyFromBackToFrontBuffer):
(WebCore::DrawingBuffer::frontColorBuffer):

  • platform/graphics/filters/FECustomFilter.cpp:

(WebCore::FECustomFilter::initializeContext):

  • platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore::DrawingBuffer::create):
(WebCore::DrawingBuffer::clear):
(WebCore::DrawingBuffer::clearFramebuffer):
(WebCore::DrawingBuffer::reset):
(WebCore::DrawingBuffer::discardResources):

  • platform/graphics/gpu/DrawingBuffer.h:

(DrawingBuffer):

  • platform/graphics/gpu/mac/DrawingBufferMac.mm:

(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore):
(WebCore::DrawingBuffer::prepareBackBuffer):
(WebCore::DrawingBuffer::requiresCopyFromBackToFrontBuffer):
(WebCore::DrawingBuffer::frontColorBuffer):

  • platform/graphics/gpu/qt/DrawingBufferQt.cpp:

(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::platformLayer):
(WebCore::DrawingBuffer::prepareBackBuffer):
(WebCore::DrawingBuffer::requiresCopyFromBackToFrontBuffer):
(WebCore):
(WebCore::DrawingBuffer::frontColorBuffer):

Source/WebKit/chromium:

  • tests/WebGLLayerChromiumTest.cpp:

(WebKit::TEST):

LayoutTests:

Adds some pixel tests for compositing all different combinations of alpha/antialias/preserveDrawingBuffer on
WebGL content.

  • fast/canvas/webgl/webgl-composite-modes-expected.png: Added.
  • fast/canvas/webgl/webgl-composite-modes-expected.txt: Added.
  • fast/canvas/webgl/webgl-composite-modes-repaint-expected.png: Added.
  • fast/canvas/webgl/webgl-composite-modes-repaint-expected.txt: Added.
  • fast/canvas/webgl/webgl-composite-modes-repaint.html: Added.
  • fast/canvas/webgl/webgl-composite-modes.html: Added.
14:10 Changeset [113492] by tony@chromium.org

[chromium] Unreviewed, land some mac/win baselines for table tests after r111742.

  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2123-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2509-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug34176-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug44505-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug59252-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug7243-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/scroll-inside-table-cell-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/scroll-relative-table-inside-table-cell-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2123-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2509-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug34176-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug44505-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug59252-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug7243-expected.png:
  • platform/chromium-mac/fast/repaint/scroll-inside-table-cell-expected.png:
  • platform/chromium-mac/fast/repaint/scroll-relative-table-inside-table-cell-expected.png:
  • platform/chromium-mac/fast/table/cell-pref-width-invalidation-expected.txt: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug2123-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2123-expected.txt: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug2509-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2509-expected.txt: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug34176-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug34176-expected.txt: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug44505-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug44505-expected.txt:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug59252-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug59252-expected.txt: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug7243-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug7243-expected.txt: Added.
  • platform/chromium-win/fast/repaint/scroll-inside-table-cell-expected.png:
  • platform/chromium-win/fast/repaint/scroll-relative-table-inside-table-cell-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug44505-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug44505-expected.txt:
  • platform/chromium/test_expectations.txt:
13:41 Changeset [113491] by jchaffraix@webkit.org

Unreviewed build fix after r113486 and r113487.

  • rendering/RenderObject.cpp:

Added missing #include.

  • rendering/RenderView.h:

Removed bad OVERRIDE.

13:20 Changeset [113490] by bdakin@apple.com

https://bugs.webkit.org/show_bug.cgi?id=81939
-webkit-image-set should update dynamically when the device scale factor
changes
-and corresponding-
<rdar://problem/11101108>

Reviewed by Darin Adler.

Source/WebCore:

New member variable to keep track of the scale factor.

  • css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::CSSImageSetValue):
(WebCore::CSSImageSetValue::bestImageForScaleFactor):

Merge the two cachedImageSet functions. There was no need for two functions here.

(WebCore::CSSImageSetValue::cachedImageSet):

cachedOrPendingImageSet() now takes a Document as a parameter so that it can
access the deviceScaleFactor. If there is a cached image already and the
Document's deviceScaleFactor doesn't match m_scaleFactor, then m_imageSet is set
to a pending image so that the best fit image will be reassessed and then
loaded.
(WebCore::CSSImageSetValue::cachedOrPendingImageSet):

  • css/CSSImageSetValue.h:

(WebCore):
(CSSImageSetValue):

cachedOrPendingImageSet() now takes a Document.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

StyleCachedImageSet should inherit from CachedImageClient just like
StyleCachedImage. It should add and remove itself as a client upon creation
and destruction, respectively.

  • rendering/style/StyleCachedImageSet.cpp:

(WebCore::StyleCachedImageSet::StyleCachedImageSet):
(WebCore):
(WebCore::StyleCachedImageSet::~StyleCachedImageSet):

  • rendering/style/StyleCachedImageSet.h:

(StyleCachedImageSet):

LayoutTests:

  • fast/hidpi/image-set-background-dynamic.html: Added.
  • fast/hidpi/image-set-border-image-dynamic.html: Added.
  • fast/hidpi/image-set-in-content-dynamic.html: Added.
  • platform/mac/fast/hidpi/image-set-background-dynamic-expected.png: Added.
  • platform/mac/fast/hidpi/image-set-background-dynamic-expected.txt: Added.
  • platform/mac/fast/hidpi/image-set-border-image-dynamic-expected.png: Added.
  • platform/mac/fast/hidpi/image-set-border-image-dynamic-expected.txt: Added.
  • platform/mac/fast/hidpi/image-set-in-content-dynamic-expected.png: Added.
  • platform/mac/fast/hidpi/image-set-in-content-dynamic-expected.txt: Added.
13:12 Changeset [113489] by staikos@webkit.org

Turn on vibration support for BlackBerry.

Reviewed by Rob Buis.

  • Scripts/build-webkit:
13:07 Changeset [113488] by schenney@chromium.org

[Chromium} Rebaseline some failing Leopard tests
https://bugs.webkit.org/show_bug.cgi?id=83387

Unreviewed chromium test expectations update.

  • platform/chromium-mac-leopard/fast/text/atsui-multiple-renderers-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/find-kana-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
13:04 Changeset [113487] by leviw@chromium.org

Update LayoutUnit usage in RenderView
https://bugs.webkit.org/show_bug.cgi?id=83147

Reviewed by Julien Chaffraix.

Updating the usage of LayoutUnits in RenderView in preparation for sub-pixel layout. This mostly
affects paint and repaint functions, which take LayoutRects up to the RenderView level. This is
necessary as we continue to accumulate sub-pixel offsets up to this level.

No new tests. No change in behavior.

  • rendering/RenderView.cpp:

(WebCore::RenderView::paint): Adding an assert that we're being called to paint on pixel
boundaries. We don't currently ever position RenderViews at sub-pixel offsets.
(WebCore::RenderView::shouldRepaint):
(WebCore::RenderView::repaintViewRectangle): Switching to a LayoutRect and cleaning up a fixme
that used decomposed offsets. Pixel snapping is applied before handing the rect up to the
FrameView.
(WebCore::RenderView::repaintRectangleInViewAndCompositedLayers): Pixel snapping before handing
the rect up to the Compositor.
(WebCore::RenderView::computeRectForRepaint):
(WebCore::RenderView::selectionBounds):
(WebCore::RenderView::viewRect):
(WebCore::RenderView::unscaledDocumentRect):

  • rendering/RenderView.h:

(RenderView):

13:02 Changeset [113486] by timothy_horton@apple.com

Add autodetection of image orientation from EXIF information
https://bugs.webkit.org/show_bug.cgi?id=19688
<rdar://problem/4126979> and <rdar://problem/11091578>

Original patch by David Carson and Eric Seidel.

Reviewed by Simon Fraser.

Add support for respecting EXIF image orientation, enabled by default for ImageDocuments.
The setting shouldRespectImageOrientation causes orientation to take effect for any image included via <img>.

Test: fast/images/exif-orientation.html, fast/images/exif-orientation-css.html

File list truncated because it's very long.

12:58 Changeset [113485] by jsbell@chromium.org

IndexedDB: Race condition in layout test logging from window and worker
https://bugs.webkit.org/show_bug.cgi?id=83378

The sequencing of logging directly from window vs. logging via posted events
from a worker is racy, making this test flake when run under Chromium. Removed
the sensitive logging on the window side; the test logic is unaffected as the
blocked/success event sequence would not be present if the window handler was
not run.

Reviewed by Tony Chang.

  • storage/indexeddb/dont-commit-on-blocked-expected.txt:
  • storage/indexeddb/dont-commit-on-blocked.html:
12:54 Changeset [113484] by leviw@chromium.org

Correct LayoutUnit usgae in RenderThemeQt and RenderThemeQStyle
https://bugs.webkit.org/show_bug.cgi?id=83376

Reviewed by Eric Seidel.

Source/WebCore:

Correcting LayoutUnit usage in QT RenderTheme code.

No new tests. No change in behavior.

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::convertToPaintingRect): Rounding the ancestor offset before
applying it to the pixel snapped partRect.
(WebCore::RenderThemeQt::paintSearchFieldCancelButton): Also rounding the ancestor
offset, and also pixel snapping the content rect before painting.

Source/WebKit/qt:

Calculating the progress animation using the pixel-snapped RenderProgress size instead
of the internal sub-pixel version.

  • WebCoreSupport/RenderThemeQStyle.cpp:

(WebCore::RenderThemeQStyle::animationDurationForProgressBar):

12:47 Changeset [113483] by commit-queue@webkit.org

[chromium] Rebaseline svg/clip-path/deep-nested-clip-in-mask* expectations
https://bugs.webkit.org/show_bug.cgi?id=83368

Unreviewed Chromium expectations rebaseline.

Patch by Florin Malita <fmalita@google.com> on 2012-04-06

  • platform/chromium-mac-leopard/svg/clip-path/clip-path-pixelation-expected.png:
  • platform/chromium-mac-leopard/svg/clip-path/deep-nested-clip-in-mask-expected.png:
  • platform/chromium-mac-leopard/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png:
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-in-mask-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-pixelation-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/deep-nested-clip-in-mask-expected.png:
  • platform/chromium-mac-snowleopard/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png:
  • platform/chromium-mac-snowleopard/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-in-mask-expected.png: Added.
  • platform/chromium-mac/svg/clip-path/clip-path-pixelation-expected.png:
  • platform/chromium-mac/svg/clip-path/deep-nested-clip-in-mask-expected.png: Added.
  • platform/chromium-mac/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png: Added.
  • platform/chromium-mac/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png: Added.
  • platform/chromium-mac/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png: Added.
  • platform/chromium-mac/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png: Added.
  • platform/chromium-win/svg/clip-path/clip-in-mask-expected.png: Added.
  • platform/chromium-win/svg/clip-path/deep-nested-clip-in-mask-expected.png: Added.
  • platform/chromium-win/svg/clip-path/deep-nested-clip-in-mask-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/clip-path/deep-nested-clip-in-mask-expected.txt.
  • platform/chromium-win/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png: Added.
  • platform/chromium-win/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt.
  • platform/chromium-win/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png: Added.
  • platform/chromium-win/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png: Added.
  • platform/chromium-win/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/clip-path/clip-in-mask-expected.txt: Removed.
  • platform/mac/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.txt: Removed.
  • platform/mac/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.txt: Removed.
  • platform/mac/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.txt: Removed.
  • platform/qt/svg/clip-path/clip-in-mask-expected.txt: Removed.
  • platform/qt/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.txt: Removed.
  • platform/qt/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.txt: Removed.
  • platform/qt/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.txt: Removed.
  • svg/clip-path/clip-in-mask-expected.txt: Renamed from LayoutTests/platform/gtk/svg/clip-path/clip-in-mask-expected.txt.
  • svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.txt: Renamed from LayoutTests/platform/gtk/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.txt.
  • svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.txt: Renamed from LayoutTests/platform/gtk/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.txt.
  • svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.txt: Renamed from LayoutTests/platform/gtk/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.txt.
12:43 Changeset [113482] by schenney@chromium.org

Font-related tests are flaky on Chromium (sometimes glyphs don't draw)
https://bugs.webkit.org/show_bug.cgi?id=66908

Unreviewed chromium test expectations update.

  • platform/chromium-mac-snowleopard/svg/custom/svg-fonts-fallback-expected.png: Removed.
  • platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.fontface.notinpage-expected.txt:
  • platform/chromium-mac/svg/custom/svg-fonts-fallback-expected.png: Added.
  • platform/chromium/test_expectations.txt:
12:43 Changeset [113481] by kbr@google.com

context-lost.html is failing
https://bugs.webkit.org/show_bug.cgi?id=81325

Reviewed by James Robinson.

Ensure that the DrawingBuffer does not attempt to restore the
TEXTURE_2D binding to an already-deleted texture.

Tested with layout test fast/canvas/webgl/context-lost.html as
well as WebGL conformance tests.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::loseContextImpl):

12:37 Changeset [113480] by commit-queue@webkit.org

Unreviewed, rolling out r113267.
http://trac.webkit.org/changeset/113267
https://bugs.webkit.org/show_bug.cgi?id=83384

causes dhtml perf regression (Requested by simonjam on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-06

Source/WebCore:

  • dom/ChildListMutationScope.cpp:

(ChildListMutationScope::MutationAccumulator):
(WebCore::ChildListMutationScope::MutationAccumulator::isAddedNodeInOrder):
(WebCore::ChildListMutationScope::MutationAccumulator::childAdded):
(WebCore::ChildListMutationScope::MutationAccumulationRouter::childAdded):

  • dom/ChildListMutationScope.h:

(WebCore::ChildListMutationScope::childAdded):
(MutationAccumulationRouter):

  • dom/ContainerNode.cpp:

(WebCore):
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::appendChild):
(WebCore::dispatchChildInsertionEvents):
(WebCore::updateTreeAfterInsertion):

LayoutTests:

  • fast/events/domnodeinserted-entire-fragment-expected.txt: Removed.
  • fast/events/domnodeinserted-entire-fragment.html: Removed.
12:28 Changeset [113479] by schenney@chromium.org

6 layout tests known to fail on Mac10.6 with CPU-Skia graphics
https://bugs.webkit.org/show_bug.cgi?id=68436

Unreviewed Chromium test expectations update.

One of the files marked in this bug is a minor rebaselining. Done.

  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/paths-data-12-t-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/paths-data-12-t-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
12:19 Changeset [113478] by schenney@chromium.org

Rebaseline after Skia 2527 landed
https://bugs.webkit.org/show_bug.cgi?id=83375

Unreviewed update of Chromium test expectations.

Patch by Philip Rogers <pdr@google.com> on 2012-04-06

  • platform/chromium-linux/svg/as-background-image/svg-as-background-5-expected.png:
  • platform/chromium-linux/svg/filters/subRegion-one-effect-expected.png:
  • platform/chromium-linux/svg/filters/subRegion-two-effects-expected.png:
  • platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-5-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-5-expected.png:
  • platform/chromium-mac/svg/as-background-image/svg-as-background-5-expected.png: Added.
  • platform/chromium-mac/svg/filters/subRegion-one-effect-expected.png:
  • platform/chromium-mac/svg/filters/subRegion-two-effects-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-as-background-5-expected.png:
  • platform/chromium-win/svg/filters/subRegion-one-effect-expected.png:
  • platform/chromium-win/svg/filters/subRegion-two-effects-expected.png:
  • platform/chromium/test_expectations.txt:
12:16 Changeset [113477] by schenney@chromium.org

Rebaseline after r109097
https://bugs.webkit.org/show_bug.cgi?id=79568

Unreviewed update of test expectations.

Patch by Philip Rogers <pdr@google.com> on 2012-04-06

  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • platform/chromium/test_expectations.txt:
12:14 Changeset [113476] by schenney@chromium.org

Rebaseline tests for wk62974
https://bugs.webkit.org/show_bug.cgi?id=62974

Unreviewed test expectations update for Chromium.

Patch by Philip Rogers <pdr@google.com> on 2012-04-06

  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-altglyph-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-text-04-t-expected.png:
  • platform/chromium-linux/svg/text/text-text-06-t-expected.png:
  • platform/chromium-linux/svg/wicd/test-rightsizing-b-expected.png:
  • platform/chromium-mac-leopard/svg/text/text-altglyph-01-b-expected.png: Added.
  • platform/chromium-mac-leopard/svg/text/text-text-04-t-expected.png: Added.
  • platform/chromium-mac-leopard/svg/text/text-text-06-t-expected.png: Added.
  • platform/chromium-mac-leopard/svg/wicd/test-rightsizing-b-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/wicd/test-rightsizing-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-altglyph-01-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-text-04-t-expected.png: Added.
  • platform/chromium-mac/svg/text/text-text-06-t-expected.png: Added.
  • platform/chromium-mac/svg/wicd/test-rightsizing-b-expected.png: Added.
  • platform/chromium-win-vista/svg/wicd: Removed.
  • platform/chromium-win-vista/svg/wicd/test-rightsizing-b-expected.png: Removed.
  • platform/chromium-win-xp/svg/wicd: Added.
  • platform/chromium-win-xp/svg/wicd/test-rightsizing-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.png:
  • platform/chromium-win/svg/text/text-altglyph-01-b-expected.png:
  • platform/chromium-win/svg/text/text-text-04-t-expected.png:
  • platform/chromium-win/svg/text/text-text-06-t-expected.png:
  • platform/chromium-win/svg/wicd/test-rightsizing-b-expected.png:
  • platform/chromium-win/svg/wicd/test-rightsizing-b-expected.txt:
  • platform/chromium/test_expectations.txt:
12:10 Changeset [113475] by schenney@chromium.org

[Chromium] Layout Test svg/custom/oversized-pattern-scale.svg and svg/custom/transformed-pattern-clamp-svg-root.svg are flaky
https://bugs.webkit.org/show_bug.cgi?id=68982

Unreviewed Chromium expectations update.

These tests now passing without issue.

  • platform/chromium-linux/svg/custom/oversized-pattern-scale-expected.png: Removed.
  • platform/chromium-mac/svg/custom/oversized-pattern-scale-expected.png: Added.
  • platform/chromium-mac/svg/custom/transformed-pattern-clamp-svg-root-expected.png:
  • platform/chromium-win/svg/custom/oversized-pattern-scale-expected.png:
  • platform/chromium-win/svg/custom/transformed-pattern-clamp-svg-root-expected.png:
  • platform/chromium/svg/custom/oversized-pattern-scale-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
12:07 Changeset [113474] by mrobinson@webkit.org

Unskip some tests that appear to be passing on GTK+ and add a
new baseline to deal with whitespace issues.

  • platform/gtk/Skipped: Unskip some tests passing locally.
  • platform/gtk/plugins/document-open-expected.txt: Added.
12:06 Changeset [113473] by jsbell@chromium.org

IndexedDB: ObjectStore/Index shouldn't hold reference to backing store
https://bugs.webkit.org/show_bug.cgi?id=83074

Source/WebCore:

We should be able to collect and close the leveldb backing store as soon as the database
connection is closed, but the IDBObjectStoreBackendImpl and IDBIndexBackendImpl were
holding RefPtrs, and those objects are kept alive by script references.

Replaced RefPtrs to the IDBBackingStore with pointers to the IDBDatabase. On the back end,
IDBDatabaseBackendImpl maintains a RefPtr to the IDBObjectStoreBackendImpl object, so
a raw pointer back is safe. On the front end, the IDBObjectStore maintains a RefPtr to
the IDBDatabase so script can navigate upwards. Ditto on both ends for the ObjectStore/Index
relationship. The frontend objects maintain RefPtrs to the backend objects, so the backend
objects and their owners are maintained as long as there's a script reference.

Also made IDBDatabaseBackendImpl handle a null IDBFactoryBackendImpl pointer, for testing.

Reviewed by Tony Chang.

Tests: webkit_unit_tests --gtest_filter="IDBDatabaseBackendTest.*"

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::~IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::loadObjectStores):

  • Modules/indexeddb/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::IDBIndexBackendImpl):
(WebCore::IDBIndexBackendImpl::openCursorInternal):
(WebCore::IDBIndexBackendImpl::countInternal):
(WebCore::IDBIndexBackendImpl::getInternal):
(WebCore::IDBIndexBackendImpl::addingKeyAllowed):

  • Modules/indexeddb/IDBIndexBackendImpl.h:

(WebCore::IDBIndexBackendImpl::create):
(IDBIndexBackendImpl):
(WebCore::IDBIndexBackendImpl::backingStore):
(WebCore::IDBIndexBackendImpl::databaseId):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl):
(WebCore::IDBObjectStoreBackendImpl::getInternal):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):
(WebCore::IDBObjectStoreBackendImpl::clearInternal):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
(WebCore::IDBObjectStoreBackendImpl::countInternal):
(WebCore::IDBObjectStoreBackendImpl::loadIndexes):
(WebCore::IDBObjectStoreBackendImpl::genAutoIncrementKey):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(WebCore::IDBObjectStoreBackendImpl::create):
(IDBObjectStoreBackendImpl):
(WebCore::IDBObjectStoreBackendImpl::backingStore):
(WebCore::IDBObjectStoreBackendImpl::databaseId):

Source/WebKit/chromium:

Reviewed by Tony Chang.

  • WebKit.gypi:
  • tests/IDBDatabaseBackendTest.cpp: Added.

(WebCore):
(MockIDBBackingStore):
(WebCore::TEST):

11:56 Changeset [113472] by jonlee@apple.com

Fix build warning on const long long to int implicit conversion.

  • inspector/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCacheResource):

11:55 Changeset [113471] by eae@chromium.org

Fix LayoutUnit usage and rounding in RenderBlock and RenderEmbeddedObject
https://bugs.webkit.org/show_bug.cgi?id=83343

Reviewed by Eric Seidel.

Fix usage of LayoutUnits and rounding/pixel snapping in RenderBlock and
RenderEmbeddedObject in preparation for turing on subpixel support.

No new tests, no change in functionality.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::baselinePosition):

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::nodeAtPoint):

11:55 Changeset [113470] by schenney@chromium.org

Zooming in SVGs in <object> is flakey
https://bugs.webkit.org/show_bug.cgi?id=71673

Unreviewed Chromium test expectations update.

  • platform/chromium-linux-x86/svg/zoom/page: Removed.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Removed.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
  • platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
  • platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/chromium-win-xp/svg/zoom/page: Removed.
  • platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/chromium/test_expectations.txt:
11:50 Changeset [113469] by mrobinson@webkit.org

[GTK] crash in editing/selection/editable-html-element.html
https://bugs.webkit.org/show_bug.cgi?id=64530

Unskip and rebaseline a test.

  • platform/gtk/Skipped: Unskip this test, because it's passing locally.
  • platform/gtk/editing/selection/editable-html-element-expected.txt:
11:46 Changeset [113468] by mrobinson@webkit.org

REGRESSION(r65062): out of bound access in TextIterator (5 editing tests) on GTK
https://bugs.webkit.org/show_bug.cgi?id=63611

Unskip tests that are now passing and rebaseline ones which
have changed results.

  • platform/gtk/Skipped:
  • platform/gtk/editing/deleting/smart-delete-003-expected.txt:
  • platform/gtk/editing/deleting/smart-delete-004-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-008-expected.txt:
11:41 Changeset [113467] by mitz@apple.com

<rdar://problem/10912476> HiDPI: Have canvas use a hidpi backing store, but downsample upon access

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig: Added ENABLE_HIGH_DPI_CANVAS.

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig: Added ENABLE_HIGH_DPI_CANVAS.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig: Added ENABLE_HIGH_DPI_CANVAS.

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig: Added ENABLE_HIGH_DPI_CANVAS.

Tools:

  • Scripts/build-webkit: Added high-dpi-canvas option to control ENABLE_HIGH_DPI_CANVAS.

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops: Added ENABLE_HIGH_DPI_CANVAS.
11:34 Changeset [113466] by leviw@chromium.org

Update LayoutUnit usage in Editor and Frame
https://bugs.webkit.org/show_bug.cgi?id=83278

Reviewed by Eric Seidel.

Frame and Editor both take input from the embedder, which passes along coordinates in screen
coordinates, which aren't fractional. Updating a few remaining functions to show this, and correcting
some inconsistencies in LayoutUnit usage.

No new tests. No change in behavior.

  • editing/Editor.cpp:

(WebCore::Editor::rangeForPoint): windowToContents returns an IntPoint.
(WebCore::Editor::countMatchesForText): Using enclosingIntRect since we're (fake) repainting the entire
view rect.

  • editing/Editor.h:

(Editor): Correcting mismatched function signature.

  • page/Frame.cpp:

(WebCore::Frame::visiblePositionForPoint): Frame takes points in screen coordinates, usually from the
embedder. Changing these functions to be in IntPoints.
(WebCore::Frame::documentAtPoint): Ditto.
(WebCore::Frame::rangeForPoint): Ditto.

  • page/Frame.h:

(Frame):

  • platform/graphics/IntRect.h:

(enclosingIntRect): Adding an inline no-op copy of the FractionalLayoutRect method enclosingIntRect.

11:34 Changeset [113465] by schenney@chromium.org

Layout Test svg/text/non-bmp-positioning-lists.svg is failing
https://bugs.webkit.org/show_bug.cgi?id=73494

Unreviewed Chromium test expectations.

The font is not right, but that's not what the test is testing.

  • platform/chromium-linux/svg/text/non-bmp-positioning-lists-expected.png: Added.
  • platform/chromium-linux/svg/text/non-bmp-positioning-lists-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/text/non-bmp-positioning-lists-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/text/non-bmp-positioning-lists-expected.txt: Added.
  • platform/chromium-mac/svg/text/non-bmp-positioning-lists-expected.png: Added.
  • platform/chromium-win/svg/text/non-bmp-positioning-lists-expected.png: Added.
  • platform/chromium-win/svg/text/non-bmp-positioning-lists-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:30 Changeset [113464] by mrobinson@webkit.org

Fix the GTK+ debug build.

  • Source/autotools/symbols.filter: Add a missing symbol to the symbols.list file.
11:25 Changeset [113463] by schenney@chromium.org

SVG filters incorrectly move elements
https://bugs.webkit.org/show_bug.cgi?id=73643

Unreviewed Chromium test expectations update.

  • platform/chromium-linux/svg/as-background-image/svg-as-background-2-expected.png: Removed.
  • platform/chromium-linux/svg/filters/filter-placement-issue-expected.png: Removed.
  • platform/chromium-linux/svg/filters/filterRes2-expected.png: Removed.
  • platform/chromium-mac/svg/filters/filter-placement-issue-expected.png: Added.
  • platform/chromium-mac/svg/filters/filterRes2-expected.png: Modified property svn:mime-type.
  • platform/chromium-win/svg/as-background-image/svg-as-background-2-expected.png:
  • platform/chromium-win/svg/filters/filter-placement-issue-expected.png: Added.
  • platform/chromium-win/svg/filters/filterRes2-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/efl/svg/as-background-image/svg-as-background-2-expected.txt: Removed.
  • svg/as-background-image/svg-as-background-2-expected.txt: Added.
11:23 Changeset [113462] by tommyw@google.com

MediaStream API: Deleting the chromium bridge class MediaStreamCenterInternal
https://bugs.webkit.org/show_bug.cgi?id=83167

Reviewed by Adam Barth.

The situation before this patch is that we had a MediaStreamCenter.h with #ifdefs for the chromium specific
private class MediaStreamCenterInternal. This bridge class only shuffled calls between MediaStreamCenter and
WebMediaStreamCenter and was needed before the introduction of Platform.
To get rid of this now unnecessary class I had two alternatives:
1) Sprinkle platform/MediaStreamCenter.h with more #ifdefs, including around the class declaration.
2) Create an abstract base class that the chromium and gstreamer implementations overrides.
My personal preference is 2) since I strongly dislike #ifdefs. The drawback is that MediaStreamCenter now
has a vtable. However since all methods in this class are extremely low-usage it doesn't affect anything
in practice.

No code behaviour changes.

  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::setEnabled):

  • Modules/mediastream/UserMediaRequest.cpp:
  • Modules/mediastream/UserMediaRequest.h:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/chromium/support/WebMediaStreamSourcesRequest.cpp:
  • platform/mediastream/MediaStreamCenter.cpp:

(WebCore::MediaStreamCenter::MediaStreamCenter):
(WebCore):
(WebCore::MediaStreamCenter::~MediaStreamCenter):

  • platform/mediastream/MediaStreamCenter.h:

(WebCore):
(MediaStreamCenter):

  • platform/mediastream/MediaStreamSourcesQueryClient.h: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.h.

(WebCore):
(MediaStreamSourcesQueryClient):
(WebCore::MediaStreamSourcesQueryClient::~MediaStreamSourcesQueryClient):

  • platform/mediastream/chromium/MediaStreamCenterChromium.cpp:

(WebCore::MediaStreamCenter::instance):
(WebCore::MediaStreamCenterChromium::MediaStreamCenterChromium):
(WebCore::MediaStreamCenterChromium::~MediaStreamCenterChromium):
(WebCore::MediaStreamCenterChromium::queryMediaStreamSources):
(WebCore::MediaStreamCenterChromium::didSetMediaStreamTrackEnabled):
(WebCore::MediaStreamCenterChromium::didStopLocalMediaStream):
(WebCore::MediaStreamCenterChromium::didConstructMediaStream):
(WebCore::MediaStreamCenterChromium::constructSDP):
(WebCore):
(WebCore::MediaStreamCenterChromium::stopLocalMediaStream):

  • platform/mediastream/chromium/MediaStreamCenterChromium.h: Renamed from Source/WebCore/platform/mediastream/chromium/MediaStreamCenterInternal.h.

(WebKit):
(WebCore):
(MediaStreamCenterChromium):

  • platform/mediastream/chromium/MediaStreamCenterInternal.cpp: Removed.
  • platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.cpp.

(WebCore):
(WebCore::MediaStreamCenter::instance):
(WebCore::MediaStreamCenterGStreamer::MediaStreamCenterGStreamer):
(WebCore::MediaStreamCenterGStreamer::~MediaStreamCenterGStreamer):
(WebCore::MediaStreamCenterGStreamer::queryMediaStreamSources):
(WebCore::MediaStreamCenterGStreamer::didSetMediaStreamTrackEnabled):
(WebCore::MediaStreamCenterGStreamer::didStopLocalMediaStream):
(WebCore::MediaStreamCenterGStreamer::didConstructMediaStream):
(WebCore::MediaStreamCenterGStreamer::constructSDP):

  • platform/mediastream/gstreamer/MediaStreamCenterGStreamer.h: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.h.

(WebCore):
(MediaStreamCenterGStreamer):

11:17 Changeset [113461] by simon.fraser@apple.com

Should disable preserves3D() for things that enforce flattening, like overflow and filters
https://bugs.webkit.org/show_bug.cgi?id=83337

Source/WebCore:

Reviewed by Dean Jackson.

The CSS3 Transforms spec says that some properties should cause flattening
of things with transform-style: preserve-3d. We currently do this as a side
effect of the GraphicsLayer structure, but we should really do it at the
RenderStyle level, as we do for other things like stacking context creation.

Test: compositing/overflow-trumps-transform-style.html

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

LayoutTests:

Reviewed by Dean Jackson.

Test for computed style and layer structure combining transform-style
with overflow.

  • compositing/overflow-trumps-transform-style-expected.txt: Added.
  • compositing/overflow-trumps-transform-style.html: Added.
11:07 Changeset [113460] by tommyw@google.com

MediaStream API: MediaStreams stops proper cleanup to take place during a page reload.
https://bugs.webkit.org/show_bug.cgi?id=83143

Reviewed by Adam Barth.

To fix this I have converted MediaStream and LocalMediaStream to be ActiveDOMObjects.

Have no idea how to write a test that succesfully verifies this. I have done manual testing
to verify that proper tear-down now takes place.

  • Modules/mediastream/LocalMediaStream.cpp:

(WebCore::LocalMediaStream::create):
(WebCore::LocalMediaStream::stopFunction):
(WebCore):

  • Modules/mediastream/LocalMediaStream.h:

(LocalMediaStream):

  • Modules/mediastream/LocalMediaStream.idl:
  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::create):
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::scriptExecutionContext):

  • Modules/mediastream/MediaStream.h:

(MediaStream):

11:06 Changeset [113459] by schenney@chromium.org

[chromium] Rounding issue on some RenderSVGPath values
https://bugs.webkit.org/show_bug.cgi?id=75367

Unreviewed Chromium expectations update.

These tests have been stable for a long time, and consistent across
all platforms. Whatever was causing previous flakiness is apparently
no longer happening.

  • platform/chromium/svg/css/composite-shadow-example-expected.txt:
  • platform/chromium/svg/css/composite-shadow-with-opacity-expected.txt:
  • platform/chromium/test_expectations.txt:
10:53 Changeset [113458] by schenney@chromium.org

[Chromium] svg/text/text-style-recalc-crash.html times out
https://bugs.webkit.org/show_bug.cgi?id=75696

Unreviewed Chromium test_expectations cleanup.

The test referenced by this bug has not failed in the current history of the flakiness board.

  • platform/chromium/test_expectations.txt:
10:48 Changeset [113457] by mitz@apple.com

<rdar://problem/10912476> Pixel access canvas APIs do not work transparently with high-DPI backing store
https://bugs.webkit.org/show_bug.cgi?id=83072

Reviewed by Simon Fraser.

Made getImageData, putImageData, and toDataURL downsample/upsample when pixels in the canvas
backing store are not in a 1:1 ratio to CSS pixels. This makes clients of these APIs
indifferent to the backing store resolution, up to sampling artifacts.

In order for this to work, ImageBuffer has to know and respect the resolutionScale
parameter. This change makes the Core Graphics-based implementation of ImageBuffer do this,
but on other platforms, resolutionScale values other than 1 will not work. Such platforms
should not enable the HIGH_DPI_CANVAS feature.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::HTMLCanvasElement): Updated a comment.
(WebCore::HTMLCanvasElement::createImageBuffer): Changed to create an ImageBuffer with
the desired resolution instead of 1.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawImage): Removed code that scaled the source rect,
since this is now handled at the ImageBuffer level.
(WebCore::CanvasRenderingContext2D::createImageData): Now returns ImageData of the requested
size regardless of the backing store resolution.
(WebCore::CanvasRenderingContext2D::getImageData): Ditto.

  • platform/graphics/ImageBuffer.h:

(WebCore::ImageBuffer::create): Removed some code that tried to apply the resolution scale
to the buffer after creating it, and changed to pass the resolution scale down to the
(platform-specific) constructor, which can apply it correctly.

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::ImageBuffer):

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::ImageBuffer): Added a resolutionScale parameter, which is used to
compute the backing buffer size, and to apply a device scale factor to the context.
(WebCore::ImageBuffer::copyImage): Changed to return an image scaled down to the logical
size of the buffer.
(WebCore::ImageBuffer::getUnmultipliedImageData): Changed to pass the resolution scale to
ImageData::getData().
(WebCore::ImageBuffer::getPremultipliedImageData): Ditto.
(WebCore::ImageBuffer::putByteArray): Changed to pass the resolution scale to
ImageData::putData(). When drawing the byte array as an image, changed to preserve the base
CTM in the destination context (thus mapping from image data pixels to backing store pixels).
(WebCore::ImageBuffer::toDataURL): Fixed a CGColorSpace leak. Made the returned image have
the buffer’s logical size instead of the backing buffer’s size.
(WebCore::ImageDataToDataURL): Fixed a CGColorSpace leak.

  • platform/graphics/cg/ImageBufferDataCG.cpp:

(WebCore::ImageBufferData::getData): Added a resolutionScale parameter. The source
coordinates are scaled by the value of that parameter, and a reverse scaling transform
is applied when copying from the backing store into the destination (either explicitly
using Accelerate or implicitly by drawing as an image). Since after scaling,
unpremultiplication and component permutation are done in-place, made the
non-Accelerate code that does these things safe in this case.
(WebCore::ImageBufferData::putData): Added a resolutionScale parameter. The destination
coordinates are scaled by the value of that parameter, and a scaling transform is applied
when copying from the source into the backing store (either explicitly using Accelerate or
implicitly by drawing as an image). Since after scaling, premultiplication and component
permutation are done in-place, made the non-Accelerate code that does these things safe in
this case.

  • platform/graphics/cg/ImageBufferDataCG.h:
  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::ImageBuffer::ImageBuffer):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::ImageBuffer):

  • platform/graphics/wince/ImageBufferWinCE.cpp:

(WebCore::ImageBuffer::ImageBuffer):

  • platform/graphics/wx/ImageBufferWx.cpp:

(WebCore::ImageBuffer::ImageBuffer):

10:37 Changeset [113456] by commit-queue@webkit.org

[chromium] Draw debug borders for tiles on layers with skipsDraw
https://bugs.webkit.org/show_bug.cgi?id=83352

Patch by Dana Jansens <danakj@chromium.org> on 2012-04-06
Reviewed by Adrienne Walker.

The tiles are given the same color as other missing tiles.

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::appendQuads):

10:35 Changeset [113455] by rwlbuis@webkit.org

Fix cast-align warnings in JSC
https://bugs.webkit.org/show_bug.cgi?id=80790

Reviewed by George Staikos.

Source/JavaScriptCore:

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::computeJumpType):
(JSC::ARMv7Assembler::link):

  • assembler/LinkBuffer.h:

(JSC::LinkBuffer::linkCode):

  • heap/MarkStack.cpp:

(JSC::SlotVisitor::copyAndAppend):

  • runtime/JSArray.cpp:

(JSC::JSArray::visitChildren):

  • wtf/RefCountedArray.h:

(WTF::RefCountedArray::Header::payload):

Source/WebCore:

  • platform/graphics/WOFFFileFormat.cpp:

(WebCore::readUInt32):
(WebCore::readUInt16):

  • platform/image-encoders/skia/JPEGImageEncoder.cpp:

(WebCore::preMultipliedBGRAtoRGB):

  • platform/network/MIMESniffing.cpp:
10:31 Changeset [113454] by darin@apple.com

Streamline strtod and fix some related problems
https://bugs.webkit.org/show_bug.cgi?id=82857

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • parser/Lexer.cpp:

(JSC::Lexer<>::lex): Use parseDouble. Since we have already scanned the number
and we know it has only correct characters, leading spaces, trailing junk, and
trailing spaces are not a possibility. No need to add a trailing null character.

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::parseInt): Changed overflow based 10 case to use parseDouble. No need
to allow trailing junk since the code above already allows only numeric digits
in the string. This code path is used only in unusual cases, so it's not
optimized for 8-bit strings, but easily could be.
(JSC::jsStrDecimalLiteral): Removed the allow trailing junk argument to this
function template because all the callers are OK with trailing junk. Use the
parseDouble function. No need to copy the data into a byte buffer, because
parseDouble handles that.
(JSC::toDouble): Got rid of the DisallowTrailingJunk argument to the
jsStrDecimalLiteral function template. That's OK because this function
already checks for trailing junk and handles it appropriately. The old code
path was doing it twice.
(JSC::parseFloat): Got rid of the AllowTrailingJunk argument to the
jsStrDecimalLiteral function template; the template allows junk unconditionally.

  • runtime/LiteralParser.cpp:

(JSC::::Lexer::lexNumber): Use parseDouble. Since we have already scanned the number
and we know it has only correct characters, leading spaces, trailing junk, and
trailing spaces are not a possibility. No need to add a trailing null character.
No need to copy the data into a byte buffer, because parseDouble handles that.
We could optimize the UChar case even more because we know all the characters
are ASCII, but not doing that at this time.

Source/WebCore:

Refactoring of code covered by existing tests.

  • dom/ViewportArguments.cpp:

(WebCore::numericPrefix): Removed a confusing comment that just said
"we tolerate extra characters" in a roundabout way. Made the "ok"
argument optional. Changed to call the new version of charactersToFloat
that returns the number of characters parsed rather than using the
charactersToFloatIgnoringJunk/didReadNumber solution from before.
(WebCore::findSizeValue): Since numericPrefix is guaranteed to return 0
when it can't parse, removed the "ok" code. Also changed the unusual
syntax "float(1.0)" to just "1", which works just as well.
(WebCore::findScaleValue): Ditto.
(WebCore::findUserScalableValue): Ditto.

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::parseToDoubleForNumberType): Removed an unneeded code path
and replaced it with an assertion; toDouble no longer will return infinity
or not-a-number values.

Source/WTF:

Replaced the strtod function template with a parseDouble function, eliminating
the following unneeded features:

  • need for a trailing null character and a call to strlen
  • needless conversion of string lengths from size_t to int and back that created the possibility of incorrect truncation
  • one level of function call; use inlining instead
  • construction of the StringToDoubleConverter object; it was used to pass arguments that are known at compile time
  • most of the StringToDoubleConverter::StringToDouble function's body; it was code we did not need
  • parsing of Infinity and NaN at the strtod level; added recently when we moved from the old strtod to the new one, and not needed or helpful at this level
  • multiple copies of code to narrow to single byte strings; in many cases this was done even when starting with an LChar string that is already single-byte, now we handle this with an overload of parseDouble
  • wtf/dtoa.cpp:

Removed a long comment about the original strtod function that no longer
applies since we deleted that function long ago. Removed a lot of includes.
Removed the strtod function templates and its instantiations, since they
are now replaced by the parseDouble function.
(WTF::Internal::parseDoubleFromLongString): Added.

  • wtf/dtoa.h:

Added an include of ASCIICType.h so we can use isASCII in a function in this
header. Left the heretofore unneeded include of double-conversion.h, since we
now want to use it in a function in this header. Removed the AllowTrailingJunkTag
and AllowTrailingSpacesTag enumerations and the strtod function template. Added
new parseDouble function, and inline implementation of it.

  • wtf/dtoa/double-conversion.cc: Removed quite a bit of unused code, hardcoding

all the StringToDouble function arguments that come from data members so it can
be a much smaller static member function. Also changed the types of arguments
from int to size_t.

  • wtf/dtoa/double-conversion.h: Removed most of the StringToDoubleConverter

class, leaving only the conversion function as a static member function.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::toDouble): Got rid of didReadNumber.
(WTF::StringImpl::toFloat): Ditto.

  • wtf/text/StringImpl.h: Ditto.
  • wtf/text/WTFString.cpp:

(WTF::String::toDouble): Got rid of didReadNumber.
(WTF::String::toFloat): Ditto.
(WTF::toDoubleType): Rewrote this function to use parseDouble. Moved the code
to skip leading spaces here, because other callers of parseDouble don't want
to do that. Repurposed the check for an empty string so it's now the same
code shared by all the "parsed nothing" cases. Removed the code to convert
the buffer to ASCII for two reasons: (1) We don't need that code at all when
CharType is LChar, and (2) We now handle this through the two overloads for
the parseDouble function. Disallowing trailing junk is now handled here,
rather than inside parseDouble.
(WTF::charactersToDouble): Updated for changes to toDoubleType. Removed the
didReadNumber argument.
(WTF::charactersToFloat): Ditto. Also added overloads that return the parsed
length. These are a slightly more powerful way to do what didReadNumber was
used for before.

  • wtf/text/WTFString.h: Added comments, eliminated didReadNumber, and added

overloads of charactersToFloat that replace charactersToFloatIgnoringJunk.

10:29 Changeset [113453] by commit-queue@webkit.org

[chromium] Surface replica should have a separate quad in the render pass
https://bugs.webkit.org/show_bug.cgi?id=83287

Patch by Dana Jansens <danakj@chromium.org> on 2012-04-06
Reviewed by Adrienne Walker.

Generate separate quads for a RenderSurface and its replica. The replica
quad is drawn independently of the surface itself. This allows us to
cull each one independently.

Covered by existing tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawRenderSurfaceQuad):
(WebCore::LayerRendererChromium::copyOffscreenTextureToDisplay):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::appendQuadsForRenderSurfaceLayer):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::setScissorRect):
(WebCore):
(WebCore::CCRenderSurface::drawContents):
(WebCore::CCRenderSurface::drawReplica):
(WebCore::CCRenderSurface::hasReplica):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(CCRenderSurface):

  • platform/graphics/chromium/cc/CCRenderSurfaceDrawQuad.cpp:

(WebCore::CCRenderSurfaceDrawQuad::create):
(WebCore::CCRenderSurfaceDrawQuad::CCRenderSurfaceDrawQuad):

  • platform/graphics/chromium/cc/CCRenderSurfaceDrawQuad.h:

(CCRenderSurfaceDrawQuad):
(WebCore::CCRenderSurfaceDrawQuad::isReplica):

10:22 Changeset [113452] by schenney@chromium.org

RenderSVGRoot should inherit from RenderReplaced
https://bugs.webkit.org/show_bug.cgi?id=76446

Unreviewed Chromium expectations update.

Second attempt, after the rebaseline tool put expectations in chromium-linux-x86 instead of chormium-linux.

  • platform/chromium-linux-x86/svg/custom/mouse-move-on-svg-container-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/mouse-move-on-svg-root-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/mouse-move-on-svg-root-standalone-expected.png: Removed.
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-container-expected.png:
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-root-expected.png:
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
10:10 Changeset [113451] by paroga@webkit.org

Remove JSC dependency from GregorianDateTime
https://bugs.webkit.org/show_bug.cgi?id=83290

Reviewed by Geoffrey Garen.

This allows us to move it to WTF later.

  • runtime/DateConstructor.cpp:

(JSC::callDate):

  • runtime/JSDateMath.h:
10:10 Changeset [113450] by mrobinson@webkit.org

[GObject bindings] Fix the coding style issues in the generated bindings
https://bugs.webkit.org/show_bug.cgi?id=82080

Reviewed by Kentaro Hara.

No new tests. This is covered by the binding tests.

  • bindings/scripts/CodeGeneratorGObject.pm: Fix most style errors in the generated GObject code.
  • bindings/scripts/test/GObject: Updated the expected results.
10:03 Changeset [113449] by adamk@chromium.org

Remove bogus assert from ChildListMutationScope
https://bugs.webkit.org/show_bug.cgi?id=83336

Reviewed by Ryosuke Niwa.

Source/WebCore:

This assert can trivially be triggered from script, but luckily the
code already behaves correctly without it.

  • dom/ChildListMutationScope.cpp:

(WebCore::ChildListMutationScope::MutationAccumulator::enqueueMutationRecord):

LayoutTests:

Added a test that would trigger the assert.

  • fast/mutation/observe-childList-expected.txt:
  • fast/mutation/observe-childList.html:
09:39 Changeset [113448] by commit-queue@webkit.org

Unreviewed, rolling out r113442.
http://trac.webkit.org/changeset/113442
https://bugs.webkit.org/show_bug.cgi?id=83373

for breaking JSC bindings compilation (Requested by pfeldman
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-06

  • GNUmakefile.list.am:
  • Target.pri:
  • UseJSC.cmake:
  • UseV8.cmake:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSMutationCallbackCustom.cpp: Added.

(WebCore):
(WebCore::JSMutationCallback::handleEvent):

  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:

(AddIncludesForTypeInImpl):
(GenerateCallbackHeader):
(GenerateCallbackImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateCallbackHeader):
(GenerateCallbackImplementation):

  • bindings/scripts/test/JS/JSTestCallback.cpp:

(WebCore::JSTestCallback::callbackWithBoolean):

  • bindings/scripts/test/JS/JSTestCallback.h:

(JSTestCallback):

  • bindings/scripts/test/TestCallback.idl:
  • bindings/scripts/test/V8/V8TestCallback.cpp:

(WebCore::V8TestCallback::callbackWithBoolean):

  • bindings/scripts/test/V8/V8TestCallback.h:

(V8TestCallback):

  • bindings/v8/custom/V8MutationCallbackCustom.cpp: Added.

(WebCore):
(WebCore::V8MutationCallback::handleEvent):

  • dom/MutationCallback.idl:
09:26 Changeset [113447] by leviw@chromium.org

Add transitional abs method to LayoutTypes and remove remaining unnecessary expandedIntSize calls.

09:13 Changeset [113446] by commit-queue@webkit.org

[Gtk] Unskip the video track tests
https://bugs.webkit.org/show_bug.cgi?id=82590

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-04-06
Reviewed by Martin Robinson.

Source/WebCore:

Enable the video track runtime feature for the Gtk port as well.

No new tests - existing ones will be unskipped.

  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

LayoutTests:

Unskip passing video track tests and update expectations
where necessary.

  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
09:09 Changeset [113445] by msaboff@apple.com

Call Heap::discardAllCompiledCode() in low memory situations
https://bugs.webkit.org/show_bug.cgi?id=83335

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Restructured Heap::discardAllCompiledCode() to do the "Is JavaScriptRunning?"
check inline so that it can be called directly without this check.

  • heap/Heap.cpp:

(JSC::Heap::discardAllCompiledCode):
(JSC::Heap::collectAllGarbage):

  • heap/Heap.h: Added JS_EXPORT_PRIVATE to discardAllCompiledCode() so it can be

called from WebCore.
(Heap):

  • runtime/JSGlobalData.h: Removed unused " void discardAllCompiledCode()" declaration.

(JSGlobalData):

Source/WebCore:

Added call to discardAllCompiledCode() when under memory pressure.
We can re-JIT as needed. This is similar to what we used to do when we did
a full GC which also cleaned up JIT code. Doing a full GC typically didn't
help our memory situation, in fact it made things worse in the really low
memory situation as it caused more paging.

Added pass through discardAllCompiledCode() method to GCController.

  • bindings/js/GCController.cpp:

(WebCore::GCController::discardAllCompiledCode):
(WebCore):

  • bindings/js/GCController.h:

(GCController):

  • platform/mac/MemoryPressureHandlerMac.mm:

(WebCore::MemoryPressureHandler::releaseMemory):

09:05 Changeset [113444] by leviw@chromium.org

Using pixel snapping instead of flooring for Floating object reporting.

09:04 Changeset [113443] by caseq@chromium.org

Web Inspector: on a single click in Timeline overview, make a minimal selection centered around cursor
https://bugs.webkit.org/show_bug.cgi?id=82616

Reviewed by Pavel Feldman.

  • center minimal selection on mouse cursor if the mouse hasn't moved (i.e. we had a click, not drag)
  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewWindow.prototype._endWindowSelectorDragging):

08:45 Changeset [113442] by haraken@chromium.org

Add CodeGenerator support for sequence<> in callbacks.
https://bugs.webkit.org/show_bug.cgi?id=83233

Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-04-06
Reviewed by Kentaro Hara.

Tests: TestCallback.idl and fast/mutation/callback-arguments.html should pass even after
the changes.

  • GNUmakefile.list.am: Removed unsued custom files V8MutationCallbackCustom.cpp and JSMutationCallbackCustom.cpp from builds.
  • Target.pri: Ditto.
  • UseJSC.cmake: Ditto.
  • UseV8.cmake: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSMutationCallbackCustom.cpp: Removed.
  • bindings/scripts/CodeGeneratorJS.pm:

(AddIncludesForTypeInImpl): Add proper header type.
(GenerateCallbackHeader): Generate declaration for the callback with sequence<T> argument.
(GenerateCallbackImplementation): Generate implementation for the callback with sequence<T> argument.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateCallbackHeader): Generate declaration for the callback with sequence<T> argument.
(GenerateCallbackImplementation): Generate implementation for the callback with sequence<T> argument.

  • bindings/scripts/test/JS/JSTestCallback.cpp: Modified test results of run-bindings-tests.

(WebCore):
(WebCore::JSTestCallback::handleEvent):

  • bindings/scripts/test/JS/JSTestCallback.h: Modified test results of run-bindings-tests.

(JSTestCallback):

  • bindings/scripts/test/TestCallback.idl: Added test callback with sequence<> argument.
  • bindings/scripts/test/V8/V8TestCallback.cpp: Modified test results of run-bindings-tests.

(WebCore):
(WebCore::V8TestCallback::handleEvent):

  • bindings/scripts/test/V8/V8TestCallback.h: Modified test results of run-bindings-tests.

(V8TestCallback):

  • bindings/v8/custom/V8MutationCallbackCustom.cpp: Removed.
  • dom/MutationCallback.idl: Removed custom bindings using sequence<T>.
08:33 Changeset [113441] by pfeldman@chromium.org

Unreviewed, rolling out r113431.
http://trac.webkit.org/changeset/113431
https://bugs.webkit.org/show_bug.cgi?id=83372

for breaking at least Chromium compilation (Requested by
pfeldman on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-06

  • rendering/RenderView.cpp:

(WebCore::RenderView::paint):
(WebCore::RenderView::shouldRepaint):
(WebCore::RenderView::repaintViewRectangle):
(WebCore::RenderView::repaintRectangleInViewAndCompositedLayers):
(WebCore::RenderView::computeRectForRepaint):
(WebCore::RenderView::selectionBounds):
(WebCore::RenderView::viewRect):
(WebCore::RenderView::unscaledDocumentRect):

  • rendering/RenderView.h:

(RenderView):

08:30 Changeset [113440] by pfeldman@chromium.org

Web Inspector: CodeGeneratorInspector.py: completely switch all domains to 'strict' mode
https://bugs.webkit.org/show_bug.cgi?id=83332

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-04-06
Reviewed by Pavel Feldman.

Hardcoded list of domains is removed from generator. Partial domain sorting is dropped as unneeded.
Types with open propery list are introduced: validator allows undocumented properties for them.

Timeline domain code is patched to do runtimeCast in the last moment because true switching to
type-safe interfaces should take significant time and should be done separately.

  • inspector/CodeGeneratorInspector.py:

(Generator.go):
(Generator.process_event):
(Generator.process_command):

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::willSendResourceRequest):
(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):

08:29 Changeset [113439] by schenney@chromium.org

RenderSVGRoot should inherit from RenderReplaced
https://bugs.webkit.org/show_bug.cgi?id=76446

Unreviewed Chromium test expectations update.

  • platform/chromium-linux-x86/svg/custom/mouse-move-on-svg-container-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/mouse-move-on-svg-root-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/mouse-move-on-svg-root-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/mouse-move-on-svg-root-standalone-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/mouse-move-on-svg-root-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/mouse-move-on-svg-root-expected.txt: Added.
  • platform/chromium-win-xp/svg/custom/mouse-move-on-svg-root-expected.png: Added.
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-expected.png:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-expected.txt:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.png:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.txt:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
  • platform/chromium-win/svg/custom/pointer-events-text-css-transform-expected.txt:
  • platform/chromium/test_expectations.txt:
08:23 Changeset [113438] by pfeldman@chromium.org

Web Inspector: CodeGeneratorInspector.py: stop accepting raw InspectorObject in generated setters
https://bugs.webkit.org/show_bug.cgi?id=83327

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-04-06
Reviewed by Pavel Feldman.

Generator fixed to have strict types in generated setter methods.

Client code is switched from InspectorObject's and String's to generated types where
needed.

  • inspector/CodeGeneratorInspector.py:

(AdHocTypeContext):
(format_setter_value_expression):

  • inspector/ConsoleMessage.cpp:

(WebCore::messageSourceValue):
(WebCore::messageTypeValue):
(WebCore::messageLevelValue):
(WebCore::ConsoleMessage::addToFrontend):

  • inspector/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::buildArrayForApplicationCacheResources):
(WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCacheResource):

  • inspector/InspectorApplicationCacheAgent.h:

(InspectorApplicationCacheAgent):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::asInspectorStyleSheet):
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
(WebCore::InspectorCSSAgent::detectOrigin):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForNode):

  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):

  • inspector/InspectorMemoryAgent.cpp:
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::buildObjectForFrameTree):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::buildObjectForTiming):
(WebCore::buildObjectForCachedResource):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::buildObjectForStyle):
(WebCore::InspectorStyleSheet::create):
(WebCore::InspectorStyleSheet::InspectorStyleSheet):
(WebCore::InspectorStyleSheet::buildObjectForRule):
(WebCore::InspectorStyleSheet::resourceStyleSheetText):
(WebCore::InspectorStyleSheet::buildArrayForRuleList):
(WebCore::InspectorStyleSheetForInlineStyle::create):
(WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):

  • inspector/InspectorStyleSheet.h:

(InspectorCSSId):
(WebCore::InspectorCSSId::asProtocolValue): method is made template as now it returns 2 formally different types.
(InspectorStyleSheet):
(WebCore::InspectorStyleSheet::canBind):
(InspectorStyleSheetForInlineStyle):

08:17 Changeset [113437] by pfeldman@chromium.org

Web Inspector: highlight diff in the gutter, not in the line content.
https://bugs.webkit.org/show_bug.cgi?id=83371

Reviewed by Yury Semikhatsky.

Now that the editing mode is enabled by default, diff highlighting gets annoying.
I am moving it to the gutter (same decoration as before, but now coloring gutter only).

  • inspector/front-end/TextViewer.js:

(WebInspector.TextEditorGutterPanel.prototype.textChanged):

  • inspector/front-end/textViewer.css:

(.diff-container .webkit-added-line.webkit-line-number):
(.diff-container .webkit-removed-line.webkit-line-number):
(.diff-container .webkit-changed-line.webkit-line-number):

08:08 Changeset [113436] by schenney@chromium.org

Differentiate between SVG/CSS width/height attributes/properties
https://bugs.webkit.org/show_bug.cgi?id=76447

Unreviewed Chromium expectations update.

  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-win-xp/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-win-xp/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-win-xp/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-win-xp/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png:
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt:
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png:
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt:
  • platform/chromium-win/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png:
  • platform/chromium-win/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt:
  • platform/chromium-win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png:
  • platform/chromium-win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt:
  • platform/chromium/test_expectations.txt:
08:04 Changeset [113435] by pfeldman@chromium.org

Web Inspector: remove url from the saved urls map before the save action.
https://bugs.webkit.org/show_bug.cgi?id=83364

Reviewed by Yury Semikhatsky.

URL gets added back upon successful save anyways, but if user chooses cancel saving,
we stop bugging him with the save-as dialog.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._exportAll):
(WebInspector.NetworkLogView.prototype._exportResource):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameResourceTreeElement.prototype._appendSaveAsAction.doSave):
(WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent.doSave):

  • inspector/front-end/TextViewer.js:

(WebInspector.TextViewer.prototype._contextMenu):
(WebInspector.TextViewer.prototype._commitEditing):

  • inspector/front-end/TimelineModel.js:

(WebInspector.TimelineModel.prototype.saveToFile):

  • inspector/front-end/inspector.js:
07:43 Changeset [113434] by caseq@chromium.org

Web Inspector: display frame details in popover on frame strip in Timeline panel
https://bugs.webkit.org/show_bug.cgi?id=83365

Reviewed by Pavel Feldman.

  • added popovers for frame strips;
  • factored out generateAggregatedInfo for reuse in the above;
  • made frame event dividers thinner, darker and greyer.
  • English.lproj/localizedStrings.js: Added "FPS" and "Frame"
  • inspector/front-end/TimelineFrameController.js:

(WebInspector.TimelineFrameController.prototype._flushFrame): added startTimeOffset.
(WebInspector.TimelineFrameController.prototype._createSyntheticFrame): ditto.

  • inspector/front-end/TimelineModel.js:

(WebInspector.TimelineModel.prototype._updateBoundaries):
(WebInspector.TimelineModel.prototype.recordOffsetInSeconds):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._updateFrames): added link to frame to strip div.
(WebInspector.TimelinePanel.prototype._refresh):
(WebInspector.TimelinePanel.prototype._getPopoverAnchor): handle frame anchors separately.
(WebInspector.TimelinePanel.prototype._mouseMove): ditto.
(WebInspector.TimelinePanel.prototype._showPopover):

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.Record.prototype.generatePopupContent):
(WebInspector.TimelinePresentationModel._generateAggregatedInfo): factored out for reuse.
(WebInspector.TimelinePresentationModel.generatePopupContentForFrame):

  • inspector/front-end/inspectorCommon.css:

(.resources-dividers-label-bar):

  • inspector/front-end/timelinePanel.css:

(.timeline .resources-event-divider.timeline-frame-divider): made divider thin and grey.
(.timeline-frame-strip): bumped z-index, added pointer-events: auto.

07:27 Changeset [113433] by pfeldman@chromium.org

Web Inspector: show "dirty" flag for CSS files edited in the resources panel.
https://bugs.webkit.org/show_bug.cgi?id=83363

Reviewed by Yury Semikhatsky.

Added TextEdited notification into the editable source frame, listening to it
in the resources panel.

  • inspector/front-end/ResourceView.js:

(WebInspector.EditableResourceSourceFrame.prototype._contentChanged):
(WebInspector.EditableResourceSourceFrame.prototype.isDirty):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameResourceTreeElement.prototype._appendRevision):
(WebInspector.FrameResourceTreeElement.prototype.sourceView):
(WebInspector.FrameResourceTreeElement.prototype._sourceViewTextEdited):

07:24 Changeset [113432] by pfeldman@chromium.org

Merge 112841 - Web Inspector: breakpoints are not shown in sidebar pane after switching pretty-print mode.
https://bugs.webkit.org/show_bug.cgi?id=82768

Reviewed by Yury Semikhatsky.

Source/WebCore:

When UISourceCode is replaced with another in ScriptsPanel, newly added
UISourceCode could already have breakpoints. We should iterate over existing
breakpoints and add them to sidebar pane.

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):

LayoutTests:

  • inspector/debugger/script-formatter-breakpoints-expected.txt:
  • inspector/debugger/script-formatter-breakpoints.html:

TBR=podivilov@chromium.org
BUG=122184
Review URL: https://chromiumcodereview.appspot.com/10005037

07:10 Changeset [113431] by leviw@chromium.org

Update LayoutUnit usage in RenderView
https://bugs.webkit.org/show_bug.cgi?id=83147

Reviewed by Julien Chaffraix.

Updating the usage of LayoutUnits in RenderView in preparation for sub-pixel layout. This mostly
affects paint and repaint functions, which take LayoutRects up to the RenderView level. This is
necessary as we continue to accumulate sub-pixel offsets up to this level.

No new tests. No change in behavior.

  • rendering/RenderView.cpp:

(WebCore::RenderView::paint): Adding an assert that we're being called to paint on pixel
boundaries. We don't currently ever position RenderViews at sub-pixel offsets.
(WebCore::RenderView::shouldRepaint):
(WebCore::RenderView::repaintViewRectangle): Switching to a LayoutRect and cleaning up a fixme
that used decomposed offsets. Pixel snapping is applied before handing the rect up to the
FrameView.
(WebCore::RenderView::repaintRectangleInViewAndCompositedLayers): Pixel snapping before handing
the rect up to the Compositor.
(WebCore::RenderView::computeRectForRepaint):
(WebCore::RenderView::selectionBounds):
(WebCore::RenderView::viewRect):
(WebCore::RenderView::unscaledDocumentRect):

  • rendering/RenderView.h:

(RenderView):

06:50 Changeset [113430] by leviw@chromium.org

Cleaning up unneeded FractionalLayoutUnit leakage into Win PopupMenu code.

05:53 Changeset [113429] by commit-queue@webkit.org

[BlackBerry] Text selection - Can't select texts
https://bugs.webkit.org/show_bug.cgi?id=83355

Fix the problem of not sending out the result of the function
SelectionHandler::regionForTextQuads(). This regression issue
is introduced by the git commit f9446b7d671d48a833ab0acf12b1e20637e0a910.

Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2012-04-06
Reviewed by George Staikos.

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::regionForTextQuads):

Add code to return the function result.

05:49 Changeset [113428] by caseq@chromium.org

Web Inspector: hide popover on mouseout from anchor
https://bugs.webkit.org/show_bug.cgi?id=83362

Reviewed by Pavel Feldman.

  • start hide popover timer when mouse moves out of popover anchor, as we won't receive mousemove events any more;
  • factored out starting of popover kill timer to a method.
  • inspector/front-end/Popover.js:

(WebInspector.PopoverHelper):
(WebInspector.PopoverHelper.prototype._mouseMove): Factored out StartHidePopoverTimer()
(WebInspector.PopoverHelper.prototype._mouseOut): Just call StartHidePopoverTimer() when mouse moves out of anchor.
(WebInspector.PopoverHelper.prototype._startHidePopoverTimer.doHide):
(WebInspector.PopoverHelper.prototype._startHidePopoverTimer):
(WebInspector.PopoverHelper.prototype._hidePopover): Reset hoverElement (aka anchor) when hiding popover.

05:08 Changeset [113427] by ossy@webkit.org

[Qt] Unskipped some tests that now pass.

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-04-06
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
05:07 Changeset [113426] by caseq@chromium.org

[Chromium] Web Inspector: getEventListeners(window) crashes on NTP
https://bugs.webkit.org/show_bug.cgi?id=83353

Reviewed by Pavel Feldman.

Source/WebCore:

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::getEventListenersCallback):

LayoutTests:

  • inspector/console/command-line-api-getEventListeners-expected.txt:
  • inspector/console/command-line-api-getEventListeners.html:
03:37 Changeset [113425] by tkent@chromium.org

Touch ChromeClient.h to fix Chromium build.
https://bugs.webkit.org/show_bug.cgi?id=83258

  • page/ChromeClient.h:
03:26 Changeset [113424] by ossy@webkit.org

[Qt][Mac] Skip new failing tests to paing the bot green.

  • platform/qt-mac/Skipped:
03:04 Changeset [113423] by ossy@webkit.org

[Qt] Unreviewed gardening.

  • platform/qt-5.0/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
  • platform/qt-5.0/svg/as-image/img-preserveAspectRatio-support-1-expected.txt: Added.
  • platform/qt-arm/Skipped: Skip new failing tests.
03:01 Changeset [113422] by tkent@chromium.org

Initial LocalizedDateICU.cpp implementation
https://bugs.webkit.org/show_bug.cgi?id=60868

Reviewed by Hajime Morita.

Source/WebCore:

Add LocalizedDateICU.cpp, which supports only Date type. It uses a
short format because a date field is keyboard-editable.
e.g. 5/15/11 in US locale.

  • WebCore.gyp/WebCore.gyp: Exclude LocalizedDateNone.cpp.
  • WebCore.gypi: Add LocalizedDateICU.cpp.
  • platform/text/LocalizedDateICU.cpp: Added.

(WebCore::parseLocalizedDate):
(WebCore::formatLocalizedDate):

LayoutTests:

  • platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-expected.txt:
  • platform/chromium/fast/forms/date/date-input-visible-strings-expected.txt: Added.
02:02 Changeset [113421] by ossy@webkit.org

[Qt] Unreviewed gardening, update platform specific expected results.

  • platform/qt/svg/as-image/img-preserveAspectRatio-support-1-expected.txt:
  • platform/qt/svg/as-image/img-preserveAspectRatio-support-2-expected.txt:
  • platform/qt/svg/as-object/object-box-sizing-no-width-height-expected.txt:
  • platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt:
  • platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
01:39 Changeset [113420] by pfeldman@chromium.org

Merge 113336 - Web Inspector: CSS file revisions are not restored upon front-end reopen.
https://bugs.webkit.org/show_bug.cgi?id=83292

Reviewed by Yury Semikhatsky.

Populating suggestions before the panel creation now.

  • inspector/front-end/inspector.js:

(WebInspector._doLoadedDoneWithCapabilities.get if):

TBR=pfeldman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10009039

01:29 Changeset [113419] by ossy@webkit.org

[Qt] Unreviewed gardening.

  • platform/qt/Skipped: Unskip tests after r113323.
00:58 Changeset [113418] by apavlov@chromium.org

[REGRESSION] Refreshed autofill popup renders garbage
https://bugs.webkit.org/show_bug.cgi?id=83255
http://code.google.com/p/chromium/issues/detail?id=118374

The code used to update only the PopupContainer coordinates as if they were the coordinates relative
to the root view. Instead, a WebWidget positioned relative to the screen origin holds the PopupContainer,
so it is the WebWidget that should be positioned in PopupContainer::refresh(), and the PopupContainer's
location should be (0, 0) (and their sizes should always be equal).

Reviewed by Kent Tamura.

No new tests, as the popup appearance is not testable in WebKit.

  • platform/chromium/PopupContainer.cpp:

(WebCore::PopupContainer::layoutAndCalculateWidgetRect): Variable renamed.
(WebCore::PopupContainer::showPopup): Use m_originalFrameRect rather than frameRect()
for passing into chromeClient.
(WebCore::PopupContainer::showInRect): Set up the correct frameRect() for the container.
(WebCore::PopupContainer::refresh): Resize the container and position the WebWidget correctly.

  • platform/chromium/PopupContainer.h:

(PopupContainer):

00:54 Changeset [113417] by zherczeg@webkit.org

[Qt] Unreviewed gardening after r113378. ENABLE(MUTATION_OBSERVERS) is disabled so
fast/mutation/clear-transient-without-delivery.html and
fast/mutation/transient-gc-crash.html have been skipped.

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-04-06
Reviewed by Zoltan Herczeg.

  • platform/qt/Skipped:
00:45 Changeset [113416] by tkent@chromium.org

Calendar Picker: Add code to open/close the calendar picker
https://bugs.webkit.org/show_bug.cgi?id=83258

Reviewed by Hajime Morita.

Source/WebCore:

No new tests. This code is not used because of no ENABLE_INPUT_TYPE_DATE.

  • WebCore.gypi: Add existing header files.
  • html/DateInputType.cpp:

(WebCore::DateInputType::DateInputType):
Moved from DateInputType.h because the constructor depends on
CalendarPickerElement.
(WebCore::DateInputType::createShadowSubtree):
Store a CalendarPickerElement object.
(WebCore::DateInputType::destroyShadowSubtree):
Release the CalendarPickerElement object.
(WebCore::DateInputType::handleBlurEvent):
Close the calendar picker when the input loses focus.

  • html/DateInputType.h:

(DateInputType):

  • Move the constructor definition to DateInputType.cpp
  • Add function declarations
  • Add m_pickerElement data member.
  • html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::hostInput): A helper to get the host <input>.
(WebCore::CalendarPickerElement::defaultEventHandler):
If the element is clicked, open a calendar picker.
(WebCore::CalendarPickerElement::openPopup):
Opens a calendar picker by ChromeClient::openPagePopup().
(WebCore::CalendarPickerElement::closePopup):
Closes a calendar picker by ChromeClient::closePagePopup().
(WebCore::CalendarPickerElement::detach):
Closes a calendar picker when the element loses a renderer.

(WebCore::CalendarPickerElement::contentSize):
Provides the initial size of a popup.
(WebCore::addString): A helper for writeDocument().
(WebCore::addJavaScriptString): ditto.
(WebCore::addProperty): ditto.
(WebCore::CalendarPickerElement::writeDocument):
Provides the source of a popup. The function creates a complete HTML with:

  • WebCore/Resources/calendarPicker.css
  • WebCore/Resources/calendarPicker.js
  • An object to pass localization strings and <input> state

(WebCore::CalendarPickerElement::setValueAndClosePopup):
Sets the value from a calendar picker to the <input>.
(WebCore::CalendarPickerElement::didClosePopup):
Clear the popup object.

  • html/shadow/CalendarPickerElement.h:

(CalendarPickerElement): Add declarations.

  • platform/text/LocalizedCalendarICU.cpp:

(WebCore::getFirstDayOfWeek): Make sure this is 0-base. UCAL_SUNDAY is 1.

Source/WebKit/chromium:

  • features.gypi: Enable ENABLE_PAGE_POPUP for non-Android

platforms. This is needed because ENABLE_CALENDAR_PICKER now depends on
ENABLE_PAGE_POPUP.

  • src/ChroemClientImpl.cpp: Add stubs.

(WebKit::ChromeClientImpl::openPagePopup):
(WebKit::ChromeClientImpl::closePagePopup):

  • src/ChromeClientImpl.h: Add declarations of openPagePopup() and closePagePopup().
Note: See TracTimeline for information about the timeline view.