Timeline


and

04/15/12:

23:37 Changeset [114226] by carlosgc@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Use GRefPtr to delete the default web context in WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=83752

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitWebContext.cpp:

(createDefaultWebContext):

23:23 Changeset [114225] by ossy@webkit.org
  • 8 edits in trunk/LayoutTests

[Qt] Unreviewed morning gardening.

  • platform/qt-4.8/fast/dom/Window/window-properties-expected.txt: Updated after r114150.
  • platform/qt-5.0-wk2/fast/dom/Window/window-properties-expected.txt: Updated after r114150.
  • platform/qt-5.0-wk2/fast/dom/prototype-inheritance-2-expected.txt: Updated after r114200.
  • platform/qt-5.0/fast/dom/Window/window-properties-expected.txt: Updated after r114150.
  • platform/qt-5.0/fast/dom/prototype-inheritance-2-expected.txt: Updated after r114200.
  • platform/qt/Skipped: Skip a test after r114150, because of missing layoutTestController.setBackingScaleFactor().
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt: Updated after r114150.
23:12 Changeset [114224] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

WebCore::weekDayShortLabels() for ICU always returns the fallback labels
https://bugs.webkit.org/show_bug.cgi?id=83991

Reviewed by Hajime Morita.

We need to specfiy 1-based index to udat_getSymbols() with
UDAT_SHORT_WEEKDAYS. Also, udat_countSymbols() with UDAT_SHORT_WEEKDAYS
returns 8.

No new tests because this behavior depends on locale setting.

  • platform/text/LocalizedCalendarICU.cpp:

(WebCore::createLabelVector): Add startIndex argument.
(WebCore::createMonthLabels):
Pass UDAT_JANUARRY(0) as startIndex to createLabelVector().
(WebCore::createWeekDayShortLabels):
Pass UDAT_SUNDAY(1) as startIndex to createLabelVector().

22:32 PrefixedAPIs edited by kojiishi@gmail.com
(diff)
22:21 Changeset [114223] by keishi@webkit.org
  • 7 edits in trunk/Source/WebKit/chromium

Introduce MenuItemID to autofill popup
https://bugs.webkit.org/show_bug.cgi?id=83777

Introducing MenuItemIDs because we want to add multiple separators and
need to identify non-autofill menu items without resorting to the separator position.

Reviewed by Kent Tamura.

  • public/WebAutofillClient.h:

(WebKit::WebAutofillClient::didAcceptAutofillSuggestion): Changed uniqueID to itemID because they aren't unique.
(WebKit::WebAutofillClient::didSelectAutofillSuggestion):

  • public/WebView.h:

(WebView):

  • src/AutofillPopupMenuClient.cpp:

(WebKit::AutofillPopupMenuClient::AutofillPopupMenuClient):
(WebKit::AutofillPopupMenuClient::getSuggestionsCount):
(WebKit::AutofillPopupMenuClient::getSuggestion):
(WebKit::AutofillPopupMenuClient::getLabel):
(WebKit::AutofillPopupMenuClient::getIcon):
(WebKit::AutofillPopupMenuClient::removeSuggestionAtIndex):
(WebKit::AutofillPopupMenuClient::canRemoveSuggestionAtIndex):
(WebKit::AutofillPopupMenuClient::valueChanged):
(WebKit::AutofillPopupMenuClient::selectionChanged):
(WebKit::AutofillPopupMenuClient::itemIsSeparator):
(WebKit::AutofillPopupMenuClient::itemIsWarning):
(WebKit::AutofillPopupMenuClient::initialize):
(WebKit::AutofillPopupMenuClient::setSuggestions):

  • src/AutofillPopupMenuClient.h: Removed m_separatorIndex because now we use itemID to identify separators.

Added m_useLegacyBehavior which is true when it is initialized with a valid separator index. This is to keep
the autofill working even when the chromium side hasn't been updated yet.
(AutofillPopupMenuClient):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::applyAutofillSuggestions):

  • src/WebViewImpl.h:

(WebViewImpl):

21:13 Changeset [114222] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed attempt to chromium-win build fix.

  • editing/DictationAlternative.h:
20:54 Changeset [114221] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

Align JSC/V8 bindings canvas.toDataURL() code flows
https://bugs.webkit.org/show_bug.cgi?id=84003

Reviewed by Eric Seidel.

Align JSC/V8 bindings canvas.toDataURL() code flow so that the binding
code implementations read alike.

No new tests. Covered by existing cnavas toDataURL tests.

  • bindings/js/JSHTMLCanvasElementCustom.cpp:

(WebCore::JSHTMLCanvasElement::toDataURL):

20:05 Changeset [114220] by jpu@apple.com
  • 31 edits
    3 copies
    3 adds in trunk/Source/WebCore

Introducing DictationCommand.
https://bugs.webkit.org/show_bug.cgi?id=83549

Reviewed by Hajime Morita.

No new tests. This patch doesn't introduce any change of new functionality. It prepares for
additional changes which will inlude tests.

On OS X, alternative dictation results need to be stored as document markers. This patch introduces
following changes to achieve this:

  1. Added DictationMarkDetails to store non-string type maker detail.
  2. Introduce DictationCommand, which is similor to TypingCommand, but allows inserting text with attached markers.
  3. Added Editor::insertDictatedText as interaface to WebKit and WebKit2.
  4. Added struct DictationAlternative to pass dictation related info from WebKit to WebCore.

Several fragments of code in TypingCommand can be also used by DictationCommand. So this patch
introduced a new class, TextInsertionBaseCommand. It's a subclass of CompositeEditCommmand, and
base class of both TypingCommand and DictationCommand.

This patch also extends InsertTextCommand class. Its constructor will take an TextInsertionMarkerSupplier
object. After text is inserted to a node, InsertTextCommand would give marker supplier a chance to
add document markers to the inserted text.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:

(WebCore::eventTargetNodeForDocument): Moved this function from EventHandler so that it can be used

by AlternativeTextController.

(WebCore):

  • dom/Document.h:

(WebCore):

  • dom/DocumentMarker.cpp:

(WebCore::DocumentMarker::DocumentMarker): New constructor that takes a pointer to DocumentMarkerDetails object.
(WebCore):

  • dom/DocumentMarker.h:

(WebCore::DocumentMarker::AllMarkers::AllMarkers):
(DocumentMarker):

  • dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::addMarker):
(WebCore):

  • dom/DocumentMarkerController.h:

(DocumentMarkerController):

  • dom/TextEvent.cpp:

(WebCore::TextEvent::createForDictation):
(WebCore):
(WebCore::TextEvent::TextEvent):

  • dom/TextEvent.h: Added member variable for dictation alternatives.

(TextEvent):
(WebCore::TextEvent::isDictation):
(WebCore::TextEvent::dictationAlternatives):

  • dom/TextEventInputType.h:
  • editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::AlternativeTextController):
(WebCore::AlternativeTextController::insertDictatedText): Used by Editor::insertDictatedText().
(WebCore):

  • editing/AlternativeTextController.h:

(WebCore):
(DictationMarkerDetails):
(WebCore::DictationMarkerDetails::create):
(WebCore::DictationMarkerDetails::originalText):
(WebCore::DictationMarkerDetails::dictationContext):
(WebCore::DictationMarkerDetails::DictationMarkerDetails):
(AlternativeTextController):

  • editing/CompositeEditCommand.h:

(WebCore::CompositeEditCommand::isDictationCommand):

  • editing/DictationAlternative.cpp: Added.

(WebCore):
(WebCore::DictationAlternative::DictationAlternative):

  • editing/DictationAlternative.h: Added. Data structure for passing dictation related data from WebKit to WebCore.

(DictationAlternative):
(WebCore):

  • editing/DictationCommand.cpp: Added.

(WebCore):
(DictationCommandLineOperation):
(WebCore::DictationCommandLineOperation::DictationCommandLineOperation):
(WebCore::DictationCommandLineOperation::operator()):
(DictationMarkerSupplier):
(WebCore::DictationMarkerSupplier::create):
(WebCore::DictationMarkerSupplier::addMarkersToTextNode):
(WebCore::DictationMarkerSupplier::DictationMarkerSupplier):
(WebCore::DictationCommand::DictationCommand):
(WebCore::DictationCommand::insertText):
(WebCore::DictationCommand::doApply):
(WebCore::DictationCommand::insertTextRunWithoutNewlines):
(WebCore::DictationCommand::insertParagraphSeparator):
(WebCore::DictationCommand::collectDictationAlternativesInRange):

  • editing/DictationCommand.h: Added.

(WebCore):
(DictationCommand):
(WebCore::DictationCommand::isDictationCommand):
(WebCore::DictationCommand::create):

  • editing/EditingAllInOne.cpp:
  • editing/Editor.cpp:

(WebCore::Editor::insertDictatedText): Main interface that allows WebKit passes in text with attached dictation information.
(WebCore):
(WebCore::Editor::insertTextWithoutSendingTextEvent):
(WebCore::Editor::updateMarkersForWordsAffectedByEditing):

  • editing/Editor.h:

(Editor):

  • editing/InsertTextCommand.cpp:

(WebCore::InsertTextCommand::InsertTextCommand):
(WebCore):
(WebCore::InsertTextCommand::doApply):

  • editing/InsertTextCommand.h:

(WebCore):
(TextInsertionMarkerSupplier): Interface to allow caller of InsertTextCommand to add document markers to inserted text.
(WebCore::TextInsertionMarkerSupplier::~TextInsertionMarkerSupplier):
(WebCore::TextInsertionMarkerSupplier::TextInsertionMarkerSupplier):
(WebCore::InsertTextCommand::createWithMarkerSupplier):
(InsertTextCommand):

  • editing/TextInsertionBaseCommand.cpp: Added. This class contains functions shared by TypingCommand and DictationCommand.

(WebCore):
(WebCore::TextInsertionBaseCommand::TextInsertionBaseCommand):
(WebCore::TextInsertionBaseCommand::applyTextInsertionCommand):
(WebCore::dispatchBeforeTextInsertedEvent):
(WebCore::canAppendNewLineFeedToSelection):

  • editing/TextInsertionBaseCommand.h: Added.

(WebCore):
(TextInsertionBaseCommand):
(WebCore::TextInsertionBaseCommand::~TextInsertionBaseCommand):
(WebCore::forEachLineInString):

  • editing/TypingCommand.cpp:

(TypingCommandLineOperation):
(WebCore::TypingCommandLineOperation::TypingCommandLineOperation):
(WebCore::TypingCommandLineOperation::operator()):
(WebCore::TypingCommand::TypingCommand):
(WebCore::TypingCommand::insertText):
(WebCore::TypingCommand::insertLineBreak):
(WebCore::TypingCommand::insertParagraphSeparator):

  • editing/TypingCommand.h:
  • page/EventHandler.cpp:
  • rendering/InlineTextBox.cpp:

(WebCore::lineStyleForMarkerType):
(WebCore::InlineTextBox::paintDocumentMarker): Renamed existing function to reflect new funcationality.
(WebCore::InlineTextBox::paintDocumentMarkers):

  • rendering/InlineTextBox.h:

(InlineTextBox):

  • testing/Internals.cpp:

(WebCore::markerTypesFrom):

19:49 Changeset [114219] by jamesr@google.com
  • 33 edits
    2 copies
    4 adds
    6 deletes in trunk/LayoutTests

[chromium] Unreviewed rebaselines for various compositing tests.

  • platform/chromium-linux-x86/compositing/reflections/animation-inside-reflection-expected.png: Removed.
  • platform/chromium-linux-x86/compositing/reflections/nested-reflection-animated-expected.png: Removed.
  • platform/chromium-linux/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
  • platform/chromium-linux/compositing/geometry/fixed-position-composited-page-scale-expected.png:
  • platform/chromium-linux/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
  • platform/chromium-linux/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
  • platform/chromium-linux/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
  • platform/chromium-linux/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
  • platform/chromium-linux/compositing/reflections/animation-inside-reflection-expected.png:
  • platform/chromium-linux/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Added.
  • platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.txt: Added.
  • platform/chromium-mac-leopard/compositing/reflections/animation-inside-reflection-expected.png:
  • platform/chromium-mac-leopard/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
  • platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
  • platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
  • platform/chromium-mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.png:
  • platform/chromium-mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.txt: Added.
  • platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
  • platform/chromium-mac/compositing/geometry/fixed-position-composited-page-scale-expected.png:
  • platform/chromium-mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
  • platform/chromium-mac/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
  • platform/chromium-mac/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
  • platform/chromium-mac/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
  • platform/chromium-mac/compositing/reflections/animation-inside-reflection-expected.png:
  • platform/chromium-mac/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-mac/compositing/repaint/newly-composited-repaint-rect-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-page-scale-down-expected.png.
  • platform/chromium-win-vista/compositing/reflections/animation-inside-reflection-expected.png: Removed.
  • platform/chromium-win-vista/compositing/reflections/nested-reflection-animated-expected.png: Removed.
  • platform/chromium-win-xp/compositing/reflections/animation-inside-reflection-expected.txt: Removed.
  • platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.png: Removed.
  • platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.txt: Added.
  • platform/chromium-win/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
  • platform/chromium-win/compositing/geometry/fixed-position-composited-page-scale-expected.png:
  • platform/chromium-win/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
  • platform/chromium-win/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
  • platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
  • platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
  • platform/chromium-win/compositing/reflections/animation-inside-reflection-expected.png:
  • platform/chromium-win/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-win/compositing/repaint/newly-composited-repaint-rect-expected.png: Copied from LayoutTests/platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png.
19:44 Changeset [114218] by commit-queue@webkit.org
  • 16 edits in trunk/Source

[chromium] LayerRendererChromium shouldn't know anything about CCLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=83415

Patch by James Robinson <jamesr@chromium.org> on 2012-04-15
Reviewed by Adrienne Walker.

Source/WebCore:

This removes all knowledge of CCLayerImpl from LayerRendererChromium. The most significant move code-wise is
moving the HUD up to live on CCLayerTreeHostImpl, since it's aware of the layer tree. This involves two changes.
First, CCHeadsUpDisplay is in charge of populating a ManagedTexture but the actual drawing code now lives in
LayerRendererChromium. Second, since we don't recreate CCLayerTreeHostImpl on a lost context, the font atlas
ownership is much simpler. Now a CCFontAtlas is created on the main thread if needed and passed asynchronously
to the CCHeadsUpDisplay which takes ownership of the atlas.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::~LayerRendererChromium):
(WebCore::LayerRendererChromium::beginDrawingFrame):
(WebCore::LayerRendererChromium::drawHeadsUpDisplay):
(WebCore):
(WebCore::LayerRendererChromium::finishDrawingFrame):
(WebCore::LayerRendererChromium::swapBuffers):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromiumClient):
(LayerRendererChromium):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
(WebCore::CCHeadsUpDisplay::setFontAtlas):
(WebCore):
(WebCore::CCHeadsUpDisplay::enabled):
(WebCore::CCHeadsUpDisplay::showPlatformLayerTree):
(WebCore::CCHeadsUpDisplay::draw):
(WebCore::CCHeadsUpDisplay::drawHudContents):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h:

(WebCore):
(WebCore::CCHeadsUpDisplay::create):
(CCHeadsUpDisplay):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initialize):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::canDraw):
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):
(WebCore::CCLayerTreeHostImpl::drawLayers):
(WebCore::CCLayerTreeHostImpl::swapBuffers):
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
(WebCore::CCLayerTreeHostImpl::setFullRootLayerDamage):
(WebCore::CCLayerTreeHostImpl::layerTreeAsText):
(WebCore):
(WebCore::CCLayerTreeHostImpl::setFontAtlas):
(WebCore::CCLayerTreeHostImpl::dumpRenderSurfaces):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::rootLayer):

  • platform/graphics/chromium/cc/CCProxy.h:

(WebCore):
(CCProxy):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::recreateContext):
(WebCore::CCSingleThreadProxy::setFontAtlas):
(WebCore):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::initializeLayerRendererOnImplThread):
(WebCore::CCThreadProxy::setFontAtlas):
(WebCore):
(WebCore::CCThreadProxy::setFontAtlasOnImplThread):
(WebCore::CCThreadProxy::recreateContextOnImplThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

Add an explicit rootLayer getter to the test implementation of LayerRendererChromium since there isn't one on
the base class any more.

  • tests/LayerRendererChromiumTest.cpp:

(FakeLayerRendererChromiumClient::rootLayer):
(FakeLayerRendererChromiumClient):
(TEST_F):

19:40 Changeset [114217] by antti@apple.com
  • 27 edits in trunk

Capture CSS parser context
https://bugs.webkit.org/show_bug.cgi?id=83998

Source/WebCore:

Reviewed by Andreas Kling.

Currently the CSS parser calls to the Document and StyleSheetInternal objects to get settings, base URL etc.
The required information should be passed in on parser construction instead. The parser should not need to
know about the document at all.

The patch adds CSSParserContext struct that captures the parsing context. StyleSheetInternal saves the
parsing context and reuses it for any further parsing.

If the same stylesheet source is parsed with an identical context then the resulting stylesheet structure will
be identical. This will allow sharing parsed stylesheets in the future.

  • css/CSSGrammar.y:
  • css/CSSImportRule.cpp:

(WebCore::StyleRuleImport::setCSSStyleSheet):

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::insertRule):

  • css/CSSPageRule.cpp:

(WebCore::CSSPageRule::setSelectorText):

  • css/CSSParser.cpp:

(WebCore):
(WebCore::strictCSSParserContext):
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::parseKeyframeRule):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseSelector):
(WebCore::CSSParser::completeURL):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseAttr):
(WebCore::CSSParser::parseFillImage):
(WebCore::CSSParser::parseFontFaceSrcURI):
(WebCore::CSSParser::parseFontFaceSrc):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseImageSet):
(WebCore::CSSParser::parseCustomFilter):
(WebCore::CSSParser::parseFilter):
(WebCore::CSSParser::cssRegionsEnabled):
(WebCore::CSSParser::parseFlowThread):
(WebCore::CSSParser::createMediaRule):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createKeyframe):

  • css/CSSParser.h:

(CSSParser):
(WebCore::CSSParser::inStrictMode):
(WebCore::CSSParser::inQuirksMode):
(WebCore::CSSParser::validUnit):

  • css/CSSParserMode.h:

(WebCore):
(CSSParserContext):

  • css/CSSRule.h:

(WebCore::CSSRule::parserContext):
(CSSRule):

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::setSelectorText):

  • css/CSSStyleSheet.cpp:

(WebCore::StyleSheetInternal::StyleSheetInternal):
(WebCore::StyleSheetInternal::parseString):
(WebCore::StyleSheetInternal::parseStringAtLine):
(WebCore):
(WebCore::StyleSheetInternal::updateBaseURL):
(WebCore::StyleSheetInternal::completeURL):
(WebCore::CSSStyleSheet::insertRule):

  • css/CSSStyleSheet.h:

(StyleSheetInternal):
(WebCore::StyleSheetInternal::parserContext):
(WebCore::StyleSheetInternal::charset):
(WebCore::StyleSheetInternal::setFinalURL):
(WebCore::StyleSheetInternal::baseURL):

  • css/CSSValuePool.cpp:
  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::parseDeclaration):

  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::insertRule):

  • dom/Document.cpp:

(WebCore::Document::webkitGetFlowByName):
(WebCore::Document::pageUserSheet):
(WebCore::Document::pageGroupUserSheets):

  • dom/Element.cpp:

(WebCore::Element::webkitMatchesSelector):

  • dom/Node.cpp:

(WebCore::Node::querySelector):
(WebCore::Node::querySelectorAll):

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::parseStyleSheet):

  • dom/StyleElement.cpp:

(WebCore::StyleElement::createSheet):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::setCSSStyleSheet):

  • html/shadow/ContentSelectorQuery.cpp:

(WebCore::ContentSelectorQuery::ContentSelectorQuery):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyleSheet::reparseStyleSheet):
(WebCore::InspectorStyleSheet::ensureSourceData):
(WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):

LayoutTests:

Reviewed by Andreas Kling.

Modify the tests so that they don't expect settings changes to apply to already existing stylesheets.

  • css3/filters/script-tests/custom-filter-property-parsing.js:
  • fast/regions/script-tests/css-regions-disabled.js:
19:14 Changeset [114216] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

[Cairo] Separate image encoding from dataURL construction
https://bugs.webkit.org/show_bug.cgi?id=83975

Reviewed by Martin Robinson.

Remove the implicit assumption that a dataURL is the only desired output format
of the image encoding phase.

No new tests. Covered by existing canvas toDataURL tests.

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::writeFunction): Rename closure to output.
(WebCore::encodeImage): Output the encoded image to the provided Vector<char>.
PNG format is only supported per the Cairo encoding MIMETypeRegistry.
(WebCore):
(WebCore::ImageBuffer::toDataURL): Refactor to use encodeImage().

18:43 Changeset [114215] by yutak@chromium.org
  • 7 edits in trunk/Source

Leak in WebSocketChannel with workers/worker-reload.html (part 2)
https://bugs.webkit.org/show_bug.cgi?id=83749

Reviewed by David Levin.

Source/WebCore:

Second attempt to remove leaks around WorkerThreadableWebSocketChannel.

No new tests, as this patch does not impose any functional change.

  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
(WebCore::ThreadableWebSocketChannelClientWrapper::failedWebSocketChannelCreation):
(WebCore::ThreadableWebSocketChannelClientWrapper::setFailedWebSocketChannelCreation):

  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:

Add a boolean flag indicating whether Bridge::initialize() has exited without receiving
a pointer to the peer object.

  • Modules/websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::WorkerContextDidInitializeTask::create):
(WebCore::WorkerThreadableWebSocketChannel::WorkerContextDidInitializeTask::WorkerContextDidInitializeTask):
(WebCore::WorkerThreadableWebSocketChannel::WorkerContextDidInitializeTask::performTask):
Kick mainThreadDestroy() to delete the peer if the bridge has failed to receive
a pointer to the peer (waitForMethodCompletion() exited due to message queue's
termination).
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadInitialize):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::initialize):

  • Modules/websockets/WorkerThreadableWebSocketChannel.h:

(WorkerThreadableWebSocketChannel):
Make WorkerContextDidInitializeTask an inner class of WorkerThreadableWebSocketChannel
so it can refer WorkerThreadableWebSocketChannel's static member function (mainThreadDestroy()).

Source/WebKit/chromium:

  • src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::postTaskForModeToWorkerContext):
Correctly propagate the return value of postTaskForModeToWorkerContext().

16:15 Changeset [114214] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Chromium perf bots should not build
https://bugs.webkit.org/show_bug.cgi?id=83641

Reviewed by Eric Seidel.

Don't build on perf bots to improve the cycle time.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
08:23 Changeset [114213] by rakuco@webkit.org
  • 1 delete in trunk/LayoutTests/platform/efl/fast/regions

Remove empty directory.

08:21 Changeset [114212] by rakuco@webkit.org
  • 2 edits
    50 deletes in trunk/LayoutTests

[EFL] Gardening. Skip fast/regions tests.

SVN r90067 skipped fast/regions for many ports, but EFL's skipped
list was added later. Skip all tests there and remove existing
baselines.

  • platform/efl/Skipped:
  • platform/efl/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
  • platform/efl/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Removed.
  • platform/efl/fast/regions/flow-content-basic-vertical-expected.png: Removed.
  • platform/efl/fast/regions/flow-content-basic-vertical-expected.txt: Removed.
  • platform/efl/fast/regions/flow-content-basic-vertical-rl-expected.png: Removed.
  • platform/efl/fast/regions/flow-content-basic-vertical-rl-expected.txt: Removed.
  • platform/efl/fast/regions/flows-dependency-dynamic-remove-expected.png: Removed.
  • platform/efl/fast/regions/flows-dependency-dynamic-remove-expected.txt: Removed.
  • platform/efl/fast/regions/flows-dependency-same-flow-expected.png: Removed.
  • platform/efl/fast/regions/flows-dependency-same-flow-expected.txt: Removed.
  • platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Removed.
  • platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Removed.
  • platform/efl/fast/regions/overflow-in-uniform-regions-dynamic-expected.png: Removed.
  • platform/efl/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt: Removed.
  • platform/efl/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png: Removed.
  • platform/efl/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Removed.
  • platform/efl/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png: Removed.
  • platform/efl/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt: Removed.
  • platform/efl/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.png: Removed.
  • platform/efl/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt: Removed.
  • platform/efl/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.png: Removed.
  • platform/efl/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.txt: Removed.
  • platform/efl/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.png: Removed.
  • platform/efl/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.txt: Removed.
  • platform/efl/fast/regions/percentage-margins-rtl-variable-width-regions-expected.png: Removed.
  • platform/efl/fast/regions/percentage-margins-rtl-variable-width-regions-expected.txt: Removed.
  • platform/efl/fast/regions/percentage-margins-variable-width-regions-expected.png: Removed.
  • platform/efl/fast/regions/percentage-margins-variable-width-regions-expected.txt: Removed.
  • platform/efl/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
  • platform/efl/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
  • platform/efl/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
  • platform/efl/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
  • platform/efl/fast/regions/text-region-split-small-pagination-expected.png: Removed.
  • platform/efl/fast/regions/text-region-split-small-pagination-expected.txt: Removed.
  • platform/efl/fast/regions/top-overflow-out-of-second-region-expected.png: Removed.
  • platform/efl/fast/regions/top-overflow-out-of-second-region-expected.txt: Removed.
  • platform/efl/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Removed.
  • platform/efl/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Removed.
  • platform/efl/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Removed.
  • platform/efl/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Removed.
  • platform/efl/fast/regions/webkit-flow-float-unable-to-push-expected.png: Removed.
  • platform/efl/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Removed.
  • platform/efl/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png: Removed.
  • platform/efl/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Removed.
  • platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png: Removed.
  • platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Removed.
  • platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.png: Removed.
  • platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Removed.
  • platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.png: Removed.
  • platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Removed.

04/14/12:

20:51 Changeset [114211] by eae@chromium.org
  • 4 edits in trunk/Source/WebCore

Fix pixelSnapping for CalendarPicker, MediaControl and ScrollbarPart
https://bugs.webkit.org/show_bug.cgi?id=83929

Reviewed by Eric Seidel.

Update CalendarPickerElement and MediaControlElements to use
pixelSnappedSize in preparation for turning on subpixel support.
Update RenderScrollbarPart to pixel snap rect before painting to ensure
that it is painted on device pixel boundaries.

No new tests, no change in functionality.

  • html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::openPopup):

  • html/shadow/MediaControlElements.cpp:

(WebCore::RenderMediaVolumeSliderContainer::layout):

  • rendering/RenderScrollbarPart.cpp:

(WebCore::RenderScrollbarPart::paintIntoRect):

20:31 Changeset [114210] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Day of week labels are wrong if WebCore::firstDayOfWeek() is not 0
https://bugs.webkit.org/show_bug.cgi?id=83990

Reviewed by Kentaro Hara.

We passed the "weekStartDay" property value as a
string. CalendarPickerElement::writeDocument() created:

weekStartDay: "1",

and the JavaScript code used it in the following code:

dayLabels[(weekStartDay + i) % 7]

If weekStartDay was "1", the expression (weekStartDay + i)
produced "10", "11", "12", ... We expected "1", "2", "3", ...

We need to pass the "weekStartDay" property as a number.

No new tests because we have no ways to test this for now. We'll
introduce tests for the calendar picker later.

  • html/shadow/CalendarPickerElement.cpp:

(WebCore::addProperty): Add addProperty() function for a number.
(WebCore::CalendarPickerElement::writeDocument):
Pass a number, not a serialized number.

17:43 Changeset [114209] by weinig@apple.com
  • 2 edits in trunk/Source/WTF

Harden WTF::ByteArray::create()
https://bugs.webkit.org/show_bug.cgi?id=83318

Reviewed by Maciej Stachowiak.

  • wtf/ByteArray.cpp:

(WTF::ByteArray::create):
Add overflow check. I don't believe there is anyway to trigger this currently,
hence no tests, so this should be considered hardening.

14:29 Changeset [114208] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk

Viewport-percentage Length units does not work for Replaced elements size
https://bugs.webkit.org/show_bug.cgi?id=83425

Patch by Joe Thomas <joethomas@motorola.com> on 2012-04-14
Reviewed by Antti Koivisto.

Added the support for viewport-percentage length units while calculating the width/height of replaced elements.

Source/WebCore:

Tests: css3/viewport-percentage-lengths/viewport-percentage-image-size.html

  • platform/Length.h:

(WebCore::Length::isSpecified):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalWidthUsing):

LayoutTests:

  • css3/viewport-percentage-lengths/resources: Added.
  • css3/viewport-percentage-lengths/resources/colorsquare.png: Added.
  • css3/viewport-percentage-lengths/viewport-percentage-image-size-expected.html: Added.
  • css3/viewport-percentage-lengths/viewport-percentage-image-size.html: Added.
14:05 Changeset [114207] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

CSSStyleDeclaration.getPropertyValue() for 'border-radius' returns null when value is set
https://bugs.webkit.org/show_bug.cgi?id=80736

Patch by Joe Thomas <joethomas@motorola.com> on 2012-04-14
Reviewed by Antti Koivisto.

Added support for fetching the value of 'border-radius' CSS property which was missing.

Source/WebCore:

Test: fast/css/border-radius-property-value.html

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getPropertyValue):

LayoutTests:

  • fast/css/border-radius-property-value-expected.txt: Added.
  • fast/css/border-radius-property-value.html: Added.
11:29 Changeset [114206] by commit-queue@webkit.org
  • 4 edits in trunk

[WK2] Set WebKitTestRunner's WebProcess cache model to DocumentBrowser.
https://bugs.webkit.org/show_bug.cgi?id=81945

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-14
Reviewed by Dan Bernstein.

Tools:

WebProcess's default cache model is DocumentViewer. When DocumentViewer model is on,
the PageCache's capacity is set to 0. Tests that are enabling 'WebKitUsesPageCachePreferenceKey' expect
PageCache to be functional.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

LayoutTests:

Re-enable 2 tests where WebKitUsesPageCachePreferenceKey is set.

  • platform/mac-wk2/Skipped:
11:15 Changeset [114205] by hyatt@apple.com
  • 3 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=83826

Wrong Font code path was chosen after r114032. The TextRun constructor has an additional argument that
needs to be included if rounding hacks are mentioned.

Reviewed by Dan Bernstein.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawTextInternal):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::paintItemForeground):

  • rendering/break_lines.cpp:

(WebCore::nextBreakablePosition):

03:30 WebKitGTK edited by sh4.seo@samsung.com
Use internal link (diff)
02:34 Changeset [114204] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

[Cairo] ImageBuffer::toDataURL(): improve error handling, add mimeType ASSERTs
https://bugs.webkit.org/show_bug.cgi?id=83569

Reviewed by Eric Seidel.

No new tests. Covered by exiting fast/canvas/*toDataURL* tests.

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::writeFunction): Return write success or failure with the appropriate
cairo status code per http://cairographics.org/manual/cairo-PNG-Support.html
(WebCore::ImageBuffer::toDataURL): Add mimeType ASSERT()s. <canvas> ensures that
a valid mimeType (supported by the port) is sent to toDataURL() calls. Check for
encoding failure and return "data:," if so.

04/13/12:

23:02 Changeset [114203] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[Chromium] Avoid unnecessary full tile updates for checkerboard tiles.
https://bugs.webkit.org/show_bug.cgi?id=83804

Patch by David Reveman <reveman@chromium.org> on 2012-04-13
Reviewed by James Robinson.

Source/WebCore:

Cleanup code that determines if we need to use a buffered update and
avoid buffering of tiles that are not in use by the impl thread.

Tests: CCLayerTreeHostTestAtomicCommitWithPartialUpdate.runMultiThread

TiledLayerChromiumTest.partialUpdates

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(UpdatableTile):
(WebCore::UpdatableTile::UpdatableTile):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::tileOnlyNeedsPartialUpdate):
(WebCore::TiledLayerChromium::tileNeedsBufferedUpdate):
(WebCore::TiledLayerChromium::updateTiles):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::bufferedUpdates):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF::setLayerPropertiesForTesting):
(WTF):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::beginTest):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::layout):
(WTF::setTestLayerPropertiesForTesting):
(WTF::CCLayerTreeHostTestLayerOcclusion::beginTest):
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):
(WTF::CCLayerTreeHostTestManySurfaces::beginTest):

  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):

20:32 Changeset [114202] by danakj@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Cleanup texture memory eviction when LayerTreeHost becomes invisible
https://bugs.webkit.org/show_bug.cgi?id=83899

Reviewed by Adrienne Walker.

When a LTH becomes invisible, the texture eviction is spread out across
two different functions and is not entirely clear. We move all the logic
together into a single place in didBecomeInvisibleOnImplThread() and
make the consequences of the current code more clear.

Covered by existing tests.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::deleteContentsTexturesOnImplThread):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):

20:07 Changeset [114201] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] There is no Color(float, float, float) constructor, fix an attempt to call it.
https://bugs.webkit.org/show_bug.cgi?id=83920

Reviewed by James Robinson.

Found by clang:

third_party/WebKit/Source/WebKit/chromium/tests/LayerChromiumTest.cpp:508:89:error: implicit conversion turns literal floating-point number into integer: 'float' to 'int' [-Werror,-Wliteral-conversion]
EXECUTE_AND_VERIFY_SET_NEEDS_COMMIT_BEHAVIOR(1, testLayer->setBackgroundColor(Color(0.4f, 0.4f, 0.4f)));

  • tests/LayerChromiumTest.cpp:
20:06 Changeset [114200] by commit-queue@webkit.org
  • 39 edits
    6 deletes in trunk

Unreviewed, rolling out r114036.
http://trac.webkit.org/changeset/114036
https://bugs.webkit.org/show_bug.cgi?id=83969

Breaks gmail.com causing it to never finish loading (Requested
by danakj on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-13

Source/WebCore:

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNamedConstructorCallback):
(GenerateImplementation):

  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::createPrototype):

  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore):

  • bindings/v8/NPV8Object.cpp:

(WebCore::npObjectTypeInfo):

  • bindings/v8/V8BindingPerContextData.cpp:

(WebCore::V8BindingPerContextData::init):
(WebCore::V8BindingPerContextData::createWrapperFromCacheSlowCase):
(WebCore::V8BindingPerContextData::constructorForTypeSlowCase):

  • bindings/v8/V8BindingPerContextData.h:

(V8BindingPerContextData):

  • bindings/v8/V8HiddenPropertyName.h:

(WebCore):

  • bindings/v8/WrapperTypeInfo.h:

(WrapperTypeInfo):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore):

  • dom/NodeList.idl:

LayoutTests:

  • fast/dom/HTMLSelectElement/named-options-expected.txt:
  • fast/dom/HTMLSelectElement/script-tests/named-options.js:
  • fast/dom/NodeList/node-list-array-class-expected.txt: Removed.
  • fast/dom/NodeList/node-list-array-class.html: Removed.
  • fast/dom/NodeList/nodelist-item-call-as-function-expected.txt:
  • fast/dom/everything-to-string-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/js/recursion-limit-equal-expected.txt:
  • inspector/console/command-line-api-expected.txt:
  • inspector/console/console-dir-expected.txt:
  • inspector/console/console-format-collections-expected.txt:
  • jquery/traversing-expected.txt:
  • platform/chromium/fast/dom/HTMLSelectElement/named-options-expected.txt: Removed.
  • platform/chromium/fast/dom/everything-to-string-expected.txt: Removed.
  • platform/chromium/inspector/console/command-line-api-expected.txt: Removed.
  • platform/chromium/inspector/console/console-dir-expected.txt:
  • platform/chromium/inspector/console/console-format-collections-expected.txt:
  • platform/chromium/jquery/traversing-expected.txt: Removed.
  • platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
20:02 Changeset [114199] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Add null pointer check to animatePageScale
https://bugs.webkit.org/show_bug.cgi?id=83940

Patch by Alexandre Elias <aelias@google.com> on 2012-04-13
Reviewed by James Robinson.

Add null pointer check to startPageScaleAnimation.

If the root scroll layer goes away in the middle of a page scale
animation, there can be a null pointer access here.

No new tests.

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::animatePageScale):

19:33 Changeset [114198] by jchaffraix@webkit.org
  • 5 edits in trunk/LayoutTests

Two lineboxcontain tests are failing
https://bugs.webkit.org/show_bug.cgi?id=82742

Reviewed by Ojan Vafai.

  • platform/mac/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt:
  • platform/mac/fast/block/lineboxcontain/glyphs-expected.txt:

Rebaselined.

  • platform/mac/Skipped:
  • platform/mac/test_expectations.txt:

Unskip some tests that are either rebaselined or now passing due to
r112582 re-adding some of the RenderLayers removed by r110072.

18:58 Changeset [114197] by danakj@chromium.org
  • 6 edits in trunk/Source

[chromium] Replicas should be included in the computed occlusion
https://bugs.webkit.org/show_bug.cgi?id=82262

Reviewed by Adrienne Walker.

Source/WebCore:

When merging a surface's occlusion up to its target, make a copy of it
where the replica will be as well, and make sure that occlusion from a
RenderSurface does not leave its clipRect.

Unit test: CCOcclusionTrackerTestReplicaDoesOcclude

CCOcclusionTrackerTestReplicaWithClipping
CCOcclusionTrackerTestSurfaceChildOfSurface

  • platform/graphics/chromium/RenderSurfaceChromium.cpp:

(WebCore::RenderSurfaceChromium::hasReplica):
(WebCore):

  • platform/graphics/chromium/RenderSurfaceChromium.h:

(RenderSurfaceChromium):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::transformSurfaceOpaqueRegion):
(WebCore::::leaveToTargetRenderSurface):

Source/WebKit/chromium:

  • tests/CCOcclusionTrackerTest.cpp:

(CCOcclusionTrackerTestReplicaDoesOcclude):
(WebKitTests::CCOcclusionTrackerTestReplicaDoesOcclude::runMyTest):
(WebKitTests):
(CCOcclusionTrackerTestReplicaWithClipping):
(WebKitTests::CCOcclusionTrackerTestReplicaWithClipping::runMyTest):
(CCOcclusionTrackerTestSurfaceChildOfSurface):
(WebKitTests::CCOcclusionTrackerTestSurfaceChildOfSurface::runMyTest):

18:30 Changeset [114196] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add layout test case for JavaScriptAudioNode.
https://bugs.webkit.org/show_bug.cgi?id=83747

Patch by Raymond Liu <raymond.liu@intel.com> on 2012-04-13
Reviewed by Chris Rogers.

  • webaudio/javascriptaudionode-expected.txt: Added.
  • webaudio/javascriptaudionode.html: Added.
18:29 Changeset [114195] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r114185.
http://trac.webkit.org/changeset/114185
https://bugs.webkit.org/show_bug.cgi?id=83967

Broke a bunch of JavaScript related tests (Requested by
andersca on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-13

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):

  • runtime/CommonIdentifiers.h:
  • tests/mozilla/ecma/Array/15.4.4.2.js:

(getTestCases):

18:27 Changeset [114194] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

convolution-mono-mono test passes now
https://bugs.webkit.org/show_bug.cgi?id=83793

Patch by Raymond Toy <rtoy@google.com> on 2012-04-13
Reviewed by Eric Seidel.

  • platform/chromium/test_expectations.txt: Delete entry.
18:25 Changeset [114193] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

AudioContext createChannelMerger() method should have optional argument for number of inputs.
https://bugs.webkit.org/show_bug.cgi?id=83759

Patch by Raymond Liu <raymond.liu@intel.com> on 2012-04-13
Reviewed by Chris Rogers.

Check https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html for the optional argument.

Source/WebCore:

Test: webaudio/audiochannelmerger-basic.html

  • Modules/webaudio/AudioChannelMerger.cpp:

(WebCore):
(WebCore::AudioChannelMerger::create):
(WebCore::AudioChannelMerger::AudioChannelMerger):

  • Modules/webaudio/AudioChannelMerger.h:

(AudioChannelMerger):

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::createChannelMerger):
(WebCore):

  • Modules/webaudio/AudioContext.h:

(AudioContext):

  • Modules/webaudio/AudioContext.idl:

LayoutTests:

  • webaudio/audiochannelmerger-basic-expected.txt: Added.
  • webaudio/audiochannelmerger-basic.html: Added.
18:20 Changeset [114192] by barraclough@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Don't rely on fixed offsets to patch calls
https://bugs.webkit.org/show_bug.cgi?id=83966

Rubber stamped by Oliver Hunt.

These aren't being used anywhere!

  • jit/JIT.h:
  • jit/JITCall.cpp:

(JSC::JIT::compileOpCall):

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileOpCall):

17:42 Changeset [114191] by danakj@chromium.org
  • 4 edits in trunk/Source/WebCore

[chromium] Remove viewport memory restrictions
https://bugs.webkit.org/show_bug.cgi?id=83316

Reviewed by Adrienne Walker.

We remove the memory restriction on web pages based on viewport size
on desktop. This is causing pages that have complex use of layers to
end up hitting our memory limits, and moreso when the window is small.
Page complexity is not really a function of the viewport size.

We drop the mininum memory limit entirely, and just evict all
unprotected textures instead.

Covered by existing tests.

  • platform/graphics/chromium/TextureManager.cpp:

(WebCore::TextureManager::highLimitBytes):
(WebCore::TextureManager::reclaimLimitBytes):

  • platform/graphics/chromium/TextureManager.h:

(TextureManager):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::beginCommitOnImplThread):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):
(WebCore::CCLayerTreeHost::updateLayers):

17:38 Changeset [114190] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Optimize tracking of intruding floats being removed from RenderBlock during layout
https://bugs.webkit.org/show_bug.cgi?id=82928

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-04-13
Reviewed by David Hyatt.

Performance tweaks in RenderBlock layout as a follow up to r112935.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::clearFloats):

17:36 Changeset [114189] by mihnea@adobe.com
  • 14 edits
    2 adds in trunk

[CSSRegions]Implement NamedFlow::contentNodes attribute
https://bugs.webkit.org/show_bug.cgi?id=80134

Reviewed by David Hyatt.

Source/WebCore:

The named flow content nodes collection contains those nodes with webkitFlowInto property set to 'flow'.
In the list, the nodes are placed in document order. Nodes with display:none are also part of the list.
The list of nodes is returned as a static node list.

The content nodes are stored in RenderNamedFlowThread. The content nodes are added to the list in NodeRenderingContext::moveToFlowThreadIfNeeded
and removed from the list in Element::detach. When an element -webkit-flow-into property is changed, the element is detached and attached.
I have also added a bit in NodeFlags to mark that an element is part of a named flow (and the corresponding inNamedFlow/setInNamedFlow/clearInNamedFlow functions).

Test: fast/regions/webkit-named-flow-content-nodes.html

  • dom/Document.cpp:

(WebCore::Document::webkitGetFlowByName):

  • dom/Document.h:
  • dom/Element.cpp:

(WebCore::Element::detach):

  • dom/Node.h:

(WebCore::Node::inNamedFlow):
(WebCore::Node::setInNamedFlow):
(WebCore::Node::clearInNamedFlow):
(Node):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):

  • dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::contentNodes):
(WebCore):

  • dom/WebKitNamedFlow.h:

(WebKitNamedFlow):

  • dom/WebKitNamedFlow.idl:
  • rendering/FlowThreadController.cpp:

(WebCore::FlowThreadController::registerNamedFlowContentNode):
(WebCore):
(WebCore::FlowThreadController::unregisterNamedFlowContentNode):

  • rendering/FlowThreadController.h:

(FlowThreadController):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore):
(WebCore::RenderNamedFlowThread::registerNamedFlowContentNode):
(WebCore::RenderNamedFlowThread::unregisterNamedFlowContentNode):

  • rendering/RenderNamedFlowThread.h:

(WebCore):
(RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::contentNodes):
(WebCore::RenderNamedFlowThread::hasContentNode):

LayoutTests:

  • fast/regions/webkit-named-flow-content-nodes-expected.txt: Added.
  • fast/regions/webkit-named-flow-content-nodes.html: Added.
17:34 Changeset [114188] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove the calls to CRASH() from ResourceLoader.cpp.
https://bugs.webkit.org/show_bug.cgi?id=83962

Reviewed by Alexey Proskuryakov.

They were added in r91316 to aid debugging for the issue fixed in r105556 and r106130.

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::willSendRequest):
(WebCore::ResourceLoader::didSendData):
(WebCore::ResourceLoader::didReceiveResponse):
(WebCore::ResourceLoader::didReceiveData):
(WebCore::ResourceLoader::didFinishLoading):
(WebCore::ResourceLoader::didFail):
(WebCore::ResourceLoader::wasBlocked):
(WebCore::ResourceLoader::cannotShowURL):
(WebCore::ResourceLoader::shouldUseCredentialStorage):
(WebCore::ResourceLoader::willCacheResponse):

17:33 Changeset [114187] by xji@chromium.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r102190) [chromium] text rendering (font and font size) in some Arabic/Persian page is wrong
when using certain fonts
https://bugs.webkit.org/show_bug.cgi?id=83523

Reviewed by Kent Tamura.

Revert r102190.
Convert characters being treatAsSpace to white space.

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::fillRuns):
(WebCore::UniscribeHelper::adjustSpaceAdvances):

17:27 Changeset [114186] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Remove fallback code for "Missing plug-in" string.
https://bugs.webkit.org/show_bug.cgi?id=81907

Patch by Bernhard Bauer <bauerb@google.com> on 2012-04-13
Reviewed by Adam Barth.

  • src/LocalizedStrings.cpp:

(WebCore::missingPluginText):

17:26 Changeset [114185] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Array.prototype.toString and Array.prototype.toLocaleString should be generic
https://bugs.webkit.org/show_bug.cgi?id=81588

Patch by Hojong Han <hojong.han@samsung.com> on 2012-04-13
Reviewed by Gavin Barraclough.

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):

  • runtime/CommonIdentifiers.h:
  • tests/mozilla/ecma/Array/15.4.4.2.js:

(getTestCases.array.item.new.TestCase):
(getTestCases):

17:11 Changeset [114184] by timothy@apple.com
  • 2 edits in trunk/Source/WebCore

Change how the Web Insector is installed on Mac builds.

<rdar://problem/10857918>

Reviewed by Mark Rowe.

  • WebCore.xcodeproj/project.pbxproj: Updated Copy Inspector Resources

and Streamline Inspector Source build phases.

16:44 Changeset [114183] by barraclough@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Don't rely on fixed offsets to patch method checks
https://bugs.webkit.org/show_bug.cgi?id=83958

Reviewed by Oliver Hunt.

  • bytecode/StructureStubInfo.h:
    • Add fields for the method check info.
  • jit/JIT.cpp:

(JSC::PropertyStubCompilationInfo::copyToStubInfo):

  • Store the offsets on the stub info, instead of asserting.
  • jit/JIT.h:
    • Delete all the method check related offsets.
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::patchMethodCallProto):

  • Use the offset from the stubInfo.
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • Pass the stubInfo to patchMethodCallProto.
16:44 Changeset [114182] by simon.fraser@apple.com
  • 7 edits in trunk/LayoutTests

Rebaseline some compositing tests. Some were affected by the colorspace of
the sample image changing.

  • compositing/images/direct-pdf-image-expected.png:
  • compositing/repaint/newly-composited-repaint-rect-expected.png:
  • compositing/visibility/visibility-image-layers-expected.png:
  • compositing/visibility/visibility-simple-video-layer-expected.png:
  • platform/mac/compositing/reflections/reflection-in-composited-expected.png:
  • platform/mac/compositing/reflections/simple-composited-reflections-expected.png:
16:43 Changeset [114181] by abarth@webkit.org
  • 1 edit
    11 deletes in trunk/LayoutTests

fast/dom/Window/window-property-descriptors.html is too much work to maintain
https://bugs.webkit.org/show_bug.cgi?id=83915

Reviewed by Alexey Proskuryakov.

The goal of this test is to remind us whenever we add something to the
global scope. In practice, however, this test is a lot of work to
maintain because every port has different features enabled, which means
every port has a different list of things in the global scope. It's
very difficult to make changes without causing this test to go red on a
number of bots.

Rather than use this test to monitor the global scope, we're better off
paying attention to the IDL files. If folks are interested in changes
to what is exposed to JavaScript, they can subscribe to IDL changes
using a watchlist. (That's what I do, and it works pretty well.)

  • fast/dom/Window/script-tests/window-property-descriptors.js: Removed.
  • fast/dom/Window/window-property-descriptors.html: Removed.
  • platform/chromium/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
  • platform/efl/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
  • platform/mac/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
  • platform/qt-arm/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.png: Removed.
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
16:31 Changeset [114180] by jer.noble@apple.com
  • 5 edits in trunk/Source

Video at apple.com gets standard controls in addition to custom controls after returning from full screen
https://bugs.webkit.org/show_bug.cgi?id=83939

Reviewed by Eric Carlson.

Source/WebCore:

No new tests; DRT and WKTR don't have the infrastructure to test full-screen animation related bugs.

Instead of asking the media element whether it is in full screen or not, rely on when the media root element
was told that it enteredFullscreen() or exitedFullscreen(), which may occur at a different time than the
media element due to animations.

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::reset):
(WebCore::MediaControlRootElement::playbackStarted):
(WebCore::MediaControlRootElement::enteredFullscreen):
(WebCore::MediaControlRootElement::exitedFullscreen):
(WebCore::MediaControlRootElement::defaultEventHandler):
(WebCore::MediaControlRootElement::startHideFullscreenControlsTimer):
(WebCore::MediaControlRootElement::hideFullscreenControlsTimerFired):

  • html/shadow/MediaControlRootElement.h:

(MediaControlRootElement): Added m_isFullscreen;

Source/WebKit2:

So that the media controls don't show up momentarily during full screen animations, call setAnimatingFullScreen(true)
before calling will{Enter,Exit}FullScreen(), so that the CSS rule for full screen animation will be in effect
immediately.

Similarly, call setAnimatingFullScreen(false) after calling did{Enter,Exit}FullScreen, so that the full screen media
controls don't momentarily appear at the end of an animation.

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController enterFullScreen:]):
(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]):
(-[WKFullScreenWindowController exitFullScreen]):
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):

16:27 Changeset [114179] by jer.noble@apple.com
  • 5 edits
    1 delete in trunk

fullscreen/video-controls-drag.html failing on Mac
https://bugs.webkit.org/show_bug.cgi?id=81176

Reviewed by Eric Carlson.

Source/WebCore:

No new tests. Fixes fullscreen/video-controls-drag.html.

Regressed in r110409. When the -webkit-media-controls-panel were changed
from position:absolute to position:relative, this broke dragging of the
controls in fullscreen, which relies on the panel being absolutely positioned
to do its drag positioning. Change the way drag positioning is calculated to
accommodate position:relative.

  • css/fullscreenQuickTime.css:

(video:-webkit-full-screen::-webkit-media-controls-panel): Instead of bottom:50px,

use margin-bottom:50px to push panel up from the bottom of the screen.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::startDrag): Do not ask for the current renderer location.
(WebCore::MediaControlPanelElement::continueDrag): Use the delta between the event locations

only to calculate the new panel position.

  • html/shadow/MediaControlElements.h:

LayoutTests:

Removed expected failing results from platform/mac.

  • platform/mac/fullscreen/video-controls-drag-expected.txt: Removed.
16:25 Changeset [114178] by simon.fraser@apple.com
  • 5 edits in trunk/LayoutTests

Fix two compositing animation tests to not have flakey pixel results
https://bugs.webkit.org/show_bug.cgi?id=83957

Reviewed by Dean Jackson.

Fix these tests to use the pause animation API by providing an animation
name in the expected data. There's no need to start the animations by hand.

  • compositing/reflections/animation-inside-reflection.html:
  • compositing/reflections/nested-reflection-animated.html:
  • platform/mac/compositing/reflections/animation-inside-reflection-expected.png:
  • platform/mac/compositing/reflections/nested-reflection-animated-expected.png:
16:16 Changeset [114177] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

Rebaseline this since svg/custom/resources/green-checker.png changed.

  • svg/custom/image-with-prefix-in-webarchive-expected.webarchive:
15:51 Changeset [114176] by simon.fraser@apple.com
  • 13 edits in trunk/LayoutTests

Avoid use of ::webkit-scrollbar to hide scrollbars, since it doesn't work in WK1
https://bugs.webkit.org/show_bug.cgi?id=83950

Reviewed by James Robinson.

Remove use of ::webkit-scrollbar from compositing tests, since this doesn't
affect WebKit1 scrollbars.

  • compositing/geometry/fixed-position-composited-page-scale-down.html:
  • compositing/geometry/fixed-position-composited-page-scale.html:
  • compositing/geometry/fixed-position-iframe-composited-page-scale-down.html:
  • compositing/geometry/fixed-position-iframe-composited-page-scale.html:
  • compositing/geometry/fixed-position-transform-composited-page-scale-down.html:
  • compositing/geometry/fixed-position-transform-composited-page-scale.html:
  • platform/mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
  • platform/mac/compositing/geometry/fixed-position-composited-page-scale-expected.png:
  • platform/mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
  • platform/mac/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
  • platform/mac/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
  • platform/mac/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
15:26 Changeset [114175] by simon.fraser@apple.com
  • 5 edits
    1 delete in trunk

Compositing layers not updated after scroll in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=83945

Source/WebCore:

Reviewed by James Robinson.

Fix the WebKit1 code path to correctly update compositing layers
after a scroll, by calling updateFixedElementsAfterScrolling() from
scrollPositionChangedViaPlatformWidget().

Covered by existing tests.

  • page/FrameView.cpp:

(WebCore::FrameView::scrollPositionChangedViaPlatformWidget):

LayoutTests:

Reviewed by James Robinson.

Replace an incorrect Mac baseline with the correct result which was
already in place for WebKit2.

Remove a passing test from test-expectations.

  • compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
  • platform/mac-wk2/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt: Removed.
  • platform/mac/test_expectations.txt:
15:09 Changeset [114174] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

Chromium test_expectations suppress platform/chromium/virtual/gpu/fast/canvas/2d.imageDataHD.html

Unreviewed.

  • platform/chromium/test_expectations.txt:
15:05 Changeset [114173] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

Fix skipped list.

  • Skipped:
15:02 Changeset [114172] by dino@apple.com
  • 6 edits
    4 adds in trunk

Don't process filters if the input region is exceptionally large.
https://bugs.webkit.org/show_bug.cgi?id=83317

Reviewed by Simon Fraser.

Source/WebCore:

An extremely large element causes problems with filters, either by
taking too long to compute the output or using too much memory. The
filter engine already has some constants for maximum expected size.
Make sure the render tree checks them before deciding to apply
effects.

Tests: css3/filters/huge-region-composited.html

css3/filters/huge-region.html

  • platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::apply):

  • rendering/FilterEffectRenderer.cpp:

(WebCore):
(WebCore::isFilterSizeValid):
(WebCore::FilterEffectRenderer::build):
(WebCore::FilterEffectRenderer::updateBackingStore):
(WebCore::FilterEffectRendererHelper::beginFilterEffect):

  • rendering/FilterEffectRenderer.h:

(FilterEffectRenderer):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateOrRemoveFilterEffect):

LayoutTests:

  • css3/filters/huge-region-composited-expected.txt: Added.
  • css3/filters/huge-region-composited.html: Added.
  • css3/filters/huge-region-expected.txt: Added.
  • css3/filters/huge-region.html: Added.
14:45 Changeset [114171] by annacc@chromium.org
  • 11 edits in trunk

Queue the cuechange event on HTMLTrackElement for proper sorting.
https://bugs.webkit.org/show_bug.cgi?id=83858

Reviewed by Eric Carlson.

Source/WebCore:

No new tests. Updates to media/track/track-cues-cuechange.html and
media/track/track-mode.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updateActiveTextTrackCues):

Add HTMLTrackElement's cuechange event to the event queue rather than
firing it synchronously.

  • html/track/LoadableTextTrack.cpp:

Remove fireCueChangeEvent() as it is no longer used.

  • html/track/LoadableTextTrack.h:

Ditto.

  • html/track/TextTrack.h:

(TextTrack):

Ditto.

LayoutTests:

  • media/track/captions-webvtt/captions-fast.vtt:

Captions were a wee bit too fast: they need to be at least 250ms apart
for accurate testing as timeupdate events are only fired every 250ms.

  • media/track/track-cues-cuechange-expected.txt:

Changes the order that cuechange events are fired.

  • media/track/track-cues-cuechange.html:

Ditto.

  • media/track/track-mode-expected.txt:

cuechange events are now fired at the proper times.
Test now checks for all cuechange events (both enter and exit of cues).

  • media/track/track-mode.html:

Ditto.

14:32 Changeset [114170] by tonikitoo@webkit.org
  • 9 edits
    48 adds in trunk

Be more restrictive when adding ScrollableArea's to FrameView's ScrollableArea's map
https://bugs.webkit.org/show_bug.cgi?id=79611

Reviewed by James Robinson.
Patch by Antonio Gomes <agomes@rim.com>

Source/WebCore:

As of today, any FrameView attached to the Widget-tree or any
RenderLayer whose corresponding RenderBox's style has a 'overflow'
property set to 'auto' is cached in its containing scrollable areas set.
We could be more restrictive about what we in fact want to
cache as scrollable areas, by checking if the element as an overflow
(i.e. more content than its viewport).

  • page/FrameView.cpp:

(WebCore::FrameView::setFrameRect):

Whenever the viewport changes, check if we have an scrollable/overflowed
content, and update the cache accordingly.

(WebCore::FrameView::setContentsSize):

Whenever the contents size changes, check if we have a scrollable/overflowed
content, and update the cache accordingly.

(WebCore::FrameView::calculateScrollbarModesForLayout):

Introduces a way to query for the scrollbars by only
taking into account the "rules" set by the web author.
For that, a new enum was added called SrollbarModesCalculationStrategy,
which allows callers to discard for example client-side scrollbar policies
in order to verify if a given frameview is scrollable or not.

(WebCore::FrameView::updateScrollableAreaSet):

Take into account various factors before considering a FrameView as
scrollable. If in the end it is, it gets added to its parent FrameView
scrollable areas map, otherwise removed.

(WebCore):
(WebCore::FrameView::addScrollableArea):

Became unneeded, thus removed.

(WebCore::FrameView::removeScrollableArea):

Whenever a FrameView is removed from the Widget-tree,
remove it from the cache.

  • page/FrameView.h:

(FrameView):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateScrollbarsAfterLayout):

Update scrollable area set after layout.

(WebCore::RenderLayer::updateScrollbarsAfterStyleChange):

Update scrollable area set after style changes.

(WebCore::RenderLayer::styleChanged):

Removed the scrollable areas logic detection from it.

(WebCore::RenderLayer::updateScrollableAreaSet):

Updates the containing FrameView scrollable areas cache
only when needed (i.e. an overflow exists).

(WebCore):

  • rendering/RenderLayer.h:

(RenderLayer):

  • testing/Internals.cpp:

(WebCore::Internals::numberOfScrollableAreas):
(WebCore):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Tests: fast/scrolling/scrollable-area-frame-inherited-visibility-hidden.html

fast/scrolling/scrollable-area-frame-overflow-hidden.html
fast/scrolling/scrollable-area-frame-overried-inherited-visibility-hidden.html
fast/scrolling/scrollable-area-frame-scrolling-no-overried-inherited-visibility-hidden.html
fast/scrolling/scrollable-area-frame-scrolling-no-visibility-hidden-child.html
fast/scrolling/scrollable-area-frame-scrolling-no.html
fast/scrolling/scrollable-area-frame-scrolling-yes-display-none.html
fast/scrolling/scrollable-area-frame-scrolling-yes.html
fast/scrolling/scrollable-area-frame-visibility-hidden-child.html
fast/scrolling/scrollable-area-frame-zero-size-and-border.html
fast/scrolling/scrollable-area-frame.html
fast/scrolling/scrollable-area-overflow-auto-display-none-in-parent.html
fast/scrolling/scrollable-area-overflow-auto-display-none.html
fast/scrolling/scrollable-area-overflow-auto-visibility-hidden-in-parent.html
fast/scrolling/scrollable-area-overflow-auto-visibility-hidden.html
fast/scrolling/scrollable-area-overflow-auto-visibility-override.html
fast/scrolling/scrollable-area-overflow-auto-visibility-visible.html
fast/scrolling/scrollable-area-overflow-auto.html
fast/scrolling/scrollable-area-overflow-not-set.html
fast/scrolling/scrollable-area-overflow-visible.html

LayoutTests:

Reviewed by NOBODY (OOPS!).

Added scrollable area set count tests to many situations observed
in real world sites.

  • fast/scrolling/resources/generic-scrollable-content.html: Added.
  • fast/scrolling/resources/hidden-generic-scrollable-content.html: Added.
  • fast/scrolling/resources/scrollable-area.js: Added.

(runTest):
(end):

  • fast/scrolling/resources/scrollable-style.css: Added.

(.inner):
(.offscreen):

  • fast/scrolling/scrollable-area-frame-expected.txt: Added.
  • fast/scrolling/scrollable-area-frame-inherited-visibility-hidden-expected.txt: Added.
  • fast/scrolling/scrollable-area-frame-inherited-visibility-hidden.html: Added.
  • fast/scrolling/scrollable-area-frame-overflow-hidden-expected.txt: Added.
  • fast/scrolling/scrollable-area-frame-overflow-hidden.html: Added.
  • fast/scrolling/scrollable-area-frame-overried-inherited-visibility-hidden-expected.txt: Added.
  • fast/scrolling/scrollable-area-frame-overried-inherited-visibility-hidden.html: Added.
  • fast/scrolling/scrollable-area-frame-scrolling-no-expected.txt: Added.
  • fast/scrolling/scrollable-area-frame-scrolling-no-overried-inherited-visibility-hidden-expected.txt: Added.
  • fast/scrolling/scrollable-area-frame-scrolling-no-overried-inherited-visibility-hidden.html: Added.
  • fast/scrolling/scrollable-area-frame-scrolling-no-visibility-hidden-child-expected.txt: Added.
  • fast/scrolling/scrollable-area-frame-scrolling-no-visibility-hidden-child.html: Added.
  • fast/scrolling/scrollable-area-frame-scrolling-no.html: Added.
  • fast/scrolling/scrollable-area-frame-scrolling-yes-display-none-expected.txt: Added.
  • fast/scrolling/scrollable-area-frame-scrolling-yes-display-none.html: Added.
  • fast/scrolling/scrollable-area-frame-scrolling-yes-expected.txt: Added.
  • fast/scrolling/scrollable-area-frame-scrolling-yes.html: Added.
  • fast/scrolling/scrollable-area-frame-visibility-hidden-child-expected.txt: Added.
  • fast/scrolling/scrollable-area-frame-visibility-hidden-child.html: Added.
  • fast/scrolling/scrollable-area-frame-zero-size-and-border-expected.txt: Added.
  • fast/scrolling/scrollable-area-frame-zero-size-and-border.html: Added.
  • fast/scrolling/scrollable-area-frame.html: Added.
  • fast/scrolling/scrollable-area-overflow-auto-display-none-expected.txt: Added.
  • fast/scrolling/scrollable-area-overflow-auto-display-none-in-parent-expected.txt: Added.
  • fast/scrolling/scrollable-area-overflow-auto-display-none-in-parent.html: Added.
  • fast/scrolling/scrollable-area-overflow-auto-display-none.html: Added.
  • fast/scrolling/scrollable-area-overflow-auto-expected.txt: Added.
  • fast/scrolling/scrollable-area-overflow-auto-visibility-hidden-expected.txt: Added.
  • fast/scrolling/scrollable-area-overflow-auto-visibility-hidden-in-parent-expected.txt: Added.
  • fast/scrolling/scrollable-area-overflow-auto-visibility-hidden-in-parent.html: Added.
  • fast/scrolling/scrollable-area-overflow-auto-visibility-hidden.html: Added.
  • fast/scrolling/scrollable-area-overflow-auto-visibility-override-expected.txt: Added.
  • fast/scrolling/scrollable-area-overflow-auto-visibility-override.html: Added.
  • fast/scrolling/scrollable-area-overflow-auto-visibility-visible-expected.txt: Added.
  • fast/scrolling/scrollable-area-overflow-auto-visibility-visible.html: Added.
  • fast/scrolling/scrollable-area-overflow-auto.html: Added.
  • fast/scrolling/scrollable-area-overflow-not-set-expected.txt: Added.
  • fast/scrolling/scrollable-area-overflow-not-set.html: Added.
  • fast/scrolling/scrollable-area-overflow-visible-expected.txt: Added.
  • fast/scrolling/scrollable-area-overflow-visible.html: Added.
14:32 April 2012 Meeting edited by jacobg@adobe.com
(diff)
14:29 Changeset [114169] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Make sure that we're using the right compiler for generating derived sources.

Rubber-stamped by Dan Bernstein.

  • WebKit2.xcodeproj/project.pbxproj:
14:23 Changeset [114168] by antti@apple.com
  • 6 edits in trunk/Source/WebCore

Track rem unit usage in StyleSheetInternal
https://bugs.webkit.org/show_bug.cgi?id=83923

Reviewed by Andreas Kling.

Currently CSSParser sets usesRemUnits flag directly to Document. It should be set to
the stylesheet instead so parser does not need to know about the document. This also
avoids setting the flag unnecessarily when the stylesheet is not used.

  • css/CSSGrammar.y:
  • css/CSSStyleSheet.cpp:

(WebCore::StyleSheetInternal::StyleSheetInternal):

  • css/CSSStyleSheet.h:

(WebCore::StyleSheetInternal::parserSetUsesRemUnits):
(WebCore::StyleSheetInternal::usesRemUnits):
(StyleSheetInternal):

  • dom/Document.cpp:

(WebCore):
(WebCore::checkUsesRemUnits):
(WebCore::Document::updateActiveStylesheets):

  • dom/Document.h:

(WebCore::Document::usesRemUnits):

14:19 Changeset [114167] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

Chromium test_expectations TIMOUT mask for fast/canvas/2d.imageDataHD.html

Unreviewed.

  • platform/chromium/test_expectations.txt:
14:01 Changeset [114166] by jamesr@google.com
  • 18 edits in trunk

[chromium] Remove unused compositeToTexture / compositeOffscreen setting
https://bugs.webkit.org/show_bug.cgi?id=83733

Reviewed by Adrienne Walker.

Source/Platform:

Remove compositeOffscreen setting. This was an experiment that is no longer needed.

  • chromium/public/WebLayerTreeView.h:

(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):

Source/WebCore:

Remove compositeOffscreen setting and implementation. This was an experiment that is no longer needed.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::finishDrawingFrame):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::setScissorToRect):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):
(CCSettings):

Source/WebKit/chromium:

Remove compositeOffscreen / compositeToTexture setting. This was an experiment that is no longer needed.

  • public/WebSettings.h:
  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCSettings):

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::WebSettingsImpl):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

Tools:

Remove compositeOffscreen / compositeToTexture setting. This was an experiment that is no longer needed.

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::resetWebSettings):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell):

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset):
(WebPreferences::applyTo):

  • DumpRenderTree/chromium/WebPreferences.h:

(WebPreferences):

13:57 Changeset [114165] by ap@apple.com
  • 5 edits in trunk

REGRESSION (XHR Caching): Uncacheable responses sent by Rails through Apache are cached
https://bugs.webkit.org/show_bug.cgi?id=83925
<rdar://problem/11231790>

Reviewed by Antti Koivisto.

Added subtests to http/tests/cache/subresource-expiration-2.html.

  • platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::parseCacheControlDirectives): Honor first max-age instead of the last. New behavior matches both Firefox and IE.
13:43 Changeset [114164] by jamesr@google.com
  • 18 edits
    2 moves
    2 deletes in trunk/Source

[chromium] Move WebVideoFrame into Platform and remove WebCore::VideoFrameChromium wrapper API
https://bugs.webkit.org/show_bug.cgi?id=83851

Reviewed by Adam Barth.

Source/Platform:

Move WebVideoFrame API into Platform.

  • Platform.gypi:
  • chromium/public/WebVideoFrame.h: Renamed from Source/WebCore/platform/graphics/chromium/VideoFrameChromium.h.

(WebKit):
(WebVideoFrame):
(WebKit::WebVideoFrame::~WebVideoFrame):
(WebKit::WebVideoFrame::format):
(WebKit::WebVideoFrame::width):
(WebKit::WebVideoFrame::height):
(WebKit::WebVideoFrame::planes):
(WebKit::WebVideoFrame::stride):
(WebKit::WebVideoFrame::data):
(WebKit::WebVideoFrame::textureId):
(WebKit::WebVideoFrame::textureTarget):

  • chromium/src/WebVideoFrame.cpp: Renamed from Source/WebCore/platform/graphics/chromium/VideoFrameChromium.cpp.

(WebKit):

Source/WebCore:

Remove VideoFrameChromium wrapper and converts WebCore code to using the Platform WebVideoFrame API directly.
Some utility code that previously existed on VideoFrameChromium and only had one caller, such as doing
width/height adjustements for YV12 frames, is moved into the calling code (CCVideoLayerImpl).

Covered by existing media/ and compositing/ layout tests.

  • WebCore.gypi:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawYUV):
(WebCore::LayerRendererChromium::drawRGBA):
(WebCore::LayerRendererChromium::copyFrameToTextures):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/VideoFrameProvider.h:

(VideoFrameProvider):

  • platform/graphics/chromium/cc/CCVideoDrawQuad.cpp:

(WebCore::CCVideoDrawQuad::create):
(WebCore::CCVideoDrawQuad::CCVideoDrawQuad):

  • platform/graphics/chromium/cc/CCVideoDrawQuad.h:

(WebKit):
(CCVideoDrawQuad):
(WebCore::CCVideoDrawQuad::frame):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore):
(WebCore::convertVFCFormatToGC3DFormat):
(WebCore::CCVideoLayerImpl::willDraw):
(WebCore::videoFrameDimension):
(WebCore::hasPaddingBytes):
(WebCore::CCVideoLayerImpl::computeVisibleSize):
(WebCore::CCVideoLayerImpl::reserveTextures):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:

(WebKit):

Source/WebKit/chromium:

Moves the WebVideoFrame interface into Platform and removes the now unnecessary VideoFrameChromiumImpl adapter
implementation.

  • WebKit.gyp:
  • public/WebVideoFrame.h:
  • src/AssertMatchingEnums.cpp:
  • src/VideoFrameChromiumImpl.cpp: Removed.
  • src/VideoFrameChromiumImpl.h: Removed.
  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::putCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::supportsType):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

12:43 Changeset [114163] by scheib@chromium.org
  • 6 edits
    1 add in trunk

Chromium: Should enable -webkit-image-set
https://bugs.webkit.org/show_bug.cgi?id=81859

Patch by Rob Flack <flackr@chromium.org> on 2012-04-13
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/css/image-set-parsing.html

  • WebCore.gypi:

Source/WebKit/chromium:

  • features.gypi:

LayoutTests:

  • platform/chromium/test_expectations.txt:
12:39 Changeset [114162] by tomz@codeaurora.org
  • 6 edits
    12 adds in trunk/LayoutTests

Integrate IETC CSS : grid layout tests
https://bugs.webkit.org/show_bug.cgi?id=83830

Patch by Dave Tharp < dtharp@codeaurora.org> on 2012-04-13
Reviewed by Adam Barth

  • ietestcenter/css3/grid/display-grid-001.htm: Added.
  • ietestcenter/css3/grid/display-grid-002.htm: Added.
  • ietestcenter/css3/grid/grid-column-001.htm: Added.
  • ietestcenter/css3/grid/grid-column-002.htm: Added.
  • ietestcenter/css3/grid/grid-column-003.htm: Added.
  • ietestcenter/css3/grid/grid-columns-001.htm: Added.
  • ietestcenter/css3/grid/grid-items-001.htm: Added.
  • ietestcenter/css3/grid/grid-items-002.htm: Added.
  • ietestcenter/css3/grid/grid-items-003.htm: Added.
  • ietestcenter/css3/grid/grid-items-004.htm: Added.
  • ietestcenter/css3/grid/grid-items-005.htm: Added.
  • platform/chromium/test_expectations.txt:
  • platform/efl/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
12:34 Changeset [114161] by lforschler@apple.com
  • 3 edits
    3 copies in tags/Safari-536.6.2

Merged r113941.

12:33 Changeset [114160] by michaeln@google.com
  • 12 edits
    5 deletes in trunk/Source

[chromium] Now that the chromium port is using a different dom_storage backend
library in its main browser process, there are a handful of files that should no
longer be included in the build, and a few files than should be deleted
outright, and the webkit api should be modified to reflect the new (and smaller)
contract between the embedder and webkit/webcore.
https://bugs.webkit.org/show_bug.cgi?id=83807

Reviewed by Adam Barth.

Source/WebCore:

No new tests, existing tests apply.

  • WebCore.gyp/WebCore.gyp: Exclude several files from the WebCore/storage directory.
  • storage/StorageEventDispatcher.h: Delete a stale comment.

Source/WebKit/chromium:

  • WebKit.gyp: Delete a few files.
  • public/WebStorageNamespace.h: Remove some unused data members and methods, and annotate close() as deprecated.
  • public/platform/WebKitPlatformSupport.h: Annotate a method as deprecated.
  • src/StorageAreaProxy.cpp: Remove the include of a deleted file.
  • src/StorageEventDispatcherChromium.cpp: Removed.
  • src/StorageEventDispatcherImpl.cpp: Added a FIXME comment for upcoming work.
  • src/StorageNamespaceProxy.cpp: Modified to no longer call out to the embedder thru the deprecated close() method.
  • src/StorageNamespaceProxy.h: Moved some blank lines around.
  • src/WebStorageAreaImpl.cpp: Removed.
  • src/WebStorageAreaImpl.h: Removed.
  • src/WebStorageEventDispatcherImpl.cpp: Cleaned up some cruft.
  • src/WebStorageNamespaceImpl.cpp: Removed.
  • src/WebStorageNamespaceImpl.h: Removed.
12:32 Changeset [114159] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed, rebaselining after r114150.

  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
12:26 Changeset [114158] by rniwa@webkit.org
  • 3 edits in trunk/Tools

webkitpy build fix. Revert the debug change (number of runs was 2 instead of 20),
and also rebaseline the test results since we ignore the first run now.

  • Scripts/webkitpy/performance_tests/perftest.py:

(PageLoadingPerfTest.run):

  • Scripts/webkitpy/performance_tests/perftest_unittest.py:

(TestPageLoadingPerfTest.test_run):

12:24 Changeset [114157] by barraclough@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Don't rely on fixed offsets to patch get_by_id/put_by_id
https://bugs.webkit.org/show_bug.cgi?id=83924

Reviewed by Oliver Hunt.

Store offsets in the structure stub info, as we do for the DFG JIT.

  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::differenceBetween):

  • this method can be static (now used from PropertyStubCompilationInfo::copyToStubInfo, will be removed soon!)
  • bytecode/StructureStubInfo.h:
    • added new fields for baseline JIT offsets.
  • jit/JIT.cpp:

(JSC::PropertyStubCompilationInfo::copyToStubInfo):

  • moved out from JIT::privateCompile.

(JSC::JIT::privateCompile):

  • moved out code to PropertyStubCompilationInfo::copyToStubInfo.
  • jit/JIT.h:

(PropertyStubCompilationInfo):

  • added helper functions to initializae PropertyStubCompilationInfo, state to store more offset info.
  • removed many offsets.
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):
(JSC::JIT::patchGetByIdSelf):
(JSC::JIT::patchPutByIdReplace):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
(JSC::JIT::resetPatchGetById):
(JSC::JIT::resetPatchPutById):

  • changed code generation to use new interface to store info on PropertyStubCompilationInfo.
  • changed repatch functions to read offsets from the structure stub info.
  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):
(JSC::JIT::patchGetByIdSelf):
(JSC::JIT::patchPutByIdReplace):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
(JSC::JIT::resetPatchGetById):
(JSC::JIT::resetPatchPutById):

  • changed code generation to use new interface to store info on PropertyStubCompilationInfo.
  • changed repatch functions to read offsets from the structure stub info.
12:21 Changeset [114156] by lforschler@apple.com
  • 4 edits in tags/Safari-536.6.2/Source

Versioning.

12:20 Changeset [114155] by lforschler@apple.com
  • 1 copy in tags/Safari-536.6.2

New Tag.

12:19 Changeset [114154] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

More rebaselining.

  • platform/mac/fast/dom/Window/window-properties-expected.txt:
12:02 Changeset [114153] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix some compiler warnings (miscellaneous)
https://bugs.webkit.org/show_bug.cgi?id=80790

Reviewed by Antonio Gomes.

Fix signed/unsigned comparison warning.

  • parser/Lexer.cpp:

(JSC::::record16):

11:49 Changeset [114152] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Include the error if we fail to initialize the web process sandbox
https://bugs.webkit.org/show_bug.cgi?id=83927

Reviewed by Alexey Proskuryakov.

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::initializeSandbox):

11:26 Changeset [114151] by scheib@chromium.org
  • 6 edits
    1 delete in trunk

Unreviewed, rolling out r114140.
http://trac.webkit.org/changeset/114140
https://bugs.webkit.org/show_bug.cgi?id=83921

Fails fast/css/image-set-parsing.html test it attempts to
introduce. (Requested by scheib on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-13

Source/WebCore:

  • WebCore.gypi:

Source/WebKit/chromium:

  • features.gypi:

LayoutTests:

  • platform/chromium/fast/css/image-set-parsing-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
11:25 PrefixedAPIs edited by mitz@apple.com
Added CanvasRenderingContext2D extensions for high-resolution backing … (diff)
11:20 Changeset [114150] by mitz@apple.com
  • 13 edits
    4 adds in trunk

<rdar://problem/10912680> Pixel access canvas APIs do not operate at backing store resolution
https://bugs.webkit.org/show_bug.cgi?id=83836

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/canvas/2d.imageDataHD.html

Added getImageDataHD and putImageDataHD functions to CanvasRenderingContext2D, as proposed in
<http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-March/035112.html>. The functions
are prefixed with “webkit” for now.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::getImageData): Added this cover function that calls
through to getImageData with LogicalCoordinateSystem.
(WebCore::CanvasRenderingContext2D::webkitGetImageDataHD): Added. Calls through to
getImageData with BackingStoreCoordinateSystem.
(WebCore::CanvasRenderingContext2D::getImageData): Added a CoordinateSystem parameter to this
now-private function. It is passed through to ImageBuffer::getUnmultipliedImageData().
(WebCore::CanvasRenderingContext2D::putImageData): Added this cover function that calls
through to putImageData with LogicalCoordinateSystem.
(WebCore::CanvasRenderingContext2D::webkitPutImageDataHD): Added. Calls through to
putImageData with BackingStoreCoordinateSystem.
(WebCore::CanvasRenderingContext2D::putImageData): Added a CoordinateSystem parameter to this
function. It is passed through to ImageBuffer::putByteArray, and used to compute the rect to
invalidate after the drawing operation.

  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/CanvasRenderingContext2D.idl: Added webkitPutImageDataHD() and

webkitGetImageDataHD().

  • platform/graphics/ImageBuffer.h: Added a CoordinateSystem enum with the values

LogicalCoordinateSystem and BackingStoreCoordinateSystem. Added a CoordinateSystem parameter,
which defaults to LogicalCoordinateSystem, to getUnmultipliedImageData,
getPremultipliedImageData, and putByteArray.

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::getUnmultipliedImageData): Now uses the CoordinateSystem parameter to
decide whether to ask ImageBufferDaya::getData() to apply the resolution scale or not.
(WebCore::ImageBuffer::getPremultipliedImageData): Ditto.
(WebCore::ImageBuffer::putByteArray): Now uses the CoordinateSystem parameter to decide
whether to maintain the resolution scale while drawing or not.
(WebCore::ImageBuffer::toDataURL):

  • platform/graphics/gtk/ImageBufferGtk.cpp:

(WebCore::ImageBuffer::toDataURL):

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):

  • platform/graphics/wince/ImageBufferWinCE.cpp:

(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):

  • platform/graphics/wx/ImageBufferWx.cpp:

(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):

LayoutTests:

  • fast/canvas/2d.imageDataHD-expected.txt: Added.
  • fast/canvas/2d.imageDataHD.html: Added.
11:16 Changeset [114149] by rniwa@webkit.org
  • 6 edits
    1 add in trunk

Enable SVG page loading performance tests
https://bugs.webkit.org/show_bug.cgi?id=83861

Reviewed by Adam Barth.

PerformanceTests:

Unskip PageLoad directory and skip tests that load too fast (less than 100ms) and are unstable,
and the ones that take too long to load (more than 20s).

  • Skipped:

Tools:

Add support for page loading tests. These are tests without any test running harnesses, and we use
DriverOutput's test_timeout to measure the loading time.

Extracted PerfTest.run and PerfTest.run_failed from PerfTestRunner._run_single_test.

  • Scripts/webkitpy/performance_tests/perftest.py:

(PerfTest.run):
(PerfTest):
(PerfTest.run_failed):
(PerfTest.parse_output):
(PerfTest.output_statistics):
(ChromiumStylePerfTest.parse_output):
(PageLoadingPerfTest): Added.
(PageLoadingPerfTest.init):
(PageLoadingPerfTest.run): Run the driver 20 times to get the statistics for the loading time.

  • Scripts/webkitpy/performance_tests/perftest_unittest.py: Added.

(MockPrinter):
(MockPrinter.init):
(MockPrinter.write):
(MainTest):
(MainTest.test_parse_output):
(MainTest.test_parse_output_with_failing_line):
(TestPageLoadingPerfTest):
(TestPageLoadingPerfTest.assertWritten):
(TestPageLoadingPerfTest.MockDriver):
(TestPageLoadingPerfTest.MockDriver.init):
(TestPageLoadingPerfTest.MockDriver.run_test):
(TestPageLoadingPerfTest.test_run):
(TestPageLoadingPerfTest.test_run_with_bad_output):

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner):
(PerfTestsRunner._collect_tests._is_test_file): Now recognizes svg tests.
(PerfTestsRunner._collect_tests):
(PerfTestsRunner._run_tests_set):
(PerfTestsRunner._run_single_test):

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(test_collect_tests_with_page_load_svg):
(test_collect_tests_with_page_load_svg.add_file):

11:15 Changeset [114148] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

Rebaseline a test.

  • platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
11:06 Changeset [114147] by shawnsingh@chromium.org
  • 12 edits
    2 adds in trunk/Source/WebCore

[chromium] Support CCHeadsUpDisplay in threaded compositing mode
https://bugs.webkit.org/show_bug.cgi?id=67499

Reviewed by James Robinson.

No new tests because this code is debugging code itself.

The last item that was needed to make the CCHeadsUpDisplay work in
threaded compositing mode was to remove the font rendering code
used on the impl-side thread. To solve this, this patch adds a
CCFontAtlas that is initialized on the main thread (where the font
rendering takes place). Then, when the HUD draws text on the impl
thread, it uses the font atlas directly.

  • WebCore.gypi:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::initialize):

  • platform/graphics/chromium/LayerRendererChromium.h:

(WebCore):
(LayerRendererChromium):

  • platform/graphics/chromium/cc/CCFontAtlas.cpp: Added.

(WebCore):
(WebCore::CCFontAtlas::CCFontAtlas):
(WebCore::wrapPositionIfNeeded):
(WebCore::CCFontAtlas::generateAtlasForFont):
(WebCore::CCFontAtlas::initialize):
(WebCore::CCFontAtlas::drawText):
(WebCore::CCFontAtlas::drawOneLineOfTextInternal):
(WebCore::CCFontAtlas::drawDebugAtlas):

  • platform/graphics/chromium/cc/CCFontAtlas.h: Added.

(WebCore):
(CCFontAtlas):
(WebCore::CCFontAtlas::create):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
(WebCore):
(WebCore::CCHeadsUpDisplay::showPlatformLayerTree):
(WebCore::CCHeadsUpDisplay::drawHudContents):
(WebCore::CCHeadsUpDisplay::drawFPSCounter):
(WebCore::CCHeadsUpDisplay::drawFPSCounterText):
(WebCore::CCHeadsUpDisplay::drawPlatformLayerTree):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h:

(WebCore::CCHeadsUpDisplay::create):
(CCHeadsUpDisplay):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initialize):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore):
(WebCore::CCLayerTreeHost::headsUpDisplayFontAtlas):
(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore):
(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::recreateContext):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::initializeLayerRendererOnImplThread):
(WebCore::CCThreadProxy::recreateContextOnImplThread):

11:06 Changeset [114146] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed - remove duplicate entries for two failing sputnik tests
from the test_expectations.txt file.

  • platform/gtk/test_expectations.txt:
11:03 Changeset [114145] by jchaffraix@webkit.org
  • 11 edits
    8 copies in branches/chromium/1084

Merge 112582 - REGRESSION (r110065-r110080): Content drawing outside overflow: hidden at ynet.co.il
https://bugs.webkit.org/show_bug.cgi?id=82129

Reviewed by Ojan Vafai.

Source/WebCore:

Tests: fast/overflow/before-after-overflow-hidden-horizontal-writing-mode-tb-expected.html

fast/overflow/before-after-overflow-hidden-horizontal-writing-mode-tb.html
fast/overflow/before-after-overflow-hidden-vertical-writing-mode-rl-expected.html
fast/overflow/before-after-overflow-hidden-vertical-writing-mode-rl.html
fast/overflow/start-end-overflow-hidden-horizontal-writing-mode-tb-expected.html
fast/overflow/start-end-overflow-hidden-horizontal-writing-mode-tb.html
fast/overflow/start-end-overflow-hidden-vertical-writing-mode-rl-expected.html
fast/overflow/start-end-overflow-hidden-vertical-writing-mode-rl.html

This is a regression from r110072. I wrongly thought we should call ensureLayer if we create our RenderOverflow.
However the current overflow code removes the before and start overflows (like in horizontal writing mode with ltr direction,
we never have a top or a left overflow). Because of that we would not get a RenderLayer as expected and the overflow clip rects
would be wrong on our RenderLayer children.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::addLayoutOverflow):
Moved the ensureLayer() call after the check that we do have some overflow but before we remove the overflow in some directions.

LayoutTests:

  • fast/overflow/before-after-overflow-hidden-horizontal-writing-mode-tb-expected.html: Added.
  • fast/overflow/before-after-overflow-hidden-horizontal-writing-mode-tb.html: Added.
  • fast/overflow/before-after-overflow-hidden-vertical-writing-mode-rl-expected.html: Added.
  • fast/overflow/before-after-overflow-hidden-vertical-writing-mode-rl.html: Added.
  • fast/overflow/start-end-overflow-hidden-horizontal-writing-mode-tb-expected.html: Added.
  • fast/overflow/start-end-overflow-hidden-horizontal-writing-mode-tb.html: Added.
  • fast/overflow/start-end-overflow-hidden-vertical-writing-mode-rl-expected.html: Added.
  • fast/overflow/start-end-overflow-hidden-vertical-writing-mode-rl.html: Added.

Added 4 ref tests that should cover the 4 different values of (hasTopOverflow, hasLeftOverflow)
in RenderBox::addLayoutOverflow.

  • platform/chromium-linux/fast/box-shadow/shadow-buffer-partial-expected.txt:
  • platform/chromium-win/fast/block/lineboxcontain/block-font-expected.txt:
  • platform/chromium-win/fast/block/lineboxcontain/block-glyphs-expected.txt:
  • platform/chromium-win/fast/block/lineboxcontain/font-expected.txt:

Rebaselined those tests on Chromium linux (new layers).

  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wk2/Skipped:

Skipped the previous tests on the other platforms.

TBR=jchaffraix@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10090001

10:47 Changeset [114144] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] LayoutTest failures/flaky for svg/as-background-image
https://bugs.webkit.org/show_bug.cgi?id=83303

Unreviewed Chromium test_expectations clean up.

Previous clean up in r114137 dropped a WIN IMAGE failure suppression.

  • platform/chromium/test_expectations.txt:
10:46 Changeset [114143] by beidson@apple.com
  • 18 edits
    2 adds in trunk

<rdar://problem/11176921> and https://bugs.webkit.org/show_bug.cgi?id=83600 Need WebKit2 API to notify whether history loads are in the page cache

Source/WebKit2:

  • Add a new WKBundlePageLoaderClient callback allowing the bundle to be notified of back/forward navigations (and deny them if it chooses)
  • Add a new API to WKBundleBackForwardListItem to probe if the item is in the page cache.

Reviewed by Darin Adler.

Add the new WKBundleBackForwardListItem API:

  • WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.cpp:

(WKBundleBackForwardListItemIsInPageCache):

  • WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.h:
  • WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.h:

(WebKit::InjectedBundleBackForwardListItem::isInPageCache):

Update the UI page loader client to allow for a user data object to be passed from the bundle:

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::shouldGoToBackForwardListItem): Update a comment typo.
(WebKit::WebLoaderClient::willGoToBackForwardListItem): Update for the user data field.

  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::willGoToBackForwardListItem):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:

Add the new callback to the bundle loader client:

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::shouldGoToBackForwardListItem):

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:

(InjectedBundlePageLoaderClient):

Call the bundle client before doing anything else, possibly canceling the navigation:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::shouldGoToHistoryItem):

  • WebProcess/qt/QtBuiltinBundlePage.cpp:

(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage) Adopt new bundle client interface.

Tools:

Add a test ShouldGoToBackForwardListItem that exercises the new BundlePageLoaderClient
callback as well as the new WKBundleBackForwardListItemIsInPageCache() API.

Reviewed by Darin Adler.

  • TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp: Added.

(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::willGoToBackForwardListItem):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp: Added.

(ShouldGoToBackForwardListItemTest):
(TestWebKitAPI::shouldGoToBackForwardListItemCallback):
(TestWebKitAPI::ShouldGoToBackForwardListItemTest::ShouldGoToBackForwardListItemTest):
(TestWebKitAPI::ShouldGoToBackForwardListItemTest::didCreatePage):

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage): Update for the new client.

10:43 Changeset [114142] by harrison@apple.com
  • 2 edits in branches/safari-534.57-branch/Source/WebCore

<rdar://problem/10552398> Meringue: 11A390: CrashTracer: 56,187 crashes in WebProcess at com.apple.WebCore: WebCore::DocumentWriter::deprecatedFrameEncoding const + 12 (71828)

Reviewed by Darin Adler.

No new tests because this change is going only on the Safari Nectarine branch, not TOT.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::addExtraFieldsToRequest):
Nil check the activeDocumentLoader().

10:40 Changeset [114141] by abarth@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

Update baselines to make this test run again.

  • platform/chromium/fast/dom/Window/window-property-descriptors-expected.txt: Replaced.
  • platform/chromium/test_expectations.txt:
10:20 Changeset [114140] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk

Chromium: Should enable -webkit-image-set
https://bugs.webkit.org/show_bug.cgi?id=81859

Patch by Rob Flack <flackr@chromium.org> on 2012-04-13
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/css/image-set-parsing.html

  • WebCore.gypi:

Source/WebKit/chromium:

  • features.gypi:

LayoutTests:

  • platform/chromium/test_expectations.txt:
09:16 Changeset [114139] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Mark test as even flakier: it can timeout.

Unreviewed.

  • platform/chromium/test_expectations.txt:
09:05 Changeset [114138] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update.

  • platform/gtk/test_expectations.txt: Flag fast/regions

again. Only parts of it were passing, sigh.

08:49 Changeset [114137] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] LayoutTest failures/flaky for svg/as-background-image
https://bugs.webkit.org/show_bug.cgi?id=83303

Unreviewed Chromium test_expectations clean up.

Consolidating common-cause flaky tests.

  • platform/chromium/test_expectations.txt:
08:42 Changeset [114136] by eae@chromium.org
  • 1794 edits
    1801 copies
    80 deletes in branches/subpixellayout

Merge trunk changes up until 114126 into subpixel branch.

08:41 Changeset [114135] by pfeldman@chromium.org
  • 5 edits in trunk

Web Inspector: do not attempt to load content from resource until request finished loading.
https://bugs.webkit.org/show_bug.cgi?id=83896

Reviewed by Yury Semikhatsky.

Source/WebCore:

When we stop in the inline script on reload, we should only show concatenated script content.
When we resume, we should replace UI source code with the actual HTML content. We should not attempt to
fetch resource content until request finished loading. I regressed it in the Request extraction
and now am bringing it back.

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype._finishedLoading):

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype.addScript):

LayoutTests:

  • inspector/debugger/raw-source-code.html:
08:40 Changeset [114134] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update.

  • platform/gtk/test_expectations.txt: Unskip fast/regions and

svg/hixie/perf that seem to pass fine on GTK bots.

07:33 Changeset [114133] by pfeldman@chromium.org
  • 4 edits in trunk

Web Inspector: follow up to r114116 - fixing QT test
https://bugs.webkit.org/show_bug.cgi?id=83892

Reviewed by Yury Semikhatsky.

Source/WebCore:

Requesting content for the scripts exclusively via the page agent now.

  • inspector/front-end/Resource.js:

(WebInspector.Resource.prototype.get content):
(WebInspector.Resource.prototype.get contentEncoded):
(WebInspector.Resource.prototype.requestContent):
(WebInspector.ResourceRevision.prototype.requestContent):

LayoutTests:

  • inspector/debugger/raw-source-code.html:
07:30 Changeset [114132] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Group EFL bots into a category on the buildbot master
https://bugs.webkit.org/show_bug.cgi?id=82712

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-13
Reviewed by Adam Roben.

Creating a new category definition on the buildbot frontend.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(loadBuilderConfig): Determine category for EFL bots

  • BuildSlaveSupport/build.webkit.org-config/templates/root.html: Add links to EFL category
07:28 Changeset [114131] by yi.4.shen@nokia.com
  • 5 edits in trunk

InsertHTML fails to insert h6 if the insertion point is before some text.
https://bugs.webkit.org/show_bug.cgi?id=82689

Reviewed by Ryosuke Niwa.

Added the missing h6 tag for the isHeaderElement.

Source/WebCore:

No new tests: updated existing test (editing/execCommand/4128080-1.html)

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::isHeaderElement):

LayoutTests:

  • editing/execCommand/4128080-1-expected.txt:
  • editing/execCommand/4128080-1.html:
07:25 Changeset [114130] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2012-04-13 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Build fix after r114126.

  • WebKit.gyp:
07:23 Changeset [114129] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[Qt][WK2] Title in MiniBrowser is not updated for a page with no title
https://bugs.webkit.org/show_bug.cgi?id=82483

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-04-13
Reviewed by Noam Rosenthal.

This fixes API tests broken by r113715.

  • UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_titleChanged.qml:
07:18 Changeset [114128] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update.

  • platform/gtk/test_expectations.txt: Marking some css2.1 tests flaky.
07:16 Changeset [114127] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Mark test as flaky.

Unreviewed.

  • platform/chromium/test_expectations.txt:
06:50 Changeset [114126] by yurys@chromium.org
  • 19 edits
    1 add
    2 deletes in trunk

Web Inspector: exception in heap profiler when expanding a class in summary view
https://bugs.webkit.org/show_bug.cgi?id=83883

Moved all DOM-specific inspector utilities into DOMExtension.js

Merged BinarySearch.js and PartialQuickSort.js into utilities.js, HeapSnapshotWorker.js now
imports utilities.js which contains all required routines.

Reviewed by Pavel Feldman.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/BinarySearch.js: Removed.
  • inspector/front-end/DOMExtension.js: Copied from Source/WebCore/inspector/front-end/utilities.js.

(Node.prototype.rangeOfWord):
(Node.prototype.traverseNextTextNode):
(Node.prototype.rangeBoundaryForOffset):
(Element.prototype.removeStyleClass):
(Element.prototype.removeMatchingStyleClasses):
(Element.prototype.addStyleClass):
(Element.prototype.hasStyleClass):
(Element.prototype.positionAt):
(Element.prototype.pruneEmptyTextNodes):
(Element.prototype.isScrolledToBottom):
(Node.prototype.enclosingNodeOrSelfWithNodeNameInArray):
(Node.prototype.enclosingNodeOrSelfWithNodeName):
(Node.prototype.enclosingNodeOrSelfWithClass):
(Node.prototype.enclosingNodeWithClass):
(Element.prototype.query):
(Element.prototype.removeChildren):
(Element.prototype.isInsertionCaretInside):
(Element.prototype.createChild):
(Element.prototype.totalOffsetLeft):
(Element.prototype.totalOffsetTop):
(Element.prototype.totalOffset):
(Element.prototype.scrollOffset):
(AnchorBox):
(Element.prototype.offsetRelativeToWindow):
(Element.prototype.boxInWindow):
(Element.prototype.setTextAndTitle):
(Event.prototype.consume):
(Text.prototype.select):
(Element.prototype.selectionLeftOffset):
(Node.prototype.isAncestor):
(Node.prototype.isDescendant):
(Node.prototype.isSelfOrAncestor):
(Node.prototype.isSelfOrDescendant):
(Node.prototype.traverseNextNode):
(Node.prototype.traversePreviousNode):
(HTMLTextAreaElement.prototype.moveCursorToEnd):
(isEnterKey):
(consumeEvent):
(highlightSearchResult):
(highlightSearchResults):
(highlightRangesWithStyleClass):
(applyDomChanges):
(revertDomChanges):

  • inspector/front-end/HeapSnapshot.js: Fixed a couple of js compiler warnings

by describing structure of heap snapshot header in the protocol.
(WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):

  • inspector/front-end/HeapSnapshotWorker.js:
  • inspector/front-end/PartialQuickSort.js: Removed.
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/utilities.js:

(.):

06:45 Changeset [114125] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Mark test as flaky.

Unreviewed.

  • platform/chromium/test_expectations.txt:
06:26 Changeset [114124] by commit-queue@webkit.org
  • 4 edits in trunk

Unreviewed, rolling out r113714.
http://trac.webkit.org/changeset/113714
https://bugs.webkit.org/show_bug.cgi?id=83887

It is behaving strange on the bots and needs more
investigation. (Requested by jeez_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-13

Source/WebKit2:

  • UIProcess/qt/QtPageClient.cpp:

(QtPageClient::isViewWindowActive):

Tools:

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::PlatformWebView):

06:16 Changeset [114123] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Unreviewed, rolling out r114103.
http://trac.webkit.org/changeset/114103
https://bugs.webkit.org/show_bug.cgi?id=83884

New breakpoint UI looks bad / needs polish. (Requested by
pfeldman_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-13

  • inspector/front-end/Images/breakpointConditionalCounterBorder.png:
  • inspector/front-end/Images/breakpointCounterBorder.png:
  • inspector/front-end/Images/programCounterBorder.png:
  • inspector/front-end/textViewer.css:

(.webkit-execution-line .webkit-line-number-outer):
(.webkit-breakpoint.webkit-execution-line .webkit-line-number-outer):
(.webkit-breakpoint-conditional.webkit-execution-line .webkit-line-number-outer):

06:14 Changeset [114122] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[BlackBerry] Sign in cookie for ESPN.com does not retain login account (for fantasy sports).
https://bugs.webkit.org/show_bug.cgi?id=83760

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-13
Reviewed by George Staikos.

.:

  • ManualTests/blackberry/http-cookie-database-set.php: Added.
  • ManualTests/blackberry/http-cookie-database-update.php: Added.

Source/WebCore:

When we update cookies' database, protocol shouldn't be checked since it is not a cookie's key.
ESPN.com's https cookies should replace old http cookies if they have the same keys(name, path, domain).

We must restart the browser to test, so have to write a manual test case.

Test: ManualTests/blackberry/http-cookie-database-set.php

  • platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:

(WebCore::CookieDatabaseBackingStore::invokeOpen):

06:06 Changeset [114121] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Mark test as flaky.

Unreviewed.

  • platform/chromium/test_expectations.txt:
06:01 Changeset [114120] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/Tools

webkit-tools-completion: Support bugzilla email completion for webkit-patch upload --cc
https://bugs.webkit.org/show_bug.cgi?id=83690

Reviewed by Tor Arne Vestbø.

Typing part of an email and pressing <TAB> will bash-complete it using the list in
Tools/Scripts/webkitpy/common/config/committers.py

  • Scripts/webkit-tools-completion.sh:
05:57 Changeset [114119] by ossy@webkit.org
  • 6 edits in trunk/LayoutTests

[Qt] Gardening: rebaseline 2 tests and add 5 tests to skiplist.

Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-04-13
Reviewed by Csaba Osztrogonác.

  • platform/qt-5.0-wk2/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt-5.0/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt/Skipped:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
05:56 Changeset [114118] by jocelyn.turcotte@nokia.com
  • 4 edits in trunk/Source

[Qt] Use QQuickFlickable::setPixelAligned instead of doing pixel-alignment when rendering.
https://bugs.webkit.org/show_bug.cgi?id=83770

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Revert the previous way of dealing with things. The problem is that different layers
would end up rounding in different directions, and would cause jittering between
layers or with the QQuickWebPage's background.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::drawTexture):

Source/WebKit2:

  • Do the alignment on the highest level as possible: the QQuickFlickable content item position. It already supports this with setPixelAligned which rounds the content item's position.
  • Also move the setClip(true) to the common constructor as this constructor is currently only used by WTR.
  • Remove setFlags(QQuickItem::ItemClipsChildrenToShape) as it is redundant with setClip(true).
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebView::QQuickWebView):

05:25 Changeset [114117] by pfeldman@chromium.org
  • 15 edits in trunk

Web Inspector: introduce ParsedURL type, clean up url and displayName mess in Resource and NetworkRequest.
https://bugs.webkit.org/show_bug.cgi?id=83871

Reviewed by Yury Semikhatsky.

Source/WebCore:

There is a number of random properties created on Resource and NetworkRequest that represent various url
fragments. Display name is being based on them and sometimes requires fake Resource instance to be created.
This change (officially) introduces WebInspector.ParsedURL as a type that encapsulates this complexity.

This change also moves documentURL property into the Resource and NetworkRequest constructors and brushes up
factory methods used to create the objects.

  • inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.GzipRule.prototype._shouldCompress):
(WebInspector.AuditRules.CookieSizeRule.prototype.processCookies):

  • inspector/front-end/Database.js:

(WebInspector.Database.prototype.get displayDomain):

  • inspector/front-end/JavaScriptContextManager.js:

(WebInspector.FrameEvaluationContext.prototype.get displayName):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkDispatcher.prototype.webSocketCreated):
(WebInspector.NetworkDispatcher.prototype._createNetworkRequest):
(get WebInspector):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._highlightNthMatchedRequest):
(WebInspector.NetworkDataGridNode.prototype._refreshNameCell):

  • inspector/front-end/NetworkRequest.js:

(WebInspector.NetworkRequest):
(WebInspector.NetworkRequest.prototype.set url):
(WebInspector.NetworkRequest.prototype.get documentURL):
(WebInspector.NetworkRequest.prototype.get parsedURL):
(WebInspector.NetworkRequest.prototype.get displayName):
(WebInspector.NetworkRequest.prototype.get folder):

  • inspector/front-end/RequestHeadersView.js:

(WebInspector.RequestHeadersView.prototype._refreshUrlFragment):

  • inspector/front-end/Resource.js:

(WebInspector.Resource):
(WebInspector.Resource.prototype.set url):
(WebInspector.Resource.prototype.get parsedURL):
(WebInspector.Resource.prototype.get frameId):
(WebInspector.Resource.prototype.get loaderId):
(WebInspector.Resource.prototype.get displayName):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype._onRequestUpdateDropped):
(WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
(WebInspector.ResourceTreeModel.prototype._createResourceFromFramePayload):
(WebInspector.ResourceTreeFrame.prototype._addRequest):

  • inspector/front-end/ResourceUtils.js:

(WebInspector.ParsedURL):
(WebInspector.ParsedURL.prototype.get displayName):
(String.prototype.asParsedURL):
(WebInspector.displayDomain):
(WebInspector.resourceURLForRelatedNode.callback):
(WebInspector.resourceURLForRelatedNode):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameTreeElement.prototype.frameNavigated):
(WebInspector.ApplicationCacheManifestTreeElement):
(WebInspector.ApplicationCacheFrameTreeElement.prototype._refreshTitles):

  • inspector/front-end/utilities.js:

LayoutTests:

  • inspector/debugger/raw-source-code.html:
05:15 Changeset [114116] by pfeldman@chromium.org
  • 11 edits in trunk

Web Inspector: extracting NetworkRequest from Resource (step 3)
https://bugs.webkit.org/show_bug.cgi?id=83802

Reviewed by Yury Semikhatsky.

Source/WebCore:

This change extracts NetworkRequest from the Resource. It is now clear that these two
should have super class that would be responsible for parsing URL and would define the
requestContent signature. Corresponding patch will follow.

  • inspector/front-end/NetworkManager.js:
  • inspector/front-end/NetworkRequest.js:

(WebInspector.NetworkRequest):
(WebInspector.NetworkRequest.prototype.get requestId):
(WebInspector.NetworkRequest.prototype.set requestId):
(WebInspector.NetworkRequest.prototype.get url):
(WebInspector.NetworkRequest.prototype.get frameId):
(WebInspector.NetworkRequest.prototype.get loaderId):
(WebInspector.NetworkRequest.prototype.get startTime):
(WebInspector.NetworkRequest.prototype.set startTime):
(WebInspector.NetworkRequest.prototype.get responseReceivedTime):
(WebInspector.NetworkRequest.prototype.set responseReceivedTime):
(WebInspector.NetworkRequest.prototype.get endTime):
(WebInspector.NetworkRequest.prototype.set endTime):
(WebInspector.NetworkRequest.prototype.get duration):
(WebInspector.NetworkRequest.prototype.get latency):
(WebInspector.NetworkRequest.prototype.get receiveDuration):
(WebInspector.NetworkRequest.prototype.get resourceSize):
(WebInspector.NetworkRequest.prototype.set resourceSize):
(WebInspector.NetworkRequest.prototype.get transferSize):
(WebInspector.NetworkRequest.prototype.increaseTransferSize):
(WebInspector.NetworkRequest.prototype.get finished):
(WebInspector.NetworkRequest.prototype.set finished):
(WebInspector.NetworkRequest.prototype.get failed):
(WebInspector.NetworkRequest.prototype.set failed):
(WebInspector.NetworkRequest.prototype.get canceled):
(WebInspector.NetworkRequest.prototype.set canceled):
(WebInspector.NetworkRequest.prototype.get cached):
(WebInspector.NetworkRequest.prototype.set cached):
(WebInspector.NetworkRequest.prototype.get timing):
(WebInspector.NetworkRequest.prototype.set timing):
(WebInspector.NetworkRequest.prototype.get mimeType):
(WebInspector.NetworkRequest.prototype.set mimeType):
(WebInspector.NetworkRequest.prototype.get displayName):
(WebInspector.NetworkRequest.prototype.get folder):
(WebInspector.NetworkRequest.prototype.get displayDomain):
(WebInspector.NetworkRequest.prototype.get type):
(WebInspector.NetworkRequest.prototype.set type):
(WebInspector.NetworkRequest.prototype.get redirectSource):
(WebInspector.NetworkRequest.prototype.set redirectSource):
(WebInspector.NetworkRequest.prototype.get requestHeaders):
(WebInspector.NetworkRequest.prototype.set requestHeaders):
(WebInspector.NetworkRequest.prototype.get requestHeadersText):
(WebInspector.NetworkRequest.prototype.set requestHeadersText):
(WebInspector.NetworkRequest.prototype.get requestHeadersSize):
(WebInspector.NetworkRequest.prototype.requestHeaderValue):
(WebInspector.NetworkRequest.prototype.get requestCookies):
(WebInspector.NetworkRequest.prototype.get requestFormData):
(WebInspector.NetworkRequest.prototype.set requestFormData):
(WebInspector.NetworkRequest.prototype.get requestHttpVersion):
(WebInspector.NetworkRequest.prototype.get responseHeaders):
(WebInspector.NetworkRequest.prototype.set responseHeaders):
(WebInspector.NetworkRequest.prototype.get responseHeadersText):
(WebInspector.NetworkRequest.prototype.set responseHeadersText):
(WebInspector.NetworkRequest.prototype.get responseHeadersSize):
(WebInspector.NetworkRequest.prototype.responseHeaderValue):
(WebInspector.NetworkRequest.prototype.get responseCookies):
(WebInspector.NetworkRequest.prototype.get queryParameters):
(WebInspector.NetworkRequest.prototype.get formParameters):
(WebInspector.NetworkRequest.prototype.get responseHttpVersion):
(WebInspector.NetworkRequest.prototype._parseParameters):
(WebInspector.NetworkRequest.prototype._headerValue):
(WebInspector.NetworkRequest.prototype.get content):
(WebInspector.NetworkRequest.prototype.get contentEncoded):
(WebInspector.NetworkRequest.prototype.requestContent):
(WebInspector.NetworkRequest.prototype.isHttpFamily):
(WebInspector.NetworkRequest.prototype.requestContentType):
(WebInspector.NetworkRequest.prototype.isPingRequest):
(WebInspector.NetworkRequest.prototype.hasErrorStatusCode):
(WebInspector.NetworkRequest.prototype.populateImageSource):
(WebInspector.NetworkRequest.prototype._contentURL):
(WebInspector.NetworkRequest.prototype._innerRequestContent.onResourceContent):
(WebInspector.NetworkRequest.prototype._innerRequestContent):
(WebInspector.NetworkRequest.prototype.setResource):
(WebInspector.NetworkRequest.prototype.resource):

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype._resourceAdded):
(WebInspector.RawSourceCode.prototype.forceUpdateSourceMapping):
(WebInspector.RawSourceCode.prototype._createContentProvider):

  • inspector/front-end/Resource.js:

(WebInspector.Resource):
(WebInspector.Resource.displayName):
(WebInspector.Resource.prototype.get request):
(WebInspector.Resource.prototype.set url):
(WebInspector.Resource.prototype.get type):
(WebInspector.Resource.prototype.get mimeType):
(WebInspector.Resource.prototype.set mimeType):
(WebInspector.Resource.prototype.get content):
(WebInspector.Resource.prototype.get contentEncoded):
(WebInspector.Resource.prototype.requestContent):
(WebInspector.Resource.prototype._innerRequestContent.callback):
(WebInspector.Resource.prototype._innerRequestContent):
(WebInspector.ResourceRevision.prototype.requestContent.callbackWrapper):
(WebInspector.ResourceRevision.prototype.requestContent):

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype.addScript):

LayoutTests:

  • http/tests/inspector/network/network-request-revision-content.html:
  • inspector/debugger/raw-source-code.html:
  • inspector/debugger/set-breakpoint.html:
  • inspector/debugger/source-frame.html:
05:12 Changeset [114115] by reed@google.com
  • 2 edits in trunk/Source/WebCore

use getClipDeviceBounds, rather than (deprecated) getTotalClip
https://bugs.webkit.org/show_bug.cgi?id=83808

Reviewed by Stephen White.

Equivalent functionality, existing tests apply.

  • platform/graphics/skia/OpaqueRegionSkia.cpp:

(WebCore::OpaqueRegionSkia::didDraw):

05:02 Changeset [114114] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Mark test as flaky.

Unreviewed.

  • platform/chromium/test_expectations.txt:
04:44 Changeset [114113] by commit-queue@webkit.org
  • 14 edits
    2 adds in trunk

[EFL] Add API for color chooser
https://bugs.webkit.org/show_bug.cgi?id=83692

.:

Enables INPUT_TYPE_COLOR by default on the EFL port.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-13
Reviewed by Kenneth Rohde Christiansen.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/WebCore:

Added new API to enable browsers to display a custom color picker
when an input field of type "color" is activated.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-13
Reviewed by Kenneth Rohde Christiansen.

  • PlatformEfl.cmake:
  • platform/efl/ColorChooserEfl.cpp: Added.

(WebCore):
(WebCore::ColorChooserEfl::ColorChooserEfl):
(WebCore::ColorChooserEfl::~ColorChooserEfl):
(WebCore::ColorChooserEfl::setSelectedColor):
(WebCore::ColorChooserEfl::endChooser):

  • platform/efl/ColorChooserEfl.h: Added.

(WebCore):
(ColorChooserEfl):

Source/WebKit/efl:

Added new API to enable browsers to display a custom color picker
when an input field of type "color" is activated.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-13
Reviewed by Kenneth Rohde Christiansen.

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore):
(WebCore::ChromeClientEfl::createColorChooser):
(WebCore::ChromeClientEfl::removeColorChooser):
(WebCore::ChromeClientEfl::updateColorChooser):

  • WebCoreSupport/ChromeClientEfl.h:

(ChromeClientEfl):

  • ewk/ewk_private.h:

(WebCore):

  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(ewk_view_color_chooser_new):
(ewk_view_color_chooser_destroy):
(ewk_view_color_chooser_color_set):
(ewk_view_color_chooser_changed):

  • ewk/ewk_view.h:

Tools:

Enables INPUT_TYPE_COLOR by default on the EFL port.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-13
Reviewed by Kenneth Rohde Christiansen.

  • Scripts/build-webkit:
04:25 Changeset [114112] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update.

  • platform/gtk/test_expectations.txt:
04:19 Changeset [114111] by antonm@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

Linux rebaselines.

Unreviewed.

  • platform/chromium-linux/platform/chromium/compositing/filters: Added.
  • platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-expected.png: Added.
  • platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Added.
04:16 Changeset [114110] by vestbo@webkit.org
  • 3 edits in trunk/Source/WebKit/qt

[Qt] Build fix with QT_NO_BEARERMANAGEMENT

Reviewed by Jocelyn Turcotte.

04:11 Changeset [114109] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Enabling/disabling delegates scrolling when page has no composited content asserts on WK1.
https://bugs.webkit.org/show_bug.cgi?id=83860

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-13
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

WK2 has compositing mode on all the time, while Wk1 turns it on only when
the page has composited content. This patch ensures that, when delegates scrolling behavior
is changed, backing stores are cleared only when there's an actual composition,
similarly to what CachedFrame does.

Test: fast/viewport/scroll-delegates-switch-on-page-with-no-composition-mode-asserts.html

  • page/FrameView.cpp:

(WebCore::FrameView::delegatesScrollingDidChange):

LayoutTests:

  • fast/viewport/scroll-delegates-switch-on-page-with-no-composition-mode-asserts-expected.txt: Added.
  • fast/viewport/scroll-delegates-switch-on-page-with-no-composition-mode-asserts.html: Added.
04:09 Changeset [114108] by keishi@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Add WebKit API to access <datalist> options
https://bugs.webkit.org/show_bug.cgi?id=83762

Introduce WebInputElement::dataListOptions so we can implement a UI for datalist.

Reviewed by Kent Tamura.

  • public/WebInputElement.h:

(WebKit):
(WebInputElement):

  • src/WebInputElement.cpp:

(WebKit::WebInputElement::dataListOptions): Added. Returns a WebNodeCollection containing WebOptionElements.

04:00 April 2012 Meeting edited by zherczeg@inf.u-szeged.hu
(diff)
03:39 Changeset [114107] by philn@webkit.org
  • 2 edits
    64 adds in trunk/LayoutTests

Unreviewed, GTK baselines for tests now being runned since the
migration to test_expectations.

  • platform/gtk/css3/font-feature-settings-rendering-expected.txt: Added.
  • platform/gtk/editing/pasteboard/smart-drag-drop-expected.txt: Added.
  • platform/gtk/fast/block/float/avoiding-float-centered-expected.txt: Added.
  • platform/gtk/fast/dom/gc-10-expected.txt: Added.
  • platform/gtk/fast/forms/date/date-appearance-expected.txt: Added.
  • platform/gtk/fast/images/exif-orientation-css-expected.txt: Added.
  • platform/gtk/fast/images/exif-orientation-expected.txt: Added.
  • platform/gtk/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Added.
  • platform/gtk/fast/regions/flow-content-basic-expected.txt: Added.
  • platform/gtk/fast/regions/flow-content-basic-vertical-expected.txt: Added.
  • platform/gtk/fast/regions/flow-content-basic-vertical-rl-expected.txt: Added.
  • platform/gtk/fast/regions/flows-dependency-dynamic-remove-expected.txt: Added.
  • platform/gtk/fast/regions/flows-dependency-same-flow-expected.txt: Added.
  • platform/gtk/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Added.
  • platform/gtk/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt: Added.
  • platform/gtk/fast/regions/overflow-in-variable-width-regions-expected.txt: Added.
  • platform/gtk/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Added.
  • platform/gtk/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt: Added.
  • platform/gtk/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt: Added.
  • platform/gtk/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt: Added.
  • platform/gtk/fast/regions/overflow-size-change-with-stacking-context-expected.txt: Added.
  • platform/gtk/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt: Added.
  • platform/gtk/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.txt: Added.
  • platform/gtk/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.txt: Added.
  • platform/gtk/fast/regions/percentage-margins-rtl-variable-width-regions-expected.txt: Added.
  • platform/gtk/fast/regions/percentage-margins-variable-width-regions-expected.txt: Added.
  • platform/gtk/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Added.
  • platform/gtk/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Added.
  • platform/gtk/fast/regions/region-style-block-background-color-expected.txt: Added.
  • platform/gtk/fast/regions/region-style-block-background-color2-expected.txt: Added.
  • platform/gtk/fast/regions/region-style-image-background-color-expected.txt: Added.
  • platform/gtk/fast/regions/region-style-inline-background-color-expected.txt: Added.
  • platform/gtk/fast/regions/render-region-custom-style-mark-expected.txt: Added.
  • platform/gtk/fast/regions/text-region-split-small-pagination-expected.txt: Added.
  • platform/gtk/fast/regions/top-overflow-out-of-second-region-expected.txt: Added.
  • platform/gtk/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Added.
  • platform/gtk/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Added.
  • platform/gtk/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Added.
  • platform/gtk/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Added.
  • platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Added.
  • platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Added.
  • platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Added.
  • platform/gtk/fast/text/hyphenate-character-expected.txt: Added.
  • platform/gtk/fast/text/hyphenate-first-word-expected.txt: Added.
  • platform/gtk/fast/text/hyphenate-locale-expected.txt: Added.
  • platform/gtk/fast/text/hyphens-expected.txt: Added.
  • platform/gtk/fast/viewport/viewport-126-expected.txt: Added.
  • platform/gtk/fast/viewport/viewport-127-expected.txt: Added.
  • platform/gtk/fast/viewport/viewport-65-expected.txt: Added.
  • platform/gtk/fast/viewport/viewport-82-expected.txt: Added.
  • platform/gtk/fast/viewport/viewport-84-expected.txt: Added.
  • platform/gtk/fast/viewport/viewport-87-expected.txt: Added.
  • platform/gtk/mathml/presentation/mo-stretch-expected.txt: Added.
  • platform/gtk/mathml/presentation/msub-base-changed-expected.txt: Added.
  • platform/gtk/mathml/presentation/msub-sub-changed-expected.txt: Added.
  • platform/gtk/mathml/presentation/msubsup-base-changed-expected.txt: Added.
  • platform/gtk/mathml/presentation/msubsup-sub-changed-expected.txt: Added.
  • platform/gtk/mathml/presentation/msubsup-sup-changed-expected.txt: Added.
  • platform/gtk/mathml/presentation/msup-base-changed-expected.txt: Added.
  • platform/gtk/mathml/presentation/msup-sup-changed-expected.txt: Added.
  • platform/gtk/plugins/plugin-initiate-popup-window-expected.txt: Added.
  • platform/gtk/test_expectations.txt: Mark a media/track test flaky.
03:37 Changeset [114106] by vestbo@webkit.org
  • 3 edits in trunk/Source/WebKit/qt

[Qt] Fix build on OS X

We were manually including the directories needed from WTF, instead of
using the WEBKIT qmake variable to add dependencies, which also adds
other tricks from WTF.pri, such as the right include paths for ICU.

Reviewed by Simon Hausmann.

03:29 WebKitGTK/WebKit2Roadmap edited by mario@webkit.org
(diff)
03:23 Changeset [114105] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

New suppression.

Unreviewed.

  • platform/chromium/test_expectations.txt:
03:11 Changeset [114104] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update.

  • platform/gtk/test_expectations.txt: Skip two media tests trigger flakiness.
03:10 Changeset [114103] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Line number is not displayed while debugging javascript
https://bugs.webkit.org/show_bug.cgi?id=83786

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-04-13
Reviewed by Pavel Feldman.

Changed the textViewer.css to start displaying the line number with
appropriate color property. Added outline property for enhanced view

No additional test cases required for the above fix.

  • inspector/front-end/Images/breakpointConditionalCounterBorder.png:
  • inspector/front-end/Images/breakpointCounterBorder.png:
  • inspector/front-end/Images/programCounterBorder.png:
  • inspector/front-end/textViewer.css:

(.webkit-execution-line .webkit-line-number-outer):
(.webkit-breakpoint.webkit-execution-line .webkit-line-number-outer):
(.webkit-breakpoint-conditional.webkit-execution-line .webkit-line-number-outer):

02:37 Changeset [114102] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Now test sometimes crashes in Debug on XP too.

Unreviewed.

  • platform/chromium/test_expectations.txt:
02:15 Changeset [114101] by tkent@chromium.org
  • 7 edits in trunk/Source

Add a runtime flag for <input type=date>
https://bugs.webkit.org/show_bug.cgi?id=83853

Reviewed by Adam Barth.

Source/WebCore:

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::inputTypeDateEnabled): Added.
(WebCore::RuntimeEnabledFeatures::setInputTypeDateEnabled): Added.

  • html/InputType.cpp:

(WebCore::createInputTypeFactoryMap):
Don't register type=date if !RuntimeEnabledFeatures::inputTypeDateEnabled()

Source/WebKit/chromium:

  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures): Add enableInputTypeDate() and isInputTypeDateEnabled().

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableInputTypeDate): Added.
(WebKit::WebRuntimeFeatures::isInputTypeDateEnabled): Added.

02:12 Changeset [114100] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update.

  • platform/gtk/test_expectations.txt: Skip failing new

encrypted-media test.

01:58 Changeset [114099] by antonm@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

Rebaselines.

Unreviewed.

  • platform/chromium-mac/fast/ruby/nested-ruby-expected.txt: Added.
  • platform/chromium-mac/fast/text/international/002-expected.png: Added.
  • platform/chromium-mac/fast/text/international/002-expected.txt: Added.
01:57 Changeset [114098] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

JSDocument::setLocation does too much bare-handed lifting
https://bugs.webkit.org/show_bug.cgi?id=83850

Reviewed by Sam Weinig.

As part of auditing all the ways of kicking off a navigation, I
happened to read JSDocument::setLocation, which uses very old patterns.
This patch updates it to do things the "modern" way. There shouldn't
be any behavior change.

  • bindings/js/JSDocumentCustom.cpp:

(WebCore::JSDocument::setLocation):

01:55 Changeset [114097] by antonm@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

Rebaselines.

Unreviewed.

  • platform/chromium-win/platform/chromium/compositing/filters: Added.
  • platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-expected.png: Added.
  • platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Added.
  • platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Added.
01:44 Changeset [114096] by philn@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline.

  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
01:39 Changeset [114095] by shinyak@chromium.org
  • 5 edits
    4 adds in trunk

Background width (or height) is wrong if width (or height) * zoom < 1.
https://bugs.webkit.org/show_bug.cgi?id=83350

Reviewed by Nikolas Zimmermann.

Source/WebCore:

calculateImageIntrinsicDimension will return wrong size if the calculated size is 0.
0 is used for expressing unspecfied, so the method returns the box width(height) instead.

Since CachedImage has already similar code, we moved it to IntSize and shared it.

Tests: fast/css/zoom-background-repeat-x-expected.html

fast/css/zoom-background-repeat-x.html
fast/css/zoom-background-repeat-y-expected.html
fast/css/zoom-background-repeat-y.html

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::imageSizeForRenderer):

  • platform/graphics/IntSize.h:

(IntSize):
(WebCore::IntSize::scale):
(WebCore::IntSize::clampToMinimumSize):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions):

LayoutTests:

  • fast/css/zoom-background-repeat-x-expected.html: Added.
  • fast/css/zoom-background-repeat-x.html: Added.
  • fast/css/zoom-background-repeat-y-expected.html: Added.
  • fast/css/zoom-background-repeat-y.html: Added.
00:56 Changeset [114094] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-13

  • DEPS:
00:53 Changeset [114093] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Prepare submitForm for seamless navigation
https://bugs.webkit.org/show_bug.cgi?id=83838

Reviewed by Ryosuke Niwa.

Previously, FrameLoader::submitForm called FrameTree::find and
Document::canNavigate separately. This patch refactors this function
to call findFrameForNavigation, which does both checks.

This doesn't change any behavior today, but it prepares us to implement
seamless navigation. Once the seamless branch lands, this change will
be tested by seamless-form-* in https://github.com/eseidel/webkit/tree/seamless/LayoutTests/fast/frames/seamless

For context, see:
https://github.com/eseidel/webkit/commit/3f27340577ac91b2cc0a834dd2c6fdfcac296c32

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::submitForm):

00:35 Changeset [114092] by tkent@chromium.org
  • 3 edits
    2 adds in trunk

Should clear an invalid string in a date field on blur
https://bugs.webkit.org/show_bug.cgi?id=83863

Reviewed by Kentaro Hara.

Source/WebCore:

Test: fast/forms/date/input-date-commit-valid-only.html

  • html/DateInputType.cpp:

(WebCore::DateInputType::handleBlurEvent):
Reset the visible value. The code is same as NumberInputType::handleBlurEvent().

LayoutTests:

  • fast/forms/date/input-date-commit-valid-only-expected.txt: Added.
  • fast/forms/date/input-date-commit-valid-only.html: Added.
00:30 Changeset [114091] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] <input type=date> tests should pass.

  • platform/chromium/test_expectations.txt:

04/12/12:

23:33 Changeset [114090] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Calendar Picker: remove unnecessary code from calendarPicker.{css,js}
https://bugs.webkit.org/show_bug.cgi?id=83685

Reviewed by Kentaro Hara.

Remove the followings from input files:

  • multi line comments /*...*/ (.js and .css)
  • single line comment ... (.js)
  • repeating whitespace (.js and .css)
  • leading and trailing whitespace (.js and .css)
  • empty lines (.js and .css)

This doesn't work for arbitrary JavaScript or CSS inputs, but
works well for expected input files like
css/make-css-file-arrays.pl

  • make-file-arrays.py:

(strip_whitespace_and_comments):
(main):

23:19 Changeset [114089] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Mark test as also crashing.

Unreviewed.

  • platform/chromium/test_expectations.txt:
23:14 Changeset [114088] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Chromium: Fix scrollbar tickmark drawing on Mountain Lion
https://bugs.webkit.org/show_bug.cgi?id=83844

Patch by Sailesh Agrawal <sail@chromium.org> on 2012-04-12
Reviewed by James Robinson.

On Mountain Lion overlay scrollbars have a new expanded mode. In expanded mode the scrolllbar is slightly wider which causes the tickmarks to look incorrect. Fix was to explicitly enter expanded mode to get the correct look.
Screenshots:
broken: http://i.imgur.com/PDKYH.png
fixed: http://i.imgur.com/utp0Y.png

  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::paint): Called setExpanded if API is available.

  • platform/mac/NSScrollerImpDetails.h: Exposed the isExpanded: API.
23:11 Changeset [114087] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Rebaselines.

Unreviewed.

  • platform/chromium-linux/svg/transforms/text-with-mask-with-svg-transform-expected.png:
23:08 Changeset [114086] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Rebaselines.

Unreviewed.

  • platform/chromium-linux/svg/text/font-size-below-point-five-expected.txt:
23:07 Changeset [114085] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

LocalizedDateICU should ignore timezones
https://bugs.webkit.org/show_bug.cgi?id=83859

Reviewed by Hajime Morita.

udat_parse() and udat_format() shift the input date by the offset of the
default timezone. We don't need this behavior for type=date. So we
specify "GMT" to udat_open().

No new tests. This behavior depends on the timezone setting of the local machine.

  • platform/text/LocalizedDateICU.cpp:

(WebCore::createShortDateFormatter):
Added. Common factory functio for UDateFormat. Use "GMT" instead of the
default timezone.
(WebCore::parseLocalizedDate): Use createShortDateFormatter().
(WebCore::formatLocalizedDate): ditto.

23:00 Changeset [114084] by carlosgc@webkit.org
  • 2 edits in trunk

[GTK] Enable WebKit2 by default in configure
https://bugs.webkit.org/show_bug.cgi?id=83753

Reviewed by Martin Robinson.

  • configure.ac:
22:37 Changeset [114083] by antonm@chromium.org
  • 139 edits
    17 adds
    25 deletes in trunk/LayoutTests

Rebaselines.

Unreviewed.

  • fast/media/mq-min-pixel-ratio-expected.txt: Added.
  • fast/reflections/reflection-masks-expected.txt: Added.
  • fast/reflections/reflection-masks-opacity-expected.txt: Added.
  • fast/reflections/reflection-masks-outset-expected.png: Added.
  • platform/chromium-mac-leopard/css3/filters/crash-filter-change-expected.png:
  • platform/chromium-mac-leopard/css3/filters/crash-hw-sw-switch-expected.png:
  • platform/chromium-mac-leopard/css3/filters/custom/missing-custom-filter-shader-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-blur-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-blur-hw-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-brightness-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-brightness-hw-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-combined-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-combined-hw-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-contrast-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-contrast-hw-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-drop-shadow-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-drop-shadow-hw-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-grayscale-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-grayscale-hw-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-hue-rotate-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-hue-rotate-hw-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-invert-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-invert-hw-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-opacity-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-opacity-hw-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-saturate-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-saturate-hw-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-sepia-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-sepia-hw-expected.png:
  • platform/chromium-mac-leopard/css3/filters/regions-expanding-expected.png:
  • platform/chromium-mac-leopard/fast/css/background-shorthand-invalid-url-expected.png:
  • platform/chromium-mac-leopard/fast/media/mq-min-pixel-ratio-expected.png:
  • platform/chromium-mac-leopard/fast/reflections/reflection-direction-expected.png:
  • platform/chromium-mac-leopard/fast/reflections/reflection-masks-expected.png:
  • platform/chromium-mac-leopard/fast/reflections/reflection-masks-opacity-expected.png:
  • platform/chromium-mac-leopard/fast/reflections/reflection-masks-outset-expected.png:
  • platform/chromium-mac-leopard/svg/custom/createImageElement-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/createImageElement2-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-leopard/svg/custom/focus-ring-expected.png:
  • platform/chromium-mac-leopard/svg/custom/image-parent-translation-expected.png:
  • platform/chromium-mac-leopard/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-mac-leopard/svg/custom/image-with-transform-clip-filter-expected.png:
  • platform/chromium-mac-leopard/svg/custom/js-update-image-and-display-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/js-update-image-and-display2-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/js-update-image-and-display3-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/js-update-image-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/pointer-events-image-css-transform-expected.png:
  • platform/chromium-mac-leopard/svg/custom/pointer-events-image-expected.png:
  • platform/chromium-mac-leopard/svg/custom/text-image-opacity-expected.png:
  • platform/chromium-mac-leopard/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png:
  • platform/chromium-mac-leopard/svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
  • platform/chromium-mac-leopard/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/chromium-mac-leopard/svg/wicd/test-rightsizing-b-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-background-images-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/masks/direct-image-mask-expected.png:
  • platform/chromium-mac-snowleopard/compositing/reflections/simple-composited-reflections-expected.png:
  • platform/chromium-mac-snowleopard/css3/filters/crash-hw-sw-switch-expected.png:
  • platform/chromium-mac-snowleopard/fast/media/mq-min-pixel-ratio-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/reflections/reflection-direction-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/fast/reflections/reflection-masks-opacity-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/createImageElement2-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/svg/custom/focus-ring-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/svg/custom/image-parent-translation-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/image-with-transform-clip-filter-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-css-transform-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/svg/custom/text-image-opacity-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/chromium-mac-snowleopard/svg/wicd/test-rightsizing-b-expected.png:
  • platform/chromium-mac/compositing/masks/direct-image-mask-expected.png:
  • platform/chromium-mac/compositing/reflections/simple-composited-reflections-expected.png:
  • platform/chromium-mac/compositing/visibility/visibility-image-layers-expected.png: Added.
  • platform/chromium-mac/css3/filters/crash-filter-change-expected.png:
  • platform/chromium-mac/css3/filters/crash-hw-sw-switch-expected.png:
  • platform/chromium-mac/css3/filters/custom/missing-custom-filter-shader-expected.png:
  • platform/chromium-mac/css3/filters/effect-blur-expected.png:
  • platform/chromium-mac/css3/filters/effect-blur-hw-expected.png:
  • platform/chromium-mac/css3/filters/effect-brightness-expected.png:
  • platform/chromium-mac/css3/filters/effect-brightness-hw-expected.png:
  • platform/chromium-mac/css3/filters/effect-combined-expected.png:
  • platform/chromium-mac/css3/filters/effect-combined-hw-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/css3/filters/effect-contrast-expected.png:
  • platform/chromium-mac/css3/filters/effect-contrast-hw-expected.png:
  • platform/chromium-mac/css3/filters/effect-drop-shadow-expected.png:
  • platform/chromium-mac/css3/filters/effect-drop-shadow-hw-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/css3/filters/effect-grayscale-expected.png:
  • platform/chromium-mac/css3/filters/effect-grayscale-hw-expected.png:
  • platform/chromium-mac/css3/filters/effect-hue-rotate-expected.png:
  • platform/chromium-mac/css3/filters/effect-hue-rotate-hw-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/css3/filters/effect-invert-expected.png:
  • platform/chromium-mac/css3/filters/effect-invert-hw-expected.png:
  • platform/chromium-mac/css3/filters/effect-opacity-expected.png:
  • platform/chromium-mac/css3/filters/effect-opacity-hw-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/css3/filters/effect-saturate-expected.png:
  • platform/chromium-mac/css3/filters/effect-saturate-hw-expected.png:
  • platform/chromium-mac/css3/filters/effect-sepia-expected.png:
  • platform/chromium-mac/css3/filters/effect-sepia-hw-expected.png:
  • platform/chromium-mac/css3/filters/regions-expanding-expected.png:
  • platform/chromium-mac/fast/css/background-shorthand-invalid-url-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/media/mq-min-pixel-ratio-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/reflections/reflection-direction-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/reflections/reflection-masks-expected.png:
  • platform/chromium-mac/fast/reflections/reflection-masks-opacity-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/reflections/reflection-masks-outset-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/threaded: Added.
  • platform/chromium-mac/platform/chromium/virtual/threaded/compositing: Added.
  • platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility: Added.
  • platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-expected.png: Added.
  • platform/chromium-mac/svg/custom/createImageElement-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/custom/createImageElement2-expected.png:
  • platform/chromium-mac/svg/custom/focus-ring-expected.png:
  • platform/chromium-mac/svg/custom/image-parent-translation-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-mac/svg/custom/image-with-transform-clip-filter-expected.png:
  • platform/chromium-mac/svg/custom/js-update-image-and-display-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/custom/js-update-image-and-display2-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/custom/js-update-image-and-display3-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/custom/js-update-image-expected.png:
  • platform/chromium-mac/svg/custom/pointer-events-image-css-transform-expected.png:
  • platform/chromium-mac/svg/custom/pointer-events-image-expected.png:
  • platform/chromium-mac/svg/custom/text-image-opacity-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/chromium-mac/svg/wicd/test-rightsizing-b-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-background-images-expected.png:
  • platform/efl/fast/media/mq-min-pixel-ratio-expected.txt: Removed.
  • platform/efl/fast/reflections/reflection-masks-expected.txt: Removed.
  • platform/efl/fast/reflections/reflection-masks-opacity-expected.txt: Removed.
  • platform/efl/fast/reflections/reflection-masks-outset-expected.png: Removed.
  • platform/efl/fast/reflections/reflection-masks-outset-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.txt: Removed.
  • platform/gtk/fast/media/mq-min-pixel-ratio-expected.txt: Removed.
  • platform/gtk/fast/reflections/reflection-masks-outset-expected.png: Removed.
  • platform/mac-snowleopard/svg/custom/js-update-image-expected.png: Removed.
  • platform/mac-snowleopard/svg/zoom/page/zoom-background-images-expected.png: Removed.
  • platform/mac/fast/media/mq-min-pixel-ratio-expected.txt: Removed.
  • platform/qt/fast/media/mq-min-pixel-ratio-expected.txt: Removed.
  • platform/win/svg/custom/image-with-transform-clip-filter-expected.txt: Removed.
22:31 Changeset [114082] by abarth@webkit.org
  • 5 edits in trunk/Source/WebCore

Prepare window.location for seamless navigation
https://bugs.webkit.org/show_bug.cgi?id=83843

Reviewed by Eric Seidel.

This patch refactors window.location to flow through
FrameLoader::findFrameForNavigation, which is where we're going to
implement the seamless navigation redirect. This patch shouldn't cause
any observable changes in behavior today, but it will make all the
seamless-window-location* tests in
https://github.com/eseidel/webkit/tree/seamless/LayoutTests/fast/frames/seamless
pass once we merge the seamlesss branch. See
https://github.com/eseidel/webkit/commit/a6e708fa6c643b156397e9a287b40a0868c7959c
for context.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::setLocation):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::locationAccessorSetter):

  • page/Location.cpp:

(WebCore::Location::setHref):
(WebCore::Location::setProtocol):
(WebCore::Location::setHost):
(WebCore::Location::setHostname):
(WebCore::Location::setPort):
(WebCore::Location::setPathname):
(WebCore::Location::setSearch):
(WebCore::Location::setHash):
(WebCore::Location::assign):
(WebCore::Location::replace):
(WebCore::Location::setLocation):
(WebCore):

  • page/Location.h:

(Location):

22:28 Changeset [114081] by danakj@chromium.org
  • 17 edits
    10 adds in trunk

[chromium] Background filters for composited layers
https://bugs.webkit.org/show_bug.cgi?id=80046

Reviewed by Adrienne Walker.

Source/WebCore:

Adds background filters to LayerChromium/CCLayerImpl. These filters are
applied to any pixels in the contents behind the layer and seen through
it.

This is done by adding a backgroundTexture() to the render surface, which
holds the read-back contents of the target framebuffer, background filter
applied, in the surface's own coordinate space. Then this is drawn back
into the frame buffer before the contents of the surface itself is drawn.

Tests: platform/chromium/compositing/filters/background-filter-blur-off-axis.html

platform/chromium/compositing/filters/background-filter-blur-outsets.html
platform/chromium/compositing/filters/background-filter-blur.html

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setBackgroundFilters):
(WebCore):
(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):
(WebCore::LayerChromium::backgroundFilters):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawBackgroundFilters):
(WebCore):
(WebCore::LayerRendererChromium::drawRenderSurfaceQuad):
(WebCore::LayerRendererChromium::getFramebufferTexture):
(WebCore::LayerRendererChromium::isCurrentRenderSurface):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::useManagedTexture):
(WebCore::LayerRendererChromium::bindFramebufferToTexture):
(WebCore::LayerRendererChromium::setScissorToRect):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

  • platform/graphics/chromium/RenderSurfaceChromium.h:

(WebCore::RenderSurfaceChromium::setBackgroundFilters):
(WebCore::RenderSurfaceChromium::backgroundFilters):
(RenderSurfaceChromium):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::setBackgroundFilters):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):
(WebCore::CCLayerImpl::backgroundFilters):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::subtreeShouldRenderToSeparateSurface):
(WebCore::calculateDrawTransformsAndVisibilityInternal):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::drawableContentRect):
(WebCore::CCRenderSurface::prepareBackgroundTexture):
(WebCore):
(WebCore::CCRenderSurface::releaseBackgroundTexture):
(WebCore::CCRenderSurface::computeDeviceTransform):
(WebCore::CCRenderSurface::computeDeviceBoundingBox):
(WebCore::CCRenderSurface::computeReadbackDeviceBoundingBox):
(WebCore::CCRenderSurface::readbackDeviceContentRect):
(WebCore::copyTextureToFramebuffer):
(WebCore::CCRenderSurface::copyDeviceToBackgroundTexture):
(WebCore::getSkBitmapTextureId):
(WebCore::CCRenderSurface::drawContents):
(WebCore::CCRenderSurface::drawReplica):
(WebCore::CCRenderSurface::drawLayer):
(WebCore::CCRenderSurface::drawSurface):
(WebCore::CCRenderSurface::applyFilters):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(CCRenderSurface):
(WebCore::CCRenderSurface::setBackgroundFilters):
(WebCore::CCRenderSurface::backgroundFilters):
(WebCore::CCRenderSurface::backgroundTexture):

  • testing/Internals.cpp:

(WebCore):
(WebCore::Internals::setBackgroundBlurOnNode):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit/chromium:

  • tests/CCLayerImplTest.cpp:

(WebCore::TEST):

LayoutTests:

  • platform/chromium/compositing/filters/background-filter-blur-expected.png: Added.
  • platform/chromium/compositing/filters/background-filter-blur-expected.txt: Added.
  • platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Added.
  • platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.txt: Added.
  • platform/chromium/compositing/filters/background-filter-blur-off-axis.html: Added.
  • platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Added.
  • platform/chromium/compositing/filters/background-filter-blur-outsets-expected.txt: Added.
  • platform/chromium/compositing/filters/background-filter-blur-outsets.html: Added.
  • platform/chromium/compositing/filters/background-filter-blur.html: Added.
21:39 Changeset [114080] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

Remove V8DOMWindowShell::setLocation
https://bugs.webkit.org/show_bug.cgi?id=83833

Reviewed by Eric Seidel.

V8DOMWindowShell::setLocation is only used by document.location. It's
more direct for document.location to call Location::setHref directly.
This integrates correctly with the navigation rules for
<iframe seamless>.

(See https://github.com/eseidel/webkit/compare/master...seamless for
more context about the connection with seamless.)

Reviewed on GitHub:
https://github.com/abarth/webkit/commit/48601729d53a6ac39df5a43b22218c91330c3f61

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore):

  • bindings/v8/V8DOMWindowShell.h:

(V8DOMWindowShell):

  • bindings/v8/custom/V8DocumentLocationCustom.cpp:

(WebCore::V8Document::locationAccessorSetter):

21:19 Changeset [114079] by leviw@chromium.org
  • 7 edits in trunk/Source/WebCore

Prepare functions in LengthFunctions.h for LayoutUnits
https://bugs.webkit.org/show_bug.cgi?id=83726

Reviewed by Eric Seidel.

Preparing the functions that live in LengthFunctions for sub-pixel layout, which entails
using and returning LayoutUnits instead of integers. There are a number of rendering
classes that are laid out using integers -- see https://trac.webkit.org/wiki/LayoutUnit
for details -- so this also adds integer-specific versions of the length functions for
explicit use in those classes.

No new tests. No change in behavior.

  • css/LengthFunctions.h:

(WebCore): Using LayoutUnits for sub-pixel precision and adding integer-specific versions
of minimumValueForLength and valueForLength that truncate.

  • css/LengthFunctions.cpp:

(WebCore):

  • dom/Document.cpp:

(WebCore::Document::pageSizeAndMarginsInPixels): Document sizes are integral.

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::layOutAxis): The frame tree continues to be integral.

  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::timerFired): RenderMarquee scrolling uses integral values.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight): Table layout is integral.

20:51 Changeset [114078] by commit-queue@webkit.org
  • 17 edits
    1 copy
    2 moves
    1 add in trunk/Source

Unreviewed, rolling out r114075.
http://trac.webkit.org/changeset/114075
https://bugs.webkit.org/show_bug.cgi?id=83857

Breaks compile (Requested by jamesr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-12

Source/Platform:

  • Platform.gypi:

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawYUV):
(WebCore::LayerRendererChromium::drawRGBA):
(WebCore::LayerRendererChromium::copyFrameToTextures):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/VideoFrameChromium.cpp: Renamed from Source/Platform/chromium/src/WebVideoFrame.cpp.

(WebCore):
(WebCore::VideoFrameChromium::~VideoFrameChromium):

  • platform/graphics/chromium/VideoFrameChromium.h: Copied from Source/Platform/chromium/public/WebVideoFrame.h.

(WebCore):
(VideoFrameChromium):

  • platform/graphics/chromium/VideoFrameProvider.h:

(VideoFrameProvider):

  • platform/graphics/chromium/cc/CCVideoDrawQuad.cpp:

(WebCore::CCVideoDrawQuad::create):
(WebCore::CCVideoDrawQuad::CCVideoDrawQuad):

  • platform/graphics/chromium/cc/CCVideoDrawQuad.h:

(CCVideoDrawQuad):
(WebCore::CCVideoDrawQuad::frame):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore):
(WebCore::convertVFCFormatToGC3DFormat):
(WebCore::CCVideoLayerImpl::willDraw):
(WebCore::CCVideoLayerImpl::computeVisibleSize):
(WebCore::CCVideoLayerImpl::reserveTextures):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebVideoFrame.h:

(WebKit):
(WebVideoFrame):
(WebKit::WebVideoFrame::~WebVideoFrame):
(WebKit::WebVideoFrame::format):
(WebKit::WebVideoFrame::width):
(WebKit::WebVideoFrame::height):
(WebKit::WebVideoFrame::planes):
(WebKit::WebVideoFrame::stride):
(WebKit::WebVideoFrame::data):
(WebKit::WebVideoFrame::textureId):
(WebKit::WebVideoFrame::textureTarget):

  • src/AssertMatchingEnums.cpp:
  • src/VideoFrameChromiumImpl.cpp: Added.

(WebKit):
(WebKit::VideoFrameChromiumImpl::toWebVideoFrame):
(WebKit::VideoFrameChromiumImpl::VideoFrameChromiumImpl):
(WebKit::VideoFrameChromiumImpl::format):
(WebKit::VideoFrameChromiumImpl::width):
(WebKit::VideoFrameChromiumImpl::height):
(WebKit::VideoFrameChromiumImpl::planes):
(WebKit::VideoFrameChromiumImpl::stride):
(WebKit::VideoFrameChromiumImpl::data):
(WebKit::VideoFrameChromiumImpl::requiredTextureSize):
(WebKit::VideoFrameChromiumImpl::hasPaddingBytes):
(WebKit::VideoFrameChromiumImpl::textureId):
(WebKit::VideoFrameChromiumImpl::textureTarget):

  • src/VideoFrameChromiumImpl.h: Renamed from Source/Platform/chromium/public/WebVideoFrame.h.

(WebKit):
(VideoFrameChromiumImpl):

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::putCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::supportsType):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

20:47 Changeset [114077] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Use _self to represnet self-navigation, like in the HTML5 spec
https://bugs.webkit.org/show_bug.cgi?id=83834

Reviewed by Eric Seidel.

This patch aligns the internal state representation of the FrameLoader
more closely with the HTML5 spec. Both the null string and "_self"
represent self-navigation, but the HTML5 spec distinguishes them when
navigating seamless iframes. In that case, "_self" is explicit
self-navigation, whereas a null string will get redirected to the
"master" frame (the closest enclosing non-seamless frame).

This patch shouldn't have any observable behavior changes, but it will
be useful when we merge in the seamless branch from GitHub.
(See https://github.com/eseidel/webkit/commit/df0e71fcacdb0e7e45fe669afe1314cec5b76523
which contains this change.)

Once the seamless branch lands, this change will be tested by a number
of tests in
https://github.com/eseidel/webkit/tree/seamless/LayoutTests/fast/frames/seamless
including seamless-hyperlink.html.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadURLIntoChildFrame):
(WebCore::FrameLoader::loadURL):

20:11 Changeset [114076] by rniwa@webkit.org
  • 3 edits
    1 add in trunk/Tools

Extract PerfTest class from PerfTestRunner
https://bugs.webkit.org/show_bug.cgi?id=83847

Reviewed by Hajime Morita.

Extracted PerfTest and ChromiumStylePerfTest from PerfTestRunner. This class abstracts a test
that was previously represented by a tuple.

Also moved the logic to determine whether a given test is chromium style or not from run() to
_collect_tests(). And moved the output parsing algorithms for parser style and chromium style
tests from PerfTestRunner to PerfTest and ChromiumStylePerfTest respectively so that we may
add new types of tests more easily.

  • Scripts/webkitpy/performance_tests/perftest.py: Added.

(PerfTest):
(PerfTest.init):
(PerfTest.test_name):
(PerfTest.dirname):
(PerfTest.path_or_url):
(PerfTest._should_ignore_line_in_parser_test_result):
(PerfTest.parse_output):
(ChromiumStylePerfTest):
(ChromiumStylePerfTest.init):
(ChromiumStylePerfTest.parse_output):

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._collect_tests):
(PerfTestsRunner.run):
(PerfTestsRunner._run_tests_set):
(PerfTestsRunner._run_single_test):

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(run_test):
(_tests_for_runner):
(test_run_test_set_with_json_output):
(test_run_test_set_with_json_source):
(test_run_test_set_with_multiple_repositories):
(_collect_tests_and_sort_test_name):
(test_collect_tests):
(test_collect_tests_with_skipped_list):

19:52 Changeset [114075] by jamesr@google.com
  • 17 edits
    2 moves
    2 deletes in trunk/Source

[chromium] Move WebVideoFrame into Platform and remove WebCore::VideoFrameChromium wrapper API
https://bugs.webkit.org/show_bug.cgi?id=83851

Reviewed by Adam Barth.

Source/Platform:

Move WebVideoFrame API into Platform.

  • Platform.gypi:
  • chromium/public/WebVideoFrame.h: Renamed from Source/WebCore/platform/graphics/chromium/VideoFrameChromium.h.

(WebKit):
(WebVideoFrame):
(WebKit::WebVideoFrame::~WebVideoFrame):
(WebKit::WebVideoFrame::format):
(WebKit::WebVideoFrame::width):
(WebKit::WebVideoFrame::height):
(WebKit::WebVideoFrame::planes):
(WebKit::WebVideoFrame::stride):
(WebKit::WebVideoFrame::data):
(WebKit::WebVideoFrame::textureId):
(WebKit::WebVideoFrame::textureTarget):

  • chromium/src/WebVideoFrame.cpp: Renamed from Source/WebCore/platform/graphics/chromium/VideoFrameChromium.cpp.

(WebKit):

Source/WebCore:

Remove VideoFrameChromium wrapper and converts WebCore code to using the Platform WebVideoFrame API directly.
Some utility code that previously existed on VideoFrameChromium and only had one caller, such as doing
width/height adjustements for YV12 frames, is moved into the calling code (CCVideoLayerImpl).

Covered by existing media/ and compositing/ layout tests.

  • WebCore.gypi:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawYUV):
(WebCore::LayerRendererChromium::drawRGBA):
(WebCore::LayerRendererChromium::copyFrameToTextures):

  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/VideoFrameProvider.h:

(VideoFrameProvider):

  • platform/graphics/chromium/cc/CCVideoDrawQuad.cpp:

(WebCore::CCVideoDrawQuad::create):
(WebCore::CCVideoDrawQuad::CCVideoDrawQuad):

  • platform/graphics/chromium/cc/CCVideoDrawQuad.h:

(WebKit):
(CCVideoDrawQuad):
(WebCore::CCVideoDrawQuad::frame):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore):
(WebCore::convertVFCFormatToGC3DFormat):
(WebCore::CCVideoLayerImpl::willDraw):
(WebCore::videoFrameDimension):
(WebCore::hasPaddingBytes):
(WebCore::CCVideoLayerImpl::computeVisibleSize):
(WebCore::CCVideoLayerImpl::reserveTextures):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:

(WebKit):

Source/WebKit/chromium:

Moves the WebVideoFrame interface into Platform and removes the now unnecessary VideoFrameChromiumImpl adapter
implementation.

  • WebKit.gyp:
  • public/WebVideoFrame.h:
  • src/AssertMatchingEnums.cpp:
  • src/VideoFrameChromiumImpl.cpp: Removed.
  • src/VideoFrameChromiumImpl.h: Removed.
  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::putCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::supportsType):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

19:51 Changeset [114074] by ap@apple.com
  • 8 edits in trunk

REGRESSION (r113900): Text tests started failing
https://bugs.webkit.org/show_bug.cgi?id=83724

Reviewed by Dan Bernstein.

Source/WebCore:

  • Resources/DefaultFonts.plist.in: Use serif fonts for standard family again,

and updated the list with better fonts for Japanese.

LayoutTests:

  • platform/mac/Skipped: unskip the tests.
  • platform/mac/fast/ruby/nested-ruby-expected.png:
  • platform/mac/fast/ruby/nested-ruby-expected.txt:
  • platform/mac/fast/text/international/002-expected.png:
  • platform/mac/fast/text/international/002-expected.txt:

Updated for minor rendering differences.

19:49 Changeset [114073] by dimich@chromium.org
  • 4 edits in branches/chromium/1025/Source/WebCore

Merge 113132 - [Chromium] Out-of-process font loading garbles text
https://bugs.webkit.org/show_bug.cgi?id=83002

Reviewed by Kent Tamura.

Initialize m_CTFont by using m_cgFont in FontPlatformData when we use
out-of-process font loading.

No new tests. This problem only occurs when the user uses a third party
font management software like Font Explorer so it is difficult to add
tests.

  • platform/graphics/chromium/CrossProcessFontLoading.mm:

(WebCore):
(WebCore::FontPlatformData::loadFont): If font loading fails, set null to outNSFont so that the FontPlatformData won't be used.

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::ctFont): Modified to return the appropriate NSFont object when the font from the browser process.

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::createFontPlatformData): Returns null when the generated FontPlatformData object doesn't have NSFont object.

TBR=bashi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10072004

19:30 Changeset [114072] by benjamin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Improve replaceUsingStringSearch() for case of a single character searchValue
https://bugs.webkit.org/show_bug.cgi?id=83738

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-12
Reviewed by Geoffrey Garen.

This patch improves replaceUsingStringSearch() with the following:
-Add a special case for single character search, taking advantage of the faster WTF::find().
-Inline replaceUsingStringSearch().
-Use StringImpl::create() instead of UString::substringSharingImpl() since we know we are in the bounds

by definition.

This gives less than 1% improvement for the multicharacter replace.
The single character search show about 9% improvement.

  • runtime/StringPrototype.cpp:

(JSC::replaceUsingStringSearch):

19:25 Changeset [114071] by benjamin@webkit.org
  • 4 edits in trunk/Source/WTF

Inline StringImpl::find(UChar, ...)
https://bugs.webkit.org/show_bug.cgi?id=83737

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-12
Reviewed by Geoffrey Garen.

The implementation of StringImpl::find() is a simple branch before invoking one of
two inline functions. The overhead of having a function for StringImpl::find() is significant.

It is better to let the compiler decide if that should be inlined or not.

  • wtf/text/StringImpl.cpp:
  • wtf/text/StringImpl.h:

(StringImpl):
(WTF::find):
(WTF):
(WTF::reverseFind):
(WTF::StringImpl::find):

  • wtf/text/WTFString.h:
19:12 Changeset [114070] by lforschler@apple.com
  • 4 edits in trunk/Source

Versioning.

18:54 Changeset [114069] by ap@apple.com
  • 4 edits in trunk/Source

Preprocessing text files with modern clang treats double slashes in comments
https://bugs.webkit.org/show_bug.cgi?id=83827

Reviewed by Mark Rowe.

Source/WebCore:

  • DerivedSources.make: Pass appropriate flags to both llvm and gcc.

Source/WebKit2:

  • DerivedSources.make: Pass appropriate flags to both llvm and gcc.
18:36 Changeset [114068] by lforschler@apple.com
  • 4 edits in branches/safari-534.57-branch/Source/WebCore

Merged r113415.

18:32 Changeset [114067] by commit-queue@webkit.org
  • 23 edits
    4 copies
    7 adds in trunk

Add Encrypted Media Extensions events and errors to HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=82974

Patch by David Dorwin <ddorwin@chromium.org> on 2012-04-12
Reviewed by Adam Barth.

The new events and errors are behind the ENABLE(ENCRYPTED_MEDIA) feature define.
Implementation is based on v0.1 of the draft proposal at
http://dvcs.w3.org/hg/html-media/raw-file/tip/encrypted-media/encrypted-media.html#events.

Source/WebCore:

Tests: fast/events/constructors/media-key-event-constructor.html

media/encrypted-media/encrypted-media-constants.html
media/encrypted-media/encrypted-media-events.html

  • WebCore.gypi:
  • bindings/v8/Dictionary.cpp:

(WebCore::Dictionary::get):
(WebCore):

  • bindings/v8/Dictionary.h:

(WebCore):
(Dictionary):

  • dom/EventNames.h:

(WebCore):

  • dom/EventNames.in:
  • html/HTMLAttributeNames.in:
  • html/HTMLMediaElement.cpp:

(WebCore):
(WebCore::HTMLMediaElement::mediaPlayerKeyAdded):
(WebCore::HTMLMediaElement::mediaPlayerKeyError):
(WebCore::HTMLMediaElement::mediaPlayerKeyMessage):
(WebCore::HTMLMediaElement::mediaPlayerKeyNeeded):

  • html/HTMLMediaElement.h:

(HTMLMediaElement):

  • html/HTMLMediaElement.idl:
  • html/MediaError.h:
  • html/MediaError.idl:
  • html/MediaKeyError.h: Added.

(WebCore):
(MediaKeyError):
(WebCore::MediaKeyError::create):
(WebCore::MediaKeyError::code):
(WebCore::MediaKeyError::MediaKeyError):

  • html/MediaKeyError.idl: Added.
  • html/MediaKeyEvent.cpp: Added.

(WebCore):
(WebCore::MediaKeyEventInit::MediaKeyEventInit):
(WebCore::MediaKeyEvent::MediaKeyEvent):
(WebCore::MediaKeyEvent::~MediaKeyEvent):
(WebCore::MediaKeyEvent::interfaceName):

  • html/MediaKeyEvent.h: Added.

(WebCore):
(MediaKeyEventInit):
(MediaKeyEvent):
(WebCore::MediaKeyEvent::create):
(WebCore::MediaKeyEvent::keySystem):
(WebCore::MediaKeyEvent::sessionId):
(WebCore::MediaKeyEvent::initData):
(WebCore::MediaKeyEvent::message):
(WebCore::MediaKeyEvent::defaultURL):
(WebCore::MediaKeyEvent::errorCode):
(WebCore::MediaKeyEvent::systemCode):

  • html/MediaKeyEvent.idl: Added.
  • page/DOMWindow.idl:
  • platform/graphics/MediaPlayer.cpp:

(WebCore):
(WebCore::MediaPlayer::keyAdded):
(WebCore::MediaPlayer::keyError):
(WebCore::MediaPlayer::keyMessage):
(WebCore::MediaPlayer::keyNeeded):

  • platform/graphics/MediaPlayer.h:

(MediaPlayerClient):
(WebCore::MediaPlayerClient::mediaPlayerKeyAdded):
(WebCore::MediaPlayerClient::mediaPlayerKeyError):
(WebCore::MediaPlayerClient::mediaPlayerKeyMessage):
(WebCore::MediaPlayerClient::mediaPlayerKeyNeeded):
(MediaPlayer):

Source/WebKit/chromium:

  • public/WebMediaPlayerClient.h:
  • src/AssertMatchingEnums.cpp:
  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::keyAdded):
(WebKit):
(WebKit::WebMediaPlayerClientImpl::keyError):
(WebKit::WebMediaPlayerClientImpl::keyMessage):
(WebKit::WebMediaPlayerClientImpl::keyNeeded):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

LayoutTests:

  • fast/events/constructors/media-key-event-constructor-expected.txt: Added.
  • fast/events/constructors/media-key-event-constructor.html: Added.
  • fast/js/resources/js-test-pre.js:

(shouldBeZero):
(shouldBeEmptyString):

  • media/encrypted-media/encrypted-media-constants-expected.txt: Added.
  • media/encrypted-media/encrypted-media-constants.html: Added.
  • media/encrypted-media/encrypted-media-events-expected.txt: Added.
  • media/encrypted-media/encrypted-media-events.html: Added.
  • media/video-test.js:

(testExpected):
(testArraysEqual):

18:29 Changeset [114066] by eae@chromium.org
  • 3 edits in branches/subpixellayout/Source/WebCore

Add size_t versions of multiplication and division operators to FractionalLayoutUnit and remove unneeded casts.

18:26 Changeset [114065] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Reset the user preferred language overrides in Internals::reset
https://bugs.webkit.org/show_bug.cgi?id=83845

Reviewed by Ryosuke Niwa.

We don't want setting the language override in one test to affect subsequent tests,
so make sure to reset it in Internals::reset.

  • testing/Internals.cpp:

(WebCore::Internals::reset):

18:11 Changeset [114064] by commit-queue@webkit.org
  • 9 edits in trunk/LayoutTests

Make layout tests not access apache on localhost:80
https://bugs.webkit.org/show_bug.cgi?id=82197

Patch by Pablo Flouret <pablof@motorola.com> on 2012-04-12
Reviewed by Ryosuke Niwa.

It pollutes the logs of people running a local webserver, and has the
potential for changing the results of tests run locally.

  • fast/dom/onerror-img.html:
  • fast/js/custom-constructors-expected.txt:
  • fast/js/script-tests/custom-constructors.js:
  • fast/notifications/notifications-double-show.html:
  • fast/notifications/notifications-with-permission.html:
  • fast/notifications/notifications-without-permission.html:
18:08 Changeset [114063] by caseq@chromium.org
  • 3 edits in trunk/Source/WebCore

[chromium][refactoring] merge CCSingleThreadProxy::{commitIfNeeded,doComposite} into commitAndComposite()
https://bugs.webkit.org/show_bug.cgi?id=83837

Reviewed by James Robinson.

  • merge CCSingleThreadProxy::commitIfNeeded() and CCSingleThreadProxy::doComposite() into commitAndComposite()
  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::compositeAndReadback): call site updated.
(WebCore::CCSingleThreadProxy::compositeImmediately): ditto.
(WebCore::CCSingleThreadProxy::commitAndComposite):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:
18:07 Changeset [114062] by japhet@chromium.org
  • 5 edits in trunk/Source/WebCore

Remove FrameLoader:m_isLoadingMainResource, since it is always
false at the only point it is checked.
https://bugs.webkit.org/show_bug.cgi?id=83819

Reviewed by Adam Barth.

No new tests, no functionality change intended.

  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::end): Merge with endIfNotLoadingMainResource(), always end, assert that we're still attached.

  • loader/DocumentWriter.h:
  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h: Remove isLoadingMainResource(), didEndDocument(), and m_isLoadingMainResource.
18:03 Changeset [114061] by lforschler@apple.com
  • 4 edits in branches/safari-534.57-branch/WebKitLibraries

Merged r113649.

18:01 Changeset [114060] by lforschler@apple.com
  • 2 edits in branches/safari-534.57-branch/Source/WebCore

Merged r113528.

17:58 Changeset [114059] by rwlbuis@webkit.org
  • 15 edits
    2 adds in trunk

XMLSerializer().serializeToString() doesn't generate the XML declaration markup like Opera and Firefox
https://bugs.webkit.org/show_bug.cgi?id=83432

Reviewed by Ryosuke Niwa.

Source/WebCore:

Serialize the xml declaration exactly as parsed, if present in the document.

Test: fast/dom/dom-parse-serialize-xmldecl.html

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::setXMLStandalone): update xmlStandalone to either yes or no.

  • dom/Document.h:

(WebCore::Document::xmlStandalone):
(WebCore::Document::xmlStandaloneStatus): xmlStandalone can be unspecified, yes or no.
(WebCore::Document::hasXMLDeclaration): test if xml declaration is present.
(WebCore::Document::setHasXMLDeclaration):
(Document):

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendXMLDeclaration): write xml declaration if present.
(WebCore):
(WebCore::MarkupAccumulator::appendStartMarkup):

  • editing/MarkupAccumulator.h:

(MarkupAccumulator):

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::startDocument): call setHasXmlDeclaration and any declaration strings parsed.

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::startDocument): call setHasXmlDeclaration and any declaration strings parsed.

LayoutTests:

Verify that xml declaration gets serialized if present. The updated test results are improvements.

  • fast/dom/dom-parse-serialize-display-expected.txt:
  • fast/dom/dom-parse-serialize-expected.txt:
  • fast/dom/dom-parse-serialize-xmldecl-expected.txt: Added.
  • fast/dom/dom-parse-serialize-xmldecl.html: Added.
  • fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
  • fast/xsl/xslt-processor-expected.txt:
  • http/tests/xmlhttprequest/xml-encoding-expected.txt:
  • platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
  • platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
17:52 Changeset [114058] by lforschler@apple.com
  • 7 edits in branches/safari-534.57-branch

Merged r112023.

17:42 Changeset [114057] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

window.open should prepare for seamless navigation by using findFrameForNavigation
https://bugs.webkit.org/show_bug.cgi?id=83835

Reviewed by Ryosuke Niwa.

Before this patch, window.open called FrameTree::find and
Document::canNavigate separately. This patch refactors the code to
call FrameLoader::findFrameForNavigation, which does both. This
refactoring prepares window.open to understand seamless navigation,
which will happen in findFrameForNavigation.

This patch should have no behavior change today, but once we merge the
seamless branch, this change will be tested by
https://github.com/eseidel/webkit/blob/seamless/LayoutTests/fast/frames/seamless/seamless-window-open.html

See https://github.com/eseidel/webkit/commit/a0d8b7defbb63047912aefbc8e22bca4f0638c37 for context.

  • WebCore.exp.in:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::findFrameForNavigation):
(WebCore::createWindow):

  • loader/FrameLoader.h:

(FrameLoader):

17:26 Changeset [114056] by commit-queue@webkit.org
  • 9 edits in trunk/LayoutTests

Convert layout test resource PNGs to sRGB. Some tests, such as
compositing/color-matching/image-color-matching.html, expect that
images with an RGB profile will not be altered when displayed. However,
some of the resources have RGB profiles that are different from sRGB
and actually should change when displayed with color profile support.

https://bugs.webkit.org/show_bug.cgi?id=83799

Patch by Tony Payne <tpayne@chromium.org> on 2012-04-12
Reviewed by Adam Barth.

  • compositing/resources/thiswayup.png:
  • css3/filters/resources/reference.png:
  • fast/media/resources/apple_logo_half_size.png:
  • fast/reflections/resources/kate.png:
  • svg/as-border-image/resources/large-tiles.png:
  • svg/custom/resources/green-checker.png:
  • svg/custom/resources/red-checker.png:
  • svg/wicd/resources/test-svg-child-object-rightsizing.png:
17:24 Changeset [114055] by lforschler@apple.com
  • 2 edits in branches/safari-534.57-branch/Source/WebCore

Merged r111977.

17:20 Changeset [114054] by lforschler@apple.com
  • 2 edits in branches/safari-534.57-branch/Source/WebCore

Merged r111108.

17:15 Changeset [114053] by lforschler@apple.com
  • 2 edits in branches/safari-534.57-branch/Source/WebCore

Merged r110150.

17:09 Changeset [114052] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

StructureStubInfo::reset() causes leaks of PolymorphicAccessStructureList and ExecutableMemoryHandle objects
https://bugs.webkit.org/show_bug.cgi?id=83823

Reviewed by Gavin Barraclough.

Put the clearing of the accessType to after the call to deref() so that
deref() can use the accessType to delete referenced objects as needed.

  • bytecode/StructureStubInfo.h:

(JSC::StructureStubInfo::reset):

17:08 Changeset [114051] by lforschler@apple.com
  • 1 copy in tags/Safari-536.7

New Tag.

17:05 Changeset [114050] by lforschler@apple.com
  • 2 edits in branches/safari-534.57-branch/Source/WebCore

Merged r110139.

17:03 Changeset [114049] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Marking fast/regions/region-overflow-break.html as image failure on Mac.

  • platform/chromium/test_expectations.txt:
16:58 Changeset [114048] by aestes@apple.com
  • 8 edits in trunk/Source

REGRESSION (r102262): iAd Producer relies on CSSStyleDeclaration property setters respecting '!important'
https://bugs.webkit.org/show_bug.cgi?id=83832

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Shipping versions of iAd Producer rely on the pre-r102262 behavior of
respecting '!important' when specified in a CSSStyleDeclaration
property setter. Restore this quirky behavior for versions of the app
that expect it.

  • WebCore.exp.in: Export

Settings::setShouldRespectPriorityInCSSAttributeSetters().

  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::JSCSSStyleDeclaration::putDelegate): If
setShouldRespectPriorityInCSSAttributeSetters() is true, restore the
pre-r102262 behavior wherein we attempt to parse '!important' out of
the property value.

  • page/Settings.cpp:

(WebCore::Settings::setShouldRespectPriorityInCSSAttributeSetters):
(WebCore::Settings::shouldRespectPriorityInCSSAttributeSetters):

  • page/Settings.h:

Source/WebKit/mac:

  • Misc/WebKitVersionChecks.h: Indicate that 535.13.0 was the first

version of WebKit.framework to ignore '!important' in
CSSStyleDeclaration property setters.

  • WebView/WebView.mm:

(shouldRespectPriorityInCSSAttributeSetters):
(-[WebView _commonInitializationWithFrameName:groupName:]): Enable a
quirk to restore pre-r102262 behavior if the application is iAd Producer
and was linked against a version of WebKit.framework that had the old behavior.

16:58 Changeset [114047] by lforschler@apple.com
  • 5 edits
    4 copies in branches/safari-534.57-branch

Merged r109480.

16:55 Changeset [114046] by achicu@adobe.com
  • 4 edits
    2 adds in trunk

REGRESSION(112745) [CSS Filters] Memory use explosion for offscreen filtered elements
https://bugs.webkit.org/show_bug.cgi?id=83815

Reviewed by Simon Fraser.

Source/WebCore:

The filtered area used to be the dirty rect intersected by the bounding box of the
layer. During a previous change that behavior was lost, so adding it back now.

Also, removing the memory buffers used to compute filters after the filter is computed.
They are deleted next time the filter is applied anyway, so there's no need to keep the
memory for them.

Test: css3/filters/offscreen-filters-memory-usage.html

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::prepare):
(WebCore):
(WebCore::FilterEffectRenderer::clearIntermediateResults):
(WebCore::FilterEffectRendererHelper::prepareFilterEffect):
(WebCore::FilterEffectRendererHelper::applyFilterEffect):

  • rendering/FilterEffectRenderer.h:

(FilterEffectRenderer):

LayoutTests:

Adding a test that creates a lot of layers outside the viewport. The memory should not grow
and the browser should not crash.

  • css3/filters/offscreen-filters-memory-usage-expected.txt: Added.
  • css3/filters/offscreen-filters-memory-usage.html: Added.
16:10 Changeset [114045] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WinCairo] Build fix after Windows export definition file change.

  • win/WebKit2CFLite.def: This file needs to be kept in sync with

WebKit2.def (aside from the WebKitInterface exports.)

16:08 Changeset [114044] by bfulgham@webkit.org
  • 3 edits in trunk/Source/WebCore

[WinCairo] Build fix after addition of openTypeTable.

  • platform/graphics/FontPlatformData.h:

(FontPlatformData): The openTypeTable declaration is needed
for WinCairo as well.

  • platform/graphics/win/FontPlatformDataWin.cpp:

(WebCore):
(WebCore::FontPlatformData::openTypeTable): The implementation
of openTypeTable is needed for non-CG builds.

16:00 Changeset [114043] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

Image failures due to text rendering change.
Bug filed and test flagged failing.
https://bugs.webkit.org/show_bug.cgi?id=83826

Unreviewed.

  • platform/chromium/test_expectations.txt:
15:28 Changeset [114042] by kbalazs@webkit.org
  • 31 edits in trunk

[Qt] Fix WebKit1 build with V8
https://bugs.webkit.org/show_bug.cgi?id=83322

Reviewed by Adam Barth.

Source/JavaScriptCore:

  • yarr/yarr.pri:

Source/WebCore:

Make it possible to build WebKit1 with v8.
WebKit2 is not covered yet so it need to be disabled.
To build webkit with --v8 one need a qtjsbackend with
an up-to-date copy of v8. Thanks to Peter Varga such
a public repository is available on gitorious:
https://qt.gitorious.org/~stampho/qt/stamphos-qtjsbackend.

This patch contains some build fix with !ENABLE(INSPECTOR)
from it's previous version. These are not necessary now
but I kept them because they makes sense.

No change in behaviour so no new tests.

  • DerivedSources.pri:
  • Target.pri:
  • WebCore.pri:
  • bindings/v8/ScriptController.cpp:
  • bindings/v8/ScriptControllerQt.cpp:
  • bindings/v8/ScriptProfiler.cpp:

(WebCore::retainedDOMInfo):
(WebCore::ScriptProfiler::initialize):

  • bindings/v8/ScriptState.cpp:

(WebCore::evalEnabled):
(WebCore::setEvalEnabled):

  • bindings/v8/V8Binding.cpp:

(WebCore):

  • bindings/v8/V8Binding.h:

(V8BindingPerIsolateData):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initContextIfNeeded):

  • bindings/v8/V8GCForContextDispose.cpp:

(WebCore::V8GCForContextDispose::pseudoIdleTimerFired):

  • bindings/v8/custom/V8InjectedScriptManager.cpp:
  • config.h:
  • editing/TextIterator.cpp:
  • html/MediaFragmentURIParser.cpp:
  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
  • platform/qt/PlatformSupportQt.cpp:

(WebCore::PlatformSupport::popupsAllowed):

Source/WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::didCreateScriptContext):

  • WebCoreSupport/FrameLoaderClientQt.h:

(FrameLoaderClientQt):
(WebCore::FrameLoaderClientQt::allowScriptExtension):

  • WebCoreSupport/InitWebCoreQt.cpp:

Source/WTF:

  • wtf/StdLibExtras.h:

(WTF):

Tools:

  • DumpRenderTree/qt/DumpRenderTree.pro:
  • qmake/mkspecs/features/default_post.prf:
  • qmake/mkspecs/features/default_pre.prf:
  • qmake/mkspecs/features/features.prf:
15:19 Changeset [114041] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

IndexedDB: Refactor cursor iteration to remove duplicate code
https://bugs.webkit.org/show_bug.cgi?id=83302

Patch by Alec Flett <alecflett@chromium.org> on 2012-04-12
Reviewed by Ojan Vafai.

No new tests, no behavior changes.

  • Modules/indexeddb/IDBBackingStore.h:

(Cursor):

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore):

14:54 Changeset [114040] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

More rebaselining.

  • platform/mac/fast/dom/Window/window-properties-expected.txt:
14:39 Changeset [114039] by barraclough@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=83821
Move dfg repatching properties of structure stub info into a union

Reviewed by Oliver Hunt.

We want to be able to have similar properties for the baseline JIT, some restructuring to prepare for this.

  • bytecode/StructureStubInfo.h:

(StructureStubInfo):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • dfg/DFGRepatch.cpp:

(JSC::DFG::dfgRepatchByIdSelfAccess):
(JSC::DFG::linkRestoreScratch):
(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::tryBuildGetByIDProtoList):
(JSC::DFG::emitPutReplaceStub):
(JSC::DFG::emitPutTransitionStub):
(JSC::DFG::tryCachePutByID):
(JSC::DFG::tryBuildPutByIdList):
(JSC::DFG::dfgResetGetByID):
(JSC::DFG::dfgResetPutByID):

14:38 Changeset [114038] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Delete a bunch of unused, copy & pasted values in JIT.h
https://bugs.webkit.org/show_bug.cgi?id=83822

Reviewed by Oliver Hunt.

The only architecture we support the JSVALUE64 JIT on is x86-64, all the patch offsets for other architectures are just nonsense.

  • jit/JIT.h:

(JIT):

14:19 Changeset [114037] by schenney@chromium.org
  • 7 edits
    3 adds in trunk/LayoutTests

[Chromium] Flaky svg/W3C-SVG-1.1/filters-conv-01-f.svg
https://bugs.webkit.org/show_bug.cgi?id=83820

Unreviewed Chromium test expectations.

  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
  • platform/chromium/test_expectations.txt:
14:15 Changeset [114036] by arv@chromium.org
  • 39 edits
    4 copies
    3 adds in trunk

Add support for [ArrayClass] and use that on NodeList
https://bugs.webkit.org/show_bug.cgi?id=

Reviewed by Adam Barth.

Attempt to reland r113931. Now with more updated test expectations.

With this patch NodeLists now have Array.prototype on their prototype chain which allows
methods such as forEach and map to work on NodeLists.

http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#interface-nodelist

For V8 we need to set a flag on the WrapperTypeInfo since V8 uses FunctionTemplates which
does not allow setting the prototype to a non FunctionTemplate so the prototype is therefore
set when the constructor is created.

For JSC we just pass the right prototype object when creating the NodeList prototype. JSC has
a bug (81588) that prevents toString to work as specced on Array.prototype.toString. This
causes test failures in the tests until that has been fixed.

Source/WebCore:

Test: fast/dom/NodeList/node-list-array-class.html

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader): Include ArrayPrototype.h if an ArrayClass.
(GenerateImplementation): If ArrayClass use arrayPrototype as prototype.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNamedConstructorCallback):
(GenerateImplementation): Adds a flag to the WrapperTypeInfo.

  • bindings/scripts/IDLAttributes.txt:: Adds new attribute: ArrayClass.
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::createPrototype):

  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore):

  • bindings/v8/NPV8Object.cpp:

(WebCore::npObjectTypeInfo):

  • bindings/v8/V8BindingPerContextData.cpp:

(WebCore::V8BindingPerContextData::init): Get the array prototype too.
(WebCore::V8BindingPerContextData::createWrapperFromCacheSlowCase):
(WebCore::V8BindingPerContextData::constructorForTypeSlowCase): If this is an ArrayClass we need to
set the [[Prototype]].

  • bindings/v8/V8BindingPerContextData.h:

(V8BindingPerContextData):

  • bindings/v8/V8HiddenPropertyName.h:

(WebCore):

  • bindings/v8/WrapperTypeInfo.h:

(WrapperTypeInfo):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore):

  • dom/NodeList.idl:

LayoutTests:

  • fast/dom/HTMLSelectElement/named-options-expected.txt:
  • fast/dom/HTMLSelectElement/script-tests/named-options.js:
  • fast/dom/NodeList/node-list-array-class-expected.txt: Added.
  • fast/dom/NodeList/node-list-array-class.html: Added.
  • fast/dom/NodeList/nodelist-item-call-as-function-expected.txt:
  • fast/dom/everything-to-string-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/js/recursion-limit-equal-expected.txt:
  • inspector/console/command-line-api-expected.txt:
  • inspector/console/console-dir-expected.txt:
  • inspector/console/console-format-collections-expected.txt:
  • jquery/traversing-expected.txt:
  • platform/chromium/fast/dom/HTMLSelectElement/named-options-expected.txt: Copied from LayoutTests/fast/dom/HTMLSelectElement/named-options-expected.txt.
  • platform/chromium/fast/dom/everything-to-string-expected.txt: Copied from LayoutTests/fast/dom/everything-to-string-expected.txt.
  • platform/chromium/inspector/console/command-line-api-expected.txt: Copied from LayoutTests/inspector/console/command-line-api-expected.txt.
  • platform/chromium/inspector/console/console-dir-expected.txt:
  • platform/chromium/inspector/console/console-format-collections-expected.txt:
  • platform/chromium/jquery/traversing-expected.txt: Copied from LayoutTests/jquery/traversing-expected.txt.
  • platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
14:14 Changeset [114035] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Web Inspector cookie expiry is showing the wrong date.
https://bugs.webkit.org/show_bug.cgi?id=83814

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-04-12
Reviewed by Rob Buis.

The internal representation for expiry is seconds, we need to convert it
to milliseconds by multiplying by 1000.

The value from this method doesn't get used anywhere except Web Inspector.
Manually tested with Web Inspector by examining the CookieItemView in the Resources Panel.

  • platform/blackberry/ParsedCookie.cpp:

(WebCore::ParsedCookie::appendWebCoreCookie):

14:11 Changeset [114034] by adamk@chromium.org
  • 13 edits in trunk/Source/WebCore

Always set V8 wrappers via V8DOMWrapper::setJSWrapperFor* instead of WeakReferenceMap::set()
https://bugs.webkit.org/show_bug.cgi?id=82256

Reviewed by Kentaro Hara.

This is an attempt to reland r112318, which was rolled out due to suspicion of OOM issues.

I've landed the refactoring bits of r112318 as separate changes,
so that this patch contains only the change in which map setter is called.

Binding tests have been updated with new output.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateToV8Converters): Call appropriate V8DOMWrapper::setJSWrapperFor*
to set up wrapper mapping and remove call to leakRef() which is handled
in V8DOMWrapper.

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::V8Float64Array::wrapSlow):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::wrapSlow):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::wrapSlow):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::wrapSlow):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::V8TestEventTarget::wrapSlow):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::wrapSlow):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::wrapSlow):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::wrapSlow):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::wrapSlow):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::wrapSlow):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):

14:09 Changeset [114033] by schenney@chromium.org
  • 3 edits
    5 adds
    1 delete in trunk/LayoutTests

chromium windows + linux svg tests failing after r65665
https://bugs.webkit.org/show_bug.cgi?id=44278

Unreviewed Chromium test expectations update.

Looks like a result of the Skia switch plus some font adjustments.

  • platform/chromium-linux/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
  • platform/chromium-linux/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/transforms/text-with-mask-with-svg-transform-expected.png:
  • platform/chromium-mac-snowleopard/svg/transforms/text-with-mask-with-svg-transform-expected.png: Removed.
  • platform/chromium-mac/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
  • platform/chromium-win/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
  • platform/chromium-win/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
14:06 Changeset [114032] by hyatt@apple.com
  • 8 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=83817

This patch modifies RenderText so that it scans all of its characters up front to
determine whether or not the simple code path can be used for measurement/rendering
of the text for the whole run.

TextRun now has an additional field that indicates that the character scan is not
required, since the entire RenderText is known to be simple. This boolean is set
when constructing the TextRun from the places that make TextRuns from RenderTexts.

The character scan has been refactored into a static Font method so that it can be
called by RenderText. The scan of individual TextRuns is also done using the same method
so that the code is shared.

Reviewed by Dan Bernstein.

  • platform/graphics/Font.cpp:

(WebCore::Font::codePath):
(WebCore::Font::characterRangeCodePath):

  • platform/graphics/Font.h:
  • platform/graphics/TextRun.h:

(WebCore::TextRun::TextRun):
(WebCore::TextRun::characterScanForCodePath):
(WebCore::TextRun::setCharacterScanForCodePath):
(TextRun):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::constructTextRun):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::textWidth):

  • rendering/RenderText.cpp:

(WebCore::RenderText::RenderText):
(WebCore::RenderText::widthFromCache):
(WebCore::RenderText::setTextInternal):
(WebCore::RenderText::width):
(WebCore::RenderText::computeCanUseSimpleFontCodePath):
(WebCore):

  • rendering/RenderText.h:

(RenderText):
(WebCore::RenderText::canUseSimpleFontCodePath):

13:56 Changeset [114031] by leviw@chromium.org
  • 15 edits in trunk/Source/WebCore

Make AccessibilityObject::size non-virtual and fix platform accessibility code's LayoutUnit usage
https://bugs.webkit.org/show_bug.cgi?id=83803

Reviewed by Eric Seidel.

AccessibilityObject::size was virtual with a number of overloads, but all the implementations were
redundant. Avoiding the virtual thunk and code duplication by declaring it non-virtual and only
implementing it in AccessibilityObject.

Also adding a pixelSnappedSize method that returns an IntSize, and using it in platform
accessibility code.

No new tests. No change in behavior.

  • accessibility/AccessibilityMenuListOption.h:

(WebCore::AccessibilityMenuListOption::canHaveChildren):

  • accessibility/AccessibilityMenuListPopup.h:

(WebCore::AccessibilityMenuListPopup::elementRect):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::size):
(WebCore::AccessibilityObject::pixelSnappedSize):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

  • accessibility/AccessibilitySlider.cpp:

(WebCore):

  • accessibility/AccessibilitySlider.h:

(AccessibilitySliderThumb):

  • accessibility/AccessibilityTableColumn.cpp:

(WebCore):

  • accessibility/AccessibilityTableColumn.h:

(AccessibilityTableColumn):

  • accessibility/AccessibilityTableHeaderContainer.cpp:

(WebCore):

  • accessibility/AccessibilityTableHeaderContainer.h:

(AccessibilityTableHeaderContainer):

  • accessibility/gtk/WebKitAccessibleInterfaceComponent.cpp:

(webkitAccessibleComponentGetExtents):

  • accessibility/gtk/WebKitAccessibleInterfaceImage.cpp:

(webkitAccessibleImageGetImagePosition):
(webkitAccessibleImageGetImageSize):

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper position]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

13:55 Changeset [114030] by schenney@chromium.org
  • 4 edits
    4 adds
    1 delete in trunk/LayoutTests

some clip paths broken on chromium win/linux after r65729
https://bugs.webkit.org/show_bug.cgi?id=44341

Unreviewed Chromium expectations update.

These tests are now matching the mac results, and the new results on
the bots look correct. Some changes are just font metric changes.

  • platform/chromium-linux/svg/clip-path/clip-path-childs-clipped-expected.png:
  • platform/chromium-linux/svg/clip-path/clip-path-pixelation-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/clip-path/clip-path-childs-clipped-expected.png: Removed.
  • platform/chromium-mac/svg/clip-path/clip-path-childs-clipped-expected.png: Added.
  • platform/chromium-win/svg/clip-path/clip-path-childs-clipped-expected.png:
  • platform/chromium-win/svg/clip-path/clip-path-pixelation-expected.png: Added.
  • platform/chromium-win/svg/clip-path/clip-path-pixelation-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
13:42 Changeset [114029] by leviw@chromium.org
  • 13 edits in branches/subpixellayout/Source/WebCore/accessibility

Remove unnecessary virtual designation for AccessibilityObject::size, add pixelSnappedSize, and use it in platform code.

13:35 Changeset [114028] by jer.noble@apple.com
  • 2 edits in trunk/Source/WTF

ThreadingWin: Mutex::unlock() can be "over-unlocked".
https://bugs.webkit.org/show_bug.cgi?id=83725

Reviewed by David Levin.

In order to support the behavior of pthread_mutex_trylock(), the Windows Mutex class includes
a recursion counter which is incremented in Mutex::lock(), decremented in Mutex::unlock(),
and checked in Mutex::tryLock(). If the mutex is "over-unlocked", the counter wraps around to
MAX_INT, and subsequent calls to Mutex::trylock() will fail. Raise an ASSERT in this situation
so the "over-unlock" will be caught.

  • wtf/ThreadingWin.cpp:

(WTF::Mutex::unlock): ASSERT if unlocking a non-locked mutex.

13:31 Changeset [114027] by schenney@chromium.org
  • 3 edits
    4 adds in trunk/LayoutTests

[Chromium] filters/feDisplacementMap.svg crossHatch pattern improperly drawn
https://bugs.webkit.org/show_bug.cgi?id=83810

Unreviewed Chromium expectations update.

These test results match Firefox, and I see no reason to believe they
are incorrect.

  • platform/chromium-linux-x86/svg/filters/feDisplacementMap-expected.png: Added.
  • platform/chromium-linux/svg/filters/feDisplacementMap-expected.png: Added.
  • platform/chromium-win-vista/svg/filters/feDisplacementMap-expected.png: Added.
  • platform/chromium-win-xp/svg/filters/feDisplacementMap-expected.png: Added.
  • platform/chromium-win/svg/filters/feDisplacementMap-expected.png:
  • platform/chromium/test_expectations.txt:
13:29 Changeset [114026] by annacc@chromium.org
  • 7 edits
    1 add in trunk

Update HTMLMediaElement's index of cues when TextTrack.mode changes to
and from TextTrack::DISABLED.
https://bugs.webkit.org/show_bug.cgi?id=83377

Reviewed by Eric Carlson.

Source/WebCore:

No new tests. Instead updated media/track/track-mode.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::textTrackModeChanged):

Add the track's cues to the index when the mode changes to HIDDEN or SHOWING.

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::textTrackRemoveCues):

Fix a copy pasta error.

  • html/track/TextTrack.cpp:

(WebCore::TextTrack::setMode):

Remove the track's cues from the index when the mode changes to DISABLED.

LayoutTests:

  • media/track/track-mode-expected.txt:
  • media/track/track-mode.html:
13:26 Changeset [114025] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

Unreviewed, rolling out r114005.
http://trac.webkit.org/changeset/114005
https://bugs.webkit.org/show_bug.cgi?id=83809

This patch may have unveiled other bugs, need to investigate
(Requested by vrk on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-12

  • media/video-seek-past-end-paused-expected.txt:
  • media/video-seek-past-end-paused.html:
  • platform/chromium/test_expectations.txt:
13:23 Changeset [114024] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Allow certain Char events in fullscreen
https://bugs.webkit.org/show_bug.cgi?id=83330

Patch by Cem Kocagil <cem.kocagil@gmail.com> on 2012-04-12
Reviewed by Alexey Proskuryakov.

  • page/EventHandler.cpp:

(WebCore::EventHandler::isKeyEventAllowedInFullScreen):

13:04 Changeset [114023] by schenney@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

Shadow is not shown when using strokeRect with a gradient strokeStyle
https://bugs.webkit.org/show_bug.cgi?id=52509

Unreviewed Chromium expectations update (after all this time).

  • platform/chromium-win/svg/css/rect-gradient-stroke-shadow-expected.png: Added.
  • platform/chromium/test_expectations.txt:
13:01 Changeset [114022] by commit-queue@webkit.org
  • 8 edits
    3 adds in trunk

IndexedDB: Attributes for a cursor "run past the end" should be undefined.
https://bugs.webkit.org/show_bug.cgi?id=83492

Patch by Alec Flett <alecflett@chromium.org> on 2012-04-12
Reviewed by Ojan Vafai.

Source/WebCore:

This brings us up to spec with respect to when it's ok to call
cursor.continue() and the various behaviors around it:

If you call it more than once, continue() throws an exception.

The values of key/primaryKey/value are consistent, whether or not
continue has been called, meaning that if continue() results in
data being loaded from the backing store, that data does not
affect the cursor until the success callback has completed.

Calls to update() and delete() can happen before continue(), but
not afterwards.

Test: storage/indexeddb/cursor-continue-validity.html

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::IDBCursor):
(WebCore::IDBCursor::key):
(WebCore::IDBCursor::primaryKey):
(WebCore::IDBCursor::value):
(WebCore::IDBCursor::update):
(WebCore::IDBCursor::continueFunction):
(WebCore::IDBCursor::deleteFunction):
(WebCore::IDBCursor::setGotValue):
(WebCore):

  • Modules/indexeddb/IDBCursor.h:

(IDBCursor):

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::dispatchEvent):

LayoutTests:

  • storage/indexeddb/cursor-continue-validity-expected.txt: Added.
  • storage/indexeddb/cursor-continue-validity.html: Added.
  • storage/indexeddb/resources/cursor-continue-validity.js: Added.
  • storage/indexeddb/resources/mozilla/cursors-expected.txt:
  • storage/indexeddb/resources/shared.js:
12:58 Changeset [114021] by eric.carlson@apple.com
  • 11 edits
    2 adds in trunk

Media engine should not be told to prepare for playback if media loading is not allowed
https://bugs.webkit.org/show_bug.cgi?id=83620

Reviewed by Dan Bernstein.

Source/WebCore:

Test: media/video-load-require-user-gesture.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::load): Early return if user gesture requirement is not met.

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::setMediaPlaybackRequiresUserGesture): Moved the method here from

Internals to be with the rest of the Internals methods that expose preferences.

  • testing/InternalSettings.h:
  • testing/InternalSettings.idl:
  • testing/Internals.cpp: Moved setMediaPlaybackRequiresUserGesture to InternalSettings.
  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

  • media/video-load-require-user-gesture-expected.txt: Added.
  • media/video-load-require-user-gesture.html: Added.
  • media/video-play-require-user-gesture.html: Update for move of setMediaPlaybackRequiresUserGesture

from window.internals to window.internals.settings.

12:54 Changeset [114020] by commit-queue@webkit.org
  • 21 edits
    2 adds in trunk

[CSS Exclusions] Add flag to enable / disable exclusions at runtime
https://bugs.webkit.org/show_bug.cgi?id=83313

Patch by Bear Travis <betravis@adobe.com> on 2012-04-12
Reviewed by Ryosuke Niwa.

.:

Adding the GTK symbols

  • Source/autotools/symbols.filter:

Source/WebCore:

Adding setCSSExclusionsEnabled/cssExclusionsEnabled that is true by default.
The CSS parser will not accept values for the exclusions properties when
cssExclusionsEnabled is false. However, you will still get the default value
in the computed style.

Test: fast/exclusions/css-exclusions-disabled.html

  • WebCore.exp.in:
  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setCSSExclusionsEnabled):
(WebCore::RuntimeEnabledFeatures::cssExclusionsEnabled):
(RuntimeEnabledFeatures):

  • css/CSSParser.cpp:

(WebCore::isSimpleLengthValue):
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::CSSParser::parseValue):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::restoreTo):
(WebCore::InternalSettings::setCSSExclusionsEnabled):
(WebCore):

  • testing/InternalSettings.h:

(InternalSettings):

  • testing/InternalSettings.idl:

Source/WebKit2:

Adding windows symbols

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

Adding a test to cover CSS parsing, which is the only piece of exclusions
work in place. Updating other exclusions test to explicitly enable the
feature.

  • fast/exclusions/css-exclusions-disabled-expected.txt: Added.
  • fast/exclusions/css-exclusions-disabled.html: Added.
  • fast/exclusions/script-tests/parsing-wrap-shape-inside.js:
  • fast/exclusions/script-tests/parsing-wrap-shape-outside.js:
  • fast/exclusions/script-tests/wrap-flow-parsing.js:
  • fast/exclusions/script-tests/wrap-margin-parsing.js:
  • fast/exclusions/script-tests/wrap-padding-parsing.js:
  • fast/exclusions/script-tests/wrap-parsing.js:
  • fast/exclusions/script-tests/wrap-through-parsing.js:
12:50 Changeset [114019] by schenney@chromium.org
  • 3 edits
    2 adds
    2 deletes in trunk/LayoutTests

[Chromium] Layout test svg/text/font-size-below-point-five.svg needs rebaseline
https://bugs.webkit.org/show_bug.cgi?id=83806

Unreviewed Chromium test expectations update.

  • platform/chromium-linux/svg/text/font-size-below-point-five-expected.txt:
  • platform/chromium-mac-leopard/svg/text/font-size-below-point-five-expected.png: Added.
  • platform/chromium-mac-leopard/svg/text/font-size-below-point-five-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/text/font-size-below-point-five-expected.png: Removed.
  • platform/chromium-mac/svg/text/font-size-below-point-five-expected.png: Added.
  • platform/chromium/test_expectations.txt:
12:35 Changeset [114018] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

Add fast/frames/flattening/frameset-flattening-simple.html to the Skipped list.

  • platform/mac/Skipped:
12:27 Changeset [114017] by schenney@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

[Chromium] LayoutTest update for several Mac filter tests
https://bugs.webkit.org/show_bug.cgi?id=83717

Unreviewed Chromium test expectations update.

Second attempt, now leaving some tests as flakey.

  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png: Added.
  • platform/chromium/test_expectations.txt:
12:27 Changeset [114016] by japhet@chromium.org
  • 5 edits in trunk/Source/WebCore

Move Archive processing to DocumentLoader, instead of FrameLoader.
https://bugs.webkit.org/show_bug.cgi?id=83055

Reviewed by Adam Barth.

No new tests, no functionality change intended.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::setupForReplaceByMIMEType):
(WebCore::DocumentLoader::maybeCreateArchive): Renamed from

FrameLoader::finishedLoadingDocument(). Returns true if an archive
was created.

(WebCore::DocumentLoader::setArchive):
(WebCore::DocumentLoader::scheduleArchiveLoad):
(WebCore::DocumentLoader::documentURL): Add a check for whether an archive url

should be returned, so that we don't need special handling in Document and
FrameLoader for overriding the document url later.

  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::receivedFirstData): Remove archive special cases, since

DocumentLoader::documentURL() will return the right thing for legacy archives
and maybeCreateArchive() will override the base url for mhtml.

(WebCore::FrameLoader::loadArchive):

  • loader/FrameLoader.h:
12:23 Changeset [114015] by andersca@apple.com
  • 3 edits in trunk/LayoutTests

Update test results after r113945.

  • fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
12:19 Changeset [114014] by dpranke@chromium.org
  • 2 edits in trunk/Tools

test-webkitpy fails on metered_stream_unittest for non-US West Coast Time Zones
https://bugs.webkit.org/show_bug.cgi?id=83583

Reviewed by Philippe Normand

Updated the unit test to ignore the hours and minutes of the
localtime for time(0), since we can't easily guarantee which
timezone we're in or what timezone rules were in effect on
1/1/1970; this should be mostly fine since we can trust that
time.localtime() will work, although there is the possibility
that we'll screw up the time formatting of which field is the
hours and which is the minutes.

  • Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:

(VerboseTest):
(VerboseTest.test_basic):
(VerboseTest.test_log_after_update):

12:16 Changeset [114013] by dslomov@google.com
  • 4 edits in trunk

Source/WebCore: REGRESSION (r113233): fast/canvas/webgl/array-message-passing.html crashing on Lion and Snow Leopard bots.
https://bugs.webkit.org/show_bug.cgi?id=83427.
Due to incorrect merge by me when landing r113233, call to find got replaces with call to add in
checking for duplicates in ObjectPool when serializing.

Reviewed by Dean Jackson.

Covered by existing tests.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::checkForDuplicate):

LayoutTests: REGRESSION (r113233): fast/canvas/webgl/array-message-passing.html crashing on Lion and Snow Leopard bots.
https://bugs.webkit.org/show_bug.cgi?id=83427.
Bug fixed, unskipping tests.

Reviewed by Dean Jackson.

  • platform/mac/Skipped:
12:07 Changeset [114012] by commit-queue@webkit.org
  • 8 edits in trunk

Don't modify shared style objects in RenderMathMLRoot.cpp
https://bugs.webkit.org/show_bug.cgi?id=83736

Patch by David Barton <dbarton@mathscribe.com> on 2012-04-12
Reviewed by Julien Chaffraix.

Source/WebCore:

To leave room for the radical sign and absolutely positioned "index", we switch to using
intrinsic padding. RenderMathMLRoot.cpp is also cleaned up and prepared for merging with
RenderMathMLSquareRoot.cpp. The base and index are no longer wrapped in extra renderers,
and the child renderers are now in the same order as in the DOM. Some padding/placement
terms are unified and debugged.

Tested by existing tests in roots.xhtml.

  • css/mathml.css:

(mroot):
(mroot > * + *):
(mroot > * + mrow, mroot > * + mfenced):

  • rendering/mathml/RenderMathMLRoot.cpp:

(WebCore):
(WebCore::RenderMathMLRoot::index):
(WebCore::RenderMathMLRoot::paint):
(WebCore::RenderMathMLRoot::layout):

  • rendering/mathml/RenderMathMLRoot.h:

(RenderMathMLRoot):

  • rendering/mathml/RenderMathMLSquareRoot.cpp:

(WebCore):
(WebCore::RenderMathMLSquareRoot::paint):

LayoutTests:

  • platform/mac/mathml/presentation/roots-expected.png:
  • platform/mac/mathml/presentation/roots-expected.txt:
12:03 Changeset [114011] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Web Inspector messages incorrectly converted
https://bugs.webkit.org/show_bug.cgi?id=83796

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-04-12
Reviewed by Rob Buis.

The JSON sent over from the remote Web Inspector front-end was being
mis interpreted as ISO-8859-1. This caused all non ascii characters to
become garbled when using the String constructor, so we use fromtUTF8 instead.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::dispatchInspectorMessage):

11:57 Changeset [114010] by tsepez@chromium.org
  • 4 edits in trunk/LayoutTests

Typos in LayoutTests/http/tests/security/xssAuditor/script-tag-inside-svg-tag*.html
https://bugs.webkit.org/show_bug.cgi?id=83794

Reviewed by Adam Barth.

Several changes needed to make the XSS in these test cases fire against actual
vulnerable browsers. The tests were still valid, but it is more helpful to see
the XSS pop up.

  • http/tests/security/xssAuditor/script-tag-inside-svg-tag.html:
  • http/tests/security/xssAuditor/script-tag-inside-svg-tag2.html:
  • http/tests/security/xssAuditor/script-tag-inside-svg-tag3.html:
11:54 Changeset [114009] by aestes@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Remove unused WebKit1 SPI for suppressing incremental rendering.
https://bugs.webkit.org/show_bug.cgi?id=83801

Reviewed by Simon Fraser.

This SPI is unused and has been replaced by API ([setS|s]uppressesIncrementalRendering).

  • WebView/WebPreferences.mm:
  • WebView/WebPreferencesPrivate.h:
11:51 Changeset [114008] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations.

  • platform/gtk/test_expectations.txt: Flaky tests list update.
11:32 Changeset [114007] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix.

  • page/mac/SettingsMac.mm:

(WebCore::defaultFontFamilyDictionary):

11:28 Changeset [114006] by antti@apple.com
  • 5 edits in trunk/Source/WebCore

Remove style sheet argument from StyleRuleImport constructor
https://bugs.webkit.org/show_bug.cgi?id=83740

Reviewed by Andreas Kling.

The style sheet is set when the rule is added to one. The parser does not need to know about it.

  • css/CSSImportRule.cpp:

(WebCore::StyleRuleImport::StyleRuleImport):

  • css/CSSImportRule.h:

(StyleRuleImport):
(WebCore::StyleRuleImport::setParentStyleSheet):

  • css/CSSParser.cpp:

(WebCore::CSSParser::createImportRule):

  • css/CSSStyleSheet.cpp:

(WebCore::StyleSheetInternal::parserAppendRule):
(WebCore::StyleSheetInternal::wrapperInsertRule):

11:24 Changeset [114005] by vrk@chromium.org
  • 4 edits in trunk/LayoutTests

Remove setTimeout from media/video-seek-past-end-paused.html and fix other minor issues
https://bugs.webkit.org/show_bug.cgi?id=83505

The test had an arbitrary performance expectation to start playing in 200 ms,
which caused the layout test to fail for Chromium when the Chromium's
audio buffer size increased.
This CL removes that expectation and fixes some HTML and grammar mistakes.

Reviewed by Eric Carlson.

  • media/video-seek-past-end-paused-expected.txt:
  • media/video-seek-past-end-paused.html:
  • platform/chromium/test_expectations.txt:
11:11 Changeset [114004] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r113900): In nightly builds, Safari Webpage Preview Fetcher crashes in Settings::initializeDefaultFontFamilies() due to uncaught exception (sandbox preventing access to fonts plist)
https://bugs.webkit.org/show_bug.cgi?id=83792
<rdar://problem/11234002>

Reviewed by Dan Bernstein.

  • page/mac/SettingsMac.mm: (WebCore::defaultFontFamilyDictionary): Bail out without setting font preferences if the process doesn't have read access to WebCore.framework.
11:10 Changeset [114003] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Add an EFL Debug Buildbot to the master configuration
https://bugs.webkit.org/show_bug.cgi?id=82711

Forgot to add EFL Linux Debug to scheduler.

Patch by Dominik Rottsches <dominik.rottsches@linux.intel.com> on 2012-04-12
Reviewed by Philippe Normand.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
10:49 PrefixedAPIs edited by scheib@chromium.org
Pointer Lock spec link (diff)
10:47 Changeset [114002] by efidler@rim.com
  • 3 edits
    1 add in trunk/Source/WebCore

[BlackBerry] Set up default fonts for BlackBerry
https://bugs.webkit.org/show_bug.cgi?id=83775

Reviewed by Antonio Gomes.

  • PlatformBlackBerry.cmake:
  • page/Settings.cpp:

(WebCore):

  • page/blackberry/SettingsBlackBerry.cpp: Added.

(WebCore):
(WebCore::Settings::initializeDefaultFontFamilies):

10:23 Changeset [114001] by jonlee@apple.com
  • 9 edits
    1 add in trunk/Source/WebCore

Implement Dictionary.h on mac (83472)
https://bugs.webkit.org/show_bug.cgi?id=83472
<rdar://problem/11209766>

Reviewed by Kentaro Hara.

A difference between Dictionary and JSDictionary makes it difficult to merge the two together and avoid
creating a confusing API. The boolean returned by Dictionary::get() represents whether the
property was found. The boolean returned by JSDictionary::tryGetProperty() represents whether an
exception was thrown.

  • WebCore.xcodeproj/project.pbxproj: Add Dictionary.h and Dictionary.cpp.
  • bindings/js/Dictionary.cpp: Added.

(WebCore::Dictionary::Dictionary):
(WebCore::Dictionary::get):

  • bindings/js/Dictionary.h: Leverage JSDictionary's functionality to obtain the data.

(WebCore::Dictionary::isObject): Mark an unimplemented.
(WebCore::Dictionary::isUndefinedOrNull): Mark an unimplemented.
(WebCore::Dictionary::getWithUndefinedOrNullCheck): Mark an unimplemented.

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::tryGetProperty): Convert to a const function.

  • bindings/js/JSDictionary.h:

(WebCore::JSDictionary::isValid):
(WebCore::JSDictionary::tryGetProperty): Convert to a const function.
(WebCore::JSDictionary::get): Similar to tryGetProperty(), but returns true if the
property was found, converting the value succeeded and the out parameter "result" was set.
(WebCore::JSDictionary::tryGetPropertyAndResult): Refactor tryGetProperty() to return the enum directly.

Change bindings scripts to use Dictionary constructor.

  • bindings/js/IDBBindingUtilities.cpp: Remove createDictionaryFromValue().
  • bindings/js/IDBBindingUtilities.h: Remove createDictionaryFromValue().
  • bindings/scripts/CodeGeneratorJS.pm:

(JSValueToNative): Update to remove IDBBindingUtilities.h dependency, and use Dictionary constructor.

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionOptionsObject): Update expected generated output.

10:16 Changeset [114000] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Fix threaded compositor HUD crash
https://bugs.webkit.org/show_bug.cgi?id=83778

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-04-12
Reviewed by James Robinson.

Don't try to read font metrics in threaded compositing mode, since we
currently can't render HUD text with the threaded compositor.

HUD is not testable in WebKit.

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::drawHudContents):

10:09 Changeset [113999] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations.

  • platform/gtk/test_expectations.txt: Marking 2 media tests flaky.
10:02 Changeset [113998] by commit-queue@webkit.org
  • 1 edit
    1 add
    7 deletes in trunk/LayoutTests

[CSS Regions] Convert a fast/regions pixel test to a ref test
https://bugs.webkit.org/show_bug.cgi?id=83713

Patch by David Alcala <dalcala@adobe.com> on 2012-04-12
Reviewed by Dirk Schulze.

  • fast/regions/region-overflow-break-expected.html: Added.
  • platform/chromium-mac-snowleopard/fast/regions/region-overflow-break-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/regions/region-overflow-break-expected.txt: Removed.
  • platform/efl/fast/regions/region-overflow-break-expected.png: Removed.
  • platform/efl/fast/regions/region-overflow-break-expected.txt: Removed.
  • platform/mac-snowleopard/fast/regions/region-overflow-break-expected.png: Removed.
  • platform/mac-snowleopard/fast/regions/region-overflow-break-expected.txt: Removed.
  • platform/mac/fast/regions/region-overflow-break-expected.txt: Removed.
10:02 Changeset [113997] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Add an EFL Debug Buildbot to the master configuration
https://bugs.webkit.org/show_bug.cgi?id=82711

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-12
Reviewed by Philippe Normand.

Hooking up our EFL Linux 64bit debug configuration buildbot to the buildbot master.

  • BuildSlaveSupport/build.webkit.org-config/config.json: EFL Debug builder added
09:40 Changeset [113996] by caseq@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: zoom timeline frame on dblclick on the frame bar
https://bugs.webkit.org/show_bug.cgi?id=83741

Reviewed by Pavel Feldman.

  • put timeline frame bars into a container, so we can have one listener;
  • upon dblclick, find the frame, get its window coordinates and set overview selection window accordingly.
  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane.prototype.zoomToFrame): Get frame coordinates, set overview window.
(WebInspector.TimelineVerticalOverview.prototype.update): Maintain framesPerBar as a member for reuse in getFramePosition()
(WebInspector.TimelineVerticalOverview.prototype.framePosition): Map frame to screen positions.
(WebInspector.TimelineVerticalOverview.prototype._renderBars): Factored out barNumberToScreenPosition()
(WebInspector.TimelineVerticalOverview.prototype._barNumberToScreenPosition):
(WebInspector.TimelineVerticalOverview.prototype.getWindowTimes): Drive-by style fix.

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._updateFrames): Put frames into a containing div.
(WebInspector.TimelinePanel.prototype._onFrameDoubleClicked): Zoom to frame upon double click.

  • inspector/front-end/timelinePanel.css:

(.timeline-frame-container):

09:31 Changeset [113995] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations post-Skipped-migration update #2.

  • platform/gtk/test_expectations.txt:
09:29 Changeset [113994] by caseq@chromium.org
  • 9 edits in trunk

Web Inspector: show wall time frame duration on the vertical overview
https://bugs.webkit.org/show_bug.cgi?id=83718

Reviewed by Pavel Feldman.

Source/WebCore:

  • show frame duration as a contour of the frame bar in vertical overview;
  • when scaling, normalize bar to a max of 3 * median frame duration, so too long frames do not dwarf the majority;
  • add Array.prototype.qselect() for the above;
  • factor our partition algorithm onto Array.prototype for better reuse;
  • inspector/front-end/PartialQuickSort.js: factor out partition()

(Object.defineProperty.):
(Object.defineProperty):

  • inspector/front-end/TimelineFrameController.js:

(WebInspector.TimelineFrameController.prototype._flushFrame): add frame.duration.
(WebInspector.TimelineFrameController.prototype._createSyntheticFrame): ditto.

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineVerticalOverview):
(WebInspector.TimelineVerticalOverview.prototype.reset): this._longestFrameTime is gone.
(WebInspector.TimelineVerticalOverview.prototype.update): ditto.
(WebInspector.TimelineVerticalOverview.prototype._aggregateFrames): return frames to display, not just their timeByCatogory.
(WebInspector.TimelineVerticalOverview.prototype._renderBars): use entire frames, not timeByCategory.
(WebInspector.TimelineVerticalOverview.prototype._renderBar): ditto.

  • inspector/front-end/externs.js: Added annotations for partition() and qselect()

(Array.prototype.partition):
(Array.prototype.qselect):

  • inspector/front-end/utilities.js:

(.):

LayoutTests:

  • inspector/utilities-expected.txt:
  • inspector/utilities.html: added results for Array.prototype.qselect()
09:20 Changeset [113993] by pierre.rossi@gmail.com
  • 29 edits in trunk/LayoutTests

[Qt] More unreviewed gardening after r113968.

Set the right expected results this time.

  • platform/qt-5.0/css1/text_properties/letter_spacing-expected.txt:
  • platform/qt-5.0/editing/inserting/5549929-2-expected.txt:
  • platform/qt-5.0/editing/inserting/5549929-3-expected.txt:
  • platform/qt-5.0/editing/inserting/insert-br-at-tabspan-001-expected.txt:
  • platform/qt-5.0/editing/inserting/insert-br-at-tabspan-002-expected.txt:
  • platform/qt-5.0/editing/inserting/insert-br-at-tabspan-003-expected.txt:
  • platform/qt-5.0/editing/inserting/insert-tab-001-expected.txt:
  • platform/qt-5.0/editing/inserting/insert-tab-002-expected.txt:
  • platform/qt-5.0/editing/inserting/insert-tab-004-expected.txt:
  • platform/qt-5.0/editing/inserting/insert-text-at-tabspan-001-expected.txt:
  • platform/qt-5.0/editing/inserting/insert-text-at-tabspan-002-expected.txt:
  • platform/qt-5.0/editing/inserting/insert-text-at-tabspan-003-expected.txt:
  • platform/qt-5.0/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
  • platform/qt-5.0/editing/selection/editable-html-element-expected.txt:
  • platform/qt-5.0/editing/selection/extend-by-word-001-expected.txt:
  • platform/qt-5.0/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
  • platform/qt-5.0/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
  • platform/qt-5.0/fast/css/word-space-extra-expected.txt:
  • platform/qt-5.0/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt:
  • platform/qt-5.0/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt:
  • platform/qt-5.0/fast/table/border-collapsing/004-expected.txt:
  • platform/qt-5.0/fast/text/international/hindi-whitespace-expected.txt:
  • platform/qt-5.0/fast/text/text-letter-spacing-expected.txt:
  • platform/qt-5.0/svg/batik/text/textPosition-expected.txt:
  • platform/qt-5.0/svg/batik/text/textPosition2-expected.txt:
  • platform/qt-5.0/svg/custom/glyph-selection-arabic-forms-expected.txt:
  • platform/qt-5.0/svg/custom/glyph-selection-bidi-mirror-expected.txt:
  • platform/qt-5.0/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
09:05 Changeset [113992] by staikos@webkit.org
  • 4 edits in trunk

Enable the fullscreen API for BlackBerry.
https://bugs.webkit.org/show_bug.cgi?id=83757

Reviewed by Antonio Gomes.

.:

  • Source/cmake/OptionsBlackBerry.cmake:

Tools:

  • Scripts/build-webkit:
09:04 Changeset [113991] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Optimize non-rounded double border rendering to avoid transparency layers
https://bugs.webkit.org/show_bug.cgi?id=83745

Patch by David Barr <davidbarr@chromium.org> on 2012-04-12
Reviewed by Simon Fraser.

No functional change, painting optimization only.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBorder):

09:02 Changeset [113990] by jchaffraix@webkit.org
  • 24 edits
    2 adds in trunk

Reduce the use of RenderLayer outside of the rendering code
https://bugs.webkit.org/show_bug.cgi?id=83728

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/layers/scrollByLines-overflow-no-layer.html

This is mostly a layering violation change. This changes reduces the number of
RenderLayer use outside rendering/ by a third but there are still numerous uses.

While auditing the different uses of RenderLayer, I found a potential crasher
and fixed it which is why we have a test case.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::visiblePositionForPoint):

  • dom/Document.cpp:

(WebCore::Document::nodesFromRect):
(WebCore::Document::handleZeroPadding):
(WebCore::nodeFromPoint):
(WebCore::Document::prepareMouseEvent):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::contains):

  • page/DragController.cpp:

(WebCore::elementUnderMouse):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseDraggedEvent):
(WebCore::EventHandler::eventMayStartDrag):
(WebCore::EventHandler::updateSelectionForMouseDrag):
(WebCore::EventHandler::hitTestResultAtPoint):
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::hoverTimerFired):
(WebCore::EventHandler::handleDrag):
Updated these call sites to use RenderView::hitTest.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • page/FrameView.cpp:

(WebCore::FrameView::contentsInCompositedLayer):
(WebCore::FrameView::scrollContentsFastPath):
Updated these call sites to use RenderObject::isComposited().

  • dom/Element.cpp:

(WebCore::Element::scrollByUnits):
Call directly RenderBox::scroll instead of calling the layer.
This actually fixes a crasher that slipped through the cracks.

  • editing/visible_units.cpp:
  • html/shadow/TextControlInnerElements.cpp:
  • page/ContextMenuController.cpp:
  • page/FocusController.cpp:
  • page/Frame.cpp:
  • page/GestureTapHighlighter.cpp:
  • page/PrintContext.cpp:
  • plugins/mac/PluginViewMac.mm:

Removed unneeded #include.

  • plugins/gtk/PluginViewGtk.cpp:
  • plugins/qt/PluginViewQt.cpp:

Replaced RenderLayer.h #include with RenderObject.h as
we use RenderObject::absoluteToLocal.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::isComposited):

  • rendering/RenderObject.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::hitTest):

  • rendering/RenderView.h:

Added 2 new functions that pipe through the RenderLayer.

LayoutTests:

The test checks that calling scrollByUnit without a RenderLayer doesn't crash.

  • fast/layers/scrollByLines-overflow-no-layer.html: Added.
  • fast/layers/scrollByLines-overflow-no-layer-expected.txt: Added.
09:00 Changeset [113989] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

font-size:0 text runs has non zero width in case of Windows Safari.
https://bugs.webkit.org/show_bug.cgi?id=83559

Patch by Pravinin D <pravind.2k4@gmail.com> on 2012-04-12
Reviewed by Dan Bernstein.

Test case already exits.
LayoutTest/fast/text/font-size-zero.html

  • platform/graphics/win/SimpleFontDataCGWin.cpp:

(WebCore):
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):

08:57 Changeset [113988] by commit-queue@webkit.org
  • 4 edits in trunk

Web Inspector: Move meta node out of nodes in snapshot serialization.
https://bugs.webkit.org/show_bug.cgi?id=83701

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-04-12
Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
(WebInspector.HeapSnapshot):

LayoutTests:

  • inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotSplitNodesEdgesMockRaw):

08:53 Changeset [113987] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Speed up processing of Selection region generation.
https://bugs.webkit.org/show_bug.cgi?id=82766

Reviewed by Rob Buis.

PR 136593.

Re-speed up text selection. The previous patch had a merge
error causing text selection not to function. The fix
implemented removed the optimization. This fixes the error
in the original patch and removes the temporary fix.

Make style updated as suggested by Antonio Gomes.

Reviewed Internally by Gen Mak.

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::regionForTextQuads):
(BlackBerry::WebKit::regionRectListContainsPoint):

08:48 Changeset [113986] by philn@webkit.org
  • 13 edits
    1 copy
    3 adds in trunk/LayoutTests

Unreviewed, GTK test_expectations post-Skipped-migration update.

  • platform/gtk/fast/dynamic/layer-hit-test-crash-expected.txt:
  • platform/gtk/http/tests/misc/acid2-expected.txt:
  • platform/gtk/svg/hittest/svg-ellipse-non-scale-stroke-expected.txt: Copied from LayoutTests/svg/hittest/svg-ellipse-non-scale-stroke-expected.txt.
  • platform/gtk/svg/hixie/perf/001-expected.txt: Added.
  • platform/gtk/svg/hixie/perf/002-expected.txt: Added.
  • platform/gtk/svg/hixie/perf/003-expected.txt:
  • platform/gtk/svg/hixie/perf/004-expected.txt:
  • platform/gtk/svg/hixie/perf/005-expected.txt:
  • platform/gtk/svg/hixie/perf/006-expected.txt:
  • platform/gtk/svg/hixie/perf/007-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
  • platform/gtk/svg/text/text-deco-01-b-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
  • platform/gtk/test_expectations.txt:
  • svg/hittest/svg-ellipse-non-scale-stroke-expected.txt:
08:43 Changeset [113985] by schenney@chromium.org
  • 6 edits
    7 adds in trunk/LayoutTests

[Chromium] LayoutTest update for several Mac filter tests
https://bugs.webkit.org/show_bug.cgi?id=83717

Unreviewed Chromium test expectations update.

  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png: Added.
  • platform/chromium-mac-leopard/svg/as-border-image/svg-as-border-image-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-border-image/svg-as-border-image-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/as-border-image/svg-as-border-image-2-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/custom/foreign-object-skew-expected.png: Modified property svn:mime-type.
  • platform/chromium/test_expectations.txt:
08:38 Changeset [113984] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

More Mac rebaselines.

Unreviewed.

  • platform/chromium-mac-leopard/css2.1/20110323/replaced-elements-001-expected.png:
08:35 Changeset [113983] by yael.aharon@nokia.com
  • 8 edits
    1 add in trunk

[Qt][WK2] Nested fixed elements scroll too fast
https://bugs.webkit.org/show_bug.cgi?id=83720

Reviewed by Noam Rosenthal.

.:

  • ManualTests/nested-fixed-position.html: Added.

Source/WebCore:

Before setting the scrollPositionDelta to a fixed layer, check if it has an ancestor which also has fixed position.
If it does, do not set scrollPositionDelta.
Added a flag to TextureMapperLayer and GraphicsLayerTextureMapper indicating if it is a fixed position layer.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:

(WebCore::GraphicsLayerTextureMapper::setFixedToViewport):
(WebCore::GraphicsLayerTextureMapper::fixedToViewport):
(GraphicsLayerTextureMapper):

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::syncCompositingStateSelf):
(WebCore::TextureMapperLayer::isAncestorFixedToViewport):
(WebCore):
(WebCore::TextureMapperLayer::setScrollPositionDeltaIfNeeded):

  • platform/graphics/texmap/TextureMapperLayer.h:

(TextureMapperLayer):
(WebCore::TextureMapperLayer::setFixedToViewport):

Source/WebKit2:

Set the fixedToViewport flag on the fixed position layers and adjust to
the new function name for setting scrollPositionDelta.

  • UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::WebLayerTreeRenderer::adjustPositionForFixedLayers):
(WebKit::WebLayerTreeRenderer::setLayerState):

08:32 Changeset [113982] by pierre.rossi@gmail.com
  • 2 edits
    37 adds in trunk/LayoutTests

[Qt] Unreviewed gardening after r113968

Since we now use QRawFont, some tests need a Qt5 specific baseline.

  • platform/qt-5.0/Skipped: skipped two tests with suspicious results.
  • platform/qt-5.0/css1/text_properties/letter_spacing-expected.txt: Added.
  • platform/qt-5.0/editing/inserting/5549929-2-expected.txt: Added.
  • platform/qt-5.0/editing/inserting/5549929-3-expected.txt: Added.
  • platform/qt-5.0/editing/inserting/insert-br-at-tabspan-001-expected.txt: Added.
  • platform/qt-5.0/editing/inserting/insert-br-at-tabspan-002-expected.txt: Added.
  • platform/qt-5.0/editing/inserting/insert-br-at-tabspan-003-expected.txt: Added.
  • platform/qt-5.0/editing/inserting/insert-tab-001-expected.txt: Added.
  • platform/qt-5.0/editing/inserting/insert-tab-002-expected.txt: Added.
  • platform/qt-5.0/editing/inserting/insert-tab-004-expected.txt: Added.
  • platform/qt-5.0/editing/inserting/insert-text-at-tabspan-001-expected.txt: Added.
  • platform/qt-5.0/editing/inserting/insert-text-at-tabspan-002-expected.txt: Added.
  • platform/qt-5.0/editing/inserting/insert-text-at-tabspan-003-expected.txt: Added.
  • platform/qt-5.0/editing/pasteboard/paste-text-at-tabspan-003-expected.txt: Added.
  • platform/qt-5.0/editing/selection/editable-html-element-expected.txt: Added.
  • platform/qt-5.0/editing/selection/extend-by-word-001-expected.txt: Added.
  • platform/qt-5.0/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt: Added.
  • platform/qt-5.0/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt: Added.
  • platform/qt-5.0/fast/css/word-space-extra-expected.txt: Added.
  • platform/qt-5.0/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
  • platform/qt-5.0/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Added.
  • platform/qt-5.0/fast/table/border-collapsing/004-expected.txt: Added.
  • platform/qt-5.0/fast/text/international/hindi-whitespace-expected.txt: Added.
  • platform/qt-5.0/fast/text/text-letter-spacing-expected.txt: Added.
  • platform/qt-5.0/svg/batik/text/textPosition-expected.txt: Added.
  • platform/qt-5.0/svg/batik/text/textPosition2-expected.txt: Added.
  • platform/qt-5.0/svg/custom/glyph-selection-arabic-forms-expected.txt: Added.
  • platform/qt-5.0/svg/custom/glyph-selection-bidi-mirror-expected.txt: Added.
08:12 Changeset [113981] by philn@webkit.org
  • 2 edits
    1 delete in trunk/LayoutTests

[GTK] Migrate Skipped tests to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=83768

Reviewed by Martin Robinson.

This will hopefully simplify gardening tasks. The tests without
bug entry have been marked with BUGWKGTK and the most problematic
suites (mostly for unimplemented or heavily unreliable features
(inspector)) have been SKIP flagged.

  • platform/gtk/Skipped: Removed.
  • platform/gtk/test_expectations.txt:
08:09 Changeset [113980] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

Pattern matching for hexadecimal should include * as an allowable count.
https://bugs.webkit.org/show_bug.cgi?id=83779

Reviewed by Rob Buis.

Update pattern matching check to allow wildcard for number
of characters allowed.

PR 148907.

Reviewed Internally by Gen Mak.

  • WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::elementPatternIndicatesHexadecimal):

08:07 Changeset [113979] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Mark test as flaky on all platforms and add new failure mode.

Unreviewed.

  • platform/chromium/test_expectations.txt:
08:01 Changeset [113978] by antonm@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Rebaseline Mac expectations.

Unreviewed.

  • platform/chromium-mac-leopard/fast/block/float/avoiding-float-centered-expected.png: Added.
07:55 Changeset [113977] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Mark test as flaking on all platforms.

Unreviewed.

  • platform/chromium/test_expectations.txt:
07:55 Changeset [113976] by charles.wei@torchmobile.com.cn
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Revert the patch for 82764
https://bugs.webkit.org/show_bug.cgi?id=83767

Reviewed by Rob Buis.

Revert the patch for 82764, which is causing misfunction.
The internal commit is: 800213f5

  • plugins/blackberry/PluginViewBlackBerry.cpp:

(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::platformGetValue):
(WebCore::PluginView::platformDestroy):

  • plugins/blackberry/PluginViewPrivateBlackBerry.h:

(PluginViewPrivate):

07:52 Changeset [113975] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt]{Mac] Unreviewed, skip new failing tests to paint the bot green.

  • platform/qt-mac/Skipped:
07:43 Changeset [113974] by kenneth@webkit.org
  • 23 edits in trunk/Source/WebKit2

Move viewport meta handling to the web process side
https://bugs.webkit.org/show_bug.cgi?id=83771

Reviewed by Simon Hausmann.

Instead of computing the viewport attributes on both sides,
we now do everything on the web process side, and just send
over the computed result.

  • Scripts/webkit2/messages.py:

(struct_or_class):
(headers_for_type):

  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

  • Shared/WebCoreArgumentCoders.h:

(WebCore):

  • UIProcess/API/efl/PageClientImpl.cpp:

(WebKit::PageClientImpl::didChangeViewportProperties):

  • UIProcess/API/efl/PageClientImpl.h:

(PageClientImpl):

  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::didChangeViewportProperties):

  • UIProcess/API/gtk/PageClientImpl.h:

(PageClientImpl):

  • UIProcess/API/mac/PageClientImpl.h:

(PageClientImpl):

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::didChangeViewportProperties):

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::didRelaunchProcess):
(QQuickWebViewFlickablePrivate::didChangeViewportProperties):
(QQuickWebViewFlickablePrivate::updateViewportSize):

  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate::didChangeViewportProperties):
(QQuickWebViewPrivate):
(QQuickWebViewFlickablePrivate):

  • UIProcess/PageClient.h:

(WebCore):
(PageClient):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didChangeViewportProperties):

  • UIProcess/WebPageProxy.h:

(WebCore):
(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/qt/QtPageClient.cpp:

(QtPageClient::didChangeViewportProperties):

  • UIProcess/qt/QtPageClient.h:

(QtPageClient):

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::didChangeViewportProperties):

  • UIProcess/win/WebView.h:

(WebView):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::dispatchViewportPropertiesDidChange):
(WebKit):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::sendViewportAttributesChanged):
(WebKit):
(WebKit::WebPage::setViewportSize):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

07:23 Changeset [113973] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] One more unreviewed gardening after r113945 and r113961.

  • platform/qt-5.0-wk2/fast/dom/prototype-inheritance-2-expected.txt:
07:21 Changeset [113972] by tkent@chromium.org
  • 6 edits in trunk/Source

[Chromium] Enable INPUT_TYPE_DATE
https://bugs.webkit.org/show_bug.cgi?id=83761

Reviewed by Kentaro Hara.

Source/WebCore:

  • html/DateInputType.cpp:

Touch it to avoid build issues. No code changes.

  • html/DateInputType.h: ditto.
  • html/InputType.cpp: ditto.

Source/WebKit/chromium:

  • features.gypi: Turn ENABLE_INPUT_TYPE_DATE on.
07:13 Changeset [113971] by yurys@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: annotate the rest of profiler front-end for closure compiler
https://bugs.webkit.org/show_bug.cgi?id=83781

All remaining Profiler front-end files are annotated for closure compiler.

Reviewed by Pavel Feldman.

  • inspector/compile-front-end.py:
  • inspector/front-end/CSSSelectorProfileView.js:
  • inspector/front-end/HeapSnapshotProxy.js:

(WebInspector.HeapSnapshotWorkerWrapper):
(WebInspector.HeapSnapshotWorkerWrapper.prototype.postMessag):
(WebInspector.HeapSnapshotWorkerWrapper.prototype.terminate):
(WebInspector.HeapSnapshotWorker):
(WebInspector.HeapSnapshotProxyObject.prototype.callFactoryMethod):
(WebInspector.HeapSnapshotProxyObject.prototype.callMethod):

  • inspector/front-end/HeapSnapshotWorkerDispatcher.js:
  • inspector/front-end/TopDownProfileDataGridTree.js:

(WebInspector.TopDownProfileDataGridTree.prototype.exclude):

  • inspector/front-end/externs.js:

(addEventListener):

06:39 Changeset [113970] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Node Value should not get corrupt while jump over different matches in search.
https://bugs.webkit.org/show_bug.cgi?id=83758

The order in which updateEntryHide is called for cached
highlightResults is changed in "last changed first corrected" order to preserve the semantic of node.

Patch by Sam D <dsam2912@gmail.com> on 2012-04-12
Reviewed by Pavel Feldman.

No new tests required.

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype._updateSearchHighlight):

06:33 Changeset [113969] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Test runner crashes without recent versions of pulseaudio-utils
https://bugs.webkit.org/show_bug.cgi?id=83774

Patch by Simon Pena <spena@igalia.com> on 2012-04-12
Reviewed by Philippe Normand.

Besides checking that pactl is available, check also that its output
is the expected one, and handle gracefully when it isn't, when
trying to unload pulseaudio modules.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort._unload_pulseaudio_module):
(GtkPort._restore_pulseaudio_module):

06:28 Changeset [113968] by pierre.rossi@gmail.com
  • 20 edits
    1 copy in trunk

[Qt] Use QRawFont when building with Qt 5
https://bugs.webkit.org/show_bug.cgi?id=78001

Source/WebCore:

Up until now, fonts in the Qt port have been handled via
the QFont API. QRawFont offers a lower-level API enabling
us to be more in line with what other WebKit ports do.
This patch proceeds to switching over to QRawFont, and
effectively use an earlier change by Andreas Kling
that remained guarded up until now.

Reviewed by Simon Hausmann.

No new tests since this is refactoring of existing
functionality.

  • Target.pri:
  • platform/graphics/Font.cpp:

(WebCore::Font::drawText):

  • platform/graphics/Font.h:

(Font):
(WebCore):
(WebCore::Font::syntheticFont): Added.

  • platform/graphics/SimpleFontData.h:

(SimpleFontData):
(WebCore::SimpleFontData::getQtRawFont):
(WebCore):

  • platform/graphics/qt/FontCacheQt.cpp:

(WebCore::rawFontForCharacters):
(WebCore):
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::createFontPlatformData):

  • platform/graphics/qt/FontCustomPlatformData.h:

(FontCustomPlatformData):

  • platform/graphics/qt/FontCustomPlatformDataQt.cpp:

(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::FontCustomPlatformData::fontPlatformData):
(WebCore::createFontCustomPlatformData):

  • platform/graphics/qt/FontPlatformData.h:

(WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate):
(FontPlatformDataPrivate):
(FontPlatformData):

  • platform/graphics/qt/FontPlatformDataQt.cpp:

(WebCore::FontPlatformData::FontPlatformData):
(WebCore):
(WebCore::FontPlatformData::operator==):

  • platform/graphics/qt/FontQt.cpp:

(WebCore::fillPenForContext):
(WebCore::pathForGlyphs):
(WebCore::drawQtGlyphRun):
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):
(WebCore::Font::initFormatForTextLayout):
(WebCore):
(WebCore::Font::drawGlyphs):
(WebCore::Font::syntheticFont):
(WebCore::Font::rawFont):

  • platform/graphics/qt/FontQt4.cpp: Copied from Source/WebCore/platform/graphics/qt/FontQt.cpp.

(WebCore):
(WebCore::fromRawDataWithoutRef):
(WebCore::setupLayout):
(WebCore::fillPenForContext):
(WebCore::strokePenForContext):
(WebCore::drawTextCommon):
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):
(WebCore::Font::canReturnFallbackFontsForComplexText):
(WebCore::Font::drawEmphasisMarksForComplexText):
(WebCore::Font::drawSimpleText):
(WebCore::Font::offsetForPositionForSimpleText):
(WebCore::Font::floatWidthForSimpleText):
(WebCore::Font::selectionRectForSimpleText):
(WebCore::Font::canExpandAroundIdeographsInComplexText):
(WebCore::Font::primaryFontHasGlyphForCharacter):
(WebCore::Font::emphasisMarkAscent):
(WebCore::Font::emphasisMarkDescent):
(WebCore::Font::emphasisMarkHeight):
(WebCore::Font::drawEmphasisMarksForSimpleText):
(WebCore::Font::font):

  • platform/graphics/qt/SimpleFontDataQt.cpp:

(WebCore::SimpleFontData::platformInit):

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::fileListNameForWidth):

  • platform/qt/RenderThemeQtMobile.cpp:

(WebCore::RenderThemeQtMobile::computeSizeBasedOnStyle):

Source/WebKit/qt:

Since QFont is not used internally, we now need
to query for a QFont that should be a good
enough match.

Reviewed by Simon Hausmann.

  • Api/qwebpage.cpp:

(QWebPage::inputMethodQuery):

  • WebCoreSupport/PopupMenuQt.cpp:

(WebCore::PopupMenuQt::show):

  • WebCoreSupport/RenderThemeQStyle.cpp:

(WebCore::RenderThemeQStyle::computeSizeBasedOnStyle):

Tools:

Flip the QRawFont switch for Qt 5.

Reviewed by Simon Hausmann.

  • qmake/mkspecs/features/features.prf:
06:22 Changeset [113967] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Calculate the cover rect of tiled backing store with the trajectory vector.
https://bugs.webkit.org/show_bug.cgi?id=83462

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2012-04-12
Reviewed by Kenneth Rohde Christiansen.

When trajectory vector is not zero, it is able to calculate the proper cover area.
No new tests - no new functionality.

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::computeCoverAndKeepRect):

06:12 Changeset [113966] by pfeldman@chromium.org
  • 18 edits
    1 copy
    7 moves in trunk

Source/WebCore: Web Inspector: extracting NetworkRequest from Resource (step 2)
https://bugs.webkit.org/show_bug.cgi?id=83773

Reviewed by Yury Semikhatsky.

This step moves request-related views from being resource-based to request-based.
See https://bugs.webkit.org/show_bug.cgi?id=61363 for the meta bug.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/ContentProviders.js:

(WebInspector.ResourceContentProvider):
(WebInspector.ResourceContentProvider.prototype.requestContent):
(WebInspector.ResourceContentProvider.prototype.searchInContent):

  • inspector/front-end/NetworkItemView.js:

(WebInspector.NetworkItemView):
(WebInspector.RequestContentView):
(WebInspector.RequestContentView.prototype._ensureInnerViewShown):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._showPopover):

  • inspector/front-end/NetworkRequest.js:

(WebInspector.NetworkRequest.prototype.resource):

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode.prototype._createContentProvider):

  • inspector/front-end/RequestCookiesView.js: Renamed from Source/WebCore/inspector/front-end/ResourceCookiesView.js.

(WebInspector.RequestCookiesView):

  • inspector/front-end/RequestHTMLView.js: Renamed from Source/WebCore/inspector/front-end/ResourceHTMLView.js.

(WebInspector.RequestHTMLView):
(WebInspector.RequestHTMLView.prototype._createIFrame):

  • inspector/front-end/RequestHeadersView.js: Renamed from Source/WebCore/inspector/front-end/ResourceHeadersView.js.

(WebInspector.RequestHeadersView):

  • inspector/front-end/RequestJSONView.js: Renamed from Source/WebCore/inspector/front-end/ResourceJSONView.js.

(WebInspector.RequestJSONView):
(WebInspector.RequestJSONView.parseJSON.WebInspector.RequestJSONView.parseJSONP):

  • inspector/front-end/RequestPreviewView.js: Renamed from Source/WebCore/inspector/front-end/ResourcePreviewView.js.

(WebInspector.RequestPreviewView):
(WebInspector.RequestPreviewView.prototype.contentLoaded):
(WebInspector.RequestPreviewView.prototype._createPreviewView):

  • inspector/front-end/RequestResponseView.js: Renamed from Source/WebCore/inspector/front-end/ResourceResponseView.js.

(WebInspector.RequestResponseView):
(WebInspector.RequestResponseView.prototype.get sourceView):
(WebInspector.RequestResponseView.prototype.contentLoaded):

  • inspector/front-end/RequestTimingView.js: Renamed from Source/WebCore/inspector/front-end/ResourceTimingView.js.

(WebInspector.RequestTimingView):
(WebInspector.RequestTimingView.prototype._refresh):

  • inspector/front-end/RequestView.js: Copied from Source/WebCore/inspector/front-end/NetworkRequest.js.

(WebInspector.RequestView):
(WebInspector.RequestView.prototype.hasContent):
(WebInspector.RequestView.hasTextContent):
(WebInspector.RequestView.nonSourceViewForRequest):

  • inspector/front-end/ResourceView.js:

(WebInspector.ResourceSourceFrame._canonicalMIMEType):
(WebInspector.ResourceSourceFrame._mimeTypeForResource):
(WebInspector.ResourceSourceFrame.prototype.requestContent):
(WebInspector.ResourceSourceFrame.prototype._contentChanged):
(WebInspector.ResourceRevisionSourceFrame.prototype.requestContent):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:

Tools: Web Inspector: Disabling Inspector causes build failure on Windows
https://bugs.webkit.org/show_bug.cgi?id=83557

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-04-11
Reviewed by Pavel Feldman.

The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
This change brings all such API calls under the guard.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(LayoutTestController):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::invoke):

LayoutTests: Web Inspector: extracting NetworkRequest from Resource (step 2)
https://bugs.webkit.org/show_bug.cgi?id=83773

Reviewed by Yury Semikhatsky.

  • http/tests/inspector/network/network-request-revision-content.html:
  • http/tests/inspector/network/request-parameters-decoding.html:
05:42 Changeset [113965] by ossy@webkit.org
  • 4 edits
    1 copy in trunk/LayoutTests

[Qt] Unreviewed gardening after r113945, update platform specific expected files.

  • platform/qt-5.0-wk2/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt-5.0/Skipped: Unskip dom/prototype-inheritance-2.html and update its results.
  • platform/qt-5.0/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
05:19 Changeset [113964] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2012-04-12 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Fix a couple of compiler annotations after r113963.

  • inspector/front-end/TopDownProfileDataGridTree.js: (WebInspector.TopDownProfileDataGridTree): (WebInspector.TopDownProfileDataGridTree.prototype.exclude):
05:03 Changeset [113963] by yurys@chromium.org
  • 14 edits in trunk/Source/WebCore

Web Inspector: add closure compiler annotations for profiler code
https://bugs.webkit.org/show_bug.cgi?id=83700

Basic type annotations are added to most of the profiler front-end. Some
dead code removed.

Reviewed by Pavel Feldman.

  • inspector/compile-front-end.py:
  • inspector/front-end/BinarySearch.js:

(Object.defineProperty):

  • inspector/front-end/BottomUpProfileDataGridTree.js:

(WebInspector.BottomUpProfileDataGridNode.prototype._restore):
(WebInspector.BottomUpProfileDataGridNode.prototype._sharedPopulate):
(WebInspector.BottomUpProfileDataGridNode.prototype._willHaveChildren):
(WebInspector.BottomUpProfileDataGridTree):

  • inspector/front-end/DataGrid.js:
  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotInstanceNode.prototype._createChildNode):
(WebInspector.HeapSnapshotDiffNode.prototype.populateChildren.firstProviderPopulated):
(WebInspector.HeapSnapshotDiffNode.prototype.populateChildren.else.firstProviderPopulated):
(WebInspector.HeapSnapshotDiffNode.prototype.populateChildren):

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype._changeBase):
(WebInspector.DetailedHeapshotView.prototype._setRetainmentDataGridSource):
(WebInspector.DetailedHeapshotView.prototype._helpClicked.appendHelp):
(WebInspector.DetailedHeapshotView.prototype._helpClicked):

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot):
(HeapSnapshotMetainfo):
(WebInspector.HeapSnapshot.prototype._buildRetainers):
(WebInspector.HeapSnapshot.prototype._buildDominatedNodes):
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):

  • inspector/front-end/ProfileDataGridTree.js:

(WebInspector.ProfileDataGridNode.prototype.insertChild):
(WebInspector.ProfileDataGridNode.prototype.removeChild):
(WebInspector.ProfileDataGridNode.prototype.removeChildren):
(WebInspector.ProfileDataGridNode.prototype._populate):
(WebInspector.ProfileDataGridTree.propertyComparator):

  • inspector/front-end/ProfileView.js:
  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfileHeader):
(WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.parsed):
(WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
(WebInspector.ProfilesPanel.prototype.performSearch.finishedCallback):
(WebInspector.ProfilesPanel.prototype.setRecordingProfile):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
(WebInspector.ProfilerDispatcher.prototype.addProfileHeader):

  • inspector/front-end/TopDownProfileDataGridTree.js:

(WebInspector.TopDownProfileDataGridTree):
(WebInspector.TopDownProfileDataGridTree.prototype.exclude):

  • inspector/front-end/externs.js:

(Array.prototype.binaryIndexOf):
(Array.prototype.sortRange):
(WebInspector.CSSSelectorProfileType):
(WebInspector.HeapSnapshotWorker):
(WebInspector.HeapSnapshotWorker.prototype.createObject):
(WebInspector.HeapSnapshotWorker.prototype.startCheckingForLongRunningCalls):

  • inspector/front-end/heapProfiler.css:
04:27 Component Model edited by hayato@chromium.org
(diff)
04:12 Changeset [113962] by commit-queue@webkit.org
  • 16 edits
    3 adds in trunk

[Qt][WK2] Zoom gesture with double tap crashes on iframe when main frame has scroll offset.
https://bugs.webkit.org/show_bug.cgi?id=83428

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-12
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

When delegate scrolling is on, the frame view needs to ignore scrolling offset when converting
coordinates. It is already done at ScrollView base class and this patch copies the logic to the
FrameView subclass.
Also make sure that TouchAdjustment's findBest*() functions' return value are not ignored by the caller.

Test: touchadjustment/iframe-with-mainframe-scroll-offset.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::bestClickableNodeForTouchPoint):
(WebCore::EventHandler::bestZoomableAreaForTouchPoint):

  • page/EventHandler.h:

(EventHandler):

  • page/FrameView.cpp:

(WebCore::FrameView::convertFromRenderer):
(WebCore::FrameView::convertToRenderer):

  • page/GestureTapHighlighter.cpp:
  • testing/Internals.cpp:

(WebCore::Internals::setDelegatesScrolling):
(WebCore::Internals::touchPositionAdjustedToBestClickableNode):
(WebCore::Internals::bestZoomableAreaForTouchPoint):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit2:

When delegate scrolling is on, the frame view needs to ignore scrolling offset when converting
coordinates. It is already done at ScrollView base class and this patch copies the logic to the
FrameView subclass.
Also make sure that TouchAdjustment's findBest*() functions' return value are not ignored by the caller.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::highlightPotentialActivation):
(WebKit::WebPage::findZoomableAreaForPoint):

LayoutTests:

  • touchadjustment/scroll-delegation/iframe-with-mainframe-scroll-offset-expected.txt: Added.
  • touchadjustment/scroll-delegation/iframe-with-mainframe-scroll-offset.html: Added.
  • touchadjustment/zoom-basic.html:
04:01 Changeset [113961] by ossy@webkit.org
  • 4 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r113945, update platform specific expected files.

  • platform/qt-4.8/fast/dom/Window/window-properties-expected.txt:
  • platform/qt-5.0-wk2/fast/dom/Window/window-properties-expected.txt:
  • platform/qt-5.0/fast/dom/Window/window-properties-expected.txt:
03:52 Changeset [113960] by ossy@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Two canvas tests fail with QT_IMAGE_DECODER=0 setup
https://bugs.webkit.org/show_bug.cgi?id=83764

The following tests were failed after r108792:

  • canvas-toDataURL-case-insensitive-mimetype.html
  • toDataURL-supportedTypes.html

because supportedImageMIMETypesForEncoding wasn't filled
with MIME types in case of QT_IMAGE_DECODER=0 build setup.

Patch by Zoltan Horvath <zoltan@webkit.org> on 2012-04-12
Reviewed by Csaba Osztrogonác.

Fixes existing tests.

  • platform/MIMETypeRegistry.cpp:

(WebCore::initializeSupportedImageMIMETypesForEncoding):

03:32 Changeset [113959] by commit-queue@webkit.org
  • 31 edits
    4 deletes in trunk

Unreviewed, rolling out r113931.
http://trac.webkit.org/changeset/113931
https://bugs.webkit.org/show_bug.cgi?id=83766

broke 4 tests on JSC platforms (Requested by philn-tp on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-12

Source/WebCore:

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNamedConstructorCallback):
(GenerateImplementation):

  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::createPrototype):

  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore):

  • bindings/v8/NPV8Object.cpp:

(WebCore::npObjectTypeInfo):

  • bindings/v8/V8BindingPerContextData.cpp:

(WebCore::V8BindingPerContextData::init):
(WebCore::V8BindingPerContextData::createWrapperFromCacheSlowCase):
(WebCore::V8BindingPerContextData::constructorForTypeSlowCase):

  • bindings/v8/V8BindingPerContextData.h:

(V8BindingPerContextData):

  • bindings/v8/V8HiddenPropertyName.h:

(WebCore):

  • bindings/v8/WrapperTypeInfo.h:

(WrapperTypeInfo):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore):

  • dom/NodeList.idl:

LayoutTests:

  • fast/dom/HTMLSelectElement/named-options-expected.txt:
  • fast/dom/HTMLSelectElement/script-tests/named-options.js:
  • fast/dom/NodeList/node-list-array-class-expected.txt: Removed.
  • fast/dom/NodeList/node-list-array-class.html: Removed.
  • fast/dom/NodeList/nodelist-item-call-as-function-expected.txt:
  • platform/chromium/fast/dom/HTMLSelectElement/named-options-expected.txt: Removed.
  • platform/chromium/inspector/console/command-line-api-expected.txt: Removed.
  • platform/chromium/inspector/console/console-dir-expected.txt:
  • platform/chromium/inspector/console/console-format-collections-expected.txt:
  • platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
03:26 Changeset [113958] by tkent@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Fix !ENABLE(PAGE_POPUP) build

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl): Wrap m_pagePopup with ENABLE(PAGE_POPUP).

03:19 Changeset [113957] by yutak@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, remove test expectations for worker-reload.html, as
the source of flakiness was removed in r113292.

  • platform/chromium/test_expectations.txt:
  • platform/mac/test_expectations.txt:
02:59 Changeset [113956] by tkent@chromium.org
  • 6 edits
    1 add in trunk/Source/WebKit/chromium

[Chromium] Add PagePopup implementation
https://bugs.webkit.org/show_bug.cgi?id=81081

Reviewed by Adam Barth.

Add WebPagePopupImpl class, which is an implementation of
WebCore::PagePopup interface and WebKit::WebPagePopup interface. It's a
WebWidget which has a Page object.

No new tests because this makes no behavior change yet.

  • WebKit.gyp: Add WebPagePopupImpl.h.
  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::hasOpenedPopup): Supports the PagePopup.
(WebKit::ChromeClientImpl::openPagePopup):
just delegate to WebViewImpl::openPagePopup().
(WebKit::ChromeClientImpl::closePagePopup): ditto.

  • src/WebPagePopupImpl.cpp:

(PagePopupChromeClient):
This is a light implementation of ChromeClient for the page in
WebPagePopupImpl. This is a friend of WebPagePopupImpl becase of ease of
access to its members.
(WebKit::PagePopupChromeClient::PagePopupChromeClient):
(WebKit::WebPagePopupImpl::WebPagePopupImpl):
(WebKit::WebPagePopupImpl::~WebPagePopupImpl):
(WebKit::WebPagePopupImpl::init):
(WebKit::WebPagePopupImpl::initPage):
(WebKit::WebPagePopupImpl::size):
(WebKit::WebPagePopupImpl::animate): Calls PageWidgetDelegate::animate().
(WebKit::WebPagePopupImpl::composite):
(WebKit::WebPagePopupImpl::layout): Calls PageWidgetDelegate::layout().
(WebKit::WebPagePopupImpl::paint): Calls PageWidgetDelegate::paint().
(WebKit::WebPagePopupImpl::resize):
(WebKit::WebPagePopupImpl::handleKeyEvent):
(WebKit::WebPagePopupImpl::handleCharEvent):
(WebKit::WebPagePopupImpl::handleGestureEvent):
(WebKit::WebPagePopupImpl::handleInputEvent):
(WebKit::WebPagePopupImpl::setFocus):
(WebKit::WebPagePopupImpl::close): Delete the page, and kill itself.
(WebKit::WebPagePopupImpl::closePopup):
(WebKit::WebPagePopup::create):

  • src/WebPagePopupImpl.h: Added.
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl): Initialize m_pagePopup.
(WebKit::WebViewImpl::handleKeyEvent):
Renamed from keyEvent(). Forward key events to a PagePopup if it is open.
(WebKit::WebViewImpl::handleCharEvent):
Renamed from charEvent(). Forward char events to a PagePopup if it is open.
(WebKit::WebViewImpl::openPagePopup):
Added. Instantiate a WebPagePopupImpl, calculates a good bounding
rectangle of the page popup from the specified element rectangle,
initialize the WebPagePopupImpl, and stop caret blink.
(WebKit::WebViewImpl::closePagePopup):
Close the popup, clear m_pagePopup, and resume caret blink.
(WebKit::WebViewImpl::setFocus): Hide all the popups.
(WebKit::WebViewImpl::hidePopups): Hide the page popup too.

  • src/WebViewImpl.h:

(WebKit::WebViewImpl::hasOpenedPopup): Checks the page popup too.

02:51 Changeset [113955] by ossy@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[Qt][ARM] Buildfix after r113934.

Reviewed by Zoltan Herczeg.

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::compare8):
(MacroAssemblerARM):

02:01 Changeset [113954] by kkristof@inf.u-szeged.hu
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r113885.

  • platform/qt/css2.1/20110323/replaced-elements-001-expected.png:
  • platform/qt/css2.1/20110323/replaced-elements-001-expected.txt:
01:51 Changeset [113953] by charles.wei@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Upstreaming BlackBerry-specific changes to PluginView -- remove unused functions
https://bugs.webkit.org/show_bug.cgi?id=83756

Reviewed by George Staikos.

PluginView::halt(), PluginView::restart() have been removed from
upstreaming code, should remove them from BlackBerry porting also.

  • plugins/blackberry/PluginViewBlackBerry.cpp:
01:50 Changeset [113952] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreveiwed gardening. Skip the failing reftest.

  • platform/qt/Skipped: skip fast/workers/worker-multi-startup.html
01:49 Changeset [113951] by bashi@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] The size of glyphStorage should be passed to substituteWithVerticalGlyphs()
https://bugs.webkit.org/show_bug.cgi?id=83751

Reviewed by Kent Tamura.

The last argument of substituteWithVerticalGlyphs() should be
the size of |glyphStorage|.

No new tests because we can't test the fix by layout tests.
I confirmed the fix with ASAN.

  • platform/graphics/skia/GlyphPageTreeNodeSkia.cpp:

(WebCore::GlyphPage::fill):

01:37 Changeset [113950] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[BlackBerry] We shouldn't set empty Content-Length & Content-Type to a request's headers.
https://bugs.webkit.org/show_bug.cgi?id=83349

When there is a redirection for a POST request, we change POST to GET and set
Content-Length/Content-Type to empty strings.
We should remove these headers instead of adding empty strings.

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-12
Reviewed by George Staikos.

No new tests. Refactor.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::handleRedirect):

  • platform/network/blackberry/ResourceRequest.h:

(ResourceRequest):

  • platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::ResourceRequest::clearHTTPContentLength):
(WebCore):
(WebCore::ResourceRequest::clearHTTPContentType):

01:31 Changeset [113949] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

[Qt] ImageBuffer: Canonical mimeType for encoding implies startsWith('image/')
https://bugs.webkit.org/show_bug.cgi?id=83746

Reviewed by Simon Hausmann.

Canonical image mimeTypes begin with "image/", and this is tested by an ASSERT
guard in toDataURL(): that checks the WebCore mimeType registry for image-for-
encoding mimeType. There is no need to also test mimeType.startsWith("image/")
since that is a given.

No new tests. Covered by existing fast/canvas/*toDataURL* tests.

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::ImageBuffer::toDataURL):

01:22 Changeset [113948] by tkent@chromium.org
  • 6 edits
    2 adds in trunk/Source/WebKit/chromium

[Chromium] Move some code of WebViewImpl and WebFrameImpl to PageWidgetDelegate
https://bugs.webkit.org/show_bug.cgi?id=83750

Reviewed by Adam Barth.

In order to share code in WebViewImpl and the incoming WebPagePopupImpl,
we move some code of WebViewImpl and WebFrameImpl to PageWidgetDelegate.
PageWidgetDelegate is a set of static functions because we can't use
virtual inheritance in this case and we don't want to move WebView's
data members to another class.

No new tests. Just refactoring.

  • WebKit.gyp: Add PageWidgetDelegate.{cpp,h} and WebPagePopupImpl.h.
  • src/PageWidgetDelegate.cpp: Added.

(WebKit::mainFrameView):
(WebKit::PageWidgetDelegate::animate):
Moved from a part of WebViewImpl::animatie()
(WebKit::PageWidgetDelegate::layout):
Moved from WebViewImpl::layout() and WebFrameImpl::layout().
(WebKit::PageWidgetDelegate::paint):
Moved from WebFrameImpl::paint() and paintWithContext().
(WebKit::PageWidgetDelegate::handleInputEvent):
Moved from a part of WebViewImpl::handleInputEvent().
(WebKit::PageWidgetEventHandler::handleMouseMove):
Common implementation of an event handling.
(WebKit::PageWidgetEventHandler::handleMouseLeave): ditto.
(WebKit::PageWidgetEventHandler::handleMouseDown): ditto.
(WebKit::PageWidgetEventHandler::handleMouseUp): ditto.
(WebKit::PageWidgetEventHandler::handleMouseWheel): ditto.
(WebKit::PageWidgetEventHandler::handleTouchEvent): ditto.

  • src/PageWidgetDelegate.h: Added.
  • src/WebFrameImpl.cpp:

Remove layout(), paintWithContext(), and paint(). They are moved to
PageWidgetDelegate.

  • src/WebFrameImpl.h:

(WebFrameImpl): Remove layout(), paintWithContext(), and paint().

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleMouseLeave):
Renamed from mouseLeave(), use PageWidgetDelegate::handleMouseLeave().
(WebKit::WebViewImpl::handleMouseDown):
Renamed from mouseDown(), use PageWidgetDelegate::handleMouseDown().
(WebKit::WebViewImpl::handleMouseUp):
Renamed from mouseUp(), use PageWidgetDelegate::handleMouseUp().
(WebKit::WebViewImpl::scrollBy): Calls renamed handleMouseWheel().
(WebKit::WebViewImpl::handleGestureEvent): Renamed from gestureEvent().
(WebKit::WebViewImpl::handleKeyEvent): Renamed from keyEvent().
(WebKit::WebViewImpl::handleCharEvent): Renamed from charEvent().
(WebKit::WebViewImpl::updateAnimations): Uses PageWidgetDelegate::animate().
(WebKit::WebViewImpl::layout): Uses PageWidgetDelegate::layout().
(WebKit::WebViewImpl::paint): Uses PageWidgetDelegate::paint().
(WebKit::WebViewImpl::handleInputEvent): Uses PageWidgetDelegate::handleInputEvent().

  • src/WebViewImpl.h:
01:09 Changeset [113947] by enne@google.com
  • 10 edits in trunk/Source/WebKit/chromium

[chromium] Fix Windows compiler warnings in webkit_unit_test target
https://bugs.webkit.org/show_bug.cgi?id=83732

Reviewed by Kent Tamura.

  • tests/CCDamageTrackerTest.cpp:

(WebKitTests::TEST_F):

  • tests/CCLayerImplTest.cpp:

(WebCore::TEST):

  • tests/CCLayerTreeHostCommonTest.cpp:

(WebKitTests::TEST):

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKitTests::TEST_F):

  • tests/CCQuadCullerTest.cpp:

(WebCore::TEST):

  • tests/FloatQuadTest.cpp:

(WebCore::TEST):

  • tests/ScrollAnimatorNoneTest.cpp:

(TEST_F):

  • tests/TreeSynchronizerTest.cpp:

(WebKitTests::TEST):

  • tests/WebLayerTest.cpp:
00:08 Changeset [113946] by philn@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r113945.

  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:

04/11/12:

23:35 Changeset [113945] by abarth@webkit.org
  • 6 edits
    2 adds in trunk

Implement Location.ancestorOrigins
https://bugs.webkit.org/show_bug.cgi?id=83493

Reviewed by David Levin.

Source/WebCore:

Test: fast/dom/Window/Location/ancestor-origins.html

This patch implements Location.ancestorOrigins(), which returns a list
of the origins of the enclosing frames. This API has been discussed
both on webkit-dev (see discussion following
https://lists.webkit.org/pipermail/webkit-dev/2012-March/020090.html)
and on the whatwg list (see discussion following
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-March/035188.html).

  • page/Location.cpp:

(WebCore::Location::ancestorOrigins):
(WebCore):

  • page/Location.h:

(Location):

  • page/Location.idl:

LayoutTests:

  • fast/dom/Window/Location/ancestor-origins-expected.txt: Added.
  • fast/dom/Window/Location/ancestor-origins.html: Added.
23:30 WebKitIDL edited by arv@chromium.org
Document the ArrayClass IDL attribute (diff)
23:05 Changeset [113944] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed rebaseline.

Patch by Antonio Gomes <agomes@rim.com> on 2012-04-11

  • media/nodesFromRect-shadowContent-expected.txt:
22:51 Changeset [113943] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/chromium

IndexedDB: Stub out WebKit interface for get(IndexedKeyRange)
https://bugs.webkit.org/show_bug.cgi?id=83637

Patch by Alec Flett <alecflett@chromium.org> on 2012-04-11
Reviewed by Kent Tamura.

This is just a stub-out of IDBObjectStore.get(IDBKeyRange) to coordinate
a landing in chromium

  • public/WebIDBObjectStore.h:

(WebKit::WebIDBObjectStore::get):
(WebIDBObjectStore):

  • src/IDBObjectStoreBackendProxy.cpp:

(WebKit::IDBObjectStoreBackendProxy::get):
(WebKit):

  • src/IDBObjectStoreBackendProxy.h:

(IDBObjectStoreBackendProxy):

  • src/WebIDBObjectStoreImpl.cpp:

(WebKit::WebIDBObjectStoreImpl::get):
(WebKit):

  • src/WebIDBObjectStoreImpl.h:

(WebIDBObjectStoreImpl):

22:40 Changeset [113942] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

fast/text/international/font-fallback-to-common-script.html fails on Mac
https://bugs.webkit.org/show_bug.cgi?id=83743

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-04-11
Reviewed by Kent Tamura.

Change test not assume that there is no font setting for Simplified Chinese.

  • fast/text/international/font-fallback-to-common-script.html:
  • platform/mac/Skipped:
21:19 Changeset [113941] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

It is incorrect to short-circuit Branch(LogicalNot(@a)) if boolean speculations on @a may fail
https://bugs.webkit.org/show_bug.cgi?id=83744
<rdar://problem/11206946>

Source/JavaScriptCore:

Reviewed by Andy Estes.

This does the conservative thing: it only short-circuits Branch(LogicalNot(@a)) if @a is a node
that is statically known to return boolean results.

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

LayoutTests:

Rubber stamped by Andy Estes.

  • fast/js/dfg-branch-not-fail-expected.txt: Added.
  • fast/js/dfg-branch-not-fail.html: Added.
  • fast/js/script-tests/dfg-branch-not-fail.js: Added.

(foo):
(bar):

20:48 Changeset [113940] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

AudioContext createChannelSplitter() method should have optional argument for number of outputs
https://bugs.webkit.org/show_bug.cgi?id=83648

Patch by Raymond Liu <raymond.liu@intel.com> on 2012-04-11
Reviewed by Chris Rogers.

Check https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html for the optional argument.

Source/WebCore:

Test: webaudio/audiochannelsplitter.html

  • Modules/webaudio/AudioChannelSplitter.cpp:

(WebCore::AudioChannelSplitter::create):
(WebCore::AudioChannelSplitter::AudioChannelSplitter):
(WebCore::AudioChannelSplitter::process):

  • Modules/webaudio/AudioChannelSplitter.h:

(AudioChannelSplitter):

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::createChannelSplitter):
(WebCore):

  • Modules/webaudio/AudioContext.h:

(AudioContext):

  • Modules/webaudio/AudioContext.idl:

LayoutTests:

  • webaudio/audiochannelsplitter-expected.txt: Added.
  • webaudio/audiochannelsplitter.html: Added.
20:34 Changeset [113939] by charles.wei@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Revert the changes that depend on Event changes, which is reverted already internally.
https://bugs.webkit.org/show_bug.cgi?id=83456

Reviewed by George Staikos.

No new tests, just to make BlackBerry-porting to build.

  • plugins/blackberry/PluginViewBlackBerry.cpp:

(WebCore::PluginView::handleWheelEvent):
(WebCore::PluginView::handleTouchEvent):
(WebCore::PluginView::handleMouseEvent):

20:06 Changeset [113938] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] There shouldn't be two or more Accept-Language in platformRequest's headerList.
https://bugs.webkit.org/show_bug.cgi?id=83670

FrameLoaderClientBlackBerry::dispatchWillSendRequest and NetworkManager::startJob will call
ResourceRequest::initializePlatformRequest. Accept-Language is added two times.
We should avoid the second adding to improve performance.

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-11
Reviewed by Rob Buis.

No new tests. Refactor.

  • platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::ResourceRequest::initializePlatformRequest):

19:32 April 2012 Meeting edited by rniwa@webkit.org
Add slides for perf-o-matic / performance tests talk (diff)
19:10 Changeset [113937] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

[BlackBerry] MMRPlayer will hang webkit thread when retrieving media metadata
https://bugs.webkit.org/show_bug.cgi?id=80978

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-04-11
Reviewed by Rob Buis.

Source/WebCore:

RIM PR: 143471
Implemented the interface function onWaitMetadataNotified()
which starts a timer to wait for the metadata retrieving to
finish, and pops up a dialog to notify the user what to do
if there still is no metadata when the timer fires.

This patch also contributed by Max Feil <mfeil@rim.com>.
Internally reviewed by Max Feil.

Test: http/tests/media/video-throttled-load-metadata.html

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore):
(WebCore::MediaPlayerPrivate::onWaitMetadataNotified):
(WebCore::MediaPlayerPrivate::waitMetadataTimerFired):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:

(MediaPlayerPrivate):

LayoutTests:

RIM PR: 143471
Added a layout test which simulates a slow network, and starts a web worker
thread to write a log message when retrieving media metadata to see if the
webkit thread is blocked by media retrieving thread.

  • http/tests/media/video-throttled-load-metadata-expected.txt: Added.
  • http/tests/media/video-throttled-load-metadata-worker.js: Added.
  • http/tests/media/video-throttled-load-metadata.html: Added.
18:55 Changeset [113936] by bashi@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Fix Windows warnings in WebSocketDeflaterTest
https://bugs.webkit.org/show_bug.cgi?id=83731

Reviewed by Kent Tamura.

Use const char* instead of const char[] to suppress warnings on
Windows.

  • tests/WebSocketDeflaterTest.cpp:

(WebCore::TEST):

18:38 Changeset [113935] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Invalid Union Reference in StructureStubInfo.{cpp.h}
https://bugs.webkit.org/show_bug.cgi?id=83735

Reviewed by Filip Pizlo.

Changed the references to u.getByIdProtoList and u.getByIdSelfList
to be consistent.

  • bytecode/StructureStubInfo.cpp:

(JSC::StructureStubInfo::visitWeakReferences):

  • bytecode/StructureStubInfo.h:

(JSC::StructureStubInfo::initGetByIdSelfList):

18:31 April 2012 Meeting edited by rniwa@webkit.org
Merge two test importing topics into one (diff)
18:13 Changeset [113934] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Unreviewed attempting to make Qt's eccentric hardware work.

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::compare8):
(MacroAssemblerARM):

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::compare8):
(MacroAssemblerMIPS):

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::compare8):
(MacroAssemblerSH4):

18:09 Changeset [113933] by jer.noble@apple.com
  • 4 edits in trunk

Layout Test webaudio/* is flaky
https://bugs.webkit.org/show_bug.cgi?id=83624

Reviewed by Chris Rogers.

Source/WebCore:

No new tests; fixes webaudio/ layout tests.

A merge error led to an Mutex overunlock situation, which caused all future mutex trylock
attempts to fail, but only on Windows. Remove the extraneous mutex unlock().

  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::process):

LayoutTests:

Re-enable webaudio/ layout tests on chromium-win.

  • platform/chromium/test_expectations.txt:
18:02 Changeset [113932] by leviw@chromium.org
  • 2 edits in trunk/Source/WebCore

Correct pixel snapping error in RenderBox::pixelSnappedClientWidth/Height
https://bugs.webkit.org/show_bug.cgi?id=83621

Reviewed by Eric Seidel.

Though the problem wouldn't yet manifest itself since we haven't flipped the switch on sub-pixel
layout, clientWidth and clientHeight, when pixel snapped, need to take the RenderBox's location
into account. Previously, ClientLeft/Top were used, but these are simply the width of the borders,
and don't include the box's sub-pixel location, which is needed to properly snap the width/height.

No new tests. Untestable until we switch to FractionalLayoutUnits. A test case that covers this
is in the subpixellayout branch and will land with the switch.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::pixelSnappedClientWidth):
(WebCore::RenderBox::pixelSnappedClientHeight):
(WebCore::RenderBox::scrollWidth): Replacing a raw zero with ZERO_LAYOUT_UNIT.

18:00 Changeset [113931] by arv@chromium.org
  • 31 edits
    1 copy
    4 adds in trunk

Add support for [ArrayClass] and use that on NodeList
https://bugs.webkit.org/show_bug.cgi?id=81573

Reviewed by Adam Barth.

With this patch NodeLists now have Array.prototype on their prototype chain which allows
methods such as forEach and map to work on NodeLists.

http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#interface-nodelist

For V8 we need to set a flag on the WrapperTypeInfo since V8 uses FunctionTemplates which
does not allow setting the prototype to a non FunctionTemplate so the prototype is therefore
set when the constructor is created.

For JSC we just pass the right prototype object when creating the NodeList prototype. JSC has
a bug (81588) that prevents toString to work as specced on Array.prototype.toString. This
causes test failures in the tests until that has been fixed.

Source/WebCore:

Test: fast/dom/NodeList/node-list-array-class.html

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader): Include ArrayPrototype.h if an ArrayClass.
(GenerateImplementation): If ArrayClass use arrayPrototype as prototype.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNamedConstructorCallback):
(GenerateImplementation): Adds a flag to the WrapperTypeInfo.

  • bindings/scripts/IDLAttributes.txt: Adds new attribute: ArrayClass.
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::createPrototype):

  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore):

  • bindings/v8/V8BindingPerContextData.cpp:

(WebCore::V8BindingPerContextData::init): Get the array prototype too.
(WebCore::V8BindingPerContextData::createWrapperFromCacheSlowCase):
(WebCore::V8BindingPerContextData::constructorForTypeSlowCase): If this is an ArrayClass we need to
set the Prototype?.

  • bindings/v8/V8BindingPerContextData.h:

(V8BindingPerContextData):

  • bindings/v8/V8HiddenPropertyName.h:

(WebCore):

  • bindings/v8/WrapperTypeInfo.h:

(WrapperTypeInfo):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore):

  • dom/NodeList.idl:

LayoutTests:

  • fast/dom/HTMLSelectElement/named-options-expected.txt:
  • fast/dom/HTMLSelectElement/script-tests/named-options.js:
  • fast/dom/NodeList/node-list-array-class-expected.txt: Added.
  • fast/dom/NodeList/node-list-array-class.html: Added.
  • fast/dom/NodeList/nodelist-item-call-as-function-expected.txt:
  • platform/chromium/fast/dom/HTMLSelectElement/named-options-expected.txt: Copied from LayoutTests/fast/dom/HTMLSelectElement/named-options-expected.txt.
  • platform/chromium/inspector/console/command-line-api-expected.txt: Added.
  • platform/chromium/inspector/console/console-dir-expected.txt:
  • platform/chromium/inspector/console/console-format-collections-expected.txt:
  • platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
17:55 Changeset [113930] by fpizlo@apple.com
  • 29 edits in trunk/Source/JavaScriptCore

op_is_foo should be optimized
https://bugs.webkit.org/show_bug.cgi?id=83666

Reviewed by Gavin Barraclough.

This implements inlining of op_is_undefined, op_is_string, op_is_number,
and op_is_boolean in LLInt and the baseline JIT. op_is_object and
op_is_function are not inlined because they are quite a bit more complex.

This also implements all of the op_is_foo opcodes in the DFG, but it does
not do any type profiling based optimizations, yet.

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::compare8):
(MacroAssemblerARMv7):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::compare8):
(MacroAssemblerX86Common):

  • assembler/MacroAssemblerX86_64.h:

(MacroAssemblerX86_64):
(JSC::MacroAssemblerX86_64::testPtr):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCCallHelpers.h:

(JSC::DFG::CCallHelpers::setupArguments):
(CCallHelpers):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):
(JSC::DFG::SpeculativeJIT::appendCallSetResult):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

  • jit/JIT.h:

(JIT):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_is_undefined):
(JSC):
(JSC::JIT::emit_op_is_boolean):
(JSC::JIT::emit_op_is_number):
(JSC::JIT::emit_op_is_string):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_is_undefined):
(JSC):
(JSC::JIT::emit_op_is_boolean):
(JSC::JIT::emit_op_is_number):
(JSC::JIT::emit_op_is_string):

  • jit/JITStubs.cpp:

(JSC):

  • llint/LLIntSlowPaths.cpp:

(LLInt):

  • llint/LLIntSlowPaths.h:

(LLInt):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • offlineasm/armv7.rb:
  • offlineasm/instructions.rb:
  • offlineasm/x86.rb:
17:43 Changeset [113929] by dpranke@chromium.org
  • 4 edits in trunk/Tools

Fix regression introduced in r113927.

Unreviewed, build fix.

I failed to rename skipped_tests() to skipped_layout_tests()
everywhere it needed to be renamed. The unit tests didn't catch
this because the TestPort was one of the places that didn't get
renamed :(.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.parse_expectations):

  • Scripts/webkitpy/layout_tests/port/test.py:

(TestPort.skipped_layout_tests):

  • Scripts/webkitpy/tool/commands/queries.py:

(PrintExpectations._model):

17:29 Changeset [113928] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

If you use an IntegerOperand and want to return it with integerResult, you need to
zero extend to get rid of the box
https://bugs.webkit.org/show_bug.cgi?id=83734
<rdar://problem/11232296>

Reviewed by Oliver Hunt.

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):

17:13 Changeset [113927] by dpranke@chromium.org
  • 8 edits in trunk/Tools

new-run-webkit-tests: 'webkit-patch skipped-ports' introduced bad layering
https://bugs.webkit.org/show_bug.cgi?id=47528

Reviewed by Adam Barth.

The skipped-ports command has been replaced by 'webkit-patch
print-expectations', which offers the equivalent functionality
via 'webkit-patch print-expectations --platform \* -t skip'
(and other features, of course).

This also allows me to fix a nasty layering violation where the
chromium port had to know about the TestExpectations objects in
order to implement the command properly.

Lastly, this allows me to rename skipped_tests() to
skipped_layout_tests() to more consistent with
skipped_perf_tests().

This patch removes skips_layout_test() from the Port interface,
because that can't be implemented without the port knowing about
Expectations objects (and skipped-ports was the only thing using it).

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.skipped_layout_tests):
(Port.skipped_perf_tests):

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_default_configuration_notfound):

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.test_expectations_overrides):

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumPortTest.test_path_to_image_diff):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort.skipped_layout_tests):

  • Scripts/webkitpy/tool/commands/queries.py:

(execute):

  • Scripts/webkitpy/tool/commands/queries_unittest.py:

(QueryCommandsTest.test_tree_status):

16:46 Changeset [113926] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

Remove an autorelease pool made redundant by r113923.
https://bugs.webkit.org/show_bug.cgi?id=83730

Reviewed by Dan Bernstein.

Remove flushLayer()'s autorelease pool, since one now exists in the
call frame above it (in LayerFlushScheduler::runLoopObserverCallback()).

  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:

(WebKit::LayerTreeHostCAMac::flushLayers):

16:41 Changeset [113925] by antti@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix build with XSLT disabled.

Not reviewed.

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::parseStyleSheet):

16:32 April 2012 Meeting edited by adele@apple.com
(diff)
16:31 Changeset [113924] by arv@chromium.org
  • 8 edits in trunk

File API does not support DOM events (like addEventListener)
https://bugs.webkit.org/show_bug.cgi?id=83688

Reviewed by Adam Barth.

Source/WebCore:

The IDL files where missing addEventListener, removeEventListener and dispatchEvent.

Tests: fast/filesystem/file-writer-events.html

fast/speech/scripted/basics.html

  • Modules/filesystem/FileWriter.idl: Add missing methods.
  • Modules/mediastream/LocalMediaStream.idl: This one gets its EventTarget from MediaStream.
  • Modules/speech/SpeechRecognition.idl: Add missing methods.

LayoutTests:

  • fast/filesystem/resources/file-writer-events.js:

(runTest):

  • fast/speech/scripted/basics-expected.txt:
  • fast/speech/scripted/basics.html:
16:28 Changeset [113923] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

LayerFlushScheduler's run loop observer should have an autorelease pool.
https://bugs.webkit.org/show_bug.cgi?id=83729

Reviewed by Dan Bernstein.

LayerFlushScheduler's run loop observer needs an autorelease pool.
NSApplication creates one, but it is only drained after processing user
input. In the case where a WebView is displaying composited content but
not receiving user input, NSApplication's pool will accumulate a large
number of objects autoreleased by the run loop observer. Have
LayerFlushScheduler create an autorelease pool that is drained after
each run loop observer callback.

  • platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp:

(WebCore::LayerFlushScheduler::runLoopObserverCallback):

16:20 Changeset [113922] by antti@apple.com
  • 48 edits in trunk/Source

Split CSSStyleSheet into internal and CSSOM type
https://bugs.webkit.org/show_bug.cgi?id=83612

Reviewed by Andreas Kling.

This will complete the separation of our style sheet data structures from CSSOM.

The internal parts of CSSStyleSheet move to StyleSheetInternal. CSS parser
and style selector will now operate on internal types. Unlike other CSSOM types
CSSStyleSheets are still always instantiated to hold the top level author stylesheets
(by Nodes).

  • css/CSSFontFaceSrcValue.cpp:

(WebCore::CSSFontFaceSrcValue::addSubresourceStyleURLs):

  • css/CSSFontFaceSrcValue.h:

(CSSFontFaceSrcValue):

  • css/CSSImportRule.cpp:

(WebCore::StyleRuleImport::create):
(WebCore::StyleRuleImport::StyleRuleImport):
(WebCore::StyleRuleImport::setCSSStyleSheet):
(WebCore::StyleRuleImport::requestStyleSheet):
(WebCore::CSSImportRule::~CSSImportRule):
(WebCore):
(WebCore::CSSImportRule::styleSheet):

  • css/CSSImportRule.h:

(WebCore):
(StyleRuleImport):
(WebCore::StyleRuleImport::parentStyleSheet):
(WebCore::StyleRuleImport::styleSheet):
(CSSImportRule):

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::insertRule):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseSheet):
(WebCore::CSSParser::parseRule):
(WebCore::CSSParser::parseKeyframeRule):
(WebCore::CSSParser::parseFontFaceValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseSelector):
(WebCore::CSSParser::parseDeclaration):
(WebCore::CSSParser::setStyleSheet):
(WebCore::CSSParser::parseFlowThread):

  • css/CSSParser.h:

(WebCore):
(CSSParser):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::addSubresourceStyleURLs):

  • css/CSSPrimitiveValue.h:

(CSSPrimitiveValue):

  • css/CSSReflectValue.cpp:

(WebCore::CSSReflectValue::addSubresourceStyleURLs):

  • css/CSSReflectValue.h:

(CSSReflectValue):

  • css/CSSRule.h:

(CSSRule):

  • css/CSSStyleSelector.cpp:

(RuleSet):
(WebCore):
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::addAuthorRulesAndCollectUserRulesFromSheets):
(WebCore::CSSStyleSelector::determineScope):
(WebCore::CSSStyleSelector::appendAuthorStylesheets):
(WebCore::parseUASheet):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • css/CSSStyleSelector.h:

(CSSStyleSelector):

Add a set for root CSSStyleSheet objects so that the wrappers created in ensureFullCSSOMWrapperForInspector
stay valid.


  • css/CSSStyleSheet.cpp:

(WebCore::StyleSheetInternal::StyleSheetInternal):
(WebCore::StyleSheetInternal::~StyleSheetInternal):
(WebCore::StyleSheetInternal::parserAppendRule):
(WebCore::StyleSheetInternal::createChildRuleCSSOMWrapper):
(WebCore::StyleSheetInternal::ruleCount):
(WebCore::StyleSheetInternal::clearCharsetRule):
(WebCore::StyleSheetInternal::clearRules):
(WebCore::StyleSheetInternal::parserSetEncodingFromCharsetRule):
(WebCore::StyleSheetInternal::wrapperInsertRule):
(WebCore::StyleSheetInternal::wrapperDeleteRule):
(WebCore::StyleSheetInternal::addNamespace):
(WebCore::StyleSheetInternal::determineNamespace):
(WebCore::StyleSheetInternal::parseString):
(WebCore::StyleSheetInternal::parseStringAtLine):
(WebCore::StyleSheetInternal::isLoading):
(WebCore::StyleSheetInternal::checkLoaded):
(WebCore::StyleSheetInternal::notifyLoadedSheet):
(WebCore::StyleSheetInternal::startLoadingDynamicSheet):
(WebCore::StyleSheetInternal::findStyleSheetOwnerNode):
(WebCore::StyleSheetInternal::findDocument):
(WebCore::StyleSheetInternal::setMediaQueries):
(WebCore::StyleSheetInternal::styleSheetChanged):
(WebCore):
(WebCore::StyleSheetInternal::baseURL):
(WebCore::StyleSheetInternal::completeURL):
(WebCore::StyleSheetInternal::addSubresourceStyleURLs):
(WebCore::StyleSheetInternal::parentStyleSheet):
(WebCore::CSSStyleSheet::CSSStyleSheet):
(WebCore::CSSStyleSheet::~CSSStyleSheet):
(WebCore::CSSStyleSheet::setDisabled):
(WebCore::CSSStyleSheet::length):
(WebCore::CSSStyleSheet::item):
(WebCore::CSSStyleSheet::rules):
(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::addRule):
(WebCore::CSSStyleSheet::cssRules):
(WebCore::CSSStyleSheet::deleteRule):
(WebCore::CSSStyleSheet::media):
(WebCore::CSSStyleSheet::parentStyleSheet):

  • css/CSSStyleSheet.h:

(WebCore):
(WebCore::StyleSheetInternal::create):
(WebCore::StyleSheetInternal::createInline):
(StyleSheetInternal):
(WebCore::StyleSheetInternal::ownerNode):
(WebCore::StyleSheetInternal::clearOwnerNode):
(WebCore::StyleSheetInternal::ownerRule):
(WebCore::StyleSheetInternal::originalURL):
(WebCore::StyleSheetInternal::title):
(WebCore::StyleSheetInternal::setTitle):
(WebCore::StyleSheetInternal::setFinalURL):
(WebCore::StyleSheetInternal::finalURL):
(CSSStyleSheet):
(WebCore::CSSStyleSheet::create):
(WebCore::CSSStyleSheet::removeRule):
(WebCore::CSSStyleSheet::clearOwnerRule):
(WebCore::CSSStyleSheet::styleSheetChanged):
(WebCore::CSSStyleSheet::findDocument):
(WebCore::CSSStyleSheet::internal):
(WebCore::CSSStyleSheet::isCSSStyleSheet):
(WebCore::CSSStyleSheet::type):

  • css/CSSValue.cpp:

(WebCore::CSSValue::addSubresourceStyleURLs):

  • css/CSSValue.h:

(WebCore):
(CSSValue):

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::addSubresourceStyleURLs):

  • css/CSSValueList.h:

(CSSValueList):

  • css/CSSValuePool.cpp:

(WebCore::CSSValuePool::createFontFaceValue):

  • css/CSSValuePool.h:

(WebCore):
(CSSValuePool):

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):

  • css/PropertySetCSSStyleDeclaration.h:

(WebCore):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet::parseDeclaration):
(WebCore::StylePropertySet::addSubresourceStyleURLs):

  • css/StylePropertySet.h:

(WebCore):
(StylePropertySet):

  • css/StyleSheet.cpp:

(WebCore):

  • css/StyleSheet.h:

(StyleSheet):
(WebCore::StyleSheet::media):
(WebCore::StyleSheet::ownerRule):
(WebCore::StyleSheet::isXSLStyleSheet):

  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::insertRule):

  • dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createCSSStyleSheet):

  • dom/Document.cpp:

(WebCore::Document::updateBaseURL):
(WebCore::Document::pageUserSheet):
(WebCore::Document::pageGroupUserSheets):
(WebCore::Document::addUserSheet):
(WebCore::Document::elementSheet):
(WebCore::Document::testAddedStylesheetRequiresStyleRecalc):
(WebCore::Document::analyzeStylesheetChange):

  • dom/Document.h:

(WebCore):
(Document):
(WebCore::Document::documentUserSheets):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::updateInlineStyleAvoidingMutation):

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::setCSSStyleSheet):
(WebCore::ProcessingInstruction::parseStyleSheet):

  • dom/StyleElement.cpp:

(WebCore::StyleElement::createSheet):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::addSubresourceAttributeURLs):
(WebCore):
(WebCore::StyledElement::addPropertyToAttributeStyle):

  • dom/StyledElement.h:

(WebCore):

  • html/HTMLFontElement.cpp:

(WebCore::HTMLFontElement::collectStyleForAttribute):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::parseAttribute):
(WebCore::HTMLLinkElement::setCSSStyleSheet):
(WebCore::HTMLLinkElement::styleSheetIsLoading):
(WebCore::HTMLLinkElement::addSubresourceAttributeURLs):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::parseAttribute):
(WebCore::HTMLStyleElement::addSubresourceAttributeURLs):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::fillMediaListChain):
(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyleSheet::styleSheetURL):
(WebCore::InspectorStyleSheet::reparseStyleSheet):
(WebCore::InspectorStyleSheet::ensureSourceData):
(WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeCSSStyleSheet):

  • svg/SVGStyleElement.cpp:

(WebCore::SVGStyleElement::parseAttribute):

  • xml/XSLStyleSheet.h:

(XSLStyleSheet):
(WebCore::XSLStyleSheet::finalURL):

  • xml/XSLStyleSheetLibxslt.cpp:

(WebCore::XSLStyleSheet::XSLStyleSheet):
(WebCore::XSLStyleSheet::isLoading):

16:14 Changeset [113921] by commit-queue@webkit.org
  • 4 edits
    5 deletes in trunk

Unreviewed, rolling out r113912.
http://trac.webkit.org/changeset/113912
https://bugs.webkit.org/show_bug.cgi?id=83727

broke atsui-spacing-features.html on windows (Requested by
simonjam on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-11

Source/WebCore:

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::justify):

LayoutTests:

  • fast/text/international/arabic-justify.html: Removed.
  • platform/chromium-win/fast/text/international/arabic-justify-expected.png: Removed.
  • platform/chromium-win/fast/text/international/arabic-justify-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac-snowleopard/fast/text/international/arabic-justify-expected.png: Removed.
  • platform/mac-snowleopard/fast/text/international/arabic-justify-expected.txt: Removed.
16:08 Changeset [113920] by mrowe@apple.com
  • 2 edits in trunk/Tools

Remove a fprintf from LayoutTestController.

This fprintf is causing 100+MB of data to be written to stderr during a single run of the tests.
It was added for no apparent reason by Ryosuke in r113651.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::redirectionDestinationForURL):

15:52 Changeset [113919] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

SpeculativeJIT::fillStorage() should work with all the states that a cell may be in
https://bugs.webkit.org/show_bug.cgi?id=83722

Reviewed by Gavin Barraclough.

It's now possible to do StorageOperand on a cell, in the case that the storage is
inline. But this means that fillStorage() must be able to handle all of the states
that a cell might be in. Previously it didn't.

With this change, it now does handle all of the states, and moreover, it does so
by preserving the DataFormat of cells and performing all of the cell speculations
that should be performed if you're using a cell as storage. But if you use this on
something that is known to be storage already then it behaves as it did before.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::fillStorage):

15:48 Changeset [113918] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[chromium] When rendering goes idle, do not count that time against frame rate
https://bugs.webkit.org/show_bug.cgi?id=73454

The FPS counter had a few issues with its reporting. The first
3 swapbuffers are non-blocking and create FPS rates that are
unrealistically high, throwing off the moving averages and
introducing false spikes into the FPS graph. There was also no
way to monitor the smoothness of the animation, or to focus in
on a particular animation or transition.

This patch updates the FPS counter code so that bad data points
are trimmed and not graphed; so that the graph itself is taller
and more legible; so that there is a clear boundary between 40FPS
and better; and to keep statistics on frame rate between
pauses in the activity in the UI so that you can trigger a
transition and read off the average and standard deviation for
that transition to judge it smooth enough or not.

Patch by Alex Nicolaou <anicolao@chromium.org> on 2012-04-11
Reviewed by James Robinson.

HUD is not testable in webkit.

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
(WebCore::CCHeadsUpDisplay::onFrameBegin):
(WebCore::CCHeadsUpDisplay::drawHudContents):
(WebCore::CCHeadsUpDisplay::drawFPSCounter):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
15:47 April 2012 Meeting edited by jacobg@adobe.com
(diff)
15:47 April 2012 Meeting edited by jacobg@adobe.com
(diff)
15:44 Changeset [113917] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

Add two flaky plug-in tests.

  • platform/mac/Skipped:
15:38 Changeset [113916] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

Add tests that broke in r113900 to the Skipped list.

  • platform/mac/Skipped:
15:29 April 2012 Meeting edited by tomz@codeaurora.org
(diff)
15:25 April 2012 Meeting edited by rniwa@webkit.org
(diff)
15:12 Changeset [113915] by zmo@google.com
  • 4 edits in trunk/Source/WebCore

WebGLRenderingContext should defer caching program info
https://bugs.webkit.org/show_bug.cgi?id=83513

Reviewed by Kenneth Russell.

  • html/canvas/WebGLProgram.cpp:

(WebCore::WebGLProgram::WebGLProgram):
(WebCore::WebGLProgram::numActiveAttribLocations): call cacheInfoIfNeeded();
(WebCore::WebGLProgram::getActiveAttribLocation): Ditto.
(WebCore::WebGLProgram::isUsingVertexAttrib0): Ditto.
(WebCore::WebGLProgram::getLinkStatus): Ditto.
(WebCore):
(WebCore::WebGLProgram::cacheActiveAttribLocations):
(WebCore::WebGLProgram::cacheInfoIfNeeded): Cache link status, active attire locations, etc if needed.
(WebCore::WebGLProgram::increaseLinkCount): also invalidate cached info.

  • html/canvas/WebGLProgram.h:

(WebGLProgram):

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::linkProgram): Do not cache program info immediately.

15:04 Changeset [113914] by commit-queue@webkit.org
  • 13 edits
    4 adds in trunk

Add keySystem attribute to canPlayType() for Encrypted Media Extensions
https://bugs.webkit.org/show_bug.cgi?id=82973

Patch by David Dorwin <ddorwin@chromium.org> on 2012-04-11
Reviewed by Adam Barth.

The new attribute is behind the ENABLE(ENCRYPTED_MEDIA) feature define.
Implementation is based on v0.1 of the draft proposal at
http://dvcs.w3.org/hg/html-media/raw-file/tip/encrypted-media/encrypted-media.html#extensions.

Source/Platform:

  • chromium/public/WebMimeRegistry.h:

(WebKit::WebMimeRegistry::supportsMediaMIMEType):

Source/WebCore:

Tests: media/encrypted-media/encrypted-media-can-play-type-webm.html

media/encrypted-media/encrypted-media-can-play-type.html

  • dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createDocument):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::canPlayType):
(WebCore::HTMLMediaElement::selectMediaResource):
(WebCore::HTMLMediaElement::loadNextSourceChild):
(WebCore::HTMLMediaElement::loadResource):
(WebCore::HTMLMediaElement::havePotentialSourceChild):
(WebCore::HTMLMediaElement::selectNextSourceChild):
(WebCore::HTMLMediaElement::getPluginProxyParams):

  • html/HTMLMediaElement.h:

(HTMLMediaElement):

  • html/HTMLMediaElement.idl:
  • platform/graphics/MediaPlayer.cpp:

(WebCore):
(WebCore::bestMediaEngineForTypeAndCodecs):
(WebCore::MediaPlayer::load):
(WebCore::MediaPlayer::loadWithNextMediaEngine):
(WebCore::MediaPlayer::supportsType):
(WebCore::MediaPlayer::networkStateChanged):

  • platform/graphics/MediaPlayer.h:

(MediaPlayer):
(WebCore):

Source/WebKit/chromium:

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::supportsType):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

LayoutTests:

  • media/encrypted-media/encrypted-media-can-play-type-expected.txt: Added.
  • media/encrypted-media/encrypted-media-can-play-type-webm-expected.txt: Added.
  • media/encrypted-media/encrypted-media-can-play-type-webm.html: Added.
  • media/encrypted-media/encrypted-media-can-play-type.html: Added.
14:43 Changeset [113913] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

[Qt] InspectorServer: Add an API level auto test
https://bugs.webkit.org/show_bug.cgi?id=83594

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2012-04-10
Reviewed by Kenneth Rohde Christiansen.

  • Source/tests.pri:
14:42 Changeset [113912] by xji@chromium.org
  • 4 edits
    5 adds in trunk

[chromium] wrong justification for arabic/persian page in cr-win.
https://bugs.webkit.org/show_bug.cgi?id=83227

Reviewed by Kent Tamura.

Source/WebCore:

GDI used to do Kashida justification.
After switch to Skia, we need to use space padding to justify the text
(assume Skia can not do Kashida justification -- stretching words).

Test: fast/text/international/arabic-justify.html

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::justify):

LayoutTests:

  • fast/text/international/arabic-justify.html: Added.
  • platform/chromium-win/fast/text/international/arabic-justify-expected.png: Added.
  • platform/chromium-win/fast/text/international/arabic-justify-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac-snowleopard/fast/text/international/arabic-justify-expected.png: Added.
  • platform/mac-snowleopard/fast/text/international/arabic-justify-expected.txt: Added.
14:33 Changeset [113911] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r113885.

  • platform/gtk/css2.1/20110323/replaced-elements-001-expected.txt:
14:27 Changeset [113910] by tonikitoo@webkit.org
  • 4 edits in trunk/LayoutTests

All Mac bots occasionally fail tons of media/ sputnik/ and svg/ tests
https://bugs.webkit.org/show_bug.cgi?id=83411

Reviewed by Eric Carlson.
Patch by Antonio Gomes <agomes@rim.com>

Fix obvious problems with the test in order to make tests lets
flaky.

  • media/nodesFromRect-shadowContent.html:
  • platform/gtk/media/nodesFromRect-shadowContent-expected.txt:
14:07 Changeset [113909] by mrobinson@webkit.org
  • 9 edits
    1 copy
    1 add in trunk

[CAIRO] Make GLContextGLX a subclass of GLContext
https://bugs.webkit.org/show_bug.cgi?id=81285

Reviewed by Gustavo Noronha Silva.

.:

  • GNUmakefile.am: Add a configuration option for activating GLX.

This is selected automatically now, but in the future there will be
the choice to turn on EGL and turn off GLX at compilation time.

  • configure.ac: Ditto.

Source/WebCore:

No new tests. This should not change behavior.

  • GNUmakefile.list.am: Add new GLContextGLX files.
  • platform/graphics/cairo/GLContext.cpp: Added. Composed of the

EGL/GLX independent portions of GLContext. Made the current context
a static variable so we can keep getting the current context platform-
-independent.

  • platform/graphics/cairo/GLContext.h: Make this class an abstract

class. GLContextGLX is a concrete implementation.

  • platform/graphics/cairo/GraphicsContext3DPrivate.cpp: Updated to reflect

slightly different calling conventions to create a sharing context.

  • platform/graphics/glx/GLContextGLX.cpp: Updated to reflect

that this code is in a subclass now.

  • platform/graphics/glx/GLContextGLX.h: Copied from Source/WebCore/platform/graphics/cairo/GLContext.h.
  • platform/graphics/gtk/GLContextGtk.cpp:

(WebCore::GLContext::getContextForWidget): Updated to respect the new
USE(GLX) flag.

14:03 Changeset [113908] by rniwa@webkit.org
  • 3 edits
    2 adds
    30 deletes in trunk/LayoutTests

fast/dom/dom-parse-serialize.html and dom-parse-serialize-display.html should be text tests
https://bugs.webkit.org/show_bug.cgi?id=83715

Reviewed by Rob Buis.

Converted the fast/dom/dom-parse-serialize.html and dom-parse-serialize-display.html to dumpAsText tests.

  • fast/dom/dom-parse-serialize-display-expected.txt: Added.
  • fast/dom/dom-parse-serialize-display.html:
  • fast/dom/dom-parse-serialize-expected.txt: Added.
  • fast/dom/dom-parse-serialize.html:
  • platform/chromium-linux/fast/dom/dom-parse-serialize-display-expected.png: Removed.
  • platform/chromium-linux/fast/dom/dom-parse-serialize-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/dom/dom-parse-serialize-display-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/dom/dom-parse-serialize-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/dom/dom-parse-serialize-display-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/dom/dom-parse-serialize-expected.png: Removed.
  • platform/chromium-mac/fast/dom/dom-parse-serialize-display-expected.png: Removed.
  • platform/chromium-mac/fast/dom/dom-parse-serialize-expected.png: Removed.
  • platform/chromium-win/fast/dom/dom-parse-serialize-display-expected.png: Removed.
  • platform/chromium-win/fast/dom/dom-parse-serialize-display-expected.txt: Removed.
  • platform/chromium-win/fast/dom/dom-parse-serialize-expected.png: Removed.
  • platform/chromium-win/fast/dom/dom-parse-serialize-expected.txt: Removed.
  • platform/efl/fast/dom/dom-parse-serialize-display-expected.png: Removed.
  • platform/efl/fast/dom/dom-parse-serialize-display-expected.txt: Removed.
  • platform/efl/fast/dom/dom-parse-serialize-expected.png: Removed.
  • platform/efl/fast/dom/dom-parse-serialize-expected.txt: Removed.
  • platform/gtk/fast/dom/dom-parse-serialize-display-expected.png: Removed.
  • platform/gtk/fast/dom/dom-parse-serialize-display-expected.txt: Removed.
  • platform/gtk/fast/dom/dom-parse-serialize-expected.png: Removed.
  • platform/gtk/fast/dom/dom-parse-serialize-expected.txt: Removed.
  • platform/mac-leopard/fast/dom/dom-parse-serialize-display-expected.png: Removed.
  • platform/mac-leopard/fast/dom/dom-parse-serialize-expected.png: Removed.
  • platform/mac/fast/dom/dom-parse-serialize-display-expected.png: Removed.
  • platform/mac/fast/dom/dom-parse-serialize-display-expected.txt: Removed.
  • platform/mac/fast/dom/dom-parse-serialize-expected.png: Removed.
  • platform/mac/fast/dom/dom-parse-serialize-expected.txt: Removed.
  • platform/qt/fast/dom/dom-parse-serialize-display-expected.png: Removed.
  • platform/qt/fast/dom/dom-parse-serialize-display-expected.txt: Removed.
  • platform/qt/fast/dom/dom-parse-serialize-expected.png: Removed.
  • platform/qt/fast/dom/dom-parse-serialize-expected.txt: Removed.
13:57 Changeset [113907] by leviw@chromium.org
  • 7 edits
    3 adds in branches/subpixellayout

Fixing a truncation of length values that was occuring after a refactor in LengthFunctions and dealing with the repercussions in RenderMarquee, Document, and RenderFrameSet. Also correcting a table border painting issue evident in fast/multicol/table-vertical-align that only crops up in multi-column tables. We must floor the size when painting the Table's decorations because we ultimately lay out the contents using flooring.

13:51 Changeset [113906] by fpizlo@apple.com
  • 10 edits
    1 delete in trunk/Source/JavaScriptCore

Global variable predictions should not be coalesced unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=83678

Reviewed by Geoff Garen.

Removed the PredictionTracker and everyone who used it. Converted GetGlobalVar
to have a heapPrediction like a civilized DFG opcode ought to.

No performance effect.

  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/CodeBlock.h:
  • bytecode/PredictionTracker.h: Removed.
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGenerationInfo.h:
  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:

(Graph):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasHeapPrediction):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

13:34 Changeset [113905] by tomz@codeaurora.org
  • 15 edits
    67 moves
    10 adds in trunk/LayoutTests

Unreviewed gardening and fix naming on EFL expected.txt files

  • platform/chromium-linux/fast/text/text-shadow-no-default-color-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png:
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png:
  • platform/chromium-mac-leopard/fast/text/text-shadow-no-default-color-expected.png: Added.
  • platform/chromium-mac-leopard/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png:
  • platform/chromium-mac-leopard/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/text-shadow-no-default-color-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png:
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png:
  • platform/chromium-mac/fast/text/text-shadow-no-default-color-expected.png: Added.
  • platform/chromium-mac/fast/text/text-shadow-no-default-color-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png:
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png:
  • platform/chromium-win/fast/text/text-shadow-no-default-color-expected.png: Added.
  • platform/chromium-win/fast/text/text-shadow-no-default-color-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/efl/fast/text/text-shadow-no-default-color-expected.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background-color-border-box-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-002-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-001-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-002-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-003-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-004-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/color-behind-images-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/order-of-images-actual.txt.
  • platform/efl/ietestcenter/css3/text/textshadow-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-001-actual.txt.
  • platform/efl/ietestcenter/css3/text/textshadow-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-002-actual.txt.
  • platform/efl/ietestcenter/css3/text/textshadow-003-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-003-actual.txt.
  • platform/efl/ietestcenter/css3/text/textshadow-004-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-004-actual.txt.
  • platform/efl/ietestcenter/css3/text/textshadow-005-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-005-actual.txt.
  • platform/efl/ietestcenter/css3/text/textshadow-006-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-006-actual.txt.
  • platform/efl/ietestcenter/css3/text/textshadow-007-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-007-actual.txt.
  • platform/efl/ietestcenter/css3/text/textshadow-008-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-008-actual.txt.
  • platform/efl/ietestcenter/css3/text/textshadow-009-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-009-actual.txt.
  • platform/efl/ietestcenter/css3/text/textshadow-010-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-010-actual.txt.
  • platform/efl/test_expectations.txt:
  • platform/mac/fast/text/text-shadow-no-default-color-expected.txt: Added.
  • platform/mac/test_expectations.txt:
  • platform/qt/fast/text/text-shadow-no-default-color-expected.txt: Added.
  • platform/qt/test_expectations.txt:
13:26 Changeset [113904] by lforschler@apple.com
  • 5 edits in branches/safari-534.57-branch/Source

Versioning.

13:25 Changeset [113903] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Upstream BlackBerry change to PatternSkia.cpp
https://bugs.webkit.org/show_bug.cgi?id=83361

Reviewed by Antonio Gomes.

Upstream a cleaned up version.

  • platform/graphics/skia/PatternSkia.cpp:

(WebCore::Pattern::platformDestroy):
(WebCore::Pattern::platformPattern):

13:19 Changeset [113902] by jamesr@google.com
  • 25 edits in trunk/Source

[chromium] Add OVERRIDE annotations for cc layer types
https://bugs.webkit.org/show_bug.cgi?id=83658

Reviewed by Daniel Bates.

This adds OVERRIDE annotations to overrides of functions on these classes:

  • CCLayerImpl
  • LayerChromium
  • TiledLayerChromium

Source/WebCore:

  • platform/graphics/chromium/Canvas2DLayerChromium.h:

(Canvas2DLayerChromium):

  • platform/graphics/chromium/CanvasLayerChromium.h:

(CanvasLayerChromium):

  • platform/graphics/chromium/ContentLayerChromium.h:

(ContentLayerChromium):

  • platform/graphics/chromium/ImageLayerChromium.h:

(ImageLayerChromium):

  • platform/graphics/chromium/PluginLayerChromium.h:

(PluginLayerChromium):

  • platform/graphics/chromium/TiledLayerChromium.h:

(TiledLayerChromium):

  • platform/graphics/chromium/VideoLayerChromium.h:

(VideoLayerChromium):

  • platform/graphics/chromium/WebGLLayerChromium.h:

(WebGLLayerChromium):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:

(CCScrollbarLayerImpl):

  • platform/graphics/chromium/cc/CCSolidColorLayerImpl.h:

(CCSolidColorLayerImpl):

  • platform/graphics/chromium/cc/CCTextureLayerImpl.h:

(CCTextureLayerImpl):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:

(CCTiledLayerImpl):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:

(CCVideoLayerImpl):

Source/WebKit/chromium:

  • src/WebLayerImpl.cpp:
  • src/WebLayerImpl.h:

(WebLayerImpl): Removed unused and empty paintContents() function.

  • tests/CCLayerIteratorTest.cpp:
  • tests/CCLayerTreeHostCommonTest.cpp:
  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:
  • tests/CCOcclusionTrackerTest.cpp:
  • tests/CCTiledLayerTestCommon.h:

(FakeTiledLayerChromium):

  • tests/LayerChromiumTest.cpp:
  • tests/TreeSynchronizerTest.cpp:
13:16 Changeset [113901] by thakis@chromium.org
  • 2 edits in trunk/Tools

[mac] Suppress deprecation warning for GlobalToLocal in the carbon parts of the test plugin.
https://bugs.webkit.org/show_bug.cgi?id=83709

Reviewed by Anders Carlsson.

  • DumpRenderTree/TestNetscapePlugIn/main.cpp:

(handleEventCarbon):

13:13 Changeset [113900] by ap@apple.com
  • 6 edits
    4 adds in trunk

[Mac] lang, xml:lang, content-language ignored when choosing fonts
https://bugs.webkit.org/show_bug.cgi?id=10874
<rdar://problem/3220202>

Reviewed by Dan Bernstein.

Adding a default font table for Mac port. Clients can still override these if they want to,
but knowing which fonts to use is more about the platform than about the client.

Tests: platform/mac/fonts/han-disunification.html

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • Resources/DefaultFonts.plist.in: Added. Added SettingsMac.mm. Added preprocessed property list with default fonts.
  • page/Settings.cpp: (WebCore::setGenericFontFamilyMap): Don't notify the page if we don't have one yet. (WebCore::Settings::Settings): Assign to m_page after calling initializeDefaultFontFamilies, so that we won't try to call page->setNeedsRecalcStyleInAllFrames() in a half-initialized Page that's creating settings. (WebCore::Settings::initializeDefaultFontFamilies): Dummy imlplementation for ports that rely on client to set defaults.
  • page/Settings.h: Added initializeDefaultFontFamilies().
  • page/mac/SettingsMac.mm: Added. (WebCore::defaultFontFamilyDictionary): (WebCore::Settings::initializeDefaultFontFamilies): Load defaults from a plist file inside WebCore framework.
13:05 Changeset [113899] by simonjam@chromium.org
  • 9 edits
    5 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium-linux/css2.1/20110323/replaced-elements-001-expected.png:
  • platform/chromium-linux/css2.1/20110323/replaced-elements-001-expected.txt:
  • platform/chromium-linux/fast/block/float/avoiding-float-centered-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/replaced-elements-001-expected.png:
  • platform/chromium-mac-snowleopard/fast/block/float/avoiding-float-centered-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/replaced-elements-001-expected.png:
  • platform/chromium-mac/fast/block/float/avoiding-float-centered-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/replaced-elements-001-expected.png:
  • platform/chromium-win/css2.1/20110323/replaced-elements-001-expected.txt:
  • platform/chromium-win/fast/block/float/avoiding-float-centered-expected.png: Added.
  • platform/chromium-win/fast/block/float/avoiding-float-centered-expected.txt: Added.
  • platform/chromium-win/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt:
  • platform/chromium/test_expectations.txt:
13:03 Changeset [113898] by antti@apple.com
  • 3 edits
    2 adds in trunk

Crash in CSSStyleSheet::deleteRule
https://bugs.webkit.org/show_bug.cgi?id=83708

Source/WebCore:

Reviewed by Andreas Kling.

Andreas spotted that the wrapper needs to be null checked before calling setParentStyleSheet(0).

Test: fast/css/delete-rule-crash.html

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::deleteRule):

LayoutTests:

Reviewed by Andreas Kling.

  • fast/css/delete-rule-crash.html: Added.
  • fast/css/delete-rule-crash-expected.txt: Added.
13:00 Changeset [113897] by adamk@chromium.org
  • 10 edits in trunk

[MutationObservers] Setting an attributeFilter should filter out all namespaced attribute mutations
https://bugs.webkit.org/show_bug.cgi?id=83706

Reviewed by Ryosuke Niwa.

Source/WebCore:

The patch amounts to plumbing QualifiedName all the way down to shouldReceiveMutationFrom
as it now needs to know about namespaceURI as well as localName.

This change is coming soon to the DOM4 spec, see
https://www.w3.org/Bugs/Public/show_bug.cgi?id=16563 for more discussion.

  • dom/MutationObserverInterestGroup.cpp:

(WebCore::MutationObserverInterestGroup::createIfNeeded):

  • dom/MutationObserverInterestGroup.h:

(WebCore::MutationObserverInterestGroup::createForChildListMutation):
(WebCore::MutationObserverInterestGroup::createForCharacterDataMutation):
(WebCore::MutationObserverInterestGroup::createForAttributesMutation):
(MutationObserverInterestGroup):

  • dom/MutationObserverRegistration.cpp:

(WebCore::MutationObserverRegistration::shouldReceiveMutationFrom):

  • dom/MutationObserverRegistration.h:

(WebCore):
(MutationObserverRegistration):

  • dom/Node.cpp:

(WebCore::Node::collectMatchingObserversForMutation):
(WebCore::Node::getRegisteredMutationObserversOfType):

  • dom/Node.h:

(Node):

LayoutTests:

Updated attributes test to match new behavior.

  • fast/mutation/observe-attributes-expected.txt:
  • fast/mutation/observe-attributes.html:
13:00 Changeset [113896] by lforschler@apple.com
  • 1 copy in branches/safari-534.57-branch

New Branch.

12:52 Changeset [113895] by rafael.lobo@openbossa.org
  • 2 edits in trunk/Tools

Adding myself to committers.py
https://bugs.webkit.org/show_bug.cgi?id=83711

Unreviewed update to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
12:51 Changeset [113894] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

Add two more DOM storage tests to the Skipped list.

  • platform/mac/Skipped:
12:45 Changeset [113893] by commit-queue@webkit.org
  • 7 edits in trunk

[EFL] LayoutTestController needs implementation of pageProperty
https://bugs.webkit.org/show_bug.cgi?id=82449

Source/WebKit/efl:

Add missing implementation pageProperty to EFL's
DumpRenderTreeSupport.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-11
Reviewed by Antonio Gomes.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::pageProperty):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Add missing implementation pageProperty to EFL's LayoutTestController
in order to unskip printing/page-rule-selection.html

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-11
Reviewed by Antonio Gomes.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::pageProperty):

LayoutTests:

Unskip printing/page-rule-selection.html

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-11
Reviewed by Antonio Gomes.

  • platform/efl/Skipped:
12:40 Changeset [113892] by andersca@apple.com
  • 1 edit
    2 moves in trunk/LayoutTests

Move fast/js/navigator-language.html to platform/qt
https://bugs.webkit.org/show_bug.cgi?id=83710

Reviewed by Ryosuke Niwa.

This test was for a Qt specific bug, and using setlocale on Mac will not update the preferred language correctly.

  • platform/qt/fast/js/navigator-language-expected.txt: Renamed from LayoutTests/fast/js/navigator-language-expected.txt.
  • platform/qt/fast/js/navigator-language.html: Renamed from LayoutTests/fast/js/navigator-language.html.
12:39 Changeset [113891] by schenney@chromium.org
  • 3 edits in trunk/LayoutTests

[Chromium/Linux] fonts-glyph-04-t.svg fails after r87152
https://bugs.webkit.org/show_bug.cgi?id=61370

Unreviewed Chromium linux expectations update.

This test is now behaving like Mac. No complaints there, just a font change.

  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.png:
  • platform/chromium/test_expectations.txt:
12:33 Changeset [113890] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] svg/wicd/test-rightsizing-a.xhtml is flaky
https://bugs.webkit.org/show_bug.cgi?id=66320

Unreviewed Chromium test expectations cleanup.

This test had been fixed some time ago and has no appearance in the flakiness board.

  • platform/chromium/test_expectations.txt:
12:26 Changeset [113889] by commit-queue@webkit.org
  • 6 edits
    1 copy
    1 add in trunk

add stereo source support in EqualPowerPanner
https://bugs.webkit.org/show_bug.cgi?id=81092

Patch by Wei James <james.wei@intel.com> on 2012-04-11
Reviewed by Chris Rogers.

Source/WebCore:

Test: webaudio/panner-equalpower-stereo.html

  • platform/audio/EqualPowerPanner.cpp:

(WebCore::EqualPowerPanner::pan):

LayoutTests:

  • webaudio/panner-equalpower-stereo-expected.txt: Added.
  • webaudio/panner-equalpower-stereo.html: Copied from LayoutTests/webaudio/panner-equalpower.html.
  • webaudio/panner-equalpower.html:
  • webaudio/resources/audio-testing.js:

(createStereoImpulseBuffer):

  • webaudio/resources/panner-model-testing.js:

(createGraph):
(createTestAndRun):
(equalPowerGain):
(checkResult):

12:23 Changeset [113888] by schenney@chromium.org
  • 4 edits
    1 add in trunk/LayoutTests

[chromium] Need new image baseline for svg/dom/SVGTransformList-basics.xhtml
https://bugs.webkit.org/show_bug.cgi?id=63036

Unreviewed Chromium test expectations update.

  • platform/chromium-mac-leopard/svg/dom/SVGTransformList-basics-expected.png:
  • platform/chromium-mac-snowleopard/svg/dom/SVGTransformList-basics-expected.png:
  • platform/chromium-mac/svg/dom/SVGTransformList-basics-expected.png: Added.
  • platform/chromium/test_expectations.txt:
12:21 Changeset [113887] by arv@chromium.org
  • 6 edits
    4 adds in trunk

StyleElement ownerNode is not cleared correctly
https://bugs.webkit.org/show_bug.cgi?id=83696

Reviewed by Antti Koivisto.

Source/WebCore:

When the css text changes in such a way that we remove the sheet of a style element or a link[rel=stylesheet]
element we need to ensure that the ownerNode of the sheet is cleared. If we don't do this and there is a
wrapper for the sheet the sheet is kept alive but the ownerNode of the sheet may point to a deleted node.

Tests: fast/dom/StyleSheet/detached-sheet-owner-node-link.html

fast/dom/StyleSheet/detached-sheet-owner-node.html

  • dom/StyleElement.cpp:

(WebCore::StyleElement::removedFromDocument):
(WebCore::StyleElement::clearSheet):
(WebCore):
(WebCore::StyleElement::createSheet):

  • dom/StyleElement.h:

(StyleElement):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::clearSheet):
(WebCore):

  • html/HTMLLinkElement.h:

(HTMLLinkElement):

LayoutTests:

  • fast/dom/StyleSheet/detached-sheet-owner-node-expected.txt: Added.
  • fast/dom/StyleSheet/detached-sheet-owner-node-link-expected.txt: Added.
  • fast/dom/StyleSheet/detached-sheet-owner-node-link.html: Added.
  • fast/dom/StyleSheet/detached-sheet-owner-node.html: Added.
12:09 Changeset [113886] by benjamin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Optimize String.split() for 1 character separator
https://bugs.webkit.org/show_bug.cgi?id=83546

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-11
Reviewed by Gavin Barraclough.

This patch adds a serie of optimizations to make stringProtoFuncSplit() faster in the common case
where the separator is a single character.

The two main gains are:
-Use of the find() function with a single character instead of doing a full string matching.
-Use of WTF::find() instead of UString::find() to avoid branching on is8Bit() and have a simpler inline

function.

The code is also changed to avoid making unnecessary allocations by converting the 8bit string to 16bits.

This makes String.split() faster by about 13% in that particular case.

  • runtime/StringPrototype.cpp:

(JSC):
(JSC::splitStringByOneCharacterImpl):
(JSC::stringProtoFuncSplit):

11:35 Changeset [113885] by hyatt@apple.com
  • 9 edits
    3 adds in trunk

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=83614
<rdar://problem/11177351>

REGRESSION: Table on wikipedia overlaps float on right hand side.

Revise how auto margins are resolved so that for objects that avoid floats, the available line
width is always used instead of the overall containing block width. computeLogicalWidth now
always properly computes inline margins (based off the object's current logicalTop() position)
and so the code in computeStartPositionDeltaForChildAvoidingFloats that recomputes inline
direction margins can now be removed.

Reviewed by Dan Bernstein.

Added new test in fast/block/float.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats):
(WebCore::RenderBlock::determineLogicalLeftPositionForChild):

  • rendering/RenderBlock.h:

(RenderBlock):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::containingBlockAvailableLineWidthInRegion):
(WebCore):
(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::renderBoxRegionInfo):
(WebCore::RenderBox::shrinkToAvoidFloats):

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=83614

Improve how auto margins are handled on objects that avoid floats. Add a new test covering this
for tables and overflow sections and revise existing results. The CSS2.1 test in particular is
a progression.

Reviewed by Dan Bernstein.

  • fast/block/float/avoiding-float-centered.html: Added.
  • platform/mac/css2.1/20110323/replaced-elements-001-expected.txt:
  • platform/mac/fast/block/float/avoiding-float-centered-expected.png: Added.
  • platform/mac/fast/block/float/avoiding-float-centered-expected.txt: Added.
  • platform/mac/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt:
11:30 Changeset [113884] by tomz@codeaurora.org
  • 2 edits
    71 adds in trunk/LayoutTests

Unreviewed gardening. Found EFL results.

  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-color-border-box-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-002-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-002-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-003-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-004-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/color-behind-images-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/order-of-images-actual.txt: Added.
  • platform/efl/ietestcenter/css3/text/textshadow-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/text/textshadow-002-actual.txt: Added.
  • platform/efl/ietestcenter/css3/text/textshadow-003-actual.txt: Added.
  • platform/efl/ietestcenter/css3/text/textshadow-004-actual.txt: Added.
  • platform/efl/ietestcenter/css3/text/textshadow-005-actual.txt: Added.
  • platform/efl/ietestcenter/css3/text/textshadow-006-actual.txt: Added.
  • platform/efl/ietestcenter/css3/text/textshadow-007-actual.txt: Added.
  • platform/efl/ietestcenter/css3/text/textshadow-008-actual.txt: Added.
  • platform/efl/ietestcenter/css3/text/textshadow-009-actual.txt: Added.
  • platform/efl/ietestcenter/css3/text/textshadow-010-actual.txt: Added.
  • platform/efl/test_expectations.txt:
11:20 Changeset [113883] by enne@google.com
  • 3 edits
    3 adds in trunk

Fix regression where a clip style change did not update layer sizes
https://bugs.webkit.org/show_bug.cgi?id=82990

Reviewed by Simon Fraser.

Source/WebCore:

After r111456, the size of composited layers also used clip, whereas
it previously had only used overflow. Because of this, when clip
changes on a render layer, it needs to recalculate its layer tree.

Test: compositing/clip-change.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::styleChanged):

LayoutTests:

  • compositing/clip-change-expected.png: Added.
  • compositing/clip-change-expected.txt: Added.
  • compositing/clip-change.html: Added.
11:19 April 2012 Meeting edited by jchaffraix@webkit.org
Added a topic + myself to some existing proposals (diff)
11:03 Changeset [113882] by tomz@codeaurora.org
  • 3 edits
    142 adds in trunk/LayoutTests

Expectations update after 81936 and 82734
https://bugs.webkit.org/show_bug.cgi?id=81936

Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-04-11
Reviewed by Adam Barth.

  • platform/mac/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.txt: Added.
  • platform/mac/ietestcenter/css3/text/textshadow-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/text/textshadow-002-expected.txt: Added.
  • platform/mac/ietestcenter/css3/text/textshadow-003-expected.txt: Added.
  • platform/mac/ietestcenter/css3/text/textshadow-004-expected.txt: Added.
  • platform/mac/ietestcenter/css3/text/textshadow-005-expected.txt: Added.
  • platform/mac/ietestcenter/css3/text/textshadow-006-expected.txt: Added.
  • platform/mac/ietestcenter/css3/text/textshadow-007-expected.txt: Added.
  • platform/mac/ietestcenter/css3/text/textshadow-008-expected.txt: Added.
  • platform/mac/ietestcenter/css3/text/textshadow-009-expected.txt: Added.
  • platform/mac/ietestcenter/css3/text/textshadow-010-expected.txt: Added.
  • platform/mac/test_expectations.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.txt: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-002-expected.txt: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-003-expected.txt: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-004-expected.txt: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-005-expected.txt: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-006-expected.txt: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-007-expected.txt: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-008-expected.txt: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-009-expected.txt: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-010-expected.txt: Added.
  • platform/qt/test_expectations.txt:
11:02 Changeset [113881] by antti@apple.com
  • 13 edits in trunk/Source/WebCore

V8 bindings are polluting WebCore namespace with overly generic FooInternal namespaces
https://bugs.webkit.org/show_bug.cgi?id=83699

Reviewed by Adam Barth.

Call them FooV8Internal instead.

  • bindings/scripts/CodeGeneratorV8.pm:

(GetFunctionTemplateCallbackName):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):

10:58 Changeset [113880] by jamesr@google.com
  • 7 edits in trunk/Source

[chromium] Add OVERRIDE annotations for cc animation-related interfaces
https://bugs.webkit.org/show_bug.cgi?id=83650

Reviewed by Daniel Bates.

This adds OVERRIDE annotations to the implementations of the following interfaces:

  • CCAnimationCurve
  • CCFloatAnimationCurve
  • CCLayerAnimationControllerClient
  • CCTransformAnimationCurve

Source/WebCore:

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/cc/CCTimingFunction.h:
  • platform/graphics/chromium/cc/CCKeyframedAnimationCurve.h:

(CCKeyframedFloatAnimationCurve):
(CCKeyframedTransformAnimationCurve):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

Source/WebKit/chromium:

  • tests/CCAnimationTestCommon.h:
10:50 Changeset [113879] by pdr@google.com
  • 4 edits
    2 adds in trunk

Fix bug where stroke's bounding box was clipped
https://bugs.webkit.org/show_bug.cgi?id=83651

Reviewed by Dirk Schulze.

Source/WebCore:

This change contains two fixes for one bug:
1) FloatRect::contains contained a nasty mistake where

maxy() < y() was compared instead of maxy() < point.y().

2) RenderSVGShape::strokeContains was depending on its internal

m_strokeAndMarkerBoundingBox instead of calling the virtual
method strokeBoundingBox(). This change switches to using
strokeBoundingBox().

Test: svg/hittest/svg-ellipse-rect-stroke.xhtml

  • platform/graphics/FloatRect.cpp:

(WebCore::FloatRect::contains):

  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::strokeContains):

LayoutTests:

  • svg/hittest/svg-ellipse-rect-stroke-expected.txt: Added.
  • svg/hittest/svg-ellipse-rect-stroke.xhtml: Added.
10:45 Changeset [113878] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Enable the [Supplemental] IDL on BlackBerry
https://bugs.webkit.org/show_bug.cgi?id=75413

Reviewed by Rob Buis.

This patch enables the [Supplemental] IDL on BlackBerry by changing the build
flow of BlackBerry as follows.

  • Previous build flow:

foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl;
generate-bindings.pl reads $idl;
generate-bindings.pl generates .h and .cpp files for $idl;

}

  • New build flow (See the discussions in bug 72138 for more details):

preprocess-idls.pl depends on all IDL files;
preprocess-idls.pl reads all IDL files;
preprocess-idls.pl resolves the dependency of [Supplemental=XXXX];
preprocess-idls.pl outputs supplemental_dependency.tmp;
foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
generate-bindings.pl reads $idl;
generate-bindings.pl reads supplemental_dependency.tmp;
generate-bindings.pl generates .h and .cpp files for $idl,

including all attributes in the IDL files that are implementing $idl;

}

Tests: Confirm that build succeeds.

http/tests/websocket/tests/*

  • PlatformBlackBerry.cmake: This change is similar to the change we have done for

UseJSC.cmake and UseV8.cmake (bug 75345).

10:44 Changeset [113877] by commit-queue@webkit.org
  • 12 edits in trunk

Unreviewed, rolling out r113836.
http://trac.webkit.org/changeset/113836
https://bugs.webkit.org/show_bug.cgi?id=83705

Broke all the WebKit2 inspector tests (Requested by andersca
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-11

Source/WebKit/win:

  • WebCoreSupport/WebInspectorClient.cpp:

(registerWindowClass):

(WebInspector::setTimelineProfilingEnabled):

  • WebNodeHighlight.cpp:

(WebNodeHighlight::WebNodeHighlight):
(WebNodeHighlight::update):

  • WebNodeHighlight.h:

(WebNodeHighlight):

  • WebView.cpp:

(WebView::WebView):
(WebView::close):
(WebView::initWithFrame):
(WebView::inspector):

  • WebView.h:

(WebView):

Tools:

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::showWebInspector):
(WTR::LayoutTestController::closeWebInspector):
(WTR::LayoutTestController::evaluateInWebInspector):
(WTR::LayoutTestController::setJavaScriptProfilingEnabled):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(LayoutTestController):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::invoke):

10:36 Changeset [113876] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r113872.
http://trac.webkit.org/changeset/113872
https://bugs.webkit.org/show_bug.cgi?id=83703

broke chromium win/mac builds (Requested by simonjam on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-11

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
(WebCore::CCHeadsUpDisplay::initializeFonts):
(WebCore::CCHeadsUpDisplay::onFrameBegin):
(WebCore::CCHeadsUpDisplay::drawHudContents):
(WebCore::CCHeadsUpDisplay::drawFPSCounter):
(WebCore::CCHeadsUpDisplay::drawFPSCounterText):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h:

(CCHeadsUpDisplay):

10:32 Changeset [113875] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Remove webkit prefix from Media Source runtime feature name.
https://bugs.webkit.org/show_bug.cgi?id=83633

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-04-11
Reviewed by Adam Barth.

Source/WebCore:

  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::mediaSourceEnabled):
(WebCore::RuntimeEnabledFeatures::setMediaSourceEnabled):

  • html/HTMLMediaElement.idl:

Source/WebKit/chromium:

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableMediaSource):
(WebKit::WebRuntimeFeatures::isMediaSourceEnabled):

10:05 Changeset [113874] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Wider suppression.

Unreviewed.

  • platform/chromium/test_expectations.txt:
09:59 Changeset [113873] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebCore

Single ShareableBitmap revision blacks out WebView on Harmattan
https://bugs.webkit.org/show_bug.cgi?id=83631

When swizzling is not supported in the driver, we need to initialize the texture as RGBA,
and make sure that the manual swizzling only modifies the sub-image.

Rubber stamped by Kenneth Rohde Christiansen.

Covered by existing tests.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::swizzleBGRAToRGBA):
(WebCore::BitmapTextureGL::didReset):
(WebCore):
(WebCore::BitmapTextureGL::updateContents):

09:57 Changeset [113872] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[chromium] When rendering goes idle, do not count that time against frame rate
https://bugs.webkit.org/show_bug.cgi?id=73454

The FPS counter had a few issues with its reporting. The first
3 swapbuffers are non-blocking and create FPS rates that are
unrealistically high, throwing off the moving averages and
introducing false spikes into the FPS graph. There was also no
way to monitor the smoothness of the animation, or to focus in
on a particular animation or transition.

This patch updates the FPS counter code so that bad data points
are trimmed and not graphed; so that the graph itself is taller
and more legible; so that there is a clear boundary between 40FPS
and better; and to keep statistics on frame rate between
pauses in the activity in the UI so that you can trigger a
transition and read off the average and standard deviation for
that transition to judge it smooth enough or not.

Patch by Alex Nicolaou <anicolao@chromium.org> on 2012-04-11
Reviewed by James Robinson.

HUD is not testable in webkit.

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
(WebCore::CCHeadsUpDisplay::onFrameBegin):
(WebCore::CCHeadsUpDisplay::drawHudContents):
(WebCore::CCHeadsUpDisplay::drawFPSCounter):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
09:21 Changeset [113871] by enne@google.com
  • 27 edits
    2 copies in trunk/Source

[chromium] Draw missing layer tile checkerboards as checkerboards
https://bugs.webkit.org/show_bug.cgi?id=83241

Reviewed by James Robinson.

Source/WebCore:

For non-Android platforms, draw missing tile checkerboards as actual
checkerboards. Use a shader to do this so that no texture uploads are
needed. This only happens on the non-composited content host to avoid
having unexpected (or transformed and aliased) checkerboards on other
content layers.

  • WebCore.gypi:
  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::setDrawCheckerboardForMissingTiles):
(WebCore::LayerChromium::drawCheckerboardForMissingTiles):
(LayerChromium):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawQuad):
(WebCore::LayerRendererChromium::drawCheckerboardQuad):
(WebCore):
(WebCore::LayerRendererChromium::checkerboardProgram):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

  • platform/graphics/chromium/ShaderChromium.cpp:

(WebCore::FragmentShaderCheckerboard::FragmentShaderCheckerboard):
(WebCore):
(WebCore::FragmentShaderCheckerboard::init):
(WebCore::FragmentShaderCheckerboard::getShaderString):

  • platform/graphics/chromium/ShaderChromium.h:

(FragmentShaderCheckerboard):
(WebCore::FragmentShaderCheckerboard::alphaLocation):
(WebCore::FragmentShaderCheckerboard::texTransformLocation):
(WebCore::FragmentShaderCheckerboard::frequencyLocation):
(WebCore):

  • platform/graphics/chromium/cc/CCCheckerboardDrawQuad.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCSolidColorLayerImpl.h.

(WebCore):
(WebCore::CCCheckerboardDrawQuad::create):
(WebCore::CCCheckerboardDrawQuad::CCCheckerboardDrawQuad):

  • platform/graphics/chromium/cc/CCCheckerboardDrawQuad.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCSolidColorLayerImpl.h.

(WebCore):
(CCCheckerboardDrawQuad):

  • platform/graphics/chromium/cc/CCDrawQuad.cpp:

(WebCore::CCDrawQuad::toCheckerboardDrawQuad):
(WebCore):

  • platform/graphics/chromium/cc/CCDrawQuad.h:

(WebCore):
(CCDrawQuad):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):
(WebCore::CCLayerImpl::setDrawCheckerboardForMissingTiles):
(WebCore::CCLayerImpl::drawCheckerboardForMissingTiles):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::appendQuadsForLayer):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(CCRenderPass):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:

(CCScrollbarLayerImpl):

  • platform/graphics/chromium/cc/CCSolidColorLayerImpl.h:

(CCSolidColorLayerImpl):

  • platform/graphics/chromium/cc/CCTextureLayerImpl.h:

(CCTextureLayerImpl):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:

(CCTiledLayerImpl):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:

(CCVideoLayerImpl):

Source/WebKit/chromium:

Rename usedCheckerboard to hadMissingTile to avoid confusion. Update
tests to not expect SolidColor quads for checkerboards.

  • src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::NonCompositedContentHost):

  • tests/CCQuadCullerTest.cpp:

(WebCore::appendQuads):

  • tests/CCSolidColorLayerImplTest.cpp:

(CCLayerTestCommon::TEST):

  • tests/CCTiledLayerImplTest.cpp:

(CCLayerTestCommon::TEST):
(CCLayerTestCommon::getQuads):

  • tests/LayerChromiumTest.cpp:
09:14 Changeset [113870] by carlosgc@webkit.org
  • 9 edits
    4 adds in trunk/Source/WebKit2

[GTK] Initial cookies API for WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=82441

Reviewed by Gustavo Noronha Silva.

  • GNUmakefile.am: Add new files to compilation.
  • UIProcess/API/gtk/WebKitCookieManager.cpp: Added.

(webkit_cookie_manager_init):
(webkitCookieManagerFinalize):
(webkit_cookie_manager_class_init):
(webkitCookieManagerCreate): Create a new WebKitCookieManager for
the given WKCookieManagerRef.
(webkit_cookie_manager_set_accept_policy): Set the cookie
acceptance policy.
(webkitCookieManagerGetAcceptPolicyCallback): Callback called by
the C API when the cookie acceptance policy has been received.
(webkit_cookie_manager_get_accept_policy): Asynchronously get the
cookie acceptance policy.
(webkit_cookie_manager_get_accept_policy_finish): Finish async
operation started by webkit_cookie_manager_get_accept_policy()
returning the cookie acceptance policy.
(webkitCookieManagerGetDomainsWithCookiesCallback): Callback
called by the C API when the list of hostnames with cookies has
been received.
(webkit_cookie_manager_get_domains_with_cookies): Asynchronously
get the list of domains with cookies.
(webkit_cookie_manager_get_domains_with_cookies_finish): Finish
async operation started by
webkit_cookie_manager_get_domains_with_cookies() returning the
list of domains.
(webkit_cookie_manager_delete_cookies_for_domain): Delete all
cookies for the given domain.
(webkit_cookie_manager_delete_all_cookies): Delete all cookies.

  • UIProcess/API/gtk/WebKitCookieManager.h: Added.
  • UIProcess/API/gtk/WebKitCookieManagerPrivate.h: Added.
  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkit_web_context_get_cookie_manager): Get the
WebKitCookieManager associated with the web context.

  • UIProcess/API/gtk/WebKitWebContext.h:
  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new chapter for

WebKitCookieManager.

  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
  • UIProcess/API/gtk/docs/webkit2gtk.types: Add

webkit_cookie_manager_get_type.

  • UIProcess/API/gtk/tests/GNUmakefile.am:
  • UIProcess/API/gtk/tests/TestCookieManager.cpp: Added.

(testCookieManagerAcceptPolicy):
(testCookieManagerDeleteCookies):
(serverCallback):
(beforeAll):
(afterAll):

  • UIProcess/API/gtk/webkit2.h: Include WebKitCookieManager.h.
09:09 Changeset [113869] by ossy@webkit.org
  • 4 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening after r113738.

  • platform/qt/Skipped: Unskip a non-existing test.
  • platform/qt/fast/multicol/cell-shrinkback-expected.png: Added.
  • platform/qt/fast/multicol/cell-shrinkback-expected.txt: Added.
  • platform/qt/fast/multicol/table-vertical-align-expected.png:
  • platform/qt/fast/multicol/table-vertical-align-expected.txt:
09:05 Changeset [113868] by commit-queue@webkit.org
  • 12 edits in trunk/Source

[BlackBerry] Update to the thread-safe GuardedPointer API
https://bugs.webkit.org/show_bug.cgi?id=83603

Patch by Joe Mason <jmason@rim.com> on 2012-04-11
Reviewed by Rob Buis.

Source/WebCore:

RIM PR: 134894
Make the destructors of all objects inheriting GuardedPointerBase protected or
private, and delete them using BlackBerry::Platform::deleteGuardedObject.
Access all GuardedPointers through GuardedPointerLocker. Use GuardedPointerDeleter
to delete LayerCompositingThread to avoid a deadlock.

No new tests, refactor.

Reviewed internally by Yong Li and George Staikos.

  • platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:

(WebCore::CookieDatabaseBackingStore::~CookieDatabaseBackingStore):

  • platform/blackberry/CookieManager.h:
  • platform/graphics/blackberry/LayerCompositingThread.cpp:
  • platform/graphics/blackberry/LayerCompositingThread.h:

(LayerCompositingThread):
(WTF::::deref):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):

Source/WebKit/blackberry:

RIM PR: 134984
Make the destructors of all objects inheriting GuardedPointerBase protected or
private, and delete them using BlackBerry::Platform::deleteGuardedObject.
Access all GuardedPointers through GuardedPointerLocker.

No new tests, refactor.

Reviewed internally by Yong Li and George Staikos.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStore::~BackingStore):

  • Api/BackingStore_p.h:

(BackingStorePrivate):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::~WebPage):
(BlackBerry::WebKit::WebPage::destroy):

  • Api/WebPage.h:
  • Api/WebPage_p.h:

(WebPagePrivate):

09:03 Changeset [113867] by rakuco@webkit.org
  • 2 edits
    735 adds in trunk/LayoutTests

[EFL][DRT] SVG dynamic-updates rebaseline
https://bugs.webkit.org/show_bug.cgi?id=83689

Unreviewed, EFL gardening.

Bug 83562 landed EFL fixes for SVG support from JavaScript.
This allows us to unskip the dynamic-updates/* family of SVG tests.
All results were visually inspected and produced PASS results.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-11

  • platform/efl/Skipped: dynamic-updates removed.
  • platform/efl/svg/dynamic-updates/: New baselines.
08:53 Changeset [113866] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Fix the build on OpenGL ES2 platforms

Unreviewed build fix.

No new tests needed.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::updateContents):
Fix typo in TEXMAP_OPENGL_ES_2 define.

08:49 Changeset [113865] by fischman@chromium.org
  • 6 edits in trunk/Source

Remove unused WebVideoFrame::Format values
https://bugs.webkit.org/show_bug.cgi?id=83625

Reviewed by Kenneth Russell.

Source/WebCore:

Covered by existing tests.

  • platform/graphics/chromium/VideoFrameChromium.h:
  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::convertVFCFormatToGC3DFormat):

Source/WebKit/chromium:

  • public/WebVideoFrame.h:

(WebKit):

  • src/AssertMatchingEnums.cpp:
08:40 Changeset [113864] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Follow up to r113863: fix chromium inspector interactive test harness.

  • src/js/Tests.js:
08:29 Changeset [113863] by pfeldman@chromium.org
  • 70 edits
    1 add in trunk

Source/WebCore: Web Inspector: extracting NetworkRequest from Resource (step 1)
https://bugs.webkit.org/show_bug.cgi?id=83684

Reviewed by Yury Semikhatsky.

Meta bug: https://bugs.webkit.org/show_bug.cgi?id=61363.
In this step, NetworkRequest is introduced. It temporarily inherits from
the Resource, but all the call sites are now referring to it as to request.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/ApplicationCacheItemsView.js:

(WebInspector.ApplicationCacheItemsView.prototype._updateCallback):

  • inspector/front-end/AuditLauncherView.js:

(WebInspector.AuditLauncherView):
(WebInspector.AuditLauncherView.prototype._onRequestStarted):
(WebInspector.AuditLauncherView.prototype._onRequestFinished):

  • inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.getDomainToResourcesMap):
(WebInspector.AuditRules.GzipRule.prototype.doRun):
(WebInspector.AuditRules.GzipRule.prototype._isCompressed):
(WebInspector.AuditRules.GzipRule.prototype._shouldCompress):
(WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun):
(WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun):
(WebInspector.AuditRules.ParallelizeDownloadRule.prototype.doRun):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
(WebInspector.AuditRules.CacheControlRule.prototype.doRun):
(WebInspector.AuditRules.CacheControlRule.prototype.handleNonCacheableResources):
(WebInspector.AuditRules.CacheControlRule.prototype._cacheableAndNonCacheableResources):
(WebInspector.AuditRules.CacheControlRule.prototype.execCheck):
(WebInspector.AuditRules.CacheControlRule.prototype.freshnessLifetimeGreaterThan):
(WebInspector.AuditRules.CacheControlRule.prototype.responseHeader):
(WebInspector.AuditRules.CacheControlRule.prototype.hasResponseHeader):
(WebInspector.AuditRules.CacheControlRule.prototype.isCompressible):
(WebInspector.AuditRules.CacheControlRule.prototype.isPubliclyCacheable):
(WebInspector.AuditRules.CacheControlRule.prototype.responseHeaderMatch):
(WebInspector.AuditRules.CacheControlRule.prototype.hasExplicitExpiration):
(WebInspector.AuditRules.CacheControlRule.prototype._isExplicitlyNonCacheable):
(WebInspector.AuditRules.CacheControlRule.prototype.isCacheableResource):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype.handleNonCacheableResources):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype.runChecks):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype._missingExpirationCheck):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype._varyCheck):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype._oneMonthExpirationCheck):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype._oneYearExpirationCheck):
(WebInspector.AuditRules.ProxyCacheControlRule.prototype.runChecks):
(WebInspector.AuditRules.ProxyCacheControlRule.prototype._questionMarkCheck):
(WebInspector.AuditRules.ProxyCacheControlRule.prototype._publicCachingCheck):
(WebInspector.AuditRules.ProxyCacheControlRule.prototype._setCookieCacheableCheck):
(WebInspector.AuditRules.CookieRuleBase.prototype.doRun.resultCallback):
(WebInspector.AuditRules.CookieRuleBase.prototype.doRun):
(WebInspector.AuditRules.CookieRuleBase.prototype.mapResourceCookies):
(WebInspector.AuditRules.CookieRuleBase.prototype._callbackForResourceCookiePairs):
(WebInspector.AuditRules.CookieSizeRule.prototype.processCookies):
(WebInspector.AuditRules.StaticCookielessRule.prototype.processCookies):
(WebInspector.AuditRules.StaticCookielessRule.prototype._collectorCallback):

  • inspector/front-end/AuditsPanel.js:

(WebInspector.AuditsPanel.prototype._executeAudit):
(WebInspector.AuditCategory.prototype.run):
(WebInspector.AuditRule.prototype.run):
(WebInspector.AuditRule.prototype.doRun):

  • inspector/front-end/ConsoleMessage.js:
  • inspector/front-end/ConsoleModel.js:

(WebInspector.ConsoleDispatcher.prototype.messageAdded):

  • inspector/front-end/ContentProviders.js:

(WebInspector.ResourceContentProvider):
(WebInspector.ResourceContentProvider.prototype.requestContent):
(WebInspector.ResourceContentProvider.prototype.searchInContent):

  • inspector/front-end/DebuggerPresentationModel.js:
  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onGetHAR):
(WebInspector.ExtensionServer.prototype._notifyRequestFinished):

  • inspector/front-end/HAREntry.js:

(WebInspector.HAREntry):
(WebInspector.HAREntry.prototype.build):
(WebInspector.HAREntry.prototype._buildRequest):
(WebInspector.HAREntry.prototype._buildResponse):
(WebInspector.HAREntry.prototype._buildContent):
(WebInspector.HAREntry.prototype._buildTimings):
(WebInspector.HAREntry.prototype._buildPostData):
(WebInspector.HAREntry.prototype._buildCookie):
(WebInspector.HAREntry.prototype._interval):
(WebInspector.HAREntry.prototype.get requestBodySize):
(WebInspector.HAREntry.prototype.get responseBodySize):
(WebInspector.HAREntry.prototype.get responseCompression):
(WebInspector.HARLog):
(WebInspector.HARLog.prototype.build):
(WebInspector.HARLog.prototype._buildPages):
(WebInspector.HARLog.prototype._convertResource):

  • inspector/front-end/NetworkItemView.js:

(WebInspector.NetworkItemView):

  • inspector/front-end/NetworkLog.js:

(WebInspector.NetworkLog):
(WebInspector.NetworkLog.prototype.get requests):
(WebInspector.NetworkLog.prototype.pageLoadForRequest):
(WebInspector.NetworkLog.prototype._onMainFrameNavigated):
(WebInspector.NetworkLog.prototype._onRequestStarted):
(WebInspector.NetworkLog.prototype._onLoad):
(WebInspector.PageLoad):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkManager.get this):
(WebInspector.NetworkManager.get NetworkAgent):
(WebInspector.NetworkManager):
(WebInspector.NetworkManager.prototype.inflightRequestForURL):
(WebInspector.NetworkDispatcher):
(WebInspector.NetworkDispatcher.prototype._updateNetworkRequestWithRequest):
(WebInspector.NetworkDispatcher.prototype._updateNetworkRequestWithResponse):
(WebInspector.NetworkDispatcher.prototype._mimeTypeIsConsistentWithType):
(WebInspector.NetworkDispatcher.prototype._updateNetworkRequestWithCachedResource):
(WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
(WebInspector.NetworkDispatcher.prototype.requestServedFromCache):
(WebInspector.NetworkDispatcher.prototype.responseReceived):
(WebInspector.NetworkDispatcher.prototype.dataReceived):
(WebInspector.NetworkDispatcher.prototype.loadingFinished):
(WebInspector.NetworkDispatcher.prototype.loadingFailed):
(WebInspector.NetworkDispatcher.prototype.requestServedFromMemoryCache):
(WebInspector.NetworkDispatcher.prototype.webSocketCreated):
(WebInspector.NetworkDispatcher.prototype.webSocketWillSendHandshakeRequest):
(WebInspector.NetworkDispatcher.prototype.webSocketHandshakeResponseReceived):
(WebInspector.NetworkDispatcher.prototype.webSocketClosed):
(WebInspector.NetworkDispatcher.prototype._appendRedirect):
(WebInspector.NetworkDispatcher.prototype._startNetworkRequest):
(WebInspector.NetworkDispatcher.prototype._updateNetworkRequest):
(WebInspector.NetworkDispatcher.prototype._finishNetworkRequest):
(WebInspector.NetworkDispatcher.prototype._dispatchEventToListeners):
(WebInspector.NetworkDispatcher.prototype._createNetworkRequest):
(get WebInspector):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._initializeView):
(WebInspector.NetworkLogView.prototype.get statusBarItems):
(WebInspector.NetworkLogView.prototype._createSortingFunctions):
(WebInspector.NetworkLogView.prototype._updateSummaryBar):
(WebInspector.NetworkLogView.prototype._updateDividersIfNeeded):
(WebInspector.NetworkLogView.prototype._invalidateAllItems):
(WebInspector.NetworkLogView.prototype._requestGridNode):
(WebInspector.NetworkLogView.prototype._createRequestGridNode):
(WebInspector.NetworkLogView.prototype._onLoadEventFired):
(WebInspector.NetworkLogView.prototype._domContentLoadedEventFired):
(WebInspector.NetworkLogView.prototype.refresh):
(WebInspector.NetworkLogView.prototype._reset):
(WebInspector.NetworkLogView.prototype.get requests):
(WebInspector.NetworkLogView.prototype.requestById):
(WebInspector.NetworkLogView.prototype._onRequestStarted):
(WebInspector.NetworkLogView.prototype._appendRequest):
(WebInspector.NetworkLogView.prototype._onRequestUpdated):
(WebInspector.NetworkLogView.prototype._refreshRequest):
(WebInspector.NetworkLogView.prototype._mainFrameNavigated):
(WebInspector.NetworkLogView.prototype.get _setLargerRequests):
(WebInspector.NetworkLogView.prototype._getPopoverAnchor):
(WebInspector.NetworkLogView.prototype._showPopover):
(WebInspector.NetworkLogView.prototype._contextMenu):
(WebInspector.NetworkLogView.prototype._copyAll):
(WebInspector.NetworkLogView.prototype._copyRequest):
(WebInspector.NetworkLogView.prototype._copyLocation):
(WebInspector.NetworkLogView.prototype._copyRequestHeaders):
(WebInspector.NetworkLogView.prototype._copyResponseHeaders):
(WebInspector.NetworkLogView.prototype._exportAll):
(WebInspector.NetworkLogView.prototype._exportRequest):
(WebInspector.NetworkLogView.prototype._matchRequest):
(WebInspector.NetworkLogView.prototype._clearSearchMatchedList):
(WebInspector.NetworkLogView.prototype._updateSearchMatchedListAfterRequestIdChanged):
(WebInspector.NetworkLogView.prototype._updateHighlightIfMatched):
(WebInspector.NetworkLogView.prototype._highlightNthMatchedRequest):
(WebInspector.NetworkLogView.prototype.performSearch):
(WebInspector.NetworkLogView.prototype.jumpToPreviousSearchResult):
(WebInspector.NetworkLogView.prototype.jumpToNextSearchResult):
(WebInspector.NetworkLogView.prototype.revealAndHighlightRequest):
(WebInspector.NetworkPanel.prototype.handleShortcut):
(WebInspector.NetworkPanel.prototype.get requests):
(WebInspector.NetworkPanel.prototype.requestById):
(WebInspector.NetworkPanel.prototype._requestByAnchor):
(WebInspector.NetworkPanel.prototype.canShowAnchorLocation):
(WebInspector.NetworkPanel.prototype.showAnchorLocation):
(WebInspector.NetworkPanel.prototype.revealAndHighlightRequest):
(WebInspector.NetworkPanel.prototype._onViewCleared):
(WebInspector.NetworkPanel.prototype._onRequestSelected):
(WebInspector.NetworkPanel.prototype._showRequest):
(WebInspector.NetworkPanel.prototype._closeVisibleRequest):
(WebInspector.NetworkPanel.prototype._toggleGridMode):
(WebInspector.NetworkPanel.prototype._toggleViewingRequestMode):
(WebInspector.NetworkTimeCalculator.prototype.computeBarGraphPercentages):
(WebInspector.NetworkTimeCalculator.prototype.computeBarGraphLabels):
(WebInspector.NetworkTimeCalculator.prototype.updateBoundaries):
(WebInspector.NetworkTimeCalculator.prototype._lowerBound):
(WebInspector.NetworkTimeCalculator.prototype._upperBound):
(WebInspector.NetworkTransferTimeCalculator.prototype._lowerBound):
(WebInspector.NetworkTransferTimeCalculator.prototype._upperBound):
(WebInspector.NetworkTransferDurationCalculator.prototype._upperBound):
(WebInspector.NetworkDataGridNode):
(WebInspector.NetworkDataGridNode.prototype.isFilteredOut):
(WebInspector.NetworkDataGridNode.prototype.select):
(WebInspector.NetworkDataGridNode.prototype._openInNewTab):
(WebInspector.NetworkDataGridNode.prototype.get selectable):
(WebInspector.NetworkDataGridNode.prototype._createTimelineCell):
(WebInspector.NetworkDataGridNode.prototype.refreshRequest):
(WebInspector.NetworkDataGridNode.prototype._refreshNameCell):
(WebInspector.NetworkDataGridNode.prototype._fileName):
(WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
(WebInspector.NetworkDataGridNode.prototype._refreshTypeCell):
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
(WebInspector.NetworkDataGridNode.prototype._refreshSizeCell):
(WebInspector.NetworkDataGridNode.prototype._refreshTimeCell):
(WebInspector.NetworkDataGridNode.prototype.refreshGraph):
(WebInspector.NetworkDataGridNode.NameComparator):
(WebInspector.NetworkDataGridNode.SizeComparator):
(WebInspector.NetworkDataGridNode.InitiatorComparator):
(WebInspector.NetworkDataGridNode.RequestPropertyComparator):

  • inspector/front-end/NetworkRequest.js: Added.

(WebInspector.NetworkRequest):

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype._requestFinished):
(WebInspector.RawSourceCode.prototype._createContentProvider):

  • inspector/front-end/Resource.js:

(WebInspector.Resource):
(WebInspector.Resource.displayName):
(WebInspector.Resource.prototype.get request):
(WebInspector.Resource.prototype.set finished):
(WebInspector.Resource.prototype.set timing):
(WebInspector.Resource.prototype.set requestHeaders):
(WebInspector.Resource.prototype.set requestHeadersText):
(WebInspector.Resource.prototype.set responseHeaders):
(WebInspector.Resource.prototype.set responseHeadersText):
(WebInspector.Resource.prototype.requestContent):

  • inspector/front-end/ResourceCookiesView.js:

(WebInspector.ResourceCookiesView):
(WebInspector.ResourceCookiesView.prototype.get _gotCookies):
(WebInspector.ResourceCookiesView.prototype._buildCookiesTable):

  • inspector/front-end/ResourceHeadersView.js:

(WebInspector.ResourceHeadersView):
(WebInspector.ResourceHeadersView.prototype._refreshURL):
(WebInspector.ResourceHeadersView.prototype._refreshQueryString):
(WebInspector.ResourceHeadersView.prototype._refreshUrlFragment):
(WebInspector.ResourceHeadersView.prototype._refreshFormData):
(WebInspector.ResourceHeadersView.prototype._refreshRequestHeaders):
(WebInspector.ResourceHeadersView.prototype._refreshResponseHeaders):
(WebInspector.ResourceHeadersView.prototype._refreshHTTPInformation):

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype.addScript):

  • inspector/front-end/ResourceTimingView.js:

(WebInspector.ResourceTimingView):
(WebInspector.ResourceTimingView.prototype.wasShown):
(WebInspector.ResourceTimingView.prototype._refresh):
(WebInspector.ResourceTimingView.createTimingTable):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel):
(WebInspector.ResourceTreeModel.prototype._frontendReused):
(WebInspector.ResourceTreeModel.prototype._onRequestUpdated):
(WebInspector.ResourceTreeModel.prototype._onRequestUpdateDropped):
(WebInspector.ResourceTreeModel.prototype._createResource):
(WebInspector.ResourceTreeFrame):
(WebInspector.ResourceTreeFrame.prototype._addRequest):

  • inspector/front-end/ResourceUtils.js:
  • inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameResourceTreeElement.prototype._appendOpenInNetworkPanelAction):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/externs.js:

(WebInspector.networkRequestById):

  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector.networkRequestById):
(WebInspector.openRequestInNetworkPanel):

Tools: Web Inspector: Disabling Inspector causes build failure on Windows
https://bugs.webkit.org/show_bug.cgi?id=83557

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-04-11
Reviewed by Pavel Feldman.

The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
This change brings all such API calls under the guard.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(LayoutTestController):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::invoke):

LayoutTests: Web Inspector: extracting NetworkRequest from Resource (step 1)
https://bugs.webkit.org/show_bug.cgi?id=83684

Reviewed by Yury Semikhatsky.

  • http/tests/inspector/network-preflight-options.html:
  • http/tests/inspector/network-test.js:
  • http/tests/inspector/network/async-xhr-json-mime-type.html:
  • http/tests/inspector/network/download.html:
  • http/tests/inspector/network/network-cachedresources-with-same-urls.html:
  • http/tests/inspector/network/network-content-replacement-embed.html:
  • http/tests/inspector/network/network-content-replacement-xhr.html:
  • http/tests/inspector/network/network-cyrillic-xhr.html:
  • http/tests/inspector/network/network-disable-cache-memory.html:
  • http/tests/inspector/network/network-disable-cache-xhrs.html:
  • http/tests/inspector/network/network-disabling-check-no-memory-leak.html:
  • http/tests/inspector/network/network-embed.html:
  • http/tests/inspector/network/network-empty-xhr.html:
  • http/tests/inspector/network/network-iframe-load-and-delete.html:
  • http/tests/inspector/network/network-initiator-from-console.html:
  • http/tests/inspector/network/network-initiator.html:
  • http/tests/inspector/network/network-request-revision-content.html:
  • http/tests/inspector/network/network-shared-worker.html:
  • http/tests/inspector/network/network-sidebar-width.html:
  • http/tests/inspector/network/network-size-chunked.html:
  • http/tests/inspector/network/network-size-sync.html:
  • http/tests/inspector/network/network-size.html:
  • http/tests/inspector/network/network-timing.html:
  • http/tests/inspector/network/network-worker.html:
  • http/tests/inspector/network/network-xhr-async.html:
  • http/tests/inspector/network/network-xhr-same-url-as-main-resource.html:
  • http/tests/inspector/network/network-xhr-sync.html:
  • http/tests/inspector/network/ping.html:
  • http/tests/inspector/network/x-frame-options-deny.html:
  • http/tests/inspector/resource-har-conversion.html:
  • http/tests/inspector/resource-har-headers.html:
  • http/tests/inspector/resource-har-pages.html:
  • http/tests/inspector/resource-parameters.html:
  • http/tests/inspector/resources-test.js:

(initialize_ResourceTest.InspectorTest.requestURLComparer):

  • inspector/debugger/raw-source-code.html:
  • inspector/debugger/source-frame.html:
  • inspector/network-status-non-http.html:
08:20 Changeset [113862] by arko@motorola.com
  • 3 edits in trunk/Source/WebCore

Microdata: Implement cache mechanism for HTMLPropertiesCollection.
https://bugs.webkit.org/show_bug.cgi?id=80490

Reviewed by Ryosuke Niwa.

Implemented caching mechanism for HTMLPropertiesCollection.
propertyCache - contains microdata item properties.
itemRefElements - contains sorted microdata item and itemref elements.
propertyNames - contains microdata property names of the elements in the collection.
itemRefElementPosition - store the current position of itemRefElements.
hasItemRefElements - set to ture once we have sorted microdata item and itemref elements list i.e, itemRefElements.
Cache is invalidated only when dom tree modified. Whenever any query is made on HTMLPropertiesCollection,
result is returned from the cache. Earliar we used to calculate properties node list every time a query is made.

  • html/HTMLPropertiesCollection.cpp:

(WebCore):
(WebCore::HTMLPropertiesCollection::HTMLPropertiesCollection):
(WebCore::HTMLPropertiesCollection::invalidateCacheIfNeeded):
(WebCore::HTMLPropertiesCollection::updateRefElements): Appends microdata item element and elements which
are added through itemref attribute in itemRefElements (in tree order).
(WebCore::nextNodeWithProperty):
(WebCore::HTMLPropertiesCollection::itemAfter): Takes parent base and previous item property as argument.
Finds the next item property in base.
(WebCore::HTMLPropertiesCollection::calcLength): Calculates the length of properties collection if length
is not available in the cache.
(WebCore::HTMLPropertiesCollection::length):
(WebCore::HTMLPropertiesCollection::firstProperty): Returns the first property in the collection.
(WebCore::HTMLPropertiesCollection::item):
(WebCore::HTMLPropertiesCollection::findProperties): Finds microdata item properties in the base element.
Appends the properties in propertyCache and property names in propertyNames.
(WebCore::HTMLPropertiesCollection::updateNameCache): It updates the propertyCache and propertyNames if hasNameCache is false.
(WebCore::HTMLPropertiesCollection::names):
(WebCore::HTMLPropertiesCollection::namedItem):
(WebCore::HTMLPropertiesCollection::hasNamedItem):

  • html/HTMLPropertiesCollection.h:

(HTMLPropertiesCollection):

07:53 Changeset [113861] by jocelyn.turcotte@nokia.com
  • 7 edits
    3 adds in trunk

[Qt] InspectorServer: Add an API level auto test
https://bugs.webkit.org/show_bug.cgi?id=83594

Reviewed by Kenneth Rohde Christiansen.

.:

  • Source/tests.pri:

Source/WebKit2:

This tests InspectorServer and WebSocketServer.

  • UIProcess/API/qt/tests/inspectorserver/inspectorserver.pro: Added.
  • UIProcess/API/qt/tests/inspectorserver/tst_inspectorserver.cpp: Added.

(tst_InspectorServer):
(tst_InspectorServer::tst_InspectorServer):
(tst_InspectorServer::prepareWebViewComponent):
(tst_InspectorServer::newWebView):
(tst_InspectorServer::init):
(tst_InspectorServer::cleanup):
(tst_InspectorServer::webView):
(tst_InspectorServer::fetchPageList):
(tst_InspectorServer::testPageList): This tests that pages with developerExtrasEnabled appear available for inspection.
(tst_InspectorServer::testRemoteDebuggingMessage): This tests a web socket connection using a raw inspector command.
(tst_InspectorServer::openRemoteDebuggingSession): This tests the whole pipeline by starting a remote inspection session.

  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView):
(tst_QQuickWebView::prepareWebViewComponent):

  • UIProcess/API/qt/tests/tests.pri:
  • UIProcess/API/qt/tests/util.cpp:

(LoadStartedCatcher::LoadStartedCatcher):
(LoadStartedCatcher::onLoadingChanged):

  • UIProcess/API/qt/tests/util.h:

(LoadStartedCatcher):

07:52 Changeset [113860] by jocelyn.turcotte@nokia.com
  • 3 edits in trunk/Source/WebKit2

[Qt] InspectorServer: Improve the JSON page list's parameter names
https://bugs.webkit.org/show_bug.cgi?id=83592

Reviewed by Simon Hausmann.

  • Add "id" that would be needed to build the URL when using local front-end resources (and will be used by tests)
  • Rename description to "title", the description contains both the title and URL on the final list
  • Rename inspectorLocation to "inspectorUrl" to match with the url parameter.
  • UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp:

(WebKit::WebInspectorServer::buildPageList):

  • qt/Resources/inspectorPageIndex.html:
07:50 Changeset [113859] by jocelyn.turcotte@nokia.com
  • 8 edits in trunk/Source

[Qt] Fix issues when using the WebView as ShaderEffectSource
https://bugs.webkit.org/show_bug.cgi?id=83587

Reviewed by Noam Rosenthal.

Source/WebCore:

  • Make sure that the bound frame buffer is preserved instead of binding to the default one
  • Accept a "mirrored" flag in beginPainting that we're applying on the projection matrix just as with internal FBOs

The "flip" logic in createProjectionMatrix has been reversed and renamed to
mirrored so that FBO rendering is considered the special case and not the
other way around just like within Qt.

  • platform/graphics/texmap/TextureMapper.h:

(WebCore::TextureMapper::beginPainting):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGLData::TextureMapperGLData):
(TextureMapperGLData):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::createProjectionMatrix):
(WebCore::BitmapTextureGL::bind):
(WebCore::TextureMapperGL::bindSurface):

  • platform/graphics/texmap/TextureMapperGL.h:

Source/WebKit2:

Qt is going to mirror the projection matrix when the shader effect source
is grabbed. Detect that the matrix is mirrored and pass on this information
to TextureMapper so that it can do the same.

  • UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::WebLayerTreeRenderer::paintToCurrentGLContext):

  • UIProcess/WebLayerTreeRenderer.h:

(WebLayerTreeRenderer):

  • UIProcess/qt/QtWebPageSGNode.cpp:

(WebKit::ContentsSGNode::render):

07:49 Changeset [113858] by jocelyn.turcotte@nokia.com
  • 9 edits in trunk/Source/WebKit2

[Qt] Remove unnecessary rendering code
https://bugs.webkit.org/show_bug.cgi?id=83591

Reviewed by Noam Rosenthal.

  • Remove code that isn't needed since the introduction of WebLayerTreeRenderer
  • Remove TextureMapper::bindSurface(0) calls following beginPainting, which calls it itself.
  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPagePrivate::paint):

  • UIProcess/API/qt/qquickwebpage_p_p.h:

(QQuickWebPagePrivate):

  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxyImpl.cpp:
  • UIProcess/DrawingAreaProxyImpl.h:

(DrawingAreaProxyImpl):

  • UIProcess/LayerTreeHostProxy.cpp:
  • UIProcess/LayerTreeHostProxy.h:

(LayerTreeHostProxy):

  • UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::WebLayerTreeRenderer::paintToCurrentGLContext):
(WebKit::WebLayerTreeRenderer::paintToGraphicsContext):

07:00 Changeset [113857] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

svg/text/svg-zoom-large-value.xhtml ASSERTs on Chromium Linux Debug
https://bugs.webkit.org/show_bug.cgi?id=63400

Unreviewed Chromium test expectation removal.

  • platform/chromium/test_expectations.txt:
06:41 Changeset [113856] by schenney@chromium.org
  • 2 edits in trunk/Source/WebCore

Shadow tree TreeScope data is not removed by ContainerNode::removeAllChildren
https://bugs.webkit.org/show_bug.cgi?id=83484

Unreviewed attempted build fix.

  • dom/ContainerNodeAlgorithms.h: Adding Document.h include.
06:31 Changeset [113855] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Skip a new test because of missing layoutTestController.setBackingScaleFactor() implemetation.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-04-11
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
06:29 Changeset [113854] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove unnecessary assignments from CSSParser::parseLinearGradient().
https://bugs.webkit.org/show_bug.cgi?id=83661

Reviewed by Kentaro Hara.

No new tests / code cleanup only.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseLinearGradient):

06:23 Changeset [113853] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Tools

[Qt][WK2] Manage graphics buffers in the web process
https://bugs.webkit.org/show_bug.cgi?id=78675

Make graphics surface available only for Qt 5, attempting to fix
the Qt-mac build.

Unreviewed build fix.

  • qmake/mkspecs/features/features.prf:
06:18 Changeset [113852] by schenney@chromium.org
  • 2 edits in trunk/Source/WebCore

Shadow tree TreeScope data is not removed by ContainerNode::removeAllChildren
https://bugs.webkit.org/show_bug.cgi?id=83484

Reviewed by Hajime Morita.

The ContainerNode::removeAllChildren method does fast and dirty node removal.
As compared to ContainerNode::removeChildren, it does not include the
method to adopt the removed child node into the root document's TreeScope.
Rather, it leaves the existing TreeScope in place. However, the existing
TreeScope may be removed, causing a crash when something prevents the child
node from being deleted immediately. The fix is to modify the code in
ContainerNodeAlgorithms to do the TreeScope adoption.

Could not reproduce crash in layout test.

  • dom/ContainerNodeAlgorithms.h:

(Private):
(WebCore::Private::NodeRemovalDispatcher::dispatch):
(WebCore::Private::addChildNodesToDeletionQueue):

05:52 Changeset [113851] by yurys@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: showing summary view is very slow on a snapshot with thousands of constructors
https://bugs.webkit.org/show_bug.cgi?id=83682

Node content is created only when the node becomes visible in the corresponding view.
This saves a lot of time when openning summary/comparison view of a snapshot
with lots of different classes.

Reviewed by Pavel Feldman.

  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotGridNode.prototype.ensureContentCreated):
(WebInspector.HeapSnapshotLazyGridNode):
(WebInspector.HeapSnapshotLazyGridNode.prototype.ensureContentCreated):
(WebInspector.HeapSnapshotLazyGridNode.prototype.createCells):
(WebInspector.HeapSnapshotConstructorNode):
(WebInspector.HeapSnapshotDiffNode):

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.HeapSnapshotSortableDataGrid):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.updateVisibleNodes):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.onResize):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._onScroll):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
(WebInspector.HeapSnapshotConstructorsDataGrid):
(WebInspector.HeapSnapshotDiffDataGrid):
(WebInspector.DetailedHeapshotView.prototype._changeNameFilter):

  • inspector/front-end/heapProfiler.css:

(.detailed-heapshot-view .data-grid tr:empty):

05:24 WebKitGtkLayoutTests edited by philn@webkit.org
(diff)
05:24 Changeset [113850] by philn@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, GTK NRWT follow-up fix after r113849.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort._unload_pulseaudio_module): Exit early if pactl is not found.

04:57 Changeset [113849] by commit-queue@webkit.org
  • 8 edits in trunk

[GTK] media/event-attributes.html fails
https://bugs.webkit.org/show_bug.cgi?id=71662

Patch by Simon Pena <spena@igalia.com> on 2012-04-11
Reviewed by Philippe Normand.

Source/WebCore:

In MediaPlayerPrivateGStreamer::didEnd, when EOS is reached, don't
synchronize position and duration on regular playback. That is:
synchronize it (and fire the durationChange signal) only on reverse
playback.

This change makes media/event-attributes.html pass. It was
previously failing because an additional durationChange signal was
emitted.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: Avoid

sending durationChange signal on regular playback.

Tools:

PulseAudio's module "module-stream-restore" allows saving the volume
of a stream, restoring it the next time it runs.
This affects the tests, since DumpRenderTree's volume settings are
saved between test runs, and tests relying on specific volume values
would miss some volumeChange events (or get additional ones).

This patch hooks on the existing GtkPort setup_test_run method and
creates a new clean_up_test_run method, so PulseAudio's module is
unloaded (if found) before running the tests, and restored (if it
was there previously) after they finished, ensuring the tests run in
the right environment.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._clean_up_run): Invoke the port implementation of
clean_up_test_run.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.clean_up_test_run): Add an empty implementation of
clean_up_test_run.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort._unload_pulseaudio_module): Unloads the offending
pulseaudio module, if found.
(GtkPort):
(GtkPort._restore_pulseaudio_module): Restores the offending
pulseaudio module, if it was there previously.
(GtkPort.setup_test_run): Calls _unload_pulseaudio_module.
(GtkPort.clean_up_test_run): Calls _restore_pulseaudio_module.

LayoutTests:

Unskip tests media/video-seek-past-end-playing and
media/sources-fallback-codecs, which no longer fail, and
media/event-attributes, which is fixed with this patch.

  • platform/gtk/Skipped: Unskip media/video-seek-past-end-playing,

media/sources-fallback-codecs and media/event-attributes

04:23 Changeset [113848] by abecsi@webkit.org
  • 7 edits in trunk

Fix the build with gcc 4.7.0
https://bugs.webkit.org/show_bug.cgi?id=83584

Reviewed by Alexey Proskuryakov.

Source/WebCore:

No new tests needed.

  • Target.pri: Disable Werror on the ANGLE code since it has several recurring issues

because older versions of flex (<2.5.35) and bison (<2.5) generate code which
triggers warnings. This generated code is committed on each version update of ANGLE,
and it is very likely that the code is generated with older versions of the mentioned
tools.

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::createForJSConstructor): Fails because of -Werror=extra

  • platform/graphics/TiledBackingStoreClient.h: Fails because -Werror=delete-non-virtual-dtor,

gcc requires classes which have virtual methods to have a virtual destructor, if their instances
or the instances of their subclasses are deleted.
(WebCore::TiledBackingStoreClient::~TiledBackingStoreClient):

  • platform/graphics/texmap/TextureMapperPlatformLayer.h: Ditto.

(WebCore::TextureMapperPlatformLayer::~TextureMapperPlatformLayer):

Tools:

  • qmake/mkspecs/features/unix/default_post.prf:

The -fuse-ld=gold option is not supported with upstream gcc.

03:50 Changeset [113847] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK gardening.

  • platform/gtk/test_expectations.txt: Mark two a11y tests as flaky.
03:06 Changeset [113846] by tkent@chromium.org
  • 4 edits
    2 adds in trunk/Source/WebCore

[V8] Calendar Picker: Add a helper function to expose PagePopupClient::setValueAndClosePopup() to JavaScript
https://bugs.webkit.org/show_bug.cgi?id=83561

Reviewed by Adam Barth.

Add ScriptController::installFunctionsForPagePopup(), which add
window.setValueAndClosePopup() for JavaScript code in PagePopup
environment, and the function calls
WebCore::PagePopupClient::setValueAndClosePopup().

This patch introduces Supplement<DOMWindow> object to hold a
PagePopupClient object. It makes keeping a PagePopupClient easier.

  • WebCore.gypi: Add DOMWindowPagePopup.{cpp,h}
  • bindings/v8/ScriptController.cpp:

(WebCore::setValueAndClosePopupCallback):
(WebCore::ScriptController::installFunctionsForPagePopup):

  • bindings/v8/ScriptController.h:

(ScriptController): Add installFunctionsForPagePopup().

  • page/DOMWindowPagePopup.cpp: Added.

(WebCore::DOMWindowPagePopup::DOMWindowPagePopup):
(WebCore::DOMWindowPagePopup::supplementName):
Returns "DOMWindowPagePopup" as a key of this Supplement<DOMWindow>.
(WebCore::DOMWindowPagePopup::setValueAndClosePopup):
Gets a DOMWindowPagePopup from the window, then calls PagePopupClient::setValueAndClosePopup().
(WebCore::DOMWindowPagePopup::install):
On-demand creation of DOMWindowPagePopup doesn't work because it
must have a PagePopupClient object. We need to install
DOMWindowPagePopup explicitly.

  • page/DOMWindowPagePopup.h: Added.
03:00 Changeset [113845] by commit-queue@webkit.org
  • 16 edits
    4 adds in trunk

[chromium] Add Battery Status API support.

Source/WebCore:

Add Battery Status API support to chromium.
https://bugs.webkit.org/show_bug.cgi?id=83284

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-04-11
Reviewed by Adam Barth.

This change is covered by tests in batterystatus/.

  • Modules/battery/BatteryController.cpp:

(WebCore::BatteryController::updateBatteryStatus):
(WebCore):

  • Modules/battery/BatteryController.h:

(BatteryController):

  • Modules/battery/BatteryManager.cpp:

(WebCore::BatteryManager::charging):
(WebCore::BatteryManager::chargingTime):
(WebCore::BatteryManager::dischargingTime):
(WebCore::BatteryManager::level):

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:

Source/WebKit/chromium:

The battery-client (BatteryClientChromium) will notify the client (WebBatteryStatusClient) when to start or stop
sending battery status updates. The client, in response will send the notifications to WebViewImpl, which sends
this update information to the WebCore::BatteryClient, and it triggers the appropriate javascript-callbacks.
The spec is at http://www.w3.org/TR/2011/WD-battery-status-20111129/.
https://bugs.webkit.org/show_bug.cgi?id=83284

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-04-11
Reviewed by Adam Barth.

  • WebKit.gyp:
  • features.gypi:
  • public/WebBatteryStatus.h: Added.

(WebKit):
(WebBatteryStatus):
(WebKit::WebBatteryStatus::WebBatteryStatus):

  • public/WebBatteryStatusClient.h: Added.

(WebKit):
(WebBatteryStatusClient):
(WebKit::WebBatteryStatusClient::~WebBatteryStatusClient):

  • public/WebView.h:

(WebKit):
(WebView):
(WebKit::WebView::updateBatteryStatus):

  • public/WebViewClient.h:

(WebKit):
(WebViewClient):
(WebKit::WebViewClient::batteryStatusClient):

  • src/BatteryClientImpl.cpp: Added.

(WebKit):
(WebKit::BatteryClientImpl::BatteryClientImpl):
(WebKit::BatteryClientImpl::updateBatteryStatus):
(WebKit::BatteryClientImpl::setController):
(WebKit::BatteryClientImpl::startUpdating):
(WebKit::BatteryClientImpl::stopUpdating):
(WebKit::BatteryClientImpl::batteryControllerDestroyed):

  • src/BatteryClientImpl.h: Added.

(WebKit):
(BatteryClientImpl):
(WebKit::BatteryClientImpl::~BatteryClientImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit):
(WebKit::WebViewImpl::updateBatteryStatus):

  • src/WebViewImpl.h:

(WebKit):
(WebViewImpl):

LayoutTests:

Add Battery Status API support to chromium.
https://bugs.webkit.org/show_bug.cgi?id=83284

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-04-11
Reviewed by Adam Barth.

  • platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
  • platform/chromium/test_expectations.txt:
02:44 Changeset [113844] by paroga@webkit.org
  • 2 edits in trunk

[CMake] Add WEBKIT_CREATE_FORWARDING_HEADERS macro
https://bugs.webkit.org/show_bug.cgi?id=83574

Reviewed by Daniel Bates.

This new macro generates forwarding headers with absolute paths to the original files.
It accepts a list of files and/or a list of directories as input.

  • Source/cmake/WebKitMacros.cmake:
02:43 Changeset [113843] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK gardening.

  • platform/gtk/test_expectations.txt: Mark an editing test as flaky.
02:41 Changeset [113842] by mihnea@adobe.com
  • 16 edits
    2 adds in trunk/Source/WebCore

[CSS Regions]Add helper class for flow threads info in RenderView
https://bugs.webkit.org/show_bug.cgi?id=83464

Reviewed by David Hyatt.

This patch creates a new helper class FlowThreadController that will accommodate all the flow thread
related info from RenderView and moves all the data structures/methods from RenderView into this new class.
There is only one FlowThreadController object per RenderView and it can be retrieved using flowThreadController() method from RenderView.
The flow thread controller object is owned by the RenderView and it is created on demand only if there are flowing
threads in the page.

Since there is no change in functionality, there are no new tests added.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:

(WebCore::Document::webkitGetFlowByName):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):

  • rendering/FlowThreadController.cpp: Added.

(WebCore):
(WebCore::FlowThreadController::create):
(WebCore::FlowThreadController::FlowThreadController):
(WebCore::FlowThreadController::~FlowThreadController):
(WebCore::FlowThreadController::ensureRenderFlowThreadWithName):
(WebCore::FlowThreadController::layoutRenderNamedFlowThreads):

  • rendering/FlowThreadController.h: Added.

(WebCore):
(FlowThreadController):
(WebCore::FlowThreadController::currentRenderFlowThread):
(WebCore::FlowThreadController::setCurrentRenderFlowThread):
(WebCore::FlowThreadController::isRenderNamedFlowThreadOrderDirty):
(WebCore::FlowThreadController::setIsRenderNamedFlowThreadOrderDirty):
(WebCore::FlowThreadController::renderNamedFlowThreadList):
(WebCore::FlowThreadController::hasRenderNamedFlowThreads):

  • rendering/RenderFlowThread.cpp:

(WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer):
(WebCore::CurrentRenderFlowThreadMaintainer::~CurrentRenderFlowThreadMaintainer):
(WebCore::CurrentRenderFlowThreadDisabler::CurrentRenderFlowThreadDisabler):
(WebCore::CurrentRenderFlowThreadDisabler::~CurrentRenderFlowThreadDisabler):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::nextRendererForNode):
(WebCore::RenderNamedFlowThread::previousRendererForNode):
(WebCore::RenderNamedFlowThread::removeRegionFromThread):
(WebCore::RenderNamedFlowThread::addDependencyOnFlowThread):
(WebCore::RenderNamedFlowThread::removeDependencyOnFlowThread):

  • rendering/RenderNamedFlowThread.h:

(RenderNamedFlowThread):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):
(WebCore::RenderObject::enclosingRenderFlowThread):
(WebCore::RenderObject::willBeDestroyed):

  • rendering/RenderTreeAsText.cpp:

(WebCore::writeRenderNamedFlowThreads):

  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):
(WebCore::RenderView::layout):
(WebCore::RenderView::hasRenderNamedFlowThreads):
(WebCore::RenderView::flowThreadController):

  • rendering/RenderView.h:

(WebCore):
(RenderView):

02:29 Changeset [113841] by commit-queue@webkit.org
  • 3 edits
    119 adds in trunk/LayoutTests

[EFL][DRT] SVG Filters rebaseline
https://bugs.webkit.org/show_bug.cgi?id=83673

Unreviewed, EFL rebaseline.

Bug 83562 fixed programmatically creating filters from JS, this
allows us to unskip a lot of SVG tests. This is part two.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-11

  • platform/efl/Skipped: Removed svg/filters/*.
  • platform/efl/svg/filters/: New baselines.
  • platform/efl/test_expectations.txt: Added one dropShadow filter failure.
02:16 Changeset [113840] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Device Metrics] Implement dimension swapping
https://bugs.webkit.org/show_bug.cgi?id=83676

The change adds a "Swap dimensions" button that swaps the emulated device dimensions to
mimic the device rotation (give that the ORIENTATION_EVENTS feature is disabled in Chromium).

Reviewed by Yury Semikhatsky.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen.prototype._createDeviceMetricsElement.swapDimensionsClicked):
(WebInspector.SettingsScreen.prototype._createDeviceMetricsElement):

01:54 Changeset [113839] by rniwa@webkit.org
  • 3 edits in trunk/Tools

Refactor PerfTestRunner to include file extensions in test names
https://bugs.webkit.org/show_bug.cgi?id=83677

Reviewed by Hajime Morita.

Move the logic that extracts the test name from _process_parser_test_result to _collect_tests.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._collect_tests):
(PerfTestsRunner._run_tests_set):
(PerfTestsRunner._process_parser_test_result): Still replace "/" by ": " to keep the output format.
We can make the said behavior change by simply removing "test_name = re.sub(r'\.\w+$', , test_name)" here.
(PerfTestsRunner._run_single_test):

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(run_test):
(_tests_for_runner):
(test_run_test_set):
(test_run_test_set_kills_drt_per_run):
(test_run_test_pause_before_testing):
(test_run_test_set_for_parser_tests):
(test_collect_tests):
(test_collect_tests_with_skipped_list):

01:52 Changeset [113838] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix compiler warnings for generated CalendarPicker.cpp with VC++
https://bugs.webkit.org/show_bug.cgi?id=83672

Reviewed by Kentaro Hara.

  • make-file-arrays.py:

(main): Do not generate literal integers larger than 127 for
members of char arrays. Use '\xHH' instead.

01:49 Changeset [113837] by philn@webkit.org
  • 8 edits
    75 adds in trunk/LayoutTests

Unreviewed, GTK rebaseline and baselines for new tests.

  • platform/gtk/fast/hidpi/image-set-background-dynamic-expected.txt: Added.
  • platform/gtk/fast/hidpi/image-set-border-image-dynamic-expected.txt: Added.
  • platform/gtk/fast/hidpi/image-set-in-content-dynamic-expected.txt: Added.
  • platform/gtk/fast/table/cell-pref-width-invalidation-expected.txt:
  • platform/gtk/fast/text/text-shadow-no-default-color-expected.txt: Added.
  • platform/gtk/ietestcenter/: Added.
  • platform/gtk/tables/mozilla/bugs/bug2123-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2509-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug34176-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug44505-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug59252-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
01:49 Changeset [113836] by commit-queue@webkit.org
  • 12 edits in trunk

Web Inspector: Disabling Inspector causes build failure on Windows
https://bugs.webkit.org/show_bug.cgi?id=83557

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-04-11
Reviewed by Pavel Feldman.

Source/WebKit/win:

The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
This change brings all such API calls under the guard.

  • WebCoreSupport/WebInspectorClient.cpp:
  • WebInspector.cpp:
  • WebNodeHighlight.cpp:

(WebNodeHighlight::WebNodeHighlight):
(WebNodeHighlight::update):

  • WebNodeHighlight.h:

(WebNodeHighlight):

  • WebView.cpp:

(WebView::WebView):
(WebView::close):
(WebView::initWithFrame):
(WebView::inspector):

  • WebView.h:

(WebView):

Tools:

The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
This change brings all such API calls under the guard.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(LayoutTestController):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::invoke):

01:43 UsingGitWithWebKit edited by dominik.rottsches@intel.com
link to using github page (diff)
01:38 Changeset [113835] by pfeldman@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: fix category -> type refactoring implications.
https://bugs.webkit.org/show_bug.cgi?id=83680

Reviewed by Yury Semikhatsky.

We are now using type identifiers (singulars) as opposed to category identifier (plurals) in the style.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._createFilterStatusBarItems.createFilterElement):
(WebInspector.NetworkLogView.prototype._createFilterStatusBarItems):
(WebInspector.NetworkLogView.prototype._showCategory):
(WebInspector.NetworkLogView.prototype._hideCategory):
(WebInspector.NetworkLogView.prototype._filter):
(WebInspector.NetworkDataGridNode.prototype.refreshResource):
(WebInspector.NetworkDataGridNode.prototype.refreshGraph):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameResourceTreeElement):
(WebInspector.ResourceRevisionTreeElement):

  • inspector/front-end/networkLogView.css:

(.network-log-grid.data-grid .network-type-script .icon):
(.network-log-grid.data-grid.small .network-type-script .icon):
(.network-log-grid.data-grid .network-type-document .icon):
(.network-log-grid.data-grid.small .network-type-document .icon):
(.network-log-grid.data-grid .network-type-stylesheet .icon):
(.network-log-grid.data-grid.small .network-type-stylesheet .icon):
(.network-log-grid.data-grid .network-type-image .icon):
(.network-log-grid.data-grid.small .network-type-image .icon):
(.network-type-document .network-graph-bar):
(.network-type-document.resource-cached .network-graph-bar):
(.network-type-stylesheet .network-graph-bar):
(.network-type-stylesheet.resource-cached .network-graph-bar):
(.network-type-image .network-graph-bar):
(.network-type-image.resource-cached .network-graph-bar):
(.network-type-font .network-graph-bar):
(.network-type-font.resource-cached .network-graph-bar):
(.network-type-script .network-graph-bar):
(.network-type-script.resource-cached .network-graph-bar):
(.network-type-xhr .network-graph-bar):
(.network-type-xhr.resource-cached .network-graph-bar):
(.network-type-websocket .network-graph-bar):
(.network-type-websocket.resource-cached .network-graph-bar):
(.network-log-grid.data-grid.filter-other table.data tr.revealed.network-type-other):

  • inspector/front-end/resourcesPanel.css:

(.resource-sidebar-tree-item.resources-type-image .icon):
(.resources-type-image .image-resource-icon-preview):
(.children.small .resource-sidebar-tree-item.resources-type-image .icon):
(.children.small .resources-type-image .image-resource-icon-preview):
(.resource-sidebar-tree-item.resources-type-document .icon):
(.children.small .resource-sidebar-tree-item.resources-type-document .icon):
(.resource-sidebar-tree-item.resources-type-stylesheet .icon):
(.children.small .resource-sidebar-tree-item.resources-type-stylesheet .icon):
(.resource-sidebar-tree-item.resources-type-font .icon):
(.children.small .resource-sidebar-tree-item.resources-type-font .icon):
(.resource-sidebar-tree-item.resources-type-script .icon):
(.children.small .resource-sidebar-tree-item.resources-type-script .icon):
(.resource-sidebar-tree-item.resources-type-xhr .icon):
(.children.small .resource-sidebar-tree-item.resources-type-xhr .icon):

01:29 Changeset [113834] by philn@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed, GTK gardening.

  • platform/gtk/Skipped: Skip failing ref test
  • platform/gtk/test_expectations.txt: Mark two tests as crashing

and unskip tests needing rebaseline.

00:02 Changeset [113833] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

[GTK] ImageBuffer: Canonical mimeType for encoding implies startsWith('image/')
https://bugs.webkit.org/show_bug.cgi?id=83657

Reviewed by Martin Robinson.

Canonical image mimeTypes begin with "image/", and this is tested by an ASSERT
guard in toDataURL(): that checks the WebCore mimeType registry for image-for-
encoding mimeType. There is no need to also test mimeType.startsWith("image/")
because that is a given.

No new tests. Covered by existing fast/canvas/*toDataURL* tests.

  • platform/graphics/gtk/ImageBufferGtk.cpp:

(WebCore::ImageBuffer::toDataURL):

00:00 Changeset [113832] by philn@webkit.org
  • 5 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r113756.

  • platform/gtk/fast/multicol/table-vertical-align-expected.txt:
  • platform/gtk/fast/overflow/hidden-scrollbar-resize-expected.txt:
  • platform/gtk/fast/repaint/overflow-outline-repaint-expected.txt:
  • platform/gtk/scrollbars/scrollbars-on-positioned-content-expected.txt:
Note: See TracTimeline for information about the timeline view.