Timeline


and

04/18/12:

23:59 Changeset [114617] by mrobinson@webkit.org
  • 1 edit in releases/WebKitGTK/webkit-1.8/Source/WebCore/dom/ShadowRootList.cpp

Fix failed merge

23:56 Changeset [114616] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

[CG] ImageBuffer::toDataURL: Remove alpha stuffing loop when encoding to JPEG
https://bugs.webkit.org/show_bug.cgi?id=84319

Reviewed by Eric Seidel.

No change in behavior. Covered by existing canvas 2d and 3d tests:

canvas/philip/tests/toDataURL.jpeg.alpha.html
fast/canvas/webgl/premultiplyalpha-test.html

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::toDataURL): Remove the alpha stuffing loop and instead,
make JPEG encoder ignore the alpha channel (kCGImageAlphaNoneSkipLast).

23:54 Changeset [114615] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore

Merging r110374

23:42 Changeset [114614] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore

Merging r111601

23:38 Changeset [114613] by mrobinson@webkit.org
  • 4 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merging r111899

23:35 Changeset [114612] by toyoshim@chromium.org
  • 2 edits in trunk/LayoutTests

Unrevieded, rebaseline svg/as-image/img-preserveAspectRatio-support-1.html

  • platform/chromium-mac-leopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
23:35 Changeset [114611] by mrobinson@webkit.org
  • 10 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merging r110323

23:33 Changeset [114610] by mrobinson@webkit.org
  • 6 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore

Fix a failed merge.

23:24 April 2012 Meeting edited by dbates@webkit.org
(diff)
22:40 Changeset [114609] by eae@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove unnecessary rounding/conversions in RenderBoxModelObject
https://bugs.webkit.org/show_bug.cgi?id=84288

Reviewed by Eric Seidel.

No new tests, no change in functionality.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBoxShadow):
Remove unnecessary pixelSnapping logic and casts in paintBoxShadow as
shadow rects are now int based.

22:21 Changeset [114608] by commit-queue@webkit.org
  • 6 edits
    3 adds in trunk

[BlackBerry] Parsed Cookie's m_hasDefaultDomain is not needed.
https://bugs.webkit.org/show_bug.cgi?id=82830

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-18
Reviewed by George Staikos.

Source/WebCore:

RFC 2965
3.2.2
Domain = value
If an explicitly specified value does not start with a dot, the user agent supplies
a leading dot.
3.3.1
Domain Defaults to the effective request-host. (Note that because there is no dot
at the beginning of effective request-host, the default Domain can only domain-match
itself.)

The first char can show the difference even though it is from the cookie database.
But m_hasDefaultDomain is set to false if the cookie is from database although the
domain is host as a default value. So m_hasDefaultDomain sometimes is wrong.

In sum, we shouldn't use m_hasDefaultDomain.

Test: http/tests/security/cookies/cookies-wrong-domain-rejected.php

  • platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::shouldRejectForSecurityReason):

  • platform/blackberry/CookieParser.cpp:

(WebCore::CookieParser::parseOneCookie):

  • platform/blackberry/ParsedCookie.cpp:

(WebCore::ParsedCookie::ParsedCookie):

  • platform/blackberry/ParsedCookie.h:

(ParsedCookie):

LayoutTests:

  • http/tests/security/cookies/cookies-wrong-domain-rejected-expected.txt: Added.
  • http/tests/security/cookies/cookies-wrong-domain-rejected-result.php: Added.
  • http/tests/security/cookies/cookies-wrong-domain-rejected.php: Added.
21:51 Changeset [114607] by enne@google.com
  • 6 edits in trunk/Source/WebCore

[chromium] Consolidate adjustTextRenderMode copypasta into Skia context
https://bugs.webkit.org/show_bug.cgi?id=83840

Reviewed by James Robinson.

The same logic to decide when to make text use LCD rendering is copy
and pasted in all the different font classes. It seems like this
should live in a single place.

  • platform/graphics/harfbuzz/FontHarfBuzz.cpp:

(WebCore::Font::drawGlyphs):
(WebCore::Font::drawComplexText):

  • platform/graphics/skia/FontSkia.cpp:

(WebCore::Font::drawGlyphs):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::adjustTextRenderMode):
(WebCore):
(WebCore::PlatformContextSkia::couldUseLCDRenderedText):

  • platform/graphics/skia/PlatformContextSkia.h:

(PlatformContextSkia):

  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::setupPaintForFont):

21:45 Changeset [114606] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium/mac] Fix build.
https://bugs.webkit.org/show_bug.cgi?id=84314

Unreviewed, build fix after http://trac.webkit.org/changeset/114604

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):

21:33 April 2012 Meeting edited by luxtella@company100.net
(diff)
21:07 April 2012 Meeting edited by thakis@chromium.org
(diff)
21:02 April 2012 Meeting edited by dglazkov@chromium.org
(diff)
20:51 Changeset [114605] by hbono@chromium.org
  • 13 edits
    2 adds in trunk

Split SpellChecker::didCheck() to SpellChecker::didCheckSucceeded() and SpellChecker::didCheckCanceled()
https://bugs.webkit.org/show_bug.cgi?id=83748

Reviewed by Ryosuke Niwa.

Source/WebCore:

The current SpellChecker::didCheck() does not delete existing markers. It causes
a problem that it leaves misspelled markers when a spellchecker client finishes
checking text successfully. This change splits this function to didCheckSucceeded()
and didCheckCanceled() so the SpellChecker class can delete existing markers
when its client finishes checking text successfully. (We do not have to erase
existing markers when the client needs to cancel a text-check request.)

Test: platform/chromium/editing/spelling/delete-misspelled-word.html

  • WebCore.exp.in: Replaced SpellChecker::didCheck with SpellChecker::didCheckSucceeded.
  • editing/SpellChecker.cpp:

(WebCore::SpellChecker::didCheckSucceeded): Added.
(WebCore):
(WebCore::SpellChecker::didCheckCanceled): Added.

  • editing/SpellChecker.h:

(SpellChecker): Added didCheckSucceeded and didCheckCanceled. Also changed didCheck to a private function.

Source/WebKit/chromium:

This change adds a new API WebTextCheckingCompletion::didCancelCheckingText(),
which encapsulates SpellChecker::didCheckCanceled() and implements it so
Chromium can use it.

  • public/WebTextCheckingCompletion.h:

(WebKit::WebTextCheckingCompletion::didCancelCheckingText):

  • src/WebTextCheckingCompletionImpl.cpp:

(WebKit::WebTextCheckingCompletionImpl::didFinishCheckingText):
(WebKit):
(WebKit::WebTextCheckingCompletionImpl::didCancelCheckingText):

  • src/WebTextCheckingCompletionImpl.h:

(WebTextCheckingCompletionImpl):

Source/WebKit/mac:

This change replaces a call for SpellChecker::didCheck() with one for
SpellChecker::didCheckSucceeded() because didCheck has been split into
didCheckSucceeded(0 and didCheckCanceled().

  • WebCoreSupport/WebEditorClient.mm:

(-[WebEditorSpellCheckResponder perform]): Replaced didCheck with didCheckSucceeded.

Tools:

This change replaces a call for SpellChecker::didCheck() with one for
SpellChecker::didCheckCenceled() because didCheck() has been split into
didCheckSucceeded() and didCheckCanceled().

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::requestCheckingOfText): Replaced didCheck with didCheckCanceled.

LayoutTests:

The current SpellChecker::didCheck() does not delete existing markers. It causes
a problem that it leaves misspelled markers when a spellchecker client finishes
checking text successfully. This change splits this function to didCheckSucceeded()
and didCheckCanceled() so the SpellChecker class can delete existing markers
when its client finishes checking text successfully. (We do not have to erase
existing markers when the client needs to cancel a text-check request.)

  • platform/chromium/editing/spelling/delete-misspelled-word-expected.txt: Added.
  • platform/chromium/editing/spelling/delete-misspelled-word.html: Added.
20:29 April 2012 Meeting edited by thakis@chromium.org
(diff)
20:29 April 2012 Meeting edited by thakis@chromium.org
(diff)
20:26 April 2012 Meeting edited by thakis@chromium.org
(diff)
19:48 Changeset [114604] by jamesr@google.com
  • 15 edits
    2 moves
    3 deletes in trunk/Source

[chromium] Convert WebPluginContainerImpl over to use WebExternalTextureLayer
https://bugs.webkit.org/show_bug.cgi?id=84120

Reviewed by Adrienne Walker.

Source/Platform:

This adds support for IO surface backed WebExternalTextureLayer, used by CoreAnimation plugins on OS X and moves
some functionality used by multiple WebLayer subclasses up to the base class.

  • chromium/public/WebContentLayer.h:

(WebContentLayer):

  • chromium/public/WebExternalTextureLayer.h:

(WebCore):
(WebExternalTextureLayer):

  • chromium/public/WebLayer.h:

(WebKit):
(WebLayer):
(WebKit::WebLayer::unwrap):

Source/WebCore:

This renames PluginLayerChromium -> TextureLayerChromium since it is now used only as the implementation of
WebExternalTextureLayer and cleans it up slightly.

  • WebCore.gypi:
  • platform/graphics/chromium/TextureLayerChromium.cpp: Renamed from Source/WebCore/platform/graphics/chromium/PluginLayerChromium.cpp.

(WebCore):
(WebCore::TextureLayerChromium::create):
(WebCore::TextureLayerChromium::TextureLayerChromium):
(WebCore::TextureLayerChromium::createCCLayerImpl):
(WebCore::TextureLayerChromium::drawsContent):
(WebCore::TextureLayerChromium::setTextureId):
(WebCore::TextureLayerChromium::setFlipped):
(WebCore::TextureLayerChromium::setUVRect):
(WebCore::TextureLayerChromium::setIOSurfaceProperties):
(WebCore::TextureLayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/TextureLayerChromium.h: Renamed from Source/WebCore/platform/graphics/chromium/PluginLayerChromium.h.

(WebCore):
(TextureLayerChromium):
(WebCore::TextureLayerChromium::flipped):
(WebCore::TextureLayerChromium::uvRect):

Source/WebKit/chromium:

This ports WebPluginContainerImpl over to use WebExternalTextureLayer instead of directly using a *LayerChromium
type for better layering and code sharing. The changes to WebPluginContainerImpl are fairly straightforward. In
addition to renames I also moved some state tracking into WPCI instead of having it exposed on the interface. I
also removed the WebExternalTextureLayerImpl intermediate class since it wasn't doing anything useful.

  • WebKit.gyp:
  • WebKit.gypi:
  • src/WebContentLayer.cpp:
  • src/WebExternalTextureLayer.cpp:

(WebKit::WebExternalTextureLayer::create):
(WebKit::WebExternalTextureLayer::setTextureId):
(WebKit::WebExternalTextureLayer::setIOSurfaceProperties):
(WebKit::WebExternalTextureLayer::setFlipped):
(WebKit::WebExternalTextureLayer::flipped):
(WebKit::WebExternalTextureLayer::setUVRect):
(WebKit::WebExternalTextureLayer::uvRect):
(WebKit::WebExternalTextureLayer::WebExternalTextureLayer):

  • src/WebExternalTextureLayerImpl.cpp: Removed.
  • src/WebExternalTextureLayerImpl.h: Removed.
  • src/WebLayer.cpp:

(WebKit::WebLayer::invalidateRect):
(WebKit):
(WebKit::WebLayer::invalidate):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::setBackingTextureId):
(WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
(WebKit::WebPluginContainerImpl::commitBackingTexture):
(WebKit::WebPluginContainerImpl::setOpaque):
(WebKit::WebPluginContainerImpl::platformLayer):
(WebKit::WebPluginContainerImpl::WebPluginContainerImpl):

  • src/WebPluginContainerImpl.h:

(WebCore):
(WebPluginContainerImpl):

  • tests/WebExternalTextureLayerImplTest.cpp: Removed.
  • tests/WebLayerTest.cpp:
19:44 April 2012 Meeting edited by rniwa@webkit.org
(diff)
19:32 Changeset [114603] by commit-queue@webkit.org
  • 9 edits in trunk

Expose attack, release as DynamicsCompressorNode's attributes.
https://bugs.webkit.org/show_bug.cgi?id=81221

Patch by Raymond Toy <rtoy@google.com> on 2012-04-18
Reviewed by Chris Rogers.

Source/WebCore:

  • Modules/webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
(WebCore::DynamicsCompressorNode::process):

  • Modules/webaudio/DynamicsCompressorNode.h:

(WebCore::DynamicsCompressorNode::attack):
(WebCore::DynamicsCompressorNode::releaseTime):
(DynamicsCompressorNode):

  • Modules/webaudio/DynamicsCompressorNode.idl: Add attack and

release attributes.

  • bindings/scripts/CodeGeneratorObjC.pm:

(SkipAttribute): Skip release()
(GenerateHeader): Call SkipAttribute for getters/setters.

  • platform/audio/DynamicsCompressor.h:

(DynamicsCompressor):

LayoutTests:

  • webaudio/dynamicscompressor-basic-expected.txt:
  • webaudio/dynamicscompressor-basic.html:
19:02 Changeset [114602] by dpranke@chromium.org
  • 2 edits in trunk/Tools

Fix failure in test-webkitpy after r114583.

Unreviewed, build fix.

Updating the call site in r114583 w/o updating the test caused
the test to fail. Somehow I forgot to run the unit tests :(.

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumDriverTest.test_crash_log):

19:01 Changeset [114601] by danakj@chromium.org
  • 10 edits in trunk/Source

[chromium] Simplify occlusion tracker API by passing layer iterator data
https://bugs.webkit.org/show_bug.cgi?id=84088

Reviewed by Adrienne Walker.

Source/WebCore:

Previously three methods lived in the API and you needed to call the
appropriate method (with different amounts of data) depending on what
the current layer iterator was representing.

This makes usage of the occlusion tracker simpler to read and harder
to mess up, by just passing in the layer iterator at each step of the
iteration process.

Covered by existing tests.

  • platform/graphics/chromium/cc/CCLayerIterator.h:

(WebCore):
(CCLayerIteratorPosition):
(CCLayerIterator):
(WebCore::CCLayerIterator::operator const CCLayerIteratorPosition<LayerType>):

  • platform/graphics/chromium/cc/CCLayerTilingData.cpp:

(WebCore::CCLayerTilingData::opaqueRegionInLayerRect):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintLayerContents):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::enterLayer):
(WebCore):
(WebCore::::leaveLayer):

  • platform/graphics/chromium/cc/CCOcclusionTracker.h:

(CCOcclusionTrackerBase):

Source/WebKit/chromium:

  • tests/CCOcclusionTrackerTest.cpp:

(CCOcclusionTrackerTestMainThreadTypes):
(CCOcclusionTrackerTestImplThreadTypes):
(WebKitTests::CCOcclusionTrackerTest::CCOcclusionTrackerTest):
(WebKitTests::CCOcclusionTrackerTest::calcDrawEtc):
(CCOcclusionTrackerTest):
(WebKitTests::CCOcclusionTrackerTest::enterLayer):
(WebKitTests::CCOcclusionTrackerTest::leaveLayer):
(WebKitTests::CCOcclusionTrackerTest::visitLayer):
(WebKitTests::CCOcclusionTrackerTest::enterContributingSurface):
(WebKitTests::CCOcclusionTrackerTest::leaveContributingSurface):
(WebKitTests::CCOcclusionTrackerTest::visitContributingSurface):
(WebKitTests::CCOcclusionTrackerTest::resetLayerIterator):
(WebKitTests::CCOcclusionTrackerTestIdentityTransforms::runMyTest):
(WebKitTests::CCOcclusionTrackerTestRotatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestTranslatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestChildInRotatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
(WebKitTests::CCOcclusionTrackerTestFilters::runMyTest):
(WebKitTests::CCOcclusionTrackerTestReplicaDoesOcclude::runMyTest):
(WebKitTests::CCOcclusionTrackerTestReplicaWithClipping::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerScissorRectOutsideChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestScreenScissorRectOutsideChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerScissorRectOverChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestScreenScissorRectOverChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerScissorRectPartlyOverChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestScreenScissorRectPartlyOverChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerScissorRectOverNothing::runMyTest):
(WebKitTests::CCOcclusionTrackerTestScreenScissorRectOverNothing::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerScissorRectForLayerOffOrigin::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOpaqueContentsRegionEmpty::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty::runMyTest):
(WebKitTests::CCOcclusionTrackerTest3dTransform::runMyTest):
(WebKitTests::CCOcclusionTrackerTestPerspectiveTransform::runMyTest):
(WebKitTests::CCOcclusionTrackerTestPerspectiveTransformBehindCamera::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerBehindCameraDoesNotOcclude::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationTranslateOnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesToParent::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesWithClipping::runMyTest):
(WebKitTests::CCOcclusionTrackerTestReplicaOccluded::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceWithReplicaUnoccluded::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceAndReplicaOccludedDifferently::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceChildOfSurface::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceChildOfClippingSurface::runMyTest):

  • tests/CCQuadCullerTest.cpp:

(WebCore):
(WebCore::makeLayer):
(WebCore::appendQuads):
(WebCore::TEST):

18:47 Changeset [114600] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update.

  • platform/gtk/test_expectations.txt: Mark new fast/table test as failing.
18:30 Changeset [114599] by jamesr@google.com
  • 9 edits in trunk/Source

[chromium] Add canBeginFrame state to CCSchedulerStateMachine to suppress initialization before our surface is available
https://bugs.webkit.org/show_bug.cgi?id=84301

Reviewed by Adrienne Walker.

Source/WebCore:

If our composited surface isn't ready yet, then the compositor may initialize in a state where the first
makeContextCurrent() fails. This adds a new state to the scheduler that we can use to suppress initialization
until we get notified that the surface is ready. I'll add the plumbing for actually notifying in a follow-up.

Updated CCSchedulerTest / CCSchedulerStateMachineTest unit tests.

  • platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::setCanBeginFrame):
(WebCore):

  • platform/graphics/chromium/cc/CCScheduler.h:

(CCScheduler):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::nextAction):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.h:

(WebCore::CCSchedulerStateMachine::setCanBeginFrame):
(CCSchedulerStateMachine):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::initializeImplOnImplThread):

Source/WebKit/chromium:

Update unit tests for new canBeginFrame bit.

  • tests/CCSchedulerStateMachineTest.cpp:

(WebCore::TEST):
(WebCore):

  • tests/CCSchedulerTest.cpp:

(WebKitTests::TEST):

18:22 Changeset [114598] by mrobinson@webkit.org
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merging r112935

18:22 Changeset [114597] by mrobinson@webkit.org
  • 4 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore

Merging r112596

18:20 Changeset [114596] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore

Merging r112596

18:20 Changeset [114595] by mrobinson@webkit.org
  • 7 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merging r112200

18:10 Changeset [114594] by fpizlo@apple.com
  • 21 edits in trunk/LayoutTests

JSC testing should have complete coverage over typed array types
https://bugs.webkit.org/show_bug.cgi?id=84302

Rubber stamped by Geoff Garen.

Changed calls to shouldBe("...", "...") to be more informative, per Geoff's
suggestion.

  • fast/js/dfg-float32array-expected.txt:
  • fast/js/dfg-int16array-expected.txt:
  • fast/js/dfg-int32array-expected.txt:
  • fast/js/dfg-int32array-overflow-values-expected.txt:
  • fast/js/dfg-int8array-expected.txt:
  • fast/js/dfg-uint16array-expected.txt:
  • fast/js/dfg-uint32array-expected.txt:
  • fast/js/dfg-uint32array-overflow-values-expected.txt:
  • fast/js/dfg-uint8array-expected.txt:
  • fast/js/dfg-uint8clampedarray-expected.txt:
  • fast/js/script-tests/dfg-float32array.js:
  • fast/js/script-tests/dfg-int16array.js:
  • fast/js/script-tests/dfg-int32array-overflow-values.js:
  • fast/js/script-tests/dfg-int32array.js:
  • fast/js/script-tests/dfg-int8array.js:
  • fast/js/script-tests/dfg-uint16array.js:
  • fast/js/script-tests/dfg-uint32array-overflow-values.js:
  • fast/js/script-tests/dfg-uint32array.js:
  • fast/js/script-tests/dfg-uint8array.js:
  • fast/js/script-tests/dfg-uint8clampedarray.js:
18:05 Changeset [114593] by mrobinson@webkit.org
  • 22 edits
    4 adds in releases/WebKitGTK/webkit-1.8

Merging r112184

18:03 Changeset [114592] by mrobinson@webkit.org
  • 7 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merging r112119

18:02 Changeset [114591] by mrobinson@webkit.org
  • 4 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merging r112012

17:55 Changeset [114590] by mrobinson@webkit.org
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merging r111912

17:52 Changeset [114589] by mrobinson@webkit.org
  • 6 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merging r111895

17:32 Changeset [114588] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore

Merging r110139

17:15 Changeset [114587] by fpizlo@apple.com
  • 11 edits
    9 adds in trunk

JSC testing should have complete coverage over typed array types
https://bugs.webkit.org/show_bug.cgi?id=84302

Source/JavaScriptCore:

Reviewed by Geoff Garen.

Added Uint8ClampedArray to the set of typed arrays that are supported by jsc
command-line.

  • JSCTypedArrayStubs.h:

(JSC):

  • jsc.cpp:

(GlobalObject::finishCreation):

Tools:

Reviewed by Geoff Garen.

Made run-fast-jsc print something and a newline if jsc threw an exception or
otherwise returned with an error code, but did not crash.

  • Scripts/run-fast-jsc:

LayoutTests:

Reviewed by Geoff Garen.

Added tests for uint8 and uint16 arrays. Added a test for uint32 arrays that
does not focus entirely on overflow values.

Also added the typed array tests to the repertoire that can be run by
run-fast-jsc.

  • fast/js/dfg-int16array-expected.txt:
  • fast/js/dfg-int8array-expected.txt:
  • fast/js/dfg-uint16array-expected.txt: Added.
  • fast/js/dfg-uint16array.html: Added.
  • fast/js/dfg-uint32array-expected.txt: Added.
  • fast/js/dfg-uint32array.html: Added.
  • fast/js/dfg-uint8array-expected.txt: Added.
  • fast/js/dfg-uint8array.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-int16array.js:
  • fast/js/script-tests/dfg-int8array.js:
  • fast/js/script-tests/dfg-uint16array.js: Added.

(getter1):
(setter1):
(getter2):
(setter2):
(getter3):
(setter3):
(getter4):
(setter4):
(getters.getter1.a):
(.a):
(setters.setter1.a):
(safeGetter):
(safeSetter):

  • fast/js/script-tests/dfg-uint32array.js: Added.

(getter1):
(setter1):
(getter2):
(setter2):
(getter3):
(setter3):
(getter4):
(setter4):
(getters.getter1.a):
(.a):
(setters.setter1.a):
(safeGetter):
(safeSetter):

  • fast/js/script-tests/dfg-uint8array.js: Added.

(getter1):
(setter1):
(getter2):
(setter2):
(getter3):
(setter3):
(getter4):
(setter4):
(getters.getter1.a):
(.a):
(setters.setter1.a):
(safeGetter):
(safeSetter):

17:11 Changeset [114586] by philn@webkit.org
  • 4 edits in trunk/LayoutTests

[GTK] r114021 triggered media flakyness
https://bugs.webkit.org/show_bug.cgi?id=83874

Reviewed by Eric Carlson.

Fix-up use of setMediaPlaybackRequiresUserGesture() in two media
tests.

  • media/video-load-require-user-gesture.html:
  • media/video-play-require-user-gesture.html:
  • platform/gtk/test_expectations.txt:
17:05 Changeset [114585] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update.

  • platform/gtk/test_expectations.txt: Unflag some tests now passing.
17:04 Changeset [114584] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Somehow, there's an errant backslash in my last WTF patch
https://bugs.webkit.org/show_bug.cgi?id=84290

Patch by Myles Maxfield <mmaxfield@google.com> on 2012-04-18
Reviewed by Andreas Kling.

  • wtf/StdLibExtras.h:

(WTF::roundUpToMultipleOf):

16:56 Changeset [114583] by dpranke@chromium.org
  • 2 edits in trunk/Tools

Fix crash in chromium.py after r114877.

Unreviewed, build fix.

Missed updating one call site for get_crash_log() :(.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumDriver.run_test):

16:38 Changeset [114582] by mrobinson@webkit.org
  • 3 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore

Merging r111775

16:34 Changeset [114581] by mrobinson@webkit.org
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merging r111714

16:32 Changeset [114580] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[Chromium] Solid color layers should respect opacity value.
https://bugs.webkit.org/show_bug.cgi?id=84197

Patch by David Reveman <reveman@chromium.org> on 2012-04-18
Reviewed by Adrienne Walker.

Source/WebCore:

Fold opacity into shader color for solid color layers.

Test: CCSolidColorLayerImplTest.verifyCorrectOpacityInQuad

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawSolidColorQuad):

Source/WebKit/chromium:

  • tests/CCSolidColorLayerImplTest.cpp:

(CCLayerTestCommon::TEST):
(CCLayerTestCommon):

16:29 Changeset [114579] by philn@webkit.org
  • 2 edits in trunk/Tools

[GTK] NRWT bails out if more than one X server runs on the machine
https://bugs.webkit.org/show_bug.cgi?id=84276

Reviewed by Dirk Pranke.

Set up GTK driver's Xvfb display number based on Xorg servers
currently running.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkDriver._start):
(GtkDriver._start.x_filter):

16:23 Changeset [114578] by mrobinson@webkit.org
  • 3 edits
    5 adds in releases/WebKitGTK/webkit-1.8

Merging r111556

16:17 Changeset [114577] by dpranke@chromium.org
  • 10 edits in trunk/Tools

run-webkit-tests picked up an old crash log
https://bugs.webkit.org/show_bug.cgi?id=84196

Reviewed by Ryosuke Niwa.

Modify the crash log-finding code so that we can
limit our search to logs newer than X - this prevents
us from finding old crash logs for a given process/pid
combination even when the PIDs might've wrapped.

Also fix a bug in filesystem_mock where files_under() would
return paths that didn't exist.

  • Scripts/webkitpy/common/system/crashlogs.py:

(CrashLogs.find_newest_log):
(CrashLogs._find_newest_log_darwin):

  • Scripts/webkitpy/common/system/crashlogs_unittest.py:

(CrashLogsTest.test_find_log_darwin):
(CrashLogsTest.test_find_log_darwin.bad_read):
(CrashLogsTest):

  • Scripts/webkitpy/common/system/filesystem_mock.py:

(MockFileSystem.files_under):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port._get_crash_log):

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort._get_crash_log):

  • Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort._get_crash_log):

  • Scripts/webkitpy/layout_tests/port/port_testcase.py:

(PortTestCase.test_get_crash_log):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitDriver.run_test):

16:11 April 2012 Meeting edited by dbarton@mathscribe.com
(diff)
16:10 Changeset [114576] by pilgrim@chromium.org
  • 5 edits in trunk/Source

[Chromium] Call prefetchDNS directly
https://bugs.webkit.org/show_bug.cgi?id=84262

Reviewed by Kentaro Hara.

Part of a series, see tracking bug 82948.

Source/WebCore:

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

  • platform/network/chromium/DNSChromium.cpp:

(WebCore::prefetchDNS):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore):

16:08 Changeset [114575] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

jsc command line should support typed arrays by default
https://bugs.webkit.org/show_bug.cgi?id=84298

Rubber stamped by Gavin Barraclough.

  • JSCTypedArrayStubs.h:

(JSC):

  • jsc.cpp:

(GlobalObject::finishCreation):

16:07 Changeset [114574] by jchaffraix@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION(102040): Auto-table layout with percent width doesn't shrink-to-fit content a cell with colspan
https://bugs.webkit.org/show_bug.cgi?id=84260

Reviewed by Ojan Vafai.

Source/WebCore:

Tests: fast/table/td-width-fifty-percent-regression-expected.html

fast/table/td-width-fifty-percent-regression.html

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
As we are spreading the cell's min / max logical width, we should be updating them.
This prevents the following logic getting confused and allocating more than needed.

LayoutTests:

  • fast/table/td-width-fifty-percent-regression-expected.html: Added.
  • fast/table/td-width-fifty-percent-regression.html: Added.
15:59 Changeset [114573] by dimich@chromium.org
  • 2 edits in branches/chromium/1084/Source/WebCore

Merge 114342 - Auto-sized frames may be taller than expected
https://bugs.webkit.org/show_bug.cgi?id=84106

Patch by Andrei Burago <aburago@chromium.org> on 2012-04-16
Reviewed by David Levin.

No new tests. The repro steps require using Chrome notifications on Win.

  • page/FrameView.cpp:

(WebCore::FrameView::autoSizeIfEnabled):

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10035046

15:57 Changeset [114572] by dimich@chromium.org
  • 4 edits in branches/chromium/1084/Source/WebCore

Merge 113287 - Auto-size may not work on first load
https://bugs.webkit.org/show_bug.cgi?id=82989

Patch by Andrei Burago <aburago@chromium.org> on 2012-04-04
Reviewed by David Levin.

No new tests. The only known repro scenario involves using chrome with a third-party extension,
which makes making a test out of it problematic.

  • dom/Document.cpp:

(WebCore::Document::implicitClose):

  • page/FrameView.cpp:

(WebCore::FrameView::autoSizeIfEnabled):

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10116046

15:49 Changeset [114571] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update.

  • platform/gtk/test_expectations.txt: Mark some tests as crashing

in debug builds due to bug 63611.

15:31 Changeset [114570] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

JSVALUE32_64 should be able to perform division on ARM without crashing, and variables
forced double should not be scrambled when performing OSR entry
https://bugs.webkit.org/show_bug.cgi?id=84272

Reviewed by Geoff Garen.

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

15:29 Changeset [114569] by jschuh@chromium.org
  • 2 edits in trunk/Source/WebCore

Win8 builds usually fail due to cygwin rebasing
https://bugs.webkit.org/show_bug.cgi?id=84274

Reviewed by Dirk Pranke.

Cygwin can fail to spawn children if the DLL is rebased. This happens
frequently enough on Windows 8 that we should retry on failure.

No new tests. No behavior changed.

  • bindings/scripts/preprocessor.pm:

(applyPreprocessor):

15:03 Changeset [114568] by leviw@chromium.org
  • 2 edits in trunk/Source/WebCore

Add explicit template instantiation to chromium/PopupListBox.cpp to prepare for sub-pixel layout
https://bugs.webkit.org/show_bug.cgi?id=84264

Reviewed by Eric Seidel.

Explicitly instantiating integer max and min templates to fix compilation in Chromium. We
intentionally truncated these values in platform code, which matches earlier behavior.
See https://trac.webkit.org/wiki/LayoutUnit for details.

No new tests. No change in behavior.

  • platform/chromium/PopupListBox.cpp:

(WebCore::PopupListBox::paintRow):
(WebCore::PopupListBox::layout):

14:53 Changeset [114567] by jer.noble@apple.com
  • 4 edits in trunk/Source

Full Screen mode does not preserve CALayer ordering after exiting.
https://bugs.webkit.org/show_bug.cgi?id=83931

Reviewed by Eric Carlson.

When swapping the placeholder and web views, use -[NSView addSubview:positioned:relativeTo:]
instead of -[NSView replaceSubview:with:], as the latter does not preserve the relative order
of the view's backing CALayers.

Source/WebKit/mac:

  • WebView/WebFullScreenController.mm:

(-[WebFullScreenController _swapView:with:]):

Source/WebKit2:

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController _swapView:with:]):

14:51 Changeset [114566] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

Prevent potential null pointer dereference in CSSStyleSelector::applyProperty().
https://bugs.webkit.org/show_bug.cgi?id=84267

Reviewed by Kentaro Hara.

No new tests / code cleanup found via static analysis.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

14:45 Changeset [114565] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

JavaScriptCore.gypi not current
https://bugs.webkit.org/show_bug.cgi?id=84224

Patch by Don Olmstead <don.olmstead@am.sony.com> on 2012-04-18
Reviewed by Eric Seidel.

Updated JavaScriptCore.gypi to contain the latest sources. Removed os-win32 as it wasn't used. Also removed references to ICU files in the gypi file as ICU is most likely specified by the port itself.

Private and public header files were determined by looking at copy-files.cmd within Apple's Visual Studio directory.

14:34 Changeset [114564] by xan@webkit.org
  • 12 edits
    1 copy
    1 add in releases/WebKitGTK/webkit-1.8

[Soup] DNS prefetching spams resolver, shoots self in the foot
https://bugs.webkit.org/show_bug.cgi?id=41630

Reviewed by Martin Robinson.

.:

Bump libsoup and glib dependencies.

  • Source/cmake/OptionsEfl.cmake:
  • configure.ac:

Source/WebCore:

Added generic DNSResolveQueue class to throttle DNS
prefetches. It's an abstract refactoring of CFNET's
DNSResolveQueue. Platform specific methods implemented for soup
and CFNET backends.

No new tests required as we're just refactoring existing code to
be used by two different ports.

  • CMakeLists.txt: added new file.
  • GNUmakefile.list.am: ditto.
  • WebCore.vcproj/WebCore.vcproj: ditto.
  • WebCore.xcodeproj/project.pbxproj: ditto.
  • platform/network/DNSResolveQueue.cpp: Added.

(WebCore):
(WebCore::DNSResolveQueue::add): adds a new host to be prefetched.
(WebCore::DNSResolveQueue::fired): by using a delay we coalesce
several prefetch requests and try to resolve them all here.

  • platform/network/DNSResolveQueue.h: Added.

(WebCore):
(DNSResolveQueue): class that implements DNS prefetch
throttling using a template pattern.
(WebCore::DNSResolveQueue::shared):
(WebCore::DNSResolveQueue::decrementRequestCount):

  • platform/network/cf/DNSCFNet.cpp:

(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences):
(WebCore::DNSResolveQueue::platformResolve):

  • platform/network/soup/DNSSoup.cpp:

(WebCore):
(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences):
(WebCore::resolvedCallback):
(WebCore::DNSResolveQueue::platformResolve):
(WebCore::prefetchDNS):

Tools:

Bump libsoup and glib dependencies.

  • efl/jhbuild.modules:
  • gtk/jhbuild.modules:

Conflicts:

Tools/efl/jhbuild.modules

14:34 Changeset [114563] by xan@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore

Build error: DNSSoup.cpp:30: fatal error: CString.h: No such file or
directory
https://bugs.webkit.org/show_bug.cgi?id=81093

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-14
Reviewed by Philippe Normand.

Fix build error introduced by r110669.

  • platform/network/soup/DNSSoup.cpp:
14:34 Changeset [114562] by xan@webkit.org
  • 11 edits
    1 copy in releases/WebKitGTK/webkit-1.8/Source/WebCore

[GTK] Use the same DNS prefetching path than the other ports.
https://bugs.webkit.org/show_bug.cgi?id=80997

Reviewed by Martin Robinson.

This patch basically reverts r56128. There is no need to add an
special code path for GTK+ DNS pre-fetching because the main
reason to do that (some potential changes in libsoup) is not
going to happen. It also reduces the amount of DNS queries by
adding a NULL hostname check.

No need for new tests as this just moves code around.

  • GNUmakefile.list.am:
  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::parseAttribute):

  • html/HTMLLinkElement.cpp:
  • loader/LinkLoader.cpp:

(WebCore::LinkLoader::loadLink):

  • page/Chrome.cpp:

(WebCore::Chrome::mouseDidMoveOverElement):

  • platform/network/DNS.h:

(WebCore):

  • platform/network/ResourceHandle.cpp:
  • platform/network/ResourceHandle.h:

(ResourceHandle):

  • platform/network/chromium/DNSChromium.cpp:
  • platform/network/soup/DNSSoup.cpp: restored.

(WebCore):
(WebCore::prefetchDNS):

  • platform/network/soup/ResourceHandleSoup.cpp:
14:33 WebKitGTK/1.8.x edited by xan@webkit.org
(diff)
14:27 April 2012 Meeting edited by eoconnor@apple.com
(diff)
14:26 Changeset [114561] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Chromium compile of WebDatabase.cpp fails without SQL_DATABASE
https://bugs.webkit.org/show_bug.cgi?id=84212

Patch by Myles Maxfield <mmaxfield@google.com> on 2012-04-18
Reviewed by Kentaro Hara.

  • src/WebDatabase.cpp:

(WebCore::AbstractDatabase::isSyncDatabase):

14:21 Changeset [114560] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

Prevent switch case fallthrough in StylePropertySet::getPropertyValue().
https://bugs.webkit.org/show_bug.cgi?id=84266

Reviewed by Kentaro Hara.

No new tests / code cleanup found by static analysis.

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getPropertyValue):

14:04 Changeset [114559] by dpranke@chromium.org
  • 5 edits in trunk/Tools

nrwt: support additional test expectations files
https://bugs.webkit.org/show_bug.cgi?id=84222

Reviewed by Ojan Vafai.

This patch adds an --additional-expectations flag that can be
used to point to more files that will override the default set
of expectations. This will allow us to remove the
'google_chrome' ports and eventually help to clean up override
handling in the chromium ports and unify expectations files and
Skipped files; this can also be used to specify overrides for
tests that run differently on a given machine.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.test_expectations_overrides):

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.test_expectations_overrides):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_additional_expectations):

14:01 Changeset [114558] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

CSSValuePool: Make numeric value caches fixed-size arrays.
<http://webkit.org/b/84268>

Reviewed by Antti Koivisto.

Change the numeric CSSPrimitiveValue caches in CSSValuePool from HashMaps to
fixed-size arrays of RefPtr<CSSPrimitiveValue>s.

This is more space efficient and doesn't incur the cost of a hash lookup every
time a numeric CSSPrimitiveValue is needed. We retain the limit of caching
only values between 0-255 for now.

  • css/CSSValuePool.cpp:

(WebCore::CSSValuePool::CSSValuePool):
(WebCore::CSSValuePool::createValue):

  • css/CSSValuePool.h:

(CSSValuePool):

13:53 Changeset [114557] by danakj@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Rename overdraw histograms so we can use field trials in histograms.xml
https://bugs.webkit.org/show_bug.cgi?id=83500

Reviewed by James Robinson.

  • platform/graphics/chromium/cc/CCOverdrawMetrics.cpp:

(WebCore::CCOverdrawMetrics::recordMetricsInternal):

13:52 Changeset [114556] by eae@chromium.org
  • 528 edits
    14 copies
    1 delete in branches/subpixellayout

Merge trunk changes up until 114550 into subpixel branch.

13:47 Changeset [114555] by jer.noble@apple.com
  • 2 edits in trunk/Tools

Lion Production Test failing with error: "Failed to stop httpd: pid file still exists" https://bugs.webkit.org/show_bug.cgi?id=84177

Reviewed by Dirk Pranke.

Try to delete the pid file left by Apache in the case it was killed forcefully.

  • Scripts/webkitpy/layout_tests/servers/apache_http_server.py:

(LayoutTestApacheHttpd._stop_running_server):

13:46 Changeset [114554] by fpizlo@apple.com
  • 17 edits
    2 adds in branches/dfgopt/Source/JavaScriptCore

DFG should have constant propagation
https://bugs.webkit.org/show_bug.cgi?id=84004

Reviewed by Gavin Barraclough.

Changes AbstractValue to be able to hold a "set" of constants, where
the maximum set size is 1 - so merging a value containing constant A
with another value containing constant B where A != B will result in
the AbstractValue claiming that it does not know any constants (i.e.
it'll just have a predicted type and possible a structure).

Added a constant folding phase that uses this new information to
replace pure operations known to have constant results with
JSConstants. This is OSR-exit-aware, in that it will prepend a Phantom
that refers to all of the kids of the node we replaced.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::beginBasicBlock):
(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::execute):

  • dfg/DFGAbstractState.h:

(AbstractState):

  • dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::clear):
(JSC::DFG::AbstractValue::isClear):
(JSC::DFG::AbstractValue::makeTop):
(JSC::DFG::AbstractValue::clobberValue):
(AbstractValue):
(JSC::DFG::AbstractValue::valueIsTop):
(JSC::DFG::AbstractValue::value):
(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::operator==):
(JSC::DFG::AbstractValue::merge):
(JSC::DFG::AbstractValue::filter):
(JSC::DFG::AbstractValue::validate):
(JSC::DFG::AbstractValue::checkConsistency):
(JSC::DFG::AbstractValue::dump):

  • dfg/DFGAdjacencyList.h:

(JSC::DFG::AdjacencyList::initialize):
(AdjacencyList):
(JSC::DFG::AdjacencyList::reset):

  • dfg/DFGBasicBlock.h:

(JSC::DFG::BasicBlock::BasicBlock):
(BasicBlock):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::constantCSE):
(CSEPhase):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGConstantFoldingPhase.cpp: Added.

(DFG):
(ConstantFoldingPhase):
(JSC::DFG::ConstantFoldingPhase::ConstantFoldingPhase):
(JSC::DFG::ConstantFoldingPhase::run):
(JSC::DFG::performConstantFolding):

  • dfg/DFGConstantFoldingPhase.h: Added.

(DFG):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGGraph.h:

(Graph):
(JSC::DFG::Graph::convertToConstant):

  • dfg/DFGInsertionSet.h:

(JSC::DFG::InsertionSet::execute):

  • dfg/DFGNode.h:

(JSC::DFG::Node::convertToConstant):
(Node):

  • runtime/JSValue.cpp:

(JSC::JSValue::description):

  • runtime/JSValue.h:

(JSValue):

13:37 Changeset [114553] by fpizlo@apple.com
  • 1 edit
    2 adds in branches/dfgopt/Source/JavaScriptCore

Unreviewed, adding files that I forgot to add in http://trac.webkit.org/changeset/114472

  • dfg/DFGSilentRegisterSavePlan.h: Added.

(DFG):
(SilentRegisterSavePlan):
(JSC::DFG::SilentRegisterSavePlan::SilentRegisterSavePlan):
(JSC::DFG::SilentRegisterSavePlan::spillAction):
(JSC::DFG::SilentRegisterSavePlan::fillAction):
(JSC::DFG::SilentRegisterSavePlan::nodeIndex):
(JSC::DFG::SilentRegisterSavePlan::gpr):
(JSC::DFG::SilentRegisterSavePlan::fpr):

  • dfg/DFGSlowPathGenerator.h: Added.

(DFG):
(SlowPathGenerator):
(JSC::DFG::SlowPathGenerator::SlowPathGenerator):
(JSC::DFG::SlowPathGenerator::~SlowPathGenerator):
(JSC::DFG::SlowPathGenerator::generate):
(JSC::DFG::SlowPathGenerator::label):
(JSC::DFG::SlowPathGenerator::call):
(JumpingSlowPathGenerator):
(JSC::DFG::JumpingSlowPathGenerator::JumpingSlowPathGenerator):
(JSC::DFG::JumpingSlowPathGenerator::linkFrom):
(JSC::DFG::JumpingSlowPathGenerator::jumpTo):
(CallSlowPathGenerator):
(JSC::DFG::CallSlowPathGenerator::CallSlowPathGenerator):
(JSC::DFG::CallSlowPathGenerator::call):
(JSC::DFG::CallSlowPathGenerator::setUp):
(JSC::DFG::CallSlowPathGenerator::recordCall):
(JSC::DFG::CallSlowPathGenerator::tearDown):
(CallResultAndNoArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndNoArgumentsSlowPathGenerator::CallResultAndNoArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndNoArgumentsSlowPathGenerator::generateInternal):
(CallResultAndOneArgumentSlowPathGenerator):
(JSC::DFG::CallResultAndOneArgumentSlowPathGenerator::CallResultAndOneArgumentSlowPathGenerator):
(JSC::DFG::CallResultAndOneArgumentSlowPathGenerator::generateInternal):
(CallResultAndTwoArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndTwoArgumentsSlowPathGenerator::CallResultAndTwoArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndTwoArgumentsSlowPathGenerator::generateInternal):
(CallResultAndThreeArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndThreeArgumentsSlowPathGenerator::CallResultAndThreeArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndThreeArgumentsSlowPathGenerator::generateInternal):
(CallResultAndFourArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndFourArgumentsSlowPathGenerator::CallResultAndFourArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndFourArgumentsSlowPathGenerator::generateInternal):
(CallResultAndFiveArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndFiveArgumentsSlowPathGenerator::CallResultAndFiveArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndFiveArgumentsSlowPathGenerator::generateInternal):
(JSC::DFG::slowPathCall):
(AssigningSlowPathGenerator):
(JSC::DFG::AssigningSlowPathGenerator::AssigningSlowPathGenerator):
(JSC::DFG::AssigningSlowPathGenerator::generateInternal):
(JSC::DFG::slowPathMove):

13:34 Changeset [114552] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Chromium] Solid color shader should use premultiplied alpha.
https://bugs.webkit.org/show_bug.cgi?id=84215

Patch by David Reveman <reveman@chromium.org> on 2012-04-18
Reviewed by Adrienne Walker.

For efficiency and consistency, expect premultiplied alpha in
solid color shader.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawDebugBorderQuad):
(WebCore::LayerRendererChromium::drawSolidColorQuad):

  • platform/graphics/chromium/ShaderChromium.cpp:

(WebCore::FragmentShaderColor::getShaderString):

13:23 Changeset [114551] by ap@apple.com
  • 9 edits in trunk/Source

[WK2] Sandbox violations prevent attaching files to gmail messages
https://bugs.webkit.org/show_bug.cgi?id=84263
<rdar://problem/11248260>

Reviewed by Oliver Hunt.

  • page/DragActions.h: Removed the newly added upload action. We cannot know if or when an upload is going to happen - a drop even listener can always get a reference to a File object, and upload it with XMLHttpRequest.
  • page/DragController.cpp: (WebCore::DragController::concludeEditDrag): Removed a separate willPerformDragDestinationAction call for upload action - ther is nothing we'd want to only do when dropping on a file upload button.
13:13 LayoutUnit edited by leviw@chromium.org
(diff)
13:12 Changeset [114550] by eae@chromium.org
  • 2 edits in branches/subpixellayout/Source

WebKit/win cleanup on branch.

13:08 Changeset [114549] by leviw@chromium.org
  • 3 edits in branches/subpixellayout/Source/WebCore/platform/graphics

Merging in r114548.

13:05 Changeset [114548] by leviw@chromium.org
  • 4 edits in trunk/Source/WebCore

GraphicsContextCG's roundToDevicePixels should round even when there's no transform
https://bugs.webkit.org/show_bug.cgi?id=84191

Reviewed by Eric Seidel.

When painting with the identify transform, the roundToDevicePixels function in GraphicsContextCG
does an early return that simply returns the FloatRect that was passed in. This proved to be a
problem in sub-pixel layout, as we wouldn't adjust the paint rect for text underline, and it could
end up being more than one pixel wide. Adding a roundedIntRect method on FloatRect for the simple
short-circuit case.

No new tests. No change in behavior before switching to sub-pixel layout.

  • platform/graphics/FloatRect.cpp:

(WebCore::roundedIntRect):

  • platform/graphics/FloatRect.h:
  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::roundToDevicePixels):

12:53 Changeset [114547] by lforschler@apple.com
  • 5 edits in branches/safari-534.57-branch/Source

Versioning.

12:48 Changeset [114546] by commit-queue@webkit.org
  • 9 edits in trunk

Clean-up WheelEvent Conversion.
https://bugs.webkit.org/show_bug.cgi?id=84243

Source/WebKit/qt:

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-18
Reviewed by Simon Hausmann.

  • WebCoreSupport/WebEventConversion.cpp:

(WebCore::WebKitPlatformWheelEvent::applyDelta):

Source/WebKit2:

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-18
Reviewed by Simon Hausmann.

  • Shared/qt/WebEventFactoryQt.cpp:

(WebKit::WebEventFactory::createWebWheelEvent):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::wheelEvent):

Tools:

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-18
Reviewed by Simon Hausmann.

Calculate proper wheel-delta from pixel-delta given.

  • DumpRenderTree/qt/EventSenderQt.cpp:

(EventSender::EventSender):
(EventSender::mouseScrollBy):
(EventSender::continuousMouseScrollBy):

LayoutTests:

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-18
Reviewed by Simon Hausmann.

  • platform/qt/fast/events/continuous-platform-wheelevent-in-scrolling-div-expected.txt:
12:32 Changeset [114545] by keishi@webkit.org
  • 10 edits in trunk

[chromium] Turn on ENABLE_DATALIST for chromium
https://bugs.webkit.org/show_bug.cgi?id=84118

Reviewed by Kent Tamura.

Source/WebCore:

  • html/HTMLDataListElement.cpp: Touched to avoid build issues. No code change.
  • html/HTMLDataListElement.h: Ditto.
  • html/HTMLInputElement.cpp: Ditto.
  • html/HTMLInputElement.h: Ditto.

Source/WebKit/chromium:

  • features.gypi: Turn on ENABLE_DATALIST.
  • src/WebInputElement.cpp: Touched to avoid build issues. No code change.

LayoutTests:

  • platform/chromium/fast/forms/label/labelable-elements-expected.txt: Update expectated result.
12:25 SelectiveTestEWS edited by beszedes@inf.u-szeged.hu
(diff)
12:19 Changeset [114544] by commit-queue@webkit.org
  • 1 edit
    1 delete in trunk/Source/WebCore

[Qt] WheelEventQt.cpp should be deleted.
https://bugs.webkit.org/show_bug.cgi?id=84237

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-18
Reviewed by Simon Hausmann.

  • platform/qt/WheelEventQt.cpp: Removed.
12:14 SelectiveTestBuildBot edited by beszedes@inf.u-szeged.hu
(diff)
11:58 Changeset [114543] by commit-queue@webkit.org
  • 22 edits
    4 adds in trunk/LayoutTests

[EFL][DRT] Update baselines after font-face support was fixed
https://bugs.webkit.org/show_bug.cgi?id=84234

Unreviewed, EFL gardening.

Fixing baselines for css/font-face* tests and tests affected
by working @font-face. A bunch of table/* rebaselines will
follow in a separate batch.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-18

  • platform/efl/fast/css/beforeSelectorOnCodeElement-expected.png:
  • platform/efl/fast/css/font-face-default-font-expected.png:
  • platform/efl/fast/css/font-face-in-media-rule-expected.png:
  • platform/efl/fast/css/font-face-multiple-faces-expected.png:
  • platform/efl/fast/css/font-face-multiple-faces-expected.txt:
  • platform/efl/fast/css/font-face-opentype-expected.png:
  • platform/efl/fast/css/font-face-opentype-expected.txt:
  • platform/efl/fast/css/font-face-remote-expected.png:
  • platform/efl/fast/css/font-face-remote-expected.txt:
  • platform/efl/fast/css/font-face-synthetic-bold-italic-expected.png: Added.
  • platform/efl/fast/css/font-face-synthetic-bold-italic-expected.txt: Added.
  • platform/efl/fast/css/font-face-unicode-range-expected.png:
  • platform/efl/fast/css/font-face-unicode-range-expected.txt:
  • platform/efl/fast/css/font-face-weight-matching-expected.png: Added.
  • platform/efl/fast/css/font-face-weight-matching-expected.txt: Added.
  • platform/efl/fast/css/font-face-woff-expected.png:
  • platform/efl/fast/css/font-face-woff-expected.txt:
  • platform/efl/fast/css/rtl-ordering-expected.txt:
  • platform/efl/fast/css/text-security-expected.txt:
  • platform/efl/fast/events/updateLayoutForHitTest-expected.png:
  • platform/efl/fast/writing-mode/broken-ideograph-small-caps-expected.png:
  • platform/efl/fast/writing-mode/broken-ideograph-small-caps-expected.txt:
  • platform/efl/fast/writing-mode/broken-ideographic-font-expected.png:
  • platform/efl/fast/writing-mode/broken-ideographic-font-expected.txt:
  • platform/efl/test_expectations.txt:
11:54 Changeset [114542] by eae@chromium.org
  • 1109 edits
    236 copies
    123 deletes in branches/subpixellayout

Merge trunk changes up until 114521 into subpixel branch.

11:46 Changeset [114541] by eae@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed. Adding FIXME comment to FractionalLayoutUnit explaining the lack of size_t operators.

  • platform/FractionalLayoutUnit.h:

(FractionalLayoutUnit):

11:40 Changeset [114540] by dgrogan@chromium.org
  • 2 edits
    5 adds in trunk/LayoutTests

IDB: Pending setVersion call in worker prevents document from opening the db, even after worker termination
https://bugs.webkit.org/show_bug.cgi?id=83952

These two tests fail in DRT most proximately because DRT provides
different instances of IDBFactoryBackend to a document and worker:
https://bugs.webkit.org/show_bug.cgi?id=82776.

One fails in chromium because of a logic error tracked by
http://crbug.com/123418. The plan is to run them both as browser tests
when the logic is fixed, but just one in the meantime.

Also added SKIP for storage/indexeddb/dont-commit-on-blocked.html
since it also can't pass in DRT and just turns the flakiness dashboard
all red.

Reviewed by Ojan Vafai.

  • platform/chromium/test_expectations.txt:
  • storage/indexeddb/pending-version-change-stuck-expected.txt: Added.
  • storage/indexeddb/pending-version-change-stuck-works-with-terminate-expected.txt: Added.
  • storage/indexeddb/pending-version-change-stuck-works-with-terminate.html: Added.
  • storage/indexeddb/pending-version-change-stuck.html: Added.
  • storage/indexeddb/resources/pending-version-change-stuck.js: Added.

(test.request.onsuccess.request.onblocked):
(test.request.onsuccess):
(test):

11:36 Changeset [114539] by benjamin@webkit.org
  • 7 edits in trunk/Source

Remove m_subclassData from JSArray, move the attribute to subclass as needed
https://bugs.webkit.org/show_bug.cgi?id=84249

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-18
Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

JSArray's m_subclassData is only used by WebCore's RuntimeArray. This patch moves
the attribute to RuntimeArray to avoid allocating memory for the pointer in the common
case.

This gives ~1% improvement in JSArray creation microbenchmark thanks to fewer allocations
of CopiedSpace.

  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateJSArray):

  • runtime/JSArray.cpp:

(JSC::JSArray::JSArray):

  • runtime/JSArray.h:

Source/WebCore:

  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::RuntimeArray):
(JSC::RuntimeArray::finishCreation):

  • bridge/runtime_array.h:

(JSC::RuntimeArray::getLength):
(JSC::RuntimeArray::getConcreteArray):
(RuntimeArray):

11:34 Changeset [114538] by antti@apple.com
  • 7 edits in trunk

matchMedia() MediaQueryList not updating
https://bugs.webkit.org/show_bug.cgi?id=75903

Patch by Luiz Agostini <luiz.agostini@palm.com> on 2012-04-18
Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/media/media-query-list-08.html

Viewport related MediaQueryList listeners were not triggered and the value
of matches were not updated if the document's style selector were not
affected by viewport changes.

The new method evaluateMediaQueries() is now called by FrameView instead of
styleSelectorChanged() if the style selector is not affected by viewport changes.

  • dom/Document.cpp:

(WebCore::Document::evaluateMediaQueries):
(WebCore):
(WebCore::Document::styleSelectorChanged):

  • dom/Document.h:

(Document):

  • page/FrameView.cpp:

(WebCore::FrameView::layout):

LayoutTests:

Testing MediaQueryLists listeners related to viewport changes.

  • fast/media/media-query-list-08-expected.txt: Added.
  • fast/media/media-query-list-08.html: Added.

Skipping the new test in Mac and Qt due to an issue in its DumpRenderTree.

  • platform/qt/Skipped:
  • platform/mac/Skipped:
11:31 Changeset [114537] by eae@chromium.org
  • 4 edits in trunk/Source/WebCore

Use explicit casts for size_t to unsigned conversion
https://bugs.webkit.org/show_bug.cgi?id=83602

Reviewed by Eric Seidel.

No new tests, no change in functinality.

Not all platforms have implicit casts from size_t to unsigned and we
can't add size_t versions of the operators to FractionalLayoutUnit for
all platforms as it would conflict with the unsigned versions of same.

Change support methods to take unsigned instead of size_t and use
explicit casts when multiplying or dividing a FractionalLayoutUnit with
a size_t and the other way around.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustForColumns):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::initialPackingOffset):
(WebCore::packingSpaceBetweenChildren):
(WebCore::initialLinePackingOffset):
(WebCore::linePackingSpaceBetweenChildren):
(WebCore::RenderFlexibleBox::packFlexLines):

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::layout):

11:31 Changeset [114536] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update.

  • platform/gtk/test_expectations.txt: Skip some failing tests and

mark 3 more frame flattening tests flaky.

11:14 Changeset [114535] by pfeldman@chromium.org
  • 5 edits in trunk

Source/WebCore: Web Inspector: [Chromium] Module's require injects scripts before the debug id is set to the context.
https://bugs.webkit.org/show_bug.cgi?id=84166

Re-applying r114497.

  • bindings/v8/V8IsolatedContext.cpp:

(WebCore::setInjectedScriptContextDebugId):
(WebCore):
(WebCore::V8IsolatedContext::V8IsolatedContext):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::evaluateInIsolatedWorld):

  • bindings/v8/V8Proxy.h:

(V8Proxy):

LayoutTests: Unreviewed, rolling out r114506.
http://trac.webkit.org/changeset/114506
https://bugs.webkit.org/show_bug.cgi?id=84254

Seems to be making gtk's DumpRenderTree crash occasionally
(Requested by tomz on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-18

  • platform/gtk/test_expectations.txt:
11:06 Changeset [114534] by achicu@adobe.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, trying to fix QT build.

It was using a FilterEffectRenderer::prepare that changed to allocateBackingStoreIfNeeded in 114529.

  • platform/graphics/texmap/TextureMapperImageBuffer.cpp:

(WebCore::BitmapTextureImageBuffer::applyFilters):

11:03 Changeset [114533] by enne@google.com
  • 7 edits
    5 adds in trunk/LayoutTests

[chromium] Unreviewed, rebaseline compositing tests after r114283.
https://bugs.webkit.org/show_bug.cgi?id=84083

  • platform/chromium-linux/compositing/overflow/overflow-positioning-expected.png:
  • platform/chromium-mac-leopard/compositing/overflow/overflow-positioning-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/overflow/overflow-positioning-expected.png:
  • platform/chromium-mac/compositing/overflow/overflow-positioning-expected.png:
  • platform/chromium-win/compositing/backing/no-backing-for-clip-expected.txt: Added.
  • platform/chromium-win/compositing/backing/no-backing-for-clip-overlap-expected.txt: Added.
  • platform/chromium-win/compositing/backing/no-backing-for-perspective-expected.txt: Added.
  • platform/chromium-win/compositing/geometry/preserve-3d-switching-expected.txt:
  • platform/chromium-win/compositing/overflow/overflow-positioning-expected.png:
  • platform/chromium/test_expectations.txt:
11:01 Changeset [114532] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: extract script navigator overlay logic into the scripts navigator controller.
https://bugs.webkit.org/show_bug.cgi?id=84244

Reviewed by Vsevolod Vlasov.

Overlay logic is well separable from the scripts panel and does not belong there.
Extracting it into a separate class.

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigatorController.prototype.wasShown):
(WebInspector.ScriptsNavigatorController.prototype._createNavigatorControlButton):
(WebInspector.ScriptsNavigatorController.prototype._escDownWhileNavigatorOverlayOpen):
(WebInspector.ScriptsNavigatorController.prototype._toggleNavigator):
(WebInspector.ScriptsNavigatorController.prototype._hidePinnedNavigator):
(WebInspector.ScriptsNavigatorController.prototype.set _pinNavigator):
(WebInspector.ScriptsNavigatorController.prototype.set showNavigatorOverlay):
(WebInspector.ScriptsNavigatorController.prototype.hideNavigatorOverlay):
(WebInspector.ScriptsNavigatorController.prototype._navigatorOverlayWasShown):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.wasShown):
(WebInspector.ScriptsPanel.prototype._editorClosed):
(WebInspector.ScriptsPanel.prototype._editorSelected):
(WebInspector.ScriptsPanel.prototype._scriptSelected):

11:01 Changeset [114531] by tomz@codeaurora.org
  • 8 edits in trunk

Unreviewed, rolling out r114506.
http://trac.webkit.org/changeset/114506
https://bugs.webkit.org/show_bug.cgi?id=84254

Seems to be making gtk's DumpRenderTree crash occasionally
(Requested by tomz on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-18

Source/WebKit/gtk:

  • webkit/webkitwebsettings.cpp:

(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):

  • webkit/webkitwebsettingsprivate.h:
  • webkit/webkitwebview.cpp:

(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):

Tools:

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

LayoutTests:

  • platform/gtk/test_expectations.txt:
10:44 Changeset [114530] by dimich@chromium.org
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r114497.
http://trac.webkit.org/changeset/114497
https://bugs.webkit.org/show_bug.cgi?id=84253

Broke compile on Win, including stdio did not help (Requested
by dimich on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-18

  • bindings/v8/V8IsolatedContext.cpp:

(WebCore::V8IsolatedContext::V8IsolatedContext):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::evaluateInIsolatedWorld):
(WebCore::V8Proxy::setInjectedScriptContextDebugId):
(WebCore):

  • bindings/v8/V8Proxy.h:

(V8Proxy):

10:37 Changeset [114529] by achicu@adobe.com
  • 4 edits in trunk/Source/WebCore

[CSS Filters] Drop-shadow and blur can avoid using full source image
https://bugs.webkit.org/show_bug.cgi?id=81263

Reviewed by Dean Jackson.

Instead of using the full bounding box of the RenderLayer we now compute the exact rectangle that is needed to
compute filter inside the dirty rectangle on screen. That's easy to calculate by reversing the filter outsets.
Even if the element is completely offscreen, but its shadow is in the viewport, we can still compute the source
rectangle that needs to be drawn in order to update the shadow correctly.

No new tests, this change doesn't have visible results and the functionality should
already be covered by previous filter tests.

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::FilterEffectRenderer):
(WebCore::FilterEffectRenderer::build): Save the outsets of the filters, so that we can use them in computeSourceImageRectForDirtyRect.
(WebCore::FilterEffectRenderer::updateBackingStoreRect): Only allocate a new source image if the size of the source rectangle changed.
(WebCore::FilterEffectRenderer::allocateBackingStoreIfNeeded): There's no need to call clearIntermediateResults() in this function. We do that after
the filter is computed.
(WebCore::FilterEffectRenderer::computeSourceImageRectForDirtyRect):
(WebCore):
(WebCore::FilterEffectRendererHelper::prepareFilterEffect):
(WebCore::FilterEffectRendererHelper::beginFilterEffect):

  • rendering/FilterEffectRenderer.h:

(FilterEffectRendererHelper):
(WebCore::FilterEffectRendererHelper::repaintRect):
(FilterEffectRenderer):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerContents):

10:23 Changeset [114528] by xan@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk

[GTK] Enable back double buffering on WebKitWebView to fix flickering
https://bugs.webkit.org/show_bug.cgi?id=84149

Patch by Carlos Garnacho <carlos@lanedo.com> on 2012-04-17
Reviewed by Martin Robinson.

Despite having WebKitWebView its own backing buffer, calling
gtk_widget_set_double_buffered(...,FALSE) may still pose side
effects, such as ensuring that all drawing operations are
flushed to the X server before rendering a non-double buffered
widget, which may translate into flickering of the parent
GdkWindow before the WebKitWebView itself is rendered.

Enabling back double buffering solves this as all contents are
first composited together before getting to the front buffer,
but effectively acts as 3rd buffer. This is sort of unavoidable
unless GTK+ gains a "let me take ownership of the backing buffer
for this widget", which currently lacks.

  • webkit/webkitwebview.cpp:

(webkit_web_view_init): Remove call to gtk_widget_set_double_buffered(..., FALSE)

10:23 Changeset [114527] by xan@webkit.org
  • 4 edits
    2 adds in releases/WebKitGTK/webkit-1.8

[soup] Crash while loading http://www.jusco.cn
https://bugs.webkit.org/show_bug.cgi?id=68238

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-04-09
Reviewed by Philippe Normand.

.:

  • configure.ac: Bumped the libsoup dependency to 2.37.90.

Source/WebCore:

Test: http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers.html

When running synchronous XMLHttpRequests, push a new inner thread default
context, so that other sources from timers and network activity do not run.
This will make synchronous requests truly synchronous with the rest of
WebCore.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCoreSynchronousLoader): Clean up the method definitions a bit by writing them inline.
(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): Push a new thread default
context to prevent other sources from running.
(WebCore::WebCoreSynchronousLoader::~WebCoreSynchronousLoader): Pop the inner thread default context.
(WebCore::closeCallback): If the client is synchronous call didFinishLoading now.
(WebCore::readCallback): Only call didFinishLoading if the client isn't synchronous.
(WebCore::ResourceHandle::defaultSession): Activate use-thread-context so that the soup session
respects the inner thread context.

LayoutTests:

  • http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers.html: Added.
10:22 Changeset [114526] by xan@webkit.org
  • 3 edits
    3 adds in releases/WebKitGTK/webkit-1.8

[GTK] Toggle buttons do not size appropriately in some themes
https://bugs.webkit.org/show_bug.cgi?id=82833

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-04-09
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Test: platform/gtk/fast/forms/large-toggle-elements.html

Instead of drawing a toggle button across the entire rectangle of
the WebCore control, draw a default-sized one cenetered in the rectangle.

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore::paintToggle): Draw default-sized toggles.

LayoutTests:

Add a test for this issue.

  • platform/gtk/fast/forms/large-toggle-elements-expected.png: Added.
  • platform/gtk/fast/forms/large-toggle-elements-expected.txt: Added.
  • platform/gtk/fast/forms/large-toggle-elements.html: Added.
10:22 Changeset [114525] by xan@webkit.org
  • 5 edits
    5 adds in releases/WebKitGTK/webkit-1.8

[GTK] Scrolling some iframes that are partially out of the viewport leads to repaint errors
https://bugs.webkit.org/show_bug.cgi?id=83309

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-04-05
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Test: platform/gtk/fast/frames/scrolling-iframe-out-of-viewport.html

The X11 backing store was not properly trimming the scroll region when it
was only a portion of the screen. This was hidden by subsequent repaints.

  • platform/gtk/GtkWidgetBackingStoreX11.cpp:

(WebCore::WidgetBackingStore::scroll): Fix the calculation of the scrolling region.

Source/WebKit/gtk:

Instead of only updating scrollRect - preservedRegion, update
scrollRect - (preservedRegion - offscreenPreservedRegion). This ensures that
when part of the scroll rect is moved onscreen from offscreen that part is
queued for a redraw.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::scroll): Properly calculate the area to repaint.

LayoutTests:

Added a pixel test for this issue.

  • platform/gtk/fast/frames/resources/scrolling-iframe-out-of-viewport-interior.html: Added.
  • platform/gtk/fast/frames/scrolling-iframe-out-of-viewport-expected.png: Added.
  • platform/gtk/fast/frames/scrolling-iframe-out-of-viewport-expected.txt: Added.
  • platform/gtk/fast/frames/scrolling-iframe-out-of-viewport.html: Added.
10:22 WebKitGTK/1.8.x edited by xan@webkit.org
(diff)
10:17 WebKitGTK/1.8.x edited by xan@webkit.org
(diff)
10:17 Changeset [114524] by xan@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/JavaScriptCore

SIGILL in JavaScriptCore on a Geode processor
https://bugs.webkit.org/show_bug.cgi?id=82496

Reviewed by Gavin Barraclough.

Don't attempt to use the DFG when SSE2 is not available.

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::canCompileOpcodes):

10:16 Changeset [114523] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL][DRT] @font-face support fails on EFL
https://bugs.webkit.org/show_bug.cgi?id=83264

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-18
Reviewed by Dimitri Glazkov.

STORE_FONT_CUSTOM_PLATFORM_DATA was not defined for EFL.
Fixing that by removing a long standing FIXME with the intention
to turn the whitelist for this switch into a blacklist.

  • loader/cache/CachedFont.cpp:
10:16 WebKitGTK/1.8.x edited by xan@webkit.org
(diff)
10:15 Changeset [114522] by xan@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8

[GTK] Respect NOCONFIGURE option in autogen.sh
https://bugs.webkit.org/show_bug.cgi?id=82447

Reviewed by Philippe Normand.

Make autogen.sh follow the new build-api for GNOME, see
http://people.gnome.org/~walters/docs/build-api.txt

  • autogen.sh: respect the NOCONFIGURE environment flag, per the

new GNOME build-api.

10:07 Changeset [114521] by benjamin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

replaceUsingStringSearch: delay the creation of the replace string until needed
https://bugs.webkit.org/show_bug.cgi?id=83841

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-18
Reviewed by Geoffrey Garen.

We do not need to obtain the replaceValue until we have a match. By moving the intialization
of replaceValue when needed, we save a few instructions when there is no match.

  • runtime/StringPrototype.cpp:

(JSC::replaceUsingRegExpSearch):
(JSC::replaceUsingStringSearch):
(JSC::stringProtoFuncReplace):

10:05 Changeset [114520] by leviw@chromium.org
  • 13 edits in trunk/Source/WebCore

Convert ShadowData and DropShadowFilterOperation to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=84098

Reviewed by Eric Seidel.

Shadows do not flow with the page, so sub-pixel layout doesn't actually offer any benefit that
couldn't have been attained before that conversion. With that in mind, this patch reverts
drop shadow offsets to integers, but also cleans up the code by switching the x/y location pair
to be an IntPoint.

No new tests. No change in behavior.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::valueForFilter):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • css/SVGCSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applySVGProperty):

  • page/animation/AnimationBase.cpp:

(WebCore::blendFunc):
(WebCore::shadowForBlending):

  • platform/animation/AnimationUtilities.h:

(WebCore::blend): New blend function that operates on IntPoints.
(WebCore):

  • platform/chromium/support/WebFilterOperations.cpp:

(WebKit::WebDropShadowFilterOperation):

  • platform/graphics/filters/FilterOperation.cpp:

(WebCore::DropShadowFilterOperation::blend):

  • platform/graphics/filters/FilterOperation.h:

(WebCore::DropShadowFilterOperation::clone):
(WebCore::DropShadowFilterOperation::x):
(WebCore::DropShadowFilterOperation::y):
(WebCore::DropShadowFilterOperation::location): Preserved the comment about lengths.
(WebCore::DropShadowFilterOperation::operator==):
(WebCore::DropShadowFilterOperation::DropShadowFilterOperation):
(DropShadowFilterOperation):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::areaCastingShadowInHole): Reverted to integers since this operates on the IntRect from
a RoundedRect.
(WebCore::RenderBoxModelObject::paintBoxShadow): Reduced the complexity and unnecessary conversion
between LayoutUnits and integers by using all integers after we calculate the pixel-snapped
RoundedRect that we use for painting.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::getShadowExtent):
(WebCore::RenderStyle::getShadowHorizontalExtent):
(WebCore::RenderStyle::getShadowVerticalExtent):

  • rendering/style/ShadowData.cpp:

(WebCore::ShadowData::ShadowData):
(WebCore::ShadowData::operator==):
(WebCore::calculateShadowExtent):
(WebCore::ShadowData::adjustRectForShadow):

  • rendering/style/ShadowData.h:

(WebCore::ShadowData::ShadowData):
(WebCore::ShadowData::x):
(WebCore::ShadowData::y):
(WebCore::ShadowData::location):
(ShadowData):

09:53 Changeset [114519] by haraken@chromium.org
  • 18 edits in trunk/Source/WebCore

[V8] Add an optional Isolate argument to wrap()
https://bugs.webkit.org/show_bug.cgi?id=84202

Reviewed by Nate Chapin.

The final objective is to pass Isolate around in V8 bindings.
This patch adds an optional Isolate argument to wrap().
After rewriting all wrap() callers so that they pass Isolate
to wrap(), I'll make the Isolate argument non-optional.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm: Modified as described above.

(GenerateHeader):

  • bindings/v8/custom/V8DocumentCustom.cpp: Ditto.

(WebCore::toV8):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: Ditto.

(WebCore::toV8):

  • bindings/v8/custom/V8NodeCustom.cpp: Ditto.

(WebCore::toV8Slow):

  • bindings/v8/custom/V8SVGDocumentCustom.cpp: Ditto.

(WebCore::toV8):

  • dom/make_names.pl: Ditto.

(printWrapperFactoryCppFile):

  • bindings/scripts/test/V8/V8Float64Array.h:

Updated run-bindings-tests results.
(V8Float64Array):
(WebCore::V8Float64Array::wrap):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):
(WebCore::V8TestActiveDOMObject::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):
(WebCore::V8TestCustomNamedGetter::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):
(WebCore::V8TestEventConstructor::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):
(WebCore::V8TestEventTarget::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):
(WebCore::V8TestInterface::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):
(WebCore::V8TestMediaQueryListListener::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):
(WebCore::V8TestNamedConstructor::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestNode.h:

(V8TestNode):
(WebCore::V8TestNode::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):
(WebCore::V8TestObj::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):
(WebCore::V8TestSerializedScriptValueInterface::wrap):
(WebCore::toV8):

09:34 Changeset [114518] by achicu@adobe.com
  • 3 edits in trunk/Source/WebCore

[CSS Filters] Do not use clipping rect when calculating the bounds of a layer
https://bugs.webkit.org/show_bug.cgi?id=83960

Reviewed by Simon Fraser.

The local clip rect should not be used when calculating the bounds of a filter area. Otherwise
drop-shadow might not know about the pixels outside the clipping rectangle, even though the actual shadow might
be inside it.

No new tests added in this patch, but this patch fixes two existing tests that fail.
LayoutTests/css3/filters/filter-repaint-shadow-clipped.html
LayoutTests/css3/filters/filter-repaint-shadow-rotated.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::calculateLayerBounds):

  • rendering/RenderLayer.h:
09:33 Changeset [114517] by lforschler@apple.com
  • 1 copy in tags/Safari-534.57.2

New tag.

09:29 Changeset [114516] by mrobinson@webkit.org
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merging r111263

09:29 Changeset [114515] by pilgrim@chromium.org
  • 11 edits
    3 adds in trunk/Source/WebCore

Followup to "Call incrementStatsCounter directly"
https://bugs.webkit.org/show_bug.cgi?id=83109

Reviewed by Kentaro Hara.

Now that incrementStatsCounter has been moved from
PlatformSupport.h to Platform.h, we need to be able to call it directly
from WebCore/bindings/v8/v8Proxy.h (for the INC_STATS macro). That
means we need a new StatsCounter class in WebCore/platform/ and an
implementation in
WebCore/platform/chromium/StatsCounterChromium.cpp. Other ports
are welcome to implement their own stats counters if they
wish. This pattern was based on the
HistogramSupport/HistogramSupportChromium classes.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/v8/V8Proxy.h:
  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:

(WebCore::V8DedicatedWorkerContext::postMessageCallback):
(WebCore::V8DedicatedWorkerContext::webkitPostMessageCallback):

  • bindings/v8/custom/V8NotificationCenterCustom.cpp:

(WebCore::V8NotificationCenter::createHTMLNotificationCallback):
(WebCore::V8NotificationCenter::createNotificationCallback):
(WebCore::V8NotificationCenter::requestPermissionCallback):

  • bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::V8WorkerContext::importScriptsCallback):
(WebCore::V8WorkerContext::setTimeoutCallback):
(WebCore::V8WorkerContext::setIntervalCallback):

  • platform/StatsCounter.cpp: Added.

(WebCore):
(WebCore::StatsCounter::incrementStatsCounter):

  • platform/StatsCounter.h: Added.

(WebCore):
(StatsCounter):

  • platform/chromium/StatsCounterChromium.cpp: Added.

(WebCore):
(WebCore::StatsCounter::incrementStatsCounter):

09:28 Changeset [114514] by eae@chromium.org
  • 4 edits in branches/subpixellayout/Source/WebCore

Replace uses of size_t with unsigned in rendering code on branch.

09:25 Changeset [114513] by apavlov@chromium.org
  • 5 edits in trunk/Source

[Chromium] REGRESSION: Popup shrinks because of autocomplete
https://bugs.webkit.org/show_bug.cgi?id=84139
http://code.google.com/p/chromium/issues/detail?id=123432

Source/WebCore:

Do not update the window rect on the wrong client but instead return the popup widget's
new screen coordinates from the refresh() method.

Reviewed by Kent Tamura.

  • platform/chromium/PopupContainer.cpp:

(WebCore::PopupContainer::refresh):

  • platform/chromium/PopupContainer.h:

(PopupContainer):

Source/WebKit/chromium:

Do not use the PopupContainer's frameRect() to update the popup client's window rect,
since PopupContainer is always positioned at (0, 0) inside the client's window rect,
and the latter one is positioned relative to the screen origin.

Reviewed by Kent Tamura.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::refreshAutofillPopup):

09:20 Changeset [114512] by mrobinson@webkit.org
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merging r110487

09:18 Changeset [114511] by mhahnenberg@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

GC activity timer should be tied to allocation, not collection
https://bugs.webkit.org/show_bug.cgi?id=83919

Reviewed by Geoffrey Garen.

  • API/JSContextRef.cpp: Used the new didAbandonObjectGraph callback to indicate that now that we've

released a global object, we're abandoning a potentially large number of objects that JSC might want
to collect.

  • heap/CopiedSpace.cpp:

(JSC::CopiedSpace::tryAllocateSlowCase): Added the call to timer's willAllocate function to indicate
that we've hit a slow path and are allocating now, so schedule the timer.

  • heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::collectAllGarbage): Removed the call to discardAllCompiledCode because it was causing us to
throw away too much code during our benchmarks (especially vp8, which is very large and thus has large
amounts of compiled code).
(JSC::Heap::collect): Added the new call to didCollect at the conclusion of a collection so that we
can cancel the timer if we no longer need to run a collection. Also added a check at the beginning of a
collection to see if we should throw away our compiled code. Currently this is set to happen about once
every minute.

  • heap/Heap.h: Added field to keep track of the last time we threw away our compiled code.
  • heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::allocateSlowCase): Added call to willAllocate on the allocation slow path, just like
in CopiedSpace.

  • runtime/GCActivityCallback.cpp: Added default stubs for non-CF platforms.

(JSC::DefaultGCActivityCallback::willAllocate):
(JSC):
(JSC::DefaultGCActivityCallback::didCollect):
(JSC::DefaultGCActivityCallback::didAbandonObjectGraph):

  • runtime/GCActivityCallback.h: Added new functions to make JSC's GC timer less arcane. This includes replacing

the operator () with willAllocate() and adding an explicit didCollect() to cancel the timer after a collection
occurs rather than relying on the way the timer is invoked to cancel itself. Also added a callback for
when somebody else (e.g. WebCore or the JSC API) to notify JSC that they have just abandoned an entire graph of
objects and that JSC might want to clean them up.
(JSC::GCActivityCallback::~GCActivityCallback):
(JSC::GCActivityCallback::willAllocate):
(JSC::GCActivityCallback::didCollect):
(JSC::GCActivityCallback::didAbandonObjectGraph):
(JSC::GCActivityCallback::synchronize):
(DefaultGCActivityCallback):

  • runtime/GCActivityCallbackCF.cpp: Re-wired all the run loop stuff to implement the aforementioned functions.

We added a flag to check whether the timer was active because the call to CFRunLoopTimerSetNextFireDate actually
turned out to be quite expensive (although Instruments couldn't tell us this).
(DefaultGCActivityCallbackPlatformData):
(JSC):
(JSC::DefaultGCActivityCallbackPlatformData::timerDidFire):
(JSC::DefaultGCActivityCallback::commonConstructor):
(JSC::scheduleTimer):
(JSC::cancelTimer):
(JSC::DefaultGCActivityCallback::willAllocate):
(JSC::DefaultGCActivityCallback::didCollect):
(JSC::DefaultGCActivityCallback::didAbandonObjectGraph):

09:18 Changeset [114510] by mrobinson@webkit.org
  • 5 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merging r110307

09:17 Changeset [114509] by simon.fraser@apple.com
  • 3 edits
    2 adds in trunk

ASSERT when a layer with a foreground layer is in 'paint into ancestor' mode
https://bugs.webkit.org/show_bug.cgi?id=84221

Source/WebCore:

Reviewed by Dean Jackson.

When a RenderLayerBacking doesn't require its own backing store, and is
in "paintIntoCompositingAncestor" mode, we would assert when trying to
paint its m_foregroundLayer if it had one (because of a negative z-index child).

The fix is to set the 'drawsContent' state on the m_foregroundLayer
as well as m_graphicsLayer.

Test: compositing/backing/no-backing-foreground-layer.html

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateDrawsContent):

LayoutTests:

Reviewed by Dean Jackson.

New testcase.

  • compositing/backing/no-backing-foreground-layer-expected.txt: Added.
  • compositing/backing/no-backing-foreground-layer.html: Added.
09:14 Changeset [114508] by commit-queue@webkit.org
  • 4 edits in trunk

[CMake] Use jsc target instead of ONLY_BUILD_JAVASCRIPTCORE
https://bugs.webkit.org/show_bug.cgi?id=84229

CMake caches ONLY_BUILD_JAVASCRIPTCORE=1 and will reuse the setting for
subsequent builds, stopping WebCore from being built ever again.

Instead of trying to emulate a build target using command line options,
just build the existing jsc target directly.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-18
Reviewed by Rob Buis.

.:

  • CMakeLists.txt:

Tools:

  • Scripts/build-jsc:
08:45 Changeset [114507] by kareng@chromium.org
  • 1 edit in branches/chromium/1025/Source/WebCore/platform/graphics/skia/NativeImageSkia.cpp

Merge 114487 - Skia OOM error when upscaling small subsets of images by large quantities
https://bugs.webkit.org/show_bug.cgi?id=84225

Patch by Rachel Blum <groby@chromium.org> on 2012-04-17
Reviewed by David Levin.

Tested with manual tests.

  • platform/graphics/skia/NativeImageSkia.cpp:

(WebCore::NativeImageSkia::shouldCacheResampling):

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10035027

08:44 Changeset [114506] by commit-queue@webkit.org
  • 8 edits in trunk

[GTK] r114021 triggered media flakyness
https://bugs.webkit.org/show_bug.cgi?id=83874

Patch by Simon Pena <spena@igalia.com> on 2012-04-18
Reviewed by Philippe Normand.

Source/WebKit/gtk:

When the MediaPlaybackRequiresUserGesture setting was added, no gtk
API was implemented to access it.

This adds a property to gtk WebKit WebSettings, and connects it to
WebKit WebView, thus allowing clients to programmatically modify it.

  • webkit/webkitwebsettings.cpp:

(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):

  • webkit/webkitwebsettingsprivate.h:
  • webkit/webkitwebview.cpp:

(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):

Tools:

Now that there is gtk API to update the
MediaPlaybackRequiresUserGesture property, set it to false from the
DumpRenderTree tool when resetting defaults to consistent values.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

LayoutTests:

media/video-load-require-user-gesture.html and
media/video-play-require-user-gesture.html where enabling
MediaPlaybackRequiresUserGesture when run, so tests running
concurrently would fail -they would pass when run independently.

Since new API is added to ensure DumpRenderTree is able to reset
that setting, having media/video-load-require-user-gesture.html and
media/video-play-require-user-gesture.html no longer causes
flakiness.

  • platform/gtk/test_expectations.txt: Unskip

media/video-load-require-user-gesture.html and
media/video-play-require-user-gesture.html

08:09 Changeset [114505] by vsevik@chromium.org
  • 1 edit in branches/chromium/1084/Source/WebCore/inspector/front-end/TextPrompt.js

Merge 114382 - Web Inspector: Suggest box appears after the command was executed in console sometimes.
https://bugs.webkit.org/show_bug.cgi?id=84148

Reviewed by Pavel Feldman.

TextPrompt.complete() requests completions asynchronously, this change adds a flag
that informs TextPrompt._completionsReady() whether completions should still be shown.

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.clearAutoComplete):
(WebInspector.TextPrompt.prototype.complete):
(WebInspector.TextPrompt.prototype._completionsReady):

TBR=vsevik@chromium.org
BUG=123826
Review URL: https://chromiumcodereview.appspot.com/10116026

07:59 Changeset [114504] by yurys@chromium.org
  • 18 edits in trunk

Web Inspector: DataGrid should use explicit root node
https://bugs.webkit.org/show_bug.cgi?id=84240

DataGrid now has an explicit root node. All children are added/removed
to that node.

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/ApplicationCacheItemsView.js:

(WebInspector.ApplicationCacheItemsView.prototype._createDataGrid):
(WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid):

  • inspector/front-end/CSSSelectorProfileView.js:

(WebInspector.CSSSelectorProfileView):
(WebInspector.CSSSelectorProfileView.prototype.rebuildGridItems):
(WebInspector.CSSSelectorProfileView.prototype.refreshData):

  • inspector/front-end/CookieItemsView.js:

(WebInspector.SimpleCookiesTable):
(WebInspector.SimpleCookiesTable.prototype.setCookies):

  • inspector/front-end/CookiesTable.js:

(WebInspector.CookiesTable):
(WebInspector.CookiesTable.prototype._rebuildTable):

  • inspector/front-end/DOMStorageItemsView.js:

(WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGrid):
(WebInspector.DataGrid.createSortableDataGrid.sortDataGrid):
(WebInspector.DataGrid.createSortableDataGrid):
(WebInspector.DataGrid.prototype.setRootNode):
(WebInspector.DataGrid.prototype.rootNode):
(WebInspector.DataGrid.prototype.autoSizeColumns):
(WebInspector.DataGrid.prototype._enumerateChildren):
(WebInspector.DataGrid.prototype._keyDown):
(WebInspector.DataGrid.prototype._contextMenuInDataTable):
(WebInspector.DataGridNode.prototype.get revealed):
(WebInspector.DataGridNode.prototype.get depth):
(WebInspector.DataGridNode.prototype.appendChild):
(WebInspector.DataGridNode.prototype.insertChild):
(WebInspector.DataGridNode.prototype.removeChild):
(WebInspector.DataGridNode.prototype.removeChildren):
(WebInspector.DataGridNode.prototype.collapse):
(WebInspector.DataGridNode.prototype.expand):
(WebInspector.DataGridNode.prototype.reveal):
(WebInspector.DataGridNode.prototype.revealAndSelect):
(WebInspector.DataGridNode.prototype.traverseNextNode):
(WebInspector.DataGridNode.prototype.traversePreviousNode):

  • inspector/front-end/HeapSnapshotDataGrids.js:

(WebInspector.HeapSnapshotSortableDataGrid):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.dispose):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.changeNameFilter):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.updateVisibleNodes):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype.sortingChanged):
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype.reset):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived.addNodeIfNonZeroDiff):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype._defaultPopulateCount.25.setDataSource):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype.sortingChanged):

  • inspector/front-end/HeapSnapshotGridNodes.js:

(WebInspector.HeapSnapshotGenericObjectNode):

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotView.prototype.performSearch):
(WebInspector.HeapSnapshotView.prototype.refreshVisibleData):

  • inspector/front-end/IndexedDBViews.js:

(WebInspector.IDBDataView.prototype._createDataGrid):
(WebInspector.IDBDataView.prototype._updateData.callback):
(WebInspector.IDBDataView.prototype._updateData):
(WebInspector.IDBDataView.prototype.clear):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._createTable):
(WebInspector.NetworkLogView.prototype.refresh):
(WebInspector.NetworkLogView.prototype._reset):

  • inspector/front-end/ProfileDataGridTree.js:

(WebInspector.ProfileDataGridNode.prototype.insertChild):
(WebInspector.ProfileDataGridNode.prototype.removeChild):
(WebInspector.ProfileDataGridNode.prototype.removeChildren):

  • inspector/front-end/ProfileView.js:

(WebInspector.CPUProfileView.prototype.refresh):

  • inspector/front-end/treeoutline.js:

LayoutTests:

  • inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest):

  • inspector/storage-panel-dom-storage.html:
07:55 Changeset [114503] by schenney@chromium.org
  • 2 edits
    2 deletes in trunk/LayoutTests

Layout Test svg/transforms/transform-origin-css-property.xhtml is failing
https://bugs.webkit.org/show_bug.cgi?id=84203

Unreviewed test expectation fix.

The svg/transforms/transform-origin-css-property.xhtml test has a
ref-test for it, so there should not be any image expectations. If the
test if failing, we need to look at why the ref test is not valid, or
why we differ.

The expectations file update here is just some cleanup for
https://bugs.webkit.org/show_bug.cgi?id=84230.

  • platform/chromium-mac/svg/transforms/transform-origin-css-property-expected.png: Removed.
  • platform/chromium-win/svg/transforms/transform-origin-css-property-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
06:55 Changeset [114502] by commit-queue@webkit.org
  • 15 edits in trunk/Source/WebCore

Add PassThis=* to support the callbacks which requires to pass "this" value.
https://bugs.webkit.org/show_bug.cgi?id=84232

Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-04-18
Reviewed by Kentaro Hara.

Adding PassThisToCallback=XXX to attributes will be useful for the callbacks which requires to pass "this".
This will help to identify the type(XXX) of "this" value in codegenerator.

Tests: bindings/scripts/test/TestCallback.idl

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateCallbackImplementation): Modified codegenerator to support [PassThisToCallback]

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateCallbackImplementation): Ditto.

  • bindings/scripts/IDLAttributes.txt: Added PassThisToCallback=*
  • bindings/scripts/test/CPP/WebDOMTestCallback.cpp: Modofied results from run-bindings-tests.

(WebDOMTestCallback::callbackWithBoolean):
(WebDOMTestCallback::callbackRequiresThisToPass):

  • bindings/scripts/test/CPP/WebDOMTestCallback.h: Ditto.

(WebDOMTestCallback):

  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp: Ditto.

(webkit_dom_test_callback_callback_with_boolean):
(webkit_dom_test_callback_callback_requires_this_to_pass):

  • bindings/scripts/test/GObject/WebKitDOMTestCallback.h: Ditto.
  • bindings/scripts/test/JS/JSTestCallback.cpp: Ditto.

(WebCore::JSTestCallback::callbackWithBoolean):
(WebCore):
(WebCore::JSTestCallback::callbackRequiresThisToPass):

  • bindings/scripts/test/JS/JSTestCallback.h: Ditto.

(JSTestCallback):

  • bindings/scripts/test/ObjC/DOMTestCallback.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestCallback.mm: Ditto.

(-[DOMTestCallback callbackWithBoolean:]):
(-[DOMTestCallback callbackRequiresThisToPass:thisClassParam:]):

  • bindings/scripts/test/TestCallback.idl: Added test to verify generated code.
  • bindings/scripts/test/V8/V8TestCallback.cpp: Ditto.

(WebCore::V8TestCallback::callbackWithBoolean):
(WebCore):
(WebCore::V8TestCallback::callbackRequiresThisToPass):

  • bindings/scripts/test/V8/V8TestCallback.h: Ditto.

(V8TestCallback):

06:52 Changeset [114501] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Not reviewed: fixing Chromium win compilation.

  • bindings/v8/V8IsolatedContext.cpp:
06:02 Changeset [114500] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove unnecessary variable reassignment in CSSParser::parseImageSet().
https://bugs.webkit.org/show_bug.cgi?id=84204

Reviewed by Kentaro Hara.

Code calls next and then current instead of reusing the result of next.

No new tests / no functionality changed.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseImageSet):

05:26 Changeset [114499] by commit-queue@webkit.org
  • 10 edits in trunk

Web Inspector: Disabling Inspector causes build failure on Windows
https://bugs.webkit.org/show_bug.cgi?id=83557

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-04-18
Reviewed by Pavel Feldman.

The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
This change brings all such API calls under the guard.

Source/WebKit/win:

  • WebCoreSupport/WebInspectorClient.cpp:
  • WebInspector.cpp:
  • WebNodeHighlight.cpp:

(WebNodeHighlight::WebNodeHighlight):
(WebNodeHighlight::update):

  • WebNodeHighlight.h:

(WebNodeHighlight):

  • WebView.cpp:

(WebView::WebView):
(WebView::close):
(WebView::initWithFrame):
(WebView::inspector):

  • WebView.h:

(WebView):

Tools:

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::showWebInspector):
(WTR::LayoutTestController::closeWebInspector):
(WTR::LayoutTestController::evaluateInWebInspector):
(WTR::LayoutTestController::setJavaScriptProfilingEnabled):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::invoke):

03:56 Changeset [114498] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[BlackBerry] HTTP GET header has a "Cookie" when refreshing a page after cookies have been cleared.
https://bugs.webkit.org/show_bug.cgi?id=84223

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-18
Reviewed by George Staikos.

.:

  • ManualTests/blackberry/clear-cookie-refresh-result.php: Added.
  • ManualTests/blackberry/clear-cookie-refresh.php: Added.

Source/WebCore:

Webkit uses the old ResourceRequest when refreshing. Its cookies' header isn't removed after clicking
"clear cookies" button. We need to set cookies for this request again.

We must click "clear button" to test, so have to write a manual test case.

Test: ManualTests/blackberry/clear-cookie-refresh.php

  • platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::ResourceRequest::initializePlatformRequest):

03:09 Changeset [114497] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: [Chromium] Module's require injects scripts before the debug id is set to the context.
https://bugs.webkit.org/show_bug.cgi?id=84166

Reviewed by Yury Semikhatsky.

V8IsolatedContext was getting debug id assigned post-construction. At the same time, it was compiling all
its module scripts within the constructor. As a result, scripts ended up in the main world's list.

  • bindings/v8/V8IsolatedContext.cpp:

(WebCore::setInjectedScriptContextDebugId):
(WebCore):
(WebCore::V8IsolatedContext::V8IsolatedContext):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::evaluateInIsolatedWorld):

  • bindings/v8/V8Proxy.h:

(V8Proxy):

03:04 Changeset [114496] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Minibrowser asserts on startup at QtViewportInteractionEngine::ensureContentWithinViewportBoundary()
https://bugs.webkit.org/show_bug.cgi?id=84172

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-18
Reviewed by Simon Hausmann.

After the viewport computing refactor, ensureContentWithinViewportBoundary() can be called
with resumed page. QtViewportInteractionEngine::ensureContentWithinViewportBoundary()
functionality does not necessarily require the page to be suspended. It's the caller's context
that determines whether the page needs to be suspended, so it's the caller's responsibility
to enforce the ASSERT().
Remove the invalid ASSERT on m_suspendCount at QtViewportInteractionEngine::ensureContentWithinViewportBoundary()

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):

02:29 SelectiveTestEWS edited by ossy@webkit.org
(diff)
01:53 Changeset [114495] by toyoshim@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update expectations
https://bugs.webkit.org/show_bug.cgi?id=84230

  • platform/chromium/test_expectations.txt:
01:49 Changeset [114494] by pfeldman@chromium.org
  • 5 edits
    2 adds in trunk

Web Inspector: document.open removes the documentElement, but does not clear the elements panel.
https://bugs.webkit.org/show_bug.cgi?id=84179

Reviewed by Yury Semikhatsky.

Source/WebCore:

Perform total update upon modifications of the document node.

Test: inspector/elements/delete-from-document.html

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::didRemoveDOMNode):

  • inspector/front-end/ElementsTreeOutline.js:

LayoutTests:

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.dumpElementsTree.print):
(initialize_ElementTest.InspectorTest.dumpElementsTree):

  • inspector/elements/delete-from-document-expected.txt: Added.
  • inspector/elements/delete-from-document.html: Added.
01:40 Changeset [114493] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

Source/WebCore: [BlackBerry] Tab awareness for HTML5 concurrent audio
https://bugs.webkit.org/show_bug.cgi?id=82930
Support for concurrent HTML5 audio improvements being made in
the platform library, which need to be aware of tabs and tab
visibility. PR96004.

Patch by Max Feil <mfeil@rim.com> on 2012-04-18
Reviewed by George Staikos.

Test: media/audio-concurrent-supported.html

  • platform/blackberry/PageClientBlackBerry.h:
  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::showErrorDialog):
(WebCore::MediaPlayerPrivate::isTabVisible):
(WebCore):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:

(MediaPlayerPrivate):

Source/WebKit/blackberry: [BlackBerry] Tab awareness for HTML5 concurrent audio
https://bugs.webkit.org/show_bug.cgi?id=82930
Support for concurrent HTML5 audio improvements being made in
the platform library, which need to be aware of tabs and tab
visibility. PR96004.

Patch by Max Feil <mfeil@rim.com> on 2012-04-18
Reviewed by George Staikos.

  • Api/WebPageClient.h:
  • Api/WebPage_p.h:

(BlackBerry::WebKit::WebPagePrivate::isVisible):

LayoutTests: [BlackBerry] Tab awareness for HTML5 concurrent audio
https://bugs.webkit.org/show_bug.cgi?id=82930
Layout test for concurrent HTML5 audio. This is a simple test
to confirm that multiple audio elements can play at the same time.

Patch by Max Feil <mfeil@rim.com> on 2012-04-18
Reviewed by George Staikos.

  • media/audio-concurrent-supported-expected.txt: Added.
  • media/audio-concurrent-supported.html: Added.
01:17 Changeset [114492] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skipping test that uses disabled feature SHADOW_DOM

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-04-18

  • platform/qt/Skipped: fast/dom/shadow/adopt-node-with-shadow-root.html
01:05 Changeset [114491] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

[CG] ImageBuffer: check getPremultipliedImageData() error return
https://bugs.webkit.org/show_bug.cgi?id=84022

Reviewed by Eric Seidel.

ImageBuffer::getPremultipliedImageData() can fail. toDataURL() should check for a
failure return, and return "data:," if so.

No new tests. Covered by existing toDataURL tests, in particular:

canvas/philip/tests/toDataURL.jpeg.alpha.html

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::toDataURL): Rename |arr| variable to premultipliedData and
return "data:," if premultipliedData is empty. Clean up whitespace and a comment.

00:37 Changeset [114490] by mario@webkit.org
  • 2 edits in trunk/Tools

[GTK] atk/textChangedNotifications API test fails
https://bugs.webkit.org/show_bug.cgi?id=84010

Unreviewed, unskipping test after bug being fixed by r114311.

  • Scripts/run-gtk-tests:

(TestRunner): Unskip now passing test.

00:35 Changeset [114489] by mikelawther@chromium.org
  • 1 edit in branches/chromium/1084/Source/WebCore/platform/graphics/skia/NativeImageSkia.cpp

Merge 114487 - Skia OOM error when upscaling small subsets of images by large quantities
https://bugs.webkit.org/show_bug.cgi?id=84225

Patch by Rachel Blum <groby@chromium.org> on 2012-04-17
Reviewed by David Levin.

Tested with manual tests.

  • platform/graphics/skia/NativeImageSkia.cpp:

(WebCore::NativeImageSkia::shouldCacheResampling):

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10083037

04/17/12:

23:39 Changeset [114488] by commit-queue@webkit.org
  • 5 edits in trunk

[BlackBerry] Viewport metatag doesn't disable double-tap zoom
https://bugs.webkit.org/show_bug.cgi?id=84199

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-04-17
Reviewed by George Staikos.

Source/WebKit/blackberry:

PR: 148279
When we set "user-scalable=no" in viewport meta-tag and change any
other WebSettings, the WebPage can turn to be scalable.
This is a regression of the change master_32/SHA:fa0f8ee9. In that
change, we used setUserScalable(webSettings->isUserScalable())
in WebPagePrivate::didChangeSettings which was incorrect for non-DRT
case, as webSettings->isUserScalable() would always return true by
default.
Create a new API WebPage::setUserScalable which will be used in
DumpRenderTree.cpp.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::setUserScalable):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):

  • Api/WebPage.h:

Tools:

Revert a part of the change master_32/SHA:fa0f8ee9 and use
WebPage::setUserScalable instead.

  • DumpRenderTree/blackberry/DumpRenderTree.cpp:

(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):

23:36 Changeset [114487] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Skia OOM error when upscaling small subsets of images by large quantities
https://bugs.webkit.org/show_bug.cgi?id=84225

Patch by Rachel Blum <groby@chromium.org> on 2012-04-17
Reviewed by David Levin.

Tested with manual tests.

  • platform/graphics/skia/NativeImageSkia.cpp:

(WebCore::NativeImageSkia::shouldCacheResampling):

22:54 Changeset [114486] by toyoshim@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, rebaseline of svg/W3C-SVG-1.1/masking-intro-01-f.svg .

  • platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
22:47 Changeset [114485] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

WebKitTestRunner needs textInputController
https://bugs.webkit.org/show_bug.cgi?id=42337

Update wk2 Skipped list to skip new failing test.

  • platform/wk2/Skipped:
22:34 Changeset [114484] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

[WK2] http/tests/navigation/anchor-frames-same-origin.html fails
https://bugs.webkit.org/show_bug.cgi?id=84227

Update wk2 Skipped list to skip new failing test.

  • platform/wk2/Skipped:
22:27 Changeset [114483] by toyoshim@chromium.org
  • 1 edit
    1 move
    2 adds in trunk/LayoutTests

Unreviewed, rebaseline of svg/as-background-image/svg-as-background-6.html .

  • platform/chromium-linux/svg/as-background-image/svg-as-background-6-expected.png: Added.
  • platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-6-expected.png: Added.
  • svg/as-background-image/svg-as-background-6-expected.txt: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-as-background-6-expected.txt.
22:18 Changeset [114482] by sfalken@apple.com
  • 3 edits in branches/safari-534.57-branch/WebKitLibraries

Merge r97323.

21:52 Changeset [114481] by morrita@google.com
  • 3 edits
    2 adds in trunk

ShadowRoot shouldn't be adopted by any Document.
https://bugs.webkit.org/show_bug.cgi?id=84127

Reviewed by Dimitri Glazkov.

Source/WebCore:

ShadowRoot cannot cannot be removed from its host, which means
ShadowRoot cannot be adopted by any Document directly because the
adoptNode() tries to remove it from its parent but it doesn't make
sense for ShadowRoot.

This change adds a guard to check such a case.

Test: fast/dom/shadow/adopt-node-with-shadow-root.html

  • dom/Document.cpp:

(WebCore::Document::adoptNode):

LayoutTests:

  • fast/dom/shadow/adopt-node-with-shadow-root-expected.txt: Added.
  • fast/dom/shadow/adopt-node-with-shadow-root.html: Added.
21:40 Changeset [114480] by jer.noble@apple.com
  • 1 edit
    1 delete in trunk/LayoutTests

REGRESSION (r114406-r114417): media/video-playing-and-pause.html failing on Lion Release (WebKit2 Tests)
https://bugs.webkit.org/show_bug.cgi?id=84226

Remove expected failing results ſtor media/video-playing-and-pause.html.

  • platform/mac-wk2/media/video-playing-and-pause-expected.txt: Removed.
21:04 Changeset [114479] by toyoshim@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, revert temporal expectation changeset (114248)
https://bugs.webkit.org/show_bug.cgi?id=84024

  • platform/chromium/test_expectations.txt:
20:54 Changeset [114478] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

DFG should not attempt to get rare case counts for op_mod on ARM
https://bugs.webkit.org/show_bug.cgi?id=84218

Reviewed by Geoff Garen.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::makeSafe):

  • dfg/DFGCommon.h:

(JSC::DFG::isX86):
(DFG):

20:42 Changeset [114477] by commit-queue@webkit.org
  • 2 edits in trunk/Source

BumpPointerAllocator assumes page size is less than MINIMUM_BUMP_POOL_SIZE
https://bugs.webkit.org/show_bug.cgi?id=80912

Patch by Myles Maxfield <mmaxfield@google.com> on 2012-04-17
Reviewed by Hajime Morita.

  • wtf/BumpPointerAllocator.h:

(WTF::BumpPointerPool::create):

20:34 Changeset [114476] by ap@apple.com
  • 9 edits
    1 move
    2 adds in trunk/Source/WebKit2

[Mac] USPS Shipping label prints without barcode
https://bugs.webkit.org/show_bug.cgi?id=84099
<rdar://problem/11133877>

Reviewed by Sam Weinig.

Use PDFDocuemnt instead of CGPDFDocument when printing PDFs, because PDFKit knows
how to draw PDF buttons, and CG does not.

  • Shared/mac/PDFKitImports.h: Added.
  • Shared/mac/PDFKitImports.mm: Added.
  • UIProcess/API/mac/WKPrintingView.mm:

Moved code for dealing with dynamically loaded PDFKit from WKPrintingView, as we
now also need it elsewhere.

  • WebKit2.xcodeproj/project.pbxproj: Added
  • WebProcess/Plugins/PDF/BuiltInPDFView.cpp: Rebamed to .mm.
  • WebProcess/Plugins/PDF/BuiltInPDFView.h: Changed m_pdfDocument to PDFDocument.
  • WebProcess/Plugins/PDF/BuiltInPDFView.mm: Copied from Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.cpp.

(WebKit::BuiltInPDFView::pdfDocumentDidLoad):
(WebKit::BuiltInPDFView::calculateSizes):
(WebKit::BuiltInPDFView::paintContent):
Changed m_pdfDocument to PDFDocument, and updated for the changes. We still use
CGPDF when drawing to screen though, because that doesn't affect USPS.

  • WebProcess/Plugins/Plugin.h: (WebKit::Plugin::pdfDocumentForPrinting): Updated

the type, and changed ifsed from CG to MAC, as we're now fully dependent on Cocoa.

  • WebProcess/Plugins/PluginView.h: (WebKit::PluginView::pdfDocumentForPrinting):

Ditto.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::pdfDocumentForPrintingFrame):
(WebKit::WebPage::beginPrinting):
(WebKit::WebPage::computePagesForPrinting):
(WebKit::WebPage::drawRectToPDF):
(WebKit::WebPage::drawPagesToPDF):

  • WebProcess/WebPage/WebPage.h:

Moved PDF document printing code to WebPageMac.mm, as it's now Objective C.

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::computePagesForPrintingPDFDocument):
(WebKit::roundCGFloat):
(WebKit::drawPDFPage): While moving, also fixed a logic error in calculating the box
(it used to intersect with an empty box).
(WebKit::WebPage::drawRectToPDFFromPDFDocument):
(WebKit::WebPage::drawPagesToPDFFromPDFDocument):

19:57 Changeset [114475] by commit-queue@webkit.org
  • 12 edits in trunk/Source/WebCore

[chromium] Ensure RateLimiter waits for Swapbuffers completion
https://bugs.webkit.org/show_bug.cgi?id=83649

Patch by John Bauman <jbauman@chromium.org> on 2012-04-17
Reviewed by James Robinson.

We were waiting only on the canvas context, which with the new GPU
scheduling was causing the RateLimiter not to ratelimit enough. We
need to insert no-op commands in the compositor context, so that we'll
wait for the canvas context and SwapBuffers as well.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::doNoOp):
(WebCore):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

  • platform/graphics/chromium/RateLimiter.cpp:

(WebCore::RateLimiter::create):
(WebCore::RateLimiter::RateLimiter):
(WebCore::RateLimiter::rateLimitContext):

  • platform/graphics/chromium/RateLimiter.h:

(RateLimiterClient):
(WebCore):
(RateLimiter):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::startRateLimiter):
(WebCore::CCLayerTreeHost::rateLimit):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCProxy.h:

(CCProxy):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::forceNoOpCommand):
(WebCore):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(CCSingleThreadProxy):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::forceNoOpCommand):
(WebCore):
(WebCore::CCThreadProxy::forceNoOpCommandOnImplThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

19:49 Changeset [114474] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

CSSValuePool: Made identifier value cache a fixed-size array.
<http://webkit.org/b/84219>

Reviewed by Antti Koivisto.

Change the identifier CSSPrimitiveValue cache in CSSValuePool from a HashMap to a
fixed-size array of RefPtr<CSSPrimitiveValue>s.

We have ~700 values total, so this is quite space efficient now that the CSSValuePool
is globally shared. More importantly it avoids a hash lookup every time we need an
identifier value.

  • css/CSSValuePool.h:
  • css/CSSValuePool.cpp:

(WebCore::CSSValuePool::createIdentifierValue):

19:48 April 2012 Meeting edited by rniwa@webkit.org
For logistical reasons, test importing session needs to take place from … (diff)
18:13 April 2012 Meeting edited by skyul@company100.net
(diff)
18:10 April 2012 Meeting edited by skyul@company100.net
(diff)
18:08 April 2012 Meeting edited by skyul@company100.net
(diff)
17:52 Changeset [114473] by piman@chromium.org
  • 7 edits in trunk/Source

[Chromium] Clean up texture ids on the impl side when losing the context
https://bugs.webkit.org/show_bug.cgi?id=84122

Reviewed by James Robinson.

Tested by CCLayerTreeHostImplTest.dontUseOldResourcesAfterLostContext.

  • platform/graphics/chromium/cc/CCTextureLayerImpl.cpp:

(WebCore::CCTextureLayerImpl::didLoseContext):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::didLoseContext):
(WebCore):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:

(CCTiledLayerImpl):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::didLoseContext):
(WebCore):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:

(CCVideoLayerImpl):

17:33 Changeset [114472] by fpizlo@apple.com
  • 12 edits in branches/dfgopt/Source/JavaScriptCore

DFG should have out-of-line slow paths
https://bugs.webkit.org/show_bug.cgi?id=83992

Reviewed by Oliver Hunt.

Introduces the notion of slow path code generation closures in the DFG.
These are defined in DFGSlowPathGenerator.h, though they are fairly
extensible so DFGSpeculativeJIT64.cpp and DFGSpeculativeJIT32_64.cpp
define a couple special-purpose ones. A slow path generation closure
(DFG::SlowPathGenerator) is executed after the main speculative path is
generated. This makes them great for scheduling slow path code out of
the way of the hot paths.

This patch also converts most - but not all - of the DFG to use slow
path generators instead of inline slow paths.

The result is a sub-1% improvement on SunSpider and V8, and a miniscule
regression on Kraken.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::TrustedImmPtr::TrustedImmPtr):
(TrustedImmPtr):
(JSC::AbstractMacroAssembler::TrustedImm32::TrustedImm32):
(TrustedImm32):

  • bytecode/StructureStubInfo.h:
  • dfg/DFGCommon.h:
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):

  • dfg/DFGJITCompiler.h:

(DFG):
(JSC::DFG::PropertyAccessRecord::PropertyAccessRecord):
(PropertyAccessRecord):
(JITCompiler):

  • dfg/DFGSilentRegisterSavePlan.h: Added.

(DFG):
(SilentRegisterSavePlan):
(JSC::DFG::SilentRegisterSavePlan::SilentRegisterSavePlan):
(JSC::DFG::SilentRegisterSavePlan::spillAction):
(JSC::DFG::SilentRegisterSavePlan::fillAction):
(JSC::DFG::SilentRegisterSavePlan::nodeIndex):
(JSC::DFG::SilentRegisterSavePlan::gpr):
(JSC::DFG::SilentRegisterSavePlan::fpr):

  • dfg/DFGSlowPathGenerator.h: Added.

(DFG):
(SlowPathGenerator):
(JSC::DFG::SlowPathGenerator::SlowPathGenerator):
(JSC::DFG::SlowPathGenerator::~SlowPathGenerator):
(JSC::DFG::SlowPathGenerator::generate):
(JSC::DFG::SlowPathGenerator::label):
(JSC::DFG::SlowPathGenerator::call):
(JumpingSlowPathGenerator):
(JSC::DFG::JumpingSlowPathGenerator::JumpingSlowPathGenerator):
(JSC::DFG::JumpingSlowPathGenerator::linkFrom):
(JSC::DFG::JumpingSlowPathGenerator::jumpTo):
(CallSlowPathGenerator):
(JSC::DFG::CallSlowPathGenerator::CallSlowPathGenerator):
(JSC::DFG::CallSlowPathGenerator::call):
(JSC::DFG::CallSlowPathGenerator::setUp):
(JSC::DFG::CallSlowPathGenerator::recordCall):
(JSC::DFG::CallSlowPathGenerator::tearDown):
(CallResultAndNoArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndNoArgumentsSlowPathGenerator::CallResultAndNoArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndNoArgumentsSlowPathGenerator::generateInternal):
(CallResultAndOneArgumentSlowPathGenerator):
(JSC::DFG::CallResultAndOneArgumentSlowPathGenerator::CallResultAndOneArgumentSlowPathGenerator):
(JSC::DFG::CallResultAndOneArgumentSlowPathGenerator::generateInternal):
(CallResultAndTwoArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndTwoArgumentsSlowPathGenerator::CallResultAndTwoArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndTwoArgumentsSlowPathGenerator::generateInternal):
(CallResultAndThreeArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndThreeArgumentsSlowPathGenerator::CallResultAndThreeArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndThreeArgumentsSlowPathGenerator::generateInternal):
(CallResultAndFourArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndFourArgumentsSlowPathGenerator::CallResultAndFourArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndFourArgumentsSlowPathGenerator::generateInternal):
(CallResultAndFiveArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndFiveArgumentsSlowPathGenerator::CallResultAndFiveArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndFiveArgumentsSlowPathGenerator::generateInternal):
(JSC::DFG::slowPathCall):
(AssigningSlowPathGenerator):
(JSC::DFG::AssigningSlowPathGenerator::AssigningSlowPathGenerator):
(JSC::DFG::AssigningSlowPathGenerator::generateInternal):
(JSC::DFG::slowPathMove):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(DFG):
(JSC::DFG::SpeculativeJIT::~SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::addSlowPathGenerator):
(JSC::DFG::SpeculativeJIT::runSlowPathGenerators):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):

  • dfg/DFGSpeculativeJIT.h:

(DFG):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::silentSavePlanForGPR):
(JSC::DFG::SpeculativeJIT::silentSavePlanForFPR):
(JSC::DFG::SpeculativeJIT::silentSpill):
(JSC::DFG::SpeculativeJIT::silentFill):
(JSC::DFG::SpeculativeJIT::silentSpillAllRegistersImpl):
(JSC::DFG::SpeculativeJIT::silentSpillAllRegisters):
(JSC::DFG::SpeculativeJIT::pickCanTrample):
(JSC::DFG::SpeculativeJIT::silentFillAllRegisters):
(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(ValueToNumberSlowPathGenerator):
(JSC::DFG::ValueToNumberSlowPathGenerator::ValueToNumberSlowPathGenerator):
(JSC::DFG::ValueToNumberSlowPathGenerator::generateInternal):
(DFG):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(CompareAndBoxBooleanSlowPathGenerator):
(JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::CompareAndBoxBooleanSlowPathGenerator):
(JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::generateInternal):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(ValueToNumberSlowPathGenerator):
(JSC::DFG::ValueToNumberSlowPathGenerator::ValueToNumberSlowPathGenerator):
(JSC::DFG::ValueToNumberSlowPathGenerator::generateInternal):
(DFG):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(CompareAndBoxBooleanSlowPathGenerator):
(JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::CompareAndBoxBooleanSlowPathGenerator):
(JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::generateInternal):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::compile):

17:31 Changeset [114471] by eae@chromium.org
  • 3 edits in trunk/Source/WebCore

Change RenderThemeChromiumSkia paint methods to use pixel snapping
https://bugs.webkit.org/show_bug.cgi?id=84175

Reviewed by Eric Seidel.

No new tests, no change in functionality.

Change RenderThemeChromiumSkia to use subpixel types and pixel snap
values just before painting.

  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::convertToPaintingRect):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):

  • rendering/RenderThemeChromiumSkia.h:

2012-04-17 Levi Weintraub <leviw@chromium.org>

Clean up outstanding LayoutUnit misuse in WebCore
https://bugs.webkit.org/show_bug.cgi?id=84209

Reviewed by Eric Seidel.

Small changes to a handful of files to prepare trunk for FractionalLayoutUnits.
For more details, see https://trac.webkit.org/wiki/LayoutUnit

No new tests. No change in behavior.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): minimumValueForLength preserves
sub-pixel precision, so we should avoid unnecessarily using integers.

  • platform/graphics/FractionalLayoutPoint.h:

(WebCore::FractionalLayoutPoint::FractionalLayoutPoint): Adding an explicit constructor from
FractionalLayoutSizes. This mirrors a method in IntPoint.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBorder): The rects that change come from roundedRects,
which are already pixel-snapped.

  • rendering/RenderBoxModelObject.h: Removing a comment that is no longer applicable.
  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth): Since we layout tables using integers, we
need to explicitly calculate the width to be integral as well to avoid pushing the next element
over by a pixel that we won't later paint with our own box decorations.

  • rendering/RenderText.h:

(RenderText): Correcting an unfortunate mismatch between in the return value of linesBoundingBox
between the header and implementation.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::getRoundedBorderFor): We were incorrectly not using the snapped border
rect to pass to calcRadiiFor (which takes an IntRect). Correcting this.

17:30 Changeset [114470] by leviw@chromium.org
  • 8 edits in trunk/Source/WebCore

2012-04-17 Levi Weintraub <leviw@chromium.org>

Clean up outstanding LayoutUnit misuse in WebCore
https://bugs.webkit.org/show_bug.cgi?id=84209

Reviewed by Eric Seidel.

Small changes to a handful of files to prepare trunk for FractionalLayoutUnits.
For more details, see https://trac.webkit.org/wiki/LayoutUnit

No new tests. No change in behavior.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): minimumValueForLength preserves
sub-pixel precision, so we should avoid unnecessarily using integers.

  • platform/graphics/FractionalLayoutPoint.h:

(WebCore::FractionalLayoutPoint::FractionalLayoutPoint): Adding an explicit constructor from
FractionalLayoutSizes. This mirrors a method in IntPoint.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBorder): The rects that change come from roundedRects,
which are already pixel-snapped.

  • rendering/RenderBoxModelObject.h: Removing a comment that is no longer applicable.
  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth): Since we layout tables using integers, we
need to explicitly calculate the width to be integral as well to avoid pushing the next element
over by a pixel that we won't later paint with our own box decorations.

  • rendering/RenderText.h:

(RenderText): Correcting an unfortunate mismatch between in the return value of linesBoundingBox
between the header and implementation.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::getRoundedBorderFor): We were incorrectly not using the snapped border
rect to pass to calcRadiiFor (which takes an IntRect). Correcting this.

17:29 Changeset [114469] by dpranke@chromium.org
  • 2 edits in trunk/Tools

build-webkit: make ninja work with chromium linux
https://bugs.webkit.org/show_bug.cgi?id=84213

Reviewed by Eric Seidel.

Fix typos so that build-webkit will use ninja to
build chromium if a build.ninja file exists and is up-to-date.

  • Scripts/webkitdirs.pm:

(determineIsChromiumNinja):

17:24 Changeset [114468] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

Ensure CSSParser member variables are initialized.
https://bugs.webkit.org/show_bug.cgi?id=84205

Reviewed by Andreas Kling.

No new tests / code cleanup only.

  • css/CSSParser.cpp:

(WebCore::CSSParser::CSSParser):

17:19 Changeset [114467] by achicu@adobe.com
  • 2 edits in trunk/Source/WebCore

Regression(114172): Use after free in CustomFilterProgram::notifyClients
https://bugs.webkit.org/show_bug.cgi?id=84000

Reviewed by Dean Jackson.

The function returned early and the shaders didn't have a chance to be saved. Moving
those two lines before the return false just to make sure that FilterEffectRenderer never adds
itself as a client for a shader without keeping track of that.

No new tests. The problem reproduces with existing tests.
css3/filters/custom/custom-filter-property-computed-style.html
css3/filters/custom/effect-custom-combined-missing.html

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::build):

16:44 Changeset [114466] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Re-enable W3C canPlayType() tests on Chromium
https://bugs.webkit.org/show_bug.cgi?id=84164

They use the new expectations override from changeset 112937 and pass after http://crrev.com/132463.

Unreviewed, layout test expectations update.

Patch by David Dorwin <ddorwin@chromium.org> on 2012-04-17

  • platform/chromium/test_expectations.txt:
16:26 Changeset [114465] by jer.noble@apple.com
  • 1 edit
    1 delete in trunk/LayoutTests

REGRESSION (r114206): fast/harness/use-page-cache.html tests failing on Lion Debug (WebKit2 Tests)
https://bugs.webkit.org/show_bug.cgi?id=84206

Remove expected failing test results for fast/harness/use-page-cache.html.

  • platform/mac-wk2/fast/harness/use-page-cache-expected.txt: Removed.
16:26 Changeset [114464] by commit-queue@webkit.org
  • 3 edits
    5 adds in trunk

IndexedDB chooses wrong record on PREV_NO_DUPLICATE index cursor
https://bugs.webkit.org/show_bug.cgi?id=60746

Patch by Alec Flett <alecflett@chromium.org> on 2012-04-17
Reviewed by Ojan Vafai.

Source/WebCore:

When iterating backwards with PREV_NO_DUPLICATE, keep walking past
the 'prev' key until it changes, then walk forward one time. This
covers the object store and index cases.

Test: storage/indexeddb/mozilla/index-prev-no-duplicate.html

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore):

LayoutTests:

Test for PREV_NO_DUPLICATE.

  • storage/indexeddb/cursor-prev-no-duplicate.html: Added.
  • storage/indexeddb/cursor-prev-no-duplicate.txt: Added.
  • storage/indexeddb/mozilla/index-prev-no-duplicate-expected.txt: Added.
  • storage/indexeddb/mozilla/index-prev-no-duplicate.html: Added.
  • storage/indexeddb/resources/cursor-prev-no-duplicate.js: Added.

(prepareDatabase.openreq.onsuccess.verreq.onsuccess):
(prepareDatabase.openreq.onsuccess):
(prepareDatabase):
(populateStore):
(runAllTests):
(waitFor):
(complete.fireCallback):
(complete):
(testFarRangeCursor):
(makeOpenKeyCursor):
(runTest.trans.oncomplete):
(runTest.testFunction):
(runTest):

16:20 Changeset [114463] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, unskip some WebSocket worker tests that should not be skipped.

  • platform/chromium/test_expectations.txt:
16:17 Changeset [114462] by reed@google.com
  • 2 edits in trunk/LayoutTests

need to rebaseline after skia 3695 lands
https://bugs.webkit.org/show_bug.cgi?id=84184

Unreviewed. expectations change only.

  • platform/chromium/test_expectations.txt:
16:12 April 2012 Meeting edited by ojan@chromium.org
(diff)
16:10 Changeset [114461] by yi.4.shen@nokia.com
  • 3 edits
    2 adds in trunk

Caret is not rendered properly inside an input element with text-indent
https://bugs.webkit.org/show_bug.cgi?id=82688

Reviewed by Ryosuke Niwa.

For an empty input element, there is no RenderText. Instead, RenderBlock::localCaretRect provides
the caret position for rendering the caret in the empty input element. To get correct caret rect,
textIndentOffset() should be used to adjust the caret's position.

Source/WebCore:

Test: editing/style/text-indent.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::localCaretRect):

LayoutTests:

  • editing/style/text-indent-expected.txt: Added.
  • editing/style/text-indent.html: Added.
16:08 Changeset [114460] by ojan@chromium.org
  • 2 edits in trunk/Tools

Add caching to the flakiness dashboard json files
https://bugs.webkit.org/show_bug.cgi?id=84198

Reviewed by Dirk Pranke.

  • TestResultServer/handlers/testfilehandler.py:

(GetFile._get_file_list):
(GetFile._get_file_content):
(GetFile._get_file_content_from_key):
(GetFile._get_test_list_json):
(GetFile._serve_json):
Add a Last-Modified header and handle If-Modified-Since headers.
(GetFile.get):

16:03 Changeset [114459] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Attempt to fix Windows build.

16:02 Changeset [114458] by rafaelw@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[MutationObservers] enable V8RecursionScope debug ASSERT()
https://bugs.webkit.org/show_bug.cgi?id=84094

Reviewed by Ojan Vafai.

This patch enables the ASSERT() which enforces usage of
V8RecursionScope.

  • src/WebKit.cpp:

(WebKit::assertV8RecursionScope):

16:01 Changeset [114457] by fpizlo@apple.com
  • 7 edits in trunk/Source

It should be possible to create an inheritorID for the global this object without crashing
https://bugs.webkit.org/show_bug.cgi?id=84200
<rdar://problem/11251082>

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • runtime/JSGlobalThis.cpp:

(JSC::JSGlobalThis::setUnwrappedObject):

  • runtime/JSGlobalThis.h:

(JSC::JSGlobalThis::unwrappedObject):
(JSGlobalThis):

  • runtime/JSObject.cpp:

(JSC::JSObject::createInheritorID):

  • runtime/JSObject.h:

(JSObject):
(JSC::JSObject::resetInheritorID):

Source/WebCore:

No new tests, because the circumstances necessary to make this happen are rather hairy.

  • bindings/js/JSDOMWindowShell.h:

(WebCore::JSDOMWindowShell::window):
(WebCore::JSDOMWindowShell::setWindow):

15:57 Changeset [114456] by lforschler@apple.com
  • 5 edits
    4 copies in branches/safari-534.57-branch

Merge 109480.

15:56 Changeset [114455] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

Make CSSParser::parseValue()'s handling of CSSPropertyCursor more obviously correct.
https://bugs.webkit.org/show_bug.cgi?id=83544

Reviewed by Kentaro Hara.

No new tests / code cleanup only.

The code as it stands appears to be correct, but static analysis was concerned that value could become null.
This patch adds a null check and ASSERT_NOT_REACHED() to make the code more obviously correct.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

15:54 Changeset [114454] by fpizlo@apple.com
  • 1 copy in branches/dfgopt

New branch for JSC DFG work

15:51 Changeset [114453] by lforschler@apple.com
  • 4 edits in branches/safari-534.57-branch/Source/WebCore

Fix for 11238384.

15:48 Changeset [114452] by danakj@chromium.org
  • 4 edits in trunk/Source

[chromium] Fix gyp for WebFilterOperation.h and WebFilterOperations.h
https://bugs.webkit.org/show_bug.cgi?id=84182

Reviewed by James Robinson.

Source/Platform:

  • Platform.gypi:

Source/WebKit/chromium:

  • WebKit.gyp:
15:43 Changeset [114451] by andersca@apple.com
  • 13 edits in trunk

Source/WebKit2: Need a client callback for when the user tires to interact with an already unresponsive page
https://bugs.webkit.org/show_bug.cgi?id=84201
<rdar://problem/11140862>

Reviewed by Andreas Kling.

Add a interactionOccurredWhileProcessUnresponsive callback that's called when the unresponsiveness timer
fires while it's already unresponsive.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/ResponsivenessTimer.cpp:

(WebKit):
(WebKit::ResponsivenessTimer::timerFired):
(WebKit::ResponsivenessTimer::start):

  • UIProcess/ResponsivenessTimer.h:

(Client):

  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::processDidBecomeUnresponsive):
(WebKit):
(WebKit::WebLoaderClient::interactionOccurredWhileProcessUnresponsive):

  • UIProcess/WebLoaderClient.h:

(WebLoaderClient):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::interactionOccurredWhileProcessUnresponsive):
(WebKit):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::interactionOccurredWhileUnresponsive):
(WebKit):

  • UIProcess/WebProcessProxy.h:

(WebProcessProxy):

Tools: Need a client callback for when the user tries to interact with an already unresponsive page
https://bugs.webkit.org/show_bug.cgi?id=84201
<rdar://problem/11140862>

Reviewed by Andreas Kling.

Add new client functions.

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

15:42 Changeset [114450] by commit-queue@webkit.org
  • 12 edits
    2 adds in trunk/Source

[Chromium] Add TextureUploader which allows us to use persistent GC3D state for texture uploads.
https://bugs.webkit.org/show_bug.cgi?id=83972

Patch by David Reveman <reveman@chromium.org> on 2012-04-17
Reviewed by James Robinson.

Source/WebCore:

Add TextureUploader class that allows us to add persistent GC3D state to the upload machinery.

  • WebCore.gypi:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:

(WebCore::LayerRendererChromium::textureUploader):
(LayerRendererChromium):

  • platform/graphics/chromium/TextureUploader.cpp: Added.

(WebCore):
(WebCore::AcceleratedTextureUploader::AcceleratedTextureUploader):
(WebCore::AcceleratedTextureUploader::~AcceleratedTextureUploader):
(WebCore::AcceleratedTextureUploader::uploadTexture):

  • platform/graphics/chromium/TextureUploader.h: Added.

(WebCore):
(TextureUploader):
(WebCore::TextureUploader::~TextureUploader):
(AcceleratedTextureUploader):
(WebCore::AcceleratedTextureUploader::create):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::doCommit):

  • platform/graphics/chromium/cc/CCTextureUpdater.cpp:

(WebCore::CCTextureUpdater::update):

  • platform/graphics/chromium/cc/CCTextureUpdater.h:

(WebCore):
(CCTextureUpdater):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):

Source/WebKit/chromium:

  • tests/CCTiledLayerTestCommon.h:

(FakeTextureUploader):
(WebKitTests::FakeTextureUploader::uploadTexture):
(WebKitTests):

  • tests/Canvas2DLayerChromiumTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):

15:37 Changeset [114449] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Mark test failing IMAGE: svg/transforms/transform-origin-css-property.xhtml

Unreviewed.

  • platform/chromium/test_expectations.txt:
15:32 Changeset [114448] by lforschler@apple.com
  • 2 edits in branches/safari-534.57-branch/Source/JavaScriptCore

Merged r107647.

15:29 Changeset [114447] by lforschler@apple.com
  • 2 edits in branches/safari-534.57-branch/Source/JavaScriptCore

Merged r112966.

15:23 Changeset [114446] by lforschler@apple.com
  • 2 edits in branches/safari-534.57-branch/Source/WebCore

Merged r111977.

15:17 Changeset [114445] by lforschler@apple.com
  • 4 edits in branches/safari-534.57-branch/WebKitLibraries

Merged r113649.

15:16 Changeset [114444] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

Clean up CSSParser::parseFillRepeat().
https://bugs.webkit.org/show_bug.cgi?id=83547

Reviewed by Kentaro Hara.

Removed multiple unnecessary calls to m_valueList->current().
Restructured logic for parsing second value to make it clearer.

No new tests / code cleanup only.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFillRepeat):

15:15 Changeset [114443] by lforschler@apple.com
  • 2 edits in branches/safari-534.57-branch/Source/WebCore

Merged r113528.

15:09 Changeset [114442] by dpranke@chromium.org
  • 2 edits in trunk/Tools

nrwt: handle stopping layout test helper after a ctrl-c cleanly on the chromium port
https://bugs.webkit.org/show_bug.cgi?id=84190

Reviewed by Ojan Vafai.

LayoutTestHelper would exit when the user typed ctrl-c, but we
would attempt to write to it to shut it down, generating an
IOError.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.stop_helper):

15:04 Changeset [114441] by dpranke@chromium.org
  • 3 edits in trunk/Tools

rename --experimental-fully-parallel
https://bugs.webkit.org/show_bug.cgi?id=84188

Reviewed by Ojan Vafai.

I thought this was done long ago; rename
--experimental-fully-parallel to just --fully-parallel and
remove the --no- switch that AFAIK no one uses.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._run_tests):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

15:03 Changeset [114440] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[V8] Pass Isolate to toV8Slow()
https://bugs.webkit.org/show_bug.cgi?id=84173

Reviewed by Nate Chapin.

The final objective is to pass Isolate around in V8 bindings.
This patch passes the Isolate to toV8Slow().

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::toV8Slow):

15:03 Changeset [114439] by lforschler@apple.com
  • 2 edits in branches/safari-534.57-branch/Source/WebCore

Merged r111108.

14:59 Changeset [114438] by lforschler@apple.com
  • 7 edits in branches/safari-534.57-branch

Merge 112023.

14:51 Changeset [114437] by jchaffraix@webkit.org
  • 16 edits in trunk/Source/WebCore

Fix the ACCELERATED_COMPOSITING code to not expose RenderLayer outside rendering
https://bugs.webkit.org/show_bug.cgi?id=83816

Reviewed by James Robinson.

No change in behavior expected.

This code adds several functions on RenderBoxModelObject to forward
to the associated layer. This removes the RenderLayer dependencies
at the call sites.

Currently only RenderBoxModelObject can be hardware accelerated as
we need a RenderLayer, this looks like the best place to put those
new functions.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::contentChanged):
(WebCore::RenderBoxModelObject::hasAcceleratedCompositing):
(WebCore::RenderBoxModelObject::startTransition):
(WebCore::RenderBoxModelObject::transitionPaused):
(WebCore::RenderBoxModelObject::transitionFinished):
(WebCore::RenderBoxModelObject::startAnimation):
(WebCore::RenderBoxModelObject::animationPaused):
(WebCore::RenderBoxModelObject::animationFinished):
(WebCore::RenderBoxModelObject::suspendAnimations):

  • rendering/RenderBoxModelObject.h:

Added the previous functions to hide the layer need.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hasAcceleratedCompositing):

  • rendering/RenderLayer.h:

Removed the previous method as it was superseeded by the
one on RenderBoxModelObject. Also moved the ContentChangeType
enumaration.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::contentChanged):

  • rendering/RenderLayerBacking.h:

(RenderLayerBacking):
Updated after the ContentChangeType enumaration move.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::reset):
(WebCore::HTMLCanvasElement::paintsIntoCanvasBuffer):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::didDraw):

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::markContextChanged):
(WebCore::WebGLRenderingContext::reshape):

  • page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::freezeAtTime):

  • page/animation/ImplicitAnimation.cpp:

(WebCore::ImplicitAnimation::startAnimation):
(WebCore::ImplicitAnimation::pauseAnimation):
(WebCore::ImplicitAnimation::endAnimation):

  • page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::startAnimation):
(WebCore::KeyframeAnimation::pauseAnimation):
(WebCore::KeyframeAnimation::endAnimation):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::imageChanged):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::imageDimensionsChanged):
(WebCore::RenderImage::notifyFinished):

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::updatePlayer):
Updated all those call sites to use the new functions. Also
removed unneeded RenderLayer.h include as we went.

14:49 Changeset [114436] by lforschler@apple.com
  • 2 edits in branches/safari-534.57-branch/Source/WebCore

Merged r110150.

14:43 Changeset [114435] by lforschler@apple.com
  • 2 edits in branches/safari-534.57-branch/Source/WebCore

Merged r110139.

14:41 Changeset [114434] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

DFG and LLInt should not clobber the frame pointer on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=84185
<rdar://problem/10767252>

Reviewed by Gavin Barraclough.

Changed LLInt to use a different register. Changed DFG to use one fewer
registers. We should revisit this and switch the DFG to use a different
register instead of r7, but we can do that in a subsequent step since
the performance effect is tiny.

  • dfg/DFGGPRInfo.h:

(GPRInfo):
(JSC::DFG::GPRInfo::toRegister):
(JSC::DFG::GPRInfo::toIndex):

  • offlineasm/armv7.rb:
14:32 Changeset [114433] by aestes@apple.com
  • 3 edits in trunk/Source/WebCore

-webkit-mask-box-image does not draw when layer tree flattening is enabled
https://bugs.webkit.org/show_bug.cgi?id=84111

Reviewed by Simon Fraser.

No new tests since taking pixel test results with
PaintBehaviorFlattenCompositingLayers set is not currently supported.
<https://bugs.webkit.org/show_bug.cgi?id=84110> tracks fixing this.

When painting mask images, we should take the non-composited path if
layers are being flattened.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paintMask):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintMaskImages):

14:28 Changeset [114432] by lforschler@apple.com
  • 2 edits in branches/safari-534.57-branch/Source/WebCore

Merge 114142.

13:56 Changeset [114431] by eae@chromium.org
  • 2 edits in trunk/Source/WebCore

Rollout r114404 as it broke a couple of chromium builds.

  • platform/FractionalLayoutUnit.h:

(WebCore::FractionalLayoutUnit::FractionalLayoutUnit):
(WebCore::FractionalLayoutUnit::isInBounds):
(WebCore):

13:48 Changeset [114430] by lforschler@apple.com
  • 5 edits in branches/safari-534.57-branch/Source

Versioning.

13:45 Changeset [114429] by lforschler@apple.com
  • 1 copy in branches/safari-534.57-branch

New Branch.

13:44 Changeset [114428] by lforschler@apple.com
  • 1 delete in branches/safari-534.57-branch

Remove branch.

13:32 Changeset [114427] by benm@google.com
  • 4 edits
    3 adds in trunk

localStorage.setItem can overwrite localStorage methods
https://bugs.webkit.org/show_bug.cgi?id=30996

Source/WebCore:

Update the JSC and V8 bindings such that if the name of the DOM
Storage property being retrieved is a match for a property in the
prototype, always return the prototype version. If there is a DOM
Storage key of the same name, it can still be retrieved via the
getItem method. This prevents storage methods from being
accidentally hidden. This brings WebKit behavior in line with the
de facto standard implemented by FireFox and IE.

Reviewed by Kentaro Hara.

Test: storage/domstorage/storage-functions-not-overwritten.html

  • bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::nameGetter):

  • bindings/v8/custom/V8StorageCustom.cpp:

(WebCore::V8Storage::namedPropertyGetter):

LayoutTests:

Add a test to verify that setting a DOM Storage key with the same name
as a function on the Storage object does not prevent that function
being called, but also that it can still be retrieved via the getItem
function.

Reviewed by Kentaro Hara.

  • storage/domstorage/script-tests/storage-functions-not-overwritten.js: Added.

(doWedgeThySelf):
(testStorage):
(runTest):

  • storage/domstorage/storage-functions-not-overwritten-expected.txt: Added.
  • storage/domstorage/storage-functions-not-overwritten.html: Added.
13:25 Changeset [114426] by scheib@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

[Chromium] Rebaseline minor text pixel differences in bidi-menulist-expected.

Unreviewed.

  • platform/chromium-mac-leopard/fast/text/international/bidi-menulist-expected.png: Added.
13:21 Changeset [114425] by eae@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix Chromium/Windows build broken by r114404.

  • platform/FractionalLayoutUnit.h:
13:17 Changeset [114424] by leviw@chromium.org
  • 12 edits in branches/subpixellayout/Source/WebCore

Reverting ShadowData to integers, and applying the refactoring from Bug 84098. Also fixing a bug that only showed up in Mac WebKit2 related to the GraphicsContext function roundToDevicePixels, which doesn't when there's no transform (whoops).

13:08 Changeset [114423] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

Reorganise Chromium test_expectations to group SVG expectations.

Unreviewed Chromium expectations change.

This is done to make future maintenance easier.

  • platform/chromium/test_expectations.txt:
13:05 Changeset [114422] by commit-queue@webkit.org
  • 7 edits in trunk

EFL's LayoutTestController does not implement callShouldCloseOnWebView
https://bugs.webkit.org/show_bug.cgi?id=82301

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-04-17
Reviewed by Martin Robinson.

Source/WebKit/efl:

Implement callShouldCloseOnWebView in EFL's LayoutTestController by
calling shouldClose() on the FrameLoader, allowing the related
test to be removed from the skip list.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::callShouldCloseOnWebView):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Implement callShouldCloseOnWebView in EFL's LayoutTestController by
calling shouldClose() on the FrameLoader, allowing the related test
to be removed from the skip list.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::callShouldCloseOnWebView):

LayoutTests:

Implement callShouldCloseOnWebView in EFL's LayoutTestController by
calling shouldClose() on the FrameLoader, allowing the related test
to be removed from the skip list.

  • platform/efl/Skipped:
13:05 Changeset [114421] by haraken@chromium.org
  • 7 edits in trunk/Source/WebCore

[Performance][V8] Skip Isolate look-up to find StringCache
https://bugs.webkit.org/show_bug.cgi?id=84103

Reviewed by Nate Chapin.

This patch improves the performance of a lot of DOM attribute
getters that return a string.

  • Improves the performance of Dromaeo/dom-attr.html(element.property) by 27.7%.
  • Improves the performance of Dromaeo/dom-attr.html(getAttribute) by 10.6%.
  • Improves the performance of div.id, div.className, div.nodeName, text.nodeValue, text.textContent by 12% -- 21%.

The followings are the test results in my Linux desktop.

Performance test: Dromaeo/dom-attr.html
Total: 674.64runs/s -> 707.03runs/s (+ 4.8%)
getAttribute: 1537.60runs/s -> 1700.20runs/s (+10.6%)
element.property: 1389.00runs/s -> 1774.20runs/s (+27.7%)
setAttribute: 538.88runs/s -> 548.87runs/s (+ 1.9%)
element.property = value: 644.07runs/s -> 656.67runs/s (+ 2.0%)
element.expando = value: 219.76runs/s -> 207.14runs/s (- 6.8%)
element.expando: 578.77runs/s -> 554.67runs/s (- 4.2%)

Performance test: https://bugs.webkit.org/attachment.cgi?id=137440
div.id: 30.70ns -> 26.70ns (+15%)
div.className: 31.10ns -> 26.40ns (+18%)
div.nodeName: 37.70ns -> 33.00ns (+14%)
text.nodeValue: 31.40ns -> 25.90ns (+21%)
text.textContent: 51.50ns -> 45.90ns (+12%)

Previously V8 bindings need to look up an Isolate to find
an Isolate-local StringCache. This patch skips the look-up
by getting the Isolate from AccessorInfo.GetIsolate()
or Arguments.GetIsolate().

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateFunctionCallString):
(NativeToJSValue):

  • bindings/v8/V8Binding.cpp:

(WebCore::getElementStringAttr):

  • bindings/v8/V8Binding.h:

(WebCore::v8ExternalString): Make 'isolate' an optional argument.
Ideally we want to make 'isolate' a non-optional argument,
but it is difficult to rewrite all v8ExternalString() callers
at a breath. We can rewrite them incrementally.
(WebCore::v8String): Ditto.
(WebCore::v8StringOrNull): Ditto.
(WebCore::v8StringOrUndefined): Ditto.
(WebCore::v8StringOrFalse): Ditto.

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp: Updated run-bindings-tests results.

(WebCore::TestEventConstructorV8Internal::attr1AttrGetter):
(WebCore::TestEventConstructorV8Internal::attr2AttrGetter):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalStr1AttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrGetter):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::readOnlyStringAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::hashAttrGetter):
(WebCore::TestObjV8Internal::conditionalMethod1Callback):

13:01 Changeset [114420] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] FrameLoaderClient should send "load,finished" signal for all frame, not just the main one
https://bugs.webkit.org/show_bug.cgi?id=84052

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-04-17
Reviewed by Antonio Gomes.

Source/WebKit/efl:

Emit the "load,finished" signal from dispatchDidFinishLoad() / instead of
postProgressFinishedNotification() in order to send notifications all frames,
not just the main one.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::postProgressFinishedNotification):
(WebCore::FrameLoaderClientEfl::dispatchDidFinishLoad):
(WebCore::FrameLoaderClientEfl::dispatchDidFailLoad):

LayoutTests:

Unskip EFL test cases which rely on the DumpRenderTree support for
LayoutTestController's dumpFrameLoadCallbacks() and expect notifications for other
frame than the main one.

  • platform/efl/Skipped:
12:56 Changeset [114419] by commit-queue@webkit.org
  • 13 edits in trunk

[EFL] Add setting API to enable/disable XSSAuditor
https://bugs.webkit.org/show_bug.cgi?id=83281

Source/WebKit/efl:

Add setting API to enable or disable WebKit's XSSAuditor to protect
from reflective cross-site scripting attacks. Also, emit the signal
'xss,detected' and provide addition information received from
XSSAuditor when reflected XSS is encountered in the page.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-17
Reviewed by Antonio Gomes.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::didDetectXSS):

  • ewk/ewk_frame.cpp:

(ewk_frame_xss_detected):

  • ewk/ewk_frame.h:
  • ewk/ewk_private.h:
  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(ewk_view_setting_enable_xss_auditor_get):
(ewk_view_setting_enable_xss_auditor_set):

  • ewk/ewk_view.h:

Tools:

Add missing implementation setXSSAuditorEnabled to EFL's LayoutTestController
in order to unskip tests in http/tests/security/xssAuditor. Also, catch the signal
'xss,detected' in DRT to enable a test, which is expecting a line containing
'didDetectXSS' in the output when reflected XSS is encountered in the page.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-17
Reviewed by Antonio Gomes.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onFrameCreated):
(DumpRenderTreeChrome::onDidDetectXSS):

  • DumpRenderTree/efl/DumpRenderTreeChrome.h:

(DumpRenderTreeChrome):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setXSSAuditorEnabled):

LayoutTests:

Unskip tests in http/tests/security/xssAuditor

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-17
Reviewed by Antonio Gomes.

  • platform/efl/Skipped:
12:48 Changeset [114418] by cfleizach@apple.com
  • 3 edits
    2 adds in trunk

Crash in invalid index for _textMarkerForIndex
https://bugs.webkit.org/show_bug.cgi?id=84104

Reviewed by Beth Dakin.

Source/WebCore:

Test: platform/mac/accessibility/textmarker-for-index-out-of-bounds-crash.html

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper _textMarkerForIndex:]):

LayoutTests:

  • platform/mac/accessibility/textmarker-for-index-out-of-bounds-crash-expected.txt: Added.
  • platform/mac/accessibility/textmarker-for-index-out-of-bounds-crash.html: Added.
12:44 Changeset [114417] by jer.noble@apple.com
  • 15 edits in trunk

HTML5 Video Full Screen button broken (looks like white square)
https://bugs.webkit.org/show_bug.cgi?id=84101

Reviewed by Dan Bernstein.

Source/WebCore:

No new tests; updated platform results which were previously rebaselined.

Use the correct CSS keyword for the -webkit-appearance of the full screen button.

  • css/mediaControls.css:

(audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):

LayoutTests:

  • platform/mac/media/controls-after-reload-expected.png:
  • platform/mac/media/controls-after-reload-expected.txt:
  • platform/mac/media/controls-strict-expected.png:
  • platform/mac/media/controls-strict-expected.txt:
  • platform/mac/media/video-controls-rendering-expected.png:
  • platform/mac/media/video-controls-rendering-expected.txt:
  • platform/mac/media/video-display-toggle-expected.png:
  • platform/mac/media/video-display-toggle-expected.txt:
  • platform/mac/media/video-no-audio-expected.png:
  • platform/mac/media/video-no-audio-expected.txt:
  • platform/mac/media/video-playing-and-pause-expected.png:
  • platform/mac/media/video-playing-and-pause-expected.txt:
12:33 Changeset [114416] by schenney@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

SVG should support transform-origin and relative values
https://bugs.webkit.org/show_bug.cgi?id=79068

Unreviewed Chromium expectations update.

  • platform/chromium-mac/svg/transforms/transform-origin-css-property-expected.png: Added.
  • platform/chromium-win/svg/transforms/transform-origin-css-property-expected.png: Added.
  • platform/chromium/test_expectations.txt:
12:30 Changeset [114415] by schenney@chromium.org
  • 7 edits
    1 add in trunk/LayoutTests

Paddings and borders on root SVG element with viewbox causes child SVG elements to be rendered with the incorrect size
https://bugs.webkit.org/show_bug.cgi?id=78613

Unreviewed Chromium expectations update.

  • platform/chromium-linux/svg/custom/circle-move-invalidation-expected.png:
  • platform/chromium-mac-leopard/svg/custom/circle-move-invalidation-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/circle-move-invalidation-expected.png:
  • platform/chromium-mac/svg/custom/circle-move-invalidation-expected.png: Added.
  • platform/chromium-win/svg/custom/circle-move-invalidation-expected.png:
  • platform/chromium-win/svg/custom/circle-move-invalidation-expected.txt:
  • platform/chromium/test_expectations.txt:
12:24 Changeset [114414] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Make sure that the layer hosting mode is kept up to date if it changes before the plug-in is initialized
https://bugs.webkit.org/show_bug.cgi?id=84180
<rdar://problem/11265113>

Reviewed by Andreas Kling.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::setLayerHostingMode):

12:23 Changeset [114413] by schenney@chromium.org
  • 5 edits
    1 add
    1 delete in trunk/LayoutTests

onclick is not reliable for transformed SVG elements
https://bugs.webkit.org/show_bug.cgi?id=34714

Unreviewed Chromium expectations update.

  • platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-2-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/select-textLength-spacing-squeeze-2-expected.png: Removed.
  • platform/chromium-mac/svg/text/select-textLength-spacing-squeeze-2-expected.png: Added.
  • platform/chromium-win/svg/text/select-textLength-spacing-squeeze-2-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
  • platform/chromium/test_expectations.txt:
12:22 Changeset [114412] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

use after free in JSC::DFG::Node::op / JSC::DFG::ByteCodeParser::flushArgument
https://bugs.webkit.org/show_bug.cgi?id=83942
<rdar://problem/11247370>

Reviewed by Gavin Barraclough.

Don't use references to the graph after resizing the graph.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::flushArgument):

12:19 Changeset [114411] by schenney@chromium.org
  • 3 edits
    4 adds in trunk/LayoutTests

getCTM() on SVG root element with borders, paddings, and viewbox returns incorrect values
https://bugs.webkit.org/show_bug.cgi?id=78631

Unreviewed Chromium expectations update.

  • platform/chromium-linux/svg/dom/SVGLocatable-getCTM-svg-root-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dom/SVGLocatable-getCTM-svg-root-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dom/SVGLocatable-getCTM-svg-root-expected.png:
  • platform/chromium-mac/svg/dom/SVGLocatable-getCTM-svg-root-expected.png: Added.
  • platform/chromium-win/svg/dom/SVGLocatable-getCTM-svg-root-expected.png: Added.
  • platform/chromium/test_expectations.txt:
12:15 Changeset [114410] by schenney@chromium.org
  • 3 edits in trunk/LayoutTests

[Chromium] Cleanup of outdated test expectations
https://bugs.webkit.org/show_bug.cgi?id=81253

Unreviewed Chromium expectations update.

  • platform/chromium-linux/svg/text/text-tselect-02-f-expected.png:
  • platform/chromium/test_expectations.txt:
12:11 Changeset [114409] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

IndexedDB: stub getKey/getObject interfaces for IDBKeyRange
https://bugs.webkit.org/show_bug.cgi?id=84089

Patch by Alec Flett <alecflett@chromium.org> on 2012-04-17
Reviewed by Dimitri Glazkov.

Added stub methods on WebIDBIndex.h to cleanly land
https://bugs.webkit.org/show_bug.cgi?id=83638

  • public/WebIDBIndex.h:

(WebKit::WebIDBIndex::getObject):
(WebKit::WebIDBIndex::getKey):

  • src/WebIDBIndexImpl.cpp:

(WebKit::WebIDBIndexImpl::getObject):
(WebKit):
(WebKit::WebIDBIndexImpl::getKey):

  • src/WebIDBIndexImpl.h:

(WebIDBIndexImpl):

12:10 Changeset [114408] by eae@chromium.org
  • 2 edits in branches/subpixellayout/Source/WebCore/rendering

Fix pixel snapping in RenderThemeChromiumSkia on branch.

12:09 Changeset [114407] by schenney@chromium.org
  • 4 edits
    3 adds
    2 deletes in trunk/LayoutTests

[chromium] svg/clip-path/clip-in-mask.svg fails on Windows and Linux
https://bugs.webkit.org/show_bug.cgi?id=53378

Unreviewed expectations update after the fix went in.

  • platform/chromium-linux-x86/svg/zoom: Removed.
  • platform/chromium-linux/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
  • platform/chromium-win-vista/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
  • platform/chromium-win-xp/svg/zoom: Removed.
  • platform/chromium/test_expectations.txt:
12:03 Changeset [114406] by tsepez@chromium.org
  • 19 edits
    4 adds in trunk

Framesniffing defense is too aggressive.
https://bugs.webkit.org/show_bug.cgi?id=83721

Reviewed by James Robinson.

Source/WebCore:

The RenderLayer code currently propagates scroll position to parent frames
without any cross-origin checks. This gives it a quick origin boundary check
that is set by FrameLoader only when performing a fragment navigation. This
allows us to safely relax the restriction on not scrolling at load time in
FrameLoader since the safe thing will happen later on at scroll time.

Test: http/tests/navigation/anchor-frames-same-origin.html

  • dom/Document.cpp:

(WebCore::Document::findUnsafeParentScrollPropagationBoundary):

  • dom/Document.h:

(Document):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::finishedParsing):
(WebCore::FrameLoader::loadInSameDocument):
(WebCore::FrameLoader::scrollToFragmentWithParentBoundary):

  • loader/FrameLoader.h:

(FrameLoader):

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):

  • page/FrameView.h:

(WebCore::FrameView::safeToPropagateScrollToParent):
(WebCore::FrameView::setSafeToPropagateScrollToParent):
(FrameView):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollRectToVisible):

LayoutTests:

  • http/tests/inspector/resource-parameters-expected.txt:
  • http/tests/navigation/anchor-frames-cross-origin-expected.txt:
  • http/tests/navigation/anchor-frames-cross-origin.html:
  • http/tests/navigation/anchor-frames-same-origin-expected.txt: Added.
  • http/tests/navigation/anchor-frames-same-origin.html: Added.
  • http/tests/navigation/resources/frame-with-anchor-cross-origin.html:
  • http/tests/navigation/resources/frame-with-anchor-same-origin.html: Added.
  • http/tests/navigation/resources/grandchild-with-anchor.html: Added.
  • http/tests/security/xssAuditor/anchor-url-dom-write-location-expected.txt:
  • http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-expected.txt:
  • http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-null-char-expected.txt:
  • http/tests/security/xssAuditor/anchor-url-dom-write-location-javascript-URL-expected.txt:
  • http/tests/security/xssAuditor/anchor-url-dom-write-location2-expected.txt:
  • http/tests/security/xssAuditor/dom-write-location-inline-event-expected.txt:
11:59 April 2012 Meeting edited by kov@webkit.org
(diff)
11:58 Changeset [114405] by barraclough@apple.com
  • 8 edits in trunk

Array.prototype.toString should be generic
https://bugs.webkit.org/show_bug.cgi?id=81588

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):

  • check for join function, use fast case if base object is array & join is present & default.
  • runtime/CommonIdentifiers.h:
    • added 'join'.

LayoutTests:

  • fast/js/array-functions-non-arrays-expected.txt:
    • check in new results
  • fast/js/array-prototype-properties-expected.txt:
    • new more detailed error message.
  • fast/js/script-tests/array-functions-non-arrays.js:
    • added new test cases, fix incorrect one.
  • sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.2_Array_prototype_toString/S15.4.4.2_A2_T1-expected.txt:
    • check in failing result (test is wrong)
11:51 Changeset [114404] by eae@chromium.org
  • 2 edits in trunk/Source/WebCore

Add size_t versions of multiplication and division operators to FractionalLayoutUnit
https://bugs.webkit.org/show_bug.cgi?id=83848

Reviewed by Julien Chaffraix.

Add size_t versions of operator* and operator/ for platforms where there
is no ambiguity between unsigned int and size_t.

No new tests, no new functionality.

  • platform/FractionalLayoutUnit.h:

(FractionalLayoutUnit):
(WebCore::FractionalLayoutUnit::FractionalLayoutUnit):
(WebCore::FractionalLayoutUnit::isInBounds):
(WebCore):
(WebCore::operator*):
(WebCore::operator/):

11:45 Changeset [114403] by schenney@chromium.org
  • 7 edits in trunk/LayoutTests

Update long-failing Chromium expectations.

Unreviewed Chromium expectation update.

There is some chance that the background test is flaky, as many others are.

  • platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-6-expected.png:
  • platform/chromium-mac/svg/as-background-image/svg-as-background-6-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-as-background-6-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
  • platform/chromium/test_expectations.txt:
11:35 Changeset [114402] by jer.noble@apple.com
  • 4 edits in trunk/Source

Exiting full screen video brings the wrong Safari window to the foreground
https://bugs.webkit.org/show_bug.cgi?id=83936

Reviewed by Adele Peterson.

Tell the original webView's window to makeKeyAndOrderFront once the exit
animation completes.

Source/WebKit/mac:

  • WebView/WebFullScreenController.mm:

(-[WebFullScreenController finishedExitFullScreenAnimation:]):

Source/WebKit2:

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):

11:21 Changeset [114401] by haraken@chromium.org
  • 51 edits in trunk/Source/WebCore

[V8] Add an optional Isolate argument to toV8().
https://bugs.webkit.org/show_bug.cgi?id=84161

Reviewed by Nate Chapin.

The final objective is to pass Isolate around in V8 bindings.
This patch adds an optional Isolate argument to toV8().
After rewriting all toV8() callers so that they pass Isolate,
I will make the Isolate argument non-optional.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

Modified as described above.
(GenerateHeader):
(NativeToJSValue):

  • bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8CSSRuleCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8CSSStyleSheetCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8CSSValueCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8CanvasPixelArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8DOMTokenListCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8EntryCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8EntrySyncCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8EventCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Float32ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Float64ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8HTMLElementCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8IDBAnyCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8IDBKeyCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8ImageDataCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Int16ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Int32ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Int8ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::toV8Slow):

  • bindings/v8/custom/V8SVGDocumentCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8SVGElementCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8SVGPathSegCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8ScriptProfileCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8StyleSheetCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Uint16ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Uint32ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Uint8ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8Float64Array.h:

Updated run-bindings-tests results.
(WebCore):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestInterface.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestNode.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestObj.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(WebCore::toV8):

11:20 Changeset [114400] by schenney@chromium.org
  • 3 edits
    4 adds
    2 deletes in trunk/LayoutTests

Update Chromium test expectations for long failing tests.

Unreviewed Chromium test expectations update.

  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • platform/chromium-linux/svg/carto.net/combobox-expected.png: Added.
  • platform/chromium-linux/svg/carto.net/combobox-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:19 Changeset [114399] by commit-queue@webkit.org
  • 2 edits
    7 adds in trunk/LayoutTests

[EFL] Create baselines for tests related to caret behaviour
https://bugs.webkit.org/show_bug.cgi?id=83277

Unreviewed, EFL baselines for tests related to cursor
positioning behaviour.

Adding baselines and unskipping tests related to cursor
positioning behaviour after r114250.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-17

  • platform/efl/editing/input/caret-at-the-edge-of-contenteditable-expected.png: Added.
  • platform/efl/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Added.
  • platform/efl/editing/input/reveal-caret-of-multiline-contenteditable-expected.png: Added.
  • platform/efl/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt: Added.
  • platform/efl/editing/input/reveal-caret-of-multiline-input-expected.png: Added.
  • platform/efl/editing/input/reveal-caret-of-multiline-input-expected.txt: Added.
  • platform/efl/test_expectations.txt:
11:11 Changeset [114398] by schenney@chromium.org
  • 3 edits
    1 add
    2 deletes in trunk/LayoutTests

fill-opacity does not render properly on chromium mac
https://bugs.webkit.org/show_bug.cgi?id=78624

Unreviewed expectations update after this change.

  • platform/chromium-mac-snowleopard/svg/text/text-fill-opacity-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/text/text-fill-opacity-expected.txt: Removed.
  • platform/chromium-mac/svg/text/text-fill-opacity-expected.png: Added.
  • platform/chromium-win/svg/text/text-fill-opacity-expected.txt:
  • platform/chromium/test_expectations.txt:
11:01 Changeset [114397] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/Source/WebKit2

[EFL][WK2] Fix build break when FULLSCREEN_API is enabled.
https://bugs.webkit.org/show_bug.cgi?id=84142

Patch by Michał Pakuła vel Rutka <m.pakula@samsung.com> on 2012-04-17
Reviewed by Martin Robinson.

Create a cpp file needed to build EFL port with FULLSCREEN_API.

  • PlatformEfl.cmake: Added WebFullScreenManagerProxyEfl.cpp to build list.
  • UIProcess/WebFullScreenManagerProxy.h:

(WebKit):

  • UIProcess/efl/WebFullScreenManagerProxyEfl.cpp: Added.

(WebKit):
(WebKit::WebFullScreenManagerProxy::invalidate):
(WebKit::WebFullScreenManagerProxy::close):
(WebKit::WebFullScreenManagerProxy::isFullScreen):
(WebKit::WebFullScreenManagerProxy::enterFullScreen):
(WebKit::WebFullScreenManagerProxy::exitFullScreen):
(WebKit::WebFullScreenManagerProxy::beganEnterFullScreen):
(WebKit::WebFullScreenManagerProxy::beganExitFullScreen):

10:59 Changeset [114396] by dglazkov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Remove fast/forms/implicit-submission.html from flaky expectations,
because it was fixed in r113808.

  • platform/chromium/test_expectations.txt: Removed flaky expectations.
10:57 Changeset [114395] by schenney@chromium.org
  • 23 edits
    6 adds
    1 delete in trunk/LayoutTests

[Chromium] Rebaseline after Skia changes (CR105305)
https://bugs.webkit.org/show_bug.cgi?id=84165

Unreviewed Chromium expectations update.

  • platform/chromium-linux-x86/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
  • platform/chromium-linux/svg/css/composite-shadow-text-expected.png: Modified property svn:mime-type.
  • platform/chromium-linux/svg/css/text-gradient-shadow-expected.png:
  • platform/chromium-linux/svg/text/selection-background-color-expected.png:
  • platform/chromium-linux/svg/text/selection-styles-expected.png:
  • platform/chromium-linux/svg/text/text-gradient-positioning-expected.png:
  • platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
  • platform/chromium-mac-leopard/svg/css/composite-shadow-text-expected.png:
  • platform/chromium-mac-leopard/svg/text/selection-background-color-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-leopard/svg/text/selection-styles-expected.png:
  • platform/chromium-mac-leopard/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/svg/css/composite-shadow-text-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png: Added.
  • platform/chromium-mac/svg/css/composite-shadow-text-expected.png: Added.
  • platform/chromium-mac/svg/css/text-gradient-shadow-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/text/selection-background-color-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/text/selection-styles-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/text/text-gradient-positioning-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
  • platform/chromium-win-vista/svg/css/composite-shadow-text-expected.png: Added.
  • platform/chromium-win-xp/svg/css/composite-shadow-text-expected.png: Added.
  • platform/chromium-win-xp/svg/css/text-gradient-shadow-expected.png: Added.
  • platform/chromium-win/svg/css/composite-shadow-text-expected.png: Modified property svn:mime-type.
  • platform/chromium-win/svg/css/text-gradient-shadow-expected.png:
  • platform/chromium/test_expectations.txt:
10:51 April 2012 Meeting edited by stearns@adobe.com
(diff)
10:41 Changeset [114394] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderTable.cpp

Correct where we do our flooring for tables to be in setting the logical width, instead of at paint time. This avoids a bug where a 1 pixel gap would exist following a table that nothing could be placed in.

10:24 Changeset [114393] by schenney@chromium.org
  • 6 edits
    2 adds
    8 deletes in trunk/LayoutTests

new baselines for crbug 104128
https://bugs.webkit.org/show_bug.cgi?id=72746

Unreviewed Chromium expectations update, just for SVG files.

  • platform/chromium-mac/svg/css/shadow-with-large-radius-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/css/shadow-with-negative-offset-expected.png: Modified property svn:mime-type.
  • platform/chromium-win/svg/css/shadow-with-large-radius-expected.png:
  • platform/chromium-win/svg/css/shadow-with-negative-offset-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/efl/svg/css/shadow-with-large-radius-expected.txt: Removed.
  • platform/efl/svg/css/shadow-with-negative-offset-expected.txt: Removed.
  • platform/gtk/svg/css/shadow-with-large-radius-expected.txt: Removed.
  • platform/gtk/svg/css/shadow-with-negative-offset-expected.txt: Removed.
  • platform/mac/svg/css/shadow-with-large-radius-expected.txt: Removed.
  • platform/mac/svg/css/shadow-with-negative-offset-expected.txt: Removed.
  • platform/qt/svg/css/shadow-with-large-radius-expected.txt: Removed.
  • platform/qt/svg/css/shadow-with-negative-offset-expected.txt: Removed.
  • svg/css/shadow-with-large-radius-expected.txt: Added.
  • svg/css/shadow-with-negative-offset-expected.txt: Added.
10:17 Changeset [114392] by yurys@chromium.org
  • 8 edits
    1 add in trunk/Source/WebCore

Web Inspector: move heap snapshot data grids into their own file
https://bugs.webkit.org/show_bug.cgi?id=84160

Moved heap snapshot data grids into a separate file.

Reviewed by Pavel Feldman.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/DataGrid.js:
  • inspector/front-end/HeapSnapshotDataGrids.js: Added.

(WebInspector.HeapSnapshotSortableDataGrid):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.dispose):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.resetSortingCache):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged.SortByTwoFields):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.updateVisibleNodes):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.onResize):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._onScroll):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingEnter):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingLeave):
(WebInspector.HeapSnapshotContainmentDataGrid):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute.nextStep.else.afterExpand):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype.sortingChanged):
(WebInspector.HeapSnapshotRetainmentDataGrid):
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype._sortFields):
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype.reset):
(WebInspector.HeapSnapshotConstructorsDataGrid):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._defaultPopulateCount.100._sortFields):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._filterSelectIndexChanged):
(WebInspector.HeapSnapshotDiffDataGrid):
(WebInspector.HeapSnapshotDiffDataGrid.prototype._defaultPopulateCount.50._sortFields):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotDiffDataGrid.prototype._baseProfileIndexChanged):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived.addNodeIfNonZeroDiff):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotDominatorsDataGrid):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype._defaultPopulateCount.25.setDataSource):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype.sortingChanged):

  • inspector/front-end/HeapSnapshotView.js:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
10:12 Changeset [114391] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Script make_names.pl should generate consistent .h & .cpp files
https://bugs.webkit.org/show_bug.cgi?id=84140

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-04-17
Reviewed by Kentaro Hara.

Added a newline character and removed ';' after the DEFINE_GLOBAL

No test cases required for this change.

  • dom/make_names.pl:

(printNamesCppFile):

10:09 Changeset [114390] by commit-queue@webkit.org
  • 14 edits
    2 adds in trunk

Source/WebCore: Add webkitSourceAddId() & webkitSourceRemoveId() to HTMLMediaElement
and propagate calls to the MediaPlayerPrivate interface.
These are needed to bring the Media Source implementation
up to date with the new 0.4 version of the Media Source spec.
http://html5-mediasource-api.googlecode.com/svn/tags/0.4/draft-spec/mediasource-draft-spec.html
https://bugs.webkit.org/show_bug.cgi?id=83616

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-04-17
Reviewed by Eric Carlson, Darin Fisher.

Test: http/tests/media/media-source/webm/video-media-source-add-and-remove-ids.html

  • html/HTMLMediaElement.cpp:

(WebCore):
(WebCore::HTMLMediaElement::isValidSourceId):
(WebCore::HTMLMediaElement::webkitSourceAddId):
(WebCore::HTMLMediaElement::webkitSourceRemoveId):
(WebCore::HTMLMediaElement::setSourceState):

  • html/HTMLMediaElement.h:

(HTMLMediaElement):

  • html/HTMLMediaElement.idl:
  • platform/graphics/MediaPlayer.cpp:

(WebCore::NullMediaPlayerPrivate::sourceAddId):
(WebCore::NullMediaPlayerPrivate::sourceRemoveId):
(WebCore):
(WebCore::MediaPlayer::sourceAddId):
(WebCore::MediaPlayer::sourceRemoveId):

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::sourceAddId):
(WebCore::MediaPlayerPrivateInterface::sourceRemoveId):

Source/WebKit/chromium: Add sourceAddId() & sourceRemoveId() stubs for Chromium.
These are needed to bring the Media Source implementation
up to date with the new 0.4 version of the Media Source spec.
http://html5-mediasource-api.googlecode.com/svn/tags/0.4/draft-spec/mediasource-draft-spec.html
https://bugs.webkit.org/show_bug.cgi?id=83616

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-04-17
Reviewed by Eric Carlson, Darin Fisher.

  • public/WebMediaPlayer.h:

(WebKit::WebMediaPlayer::sourceAddId):
(WebKit::WebMediaPlayer::sourceRemoveId):

  • src/AssertMatchingEnums.cpp:
  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::sourceAddId):
(WebKit):
(WebKit::WebMediaPlayerClientImpl::sourceRemoveId):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

LayoutTests: Add LayoutTests for new webkitSourceAddId() & webkitSourceRemoveId() methods.
https://bugs.webkit.org/show_bug.cgi?id=83616

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-04-17
Reviewed by Eric Carlson, Darin Fisher.

  • http/tests/media/media-source/webm/video-media-source-add-and-remove-ids-expected.txt: Added.
  • http/tests/media/media-source/webm/video-media-source-add-and-remove-ids.html: Added.
  • platform/chromium/test_expectations.txt:
10:04 April 2012 Meeting edited by dmazzoni@google.com
(diff)
10:03 April 2012 Meeting edited by eoconnor@apple.com
i would attend several of these talks :) (diff)
10:02 April 2012 Meeting edited by enne@google.com
(diff)
10:02 April 2012 Meeting edited by enne@google.com
(diff)
09:41 Changeset [114389] by abecsi@webkit.org
  • 10 edits in trunk/Source/WebKit2

[Qt][WK2] Refactor the gesture recognizers
https://bugs.webkit.org/show_bug.cgi?id=83044

Reviewed by Kenneth Rohde Christiansen and Simon Hausmann.

This patch implements a simple decision tree in the web page event handler
on the basis of how many active touch points the current touch event has.

Active touch points are pressed, moved or stationary and the number of these
fully determine which gesture recognizer should be updated, cancelled or
finished.

This new structure makes the internal states of the pinch and pan gesture
recognizers independent from the event type, thus makes it possible to handle
the transitions between these gestures in one centralized place which reduces
code duplication and complexity and fixes some issues regarding incorrectly
handled transitions.

  • UIProcess/qt/QtPanGestureRecognizer.cpp:

(WebKit::QtPanGestureRecognizer::update):
(WebKit::QtPanGestureRecognizer::finish):
(WebKit):
(WebKit::QtPanGestureRecognizer::cancel):

  • UIProcess/qt/QtPanGestureRecognizer.h:

(QtPanGestureRecognizer):

  • UIProcess/qt/QtPinchGestureRecognizer.cpp:

(WebKit):
(WebKit::QtPinchGestureRecognizer::update):
(WebKit::QtPinchGestureRecognizer::finish):

  • UIProcess/qt/QtPinchGestureRecognizer.h:

(QtPinchGestureRecognizer):

  • UIProcess/qt/QtTapGestureRecognizer.cpp:

(WebKit::QtTapGestureRecognizer::withinDistance):
(WebKit::QtTapGestureRecognizer::update):
(WebKit::QtTapGestureRecognizer::cancel):
(WebKit):
(WebKit::QtTapGestureRecognizer::singleTapTimeout):
(WebKit::QtTapGestureRecognizer::tapAndHoldTimeout):
(WebKit::QtTapGestureRecognizer::reset):

  • UIProcess/qt/QtTapGestureRecognizer.h:

(QtTapGestureRecognizer):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit):

  • UIProcess/qt/QtViewportInteractionEngine.h:

(QtViewportInteractionEngine):

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(QtWebPageEventHandler::resetGestureRecognizers):
(QtWebPageEventHandler::doneWithTouchEvent):

09:31 Changeset [114388] by apavlov@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: [CRASH] InspectorDOMAgent::didInsertDOMNode() on page reload with open Inspector
https://bugs.webkit.org/show_bug.cgi?id=84154

Source/WebCore:

Check that a node inserted actually has a parent.

Reviewed by Yury Semikhatsky.

Test: inspector/elements/elements-panel-reload-assert.html

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::didInsertDOMNode):

LayoutTests:

Reviewed by Yury Semikhatsky.

  • inspector/elements/elements-panel-reload-assert-expected.txt: Added.
  • inspector/elements/elements-panel-reload-assert.html: Added.
09:26 Changeset [114387] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt] JSC build should handle --no-webkit2 option to avoid unwanted clean-builds
https://bugs.webkit.org/show_bug.cgi?id=77533

Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-04-17
Reviewed by Simon Hausmann.

Pick up the --no-webkit2 option from BUILD_WEBKIT_ARGS and pass on
the corresponding parameter to the buildQMakeProjects function.

  • Scripts/build-jsc:
09:13 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
09:13 Changeset [114386] by commit-queue@webkit.org
  • 12 edits in trunk

[EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()
https://bugs.webkit.org/show_bug.cgi?id=83030

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-04-17
Reviewed by Antonio Gomes.

Source/WebKit/efl:

Emit "load,started" and "onload,event" signals needed to support
LayoutTestController's dumpFrameLoadCallbacks() in EFL's DumpRenderTree.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchDidHandleOnloadEvents):
(WebCore::FrameLoaderClientEfl::dispatchDidCommitLoad):
(WebCore::FrameLoaderClientEfl::dispatchDidFailLoad):

  • ewk/ewk_frame.cpp:

(ewk_frame_load_committed):
(ewk_frame_load_started):

  • ewk/ewk_frame.h:
  • ewk/ewk_private.h:
  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(ewk_view_load_started):
(ewk_view_onload_event):

  • ewk/ewk_view.h:

Tools:

Implement support for LayoutTestController's dumpFrameLoadCallbacks()
in EFL's DumpRenderTree. Make use of the new frame argument passed to
the "load,started" and "load,finished" signals.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onLoadStarted):
(DumpRenderTreeChrome::processWork):
(DumpRenderTreeChrome::topLoadingFrameLoadFinished):
(DumpRenderTreeChrome::onWebViewOnloadEvent):
(DumpRenderTreeChrome::onInsecureContentRun):
(DumpRenderTreeChrome::onInsecureContentDisplayed):
(DumpRenderTreeChrome::onFrameCreated):
(DumpRenderTreeChrome::onFrameProvisionalLoad):
(DumpRenderTreeChrome::onFrameLoadCommitted):
(DumpRenderTreeChrome::onFrameLoadFinished):
(DumpRenderTreeChrome::onFrameLoadError):

  • DumpRenderTree/efl/DumpRenderTreeChrome.h:

(DumpRenderTreeChrome):

LayoutTests:

Unskip the test cases in EFL which needed dumpFrameLoadCallbacks()
support in the DumpRenderTree now that it is implemented.

  • platform/efl/Skipped:
09:12 Changeset [114385] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] Enable back double buffering on WebKitWebView to fix flickering
https://bugs.webkit.org/show_bug.cgi?id=84149

Patch by Carlos Garnacho <carlos@lanedo.com> on 2012-04-17
Reviewed by Martin Robinson.

Despite having WebKitWebView its own backing buffer, calling
gtk_widget_set_double_buffered(...,FALSE) may still pose side
effects, such as ensuring that all drawing operations are
flushed to the X server before rendering a non-double buffered
widget, which may translate into flickering of the parent
GdkWindow before the WebKitWebView itself is rendered.

Enabling back double buffering solves this as all contents are
first composited together before getting to the front buffer,
but effectively acts as 3rd buffer. This is sort of unavoidable
unless GTK+ gains a "let me take ownership of the backing buffer
for this widget", which currently lacks.

  • webkit/webkitwebview.cpp:

(webkit_web_view_init): Remove call to gtk_widget_set_double_buffered(..., FALSE)

09:10 Changeset [114384] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

REGRESSION(r113172) Wheel events are scrolling inversed.
https://bugs.webkit.org/show_bug.cgi?id=84156

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-17
Reviewed by Simon Hausmann.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::wheelEvent):

08:50 Changeset [114383] by danakj@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Consistent checking for clipped rects when we need the computed result enclosed within the real result
https://bugs.webkit.org/show_bug.cgi?id=83543

Reviewed by Adrienne Walker.

It should not be possible to make a rect in layer space that is clipped
by the camera but for which the screen space transform gives a
rectilinear output. But use consistent methods for checking that the
result remains enclosed within the actual pixels.

One day when clipped is true, we can find an interior axis-aligned rect
within the clipped result, and checking clipped explicitly makes this
more clear.

Covered by existing tests.

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::computeOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):

08:38 Changeset [114382] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Suggest box appears after the command was executed in console sometimes.
https://bugs.webkit.org/show_bug.cgi?id=84148

Reviewed by Pavel Feldman.

TextPrompt.complete() requests completions asynchronously, this change adds a flag
that informs TextPrompt._completionsReady() whether completions should still be shown.

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.clearAutoComplete):
(WebInspector.TextPrompt.prototype.complete):
(WebInspector.TextPrompt.prototype._completionsReady):

08:37 Changeset [114381] by commit-queue@webkit.org
  • 13 edits in trunk

Unreviewed, rolling out r114376.
http://trac.webkit.org/changeset/114376
https://bugs.webkit.org/show_bug.cgi?id=84155

Wrong patch version committed, asked by the patch author.
(Requested by rakuco on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-17

Source/WebKit/efl:

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::postProgressFinishedNotification):
(WebCore::FrameLoaderClientEfl::dispatchDidFinishLoad):
(WebCore::FrameLoaderClientEfl::dispatchDidHandleOnloadEvents):
(WebCore::FrameLoaderClientEfl::dispatchDidCommitLoad):
(WebCore::FrameLoaderClientEfl::dispatchDidFailLoad):

  • WebCoreSupport/FrameLoaderClientEfl.h:

(FrameLoaderClientEfl):

  • ewk/ewk_frame.cpp:
  • ewk/ewk_frame.h:
  • ewk/ewk_private.h:
  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):

  • ewk/ewk_view.h:

Tools:

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::processWork):
(DumpRenderTreeChrome::onLoadFinished):
(DumpRenderTreeChrome::onWillSendRequest):

  • DumpRenderTree/efl/DumpRenderTreeChrome.h:

(DumpRenderTreeChrome):

LayoutTests:

  • platform/efl/Skipped:
08:20 Changeset [114380] by mifenton@rim.com
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Pattern matching should be applied to numbers
https://bugs.webkit.org/show_bug.cgi?id=84152

Reviewed by Antonio Gomes.

PR 148906.

Add pattern matching for number based on [0-9] to trigger
input help matching number fields.

  • WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::elementPatternIndicatesNumber):
(DOMSupport):
(BlackBerry::WebKit::DOMSupport::elementPatternIndicatesHexadecimal):
(BlackBerry::WebKit::DOMSupport::elementPatternMatches):

  • WebKitSupport/DOMSupport.h:
  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::convertInputType):

08:20 Changeset [114379] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION (r105453): Crash when handling touch events
https://bugs.webkit.org/show_bug.cgi?id=81958

Patch by Yong Li <yoli@rim.com> on 2012-04-17
Reviewed by Antonio Gomes.

.:

Add a manual test for this issue because DumpRenderTree
currently cannot send a group of touch points with
different touch states in one shot.

  • ManualTests/resources/iframe-reloaded-on-touch.html: Added.
  • ManualTests/touch-stale-iframe-crash.html: Added.

Source/WebCore:

Always perform sanity checks when handling every touch point
because the node and document may have been destroyed or detached.

ManualTests/touch-stale-iframe-crash.html added.
(DumpRenderTree doesn't support transiting touch states in one shot yet)

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleTouchEvent):

08:18 Changeset [114378] by schenney@chromium.org
  • 2 edits
    1 add
    1 delete in trunk/LayoutTests

[Chromium] Rebaseline svg/carto.net/colourpicker.svg

Unreviewed Chromium test expectations update.

This test has been marked as failing for so long that its result is
always wrong. Rebaselining to review flakiness.

  • platform/chromium-linux/svg/carto.net/colourpicker-expected.png: Added.
  • platform/chromium-linux/svg/carto.net/colourpicker-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
08:06 Changeset [114377] by schenney@chromium.org
  • 36 edits
    12 adds
    5 deletes in trunk/LayoutTests

[Chromium] Rebaseline after fix/improve bitmap sampling (matrixproc)
https://bugs.webkit.org/show_bug.cgi?id=84150

Unreviewed Chromium test expectations update.

  • fast/repaint/background-misaligned-expected.txt: Added.
  • platform/chromium-linux-x86/fast/repaint/background-misaligned-expected.png: Added.
  • platform/chromium-linux/fast/repaint/background-misaligned-expected.png: Added.
  • platform/chromium-linux/fast/repaint/backgroundSizeRepaint-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-linux/svg/custom/pattern-skew-transformed-expected.png: Added.
  • platform/chromium-linux/svg/custom/pattern-with-transformation-expected.png:
  • platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-leopard/fast/gradients/background-clipped-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/repaint/background-misaligned-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/backgroundSizeRepaint-expected.png:
  • platform/chromium-mac-leopard/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-mac-leopard/svg/custom/pattern-rotate-expected.png:
  • platform/chromium-mac-leopard/svg/custom/pattern-with-transformation-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-leopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-mac-snowleopard/fast/gradients/background-clipped-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/background-misaligned-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/backgroundSizeRepaint-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/pattern-rotate-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/pattern-with-transformation-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac-snowleopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-mac/fast/gradients/background-clipped-expected.txt:
  • platform/chromium-mac/fast/repaint/background-misaligned-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/fast/repaint/backgroundSizeRepaint-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-zoom-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png: Added.
  • platform/chromium-mac/svg/custom/pattern-in-defs-expected.png:
  • platform/chromium-mac/svg/custom/pattern-rotate-expected.png:
  • platform/chromium-mac/svg/custom/pattern-skew-transformed-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/custom/pattern-with-transformation-expected.png:
  • platform/chromium-mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-win-vista/fast/repaint: Added.
  • platform/chromium-win-vista/fast/repaint/background-misaligned-expected.png: Added.
  • platform/chromium-win-xp/fast/repaint/background-misaligned-expected.png: Added.
  • platform/chromium-win-xp/svg/as-border-image: Removed.
  • platform/chromium-win/fast/repaint/background-misaligned-expected.png:
  • platform/chromium-win/fast/repaint/backgroundSizeRepaint-expected.png:
  • platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-zoom-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-win/svg/custom/pattern-in-defs-expected.png:
  • platform/chromium-win/svg/custom/pattern-skew-transformed-expected.png:
  • platform/chromium-win/svg/custom/pattern-with-transformation-expected.png:
  • platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/efl/fast/repaint/background-misaligned-expected.txt: Removed.
  • platform/gtk/fast/repaint/background-misaligned-expected.txt: Removed.
  • platform/mac/fast/repaint/background-misaligned-expected.txt: Removed.
  • platform/qt/fast/repaint/background-misaligned-expected.txt: Removed.
08:02 Changeset [114376] by commit-queue@webkit.org
  • 13 edits in trunk

[EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()
https://bugs.webkit.org/show_bug.cgi?id=83030

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-04-17
Reviewed by Antonio Gomes.

Source/WebKit/efl:

Implement support for LayoutTestController's dumpFrameLoadCallbacks()
in EFL's DumpRenderTree. We no longer emit the "load,finished" signal
from postProgressFinishedNotification() since it is already emitted
from dispatchDidFinishLoad(). This avoids unwanted extra signals we
prevent some tests from passing (e.g.
http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html).

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::postProgressFinishedNotification):
(WebCore::FrameLoaderClientEfl::dispatchDidFinishLoad):
(WebCore::FrameLoaderClientEfl::dispatchDidHandleOnloadEvents):
(WebCore::FrameLoaderClientEfl::dispatchDidCommitLoad):
(WebCore::FrameLoaderClientEfl::dispatchDidFailLoad):

  • WebCoreSupport/FrameLoaderClientEfl.h:

(FrameLoaderClientEfl):

  • ewk/ewk_frame.cpp:

(ewk_frame_load_committed):

  • ewk/ewk_frame.h:
  • ewk/ewk_private.h:
  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(ewk_view_onload_event):

  • ewk/ewk_view.h:

Tools:

Implement support for LayoutTestController's dumpFrameLoadCallbacks()
in EFL's DumpRenderTree.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::processWork):
(DumpRenderTreeChrome::topLoadingFrameLoadFinished):
(DumpRenderTreeChrome::onWebViewOnloadEvent):
(DumpRenderTreeChrome::onInsecureContentRun):
(DumpRenderTreeChrome::onInsecureContentDisplayed):
(DumpRenderTreeChrome::onFrameCreated):
(DumpRenderTreeChrome::onFrameProvisionalLoad):
(DumpRenderTreeChrome::onFrameLoadCommitted):
(DumpRenderTreeChrome::onFrameLoadFinished):
(DumpRenderTreeChrome::onFrameLoadError):

  • DumpRenderTree/efl/DumpRenderTreeChrome.h:

(DumpRenderTreeChrome):

LayoutTests:

Unskip the test cases in EFL which needed dumpFrameLoadCallbacks()
support in the DumpRenderTree now that it is implemented.

  • platform/efl/Skipped:
07:15 Changeset [114375] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Unreviewed ARM build fix

  • PluginProcess/qt/PluginProcessMainQt.cpp:

(WebKit::PluginProcessMain): Export this function.

07:02 Changeset [114374] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

Asserts in XMLHttpRequestProgressEventThrottle
https://bugs.webkit.org/show_bug.cgi?id=81506

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-17
Reviewed by Julien Chaffraix.

Source/WebCore:

The asserts were incorrectly triggered because suspending active DOM objects
(which suspends the XMLHttpRequestProgressEventThrottle) doesn't stop JavaScript
from running or suspend any running loader we may have. The previous code would
assume those 2 cases were impossible.

When XmlHttpRequest::open is called or data is received while the XmlHttpRequest object
is suspended the object may attempt to dispatch events. This patch defers these events
until the object is resumed.

Progress events are coalesced similar to normal throttling, and readystate-change events
are coalesced to avoid identical events emitted right after eachother.

On resume the events are dispatched after a timer to avoid interfering with
ScriptExecutionContext which is iterating over suspended objects.

Test: fast/events/pagehide-xhr-open.html

  • xml/XMLHttpRequestProgressEventThrottle.cpp:

(WebCore::XMLHttpRequestProgressEventThrottle::XMLHttpRequestProgressEventThrottle):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchProgressEvent):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchEvent):
(WebCore::XMLHttpRequestProgressEventThrottle::flushProgressEvent):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchDeferredEvents):
(WebCore::XMLHttpRequestProgressEventThrottle::fired):
(WebCore::XMLHttpRequestProgressEventThrottle::suspend):
(WebCore::XMLHttpRequestProgressEventThrottle::resume):

  • xml/XMLHttpRequestProgressEventThrottle.h:

(XMLHttpRequestProgressEventThrottle):

LayoutTests:

Tests that xmlhttprequest.open does not assert in when called from onpagehide.

  • fast/events/pagehide-xhr-open-expected.txt: Added.
  • fast/events/pagehide-xhr-open.html: Added.
  • fast/events/resources/subframe-xmlhttprequest.html: Added.
  • platform/chromium/test_expectations.txt:
06:44 Changeset [114373] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Chromium] Crash when inspecting empty IndexedDB object store.
https://bugs.webkit.org/show_bug.cgi?id=84035

Reviewed by Pavel Feldman.

Added a check that m_idbCursor is not null before calling postSuccessHandlerCallback() on it.

  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):

06:35 Changeset [114372] by loislo@chromium.org
  • 1 edit
    1 move in trunk/PerformanceTests

Web Inspector: the fix for test after massive rename in r114271.
https://bugs.webkit.org/show_bug.cgi?id=84147

Drive by fix. The test was renamed to heap-snapshot.html

Reviewed by Yury Semikhatsky.

  • inspector/heap-snapshot.html: Renamed from PerformanceTests/inspector/detailed-heapshots-smoke-test.html.
06:30 WebKit Team edited by pilgrim@chromium.org
(diff)
06:29 Changeset [114371] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt] Fix builds with force_static_libs_as_shared for non-linux builds.
https://bugs.webkit.org/show_bug.cgi?id=83035

Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-04-17
Reviewed by Simon Hausmann.

The force_static_libs_as_shared feature for the Qt port will remove
hide_symbols from Qt's CONFIG in order to make them visible to other
libraries again.

Due to an evaluation order problem in qmake, the flags for the C++ compiler
that are set by adding hide_symbols to the CONFIG variables get applied
to qmake's C++ compiler flags directly and hence trying to remove these
later will not work and cause build failures when using the force_static_libs_as_shared
feature of the Qt port.

This is fixed by removing the flags that hide the exports from the compiler flags directly.

  • qmake/mkspecs/features/force_static_libs_as_shared.prf:
06:14 Changeset [114370] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt] Zoom out on second double-tap.
https://bugs.webkit.org/show_bug.cgi?id=84145

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-17
Reviewed by Simon Hausmann.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):

  • UIProcess/qt/QtViewportInteractionEngine.h:

(QtViewportInteractionEngine):

06:10 Changeset [114369] by reed@google.com
  • 2 edits in trunk/LayoutTests

Need to rebaseline these images after skia 3695 lands
https://bugs.webkit.org/show_bug.cgi?id=84144

Unreviewed. Expectations change only

  • platform/chromium/test_expectations.txt:
06:03 Changeset [114368] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [regression r112413]content scripts tree outline is not added to the tab.
https://bugs.webkit.org/show_bug.cgi?id=84146

Reviewed by Vsevolod Vlasov.

Adding the tree to the container.

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator):

04:56 Changeset [114367] by commit-queue@webkit.org
  • 31 edits in trunk/Source

[EFL][WK2] Fix build break when CONTEXT_MENUS is disabled.
https://bugs.webkit.org/show_bug.cgi?id=83285

Patch by Mariusz Grzegorczyk <mariusz.g@samsung.com> on 2012-04-17
Reviewed by Ryosuke Niwa.

Source/WebCore:

  • platform/ContextMenuItem.h: Remove macro around enums - needed by InjectedBundle.

(WebCore):

  • platform/Widget.h: Remove namespace WebCore for PlatformPageClient typedef.

Source/WebKit/efl:

Remove WebCore namespace from PageClientEfl.

  • WebCoreSupport/PageClientEfl.cpp:

(WebCore):

  • WebCoreSupport/PageClientEfl.h:
  • ewk/ewk_private.h:

(EWKPrivate):

  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(EWKPrivate::corePageClient):

Source/WebKit2:

Surround code related to context menu with ENABLE(CONTEXT_MENUS) macro.
Add dummy functions for public API implementation related to context menu.

  • Shared/API/c/WKContextMenuItem.cpp:

(WKContextMenuItemGetTypeID):
(WKContextMenuItemCreateAsAction):
(WKContextMenuItemCreateAsCheckableAction):
(WKContextMenuItemCreateAsSubmenu):
(WKContextMenuItemSeparatorItem):
(WKContextMenuItemGetTag):
(WKContextMenuItemGetType):
(WKContextMenuItemCopyTitle):
(WKContextMenuItemGetEnabled):
(WKContextMenuItemGetChecked):
(WKContextMenuCopySubmenuItems):
(WKContextMenuItemGetUserData):
(WKContextMenuItemSetUserData):

  • Shared/WebContextMenuItem.cpp:
  • Shared/WebContextMenuItem.h:
  • Shared/WebContextMenuItemData.cpp:
  • Shared/WebContextMenuItemData.h:
  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageContextMenuClient):

  • UIProcess/WebPageContextMenuClient.cpp:
  • UIProcess/WebPageContextMenuClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageSetContextMenuClient):

  • WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.h:
  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
  • WebProcess/WebCoreSupport/WebContextMenuClient.h:
  • WebProcess/WebCoreSupport/efl/WebContextMenuClientEfl.cpp:
  • WebProcess/WebPage/WebContextMenu.cpp:
  • WebProcess/WebPage/WebContextMenu.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit):
(WebKit::handleMouseEvent):
(WebKit::WebPage::mouseEvent):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

  • WebProcess/WebPage/WebPage.messages.in:
04:53 Changeset [114366] by mario@webkit.org
  • 4 edits in trunk/LayoutTests

Unreviewed, fix wrong paths to JS resources in GTK tests.

  • platform/gtk/accessibility/aria-list-and-listitem.html:
  • platform/gtk/accessibility/aria-option-role.html:
  • platform/gtk/accessibility/aria-option-role-expected.txt: Fixed

typo in the expected output.

04:36 Changeset [114365] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skipped this test because of missing test fonts.

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-04-17

  • platform/qt-5.0/Skipped:
04:35 Changeset [114364] by ossy@webkit.org
  • 2 edits
    4 adds in trunk/LayoutTests

[Qt] Rebaseline and add platform specific expectations, after r114283.

Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-04-17
Reviewed by Csaba Osztrogonác.

  • platform/qt-5.0-wk2/compositing/backing/no-backing-for-clip-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/backing/no-backing-for-clip-overlap-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/backing/no-backing-for-perspective-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/geometry/preserve-3d-switching-expected.txt:
04:05 Changeset [114363] by toyoshim@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update expectations for worker WebSocket tests
https://bugs.webkit.org/show_bug.cgi?id=84125

Add BUGWK84125 and mark as CRASH.

  • platform/chromium/test_expectations.txt:
03:58 Changeset [114362] by mario@webkit.org
  • 2 edits
    2 moves
    5 adds in trunk/LayoutTests

Unreviewed, GTK rebaseline after r113981.

  • accessibility/aria-labelledby-on-input-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-labelledby-on-input-expected.txt.
  • accessibility/aria-labelledby-stay-within-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-labelledby-stay-within-expected.txt.
  • platform/gtk/accessibility/aria-list-and-listitem-expected.txt: Added.
  • platform/gtk/accessibility/aria-list-and-listitem.html: Added.
  • platform/gtk/accessibility/aria-option-role-expected.txt: Added.
  • platform/gtk/accessibility/aria-option-role.html: Added.
  • platform/gtk/accessibility/lists-expected.txt: Added.
  • platform/gtk/test_expectations.txt:
02:48 Changeset [114361] by staikos@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

Export the initialization function so it can be called earlier.
https://bugs.webkit.org/show_bug.cgi?id=84134

Reviewed by Nikolas Zimmermann.

  • Api/BlackBerryGlobal.h: export globalInitialize()

(WebKit):

01:37 April 2012 Meeting edited by rniwa@webkit.org
(diff)
01:36 Changeset [114360] by tkent@chromium.org
  • 7 edits in trunk/Source/WebCore

Introduce an internal feature for a fixed placeholder
https://bugs.webkit.org/show_bug.cgi?id=84009

Reviewed by Hajime Morita.

This change adds a framework to support fixed placeholder string for
textfield-like <input> without the palceholder attribute support. This
doesn't change any behavior of input types which support the
'placeholder' attribute.

According to the standard, <input type=date> doesn't support the
'placeholder' attribute. However it is a kind of text field in WebKit
platforms with ENABLE_CALENDAR_PICKER, and we may show something useful
information as the default placeholder.

No new tests because of no behavior changes.

  • html/HTMLTextFormControlElement.h:

(HTMLTextFormControlElement): Make isPlaceholderEmpty() virtual.

  • html/HTMLInputElement.h:

(HTMLInputElement): Overrides isPlaceholderEmpty().

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::isPlaceholderEmpty):
Check InputType::defaultPlaceholder() if InputType::usesFixedPlaceholder().

  • html/InputType.cpp:

(WebCore::InputType::usesFixedPlaceholder): Added. Returns false.
(WebCore::InputType::fixedPlaceholder): Added. Returns a null string.

  • html/InputType.h:

(InputType): Add usesFixedPlaceholder() and fixedPlaceholder().

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::updatePlaceholderText):
Uses fixedPlaceholder() instead of strippedPlaceholder() if usesFixedPlaceholder().

01:20 Changeset [114359] by tkent@chromium.org
  • 4 edits
    1 copy in trunk/Source/WebCore

Move some code of LocalizedNumberICU.cpp to ICULocale.cpp
https://bugs.webkit.org/show_bug.cgi?id=84128

Reviewed by Hajime Morita.

No new tests. No behavior change.

  • WebCore.gypi: Add ICULocale.cpp
  • platform/text/ICULocale.cpp:

Added. Move some code from LocalizedNumberICU.cpp

  • platform/text/ICULocale.h:

(ICULocale): Add currentLocale().

  • platform/text/LocalizedNumberICU.cpp:

(WebCore::convertToLocalizedNumber): Use ICULocale::currentLocale().
(WebCore::convertFromLocalizedNumber): ditto.

00:47 Changeset [114358] by hausmann@webkit.org
  • 2 edits in trunk/Source/WebCore

[Plugins] delete ws_info regardless of window mode.
https://bugs.webkit.org/show_bug.cgi?id=83004

Patch by Bang Kwang min <justine.bang@samsung.com> on 2012-04-17
Reviewed by Simon Hausmann.

m_npWindow.ws_info should be deleted even if plugin run as windowless mode to remove memory leak.
Every plugin works well after this patch without any crash.
Additionally, change casting syntax to C++ style.

  • plugins/PluginView.cpp:

(WebCore::PluginView::stop):

00:40 Changeset [114357] by tkent@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Calendar Picker: Popup position is wrong when there are
no enough space below the target date field
https://bugs.webkit.org/show_bug.cgi?id=84007

Reviewed by Hajime Morita.

The popup was detached from the origin element because
calendarPicker.js resizes its window. To fix this bug, we move the
window position vertically when it is resized.

No new tests. This is not testable in WebKit.

  • src/WebPagePopupImpl.cpp:

(WebKit::PagePopupChromeClient::setWindowRect):
If this request is just a resize and m_isPutAboveOrigin is true,
update the vertical position so that the popup attaches to the
origin rectangle.
(WebKit::WebPagePopupImpl::WebPagePopupImpl):
Initialize m_isPutAboveOrigin with false.
(WebKit::WebPagePopupImpl::init): Set m_isPutAboveOrigin true.

  • src/WebPagePopupImpl.h:

(WebPagePopupImpl): Add m_isPutAboveOrigin.

00:30 Changeset [114356] by tkent@chromium.org
  • 5 edits in trunk

Calendar Picker: Support RTL layout
https://bugs.webkit.org/show_bug.cgi?id=83668

Reviewed by Hajime Morita.

.:

  • ManualTests/forms/calendar-picker.html:

Add Arabic parameters.
Add <select> to select a locale.

Source/WebCore:

Manual test: ManualTests/forms/calendar-picker.html

  • Resources/calendarPicker.js:

(layout): If params.isRTL, add dir=rtl to the body.
(DaysTable.prototype._handleKey): Reverse Left and Right cursor keys if RTL.

  • html/shadow/CalendarPickerElement.cpp:

(WebCore::addProperty): Add addProperty() with a bool value.
(WebCore::CalendarPickerElement::writeDocument):
Check the direction of the first character of localized January label,
and pass it as isRTL property.

00:21 Changeset [114355] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip tests because ENABLE(SHADOW_DOM) is disabled.

  • platform/qt/Skipped:
00:18 Changeset [114354] by toyoshim@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium expectations.

  • platform/chromium/test_expectations.txt:
00:18 Changeset [114353] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Remove CreateWebKitBuildDirectory step to fix Chromium Windows Perf bot
https://bugs.webkit.org/show_bug.cgi?id=84068

Reviewed by Eric Seidel.

Remove CreateWebKitBuildDirectory from master.cfg since download-built-product
automatically creates the build directory if needed.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(DownloadAndPerfTestFactory.init):
(DownloadAndPerfTestWebKit2Factory.init):

04/16/12:

23:51 April 2012 Meeting edited by vestbo@webkit.org
(diff)
23:45 Changeset [114352] by carlosgc@webkit.org
  • 4 edits in trunk/Source

Unreviewed. Fix make distcheck issues.

Source/JavaScriptCore:

  • GNUmakefile.list.am: Add missing files.

Source/WebCore:

  • GNUmakefile.list.am: Add missing files.
23:40 Changeset [114351] by commit-queue@webkit.org
  • 106 edits
    1 add in trunk/Source/WebCore

insertedIntoDocument and insertedIntoTree should be unitifed.
https://bugs.webkit.org/show_bug.cgi?id=82701

Patch by Hajime Morrita <morrita@chromium.org> on 2012-04-16
Reviewed by Ryosuke Niwa.

Both Node::insertedIntoTree() and Node::insertedIntoDocument() are
served as lifecycle callbacks which are invoked when a node is
inserted into its new parent. There are also removedFromTree()
and removedFromDocument() respectively. Considering that this pair
of virtual functions are laid onto the hot path, it's worth
merging them into one, to gain some speedup. Such
unification could clarify the semantics as well.

This change makes following change to merge these functions.

  • pulling the tree traversal out from ContainerNode to ChildNodeInsertionNotifier.
  • letting new Node::insertInto() do the job for its own, but not for its children and
  • Pass the parent of each insertion root as a parameter of insertedInto(). This root node can tell inserted node where it is inserted, specifically whetehr the insertion is to the document or not.

Same pattern is also applied to Node::removedFromDocument() and
Node::removedFromTree(), which are factored to Node::removedFrom()
and ChildNodeRemovalNotifier respectively.

Speed up on Dromaeo/dom-modify.html is about 2%.
Further speed-up by de-virtulization would be possible.

Caveat:

There is possible situation where a node need to invoke
insertedInto() after its children is nofitied, instead of before
that. It was represented naturally with previous
traversal-by-ContainerNode pattern, but is no longer simple with
this new external traversal. To support this scenario, we
introduced the InsertionNotificationRequest as a return value of insertedInto()
and a supplemental hook Node::didNotifyDescendantInseretions(). See for
example HTMLFormElement.cpp to learn how it works.

No new tests. Covered by existing tests.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::parserInsertBefore):
(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::parserRemoveChild):
(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::parserAddChild):
(WebCore::updateTreeAfterInsertion):

  • dom/ContainerNode.h:

(ContainerNode):
(WebCore::Node::highestAncestor):
(WebCore):

  • dom/ContainerNodeAlgorithms.cpp: Added.

(WebCore):
(WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoDocument):
(WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoTree):
(WebCore::ChildNodeRemovalNotifier::notifyDescendantRemovedFromDocument):
(WebCore::ChildNodeRemovalNotifier::notifyDescendantRemovedFromTree):

  • dom/ContainerNodeAlgorithms.h:

(ChildNodeInsertionNotifier):
(WebCore::ChildNodeInsertionNotifier::ChildNodeInsertionNotifier):
(WebCore):
(ChildNodeRemovalNotifier):
(WebCore::ChildNodeRemovalNotifier::ChildNodeRemovalNotifier):
(WebCore::removeAllChildrenInContainer):
(WebCore::appendChildToContainer):
(Private):
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoDocument):
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoTree):
(WebCore::ChildNodeInsertionNotifier::notifyInsertedIntoDocument):
(WebCore::ChildNodeInsertionNotifier::notify):
(WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromDocument):
(WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromTree):
(WebCore::ChildNodeRemovalNotifier::notify):

  • dom/DOMAllInOne.cpp:
  • dom/DocumentType.cpp:

(WebCore::DocumentType::insertedInto):
(WebCore::DocumentType::removedFrom):

  • dom/DocumentType.h:

(DocumentType):

  • dom/Element.cpp:

(WebCore::Element::insertedInto):
(WebCore::Element::removedFrom):

  • dom/Element.h:

(Element):

  • dom/Node.cpp:

(WebCore::Node::insertedInto):
(WebCore::Node::removedFrom):

  • dom/Node.h:

(Node):
(WebCore::Node::didNotifyDescendantInseretions):

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::insertedInto):
(WebCore::ProcessingInstruction::removedFrom):

  • dom/ProcessingInstruction.h:

(ProcessingInstruction):

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::insertedInto):

  • dom/ScriptElement.h:

(WebCore):
(ScriptElement):

  • dom/ShadowTree.cpp:

(WebCore::ShadowTree::addShadowRoot):
(WebCore::ShadowTree::removeAllShadowRoots):

  • dom/ShadowTree.h:

(ShadowTree):
(ShadowRootVector):
(WebCore::ShadowRootVector::ShadowRootVector):
(WebCore):

  • html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::insertedInto):
(WebCore::FormAssociatedElement::removedFrom):
(WebCore::FormAssociatedElement::formRemovedFromTree):

  • html/FormAssociatedElement.h:

(FormAssociatedElement):

  • html/HTMLBaseElement.cpp:

(WebCore::HTMLBaseElement::insertedInto):
(WebCore::HTMLBaseElement::removedFrom):

  • html/HTMLBaseElement.h:

(HTMLBaseElement):

  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::insertedInto):
(WebCore::HTMLBodyElement::didNotifyDescendantInseretions):

  • html/HTMLBodyElement.h:

(HTMLBodyElement):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::insertedInto):
(WebCore::HTMLFormControlElement::removedFrom):

  • html/HTMLFormControlElement.h:

(HTMLFormControlElement):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::insertedInto):
(WebCore::HTMLFormElement::didNotifyDescendantInseretions):
(WebCore::HTMLFormElement::removedFrom):

  • html/HTMLFormElement.h:

(HTMLFormElement):

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::insertedInto):
(WebCore):
(WebCore::HTMLFrameElementBase::didNotifyDescendantInseretions):

  • html/HTMLFrameElementBase.h:

(HTMLFrameElementBase):

  • html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::insertedInto):
(WebCore::HTMLFrameSetElement::removedFrom):

  • html/HTMLFrameSetElement.h:

(HTMLFrameSetElement):

  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::insertedInto):
(WebCore::HTMLIFrameElement::removedFrom):

  • html/HTMLIFrameElement.h:

(HTMLIFrameElement):

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::insertedInto):
(WebCore::HTMLImageElement::removedFrom):

  • html/HTMLImageElement.h:

(HTMLImageElement):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::insertedInto):
(WebCore::HTMLInputElement::removedFrom):

  • html/HTMLInputElement.h:
  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::insertedInto):
(WebCore::HTMLLinkElement::removedFrom):

  • html/HTMLLinkElement.h:

(HTMLLinkElement):

  • html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::insertedInto):
(WebCore::HTMLMapElement::removedFrom):

  • html/HTMLMapElement.h:

(HTMLMapElement):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::insertedInto):
(WebCore::HTMLMediaElement::removedFrom):

  • html/HTMLMediaElement.h:

(HTMLMediaElement):

  • html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::insertedInto):

  • html/HTMLMetaElement.h:

(HTMLMetaElement):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::insertedInto):
(WebCore::HTMLObjectElement::removedFrom):

  • html/HTMLObjectElement.h:

(HTMLObjectElement):

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::insertedInto):

  • html/HTMLOptionElement.h:

(HTMLOptionElement):

  • html/HTMLQuoteElement.cpp:

(WebCore::HTMLQuoteElement::insertedInto):

  • html/HTMLQuoteElement.h:

(HTMLQuoteElement):

  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::insertedInto):

  • html/HTMLScriptElement.h:

(HTMLScriptElement):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::insertedInto):

  • html/HTMLSelectElement.h:
  • html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::insertedInto):

  • html/HTMLSourceElement.h:

(HTMLSourceElement):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::insertedInto):
(WebCore::HTMLStyleElement::removedFrom):

  • html/HTMLStyleElement.h:

(HTMLStyleElement):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::insertedInto):

  • html/HTMLTextFormControlElement.h:
  • html/HTMLTitleElement.cpp:

(WebCore::HTMLTitleElement::insertedInto):
(WebCore::HTMLTitleElement::removedFrom):

  • html/HTMLTitleElement.h:

(HTMLTitleElement):

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::insertedInto):

  • html/HTMLTrackElement.h:

(HTMLTrackElement):

  • mathml/MathMLMathElement.cpp:

(WebCore::MathMLMathElement::insertedInto):

  • mathml/MathMLMathElement.h:

(MathMLMathElement):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::removedFrom):

  • svg/SVGElement.h:

(SVGElement):

  • svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::insertedInto):
(WebCore::SVGFEImageElement::removedFrom):

  • svg/SVGFEImageElement.h:

(SVGFEImageElement):

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::insertedInto):
(WebCore::SVGFontFaceElement::removedFrom):

  • svg/SVGFontFaceElement.h:

(SVGFontFaceElement):

  • svg/SVGFontFaceUriElement.cpp:

(WebCore::SVGFontFaceUriElement::insertedInto):

  • svg/SVGFontFaceUriElement.h:

(SVGFontFaceUriElement):

  • svg/SVGGlyphElement.cpp:

(WebCore::SVGGlyphElement::insertedInto):
(WebCore::SVGGlyphElement::removedFrom):

  • svg/SVGGlyphElement.h:

(SVGGlyphElement):

  • svg/SVGHKernElement.cpp:

(WebCore::SVGHKernElement::insertedInto):
(WebCore::SVGHKernElement::removedFrom):

  • svg/SVGHKernElement.h:

(SVGHKernElement):

  • svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::insertedInto):

  • svg/SVGImageElement.h:

(SVGImageElement):

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::insertedInto):
(WebCore::SVGSVGElement::removedFrom):

  • svg/SVGSVGElement.h:

(SVGSVGElement):

  • svg/SVGScriptElement.cpp:

(WebCore::SVGScriptElement::insertedInto):

  • svg/SVGScriptElement.h:

(SVGScriptElement):

  • svg/SVGStyleElement.cpp:

(WebCore::SVGStyleElement::insertedInto):
(WebCore::SVGStyleElement::removedFrom):

  • svg/SVGStyleElement.h:

(SVGStyleElement):

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::insertedInto):
(WebCore::SVGStyledElement::removedFrom):
(WebCore::SVGStyledElement::updateRelativeLengthsInformation):

  • svg/SVGStyledElement.h:

(SVGStyledElement):

  • svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::buildPendingResource):
(WebCore::SVGTRefElement::insertedInto):
(WebCore::SVGTRefElement::removedFrom):

  • svg/SVGTRefElement.h:

(SVGTRefElement):

  • svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::insertedInto):

  • svg/SVGTextPathElement.h:
  • svg/SVGTitleElement.cpp:

(WebCore::SVGTitleElement::insertedInto):
(WebCore::SVGTitleElement::removedFrom):

  • svg/SVGTitleElement.h:

(SVGTitleElement):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::insertedInto):
(WebCore::SVGUseElement::removedFrom):

  • svg/SVGUseElement.h:

(SVGUseElement):

  • svg/SVGVKernElement.cpp:

(WebCore::SVGVKernElement::insertedInto):
(WebCore::SVGVKernElement::removedFrom):

  • svg/SVGVKernElement.h:

(SVGVKernElement):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::insertedInto):
(WebCore::SVGSMILElement::removedFrom):

  • svg/animation/SVGSMILElement.h:

(SVGSMILElement):

23:26 Changeset [114350] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Stack overflow in CSS parser caused by recursive stylesheet import
https://bugs.webkit.org/show_bug.cgi?id=83545

Patch by David Barr <davidbarr@chromium.org> on 2012-04-16
Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: http/tests/css/css-imports-redirect-cycle.html

  • css/CSSImportRule.cpp:

(WebCore::StyleRuleImport::requestStyleSheet):

LayoutTests:

  • http/tests/css/css-imports-redirect-cycle-expected.txt: Added.
  • http/tests/css/css-imports-redirect-cycle.css: Added.
  • http/tests/css/css-imports-redirect-cycle.html: Added.
23:22 Changeset [114349] by lforschler@apple.com
  • 5 edits in branches/safari-534.57-branch/Source

Versioning.

23:11 Changeset [114348] by tkent@chromium.org
  • 2 edits in trunk/Source/Platform

[Chromium] Fix Chromium-Mac build
https://bugs.webkit.org/show_bug.cgi?id=80054

  • chromium/public/WebFilterOperations.h:

(WebKit): WebFilterOperation is a struct, not a class.

22:57 Changeset [114347] by tkent@chromium.org
  • 5 edits
    1 move in trunk/Source

Rename LocalizedNumberICU.h to ICULocale.h
https://bugs.webkit.org/show_bug.cgi?id=84119

Reviewed by Kentaro Hara.

Source/WebCore:

LocalizedNumberICU.h contains only ICULocale class. It should be
named as ICULocale.h. We're going to move some functions in
LocalizedDateICU.cpp and LocalizedCalendarICU.cpp to ICULocale,
and add unit tests for them.

  • WebCore.gypi: Rename LocalizedNumberICU.h to ICULocale.h
  • platform/text/ICULocale.h:

Renamed from Source/WebCore/platform/text/LocalizedNumberICU.h.

  • platform/text/LocalizedNumberICU.cpp:

Rename LocalizedNumberICU.h to ICULocale.h

Source/WebKit/chromium:

  • tests/LocalizedNumberICUTest.cpp: Rename LocalizedNumberICU.h to ICULocale.h
22:49 Changeset [114346] by toyoshim@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, skip one more worker WebSocket test.
https://bugs.webkit.org/show_bug.cgi?id=84125

  • platform/chromium/test_expectations.txt:
22:46 Changeset [114345] by ryuan.choi@samsung.com
  • 1 edit
    2 adds in trunk/Source/WebKit2

[EFL][WK2] Add missing files to build webkit2/Efl.
https://bugs.webkit.org/show_bug.cgi?id=76139

Reviewed by Ryosuke Niwa.

Add missing files needed to build webkit2/Efl.

  • Shared/efl/PlatformCertificateInfo.h: Added.

(WebKit):
(PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::encode):
(WebKit::PlatformCertificateInfo::decode):

  • UIProcess/Launcher/efl/ThreadLauncherEfl.cpp: Added.

(WebKit):
(WebKit::ThreadLauncher::createWebThread):

22:36 Changeset [114344] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[chromium] Move paintRenderedResultsToCanvas code into DrawingBuffer
https://bugs.webkit.org/show_bug.cgi?id=84066

Patch by James Robinson <jamesr@chromium.org> on 2012-04-16
Reviewed by Adrienne Walker.

WebGLLayerChromium used to be responsible for the readback path for software painting WebGL canvases (for
printing, etc), but this path no longer has any compositor interaction. This moves the code into
DrawingBufferChromium which is responsible for managing the front / back buffers for WebGL.

  • platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):

  • platform/graphics/chromium/WebGLLayerChromium.cpp:
  • platform/graphics/chromium/WebGLLayerChromium.h:

(WebGLLayerChromium):

22:28 Changeset [114343] by danakj@chromium.org
  • 8 edits
    4 adds in trunk/Source

[chromium] Expose compositor filters to Aura through WebLayer
https://bugs.webkit.org/show_bug.cgi?id=80054

Reviewed by James Robinson.

Source/Platform:

  • chromium/public/WebFilterOperation.h: Added.

(WebKit):
(WebFilterOperation):
(WebKit::WebFilterOperation::WebFilterOperation):
(WebBasicColorMatrixFilterOperation):
(WebKit::WebBasicColorMatrixFilterOperation::WebBasicColorMatrixFilterOperation):
(WebBasicComponentTransferFilterOperation):
(WebKit::WebBasicComponentTransferFilterOperation::WebBasicComponentTransferFilterOperation):
(WebBlurFilterOperation):
(WebKit::WebBlurFilterOperation::WebBlurFilterOperation):
(WebDropShadowFilterOperation):
(WebKit::WebDropShadowFilterOperation::WebDropShadowFilterOperation):

  • chromium/public/WebFilterOperations.h: Added.

(WebKit):
(WebFilterOperations):

  • chromium/public/WebLayer.h:

(WebKit):
(WebLayer):

Source/WebCore:

Adds WebFilterOperation that wraps WebCore::FilterOperation and
WebFilterOperations that wraps WebCore::FilterOperations.

We add support for most of the FilterOperation subclasses, and
allow the user to set the WebFilterOperations for both layer
content filters and background filters.

  • WebCore.gypi:
  • platform/chromium/support/WebFilterOperation.cpp: Added.

(WebKit):
(WebKit::WebBasicColorMatrixFilterOperation::toFilterOperation):
(WebKit::WebBasicComponentTransferFilterOperation::toFilterOperation):
(WebKit::WebBlurFilterOperation::toFilterOperation):
(WebKit::WebDropShadowFilterOperation::toFilterOperation):

  • platform/chromium/support/WebFilterOperations.cpp: Added.

(WebKit):
(WebKit::WebFilterOperations::WebFilterOperations):
(WebKit::WebFilterOperations::append):
(WebKit::WebFilterOperations::clear):
(WebKit::WebFilterOperations::toFilterOperations):

Source/WebKit/chromium:

  • WebKit.gyp:
  • src/WebLayer.cpp:

(WebKit::WebLayer::setFilters):
(WebKit):
(WebKit::WebLayer::setBackgroundFilters):

22:08 Changeset [114342] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Auto-sized frames may be taller than expected
https://bugs.webkit.org/show_bug.cgi?id=84106

Patch by Andrei Burago <aburago@chromium.org> on 2012-04-16
Reviewed by David Levin.

No new tests. The repro steps require using Chrome notifications on Win.

  • page/FrameView.cpp:

(WebCore::FrameView::autoSizeIfEnabled):

22:08 Changeset [114341] by toyoshim@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed, remove invalid text expectation for Snow Leopard.

  • platform/chromium-mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.txt: Removed.
22:07 Changeset [114340] by lforschler@apple.com
  • 1 copy in tags/Safari-534.57.1

New tag.

21:32 Changeset [114339] by toyoshim@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed, remove useless text expectation for WinXP

  • platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.txt: Removed.
21:09 Changeset [114338] by toyoshim@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, skip a worker WebSocket test.
https://bugs.webkit.org/show_bug.cgi?id=84125

  • platform/chromium/test_expectations.txt:
20:58 Changeset [114337] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-16

  • DEPS:
20:42 Changeset [114336] by tkent@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

[Chromium] Move popup location detection code from WebViewImpl to WebPagePopupImpl
https://bugs.webkit.org/show_bug.cgi?id=84116

Reviewed by Kentaro Hara.

This makes no behavior change. Just move some code.
To fix Bug 84007, WebPagePopupImpl needs to know if the popup is
above the target element or below the target element.

  • src/WebPagePopupImpl.cpp:

(WebKit::WebPagePopupImpl::init): Move some code from WebViewImpl::openPagePopup().

  • src/WebPagePopupImpl.h:

(WebPagePopupImpl): Rename an argument name.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::openPagePopup): Move some code to WebPagePopupImpl::init().

20:38 April 2012 Meeting edited by rniwa@webkit.org
(diff)
20:04 Changeset [114335] by jamesr@google.com
  • 16 edits
    2 copies
    1 move in trunk/Source

[chromium] Expose WebVideoLayer to Platform API and port WebMediaPlayerClientImpl to using it
https://bugs.webkit.org/show_bug.cgi?id=83963

Reviewed by Adrienne Walker.

Source/Platform:

Adds a compositor layer type for video, WebVideoLayer, and a WebVideoProvider interface.

  • Platform.gypi:
  • chromium/public/WebContentLayer.h:

(WebContentLayer):

  • chromium/public/WebLayer.h:

(WebLayer):
(WebKit::WebLayer::unwrap):

  • chromium/public/WebVideoFrameProvider.h: Renamed from Source/WebCore/platform/graphics/chromium/VideoFrameProvider.h.

(WebKit):
(WebVideoFrameProvider):
(WebKit::WebVideoFrameProvider::~WebVideoFrameProvider):
(Client):

  • chromium/public/WebVideoLayer.h: Copied from Source/WebKit/chromium/src/WebContentLayer.cpp.

(WebCore):
(WebKit):
(WebVideoLayer):
(WebKit::WebVideoLayer::WebVideoLayer):
(WebKit::WebVideoLayer::~WebVideoLayer):

Source/WebCore:

Converts VideoLayerChromium / CCVideoLayerImpl to use a Platform WebVideoFrameProvider interface instead of a
WebCore VideoFrameProvider.

  • WebCore.gypi:
  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::create):
(WebCore::VideoLayerChromium::VideoLayerChromium):

  • platform/graphics/chromium/VideoLayerChromium.h:

(WebKit):
(WebCore):
(VideoLayerChromium):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::CCVideoLayerImpl):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:

(WebCore::CCVideoLayerImpl::create):
(CCVideoLayerImpl):

Source/WebKit/chromium:

Adds implementation of WebVideoLayer and ports WebMediaPlayerClientImpl over to using it.
WebMediaPlayerClientImpl still exposes a WebCore::VideoLayerChromium* to the compositor via the platformLayer()
interface, but this is temporary until we can change the PlatformLayer typedef over to WebLayer.

  • WebKit.gyp:
  • src/WebContentLayer.cpp:
  • src/WebLayer.cpp:

(WebKit::WebLayer::invalidate):
(WebKit):

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
(WebKit::WebMediaPlayerClientImpl::repaint):
(WebKit::WebMediaPlayerClientImpl::setOpaque):
(WebKit::WebMediaPlayerClientImpl::platformLayer):
(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
(WebKit::WebMediaPlayerClientImpl::setVideoFrameProviderClient):
(WebKit::WebMediaPlayerClientImpl::supportsType):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

  • src/WebVideoLayer.cpp: Copied from Source/WebKit/chromium/src/WebContentLayer.cpp.

(WebKit):
(WebKit::WebVideoLayer::create):
(WebKit::WebVideoLayer::WebVideoLayer):
(WebKit::WebVideoLayer::active):

19:55 Changeset [114334] by commit-queue@webkit.org
  • 6 edits in trunk

[Shadow DOM] InsertionPoint should have isActive() member function.
https://bugs.webkit.org/show_bug.cgi?id=82010

Patch by Takashi Sakamoto <tasak@google.com> on 2012-04-16
Reviewed by Hajime Morita.

This patch adds isActive public member function to InsertionPoint and
makes InsertionPoint elements consider whether active or not.
If an InsertionPoint is inactive, the element is not shadow boundary
and is needed to be rendered.
c.f. https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#dfn-active-insertion-point

Test: update existing tests, i.e.
LayoutTests/fast/dom/shadow/shadow-contents-fallback-dynamic.html and
LayoutTests/fast/dom/shadow/shadow-contents-fallback.html

  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::isActive):
A new public method for checking whether an insertion point is active or inactive.
If active, returns true. Otherwise, false.
(WebCore::InsertionPoint::isShadowBoundary):
Make the method consider whether an insertin point is active or inactive.
(WebCore::InsertionPoint::rendererIsNeeded):
Changed to return true If an insertion point is inactive.
(WebCore::InsertionPoint::attach):
Changed to call only HTMLElement::attach If an insertion point is inactive.
(WebCore::InsertionPoint::detach):
Changed to call only HTMLElement::detach If an insertion point is inactive.

  • html/shadow/InsertionPoint.h:

(InsertionPoint):
Added isActive public method.

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):
Changed to take into account an insertion point's activeness when parent is an insertion point.
(WebCore::NodeRenderingContext::firstRendererOf):
(WebCore::NodeRenderingContext::lastRendererOf):
Changed to take into account an insertion point's activeness.

19:33 April 2012 Meeting edited by rniwa@webkit.org
(diff)
19:15 Changeset [114333] by morrita@google.com
  • 3 edits in trunk/Source/WebCore

Type tags in NodeFlags could be compressed
https://bugs.webkit.org/show_bug.cgi?id=79299

Because existing node flags which indicate the class of each node
are mutually exclusive, these flags can be represented as a enum.
This patch introduces Node::NodeTypeTag to turn these flags into a
enum, and embeds it into Node::m_nodeFlags.

Reviewed by Antti Koivisto.

No new tests. No bahavior change.

  • dom/Node.cpp:

(WebCore):

  • dom/Node.h:

(WebCore):
(Node):
(WebCore::Node::typeTag):
(WebCore::Node::parentNode):
(WebCore::Node::parentNodeGuaranteedHostFree):
(WebCore::Node::isContainerNode):
(WebCore::Node::isElementNode):
(WebCore::Node::isStyledElement):
(WebCore::Node::isTextNode):
(WebCore::Node::isHTMLElement):
(WebCore::Node::isSVGElement):
(WebCore::Node::isShadowRoot):

19:02 Changeset [114332] by kov@webkit.org
  • 2 edits in trunk/Tools

[GTK] Use configure instead of autogen.sh for gtk+
https://bugs.webkit.org/show_bug.cgi?id=84112

Rubber-stamped by Martin Robinson.

  • gtk/jhbuild.modules: GTK+'s autogen requires gobject-introspection;

we don't want to depend on that for now, so run configure instead - we
can, since we are using a tarball

18:06 Changeset [114331] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore

Merging r110150

17:55 Changeset [114330] by commit-queue@webkit.org
  • 6 edits
    2 deletes in trunk

Unreviewed, rolling out r114285.
http://trac.webkit.org/changeset/114285
https://bugs.webkit.org/show_bug.cgi?id=84107

broke fast/media/media-query-list-08.html in Mac (Requested by
andersca on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-16

Source/WebCore:

  • dom/Document.cpp:

(WebCore::Document::styleSelectorChanged):

  • dom/Document.h:

(Document):

  • page/FrameView.cpp:

(WebCore::FrameView::layout):

LayoutTests:

  • fast/media/media-query-list-08-expected.txt: Removed.
  • fast/media/media-query-list-08.html: Removed.
  • platform/qt/Skipped:
17:48 Changeset [114329] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk/Source/WebKit/chromium

Fix WebKit style violations in Chromium WebMediaPlayer.h & WebMediaPlayerClient.h
https://bugs.webkit.org/show_bug.cgi?id=84046

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-04-16
Reviewed by Darin Fisher.

  • WebKit.gyp:
  • public/WebMediaPlayer.h:

(WebKit):

  • public/WebMediaPlayerClient.h:
  • public/WebTimeRange.h: Copied from Source/WebKit/chromium/public/WebMediaPlayerClient.h.

(WebKit):
(WebKit::WebTimeRange::WebTimeRange):
(WebTimeRange):

  • src/AssertMatchingEnums.cpp:
17:47 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
17:47 Changeset [114328] by japhet@chromium.org
  • 3 edits in trunk/Source/WebCore

Remove unused variable CachedResourceLoader::m_loadFinishing
https://bugs.webkit.org/show_bug.cgi?id=84100

Reviewed by Alexey Proskuryakov.

No new tests, removing dead code.

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::loadDone):
(WebCore::CachedResourceLoader::decrementRequestCount):

  • loader/cache/CachedResourceLoader.h:

(CachedResourceLoader):
(WebCore::CachedResourceLoader::requestCount):

17:35 Changeset [114327] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

Followup to http://trac.webkit.org/changeset/114323

For more correctness, actually include an autorelease pool instead of cleverly trying to avoid its use.

Reviewed by Mark Rowe.

  • PluginProcess/mac/PluginProcessMainMac.mm:

(WebKit::PluginProcessMain):

17:35 Changeset [114326] by kov@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r114322.
http://trac.webkit.org/changeset/114322
https://bugs.webkit.org/show_bug.cgi?id=84096

Didn't make the debug bot happy, so back out

  • gtk/jhbuild.modules:
17:28 Changeset [114325] by kling@webkit.org
  • 6 edits in trunk/Source/WebCore

Remove contextStyleSheet argument from CSSValuePool::createFontFaceValue().
<http://webkit.org/b/83988>

Reviewed by Antti Koivisto.

Remove the 'context style sheet' argument to <font face> value parsing.
It was only ever used to grab at the CSSValuePool back when they were per-Document.

  • css/CSSParser.h:
  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFontFaceValue):

  • css/CSSValuePool.h:
  • css/CSSValuePool.cpp:

(WebCore::CSSValuePool::createFontFaceValue):

  • html/HTMLFontElement.cpp:

(WebCore::HTMLFontElement::collectStyleForAttribute):

17:21 Changeset [114324] by danakj@chromium.org
  • 1 edit in trunk/Source/WebCore/ChangeLog

[chromium] Consistent checking for clipped rects when we need the computed result enclosed within the real result
https://bugs.webkit.org/show_bug.cgi?id=83543

Reviewed by Adrienne Walker.

It should not be possible to make a rect in layer space that is clipped
by the camera but for which the screen space transform gives a
rectilinear output. But use consistent methods for checking that the
result remains enclosed within the actual pixels.

One day when clipped is true, we can find an interior axis-aligned rect
within the clipped result, and checking clipped explicitly makes this
more clear.

Covered by existing tests.

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::computeOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):

17:21 Changeset [114323] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/11238965> Leak in Plugin Process when launched 32-bit

Reviewed by Jessie Berlin.

  • PluginProcess/mac/PluginProcessMainMac.mm:

(WebKit::PluginProcessMain): alloc/init an NSDictionary then release it, instead of leaking an autoreleased one.

17:18 Changeset [114322] by kov@webkit.org
  • 2 edits in trunk/Tools

[GTK] Try to fix debug bot by adding gobject-introspection to the build
https://bugs.webkit.org/show_bug.cgi?id=84096

Unreviewed speculative build fix.

  • gtk/jhbuild.modules: Added gobject-introspection, since modules need

an up-to-date introspection m4 for running autogen.

17:17 Changeset [114321] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

Add two flaky tests in fast/profiler.

  • platform/mac/Skipped:
16:53 Changeset [114320] by arv@chromium.org
  • 3 edits
    2 adds in trunk

[V8] Don't delete the per context data until the V8IsolatedContext is deleted
https://bugs.webkit.org/show_bug.cgi?id=83831

Reviewed by Nate Chapin.

Source/WebCore:

Test: http/tests/security/isolatedWorld/context-destroy.html

  • bindings/v8/V8IsolatedContext.cpp:

(WebCore::V8IsolatedContext::destroy):

LayoutTests:

  • http/tests/security/isolatedWorld/context-destroy-expected.txt: Added.
  • http/tests/security/isolatedWorld/context-destroy.html: Added.
16:50 Changeset [114319] by commit-queue@webkit.org
  • 12 edits in trunk/Source/WebCore

Add V8 code generation support for MessagePortArray attributes.
https://bugs.webkit.org/show_bug.cgi?id=83943

Patch by Greg Billock <gbillock@google.com> on 2012-04-16
Reviewed by Kentaro Hara.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):

  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:

(WebDOMTestSerializedScriptValueInterface::ports):

  • bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h:

(WebDOMTestSerializedScriptValueInterface):

  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:

(webkit_dom_test_serialized_script_value_interface_get_property):
(webkit_dom_test_serialized_script_value_interface_class_init):
(webkit_dom_test_serialized_script_value_interface_get_ports):

  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore):
(WebCore::jsTestSerializedScriptValueInterfacePorts):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h:
  • bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm:

(-[DOMTestSerializedScriptValueInterface ports]):

  • bindings/scripts/test/TestSerializedScriptValueInterface.idl:
  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceInternal::portsAttrGetter):
(TestSerializedScriptValueInterfaceInternal):
(WebCore):

16:45 Changeset [114318] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Marking test failing TEXT: css3/filters/custom/custom-filter-property-computed-style.html.

Unreviewed.

  • platform/chromium/test_expectations.txt:
16:37 Changeset [114317] by commit-queue@webkit.org
  • 17 edits in trunk

Unreviewed, rolling out r114309.
http://trac.webkit.org/changeset/114309
https://bugs.webkit.org/show_bug.cgi?id=84097

it broke everything (Requested by olliej on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-16

Source/JavaScriptCore:

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • bytecode/CodeBlock.h:
  • dfg/DFGOperations.cpp:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::throwException):

  • interpreter/Interpreter.h:

(Interpreter):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jsc.cpp:

(functionJSCStack):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::handleHostCall):

  • parser/Parser.h:

(JSC::::parse):

  • runtime/Error.cpp:

(JSC::addErrorInfo):
(JSC::throwError):

  • runtime/Error.h:

(JSC):

LayoutTests:

  • fast/js/exception-properties-expected.txt:
  • fast/js/script-tests/exception-properties.js:
  • fast/js/script-tests/stack-trace.js:

(selfRecursive1):

  • fast/js/stack-trace-expected.txt:
16:32 Changeset [114316] by xji@chromium.org
  • 2 edits in trunk/Source/WebCore

platform/graphics/skia/GlyphPageTreeNodeSkia.cpp mis-use 'continue' for 'break'
https://bugs.webkit.org/show_bug.cgi?id=83521

Reviewed by David Levin.

No functionality change, so no new tests.

  • platform/graphics/skia/GlyphPageTreeNodeSkia.cpp:

(WebCore::GlyphPage::fill):

16:24 Changeset [114315] by leviw@chromium.org
  • 9 edits in trunk/Source/WebCore

Make borderBoxRect sub-pixel precise and add a pixel snapped version
https://bugs.webkit.org/show_bug.cgi?id=84063

Reviewed by Eric Seidel.

In an effort to prevent misuse, we previously decided to have borderBoxRect return a
pixel-snapped IntRect. This is because borderBoxRect returns a rect that's positioned
at (0,0), and therefore won't snap to the same size as the element it's covering.

There are a couple uses of borderBoxRect that don't pixel snap the values and require
sub-pixel precision. This patch adds a pixelSnappedBorderBoxRect that makes the snapping
explicit, and moves uses that would otherwise pixel snap the rect to this version to
avoid producing a rect of the incorrect size. For details about pixel snapping with
LayoutUnits, please see https://trac.webkit.org/wiki/LayoutUnit

No new tests. No change in behavior.

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::SpinButtonElement::defaultEventHandler):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addVisualOverflowFromTheme):

  • rendering/RenderBox.h:

(WebCore::RenderBox::borderBoxRect):
(WebCore::RenderBox::pixelSnappedBorderBoxRect):
(WebCore::RenderBox::borderBoundingBox):
(WebCore::RenderBox::hasVisualOverflow):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollCornerRect):
(WebCore::RenderLayer::scrollCornerAndResizerRect):
(WebCore::RenderLayer::horizontalScrollbarStart):
(WebCore::RenderLayer::positionOverflowControls):
(WebCore::RenderLayer::paintResizer):
(WebCore::RenderLayer::hitTestOverflowControls):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::startTransition):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::addOverflowFromChildren):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeMac::paintSearchFieldResultsButton):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::paintReplaced):
(WebCore::RenderSVGRoot::computeFloatRectForRepaint):

16:19 Changeset [114314] by scheib@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

[Chromium] Rebaseline continued from xji's rebase after r114267.

Unreviewed.

  • platform/chromium-win-xp/fast/text/international/arabic-justify-expected.png: Added.
16:10 Changeset [114313] by tomz@codeaurora.org
  • 6 edits
    11 adds
    11 deletes in trunk/LayoutTests

Unreviewed gardening for ietestcenter/grid. Adding reference tests
and removing gtk expected.txt

Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-04-16

  • ietestcenter/css3/grid/display-grid-001-expected.htm: Added.
  • ietestcenter/css3/grid/display-grid-002-expected.htm: Added.
  • ietestcenter/css3/grid/grid-column-001-expected.htm: Added.
  • ietestcenter/css3/grid/grid-column-002-expected.htm: Added.
  • ietestcenter/css3/grid/grid-column-003-expected.htm: Added.
  • ietestcenter/css3/grid/grid-columns-001-expected.htm: Added.
  • ietestcenter/css3/grid/grid-items-001-expected.htm: Added.
  • ietestcenter/css3/grid/grid-items-002-expected.htm: Added.
  • ietestcenter/css3/grid/grid-items-003-expected.htm: Added.
  • ietestcenter/css3/grid/grid-items-004-expected.htm: Added.
  • ietestcenter/css3/grid/grid-items-005-expected.htm: Added.
  • platform/chromium/test_expectations.txt:
  • platform/efl/test_expectations.txt:
  • platform/gtk/ietestcenter/css3/grid/display-grid-001-expected.txt: Removed.
  • platform/gtk/ietestcenter/css3/grid/display-grid-002-expected.txt: Removed.
  • platform/gtk/ietestcenter/css3/grid/grid-column-001-expected.txt: Removed.
  • platform/gtk/ietestcenter/css3/grid/grid-column-002-expected.txt: Removed.
  • platform/gtk/ietestcenter/css3/grid/grid-column-003-expected.txt: Removed.
  • platform/gtk/ietestcenter/css3/grid/grid-columns-001-expected.txt: Removed.
  • platform/gtk/ietestcenter/css3/grid/grid-items-001-expected.txt: Removed.
  • platform/gtk/ietestcenter/css3/grid/grid-items-002-expected.txt: Removed.
  • platform/gtk/ietestcenter/css3/grid/grid-items-003-expected.txt: Removed.
  • platform/gtk/ietestcenter/css3/grid/grid-items-004-expected.txt: Removed.
  • platform/gtk/ietestcenter/css3/grid/grid-items-005-expected.txt: Removed.
  • platform/gtk/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
15:54 Changeset [114312] by kov@webkit.org
  • 2 edits in trunk/Tools

[GTK] Add pango to jhbuild
https://bugs.webkit.org/show_bug.cgi?id=84086

Unreviewed build fix.

  • gtk/jhbuild.modules: Add pango's latest stable release, 1.30, to our

jhbuild environment. It's required for latest stable GTK+ and some
systems may lack it.

15:50 Changeset [114311] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Crash when running some editing related tests
https://bugs.webkit.org/show_bug.cgi?id=84091

Reviewed by Andreas Kling.

Null check triggeringEvent.

  • editing/Editor.cpp:

(WebCore::Editor::insertTextWithoutSendingTextEvent):

15:27 Changeset [114310] by leviw@chromium.org
  • 15 edits in branches/subpixellayout

Reverting unnecessary changes to RenderRubyRun, and applying the patch from webkit.org/b/84063.

15:26 Changeset [114309] by oliver@apple.com
  • 17 edits in trunk

Exception stack traces aren't complete when the exception starts in native code
https://bugs.webkit.org/show_bug.cgi?id=84073

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Refactored building the stack trace to so that we can construct
it earlier, and don't rely on any prior work performed in the
exception handling machinery. Also updated LLInt and the DFG to
completely initialise the callframes of host function calls.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::codeOriginIndexForReturn):
(CodeBlock):

  • dfg/DFGOperations.cpp:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::addStackTraceIfNecessary):
(JSC):
(JSC::Interpreter::throwException):

  • interpreter/Interpreter.h:

(Interpreter):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jsc.cpp:

(functionJSCStack):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::handleHostCall):

  • parser/Parser.h:

(JSC::::parse):

  • runtime/Error.cpp:

(JSC::addErrorInfo):
(JSC::throwError):

  • runtime/Error.h:

(JSC):

LayoutTests:

Update tests to include new exception property ordering, and new functions

  • fast/js/exception-properties-expected.txt:
  • fast/js/script-tests/exception-properties.js:
  • fast/js/script-tests/stack-trace.js:

(selfRecursive1): Modified slightly so that we produce consistent traces

  • fast/js/stack-trace-expected.txt:
15:25 Changeset [114308] by kov@webkit.org
  • 2 edits in trunk/Tools

[GTK] fonts jhbuild module needs an empty clean target
https://bugs.webkit.org/show_bug.cgi?id=84085

Rubber-stamped by Martin Robinson.

  • gtk/jhbuild.modules: update to webkitgtk-test-fonts 0.0.2, which

includes a phony clean target that should make warnings and errors go
away.

15:19 Changeset [114307] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit/mac

Use a MIG call when creating a plug-in property list file
https://bugs.webkit.org/show_bug.cgi?id=84084
<rdar://problem/11197341>

Reviewed by Sam Weinig.

  • Plugins/Hosted/NetscapePluginHostManager.mm:

(WebKit::NetscapePluginHostManager::createPropertyListFile):
Get a plug-in host and call _WKPHCreatePluginMIMETypesPreferences instead.

  • Plugins/Hosted/WebKitPluginHost.defs:

Add PHCreatePluginMIMETypesPreferences.

  • Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage createPropertyListFile]):
NetscapePluginHostManager::createPropertyListFile is no longer a static member function.

15:14 Changeset [114306] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Update test_expectations for chromium
https://bugs.webkit.org/show_bug.cgi?id=83965

Patch by David Alcala <dalcala@adobe.com> on 2012-04-16
Reviewed by Dirk Schulze.

  • platform/chromium/test_expectations.txt:
15:09 Changeset [114305] by scheib@chromium.org
  • 3 edits in trunk/LayoutTests

[Chromium] Rebasing pixel tests for composited-document-element, tiny text difference.

Unreviewed.

  • platform/chromium-mac-snowleopard/compositing/repaint/composited-document-element-expected.png:
  • platform/chromium-mac/compositing/repaint/composited-document-element-expected.png:
15:05 Changeset [114304] by commit-queue@webkit.org
  • 2 edits in trunk

Re-add GPU DEPS builders to flakiness dashboard.
https://bugs.webkit.org/show_bug.cgi?id=84056

Patch by Dave Tu <dtu@chromium.org> on 2012-04-16
Reviewed by Ojan Vafai.

  • Tools/TestResultServer/static-dashboards/builders.js:
15:05 Changeset [114303] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Supressing test errors introduced by http://trac.webkit.org/changeset/114283.

Unreviewed.

  • platform/chromium/test_expectations.txt:
15:02 Changeset [114302] by simon.fraser@apple.com
  • 3 edits in trunk/Source/WebCore

Rename to updateZOrderListsSlowCase to rebuildZOrderLists
https://bugs.webkit.org/show_bug.cgi?id=84071

Reviewed by Antti Koivisto.

Use a better name for updateZOrderListsSlowCase().

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::rebuildZOrderLists):

  • rendering/RenderLayer.h:

(RenderLayer):
(WebCore::RenderLayer::updateZOrderLists):

14:50 Changeset [114301] by commit-queue@webkit.org
  • 6 edits in trunk/Source

[chromium] Allow WebGestureEvent to store four floating point values
https://bugs.webkit.org/show_bug.cgi?id=84053

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-04-16
Reviewed by Darin Fisher.

See bug description for an explanation of the changes made.

Source/WebCore:

  • platform/PlatformGestureEvent.h:

(WebCore::PlatformGestureEvent::PlatformGestureEvent):
(PlatformGestureEvent):
(WebCore::PlatformGestureEvent::gammaX):
(WebCore::PlatformGestureEvent::gammaY):

Source/WebKit/chromium:

  • public/WebInputEvent.h:

(WebGestureEvent):
(WebKit::WebGestureEvent::WebGestureEvent):

  • src/WebInputEvent.cpp:

(SameSizeAsWebGestureEvent):

  • src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

14:44 Changeset [114300] by schenney@chromium.org
  • 4 edits
    1 add
    1 delete in trunk/LayoutTests

[Chromium] Flaky layout test LayoutTests/svg/hixie/error/012.xml
https://bugs.webkit.org/show_bug.cgi?id=84082

Unreviewed Chromium test expectations update.

Results look right but the test maybe flaky.

  • platform/chromium-mac-leopard/svg/hixie/error/012-expected.png:
  • platform/chromium-mac-leopard/svg/hixie/error/012-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/hixie/error/012-expected.png:
  • platform/chromium-mac/svg/hixie/error/012-expected.png: Added.
  • platform/chromium/test_expectations.txt:
14:33 Changeset [114299] by schenney@chromium.org
  • 12 edits
    3 deletes in trunk/LayoutTests

[Chromium] Rebaseline now that SK_IGNORE_HAIRLINE_CLIP_FIX is undefined
https://bugs.webkit.org/show_bug.cgi?id=84075

Unreviewed Chromium expectations update.

  • platform/chromium-linux-x86/svg/as-image: Removed.
  • platform/chromium-linux-x86/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Removed.
  • platform/chromium-linux/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
  • platform/chromium-linux/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac-leopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac-snowleopard/svg/hixie/perf/001-expected.png:
  • platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.png: Modified property svn:mime-type.
  • platform/chromium-mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
  • platform/chromium-mac/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-win/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
  • platform/chromium/test_expectations.txt:
  • svg/hixie/perf/001-expected.txt: Removed.
  • svg/hixie/perf/002-expected.txt: Removed.
14:19 Changeset [114298] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[Refactoring][V8] Remove $indent from NativeToJSValue()
https://bugs.webkit.org/show_bug.cgi?id=84077

Reviewed by Nate Chapin.

$indent in NativeToJSValue() in CodeGeneratorV8.pm is not used.
This patch removes it.

No new tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateFunctionCallString):
(NativeToJSValue):

14:19 Changeset [114297] by kov@webkit.org
  • 4 edits
    1 delete in trunk

[GTK] Bump dependency on GTK+ 3.x to match reality
https://bugs.webkit.org/show_bug.cgi?id=84060

Rubber-stamped by Martin Robinson.

.:

  • configure.ac: Bump GTK+ 3 requirement to 3.4.0. In practice we

already depend on this version because of our dependency on a recent
glib, which causes linking issues with older GTK+; also bump glib to
its earliest version.

Tools:

  • gtk/jhbuild.modules: Bump GTK+ to 3.4.0, plus glib and gdk-pixbuf

to their GNOME 3.4 versions.

  • gtk/patches/gtk+-3.0.12-gtkprinter.patch: Removed. This patch

is applied upstream.

14:02 Changeset [114296] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Marking failing test platform/chromium/compositing/filters/background-filter-blur-outsets.html.

Unreviewed.

  • platform/chromium/test_expectations.txt:
14:02 Changeset [114295] by andersca@apple.com
  • 8 edits in trunk/Source/WebKit2

Nightly Back/Forward no longer calls plug-in's NPP_NewStream
https://bugs.webkit.org/show_bug.cgi?id=83805
<rdar://problem/11238748>

Reviewed by Simon Fraser.

When a page with a full-frame plug-in is restored from the page cache, it needs to re-fetch the plug-in stream.

Fix this by breaking the assumption that a plug-in will always get its data from WebCore if it's a full-frame plug-in;
instead it only get its data from WebCore if it's a full-frame plug-in that's not being restored from the page cache.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):
Rename m_loadManually to m_shouldUseManualLoader.

(WebKit::NetscapePlugin::initialize):
Get the mode from parameters.isFullFramePlugin instead.

(WebKit::NetscapePlugin::manualStreamDidReceiveResponse):
(WebKit::NetscapePlugin::manualStreamDidReceiveData):
(WebKit::NetscapePlugin::manualStreamDidFinishLoading):
(WebKit::NetscapePlugin::manualStreamDidFail):
Rename m_loadManually to m_shouldUseManualLoader.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

Rename m_loadManually to m_shouldUseManualLoader.

  • WebProcess/Plugins/Plugin.cpp:

(WebKit::Plugin::Parameters::encode):
(WebKit::Plugin::Parameters::decode):

  • WebProcess/Plugins/Plugin.h:

(Parameters):
Add an extra isFullFramePlugin parameter, and rename loadManually to shouldUseManualLoader.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::WebFrameLoaderClient):
Initialize m_frameCameFromPageCache.

(WebKit::WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
Set m_frameCameFromPageCache to true.

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
Set m_frameCameFromPageCache to false.

(WebKit::WebFrameLoaderClient::createPlugin):
Initialize isFullFramePlugin and shouldUseManualLoader.

13:57 Changeset [114294] by schenney@chromium.org
  • 3 edits
    2 adds in trunk/LayoutTests

[Chromium] Rebaseline svg/filters/sourceAlpha.svg on mac
https://bugs.webkit.org/show_bug.cgi?id=84069

Unreviewed Chromium test expectations update.

Finally closing out an expectations update from 2009.

  • platform/chromium-mac-leopard/svg/filters/sourceAlpha-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/sourceAlpha-expected.png:
  • platform/chromium-mac/svg/filters/sourceAlpha-expected.png: Added.
  • platform/chromium/test_expectations.txt:
13:32 Changeset [114293] by schenney@chromium.org
  • 3 edits
    10 adds
    10 deletes in trunk/LayoutTests

[Chromium] Layout test svg/filters/shadow-on-rect-with-filter.svg fails
https://bugs.webkit.org/show_bug.cgi?id=84064

Unreviewed Chromium expectations update.

One of these results, for svg/filters/filter-source-position.svg, is
incorrect, but it should be updated regardless.

  • platform/chromium-linux-x86/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
  • platform/chromium-linux/svg/filters/filter-clip-expected.png: Added.
  • platform/chromium-linux/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
  • platform/chromium-win-vista/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
  • platform/chromium-win-xp/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
  • platform/chromium-win/svg/filters/filter-clip-expected.png: Added.
  • platform/chromium-win/svg/filters/filter-source-position-expected.png: Added.
  • platform/chromium-win/svg/filters/shadow-on-rect-with-filter-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/efl/svg/filters/filter-source-position-expected.png: Removed.
  • platform/efl/svg/filters/filter-source-position-expected.txt: Removed.
  • platform/efl/svg/filters/shadow-on-rect-with-filter-expected.txt: Removed.
  • platform/gtk/svg/filters/filter-source-position-expected.png: Removed.
  • platform/gtk/svg/filters/filter-source-position-expected.txt: Removed.
  • platform/gtk/svg/filters/shadow-on-rect-with-filter-expected.txt: Removed.
  • platform/mac/svg/filters/filter-source-position-expected.txt: Removed.
  • platform/mac/svg/filters/shadow-on-rect-with-filter-expected.txt: Removed.
  • platform/qt/svg/filters/filter-source-position-expected.txt: Removed.
  • platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt: Removed.
  • svg/filters/filter-source-position-expected.png: Added.
  • svg/filters/filter-source-position-expected.txt: Added.
  • svg/filters/shadow-on-rect-with-filter-expected.txt: Added.
13:26 Changeset [114292] by scheib@chromium.org
  • 3 edits in trunk/LayoutTests

[Chromium] Rebaselining minor text difference in compositing/geometry/fixed-position-composited-page-scale-down.

Unreviewed.

  • platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
  • platform/chromium-mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
13:14 Changeset [114291] by ap@apple.com
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Remove BlobRegistryProxy::createResourceHandle
https://bugs.webkit.org/show_bug.cgi?id=84047

Reviewed by Nate Chapin.

  • src/BlobRegistryProxy.h: (BlobRegistryProxy::createResourceHandle): This function

is no longer used.

13:08 Changeset [114290] by commit-queue@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

RenderImage ignores its percent width/height when setContainerSizeForRenderer
https://bugs.webkit.org/show_bug.cgi?id=80431

Add a test case for Bug 80431. It renders a 1x1 svg as an image with percent
width/height specified.

Patch by Yong Li <yoli@rim.com> on 2012-04-16
Reviewed by Nikolas Zimmermann.

  • svg/as-image/resources/rect-1x1.svg: Added.
  • svg/as-image/svg-as-image-with-relative-size-expected.html: Added.
  • svg/as-image/svg-as-image-with-relative-size.html: Added.
13:05 Changeset [114289] by scheib@chromium.org
  • 3 edits in trunk/LayoutTests

Reverting shader-precision-format.html reftest fix - it only fixed some DBG builders. Marking test failing for those.

Unreviewed.

  • fast/canvas/webgl/shader-precision-format-expected.txt:
  • platform/chromium/test_expectations.txt:
13:00 Changeset [114288] by tonikitoo@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

2012-04-16 Antonio Gomes <agomes@rim.com>

Screen shift down when VKB shows by clicking in a input box MKS_3601371
PR #149846

Reviewed by Rob Buis.

After switching from ScrollView::canOverscroll to ScrollView::constrainsScrollingToContentEdge
we had a less restricted code path allowing/disallowing overscrolling. That caused
some webpages like google.com to get on overscroll when adjusting the scroll
position to ensure the focused input field is visible.

Patch restricts the way we allow overscrolling to the bottom, where the virtual
keyboard pops up from, clamping it to 0, 0 if it tries to
overscroll upwards, and to maximum scroll position if it overscrolls
downwards.

Internally reviewed by Mike Fenton.
PR #149846

  • WebKitSupport/InputHandler.cpp: (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
12:34 Changeset [114287] by xji@chromium.org
  • 3 edits
    7 adds in trunk/LayoutTests

Rebaseline after r114267.

  • platform/chromium-linux/fast/text/international/arabic-justify-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/international/arabic-justify-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/international/arabic-justify-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/arabic-justify-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/arabic-justify-expected.txt: Added.
  • platform/chromium-mac/fast/text/international/arabic-justify-expected.png: Added.
  • platform/chromium-mac/fast/text/international/arabic-justify-expected.txt: Added.
  • platform/chromium-win/fast/text/international/arabic-justify-expected.png:
  • platform/chromium/test_expectations.txt:
11:52 Changeset [114286] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

EndPrinting message should be sent synchronously when printing was initiated from DOM.
https://bugs.webkit.org/show_bug.cgi?id=84049
<rdar://problem/11096575>

Reviewed by Oliver Hunt.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::printFrame): When printing is initiated by WebProcess, all messages from UI process are sent synchronously to avoid being queued, and so should EndPrinting.
11:45 Changeset [114285] by antti@apple.com
  • 6 edits
    2 adds in trunk

matchMedia() MediaQueryList not updating
https://bugs.webkit.org/show_bug.cgi?id=75903

Patch by Luiz Agostini <luiz.agostini@palm.com> on 2012-04-16
Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/media/media-query-list-08.html

Viewport related MediaQueryList listeners were not triggered and the value
of matches were not updated if the document's style selector were not
affected by viewport changes.

The new method evaluateMediaQueries() is now called by FrameView instead of
styleSelectorChanged() if the style selector is not affected by viewport changes.

  • dom/Document.cpp:

(WebCore::Document::evaluateMediaQueries):
(WebCore):
(WebCore::Document::styleSelectorChanged):

  • dom/Document.h:

(Document):

  • page/FrameView.cpp:

(WebCore::FrameView::layout):

LayoutTests:

Testing MediaQueryLists listeners related to viewport changes.

  • fast/media/media-query-list-08-expected.txt: Added.
  • fast/media/media-query-list-08.html: Added.

Skipping the new test in Qt due to an issue in its DumpRenderTree.

  • platform/qt/Skipped:
11:41 Changeset [114284] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[chromium] Delete uncalled unreserveContentsTextures function
https://bugs.webkit.org/show_bug.cgi?id=84005

Patch by James Robinson <jamesr@chromium.org> on 2012-04-16
Reviewed by Adrienne Walker.

This is vestigal dead code.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:
  • platform/graphics/chromium/Canvas2DLayerChromium.h:

(Canvas2DLayerChromium):

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):

11:32 Changeset [114283] by simon.fraser@apple.com
  • 14 edits
    7 adds in trunk

Avoid using backing store for compositing layers that just need to clip
https://bugs.webkit.org/show_bug.cgi?id=40547

Source/WebCore:

Reviewed by Dean Jackson.

If a layer becomes composited because it needs to clip composited
descendants, or if it has perspective, then it doesn't actually
needs its own backing store; its contents can be painted by an
ancestor, and we can just have an empty layer that does the clipping
or applies the perspective transform.

This saves backing store memory on some pages.

Tests: compositing/backing/no-backing-for-clip-overlap.html

compositing/backing/no-backing-for-clip.html
compositing/backing/no-backing-for-perspective.html

  • rendering/RenderLayer.cpp:

(WebCore):
(WebCore::RenderLayer::enclosingCompositingLayerForRepaint):
(WebCore::RenderLayer::paintLayer):

  • rendering/RenderLayer.h:

(RenderLayer):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::RenderLayerBacking):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::containsPaintedContent):
(WebCore::RenderLayerBacking::setContentsNeedDisplay):
(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
(WebCore::RenderLayerBacking::paintIntoLayer):

  • rendering/RenderLayerBacking.h:

(RenderLayerBacking):
(WebCore::RenderLayerBacking::paintsIntoCompositedAncestor):
(WebCore::RenderLayerBacking::setRequiresOwnBackingStore):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::layerWillBeRemoved):
(WebCore::RenderLayerCompositor::recursiveRepaintLayerRect):
(WebCore::RenderLayerCompositor::requiresCompositingLayer):
(WebCore::RenderLayerCompositor::requiresOwnBackingStore):
(WebCore):

  • rendering/RenderLayerCompositor.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::containerForRepaint):

  • rendering/RenderTreeAsText.cpp:

(WebCore::write):

  • rendering/RenderView.cpp:

(WebCore::RenderView::paintBoxDecorations):

LayoutTests:

Reviewed by Dean Jackson.

New tests for backing store elimination with clip or perspective.

New results for some tests that no longer have backing store on some
layers.

  • compositing/backing/no-backing-for-clip-expected.txt: Added.
  • compositing/backing/no-backing-for-clip-overlap-expected.txt: Added.
  • compositing/backing/no-backing-for-clip-overlap.html: Added.
  • compositing/backing/no-backing-for-clip.html: Added.
  • compositing/backing/no-backing-for-perspective-expected.txt: Added.
  • compositing/backing/no-backing-for-perspective.html: Added.
  • compositing/geometry/preserve-3d-switching-expected.txt:
  • compositing/visibility/layer-visible-content-expected.png:
  • compositing/visibility/layer-visible-content-expected.txt:
11:28 April 2012 Meeting edited by eae@chromium.org
(diff)
11:27 Changeset [114282] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Increase padding for text element
https://bugs.webkit.org/show_bug.cgi?id=83903

Patch by Yongxin Dai <yodai@rim.com> on 2012-04-16
Reviewed by Antonio Gomes.

PR 125888

Increase the padding value for focused text element to make selection handle
at least partially visible when the user is dragging at edge of viewport
in in-region scoll mode.

Reviewed internally by Mike Fenton.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):

11:27 Changeset [114281] by scheib@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Marking css3/filters/huge-region.html and composited version MISSING, CRASH.

Unreviewed.

  • platform/chromium/test_expectations.txt:
11:12 Changeset [114280] by scheib@chromium.org
  • 2 edits in trunk/Tools

Adding Contributors Brian Salomon and Tom Hudson to committers.py.

Unreviewed.

  • Scripts/webkitpy/common/config/committers.py:
11:06 Changeset [114279] by andersca@apple.com
  • 3 edits in trunk/LayoutTests

Try to fix a flaky JS test.

Use a URL that's allowed to load so the resource load delegate won't randomly complain about it depending on
if the load starts before the Audio object is garbage collected (that's my guess anyway).

  • fast/js/custom-constructors-expected.txt:
  • fast/js/script-tests/custom-constructors.js:
11:01 Changeset [114278] by beidson@apple.com
  • 5 edits in trunk/Source

<rdar://problem/11249336> and https://bugs.webkit.org/show_bug.cgi?id=84050 WebKit2 back/forward items in the page cache are never removed when the page is closed

Reviewed by Jessie Berlin and unofficially reviewed by Jon Lee.

Source/WebCore:

  • WebCore.exp.in: Export PageCache::remove()

Source/WebKit2:

Individual WebBackForwardListProxy's had no idea which items are associated with them.
This adds that association and makes sure the proxy removes all associated items from the PageCache when it closes.

  • WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::WebBackForwardListProxy::removeItem): Remove the item from the PageCache in case it was in it.
(WebKit::WebBackForwardListProxy::addItem): Add the item ID to this back/forward list's set of associated IDs.
(WebKit::WebBackForwardListProxy::close): Remove each associated item from the PageCache.

  • WebProcess/WebPage/WebBackForwardListProxy.h:
10:55 Changeset [114277] by eae@chromium.org
  • 925 edits
    198 copies
    37 deletes in branches/subpixellayout

Merge trunk changes up until 114126 into subpixel branch.

10:55 April 2012 Meeting edited by jsbell@chromium.org
Added proposed IDB discussion (diff)
10:51 Changeset [114276] by philn@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, GTK build fix after r114269.

  • GNUmakefile.list.am:
10:43 Changeset [114275] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Fix bug in WebPluginContainer::isRectTopmost() which gave the incorrect result for a scrolled window.
https://bugs.webkit.org/show_bug.cgi?id=80606

Patch by Raymes Khoury <raymes@chromium.org> on 2012-04-16
Reviewed by Darin Fisher.

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::isRectTopmost):

10:41 Changeset [114274] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix COMMANDLINE_TYPEDARRAYS build
https://bugs.webkit.org/show_bug.cgi?id=84051

Reviewed by Gavin Barraclough.

Update for new putByIndex API and wtf changes.

  • JSCTypedArrayStubs.h:

(JSC):

10:30 Changeset [114273] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update.

  • platform/gtk/test_expectations.txt: Turns out those frame

flattening tests are still flaky.

10:25 Changeset [114272] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: timeline. Range selection works incorrect with right click
https://bugs.webkit.org/show_bug.cgi?id=83870

Reviewed by Pavel Feldman.

  • only start window dragging upon mousedown with left button (right will cause a context menu and we won't see mouseup)
  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewWindow.prototype._dragWindow):

10:23 Changeset [114271] by yurys@chromium.org
  • 13 edits
    63 moves
    1 delete in trunk

Web Inspector: rename heap profiler files and classes DetailedHeapshot* ->HeapSnapshot*
https://bugs.webkit.org/show_bug.cgi?id=84038

A bunch of renames "detailed heapshot" -> "heap snapshot".

Reviewed by Pavel Feldman.

PerformanceTests:

  • inspector/detailed-heapshots-smoke-test.html:

Source/WebCore:

Tests: inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting.html

inspector/profiler/heap-snapshot-comparison-show-all.html
inspector/profiler/heap-snapshot-comparison-show-next.html
inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting.html
inspector/profiler/heap-snapshot-comparison-sorting.html
inspector/profiler/heap-snapshot-containment-expansion-preserved-when-sorting.html
inspector/profiler/heap-snapshot-containment-show-all.html
inspector/profiler/heap-snapshot-containment-show-next.html
inspector/profiler/heap-snapshot-containment-shown-node-count-preserved-when-sorting.html
inspector/profiler/heap-snapshot-containment-sorting.html
inspector/profiler/heap-snapshot-dominators-expansion-preserved-when-sorting.html
inspector/profiler/heap-snapshot-dominators-show-all.html
inspector/profiler/heap-snapshot-dominators-show-next.html
inspector/profiler/heap-snapshot-dominators-shown-node-count-preserved-when-sorting.html
inspector/profiler/heap-snapshot-dominators-sorting.html
inspector/profiler/heap-snapshot-summary-expansion-preserved-when-sorting.html
inspector/profiler/heap-snapshot-summary-show-all.html
inspector/profiler/heap-snapshot-summary-show-next.html
inspector/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting.html
inspector/profiler/heap-snapshot-summary-sorting.html

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/HeapSnapshotGridNodes.js: Renamed from Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js.

(WebInspector.HeapSnapshotGridNode):
(WebInspector.HeapSnapshotGridNode.prototype.ensureContentCreated):
(WebInspector.HeapSnapshotGridNode.prototype.createCell):
(WebInspector.HeapSnapshotGridNode.prototype.dispose):
(WebInspector.HeapSnapshotGridNode.prototype.hasHoverMessage.false.queryObjectContent):
(WebInspector.HeapSnapshotGridNode.prototype._toPercentString):
(WebInspector.HeapSnapshotGridNode.prototype._createValueCell):
(WebInspector.HeapSnapshotGridNode.prototype._populate.sorted):
(WebInspector.HeapSnapshotGridNode.prototype._populate):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren.callSerialize):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved.notify):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
(WebInspector.HeapSnapshotGridNode.prototype._saveChildren):
(WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort.afterPopulate):
(WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort):
(WebInspector.HeapSnapshotGridNode.prototype.sort):
(WebInspector.HeapSnapshotLazyGridNode):
(WebInspector.HeapSnapshotLazyGridNode.prototype.ensureContentCreated):
(WebInspector.HeapSnapshotLazyGridNode.prototype.createCells):
(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.createCell):
(WebInspector.HeapSnapshotGenericObjectNode.prototype._createObjectCell):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.queryObjectContent.else.formatResult):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.queryObjectContent):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get _retainedSizePercent):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get _shallowSizePercent):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.updateHasChildren):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.isWindow):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.shortenWindowURL):
(WebInspector.HeapSnapshotObjectNode):
(WebInspector.HeapSnapshotObjectNode.prototype.updateHasChildren):
(WebInspector.HeapSnapshotObjectNode.prototype._createChildNode):
(WebInspector.HeapSnapshotObjectNode.prototype._childHashForEntity):
(WebInspector.HeapSnapshotObjectNode.prototype._childHashForNode):
(WebInspector.HeapSnapshotObjectNode.prototype.comparator):
(WebInspector.HeapSnapshotObjectNode.prototype._emptyData):
(WebInspector.HeapSnapshotObjectNode.prototype._enhanceData):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):
(WebInspector.HeapSnapshotInstanceNode):
(WebInspector.HeapSnapshotInstanceNode.prototype._createChildNode):
(WebInspector.HeapSnapshotInstanceNode.prototype._childHashForEntity):
(WebInspector.HeapSnapshotInstanceNode.prototype._childHashForNode):
(WebInspector.HeapSnapshotInstanceNode.prototype.comparator):
(WebInspector.HeapSnapshotInstanceNode.prototype._emptyData):
(WebInspector.HeapSnapshotInstanceNode.prototype._enhanceData):
(WebInspector.HeapSnapshotInstanceNode.prototype.get isDeletedNode):
(WebInspector.HeapSnapshotConstructorNode):
(WebInspector.HeapSnapshotConstructorNode.prototype.createCell):
(WebInspector.HeapSnapshotConstructorNode.prototype._createChildNode):
(WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider):
(WebInspector.HeapSnapshotConstructorNode.prototype.comparator):
(WebInspector.HeapSnapshotConstructorNode.prototype._childHashForEntity):
(WebInspector.HeapSnapshotConstructorNode.prototype._childHashForNode):
(WebInspector.HeapSnapshotConstructorNode.prototype.get data):
(WebInspector.HeapSnapshotConstructorNode.prototype.get _countPercent):
(WebInspector.HeapSnapshotConstructorNode.prototype.get _retainedSizePercent):
(WebInspector.HeapSnapshotConstructorNode.prototype.get _shallowSizePercent):
(WebInspector.HeapSnapshotIteratorsTuple):
(WebInspector.HeapSnapshotIteratorsTuple.prototype.dispose):
(WebInspector.HeapSnapshotIteratorsTuple.prototype.sortAndRewind):
(WebInspector.HeapSnapshotDiffNode):
(WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.diffCalculated):
(WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff):
(WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.baseIdsReceived):
(WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.idsReceived):
(WebInspector.HeapSnapshotDiffNode.prototype._createChildNode):
(WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider):
(WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider):
(WebInspector.HeapSnapshotDiffNode.prototype._childHashForEntity):
(WebInspector.HeapSnapshotDiffNode.prototype._childHashForNode):
(WebInspector.HeapSnapshotDiffNode.prototype.comparator):
(WebInspector.HeapSnapshotDiffNode.prototype.populateChildren.firstProviderPopulated):
(WebInspector.HeapSnapshotDiffNode.prototype.populateChildren.else.firstProviderPopulated):
(WebInspector.HeapSnapshotDiffNode.prototype.populateChildren):
(WebInspector.HeapSnapshotDiffNode.prototype._signForDelta):
(WebInspector.HeapSnapshotDiffNode.prototype.get data):
(WebInspector.HeapSnapshotDominatorObjectNode):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._createChildNode):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._childHashForEntity):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._childHashForNode):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype.comparator):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._emptyData):
(MixInSnapshotNodeFunctions):

  • inspector/front-end/HeapSnapshotView.js: Renamed from Source/WebCore/inspector/front-end/DetailedHeapshotView.js.

(WebInspector.HeapSnapshotSortableDataGrid):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.dispose):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.resetSortingCache):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged.SortByTwoFields):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.updateVisibleNodes):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.onResize):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._onScroll):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingEnter):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingLeave):
(WebInspector.HeapSnapshotContainmentDataGrid):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute.nextStep.else.afterExpand):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype.sortingChanged):
(WebInspector.HeapSnapshotRetainmentDataGrid):
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype._sortFields):
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype.reset):
(WebInspector.HeapSnapshotConstructorsDataGrid):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._defaultPopulateCount.100._sortFields):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._filterSelectIndexChanged):
(WebInspector.HeapSnapshotDiffDataGrid):
(WebInspector.HeapSnapshotDiffDataGrid.prototype._defaultPopulateCount.50._sortFields):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotDiffDataGrid.prototype._baseProfileIndexChanged):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived.addNodeIfNonZeroDiff):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotDominatorsDataGrid):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype._defaultPopulateCount.25.setDataSource):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype.sortingChanged):
(WebInspector.HeapSnapshotView.profileCallback):
(WebInspector.HeapSnapshotView):
(WebInspector.HeapSnapshotView.prototype.dispose):
(WebInspector.HeapSnapshotView.prototype.get statusBarItems):
(WebInspector.HeapSnapshotView.prototype.get profile):
(WebInspector.HeapSnapshotView.prototype.get profileWrapper):
(WebInspector.HeapSnapshotView.prototype.get baseProfile):
(WebInspector.HeapSnapshotView.prototype.get baseProfileWrapper):
(WebInspector.HeapSnapshotView.prototype.wasShown.profileCallback1):
(WebInspector.HeapSnapshotView.prototype.wasShown.profileCallback2):
(WebInspector.HeapSnapshotView.prototype.wasShown):
(WebInspector.HeapSnapshotView.prototype.willHide):
(WebInspector.HeapSnapshotView.prototype.onResize):
(WebInspector.HeapSnapshotView.prototype.searchCanceled):
(WebInspector.HeapSnapshotView.prototype.performSearch.matchesByName):
(WebInspector.HeapSnapshotView.prototype.performSearch.matchesById):
(WebInspector.HeapSnapshotView.prototype.performSearch.matchesQuery):
(WebInspector.HeapSnapshotView.prototype.performSearch):
(WebInspector.HeapSnapshotView.prototype.jumpToFirstSearchResult):
(WebInspector.HeapSnapshotView.prototype.jumpToLastSearchResult):
(WebInspector.HeapSnapshotView.prototype.jumpToNextSearchResult):
(WebInspector.HeapSnapshotView.prototype.jumpToPreviousSearchResult):
(WebInspector.HeapSnapshotView.prototype.showingFirstSearchResult):
(WebInspector.HeapSnapshotView.prototype.showingLastSearchResult):
(WebInspector.HeapSnapshotView.prototype._jumpToSearchResult):
(WebInspector.HeapSnapshotView.prototype.refreshVisibleData):
(WebInspector.HeapSnapshotView.prototype._changeBase):
(WebInspector.HeapSnapshotView.prototype._changeFilter):
(WebInspector.HeapSnapshotView.prototype._createToolbarWithClassNameFilter):
(WebInspector.HeapSnapshotView.prototype._changeNameFilter):
(WebInspector.HeapSnapshotView.prototype._profiles):
(WebInspector.HeapSnapshotView.prototype._loadProfile):
(WebInspector.HeapSnapshotView.prototype._loadProfileByIndex):
(WebInspector.HeapSnapshotView.prototype.isDetailedSnapshot):
(WebInspector.HeapSnapshotView.prototype.processLoadedSnapshot):
(WebInspector.HeapSnapshotView.prototype._selectionChanged):
(WebInspector.HeapSnapshotView.prototype._inspectedObjectChanged):
(WebInspector.HeapSnapshotView.prototype._setRetainmentDataGridSource):
(WebInspector.HeapSnapshotView.prototype._mouseDownInContentsGrid):
(WebInspector.HeapSnapshotView.prototype.changeView.sortingComplete):
(WebInspector.HeapSnapshotView.prototype.changeView):
(WebInspector.HeapSnapshotView.prototype._changeView):
(WebInspector.HeapSnapshotView.prototype._getHoverAnchor):
(WebInspector.HeapSnapshotView.prototype._resolveObjectForPopover):
(WebInspector.HeapSnapshotView.prototype._helpClicked.appendHelp):
(WebInspector.HeapSnapshotView.prototype._helpClicked):
(WebInspector.HeapSnapshotView.prototype._startRetainersHeaderDragging):
(WebInspector.HeapSnapshotView.prototype._retainersHeaderDragging):
(WebInspector.HeapSnapshotView.prototype._endRetainersHeaderDragging):
(WebInspector.HeapSnapshotView.prototype._updateRetainmentViewHeight):
(WebInspector.HeapSnapshotView.prototype._updateBaseOptions):
(WebInspector.HeapSnapshotView.prototype._updateFilterOptions):
(WebInspector.HeapSnapshotProfileType):
(WebInspector.HeapSnapshotProfileType.prototype.get buttonTooltip):
(WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
(WebInspector.HeapSnapshotProfileType.prototype.get treeItemTitle):
(WebInspector.HeapSnapshotProfileType.prototype.get description):
(WebInspector.HeapSnapshotProfileType.prototype.createSidebarTreeElementForProfile):
(WebInspector.HeapSnapshotProfileType.prototype.createView):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype._addHeapSnapshotChunk):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
(WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/heapProfiler.css:

(.heap-snapshot-view):
(.heap-snapshot-view.visible):
(.heap-snapshot-view .view):
(.heap-snapshot-view .view.visible):
(.heap-snapshot-view .data-grid tr:empty):
(.heap-snapshot-view .data-grid):
(.heap-snapshot-view .data-grid td.count-column):
(.heap-snapshot-view .data-grid td.addedCount-column):
(.heap-snapshot-view .data-grid td.removedCount-column):
(.heap-snapshot-view .data-grid td.countDelta-column):
(.heap-snapshot-view .data-grid td.addedSize-column):
(.heap-snapshot-view .data-grid td.removedSize-column):
(.heap-snapshot-view .data-grid td.sizeDelta-column):
(.heap-snapshot-view .data-grid td.shallowSize-column):
(.heap-snapshot-view .data-grid td.retainedSize-column):
(.heap-snapshot-view .data-grid td.distanceToWindow-column):
(.heap-snapshot-view .data-grid span.percent-column):
(.heap-snapshot-view .console-formatted-object, .console-formatted-node):
(.heap-snapshot-view .console-formatted-string):
(.heap-snapshot-view .console-formatted-id):
(.heap-snapshot-view .data-grid tr.selected *):
(.heap-snapshot-view .data-grid:focus tr.selected *):
(.heap-snapshot-view .delimiter):
(.heap-snapshot-view .views-container):
(.heap-snapshot-view .views-container .view):
(.heap-snapshot-view .retaining-paths-view):
(.heap-snapshot-view .class-view-grid):
(.heap-snapshot-view .class-view-toolbar):
(.heap-snapshot-view .class-view-toolbar input.class-name-filter):
(.heap-snapshot-view .retainers-view-header):
(.heap-snapshot-view .retainers-view-header .title > span):
(.heap-snapshot-view tr:not(.selected) td.object-column span.highlight):
(.heap-snapshot-view td.object-column span.grayed):
(.heap-snapshot-help-status-bar-item .glyph):
(table.heap-snapshot-help):

  • inspector/front-end/inspector.html:

LayoutTests:

  • inspector/profiler/detailed-heapshots-test.js: Removed.
  • inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-expansion-preserved-when-sorting-expected.txt.
  • inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-expansion-preserved-when-sorting.html.
  • inspector/profiler/heap-snapshot-comparison-show-all-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-show-all-expected.txt.
  • inspector/profiler/heap-snapshot-comparison-show-all.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-show-all.html.
  • inspector/profiler/heap-snapshot-comparison-show-next-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-show-next-expected.txt.
  • inspector/profiler/heap-snapshot-comparison-show-next.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-show-next.html.
  • inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-shown-node-count-preserved-when-sorting-expected.txt.
  • inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-shown-node-count-preserved-when-sorting.html.
  • inspector/profiler/heap-snapshot-comparison-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-sorting-expected.txt.
  • inspector/profiler/heap-snapshot-comparison-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-sorting.html.
  • inspector/profiler/heap-snapshot-containment-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting-expected.txt.
  • inspector/profiler/heap-snapshot-containment-expansion-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting.html.
  • inspector/profiler/heap-snapshot-containment-show-all-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-show-all-expected.txt.
  • inspector/profiler/heap-snapshot-containment-show-all.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-show-all.html.
  • inspector/profiler/heap-snapshot-containment-show-next-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-show-next-expected.txt.
  • inspector/profiler/heap-snapshot-containment-show-next.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-show-next.html.
  • inspector/profiler/heap-snapshot-containment-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-shown-node-count-preserved-when-sorting-expected.txt.
  • inspector/profiler/heap-snapshot-containment-shown-node-count-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-shown-node-count-preserved-when-sorting.html.
  • inspector/profiler/heap-snapshot-containment-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-sorting-expected.txt.
  • inspector/profiler/heap-snapshot-containment-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-sorting.html.
  • inspector/profiler/heap-snapshot-dominators-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-expansion-preserved-when-sorting-expected.txt.
  • inspector/profiler/heap-snapshot-dominators-expansion-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-expansion-preserved-when-sorting.html.
  • inspector/profiler/heap-snapshot-dominators-show-all-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-show-all-expected.txt.
  • inspector/profiler/heap-snapshot-dominators-show-all.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-show-all.html.
  • inspector/profiler/heap-snapshot-dominators-show-next-actual.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-show-next-actual.txt.
  • inspector/profiler/heap-snapshot-dominators-show-next-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-show-next-expected.txt.
  • inspector/profiler/heap-snapshot-dominators-show-next.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-show-next.html.
  • inspector/profiler/heap-snapshot-dominators-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-shown-node-count-preserved-when-sorting-expected.txt.
  • inspector/profiler/heap-snapshot-dominators-shown-node-count-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-shown-node-count-preserved-when-sorting.html.
  • inspector/profiler/heap-snapshot-dominators-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-sorting-expected.txt.
  • inspector/profiler/heap-snapshot-dominators-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-sorting.html.
  • inspector/profiler/heap-snapshot-inspect-dom-wrapper.html:
  • inspector/profiler/heap-snapshot-summary-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting-expected.txt.
  • inspector/profiler/heap-snapshot-summary-expansion-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting.html.
  • inspector/profiler/heap-snapshot-summary-show-all-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-show-all-expected.txt.
  • inspector/profiler/heap-snapshot-summary-show-all.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-show-all.html.
  • inspector/profiler/heap-snapshot-summary-show-next-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-show-next-expected.txt.
  • inspector/profiler/heap-snapshot-summary-show-next.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-show-next.html.
  • inspector/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-shown-node-count-preserved-when-sorting-expected.txt.
  • inspector/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-shown-node-count-preserved-when-sorting.html.
  • inspector/profiler/heap-snapshot-summary-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-sorting-expected.txt.
  • inspector/profiler/heap-snapshot-summary-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-sorting.html.
  • inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest.InspectorTest.startProfilerTest.detailedHeapProfilesEnabled):
(initialize_HeapSnapshotTest.InspectorTest.completeProfilerTest):
(initialize_HeapSnapshotTest.InspectorTest.runHeapSnapshotTestSuite.runner):
(initialize_HeapSnapshotTest.InspectorTest.runHeapSnapshotTestSuite):
(initialize_HeapSnapshotTest):
(initialize_HeapSnapshotTest.):

  • platform/chromium/inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-comparison-expansion-preserved-when-sorting-expected.txt.
  • platform/chromium/inspector/profiler/heap-snapshot-comparison-show-all-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-comparison-show-all-expected.txt.
  • platform/chromium/inspector/profiler/heap-snapshot-comparison-show-next-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-comparison-show-next-expected.txt.
  • platform/chromium/inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-comparison-shown-node-count-preserved-when-sorting-expected.txt.
  • platform/chromium/inspector/profiler/heap-snapshot-comparison-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-comparison-sorting-expected.txt.
  • platform/chromium/inspector/profiler/heap-snapshot-containment-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting-expected.txt.
  • platform/chromium/inspector/profiler/heap-snapshot-containment-show-all-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-containment-show-all-expected.txt.
  • platform/chromium/inspector/profiler/heap-snapshot-containment-show-next-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-containment-show-next-expected.txt.
  • platform/chromium/inspector/profiler/heap-snapshot-containment-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-containment-shown-node-count-preserved-when-sorting-expected.txt.
  • platform/chromium/inspector/profiler/heap-snapshot-containment-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-containment-sorting-expected.txt.
  • platform/chromium/inspector/profiler/heap-snapshot-dominators-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-dominators-expansion-preserved-when-sorting-expected.txt.
  • platform/chromium/inspector/profiler/heap-snapshot-dominators-show-all-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-dominators-show-all-expected.txt.
  • platform/chromium/inspector/profiler/heap-snapshot-dominators-show-next-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-dominators-show-next-expected.txt.
  • platform/chromium/inspector/profiler/heap-snapshot-dominators-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-dominators-shown-node-count-preserved-when-sorting-expected.txt.
  • platform/chromium/inspector/profiler/heap-snapshot-dominators-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-dominators-sorting-expected.txt.
  • platform/chromium/inspector/profiler/heap-snapshot-summary-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting-expected.txt.
  • platform/chromium/inspector/profiler/heap-snapshot-summary-show-all-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-summary-show-all-expected.txt.
  • platform/chromium/inspector/profiler/heap-snapshot-summary-show-next-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-summary-show-next-expected.txt.
  • platform/chromium/inspector/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-summary-shown-node-count-preserved-when-sorting-expected.txt.
  • platform/chromium/inspector/profiler/heap-snapshot-summary-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-summary-sorting-expected.txt.
10:18 Changeset [114270] by caseq@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: touch pad is pain to use in lower pane of Timeline panel due two two-axis scrolling
https://bugs.webkit.org/show_bug.cgi?id=83946

Reviewed by Pavel Feldman.

Remove delegation of mousewheel events from lower timeline pane to the timeline overview. This disables
support for moving overview window with horizontal swype over lower timeline pane, thus removing
an irritating situation when we try to both change overview window and scroll lower timeline pane
upon a single touchpad gesture. Those willing to move timeline window now would need to position
mouse over overview.

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewWindow.prototype._onMouseWheel):
(WebInspector.TimelineOverviewWindow.prototype._zoom):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):

10:14 Changeset [114269] by philn@webkit.org
  • 10 edits
    2 adds in trunk/Source/WebCore

[GStreamer] HRTFDatabaseLoader conflicts with AudioFileReader
https://bugs.webkit.org/show_bug.cgi?id=78095

Reviewed by Martin Robinson.

Moved the GStreamer initialization logic to a new
GStreamerUtilities module, used by the MediaPlayer and the
AudioContext. I also removed the static variables as
gst_init_check already handles cases where it's called multiple
times.

  • GNUmakefile.list.am:
  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::constructCommon):

  • platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):

  • platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::AudioFileReader::createBus):

  • platform/graphics/gstreamer/GRefPtrGStreamer.cpp:

(WTF::adoptGRef):
(WTF):
(WTF::GstElementFactory):

  • platform/graphics/gstreamer/GRefPtrGStreamer.h:

(WTF):

  • platform/graphics/gstreamer/GStreamerUtilities.cpp: Added.

(WebCore):
(WebCore::initializeGStreamer):

  • platform/graphics/gstreamer/GStreamerUtilities.h: Added.

(WebCore):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::doGstInit):

10:06 Changeset [114268] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Update GraphicsContext3DOpenGLES.cpp and fix some issues to build with GLES.
https://bugs.webkit.org/show_bug.cgi?id=83982

Patch by ChangSeok Oh <shivamidow@gmail.com> on 2012-04-16
Reviewed by Martin Robinson.

GL_BGRA is not defined in GLESv2, so it causes build-break at readRenderingResults.
To resolve this, a helper function readPixelsAndConvertToBGRAIfNecessary is added
in GC3DOpenGL.cpp & GC3DOpenGLES.cpp and it's used in GC3DOpenGLCommon.cpp.
And some other issues to build with GLES are gone with this patch.

No new tests, since no new feature.

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::readPixelsAndConvertToBGRAIfNecessary):
(WebCore):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::readRenderingResults):

  • platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:

(WebCore::GraphicsContext3D::readPixelsAndConvertToBGRAIfNecessary):
(WebCore):
(WebCore::GraphicsContext3D::reshapeFBOs):
(WebCore::GraphicsContext3D::resolveMultisamplingIfNecessary):

10:03 Changeset [114267] by xji@chromium.org
  • 4 edits
    8 adds in trunk

[chromium] wrong justification for arabic/persian page in cr-win.
https://bugs.webkit.org/show_bug.cgi?id=83227

Reviewed by Kent Tamura.

Source/WebCore:

Disable kashida justification if using Skia to draw.

Test: fast/text/international/arabic-justify.html

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::justify):

LayoutTests:

  • fast/text/international/arabic-justify.html: Added.
  • platform/chromium-win/fast/text/international/arabic-justify-expected.png: Added.
  • platform/chromium-win/fast/text/international/arabic-justify-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/text/international/arabic-justify-expected.txt: Added.
  • platform/mac-snowleopard/fast/text/international/arabic-justify-expected.png: Added.
  • platform/mac-snowleopard/fast/text/international/arabic-justify-expected.txt: Added.
  • platform/mac/fast/text/international/arabic-justify-expected.txt: Added.
  • platform/qt/fast/text/international/arabic-justify-expected.txt: Added.
09:59 Changeset [114266] by jpu@apple.com
  • 4 edits in trunk/Source/WebCore

Build fix.

Change set 114220 broke OS X internal build. Change set 114231 attempted to fix it, but isn't entirely

correct. This patch amends change set 114231.

  • WebCore.exp.in:
  • editing/DictationAlternative.cpp:

(WebCore::DictationAlternative::DictationAlternative):

  • editing/DictationAlternative.h:

(DictationAlternative):

09:37 Changeset [114265] by antti@apple.com
  • 6 edits
    2 adds in trunk

REGRESSION (r104445): Style is not recomputed on serenaandlily.com
https://bugs.webkit.org/show_bug.cgi?id=83663

Source/WebCore:

Reviewed by Andreas Kling.

CSS class and id selectors are case insensitive in non-strict modes. The code
that invalidated the scope elements used getElementByID() which is case
sensitive in all modes. As a result we would fail to invalidate elements
that would match a style rule but used different case in id.

The new code invalidates by crawling the DOM tree. This often (when there are classes)
actually faster than the existing code as we can now handle everything in a single pass.
Each class scope required a crawl with the old code.

The code uses the same functions as the selector matching code to get the same behavior.

The maximum class limit is lifted as number of classes does not affect complexity anymore.

Test: fast/css/id-or-class-before-stylesheet-strict.html

  • css/SelectorChecker.h:

(WebCore::SelectorChecker::elementMatchesSelectorScopes):
(WebCore):

  • dom/Document.cpp:

(WebCore::Document::testAddedStylesheetRequiresStyleRecalc):
(WebCore):

LayoutTests:

Reviewed by Andreas Kling.

Update the existing test with case insensitive comparisons and add a strict mode test.

  • fast/css/id-or-class-before-stylesheet-expected.txt:
  • fast/css/id-or-class-before-stylesheet-strict-expected.txt: Added.
  • fast/css/id-or-class-before-stylesheet-strict.html: Added.
  • fast/css/id-or-class-before-stylesheet.html:
09:28 April 2012 Meeting edited by tomz@codeaurora.org
(diff)
08:56 Changeset [114264] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update.

  • platform/gtk/test_expectations.txt: Unflag frame flattening

tests fixed in r114262.

08:53 Changeset [114263] by commit-queue@webkit.org
  • 6 edits in trunk

[BlackBerry] Add ability for DRT to handle HTTP authentication challenges.
https://bugs.webkit.org/show_bug.cgi?id=84031

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-04-16
Reviewed by Rob Buis.

Source/WebKit/blackberry:

Added the interface function didReceivedAuthenticaitonChallenge()
in interface class DumpRenderTreeClient;
Called m_dumpRenderTree->didReceiveAuthenticationChallenge() in
WebPagePrivate::authenticationChallenge() when DRT is enabled.

Test: reuse existing test cases:
http/tests/loading/basic-credentials-sent-automatically.html
http/tests/loading/basic-auth-resend-wrong-credentials.html

  • Api/DumpRenderTreeClient.h:

(WebCore):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):

Tools:

Implemented interface function didReceiveAuthenticationChallenge in class
DumpRenderTree.

  • DumpRenderTree/blackberry/DumpRenderTree.cpp:

(drtCredentialDescription):
(BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
(WebKit):

  • DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:

(WebCore):
(DumpRenderTree):

08:51 Changeset [114262] by commit-queue@webkit.org
  • 16 edits in trunk/LayoutTests

[Qt] LayoutTest: Replace setTimeout with synchronous layout for frame flattening where possible.
https://bugs.webkit.org/show_bug.cgi?id=84028

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-16
Reviewed by Kenneth Rohde Christiansen.

It's safer (and faster) to force synchronous layout, than expecting a layout before setTimout(0) hits.

  • fast/frames/flattening/crash-svg-document.html: Remove extra line so that non-svg builds don't report failure.
  • fast/frames/flattening/frameset-flattening-advanced.html:
  • fast/frames/flattening/frameset-flattening-grid.html:
  • fast/frames/flattening/frameset-flattening-subframesets.html:
  • fast/frames/flattening/iframe-flattening-fixed-height.html:
  • fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-with-js-forced-layout.html:
  • fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html:
  • fast/frames/flattening/iframe-flattening-fixed-width-and-height-zero-size.html:
  • fast/frames/flattening/iframe-flattening-fixed-width.html:
  • fast/frames/flattening/iframe-flattening-nested.html:
  • fast/frames/flattening/iframe-flattening-offscreen.html:
  • fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout.html:
  • fast/frames/flattening/iframe-flattening-out-of-view.html:
  • fast/frames/flattening/iframe-flattening-selection-crash.html:
  • fast/frames/flattening/iframe-flattening-simple.html:
08:36 Changeset [114261] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

CSS3 Selectors failures on css3test.com
https://bugs.webkit.org/show_bug.cgi?id=83885

Patch by Uday Kiran <udaykiran@motorola.com> on 2012-04-16
Reviewed by Zoltan Herczeg.

Source/WebCore:

Parsing fix for CSS3 selectors :nth-child(), :nth-last-child() :nth-of-type() :nth-last-of-type()
with values -n-b and n-b as they are of valid form an+b where a and b are integers.
http://www.w3.org/TR/selectors/#structural-pseudos

Descriptors of form n-b or -n-b, where b is number, are valid CSS identifiers.
However, in NthChildMode we need to check whether this identifier is a valid nth child descriptor.
The original code only checked this if the string was n- or -n- but this is not enough.
We need to check everything which starts with an n- or -n- prefix.

Test: css3/parsing-css3-nthchild.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::lex):

LayoutTests:

  • css3/parsing-css3-nthchild-expected.txt: Added.
  • css3/parsing-css3-nthchild.html: Added.
08:35 Changeset [114260] by philn@webkit.org
  • 2 edits in trunk

[GTK] GStreamer 1.0 support in configure.ac
https://bugs.webkit.org/show_bug.cgi?id=84029

Reviewed by Martin Robinson.

The GStreamer version was recently changed to 1.0 in the git
repositories of the project so we need to reflect this change in
configure.ac.

  • configure.ac:
08:33 Changeset [114259] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK test_expectations update.

  • platform/gtk/test_expectations.txt:
08:18 Changeset [114258] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

ASSERT in notifyChildInserted when HTMLMediaElement is removed from tree
https://bugs.webkit.org/show_bug.cgi?id=83949

Reviewed by Antti Koivisto.

No new tests. I was not able to create a reproducible test case, but I have been unable
to reproduce the ASSERT that occassionally fired in existing tests since I have been
living on these changes.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::insertedIntoDocument): Call configureMediaControls.
(WebCore::HTMLMediaElement::removedFromDocument): Ditto.
(WebCore::HTMLMediaElement::configureMediaControls): Don't show controls when the

media element is not in a Document.

08:15 Changeset [114257] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

build-webkit --gtk --no-webkit2 builds WK2
https://bugs.webkit.org/show_bug.cgi?id=83977

Patch by Philippe Normand <pnormand@igalia.com> on 2012-04-16
Reviewed by Martin Robinson.

  • Scripts/build-webkit: Fixup ./configure option to disable

WebKit2 build.

08:13 Changeset [114256] by eric.carlson@apple.com
  • 5 edits in trunk

Layout Test media/track/track-delete-during-setup.html is hitting an ASSERT_NOT_REACHED
https://bugs.webkit.org/show_bug.cgi?id=82269

Reviewed by Antti Koivisto.

Source/WebCore:

No new tests, already tested by media/track/track-delete-during-setup.html.

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::insertedIntoDocument): Don't notify the media element until/unless
the track element is inserted into the document.

  • html/HTMLTrackElement.h:

LayoutTests:

  • platform/chromium/test_expectations.txt:
08:10 Changeset [114255] by mhahnenberg@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

GC in the middle of JSObject::allocatePropertyStorage can cause badness
https://bugs.webkit.org/show_bug.cgi?id=83839

Reviewed by Geoffrey Garen.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • jit/JITStubs.cpp: Making changes to use the new return value of growPropertyStorage.

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/JSObject.cpp:

(JSC::JSObject::growPropertyStorage): Renamed to more accurately reflect that we're
growing our already-existing PropertyStorage.

  • runtime/JSObject.h:

(JSObject):
(JSC::JSObject::setPropertyStorage): "Atomically" sets the new property storage
and the new structure so that we can be sure a GC never occurs when our Structure
info is out of sync with our PropertyStorage.
(JSC):
(JSC::JSObject::putDirectInternal): Moved the check to see if we should
allocate more backing store before the actual property insertion into
the structure.
(JSC::JSObject::putDirectWithoutTransition): Ditto.
(JSC::JSObject::transitionTo): Ditto.

  • runtime/Structure.cpp:

(JSC::Structure::suggestedNewPropertyStorageSize): Added to keep the resize policy
for property backing stores contained within the Structure class.
(JSC):

  • runtime/Structure.h:

(JSC::Structure::shouldGrowPropertyStorage): Lets clients know if another insertion
into the Structure would require resizing the property backing store so that they can
preallocate the required storage.
(Structure):

07:49 Changeset [114254] by commit-queue@webkit.org
  • 2 edits
    16 adds in trunk/LayoutTests

[EFL][DRT] Create baselines for CSS cases related to Ahem font
https://bugs.webkit.org/show_bug.cgi?id=83265

Unreviewed, EFL gardening.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-16

  • platform/efl/fast/css/caption-width-absolute-position-expected.png: Added.
  • platform/efl/fast/css/caption-width-absolute-position-expected.txt: Added.
  • platform/efl/fast/css/caption-width-absolute-position-offset-top-expected.png: Added.
  • platform/efl/fast/css/caption-width-absolute-position-offset-top-expected.txt: Added.
  • platform/efl/fast/css/caption-width-fixed-position-expected.png: Added.
  • platform/efl/fast/css/caption-width-fixed-position-expected.txt: Added.
  • platform/efl/fast/css/caption-width-fixed-position-offset-top-expected.png: Added.
  • platform/efl/fast/css/caption-width-fixed-position-offset-top-expected.txt: Added.
  • platform/efl/fast/css/caption-width-relative-position-expected.png: Added.
  • platform/efl/fast/css/caption-width-relative-position-expected.txt: Added.
  • platform/efl/fast/css/caption-width-relative-position-offset-top-expected.png: Added.
  • platform/efl/fast/css/caption-width-relative-position-offset-top-expected.txt: Added.
  • platform/efl/fast/css/min-width-with-spanned-cell-expected.png: Added.
  • platform/efl/fast/css/min-width-with-spanned-cell-expected.txt: Added.
  • platform/efl/fast/css/min-width-with-spanned-cell-fixed-expected.png: Added.
  • platform/efl/fast/css/min-width-with-spanned-cell-fixed-expected.txt: Added.
  • platform/efl/test_expectations.txt:
07:43 Changeset [114253] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Fix build break in PageClientImpl.cpp.
https://bugs.webkit.org/show_bug.cgi?=id=84034

Reviewed by Kenneth Rohde Christiansen.

Fixes typo in didChangeViewportProperites definition.

  • UIProcess/API/efl/PageClientImpl.cpp: (WebKit::PageClientImpl::didChangeViewportProperties):

Patch by Michał Pakuła vel Rutka <m.pakula@samsung.com> on 2012-04-16

07:33 Changeset [114252] by commit-queue@webkit.org
  • 53 edits
    56 adds in trunk/LayoutTests

[EFL][DRT] SVG rebaseline for tests affected by SVGEllipse and SVG shadow root changes
https://bugs.webkit.org/show_bug.cgi?id=84027

Unreviewed, EFL gardening.

Updating txt baselines for tests affected by r109097 and r112806,
creating pixel test results.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-16

  • platform/efl/svg/batik/paints/patternPreserveAspectRatioA-expected.png: Added.
  • platform/efl/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
  • platform/efl/svg/batik/paints/patternRegionA-expected.png: Added.
  • platform/efl/svg/batik/paints/patternRegionA-expected.txt:
  • platform/efl/svg/batik/paints/patternRegions-expected.png: Added.
  • platform/efl/svg/batik/paints/patternRegions-expected.txt:
  • platform/efl/svg/batik/paints/patternRegions-positioned-objects-expected.png: Added.
  • platform/efl/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
  • platform/efl/svg/carto.net/button-expected.png: Added.
  • platform/efl/svg/carto.net/button-expected.txt:
  • platform/efl/svg/carto.net/colourpicker-expected.png: Added.
  • platform/efl/svg/carto.net/colourpicker-expected.txt:
  • platform/efl/svg/carto.net/slider-expected.png: Added.
  • platform/efl/svg/carto.net/slider-expected.txt:
  • platform/efl/svg/carto.net/window-expected.png: Added.
  • platform/efl/svg/carto.net/window-expected.txt:
  • platform/efl/svg/clip-path/clip-in-mask-expected.png: Added.
  • platform/efl/svg/clip-path/clip-in-mask-expected.txt:
  • platform/efl/svg/clip-path/clip-path-child-clipped-expected.png: Added.
  • platform/efl/svg/clip-path/clip-path-child-clipped-expected.txt:
  • platform/efl/svg/clip-path/clip-path-clipped-no-content-expected.png: Added.
  • platform/efl/svg/clip-path/clip-path-clipped-no-content-expected.txt:
  • platform/efl/svg/clip-path/clip-path-css-transform-1-expected.png: Added.
  • platform/efl/svg/clip-path/clip-path-css-transform-1-expected.txt:
  • platform/efl/svg/clip-path/clip-path-css-transform-2-expected.png: Added.
  • platform/efl/svg/clip-path/clip-path-css-transform-2-expected.txt:
  • platform/efl/svg/clip-path/clip-path-evenodd-expected.png: Added.
  • platform/efl/svg/clip-path/clip-path-evenodd-expected.txt:
  • platform/efl/svg/clip-path/clip-path-evenodd-nonzero-expected.png: Added.
  • platform/efl/svg/clip-path/clip-path-evenodd-nonzero-expected.txt:
  • platform/efl/svg/clip-path/clip-path-nonzero-evenodd-expected.png: Added.
  • platform/efl/svg/clip-path/clip-path-nonzero-evenodd-expected.txt:
  • platform/efl/svg/clip-path/clip-path-nonzero-expected.png: Added.
  • platform/efl/svg/clip-path/clip-path-nonzero-expected.txt:
  • platform/efl/svg/clip-path/clip-path-pixelation-expected.png: Added.
  • platform/efl/svg/clip-path/clip-path-pixelation-expected.txt:
  • platform/efl/svg/clip-path/clip-path-text-and-shape-expected.png: Added.
  • platform/efl/svg/clip-path/clip-path-text-and-shape-expected.txt:
  • platform/efl/svg/clip-path/clip-path-transform-1-expected.png: Added.
  • platform/efl/svg/clip-path/clip-path-transform-1-expected.txt:
  • platform/efl/svg/clip-path/clip-path-use-as-child2-expected.png: Added.
  • platform/efl/svg/clip-path/clip-path-use-as-child2-expected.txt:
  • platform/efl/svg/clip-path/clip-path-use-as-child3-expected.png: Added.
  • platform/efl/svg/clip-path/clip-path-use-as-child3-expected.txt:
  • platform/efl/svg/clip-path/clip-path-use-as-child4-expected.png: Added.
  • platform/efl/svg/clip-path/clip-path-use-as-child4-expected.txt:
  • platform/efl/svg/clip-path/clip-path-use-as-child5-expected.png: Added.
  • platform/efl/svg/clip-path/clip-path-use-as-child5-expected.txt:
  • platform/efl/svg/clip-path/clip-path-with-container-expected.png: Added.
  • platform/efl/svg/clip-path/clip-path-with-container-expected.txt:
  • platform/efl/svg/clip-path/clip-path-with-different-unittypes-expected.png: Added.
  • platform/efl/svg/clip-path/clip-path-with-different-unittypes-expected.txt:
  • platform/efl/svg/clip-path/clip-path-with-different-unittypes2-expected.png: Added.
  • platform/efl/svg/clip-path/clip-path-with-different-unittypes2-expected.txt:
  • platform/efl/svg/clip-path/clip-path-with-invisibile-child-expected.png: Added.
  • platform/efl/svg/clip-path/clip-path-with-invisibile-child-expected.txt:
  • platform/efl/svg/clip-path/clip-path-with-text-clipped-expected.png: Added.
  • platform/efl/svg/clip-path/clip-path-with-text-clipped-expected.txt:
  • platform/efl/svg/clip-path/clipper-placement-issue-expected.png: Added.
  • platform/efl/svg/clip-path/clipper-placement-issue-expected.txt:
  • platform/efl/svg/clip-path/deep-nested-clip-in-mask-expected.png: Added.
  • platform/efl/svg/clip-path/deep-nested-clip-in-mask-expected.txt:
  • platform/efl/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png: Added.
  • platform/efl/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt:
  • platform/efl/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png: Added.
  • platform/efl/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.txt:
  • platform/efl/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png: Added.
  • platform/efl/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.txt:
  • platform/efl/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png: Added.
  • platform/efl/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.txt:
  • platform/efl/svg/css/clippath-with-shadow-expected.png: Added.
  • platform/efl/svg/css/clippath-with-shadow-expected.txt:
  • platform/efl/svg/css/mask-with-shadow-expected.png: Added.
  • platform/efl/svg/css/mask-with-shadow-expected.txt:
  • platform/efl/svg/css/shadow-changes-expected.png: Added.
  • platform/efl/svg/css/shadow-changes-expected.txt:
  • platform/efl/svg/hixie/cascade/001-broken-expected.png: Added.
  • platform/efl/svg/hixie/cascade/001-broken-expected.txt:
  • platform/efl/svg/hixie/cascade/002-expected.png: Added.
  • platform/efl/svg/hixie/cascade/002-expected.txt:
  • platform/efl/svg/hixie/error/001-expected.png: Added.
  • platform/efl/svg/hixie/error/001-expected.txt:
  • platform/efl/svg/hixie/error/003-expected.png: Added.
  • platform/efl/svg/hixie/error/003-expected.txt:
  • platform/efl/svg/hixie/error/017-expected.png: Added.
  • platform/efl/svg/hixie/error/017-expected.txt:
  • platform/efl/svg/hixie/perf/001-expected.png: Added.
  • platform/efl/svg/hixie/perf/001-expected.txt: Added.
  • platform/efl/svg/hixie/perf/002-expected.png: Added.
  • platform/efl/svg/hixie/perf/002-expected.txt: Added.
  • platform/efl/svg/hixie/rendering-model/001-expected.png: Added.
  • platform/efl/svg/hixie/rendering-model/001-expected.txt:
  • platform/efl/svg/hixie/rendering-model/002-expected.png: Added.
  • platform/efl/svg/hixie/rendering-model/002-expected.txt:
  • platform/efl/svg/hixie/transform/001-expected.png: Added.
  • platform/efl/svg/hixie/transform/001-expected.txt:
  • platform/efl/svg/hixie/use/001-expected.png: Added.
  • platform/efl/svg/hixie/use/001-expected.txt:
  • platform/efl/svg/stroke/zero-length-path-linecap-rendering-expected.png: Added.
  • platform/efl/svg/stroke/zero-length-path-linecap-rendering-expected.txt:
  • platform/efl/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Added.
  • platform/efl/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt:
  • platform/efl/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/efl/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/efl/svg/zoom/page/zoom-hixie-mixed-008-expected.png: Added.
  • platform/efl/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
  • platform/efl/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Added.
  • platform/efl/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
07:30 WebKit Team edited by rafael.lobo@openbossa.org
Adding myself to the committers list. (diff)
07:20 Changeset [114251] by lforschler@apple.com
  • 2 edits in branches/safari-534.57-branch/Source/JavaScriptCore

Merged r112966.

07:17 Changeset [114250] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] [DRT] Feeding key events with invalid keyName
https://bugs.webkit.org/show_bug.cgi?id=83797

Tools:

Keep the keyName valid within scope of KeyEventInfo to avoid
feeding key events with invalid keyName.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-16
Reviewed by Philippe Normand.

  • DumpRenderTree/efl/EventSender.cpp:

(KeyEventInfo::KeyEventInfo):
(KeyEventInfo):
(keyPadNameFromJSValue):
(keyNameFromJSValue):
(createKeyEventInfo):
(sendKeyDown):

LayoutTests:

Unskip fast/frames/iframe-window-focus.html

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-16
Reviewed by Philippe Normand.

  • platform/efl/Skipped:
07:05 Changeset [114249] by yael.aharon@nokia.com
  • 8 edits
    1 add in trunk

[Qt][WK2] Fixed elements position is wrong after zooming.
https://bugs.webkit.org/show_bug.cgi?id=83981

Reviewed by Kenneth Rohde Christiansen.

.:

  • ManualTests/remove-add-fixed-position.html: Added.

Source/WebCore:

When setFixedVisibleContentRect is called we mark all fixed elements in the frame for layout.
In order to find these elements, RenderView maintains a list of fixed elements.
They are added and removed at the same time that they are added and removed from their parent RenderBlock.
The idea is taken from the iOS5.1 branch, at opensource.apple.com.
Added a manual test that allows removing and adding fixed elements at will.

  • page/FrameView.cpp:

(WebCore::FrameView::setFixedVisibleContentRect):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::insertPositionedObject):
(WebCore::RenderBlock::removePositionedObject):

  • rendering/RenderView.cpp:

(WebCore::RenderView::setFixedPositionedObjectsNeedLayout):
(WebCore):
(WebCore::RenderView::insertFixedPositionedObject):
(WebCore::RenderView::removeFixedPositionedObject):

  • rendering/RenderView.h:

(RenderView):

Source/WebKit2:

Turn on the flag setFixedElementsLayoutRelativeToFrame. This causes fixed elements position to be calculated based on
visibleWidth and visibleHeight. When zoom level grows, the visibleWidth and visibleHeight become smaller.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setResizesToContentsUsingLayoutSize):

06:59 Changeset [114248] by toyoshim@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, skip crash test in chromium-mac.
https://bugs.webkit.org/show_bug.cgi?id=84024

  • platform/chromium/test_expectations.txt:
06:38 Changeset [114247] by kenneth@webkit.org
  • 6 edits in trunk/Source/WebKit2

[Qt] Clean up how the interaction engine is making use of ViewportAttributes
https://bugs.webkit.org/show_bug.cgi?id=83895

Reviewed by Simon Hausmann.

Refactor how the interaction engine is using the ViewportAttributes
and get rid of the Contraints subclass.

Push the ViewportAttributes through to the QQuickWebViewPrivate class
and add some default values in the case the Legacy view is used.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewLegacyPrivate::QQuickWebViewLegacyPrivate):
(QQuickWebViewFlickablePrivate::didChangeViewportProperties):

  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

  • UIProcess/API/qt/qwebviewportinfo.cpp:

(QWebViewportInfo::QWebViewportInfo):
(QWebViewportInfo::~QWebViewportInfo):
(QWebViewportInfo::currentScale):
(QWebViewportInfo::devicePixelRatio):
(QWebViewportInfo::initialScale):
(QWebViewportInfo::minimumScale):
(QWebViewportInfo::maximumScale):
(QWebViewportInfo::isScalable):
(QWebViewportInfo::layoutSize):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::cssScaleFromItem):
(WebKit::QtViewportInteractionEngine::itemScaleFromCSS):
(WebKit::QtViewportInteractionEngine::itemCoordFromCSS):
(WebKit::QtViewportInteractionEngine::innerBoundedCSSScale):
(WebKit::QtViewportInteractionEngine::outerBoundedCSSScale):
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
(WebKit::QtViewportInteractionEngine::setCSSScaleBounds):
(WebKit::QtViewportInteractionEngine::setCSSScale):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
(WebKit::QtViewportInteractionEngine::pinchGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::pinchGestureEnded):

  • UIProcess/qt/QtViewportInteractionEngine.h:

(QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::hadUserInteraction):
(WebKit::QtViewportInteractionEngine::setAllowsUserScaling):
(WebKit::QtViewportInteractionEngine::setContentToDevicePixelRatio):

06:19 Changeset [114246] by pierre.rossi@gmail.com
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after QRawFont change.

Missed this one earlier. We now use primaryFontHasGlyphForCharacter from
FontFastPath.cpp, resulting in a different DRT output.

  • platform/qt-5.0/Skipped: unskip
  • platform/qt-5.0/svg/as-image/img-preserveAspectRatio-support-1-expected.txt:
06:16 SelectiveTestEWS edited by beszedes@inf.u-szeged.hu
(diff)
06:09 SelectiveTestBuildBot edited by beszedes@inf.u-szeged.hu
(diff)
05:58 Changeset [114245] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Replace QtXmlPatterns usage with libxslt dependency
https://bugs.webkit.org/show_bug.cgi?id=76820

Unreviewed gardening. Skip new failing tests after r114240 until fix.

  • platform/qt-5.0/Skipped:
05:53 Changeset [114244] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL][DRT] Gardening CSS Regions & Exclusions
https://bugs.webkit.org/show_bug.cgi?id=84011

Skipping CSS regions and exclusions tests for now,
waiting for feature to complete.

Unreviewed, EFL gardening.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-16

  • platform/efl/Skipped:
  • platform/efl/test_expectations.txt:
05:41 Changeset [114243] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK gardening.

  • platform/gtk/test_expectations.txt: Flag two failing media tests.
04:58 Top100Invariant edited by beszedes@inf.u-szeged.hu
(diff)
04:57 RegressionTestResearch edited by beszedes@inf.u-szeged.hu
(diff)
04:51 SelectiveTestBuildBot edited by beszedes@inf.u-szeged.hu
(diff)
04:50 Changeset [114242] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Accelerated compositing layers fail to render in direct rendering mode
https://bugs.webkit.org/show_bug.cgi?id=83933

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-04-16
Reviewed by Adam Treat.

RIM PR: 149609
This was because I accidentally dropped an exclamation mark when
upstreaming the patch for PR 136381 (bug #83131). Fixed by adding back
the exclamation mark.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):

04:49 Improving Regression Tests edited by beszedes@inf.u-szeged.hu
(diff)
04:46 Changeset [114241] by pfeldman@chromium.org
  • 26 edits
    1 add in trunk

Web Inspector: extract ContentProvider into its own file, make NetworkRequest, Resoruce and others implement it.
https://bugs.webkit.org/show_bug.cgi?id=83922

Reviewed by Yury Semikhatsky.

Source/WebCore:

We have two different types of requestContent methods: one on the source mapping level and one on the resource level.
There are also adapters between the two. I'm aligning it all to a single requestContent method declared in ContentProvider.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/BreakpointsSidebarPane.js:

(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint.didRequestContent):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint):

  • inspector/front-end/ContentProvider.js: Added.

(WebInspector.ContentProvider):
(WebInspector.ContentProvider.prototype.contentURL):
(WebInspector.ContentProvider.prototype.requestContent):
(WebInspector.ContentProvider.prototype.searchInContent):
(WebInspector.ContentProvider.SearchMatch):

  • inspector/front-end/ContentProviders.js:

(WebInspector.ScriptContentProvider.prototype.contentURL):
(WebInspector.ScriptContentProvider.prototype.requestContent):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.contentURL):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.requestContent):
(WebInspector.CompilerSourceMappingContentProvider.prototype.contentURL):
(WebInspector.CompilerSourceMappingContentProvider.prototype.requestContent):
(WebInspector.StaticContentProvider.prototype.contentURL):
(WebInspector.StaticContentProvider.prototype.requestContent):

  • inspector/front-end/DebuggerPresentationModel.js:
  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._getResourceContent):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.requestContent):

  • inspector/front-end/NetworkItemView.js:

(WebInspector.RequestContentView.prototype._ensureInnerViewShown.callback):
(WebInspector.RequestContentView.prototype._ensureInnerViewShown):

  • inspector/front-end/NetworkRequest.js:

(WebInspector.NetworkRequest.prototype.contentURL):
(WebInspector.NetworkRequest.prototype.requestContent):
(WebInspector.NetworkRequest.prototype.searchInContent):
(WebInspector.NetworkRequest.prototype.populateImageSource):
(WebInspector.NetworkRequest.prototype._innerRequestContent.onResourceContent):
(WebInspector.NetworkRequest.prototype._innerRequestContent):

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode.prototype._createContentProvider):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping):

  • inspector/front-end/Resource.js:

(WebInspector.Resource.prototype.contentURL):
(WebInspector.Resource.prototype.requestContent):
(WebInspector.Resource.prototype._innerRequestContent.callback):
(WebInspector.Resource.prototype._innerRequestContent):
(WebInspector.ResourceRevision.prototype.contentURL):
(WebInspector.ResourceRevision.prototype.requestContent.callbackWrapper):
(WebInspector.ResourceRevision.prototype.requestContent):
(WebInspector.ResourceRevision.prototype.searchInContent):

  • inspector/front-end/ResourceView.js:

(WebInspector.ResourceSourceFrame.prototype.requestContent):
(WebInspector.ResourceSourceFrame.prototype._contentChanged):
(WebInspector.ResourceRevisionSourceFrame.prototype.requestContent):

  • inspector/front-end/ScriptFormatter.js:
  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.requestVisibleScriptOutline):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.setContent):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.requestContent):
(WebInspector.UISourceCode.prototype._didRequestContent):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:

LayoutTests:

  • http/tests/inspector/compiler-script-mapping.html:
  • inspector/debugger/content-providers-expected.txt:
  • inspector/debugger/content-providers.html:
  • inspector/debugger/raw-source-code.html:
  • inspector/debugger/ui-source-code.html:
04:44 Changeset [114240] by kbalazs@webkit.org
  • 3 edits
    6 adds in trunk/Tools

[Qt] Replace QtXmlPatterns usage with libxslt dependency
<https://bugs.webkit.org/show_bug.cgi?id=76820>

Patch by Andras Piroska <pandras@inf.u-szeged.hu> on 2012-04-16
Reviewed by Simon Hausmann.

The features.prf file was modified, in order to use libxml and libxslt by default.
This modification only work at Qt5.

  • qmake/config.tests/libxml2/libxml2.cpp: Added.

(main):

  • qmake/config.tests/libxml2/libxml2.pro: Added.
  • qmake/config.tests/libxslt/libxslt.cpp: Added.

(main):

  • qmake/config.tests/libxslt/libxslt.pro: Added.
  • qmake/mkspecs/features/features.prf:
  • qmake/sync.profile:
04:32 Changeset [114239] by toyoshim@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, fix a wrong expected.txt
https://bugs.webkit.org/show_bug.cgi?id=84014

  • fast/canvas/webgl/shader-precision-format-expected.txt:
04:20 Changeset [114238] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] EWebLaucher : Fix wrong parameter order in function call for multiple windows.
https://bugs.webkit.org/show_bug.cgi?id=83862

Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-04-16
Reviewed by Kenneth Rohde Christiansen.

EWebLauncher creates multiple windows, like multiple tabs when pressing F9 key.
It doesn't work properly because of wrong parameter order in function call.

  • EWebLauncher/main.c:
03:13 Changeset [114237] by ossy@webkit.org
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip failing tests, because less tests means less problems.

  • platform/qt-5.0/Skipped:
  • platform/qt/Skipped:
02:24 Changeset [114236] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r114200.

  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
02:04 Changeset [114235] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[BlackBerry] Missing readyState 2 when a XMLHttpRequest calls xmlhttp.open("HEAD","notExist.html",true).
https://bugs.webkit.org/show_bug.cgi?id=83866

Source/WebCore:

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-16
Reviewed by George Staikos.

We receive 404 for a XMLHttpRequest which calls open("HEAD", "notExist.html", true).
There are no data received because its method is HEAD.
This case shouldn't be treated as a failure.

Test: http/tests/xmlhttprequest/xmlhttprequest-check-head-readystate-for-404.html

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::handleNotifyClose):

LayoutTests:

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-16
Reviewed by George Staikos.

  • http/tests/xmlhttprequest/xmlhttprequest-check-head-readystate-for-404-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-check-head-readystate-for-404.html: Added.
01:56 Changeset [114234] by tkent@chromium.org
  • 7 edits
    2 deletes in trunk/LayoutTests

[Chromium] Rebaseline for date-appearance.html.

  • platform/chromium-linux/fast/forms/date/date-appearance-expected.png:
  • platform/chromium-linux/fast/forms/date/date-appearance-expected.txt:
  • platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/date/date-appearance-expected.png:
  • platform/chromium-mac/fast/forms/date/date-appearance-expected.txt:
  • platform/chromium-win/fast/forms/date/date-appearance-expected.png:
  • platform/chromium-win/fast/forms/date/date-appearance-expected.txt:
01:42 Changeset [114233] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt]REGRESSION(r114217): It broke fast/repaint/line-flow-with-floats-in-regions.html
https://bugs.webkit.org/show_bug.cgi?id=84013

Unreviewed gardening, skip a failing test to paint the bot green. (Less tests, less problem.)

  • platform/qt/Skipped:
01:32 Changeset [114232] by philn@webkit.org
  • 1 edit
    12 adds in trunk/LayoutTests

Unreviewed, GTK baselines for tests added in r114162.

  • platform/gtk/ietestcenter/css3/grid/display-grid-001-expected.txt: Added.
  • platform/gtk/ietestcenter/css3/grid/display-grid-002-expected.txt: Added.
  • platform/gtk/ietestcenter/css3/grid/grid-column-001-expected.txt: Added.
  • platform/gtk/ietestcenter/css3/grid/grid-column-002-expected.txt: Added.
  • platform/gtk/ietestcenter/css3/grid/grid-column-003-expected.txt: Added.
  • platform/gtk/ietestcenter/css3/grid/grid-columns-001-expected.txt: Added.
  • platform/gtk/ietestcenter/css3/grid/grid-items-001-expected.txt: Added.
  • platform/gtk/ietestcenter/css3/grid/grid-items-002-expected.txt: Added.
  • platform/gtk/ietestcenter/css3/grid/grid-items-003-expected.txt: Added.
  • platform/gtk/ietestcenter/css3/grid/grid-items-004-expected.txt: Added.
  • platform/gtk/ietestcenter/css3/grid/grid-items-005-expected.txt: Added.
01:16 Changeset [114231] by jonlee@apple.com
  • 4 edits in trunk/Source/WebCore

Build fix.

  • WebCore.exp.in:
  • editing/DictationAlternative.cpp:

(WebCore::DictationAlternative::DictationAlternative):

  • editing/DictationAlternative.h:

(DictationAlternative):

01:11 Changeset [114230] by staikos@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix signed/unsigned mismatch warning for BlackBerry debug builds.
https://bugs.webkit.org/show_bug.cgi?id=80790

Reviewed by Rob Buis.

  • platform/blackberry/CookieMap.cpp:

(WebCore::CookieMap::removeCookieAtIndex):

00:42 Changeset [114229] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK gardening.

  • platform/gtk/test_expectations.txt: Skip svg failures, unskip

ietestcenter for rebaseline and unflag a flaky media/track test.

00:26 Changeset [114228] by philn@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, GTK gardening.

  • Scripts/run-gtk-tests:

(TestRunner): Skip /webkit/atk/textChangedNotifications.

00:14 Changeset [114227] by thakis@chromium.org
  • 2 edits in trunk/Source/WTF

Make NullPtr.h compile with clang -std=c++11 and libstdc++4.2
https://bugs.webkit.org/show_bug.cgi?id=83999

Reviewed by Sam Weinig.

Before this patch, NullPtr.h assumed that a working |nullptr| implied
a working |std::nullptr_t| as well. With clang and libstdc++4.2, this
is not true.

I tested (-stdlib=libc++, -stdlib=libstdc++) x (-std=c++11, -std=c++03)
with clang.

  • wtf/NullPtr.h:

(std):

04/15/12:

23:37 Changeset [114226] by carlosgc@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Use GRefPtr to delete the default web context in WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=83752

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitWebContext.cpp:

(createDefaultWebContext):

23:23 Changeset [114225] by ossy@webkit.org
  • 8 edits in trunk/LayoutTests

[Qt] Unreviewed morning gardening.

  • platform/qt-4.8/fast/dom/Window/window-properties-expected.txt: Updated after r114150.
  • platform/qt-5.0-wk2/fast/dom/Window/window-properties-expected.txt: Updated after r114150.
  • platform/qt-5.0-wk2/fast/dom/prototype-inheritance-2-expected.txt: Updated after r114200.
  • platform/qt-5.0/fast/dom/Window/window-properties-expected.txt: Updated after r114150.
  • platform/qt-5.0/fast/dom/prototype-inheritance-2-expected.txt: Updated after r114200.
  • platform/qt/Skipped: Skip a test after r114150, because of missing layoutTestController.setBackingScaleFactor().
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt: Updated after r114150.
23:12 Changeset [114224] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

WebCore::weekDayShortLabels() for ICU always returns the fallback labels
https://bugs.webkit.org/show_bug.cgi?id=83991

Reviewed by Hajime Morita.

We need to specfiy 1-based index to udat_getSymbols() with
UDAT_SHORT_WEEKDAYS. Also, udat_countSymbols() with UDAT_SHORT_WEEKDAYS
returns 8.

No new tests because this behavior depends on locale setting.

  • platform/text/LocalizedCalendarICU.cpp:

(WebCore::createLabelVector): Add startIndex argument.
(WebCore::createMonthLabels):
Pass UDAT_JANUARRY(0) as startIndex to createLabelVector().
(WebCore::createWeekDayShortLabels):
Pass UDAT_SUNDAY(1) as startIndex to createLabelVector().

22:32 PrefixedAPIs edited by kojiishi@gmail.com
(diff)
22:21 Changeset [114223] by keishi@webkit.org
  • 7 edits in trunk/Source/WebKit/chromium

Introduce MenuItemID to autofill popup
https://bugs.webkit.org/show_bug.cgi?id=83777

Introducing MenuItemIDs because we want to add multiple separators and
need to identify non-autofill menu items without resorting to the separator position.

Reviewed by Kent Tamura.

  • public/WebAutofillClient.h:

(WebKit::WebAutofillClient::didAcceptAutofillSuggestion): Changed uniqueID to itemID because they aren't unique.
(WebKit::WebAutofillClient::didSelectAutofillSuggestion):

  • public/WebView.h:

(WebView):

  • src/AutofillPopupMenuClient.cpp:

(WebKit::AutofillPopupMenuClient::AutofillPopupMenuClient):
(WebKit::AutofillPopupMenuClient::getSuggestionsCount):
(WebKit::AutofillPopupMenuClient::getSuggestion):
(WebKit::AutofillPopupMenuClient::getLabel):
(WebKit::AutofillPopupMenuClient::getIcon):
(WebKit::AutofillPopupMenuClient::removeSuggestionAtIndex):
(WebKit::AutofillPopupMenuClient::canRemoveSuggestionAtIndex):
(WebKit::AutofillPopupMenuClient::valueChanged):
(WebKit::AutofillPopupMenuClient::selectionChanged):
(WebKit::AutofillPopupMenuClient::itemIsSeparator):
(WebKit::AutofillPopupMenuClient::itemIsWarning):
(WebKit::AutofillPopupMenuClient::initialize):
(WebKit::AutofillPopupMenuClient::setSuggestions):

  • src/AutofillPopupMenuClient.h: Removed m_separatorIndex because now we use itemID to identify separators.

Added m_useLegacyBehavior which is true when it is initialized with a valid separator index. This is to keep
the autofill working even when the chromium side hasn't been updated yet.
(AutofillPopupMenuClient):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::applyAutofillSuggestions):

  • src/WebViewImpl.h:

(WebViewImpl):

21:13 Changeset [114222] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed attempt to chromium-win build fix.

  • editing/DictationAlternative.h:
20:54 Changeset [114221] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

Align JSC/V8 bindings canvas.toDataURL() code flows
https://bugs.webkit.org/show_bug.cgi?id=84003

Reviewed by Eric Seidel.

Align JSC/V8 bindings canvas.toDataURL() code flow so that the binding
code implementations read alike.

No new tests. Covered by existing cnavas toDataURL tests.

  • bindings/js/JSHTMLCanvasElementCustom.cpp:

(WebCore::JSHTMLCanvasElement::toDataURL):

20:05 Changeset [114220] by jpu@apple.com
  • 31 edits
    3 copies
    3 adds in trunk/Source/WebCore

Introducing DictationCommand.
https://bugs.webkit.org/show_bug.cgi?id=83549

Reviewed by Hajime Morita.

No new tests. This patch doesn't introduce any change of new functionality. It prepares for
additional changes which will inlude tests.

On OS X, alternative dictation results need to be stored as document markers. This patch introduces
following changes to achieve this:

  1. Added DictationMarkDetails to store non-string type maker detail.
  2. Introduce DictationCommand, which is similor to TypingCommand, but allows inserting text with attached markers.
  3. Added Editor::insertDictatedText as interaface to WebKit and WebKit2.
  4. Added struct DictationAlternative to pass dictation related info from WebKit to WebCore.

Several fragments of code in TypingCommand can be also used by DictationCommand. So this patch
introduced a new class, TextInsertionBaseCommand. It's a subclass of CompositeEditCommmand, and
base class of both TypingCommand and DictationCommand.

This patch also extends InsertTextCommand class. Its constructor will take an TextInsertionMarkerSupplier
object. After text is inserted to a node, InsertTextCommand would give marker supplier a chance to
add document markers to the inserted text.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:

(WebCore::eventTargetNodeForDocument): Moved this function from EventHandler so that it can be used

by AlternativeTextController.

(WebCore):

  • dom/Document.h:

(WebCore):

  • dom/DocumentMarker.cpp:

(WebCore::DocumentMarker::DocumentMarker): New constructor that takes a pointer to DocumentMarkerDetails object.
(WebCore):

  • dom/DocumentMarker.h:

(WebCore::DocumentMarker::AllMarkers::AllMarkers):
(DocumentMarker):

  • dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::addMarker):
(WebCore):

  • dom/DocumentMarkerController.h:

(DocumentMarkerController):

  • dom/TextEvent.cpp:

(WebCore::TextEvent::createForDictation):
(WebCore):
(WebCore::TextEvent::TextEvent):

  • dom/TextEvent.h: Added member variable for dictation alternatives.

(TextEvent):
(WebCore::TextEvent::isDictation):
(WebCore::TextEvent::dictationAlternatives):

  • dom/TextEventInputType.h:
  • editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::AlternativeTextController):
(WebCore::AlternativeTextController::insertDictatedText): Used by Editor::insertDictatedText().
(WebCore):

  • editing/AlternativeTextController.h:

(WebCore):
(DictationMarkerDetails):
(WebCore::DictationMarkerDetails::create):
(WebCore::DictationMarkerDetails::originalText):
(WebCore::DictationMarkerDetails::dictationContext):
(WebCore::DictationMarkerDetails::DictationMarkerDetails):
(AlternativeTextController):

  • editing/CompositeEditCommand.h:

(WebCore::CompositeEditCommand::isDictationCommand):

  • editing/DictationAlternative.cpp: Added.

(WebCore):
(WebCore::DictationAlternative::DictationAlternative):

  • editing/DictationAlternative.h: Added. Data structure for passing dictation related data from WebKit to WebCore.

(DictationAlternative):
(WebCore):

  • editing/DictationCommand.cpp: Added.

(WebCore):
(DictationCommandLineOperation):
(WebCore::DictationCommandLineOperation::DictationCommandLineOperation):
(WebCore::DictationCommandLineOperation::operator()):
(DictationMarkerSupplier):
(WebCore::DictationMarkerSupplier::create):
(WebCore::DictationMarkerSupplier::addMarkersToTextNode):
(WebCore::DictationMarkerSupplier::DictationMarkerSupplier):
(WebCore::DictationCommand::DictationCommand):
(WebCore::DictationCommand::insertText):
(WebCore::DictationCommand::doApply):
(WebCore::DictationCommand::insertTextRunWithoutNewlines):
(WebCore::DictationCommand::insertParagraphSeparator):
(WebCore::DictationCommand::collectDictationAlternativesInRange):

  • editing/DictationCommand.h: Added.

(WebCore):
(DictationCommand):
(WebCore::DictationCommand::isDictationCommand):
(WebCore::DictationCommand::create):

  • editing/EditingAllInOne.cpp:
  • editing/Editor.cpp:

(WebCore::Editor::insertDictatedText): Main interface that allows WebKit passes in text with attached dictation information.
(WebCore):
(WebCore::Editor::insertTextWithoutSendingTextEvent):
(WebCore::Editor::updateMarkersForWordsAffectedByEditing):

  • editing/Editor.h:

(Editor):

  • editing/InsertTextCommand.cpp:

(WebCore::InsertTextCommand::InsertTextCommand):
(WebCore):
(WebCore::InsertTextCommand::doApply):

  • editing/InsertTextCommand.h:

(WebCore):
(TextInsertionMarkerSupplier): Interface to allow caller of InsertTextCommand to add document markers to inserted text.
(WebCore::TextInsertionMarkerSupplier::~TextInsertionMarkerSupplier):
(WebCore::TextInsertionMarkerSupplier::TextInsertionMarkerSupplier):
(WebCore::InsertTextCommand::createWithMarkerSupplier):
(InsertTextCommand):

  • editing/TextInsertionBaseCommand.cpp: Added. This class contains functions shared by TypingCommand and DictationCommand.

(WebCore):
(WebCore::TextInsertionBaseCommand::TextInsertionBaseCommand):
(WebCore::TextInsertionBaseCommand::applyTextInsertionCommand):
(WebCore::dispatchBeforeTextInsertedEvent):
(WebCore::canAppendNewLineFeedToSelection):

  • editing/TextInsertionBaseCommand.h: Added.

(WebCore):
(TextInsertionBaseCommand):
(WebCore::TextInsertionBaseCommand::~TextInsertionBaseCommand):
(WebCore::forEachLineInString):

  • editing/TypingCommand.cpp:

(TypingCommandLineOperation):
(WebCore::TypingCommandLineOperation::TypingCommandLineOperation):
(WebCore::TypingCommandLineOperation::operator()):
(WebCore::TypingCommand::TypingCommand):
(WebCore::TypingCommand::insertText):
(WebCore::TypingCommand::insertLineBreak):
(WebCore::TypingCommand::insertParagraphSeparator):

  • editing/TypingCommand.h:
  • page/EventHandler.cpp:
  • rendering/InlineTextBox.cpp:

(WebCore::lineStyleForMarkerType):
(WebCore::InlineTextBox::paintDocumentMarker): Renamed existing function to reflect new funcationality.
(WebCore::InlineTextBox::paintDocumentMarkers):

  • rendering/InlineTextBox.h:

(InlineTextBox):

  • testing/Internals.cpp:

(WebCore::markerTypesFrom):

19:49 Changeset [114219] by jamesr@google.com
  • 33 edits
    2 copies
    4 adds
    6 deletes in trunk/LayoutTests

[chromium] Unreviewed rebaselines for various compositing tests.

  • platform/chromium-linux-x86/compositing/reflections/animation-inside-reflection-expected.png: Removed.
  • platform/chromium-linux-x86/compositing/reflections/nested-reflection-animated-expected.png: Removed.
  • platform/chromium-linux/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
  • platform/chromium-linux/compositing/geometry/fixed-position-composited-page-scale-expected.png:
  • platform/chromium-linux/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
  • platform/chromium-linux/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
  • platform/chromium-linux/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
  • platform/chromium-linux/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
  • platform/chromium-linux/compositing/reflections/animation-inside-reflection-expected.png:
  • platform/chromium-linux/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Added.
  • platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.txt: Added.
  • platform/chromium-mac-leopard/compositing/reflections/animation-inside-reflection-expected.png:
  • platform/chromium-mac-leopard/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
  • platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
  • platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
  • platform/chromium-mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.png:
  • platform/chromium-mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.txt: Added.
  • platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
  • platform/chromium-mac/compositing/geometry/fixed-position-composited-page-scale-expected.png:
  • platform/chromium-mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
  • platform/chromium-mac/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
  • platform/chromium-mac/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
  • platform/chromium-mac/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
  • platform/chromium-mac/compositing/reflections/animation-inside-reflection-expected.png:
  • platform/chromium-mac/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-mac/compositing/repaint/newly-composited-repaint-rect-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-page-scale-down-expected.png.
  • platform/chromium-win-vista/compositing/reflections/animation-inside-reflection-expected.png: Removed.
  • platform/chromium-win-vista/compositing/reflections/nested-reflection-animated-expected.png: Removed.
  • platform/chromium-win-xp/compositing/reflections/animation-inside-reflection-expected.txt: Removed.
  • platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.png: Removed.
  • platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.txt: Added.
  • platform/chromium-win/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
  • platform/chromium-win/compositing/geometry/fixed-position-composited-page-scale-expected.png:
  • platform/chromium-win/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
  • platform/chromium-win/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
  • platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
  • platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
  • platform/chromium-win/compositing/reflections/animation-inside-reflection-expected.png:
  • platform/chromium-win/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/chromium-win/compositing/repaint/newly-composited-repaint-rect-expected.png: Copied from LayoutTests/platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png.
19:44 Changeset [114218] by commit-queue@webkit.org
  • 16 edits in trunk/Source

[chromium] LayerRendererChromium shouldn't know anything about CCLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=83415

Patch by James Robinson <jamesr@chromium.org> on 2012-04-15
Reviewed by Adrienne Walker.

Source/WebCore:

This removes all knowledge of CCLayerImpl from LayerRendererChromium. The most significant move code-wise is
moving the HUD up to live on CCLayerTreeHostImpl, since it's aware of the layer tree. This involves two changes.
First, CCHeadsUpDisplay is in charge of populating a ManagedTexture but the actual drawing code now lives in
LayerRendererChromium. Second, since we don't recreate CCLayerTreeHostImpl on a lost context, the font atlas
ownership is much simpler. Now a CCFontAtlas is created on the main thread if needed and passed asynchronously
to the CCHeadsUpDisplay which takes ownership of the atlas.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::~LayerRendererChromium):
(WebCore::LayerRendererChromium::beginDrawingFrame):
(WebCore::LayerRendererChromium::drawHeadsUpDisplay):
(WebCore):
(WebCore::LayerRendererChromium::finishDrawingFrame):
(WebCore::LayerRendererChromium::swapBuffers):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromiumClient):
(LayerRendererChromium):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
(WebCore::CCHeadsUpDisplay::setFontAtlas):
(WebCore):
(WebCore::CCHeadsUpDisplay::enabled):
(WebCore::CCHeadsUpDisplay::showPlatformLayerTree):
(WebCore::CCHeadsUpDisplay::draw):
(WebCore::CCHeadsUpDisplay::drawHudContents):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h:

(WebCore):
(WebCore::CCHeadsUpDisplay::create):
(CCHeadsUpDisplay):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initialize):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::canDraw):
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):
(WebCore::CCLayerTreeHostImpl::drawLayers):
(WebCore::CCLayerTreeHostImpl::swapBuffers):
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
(WebCore::CCLayerTreeHostImpl::setFullRootLayerDamage):
(WebCore::CCLayerTreeHostImpl::layerTreeAsText):
(WebCore):
(WebCore::CCLayerTreeHostImpl::setFontAtlas):
(WebCore::CCLayerTreeHostImpl::dumpRenderSurfaces):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::rootLayer):

  • platform/graphics/chromium/cc/CCProxy.h:

(WebCore):
(CCProxy):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::recreateContext):
(WebCore::CCSingleThreadProxy::setFontAtlas):
(WebCore):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::initializeLayerRendererOnImplThread):
(WebCore::CCThreadProxy::setFontAtlas):
(WebCore):
(WebCore::CCThreadProxy::setFontAtlasOnImplThread):
(WebCore::CCThreadProxy::recreateContextOnImplThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

Add an explicit rootLayer getter to the test implementation of LayerRendererChromium since there isn't one on
the base class any more.

  • tests/LayerRendererChromiumTest.cpp:

(FakeLayerRendererChromiumClient::rootLayer):
(FakeLayerRendererChromiumClient):
(TEST_F):

19:40 Changeset [114217] by antti@apple.com
  • 27 edits in trunk

Capture CSS parser context
https://bugs.webkit.org/show_bug.cgi?id=83998

Source/WebCore:

Reviewed by Andreas Kling.

Currently the CSS parser calls to the Document and StyleSheetInternal objects to get settings, base URL etc.
The required information should be passed in on parser construction instead. The parser should not need to
know about the document at all.

The patch adds CSSParserContext struct that captures the parsing context. StyleSheetInternal saves the
parsing context and reuses it for any further parsing.

If the same stylesheet source is parsed with an identical context then the resulting stylesheet structure will
be identical. This will allow sharing parsed stylesheets in the future.

  • css/CSSGrammar.y:
  • css/CSSImportRule.cpp:

(WebCore::StyleRuleImport::setCSSStyleSheet):

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::insertRule):

  • css/CSSPageRule.cpp:

(WebCore::CSSPageRule::setSelectorText):

  • css/CSSParser.cpp:

(WebCore):
(WebCore::strictCSSParserContext):
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::parseKeyframeRule):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseSelector):
(WebCore::CSSParser::completeURL):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseAttr):
(WebCore::CSSParser::parseFillImage):
(WebCore::CSSParser::parseFontFaceSrcURI):
(WebCore::CSSParser::parseFontFaceSrc):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseImageSet):
(WebCore::CSSParser::parseCustomFilter):
(WebCore::CSSParser::parseFilter):
(WebCore::CSSParser::cssRegionsEnabled):
(WebCore::CSSParser::parseFlowThread):
(WebCore::CSSParser::createMediaRule):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createKeyframe):

  • css/CSSParser.h:

(CSSParser):
(WebCore::CSSParser::inStrictMode):
(WebCore::CSSParser::inQuirksMode):
(WebCore::CSSParser::validUnit):

  • css/CSSParserMode.h:

(WebCore):
(CSSParserContext):

  • css/CSSRule.h:

(WebCore::CSSRule::parserContext):
(CSSRule):

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::setSelectorText):

  • css/CSSStyleSheet.cpp:

(WebCore::StyleSheetInternal::StyleSheetInternal):
(WebCore::StyleSheetInternal::parseString):
(WebCore::StyleSheetInternal::parseStringAtLine):
(WebCore):
(WebCore::StyleSheetInternal::updateBaseURL):
(WebCore::StyleSheetInternal::completeURL):
(WebCore::CSSStyleSheet::insertRule):

  • css/CSSStyleSheet.h:

(StyleSheetInternal):
(WebCore::StyleSheetInternal::parserContext):
(WebCore::StyleSheetInternal::charset):
(WebCore::StyleSheetInternal::setFinalURL):
(WebCore::StyleSheetInternal::baseURL):

  • css/CSSValuePool.cpp:
  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::parseDeclaration):

  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::insertRule):

  • dom/Document.cpp:

(WebCore::Document::webkitGetFlowByName):
(WebCore::Document::pageUserSheet):
(WebCore::Document::pageGroupUserSheets):

  • dom/Element.cpp:

(WebCore::Element::webkitMatchesSelector):

  • dom/Node.cpp:

(WebCore::Node::querySelector):
(WebCore::Node::querySelectorAll):

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::parseStyleSheet):

  • dom/StyleElement.cpp:

(WebCore::StyleElement::createSheet):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::setCSSStyleSheet):

  • html/shadow/ContentSelectorQuery.cpp:

(WebCore::ContentSelectorQuery::ContentSelectorQuery):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyleSheet::reparseStyleSheet):
(WebCore::InspectorStyleSheet::ensureSourceData):
(WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):

LayoutTests:

Reviewed by Andreas Kling.

Modify the tests so that they don't expect settings changes to apply to already existing stylesheets.

  • css3/filters/script-tests/custom-filter-property-parsing.js:
  • fast/regions/script-tests/css-regions-disabled.js:
19:14 Changeset [114216] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

[Cairo] Separate image encoding from dataURL construction
https://bugs.webkit.org/show_bug.cgi?id=83975

Reviewed by Martin Robinson.

Remove the implicit assumption that a dataURL is the only desired output format
of the image encoding phase.

No new tests. Covered by existing canvas toDataURL tests.

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::writeFunction): Rename closure to output.
(WebCore::encodeImage): Output the encoded image to the provided Vector<char>.
PNG format is only supported per the Cairo encoding MIMETypeRegistry.
(WebCore):
(WebCore::ImageBuffer::toDataURL): Refactor to use encodeImage().

18:43 Changeset [114215] by yutak@chromium.org
  • 7 edits in trunk/Source

Leak in WebSocketChannel with workers/worker-reload.html (part 2)
https://bugs.webkit.org/show_bug.cgi?id=83749

Reviewed by David Levin.

Source/WebCore:

Second attempt to remove leaks around WorkerThreadableWebSocketChannel.

No new tests, as this patch does not impose any functional change.

  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
(WebCore::ThreadableWebSocketChannelClientWrapper::failedWebSocketChannelCreation):
(WebCore::ThreadableWebSocketChannelClientWrapper::setFailedWebSocketChannelCreation):

  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:

Add a boolean flag indicating whether Bridge::initialize() has exited without receiving
a pointer to the peer object.

  • Modules/websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::WorkerContextDidInitializeTask::create):
(WebCore::WorkerThreadableWebSocketChannel::WorkerContextDidInitializeTask::WorkerContextDidInitializeTask):
(WebCore::WorkerThreadableWebSocketChannel::WorkerContextDidInitializeTask::performTask):
Kick mainThreadDestroy() to delete the peer if the bridge has failed to receive
a pointer to the peer (waitForMethodCompletion() exited due to message queue's
termination).
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadInitialize):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::initialize):

  • Modules/websockets/WorkerThreadableWebSocketChannel.h:

(WorkerThreadableWebSocketChannel):
Make WorkerContextDidInitializeTask an inner class of WorkerThreadableWebSocketChannel
so it can refer WorkerThreadableWebSocketChannel's static member function (mainThreadDestroy()).

Source/WebKit/chromium:

  • src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::postTaskForModeToWorkerContext):
Correctly propagate the return value of postTaskForModeToWorkerContext().

16:15 Changeset [114214] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Chromium perf bots should not build
https://bugs.webkit.org/show_bug.cgi?id=83641

Reviewed by Eric Seidel.

Don't build on perf bots to improve the cycle time.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
08:23 Changeset [114213] by rakuco@webkit.org
  • 1 delete in trunk/LayoutTests/platform/efl/fast/regions

Remove empty directory.

08:21 Changeset [114212] by rakuco@webkit.org
  • 2 edits
    50 deletes in trunk/LayoutTests

[EFL] Gardening. Skip fast/regions tests.

SVN r90067 skipped fast/regions for many ports, but EFL's skipped
list was added later. Skip all tests there and remove existing
baselines.

  • platform/efl/Skipped:
  • platform/efl/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
  • platform/efl/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Removed.
  • platform/efl/fast/regions/flow-content-basic-vertical-expected.png: Removed.
  • platform/efl/fast/regions/flow-content-basic-vertical-expected.txt: Removed.
  • platform/efl/fast/regions/flow-content-basic-vertical-rl-expected.png: Removed.
  • platform/efl/fast/regions/flow-content-basic-vertical-rl-expected.txt: Removed.
  • platform/efl/fast/regions/flows-dependency-dynamic-remove-expected.png: Removed.
  • platform/efl/fast/regions/flows-dependency-dynamic-remove-expected.txt: Removed.
  • platform/efl/fast/regions/flows-dependency-same-flow-expected.png: Removed.
  • platform/efl/fast/regions/flows-dependency-same-flow-expected.txt: Removed.
  • platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Removed.
  • platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Removed.
  • platform/efl/fast/regions/overflow-in-uniform-regions-dynamic-expected.png: Removed.
  • platform/efl/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt: Removed.
  • platform/efl/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png: Removed.
  • platform/efl/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Removed.
  • platform/efl/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png: Removed.
  • platform/efl/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt: Removed.
  • platform/efl/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.png: Removed.
  • platform/efl/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt: Removed.
  • platform/efl/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.png: Removed.
  • platform/efl/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.txt: Removed.
  • platform/efl/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.png: Removed.
  • platform/efl/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.txt: Removed.
  • platform/efl/fast/regions/percentage-margins-rtl-variable-width-regions-expected.png: Removed.
  • platform/efl/fast/regions/percentage-margins-rtl-variable-width-regions-expected.txt: Removed.
  • platform/efl/fast/regions/percentage-margins-variable-width-regions-expected.png: Removed.
  • platform/efl/fast/regions/percentage-margins-variable-width-regions-expected.txt: Removed.
  • platform/efl/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
  • platform/efl/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
  • platform/efl/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
  • platform/efl/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
  • platform/efl/fast/regions/text-region-split-small-pagination-expected.png: Removed.
  • platform/efl/fast/regions/text-region-split-small-pagination-expected.txt: Removed.
  • platform/efl/fast/regions/top-overflow-out-of-second-region-expected.png: Removed.
  • platform/efl/fast/regions/top-overflow-out-of-second-region-expected.txt: Removed.
  • platform/efl/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Removed.
  • platform/efl/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Removed.
  • platform/efl/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Removed.
  • platform/efl/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Removed.
  • platform/efl/fast/regions/webkit-flow-float-unable-to-push-expected.png: Removed.
  • platform/efl/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Removed.
  • platform/efl/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png: Removed.
  • platform/efl/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Removed.
  • platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png: Removed.
  • platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Removed.
  • platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.png: Removed.
  • platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Removed.
  • platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.png: Removed.
  • platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Removed.

04/14/12:

20:51 Changeset [114211] by eae@chromium.org
  • 4 edits in trunk/Source/WebCore

Fix pixelSnapping for CalendarPicker, MediaControl and ScrollbarPart
https://bugs.webkit.org/show_bug.cgi?id=83929

Reviewed by Eric Seidel.

Update CalendarPickerElement and MediaControlElements to use
pixelSnappedSize in preparation for turning on subpixel support.
Update RenderScrollbarPart to pixel snap rect before painting to ensure
that it is painted on device pixel boundaries.

No new tests, no change in functionality.

  • html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::openPopup):

  • html/shadow/MediaControlElements.cpp:

(WebCore::RenderMediaVolumeSliderContainer::layout):

  • rendering/RenderScrollbarPart.cpp:

(WebCore::RenderScrollbarPart::paintIntoRect):

20:31 Changeset [114210] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Day of week labels are wrong if WebCore::firstDayOfWeek() is not 0
https://bugs.webkit.org/show_bug.cgi?id=83990

Reviewed by Kentaro Hara.

We passed the "weekStartDay" property value as a
string. CalendarPickerElement::writeDocument() created:

weekStartDay: "1",

and the JavaScript code used it in the following code:

dayLabels[(weekStartDay + i) % 7]

If weekStartDay was "1", the expression (weekStartDay + i)
produced "10", "11", "12", ... We expected "1", "2", "3", ...

We need to pass the "weekStartDay" property as a number.

No new tests because we have no ways to test this for now. We'll
introduce tests for the calendar picker later.

  • html/shadow/CalendarPickerElement.cpp:

(WebCore::addProperty): Add addProperty() function for a number.
(WebCore::CalendarPickerElement::writeDocument):
Pass a number, not a serialized number.

17:43 Changeset [114209] by weinig@apple.com
  • 2 edits in trunk/Source/WTF

Harden WTF::ByteArray::create()
https://bugs.webkit.org/show_bug.cgi?id=83318

Reviewed by Maciej Stachowiak.

  • wtf/ByteArray.cpp:

(WTF::ByteArray::create):
Add overflow check. I don't believe there is anyway to trigger this currently,
hence no tests, so this should be considered hardening.

14:29 Changeset [114208] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk

Viewport-percentage Length units does not work for Replaced elements size
https://bugs.webkit.org/show_bug.cgi?id=83425

Patch by Joe Thomas <joethomas@motorola.com> on 2012-04-14
Reviewed by Antti Koivisto.

Added the support for viewport-percentage length units while calculating the width/height of replaced elements.

Source/WebCore:

Tests: css3/viewport-percentage-lengths/viewport-percentage-image-size.html

  • platform/Length.h:

(WebCore::Length::isSpecified):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalWidthUsing):

LayoutTests:

  • css3/viewport-percentage-lengths/resources: Added.
  • css3/viewport-percentage-lengths/resources/colorsquare.png: Added.
  • css3/viewport-percentage-lengths/viewport-percentage-image-size-expected.html: Added.
  • css3/viewport-percentage-lengths/viewport-percentage-image-size.html: Added.
14:05 Changeset [114207] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

CSSStyleDeclaration.getPropertyValue() for 'border-radius' returns null when value is set
https://bugs.webkit.org/show_bug.cgi?id=80736

Patch by Joe Thomas <joethomas@motorola.com> on 2012-04-14
Reviewed by Antti Koivisto.

Added support for fetching the value of 'border-radius' CSS property which was missing.

Source/WebCore:

Test: fast/css/border-radius-property-value.html

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getPropertyValue):

LayoutTests:

  • fast/css/border-radius-property-value-expected.txt: Added.
  • fast/css/border-radius-property-value.html: Added.
11:29 Changeset [114206] by commit-queue@webkit.org
  • 4 edits in trunk

[WK2] Set WebKitTestRunner's WebProcess cache model to DocumentBrowser.
https://bugs.webkit.org/show_bug.cgi?id=81945

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-14
Reviewed by Dan Bernstein.

Tools:

WebProcess's default cache model is DocumentViewer. When DocumentViewer model is on,
the PageCache's capacity is set to 0. Tests that are enabling 'WebKitUsesPageCachePreferenceKey' expect
PageCache to be functional.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

LayoutTests:

Re-enable 2 tests where WebKitUsesPageCachePreferenceKey is set.

  • platform/mac-wk2/Skipped:
11:15 Changeset [114205] by hyatt@apple.com
  • 3 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=83826

Wrong Font code path was chosen after r114032. The TextRun constructor has an additional argument that
needs to be included if rounding hacks are mentioned.

Reviewed by Dan Bernstein.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawTextInternal):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::paintItemForeground):

  • rendering/break_lines.cpp:

(WebCore::nextBreakablePosition):

03:30 WebKitGTK edited by sh4.seo@samsung.com
Use internal link (diff)
02:34 Changeset [114204] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

[Cairo] ImageBuffer::toDataURL(): improve error handling, add mimeType ASSERTs
https://bugs.webkit.org/show_bug.cgi?id=83569

Reviewed by Eric Seidel.

No new tests. Covered by exiting fast/canvas/*toDataURL* tests.

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::writeFunction): Return write success or failure with the appropriate
cairo status code per http://cairographics.org/manual/cairo-PNG-Support.html
(WebCore::ImageBuffer::toDataURL): Add mimeType ASSERT()s. <canvas> ensures that
a valid mimeType (supported by the port) is sent to toDataURL() calls. Check for
encoding failure and return "data:," if so.

Note: See TracTimeline for information about the timeline view.