Timeline


and

04/22/12:

23:37 Changeset [114874] by ossy@webkit.org

Add Notification constructor
https://bugs.webkit.org/show_bug.cgi?id=80477

[Qt] Unreviewed gardening after r114855.

  • platform/qt-4.8/fast/dom/Window/window-properties-expected.txt:
  • platform/qt-5.0-wk2/fast/dom/Window/window-properties-expected.txt:
  • platform/qt-5.0-wk2/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt-5.0/fast/dom/Window/window-properties-expected.txt:
  • platform/qt-5.0/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
23:30 Changeset [114873] by zandobersek@gmail.com

Unreviewed, add a baseline for computed style test after r114766.

  • platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt: Added.
23:16 Changeset [114872] by yurys@chromium.org

Web Inspector: make populateChildren methods private in heap profiler front-end
https://bugs.webkit.org/show_bug.cgi?id=84562

Source/WebCore:

  • populateChildren method on HeapSnapshotConstructorsDataGrid and

HeapSnapshotDiffDataGrid now is private.

  • Made _defaultPopulateCount a public method on HeapSnapshotSortableDataGrid which

is overriden in some descendants

  • Removed unused HeapSnapshotPathFinderProxy
  • added closure compiler annotations

Reviewed by Pavel Feldman.

  • inspector/front-end/HeapSnapshotDataGrids.js:

(WebInspector.HeapSnapshotSortableDataGrid.prototype.defaultPopulateCount):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._filterSelectIndexChanged):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.defaultPopulateCount):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype.defaultPopulateCount):

  • inspector/front-end/HeapSnapshotGridNodes.js:

(WebInspector.HeapSnapshotGridNode):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren.callSerialize):
(WebInspector.HeapSnapshotDiffNode):
(WebInspector.HeapSnapshotDiffNode.prototype.populateChildren.firstProviderPopulated):

  • inspector/front-end/HeapSnapshotProxy.js:

LayoutTests:

  • Made _defaultPopulateCount a public method on HeapSnapshotSortableDataGrid which

is overriden in some descendants

Reviewed by Pavel Feldman.

  • inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest.InspectorTest.startProfilerTest.detailedHeapProfilesEnabled.WebInspector.HeapSnapshotContainmentDataGrid.prototype.defaultPopulateCount):
(initialize_HeapSnapshotTest.InspectorTest.startProfilerTest.detailedHeapProfilesEnabled.WebInspector.HeapSnapshotConstructorsDataGrid.prototype.defaultPopulateCount):
(initialize_HeapSnapshotTest.InspectorTest.startProfilerTest.detailedHeapProfilesEnabled.WebInspector.HeapSnapshotDiffDataGrid.prototype.defaultPopulateCount):
(initialize_HeapSnapshotTest.InspectorTest.startProfilerTest.detailedHeapProfilesEnabled.WebInspector.HeapSnapshotDominatorsDataGrid.prototype.defaultPopulateCount):
(initialize_HeapSnapshotTest.InspectorTest.startProfilerTest.detailedHeapProfilesEnabled):

22:59 Changeset [114871] by kling@webkit.org

Unreviewed build fix, remove Attribute.cpp from DOMAllInOne.cpp.

  • dom/DOMAllInOne.cpp: My nemesis.
22:40 Changeset [114870] by kling@webkit.org

Optimize Element attribute storage for the common case (no Attr objects.)
<http://webkit.org/b/83440>

Reviewed by Antti Koivisto.

Source/WebCore:

Reduce Attribute to its smallest possible size; a qname/value pair.
They are no-longer ref-counted, which allows us to store them in Vectors.

Refactored the DOM Attr object to go with the new Attribute:
Attr now wraps either {element, qname} or {qname, value}. The latter is for
the case where a standalone Attr object is instantiated via DOM APIs.

ElementAttributeData.cpp manages a map of pair<element, qname> => Attr.
Each Element (well, ElementAttributeData) keeps track of how many Attr
objects are pointing to it. This is so we can avoid hash lookups during
common operations in the typical case where you have zero Attrs.

Also removed the inline capacity (was 4) from AttributeVector as that
would significantly increase bloat now that we store Attribute (2 pointers)
rather than RefPtr<Attribute>. We trade this one piece of indirection
for the removal of per-Attribute indirection.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Attr.cpp:

(WebCore::Attr::Attr):
(WebCore):
(WebCore::Attr::create):
(WebCore::Attr::~Attr):
(WebCore::Attr::createTextChild):
(WebCore::Attr::setPrefix):
(WebCore::Attr::setValue):
(WebCore::Attr::cloneNode):
(WebCore::Attr::childrenChanged):
(WebCore::Attr::style):
(WebCore::Attr::value):
(WebCore::Attr::elementAttribute):
(WebCore::Attr::detachFromElementWithValue):
(WebCore::Attr::attachToElement):

  • dom/Attr.h:

(WebCore):
(Attr):
(WebCore::Attr::qualifiedName):
(WebCore::Attr::localName):
(WebCore::Attr::namespaceURI):
(WebCore::Attr::prefix):

  • dom/Attribute.cpp: Removed.
  • dom/Attribute.h:

(WebCore::Attribute::Attribute):
(Attribute):

  • dom/Document.cpp:

(WebCore::Document::importNode):
(WebCore::Document::createAttributeNS):

  • dom/Element.cpp:

(WebCore::Element::~Element):
(WebCore::Element::detachAttribute):
(WebCore):
(WebCore::Element::removeAttribute):
(WebCore::Element::setAttributeInternal):
(WebCore::Element::parserSetAttributes):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeNode):
(WebCore::Element::normalizeAttributes):
(WebCore::Element::didRemoveAttribute):
(WebCore::Element::attrIfExists):
(WebCore::Element::ensureAttr):

  • dom/Element.h:

(Element):
(WebCore::Element::getAttributeItemIndex):

  • dom/ElementAttributeData.cpp:

(WebCore):
(WebCore::attrMap):
(WebCore::ElementAttributeData::attrIfExists):
(WebCore::ElementAttributeData::ensureAttr):
(WebCore::ElementAttributeData::setAttr):
(WebCore::ElementAttributeData::removeAttr):
(WebCore::AttributeVector::removeAttribute):
(WebCore::ElementAttributeData::~ElementAttributeData):
(WebCore::ElementAttributeData::addAttribute):
(WebCore::ElementAttributeData::removeAttribute):
(WebCore::ElementAttributeData::isEquivalent):
(WebCore::ElementAttributeData::detachAttributesFromElement):
(WebCore::ElementAttributeData::getAttributeItemIndexSlowCase):
(WebCore::ElementAttributeData::setAttributes):
(WebCore::ElementAttributeData::clearAttributes):
(WebCore::ElementAttributeData::replaceAttribute):
(WebCore::ElementAttributeData::getAttributeNode):

  • dom/ElementAttributeData.h:

(WebCore):
(WebCore::AttributeVector::AttributeVector):
(AttributeVector):
(WebCore::AttributeVector::getAttributeItem):
(WebCore::AttributeVector::getAttributeItemIndex):
(WebCore::AttributeVector::insertAttribute):
(WebCore::ElementAttributeData::attributeItem):
(ElementAttributeData):
(WebCore::ElementAttributeData::ElementAttributeData):
(WebCore::ElementAttributeData::attributeVector):
(WebCore::ElementAttributeData::clonedAttributeVector):
(WebCore::ElementAttributeData::removeAttribute):
(WebCore::ElementAttributeData::getAttributeItem):
(WebCore::ElementAttributeData::getAttributeItemIndex):

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::getNamedItem):
(WebCore::NamedNodeMap::getNamedItemNS):
(WebCore::NamedNodeMap::removeNamedItem):
(WebCore::NamedNodeMap::removeNamedItemNS):
(WebCore::NamedNodeMap::item):

  • dom/Node.cpp:

(WebCore::Node::compareDocumentPosition):

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::parseAttribute):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::parseAttribute):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):
(WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement):
(WebCore::HTMLConstructionSite::insertScriptElement):
(WebCore::HTMLConstructionSite::createElement):
(WebCore::HTMLConstructionSite::createHTMLElement):
(WebCore::HTMLConstructionSite::createHTMLElementFromSavedElement):

  • html/parser/HTMLToken.h:

(WebCore::AtomicHTMLToken::AtomicHTMLToken):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processFakeStartTag):
(WebCore::HTMLTreeBuilder::attributesForIsindexInput):
(WebCore::HTMLTreeBuilder::processIsindexStartTagForInBody):
(WebCore):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):

  • html/parser/HTMLTreeBuilder.h:
  • html/parser/TextDocumentParser.cpp:

(WebCore::TextDocumentParser::insertFakePreElement):

  • page/PageSerializer.cpp:

(WebCore::SerializerMarkupAccumulator::appendCustomAttributes):

  • svg/SVGFitToViewBox.cpp:
  • svg/properties/SVGAnimatedPropertySynchronizer.h:
  • xml/XMLErrors.cpp:

(WebCore::createXHTMLParserErrorHeader):
(WebCore::XMLErrors::insertErrorMessageBlock):

  • xml/XPathNodeSet.cpp:

(WebCore::XPath::NodeSet::traversalSort):

  • xml/XPathStep.cpp:

(WebCore::XPath::Step::nodesInAxis):

  • xml/parser/MarkupTokenBase.h:

(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):
(WebCore::AtomicMarkupTokenBase::getAttributeItem):
(WebCore::AtomicMarkupTokenBase::attributes):
(AtomicMarkupTokenBase):
(WebCore::::initializeAttributes):

  • xml/parser/XMLToken.h:

(WebCore::AtomicXMLToken::AtomicXMLToken):

  • xml/parser/XMLTreeBuilder.cpp:

(WebCore::XMLTreeBuilder::processNamespaces):
(WebCore::XMLTreeBuilder::processAttributes):

Source/WebKit/chromium:

Remove the WebNamedNodeMap and WebAttribute API classes since they are no
longer needed by chromium after <http://crrev.com/133299>.

  • WebKit.gyp:
  • public/WebAttribute.h: Removed.
  • public/WebElement.h:
  • public/WebNamedNodeMap.h: Removed.
  • src/WebAttribute.cpp: Removed.
  • src/WebElement.cpp:
  • src/WebNamedNodeMap.cpp: Removed.
22:30 Changeset [114869] by commit-queue@webkit.org

.: [Gtk] Added MOZ_X11 build flag for TARGET_X11
[Qt] Added MOZ_X11 build flag for !embedded
[CMake] Added MOZ_X11 build flag for WTF_OS_UNIX
https://bugs.webkit.org/show_bug.cgi?id=40785

Patch by Sriram Neelakandan <sriram.neelakandan@gmail.com> on 2012-04-22
Reviewed by Anders Carlsson.

  • GNUmakefile.am:
  • Source/cmake/OptionsCommon.cmake:

Source/WebCore: Sync the MOZ_X11 changes from r14 of http://code.google.com/p/npapi-sdk/
also, modified required build flags for Qt,Gtk and CMake
[Qt] Added MOZ_X11 build flag for !embedded
https://bugs.webkit.org/show_bug.cgi?id=40785

Patch by Sriram Neelakandan <sriram.neelakandan@gmail.com> on 2012-04-22
Reviewed by Anders Carlsson.

No new tests. This does not change functionality. Affects all X11 Ports. Build should break if MOZ_X11 is not passed where required

  • WebCore.pri:
  • plugins/npapi.h:

Source/WebKit2: [Gtk] Added MOZ_X11 build flag for TARGET_X11
[Qt] Added MOZ_X11 build flag for !embedded
https://bugs.webkit.org/show_bug.cgi?id=40785

Patch by Sriram Neelakandan <sriram.neelakandan@gmail.com> on 2012-04-22
Reviewed by Anders Carlsson.

  • GNUmakefile.am:
  • Target.pri:

Tools: [Gtk] Added MOZ_X11 build flag for TARGET_X11
https://bugs.webkit.org/show_bug.cgi?id=40785

Patch by Sriram Neelakandan <sriram.neelakandan@gmail.com> on 2012-04-22
Reviewed by Anders Carlsson.

  • GNUmakefile.am:
22:22 Changeset [114868] by zandobersek@gmail.com

[TestResultsServer] Impossible to inspect builds on non-Chromium builders
https://bugs.webkit.org/show_bug.cgi?id=84544

Reviewed by Ryosuke Niwa.

Use the groupEnum parameter that is passed through to the onBuilderListLoad
function rather than an undefined attribute of the BuilderGroup object. This
makes it again possible to inspect builds on non-Chromium builders in the
test results server by not trying to always add Chromium revision links.

  • TestResultServer/static-dashboards/builders.js:
22:19 Changeset [114867] by commit-queue@webkit.org

Reset event propagation and canceled flags in Event.initEvent
https://bugs.webkit.org/show_bug.cgi?id=83964

Patch by Pablo Flouret <pablof@motorola.com> on 2012-04-22
Reviewed by Ryosuke Niwa.

Step 3 in http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#dom-event-initevent
Useful for re-configuring an event before dispatching.

Source/WebCore:

Test: fast/events/flags-unset-on-init-event.html

  • dom/Event.cpp:

(WebCore::Event::initEvent):

LayoutTests:

  • fast/events/flags-unset-on-init-event-expected.txt: Added.
  • fast/events/flags-unset-on-init-event.html: Added.
21:48 Changeset [114866] by hbono@chromium.org

Replace an undefined variable with a constant
https://bugs.webkit.org/show_bug.cgi?id=84427

Reviewed by Ryosuke Niwa.

Unfortunately, my r114605 uses an undefined variable 'sleepPeriod' and it
causes a JavaScript exception. This change replaces this variable with 1.

  • platform/chromium/editing/spelling/delete-misspelled-word.html:
19:13 Changeset [114865] by commit-queue@webkit.org

[GTK] Remove the obsolete Hildon UI extensions
https://bugs.webkit.org/show_bug.cgi?id=83420

Patch by Adrian Bunk <bunk@stusta.de> on 2012-04-22
Reviewed by Martin Robinson.

.:

  • configure.ac:

Source/WebKit/gtk:

  • GNUmakefile.am:
  • WebCoreSupport/EditorClientGtk.cpp:

(WebKit::EditorClient::setInputMethodState):

  • webkit/webkitwebview.cpp:

(webkit_web_view_button_release_event):

17:56 Changeset [114864] by mrobinson@webkit.org

[Cairo] Implement CompositeDifference
https://bugs.webkit.org/show_bug.cgi?id=77354

Reviewed by Alejandro G. Castro.

No new tests. The difference compositing operator are not exposed
to web content, so this change is simply in preparation for a time
in which it is used.

Properly map the difference compositing blend modes to a Cairo operator.

  • platform/graphics/cairo/CairoUtilities.cpp:

(WebCore::toCairoOperator): Add a mapping for difference. Remove
code supporting versions of Cairo before 1.10, since the Cairo backend
requires 1.10 or greater already.

16:01 Changeset [114863] by jonlee@apple.com

Remove notifications support on Mac Lion.
https://bugs.webkit.org/show_bug.cgi?id=84554
<rdar://problem/11297128>

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
15:27 Changeset [114862] by mnaganov@chromium.org

[Chromium] Fix clang build after r114827, unreviewed.

  • tests/LayerTextureUpdaterTest.cpp:

(WebCore::TEST):

14:52 Applications using WebKit edited by alexandre.morgaut@4d.com
add Wakanda server ina new Server section (diff)
14:37 Applications using WebKit edited by alexandre.morgaut@4d.com
add Wakanda studio in "Web Development Applications" section (diff)
14:27 Changeset [114861] by mnaganov@chromium.org

[Chromium] Unreviewed test expectations update.

Mark fast/canvas/2d.text.draw.fill.maxWidth.gradient.html as flaky on Mac 10.6

  • platform/chromium/test_expectations.txt:
14:17 Changeset [114860] by mnaganov@chromium.org

[Chromium] Unreviewed test expectations update.

fast/workers/storage/interrupt-database.html can also TIMEOUT in debug.

  • platform/chromium/test_expectations.txt:
14:06 Changeset [114859] by mnaganov@chromium.org

[Chromium] Unreviewed test expectations update.

css3/zoom-coords-expected.txt now passes on Mac
According to bot logs this is after <http://trac.webkit.org/changeset/114813>

  • platform/chromium-mac/css3/zoom-coords-expected.txt: Added.
13:58 April 2012 Meeting edited by tomz@codeaurora.org
(diff)
13:22 Changeset [114858] by shawnsingh@chromium.org

[chromium] Damage Tracker needs to use CCMathUtil transforms
https://bugs.webkit.org/show_bug.cgi?id=84070

Reviewed by Adrienne Walker.

Source/WebCore:

Unit test added to CCDamageTracker.cpp.

This patch makes CCDamageTracker use CCMathUtil transforms, so
that perspective w < 0 problem is correctly handled.

  • platform/graphics/chromium/cc/CCDamageTracker.cpp:

(WebCore::CCDamageTracker::extendDamageForLayer):
(WebCore::CCDamageTracker::extendDamageForRenderSurface):

Source/WebKit/chromium:

  • tests/CCDamageTrackerTest.cpp:

(WebKitTests::TEST_F):
(WebKitTests):

11:45 April 2012 Meeting edited by tomz@codeaurora.org
(diff)
11:44 April 2012 Meeting edited by tomz@codeaurora.org
(diff)
10:39 April 2012 Meeting edited by peter@chromium.org
Add link about the Web Component Model status-update notes in the right … (diff)
09:43 Changeset [114857] by commit-queue@webkit.org

[Qt] Multi-level tap-to-zoom.
https://bugs.webkit.org/show_bug.cgi?id=84456

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-22
Reviewed by Kenneth Rohde Christiansen.

Replace tap-to-zoomed flag with a stack of progressively higher zoom levels,
and zoom out to last zoom-level when attempting to zoom to current level.

Additionally detect a series of tap-to-zoom gestures on the same level and
continue to zoom out.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):

  • UIProcess/qt/QtViewportInteractionEngine.h:

(QtViewportInteractionEngine):

04/21/12:

18:36 Acronyms edited by tkent@chromium.org
Add DFG, NRWT, ORWT and WTF (diff)
18:26 Porting Macros plan edited by tkent@chromium.org
Remove obsolete ENABLE flag names (diff)
17:18 Changeset [114856] by cevans@google.com

Merge 112939
BUG=121524
Review URL: https://chromiumcodereview.appspot.com/10169026

17:18 Changeset [114855] by jonlee@apple.com

Add Notification constructor
https://bugs.webkit.org/show_bug.cgi?id=80477
<rdar://problem/10912431>

Reviewed by Jian Li.

Source/WebCore:

Tests will be added once there is support for web notifications on the Mac ports.

  • WebCore.exp.in: Export finalize() function.

Modify Dictionary to support creation of event listeners.

  • bindings/js/Dictionary.h:

(WebCore::Dictionary::isObject): Return true if the JSDictionary is valid.
(WebCore::Dictionary::isUndefinedOrNull): Return true if the JSDictionary is not valid.
(WebCore::Dictionary::get): Add convenience function to take const char* for
property name, to prevent having to do implicit conversion to WTF::String.
(WebCore::Dictionary::getEventListener): Add function to create event listener
from the dictionary.
(WebCore::Dictionary::asJSObject): Helper to convert WebCore objects to JS wrapper.

  • bindings/js/Dictionary.cpp:

(WebCore::Notification): Implement asJSObject() for Notification.

  • bindings/js/JSDictionary.h:

(WebCore::JSDictionary::execState): Expose the exec state so that the Dictionary
can obtain its world for creating the event listener.

  • bindings/v8/Dictionary.h:

(WebCore::Dictionary::getEventListener): Stub implementation.

Add new constructor to idl definitions.

  • notifications/DOMWindowNotifications.idl: Add Notification constructor, if

ENABLE(NOTIFICATIONS) is on.

  • notifications/Notification.idl: If ENABLE(NOTIFICATIONS) is turned on, define

the constructor. Otherwise, use OmitConstructor.

  • notifications/NotificationCenter.idl: Wrap creation functions in

ENABLE(LEGACY_NOTIFICATIONS).

  • notifications/NotificationCenter.h: Ditto.

(NotificationCenter):

  • notifications/Notification.h:

(Notification): Wrap legacy constructors in ENABLE(LEGACY_NOTIFICATIONS).
(WebCore::Notification::create): New creation function based on discussions in WG.

  • notifications/Notification.cpp:

(WebCore::getAndAddEventListener): Helper function to get the listener from the
dictionary, and attach to the notification.
(WebCore::Notification::create): Create the notification, then apply whatever
properties can be found in the dictionary to the notification. In order to
attach the event listeners, the notification has to have been created, which is
why this all happens in the factory method and not in the constructor.
(WebCore::Notification::setBody): Added so that it can be set if we find it in the
dictionary.

The new constructor queues a task to show when it is created. To support this, we
use a one-shot timer that calls show() in the next iteration of the run loop.
(WebCore::Notification::Notification): Start the timer.
(WebCore::Notification::showTaskTimerFired): Call show().

Notifications, not being attached to the DOM, could be GC'ed by the JS engine
before its life cycle has completed. We add calls to setPendingActivity() when the
notification has been shown, and when it is closed, we unsetPendingActivity().
To guarantee that we only call this once, we add a new state to the Notification
state machine, called NotificationState::Closed.
(WebCore::Notification::show): Call setPendingActivity() for all ports. Remove conditional on Mac.
(WebCore::Notification::close): Include Closed state to machine; do nothing.
(WebCore::Notification::dispatchCloseEvent): Call finalize().
(WebCore::Notification::finalize): If the state is not Closed, we unsetPendingActivity()
to make it available for GC.
(WebCore::Notification::finishLoading): Remove the unsetPendingActivity(). That call
was to balance the setPendingActivity() called for loading the icon. Instead of wrapping
around the icon load, we wrap around the show() -> finalize() loop.

In Notification, rename some of the stages and functions to more clearly communicate
that they mostly deal with the icon of the notification, instead of general loading.
(WebCore::Notification::show): Refactored to use LoadingIcon and CancelledIcon.
(WebCore::Notification::close): Refactored to use LoadingIcon and CancelledIcon.
(WebCore::Notification::~Notification): Refactor to use LoadingIcon.
(WebCore::Notification::startLoadingIcon): Renamed from startLoading().
(WebCore::Notification::stopLoadingIcon): Renamed from stopLoading().
(WebCore::Notification::finishLoadingIcon): Renamed from finishLoading().
(WebCore::Notification::didFinishLoading):
(WebCore::Notification::didFail):
(WebCore::Notification::didFailRedirectCheck):
(WebCore::Notification::didReceiveResponse):
(WebCore::Notification::finishLoading):

Add Dictionary.cpp.

  • GNUmakefile.list.am:
  • Target.pri:
  • UseJSC.cmake:
  • WebCore.gypi:

Fix bug in V8 bindings generation code. If the constructor doesn't raise an exception,
don't use an exception code.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateParametersCheck):

  • bindings/scripts/test/V8/V8TestObj.cpp: Reset results.

(WebCore::TestObjV8Internal::optionsObjectCallback):

Source/WebKit/mac:

  • WebCoreSupport/WebNotificationClient.mm:

(WebNotificationClient::clearNotifications): When clearing notifications, finalize
them so that they can be cleaned up by the GC.

Source/WebKit2:

  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::show): If the notification doesn't get shown,
we should return false, since it will not go through a setPendingActivity cycle.
(WebKit::WebNotificationManager::clearNotifications): When clearing notifications,
finalize them so that they can be cleaned up by the GC.

17:01 Changeset [114854] by cevans@google.com

Merge 112935
BUG=106413
Review URL: https://chromiumcodereview.appspot.com/10170019

16:59 Changeset [114853] by cevans@google.com

Merge 112935
BUG=106413
Review URL: https://chromiumcodereview.appspot.com/10164022

16:56 Changeset [114852] by cevans@google.com

Merge 113229
BUG=99229
Review URL: https://chromiumcodereview.appspot.com/10165023

16:54 Changeset [114851] by cevans@google.com

Merge 113670
BUG=117110
Review URL: https://chromiumcodereview.appspot.com/10170018

16:52 Changeset [114850] by cevans@google.com

Merge 113670
BUG=117110
Review URL: https://chromiumcodereview.appspot.com/10166026

16:19 Changeset [114849] by commit-queue@webkit.org

Don't hard code the plugins that blackberry supports.
https://bugs.webkit.org/show_bug.cgi?id=84535

Use the existing PluginDatabase to query for the plugins we can handle.

The original implemention of FrameLoaderClientBlackBerry::createPlugin
was a partial copy from another port. In the Qt port there is some
workarounds for flash which is why this exists there. Sadly the bits
that were copied made it so only flash worked, but as flash was the only
plugin on the system this issue was not noticed until QNX tried to get
jnext working. Tracing it down to this bit of code rather then
correcting it they hardcoded the jnext into the same block as flash was.

The blackberry port isn't specifically suppose to only allow jnext and
flash, but was an accident due to the way this code was developed.

Patch by Benjamin C Meyer <bmeyer@rim.com> on 2012-04-21
Reviewed by Adam Treat.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::createPlugin):

15:40 Changeset [114848] by commit-queue@webkit.org

Support loading the same plugin in multiple locations in the Blackberry port.
https://bugs.webkit.org/show_bug.cgi?id=84537

The hash for the plugin is only based upon the plugin meta information
which will be the same for the same plugin in the system and user's
plugin folders.

It looks like this code was copied/based on the windows port
which doesn't allow the same plugin to be loaded more than once.

Because we want to support multiple copies of the same plugin
in the blackberry port we want to incorperate the path of the plugin
into the hash.

PR 150404

Patch by Benjamin C Meyer <bmeyer@rim.com> on 2012-04-21
Reviewed by Adam Treat.

  • plugins/blackberry/PluginPackageBlackBerry.cpp:

(WebCore::PluginPackage::hash):

15:02 Changeset [114847] by rniwa@webkit.org

Chromium roll attempt from r133173 to r133348.

  • DEPS:
13:11 Changeset [114846] by commit-queue@webkit.org

System plugins are preferred over application plugins
https://bugs.webkit.org/show_bug.cgi?id=84538

Set the preferred paths for plugins so that plugins that reside
inside of the bar will be preferred over plugins that are in the
system folder.

PR 150404

Patch by Benjamin C Meyer <bmeyer@rim.com> on 2012-04-21
Reviewed by Adam Treat.

  • plugins/PluginDatabase.cpp:

(WebCore::PluginDatabase::isPreferredPluginDirectory):

13:03 Changeset [114845] by darin@apple.com

Change JavaScript lexer to use 0 instead of -1 for sentinel, eliminating the need to put characters into ints
https://bugs.webkit.org/show_bug.cgi?id=84523

Reviewed by Oliver Hunt.

Profiles showed that checks against -1 were costly, and I saw they could be eliminated.
Streamlined this code to use standard character types and 0 rather than -1. One benefit
of this is that there's no widening and narrowing. Another is that there are many cases
where we already have the correct behavior for 0, so can eliminate a branch that was
used to test for -1 before. Also eliminates typecasts in the code.

  • parser/Lexer.cpp:

(JSC::Lexer::invalidCharacterMessage): Updated use of String::format since m_current is now a
character type, not an int.
(JSC::Lexer::setCode): Use 0 rather than -1 when past the end.
(JSC::Lexer::shift): Ditto. Also spruced up the comment a bit.
(JSC::Lexer::atEnd): Added. New function that distinguishes an actual 0 character from the end
of the code. This can be used places we used to cheeck for -1.
(JSC::Lexer::peek): Updated to use -1 instead of 0. Removed meaningless comment.
(JSC::Lexer::parseFourDigitUnicodeHex): Changed to use character types instead of int.
(JSC::Lexer::shiftLineTerminator): Removed now-unneeded type casts. Changed local variable that
had a data-member-style name.
(JSC::Lexer::parseIdentifier): Removed now-unneeded explicit checks for -1, since the isIdentPart
function already returns false for the 0 character. Updated types in a couple other places. Used
the atEnd function where needed.
(JSC::Lexer::parseIdentifierSlowCase): More of the same.
(JSC::characterRequiresParseStringSlowCase): Added overloaded helper function for parseString.
(JSC::Lexer::parseString): Ditto.
(JSC::Lexer::parseStringSlowCase): Ditto.
(JSC::Lexer::parseMultilineComment): Ditto.
(JSC::Lexer::lex): More of the same. Also changed code to set the startOffset directly in
the tokenInfo instead of putting it in a local variable first, saving some memory access.
(JSC::Lexer::scanRegExp): Ditto.
(JSC::Lexer::skipRegExp): Ditto.

  • parser/Lexer.h: Changed return type of the peek function and type of m_current from int to

the character type. Added atEnd function.
(JSC::Lexer::setOffset): Used 0 instead of -1 and removed an overzealous attempt to optimize.
(JSC::Lexer::lexExpectIdentifier): Used 0 instead of -1.

12:46 Changeset [114844] by darin@apple.com

Change JavaScript lexer to use 0 instead of -1 for sentinel, eliminating the need to put characters into ints
https://bugs.webkit.org/show_bug.cgi?id=84523

Reviewed by Oliver Hunt.

Separate preparation step of copyright dates, renaming, and other small tweaks.

  • parser/Lexer.cpp:

(JSC::Lexer::invalidCharacterMessage): Removed "get" from name to match WebKit naming conventions.
(JSC::Lexer::peek): Removed meaningless comment.
(JSC::Lexer::parseFourDigitUnicodeHex): Renamed from getUnicodeCharacter to be more precise about
what this function does.
(JSC::Lexer::shiftLineTerminator): Renamed local variable that had a data-member-style name.
(JSC::Lexer::parseStringSlowCase): Updated for new name of parseFourDigitUnicodeHex.
(JSC::Lexer::lex): Updated for new name of invalidCharacterMessage.

  • parser/Lexer.h: Removed an unneeded forward declaration of the RegExp class.

Renamed getInvalidCharMessage to invalidCharacterMessage and made it const. Renamed
getUnicodeCharacter to parseFourDigitUnicodeHex.

09:43 Changeset [114843] by darin@apple.com

Improve performance of removing user and password from URLs
https://bugs.webkit.org/show_bug.cgi?id=84525

Reviewed by Dan Bernstein.

Performance improvement only. Correctness covered by existing regression tests.

The most common use of KURL::setUser and KURL::setPass, by far, is to remove
the user and password from a URL that already has neither. Optimize this by
not re-parsing the URL in that case.

  • platform/KURL.cpp:

(WebCore::KURL::setUser): Restructure code so that the code path that removes
the user does no work when there is nothing to remove. Otherwise, leave the
logic of the function untouched.
(WebCore::KURL::setPass): Same thing, only for password rather than user.

03:46 Changeset [114842] by zandobersek@gmail.com

Unreviewed - move some expectations added in r114839 to their proper location.

  • platform/gtk/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Copied from LayoutTests/platform/gtk/css2.1/abspos-containing-block-initial-007-expected.txt.
  • platform/gtk/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt: Copied from LayoutTests/platform/gtk/css2.1/abspos-non-replaced-width-margin-000-expected.txt.
  • platform/gtk/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt: Copied from LayoutTests/platform/gtk/css2.1/abspos-replaced-width-margin-000-expected.txt.
  • platform/gtk/css2.1/abspos-containing-block-initial-007-expected.txt: Removed.
  • platform/gtk/css2.1/abspos-non-replaced-width-margin-000-expected.txt: Removed.
  • platform/gtk/css2.1/abspos-replaced-width-margin-000-expected.txt: Removed.
  • platform/gtk/tables/bug137388-2-expected.txt: Removed.
  • platform/gtk/tables/bug29314-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug137388-2-expected.txt: Copied from LayoutTests/platform/gtk/tables/bug137388-2-expected.txt.
  • platform/gtk/tables/mozilla/bugs/bug29314-expected.txt: Copied from LayoutTests/platform/gtk/tables/bug29314-expected.txt.
01:49 Changeset [114841] by ossy@webkit.org

[Qt] Unreviewed weekend gardening, skip new failing reftests.

  • platform/qt/Skipped:
01:37 Changeset [114840] by ossy@webkit.org

Unreviewed gardening after r114766.

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/svg/css/getComputedStyle-basic-expected.txt:
00:21 Changeset [114839] by mrobinson@webkit.org

Rebaseline the last set of GTK+ tests after font metrics and mock scrollbar changes.

  • platform/gtk: Rebaseline tests.

04/20/12:

23:24 Changeset [114838] by philn@webkit.org

Unreviewed, GTK svg rebaseline after r114799.

22:14 Changeset [114837] by commit-queue@webkit.org

Unreviewed, rolling out r114768.
http://trac.webkit.org/changeset/114768
https://bugs.webkit.org/show_bug.cgi?id=84521

Original patch was not the problem, re-applying (Requested by
pfeldman_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-20

  • bindings/v8/V8IsolatedContext.cpp:

(WebCore::setInjectedScriptContextDebugId):
(WebCore):
(WebCore::V8IsolatedContext::V8IsolatedContext):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::evaluateInIsolatedWorld):

  • bindings/v8/V8Proxy.h:

(V8Proxy):

20:22 April 2012 Meeting edited by dglazkov@chromium.org
(diff)
20:19 ShadowDOMDesignathon created by dglazkov@chromium.org
20:07 Changeset [114836] by kov@webkit.org

Rebaseline more GTK tests after <http://trac.webkit.org/changeset/114799>.

19:51 Changeset [114835] by timothy@apple.com

Make the Web Inspector be the first responder when opening docked.

<rdar://problem/11294217>

Reviewed by Brian Weinstein.

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.mm:

(-[WebInspectorWindowController showWindow:]): Call makeFirstResponder: on
the window and pass the Inspector's WebView.

Source/WebKit2:

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformAttach): Call makeFirstResponder: on
the window and pass the Inspector's WKView.

19:27 Changeset [114834] by kov@webkit.org

Undoing undesired changes.

  • fast/block/float/008-expected.txt:
  • fast/block/float/019-expected.txt:
  • fast/block/float/035-expected.txt:
  • fast/block/float/relative-painted-twice-expected.txt:
  • fast/block/positioning/negative-rel-position-expected.txt:
  • fast/canvas/canvas-bg-expected.txt:
  • fast/css-generated-content/table-parts-before-and-after-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/flexbox/flex-hang-expected.txt:
  • fast/forms/file/get-file-upload-expected.txt:
  • fast/forms/select/listbox-in-multi-column-expected.txt:
19:23 Apr2012WebKitMeetingGrp.jpg attached to April 2012 Meeting by kaustubh@motorola.com
Apr 2012 Webkit Meeting Group Photo (Little larger size)
19:21 Changeset [114833] by kov@webkit.org

Rebaseline more GTK fast tests after <http://trac.webkit.org/changeset/114799>.

19:19 Changeset [114832] by dbates@webkit.org

Rebaseline more GTK CSS3 and editing tests after <http://trac.webkit.org/changeset/114799>.

19:10 Changeset [114831] by dbates@webkit.org

Rebaseline more GTK CSS2.1 tests after <http://trac.webkit.org/changeset/114799>.

19:05 Changeset [114830] by kov@webkit.org

Rebaseline more GTK editing, fast tests after <http://trac.webkit.org/changeset/114799>.

19:01 Changeset [114829] by dbates@webkit.org

Rebaseline more GTK CSS3 and animation tests after <http://trac.webkit.org/changeset/114799>.

18:50 Changeset [114828] by dbates@webkit.org

Rebaseline more GTK CSS2.1 tests after <http://trac.webkit.org/changeset/114799>.

18:48 Changeset [114827] by enne@google.com

[chromium] Refactor opaque content transform out of Skia context
https://bugs.webkit.org/show_bug.cgi?id=83608

Reviewed by James Robinson.

Source/WebCore:

Having PlatformContextSkia know about the transform into content space
for a layer is a layering violation. This change lets the
PlatformContextSkia deal with opaque rects in its own space and lets
the caller handle transforming it into its own space. This also
prevents a matrix multiply per draw into the Skia canvas and does it
just once at the end to transform the final rect.

This is an incremental refactoring so that additional tracking for
text rects can be added and use the same space as opaque rects.

Tests: LayerTextureUpdaterTest.testPartialOpaqueRectNoTransform

LayerTextureUpdaterTest.testPartialOpaqueRectTranslation
LayerTextureUpdaterTest.testPartialOpaqueRectScale

  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapCanvasLayerTextureUpdater::prepareToUpdate):

  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:

(BitmapCanvasLayerTextureUpdater):

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::prepareToUpdate):

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:

(BitmapSkPictureCanvasLayerTextureUpdater):

  • platform/graphics/chromium/CanvasLayerTextureUpdater.cpp:

(WebCore::CanvasLayerTextureUpdater::paintContents):

  • platform/graphics/chromium/CanvasLayerTextureUpdater.h:

(CanvasLayerTextureUpdater):

  • platform/graphics/chromium/LayerTextureUpdater.h:

(WebCore::LayerTextureUpdater::prepareToUpdate):

  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::SkPictureCanvasLayerTextureUpdater::prepareToUpdate):

  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h:

(SkPictureCanvasLayerTextureUpdater):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateTiles):

  • platform/graphics/skia/OpaqueRegionSkia.cpp:

(WebCore::OpaqueRegionSkia::didDrawRect):
(WebCore::OpaqueRegionSkia::didDrawPath):
(WebCore::OpaqueRegionSkia::didDrawPoints):
(WebCore::OpaqueRegionSkia::didDrawBounded):
(WebCore::OpaqueRegionSkia::didDraw):

  • platform/graphics/skia/OpaqueRegionSkia.h:

(OpaqueRegionSkia):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::didDrawRect):
(WebCore::PlatformContextSkia::didDrawPath):
(WebCore::PlatformContextSkia::didDrawPoints):
(WebCore::PlatformContextSkia::didDrawBounded):

  • platform/graphics/skia/PlatformContextSkia.h:

(PlatformContextSkia):

Source/WebKit/chromium:

Add tests for opaque tracking in LayerTextureUpdater, since the
transform logic has moved there.

  • tests/CCTiledLayerTestCommon.cpp:

(WebKitTests::FakeLayerTextureUpdater::prepareToUpdate):

  • tests/CCTiledLayerTestCommon.h:

(FakeLayerTextureUpdater):

  • tests/LayerTextureUpdaterTest.cpp:

(WebCore::PaintFillPartialOpaque::PaintFillPartialOpaque):
(PaintFillPartialOpaque):
(WebCore::PaintFillPartialOpaque::operator()):
(WebCore):
(WebCore::TEST):

  • tests/PlatformContextSkiaTest.cpp:

(WebCore::TEST):

18:45 Changeset [114826] by kov@webkit.org

Rebaseline more GTK editing, dom, fast tests after <http://trac.webkit.org/changeset/114799>.

18:43 Changeset [114825] by dbates@webkit.org

Rebaseline more GTK CSS3 tests after <http://trac.webkit.org/changeset/114799>.

18:43 Acronyms edited by yosin@chromium.org
(diff)
18:36 Changeset [114824] by kov@webkit.org

Rebaseline more GTK fast/block tests after <http://trac.webkit.org/changeset/114799>.

18:34 Changeset [114823] by dbates@webkit.org

Rebaseline more GTK css1 tests after <http://trac.webkit.org/changeset/114799>.

18:30 Changeset [114822] by dbates@webkit.org

Rebaseline more GTK css2.1 tests after <http://trac.webkit.org/changeset/114799>.

18:25 Changeset [114821] by kov@webkit.org

Rebaseline more GTK css3 and editing tests after <http://trac.webkit.org/changeset/114799>.

18:22 Changeset [114820] by dbates@webkit.org

Rebaseline GTK fast/block tests after <http://trac.webkit.org/changeset/114799>.

  • platform/gtk/fast/block/float/001-expected.txt:
  • platform/gtk/fast/block/float/002-expected.txt:
  • platform/gtk/fast/block/float/003-expected.txt:
  • platform/gtk/fast/block/float/004-expected.txt:
  • platform/gtk/fast/block/float/005-expected.txt:
  • platform/gtk/fast/block/float/006-expected.txt:
  • platform/gtk/fast/block/float/007-expected.txt:
  • platform/gtk/fast/block/float/010-expected.txt:
  • platform/gtk/fast/block/float/011-expected.txt:
  • platform/gtk/fast/block/float/012-expected.txt:
  • platform/gtk/fast/block/float/013-expected.txt:
  • platform/gtk/fast/block/float/014-expected.txt:
  • platform/gtk/fast/block/float/015-expected.txt:
  • platform/gtk/fast/block/float/016-expected.txt:
  • platform/gtk/fast/block/float/017-expected.txt:
  • platform/gtk/fast/block/float/018-expected.txt:
  • platform/gtk/fast/block/margin-collapse/001-expected.txt:
  • platform/gtk/fast/block/margin-collapse/002-expected.txt:
  • platform/gtk/fast/block/margin-collapse/003-expected.txt:
  • platform/gtk/fast/block/margin-collapse/004-expected.txt:
  • platform/gtk/fast/block/margin-collapse/005-expected.txt:
  • platform/gtk/fast/block/margin-collapse/006-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/001-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/002-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/003-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/004-expected.txt:
18:19 Acronyms edited by yosin@chromium.org
Add JNI, NP, XC (diff)
18:17 Changeset [114819] by kov@webkit.org

Rebasing fast/background results after r114799.

18:12 Changeset [114818] by dbates@webkit.org

Rebaseline more GTK css1 tests after <http://trac.webkit.org/changeset/114799>.

  • platform/gtk/css1/box_properties/border_width_inline-expected.txt:
  • platform/gtk/css1/box_properties/clear-expected.txt:
  • platform/gtk/css1/box_properties/clear_float-expected.txt:
  • platform/gtk/css1/box_properties/float-expected.txt:
  • platform/gtk/css1/box_properties/float_margin-expected.txt:
  • platform/gtk/css1/box_properties/float_on_text_elements-expected.txt:
  • platform/gtk/css1/box_properties/height-expected.txt:
  • platform/gtk/css1/box_properties/margin-expected.txt:
  • platform/gtk/css1/box_properties/margin_bottom-expected.txt:
  • platform/gtk/css1/box_properties/margin_bottom_inline-expected.txt:
  • platform/gtk/css1/box_properties/margin_inline-expected.txt:
  • platform/gtk/css1/box_properties/margin_left-expected.txt:
  • platform/gtk/css1/box_properties/margin_left_inline-expected.txt:
  • platform/gtk/css1/box_properties/margin_right-expected.txt:
  • platform/gtk/css1/box_properties/margin_right_inline-expected.txt:
  • platform/gtk/css1/box_properties/margin_top-expected.txt:
  • platform/gtk/css1/box_properties/margin_top_inline-expected.txt:
18:08 Changeset [114817] by enrica@apple.com

CRASH at WebCore::ReplaceSelectionCommand::removeRedundantMarkup
https://bugs.webkit.org/show_bug.cgi?id=84518
<rdar://problem/10714790>

Reviewed by Simon Fraser.

Source/WebCore:

There are cases where the m_lastNodeInserted is NULL to begin with or
gets deleted by removeRedundantStylesAndKeepStyleSpanInline.
This change handles those cases properly.

Tests: editing/pasteboard/paste-sanitize-crash-1.html

editing/pasteboard/paste-sanitize-crash-2.html

  • editing/ReplaceSelectionCommand.h:

(WebCore::ReplaceSelectionCommand::InsertedNodes::pastLastLeaf):

  • editing/SimplifyMarkupCommand.cpp:

(WebCore::SimplifyMarkupCommand::doApply):

LayoutTests:

  • editing/pasteboard/paste-sanitize-crash-1-expected.txt: Added.
  • editing/pasteboard/paste-sanitize-crash-1.html: Added.
  • editing/pasteboard/paste-sanitize-crash-2-expected.txt: Added.
  • editing/pasteboard/paste-sanitize-crash-2.html: Added.
18:06 Changeset [114816] by kov@webkit.org

Rebasing editing results after r114799.

Baselines for more of css2.1 and dom.

18:03 Acronyms edited by yosin@chromium.org
Update CF and add UUID (diff)
18:03 Changeset [114815] by dbates@webkit.org

Rebaseline GTK animations tests after <http://trac.webkit.org/changeset/114799>.

  • platform/gtk/animations/cross-fade-background-image-expected.txt:
  • platform/gtk/animations/cross-fade-border-image-source-expected.txt:
  • platform/gtk/animations/cross-fade-list-style-image-expected.txt:
  • platform/gtk/animations/cross-fade-webkit-mask-box-image-expected.txt:
  • platform/gtk/animations/cross-fade-webkit-mask-image-expected.txt:
18:02 Changeset [114814] by michaeln@google.com

[chromium] Tiny change to DomStorage v8 bindings to avoid a relatively expensive test in a couple
of places by reordering the expressions in compound conditions, if (fastTest && moreExpensiveTest)
https://bugs.webkit.org/show_bug.cgi?id=84500

Reviewed by Kentaro Hara.

No new tests, no new functionality.

  • bindings/v8/custom/V8StorageCustom.cpp:

(WebCore::storageGetter):
(WebCore::V8Storage::namedPropertyQuery):

17:59 Acronyms edited by yosin@chromium.org
(diff)
17:58 Changeset [114813] by mitz@apple.com

REGRESSION (r114784): svg/text/foreignObject-text-clipping-bug.xml failing on Mountain Lion Debug Tests
https://bugs.webkit.org/show_bug.cgi?id=84505

Reviewed by Anders Carlsson.

Source/WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::blockBeforeWithinSelectionRoot): Changed to not assume that boxes only
have boxes as siblings.

LayoutTests:

  • platform/mac/test_expectations.txt:
17:56 Changeset [114812] by kov@webkit.org

Rebaseline GTK CSS1 tests after <http://trac.webkit.org/changeset/114799>.

Patch by Daniel Bates <dbates@webkit.org> on 2012-04-20

  • platform/gtk/css1/basic/class_as_selector-expected.txt:
  • platform/gtk/css1/basic/comments-expected.txt:
  • platform/gtk/css1/basic/containment-expected.txt:
  • platform/gtk/css1/basic/contextual_selectors-expected.txt:
  • platform/gtk/css1/basic/grouping-expected.txt:
  • platform/gtk/css1/basic/id_as_selector-expected.txt:
  • platform/gtk/css1/basic/inheritance-expected.txt:
  • platform/gtk/css1/box_properties/acid_test-expected.txt:
  • platform/gtk/css1/box_properties/border-expected.txt:
  • platform/gtk/css1/box_properties/border_bottom-expected.txt:
  • platform/gtk/css1/box_properties/border_bottom_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_bottom_width-expected.txt:
  • platform/gtk/css1/box_properties/border_bottom_width_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_color-expected.txt:
  • platform/gtk/css1/box_properties/border_color_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_left-expected.txt:
  • platform/gtk/css1/box_properties/border_left_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_left_width-expected.txt:
  • platform/gtk/css1/box_properties/border_left_width_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_right-expected.txt:
  • platform/gtk/css1/box_properties/border_right_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_right_width-expected.txt:
  • platform/gtk/css1/box_properties/border_right_width_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_style-expected.txt:
  • platform/gtk/css1/box_properties/border_style_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_top-expected.txt:
  • platform/gtk/css1/box_properties/border_top_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_top_width-expected.txt:
  • platform/gtk/css1/box_properties/border_top_width_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_width-expected.txt:
  • platform/gtk/css1/cascade/cascade_order-expected.txt:
  • platform/gtk/css1/cascade/important-expected.txt:
  • platform/gtk/css1/classification/display-expected.txt:
  • platform/gtk/css1/classification/list_style-expected.txt:
  • platform/gtk/css1/classification/list_style_image-expected.txt:
  • platform/gtk/css1/classification/list_style_position-expected.txt:
  • platform/gtk/css1/classification/list_style_type-expected.txt:
  • platform/gtk/css1/classification/white_space-expected.txt:
  • platform/gtk/css1/color_and_background/background-expected.txt:
  • platform/gtk/css1/color_and_background/background_attachment-expected.txt:
  • platform/gtk/css1/color_and_background/background_color-expected.txt:
  • platform/gtk/css1/color_and_background/background_image-expected.txt:
  • platform/gtk/css1/color_and_background/background_position-expected.txt:
  • platform/gtk/css1/color_and_background/background_repeat-expected.txt:
  • platform/gtk/css1/color_and_background/color-expected.txt:
  • platform/gtk/css1/conformance/forward_compatible_parsing-expected.txt:
  • platform/gtk/css1/font_properties/font-expected.txt:
  • platform/gtk/css1/font_properties/font_family-expected.txt:
  • platform/gtk/css1/font_properties/font_size-expected.txt:
  • platform/gtk/css1/font_properties/font_style-expected.txt:
  • platform/gtk/css1/font_properties/font_variant-expected.txt:
  • platform/gtk/css1/font_properties/font_weight-expected.txt:
  • platform/gtk/css1/formatting_model/canvas-expected.txt:
  • platform/gtk/css1/formatting_model/floating_elements-expected.txt:
  • platform/gtk/css1/formatting_model/height_of_lines-expected.txt:
  • platform/gtk/css1/formatting_model/horizontal_formatting-expected.txt:
  • platform/gtk/css1/formatting_model/inline_elements-expected.txt:
  • platform/gtk/css1/formatting_model/replaced_elements-expected.txt:
  • platform/gtk/css1/formatting_model/vertical_formatting-expected.txt:
  • platform/gtk/css1/pseudo/anchor-expected.txt:
  • platform/gtk/css1/pseudo/firstletter-expected.txt:
  • platform/gtk/css1/pseudo/firstline-expected.txt:
  • platform/gtk/css1/pseudo/multiple_pseudo_elements-expected.txt:
  • platform/gtk/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
  • platform/gtk/css1/text_properties/letter_spacing-expected.txt:
  • platform/gtk/css1/text_properties/line_height-expected.txt:
  • platform/gtk/css1/text_properties/text_align-expected.txt:
  • platform/gtk/css1/text_properties/text_decoration-expected.txt:
  • platform/gtk/css1/text_properties/text_indent-expected.txt:
  • platform/gtk/css1/text_properties/text_transform-expected.txt:
  • platform/gtk/css1/text_properties/vertical_align-expected.txt:
  • platform/gtk/css1/text_properties/word_spacing-expected.txt:
  • platform/gtk/css1/units/color_units-expected.txt:
  • platform/gtk/css1/units/length_units-expected.txt:
  • platform/gtk/css1/units/percentage_units-expected.txt:
  • platform/gtk/css1/units/urls-expected.txt:
17:50 Changeset [114811] by dbates@webkit.org

Rebaseline GTK CSS1 tests after <http://trac.webkit.org/changeset/114799>.

  • platform/gtk/css1/basic/class_as_selector-expected.txt:
  • platform/gtk/css1/basic/comments-expected.txt:
  • platform/gtk/css1/basic/containment-expected.txt:
  • platform/gtk/css1/basic/contextual_selectors-expected.txt:
  • platform/gtk/css1/basic/grouping-expected.txt:
  • platform/gtk/css1/basic/id_as_selector-expected.txt:
  • platform/gtk/css1/basic/inheritance-expected.txt:
  • platform/gtk/css1/box_properties/acid_test-expected.txt:
  • platform/gtk/css1/box_properties/border-expected.txt:
  • platform/gtk/css1/box_properties/border_bottom-expected.txt:
  • platform/gtk/css1/box_properties/border_bottom_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_bottom_width-expected.txt:
  • platform/gtk/css1/box_properties/border_bottom_width_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_color-expected.txt:
  • platform/gtk/css1/box_properties/border_color_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_left-expected.txt:
  • platform/gtk/css1/box_properties/border_left_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_left_width-expected.txt:
  • platform/gtk/css1/box_properties/border_left_width_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_right-expected.txt:
  • platform/gtk/css1/box_properties/border_right_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_right_width-expected.txt:
  • platform/gtk/css1/box_properties/border_right_width_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_style-expected.txt:
  • platform/gtk/css1/box_properties/border_style_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_top-expected.txt:
  • platform/gtk/css1/box_properties/border_top_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_top_width-expected.txt:
  • platform/gtk/css1/box_properties/border_top_width_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_width-expected.txt:
  • platform/gtk/css1/cascade/cascade_order-expected.txt:
  • platform/gtk/css1/cascade/important-expected.txt:
  • platform/gtk/css1/classification/display-expected.txt:
  • platform/gtk/css1/classification/list_style-expected.txt:
  • platform/gtk/css1/classification/list_style_image-expected.txt:
  • platform/gtk/css1/classification/list_style_position-expected.txt:
  • platform/gtk/css1/classification/list_style_type-expected.txt:
  • platform/gtk/css1/classification/white_space-expected.txt:
  • platform/gtk/css1/color_and_background/background-expected.txt:
  • platform/gtk/css1/color_and_background/background_attachment-expected.txt:
  • platform/gtk/css1/color_and_background/background_color-expected.txt:
  • platform/gtk/css1/color_and_background/background_image-expected.txt:
  • platform/gtk/css1/color_and_background/background_position-expected.txt:
  • platform/gtk/css1/color_and_background/background_repeat-expected.txt:
  • platform/gtk/css1/color_and_background/color-expected.txt:
  • platform/gtk/css1/conformance/forward_compatible_parsing-expected.txt:
  • platform/gtk/css1/font_properties/font-expected.txt:
  • platform/gtk/css1/font_properties/font_family-expected.txt:
  • platform/gtk/css1/font_properties/font_size-expected.txt:
  • platform/gtk/css1/font_properties/font_style-expected.txt:
  • platform/gtk/css1/font_properties/font_variant-expected.txt:
  • platform/gtk/css1/font_properties/font_weight-expected.txt:
  • platform/gtk/css1/formatting_model/canvas-expected.txt:
  • platform/gtk/css1/formatting_model/floating_elements-expected.txt:
  • platform/gtk/css1/formatting_model/height_of_lines-expected.txt:
  • platform/gtk/css1/formatting_model/horizontal_formatting-expected.txt:
  • platform/gtk/css1/formatting_model/inline_elements-expected.txt:
  • platform/gtk/css1/formatting_model/replaced_elements-expected.txt:
  • platform/gtk/css1/formatting_model/vertical_formatting-expected.txt:
  • platform/gtk/css1/pseudo/anchor-expected.txt:
  • platform/gtk/css1/pseudo/firstletter-expected.txt:
  • platform/gtk/css1/pseudo/firstline-expected.txt:
  • platform/gtk/css1/pseudo/multiple_pseudo_elements-expected.txt:
  • platform/gtk/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
  • platform/gtk/css1/text_properties/letter_spacing-expected.txt:
  • platform/gtk/css1/text_properties/line_height-expected.txt:
  • platform/gtk/css1/text_properties/text_align-expected.txt:
  • platform/gtk/css1/text_properties/text_decoration-expected.txt:
  • platform/gtk/css1/text_properties/text_indent-expected.txt:
  • platform/gtk/css1/text_properties/text_transform-expected.txt:
  • platform/gtk/css1/text_properties/vertical_align-expected.txt:
  • platform/gtk/css1/text_properties/word_spacing-expected.txt:
  • platform/gtk/css1/units/color_units-expected.txt:
  • platform/gtk/css1/units/length_units-expected.txt:
  • platform/gtk/css1/units/percentage_units-expected.txt:
  • platform/gtk/css1/units/urls-expected.txt:
17:38 Acronyms created by yosin@chromium.org
17:33 Changeset [114810] by kov@webkit.org

Rebasing editing results after r114799.

  • platform/gtk/editing/deleting/4922367-expected.txt:
  • platform/gtk/editing/deleting/5099303-expected.txt:
  • platform/gtk/editing/deleting/5126166-expected.txt:
  • platform/gtk/editing/deleting/5144139-2-expected.txt:
  • platform/gtk/editing/deleting/5206311-1-expected.txt:
  • platform/gtk/editing/deleting/5272440-expected.txt:
  • platform/gtk/editing/deleting/5369009-expected.txt:
  • platform/gtk/editing/deleting/5433862-2-expected.txt:
  • platform/gtk/editing/deleting/5483370-expected.txt:
  • platform/gtk/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-3608445-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-3608462-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-3775172-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-3800834-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-3857753-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-3865854-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-3928305-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-3959464-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-4083333-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-after-span-ws-001-expected.txt:
  • platform/gtk/editing/deleting/delete-after-span-ws-002-expected.txt:
  • platform/gtk/editing/deleting/delete-after-span-ws-003-expected.txt:
  • platform/gtk/editing/deleting/delete-and-undo-expected.txt:
  • platform/gtk/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
  • platform/gtk/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
  • platform/gtk/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
  • platform/gtk/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
  • platform/gtk/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
  • platform/gtk/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
  • platform/gtk/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
  • platform/gtk/editing/execCommand/4580583-1-expected.txt:
  • platform/gtk/editing/execCommand/4580583-2-expected.txt:
  • platform/gtk/editing/execCommand/4641880-1-expected.txt:
  • platform/gtk/editing/execCommand/4641880-2-expected.txt:
  • platform/gtk/editing/execCommand/4747450-expected.txt:
  • platform/gtk/editing/execCommand/4916402-expected.txt:
  • platform/gtk/editing/execCommand/4916541-expected.txt:
  • platform/gtk/editing/execCommand/4924441-expected.txt:
  • platform/gtk/editing/execCommand/5080333-1-expected.txt:
  • platform/gtk/editing/execCommand/5080333-2-expected.txt:
  • platform/gtk/editing/execCommand/5136770-expected.txt:
  • platform/gtk/editing/execCommand/5138441-expected.txt:
  • platform/gtk/editing/execCommand/5142012-1-expected.txt:
  • platform/gtk/editing/execCommand/5142012-2-expected.txt:
  • platform/gtk/editing/execCommand/5190926-expected.txt:
  • platform/gtk/editing/execCommand/5481523-expected.txt:
  • platform/gtk/editing/execCommand/5482023-expected.txt:
  • platform/gtk/editing/execCommand/5569741-expected.txt:
  • platform/gtk/editing/execCommand/create-list-with-hr-expected.txt:
  • platform/gtk/editing/input/caret-at-the-edge-of-contenteditable-expected.txt:
  • platform/gtk/editing/input/caret-at-the-edge-of-input-expected.txt:
  • platform/gtk/editing/input/emacs-ctrl-o-expected.txt:
  • platform/gtk/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt:
  • platform/gtk/editing/input/reveal-caret-of-multiline-input-expected.txt:
  • platform/gtk/editing/inserting/12882-expected.txt:
  • platform/gtk/editing/inserting/4278698-expected.txt:
  • platform/gtk/editing/inserting/4840662-expected.txt:
  • platform/gtk/editing/inserting/4875189-1-expected.txt:
  • platform/gtk/editing/inserting/4875189-2-expected.txt:
  • platform/gtk/editing/inserting/4959067-expected.txt:
  • platform/gtk/editing/inserting/4960120-1-expected.txt:
  • platform/gtk/editing/inserting/4960120-2-expected.txt:
  • platform/gtk/editing/inserting/5002441-expected.txt:
  • platform/gtk/editing/inserting/5058163-1-expected.txt:
  • platform/gtk/editing/inserting/5058163-2-expected.txt:
  • platform/gtk/editing/inserting/5156401-2-expected.txt:
  • platform/gtk/editing/inserting/5418891-expected.txt:
  • platform/gtk/editing/inserting/5510537-expected.txt:
  • platform/gtk/editing/inserting/5549929-2-expected.txt:
  • platform/gtk/editing/inserting/5549929-3-expected.txt:
  • platform/gtk/editing/inserting/6703873-expected.txt:
  • platform/gtk/editing/inserting/before-after-input-element-expected.txt:
  • platform/gtk/editing/inserting/break-blockquote-after-delete-expected.txt:
  • platform/gtk/editing/inserting/editable-html-element-expected.txt:
  • platform/gtk/editing/inserting/editable-inline-element-expected.txt:
  • platform/gtk/editing/inserting/edited-whitespace-1-expected.txt:
  • platform/gtk/editing/inserting/editing-empty-divs-expected.txt:
  • platform/gtk/editing/inserting/insert-3654864-fix-expected.txt:
  • platform/gtk/editing/inserting/insert-3775316-fix-expected.txt:
  • platform/gtk/editing/inserting/insert-3778059-fix-expected.txt:
  • platform/gtk/editing/inserting/insert-3800346-fix-expected.txt:
  • platform/gtk/editing/inserting/insert-3851164-fix-expected.txt:
  • platform/gtk/editing/inserting/insert-after-delete-001-expected.txt:
  • platform/gtk/editing/inserting/insert-at-end-01-expected.txt:
  • platform/gtk/editing/inserting/insert-at-end-02-expected.txt:
  • platform/gtk/editing/pasteboard/3976872-expected.txt:
  • platform/gtk/editing/pasteboard/4076267-2-expected.txt:
  • platform/gtk/editing/pasteboard/4076267-3-expected.txt:
  • platform/gtk/editing/pasteboard/4076267-expected.txt:
  • platform/gtk/editing/pasteboard/4242293-expected.txt:
  • platform/gtk/editing/pasteboard/4631972-expected.txt:
  • platform/gtk/editing/pasteboard/4641033-expected.txt:
  • platform/gtk/editing/pasteboard/4806874-expected.txt:
  • platform/gtk/editing/pasteboard/4944770-1-expected.txt:
  • platform/gtk/editing/pasteboard/4944770-2-expected.txt:
  • platform/gtk/editing/pasteboard/4947130-expected.txt:
  • platform/gtk/editing/pasteboard/7955-expected.txt:
  • platform/gtk/editing/pasteboard/8145-1-expected.txt:
  • platform/gtk/editing/pasteboard/8145-2-expected.txt:
  • platform/gtk/editing/pasteboard/8145-3-expected.txt:
  • platform/gtk/editing/selection/13804-expected.txt:
  • platform/gtk/editing/selection/14971-expected.txt:
  • platform/gtk/editing/selection/3690703-2-expected.txt:
  • platform/gtk/editing/selection/3690703-expected.txt:
  • platform/gtk/editing/selection/3690719-expected.txt:
  • platform/gtk/editing/selection/4397952-expected.txt:
  • platform/gtk/editing/selection/4402375-expected.txt:
  • platform/gtk/editing/selection/4776665-expected.txt:
  • platform/gtk/editing/selection/4818145-expected.txt:
  • platform/gtk/editing/selection/4866671-expected.txt:
  • platform/gtk/editing/selection/4889598-expected.txt:
  • platform/gtk/editing/selection/6476-expected.txt:
  • platform/gtk/editing/selection/7152-1-expected.txt:
  • platform/gtk/editing/selection/7152-2-expected.txt:
  • platform/gtk/editing/style/4916887-expected.txt:
  • platform/gtk/editing/style/5017613-1-expected.txt:
  • platform/gtk/editing/style/5017613-2-expected.txt:
  • platform/gtk/editing/style/5046875-1-expected.txt:
  • platform/gtk/editing/style/5046875-2-expected.txt:
  • platform/gtk/editing/style/5065910-expected.txt:
  • platform/gtk/editing/style/5084241-expected.txt:
  • platform/gtk/editing/style/5228141-expected.txt:
  • platform/gtk/editing/style/5279521-expected.txt:
  • platform/gtk/editing/style/apple-style-editable-mix-expected.txt:
  • platform/gtk/editing/style/block-style-001-expected.txt:
  • platform/gtk/editing/style/block-style-002-expected.txt:
  • platform/gtk/editing/style/block-style-003-expected.txt:
  • platform/gtk/editing/style/block-styles-007-expected.txt:
  • platform/gtk/editing/style/create-block-for-style-001-expected.txt:
  • platform/gtk/editing/style/create-block-for-style-002-expected.txt:
  • platform/gtk/editing/style/create-block-for-style-003-expected.txt:
  • platform/gtk/editing/style/create-block-for-style-004-expected.txt:
  • platform/gtk/editing/undo/4063751-expected.txt:
  • platform/gtk/editing/undo/redo-typing-001-expected.txt:
  • platform/gtk/editing/undo/undo-combined-delete-boundary-expected.txt:
  • platform/gtk/editing/undo/undo-combined-delete-expected.txt:
  • platform/gtk/editing/undo/undo-delete-boundary-expected.txt:
  • platform/gtk/editing/undo/undo-delete-expected.txt:
  • platform/gtk/editing/undo/undo-forward-delete-boundary-expected.txt:
  • platform/gtk/editing/undo/undo-forward-delete-expected.txt:
  • platform/gtk/editing/unsupported-content/list-delete-001-expected.txt:
  • platform/gtk/editing/unsupported-content/list-delete-003-expected.txt:
  • platform/gtk/editing/unsupported-content/list-type-after-expected.txt:
  • platform/gtk/editing/unsupported-content/list-type-before-expected.txt:
  • platform/gtk/editing/unsupported-content/table-delete-001-expected.txt:
  • platform/gtk/editing/unsupported-content/table-delete-002-expected.txt:
17:31 Changeset [114809] by fpizlo@apple.com

DFG should optimize int8 and int16 arrays on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=84503

Reviewed by Oliver Hunt.

  • assembler/ARMv7Assembler.h:

(ARMv7Assembler):
(JSC::ARMv7Assembler::ldrsb):
(JSC::ARMv7Assembler::ldrsh):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::load16Signed):
(JSC::MacroAssemblerARMv7::load8Signed):

  • bytecode/PredictedType.h:

(JSC::isActionableIntMutableArrayPrediction):

  • dfg/DFGNode.h:

(JSC::DFG::Node::shouldSpeculateInt8Array):
(JSC::DFG::Node::shouldSpeculateInt16Array):

17:27 Changeset [114808] by danakj@chromium.org

[chromium] Remove special case for recreating layers during sync
https://bugs.webkit.org/show_bug.cgi?id=84458

Reviewed by James Robinson.

Source/WebCore:

We no longer delete layers on the impl side, unless it is due to
deleting the layer on webkit side. So we will no longer have a
situation where we need to push properties from an old
LayerChromium to a new CCLayerImpl.

  • platform/graphics/chromium/TreeSynchronizer.cpp:

(WebCore::TreeSynchronizer::reuseOrCreateCCLayerImpl):

Source/WebKit/chromium:

  • tests/TreeSynchronizerTest.cpp:
17:25 WikiStart edited by yosin@chromium.org
Add link to "Acronyms" page in "Documentation" section (diff)
17:22 Changeset [114807] by danakj@chromium.org

[chromium] WebFilterOperations API does not compile or dynamically link
https://bugs.webkit.org/show_bug.cgi?id=84506

Reviewed by James Robinson.

Non-inline functions need WEBKIT_EXPORT in their declarations,
and the type used in the WebPrivateOwnPtr needs to be forward-
declared even when WEBKIT_IMPLEMENTATION is not defined.

Source/Platform:

  • chromium/public/WebFilterOperations.h:

(WebKit::WebFilterOperations::WebFilterOperations):
(WebFilterOperations):

Source/WebCore:

  • platform/chromium/support/WebFilterOperations.cpp:

(WebKit::WebFilterOperations::initialize):

17:18 Changeset [114806] by commit-queue@webkit.org

Unreviewed, rolling out r114333.
http://trac.webkit.org/changeset/114333
https://bugs.webkit.org/show_bug.cgi?id=84511

perf regression (Requested by morrita on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-20

  • dom/Node.cpp:
  • dom/Node.h:

(WebCore):
(Node):
(WebCore::Node::isElementNode):
(WebCore::Node::isContainerNode):
(WebCore::Node::isTextNode):
(WebCore::Node::isHTMLElement):
(WebCore::Node::isSVGElement):
(WebCore::Node::isStyledElement):
(WebCore::Node::isShadowRoot):
(WebCore::Node::parentNode):
(WebCore::Node::parentNodeGuaranteedHostFree):

17:16 Changeset [114805] by commit-queue@webkit.org

IndexedDB: Support get/getKey(keyRange)
https://bugs.webkit.org/show_bug.cgi?id=83638

Patch by Alec Flett <alecflett@chromium.org> on 2012-04-20
Reviewed by Ojan Vafai.

Source/WebCore:

Support IDBKeyRange as a parameter to all the various get/getKey
combinations. Switches the existing get/getKey versions that use
IDBKey directly to start using IDBKeyRange.only().

Test: storage/indexeddb/get-keyrange.html

  • Modules/indexeddb/IDBIndex.cpp:

(WebCore::IDBIndex::get):
(WebCore):
(WebCore::IDBIndex::getKey):

  • Modules/indexeddb/IDBIndex.h:

(IDBIndex):

  • Modules/indexeddb/IDBIndex.idl:
  • Modules/indexeddb/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::getInternal):
(WebCore):
(WebCore::IDBIndexBackendImpl::getByRangeInternal):
(WebCore::IDBIndexBackendImpl::getKeyInternal):
(WebCore::IDBIndexBackendImpl::getKeyByRangeInternal):
(WebCore::IDBIndexBackendImpl::get):
(WebCore::IDBIndexBackendImpl::getKey):

  • Modules/indexeddb/IDBIndexBackendImpl.h:

(IDBIndexBackendImpl):

  • Modules/indexeddb/IDBIndexBackendInterface.h:

(IDBIndexBackendInterface):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::get):
(WebCore):

  • Modules/indexeddb/IDBObjectStore.h:

(IDBObjectStore):

  • Modules/indexeddb/IDBObjectStore.idl:
  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore):
(WebCore::IDBObjectStoreBackendImpl::get):
(WebCore::IDBObjectStoreBackendImpl::getByRangeInternal):
(WebCore::IDBObjectStoreBackendImpl::getInternal):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(IDBObjectStoreBackendImpl):

  • Modules/indexeddb/IDBObjectStoreBackendInterface.h:

(IDBObjectStoreBackendInterface):

Source/WebKit/chromium:

Hook up WebKit API to the new get/getKey implementations.

  • src/IDBIndexBackendProxy.cpp:

(WebKit::IDBIndexBackendProxy::get):
(WebKit):
(WebKit::IDBIndexBackendProxy::getKey):

  • src/IDBIndexBackendProxy.h:

(IDBIndexBackendProxy):

  • src/WebIDBIndexImpl.cpp:

(WebKit::WebIDBIndexImpl::getObject):
(WebKit::WebIDBIndexImpl::getKey):

  • src/WebIDBObjectStoreImpl.cpp:

(WebKit::WebIDBObjectStoreImpl::get):

LayoutTests:

Tests for all the get/getKey combinations when using a range.

  • storage/indexeddb/get-keyrange-expected.txt: Added.
  • storage/indexeddb/get-keyrange.html: Added.
  • storage/indexeddb/index-get-key-argument-required-expected.txt:
  • storage/indexeddb/objectStore-required-arguments-expected.txt:
  • storage/indexeddb/resources/get-keyrange.js: Added.

(test):
(openDatabase):
(setVersion):
(deleteExisting):
(addData):
(getRangeOnlyTest.request.onsuccess):
(getRangeOnlyTest):
(getRangeLowerTest.request.onsuccess):
(getRangeLowerTest):
(getRangeLowerOpenTest.request.onsuccess):
(getRangeLowerOpenTest):
(getRangeUpperTest.request.onsuccess):
(getRangeUpperTest):
(getRangeLowerFractionTest.request.onsuccess):
(getRangeLowerFractionTest):
(getOutOfRangeTest.request.onsuccess):
(getOutOfRangeTest):
(getBadOnlyTest.request.onsuccess):
(getBadOnlyTest):
(getNullTest):

17:12 Changeset [114804] by jer.noble@apple.com

Unreviewed, rolling out r114789.
http://trac.webkit.org/changeset/114789
https://bugs.webkit.org/show_bug.cgi?id=84515

Caused 5 tests to fail on mac/ (Requested by jernoble on

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-20

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSValueKeywords.in:
  • platform/ThemeTypes.h:
  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paint):

17:12 Changeset [114803] by oliver@apple.com

Add an ability to find the extent of a callframe
https://bugs.webkit.org/show_bug.cgi?id=84513

Reviewed by Filip Pizlo.

Add a function to get the extent of a callframe and
use that function for a new assertion to make sure the
RegisterFile makes sense using that information.

  • interpreter/CallFrame.cpp:

(JSC::CallFrame::frameExtentInternal):
(JSC):

  • interpreter/CallFrame.h:

(JSC::ExecState::frameExtent):
(ExecState):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::executeCall):

17:07 Changeset [114802] by beidson@apple.com

https://bugs.webkit.org/show_bug.cgi?id=84512 Repurpose ActiveDOMObject::WillShowDialog to WillDeferLoading

Reviewed by Eric Carlson.

Source/WebCore:

No new tests. (Refactor, no behavior change)

Rename WillShowDialog to WillDeferLoading:

  • dom/ActiveDOMObject.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::suspend):

Don't take a ReasonForSuspension argument anymore, just use WillDeferLoading:

  • page/PageGroupLoadDeferrer.cpp:

(WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):

  • page/PageGroupLoadDeferrer.h:

Don't pass a Reason anymore as WillDeferLoading is used by default:

  • page/Chrome.cpp:

(WebCore::Chrome::runModal):
(WebCore::Chrome::runBeforeUnloadConfirmPanel):
(WebCore::Chrome::runJavaScriptAlert):
(WebCore::Chrome::runJavaScriptConfirm):
(WebCore::Chrome::runJavaScriptPrompt):
(WebCore::Chrome::shouldInterruptJavaScript):

Source/WebKit/blackberry:

PageGroupLoadDeferrer's don't take a ReasonForSuspension argument anymore;
They just use WillDeferLoading by default.

  • Api/WebPageGroupLoadDeferrer.cpp:

(BlackBerry::WebKit::WebPageGroupLoadDeferrer::WebPageGroupLoadDeferrer):

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::createWindow):
(WebCore::ChromeClientBlackBerry::runOpenPanel):

Source/WebKit/chromium:

PageGroupLoadDeferrer's don't take a ReasonForSuspension argument anymore;
They just use WillDeferLoading by default.

  • src/WebViewImpl.cpp:

(WebKit::WebView::willEnterModalLoop):

17:01 Changeset [114801] by philn@webkit.org

Unreviewed, GTK css2.1 rebaseline after r114796 and r114799.

  • platform/gtk/css2.1: Massive Update.
16:49 Changeset [114800] by commit-queue@webkit.org

[chromium] Plumb a compositor surface ready notification through to the threaded compositor
https://bugs.webkit.org/show_bug.cgi?id=84305

Patch by James Robinson <jamesr@chromium.org> on 2012-04-20
Reviewed by Adrienne Walker.

Source/Platform:

Add a notification for when the compositor surface associated with a given view is ready to use.

  • chromium/public/WebLayerTreeView.h:

(WebLayerTreeView):

Source/WebCore:

Plumb setSurfaceReady through to the scheduler.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::setSurfaceReady):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCProxy.h:

(CCProxy):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::setSurfaceReady):
(WebCore):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(CCSingleThreadProxy):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::setSurfaceReady):
(WebCore):
(WebCore::CCThreadProxy::setSurfaceReadyOnImplThread):
(WebCore::CCThreadProxy::initializeImplOnImplThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

Adds a notification to WebWidget for when the compositor surface is ready to use. This exists to fix a race
condition when WebKit requires that we enter compositing mode but we haven't completed initialization of the
native window/etc backing the WebWidget, and we can't block for this initialization to complete without inducing
deadlocks. In this situation, we proceed as usual except that we can't attempt to use the compositor context or
it will fail.

  • public/WebWidget.h:

(WebWidget):

  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::setSurfaceReady):
(WebKit):

  • src/WebPagePopupImpl.cpp:

(WebKit::WebPagePopupImpl::setCompositorSurfaceReady):
(WebKit):

  • src/WebPagePopupImpl.h:

(WebPagePopupImpl):

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::setCompositorSurfaceReady):
(WebKit):

  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setCompositorSurfaceReady):
(WebKit):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • src/WebViewImpl.h:

(WebViewImpl):

16:47 Changeset [114799] by mrobinson@webkit.org

[Gtk][WK1] Use mock scrollbars when testing
https://bugs.webkit.org/show_bug.cgi?id=79577

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-04-20
Reviewed by Daniel Bates.

Enable mock scrollbars if running DumpRenderTree.

  • webkit/webkitwebview.cpp:

(webkit_web_view_update_settings):

16:32 Changeset [114798] by dino@apple.com

REGRESSION (r114764-r114766): svg/css/getComputedStyle-basic.xhtml failing on Lion Debug (Tests)
https://bugs.webkit.org/show_bug.cgi?id=84483

Reviewed by Simon Fraser.

Add -webkit-filter results to the platforms on which it is enabled.
This required a new platform result for WebKit mac.

  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/mac/svg/css/getComputedStyle-basic-expected.txt: Copied from LayoutTests/platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt.
  • platform/mac/test_expectations.txt:
16:31 Changeset [114797] by pilgrim@chromium.org

[Chromium] Call memoryUsageMB directly
https://bugs.webkit.org/show_bug.cgi?id=84376

Reviewed by Kentaro Hara.

Source/WebCore:

Now that memoryUsageMB has been moved from PlatformSupport.h to
Platform.h, we need to be able to call it directly
from WebCore/bindings/v8/V8GCController.cpp.
That means we need a new MemoryUsageSupport class in
WebCore/platform/ and an implementation in
WebCore/platform/chromium/MemoryUsageSupportChromium.cpp.
Other ports are welcome to implement their memory usage
functions if they wish. This pattern was based on the
HistogramSupport/HistogramSupportChromium classes.

Part of a refactoring series. See tracking bug 82948.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/v8/V8GCController.cpp:

(WebCore):

  • platform/MemoryUsageSupport.cpp: Added.

(WebCore):
(WebCore::MemoryUsageSupport::memoryUsageMB):

  • platform/MemoryUsageSupport.h: Added.

(WebCore):
(MemoryUsageSupport):

  • platform/chromium/MemoryUsageSupportChromium.cpp: Added.

(WebCore):
(WebCore::MemoryUsageSupport::memoryUsageMB):

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

Source/WebKit/chromium:

Part of a refactoring series. See tracking bug 82948.

  • src/PlatformSupport.cpp:

(WebCore):

16:18 Changeset [114796] by mrobinson@webkit.org

[GTK] Revert changes that disabled Cairo fonts metrics hinting
https://bugs.webkit.org/show_bug.cgi?id=84502

Reviewed by Daniel Bates.

Re-enable Cairo metrics hinting, which seems to ensure consistent results in
reference and pixel test results. This makes our font metrics a bit different
than the Mac port's, but it's a decent price to pay for consistent results.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(initializeGtkFontSettings):

  • WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:

(WTR::initializeGtkSettings):

16:18 Internals_Hackathon edited by bashi@chromium.org
(diff)
16:05 BuildingGtk edited by kov@webkit.org
(diff)
16:04 Changeset [114795] by jer.noble@apple.com

REGRESSION (r114784): svg/text/foreignObject-text-clipping-bug.xml failing on Mountain Lion Debug Tests
https://bugs.webkit.org/show_bug.cgi?id=84505

Unreviewed; add new crashing test result to test_expectations.txt.

  • platform/mac/test_expectations.txt:
16:03 Changeset [114794] by commit-queue@webkit.org

[EFL] [DRT] Add baselines for the tests which are missing expected results
https://bugs.webkit.org/show_bug.cgi?id=84440

Unreviewed, added EFL baselines for passing tests and also skipped two tests
which are failing due to missing implementation.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-20

  • platform/efl/Skipped:
  • platform/efl/fast/block/float/avoiding-float-centered-expected.png: Added.
  • platform/efl/fast/block/float/avoiding-float-centered-expected.txt: Added.
  • platform/efl/fast/events/panScroll-click-hyperlink-expected.txt: Added.
15:52 Changeset [114793] by benjamin@webkit.org

Inline the JSArray constructor
https://bugs.webkit.org/show_bug.cgi?id=84416

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-20
Reviewed by Geoffrey Garen.

The constructor is trivial, no reason to jump for it.

This makes the creation of array ~5% faster (on non-trivial cases, no empty arrays).

  • runtime/JSArray.cpp:

(JSC):

  • runtime/JSArray.h:

(JSC::JSArray::JSArray):

15:46 April 2012 Meeting edited by noam.rosenthal@nokia.com
(diff)
15:45 April 2012 Meeting edited by jberlin@webkit.org
Adding notes for the keeping the bots green session (diff)
15:44 April 2012 Keeping the bots green created by jberlin@webkit.org
Notes for the keeping the bots green session
15:38 Changeset [114792] by andersca@apple.com

Re-land. The non-fast scrollable region is now always updated after layout, and frameViewScrollableAreasDidChange has been removed.

computeNonFastScrollableRegion needs to traverse the entire frame tree
https://bugs.webkit.org/show_bug.cgi?id=84409
<rdar://problem/11285741>

Reviewed by Dan Bernstein.

Now that scrollable areas won't be in the set of scrollable areas unless they are actually scrollable, we need to look for scrollable
areas in the entire frame tree since there can be a scrollable frame that's a subframe of a non-scrollable frame for example.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::computeNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):

15:35 Changeset [114791] by enne@google.com

[chromium] Clip TransparencyWin to prevent OOM from large Skia canvas
https://bugs.webkit.org/show_bug.cgi?id=84289

Reviewed by James Robinson.

Source/WebCore:

TransparencyWin will create a Skia canvas of whatever size is passed
in, even if the result will ultimately be clipped. Handle the clip
implicitly and try (in some cases) to create a smaller canvas. This
can happen due to RenderBox::paintBoxDecorations passing a paint rect
down of the entire element's size.

Modes with more complicated transforms (ScaleTransform, UnTransform)
are not handled yet.

Tests: TransparencyWin.ClippedKeepTransformNoLayer

TransparencyWin.ClippedKeepTransformOpaqueCompositeLayer
TransparencyWin.ClippedKeepTransformOpaqueWhiteLayer

  • platform/graphics/chromium/TransparencyWin.cpp:

(WebCore::TransparencyWin::computeLayerSize):

Source/WebKit/chromium:

Add a test that would OOM if the layer wasn't clipped. Also, verify
that clipping the canvas doesn't shift pixels around incorrectly.

  • tests/TransparencyWinTest.cpp:

(WebCore::testClippedLayerKeepTransform):
(WebCore):
(WebCore::TEST):

15:33 Changeset [114790] by jer.noble@apple.com

apple.com top navigation bar appears inside video during full screen exit animation
https://bugs.webkit.org/show_bug.cgi?id=83095

Reviewed by Eric Carlson.

Source/WebCore:

Test: fullscreen/full-screen-exit-animation-stacking-context.html

Only tell ancestors of the full screen element that they are no longer ancestors once
the full screen animation is complete:

  • dom/Document.cpp:

(WebCore::Document::webkitWillExitFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):

To facilitate writing reproducible LayoutTests, expose webkitWill/Did/Enter/ExitFullScreen
from the Internals object, so scripts can call them explicitly:

  • testing/Internals.cpp:

(WebCore::Internals::webkitWillEnterFullScreenForElement): Call the Document equivalent.
(WebCore::Internals::webkitDidEnterFullScreenForElement): Ditto.
(WebCore::Internals::webkitWillExitFullScreenForElement): Ditto.
(WebCore::Internals::webkitDidExitFullScreenForElement): Ditto.

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

Add new WebCore symbols needed by DumpRenderTree to exported symbol list.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

Tools:

Add a new LayoutTestController function, setHasCustomFullScreenBehavior(), which allows scripts to
disable the standard full screen behavior, and replace it with explicit callbacks to the relevant
Document methods from within the script. This allows subtle timing bugs to be consistently reproduced
from within LayoutTests.

Add the new methods, hasCustomFullScreenBehavior() and setHasCustomFullScreenBehavior():

  • DumpRenderTree/LayoutTestController.cpp:

(setHasCustomFullScreenBehaviorCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController::setHasCustomFullScreenBehavior):
(LayoutTestController::hasCustomFullScreenBehavior):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::enterFullScreenForElement):
(WTR::InjectedBundlePage::exitFullScreenForElement):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(WTR::LayoutTestController::setHasCustomFullScreenBehavior):
(WTR::LayoutTestController::hasCustomFullScreenBehavior):

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::reset):

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController::setHasCustomFullScreenBehavior):
(LayoutTestController::hasCustomFullScreenBehavior):

Query the new methods before calling will/did/Enter/ExitFullScreen:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::enterFullScreenNow):
(WebViewHost::exitFullScreenNow):

  • DumpRenderTree/mac/UIDelegate.mm:

(-[UIDelegate webView:enterFullScreenForElement:listener:]):
(-[UIDelegate webView:exitFullScreenForElement:listener:]):

LayoutTests:

  • fullscreen/full-screen-exit-animation-stacking-context-expected.txt: Added.
  • fullscreen/full-screen-exit-animation-stacking-context.html: Added.
  • platform/mac/fullscreen/full-screen-exit-animation-stacking-context-expected.png: Added.
15:33 Changeset [114789] by jer.noble@apple.com

media-exit-fullscreen-button (and related enums) is unnecessary and should be removed.
https://bugs.webkit.org/show_bug.cgi?id=84162

Reviewed by Eric Carlson.

No new tests; no change in functionality so covered by existing tests.

Remove the media-exit-fullscreen-button keyword, and rename media-enter-fullscreen-button to
media-fullscreen-button.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSValueKeywords.in:
  • css/mediaControls.css:

(audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):

  • platform/ThemeTypes.h:
  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paint):

15:32 Changeset [114788] by dpranke@chromium.org

NRWT: option --skip-pixel-test-if-no-baseline support on DRT
https://bugs.webkit.org/show_bug.cgi?id=72841

Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-04-20
Reviewed by Dirk Pranke

This patch implements support for --skip-pixel-test-if-no-baseline generically in NRWT,
instead of in every DRT and WTR implementation. We add 'should_run_pixel_test'
and 'reference_files' fields to the TestInput objects, and use those flags
to select the right driver to use in the DriverProxy.

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner.init):
(SingleTestRunner._driver_input):
(SingleTestRunner._run_reftest):

  • Scripts/webkitpy/layout_tests/controllers/worker.py:

(Worker.handle_test_list):
(Worker._update_test_input):

  • Scripts/webkitpy/layout_tests/models/test_input.py:

(TestInput):
(TestInput.init):
(TestInput.repr):

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumDriver._wrapper_options):
(ChromiumDriver.run_test):

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumDriverTest.test_crash_log):

  • Scripts/webkitpy/layout_tests/port/driver.py:

(DriverInput.init):
(Driver.init):
(DriverProxy.init):
(DriverProxy.run_test):
(DriverProxy.start):
(DriverProxy.cmd_line):

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkDriver._start):

  • Scripts/webkitpy/layout_tests/port/mock_drt.py:

(MockDRT.run):
(MockDRT.input_from_line):
(MockDRT.output_for_test):
(MockDRT.write_test_output):
(MockChromiumDRT.input_from_line):
(MockChromiumDRT.output_for_test):
(MockChromiumDRT.write_test_output):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitDriver.cmd_line):
(WebKitDriver.run_test):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::runTest):

  • WebKitTestRunner/TestController.h:

(TestController):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::TestInvocation):
(WTR::TestInvocation::setIsPixelTest):

  • WebKitTestRunner/TestInvocation.h:

(TestInvocation):

15:18 Changeset [114787] by commit-queue@webkit.org

[chromium] Fix compile errors when DEBUG_GL_CALLS is enabled
https://bugs.webkit.org/show_bug.cgi?id=84491

Patch by Alexandre Elias <aelias@google.com> on 2012-04-20
Reviewed by Ojan Vafai.

DEBUG_GL_CALLS had not been used in a while and the mode no longer
compiled when I tried it. I improved the GLC macro to support either
raw pointers or RefPtrs, and to be a single expression in order to
interact properly with if/else blocks. I fixed the cases where we
were passing in the "context" method pointer by mistake, and removed the
now-unnecessary "get()" calls for the RefPtrs.

No new tests. (No-op change in release builds.)

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::clearRenderSurface):
(WebCore::LayerRendererChromium::beginDrawingFrame):
(WebCore::LayerRendererChromium::doNoOp):
(WebCore::LayerRendererChromium::drawQuad):
(WebCore::LayerRendererChromium::drawTextureQuad):
(WebCore::LayerRendererChromium::drawHeadsUpDisplay):
(WebCore::LayerRendererChromium::finishDrawingFrame):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::bindFramebufferToTexture):
(WebCore::LayerRendererChromium::setScissorToRect):
(WebCore::LayerRendererChromium::setDrawViewportRect):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:

(WebCore):

15:15 Changeset [114786] by andersca@apple.com

Fix build.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::updateMainFrameScrollPositionAndScrollLayerPosition):

15:15 April 2012 Meeting edited by dbates@webkit.org
(diff)
14:54 Changeset [114785] by simon.fraser@apple.com

Set m_compositingDependsOnGeometry to false if possible
https://bugs.webkit.org/show_bug.cgi?id=84391

Reviewed by James Robinson.

For some kinds of elements, RenderLayerCompositor has to delay decisions about
compositing until the element's size and/or position are known. This was previsouly
based on the confusingly named m_compositingDependsOnGeometry flag, but another
variant of the same technique, with an additional flag m_compositingNeedsUpdate,
was added in r98627.

Also, once the m_compositingDependsOnGeometry flag was set to true, nothing
set it to false, so every compositing layer update resulted in a computeCompositingRequirements()
pass over the layers.

Rename the m_compositingDependsOnGeometry flag to m_reevaluateCompositingAfterLayout,
and clear the flag when we do a layout-related compositing layer update.
Use the same flag for position:fixed compositing.

This requires RenderLayerCompositor to distinguish between style- and layout-
related updates, requiring some minor refactoring in FrameView.

Should not change behavior.

  • dom/Document.cpp:

(WebCore::Document::recalcStyle):
(WebCore::Document::implicitClose):

  • page/FrameView.cpp:

(WebCore::FrameView::updateCompositingLayersAfterStyleChange):
(WebCore::FrameView::updateCompositingLayersAfterLayout):
(WebCore::FrameView::restoreBackingStores):
(WebCore::FrameView::layout):

  • page/FrameView.h:

(FrameView):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::updateCompositingLayersTimerFired):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::layerTreeAsText):
(WebCore::RenderLayerCompositor::requiresCompositingForPlugin):
(WebCore::RenderLayerCompositor::requiresCompositingForFrame):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

14:45 April 2012 Write Your Own Render Object edited by dpranke@chromium.org
(diff)
14:41 April 2012 Write Your Own Render Object edited by dpranke@chromium.org
(diff)
14:40 Changeset [114784] by mitz@apple.com

Source/WebCore: <rdar://problem/10786000> Selection highlights of lines in adjoining blocks can overlap
https://bugs.webkit.org/show_bug.cgi?id=84489

Reviewed by Anders Carlsson.

Test: fast/block/line-layout/selection-highlight-overlap.html

  • rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::selectionRect): Changed to use
selection{Top,Height}AdjustedForPrecedingBlock().

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintSelection): Ditto.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::inlineSelectionGaps): Ditto.
(WebCore::RenderBlock::blockBeforeWithinSelectionRoot): Added. Returns the block which is
likely to contain the selected line just before the first line in this block, if it is
within the same selection root.

  • rendering/RenderBlock.h:
  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::selectionTopAdjustedForPrecedingBlock): Added. If the selection
starts before our block, finds the last line in the preceding block and adjusts the selection
top to avoid overlap with that line’s selection bottom.

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::selectionHeightAdjustedForPrecedingBlock): Added. Like
selectionHeight(), but uses selectionTopAdjustedForPrecedingBlock().

LayoutTests: Selection highlights of lines in adjoining blocks can overlap
https://bugs.webkit.org/show_bug.cgi?id=84489

Reviewed by Anders Carlsson.

  • fast/block/line-layout/selection-highlight-overlap-expected.html: Added.
  • fast/block/line-layout/selection-highlight-overlap.html: Added.
14:37 Changeset [114783] by jer.noble@apple.com

Crash in getOrDrawNodeHighlight after r114659
https://bugs.webkit.org/show_bug.cgi?id=84486

Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2012-04-20
Reviewed by Daniel Bates.

No new tests. Fixes a crash in test: inspector/elements/elements-panel-selection-on-refresh.html.

  • inspector/DOMNodeHighlighter.cpp:
14:33 April 2012 Write Your Own Render Object edited by dpranke@chromium.org
(diff)
14:29 Changeset [114782] by beidson@apple.com

https://bugs.webkit.org/show_bug.cgi?id=84490
PageGroupLoadDeferrer needs to take a ReasonForSuspension argument

Reviewed by Anders Carlsson.

Source/WebCore:

No new tests. (Refactor, no change in behavior)

  • Make PageGroupLoadDeferrer take a ReasonForSuspension argument so it can pass it along.
  • page/PageGroupLoadDeferrer.cpp:

(WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):

  • page/PageGroupLoadDeferrer.h:
  • Change suspendScheduledTasks to take a ReasonForSuspension.
  • As long as we're changing Document.h, add a m_suspendedScheduledTasks flag and some ASSERTs to catch what would be epically wrong behavior in the future.
  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::suspendScheduledTasks):
(WebCore::Document::resumeScheduledTasks):

  • dom/Document.h:
  • Pass ActiveDOMObject::WillShowDialog along to all PageGroupLoadDeferrers, as it used to be the default behavior
  • page/Chrome.cpp:

(WebCore::Chrome::runModal):
(WebCore::Chrome::runBeforeUnloadConfirmPanel):
(WebCore::Chrome::runJavaScriptAlert):
(WebCore::Chrome::runJavaScriptConfirm):
(WebCore::Chrome::runJavaScriptPrompt):
(WebCore::Chrome::shouldInterruptJavaScript):

Source/WebKit/blackberry:

  • Api/WebPageGroupLoadDeferrer.cpp:

(BlackBerry::WebKit::WebPageGroupLoadDeferrer::WebPageGroupLoadDeferrer): Pass along ActiveDOMObject::WillShowDialog,

which used to be the default

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::createWindow): Pass along ActiveDOMObject::WillShowDialog, which used to be the default.
(WebCore::ChromeClientBlackBerry::runOpenPanel): Ditto.

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebView::willEnterModalLoop): Pass along ActiveDOMObject::WillShowDialog, which used

to be the default.

14:25 Changeset [114781] by andersca@apple.com

Scrolling after going to a find-in-page result jumps to the top of the page
https://bugs.webkit.org/show_bug.cgi?id=84485
<rdar://problem/11273734>

Reviewed by Beth Dakin.

If we're both updating the requested scroll position and entering slow mode in the same commit, the
probable main thread scroll position should be the requested scroll position.

  • page/scrolling/mac/ScrollingTreeNodeMac.mm:

(WebCore::ScrollingTreeNodeMac::update):

14:23 April 2012 Write Your Own Render Object edited by dpranke@chromium.org
(diff)
14:22 Changeset [114780] by eae@chromium.org

Merge trunk changes up until 114777 into subpixel branch.

14:22 April 2012 Write Your Own Render Object edited by dpranke@chromium.org
(diff)
14:19 Changeset [114779] by commit-queue@webkit.org

[BlackBerry] Expose WebViewportArguments to WebPageClient
https://bugs.webkit.org/show_bug.cgi?id=84471

Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-04-20
Reviewed by Antonio Gomes.

Source/WebKit:

  • PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

Implement the ability for the WebPageClient to specify a fallback
virtual viewport to be used whenever a meta viewport tag is not
present in the HTML. This can drastically impact apparent layout.
This patch is designed to provide a classic "Column View" style of
layout without breaking the web by simply exposing meta viewport
arguments to WebPageClients.

Note: As a side effect of this change. the WebPagePrivate::
recomputeVirtualViewportFromViewportArguments method no longer
modifies the targetDensityDpi property of the m_viewportArguments.
However this does not affect the class because that property itself
means nothing to us. Only the computeViewportArguments method from
WebCore uses it, and the currentViewportArguments object we pass
into that method has the adjusted targetDensityDpi value as before.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::setUserViewportArguments):
(WebKit):
(BlackBerry::WebKit::WebPage::resetUserViewportArguments):
(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):

  • Api/WebPage.h:

(WebKit):

  • Api/WebPage_p.h:

(WebPagePrivate):

  • Api/WebViewportArguments.cpp: Added.

(WebKit):
(BlackBerry::WebKit:::d):
(BlackBerry::WebKit::WebViewportArguments::~WebViewportArguments):
(BlackBerry::WebKit::WebViewportArguments::initialScale):
(BlackBerry::WebKit::WebViewportArguments::setInitialScale):
(BlackBerry::WebKit::WebViewportArguments::minimumScale):
(BlackBerry::WebKit::WebViewportArguments::setMinimumScale):
(BlackBerry::WebKit::WebViewportArguments::maximumScale):
(BlackBerry::WebKit::WebViewportArguments::setMaximumScale):
(BlackBerry::WebKit::WebViewportArguments::width):
(BlackBerry::WebKit::WebViewportArguments::setWidth):
(BlackBerry::WebKit::WebViewportArguments::height):
(BlackBerry::WebKit::WebViewportArguments::setHeight):
(BlackBerry::WebKit::WebViewportArguments::targetDensityDpi):
(BlackBerry::WebKit::WebViewportArguments::setTargetDensityDpi):
(BlackBerry::WebKit::WebViewportArguments::userScalable):
(BlackBerry::WebKit::WebViewportArguments::setUserScalable):
(BlackBerry::WebKit::WebViewportArguments::operator==):
(BlackBerry::WebKit::WebViewportArguments::operator!=):

  • Api/WebViewportArguments.h: Added.

(WebCore):
(WebKit):

14:17 Changeset [114778] by commit-queue@webkit.org

Avoid synchronously recalculating the nonFastScrollableRegion when the ScrollableArea set changes
https://bugs.webkit.org/show_bug.cgi?id=84470

Patch by James Robinson <jamesr@chromium.org> on 2012-04-20
Reviewed by Anders Carlsson.

Source/WebCore:

When a scrollable area is added or removed, we shouldn't recalculate the nonFastScrollableRegion synchronously
since this is slow, the RenderObject tree might not be in an up-to-date state, and we'll typically do layout
soon anyway.

  • page/FrameView.cpp:

(WebCore::FrameView::addScrollableArea):
(WebCore::FrameView::removeScrollableArea):

  • page/scrolling/ScrollingCoordinator.cpp:
  • page/scrolling/ScrollingCoordinator.h:

(ScrollingCoordinator):

Source/WebKit/chromium:

Trigger a layout when a plugin becomes or stops being scrollable so the nonFastScrollableRegion
can be updated.

  • src/ScrollbarGroup.cpp:

(WebKit::ScrollbarGroup::scrollbarCreated):
(WebKit::ScrollbarGroup::scrollbarDestroyed):

14:09 April 2012 Write Your Own Render Object created by dpranke@chromium.org
14:02 Changeset [114777] by dimich@chromium.org

Rebaselining svg/css/getComputedStyle-basic.html after
http://trac.webkit.org/changeset/114766

Not reviewed.

  • platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt.
  • platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt.
  • platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt.
  • platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt.
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
13:48 April 2012 Meeting edited by dpranke@chromium.org
(diff)
13:47 April 2012 Meeting edited by morrita@google.com
(diff)
13:46 EFLWebKit edited by rakuco@webkit.org
Update libsoup version (diff)
13:44 P1010689-small.jpg attached to April 2012 Meeting by morrita@google.com
Group Photo (Small)
13:41 P1010689.JPG attached to April 2012 Meeting by morrita@google.com
Group Photo
13:28 Changeset [114776] by commit-queue@webkit.org

[EFL] Make it possible to define offline storage quota per origin
https://bugs.webkit.org/show_bug.cgi?id=84170

Improved LayoutTestController::setDatabaseQuota to set quota based on
origin which was causing some tests to fail. Also align the default
quota for testing (5MB) with others ports.

When dumpDatabaseCallbacks is set to true by, also dump some database
information when quota is exceed, which is also required by some tests.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-20
Reviewed by Antonio Gomes.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

  • DumpRenderTree/efl/DumpRenderTreeView.cpp:

(onExceededDatabaseQuota):
(drtViewAdd):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setDatabaseQuota):

13:22 Changeset [114775] by eae@chromium.org

Fix use of LayoutUnits in DOMNodeHighlighter
https://bugs.webkit.org/show_bug.cgi?id=84472

Reviewed by Eric Seidel.

Fix use of subpixel units and rounding in new code introduced in r114659.

No new tests, no change in functionality.

  • inspector/DOMNodeHighlighter.cpp:
13:07 Changeset [114774] by commit-queue@webkit.org

Enable Encrypted Media tests on Chromium now that Chromium side is committed
https://bugs.webkit.org/show_bug.cgi?id=84474

Unreviewed enabling of layout tests.

Patch by David Dorwin <ddorwin@chromium.org> on 2012-04-20

  • platform/chromium/test_expectations.txt:
13:03 Changeset [114773] by jer.noble@apple.com

REGRESSION (r114764-r114766): svg/css/getComputedStyle-basic.xhtml failing on Lion Debug (Tests)
https://bugs.webkit.org/show_bug.cgi?id=84483

Unreviewed; add new failing test to expected results.

  • platform/mac/test_expectations.txt:
12:55 Changeset [114772] by mhahnenberg@apple.com

Heap should cancel GC timer at the start of the collection
https://bugs.webkit.org/show_bug.cgi?id=84477

Reviewed by Geoffrey Garen.

Currently the Heap cancels the GC timer at the conclusion of a collection.
We should change this to be at the beginning because something (e.g. a finalizer)
could call didAbandonObjectGraph(), which will schedule the timer, but then
we'll immediately unschedule the timer at the conclusion of the collection,
thus potentially preventing large swaths of memory from being reclaimed in a timely manner.

  • API/JSBase.cpp:

(JSGarbageCollect): Remove outdated fix-me and remove check for whether the Heap is
busy or not, since we're just scheduling a timer to run a GC in the future.

  • heap/Heap.cpp:

(JSC::Heap::collect): Rename didCollect to willCollect and move the call to the
top of Heap::collect.

  • runtime/GCActivityCallback.cpp: Renamed didCollect to willCollect.

(JSC::DefaultGCActivityCallback::willCollect):

  • runtime/GCActivityCallback.h: Ditto.

(JSC::GCActivityCallback::willCollect):
(DefaultGCActivityCallback):

  • runtime/GCActivityCallbackCF.cpp: Ditto.

(JSC::DefaultGCActivityCallback::willCollect):

12:36 Changeset [114771] by mhahnenberg@apple.com

JSGarbageCollect should not call collectAllGarbage()
https://bugs.webkit.org/show_bug.cgi?id=84476

Reviewed by Geoffrey Garen.

  • API/JSBase.cpp:

(JSGarbageCollect): Notify the Heap's GCActivityCallback using didAbandonObjectGraph.

12:11 Changeset [114770] by tonikitoo@webkit.org

Relax ScrollView::adjustScrollPositionWithinRange in case constrainsScrollingToContentEdge is false
https://bugs.webkit.org/show_bug.cgi?id=84178

Reviewed by Adam Treat.
Patch by Antonio Gomes <agomes@rim.com>

No new tests since it is not easily testable.

When a port has both delegatesScrolling and constrainsScrollingToContentEdge set to FALSE
(i.e. it accepts overscrolled position), calling ScrollView::setScrollPosition with an overscrolled
position still gets the position clamped to the content size edges.

Patch relaxes ::adjustScrollPositionWithinRange in that sense in order to track the actual scroll
position.

Note: ScrollView::setScrollOffset already does something similar.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::adjustScrollPositionWithinRange):

12:09 Changeset [114769] by eae@chromium.org

Merge trunk changes up until 114767 into subpixel branch.

12:07 April 2012 Meeting edited by rniwa@webkit.org
(diff)
12:04 Changeset [114768] by commit-queue@webkit.org

Unreviewed, rolling out r114535.
http://trac.webkit.org/changeset/114535
https://bugs.webkit.org/show_bug.cgi?id=84475

It might have caused V8 crashes. (Requested by pfeldman_ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-20

  • bindings/v8/V8IsolatedContext.cpp:

(WebCore::V8IsolatedContext::V8IsolatedContext):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::evaluateInIsolatedWorld):
(WebCore::V8Proxy::setInjectedScriptContextDebugId):
(WebCore):

  • bindings/v8/V8Proxy.h:

(V8Proxy):

11:51 April 2012 Reducing build systems edited by dbates@webkit.org
Add clarifying sentence to section "Another approach: scripts; … (diff)
11:46 Changeset [114767] by eae@chromium.org

Misc platform fixes on branch.

11:42 April 2012 Reducing build systems edited by dbates@webkit.org
Fix formatting; spelling/grammer corrections (diff)
11:41 Changeset [114766] by dino@apple.com

-webkit-filter missing from computed style enumeration
https://bugs.webkit.org/show_bug.cgi?id=84468

Source/WebCore:

Reviewed by Timothy Hatcher.

CSSComputedStyleDeclaration has a list of properties that it exposes.
While the computed style for filter was available, the property wasn't
listed and hence missing in clients like the Web Inspector.

Covered by existing tests.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore): add CSSPropertyWebkitFilter

LayoutTests:

Reviewed by Timothy Hatcher.

Added new results for platforms that have filters enabled. Hopefully
I got them all. Luckily there were already platform results for this
test in each case.

  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
11:35 April 2012 Meeting edited by wingo@igalia.com
(diff)
11:34 April 2012 JavaScriptCore Roundup created by wingo@igalia.com
11:29 April 2012 Meeting edited by wingo@igalia.com
(diff)
11:29 April 2012 Meeting edited by wingo@igalia.com
(diff)
11:28 April 2012 Reducing build systems created by dbates@webkit.org
First pass at notes.
11:27 April 2012 Canvas Canvass created by wingo@igalia.com
11:13 Changeset [114765] by lforschler@apple.com

Move bot to Lion Debug to help catch up.

11:12 Changeset [114764] by eae@chromium.org

[win] Update windows platform code to use pixel snapped values
https://bugs.webkit.org/show_bug.cgi?id=84283

Reviewed by Eric Seidel.

Source/WebCore:

No new tests, no change in functionality.

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::pixelSnappedElementRect):
Use pixel snapped values when computing screenRect.

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::calculatePositionAndSize):
(WebCore::PopupMenuWin::paint):
Cast client padding to ints as they are guaranteed to align with device pixels.

Source/WebKit/win:

  • AccessibleBase.cpp:

(AccessibleBase::accLocation):

11:03 April 2012 Meeting edited by wingo@igalia.com
(diff)
11:02 April 2012 Meeting edited by noam.rosenthal@nokia.com
(diff)
11:01 April 2012 Meeting edited by noam.rosenthal@nokia.com
(diff)
11:00 Scrolling Session Meeting 2012 created by noam.rosenthal@nokia.com
10:57 Changeset [114763] by danakj@chromium.org

[chromium] Some filters require inflating damage rect in CCDamageTracker
https://bugs.webkit.org/show_bug.cgi?id=84373

Reviewed by James Robinson.

Source/WebCore:

When a layer is blurred, damaged pixels are blurred out into a radius
and their damage should be expanded to include total blurred region.

Unit test: CCDamageTrackerTest.verifyDamageForBlurredSurface

  • platform/graphics/chromium/cc/CCDamageTracker.cpp:

(WebCore::CCDamageTracker::updateDamageTrackingState):
(WebCore::CCDamageTracker::expandDamageRectWithForegroundFilters):
(WebCore):

  • platform/graphics/chromium/cc/CCDamageTracker.h:

(WebCore):
(CCDamageTracker):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::trackDamageForAllSurfaces):

Source/WebKit/chromium:

  • tests/CCDamageTrackerTest.cpp:

(WebKitTests::emulateDrawingOneFrame):
(WebKitTests::TEST_F):
(WebKitTests):

10:56 April 2012 Meeting edited by dbates@webkit.org
Add hyperlink to discussion notes for session "Reducing build systems" (diff)
10:54 Changeset [114762] by eae@chromium.org

Merge trunk changes up until 114758 into subpixel branch.

10:53 Changeset [114761] by commit-queue@webkit.org

[chromium] Don't crash when scrolling empty layer tree
https://bugs.webkit.org/show_bug.cgi?id=84455

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-04-20
Reviewed by James Robinson.

Source/WebCore:

Do not try to calculate render passes when there are no layers in the
layer tree.

Added new unit test.

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):

Source/WebKit/chromium:

Try to scroll an empty layer tree.

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKitTests::TEST_F):
(WebKitTests):

10:46 Changeset [114760] by commit-queue@webkit.org

Ensure text is centered for default captions
https://bugs.webkit.org/show_bug.cgi?id=84450

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-04-20
Reviewed by Eric Carlson.

Source/WebCore:

Updated existing test.

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::getDisplayTree): Added default width.

LayoutTests:

Updated test to cover default positioning of captions.

  • media/track/track-cue-rendering-expected.txt: Updated.
  • media/track/track-cue-rendering.html: Updated.
10:31 Changeset [114759] by commit-queue@webkit.org

[EFL][DRT] Gardening SVG tests and timeouts
https://bugs.webkit.org/show_bug.cgi?id=84462

Unreviewed, EFL gardening.

A number of SVG Batik text tests needed rebaselining likely due to bug 83264.
Also, moving some tests that fail to call notifyDone to test_expectations with appropriate bugs filed.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-20

  • platform/efl/svg/batik/text/longTextOnPath-expected.png: Added.
  • platform/efl/svg/batik/text/longTextOnPath-expected.txt:
  • platform/efl/svg/batik/text/smallFonts-expected.png: Added.
  • platform/efl/svg/batik/text/smallFonts-expected.txt:
  • platform/efl/svg/batik/text/textAnchor2-expected.png: Added.
  • platform/efl/svg/batik/text/textAnchor3-expected.png: Added.
  • platform/efl/svg/batik/text/textDecoration-expected.png: Added.
  • platform/efl/svg/batik/text/textDecoration-expected.txt:
  • platform/efl/svg/batik/text/textDecoration2-expected.png: Added.
  • platform/efl/svg/batik/text/textEffect-expected.png: Added.
  • platform/efl/svg/batik/text/textEffect-expected.txt:
  • platform/efl/svg/batik/text/textEffect2-expected.png: Added.
  • platform/efl/svg/batik/text/textEffect2-expected.txt:
  • platform/efl/svg/batik/text/textEffect3-expected.png: Added.
  • platform/efl/svg/batik/text/textEffect3-expected.txt:
  • platform/efl/svg/batik/text/textFeatures-expected.png: Added.
  • platform/efl/svg/batik/text/textFeatures-expected.txt:
  • platform/efl/svg/batik/text/textGlyphOrientationHorizontal-expected.png: Added.
  • platform/efl/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
  • platform/efl/svg/batik/text/textLayout-expected.png: Added.
  • platform/efl/svg/batik/text/textLayout-expected.txt:
  • platform/efl/svg/batik/text/textLayout2-expected.png: Added.
  • platform/efl/svg/batik/text/textLayout2-expected.txt:
  • platform/efl/svg/batik/text/textLength-expected.png: Added.
  • platform/efl/svg/batik/text/textLength-expected.txt:
  • platform/efl/svg/batik/text/textOnPath2-expected.png: Added.
  • platform/efl/svg/batik/text/textOnPath2-expected.txt:
  • platform/efl/svg/batik/text/textOnPathSpaces-expected.png: Added.
  • platform/efl/svg/batik/text/textOnPathSpaces-expected.txt:
  • platform/efl/svg/batik/text/textPCDATA-expected.png: Added.
  • platform/efl/svg/batik/text/textPosition-expected.png: Added.
  • platform/efl/svg/batik/text/textPosition-expected.txt:
  • platform/efl/svg/batik/text/textPosition2-expected.png: Added.
  • platform/efl/svg/batik/text/textPosition2-expected.txt:
  • platform/efl/svg/batik/text/textProperties-expected.png: Added.
  • platform/efl/svg/batik/text/textProperties-expected.txt:
  • platform/efl/svg/batik/text/textStyles-expected.png: Added.
  • platform/efl/svg/batik/text/textStyles-expected.txt:
  • platform/efl/svg/batik/text/verticalText-expected.png: Added.
  • platform/efl/svg/batik/text/verticalText-expected.txt:
  • platform/efl/svg/batik/text/xmlSpace-expected.png: Added.
  • platform/efl/svg/batik/text/xmlSpace-expected.txt:
  • platform/efl/test_expectations.txt:
10:23 April 2012 HTML5 Media Element & WebAudio created by jer.noble@apple.com
Initial Commit
10:23 April 2012 Meeting edited by jer.noble@apple.com
(diff)
10:13 Changeset [114758] by pfeldman@chromium.org

Web Inspector: open file dialog is not centered.
https://bugs.webkit.org/show_bug.cgi?id=84464

Reviewed by Yury Semikhatsky.

There was an error in the positioning logic.

  • inspector/front-end/FilteredItemSelectionDialog.js:

(WebInspector.FilteredItemSelectionDialog.prototype.position):

10:11 Importing Thirdparty tests edited by rniwa@webkit.org
(diff)
10:11 April 2012 Meeting edited by rniwa@webkit.org
(diff)
10:10 Importing Thirdparty tests created by rniwa@webkit.org
10:09 April 2012 Meeting edited by rniwa@webkit.org
(diff)
10:09 Changeset [114757] by danakj@chromium.org

Merge 113677 - [chromium] Viewport is not filled when out of texture memory on mac
https://bugs.webkit.org/show_bug.cgi?id=83351

Reviewed by Adrienne Walker.

Source/Platform:

  • chromium/public/WebLayerTreeView.h:

(WebLayerTreeView):

Source/WebCore:

Currently we add gutter quads on the NonCompositedContentHost layer,
which lies above another visible layer - the rubberband layer on mac.
For this reason, on mac, gutter quads were disabled, as well as forcing
the NCCH layer to draw, in order to make the rubberband layer appear.

We move the logic for adding gutter quads into CCRenderPass, and add
gutter quads for all pixels that are visible through the viewport.
This allows us to stop special-casing the NCCH layer, and allows us
to skip drawing the layer equally with other layers. We remove the
backgroundCoversViewport() flag entirely.

In order to do this, we fix a bug in the occlusion tracker, that
allowed opaque() layers with skipsDraw to occlude, by making
the visibleContentOpaqueRegion() method on the layer classes
also return the opaque region for non-tiled layers, always use
its value in the occlusion tracker.

Unit test: CCLayerTreeHostImplTest.viewportCovered

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::pushPropertiesTo):
(WebCore::LayerChromium::visibleContentOpaqueRegion):
(WebCore):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::visibleContentOpaqueRegion):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::visibleContentOpaqueRegion):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::appendQuads):
(CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeHost::setBackgroundColor):
(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore::CCLayerTreeHostImpl::backgroundColor):
(WebCore::CCLayerTreeHostImpl::setBackgroundColor):
(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::computeOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):

  • platform/graphics/chromium/cc/CCOcclusionTracker.h:

(CCOcclusionTrackerBase):
(WebCore::CCOcclusionTrackerBase::computeVisibleRegionInScreen):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::appendQuadsToFillScreen):
(WebCore):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(WebCore):
(CCRenderPass):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::appendQuads):
(WebCore::CCTiledLayerImpl::visibleContentOpaqueRegion):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:

(WebCore::CCTiledLayerImpl::skipsDraw):
(CCTiledLayerImpl):

Source/WebKit/chromium:

  • src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setBackgroundColor):

  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::setBackgroundColor):
(WebKit):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setBackgroundColor):
(WebKit):
(WebKit::WebViewImplContentPainter::paint):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • src/WebViewImpl.h:

(WebCore):
(WebViewImpl):

  • tests/CCLayerImplTest.cpp:

(WebCore::TEST):

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKitTests::BlendStateCheckLayer::appendQuads):
(WebKitTests::TEST_F):
(WebKitTests):

  • tests/CCLayerTreeHostTest.cpp:

(WTF):
(CCLayerTreeHostTestCommit):
(WTF::CCLayerTreeHostTestCommit::CCLayerTreeHostTestCommit):
(WTF::CCLayerTreeHostTestCommit::beginTest):
(WTF::CCLayerTreeHostTestCommit::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestCommit::afterTest):
(WTF::TEST_F):
(TestLayerChromium):

  • tests/CCOcclusionTrackerTest.cpp:

(WebKitTests::TestContentLayerChromium::TestContentLayerChromium):
(WebKitTests::TestContentLayerChromium::visibleContentOpaqueRegion):
(WebKitTests::TestContentLayerChromium::setOpaqueContentsRect):
(TestContentLayerChromium):
(WebKitTests::TestContentLayerImpl::TestContentLayerImpl):
(TestContentLayerImpl):
(WebKitTests::TestContentLayerImpl::visibleContentOpaqueRegion):
(WebKitTests::TestContentLayerImpl::setOpaqueContentsRect):

  • tests/CCTiledLayerImplTest.cpp:
  • tests/LayerChromiumTest.cpp:

TBR=danakj@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10146014

10:08 Instrumentation and Metrics created by rniwa@webkit.org
10:07 Changeset [114756] by dimich@chromium.org

Unreviewed. Mark inspector/profiler/heap-snapshot-inspect-dom-wrapper.html
as TIMEOUT since it's too slow for even SLOW at the moment.

  • platform/chromium/test_expectations.txt:
10:05 Changeset [114755] by commit-queue@webkit.org

[Qt] PlatformMouseEventQt.cpp should be deleted.
https://bugs.webkit.org/show_bug.cgi?id=84437

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-20
Reviewed by Kenneth Rohde Christiansen.

  • platform/qt/PlatformMouseEventQt.cpp: Removed.
09:39 UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
09:28 Changeset [114754] by pfeldman@chromium.org

Web Inspector: follow up to r114729: more @return annotations added.
https://bugs.webkit.org/show_bug.cgi?id=84447

Reviewed by Yury Semikhatsky.

  • inspector/front-end/Resource.js:

(WebInspector.Resource):
(WebInspector.ResourceRevision.prototype.get content):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeFrame.prototype._addRequest):

  • inspector/front-end/ResourceUtils.js:

(String.prototype.asParsedURL):

09:24 Changeset [114753] by pfeldman@chromium.org

Web Inspector: migrate from ScriptsNavigator to NavigatorView in the Styles panel
https://bugs.webkit.org/show_bug.cgi?id=84459

Reviewed by Yury Semikhatsky.

Now that NavigatorView has all the functionality we need, we can use it.

  • inspector/front-end/NavigatorView.js:

(WebInspector.NavigatorScriptTreeElement.prototype.ondblclick):

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator):

  • inspector/front-end/StylesPanel.js:

(WebInspector.StylesPanel):
(WebInspector.StylesPanel.prototype._resourceAdded):
(WebInspector.StylesPanel.prototype._reset):
(WebInspector.StylesPanel.prototype._itemSelected):
(WebInspector.StylesPanel.prototype._showFile):

  • inspector/front-end/navigatorView.css:

(.navigator-tabbed-pane .tabbed-pane-content):
(.navigator-tabbed-pane .navigator-container):
(.navigator-tabbed-pane .navigator):
(.navigator-tabbed-pane .tabbed-pane-header):
(.navigator-tabbed-pane .tabbed-pane-header-contents):

  • inspector/front-end/scriptsPanel.css:
09:15 Changeset [114752] by schenney@chromium.org

Layout Test svg/transforms/transform-origin-css-property.xhtml is failing
https://bugs.webkit.org/show_bug.cgi?id=84203

Reviewed by Simon Fraser.

This test compares CSS div's n a ref-test with a single spec for transform-origin
to SVG rects with multipe specs for transform-origin that are supposed
to all be equivalent, such as [50%,50%] and [center, center]. It fails
due to one-pixel differences on Chromium.

This change renders as many divs in the ref-test as SVG rects in the
test, and ends up with the same result. It seems likely that one of
the several specs that are used is computed slightly differently
(maybe 50% is not the same as center).

  • platform/chromium/test_expectations.txt:
  • svg/transforms/transform-origin-css-property-expected.xhtml:
09:13 Changeset [114751] by schenney@chromium.org

Remove empty svg/misc directory
https://bugs.webkit.org/show_bug.cgi?id=79917

Unreviewed test directory cleanup.

  • svg/misc: Removed.
  • svg/misc/resources: Removed.
09:11 Changeset [114750] by schenney@chromium.org

SVG anchor on use fails
https://bugs.webkit.org/show_bug.cgi?id=81122

Reviewed by Rob Buis.

Adding a ref test for this bug. This seems to have been fixed, but a
regression test is in order.

  • svg/custom/anchor-on-use-expected.svg: Added.
  • svg/custom/anchor-on-use.svg: Added.
09:08 Changeset [114749] by commit-queue@webkit.org

[EFL] Add Security Origin API
https://bugs.webkit.org/show_bug.cgi?id=84023

Source/WebKit:

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-20
Reviewed by Antonio Gomes.

  • PlatformEfl.cmake:

Source/WebKit/efl:

Added an API to get a Security Origin handle from a Ewk_Frame. This is
needed for fine grained security policy. This new API will also allow
to define quota and get usage information of a Web Storage based on its
Security Origin.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-20
Reviewed by Antonio Gomes.

  • ewk/EWebKit.h:
  • ewk/ewk_frame.cpp:

(ewk_frame_security_origin_get):

  • ewk/ewk_frame.h:
  • ewk/ewk_security_origin.cpp: Added.

(ewk_security_origin_protocol_get):
(ewk_security_origin_host_get):
(ewk_security_origin_port_get):
(ewk_security_origin_web_database_usage_get):
(ewk_security_origin_web_database_quota_get):
(ewk_security_origin_web_database_quota_set):
(ewk_security_origin_free):
(ewk_security_origin_new):

  • ewk/ewk_security_origin.h: Added.
08:45 Changeset [114748] by pfeldman@chromium.org

Web Inspector: Does not have search navigation button for going through matches in either direction (prev, next)
https://bugs.webkit.org/show_bug.cgi?id=84235

Added buttons for navigating on seiarch matches in inspector panel
through button clicks as well.

Patch by Sam D <dsam2912@gmail.com> on 2012-04-20
Reviewed by Pavel Feldman.

No new tests / ux enhanced for search functionality

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • inspector/front-end/Images/searchNext.png: Added.
  • inspector/front-end/Images/searchPrev.png: Added.
  • inspector/front-end/SearchController.js:

(WebInspector.SearchController):
(WebInspector.SearchController.prototype._updateSearchNavigationButtonState):
(WebInspector.SearchController.prototype._updateSearchMatchesCountAndCurrentMatchIndex):
(WebInspector.SearchController.prototype._onNextButtonSearch):
(WebInspector.SearchController.prototype._onPrevButtonSearch):
(WebInspector.SearchController.prototype._performSearch):
(WebInspector.SearchController.prototype._createSearchNavigationButton):
(WebInspector.SearchController.prototype._populateSearchNavigationButtons):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:

(.toolbar-search-item):
(#search):
(#toolbar-search-navigation-control):
(.toolbar-search-navigation-label):
(.toolbar-search-navigation-label:hover):
(.toolbar-search-navigation-icon-prev , .toolbar-search-navigation-icon-next):
(.toolbar-search-navigation-icon-prev):
(.toolbar-search-navigation-icon-next):

  • inspector/front-end/inspector.html:
08:38 Changeset [114747] by yurys@chromium.org

2012-04-20 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Mark inspector/profiler/heap-snapshot-inspect-dom-wrapper.html
as slow in release mode.

  • platform/chromium/test_expectations.txt:
08:22 BuildBot edited by dominik.rottsches@intel.com
Pulseaudio troubleshooting (diff)
08:17 Deprecating features and vendor prefixes edited by adamk@chromium.org
(diff)
07:54 Changeset [114746] by mnaganov@chromium.org

[Chromium] Unreviewed test expectations update
https://bugs.webkit.org/show_bug.cgi?id=73991

Unmark passing tests (Vista & Win7):

fast/text/international/complex-character-based-fallback.html
fast/text/international/danda-space.html
fast/text/international/thai-baht-space.html
fast/text/international/chromium-complex-text-non-printable.html
platform/win/fast/text/uniscribe-missing-glyph.html
fast/text/international/bidi-neutral-run.html
fast/text/international/thai-line-breaks.html

  • platform/chromium/test_expectations.txt:
07:36 Changeset [114745] by mnaganov@chromium.org

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-20

  • DEPS:
06:33 Changeset [114744] by pfeldman@chromium.org

Web Inspector: extract NavigatorView and NavigatorOverlayController from ScriptsNavigator.
https://bugs.webkit.org/show_bug.cgi?id=84441

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • Moves NavigatorOverlayController out of ScriptsNavigator
  • Extracts NavigatorView from ScriptsNavigator and makes ScriptsNavigator contain 3 NavigatorView instances (one per tab)
  • Subclasses SnippetsNavigatorView and leaves it within ScriptsNavigator.
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/NavigatorOverlayController.js: Added.

(WebInspector.NavigatorOverlayController.prototype.wasShown):
(WebInspector.NavigatorOverlayController.prototype._createNavigatorControlButton):
(WebInspector.NavigatorOverlayController.prototype._escDownWhileNavigatorOverlayOpen):
(WebInspector.NavigatorOverlayController.prototype._toggleNavigator):
(WebInspector.NavigatorOverlayController.prototype._hidePinnedNavigator):
(WebInspector.NavigatorOverlayController.prototype.set _pinNavigator):
(WebInspector.NavigatorOverlayController.prototype.set showNavigatorOverlay):
(WebInspector.NavigatorOverlayController.prototype.hideNavigatorOverlay):
(WebInspector.NavigatorOverlayController.prototype._navigatorOverlayWasShown):

  • inspector/front-end/NavigatorView.js: Added.

(WebInspector.NavigatorView):
(WebInspector.NavigatorView.prototype._updateScriptTitle.get if):
(WebInspector.NavigatorView.prototype._updateScriptTitle):
(WebInspector.NavigatorView.prototype._scriptSelected):
(WebInspector.NavigatorView.prototype._removeUISourceCode.get while):
(WebInspector.NavigatorView.prototype._removeUISourceCode):
(WebInspector.NavigatorView.prototype._showScriptFoldersSettingChanged):
(WebInspector.NavigatorView.prototype._fileRenamed):
(WebInspector.NavigatorView.prototype.rename.commitHandler):
(WebInspector.NavigatorView.prototype.rename.cancelHandler):
(WebInspector.NavigatorView.prototype.rename.afterEditing):
(WebInspector.NavigatorView.prototype.reset):
(WebInspector.NavigatorView.prototype.createFolderTreeElement):
(WebInspector.NavigatorView.prototype.getOrCreateFolderTreeElement):
(WebInspector.NavigatorView.prototype.handleContextMenu):
(WebInspector.NavigatorTreeOutline):
(WebInspector.NavigatorTreeOutline._treeElementsCompare.compare.typeWeight):
(WebInspector.NavigatorTreeOutline._treeElementsCompare):
(WebInspector.NavigatorTreeOutline.prototype.scriptTreeElements):
(WebInspector.NavigatorTreeOutline.prototype.searchStarted):
(WebInspector.NavigatorTreeOutline.prototype.searchFinished):
(WebInspector.BaseNavigatorTreeElement):
(WebInspector.BaseNavigatorTreeElement.prototype.onattach):
(WebInspector.BaseNavigatorTreeElement.prototype.onreveal):
(WebInspector.BaseNavigatorTreeElement.prototype.get titleText):
(WebInspector.BaseNavigatorTreeElement.prototype.set titleText):
(WebInspector.BaseNavigatorTreeElement.prototype.matchesSearchText):
(WebInspector.NavigatorFolderTreeElement):
(WebInspector.NavigatorFolderTreeElement.prototype.get folderIdentifier):
(WebInspector.NavigatorFolderTreeElement.prototype.get isDomain):
(WebInspector.NavigatorFolderTreeElement.prototype.onattach):
(WebInspector.NavigatorScriptTreeElement):
(WebInspector.NavigatorScriptTreeElement.prototype.get uiSourceCode):
(WebInspector.NavigatorScriptTreeElement.prototype.onattach):
(WebInspector.NavigatorScriptTreeElement.prototype.onspace):
(WebInspector.NavigatorScriptTreeElement.prototype._onclick):
(WebInspector.NavigatorScriptTreeElement.prototype.onenter):
(WebInspector.NavigatorScriptTreeElement.prototype._handleContextMenuEvent):

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator):
(WebInspector.ScriptsNavigator.prototype.addUISourceCode):
(WebInspector.ScriptsNavigator.prototype.isScriptSourceAdded):
(WebInspector.ScriptsNavigator.prototype.revealUISourceCode):
(WebInspector.ScriptsNavigator.prototype.replaceUISourceCodes):
(WebInspector.ScriptsNavigator.prototype._scriptSelected):
(WebInspector.ScriptsNavigator.prototype.reset):
(WebInspector.SnippetsNavigatorView):
(WebInspector.SnippetsNavigatorView.prototype.getOrCreateFolderTreeElement):
(WebInspector.SnippetsNavigatorView.prototype._getOrCreateSnippetEvaluationsFolderTreeElement):
(WebInspector.SnippetsNavigatorView.prototype.handleContextMenu):
(WebInspector.SnippetsNavigatorView.prototype._fileRenamed):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/navigatorView.css: Added.

(.navigator-domain-tree-item .icon):
(.navigator-folder-tree-item .icon):
(.navigator-script-tree-item .icon):
(.navigator li):
(.navigator :focus li.selected):
(.navigator li.selected .selection):
(.navigator :focus li.selected .selection):
(.navigator .search-match-found li.selected .selection):
(.navigator .search-match-not-found li.selected .selection):
(.navigator .searching li.selected .selection):
(.navigator .icon):
(.navigator .base-navigator-tree-element-title):
(.navigator .base-navigator-tree-element-title.editing):
(.navigator-tree-search-box):
(.navigator-tree-search-box.visible):
(.navigator-tree-search-box > input):

  • inspector/front-end/scriptsPanel.css:

LayoutTests:

  • http/tests/inspector/debugger-test.js:
05:59 Changeset [114743] by mnaganov@chromium.org

[Chromium] Unreviewed test results update
http://code.google.com/p/chromium/issues/detail?id=123809

Rebaseline tests after Skia roll. There was a comment saying
"Rebaseline after Skia rev. 3695 lands", while Skia is
already at r3729.

  • platform/chromium-linux-x86/svg/hixie/perf/001-expected.png:
  • platform/chromium-linux-x86/svg/hixie/perf/002-expected.png:
  • platform/chromium-linux/fast/backgrounds/background-leakage-expected.png:
  • platform/chromium-linux/fast/backgrounds/background-leakage-transforms-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-complex-inner-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble05-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusGroove02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusRidge01-expected.png:
  • platform/chromium-linux/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
  • platform/chromium-linux/svg/hixie/perf/001-expected.png:
  • platform/chromium-linux/svg/hixie/perf/002-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-mac-leopard/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
  • platform/chromium-mac-leopard/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
  • platform/chromium-mac-leopard/svg/hixie/perf/001-expected.png:
  • platform/chromium-mac-leopard/svg/hixie/perf/002-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/background-leakage-transforms-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
  • platform/chromium-mac-snowleopard/svg/hixie/perf/001-expected.png:
  • platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.png:
  • platform/chromium-mac/fast/backgrounds/background-leakage-expected.png:
  • platform/chromium-mac/fast/backgrounds/background-leakage-transforms-expected.png:
  • platform/chromium-mac/fast/borders/border-radius-complex-inner-expected.png:
  • platform/chromium-mac/fast/borders/border-styles-split-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusDouble01-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusDouble02-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusGroove02-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusRidge01-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-mac/fast/writing-mode/border-styles-vertical-lr-expected.png:
  • platform/chromium-mac/fast/writing-mode/border-styles-vertical-rl-expected.png:
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.txt: Removed.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt: Removed.
  • platform/chromium-mac/svg/hixie/perf/001-expected.png:
  • platform/chromium-mac/svg/hixie/perf/002-expected.png:
  • platform/chromium-win/fast/backgrounds/background-leakage-expected.png:
  • platform/chromium-win/fast/backgrounds/background-leakage-transforms-expected.png:
  • platform/chromium-win/fast/borders/border-radius-complex-inner-expected.png:
  • platform/chromium-win/fast/borders/border-radius-groove-02-expected.png:
  • platform/chromium-win/fast/borders/border-styles-split-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusGroove02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusRidge01-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
  • platform/chromium-win/svg/hixie/perf/001-expected.png:
  • platform/chromium-win/svg/hixie/perf/002-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/efl/fast/borders/border-radius-complex-inner-expected.txt: Removed.
05:30 Changeset [114742] by mnaganov@chromium.org

[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=29359

Unmark passing fast/forms/date/date-appearance.html

  • platform/chromium/test_expectations.txt:
05:07 Changeset [114741] by mnaganov@chromium.org

[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=83826

Remove now passing test from expectations:

fast/text/drawBidiText.html
fast/text/international/bidi-listbox-atsui.html

  • platform/chromium/test_expectations.txt:
04:58 Changeset [114740] by pfeldman@chromium.org

Web Inspector: make ScriptNavigatorController use views only, rename to NavigatorOverlayController.
https://bugs.webkit.org/show_bug.cgi?id=84352

Reviewed by Vsevolod Vlasov.

This change makes navigator controller use view interfaces only. Focus machinery has been refactored in order
to make it possible: now all view ancestors can either override "focus" or "defaultFocusedElement" method
with latter method being preferred.

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.defaultFocusedElement):

  • inspector/front-end/ExtensionPanel.js:

(WebInspector.ExtensionPanel.prototype.defaultFocusedElement):

  • inspector/front-end/Panel.js:

(WebInspector.Panel.prototype.wasShown):
(WebInspector.Panel.prototype.defaultFocusedElement):

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator):
(WebInspector.NavigatorOverlayController.prototype._hidePinnedNavigator):
(WebInspector.NavigatorOverlayController.prototype.set _pinNavigator):
(WebInspector.NavigatorOverlayController.prototype.set showNavigatorOverlay):
(WebInspector.NavigatorOverlayController.prototype.hideNavigatorOverlay):
(WebInspector.NavigatorOverlayController.prototype._navigatorOverlayWasShown):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.defaultFocusedElement):

  • inspector/front-end/SidebarOverlay.js:

(WebInspector.SidebarOverlay.prototype.show):
(WebInspector.SidebarOverlay.prototype.hide):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.defaultFocusedElement):

  • inspector/front-end/StylesPanel.js:

(WebInspector.StylesPanel):

  • inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer.prototype.get view):
(WebInspector.TabbedEditorContainer.prototype.get visibleView):

  • inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPane):
(WebInspector.TabbedPane.prototype.defaultFocusedElement):

  • inspector/front-end/TextViewer.js:

(WebInspector.TextViewer.prototype.defaultFocusedElement):
(WebInspector.TextEditorMainPanel.prototype.defaultFocusedElement):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype.defaultFocusedElement):

  • inspector/front-end/View.js:

(WebInspector.View.prototype._collectViewHierarchy):
(WebInspector.View.prototype.defaultFocusedElement):
(WebInspector.View.prototype.setDefaultFocusedElement):
(WebInspector.View.prototype.focus):

04:57 Changeset [114739] by mnaganov@chromium.org

[Chromium] Unreviewed test expectations update.
http://code.google.com/p/chromium/issues/detail?id=124313

Mark fast/css/font-face-opentype.html and fast/css/font-face-woff.html
as crashing on Debug XP.

  • platform/chromium/test_expectations.txt:
04:48 Changeset [114738] by mnaganov@chromium.org

[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84432

Mark several fast/filesystem tests as failing on Windows.

  • platform/chromium/test_expectations.txt:
03:56 Changeset [114737] by commit-queue@webkit.org

[EFL] [DRT] Send double click event from EventSender
https://bugs.webkit.org/show_bug.cgi?id=82867

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-20
Reviewed by Daniel Bates.

Tools:

Add support for EFL DumpRenderTree EventSender to send
double click events.

  • DumpRenderTree/efl/EventSender.cpp:

(sendMouseEvent):

LayoutTests:

Unskip tests connected with double click simulation.

  • platform/efl/Skipped:
03:54 Changeset [114736] by sergio@webkit.org

[GTK] Enable Web Timing
https://bugs.webkit.org/show_bug.cgi?id=42432

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Added WebTiming support to the GTK+ port. WebTiming allows
developers to collect detailed network timing information per
resource. It requires the new SoupMessage's "network-event"
signal.

  • GNUmakefile.am:
  • bindings/gobject/GNUmakefile.am:
  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore):
(WebCore::restartedCallback):
(WebCore::sendRequestCallback):
(WebCore::milisecondsSinceRequest):
(WebCore::wroteBodyCallback):
(WebCore::requestStartedCallback):
(WebCore::networkEventCallback):
(WebCore::startHTTPRequest):
(WebCore::ResourceHandle::platformSetDefersLoading):
(WebCore::ResourceHandle::defaultSession):

Tools:

Build web timing by default whenever build-webkit is used.

  • Scripts/build-webkit:

LayoutTests:

Removed some tests that are working fine now after adding Web
Timing support.

  • platform/gtk/test_expectations.txt:
03:28 Changeset [114735] by mnaganov@chromium.org

[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84427

Mark platform/chromium/editing/spelling/delete-misspelled-word.html as
PASS/TIMEOUT on Mac and Win debug.

  • platform/chromium/test_expectations.txt:
03:02 Changeset [114734] by pfeldman@chromium.org

Not reviewed: fixed chromium sanity tests for inspector via assigning last path component
to entire url for parsed urls with invalid specs.

Source/WebCore:

  • inspector/front-end/ResourceUtils.js:

(WebInspector.ParsedURL):

Source/WebKit/chromium:

  • src/js/Tests.js:

(.TestSuite.prototype._scriptsAreParsed):

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

02:44 Changeset [114733] by dbates@webkit.org

[EFL] Add missing reset for setAuthorAndUserStylesEnabled inside DRT.
https://bugs.webkit.org/show_bug.cgi?id=84430

Patch by Kamil Blank <k.blank@samsung.com> on 2012-04-20
Reviewed by Daniel Bates.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

02:30 Changeset [114732] by haraken@chromium.org

Unreviewed, rolling out r114401.
http://trac.webkit.org/changeset/114401
https://bugs.webkit.org/show_bug.cgi?id=84161

Chromium crash

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(NativeToJSValue):

  • bindings/scripts/test/V8/V8Float64Array.h:

(WebCore):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestInterface.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestNode.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestObj.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(WebCore::toV8):

  • bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8CSSRuleCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8CSSStyleSheetCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8CSSValueCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8CanvasPixelArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8DOMTokenListCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8EntryCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8EntrySyncCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8EventCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Float32ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Float64ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8HTMLElementCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8IDBAnyCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8IDBKeyCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8ImageDataCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Int16ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Int32ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Int8ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::toV8Slow):

  • bindings/v8/custom/V8SVGDocumentCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8SVGElementCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8SVGPathSegCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8ScriptProfileCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8StyleSheetCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Uint16ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Uint32ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Uint8ArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::toV8):

02:29 Changeset [114731] by haraken@chromium.org

Unreviewed, rolling out r114440.
http://trac.webkit.org/changeset/114440
https://bugs.webkit.org/show_bug.cgi?id=84173

Chromium crash

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::toV8Slow):

02:28 Changeset [114730] by haraken@chromium.org

Unreviewed, rolling out r114519.
http://trac.webkit.org/changeset/114519
https://bugs.webkit.org/show_bug.cgi?id=84202

Chromium crash

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

  • bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):
(WebCore::V8Float64Array::wrap):
(WebCore):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):
(WebCore::V8TestActiveDOMObject::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):
(WebCore::V8TestCustomNamedGetter::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):
(WebCore::V8TestEventConstructor::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):
(WebCore::V8TestEventTarget::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):
(WebCore::V8TestInterface::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):
(WebCore::V8TestMediaQueryListListener::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):
(WebCore::V8TestNamedConstructor::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestNode.h:

(V8TestNode):
(WebCore::V8TestNode::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):
(WebCore::V8TestObj::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):
(WebCore::V8TestSerializedScriptValueInterface::wrap):
(WebCore::toV8):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::toV8Slow):

  • bindings/v8/custom/V8SVGDocumentCustom.cpp:

(WebCore::toV8):

  • dom/make_names.pl:

(printWrapperFactoryCppFile):

02:15 Changeset [114729] by pfeldman@chromium.org

Web Inspector: replace @type annotation with @return annotation for getters
https://bugs.webkit.org/show_bug.cgi?id=84362

Reviewed by Yury Semikhatsky.

Otherwise, compiler does not check for errors.

  • inspector/front-end/AdvancedSearchController.js:

(WebInspector.SearchView.prototype.get searchConfig):

  • inspector/front-end/BreakpointManager.js:
  • inspector/front-end/NetworkRequest.js:

(WebInspector.NetworkRequest.prototype.requestContent):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeFrame):
(WebInspector.ResourceTreeFrame.prototype._navigate):

  • inspector/front-end/ScriptsNavigator.js:
  • inspector/front-end/Settings.js:
  • inspector/front-end/SnippetsModel.js:
  • inspector/front-end/SplitView.js:
  • inspector/front-end/TabbedEditorContainer.js:
  • inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPaneTab):

  • inspector/front-end/TextEditorModel.js:
  • inspector/front-end/TimelinePresentationModel.js:
01:49 Changeset [114728] by pilgrim@chromium.org

[Chromium] Call cacheMetadata directly
https://bugs.webkit.org/show_bug.cgi?id=84415

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

  • platform/network/chromium/ResourceHandle.cpp:

(WebCore::ResourceHandle::cacheMetadata):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore):

01:41 Changeset [114727] by pilgrim@chromium.org

[Chromium] Call stopSharedTimer directly
https://bugs.webkit.org/show_bug.cgi?id=84418

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

  • platform/chromium/SharedTimerChromium.cpp:

(WebCore::stopSharedTimer):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore):

00:50 Changeset [114726] by mnaganov@chromium.org

[Chromium] Unreviewed test results update.

Remove unneeded test results.

  • platform/chromium-win-xp/fast/ruby/floating-ruby-text-expected.txt: Removed.
  • platform/chromium-win-xp/fast/ruby/positioned-ruby-text-expected.txt: Removed.
  • platform/chromium/fast/ruby/floating-ruby-text-expected.txt: Removed.
  • platform/chromium/fast/ruby/positioned-ruby-text-expected.txt: Removed.
00:42 Changeset [114725] by rniwa@webkit.org

REGRESSION(r112781): Windows build slaves are no longer including .pdb files in archives handed to testers
https://bugs.webkit.org/show_bug.cgi?id=84424

Reviewed by Mark Rowe.

Let Windows and Chromium have their own list of files to copy.

  • BuildSlaveSupport/built-product-archive:

(removeDirectoryIfExists):
(copyBuildFiles):
(archiveBuiltProduct):

00:40 Changeset [114724] by commit-queue@webkit.org

DOMFileSystem::scheduleCallback() crashes on file() call after reload.
https://bugs.webkit.org/show_bug.cgi?id=76461

DOMFileSystem::scheduleCallback() is unavailable when the page in unloading, so we should
avoid using it in callback.

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-04-20
Reviewed by David Levin.

Source/WebCore:

Test: fast/filesystem/file-after-reload-crash.html

  • Modules/filesystem/DOMFileSystem.cpp:

(WebCore):

LayoutTests:

  • fast/filesystem/file-after-reload-crash-expected.txt: Added.
  • fast/filesystem/file-after-reload-crash.html: Added.
00:37 April 2012 Meeting edited by sh4.seo@samsung.com
(diff)
00:33 Changeset [114723] by mnaganov@chromium.org

[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84427

Mark platform/chromium/editing/spelling/delete-misspelled-word.html as
timing out on Linux debug.

  • platform/chromium/test_expectations.txt:
00:27 Changeset [114722] by commit-queue@webkit.org

[EFL] Add setting API for author and user styles.
https://bugs.webkit.org/show_bug.cgi?id=82860

Patch by Kamil Blank <k.blank@samsung.com> on 2012-04-20
Reviewed by Daniel Bates.

Source/WebKit/efl:

Add missing implementation setAuthorAndUserStylesEnabled to EFL's
DumpRenderTreeSupport.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

Tools:

Implementation of setAuthorAndUserStylesEnabled.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setAuthorAndUserStylesEnabled):

LayoutTests:

Enable test connected with setAuthorAndUserStylesEnabled.

  • platform/efl/Skipped:
  • platform/efl/fast/css/disabled-author-styles-expected.txt: Added.

04/19/12:

23:58 Changeset [114721] by commit-queue@webkit.org

[EFL] Missing keycode translation for space key
https://bugs.webkit.org/show_bug.cgi?id=84153

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-19
Reviewed by Antonio Gomes.

Source/WebCore:

Map space key to Unicode value in createKeyMap(), and also set
correct keyname 'space' for space key in createWindowsKeyMap().

Tests: fast/html/details-keyboard-show-hide.html

fast/forms/button-spacebar-click.html

  • platform/efl/EflKeyboardUtilities.cpp:

(WebCore::createKeyMap):

Tools:

Set keyname for space key before dispatching event.

  • DumpRenderTree/efl/EventSender.cpp:

(keyNameFromJSValue):

LayoutTests:

Unskip tests connected with space key.

  • platform/efl/Skipped:
23:53 April 2012 MeetingRethinkingRendering edited by dbarton@mathscribe.com
(diff)
23:47 Changeset [114720] by carlosgc@webkit.org

[GTK] Allow to use WebInspector in GtkLauncher
https://bugs.webkit.org/show_bug.cgi?id=84143

Reviewed by Martin Robinson.

  • GNUmakefile.am: Add new files to compilation.
  • GtkLauncher/LauncherInspectorWindow.c: Added.

(launcherInspectorWindowFinalize):
(launcher_inspector_window_init):
(launcher_inspector_window_class_init):
(inspectedURIChanged): Update the window title based on current
inspected URI.
(showInspectorWindow): Show inspector window.
(closeInspectorWindow): Hide inspector window.
(launcherInspectorWindowNew): Create an inspector window.
(launcherInspectorWindowGetWebView): Return the inspected web view.

  • GtkLauncher/LauncherInspectorWindow.h: Added.
  • GtkLauncher/main.c:

(inspectorInspectWebViewCb): Create an inspector window.
(createBrowser): Connect to inspect-web-view signal of the view
inspector.

23:44 Changeset [114719] by carlosgc@webkit.org

[GTK] Ignore resources while replacing content in WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=79777

Reviewed by Philippe Normand.

  • UIProcess/API/gtk/WebKitResourceLoadClient.cpp:

(didSendRequestForResource): Return early if resources is Null.
(didReceiveResponseForResource): Ditto.
(didReceiveContentLengthForResource): Ditto.
(didFinishLoadForResource): Ditto.
(didFailLoadForResource): Ditto.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewLoadChanged): Clear resources before checking
whether we are replacing content.
(webkitWebViewIsReplacingContentOrDidReplaceContent): Helper
function to check whether view is replacing content or current
content is replaced.
(webkitWebViewResourceLoadStarted): Do not create resources when
replacing content.
(webkitWebViewGetLoadingWebResource): Ignore when replacing
content. Also add an assert when getting a loading resources to
make sure we only return Null when replacing content.
(webkitWebViewRemoveLoadingWebResource): Ditto.
(webkitWebViewResourceLoadFinished): Ditto.

  • UIProcess/API/gtk/tests/TestResources.cpp:

(replacedContentResourceLoadStartedCallback):
(testWebViewResourcesReplacedContent):
(beforeAll):

23:18 Changeset [114718] by commit-queue@webkit.org

Inserting empty html moves caret.
https://bugs.webkit.org/show_bug.cgi?id=71771

Patch by Antaryami Pandia <antaryami.pandia@motorola.com> on 2012-04-19
Reviewed by Ryosuke Niwa.

Source/WebCore:

When we place the cursor in the middle of a text node and try to insert some text
between, then we split text node. But in this case we have nothing to insert since
the string to be inserted is empty. So the check for fragments should precedes the
call to code block containing splitTextNode.

Test: editing/inserting/insert-empty-html.html

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::doApply):

LayoutTests:

Test inserting empty html.

  • editing/inserting/insert-empty-html-expected.txt: Added.
  • editing/inserting/insert-empty-html.html: Added.
22:35 Changeset [114717] by lforschler@apple.com

Versioning.

22:23 Changeset [114716] by lforschler@apple.com

New Tag.

21:49 WebComponentsStatusMeetingNotes edited by paulirish@chromium.org
formatting! (diff)
20:35 Changeset [114715] by commit-queue@webkit.org

[BlackBerry] Update HTTP connection per host limit in ResourceRequestBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=84380

Patch by Tay Grigg <tgrigg@rim.com> on 2012-04-19
Reviewed by George Staikos.

Reviewed Internally by: George Rizkalla, Lyon Chen

Set the limit on the http connection count per host to the default
of 10000, queue the requests in the networking layer instead,
this should increase parallelism at the WebKit layer to remove
any potential bottlenecks.

  • platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::initializeMaximumHTTPConnectionCountPerHost):

20:29 Changeset [114714] by commit-queue@webkit.org

Media Stream API: Piece of code cleanup for the chromium port
https://bugs.webkit.org/show_bug.cgi?id=84328

Patch by Jeremy Mao <yujie.mao@intel.com> on 2012-04-19
Reviewed by Kent Tamura.

Source/WebKit/chromium:

Remove some deprecated interfaces.

No new tests. No behavior changes.

  • public/WebUserMediaClient.h:

Remove deprecated requestUserMedia interface.

  • public/WebUserMediaRequest.h:

Remove deprecated requestSucceeded interface.

  • src/UserMediaClientImpl.cpp:

(WebKit::UserMediaClientImpl::requestUserMedia):
Use the requestUserMedia split sources implementation.

  • src/WebUserMediaRequest.cpp:

Remove deprecated requestSucceeded implementation.

Tools:

WebUserMediaClientMock use an old requestUserMedia interface and
Replace it with the new interface.

  • DumpRenderTree/chromium/WebUserMediaClientMock.cpp:

(WebKit::WebUserMediaClientMock::requestUserMedia):
Remove the old requestUserMedia and replace it with the new.

  • DumpRenderTree/chromium/WebUserMediaClientMock.h:

(WebUserMediaClientMock):

19:32 Changeset [114713] by dimich@chromium.org

Unreviewed, rolling out r114711.
http://trac.webkit.org/changeset/114711
https://bugs.webkit.org/show_bug.cgi?id=84412

Many tests crash in RenderObject::container() (Requested by
dimich on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-19

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::computeNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::ScrollingCoordinator::frameViewScrollableAreasDidChange):

19:07 Changeset [114712] by dimich@chromium.org

Not reviewed, re-update baselines for new tests
added in http://trac.webkit.org/changeset/114666
and then modified in http://trac.webkit.org/changeset/114685

  • platform/chromium-linux/fast/ruby/floating-ruby-text-expected.txt: Removed.
  • platform/chromium-linux/fast/ruby/positioned-ruby-text-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/ruby/floating-ruby-text-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/ruby/positioned-ruby-text-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/ruby/floating-ruby-text-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/ruby/positioned-ruby-text-expected.txt: Removed.
  • platform/chromium-mac/fast/ruby/floating-ruby-text-expected.txt: Removed.
  • platform/chromium-mac/fast/ruby/positioned-ruby-text-expected.txt: Removed.
  • platform/chromium-win-vista/fast/ruby/floating-ruby-text-expected.txt: Removed.
  • platform/chromium-win-vista/fast/ruby/positioned-ruby-text-expected.txt: Removed.
  • platform/chromium-win/fast/ruby/floating-ruby-text-expected.txt: Removed.
  • platform/chromium-win/fast/ruby/positioned-ruby-text-expected.txt: Removed.
  • platform/chromium/fast/ruby/floating-ruby-text-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/ruby/floating-ruby-text-expected.txt.
  • platform/chromium/fast/ruby/positioned-ruby-text-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/ruby/positioned-ruby-text-expected.txt.
18:40 Changeset [114711] by andersca@apple.com

computeNonFastScrollableRegion needs to traverse the entire frame tree
https://bugs.webkit.org/show_bug.cgi?id=84409
<rdar://problem/11285741>

Reviewed by Dan Bernstein.

Now that scrollable areas won't be in the set of scrollable areas unless they are actually scrollable, we need to look for scrollable
areas in the entire frame tree since there can be a scrollable frame that's a subframe of a non-scrollable frame for example.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::computeNonFastScrollableRegion):
Traverse the entire frame tree looking for scrollable areas. Also, remove the scrollability checks because scrollable areas will only be
in the set if they have scrollbars that are enabled.

(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::ScrollingCoordinator::frameViewScrollableAreasDidChange):
computeNonFastScrollableRegion now takes the main frame.

18:40 Changeset [114710] by hbono@chromium.org

Merge 114350 - Stack overflow in CSS parser caused by recursive stylesheet import
https://bugs.webkit.org/show_bug.cgi?id=83545

Patch by David Barr <davidbarr@chromium.org> on 2012-04-16
Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: http/tests/css/css-imports-redirect-cycle.html

  • css/CSSImportRule.cpp:

(WebCore::StyleRuleImport::requestStyleSheet):

LayoutTests:

  • http/tests/css/css-imports-redirect-cycle-expected.txt: Added.
  • http/tests/css/css-imports-redirect-cycle.css: Added.
  • http/tests/css/css-imports-redirect-cycle.html: Added.

BUG=122606
TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10143006

18:14 Changeset [114709] by hbono@chromium.org

Merge 114267 - [chromium] wrong justification for arabic/persian page in cr-win.
https://bugs.webkit.org/show_bug.cgi?id=83227

Reviewed by Kent Tamura.

Source/WebCore:

Disable kashida justification if using Skia to draw.

Test: fast/text/international/arabic-justify.html

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::justify):

LayoutTests:

  • fast/text/international/arabic-justify.html: Added.
  • platform/chromium-win/fast/text/international/arabic-justify-expected.png: Added.
  • platform/chromium-win/fast/text/international/arabic-justify-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/text/international/arabic-justify-expected.txt: Added.
  • platform/mac-snowleopard/fast/text/international/arabic-justify-expected.png: Added.
  • platform/mac-snowleopard/fast/text/international/arabic-justify-expected.txt: Added.
  • platform/mac/fast/text/international/arabic-justify-expected.txt: Added.
  • platform/qt/fast/text/international/arabic-justify-expected.txt: Added.

TBR=xji@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10154002

17:59 Internals_Hackathon edited by kaustubh@motorola.com
(diff)
17:58 Changeset [114708] by jsbell@chromium.org

[Chromium] IndexedDB: Prep for changing keyPath return type
https://bugs.webkit.org/show_bug.cgi?id=84208

To introduce Array-type key paths (see http://webkit.org/b/84207) the keyPath() accessors
on WebIDBObjectStore and WebIDBIndex need to change return type. To do so requires temporarily
changing the method names to keyPathString with compatibility shims (on the WebKit side)
then switching the implementation in the Chromium port in a follow-up patch.

Reviewed by Kent Tamura.

  • public/WebIDBIndex.h:

(WebKit::WebIDBIndex::keyPath):
(WebKit::WebIDBIndex::keyPathString):

  • public/WebIDBObjectStore.h:

(WebKit::WebIDBObjectStore::keyPath):
(WebKit::WebIDBObjectStore::keyPathString):

  • src/WebIDBIndexImpl.cpp:

(WebKit::WebIDBIndexImpl::keyPathString):

  • src/WebIDBIndexImpl.h:

(WebIDBIndexImpl):

  • src/WebIDBObjectStoreImpl.cpp:

(WebKit::WebIDBObjectStoreImpl::keyPathString):

  • src/WebIDBObjectStoreImpl.h:

(WebIDBObjectStoreImpl):

17:50 Changeset [114707] by andersca@apple.com

Focus ring on wikipedia gets blobs when you type
https://bugs.webkit.org/show_bug.cgi?id=84407
<rdar://problem/11011847>

Reviewed by Dan Bernstein.

Make it possible to override the focus ring visible rect from layer drawing code.

  • platform/graphics/mac/WebLayer.mm:

(drawLayerContents):
Call ThemeMac::setFocusRingClipRect to set the focus ring clip rect while drawing.

  • platform/mac/ThemeMac.h:
  • platform/mac/ThemeMac.mm:

(-[WebCoreFlippedView _focusRingVisibleRect]):
If there's an active focus ring visible rect, use it. Otherwise, fall back to the previous behavior
and just return the view's visible rect.

(WebCore::ThemeMac::setFocusRingClipRect):
Update the focus clip rect.

17:48 Changeset [114706] by jer.noble@apple.com

Rollout r114674.

New tests added in http://trac.webkit.org/changeset/114685 made the
platform results added in http://trac.webkit.org/changeset/114674
unnecessary.

  • platform/mac/fast/ruby/floating-ruby-text-expected.txt: Removed.
  • platform/mac/fast/ruby/positioned-ruby-text-expected.txt: Removed.
17:37 Changeset [114705] by ostapenko.viatcheslav@nokia.com

[Qt] ASSERT(m_thread == currentThread()) on Mac when threaded rendering is enabled for the Qt scenegraph
https://bugs.webkit.org/show_bug.cgi?id=84278

Reviewed by Noam Rosenthal.

Delete the whole layer tree on UI side when paint node is deleted and force resync of the layers when
page becomes visible again.

  • UIProcess/LayerTreeHostProxy.cpp:

(WebKit::LayerTreeHostProxy::purgeBackingStores):

  • UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::WebLayerTreeRenderer::WebLayerTreeRenderer):
(WebKit::WebLayerTreeRenderer::purgeGLResources):
(WebKit::WebLayerTreeRenderer::appendUpdate):
(WebKit::WebLayerTreeRenderer::setActive):
(WebKit):

  • UIProcess/WebLayerTreeRenderer.h:

(WebLayerTreeRenderer):

  • UIProcess/qt/QtWebPageSGNode.cpp:

(WebKit::ContentsSGNode::ContentsSGNode):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::purgeBackingStores):

17:33 Changeset [114704] by jer.noble@apple.com

Partial rollout of r114673.

Test plugins/npp-set-window-called-during-destruction.html passes on mac-wk2,
but fails on mac. Update test_expectations so that both results are expected.

  • platform/mac/test_expectations.txt:
17:33 Changeset [114703] by dimich@chromium.org

Unreviewed, rolling out r114690.
http://trac.webkit.org/changeset/114690
https://bugs.webkit.org/show_bug.cgi?id=84408

Broke GlueSerializeTest.BackwardsCompatibleTest in Chromium
test_shell_tests (Requested by dimich on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-19

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::HistoryItem):

  • loader/HistoryController.cpp:

(WebCore::HistoryController::restoreScrollPositionAndViewState):

17:23 Deprecating features and vendor prefixes created by adamk@chromium.org
17:17 Changeset [114702] by oliver@apple.com

Exception stack traces aren't complete when the exception starts in native code
https://bugs.webkit.org/show_bug.cgi?id=84073

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Refactored building the stack trace to so that we can construct
it earlier, and don't rely on any prior work performed in the
exception handling machinery. Also updated LLInt and the DFG to
completely initialise the callframes of host function calls.

Also fixed a few LLInt paths that failed to correctly update the
topCallFrame.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • dfg/DFGJITCompiler.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

  • interpreter/Interpreter.cpp:

(JSC::eval):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::addStackTraceIfNecessary):
(JSC):
(JSC::Interpreter::throwException):

  • interpreter/Interpreter.h:

(Interpreter):

  • jit/JITCall.cpp:

(JSC::JIT::compileOpCall):

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileOpCall):

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTINativeCall):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTINativeCall):

  • jsc.cpp:

(functionJSCStack):

  • llint/LLIntExceptions.cpp:

(JSC::LLInt::interpreterThrowInCaller):
(JSC::LLInt::returnToThrow):
(JSC::LLInt::callToThrow):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::handleHostCall):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • parser/Parser.h:

(JSC::::parse):

  • runtime/Error.cpp:

(JSC::addErrorInfo):
(JSC::throwError):

  • runtime/Error.h:

(JSC):

LayoutTests:

Update tests to show complete trace information

  • fast/js/exception-properties-expected.txt:
  • fast/js/script-tests/exception-properties.js:
  • fast/js/script-tests/stack-trace.js:

(selfRecursive1):

  • fast/js/stack-trace-expected.txt:
17:12 Changeset [114701] by dimich@chromium.org

[Chromium] Rebaselining new tests added in http://trac.webkit.org/changeset/114666
Not reviewed.

  • platform/chromium-linux-x86/fast/ruby/floating-ruby-text-expected.txt: Added.
  • platform/chromium-linux-x86/fast/ruby/positioned-ruby-text-expected.txt: Added.
  • platform/chromium-linux/fast/ruby/floating-ruby-text-expected.txt: Added.
  • platform/chromium-linux/fast/ruby/positioned-ruby-text-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/ruby/floating-ruby-text-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/ruby/positioned-ruby-text-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/ruby/floating-ruby-text-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/ruby/positioned-ruby-text-expected.txt: Added.
  • platform/chromium-mac/fast/ruby/floating-ruby-text-expected.txt: Added.
  • platform/chromium-mac/fast/ruby/positioned-ruby-text-expected.txt: Added.
  • platform/chromium-win-vista/fast/ruby/floating-ruby-text-expected.txt: Added.
  • platform/chromium-win-vista/fast/ruby/positioned-ruby-text-expected.txt: Added.
  • platform/chromium-win-xp/fast/ruby/floating-ruby-text-expected.txt: Added.
  • platform/chromium-win-xp/fast/ruby/positioned-ruby-text-expected.txt: Added.
  • platform/chromium-win/fast/ruby/floating-ruby-text-expected.txt: Added.
  • platform/chromium-win/fast/ruby/positioned-ruby-text-expected.txt: Added.
17:11 Changeset [114700] by kling@webkit.org

ElementAttributeData should be fast-malloc'd.
<http://webkit.org/b/84405>

Reviewed by Antti Koivisto.

Sprinkle missing WTF_MAKE_FAST_ALLOCATED.

  • dom/ElementAttributeData.h:

(ElementAttributeData):

17:10 April 2012 Meeting edited by adamk@chromium.org
(diff)
17:08 Changeset [114699] by commit-queue@webkit.org

REGRESSION(r112177): Numbered list item rendered bulleted
https://bugs.webkit.org/show_bug.cgi?id=84216

Patch by David Barr <davidbarr@chromium.org> on 2012-04-19
Reviewed by Ryosuke Niwa.

Shorthands that imply omitted values cannot be derived from
an incomplete set of longhand rules.

No new tests; updated existing tests that should have caught this.

Source/WebCore:

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseTransformOriginShorthand):
Set implicit initial for Z when omitted.

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getShorthandValue):

LayoutTests:

  • css3/flexbox/css-properties.html:
  • fast/css/cssText-shorthand.html:
  • fast/css/uri-token-parsing-expected.txt:
  • fast/css/uri-token-parsing.html:
  • fast/dom/css-dom-read-2-expected.txt:
17:06 Internals_Hackathon edited by ravi.kasibhatla@motorola.com
(diff)
17:05 Changeset [114698] by mhahnenberg@apple.com

We're collecting pathologically due to small allocations
https://bugs.webkit.org/show_bug.cgi?id=84404

Reviewed by Geoffrey Garen.

No change in performance on run-jsc-benchmarks.

  • dfg/DFGSpeculativeJIT.h: Replacing m_firstFreeCell with m_freeList.

(JSC::DFG::SpeculativeJIT::emitAllocateBasicJSObject):

  • heap/CopiedSpace.cpp: Getting rid of any water mark related stuff, since it's no

longer useful.
(JSC::CopiedSpace::CopiedSpace):
(JSC::CopiedSpace::tryAllocateSlowCase): We now only call didAllocate here rather than
carrying out a somewhat complicated accounting job for our old water mark throughout CopiedSpace.
(JSC::CopiedSpace::tryAllocateOversize): Call the new didAllocate to notify the Heap of
newly allocated stuff.
(JSC::CopiedSpace::tryReallocateOversize):
(JSC::CopiedSpace::doneFillingBlock):
(JSC::CopiedSpace::doneCopying):
(JSC::CopiedSpace::destroy):

  • heap/CopiedSpace.h:

(CopiedSpace):

  • heap/CopiedSpaceInlineMethods.h:

(JSC::CopiedSpace::startedCopying):

  • heap/Heap.cpp: Removed water mark related stuff, replaced with new bytesAllocated and

bytesAllocatedLimit to track how much memory has been allocated since the last collection.
(JSC::Heap::Heap):
(JSC::Heap::reportExtraMemoryCostSlowCase):
(JSC::Heap::collect): We now set the new limit of bytes that we can allocate before triggering
a collection to be the size of the Heap after the previous collection. Thus, we still have our
2x allocation amount.
(JSC::Heap::didAllocate): Notifies the GC activity timer of how many bytes have been allocated
thus far and then adds the new number of bytes to the current total.
(JSC):

  • heap/Heap.h: Removed water mark related stuff.

(JSC::Heap::notifyIsSafeToCollect):
(Heap):
(JSC::Heap::shouldCollect):
(JSC):

  • heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::tryAllocateHelper): Refactored to use MarkedBlock's new FreeList struct.
(JSC::MarkedAllocator::allocateSlowCase):
(JSC::MarkedAllocator::addBlock):

  • heap/MarkedAllocator.h:

(MarkedAllocator):
(JSC::MarkedAllocator::MarkedAllocator):
(JSC::MarkedAllocator::allocate):
(JSC::MarkedAllocator::zapFreeList): Refactored to take in a FreeList instead of a FreeCell.

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::specializedSweep):
(JSC::MarkedBlock::sweep):
(JSC::MarkedBlock::sweepHelper):
(JSC::MarkedBlock::zapFreeList):

  • heap/MarkedBlock.h:

(FreeList): Added a new struct that keeps track of the current MarkedAllocator's
free list including the number of bytes of stuff in the free list so that when the free list is
exhausted, the correct amount can be reported to Heap.
(MarkedBlock):
(JSC::MarkedBlock::FreeList::FreeList):
(JSC):

  • heap/MarkedSpace.cpp: Removing all water mark related stuff.

(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::resetAllocators):

  • heap/MarkedSpace.h:

(MarkedSpace):
(JSC):

  • heap/WeakSet.cpp:

(JSC::WeakSet::findAllocator): Refactored to use the didAllocate interface with the Heap. This
function still needs work though now that the Heap knows how many bytes have been allocated
since the last collection.

  • jit/JITInlineMethods.h: Refactored to use MarkedBlock's new FreeList struct.

(JSC::JIT::emitAllocateBasicJSObject): Ditto.

  • llint/LowLevelInterpreter.asm: Ditto.
  • runtime/GCActivityCallback.cpp:

(JSC::DefaultGCActivityCallback::didAllocate):

  • runtime/GCActivityCallback.h:

(JSC::GCActivityCallback::didAllocate): Renamed willAllocate to didAllocate to indicate that
the allocation that is being reported has already taken place.
(DefaultGCActivityCallback):

  • runtime/GCActivityCallbackCF.cpp:

(JSC):
(JSC::DefaultGCActivityCallback::didAllocate): Refactored to return early if the amount of
allocation since the last collection is not above a threshold (initially arbitrarily chosen to
be 128KB).

17:05 Changeset [114697] by peter@chromium.org

[Chromium] Don't compile FontCacheSkia for Android
https://bugs.webkit.org/show_bug.cgi?id=84392

Reviewed by Kent Tamura.

Chromium for the Android platform uses its own FontCacheAndroid
implementation. Compile errors show up when trying to build the
content shell.

  • WebCore.gyp/WebCore.gyp:
17:03 Internals_Hackathon edited by ryuan.choi@samsung.com
(diff)
17:01 Internals_Hackathon edited by mxie@rim.com
(diff)
16:59 Internals_Hackathon edited by levin@chromium.org
(diff)
16:58 Internals_Hackathon edited by morrita@google.com
(diff)
16:58 Internals_Hackathon edited by mxie@rim.com
(diff)
16:57 Internals_Hackathon edited by ap@apple.com
(diff)
16:56 Internals_Hackathon edited by gyuyoung.kim@samsung.com
(diff)
16:55 Internals_Hackathon edited by ravi.kasibhatla@motorola.com
(diff)
16:54 Changeset [114696] by commit-queue@webkit.org

[Cairo] Remove rgb24-hacks.txt and scale-removal.txt
https://bugs.webkit.org/show_bug.cgi?id=83475

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-04-19
Reviewed by Daniel Bates.

No new tests. This does not change functionality.

Remove some obsolete patch files for Cairo that were used in some
very old versions of Safari for Windows.

  • platform/graphics/cairo/rgb24-hacks.txt: Removed.
  • platform/graphics/cairo/scale-removal.txt: Removed.
16:54 Internals_Hackathon edited by ravi.kasibhatla@motorola.com
(diff)
16:53 Internals_Hackathon edited by tomz@codeaurora.org
(diff)
16:52 Changeset [114695] by fpizlo@apple.com

MacroAssemblerARMv7::branchTruncateDoubleToUint32 should obey the overflow signal
https://bugs.webkit.org/show_bug.cgi?id=84401

Reviewed by Gavin Barraclough.

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::branchTruncateDoubleToUint32):

16:52 Internals_Hackathon edited by kaustubh@motorola.com
(diff)
16:52 Internals_Hackathon edited by gyuyoung.kim@samsung.com
(diff)
16:50 Internals_Hackathon edited by ap@apple.com
(diff)
16:50 Changeset [114694] by commit-queue@webkit.org

[EFL] DRT console messages should contain only the file name part of local URIs
https://bugs.webkit.org/show_bug.cgi?id=84236

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-04-19
Reviewed by Kentaro Hara.

Tools:

Process console messages before printing them in EFL's DumpRenderTree
them so that they contain only the file name part of local URIs. This
is what is expected by test cases.

  • DumpRenderTree/efl/DumpRenderTreeView.cpp:

(urlSuitableForTestResult):
(onConsoleMessage):

LayoutTests:

Remove from the skip list the tests which expect only the file name
part of local URIs to be displayed in console messages now that it has
been fixed in EFL's DumpRenderTree.

  • platform/efl/Skipped:
16:49 Internals_Hackathon edited by tomz@codeaurora.org
(diff)
16:48 Internals_Hackathon edited by tomz@codeaurora.org
(diff)
16:47 Internals_Hackathon edited by efidler@rim.com
(diff)
16:46 Changeset [114693] by commit-queue@webkit.org

transforms/no_transform_hit_testing.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=82415

Patch by Florin Malita <fmalita@google.com> on 2012-04-19
Reviewed by Simon Fraser.

Convert the test to text-only (dumpAsText) to avoid inconsistent pixel results.

  • platform/chromium-linux/transforms/no_transform_hit_testing-expected.png: Removed.
  • platform/chromium-mac-leopard/transforms/no_transform_hit_testing-expected.png: Removed.
  • platform/chromium-mac-snowleopard/transforms/no_transform_hit_testing-expected.png: Removed.
  • platform/chromium-mac/transforms/no_transform_hit_testing-expected.png: Removed.
  • platform/chromium-win/transforms/no_transform_hit_testing-expected.png: Removed.
  • platform/chromium-win/transforms/no_transform_hit_testing-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/efl/transforms/no_transform_hit_testing-expected.png: Removed.
  • platform/efl/transforms/no_transform_hit_testing-expected.txt: Removed.
  • platform/gtk/transforms/no_transform_hit_testing-expected.txt: Removed.
  • platform/mac-leopard/transforms/no_transform_hit_testing-expected.png: Removed.
  • platform/mac/transforms/no_transform_hit_testing-expected.png: Removed.
  • platform/mac/transforms/no_transform_hit_testing-expected.txt: Removed.
  • platform/qt-mac/transforms/no_transform_hit_testing-expected.txt: Removed.
  • platform/qt/transforms/no_transform_hit_testing-expected.png: Removed.
  • platform/qt/transforms/no_transform_hit_testing-expected.txt: Removed.
  • transforms/no_transform_hit_testing-expected.txt: Added.
  • transforms/no_transform_hit_testing.html:
16:45 Internals_Hackathon edited by gyuyoung.kim@samsung.com
(diff)
16:43 Internals_Hackathon edited by tomz@codeaurora.org
(diff)
16:42 Internals_Hackathon edited by tomz@codeaurora.org
(diff)
16:42 Internals_Hackathon edited by morrita@google.com
(diff)
16:41 Changeset [114692] by jamesr@google.com

[chromium] Unreviewed, update chromium expectations for various compositing layout tests

  • platform/chromium/test_expectations.txt:
16:39 Internals_Hackathon edited by kaustubh@motorola.com
(diff)
16:38 Changeset [114691] by peter@chromium.org

Use sqrtf instead of sqrt in CanvasRenderingContext2D.cpp
https://bugs.webkit.org/show_bug.cgi?id=84403

Reviewed by Andreas Kling.

r114679 broke Chromium Win and Android bots due to call
ambiguity between a double and float argument.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::inflateStrokeRect):

16:34 Internals_Hackathon edited by dtharp@codeaurora.org
(diff)
16:30 Internals_Hackathon edited by efidler@rim.com
(diff)
16:30 Changeset [114690] by commit-queue@webkit.org

Default to null value for HistoryItem::m_pageScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=84385

Patch by Alexandre Elias <aelias@google.com> on 2012-04-19
Reviewed by Nate Chapin.

Previously, HistoryItem::m_pageScaleFactor defaulted to a value
of 1, making it impossible to determine whether this value was never
set, or intentionally set to 1. This patch introduces a default value
of 0 and makes restoreScrollPositionAndViewState not touch the page
scale factor if this value is still present at time of reload.

This is a no-op change for common navigation scenarios. The
motivation for this change is the corner case of syncing history items
from a desktop browser to a mobile device. In that case, we need a
way to specify that the history item does not contain a
pageScaleFactor so that the mobile device does not display the page
overly zoomed in.

No new tests.

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::HistoryItem):

  • loader/HistoryController.cpp:

(WebCore::HistoryController::restoreScrollPositionAndViewState):

16:28 Internals_Hackathon edited by kaustubh@motorola.com
(diff)
16:27 Changeset [114689] by alexis.menard@openbossa.org

Unreviewed Qt build warning fix.

The file editing/StringHelper.h does not exist.

  • Target.pri:
16:27 Internals_Hackathon edited by morrita@google.com
(diff)
16:26 Internals_Hackathon edited by morrita@google.com
(diff)
16:19 Internals_Hackathon edited by morrita@google.com
(diff)
16:17 Internals_Hackathon edited by kaustubh@motorola.com
(diff)
16:03 Internals_Hackathon edited by ap@apple.com
(diff)
16:01 Changeset [114688] by dbates@webkit.org

Remove empty directory Source/WebCore/webaudio

Changeset 111474 <http://trac.webkit.org/changeset/111474> moved all the files in
Source/WebCore/webaudio to Source/WebCore/Modules/webaudio. We should remove the
empty directory Source/WebCore/webaudio.

  • webaudio: Removed.
16:00 Changeset [114687] by mahesh.kulkarni@nokia.com

[Qt][Wk2] unskip page-reload-cancel-permission-requests from geolocation for wk2
https://bugs.webkit.org/show_bug.cgi?id=84293

Reviewed by Tor Arne Vestbø.

Unskipped page-reload-cancel-permission-requests after r105988.

  • platform/qt-5.0-wk2/Skipped:
16:00 Internals_Hackathon edited by efidler@rim.com
(diff)
15:59 Changeset [114686] by kling@webkit.org

[chromium] Add simplified API for iterating over a WebElement's attributes.
<http://webkit.org/b/84183>

Reviewed by Dimitri Glazkov.

Add attributeCount(), attributeLocalName(index) and attributeValue(index) to the
WebElement API so that call sites currently using WebNamedNodeMap can be
converted, which will ultimately allow us to refactor WebCore::Attribute
on <http://webkit.org/b/83440>.

  • public/WebElement.h:
  • src/WebElement.cpp:

(WebKit::WebElement::attributeCount):
(WebKit::WebElement::attributeLocalName):
(WebKit::WebElement::attributeValue):

15:59 Internals_Hackathon edited by ap@apple.com
(diff)
15:59 Internals_Hackathon edited by morrita@google.com
(diff)
15:58 Internals_Hackathon edited by ap@apple.com
(diff)
15:57 April 2012 Meeting edited by morrita@google.com
(diff)
15:54 Internals_Hackathon edited by ap@apple.com
(diff)
15:53 Internals_Hackathon created by ap@apple.com
15:49 Changeset [114685] by commit-queue@webkit.org

New ruby tests broken on Mac
https://bugs.webkit.org/show_bug.cgi?id=84382

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-04-19
Reviewed by Eric Seidel.

Tweaking new tests to make them render the same on all platforms.

  • fast/ruby/floating-ruby-text-expected.txt:
  • fast/ruby/floating-ruby-text.html:
  • fast/ruby/positioned-ruby-text-expected.txt:
  • fast/ruby/positioned-ruby-text.html:
15:44 Changeset [114684] by commit-queue@webkit.org

KeywordLookupGenerator.py should take an output file as an argument
https://bugs.webkit.org/show_bug.cgi?id=84292

Patch by Don Olmstead <don.olmstead@am.sony.com> on 2012-04-19
Reviewed by Eric Seidel.

Extended KeywordLookupGenerator to accept an additional argument specifying an output file. If this argument is found stdout is redirected to a file for the duration of the script.

  • KeywordLookupGenerator.py:
15:33 Changeset [114683] by psolanki@apple.com

Incorrect inter-caps in “ShouldSkipMetaData” etc.
https://bugs.webkit.org/show_bug.cgi?id=72159

Reviewed by Dan Bernstein.

No new tests since no change in functionality.

  • platform/graphics/ImageSource.h:
  • platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::imageSourceOptions):
(WebCore::ImageSource::isSizeAvailable):
(WebCore::ImageSource::frameSizeAtIndex):
(WebCore::ImageSource::orientationAtIndex):
(WebCore::ImageSource::getHotSpot):
(WebCore::ImageSource::repetitionCount):
(WebCore::ImageSource::createFrameAtIndex):
(WebCore::ImageSource::frameDurationAtIndex):

15:12 Changeset [114682] by commit-queue@webkit.org

[EFL] [DRT] Should create offline storage inside DUMPRENDERTREE_TEMP
https://bugs.webkit.org/show_bug.cgi?id=84169

All databases were being created inside ~/.webkit which was causing
flaky tests when running multiple tests in parallel, specially timeouts
due to concurrency.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-19
Reviewed by Eric Seidel.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::initialize):

15:10 Changeset [114681] by dbates@webkit.org

Update Build Location notice on Mac debug instructions to reflect changes in Xcode 4.3.2
https://bugs.webkit.org/show_bug.cgi?id=84364

Reviewed by Eric Seidel.

As of Xcode 4.3.2, the build location "Locations Specified by Targets" has been renamed to
"Legacy".

  • building/debug-mac-uiprocess.html:
  • building/debug.html:
15:07 Changeset [114680] by commit-queue@webkit.org

Canvas more precisely makes the bounding rect for stroke rendering.
https://bugs.webkit.org/show_bug.cgi?id=75792

Patch by Huang Dongsung <luxtella@company100.net> on 2012-04-19
Reviewed by Simon Fraser.

  • fast/canvas/canvas-strokePath-cap-join-expected.txt: Added.
  • fast/canvas/canvas-strokePath-cap-join.html: Added.
  • fast/canvas/script-tests/canvas-strokePath-cap-join.js: Added.
15:05 Changeset [114679] by commit-queue@webkit.org

Canvas more precisely makes the bounding rect for stroke rendering.
https://bugs.webkit.org/show_bug.cgi?id=75792

Patch by Huang Dongsung <luxtella@company100.net> on 2012-04-19
Reviewed by Simon Fraser.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::stroke):
(WebCore::CanvasRenderingContext2D::drawTextInternal):
(WebCore::CanvasRenderingContext2D::inflateStrokeRect):
(WebCore):

  • html/canvas/CanvasRenderingContext2D.h:

(CanvasRenderingContext2D):

15:03 Changeset [114678] by macpherson@chromium.org

Eliminate potential null pointer dereference in CSSStyleSelector::containsUncommonAttributeSelector().
https://bugs.webkit.org/show_bug.cgi?id=84366

Reviewed by Kentaro Hara.

No new tests / code cleanup only.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

15:00 Changeset [114677] by macpherson@chromium.org

Fix null-pointer dereference in ApplyPropertyZoom::applyValue().
https://bugs.webkit.org/show_bug.cgi?id=84279

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/css/zoom-on-unattached.html

  • css/CSSStyleApplyProperty.cpp:

(WebCore::ApplyPropertyZoom::applyValue):

LayoutTests:

  • fast/css/zoom-on-unattached-expected.txt: Added.
  • fast/css/zoom-on-unattached.html: Added.
14:56 Changeset [114676] by macpherson@chromium.org

Clean up list iteration in MediaQueryExp constructor (avoid unnecessary calls to current()).
https://bugs.webkit.org/show_bug.cgi?id=84369

Reviewed by Simon Fraser.

No new tests / code cleanup only.

  • css/MediaQueryExp.cpp:

(WebCore::MediaQueryExp::MediaQueryExp):

14:55 Changeset [114675] by fpizlo@apple.com

It should be possible to perform debugCall on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=84381

Reviewed by Oliver Hunt.

debugCall() was clobbering the argument to the call it was making, leading to a
corrupt ExecState*. This change fixes that issue by using a scratch register that
does not clobber arguments, and it also introduces more assertions that we have
a valid call frame.

  • dfg/DFGAssemblyHelpers.cpp:

(DFG):
(JSC::DFG::AssemblyHelpers::jitAssertHasValidCallFrame):

  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::selectScratchGPR):
(AssemblyHelpers):
(JSC::DFG::AssemblyHelpers::debugCall):
(JSC::DFG::AssemblyHelpers::jitAssertHasValidCallFrame):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::linkOSRExits):

  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::selectScratchGPR):

14:48 April 2012 Meeting edited by rniwa@webkit.org
(diff)
14:32 Changeset [114674] by jer.noble@apple.com

REGRESSION (r114666): fast/ruby/floating-ruby-text.html, fast/ruby/positioned-ruby-text.html failing on Lion Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=84384

Add platform/mac baselines for new ruby tests.

  • platform/mac/fast/ruby/floating-ruby-text-expected.txt: Added.
  • platform/mac/fast/ruby/positioned-ruby-text-expected.txt: Added.
14:29 Changeset [114673] by barraclough@apple.com

Check in correct expectations for some passing tests.

Rubber stamped by Oliver Hunt.

  • platform/mac/test_expectations.txt:
14:26 Changeset [114672] by dgrogan@chromium.org

Remove description from calls to indexedDB.open
https://bugs.webkit.org/show_bug.cgi?id=84109

open() used to take two parameters, a database name and an optional
string database description. The description was deprecated. An
optional integer version parameter was recently added in its place.

This change removes the description parameter from calls that still
had it so that it's not interpreted as a version.

Reviewed by Eric Seidel.

  • storage/indexeddb/create-object-store-options-expected.txt:
  • storage/indexeddb/createObjectStore-name-argument-required-expected.txt:
  • storage/indexeddb/createObjectStore-null-name-expected.txt:
  • storage/indexeddb/cursor-update-value-argument-required-expected.txt:
  • storage/indexeddb/database-odd-names-expected.txt:
  • storage/indexeddb/deleteObjectStore-name-argument-required-expected.txt:
  • storage/indexeddb/deleteObjectStore-null-name-expected.txt:
  • storage/indexeddb/factory-basics-expected.txt:
  • storage/indexeddb/index-get-key-argument-required-expected.txt:
  • storage/indexeddb/invalid-keys-expected.txt:
  • storage/indexeddb/key-sort-order-across-types-expected.txt:
  • storage/indexeddb/key-sort-order-date-expected.txt:
  • storage/indexeddb/key-type-array-expected.txt:
  • storage/indexeddb/key-type-infinity-expected.txt:
  • storage/indexeddb/keypath-basics-expected.txt:
  • storage/indexeddb/keypath-fetch-key-expected.txt:
  • storage/indexeddb/objectStore-required-arguments-expected.txt:
  • storage/indexeddb/odd-strings-expected.txt:
  • storage/indexeddb/readonly-expected.txt:
  • storage/indexeddb/readonly-properties-expected.txt:
  • storage/indexeddb/resources/create-object-store-options.js:

(test):

  • storage/indexeddb/resources/createObjectStore-name-argument-required.js:

(test):

  • storage/indexeddb/resources/createObjectStore-null-name.js:

(test):

  • storage/indexeddb/resources/cursor-update-value-argument-required.js:

(test):

  • storage/indexeddb/resources/database-odd-names.js:

(openNextDatabase):

  • storage/indexeddb/resources/deleteObjectStore-name-argument-required.js:

(test):

  • storage/indexeddb/resources/deleteObjectStore-null-name.js:

(test):

  • storage/indexeddb/resources/factory-basics.js:

(test):
(getDatabaseNamesSuccess1):

  • storage/indexeddb/resources/index-get-key-argument-required.js:

(test):

  • storage/indexeddb/resources/invalid-keys.js:

(test):

  • storage/indexeddb/resources/key-sort-order-across-types.js:

(test):

  • storage/indexeddb/resources/key-sort-order-date.js:

(test):

  • storage/indexeddb/resources/key-type-array.js:

(test):

  • storage/indexeddb/resources/key-type-infinity.js:

(test):

  • storage/indexeddb/resources/keypath-basics.js:

(test):

  • storage/indexeddb/resources/keypath-fetch-key.js:

(test):

  • storage/indexeddb/resources/objectStore-required-arguments.js:

(test):

  • storage/indexeddb/resources/odd-strings.js:

(openNextDatabase):
(verifyNextDatabase):

  • storage/indexeddb/resources/readonly-properties.js:

(test):

  • storage/indexeddb/resources/readonly.js:

(test):

  • storage/indexeddb/resources/setVersion-null.js:

(test):

  • storage/indexeddb/resources/setVersion-undefined.js:

(test):

  • storage/indexeddb/resources/transaction-and-objectstore-calls.js:

(test):

  • storage/indexeddb/resources/transaction-storeNames-required.js:

(test):

  • storage/indexeddb/resources/value-undefined.js:

(test):

  • storage/indexeddb/resources/values-odd-types.js:

(test):

  • storage/indexeddb/setVersion-null-expected.txt:
  • storage/indexeddb/setVersion-undefined-expected.txt:
  • storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
  • storage/indexeddb/transaction-storeNames-required-expected.txt:
  • storage/indexeddb/value-undefined-expected.txt:
  • storage/indexeddb/values-odd-types-expected.txt:
14:24 Changeset [114671] by pilgrim@chromium.org

[Chromium] Call signedPublicKeyAndChallengeString directly
https://bugs.webkit.org/show_bug.cgi?id=84372

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

  • platform/chromium/SSLKeyGeneratorChromium.cpp:

(WebCore::signedPublicKeyAndChallengeString):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore):

14:22 Changeset [114670] by macpherson@chromium.org

Remove unnecessary assignment in CSSParser::parseCubicBezierTimingFunctionValue().
https://bugs.webkit.org/show_bug.cgi?id=84368

Reviewed by Simon Fraser.

No new tests / code cleanup only.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseCubicBezierTimingFunctionValue):

14:20 Changeset [114669] by macpherson@chromium.org

Initialize all member variables in CSSImageSetValue's copy constructor.
https://bugs.webkit.org/show_bug.cgi?id=84379

Reviewed by Simon Fraser.

No new tests / code cleanup only.

  • css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::CSSImageSetValue):

14:19 April 2012 Meeting edited by wingo@igalia.com
(diff)
13:54 April 2012 Meeting edited by wingo@igalia.com
(diff)
13:53 Changeset [114668] by pilgrim@chromium.org

[Chromium] Call audioHardwareBufferSize directly
https://bugs.webkit.org/show_bug.cgi?id=84370

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

  • src/AudioDestinationChromium.cpp:

(WebCore::AudioDestinationChromium::AudioDestinationChromium):

13:34 Changeset [114667] by philn@webkit.org

Unreviewed, GTK test_expectations update after r114640.

  • platform/gtk/test_expectations.txt:
13:15 Changeset [114666] by commit-queue@webkit.org

Positioned children of ruby runs not handled correctly during layout
https://bugs.webkit.org/show_bug.cgi?id=84157

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-04-19
Reviewed by Julien Chaffraix.

Source/WebCore:

A positioned ruby text causes a problem because it is excluded from
normal layout by its parent and instead gets layout from
RenderRubyRun::layoutSpecialExcludedChild; however this means it gets
skipped over during the loop in RenderBlock::layoutBlockChildren,
which is where positioned RenderBlocks get added to the appropriate
positioned object lists. As a result, a dirty positioned ruby text
will not get layout again unless the RenderRubyRun also needs layout
which is not guaranteed.

This patch disqualifies ruby text elements from being positioned.
If it is necessary to support this in future, ruby text layout will
have to be modified to ensure the renderers are added to the
appropriate block lists.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::adjustRenderStyle):

  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::rubyText):

LayoutTests:

  • fast/ruby/modify-positioned-ruby-text-crash-expected.txt: Added
  • fast/ruby/modify-positioned-ruby-text-crash.html: Exercises the crash condition

in but 84157 relating to positioned ruby text. This is being added
in case support for positioned ruby text is added in future, so that
we can guard against regression.

  • fast/ruby/floating-ruby-text-expected.png: Added
  • fast/ruby/floating-ruby-text-expected.txt: Added
  • fast/ruby/floating-ruby-text.html: Creates a positioned ruby text. The

position should be ignored.

  • fast/ruby/positioned-ruby-text-expected.png: Added
  • fast/ruby/positioned-ruby-text-expected.txt: Added
  • fast/ruby/positioned-ruby-text.html: Creates a floating ruby text. The

float should be ignored.

12:27 April 2012 MeetingRethinkingRendering edited by dpranke@chromium.org
(diff)
12:22 April 2012 MeetingRethinkingRendering edited by dpranke@chromium.org
(diff)
12:20 April 2012 MeetingRethinkingRendering edited by dpranke@chromium.org
(diff)
12:19 April 2012 Meeting edited by komoroske@chromium.org
Added link to Web Components notes (diff)
12:18 April 2012 MeetingRethinkingRendering edited by dpranke@chromium.org
(diff)
12:18 WebComponentsStatusMeetingNotes created by komoroske@chromium.org
Initial commit; may fix formatting later.
12:12 Changeset [114665] by commit-queue@webkit.org

DevTools: assertion failure upon devtools window reopen.
https://bugs.webkit.org/show_bug.cgi?id=53493

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-04-19
Reviewed by Pavel Feldman.

The pointers pointed to by WebInspector must be reset explicitly
in WebInspector::didClose() method

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::closeInspectorFrontend):

  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::didClose):

12:11 Accelerated rendering and compositing edited by jonlee@apple.com
(diff)
12:08 Changeset [114664] by fpizlo@apple.com

LLInt no-JIT fallback native call trampoline's exception handler incorrectly assumes that
the PB/PC has been preserved
https://bugs.webkit.org/show_bug.cgi?id=84367

Reviewed by Oliver Hunt.

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
11:59 April 2012 MeetingRethinkingRendering edited by dpranke@chromium.org
(diff)
11:56 Changeset [114663] by vsevik@chromium.org

Web Inspector: No response body available for cached resource requests with error status codes.
https://bugs.webkit.org/show_bug.cgi?id=84265

Reviewed by Pavel Feldman.

Source/WebCore:

InspectorResourceAgent now saves failed subresource request response body in its cache.
Saved data is shown on front-end.

Test: http/tests/inspector/network/network-image-404.html

  • inspector/InspectorResourceAgent.cpp:

(WebCore::isErrorStatusCode):
(WebCore):
(WebCore::InspectorResourceAgent::didReceiveData):

  • inspector/NetworkResourcesData.cpp:

(WebCore::NetworkResourcesData::ResourceData::removeContent):
(WebCore::NetworkResourcesData::ResourceData::purgeContent):
(WebCore):
(WebCore::NetworkResourcesData::responseReceived):
(WebCore::NetworkResourcesData::setResourceContent):

  • inspector/NetworkResourcesData.h:

(ResourceData):
(WebCore::NetworkResourcesData::ResourceData::httpStatusCode):
(WebCore::NetworkResourcesData::ResourceData::setHTTPStatusCode):

  • inspector/front-end/RequestView.js:

(WebInspector.RequestView.hasTextContent):

LayoutTests:

  • http/tests/inspector/network/network-image-404-expected.txt: Added.
  • http/tests/inspector/network/network-image-404.html: Added.
  • http/tests/inspector/network/resources/404.php: Added.
11:51 April 2012 MeetingRethinkingRendering edited by dpranke@chromium.org
(diff)
11:50 Changeset [114662] by yurys@chromium.org

Web Inspector / Heap snapshots: "Object's retaining tree" view doesn't get cleared when navigating between objects
https://bugs.webkit.org/show_bug.cgi?id=84337

When DataGrid root node is reset, make sure all existing rows are removed.

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGrid.prototype.setRootNode):

11:47 Changeset [114661] by bdakin@apple.com

https://bugs.webkit.org/show_bug.cgi?id=80534
REGRESSION: When Safari is not frontmost, pages should not get mouse moves or
hover

Reviewed by Adele Peterson.

This patch just adds some code back that was removed by
http://trac.webkit.org/changeset/102632 This particular code was unrelated to that
bug and should not have been removed.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseMoveEvent):

11:46 Accelerated rendering and compositing edited by jonlee@apple.com
(diff)
11:44 Changeset [114660] by fpizlo@apple.com

It should be possible to load from Float64 arrays on ARMv7 without crashing
https://bugs.webkit.org/show_bug.cgi?id=84361

Reviewed by Oliver Hunt.

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::loadDouble):
(JSC::MacroAssemblerARMv7::storeDouble):

11:42 April 2012 MeetingRethinkingRendering edited by dpranke@chromium.org
(diff)
11:42 Changeset [114659] by wangxianzhu@chromium.org

DevTools highlights elements in frames at un-scaled positions
https://bugs.webkit.org/show_bug.cgi?id=84181

Source/WebCore:

On mobile platforms (e.g. chromium-android), normally pages are scaled,
thus the coordinations of highlight rect inside of a frame needs to
consider not only the offset, but also the scale. The change uses
FrameView::contentsToRootView() to map the coordinates of a node in
a frame to the coordinates in the main frame, instead of calculating
by only the offset.

Reviewed by Pavel Feldman.

Test: inspector/elements/highlight-node-scaled.html

  • inspector/DOMNodeHighlighter.cpp:

LayoutTests:

The new test case is a scaled web page containing an iframe. It tests
if the highlight rect of an element in the iframe is correct.

Reviewed by Pavel Feldman.

  • inspector/elements/highlight-node-scaled-expected.txt: Added.
  • inspector/elements/highlight-node-scaled.html: Added.
  • inspector/elements/resources/highlight-node-scaled-iframe.html: Added.
11:38 Changeset [114658] by yurys@chromium.org

Web Inspector / Heap snapshots: "Objects allocated ..." views are empty
https://bugs.webkit.org/show_bug.cgi?id=84347

Pass parsed maxJSObjectId value to the profile header constructor.

Reviewed by Pavel Feldman.

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfileHeader):
(WebInspector.ProfilesPanel.prototype.setRecordingProfile):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
(WebInspector.ProfilerDispatcher.prototype.addProfileHeader):

11:36 April 2012 Meeting edited by jacobg@adobe.com
(diff)
11:35 April 2012 Meeting edited by dpranke@chromium.org
(diff)
11:33 April 2012 Meeting edited by jacobg@adobe.com
(diff)
11:33 April 2012 MeetingRethinkingRendering created by dpranke@chromium.org
11:30 UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
11:30 UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
11:28 April 2012 Meeting edited by rniwa@webkit.org
(diff)
11:27 Changeset [114657] by ap@apple.com

AVFoundation: media/video-size-intrinsic-scale.html test fails, and the movie is drawn incorrectly
https://bugs.webkit.org/show_bug.cgi?id=66601

Reviewed by Eric Carlson.

  • platform/mac-snowleopard/media/video-size-intrinsic-scale-expected.txt: Added.

Copied passing result, since this doesn't fail on Snow Leopard.

  • platform/mac/media/video-size-intrinsic-scale-expected.txt: Added a failing results to make

bots green.

11:25 Changeset [114656] by beidson@apple.com

<rdar://problem/10664148> and https://bugs.webkit.org/show_bug.cgi?id=84360 StorageThread should have an autorelease pool in place for Cocoa clients

Reviewed by Eric Carlson.

No new tests. (Not practical to test this with current tools)

  • storage/StorageThread.cpp:

(WebCore::StorageThread::threadEntryPoint): Include an AutodrainedPool and cycle it after each message.

11:20 Changeset [114655] by macpherson@chromium.org

Fix potential null pointer dereference in RuleSet::addRulesFromSheet().
https://bugs.webkit.org/show_bug.cgi?id=84258

Reviewed by Andreas Kling.

Fix variable that is dereferenced without null check here, but checked in code above and below.

No new test / code cleanup from coverity analysis.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

11:19 Accelerated rendering and compositing edited by jonlee@apple.com
(diff)
11:19 Accelerated rendering and compositing edited by jonlee@apple.com
(diff)
11:18 Accelerated rendering and compositing created by jonlee@apple.com
Initial draft
11:18 Changeset [114654] by yurys@chromium.org

Web Inspector: exception when hovering object while paused
https://bugs.webkit.org/show_bug.cgi?id=84358

Added missing boolean parameter to the call site of evaluate method
on call frame.

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/AdvancedSearchController.js:
  • inspector/front-end/DebuggerPresentationModel.js: annotated slectedCallFrame

method so that closure compiler catches errors like in the bug report.
(WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype._resolveObjectForPopover):

11:17 Changeset [114653] by commit-queue@webkit.org

[GTK] 3 fast/ layout tests failing after upgrading libsoup to 2.37.92
https://bugs.webkit.org/show_bug.cgi?id=82484

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-19
Reviewed by Martin Robinson.

Tools:

Bumping libsoup to version 2.38.1 which fixes the above WebKit bug.

  • efl/jhbuild.modules:
  • gtk/jhbuild.modules:

LayoutTests:

Unskipping tests that were previously failing due to a bug in libsoup.

  • platform/gtk/test_expectations.txt:
11:17 April 2012 Meeting edited by jonlee@apple.com
(diff)
11:14 April 2012 Meeting edited by danakj@chromium.org
(diff)
11:11 Changeset [114652] by yurys@chromium.org

Web Inspector: nodes are not removed from the summary view when switching between allocation ranges
https://bugs.webkit.org/show_bug.cgi?id=84354

Clear all top level nodes not only those visible in the viewport when populating
the constructors view with new content.

Reviewed by Pavel Feldman.

  • inspector/front-end/HeapSnapshotDataGrids.js:

(WebInspector.HeapSnapshotSortableDataGrid.prototype.dispose):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.topLevelNodes):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.changeNameFilter):
(WebInspector.HeapSnapshotViewportDataGrid.prototype.topLevelNodes):
(WebInspector.HeapSnapshotViewportDataGrid.prototype.removeTopLevelNodes):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):

11:05 MeetingNotesLayoutModes edited by mjs@apple.com
(diff)
11:03 Changeset [114651] by commit-queue@webkit.org

Source/WebCore: [chromium] Allow scrolling non-root layers in the compositor thread
https://bugs.webkit.org/show_bug.cgi?id=73350

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-04-19
Reviewed by James Robinson.

This patch enables scrolling child layers in the compositor thread.
Scroll deltas are accumulated for each scrolled CCLayerImpl and
synchronized to the main thread.

If a layer has no room to scroll in a given direction, one of its
ancestor layers is scrolled instead if possible.

Added new webkit_unit_tests to verify scrolling behavior.

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::scrollBy):
(WebCore):

  • platform/graphics/chromium/ContentLayerChromium.h:

(ContentLayerDelegate):
(ContentLayerChromium):

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(WebCore::GraphicsLayerChromium::didScroll):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setMaxScrollPosition):
(WebCore):
(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):
(WebCore::LayerChromium::maxScrollPosition):
(WebCore::LayerChromium::scrollable):
(WebCore::LayerChromium::scrollBy):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::findLayerInSubtree):
(WebCore):
(WebCore::CCLayerImpl::tryScroll):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::findLayerById):
(WebCore):
(WebCore::findFirstScrollableLayer):
(WebCore::CCLayerTreeHost::applyScrollAndScale):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::startPageScaleAnimation):
(WebCore::CCLayerTreeHostImpl::contentSize):
(WebCore):
(WebCore::CCLayerTreeHostImpl::calculateVisibleLayers):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):
(WebCore::findRootScrollLayer):
(WebCore::findScrollLayerForContentLayer):
(WebCore::CCLayerTreeHostImpl::setRootLayer):
(WebCore::adjustScrollsForPageScaleChange):
(WebCore::applyPageScaleDeltaToScrollLayers):
(WebCore::CCLayerTreeHostImpl::setPageScaleFactorAndLimits):
(WebCore::CCLayerTreeHostImpl::setPageScaleDelta):
(WebCore::CCLayerTreeHostImpl::updateMaxScrollPosition):
(WebCore::CCLayerTreeHostImpl::scrollBegin):
(WebCore::CCLayerTreeHostImpl::scrollBy):
(WebCore::CCLayerTreeHostImpl::scrollEnd):
(WebCore::CCLayerTreeHostImpl::pinchGestureUpdate):
(WebCore::CCLayerTreeHostImpl::computePinchZoomDeltas):
(WebCore::CCLayerTreeHostImpl::makeScrollAndScaleSet):
(WebCore::collectScrollDeltas):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):
(WebCore::CCLayerTreeHostImpl::animatePageScale):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore::CCLayerTreeHostImpl::rootScrollLayer):
(CCLayerTreeHostImpl):
(LayerGeometry):

Source/WebKit/chromium: [chromium] Add tests for scrolling non-root layers in the compositor thread
https://bugs.webkit.org/show_bug.cgi?id=73350

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-04-19
Reviewed by James Robinson.

  • src/WebContentLayerImpl.cpp:

(WebKit::WebContentLayerImpl::didScroll):
(WebKit):

  • src/WebContentLayerImpl.h:

(WebContentLayerImpl):

  • tests/CCLayerImplTest.cpp:

(WebCore::TEST):
(WebCore):

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKitTests::CCLayerTreeHostImplTest::createScrollableLayer):
(CCLayerTreeHostImplTest):
(WebKitTests::CCLayerTreeHostImplTest::initializeLayerRendererAndDrawFrame):
(WebKitTests::TEST_F):
(WebKitTests):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::TestOpacityChangeLayerDelegate::didScroll):
(WTF::MockContentLayerDelegate::paintContents):
(WTF::MockContentLayerDelegate::didScroll):
(CCLayerTreeHostTestScrollChildLayer):
(WTF::CCLayerTreeHostTestScrollChildLayer::CCLayerTreeHostTestScrollChildLayer):
(WTF::CCLayerTreeHostTestScrollChildLayer::beginTest):
(WTF::CCLayerTreeHostTestScrollChildLayer::applyScrollAndScale):
(WTF::CCLayerTreeHostTestScrollChildLayer::beginCommitOnCCThread):
(WTF::CCLayerTreeHostTestScrollChildLayer::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestScrollChildLayer::afterTest):
(WTF):
(WTF::TEST_F):

10:55 MeetingNotesLayoutModes edited by mjs@apple.com
(diff)
10:53 Changeset [114650] by annacc@chromium.org

Space out captions-fast.vtt to prevent flakiness in media/track/track-mode.html.
https://bugs.webkit.org/show_bug.cgi?id=83878

Reviewed by Eric Carlson.

  • media/track/captions-webvtt/captions-fast.vtt:
  • media/track/track-mode-expected.txt:
  • media/track/track-mode.html:
10:44 MeetingNotesLayoutModes edited by mjs@apple.com
(diff)
10:41 MeetingNotesLayoutModes edited by mjs@apple.com
(diff)
10:39 MeetingNotesLayoutModes edited by mjs@apple.com
(diff)
10:39 MeetingNotesLayoutModes created by mjs@apple.com
10:11 Changeset [114649] by yurys@chromium.org

Web Inspector: make constructors and diff heap snapshot data grids use viewport
https://bugs.webkit.org/show_bug.cgi?id=84348

HeapSnapshotViewportDataGrid is introduced which allows to add to the tbody only
visible rows. HeapSnapshotConstructorsDataGrid and HeapSnapshotDiffDataGrid are
inherited from this class which makes them operate well on large amounts of nodes.

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGridNode.prototype.nodeHeight):
(WebInspector.DataGridNode.prototype._attach):

  • inspector/front-end/HeapSnapshotDataGrids.js:

(WebInspector.HeapSnapshotSortableDataGrid):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.nodesForNameFilter):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.changeNameFilter):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.appendChildAfterSorting):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.updateVisibleNodes):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingEnter):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingLeave):
(WebInspector.HeapSnapshotViewportDataGrid):
(WebInspector.HeapSnapshotViewportDataGrid.prototype.nodesForNameFilter):
(WebInspector.HeapSnapshotViewportDataGrid.prototype.appendChildAfterSorting):
(WebInspector.HeapSnapshotViewportDataGrid.prototype.updateVisibleNodes):
(WebInspector.HeapSnapshotViewportDataGrid.prototype.appendTopLevelNode):
(WebInspector.HeapSnapshotViewportDataGrid.prototype._addPaddingRows):
(WebInspector.HeapSnapshotViewportDataGrid.prototype._removePaddingRows):
(WebInspector.HeapSnapshotViewportDataGrid.prototype.onResize):
(WebInspector.HeapSnapshotViewportDataGrid.prototype._onScroll):
(WebInspector.HeapSnapshotPaddingNode):
(WebInspector.HeapSnapshotPaddingNode.prototype.setHeight):
(WebInspector.HeapSnapshotPaddingNode.prototype.removeFromTable):
(WebInspector.HeapSnapshotConstructorsDataGrid):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotDiffDataGrid):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived.addNodeIfNonZeroDiff):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren):

  • inspector/front-end/HeapSnapshotGridNodes.js:

(WebInspector.HeapSnapshotGridNode):
(WebInspector.HeapSnapshotGridNode.prototype.collapse):
(WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort.afterPopulate):
(WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort):
(WebInspector.HeapSnapshotGridNode.prototype.sort):
(WebInspector.HeapSnapshotObjectNode.prototype._createChildNode):
(WebInspector.HeapSnapshotObjectNode.prototype.comparator):
(WebInspector.HeapSnapshotInstanceNode.prototype._createChildNode):
(WebInspector.HeapSnapshotInstanceNode.prototype.comparator):
(WebInspector.HeapSnapshotConstructorNode):
(WebInspector.HeapSnapshotConstructorNode.prototype._createChildNode):
(WebInspector.HeapSnapshotConstructorNode.prototype.comparator):
(WebInspector.HeapSnapshotDiffNode):
(WebInspector.HeapSnapshotDiffNode.prototype._createChildNode):
(WebInspector.HeapSnapshotDiffNode.prototype.comparator):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._createChildNode):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype.comparator):

  • inspector/front-end/ShowMoreDataGridNode.js:

(WebInspector.ShowMoreDataGridNode.prototype.createCells):
(WebInspector.ShowMoreDataGridNode.prototype.nodeHeight):

LayoutTests:

  • inspector/profiler/heap-snapshot-test.js: since summary and containment views are

now viewports, we should make sure all lazy clean up is done before collecting visible
rows content.
(initialize_HeapSnapshotTest):

10:07 Changeset [114648] by commit-queue@webkit.org

[EFL] [DRT] Unskip KeyEvent related tests which are passing now
https://bugs.webkit.org/show_bug.cgi?id=84345

Unreviewed, unskip passing KeyEvent tests.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-19

  • platform/efl/Skipped:
10:05 Changeset [114647] by commit-queue@webkit.org

IndexedDB: Stub out IDBCursor.advance for landing
https://bugs.webkit.org/show_bug.cgi?id=84280

Patch by Alec Flett <alecflett@chromium.org> on 2012-04-19
Reviewed by Dimitri Glazkov.

Just a stub method so it can be implemented on chromium

  • public/WebIDBCursor.h:

(WebKit::WebIDBCursor::advance):

  • src/WebIDBCursorImpl.cpp:

(WebKit::WebIDBCursorImpl::advance):
(WebKit):

  • src/WebIDBCursorImpl.h:

(WebIDBCursorImpl):

10:00 Changeset [114646] by lforschler@apple.com

Move apple-xserve-10 from Lion Test to SnowLeopard Debug Build

  • BuildSlaveSupport/build.webkit.org-config/config.json:
10:00 Changeset [114645] by haraken@chromium.org

Unreviewed, rolling out r114421.
http://trac.webkit.org/changeset/114421
https://bugs.webkit.org/show_bug.cgi?id=84103

Chromium crash

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateFunctionCallString):
(NativeToJSValue):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::TestEventConstructorV8Internal::attr1AttrGetter):
(WebCore::TestEventConstructorV8Internal::attr2AttrGetter):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalStr1AttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrGetter):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::readOnlyStringAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::hashAttrGetter):
(WebCore::TestObjV8Internal::conditionalMethod1Callback):

  • bindings/v8/V8Binding.cpp:

(WebCore::getElementStringAttr):

  • bindings/v8/V8Binding.h:

(WebCore::v8ExternalString):
(WebCore::v8String):
(WebCore::v8StringOrNull):
(WebCore::v8StringOrUndefined):
(WebCore::v8StringOrFalse):

09:59 Changeset [114644] by vsevik@chromium.org

Unreviewed, rolling out r114626.
http://trac.webkit.org/changeset/114626
https://bugs.webkit.org/show_bug.cgi?id=84349

caused new assertions in debug builds (Requested by smfr_ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-19

Source/WebCore:

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::didReceiveData):

  • inspector/NetworkResourcesData.cpp:

(WebCore::NetworkResourcesData::responseReceived):

  • inspector/NetworkResourcesData.h:

(ResourceData):
(NetworkResourcesData):

  • inspector/front-end/RequestView.js:

(WebInspector.RequestView.hasTextContent):

LayoutTests:

  • http/tests/inspector/network/network-image-404-expected.txt: Removed.
  • http/tests/inspector/network/network-image-404.html: Removed.
  • http/tests/inspector/network/resources/404.php: Removed.
09:58 UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
09:56 UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
09:53 Changeset [114643] by jschuh@chromium.org

Merge 114275

BUG=27086
TBR=raymes@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10113012

09:40 Changeset [114642] by danakj@chromium.org

Merge 114191 - [chromium] Remove viewport memory restrictions
https://bugs.webkit.org/show_bug.cgi?id=83316

Reviewed by Adrienne Walker.

We remove the memory restriction on web pages based on viewport size
on desktop. This is causing pages that have complex use of layers to
end up hitting our memory limits, and moreso when the window is small.
Page complexity is not really a function of the viewport size.

We drop the mininum memory limit entirely, and just evict all
unprotected textures instead.

Covered by existing tests.

  • platform/graphics/chromium/TextureManager.cpp:

(WebCore::TextureManager::highLimitBytes):
(WebCore::TextureManager::reclaimLimitBytes):

  • platform/graphics/chromium/TextureManager.h:

(TextureManager):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::beginCommitOnImplThread):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):
(WebCore::CCLayerTreeHost::updateLayers):

TBR=danakj@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10025037

09:40 Changeset [114641] by pilgrim@chromium.org

[Chromium] Call mimeRegistry directly
https://bugs.webkit.org/show_bug.cgi?id=84334

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

  • platform/chromium/MIMETypeRegistryChromium.cpp:

(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
(WebCore::MIMETypeRegistry::getWellKnownMIMETypeForExtension):
(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
(WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
(WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
(WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::layoutTestMode):

09:27 Changeset [114640] by commit-queue@webkit.org

Display a TextTrackCue when snap-to-lines flag is not set
https://bugs.webkit.org/show_bug.cgi?id=79750

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-04-19
Reviewed by Eric Carlson.

Source/WebCore:

Support for positioning of a cue on top of the video element when snap-to-lines is not set.

Test: media/track/track-cue-rendering-snap-to-lines-not-set.html

  • css/mediaControls.css:

(video::-webkit-media-text-track-container): Marked the container as
flexible box in order to use all the available space on top of the controls.
(video::-webkit-media-text-track-background): Added background default settings.
(video::-webkit-media-text-track-display): Added default position.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Updated comments.

  • html/track/TextTrackCue.cpp:

(WebCore):
(WebCore::TextTrackCue::TextTrackCue): Updated constructor to calculate
the computed line position.
(WebCore::TextTrackCue::setLine): Updated call to calculate the computed line
position.
(WebCore::TextTrackCue::setPosition):
(WebCore::TextTrackCue::calculateComputedLinePosition): Partial calculation of the
computated line position.
(WebCore::TextTrackCue::calculateDisplayParameters): Updated display parameter computations
required by the spec.
(WebCore::TextTrackCue::getDisplayTree): Updated positioning attributes when snap-to-lines
is not set. Added extra anonymous box for background, because setting position:absolute
on the display tree determines the background to cover the whole block, not just inline.
(WebCore::TextTrackCue::getPositionCoordinates): Determine coordinates as required by the spec.

  • html/track/TextTrackCue.h:

(TextTrackCue):

LayoutTests:

Added tests to support positioning of cues when snap-to-lines set.

  • media/media-controls.js:

(textTrackDisplayElement): Added an extra parameter, to return the display
box of the N-th active cue.

  • media/track/captions-webvtt/captions-snap-to-lines-not-set.vtt: Added.
  • media/track/track-cue-rendering-expected.txt: Updated background color check.
  • media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt: Added.
  • media/track/track-cue-rendering-snap-to-lines-not-set.html: Added.
  • media/track/track-cue-rendering.html: Updated background color check.
09:23 Changeset [114639] by fpizlo@apple.com

JSC testing should have complete coverage over typed array types
https://bugs.webkit.org/show_bug.cgi?id=84302

Rubber stamped by Gavin Barraclough.

Added float64 array test coverage.

  • fast/js/dfg-float64array-expected.txt: Added.
  • fast/js/dfg-float64array.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-float64array.js: Added.

(getter1):
(setter1):
(getter2):
(setter2):
(getter3):
(setter3):
(getter4):
(setter4):
(getters.getter1.a):
(.a):
(setters.setter1.a):
(safeGetter):
(safeSetter):

09:20 Changeset [114638] by vsevik@chromium.org

Merge 114373 - Web Inspector: [Chromium] Crash when inspecting empty IndexedDB object store.
https://bugs.webkit.org/show_bug.cgi?id=84035

Reviewed by Pavel Feldman.

Added a check that m_idbCursor is not null before calling postSuccessHandlerCallback() on it.

  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):

TBR=vsevik@chromium.org
BUG=121578
Review URL: https://chromiumcodereview.appspot.com/10125008

09:19 Changeset [114637] by pfeldman@chromium.org

Web Inspector: introduce styles panel as an experiment
https://bugs.webkit.org/show_bug.cgi?id=84331

Reviewed by Vsevolod Vlasov.

This change introduces new "Styles" panel that looks like the "Scripts" one,
but operates stylesheets. This is happening under the experimental flag.

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/Panel.js:

(WebInspector.Panel.prototype.showAnchorLocation):

  • inspector/front-end/ResourceView.js:

(WebInspector.EditableResourceSourceFrame.prototype.didEditContent):

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigatorController.prototype._navigatorOverlayWasShown):

  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype._clearLineHighlight):

  • inspector/front-end/StylesPanel.js: Added.

(WebInspector.StylesPanel):
(WebInspector.StylesPanel.prototype.wasShown):
(WebInspector.StylesPanel.prototype._initialize):
(WebInspector.StylesPanel.prototype._populateResourceTree.populateFrame):
(WebInspector.StylesPanel.prototype._populateResourceTree):
(WebInspector.StylesPanel.prototype._resourceAdded):
(WebInspector.StylesPanel.prototype._reset):
(WebInspector.StylesPanel.prototype._cachedResourcesLoaded):
(WebInspector.StylesPanel.prototype.get toolbarItemLabel):
(WebInspector.StylesPanel.prototype.viewForFile.get if):
(WebInspector.StylesPanel.prototype.viewForFile):
(WebInspector.StylesPanel.prototype._textEdited):
(WebInspector.StylesPanel.prototype._scriptSelected):
(WebInspector.StylesPanel.prototype._showFile):
(WebInspector.StylesPanel.prototype.canShowAnchorLocation):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection):
(WebInspector.StylePropertiesSection.prototype._createRuleOriginNode):

  • inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector._createPanels):
(WebInspector._showAnchorLocationInPanel):

  • inspector/front-end/scriptsPanel.css:
  • inspector/front-end/splitView.css:

(.sidebar-overlay):

09:16 Changeset [114636] by vsevik@chromium.org

Follow up to r114632: build fix.

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):

09:10 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
08:57 Changeset [114635] by pilgrim@chromium.org

[Chromium] Call sampleGamepads directly
https://bugs.webkit.org/show_bug.cgi?id=84339

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

  • platform/chromium/GamepadsChromium.cpp:

(WebCore::sampleGamepads):

  • platform/chromium/PlatformSupport.h:

(WebCore):
(PlatformSupport):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::injectIDBKeyIntoSerializedValue):

08:51 Changeset [114634] by pilgrim@chromium.org

[Chromium] Call audioHardwareSampleRate directly
https://bugs.webkit.org/show_bug.cgi?id=84335

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

  • src/AudioDestinationChromium.cpp:

(WebCore::AudioDestination::hardwareSampleRate):

08:48 UpdatingBugzilla edited by ddkilzer@apple.com
Added (diff)
08:37 Changeset [114633] by commit-queue@webkit.org

[EFL] dispatchDidCancelClientRedirect needs implementation
https://bugs.webkit.org/show_bug.cgi?id=83669

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-04-19
Reviewed by Antonio Gomes.

Source/WebKit/efl:

Emit a new "redirect,cancelled" signal on the ewk_frame when a
redirect is cancelled. This is needed by EFL's DumpRenderTree to dump
frame load callbacks information.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchDidCancelClientRedirect):

  • ewk/ewk_frame.cpp:

(ewk_frame_redirect_cancelled):

  • ewk/ewk_frame.h:
  • ewk/ewk_private.h:

Tools:

Catch the new ewk_frame "redirect,cancelled" signal in EFL's DRT and
and print out information that is expected by several test cases if
LayoutTestController's dumpFrameLoadCallback() returns true.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onFrameCreated):
(DumpRenderTreeChrome::onFrameRedirectCancelled):

  • DumpRenderTree/efl/DumpRenderTreeChrome.h:

(DumpRenderTreeChrome):

08:34 Changeset [114632] by vsevik@chromium.org

Web Inspector: x-frame security errors logged when typing in the console are annoying.
https://bugs.webkit.org/show_bug.cgi?id=81970

Reviewed by Pavel Feldman.

Parameter DoNotPauseOnExceptions in Runtime.evaluate() renamed to DoNotPauseOnExceptionsAndMuteConsole.
Added this parameter to Runtime.callFunctionOn() and passed true in all call sites.
Added this parameter to Debugger.evaluateOnCallFrame().
Added a flag to console that mutes all messages unless they have ConsoleAPI message source.
This flag is now temporarily set from InspectorRuntimeAgent and InspectorDebuggerAgent for certain injected source calls.

  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::asBool):
(WebCore):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

  • inspector/InspectorRuntimeAgent.cpp:

(WebCore):
(WebCore::setPauseOnExceptionsState):
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):
(WebCore::InspectorRuntimeAgent::getProperties):

  • inspector/InspectorRuntimeAgent.h:

(InspectorRuntimeAgent):

  • inspector/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::muteConsole):
(WebCore):
(WebCore::PageDebuggerAgent::unmuteConsole):

  • inspector/PageDebuggerAgent.h:

(PageDebuggerAgent):

  • inspector/PageRuntimeAgent.cpp:

(WebCore::PageRuntimeAgent::muteConsole):
(WebCore):
(WebCore::PageRuntimeAgent::unmuteConsole):

  • inspector/PageRuntimeAgent.h:

(PageRuntimeAgent):

  • inspector/WorkerDebuggerAgent.cpp:

(WebCore::WorkerDebuggerAgent::muteConsole):
(WebCore):
(WebCore::WorkerDebuggerAgent::unmuteConsole):

  • inspector/WorkerDebuggerAgent.h:

(WorkerDebuggerAgent):

  • inspector/WorkerRuntimeAgent.cpp:

(WebCore::WorkerRuntimeAgent::muteConsole):
(WebCore):
(WebCore::WorkerRuntimeAgent::unmuteConsole):

  • inspector/WorkerRuntimeAgent.h:

(WorkerRuntimeAgent):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype.evalInInspectedWindow):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
(WebInspector.PresentationCallFrame.prototype.evaluate):

  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject.prototype.setPropertyValue):
(WebInspector.RemoteObject.prototype.callFunction):
(WebInspector.RemoteObject.prototype.callFunctionJSON):

  • inspector/front-end/WorkerManager.js:
  • page/Console.cpp:

(WebCore::Console::addMessage):
(WebCore::Console::warn):
(WebCore):
(WebCore::Console::mute):
(WebCore::Console::unmute):

  • page/Console.h:

(Console):

08:26 Changeset [114631] by commit-queue@webkit.org

[Qt][WK2] Zoom out on the second double click does not always scale right.
https://bugs.webkit.org/show_bug.cgi?id=84332

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-19
Reviewed by Simon Hausmann.

Zoom out to the minimum scale value instead of the fixed 1.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):

08:21 April 2012 Meeting edited by dominicc@chromium.org
(diff)
07:46 Changeset [114630] by commit-queue@webkit.org

Unreviewed, rolling out r114628.
http://trac.webkit.org/changeset/114628
https://bugs.webkit.org/show_bug.cgi?id=84341

Breaks EFL and GTK builds (Requested by pfeldman on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-19

  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):
(WebCore::InspectorRuntimeAgent::getProperties):

  • inspector/InspectorRuntimeAgent.h:

(InspectorRuntimeAgent):

  • inspector/PageDebuggerAgent.cpp:
  • inspector/PageDebuggerAgent.h:

(PageDebuggerAgent):

  • inspector/PageRuntimeAgent.cpp:
  • inspector/PageRuntimeAgent.h:

(PageRuntimeAgent):

  • inspector/WorkerDebuggerAgent.cpp:
  • inspector/WorkerDebuggerAgent.h:

(WorkerDebuggerAgent):

  • inspector/WorkerRuntimeAgent.cpp:
  • inspector/WorkerRuntimeAgent.h:

(WorkerRuntimeAgent):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype.evalInInspectedWindow):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
(WebInspector.PresentationCallFrame.prototype.evaluate):

  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject.prototype.setPropertyValue):
(WebInspector.RemoteObject.prototype.callFunction):
(WebInspector.RemoteObject.prototype.callFunctionJSON):

  • inspector/front-end/WorkerManager.js:
  • page/Console.cpp:

(WebCore):
(WebCore::Console::addMessage):
(WebCore::Console::warn):

  • page/Console.h:

(Console):

06:42 Changeset [114629] by schenney@chromium.org

Add expectation for flaky svg/custom/foreign-object-skew.svg

Unreviewed Chromium expectations fix.

  • platform/chromium/test_expectations.txt:
06:28 Changeset [114628] by vsevik@chromium.org

Web Inspector: x-frame security errors logged when typing in the console are annoying.
https://bugs.webkit.org/show_bug.cgi?id=81970

Reviewed by Pavel Feldman.

Parameter DoNotPauseOnExceptions in Runtime.evaluate() renamed to DoNotPauseOnExceptionsAndMuteConsole.
Added this parameter to Runtime.callFunctionOn() and passed true in all call sites.
Added this parameter to Debugger.evaluateOnCallFrame().
Added a flag to console that mutes all messages unless they have ConsoleAPI message source.
This flag is now temporarily set from InspectorRuntimeAgent and InspectorDebuggerAgent for certain injected source calls.

  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::asBool):
(WebCore):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

  • inspector/InspectorRuntimeAgent.cpp:

(WebCore):
(WebCore::setPauseOnExceptionsState):
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):
(WebCore::InspectorRuntimeAgent::getProperties):

  • inspector/InspectorRuntimeAgent.h:

(InspectorRuntimeAgent):

  • inspector/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::muteConsole):
(WebCore):
(WebCore::PageDebuggerAgent::unmuteConsole):

  • inspector/PageDebuggerAgent.h:

(PageDebuggerAgent):

  • inspector/PageRuntimeAgent.cpp:

(WebCore::PageRuntimeAgent::muteConsole):
(WebCore):
(WebCore::PageRuntimeAgent::unmuteConsole):

  • inspector/PageRuntimeAgent.h:

(PageRuntimeAgent):

  • inspector/WorkerDebuggerAgent.cpp:

(WebCore::WorkerDebuggerAgent::muteConsole):
(WebCore):
(WebCore::WorkerDebuggerAgent::unmuteConsole):

  • inspector/WorkerDebuggerAgent.h:

(WorkerDebuggerAgent):

  • inspector/WorkerRuntimeAgent.cpp:

(WebCore::WorkerRuntimeAgent::muteConsole):
(WebCore):
(WebCore::WorkerRuntimeAgent::unmuteConsole):

  • inspector/WorkerRuntimeAgent.h:

(WorkerRuntimeAgent):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype.evalInInspectedWindow):

  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
(WebInspector.PresentationCallFrame.prototype.evaluate):

  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject.prototype.setPropertyValue):
(WebInspector.RemoteObject.prototype.callFunction):
(WebInspector.RemoteObject.prototype.callFunctionJSON):

  • inspector/front-end/WorkerManager.js:
  • page/Console.cpp:

(WebCore::Console::addMessage):
(WebCore::Console::warn):
(WebCore):
(WebCore::Console::mute):
(WebCore::Console::unmute):

  • page/Console.h:

(Console):

06:11 Changeset [114627] by noam.rosenthal@nokia.com

[Qt] Fix Qt-Mac build after libxml patch
https://bugs.webkit.org/show_bug.cgi?id=84313

Use direct include/library paths instead of PKGCONFIG when on Mac.

Reviewed by Simon Hausmann.

No new tests, build fix.

  • WebCore.pri:
05:08 Changeset [114626] by vsevik@chromium.org

Web Inspector: No response body available for cached resource requests with error status codes.
https://bugs.webkit.org/show_bug.cgi?id=84265

Source/WebCore:

Reviewed by Pavel Feldman.

InspectorResourceAgent now saves failed subresource request response body in its cache.
Saved data is shown on front-end.

Test: http/tests/inspector/network/network-image-404.html

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::didReceiveData):

  • inspector/NetworkResourcesData.cpp:

(WebCore::NetworkResourcesData::responseReceived):
(WebCore::NetworkResourcesData::httpStatusCode):
(WebCore):

  • inspector/NetworkResourcesData.h:

(WebCore::NetworkResourcesData::ResourceData::httpStatusCode):
(WebCore::NetworkResourcesData::ResourceData::setHTTPStatusCode):
(ResourceData):
(NetworkResourcesData):

  • inspector/front-end/RequestView.js:

(WebInspector.RequestView.hasTextContent):

LayoutTests:

  • http/tests/inspector/network/network-image-404-expected.txt: Added.
  • http/tests/inspector/network/network-image-404.html: Added.
  • http/tests/inspector/network/resources/404.php: Added.
04:55 Changeset [114625] by kkristof@inf.u-szeged.hu

[Qt] Gardening. Skip failing reftest after 114574.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-04-19
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
04:46 SelectiveTestBuildBot edited by beszedes@inf.u-szeged.hu
(diff)
04:45 selectivetest.jpg attached to SelectiveTestBuildBot by beszedes@inf.u-szeged.hu
04:44 Changeset [114624] by commit-queue@webkit.org

[BlackBerry] Always use the AnimationFrameRateController for accelerated animations
https://bugs.webkit.org/show_bug.cgi?id=84323

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-04-19
Reviewed by Antonio Gomes.

PR 150750
Regardless of whether there's a WebPageCompositorClient, we want the
AnimationFrameRateController to manage animation frames.
Reviewed internally by Andrew Lo.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::blitContents):

  • Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):

  • Api/WebPageCompositor_p.h:

(WebPageCompositorPrivate):

04:43 selectivetest.png attached to SelectiveTestBuildBot by beszedes@inf.u-szeged.hu
04:39 SelectiveTestBuildBot edited by beszedes@inf.u-szeged.hu
(diff)
04:39 Changeset [114623] by pfeldman@chromium.org

Web Inspector: reuse ParsedUrl in the UISourceCode
https://bugs.webkit.org/show_bug.cgi?id=84326

Reviewed by Yury Semikhatsky.

Source/WebCore:

Migrated UISourceCode to ParsedURL, moved the displayName logic into its only client:
TabbedEditorContainer.

  • inspector/front-end/CompilerScriptMapping.js:

(WebInspector.SourceMapParser.prototype._canonicalizeURL):

  • inspector/front-end/FilteredItemSelectionDialog.js:

(WebInspector.OpenResourceDialog.filterOutEmptyURLs):
(WebInspector.OpenResourceDialog.compareFunction):
(WebInspector.OpenResourceDialog):
(WebInspector.OpenResourceDialog.prototype.itemTitleAt):
(WebInspector.OpenResourceDialog.prototype.itemKeyAt):

  • inspector/front-end/ResourceUtils.js:

(WebInspector.ParsedURL):

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator.prototype._getOrCreateFolderTreeElement):
(WebInspector.NavigatorFolderTreeElement):

  • inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer.prototype._titleForFile):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.get parsedURL):

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • inspector/debugger/ui-source-code-display-name.html:
04:36 SelectiveTestBuildBot edited by beszedes@inf.u-szeged.hu
(diff)
03:18 SelectiveTestBuildBot edited by ossy@webkit.org
fixes (diff)
02:57 SelectiveTestBuildBot edited by schrettner@inf.u-szeged.hu
(diff)
02:08 Changeset [114622] by commit-queue@webkit.org

[CMake] Build fix after r114575
https://bugs.webkit.org/show_bug.cgi?id=84322

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-19
Reviewed by Simon Hausmann.

Build fix, adding WTF when linking jsc shell.

  • shell/CMakeLists.txt:
00:20 Changeset [114621] by commit-queue@webkit.org

Optimize for DARWIN in DirectConvolver::process()
https://bugs.webkit.org/show_bug.cgi?id=80256

Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-04-19
Reviewed by Chris Rogers.

  • platform/audio/DirectConvolver.cpp:

(WebCore::DirectConvolver::process):

00:09 Changeset [114620] by mrobinson@webkit.org

Finish merge of r111601

00:07 Changeset [114619] by toyoshim@chromium.org

Unreviewed, add expected.txt for cookies-wrong-domain-rejected-result.php .

  • http/tests/security/cookies/cookies-wrong-domain-rejected-result-expected.txt: Added.
00:05 Changeset [114618] by mrobinson@webkit.org

Fix failed merge

04/18/12:

23:59 Changeset [114617] by mrobinson@webkit.org

Fix failed merge

23:56 Changeset [114616] by noel.gordon@gmail.com

[CG] ImageBuffer::toDataURL: Remove alpha stuffing loop when encoding to JPEG
https://bugs.webkit.org/show_bug.cgi?id=84319

Reviewed by Eric Seidel.

No change in behavior. Covered by existing canvas 2d and 3d tests:

canvas/philip/tests/toDataURL.jpeg.alpha.html
fast/canvas/webgl/premultiplyalpha-test.html

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::toDataURL): Remove the alpha stuffing loop and instead,
make JPEG encoder ignore the alpha channel (kCGImageAlphaNoneSkipLast).

23:54 Changeset [114615] by mrobinson@webkit.org

Merging r110374

23:42 Changeset [114614] by mrobinson@webkit.org

Merging r111601

23:38 Changeset [114613] by mrobinson@webkit.org

Merging r111899

23:35 Changeset [114612] by toyoshim@chromium.org

Unrevieded, rebaseline svg/as-image/img-preserveAspectRatio-support-1.html

  • platform/chromium-mac-leopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
23:35 Changeset [114611] by mrobinson@webkit.org

Merging r110323

23:33 Changeset [114610] by mrobinson@webkit.org

Fix a failed merge.

23:24 April 2012 Meeting edited by dbates@webkit.org
(diff)
22:40 Changeset [114609] by eae@chromium.org

Remove unnecessary rounding/conversions in RenderBoxModelObject
https://bugs.webkit.org/show_bug.cgi?id=84288

Reviewed by Eric Seidel.

No new tests, no change in functionality.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBoxShadow):
Remove unnecessary pixelSnapping logic and casts in paintBoxShadow as
shadow rects are now int based.

22:21 Changeset [114608] by commit-queue@webkit.org

[BlackBerry] Parsed Cookie's m_hasDefaultDomain is not needed.
https://bugs.webkit.org/show_bug.cgi?id=82830

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-18
Reviewed by George Staikos.

Source/WebCore:

RFC 2965
3.2.2
Domain = value
If an explicitly specified value does not start with a dot, the user agent supplies
a leading dot.
3.3.1
Domain Defaults to the effective request-host. (Note that because there is no dot
at the beginning of effective request-host, the default Domain can only domain-match
itself.)

The first char can show the difference even though it is from the cookie database.
But m_hasDefaultDomain is set to false if the cookie is from database although the
domain is host as a default value. So m_hasDefaultDomain sometimes is wrong.

In sum, we shouldn't use m_hasDefaultDomain.

Test: http/tests/security/cookies/cookies-wrong-domain-rejected.php

  • platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::shouldRejectForSecurityReason):

  • platform/blackberry/CookieParser.cpp:

(WebCore::CookieParser::parseOneCookie):

  • platform/blackberry/ParsedCookie.cpp:

(WebCore::ParsedCookie::ParsedCookie):

  • platform/blackberry/ParsedCookie.h:

(ParsedCookie):

LayoutTests:

  • http/tests/security/cookies/cookies-wrong-domain-rejected-expected.txt: Added.
  • http/tests/security/cookies/cookies-wrong-domain-rejected-result.php: Added.
  • http/tests/security/cookies/cookies-wrong-domain-rejected.php: Added.
21:51 Changeset [114607] by enne@google.com

[chromium] Consolidate adjustTextRenderMode copypasta into Skia context
https://bugs.webkit.org/show_bug.cgi?id=83840

Reviewed by James Robinson.

The same logic to decide when to make text use LCD rendering is copy
and pasted in all the different font classes. It seems like this
should live in a single place.

  • platform/graphics/harfbuzz/FontHarfBuzz.cpp:

(WebCore::Font::drawGlyphs):
(WebCore::Font::drawComplexText):

  • platform/graphics/skia/FontSkia.cpp:

(WebCore::Font::drawGlyphs):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::adjustTextRenderMode):
(WebCore):
(WebCore::PlatformContextSkia::couldUseLCDRenderedText):

  • platform/graphics/skia/PlatformContextSkia.h:

(PlatformContextSkia):

  • platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::setupPaintForFont):

21:45 Changeset [114606] by thakis@chromium.org

[chromium/mac] Fix build.
https://bugs.webkit.org/show_bug.cgi?id=84314

Unreviewed, build fix after http://trac.webkit.org/changeset/114604

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):

21:33 April 2012 Meeting edited by luxtella@company100.net
(diff)
21:07 April 2012 Meeting edited by thakis@chromium.org
(diff)
21:02 April 2012 Meeting edited by dglazkov@chromium.org
(diff)
20:51 Changeset [114605] by hbono@chromium.org

Split SpellChecker::didCheck() to SpellChecker::didCheckSucceeded() and SpellChecker::didCheckCanceled()
https://bugs.webkit.org/show_bug.cgi?id=83748

Reviewed by Ryosuke Niwa.

Source/WebCore:

The current SpellChecker::didCheck() does not delete existing markers. It causes
a problem that it leaves misspelled markers when a spellchecker client finishes
checking text successfully. This change splits this function to didCheckSucceeded()
and didCheckCanceled() so the SpellChecker class can delete existing markers
when its client finishes checking text successfully. (We do not have to erase
existing markers when the client needs to cancel a text-check request.)

Test: platform/chromium/editing/spelling/delete-misspelled-word.html

  • WebCore.exp.in: Replaced SpellChecker::didCheck with SpellChecker::didCheckSucceeded.
  • editing/SpellChecker.cpp:

(WebCore::SpellChecker::didCheckSucceeded): Added.
(WebCore):
(WebCore::SpellChecker::didCheckCanceled): Added.

  • editing/SpellChecker.h:

(SpellChecker): Added didCheckSucceeded and didCheckCanceled. Also changed didCheck to a private function.

Source/WebKit/chromium:

This change adds a new API WebTextCheckingCompletion::didCancelCheckingText(),
which encapsulates SpellChecker::didCheckCanceled() and implements it so
Chromium can use it.

  • public/WebTextCheckingCompletion.h:

(WebKit::WebTextCheckingCompletion::didCancelCheckingText):

  • src/WebTextCheckingCompletionImpl.cpp:

(WebKit::WebTextCheckingCompletionImpl::didFinishCheckingText):
(WebKit):
(WebKit::WebTextCheckingCompletionImpl::didCancelCheckingText):

  • src/WebTextCheckingCompletionImpl.h:

(WebTextCheckingCompletionImpl):

Source/WebKit/mac:

This change replaces a call for SpellChecker::didCheck() with one for
SpellChecker::didCheckSucceeded() because didCheck has been split into
didCheckSucceeded(0 and didCheckCanceled().

  • WebCoreSupport/WebEditorClient.mm:

(-[WebEditorSpellCheckResponder perform]): Replaced didCheck with didCheckSucceeded.

Tools:

This change replaces a call for SpellChecker::didCheck() with one for
SpellChecker::didCheckCenceled() because didCheck() has been split into
didCheckSucceeded() and didCheckCanceled().

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::requestCheckingOfText): Replaced didCheck with didCheckCanceled.

LayoutTests:

The current SpellChecker::didCheck() does not delete existing markers. It causes
a problem that it leaves misspelled markers when a spellchecker client finishes
checking text successfully. This change splits this function to didCheckSucceeded()
and didCheckCanceled() so the SpellChecker class can delete existing markers
when its client finishes checking text successfully. (We do not have to erase
existing markers when the client needs to cancel a text-check request.)

  • platform/chromium/editing/spelling/delete-misspelled-word-expected.txt: Added.
  • platform/chromium/editing/spelling/delete-misspelled-word.html: Added.
20:29 April 2012 Meeting edited by thakis@chromium.org
(diff)
20:29 April 2012 Meeting edited by thakis@chromium.org
(diff)
20:26 April 2012 Meeting edited by thakis@chromium.org
(diff)
19:48 Changeset [114604] by jamesr@google.com

[chromium] Convert WebPluginContainerImpl over to use WebExternalTextureLayer
https://bugs.webkit.org/show_bug.cgi?id=84120

Reviewed by Adrienne Walker.

Source/Platform:

This adds support for IO surface backed WebExternalTextureLayer, used by CoreAnimation plugins on OS X and moves
some functionality used by multiple WebLayer subclasses up to the base class.

  • chromium/public/WebContentLayer.h:

(WebContentLayer):

  • chromium/public/WebExternalTextureLayer.h:

(WebCore):
(WebExternalTextureLayer):

  • chromium/public/WebLayer.h:

(WebKit):
(WebLayer):
(WebKit::WebLayer::unwrap):

Source/WebCore:

This renames PluginLayerChromium -> TextureLayerChromium since it is now used only as the implementation of
WebExternalTextureLayer and cleans it up slightly.

  • WebCore.gypi:
  • platform/graphics/chromium/TextureLayerChromium.cpp: Renamed from Source/WebCore/platform/graphics/chromium/PluginLayerChromium.cpp.

(WebCore):
(WebCore::TextureLayerChromium::create):
(WebCore::TextureLayerChromium::TextureLayerChromium):
(WebCore::TextureLayerChromium::createCCLayerImpl):
(WebCore::TextureLayerChromium::drawsContent):
(WebCore::TextureLayerChromium::setTextureId):
(WebCore::TextureLayerChromium::setFlipped):
(WebCore::TextureLayerChromium::setUVRect):
(WebCore::TextureLayerChromium::setIOSurfaceProperties):
(WebCore::TextureLayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/TextureLayerChromium.h: Renamed from Source/WebCore/platform/graphics/chromium/PluginLayerChromium.h.

(WebCore):
(TextureLayerChromium):
(WebCore::TextureLayerChromium::flipped):
(WebCore::TextureLayerChromium::uvRect):

Source/WebKit/chromium:

This ports WebPluginContainerImpl over to use WebExternalTextureLayer instead of directly using a *LayerChromium
type for better layering and code sharing. The changes to WebPluginContainerImpl are fairly straightforward. In
addition to renames I also moved some state tracking into WPCI instead of having it exposed on the interface. I
also removed the WebExternalTextureLayerImpl intermediate class since it wasn't doing anything useful.

  • WebKit.gyp:
  • WebKit.gypi:
  • src/WebContentLayer.cpp:
  • src/WebExternalTextureLayer.cpp:

(WebKit::WebExternalTextureLayer::create):
(WebKit::WebExternalTextureLayer::setTextureId):
(WebKit::WebExternalTextureLayer::setIOSurfaceProperties):
(WebKit::WebExternalTextureLayer::setFlipped):
(WebKit::WebExternalTextureLayer::flipped):
(WebKit::WebExternalTextureLayer::setUVRect):
(WebKit::WebExternalTextureLayer::uvRect):
(WebKit::WebExternalTextureLayer::WebExternalTextureLayer):

  • src/WebExternalTextureLayerImpl.cpp: Removed.
  • src/WebExternalTextureLayerImpl.h: Removed.
  • src/WebLayer.cpp:

(WebKit::WebLayer::invalidateRect):
(WebKit):
(WebKit::WebLayer::invalidate):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::setBackingTextureId):
(WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
(WebKit::WebPluginContainerImpl::commitBackingTexture):
(WebKit::WebPluginContainerImpl::setOpaque):
(WebKit::WebPluginContainerImpl::platformLayer):
(WebKit::WebPluginContainerImpl::WebPluginContainerImpl):

  • src/WebPluginContainerImpl.h:

(WebCore):
(WebPluginContainerImpl):

  • tests/WebExternalTextureLayerImplTest.cpp: Removed.
  • tests/WebLayerTest.cpp:
19:44 April 2012 Meeting edited by rniwa@webkit.org
(diff)
19:32 Changeset [114603] by commit-queue@webkit.org

Expose attack, release as DynamicsCompressorNode's attributes.
https://bugs.webkit.org/show_bug.cgi?id=81221

Patch by Raymond Toy <rtoy@google.com> on 2012-04-18
Reviewed by Chris Rogers.

Source/WebCore:

  • Modules/webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
(WebCore::DynamicsCompressorNode::process):

  • Modules/webaudio/DynamicsCompressorNode.h:

(WebCore::DynamicsCompressorNode::attack):
(WebCore::DynamicsCompressorNode::releaseTime):
(DynamicsCompressorNode):

  • Modules/webaudio/DynamicsCompressorNode.idl: Add attack and

release attributes.

  • bindings/scripts/CodeGeneratorObjC.pm:

(SkipAttribute): Skip release()
(GenerateHeader): Call SkipAttribute for getters/setters.

  • platform/audio/DynamicsCompressor.h:

(DynamicsCompressor):

LayoutTests:

  • webaudio/dynamicscompressor-basic-expected.txt:
  • webaudio/dynamicscompressor-basic.html:
19:02 Changeset [114602] by dpranke@chromium.org

Fix failure in test-webkitpy after r114583.

Unreviewed, build fix.

Updating the call site in r114583 w/o updating the test caused
the test to fail. Somehow I forgot to run the unit tests :(.

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumDriverTest.test_crash_log):

19:01 Changeset [114601] by danakj@chromium.org

[chromium] Simplify occlusion tracker API by passing layer iterator data
https://bugs.webkit.org/show_bug.cgi?id=84088

Reviewed by Adrienne Walker.

Source/WebCore:

Previously three methods lived in the API and you needed to call the
appropriate method (with different amounts of data) depending on what
the current layer iterator was representing.

This makes usage of the occlusion tracker simpler to read and harder
to mess up, by just passing in the layer iterator at each step of the
iteration process.

Covered by existing tests.

  • platform/graphics/chromium/cc/CCLayerIterator.h:

(WebCore):
(CCLayerIteratorPosition):
(CCLayerIterator):
(WebCore::CCLayerIterator::operator const CCLayerIteratorPosition<LayerType>):

  • platform/graphics/chromium/cc/CCLayerTilingData.cpp:

(WebCore::CCLayerTilingData::opaqueRegionInLayerRect):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintLayerContents):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::enterLayer):
(WebCore):
(WebCore::::leaveLayer):

  • platform/graphics/chromium/cc/CCOcclusionTracker.h:

(CCOcclusionTrackerBase):

Source/WebKit/chromium:

  • tests/CCOcclusionTrackerTest.cpp:

(CCOcclusionTrackerTestMainThreadTypes):
(CCOcclusionTrackerTestImplThreadTypes):
(WebKitTests::CCOcclusionTrackerTest::CCOcclusionTrackerTest):
(WebKitTests::CCOcclusionTrackerTest::calcDrawEtc):
(CCOcclusionTrackerTest):
(WebKitTests::CCOcclusionTrackerTest::enterLayer):
(WebKitTests::CCOcclusionTrackerTest::leaveLayer):
(WebKitTests::CCOcclusionTrackerTest::visitLayer):
(WebKitTests::CCOcclusionTrackerTest::enterContributingSurface):
(WebKitTests::CCOcclusionTrackerTest::leaveContributingSurface):
(WebKitTests::CCOcclusionTrackerTest::visitContributingSurface):
(WebKitTests::CCOcclusionTrackerTest::resetLayerIterator):
(WebKitTests::CCOcclusionTrackerTestIdentityTransforms::runMyTest):
(WebKitTests::CCOcclusionTrackerTestRotatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestTranslatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestChildInRotatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
(WebKitTests::CCOcclusionTrackerTestFilters::runMyTest):
(WebKitTests::CCOcclusionTrackerTestReplicaDoesOcclude::runMyTest):
(WebKitTests::CCOcclusionTrackerTestReplicaWithClipping::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerScissorRectOutsideChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestScreenScissorRectOutsideChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerScissorRectOverChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestScreenScissorRectOverChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerScissorRectPartlyOverChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestScreenScissorRectPartlyOverChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerScissorRectOverNothing::runMyTest):
(WebKitTests::CCOcclusionTrackerTestScreenScissorRectOverNothing::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerScissorRectForLayerOffOrigin::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOpaqueContentsRegionEmpty::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty::runMyTest):
(WebKitTests::CCOcclusionTrackerTest3dTransform::runMyTest):
(WebKitTests::CCOcclusionTrackerTestPerspectiveTransform::runMyTest):
(WebKitTests::CCOcclusionTrackerTestPerspectiveTransformBehindCamera::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerBehindCameraDoesNotOcclude::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationTranslateOnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesToParent::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesWithClipping::runMyTest):
(WebKitTests::CCOcclusionTrackerTestReplicaOccluded::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceWithReplicaUnoccluded::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceAndReplicaOccludedDifferently::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceChildOfSurface::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceChildOfClippingSurface::runMyTest):

  • tests/CCQuadCullerTest.cpp:

(WebCore):
(WebCore::makeLayer):
(WebCore::appendQuads):
(WebCore::TEST):

18:47 Changeset [114600] by philn@webkit.org

Unreviewed, GTK test_expectations update.

  • platform/gtk/test_expectations.txt: Mark new fast/table test as failing.
18:30 Changeset [114599] by jamesr@google.com

[chromium] Add canBeginFrame state to CCSchedulerStateMachine to suppress initialization before our surface is available
https://bugs.webkit.org/show_bug.cgi?id=84301

Reviewed by Adrienne Walker.

Source/WebCore:

If our composited surface isn't ready yet, then the compositor may initialize in a state where the first
makeContextCurrent() fails. This adds a new state to the scheduler that we can use to suppress initialization
until we get notified that the surface is ready. I'll add the plumbing for actually notifying in a follow-up.

Updated CCSchedulerTest / CCSchedulerStateMachineTest unit tests.

  • platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::setCanBeginFrame):
(WebCore):

  • platform/graphics/chromium/cc/CCScheduler.h:

(CCScheduler):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::nextAction):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.h:

(WebCore::CCSchedulerStateMachine::setCanBeginFrame):
(CCSchedulerStateMachine):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::initializeImplOnImplThread):

Source/WebKit/chromium:

Update unit tests for new canBeginFrame bit.

  • tests/CCSchedulerStateMachineTest.cpp:

(WebCore::TEST):
(WebCore):

  • tests/CCSchedulerTest.cpp:

(WebKitTests::TEST):

18:22 Changeset [114598] by mrobinson@webkit.org

Merging r112935

18:22 Changeset [114597] by mrobinson@webkit.org

Merging r112596

18:20 Changeset [114596] by mrobinson@webkit.org

Merging r112596

18:20 Changeset [114595] by mrobinson@webkit.org

Merging r112200

18:10 Changeset [114594] by fpizlo@apple.com

JSC testing should have complete coverage over typed array types
https://bugs.webkit.org/show_bug.cgi?id=84302

Rubber stamped by Geoff Garen.

Changed calls to shouldBe("...", "...") to be more informative, per Geoff's
suggestion.

  • fast/js/dfg-float32array-expected.txt:
  • fast/js/dfg-int16array-expected.txt:
  • fast/js/dfg-int32array-expected.txt:
  • fast/js/dfg-int32array-overflow-values-expected.txt:
  • fast/js/dfg-int8array-expected.txt:
  • fast/js/dfg-uint16array-expected.txt:
  • fast/js/dfg-uint32array-expected.txt:
  • fast/js/dfg-uint32array-overflow-values-expected.txt:
  • fast/js/dfg-uint8array-expected.txt:
  • fast/js/dfg-uint8clampedarray-expected.txt:
  • fast/js/script-tests/dfg-float32array.js:
  • fast/js/script-tests/dfg-int16array.js:
  • fast/js/script-tests/dfg-int32array-overflow-values.js:
  • fast/js/script-tests/dfg-int32array.js:
  • fast/js/script-tests/dfg-int8array.js:
  • fast/js/script-tests/dfg-uint16array.js:
  • fast/js/script-tests/dfg-uint32array-overflow-values.js:
  • fast/js/script-tests/dfg-uint32array.js:
  • fast/js/script-tests/dfg-uint8array.js:
  • fast/js/script-tests/dfg-uint8clampedarray.js:
18:05 Changeset [114593] by mrobinson@webkit.org

Merging r112184

18:03 Changeset [114592] by mrobinson@webkit.org

Merging r112119

18:02 Changeset [114591] by mrobinson@webkit.org

Merging r112012

17:55 Changeset [114590] by mrobinson@webkit.org

Merging r111912

17:52 Changeset [114589] by mrobinson@webkit.org

Merging r111895

17:32 Changeset [114588] by mrobinson@webkit.org

Merging r110139

17:15 Changeset [114587] by fpizlo@apple.com

JSC testing should have complete coverage over typed array types
https://bugs.webkit.org/show_bug.cgi?id=84302

Source/JavaScriptCore:

Reviewed by Geoff Garen.

Added Uint8ClampedArray to the set of typed arrays that are supported by jsc
command-line.

  • JSCTypedArrayStubs.h:

(JSC):

  • jsc.cpp:

(GlobalObject::finishCreation):

Tools:

Reviewed by Geoff Garen.

Made run-fast-jsc print something and a newline if jsc threw an exception or
otherwise returned with an error code, but did not crash.

  • Scripts/run-fast-jsc:

LayoutTests:

Reviewed by Geoff Garen.

Added tests for uint8 and uint16 arrays. Added a test for uint32 arrays that
does not focus entirely on overflow values.

Also added the typed array tests to the repertoire that can be run by
run-fast-jsc.

  • fast/js/dfg-int16array-expected.txt:
  • fast/js/dfg-int8array-expected.txt:
  • fast/js/dfg-uint16array-expected.txt: Added.
  • fast/js/dfg-uint16array.html: Added.
  • fast/js/dfg-uint32array-expected.txt: Added.
  • fast/js/dfg-uint32array.html: Added.
  • fast/js/dfg-uint8array-expected.txt: Added.
  • fast/js/dfg-uint8array.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-int16array.js:
  • fast/js/script-tests/dfg-int8array.js:
  • fast/js/script-tests/dfg-uint16array.js: Added.

(getter1):
(setter1):
(getter2):
(setter2):
(getter3):
(setter3):
(getter4):
(setter4):
(getters.getter1.a):
(.a):
(setters.setter1.a):
(safeGetter):
(safeSetter):

  • fast/js/script-tests/dfg-uint32array.js: Added.

(getter1):
(setter1):
(getter2):
(setter2):
(getter3):
(setter3):
(getter4):
(setter4):
(getters.getter1.a):
(.a):
(setters.setter1.a):
(safeGetter):
(safeSetter):

  • fast/js/script-tests/dfg-uint8array.js: Added.

(getter1):
(setter1):
(getter2):
(setter2):
(getter3):
(setter3):
(getter4):
(setter4):
(getters.getter1.a):
(.a):
(setters.setter1.a):
(safeGetter):
(safeSetter):

17:11 Changeset [114586] by philn@webkit.org

[GTK] r114021 triggered media flakyness
https://bugs.webkit.org/show_bug.cgi?id=83874

Reviewed by Eric Carlson.

Fix-up use of setMediaPlaybackRequiresUserGesture() in two media
tests.

  • media/video-load-require-user-gesture.html:
  • media/video-play-require-user-gesture.html:
  • platform/gtk/test_expectations.txt:
17:05 Changeset [114585] by philn@webkit.org

Unreviewed, GTK test_expectations update.

  • platform/gtk/test_expectations.txt: Unflag some tests now passing.
17:04 Changeset [114584] by commit-queue@webkit.org

Somehow, there's an errant backslash in my last WTF patch
https://bugs.webkit.org/show_bug.cgi?id=84290

Patch by Myles Maxfield <mmaxfield@google.com> on 2012-04-18
Reviewed by Andreas Kling.

  • wtf/StdLibExtras.h:

(WTF::roundUpToMultipleOf):

16:56 Changeset [114583] by dpranke@chromium.org

Fix crash in chromium.py after r114877.

Unreviewed, build fix.

Missed updating one call site for get_crash_log() :(.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumDriver.run_test):

16:38 Changeset [114582] by mrobinson@webkit.org

Merging r111775

16:34 Changeset [114581] by mrobinson@webkit.org

Merging r111714

16:32 Changeset [114580] by commit-queue@webkit.org

[Chromium] Solid color layers should respect opacity value.
https://bugs.webkit.org/show_bug.cgi?id=84197

Patch by David Reveman <reveman@chromium.org> on 2012-04-18
Reviewed by Adrienne Walker.

Source/WebCore:

Fold opacity into shader color for solid color layers.

Test: CCSolidColorLayerImplTest.verifyCorrectOpacityInQuad

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawSolidColorQuad):

Source/WebKit/chromium:

  • tests/CCSolidColorLayerImplTest.cpp:

(CCLayerTestCommon::TEST):
(CCLayerTestCommon):

16:29 Changeset [114579] by philn@webkit.org

[GTK] NRWT bails out if more than one X server runs on the machine
https://bugs.webkit.org/show_bug.cgi?id=84276

Reviewed by Dirk Pranke.

Set up GTK driver's Xvfb display number based on Xorg servers
currently running.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkDriver._start):
(GtkDriver._start.x_filter):

16:23 Changeset [114578] by mrobinson@webkit.org

Merging r111556

16:17 Changeset [114577] by dpranke@chromium.org

run-webkit-tests picked up an old crash log
https://bugs.webkit.org/show_bug.cgi?id=84196

Reviewed by Ryosuke Niwa.

Modify the crash log-finding code so that we can
limit our search to logs newer than X - this prevents
us from finding old crash logs for a given process/pid
combination even when the PIDs might've wrapped.

Also fix a bug in filesystem_mock where files_under() would
return paths that didn't exist.

  • Scripts/webkitpy/common/system/crashlogs.py:

(CrashLogs.find_newest_log):
(CrashLogs._find_newest_log_darwin):

  • Scripts/webkitpy/common/system/crashlogs_unittest.py:

(CrashLogsTest.test_find_log_darwin):
(CrashLogsTest.test_find_log_darwin.bad_read):
(CrashLogsTest):

  • Scripts/webkitpy/common/system/filesystem_mock.py:

(MockFileSystem.files_under):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port._get_crash_log):

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort._get_crash_log):

  • Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort._get_crash_log):

  • Scripts/webkitpy/layout_tests/port/port_testcase.py:

(PortTestCase.test_get_crash_log):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitDriver.run_test):

16:11 April 2012 Meeting edited by dbarton@mathscribe.com
(diff)
16:10 Changeset [114576] by pilgrim@chromium.org

[Chromium] Call prefetchDNS directly
https://bugs.webkit.org/show_bug.cgi?id=84262

Reviewed by Kentaro Hara.

Part of a series, see tracking bug 82948.

Source/WebCore:

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

  • platform/network/chromium/DNSChromium.cpp:

(WebCore::prefetchDNS):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore):

16:08 Changeset [114575] by fpizlo@apple.com

jsc command line should support typed arrays by default
https://bugs.webkit.org/show_bug.cgi?id=84298

Rubber stamped by Gavin Barraclough.

  • JSCTypedArrayStubs.h:

(JSC):

  • jsc.cpp:

(GlobalObject::finishCreation):

16:07 Changeset [114574] by jchaffraix@webkit.org

REGRESSION(102040): Auto-table layout with percent width doesn't shrink-to-fit content a cell with colspan
https://bugs.webkit.org/show_bug.cgi?id=84260

Reviewed by Ojan Vafai.

Source/WebCore:

Tests: fast/table/td-width-fifty-percent-regression-expected.html

fast/table/td-width-fifty-percent-regression.html

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
As we are spreading the cell's min / max logical width, we should be updating them.
This prevents the following logic getting confused and allocating more than needed.

LayoutTests:

  • fast/table/td-width-fifty-percent-regression-expected.html: Added.
  • fast/table/td-width-fifty-percent-regression.html: Added.
15:59 Changeset [114573] by dimich@chromium.org

Merge 114342 - Auto-sized frames may be taller than expected
https://bugs.webkit.org/show_bug.cgi?id=84106

Patch by Andrei Burago <aburago@chromium.org> on 2012-04-16
Reviewed by David Levin.

No new tests. The repro steps require using Chrome notifications on Win.

  • page/FrameView.cpp:

(WebCore::FrameView::autoSizeIfEnabled):

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10035046

15:57 Changeset [114572] by dimich@chromium.org

Merge 113287 - Auto-size may not work on first load
https://bugs.webkit.org/show_bug.cgi?id=82989

Patch by Andrei Burago <aburago@chromium.org> on 2012-04-04
Reviewed by David Levin.

No new tests. The only known repro scenario involves using chrome with a third-party extension,
which makes making a test out of it problematic.

  • dom/Document.cpp:

(WebCore::Document::implicitClose):

  • page/FrameView.cpp:

(WebCore::FrameView::autoSizeIfEnabled):

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10116046

15:49 Changeset [114571] by philn@webkit.org

Unreviewed, GTK test_expectations update.

  • platform/gtk/test_expectations.txt: Mark some tests as crashing

in debug builds due to bug 63611.

15:31 Changeset [114570] by fpizlo@apple.com

JSVALUE32_64 should be able to perform division on ARM without crashing, and variables
forced double should not be scrambled when performing OSR entry
https://bugs.webkit.org/show_bug.cgi?id=84272

Reviewed by Geoff Garen.

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

15:29 Changeset [114569] by jschuh@chromium.org

Win8 builds usually fail due to cygwin rebasing
https://bugs.webkit.org/show_bug.cgi?id=84274

Reviewed by Dirk Pranke.

Cygwin can fail to spawn children if the DLL is rebased. This happens
frequently enough on Windows 8 that we should retry on failure.

No new tests. No behavior changed.

  • bindings/scripts/preprocessor.pm:

(applyPreprocessor):

15:03 Changeset [114568] by leviw@chromium.org

Add explicit template instantiation to chromium/PopupListBox.cpp to prepare for sub-pixel layout
https://bugs.webkit.org/show_bug.cgi?id=84264

Reviewed by Eric Seidel.

Explicitly instantiating integer max and min templates to fix compilation in Chromium. We
intentionally truncated these values in platform code, which matches earlier behavior.
See https://trac.webkit.org/wiki/LayoutUnit for details.

No new tests. No change in behavior.

  • platform/chromium/PopupListBox.cpp:

(WebCore::PopupListBox::paintRow):
(WebCore::PopupListBox::layout):

14:53 Changeset [114567] by jer.noble@apple.com

Full Screen mode does not preserve CALayer ordering after exiting.
https://bugs.webkit.org/show_bug.cgi?id=83931

Reviewed by Eric Carlson.

When swapping the placeholder and web views, use -[NSView addSubview:positioned:relativeTo:]
instead of -[NSView replaceSubview:with:], as the latter does not preserve the relative order
of the view's backing CALayers.

Source/WebKit/mac:

  • WebView/WebFullScreenController.mm:

(-[WebFullScreenController _swapView:with:]):

Source/WebKit2:

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController _swapView:with:]):

14:51 Changeset [114566] by macpherson@chromium.org

Prevent potential null pointer dereference in CSSStyleSelector::applyProperty().
https://bugs.webkit.org/show_bug.cgi?id=84267

Reviewed by Kentaro Hara.

No new tests / code cleanup found via static analysis.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

14:45 Changeset [114565] by commit-queue@webkit.org

JavaScriptCore.gypi not current
https://bugs.webkit.org/show_bug.cgi?id=84224

Patch by Don Olmstead <don.olmstead@am.sony.com> on 2012-04-18
Reviewed by Eric Seidel.

Updated JavaScriptCore.gypi to contain the latest sources. Removed os-win32 as it wasn't used. Also removed references to ICU files in the gypi file as ICU is most likely specified by the port itself.

Private and public header files were determined by looking at copy-files.cmd within Apple's Visual Studio directory.

14:34 Changeset [114564] by xan@webkit.org

[Soup] DNS prefetching spams resolver, shoots self in the foot
https://bugs.webkit.org/show_bug.cgi?id=41630

Reviewed by Martin Robinson.

.:

Bump libsoup and glib dependencies.

  • Source/cmake/OptionsEfl.cmake:
  • configure.ac:

Source/WebCore:

Added generic DNSResolveQueue class to throttle DNS
prefetches. It's an abstract refactoring of CFNET's
DNSResolveQueue. Platform specific methods implemented for soup
and CFNET backends.

No new tests required as we're just refactoring existing code to
be used by two different ports.

  • CMakeLists.txt: added new file.
  • GNUmakefile.list.am: ditto.
  • WebCore.vcproj/WebCore.vcproj: ditto.
  • WebCore.xcodeproj/project.pbxproj: ditto.
  • platform/network/DNSResolveQueue.cpp: Added.

(WebCore):
(WebCore::DNSResolveQueue::add): adds a new host to be prefetched.
(WebCore::DNSResolveQueue::fired): by using a delay we coalesce
several prefetch requests and try to resolve them all here.

  • platform/network/DNSResolveQueue.h: Added.

(WebCore):
(DNSResolveQueue): class that implements DNS prefetch
throttling using a template pattern.
(WebCore::DNSResolveQueue::shared):
(WebCore::DNSResolveQueue::decrementRequestCount):

  • platform/network/cf/DNSCFNet.cpp:

(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences):
(WebCore::DNSResolveQueue::platformResolve):

  • platform/network/soup/DNSSoup.cpp:

(WebCore):
(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences):
(WebCore::resolvedCallback):
(WebCore::DNSResolveQueue::platformResolve):
(WebCore::prefetchDNS):

Tools:

Bump libsoup and glib dependencies.

  • efl/jhbuild.modules:
  • gtk/jhbuild.modules:

Conflicts:

Tools/efl/jhbuild.modules

14:34 Changeset [114563] by xan@webkit.org

Build error: DNSSoup.cpp:30: fatal error: CString.h: No such file or
directory
https://bugs.webkit.org/show_bug.cgi?id=81093

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-14
Reviewed by Philippe Normand.

Fix build error introduced by r110669.

  • platform/network/soup/DNSSoup.cpp:
14:34 Changeset [114562] by xan@webkit.org

[GTK] Use the same DNS prefetching path than the other ports.
https://bugs.webkit.org/show_bug.cgi?id=80997

Reviewed by Martin Robinson.

This patch basically reverts r56128. There is no need to add an
special code path for GTK+ DNS pre-fetching because the main
reason to do that (some potential changes in libsoup) is not
going to happen. It also reduces the amount of DNS queries by
adding a NULL hostname check.

No need for new tests as this just moves code around.

  • GNUmakefile.list.am:
  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::parseAttribute):

  • html/HTMLLinkElement.cpp:
  • loader/LinkLoader.cpp:

(WebCore::LinkLoader::loadLink):

  • page/Chrome.cpp:

(WebCore::Chrome::mouseDidMoveOverElement):

  • platform/network/DNS.h:

(WebCore):

  • platform/network/ResourceHandle.cpp:
  • platform/network/ResourceHandle.h:

(ResourceHandle):

  • platform/network/chromium/DNSChromium.cpp:
  • platform/network/soup/DNSSoup.cpp: restored.

(WebCore):
(WebCore::prefetchDNS):

  • platform/network/soup/ResourceHandleSoup.cpp:
14:33 WebKitGTK/1.8.x edited by xan@webkit.org
(diff)
14:27 April 2012 Meeting edited by eoconnor@apple.com
(diff)
14:26 Changeset [114561] by commit-queue@webkit.org

Chromium compile of WebDatabase.cpp fails without SQL_DATABASE
https://bugs.webkit.org/show_bug.cgi?id=84212

Patch by Myles Maxfield <mmaxfield@google.com> on 2012-04-18
Reviewed by Kentaro Hara.

  • src/WebDatabase.cpp:

(WebCore::AbstractDatabase::isSyncDatabase):

14:21 Changeset [114560] by macpherson@chromium.org

Prevent switch case fallthrough in StylePropertySet::getPropertyValue().
https://bugs.webkit.org/show_bug.cgi?id=84266

Reviewed by Kentaro Hara.

No new tests / code cleanup found by static analysis.

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getPropertyValue):

14:04 Changeset [114559] by dpranke@chromium.org

nrwt: support additional test expectations files
https://bugs.webkit.org/show_bug.cgi?id=84222

Reviewed by Ojan Vafai.

This patch adds an --additional-expectations flag that can be
used to point to more files that will override the default set
of expectations. This will allow us to remove the
'google_chrome' ports and eventually help to clean up override
handling in the chromium ports and unify expectations files and
Skipped files; this can also be used to specify overrides for
tests that run differently on a given machine.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.test_expectations_overrides):

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.test_expectations_overrides):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_additional_expectations):

14:01 Changeset [114558] by kling@webkit.org

CSSValuePool: Make numeric value caches fixed-size arrays.
<http://webkit.org/b/84268>

Reviewed by Antti Koivisto.

Change the numeric CSSPrimitiveValue caches in CSSValuePool from HashMaps to
fixed-size arrays of RefPtr<CSSPrimitiveValue>s.

This is more space efficient and doesn't incur the cost of a hash lookup every
time a numeric CSSPrimitiveValue is needed. We retain the limit of caching
only values between 0-255 for now.

  • css/CSSValuePool.cpp:

(WebCore::CSSValuePool::CSSValuePool):
(WebCore::CSSValuePool::createValue):

  • css/CSSValuePool.h:

(CSSValuePool):

13:53 Changeset [114557] by danakj@chromium.org

[chromium] Rename overdraw histograms so we can use field trials in histograms.xml
https://bugs.webkit.org/show_bug.cgi?id=83500

Reviewed by James Robinson.

  • platform/graphics/chromium/cc/CCOverdrawMetrics.cpp:

(WebCore::CCOverdrawMetrics::recordMetricsInternal):

13:52 Changeset [114556] by eae@chromium.org

Merge trunk changes up until 114550 into subpixel branch.

13:47 Changeset [114555] by jer.noble@apple.com

Lion Production Test failing with error: "Failed to stop httpd: pid file still exists" https://bugs.webkit.org/show_bug.cgi?id=84177

Reviewed by Dirk Pranke.

Try to delete the pid file left by Apache in the case it was killed forcefully.

  • Scripts/webkitpy/layout_tests/servers/apache_http_server.py:

(LayoutTestApacheHttpd._stop_running_server):

13:46 Changeset [114554] by fpizlo@apple.com

DFG should have constant propagation
https://bugs.webkit.org/show_bug.cgi?id=84004

Reviewed by Gavin Barraclough.

Changes AbstractValue to be able to hold a "set" of constants, where
the maximum set size is 1 - so merging a value containing constant A
with another value containing constant B where A != B will result in
the AbstractValue claiming that it does not know any constants (i.e.
it'll just have a predicted type and possible a structure).

Added a constant folding phase that uses this new information to
replace pure operations known to have constant results with
JSConstants. This is OSR-exit-aware, in that it will prepend a Phantom
that refers to all of the kids of the node we replaced.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::beginBasicBlock):
(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::execute):

  • dfg/DFGAbstractState.h:

(AbstractState):

  • dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::clear):
(JSC::DFG::AbstractValue::isClear):
(JSC::DFG::AbstractValue::makeTop):
(JSC::DFG::AbstractValue::clobberValue):
(AbstractValue):
(JSC::DFG::AbstractValue::valueIsTop):
(JSC::DFG::AbstractValue::value):
(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::operator==):
(JSC::DFG::AbstractValue::merge):
(JSC::DFG::AbstractValue::filter):
(JSC::DFG::AbstractValue::validate):
(JSC::DFG::AbstractValue::checkConsistency):
(JSC::DFG::AbstractValue::dump):

  • dfg/DFGAdjacencyList.h:

(JSC::DFG::AdjacencyList::initialize):
(AdjacencyList):
(JSC::DFG::AdjacencyList::reset):

  • dfg/DFGBasicBlock.h:

(JSC::DFG::BasicBlock::BasicBlock):
(BasicBlock):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::constantCSE):
(CSEPhase):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGConstantFoldingPhase.cpp: Added.

(DFG):
(ConstantFoldingPhase):
(JSC::DFG::ConstantFoldingPhase::ConstantFoldingPhase):
(JSC::DFG::ConstantFoldingPhase::run):
(JSC::DFG::performConstantFolding):

  • dfg/DFGConstantFoldingPhase.h: Added.

(DFG):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGGraph.h:

(Graph):
(JSC::DFG::Graph::convertToConstant):

  • dfg/DFGInsertionSet.h:

(JSC::DFG::InsertionSet::execute):

  • dfg/DFGNode.h:

(JSC::DFG::Node::convertToConstant):
(Node):

  • runtime/JSValue.cpp:

(JSC::JSValue::description):

  • runtime/JSValue.h:

(JSValue):

13:37 Changeset [114553] by fpizlo@apple.com

Unreviewed, adding files that I forgot to add in http://trac.webkit.org/changeset/114472

  • dfg/DFGSilentRegisterSavePlan.h: Added.

(DFG):
(SilentRegisterSavePlan):
(JSC::DFG::SilentRegisterSavePlan::SilentRegisterSavePlan):
(JSC::DFG::SilentRegisterSavePlan::spillAction):
(JSC::DFG::SilentRegisterSavePlan::fillAction):
(JSC::DFG::SilentRegisterSavePlan::nodeIndex):
(JSC::DFG::SilentRegisterSavePlan::gpr):
(JSC::DFG::SilentRegisterSavePlan::fpr):

  • dfg/DFGSlowPathGenerator.h: Added.

(DFG):
(SlowPathGenerator):
(JSC::DFG::SlowPathGenerator::SlowPathGenerator):
(JSC::DFG::SlowPathGenerator::~SlowPathGenerator):
(JSC::DFG::SlowPathGenerator::generate):
(JSC::DFG::SlowPathGenerator::label):
(JSC::DFG::SlowPathGenerator::call):
(JumpingSlowPathGenerator):
(JSC::DFG::JumpingSlowPathGenerator::JumpingSlowPathGenerator):
(JSC::DFG::JumpingSlowPathGenerator::linkFrom):
(JSC::DFG::JumpingSlowPathGenerator::jumpTo):
(CallSlowPathGenerator):
(JSC::DFG::CallSlowPathGenerator::CallSlowPathGenerator):
(JSC::DFG::CallSlowPathGenerator::call):
(JSC::DFG::CallSlowPathGenerator::setUp):
(JSC::DFG::CallSlowPathGenerator::recordCall):
(JSC::DFG::CallSlowPathGenerator::tearDown):
(CallResultAndNoArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndNoArgumentsSlowPathGenerator::CallResultAndNoArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndNoArgumentsSlowPathGenerator::generateInternal):
(CallResultAndOneArgumentSlowPathGenerator):
(JSC::DFG::CallResultAndOneArgumentSlowPathGenerator::CallResultAndOneArgumentSlowPathGenerator):
(JSC::DFG::CallResultAndOneArgumentSlowPathGenerator::generateInternal):
(CallResultAndTwoArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndTwoArgumentsSlowPathGenerator::CallResultAndTwoArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndTwoArgumentsSlowPathGenerator::generateInternal):
(CallResultAndThreeArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndThreeArgumentsSlowPathGenerator::CallResultAndThreeArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndThreeArgumentsSlowPathGenerator::generateInternal):
(CallResultAndFourArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndFourArgumentsSlowPathGenerator::CallResultAndFourArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndFourArgumentsSlowPathGenerator::generateInternal):
(CallResultAndFiveArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndFiveArgumentsSlowPathGenerator::CallResultAndFiveArgumentsSlowPathGenerator):
(JSC::DFG::CallResultAndFiveArgumentsSlowPathGenerator::generateInternal):
(JSC::DFG::slowPathCall):
(AssigningSlowPathGenerator):
(JSC::DFG::AssigningSlowPathGenerator::AssigningSlowPathGenerator):
(JSC::DFG::AssigningSlowPathGenerator::generateInternal):
(JSC::DFG::slowPathMove):

13:34 Changeset [114552] by commit-queue@webkit.org

[Chromium] Solid color shader should use premultiplied alpha.
https://bugs.webkit.org/show_bug.cgi?id=84215

Patch by David Reveman <reveman@chromium.org> on 2012-04-18
Reviewed by Adrienne Walker.

For efficiency and consistency, expect premultiplied alpha in
solid color shader.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawDebugBorderQuad):
(WebCore::LayerRendererChromium::drawSolidColorQuad):

  • platform/graphics/chromium/ShaderChromium.cpp:

(WebCore::FragmentShaderColor::getShaderString):

13:23 Changeset [114551] by ap@apple.com

[WK2] Sandbox violations prevent attaching files to gmail messages
https://bugs.webkit.org/show_bug.cgi?id=84263
<rdar://problem/11248260>

Reviewed by Oliver Hunt.

  • page/DragActions.h: Removed the newly added upload action. We cannot know if or when an upload is going to happen - a drop even listener can always get a reference to a File object, and upload it with XMLHttpRequest.
  • page/DragController.cpp: (WebCore::DragController::concludeEditDrag): Removed a separate willPerformDragDestinationAction call for upload action - ther is nothing we'd want to only do when dropping on a file upload button.
13:13 LayoutUnit edited by leviw@chromium.org
(diff)
13:12 Changeset [114550] by eae@chromium.org

WebKit/win cleanup on branch.

13:08 Changeset [114549] by leviw@chromium.org

Merging in r114548.

13:05 Changeset [114548] by leviw@chromium.org

GraphicsContextCG's roundToDevicePixels should round even when there's no transform
https://bugs.webkit.org/show_bug.cgi?id=84191

Reviewed by Eric Seidel.

When painting with the identify transform, the roundToDevicePixels function in GraphicsContextCG
does an early return that simply returns the FloatRect that was passed in. This proved to be a
problem in sub-pixel layout, as we wouldn't adjust the paint rect for text underline, and it could
end up being more than one pixel wide. Adding a roundedIntRect method on FloatRect for the simple
short-circuit case.

No new tests. No change in behavior before switching to sub-pixel layout.

  • platform/graphics/FloatRect.cpp:

(WebCore::roundedIntRect):

  • platform/graphics/FloatRect.h:
  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::roundToDevicePixels):

12:53 Changeset [114547] by lforschler@apple.com

Versioning.

12:48 Changeset [114546] by commit-queue@webkit.org

Clean-up WheelEvent Conversion.
https://bugs.webkit.org/show_bug.cgi?id=84243

Source/WebKit/qt:

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-18
Reviewed by Simon Hausmann.

  • WebCoreSupport/WebEventConversion.cpp:

(WebCore::WebKitPlatformWheelEvent::applyDelta):

Source/WebKit2:

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-18
Reviewed by Simon Hausmann.

  • Shared/qt/WebEventFactoryQt.cpp:

(WebKit::WebEventFactory::createWebWheelEvent):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::wheelEvent):

Tools:

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-18
Reviewed by Simon Hausmann.

Calculate proper wheel-delta from pixel-delta given.

  • DumpRenderTree/qt/EventSenderQt.cpp:

(EventSender::EventSender):
(EventSender::mouseScrollBy):
(EventSender::continuousMouseScrollBy):

LayoutTests:

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-18
Reviewed by Simon Hausmann.

  • platform/qt/fast/events/continuous-platform-wheelevent-in-scrolling-div-expected.txt:
12:32 Changeset [114545] by keishi@webkit.org

[chromium] Turn on ENABLE_DATALIST for chromium
https://bugs.webkit.org/show_bug.cgi?id=84118

Reviewed by Kent Tamura.

Source/WebCore:

  • html/HTMLDataListElement.cpp: Touched to avoid build issues. No code change.
  • html/HTMLDataListElement.h: Ditto.
  • html/HTMLInputElement.cpp: Ditto.
  • html/HTMLInputElement.h: Ditto.

Source/WebKit/chromium:

  • features.gypi: Turn on ENABLE_DATALIST.
  • src/WebInputElement.cpp: Touched to avoid build issues. No code change.

LayoutTests:

  • platform/chromium/fast/forms/label/labelable-elements-expected.txt: Update expectated result.
12:25 SelectiveTestEWS edited by beszedes@inf.u-szeged.hu
(diff)
12:19 Changeset [114544] by commit-queue@webkit.org

[Qt] WheelEventQt.cpp should be deleted.
https://bugs.webkit.org/show_bug.cgi?id=84237

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-18
Reviewed by Simon Hausmann.

  • platform/qt/WheelEventQt.cpp: Removed.
12:14 SelectiveTestBuildBot edited by beszedes@inf.u-szeged.hu
(diff)
11:58 Changeset [114543] by commit-queue@webkit.org

[EFL][DRT] Update baselines after font-face support was fixed
https://bugs.webkit.org/show_bug.cgi?id=84234

Unreviewed, EFL gardening.

Fixing baselines for css/font-face* tests and tests affected
by working @font-face. A bunch of table/* rebaselines will
follow in a separate batch.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-18

  • platform/efl/fast/css/beforeSelectorOnCodeElement-expected.png:
  • platform/efl/fast/css/font-face-default-font-expected.png:
  • platform/efl/fast/css/font-face-in-media-rule-expected.png:
  • platform/efl/fast/css/font-face-multiple-faces-expected.png:
  • platform/efl/fast/css/font-face-multiple-faces-expected.txt:
  • platform/efl/fast/css/font-face-opentype-expected.png:
  • platform/efl/fast/css/font-face-opentype-expected.txt:
  • platform/efl/fast/css/font-face-remote-expected.png:
  • platform/efl/fast/css/font-face-remote-expected.txt:
  • platform/efl/fast/css/font-face-synthetic-bold-italic-expected.png: Added.
  • platform/efl/fast/css/font-face-synthetic-bold-italic-expected.txt: Added.
  • platform/efl/fast/css/font-face-unicode-range-expected.png:
  • platform/efl/fast/css/font-face-unicode-range-expected.txt:
  • platform/efl/fast/css/font-face-weight-matching-expected.png: Added.
  • platform/efl/fast/css/font-face-weight-matching-expected.txt: Added.
  • platform/efl/fast/css/font-face-woff-expected.png:
  • platform/efl/fast/css/font-face-woff-expected.txt:
  • platform/efl/fast/css/rtl-ordering-expected.txt:
  • platform/efl/fast/css/text-security-expected.txt:
  • platform/efl/fast/events/updateLayoutForHitTest-expected.png:
  • platform/efl/fast/writing-mode/broken-ideograph-small-caps-expected.png:
  • platform/efl/fast/writing-mode/broken-ideograph-small-caps-expected.txt:
  • platform/efl/fast/writing-mode/broken-ideographic-font-expected.png:
  • platform/efl/fast/writing-mode/broken-ideographic-font-expected.txt:
  • platform/efl/test_expectations.txt:
11:54 Changeset [114542] by eae@chromium.org

Merge trunk changes up until 114521 into subpixel branch.

11:46 Changeset [114541] by eae@chromium.org

Unreviewed. Adding FIXME comment to FractionalLayoutUnit explaining the lack of size_t operators.

  • platform/FractionalLayoutUnit.h:

(FractionalLayoutUnit):

11:40 Changeset [114540] by dgrogan@chromium.org

IDB: Pending setVersion call in worker prevents document from opening the db, even after worker termination
https://bugs.webkit.org/show_bug.cgi?id=83952

These two tests fail in DRT most proximately because DRT provides
different instances of IDBFactoryBackend to a document and worker:
https://bugs.webkit.org/show_bug.cgi?id=82776.

One fails in chromium because of a logic error tracked by
http://crbug.com/123418. The plan is to run them both as browser tests
when the logic is fixed, but just one in the meantime.

Also added SKIP for storage/indexeddb/dont-commit-on-blocked.html
since it also can't pass in DRT and just turns the flakiness dashboard
all red.

Reviewed by Ojan Vafai.

  • platform/chromium/test_expectations.txt:
  • storage/indexeddb/pending-version-change-stuck-expected.txt: Added.
  • storage/indexeddb/pending-version-change-stuck-works-with-terminate-expected.txt: Added.
  • storage/indexeddb/pending-version-change-stuck-works-with-terminate.html: Added.
  • storage/indexeddb/pending-version-change-stuck.html: Added.
  • storage/indexeddb/resources/pending-version-change-stuck.js: Added.

(test.request.onsuccess.request.onblocked):
(test.request.onsuccess):
(test):

11:36 Changeset [114539] by benjamin@webkit.org

Remove m_subclassData from JSArray, move the attribute to subclass as needed
https://bugs.webkit.org/show_bug.cgi?id=84249

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-18
Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

JSArray's m_subclassData is only used by WebCore's RuntimeArray. This patch moves
the attribute to RuntimeArray to avoid allocating memory for the pointer in the common
case.

This gives ~1% improvement in JSArray creation microbenchmark thanks to fewer allocations
of CopiedSpace.

  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateJSArray):

  • runtime/JSArray.cpp:

(JSC::JSArray::JSArray):

  • runtime/JSArray.h:

Source/WebCore:

  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::RuntimeArray):
(JSC::RuntimeArray::finishCreation):

  • bridge/runtime_array.h:

(JSC::RuntimeArray::getLength):
(JSC::RuntimeArray::getConcreteArray):
(RuntimeArray):

11:34 Changeset [114538] by antti@apple.com

matchMedia() MediaQueryList not updating
https://bugs.webkit.org/show_bug.cgi?id=75903

Patch by Luiz Agostini <luiz.agostini@palm.com> on 2012-04-18
Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/media/media-query-list-08.html

Viewport related MediaQueryList listeners were not triggered and the value
of matches were not updated if the document's style selector were not
affected by viewport changes.

The new method evaluateMediaQueries() is now called by FrameView instead of
styleSelectorChanged() if the style selector is not affected by viewport changes.

  • dom/Document.cpp:

(WebCore::Document::evaluateMediaQueries):
(WebCore):
(WebCore::Document::styleSelectorChanged):

  • dom/Document.h:

(Document):

  • page/FrameView.cpp:

(WebCore::FrameView::layout):

LayoutTests:

Testing MediaQueryLists listeners related to viewport changes.

  • fast/media/media-query-list-08-expected.txt: Added.
  • fast/media/media-query-list-08.html: Added.

Skipping the new test in Mac and Qt due to an issue in its DumpRenderTree.

  • platform/qt/Skipped:
  • platform/mac/Skipped:
11:31 Changeset [114537] by eae@chromium.org

Use explicit casts for size_t to unsigned conversion
https://bugs.webkit.org/show_bug.cgi?id=83602

Reviewed by Eric Seidel.

No new tests, no change in functinality.

Not all platforms have implicit casts from size_t to unsigned and we
can't add size_t versions of the operators to FractionalLayoutUnit for
all platforms as it would conflict with the unsigned versions of same.

Change support methods to take unsigned instead of size_t and use
explicit casts when multiplying or dividing a FractionalLayoutUnit with
a size_t and the other way around.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustForColumns):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::initialPackingOffset):
(WebCore::packingSpaceBetweenChildren):
(WebCore::initialLinePackingOffset):
(WebCore::linePackingSpaceBetweenChildren):
(WebCore::RenderFlexibleBox::packFlexLines):

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::layout):

11:31 Changeset [114536] by philn@webkit.org

Unreviewed, GTK test_expectations update.

  • platform/gtk/test_expectations.txt: Skip some failing tests and

mark 3 more frame flattening tests flaky.

11:14 Changeset [114535] by pfeldman@chromium.org

Source/WebCore: Web Inspector: [Chromium] Module's require injects scripts before the debug id is set to the context.
https://bugs.webkit.org/show_bug.cgi?id=84166

Re-applying r114497.

  • bindings/v8/V8IsolatedContext.cpp:

(WebCore::setInjectedScriptContextDebugId):
(WebCore):
(WebCore::V8IsolatedContext::V8IsolatedContext):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::evaluateInIsolatedWorld):

  • bindings/v8/V8Proxy.h:

(V8Proxy):

LayoutTests: Unreviewed, rolling out r114506.
http://trac.webkit.org/changeset/114506
https://bugs.webkit.org/show_bug.cgi?id=84254

Seems to be making gtk's DumpRenderTree crash occasionally
(Requested by tomz on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-18

  • platform/gtk/test_expectations.txt:
11:06 Changeset [114534] by achicu@adobe.com

Unreviewed, trying to fix QT build.

It was using a FilterEffectRenderer::prepare that changed to allocateBackingStoreIfNeeded in 114529.

  • platform/graphics/texmap/TextureMapperImageBuffer.cpp:

(WebCore::BitmapTextureImageBuffer::applyFilters):

11:03 Changeset [114533] by enne@google.com

[chromium] Unreviewed, rebaseline compositing tests after r114283.
https://bugs.webkit.org/show_bug.cgi?id=84083

  • platform/chromium-linux/compositing/overflow/overflow-positioning-expected.png:
  • platform/chromium-mac-leopard/compositing/overflow/overflow-positioning-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/overflow/overflow-positioning-expected.png:
  • platform/chromium-mac/compositing/overflow/overflow-positioning-expected.png:
  • platform/chromium-win/compositing/backing/no-backing-for-clip-expected.txt: Added.
  • platform/chromium-win/compositing/backing/no-backing-for-clip-overlap-expected.txt: Added.
  • platform/chromium-win/compositing/backing/no-backing-for-perspective-expected.txt: Added.
  • platform/chromium-win/compositing/geometry/preserve-3d-switching-expected.txt:
  • platform/chromium-win/compositing/overflow/overflow-positioning-expected.png:
  • platform/chromium/test_expectations.txt:
11:01 Changeset [114532] by pfeldman@chromium.org

Web Inspector: extract script navigator overlay logic into the scripts navigator controller.
https://bugs.webkit.org/show_bug.cgi?id=84244

Reviewed by Vsevolod Vlasov.

Overlay logic is well separable from the scripts panel and does not belong there.
Extracting it into a separate class.

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigatorController.prototype.wasShown):
(WebInspector.ScriptsNavigatorController.prototype._createNavigatorControlButton):
(WebInspector.ScriptsNavigatorController.prototype._escDownWhileNavigatorOverlayOpen):
(WebInspector.ScriptsNavigatorController.prototype._toggleNavigator):
(WebInspector.ScriptsNavigatorController.prototype._hidePinnedNavigator):
(WebInspector.ScriptsNavigatorController.prototype.set _pinNavigator):
(WebInspector.ScriptsNavigatorController.prototype.set showNavigatorOverlay):
(WebInspector.ScriptsNavigatorController.prototype.hideNavigatorOverlay):
(WebInspector.ScriptsNavigatorController.prototype._navigatorOverlayWasShown):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.wasShown):
(WebInspector.ScriptsPanel.prototype._editorClosed):
(WebInspector.ScriptsPanel.prototype._editorSelected):
(WebInspector.ScriptsPanel.prototype._scriptSelected):

11:01 Changeset [114531] by tomz@codeaurora.org

Unreviewed, rolling out r114506.
http://trac.webkit.org/changeset/114506
https://bugs.webkit.org/show_bug.cgi?id=84254

Seems to be making gtk's DumpRenderTree crash occasionally
(Requested by tomz on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-18

Source/WebKit/gtk:

  • webkit/webkitwebsettings.cpp:

(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):

  • webkit/webkitwebsettingsprivate.h:
  • webkit/webkitwebview.cpp:

(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):

Tools:

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

LayoutTests:

  • platform/gtk/test_expectations.txt:
10:44 Changeset [114530] by dimich@chromium.org

Unreviewed, rolling out r114497.
http://trac.webkit.org/changeset/114497
https://bugs.webkit.org/show_bug.cgi?id=84253

Broke compile on Win, including stdio did not help (Requested
by dimich on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-18

  • bindings/v8/V8IsolatedContext.cpp:

(WebCore::V8IsolatedContext::V8IsolatedContext):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::evaluateInIsolatedWorld):
(WebCore::V8Proxy::setInjectedScriptContextDebugId):
(WebCore):

  • bindings/v8/V8Proxy.h:

(V8Proxy):

10:37 Changeset [114529] by achicu@adobe.com

[CSS Filters] Drop-shadow and blur can avoid using full source image
https://bugs.webkit.org/show_bug.cgi?id=81263

Reviewed by Dean Jackson.

Instead of using the full bounding box of the RenderLayer we now compute the exact rectangle that is needed to
compute filter inside the dirty rectangle on screen. That's easy to calculate by reversing the filter outsets.
Even if the element is completely offscreen, but its shadow is in the viewport, we can still compute the source
rectangle that needs to be drawn in order to update the shadow correctly.

No new tests, this change doesn't have visible results and the functionality should
already be covered by previous filter tests.

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::FilterEffectRenderer):
(WebCore::FilterEffectRenderer::build): Save the outsets of the filters, so that we can use them in computeSourceImageRectForDirtyRect.
(WebCore::FilterEffectRenderer::updateBackingStoreRect): Only allocate a new source image if the size of the source rectangle changed.
(WebCore::FilterEffectRenderer::allocateBackingStoreIfNeeded): There's no need to call clearIntermediateResults() in this function. We do that after
the filter is computed.
(WebCore::FilterEffectRenderer::computeSourceImageRectForDirtyRect):
(WebCore):
(WebCore::FilterEffectRendererHelper::prepareFilterEffect):
(WebCore::FilterEffectRendererHelper::beginFilterEffect):

  • rendering/FilterEffectRenderer.h:

(FilterEffectRendererHelper):
(WebCore::FilterEffectRendererHelper::repaintRect):
(FilterEffectRenderer):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerContents):

10:23 Changeset [114528] by xan@webkit.org

[GTK] Enable back double buffering on WebKitWebView to fix flickering
https://bugs.webkit.org/show_bug.cgi?id=84149

Patch by Carlos Garnacho <carlos@lanedo.com> on 2012-04-17
Reviewed by Martin Robinson.

Despite having WebKitWebView its own backing buffer, calling
gtk_widget_set_double_buffered(...,FALSE) may still pose side
effects, such as ensuring that all drawing operations are
flushed to the X server before rendering a non-double buffered
widget, which may translate into flickering of the parent
GdkWindow before the WebKitWebView itself is rendered.

Enabling back double buffering solves this as all contents are
first composited together before getting to the front buffer,
but effectively acts as 3rd buffer. This is sort of unavoidable
unless GTK+ gains a "let me take ownership of the backing buffer
for this widget", which currently lacks.

  • webkit/webkitwebview.cpp:

(webkit_web_view_init): Remove call to gtk_widget_set_double_buffered(..., FALSE)

10:23 Changeset [114527] by xan@webkit.org

[soup] Crash while loading http://www.jusco.cn
https://bugs.webkit.org/show_bug.cgi?id=68238

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-04-09
Reviewed by Philippe Normand.

.:

  • configure.ac: Bumped the libsoup dependency to 2.37.90.

Source/WebCore:

Test: http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers.html

When running synchronous XMLHttpRequests, push a new inner thread default
context, so that other sources from timers and network activity do not run.
This will make synchronous requests truly synchronous with the rest of
WebCore.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCoreSynchronousLoader): Clean up the method definitions a bit by writing them inline.
(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): Push a new thread default
context to prevent other sources from running.
(WebCore::WebCoreSynchronousLoader::~WebCoreSynchronousLoader): Pop the inner thread default context.
(WebCore::closeCallback): If the client is synchronous call didFinishLoading now.
(WebCore::readCallback): Only call didFinishLoading if the client isn't synchronous.
(WebCore::ResourceHandle::defaultSession): Activate use-thread-context so that the soup session
respects the inner thread context.

LayoutTests:

  • http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-sync-no-timers.html: Added.
10:22 Changeset [114526] by xan@webkit.org

[GTK] Toggle buttons do not size appropriately in some themes
https://bugs.webkit.org/show_bug.cgi?id=82833

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-04-09
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Test: platform/gtk/fast/forms/large-toggle-elements.html

Instead of drawing a toggle button across the entire rectangle of
the WebCore control, draw a default-sized one cenetered in the rectangle.

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore::paintToggle): Draw default-sized toggles.

LayoutTests:

Add a test for this issue.

  • platform/gtk/fast/forms/large-toggle-elements-expected.png: Added.
  • platform/gtk/fast/forms/large-toggle-elements-expected.txt: Added.
  • platform/gtk/fast/forms/large-toggle-elements.html: Added.
10:22 Changeset [114525] by xan@webkit.org

[GTK] Scrolling some iframes that are partially out of the viewport leads to repaint errors
https://bugs.webkit.org/show_bug.cgi?id=83309

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-04-05
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Test: platform/gtk/fast/frames/scrolling-iframe-out-of-viewport.html

The X11 backing store was not properly trimming the scroll region when it
was only a portion of the screen. This was hidden by subsequent repaints.

  • platform/gtk/GtkWidgetBackingStoreX11.cpp:

(WebCore::WidgetBackingStore::scroll): Fix the calculation of the scrolling region.

Source/WebKit/gtk:

Instead of only updating scrollRect - preservedRegion, update
scrollRect - (preservedRegion - offscreenPreservedRegion). This ensures that
when part of the scroll rect is moved onscreen from offscreen that part is
queued for a redraw.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::scroll): Properly calculate the area to repaint.

LayoutTests:

Added a pixel test for this issue.

  • platform/gtk/fast/frames/resources/scrolling-iframe-out-of-viewport-interior.html: Added.
  • platform/gtk/fast/frames/scrolling-iframe-out-of-viewport-expected.png: Added.
  • platform/gtk/fast/frames/scrolling-iframe-out-of-viewport-expected.txt: Added.
  • platform/gtk/fast/frames/scrolling-iframe-out-of-viewport.html: Added.
10:22 WebKitGTK/1.8.x edited by xan@webkit.org
(diff)
10:17 WebKitGTK/1.8.x edited by xan@webkit.org
(diff)
10:17 Changeset [114524] by xan@webkit.org

SIGILL in JavaScriptCore on a Geode processor
https://bugs.webkit.org/show_bug.cgi?id=82496

Reviewed by Gavin Barraclough.

Don't attempt to use the DFG when SSE2 is not available.

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::canCompileOpcodes):

10:16 Changeset [114523] by commit-queue@webkit.org

[EFL][DRT] @font-face support fails on EFL
https://bugs.webkit.org/show_bug.cgi?id=83264

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-18
Reviewed by Dimitri Glazkov.

STORE_FONT_CUSTOM_PLATFORM_DATA was not defined for EFL.
Fixing that by removing a long standing FIXME with the intention
to turn the whitelist for this switch into a blacklist.

  • loader/cache/CachedFont.cpp:
10:16 WebKitGTK/1.8.x edited by xan@webkit.org
(diff)
10:15 Changeset [114522] by xan@webkit.org

[GTK] Respect NOCONFIGURE option in autogen.sh
https://bugs.webkit.org/show_bug.cgi?id=82447

Reviewed by Philippe Normand.

Make autogen.sh follow the new build-api for GNOME, see
http://people.gnome.org/~walters/docs/build-api.txt

  • autogen.sh: respect the NOCONFIGURE environment flag, per the

new GNOME build-api.

10:07 Changeset [114521] by benjamin@webkit.org

replaceUsingStringSearch: delay the creation of the replace string until needed
https://bugs.webkit.org/show_bug.cgi?id=83841

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-18
Reviewed by Geoffrey Garen.

We do not need to obtain the replaceValue until we have a match. By moving the intialization
of replaceValue when needed, we save a few instructions when there is no match.

  • runtime/StringPrototype.cpp:

(JSC::replaceUsingRegExpSearch):
(JSC::replaceUsingStringSearch):
(JSC::stringProtoFuncReplace):

10:05 Changeset [114520] by leviw@chromium.org

Convert ShadowData and DropShadowFilterOperation to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=84098

Reviewed by Eric Seidel.

Shadows do not flow with the page, so sub-pixel layout doesn't actually offer any benefit that
couldn't have been attained before that conversion. With that in mind, this patch reverts
drop shadow offsets to integers, but also cleans up the code by switching the x/y location pair
to be an IntPoint.

No new tests. No change in behavior.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::valueForFilter):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • css/SVGCSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applySVGProperty):

  • page/animation/AnimationBase.cpp:

(WebCore::blendFunc):
(WebCore::shadowForBlending):

  • platform/animation/AnimationUtilities.h:

(WebCore::blend): New blend function that operates on IntPoints.
(WebCore):

  • platform/chromium/support/WebFilterOperations.cpp:

(WebKit::WebDropShadowFilterOperation):

  • platform/graphics/filters/FilterOperation.cpp:

(WebCore::DropShadowFilterOperation::blend):

  • platform/graphics/filters/FilterOperation.h:

(WebCore::DropShadowFilterOperation::clone):
(WebCore::DropShadowFilterOperation::x):
(WebCore::DropShadowFilterOperation::y):
(WebCore::DropShadowFilterOperation::location): Preserved the comment about lengths.
(WebCore::DropShadowFilterOperation::operator==):
(WebCore::DropShadowFilterOperation::DropShadowFilterOperation):
(DropShadowFilterOperation):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::areaCastingShadowInHole): Reverted to integers since this operates on the IntRect from
a RoundedRect.
(WebCore::RenderBoxModelObject::paintBoxShadow): Reduced the complexity and unnecessary conversion
between LayoutUnits and integers by using all integers after we calculate the pixel-snapped
RoundedRect that we use for painting.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::getShadowExtent):
(WebCore::RenderStyle::getShadowHorizontalExtent):
(WebCore::RenderStyle::getShadowVerticalExtent):

  • rendering/style/ShadowData.cpp:

(WebCore::ShadowData::ShadowData):
(WebCore::ShadowData::operator==):
(WebCore::calculateShadowExtent):
(WebCore::ShadowData::adjustRectForShadow):

  • rendering/style/ShadowData.h:

(WebCore::ShadowData::ShadowData):
(WebCore::ShadowData::x):
(WebCore::ShadowData::y):
(WebCore::ShadowData::location):
(ShadowData):

09:53 Changeset [114519] by haraken@chromium.org

[V8] Add an optional Isolate argument to wrap()
https://bugs.webkit.org/show_bug.cgi?id=84202

Reviewed by Nate Chapin.

The final objective is to pass Isolate around in V8 bindings.
This patch adds an optional Isolate argument to wrap().
After rewriting all wrap() callers so that they pass Isolate
to wrap(), I'll make the Isolate argument non-optional.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm: Modified as described above.

(GenerateHeader):

  • bindings/v8/custom/V8DocumentCustom.cpp: Ditto.

(WebCore::toV8):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: Ditto.

(WebCore::toV8):

  • bindings/v8/custom/V8NodeCustom.cpp: Ditto.

(WebCore::toV8Slow):

  • bindings/v8/custom/V8SVGDocumentCustom.cpp: Ditto.

(WebCore::toV8):

  • dom/make_names.pl: Ditto.

(printWrapperFactoryCppFile):

  • bindings/scripts/test/V8/V8Float64Array.h:

Updated run-bindings-tests results.
(V8Float64Array):
(WebCore::V8Float64Array::wrap):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):
(WebCore::V8TestActiveDOMObject::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):
(WebCore::V8TestCustomNamedGetter::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):
(WebCore::V8TestEventConstructor::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):
(WebCore::V8TestEventTarget::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):
(WebCore::V8TestInterface::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):
(WebCore::V8TestMediaQueryListListener::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):
(WebCore::V8TestNamedConstructor::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestNode.h:

(V8TestNode):
(WebCore::V8TestNode::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):
(WebCore::V8TestObj::wrap):
(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):
(WebCore::V8TestSerializedScriptValueInterface::wrap):
(WebCore::toV8):

09:34 Changeset [114518] by achicu@adobe.com

[CSS Filters] Do not use clipping rect when calculating the bounds of a layer
https://bugs.webkit.org/show_bug.cgi?id=83960

Reviewed by Simon Fraser.

The local clip rect should not be used when calculating the bounds of a filter area. Otherwise
drop-shadow might not know about the pixels outside the clipping rectangle, even though the actual shadow might
be inside it.

No new tests added in this patch, but this patch fixes two existing tests that fail.
LayoutTests/css3/filters/filter-repaint-shadow-clipped.html
LayoutTests/css3/filters/filter-repaint-shadow-rotated.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::calculateLayerBounds):

  • rendering/RenderLayer.h:
09:33 Changeset [114517] by lforschler@apple.com

New tag.

09:29 Changeset [114516] by mrobinson@webkit.org

Merging r111263

09:29 Changeset [114515] by pilgrim@chromium.org

Followup to "Call incrementStatsCounter directly"
https://bugs.webkit.org/show_bug.cgi?id=83109

Reviewed by Kentaro Hara.

Now that incrementStatsCounter has been moved from
PlatformSupport.h to Platform.h, we need to be able to call it directly
from WebCore/bindings/v8/v8Proxy.h (for the INC_STATS macro). That
means we need a new StatsCounter class in WebCore/platform/ and an
implementation in
WebCore/platform/chromium/StatsCounterChromium.cpp. Other ports
are welcome to implement their own stats counters if they
wish. This pattern was based on the
HistogramSupport/HistogramSupportChromium classes.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/v8/V8Proxy.h:
  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:

(WebCore::V8DedicatedWorkerContext::postMessageCallback):
(WebCore::V8DedicatedWorkerContext::webkitPostMessageCallback):

  • bindings/v8/custom/V8NotificationCenterCustom.cpp:

(WebCore::V8NotificationCenter::createHTMLNotificationCallback):
(WebCore::V8NotificationCenter::createNotificationCallback):
(WebCore::V8NotificationCenter::requestPermissionCallback):

  • bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::V8WorkerContext::importScriptsCallback):
(WebCore::V8WorkerContext::setTimeoutCallback):
(WebCore::V8WorkerContext::setIntervalCallback):

  • platform/StatsCounter.cpp: Added.

(WebCore):
(WebCore::StatsCounter::incrementStatsCounter):

  • platform/StatsCounter.h: Added.

(WebCore):
(StatsCounter):

  • platform/chromium/StatsCounterChromium.cpp: Added.

(WebCore):
(WebCore::StatsCounter::incrementStatsCounter):

09:28 Changeset [114514] by eae@chromium.org

Replace uses of size_t with unsigned in rendering code on branch.

09:25 Changeset [114513] by apavlov@chromium.org

[Chromium] REGRESSION: Popup shrinks because of autocomplete
https://bugs.webkit.org/show_bug.cgi?id=84139
http://code.google.com/p/chromium/issues/detail?id=123432

Source/WebCore:

Do not update the window rect on the wrong client but instead return the popup widget's
new screen coordinates from the refresh() method.

Reviewed by Kent Tamura.

  • platform/chromium/PopupContainer.cpp:

(WebCore::PopupContainer::refresh):

  • platform/chromium/PopupContainer.h:

(PopupContainer):

Source/WebKit/chromium:

Do not use the PopupContainer's frameRect() to update the popup client's window rect,
since PopupContainer is always positioned at (0, 0) inside the client's window rect,
and the latter one is positioned relative to the screen origin.

Reviewed by Kent Tamura.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::refreshAutofillPopup):

09:20 Changeset [114512] by mrobinson@webkit.org

Merging r110487

09:18 Changeset [114511] by mhahnenberg@apple.com

GC activity timer should be tied to allocation, not collection
https://bugs.webkit.org/show_bug.cgi?id=83919

Reviewed by Geoffrey Garen.

  • API/JSContextRef.cpp: Used the new didAbandonObjectGraph callback to indicate that now that we've

released a global object, we're abandoning a potentially large number of objects that JSC might want
to collect.

  • heap/CopiedSpace.cpp:

(JSC::CopiedSpace::tryAllocateSlowCase): Added the call to timer's willAllocate function to indicate
that we've hit a slow path and are allocating now, so schedule the timer.

  • heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::collectAllGarbage): Removed the call to discardAllCompiledCode because it was causing us to
throw away too much code during our benchmarks (especially vp8, which is very large and thus has large
amounts of compiled code).
(JSC::Heap::collect): Added the new call to didCollect at the conclusion of a collection so that we
can cancel the timer if we no longer need to run a collection. Also added a check at the beginning of a
collection to see if we should throw away our compiled code. Currently this is set to happen about once
every minute.

  • heap/Heap.h: Added field to keep track of the last time we threw away our compiled code.
  • heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::allocateSlowCase): Added call to willAllocate on the allocation slow path, just like
in CopiedSpace.

  • runtime/GCActivityCallback.cpp: Added default stubs for non-CF platforms.

(JSC::DefaultGCActivityCallback::willAllocate):
(JSC):
(JSC::DefaultGCActivityCallback::didCollect):
(JSC::DefaultGCActivityCallback::didAbandonObjectGraph):

  • runtime/GCActivityCallback.h: Added new functions to make JSC's GC timer less arcane. This includes replacing

the operator () with willAllocate() and adding an explicit didCollect() to cancel the timer after a collection
occurs rather than relying on the way the timer is invoked to cancel itself. Also added a callback for
when somebody else (e.g. WebCore or the JSC API) to notify JSC that they have just abandoned an entire graph of
objects and that JSC might want to clean them up.
(JSC::GCActivityCallback::~GCActivityCallback):
(JSC::GCActivityCallback::willAllocate):
(JSC::GCActivityCallback::didCollect):
(JSC::GCActivityCallback::didAbandonObjectGraph):
(JSC::GCActivityCallback::synchronize):
(DefaultGCActivityCallback):

  • runtime/GCActivityCallbackCF.cpp: Re-wired all the run loop stuff to implement the aforementioned functions.

We added a flag to check whether the timer was active because the call to CFRunLoopTimerSetNextFireDate actually
turned out to be quite expensive (although Instruments couldn't tell us this).
(DefaultGCActivityCallbackPlatformData):
(JSC):
(JSC::DefaultGCActivityCallbackPlatformData::timerDidFire):
(JSC::DefaultGCActivityCallback::commonConstructor):
(JSC::scheduleTimer):
(JSC::cancelTimer):
(JSC::DefaultGCActivityCallback::willAllocate):
(JSC::DefaultGCActivityCallback::didCollect):
(JSC::DefaultGCActivityCallback::didAbandonObjectGraph):

09:18 Changeset [114510] by mrobinson@webkit.org

Merging r110307

09:17 Changeset [114509] by simon.fraser@apple.com

ASSERT when a layer with a foreground layer is in 'paint into ancestor' mode
https://bugs.webkit.org/show_bug.cgi?id=84221

Source/WebCore:

Reviewed by Dean Jackson.

When a RenderLayerBacking doesn't require its own backing store, and is
in "paintIntoCompositingAncestor" mode, we would assert when trying to
paint its m_foregroundLayer if it had one (because of a negative z-index child).

The fix is to set the 'drawsContent' state on the m_foregroundLayer
as well as m_graphicsLayer.

Test: compositing/backing/no-backing-foreground-layer.html

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateDrawsContent):

LayoutTests:

Reviewed by Dean Jackson.

New testcase.

  • compositing/backing/no-backing-foreground-layer-expected.txt: Added.
  • compositing/backing/no-backing-foreground-layer.html: Added.
09:14 Changeset [114508] by commit-queue@webkit.org

[CMake] Use jsc target instead of ONLY_BUILD_JAVASCRIPTCORE
https://bugs.webkit.org/show_bug.cgi?id=84229

CMake caches ONLY_BUILD_JAVASCRIPTCORE=1 and will reuse the setting for
subsequent builds, stopping WebCore from being built ever again.

Instead of trying to emulate a build target using command line options,
just build the existing jsc target directly.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-18
Reviewed by Rob Buis.

.:

  • CMakeLists.txt:

Tools:

  • Scripts/build-jsc:
08:45 Changeset [114507] by kareng@chromium.org

Merge 114487 - Skia OOM error when upscaling small subsets of images by large quantities
https://bugs.webkit.org/show_bug.cgi?id=84225

Patch by Rachel Blum <groby@chromium.org> on 2012-04-17
Reviewed by David Levin.

Tested with manual tests.

  • platform/graphics/skia/NativeImageSkia.cpp:

(WebCore::NativeImageSkia::shouldCacheResampling):

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10035027

08:44 Changeset [114506] by commit-queue@webkit.org

[GTK] r114021 triggered media flakyness
https://bugs.webkit.org/show_bug.cgi?id=83874

Patch by Simon Pena <spena@igalia.com> on 2012-04-18
Reviewed by Philippe Normand.

Source/WebKit/gtk:

When the MediaPlaybackRequiresUserGesture setting was added, no gtk
API was implemented to access it.

This adds a property to gtk WebKit WebSettings, and connects it to
WebKit WebView, thus allowing clients to programmatically modify it.

  • webkit/webkitwebsettings.cpp:

(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):

  • webkit/webkitwebsettingsprivate.h:
  • webkit/webkitwebview.cpp:

(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):

Tools:

Now that there is gtk API to update the
MediaPlaybackRequiresUserGesture property, set it to false from the
DumpRenderTree tool when resetting defaults to consistent values.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

LayoutTests:

media/video-load-require-user-gesture.html and
media/video-play-require-user-gesture.html where enabling
MediaPlaybackRequiresUserGesture when run, so tests running
concurrently would fail -they would pass when run independently.

Since new API is added to ensure DumpRenderTree is able to reset
that setting, having media/video-load-require-user-gesture.html and
media/video-play-require-user-gesture.html no longer causes
flakiness.

  • platform/gtk/test_expectations.txt: Unskip

media/video-load-require-user-gesture.html and
media/video-play-require-user-gesture.html

08:09 Changeset [114505] by vsevik@chromium.org

Merge 114382 - Web Inspector: Suggest box appears after the command was executed in console sometimes.
https://bugs.webkit.org/show_bug.cgi?id=84148

Reviewed by Pavel Feldman.

TextPrompt.complete() requests completions asynchronously, this change adds a flag
that informs TextPrompt._completionsReady() whether completions should still be shown.

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.clearAutoComplete):
(WebInspector.TextPrompt.prototype.complete):
(WebInspector.TextPrompt.prototype._completionsReady):

TBR=vsevik@chromium.org
BUG=123826
Review URL: https://chromiumcodereview.appspot.com/10116026

07:59 Changeset [114504] by yurys@chromium.org

Web Inspector: DataGrid should use explicit root node
https://bugs.webkit.org/show_bug.cgi?id=84240

DataGrid now has an explicit root node. All children are added/removed
to that node.

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/ApplicationCacheItemsView.js:

(WebInspector.ApplicationCacheItemsView.prototype._createDataGrid):
(WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid):

  • inspector/front-end/CSSSelectorProfileView.js:

(WebInspector.CSSSelectorProfileView):
(WebInspector.CSSSelectorProfileView.prototype.rebuildGridItems):
(WebInspector.CSSSelectorProfileView.prototype.refreshData):

  • inspector/front-end/CookieItemsView.js:

(WebInspector.SimpleCookiesTable):
(WebInspector.SimpleCookiesTable.prototype.setCookies):

  • inspector/front-end/CookiesTable.js:

(WebInspector.CookiesTable):
(WebInspector.CookiesTable.prototype._rebuildTable):

  • inspector/front-end/DOMStorageItemsView.js:

(WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGrid):
(WebInspector.DataGrid.createSortableDataGrid.sortDataGrid):
(WebInspector.DataGrid.createSortableDataGrid):
(WebInspector.DataGrid.prototype.setRootNode):
(WebInspector.DataGrid.prototype.rootNode):
(WebInspector.DataGrid.prototype.autoSizeColumns):
(WebInspector.DataGrid.prototype._enumerateChildren):
(WebInspector.DataGrid.prototype._keyDown):
(WebInspector.DataGrid.prototype._contextMenuInDataTable):
(WebInspector.DataGridNode.prototype.get revealed):
(WebInspector.DataGridNode.prototype.get depth):
(WebInspector.DataGridNode.prototype.appendChild):
(WebInspector.DataGridNode.prototype.insertChild):
(WebInspector.DataGridNode.prototype.removeChild):
(WebInspector.DataGridNode.prototype.removeChildren):
(WebInspector.DataGridNode.prototype.collapse):
(WebInspector.DataGridNode.prototype.expand):
(WebInspector.DataGridNode.prototype.reveal):
(WebInspector.DataGridNode.prototype.revealAndSelect):
(WebInspector.DataGridNode.prototype.traverseNextNode):
(WebInspector.DataGridNode.prototype.traversePreviousNode):

  • inspector/front-end/HeapSnapshotDataGrids.js:

(WebInspector.HeapSnapshotSortableDataGrid):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.dispose):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.changeNameFilter):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.updateVisibleNodes):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype.sortingChanged):
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype.reset):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived.addNodeIfNonZeroDiff):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype._defaultPopulateCount.25.setDataSource):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype.sortingChanged):

  • inspector/front-end/HeapSnapshotGridNodes.js:

(WebInspector.HeapSnapshotGenericObjectNode):

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotView.prototype.performSearch):
(WebInspector.HeapSnapshotView.prototype.refreshVisibleData):

  • inspector/front-end/IndexedDBViews.js:

(WebInspector.IDBDataView.prototype._createDataGrid):
(WebInspector.IDBDataView.prototype._updateData.callback):
(WebInspector.IDBDataView.prototype._updateData):
(WebInspector.IDBDataView.prototype.clear):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._createTable):
(WebInspector.NetworkLogView.prototype.refresh):
(WebInspector.NetworkLogView.prototype._reset):

  • inspector/front-end/ProfileDataGridTree.js:

(WebInspector.ProfileDataGridNode.prototype.insertChild):
(WebInspector.ProfileDataGridNode.prototype.removeChild):
(WebInspector.ProfileDataGridNode.prototype.removeChildren):

  • inspector/front-end/ProfileView.js:

(WebInspector.CPUProfileView.prototype.refresh):

  • inspector/front-end/treeoutline.js:

LayoutTests:

  • inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest):

  • inspector/storage-panel-dom-storage.html:
07:55 Changeset [114503] by schenney@chromium.org

Layout Test svg/transforms/transform-origin-css-property.xhtml is failing
https://bugs.webkit.org/show_bug.cgi?id=84203

Unreviewed test expectation fix.

The svg/transforms/transform-origin-css-property.xhtml test has a
ref-test for it, so there should not be any image expectations. If the
test if failing, we need to look at why the ref test is not valid, or
why we differ.

The expectations file update here is just some cleanup for
https://bugs.webkit.org/show_bug.cgi?id=84230.

  • platform/chromium-mac/svg/transforms/transform-origin-css-property-expected.png: Removed.
  • platform/chromium-win/svg/transforms/transform-origin-css-property-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
06:55 Changeset [114502] by commit-queue@webkit.org

Add PassThis=* to support the callbacks which requires to pass "this" value.
https://bugs.webkit.org/show_bug.cgi?id=84232

Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-04-18
Reviewed by Kentaro Hara.

Adding PassThisToCallback=XXX to attributes will be useful for the callbacks which requires to pass "this".
This will help to identify the type(XXX) of "this" value in codegenerator.

Tests: bindings/scripts/test/TestCallback.idl

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateCallbackImplementation): Modified codegenerator to support [PassThisToCallback]

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateCallbackImplementation): Ditto.

  • bindings/scripts/IDLAttributes.txt: Added PassThisToCallback=*
  • bindings/scripts/test/CPP/WebDOMTestCallback.cpp: Modofied results from run-bindings-tests.

(WebDOMTestCallback::callbackWithBoolean):
(WebDOMTestCallback::callbackRequiresThisToPass):

  • bindings/scripts/test/CPP/WebDOMTestCallback.h: Ditto.

(WebDOMTestCallback):

  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp: Ditto.

(webkit_dom_test_callback_callback_with_boolean):
(webkit_dom_test_callback_callback_requires_this_to_pass):

  • bindings/scripts/test/GObject/WebKitDOMTestCallback.h: Ditto.
  • bindings/scripts/test/JS/JSTestCallback.cpp: Ditto.

(WebCore::JSTestCallback::callbackWithBoolean):
(WebCore):
(WebCore::JSTestCallback::callbackRequiresThisToPass):

  • bindings/scripts/test/JS/JSTestCallback.h: Ditto.

(JSTestCallback):

  • bindings/scripts/test/ObjC/DOMTestCallback.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestCallback.mm: Ditto.

(-[DOMTestCallback callbackWithBoolean:]):
(-[DOMTestCallback callbackRequiresThisToPass:thisClassParam:]):

  • bindings/scripts/test/TestCallback.idl: Added test to verify generated code.
  • bindings/scripts/test/V8/V8TestCallback.cpp: Ditto.

(WebCore::V8TestCallback::callbackWithBoolean):
(WebCore):
(WebCore::V8TestCallback::callbackRequiresThisToPass):

  • bindings/scripts/test/V8/V8TestCallback.h: Ditto.

(V8TestCallback):

06:52 Changeset [114501] by pfeldman@chromium.org

Not reviewed: fixing Chromium win compilation.

  • bindings/v8/V8IsolatedContext.cpp:
06:02 Changeset [114500] by macpherson@chromium.org

Remove unnecessary variable reassignment in CSSParser::parseImageSet().
https://bugs.webkit.org/show_bug.cgi?id=84204

Reviewed by Kentaro Hara.

Code calls next and then current instead of reusing the result of next.

No new tests / no functionality changed.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseImageSet):

05:26 Changeset [114499] by commit-queue@webkit.org

Web Inspector: Disabling Inspector causes build failure on Windows
https://bugs.webkit.org/show_bug.cgi?id=83557

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-04-18
Reviewed by Pavel Feldman.

The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
This change brings all such API calls under the guard.

Source/WebKit/win:

  • WebCoreSupport/WebInspectorClient.cpp:
  • WebInspector.cpp:
  • WebNodeHighlight.cpp:

(WebNodeHighlight::WebNodeHighlight):
(WebNodeHighlight::update):

  • WebNodeHighlight.h:

(WebNodeHighlight):

  • WebView.cpp:

(WebView::WebView):
(WebView::close):
(WebView::initWithFrame):
(WebView::inspector):

  • WebView.h:

(WebView):

Tools:

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::showWebInspector):
(WTR::LayoutTestController::closeWebInspector):
(WTR::LayoutTestController::evaluateInWebInspector):
(WTR::LayoutTestController::setJavaScriptProfilingEnabled):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::invoke):

03:56 Changeset [114498] by commit-queue@webkit.org

[BlackBerry] HTTP GET header has a "Cookie" when refreshing a page after cookies have been cleared.
https://bugs.webkit.org/show_bug.cgi?id=84223

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-18
Reviewed by George Staikos.

.:

  • ManualTests/blackberry/clear-cookie-refresh-result.php: Added.
  • ManualTests/blackberry/clear-cookie-refresh.php: Added.

Source/WebCore:

Webkit uses the old ResourceRequest when refreshing. Its cookies' header isn't removed after clicking
"clear cookies" button. We need to set cookies for this request again.

We must click "clear button" to test, so have to write a manual test case.

Test: ManualTests/blackberry/clear-cookie-refresh.php

  • platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::ResourceRequest::initializePlatformRequest):

03:09 Changeset [114497] by pfeldman@chromium.org

Web Inspector: [Chromium] Module's require injects scripts before the debug id is set to the context.
https://bugs.webkit.org/show_bug.cgi?id=84166

Reviewed by Yury Semikhatsky.

V8IsolatedContext was getting debug id assigned post-construction. At the same time, it was compiling all
its module scripts within the constructor. As a result, scripts ended up in the main world's list.

  • bindings/v8/V8IsolatedContext.cpp:

(WebCore::setInjectedScriptContextDebugId):
(WebCore):
(WebCore::V8IsolatedContext::V8IsolatedContext):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::evaluateInIsolatedWorld):

  • bindings/v8/V8Proxy.h:

(V8Proxy):

03:04 Changeset [114496] by commit-queue@webkit.org

[Qt][WK2] Minibrowser asserts on startup at QtViewportInteractionEngine::ensureContentWithinViewportBoundary()
https://bugs.webkit.org/show_bug.cgi?id=84172

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-18
Reviewed by Simon Hausmann.

After the viewport computing refactor, ensureContentWithinViewportBoundary() can be called
with resumed page. QtViewportInteractionEngine::ensureContentWithinViewportBoundary()
functionality does not necessarily require the page to be suspended. It's the caller's context
that determines whether the page needs to be suspended, so it's the caller's responsibility
to enforce the ASSERT().
Remove the invalid ASSERT on m_suspendCount at QtViewportInteractionEngine::ensureContentWithinViewportBoundary()

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):

02:29 SelectiveTestEWS edited by ossy@webkit.org
(diff)
01:53 Changeset [114495] by toyoshim@chromium.org

Unreviewed, update expectations
https://bugs.webkit.org/show_bug.cgi?id=84230

  • platform/chromium/test_expectations.txt:
01:49 Changeset [114494] by pfeldman@chromium.org

Web Inspector: document.open removes the documentElement, but does not clear the elements panel.
https://bugs.webkit.org/show_bug.cgi?id=84179

Reviewed by Yury Semikhatsky.

Source/WebCore:

Perform total update upon modifications of the document node.

Test: inspector/elements/delete-from-document.html

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::didRemoveDOMNode):

  • inspector/front-end/ElementsTreeOutline.js:

LayoutTests:

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.dumpElementsTree.print):
(initialize_ElementTest.InspectorTest.dumpElementsTree):

  • inspector/elements/delete-from-document-expected.txt: Added.
  • inspector/elements/delete-from-document.html: Added.
01:40 Changeset [114493] by commit-queue@webkit.org

Source/WebCore: [BlackBerry] Tab awareness for HTML5 concurrent audio
https://bugs.webkit.org/show_bug.cgi?id=82930
Support for concurrent HTML5 audio improvements being made in
the platform library, which need to be aware of tabs and tab
visibility. PR96004.

Patch by Max Feil <mfeil@rim.com> on 2012-04-18
Reviewed by George Staikos.

Test: media/audio-concurrent-supported.html

  • platform/blackberry/PageClientBlackBerry.h:
  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::showErrorDialog):
(WebCore::MediaPlayerPrivate::isTabVisible):
(WebCore):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:

(MediaPlayerPrivate):

Source/WebKit/blackberry: [BlackBerry] Tab awareness for HTML5 concurrent audio
https://bugs.webkit.org/show_bug.cgi?id=82930
Support for concurrent HTML5 audio improvements being made in
the platform library, which need to be aware of tabs and tab
visibility. PR96004.

Patch by Max Feil <mfeil@rim.com> on 2012-04-18
Reviewed by George Staikos.

  • Api/WebPageClient.h:
  • Api/WebPage_p.h:

(BlackBerry::WebKit::WebPagePrivate::isVisible):

LayoutTests: [BlackBerry] Tab awareness for HTML5 concurrent audio
https://bugs.webkit.org/show_bug.cgi?id=82930
Layout test for concurrent HTML5 audio. This is a simple test
to confirm that multiple audio elements can play at the same time.

Patch by Max Feil <mfeil@rim.com> on 2012-04-18
Reviewed by George Staikos.

  • media/audio-concurrent-supported-expected.txt: Added.
  • media/audio-concurrent-supported.html: Added.
01:17 Changeset [114492] by kkristof@inf.u-szeged.hu

[Qt] Unreviewed gardening, skipping test that uses disabled feature SHADOW_DOM

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-04-18

  • platform/qt/Skipped: fast/dom/shadow/adopt-node-with-shadow-root.html
01:05 Changeset [114491] by noel.gordon@gmail.com

[CG] ImageBuffer: check getPremultipliedImageData() error return
https://bugs.webkit.org/show_bug.cgi?id=84022

Reviewed by Eric Seidel.

ImageBuffer::getPremultipliedImageData() can fail. toDataURL() should check for a
failure return, and return "data:," if so.

No new tests. Covered by existing toDataURL tests, in particular:

canvas/philip/tests/toDataURL.jpeg.alpha.html

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::toDataURL): Rename |arr| variable to premultipliedData and
return "data:," if premultipliedData is empty. Clean up whitespace and a comment.

00:37 Changeset [114490] by mario@webkit.org

[GTK] atk/textChangedNotifications API test fails
https://bugs.webkit.org/show_bug.cgi?id=84010

Unreviewed, unskipping test after bug being fixed by r114311.

  • Scripts/run-gtk-tests:

(TestRunner): Unskip now passing test.

00:35 Changeset [114489] by mikelawther@chromium.org

Merge 114487 - Skia OOM error when upscaling small subsets of images by large quantities
https://bugs.webkit.org/show_bug.cgi?id=84225

Patch by Rachel Blum <groby@chromium.org> on 2012-04-17
Reviewed by David Levin.

Tested with manual tests.

  • platform/graphics/skia/NativeImageSkia.cpp:

(WebCore::NativeImageSkia::shouldCacheResampling):

TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10083037

Note: See TracTimeline for information about the timeline view.