Timeline
Apr 24, 2012:
- 11:52 PM Changeset in webkit [115168] by
-
- 18 edits in trunk/LayoutTests
Unreviewed, GTK svg rebaseline after r115085.
- platform/gtk/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
- platform/gtk/svg/carto.net/button-expected.txt:
- platform/gtk/svg/carto.net/colourpicker-expected.txt:
- platform/gtk/svg/carto.net/slider-expected.txt:
- platform/gtk/svg/carto.net/window-expected.txt:
- platform/gtk/svg/custom/embedding-external-svgs-expected.txt:
- platform/gtk/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
- platform/gtk/svg/custom/relative-sized-use-on-symbol-expected.txt:
- platform/gtk/svg/custom/use-clipped-hit-expected.txt:
- platform/gtk/svg/custom/use-modify-target-symbol-expected.txt:
- platform/gtk/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
- platform/gtk/svg/custom/use-on-g-containing-symbol-expected.txt:
- platform/gtk/svg/custom/use-on-symbol-expected.txt:
- platform/gtk/svg/custom/use-recalcStyle-crash-expected.txt:
- platform/gtk/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
- platform/gtk/svg/custom/use-setAttribute-crash-expected.txt:
- platform/gtk/svg/custom/use-symbol-overflow-expected.txt:
- 11:37 PM Changeset in webkit [115167] by
-
- 2 edits in trunk/Source/WebCore
2012-04-24 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Revert part of the change r115063 which commented out
real worker creation. It was commited by mistake.
- inspector/front-end/HeapSnapshotProxy.js: (WebInspector.HeapSnapshotWorker):
- 10:52 PM Changeset in webkit [115166] by
-
- 3 edits in trunk/Source/WebCore
New Notification constructor do not take into account security origin permissions
https://bugs.webkit.org/show_bug.cgi?id=84825
<rdar://problem/11315405>
Reviewed by Darin Adler.
Tests requires support for notifications on Mac (see 79492).
When the task timer fires, we should check to see that the notification has permission
to show. If not, we fire the onError event.
- notifications/Notification.cpp:
(WebCore::Notification::Notification): Since the timer may show, or call the onerror event,
we rename it from m_showTaskTimer. to m_taskTimer.
(WebCore::Notification::dispatchErrorEvent): The default constructor of ErrorEvent doesn't
create the proper event object. Create it using Event::create().
(WebCore::Notification::taskTimerFired): Check to see that we have permission first.
- notifications/Notification.h:
(Notification):
- 9:30 PM Changeset in webkit [115165] by
-
- 12 edits in trunk/Source/WebCore
Add a logging channel and some ouput for compositing
https://bugs.webkit.org/show_bug.cgi?id=84817
Reviewed by Darin Adler.
Add a logging channel called "Compositing".
Output useful information to this channel, including
a line for each composited layer, its composited bounds,
the reason it was composited, the backing store megapixels,
and a count of total composited layers and total backing
store megapixels.
- platform/Logging.cpp:
(WebCore):
(WebCore::getChannelFromName):
- platform/Logging.h:
(WebCore):
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::backingStoreArea):
- platform/graphics/GraphicsLayer.h:
(GraphicsLayer):
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::backingStoreArea):
(WebCore):
- platform/graphics/ca/GraphicsLayerCA.h:
(GraphicsLayerCA):
- platform/mac/LoggingMac.mm:
(WebCore::initializeLoggingChannelsIfNecessary):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::nameForLayer):
(WebCore::RenderLayerBacking::backingStoreArea):
(WebCore):
- rendering/RenderLayerBacking.h:
(RenderLayerBacking):
- rendering/RenderLayerCompositor.cpp:
(WebCore):
(WebCore::compositingLogEnabled):
(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::logCompositingInfo):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
(WebCore::RenderLayerCompositor::updateLayerTreeGeometry):
(WebCore::RenderLayerCompositor::reasonForCompositing):
- rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
- 8:25 PM Changeset in webkit [115164] by
-
- 4 edits2 adds in trunk
getMatchedCSSRules() should return null when the second argument is an unrecognized pseudo-element name
https://bugs.webkit.org/show_bug.cgi?id=83298
Patch by Kulanthaivel Palanichamy <kulanthaivel@codeaurora.org> on 2012-04-24
Reviewed by Ojan Vafai.
Source/WebCore:
I couldn't find any specification or any meaningful discussion on this API, but I
assume that it shouldn't be any different from window.getComputedStyle()
as far as the parameters are concerned.
Test: fast/dom/Window/getMatchedCSSRules-with-invalid-pseudo-elements.html
- page/DOMWindow.cpp:
(WebCore::DOMWindow::getMatchedCSSRules):
- page/DOMWindow.idl:
LayoutTests:
- fast/dom/Window/getMatchedCSSRules-with-invalid-pseudo-elements-expected.txt: Added.
- fast/dom/Window/getMatchedCSSRules-with-invalid-pseudo-elements.html: Added.
- 8:02 PM Changeset in webkit [115163] by
-
- 8 edits in trunk/Source/WebCore
overflow: hidden on the main frame is broken with threaded scrolling
https://bugs.webkit.org/show_bug.cgi?id=84819
<rdar://problem/10920677>
Reviewed by Darin Adler.
Pass along the horizontal and vertical scrollbar modes to the scrolling tree and use it
to determine if wheel events should be handled or not. This matches what we do for non-threaded scrolling.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::ScrollingCoordinator::setScrollParameters):
- page/scrolling/ScrollingCoordinator.h:
(ScrollParameters):
- page/scrolling/ScrollingTreeNode.cpp:
(WebCore::ScrollingTreeNode::ScrollingTreeNode):
(WebCore::ScrollingTreeNode::update):
- page/scrolling/ScrollingTreeNode.h:
(WebCore::ScrollingTreeNode::canHaveScrollbars):
(ScrollingTreeNode):
- page/scrolling/ScrollingTreeState.cpp:
(WebCore::ScrollingTreeState::ScrollingTreeState):
(WebCore::ScrollingTreeState::setHorizontalScrollbarMode):
(WebCore):
(WebCore::ScrollingTreeState::setVerticalScrollbarMode):
- page/scrolling/ScrollingTreeState.h:
(WebCore::ScrollingTreeState::horizontalScrollbarMode):
(ScrollingTreeState):
(WebCore::ScrollingTreeState::verticalScrollbarMode):
- page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::handleWheelEvent):
- 7:58 PM Changeset in webkit [115162] by
-
- 3 edits in trunk/Source/WebCore
[chromium] Don't call calculateRenderPasses in CCLayerTreeHostImpl::scrollBegin()
https://bugs.webkit.org/show_bug.cgi?id=84807
Reviewed by James Robinson.
Instead of calculate render passes and quads and tracking damage,
simply calculate the updated render layer list, which is what is
needed for scrolling. This prevents a willDraw/didDraw mismatch on
layers.
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
(WebCore):
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::ensureMostRecentRenderSurfaceLayerList):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
- 7:46 PM Changeset in webkit [115161] by
-
- 5 edits in trunk/Source
[chromium] Unbounded draws should use clip to limit their damage to opaque tracking
https://bugs.webkit.org/show_bug.cgi?id=84494
Reviewed by Adrienne Walker.
Source/WebCore:
Unit test: PlatformContextSkiaTest.UnboundedDrawsAreClipped
- platform/graphics/skia/OpaqueRegionSkia.cpp:
(WebCore::OpaqueRegionSkia::didDrawRect):
(WebCore::OpaqueRegionSkia::didDrawPath):
(WebCore::OpaqueRegionSkia::didDrawPoints):
(WebCore::OpaqueRegionSkia::didDrawBounded):
(WebCore::OpaqueRegionSkia::didDrawUnbounded):
- platform/graphics/skia/OpaqueRegionSkia.h:
(OpaqueRegionSkia):
Source/WebKit/chromium:
- tests/PlatformContextSkiaTest.cpp:
(WebCore::TEST):
(WebCore):
- 7:11 PM Changeset in webkit [115160] by
-
- 5 edits6 adds in trunk
Implement createTBody for table element.
https://bugs.webkit.org/show_bug.cgi?id=84465
Reviewed by Ojan Vafai.
Source/WebCore:
Implement createTBody of table element to allow creating tbodies from JS.
It's following the specification http://dev.w3.org/html5/spec/the-table-element.html#dom-table-createtbody.
Tests: fast/table/table-create-tbody-existing-tbody.html
fast/table/table-create-tbody-multiple-tbody.html
fast/table/table-create-tbody.html
- html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::createTBody):
(WebCore):
- html/HTMLTableElement.h:
(HTMLTableElement):
- html/HTMLTableElement.idl:
LayoutTests:
Add test to cover the new createTBody method.
- fast/table/table-create-tbody-existing-tbody-expected.txt: Added.
- fast/table/table-create-tbody-existing-tbody.html: Added.
- fast/table/table-create-tbody-expected.txt: Added.
- fast/table/table-create-tbody-multiple-tbody-expected.txt: Added.
- fast/table/table-create-tbody-multiple-tbody.html: Added.
- fast/table/table-create-tbody.html: Added.
- 7:07 PM Changeset in webkit [115159] by
-
- 5 edits in trunk/Source/WebCore
ScrollingCoordinator::setScrollParameters should take a single struct
https://bugs.webkit.org/show_bug.cgi?id=84816
Reviewed by Andreas Kling.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::ScrollingCoordinator::setScrollParameters):
- page/scrolling/ScrollingCoordinator.h:
(ScrollingCoordinator):
(ScrollParameters):
- page/scrolling/ScrollingCoordinatorNone.cpp:
(WebCore::ScrollingCoordinator::setScrollParameters):
- page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::ScrollingCoordinator::setScrollParameters):
- 7:05 PM Changeset in webkit [115158] by
-
- 3 edits in trunk/Source/WebCore
Remove unused undefined() method from ScriptValue
https://bugs.webkit.org/show_bug.cgi?id=84751
Reviewed by Kentaro Hara.
- bindings/js/ScriptValue.h:
(ScriptValue):
- bindings/v8/ScriptValue.h:
(ScriptValue):
- 6:59 PM Changeset in webkit [115157] by
-
- 3 edits2 adds in trunk
ASSERT failure in RenderLayer::computeRepaintRects
https://bugs.webkit.org/show_bug.cgi?id=84480
Patch by Yong Li <yoli@rim.com> on 2012-04-24
Reviewed by Simon Fraser.
Source/WebCore:
Update visibility status if necessary before updating
compositing state in RenderLayer::styleChanged().
No new tests because this is obviously right thing to do
and creating new test seems too much for this small change.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::styleChanged):
LayoutTests:
Add a layout test for it.
- compositing/visibility/compositing-and-visibility-turned-off-together-expected.txt: Added.
- compositing/visibility/compositing-and-visibility-turned-off-together.html: Added.
- 6:29 PM Changeset in webkit [115156] by
-
- 9 edits in trunk/Source/JavaScriptCore
GC Activity Callback timer should be based on how much has been allocated since the last collection
https://bugs.webkit.org/show_bug.cgi?id=84763
Reviewed by Geoffrey Garen.
The desired behavior for the GC timer is to collect at some point in the future,
regardless of how little we've allocated. A secondary goal, which is almost if not
as important, is for the timer to collect sooner if there is the potential to
collect a greater amount of memory. Conversely, as we allocate more memory we'd
like to reduce the delay to the next collection. If we're allocating quickly enough,
the timer should be preempted in favor of a normal allocation-triggered collection.
If allocation were to slow or stop, we'd like the timer to be able to opportunistically
run a collection without us having to allocate to the hard limit set by the Heap.
This type of policy can be described in terms of the amount of CPU we are willing
to dedicate to reclaim a single MB of memory. For example, we might be willing to
dedicate 1% of our CPU to reclaim 1 MB. We base our CPU usage off of the length of
the last collection, e.g. if our last collection took 1ms, we would want to wait about
100ms before running another collection to reclaim 1 MB. These constants should be
tune-able, e.g. 0.1% CPU = 1 MB vs. 1% CPU = 1 MB vs. 10% CPU = 1 MB.
- API/JSBase.cpp: Use the new reportAbandonedObjectGraph.
(JSGarbageCollect):
- API/JSContextRef.cpp: Ditto.
- heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::reportAbandonedObjectGraph): Similar to reportExtraMemoryCost. Clients call
this function to notify the Heap that some unknown number of JSC objects might have just
been abandoned and are now garbage. The Heap might schedule a new collection timer based
on this notification.
(JSC):
(JSC::Heap::collect): Renamed m_lastFullGCSize to the less confusing m_sizeAfterLastCollect.
- heap/Heap.h:
(Heap):
- heap/MarkedAllocator.h:
(JSC::MarkedAllocator::zapFreeList): Fixed a bug in zapFreeList that failed to nullify the
current allocator's FreeList once zapping was complete.
- runtime/GCActivityCallback.cpp: Removed didAbandonObjectGraph because it was replaced by
Heap::reportAbandonedObjectGraph.
(JSC):
- runtime/GCActivityCallback.h:
(JSC::GCActivityCallback::willCollect):
(DefaultGCActivityCallback):
- runtime/GCActivityCallbackCF.cpp: Refactored the GC timer code so that we now schedule the
timer based on how much we have allocated since the last collection up to a certain amount.
We use the length of the previous GC to try to keep our total cost of opportunistic timer-triggered
collections around 1% of the CPU per MB of garbage we expect to reclaim up to a maximum of 5 MB.
(DefaultGCActivityCallbackPlatformData):
(JSC):
(JSC::DefaultGCActivityCallback::~DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::commonConstructor):
(JSC::scheduleTimer):
(JSC::cancelTimer):
(JSC::DefaultGCActivityCallback::didAllocate):
- 6:17 PM Changeset in webkit [115155] by
-
- 9 edits in trunk
Calendar Picker: Open a calendar picker by keyboard operation
https://bugs.webkit.org/show_bug.cgi?id=84680
Reviewed by Kentaro Hara.
Source/WebCore:
- Open a calendar picker by the down arrow key.
- Remove stepping down/up by keyboard and wheel operations. This behavior was for text fields with spin buttons. Because the date
type doesn't have spin buttons, we should remove this behavior.
No new tests for opening a calendar picker. This behavior is not
testable by DRT yet. For removal of stepping up/down,
fast/forms/date/date-stepup-stepdown-from-renderer.html is updated.
- html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::handleKeydownEvent):
Check shouldHaveSpinButton() before spin button key operations.
(WebCore::BaseDateAndTimeInputType::handleWheelEvent):
Check shouldHaveSpinButton() before spin button wheel operations.
- html/BaseDateAndTimeInputType.h:
(BaseDateAndTimeInputType):
Make handleKeydownEvent() protected because a subclass overrides it.
- html/DateInputType.cpp:
(WebCore::DateInputType::handleKeydownEvent):
Open a calendar picker by the down arrow key.
- html/DateInputType.h:
(DateInputType): Add handleKeydownEvent() declaration.
- html/shadow/CalendarPickerElement.h:
(CalendarPickerElement): Make openPopup() public because DateInputType calls it.
LayoutTests:
- fast/forms/date/date-stepup-stepdown-from-renderer-expected.txt:
- fast/forms/date/date-stepup-stepdown-from-renderer.html:
Stepping up/down by kerboard was removed. Update the test to confirm it doesn't work.
- 6:11 PM Changeset in webkit [115154] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84813
Suppress test image mismatch due to r115123. Rebaseline is coming soon.
- platform/chromium/test_expectations.txt:
- 6:10 PM Changeset in webkit [115153] by
-
- 9 edits12 deletes in trunk/LayoutTests
[Qt] Move notification icon download out of WebCore
https://bugs.webkit.org/show_bug.cgi?id=80700
Reviewed by Jian Li.
Remove http/tests/notifications after the code the tests were testing has been removed.
- http/tests/notifications: Removed.
- http/tests/notifications/icon-does-not-exist-expected.txt: Removed.
- http/tests/notifications/icon-does-not-exist.html: Removed.
- http/tests/notifications/icon-exists-cancel-expected.txt: Removed.
- http/tests/notifications/icon-exists-cancel.html: Removed.
- http/tests/notifications/icon-exists-expected.txt: Removed.
- http/tests/notifications/icon-exists-show-alert-during-load-expected.txt: Removed.
- http/tests/notifications/icon-exists-show-alert-during-load.html: Removed.
- http/tests/notifications/icon-exists.html: Removed.
- http/tests/notifications/icon-requires-auth-expected.txt: Removed.
- http/tests/notifications/icon-requires-auth.html: Removed.
- http/tests/notifications/resources: Removed.
- http/tests/notifications/resources/icon-exists.png: Removed.
- http/tests/notifications/resources/icon-requires-auth.php: Removed.
- platform/chromium/test_expectations.txt:
- platform/efl/Skipped:
- platform/gtk/test_expectations.txt:
- platform/mac/Skipped:
- platform/qt-5.0-wk2/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- 6:02 PM Changeset in webkit [115152] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Perform spellcheck before handling TouchRelease event
https://bugs.webkit.org/show_bug.cgi?id=84744
After rebasing to master_35, it appears as though some code had been moved around.
Here, we were handling the TouchReleased event before calling spellcheck. This
meant that when we finally got the call to spellcheck, the fatFinger result had been
reset and the spelling markers had been removed.
In addition, based on https://bugs.webkit.org/show_bug.cgi?id=66330
I am also updating the BlackBerry specific documentMarkerContainingPoint to use
LayoutPoint instead of IntPoint.
Internally reviewed by Mike Fenton.
Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-04-24
Reviewed by Antonio Gomes.
- WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
(BlackBerry::WebKit::TouchEventHandler::spellCheck):
- dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::markerContainingPoint):
- dom/DocumentMarkerController.h:
- 5:58 PM Changeset in webkit [115151] by
-
- 4 edits in trunk/Source/JavaScriptCore
objectProtoFuncToString creates new string every invocation
https://bugs.webkit.org/show_bug.cgi?id=84781
Reviewed by Geoffrey Garen.
Cache the results of object toString() in the attached Structure.
- runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncToString):
- runtime/Structure.cpp:
(JSC::Structure::visitChildren): visit new m_hasObjectToStringValue.
- runtime/Structure.h: Added new member m_hasObjectToStringValue
(JSC):
(JSC::Structure::objectToStringValue):
(Structure):
(JSC::Structure::setObjectToStringValue):
- 5:49 PM Changeset in webkit [115150] by
-
- 3 edits in trunk/LayoutTests
Unreviewed rebaseline after r115134.
- platform/qt/fast/block/positioning/016-expected.txt:
- platform/qt/fast/block/positioning/025-expected.txt:
- 5:47 PM Changeset in webkit [115149] by
-
- 13 edits in trunk/Source/WebCore
Unreviewed, rolling out r115099, r115102, and r115127.
http://trac.webkit.org/changeset/115099
http://trac.webkit.org/changeset/115102
http://trac.webkit.org/changeset/115127
https://bugs.webkit.org/show_bug.cgi?id=84809
Made html5lib/runner.html crash, spot fix didn't help so
rolling out so original author can do over. (Requested by
kling on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-24
- dom/Element.cpp:
(WebCore::Element::parserSetAttributes):
(WebCore::Element::normalizeAttributes):
- dom/Element.h:
(Element):
- dom/ElementAttributeData.cpp:
(WebCore::AttributeVector::removeAttribute):
(WebCore):
- dom/ElementAttributeData.h:
(AttributeVector):
(WebCore::AttributeVector::AttributeVector):
(WebCore):
(WebCore::AttributeVector::getAttributeItem):
(WebCore::AttributeVector::getAttributeItemIndex):
(WebCore::AttributeVector::insertAttribute):
(WebCore::ElementAttributeData::getAttributeItem):
(WebCore::ElementAttributeData::getAttributeItemIndex):
(WebCore::ElementAttributeData::attributeVector):
(WebCore::ElementAttributeData::clonedAttributeVector):
(ElementAttributeData):
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::createHTMLElementFromSavedElement):
- html/parser/HTMLToken.h:
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processFakeStartTag):
(WebCore::HTMLTreeBuilder::attributesForIsindexInput):
- html/parser/HTMLTreeBuilder.h:
- html/parser/TextDocumentParser.cpp:
(WebCore::TextDocumentParser::insertFakePreElement):
- xml/XMLErrors.cpp:
(WebCore::createXHTMLParserErrorHeader):
(WebCore::XMLErrors::insertErrorMessageBlock):
- xml/parser/MarkupTokenBase.h:
(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):
(WebCore::AtomicMarkupTokenBase::getAttributeItem):
(WebCore::AtomicMarkupTokenBase::attributes):
(AtomicMarkupTokenBase):
(WebCore::::initializeAttributes):
- xml/parser/XMLToken.h:
(WebCore::AtomicXMLToken::AtomicXMLToken):
- 5:43 PM Changeset in webkit [115148] by
-
- 5 edits in trunk
Prevent drag and drop from setting file URLs
https://bugs.webkit.org/show_bug.cgi?id=76596
Reviewed by Enrica Casucci.
Source/WebCore:
Blacklisted file URLs from being set via dataTransfer.setData for specific types.
- platform/mac/ClipboardMac.mm:
(WebCore::ClipboardMac::setData):
LayoutTests:
Updated tests to reflect new expectations.
- http/tests/security/dataTransfer-set-data-file-url.html:
- platform/mac/editing/pasteboard/dataTransfer-set-data-file-url.html:
- 5:33 PM Changeset in webkit [115147] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84810
Mark svg/carto.net/window.svg as fail due to changes in r115085.
- platform/chromium/test_expectations.txt:
- 5:28 PM Changeset in webkit [115146] by
-
- 2 edits in trunk/Tools
nrwt: add ASAN handling to chromium crash logs
https://bugs.webkit.org/show_bug.cgi?id=84664
Reviewed by Ojan Vafai.
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort._get_crash_log):
- 5:25 PM Changeset in webkit [115145] by
-
- 13 edits in trunk/Source
REGRESSION (r109022) Safari not placing service data on pasteboard.
https://bugs.webkit.org/show_bug.cgi?id=84766
<rdar://problem/11085756>
The support for OS X services requires that the write operations to
the pasteboard occur synchronously. This behavior was changed with r109022.
This change removes the original synchronous call to the WebProcess to perform
the pasteboard write that had become asynchronous after r109022.
It implements instead a synchronous call to retrive the content to be placed
in the pasteboard.
Reviewed by Alexey Proskuryakov.
Source/WebCore:
- WebCore.exp.in:
- editing/Editor.h:
- editing/mac/EditorMac.mm:
(WebCore::Editor::writeSelectionToPasteboard):
(WebCore::Editor::stringSelectionForPasteboard): Added.
(WebCore::Editor::dataSelectionForPasteboard): Added.
- platform/Pasteboard.h:
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::getStringSelection): Added.
(WebCore::Pasteboard::getDataSelection): Added.
(WebCore::Pasteboard::writeSelectionForTypes):
(WebCore::Pasteboard::writeSelection):
Source/WebKit2:
- UIProcess/API/mac/WKView.mm:
(-[WKView writeSelectionToPasteboard:types:]): Uses new methods.
- UIProcess/WebPageProxy.h:
- UIProcess/mac/WebPageProxyMac.mm: Removed writeSelectionToPasteboard.
(WebKit::WebPageProxy::getStringSelectionForPasteboard): Added.
(WebKit::WebPageProxy::getBufferSelectionForPasteboard): Added.
- WebProcess/WebPage/WebPage.h: Added support for the new messages and
removed old message.
- WebProcess/WebPage/WebPage.messages.in: Ditto.
- WebProcess/WebPage/mac/WebPageMac.mm: Ditto.
(WebKit::WebPage::readSelectionFromPasteboard): Added.
(WebKit::WebPage::getBufferSelectionForPasteboard): Added.
- 5:12 PM Changeset in webkit [115144] by
-
- 2 edits in trunk/Source/JavaScriptCore
Patch by Thouraya ANDOLSI <thouraya.andolsi@st.com> on 2012-04-24
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=84727.
Fix build when ENABLE_JIT_CONSTANT_BLINDING enabled.
- assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::or32):
(JSC::MacroAssemblerSH4::and32):
(JSC::MacroAssemblerSH4::lshift32):
(JSC::MacroAssemblerSH4::xor32):
(JSC::MacroAssemblerSH4::branchSub32):
(JSC::MacroAssemblerSH4::urshift32):
- 5:11 PM Changeset in webkit [115143] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84806
html5lib/runner.html fails after r115099 and r115127, mark it so.
- platform/chromium/test_expectations.txt:
- 5:10 PM Changeset in webkit [115142] by
-
- 3 edits in trunk/Tools
webkit-patch rebaseline-test is retrieving stale expectations
https://bugs.webkit.org/show_bug.cgi?id=84762
Reviewed by Ojan Vafai.
webkit-patch rebaseline-expectations is fetching files directly
from the layout-test-results directory on the buildbots, rather
than fetching them from the archive. This is problematic because
we don't clobber the directory after each run and so you can end
up fetching stale failing results.
This change temporarily changes the code to fetch the zip file
instead -- making things much slower -- until I can confer w/
abarth and ojan over the best way to fix this for the long-term.
- Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineTest.init):
(RebaselineTest._zip_file_set):
(RebaselineTest):
(RebaselineTest._fetch_baseline):
(RebaselineTest._rebaseline_test):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaseline.stub_rebaseline_test_command_and_tool):
(TestRebaseline.stub_rebaseline_test_command_and_tool.FakeZipFileSet):
(TestRebaseline.stub_rebaseline_test_command_and_tool.FakeZipFileSet.read):
(TestRebaseline.test_rebaseline_updates_expectations_file_noop):
(test_rebaseline_updates_expectations_file):
(test_rebaseline_test):
(test_rebaseline_and_copy_test):
(test_rebaseline_and_copy_test_no_existing_result):
(test_rebaseline_and_copy_test_with_lion_result):
(test_rebaseline_and_copy_no_overwrite_test):
- 5:06 PM Changeset in webkit [115141] by
-
- 14 edits in trunk/Source/JavaScriptCore
Add explicit patchableBranchPtrWithPatch/patchableJump methods
https://bugs.webkit.org/show_bug.cgi?id=84498
Reviewed by Filip Pizlo.
Don't rely on inUninterruptedSequence to distinguish which jumps we need to be able to repatch.
- assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::PatchableJump::PatchableJump):
(PatchableJump):
(JSC::AbstractMacroAssembler::PatchableJump::operator Jump&):
(AbstractMacroAssembler):
(JSC::AbstractMacroAssembler::AbstractMacroAssembler):
- Added PatchableJump type, removed inUninterruptedSequence.
- assembler/LinkBuffer.h:
(LinkBuffer):
(JSC::LinkBuffer::locationOf):
- Only allow the location to be taken of patchable branches
- assembler/MacroAssembler.h:
(MacroAssembler):
(JSC::MacroAssembler::patchableBranchPtrWithPatch):
(JSC::MacroAssembler::patchableJump):
(JSC::MacroAssembler::shouldBlind):
- Added default implementation of patchableBranchPtrWithPatch, patchableJump.
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::MacroAssemblerARMv7):
(MacroAssemblerARMv7):
(JSC::MacroAssemblerARMv7::patchableBranchPtrWithPatch):
(JSC::MacroAssemblerARMv7::patchableJump):
(JSC::MacroAssemblerARMv7::jump):
(JSC::MacroAssemblerARMv7::makeBranch):
- Added ARMv7 implementation of patchableBranchPtrWithPatch, patchableJump.
- dfg/DFGCorrectableJumpPoint.h:
(DFG):
(JSC::DFG::CorrectableJumpPoint::switchToLateJump):
- Late jumps are PatchableJumps.
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::linkOSRExits):
- replace use of inUninterruptedSequence
- dfg/DFGJITCompiler.h:
(JSC::DFG::PropertyAccessRecord::PropertyAccessRecord):
(PropertyAccessRecord):
- replace use of inUninterruptedSequence
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
- replace use of inUninterruptedSequence
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
- replace use of inUninterruptedSequence
- jit/JIT.h:
(PropertyStubCompilationInfo):
- replace use of inUninterruptedSequence
- jit/JITInlineMethods.h:
(JSC::JIT::beginUninterruptedSequence):
(JSC::JIT::endUninterruptedSequence):
- replace use of inUninterruptedSequence
- jit/JITPropertyAccess.cpp:
(JSC::JIT::compileGetByIdHotPath):
- replace use of inUninterruptedSequence
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::compileGetByIdHotPath):
- replace use of inUninterruptedSequence
- 4:59 PM Changeset in webkit [115140] by
-
- 2 edits in trunk/LayoutTests
Fix layout test failures for Oscillator because WaveTable now normalizes to 0dBFS instead of -6dbFS
https://bugs.webkit.org/show_bug.cgi?id=84799
Reviewed by James Robinson.
This fixes failures caused by: http://trac.webkit.org/changeset/115111
We need to adjust the layout test itself to scale by 1/2 to compensate for the new WaveTable normalization.
The reason we don't change the audio .wav file baselines themselves is because audio values can potentially
clip past full scale, and we need to be able to avoid this "overshoot".
- webaudio/resources/oscillator-testing.js:
(generateExponentialOscillatorSweep):
- 4:58 PM Changeset in webkit [115139] by
-
- 6 edits in trunk/Source
[chromium] Image masks are considered opaque incorrectly
https://bugs.webkit.org/show_bug.cgi?id=84275
Reviewed by Adrienne Walker.
Source/WebCore:
Match the behaviour of SkCanvas layers more closely while tracking
opaque paints. SkCanvas layers actually act as a separate device
(ie. pixels) and when the layer is popped off, the pixels are copied
down to the layer below.
While we can use the total clip to decide what pixels the the
drawing operation will affect in the final device, the blending
down through layers needs to consider each layer carefully.
In this case the image mask is drawn into a layer which is copied
down using the DestinationIn operation. Since the layer contains
non-opaque pixels, the DestinationIn copy can destroy opaque
areas in the next layer. We add OpaqueRegionSkia::FillByCopy to
distinguish the case where we are copying a block of pixels, and the
alpha values are essentially unknown.
Unit test: PlatformContextSkiaTest.trackImageMask
PlatformContextSkiaTest.trackImageMaskWithOpaqueRect
- platform/graphics/skia/OpaqueRegionSkia.cpp:
(WebCore::paintIsOpaque):
(WebCore::OpaqueRegionSkia::applyOpaqueRegionFromLayer):
(WebCore::OpaqueRegionSkia::pushCanvasLayer):
(WebCore::OpaqueRegionSkia::popCanvasLayer):
(WebCore::OpaqueRegionSkia::didDrawRect):
(WebCore::OpaqueRegionSkia::didDrawPath):
(WebCore::OpaqueRegionSkia::didDrawPoints):
(WebCore::OpaqueRegionSkia::didDrawBounded):
(WebCore::OpaqueRegionSkia::didDraw):
(WebCore::OpaqueRegionSkia::didDrawUnbounded):
(WebCore::OpaqueRegionSkia::markRectAsOpaque):
(WebCore::OpaqueRegionSkia::markRectAsNonOpaque):
(WebCore::OpaqueRegionSkia::markAllAsNonOpaque):
- platform/graphics/skia/OpaqueRegionSkia.h:
(OpaqueRegionSkia):
(CanvasLayerState):
- platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::restoreLayer):
Source/WebKit/chromium:
- tests/PlatformContextSkiaTest.cpp:
(WebCore):
(WebCore::TEST):
- 4:55 PM Changeset in webkit [115138] by
-
- 6 edits15 adds in trunk
CSS Shaders: Repainting the FECustomFilter requires full source image
https://bugs.webkit.org/show_bug.cgi?id=76689
Source/WebCore:
Reviewed by Dean Jackson..
When a pixel of a filtered layer changes we need to update the whole bounding box of the layer and
not just the dirty rectangle. That's because the shader might change the color of any of the pixels inside the box.
Added tests where a shader is moving and rotating the contents and the actual
dirty box of the source image is not the same as the output dirty rectangle.
Tests: css3/filters/custom/filter-repaint-custom-clipped.html
css3/filters/custom/filter-repaint-custom-rotated.html
css3/filters/custom/filter-repaint-custom.html
- rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::FilterEffectRenderer):
(WebCore::FilterEffectRenderer::build):
(WebCore::FilterEffectRenderer::computeSourceImageRectForDirtyRect):
- rendering/FilterEffectRenderer.h:
(FilterEffectRenderer):
(WebCore::FilterEffectRenderer::hasCustomShaderFilter):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setFilterBackendNeedsRepaintingInRect):
LayoutTests:
Reviewed by Dean Jackson.
- css3/filters/custom/filter-repaint-custom-clipped-expected.png: Added.
- css3/filters/custom/filter-repaint-custom-clipped-expected.txt: Added.
- css3/filters/custom/filter-repaint-custom-clipped.html: Added.
- css3/filters/custom/filter-repaint-custom-expected.png: Added.
- css3/filters/custom/filter-repaint-custom-expected.txt: Added.
- css3/filters/custom/filter-repaint-custom-rotated-expected.png: Added.
- css3/filters/custom/filter-repaint-custom-rotated-expected.txt: Added.
- css3/filters/custom/filter-repaint-custom-rotated.html: Added.
- css3/filters/custom/filter-repaint-custom.html: Added.
- css3/filters/resources/color-add.fs: Added.
- css3/filters/resources/vertex-horizontal-offset.vs: Added.
- css3/filters/resources/vertex-rotate.vs: Added.
- platform/chromium-mac/css3/filters/custom/filter-repaint-custom-clipped-expected.png: Added.
- platform/chromium-mac/css3/filters/custom/filter-repaint-custom-expected.png: Added.
- platform/chromium-mac/css3/filters/custom/filter-repaint-custom-rotated-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 4:52 PM Changeset in webkit [115137] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84802
New test added in r115096 is failing on Chromium, mark it so.
- platform/chromium/test_expectations.txt:
- 4:51 PM Changeset in webkit [115136] by
-
- 68 edits in trunk/Source
Replace occurences of style selector from variables and methods names by style resolver.
https://bugs.webkit.org/show_bug.cgi?id=84765
Reviewed by Andreas Kling.
Rename methods and variables to follow the new name StyleResolver. It requires to update the
local variables, methods parameters, and function names to match the new name and to remove
the concept of "selector" to avoid clashing with the CSS concept. The next and last patch
will be to rename CSSStyleSelector file and update the includes.
Source/WebCore:
No new tests : just renaming the variables and method names. No behavior changes expected.
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::dispatchInvalidationCallbacks):
- css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::addStops):
- css/CSSPageRule.cpp:
(WebCore::CSSPageRule::setSelectorText):
- css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::setSelectorText):
- css/CSSStyleSheet.cpp:
(WebCore::StyleSheetInternal::styleSheetChanged):
- css/MediaQueryEvaluator.cpp:
(WebCore::MediaQueryEvaluator::eval):
- css/MediaQueryMatcher.cpp:
(WebCore::MediaQueryMatcher::prepareEvaluator):
(WebCore::MediaQueryMatcher::styleResolverChanged):
- css/MediaQueryMatcher.h:
(MediaQueryMatcher):
- css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::StyleRuleCSSStyleDeclaration::setNeedsStyleRecalc):
- css/StyleBuilder.cpp:
(WebCore::ApplyPropertyExpanding::applyInheritValue):
(WebCore::ApplyPropertyExpanding::applyInitialValue):
(WebCore::ApplyPropertyExpanding::applyValue):
(WebCore::ApplyPropertyDefaultBase::applyInheritValue):
(WebCore::ApplyPropertyDefaultBase::applyInitialValue):
(WebCore::ApplyPropertyDefault::applyValue):
(WebCore::ApplyPropertyNumber::applyValue):
(WebCore::ApplyPropertyStyleImage::applyValue):
(WebCore::ApplyPropertyAuto::applyInheritValue):
(WebCore::ApplyPropertyAuto::applyInitialValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::convertToLength):
(WebCore::ApplyPropertyClip::applyInheritValue):
(WebCore::ApplyPropertyClip::applyInitialValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyColor::applyInheritValue):
(WebCore::ApplyPropertyColor::applyInitialValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyColor::applyColorValue):
(WebCore::ApplyPropertyDirection::applyValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyFillLayer::applyInheritValue):
(WebCore::ApplyPropertyFillLayer::applyInitialValue):
(WebCore::ApplyPropertyFillLayer::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFont::applyInheritValue):
(WebCore::ApplyPropertyFont::applyInitialValue):
(WebCore::ApplyPropertyFont::applyValue):
(WebCore::ApplyPropertyFontSize::applyInheritValue):
(WebCore::ApplyPropertyFontSize::applyInitialValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyInheritValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyInitialValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyBorderImage::applyValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInheritValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInitialValue):
(WebCore::ApplyPropertyBorderImageModifier::applyValue):
(WebCore::ApplyPropertyBorderImageSource::applyValue):
(WebCore::ApplyPropertyCounter::applyInheritValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCursor::applyInheritValue):
(WebCore::ApplyPropertyCursor::applyInitialValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyUnicodeBidi::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyAnimation::map):
(WebCore::ApplyPropertyAnimation::applyInheritValue):
(WebCore::ApplyPropertyAnimation::applyInitialValue):
(WebCore::ApplyPropertyAnimation::applyValue):
(WebCore::ApplyPropertyOutlineStyle::applyInheritValue):
(WebCore::ApplyPropertyOutlineStyle::applyInitialValue):
(WebCore::ApplyPropertyOutlineStyle::applyValue):
(WebCore::ApplyPropertyResize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyAspectRatio::applyInheritValue):
(WebCore::ApplyPropertyAspectRatio::applyInitialValue):
(WebCore::ApplyPropertyAspectRatio::applyValue):
(WebCore::ApplyPropertyZoom::resetEffectiveZoom):
(WebCore::ApplyPropertyZoom::applyInheritValue):
(WebCore::ApplyPropertyZoom::applyInitialValue):
(WebCore::ApplyPropertyZoom::applyValue):
(WebCore::ApplyPropertyDisplay::isValidDisplayValue):
(WebCore::ApplyPropertyDisplay::applyInheritValue):
(WebCore::ApplyPropertyDisplay::applyInitialValue):
(WebCore::ApplyPropertyDisplay::applyValue):
(WebCore::ApplyPropertyFlex::applyInheritValue):
(WebCore::ApplyPropertyFlex::applyInitialValue):
(WebCore::ApplyPropertyFlex::applyValue):
- css/StyleBuilder.h:
(WebCore::PropertyHandler::applyInheritValue):
(WebCore::PropertyHandler::applyInitialValue):
(WebCore::PropertyHandler::applyValue):
- css/StyleMedia.cpp:
(WebCore::StyleMedia::matchMedium):
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::setDocType):
(WebCore::Document::childrenChanged):
(WebCore::Document::setContentLanguage):
(WebCore::Document::recalcStyle):
(WebCore::Document::updateLayoutIgnorePendingStylesheets):
(WebCore::Document::styleForElementIgnoringPendingStylesheets):
(WebCore::Document::styleForPage):
(WebCore::Document::combineCSSFeatureFlags):
(WebCore::Document::resetCSSFeatureFlags):
(WebCore::Document::createStyleResolver):
(WebCore::Document::clearStyleResolver):
(WebCore::Document::clearPageUserSheet):
(WebCore::Document::updatePageUserSheet):
(WebCore::Document::clearPageGroupUserSheets):
(WebCore::Document::updatePageGroupUserSheets):
(WebCore::Document::addUserSheet):
(WebCore::Document::processHttpEquiv):
(WebCore::Document::setSelectedStylesheetSet):
(WebCore::Document::removePendingSheet):
(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::styleResolverChanged):
(WebCore::Document::analyzeStylesheetChange):
(WebCore::Document::updateActiveStylesheets):
- dom/Document.h:
(WebCore::Document::styleResolverIfExists):
(WebCore::Document::styleResolver):
(Document):
- dom/Element.cpp:
(WebCore::StyleResolverParentPusher::StyleResolverParentPusher):
(WebCore::StyleResolverParentPusher::push):
(WebCore::StyleResolverParentPusher::~StyleResolverParentPusher):
(StyleResolverParentPusher):
(WebCore::Element::attributeChanged):
(WebCore::Element::attach):
(WebCore::Element::styleForRenderer):
(WebCore::Element::recalcStyle):
(WebCore::Element::beginParsingChildren):
(WebCore::Element::finishParsingChildren):
- dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::removedFrom):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::attach):
- dom/ShadowTree.cpp:
(WebCore::ShadowTree::recalcShadowTreeStyle):
- dom/StyleElement.cpp:
(WebCore::StyleElement::removedFromDocument):
- editing/EditingStyle.cpp:
(WebCore::styleFromMatchedRulesForElement):
- history/CachedPage.cpp:
(WebCore::CachedPage::restore):
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::styleResolver):
- html/HTMLCanvasElement.h:
(HTMLCanvasElement):
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::setDisabledState):
(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::removedFrom):
(WebCore::HTMLLinkElement::removePendingSheet):
- html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::registerWithScopingNode):
(WebCore::HTMLStyleElement::unregisterWithScopingNode):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setFont):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::recalcStyleForPseudoStateIfNeeded):
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::buildArrayForRuleList):
(WebCore::InspectorCSSAgent::clearPseudoState):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::updateViewMetrics):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::getMatchedCSSRules):
- page/Frame.cpp:
(WebCore::Frame::setPrinting):
- page/FrameView.cpp:
(WebCore::FrameView::layout):
- page/Page.cpp:
(WebCore::Page::setViewMode):
(WebCore::Page::setNeedsRecalcStyleInAllFrames):
(WebCore::Page::allVisitedStateChanged):
(WebCore::Page::visitedStateChanged):
- page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::KeyframeAnimation):
- platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::adjustSliderTrackStyle):
(WebCore::RenderThemeEfl::adjustSliderThumbStyle):
(WebCore::RenderThemeEfl::adjustCheckboxStyle):
(WebCore::RenderThemeEfl::adjustRadioStyle):
(WebCore::RenderThemeEfl::adjustButtonStyle):
(WebCore::RenderThemeEfl::adjustMenuListStyle):
(WebCore::RenderThemeEfl::adjustMenuListButtonStyle):
(WebCore::RenderThemeEfl::adjustTextFieldStyle):
(WebCore::RenderThemeEfl::adjustTextAreaStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldStyle):
(WebCore::RenderThemeEfl::adjustProgressBarStyle):
- platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::adjustButtonStyle):
(WebCore::RenderThemeGtk::adjustMenuListStyle):
(WebCore::RenderThemeGtk::adjustMenuListButtonStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldStyle):
(WebCore::RenderThemeGtk::adjustSliderThumbStyle):
- platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::adjustSliderThumbStyle):
(WebCore::RenderThemeQt::adjustSearchFieldStyle):
(WebCore::RenderThemeQt::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeQt::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQt::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeQt::adjustInnerSpinButtonStyle):
- platform/qt/RenderThemeQtMobile.cpp:
(WebCore::RenderThemeQtMobile::adjustButtonStyle):
(WebCore::RenderThemeQtMobile::adjustMenuListStyle):
- platform/wx/RenderThemeWx.cpp:
(WebCore::RenderThemeWx::adjustButtonStyle):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::paintItemForeground):
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::fontSelector):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::getUncachedPseudoStyle):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::styleDidChange):
(WebCore::RenderRegion::computeStyleInRegion):
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::fontSelector):
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::adjustInputFieldSpeechButtonStyle):
- rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::adjustMenuListStyle):
(WebCore::RenderThemeChromiumSkia::adjustMenuListButtonStyle):
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::adjustMenuListStyle):
(WebCore::RenderThemeMac::adjustSliderThumbStyle):
(WebCore::RenderThemeMac::adjustSearchFieldStyle):
- rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::setFontFromControlSize):
(WebCore::RenderThemeSafari::adjustButtonStyle):
(WebCore::RenderThemeSafari::adjustMenuListStyle):
(WebCore::RenderThemeSafari::adjustMenuListButtonStyle):
(WebCore::RenderThemeSafari::adjustSliderThumbStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldResultsButtonStyle):
- rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeWin::adjustMenuListStyle):
(WebCore::RenderThemeWin::adjustMenuListButtonStyle):
(WebCore::RenderThemeWin::adjustSearchFieldStyle):
(WebCore::RenderThemeWin::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeWin::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeWin::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeWin::adjustSearchFieldResultsButtonStyle):
- rendering/RenderThemeWinCE.cpp:
(WebCore::RenderThemeWinCE::adjustMenuListStyle):
(WebCore::RenderThemeWinCE::adjustSearchFieldStyle):
(WebCore::RenderThemeWinCE::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeWinCE::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeWinCE::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeWinCE::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeWinCE::adjustMenuListButtonStyle):
- rendering/style/StyleGeneratedImage.cpp:
(WebCore::StyleGeneratedImage::image):
- rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::computeNewScaledFontForStyle):
- svg/SVGElement.cpp:
(WebCore::SVGElement::customStyleForRenderer):
- svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::rebuildFontFace):
(WebCore::SVGFontFaceElement::removedFrom):
- xml/XMLTreeViewer.cpp:
(WebCore::XMLTreeViewer::transformDocumentToTreeView):
- xml/parser/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::end):
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::doEnd):
- xml/parser/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::doEnd):
- WebCore.exp.in:
Source/WebKit/chromium:
- src/AutofillPopupMenuClient.cpp:
(WebKit::AutofillPopupMenuClient::fontSelector):
(WebKit::AutofillPopupMenuClient::initialize):
- src/WebDevToolsAgentImpl.cpp:
(WebKit::DeviceMetricsSupport::autoZoomPageToFitWidth):
(WebKit::DeviceMetricsSupport::applySizeOverrideInternal):
Source/WebKit/mac:
- WebView/WebHTMLView.mm:
(-[WebHTMLView reapplyStyles]):
(-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
Source/WebKit/qt:
- Api/qwebelement.cpp:
(QWebElement::styleProperty):
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setMediaType):
- WebCoreSupport/RenderThemeQStyle.cpp:
(WebCore::RenderThemeQStyle::adjustButtonStyle):
(WebCore::RenderThemeQStyle::adjustTextAreaStyle):
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
(WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
(WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):
- 4:45 PM Changeset in webkit [115135] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] setUserViewportArguments not always respected.
https://bugs.webkit.org/show_bug.cgi?id=84738
Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-04-24
Reviewed by Antonio Gomes.
Remove the unnecessary logic in
WebPagePrivate::recomputeVirtualViewportFromViewportArguments().
Instead it is much simpler to just set the m_viewportArguments to
m_userViewportArguments on LoadCommitted. If there is a viewport
tag in the content, m_viewportArguments will be replaced with it
as usual during normal page load.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
- 4:43 PM Changeset in webkit [115134] by
-
- 3 edits1 add in trunk
Fixed background is scrolling in http://www.nieuwecode.nl/ in Qt webkit2
https://bugs.webkit.org/show_bug.cgi?id=83980
Reviewed by Simon Fraser.
.:
- ManualTests/fixed-position-no-z-index.html: Added.
Source/WebCore:
When a fixed position element does not have z-index explicitly specified, it does not create a
stacking context. This results in fixed elements scrolling with the content layer.
This patch creates a stacking context for fixed positioned elements for the Qt port, by enabling
the flag ENABLE_FIXED_POSITION_CREATES_STACKING_CONTEXT.
Added a manual test because this patch takes effect only during scrolling.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- 4:43 PM Changeset in webkit [115133] by
-
- 2 edits1 add in trunk/Tools
Improve code for embedding flakiness dashboard as an iframe
https://bugs.webkit.org/show_bug.cgi?id=84782
Reviewed by Dirk Pranke.
-Include the horizontal scrollbar height in the measured height of the page.
-Post a message everytime the height changes instead of in response to a queryContentHeight message.
This way, the embedder doesn't need to poll.
No new tests. This is hard to test because it involves postMessage and iframes.
Once we switch the dashboard tests over to qunit, we should be able to write an
asyncTest for this.
- TestResultServer/static-dashboards/flakiness_dashboard.js:
(generatePage):
(appendHTML):
(appendExpectations):
(postHeightChangedMessage):
(generatePageForIndividualTests.if):
(generatePageForIndividualTests):
- TestResultServer/static-dashboards/flakiness_dashboard_embedded.html: Added.
- 4:41 PM Changeset in webkit [115132] by
-
- 5 edits in trunk/Source
Generalize the single character optimization of r114072
https://bugs.webkit.org/show_bug.cgi?id=83961
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-24
Reviewed by Eric Seidel.
Source/JavaScriptCore:
Use the regular String::find(StringImpl*) in all cases now that it has been made faster.
- runtime/StringPrototype.cpp:
(JSC::replaceUsingStringSearch):
Source/WTF:
This patch makes some improvment over String::find() in the case of lookup for a single
character.
The two function find(UChar|LChar) are replaced by a template.
The case of searching a UChar in a 8bit string has a shortcut if the UChar cannot
possibly match any character in the range of the type LChar.
The slow case StringImpl::find(StringImpl*) is modified to
-Do not allocate in the fast case if only one string is 8bit.
-Use the shortcut for searching UChar in LChar.
This speed up the function by about 7% when avoiding string conversion.
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::find):
- wtf/text/StringImpl.h:
(StringImpl):
(WTF):
(WTF::find):
(WTF::StringImpl::find):
- 4:33 PM Changeset in webkit [115131] by
-
- 4 edits in trunk/Tools
Replace garden-o-matic accordion UI with a panel UI
https://bugs.webkit.org/show_bug.cgi?id=84081
Reviewed by Dimitri Glazkov.
This is a nicer UI to work with and makes it easier to embed the flakiness dashboard,
since we can reuse the same iframe without moving it in the DOM.
Also, excise unnecessary jquery-isms.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
- 4:16 PM Changeset in webkit [115130] by
-
- 2 edits1 add12 deletes in trunk/LayoutTests
REGRESSION (r115083-r115087): 6 tests failing on Lion Release (WebKit2 Tests)
https://bugs.webkit.org/show_bug.cgi?id=84783
Reviewed by Dirk Schulze.
Fix struct-use-09-b.svg missing test result by converting to a reftest.
- platform/chromium-linux/svg/custom/struct-use-09-b-expected.png: Removed.
- platform/chromium-mac-leopard/svg/custom/struct-use-09-b-expected.png: Removed.
- platform/chromium-mac/svg/custom/struct-use-09-b-expected.png: Removed.
- platform/chromium-mac/svg/custom/struct-use-09-b-expected.txt: Removed.
- platform/chromium-win/svg/custom/struct-use-09-b-expected.png: Removed.
- platform/chromium-win/svg/custom/struct-use-09-b-expected.txt: Removed.
- platform/gtk/svg/custom/struct-use-09-b-expected.png: Removed.
- platform/gtk/svg/custom/struct-use-09-b-expected.txt: Removed.
- platform/mac-leopard/svg/custom/struct-use-09-b-expected.png: Removed.
- platform/mac/svg/custom/struct-use-09-b-expected.png: Removed.
- platform/qt/svg/custom/struct-use-09-b-expected.png: Removed.
- platform/qt/svg/custom/struct-use-09-b-expected.txt: Removed.
- svg/custom/struct-use-09-b-expected.svg:
- svg/custom/struct-use-09-b.svg:
- 4:08 PM Changeset in webkit [115129] by
-
- 1 edit3 adds in trunk/LayoutTests
[chromium] Unreviewd test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84790
Adding expectations for new tests added in r115091.
- platform/chromium-mac/fast/css/table-rules-attribute-groups-with-frame-expected.png: Added.
- platform/chromium-mac/fast/css/table-rules-attribute-with-frame1-expected.png: Added.
- platform/chromium-mac/fast/css/table-rules-attribute-with-frame2-expected.png: Added.
- 4:00 PM Changeset in webkit [115128] by
-
- 2 edits in trunk/Source/WebKit2
Fix Windows build.
- WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.h:
(~InjectedBundleDOMWindowExtension): VS doesn't like OVERRIDE on d'tor's
- 3:55 PM Changeset in webkit [115127] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r115099): html5lib/runner.html crashes.
<http://webkit.org/b/84791>
Reviewed by Anders Carlsson.
Unbreak and simplify the code that filters attributes on isindex elements.
It's perfectly safe to remove elements from a Vector while iterating over it.
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::attributesForIsindexInput):
- 3:55 PM Changeset in webkit [115126] by
-
- 2 edits in trunk/Tools
[Chromium] DumpRenderTree should depend on base.gyp:test_support_base
https://bugs.webkit.org/show_bug.cgi?id=84729
Reviewed by Dirk Pranke.
This dependency is necessary for Android since it'll soon be
calling InitAndroidOSPathStub() in it's platform support. The
TestWebKitAPI and webkit_unit_tests already have this dependency.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- 3:50 PM Changeset in webkit [115125] by
-
- 6 edits2 adds in trunk
Extra display logic for the media control panel element
https://bugs.webkit.org/show_bug.cgi?id=82476
Patch by Victor Carbune <vcarbune@adobe.com> on 2012-04-24
Reviewed by Eric Carlson.
Source/WebCore:
This patch fixes a bug which caused the controls to be displayed
when they should remain hidden. Added an extra variable to the
panel elements which properly keeps the state of the panel (visible or not).
Test: media/video-controls-toggling.html
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::MediaControlPanelElement): Added the
variable m_isDisplayed to hold the state whether the panel is visible or not.
(WebCore::MediaControlPanelElement::makeOpaque): Showing the panel only if it
is visible.
(WebCore::MediaControlPanelElement::makeTransparent): Enabled the transition
timer which sets the display:none property on the controls.
(WebCore::MediaControlPanelElement::setIsDisplayed): Setter for the state variable.
(WebCore):
- html/shadow/MediaControlElements.h:
(MediaControlPanelElement):
- html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::show): Updated the panel visibility state.
(WebCore::MediaControlRootElement::hide): Updated the panel visibility state.
- html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlRootElementChromium::show): Updated the panel visibility state.
(WebCore::MediaControlRootElementChromium::hide): Updated the panel visibility state.
LayoutTests:
Added test to ensure that controls are not displayed when
the controls attribute is not set.
- media/video-controls-toggling-expected.txt: Added.
- media/video-controls-toggling.html: Added.
- 3:46 PM Changeset in webkit [115124] by
-
- 4 edits in trunk/Tools
Replace vague informative statement with the list of builders where the test isn't listed
https://bugs.webkit.org/show_bug.cgi?id=84779
Reviewed by Dirk Pranke.
This is more informative and more likely to be noticed. With the old UI, people never
read the line and if they did, they didn't really understand what it meant. Hopefully
have the list of builders will be more clear.
- TestResultServer/static-dashboards/flakiness_dashboard.js:
- TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
- TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
- 3:44 PM Changeset in webkit [115123] by
-
- 14 edits1 delete in trunk
CSS Shaders: Custom filters painting is broken
https://bugs.webkit.org/show_bug.cgi?id=82803
Reviewed by Kenneth Russell.
Source/WebCore:
In this patch I moved CSS Shaders file loading notifications from FilterEffectRenderer to the new RenderLayerFilterInfo.
That's because FilterEffectRenderer is only used when running the filters in the software pipeline
and has a very short lifetime. Due to a recent change FilterEffectRenderer actually
gets deleted if the shader is not loaded, so it doesn't live that much to be notified when the shader
was actually loaded.
Also removed the FilterEffectObserver, that was only used to notify the RenderLayer about the loaded shader.
No new tests. This is making existing CSS Shaders tests pass again.
Cannot un-skip on Mac for now because the feature is compile time disabled.
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/filters/CustomFilterOperation.h:
(WebCore::CustomFilterOperation::affectsOpacity):
(WebCore::CustomFilterOperation::movesPixels):
- platform/graphics/filters/FilterOperations.cpp:
(WebCore):
(WebCore::FilterOperations::hasCustomFilter):
- platform/graphics/filters/FilterOperations.h:
(FilterOperations):
- platform/graphics/texmap/TextureMapperImageBuffer.cpp:
(WebCore::BitmapTextureImageBuffer::applyFilters):
- rendering/FilterEffectObserver.h: Removed.
- rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::FilterEffectRenderer):
(WebCore::FilterEffectRenderer::~FilterEffectRenderer):
(WebCore::FilterEffectRenderer::build):
- rendering/FilterEffectRenderer.h:
(WebCore):
(WebCore::FilterEffectRenderer::create):
(FilterEffectRenderer):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateOrRemoveFilterEffect):
- rendering/RenderLayer.h:
- rendering/RenderLayerFilterInfo.cpp:
(WebCore::RenderLayerFilterInfo::~RenderLayerFilterInfo):
(WebCore::RenderLayerFilterInfo::notifyCustomFilterProgramLoaded):
(WebCore):
(WebCore::RenderLayerFilterInfo::updateCustomFilterClients):
(WebCore::RenderLayerFilterInfo::removeCustomFilterClients):
- rendering/RenderLayerFilterInfo.h:
(WebCore):
(RenderLayerFilterInfo):
LayoutTests:
- platform/chromium/test_expectations.txt: Un-skipping related tests on Chromium.
- 3:30 PM Changeset in webkit [115122] by
-
- 1 edit1 add14 deletes in trunk/LayoutTests
[SVG] convert use-css-events.svg to be a reftest
https://bugs.webkit.org/show_bug.cgi?id=84788
Reviewed by Andreas Kling.
- platform/chromium-linux/svg/custom/use-css-events-expected.png: Removed.
- platform/chromium-mac/svg/custom/use-css-events-expected.png: Removed.
- platform/chromium-mac/svg/custom/use-css-events-expected.txt: Removed.
- platform/chromium-win/svg/custom/use-css-events-expected.png: Removed.
- platform/chromium-win/svg/custom/use-css-events-expected.txt: Removed.
- platform/gtk/svg/custom/use-css-events-expected.png: Removed.
- platform/gtk/svg/custom/use-css-events-expected.txt: Removed.
- platform/mac-leopard/svg/custom/use-css-events-expected.png: Removed.
- platform/mac-snowleopard/svg/custom/use-css-events-expected.png: Removed.
- platform/mac/svg/custom/use-css-events-expected.png: Removed.
- platform/mac/svg/custom/use-css-events-expected.txt: Removed.
- platform/qt/svg/custom/use-css-events-expected.png: Removed.
- platform/qt/svg/custom/use-css-events-expected.txt: Removed.
- platform/win/svg/custom/use-css-events-expected.txt: Removed.
- svg/custom/use-css-events-expected.svg: Added.
- 3:20 PM Changeset in webkit [115121] by
-
- 1 edit in branches/subpixellayout/Source/WebCore/rendering/LayoutTypes.h
Fix clampToLayoutUnit on branch.
- 3:14 PM Changeset in webkit [115120] by
-
- 3 edits in trunk/Source/WebCore
Another build fix.
Not reviewed.
- css/MediaList.cpp:
(WebCore::MediaQuerySet::MediaQuerySet):
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::StylePropertySet):
- 3:12 PM Changeset in webkit [115119] by
-
- 4 edits in trunk/LayoutTests
REGRESSION (r115083-r115087): 6 tests failing on Lion Release (WebKit2 Tests)
https://bugs.webkit.org/show_bug.cgi?id=84783
Reviewed by Andreas Kling.
This regression was caused because the test results from an old patch were
blindly taken, rebaseline these against trunk.
- svg/custom/use-in-symbol-with-offset-expected.txt:
- svg/custom/use-transfer-width-height-properties-to-svg2-expected.txt:
- svg/custom/use-transfer-width-height-properties-to-symbol-expected.txt:
- 3:06 PM Changeset in webkit [115118] by
-
- 7 edits2 moves2 adds6 deletes in trunk/LayoutTests
[chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84785
Updating test expectation changes due to r115085.
- platform/chromium-linux-x86/svg/custom/use-setAttribute-crash-expected.txt: Removed.
- platform/chromium-linux/svg/custom/use-setAttribute-crash-expected.txt: Removed.
- platform/chromium-mac-leopard/svg/custom/use-setAttribute-crash-expected.txt: Removed.
- platform/chromium-mac-snowleopard/svg/custom/use-setAttribute-crash-expected.txt: Removed.
- platform/chromium-mac/svg/custom/struct-use-09-b-expected.txt: Added.
- platform/chromium-win-vista/svg/custom/use-setAttribute-crash-expected.txt: Removed.
- platform/chromium-win-xp/svg/custom/use-setAttribute-crash-expected.txt: Removed.
- platform/chromium-win/svg/custom/embedding-external-svgs-expected.txt:
- platform/chromium-win/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
- platform/chromium-win/svg/custom/relative-sized-use-on-symbol-expected.txt:
- platform/chromium-win/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
- platform/chromium-win/svg/custom/struct-use-09-b-expected.txt:
- platform/chromium-win/svg/custom/use-setAttribute-crash-expected.txt:
- platform/chromium/svg/custom/use-in-symbol-with-offset-expected.txt: Added.
- platform/chromium/svg/custom/use-transfer-width-height-properties-to-svg2-expected.txt: Renamed from LayoutTests/platform/qt/svg/custom/use-transfer-width-height-properties-to-svg2-expected.txt.
- platform/chromium/svg/custom/use-transfer-width-height-properties-to-symbol-expected.txt: Renamed from LayoutTests/platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol-expected.txt.
- 3:03 PM Changeset in webkit [115117] by
-
- 2 edits in trunk/Source/WebCore
Try to fix Qt build.
Not reviewed.
- css/StyleRule.h:
(WebCore::StyleRuleBase::StyleRuleBase):
- 2:58 PM Changeset in webkit [115116] by
-
- 3 edits in trunk/Source/WebKit/chromium
[Chromium] Implement WebCore::dateFormat{DayInMonth,Month,Year}Text()
https://bugs.webkit.org/show_bug.cgi?id=84683
Reviewed by Dimitri Glazkov.
- public/platform/WebLocalizedString.h:
Add DateFormat{DayInMonth,Month,Year}Label
- src/LocalizedStrings.cpp:
(WebCore::dateFormatYearText): Implemented.
(WebCore::dateFormatMonthText): ditto.
(WebCore::dateFormatDayInMonthText): ditto.
- 2:56 PM Changeset in webkit [115115] by
-
- 15 edits in trunk/Source/WebCore
Implement StyleRule copying
https://bugs.webkit.org/show_bug.cgi?id=84752
Reviewed by Andreas Kling.
We'll need this for copy-on-write when style sheet data is shared between documents.
Implement copy() and copy constructor for style rules their children as needed.
The code is not yet used.
- css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::CSSSelectorList):
(WebCore):
- css/CSSSelectorList.h:
(CSSSelectorList):
- css/MediaList.h:
(WebCore::MediaQuerySet::copy):
(MediaQuerySet):
- css/MediaQuery.cpp:
(WebCore::MediaQuery::MediaQuery):
(WebCore):
- css/MediaQuery.h:
(MediaQuery):
(WebCore::MediaQuery::copy):
- css/MediaQueryExp.h:
(WebCore::MediaQueryExp::copy):
(MediaQueryExp):
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::StylePropertySet):
(WebCore):
(WebCore::StylePropertySet::copy):
- css/StylePropertySet.h:
Make this copy parse mode too. As a result ElementAttributeData no longer needs to set it explicitly after copying.
(StylePropertySet):
- css/StyleRule.cpp:
(WebCore::StyleRuleBase::copy):
(WebCore):
(WebCore::StyleRule::StyleRule):
(WebCore::StyleRulePage::StyleRulePage):
(WebCore::StyleRuleFontFace::StyleRuleFontFace):
(WebCore::StyleRuleBlock::StyleRuleBlock):
(WebCore::StyleRuleMedia::StyleRuleMedia):
(WebCore::StyleRuleRegion::StyleRuleRegion):
- css/StyleRule.h:
(StyleRuleBase):
(WebCore::StyleRuleBase::StyleRuleBase):
(WebCore::StyleRule::copy):
(StyleRule):
(WebCore::StyleRuleFontFace::copy):
(StyleRuleFontFace):
(WebCore::StyleRulePage::copy):
(StyleRulePage):
(StyleRuleBlock):
(WebCore::StyleRuleMedia::copy):
(StyleRuleMedia):
(WebCore::StyleRuleRegion::copy):
(StyleRuleRegion):
- css/WebKitCSSKeyframesRule.cpp:
(WebCore):
(WebCore::StyleRuleKeyframes::StyleRuleKeyframes):
- css/WebKitCSSKeyframesRule.h:
(WebCore):
(WebCore::StyleRuleKeyframes::copy):
(StyleRuleKeyframes):
- 2:34 PM Changeset in webkit [115114] by
-
- 5 edits in branches/safari-534.57-branch/Source
Versioning.
- 2:33 PM Changeset in webkit [115113] by
-
- 1 copy in tags/Safari-534.57.3
New tag.
- 2:24 PM Changeset in webkit [115112] by
-
- 17 edits5 deletes in trunk
Revert r115009; It doesn't make necessary changes to NodeRareData and Node.
Source/WebCore:
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::getNamedItems):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::getNamedItems):
- html/CollectionType.h:
- html/HTMLCollection.cpp:
(WebCore::HTMLCollection::shouldIncludeChildren):
(WebCore::HTMLCollection::isAcceptableElement):
- html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::HTMLFormCollection):
- html/RadioNodeList.cpp: Removed.
- html/RadioNodeList.h: Removed.
- html/RadioNodeList.idl: Removed.
LayoutTests:
- fast/forms/form-collection-radio-node-list-expected.txt: Removed.
- fast/forms/form-collection-radio-node-list.html: Removed.
- 2:20 PM Changeset in webkit [115111] by
-
- 2 edits in trunk/Source/WebCore
WaveTable should normalize to 0dbFS instead of -6dbFS
https://bugs.webkit.org/show_bug.cgi?id=84644
Reviewed by Kenneth Russell.
No new tests. Oscillator tests will be rebaselined after landing, since several platforms are affected.
- Modules/webaudio/WaveTable.cpp:
(WebCore::WaveTable::createBandLimitedTables):
- 2:15 PM Changeset in webkit [115110] by
-
- 3 edits in trunk/LayoutTests
Unreviewed. Test expectations updates to make lint happy.
Some test files are removed or moved so update test expectations accordingly.
- platform/chromium/test_expectations.txt:
- platform/gtk/test_expectations.txt:
- 2:14 PM Changeset in webkit [115109] by
-
- 8 edits in trunk
MediaStream API: Create a new flag for PeerConnection
https://bugs.webkit.org/show_bug.cgi?id=84723
Reviewed by Dimitri Glazkov.
To allow Chrome to make the GetUserMedia functionality available by default we
need another flag for the PeerConnection related parts. This new flag is in
addition to the general media stream flag, and both need to be enabled for
PeerConnection object creation.
Source/WebCore:
No code behavior changes.
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
- bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::peerConnectionEnabled):
(WebCore::RuntimeEnabledFeatures::setPeerConnectionEnabled):
(WebCore::RuntimeEnabledFeatures::webkitDeprecatedPeerConnectionEnabled):
(WebCore::RuntimeEnabledFeatures::webkitPeerConnection00Enabled):
Source/WebKit/chromium:
- public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
- src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enablePeerConnection):
(WebKit):
(WebKit::WebRuntimeFeatures::isPeerConnectionEnabled):
Tools:
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
- 2:13 PM Changeset in webkit [115108] by
-
- 3 edits in trunk/LayoutTests
Rebaseline 2 tests after r115091
Unreviewed.
- platform/mac/accessibility/table-detection-expected.txt:
- platform/mac/accessibility/table-with-rules-expected.txt:
- 2:13 PM Changeset in webkit [115107] by
-
- 2 edits in branches/safari-534.57-branch/Source/JavaScriptCore
Merge fix for radar 11310337.
- 2:10 PM Changeset in webkit [115106] by
-
- 3 edits2 adds1 delete in trunk/LayoutTests
[chromium] Rebaseline and enable the background-blur layout tests
https://bugs.webkit.org/show_bug.cgi?id=84654
Unreviewed.
- platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.txt: Removed.
- platform/chromium-mac/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Added.
- platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png:
- platform/chromium/test_expectations.txt:
- 2:01 PM Changeset in webkit [115105] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, 32-bit build fix.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 1:52 PM Changeset in webkit [115104] by
-
- 11 edits in trunk
[BlackBerry] Revert broken changes to authentication dialog
https://bugs.webkit.org/show_bug.cgi?id=80135
Patch by Joe Mason <jmason@rim.com> on 2012-04-24
Reviewed by Antonio Gomes.
The previous patches from this bug caused an infinite loop when using digest auth;
apparently they were only tested with basic.
Source/WebCore:
- platform/blackberry/PageClientBlackBerry.h:
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::handleAuthHeader):
(WebCore::NetworkJob::sendRequestWithCredentials):
Source/WebKit/blackberry:
- Api/DumpRenderTreeClient.h:
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
- Api/WebPageClient.h:
- Api/WebPage_p.h:
(WebPagePrivate):
Tools:
- DumpRenderTree/blackberry/DumpRenderTree.cpp:
- DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
(WebCore):
- 1:43 PM Changeset in webkit [115103] by
-
- 8 edits6 adds in trunk
DFG performs incorrect DCE on (some?) intrinsics
https://bugs.webkit.org/show_bug.cgi?id=84746
<rdar://problem/11310772>
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGByteCodeParser.cpp:
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::setIntrinsicResult):
(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
LayoutTests:
Rubber stamped by Oliver Hunt.
- fast/js/dfg-dead-min-one-arg-expected.txt: Added.
- fast/js/dfg-dead-min-one-arg.html: Added.
- fast/js/dfg-dead-min-two-args-expected.txt: Added.
- fast/js/dfg-dead-min-two-args.html: Added.
- fast/js/script-tests/dfg-dead-min-one-arg.js: Added.
(foo):
(.x.f.valueOf):
- fast/js/script-tests/dfg-dead-min-two-args.js: Added.
(foo):
(bar):
(.x.f.valueOf):
(.y.f.valueOf):
- 1:35 PM WebKit Team edited by
- Move myself to reviewers. (diff)
- 1:23 PM Changeset in webkit [115102] by
-
- 2 edits in trunk/Source/WebCore
Fix wrong ASSERT() in findAttributeInVector()
https://bugs.webkit.org/show_bug.cgi?id=84756
Unreviewed build fix.
- dom/ElementAttributeData.h:
(WebCore::findAttributeInVector):
- 1:15 PM Changeset in webkit [115101] by
-
- 2 edits in trunk/Source/WebCore
Update the scroll layer position on the main thread when viewing full-frame images
https://bugs.webkit.org/show_bug.cgi?id=84754
<rdar://problem/11193304>
Reviewed by Andreas Kling.
Showing really big images can be slow sometimes and in that case it's better to update the scroll layer position on
the main thread, which will avoid flashing white.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::updateShouldUpdateScrollLayerPositionOnMainThread):
- 1:01 PM Changeset in webkit [115100] by
-
- 2 edits in trunk/LayoutTests
Rebaseline mac rendertree output for svg/custom/use-css-events.svg.
- platform/mac/svg/custom/use-css-events-expected.txt: Updated for custom ellipse renderer changes.
- 12:59 PM Changeset in webkit [115099] by
-
- 13 edits in trunk/Source/WebCore
Use Vector<Attribute> directly instead of encapsulating it in AttributeVector
https://bugs.webkit.org/show_bug.cgi?id=84413
Reviewed by Andreas Kling.
As commented in https://bugs.webkit.org/show_bug.cgi?id=79963#c16 we do not
usually subclass basic types like Vector. This patch changes code to use
Vector<Attribute> directly and move around the functionality of the former
methods to more specific helper functions or inline code at the callers.
- dom/Element.cpp:
(WebCore::Element::parserSetAttributes):
(WebCore::Element::normalizeAttributes):
- dom/Element.h:
(Element):
- dom/ElementAttributeData.cpp:
- dom/ElementAttributeData.h:
(WebCore::getAttributeFromVector):
(WebCore::ElementAttributeData::getAttributeItem):
(ElementAttributeData):
(WebCore::ElementAttributeData::attributeVector):
(WebCore::ElementAttributeData::clonedAttributeVector):
(WebCore::ElementAttributeData::getAttributeItemIndex):
(WebCore):
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::createHTMLElementFromSavedElement):
- html/parser/HTMLToken.h:
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processFakeStartTag):
(WebCore::HTMLTreeBuilder::attributesForIsindexInput):
- html/parser/HTMLTreeBuilder.h:
- html/parser/TextDocumentParser.cpp:
(WebCore::TextDocumentParser::insertFakePreElement):
- xml/XMLErrors.cpp:
(WebCore::createXHTMLParserErrorHeader):
(WebCore::XMLErrors::insertErrorMessageBlock):
- xml/parser/MarkupTokenBase.h:
(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):
(WebCore::AtomicMarkupTokenBase::getAttributeItem):
(WebCore::AtomicMarkupTokenBase::attributes):
(AtomicMarkupTokenBase):
(WebCore::::initializeAttributes):
- xml/parser/XMLToken.h:
(WebCore::AtomicXMLToken::AtomicXMLToken):
- 12:47 PM Changeset in webkit [115098] by
-
- 9 edits1 copy9 moves1 delete in trunk/LayoutTests
MediaStream API: Moving LT/fast/dom/MediaStream/* to LT/fast/mediastream
https://bugs.webkit.org/show_bug.cgi?id=82870
Reviewed by Dimitri Glazkov.
- fast/dom/MediaStream/script-tests/argument-types.js: Removed.
- fast/mediastream/argument-types-expected.txt: Renamed from LayoutTests/fast/dom/MediaStream/argument-types-expected.txt.
- fast/mediastream/argument-types.html: Renamed from LayoutTests/fast/dom/MediaStream/argument-types.html.
- fast/mediastream/enabled-expected.txt: Renamed from LayoutTests/fast/dom/MediaStream/enabled-expected.txt.
- fast/mediastream/enabled.html: Renamed from LayoutTests/fast/dom/MediaStream/enabled.html.
- fast/mediastream/no-interface-object-expected.txt: Renamed from LayoutTests/fast/dom/MediaStream/no-interface-object-expected.txt.
- fast/mediastream/no-interface-object.html: Renamed from LayoutTests/fast/dom/MediaStream/no-interface-object.html.
- fast/mediastream/peerconnection-Attributes.html:
- fast/mediastream/peerconnection-argument-types.html:
- fast/mediastream/script-tests/argument-types.js:
(test):
- fast/mediastream/script-tests/enabled.js: Renamed from LayoutTests/fast/dom/MediaStream/script-tests/enabled.js.
(hasGetUserMediaProperty):
- fast/mediastream/script-tests/no-interface-object.js: Renamed from LayoutTests/fast/dom/MediaStream/script-tests/no-interface-object.js.
(shouldThrowReferenceError):
(test):
- fast/mediastream/script-tests/peerconnection-Attributes.js: Renamed from LayoutTests/fast/mediastream/script-tests/Attributes.js.
(shouldNotThrow):
(test):
(shouldBeA):
(shouldBeTrueA):
(emptyFunction):
(ObjectThrowingException.prototype.toString):
(gotStream):
(gotStreamFailed):
- fast/mediastream/script-tests/peerconnection-argument-types.js: Copied from LayoutTests/fast/mediastream/script-tests/argument-types.js.
(shouldNotThrow):
(test):
(emptyFunction):
(ObjectThrowingException.prototype.toString):
- platform/efl/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- 12:46 PM Changeset in webkit [115097] by
-
- 73 edits in trunk/Source
Rename CSSStyleSelector class to StyleResolver.
https://bugs.webkit.org/show_bug.cgi?id=84734
Reviewed by Andreas Kling.
The name CSSStyleSelector is confusing as it conflicts a bit with
the CSS concept of selectors. One could think it's an encapsulation
of the CSS selectors but it's not, in fact this class is responsible
of finding the RenderStyle for a given element. This is the first patch
as I will later rename the files, and then rename the local variables.
Source/WebCore:
No new tests : renaming, no behavior changes should appear.
- css/CSSCalculationValue.cpp:
(WebCore::CSSCalcPrimitiveValue::toCalcValue):
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::dispatchInvalidationCallbacks):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseSizeParameter):
- css/CSSStyleSelector.cpp:
(RuleSet):
(WebCore::RuleSet::features):
(WebCore):
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::addAuthorRulesAndCollectUserRulesFromSheets):
(WebCore::makeRuleSet):
(WebCore::StyleResolver::collectFeatures):
(WebCore::StyleResolver::determineScope):
(WebCore::StyleResolver::ruleSetForScope):
(WebCore::StyleResolver::appendAuthorStylesheets):
(WebCore::StyleResolver::setupScopeStack):
(WebCore::StyleResolver::pushScope):
(WebCore::StyleResolver::popScope):
(WebCore::StyleResolver::pushParentElement):
(WebCore::StyleResolver::popParentElement):
(WebCore::StyleResolver::pushParentShadowRoot):
(WebCore::StyleResolver::popParentShadowRoot):
(WebCore::StyleResolver::addKeyframeStyle):
(WebCore::StyleResolver::~StyleResolver):
(WebCore::StyleResolver::sweepMatchedPropertiesCache):
(WebCore::StyleResolver::Features::Features):
(WebCore::StyleResolver::Features::~Features):
(WebCore::StyleResolver::Features::add):
(WebCore::StyleResolver::Features::clear):
(WebCore::StyleResolver::addMatchedProperties):
(WebCore::StyleResolver::addElementStyleProperties):
(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::collectMatchingRulesForRegion):
(WebCore::StyleResolver::sortAndTransferMatchedRules):
(WebCore::StyleResolver::matchScopedAuthorRules):
(WebCore::StyleResolver::matchAuthorRules):
(WebCore::StyleResolver::matchUserRules):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::collectMatchingRulesForList):
- css/CSSStyleSelector.h:
(StyleResolver):
(Features):
- css/MediaQueryEvaluator.cpp:
(WebCore::MediaQueryEvaluator::eval):
- css/MediaQueryEvaluator.h:
(WebCore):
(MediaQueryEvaluator):
- css/MediaQueryMatcher.cpp:
(WebCore::MediaQueryMatcher::prepareEvaluator):
- css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
- css/StyleBuilder.cpp:
(WebCore::ApplyPropertyExpanding::applyInheritValue):
(WebCore::ApplyPropertyExpanding::applyInitialValue):
(WebCore::ApplyPropertyExpanding::applyValue):
(WebCore::ApplyPropertyDefaultBase::applyInheritValue):
(WebCore::ApplyPropertyDefaultBase::applyInitialValue):
(WebCore::ApplyPropertyDefaultBase::applyValue):
(WebCore::ApplyPropertyDefault::applyValue):
(WebCore::ApplyPropertyNumber::applyValue):
(WebCore::ApplyPropertyStyleImage::applyValue):
(WebCore::ApplyPropertyAuto::applyInheritValue):
(WebCore::ApplyPropertyAuto::applyInitialValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::convertToLength):
(WebCore::ApplyPropertyClip::applyInheritValue):
(WebCore::ApplyPropertyClip::applyInitialValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyColor::applyInheritValue):
(WebCore::ApplyPropertyColor::applyInitialValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyColor::applyColorValue):
(WebCore::ApplyPropertyDirection::applyValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyFillLayer::applyInheritValue):
(WebCore::ApplyPropertyFillLayer::applyInitialValue):
(WebCore::ApplyPropertyFillLayer::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFont::applyInheritValue):
(WebCore::ApplyPropertyFont::applyInitialValue):
(WebCore::ApplyPropertyFont::applyValue):
(WebCore::ApplyPropertyFontSize::applyInheritValue):
(WebCore::ApplyPropertyFontSize::applyInitialValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyInheritValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyInitialValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyBorderImage::applyValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInheritValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInitialValue):
(WebCore::ApplyPropertyBorderImageModifier::applyValue):
(WebCore::ApplyPropertyBorderImageSource::applyValue):
(WebCore::ApplyPropertyCounter::emptyFunction):
(WebCore::ApplyPropertyCounter::applyInheritValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCursor::applyInheritValue):
(WebCore::ApplyPropertyCursor::applyInitialValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyUnicodeBidi::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyPageSize::applyInheritValue):
(WebCore::ApplyPropertyPageSize::applyInitialValue):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore):
(WebCore::ApplyPropertyAnimation::map):
(WebCore::ApplyPropertyAnimation::applyInheritValue):
(WebCore::ApplyPropertyAnimation::applyInitialValue):
(WebCore::ApplyPropertyAnimation::applyValue):
(WebCore::ApplyPropertyOutlineStyle::applyInheritValue):
(WebCore::ApplyPropertyOutlineStyle::applyInitialValue):
(WebCore::ApplyPropertyOutlineStyle::applyValue):
(WebCore::ApplyPropertyResize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyAspectRatio::applyInheritValue):
(WebCore::ApplyPropertyAspectRatio::applyInitialValue):
(WebCore::ApplyPropertyAspectRatio::applyValue):
(WebCore::ApplyPropertyZoom::resetEffectiveZoom):
(WebCore::ApplyPropertyZoom::applyInheritValue):
(WebCore::ApplyPropertyZoom::applyInitialValue):
(WebCore::ApplyPropertyZoom::applyValue):
(WebCore::ApplyPropertyDisplay::isValidDisplayValue):
(WebCore::ApplyPropertyDisplay::applyInheritValue):
(WebCore::ApplyPropertyDisplay::applyInitialValue):
(WebCore::ApplyPropertyDisplay::applyValue):
(WebCore::ApplyPropertyFlex::applyInheritValue):
(WebCore::ApplyPropertyFlex::applyInitialValue):
(WebCore::ApplyPropertyFlex::applyValue):
(WebCore::StyleBuilder::StyleBuilder):
- css/StyleBuilder.h:
(WebCore):
(PropertyHandler):
(WebCore::PropertyHandler::applyInheritValue):
(WebCore::PropertyHandler::applyInitialValue):
(WebCore::PropertyHandler::applyValue):
- css/StyleMedia.cpp:
(WebCore::StyleMedia::matchMedium):
- css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::setName):
- css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::setMatrixValue):
- dom/Document.cpp:
(WebCore::Document::recalcStyle):
(WebCore::Document::createStyleSelector):
(WebCore::Document::testAddedStylesheetRequiresStyleRecalc):
- dom/Document.h:
(WebCore):
(WebCore::Document::styleSelectorIfExists):
(WebCore::Document::styleSelector):
(Document):
- dom/Element.cpp:
(StyleSelectorParentPusher):
(WebCore::Element::attributeChanged):
(WebCore::Element::beginParsingChildren):
(WebCore::Element::finishParsingChildren):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::attach):
- dom/ShadowTree.cpp:
(WebCore::ShadowTree::recalcShadowTreeStyle):
- editing/EditingStyle.cpp:
(WebCore::EditingStyle::mergeStyleFromRules):
(WebCore::EditingStyle::removeStyleFromRulesAndContext):
(WebCore::EditingStyle::removePropertiesInElementDefaultStyle):
(WebCore::legacyFontSizeFromCSSValue):
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::focusedOrActiveStateChanged):
- history/CachedPage.cpp:
(WebCore::CachedPage::restore):
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::styleSelector):
- html/HTMLCanvasElement.h:
(HTMLCanvasElement):
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::process):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setFont):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::buildArrayForRuleList):
- inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::getMatchedCSSRules):
- page/Page.cpp:
(WebCore::Page::allVisitedStateChanged):
(WebCore::Page::visitedStateChanged):
- page/animation/AnimationController.cpp:
(WebCore::AnimationController::updateAnimations):
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::adjustButtonStyle):
(WebCore::RenderThemeBlackBerry::adjustTextAreaStyle):
(WebCore::RenderThemeBlackBerry::adjustTextFieldStyle):
(WebCore::RenderThemeBlackBerry::adjustSearchFieldStyle):
(WebCore::RenderThemeBlackBerry::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeBlackBerry::adjustMenuListButtonStyle):
(WebCore::RenderThemeBlackBerry::adjustMenuListStyle):
(WebCore::RenderThemeBlackBerry::adjustCheckboxStyle):
(WebCore::RenderThemeBlackBerry::adjustRadioStyle):
- platform/blackberry/RenderThemeBlackBerry.h:
(RenderThemeBlackBerry):
- platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::adjustSliderTrackStyle):
(WebCore::RenderThemeEfl::adjustSliderThumbStyle):
(WebCore::RenderThemeEfl::adjustCheckboxStyle):
(WebCore::RenderThemeEfl::adjustRadioStyle):
(WebCore::RenderThemeEfl::adjustButtonStyle):
(WebCore::RenderThemeEfl::adjustMenuListStyle):
(WebCore::RenderThemeEfl::adjustMenuListButtonStyle):
(WebCore::RenderThemeEfl::adjustTextFieldStyle):
(WebCore::RenderThemeEfl::adjustTextAreaStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldStyle):
(WebCore::RenderThemeEfl::adjustProgressBarStyle):
- platform/efl/RenderThemeEfl.h:
(RenderThemeEfl):
- platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::adjustButtonStyle):
(WebCore::RenderThemeGtk::adjustMenuListStyle):
(WebCore::RenderThemeGtk::adjustMenuListButtonStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldStyle):
(WebCore::RenderThemeGtk::adjustSliderTrackStyle):
(WebCore::RenderThemeGtk::adjustSliderThumbStyle):
(WebCore::RenderThemeGtk::adjustProgressBarStyle):
- platform/gtk/RenderThemeGtk.h:
(RenderThemeGtk):
- platform/gtk/RenderThemeGtk2.cpp:
(WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle):
- platform/gtk/RenderThemeGtk3.cpp:
(WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle):
- platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::adjustTextFieldStyle):
(WebCore::RenderThemeQt::adjustTextAreaStyle):
(WebCore::RenderThemeQt::adjustMenuListStyle):
(WebCore::RenderThemeQt::adjustMenuListButtonStyle):
(WebCore::RenderThemeQt::adjustProgressBarStyle):
(WebCore::RenderThemeQt::adjustSliderTrackStyle):
(WebCore::RenderThemeQt::adjustSliderThumbStyle):
(WebCore::RenderThemeQt::adjustSearchFieldStyle):
(WebCore::RenderThemeQt::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeQt::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQt::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeQt::adjustInnerSpinButtonStyle):
- platform/qt/RenderThemeQt.h:
(RenderThemeQt):
- platform/qt/RenderThemeQtMobile.cpp:
(WebCore::RenderThemeQtMobile::adjustButtonStyle):
(WebCore::RenderThemeQtMobile::adjustTextFieldStyle):
(WebCore::RenderThemeQtMobile::adjustMenuListStyle):
- platform/qt/RenderThemeQtMobile.h:
(RenderThemeQtMobile):
- platform/wx/RenderThemeWx.cpp:
(RenderThemeWx):
(WebCore::RenderThemeWx::adjustButtonStyle):
(WebCore::RenderThemeWx::adjustTextFieldStyle):
(WebCore::RenderThemeWx::adjustMenuListStyle):
(WebCore::RenderThemeWx::adjustMenuListButtonStyle):
- rendering/RenderInputSpeech.cpp:
(WebCore::RenderInputSpeech::adjustInputFieldSpeechButtonStyle):
- rendering/RenderInputSpeech.h:
(RenderInputSpeech):
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::adjustCheckboxStyle):
(WebCore::RenderTheme::adjustRadioStyle):
(WebCore::RenderTheme::adjustButtonStyle):
(WebCore::RenderTheme::adjustInnerSpinButtonStyle):
(WebCore::RenderTheme::adjustTextFieldStyle):
(WebCore::RenderTheme::adjustTextAreaStyle):
(WebCore::RenderTheme::adjustMenuListStyle):
(WebCore::RenderTheme::adjustInputFieldSpeechButtonStyle):
(WebCore::RenderTheme::adjustMeterStyle):
(WebCore::RenderTheme::adjustProgressBarStyle):
(WebCore::RenderTheme::adjustMenuListButtonStyle):
(WebCore::RenderTheme::adjustSliderTrackStyle):
(WebCore::RenderTheme::adjustSliderThumbStyle):
(WebCore::RenderTheme::adjustSearchFieldStyle):
(WebCore::RenderTheme::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderTheme::adjustSearchFieldDecorationStyle):
(WebCore::RenderTheme::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderTheme::adjustSearchFieldResultsButtonStyle):
- rendering/RenderTheme.h:
(RenderTheme):
- rendering/RenderThemeChromiumAndroid.cpp:
(WebCore::RenderThemeChromiumAndroid::adjustInnerSpinButtonStyle):
- rendering/RenderThemeChromiumAndroid.h:
(RenderThemeChromiumAndroid):
- rendering/RenderThemeChromiumLinux.cpp:
(WebCore::RenderThemeChromiumLinux::adjustInnerSpinButtonStyle):
- rendering/RenderThemeChromiumLinux.h:
(RenderThemeChromiumLinux):
- rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::adjustButtonStyle):
(WebCore::RenderThemeChromiumSkia::adjustSearchFieldStyle):
(WebCore::RenderThemeChromiumSkia::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeChromiumSkia::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeChromiumSkia::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeChromiumSkia::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeChromiumSkia::adjustMenuListStyle):
(WebCore::RenderThemeChromiumSkia::adjustMenuListButtonStyle):
- rendering/RenderThemeChromiumSkia.h:
(RenderThemeChromiumSkia):
- rendering/RenderThemeChromiumWin.cpp:
(WebCore):
(WebCore::RenderThemeChromiumWin::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeChromiumWin::adjustProgressBarStyle):
- rendering/RenderThemeChromiumWin.h:
(RenderThemeChromiumWin):
- rendering/RenderThemeMac.h:
(RenderThemeMac):
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::setFontFromControlSize):
(WebCore::RenderThemeMac::adjustTextFieldStyle):
(WebCore::RenderThemeMac::adjustTextAreaStyle):
(WebCore::RenderThemeMac::adjustProgressBarStyle):
(WebCore::RenderThemeMac::adjustMenuListStyle):
(WebCore::RenderThemeMac::adjustMenuListButtonStyle):
(WebCore::RenderThemeMac::adjustSliderTrackStyle):
(WebCore::RenderThemeMac::adjustSliderThumbStyle):
(WebCore::RenderThemeMac::adjustSearchFieldStyle):
(WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):
- rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::setFontFromControlSize):
(WebCore::RenderThemeSafari::adjustButtonStyle):
(WebCore::RenderThemeSafari::adjustTextFieldStyle):
(WebCore::RenderThemeSafari::adjustTextAreaStyle):
(WebCore::RenderThemeSafari::adjustMenuListStyle):
(WebCore::RenderThemeSafari::adjustMenuListButtonStyle):
(WebCore::RenderThemeSafari::adjustSliderThumbStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldResultsButtonStyle):
- rendering/RenderThemeSafari.h:
(RenderThemeSafari):
- rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeWin::adjustMenuListStyle):
(WebCore::RenderThemeWin::adjustMenuListButtonStyle):
(WebCore::RenderThemeWin::adjustSearchFieldStyle):
(WebCore::RenderThemeWin::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeWin::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeWin::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeWin::adjustSearchFieldResultsButtonStyle):
- rendering/RenderThemeWin.h:
(RenderThemeWin):
(WebCore::RenderThemeWin::adjustButtonStyle):
(WebCore::RenderThemeWin::adjustTextFieldStyle):
(WebCore::RenderThemeWin::adjustTextAreaStyle):
- rendering/RenderThemeWinCE.cpp:
(WebCore::RenderThemeWinCE::adjustMenuListStyle):
(WebCore::RenderThemeWinCE::adjustSearchFieldStyle):
(WebCore::RenderThemeWinCE::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeWinCE::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeWinCE::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeWinCE::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeWinCE::adjustMenuListButtonStyle):
- rendering/RenderThemeWinCE.h:
(RenderThemeWinCE):
(WebCore::RenderThemeWinCE::adjustButtonStyle):
(WebCore::RenderThemeWinCE::adjustTextFieldStyle):
(WebCore::RenderThemeWinCE::adjustTextAreaStyle):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::isStyleAvailable):
- rendering/style/RenderStyle.h:
(WebCore):
- rendering/style/StyleRareNonInheritedData.h:
(WebCore):
- rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::computeNewScaledFontForStyle):
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::isOverflowHidden):
Source/WebKit/qt:
- WebCoreSupport/RenderThemeQStyle.cpp:
(WebCore::RenderThemeQStyle::adjustButtonStyle):
(WebCore::RenderThemeQStyle::adjustTextAreaStyle):
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
(WebCore::RenderThemeQStyle::adjustSliderTrackStyle):
(WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
(WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):
- WebCoreSupport/RenderThemeQStyle.h:
(RenderThemeQStyle):
- 12:43 PM Changeset in webkit [115096] by
-
- 4 edits3 adds in trunk
Failure to allocate ArrayStorage in emit_op_new_array leads to poisonous JSArray
https://bugs.webkit.org/show_bug.cgi?id=84648
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
When emit_op_new_array successfully allocates a new JSArray but fails to allocate
the corresponding ArrayStorage for it, it falls back to the out-of-line stub call
to constructArray, which constructs and entirely new JSArray/ArrayStorage pair.
This leaves us with a JSArray hanging around on the stack or in a register that
did not go through its own constructor, thus giving it uninitialized memory in the
two fields that are checked in JSArray::visitChildren.
- jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateJSArray): We try to allocate the ArrayStorage first, so that
if we fail we haven't generated the poisonous JSArray that can cause a GC crash.
- jit/JITOpcodes.cpp:
(JSC::JIT::emitSlow_op_new_array):
LayoutTests:
Added a test that randomly allocates new arrays, modifies the object graph by
pointing arrays to other arrays, and removes arrays from the global list. This test
is sufficient to repro this bug when the DFG is disabled, and it should serve as
a good regression test as we implement more optimizations for array allocation in
both JITs.
- fast/js/random-array-gc-stress-expected.txt: Added.
- fast/js/random-array-gc-stress.html: Added.
- fast/js/script-tests/random-array-gc-stress.js: Added.
(gc):
(getRandomIndex):
(test):
- 12:41 PM Changeset in webkit [115095] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Unreviewed build fix after r115083
- WebProcess/qt/QtBuiltinBundlePage.cpp:
(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):
- 12:28 PM Changeset in webkit [115094] by
-
- 2 edits in trunk/Tools
[TestResultsServer] Add a unit test for changes in r114868
https://bugs.webkit.org/show_bug.cgi?id=84713
Reviewed by Ojan Vafai.
Add a new unit test to test the isToTWebKit attribute of a BuilderGroup object
that is created for either DEPS or ToT builder groups. The unit test covers changes
made in r114868.
- TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
(testBuilderGroupIsToTWebKitAttribute.g_handleBuildersListLoaded):
(testBuilderGroupIsToTWebKitAttribute.assertEquals):
- 12:19 PM Changeset in webkit [115093] by
-
- 12 edits in trunk/Source/JavaScriptCore
DFG on ARMv7 should not OSR exit on every integer division
https://bugs.webkit.org/show_bug.cgi?id=84661
Reviewed by Oliver Hunt.
On ARMv7, ArithDiv no longer has to know whether or not to speculate integer (since
that was broken with the introduction of Int32ToDouble) nor does it have to know
whether or not to convert its result to integer. This is now taken care of for free
with the addition of the DoubleAsInt32 node, which represents a double-is-really-int
speculation.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::OSRExit::considerAddingAsFrequentExitSiteSlow):
- dfg/DFGOSRExit.h:
(OSRExit):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
(JSC::DFG::SpeculativeJIT::compileDoubleAsInt32):
(DFG):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::forwardSpeculationCheck):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 12:11 PM Changeset in webkit [115092] by
-
- 5 edits in trunk/Source/JavaScriptCore
"GlobalHandle" HandleHeap (now WeakSet) allocations grow but do not shrink
https://bugs.webkit.org/show_bug.cgi?id=84740
<rdar://problem/9917638>
Reviewed by Gavin Barraclough.
Shrink!
- heap/Heap.cpp:
(JSC::Heap::destroy): Be more specific about what's shrinking, since we
can also shrink the WeakSet, but we don't do so here.
(JSC::Heap::collect): If we're going to shrink the heap, shrink the
WeakSet too. Otherwise, its footprint is permanent.
- heap/Heap.h:
(Heap): Removed shrink() as a public interface, since it's vague about
which parts of the heap it affects, and it's really an internal detail.
- heap/WeakSet.cpp:
(JSC::WeakSet::shrink): Nix any free blocks. We assume that sweep() has
already taken place, since that's the convention for shrink() in the heap.
- heap/WeakSet.h:
(WeakSet): New function!
- 12:03 PM Changeset in webkit [115091] by
-
- 10 edits17 adds in trunk
CSS 2.1 failure: table-columns-example-001 fails
https://bugs.webkit.org/show_bug.cgi?id=83978
Reviewed by David Hyatt.
Source/WebCore:
Tests: css2.1/20110323/table-columns-example-001.html
fast/css/table-rules-attribute-groups-with-frame.html
fast/css/table-rules-attribute-groups.html
fast/css/table-rules-attribute-none-with-frame.html
fast/css/table-rules-attribute-with-frame1.html
fast/css/table-rules-attribute-with-frame2.html
fast/css/table-rules-attribute.html
WebKit does not implement the 'cols', 'rows', and 'all' rules attributes correctly
for cells that are adjacent to the table's edges. The solution is to follow the hint in the
spec at http://www.w3.org/TR/CSS21/tables.html#columns and set the table's border to
hidden when the rules attribute is set to one of 'cols', 'rows' or 'all', and the table itself
has no explicit border. Border collapsing will take care of the rest as 'hidden' always wins in
border-conflict resolution. It's not completely clear from the spec that an explicit table border
should trump a cols rule but doing so is consistent with FF and Opera at least. A 'rules' attribute
is trumped by anything specified for the 'frame' attribute so need to ensure that is respected too.
In short, any 'rules' attribute means a hidden table border unless there's a frame or border attribute.
- html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::additionalAttributeStyle):
LayoutTests:
- css2.1/20110323/table-columns-example-001-expected.html: Added.
- css2.1/20110323/table-columns-example-001.htm: Added.
- fast/css/table-rules-attribute-expected.html: Added.
- fast/css/table-rules-attribute-groups-expected.html: Added.
- fast/css/table-rules-attribute-groups-with-frame-expected.png: Added.
- fast/css/table-rules-attribute-groups-with-frame-expected.txt: Added.
- fast/css/table-rules-attribute-groups-with-frame.html: Added.
- fast/css/table-rules-attribute-groups.html: Added.
- fast/css/table-rules-attribute-none-with-frame-expected.html: Added.
- fast/css/table-rules-attribute-none-with-frame.html: Added.
- fast/css/table-rules-attribute-with-frame1-expected.png: Added.
- fast/css/table-rules-attribute-with-frame1-expected.txt: Added.
- fast/css/table-rules-attribute-with-frame1.html: Added.
- fast/css/table-rules-attribute-with-frame2-expected.png: Added.
- fast/css/table-rules-attribute-with-frame2-expected.txt: Added.
- fast/css/table-rules-attribute-with-frame2.html: Added. These test the correct interaction of a rules attribute with a frame attribute. 'cols' is used for the test, but each of cols, rows, and all have the same effect on the table's borders. It wasn't possible to create reftests for all of them because of the different behaviour of the frame attr to a simple border, probably due to painting order.
- fast/css/table-rules-attribute.html: Added. This tests correct rendering of the rules attribute on a table without its own border. It also tests border collapsing on tables with a rules attribute.
- platform/chromium-linux/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
This is a progression - the table's border is hidden.
- platform/chromium/test_expectations.txt:
- platform/gtk/test_expectations.txt:
- platform/mac/Skipped:
- platform/mac/test_expectations.txt:
- platform/qt/test_expectations.txt:
- 11:55 AM Changeset in webkit [115090] by
-
- 31 edits5 adds11 deletes in trunk/LayoutTests
[EFL] Rebaseline background tests
https://bugs.webkit.org/show_bug.cgi?id=84686
Unreviewed rebaseline.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-24
- platform/efl/Skipped:
- platform/efl/fast/backgrounds/001-expected.txt:
- platform/efl/fast/backgrounds/animated-gif-as-background-expected.png:
- platform/efl/fast/backgrounds/animated-svg-as-mask-expected.txt:
- platform/efl/fast/backgrounds/background-leakage-expected.txt:
- platform/efl/fast/backgrounds/background-leakage-transforms-expected.txt:
- platform/efl/fast/backgrounds/background-origin-root-element-expected.txt:
- platform/efl/fast/backgrounds/background-position-1-expected.png:
- platform/efl/fast/backgrounds/background-position-parsing-expected.txt:
- platform/efl/fast/backgrounds/background-position-rounding-expected.png:
- platform/efl/fast/backgrounds/body-generated-image-propagated-to-root-expected.txt:
- platform/efl/fast/backgrounds/mask-box-image-expected.png: Added.
- platform/efl/fast/backgrounds/mask-box-image-expected.txt: Added.
- platform/efl/fast/backgrounds/mask-composite-expected.png:
- platform/efl/fast/backgrounds/opacity-on-document-element-expected.txt:
- platform/efl/fast/backgrounds/positioned-root-expected.png: Removed.
- platform/efl/fast/backgrounds/positioned-root-expected.txt: Removed.
- platform/efl/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.txt:
- platform/efl/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.txt:
- platform/efl/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
- platform/efl/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
- platform/efl/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.txt:
- platform/efl/fast/backgrounds/repeat/noRepeatCorrectClip-expected.png:
- platform/efl/fast/backgrounds/size/backgroundSize15-expected.txt:
- platform/efl/fast/backgrounds/size/backgroundSize16-expected.txt:
- platform/efl/fast/backgrounds/size/backgroundSize17-expected.png:
- platform/efl/fast/backgrounds/size/backgroundSize17-expected.txt: Removed.
- platform/efl/fast/backgrounds/size/backgroundSize18-expected.png:
- platform/efl/fast/backgrounds/size/backgroundSize18-expected.txt: Removed.
- platform/efl/fast/backgrounds/size/backgroundSize19-expected.png:
- platform/efl/fast/backgrounds/size/backgroundSize19-expected.txt: Removed.
- platform/efl/fast/backgrounds/size/backgroundSize20-expected.png:
- platform/efl/fast/backgrounds/size/backgroundSize20-expected.txt: Removed.
- platform/efl/fast/backgrounds/size/backgroundSize21-expected.png:
- platform/efl/fast/backgrounds/size/backgroundSize21-expected.txt: Removed.
- platform/efl/fast/backgrounds/size/backgroundSize22-expected.png:
- platform/efl/fast/backgrounds/size/backgroundSize22-expected.txt: Removed.
- platform/efl/fast/backgrounds/size/contain-and-cover-expected.png: Added.
- platform/efl/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
- platform/efl/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
- platform/efl/fast/backgrounds/size/zero-expected.txt:
- platform/efl/fast/backgrounds/solid-color-context-restore-expected.png:
- platform/efl/fast/backgrounds/solid-color-context-restore-expected.txt:
- platform/efl/fast/backgrounds/svg-as-mask-expected.txt: Removed.
- platform/efl/fast/backgrounds/table-root-expected.png: Removed.
- platform/efl/fast/backgrounds/table-root-expected.txt: Removed.
- 11:51 AM Changeset in webkit [115089] by
-
- 2 edits in trunk/Source/WebCore
Stop installing localizedStrings.js in Production builds.
<rdar://problem/11296649>
Reviewed by Joseph Pecoraro.
- Configurations/WebCore.xcconfig: Added EXCLUDED_SOURCE_FILE_NAMES_Production_macosx
and modified EXCLUDED_SOURCE_FILE_NAMES to look for CONFIGURATION variant.
- 11:44 AM Changeset in webkit [115088] by
-
- 2 edits in trunk/LayoutTests
fast/dom/Window/window-postmessage-clone.html failing on Mac after r114992
https://bugs.webkit.org/show_bug.cgi?id=84741
Not reviewed. Rebaseline only; verified locally.
- fast/dom/Window/window-postmessage-clone-expected.txt:
- 11:34 AM Changeset in webkit [115087] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, skip unsupported inspector heap profiler test on mac.
- platform/mac/Skipped: Skip inspector/profiler/heap-snapshot-comparison-dom-groups-change.html
- 11:32 AM Changeset in webkit [115086] by
-
- 5 edits in trunk/Source
[chromium] Add a description field in WebURLError and show failure description in the inspector network tab.
https://bugs.webkit.org/show_bug.cgi?id=84566
Patch by Yuzhu Shen <yzshen@chromium.org> on 2012-04-24
Reviewed by Pavel Feldman.
Source/Platform:
- chromium/public/WebURLError.h:
(WebURLError):
Source/WebCore:
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
- platform/chromium/support/WebURLError.cpp:
(WebKit::WebURLError::operator=):
(WebKit::WebURLError::operator ResourceError):
- 11:21 AM Changeset in webkit [115085] by
-
- 44 edits4 adds1 delete in trunk
[SVG] getBBox on a <g> within symbol returns 0 but with defs it works correctly
https://bugs.webkit.org/show_bug.cgi?id=72796
SVG <use> of <symbol> containing <linearGradient> renders black
https://bugs.webkit.org/show_bug.cgi?id=82775
Source/WebCore:
Reviewed by Dirk Schulze.
Create RenderSVGHiddenContainer for each <symbol>, which allows creation of child renderers too. This fixes
both bugs since the bbox can be calculated at all times now and gradients in <symbol> are always created.
This does allocate more memory but in general <symbol> is not used a lot and they tend to be small subtrees.
Patch by Leo Yang.
Tests: svg/custom/bbox-of-g-in-symbol.svg
svg/custom/gradient-in-symbol-expected.svg
svg/custom/gradient-in-symbol.svg
- svg/SVGSymbolElement.cpp:
(WebCore::SVGSymbolElement::createRenderer):
(WebCore):
- svg/SVGSymbolElement.h:
(SVGSymbolElement):
LayoutTests:
Add a new test for each bug. Also rebaseline some test results since
RenderSVGHiddenContainer is dumped now.
Reviewed by Dirk Schulze.
- platform/chromium/test_expectations.txt:
- platform/mac/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
- platform/mac/svg/carto.net/button-expected.txt:
- platform/mac/svg/carto.net/colourpicker-expected.txt:
- platform/mac/svg/carto.net/slider-expected.txt:
- platform/mac/svg/carto.net/window-expected.txt:
- platform/mac/svg/custom/embedding-external-svgs-expected.txt:
- platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
- platform/mac/svg/custom/relative-sized-use-on-symbol-expected.txt:
- platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
- platform/mac/svg/custom/struct-use-09-b-expected.txt: Removed.
- platform/mac/svg/custom/use-clipped-hit-expected.txt:
- platform/mac/svg/custom/use-css-events-expected.txt:
- platform/mac/svg/custom/use-modify-target-symbol-expected.txt:
- platform/mac/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
- platform/mac/svg/custom/use-on-g-containing-symbol-expected.txt:
- platform/mac/svg/custom/use-on-symbol-expected.txt:
- platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt:
- platform/mac/svg/custom/use-recalcStyle-crash-expected.txt:
- platform/mac/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
- platform/mac/svg/custom/use-symbol-overflow-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
- platform/qt/svg/carto.net/button-expected.txt:
- platform/qt/svg/carto.net/colourpicker-expected.txt:
- platform/qt/svg/carto.net/slider-expected.txt:
- platform/qt/svg/carto.net/window-expected.txt:
- platform/qt/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
- platform/qt/svg/custom/use-on-g-containing-symbol-expected.txt:
- platform/qt/svg/custom/use-on-symbol-expected.txt:
- platform/qt/svg/custom/use-recalcStyle-crash-expected.txt:
- platform/qt/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
- platform/qt/svg/custom/use-transfer-width-height-properties-to-svg2-expected.txt:
- platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol-expected.txt:
- platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol2-expected.txt:
- svg/custom/bbox-of-g-in-symbol-expected.txt: Added.
- svg/custom/bbox-of-g-in-symbol.svg: Added.
- svg/custom/deep-dynamic-updates-expected.txt:
- svg/custom/gradient-in-symbol-expected.svg: Added.
- svg/custom/gradient-in-symbol.svg: Added.
- svg/custom/use-in-symbol-with-offset-expected.txt:
- svg/custom/use-setAttribute-crash-expected.txt:
- svg/custom/use-transfer-width-height-properties-to-svg2-expected.txt:
- svg/custom/use-transfer-width-height-properties-to-symbol-expected.txt:
- svg/custom/use-transfer-width-height-properties-to-symbol1-expected.txt:
- svg/custom/use-transfer-width-height-properties-to-symbol2-expected.txt:
- 11:13 AM Changeset in webkit [115084] by
-
- 2 edits in branches/subpixellayout/Source/WebKit/gtk/webkit
Misc GTK fixes on branch.
- 11:12 AM Changeset in webkit [115083] by
-
- 31 edits8 adds in trunk
<rdar://problem/10120155> and https://bugs.webkit.org/show_bug.cgi?id=82664 Need DOMWindow mechanism to supplement UserScripts for page cache notifications
Source/WebCore:
This patch creates a new object type "DOMWindowExtension" which extends DOMWindowProperty.
A DOMWindowExtension is tied to a particular DOMWindow and represents extensibility in that
DOMWindow within a particular DOMWrapperWorld.
It is a token object meant designed to notify clients of the various events in the lifetime
of a DOMWindow property such as creation, disconnecting for the page cache, reconnecting
when restoring from the page cache, and DOMWindow destruction.
Reviewed by Sam Weinig.
New WebKit API test DOMWindowExtensionBasic added.
Add hooks for 4 new client calls regarding DOMWindowExtensions and global object lifetime:
- loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::dispatchCanCreateGlobalObject):
(WebCore::FrameLoaderClient::dispatchWillDisconnectDOMWindowExtensionFromGlobalObject):
(WebCore::FrameLoaderClient::dispatchDidReconnectDOMWindowExtensionToGlobalObject):
(WebCore::FrameLoaderClient::dispatchWillDestroyGlobalObjectForDOMWindowExtension):
At the same time "DidClearWindowObject" is called, also notify clients that the global object is available:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::receivedFirstData):
(WebCore::FrameLoader::dispatchGlobalObjectAvailableInAllWorlds):
- loader/FrameLoader.h:
DOMWindowProperties might want to unregister themselves during these notifications, so copy
the set to a Vector. While this technique is arguably fragile, its certainly less fragile than
mutating a set while iterating it:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::willDetachPage):
(WebCore::DOMWindow::disconnectDOMWindowProperties):
(WebCore::DOMWindow::reconnectDOMWindowProperties):
Implement the DOMWindowExtension object. It acts like a DOMWindowProperty with the added capability
of remembering what Frame it used to be connected to so it can *always* notify clients on willDetachPage:
- page/DOMWindowExtension.cpp: Added.
(WebCore::DOMWindowExtension::DOMWindowExtension):
(WebCore::DOMWindowExtension::~DOMWindowExtension):
(WebCore::DOMWindowExtension::disconnectFrame):
(WebCore::DOMWindowExtension::reconnectFrame):
(WebCore::DOMWindowExtension::willDetachPage):
- page/DOMWindowExtension.h: Added.
(WebCore::DOMWindowExtension::create):
(WebCore::DOMWindowExtension::world):
Project files:
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
Source/WebKit2:
Reviewed by Sam Weinig.
- Adds a new API object WKBundleDOMWindowExtension
- Exposes callbacks about the lifetime of DOMWindowExtensions through BundlePageLoaderClient
Add new API casts:
- Shared/API/c/WKBase.h:
- Shared/APIClientTraits.cpp:
- Shared/APIObject.h:
- WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
Add API for the new DOMWindowExtension object:
- WebProcess/InjectedBundle/API/c/WKBundleDOMWindowExtension.cpp: Added.
(WKBundleDOMWindowExtensionGetTypeID):
(WKBundleDOMWindowExtensionCreate):
(WKBundleDOMWindowExtensionGetFrame):
(WKBundleDOMWindowExtensionGetScriptWorld):
- WebProcess/InjectedBundle/API/c/WKBundleDOMWindowExtension.h: Added.
Add implementation for that API which wraps the WebCore::DOMWindowExtension:
- WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp: Added.
(WebKit::allExtensions):
(WebKit::InjectedBundleDOMWindowExtension::create):
(WebKit::InjectedBundleDOMWindowExtension::get):
(WebKit::InjectedBundleDOMWindowExtension::InjectedBundleDOMWindowExtension):
(WebKit::InjectedBundleDOMWindowExtension::~InjectedBundleDOMWindowExtension):
(WebKit::InjectedBundleDOMWindowExtension::frame):
(WebKit::InjectedBundleDOMWindowExtension::world):
- WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.h: Added.
(InjectedBundleDOMWindowExtension):
(WebKit::InjectedBundleDOMWindowExtension::type):
Add new BundlePageLoaderClient methods:
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::didCreateGlobalObjectForFrame):
(WebKit::InjectedBundlePageLoaderClient::willDisconnectDOMWindowExtensionFromGlobalObject):
(WebKit::InjectedBundlePageLoaderClient::didReconnectDOMWindowExtensionToGlobalObject):
(WebKit::InjectedBundlePageLoaderClient::willDestroyGlobalObjectForDOMWindowExtension):
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
(InjectedBundlePageLoaderClient):
Implement the 4 new callbacks from WebCore which notify the BundlePageLoaderClient:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchGlobalObjectAvailable):
(WebKit::WebFrameLoaderClient::dispatchWillDisconnectDOMWindowExtensionFromGlobalObject):
(WebKit::WebFrameLoaderClient::dispatchDidReconnectDOMWindowExtensionToGlobalObject):
(WebKit::WebFrameLoaderClient::dispatchWillDestroyGlobalObjectForDOMWindowExtension):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
Project Files:
- CMakeLists.txt:
- GNUmakefile.am:
- Target.pri:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
Tools:
Reviewed by Sam Weinig.
Add a new bundle test that stresses the basics of the WKBundleDOMWindowExtension API.
It makes sure new extensions can be added at the right times, and that all of the expected
callbacks are made.
- TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp: Added.
(TestWebKitAPI::didReceiveMessageFromInjectedBundle): Record all messages sent from the bundle.
(TestWebKitAPI::TEST): Run a page through some basic exercises, then compared messages sent from the
bundle to a set of known expected messages.
Listen to all the new client callbacks, create some extensions, and monitor their lifetimes:
- TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp: Added.
(TestWebKitAPI::DOMWindowExtensionBasic::DOMWindowExtensionBasic):
(TestWebKitAPI::DOMWindowExtensionBasic::frameLoadFinished):
(TestWebKitAPI::DOMWindowExtensionBasic::sendExtensionStateMessage):
(TestWebKitAPI::DOMWindowExtensionBasic::initialize):
(TestWebKitAPI::DOMWindowExtensionBasic::didCreatePage):
(TestWebKitAPI::DOMWindowExtensionBasic::updateExtensionStateRecord):
(TestWebKitAPI::DOMWindowExtensionBasic::sendBundleMessage):
(TestWebKitAPI::DOMWindowExtensionBasic::didCreateGlobalObjectForFrame):
(TestWebKitAPI::DOMWindowExtensionBasic::willDisconnectDOMWindowExtensionFromGlobalObject):
(TestWebKitAPI::DOMWindowExtensionBasic::didReconnectDOMWindowExtensionToGlobalObject):
(TestWebKitAPI::DOMWindowExtensionBasic::willDestroyGlobalObjectForDOMWindowExtension):
(TestWebKitAPI::didFinishLoadForFrameCallback):
(TestWebKitAPI::didCreateGlobalObjectForFrameCallback):
(TestWebKitAPI::willDisconnectDOMWindowExtensionFromGlobalObjectCallback):
(TestWebKitAPI::didReconnectDOMWindowExtensionToGlobalObjectCallback):
(TestWebKitAPI::willDestroyGlobalObjectForDOMWindowExtensionCallback):
- TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
(TestWebKitAPI::didReceiveMessageFromInjectedBundle): Make this method static, as it always should have been.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- 10:48 AM Changeset in webkit [115082] by
-
- 3 edits in trunk/Source/WebKit2
[Qt][WK2] Implement axis locking on the WebView for pan gestures
https://bugs.webkit.org/show_bug.cgi?id=84350
Reviewed by Kenneth Rohde Christiansen.
If a pan gesture has sufficient velocity along one axis the WebView
should automatically lock the page movement to that axis.
This locking should be maintained until the ongoing pan gesture ends.
This patch implements a simple axis locker which adjusts the positions
sent to the Flickable to the initial reference position according to the
direction an velocity information it gathered from incoming touch events.
The FlickableAxisLocker makes use of the velocity information of the touch point
if available, else an approximate velocity of the incoming event is
calculated.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::FlickableAxisLocker::FlickableAxisLocker):
(QQuickWebViewPrivate::FlickableAxisLocker::touchVelocity):
(QQuickWebViewPrivate::FlickableAxisLocker::update):
(QQuickWebViewPrivate::FlickableAxisLocker::setReferencePosition):
(QQuickWebViewPrivate::FlickableAxisLocker::reset):
(QQuickWebViewPrivate::FlickableAxisLocker::adjust):
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebView::touchEvent):
(QQuickWebView::handleFlickableMousePress):
(QQuickWebView::handleFlickableMouseMove):
(QQuickWebView::handleFlickableMouseRelease):
- UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
- 10:46 AM Changeset in webkit [115081] by
-
- 4 edits1 delete in trunk/LayoutTests
Update svg-ellipse-non-scale-stroke expectations
https://bugs.webkit.org/show_bug.cgi?id=82628
Unreviewed update of test expectations.
- platform/chromium/test_expectations.txt:
- platform/gtk/svg/hittest/svg-ellipse-non-scale-stroke-expected.txt: Removed.
- platform/gtk/test_expectations.txt:
- svg/hittest/svg-ellipse-non-scale-stroke-expected.txt:
- 10:43 AM Changeset in webkit [115080] by
-
- 5 edits in trunk/Source
[chromium] Don't keep pointers to released layer tree
https://bugs.webkit.org/show_bug.cgi?id=84715
Patch by Sami Kyostila <skyostil@chromium.org> on 2012-04-24
Reviewed by Adrienne Walker.
Source/WebCore:
As part of tree synchronization, CCLayerTreeHostImpl loses ownership of
the previous tree (as per releaseRootLayer()). After this point we
should not retain any pointers to the old tree, because they are
effectively invalid as soon as the root layer is released.
For processing scroll updates we need to keep track of which layer is
being scrolled, and this state needs to survive tree synchronizations.
Instead of keeping a direct pointer to the scrolled layer, we now save
the id of that layer and use it to look up the same layer from the new
tree.
Unit test: CCLayerTreeHostImplTest.replaceTreeWhileScrolling
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::setRootLayer):
(WebCore::CCLayerTreeHostImpl::releaseRootLayer):
(WebCore::CCLayerTreeHostImpl::scrollBegin):
(WebCore::CCLayerTreeHostImpl::scrollEnd):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
Source/WebKit/chromium:
Added new unit test to check that we can keep scrolling even if the layer
tree is replaced from under us.
- tests/CCLayerTreeHostImplTest.cpp:
(WebKitTests::TEST_F):
(WebKitTests):
- 10:17 AM Changeset in webkit [115079] by
-
- 9 edits2 adds in trunk/Source/WebCore
[CSS Filters] Move m_filter and related fields from RenderLayer to a different structure and only allocate it when needed
https://bugs.webkit.org/show_bug.cgi?id=84460
Reviewed by Dean Jackson.
The new RenderLayerFilterInfo is meant to be allocated only when needed by filters. The link to the RenderLayerFilterInfo
is maintained using a HashMap and a single boolean in the RenderLayer class.
No new tests, just extracted a couple of fields inside the RenderLayer to a separate class.
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRendererHelper::prepareFilterEffect):
(WebCore::FilterEffectRendererHelper::beginFilterEffect):
(WebCore::FilterEffectRendererHelper::applyFilterEffect):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::~RenderLayer):
(WebCore::RenderLayer::paintsWithFilters):
(WebCore::RenderLayer::requiresFullLayerImageForFilters):
(WebCore::RenderLayer::setFilterBackendNeedsRepaintingInRect):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::updateOrRemoveFilterEffect):
- rendering/RenderLayer.h:
(WebCore::RenderLayer::filterRenderer):
(RenderLayer):
(WebCore::RenderLayer::filterInfo):
(WebCore::RenderLayer::ensureFilterInfo):
(WebCore::RenderLayer::removeFilterInfoIfNeeded):
(WebCore::RenderLayer::hasFilterInfo):
(WebCore::RenderLayer::setHasFilterInfo):
- rendering/RenderLayerFilterInfo.cpp: Added.
(WebCore):
(WebCore::RenderLayerFilterInfo::filterInfoForRenderLayer):
(WebCore::RenderLayerFilterInfo::createFilterInfoForRenderLayerIfNeeded):
(WebCore::RenderLayerFilterInfo::removeFilterInfoForRenderLayer):
(WebCore::RenderLayerFilterInfo::RenderLayerFilterInfo):
(WebCore::RenderLayerFilterInfo::~RenderLayerFilterInfo):
(WebCore::RenderLayerFilterInfo::setRenderer):
- rendering/RenderLayerFilterInfo.h: Added.
(WebCore):
(RenderLayerFilterInfo):
(WebCore::RenderLayerFilterInfo::dirtySourceRect):
(WebCore::RenderLayerFilterInfo::addDirtySourceRect):
(WebCore::RenderLayerFilterInfo::resetDirtySourceRect):
(WebCore::RenderLayerFilterInfo::renderer):
- 10:09 AM Changeset in webkit [115078] by
-
- 4 edits in trunk/Source/WTF
Iterating a HashMap<String, X> involves a string equality comparison to check for the empty value
https://bugs.webkit.org/show_bug.cgi?id=84524
Reviewed by Antti Koivisto.
Added a new algorithm for checking for empty buckets that can be specialized.
Specialized it for String. We may later want to do the same thing for KURL.
It's not important to do it for AtomicString, since AtomicString's == function
is already a simple pointer equality compare. We may also later want to do
something similar for pairs that have String objects in them.
- wtf/HashTable.h:
(WTF::HashTable::isEmptyBucket): Call the new isHashTraitsEmptyValue function, which
will do something more efficient for String.
- wtf/HashTraits.h: Added hasIsEmptyValueFunction to hash traits, with a default value
of false. This allows us to continue to get automatic comparison with the appropriate
emptyValue result for all existing traits, but supply a custom isEmptyValue function
for HashTraits<String>. Putting an isEmptyValue function into the traits would require
overriding it in every class that has a custom value for emptyValue. Specialized
HashTraits for String to add hasIsEmptyValueFunction and declare, but not define, the
isEmptyValue function.
(WTF::isHashTraitsEmptyValue): Added a function that uses the HashTraitsEmptyValueChecker
struct to use either == combined with the emptyValue function or the isEmptyValue function.
- wtf/text/StringHash.h: Removed unneeded includes and sorted the using statements at
the bottom of the file.
(WTF::HashTraits<String>::isEmptyValue): Define this function here, since here we have
included the WTFString.h header; the HashTraits.h header compiles without WTFString.h.
- 10:01 AM Changeset in webkit [115077] by
-
- 3 edits in trunk/Source/WebCore
[V8] Pass Isolate around in SerializedScriptValue.cpp (Part1)
https://bugs.webkit.org/show_bug.cgi?id=84663
Reviewed by Nate Chapin.
The objective is to pass Isolate to toV8() in SerializedScriptValue.cpp.
Part1: Add an Isolate argument to SerializedScriptValue::create(),
SerializedScriptValue::deserialize(), etc.
Part2: Add an m_isolate member to SerializedScriptValue::Writer()
and SerializedScriptValue::Reader().
Part3: Pass Isolate to toV8().
This patch fixes Part1.
No tests. No change in behavior.
- bindings/v8/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::undefinedValue):
(WebCore::SerializedScriptValue::booleanValue):
(WebCore::SerializedScriptValue::numberValue):
(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::deserialize):
(WebCore::SerializedScriptValue::deserializeForInspector):
- bindings/v8/SerializedScriptValue.h:
(SerializedScriptValue):
- 9:51 AM Changeset in webkit [115076] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84735
Mark http/tests/inspector/change-iframe-src.html as flaky on Windows
- platform/chromium/test_expectations.txt:
- 9:48 AM Changeset in webkit [115075] by
-
- 6 edits2 adds in trunk
[GTK] Build and run TestWebKitAPI unit tests
https://bugs.webkit.org/show_bug.cgi?id=84325
Reviewed by Philippe Normand.
.:
- GNUmakefile.am: Include makefiles to build gtest and
TestWebKitAPI. Add BUILDING_WEBKIT2 macro to compilation when
building WebKit2.
Source/ThirdParty:
- gtest/GNUmakefile.am: Added.
Tools:
We only build WTF unit tests for now. WebKit2 tests will be
enabled in a follow up patch.
- Scripts/run-gtk-tests:
(TestRunner): Add TestWebKitAPI/WTF to the list of directories
containing unit tests.
(TestRunner._run_test_glib): Run glib tests using gtester.
(TestRunner._run_test_google): Run google tests.
(TestRunner._run_test): Use _run_test_glib or _run_test_google
depending on whether given test is glib or google test
- TestWebKitAPI/GNUmakefile.am: Added.
- TestWebKitAPI/config.h: Use #ifdef instead of # to fix a compile
warning with -Wundef. Include WebKit2 headers only when building
WebKit2.
- 9:44 AM Changeset in webkit [115074] by
-
- 3 edits in trunk/Source/WebCore
[V8][Refactoring] Remove deserializeAndSetProperty()
from SerializedScriptValue.cpp
https://bugs.webkit.org/show_bug.cgi?id=84662
Reviewed by Nate Chapin.
SerializedScriptValue::deserializeAndSetProperty() is no
longer used. This patch removes it.
No tests. No change in behavior.
- bindings/v8/SerializedScriptValue.cpp:
- bindings/v8/SerializedScriptValue.h:
- 9:40 AM Changeset in webkit [115073] by
-
- 5 edits in trunk/Source/WebCore
[V8] Pass Isolate to setDOMException() in CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=84660
Reviewed by Nate Chapin.
The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to setDOMException() in CodeGeneratorV8.pm.
Test: bindings/scripts/test/TestEventTarget.idl
bindings/scripts/test/TestObj.idl
bindings/scripts/test/TestInterface.idl
- bindings/scripts/CodeGeneratorV8.pm: Modified as described above.
(GenerateSetDOMException):
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateFunctionCallback):
(GenerateParametersCheck):
(GenerateFunctionCallString):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
Updated run-bindings-tests results.
(WebCore::TestEventTargetV8Internal::itemCallback):
(WebCore::TestEventTargetV8Internal::dispatchEventCallback):
- bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
- bindings/scripts/test/V8/V8TestObj.cpp: Ditto.
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::attrWithSetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::methodWithExceptionCallback):
(WebCore::TestObjV8Internal::withScriptStateVoidExceptionCallback):
(WebCore::TestObjV8Internal::withScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::getSVGDocumentCallback):
(WebCore::TestObjV8Internal::strictFunctionCallback):
- 9:31 AM Changeset in webkit [115072] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84733
Mark fast/canvas/canvas-composite.html as flaky on Vista.
- 9:28 AM Changeset in webkit [115071] by
-
- 7 edits in trunk/Tools
[Qt][WK2] Convert touch-point area
https://bugs.webkit.org/show_bug.cgi?id=84434
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-24
Reviewed by Kenneth Rohde Christiansen.
Fix failing test after r114917 by also adding the new EventSender API
to WebKitTestRunner.
- WebKitTestRunner/EventSenderProxy.h:
(EventSenderProxy):
- WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
- WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::setTouchPointRadius):
- WebKitTestRunner/InjectedBundle/EventSendingController.h:
(EventSendingController):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
- WebKitTestRunner/qt/EventSenderProxyQt.cpp:
(WTR::EventSenderProxy::addTouchPoint):
(WTR::EventSenderProxy::updateTouchPoint):
(WTR::EventSenderProxy::setTouchPointRadius):
(WTR::EventSenderProxy::clearTouchPoints):
- 9:21 AM Changeset in webkit [115070] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK test_expectations update.
- platform/gtk/test_expectations.txt: One more drag&drop test
failing and mark fast/events/panScroll-click-hyperlink.html as
missing result.
- 9:18 AM Changeset in webkit [115069] by
-
- 6 edits in branches/chromium/1084
Revert 114994 - Merge 114699 - REGRESSION(r112177): Numbered list item rendered bulleted
https://bugs.webkit.org/show_bug.cgi?id=84216
Patch by David Barr <davidbarr@chromium.org> on 2012-04-19
Reviewed by Ryosuke Niwa.
Shorthands that imply omitted values cannot be derived from
an incomplete set of longhand rules.
No new tests; updated existing tests that should have caught this.
Source/WebCore:
- css/CSSParser.cpp:
(WebCore::CSSParser::parseTransformOriginShorthand):
Set implicit initial for Z when omitted.
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getShorthandValue):
LayoutTests:
- css3/flexbox/css-properties.html:
- fast/css/cssText-shorthand.html:
- fast/css/uri-token-parsing-expected.txt:
- fast/css/uri-token-parsing.html:
- fast/dom/css-dom-read-2-expected.txt:
TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10140014
TBR=mikelawther@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10204020
- 9:14 AM Changeset in webkit [115068] by
-
- 15 edits in trunk/Source/WebCore
[V8] Pass Isolate to setDOMException() (Part2)
https://bugs.webkit.org/show_bug.cgi?id=84658
Reviewed by Nate Chapin.
The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to setDOMException() in custom
binding code.
No tests. No change in behavior.
- bindings/v8/V8Collection.cpp:
(WebCore::toOptionsCollectionSetter):
- bindings/v8/V8Collection.h:
(WebCore):
- bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::constructWebGLArrayWithArrayBufferArgument):
(WebCore::setWebGLArrayHelper):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::WindowSetTimeoutImpl):
- bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::V8DataView::getInt8Callback):
(WebCore::V8DataView::getUint8Callback):
(WebCore::V8DataView::setInt8Callback):
(WebCore::V8DataView::setUint8Callback):
- bindings/v8/custom/V8DirectoryEntrySyncCustom.cpp:
(WebCore::V8DirectoryEntrySync::getDirectoryCallback):
(WebCore::V8DirectoryEntrySync::getFileCallback):
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::toDataURLCallback):
- bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore::V8HTMLElement::itemValueAccessorSetter):
- bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore::V8HTMLOptionsCollection::addCallback):
(WebCore::V8HTMLOptionsCollection::lengthAccessorSetter):
(WebCore::V8HTMLOptionsCollection::indexedPropertySetter):
- bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
(WebCore::V8HTMLSelectElement::indexedPropertySetter):
- bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::V8Node::insertBeforeCallback):
(WebCore::V8Node::replaceChildCallback):
(WebCore::V8Node::removeChildCallback):
(WebCore::V8Node::appendChildCallback):
- bindings/v8/custom/V8SQLTransactionCustom.cpp:
(WebCore::V8SQLTransaction::executeSqlCallback):
- bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:
(WebCore::V8WebKitMutationObserver::observeCallback):
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::responseAccessorGetter):
- 9:06 AM Changeset in webkit [115067] by
-
- 5 edits in trunk/Source/WebCore
[V8] Pass Isolate to setDOMException() (Part1)
https://bugs.webkit.org/show_bug.cgi?id=84656
Reviewed by Nate Chapin.
The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to setDOMException() in custom binding code.
No tests. No change in behavior.
- bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::protocolAccessorSetter):
- bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
(WebCore::V8SQLTransactionSync::executeSqlCallback):
- bindings/v8/custom/V8SVGLengthCustom.cpp:
(WebCore::V8SVGLength::valueAccessorGetter):
(WebCore::V8SVGLength::valueAccessorSetter):
(WebCore::V8SVGLength::convertToSpecifiedUnitsCallback):
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::getObjectParameter):
(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getExtensionCallback):
(WebCore::V8WebGLRenderingContext::getFramebufferAttachmentParameterCallback):
(WebCore::V8WebGLRenderingContext::getParameterCallback):
(WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
(WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
(WebCore::V8WebGLRenderingContext::getUniformCallback):
(WebCore::vertexAttribAndUniformHelperf):
(WebCore::uniformHelperi):
(WebCore::uniformMatrixHelper):
- 9:05 AM Changeset in webkit [115066] by
-
- 5 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Add additional details including the bounds of the box for caretPositionChanged.
https://bugs.webkit.org/show_bug.cgi?id=84728
Reviewed by Antonio Gomes.
PR 138988.
Update caretPositionChanged to include the limit of the input field
for single line inputs.
Reviewed Internally by Gen Mak.
- Api/WebPageClient.h:
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::boundingBoxForInputField):
(WebKit):
- WebKitSupport/InputHandler.h:
(InputHandler):
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::clippingRectForVisibleContent):
(BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
- 8:57 AM Changeset in webkit [115065] by
-
- 3 edits1 add in trunk
[BlackBerry] Input Range element expects mouse events
https://bugs.webkit.org/show_bug.cgi?id=84571
Reviewed by Antonio Gomes.
.:
Input element with Range type expects mouse events to
drag the handle. Note that Input Range could appear
in both the web page directly, or in some shadow tree,
like the MediaControlTimeline and MediaControlVolume.
- ManualTests/blackberry/slider-thumb-consumes-event.html: Added.
Source/WebKit/blackberry:
Input element with Range type expects mouse events to
drag the handle. Note that Input Range could appear
in both the web page directly, or in some shadow tree,
like the MediaControlTimeline and MediaControlVolume.
- WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::isRangeControlElement):
(WebKit):
(BlackBerry::WebKit::elementExpectsMouseEvents):
(BlackBerry::WebKit::shouldConvertTouchToMouse):
- 8:46 AM Changeset in webkit [115064] by
-
- 12 edits in trunk
Web Inspector: encapsulate live location into the Script.
https://bugs.webkit.org/show_bug.cgi?id=84722
Reviewed by Yury Semikhatsky.
Source/WebCore:
Live location is just a location on the script. The way it is implemented today involves too many indirections.
- inspector/front-end/CompilerScriptMapping.js:
- inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.setBreakpointByScriptLocation):
(WebInspector.DebuggerModel.prototype.scriptForId):
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.createLiveLocation):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessageToScript):
(WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
(WebInspector.PresentationCallFrame.prototype.uiLocation):
(WebInspector.DebuggerPresentationModel.CallFramePlacard):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyRawLocation):
- inspector/front-end/RawSourceCode.js:
- inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype.addScript):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeChanged):
(WebInspector.ResourceScriptMapping.prototype._bindScriptToRawSourceCode):
- inspector/front-end/Script.js:
(WebInspector.Script):
(WebInspector.Script.prototype.isInlineScript):
(WebInspector.Script.prototype.setSourceMapping):
(WebInspector.Script.prototype.createLocation):
(WebInspector.Script.Location):
(WebInspector.Script.Location.prototype.dispose):
(WebInspector.Script.Location.prototype._update):
- inspector/front-end/ScriptMapping.js:
(WebInspector.UILocation):
(WebInspector.SourceMapping):
(WebInspector.SourceMapping.prototype.rawLocationToUILocation):
(WebInspector.SourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.MainScriptMapping):
(WebInspector.MainScriptMapping.prototype.addScript):
(WebInspector.MainScriptMapping.prototype.reset):
- inspector/front-end/SnippetsModel.js:
(WebInspector.SnippetsScriptMapping.prototype._createUISourceCodeForScript):
LayoutTests:
- http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
- inspector/debugger/linkifier.html:
- 8:37 AM Changeset in webkit [115063] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: a bunch of heap profiler cleanups
https://bugs.webkit.org/show_bug.cgi?id=84730
- HeapSnapshotProviderProxy passed explicitely as a parameter to HeapSnapshotGridNode
constructor
- Removed dead code
- Removed unused parameters
- Added more closure compiler annotations
- Extracted code finding cycled among node ancestors into a separate method
Reviewed by Pavel Feldman.
- inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype.createEdgesProvider):
(WebInspector.HeapSnapshot.prototype.createRetainingEdgesProvider):
(WebInspector.HeapSnapshot.prototype.createNodesProviderForDominator):
(WebInspector.HeapSnapshotEdgesProvider):
- inspector/front-end/HeapSnapshotDataGrids.js:
- inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode):
(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotObjectNode):
(WebInspector.HeapSnapshotObjectNode.prototype._findAncestorWithSameSnapshotNodeId):
(WebInspector.HeapSnapshotInstanceNode):
(WebInspector.HeapSnapshotConstructorNode):
(WebInspector.HeapSnapshotDiffNode):
(WebInspector.HeapSnapshotDiffNode._createProvider):
(WebInspector.HeapSnapshotDominatorObjectNode):
- inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotWorker):
(WebInspector.HeapSnapshotProxy.prototype.createNodesProviderForDominator):
- inspector/front-end/utilities.js:
- 8:35 AM Changeset in webkit [115062] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
The following tests have been marked as crashing in debug mode only:
http/tests/websocket/tests/hixie76/workers/close-in-onmessage-crash.html
http/tests/websocket/tests/hixie76/workers/close-in-worker.html
http/tests/websocket/tests/hixie76/workers/worker-handshake-challenge-randomness.html
http/tests/websocket/tests/hixie76/workers/worker-simple.html
media/media-controller-playback.html
media/track/track-cues-missed.html
media/track/track-cues-pause-on-exit.html
media/track/track-cues-sorted-before-dispatch.html
- platform/chromium/test_expectations.txt:
- 8:29 AM Changeset in webkit [115061] by
-
- 5 edits in trunk/Source
Fix includes in StrongInlines.h and ScriptValue.h
https://bugs.webkit.org/show_bug.cgi?id=84659
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- heap/StrongInlines.h: Include JSGlobalData.h, since JSGlobalData's
definiition is required here.
Source/WebCore:
This change was prompted by an attempt to use ScriptValue.h from a
WebCore header file and running into trouble with the (as it turns out
unnecessary) include of JSDOMBinding.h.
- bindings/js/ScriptValue.cpp: Add include of JSDOMBinding.h, now that
it's not included by the header.
- bindings/js/ScriptValue.h: Remove unnecessary include of JSDOMBinding.h.
- 8:27 AM Changeset in webkit [115060] by
-
- 11 edits in trunk/Source/WebCore
Move MediaList CSSOM wrapper ownership to parent rule or stylesheet
https://bugs.webkit.org/show_bug.cgi?id=84716
Reviewed by Anders Carlsson.
MediaList CSSOM wrapper should be owned by a rule or a stylesheet, not by the underlying
MediaQuerySet.
Remove the ref forwarding from MediaList in favor of regular refcounting. Use the usual
pattern where the parent wrapper refs the child wrapper and zeroes the backpointer
on destruction.
- bindings/js/JSDOMBinding.h:
(WebCore::root):
- css/CSSImportRule.cpp:
(WebCore::CSSImportRule::~CSSImportRule):
(WebCore::CSSImportRule::media):
- css/CSSImportRule.h:
(StyleRuleImport):
(CSSImportRule):
- css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::~CSSMediaRule):
(WebCore::CSSMediaRule::media):
- css/CSSMediaRule.h:
(CSSMediaRule):
- css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::~CSSStyleSheet):
(WebCore::CSSStyleSheet::media):
- css/CSSStyleSheet.h:
(CSSStyleSheet):
- css/MediaList.cpp:
(WebCore::MediaQuerySet::mediaText):
(WebCore::MediaList::MediaList):
(WebCore):
(WebCore::MediaList::notifyChanged):
- css/MediaList.h:
(MediaQuerySet):
(WebCore::MediaList::create):
(WebCore::MediaList::parentRule):
(WebCore::MediaList::clearParentStyleSheet):
(WebCore::MediaList::clearParentRule):
(WebCore::MediaList::queries):
(MediaList):
- css/StyleRule.h:
(WebCore::StyleRuleMedia::mediaQueries):
- 8:27 AM Changeset in webkit [115059] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Tap-to zoom should navigate when appropiate
https://bugs.webkit.org/show_bug.cgi?id=84602
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-24
Reviewed by Simon Hausmann.
When a zoomable area is returned and has the same zoom-level as the current,
examine if the using this target would expose currently unexposed parts of
the zoom-target. If it does, pan to that area instead of zooming back.
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
- 8:25 AM Changeset in webkit [115058] by
-
- 4 edits in trunk
[GTK] Should pass canvas/philip/tests/toDataURL.jpeg.alpha.html
https://bugs.webkit.org/show_bug.cgi?id=83973
Reviewed by Philippe Normand.
Source/WebCore:
Test: canvas/philip/tests/toDataURL.jpeg.alpha.html
- platform/graphics/gtk/ImageBufferGtk.cpp:
(WebCore::encodeImage): Convert ARGB32 cairo surface into RGB24
when encoding JPEG images since JPEG encoder doesn't support alpha
channel.
LayoutTests:
- platform/gtk/test_expectations.txt: Unskip
canvas/philip/tests/toDataURL.jpeg.alpha.html
- 8:18 AM Changeset in webkit [115057] by
-
- 6 edits1 add in trunk/Source
[GTK] Add WebKitCookieManager::changed signal to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=82598
Reviewed by Philippe Normand.
Source/WebCore:
- GNUmakefile.list.am: Add new files to compilation.
- platform/gtk/TemporaryLinkStubs.cpp: Remove stubs for
setCookieStoragePrivateBrowsingEnabled,
startObservingCookieChanges and stopObservingCookieChanges.
- platform/network/soup/CookieStorageSoup.cpp: Added.
(WebCore::setCookieStoragePrivateBrowsingEnabled):
(WebCore::soupCookiesChanged): Notify cookies changes using
platform strategies.
(WebCore::startObservingCookieChanges): Connect to changed signal
of the soup cookie jar.
(WebCore::stopObservingCookieChanges): Disconnect signals handlers
for changed signals of the soup cookie jar.
Source/WebKit2:
- UIProcess/API/gtk/WebKitCookieManager.cpp:
(webkitCookieManagerFinalize): Stop observing cookie changes.
(webkit_cookie_manager_class_init): Add
WebKitCookieManager::changed signal.
(cookiesDidChange): Emit WebKitCookieManager::changed signal.
(webkitCookieManagerCreate): Implement WKCookieManagerClient and
start observing cookie changes.
- UIProcess/API/gtk/tests/TestCookieManager.cpp:
(testCookieManagerCookiesChanged):
(beforeAll):
- 8:16 AM Changeset in webkit [115056] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-24
- DEPS:
- 7:59 AM Changeset in webkit [115055] by
-
- 9 edits2 adds2 deletes in trunk/Source/WebCore
Rename CSSStyleApplyProperty files to StyleBuilder.
https://bugs.webkit.org/show_bug.cgi?id=84721
Reviewed by Antti Koivisto.
r115043 renamed CSSStyleApplyProperty class to StyleBuilder. This
patch rename the files to match the new class name.
No new tests : renaming of files, no behavior changes expected.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSAllInOne.cpp:
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- css/StyleBuilder.cpp: Renamed from Source/WebCore/css/CSSStyleApplyProperty.cpp.
(WebCore):
(ApplyPropertyExpanding):
(WebCore::ApplyPropertyExpanding::applyInheritValue):
(WebCore::ApplyPropertyExpanding::applyInitialValue):
(WebCore::ApplyPropertyExpanding::applyValue):
(WebCore::ApplyPropertyExpanding::createHandler):
(ApplyPropertyDefaultBase):
(WebCore::ApplyPropertyDefaultBase::setValue):
(WebCore::ApplyPropertyDefaultBase::value):
(WebCore::ApplyPropertyDefaultBase::initial):
(WebCore::ApplyPropertyDefaultBase::applyInheritValue):
(WebCore::ApplyPropertyDefaultBase::applyInitialValue):
(WebCore::ApplyPropertyDefaultBase::applyValue):
(WebCore::ApplyPropertyDefaultBase::createHandler):
(ApplyPropertyDefault):
(WebCore::ApplyPropertyDefault::setValue):
(WebCore::ApplyPropertyDefault::applyValue):
(WebCore::ApplyPropertyDefault::createHandler):
(ApplyPropertyNumber):
(WebCore::ApplyPropertyNumber::setValue):
(WebCore::ApplyPropertyNumber::applyValue):
(WebCore::ApplyPropertyNumber::createHandler):
(ApplyPropertyStyleImage):
(WebCore::ApplyPropertyStyleImage::applyValue):
(WebCore::ApplyPropertyStyleImage::createHandler):
(ApplyPropertyAuto):
(WebCore::ApplyPropertyAuto::setValue):
(WebCore::ApplyPropertyAuto::value):
(WebCore::ApplyPropertyAuto::hasAuto):
(WebCore::ApplyPropertyAuto::setAuto):
(WebCore::ApplyPropertyAuto::applyInheritValue):
(WebCore::ApplyPropertyAuto::applyInitialValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyAuto::createHandler):
(ApplyPropertyClip):
(WebCore::ApplyPropertyClip::convertToLength):
(WebCore::ApplyPropertyClip::applyInheritValue):
(WebCore::ApplyPropertyClip::applyInitialValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyClip::createHandler):
(WebCore::defaultInitialColor):
(ApplyPropertyColor):
(WebCore::ApplyPropertyColor::applyInheritValue):
(WebCore::ApplyPropertyColor::applyInitialValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyColor::applyColorValue):
(WebCore::ApplyPropertyColor::createHandler):
(ApplyPropertyDirection):
(WebCore::ApplyPropertyDirection::applyValue):
(WebCore::ApplyPropertyDirection::createHandler):
(ApplyPropertyLength):
(WebCore::ApplyPropertyLength::setValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyLength::createHandler):
(ApplyPropertyString):
(WebCore::ApplyPropertyString::setValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyString::createHandler):
(ApplyPropertyBorderRadius):
(WebCore::ApplyPropertyBorderRadius::setValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyBorderRadius::createHandler):
(FillLayerAccessorTypes):
(ApplyPropertyFillLayer):
(WebCore::ApplyPropertyFillLayer::applyInheritValue):
(WebCore::ApplyPropertyFillLayer::applyInitialValue):
(WebCore::ApplyPropertyFillLayer::applyValue):
(WebCore::ApplyPropertyFillLayer::createHandler):
(ApplyPropertyComputeLength):
(WebCore::ApplyPropertyComputeLength::setValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyComputeLength::createHandler):
(ApplyPropertyFont):
(WebCore::ApplyPropertyFont::applyInheritValue):
(WebCore::ApplyPropertyFont::applyInitialValue):
(WebCore::ApplyPropertyFont::applyValue):
(WebCore::ApplyPropertyFont::createHandler):
(ApplyPropertyFontSize):
(WebCore::ApplyPropertyFontSize::largerFontSize):
(WebCore::ApplyPropertyFontSize::smallerFontSize):
(WebCore::ApplyPropertyFontSize::applyInheritValue):
(WebCore::ApplyPropertyFontSize::applyInitialValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyFontSize::createHandler):
(ApplyPropertyFontWeight):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontWeight::createHandler):
(ApplyPropertyFontVariantLigatures):
(WebCore::ApplyPropertyFontVariantLigatures::applyInheritValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyInitialValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::createHandler):
(ApplyPropertyBorderImage):
(WebCore::ApplyPropertyBorderImage::applyValue):
(WebCore::ApplyPropertyBorderImage::createHandler):
(ApplyPropertyBorderImageModifier):
(WebCore::ApplyPropertyBorderImageModifier::getValue):
(WebCore::ApplyPropertyBorderImageModifier::setValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInheritValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInitialValue):
(WebCore::ApplyPropertyBorderImageModifier::applyValue):
(WebCore::ApplyPropertyBorderImageModifier::createHandler):
(ApplyPropertyBorderImageSource):
(WebCore::ApplyPropertyBorderImageSource::applyValue):
(WebCore::ApplyPropertyBorderImageSource::createHandler):
(ApplyPropertyCounter):
(WebCore::ApplyPropertyCounter::emptyFunction):
(WebCore::ApplyPropertyCounter::applyInheritValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCounter::createHandler):
(ApplyPropertyCursor):
(WebCore::ApplyPropertyCursor::applyInheritValue):
(WebCore::ApplyPropertyCursor::applyInitialValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyCursor::createHandler):
(ApplyPropertyTextAlign):
(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyTextAlign::createHandler):
(ApplyPropertyTextDecoration):
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyTextDecoration::createHandler):
(ApplyPropertyUnicodeBidi):
(WebCore::ApplyPropertyUnicodeBidi::applyValue):
(WebCore::ApplyPropertyUnicodeBidi::createHandler):
(ApplyPropertyLineHeight):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyLineHeight::createHandler):
(ApplyPropertyPageSize):
(WebCore::ApplyPropertyPageSize::mmLength):
(WebCore::ApplyPropertyPageSize::inchLength):
(WebCore::ApplyPropertyPageSize::getPageSizeFromName):
(WebCore::ApplyPropertyPageSize::applyInheritValue):
(WebCore::ApplyPropertyPageSize::applyInitialValue):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyPageSize::createHandler):
(ApplyPropertyTextEmphasisStyle):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::createHandler):
(ApplyPropertyAnimation):
(WebCore::ApplyPropertyAnimation::setValue):
(WebCore::ApplyPropertyAnimation::value):
(WebCore::ApplyPropertyAnimation::test):
(WebCore::ApplyPropertyAnimation::clear):
(WebCore::ApplyPropertyAnimation::initial):
(WebCore::ApplyPropertyAnimation::map):
(WebCore::ApplyPropertyAnimation::accessAnimations):
(WebCore::ApplyPropertyAnimation::animations):
(WebCore::ApplyPropertyAnimation::applyInheritValue):
(WebCore::ApplyPropertyAnimation::applyInitialValue):
(WebCore::ApplyPropertyAnimation::applyValue):
(WebCore::ApplyPropertyAnimation::createHandler):
(ApplyPropertyOutlineStyle):
(WebCore::ApplyPropertyOutlineStyle::applyInheritValue):
(WebCore::ApplyPropertyOutlineStyle::applyInitialValue):
(WebCore::ApplyPropertyOutlineStyle::applyValue):
(WebCore::ApplyPropertyOutlineStyle::createHandler):
(ApplyPropertyResize):
(WebCore::ApplyPropertyResize::applyValue):
(WebCore::ApplyPropertyResize::createHandler):
(ApplyPropertyVerticalAlign):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyVerticalAlign::createHandler):
(ApplyPropertyAspectRatio):
(WebCore::ApplyPropertyAspectRatio::applyInheritValue):
(WebCore::ApplyPropertyAspectRatio::applyInitialValue):
(WebCore::ApplyPropertyAspectRatio::applyValue):
(WebCore::ApplyPropertyAspectRatio::createHandler):
(ApplyPropertyZoom):
(WebCore::ApplyPropertyZoom::resetEffectiveZoom):
(WebCore::ApplyPropertyZoom::applyInheritValue):
(WebCore::ApplyPropertyZoom::applyInitialValue):
(WebCore::ApplyPropertyZoom::applyValue):
(WebCore::ApplyPropertyZoom::createHandler):
(ApplyPropertyDisplay):
(WebCore::ApplyPropertyDisplay::isValidDisplayValue):
(WebCore::ApplyPropertyDisplay::applyInheritValue):
(WebCore::ApplyPropertyDisplay::applyInitialValue):
(WebCore::ApplyPropertyDisplay::applyValue):
(WebCore::ApplyPropertyDisplay::createHandler):
(ApplyPropertyFlex):
(WebCore::ApplyPropertyFlex::applyInheritValue):
(WebCore::ApplyPropertyFlex::applyInitialValue):
(WebCore::ApplyPropertyFlex::applyValue):
(WebCore::ApplyPropertyFlex::createHandler):
(WebCore::ApplyPropertyFlex::getFlexValue):
(WebCore::StyleBuilder::sharedStyleBuilder):
(WebCore::StyleBuilder::StyleBuilder):
- css/StyleBuilder.h: Renamed from Source/WebCore/css/CSSStyleApplyProperty.h.
(WebCore):
(PropertyHandler):
(WebCore::PropertyHandler::PropertyHandler):
(WebCore::PropertyHandler::applyInheritValue):
(WebCore::PropertyHandler::applyInitialValue):
(WebCore::PropertyHandler::applyValue):
(WebCore::PropertyHandler::isValid):
(WebCore::PropertyHandler::inheritFunction):
(WebCore::PropertyHandler::initialFunction):
(WebCore::PropertyHandler::applyFunction):
(StyleBuilder):
(WebCore::StyleBuilder::propertyHandler):
(WebCore::StyleBuilder::index):
(WebCore::StyleBuilder::valid):
(WebCore::StyleBuilder::setPropertyHandler):
- 7:51 AM Changeset in webkit [115054] by
-
- 2 edits in trunk/Tools
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84726
Mark webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_start_cmd as failing on Windows.
- Scripts/webkitpy/test/test_finder.py:
(TestFinder._default_names):
- 7:49 AM Changeset in webkit [115053] by
-
- 3 edits2 adds in trunk
WebCore::EventTarget::addEventListener crash
https://bugs.webkit.org/show_bug.cgi?id=84171
Source/WebCore:
Reviewed by Nikolas Zimmermann.
Test: svg/custom/use-tref-crash.svg
Adding tref target event listeners while building the shadow tree is
problematic, because SVGUseElement::buildShadowAndInstanceTree() only
sets the element instance<->shadow element association at a later time.
Fortunately, buildShadowAndInstanceTree() also propagates the event
handlers (transferEventListenersToShadowTree) - so we can simply skip
them in SVGTRefElement::buildPendingResource() for shadow elements.
- svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::buildPendingResource):
LayoutTests:
Reviewed by Nikolas Zimmermann.
- svg/custom/use-tref-crash-expected.txt: Added.
- svg/custom/use-tref-crash.svg: Added.
- 7:47 AM Changeset in webkit [115052] by
-
- 2 edits in trunk/Source/WebCore
Clickable area of a calendar picker indicator is too small.
https://bugs.webkit.org/show_bug.cgi?id=84677
Reviewed by Kentaro Hara.
Test: fast/forms/date/date-appearance.html is affected.
- css/html.css:
(input::-webkit-calendar-picker-indicator):
- Remove unnecessary disaplay:inline-block.
- Add paddings instead of the margin.
(input::-webkit-calendar-picker-indicator:hover):
Add hover style.
- 7:29 AM Changeset in webkit [115051] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84724
Mark platform/chromium/media/video-frame-size-change.html as flaky on Mac 10.6.
- platform/chromium/test_expectations.txt:
- 7:22 AM Changeset in webkit [115050] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
http://crbug.com/31623
Mark http/tests/appcache/remove-cache.html as flaky on Mac 10.6.
- platform/chromium/test_expectations.txt:
- 7:16 AM Changeset in webkit [115049] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84720
Mark fast/repaint/fixed-right-in-page-scale.html as flaky in debug mode.
- platform/chromium/test_expectations.txt:
- 7:09 AM Changeset in webkit [115048] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84719
Mark svg/text/select-text-svgfont.html as flaky on Windows.
- platform/chromium/test_expectations.txt:
- 6:50 AM Changeset in webkit [115047] by
-
- 2 edits in trunk/Source/WebCore
Another unreviewed build fix for Mac.
- css/CSSStyleSelector.h:
(CSSStyleSelector):
- 6:48 AM Changeset in webkit [115046] by
-
- 6 edits in trunk
[EFL] Enable Web Timing
https://bugs.webkit.org/show_bug.cgi?id=84705
Patch by Christophe Dumez <Christophe Dumez> on 2012-04-24
Reviewed by Tony Gentilcore.
.:
Enable Web Timing in EFL port for for performance profiling and
improvement.
- Source/cmake/OptionsEfl.cmake:
Tools:
Enable web timing by default whenever build-webkit is used.
- Scripts/build-webkit:
LayoutTests:
Unskip the test cases that require Web Timing now that it is enabled
by default in EFL port.
- platform/efl/Skipped:
- 6:44 AM Changeset in webkit [115045] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix attempt for Mac.
- rendering/style/RenderStyle.h:
- 6:28 AM Changeset in webkit [115044] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=65063
Unmark as failing on Mac 10.6 css2.1/t0905-c414-flt-01-d-g.html.
- platform/chromium/test_expectations.txt:
- 6:28 AM Changeset in webkit [115043] by
-
- 5 edits in trunk/Source/WebCore
Rename CSSStyleApplyProperty class to StyleBuilder.
https://bugs.webkit.org/show_bug.cgi?id=84711
Reviewed by Antti Koivisto.
As per discussion on bug https://bugs.webkit.org/show_bug.cgi?id=42764
the name is a bit confusing. This first patch rename the class and a
following one will rename the files. We also drop the CSS prefix of the
class to keep CSS prefixed classes for CSSOM types.
No new tests : renaming, no behavior changes should appear.
- css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyExpanding::applyInheritValue):
(WebCore::ApplyPropertyExpanding::applyInitialValue):
(WebCore::ApplyPropertyExpanding::applyValue):
(WebCore::StyleBuilder::sharedStyleBuilder):
(WebCore::StyleBuilder::StyleBuilder):
- css/CSSStyleApplyProperty.h:
(WebCore):
(StyleBuilder):
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- css/CSSStyleSelector.h:
(CSSStyleSelector):
- 6:21 AM Changeset in webkit [115042] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
Unmark as failing on Mac 10.5 the following tests:
fast/backgrounds/size/backgroundSize15.html
fast/events/reveal-link-when-focused.html
fast/frames/content-opacity-1.html
fast/frames/content-opacity-2.html
fast/xsl/xslt-extra-content-at-end.xml
printing/return-from-printing-mode.html
- platform/chromium/test_expectations.txt:
- 6:03 AM Changeset in webkit [115041] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=82628
Unmark svg/hittest/svg-ellipse-non-scale-stroke.xhtml -- passes for a long time.
- platform/chromium/test_expectations.txt:
- 5:56 AM Changeset in webkit [115040] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=75161
Unmark media/video-poster-blocked-by-willsendrequest.html -- fails no more after FFmpeg roll 132717:133551 in Chromium.
- platform/chromium/test_expectations.txt:
- 5:49 AM Changeset in webkit [115039] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84714
Mark compositing/geometry/empty-embed-rects.html as flaky on Mac 10.6.
- platform/chromium/test_expectations.txt:
- 5:49 AM Changeset in webkit [115038] by
-
- 5 edits2 deletes in trunk/Source/WebCore
Merge LocalizedCalendar into LocalizedDate
https://bugs.webkit.org/show_bug.cgi?id=84685
Reviewed by Kentaro Hara.
The functionality of LocalizedCalendar is very related to
LocalizedDate. We should merge them.
No new tests. Just refactoring.
- WebCore.gypi: Remove LocalizedCalendar.h and LocalizedCalenderICU.cpp.
- html/shadow/CalendarPickerElement.cpp:
Include LocalizedDate.h instead of LocalizedCalendar.h.
- platform/text/LocalizedCalendar.h:
Removed. Merged into LocalizedDate.h.
- platform/text/LocalizedCalendarICU.cpp:
Removed. Merged into LocalizedDateICU.h.
- platform/text/LocalizedDate.h:
(WebCore): Move some functions from LocalizedCalendar.h.
- platform/text/LocalizedDateICU.cpp:
Move some functions from LocalizedCalendarICU.cpp.
- 5:41 AM Changeset in webkit [115037] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84712
Mark http/tests/inspector/network/x-frame-options-deny.html as flaky on Vista.
- platform/chromium/test_expectations.txt:
- 5:40 AM Changeset in webkit [115036] by
-
- 15 edits in trunk/LayoutTests
Unreviewed, fix some more GTK baselines after r114836.
- platform/gtk/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
- platform/gtk/fast/dom/importNodeHTML-expected.txt:
- platform/gtk/fast/dom/importNodeXML-expected.txt:
- platform/gtk/fast/dom/inner-text-expected.txt:
- platform/gtk/fast/dom/isindex-001-expected.txt:
- platform/gtk/fast/dom/isindex-002-expected.txt:
- platform/gtk/fast/dom/outerText-expected.txt:
- platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
- platform/gtk/fast/dom/row-inner-text-expected.txt:
- platform/gtk/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt:
- platform/gtk/fast/dom/scroll-reveal-left-overflow-expected.txt:
- platform/gtk/fast/dom/scroll-reveal-top-overflow-expected.txt:
- platform/gtk/fast/dom/tabindex-clamp-expected.txt:
- platform/gtk/fast/dom/vertical-scrollbar-in-rtl-expected.txt:
- 5:39 AM Changeset in webkit [115035] by
-
- 2 edits in trunk/LayoutTests
[Qt] Gardening. Skipped a test because JSC doesn't support heap profiling.
Patch by János Badics <János Badics> on 2012-04-24
Reviewed by Csaba Osztrogonác.
- platform/qt/Skipped:
- 5:31 AM Changeset in webkit [115034] by
-
- 2 edits in trunk/LayoutTests
[EFL] [DRT] Enable passing sputnik tests
https://bugs.webkit.org/show_bug.cgi?id=84600
Unreviewed, unskip sputnik tests which are passing now.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-24
- platform/efl/Skipped:
- 4:33 AM Changeset in webkit [115033] by
-
- 3 edits in trunk/LayoutTests
[EFL] Move tests that require link prefetching to test expectations
https://bugs.webkit.org/show_bug.cgi?id=84673
Unreviewed, test expectations update.
Move tests that require link prefetching to test expectations since it
is disabled by default.
Patch by Christophe Dumez <Christophe Dumez> on 2012-04-24
- platform/efl/Skipped:
- platform/efl/test_expectations.txt:
- 4:24 AM Changeset in webkit [115032] by
-
- 11 edits in trunk
Web Inspector: remove pure delegation code from DebuggerPresentationModel
https://bugs.webkit.org/show_bug.cgi?id=84704
Reviewed by Yury Semikhatsky.
Source/WebCore:
This change removes the code that delegates calls to breakpoint manager and exposes the breakpoint
manager in debugger presentation model itself. It allows narrowing dpm dependencies.
- inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointCheckboxClicked):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointContextMenu):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._contextMenu):
- inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.debuggerPausedDetails):
(WebInspector.DebuggerModel.prototype.createRawLocationByURL):
(WebInspector.DebuggerModel.prototype.isPaused):
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.get breakpointManager):
(WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype._setContentWithInitialContent):
- inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource):
(WebInspector.JavaScriptSource.prototype.consoleMessagesCleared):
(WebInspector.JavaScriptSource.prototype.findBreakpoint):
(WebInspector.JavaScriptSource.prototype.setBreakpoint):
(WebInspector.JavaScriptSource.prototype.setBreakpointEnabled):
(WebInspector.JavaScriptSource.prototype.removeBreakpoint):
(WebInspector.JavaScriptSource.prototype.updateBreakpoint):
(WebInspector.JavaScriptSource.prototype.continueToLine):
(WebInspector.JavaScriptSource.prototype.canSetContent):
(WebInspector.JavaScriptSource.prototype.setContent):
(WebInspector.JavaScriptSource.prototype.updateBreakpointsAfterLiveEdit):
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.canEditSource):
(WebInspector.JavaScriptSourceFrame.prototype.editContent):
(WebInspector.JavaScriptSourceFrame.prototype._onContentChanged):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.else.editBreakpointCondition.didEditBreakpointCondition):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.else):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu):
(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype._getPopoverAnchor):
(WebInspector.JavaScriptSourceFrame.prototype._resolveObjectForPopover.showObjectPopover):
(WebInspector.JavaScriptSourceFrame.prototype._resolveObjectForPopover):
(WebInspector.JavaScriptSourceFrame.prototype._setBreakpoint):
(WebInspector.JavaScriptSourceFrame.prototype._onMouseDown):
- inspector/front-end/ScopeChainSidebarPane.js:
(WebInspector.ScopeChainSidebarPane.prototype.update):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetUILocation):
(WebInspector.ScriptsPanel.prototype._debuggerPaused):
LayoutTests:
- http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
- inspector/debugger/pause-in-inline-script.html:
- 4:23 AM Changeset in webkit [115031] by
-
- 4 edits2 adds in trunk
Web Inspector: native nodes may have snapshot id less than base snapshot max JS object id
https://bugs.webkit.org/show_bug.cgi?id=84681
Make sure new nodes whose IDs less than base snapshot max JS object id will
get into snapshot delta.
Reviewed by Pavel Feldman.
Source/WebCore:
Test: inspector/profiler/heap-snapshot-comparison-dom-groups-change.html
- inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._calculateDiffForClass):
- inspector/front-end/HeapSnapshotDataGrids.js:
(WebInspector.HeapSnapshotSortableDataGrid): Drive-by fix, made recursion counter
a normal field on HeapSnapshotSortableDataGrid.
(WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingEnter):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingLeave):
LayoutTests:
- inspector/profiler/heap-snapshot-comparison-dom-groups-change-expected.txt: Added.
- inspector/profiler/heap-snapshot-comparison-dom-groups-change.html: Added.
- 4:08 AM Changeset in webkit [115030] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, unflag tests passing after r114796.
- platform/gtk/test_expectations.txt:
- 4:03 AM Changeset in webkit [115029] by
-
- 6 edits in trunk/Source
Unreviewed, rolling out r115000.
http://trac.webkit.org/changeset/115000
https://bugs.webkit.org/show_bug.cgi?id=84703
Breaks webkit_unit_tests on Mac in Chromium:
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.6/builds/15157
(Requested by mnaganov on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-24
Source/WebCore:
- platform/graphics/skia/OpaqueRegionSkia.cpp:
(WebCore::paintIsOpaque):
(WebCore::OpaqueRegionSkia::popCanvasLayer):
(WebCore::OpaqueRegionSkia::didDraw):
(WebCore::OpaqueRegionSkia::didDrawUnbounded):
(WebCore::OpaqueRegionSkia::markRectAsOpaque):
(WebCore::OpaqueRegionSkia::markRectAsNonOpaque):
- platform/graphics/skia/OpaqueRegionSkia.h:
(OpaqueRegionSkia):
(WebCore::OpaqueRegionSkia::CanvasLayerState::CanvasLayerState):
(CanvasLayerState):
- platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::restoreLayer):
Source/WebKit/chromium:
- tests/PlatformContextSkiaTest.cpp:
(WebCore):
(WebCore::TEST):
- 3:53 AM Changeset in webkit [115028] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK test_expectations update.
- platform/gtk/test_expectations.txt:
- 3:43 AM Changeset in webkit [115027] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=79454
Mark svg/text/text-rescale.html as flaky on release Linux as well.
- platform/chromium/test_expectations.txt:
- 3:36 AM Changeset in webkit [115026] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84696
Mark fast/workers/storage/interrupt-database.html as flaky on Mac 10.6
- platform/chromium/test_expectations.txt:
- 3:34 AM Changeset in webkit [115025] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84698
Mark fast/forms/placeholder-position.html as flaky on Linux
- platform/chromium/test_expectations.txt:
- 3:18 AM Changeset in webkit [115024] by
-
- 2 edits1 add in trunk/LayoutTests
[Qt] Gardening
Patch by Szilard Ledan <Szilárd LEDÁN> on 2012-04-24
Reviewed by Csaba Osztrogonác.
- 3:17 AM Changeset in webkit [115023] by
-
- 2 edits4 deletes in trunk/LayoutTests
Unreviewed, GTK test_expectations update, mark some tests as
failing and remove wrong baselines.
- platform/gtk/fast/events/attempt-scroll-with-no-scrollbars-expected.txt: Removed.
- platform/gtk/fast/events/mouse-relative-position-expected.txt: Removed.
- platform/gtk/fast/events/panScroll-click-hyperlink-expected.txt: Removed.
- platform/gtk/fast/events/selectstart-by-double-triple-clicks-expected.txt: Removed.
- platform/gtk/test_expectations.txt:
- 2:41 AM Changeset in webkit [115022] by
-
- 3 edits in trunk/Source/WebKit2
[Qt] Restore x-position when restoring previous zoom-level.
https://bugs.webkit.org/show_bug.cgi?id=84591
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-24
Reviewed by Simon Hausmann.
Tap-to-zoom fits content to width, therefore it is essentional that
the content is refitted to width when zooming out.
This patch pairs horizontal position and scale on the zoom-out stack.
Additionally it fixes a problem with not detecting zoom-out properly
due to floating point errors.
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::fuzzyCompare):
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
- UIProcess/qt/QtViewportInteractionEngine.h:
(WebKit::QtViewportInteractionEngine::ScaleStackItem::ScaleStackItem):
(QtViewportInteractionEngine):
- 2:40 AM Changeset in webkit [115021] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
Fix lint error in the test expectations file.
- platform/chromium/test_expectations.txt:
- 2:38 AM Changeset in webkit [115020] by
-
- 156 edits3 adds in trunk/LayoutTests
Unreviewed, re-add the GTK baselines that were removed during last
rebaseline of doom (like r114836 and likely other commits).
- platform/gtk/: Fix empty baselines...
- platform/gtk/editing/selection/5195166-1-expected.txt: Added.
- platform/gtk/fast/html/details-marker-style-expected.txt: Added.
- platform/gtk/fast/images/support-broken-image-delegate-expected.txt: Added.
- 2:34 AM Changeset in webkit [115019] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84689
Mark fast/images/embed-does-not-propagate-dimensions-to-object-ancestor.html as flaky on Mac 10.6
- platform/chromium/test_expectations.txt:
- 2:32 AM Changeset in webkit [115018] by
-
- 3 edits in trunk/LayoutTests
[EFL] move tests that require LayoutTestController's layerTreeAsText to test expectations
https://bugs.webkit.org/show_bug.cgi?id=84671
Unreviewed, test expectations update.
Moving test cases which require layerTreeAsText from Skipped list to
test expectations.
Patch by Christophe Dumez <Christophe Dumez> on 2012-04-24
- platform/efl/Skipped:
- platform/efl/test_expectations.txt:
- 2:28 AM Changeset in webkit [115017] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84688
Mark compositing/animation/computed-style-during-delay.html as flaky on Mac 10.6
- platform/chromium/test_expectations.txt:
- 2:17 AM Changeset in webkit [115016] by
-
- 7 edits in trunk/Source/WebCore
Consolidate external stylesheet quirks handling to StyleSheetInternal
https://bugs.webkit.org/show_bug.cgi?id=84632
Reviewed by Andreas Kling.
Move the repeated code from StyleImportRule and HTMLLinkElement to StyleSheetInternal::parseUserStyleSheet.
Remove a BUILDING_ON_LEOPARD-only quirk.
- css/CSSImportRule.cpp:
(WebCore::StyleRuleImport::setCSSStyleSheet):
- css/CSSParser.cpp:
(WebCore):
(WebCore::CSSParserContext::CSSParserContext):
Add new settings bits to the CSSParserContext. These are used for external stylesheet parsing quirks.
- css/CSSParserMode.h:
(CSSParserContext):
- css/CSSStyleSheet.cpp:
(WebCore::StyleSheetInternal::parseUserStyleSheet):
(WebCore::StyleSheetInternal::parseString):
(WebCore):
(WebCore::StyleSheetInternal::parseStringAtLine):
- css/CSSStyleSheet.h:
(WebCore):
(StyleSheetInternal):
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::setCSSStyleSheet):
- 2:16 AM Changeset in webkit [115015] by
-
- 2 edits in trunk/LayoutTests
[Chromium] All of <datalist> tests are passing.
- platform/chromium/test_expectations.txt:
- 2:09 AM Changeset in webkit [115014] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
Mark certain media tests after FFmpeg roll in Chromium:
media/media-controller-playback.html
media/track/track-cues-missed.html
media/track/track-cues-pause-on-exit.html
media/track/track-cues-sorted-before-dispatch.html
media/video-colorspace-yuv422.html
media/video-currentTime-delay.html
- platform/chromium/test_expectations.txt:
- 2:06 AM Changeset in webkit [115013] by
-
- 12 edits in trunk/LayoutTests
Unreviewed, GTK test_expectations and another media rebaseline
after r114957.
- platform/gtk/fast/forms/large-toggle-elements-expected.txt:
- platform/gtk/fast/frames/scrolling-iframe-out-of-viewport-expected.txt:
- platform/gtk/media/audio-controls-rendering-expected.txt:
- platform/gtk/media/audio-repaint-expected.txt:
- platform/gtk/media/controls-strict-expected.txt:
- platform/gtk/media/controls-styling-expected.txt:
- platform/gtk/media/controls-without-preload-expected.txt:
- platform/gtk/media/media-controls-clone-expected.txt:
- platform/gtk/media/media-document-audio-repaint-expected.txt:
- platform/gtk/media/video-controls-rendering-expected.txt:
- platform/gtk/test_expectations.txt:
- 1:52 AM Changeset in webkit [115012] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Incomplete interaction-engine reset.
https://bugs.webkit.org/show_bug.cgi?id=84594
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-24
Reviewed by Simon Hausmann.
Reset a few values forgotten in the reset function.
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::reset):
- 1:35 AM Changeset in webkit [115011] by
-
- 9 edits in trunk/Source
[Qt] Move notification icon download out of WebCore
https://bugs.webkit.org/show_bug.cgi?id=80700
Reviewed by Simon Hausmann.
Source/WebCore:
Remove the code that downloads the notification's icon out of WebCore.
Other ports let the client decide if to download the icon or not.
No new tests. This patch is only removing code.
- notifications/Notification.cpp:
(WebCore::Notification::~Notification):
(WebCore::Notification::show):
(WebCore::Notification::close):
(WebCore::Notification::contextDestroyed):
- notifications/Notification.h:
(Notification):
Source/WebKit/qt:
Remove the code that handles the notification's icon and use the icon url instead.
The "display" event has to be asynchronous, so a timer was added to achieve that.
The platform plugin API and example were updated to reflect this change.
This change does not address the recent changes in web notifications spec.
- Api/qwebkitplatformplugin.h:
(QWebNotificationData):
- WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationWrapper::NotificationWrapper):
(WebCore::NotificationWrapper::sendDisplayEvent):
(WebCore):
(WebCore::NotificationWrapper::iconUrl):
(WebCore::NotificationPresenterClientQt::show):
(WebCore::NotificationPresenterClientQt::displayNotification):
(WebCore::NotificationPresenterClientQt::sendDisplayEvent):
- WebCoreSupport/NotificationPresenterClientQt.h:
(NotificationWrapper):
(NotificationPresenterClientQt):
- examples/platformplugin/WebNotificationPresenter.cpp:
(WebNotificationWidget::showNotification):
- examples/platformplugin/qwebkitplatformplugin.h:
(QWebNotificationData):
- 1:34 AM Changeset in webkit [115010] by
-
- 4 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip failing tests because of new regressions.
- platform/qt-5.0-wk2/Skipped:
- platform/qt-5.0/Skipped:
- platform/qt/Skipped:
- 1:11 AM Changeset in webkit [115009] by
-
- 17 edits5 adds in trunk
RadioNodeList support in HTMLFormElement::elements
https://bugs.webkit.org/show_bug.cgi?id=81854
Source/WebCore:
Implement RadioNodeList support spec'ed at
http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-interfaces.html#radionodelist
Patch by Rakesh KN <rakesh.kn@motorola.com> on 2012-04-24
Reviewed by Ryosuke Niwa.
Test: fast/forms/form-collection-radio-node-list.html
- CMakeLists.txt:
Added entries for new files.
- DerivedSources.cpp: Ditto.
- DerivedSources.make: Ditto.
- DerivedSources.pri: Ditto.
- GNUmakefile.list.am: Ditto.
- Target.pri: Ditto.
- WebCore.gypi: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::getNamedItems):
Modified to create RadioNodeList object when FormControlCollection has more than
one element of same name/id.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
Added code to include Node.h and JSNode.h in JSRadioNodeElement.cpp.
- bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::getNamedItems):
Modified to create RadioNodeList object when FormControlCollection has more than
one element of same name/id.
- html/CollectionType.h:
Added new FormControls type.
- html/HTMLCollection.cpp:
(WebCore::HTMLCollection::shouldIncludeChildren):
(WebCore::HTMLCollection::isAcceptableElement):
Handle FormControls collection type.
- html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::HTMLFormCollection):
Contruct collection of FormControls type.
- html/RadioNodeList.cpp: Added.
(WebCore):
(WebCore::RadioNodeList::RadioNodeList):
(WebCore::RadioNodeList::~RadioNodeList):
(WebCore::toRadioButtonInputElement):
(WebCore::RadioNodeList::value):
(WebCore::RadioNodeList::setValue):
(WebCore::RadioNodeList::nodeMatches):
- html/RadioNodeList.h: Added.
(WebCore):
(RadioNodeList):
(WebCore::RadioNodeList::create):
RadioNodeList implementation.
- html/RadioNodeList.idl: Added.
Idl for generating RadioNodeList JS/V8 bindings.
LayoutTests:
Patch by Rakesh KN <rakesh.kn@motorola.com> on 2012-04-24
Reviewed by Ryosuke Niwa.
- fast/forms/form-collection-radio-node-list-expected.txt: Added.
- fast/forms/form-collection-radio-node-list.html: Added.
- 1:02 AM Changeset in webkit [115008] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK test_expectations update.
- platform/gtk/test_expectations.txt:
- 12:48 AM Changeset in webkit [115007] by
-
- 3 edits in trunk/Source/WebCore
Implement the field cache of ObjcClass in WebKit types
https://bugs.webkit.org/show_bug.cgi?id=84667
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-24
Reviewed by Geoffrey Garen.
Every time we get a field through the Objective-C bridge, we waste some time converting
the incoming string to an CFString.
This patch implement the field cache based on WTF types so that we can return directly
in case of a positive match.
When we do not have a match on the Identifier, we allocate the memory and find the valid field
as before.
- bridge/objc/objc_class.h:
(ObjcClass):
- bridge/objc/objc_class.mm:
(JSC::Bindings::deleteMethod):
(Bindings):
(JSC::Bindings::ObjcClass::ObjcClass):
(JSC::Bindings::ObjcClass::fieldNamed):
- 12:47 AM Changeset in webkit [115006] by
-
- 6 edits in trunk/LayoutTests
Unreviewed, GTK rebaseline after r114957.
- platform/gtk/fast/hidpi/video-controls-in-hidpi-expected.txt:
- platform/gtk/media/video-empty-source-expected.txt:
- platform/gtk/media/video-no-audio-expected.txt:
- platform/gtk/media/video-volume-slider-expected.txt:
- platform/gtk/media/video-zoom-controls-expected.txt:
- 12:43 AM Changeset in webkit [115005] by
-
- 10 edits in trunk/Source
Incremental rendering should be unsuppressed after the load event or a configurable timeout, whichever occurs first.
https://bugs.webkit.org/show_bug.cgi?id=84583
Source/WebCore:
Reviewed by Anders Carlsson.
In high-latency situations, having incremental rendering suppression
enabled makes for a worse experience due to the excessively long time
it takes for the load event to fire. So that clients that opt in to
incremental rendering suppression can mitigate this, add a configurable
timeout in which rendering is re-enabled if the load event has yet to
fire.
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::setReadyState): When the document transitions to
the loading state, start a timer; when it transitions to the completed
state, allow visual updates.
(WebCore::Document::setVisualUpdatesAllowed): If visual updates are
allowed, force a repaint. Otherwise, set a flag that suppresses
rendering.
(WebCore::Document::visualUpdatesSuppressionTimerFired): When the timer
fires, allow visual updates.
(WebCore::Document::implicitClose): Remove code that is now called in
setVisualUpdatesAllowed().
- dom/Document.h:
(WebCore::Document::visualUpdatesAllowed):
- page/Settings.cpp:
(WebCore::Settings::Settings):
- page/Settings.h:
(WebCore::Settings::setIncrementalRenderingSuppressionTimeoutInSeconds):
(WebCore::Settings::incrementalRenderingSuppressionTimeoutInSeconds):
Source/WebKit/mac:
Add a private WebPreference for setting the incremental rendering suppression timeout.
Reviewed by Anders Carlsson.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(-[WebPreferences setIncrementalRenderingSuppressionTimeoutInSeconds:]):
(-[WebPreferences incrementalRenderingSuppressionTimeoutInSeconds]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Apr 23, 2012:
- 11:40 PM Changeset in webkit [115004] by
-
- 1 copy in releases/WebKitGTK/webkit-1.8.1
Tagging the WebKitGTK+ 1.8.1 release
- 11:22 PM Changeset in webkit [115003] by
-
- 4 edits in releases/WebKitGTK/webkit-1.8
.: Update the versions for the 1.8.1 release.
- configure.ac:
Source/WebKit/gtk: Update the NEWS for the 1.8.1 release.
- NEWS:
- 11:22 PM Changeset in webkit [115002] by
-
- 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore
Merge 114980 - REGRESSION(113604): [Soup] Some pages that use synchronous XMLHttpRequests freeze the browser
https://bugs.webkit.org/show_bug.cgi?id=84560
Reviewed by Xan Lopez.
When kicking off a synchronous XMLHttpRequest, add one to the connection
limit. This ensures that when a page starts a synchronous request, while
already at the connection limit the request will not deadlock.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): Accept a new SoupSession
argument so that we can get the correct SoupSession for the networking context. Bump
the connection limit.
(WebCore::WebCoreSynchronousLoader::~WebCoreSynchronousLoader): Decrement the connection limit.
(WebCore::WebCoreSynchronousLoader::adjustMaxConnections): Added this helper.
(WebCoreSynchronousLoader): Added a new SoupSession member.
(WebCore::sessionFromContext): Added this helper.
(WebCore::ResourceHandleInternal::soupSession): Use the new sessionFromContext helper.
(WebCore::ResourceHandle::loadResourceSynchronously): Pass the SoupSession from the NetworkingContext
to the synchronous loader.
- 11:19 PM Changeset in webkit [115001] by
-
- 3 edits5 deletes in trunk/LayoutTests
Unreviewed. Fix incorrect test results for <datalist>
- fast/forms/datalist/datalist-expected.txt: Remove fallback content.
- fast/forms/datalist/datalist-nonoption-child-expected.txt: ditto.
- platform/chromium-linux/fast/forms/datalist/input-list-expected.png: Removed.
- platform/chromium-mac/fast/forms/datalist/input-list-expected.png: Removed.
- platform/chromium-mac/fast/forms/datalist/input-list-expected.txt: Removed.
- platform/chromium-win/fast/forms/datalist/input-list-expected.png: Removed.
- platform/chromium-win/fast/forms/datalist/input-list-expected.txt: Removed.
- 11:12 PM Changeset in webkit [115000] by
-
- 6 edits in trunk/Source
[chromium] Image masks are considered opaque incorrectly
https://bugs.webkit.org/show_bug.cgi?id=84275
Reviewed by Adrienne Walker.
Source/WebCore:
Match the behaviour of SkCanvas layers more closely while tracking
opaque paints. SkCanvas layers actually act as a separate device
(ie. pixels) and when the layer is popped off, the pixels are copied
down to the layer below.
While we can use the total clip to decide what pixels the the
drawing operation will affect in the final device, the blending
down through layers needs to consider each layer carefully.
In this case the image mask is drawn into a layer which is copied
down using the DestinationIn operation. Since the layer contains
non-opaque pixels, the DestinationIn copy can destroy opaque
areas in the next layer. We add OpaqueRegionSkia::FillByCopy to
distinguish the case where we are copying a block of pixels, and the
alpha values are essentially unknown.
Unit test: PlatformContextSkiaTest.trackImageMask
PlatformContextSkiaTest.trackImageMaskWithOpaqueRect
- platform/graphics/skia/OpaqueRegionSkia.cpp:
(WebCore::paintIsOpaque):
(WebCore::OpaqueRegionSkia::applyOpaqueRegionFromLayer):
(WebCore::OpaqueRegionSkia::pushCanvasLayer):
(WebCore::OpaqueRegionSkia::popCanvasLayer):
(WebCore::OpaqueRegionSkia::didDrawRect):
(WebCore::OpaqueRegionSkia::didDrawPath):
(WebCore::OpaqueRegionSkia::didDrawPoints):
(WebCore::OpaqueRegionSkia::didDrawBounded):
(WebCore::OpaqueRegionSkia::didDraw):
(WebCore::OpaqueRegionSkia::didDrawUnbounded):
(WebCore::OpaqueRegionSkia::markRectAsOpaque):
(WebCore::OpaqueRegionSkia::markRectAsNonOpaque):
(WebCore::OpaqueRegionSkia::markAllAsNonOpaque):
- platform/graphics/skia/OpaqueRegionSkia.h:
(OpaqueRegionSkia):
(CanvasLayerState):
- platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::restoreLayer):
Source/WebKit/chromium:
- tests/PlatformContextSkiaTest.cpp:
(WebCore):
(WebCore::TEST):
- 10:57 PM Changeset in webkit [114999] by
-
- 12 edits2 adds in trunk
Show the format indicator in a date field
https://bugs.webkit.org/show_bug.cgi?id=83872
Reviewed by Hajime Morita.
Source/WebCore:
Enable the fixed placeholder feature for the date type, and show
the editable date format as the fixed placeholder.
The format string is created by the following steps.
- Obtain a pattern string from ICU http://icu-project.org/apiref/icu4c/classSimpleDateFormat.html#details
- Replace a sequence of 'y', 'Y', 'M', or 'd' in the pattern with a natural language string such as "year", "month", or "day".
Test: fast/forms/date/date-fixed-placeholder.html
- html/DateInputType.cpp:
(WebCore::DateInputType::supportsPlaceholder): Added. Returns true.
(WebCore::DateInputType::usesFixedPlaceholder): Added. Returns true.
(WebCore::DateInputType::fixedPlaceholder):
Added. Calls localizedDateFormatText() provided by LocalizedDate.h.
- html/DateInputType.h:
(DateInputType): Add declarations of new override functions.
- platform/LocalizedStrings.h:
(WebCore): Add dateFormat{Year,Month,DayInMonth}Text()
- platform/text/ICULocale.cpp:
(WebCore::isICUYearSymbol): A function to improve redability.
(WebCore::isICUMonthSymbol): ditto.
(WebCore::isICUDayInMonthSymbol): ditto.
(WebCore::localizeFormat): Step 2 of the above description.
(WebCore::ICULocale::initializeLocalizedDateFormatText):
Step 1 of the above description.
(WebCore::ICULocale::localizedDateFormatText):
- platform/text/ICULocale.h:
(ICULocale): Add new functions and a data member.
- platform/text/LocalizedDate.h:
(WebCore): Add localizedDateFormatText().
- platform/text/LocalizedDateICU.cpp:
(WebCore::localizedDateFormatText):
Just call ICULocale::localizedDateFormatText().
Source/WebKit/chromium:
- src/LocalizedStrings.cpp:
(WebCore::dateFormatYearText): Added a stub.
(WebCore::dateFormatMonthText): ditto.
(WebCore::dateFormatDayInMonthText): ditto.
LayoutTests:
- fast/forms/date/date-fixed-placeholder-expected.txt: Added.
- fast/forms/date/date-fixed-placeholder.html: Added.
- platform/chromium/test_expectations.txt:
Mark date-appearance.html FAIL because of render dump change.
- 10:34 PM Changeset in webkit [114998] by
-
- 1 edit14 adds in trunk/LayoutTests
Getting baselines for new test landed in http://trac.webkit.org/changeset/114973
Not reviewed.
- platform/chromium-linux-x86/fast/html/details-marker-style-expected.txt: Added.
- platform/chromium-linux/fast/html/details-marker-style-expected.png: Added.
- platform/chromium-linux/fast/html/details-marker-style-expected.txt: Added.
- platform/chromium-mac-leopard/fast/html/details-marker-style-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/html/details-marker-style-expected.txt: Added.
- platform/chromium-mac/fast/html/details-marker-style-expected.png: Added.
- platform/chromium-mac/fast/html/details-marker-style-expected.txt: Added.
- platform/chromium-win-vista/fast/html/details-marker-style-expected.txt: Added.
- platform/chromium-win-xp/fast/html/details-marker-style-expected.txt: Added.
- platform/chromium-win/fast/html/details-marker-style-expected.png: Added.
- platform/chromium-win/fast/html/details-marker-style-expected.txt: Added.
- 10:12 PM Changeset in webkit [114997] by
-
- 4 edits in trunk/Source/WebCore
[V8] Pass Isolate to v8Array()
https://bugs.webkit.org/show_bug.cgi?id=84295
Reviewed by Nate Chapin.
The final objective is to pass Isolate around in V8 bindings.
This patch passes the Isolate to v8Array().
(GenerateNormalAttrGetter):
(NativeToJSValue):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::sequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::methodReturningSequenceCallback):
- bindings/v8/V8Binding.h:
(WebCore::v8Array):
- 10:07 PM Changeset in webkit [114996] by
-
- 4 edits in trunk/Source/WebCore
[V8] Pass Isolate to GetNamedProperty()
https://bugs.webkit.org/show_bug.cgi?id=84277
Reviewed by Nate Chapin.
The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to GetNamedProperty().
(GenerateHeader):
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::getter):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::GetNamedProperty):
(WebCore::V8HTMLDocument::allAccessorGetter):
- 9:27 PM Changeset in webkit [114995] by
-
- 7 edits in trunk/LayoutTests
Layout Test platform/chromium/compositing/filters/background-filter-blur-outsets.html is failing
https://bugs.webkit.org/show_bug.cgi?id=84072
Reviewed by Adrienne Walker.
Use onload and layoutTestController.display() to ensure the page is
loaded and compositor is ready before setting the background blur.
Also, smaller blur for faster test bots.
- platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png:
- platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.txt:
- platform/chromium/compositing/filters/background-filter-blur-off-axis.html:
- platform/chromium/compositing/filters/background-filter-blur-outsets.html:
- platform/chromium/compositing/filters/background-filter-blur.html:
- 9:27 PM Changeset in webkit [114994] by
-
- 6 edits in branches/chromium/1084
Merge 114699 - REGRESSION(r112177): Numbered list item rendered bulleted
https://bugs.webkit.org/show_bug.cgi?id=84216
Patch by David Barr <davidbarr@chromium.org> on 2012-04-19
Reviewed by Ryosuke Niwa.
Shorthands that imply omitted values cannot be derived from
an incomplete set of longhand rules.
No new tests; updated existing tests that should have caught this.
Source/WebCore:
- css/CSSParser.cpp:
(WebCore::CSSParser::parseTransformOriginShorthand):
Set implicit initial for Z when omitted.
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getShorthandValue):
LayoutTests:
- css3/flexbox/css-properties.html:
- fast/css/cssText-shorthand.html:
- fast/css/uri-token-parsing-expected.txt:
- fast/css/uri-token-parsing.html:
- fast/dom/css-dom-read-2-expected.txt:
TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10140014
- 9:19 PM Changeset in webkit [114993] by
-
- 13 edits in trunk/Source
[chromium] DomStorage event handling mods.
https://bugs.webkit.org/show_bug.cgi?id=84387
Source/WebCore:
Add a few simple inline getters to allow the source Document of a storage
event to be identified given a pointer to the source StorageArea so those
Documents can be excluded by the event dispatching logic.
Reviewed by Dimitri Glazkov.
No new tests. No new functionality or change in behavior.
- page/DOMWindow.h:
(WebCore::DOMWindow::optionalSessionStorage): simple inline getter to avoid construction where possible
(WebCore::DOMWindow::optionalLocalStorage): ditto
- storage/Storage.h:
(WebCore::Storage::area): simple inline getter
Source/WebKit/chromium:
Events are currently handled inconsistently. The dispatch of some events are
initiated from within webkit/webcore, the dispatch of other events are initiated
from the outside via the WebKit::WebStorageEventDispatcher interface. The existing
WebStorageEventDispatcher is not expressive enough to handle initiation all
events from the outside. There's a chunk of nearly replicated code in there
that shouldn't be. The existing code has several FIXMEs related to making
this better.
The current state of things in webkit/webcore is also blocking development of some
overall performance improvements to chromium's implemention of this feature (getting
rid of sync ipcs for each access and adding a renderer-side caching layer).
To facilitate the perf improvements, this patch adds WebKit API to allow all
DomStorage events to be initiated from the outside. This is needed because
there will be an async latency between setting an item and receiving the
'oldValue' from the main browser process which is required to raise the
mutation event.
This is the first of a multi-sided sequence of patches to make this transition.
wkpatch 1: add the new wider WebKit API and impl
crpatch 2: start using the new wider WebKit API
wkpatch 3: cleanup, delete the old WebKit API and impl
xxxxxxx 4/5: cleanup, remove extra params from new API whose only purpose was to allow the transition
Reviewed by Dimitri Glazkov.
- public/WebStorageEventDispatcher.h: Add new API to dispatch events.
- public/WebStorageNamespace.h: Add new API to test for namespace equality.
- src/StorageAreaProxy.cpp:
(WebCore::StorageAreaProxy::dispatchLocalStorageEvent): implementation of the new API
(WebCore::StorageAreaProxy::dispatchSessionStorageEvent): implementation of the new API
(WebCore::StorageAreaProxy::IsEventSource): a helper method
(WebCore::StorageAreaProxy::FindPageWithSessionStorageNamespace): a helper method
- src/StorageAreaProxy.h:
- src/StorageEventDispatcherImpl.cpp: added a FIXME comment to delete soon
- src/StorageNamespaceProxy.cpp:
(WebCore::StorageNamespaceProxy::IsSameNamespace): plumbing to call the new API
- src/StorageNamespaceProxy.h:
- src/WebStorageEventDispatcherImpl.cpp:
(WebKit::WebStorageEventDispatcher::dispatchLocalStorageEvent): plumbing to call the new impl
(WebKit::WebStorageEventDispatcher::dispatchSessionStorageEvent): plumbing to call the new impl
- src/WebStorageEventDispatcherImpl.h: added a FIXME comment to delete soon
- 8:43 PM Changeset in webkit [114992] by
-
- 61 edits2 adds in trunk
Change ImageData to reference Uint8ClampedArray rather than CanvasPixelArray
https://bugs.webkit.org/show_bug.cgi?id=73011
Reviewed by Oliver Hunt.
Source/WebCore:
Changed ImageData to contain Uint8ClampedArray instead of ByteArray
per current HTML5 spec.
In order to avoid introducing large data copies, it was necessary to
switch a few other places in WebKit to use Uint8ClampedArray at the
same time, most notably the FilterEffect implementation, portions of
ImageBuffer, and a couple of places in the image encoders.
Note that the change in method name from "get" to "item" occurred
because JSC's autogenerated indexed getters reference a method
called "item". If desired, a convenience method could be
introduced to avoid the renamings in the FilterEffect classes.
With these changes, ByteArray and some custom code in JavaScriptCore
actually become unreferenced, and can be deleted. This deletion will
be done separately in Bug 83655, to keep the size of this patch
manageable.
Test: fast/canvas/imagedata-contains-uint8clampedarray.html
- bindings/js/JSImageDataCustom.cpp:
(WebCore::toJS):
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneDeserializer::readTerminal):
- bindings/v8/SerializedScriptValue.cpp:
- bindings/v8/custom/V8ImageDataCustom.cpp:
(WebCore::toV8):
- bridge/qt/qt_pixmapruntime.cpp:
(JSC::Bindings::QtPixmapToImageDataMethod::invoke):
- html/ImageData.cpp:
(WebCore::ImageData::create):
(WebCore::ImageData::ImageData):
- html/ImageData.h:
(ImageData):
(WebCore::ImageData::data):
- html/ImageData.idl:
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::createEmptyImageData):
(WebCore::CanvasRenderingContext2D::getImageData):
(WebCore::CanvasRenderingContext2D::putImageData):
- platform/graphics/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::extractImageData):
- platform/graphics/ImageBuffer.cpp:
(WebCore::ImageBuffer::genericConvertToLuminanceMask):
- platform/graphics/ImageBuffer.h:
- platform/graphics/ShadowBlur.cpp:
(WebCore::ShadowBlur::blurShadowBuffer):
- platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::getImageData):
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageDataToDataURL):
- platform/graphics/cg/ImageBufferDataCG.cpp:
(WebCore::ImageBufferData::getData):
(WebCore::ImageBufferData::putData):
- platform/graphics/cg/ImageBufferDataCG.h:
(ImageBufferData):
- platform/graphics/filters/FEBlend.cpp:
(WebCore::FEBlend::platformApplySoftware):
- platform/graphics/filters/FEColorMatrix.cpp:
(WebCore::effectType):
(WebCore::FEColorMatrix::platformApplySoftware):
- platform/graphics/filters/FEComponentTransfer.cpp:
(WebCore::FEComponentTransfer::platformApplySoftware):
- platform/graphics/filters/FEComposite.cpp:
(WebCore::FEComposite::platformArithmeticSoftware):
(WebCore::FEComposite::platformApplySoftware):
- platform/graphics/filters/FEComposite.h:
- platform/graphics/filters/FEConvolveMatrix.cpp:
(WebCore::setDestinationPixels):
(WebCore::FEConvolveMatrix::fastSetInteriorPixels):
(WebCore::FEConvolveMatrix::fastSetOuterPixels):
(WebCore::FEConvolveMatrix::platformApplySoftware):
- platform/graphics/filters/FEConvolveMatrix.h:
(PaintingData):
- platform/graphics/filters/FECustomFilter.cpp:
(WebCore::FECustomFilter::platformApplySoftware):
(WebCore::FECustomFilter::bindProgramAndBuffers):
- platform/graphics/filters/FECustomFilter.h:
(JSC):
(FECustomFilter):
- platform/graphics/filters/FEDisplacementMap.cpp:
(WebCore::FEDisplacementMap::platformApplySoftware):
- platform/graphics/filters/FEDropShadow.cpp:
(WebCore::FEDropShadow::platformApplySoftware):
- platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::boxBlur):
(WebCore::FEGaussianBlur::platformApplyGeneric):
(WebCore::FEGaussianBlur::platformApply):
(WebCore::FEGaussianBlur::platformApplySoftware):
- platform/graphics/filters/FEGaussianBlur.h:
(PlatformApplyParameters):
(FEGaussianBlur):
- platform/graphics/filters/FELighting.cpp:
(WebCore::FELighting::LightingData::topLeft):
(WebCore::FELighting::LightingData::topRow):
(WebCore::FELighting::LightingData::topRight):
(WebCore::FELighting::LightingData::leftColumn):
(WebCore::FELighting::LightingData::interior):
(WebCore::FELighting::LightingData::rightColumn):
(WebCore::FELighting::LightingData::bottomLeft):
(WebCore::FELighting::LightingData::bottomRow):
(WebCore::FELighting::LightingData::bottomRight):
(WebCore::FELighting::inlineSetPixel):
(WebCore::FELighting::drawLighting):
(WebCore::FELighting::platformApplySoftware):
- platform/graphics/filters/FELighting.h:
(LightingData):
(FELighting):
- platform/graphics/filters/FEMorphology.cpp:
(WebCore::FEMorphology::platformApplyGeneric):
(WebCore::FEMorphology::platformApplySoftware):
- platform/graphics/filters/FEMorphology.h:
(PaintingData):
- platform/graphics/filters/FETurbulence.cpp:
(WebCore::FETurbulence::fillRegion):
(WebCore::FETurbulence::platformApplySoftware):
- platform/graphics/filters/FETurbulence.h:
(FillRegionParameters):
(FETurbulence):
- platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::forceValidPreMultipliedPixels):
(WebCore::FilterEffect::asUnmultipliedImage):
(WebCore::FilterEffect::asPremultipliedImage):
(WebCore::FilterEffect::copyImageBytes):
(WebCore::FilterEffect::copyUnmultipliedImage):
(WebCore::FilterEffect::copyPremultipliedImage):
(WebCore::FilterEffect::createUnmultipliedImageResult):
(WebCore::FilterEffect::createPremultipliedImageResult):
- platform/graphics/filters/FilterEffect.h:
(FilterEffect):
- platform/graphics/filters/arm/FEGaussianBlurNEON.h:
(WebCore::FEGaussianBlur::platformApplyNeon):
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
- platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::getImageData):
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::getImageData):
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
- platform/graphics/texmap/TextureMapperGL.cpp:
- platform/graphics/wince/ImageBufferWinCE.cpp:
(WebCore::getImageData):
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
- platform/graphics/wx/ImageBufferWx.cpp:
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
- platform/image-encoders/skia/JPEGImageEncoder.cpp:
(WebCore::JPEGImageEncoder::encode):
- platform/image-encoders/skia/PNGImageEncoder.cpp:
(WebCore::PNGImageEncoder::encode):
- platform/image-encoders/skia/WEBPImageEncoder.cpp:
(WebCore::WEBPImageEncoder::encode):
Source/WebKit/chromium:
- src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DPrivate::paintRenderingResultsToImageData):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::doPixelReadbackToCanvas):
Source/WTF:
- wtf/ArrayBuffer.h:
(ArrayBuffer):
(WTF::ArrayBuffer::create):
(WTF::ArrayBuffer::createUninitialized):
(WTF):
(WTF::ArrayBufferContents::tryAllocate):
- wtf/TypedArrayBase.h:
(WTF::TypedArrayBase::createUninitialized):
(TypedArrayBase):
- wtf/Uint8ClampedArray.h:
(Uint8ClampedArray):
(WTF::Uint8ClampedArray::createUninitialized):
(WTF):
(WTF::Uint8ClampedArray::zeroFill):
LayoutTests:
- fast/canvas/imagedata-contains-uint8clampedarray-expected.txt: Added.
- fast/canvas/imagedata-contains-uint8clampedarray.html: Added.
- fast/dom/Window/script-tests/postmessage-clone.js:
- fast/dom/Window/window-postmessage-clone-expected.txt:
- platform/chromium/fast/dom/Window/window-postmessage-clone-expected.txt:
- platform/gtk/fast/dom/Window/window-postmessage-clone-expected.txt:
- 8:39 PM Changeset in webkit [114991] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Remove deleted files from WebCore.gypi and fix typo
https://bugs.webkit.org/show_bug.cgi?id=84651
Patch by Ryan Sleevi <rsleevi@chromium.org> on 2012-04-23
Reviewed by Ryosuke Niwa.
No new tests. No behavior change.
- WebCore.gypi:
Remove references to PlatformMouseEventQt.cpp and WheelEventQt.cpp. Add a missing comma.
- 8:29 PM Changeset in webkit [114990] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, fix wrong paths of js-test-*.js.
https://bugs.webkit.org/show_bug.cgi?id=82871
- fast/forms/datalist/input-list.html:
- 8:21 PM Changeset in webkit [114989] by
-
- 3 edits2 adds in trunk
[V8] Fix issue with trying to access a constructor in a frame that has been removed
https://bugs.webkit.org/show_bug.cgi?id=84640
Reviewed by Kentaro Hara.
Source/WebCore:
This regressed in r113250. Now we do what we did before and return undefined if the frame
does not have a context.
Test: fast/dom/constructor-in-removed-frame.html
- bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::constructorForType):
LayoutTests:
- fast/dom/constructor-in-removed-frame-expected.txt: Added.
- fast/dom/constructor-in-removed-frame.html: Added.
- 8:19 PM Changeset in webkit [114988] by
-
- 2 edits in trunk/Source/WebCore
Oscillator::setWaveTable() should not reset oscillator phase
https://bugs.webkit.org/show_bug.cgi?id=84647
Reviewed by Kenneth Russell.
- Modules/webaudio/Oscillator.cpp:
(WebCore::Oscillator::setWaveTable):
- 8:15 PM Changeset in webkit [114987] by
-
- 5 edits in trunk/Source/WebKit/chromium
Crash when the page with a calendar picker is scrolled
https://bugs.webkit.org/show_bug.cgi?id=84287
Reviewed by Hajime Morita.
Use the same ownership model as WebPopupMenuImpl's.
- src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::close):
Clear m_widgetClient to avoid furthur access to it. deref instead of delete.
(WebKit::WebPagePopupImpl::closePopup):
Do not call closeWidgetSoon() if close() was already called.
(WebKit::WebPagePopup::create):
Add a reference. Add explanation of the ownership.
- src/WebPagePopupImpl.h:
(WebPagePopupImpl): Make this RefCounted. Make the destuctor public.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl): No need to clear m_pagePopup explicitly.
(WebKit::WebViewImpl::openPagePopup): Need to use .get() because m_pagePopup is a RefPtr.
(WebKit::WebViewImpl::closePagePopup): ditto.
(WebKit::WebViewImpl::hidePopups): ditto.
- src/WebViewImpl.h: Make m_pagePopup a RefPtr.
- 7:11 PM Changeset in webkit [114986] by
-
- 3 edits in trunk/Source/WebCore
[V8][Refactoring] Remove V8Proxy::throwSyntaxError()
https://bugs.webkit.org/show_bug.cgi?id=84627
Reviewed by Nate Chapin.
This patch removes V8Proxy::throwSyntaxError()
since it is no longer used.
No tests. No change in behavior.
- bindings/v8/V8Proxy.cpp:
- bindings/v8/V8Proxy.h:
(V8Proxy):
- 7:07 PM Changeset in webkit [114985] by
-
- 2 edits in trunk/Source/WTF
Enable parallel GC for BlackBerry.
https://bugs.webkit.org/show_bug.cgi?id=84633
Reviewed by Antonio Gomes.
- wtf/Platform.h:
- 7:01 PM Changeset in webkit [114984] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Build failure when DEBUG_FAT_FINGER is enabled
https://bugs.webkit.org/show_bug.cgi?id=84563
Reviewed by Antonio Gomes.
Fat Finger log code uses obsolete IntRect::toString() for logging,
which was first implemented interally and removed later.
- WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::findIntersectingRegions):
- 7:00 PM Changeset in webkit [114983] by
-
- 18 edits1 move2 deletes in trunk/Source
[chromium] Use TextureLayerChromium for WebGL content instead of a dedicated layer type
https://bugs.webkit.org/show_bug.cgi?id=84311
Reviewed by Adrienne Walker.
Source/Platform:
Remove some unused getters.
- chromium/public/WebExternalTextureLayer.h:
(WebExternalTextureLayer):
Source/WebCore:
WebGL content's interface with the compositor can be expressed in terms of two basic operations:
1.) Do some stuff
2.) Provide a texture ID for the compositor to use
This implements (1) in DrawingBufferChromium and uses the already-existing TextureLayerChromium to handle (2).
This cuts down the compositor interface significantly and allows for more code reuse in exchange for more code
in TextureLayerChromium to handle the features WebGL needs.
- WebCore.gypi:
- platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::~DrawingBuffer):
(DrawingBufferPrivate):
(WebCore::DrawingBufferPrivate::DrawingBufferPrivate):
(WebCore::DrawingBufferPrivate::~DrawingBufferPrivate):
(WebCore::DrawingBufferPrivate::layer):
(WebCore):
(WebCore::DrawingBuffer::platformLayer):
- platform/graphics/chromium/LayerRendererChromium.cpp:
- platform/graphics/chromium/TextureLayerChromium.h:
(TextureLayerChromiumClient):
(WebCore::TextureLayerChromiumClient::~TextureLayerChromiumClient):
(WebCore):
(TextureLayerChromium):
(WebCore::TextureLayerChromium::clearClient):
- platform/graphics/chromium/WebGLLayerChromium.cpp: Removed.
- platform/graphics/chromium/WebGLLayerChromium.h: Removed.
- platform/graphics/gpu/DrawingBuffer.h:
(WebCore):
(WebCore::DrawingBuffer::graphicsContext3D):
(DrawingBuffer):
Source/WebKit/chromium:
- WebKit.gypi:
- src/WebExternalTextureLayer.cpp:
(WebKit::WebExternalTextureLayer::create):
- src/WebLayer.cpp:
- tests/WebGLLayerChromiumTest.cpp: Removed.
- tests/WebLayerTest.cpp:
- 6:50 PM Changeset in webkit [114982] by
-
- 2 edits in trunk/Websites/webkit.org
Add notice about running xcode-select before using Xcode 4.3.2 command line tools
Rubber-stamped by Eric Seidel.
Before you can use the Xcode 4.3.2 command line tools, you must either run
sudo xcode-select -switch /Applications/Xcode.app or set the environment variable
DEVELOPER_DIR to point to the Xcode developer tools directory.
- building/tools.html:
- 6:50 PM Changeset in webkit [114981] by
-
- 14 edits in trunk/Source
IndexedDB: remove IDB(Index|ObjectStore)BackendImpl::get/getKey for IDBKey
https://bugs.webkit.org/show_bug.cgi?id=84285
Patch by Alec Flett <alecflett@chromium.org> on 2012-04-23
Reviewed by Dimitri Glazkov.
Source/WebCore:
No new tests required, this code is no longer called.
This is old code supporting IDBKey-based lookup, supplanted by
IDBKeyRange. Now that chromium IPC/proxy code has landed,
these functions can be removed.
- Modules/indexeddb/IDBIndexBackendInterface.h:
(IDBIndexBackendInterface):
- Modules/indexeddb/IDBObjectStoreBackendInterface.h:
(IDBObjectStoreBackendInterface):
Source/WebKit/chromium:
This is old code supporting IDBKey-based lookup, supplanted by
IDBKeyRange. Now that chromium IPC/proxy code has landed,
these functions can be removed.
- public/WebIDBIndex.h:
- public/WebIDBObjectStore.h:
- src/IDBIndexBackendProxy.cpp:
- src/IDBIndexBackendProxy.h:
(IDBIndexBackendProxy):
- src/IDBObjectStoreBackendProxy.cpp:
- src/IDBObjectStoreBackendProxy.h:
(IDBObjectStoreBackendProxy):
- src/WebIDBIndexImpl.cpp:
- src/WebIDBIndexImpl.h:
(WebIDBIndexImpl):
- src/WebIDBObjectStoreImpl.cpp:
- src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl):
- 6:42 PM WebKitGTK/1.8.x edited by
- (diff)
- 6:33 PM Changeset in webkit [114980] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(113604): [Soup] Some pages that use synchronous XMLHttpRequests freeze the browser
https://bugs.webkit.org/show_bug.cgi?id=84560
Reviewed by Xan Lopez.
When kicking off a synchronous XMLHttpRequest, add one to the connection
limit. This ensures that when a page starts a synchronous request, while
already at the connection limit the request will not deadlock.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): Accept a new SoupSession
argument so that we can get the correct SoupSession for the networking context. Bump
the connection limit.
(WebCore::WebCoreSynchronousLoader::~WebCoreSynchronousLoader): Decrement the connection limit.
(WebCore::WebCoreSynchronousLoader::adjustMaxConnections): Added this helper.
(WebCoreSynchronousLoader): Added a new SoupSession member.
(WebCore::sessionFromContext): Added this helper.
(WebCore::ResourceHandleInternal::soupSession): Use the new sessionFromContext helper.
(WebCore::ResourceHandle::loadResourceSynchronously): Pass the SoupSession from the NetworkingContext
to the synchronous loader.
- 6:31 PM Changeset in webkit [114979] by
-
- 18 edits in branches/chromium/1084/Source
Merge 114800 - [chromium] Plumb a compositor surface ready notification through to the threaded compositor
https://bugs.webkit.org/show_bug.cgi?id=84305
Patch by James Robinson <jamesr@chromium.org> on 2012-04-20
Reviewed by Adrienne Walker.
Source/Platform:
Add a notification for when the compositor surface associated with a given view is ready to use.
- chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):
Source/WebCore:
Plumb setSurfaceReady through to the scheduler.
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::setSurfaceReady):
(WebCore):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
- platform/graphics/chromium/cc/CCProxy.h:
(CCProxy):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::setSurfaceReady):
(WebCore):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(CCSingleThreadProxy):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::setSurfaceReady):
(WebCore):
(WebCore::CCThreadProxy::setSurfaceReadyOnImplThread):
(WebCore::CCThreadProxy::initializeImplOnImplThread):
- platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
Source/WebKit/chromium:
Adds a notification to WebWidget for when the compositor surface is ready to use. This exists to fix a race
condition when WebKit requires that we enter compositing mode but we haven't completed initialization of the
native window/etc backing the WebWidget, and we can't block for this initialization to complete without inducing
deadlocks. In this situation, we proceed as usual except that we can't attempt to use the compositor context or
it will fail.
- public/WebWidget.h:
(WebWidget):
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::setSurfaceReady):
(WebKit):
- src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::setCompositorSurfaceReady):
(WebKit):
- src/WebPagePopupImpl.h:
(WebPagePopupImpl):
- src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::setCompositorSurfaceReady):
(WebKit):
- src/WebPopupMenuImpl.h:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setCompositorSurfaceReady):
(WebKit):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
- src/WebViewImpl.h:
(WebViewImpl):
TBR=jamesr@chromium.org
BUG=123356
Review URL: https://chromiumcodereview.appspot.com/10199014
- 6:27 PM Changeset in webkit [114978] by
-
- 3 edits in trunk/Websites/webkit.org
Explicitly mention Xcode version 4.3.2 in Mac debug instructions
Rubber-stamped by Eric Seidel.
The build location instructions at the top of page building/{debug-mac-uiprocess.html, debug.html}
are specific to Xcode 4.3.2.
- building/debug-mac-uiprocess.html: Substitute "Xcode 4.3.2" for "Xcode 4".
- building/debug.html: Ditto.
- 6:25 PM Changeset in webkit [114977] by
-
- 9 edits in branches/chromium/1084/Source
Merge 114599 - [chromium] Add canBeginFrame state to CCSchedulerStateMachine to suppress initialization before our surface is available
https://bugs.webkit.org/show_bug.cgi?id=84301
Reviewed by Adrienne Walker.
Source/WebCore:
If our composited surface isn't ready yet, then the compositor may initialize in a state where the first
makeContextCurrent() fails. This adds a new state to the scheduler that we can use to suppress initialization
until we get notified that the surface is ready. I'll add the plumbing for actually notifying in a follow-up.
Updated CCSchedulerTest / CCSchedulerStateMachineTest unit tests.
- platform/graphics/chromium/cc/CCScheduler.cpp:
(WebCore::CCScheduler::setCanBeginFrame):
(WebCore):
- platform/graphics/chromium/cc/CCScheduler.h:
(CCScheduler):
- platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::nextAction):
- platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
(WebCore::CCSchedulerStateMachine::setCanBeginFrame):
(CCSchedulerStateMachine):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::initializeImplOnImplThread):
Source/WebKit/chromium:
Update unit tests for new canBeginFrame bit.
- tests/CCSchedulerStateMachineTest.cpp:
(WebCore::TEST):
(WebCore):
- tests/CCSchedulerTest.cpp:
(WebKitTests::TEST):
TBR=jamesr@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10202004
- 6:25 PM Changeset in webkit [114976] by
-
- 7 edits2 deletes in trunk
Unreviewed, rolling out r114965.
http://trac.webkit.org/changeset/114965
https://bugs.webkit.org/show_bug.cgi?id=84665
Four new resource load delegate test failures (Requested by
jernoble on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-23
Source/WebCore:
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didFinishLoading):
(WebCore::SubresourceLoader::didFail):
(WebCore::SubresourceLoader::willCancel):
(WebCore::SubresourceLoader::releaseResources):
LayoutTests:
- http/tests/cache/cancel-during-failure-crash-expected.txt: Removed.
- http/tests/cache/cancel-during-failure-crash.html: Removed.
- platform/chromium-mac/security/block-test-expected.txt:
- platform/chromium-win/security/block-test-expected.txt:
- platform/gtk/security/block-test-expected.txt:
- platform/mac/security/block-test-expected.txt:
- 6:12 PM Changeset in webkit [114975] by
-
- 13 edits in trunk
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=84649
RenderMathMLOperator currently ignores font families, fails
to use Stix
Reviewed by Dan Bernstein.
This patch makes RenderMathMLOperator honor the font-family
list. This means that by default, Stix glyphs will now be
used for operators just like for other MathML content.
Unfortunately, just doing that resulted in a bug because of
the fragile hardcoded glyph sizes. The Stix vertical bar
glyph is much smaller than the code assumed any glyphs would
be. That code should be re-written, but in the meantime, I
put a fix in place to try to make it work for small glyphs.
These new functions should be used instead of accessing
gGlyphHeight or gGlyphLineHeight directly. If the glyph is
smaller than the expected hardcoded value, then the actual
glyph height is used, and a new line height based on the
glyph height is used.
(WebCore::RenderMathMLOperator::glyphHeightForCharacter):
(WebCore::RenderMathMLOperator::lineHeightForCharacter):
Use the style's FontDescription to honor the font family
list and the style's FontSelector to honor @font-face.
Also use glyphHeightForCharacter() instead of gGlyphHeight.
And now that createGlyph() takes a lineHeight, use
lineHeightForCharacter() to determine the right value.
(WebCore::RenderMathMLOperator::updateFromElement):
size was an ambiguous variable name, so I renamed it to the
more accurate maxHeightForRenderer. This function also now
takes a lineHeight instead of using gGlyphLineHeight. And
again, use the style's FontDescription and FontSelector.
(WebCore::RenderMathMLOperator::createStackableStyle):
Re-name size to maxHeightForRenderer, and take lineHeight as
a parameter.
(WebCore::RenderMathMLOperator::createGlyph):
- rendering/mathml/RenderMathMLOperator.h:
(RenderMathMLOperator):
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=84649
RenderMathMLOperator currently ignores font families, fails to use Stix
Reviewed by Dan Bernstein.
Metrics are slightly different now that Stix glyphs are being used for operators.
- platform/mac/mathml/presentation/fenced-expected.txt:
- platform/mac/mathml/presentation/fenced-mi-expected.txt:
- platform/mac/mathml/presentation/mo-expected.txt:
- platform/mac/mathml/presentation/mo-stretch-expected.txt:
- platform/mac/mathml/presentation/over-expected.txt:
- platform/mac/mathml/presentation/row-alignment-expected.txt:
- platform/mac/mathml/presentation/row-expected.txt:
- platform/mac/mathml/presentation/sub-expected.txt:
- platform/mac/mathml/presentation/subsup-expected.txt:
- 6:10 PM Changeset in webkit [114974] by
-
- 23 edits2 adds in trunk
Return value from executed script in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=79851
Patch by Eriq Augustine <eaugusti@chromium.org> on 2012-04-23
Reviewed by Adam Barth.
Source/WebCore:
Providing a varaiant of evaluateScriptInIsolatedWorld that
returns the value of the evaluated script.
Test: platform/chromium/http/tests/misc/execute-and-return-value.html
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::evaluateInIsolatedWorld):
- bindings/v8/ScriptController.h:
(ScriptController):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::evaluateInIsolatedWorld):
- bindings/v8/V8Proxy.h:
(V8Proxy):
Source/WebKit/chromium:
Providing a variant of evaluateScriptInIsolatedWorld that
returns the value of the evaluated script.
- public/WebFrame.h:
(WebFrame):
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::executeScriptInIsolatedWorldAndReturnValues):
(WebKit):
- src/WebFrameImpl.h:
(WebKit):
(WebFrameImpl):
Tools:
Adding a function to LayoutTestController that evaluates a script in
an isolated wold an returns the result of the evaluation.
- DumpRenderTree/LayoutTestController.cpp:
(evaluateScriptInIsolatedWorldAndReturnValue):
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
- DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
(LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::setXSSAuditorEnabled):
(LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
- DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController):
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
LayoutTests:
Testing executing a script and getting the result of that script.
- platform/chromium/http/tests/misc/execute-and-return-value-expected.txt: Added.
- platform/chromium/http/tests/misc/execute-and-return-value.html: Added.
- 5:57 PM Changeset in webkit [114973] by
-
- 3 edits4 adds in trunk
RenderDetailsMarker should draw the triangle inside the content box
https://bugs.webkit.org/show_bug.cgi?id=84557
Reviewed by Hajime Morita.
Source/WebCore:
RenderDetailsMarker didn't support cases in which a marker has
borders and/or padings, or non-square size.
Test: fast/html/details-marker-style.html
- rendering/RenderDetailsMarker.cpp:
(WebCore::RenderDetailsMarker::getPath):
Scale by contentWidth() and contentHeight().
(WebCore::RenderDetailsMarker::paint):
Move the trianle origin by the ammount of left/top borders and paddings.
LayoutTests:
- fast/html/details-marker-style.html: Added.
- platform/mac-snowleopard/fast/html/details-marker-style-expected.png: Added.
- platform/mac-snowleopard/fast/html/details-marker-style-expected.txt: Added.
- 5:52 PM Changeset in webkit [114972] by
-
- 9 edits in trunk/Source/WebCore
[V8] Pass Isolate to toV8() (Part6)
https://bugs.webkit.org/show_bug.cgi?id=84273
Reviewed by Nate Chapin.
The objective is to pass Isolate to all toV8()s.
Since there are a lot of toV8()s, I'll make the change
step by step. This patch passes Isolate to toV8() in
several custom bindings.
No tests. No change in behavior.
- bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
(WebCore::getNamedItems):
(WebCore::getItem):
(WebCore::V8HTMLAllCollection::namedPropertyGetter):
(WebCore::V8HTMLAllCollection::itemCallback):
(WebCore::V8HTMLAllCollection::namedItemCallback):
(WebCore::V8HTMLAllCollection::callAsFunctionCallback):
- bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::getNamedItems):
(WebCore::V8HTMLCollection::namedPropertyGetter):
(WebCore::V8HTMLCollection::namedItemCallback):
(WebCore::toV8):
- bindings/v8/custom/V8SVGPathSegCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8StyleSheetCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8StyleSheetListCustom.cpp:
(WebCore::V8StyleSheetList::namedPropertyGetter):
- bindings/v8/custom/V8TrackEventCustom.cpp:
(WebCore::V8TrackEvent::trackAccessorGetter):
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
(WebCore::getObjectParameter):
(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getExtensionCallback):
(WebCore::V8WebGLRenderingContext::getFramebufferAttachmentParameterCallback):
(WebCore::V8WebGLRenderingContext::getParameterCallback):
(WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
(WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
(WebCore::V8WebGLRenderingContext::getUniformCallback):
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::responseAccessorGetter):
- bindings/v8/custom/V8XSLTProcessorCustom.cpp:
(WebCore::V8XSLTProcessor::transformToFragmentCallback):
(WebCore::V8XSLTProcessor::transformToDocumentCallback):
- 5:47 PM Changeset in webkit [114971] by
-
- 5 edits in trunk/Source/WebCore
Move the content of LocalizedCalendarICU.cpp and LocalizedDateICU.cpp to ICULocale.cpp.
https://bugs.webkit.org/show_bug.cgi?id=84568
Reviewed by Hajime Morita.
Move it to ICULocal.cpp because we want to share UDateFormat
object in LocalizedDate functions and LocalizedCalendar functions,
and it becomes easier to cache the UDateFormat object, and making
unit tests for these functions easier.
No new tests because of no bahevior changes.
- platform/text/ICULocale.cpp:
(WebCore::ICULocale::ICULocale): Initialize new members.
(WebCore::ICULocale::~ICULocale): Delete m_shortDateFormat.
(WebCore::ICULocale::initializeShortDateFormat):
Moved from creteShortDateFormatter of LocalizedDateICU.cpp.
(WebCore::ICULocale::parseLocalizedDate):
Moved from LocalizedDate.cpp, use m_shortDateFormat.
(WebCore::ICULocale::formatLocalizedDate): ditto.
(WebCore::ICULocale::createLabelVector):
Moved from LocalizedCalendarICU.cpp, use m_shortDateFormat.
(WebCore::createFallbackMonthLabels): Moved from LocalizedCalendarICU.cpp.
(WebCore::createFallbackWeekDayShortLabels): ditto.
(WebCore::ICULocale::initializeCalendar):
lazy initialization of m_monthLabels, m_weekDayShortLabels, and m_firstDayOfWeek.
(WebCore::ICULocale::monthLabels):
(WebCore::ICULocale::weekDayShortLabels):
(WebCore::ICULocale::firstDayOfWeek):
- platform/text/ICULocale.h:
(ICULocale): Add declarations.
- platform/text/LocalizedCalendarICU.cpp:
(WebCore::monthLabels): Use ICULocale::currentLocale().
(WebCore::weekDayShortLabels): ditto.
(WebCore::firstDayOfWeek): ditto.
- platform/text/LocalizedDateICU.cpp:
(WebCore::parseLocalizedDate): ditto.
(WebCore::formatLocalizedDate): ditto.
- 5:39 PM Changeset in webkit [114970] by
-
- 5 edits1 copy1 add in trunk/Source
Move AudioDestinationChromium FIFO class to its own class.
https://bugs.webkit.org/show_bug.cgi?id=84058
Patch by Raymond Toy <Raymond Toy> on 2012-04-23
Reviewed by Chris Rogers.
Source/WebCore:
Current tests cover the changes.
- WebCore.gypi: Update with new files.
- platform/audio/AudioPullFIFO.cpp: Copied from Source/WebKit/chromium/src/AudioDestinationChromium.cpp.
(WebCore): Renamed old class the AudioPullFIFO.
(WebCore::AudioPullFIFO::AudioPullFIFO):
(WebCore::AudioPullFIFO::consume):
(WebCore::AudioPullFIFO::findWrapLengths):
(WebCore::AudioPullFIFO::fillBuffer):
- platform/audio/AudioPullFIFO.h: Added.
(WebCore):
(AudioPullFIFO):
(WebCore::AudioPullFIFO::updateIndex):
Source/WebKit/chromium:
Remove private FIFO class and use new AudioPullFIFO class.
- src/AudioDestinationChromium.cpp:
(WebCore::AudioDestinationChromium::AudioDestinationChromium):
- src/AudioDestinationChromium.h:
(AudioDestinationChromium):
- 5:36 PM Changeset in webkit [114969] by
-
- 4 edits3 adds in trunk
DFG OSR exit should ensure that all variables have been initialized
https://bugs.webkit.org/show_bug.cgi?id=84653
<rdar://problem/11258183>
Source/JavaScriptCore:
Reviewed by Gavin Barraclough.
Initialize all uncaptured dead variables to undefined on OSR exit.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::ValueSource::dump):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
- dfg/DFGSpeculativeJIT.h:
LayoutTests:
Reviewed by Gavin Barraclough.
- fast/js/dfg-dead-variable-on-exit-expected.txt: Added.
- fast/js/dfg-dead-variable-on-exit.html: Added.
- fast/js/script-tests/dfg-dead-variable-on-exit.js: Added.
(foo):
- 5:24 PM Changeset in webkit [114968] by
-
- 4 edits in branches/subpixellayout/Source
Adding a flag to disable sub-pixel layout, defaulting to on.
- 5:19 PM Changeset in webkit [114967] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt
- 5:14 PM Changeset in webkit [114966] by
-
- 12 edits in branches/chromium/1084/Source/WebCore
Merge 114475 - [chromium] Ensure RateLimiter waits for Swapbuffers completion
https://bugs.webkit.org/show_bug.cgi?id=83649
Patch by John Bauman <jbauman@chromium.org> on 2012-04-17
Reviewed by James Robinson.
We were waiting only on the canvas context, which with the new GPU
scheduling was causing the RateLimiter not to ratelimit enough. We
need to insert no-op commands in the compositor context, so that we'll
wait for the canvas context and SwapBuffers as well.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::doNoOp):
(WebCore):
- platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
- platform/graphics/chromium/RateLimiter.cpp:
(WebCore::RateLimiter::create):
(WebCore::RateLimiter::RateLimiter):
(WebCore::RateLimiter::rateLimitContext):
- platform/graphics/chromium/RateLimiter.h:
(RateLimiterClient):
(WebCore):
(RateLimiter):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::startRateLimiter):
(WebCore::CCLayerTreeHost::rateLimit):
(WebCore):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
- platform/graphics/chromium/cc/CCProxy.h:
(CCProxy):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::forceNoOpCommand):
(WebCore):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(CCSingleThreadProxy):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::forceNoOpCommand):
(WebCore):
(WebCore::CCThreadProxy::forceNoOpCommandOnImplThread):
- platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
TBR=jbauman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10201008
- 5:14 PM Changeset in webkit [114965] by
-
- 7 edits2 adds in trunk
Source/WebCore: REGRESSION (r100311): YummySoup app crashes when trying to print
https://bugs.webkit.org/show_bug.cgi?id=83918
Reviewed by Alexey Proskuryakov.
Test: http/tests/xmlhttprequest/cancel-during-failure-crash.html
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didFinishLoading):
(WebCore::SubresourceLoader::didFail):
(WebCore::SubresourceLoader::willCancel): Now that we might enter the function if we're already Finishing,
some cleanup needs to be done in the Initialized state only.
(WebCore::SubresourceLoader::releaseResources): Move requesting counting decrement and laodDone() to
the finishing functions.
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=83918.
Reviewed by Alexey Proskuryakov.
- http/tests/cache/cancel-during-failure-crash-expected.txt: Added.
- http/tests/cache/cancel-during-failure-crash.html: Added.
- platform/chromium-mac/security/block-test-expected.txt:
- platform/chromium-win/security/block-test-expected.txt:
- platform/gtk/security/block-test-expected.txt:
- platform/mac/security/block-test-expected.txt:
- 4:57 PM Changeset in webkit [114964] by
-
- 1 edit1 copy in trunk/LayoutTests
Unreviewed. Split LayoutTests/ChangeLog.
- ChangeLog-2012-04-23: Copied from LayoutTests/ChangeLog.
- 4:52 PM Changeset in webkit [114963] by
-
- 7 edits4 adds in trunk/Source/WebCore
[chromium] Visualize accelerated compositor rects.
https://bugs.webkit.org/show_bug.cgi?id=79400
Reviewed by Adrienne Walker.
No tests, all the code added is only debugging code.
This patch adds support for visualizing three different types of
rects on the chromium heads-up display:
- updateRects that indicate what was painted/uploaded to a resource
- propertyChangedRects that indicate layers that has property changes
- surfaceDamageRects that are the accumulation of updateRects and propertyChangedRects, indicating what pixels on the screen have actually changed. (Surface damage also accounts for newly exposed areas but that is not explicitly visualized.)
In addition to adding support for visualizing this, the
CCHeadsUpDisplay was significantly refactored, separating the FPS
Counter functionality into a different class, so that the heads-up
display is all about visualizing annotations, and those
annotations (frame rate, debug rects) are logged separately.
- WebCore.gypi:
- platform/graphics/chromium/cc/CCDebugRectHistory.cpp: Added.
(WebCore):
(WebCore::CCDebugRectHistory::CCDebugRectHistory):
(WebCore::CCDebugRectHistory::enabled):
(WebCore::CCDebugRectHistory::saveDebugRectsForCurrentFrame):
(WebCore::CCDebugRectHistory::savePaintRects):
(WebCore::CCDebugRectHistory::savePropertyChangedRects):
(WebCore::CCDebugRectHistory::saveSurfaceDamageRects):
- platform/graphics/chromium/cc/CCDebugRectHistory.h: Added.
(WebCore):
(WebCore::CCDebugRect::CCDebugRect):
(CCDebugRect):
(CCDebugRectHistory):
(WebCore::CCDebugRectHistory::create):
(WebCore::CCDebugRectHistory::debugRects):
- platform/graphics/chromium/cc/CCFrameRateCounter.cpp: Added.
(WebCore):
(WebCore::safeMod):
(WebCore::CCFrameRateCounter::frameIndex):
(WebCore::CCFrameRateCounter::CCFrameRateCounter):
(WebCore::CCFrameRateCounter::markBeginningOfFrame):
(WebCore::CCFrameRateCounter::markEndOfFrame):
(WebCore::CCFrameRateCounter::isBadFrameInterval):
(WebCore::CCFrameRateCounter::isBadFrame):
(WebCore::CCFrameRateCounter::getAverageFPSAndStandardDeviation):
(WebCore::CCFrameRateCounter::timeStampOfRecentFrame):
- platform/graphics/chromium/cc/CCFrameRateCounter.h: Added.
(WebCore):
(CCFrameRateCounter):
(WebCore::CCFrameRateCounter::create):
(WebCore::CCFrameRateCounter::currentFrameNumber):
(WebCore::CCFrameRateCounter::timeStampHistorySize):
- platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore):
(WebCore::CCHeadsUpDisplay::enabled):
(WebCore::CCHeadsUpDisplay::showDebugRects):
(WebCore::CCHeadsUpDisplay::draw):
(WebCore::CCHeadsUpDisplay::drawHudContents):
(WebCore::CCHeadsUpDisplay::drawFPSCounter):
(WebCore::CCHeadsUpDisplay::drawFPSCounterText):
(WebCore::CCHeadsUpDisplay::drawDebugRects):
- platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
(WebCore):
(CCHeadsUpDisplay):
(WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
(CCSettings):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::drawLayers):
(WebCore::CCLayerTreeHostImpl::swapBuffers):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(WebCore):
(WebCore::CCLayerTreeHostImpl::fpsCounter):
(WebCore::CCLayerTreeHostImpl::debugRectHistory):
(CCLayerTreeHostImpl):
- 4:49 PM Changeset in webkit [114962] by
-
- 12 edits in trunk/Source
Cut dependency on RenderLayer::scrollRectToVisible outside rendering
https://bugs.webkit.org/show_bug.cgi?id=84607
Reviewed by Simon Fraser.
Source/WebCore:
Layering fix only, there should be no change behavior.
Because we don't have an accessor on RenderObject, a lot of the code needs
to know about RenderLayer. This is not necessary and exposes RenderLayer to
objects that shouldn't know about it.
This patch adds a RenderObject::scrollRectToVisible with the ad-hoc explanation
as to why it isn't on RenderBox (scrolling is a RenderBox concept).
- WebCore.exp.in:
- WebCore.order:
Updated to expose the new method.
- dom/Element.cpp:
(WebCore::Element::scrollIntoView):
(WebCore::Element::scrollIntoViewIfNeeded):
(WebCore::Element::updateFocusAppearance):
- editing/Editor.cpp:
(WebCore::Editor::findStringAndScrollToVisible):
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::revealSelection):
- page/FrameView.cpp:
(WebCore::FrameView::scrollToAnchor):
Updated those call sites to use the new function.
- rendering/RenderLayer.h:
Removed ScrollBehavior.h #include and default argument values
as we are always called through RenderObject now.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::scrollRectToVisible):
- rendering/RenderObject.h:
Added a new function that just forwards to the enclosing layer
if any. We return whether we actually tried to scroll to match
some call sites expectations.
Source/WebKit/mac:
- WebView/WebFrame.mm:
(-[WebFrame _scrollDOMRangeToVisible:]):
Updated to use RenderObject::scrollRectToVisible and not depend on RenderLayer.
- 4:22 PM Changeset in webkit [114961] by
-
- 11 edits2 adds in trunk
framebuffer binding should not be changed after canvas resize or compositing
https://bugs.webkit.org/show_bug.cgi?id=84609
Reviewed by Kenneth Russell.
Source/WebCore:
Test: fast/canvas/webgl/framebuffer-bindings-unaffected-on-resize.html
- html/canvas/WebGLRenderingContext.cpp: set framebuffer binding to DrawingBuffer.
(WebCore):
(WebCore::WebGLRenderingContext::bindFramebuffer):
(WebCore::WebGLRenderingContext::deleteFramebuffer):
(WebCore::WebGLRenderingContext::loseContextImpl):
- platform/graphics/cairo/DrawingBufferCairo.cpp: initialize m_framebufferBinding.
(WebCore::DrawingBuffer::DrawingBuffer):
- platform/graphics/chromium/DrawingBufferChromium.cpp: Ditto.
(WebCore::DrawingBuffer::DrawingBuffer):
- platform/graphics/chromium/WebGLLayerChromium.cpp: Recover framebuffer binding after update().
(WebCore::WebGLLayerChromium::update):
- platform/graphics/gpu/DrawingBuffer.cpp: Add a function to restore framebuffer binding.
(WebCore::DrawingBuffer::restoreFramebufferBinding):
(WebCore):
- platform/graphics/gpu/DrawingBuffer.h: Ditto.
(WebCore::DrawingBuffer::setTexture2DBinding):
(DrawingBuffer):
(WebCore::DrawingBuffer::setFramebufferBinding):
- platform/graphics/gpu/mac/DrawingBufferMac.mm: initialize m_framebufferBinding.
(WebCore::DrawingBuffer::DrawingBuffer):
- platform/graphics/gpu/qt/DrawingBufferQt.cpp: initialize m_framebufferBinding.
(WebCore::DrawingBuffer::DrawingBuffer):
LayoutTests:
- fast/canvas/webgl/framebuffer-bindings-unaffected-on-resize-expected.txt: Added.
- fast/canvas/webgl/framebuffer-bindings-unaffected-on-resize.html: Added.
- fast/canvas/webgl/resources/webgl-test-utils.js: Sync with khronos side (partial)
(WebGLTestUtils.):
(WebGLTestUtils):
- 4:13 PM ImportingThirdPartyTests edited by
- (diff)
- 4:13 PM ImportingThirdPartyTests edited by
- (diff)
- 4:13 PM Changeset in webkit [114960] by
-
- 3 edits in trunk/Tools
run-perf-tests fail intermittently with an exception
https://bugs.webkit.org/show_bug.cgi?id=83532
Reviewed by Ryosuke Niwa.
This bulletproofs port.get_option('child_processes')
against the case where the option wasn't set.
- Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort._get_crash_log):
- Scripts/webkitpy/layout_tests/port/mac_unittest.py:
(test_get_crash_log):
(test_get_crash_log.fake_time_cb):
- 4:10 PM ImportingThirdPartyTests edited by
- (diff)
- 4:07 PM Changeset in webkit [114959] by
-
- 5 edits in trunk
Call instruction for the baseline JIT stores origin info in wrong callframe
https://bugs.webkit.org/show_bug.cgi?id=84645
Reviewed by Gavin Barraclough.
Source/JavaScriptCore:
The baseline JIT was updating the wrong callframe when making a call. If the
call failed during dispatch (unable to perform codegen, calling a non-object)
we would attempt to use this information, but it would be completely wrong.
- jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
- jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCall):
LayoutTests:
Directly force LLInt, Baseline, and DFG JITs to handle the path where
a call fails during dispatch.
- fast/js/script-tests/stack-trace.js:
(callNonCallable):
- 4:02 PM ImportingThirdPartyTests edited by
- (diff)
- 3:57 PM ImportingThirdPartyTests created by
- 3:52 PM Changeset in webkit [114958] by
-
- 4 edits in trunk/Source/WebKit2
[Mac] WebProcess should empty cache on a background thread/block.
<http://webkit.org/b/84619>
<rdar://problem/10668689>
Reviewed by Anders Carlsson.
Move the removeAllCachedResponses call to a dispatch queue and wait for it on exit.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
- WebProcess/WebProcess.h:
(WebProcess):
- WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformClearResourceCaches):
(WebKit::WebProcess::platformTerminate):
- 3:41 PM Changeset in webkit [114957] by
-
- 21 edits2 adds in trunk
Simplify volume slider rendering
https://bugs.webkit.org/show_bug.cgi?id=82150
Patch by Victor Carbune <vcarbune@adobe.com> on 2012-04-23
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/video-controls-rendering-toggle-display-none.html
- css/mediaControlsChromium.css: Update controls css for Chromium.
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
- css/mediaControlsGtk.css: Update controls css for GTK.
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
- css/mediaControlsQuickTime.css: Update controls css for Safari.
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
(audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
- html/shadow/MediaControlElements.cpp: Removed particular renderer.
(WebCore):
- html/shadow/MediaControlElements.h:
(MediaControlVolumeSliderContainerElement): Remoed particular renderer.
- html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::create): Added a div element as a container. Removed extra unused mute button.
- html/shadow/MediaControlRootElementChromium.cpp: Added an extra div
element as a container for the mute button and the volume slider to
easily position them relative to each other.
(WebCore::MediaControlRootElementChromium::create):
LayoutTests:
Added new TEXT baselines for Mac.
Baselines for GTK and Chromium need to be re-generated as well.
- media/video-controls-rendering-toggle-display-none-expected.txt: Added.
- media/video-controls-rendering-toggle-display-none.html: Added.
- platform/chromium/test_expectations.txt: Updated test expectations
- platform/gtk/test_expectations.txt: Updated test expectations.
Commented out a duplicate test marked as CRASH because otherwise cq complains.
- platform/mac/fast/hidpi/video-controls-in-hidpi-expected.txt: Updated.
- platform/mac/media/audio-controls-rendering-expected.txt: Updated.
- platform/mac/media/audio-repaint-expected.txt: Updated.
- platform/mac/media/controls-after-reload-expected.txt: Updated.
- platform/mac/media/controls-strict-expected.txt: Updated.
- platform/mac/media/media-controls-clone-expected.txt: Updated.
- platform/mac/media/video-controls-rendering-expected.txt: Updated.
- platform/mac/media/video-display-toggle-expected.txt: Updated.
- platform/mac/media/video-no-audio-expected.txt: Updated.
- platform/mac/media/video-playing-and-pause-expected.txt: Updated.
- 3:36 PM Changeset in webkit [114956] by
-
- 3 edits3 adds in trunk
DFG must keep alive values that it will perform speculations on
https://bugs.webkit.org/show_bug.cgi?id=84638
<rdar://problem/11258183>
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
- dfg/DFGNodeType.h:
(DFG):
LayoutTests:
Rubber stamped by Oliver Hunt.
- fast/js/dfg-dead-speculation-expected.txt: Added.
- fast/js/dfg-dead-speculation.html: Added.
- fast/js/script-tests/dfg-dead-speculation.js: Added.
(foo):
(.thingy.f.valueOf):
- 3:33 PM Changeset in webkit [114955] by
-
- 2 edits in trunk/Tools
[Qt] Add desktop zooming support for QQuickWebView
https://bugs.webkit.org/show_bug.cgi?id=82337
Unreviewed typo fix after r114900.
- MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow): Fix the mistyped
value of a zoom level.
- 3:30 PM Changeset in webkit [114954] by
-
- 4 edits in branches/subpixellayout/Source/WebCore
Cleaning up LayoutUnit usage for maximalOutlineSize. Removing hacky RenderTreeAsText changes that are no longer necessary. Removing a static_cast in CSSPrimitiveValue that wasn't necessary.
- 3:11 PM WikiStart edited by
- (diff)
- 3:07 PM Changeset in webkit [114953] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix non-LLInt builds by temporarily removing an over-enthusiastic assertion
- 3:01 PM Changeset in webkit [114952] by
-
- 7409 edits139 copies10 deletes in branches/subpixellayout
Merge trunk changes up until 114938 into subpixel branch.
- 2:59 PM Changeset in webkit [114951] by
-
- 2 edits in trunk/Tools
[chromium-android] Get rid of the trick that replaces system fallback font with DejaVuSans.
https://bugs.webkit.org/show_bug.cgi?id=84580
Patch by Hao Zheng <zhenghao@chromium.org> on 2012-04-23
Reviewed by Ojan Vafai.
Android's first fallback font is changed to DroidSansArabic.ttf in JB.
Take the opportunity to get rid of the trick.
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.start_helper):
(ChromiumAndroidPort._push_fonts):
- 2:58 PM Changeset in webkit [114950] by
-
- 3 edits2 deletes in trunk
Unreviewed, rolling out r109981.
http://trac.webkit.org/changeset/109981
https://bugs.webkit.org/show_bug.cgi?id=84630
Broke Twitter map buddy icon (see
https://bugs.webkit.org/show_bug.cgi?id=84558) (Requested by
thorton on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-23
Source/WebCore:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::addToOverlapMap):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
LayoutTests:
- compositing/layer-creation/overlap-empty-layer-expected.txt: Removed.
- compositing/layer-creation/overlap-empty-layer.html: Removed.
- 2:52 PM Changeset in webkit [114949] by
-
- 1 edit2 copies in branches/chromium/1084
Merge 113825
BUG=121899
Review URL: https://chromiumcodereview.appspot.com/10203001
- 2:50 PM Changeset in webkit [114948] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 113825
BUG=121899
Review URL: https://chromiumcodereview.appspot.com/10202001
- 2:30 PM Changeset in webkit [114947] by
-
- 1 edit2 copies in branches/chromium/1084
Merge 112973
BUG=121206
Review URL: https://chromiumcodereview.appspot.com/10201001
- 2:28 PM Changeset in webkit [114946] by
-
- 1 edit in branches/subpixellayout/Source/WebCore/rendering/RenderThemeChromiumSkia.cpp
Fix Chromium Skia on branch.
- 2:26 PM UsingGitWithWebKit edited by
- Add the instruction on how to install git on mac port (diff)
- 2:23 PM Changeset in webkit [114945] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 112973
BUG=121206
Review URL: https://chromiumcodereview.appspot.com/10155016
- 2:17 PM Changeset in webkit [114944] by
-
- 1 edit2 copies in branches/chromium/1084
Merge 113099
BUG=121692
Review URL: https://chromiumcodereview.appspot.com/10198001
- 2:12 PM Changeset in webkit [114943] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 113099
BUG=121692
Review URL: https://chromiumcodereview.appspot.com/10163021
- 2:09 PM Changeset in webkit [114942] by
-
- 1 edit1 copy in branches/chromium/1084
Merge 113597
BUG=121645
Review URL: https://chromiumcodereview.appspot.com/10196001
- 2:03 PM Changeset in webkit [114941] by
-
- 1 edit1 copy in branches/chromium/1025
Merge 113597
BUG=121645
Review URL: https://chromiumcodereview.appspot.com/10191012
- 1:56 PM Changeset in webkit [114940] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 112935
BUG=106413
Review URL: https://chromiumcodereview.appspot.com/10182014
- 1:47 PM Changeset in webkit [114939] by
-
- 1 edit2 deletes in branches/chromium/1025
Revert 114853 - Merge 112935
BUG=106413
Review URL: https://chromiumcodereview.appspot.com/10164022
TBR=cevans@google.com
Review URL: https://chromiumcodereview.appspot.com/10182013
- 1:32 PM Changeset in webkit [114938] by
-
- 2 edits in branches/subpixellayout/Source
Platform fixes for windows, qt and gtk on branch.
- 1:32 PM Changeset in webkit [114937] by
-
- 2 edits in trunk/Source/WebKit/chromium
Chromium roll 133422:133506.
Not reviewed.
- DEPS:
- 1:17 PM Changeset in webkit [114936] by
-
- 2 edits in trunk/Source/WebCore
Crash in RenderInline::clippedOverflowRectForRepaint for PrintPreview
https://bugs.webkit.org/show_bug.cgi?id=84300
Reviewed by Simon Fraser.
No new tests, have not been able to come up with a reliable reduction.
- rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRectForRepaint):
Add NULL check for containingBlock() as it can return NULL when detached
from the tree.
- 1:12 PM Changeset in webkit [114935] by
-
- 11 edits2 deletes in trunk
Unreviewed, rolling out r114929.
http://trac.webkit.org/changeset/114929
https://bugs.webkit.org/show_bug.cgi?id=84623
Broke 35 canvas/webgl tests (Requested by jernoble on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-23
Source/WebCore:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::bindFramebuffer):
(WebCore::WebGLRenderingContext::deleteFramebuffer):
(WebCore::WebGLRenderingContext::loseContextImpl):
- platform/graphics/cairo/DrawingBufferCairo.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
- platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
- platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::update):
- platform/graphics/gpu/DrawingBuffer.cpp:
- platform/graphics/gpu/DrawingBuffer.h:
(WebCore::DrawingBuffer::setTexture2DBinding):
(DrawingBuffer):
- platform/graphics/gpu/mac/DrawingBufferMac.mm:
(WebCore::DrawingBuffer::DrawingBuffer):
- platform/graphics/gpu/qt/DrawingBufferQt.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
LayoutTests:
- fast/canvas/webgl/framebuffer-bindings-unaffected-on-resize-expected.txt: Removed.
- fast/canvas/webgl/framebuffer-bindings-unaffected-on-resize.html: Removed.
- fast/canvas/webgl/resources/webgl-test-utils.js:
(WebGLTestUtils):
- 1:06 PM Changeset in webkit [114934] by
-
- 2 edits in trunk/Source/WebCore
[V8] Pass Isolate around in V8Collection.h
https://bugs.webkit.org/show_bug.cgi?id=84299
Reviewed by Nate Chapin.
The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate around in V8Collection.h.
No tests. No change in behavior.
- bindings/v8/V8Collection.h:
(WebCore::getV8Object):
(WebCore::getNamedPropertyOfCollection):
(WebCore::collectionNamedPropertyGetter):
(WebCore::getIndexedPropertyOfCollection):
(WebCore::collectionIndexedPropertyGetter):
- 12:49 PM Changeset in webkit [114933] by
-
- 2 edits in trunk/Tools
test-webkitpy is failing
https://bugs.webkit.org/show_bug.cgi?id=84617
Reviewed by Eric Seidel.
- Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
(HttpLockTestWithRealFileSystem.clean_all_lockfile):
- 12:38 PM Changeset in webkit [114932] by
-
- 11 edits in trunk/Source/WebCore
[V8] Pass Isolate to toV8() (Part5)
https://bugs.webkit.org/show_bug.cgi?id=84271
Reviewed by Nate Chapin.
The objective is to pass Isolate to all toV8()s.
Since there are a lot of toV8(), I'll make the change
step by step. This patch passes Isolate to toV8()
in several custom bindings.
No tests. No change in behavior.
- bindings/v8/custom/V8MessageChannelConstructor.cpp:
(WebCore::V8MessageChannel::constructorCallback):
- bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAccessorGetter):
(WebCore::V8MessageEvent::portsAccessorGetter):
- bindings/v8/custom/V8MutationCallbackCustom.cpp:
(WebCore::V8MutationCallback::handleEvent):
- bindings/v8/custom/V8NamedNodeMapCustom.cpp:
(WebCore::V8NamedNodeMap::indexedPropertyGetter):
(WebCore::V8NamedNodeMap::namedPropertyGetter):
(WebCore::toV8):
- bindings/v8/custom/V8NodeListCustom.cpp:
(WebCore::V8NodeList::namedPropertyGetter):
- bindings/v8/custom/V8NotificationCenterCustom.cpp:
(WebCore::V8NotificationCenter::createHTMLNotificationCallback):
(WebCore::V8NotificationCenter::createNotificationCallback):
- bindings/v8/custom/V8PerformanceCustom.cpp:
(WebCore::V8Performance::memoryAccessorGetter):
- bindings/v8/custom/V8PopStateEventCustom.cpp:
(WebCore::V8PopStateEvent::stateAccessorGetter):
- bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
(WebCore::V8SQLTransactionSync::executeSqlCallback):
- bindings/v8/custom/V8SVGPathSegCustom.cpp:
(WebCore::toV8):
- 12:34 PM April 2012 Write Your Own Render Object edited by
- (diff)
- 12:32 PM Changeset in webkit [114931] by
-
- 4 adds in branches/subpixellayout/LayoutTests/fast/sub-pixel
Add two subpixel tests.
- 12:31 PM Changeset in webkit [114930] by
-
- 1 edit in branches/subpixellayout/Source/WebKit2/WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp
Add two subpixel tests.
- 12:31 PM Changeset in webkit [114929] by
-
- 11 edits2 adds in trunk
framebuffer binding should not be changed after canvas resize or compositing
https://bugs.webkit.org/show_bug.cgi?id=84609
Reviewed by Kenneth Russell.
Source/WebCore:
Test: fast/canvas/webgl/framebuffer-bindings-unaffected-on-resize.html
- html/canvas/WebGLRenderingContext.cpp: set framebuffer binding to DrawingBuffer.
(WebCore):
(WebCore::WebGLRenderingContext::bindFramebuffer):
(WebCore::WebGLRenderingContext::deleteFramebuffer):
(WebCore::WebGLRenderingContext::loseContextImpl):
- platform/graphics/cairo/DrawingBufferCairo.cpp: initialize m_framebufferBinding.
(WebCore::DrawingBuffer::DrawingBuffer):
- platform/graphics/chromium/DrawingBufferChromium.cpp: Ditto.
(WebCore::DrawingBuffer::DrawingBuffer):
- platform/graphics/chromium/WebGLLayerChromium.cpp: Recover framebuffer binding after update().
(WebCore::WebGLLayerChromium::update):
- platform/graphics/gpu/DrawingBuffer.cpp: Add a function to restore framebuffer binding.
(WebCore::DrawingBuffer::restoreFramebufferBinding):
(WebCore):
- platform/graphics/gpu/DrawingBuffer.h: Ditto.
(WebCore::DrawingBuffer::setTexture2DBinding):
(DrawingBuffer):
(WebCore::DrawingBuffer::setFramebufferBinding):
- platform/graphics/gpu/mac/DrawingBufferMac.mm: initialize m_framebufferBinding.
(WebCore::DrawingBuffer::DrawingBuffer):
- platform/graphics/gpu/qt/DrawingBufferQt.cpp: initialize m_framebufferBinding.
(WebCore::DrawingBuffer::DrawingBuffer):
LayoutTests:
- fast/canvas/webgl/framebuffer-bindings-unaffected-on-resize-expected.txt: Added.
- fast/canvas/webgl/framebuffer-bindings-unaffected-on-resize.html: Added.
- fast/canvas/webgl/resources/webgl-test-utils.js: Sync with khronos side (partial)
(WebGLTestUtils.):
(WebGLTestUtils):
- 12:24 PM Changeset in webkit [114928] by
-
- 3 edits1 copy1 move2 adds in trunk/Tools
Split up flakiness_dashboard.html into multiple files. This is a step in the direction
of making the code more maintainable (e.g. being able to use qunit for testing).
- TestResultServer/static-dashboards/dashboard_base.js:
- TestResultServer/static-dashboards/flakiness_dashboard.css: Added.
- TestResultServer/static-dashboards/flakiness_dashboard.html:
- TestResultServer/static-dashboards/flakiness_dashboard.js: Copied from Tools/TestResultServer/static-dashboards/flakiness_dashboard.html.
- TestResultServer/static-dashboards/flakiness_dashboard_tests.css: Added.
- TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Renamed from Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.js.
- 12:07 PM Changeset in webkit [114927] by
-
- 13 edits in trunk/Source/WebCore
[V8] Pass Isolate to toV8() (Part4)
https://bugs.webkit.org/show_bug.cgi?id=84269
Reviewed by Nate Chapin.
The objective is to pass Isolate to all toV8()s.
Since there are a lot of toV8()s, I'll make the change
step by step. This patch passes Isolate to toV8() in
several custom bindings.
No tests. No change in behavior.
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::getContextCallback):
- bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::allAccessorGetter):
- bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore::toV8Object):
(WebCore::V8HTMLElement::itemValueAccessorGetter):
- bindings/v8/custom/V8HTMLFormElementCustom.cpp:
(WebCore::V8HTMLFormElement::indexedPropertyGetter):
(WebCore::V8HTMLFormElement::namedPropertyGetter):
- bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
(WebCore::V8HTMLFrameSetElement::namedPropertyGetter):
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::v8HTMLImageElementConstructorCallback):
- bindings/v8/custom/V8HTMLLinkElementCustom.cpp:
(WebCore::V8HTMLLinkElement::sizesAccessorGetter):
- bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore::V8HTMLOptionsCollection::indexedPropertyGetter):
- bindings/v8/custom/V8HTMLOutputElementCustom.cpp:
(WebCore::V8HTMLOutputElement::htmlForAccessorGetter):
- bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
(WebCore::V8HTMLSelectElement::indexedPropertyGetter):
- bindings/v8/custom/V8ImageDataCustom.cpp:
(WebCore::toV8):
- 11:59 AM Changeset in webkit [114926] by
-
- 5 edits in trunk/Source/WebCore
Clean up subpixel unit handling in hit testing code
https://bugs.webkit.org/show_bug.cgi?id=84496
Reviewed by Eric Seidel.
Fix use of IntRect and LayoutRect in hit testing code in preparation for
subpixel layout.
No new tests, no change in functionality.
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::rectForPoint):
Revert rectForPoint to IntRect as all call sites converted it to an
IntRect anyway to compare it with an IntPoint or another IntRect.
- rendering/HitTestingTransformState.cpp:
(WebCore::HitTestingTransformState::boundsOfMappedQuad):
- rendering/HitTestingTransformState.h:
Convert boundsOfMappedQuad to LayoutRect as the TransformationMatrix now
has subpixel precision.
- 11:47 AM Changeset in webkit [114925] by
-
- 10 edits in trunk/Source/WebCore
[V8] Pass Isolate to toV8() (Part3)
https://bugs.webkit.org/show_bug.cgi?id=84261
Reviewed by Nate Chapin.
The objective is to pass Isolate to all toV8()s.
Since there are a lot of toV8(), I'll make the change
step by step. This patch passes Isolate to toV8()
in several custom bindings.
No tests. No change in behavior.
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::openCallback):
(WebCore::V8DOMWindow::indexedPropertyGetter):
(WebCore::V8DOMWindow::namedPropertyGetter):
- bindings/v8/custom/V8DirectoryEntrySyncCustom.cpp:
(WebCore::V8DirectoryEntrySync::getDirectoryCallback):
(WebCore::V8DirectoryEntrySync::getFileCallback):
- bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::evaluateCallback):
(WebCore::V8Document::getCSSCanvasContextCallback):
(WebCore::V8Document::createTouchListCallback):
- bindings/v8/custom/V8DocumentLocationCustom.cpp:
(WebCore::V8Document::locationAccessorGetter):
- bindings/v8/custom/V8EntryCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8EntrySyncCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8EventCustom.cpp:
(WebCore::V8Event::dataTransferAccessorGetter):
(WebCore::V8Event::clipboardDataAccessorGetter):
(WebCore):
- bindings/v8/custom/V8FileReaderCustom.cpp:
(WebCore::V8FileReader::resultAccessorGetter):
- bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
(WebCore::getItem):
(WebCore::V8HTMLAllCollection::callAsFunctionCallback):
- 11:42 AM Changeset in webkit [114924] by
-
- 10 edits in trunk/Source/WebCore
[V8] Pass Isolate to toV8() (Part2)
https://bugs.webkit.org/show_bug.cgi?id=84259
Reviewed by Nate Chapin.
The objective is to pass Isolate to all toV8()s.
Since there are a lot of toV8(), I'll make the change
step by step. This patch passes Isolate to toV8() in
several custom bindings.
No tests. No change in behavior.
- bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8CSSRuleCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8CSSStyleSheetCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8CSSValueCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
(WebCore::toV8Object):
(WebCore::V8CanvasRenderingContext2D::strokeStyleAccessorGetter):
(WebCore::V8CanvasRenderingContext2D::fillStyleAccessorGetter):
- bindings/v8/custom/V8ConsoleCustom.cpp:
(WebCore::V8Console::memoryAccessorGetter):
- bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
(WebCore::V8SQLStatementErrorCallback::handleEvent):
- bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8DOMTokenListCustom.cpp:
(WebCore::toV8):
- 11:34 AM Changeset in webkit [114923] by
-
- 4 edits in trunk/Source/WTF
Unreviewed, rolling out r114914.
http://trac.webkit.org/changeset/114914
https://bugs.webkit.org/show_bug.cgi?id=84615
Causing infinite hangs on some tests involving HashMaps with
integer keys (Requested by dimich on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-23
- wtf/HashTable.h:
(WTF::HashTable::isEmptyBucket):
- wtf/HashTraits.h:
- wtf/text/StringHash.h:
- 11:33 AM Changeset in webkit [114922] by
-
- 10 edits in trunk/Source/WebCore
[V8][Refactoring] Remove V8Proxy::toV8()
https://bugs.webkit.org/show_bug.cgi?id=84257
Reviewed by Nate Chapin.
Some constructorCallback()s are using V8Proxy::toV8(),
other constructorCallback()s are directly using setJSWrapperForXXX()
(XXX can be DOMObject, ActiveDOMObject, Node or ActiveNode).
We should unify them.
Considering the fact that V8Proxy::toV8() just supports
XXX=DOMObject and thus is not flexible, replacing V8Proxy::toV8()
with setJSWrapperForDOMObject() would make sense.
No tests. No change in behavior.
- bindings/v8/V8Proxy.h: Removed toV8().
- bindings/scripts/CodeGeneratorV8.pm: Replaced toV8() with setJSWrapperForDOMObject().
(GenerateEventConstructorCallback):
- bindings/v8/custom/V8ArrayBufferCustom.cpp: Ditto.
(WebCore::V8ArrayBuffer::constructorCallback):
- bindings/v8/custom/V8ArrayBufferViewCustom.h: Ditto.
(WebCore::constructWebGLArrayWithArrayBufferArgument):
(WebCore::constructWebGLArray):
- bindings/v8/custom/V8DOMFormDataCustom.cpp: Ditto.
(WebCore::V8DOMFormData::constructorCallback):
- bindings/v8/custom/V8DataViewCustom.cpp: Ditto.
(WebCore::V8DataView::constructorCallback):
- bindings/v8/custom/V8MessageChannelConstructor.cpp: Ditto.
(WebCore::V8MessageChannel::constructorCallback):
- bindings/v8/custom/V8WebKitPointConstructor.cpp: Ditto.
(WebCore::V8WebKitPoint::constructorCallback):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp: Updated run-bindings-tests results.
(WebCore::V8TestEventConstructor::constructorCallback):
- 11:21 AM Changeset in webkit [114921] by
-
- 151 edits4 deletes in trunk/LayoutTests
[Chromium] Not reviewed, rebaseline of button images after
Chromium change http://codereview.chromium.org/10107019/
- platform/chromium-linux/css3/selectors3/html/css3-modsel-161-expected.png:
- platform/chromium-linux/css3/selectors3/html/css3-modsel-19b-expected.png:
- platform/chromium-linux/css3/selectors3/html/css3-modsel-64-expected.png:
- platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-161-expected.png:
- platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-19b-expected.png:
- platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-64-expected.png:
- platform/chromium-linux/css3/selectors3/xml/css3-modsel-161-expected.png:
- platform/chromium-linux/css3/selectors3/xml/css3-modsel-19b-expected.png:
- platform/chromium-linux/css3/selectors3/xml/css3-modsel-64-expected.png:
- platform/chromium-linux/editing/pasteboard/4641033-expected.png:
- platform/chromium-linux/editing/pasteboard/4944770-1-expected.png:
- platform/chromium-linux/editing/pasteboard/4944770-2-expected.png:
- platform/chromium-linux/editing/selection/3690703-2-expected.png:
- platform/chromium-linux/editing/selection/3690703-expected.png:
- platform/chromium-linux/editing/selection/3690719-expected.png:
- platform/chromium-linux/editing/selection/4397952-expected.png:
- platform/chromium-linux/editing/selection/5240265-expected.png:
- platform/chromium-linux/editing/selection/caret-before-select-expected.png:
- platform/chromium-linux/editing/selection/replaced-boundaries-3-expected.png:
- platform/chromium-linux/editing/selection/select-box-expected.png:
- platform/chromium-linux/editing/selection/select-element-paragraph-boundary-expected.png:
- platform/chromium-linux/editing/selection/selection-button-text-expected.png:
- platform/chromium-linux/fast/block/float/float-avoidance-expected.png:
- platform/chromium-linux/fast/block/margin-collapse/103-expected.png:
- platform/chromium-linux/fast/block/positioning/inline-block-relposition-expected.png:
- platform/chromium-linux/fast/css/continuationCrash-expected.png:
- platform/chromium-linux/fast/css/margin-top-bottom-dynamic-expected.png:
- platform/chromium-linux/fast/css/rtl-ordering-expected.png:
- platform/chromium-linux/fast/css/square-button-appearance-expected.png:
- platform/chromium-linux/fast/css/text-transform-select-expected.png:
- platform/chromium-linux/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
- platform/chromium-linux/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
- platform/chromium-linux/fast/forms/001-expected.png:
- platform/chromium-linux/fast/forms/003-expected.png:
- platform/chromium-linux/fast/forms/004-expected.png:
- platform/chromium-linux/fast/forms/HTMLOptionElement_label01-expected.png:
- platform/chromium-linux/fast/forms/HTMLOptionElement_label02-expected.png:
- platform/chromium-linux/fast/forms/HTMLOptionElement_label03-expected.png:
- platform/chromium-linux/fast/forms/HTMLOptionElement_label04-expected.png:
- platform/chromium-linux/fast/forms/HTMLOptionElement_label06-expected.png:
- platform/chromium-linux/fast/forms/HTMLOptionElement_label07-expected.png:
- platform/chromium-linux/fast/forms/basic-buttons-expected.png:
- platform/chromium-linux/fast/forms/basic-selects-expected.png:
- platform/chromium-linux/fast/forms/blankbuttons-expected.png:
- platform/chromium-linux/fast/forms/box-shadow-override-expected.png:
- platform/chromium-linux/fast/forms/button-align-expected.png:
- platform/chromium-linux/fast/forms/button-cannot-be-nested-expected.png:
- platform/chromium-linux/fast/forms/button-generated-content-expected.png:
- platform/chromium-linux/fast/forms/button-inner-block-reuse-expected.png:
- platform/chromium-linux/fast/forms/button-positioned-expected.png:
- platform/chromium-linux/fast/forms/button-sizes-expected.png:
- platform/chromium-linux/fast/forms/button-style-color-expected.png:
- platform/chromium-linux/fast/forms/button-table-styles-expected.png:
- platform/chromium-linux/fast/forms/button-text-transform-expected.png:
- platform/chromium-linux/fast/forms/button-white-space-expected.png:
- platform/chromium-linux/fast/forms/control-clip-overflow-expected.png:
- platform/chromium-linux/fast/forms/control-restrict-line-height-expected.png:
- platform/chromium-linux/fast/forms/disabled-select-change-index-expected.png:
- platform/chromium-linux/fast/forms/file/file-input-direction-expected.png:
- platform/chromium-linux/fast/forms/file/file-input-disabled-expected.png:
- platform/chromium-linux/fast/forms/file/file-input-pressed-state-expected.png:
- platform/chromium-linux/fast/forms/file/input-file-re-render-expected.png:
- platform/chromium-linux/fast/forms/form-element-geometry-expected.png:
- platform/chromium-linux/fast/forms/formmove3-expected.png:
- platform/chromium-linux/fast/forms/input-appearance-height-expected.png:
- platform/chromium-linux/fast/forms/input-button-sizes-expected.png:
- platform/chromium-linux/fast/forms/input-value-expected.png:
- platform/chromium-linux/fast/forms/menulist-deselect-update-expected.png:
- platform/chromium-linux/fast/forms/menulist-no-overflow-expected.png:
- platform/chromium-linux/fast/forms/menulist-restrict-line-height-expected.png:
- platform/chromium-linux/fast/forms/menulist-separator-painting-expected.png:
- platform/chromium-linux/fast/forms/menulist-style-color-expected.png:
- platform/chromium-linux/fast/forms/menulist-width-change-expected.png:
- platform/chromium-linux/fast/forms/option-script-expected.png:
- platform/chromium-linux/fast/forms/option-strip-whitespace-expected.png:
- platform/chromium-linux/fast/forms/option-text-clip-expected.png:
- platform/chromium-linux/fast/forms/select-align-expected.png:
- platform/chromium-linux/fast/forms/select-baseline-expected.png:
- platform/chromium-linux/fast/forms/select-change-listbox-to-popup-expected.png:
- platform/chromium-linux/fast/forms/select-dirty-parent-pref-widths-expected.png:
- platform/chromium-linux/fast/forms/select-disabled-appearance-expected.png:
- platform/chromium-linux/fast/forms/select-initial-position-expected.png:
- platform/chromium-linux/fast/forms/select-selected-expected.png:
- platform/chromium-linux/fast/forms/select-size-expected.png:
- platform/chromium-linux/fast/forms/select-style-expected.png:
- platform/chromium-linux/fast/forms/select-visual-hebrew-expected.png:
- platform/chromium-linux/fast/forms/select-writing-direction-natural-expected.png:
- platform/chromium-linux/fast/forms/selectlist-minsize-expected.png:
- platform/chromium-linux/fast/forms/stuff-on-my-optgroup-expected.png:
- platform/chromium-linux/fast/forms/targeted-frame-submission-expected.png:
- platform/chromium-linux/fast/forms/validation-message-appearance-expected.png:
- platform/chromium-linux/fast/html/details-replace-summary-child-expected.png:
- platform/chromium-linux/fast/html/details-replace-text-expected.png:
- platform/chromium-linux/fast/html/keygen-expected.png:
- platform/chromium-linux/fast/invalid/014-expected.png:
- platform/chromium-linux/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
- platform/chromium-linux/fast/overflow/scrollRevealButton-expected.png:
- platform/chromium-linux/fast/parser/document-write-option-expected.png:
- platform/chromium-linux/fast/repaint/control-clip-expected.png:
- platform/chromium-linux/fast/replaced/replaced-breaking-expected.png:
- platform/chromium-linux/fast/replaced/replaced-breaking-mixture-expected.png:
- platform/chromium-linux/fast/replaced/three-selects-break-expected.png:
- platform/chromium-linux/fast/replaced/width100percent-button-expected.png:
- platform/chromium-linux/fast/selectors/064-expected.png:
- platform/chromium-linux/fast/table/append-cells2-expected.png:
- platform/chromium-linux/fast/table/remove-td-display-none-expected.png:
- platform/chromium-linux/fast/text/international/bidi-menulist-expected.png:
- platform/chromium-linux/fast/text/international/hindi-spacing-expected.png:
- platform/chromium-linux/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png:
- platform/chromium-linux/fast/text/textIteratorNilRenderer-expected.png:
- platform/chromium-linux/fullscreen/full-screen-iframe-zIndex-expected.png:
- platform/chromium-linux/fullscreen/full-screen-remove-ancestor-after-expected.png:
- platform/chromium-linux/fullscreen/full-screen-zIndex-after-expected.png:
- platform/chromium-linux/http/tests/navigation/javascriptlink-frames-expected.png:
- platform/chromium-linux/svg/custom/foreign-object-skew-expected.png:
- platform/chromium-linux/svg/custom/inline-svg-in-xhtml-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug138725-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug18359-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug26178-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug28928-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug29326-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug33855-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug39209-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug4382-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug4429-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug44505-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug46368-1-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug46368-2-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug51037-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug51727-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug52505-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug52506-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug60749-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug68912-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug7342-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug92647-2-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.png:
- platform/chromium-linux/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
- platform/chromium-linux/tables/mozilla/core/margins-expected.png:
- platform/chromium-linux/tables/mozilla/dom/tableDom-expected.png:
- platform/chromium-linux/tables/mozilla/other/move_row-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
- platform/chromium-linux/transforms/2d/zoom-menulist-expected.png:
- platform/chromium-mac-leopard/fast/forms/box-shadow-override-expected.txt: Removed.
- platform/chromium-mac-leopard/tables/mozilla/bugs/bug26178-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/forms/box-shadow-override-expected.txt: Removed.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug26178-expected.txt: Removed.
- 11:18 AM Changeset in webkit [114920] by
-
- 8 edits in trunk/Source/WebCore
[V8] Pass Isolate to toV8() (Part1)
https://bugs.webkit.org/show_bug.cgi?id=84250
Reviewed by Nate Chapin.
The final objective is to pass Isolate around in V8 bindings.
This patch makes a change in CodeGeneratorV8.pm so that the
generated code passes Isolate to toV8().
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm: Modified as described above.
(GenerateNormalAttrGetter):
(GenerateNamedConstructorCallback):
(GenerateCallbackImplementation):
(GenerateFunctionCallString):
(NativeToJSValue):
- bindings/scripts/test/V8/V8Float64Array.cpp: Updated run-bindings-tests results.
(WebCore::Float64ArrayV8Internal::fooCallback):
- bindings/scripts/test/V8/V8TestCallback.cpp:
(WebCore::V8TestCallback::callbackWithClass1Param):
(WebCore::V8TestCallback::callbackWithClass2Param):
(WebCore::V8TestCallback::callbackWithStringList):
(WebCore::V8TestCallback::callbackRequiresThisToPass):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructorCallback):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::readOnlyTestObjAttrAttrGetter):
(WebCore::TestObjV8Internal::testObjAttrAttrGetter):
(WebCore::TestObjV8Internal::XMLObjAttrAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrGetter):
(WebCore::TestObjV8Internal::cachedAttribute1AttrGetter):
(WebCore::TestObjV8Internal::cachedAttribute2AttrGetter):
(WebCore::TestObjV8Internal::mutablePointAttrGetter):
(WebCore::TestObjV8Internal::immutablePointAttrGetter):
(WebCore::TestObjV8Internal::objMethodCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::withScriptStateObjCallback):
(WebCore::TestObjV8Internal::withScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesCallback):
(WebCore::TestObjV8Internal::mutablePointFunctionCallback):
(WebCore::TestObjV8Internal::immutablePointFunctionCallback):
(WebCore::TestObjV8Internal::strictFunctionCallback):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceV8Internal::portsAttrGetter):
- 10:47 AM Changeset in webkit [114919] by
-
- 3 edits in trunk/Source/WebCore
[V8] Add an optional Isolate argument to setDOMException() and throwError()
https://bugs.webkit.org/show_bug.cgi?id=84310
Reviewed by Nate Chapin.
The objective is to pass Isolate to setDOMException()
and throwError(). This patch adds an optional Isolate argument
to setDOMException() and throwError(). I'll pass the Isolate
to these methods in the following patches.
No tests. No change in behavior.
- bindings/v8/V8Proxy.cpp:
(WebCore):
(WebCore::V8Proxy::setDOMException):
(WebCore::V8Proxy::throwError):
- bindings/v8/V8Proxy.h:
(V8Proxy):
(WebCore):
(WebCore::throwError):
- 10:42 AM Changeset in webkit [114918] by
-
- 2 edits in trunk/LayoutTests
css3/zoom-coords.xml failing after http://trac.webkit.org/changeset/114811
https://bugs.webkit.org/show_bug.cgi?id=84612
Unreviewed partial rollout of r114811.
- css3/zoom-coords-expected.txt:
- 10:40 AM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 10:36 AM Changeset in webkit [114917] by
-
- 7 edits1 add in trunk
[Qt][WK2] Convert touch-point area.
https://bugs.webkit.org/show_bug.cgi?id=84434
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-23
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
Missed WebKit2 conversion in commit r106470.
- Shared/qt/WebEventFactoryQt.cpp:
(WebKit::WebEventFactory::createWebTouchEvent):
Tools:
Add feature to set touch-point radius for emitted touch-events.
- DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::addTouchPoint):
(EventSender::updateTouchPoint):
(EventSender::setTouchPointRadius):
(EventSender::clearTouchPoints):
- DumpRenderTree/qt/EventSenderQt.h:
(EventSender):
LayoutTests:
Expand the basic touch test, to check touch-point radius, if feature
is available in EventSender.
- fast/events/touch/script-tests/basic-single-touch-events.js:
(verifyTouchPoint):
(verifyTouch):
(singleTouchSequence):
- 10:29 AM Changeset in webkit [114916] by
-
- 1 edit in branches/chromium/1084/Source/WebCore/rendering/RenderBlock.cpp
Compile fix for Merge 112935
BUG=106413
Review URL: https://chromiumcodereview.appspot.com/10185004
- 10:28 AM Changeset in webkit [114915] by
-
- 4 edits in trunk/Source
[chromium] Properly ignore unsupported animation directions.
https://bugs.webkit.org/show_bug.cgi?id=84599
Patch by Ian Vollick <vollick@chromium.org> on 2012-04-23
Reviewed by Adrienne Walker.
Source/WebCore:
Tested in CCLayerAnimationControllerTest.ignoreUnsupportedAnimationDirections.
- platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
Source/WebKit/chromium:
- tests/CCLayerAnimationControllerTest.cpp:
(WebKitTests::TEST):
(WebKitTests):
- 10:26 AM Changeset in webkit [114914] by
-
- 4 edits in trunk/Source/WTF
Iterating a HashMap<String, X> involves a string equality comparison to check for the empty value
https://bugs.webkit.org/show_bug.cgi?id=84524
Reviewed by Antti Koivisto.
Added a new algorithm for checking for empty buckets that can be specialized.
Specialized it for String. We may later want to do the same thing for KURL.
It's not important to do it for AtomicString, since AtomicString's == function
is already a simple pointer equality compare.
- wtf/HashTable.h:
(WTF::HashTable::isEmptyBucket): Call the new isHashTraitsEmptyValue function, which
will do something more efficient for String.
- wtf/HashTraits.h: Added hasIsEmptyValueFunction to hash traits, with a default value
of false. This allows us to continue to get automatic comparison with the appropriate
emptyValue result for all existing traits, but supply a custom isEmptyValue function
for HashTraits<String>. Putting an isEmptyValue function into the traits would require
overriding it in every class that has a custom value for emptyValue. Specialized
HashTraits for String to add hasIsEmptyValueFunction and declare, but not define, the
isEmptyValue function.
(WTF::isHashTraitsEmptyValue): Added a function that uses the HashTraitsEmptyValueChecker
struct to use either == combined with the emptyValue function or the isEmptyValue function.
(PairHashTraits): Define hasIsEmptyValueFunction and isEmptyValue.
- wtf/text/StringHash.h: Removed unneeded includes and sorted the using statements at
the bottom of the file.
(WTF::HashTraits<String>::isEmptyValue): Define this function here, since here we have
included the WTFString.h header; the HashTraits.h header compiles without WTFString.h.
- 10:24 AM WebKitGTK/WebKit2Roadmap edited by
- Add send-request signal that is blocking yelp (diff)
- 10:22 AM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 10:21 AM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 10:18 AM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 9:58 AM Changeset in webkit [114913] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
Unskip the tests skipped in r114905.
- platform/qt-5.0/Skipped:
- 9:55 AM Changeset in webkit [114912] by
-
- 7 edits in trunk/Source/WebCore
[Performance][V8] Skip Isolate look-up to find StringCache
https://bugs.webkit.org/show_bug.cgi?id=84103
Reviewed by Nate Chapin.
This patch improves the performance of a lot of DOM attribute
getters that return a string.
- Improves the performance of Dromaeo/dom-attr.html(element.property) by 27.7%.
- Improves the performance of Dromaeo/dom-attr.html(getAttribute) by 10.6%.
- Improves the performance of div.id, div.className, div.nodeName, text.nodeValue, text.textContent by 12% -- 21%.
The followings are the test results in my Linux desktop.
Performance test: Dromaeo/dom-attr.html
Total: 674.64runs/s -> 707.03runs/s (+ 4.8%)
getAttribute: 1537.60runs/s -> 1700.20runs/s (+10.6%)
element.property: 1389.00runs/s -> 1774.20runs/s (+27.7%)
setAttribute: 538.88runs/s -> 548.87runs/s (+ 1.9%)
element.property = value: 644.07runs/s -> 656.67runs/s (+ 2.0%)
element.expando = value: 219.76runs/s -> 207.14runs/s (- 6.8%)
element.expando: 578.77runs/s -> 554.67runs/s (- 4.2%)
Performance test: https://bugs.webkit.org/attachment.cgi?id=137440
div.id: 30.70ns -> 26.70ns (+15%)
div.className: 31.10ns -> 26.40ns (+18%)
div.nodeName: 37.70ns -> 33.00ns (+14%)
text.nodeValue: 31.40ns -> 25.90ns (+21%)
text.textContent: 51.50ns -> 45.90ns (+12%)
Previously V8 bindings need to look up an Isolate to find
an Isolate-local StringCache. This patch skips the look-up
by getting the Isolate from AccessorInfo.GetIsolate()
or Arguments.GetIsolate().
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateFunctionCallString):
(NativeToJSValue):
- bindings/v8/V8Binding.cpp:
(WebCore::getElementStringAttr):
- bindings/v8/V8Binding.h:
(WebCore::v8ExternalString): Make 'isolate' an optional argument.
Ideally we want to make 'isolate' a non-optional argument,
but it is difficult to rewrite all v8ExternalString() callers
at a breath. We can rewrite them incrementally.
(WebCore::v8String): Ditto.
(WebCore::v8StringOrNull): Ditto.
(WebCore::v8StringOrUndefined): Ditto.
(WebCore::v8StringOrFalse): Ditto.
- bindings/scripts/test/V8/V8TestEventConstructor.cpp: Updated run-bindings-tests results.
(WebCore::TestEventConstructorV8Internal::attr1AttrGetter):
(WebCore::TestEventConstructorV8Internal::attr2AttrGetter):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalStr1AttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrGetter):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::readOnlyStringAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::hashAttrGetter):
(WebCore::TestObjV8Internal::conditionalMethod1Callback):
- 9:50 AM Changeset in webkit [114911] by
-
- 18 edits in trunk/Source/WebCore
[V8] Add an optional Isolate argument to wrap()
https://bugs.webkit.org/show_bug.cgi?id=84202
Reviewed by Nate Chapin.
The final objective is to pass Isolate around in V8 bindings.
This patch adds an optional Isolate argument to wrap().
After rewriting all wrap() callers so that they pass Isolate
to wrap(), I'll make the Isolate argument non-optional.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm: Modified as described above.
(GenerateHeader):
- bindings/v8/custom/V8DocumentCustom.cpp: Ditto.
(WebCore::toV8):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: Ditto.
(WebCore::toV8):
- bindings/v8/custom/V8NodeCustom.cpp: Ditto.
(WebCore::toV8Slow):
- bindings/v8/custom/V8SVGDocumentCustom.cpp: Ditto.
(WebCore::toV8):
- dom/make_names.pl: Ditto.
(printWrapperFactoryCppFile):
- bindings/scripts/test/V8/V8Float64Array.h:
Updated run-bindings-tests results.
(V8Float64Array):
(WebCore::V8Float64Array::wrap):
- bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
(WebCore::V8TestActiveDOMObject::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
(WebCore::V8TestCustomNamedGetter::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
(WebCore::V8TestEventConstructor::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
(WebCore::V8TestEventTarget::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
(WebCore::V8TestInterface::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
(WebCore::V8TestMediaQueryListListener::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
(WebCore::V8TestNamedConstructor::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestNode.h:
(V8TestNode):
(WebCore::V8TestNode::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
(WebCore::V8TestObj::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
(WebCore::V8TestSerializedScriptValueInterface::wrap):
(WebCore::toV8):
- 9:46 AM Changeset in webkit [114910] by
-
- 3 edits in trunk/Source/WebCore
[V8] Pass Isolate to toV8Slow()
https://bugs.webkit.org/show_bug.cgi?id=84173
Reviewed by Nate Chapin.
The final objective is to pass Isolate around in V8 bindings.
This patch passes the Isolate to toV8Slow().
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
- bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):
- 9:44 AM Changeset in webkit [114909] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r114855): fast/js/global-constructors.html, fast/dom/Window/window-properties.html, fast/dom/prototype-inheritance-2.html failing.
https://bugs.webkit.org/show_bug.cgi?id=84604
Unreviewed gardening; add new expected failing tests to test_expectations.txt.
- platform/mac/test_expectations.txt:
- 9:30 AM Changeset in webkit [114908] by
-
- 6 edits63 adds in trunk/LayoutTests
[Qt] Unreviewed gardening after r114899
- platform/qt-5.0/css2.1/t0805-c5518-brdr-t-01-e-expected.txt: Added.
- platform/qt-5.0/css2.1/t0805-c5519-brdr-r-00-a-expected.txt: Added.
- platform/qt-5.0/css2.1/t0805-c5519-brdr-r-01-e-expected.txt: Added.
- platform/qt-5.0/css2.1/t0805-c5520-brdr-b-01-e-expected.txt: Added.
- platform/qt-5.0/css2.1/t0805-c5521-brdr-l-00-a-expected.txt: Added.
- platform/qt-5.0/css2.1/t0805-c5521-brdr-l-01-e-expected.txt: Added.
- platform/qt-5.0/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt: Added.
- platform/qt-5.0/css2.1/t0905-c414-flt-02-c-expected.txt: Added.
- platform/qt-5.0/css2.1/t0905-c414-flt-03-c-expected.txt: Added.
- platform/qt-5.0/css2.1/t0905-c414-flt-04-c-expected.txt: Added.
- platform/qt-5.0/css2.1/t0905-c414-flt-fit-01-d-g-expected.txt: Added.
- platform/qt-5.0/css2.1/t0905-c5525-fltblck-00-d-ag-expected.txt: Added.
- platform/qt-5.0/css2.1/t0905-c5525-fltblck-01-d-expected.txt: Added.
- platform/qt-5.0/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt: Added.
- platform/qt-5.0/css2.1/t0905-c5525-flthw-00-c-g-expected.txt: Added.
- platform/qt-5.0/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt: Added.
- platform/qt-5.0/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt: Added.
- platform/qt-5.0/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt: Added.
- platform/qt-5.0/css2.1/t0905-c5525-fltwrap-00-b-expected.txt: Added.
- platform/qt-5.0/css2.1/t0905-c5526-flthw-00-c-g-expected.txt: Added.
- platform/qt-5.0/css2.1/t090501-c414-flt-01-b-expected.txt: Added.
- platform/qt-5.0/css2.1/t090501-c414-flt-03-b-g-expected.txt: Added.
- platform/qt-5.0/css2.1/t090501-c414-flt-ln-01-d-g-expected.txt: Added.
- platform/qt-5.0/css2.1/t090501-c5525-flt-l-00-b-g-expected.txt: Added.
- platform/qt-5.0/css2.1/t090501-c5525-flt-r-00-b-g-expected.txt: Added.
- platform/qt-5.0/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.txt: Added.
- platform/qt-5.0/css2.1/t1202-counter-03-b-expected.txt: Added.
- platform/qt-5.0/css2.1/t1202-counter-04-b-expected.txt: Added.
- platform/qt-5.0/css2.1/t1202-counters-03-b-expected.txt: Added.
- platform/qt-5.0/css2.1/t1205-c566-list-stl-01-c-g-expected.txt: Added.
- platform/qt-5.0/editing/deleting/5144139-2-expected.txt: Added.
- platform/qt-5.0/editing/selection/click-left-of-rtl-wrapping-text-expected.txt: Added.
- platform/qt-5.0/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt: Added.
- platform/qt-5.0/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt: Added.
- platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt: Added.
- platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt: Added.
- platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt: Added.
- platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt: Added.
- platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt: Added.
- platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt: Added.
- platform/qt-5.0/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
- platform/qt-5.0/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
- platform/qt-5.0/fast/borders/bidi-002-expected.txt: Added.
- platform/qt-5.0/fast/borders/bidi-009a-expected.txt: Added.
- platform/qt-5.0/fast/borders/bidi-012-expected.txt: Added.
- platform/qt-5.0/fast/css/beforeSelectorOnCodeElement-expected.txt: Added.
- platform/qt-5.0/fast/forms/listbox-bidi-align-expected.txt: Added.
- platform/qt-5.0/fast/forms/search-rtl-expected.txt: Added.
- platform/qt-5.0/fast/repaint/continuation-after-outline-expected.txt: Added.
- platform/qt-5.0/fast/text/backslash-to-yen-sign-euc-expected.txt: Added.
- platform/qt-5.0/fast/text/backslash-to-yen-sign-expected.txt: Added.
- platform/qt-5.0/fast/text/fallback-traits-fixup-expected.txt: Added.
- platform/qt-5.0/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt: Added.
- platform/qt-5.0/fast/text/soft-hyphen-3-expected.txt: Added.
- platform/qt-5.0/fast/text/softHyphen-expected.txt: Added.
- platform/qt-5.0/fast/writing-mode/fallback-orientation-expected.txt: Added.
- platform/qt-5.0/svg/as-image/img-preserveAspectRatio-support-1-expected.txt:
- platform/qt-5.0/svg/custom/glyph-selection-bidi-mirror-expected.txt:
- platform/qt-5.0/svg/custom/glyph-selection-non-bmp-expected.txt: Added.
- platform/qt-5.0/svg/hixie/intrinsic/003-expected.txt: Added.
- platform/qt-5.0/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
- 9:20 AM Changeset in webkit [114907] by
-
- 51 edits in trunk/Source/WebCore
[V8] Add an optional Isolate argument to toV8().
https://bugs.webkit.org/show_bug.cgi?id=84161
Reviewed by Nate Chapin.
The final objective is to pass Isolate around in V8 bindings.
This patch adds an optional Isolate argument to toV8().
After rewriting all toV8() callers so that they pass Isolate,
I will make the Isolate argument non-optional.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
Modified as described above.
(GenerateHeader):
(NativeToJSValue):
- bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8CSSRuleCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8CSSStyleSheetCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8CSSValueCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8CanvasPixelArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8DOMTokenListCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8EntryCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8EntrySyncCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8EventCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Float32ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Float64ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8IDBAnyCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8IDBKeyCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8ImageDataCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Int16ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Int32ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Int8ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8NamedNodeMapCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):
- bindings/v8/custom/V8SVGDocumentCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8SVGElementCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8SVGPathSegCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8ScriptProfileCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8StyleSheetCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Uint16ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Uint32ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Uint8ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::toV8):
- bindings/scripts/test/V8/V8Float64Array.h:
Updated run-bindings-tests results.
(WebCore):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestEventConstructor.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestEventTarget.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestInterface.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestNamedConstructor.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestNode.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestObj.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(WebCore::toV8):
- 9:10 AM Changeset in webkit [114906] by
-
- 7 edits in trunk
[EFL] EFL's LayoutTestController does not implement elementDoesAutoCompleteForElementWithId
https://bugs.webkit.org/show_bug.cgi?id=84425
Patch by Christophe Dumez <Christophe Dumez> on 2012-04-23
Reviewed by Antonio Gomes.
Source/WebKit/efl:
Add a helper function to DumpRenderTreeSupportEfl, returning
whether or not an element does perform autocompletion.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::elementDoesAutoCompleteForElementWithId):
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
Tools:
Use the new helper in DumpRenderTreeSupportEfl to properly
test whether an element performs autocompletion.
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::elementDoesAutoCompleteForElementWithId):
LayoutTests:
Unskip the newly-passing test now that EFL's LayoutTestController
implements elementDoesAutoCompleteForElementWithId().
- platform/efl/Skipped:
- 9:08 AM Changeset in webkit [114905] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip new failing tests. (less tests == less problem)
- platform/qt-5.0/Skipped:
- 9:04 AM Changeset in webkit [114904] by
-
- 3 edits in trunk/LayoutTests
[EFL] Unskip passing web storage tests
https://bugs.webkit.org/show_bug.cgi?id=84342
Unreviewed gardening.
Unskiped the passing tests and moved the remainig ones to
tests_expectations.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-23
- platform/efl/Skipped:
- platform/efl/test_expectations.txt:
- 8:34 AM Changeset in webkit [114903] by
-
- 2 edits in trunk/Tools
master.cfg cleanup, remove dead codes after r92792.
https://bugs.webkit.org/show_bug.cgi?id=84433
Relanding r114881 after typo fix in UploadBuiltProduct.
Reviewed by Ryosuke Niwa.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- 8:05 AM Changeset in webkit [114902] by
-
- 2 edits in trunk/Source/WebCore
[EFL][WK2] Fix build break when non-cross platform CONTEXT_MENUS are enabled.
https://bugs.webkit.org/show_bug.cgi?id=84136
Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2012-04-23
Reviewed by Andreas Kling.
There was a mismatch between contextMenuItemVector declaration and definition.
Fixed by changing PlatformMenuDescription for EFL port by adding a const modifier.
No new tests required.
- platform/PlatformMenuDescription.h:
(WebCore): Added const modifier to PlatformMenuDescription definition.
- 8:05 AM Changeset in webkit [114901] by
-
- 5 edits in trunk
[EFL][DRT] Need to support requestAnimationFrame
https://bugs.webkit.org/show_bug.cgi?id=84585
Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-23
Reviewed by Martin Robinson.
Tools:
Making requestAnimationFrame() support a default on the EFL build.
- Scripts/build-webkit:
LayoutTests:
Unskipping cases related to requestAnimationFrame().
Moving leftover cases to test_expectations.txt for separate
analysis.
- platform/efl/Skipped:
- platform/efl/test_expectations.txt:
- 7:56 AM Changeset in webkit [114900] by
-
- 7 edits in trunk
[Qt] Add desktop zooming support for QQuickWebView
https://bugs.webkit.org/show_bug.cgi?id=82337
Reviewed by Simon Hausmann.
Source/WebKit2:
Add private C++ API for programmatic zooming.
This is important on desktop where we don't
have any way to zoom currently.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewLegacyPrivate::zoomFactor):
(QQuickWebViewLegacyPrivate::setZoomFactor):
(QQuickWebView::zoomFactor):
(QQuickWebView::setZoomFactor):
- UIProcess/API/qt/qquickwebview_p.h:
- UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate::zoomFactor):
(QQuickWebViewPrivate::setZoomFactor):
(QQuickWebViewPrivate):
(QQuickWebViewLegacyPrivate):
Tools:
Add zooming support for MiniBrowser to
test the new API.
- MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::zoomIn):
(BrowserWindow::zoomOut):
(BrowserWindow::keyPressEvent):
(BrowserWindow::wheelEvent):
- MiniBrowser/qt/BrowserWindow.h:
(BrowserWindow):
- 7:55 AM Changeset in webkit [114899] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Ensure zero-width space effectively accounts for a width of zero.
https://bugs.webkit.org/show_bug.cgi?id=84595
Reviewed by Simon Hausmann.
The logic so far relies on FontCache::getFontDataForCharacters to
return a valid fontData in the case where the fonts specified don't
have a glyph for the zero-width space character.
QTextLayout::glyphRuns simply ignores characters that don't render in
the glyph runs it returns, so we need to ensure that the subsequent
call to platformWidthForGlyph doesn't lead to a non-zero width.
Covered by tests containing control characters such as
a soft-hyphen like it's the case in:
svg/as-image/img-preserveAspectRatio-support-1.html
- platform/graphics/qt/SimpleFontDataQt.cpp:
(WebCore::SimpleFontData::platformWidthForGlyph):
- 7:53 AM Changeset in webkit [114898] by
-
- 4 edits in trunk/Source
[chromium] When prepareToDraw fails due to animation checkerboard, we need to call setNeedsCommit
https://bugs.webkit.org/show_bug.cgi?id=84520
Patch by Ian Vollick <vollick@chromium.org> on 2012-04-23
Reviewed by Adrienne Walker.
Source/WebCore:
Tested in CCLayerTreeHostImplTest.prepareToDrawFailsWhenAnimationUsesCheckerboard
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::prepareToDraw):
Source/WebKit/chromium:
- tests/CCLayerTreeHostImplTest.cpp:
(WebKitTests::TEST_F):
- 7:43 AM Changeset in webkit [114897] by
-
- 50 edits in trunk/Source/WebKit2
[Qt][WK2] Move non-api classes to WebKit namespace at WebKit2/UiProcess/qt
https://bugs.webkit.org/show_bug.cgi?id=84528
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-23
Reviewed by Simon Hausmann.
Fix namespace usage in non-api classes for Qt.
- UIProcess/API/qt/qquickwebpage.cpp:
- UIProcess/API/qt/qquickwebpage_p.h:
(WebKit):
- UIProcess/API/qt/qquickwebpage_p_p.h:
(WebKit):
(QQuickWebPagePrivate):
- UIProcess/API/qt/qquickwebview.cpp:
- UIProcess/API/qt/qquickwebview_p.h:
(WebKit):
- UIProcess/API/qt/qquickwebview_p_p.h:
(WebKit):
(QQuickWebViewPrivate::viewportInteractionEngine):
(QQuickWebViewPrivate):
(QQuickWebViewFlickablePrivate::viewportInteractionEngine):
(QQuickWebViewFlickablePrivate):
- UIProcess/API/qt/qwebdownloaditem_p.h:
(WebKit):
- UIProcess/API/qt/qwebviewportinfo.cpp:
- UIProcess/qt/LayerBackingStore.cpp:
- UIProcess/qt/LayerBackingStore.h:
(WebKit):
- UIProcess/qt/QtDialogRunner.cpp:
(WebKit):
- UIProcess/qt/QtDialogRunner.h:
(WebKit):
- UIProcess/qt/QtDownloadManager.cpp:
- UIProcess/qt/QtDownloadManager.h:
(WebKit):
- UIProcess/qt/QtGestureRecognizer.cpp:
- UIProcess/qt/QtGestureRecognizer.h:
(WebKit):
- UIProcess/qt/QtPageClient.cpp:
(WebKit):
- UIProcess/qt/QtPageClient.h:
(WebKit):
(QtPageClient):
- UIProcess/qt/QtPanGestureRecognizer.cpp:
- UIProcess/qt/QtPanGestureRecognizer.h:
- UIProcess/qt/QtPinchGestureRecognizer.cpp:
- UIProcess/qt/QtPinchGestureRecognizer.h:
- UIProcess/qt/QtTapGestureRecognizer.h:
(WebKit):
- UIProcess/qt/QtViewportInteractionEngine.cpp:
- UIProcess/qt/QtViewportInteractionEngine.h:
- UIProcess/qt/QtWebContext.cpp:
- UIProcess/qt/QtWebContext.h:
- UIProcess/qt/QtWebError.cpp:
(WebKit):
- UIProcess/qt/QtWebError.h:
(WebKit):
- UIProcess/qt/QtWebIconDatabaseClient.cpp:
(WebKit):
- UIProcess/qt/QtWebIconDatabaseClient.h:
(WTF):
(WebKit):
(QtWebIconDatabaseClient):
- UIProcess/qt/QtWebPageEventHandler.cpp:
(WebKit):
- UIProcess/qt/QtWebPageEventHandler.h:
(WebCore):
(WebKit):
- UIProcess/qt/QtWebPageLoadClient.cpp:
(WebKit):
- UIProcess/qt/QtWebPageLoadClient.h:
(WebKit):
- UIProcess/qt/QtWebPagePolicyClient.cpp:
(WebKit):
- UIProcess/qt/QtWebPagePolicyClient.h:
(WebKit):
- UIProcess/qt/QtWebPageSGNode.cpp:
- UIProcess/qt/QtWebPageSGNode.h:
(WebKit):
- UIProcess/qt/QtWebPageUIClient.cpp:
- UIProcess/qt/QtWebPageUIClient.h:
(WebKit):
- UIProcess/qt/QtWebUndoController.cpp:
(WebKit):
- UIProcess/qt/QtWebUndoController.h:
(WebKit):
- UIProcess/qt/WebContextMenuProxyQt.cpp:
- UIProcess/qt/WebContextQt.cpp:
- UIProcess/qt/WebFullScreenManagerProxyQt.cpp:
- UIProcess/qt/WebGeolocationProviderQt.cpp:
(WebKit):
- UIProcess/qt/WebGeolocationProviderQt.h:
(WebKit):
- UIProcess/qt/WebPopupMenuProxyQt.cpp:
(WebKit):
- UIProcess/qt/WebPopupMenuProxyQt.h:
- 7:35 AM Changeset in webkit [114896] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84596
Mark media/encrypted-media/encrypted-media-events.html as flaky.
- platform/chromium/test_expectations.txt:
- 7:26 AM Changeset in webkit [114895] by
-
- 7 edits in trunk
Simplify CSSParser::parseFont.
https://bugs.webkit.org/show_bug.cgi?id=78698
Reviewed by Antti Koivisto.
Source/WebCore:
Simplify parseFont by sharing the code we have for
the longhands of the font property.
No new tests : Extend the existing font shorthand test and modify expected files
as now the order of the longhands added in the property list of the style
has changed. It's very unlikely that some code is relying on this order though. It will
also match the way the spec order them http://www.w3.org/TR/css3-fonts/#font-prop
even though the order is arbitrary for some values.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFont):
(WebCore::CSSParser::parseLineHeight):
(WebCore):
(WebCore::CSSParser::parseFontSize):
(WebCore::CSSParser::parseFontWeight): Fix a bug discovered while using parseFontWeight from
the parseFont (case font: 0/0, Arial, sans-serif; in a layout test), we should return true only
when we add something in the property list.
- css/CSSParser.h:
LayoutTests:
Added new incorrect values to improve the test coverage of the font shorthand property.
The patch changed the order the longhands are added to the list
of properties for the style so the expected files need to be updated.
- fast/css/font-shorthand-expected.txt:
- fast/css/font-shorthand.html:
- fast/inspector-support/style-expected.txt:
- 6:48 AM Changeset in webkit [114894] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: improve the way heap snapshot diff is calculated
https://bugs.webkit.org/show_bug.cgi?id=84590
Diff calculation now consists of the following steps:
- Collect data about nodes in the base heap snapshot
- Pass it to the second snapshot.
- Calculate delta for each class.
Reviewed by Pavel Feldman.
- inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot):
(WebInspector.HeapSnapshot.prototype.dispose):
(WebInspector.HeapSnapshot.prototype.aggregatesForDiff):
(WebInspector.HeapSnapshot.prototype.calculateSnapshotDiff):
(WebInspector.HeapSnapshot.prototype._calculateDiffForClass):
(WebInspector.HeapSnapshot.prototype.createAddedNodesProvider):
(WebInspector.HeapSnapshot.prototype.createDeletedNodesProvider):
- inspector/front-end/HeapSnapshotDataGrids.js:
(WebInspector.HeapSnapshotDiffDataGrid.prototype._populateChildren.aggregatesForDiffReceived.didCalculateSnapshotDiff):
(WebInspector.HeapSnapshotDiffDataGrid.prototype._populateChildren):
- inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotIteratorsTuple):
(WebInspector.HeapSnapshotDiffNode):
(WebInspector.HeapSnapshotDiffNode.prototype._createChildNode):
(WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider):
- inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotProxy.prototype.aggregatesForDiff):
(WebInspector.HeapSnapshotProxy.prototype.calculateSnapshotDiff):
(WebInspector.HeapSnapshotProxy.prototype.createAddedNodesProvider):
(WebInspector.HeapSnapshotProxy.prototype.createDeletedNodesProvider):
- inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype._changeBase):
- 6:39 AM Changeset in webkit [114893] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
http://webkit.org/b/72402
Unmark compositing/layer-creation/overflow-scroll-overlap.html as failing
- platform/chromium/test_expectations.txt:
- 6:26 AM Changeset in webkit [114892] by
-
- 13 edits1 add in trunk
Web Inspector: Rename and extract UISourceCodeImpl into JavaScriptSource
https://bugs.webkit.org/show_bug.cgi?id=84587
Reviewed by Yury Semikhatsky.
Source/WebCore:
No changes other than extraction here. This is the first step in the Resource
hierarchy refactoring described in bug 84586.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/CompilerScriptMapping.js:
(WebInspector.CompilerScriptMapping.prototype.addScript):
- inspector/front-end/DebuggerPresentationModel.js:
- inspector/front-end/JavaScriptSource.js: Added.
(WebInspector.JavaScriptSource):
(WebInspector.JavaScriptSource.prototype.breakpoints):
(WebInspector.JavaScriptSource.prototype.breakpointAdded):
(WebInspector.JavaScriptSource.prototype.breakpointRemoved):
(WebInspector.JavaScriptSource.prototype.consoleMessages):
(WebInspector.JavaScriptSource.prototype.consoleMessageAdded):
(WebInspector.JavaScriptSource.prototype.consoleMessagesCleared):
- inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype._createUISourceCode):
- inspector/front-end/SnippetsModel.js:
(WebInspector.SnippetsScriptMapping.prototype._snippetAdded):
(WebInspector.SnippetsScriptMapping.prototype._createUISourceCodeForScript):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
LayoutTests:
- inspector/debugger/breakpoint-manager.html:
- inspector/debugger/scripts-panel.html:
- 6:15 AM Changeset in webkit [114891] by
-
- 2 edits in trunk/Source/WebKit/chromium
Chromium roll from r133348 to r133422.
- DEPS:
- 5:53 AM Changeset in webkit [114890] by
-
- 13 edits1 add in trunk/Source
Move ReferrerPolicy out of SecurityPolicy class into its own header in platform.
https://bugs.webkit.org/show_bug.cgi?id=84516
Source/WebCore:
Reviewed by Adam Barth.
No change in behaviour; same enum, different class.
- GNUmakefile.list.am:
- Target.pri:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::processReferrerPolicy):
- dom/Document.h:
(WebCore::Document::referrerPolicy):
(Document):
- page/SecurityPolicy.h:
- platform/ReferrerPolicy.h: Added.
(WebCore):
Source/WebKit/chromium:
Reviewed by Adam Barth.
No change in behaviour; same enum, different class.
- src/AssertMatchingEnums.cpp:
- src/WebSecurityPolicy.cpp:
(WebKit::WebSecurityPolicy::generateReferrerHeader):
- 5:37 AM Changeset in webkit [114889] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=70765
Unmark fast/forms/listbox-clip.html on Windows
- platform/chromium/test_expectations.txt:
- 5:15 AM Changeset in webkit [114888] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
http://crbug.com/23494
Unmark css2.1/t1503-c522-font-family-00-b.html on Leopard.
- platform/chromium/test_expectations.txt:
- 4:34 AM Changeset in webkit [114887] by
-
- 11 edits in trunk/Source/WebCore
JS binding code generator doesn't handle "attribute unsigned long[]" well
https://bugs.webkit.org/show_bug.cgi?id=84540
Patch by Vineet Chaudhary <Vineet> on 2012-04-23
Reviewed by Kentaro Hara.
Codegenerator should handle spaces with the sequence<> to support
numeric types like "unsigned long", "int" .. etc. and primitive types
like "boolean", "Date" etc.
Tests: bindings/scripts/test/TestObj.idl
- bindings/scripts/CodeGenerator.pm:
(SkipIncludeHeader): Rename AvoidInclusionOfType to SkipIncludeHeader.
(GetArrayType):
- bindings/scripts/CodeGeneratorJS.pm:
(AddIncludesForType):
(NativeToJSValue):
- bindings/scripts/CodeGeneratorObjC.pm:
(AddIncludesForType):
(GenerateImplementation):
- bindings/scripts/CodeGeneratorV8.pm:
(AddIncludesForType):
(GetHeaderClassInclude):
(GenerateNormalAttrGetter):
(NativeToJSValue):
- bindings/scripts/IDLStructure.pm:
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
(WebCore::jsTestObjIntSequenceAttr):
(WebCore::jsTestObjShortSequenceAttr):
(WebCore::jsTestObjLongSequenceAttr):
(WebCore::jsTestObjLongLongSequenceAttr):
(WebCore::jsTestObjUnsignedIntSequenceAttr):
(WebCore::jsTestObjUnsignedShortSequenceAttr):
(WebCore::jsTestObjUnsignedLongSequenceAttr):
(WebCore::jsTestObjUnsignedLongLongSequenceAttr):
(WebCore::jsTestObjFloatSequenceAttr):
(WebCore::jsTestObjDoubleSequenceAttr):
(WebCore::jsTestObjBooleanSequenceAttr):
(WebCore::jsTestObjVoidSequenceAttr):
(WebCore::jsTestObjDateSequenceAttr):
(WebCore::setJSTestObjSequenceAttr):
(WebCore::setJSTestObjIntSequenceAttr):
(WebCore::setJSTestObjShortSequenceAttr):
(WebCore::setJSTestObjLongSequenceAttr):
(WebCore::setJSTestObjLongLongSequenceAttr):
(WebCore::setJSTestObjUnsignedIntSequenceAttr):
(WebCore::setJSTestObjUnsignedShortSequenceAttr):
(WebCore::setJSTestObjUnsignedLongSequenceAttr):
(WebCore::setJSTestObjUnsignedLongLongSequenceAttr):
(WebCore::setJSTestObjFloatSequenceAttr):
(WebCore::setJSTestObjDoubleSequenceAttr):
(WebCore::setJSTestObjBooleanSequenceAttr):
(WebCore::setJSTestObjVoidSequenceAttr):
(WebCore::setJSTestObjDateSequenceAttr):
- bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::intSequenceAttrAttrGetter):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::intSequenceAttrAttrSetter):
(WebCore::TestObjV8Internal::shortSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::shortSequenceAttrAttrSetter):
(WebCore::TestObjV8Internal::longSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::longSequenceAttrAttrSetter):
(WebCore::TestObjV8Internal::longLongSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::longLongSequenceAttrAttrSetter):
(WebCore::TestObjV8Internal::unsignedIntSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::unsignedIntSequenceAttrAttrSetter):
(WebCore::TestObjV8Internal::unsignedShortSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::unsignedShortSequenceAttrAttrSetter):
(WebCore::TestObjV8Internal::unsignedLongSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::unsignedLongSequenceAttrAttrSetter):
(WebCore::TestObjV8Internal::unsignedLongLongSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::unsignedLongLongSequenceAttrAttrSetter):
(WebCore::TestObjV8Internal::floatSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::floatSequenceAttrAttrSetter):
(WebCore::TestObjV8Internal::doubleSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::doubleSequenceAttrAttrSetter):
(WebCore::TestObjV8Internal::booleanSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::booleanSequenceAttrAttrSetter):
(WebCore::TestObjV8Internal::voidSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::voidSequenceAttrAttrSetter):
(WebCore::TestObjV8Internal::dateSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::dateSequenceAttrAttrSetter):
(WebCore):
- 3:50 AM Changeset in webkit [114886] by
-
- 2 edits in trunk/Tools
Unreviewed rolling out r114881, because it broke upload buildstep.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(ConfigureBuild.init):
(ConfigureBuild.start):
(CompileWebKit.start):
(UploadBuiltProduct):
(UploadBuiltProduct.determineExtraFeatures):
(Factory.init):
(BuildFactory.init):
(TestFactory.init):
(loadBuilderConfig):
- 3:44 AM Changeset in webkit [114885] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed assertion fix for Chromium bots.
Skip unnecessary Attr::attachToElement() after constructing an Attr using the
constructor that attaches to an Element.
- dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::ensureAttr):
- 3:38 AM Changeset in webkit [114884] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
Unmark fast/regex/unicodeCaseInsensitive.html -- the bug has been
fixed long ago, and the test is passing now.
- platform/chromium/test_expectations.txt:
- 3:17 AM Changeset in webkit [114883] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r114870): Assertion failure in ElementAttributeData::setAttr().
<http://webkit.org/b/84581>
Reviewed by Antti Koivisto.
Attach the Attr and bump m_attrCount manually in ensureAttr() instead of calling
setAttr(). The latter asserts that the Attr isn't present in the map, which
obviously isn't true after we've just added it.
This has the added effect of removing one unnecessary hash lookup.
- dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::ensureAttr):
- 2:42 AM Changeset in webkit [114882] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: make ParsedURL.prototype.displayName data url friendly.
https://bugs.webkit.org/show_bug.cgi?id=84578
Reviewed by Yury Semikhatsky.
We'd like to define valid URL as the one that has scheme, host and path.
We can append to this URL and manipulate its content. We still want
possibly invalid specs (such as data or about) to exist and have nice
display names.
- inspector/front-end/ResourceUtils.js:
(WebInspector.ParsedURL):
(WebInspector.ParsedURL.prototype.get displayName):
- 1:51 AM Changeset in webkit [114881] by
-
- 2 edits in trunk/Tools
master.cfg cleanup, remove dead codes after r92792.
https://bugs.webkit.org/show_bug.cgi?id=84433
Reviewed by Ryosuke Niwa.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- 1:49 AM Changeset in webkit [114880] by
-
- 17 edits in trunk/Source/WebCore
Web Inspector: introduce String.prototype.starts/endsWith and use it all over the place.
https://bugs.webkit.org/show_bug.cgi?id=84574
Reviewed by Yury Semikhatsky.
- inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.VendorPrefixedCSSProperties.prototype.visitProperty):
- inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint):
- inspector/front-end/CSSCompletions.js:
(WebInspector.CSSCompletions.prototype.startsWith):
(WebInspector.CSSCompletions.prototype._firstIndexOfPrefix):
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._reportCompletions):
- inspector/front-end/CookieItemsView.js:
(WebInspector.Cookies.cookieMatchesResourceURL):
- inspector/front-end/DatabaseQueryView.js:
(WebInspector.DatabaseQueryView.prototype.completions):
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._buildAttributeDOM):
- inspector/front-end/ProfileView.js:
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.addProfileHeader):
(WebInspector.ProfilesPanel.prototype.displayTitleForProfileLink):
(WebInspector.ProfileSidebarTreeElement):
(WebInspector.ProfileSidebarTreeElement.prototype.get mainTitle):
- inspector/front-end/ResourceUtils.js:
(WebInspector.ParsedURL):
(WebInspector.displayNameForURL):
(WebInspector.linkifyStringAsFragmentWithCustomLinkifier):
(WebInspector.completeURL):
- inspector/front-end/SnippetsModel.js:
(WebInspector.SnippetsModel.prototype.snippetIdForSourceURL):
- inspector/front-end/SourceCSSTokenizer.js:
(WebInspector.SourceCSSTokenizer.prototype.nextToken):
- inspector/front-end/SourceCSSTokenizer.re2js:
- inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype._completeCommonPrefix):
- inspector/front-end/UIUtils.js:
(WebInspector.startEditing):
- inspector/front-end/utilities.js:
- 1:40 AM Changeset in webkit [114879] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r114870): Performance hit on DOM/CloneNodes and DOM/CreateNodes.
<http://webkit.org/b/84575>
Reviewed by Antti Koivisto.
Simplify the cloning of Attributes from one Element to another by simply
assigning to m_attributes. This avoids default-constructing a bunch of
Attribute objects that we overwrite immediately anyway (this used to be
fine because they were RefPtr<Attribute> but now that a default-constructed
Attribute contains a QualifiedName, we were doing a bunch of extra hash
lookups, etc.)
- dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::setAttributes):
- 1:05 AM Changeset in webkit [114878] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: implement "open stylesheet" dialog.
https://bugs.webkit.org/show_bug.cgi?id=84466
Reviewed by Yury Semikhatsky.
This change introduces abstract OpenResourceDialog and re-uses it in OpenScriptDialog and OpenStylesheetDialog.
Drive-by fix for data: url representation in the navigator and open resource dialogs.
- inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog.prototype.position):
(WebInspector.OpenResourceDialog.filterOutEmptyURLs):
(WebInspector.OpenResourceDialog.compareFunction):
(WebInspector.OpenResourceDialog):
(WebInspector.OpenResourceDialog.prototype.itemTitleAt):
(WebInspector.OpenResourceDialog.prototype.itemKeyAt):
(WebInspector.OpenResourceDialog.prototype.itemsCount):
(WebInspector.OpenResourceDialog.prototype.requestItems):
(WebInspector.OpenResourceDialog.prototype.selectItem):
(WebInspector.OpenScriptDialog):
(WebInspector.OpenScriptDialog.install):
(WebInspector.OpenScriptDialog._show):
(WebInspector.OpenScriptDialog.prototype.selectItem):
- inspector/front-end/ResourceUtils.js:
(WebInspector.ParsedURL):
- inspector/front-end/ScriptsPanel.js:
- inspector/front-end/StylesPanel.js:
(WebInspector.StylesPanel):
(WebInspector.StylesPanel.prototype._showOpenStylesheetDialog):
(WebInspector.OpenStylesheetDialog):
(WebInspector.OpenStylesheetDialog.prototype.selectItem):
- inspector/front-end/inspector.html:
- 1:00 AM Changeset in webkit [114877] by
-
- 12 edits1 add1 delete in trunk
Add test function to get placeholder string
https://bugs.webkit.org/show_bug.cgi?id=84536
Reviewed by Ryosuke Niwa.
.:
- Source/autotools/symbols.filter:
Expose Node::textContent and HTMLTextFormControlElement::placeholderShouldBeVisible.
Source/WebCore:
Add window.internals.visiblePlaceholder(element), which returns a
placeholder string only when it's visible.
- WebCore.exp.in: Expose HTMLTextFormControlElement::placeholderShouldBeVisible().
- testing/Internals.cpp:
(WebCore::Internals::visiblePlaceholder): Added.
(WebCore::Internals::selectColorInColorChooser): Omit HTMLNames::.
- testing/Internals.h:
(Internals): Add visiblePlaceholder().
- testing/Internals.idl: ditto.
Source/WebKit2:
- win/WebKit2.def: Expose HTMLNames::inputTag,
HTMLTextFormControlElement::placeholderShouldBeVisible(), and
Node::textContent.
- win/WebKit2CFLite.def: ditto.
LayoutTests:
Make placeholder-stripped.html a dumpAsText test.
- fast/forms/placeholder-stripped-expected.html: Removed.
- fast/forms/placeholder-stripped-expected.txt: Added.
- fast/forms/placeholder-stripped.html:
- 12:47 AM Changeset in webkit [114876] by
-
- 3 edits2 adds in trunk
Source/WebCore: Incorrect handling of CSS escape sequences that encode surrogates
https://bugs.webkit.org/show_bug.cgi?id=76152
Patch by Szilard Ledan <Szilárd LEDÁN> on 2012-04-23
Reviewed by Kent Tamura.
Test: fast/css/parsing-css-surrogate-pairs.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseEscape):
LayoutTests: Added a test for css surrogate pairs parser
https://bugs.webkit.org/show_bug.cgi?id=76152
Patch by Szilard Ledan <Szilárd LEDÁN> on 2012-04-23
Reviewed by Kent Tamura.
- fast/css/parsing-css-surrogate-pairs-expected.txt: Added.
- fast/css/parsing-css-surrogate-pairs.html: Added.
- 12:10 AM Changeset in webkit [114875] by
-
- 2 edits in trunk/Tools
[Qt] Make DRT not dump pixel results if test is calling layoutTestController.dumpAsText()
https://bugs.webkit.org/show_bug.cgi?id=84327
Patch by Milian Wolff <mail@milianw.de> on 2012-04-23
Reviewed by Csaba Osztrogonác.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::dump):
Apr 22, 2012:
- 11:37 PM Changeset in webkit [114874] by
-
- 8 edits in trunk/LayoutTests
Add Notification constructor
https://bugs.webkit.org/show_bug.cgi?id=80477
[Qt] Unreviewed gardening after r114855.
- platform/qt-4.8/fast/dom/Window/window-properties-expected.txt:
- platform/qt-5.0-wk2/fast/dom/Window/window-properties-expected.txt:
- platform/qt-5.0-wk2/fast/dom/prototype-inheritance-2-expected.txt:
- platform/qt-5.0/fast/dom/Window/window-properties-expected.txt:
- platform/qt-5.0/fast/dom/prototype-inheritance-2-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
- 11:30 PM Changeset in webkit [114873] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed, add a baseline for computed style test after r114766.
- platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt: Added.
- 11:16 PM Changeset in webkit [114872] by
-
- 6 edits in trunk
Web Inspector: make populateChildren methods private in heap profiler front-end
https://bugs.webkit.org/show_bug.cgi?id=84562
Source/WebCore:
- populateChildren method on HeapSnapshotConstructorsDataGrid and
HeapSnapshotDiffDataGrid now is private.
- Made _defaultPopulateCount a public method on HeapSnapshotSortableDataGrid which
is overriden in some descendants
- Removed unused HeapSnapshotPathFinderProxy
- added closure compiler annotations
Reviewed by Pavel Feldman.
- inspector/front-end/HeapSnapshotDataGrids.js:
(WebInspector.HeapSnapshotSortableDataGrid.prototype.defaultPopulateCount):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._filterSelectIndexChanged):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.defaultPopulateCount):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype.defaultPopulateCount):
- inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren.callSerialize):
(WebInspector.HeapSnapshotDiffNode):
(WebInspector.HeapSnapshotDiffNode.prototype.populateChildren.firstProviderPopulated):
- inspector/front-end/HeapSnapshotProxy.js:
LayoutTests:
- Made _defaultPopulateCount a public method on HeapSnapshotSortableDataGrid which
is overriden in some descendants
Reviewed by Pavel Feldman.
- inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest.InspectorTest.startProfilerTest.detailedHeapProfilesEnabled.WebInspector.HeapSnapshotContainmentDataGrid.prototype.defaultPopulateCount):
(initialize_HeapSnapshotTest.InspectorTest.startProfilerTest.detailedHeapProfilesEnabled.WebInspector.HeapSnapshotConstructorsDataGrid.prototype.defaultPopulateCount):
(initialize_HeapSnapshotTest.InspectorTest.startProfilerTest.detailedHeapProfilesEnabled.WebInspector.HeapSnapshotDiffDataGrid.prototype.defaultPopulateCount):
(initialize_HeapSnapshotTest.InspectorTest.startProfilerTest.detailedHeapProfilesEnabled.WebInspector.HeapSnapshotDominatorsDataGrid.prototype.defaultPopulateCount):
(initialize_HeapSnapshotTest.InspectorTest.startProfilerTest.detailedHeapProfilesEnabled):
- 10:59 PM Changeset in webkit [114871] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix, remove Attribute.cpp from DOMAllInOne.cpp.
- dom/DOMAllInOne.cpp: My nemesis.
- 10:40 PM Changeset in webkit [114870] by
-
- 37 edits5 deletes in trunk/Source
Optimize Element attribute storage for the common case (no Attr objects.)
<http://webkit.org/b/83440>
Reviewed by Antti Koivisto.
Source/WebCore:
Reduce Attribute to its smallest possible size; a qname/value pair.
They are no-longer ref-counted, which allows us to store them in Vectors.
Refactored the DOM Attr object to go with the new Attribute:
Attr now wraps either {element, qname} or {qname, value}. The latter is for
the case where a standalone Attr object is instantiated via DOM APIs.
ElementAttributeData.cpp manages a map of pair<element, qname> => Attr.
Each Element (well, ElementAttributeData) keeps track of how many Attr
objects are pointing to it. This is so we can avoid hash lookups during
common operations in the typical case where you have zero Attrs.
Also removed the inline capacity (was 4) from AttributeVector as that
would significantly increase bloat now that we store Attribute (2 pointers)
rather than RefPtr<Attribute>. We trade this one piece of indirection
for the removal of per-Attribute indirection.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/Attr.cpp:
(WebCore::Attr::Attr):
(WebCore):
(WebCore::Attr::create):
(WebCore::Attr::~Attr):
(WebCore::Attr::createTextChild):
(WebCore::Attr::setPrefix):
(WebCore::Attr::setValue):
(WebCore::Attr::cloneNode):
(WebCore::Attr::childrenChanged):
(WebCore::Attr::style):
(WebCore::Attr::value):
(WebCore::Attr::elementAttribute):
(WebCore::Attr::detachFromElementWithValue):
(WebCore::Attr::attachToElement):
- dom/Attr.h:
(WebCore):
(Attr):
(WebCore::Attr::qualifiedName):
(WebCore::Attr::localName):
(WebCore::Attr::namespaceURI):
(WebCore::Attr::prefix):
- dom/Attribute.cpp: Removed.
- dom/Attribute.h:
(WebCore::Attribute::Attribute):
(Attribute):
- dom/Document.cpp:
(WebCore::Document::importNode):
(WebCore::Document::createAttributeNS):
- dom/Element.cpp:
(WebCore::Element::~Element):
(WebCore::Element::detachAttribute):
(WebCore):
(WebCore::Element::removeAttribute):
(WebCore::Element::setAttributeInternal):
(WebCore::Element::parserSetAttributes):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeNode):
(WebCore::Element::normalizeAttributes):
(WebCore::Element::didRemoveAttribute):
(WebCore::Element::attrIfExists):
(WebCore::Element::ensureAttr):
- dom/Element.h:
(Element):
(WebCore::Element::getAttributeItemIndex):
- dom/ElementAttributeData.cpp:
(WebCore):
(WebCore::attrMap):
(WebCore::ElementAttributeData::attrIfExists):
(WebCore::ElementAttributeData::ensureAttr):
(WebCore::ElementAttributeData::setAttr):
(WebCore::ElementAttributeData::removeAttr):
(WebCore::AttributeVector::removeAttribute):
(WebCore::ElementAttributeData::~ElementAttributeData):
(WebCore::ElementAttributeData::addAttribute):
(WebCore::ElementAttributeData::removeAttribute):
(WebCore::ElementAttributeData::isEquivalent):
(WebCore::ElementAttributeData::detachAttributesFromElement):
(WebCore::ElementAttributeData::getAttributeItemIndexSlowCase):
(WebCore::ElementAttributeData::setAttributes):
(WebCore::ElementAttributeData::clearAttributes):
(WebCore::ElementAttributeData::replaceAttribute):
(WebCore::ElementAttributeData::getAttributeNode):
- dom/ElementAttributeData.h:
(WebCore):
(WebCore::AttributeVector::AttributeVector):
(AttributeVector):
(WebCore::AttributeVector::getAttributeItem):
(WebCore::AttributeVector::getAttributeItemIndex):
(WebCore::AttributeVector::insertAttribute):
(WebCore::ElementAttributeData::attributeItem):
(ElementAttributeData):
(WebCore::ElementAttributeData::ElementAttributeData):
(WebCore::ElementAttributeData::attributeVector):
(WebCore::ElementAttributeData::clonedAttributeVector):
(WebCore::ElementAttributeData::removeAttribute):
(WebCore::ElementAttributeData::getAttributeItem):
(WebCore::ElementAttributeData::getAttributeItemIndex):
- dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::getNamedItem):
(WebCore::NamedNodeMap::getNamedItemNS):
(WebCore::NamedNodeMap::removeNamedItem):
(WebCore::NamedNodeMap::removeNamedItemNS):
(WebCore::NamedNodeMap::item):
- dom/Node.cpp:
(WebCore::Node::compareDocumentPosition):
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::parseAttribute):
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::parseAttribute):
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):
(WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement):
(WebCore::HTMLConstructionSite::insertScriptElement):
(WebCore::HTMLConstructionSite::createElement):
(WebCore::HTMLConstructionSite::createHTMLElement):
(WebCore::HTMLConstructionSite::createHTMLElementFromSavedElement):
- html/parser/HTMLToken.h:
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processFakeStartTag):
(WebCore::HTMLTreeBuilder::attributesForIsindexInput):
(WebCore::HTMLTreeBuilder::processIsindexStartTagForInBody):
(WebCore):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
- html/parser/HTMLTreeBuilder.h:
- html/parser/TextDocumentParser.cpp:
(WebCore::TextDocumentParser::insertFakePreElement):
- page/PageSerializer.cpp:
(WebCore::SerializerMarkupAccumulator::appendCustomAttributes):
- svg/SVGFitToViewBox.cpp:
- svg/properties/SVGAnimatedPropertySynchronizer.h:
- xml/XMLErrors.cpp:
(WebCore::createXHTMLParserErrorHeader):
(WebCore::XMLErrors::insertErrorMessageBlock):
- xml/XPathNodeSet.cpp:
(WebCore::XPath::NodeSet::traversalSort):
- xml/XPathStep.cpp:
(WebCore::XPath::Step::nodesInAxis):
- xml/parser/MarkupTokenBase.h:
(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):
(WebCore::AtomicMarkupTokenBase::getAttributeItem):
(WebCore::AtomicMarkupTokenBase::attributes):
(AtomicMarkupTokenBase):
(WebCore::::initializeAttributes):
- xml/parser/XMLToken.h:
(WebCore::AtomicXMLToken::AtomicXMLToken):
- xml/parser/XMLTreeBuilder.cpp:
(WebCore::XMLTreeBuilder::processNamespaces):
(WebCore::XMLTreeBuilder::processAttributes):
Source/WebKit/chromium:
Remove the WebNamedNodeMap and WebAttribute API classes since they are no
longer needed by chromium after <http://crrev.com/133299>.
- WebKit.gyp:
- public/WebAttribute.h: Removed.
- public/WebElement.h:
- public/WebNamedNodeMap.h: Removed.
- src/WebAttribute.cpp: Removed.
- src/WebElement.cpp:
- src/WebNamedNodeMap.cpp: Removed.
- 10:30 PM Changeset in webkit [114869] by
-
- 11 edits in trunk
.: [Gtk] Added MOZ_X11 build flag for TARGET_X11
[Qt] Added MOZ_X11 build flag for !embedded
[CMake] Added MOZ_X11 build flag for WTF_OS_UNIX
https://bugs.webkit.org/show_bug.cgi?id=40785
Patch by Sriram Neelakandan <sriram.neelakandan@gmail.com> on 2012-04-22
Reviewed by Anders Carlsson.
- GNUmakefile.am:
- Source/cmake/OptionsCommon.cmake:
Source/WebCore: Sync the MOZ_X11 changes from r14 of http://code.google.com/p/npapi-sdk/
also, modified required build flags for Qt,Gtk and CMake
[Qt] Added MOZ_X11 build flag for !embedded
https://bugs.webkit.org/show_bug.cgi?id=40785
Patch by Sriram Neelakandan <sriram.neelakandan@gmail.com> on 2012-04-22
Reviewed by Anders Carlsson.
No new tests. This does not change functionality. Affects all X11 Ports. Build should break if MOZ_X11 is not passed where required
- WebCore.pri:
- plugins/npapi.h:
Source/WebKit2: [Gtk] Added MOZ_X11 build flag for TARGET_X11
[Qt] Added MOZ_X11 build flag for !embedded
https://bugs.webkit.org/show_bug.cgi?id=40785
Patch by Sriram Neelakandan <sriram.neelakandan@gmail.com> on 2012-04-22
Reviewed by Anders Carlsson.
- GNUmakefile.am:
- Target.pri:
Tools: [Gtk] Added MOZ_X11 build flag for TARGET_X11
https://bugs.webkit.org/show_bug.cgi?id=40785
Patch by Sriram Neelakandan <sriram.neelakandan@gmail.com> on 2012-04-22
Reviewed by Anders Carlsson.
- GNUmakefile.am:
- 10:22 PM Changeset in webkit [114868] by
-
- 2 edits in trunk/Tools
[TestResultsServer] Impossible to inspect builds on non-Chromium builders
https://bugs.webkit.org/show_bug.cgi?id=84544
Reviewed by Ryosuke Niwa.
Use the groupEnum parameter that is passed through to the onBuilderListLoad
function rather than an undefined attribute of the BuilderGroup object. This
makes it again possible to inspect builds on non-Chromium builders in the
test results server by not trying to always add Chromium revision links.
- TestResultServer/static-dashboards/builders.js:
- 10:19 PM Changeset in webkit [114867] by
-
- 3 edits2 adds in trunk
Reset event propagation and canceled flags in Event.initEvent
https://bugs.webkit.org/show_bug.cgi?id=83964
Patch by Pablo Flouret <pablof@motorola.com> on 2012-04-22
Reviewed by Ryosuke Niwa.
Step 3 in http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#dom-event-initevent
Useful for re-configuring an event before dispatching.
Source/WebCore:
Test: fast/events/flags-unset-on-init-event.html
- dom/Event.cpp:
(WebCore::Event::initEvent):
LayoutTests:
- fast/events/flags-unset-on-init-event-expected.txt: Added.
- fast/events/flags-unset-on-init-event.html: Added.
- 9:48 PM Changeset in webkit [114866] by
-
- 2 edits in trunk/LayoutTests
Replace an undefined variable with a constant
https://bugs.webkit.org/show_bug.cgi?id=84427
Reviewed by Ryosuke Niwa.
Unfortunately, my r114605 uses an undefined variable 'sleepPeriod' and it
causes a JavaScript exception. This change replaces this variable with 1.
- platform/chromium/editing/spelling/delete-misspelled-word.html:
- 7:13 PM Changeset in webkit [114865] by
-
- 6 edits in trunk
[GTK] Remove the obsolete Hildon UI extensions
https://bugs.webkit.org/show_bug.cgi?id=83420
Patch by Adrian Bunk <bunk@stusta.de> on 2012-04-22
Reviewed by Martin Robinson.
.:
- configure.ac:
Source/WebKit/gtk:
- GNUmakefile.am:
- WebCoreSupport/EditorClientGtk.cpp:
(WebKit::EditorClient::setInputMethodState):
- webkit/webkitwebview.cpp:
(webkit_web_view_button_release_event):
- 5:56 PM Changeset in webkit [114864] by
-
- 2 edits in trunk/Source/WebCore
[Cairo] Implement CompositeDifference
https://bugs.webkit.org/show_bug.cgi?id=77354
Reviewed by Alejandro G. Castro.
No new tests. The difference compositing operator are not exposed
to web content, so this change is simply in preparation for a time
in which it is used.
Properly map the difference compositing blend modes to a Cairo operator.
- platform/graphics/cairo/CairoUtilities.cpp:
(WebCore::toCairoOperator): Add a mapping for difference. Remove
code supporting versions of Cairo before 1.10, since the Cairo backend
requires 1.10 or greater already.
- 4:01 PM Changeset in webkit [114863] by
-
- 8 edits in trunk/Source
Remove notifications support on Mac Lion.
https://bugs.webkit.org/show_bug.cgi?id=84554
<rdar://problem/11297128>
Reviewed by Sam Weinig.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- 3:27 PM Changeset in webkit [114862] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Fix clang build after r114827, unreviewed.
- tests/LayerTextureUpdaterTest.cpp:
(WebCore::TEST):
- 2:52 PM Applications using WebKit edited by
- add Wakanda server ina new Server section (diff)
- 2:37 PM Applications using WebKit edited by
- add Wakanda studio in "Web Development Applications" section (diff)
- 2:27 PM Changeset in webkit [114861] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
Mark fast/canvas/2d.text.draw.fill.maxWidth.gradient.html as flaky on Mac 10.6
- platform/chromium/test_expectations.txt:
- 2:17 PM Changeset in webkit [114860] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
fast/workers/storage/interrupt-database.html can also TIMEOUT in debug.
- platform/chromium/test_expectations.txt:
- 2:06 PM Changeset in webkit [114859] by
-
- 1 edit1 add in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
css3/zoom-coords-expected.txt now passes on Mac
According to bot logs this is after <http://trac.webkit.org/changeset/114813>
- platform/chromium-mac/css3/zoom-coords-expected.txt: Added.
- 1:58 PM April 2012 Meeting edited by
- (diff)
- 1:22 PM Changeset in webkit [114858] by
-
- 4 edits in trunk/Source
[chromium] Damage Tracker needs to use CCMathUtil transforms
https://bugs.webkit.org/show_bug.cgi?id=84070
Reviewed by Adrienne Walker.
Source/WebCore:
Unit test added to CCDamageTracker.cpp.
This patch makes CCDamageTracker use CCMathUtil transforms, so
that perspective w < 0 problem is correctly handled.
- platform/graphics/chromium/cc/CCDamageTracker.cpp:
(WebCore::CCDamageTracker::extendDamageForLayer):
(WebCore::CCDamageTracker::extendDamageForRenderSurface):
Source/WebKit/chromium:
- tests/CCDamageTrackerTest.cpp:
(WebKitTests::TEST_F):
(WebKitTests):
- 11:45 AM April 2012 Meeting edited by
- (diff)
- 11:44 AM April 2012 Meeting edited by
- (diff)
- 10:39 AM April 2012 Meeting edited by
- Add link about the Web Component Model status-update notes in the … (diff)
- 9:43 AM Changeset in webkit [114857] by
-
- 3 edits in trunk/Source/WebKit2
[Qt] Multi-level tap-to-zoom.
https://bugs.webkit.org/show_bug.cgi?id=84456
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-22
Reviewed by Kenneth Rohde Christiansen.
Replace tap-to-zoomed flag with a stack of progressively higher zoom levels,
and zoom out to last zoom-level when attempting to zoom to current level.
Additionally detect a series of tap-to-zoom gestures on the same level and
continue to zoom out.
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
- UIProcess/qt/QtViewportInteractionEngine.h:
(QtViewportInteractionEngine):
Apr 21, 2012:
- 6:36 PM Acronyms edited by
- Add DFG, NRWT, ORWT and WTF (diff)
- 6:26 PM Porting Macros plan edited by
- Remove obsolete ENABLE flag names (diff)
- 5:18 PM Changeset in webkit [114856] by
-
- 1 edit in branches/chromium/1084/Source/WebCore/platform/graphics/GraphicsLayer.cpp
Merge 112939
BUG=121524
Review URL: https://chromiumcodereview.appspot.com/10169026
- 5:18 PM Changeset in webkit [114855] by
-
- 22 edits in trunk/Source
Add Notification constructor
https://bugs.webkit.org/show_bug.cgi?id=80477
<rdar://problem/10912431>
Reviewed by Jian Li.
Source/WebCore:
Tests will be added once there is support for web notifications on the Mac ports.
- WebCore.exp.in: Export finalize() function.
Modify Dictionary to support creation of event listeners.
- bindings/js/Dictionary.h:
(WebCore::Dictionary::isObject): Return true if the JSDictionary is valid.
(WebCore::Dictionary::isUndefinedOrNull): Return true if the JSDictionary is not valid.
(WebCore::Dictionary::get): Add convenience function to take const char* for
property name, to prevent having to do implicit conversion to WTF::String.
(WebCore::Dictionary::getEventListener): Add function to create event listener
from the dictionary.
(WebCore::Dictionary::asJSObject): Helper to convert WebCore objects to JS wrapper.
- bindings/js/Dictionary.cpp:
(WebCore::Notification): Implement asJSObject() for Notification.
- bindings/js/JSDictionary.h:
(WebCore::JSDictionary::execState): Expose the exec state so that the Dictionary
can obtain its world for creating the event listener.
- bindings/v8/Dictionary.h:
(WebCore::Dictionary::getEventListener): Stub implementation.
Add new constructor to idl definitions.
- notifications/DOMWindowNotifications.idl: Add Notification constructor, if
ENABLE(NOTIFICATIONS) is on.
- notifications/Notification.idl: If ENABLE(NOTIFICATIONS) is turned on, define
the constructor. Otherwise, use OmitConstructor.
- notifications/NotificationCenter.idl: Wrap creation functions in
ENABLE(LEGACY_NOTIFICATIONS).
- notifications/NotificationCenter.h: Ditto.
(NotificationCenter):
- notifications/Notification.h:
(Notification): Wrap legacy constructors in ENABLE(LEGACY_NOTIFICATIONS).
(WebCore::Notification::create): New creation function based on discussions in WG.
- notifications/Notification.cpp:
(WebCore::getAndAddEventListener): Helper function to get the listener from the
dictionary, and attach to the notification.
(WebCore::Notification::create): Create the notification, then apply whatever
properties can be found in the dictionary to the notification. In order to
attach the event listeners, the notification has to have been created, which is
why this all happens in the factory method and not in the constructor.
(WebCore::Notification::setBody): Added so that it can be set if we find it in the
dictionary.
The new constructor queues a task to show when it is created. To support this, we
use a one-shot timer that calls show() in the next iteration of the run loop.
(WebCore::Notification::Notification): Start the timer.
(WebCore::Notification::showTaskTimerFired): Call show().
Notifications, not being attached to the DOM, could be GC'ed by the JS engine
before its life cycle has completed. We add calls to setPendingActivity() when the
notification has been shown, and when it is closed, we unsetPendingActivity().
To guarantee that we only call this once, we add a new state to the Notification
state machine, called NotificationState::Closed.
(WebCore::Notification::show): Call setPendingActivity() for all ports. Remove conditional on Mac.
(WebCore::Notification::close): Include Closed state to machine; do nothing.
(WebCore::Notification::dispatchCloseEvent): Call finalize().
(WebCore::Notification::finalize): If the state is not Closed, we unsetPendingActivity()
to make it available for GC.
(WebCore::Notification::finishLoading): Remove the unsetPendingActivity(). That call
was to balance the setPendingActivity() called for loading the icon. Instead of wrapping
around the icon load, we wrap around the show() -> finalize() loop.
In Notification, rename some of the stages and functions to more clearly communicate
that they mostly deal with the icon of the notification, instead of general loading.
(WebCore::Notification::show): Refactored to use LoadingIcon and CancelledIcon.
(WebCore::Notification::close): Refactored to use LoadingIcon and CancelledIcon.
(WebCore::Notification::~Notification): Refactor to use LoadingIcon.
(WebCore::Notification::startLoadingIcon): Renamed from startLoading().
(WebCore::Notification::stopLoadingIcon): Renamed from stopLoading().
(WebCore::Notification::finishLoadingIcon): Renamed from finishLoading().
(WebCore::Notification::didFinishLoading):
(WebCore::Notification::didFail):
(WebCore::Notification::didFailRedirectCheck):
(WebCore::Notification::didReceiveResponse):
(WebCore::Notification::finishLoading):
Add Dictionary.cpp.
- GNUmakefile.list.am:
- Target.pri:
- UseJSC.cmake:
- WebCore.gypi:
Fix bug in V8 bindings generation code. If the constructor doesn't raise an exception,
don't use an exception code.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheck):
- bindings/scripts/test/V8/V8TestObj.cpp: Reset results.
(WebCore::TestObjV8Internal::optionsObjectCallback):
Source/WebKit/mac:
- WebCoreSupport/WebNotificationClient.mm:
(WebNotificationClient::clearNotifications): When clearing notifications, finalize
them so that they can be cleaned up by the GC.
Source/WebKit2:
- WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::show): If the notification doesn't get shown,
we should return false, since it will not go through a setPendingActivity cycle.
(WebKit::WebNotificationManager::clearNotifications): When clearing notifications,
finalize them so that they can be cleaned up by the GC.
- 5:01 PM Changeset in webkit [114854] by
-
- 1 edit2 copies in branches/chromium/1084
Merge 112935
BUG=106413
Review URL: https://chromiumcodereview.appspot.com/10170019
- 4:59 PM Changeset in webkit [114853] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 112935
BUG=106413
Review URL: https://chromiumcodereview.appspot.com/10164022
- 4:56 PM Changeset in webkit [114852] by
-
- 1 edit2 copies in branches/chromium/1084
Merge 113229
BUG=99229
Review URL: https://chromiumcodereview.appspot.com/10165023
- 4:54 PM Changeset in webkit [114851] by
-
- 1 edit2 copies in branches/chromium/1084
Merge 113670
BUG=117110
Review URL: https://chromiumcodereview.appspot.com/10170018
- 4:52 PM Changeset in webkit [114850] by
-
- 1 edit2 copies in branches/chromium/1025
Merge 113670
BUG=117110
Review URL: https://chromiumcodereview.appspot.com/10166026
- 4:19 PM Changeset in webkit [114849] by
-
- 2 edits in trunk/Source/WebKit/blackberry
Don't hard code the plugins that blackberry supports.
https://bugs.webkit.org/show_bug.cgi?id=84535
Use the existing PluginDatabase to query for the plugins we can handle.
The original implemention of FrameLoaderClientBlackBerry::createPlugin
was a partial copy from another port. In the Qt port there is some
workarounds for flash which is why this exists there. Sadly the bits
that were copied made it so only flash worked, but as flash was the only
plugin on the system this issue was not noticed until QNX tried to get
jnext working. Tracing it down to this bit of code rather then
correcting it they hardcoded the jnext into the same block as flash was.
The blackberry port isn't specifically suppose to only allow jnext and
flash, but was an accident due to the way this code was developed.
Patch by Benjamin C Meyer <bmeyer@rim.com> on 2012-04-21
Reviewed by Adam Treat.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::createPlugin):
- 3:40 PM Changeset in webkit [114848] by
-
- 2 edits in trunk/Source/WebCore
Support loading the same plugin in multiple locations in the Blackberry port.
https://bugs.webkit.org/show_bug.cgi?id=84537
The hash for the plugin is only based upon the plugin meta information
which will be the same for the same plugin in the system and user's
plugin folders.
It looks like this code was copied/based on the windows port
which doesn't allow the same plugin to be loaded more than once.
Because we want to support multiple copies of the same plugin
in the blackberry port we want to incorperate the path of the plugin
into the hash.
PR 150404
Patch by Benjamin C Meyer <bmeyer@rim.com> on 2012-04-21
Reviewed by Adam Treat.
- plugins/blackberry/PluginPackageBlackBerry.cpp:
(WebCore::PluginPackage::hash):
- 3:02 PM Changeset in webkit [114847] by
-
- 2 edits in trunk/Source/WebKit/chromium
Chromium roll attempt from r133173 to r133348.
- DEPS:
- 1:11 PM Changeset in webkit [114846] by
-
- 2 edits in trunk/Source/WebCore
System plugins are preferred over application plugins
https://bugs.webkit.org/show_bug.cgi?id=84538
Set the preferred paths for plugins so that plugins that reside
inside of the bar will be preferred over plugins that are in the
system folder.
PR 150404
Patch by Benjamin C Meyer <bmeyer@rim.com> on 2012-04-21
Reviewed by Adam Treat.
- plugins/PluginDatabase.cpp:
(WebCore::PluginDatabase::isPreferredPluginDirectory):
- 1:03 PM Changeset in webkit [114845] by
-
- 3 edits in trunk/Source/JavaScriptCore
Change JavaScript lexer to use 0 instead of -1 for sentinel, eliminating the need to put characters into ints
https://bugs.webkit.org/show_bug.cgi?id=84523
Reviewed by Oliver Hunt.
Profiles showed that checks against -1 were costly, and I saw they could be eliminated.
Streamlined this code to use standard character types and 0 rather than -1. One benefit
of this is that there's no widening and narrowing. Another is that there are many cases
where we already have the correct behavior for 0, so can eliminate a branch that was
used to test for -1 before. Also eliminates typecasts in the code.
- parser/Lexer.cpp:
(JSC::Lexer::invalidCharacterMessage): Updated use of String::format since m_current is now a
character type, not an int.
(JSC::Lexer::setCode): Use 0 rather than -1 when past the end.
(JSC::Lexer::shift): Ditto. Also spruced up the comment a bit.
(JSC::Lexer::atEnd): Added. New function that distinguishes an actual 0 character from the end
of the code. This can be used places we used to cheeck for -1.
(JSC::Lexer::peek): Updated to use -1 instead of 0. Removed meaningless comment.
(JSC::Lexer::parseFourDigitUnicodeHex): Changed to use character types instead of int.
(JSC::Lexer::shiftLineTerminator): Removed now-unneeded type casts. Changed local variable that
had a data-member-style name.
(JSC::Lexer::parseIdentifier): Removed now-unneeded explicit checks for -1, since the isIdentPart
function already returns false for the 0 character. Updated types in a couple other places. Used
the atEnd function where needed.
(JSC::Lexer::parseIdentifierSlowCase): More of the same.
(JSC::characterRequiresParseStringSlowCase): Added overloaded helper function for parseString.
(JSC::Lexer::parseString): Ditto.
(JSC::Lexer::parseStringSlowCase): Ditto.
(JSC::Lexer::parseMultilineComment): Ditto.
(JSC::Lexer::lex): More of the same. Also changed code to set the startOffset directly in
the tokenInfo instead of putting it in a local variable first, saving some memory access.
(JSC::Lexer::scanRegExp): Ditto.
(JSC::Lexer::skipRegExp): Ditto.
- parser/Lexer.h: Changed return type of the peek function and type of m_current from int to
the character type. Added atEnd function.
(JSC::Lexer::setOffset): Used 0 instead of -1 and removed an overzealous attempt to optimize.
(JSC::Lexer::lexExpectIdentifier): Used 0 instead of -1.
- 12:46 PM Changeset in webkit [114844] by
-
- 3 edits in trunk/Source/JavaScriptCore
Change JavaScript lexer to use 0 instead of -1 for sentinel, eliminating the need to put characters into ints
https://bugs.webkit.org/show_bug.cgi?id=84523
Reviewed by Oliver Hunt.
Separate preparation step of copyright dates, renaming, and other small tweaks.
- parser/Lexer.cpp:
(JSC::Lexer::invalidCharacterMessage): Removed "get" from name to match WebKit naming conventions.
(JSC::Lexer::peek): Removed meaningless comment.
(JSC::Lexer::parseFourDigitUnicodeHex): Renamed from getUnicodeCharacter to be more precise about
what this function does.
(JSC::Lexer::shiftLineTerminator): Renamed local variable that had a data-member-style name.
(JSC::Lexer::parseStringSlowCase): Updated for new name of parseFourDigitUnicodeHex.
(JSC::Lexer::lex): Updated for new name of invalidCharacterMessage.
- parser/Lexer.h: Removed an unneeded forward declaration of the RegExp class.
Renamed getInvalidCharMessage to invalidCharacterMessage and made it const. Renamed
getUnicodeCharacter to parseFourDigitUnicodeHex.
- 9:43 AM Changeset in webkit [114843] by
-
- 2 edits in trunk/Source/WebCore
Improve performance of removing user and password from URLs
https://bugs.webkit.org/show_bug.cgi?id=84525
Reviewed by Dan Bernstein.
Performance improvement only. Correctness covered by existing regression tests.
The most common use of KURL::setUser and KURL::setPass, by far, is to remove
the user and password from a URL that already has neither. Optimize this by
not re-parsing the URL in that case.
- platform/KURL.cpp:
(WebCore::KURL::setUser): Restructure code so that the code path that removes
the user does no work when there is nothing to remove. Otherwise, leave the
logic of the function untouched.
(WebCore::KURL::setPass): Same thing, only for password rather than user.
- 3:46 AM Changeset in webkit [114842] by
-
- 1 edit5 moves in trunk/LayoutTests
Unreviewed - move some expectations added in r114839 to their proper location.
- platform/gtk/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Copied from LayoutTests/platform/gtk/css2.1/abspos-containing-block-initial-007-expected.txt.
- platform/gtk/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt: Copied from LayoutTests/platform/gtk/css2.1/abspos-non-replaced-width-margin-000-expected.txt.
- platform/gtk/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt: Copied from LayoutTests/platform/gtk/css2.1/abspos-replaced-width-margin-000-expected.txt.
- platform/gtk/css2.1/abspos-containing-block-initial-007-expected.txt: Removed.
- platform/gtk/css2.1/abspos-non-replaced-width-margin-000-expected.txt: Removed.
- platform/gtk/css2.1/abspos-replaced-width-margin-000-expected.txt: Removed.
- platform/gtk/tables/bug137388-2-expected.txt: Removed.
- platform/gtk/tables/bug29314-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug137388-2-expected.txt: Copied from LayoutTests/platform/gtk/tables/bug137388-2-expected.txt.
- platform/gtk/tables/mozilla/bugs/bug29314-expected.txt: Copied from LayoutTests/platform/gtk/tables/bug29314-expected.txt.
- 1:49 AM Changeset in webkit [114841] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed weekend gardening, skip new failing reftests.
- platform/qt/Skipped:
- 1:37 AM Changeset in webkit [114840] by
-
- 4 edits in trunk/LayoutTests
Unreviewed gardening after r114766.
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/qt/svg/css/getComputedStyle-basic-expected.txt:
- 12:21 AM Changeset in webkit [114839] by
-
- 23 edits32 adds in trunk/LayoutTests
Rebaseline the last set of GTK+ tests after font metrics and mock scrollbar changes.
- platform/gtk: Rebaseline tests.
Apr 20, 2012:
- 11:24 PM Changeset in webkit [114838] by
-
- 47 edits12 adds in trunk/LayoutTests
Unreviewed, GTK svg rebaseline after r114799.
- 10:14 PM Changeset in webkit [114837] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r114768.
http://trac.webkit.org/changeset/114768
https://bugs.webkit.org/show_bug.cgi?id=84521
Original patch was not the problem, re-applying (Requested by
pfeldman_ on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-20
- bindings/v8/V8IsolatedContext.cpp:
(WebCore::setInjectedScriptContextDebugId):
(WebCore):
(WebCore::V8IsolatedContext::V8IsolatedContext):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::evaluateInIsolatedWorld):
- bindings/v8/V8Proxy.h:
(V8Proxy):
- 8:22 PM April 2012 Meeting edited by
- (diff)
- 8:19 PM ShadowDOMDesignathon created by
- 8:07 PM Changeset in webkit [114836] by
-
- 4088 edits in trunk/LayoutTests
Rebaseline more GTK tests after <http://trac.webkit.org/changeset/114799>.
- 7:51 PM Changeset in webkit [114835] by
-
- 4 edits in trunk/Source
Make the Web Inspector be the first responder when opening docked.
<rdar://problem/11294217>
Reviewed by Brian Weinstein.
Source/WebKit/mac:
- WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController showWindow:]): Call makeFirstResponder: on
the window and pass the Inspector's WebView.
Source/WebKit2:
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformAttach): Call makeFirstResponder: on
the window and pass the Inspector's WKView.
- 7:27 PM Changeset in webkit [114834] by
-
- 12 edits in trunk/LayoutTests
Undoing undesired changes.
- fast/block/float/008-expected.txt:
- fast/block/float/019-expected.txt:
- fast/block/float/035-expected.txt:
- fast/block/float/relative-painted-twice-expected.txt:
- fast/block/positioning/negative-rel-position-expected.txt:
- fast/canvas/canvas-bg-expected.txt:
- fast/css-generated-content/table-parts-before-and-after-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- fast/flexbox/flex-hang-expected.txt:
- fast/forms/file/get-file-upload-expected.txt:
- fast/forms/select/listbox-in-multi-column-expected.txt:
- 7:21 PM Changeset in webkit [114833] by
-
- 240 edits in trunk/LayoutTests
Rebaseline more GTK fast tests after <http://trac.webkit.org/changeset/114799>.
- 7:19 PM Changeset in webkit [114832] by
-
- 125 edits in trunk/LayoutTests
Rebaseline more GTK CSS3 and editing tests after <http://trac.webkit.org/changeset/114799>.
- 7:10 PM Changeset in webkit [114831] by
-
- 55 edits in trunk/LayoutTests
Rebaseline more GTK CSS2.1 tests after <http://trac.webkit.org/changeset/114799>.
- 7:05 PM Changeset in webkit [114830] by
-
- 299 edits in trunk/LayoutTests
Rebaseline more GTK editing, fast tests after <http://trac.webkit.org/changeset/114799>.
- 7:01 PM Changeset in webkit [114829] by
-
- 143 edits in trunk/LayoutTests
Rebaseline more GTK CSS3 and animation tests after <http://trac.webkit.org/changeset/114799>.
- 6:50 PM Changeset in webkit [114828] by
-
- 35 edits in trunk/LayoutTests
Rebaseline more GTK CSS2.1 tests after <http://trac.webkit.org/changeset/114799>.
- 6:48 PM Changeset in webkit [114827] by
-
- 20 edits in trunk/Source
[chromium] Refactor opaque content transform out of Skia context
https://bugs.webkit.org/show_bug.cgi?id=83608
Reviewed by James Robinson.
Source/WebCore:
Having PlatformContextSkia know about the transform into content space
for a layer is a layering violation. This change lets the
PlatformContextSkia deal with opaque rects in its own space and lets
the caller handle transforming it into its own space. This also
prevents a matrix multiply per draw into the Skia canvas and does it
just once at the end to transform the final rect.
This is an incremental refactoring so that additional tracking for
text rects can be added and use the same space as opaque rects.
Tests: LayerTextureUpdaterTest.testPartialOpaqueRectNoTransform
LayerTextureUpdaterTest.testPartialOpaqueRectTranslation
LayerTextureUpdaterTest.testPartialOpaqueRectScale
- platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:
(WebCore::BitmapCanvasLayerTextureUpdater::prepareToUpdate):
- platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:
(BitmapCanvasLayerTextureUpdater):
- platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::prepareToUpdate):
- platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
(BitmapSkPictureCanvasLayerTextureUpdater):
- platform/graphics/chromium/CanvasLayerTextureUpdater.cpp:
(WebCore::CanvasLayerTextureUpdater::paintContents):
- platform/graphics/chromium/CanvasLayerTextureUpdater.h:
(CanvasLayerTextureUpdater):
- platform/graphics/chromium/LayerTextureUpdater.h:
(WebCore::LayerTextureUpdater::prepareToUpdate):
- platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::SkPictureCanvasLayerTextureUpdater::prepareToUpdate):
- platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h:
(SkPictureCanvasLayerTextureUpdater):
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::updateTiles):
- platform/graphics/skia/OpaqueRegionSkia.cpp:
(WebCore::OpaqueRegionSkia::didDrawRect):
(WebCore::OpaqueRegionSkia::didDrawPath):
(WebCore::OpaqueRegionSkia::didDrawPoints):
(WebCore::OpaqueRegionSkia::didDrawBounded):
(WebCore::OpaqueRegionSkia::didDraw):
- platform/graphics/skia/OpaqueRegionSkia.h:
(OpaqueRegionSkia):
- platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::didDrawRect):
(WebCore::PlatformContextSkia::didDrawPath):
(WebCore::PlatformContextSkia::didDrawPoints):
(WebCore::PlatformContextSkia::didDrawBounded):
- platform/graphics/skia/PlatformContextSkia.h:
(PlatformContextSkia):
Source/WebKit/chromium:
Add tests for opaque tracking in LayerTextureUpdater, since the
transform logic has moved there.
- tests/CCTiledLayerTestCommon.cpp:
(WebKitTests::FakeLayerTextureUpdater::prepareToUpdate):
- tests/CCTiledLayerTestCommon.h:
(FakeLayerTextureUpdater):
- tests/LayerTextureUpdaterTest.cpp:
(WebCore::PaintFillPartialOpaque::PaintFillPartialOpaque):
(PaintFillPartialOpaque):
(WebCore::PaintFillPartialOpaque::operator()):
(WebCore):
(WebCore::TEST):
- tests/PlatformContextSkiaTest.cpp:
(WebCore::TEST):
- 6:45 PM Changeset in webkit [114826] by
-
- 70 edits in trunk/LayoutTests
Rebaseline more GTK editing, dom, fast tests after <http://trac.webkit.org/changeset/114799>.
- 6:43 PM Changeset in webkit [114825] by
-
- 190 edits in trunk/LayoutTests
Rebaseline more GTK CSS3 tests after <http://trac.webkit.org/changeset/114799>.
- 6:43 PM Acronyms edited by
- (diff)
- 6:36 PM Changeset in webkit [114824] by
-
- 104 edits in trunk/LayoutTests
Rebaseline more GTK fast/block tests after <http://trac.webkit.org/changeset/114799>.
- 6:34 PM Changeset in webkit [114823] by
-
- 13 edits in trunk/LayoutTests
Rebaseline more GTK css1 tests after <http://trac.webkit.org/changeset/114799>.
- 6:30 PM Changeset in webkit [114822] by
-
- 86 edits in trunk/LayoutTests
Rebaseline more GTK css2.1 tests after <http://trac.webkit.org/changeset/114799>.
- 6:25 PM Changeset in webkit [114821] by
-
- 291 edits in trunk/LayoutTests
Rebaseline more GTK css3 and editing tests after <http://trac.webkit.org/changeset/114799>.
- 6:22 PM Changeset in webkit [114820] by
-
- 27 edits in trunk/LayoutTests
Rebaseline GTK fast/block tests after <http://trac.webkit.org/changeset/114799>.
- platform/gtk/fast/block/float/001-expected.txt:
- platform/gtk/fast/block/float/002-expected.txt:
- platform/gtk/fast/block/float/003-expected.txt:
- platform/gtk/fast/block/float/004-expected.txt:
- platform/gtk/fast/block/float/005-expected.txt:
- platform/gtk/fast/block/float/006-expected.txt:
- platform/gtk/fast/block/float/007-expected.txt:
- platform/gtk/fast/block/float/010-expected.txt:
- platform/gtk/fast/block/float/011-expected.txt:
- platform/gtk/fast/block/float/012-expected.txt:
- platform/gtk/fast/block/float/013-expected.txt:
- platform/gtk/fast/block/float/014-expected.txt:
- platform/gtk/fast/block/float/015-expected.txt:
- platform/gtk/fast/block/float/016-expected.txt:
- platform/gtk/fast/block/float/017-expected.txt:
- platform/gtk/fast/block/float/018-expected.txt:
- platform/gtk/fast/block/margin-collapse/001-expected.txt:
- platform/gtk/fast/block/margin-collapse/002-expected.txt:
- platform/gtk/fast/block/margin-collapse/003-expected.txt:
- platform/gtk/fast/block/margin-collapse/004-expected.txt:
- platform/gtk/fast/block/margin-collapse/005-expected.txt:
- platform/gtk/fast/block/margin-collapse/006-expected.txt:
- platform/gtk/fast/block/margin-collapse/block-inside-inline/001-expected.txt:
- platform/gtk/fast/block/margin-collapse/block-inside-inline/002-expected.txt:
- platform/gtk/fast/block/margin-collapse/block-inside-inline/003-expected.txt:
- platform/gtk/fast/block/margin-collapse/block-inside-inline/004-expected.txt:
- 6:19 PM Acronyms edited by
- Add JNI, NP, XC (diff)
- 6:17 PM Changeset in webkit [114819] by
-
- 27 edits in trunk/LayoutTests
Rebasing fast/background results after r114799.
- 6:12 PM Changeset in webkit [114818] by
-
- 18 edits in trunk/LayoutTests
Rebaseline more GTK css1 tests after <http://trac.webkit.org/changeset/114799>.
- platform/gtk/css1/box_properties/border_width_inline-expected.txt:
- platform/gtk/css1/box_properties/clear-expected.txt:
- platform/gtk/css1/box_properties/clear_float-expected.txt:
- platform/gtk/css1/box_properties/float-expected.txt:
- platform/gtk/css1/box_properties/float_margin-expected.txt:
- platform/gtk/css1/box_properties/float_on_text_elements-expected.txt:
- platform/gtk/css1/box_properties/height-expected.txt:
- platform/gtk/css1/box_properties/margin-expected.txt:
- platform/gtk/css1/box_properties/margin_bottom-expected.txt:
- platform/gtk/css1/box_properties/margin_bottom_inline-expected.txt:
- platform/gtk/css1/box_properties/margin_inline-expected.txt:
- platform/gtk/css1/box_properties/margin_left-expected.txt:
- platform/gtk/css1/box_properties/margin_left_inline-expected.txt:
- platform/gtk/css1/box_properties/margin_right-expected.txt:
- platform/gtk/css1/box_properties/margin_right_inline-expected.txt:
- platform/gtk/css1/box_properties/margin_top-expected.txt:
- platform/gtk/css1/box_properties/margin_top_inline-expected.txt:
- 6:08 PM Changeset in webkit [114817] by
-
- 4 edits4 adds in trunk
CRASH at WebCore::ReplaceSelectionCommand::removeRedundantMarkup
https://bugs.webkit.org/show_bug.cgi?id=84518
<rdar://problem/10714790>
Reviewed by Simon Fraser.
Source/WebCore:
There are cases where the m_lastNodeInserted is NULL to begin with or
gets deleted by removeRedundantStylesAndKeepStyleSpanInline.
This change handles those cases properly.
Tests: editing/pasteboard/paste-sanitize-crash-1.html
editing/pasteboard/paste-sanitize-crash-2.html
- editing/ReplaceSelectionCommand.h:
(WebCore::ReplaceSelectionCommand::InsertedNodes::pastLastLeaf):
- editing/SimplifyMarkupCommand.cpp:
(WebCore::SimplifyMarkupCommand::doApply):
LayoutTests:
- editing/pasteboard/paste-sanitize-crash-1-expected.txt: Added.
- editing/pasteboard/paste-sanitize-crash-1.html: Added.
- editing/pasteboard/paste-sanitize-crash-2-expected.txt: Added.
- editing/pasteboard/paste-sanitize-crash-2.html: Added.
- 6:06 PM Changeset in webkit [114816] by
-
- 105 edits in trunk/LayoutTests
Rebasing editing results after r114799.
Baselines for more of css2.1 and dom.
- 6:03 PM Acronyms edited by
- Update CF and add UUID (diff)
- 6:03 PM Changeset in webkit [114815] by
-
- 6 edits in trunk/LayoutTests
Rebaseline GTK animations tests after <http://trac.webkit.org/changeset/114799>.
- platform/gtk/animations/cross-fade-background-image-expected.txt:
- platform/gtk/animations/cross-fade-border-image-source-expected.txt:
- platform/gtk/animations/cross-fade-list-style-image-expected.txt:
- platform/gtk/animations/cross-fade-webkit-mask-box-image-expected.txt:
- platform/gtk/animations/cross-fade-webkit-mask-image-expected.txt:
- 6:02 PM Changeset in webkit [114814] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Tiny change to DomStorage v8 bindings to avoid a relatively expensive test in a couple
of places by reordering the expressions in compound conditions, if (fastTest && moreExpensiveTest)
https://bugs.webkit.org/show_bug.cgi?id=84500
Reviewed by Kentaro Hara.
No new tests, no new functionality.
- bindings/v8/custom/V8StorageCustom.cpp:
(WebCore::storageGetter):
(WebCore::V8Storage::namedPropertyQuery):
- 5:59 PM Acronyms edited by
- (diff)
- 5:58 PM Changeset in webkit [114813] by
-
- 4 edits in trunk
REGRESSION (r114784): svg/text/foreignObject-text-clipping-bug.xml failing on Mountain Lion Debug Tests
https://bugs.webkit.org/show_bug.cgi?id=84505
Reviewed by Anders Carlsson.
Source/WebCore:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::blockBeforeWithinSelectionRoot): Changed to not assume that boxes only
have boxes as siblings.
LayoutTests:
- platform/mac/test_expectations.txt:
- 5:56 PM Changeset in webkit [114812] by
-
- 293 edits in trunk/LayoutTests
Rebaseline GTK CSS1 tests after <http://trac.webkit.org/changeset/114799>.
Patch by Daniel Bates <dbates@webkit.org> on 2012-04-20
- platform/gtk/css1/basic/class_as_selector-expected.txt:
- platform/gtk/css1/basic/comments-expected.txt:
- platform/gtk/css1/basic/containment-expected.txt:
- platform/gtk/css1/basic/contextual_selectors-expected.txt:
- platform/gtk/css1/basic/grouping-expected.txt:
- platform/gtk/css1/basic/id_as_selector-expected.txt:
- platform/gtk/css1/basic/inheritance-expected.txt:
- platform/gtk/css1/box_properties/acid_test-expected.txt:
- platform/gtk/css1/box_properties/border-expected.txt:
- platform/gtk/css1/box_properties/border_bottom-expected.txt:
- platform/gtk/css1/box_properties/border_bottom_inline-expected.txt:
- platform/gtk/css1/box_properties/border_bottom_width-expected.txt:
- platform/gtk/css1/box_properties/border_bottom_width_inline-expected.txt:
- platform/gtk/css1/box_properties/border_color-expected.txt:
- platform/gtk/css1/box_properties/border_color_inline-expected.txt:
- platform/gtk/css1/box_properties/border_inline-expected.txt:
- platform/gtk/css1/box_properties/border_left-expected.txt:
- platform/gtk/css1/box_properties/border_left_inline-expected.txt:
- platform/gtk/css1/box_properties/border_left_width-expected.txt:
- platform/gtk/css1/box_properties/border_left_width_inline-expected.txt:
- platform/gtk/css1/box_properties/border_right-expected.txt:
- platform/gtk/css1/box_properties/border_right_inline-expected.txt:
- platform/gtk/css1/box_properties/border_right_width-expected.txt:
- platform/gtk/css1/box_properties/border_right_width_inline-expected.txt:
- platform/gtk/css1/box_properties/border_style-expected.txt:
- platform/gtk/css1/box_properties/border_style_inline-expected.txt:
- platform/gtk/css1/box_properties/border_top-expected.txt:
- platform/gtk/css1/box_properties/border_top_inline-expected.txt:
- platform/gtk/css1/box_properties/border_top_width-expected.txt:
- platform/gtk/css1/box_properties/border_top_width_inline-expected.txt:
- platform/gtk/css1/box_properties/border_width-expected.txt:
- platform/gtk/css1/cascade/cascade_order-expected.txt:
- platform/gtk/css1/cascade/important-expected.txt:
- platform/gtk/css1/classification/display-expected.txt:
- platform/gtk/css1/classification/list_style-expected.txt:
- platform/gtk/css1/classification/list_style_image-expected.txt:
- platform/gtk/css1/classification/list_style_position-expected.txt:
- platform/gtk/css1/classification/list_style_type-expected.txt:
- platform/gtk/css1/classification/white_space-expected.txt:
- platform/gtk/css1/color_and_background/background-expected.txt:
- platform/gtk/css1/color_and_background/background_attachment-expected.txt:
- platform/gtk/css1/color_and_background/background_color-expected.txt:
- platform/gtk/css1/color_and_background/background_image-expected.txt:
- platform/gtk/css1/color_and_background/background_position-expected.txt:
- platform/gtk/css1/color_and_background/background_repeat-expected.txt:
- platform/gtk/css1/color_and_background/color-expected.txt:
- platform/gtk/css1/conformance/forward_compatible_parsing-expected.txt:
- platform/gtk/css1/font_properties/font-expected.txt:
- platform/gtk/css1/font_properties/font_family-expected.txt:
- platform/gtk/css1/font_properties/font_size-expected.txt:
- platform/gtk/css1/font_properties/font_style-expected.txt:
- platform/gtk/css1/font_properties/font_variant-expected.txt:
- platform/gtk/css1/font_properties/font_weight-expected.txt:
- platform/gtk/css1/formatting_model/canvas-expected.txt:
- platform/gtk/css1/formatting_model/floating_elements-expected.txt:
- platform/gtk/css1/formatting_model/height_of_lines-expected.txt:
- platform/gtk/css1/formatting_model/horizontal_formatting-expected.txt:
- platform/gtk/css1/formatting_model/inline_elements-expected.txt:
- platform/gtk/css1/formatting_model/replaced_elements-expected.txt:
- platform/gtk/css1/formatting_model/vertical_formatting-expected.txt:
- platform/gtk/css1/pseudo/anchor-expected.txt:
- platform/gtk/css1/pseudo/firstletter-expected.txt:
- platform/gtk/css1/pseudo/firstline-expected.txt:
- platform/gtk/css1/pseudo/multiple_pseudo_elements-expected.txt:
- platform/gtk/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
- platform/gtk/css1/text_properties/letter_spacing-expected.txt:
- platform/gtk/css1/text_properties/line_height-expected.txt:
- platform/gtk/css1/text_properties/text_align-expected.txt:
- platform/gtk/css1/text_properties/text_decoration-expected.txt:
- platform/gtk/css1/text_properties/text_indent-expected.txt:
- platform/gtk/css1/text_properties/text_transform-expected.txt:
- platform/gtk/css1/text_properties/vertical_align-expected.txt:
- platform/gtk/css1/text_properties/word_spacing-expected.txt:
- platform/gtk/css1/units/color_units-expected.txt:
- platform/gtk/css1/units/length_units-expected.txt:
- platform/gtk/css1/units/percentage_units-expected.txt:
- platform/gtk/css1/units/urls-expected.txt:
- 5:50 PM Changeset in webkit [114811] by
-
- 79 edits in trunk/LayoutTests
Rebaseline GTK CSS1 tests after <http://trac.webkit.org/changeset/114799>.
- platform/gtk/css1/basic/class_as_selector-expected.txt:
- platform/gtk/css1/basic/comments-expected.txt:
- platform/gtk/css1/basic/containment-expected.txt:
- platform/gtk/css1/basic/contextual_selectors-expected.txt:
- platform/gtk/css1/basic/grouping-expected.txt:
- platform/gtk/css1/basic/id_as_selector-expected.txt:
- platform/gtk/css1/basic/inheritance-expected.txt:
- platform/gtk/css1/box_properties/acid_test-expected.txt:
- platform/gtk/css1/box_properties/border-expected.txt:
- platform/gtk/css1/box_properties/border_bottom-expected.txt:
- platform/gtk/css1/box_properties/border_bottom_inline-expected.txt:
- platform/gtk/css1/box_properties/border_bottom_width-expected.txt:
- platform/gtk/css1/box_properties/border_bottom_width_inline-expected.txt:
- platform/gtk/css1/box_properties/border_color-expected.txt:
- platform/gtk/css1/box_properties/border_color_inline-expected.txt:
- platform/gtk/css1/box_properties/border_inline-expected.txt:
- platform/gtk/css1/box_properties/border_left-expected.txt:
- platform/gtk/css1/box_properties/border_left_inline-expected.txt:
- platform/gtk/css1/box_properties/border_left_width-expected.txt:
- platform/gtk/css1/box_properties/border_left_width_inline-expected.txt:
- platform/gtk/css1/box_properties/border_right-expected.txt:
- platform/gtk/css1/box_properties/border_right_inline-expected.txt:
- platform/gtk/css1/box_properties/border_right_width-expected.txt:
- platform/gtk/css1/box_properties/border_right_width_inline-expected.txt:
- platform/gtk/css1/box_properties/border_style-expected.txt:
- platform/gtk/css1/box_properties/border_style_inline-expected.txt:
- platform/gtk/css1/box_properties/border_top-expected.txt:
- platform/gtk/css1/box_properties/border_top_inline-expected.txt:
- platform/gtk/css1/box_properties/border_top_width-expected.txt:
- platform/gtk/css1/box_properties/border_top_width_inline-expected.txt:
- platform/gtk/css1/box_properties/border_width-expected.txt:
- platform/gtk/css1/cascade/cascade_order-expected.txt:
- platform/gtk/css1/cascade/important-expected.txt:
- platform/gtk/css1/classification/display-expected.txt:
- platform/gtk/css1/classification/list_style-expected.txt:
- platform/gtk/css1/classification/list_style_image-expected.txt:
- platform/gtk/css1/classification/list_style_position-expected.txt:
- platform/gtk/css1/classification/list_style_type-expected.txt:
- platform/gtk/css1/classification/white_space-expected.txt:
- platform/gtk/css1/color_and_background/background-expected.txt:
- platform/gtk/css1/color_and_background/background_attachment-expected.txt:
- platform/gtk/css1/color_and_background/background_color-expected.txt:
- platform/gtk/css1/color_and_background/background_image-expected.txt:
- platform/gtk/css1/color_and_background/background_position-expected.txt:
- platform/gtk/css1/color_and_background/background_repeat-expected.txt:
- platform/gtk/css1/color_and_background/color-expected.txt:
- platform/gtk/css1/conformance/forward_compatible_parsing-expected.txt:
- platform/gtk/css1/font_properties/font-expected.txt:
- platform/gtk/css1/font_properties/font_family-expected.txt:
- platform/gtk/css1/font_properties/font_size-expected.txt:
- platform/gtk/css1/font_properties/font_style-expected.txt:
- platform/gtk/css1/font_properties/font_variant-expected.txt:
- platform/gtk/css1/font_properties/font_weight-expected.txt:
- platform/gtk/css1/formatting_model/canvas-expected.txt:
- platform/gtk/css1/formatting_model/floating_elements-expected.txt:
- platform/gtk/css1/formatting_model/height_of_lines-expected.txt:
- platform/gtk/css1/formatting_model/horizontal_formatting-expected.txt:
- platform/gtk/css1/formatting_model/inline_elements-expected.txt:
- platform/gtk/css1/formatting_model/replaced_elements-expected.txt:
- platform/gtk/css1/formatting_model/vertical_formatting-expected.txt:
- platform/gtk/css1/pseudo/anchor-expected.txt:
- platform/gtk/css1/pseudo/firstletter-expected.txt:
- platform/gtk/css1/pseudo/firstline-expected.txt:
- platform/gtk/css1/pseudo/multiple_pseudo_elements-expected.txt:
- platform/gtk/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
- platform/gtk/css1/text_properties/letter_spacing-expected.txt:
- platform/gtk/css1/text_properties/line_height-expected.txt:
- platform/gtk/css1/text_properties/text_align-expected.txt:
- platform/gtk/css1/text_properties/text_decoration-expected.txt:
- platform/gtk/css1/text_properties/text_indent-expected.txt:
- platform/gtk/css1/text_properties/text_transform-expected.txt:
- platform/gtk/css1/text_properties/vertical_align-expected.txt:
- platform/gtk/css1/text_properties/word_spacing-expected.txt:
- platform/gtk/css1/units/color_units-expected.txt:
- platform/gtk/css1/units/length_units-expected.txt:
- platform/gtk/css1/units/percentage_units-expected.txt:
- platform/gtk/css1/units/urls-expected.txt:
- 5:38 PM Acronyms created by
- 5:33 PM Changeset in webkit [114810] by
-
- 147 edits in trunk/LayoutTests
Rebasing editing results after r114799.
- platform/gtk/editing/deleting/4922367-expected.txt:
- platform/gtk/editing/deleting/5099303-expected.txt:
- platform/gtk/editing/deleting/5126166-expected.txt:
- platform/gtk/editing/deleting/5144139-2-expected.txt:
- platform/gtk/editing/deleting/5206311-1-expected.txt:
- platform/gtk/editing/deleting/5272440-expected.txt:
- platform/gtk/editing/deleting/5369009-expected.txt:
- platform/gtk/editing/deleting/5433862-2-expected.txt:
- platform/gtk/editing/deleting/5483370-expected.txt:
- platform/gtk/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3608445-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3608462-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3775172-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3800834-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3857753-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3865854-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3928305-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3959464-fix-expected.txt:
- platform/gtk/editing/deleting/delete-4083333-fix-expected.txt:
- platform/gtk/editing/deleting/delete-after-span-ws-001-expected.txt:
- platform/gtk/editing/deleting/delete-after-span-ws-002-expected.txt:
- platform/gtk/editing/deleting/delete-after-span-ws-003-expected.txt:
- platform/gtk/editing/deleting/delete-and-undo-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
- platform/gtk/editing/execCommand/4580583-1-expected.txt:
- platform/gtk/editing/execCommand/4580583-2-expected.txt:
- platform/gtk/editing/execCommand/4641880-1-expected.txt:
- platform/gtk/editing/execCommand/4641880-2-expected.txt:
- platform/gtk/editing/execCommand/4747450-expected.txt:
- platform/gtk/editing/execCommand/4916402-expected.txt:
- platform/gtk/editing/execCommand/4916541-expected.txt:
- platform/gtk/editing/execCommand/4924441-expected.txt:
- platform/gtk/editing/execCommand/5080333-1-expected.txt:
- platform/gtk/editing/execCommand/5080333-2-expected.txt:
- platform/gtk/editing/execCommand/5136770-expected.txt:
- platform/gtk/editing/execCommand/5138441-expected.txt:
- platform/gtk/editing/execCommand/5142012-1-expected.txt:
- platform/gtk/editing/execCommand/5142012-2-expected.txt:
- platform/gtk/editing/execCommand/5190926-expected.txt:
- platform/gtk/editing/execCommand/5481523-expected.txt:
- platform/gtk/editing/execCommand/5482023-expected.txt:
- platform/gtk/editing/execCommand/5569741-expected.txt:
- platform/gtk/editing/execCommand/create-list-with-hr-expected.txt:
- platform/gtk/editing/input/caret-at-the-edge-of-contenteditable-expected.txt:
- platform/gtk/editing/input/caret-at-the-edge-of-input-expected.txt:
- platform/gtk/editing/input/emacs-ctrl-o-expected.txt:
- platform/gtk/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt:
- platform/gtk/editing/input/reveal-caret-of-multiline-input-expected.txt:
- platform/gtk/editing/inserting/12882-expected.txt:
- platform/gtk/editing/inserting/4278698-expected.txt:
- platform/gtk/editing/inserting/4840662-expected.txt:
- platform/gtk/editing/inserting/4875189-1-expected.txt:
- platform/gtk/editing/inserting/4875189-2-expected.txt:
- platform/gtk/editing/inserting/4959067-expected.txt:
- platform/gtk/editing/inserting/4960120-1-expected.txt:
- platform/gtk/editing/inserting/4960120-2-expected.txt:
- platform/gtk/editing/inserting/5002441-expected.txt:
- platform/gtk/editing/inserting/5058163-1-expected.txt:
- platform/gtk/editing/inserting/5058163-2-expected.txt:
- platform/gtk/editing/inserting/5156401-2-expected.txt:
- platform/gtk/editing/inserting/5418891-expected.txt:
- platform/gtk/editing/inserting/5510537-expected.txt:
- platform/gtk/editing/inserting/5549929-2-expected.txt:
- platform/gtk/editing/inserting/5549929-3-expected.txt:
- platform/gtk/editing/inserting/6703873-expected.txt:
- platform/gtk/editing/inserting/before-after-input-element-expected.txt:
- platform/gtk/editing/inserting/break-blockquote-after-delete-expected.txt:
- platform/gtk/editing/inserting/editable-html-element-expected.txt:
- platform/gtk/editing/inserting/editable-inline-element-expected.txt:
- platform/gtk/editing/inserting/edited-whitespace-1-expected.txt:
- platform/gtk/editing/inserting/editing-empty-divs-expected.txt:
- platform/gtk/editing/inserting/insert-3654864-fix-expected.txt:
- platform/gtk/editing/inserting/insert-3775316-fix-expected.txt:
- platform/gtk/editing/inserting/insert-3778059-fix-expected.txt:
- platform/gtk/editing/inserting/insert-3800346-fix-expected.txt:
- platform/gtk/editing/inserting/insert-3851164-fix-expected.txt:
- platform/gtk/editing/inserting/insert-after-delete-001-expected.txt:
- platform/gtk/editing/inserting/insert-at-end-01-expected.txt:
- platform/gtk/editing/inserting/insert-at-end-02-expected.txt:
- platform/gtk/editing/pasteboard/3976872-expected.txt:
- platform/gtk/editing/pasteboard/4076267-2-expected.txt:
- platform/gtk/editing/pasteboard/4076267-3-expected.txt:
- platform/gtk/editing/pasteboard/4076267-expected.txt:
- platform/gtk/editing/pasteboard/4242293-expected.txt:
- platform/gtk/editing/pasteboard/4631972-expected.txt:
- platform/gtk/editing/pasteboard/4641033-expected.txt:
- platform/gtk/editing/pasteboard/4806874-expected.txt:
- platform/gtk/editing/pasteboard/4944770-1-expected.txt:
- platform/gtk/editing/pasteboard/4944770-2-expected.txt:
- platform/gtk/editing/pasteboard/4947130-expected.txt:
- platform/gtk/editing/pasteboard/7955-expected.txt:
- platform/gtk/editing/pasteboard/8145-1-expected.txt:
- platform/gtk/editing/pasteboard/8145-2-expected.txt:
- platform/gtk/editing/pasteboard/8145-3-expected.txt:
- platform/gtk/editing/selection/13804-expected.txt:
- platform/gtk/editing/selection/14971-expected.txt:
- platform/gtk/editing/selection/3690703-2-expected.txt:
- platform/gtk/editing/selection/3690703-expected.txt:
- platform/gtk/editing/selection/3690719-expected.txt:
- platform/gtk/editing/selection/4397952-expected.txt:
- platform/gtk/editing/selection/4402375-expected.txt:
- platform/gtk/editing/selection/4776665-expected.txt:
- platform/gtk/editing/selection/4818145-expected.txt:
- platform/gtk/editing/selection/4866671-expected.txt:
- platform/gtk/editing/selection/4889598-expected.txt:
- platform/gtk/editing/selection/6476-expected.txt:
- platform/gtk/editing/selection/7152-1-expected.txt:
- platform/gtk/editing/selection/7152-2-expected.txt:
- platform/gtk/editing/style/4916887-expected.txt:
- platform/gtk/editing/style/5017613-1-expected.txt:
- platform/gtk/editing/style/5017613-2-expected.txt:
- platform/gtk/editing/style/5046875-1-expected.txt:
- platform/gtk/editing/style/5046875-2-expected.txt:
- platform/gtk/editing/style/5065910-expected.txt:
- platform/gtk/editing/style/5084241-expected.txt:
- platform/gtk/editing/style/5228141-expected.txt:
- platform/gtk/editing/style/5279521-expected.txt:
- platform/gtk/editing/style/apple-style-editable-mix-expected.txt:
- platform/gtk/editing/style/block-style-001-expected.txt:
- platform/gtk/editing/style/block-style-002-expected.txt:
- platform/gtk/editing/style/block-style-003-expected.txt:
- platform/gtk/editing/style/block-styles-007-expected.txt:
- platform/gtk/editing/style/create-block-for-style-001-expected.txt:
- platform/gtk/editing/style/create-block-for-style-002-expected.txt:
- platform/gtk/editing/style/create-block-for-style-003-expected.txt:
- platform/gtk/editing/style/create-block-for-style-004-expected.txt:
- platform/gtk/editing/undo/4063751-expected.txt:
- platform/gtk/editing/undo/redo-typing-001-expected.txt:
- platform/gtk/editing/undo/undo-combined-delete-boundary-expected.txt:
- platform/gtk/editing/undo/undo-combined-delete-expected.txt:
- platform/gtk/editing/undo/undo-delete-boundary-expected.txt:
- platform/gtk/editing/undo/undo-delete-expected.txt:
- platform/gtk/editing/undo/undo-forward-delete-boundary-expected.txt:
- platform/gtk/editing/undo/undo-forward-delete-expected.txt:
- platform/gtk/editing/unsupported-content/list-delete-001-expected.txt:
- platform/gtk/editing/unsupported-content/list-delete-003-expected.txt:
- platform/gtk/editing/unsupported-content/list-type-after-expected.txt:
- platform/gtk/editing/unsupported-content/list-type-before-expected.txt:
- platform/gtk/editing/unsupported-content/table-delete-001-expected.txt:
- platform/gtk/editing/unsupported-content/table-delete-002-expected.txt:
- 5:31 PM Changeset in webkit [114809] by
-
- 5 edits in trunk/Source/JavaScriptCore
DFG should optimize int8 and int16 arrays on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=84503
Reviewed by Oliver Hunt.
- assembler/ARMv7Assembler.h:
(ARMv7Assembler):
(JSC::ARMv7Assembler::ldrsb):
(JSC::ARMv7Assembler::ldrsh):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::load16Signed):
(JSC::MacroAssemblerARMv7::load8Signed):
- bytecode/PredictedType.h:
(JSC::isActionableIntMutableArrayPrediction):
- dfg/DFGNode.h:
(JSC::DFG::Node::shouldSpeculateInt8Array):
(JSC::DFG::Node::shouldSpeculateInt16Array):
- 5:27 PM Changeset in webkit [114808] by
-
- 4 edits in trunk/Source
[chromium] Remove special case for recreating layers during sync
https://bugs.webkit.org/show_bug.cgi?id=84458
Reviewed by James Robinson.
Source/WebCore:
We no longer delete layers on the impl side, unless it is due to
deleting the layer on webkit side. So we will no longer have a
situation where we need to push properties from an old
LayerChromium to a new CCLayerImpl.
- platform/graphics/chromium/TreeSynchronizer.cpp:
(WebCore::TreeSynchronizer::reuseOrCreateCCLayerImpl):
Source/WebKit/chromium:
- tests/TreeSynchronizerTest.cpp:
- 5:25 PM WikiStart edited by
- Add link to "Acronyms" page in "Documentation" section (diff)
- 5:22 PM Changeset in webkit [114807] by
-
- 4 edits in trunk/Source
[chromium] WebFilterOperations API does not compile or dynamically link
https://bugs.webkit.org/show_bug.cgi?id=84506
Reviewed by James Robinson.
Non-inline functions need WEBKIT_EXPORT in their declarations,
and the type used in the WebPrivateOwnPtr needs to be forward-
declared even when WEBKIT_IMPLEMENTATION is not defined.
Source/Platform:
- chromium/public/WebFilterOperations.h:
(WebKit::WebFilterOperations::WebFilterOperations):
(WebFilterOperations):
Source/WebCore:
- platform/chromium/support/WebFilterOperations.cpp:
(WebKit::WebFilterOperations::initialize):
- 5:18 PM Changeset in webkit [114806] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r114333.
http://trac.webkit.org/changeset/114333
https://bugs.webkit.org/show_bug.cgi?id=84511
perf regression (Requested by morrita on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-20
- dom/Node.cpp:
- dom/Node.h:
(WebCore):
(Node):
(WebCore::Node::isElementNode):
(WebCore::Node::isContainerNode):
(WebCore::Node::isTextNode):
(WebCore::Node::isHTMLElement):
(WebCore::Node::isSVGElement):
(WebCore::Node::isStyledElement):
(WebCore::Node::isShadowRoot):
(WebCore::Node::parentNode):
(WebCore::Node::parentNodeGuaranteedHostFree):
- 5:16 PM Changeset in webkit [114805] by
-
- 21 edits3 adds in trunk
IndexedDB: Support get/getKey(keyRange)
https://bugs.webkit.org/show_bug.cgi?id=83638
Patch by Alec Flett <alecflett@chromium.org> on 2012-04-20
Reviewed by Ojan Vafai.
Source/WebCore:
Support IDBKeyRange as a parameter to all the various get/getKey
combinations. Switches the existing get/getKey versions that use
IDBKey directly to start using IDBKeyRange.only().
Test: storage/indexeddb/get-keyrange.html
- Modules/indexeddb/IDBIndex.cpp:
(WebCore::IDBIndex::get):
(WebCore):
(WebCore::IDBIndex::getKey):
- Modules/indexeddb/IDBIndex.h:
(IDBIndex):
- Modules/indexeddb/IDBIndex.idl:
- Modules/indexeddb/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::getInternal):
(WebCore):
(WebCore::IDBIndexBackendImpl::getByRangeInternal):
(WebCore::IDBIndexBackendImpl::getKeyInternal):
(WebCore::IDBIndexBackendImpl::getKeyByRangeInternal):
(WebCore::IDBIndexBackendImpl::get):
(WebCore::IDBIndexBackendImpl::getKey):
- Modules/indexeddb/IDBIndexBackendImpl.h:
(IDBIndexBackendImpl):
- Modules/indexeddb/IDBIndexBackendInterface.h:
(IDBIndexBackendInterface):
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::get):
(WebCore):
- Modules/indexeddb/IDBObjectStore.h:
(IDBObjectStore):
- Modules/indexeddb/IDBObjectStore.idl:
- Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::get):
(WebCore::IDBObjectStoreBackendImpl::getByRangeInternal):
(WebCore::IDBObjectStoreBackendImpl::getInternal):
- Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(IDBObjectStoreBackendImpl):
- Modules/indexeddb/IDBObjectStoreBackendInterface.h:
(IDBObjectStoreBackendInterface):
Source/WebKit/chromium:
Hook up WebKit API to the new get/getKey implementations.
- src/IDBIndexBackendProxy.cpp:
(WebKit::IDBIndexBackendProxy::get):
(WebKit):
(WebKit::IDBIndexBackendProxy::getKey):
- src/IDBIndexBackendProxy.h:
(IDBIndexBackendProxy):
- src/WebIDBIndexImpl.cpp:
(WebKit::WebIDBIndexImpl::getObject):
(WebKit::WebIDBIndexImpl::getKey):
- src/WebIDBObjectStoreImpl.cpp:
(WebKit::WebIDBObjectStoreImpl::get):
LayoutTests:
Tests for all the get/getKey combinations when using a range.
- storage/indexeddb/get-keyrange-expected.txt: Added.
- storage/indexeddb/get-keyrange.html: Added.
- storage/indexeddb/index-get-key-argument-required-expected.txt:
- storage/indexeddb/objectStore-required-arguments-expected.txt:
- storage/indexeddb/resources/get-keyrange.js: Added.
(test):
(openDatabase):
(setVersion):
(deleteExisting):
(addData):
(getRangeOnlyTest.request.onsuccess):
(getRangeOnlyTest):
(getRangeLowerTest.request.onsuccess):
(getRangeLowerTest):
(getRangeLowerOpenTest.request.onsuccess):
(getRangeLowerOpenTest):
(getRangeUpperTest.request.onsuccess):
(getRangeUpperTest):
(getRangeLowerFractionTest.request.onsuccess):
(getRangeLowerFractionTest):
(getOutOfRangeTest.request.onsuccess):
(getOutOfRangeTest):
(getBadOnlyTest.request.onsuccess):
(getBadOnlyTest):
(getNullTest):
- 5:12 PM Changeset in webkit [114804] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed, rolling out r114789.
http://trac.webkit.org/changeset/114789
https://bugs.webkit.org/show_bug.cgi?id=84515
Caused 5 tests to fail on mac/ (Requested by jernoble on
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-20
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- css/CSSValueKeywords.in:
- platform/ThemeTypes.h:
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint):
- 5:12 PM Changeset in webkit [114803] by
-
- 4 edits in trunk/Source/JavaScriptCore
Add an ability to find the extent of a callframe
https://bugs.webkit.org/show_bug.cgi?id=84513
Reviewed by Filip Pizlo.
Add a function to get the extent of a callframe and
use that function for a new assertion to make sure the
RegisterFile makes sense using that information.
- interpreter/CallFrame.cpp:
(JSC::CallFrame::frameExtentInternal):
(JSC):
- interpreter/CallFrame.h:
(JSC::ExecState::frameExtent):
(ExecState):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::executeCall):
- 5:07 PM Changeset in webkit [114802] by
-
- 11 edits in trunk/Source
https://bugs.webkit.org/show_bug.cgi?id=84512 Repurpose ActiveDOMObject::WillShowDialog to WillDeferLoading
Reviewed by Eric Carlson.
Source/WebCore:
No new tests. (Refactor, no behavior change)
Rename WillShowDialog to WillDeferLoading:
- dom/ActiveDOMObject.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::suspend):
Don't take a ReasonForSuspension argument anymore, just use WillDeferLoading:
- page/PageGroupLoadDeferrer.cpp:
(WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
- page/PageGroupLoadDeferrer.h:
Don't pass a Reason anymore as WillDeferLoading is used by default:
- page/Chrome.cpp:
(WebCore::Chrome::runModal):
(WebCore::Chrome::runBeforeUnloadConfirmPanel):
(WebCore::Chrome::runJavaScriptAlert):
(WebCore::Chrome::runJavaScriptConfirm):
(WebCore::Chrome::runJavaScriptPrompt):
(WebCore::Chrome::shouldInterruptJavaScript):
Source/WebKit/blackberry:
PageGroupLoadDeferrer's don't take a ReasonForSuspension argument anymore;
They just use WillDeferLoading by default.
- Api/WebPageGroupLoadDeferrer.cpp:
(BlackBerry::WebKit::WebPageGroupLoadDeferrer::WebPageGroupLoadDeferrer):
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::createWindow):
(WebCore::ChromeClientBlackBerry::runOpenPanel):
Source/WebKit/chromium:
PageGroupLoadDeferrer's don't take a ReasonForSuspension argument anymore;
They just use WillDeferLoading by default.
- src/WebViewImpl.cpp:
(WebKit::WebView::willEnterModalLoop):
- 5:01 PM Changeset in webkit [114801] by
-
- 133 edits in trunk/LayoutTests
Unreviewed, GTK css2.1 rebaseline after r114796 and r114799.
- platform/gtk/css2.1: Massive Update.
- 4:49 PM Changeset in webkit [114800] by
-
- 20 edits in trunk/Source
[chromium] Plumb a compositor surface ready notification through to the threaded compositor
https://bugs.webkit.org/show_bug.cgi?id=84305
Patch by James Robinson <jamesr@chromium.org> on 2012-04-20
Reviewed by Adrienne Walker.
Source/Platform:
Add a notification for when the compositor surface associated with a given view is ready to use.
- chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):
Source/WebCore:
Plumb setSurfaceReady through to the scheduler.
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::setSurfaceReady):
(WebCore):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
- platform/graphics/chromium/cc/CCProxy.h:
(CCProxy):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::setSurfaceReady):
(WebCore):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(CCSingleThreadProxy):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::setSurfaceReady):
(WebCore):
(WebCore::CCThreadProxy::setSurfaceReadyOnImplThread):
(WebCore::CCThreadProxy::initializeImplOnImplThread):
- platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
Source/WebKit/chromium:
Adds a notification to WebWidget for when the compositor surface is ready to use. This exists to fix a race
condition when WebKit requires that we enter compositing mode but we haven't completed initialization of the
native window/etc backing the WebWidget, and we can't block for this initialization to complete without inducing
deadlocks. In this situation, we proceed as usual except that we can't attempt to use the compositor context or
it will fail.
- public/WebWidget.h:
(WebWidget):
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::setSurfaceReady):
(WebKit):
- src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::setCompositorSurfaceReady):
(WebKit):
- src/WebPagePopupImpl.h:
(WebPagePopupImpl):
- src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::setCompositorSurfaceReady):
(WebKit):
- src/WebPopupMenuImpl.h:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setCompositorSurfaceReady):
(WebKit):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
- src/WebViewImpl.h:
(WebViewImpl):
- 4:47 PM Changeset in webkit [114799] by
-
- 2 edits in trunk/Source/WebKit/gtk
[Gtk][WK1] Use mock scrollbars when testing
https://bugs.webkit.org/show_bug.cgi?id=79577
Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-04-20
Reviewed by Daniel Bates.
Enable mock scrollbars if running DumpRenderTree.
- webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
- 4:32 PM Changeset in webkit [114798] by
-
- 2 edits1 add in trunk/LayoutTests
REGRESSION (r114764-r114766): svg/css/getComputedStyle-basic.xhtml failing on Lion Debug (Tests)
https://bugs.webkit.org/show_bug.cgi?id=84483
Reviewed by Simon Fraser.
Add -webkit-filter results to the platforms on which it is enabled.
This required a new platform result for WebKit mac.
- platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
- platform/mac/svg/css/getComputedStyle-basic-expected.txt: Copied from LayoutTests/platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt.
- platform/mac/test_expectations.txt:
- 4:31 PM Changeset in webkit [114797] by
-
- 11 edits3 adds in trunk/Source
[Chromium] Call memoryUsageMB directly
https://bugs.webkit.org/show_bug.cgi?id=84376
Reviewed by Kentaro Hara.
Source/WebCore:
Now that memoryUsageMB has been moved from PlatformSupport.h to
Platform.h, we need to be able to call it directly
from WebCore/bindings/v8/V8GCController.cpp.
That means we need a new MemoryUsageSupport class in
WebCore/platform/ and an implementation in
WebCore/platform/chromium/MemoryUsageSupportChromium.cpp.
Other ports are welcome to implement their memory usage
functions if they wish. This pattern was based on the
HistogramSupport/HistogramSupportChromium classes.
Part of a refactoring series. See tracking bug 82948.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/v8/V8GCController.cpp:
(WebCore):
- platform/MemoryUsageSupport.cpp: Added.
(WebCore):
(WebCore::MemoryUsageSupport::memoryUsageMB):
- platform/MemoryUsageSupport.h: Added.
(WebCore):
(MemoryUsageSupport):
- platform/chromium/MemoryUsageSupportChromium.cpp: Added.
(WebCore):
(WebCore::MemoryUsageSupport::memoryUsageMB):
- platform/chromium/PlatformSupport.h:
(PlatformSupport):
Source/WebKit/chromium:
Part of a refactoring series. See tracking bug 82948.
- src/PlatformSupport.cpp:
(WebCore):
- 4:18 PM Changeset in webkit [114796] by
-
- 3 edits in trunk/Tools
[GTK] Revert changes that disabled Cairo fonts metrics hinting
https://bugs.webkit.org/show_bug.cgi?id=84502
Reviewed by Daniel Bates.
Re-enable Cairo metrics hinting, which seems to ensure consistent results in
reference and pixel test results. This makes our font metrics a bit different
than the Mac port's, but it's a decent price to pay for consistent results.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(initializeGtkFontSettings):
- WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
(WTR::initializeGtkSettings):
- 4:18 PM Internals_Hackathon edited by
- (diff)
- 4:05 PM BuildingGtk edited by
- (diff)
- 4:04 PM Changeset in webkit [114795] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r114784): svg/text/foreignObject-text-clipping-bug.xml failing on Mountain Lion Debug Tests
https://bugs.webkit.org/show_bug.cgi?id=84505
Unreviewed; add new crashing test result to test_expectations.txt.
- platform/mac/test_expectations.txt:
- 4:03 PM Changeset in webkit [114794] by
-
- 2 edits3 adds in trunk/LayoutTests
[EFL] [DRT] Add baselines for the tests which are missing expected results
https://bugs.webkit.org/show_bug.cgi?id=84440
Unreviewed, added EFL baselines for passing tests and also skipped two tests
which are failing due to missing implementation.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-20
- platform/efl/Skipped:
- platform/efl/fast/block/float/avoiding-float-centered-expected.png: Added.
- platform/efl/fast/block/float/avoiding-float-centered-expected.txt: Added.
- platform/efl/fast/events/panScroll-click-hyperlink-expected.txt: Added.
- 3:52 PM Changeset in webkit [114793] by
-
- 4 edits in trunk/Source/JavaScriptCore
Inline the JSArray constructor
https://bugs.webkit.org/show_bug.cgi?id=84416
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-20
Reviewed by Geoffrey Garen.
The constructor is trivial, no reason to jump for it.
This makes the creation of array ~5% faster (on non-trivial cases, no empty arrays).
- runtime/JSArray.cpp:
(JSC):
- runtime/JSArray.h:
(JSC::JSArray::JSArray):
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 3:46 PM April 2012 Meeting edited by
- (diff)
- 3:45 PM April 2012 Meeting edited by
- Adding notes for the keeping the bots green session (diff)
- 3:44 PM April 2012 Keeping the bots green created by
- Notes for the keeping the bots green session
- 3:38 PM Changeset in webkit [114792] by
-
- 2 edits in trunk/Source/WebCore
Re-land. The non-fast scrollable region is now always updated after layout, and frameViewScrollableAreasDidChange has been removed.
computeNonFastScrollableRegion needs to traverse the entire frame tree
https://bugs.webkit.org/show_bug.cgi?id=84409
<rdar://problem/11285741>
Reviewed by Dan Bernstein.
Now that scrollable areas won't be in the set of scrollable areas unless they are actually scrollable, we need to look for scrollable
areas in the entire frame tree since there can be a scrollable frame that's a subframe of a non-scrollable frame for example.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::computeNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
- 3:35 PM Changeset in webkit [114791] by
-
- 4 edits in trunk/Source
[chromium] Clip TransparencyWin to prevent OOM from large Skia canvas
https://bugs.webkit.org/show_bug.cgi?id=84289
Reviewed by James Robinson.
Source/WebCore:
TransparencyWin will create a Skia canvas of whatever size is passed
in, even if the result will ultimately be clipped. Handle the clip
implicitly and try (in some cases) to create a smaller canvas. This
can happen due to RenderBox::paintBoxDecorations passing a paint rect
down of the entire element's size.
Modes with more complicated transforms (ScaleTransform, UnTransform)
are not handled yet.
Tests: TransparencyWin.ClippedKeepTransformNoLayer
TransparencyWin.ClippedKeepTransformOpaqueCompositeLayer
TransparencyWin.ClippedKeepTransformOpaqueWhiteLayer
- platform/graphics/chromium/TransparencyWin.cpp:
(WebCore::TransparencyWin::computeLayerSize):
Source/WebKit/chromium:
Add a test that would OOM if the layer wasn't clipped. Also, verify
that clipping the canvas doesn't shift pixels around incorrectly.
- tests/TransparencyWinTest.cpp:
(WebCore::testClippedLayerKeepTransform):
(WebCore):
(WebCore::TEST):
- 3:33 PM Changeset in webkit [114790] by
-
- 22 edits in trunk
apple.com top navigation bar appears inside video during full screen exit animation
https://bugs.webkit.org/show_bug.cgi?id=83095
Reviewed by Eric Carlson.
Source/WebCore:
Test: fullscreen/full-screen-exit-animation-stacking-context.html
Only tell ancestors of the full screen element that they are no longer ancestors once
the full screen animation is complete:
- dom/Document.cpp:
(WebCore::Document::webkitWillExitFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):
To facilitate writing reproducible LayoutTests, expose webkitWill/Did/Enter/ExitFullScreen
from the Internals object, so scripts can call them explicitly:
- testing/Internals.cpp:
(WebCore::Internals::webkitWillEnterFullScreenForElement): Call the Document equivalent.
(WebCore::Internals::webkitDidEnterFullScreenForElement): Ditto.
(WebCore::Internals::webkitWillExitFullScreenForElement): Ditto.
(WebCore::Internals::webkitDidExitFullScreenForElement): Ditto.
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit2:
Add new WebCore symbols needed by DumpRenderTree to exported symbol list.
- win/WebKit2.def:
- win/WebKit2CFLite.def:
Tools:
Add a new LayoutTestController function, setHasCustomFullScreenBehavior(), which allows scripts to
disable the standard full screen behavior, and replace it with explicit callbacks to the relevant
Document methods from within the script. This allows subtle timing bugs to be consistently reproduced
from within LayoutTests.
Add the new methods, hasCustomFullScreenBehavior() and setHasCustomFullScreenBehavior():
- DumpRenderTree/LayoutTestController.cpp:
(setHasCustomFullScreenBehaviorCallback):
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
(LayoutTestController::setHasCustomFullScreenBehavior):
(LayoutTestController::hasCustomFullScreenBehavior):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::enterFullScreenForElement):
(WTR::InjectedBundlePage::exitFullScreenForElement):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(WTR::LayoutTestController::setHasCustomFullScreenBehavior):
(WTR::LayoutTestController::hasCustomFullScreenBehavior):
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::reset):
- DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController::setHasCustomFullScreenBehavior):
(LayoutTestController::hasCustomFullScreenBehavior):
Query the new methods before calling will/did/Enter/ExitFullScreen:
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::enterFullScreenNow):
(WebViewHost::exitFullScreenNow):
- DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webView:enterFullScreenForElement:listener:]):
(-[UIDelegate webView:exitFullScreenForElement:listener:]):
LayoutTests:
- fullscreen/full-screen-exit-animation-stacking-context-expected.txt: Added.
- fullscreen/full-screen-exit-animation-stacking-context.html: Added.
- platform/mac/fullscreen/full-screen-exit-animation-stacking-context-expected.png: Added.
- 3:33 PM Changeset in webkit [114789] by
-
- 5 edits in trunk/Source/WebCore
media-exit-fullscreen-button (and related enums) is unnecessary and should be removed.
https://bugs.webkit.org/show_bug.cgi?id=84162
Reviewed by Eric Carlson.
No new tests; no change in functionality so covered by existing tests.
Remove the media-exit-fullscreen-button keyword, and rename media-enter-fullscreen-button to
media-fullscreen-button.
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- css/CSSValueKeywords.in:
- css/mediaControls.css:
(audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):
- platform/ThemeTypes.h:
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint):
- 3:32 PM Changeset in webkit [114788] by
-
- 14 edits in trunk/Tools
NRWT: option --skip-pixel-test-if-no-baseline support on DRT
https://bugs.webkit.org/show_bug.cgi?id=72841
Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-04-20
Reviewed by Dirk Pranke
This patch implements support for --skip-pixel-test-if-no-baseline generically in NRWT,
instead of in every DRT and WTR implementation. We add 'should_run_pixel_test'
and 'reference_files' fields to the TestInput objects, and use those flags
to select the right driver to use in the DriverProxy.
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner.init):
(SingleTestRunner._driver_input):
(SingleTestRunner._run_reftest):
- Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker.handle_test_list):
(Worker._update_test_input):
- Scripts/webkitpy/layout_tests/models/test_input.py:
(TestInput):
(TestInput.init):
(TestInput.repr):
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver._wrapper_options):
(ChromiumDriver.run_test):
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
(ChromiumDriverTest.test_crash_log):
- Scripts/webkitpy/layout_tests/port/driver.py:
(DriverInput.init):
(Driver.init):
(DriverProxy.init):
(DriverProxy.run_test):
(DriverProxy.start):
(DriverProxy.cmd_line):
- Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkDriver._start):
- Scripts/webkitpy/layout_tests/port/mock_drt.py:
(MockDRT.run):
(MockDRT.input_from_line):
(MockDRT.output_for_test):
(MockDRT.write_test_output):
(MockChromiumDRT.input_from_line):
(MockChromiumDRT.output_for_test):
(MockChromiumDRT.write_test_output):
- Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver.cmd_line):
(WebKitDriver.run_test):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::runTest):
- WebKitTestRunner/TestController.h:
(TestController):
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::TestInvocation):
(WTR::TestInvocation::setIsPixelTest):
- WebKitTestRunner/TestInvocation.h:
(TestInvocation):
- 3:18 PM Changeset in webkit [114787] by
-
- 3 edits in trunk/Source/WebCore
[chromium] Fix compile errors when DEBUG_GL_CALLS is enabled
https://bugs.webkit.org/show_bug.cgi?id=84491
Patch by Alexandre Elias <aelias@google.com> on 2012-04-20
Reviewed by Ojan Vafai.
DEBUG_GL_CALLS had not been used in a while and the mode no longer
compiled when I tried it. I improved the GLC macro to support either
raw pointers or RefPtrs, and to be a single expression in order to
interact properly with if/else blocks. I fixed the cases where we
were passing in the "context" method pointer by mistake, and removed the
now-unnecessary "get()" calls for the RefPtrs.
No new tests. (No-op change in release builds.)
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::clearRenderSurface):
(WebCore::LayerRendererChromium::beginDrawingFrame):
(WebCore::LayerRendererChromium::doNoOp):
(WebCore::LayerRendererChromium::drawQuad):
(WebCore::LayerRendererChromium::drawTextureQuad):
(WebCore::LayerRendererChromium::drawHeadsUpDisplay):
(WebCore::LayerRendererChromium::finishDrawingFrame):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::bindFramebufferToTexture):
(WebCore::LayerRendererChromium::setScissorToRect):
(WebCore::LayerRendererChromium::setDrawViewportRect):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
- platform/graphics/chromium/LayerRendererChromium.h:
(WebCore):
- 3:15 PM Changeset in webkit [114786] by
-
- 2 edits in trunk/Source/WebCore
Fix build.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::updateMainFrameScrollPositionAndScrollLayerPosition):
- 3:15 PM April 2012 Meeting edited by
- (diff)
- 2:54 PM Changeset in webkit [114785] by
-
- 6 edits in trunk/Source/WebCore
Set m_compositingDependsOnGeometry to false if possible
https://bugs.webkit.org/show_bug.cgi?id=84391
Reviewed by James Robinson.
For some kinds of elements, RenderLayerCompositor has to delay decisions about
compositing until the element's size and/or position are known. This was previsouly
based on the confusingly named m_compositingDependsOnGeometry flag, but another
variant of the same technique, with an additional flag m_compositingNeedsUpdate,
was added in r98627.
Also, once the m_compositingDependsOnGeometry flag was set to true, nothing
set it to false, so every compositing layer update resulted in a computeCompositingRequirements()
pass over the layers.
Rename the m_compositingDependsOnGeometry flag to m_reevaluateCompositingAfterLayout,
and clear the flag when we do a layout-related compositing layer update.
Use the same flag for position:fixed compositing.
This requires RenderLayerCompositor to distinguish between style- and layout-
related updates, requiring some minor refactoring in FrameView.
Should not change behavior.
- dom/Document.cpp:
(WebCore::Document::recalcStyle):
(WebCore::Document::implicitClose):
- page/FrameView.cpp:
(WebCore::FrameView::updateCompositingLayersAfterStyleChange):
(WebCore::FrameView::updateCompositingLayersAfterLayout):
(WebCore::FrameView::restoreBackingStores):
(WebCore::FrameView::layout):
- page/FrameView.h:
(FrameView):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::updateCompositingLayersTimerFired):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::layerTreeAsText):
(WebCore::RenderLayerCompositor::requiresCompositingForPlugin):
(WebCore::RenderLayerCompositor::requiresCompositingForFrame):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
- rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
- 2:45 PM April 2012 Write Your Own Render Object edited by
- (diff)
- 2:41 PM April 2012 Write Your Own Render Object edited by
- (diff)
- 2:40 PM Changeset in webkit [114784] by
-
- 8 edits2 adds in trunk
Source/WebCore: <rdar://problem/10786000> Selection highlights of lines in adjoining blocks can overlap
https://bugs.webkit.org/show_bug.cgi?id=84489
Reviewed by Anders Carlsson.
Test: fast/block/line-layout/selection-highlight-overlap.html
- rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::selectionRect): Changed to use
selection{Top,Height}AdjustedForPrecedingBlock().
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintSelection): Ditto.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::inlineSelectionGaps): Ditto.
(WebCore::RenderBlock::blockBeforeWithinSelectionRoot): Added. Returns the block which is
likely to contain the selected line just before the first line in this block, if it is
within the same selection root.
- rendering/RenderBlock.h:
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::selectionTopAdjustedForPrecedingBlock): Added. If the selection
starts before our block, finds the last line in the preceding block and adjusts the selection
top to avoid overlap with that line’s selection bottom.
- rendering/RootInlineBox.h:
(WebCore::RootInlineBox::selectionHeightAdjustedForPrecedingBlock): Added. Like
selectionHeight(), but uses selectionTopAdjustedForPrecedingBlock().
LayoutTests: Selection highlights of lines in adjoining blocks can overlap
https://bugs.webkit.org/show_bug.cgi?id=84489
Reviewed by Anders Carlsson.
- fast/block/line-layout/selection-highlight-overlap-expected.html: Added.
- fast/block/line-layout/selection-highlight-overlap.html: Added.
- 2:37 PM Changeset in webkit [114783] by
-
- 2 edits in trunk/Source/WebCore
Crash in getOrDrawNodeHighlight after r114659
https://bugs.webkit.org/show_bug.cgi?id=84486
Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2012-04-20
Reviewed by Daniel Bates.
No new tests. Fixes a crash in test: inspector/elements/elements-panel-selection-on-refresh.html.
- inspector/DOMNodeHighlighter.cpp:
- 2:33 PM April 2012 Write Your Own Render Object edited by
- (diff)
- 2:29 PM Changeset in webkit [114782] by
-
- 11 edits in trunk/Source
https://bugs.webkit.org/show_bug.cgi?id=84490
PageGroupLoadDeferrer needs to take a ReasonForSuspension argument
Reviewed by Anders Carlsson.
Source/WebCore:
No new tests. (Refactor, no change in behavior)
- Make PageGroupLoadDeferrer take a ReasonForSuspension argument so it can pass it along.
- page/PageGroupLoadDeferrer.cpp:
(WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
- page/PageGroupLoadDeferrer.h:
- Change suspendScheduledTasks to take a ReasonForSuspension.
- As long as we're changing Document.h, add a m_suspendedScheduledTasks flag and some ASSERTs to catch what would be epically wrong behavior in the future.
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::suspendScheduledTasks):
(WebCore::Document::resumeScheduledTasks):
- dom/Document.h:
- Pass ActiveDOMObject::WillShowDialog along to all PageGroupLoadDeferrers, as it used to be the default behavior
- page/Chrome.cpp:
(WebCore::Chrome::runModal):
(WebCore::Chrome::runBeforeUnloadConfirmPanel):
(WebCore::Chrome::runJavaScriptAlert):
(WebCore::Chrome::runJavaScriptConfirm):
(WebCore::Chrome::runJavaScriptPrompt):
(WebCore::Chrome::shouldInterruptJavaScript):
Source/WebKit/blackberry:
- Api/WebPageGroupLoadDeferrer.cpp:
(BlackBerry::WebKit::WebPageGroupLoadDeferrer::WebPageGroupLoadDeferrer): Pass along ActiveDOMObject::WillShowDialog,
which used to be the default
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::createWindow): Pass along ActiveDOMObject::WillShowDialog, which used to be the default.
(WebCore::ChromeClientBlackBerry::runOpenPanel): Ditto.
Source/WebKit/chromium:
- src/WebViewImpl.cpp:
(WebKit::WebView::willEnterModalLoop): Pass along ActiveDOMObject::WillShowDialog, which used
to be the default.
- 2:25 PM Changeset in webkit [114781] by
-
- 2 edits in trunk/Source/WebCore
Scrolling after going to a find-in-page result jumps to the top of the page
https://bugs.webkit.org/show_bug.cgi?id=84485
<rdar://problem/11273734>
Reviewed by Beth Dakin.
If we're both updating the requested scroll position and entering slow mode in the same commit, the
probable main thread scroll position should be the requested scroll position.
- page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::update):
- 2:23 PM April 2012 Write Your Own Render Object edited by
- (diff)
- 2:22 PM Changeset in webkit [114780] by
-
- 479 edits4 copies in branches/subpixellayout
Merge trunk changes up until 114777 into subpixel branch.
- 2:22 PM April 2012 Write Your Own Render Object edited by
- (diff)
- 2:19 PM Changeset in webkit [114779] by
-
- 6 edits2 adds in trunk/Source/WebKit
[BlackBerry] Expose WebViewportArguments to WebPageClient
https://bugs.webkit.org/show_bug.cgi?id=84471
Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-04-20
Reviewed by Antonio Gomes.
Source/WebKit:
- PlatformBlackBerry.cmake:
Source/WebKit/blackberry:
Implement the ability for the WebPageClient to specify a fallback
virtual viewport to be used whenever a meta viewport tag is not
present in the HTML. This can drastically impact apparent layout.
This patch is designed to provide a classic "Column View" style of
layout without breaking the web by simply exposing meta viewport
arguments to WebPageClients.
Note: As a side effect of this change. the WebPagePrivate::
recomputeVirtualViewportFromViewportArguments method no longer
modifies the targetDensityDpi property of the m_viewportArguments.
However this does not affect the class because that property itself
means nothing to us. Only the computeViewportArguments method from
WebCore uses it, and the currentViewportArguments object we pass
into that method has the adjusted targetDensityDpi value as before.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::setUserViewportArguments):
(WebKit):
(BlackBerry::WebKit::WebPage::resetUserViewportArguments):
(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
- Api/WebPage.h:
(WebKit):
- Api/WebPage_p.h:
(WebPagePrivate):
- Api/WebViewportArguments.cpp: Added.
(WebKit):
(BlackBerry::WebKit:::d):
(BlackBerry::WebKit::WebViewportArguments::~WebViewportArguments):
(BlackBerry::WebKit::WebViewportArguments::initialScale):
(BlackBerry::WebKit::WebViewportArguments::setInitialScale):
(BlackBerry::WebKit::WebViewportArguments::minimumScale):
(BlackBerry::WebKit::WebViewportArguments::setMinimumScale):
(BlackBerry::WebKit::WebViewportArguments::maximumScale):
(BlackBerry::WebKit::WebViewportArguments::setMaximumScale):
(BlackBerry::WebKit::WebViewportArguments::width):
(BlackBerry::WebKit::WebViewportArguments::setWidth):
(BlackBerry::WebKit::WebViewportArguments::height):
(BlackBerry::WebKit::WebViewportArguments::setHeight):
(BlackBerry::WebKit::WebViewportArguments::targetDensityDpi):
(BlackBerry::WebKit::WebViewportArguments::setTargetDensityDpi):
(BlackBerry::WebKit::WebViewportArguments::userScalable):
(BlackBerry::WebKit::WebViewportArguments::setUserScalable):
(BlackBerry::WebKit::WebViewportArguments::operator==):
(BlackBerry::WebKit::WebViewportArguments::operator!=):
- Api/WebViewportArguments.h: Added.
(WebCore):
(WebKit):
- 2:17 PM Changeset in webkit [114778] by
-
- 6 edits in trunk/Source
Avoid synchronously recalculating the nonFastScrollableRegion when the ScrollableArea set changes
https://bugs.webkit.org/show_bug.cgi?id=84470
Patch by James Robinson <jamesr@chromium.org> on 2012-04-20
Reviewed by Anders Carlsson.
Source/WebCore:
When a scrollable area is added or removed, we shouldn't recalculate the nonFastScrollableRegion synchronously
since this is slow, the RenderObject tree might not be in an up-to-date state, and we'll typically do layout
soon anyway.
- page/FrameView.cpp:
(WebCore::FrameView::addScrollableArea):
(WebCore::FrameView::removeScrollableArea):
- page/scrolling/ScrollingCoordinator.cpp:
- page/scrolling/ScrollingCoordinator.h:
(ScrollingCoordinator):
Source/WebKit/chromium:
Trigger a layout when a plugin becomes or stops being scrollable so the nonFastScrollableRegion
can be updated.
- src/ScrollbarGroup.cpp:
(WebKit::ScrollbarGroup::scrollbarCreated):
(WebKit::ScrollbarGroup::scrollbarDestroyed):
- 2:09 PM April 2012 Write Your Own Render Object created by
- 2:02 PM Changeset in webkit [114777] by
-
- 5 edits4 copies in trunk/LayoutTests
Rebaselining svg/css/getComputedStyle-basic.html after
http://trac.webkit.org/changeset/114766
Not reviewed.
- platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt.
- platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt.
- platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt.
- platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt.
- platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
- 1:48 PM April 2012 Meeting edited by
- (diff)
- 1:47 PM April 2012 Meeting edited by
- (diff)
- 1:46 PM EFLWebKit edited by
- Update libsoup version (diff)
- 1:28 PM Changeset in webkit [114776] by
-
- 4 edits in trunk/Tools
[EFL] Make it possible to define offline storage quota per origin
https://bugs.webkit.org/show_bug.cgi?id=84170
Improved LayoutTestController::setDatabaseQuota to set quota based on
origin which was causing some tests to fail. Also align the default
quota for testing (5MB) with others ports.
When dumpDatabaseCallbacks is set to true by, also dump some database
information when quota is exceed, which is also required by some tests.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-20
Reviewed by Antonio Gomes.
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
- DumpRenderTree/efl/DumpRenderTreeView.cpp:
(onExceededDatabaseQuota):
(drtViewAdd):
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setDatabaseQuota):
- 1:22 PM Changeset in webkit [114775] by
-
- 2 edits in trunk/Source/WebCore
Fix use of LayoutUnits in DOMNodeHighlighter
https://bugs.webkit.org/show_bug.cgi?id=84472
Reviewed by Eric Seidel.
Fix use of subpixel units and rounding in new code introduced in r114659.
No new tests, no change in functionality.
- inspector/DOMNodeHighlighter.cpp:
- 1:07 PM Changeset in webkit [114774] by
-
- 2 edits in trunk/LayoutTests
Enable Encrypted Media tests on Chromium now that Chromium side is committed
https://bugs.webkit.org/show_bug.cgi?id=84474
Unreviewed enabling of layout tests.
Patch by David Dorwin <ddorwin@chromium.org> on 2012-04-20
- platform/chromium/test_expectations.txt:
- 1:03 PM Changeset in webkit [114773] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r114764-r114766): svg/css/getComputedStyle-basic.xhtml failing on Lion Debug (Tests)
https://bugs.webkit.org/show_bug.cgi?id=84483
Unreviewed; add new failing test to expected results.
- platform/mac/test_expectations.txt:
- 12:55 PM Changeset in webkit [114772] by
-
- 6 edits in trunk/Source/JavaScriptCore
Heap should cancel GC timer at the start of the collection
https://bugs.webkit.org/show_bug.cgi?id=84477
Reviewed by Geoffrey Garen.
Currently the Heap cancels the GC timer at the conclusion of a collection.
We should change this to be at the beginning because something (e.g. a finalizer)
could call didAbandonObjectGraph(), which will schedule the timer, but then
we'll immediately unschedule the timer at the conclusion of the collection,
thus potentially preventing large swaths of memory from being reclaimed in a timely manner.
- API/JSBase.cpp:
(JSGarbageCollect): Remove outdated fix-me and remove check for whether the Heap is
busy or not, since we're just scheduling a timer to run a GC in the future.
- heap/Heap.cpp:
(JSC::Heap::collect): Rename didCollect to willCollect and move the call to the
top of Heap::collect.
- runtime/GCActivityCallback.cpp: Renamed didCollect to willCollect.
(JSC::DefaultGCActivityCallback::willCollect):
- runtime/GCActivityCallback.h: Ditto.
(JSC::GCActivityCallback::willCollect):
(DefaultGCActivityCallback):
- runtime/GCActivityCallbackCF.cpp: Ditto.
(JSC::DefaultGCActivityCallback::willCollect):
- 12:36 PM Changeset in webkit [114771] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSGarbageCollect should not call collectAllGarbage()
https://bugs.webkit.org/show_bug.cgi?id=84476
Reviewed by Geoffrey Garen.
- API/JSBase.cpp:
(JSGarbageCollect): Notify the Heap's GCActivityCallback using didAbandonObjectGraph.
- 12:11 PM Changeset in webkit [114770] by
-
- 2 edits in trunk/Source/WebCore
Relax ScrollView::adjustScrollPositionWithinRange in case constrainsScrollingToContentEdge is false
https://bugs.webkit.org/show_bug.cgi?id=84178
Reviewed by Adam Treat.
Patch by Antonio Gomes <agomes@rim.com>
No new tests since it is not easily testable.
When a port has both delegatesScrolling and constrainsScrollingToContentEdge set to FALSE
(i.e. it accepts overscrolled position), calling ScrollView::setScrollPosition with an overscrolled
position still gets the position clamped to the content size edges.
Patch relaxes ::adjustScrollPositionWithinRange in that sense in order to track the actual scroll
position.
Note: ScrollView::setScrollOffset already does something similar.
- platform/ScrollView.cpp:
(WebCore::ScrollView::adjustScrollPositionWithinRange):
- 12:09 PM Changeset in webkit [114769] by
-
- 495 edits23 copies in branches/subpixellayout
Merge trunk changes up until 114767 into subpixel branch.
- 12:07 PM April 2012 Meeting edited by
- (diff)
- 12:04 PM Changeset in webkit [114768] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r114535.
http://trac.webkit.org/changeset/114535
https://bugs.webkit.org/show_bug.cgi?id=84475
It might have caused V8 crashes. (Requested by pfeldman_ on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-20
- bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::V8IsolatedContext):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::evaluateInIsolatedWorld):
(WebCore::V8Proxy::setInjectedScriptContextDebugId):
(WebCore):
- bindings/v8/V8Proxy.h:
(V8Proxy):
- 11:51 AM April 2012 Reducing build systems edited by
- Add clarifying sentence to section "Another approach: scripts; … (diff)
- 11:46 AM Changeset in webkit [114767] by
-
- 2 edits in branches/subpixellayout/Source/WebCore
Misc platform fixes on branch.
- 11:42 AM April 2012 Reducing build systems edited by
- Fix formatting; spelling/grammer corrections (diff)
- 11:41 AM Changeset in webkit [114766] by
-
- 9 edits in trunk
-webkit-filter missing from computed style enumeration
https://bugs.webkit.org/show_bug.cgi?id=84468
Source/WebCore:
Reviewed by Timothy Hatcher.
CSSComputedStyleDeclaration has a list of properties that it exposes.
While the computed style for filter was available, the property wasn't
listed and hence missing in clients like the Web Inspector.
Covered by existing tests.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore): add CSSPropertyWebkitFilter
LayoutTests:
Reviewed by Timothy Hatcher.
Added new results for platforms that have filters enabled. Hopefully
I got them all. Luckily there were already platform results for this
test in each case.
- platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- 11:35 AM April 2012 Meeting edited by
- (diff)
- 11:34 AM April 2012 JavaScriptCore Roundup created by
- 11:29 AM April 2012 Meeting edited by
- (diff)
- 11:29 AM April 2012 Meeting edited by
- (diff)
- 11:28 AM April 2012 Reducing build systems created by
- First pass at notes.
- 11:27 AM April 2012 Canvas Canvass created by
- 11:13 AM Changeset in webkit [114765] by
-
- 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
Move bot to Lion Debug to help catch up.
- 11:12 AM Changeset in webkit [114764] by
-
- 5 edits in trunk/Source
[win] Update windows platform code to use pixel snapped values
https://bugs.webkit.org/show_bug.cgi?id=84283
Reviewed by Eric Seidel.
Source/WebCore:
No new tests, no change in functionality.
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::pixelSnappedElementRect):
Use pixel snapped values when computing screenRect.
- platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::calculatePositionAndSize):
(WebCore::PopupMenuWin::paint):
Cast client padding to ints as they are guaranteed to align with device pixels.
Source/WebKit/win:
- AccessibleBase.cpp:
(AccessibleBase::accLocation):
- 11:03 AM April 2012 Meeting edited by
- (diff)
- 11:02 AM April 2012 Meeting edited by
- (diff)
- 11:01 AM April 2012 Meeting edited by
- (diff)
- 11:00 AM Scrolling Session Meeting 2012 created by
- 10:57 AM Changeset in webkit [114763] by
-
- 6 edits in trunk/Source
[chromium] Some filters require inflating damage rect in CCDamageTracker
https://bugs.webkit.org/show_bug.cgi?id=84373
Reviewed by James Robinson.
Source/WebCore:
When a layer is blurred, damaged pixels are blurred out into a radius
and their damage should be expanded to include total blurred region.
Unit test: CCDamageTrackerTest.verifyDamageForBlurredSurface
- platform/graphics/chromium/cc/CCDamageTracker.cpp:
(WebCore::CCDamageTracker::updateDamageTrackingState):
(WebCore::CCDamageTracker::expandDamageRectWithForegroundFilters):
(WebCore):
- platform/graphics/chromium/cc/CCDamageTracker.h:
(WebCore):
(CCDamageTracker):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::trackDamageForAllSurfaces):
Source/WebKit/chromium:
- tests/CCDamageTrackerTest.cpp:
(WebKitTests::emulateDrawingOneFrame):
(WebKitTests::TEST_F):
(WebKitTests):
- 10:56 AM April 2012 Meeting edited by
- Add hyperlink to discussion notes for session "Reducing build systems" (diff)
- 10:54 AM Changeset in webkit [114762] by
-
- 978 edits65 copies30 deletes in branches/subpixellayout
Merge trunk changes up until 114758 into subpixel branch.
- 10:53 AM Changeset in webkit [114761] by
-
- 4 edits in trunk/Source
[chromium] Don't crash when scrolling empty layer tree
https://bugs.webkit.org/show_bug.cgi?id=84455
Patch by Sami Kyostila <skyostil@chromium.org> on 2012-04-20
Reviewed by James Robinson.
Source/WebCore:
Do not try to calculate render passes when there are no layers in the
layer tree.
Added new unit test.
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
Source/WebKit/chromium:
Try to scroll an empty layer tree.
- tests/CCLayerTreeHostImplTest.cpp:
(WebKitTests::TEST_F):
(WebKitTests):
- 10:46 AM Changeset in webkit [114760] by
-
- 5 edits in trunk
Ensure text is centered for default captions
https://bugs.webkit.org/show_bug.cgi?id=84450
Patch by Victor Carbune <vcarbune@adobe.com> on 2012-04-20
Reviewed by Eric Carlson.
Source/WebCore:
Updated existing test.
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::getDisplayTree): Added default width.
LayoutTests:
Updated test to cover default positioning of captions.
- media/track/track-cue-rendering-expected.txt: Updated.
- media/track/track-cue-rendering.html: Updated.
- 10:31 AM Changeset in webkit [114759] by
-
- 21 edits23 adds in trunk/LayoutTests
[EFL][DRT] Gardening SVG tests and timeouts
https://bugs.webkit.org/show_bug.cgi?id=84462
Unreviewed, EFL gardening.
A number of SVG Batik text tests needed rebaselining likely due to bug 83264.
Also, moving some tests that fail to call notifyDone to test_expectations with appropriate bugs filed.
Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-20
- platform/efl/svg/batik/text/longTextOnPath-expected.png: Added.
- platform/efl/svg/batik/text/longTextOnPath-expected.txt:
- platform/efl/svg/batik/text/smallFonts-expected.png: Added.
- platform/efl/svg/batik/text/smallFonts-expected.txt:
- platform/efl/svg/batik/text/textAnchor2-expected.png: Added.
- platform/efl/svg/batik/text/textAnchor3-expected.png: Added.
- platform/efl/svg/batik/text/textDecoration-expected.png: Added.
- platform/efl/svg/batik/text/textDecoration-expected.txt:
- platform/efl/svg/batik/text/textDecoration2-expected.png: Added.
- platform/efl/svg/batik/text/textEffect-expected.png: Added.
- platform/efl/svg/batik/text/textEffect-expected.txt:
- platform/efl/svg/batik/text/textEffect2-expected.png: Added.
- platform/efl/svg/batik/text/textEffect2-expected.txt:
- platform/efl/svg/batik/text/textEffect3-expected.png: Added.
- platform/efl/svg/batik/text/textEffect3-expected.txt:
- platform/efl/svg/batik/text/textFeatures-expected.png: Added.
- platform/efl/svg/batik/text/textFeatures-expected.txt:
- platform/efl/svg/batik/text/textGlyphOrientationHorizontal-expected.png: Added.
- platform/efl/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
- platform/efl/svg/batik/text/textLayout-expected.png: Added.
- platform/efl/svg/batik/text/textLayout-expected.txt:
- platform/efl/svg/batik/text/textLayout2-expected.png: Added.
- platform/efl/svg/batik/text/textLayout2-expected.txt:
- platform/efl/svg/batik/text/textLength-expected.png: Added.
- platform/efl/svg/batik/text/textLength-expected.txt:
- platform/efl/svg/batik/text/textOnPath2-expected.png: Added.
- platform/efl/svg/batik/text/textOnPath2-expected.txt:
- platform/efl/svg/batik/text/textOnPathSpaces-expected.png: Added.
- platform/efl/svg/batik/text/textOnPathSpaces-expected.txt:
- platform/efl/svg/batik/text/textPCDATA-expected.png: Added.
- platform/efl/svg/batik/text/textPosition-expected.png: Added.
- platform/efl/svg/batik/text/textPosition-expected.txt:
- platform/efl/svg/batik/text/textPosition2-expected.png: Added.
- platform/efl/svg/batik/text/textPosition2-expected.txt:
- platform/efl/svg/batik/text/textProperties-expected.png: Added.
- platform/efl/svg/batik/text/textProperties-expected.txt:
- platform/efl/svg/batik/text/textStyles-expected.png: Added.
- platform/efl/svg/batik/text/textStyles-expected.txt:
- platform/efl/svg/batik/text/verticalText-expected.png: Added.
- platform/efl/svg/batik/text/verticalText-expected.txt:
- platform/efl/svg/batik/text/xmlSpace-expected.png: Added.
- platform/efl/svg/batik/text/xmlSpace-expected.txt:
- platform/efl/test_expectations.txt:
- 10:23 AM April 2012 HTML5 Media Element & WebAudio created by
- Initial Commit
- 10:23 AM April 2012 Meeting edited by
- (diff)
- 10:13 AM Changeset in webkit [114758] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: open file dialog is not centered.
https://bugs.webkit.org/show_bug.cgi?id=84464
Reviewed by Yury Semikhatsky.
There was an error in the positioning logic.
- inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog.prototype.position):
- 10:11 AM Importing Thirdparty tests edited by
- (diff)
- 10:11 AM April 2012 Meeting edited by
- (diff)
- 10:10 AM Importing Thirdparty tests created by
- 10:09 AM April 2012 Meeting edited by
- (diff)
- 10:09 AM Changeset in webkit [114757] by
-
- 28 edits in branches/chromium/1084/Source
Merge 113677 - [chromium] Viewport is not filled when out of texture memory on mac
https://bugs.webkit.org/show_bug.cgi?id=83351
Reviewed by Adrienne Walker.
Source/Platform:
- chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):
Source/WebCore:
Currently we add gutter quads on the NonCompositedContentHost layer,
which lies above another visible layer - the rubberband layer on mac.
For this reason, on mac, gutter quads were disabled, as well as forcing
the NCCH layer to draw, in order to make the rubberband layer appear.
We move the logic for adding gutter quads into CCRenderPass, and add
gutter quads for all pixels that are visible through the viewport.
This allows us to stop special-casing the NCCH layer, and allows us
to skip drawing the layer equally with other layers. We remove the
backgroundCoversViewport() flag entirely.
In order to do this, we fix a bug in the occlusion tracker, that
allowed opaque() layers with skipsDraw to occlude, by making
the visibleContentOpaqueRegion() method on the layer classes
also return the opaque region for non-tiled layers, always use
its value in the occlusion tracker.
Unit test: CCLayerTreeHostImplTest.viewportCovered
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::pushPropertiesTo):
(WebCore::LayerChromium::visibleContentOpaqueRegion):
(WebCore):
- platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::visibleContentOpaqueRegion):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::visibleContentOpaqueRegion):
(WebCore):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::appendQuads):
(CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::setBackgroundColor):
(CCLayerTreeHost):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(WebCore::CCLayerTreeHostImpl::backgroundColor):
(WebCore::CCLayerTreeHostImpl::setBackgroundColor):
(CCLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::computeOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):
- platform/graphics/chromium/cc/CCOcclusionTracker.h:
(CCOcclusionTrackerBase):
(WebCore::CCOcclusionTrackerBase::computeVisibleRegionInScreen):
- platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::appendQuadsToFillScreen):
(WebCore):
- platform/graphics/chromium/cc/CCRenderPass.h:
(WebCore):
(CCRenderPass):
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::appendQuads):
(WebCore::CCTiledLayerImpl::visibleContentOpaqueRegion):
- platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(WebCore::CCTiledLayerImpl::skipsDraw):
(CCTiledLayerImpl):
Source/WebKit/chromium:
- src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setBackgroundColor):
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::setBackgroundColor):
(WebKit):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setBackgroundColor):
(WebKit):
(WebKit::WebViewImplContentPainter::paint):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
- src/WebViewImpl.h:
(WebCore):
(WebViewImpl):
- tests/CCLayerImplTest.cpp:
(WebCore::TEST):
- tests/CCLayerTreeHostImplTest.cpp:
(WebKitTests::BlendStateCheckLayer::appendQuads):
(WebKitTests::TEST_F):
(WebKitTests):
- tests/CCLayerTreeHostTest.cpp:
(WTF):
(CCLayerTreeHostTestCommit):
(WTF::CCLayerTreeHostTestCommit::CCLayerTreeHostTestCommit):
(WTF::CCLayerTreeHostTestCommit::beginTest):
(WTF::CCLayerTreeHostTestCommit::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestCommit::afterTest):
(WTF::TEST_F):
(TestLayerChromium):
- tests/CCOcclusionTrackerTest.cpp:
(WebKitTests::TestContentLayerChromium::TestContentLayerChromium):
(WebKitTests::TestContentLayerChromium::visibleContentOpaqueRegion):
(WebKitTests::TestContentLayerChromium::setOpaqueContentsRect):
(TestContentLayerChromium):
(WebKitTests::TestContentLayerImpl::TestContentLayerImpl):
(TestContentLayerImpl):
(WebKitTests::TestContentLayerImpl::visibleContentOpaqueRegion):
(WebKitTests::TestContentLayerImpl::setOpaqueContentsRect):
- tests/CCTiledLayerImplTest.cpp:
- tests/LayerChromiumTest.cpp:
TBR=danakj@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10146014
- 10:08 AM Instrumentation and Metrics created by
- 10:07 AM Changeset in webkit [114756] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Mark inspector/profiler/heap-snapshot-inspect-dom-wrapper.html
as TIMEOUT since it's too slow for even SLOW at the moment.
- platform/chromium/test_expectations.txt:
- 10:05 AM Changeset in webkit [114755] by
-
- 1 edit1 delete in trunk/Source/WebCore
[Qt] PlatformMouseEventQt.cpp should be deleted.
https://bugs.webkit.org/show_bug.cgi?id=84437
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-20
Reviewed by Kenneth Rohde Christiansen.
- platform/qt/PlatformMouseEventQt.cpp: Removed.
- 9:39 AM UpdatingBugzilla edited by
- (diff)
- 9:28 AM Changeset in webkit [114754] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: follow up to r114729: more @return annotations added.
https://bugs.webkit.org/show_bug.cgi?id=84447
Reviewed by Yury Semikhatsky.
- inspector/front-end/Resource.js:
(WebInspector.Resource):
(WebInspector.ResourceRevision.prototype.get content):
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeFrame.prototype._addRequest):
- inspector/front-end/ResourceUtils.js:
(String.prototype.asParsedURL):
- 9:24 AM Changeset in webkit [114753] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: migrate from ScriptsNavigator to NavigatorView in the Styles panel
https://bugs.webkit.org/show_bug.cgi?id=84459
Reviewed by Yury Semikhatsky.
Now that NavigatorView has all the functionality we need, we can use it.
- inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorScriptTreeElement.prototype.ondblclick):
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator):
- inspector/front-end/StylesPanel.js:
(WebInspector.StylesPanel):
(WebInspector.StylesPanel.prototype._resourceAdded):
(WebInspector.StylesPanel.prototype._reset):
(WebInspector.StylesPanel.prototype._itemSelected):
(WebInspector.StylesPanel.prototype._showFile):
- inspector/front-end/navigatorView.css:
(.navigator-tabbed-pane .tabbed-pane-content):
(.navigator-tabbed-pane .navigator-container):
(.navigator-tabbed-pane .navigator):
(.navigator-tabbed-pane .tabbed-pane-header):
(.navigator-tabbed-pane .tabbed-pane-header-contents):
- inspector/front-end/scriptsPanel.css:
- 9:15 AM Changeset in webkit [114752] by
-
- 3 edits in trunk/LayoutTests
Layout Test svg/transforms/transform-origin-css-property.xhtml is failing
https://bugs.webkit.org/show_bug.cgi?id=84203
Reviewed by Simon Fraser.
This test compares CSS div's n a ref-test with a single spec for transform-origin
to SVG rects with multipe specs for transform-origin that are supposed
to all be equivalent, such as [50%,50%] and [center, center]. It fails
due to one-pixel differences on Chromium.
This change renders as many divs in the ref-test as SVG rects in the
test, and ends up with the same result. It seems likely that one of
the several specs that are used is computed slightly differently
(maybe 50% is not the same as center).
- platform/chromium/test_expectations.txt:
- svg/transforms/transform-origin-css-property-expected.xhtml:
- 9:13 AM Changeset in webkit [114751] by
-
- 1 edit1 delete in trunk/LayoutTests
Remove empty svg/misc directory
https://bugs.webkit.org/show_bug.cgi?id=79917
Unreviewed test directory cleanup.
- svg/misc: Removed.
- svg/misc/resources: Removed.
- 9:11 AM Changeset in webkit [114750] by
-
- 1 edit2 adds in trunk/LayoutTests
SVG anchor on use fails
https://bugs.webkit.org/show_bug.cgi?id=81122
Reviewed by Rob Buis.
Adding a ref test for this bug. This seems to have been fixed, but a
regression test is in order.
- svg/custom/anchor-on-use-expected.svg: Added.
- svg/custom/anchor-on-use.svg: Added.
- 9:08 AM Changeset in webkit [114749] by
-
- 7 edits2 adds in trunk/Source/WebKit
[EFL] Add Security Origin API
https://bugs.webkit.org/show_bug.cgi?id=84023
Source/WebKit:
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-20
Reviewed by Antonio Gomes.
- PlatformEfl.cmake:
Source/WebKit/efl:
Added an API to get a Security Origin handle from a Ewk_Frame. This is
needed for fine grained security policy. This new API will also allow
to define quota and get usage information of a Web Storage based on its
Security Origin.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-20
Reviewed by Antonio Gomes.
- ewk/EWebKit.h:
- ewk/ewk_frame.cpp:
(ewk_frame_security_origin_get):
- ewk/ewk_frame.h:
- ewk/ewk_security_origin.cpp: Added.
(ewk_security_origin_protocol_get):
(ewk_security_origin_host_get):
(ewk_security_origin_port_get):
(ewk_security_origin_web_database_usage_get):
(ewk_security_origin_web_database_quota_get):
(ewk_security_origin_web_database_quota_set):
(ewk_security_origin_free):
(ewk_security_origin_new):
- ewk/ewk_security_origin.h: Added.
- 8:45 AM Changeset in webkit [114748] by
-
- 7 edits2 adds in trunk/Source/WebCore
Web Inspector: Does not have search navigation button for going through matches in either direction (prev, next)
https://bugs.webkit.org/show_bug.cgi?id=84235
Added buttons for navigating on seiarch matches in inspector panel
through button clicks as well.
Patch by Sam D <dsam2912@gmail.com> on 2012-04-20
Reviewed by Pavel Feldman.
No new tests / ux enhanced for search functionality
- English.lproj/localizedStrings.js:
- WebCore.gypi:
- inspector/front-end/Images/searchNext.png: Added.
- inspector/front-end/Images/searchPrev.png: Added.
- inspector/front-end/SearchController.js:
(WebInspector.SearchController):
(WebInspector.SearchController.prototype._updateSearchNavigationButtonState):
(WebInspector.SearchController.prototype._updateSearchMatchesCountAndCurrentMatchIndex):
(WebInspector.SearchController.prototype._onNextButtonSearch):
(WebInspector.SearchController.prototype._onPrevButtonSearch):
(WebInspector.SearchController.prototype._performSearch):
(WebInspector.SearchController.prototype._createSearchNavigationButton):
(WebInspector.SearchController.prototype._populateSearchNavigationButtons):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css:
(.toolbar-search-item):
(#search):
(#toolbar-search-navigation-control):
(.toolbar-search-navigation-label):
(.toolbar-search-navigation-label:hover):
(.toolbar-search-navigation-icon-prev , .toolbar-search-navigation-icon-next):
(.toolbar-search-navigation-icon-prev):
(.toolbar-search-navigation-icon-next):
- inspector/front-end/inspector.html:
- 8:38 AM Changeset in webkit [114747] by
-
- 2 edits in trunk/LayoutTests
2012-04-20 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Mark inspector/profiler/heap-snapshot-inspect-dom-wrapper.html
as slow in release mode.
- platform/chromium/test_expectations.txt:
- 8:22 AM BuildBot edited by
- Pulseaudio troubleshooting (diff)
- 8:17 AM Deprecating features and vendor prefixes edited by
- (diff)
- 7:54 AM Changeset in webkit [114746] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update
https://bugs.webkit.org/show_bug.cgi?id=73991
Unmark passing tests (Vista & Win7):
fast/text/international/complex-character-based-fallback.html
fast/text/international/danda-space.html
fast/text/international/thai-baht-space.html
fast/text/international/chromium-complex-text-non-printable.html
platform/win/fast/text/uniscribe-missing-glyph.html
fast/text/international/bidi-neutral-run.html
fast/text/international/thai-line-breaks.html
- platform/chromium/test_expectations.txt:
- 7:36 AM Changeset in webkit [114745] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-20
- DEPS:
- 6:33 AM Changeset in webkit [114744] by
-
- 10 edits3 adds in trunk
Web Inspector: extract NavigatorView and NavigatorOverlayController from ScriptsNavigator.
https://bugs.webkit.org/show_bug.cgi?id=84441
Reviewed by Yury Semikhatsky.
Source/WebCore:
- Moves NavigatorOverlayController out of ScriptsNavigator
- Extracts NavigatorView from ScriptsNavigator and makes ScriptsNavigator contain 3 NavigatorView instances (one per tab)
- Subclasses SnippetsNavigatorView and leaves it within ScriptsNavigator.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/NavigatorOverlayController.js: Added.
(WebInspector.NavigatorOverlayController.prototype.wasShown):
(WebInspector.NavigatorOverlayController.prototype._createNavigatorControlButton):
(WebInspector.NavigatorOverlayController.prototype._escDownWhileNavigatorOverlayOpen):
(WebInspector.NavigatorOverlayController.prototype._toggleNavigator):
(WebInspector.NavigatorOverlayController.prototype._hidePinnedNavigator):
(WebInspector.NavigatorOverlayController.prototype.set _pinNavigator):
(WebInspector.NavigatorOverlayController.prototype.set showNavigatorOverlay):
(WebInspector.NavigatorOverlayController.prototype.hideNavigatorOverlay):
(WebInspector.NavigatorOverlayController.prototype._navigatorOverlayWasShown):
- inspector/front-end/NavigatorView.js: Added.
(WebInspector.NavigatorView):
(WebInspector.NavigatorView.prototype._updateScriptTitle.get if):
(WebInspector.NavigatorView.prototype._updateScriptTitle):
(WebInspector.NavigatorView.prototype._scriptSelected):
(WebInspector.NavigatorView.prototype._removeUISourceCode.get while):
(WebInspector.NavigatorView.prototype._removeUISourceCode):
(WebInspector.NavigatorView.prototype._showScriptFoldersSettingChanged):
(WebInspector.NavigatorView.prototype._fileRenamed):
(WebInspector.NavigatorView.prototype.rename.commitHandler):
(WebInspector.NavigatorView.prototype.rename.cancelHandler):
(WebInspector.NavigatorView.prototype.rename.afterEditing):
(WebInspector.NavigatorView.prototype.reset):
(WebInspector.NavigatorView.prototype.createFolderTreeElement):
(WebInspector.NavigatorView.prototype.getOrCreateFolderTreeElement):
(WebInspector.NavigatorView.prototype.handleContextMenu):
(WebInspector.NavigatorTreeOutline):
(WebInspector.NavigatorTreeOutline._treeElementsCompare.compare.typeWeight):
(WebInspector.NavigatorTreeOutline._treeElementsCompare):
(WebInspector.NavigatorTreeOutline.prototype.scriptTreeElements):
(WebInspector.NavigatorTreeOutline.prototype.searchStarted):
(WebInspector.NavigatorTreeOutline.prototype.searchFinished):
(WebInspector.BaseNavigatorTreeElement):
(WebInspector.BaseNavigatorTreeElement.prototype.onattach):
(WebInspector.BaseNavigatorTreeElement.prototype.onreveal):
(WebInspector.BaseNavigatorTreeElement.prototype.get titleText):
(WebInspector.BaseNavigatorTreeElement.prototype.set titleText):
(WebInspector.BaseNavigatorTreeElement.prototype.matchesSearchText):
(WebInspector.NavigatorFolderTreeElement):
(WebInspector.NavigatorFolderTreeElement.prototype.get folderIdentifier):
(WebInspector.NavigatorFolderTreeElement.prototype.get isDomain):
(WebInspector.NavigatorFolderTreeElement.prototype.onattach):
(WebInspector.NavigatorScriptTreeElement):
(WebInspector.NavigatorScriptTreeElement.prototype.get uiSourceCode):
(WebInspector.NavigatorScriptTreeElement.prototype.onattach):
(WebInspector.NavigatorScriptTreeElement.prototype.onspace):
(WebInspector.NavigatorScriptTreeElement.prototype._onclick):
(WebInspector.NavigatorScriptTreeElement.prototype.onenter):
(WebInspector.NavigatorScriptTreeElement.prototype._handleContextMenuEvent):
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator):
(WebInspector.ScriptsNavigator.prototype.addUISourceCode):
(WebInspector.ScriptsNavigator.prototype.isScriptSourceAdded):
(WebInspector.ScriptsNavigator.prototype.revealUISourceCode):
(WebInspector.ScriptsNavigator.prototype.replaceUISourceCodes):
(WebInspector.ScriptsNavigator.prototype._scriptSelected):
(WebInspector.ScriptsNavigator.prototype.reset):
(WebInspector.SnippetsNavigatorView):
(WebInspector.SnippetsNavigatorView.prototype.getOrCreateFolderTreeElement):
(WebInspector.SnippetsNavigatorView.prototype._getOrCreateSnippetEvaluationsFolderTreeElement):
(WebInspector.SnippetsNavigatorView.prototype.handleContextMenu):
(WebInspector.SnippetsNavigatorView.prototype._fileRenamed):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/navigatorView.css: Added.
(.navigator-domain-tree-item .icon):
(.navigator-folder-tree-item .icon):
(.navigator-script-tree-item .icon):
(.navigator li):
(.navigator :focus li.selected):
(.navigator li.selected .selection):
(.navigator :focus li.selected .selection):
(.navigator .search-match-found li.selected .selection):
(.navigator .search-match-not-found li.selected .selection):
(.navigator .searching li.selected .selection):
(.navigator .icon):
(.navigator .base-navigator-tree-element-title):
(.navigator .base-navigator-tree-element-title.editing):
(.navigator-tree-search-box):
(.navigator-tree-search-box.visible):
(.navigator-tree-search-box > input):
- inspector/front-end/scriptsPanel.css:
LayoutTests:
- http/tests/inspector/debugger-test.js:
- 5:59 AM Changeset in webkit [114743] by
-
- 56 edits3 deletes in trunk/LayoutTests
[Chromium] Unreviewed test results update
http://code.google.com/p/chromium/issues/detail?id=123809
Rebaseline tests after Skia roll. There was a comment saying
"Rebaseline after Skia rev. 3695 lands", while Skia is
already at r3729.
- platform/chromium-linux-x86/svg/hixie/perf/001-expected.png:
- platform/chromium-linux-x86/svg/hixie/perf/002-expected.png:
- platform/chromium-linux/fast/backgrounds/background-leakage-expected.png:
- platform/chromium-linux/fast/backgrounds/background-leakage-transforms-expected.png:
- platform/chromium-linux/fast/borders/border-radius-complex-inner-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusDouble01-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusDouble05-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusGroove02-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusRidge01-expected.png:
- platform/chromium-linux/fast/repaint/shadow-multiple-vertical-expected.png:
- platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
- platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
- platform/chromium-linux/svg/hixie/perf/001-expected.png:
- platform/chromium-linux/svg/hixie/perf/002-expected.png:
- platform/chromium-mac-leopard/fast/repaint/shadow-multiple-vertical-expected.png:
- platform/chromium-mac-leopard/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
- platform/chromium-mac-leopard/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
- platform/chromium-mac-leopard/svg/hixie/perf/001-expected.png:
- platform/chromium-mac-leopard/svg/hixie/perf/002-expected.png:
- platform/chromium-mac-snowleopard/fast/backgrounds/background-leakage-transforms-expected.png:
- platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-vertical-expected.png:
- platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
- platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
- platform/chromium-mac-snowleopard/svg/hixie/perf/001-expected.png:
- platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.png:
- platform/chromium-mac/fast/backgrounds/background-leakage-expected.png:
- platform/chromium-mac/fast/backgrounds/background-leakage-transforms-expected.png:
- platform/chromium-mac/fast/borders/border-radius-complex-inner-expected.png:
- platform/chromium-mac/fast/borders/border-styles-split-expected.png:
- platform/chromium-mac/fast/borders/borderRadiusDouble01-expected.png:
- platform/chromium-mac/fast/borders/borderRadiusDouble02-expected.png:
- platform/chromium-mac/fast/borders/borderRadiusGroove02-expected.png:
- platform/chromium-mac/fast/borders/borderRadiusRidge01-expected.png:
- platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png:
- platform/chromium-mac/fast/writing-mode/border-styles-vertical-lr-expected.png:
- platform/chromium-mac/fast/writing-mode/border-styles-vertical-rl-expected.png:
- platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
- platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.txt: Removed.
- platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
- platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt: Removed.
- platform/chromium-mac/svg/hixie/perf/001-expected.png:
- platform/chromium-mac/svg/hixie/perf/002-expected.png:
- platform/chromium-win/fast/backgrounds/background-leakage-expected.png:
- platform/chromium-win/fast/backgrounds/background-leakage-transforms-expected.png:
- platform/chromium-win/fast/borders/border-radius-complex-inner-expected.png:
- platform/chromium-win/fast/borders/border-radius-groove-02-expected.png:
- platform/chromium-win/fast/borders/border-styles-split-expected.png:
- platform/chromium-win/fast/borders/borderRadiusDouble01-expected.png:
- platform/chromium-win/fast/borders/borderRadiusDouble02-expected.png:
- platform/chromium-win/fast/borders/borderRadiusGroove02-expected.png:
- platform/chromium-win/fast/borders/borderRadiusRidge01-expected.png:
- platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
- platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
- platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
- platform/chromium-win/svg/hixie/perf/001-expected.png:
- platform/chromium-win/svg/hixie/perf/002-expected.png:
- platform/chromium/test_expectations.txt:
- platform/efl/fast/borders/border-radius-complex-inner-expected.txt: Removed.
- 5:30 AM Changeset in webkit [114742] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=29359
Unmark passing fast/forms/date/date-appearance.html
- platform/chromium/test_expectations.txt:
- 5:07 AM Changeset in webkit [114741] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=83826
Remove now passing test from expectations:
fast/text/drawBidiText.html
fast/text/international/bidi-listbox-atsui.html
- platform/chromium/test_expectations.txt:
- 4:58 AM Changeset in webkit [114740] by
-
- 14 edits in trunk/Source/WebCore
Web Inspector: make ScriptNavigatorController use views only, rename to NavigatorOverlayController.
https://bugs.webkit.org/show_bug.cgi?id=84352
Reviewed by Vsevolod Vlasov.
This change makes navigator controller use view interfaces only. Focus machinery has been refactored in order
to make it possible: now all view ancestors can either override "focus" or "defaultFocusedElement" method
with latter method being preferred.
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.defaultFocusedElement):
- inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionPanel.prototype.defaultFocusedElement):
- inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.wasShown):
(WebInspector.Panel.prototype.defaultFocusedElement):
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator):
(WebInspector.NavigatorOverlayController.prototype._hidePinnedNavigator):
(WebInspector.NavigatorOverlayController.prototype.set _pinNavigator):
(WebInspector.NavigatorOverlayController.prototype.set showNavigatorOverlay):
(WebInspector.NavigatorOverlayController.prototype.hideNavigatorOverlay):
(WebInspector.NavigatorOverlayController.prototype._navigatorOverlayWasShown):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.defaultFocusedElement):
- inspector/front-end/SidebarOverlay.js:
(WebInspector.SidebarOverlay.prototype.show):
(WebInspector.SidebarOverlay.prototype.hide):
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.defaultFocusedElement):
- inspector/front-end/StylesPanel.js:
(WebInspector.StylesPanel):
- inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype.get view):
(WebInspector.TabbedEditorContainer.prototype.get visibleView):
- inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane):
(WebInspector.TabbedPane.prototype.defaultFocusedElement):
- inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype.defaultFocusedElement):
(WebInspector.TextEditorMainPanel.prototype.defaultFocusedElement):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype.defaultFocusedElement):
- inspector/front-end/View.js:
(WebInspector.View.prototype._collectViewHierarchy):
(WebInspector.View.prototype.defaultFocusedElement):
(WebInspector.View.prototype.setDefaultFocusedElement):
(WebInspector.View.prototype.focus):
- 4:57 AM Changeset in webkit [114739] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
http://code.google.com/p/chromium/issues/detail?id=124313
Mark fast/css/font-face-opentype.html and fast/css/font-face-woff.html
as crashing on Debug XP.
- platform/chromium/test_expectations.txt:
- 4:48 AM Changeset in webkit [114738] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84432
Mark several fast/filesystem tests as failing on Windows.
- platform/chromium/test_expectations.txt:
- 3:56 AM Changeset in webkit [114737] by
-
- 4 edits in trunk
[EFL] [DRT] Send double click event from EventSender
https://bugs.webkit.org/show_bug.cgi?id=82867
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-20
Reviewed by Daniel Bates.
Tools:
Add support for EFL DumpRenderTree EventSender to send
double click events.
- DumpRenderTree/efl/EventSender.cpp:
(sendMouseEvent):
LayoutTests:
Unskip tests connected with double click simulation.
- platform/efl/Skipped:
- 3:54 AM Changeset in webkit [114736] by
-
- 8 edits in trunk
[GTK] Enable Web Timing
https://bugs.webkit.org/show_bug.cgi?id=42432
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Added WebTiming support to the GTK+ port. WebTiming allows
developers to collect detailed network timing information per
resource. It requires the new SoupMessage's "network-event"
signal.
- GNUmakefile.am:
- bindings/gobject/GNUmakefile.am:
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore):
(WebCore::restartedCallback):
(WebCore::sendRequestCallback):
(WebCore::milisecondsSinceRequest):
(WebCore::wroteBodyCallback):
(WebCore::requestStartedCallback):
(WebCore::networkEventCallback):
(WebCore::startHTTPRequest):
(WebCore::ResourceHandle::platformSetDefersLoading):
(WebCore::ResourceHandle::defaultSession):
Tools:
Build web timing by default whenever build-webkit is used.
- Scripts/build-webkit:
LayoutTests:
Removed some tests that are working fine now after adding Web
Timing support.
- platform/gtk/test_expectations.txt:
- 3:28 AM Changeset in webkit [114735] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84427
Mark platform/chromium/editing/spelling/delete-misspelled-word.html as
PASS/TIMEOUT on Mac and Win debug.
- platform/chromium/test_expectations.txt:
- 3:02 AM Changeset in webkit [114734] by
-
- 6 edits in trunk
Not reviewed: fixed chromium sanity tests for inspector via assigning last path component
to entire url for parsed urls with invalid specs.
Source/WebCore:
- inspector/front-end/ResourceUtils.js:
(WebInspector.ParsedURL):
Source/WebKit/chromium:
- src/js/Tests.js:
(.TestSuite.prototype._scriptsAreParsed):
LayoutTests:
- http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
- 2:44 AM Changeset in webkit [114733] by
-
- 2 edits in trunk/Tools
[EFL] Add missing reset for setAuthorAndUserStylesEnabled inside DRT.
https://bugs.webkit.org/show_bug.cgi?id=84430
Patch by Kamil Blank <k.blank@samsung.com> on 2012-04-20
Reviewed by Daniel Bates.
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
- 2:30 AM Changeset in webkit [114732] by
-
- 51 edits in trunk/Source/WebCore
Unreviewed, rolling out r114401.
http://trac.webkit.org/changeset/114401
https://bugs.webkit.org/show_bug.cgi?id=84161
Chromium crash
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(NativeToJSValue):
- bindings/scripts/test/V8/V8Float64Array.h:
(WebCore):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestEventConstructor.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestEventTarget.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestInterface.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestNamedConstructor.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestNode.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestObj.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(WebCore::toV8):
- bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8CSSRuleCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8CSSStyleSheetCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8CSSValueCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8CanvasPixelArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8DOMTokenListCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8EntryCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8EntrySyncCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8EventCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Float32ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Float64ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8IDBAnyCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8IDBKeyCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8ImageDataCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Int16ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Int32ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Int8ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8NamedNodeMapCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):
- bindings/v8/custom/V8SVGDocumentCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8SVGElementCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8SVGPathSegCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8ScriptProfileCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8StyleSheetCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Uint16ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Uint32ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Uint8ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::toV8):
- 2:29 AM Changeset in webkit [114731] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r114440.
http://trac.webkit.org/changeset/114440
https://bugs.webkit.org/show_bug.cgi?id=84173
Chromium crash
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
- bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):
- 2:28 AM Changeset in webkit [114730] by
-
- 18 edits in trunk/Source/WebCore
Unreviewed, rolling out r114519.
http://trac.webkit.org/changeset/114519
https://bugs.webkit.org/show_bug.cgi?id=84202
Chromium crash
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
- bindings/scripts/test/V8/V8Float64Array.h:
(V8Float64Array):
(WebCore::V8Float64Array::wrap):
(WebCore):
- bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
(WebCore::V8TestActiveDOMObject::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
(WebCore::V8TestCustomNamedGetter::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
(WebCore::V8TestEventConstructor::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
(WebCore::V8TestEventTarget::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
(WebCore::V8TestInterface::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
(WebCore::V8TestMediaQueryListListener::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
(WebCore::V8TestNamedConstructor::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestNode.h:
(V8TestNode):
(WebCore::V8TestNode::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
(WebCore::V8TestObj::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
(WebCore::V8TestSerializedScriptValueInterface::wrap):
(WebCore::toV8):
- bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):
- bindings/v8/custom/V8SVGDocumentCustom.cpp:
(WebCore::toV8):
- dom/make_names.pl:
(printWrapperFactoryCppFile):
- 2:15 AM Changeset in webkit [114729] by
-
- 13 edits in trunk/Source/WebCore
Web Inspector: replace @type annotation with @return annotation for getters
https://bugs.webkit.org/show_bug.cgi?id=84362
Reviewed by Yury Semikhatsky.
Otherwise, compiler does not check for errors.
- inspector/front-end/AdvancedSearchController.js:
(WebInspector.SearchView.prototype.get searchConfig):
- inspector/front-end/BreakpointManager.js:
- inspector/front-end/NetworkRequest.js:
(WebInspector.NetworkRequest.prototype.requestContent):
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeFrame):
(WebInspector.ResourceTreeFrame.prototype._navigate):
- inspector/front-end/ScriptsNavigator.js:
- inspector/front-end/Settings.js:
- inspector/front-end/SnippetsModel.js:
- inspector/front-end/SplitView.js:
- inspector/front-end/TabbedEditorContainer.js:
- inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPaneTab):
- inspector/front-end/TextEditorModel.js:
- inspector/front-end/TimelinePresentationModel.js:
- 1:49 AM Changeset in webkit [114728] by
-
- 5 edits in trunk/Source
[Chromium] Call cacheMetadata directly
https://bugs.webkit.org/show_bug.cgi?id=84415
Reviewed by Kentaro Hara.
Part of a refactoring series. See tracking bug 82948.
Source/WebCore:
- platform/chromium/PlatformSupport.h:
(PlatformSupport):
- platform/network/chromium/ResourceHandle.cpp:
(WebCore::ResourceHandle::cacheMetadata):
Source/WebKit/chromium:
- src/PlatformSupport.cpp:
(WebCore):
- 1:41 AM Changeset in webkit [114727] by
-
- 5 edits in trunk/Source
[Chromium] Call stopSharedTimer directly
https://bugs.webkit.org/show_bug.cgi?id=84418
Reviewed by Kentaro Hara.
Part of a refactoring series. See tracking bug 82948.
Source/WebCore:
- platform/chromium/PlatformSupport.h:
(PlatformSupport):
- platform/chromium/SharedTimerChromium.cpp:
(WebCore::stopSharedTimer):
Source/WebKit/chromium:
- src/PlatformSupport.cpp:
(WebCore):
- 12:50 AM Changeset in webkit [114726] by
-
- 1 edit4 deletes in trunk/LayoutTests
[Chromium] Unreviewed test results update.
Remove unneeded test results.
- platform/chromium-win-xp/fast/ruby/floating-ruby-text-expected.txt: Removed.
- platform/chromium-win-xp/fast/ruby/positioned-ruby-text-expected.txt: Removed.
- platform/chromium/fast/ruby/floating-ruby-text-expected.txt: Removed.
- platform/chromium/fast/ruby/positioned-ruby-text-expected.txt: Removed.
- 12:42 AM Changeset in webkit [114725] by
-
- 2 edits in trunk/Tools
REGRESSION(r112781): Windows build slaves are no longer including .pdb files in archives handed to testers
https://bugs.webkit.org/show_bug.cgi?id=84424
Reviewed by Mark Rowe.
Let Windows and Chromium have their own list of files to copy.
- BuildSlaveSupport/built-product-archive:
(removeDirectoryIfExists):
(copyBuildFiles):
(archiveBuiltProduct):
- 12:40 AM Changeset in webkit [114724] by
-
- 3 edits2 adds in trunk
DOMFileSystem::scheduleCallback() crashes on file() call after reload.
https://bugs.webkit.org/show_bug.cgi?id=76461
DOMFileSystem::scheduleCallback() is unavailable when the page in unloading, so we should
avoid using it in callback.
Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-04-20
Reviewed by David Levin.
Source/WebCore:
Test: fast/filesystem/file-after-reload-crash.html
- Modules/filesystem/DOMFileSystem.cpp:
(WebCore):
LayoutTests:
- fast/filesystem/file-after-reload-crash-expected.txt: Added.
- fast/filesystem/file-after-reload-crash.html: Added.
- 12:37 AM April 2012 Meeting edited by
- (diff)
- 12:33 AM Changeset in webkit [114723] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84427
Mark platform/chromium/editing/spelling/delete-misspelled-word.html as
timing out on Linux debug.
- platform/chromium/test_expectations.txt:
- 12:27 AM Changeset in webkit [114722] by
-
- 7 edits1 add in trunk
[EFL] Add setting API for author and user styles.
https://bugs.webkit.org/show_bug.cgi?id=82860
Patch by Kamil Blank <k.blank@samsung.com> on 2012-04-20
Reviewed by Daniel Bates.
Source/WebKit/efl:
Add missing implementation setAuthorAndUserStylesEnabled to EFL's
DumpRenderTreeSupport.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
Tools:
Implementation of setAuthorAndUserStylesEnabled.
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setAuthorAndUserStylesEnabled):
LayoutTests:
Enable test connected with setAuthorAndUserStylesEnabled.
- platform/efl/Skipped:
- platform/efl/fast/css/disabled-author-styles-expected.txt: Added.
