Timeline


and

05/08/12:

23:59 TraversingShadowDOMTree edited by hayato@chromium.org
(diff)
23:16 Changeset [116497] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

NavigatorRegisterProtocolHandler can call ChromeClient directly.
https://bugs.webkit.org/show_bug.cgi?id=85944

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-05-08
Reviewed by Adam Barth.

Covered by fast/dom/register-protocol-handler.html

  • page/Chrome.cpp: Remove registerProtocolHandler function.
  • page/Chrome.h: Remove registerProtocolHandler prototype.

(Chrome):

  • page/NavigatorRegisterProtocolHandler.cpp: Call ChromeClient::registerProtocolHandler directly.

(WebCore::NavigatorRegisterProtocolHandler::registerProtocolHandler):

23:14 Changeset [116496] by mario@webkit.org
  • 2 edits in trunk/Source/WebCore

Coding style issues present in RenderFrameSet.cpp
https://bugs.webkit.org/show_bug.cgi?id=85955

Reviewed by Eric Seidel.

Just fixed those coding style issues.

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::GridAxis::resize):
(WebCore::RenderFrameSet::layOutAxis):
(WebCore::RenderFrameSet::continueResizing):

22:52 Changeset [116495] by jochen@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
21:45 Changeset [116494] by barraclough@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

ROLLING OUT r114255

GC in the middle of JSObject::allocatePropertyStorage can cause badness
https://bugs.webkit.org/show_bug.cgi?id=83839

Reviewed by nobody.

This breaks the world, with COLLECT_ON_EVERY_ALLOCATION enabled.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/JSObject.cpp:

(JSC::JSObject::allocatePropertyStorage):

  • runtime/JSObject.h:

(JSObject):
(JSC::JSObject::isUsingInlineStorage):
(JSC):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirectWithoutTransition):
(JSC::JSObject::transitionTo):

  • runtime/Structure.cpp:

(JSC):

  • runtime/Structure.h:

(JSC::Structure::didTransition):

21:43 TraversingShadowDOMTree edited by hayato@chromium.org
(diff)
21:33 Changeset [116493] by jonlee@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix.

  • platform/mac/WebCoreSystemInterface.h:
21:20 Changeset [116492] by jonlee@apple.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix.

  • WebProcess/WebPage/ca/win/LayerTreeHostCAWin.h:

(LayerTreeHostCAWin):

21:10 Changeset [116491] by tkent@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, a trivial test fix to remove a platform-dependency.
https://bugs.webkit.org/show_bug.cgi?id=81854

  • fast/forms/form-collection-radio-node-list-expected.txt:
  • fast/forms/form-collection-radio-node-list.html:

Remove form controls from the document before completing the test.

20:49 Changeset [116490] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update
Skip post-in-iframe-with-back-navigation.html because it might cause a
failure of the next test, preload-append-scan.php

  • platform/chromium/test_expectations.txt:
20:39 Changeset [116489] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update test expectations.

  • platform/chromium/test_expectations.txt:
20:35 Changeset [116488] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

[BlackBerry] Auth credentials set in private mode are reused in public mode.
https://bugs.webkit.org/show_bug.cgi?id=84697

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-05-08
Reviewed by Rob Buis.

Add setPrivateMode function for CredentialStorage.

Source/WebCore:

Now, we only save credentials in memory and CredentialBackingStore isn't enabled.
When we set private mode from on to off, we clear all these temporary credentials.

We have to change Private Browsing to test, so have to write a manual test case.
Test: ManualTests/blackberry/http-auth-private-mode-changed.html

  • network/CredentialStorage.cpp:

(WebCore::CredentialStorage::setPrivateMode):
(WebCore):

  • platform/network/CredentialStorage.h:

(CredentialStorage):

Source/WebKit/blackberry:

We have to change Private Browsing to test, so have to write a manual test case.
Test: ManualTests/blackberry/http-auth-private-mode-changed.html

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):

20:23 Changeset [116487] by commit-queue@webkit.org
  • 20 edits
    5 adds in trunk

RadioNodeList support in HTMLFormElement::elements
https://bugs.webkit.org/show_bug.cgi?id=81854

Patch by Rakesh KN <rakesh.kn@motorola.com> on 2012-05-08
Reviewed by Ryosuke Niwa.

Source/WebCore:

Implement RadioNodeList support spec'ed at
http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-interfaces.html#radionodelist

Test: fast/forms/form-collection-radio-node-list.html

  • CMakeLists.txt:

Added entries for new files.

  • DerivedSources.cpp: Ditto.
  • DerivedSources.make: Ditto.
  • DerivedSources.pri: Ditto.
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::getNamedItems):
Modified to create RadioNodeList object when FormControlCollection has more than
one element of same name/id.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
Added code to include Node.h and JSNode.h in JSRadioNodeElement.cpp.

  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:

(WebCore::getNamedItems):
Modified to create RadioNodeList object when FormControlCollection has more than
one element of same name/id.

  • dom/Node.cpp:

(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanged):
Invalidate lists even for change in id, type, checked attributes.
(WebCore::NodeListsNodeData::invalidateCachesThatDependOnAttributes):
Invalidate radioNodeList cache.
(WebCore::NodeListsNodeData::isEmpty):
Changes for radioNodeList.
(WebCore::Node::radioNodeList):
Creates if needed a RadioNodeList and adds it to the cache.
(WebCore::Node::removeCachedRadioNodeList):
Removes a cached radioNodeList.

  • dom/Node.h: Ditto
  • dom/NodeRareData.h:

(WebCore):
(NodeListsNodeData):
Added radioNodeList list.

  • html/CollectionType.h:

Added new FormControls type.

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::shouldIncludeChildren):
(WebCore::HTMLCollection::isAcceptableElement):
Handle FormControls collection type.

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::HTMLFormCollection):
Contruct collection of FormControls type.

  • html/RadioNodeList.cpp: Added.

(WebCore):
(WebCore::RadioNodeList::RadioNodeList):
(WebCore::RadioNodeList::~RadioNodeList):
(WebCore::toRadioButtonInputElement):
(WebCore::RadioNodeList::value):
(WebCore::RadioNodeList::setValue):
(WebCore::RadioNodeList::nodeMatches):

  • html/RadioNodeList.h: Added.

(WebCore):
(RadioNodeList):
(WebCore::RadioNodeList::create):
RadioNodeList implementation.

  • html/RadioNodeList.idl: Added.

Idl for generating RadioNodeList JS/V8 bindings.

LayoutTests:

  • fast/forms/form-collection-radio-node-list-expected.txt: Added.
  • fast/forms/form-collection-radio-node-list.html: Added.
20:20 Changeset [116486] by benjamin@webkit.org
  • 3 edits
    6 adds in trunk

[JSC] Regression: addEventListener() and removeEventListener() raise an exception on missing args
https://bugs.webkit.org/show_bug.cgi?id=85928

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-05-08
Reviewed by Geoffrey Garen.

Source/WebCore:

The functions addEventListener() and removeEventListener() raise an exception if there are missin arguments.
This behavior breaks existing content.

This patch change the code generator of JavaScript core to have an exception for addEventListener() and removeEventListener().
For those function, we do not raise an exception on missin argument.

This patch does not modify the V8 code generator because such exceptions are already in place there.

Tests: fast/dom/Window/window-legacy-event-listener.html

fast/dom/XMLHttpRequest-legacy-event-listener.html
fast/dom/node-legacy-event-listener.html

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

LayoutTests:

  • fast/dom/Window/window-legacy-event-listener-expected.txt: Added.
  • fast/dom/Window/window-legacy-event-listener.html: Added.
  • fast/dom/XMLHttpRequest-legacy-event-listener-expected.txt: Added.
  • fast/dom/XMLHttpRequest-legacy-event-listener.html: Added.
  • fast/dom/node-legacy-event-listener-expected.txt: Added.
  • fast/dom/node-legacy-event-listener.html: Added.
19:48 Changeset [116485] by crogers@google.com
  • 14 edits in trunk/Source/WebCore

AudioParam should directly be given context in create() method
https://bugs.webkit.org/show_bug.cgi?id=85905

Reviewed by James Robinson.

No new tests. This is a low-level re-factoring and is covered by existing tests.

  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):

  • Modules/webaudio/AudioGain.h:

(WebCore::AudioGain::create):
(WebCore::AudioGain::AudioGain):

  • Modules/webaudio/AudioGainNode.cpp:

(WebCore::AudioGainNode::AudioGainNode):

  • Modules/webaudio/AudioPannerNode.cpp:

(WebCore::AudioPannerNode::AudioPannerNode):

  • Modules/webaudio/AudioParam.h:

(WebCore::AudioParam::create):
(AudioParam):
(WebCore::AudioParam::AudioParam):

  • Modules/webaudio/BiquadFilterNode.cpp:

(WebCore::BiquadFilterNode::BiquadFilterNode):

  • Modules/webaudio/BiquadProcessor.cpp:

(WebCore::BiquadProcessor::BiquadProcessor):

  • Modules/webaudio/BiquadProcessor.h:
  • Modules/webaudio/DelayNode.cpp:

(WebCore::DelayNode::DelayNode):

  • Modules/webaudio/DelayProcessor.cpp:

(WebCore::DelayProcessor::DelayProcessor):

  • Modules/webaudio/DelayProcessor.h:

(DelayProcessor):

  • Modules/webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):

  • Modules/webaudio/Oscillator.cpp:

(WebCore::Oscillator::Oscillator):

19:44 Changeset [116484] by mhahnenberg@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Heap should not continually allocate new pages in steady state
https://bugs.webkit.org/show_bug.cgi?id=85936

Reviewed by Geoff Garen.

Currently, in steady state (i.e. a constant amount of live GC
memory with a constant rate of allocation) assuming we've just
finished a collection with X live blocks in CopiedSpace, we
increase our working set by X blocks in CopiedSpace with each
collection we perform. This is due to the fact that we allocate
until we run out of free blocks to use in the Heap before we
consider whether we should run a collection.

In the longer term, this issue will be mostly resolved by
implementing quick release for the CopiedSpace. In the shorter
term, we should change our policy to check whether we should
allocate before trying to use a free block from the Heap. We
can change our policy to something more appropriate once we
have implemented quick release.

This change should also have the convenient side effect of
reducing the variance in GC-heavy tests (e.g. v8-splay) due
to fact that we are doing less VM allocation during copying
collection. Overall, this patch is performance neutral across
the benchmarks we track.

  • heap/CopiedSpace.cpp:

(JSC::CopiedSpace::getFreshBlock): Shuffle the request from the BlockAllocator
around so that we only do it if the block request must succeed
i.e. after we've already checked whether we should do a collection.

  • heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::allocateSlowCase): Ditto.
(JSC::MarkedAllocator::allocateBlock): We no longer have a failure mode in this
function because by the time we've called it, we've already checked whether we
should run a collection so there's no point in returning null.

  • heap/MarkedAllocator.h: Removing old arguments from function declaration.

(MarkedAllocator):

19:37 Changeset [116483] by ojan@chromium.org
  • 5 edits in trunk/Tools

Show the chromium non-layout test bots in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=85903

Reviewed by Eric Seidel.

This is just a single-line high-level overview of the chromium non-layout test bots.
This means that Chromium WebKit gardeners only need to keep garden-o-matic open in
order to do their job.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:

(#chromium-gtests iframe):
(#chromium-gtests):
(#gtest-label):

19:34 Changeset [116482] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening, unskip test after r116475.

  • platform/efl/test_expectations.txt:
19:26 Changeset [116481] by danakj@chromium.org
  • 8 edits in trunk/Source

[chromium] Show borders for partial-draw-culled quads to visualize culling behaviour
https://bugs.webkit.org/show_bug.cgi?id=85414

Reviewed by Adrienne Walker.

Source/WebCore:

The borders are brown, and are only shown when the quad's visible rect
is non-empty and is different from the quad's original rect.

Adds a flag to CCQuadCuller constructor, to enable showing debug borders
around what it leaves after culling (when it culls anything in a quad
at all).

  • platform/graphics/chromium/cc/CCDrawQuad.h:

(WebCore::CCDrawQuad::isDebugQuad):
(WebCore::CCDrawQuad::sharedQuadState):
(CCDrawQuad):

  • platform/graphics/chromium/cc/CCQuadCuller.cpp:

(WebCore):
(WebCore::CCQuadCuller::CCQuadCuller):
(WebCore::appendQuadInternal):
(WebCore::CCQuadCuller::append):
(WebCore::CCQuadCuller::appendSurface):
(WebCore::CCQuadCuller::appendReplica):

  • platform/graphics/chromium/cc/CCQuadCuller.h:

(CCQuadCuller):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::appendQuadsForLayer):
(WebCore::CCRenderPass::appendQuadsForRenderSurfaceLayer):

Source/WebKit/chromium:

  • tests/CCQuadCullerTest.cpp:

(WebCore::appendQuads):

  • tests/MockCCQuadCuller.h:

(WebCore::MockCCQuadCuller::MockCCQuadCuller):

19:18 Changeset [116480] by jchaffraix@webkit.org
  • 4 edits in trunk/Source/WebCore

Move RenderLayers z-index lists dirtying to post style change
https://bugs.webkit.org/show_bug.cgi?id=85437

Reviewed by Darin Adler.

No expected change in behavior.

This change moves the z-order lists to RenderLayer::styleChanged. As part of this
change, also added proper handling of stacking context transition. This enabled
us to tighten more of the dirtyZOrderLists / clearZOrderLists code.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::styleWillChange):
Removed this code, moved to updateStackingContextsAfterStyleChange.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
Only stacking contexts start with dirty z-order lists.

(WebCore::RenderLayer::dirtyZOrderLists):
Added an ASSERT.

(WebCore::RenderLayer::updateStackingContextsAfterStyleChange):
Refactored the code to handle the transition between stacking context status.

(WebCore::RenderLayer::styleChanged):
Added a call to updateStackingContextsAfterStyleChange.

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::isStackingContext):
Added a call to the next function.

(WebCore::RenderLayer::layerWithStyleIsStackingContext):
Factored the isStackingContext logic here so that we can reuse it inside
updateStackingContextsAfterStyleChange.

(WebCore::RenderLayer::clearZOrderLists):
Added an ASSERT.

19:11 Changeset [116479] by tkent@chromium.org
  • 2 edits in trunk/Source/WebKit/mac

Fixe Chromium build, and add a FIXME comment about a layering violation.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

19:03 Changeset [116478] by andersca@apple.com
  • 9 edits in trunk/Source/WebKit2

DrawingAreaProxyImpl doesn't work with window server hosting
https://bugs.webkit.org/show_bug.cgi?id=85947
<rdar://problem/11213718>

Reviewed by Andreas Kling.

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::updateAcceleratedCompositingMode):
Update the layer tree context and call WebPage::updateAcceleratedCompositingMode.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::setLayerHostingMode):
If setting the layer hosting mode changed the layer tree context, send back an UpdateAcceleratedCompositingMode message
with the new context.

  • WebProcess/WebPage/ca/LayerTreeHostCA.cpp:

(WebKit::LayerTreeHostCA::initialize):
platformInitialize no longer takes a context.

  • WebProcess/WebPage/ca/LayerTreeHostCA.h:

(LayerTreeHostCA):
Make m_layerTreeContext protected instead.

  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h:
  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:

(WebKit::LayerTreeHostCAMac::platformInitialize):
Assign to m_layerTreeContext directly.

(WebKit::LayerTreeHostCAMac::setLayerHostingMode):
Set m_layerTreeContext.contextID.

  • WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:

(WebKit::LayerTreeHostCAWin::platformInitialize):
Assign to m_layerTreeContext directly.

18:47 Changeset [116477] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Suppress failing test while the fix is being worked out.

  • platform/chromium/test_expectations.txt:
18:45 Changeset [116476] by inferno@chromium.org
  • 11 edits
    2 adds in trunk

Crash due to owning renderer not removed from custom scrollbar.
https://bugs.webkit.org/show_bug.cgi?id=80610

Reviewed by Eric Seidel.

Source/WebCore:

Test: scrollbars/scrollbar-owning-renderer-crash.html

Changed RenderScrollbar to keep pointer to owning node, instead of the
renderer. Renderer can get destroyed without informing the scrollbar, causing
crashes later. Remove code from r94107 since it is not needed anymore and saves
times when RenderBox is getting destroyed.

  • page/FrameView.cpp:

(WebCore::FrameView::createScrollbar): pass renderer's node.

  • page/FrameView.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::willBeDestroyed): no longer need this. came originally from r94107.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::createScrollbar): pass renderer's node.
(WebCore::RenderLayer::destroyScrollbar): no longer need to clear owning renderer.

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::createScrollbar): pass renderer's node.

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::createScrollbar): pass renderer's node.

  • rendering/RenderScrollbar.cpp:

(WebCore::RenderScrollbar::createCustomScrollbar): Store owner node instead of renderer.
(WebCore::RenderScrollbar::RenderScrollbar): Store owner node instead of renderer.
(WebCore::RenderScrollbar::owningRenderer): calculate owning renderer from owner node.

  • rendering/RenderScrollbar.h:

(RenderScrollbar):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::createScrollbar): pass renderer's node.

LayoutTests:

  • scrollbars/scrollbar-owning-renderer-crash-expected.txt: Added.
  • scrollbars/scrollbar-owning-renderer-crash.html: Added.
18:44 TraversingShadowDOMTree edited by hayato@chromium.org
(diff)
18:32 Changeset [116475] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

[EFL][DRT] Implement TextInputController.
https://bugs.webkit.org/show_bug.cgi?id=78559

Patch by Kangil Han <kangil.han@samsung.com> on 2012-05-08
Reviewed by Martin Robinson.

TextInputController has been created for an input emulation purpose in DRT.
However, not like other ports, EFL doesn't have it.
Therefore, this patch will enable EFL port to have an input emulation in DRT.

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::setComposition):
(DumpRenderTreeSupportEfl::hasComposition):
(DumpRenderTreeSupportEfl::compositionRange):
(DumpRenderTreeSupportEfl::confirmComposition):
(DumpRenderTreeSupportEfl::firstRectForCharacterRange):
(DumpRenderTreeSupportEfl::selectedRange):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

  • DumpRenderTree/efl/CMakeLists.txt:
  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::onWindowObjectCleared):

  • DumpRenderTree/efl/TextInputController.cpp: Added.

(setMarkedTextCallback):
(hasMarkedTextCallback):
(markedRangeCallback):
(insertTextCallback):
(unmarkTextCallback):
(firstRectForCharacterRangeCallback):
(selectedRangeCallback):
(makeTextInputController):

  • DumpRenderTree/efl/TextInputController.h: Added.

LayoutTests:

  • platform/efl/Skipped:
18:05 TraversingShadowDOMTree created by hayato@chromium.org
17:58 Changeset [116474] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] force ENABLE_REGISTER_PROTOCOL_HANDLER=1 in features.gypi
https://bugs.webkit.org/show_bug.cgi?id=85924

Reviewed by Adam Barth.

This has been enabled for a few months on Chromium trunk so remove the
ability to turn it off via a gyp flag. This simplifies features.gypi.

  • features.gypi:
17:57 Changeset [116473] by jonlee@apple.com
  • 16 edits
    7 adds in trunk

Safari warns that it needs to resend the form in an iFrame when going back
https://bugs.webkit.org/show_bug.cgi?id=82658
<rdar://problem/11292558>

Reviewed by Darin Adler.

Source/WebCore:

Test: http/tests/loading/post-in-iframe-with-back-navigation.html

  • WebCore.exp.in: Add _wkCFURLRequestAllowAllPostCaching.
  • platform/mac/WebCoreSystemInterface.h: Add wkCFURLRequestAllowAllPostCaching.
  • platform/mac/WebCoreSystemInterface.mm: Add wkCFURLRequestAllowAllPostCaching.
  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doUpdatePlatformRequest): Set the bit to cache all POST responses.

  • platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::doUpdatePlatformRequest): Set the bit to cache all POST responses.

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Add wkCFURLRequestAllowAllPostCaching.

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Add wkCFURLRequestAllowAllPostCaching.

WebKitLibraries:

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceSnowLeopard.a:

LayoutTests:

Add new test which navigates a series of pages in an iframe. Each navigation is a POST.
At the third page we click on a back link, and expect to see stale POST data.

  • http/tests/loading/post-in-iframe-with-back-navigation-expected.txt: Added.
  • http/tests/loading/post-in-iframe-with-back-navigation.html: Added.
  • http/tests/loading/resources/post-in-iframe-with-back-navigation-page-1.php: Added.
  • http/tests/loading/resources/post-in-iframe-with-back-navigation-page-2.php: Added.
  • http/tests/loading/resources/post-in-iframe-with-back-navigation-page-3.php: Added.
  • http/tests/resources/js-test-post.js: Added. Copied from fast/js/resources since it is

inaccessible to the test server.

  • http/tests/resources/js-test-pre.js: Added. Copied from fast/js/resources since it is

inaccessible to the test server.

17:54 Changeset [116472] by danakj@chromium.org
  • 8 edits in trunk/Source

[chromium] Reflections with masks should not occlude
https://bugs.webkit.org/show_bug.cgi?id=85927

Reviewed by James Robinson.

Source/WebCore:

When a surface does not have a mask, we make both it and its reflection
occlude the things below them. However, if the reflection has a mask
applied to it, then we should not consider it as occluding.

Adds replicaHasMask() to the render surface classes so we can test if
the mask is present.

Unit Tests: CCOcclusionTrackerTestReplicaWithMask

  • platform/graphics/chromium/RenderSurfaceChromium.cpp:

(WebCore::RenderSurfaceChromium::hasMask):
This is unusued right now, but will allow us to remove a FIXME from
CCOcclusionTracker::finishedTargetRenderSurface().
(WebCore):
(WebCore::RenderSurfaceChromium::replicaHasMask):

  • platform/graphics/chromium/RenderSurfaceChromium.h:

(RenderSurfaceChromium):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::leaveToTargetRenderSurface):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::hasMask):
This is unusued right now, but will allow us to remove a FIXME from
CCOcclusionTracker::finishedTargetRenderSurface().
(WebCore):
(WebCore::CCRenderSurface::replicaHasMask):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(CCRenderSurface):

Source/WebKit/chromium:

  • tests/CCOcclusionTrackerTest.cpp:

(WebKitTests::CCOcclusionTrackerTest::TearDown):
(WebKitTests::CCOcclusionTrackerTest::createMaskLayer):
(CCOcclusionTrackerTest):
(WebKitTests::CCOcclusionTrackerTest::setMask):
(CCOcclusionTrackerTestReplicaWithMask):
(WebKitTests::CCOcclusionTrackerTestReplicaWithMask::runMyTest):
(WebKitTests):

17:52 Changeset [116471] by eric@webkit.org
  • 7 edits in trunk

Add stylesheet inheritance support to IFRAME_SEAMLESS
https://bugs.webkit.org/show_bug.cgi?id=85914

Reviewed by Ojan Vafai.

Source/WebCore:

This work is already guarded by IFRAME_SEAMLESS, as
Document::shouldDisplaySeamlesslyWithParent always returns false
when IFRAME_SEAMLESS is off.

This makes the child document use all author stylesheets from all parent documents,
per the seamless spec:
http://www.whatwg.org/specs/web-apps/current-work/#attr-iframe-seamless

This support is slightly inefficient as every time a sheet is added
to a parent document, the child document must do a full style selector recalc.
Normally author sheet additions have a fast-path which avoids the full selector recalc,
but such is not possible in the seamless case as we're inserting the parents sheets
earlier in the child's cascade (instead of just appending them to the end of the list).

The test covers both the static inheritance as well as addition of a stylesheet
to the parent and testing that it caused a recalc of the child.

Covered by fast/frames/seamless/seamless-css-cascade.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::addStylesheetsFromSeamlessParents):
(WebCore):

  • css/StyleResolver.h:

(StyleResolver):

  • dom/Document.cpp:

(WebCore::Document::seamlessParentUpdatedStylesheets):
(WebCore):
(WebCore::Document::notifySeamlessChildDocumentsOfStylesheetUpdate):
(WebCore::Document::updateActiveStylesheets):

  • dom/Document.h:

(Document):

LayoutTests:

Update the results (for both static and dynamic inheritance)
now that this support is landed.

  • fast/frames/seamless/seamless-css-cascade-expected.txt:
17:42 Changeset [116470] by rakuco@webkit.org
  • 5 edits in trunk

[EFL] Pass a WTF::String directly from DRT to ewebkit when possible
https://bugs.webkit.org/show_bug.cgi?id=84634

Reviewed by Gustavo Noronha Silva.

Drop unnecessary const char* -> WTF::String conversions by
creating String objects directly in LayoutTestController out of
JSStringRef's and passing them to DumpRenderTreeSupportEfl.

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::setValueForUser):
(DumpRenderTreeSupportEfl::addUserStyleSheet):
(DumpRenderTreeSupportEfl::findString):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::queueLoad):
(LayoutTestController::setValueForUser):
(LayoutTestController::findString):
(LayoutTestController::addUserStyleSheet):

17:41 WikiStart edited by hayato@chromium.org
(diff)
17:40 WikiStart edited by hayato@chromium.org
(diff)
17:24 Changeset [116469] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Can't scroll PDF in subframe
https://bugs.webkit.org/show_bug.cgi?id=85932
<rdar://problem/11405527>

Reviewed by Sam Weinig.

  • WebProcess/Plugins/PDF/BuiltInPDFView.h:
  • WebProcess/Plugins/PDF/BuiltInPDFView.mm:

(WebKit::BuiltInPDFView::updateScrollbars):
Trigger a layout when scrollbars come and go so the non fast scrollable region gets recomputed.

(WebKit::BuiltInPDFView::scrollableAreaBoundingBox):
Implement this by calling out to the PluginView.

17:02 Changeset [116468] by rakuco@webkit.org
  • 4 edits in trunk

[CMake] FindGStreamer: Fix the build with static WebCore.
https://bugs.webkit.org/show_bug.cgi?id=85930

Reviewed by Daniel Bates.

.:

Building WebCore statically was failing because files in
WebCore/platform/gstreamer when ENABLE_VIDEO was set required
gstreamer-base, which was not being linked to after r116453.

Fix that by looking for gstreamer-base, requiring and linking
against it if GStreamer is used.

  • Source/cmake/FindGStreamer.cmake:

Source/WebCore:

No new tests, build fix.

Building WebCore statically was failing because files in
WebCore/platform/gstreamer when ENABLE_VIDEO was set required
gstreamer-base, which was not being linked to after r116453.

Fix that by looking for gstreamer-base, requiring and linking
against it if GStreamer is used.

  • PlatformEfl.cmake: Link to GSTREAMER_LIBRARIES and

GSTREAMER_BASE_LIBRARIES, and include GSTREAMER_INCLUDE_DIRS and
GSTREAMER_BASE_INCLUDE_DIRS.

16:55 Changeset [116467] by fpizlo@apple.com
  • 17 edits in branches/dfgopt/Source/JavaScriptCore

DFG should support op_get_argument_by_val and op_get_arguments_length
https://bugs.webkit.org/show_bug.cgi?id=85911

Reviewed by Oliver Hunt.

This adds a simple and relatively conservative implementation of op_get_argument_by_val
and op_get_arguments_length. We can optimize these later. For now it's great to have
the additional coverage.

This patch appears to be perf-neutral.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::addressFor):
(JSC::DFG::AssemblyHelpers::tagFor):
(JSC::DFG::AssemblyHelpers::payloadFor):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):
(JSC::DFG::canInlineOpcode):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasHeapPrediction):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):
(SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_get_argument_by_val):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_get_argument_by_val):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
16:50 Changeset [116466] by jonlee@apple.com
  • 3 edits in trunk/Source/WebKit2

[WK2] Push wheel events if there are too many in queue
https://bugs.webkit.org/show_bug.cgi?id=85747
<rdar://problem/11390790>

Reviewed by Anders Carlsson.

It is possible that a whole bunch of messages added to the message queue, or a series
of long-running messages, cause unresponsiveness. The reason for this is that we have
a scroll event waiting for acknowledgment from the web process before it sends the next
event. And in the time between the user has scrolled, causing a large backlog of scroll
events to be held in the UI process.

We should push new scroll events if the queue accumulates too many of them.

  • UIProcess/WebPageProxy.h: The vector m_currentlyProcessedWheelEvents used to hold the

series of wheel events that were coalesced and sent as a single wheel event to the web
process. When the web process acknowledges this with didReceiveEvent, the UI process
cleared that vector, then tried to coalesce the next wheel event to send. Now we might have
multiple sets of coalesced wheel events that we are sending to the web process. To keep
track of these sets, m_currentlyProcessedWheelEvents now is a queue of Vectors.
(WebPageProxy):

  • UIProcess/WebPageProxy.cpp: Add new constant wheelEventQueueSizeThreshold representing

the threshold of scroll events to look for before we start pushing events.
(WebKit::canCoalesce): Move static function so that handleWheelEvent() has access. No changes.
(WebKit::coalesce): Move static function so that handleWheelEvent() has access. No changes.
(WebKit::coalescedWheelEvent): Move static function so that handleWheelEvent() has access. No changes.
(WebKit::WebPageProxy::handleWheelEvent): If we are currently waiting for acknowledgment
from the web process that a wheel event has been handled, we add it to the queue. We
check to see that the queue size is within our threshold before we return early. Otherwise
we will start pushing events in the queue. Refactor the rest of the function into
processNextQueuedWheelEvent() and sendWheelEvent(). If we are not currently waiting for
acknowledgment, nor have events in the queue, then we send the current wheel event.
(WebKit::WebPageProxy::processNextQueuedWheelEvent): Try to coalesce events based on the
wheel event at the head of the queue, and send that event to the web process.
(WebKit::WebPageProxy::sendWheelEvent): Refactored from handleWheelEvent().
(WebKit::WebPageProxy::didReceiveEvent): Instead of clearing m_currentlyProcessedWheelEvents,
which contained the set of one coalesced wheel event, we pull the head Vector, which
contains the same set of events. Refactor to use processNextQueuedWheelEvent().

16:24 Changeset [116465] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

JavaScriptAudioNode should not ASSERT if number of input channels is 0
https://bugs.webkit.org/show_bug.cgi?id=85818

Patch by Raymond Toy <rtoy@google.com> on 2012-05-08
Reviewed by Eric Seidel.

Source/WebCore:

Test: webaudio/javascriptaudionode-zero-input-channels.html

  • Modules/webaudio/JavaScriptAudioNode.cpp:

(WebCore::JavaScriptAudioNode::process): Update buffersAreGood.
(WebCore::JavaScriptAudioNode::fireProcessEvent): Remove ASSERT.

LayoutTests:

  • webaudio/javascriptaudionode-zero-input-channels-expected.txt: Added.
  • webaudio/javascriptaudionode-zero-input-channels.html: Added.
16:21 Changeset [116464] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk

[EFL][DRT] EventSender needs implementation of leapForward function
https://bugs.webkit.org/show_bug.cgi?id=83486

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-05-08
Reviewed by Eric Seidel.

Tools:

Implemented leapForward function in Efl's DRT. This function is required
to delay and queue event execution and simulate real user behavior.

  • DumpRenderTree/efl/EventSender.cpp:

(DelayedEvent):
(MouseEventInfo::MouseEventInfo):
(MouseEventInfo):
(sendClick):
(mouseDownCallback):
(mouseUpCallback):
(mouseMoveToCallback):
(leapForwardCallback):
(mouseScrollByCallback):
(feedOrQueueMouseEvent):
(feedMouseEvent):
(feedQueuedMouseEvents):

LayoutTests:

Unskipping few tests that were failing due to the missing leapForward function
Added EFL specific test result, since EFL doesnt support 2D wheel events

  • platform/efl/Skipped:
  • platform/efl/fast/events/platform-wheelevent-in-scrolling-div-expected.txt: Added.
16:01 Changeset [116463] by danakj@chromium.org
  • 4 edits in trunk/Source

Region reads past end of spans
https://bugs.webkit.org/show_bug.cgi?id=85909

Reviewed by Anders Carlsson.

Source/WebCore:

Region currently checks aSpan == aSpanEnd as the indicator that
we passed all the spans. When aSpan < aSpanEnd, it uses aSpan+1
to find the height of the span.

If aSpan == aSpanEnd - 1, then aSpan+1 == aSpanEnd. This does not
represent a valid span, since aSpanEnd is past the end of the
array, not the last element in the array. The loop should terminate
in this case.

Checking aSegment != aSegmentEnd is acceptable in the inner loop since
it increments by two each time (segments come in pairs, while spans
come in singles).

Test: RegionTest.ReadPastFullSpanVectorInIntersectsTest

  • platform/graphics/Region.cpp:

(WebCore::Region::Shape::compareShapes):

Source/WebKit/chromium:

  • tests/RegionTest.cpp:

(WebCore::TEST):
(WebCore):

16:01 Changeset [116462] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk/Source/WebKit

Source/WebKit: [BlackBerry] Implement a popup client for HTML controls
https://bugs.webkit.org/show_bug.cgi?id=85670

Patch by Crystal Zhang <haizhang@rim.com> on 2012-05-08
Reviewed by Rob Buis.

Add popup client file to build system.

  • PlatformBlackBerry.cmake:

Source/WebKit/blackberry: [BlackBerry] Implement a popup client for HTML controls

https://bugs.webkit.org/show_bug.cgi?id=85670

Reviewed by Rob Buis.

Implement a popup client for HTML controls, which would be used to load
different popups according to popup type.

  • WebCoreSupport/PagePopupBlackBerry.cpp: Added. (WebCore): (PagePopupChromeClient): (WebCore::PagePopupChromeClient::PagePopupChromeClient): (WebCore::PagePopupChromeClient::closeWindowSoon): (WebCore::PagePopupChromeClient::webPage): (WebCore::PagePopupBlackBerry::PagePopupBlackBerry): (WebCore::PagePopupBlackBerry::~PagePopupBlackBerry): (WebCore::PagePopupBlackBerry::sendCreatePopupWebViewRequest): (WebCore::PagePopupBlackBerry::init): (WebCore::setValueAndClosePopupCallback): (WebCore::popUpExtensionInitialize): (WebCore::popUpExtensionFinalize): (WebCore::PagePopupBlackBerry::installDomFunction): (WebCore::PagePopupBlackBerry::handleMouseEvent): (WebCore::PagePopupBlackBerry::closePopup): (WebCore::PagePopupBlackBerry::closeWebPage):
  • WebCoreSupport/PagePopupBlackBerry.h: Added. (WebKit): (WebCore): (PagePopupBlackBerry):

Patch by Crystal Zhang <haizhang@rim.com> on 2012-05-08

15:50 Changeset [116461] by ryuan.choi@samsung.com
  • 2 edits in trunk/Tools

[EFL][DRT] WebKit/DRT should not paint webview for the pixel tests.
https://bugs.webkit.org/show_bug.cgi?id=79853

Reviewed by Eric Seidel.

Screen buffer can be different from rendered results.
For example, WebKit/Efl just moves tiles for ewk_view_tiled when scrolling
contents.
It means that pixel tests can't check regression of ewk_view_tiled.

This patch changes a way to provide bitmap from painting webview to capturing
evas.

  • DumpRenderTree/efl/PixelDumpSupportEfl.cpp:

(createBitmapContextFromWebView):

15:45 Changeset [116460] by tony@chromium.org
  • 3 edits
    3 adds in trunk/Source/WebKit/chromium

move listener_leak_test to webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=85922

Reviewed by Ojan Vafai.

Porting the test from src/webkit/tools/test_shell/listener_leak_test.cc.
All I did was change the style and use the FrameTestHelper to load the file.

  • WebKit.gyp: Exclude file in components build.
  • WebKit.gypi: Add new file.
  • tests/ListenerLeakTest.cpp: Added.

(WebKit):
(WebKit::GetProperty):
(WebKit::GetNumObjects):
(ListenerLeakTest):
(WebKit::ListenerLeakTest::ListenerLeakTest):
(WebKit::ListenerLeakTest::RunTest):
(WebKit::TEST_F):

  • tests/data/listener/listener_leak1.html: Added.
  • tests/data/listener/listener_leak2.html: Added.
15:31 Changeset [116459] by oliver@apple.com
  • 1 edit
    22 adds in trunk/LayoutTests

Add mac results for new tests following http://trac.webkit.org/changeset/116438.

15:29 Changeset [116458] by pdr@google.com
  • 5 edits
    8 adds in trunk

Prevent crash in animated lists
https://bugs.webkit.org/show_bug.cgi?id=85382

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Animated lists blindly assign the last list value to m_toAtEndOfDurationType
in SVGAnimationElement::startedActiveInterval. If the last list value's length
is larger or smaller than the animated "to" length, we crash.

This change prevents accessing values off the end of toAtEndOfDuration by adding
a check for this case. It may seem inefficient to perform this check on every
animation update but the "to" value can change (in cardinality) while animating.

I checked each of the other animation types (e.g., SVGAnimatedAngle,
SVGAnimatedBoolean, etc.) and was only able to hit this style of crash
in the three types modified in this change:
SVGAnimatedLengthList, SVGAnimatedNumberList, and SVGAnimatedPointList.

Tests: svg/animations/animate-linear-discrete-additive-b-expected.svg

svg/animations/animate-linear-discrete-additive-b.svg
svg/animations/animate-linear-discrete-additive-c-expected.svg
svg/animations/animate-linear-discrete-additive-c.svg
svg/animations/animate-linear-discrete-additive-expected.svg
svg/animations/animate-linear-discrete-additive.svg
svg/animations/animate-list-crash.svg

  • svg/SVGAnimatedLengthList.cpp:

(WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedNumberList.cpp:

(WebCore::SVGAnimatedNumberListAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedPointList.cpp:

(WebCore::SVGAnimatedPointListAnimator::calculateAnimatedValue):

LayoutTests:

  • svg/animations/animate-linear-discrete-additive-b-expected.svg: Added.
  • svg/animations/animate-linear-discrete-additive-b.svg: Added.
  • svg/animations/animate-linear-discrete-additive-c-expected.svg: Added.
  • svg/animations/animate-linear-discrete-additive-c.svg: Added.
  • svg/animations/animate-linear-discrete-additive-expected.svg: Added.
  • svg/animations/animate-linear-discrete-additive.svg: Added.
  • svg/animations/animate-list-crash-expected.txt: Added.
  • svg/animations/animate-list-crash.svg: Added.
15:04 Changeset [116457] by rafaelw@chromium.org
  • 3 edits in trunk/Source/WebCore

HTMLElementStack::hasOnlyHTMLElementsInScope is no longer called
https://bugs.webkit.org/show_bug.cgi?id=85908

Reviewed by Eric Seidel.

This patch just removes the dead code.

No tests needed. Cleanup only.

  • html/parser/HTMLElementStack.cpp:
  • html/parser/HTMLElementStack.h:

(HTMLElementStack):

14:57 Changeset [116456] by wjmaclean@chromium.org
  • 6 edits
    5 adds in trunk/Source

[chromium] Create LinkHighlightLayerChromium class to provide link-highlight preview animations for GraphicsLayerChromium.
https://bugs.webkit.org/show_bug.cgi?id=85084

Reviewed by James Robinson.

Source/WebCore:

Unit test provided.

Creates a layer delegate class to provide link highlight animations for link-preview feature.
These are added to a GraphicsLayerChromium via provided methods. Moves dispensing of animation
ids into a separate class.

  • WebCore.gypi:
  • platform/graphics/chromium/AnimationIdVendor.cpp: Added.

(WebCore):
(WebCore::AnimationIdVendor::getNextAnimationId):
(WebCore::AnimationIdVendor::getNextGroupId):

  • platform/graphics/chromium/AnimationIdVendor.h: Added.

(WebCore):
(AnimationIdVendor):

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::willBeDestroyed):
(WebCore::GraphicsLayerChromium::updateNames):
(WebCore::GraphicsLayerChromium::addAnimation):
(WebCore::GraphicsLayerChromium::addLinkHighlight):
(WebCore):
(WebCore::GraphicsLayerChromium::didFinishLinkHighlight):
(WebCore::GraphicsLayerChromium::updateChildList):
(WebCore::GraphicsLayerChromium::mapAnimationNameToId):

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(WebCore):
(GraphicsLayerChromium):

  • platform/graphics/chromium/LinkHighlight.cpp: Added.

(WebCore):
(WebCore::LinkHighlight::create):
(WebCore::LinkHighlight::LinkHighlight):
(WebCore::LinkHighlight::~LinkHighlight):
(WebCore::LinkHighlight::contentLayer):
(WebCore::LinkHighlight::paintContents):
(WebCore::LinkHighlight::notifyAnimationStarted):
(WebCore::LinkHighlight::notifyAnimationFinished):

  • platform/graphics/chromium/LinkHighlight.h: Added.

(WebCore):
(LinkHighlight):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/LinkHighlightTest.cpp: Added.

(WebCore):
(MockGraphicsLayerClient):
(WebCore::MockGraphicsLayerClient::notifyAnimationStarted):
(WebCore::MockGraphicsLayerClient::notifySyncRequired):
(WebCore::MockGraphicsLayerClient::paintContents):
(WebCore::MockGraphicsLayerClient::showDebugBorders):
(WebCore::MockGraphicsLayerClient::showRepaintCounter):
(WebCore::TEST):

14:52 Changeset [116455] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

SIGFPE on divide in classic interpreter
https://bugs.webkit.org/show_bug.cgi?id=85917

Rubber stamped by Oliver Hunt.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • check for divisor of -1.
14:22 Changeset [116454] by ojan@chromium.org
  • 1 edit
    20 copies
    44 moves
    74 adds in trunk/LayoutTests

Chromium rebaselines after http://trac.webkit.org/changeset/116438.

  • platform/chromium-linux/css2.1/20110323/first-letter-000-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-000-expected.png.
  • platform/chromium-linux/css2.1/20110323/first-letter-001-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-001-expected.png.
  • platform/chromium-linux/css2.1/20110323/first-letter-dynamic-001-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png.
  • platform/chromium-linux/css2.1/20110323/first-letter-dynamic-002-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-002-expected.png.
  • platform/chromium-linux/css2.1/20110323/first-letter-dynamic-003a-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003a-expected.png.
  • platform/chromium-linux/css2.1/20110323/first-letter-dynamic-003b-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
  • platform/chromium-linux/css2.1/20110323/first-letter-inherit-001-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-inherit-001-expected.png.
  • platform/chromium-linux/css2.1/20110323/first-letter-nested-001-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-001-expected.png.
  • platform/chromium-linux/css2.1/20110323/first-letter-nested-002-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-002-expected.png.
  • platform/chromium-linux/css2.1/20110323/first-letter-nested-003-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-003-expected.png.
  • platform/chromium-linux/css2.1/20110323/first-letter-nested-004-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-004-expected.png.
  • platform/chromium-linux/css2.1/20110323/first-letter-nested-005-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-005-expected.png.
  • platform/chromium-linux/css2.1/20110323/first-letter-nested-006-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-006-expected.png.
  • platform/chromium-linux/css2.1/20110323/first-letter-nested-007-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-007-expected.png.
  • platform/chromium-linux/css2.1/20110323/first-letter-quote-001-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-001-expected.png.
  • platform/chromium-linux/css2.1/20110323/first-letter-quote-002-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-002-expected.png.
  • platform/chromium-linux/css2.1/20110323/first-letter-quote-003-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-003-expected.png.
  • platform/chromium-linux/css2.1/20110323/first-letter-quote-004-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-004-expected.png.
  • platform/chromium-linux/css2.1/20110323/first-letter-quote-005-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-005-expected.png.
  • platform/chromium-linux/css2.1/20110323/first-letter-quote-006-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-006-expected.png.
  • platform/chromium-linux/fast/css/first-letter-nested-positioned-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/first-letter-nested-positioned-expected.png.
  • platform/chromium-linux/fast/css/first-letter-quotes-no-content-before-after-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/first-letter-quotes-no-content-before-after-expected.png.
  • platform/chromium-mac-leopard/css2.1/20110323/first-letter-000-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/first-letter-dynamic-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/first-letter-dynamic-002-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/first-letter-dynamic-003a-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/first-letter-dynamic-003b-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/first-letter-inherit-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/first-letter-quote-001-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/first-letter-quote-002-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/first-letter-quote-003-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/first-letter-quote-004-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/first-letter-quote-005-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/20110323/first-letter-quote-006-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/first-letter-nested-positioned-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/first-letter-quotes-no-content-before-after-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-000-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-dynamic-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-dynamic-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-dynamic-003a-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-dynamic-003b-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-inherit-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-quote-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-quote-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-quote-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-quote-004-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-quote-005-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-quote-006-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/first-letter-nested-positioned-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/first-letter-quotes-no-content-before-after-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-000-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-000-expected.txt: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-001-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-001-expected.txt: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-dynamic-001-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-dynamic-001-expected.txt: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-dynamic-002-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-dynamic-002-expected.txt: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-dynamic-003a-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-dynamic-003a-expected.txt: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-dynamic-003b-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-dynamic-003b-expected.txt: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-inherit-001-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-inherit-001-expected.txt: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-nested-001-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-nested-001-expected.txt: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-nested-002-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-nested-002-expected.txt: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-nested-003-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-nested-003-expected.txt: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-nested-004-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-nested-004-expected.txt: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-nested-005-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-nested-005-expected.txt: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-nested-006-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-nested-006-expected.txt: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-nested-007-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-nested-007-expected.txt: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-quote-001-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-quote-001-expected.txt: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-quote-002-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-quote-002-expected.txt: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-quote-003-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-quote-003-expected.txt: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-quote-004-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-quote-004-expected.txt: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-quote-005-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-quote-005-expected.txt: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-quote-006-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/first-letter-quote-006-expected.txt: Added.
  • platform/chromium-mac/fast/css/first-letter-nested-positioned-expected.png: Added.
  • platform/chromium-mac/fast/css/first-letter-nested-positioned-expected.txt: Added.
  • platform/chromium-mac/fast/css/first-letter-quotes-no-content-before-after-expected.png: Added.
  • platform/chromium-mac/fast/css/first-letter-quotes-no-content-before-after-expected.txt: Added.
  • platform/chromium-win/css2.1/20110323/first-letter-000-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/first-letter-000-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-000-expected.txt.
  • platform/chromium-win/css2.1/20110323/first-letter-001-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
  • platform/chromium-win/css2.1/20110323/first-letter-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-001-expected.txt.
  • platform/chromium-win/css2.1/20110323/first-letter-dynamic-001-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003a-expected.png.
  • platform/chromium-win/css2.1/20110323/first-letter-dynamic-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.txt.
  • platform/chromium-win/css2.1/20110323/first-letter-dynamic-002-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png.
  • platform/chromium-win/css2.1/20110323/first-letter-dynamic-002-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-002-expected.txt.
  • platform/chromium-win/css2.1/20110323/first-letter-dynamic-003a-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003a-expected.png.
  • platform/chromium-win/css2.1/20110323/first-letter-dynamic-003a-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003a-expected.txt.
  • platform/chromium-win/css2.1/20110323/first-letter-dynamic-003b-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
  • platform/chromium-win/css2.1/20110323/first-letter-dynamic-003b-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.txt.
  • platform/chromium-win/css2.1/20110323/first-letter-inherit-001-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/first-letter-inherit-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-inherit-001-expected.txt.
  • platform/chromium-win/css2.1/20110323/first-letter-nested-001-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
  • platform/chromium-win/css2.1/20110323/first-letter-nested-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-001-expected.txt.
  • platform/chromium-win/css2.1/20110323/first-letter-nested-002-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
  • platform/chromium-win/css2.1/20110323/first-letter-nested-002-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-002-expected.txt.
  • platform/chromium-win/css2.1/20110323/first-letter-nested-003-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
  • platform/chromium-win/css2.1/20110323/first-letter-nested-003-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-003-expected.txt.
  • platform/chromium-win/css2.1/20110323/first-letter-nested-004-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
  • platform/chromium-win/css2.1/20110323/first-letter-nested-004-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-004-expected.txt.
  • platform/chromium-win/css2.1/20110323/first-letter-nested-005-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
  • platform/chromium-win/css2.1/20110323/first-letter-nested-005-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-005-expected.txt.
  • platform/chromium-win/css2.1/20110323/first-letter-nested-006-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
  • platform/chromium-win/css2.1/20110323/first-letter-nested-006-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-006-expected.txt.
  • platform/chromium-win/css2.1/20110323/first-letter-nested-007-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
  • platform/chromium-win/css2.1/20110323/first-letter-nested-007-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-007-expected.txt.
  • platform/chromium-win/css2.1/20110323/first-letter-quote-001-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png.
  • platform/chromium-win/css2.1/20110323/first-letter-quote-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-001-expected.txt.
  • platform/chromium-win/css2.1/20110323/first-letter-quote-002-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png.
  • platform/chromium-win/css2.1/20110323/first-letter-quote-002-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-002-expected.txt.
  • platform/chromium-win/css2.1/20110323/first-letter-quote-003-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png.
  • platform/chromium-win/css2.1/20110323/first-letter-quote-003-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-003-expected.txt.
  • platform/chromium-win/css2.1/20110323/first-letter-quote-004-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png.
  • platform/chromium-win/css2.1/20110323/first-letter-quote-004-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-004-expected.txt.
  • platform/chromium-win/css2.1/20110323/first-letter-quote-005-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png.
  • platform/chromium-win/css2.1/20110323/first-letter-quote-005-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-005-expected.txt.
  • platform/chromium-win/css2.1/20110323/first-letter-quote-006-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png.
  • platform/chromium-win/css2.1/20110323/first-letter-quote-006-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-006-expected.txt.
  • platform/chromium-win/fast/css/first-letter-nested-positioned-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png.
  • platform/chromium-win/fast/css/first-letter-nested-positioned-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/first-letter-nested-positioned-expected.txt.
  • platform/chromium-win/fast/css/first-letter-quotes-no-content-before-after-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
  • platform/chromium-win/fast/css/first-letter-quotes-no-content-before-after-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/first-letter-quotes-no-content-before-after-expected.txt.
13:32 Changeset [116453] by rakuco@webkit.org
  • 7 edits
    8 deletes in trunk

[CMake] Rewrite FindGStreamer.cmake.
https://bugs.webkit.org/show_bug.cgi?id=85857

Reviewed by Daniel Bates.

.:

We are currently kind of duplicating the same
FindGStreamer-Foo.cmake file whenever a new GStreamer plugin needs
to be found. Besides this approach not scaling very well, it
relies on pkg-config for version checking, uses the LibFindMacros
package that we should deprecate and all the find files could be
merged into one, with users using the COMPONENTS feature of the
FIND_PACKAGE() call to find the desired plugins.

FindGStreamer.cmake has then been rewritten to take all that into
account:

  • The LibFindMacros.cmake package is not used anymore.
  • Version check is performed in the CMake file itself by parsing

the gstversion.h header.

  • All GStreamer plugins are searched and the COMPONENTS keyword

used in the FIND_PACKAGE() call is used to check which plugins are
required.

  • The plugins-base and base GStreamer plugins are not searched, as

they were not used anywhere in the build system.

  • Source/cmake/FindGStreamer-App.cmake: Removed.
  • Source/cmake/FindGStreamer-Audio.cmake: Removed.
  • Source/cmake/FindGStreamer-Base.cmake: Removed.
  • Source/cmake/FindGStreamer-FFT.cmake: Removed.
  • Source/cmake/FindGStreamer-Interfaces.cmake: Removed.
  • Source/cmake/FindGStreamer-Pbutils.cmake: Removed.
  • Source/cmake/FindGStreamer-Plugins-Base.cmake: Removed.
  • Source/cmake/FindGStreamer-Video.cmake: Removed.
  • Source/cmake/FindGStreamer.cmake: Rewrite as described above.
  • Source/cmake/OptionsEfl.cmake: Use COMPONENTS to specify which

GStreamer plugins to look for.

Source/WebCore:

No new tests, build system change.

We are currently kind of duplicating the same
FindGStreamer-Foo.cmake file whenever a new GStreamer plugin needs
to be found. Besides this approach not scaling very well, it
relies on pkg-config for version checking, uses the LibFindMacros
package that we should deprecate and all the find files could be
merged into one, with users using the COMPONENTS feature of the
FIND_PACKAGE() call to find the desired plugins.

FindGStreamer.cmake has then been rewritten to take all that into
account:

  • The LibFindMacros.cmake package is not used anymore.
  • Version check is performed in the CMake file itself by parsing

the gstversion.h header.

  • All GStreamer plugins are searched and the COMPONENTS keyword

used in the FIND_PACKAGE() call is used to check which plugins are
required.

  • The plugins-base and base GStreamer plugins are not searched, as

they were not used anywhere in the build system.

  • PlatformEfl.cmake: Update GStreamer-related variable names.

Source/WebKit:

We are currently kind of duplicating the same
FindGStreamer-Foo.cmake file whenever a new GStreamer plugin needs
to be found. Besides this approach not scaling very well, it
relies on pkg-config for version checking, uses the LibFindMacros
package that we should deprecate and all the find files could be
merged into one, with users using the COMPONENTS feature of the
FIND_PACKAGE() call to find the desired plugins.

FindGStreamer.cmake has then been rewritten to take all that into
account:

  • The LibFindMacros.cmake package is not used anymore.
  • Version check is performed in the CMake file itself by parsing

the gstversion.h header.

  • All GStreamer plugins are searched and the COMPONENTS keyword

used in the FIND_PACKAGE() call is used to check which plugins are
required.

  • The plugins-base and base GStreamer plugins are not searched, as

they were not used anywhere in the build system.

  • PlatformEfl.cmake: Update GStreamer-related variable names.
13:24 Changeset [116452] by commit-queue@webkit.org
  • 5 edits in trunk

[EFL] Handling of numeric-pad keys in EFL's PlatformKeyboardEvent
https://bugs.webkit.org/show_bug.cgi?id=85479

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-08
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

EFL's PlatformKeyboardEvent::isKeypad() now returns meaningful value.
Added numeric-pad keys to the Key Map and Windows Key Map.

No new tests.

  • platform/efl/EflKeyboardUtilities.cpp:

(WebCore::createKeyMap):
(WebCore::createWindowsKeyMap):

  • platform/efl/PlatformKeyboardEventEfl.cpp:

(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

LayoutTests:

Unskipped fast/events/keydown-numpad-keys.html.

  • platform/efl/Skipped:
12:44 Changeset [116451] by zimmermann@webkit.org
  • 19 edits
    2 adds in trunk

Tie lifetime of SVGAnimateElement::m_animatedType to the duration of the animation
https://bugs.webkit.org/show_bug.cgi?id=85627

Reviewed by Antti Koivisto.

Source/WebCore:

Example:
<rect width="10" height="100">

<animate attributeName="width" from="10" to="100" begin="2s" dur="4s" fill="remove"/>

</rect>

At t=0s the <animate> element receives its first interval: begin=2s, end=6s.
At this point we've created the 'OwnPtr<SVGAnimatedType> m_animatedType' in
SVGAnimateElement, which holds the current animated value of the target type.
In this example it contains a SVGLength with '10' as value at t=0s.

Calling "rect.width.animVal.value" will return the value currently contained in the
m_animatedType from the SVGAnimateElement, even though the animation didn't begin
yet. This is fine, as the animVal equals to the baseVal, as long as no animation is
running.

At t=6s you'd expect that the whole 'animVal' object is destructed again, as it's no
longer needed, as animVal will be equal to baseVal again, but the current code keeps
the animVal alive, and just resets it to the baseVal. The animVals will be destructed
once the animate element leaves the tree.

CSS animations suffer from the same problem, we never remove the animated SMIL properties
but we only reset them to the base value. This makes integration with CSS Animations and
CSS Transitions harder, so this needs to be changed.

This patch starts tracking the start/end of an animation chain properly, to destruct
the animation effect for non-frozen animations at the end of their duration. This has to
work properly together with seeking (SVGSVGElement.setCurrentTime), as our testing relies
on the ability to drive the SMIL timeline from script.

Tests: svg/animations/list-wrapper-assertion-expected.svg

svg/animations/list-wrapper-assertion.svg

  • svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::resetAnimatedType):
(WebCore::applyCSSPropertyToTarget):
(WebCore::removeCSSPropertyFromTarget):
(WebCore::applyCSSPropertyToTargetAndInstances):
(WebCore::removeCSSPropertyFromTargetAndInstances):
(WebCore::notifyTargetAboutAnimValChange):
(WebCore::notifyTargetAndInstancesAboutAnimValChange):
(WebCore::SVGAnimateElement::clearAnimatedType):
(WebCore::SVGAnimateElement::applyResultsToTarget):
(WebCore::SVGAnimateElement::targetElementWillChange):

  • svg/SVGAnimateElement.h:

(SVGAnimateElement):

  • svg/SVGAnimateMotionElement.cpp:

(WebCore::SVGAnimateMotionElement::resetAnimatedType):
(WebCore::SVGAnimateMotionElement::clearAnimatedType):

  • svg/SVGAnimateMotionElement.h:

(SVGAnimateMotionElement):

  • svg/SVGAnimationElement.cpp:
  • svg/SVGAnimationElement.h:
  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::updateAnimations):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::reset):
(WebCore::SVGSMILElement::targetElementWillChange):
(WebCore::SVGSMILElement::determineActiveState):
(WebCore::SVGSMILElement::progress):

  • svg/animation/SVGSMILElement.h:

(SVGSMILElement):

  • svg/properties/SVGAnimatedListPropertyTearOff.h:

Remove svgAttributeChanged() calls from animationEnded/animValDidChange.
Callers are now required to notify the target about changes. There are cases
where we want to call animValDidChange without invoking svgAttributeChanged().
That is supported now.

(WebCore::SVGAnimatedListPropertyTearOff::animationEnded):
(WebCore::SVGAnimatedListPropertyTearOff::animValDidChange):

  • svg/properties/SVGAnimatedProperty.h: Ditto.

(WebCore::SVGAnimatedProperty::commitChange): Add safety guard.

  • svg/properties/SVGAnimatedPropertyTearOff.h: Ditto.

(WebCore::SVGAnimatedPropertyTearOff::animationEnded):
(WebCore::SVGAnimatedPropertyTearOff::animValDidChange):

  • svg/properties/SVGAnimatedStaticPropertyTearOff.h: Ditto.

(WebCore::SVGAnimatedStaticPropertyTearOff::animationEnded):
(WebCore::SVGAnimatedStaticPropertyTearOff::animValDidChange):

LayoutTests:

Update animate-target-id-changed.svg test to match Firefox behavior.
When an animation element with fill="freeze" is changed to a new target
eg, via animate.href = "#someOtherID", the animation effect should be removed.

Add tests for assertions I ran into while developing this patch.

  • platform/chromium/test_expectations.txt: Require new results for animate-target-id-changed-expected.txt.
  • platform/mac/svg/custom/animate-target-id-changed-expected.png:
  • svg/animations/list-wrapper-assertion-expected.svg: Added.
  • svg/animations/list-wrapper-assertion.svg: Added.
  • svg/custom/animate-target-id-changed-expected.txt:
  • svg/custom/animate-target-id-changed.svg:
12:36 Changeset [116450] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebCore

[EFL][DRT]Do not create ScrollbarEfl when mockScrollbar is enabled.
https://bugs.webkit.org/show_bug.cgi?id=81315

Reviewed by Chang Shu.

ScrollbarEfl creates custom scrollbars as separated layer and they are
not related to ScrollbarTheme.
So, DRT/Efl creates custom scrollbars on webview which paints mockScrollbar.

This patch prevents creating custom scrollbars when mockScrollbar is enabled.

Because DRT/Efl only renders the webview now, expected results are same
until Bug 79853 is landed.

  • platform/efl/ScrollbarEfl.cpp:

(Scrollbar::createNativeScrollbar):

12:33 Changeset [116449] by timothy@apple.com
  • 7 edits in trunk/Source

Fix the SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL macro so it passes the full path to dlopen.

dyld only considers libraries in the versioned framework path if their install name
matches the library that it is attempting to load. The path we were passing to
dlopen lacked the Versions/A component of the path so dyld did not recognize that
we wanted it to use the staged version if it is newer.

<rdar://problem/11406517>

Reviewed by Mark Rowe.

Source/WebCore:

  • platform/mac/SoftLinking.h: Have SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL take the

framework version as an argument and use it when constructing the path to dlopen.

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.mm: Pass A to SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL for the version.

Source/WebKit2:

  • UIProcess/mac/WebInspectorProxyMac.mm: Pass A to SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL for the version.
  • WebProcess/WebPage/mac/WebInspectorMac.mm: Ditto.
12:26 Changeset [116448] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Unreviewed, rolling out r116440.
http://trac.webkit.org/changeset/116440
https://bugs.webkit.org/show_bug.cgi?id=85904

Broke the Chromium Android bot (Requested by beverloo on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-08

  • WTF.gyp/WTF.gyp:
12:16 Changeset [116447] by rafael.lobo@openbossa.org
  • 2 edits in trunk/Source/WebCore

Build fix for Qt Snowleopard Release
https://bugs.webkit.org/show_bug.cgi?id=85895

Reviewed by Alexis Menard.

The enum value JSUint8ClampedArray conflicted with the JSUint8ClampedArray class.
I've added the 'Type' suffix to the enum value to make their names different.

No new tests needed.

  • bridge/qt/qt_runtime_qt4.cpp:

(JSC::Bindings::valueRealType):
(JSC::Bindings::convertValueToQVariant):

12:11 Changeset [116446] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

offsetLeft broken within CSS3 columns
https://bugs.webkit.org/show_bug.cgi?id=34875

Patch by Shezan Baig <shezbaig.wk@gmail.com> on 2012-05-08
Reviewed by Julien Chaffraix.

Source/WebCore:

Reimplement offsetLeft and offsetTop in terms of a new method called
'offsetTopLeft'. The new method starts from a reference point (the
top-left coordinate of a box or inline) and adjusts this reference
point for columns as we traverse each parent. Note that the reference
point needs to be adjusted in both dimensions, even though offsetLeft
and offsetTop return only one of them.

A new method called 'offsetForColumns' was added to RenderObject. This
method is similar to adjustForColumns, except that it returns the
offset instead of modifying a reference. This method is necessary to
simplify the implementation of offsetTopLeft.

Tests: fast/block/positioning/offsetLeft-offsetTop-multicolumn-expected.txt

fast/block/positioning/offsetLeft-offsetTop-multicolumn.html

  • rendering/RenderBox.h:

(RenderBox):
Override offsetLeft and offsetTop.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::offsetLeft):
Implemented in terms of RenderBoxModelObject::offsetTopLeft, using
topLeftLocation as startPoint.
(WebCore::RenderBox::offsetTop):
Implemented in terms of RenderBoxModelObject::offsetTopLeft, using
topLeftLocation as startPoint.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::offsetTopLeft):
New method to compute offsetLeft and offsetTop simultaneously, and
adjusting for columns at each parent.
(WebCore::RenderBoxModelObject::offsetLeft):
Reimplemented in terms of offsetTopLeft.
(WebCore::RenderBoxModelObject::offsetTop):
Reimplemented in terms of offsetTopLeft.

  • rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):
Declare new offsetTopLeft method.

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::offsetLeft):
Reimplemented in terms of RenderBoxModelObject::offsetTopLeft.
(WebCore::RenderInline::offsetTop):
Reimplemented in terms of RenderBoxModelObject::offsetTopLeft.

  • rendering/RenderObject.h:

(RenderObject):
(WebCore::RenderObject::offsetForColumns):
New helper method to simplify implementation of offsetTopLeft.

LayoutTests:

Add test for offsetLeft and offsetTop within multi-columns.

  • fast/block/positioning/offsetLeft-offsetTop-multicolumn-expected.txt: Added.
  • fast/block/positioning/offsetLeft-offsetTop-multicolumn.html: Added.
12:09 Changeset [116445] by rakuco@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] media/video-play-require-user-gesture.html test is failing
https://bugs.webkit.org/show_bug.cgi?id=85900

Unreviewed gardening.

Move media/video-play-require-user-gesture.html to test_expectations.txt since
it requires Full Screen API support. Also move fullscreen tests from Skipped
list to test_expectations.txt

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-08

  • platform/efl/Skipped:
  • platform/efl/test_expectations.txt:
12:07 Changeset [116444] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Layout test fast/overflow/lots-of-sibling-inline-boxes.html is flaky in debug builds
https://bugs.webkit.org/show_bug.cgi?id=85896

Unreviewed gardening.

Marking test as slow, since it times-out when executed using debug builds under
heavy processor loads.

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-05-08

  • platform/efl/test_expectations.txt:
12:04 Changeset [116443] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Update Web Timing tests expectations
https://bugs.webkit.org/show_bug.cgi?id=85622

Unreviewed Gardening.

Removed http/tests/misc/webtiming-origins.html and
http/tests/misc/webtiming-ssl from test expectations.
They started to pass after r116160.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-08

  • platform/efl/test_expectations.txt:
11:57 Changeset [116442] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] http/tests/security/cross-frame-access-* tests are failing
https://bugs.webkit.org/show_bug.cgi?id=85899

Unreviewed, move failing tests to test expectations.

http/tests/security/cross-frame-access-* tests are failing because EFL port
does not support showModalDialog. We need to move the test cases to test
expectations while the feature is implemented.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-08

  • platform/efl/test_expectations.txt:
11:51 Changeset [116441] by jchaffraix@webkit.org
  • 1 edit
    2 copies in branches/chromium/1084

Merge 115458 - NULL-deref in RenderBox::clippedOverflowRectForRepaint
https://bugs.webkit.org/show_bug.cgi?id=84774

Reviewed by Tony Chang.

Source/WebCore:

Test: fast/inline/crash-new-continuation-with-outline.html

The bug comes from trying to repaint the :after content as part of updateBeforeAfterContent.
The repainting logic would query the yet-to-be-inserted continuation(). Then we would crash in
RenderBox::clippedOverflowRectForRepaint as we didn't have an enclosingLayer() (which any
RenderObject in the tree will have).

The fix is to check in RenderInline::clippedOverflowRectForRepaint that our continuation()
is properly inserted in the tree. We could check that it isRooted() but it's an overkill here.

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::clippedOverflowRectForRepaint):

LayoutTests:

  • fast/inline/crash-new-continuation-with-outline-expected.txt: Added.
  • fast/inline/crash-new-continuation-with-outline.html: Added.

TBR=jchaffraix@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10375053

11:45 Changeset [116440] by abarth@webkit.org
  • 2 edits in trunk/Source/WTF

[Chromium] OS(ANDROID) ImageDiff requires us to build WTF for both host and target
https://bugs.webkit.org/show_bug.cgi?id=85897

Reviewed by Tony Chang.

  • WTF.gyp/WTF.gyp:
11:41 UsingGitWithWebKit edited by robert@roberthogan.net
(diff)
11:33 Changeset [116439] by rniwa@webkit.org
  • 3 edits in trunk

perf-o-matic fix attempt for dashboard images.

Rubber-stamped by Antti Koivisto.

Also stop generating images for 30, 90, and 365 days since they have been timing out.

  • Websites/webkit-perf.appspot.com/controller.py:

(schedule_runs_update):

  • Websites/webkit-perf.appspot.com/models.py:

(Runs.chart_params):

11:25 Changeset [116438] by robert@webkit.org
  • 5 edits
    67 adds in trunk

CSS 2.1 failure: first-letter-nested-004.htm fails
https://bugs.webkit.org/show_bug.cgi?id=72987

Reviewed by Eric Seidel.

Source/WebCore:

When styling first-letter check each sibling and drill into its inlines until we find either (i) a text node
that is not all whitespace, or (ii) a line break.

This makes our rendering of the following tests compatible with FF and Opera. Our current behaviour is also conformant
since the spec allows UAs to style just one element:

css2.1/20110323/first-letter-quote-002.htm
css2.1/20110323/first-letter-quote-003.htm
css2.1/20110323/first-letter-quote-004.htm
css2.1/20110323/first-letter-quote-005.htm

This fixes the following two tests. We now drill into the descendants of an element styled with :first-letter looking
for text to style:

css2.1/20110323/first-letter-nested-004.htm
css2.1/20110323/first-letter-nested-006.htm

This patch changes our rendering of first-letter-dynamic-001.htm as we now render adjacent quotes in the second line as
green. This is consistent with the spec, which allows this behaviour but does not require it. It's the 'right' behaviour
since it is consistent with the rendering of such quotes in a single element with :first-letter style.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::findLastObjectWithFirstLetterText): Iterate through the child's siblings looking for the last

object to be styled :first-letter.

(WebCore::RenderBlock::findLastObjectAfterFirstLetterPunctuation): Style any leading punctuation as first-letter, drill

down into the child's descendants looking for text if necessary.

(WebCore::RenderBlock::updateFirstLetter): Refactor to drill into sibling's children looking for inlines

that should be styled as first-letter.

(WebCore::RenderBlock::addFirstLetter): Split out from updateFirstLetter so that it can be used when a

descendant node inside a sibling is found in findLastObjectWithFirstLetterText() needs to be styled as first-letter.

  • rendering/RenderBlock.h:

LayoutTests:

  • css2.1/20110323/first-letter-000.htm: Added.
  • css2.1/20110323/first-letter-001.htm: Added.
  • css2.1/20110323/first-letter-dynamic-001.htm: Added.
  • css2.1/20110323/first-letter-dynamic-002.htm: Added.
  • css2.1/20110323/first-letter-dynamic-003a.htm: Added.
  • css2.1/20110323/first-letter-dynamic-003b.htm: Added.
  • css2.1/20110323/first-letter-inherit-001.htm: Added.
  • css2.1/20110323/first-letter-nested-001.htm: Added.
  • css2.1/20110323/first-letter-nested-002.htm: Added.
  • css2.1/20110323/first-letter-nested-003.htm: Added.
  • css2.1/20110323/first-letter-nested-004.htm: Added.
  • css2.1/20110323/first-letter-nested-005.htm: Added.
  • css2.1/20110323/first-letter-nested-006.htm: Added.
  • css2.1/20110323/first-letter-nested-007.htm: Added.
  • css2.1/20110323/first-letter-quote-001.htm: Added.
  • css2.1/20110323/first-letter-quote-002.htm: Added.
  • css2.1/20110323/first-letter-quote-003.htm: Added.
  • css2.1/20110323/first-letter-quote-004.htm: Added.
  • css2.1/20110323/first-letter-quote-005.htm: Added.
  • css2.1/20110323/first-letter-quote-006.htm: Added.
  • fast/css/first-letter-capitalized-edit-select-crash-expected.txt: Rebaselined.
  • fast/css/first-letter-nested-positioned.htm: Added.

Tests that text nested inside a positioned object is styled.

  • fast/css/first-letter-quotes-no-content-before-after.html: Added.

Tests that two consecutive quotes, each in a :before and :after pseudo element surrounding
an empty main element, get styled with first letter.

Behold! Pixel Results!

  • platform/chromium-linux-x86/css2.1/20110323/first-letter-000-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/first-letter-000-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/first-letter-001-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/first-letter-001-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-002-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-002-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003a-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003a-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/first-letter-inherit-001-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/first-letter-inherit-001-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-001-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-001-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-002-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-002-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-003-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-003-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-004-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-004-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-005-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-005-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-006-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-006-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-007-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-007-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-001-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-001-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-002-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-002-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-003-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-003-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-004-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-004-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-005-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-005-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-006-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-006-expected.txt: Added.
  • platform/chromium-linux-x86/fast/css/first-letter-nested-positioned-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/first-letter-nested-positioned-expected.txt: Added.
  • platform/chromium-linux-x86/fast/css/first-letter-quotes-no-content-before-after-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/first-letter-quotes-no-content-before-after-expected.txt: Added.
11:09 Changeset [116437] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Unreviewed, rolling out r116402.
http://trac.webkit.org/changeset/116402
https://bugs.webkit.org/show_bug.cgi?id=85898

Caused a 3% regression on Chromium's bloat-http test on Linux
(Requested by ojan_gardening on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-08

  • WebCore.exp.in:
  • bindings/v8/RetainedDOMInfo.cpp:
  • dom/ContainerNode.h:
  • dom/Node.cpp:

(WebCore::Node::traverseNextNode):
(WebCore):
(WebCore::Node::traverseNextSibling):

  • dom/Node.h:

(Node):

10:58 Changeset [116436] by commit-queue@webkit.org
  • 3 edits in trunk

[CMake] Add ENABLE_IFRAME_SEAMLESS flag
https://bugs.webkit.org/show_bug.cgi?id=85838

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-08
Reviewed by Eric Seidel.

Add ENABLE_IFRAME_SEAMLESS flag to CMake and enable it by default.
This flag was introduced by r116356.

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:
10:51 Changeset [116435] by hbono@chromium.org
  • 3 edits
    4 adds in trunk

[Chromium] Fix the position of an RTL resizer
https://bugs.webkit.org/show_bug.cgi?id=80640

Reviewed by Tony Chang.

When rendering an RTL resizer, my r110073 renders it at the same position as the
one used for rendering a LTR resizer. Unfortunately, this code renders the RTL
resizer image at an incorrect position on Mac and Linux. This change uses the
correct formula to calculate the position of an RTL resizer.

Source/WebCore:

Test: platform/chromium/scrollbars/rtl-resizer-position.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::drawPlatformResizerImage):

LayoutTests:

  • platform/chromium/platform/chromium/scrollbars: Added.
  • platform/chromium/platform/chromium/scrollbars/rtl-resizer-position-expected.png: Added.
  • platform/chromium/platform/chromium/scrollbars/rtl-resizer-position-expected.txt: Added.
  • platform/chromium/scrollbars/rtl-resizer-position.html: Added.
10:14 Changeset [116434] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Memory leak in DRT EventSender.cpp
https://bugs.webkit.org/show_bug.cgi?id=85886

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-08
Reviewed by Martin Robinson.

Fix a memory leak in gdkModifersFromJSValue() by using JSRetainPtr for
JSString created with JSStringCreateWithUTF8CString.

  • DumpRenderTree/gtk/EventSender.cpp:

(gdkModifersFromJSValue):

10:06 Changeset [116433] by tony@chromium.org
  • 3 edits
    2 adds in trunk/Source/WebKit/chromium

[chromium] move event_listener_unittest to webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=85836

Reviewed by James Robinson.

Porting the test from src/webkit/tools/test_shell/event_listener_unittest.cc.
All I did was change the style and use the FrameTestHelper to load the file.

  • WebKit.gyp: Exclude file in components build.
  • WebKit.gypi: Add new file.
  • tests/EventListenerTest.cpp: Added.

(WebKit):
(TestWebDOMEventListener):
(WebKit::TestWebDOMEventListener::TestWebDOMEventListener):
(WebKit::TestWebDOMEventListener::~TestWebDOMEventListener):
(WebKit::TestWebDOMEventListener::eventCount):
(WebKit::TestWebDOMEventListener::eventAt):
(WebKit::TestWebDOMEventListener::clearEvents):
(WebDOMEventListenerTest):
(WebKit::WebDOMEventListenerTest::WebDOMEventListenerTest):
(WebKit::WebDOMEventListenerTest::SetUp):
(WebKit::WebDOMEventListenerTest::TearDown):
(WebKit::WebDOMEventListenerTest::mainFrame):
(WebKit::WebDOMEventListenerTest::document):
(WebKit::WebDOMEventListenerTest::executeScript):
(WebKit::WebDOMEventListenerTest::GetNodeID):
(WebKit::TEST_F):

  • tests/data/listener/mutation_event_listener.html: Added.
10:01 Changeset [116432] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] glib dependency needs to be updated in jhbuild
https://bugs.webkit.org/show_bug.cgi?id=85878

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-08
Reviewed by Martin Robinson.

Bump glib version from 2.31.8 to 2.32.2 in jhbuild.modules. This
addresses flakiness in media tests due to possible deadlock with the
following output on stderr:
GStreamer-WARNING : wrong STREAM_LOCK count 0

The bug was fixed upstream by:
http://git.gnome.org/browse/glib/commit/?id=265f265c677bc5399dbb1cfa449cb4b915a6459f

  • efl/jhbuild.modules:
09:57 Changeset [116431] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip failing tests.

  • platform/qt-5.0/Skipped:
09:27 Changeset [116430] by kling@webkit.org
  • 53 edits in trunk/Source/WebCore

Element: isURLAttribute() should take a const Attribute&.
<http://webkit.org/b/85890>

Reviewed by Anders Carlsson.

Change isURLAttribute(Attribute*) to isURLAttribute(const Attribute&) to enforce
the fact that the Attribute can't be null, and shouldn't be mutated, at compile-time.
Also sprinkle OVERRIDE while we're at it.

  • dom/Element.cpp:

(WebCore::Element::getURLAttribute):
(WebCore::Element::getNonEmptyURLAttribute):

  • dom/Element.h:

(WebCore::Element::isURLAttribute):

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendQuotedURLAttributeValue):
(WebCore::MarkupAccumulator::appendAttribute):

  • editing/markup.cpp:

(WebCore::completeURLs):

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::isURLAttribute):

  • html/HTMLAnchorElement.h:
  • html/HTMLBaseElement.cpp:

(WebCore::HTMLBaseElement::isURLAttribute):

  • html/HTMLBaseElement.h:
  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::isURLAttribute):

  • html/HTMLBodyElement.h:
  • html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::isURLAttribute):

  • html/HTMLButtonElement.h:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::isURLAttribute):

  • html/HTMLElement.h:
  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::isURLAttribute):

  • html/HTMLEmbedElement.h:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::isURLAttribute):

  • html/HTMLFormElement.h:
  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::isURLAttribute):

  • html/HTMLFrameElementBase.h:

(HTMLFrameElementBase):

  • html/HTMLHtmlElement.cpp:

(WebCore::HTMLHtmlElement::isURLAttribute):

  • html/HTMLHtmlElement.h:
  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::isURLAttribute):

  • html/HTMLImageElement.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::isURLAttribute):

  • html/HTMLInputElement.h:
  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::isURLAttribute):

  • html/HTMLLinkElement.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::isURLAttribute):

  • html/HTMLMediaElement.h:
  • html/HTMLModElement.cpp:

(WebCore::HTMLModElement::isURLAttribute):

  • html/HTMLModElement.h:
  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::isURLAttribute):

  • html/HTMLObjectElement.h:
  • html/HTMLParamElement.cpp:

(WebCore::HTMLParamElement::isURLAttribute):

  • html/HTMLParamElement.h:
  • html/HTMLQuoteElement.cpp:

(WebCore::HTMLQuoteElement::isURLAttribute):

  • html/HTMLQuoteElement.h:
  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::isURLAttribute):

  • html/HTMLScriptElement.h:
  • html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::isURLAttribute):

  • html/HTMLSourceElement.h:
  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::isURLAttribute):

  • html/HTMLTableCellElement.h:
  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::isURLAttribute):

  • html/HTMLTableElement.h:
  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::isURLAttribute):

  • html/HTMLTrackElement.h:
  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::isURLAttribute):

  • html/HTMLVideoElement.h:
  • svg/SVGScriptElement.cpp:

(WebCore::SVGScriptElement::isURLAttribute):

  • svg/SVGScriptElement.h:
09:21 Changeset [116429] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Over-scroll image should be tiled
https://bugs.webkit.org/show_bug.cgi?id=85860

Patch by Andrew Lo <anlo@rim.com> on 2012-05-08
Reviewed by Rob Buis.

Implement tiling for over-scroll image if image dimension don't match
the surface dimensions.

  • Api/BackingStore.cpp:

(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::ensureOverScrollImage):
(BlackBerry::WebKit::BackingStorePrivate::paintDefaultBackground):

  • Api/BackingStore_p.h:

(BackingStorePrivate):

08:53 Changeset [116428] by ossy@webkit.org
  • 41 edits
    4 adds in trunk/LayoutTests

[Qt] Unreviewed gardening, unskip now passing tests, update platform specific expected files.

  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/qt/fast/block/float/016-expected.png:
  • platform/qt/fast/css/border-solid-single-edge-antialias-expected.txt: Added.
  • platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
  • platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
  • platform/qt/fast/dom/HTMLMeterElement/meter-element-expected.png:
  • platform/qt/fast/dom/HTMLMeterElement/meter-element-expected.txt:
  • platform/qt/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
  • platform/qt/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
  • platform/qt/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png:
  • platform/qt/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
  • platform/qt/fast/dom/HTMLMeterElement/meter-styles-expected.png:
  • platform/qt/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
  • platform/qt/fast/js/constructor-length-expected.txt: Added.
  • platform/qt/fast/repaint/scale-page-shrink-expected.png: Added.
  • platform/qt/fast/repaint/scale-page-shrink-expected.txt: Added.
  • platform/qt/fast/table/027-expected.png:
  • platform/qt/fast/table/027-expected.txt:
  • platform/qt/fast/table/027-vertical-expected.png:
  • platform/qt/fast/table/027-vertical-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug14929-expected.png:
  • platform/qt/tables/mozilla/bugs/bug14929-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2123-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2123-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2509-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2509-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug27038-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug27038-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug27038-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug27038-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2947-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2947-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug34176-expected.png:
  • platform/qt/tables/mozilla/bugs/bug34176-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug44505-expected.png:
  • platform/qt/tables/mozilla/bugs/bug44505-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug59252-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug59252-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug7243-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
  • platform/qt/test_expectations.txt:
08:46 Changeset [116427] by schenney@chromium.org
  • 2 edits in trunk/Source/WebCore

Shrink ElementAttributeData by factoring out Attr object count.
https://bugs.webkit.org/show_bug.cgi?id=85825

Unreviewed build fix.

  • dom/ElementAttributeData.cpp:

(WebCore::attrListForElement): Was returning false instead of 0 for a pointer value. Now returns 0.

08:27 Changeset [116426] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][DRT] fast/layers/video-layer.html needs rebaseline after bug85602 landed
https://bugs.webkit.org/show_bug.cgi?id=85873

Unreviewed, EFL gardening.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-08

  • platform/efl/fast/layers/video-layer-expected.txt:
08:24 Changeset [116425] by kareng@chromium.org
  • 1 add in branches/chromium/1130/codereview.settings

adding codereview.settings for easy drovering

08:23 Changeset [116424] by kareng@chromium.org
  • 1 copy in branches/chromium/1130

creating chromium m20 branch

08:20 Changeset [116423] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

Element: Merge idAttributeChanged() into attributeChanged().
<http://webkit.org/b/85885>

Reviewed by Antti Koivisto.

No new tests, code churn only.

  • dom/Element.h:
  • dom/Element.cpp:

(WebCore::Element::attributeChanged): There's no need for this to be a standalone function anymore.

07:59 Changeset [116422] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[WK2] Integrate Page Visibility state change and WK2 Suspend/Resume API
https://bugs.webkit.org/show_bug.cgi?id=85650

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2012-05-08
Reviewed by Kenneth Rohde Christiansen.

This patch uses state changes of the Page Visibility API to trigger the
automatic suspension/resume of animations on the WebPage and its main frame,
in the same fashion of what is used by the Suspend/Resume API of WebKit2.
By telling the WebPage it will move off/on the screen and the FrameView to
hide/show, this patch is suspending/resuming animations (animated painting)
but not timers and other active DOM objects.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setVisibilityState):

07:42 Changeset [116421] by commit-queue@webkit.org
  • 2 edits
    7 adds in trunk/LayoutTests

[EFL] [DRT] Add baselines for the tests which are missing expected results
https://bugs.webkit.org/show_bug.cgi?id=85875

Unreviewed, add EFL baselines for the tests which are missing expected
results.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-08

  • platform/efl/fast/css/first-line-text-decoration-expected.png: Added.
  • platform/efl/fast/css/first-line-text-decoration-expected.txt: Added.
  • platform/efl/fast/css/first-line-text-decoration-inherited-from-parent-expected.png: Added.
  • platform/efl/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt: Added.
  • platform/efl/fast/images/png-suite/test-expected.png: Added.
  • platform/efl/fast/images/png-suite/test-expected.txt: Added.
  • platform/efl/test_expectations.txt:
07:12 Changeset [116420] by kenneth@webkit.org
  • 3 edits
    1 add in trunk/Source/WebKit2

[Qt] Add QML/WK2 evaluateJavaScript experimental API
https://bugs.webkit.org/show_bug.cgi?id=85496

Reviewed by Simon Hausmann.

This is an initial patch adding support for strings,
numbers and bools as return values.

Test: qmltests/WebView/tst_evaluateJavaScript.qml

  • UIProcess/API/qt/qquickwebview.cpp:

(JSCallbackClosure):
(toQString):
(toQJSValue):
(buildQJSValue):
(javaScriptCallback):
(QQuickWebViewExperimental::evaluateJavaScript):
(QQuickWebView::runJavaScriptInMainFrame):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_evaluateJavaScript.qml: Added.
07:09 Changeset [116419] by kling@webkit.org
  • 4 edits in trunk/Source/WebCore

Shrink ElementAttributeData by factoring out Attr object count.
<http://webkit.org/b/85825>

Reviewed by Antti Koivisto.

Stop tracking the number of Attr objects that point to a given Element on the
Element itself and manage this by having a global hashmap of Element => AttrList,
where AttrList is a vector of (pointers to) the associated Attr objects.

This shrinks ElementAttributeData by one integer, effectively reducing memory
consumption by ~530kB when viewing the full HTML5 spec at <http://whatwg.org/c>.

  • dom/ElementAttributeData.h:

(ElementAttributeData):

Remove m_attrCount...

  • dom/Node.h:

(WebCore::Node::hasAttrList):
(WebCore::Node::setHasAttrList):
(WebCore::Node::clearHasAttrList):

...replacing it with a Node flag that tells us whether there's an Attr
object map for this Node (only applies to Elements.)

  • dom/ElementAttributeData.cpp:

(WebCore::attrListMap):
(WebCore::attrListForElement):
(WebCore::ensureAttrListForElement):
(WebCore::removeAttrListForElement):
(WebCore::ElementAttributeData::attrIfExists):
(WebCore::ElementAttributeData::ensureAttr):
(WebCore::ElementAttributeData::setAttr):
(WebCore::ElementAttributeData::removeAttr):
(WebCore::ElementAttributeData::detachAttributesFromElement):

Map Element => per-Element AttrList in a global hash.

07:02 Changeset [116418] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[Blackberry] remove m_isRequestedByPlugin in ResourceRequest
https://bugs.webkit.org/show_bug.cgi?id=84559

Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-05-08
Reviewed by Antonio Gomes.

Source/WebCore:

ResourceRequest is a network level abstraction, and it should
not know anything about web concepts such as plug-ins, and Blackberry
does not need m_isRequestedByPlugin any longer, So clean up all related
code.

Tested on a website of http://edition.cnn.com, a new window should be
opened only when user has a singe tap gesture on a plugin element.

  • platform/network/blackberry/ResourceRequest.h:

(WebCore::ResourceRequest::ResourceRequest):
(ResourceRequest):
(CrossThreadResourceRequestData):

  • platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::ResourceRequest::doPlatformCopyData):
(WebCore::ResourceRequest::doPlatformAdopt):

Source/WebKit/blackberry:

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNewWindowAction):

07:00 Changeset [116417] by alexis.menard@openbossa.org
  • 4 edits in trunk

[Qt] Unbreak debugging of WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=85839

Reviewed by Simon Hausmann.

Source/WebKit2:

When you attach GDB to a running process, it stops it.
http://trac.webkit.org/changeset/115958 introduced a pause()
call to wait the debugger to be attached to then continue
the execution of the WebProcess. Unfortunately the pause()
function does not return unless a signal handler is called.
This patch introduce an event handler to exit from the paused
state when the debugger send the signal SIGCONT. The old code
works with older version of GDB (<7.0) but not with newer
versions where the behavior of pause() is correct.

  • qt/MainQt.cpp:

(sigcontHandler):
(main):

Tools:

When you attach GDB to a running process, it stops it.
http://trac.webkit.org/changeset/115958 introduced a pause()
call to wait the debugger to be attached to then continue
the execution of the WebProcess. Unfortunately the pause()
function does not return unless a signal handler is called.
This patch introduce an event handler to exit from the paused
state when the debugger send the signal SIGCONT. The old code
works with older version of GDB (<7.0) but not with newer
versions where the behavior of pause() is correct.

  • WebKitTestRunner/qt/main.cpp:

(sigcontHandler):
(main):

06:57 Changeset [116416] by commit-queue@webkit.org
  • 6 edits in trunk

[EFL][DRT] EFL's DRT does not fully support page visibility
https://bugs.webkit.org/show_bug.cgi?id=85032

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-08
Reviewed by Antonio Gomes.

Tools:

  • DumpRenderTree/LayoutTestController.cpp:

(resetPageVisibilityCallback): Fix incorrect argumentCount check.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues): Properly
reset page visibility setting between tests.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setPageVisibility): Add support for "preview"
visibility state.

LayoutTests:

Unskip remaining page visibility test cases now that the functionality
is fully implemented in EFL port.

  • platform/efl/Skipped:
06:39 Changeset [116415] by gavinp@chromium.org
  • 2 edits in trunk/Tools

[webkit-patch] Return meaningful results from single-result queries.
https://bugs.webkit.org/show_bug.cgi?id=85367

Reviewed by Dirk Pranke.

Sometimes a quicksearch returns a single result by just redirecting to the page for that single
bug. This patch hacks around that by noticing the redirect target is a single page, and constructing
a result list consisting of that one bug.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(BugzillaQueries._fetch_bugs_from_advanced_query):

06:37 Changeset [116414] by gavinp@chromium.org
  • 5 edits
    4 adds in trunk/Tools

[webkit-patch] Add new chrome-channels command to track down current chrome release channels for a committed bug.
https://bugs.webkit.org/show_bug.cgi?id=85368

Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/config/urls.py:
  • Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:

(MockBugzillaQueries.fetch_bugs_matching_quicksearch):

  • Scripts/webkitpy/common/net/omahaproxy.py: Added.

(OmahaProxy):
(OmahaProxy.init):
(OmahaProxy.set_url):
(OmahaProxy._json_url):
(OmahaProxy._get_json):
(OmahaProxy.get_revisions):

  • Scripts/webkitpy/common/net/omahaproxy_unittest.py: Added.

(MockOmahaProxy):
(MockOmahaProxy.init):
(OmahaProxyTest):
(OmahaProxyTest.test_get_revisions):

  • Scripts/webkitpy/tool/commands/init.py:
  • Scripts/webkitpy/tool/commands/bugsearch.py:

(BugSearch):

  • Scripts/webkitpy/tool/commands/chromechannels.py: Added.

(ChromeChannels):
(init):
(execute):

  • Scripts/webkitpy/tool/commands/chromechannels_unittest.py: Added.

(MockOmahaProxy):
(MockOmahaProxy.get_revisions):
(TestableChromeChannels):
(TestableChromeChannels.init):
(ChromeChannelsTest):
(ChromeChannelsTest.test_single_bug):
(ChromeChannelsTest.test_with_query):

06:32 Changeset [116413] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Update documentation of ewk_frame_contents_alternate_set and ewk_view_zoom_range_set.
https://bugs.webkit.org/show_bug.cgi?id=84588

Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-05-08
Reviewed by Eric Seidel.

In ewk_frame_contents_alternate_set, param unreachableUri is required, must not be 0.
In ewk_view_zoom_range_set, function returns EINA_FALSE only on failure,
not when zoom range is changed.

  • ewk/ewk_frame.h:
  • ewk/ewk_view.h:
06:29 Changeset [116412] by carlosgc@webkit.org
  • 2 edits in trunk/Tools

Unreviewed. Fix GTK+ unit tests.

  • gtk/common.py:

(pkg_config_file_variable):

03:04 Changeset [116411] by ossy@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed. Remove an accidentally committed file.

  • platform/qt/Skipped.orig: Removed.
02:55 Changeset [116410] by carlosgc@webkit.org
  • 3 edits
    1 copy in trunk/Tools

[GTK] Google tests that time out are leaked
https://bugs.webkit.org/show_bug.cgi?id=84973

Reviewed by Philippe Normand.

Move Tools/Scripts/run-gtk-tests to Tools/gtk/run-api-tests
leaving run-gtk-tests as simple wrapper that runs run-api-tests in
a jhbuild environment when jhbuild is available.

  • Scripts/run-gtk-tests: Run Tools/gtk/run-api-tests directly or

with jhbuild if present.

  • gtk/common.py:

(pkg_config_file_variable): Generic function to get a variable
from a pkg-config file.
(prefix_of_pkg_config_file): Use pkg_config_file_variable with 'prefix'.

  • gtk/run-api-tests: Copied from Tools/Scripts/run-gtk-tests.

(TestRunner.init): Use common.build_path() to get the programs path.
(TestRunner._lookup_atspi2_binary): Use
common.pkg_config_file_variable() to get the 'exec_prefix'.
(TestRunner._start_accessibility_daemons): Use subprocess.Popen()
directly instead of helper _create_process that has been removed.
(TestRunner._setup_testing_environment): Use subprocess.Popen()
directly instead of helper _create_process that has been
removed. Use common.top_level_path() and common.build_path()
instead of custom methods that have been removed too.
(TestRunner._run_test_command): Use subprocess.Popen() directly
instead of helper _create_process that has been removed.

02:50 Changeset [116409] by ossy@webkit.org
  • 49 edits
    4 copies
    115 adds in trunk/LayoutTests

[Qt] Unskip now passing tests and update platform specific expected files.

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-05-08
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
  • platform/qt/Skipped.orig: Copied from LayoutTests/platform/qt/Skipped.
  • platform/qt/editing/pasteboard/paste-text-014-expected.png: Added.
  • platform/qt/fast/block/float/editable-text-overlapping-float-expected.png: Added.
  • platform/qt/fast/block/float/editable-text-overlapping-float-expected.txt:
  • platform/qt/fast/block/float/multiple-float-positioning-expected.png: Added.
  • platform/qt/fast/block/float/multiple-float-positioning-expected.txt:
  • platform/qt/fast/block/margin-collapse/103-expected.png: Added.
  • platform/qt/fast/block/margin-collapse/103-expected.txt: Added.
  • platform/qt/fast/block/positioning/absolute-in-inline-ltr-2-expected.png: Added.
  • platform/qt/fast/block/positioning/absolute-in-inline-ltr-2-expected.txt:
  • platform/qt/fast/block/positioning/absolute-in-inline-rtl-2-expected.png: Added.
  • platform/qt/fast/block/positioning/absolute-in-inline-rtl-2-expected.txt:
  • platform/qt/fast/block/positioning/absolute-in-inline-rtl-3-expected.png: Added.
  • platform/qt/fast/block/positioning/absolute-in-inline-rtl-3-expected.txt:
  • platform/qt/fast/block/positioning/auto/006-expected.png: Added.
  • platform/qt/fast/block/positioning/auto/006-expected.txt:
  • platform/qt/fast/css/apple-prefix-expected.png: Added.
  • platform/qt/fast/css/apple-prefix-expected.txt:
  • platform/qt/fast/css/color-correction-backgrounds-and-text-expected.png: Added.
  • platform/qt/fast/css/color-correction-backgrounds-and-text-expected.txt: Added.
  • platform/qt/fast/css/ex-after-font-variant-expected.png: Added.
  • platform/qt/fast/css/ex-after-font-variant-expected.txt:
  • platform/qt/fast/css/percentage-non-integer-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/selection-clear-expected.png.
  • platform/qt/fast/css/percentage-non-integer-expected.txt:
  • platform/qt/fast/css/positioned-overflow-scroll-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/selection-clear-expected.png.
  • platform/qt/fast/css/positioned-overflow-scroll-expected.txt: Added.
  • platform/qt/fast/dom/HTMLImageElement/image-alt-text-expected.png: Added.
  • platform/qt/fast/dom/HTMLImageElement/image-alt-text-expected.txt:
  • platform/qt/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png: Added.
  • platform/qt/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
  • platform/qt/fast/dynamic/008-expected.png: Added.
  • platform/qt/fast/dynamic/008-expected.txt:
  • platform/qt/fast/forms/box-shadow-override-expected.png: Added.
  • platform/qt/fast/forms/box-shadow-override-expected.txt:
  • platform/qt/fast/forms/disabled-select-change-index-expected.png: Added.
  • platform/qt/fast/forms/disabled-select-change-index-expected.txt:
  • platform/qt/fast/forms/file/file-input-direction-expected.png: Added.
  • platform/qt/fast/forms/file/file-input-direction-expected.txt:
  • platform/qt/fast/forms/file/file-input-disabled-expected.png: Added.
  • platform/qt/fast/forms/file/file-input-disabled-expected.txt:
  • platform/qt/fast/forms/form-element-geometry-expected.png: Added.
  • platform/qt/fast/forms/form-element-geometry-expected.txt:
  • platform/qt/fast/forms/input-disabled-color-expected.png: Added.
  • platform/qt/fast/forms/input-disabled-color-expected.txt:
  • platform/qt/fast/forms/input-text-click-outside-expected.png: Added.
  • platform/qt/fast/forms/input-text-click-outside-expected.txt: Added.
  • platform/qt/fast/forms/input-text-scroll-left-on-blur-expected.png: Added.
  • platform/qt/fast/forms/input-text-scroll-left-on-blur-expected.txt: Added.
  • platform/qt/fast/forms/negativeLineHeight-expected.png: Added.
  • platform/qt/fast/forms/negativeLineHeight-expected.txt:
  • platform/qt/fast/forms/placeholder-pseudo-style-expected.png: Added.
  • platform/qt/fast/forms/placeholder-pseudo-style-expected.txt: Added.
  • platform/qt/fast/forms/range/slider-padding-expected.png: Added.
  • platform/qt/fast/forms/range/slider-padding-expected.txt: Added.
  • platform/qt/fast/forms/tabbing-input-iframe-expected.png: Added.
  • platform/qt/fast/forms/tabbing-input-iframe-expected.txt: Added.
  • platform/qt/fast/forms/textAreaLineHeight-expected.png: Added.
  • platform/qt/fast/forms/textAreaLineHeight-expected.txt: Added.
  • platform/qt/fast/forms/textarea-align-expected.png: Added.
  • platform/qt/fast/forms/textarea-align-expected.txt:
  • platform/qt/fast/forms/textarea-scrollbar-expected.png: Added.
  • platform/qt/fast/forms/textarea-scrollbar-expected.txt: Added.
  • platform/qt/fast/forms/textarea-scrolled-type-expected.png: Added.
  • platform/qt/fast/forms/textarea-scrolled-type-expected.txt: Added.
  • platform/qt/fast/forms/textarea-setinnerhtml-expected.png: Added.
  • platform/qt/fast/forms/textarea-setinnerhtml-expected.txt:
  • platform/qt/fast/inline/inline-borders-with-bidi-override-expected.png: Added.
  • platform/qt/fast/inline/inline-borders-with-bidi-override-expected.txt:
  • platform/qt/fast/invalid/016-expected.png: Added.
  • platform/qt/fast/invalid/016-expected.txt:
  • platform/qt/fast/invalid/missing-end-tag-expected.png: Added.
  • platform/qt/fast/invalid/missing-end-tag-expected.txt: Added.
  • platform/qt/fast/layers/scroll-rect-to-visible-expected.png: Added.
  • platform/qt/fast/layers/scroll-rect-to-visible-expected.txt:
  • platform/qt/fast/overflow/003-expected.png: Added.
  • platform/qt/fast/overflow/003-expected.txt:
  • platform/qt/fast/overflow/clip-rects-fixed-ancestor-expected.png: Added.
  • platform/qt/fast/overflow/clip-rects-fixed-ancestor-expected.txt: Added.
  • platform/qt/fast/overflow/image-selection-highlight-expected.png: Added.
  • platform/qt/fast/overflow/image-selection-highlight-expected.txt:
  • platform/qt/fast/overflow/overflow-rtl-expected.png: Added.
  • platform/qt/fast/overflow/overflow-rtl-expected.txt: Added.
  • platform/qt/fast/overflow/overflow-x-y-expected.png: Added.
  • platform/qt/fast/overflow/overflow-x-y-expected.txt: Added.
  • platform/qt/fast/overflow/scrollRevealButton-expected.png: Added.
  • platform/qt/fast/overflow/scrollRevealButton-expected.txt: Added.
  • platform/qt/fast/overflow/unreachable-overflow-rtl-bug-expected.png: Added.
  • platform/qt/fast/overflow/unreachable-overflow-rtl-bug-expected.txt:
  • platform/qt/fast/parser/entity-comment-in-textarea-expected.png: Added.
  • platform/qt/fast/parser/entity-comment-in-textarea-expected.txt: Added.
  • platform/qt/fast/parser/open-comment-in-textarea-expected.png: Added.
  • platform/qt/fast/parser/open-comment-in-textarea-expected.txt: Added.
  • platform/qt/fast/repaint/button-spurious-layout-hint-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/selection-clear-expected.png.
  • platform/qt/fast/repaint/button-spurious-layout-hint-expected.txt: Added.
  • platform/qt/fast/repaint/control-clip-expected.png: Added.
  • platform/qt/fast/repaint/control-clip-expected.txt:
  • platform/qt/fast/repaint/flexible-box-overflow-expected.png: Added.
  • platform/qt/fast/repaint/flexible-box-overflow-expected.txt: Added.
  • platform/qt/fast/repaint/flexible-box-overflow-horizontal-expected.png: Added.
  • platform/qt/fast/repaint/flexible-box-overflow-horizontal-expected.txt: Added.
  • platform/qt/fast/repaint/focus-ring-expected.png: Added.
  • platform/qt/fast/repaint/focus-ring-expected.txt: Added.
  • platform/qt/fast/repaint/inline-block-overflow-expected.png: Added.
  • platform/qt/fast/repaint/inline-block-overflow-expected.txt: Added.
  • platform/qt/fast/repaint/inline-outline-repaint-expected.png: Added.
  • platform/qt/fast/repaint/inline-outline-repaint-expected.txt:
  • platform/qt/fast/repaint/layer-child-outline-expected.png: Added.
  • platform/qt/fast/repaint/layer-child-outline-expected.txt: Added.
  • platform/qt/fast/repaint/layer-outline-expected.png: Added.
  • platform/qt/fast/repaint/layer-outline-expected.txt: Added.
  • platform/qt/fast/repaint/layer-outline-horizontal-expected.png: Added.
  • platform/qt/fast/repaint/layer-outline-horizontal-expected.txt: Added.
  • platform/qt/fast/repaint/list-marker-expected.png: Added.
  • platform/qt/fast/repaint/list-marker-expected.txt: Added.
  • platform/qt/fast/repaint/selection-after-delete-expected.png: Added.
  • platform/qt/fast/repaint/selection-after-delete-expected.txt:
  • platform/qt/fast/repaint/selection-after-remove-expected.png: Added.
  • platform/qt/fast/repaint/selection-after-remove-expected.txt:
  • platform/qt/fast/repaint/selection-clear-expected.png:
  • platform/qt/fast/repaint/selection-clear-expected.txt:
  • platform/qt/fast/repaint/selection-gap-overflow-scroll-expected.png: Added.
  • platform/qt/fast/repaint/selection-gap-overflow-scroll-expected.txt: Added.
  • platform/qt/fast/repaint/text-selection-rect-in-overflow-2-expected.png: Added.
  • platform/qt/fast/repaint/text-selection-rect-in-overflow-2-expected.txt: Added.
  • platform/qt/fast/repaint/text-selection-rect-in-overflow-expected.png: Added.
  • platform/qt/fast/repaint/text-selection-rect-in-overflow-expected.txt: Added.
  • platform/qt/fast/repaint/text-shadow-expected.png: Added.
  • platform/qt/fast/repaint/text-shadow-expected.txt: Added.
  • platform/qt/fast/repaint/text-shadow-horizontal-expected.png: Added.
  • platform/qt/fast/repaint/text-shadow-horizontal-expected.txt: Added.
  • platform/qt/fast/replaced/border-radius-clip-expected.png: Added.
  • platform/qt/fast/replaced/border-radius-clip-expected.txt: Added.
  • platform/qt/fast/replaced/width100percent-textarea-expected.png: Added.
  • platform/qt/fast/replaced/width100percent-textarea-expected.txt: Added.
  • platform/qt/fast/table/003-expected.png: Added.
  • platform/qt/fast/table/003-expected.txt:
  • platform/qt/fast/table/cell-pref-width-invalidation-expected.png: Added.
  • platform/qt/fast/table/cell-pref-width-invalidation-expected.txt:
  • platform/qt/fast/text/atsui-small-caps-punctuation-size-expected.png: Added.
  • platform/qt/fast/text/atsui-small-caps-punctuation-size-expected.txt:
  • platform/qt/fast/text/basic/003-expected.png: Added.
  • platform/qt/fast/text/basic/003-expected.txt:
  • platform/qt/fast/text/cg-vs-atsui-expected.png: Added.
  • platform/qt/fast/text/cg-vs-atsui-expected.txt:
  • platform/qt/fast/text/complex-text-opacity-expected.png: Added.
  • platform/qt/fast/text/complex-text-opacity-expected.txt: Added.
  • platform/qt/fast/text/embed-at-end-of-pre-wrap-line-expected.png: Added.
  • platform/qt/fast/text/embed-at-end-of-pre-wrap-line-expected.txt: Added.
  • platform/qt/fast/text/large-text-composed-char-expected.png: Added.
  • platform/qt/fast/text/large-text-composed-char-expected.txt:
  • platform/qt/fast/text/letter-spacing-negative-opacity-expected.png: Added.
  • platform/qt/fast/text/letter-spacing-negative-opacity-expected.txt:
  • platform/qt/fast/text/line-breaks-after-white-space-expected.png: Added.
  • platform/qt/fast/text/line-breaks-after-white-space-expected.txt:
  • platform/qt/fast/text/whitespace/normal-after-nowrap-breaking-expected.png: Added.
  • platform/qt/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
  • platform/qt/fast/text/whitespace/pre-break-word-expected.png: Added.
  • platform/qt/fast/text/whitespace/pre-break-word-expected.txt:
  • platform/qt/fast/text/whitespace/pre-wrap-line-test-expected.png: Added.
  • platform/qt/fast/text/whitespace/pre-wrap-line-test-expected.txt:
  • platform/qt/fast/text/whitespace/pre-wrap-overflow-selection-expected.png: Added.
  • platform/qt/fast/text/whitespace/pre-wrap-overflow-selection-expected.txt:
  • platform/qt/fast/text/word-break-expected.png: Added.
  • platform/qt/fast/text/word-break-expected.txt:
  • platform/qt/fast/xsl/xslt-entity-expected.png: Added.
  • platform/qt/fast/xsl/xslt-entity-expected.txt:
02:43 Changeset [116408] by apavlov@chromium.org
  • 4 edits
    2 adds in trunk

Extra line-breaks added when copying from source.
https://bugs.webkit.org/show_bug.cgi?id=85282

Reviewed by Ryosuke Niwa.

Source/WebCore:

The code used to replace any \n by \r\n, even the one that had a preceding \r, resulting in \r\r\n.
This change introduces a check for the preceding \r when replacing \n's.

Test: platform/win/editing/pasteboard/pasting-crlf-isnt-translated-to-crcrlf-win.html

  • platform/chromium/ClipboardUtilitiesChromium.cpp:

(WebCore::replaceNewlinesWithWindowsStyleNewlines):

  • platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::replaceNewlinesWithWindowsStyleNewlines):

LayoutTests:

  • platform/win/editing/pasteboard/pasting-crlf-isnt-translated-to-crcrlf-win-expected.txt: Added.
  • platform/win/editing/pasteboard/pasting-crlf-isnt-translated-to-crcrlf-win.html: Added.
02:28 Changeset [116407] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

[EFL] [DRT] Clear extra views before setting a blank page
https://bugs.webkit.org/show_bug.cgi?id=85608

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-08
Reviewed by Kenneth Rohde Christiansen.

We need to clear the extra views before setting a blank page,
otherwise it will cause more events interactions and sometimes
trigger a unload(). This was causing frame-crash-with-page-cache.html
to leak events to the next test causing any subsequent test to
fail.

  • DumpRenderTree/efl/DumpRenderTree.cpp:

(runTest):

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::clearExtraViews):
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

  • DumpRenderTree/efl/DumpRenderTreeChrome.h:

(DumpRenderTreeChrome):

02:04 Changeset [116406] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Gardening after 116361. Updated expected result.

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-05-08
Reviewed by Csaba Osztrogonác.

  • platform/qt/fast/js/switch-behaviour-expected.txt:
02:00 Changeset [116405] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

OS(ANDROID) JNI AttachCurrentThread take JNIEnv as a parameter, not void
https://bugs.webkit.org/show_bug.cgi?id=85869

Reviewed by Eric Seidel.

According to
http://docs.oracle.com/javase/1.5.0/docs/guide/jni/spec/invocation.html,
AttachCurrentThread takes a JNIEnv rather than a void. Apparently,
most implementations actually take a void. The OS(ANDROID)
implementation, however, actually takes an JNIEnv
. This patch
introduces a typedef to give each implementation what it desires.

  • bridge/jni/JNIUtility.cpp:

(JSC::Bindings::getJNIEnv):

01:59 Changeset [116404] by ossy@webkit.org
  • 5 edits in trunk/LayoutTests

Unreviewed gardening. Remove tests from test expectations and
from a Skipped list, because they were disabled by r94327.

  • platform/efl/Skipped:
  • platform/gtk/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
01:42 Changeset [116403] by kbalazs@webkit.org
  • 15 edits in trunk

[Qt] X11 plugins need to be reworked for Qt5+WK1
https://bugs.webkit.org/show_bug.cgi?id=80691

Reviewed by Simon Hausmann.

.:

Implement basic windowless plugin support with Qt5.

  • Source/api.pri: Need private API's to be able

to use QApplicationPrivate::windowForWidget.

Source/WebCore:

Implement basic windowless plugin support with Qt5.
The solution is the same that has been chosen for
WebKit2. We get the content drawed by the plugin
from the X server as an image, create a QImage
from it and paint it to the window surface with QPainter.
Performance is sufficient for basic video playback.

No new tests, covered by existing plugin tests.

  • Target.pri:
  • WebCore.pri:
  • platform/qt/QWebPageClient.h:

(QWebPageClient):

  • plugins/PluginView.h:

(PluginView):

  • plugins/qt/PluginPackageQt.cpp:

(WebCore::PluginPackage::isPluginBlacklisted):
Blacklist plugins that are incompatible with Qt5.
The only one I know about currently is skypebuttons
but the list can be extended in the future.
(WebCore):
(WebCore::PluginPackage::load):

  • plugins/qt/PluginViewQt.cpp:

(X11Environment):
(WebCore):
(WebCore::x11Display):
(WebCore::x11Screen):
(WebCore::rootWindowID):
(WebCore::displayDepth):
(WebCore::syncX):
(WebCore::PluginView::platformPageClient): Added a safe
convenience getter for the QWebpageClient.
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::setFocus):
(WebCore::setupGraphicsExposeEvent):
(WebCore::PluginView::paintUsingXPixmap):
(WebCore::setSharedXEventFields):
(WebCore::PluginView::initXEvent):
(WebCore::PluginView::setXKeyEventSpecificFields):
(WebCore::setXButtonEventSpecificFields):
(WebCore::setXMotionEventSpecificFields):
(WebCore::setXCrossingEventSpecificFields):
(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::setParentVisible):
(WebCore::PluginView::platformGetValue):
(WebCore::PluginView::invalidateRect):
(WebCore::getVisualAndColormap):
Refactored this function to make it more clear
what does it actually do.
(WebCore::PluginView::platformStart):
(WebCore::PluginView::platformDestroy):

Source/WebKit/qt:

  • Api/qwebsettings.cpp:

(QWebSettings::enablePersistentStorage):
Build fix for Qt5.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::createPlugin):
Inject the wmode parameter for flash so it will
work in windowless, non-transparent mode which
is the only one we support currently.

  • WebCoreSupport/PageClientQt.cpp:

(WebCore):
(WebCore::QWebPageClient::ownerWindow):
Added a getter for the top level window so the PluginView
can get it without calling into QtWidgets code.

Tools:

Implement basic windowless plugin support with Qt5.

  • qmake/mkspecs/features/features.prf:

Enable NPAPI plugins if X11 libraries are available.

  • qmake/mkspecs/features/functions.prf:

Added a convenience function to determine availability
of X11 libraries.

01:31 Changeset [116402] by antti@apple.com
  • 6 edits in trunk/Source/WebCore

Inline Node::traverseNextNode
https://bugs.webkit.org/show_bug.cgi?id=85844

Reviewed by Ryosuke Niwa.

Inline traverseNextNode and traverseNextSibling to reduce entry/exit overhead and allow better code generation
for many hot loops. Also added separate versions of stayWithin and unscoped cases (the function is
so simple that this seemed like the cleanest way to do it, the most reliable too) and used UNLIKELY for the
end-of-traversal conditions.

The traversal function can show up to ~1% in normal page loading profiles.

run-perf-tests seems to think this is a progression in some subtests though bots will tell for certain.

  • WebCore.exp.in:
  • dom/ContainerNode.h:


Following the existing pattern, function bodies go to ContainerNode.h so they can call parentNode().
(which returns ContainerNode, not Node).

(WebCore::Node::traverseNextNode):
(WebCore):
(WebCore::Node::traverseNextSibling):

  • dom/Node.cpp:

(WebCore):

  • dom/Node.h:

(Node):

00:34 Changeset [116401] by abarth@webkit.org
  • 2 edits in trunk/Source/WTF

[Chromium] Assertions.cpp should work on OS(ANDROID)
https://bugs.webkit.org/show_bug.cgi?id=85867

Reviewed by Eric Seidel.

Some minor ifdefs for OS(ANDROID) on PLATFORM(CHROMIUM).

  • wtf/Assertions.cpp:
00:05 Changeset [116400] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk/Source/WebKit

[BlackBerry] AutofillManager implementation upstream
https://bugs.webkit.org/show_bug.cgi?id=85576

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-05-08
Reviewed by Rob Buis.

Source/WebKit:

Added WebKit/blackberry/WebCoreSupport/AutofillManager.cpp
into building system of BlackBerry porting.

  • PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

RIM PR: 136405
Implemented class AutofillManager to handle the form autofill
interactions.
It listens to text changed notification from text input, searches
autofill database for the suggested autofill candidate value,
and notifies WebPageClient to pop up a context dialog for user;
it also responds to user's choice by autofilling the text input.

  • WebCoreSupport/AutofillManager.cpp: Added.

(WebCore):
(WebCore::AutofillManager::create):
(WebCore::AutofillManager::didChangeInTextField):
(WebCore::AutofillManager::autofillTextField):
(WebCore::AutofillManager::saveTextFields):
(WebCore::AutofillManager::clear):

  • WebCoreSupport/AutofillManager.h: Added.

(WTF):
(WebKit):
(WebCore):
(AutofillManager):
(WebCore::AutofillManager::m_element):

05/07/12:

23:59 Changeset [116399] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chormium] Test expectatino update

  • platform/chromium/test_expectations.txt:
    • multiline-pack.html is failing on all DEBUG bots.
    • filter-repaint-custom-rotated.html fails on Mac.
23:56 Changeset [116398] by pfeldman@chromium.org
  • 5 edits in trunk

Web Inspector: make JavaScriptSourceFrame use breakpoint manager's breakpoints store.
https://bugs.webkit.org/show_bug.cgi?id=85714

Reviewed by Yury Semikhatsky.

It is currently using its own copy of breakpoints which is not necessary.

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager):
(WebInspector.BreakpointManager.prototype.restoreBreakpoints):
(WebInspector.BreakpointManager.prototype.setBreakpoint):
(WebInspector.BreakpointManager.prototype._innerSetBreakpoint):
(WebInspector.BreakpointManager.prototype.findBreakpoint):
(WebInspector.BreakpointManager.prototype.reset):
(WebInspector.BreakpointManager.prototype._debuggerReset):
(WebInspector.BreakpointManager.prototype._breakpointResolved):
(WebInspector.BreakpointManager.prototype._uiLocationAdded):
(WebInspector.BreakpointManager.prototype._uiLocationRemoved):
(WebInspector.BreakpointManager.Breakpoint.prototype._breakpointStorageId):
(WebInspector.BreakpointManager.Storage.prototype._restoreBreakpoints):
(set WebInspector.BreakpointManager.Storage.Item):

  • inspector/front-end/JavaScriptSource.js:

(WebInspector.JavaScriptSource.prototype.consoleMessagesCleared):
(WebInspector.JavaScriptSource.prototype.breakpointStorageId):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype._onContentChanged):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu):
(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype._onMouseDown):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointAdded):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointRemoved):
(WebInspector.JavaScriptSourceFrame.prototype.onTextViewerContentLoaded):
(WebInspector.JavaScriptSourceFrame.prototype._continueToLine):
(WebInspector.JavaScriptSourceFrame.prototype._updateBreakpointsAfterLiveEdit):

23:30 Changeset [116397] by pfeldman@chromium.org
  • 5 edits in trunk

Web Inspector: do not create locations for resolved provisional breakpoints
https://bugs.webkit.org/show_bug.cgi?id=85716

Reviewed by Yury Semikhatsky.

Source/WebCore:

Marked provisional breakpoints as such.

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype._debuggerReset):
(WebInspector.BreakpointManager.prototype._breakpointResolved):

LayoutTests:

  • inspector/debugger/breakpoint-manager-expected.txt:
  • inspector/debugger/breakpoint-manager.html:
22:59 Changeset [116396] by commit-queue@webkit.org
  • 3 edits in trunk

Adjust flakiness dashboard gpu_tests image diff URLs.
https://bugs.webkit.org/show_bug.cgi?id=85423

Patch by Dave Tu <dtu@chromium.org> on 2012-05-07
Reviewed by Ojan Vafai.

  • Tools/TestResultServer/static-dashboards/flakiness_dashboard.js:
22:45 Changeset [116395] by simon.fraser@apple.com
  • 3 edits
    3 adds in trunk

Compositing layers with transformed children not large enough to show contents
https://bugs.webkit.org/show_bug.cgi?id=85855

Source/WebCore:

Reviewed by Dan Bernstein.

r114518 added a code path to RenderLayer::calculateLayerBounds() which
does an early return if the layer has clipping. However, this code
path omitted to take local transforms into account.

Fix is to handle transforms as we do in the non-clipped case.

Test: compositing/geometry/bounds-clipped-composited-child.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateLayerBounds):

LayoutTests:

Reviewed by Dan Bernstein.

Test having composited element with clipped, transformed children.

  • compositing/geometry/bounds-clipped-composited-child-expected.png: Added.
  • compositing/geometry/bounds-clipped-composited-child-expected.txt: Added.
  • compositing/geometry/bounds-clipped-composited-child.html: Added.
22:14 Changeset [116394] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix signed/unsigned mismatch
https://bugs.webkit.org/show_bug.cgi?id=85845

Make literal in assert be unsigned to match comparison on LHS. Avoids
warning on Windows.

Patch by Scott Graham <scottmg@chromium.org> on 2012-05-07
Reviewed by Eric Seidel.

No new tests. No intended functionality change.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::splitColumn):

22:00 Changeset [116393] by kinuko@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed build fix: didOpenFileSystem hides overloaded virtual function

  • src/WorkerAsyncFileSystemChromium.cpp:
21:12 Changeset [116392] by eae@chromium.org
  • 6 edits in trunk/Source/WebCore

Fix performance regression for floats caused by LayoutUnit change
https://bugs.webkit.org/show_bug.cgi?id=85834

Reviewed by Eric Seidel.

Fix performance regression caused by r116009 by disabling the use of
64bit math in FractionalLayoutUnit, simplifying the pixelSnappedMaxX/Y
math, inlining a couple of methods and replacing the literal 0 (zero)
with ZERO_LAYOUT_UNIT.

No new tests, no change in functionality.

  • platform/FractionalLayoutUnit.h:

(WebCore::boundedMultiply):
(WebCore::operator*):
(WebCore::operator/):
Disable the use of 64bit (long long) math in the case where the fraction
is set to 1.

  • platform/graphics/FractionalLayoutRect.h:

(WebCore::FractionalLayoutRect::pixelSnappedMaxX):
(WebCore::FractionalLayoutRect::pixelSnappedMaxY):
Simplify the pixel snapping logic for maxX/maxY.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::isSelfCollapsingBlock):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::computeOverflow):
(WebCore::RenderBlock::clearFloatsIfNeeded):
(WebCore::RenderBlock::paintChildren):
(WebCore::RenderBlock::blockSelectionGap):
(WebCore::RenderBlock::logicalLeftSelectionGap):
(WebCore::RenderBlock::logicalRightSelectionGap):
(WebCore::RenderBlock::computeLogicalLocationForFloat):
(WebCore::RenderBlock::lowestFloatLogicalBottom):
(WebCore::RenderBlock::getClearDelta):
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):
(WebCore::RenderBlock::addFocusRingRects):
(WebCore::RenderBlock::adjustLinePositionForPagination):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::availableLogicalWidthForLine):
(WebCore::RenderBlock::availableLogicalWidthForContent):
(WebCore::RenderBlock::FloatingObject::x):
(WebCore::RenderBlock::FloatingObject::maxX):
(WebCore::RenderBlock::FloatingObject::y):
(WebCore::RenderBlock::FloatingObject::maxY):
(WebCore::RenderBlock::FloatingObject::width):
(WebCore::RenderBlock::FloatingObject::height):
(FloatingObject):
(WebCore::RenderBlock::FloatingObject::pixelSnappedX):
(WebCore::RenderBlock::FloatingObject::pixelSnappedMaxX):
(WebCore::RenderBlock::FloatingObject::pixelSnappedY):
(WebCore::RenderBlock::FloatingObject::pixelSnappedMaxY):
(WebCore::RenderBlock::FloatingObject::pixelSnappedWidth):
(WebCore::RenderBlock::FloatingObject::pixelSnappedHeight):
(WebCore::RenderBlock::RenderBlockRareData::positiveMarginBeforeDefault):
(WebCore::RenderBlock::RenderBlockRareData::negativeMarginBeforeDefault):
(WebCore::RenderBlock::RenderBlockRareData::positiveMarginAfterDefault):
(WebCore::RenderBlock::RenderBlockRareData::negativeMarginAfterDefault):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::accumulateRelativePositionOffsets):
(WebCore::RenderBoxModelObject::offsetLeft):
(WebCore::RenderBoxModelObject::offsetTop):
(WebCore::RenderBoxModelObject::computedCSSPaddingTop):
(WebCore::RenderBoxModelObject::computedCSSPaddingBottom):
(WebCore::RenderBoxModelObject::computedCSSPaddingLeft):
(WebCore::RenderBoxModelObject::computedCSSPaddingRight):
(WebCore::RenderBoxModelObject::computedCSSPaddingBefore):
(WebCore::RenderBoxModelObject::computedCSSPaddingAfter):
(WebCore::RenderBoxModelObject::computedCSSPaddingStart):
(WebCore::RenderBoxModelObject::computedCSSPaddingEnd):

21:11 Changeset [116391] by kinuko@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed build fix: adding missing include.

  • src/AsyncFileSystemChromium.cpp:
21:10 Changeset [116390] by tkent@chromium.org
  • 1 edit
    6 adds in trunk/LayoutTests

[Chromium] Add expectations for first-line-text-decoration.html.

  • platform/chromium-linux/fast/css/first-line-text-decoration-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/first-line-text-decoration-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/first-line-text-decoration-expected.png: Added.
  • platform/chromium-mac/fast/css/first-line-text-decoration-expected.png: Added.
  • platform/chromium-win/fast/css/first-line-text-decoration-expected.png: Added.
  • platform/chromium-win/fast/css/first-line-text-decoration-expected.txt: Added.
20:49 Changeset [116389] by commit-queue@webkit.org
  • 9 edits
    10 adds in trunk

width/height attributes of input element cannot be accessed by JavaScript.
https://bugs.webkit.org/show_bug.cgi?id=70304

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-05-07
Reviewed by Darin Adler.

If the type of input element is image button, width/height attributes should be supported.
These attributes are defined in HTML5 spec.
http://www.w3.org/TR/html5/the-map-element.html#attr-dim-width

Source/WebCore:

Tests: fast/forms/input-width-height-attributes-without-renderer-loaded-image.html

fast/forms/input-width-height-attributes-without-renderer-not-loaded-image.html
fast/forms/input-width-height-attributes-without-renderer.html
fast/forms/input-width-height-attributes.html

  • html/HTMLInputElement.cpp: Add setter/getter functions to query/set width/height of input element.

(WebCore):
(WebCore::HTMLInputElement::height): Gets height of input element.
(WebCore::HTMLInputElement::width): Gets width of input element.
(WebCore::HTMLInputElement::setHeight): Sets height of input element.
(WebCore::HTMLInputElement::setWidth): Sets width of input element.

  • html/HTMLInputElement.h: Add public prototype.

(HTMLInputElement):

  • html/HTMLInputElement.idl: Add width/height attributes.
  • html/ImageInputType.cpp: Add getter functions if the element is an image button.

(WebCore):
(WebCore::ImageInputType::height): Gets height of input element.
(WebCore::ImageInputType::width): Gets width of input element.

  • html/ImageInputType.h: Add prototype.

(ImageInputType):

  • html/InputType.cpp: Add getter functions.

(WebCore::InputType::height): Returns zero.
(WebCore):
(WebCore::InputType::width): Returns zero.

  • html/InputType.h: Add prototype.

(InputType):

LayoutTests:

  • fast/forms/input-width-height-attributes-expected.txt: Added.
  • fast/forms/input-width-height-attributes-without-renderer-expected.txt: Added.
  • fast/forms/input-width-height-attributes-without-renderer-loaded-image-expected.txt: Added.
  • fast/forms/input-width-height-attributes-without-renderer-loaded-image.html: Added.
  • fast/forms/input-width-height-attributes-without-renderer-not-loaded-image-expected.txt: Added.
  • fast/forms/input-width-height-attributes-without-renderer-not-loaded-image.html: Added.
  • fast/forms/input-width-height-attributes-without-renderer.html: Added.
  • fast/forms/input-width-height-attributes.html: Added.
  • fast/forms/resources/green.jpg: Added.
  • fast/forms/resources/image-slow.pl: Added.
20:34 Changeset [116388] by kinuko@chromium.org
  • 39 edits
    1 copy
    1 move
    3 adds in trunk

Support cross-filesystem operations in FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=84135

Reviewed by David Levin.

Source/WebCore:

Currently we pass Entry's fullPath to AsyncFileSystem layer where
we convert the given path to filesystem URL which includes origin and
filesystem type information, but in that way we cannot handle
cross-filesystem operations (e.g. cross-filesystem copy and move)
well since we end up with always attaching the source filesystem's
origin and type information for argument paths.

This patch does:

  • change AsyncFileSystem's operation methods not to take entry paths but complete filesystem URLs.
  • move type and rootURL information from AsyncFileSystem instance into DOMFileSystemBase instance (platform layer to Modules/filesystem layer)
  • move filesystem-type related code in AsyncFileSystemChromium.cpp into DOMFileSystemChromium.cpp, which implements chromioum-specific DOMFileSystem code.
  • move platform/FileSystemType.h into Modules/filesystem/FileSystemType.h.
  • adding FileSystemType.h entry to build files (e.g. WebCore.gypi, WebCore.xcodeproj etc)

Test: fast/filesystem/cross-filesystem-op.html

  • Modules/filesystem/DOMFileSystem.cpp:

(WebCore::DOMFileSystem::create):
(WebCore::DOMFileSystem::DOMFileSystem):
(WebCore::DOMFileSystem::createWriter):
(WebCore::DOMFileSystem::createFile):

  • Modules/filesystem/DOMFileSystem.h:
  • Modules/filesystem/DOMFileSystemBase.cpp:

(WebCore::DOMFileSystemBase::DOMFileSystemBase):
(WebCore::DOMFileSystemBase::createFileSystemURL): Added as an internal
implementation of Entry.toURL().
(WebCore::DOMFileSystemBase::getMetadata):
(WebCore::verifyAndGetDestinationPathForCopyOrMove):
(WebCore::DOMFileSystemBase::move):
(WebCore::DOMFileSystemBase::copy):
(WebCore::DOMFileSystemBase::remove):
(WebCore::DOMFileSystemBase::removeRecursively):
(WebCore::DOMFileSystemBase::getParent):
(WebCore::DOMFileSystemBase::getFile):
(WebCore::DOMFileSystemBase::getDirectory):
(WebCore::DOMFileSystemBase::readDirectory):

  • Modules/filesystem/DOMFileSystemBase.h: Changed to make each

DOMFileSystemBase instance have filesystem type and rootURL (they were
held by AsyncFileSystem previously)
(WebCore::DOMFileSystemBase::create): Changed to take additional parameters.
(WebCore::DOMFileSystemBase::type): Added.(Moved from AsyncFileSystem::type)
(WebCore::DOMFileSystemBase::rootURL): Added.(Moved from AsyncFileSystem::rootURL).

  • Modules/filesystem/DOMFileSystemSync.cpp:

(WebCore::DOMFileSystemSync::create):
(WebCore::DOMFileSystemSync::DOMFileSystemSync):
(WebCore::DOMFileSystemSync::createFile):
(WebCore::DOMFileSystemSync::createWriter):

  • Modules/filesystem/DOMFileSystemSync.h:

(WebCore::DOMFileSystemSync::create):

  • Modules/filesystem/DOMWindowFileSystem.cpp:

(WebCore::DOMWindowFileSystem::webkitRequestFileSystem):
(WebCore::DOMWindowFileSystem::webkitResolveLocalFileSystemURL):

  • Modules/filesystem/EntryBase.cpp:

(WebCore::EntryBase::toURL):

  • Modules/filesystem/FileSystemCallbacks.cpp:

(WebCore::FileSystemCallbacks::create):
(WebCore::FileSystemCallbacks::FileSystemCallbacks):
(WebCore::FileSystemCallbacks::didOpenFileSystem):
(WebCore::ResolveURICallbacks::create):
(WebCore::ResolveURICallbacks::ResolveURICallbacks):
(WebCore::ResolveURICallbacks::didOpenFileSystem):

  • Modules/filesystem/FileSystemCallbacks.h:

(FileSystemCallbacks):
(ResolveURICallbacks):

  • Modules/filesystem/FileSystemType.h: Renamed from Source/WebCore/platform/FileSystemType.h.
  • Modules/filesystem/LocalFileSystem.cpp:

(WebCore::openFileSystem):
(WebCore::LocalFileSystem::readFileSystem):
(WebCore::LocalFileSystem::requestFileSystem):

  • Modules/filesystem/LocalFileSystem.h:
  • Modules/filesystem/WorkerContextFileSystem.cpp:

(WebCore::WorkerContextFileSystem::webkitRequestFileSystem):
(WebCore::WorkerContextFileSystem::webkitRequestFileSystemSync):
(WebCore::WorkerContextFileSystem::webkitResolveLocalFileSystemURL):
(WebCore::WorkerContextFileSystem::webkitResolveLocalFileSystemSyncURL):

  • Modules/filesystem/chromium/DOMFileSystemChromium.cpp: Added for chromium-specific

implementation. Almost all of the code is moved from AsyncFileSystemChromium.
(WebCore::DOMFileSystemBase::isValidType):
(WebCore::DOMFileSystemBase::crackFileSystemURL):
(WebCore::DOMFileSystemBase::supportsToURL):
(WebCore::DOMFileSystemBase::createFileSystemURL):
(WebCore::DOMFileSystemChromium::createIsolatedFileSystem):

  • Modules/filesystem/chromium/DOMFileSystemChromium.h: Added.
  • Modules/filesystem/chromium/DataTransferItemFileSystemChromium.cpp:

(WebCore::DataTransferItemFileSystem::webkitGetAsEntry):

  • Modules/filesystem/chromium/DraggedIsolatedFileSystem.cpp:

(WebCore::DraggedIsolatedFileSystem::getDOMFileSystem):

  • WebCore.gypi:
  • platform/AsyncFileSystem.cpp:

(WebCore::AsyncFileSystem::openFileSystem):

  • platform/AsyncFileSystem.h:

(AsyncFileSystem):
(WebCore::AsyncFileSystem::AsyncFileSystem):

  • platform/AsyncFileSystemCallbacks.h:

(WebCore::AsyncFileSystemCallbacks::didOpenFileSystem):

  • platform/blackberry/AsyncFileSystemBlackBerry.cpp:

(WebCore::AsyncFileSystem::create):
(WebCore::AsyncFileSystem::openFileSystem):
(WebCore::AsyncFileSystemBlackBerry::AsyncFileSystemBlackBerry):
(WebCore::AsyncFileSystemBlackBerry::move):
(WebCore::AsyncFileSystemBlackBerry::copy):
(WebCore::AsyncFileSystemBlackBerry::remove):
(WebCore::AsyncFileSystemBlackBerry::removeRecursively):
(WebCore::AsyncFileSystemBlackBerry::readMetadata):
(WebCore::AsyncFileSystemBlackBerry::createFile):
(WebCore::AsyncFileSystemBlackBerry::createDirectory):
(WebCore::AsyncFileSystemBlackBerry::fileExists):
(WebCore::AsyncFileSystemBlackBerry::directoryExists):
(WebCore::AsyncFileSystemBlackBerry::readDirectory):
(WebCore::AsyncFileSystemBlackBerry::createWriter):
(WebCore::AsyncFileSystemBlackBerry::createSnapshotFileAndReadMetadata):

  • platform/blackberry/AsyncFileSystemBlackBerry.h:
  • platform/chromium/PlatformSupport.h:
  • platform/gtk/AsyncFileSystemGtk.cpp:

(WebCore::AsyncFileSystem::create):
(WebCore::AsyncFileSystem::openFileSystem):
(WebCore::AsyncFileSystemGtk::AsyncFileSystemGtk):
(WebCore::AsyncFileSystemGtk::move):
(WebCore::AsyncFileSystemGtk::copy):
(WebCore::AsyncFileSystemGtk::remove):
(WebCore::AsyncFileSystemGtk::removeRecursively):
(WebCore::AsyncFileSystemGtk::readMetadata):
(WebCore::AsyncFileSystemGtk::createFile):
(WebCore::AsyncFileSystemGtk::createDirectory):
(WebCore::AsyncFileSystemGtk::fileExists):
(WebCore::AsyncFileSystemGtk::directoryExists):
(WebCore::AsyncFileSystemGtk::readDirectory):
(WebCore::AsyncFileSystemGtk::createWriter):

  • platform/gtk/AsyncFileSystemGtk.h:
  • GNUmakefile.list.am: Added FileSystemType.h.
  • WebCore.gypi: Added FileSystemType.h.
  • WebCore.vcproj/WebCore.vcproj: Added FileSystemType.h.
  • WebCore.xcodeproj/project.pbxproj: Added FileSystemType.h.

Source/WebKit/chromium:

Currently we pass Entry's fullPath to AsyncFileSystem layer where
we convert the given path to filesystem URL which includes origin and
filesystem type information, but in that way we cannot handle
cross-filesystem operations (e.g. cross-filesystem copy and move)
well since we end up with always attaching the source filesystem's
origin and type information for argument paths.

This patch does:

  • move filesystem-type related code out of AsyncFileSystemChromium.cpp (moving into DOMFileSystemChromium.cpp)
  • change AsyncFileSystemChromium's methods implementation not to take entry paths but complete filesystem URLs.
  • src/AsyncFileSystemChromium.cpp:

(WebCore::AsyncFileSystemChromium::AsyncFileSystemChromium):
(WebCore::AsyncFileSystemChromium::move):
(WebCore::AsyncFileSystemChromium::copy):
(WebCore::AsyncFileSystemChromium::remove):
(WebCore::AsyncFileSystemChromium::removeRecursively):
(WebCore::AsyncFileSystemChromium::readMetadata):
(WebCore::AsyncFileSystemChromium::createFile):
(WebCore::AsyncFileSystemChromium::createDirectory):
(WebCore::AsyncFileSystemChromium::fileExists):
(WebCore::AsyncFileSystemChromium::directoryExists):
(WebCore::AsyncFileSystemChromium::readDirectory):
(WebCore::AsyncFileSystemChromium::createWriter):
(WebCore::AsyncFileSystemChromium::createSnapshotFileAndReadMetadata):

  • src/AsyncFileSystemChromium.h:

(WebCore::AsyncFileSystemChromium::create):
(AsyncFileSystemChromium):

  • src/LocalFileSystemChromium.cpp:

(WebCore::openFileSystemHelper):

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::createAsyncFileSystem):

  • src/WebFileSystemCallbacksImpl.cpp:

(WebKit::WebFileSystemCallbacksImpl::WebFileSystemCallbacksImpl):
(WebKit::WebFileSystemCallbacksImpl::didOpenFileSystem):

  • src/WebFileSystemCallbacksImpl.h:

(WebFileSystemCallbacksImpl):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::createFileSystem):
(WebKit::WebFrameImpl::createFileEntry):

  • src/WorkerAsyncFileSystemChromium.cpp:

(WebCore::WorkerAsyncFileSystemChromium::WorkerAsyncFileSystemChromium):
(WebCore::WorkerAsyncFileSystemChromium::move):
(WebCore::WorkerAsyncFileSystemChromium::copy):
(WebCore::WorkerAsyncFileSystemChromium::remove):
(WebCore::WorkerAsyncFileSystemChromium::removeRecursively):
(WebCore::WorkerAsyncFileSystemChromium::readMetadata):
(WebCore::WorkerAsyncFileSystemChromium::createFile):
(WebCore::WorkerAsyncFileSystemChromium::createDirectory):
(WebCore::WorkerAsyncFileSystemChromium::fileExists):
(WebCore::WorkerAsyncFileSystemChromium::directoryExists):
(WebCore::WorkerAsyncFileSystemChromium::readDirectory):
(WebCore::WorkerAsyncFileSystemChromium::createWriter):
(WebCore::WorkerAsyncFileSystemChromium::createSnapshotFileAndReadMetadata):

  • src/WorkerAsyncFileSystemChromium.h:

(WebCore::WorkerAsyncFileSystemChromium::create):
(WorkerAsyncFileSystemChromium):

LayoutTests:

  • fast/filesystem/cross-filesystem-op-expected.txt: Added.
  • fast/filesystem/cross-filesystem-op.html: Added.
20:05 Changeset [116387] by rakuco@webkit.org
  • 2 edits in trunk/Tools

[webkitpy] Remove Python 2.5-specific workaround from http_server_base.py.
https://bugs.webkit.org/show_bug.cgi?id=85852

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/servers/http_server_base.py:

(HttpServerBase._is_server_running_on_all_ports): Revert the part
of r89412 which was a workaround for an issue with Python 2.5 on
Mac 10.5.

19:52 Changeset [116386] by ojan@chromium.org
  • 1 edit
    6 adds in trunk/LayoutTests

Chromium rebaselines after http://trac.webkit.org/changeset/116373.
Differences look to just be in platform-specific text rendering.

  • platform/chromium-linux/fast/css/first-line-text-decoration-inherited-from-parent-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/first-line-text-decoration-inherited-from-parent-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/first-line-text-decoration-inherited-from-parent-expected.png: Added.
  • platform/chromium-mac/fast/css/first-line-text-decoration-inherited-from-parent-expected.png: Added.
  • platform/chromium-win/fast/css/first-line-text-decoration-inherited-from-parent-expected.png: Added.
  • platform/chromium-win/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt: Added.
19:47 Changeset [116385] by abarth@webkit.org
  • 5 edits in trunk/Source

[Chromium] Android wishes to use an empty implementation if AXObjectCache
https://bugs.webkit.org/show_bug.cgi?id=85842

Reviewed by Eric Seidel.

Source/WebCore:

Add proper HAVE(ACCESSIBILITY) ifdefs so that Chromium builds without
accessibility.

  • accessibility/chromium/AXObjectCacheChromium.cpp:
  • accessibility/chromium/AccessibilityObjectChromium.cpp:

Source/WTF:

Disable accessibility on OS(ANDROID) for PLATFORM(CHROMIUM).

  • wtf/Platform.h:
19:22 Changeset [116384] by commit-queue@webkit.org
  • 14 edits
    5 adds in trunk

[Web Intents] Flagged-off implementation of an intent tag for registration.
https://bugs.webkit.org/show_bug.cgi?id=73039

Patch by Greg Billock <gbillock@google.com> on 2012-05-07
Reviewed by Adam Barth.

Source/WebCore:

The intent tag is a declarative way for pages to register that they
accept delivery of web intent invocations of particular types. See the
spec at http://dvcs.w3.org/hg/web-intents/raw-file/tip/spec/Overview.html

After discussion on the WhatWG list (see thread at
http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2012-April/035301.html)
the current plan is to combine declarative registration of Web
Intents and protocol/content handlers with this tag. Alternatives
considered were the meta and link tags.

  • WebCore.gypi:
  • html/HTMLAttributeNames.in:
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLIntentElement.cpp: Added.

(WebCore::HTMLIntentElement::HTMLIntentElement):
(WebCore::HTMLIntentElement::create):
(WebCore::HTMLIntentElement::insertedIntoDocument):

  • html/HTMLIntentElement.h: Added.
  • html/HTMLIntentElement.idl: Added.
  • html/HTMLTagNames.in:
  • loader/FrameLoaderClient.h:

(WebCore::FrameLoaderClient::registerIntentService):

  • page/DOMWindow.idl:

Source/WebKit/chromium:

The intent tag allows web pages to mark themselves declaratively as accepting
web intent delivery of particular characteristics (action/type).
See the spec at:
http://dvcs.w3.org/hg/web-intents/raw-file/tip/spec/Overview.html

  • WebKit.gyp:
  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::registerIntentService):

  • src/FrameLoaderClientImpl.h:
18:53 Changeset [116383] by tkent@chromium.org
  • 3 edits
    2 deletes in trunk/Source/WebKit/chromium

Unreviewed, rolling out r116375.
http://trac.webkit.org/changeset/116375
https://bugs.webkit.org/show_bug.cgi?id=85850

Build break on Chromium-win and Chromium-mac. (Requested by
tkent on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-07

  • WebKit.gyp:
  • WebKit.gypi:
  • tests/EventListenerTest.cpp: Removed.
  • tests/data/listener/mutation_event_listener.html: Removed.
18:32 Changeset [116382] by aestes@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Add platform/mac/ results for new tests added by r116373.

  • platform/mac/fast/css/first-line-text-decoration-expected.txt: Added.
  • platform/mac/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt: Added.
18:14 Changeset [116381] by lforschler@apple.com
  • 12 edits in tags/Safari-534.57.4

Merge fixes for radars: 11331161, 11331164, 11331169.

18:11 Changeset [116380] by lforschler@apple.com
  • 1 copy in tags/Safari-534.57.4

New tag.

18:09 Changeset [116379] by lforschler@apple.com
  • 5 edits in branches/safari-534.57-branch/Source

Versioning.

18:08 FeatureFlags edited by tkent@chromium.org
Add IFRAME_SEAMLESS (diff)
17:34 Changeset [116378] by fpizlo@apple.com
  • 11 edits in branches/dfgopt/Source/JavaScriptCore

DFG should support op_tear_off_arguments
https://bugs.webkit.org/show_bug.cgi?id=85847

Reviewed by Michael Saboff.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):
(JSC::DFG::canInlineOpcode):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

17:11 Changeset [116377] by danakj@chromium.org
  • 5 edits in trunk/Source

Region::intersects() and Region::contains() are slow due to copy overhead
https://bugs.webkit.org/show_bug.cgi?id=81076

Reviewed by Anders Carlsson.

Source/WebCore:

Testing contains() and intersects() requires a copy which ends up
invoking a malloc on sufficiently complicated web pages, and slows down
the test unnecessarily. These methods can be done by iterating over the
Region::Shape values rather than making a copy of the entire region and
manipulating it.

This uses Region::Shape::compareShapes() to walk the query regions and
compute the result of the intersects or contains tests without making a
copy.

This change improves the performance of the Region overlap testing for
composited layers, and allows for testing contains() before unite() to
avoid unnecessary copies of the Region when inserting into complex
Regions. With a layout test that has 225 composited layers, and tests
Region.intersects() for 1000 layers above them, this change decreases
the running time of the test by 1.2% by avoiding a copy of the 225
rects each time.

Unit test: RegionTest.intersectsRegion

RegionTest.containsRegion

  • platform/graphics/Region.cpp:

(WebCore::Region::contains):
(WebCore::Region::intersects):
(WebCore):
(WebCore::Region::Shape::compareShapes):
(Region::Shape::CompareContainsOperation):
(WebCore::Region::Shape::CompareContainsOperation::aOutsideB):
(WebCore::Region::Shape::CompareContainsOperation::bOutsideA):
(WebCore::Region::Shape::CompareContainsOperation::aOverlapsB):
(Region::Shape::CompareIntersectsOperation):
(WebCore::Region::Shape::CompareIntersectsOperation::aOutsideB):
(WebCore::Region::Shape::CompareIntersectsOperation::bOutsideA):
(WebCore::Region::Shape::CompareIntersectsOperation::aOverlapsB):

  • platform/graphics/Region.h:

(Shape):

Source/WebKit/chromium:

  • tests/RegionTest.cpp:

(WebCore):
(WebCore::TEST):

17:09 Changeset [116376] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Correct logical error in accessibilityIsIgnored.
https://bugs.webkit.org/show_bug.cgi?id=85828

Patch by David Tseng <dtseng@google.com> on 2012-05-07
Reviewed by Chris Fleizach.

Covered by existing tests.

  • accessibility/AccessibilityMenuListOption.cpp:

(WebCore::AccessibilityMenuListOption::accessibilityIsIgnored):

  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::accessibilityIsIgnored):

17:05 Changeset [116375] by tony@chromium.org
  • 3 edits
    3 adds in trunk/Source/WebKit/chromium

[chromium] move event_listener_unittest to webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=85836

Reviewed by James Robinson.

Porting the test from src/webkit/tools/test_shell/event_listener_unittest.cc.
All I did was change the style and use the FrameTestHelper to load the file.

  • WebKit.gyp: Exclude file in components build.
  • WebKit.gypi: Add new file.
  • tests/EventListenerTest.cpp: Added.

(WebKit):
(TestWebDOMEventListener):
(WebKit::TestWebDOMEventListener::TestWebDOMEventListener):
(WebKit::TestWebDOMEventListener::~TestWebDOMEventListener):
(WebKit::TestWebDOMEventListener::eventCount):
(WebKit::TestWebDOMEventListener::eventAt):
(WebKit::TestWebDOMEventListener::clearEvents):
(WebDOMEventListenerTest):
(WebKit::WebDOMEventListenerTest::WebDOMEventListenerTest):
(WebKit::WebDOMEventListenerTest::SetUp):
(WebKit::WebDOMEventListenerTest::TearDown):
(WebKit::WebDOMEventListenerTest::mainFrame):
(WebKit::WebDOMEventListenerTest::document):
(WebKit::WebDOMEventListenerTest::executeScript):
(WebKit::WebDOMEventListenerTest::GetNodeID):
(WebKit::TEST_F):

  • tests/data/listener/mutation_event_listener.html: Added.
16:56 Changeset [116374] by zmo@google.com
  • 7 edits in trunk

vertexAttribPointer needs to reject large negative offsets
https://bugs.webkit.org/show_bug.cgi?id=85117

Reviewed by Kenneth Russell.

Source/WebCore:

  • html/canvas/WebGLRenderingContext.cpp: Use long long for GLsizeiptr and GLintptr

(WebCore):
(WebCore::WebGLRenderingContext::bufferData):
(WebCore::WebGLRenderingContext::bufferSubData):
(WebCore::WebGLRenderingContext::drawElements):
(WebCore::WebGLRenderingContext::getVertexAttribOffset):
(WebCore::WebGLRenderingContext::vertexAttribPointer):

  • html/canvas/WebGLRenderingContext.h: Ditto

(WebGLRenderingContext):

  • html/canvas/WebGLRenderingContext.idl: Ditto

LayoutTests:

  • fast/canvas/webgl/index-validation-expected.txt:
  • fast/canvas/webgl/index-validation.html: Add a test case for large negative offset.
16:39 Changeset [116373] by commit-queue@webkit.org
  • 5 edits
    6 adds in trunk

:first-line text-decorations are not rendered
https://bugs.webkit.org/show_bug.cgi?id=6047

Source/WebCore:

Text-decorations are applied during paint phase. The style was not being properly selected in case of
first line box. The patch fixes this.

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-05-07
Reviewed by Eric Seidel.

Tests: fast/css/first-line-text-decoration-inherited-from-parent.html

fast/css/first-line-text-decoration.html

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Inform the decoration color retriever if this box is part of the first line box or not.

  • rendering/RenderObject.cpp:

(WebCore::decorationColor):
Changed the argument from RenderObject* to RenderStyle*. As this function is just a helper to getTextDecorationColors
as used RenderObject solely to retrieve the corresponding RenderStyle, which(RenderStyle*) was already available with the latter function.

(WebCore::RenderObject::getTextDecorationColors):
Take a new variable to check if first line style or the regular style has to be used.
Sends RenderStyle* as an argument to decorationColor().

  • rendering/RenderObject.h:

(RenderObject):

LayoutTests:

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-05-07
Reviewed by Eric Seidel.

  • fast/css/first-line-text-decoration.html: Added.
  • platform/qt-linux/fast/css/first-line-text-decoration-expected.png: Added.
  • platform/qt-linux/fast/css/first-line-text-decoration-expected.txt: Added. This test checks if text-decoration present in the tags first-line style is applied properly.
  • fast/css/first-line-text-decoration-inherited-from-parent.html: Added.
  • platform/qt-linux/fast/css/first-line-text-decoration-inherited-from-parent-expected.png: Added.
  • platform/qt-linux/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt: Added. This test checks if the text-decoration and text color is chosen properly in the case where the first-line style is inherited from a parent and contains such text-decorations.
16:35 Changeset [116372] by oliver@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

2012-05-07 Oliver Hunt <oliver@apple.com>

Rolling out r110287

RS=Filip Pizlo

r110287 was meant to be refactoring only, but changed behavior
enough to break some websites, including qq.com.

16:33 Changeset [116371] by jchaffraix@webkit.org
  • 14 edits in trunk/Source

Refactor windowClipRectForLayer to remove the explicit RenderLayer dependency
https://bugs.webkit.org/show_bug.cgi?id=84090

Reviewed by David Hyatt.

Source/WebCore:

No observable change in behavior.

The function name was ambiguous as it was not a general purpose function but was
working directly on HTMLFrameOwnerElement. The rename makes this more obvious as
well as removes the explicit dependency on RenderLayer.

One of the slight change of this refactoring is that we now always null-check the
HTMLFrameOwnerElement's renderer as part windowClipRectForFrameOwner as I don't see
any evidence for the other code paths not to hit that. Also we may recur more on our
frame tree if we have no layer as we now call windowClipRect() in this case.

  • page/FrameView.h:

(FrameView):

  • plugins/PluginView.cpp:

(WebCore::PluginView::windowClipRect):

  • WebCore.exp.in:
  • WebCore.order:
  • page/FrameView.cpp:

(WebCore::FrameView::windowClipRect):
Updated after windowClipRectForLayer name and signature change.

(WebCore::FrameView::windowClipRectForFrameOwner):
This function now takes the HTMLFrameOwnerElement directly.

  • plugins/PluginView.cpp:

(WebCore::PluginView::PluginView):
(WebCore::PluginView::create):

  • plugins/PluginView.h:

(PluginView):
Updated |m_element| to be an HTMLPlugInElement as this was what was
passed by every caller. This makes the conversion to HTMLFrameOwnerElement
possible.

Source/WebKit/chromium:

  • src/WebPluginContainerImpl.cpp:

Updated after windowClipRectForLayer name and signature change.

Source/WebKit/win:

  • WebCoreSupport/EmbeddedWidget.cpp:

(EmbeddedWidget::windowClipRect):
Updated after windowClipRectForLayer name and signature change.

  • WebCoreSupport/EmbeddedWidget.h:

(EmbeddedWidget):
(EmbeddedWidget::EmbeddedWidget):
Updated the internal DOM pointer to be an HTMLPlugInElement
as it was what was passed in anyway. Also fixed some style
issues detected by our tools.

Source/WebKit2:

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::clipRectInWindowCoordinates):
Updated after windowClipRectForLayer name and signature change.

16:32 Changeset [116370] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK gardening.

  • platform/gtk/test_expectations.txt: Mark seamless frames as

failing until we enable the feature.

16:32 Changeset [116369] by lforschler@apple.com
  • 4 edits in trunk/Source

Versioning.

16:30 Changeset [116368] by enrica@apple.com
  • 6 edits in trunk/Source/WebCore

REGRESSION (r101575): Chinese input is broken when composing mail in iCloud using Safari.
https://bugs.webkit.org/show_bug.cgi?id=85840
<rdar://problem/11115520>

Reviewed by Alexey Proskuryakov.

The revision that broke this, introduced a way to sanitize the markup when deleting a range selection.
iCloud listens for DOM modification events and clears the selection, altering the input method state.
The fix consists in adding a paramenter to DeleteSelectionCommand to control when we sanitize the
markup.

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::deleteSelection):

  • editing/CompositeEditCommand.h:
  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::DeleteSelectionCommand):
(WebCore::DeleteSelectionCommand::doApply):

  • editing/DeleteSelectionCommand.h:

(WebCore::DeleteSelectionCommand::create):

  • editing/InsertTextCommand.cpp:

(WebCore::InsertTextCommand::doApply):

16:22 Changeset [116367] by aestes@apple.com
  • 8 edits in trunk/Source

ENABLE_IFRAME_SEAMLESS should be part of FEATURE_DEFINES.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
16:15 Changeset [116366] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

webkitdirs.pm: Make determineNumberOfCPUs work on FreeBSD.
https://bugs.webkit.org/show_bug.cgi?id=81481

Patch by Raphael Kubo da Costa <rakuco@FreeBSD.org> on 2012-05-07
Reviewed by Dirk Pranke.

FreeBSD has the same sysctl interface present in Darwin to query
the number of CPUs available, so use that too.

  • Scripts/webkitdirs.pm:

(determineNumberOfCPUs): Share the sysctl call with Darwin.
(isFreeBSD): Added.

16:07 Changeset [116365] by mrobinson@webkit.org
  • 3 edits in trunk/Source/WebCore

[Cairo] Implement ImageBuffer::copyImage for BackingStoreCopy == DontCopyBackingStore
https://bugs.webkit.org/show_bug.cgi?id=85728

Reviewed by Alejandro G. Castro.

No new tests. This should not change functionality, only increase performance.

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::copyImage): Add an implementation that knows how to avoid copying the backing store.
(WebCore::ImageBuffer::draw): Use the copyImage constructor now that it knows how to
avoid copying the backing store.
(WebCore::ImageBuffer::drawPattern): Ditto.

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::updateBackingStore): Use DontCopyBackingStore for Cairo
as well.

16:06 Changeset [116364] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

[CG] Separate image encoding from dataURL construction
https://bugs.webkit.org/show_bug.cgi?id=85782

Reviewed by Kenneth Russell.

Remove the implicit assumption that a dataURL is the only desired output format
of the image encoding phase.

No new tests. No behavioral change. Covered by canvas 2d and 3d tests:

canvas/philip/tests/*toDataURL*.html
fast/canvas/webgl/premultiplyalpha-test.html

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::CGImageEncodeToData): Image encoding helper: encode the image using the
uti-defined encoder (PNG/JPEG/etc) and output to the given CFMutableDataRef data.
(WebCore):
(WebCore::CGImageToDataURL): Refactor to use CGImageEncodeToData().

16:02 Changeset [116363] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix release build.

16:00 Changeset [116362] by danakj@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Ensure synchronization in threaded unit tests by checking the sourceFrameNumber() to count commits
https://bugs.webkit.org/show_bug.cgi?id=85390

Reviewed by Adrienne Walker.

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestScrollMultipleRedraw::beginCommitOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommit::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestScrollChildLayer::beginCommitOnCCThread):

15:52 Changeset [116361] by oliver@apple.com
  • 7 edits in trunk

LLInt doesn't check for Ropes when performing a character switch
https://bugs.webkit.org/show_bug.cgi?id=85837

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Make LLint check if the scrutinee of a char switch is a rope, and if
so fall back to a slow case.

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(LLInt):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:

LayoutTests:

Add a few tests to force the use of ropes on switch statements.

  • fast/js/script-tests/switch-behaviour.js:
  • fast/js/switch-behaviour-expected.txt:
15:29 Changeset [116360] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Suppress switch-without-cases warning
https://bugs.webkit.org/show_bug.cgi?id=85830

Warnings like
...\webkit\CSSGrammar.cpp(2075) : warning C4065: switch statement contains 'default' but no 'case' labels
are generated. These are bogus, so just suppress them in the build
settings.

Patch by Scott Graham <scottmg@chromium.org> on 2012-05-07
Reviewed by Dirk Pranke

No new tests, no intended functionlity change. Just changing compiler
settings.

  • WebCore.gyp/WebCore.gyp:
15:21 Changeset [116359] by enne@google.com
  • 9 edits in trunk/Source

[chromium] Allow for asymmetric tile sizes on composited tiled layers
https://bugs.webkit.org/show_bug.cgi?id=85687

Reviewed by James Robinson.

Source/WebCore:

Update TiledLayerChromium/CCLayerTilingData/TilingData to allow for a
the width and height of tile sizes to differ. Modify TilingData to use
IntSize everywhere for these width/height pairs.

Also, remove some unused functions from TilingData.

Test: TilingDataTest.*

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::updateTileSizeAndTilingOption):

  • platform/graphics/chromium/cc/CCLayerTilingData.cpp:

(WebCore::CCLayerTilingData::CCLayerTilingData):
(WebCore::CCLayerTilingData::setTileSize):
(WebCore):
(WebCore::CCLayerTilingData::tileSize):
(WebCore::CCLayerTilingData::operator=):
(WebCore::CCLayerTilingData::tileRect):
(WebCore::CCLayerTilingData::setBounds):
(WebCore::CCLayerTilingData::bounds):

  • platform/graphics/chromium/cc/CCLayerTilingData.h:

(CCLayerTilingData):

  • platform/graphics/gpu/Texture.cpp:

(WebCore::Texture::Texture):
(WebCore::Texture::create):
(WebCore::Texture::load):
(WebCore::Texture::updateSubRect):

  • platform/graphics/gpu/TilingData.cpp:

(WebCore::TilingData::TilingData):
(WebCore::TilingData::setTotalSize):
(WebCore::TilingData::setMaxTextureSize):
(WebCore::TilingData::tileXIndexFromSrcCoord):
(WebCore::TilingData::tileYIndexFromSrcCoord):
(WebCore::TilingData::tileBounds):
(WebCore::TilingData::tileSizeX):
(WebCore::TilingData::tileSizeY):
(WebCore::TilingData::recomputeNumTiles):

  • platform/graphics/gpu/TilingData.h:

(TilingData):
(WebCore::TilingData::totalSize):
(WebCore::TilingData::maxTextureSize):
(WebCore::TilingData::TilingData):

Source/WebKit/chromium:

Update tests for new constructor and function args. Add a few more
tests that use non-square tile sizes.

  • tests/TilingDataTest.cpp:

(WebCore::TestTiling::TestTiling):
(WebCore::TEST):
(WebCore):

15:15 Changeset [116358] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

ConvolverNode setBuffer() should not ASSERT on null buffer
https://bugs.webkit.org/show_bug.cgi?id=85653

Patch by Raymond Toy <rtoy@google.com> on 2012-05-07
Reviewed by Chris Rogers.

Source/WebCore:

Test: webaudio/convolver-setBuffer-null.html

  • Modules/webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::setBuffer): Don't ASSERT on null buffer.

LayoutTests:

  • webaudio/convolver-setBuffer-null-expected.txt: Added.
  • webaudio/convolver-setBuffer-null.html: Added.
15:07 Changeset [116357] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Crash due to positioned object list not being cleared during block flow split
https://bugs.webkit.org/show_bug.cgi?id=85074

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-05-07
Reviewed by Abhishek Arya.

Source/WebCore:

When an element is being split due to a column span element being
inserted, any of its ancestors that are underneath the column
containing block also get split. If an ancestor has an object in
its positioned object list from a previous layout, then the list
will have to be cleared because the positioned object could have moved
to be under the continuation. This patch causes the list to be
cleared.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::splitBlocks):

LayoutTests:

Test exercises crashing condition in bug 85074. It creates a column
span that requires multiple layers of splitting blocks from the
element that contains the columns, puts a positioned element underneath
one of the split blocks, and then causes a reattach of the column span
element.

  • fast/block/positioning/positioned-object-under-split-block-parent-crash-expected.txt: Added
  • fast/block/positioning/positioned-object-under-split-block-parent-crash.html: Added
15:02 Changeset [116356] by eric@webkit.org
  • 13 edits in trunk

Add ENABLE_IFRAME_SEAMLESS so Apple can turn off SEAMLESS if needed
https://bugs.webkit.org/show_bug.cgi?id=85822

Reviewed by Adam Barth.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • dom/Document.cpp:

(WebCore::Document::shouldDisplaySeamlesslyWithParent):

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
14:57 Changeset [116355] by aestes@apple.com
  • 10 edits in trunk/LayoutTests

Update media/ pixel test results after r115749.

  • platform/mac/media/audio-controls-rendering-expected.png:
  • platform/mac/media/controls-after-reload-expected.png:
  • platform/mac/media/controls-layout-direction-expected.png:
  • platform/mac/media/controls-strict-expected.png:
  • platform/mac/media/media-controls-clone-expected.png:
  • platform/mac/media/video-controls-rendering-expected.png:
  • platform/mac/media/video-display-toggle-expected.png:
  • platform/mac/media/video-layer-crash-expected.png:
  • platform/mac/media/video-playing-and-pause-expected.png:
14:40 Changeset [116354] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Fix compositing expectations to not include leopard.

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
14:30 Changeset [116353] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Selection Background Color Error
https://bugs.webkit.org/show_bug.cgi?id=80382

Patch by Shezan Baig <shezbaig.wk@gmail.com> on 2012-05-07
Reviewed by David Hyatt.

Source/WebCore:

Determine the text colors and selection colors before painting the
background behind the text. This is because when determining whether
to invert the selection background, the selection text color should be
used instead of the regular text color. With this patch, the selection
text color is passed to 'paintSelection' so that the selection
background can be compared against it, instead of comparing against the
CSSPropertyColor value.

Test: fast/backgrounds/selection-background-color.html

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint):

Pass selection text color to paintSelection

(WebCore::InlineTextBox::paintSelection):

Use the selection text color instead of CSSPropertyColor

  • rendering/InlineTextBox.h:

(InlineTextBox):

Adjust signature of paintSelection to accept text color

LayoutTests:

Added new test case for selection background color.

  • fast/backgrounds/selection-background-color.html: Added.
  • fast/backgrounds/selection-background-color-expected.html: Added.
13:41 Changeset [116352] by alexis.menard@openbossa.org
  • 4 edits in trunk

Unreviewed Qt build fix in Debug.

We need some system includes here for getpid() to be recognized.

Source/WebKit2:

  • qt/MainQt.cpp:

Tools:

  • WebKitTestRunner/qt/main.cpp:
13:40 Changeset [116351] by commit-queue@webkit.org
  • 18 edits
    1 copy
    2 adds
    1 delete in trunk/Source

[Chromium] Use GL_CHROMIUM_command_buffer_query to throttle texture uploads.
https://bugs.webkit.org/show_bug.cgi?id=81004

Patch by David Reveman <reveman@chromium.org> on 2012-05-07
Reviewed by Adrienne Walker.

Source/WebCore:

Add ThrottledTextureUploader class that uses GL_CHROMIUM_command_buffer_query
to throttle texture uploads based on number of currently pending queries.

Unit test: ThrottledTextureUploaderTest.IsBusy

  • WebCore.gypi:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::initializeSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

  • platform/graphics/chromium/TextureUploader.cpp: Removed.
  • platform/graphics/chromium/TextureUploader.h:

(TextureUploader):

  • platform/graphics/chromium/ThrottledTextureUploader.cpp: Added.

(WebCore):
(WebCore::ThrottledTextureUploader::Query::Query):
(WebCore::ThrottledTextureUploader::Query::~Query):
(WebCore::ThrottledTextureUploader::Query::begin):
(WebCore::ThrottledTextureUploader::Query::end):
(WebCore::ThrottledTextureUploader::Query::isPending):
(WebCore::ThrottledTextureUploader::Query::wait):
(WebCore::ThrottledTextureUploader::ThrottledTextureUploader):
(WebCore::ThrottledTextureUploader::~ThrottledTextureUploader):
(WebCore::ThrottledTextureUploader::isBusy):
(WebCore::ThrottledTextureUploader::beginUploads):
(WebCore::ThrottledTextureUploader::endUploads):
(WebCore::ThrottledTextureUploader::uploadTexture):
(WebCore::ThrottledTextureUploader::processQueries):

  • platform/graphics/chromium/ThrottledTextureUploader.h: Copied from Source/WebCore/platform/graphics/chromium/TextureUploader.h.

(WebCore):
(ThrottledTextureUploader):
(WebCore::ThrottledTextureUploader::create):
(Query):
(WebCore::ThrottledTextureUploader::Query::create):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(UnthrottledTextureUploader):
(WebCore::UnthrottledTextureUploader::create):
(WebCore::UnthrottledTextureUploader::~UnthrottledTextureUploader):
(WebCore::UnthrottledTextureUploader::isBusy):
(WebCore::UnthrottledTextureUploader::beginUploads):
(WebCore::UnthrottledTextureUploader::endUploads):
(WebCore::UnthrottledTextureUploader::uploadTexture):
(WebCore::UnthrottledTextureUploader::UnthrottledTextureUploader):
(WebCore):
(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::recreateContext):
(WebCore::CCSingleThreadProxy::doCommit):

  • platform/graphics/chromium/cc/CCTextureUpdater.cpp:

(WebCore::CCTextureUpdater::update):

  • platform/graphics/chromium/cc/CCTextureUpdater.h:

(CCTextureUpdater):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore):
(UnthrottledTextureUploader):
(WebCore::UnthrottledTextureUploader::create):
(WebCore::UnthrottledTextureUploader::~UnthrottledTextureUploader):
(WebCore::UnthrottledTextureUploader::isBusy):
(WebCore::UnthrottledTextureUploader::beginUploads):
(WebCore::UnthrottledTextureUploader::endUploads):
(WebCore::UnthrottledTextureUploader::uploadTexture):
(WebCore::UnthrottledTextureUploader::UnthrottledTextureUploader):
(WebCore::CCThreadProxy::initializeLayerRendererOnImplThread):
(WebCore::CCThreadProxy::recreateContextOnImplThread):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCLayerTreeHostImplTest.cpp:

(WebKitTests::TEST_F):

  • tests/CCTiledLayerTestCommon.h:

(WebKitTests::FakeTextureUploader::isBusy):
(WebKitTests::FakeTextureUploader::beginUploads):
(WebKitTests::FakeTextureUploader::endUploads):

  • tests/Canvas2DLayerChromiumTest.cpp:
  • tests/LayerRendererChromiumTest.cpp:

(FakeLayerRendererChromium::FakeLayerRendererChromium):
(LayerRendererChromiumTest::LayerRendererChromiumTest):
(TEST):

  • tests/ThrottledTextureUploaderTest.cpp: Added.

(WebKit):
(FakeWebGraphicsContext3DWithQueryTesting):
(WebKit::FakeWebGraphicsContext3DWithQueryTesting::FakeWebGraphicsContext3DWithQueryTesting):
(WebKit::FakeWebGraphicsContext3DWithQueryTesting::getQueryObjectuivEXT):
(WebKit::FakeWebGraphicsContext3DWithQueryTesting::setResultAvailable):
(WebKit::TEST):

  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):

13:37 Changeset [116350] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Delete previous buffer when new over-scroll image path is set
https://bugs.webkit.org/show_bug.cgi?id=85812

Patch by Andrew Lo <anlo@rim.com> on 2012-05-07
Reviewed by Rob Buis.

When a new over-scroll image path is set, delete old buffer before creating
a new one.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::ensureOverScrollImage):

13:37 Changeset [116349] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Rebaseline fast/layers/video-layer.html.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-07

  • platform/efl/fast/layers/video-layer-expected.txt:
13:23 Changeset [116348] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Over-scroll image path property should be relative to local application directory
https://bugs.webkit.org/show_bug.cgi?id=85814

Patch by Andrew Lo <anlo@rim.com> on 2012-05-07
Reviewed by Rob Buis.

Over-scroll image path web setting should be relative to the local directory.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::ensureOverScrollImage):

13:23 Changeset [116347] by ojan@chromium.org
  • 4 edits
    2 adds in trunk/Tools

When embedding the flakiness dashboard, hide popups when the frame is blurred.
https://bugs.webkit.org/show_bug.cgi?id=85684

Reviewed by Dirk Pranke.

If you show a popup, then click elsewhere in garden-o-matic, it will now
properly hide it.

  • TestResultServer/static-dashboards/dashboard_base.js:

(showPopup):

  • TestResultServer/static-dashboards/flakiness_dashboard.js:

(showPopupForBuild):
(generatePageForIndividualTests.if):
(generatePageForIndividualTests):

  • TestResultServer/static-dashboards/flakiness_dashboard_embedded_unittests.js: Added.
  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
  • TestResultServer/static-dashboards/run-embedded-unittests.html: Added.
13:21 Changeset [116346] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Mark more tests as flaky, including some compositing tests
https://bugs.webkit.org/show_bug.cgi?id=85771

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
13:19 Changeset [116345] by fpizlo@apple.com
  • 20 edits in branches/dfgopt/Source/JavaScriptCore

DFG should support reflective arguments access
https://bugs.webkit.org/show_bug.cgi?id=85721

Reviewed by Oliver Hunt.

This adds support for op_create_arguments to the DFG. No other arguments-related
opcodes are added by this change, though it does add a lot of the scaffolding
necessary for the other ops.

This also adds GetByVal/PutByVal optimizations for Arguments.

Finally, this rationalizes slowPathCall with no return. Previously, that would
work via callOperation() overloads that took InvalidGPRReg as the return GPR.
But that creates awful ambiguity, since we had template functions that were
polymorphic over all parameters except the second, which was a GPRReg, and a
bunch of non-template overloads that also potentially had GPRReg as the second
argument. I finally started to hit this ambiguity and was getting absolutely
bizarre compiler errors, that made me feel like I was programming in SML. So,
I changed the no-argument overloads to take NoResultTag instead, which made
everything sensible again by eliminating the overload ambiguity.

This is a ~7% speed-up on V8/earley and neutral elsewhere.

  • bytecode/PredictedType.h:

(JSC::isArgumentsPrediction):
(JSC):
(JSC::isActionableMutableArrayPrediction):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCCallHelpers.h:

(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(CCallHelpers):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):
(JSC::DFG::canInlineOpcode):

  • dfg/DFGCommon.h:
  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGNode.h:

(JSC::DFG::Node::unmodifiedArgumentsRegister):
(Node):
(JSC::DFG::Node::shouldSpeculateArguments):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
(JSC::DFG::SpeculativeJIT::compileGetByValOnArguments):
(DFG):
(JSC::DFG::SpeculativeJIT::compileGetArgumentsLength):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::silentSpillAllRegistersImpl):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::pickCanTrample):
(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::compile):

  • runtime/Arguments.h:

(ArgumentsData):
(Arguments):
(JSC::Arguments::offsetOfData):

13:17 Changeset [116344] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[chromium] WebViewHost should setCompositorSurfaceReady
https://bugs.webkit.org/show_bug.cgi?id=85418

Patch by Ian Vollick <vollick@chromium.org> on 2012-05-07
Reviewed by James Robinson.

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::setWebWidget):

13:16 Changeset [116343] by rwlbuis@webkit.org
  • 4 edits in trunk/Source/WebCore

Shrink SVGInlineTextBox object size
https://bugs.webkit.org/show_bug.cgi?id=85805

Reviewed by Darin Adler.

Reduce the object size of SVGInlineTextBox by using bitfields. This
should be 4 bytes on 32-bits and 8 bytes on 64-bits systems.

  • rendering/svg/RenderSVGResource.h:
  • rendering/svg/SVGInlineTextBox.cpp:

(ExpectedSVGInlineTextBoxSize):
(WebCore):

  • rendering/svg/SVGInlineTextBox.h:

(SVGInlineTextBox):

13:14 Changeset [116342] by commit-queue@webkit.org
  • 6 edits
    5 deletes in trunk/Source

Unreviewed, rolling out r116334.
http://trac.webkit.org/changeset/116334
https://bugs.webkit.org/show_bug.cgi?id=85816

Broke the Chromium Win/Mac compile (Requested by
ojan_gardening on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-07

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/chromium/AnimationIdVendor.cpp: Removed.
  • platform/graphics/chromium/AnimationIdVendor.h: Removed.
  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(std):
(WebCore::GraphicsLayerChromium::updateNames):
(WebCore::GraphicsLayerChromium::addAnimation):
(WebCore::GraphicsLayerChromium::updateChildList):
(WebCore::GraphicsLayerChromium::mapAnimationNameToId):

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(WebCore):
(GraphicsLayerChromium):

  • platform/graphics/chromium/LinkHighlightLayerDelegate.cpp: Removed.
  • platform/graphics/chromium/LinkHighlightLayerDelegate.h: Removed.

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/LinkHighlightLayerDelegateTest.cpp: Removed.
13:10 Changeset [116341] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] Page caching permission from EFL's FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=85620

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-07
Reviewed by Gustavo Noronha Silva.

Source/WebKit/efl:

FrameLoaderClientEfl::canCachePage() returns true.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::canCachePage):

LayoutTests:

Unskip bug-related testcases.

  • platform/efl/Skipped:
13:06 Changeset [116340] by aestes@apple.com
  • 2 edits
    2 deletes in trunk/LayoutTests

Update mac-wk2 baselines.

  • platform/mac-wk2/Skipped: Skip a test that times out due to WKTR's

EventSender implementation not supporting drag and drop.

Remove mac-wk2 platform-specific results for two tests that now match the baseline result.

  • platform/mac-wk2/editing/selection/select-across-readonly-input-1-expected.txt: Removed.
  • platform/mac-wk2/media/no-auto-play-in-sandbox-expected.txt: Removed.
12:35 Changeset [116339] by enne@google.com
  • 2 edits in trunk/Source/WebCore

Fix containerForRepaint() assumption about non-null enclosingLayer()
https://bugs.webkit.org/show_bug.cgi?id=85807

Reviewed by Simon Fraser.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::containerForRepaint):

12:22 Changeset [116338] by jonlee@apple.com
  • 8 edits in trunk/Tools

WebKitTestRunner needs layoutTestController.dumpFrameLoadCallbacks
https://bugs.webkit.org/show_bug.cgi?id=42331
<rdar://problem/8193641>

Reviewed by Darin Adler.

This patch sets up the framework for supporting dumpFrameLoadCallbacks, as well as
outputting some of the required strings. As tests become unskipped the other callbacks
can be supported.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Add dumpFrameLoadCallbacks()
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::didReceiveMessage): pass in the dictionary containing keys needed to initialize
dump callbacks for the layoutTestController.
(WTR::InjectedBundle::booleanForKey): Helper function to extract boolean value from key in WKDictionaryRef.
Output some warning if we are trying to extract a value that is not a boolean.
(WTR::InjectedBundle::beginTesting): Update to take in the dictionary passed in by the TestController.
We cannot set the bits on the layoutTestController until it has been created in beginTesting().

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::didReceiveMessage):
(WTR):
(WTR::InjectedBundle::beginTesting):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR):
(WTR::dumpFrameDescriptionSuitableForTestResult): Static function similar to
-[WebFrame _drt_descriptionSuitableForTestResult] in DumpRenderTree.
(WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): Output string.
(WTR::InjectedBundlePage::didCommitLoadForFrame): Output string.
(WTR::InjectedBundlePage::didFinishLoadForFrame): Output string.
(WTR::InjectedBundlePage::didReceiveTitleForFrame): Output string.
(WTR::InjectedBundlePage::didCancelClientRedirectForFrame): Output string.
(WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Output string. In WK1 it's
"willPerformClientRedirectToURL" so we will have to use that value here.
(WTR::InjectedBundlePage::didFinishDocumentLoadForFrame): Output string.
(WTR::InjectedBundlePage::didHandleOnloadEventsForFrame): Output string.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::LayoutTestController): Initialize to not dump frame load callbacks.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(WTR::LayoutTestController::dumpFrameLoadCallbacks): Change to use setShouldDumpFrameLoadCallbacks.
(WTR::LayoutTestController::setShouldDumpFrameLoadCallbacks): Set bit.
(WTR::LayoutTestController::shouldDumpFrameLoadCallbacks): Return bit.
(LayoutTestController): Added m_dumpFrameLoadCallbacks to track whether to dump the output.

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::shouldLogFrameLoadDelegates): Similar to DRT.
(WTR::TestInvocation::invoke): Based on the URL loaded, set the bit in the dictionary that gets passed
to the injected bundle.

12:12 Changeset [116337] by commit-queue@webkit.org
  • 148 edits
    3 adds in trunk

IndexedDB: Replace numeric constants with strings
https://bugs.webkit.org/show_bug.cgi?id=84894

Patch by Alec Flett <alecflett@chromium.org> on 2012-05-07
Reviewed by Tony Chang.

Source/WebCore:

Test: storage/indexeddb/legacy-constants.html

Update IDBObjectStore.openCursor, IDBIndex.openCursor,
IDBIndex.openKeyCursor, IDBDatabase.transaction,
IDBCursor.direction, IDBTransaction.mode, and
IDBRequest.readyState to meet the latest spec. All of these APIs
now support string-based values in addition to the
legacy/deprecated enum-based values.

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore):
(WebCore::IDBCursor::direction):
(WebCore::IDBCursor::stringToDirection):
(WebCore::IDBCursor::directionToString):

  • Modules/indexeddb/IDBCursor.h:

(IDBCursor):

  • Modules/indexeddb/IDBCursor.idl:
  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::transaction):
(WebCore):

  • Modules/indexeddb/IDBDatabase.h:

(IDBDatabase):

  • Modules/indexeddb/IDBDatabase.idl:
  • Modules/indexeddb/IDBIndex.cpp:

(WebCore::IDBIndex::openCursor):
(WebCore):
(WebCore::IDBIndex::openKeyCursor):

  • Modules/indexeddb/IDBIndex.h:

(WebCore::IDBIndex::openCursor):
(IDBIndex):
(WebCore::IDBIndex::openKeyCursor):

  • Modules/indexeddb/IDBIndex.idl:
  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::openCursor):
(WebCore):

  • Modules/indexeddb/IDBObjectStore.h:

(WebCore::IDBObjectStore::openCursor):
(IDBObjectStore):

  • Modules/indexeddb/IDBObjectStore.idl:
  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::readyState):
(WebCore::IDBRequest::markEarlyDeath):
(WebCore::IDBRequest::resetReadyState):
(WebCore::IDBRequest::abort):
(WebCore::IDBRequest::finishCursor):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::stop):

  • Modules/indexeddb/IDBRequest.h:
  • Modules/indexeddb/IDBRequest.idl:
  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore):
(WebCore::IDBTransaction::mode):
(WebCore::IDBTransaction::stringToMode):
(WebCore::IDBTransaction::modeToString):

  • Modules/indexeddb/IDBTransaction.h:

(IDBTransaction):

  • Modules/indexeddb/IDBTransaction.idl:

LayoutTests:

New test for legacy constants (legacy-constants) and update all
other tests to use the new string-based constants.

  • storage/indexeddb/basics-expected.txt:
  • storage/indexeddb/basics-workers-expected.txt:
  • storage/indexeddb/constants-expected.txt:
  • storage/indexeddb/create-object-store-options-expected.txt:
  • storage/indexeddb/cursor-added-bug-expected.txt:
  • storage/indexeddb/cursor-advance-expected.txt:
  • storage/indexeddb/cursor-continue-expected.txt:
  • storage/indexeddb/cursor-continue-validity-expected.txt:
  • storage/indexeddb/cursor-delete-expected.txt:
  • storage/indexeddb/cursor-inconsistency-expected.txt:
  • storage/indexeddb/cursor-index-delete-expected.txt:
  • storage/indexeddb/cursor-key-order-expected.txt:
  • storage/indexeddb/cursor-prev-no-duplicate-expected.txt:
  • storage/indexeddb/cursor-primary-key-order-expected.txt:
  • storage/indexeddb/cursor-reverse-bug-expected.txt:
  • storage/indexeddb/cursor-skip-deleted-expected.txt:
  • storage/indexeddb/cursor-update-expected.txt:
  • storage/indexeddb/data-corruption-expected.txt:
  • storage/indexeddb/database-quota-expected.txt:
  • storage/indexeddb/delete-range-expected.txt:
  • storage/indexeddb/error-causes-abort-by-default-expected.txt:
  • storage/indexeddb/exception-in-event-aborts-expected.txt:
  • storage/indexeddb/factory-deletedatabase-expected.txt:
  • storage/indexeddb/index-count-expected.txt:
  • storage/indexeddb/index-multientry-expected.txt:
  • storage/indexeddb/index-unique-expected.txt:
  • storage/indexeddb/key-generator-expected.txt:
  • storage/indexeddb/key-type-array-expected.txt:
  • storage/indexeddb/keypath-edges-expected.txt:
  • storage/indexeddb/keypath-intrinsic-properties-expected.txt:
  • storage/indexeddb/legacy-constants-expected.txt: Added.
  • storage/indexeddb/legacy-constants.html: Added.
  • storage/indexeddb/mozilla/clear-expected.txt:
  • storage/indexeddb/mozilla/create-index-unique-expected.txt:
  • storage/indexeddb/mozilla/create-objectstore-basics-expected.txt:
  • storage/indexeddb/mozilla/cursor-mutation-expected.txt:
  • storage/indexeddb/mozilla/cursor-mutation-objectstore-only-expected.txt:
  • storage/indexeddb/mozilla/cursors-expected.txt:
  • storage/indexeddb/mozilla/index-prev-no-duplicate-expected.txt:
  • storage/indexeddb/mozilla/index-prev-no-duplicate.html:
  • storage/indexeddb/mozilla/indexes-expected.txt:
  • storage/indexeddb/mozilla/odd-result-order-expected.txt:
  • storage/indexeddb/mozilla/readwrite-transactions-expected.txt:
  • storage/indexeddb/mozilla/readyState-expected.txt:
  • storage/indexeddb/mozilla/resources/clear.js:

(clear):

  • storage/indexeddb/mozilla/resources/create-index-unique.js:

(createAndVerifyIndex):

  • storage/indexeddb/mozilla/resources/create-objectstore-basics.js:

(cleanDatabase):

  • storage/indexeddb/mozilla/resources/cursor-mutation-objectstore-only.js:

(checkCursorResultsAndSetupMutatingCursor):

  • storage/indexeddb/mozilla/resources/cursor-mutation.js:

(setupMutatingCursor):

  • storage/indexeddb/mozilla/resources/cursors.js:
  • storage/indexeddb/mozilla/resources/indexes.js:
  • storage/indexeddb/mozilla/resources/odd-result-order.js:

(addRecord):
(deleteRecord):

  • storage/indexeddb/mozilla/resources/readwrite-transactions.js:

(setVersionComplete):
(postAdd):
(postAdd2):
(postPut):
(postPut2):
(postPut3):
(postPut4):
(postDelete):
(postDelete2):

  • storage/indexeddb/mozilla/resources/readyState.js:

(test):
(openSuccess):
(setupObjectStore):
(getRecord):
(finalCheck):

  • storage/indexeddb/mozilla/resources/versionchange.js:

(postSetVersion):
(postSetVersion2):

  • storage/indexeddb/mozilla/versionchange-expected.txt:
  • storage/indexeddb/mutating-cursor-expected.txt:
  • storage/indexeddb/noblobs-expected.txt:
  • storage/indexeddb/noblobs.html:
  • storage/indexeddb/objectstore-autoincrement-expected.txt:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics-workers-expected.txt:
  • storage/indexeddb/objectstore-count-expected.txt:
  • storage/indexeddb/open-cursor-expected.txt:
  • storage/indexeddb/open-during-transaction-expected.txt:
  • storage/indexeddb/opencursor-key-expected.txt:
  • storage/indexeddb/prefetch-bugfix-108071-expected.txt:
  • storage/indexeddb/readonly-expected.txt:
  • storage/indexeddb/request-event-propagation-expected.txt:
  • storage/indexeddb/resources/basics.js:

(test):
(openCallback):

  • storage/indexeddb/resources/constants.js:

(test):

  • storage/indexeddb/resources/create-object-store-options.js:

(setVersionComplete):

  • storage/indexeddb/resources/cursor-added-bug.js:

(openCursor):

  • storage/indexeddb/resources/cursor-advance.js:

(runTest):
(testAdvanceIndexNoDupe):
(testAdvanceIndexPrev):
(testAdvanceIndexPrevNoDupe):

  • storage/indexeddb/resources/cursor-continue-validity.js:

(continueTest):
(continueIndexTest):
(testModifyContinueOrder):

  • storage/indexeddb/resources/cursor-continue.js:

(ascendingTest):
(descendingTest):

  • storage/indexeddb/resources/cursor-delete.js:

(openCursor):
(addObject):

  • storage/indexeddb/resources/cursor-inconsistency.js:

(openBasicCursor):

  • storage/indexeddb/resources/cursor-index-delete.js:

(openCursor):
(addObject):

  • storage/indexeddb/resources/cursor-key-order.js:
  • storage/indexeddb/resources/cursor-prev-no-duplicate.js:

(populateStore):
(testFarRangeCursor_closed):
(testFarRangeCursor_open):
(testFarRangeCursor_indexClosed):
(testFarRangeCursor_indexOpen):
(testFarRangeCursor_indexKeyOpen):
(testFarRangeCursor_indexKeyClosed):
(testBoundaryCursor_closed):
(testBoundaryCursor_open):
(testBoundaryCursor_indexClosed):
(testBoundaryCursor_indexOpen):
(testBoundaryCursor_indexKeyClosed):
(testBoundaryCursor_indexKeyOpen):
(testNoDuplicate_closed):
(testNoDuplicate_open):
(testNoDuplicate_indexKeyClosed):

  • storage/indexeddb/resources/cursor-primary-key-order.js:

(populateStore):

  • storage/indexeddb/resources/cursor-reverse-bug.js:

(populateStore):
(testCursor):

  • storage/indexeddb/resources/cursor-skip-deleted.js:

(basicCursorTest):
(reverseCursorTest):

  • storage/indexeddb/resources/cursor-update.js:

(openBasicCursor):

  • storage/indexeddb/resources/data-corruption.js:

(addData):
(getData):

  • storage/indexeddb/resources/database-quota.js:

(checkQuotaEnforcing):

  • storage/indexeddb/resources/delete-range.js:

(runTests.nextTest):
(runTests):

  • storage/indexeddb/resources/error-causes-abort-by-default.js:

(addData):
(transactionCompleted):
(transactionAborted1):

  • storage/indexeddb/resources/exception-in-event-aborts.js:

(startTest):
(transactionAborted1):
(transactionAborted2):

  • storage/indexeddb/resources/factory-deletedatabase.js:

(getValue):

  • storage/indexeddb/resources/index-count.js:
  • storage/indexeddb/resources/index-cursor.js:

(runNextTest):
(testNullKeyRange):

  • storage/indexeddb/resources/index-multientry.js:
  • storage/indexeddb/resources/index-unique.js:

(setVersionCompleted):

  • storage/indexeddb/resources/key-generator.js:

(.):

  • storage/indexeddb/resources/key-type-array.js:
  • storage/indexeddb/resources/keypath-edges.js:
  • storage/indexeddb/resources/keypath-intrinsic-properties.js:
  • storage/indexeddb/resources/legacy-constants.js: Added.

(test):
(prepareDatabase.openreq.onsuccess.verreq.onsuccess):
(prepareDatabase.openreq.onsuccess):
(prepareDatabase):
(populateStore):
(checkNext.request.onsuccess):
(checkNext):
(checkNextNoDuplicate.request.onsuccess):
(checkNextNoDuplicate):
(checkPrev.request.onsuccess):
(checkPrev):
(checkPrevNoDuplicate.request.onsuccess):
(checkPrevNoDuplicate):

  • storage/indexeddb/resources/mutating-cursor.js:

(openForwardCursor):
(openReverseCursor):

  • storage/indexeddb/resources/objectstore-autoincrement.js:

(setVersionCompleted):

  • storage/indexeddb/resources/objectstore-basics.js:

(addData):
(addAgainFailure):

  • storage/indexeddb/resources/objectstore-count.js:
  • storage/indexeddb/resources/objectstore-cursor.js:

(runNextTest):
(testNullKeyRange):

  • storage/indexeddb/resources/open-cursor.js:

(cursorWithKeySuccess):
(cursorSuccess):

  • storage/indexeddb/resources/open-during-transaction.js:
  • storage/indexeddb/resources/opencursor-key.js:
  • storage/indexeddb/resources/prefetch-bugfix-108071.js:
  • storage/indexeddb/resources/request-event-propagation.js:

(startTest):
(transactionAborted):
(transactionAborted2):

  • storage/indexeddb/resources/set_version_blocked.js:

(blocked):

  • storage/indexeddb/resources/transaction-abort.js:

(startTest):

  • storage/indexeddb/resources/transaction-after-close.js:

(runFirstRegularTransaction):
(firstTransactionComplete):
(onSecondOpen):

  • storage/indexeddb/resources/transaction-basics.js:

(testInvalidMode):

  • storage/indexeddb/resources/transaction-event-propagation.js:

(startTest):
(dbAbortBubbleCallback):

  • storage/indexeddb/resources/transaction-rollback.js:

(setVersionComplete):
(abortCallback):

  • storage/indexeddb/set_version_blocked-expected.txt:
  • storage/indexeddb/structured-clone-expected.txt:
  • storage/indexeddb/structured-clone.html:
  • storage/indexeddb/transaction-abort-expected.txt:
  • storage/indexeddb/transaction-abort-with-js-recursion-cross-frame-expected.txt:
  • storage/indexeddb/transaction-abort-with-js-recursion-cross-frame.html:
  • storage/indexeddb/transaction-abort-with-js-recursion-expected.txt:
  • storage/indexeddb/transaction-abort-with-js-recursion.html:
  • storage/indexeddb/transaction-after-close-expected.txt:
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-event-propagation-expected.txt:
  • storage/indexeddb/transaction-rollback-expected.txt:
  • storage/indexeddb/tutorial.html:
12:11 Changeset [116336] by pilgrim@chromium.org
  • 18 edits
    1 copy in trunk/Source

[Chromium] Move fileSystem to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=85760

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

  • Platform.gypi:
  • chromium/public/Platform.h:

(WebKit):
(Platform):
(WebKit::Platform::fileSystem):

  • chromium/public/WebFileSystem.h: Added.

(WebKit):
(WebFileSystem):
(WebKit::WebFileSystem::move):
(WebKit::WebFileSystem::copy):
(WebKit::WebFileSystem::remove):
(WebKit::WebFileSystem::removeRecursively):
(WebKit::WebFileSystem::readMetadata):
(WebKit::WebFileSystem::createFile):
(WebKit::WebFileSystem::createDirectory):
(WebKit::WebFileSystem::fileExists):
(WebKit::WebFileSystem::directoryExists):
(WebKit::WebFileSystem::readDirectory):
(WebKit::WebFileSystem::createFileWriter):
(WebKit::WebFileSystem::createSnapshotFileAndReadMetadata):
(WebKit::WebFileSystem::~WebFileSystem):

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/platform/WebFileSystem.h:
  • public/platform/WebKitPlatformSupport.h:

(WebKit):
(WebKitPlatformSupport):

  • src/AssertMatchingEnums.cpp:
  • src/AsyncFileSystemChromium.cpp:

(WebCore::AsyncFileSystemChromium::AsyncFileSystemChromium):

  • src/LocalFileSystemChromium.cpp:
  • src/WebFileSystemCallbacksImpl.cpp:
  • src/WebFileSystemCallbacksImpl.h:
  • src/WebFrameImpl.cpp:
  • src/WebWorkerClientImpl.h:
  • src/WorkerAsyncFileSystemChromium.cpp:
  • src/WorkerAsyncFileWriterChromium.cpp:
  • src/WorkerFileSystemCallbacksBridge.h:
  • src/WorkerFileWriterCallbacksBridge.cpp:

(WebKit::WorkerFileWriterCallbacksBridge::initOnMainThread):

12:01 Changeset [116335] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Test the combination of CSP and srcdoc
https://bugs.webkit.org/show_bug.cgi?id=85778

Reviewed by Eric Seidel.

This test ensure that <iframe srcdoc> can't be used to bypass
Content-Security-Policy restrictions on script-src. We already have the
correct behavior. This test just verifies it.

  • http/tests/security/contentSecurityPolicy/srcdoc-doesnt-bypass-script-src-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/srcdoc-doesnt-bypass-script-src.html: Added.
11:57 Changeset [116334] by wjmaclean@chromium.org
  • 6 edits
    5 adds in trunk/Source

[chromium] Create LinkHighlightLayerChromium class to provide link-highlight preview animations for GraphicsLayerChromium.
https://bugs.webkit.org/show_bug.cgi?id=85084

Reviewed by Adrienne Walker.

Source/WebCore:

Unit test provided.

Creates a layer delegate class to provide link highlight animations for link-preview feature.
These are added to a GraphicsLayerChromium via provided methods. Moves dispensing of animation
ids into a separate class.

  • WebCore.gypi:
  • platform/graphics/chromium/AnimationIdVendor.cpp: Added.

(WebCore):
(WebCore::AnimationIdVendor::getNextAnimationId):
(WebCore::AnimationIdVendor::getNextGroupId):

  • platform/graphics/chromium/AnimationIdVendor.h: Added.

(WebCore):
(AnimationIdVendor):

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::updateNames):
(WebCore::GraphicsLayerChromium::addAnimation):
(WebCore::GraphicsLayerChromium::addLinkHighlightLayer):
(WebCore):
(WebCore::GraphicsLayerChromium::didFinishLinkHighlightLayer):
(WebCore::GraphicsLayerChromium::updateChildList):
(WebCore::GraphicsLayerChromium::mapAnimationNameToId):

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(WebCore):
(GraphicsLayerChromium):

  • platform/graphics/chromium/LinkHighlightLayerDelegate.cpp: Added.

(WebCore):
(WebCore::LinkHighlightLayerDelegate::create):
(WebCore::LinkHighlightLayerDelegate::LinkHighlightLayerDelegate):
(WebCore::LinkHighlightLayerDelegate::~LinkHighlightLayerDelegate):
(WebCore::LinkHighlightLayerDelegate::getContentLayer):
(WebCore::LinkHighlightLayerDelegate::paintContents):
(WebCore::LinkHighlightLayerDelegate::didScroll):
(WebCore::LinkHighlightLayerDelegate::notifyAnimationStarted):
(WebCore::LinkHighlightLayerDelegate::notifyAnimationFinished):

  • platform/graphics/chromium/LinkHighlightLayerDelegate.h: Added.

(WebCore):
(LinkHighlightLayerDelegate):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/LinkHighlightLayerDelegateTest.cpp: Added.

(WebCore):
(MockGraphicsLayerClient):
(WebCore::MockGraphicsLayerClient::notifyAnimationStarted):
(WebCore::MockGraphicsLayerClient::notifySyncRequired):
(WebCore::MockGraphicsLayerClient::paintContents):
(WebCore::MockGraphicsLayerClient::showDebugBorders):
(WebCore::MockGraphicsLayerClient::showRepaintCounter):
(WebCore::TEST):

11:54 Changeset [116333] by jsbell@chromium.org
  • 4 edits in trunk/Source

IndexedDB: LevelDB coding for bools is broken
https://bugs.webkit.org/show_bug.cgi?id=85810

Reviewed by Tony Chang.

Source/WebCore:

Code was appending to a pre-sized Vector, rather than using an
index setter. This caused uninitialized data to be written out.
Issue was detected on the Chromium side in http://crbug.com/126388

Tests: webkit_unit_tests --gtest_filter='IDBLevelDBCodingTest.*codeBool'

  • Modules/indexeddb/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::encodeBool):

Source/WebKit/chromium:

Added tests for encodeBool/decodeBool.

  • tests/IDBLevelDBCodingTest.cpp:

(IDBLevelDBCoding::TEST):
(IDBLevelDBCoding):

11:48 Changeset [116332] by shawnsingh@chromium.org
  • 5 edits in trunk/Source

[chromium] CCMathUtil projectPoint needs to avoid divide-by-zero
https://bugs.webkit.org/show_bug.cgi?id=85560

Reviewed by Adrienne Walker.

Source/WebCore:

Unit test added: CCMathUtilTest.cpp - verifyProjectionOfPerpendicularPlane
Unit test updated/renamed: CCLayerTreeHostCommonTest.cpp - verifyVisibleRectFor3dPerspectiveWhenClippedByW

The divide-by-zero occurs in an innocuous case where the layers
are probably invisible anyway. However, producing Infs and NaNs
could cause values to be used when un-intended, so its appropriate
to handle the divide-by-zero correctly.

  • platform/graphics/chromium/cc/CCMathUtil.cpp:

(WebCore::projectPoint):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostCommonTest.cpp:

(WebKitTests::TEST):

  • tests/CCMathUtilTest.cpp:

(WebCore::TEST):
(WebCore):

11:41 Changeset [116331] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Wrong positioning due to wrong width calculation wrt width:0
https://bugs.webkit.org/show_bug.cgi?id=50135

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-05-07
Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/block/block-parent-with-zero-width-child.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computePreferredLogicalWidths):
When width is fixed, the specified width must be taken, provided the value is positive.
Width=0 case was being ignored.

LayoutTests:

  • fast/block/block-parent-with-zero-width-child-expected.txt: Added.
  • fast/block/block-parent-with-zero-width-child.html: Added.
11:34 Changeset [116330] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

[CG] ImageBuffer::ImageDataToDataURL: Remove alpha stuffing when encoding to JPEG
https://bugs.webkit.org/show_bug.cgi?id=85779

Reviewed by Eric Seidel.

No change in behavior. Covered by fast/canvas/webgl/premultiplyalpha-test.html

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageDataToDataURL): Remove the need to stuff the alpha channel with 255.
Rename dataVector to premultipliedData and verify that its resize() worked. Rewrite
the premultiplication loop without the alpha channel = 255 part and ask the CG JPEG
encoder to ignore the alpha channel (kCGImageAlphaNoneSkipLast) instead.

11:34 Changeset [116329] by lforschler@apple.com
  • 4 edits in tags/Safari-536.10.2/Source

Versioning.

11:32 Changeset [116328] by commit-queue@webkit.org
  • 5 edits in trunk

[GTK] media/video-seek-past-end-playing.html times out
https://bugs.webkit.org/show_bug.cgi?id=84858

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-05-07
Reviewed by Philippe Normand.

Source/WebCore:

Removing the intentional state change to PAUSED on didEnd().
My understanding is that the fix works because the additional
state transition to PAUSED was resetting the internal m_seeking state to early,
so that updatePlayState() in HTMLMediaElement was not able to
correctly figure out/recover playstate after seeking.

No new tests, covered by existing media tests, and fixing
video-seek-past-end-playing.html flakiness on GTK, failure on EFL.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

LayoutTests:

video-seek-past-end-playing.html should work reliably after fix, removing.

  • platform/gtk/test_expectations.txt:
11:30 Changeset [116327] by lforschler@apple.com
  • 1 copy in tags/Safari-536.10.2

New Tag.

11:30 Changeset [116326] by lforschler@apple.com
  • 4 edits in tags/Safari-536.10.1/Source

Fix versioning for 536.10.1.

11:27 Changeset [116325] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash in RenderBlock::updateFirstLetterStyle.
https://bugs.webkit.org/show_bug.cgi?id=85759

Reviewed by Julien Chaffraix.

Source/WebCore:

Test: fast/css-generated-content/first-letter-next-sibling-crash.html

RenderBlock::removeChild can bring up the children from last single anonymous block,
causing |nextSibling| in RenderBlock::updateFirstLetterStyle to go stale. We prevent
this by removing the child safely using removeChildNode before destroying it.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetterStyle):

LayoutTests:

  • fast/css-generated-content/first-letter-next-sibling-crash-expected.txt: Added.
  • fast/css-generated-content/first-letter-next-sibling-crash.html: Added.
11:24 Changeset [116324] by lforschler@apple.com
  • 4 edits in tags/Safari-536.10.1/Source

Versioning.

11:24 Changeset [116323] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK gardening.

  • platform/gtk/test_expectations.txt: Mark

fast/events/message-port-close.html as crashing in debug builds.

11:16 Changeset [116322] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK gardening.

  • platform/gtk/test_expectations.txt: Mark new mediastream test as

expected failure.

10:56 Changeset [116321] by tommyw@google.com
  • 9 edits in trunk/Source

MediaStream API: Rename MediaStreamCenter::didConstructMediaStream
https://bugs.webkit.org/show_bug.cgi?id=85796

Reviewed by Adam Barth.

Source/Platform:

Renamed WebMediaStreamCenter::didConstructMediaStream to didCreateMediaStream,
and change so that it is only called for MediaStreams created from JS.
Also send out the WebMediaStreamDescriptor non-const instead.

  • chromium/public/WebMediaStreamCenter.h:

(WebKit::WebMediaStreamCenter::didCreateMediaStream):
(WebMediaStreamCenter):
(WebKit::WebMediaStreamCenter::didConstructMediaStream):

Source/WebCore:

Renamed MediaStreamCenter::didConstructMediaStream to didCreateMediaStream,
and change so that it is only called for MediaStreams created from JS.

Not really testable.

  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::create):

  • platform/mediastream/MediaStreamCenter.h:

(MediaStreamCenter):

  • platform/mediastream/chromium/MediaStreamCenterChromium.cpp:

(WebCore::MediaStreamCenterChromium::didCreateMediaStream):

  • platform/mediastream/chromium/MediaStreamCenterChromium.h:

(MediaStreamCenterChromium):

  • platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:

(WebCore::MediaStreamCenterGStreamer::didCreateMediaStream):

  • platform/mediastream/gstreamer/MediaStreamCenterGStreamer.h:

(MediaStreamCenterGStreamer):

10:42 Changeset [116320] by mitz@apple.com
  • 3 edits in trunk/Websites/webkit.org

webkit.org instructions for debugging WebProcess are unnecessarily complex
https://bugs.webkit.org/show_bug.cgi?id=85756

Reviewed by Darin Adler.

  • building/debug.html: Added instructions for setting up and using the WebKit workspace for

debugging the Web process, as well as instructions for debugging the Web process from the
command line using debug-safari and debug-minibrowser.

  • building/tools.html: Updated links and tweaked the language.
10:37 Changeset [116319] by nduca@chromium.org
  • 18 edits in trunk/Source

Unreviewed, rolling out r115525.
http://trac.webkit.org/changeset/115525
https://bugs.webkit.org/show_bug.cgi?id=66683

Too many pages rely on DOMTimeStamp as first argument.
Reverting while we consider next steps.

Source/WebCore:

  • WebCore.exp.in:
  • bindings/js/JSRequestAnimationFrameCallbackCustom.cpp:

(WebCore::JSRequestAnimationFrameCallback::handleEvent):

  • dom/Document.cpp:

(WebCore::Document::serviceScriptedAnimations):

  • dom/Document.h:

(Document):

  • dom/RequestAnimationFrameCallback.h:

(RequestAnimationFrameCallback):

  • dom/RequestAnimationFrameCallback.idl:
  • dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::ScriptedAnimationController):
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
(WebCore):
(WebCore::ScriptedAnimationController::windowScreenDidChange):
(WebCore::ScriptedAnimationController::scheduleAnimation):
(WebCore::ScriptedAnimationController::animationTimerFired):

  • dom/ScriptedAnimationController.h:

(ScriptedAnimationController):
(WebCore::ScriptedAnimationController::displayRefreshFired):

  • page/FrameView.cpp:

(WebCore::FrameView::serviceScriptedAnimations):

  • page/FrameView.h:

(FrameView):

  • platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::notifyClients):

  • platform/graphics/DisplayRefreshMonitor.h:

(DisplayRefreshMonitor):

  • platform/graphics/blackberry/DisplayRefreshMonitorBlackBerry.cpp:

(WebCore::DisplayRefreshMonitor::displayLinkFired):

  • platform/graphics/mac/DisplayRefreshMonitorMac.cpp:

(WebCore):
(WebCore::DisplayRefreshMonitor::requestRefreshCallback):
(WebCore::DisplayRefreshMonitor::displayLinkFired):

Source/WebKit/chromium:

  • src/PageWidgetDelegate.cpp:

(WebKit::PageWidgetDelegate::animate):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::updateAnimations):

10:32 Changeset [116318] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Add methods need by client side
https://bugs.webkit.org/show_bug.cgi?id=85661

Patch by Crystal Zhang <haizhang@rim.com> on 2012-05-07
Reviewed by Antonio Gomes.

Add methods needed by client side when create and close HTML popup dialogs.
PR 154360

  • Api/WebPageClient.h:
10:32 Changeset [116317] by tommyw@google.com
  • 9 edits in trunk/Source

MediaStream API: Allow UserMediaRequest::succeed to take an MediaStreamDescriptor
https://bugs.webkit.org/show_bug.cgi?id=85798

Reviewed by Adam Barth.

Source/Platform:

Adding another UserMediaRequest::succeed function that takes an MediaStreamDescriptor
instead of the two MediaStreamSource arrays.

  • chromium/public/WebMediaStreamCenter.h:

(WebMediaStreamCenter):
(WebKit::WebMediaStreamCenter::constructSDP):

Source/WebCore:

Adding another UserMediaRequest::succeed function that takes an MediaStreamDescriptor
instead of the two MediaStreamSource arrays.

Not currently testable.

  • Modules/mediastream/LocalMediaStream.cpp:

(WebCore::LocalMediaStream::create):
(WebCore):
(WebCore::LocalMediaStream::LocalMediaStream):

  • Modules/mediastream/LocalMediaStream.h:

(LocalMediaStream):

  • Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::succeed):
(WebCore):

  • Modules/mediastream/UserMediaRequest.h:

(WebCore):
(UserMediaRequest):

Source/WebKit/chromium:

Adding another WebUserMediaRequest::requestSucceed function that takes an
WebMediaStreamDescriptor instead of the two WebMediaStreamSource arrays.

  • public/WebUserMediaRequest.h:

(WebKit):
(WebUserMediaRequest):

  • src/WebUserMediaRequest.cpp:

(WebKit::WebUserMediaRequest::requestSucceeded):

10:25 Changeset [116316] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] setContentsMemoryAllocationLimitBytes needs to setNeedsCommit.
https://bugs.webkit.org/show_bug.cgi?id=85801

Patch by Michal Mocny <mmocny@google.com> on 2012-05-07
Reviewed by Adrienne Walker.

CCLayerTreeHost::setContentsMemoryAllocationLimitBytes needs to call setNeedsCommit after adjusting memory
limits, so that we push a new frame. In particular, when returning from non visibile state, we adjust
memory allocation from 0 to non 0, and we need to push a non blank frame.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::setContentsMemoryAllocationLimitBytes):

10:21 Changeset [116315] by tommyw@google.com
  • 6 edits
    2 adds in trunk

[chromium] MediaStream API: Enhance WebUserMediaClientMock and add a test for it
https://bugs.webkit.org/show_bug.cgi?id=85618

Reviewed by Adam Barth.

Adding the capability to control which MediaStreamTracks actually get created,
and adding a test that exercises the JS api using that capability.

Tools:

  • DumpRenderTree/chromium/WebUserMediaClientMock.cpp:

(WebKit::WebUserMediaClientMock::requestUserMedia):

  • DumpRenderTree/chromium/WebUserMediaClientMock.h:
  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::testMediaStreamClient):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

LayoutTests:

  • fast/mediastream/getusermedia-expected.txt: Added.
  • fast/mediastream/getusermedia.html: Added.
10:20 Changeset [116314] by lforschler@apple.com
  • 1 copy in branches/safari-536-branch

New branch.

09:26 Changeset [116313] by commit-queue@webkit.org
  • 6 edits in trunk

[EFL] media/track/track-cue-rendering-snap-to-lines-not-set.html fails
https://bugs.webkit.org/show_bug.cgi?id=85602

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-07
Reviewed by Eric Carlson.

Source/WebCore:

Fix positioning of the controls panel back to relative, as it is
in the parent CSS.

  • css/mediaControlsEfl.css:

(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):

LayoutTests:

Update expected result for several media tests now that the
positioning of the controls panel is relative.

  • platform/efl/media/media-controls-clone-expected.txt:
  • platform/efl/media/video-empty-source-expected.txt:
  • platform/efl/media/video-zoom-controls-expected.txt:
08:05 Changeset [116312] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening, fix failure expectation for test.

  • platform/efl/test_expectations.txt:
08:02 Changeset [116311] by adam.bergkvist@ericsson.com
  • 6 edits in trunk/Source/WebCore

MediaStream should not be an ActiveDOMObject
https://bugs.webkit.org/show_bug.cgi?id=85191

Reviewed by Adam Barth.

The model with MediaStreamDescriptor and MediaStream (and LocalMediaStream)
allows the JavaScript objects (MediaStream and LocalMediaStream) to be
cleaned up while the MediaStreamDescriptor lives on to manage the stream in
the platform. This happens for example when a URL is created to represent
a MediaStream (using createObjectURL()). In that case, the MediaStreamDescriptor
is put into the MediaStreamRegistry and even though the MediaStream object is
lost, the URL still works since the descriptor is kept in the registry.

The changes introduced in r113460 (http://webkit.org/b/83143) turned
MediaStream and LocalMediaStream into ActiveDOMObjects. For example on page
reload, LocalMediaStream calls MediaStreamCenter::didStopLocalMediaStream()
via its ActiveDOMObject::stop() method. However, when a page reload occurs,
the LocalMediaStream object may have been cleaned up already and
MediaStreamCenter::didStopLocalMediaStream() will not be called.

One way to make the behavior consistent would be to call
MediaStreamCenter::didStopLocalMediaStream() when the descriptor is cleaned up,
cause then we wouldn't be dependent on the LocalMediaStream object being alive.
However, calling MediaStreamCenter::didStopLocalMediaStream() might not be the
correct thing to do when all references to the descriptor are lost since there
can be MediaStream objects constructed from the tracks of the LocalMediaStream
that should continue to work. MediaStreamCenter::didStopLocalMediaStream() was
intended for LocalMediaStream.stop() which is used to revoke access to devices;
that should not necessarily happen when the descriptor of a LocalMediaStream is
cleaned up. If it's necessary for some ports to signal to the platform that a
MediaStreamDescriptor is cleaned up, then I would suggest adding a new function,
willDestroyMediaStreamDescriptor(), to the MediaStreamCenter interface.

The current resolution is to make MediaStream a ContextDestructionObserver
instead of an ActiveDOMObject.

Currently not testable.

  • Modules/mediastream/LocalMediaStream.cpp:

(WebCore::LocalMediaStream::create):

  • Modules/mediastream/LocalMediaStream.h:

(LocalMediaStream):

  • Modules/mediastream/LocalMediaStream.idl:
  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::create):
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::scriptExecutionContext):

  • Modules/mediastream/MediaStream.h:
08:01 Changeset [116310] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

[Gtk] WebGL feature is not built anymore through build-webkit after r116251
https://bugs.webkit.org/show_bug.cgi?id=85788

Reviewed by Martin Robinson.

Enable WebGL by default for the Gtk port. The feature is already enabled by
default in configure.ac, so there's no reason it shouldn't be enabled when
building through build-webkit.

  • Scripts/webkitperl/FeatureList.pm:
07:46 Changeset [116309] by mihnea@adobe.com
  • 3 edits
    2 adds
    18 deletes in trunk/LayoutTests

[CSSRegions]Convert (some) region style tests to ref tests
https://bugs.webkit.org/show_bug.cgi?id=85783

Reviewed by Andreas Kling.

  • fast/regions/region-style-image-background-color-expected.html: Added.
  • fast/regions/region-style-image-background-color.html:
  • fast/regions/region-style-inline-background-color-expected.html: Added.
  • fast/regions/region-style-inline-background-color.html:
  • platform/chromium-linux/fast/regions/region-style-image-background-color-expected.png: Removed.
  • platform/chromium-linux/fast/regions/region-style-inline-background-color-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/regions/region-style-image-background-color-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/regions/region-style-inline-background-color-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/regions/region-style-image-background-color-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/regions/region-style-inline-background-color-expected.png: Removed.
  • platform/chromium-mac/fast/regions/region-style-image-background-color-expected.png: Removed.
  • platform/chromium-mac/fast/regions/region-style-inline-background-color-expected.png: Removed.
  • platform/chromium-win/fast/regions/region-style-image-background-color-expected.png: Removed.
  • platform/chromium-win/fast/regions/region-style-image-background-color-expected.txt: Removed.
  • platform/chromium-win/fast/regions/region-style-inline-background-color-expected.png: Removed.
  • platform/chromium-win/fast/regions/region-style-inline-background-color-expected.txt: Removed.
  • platform/gtk/fast/regions/region-style-image-background-color-expected.txt: Removed.
  • platform/gtk/fast/regions/region-style-inline-background-color-expected.txt: Removed.
  • platform/mac/fast/regions/region-style-image-background-color-expected.png: Removed.
  • platform/mac/fast/regions/region-style-image-background-color-expected.txt: Removed.
  • platform/mac/fast/regions/region-style-inline-background-color-expected.png: Removed.
  • platform/mac/fast/regions/region-style-inline-background-color-expected.txt: Removed.
07:32 Changeset [116308] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk

[BlackBerry] WWW-Authenticate header on 200 response pops up authentication dialog
https://bugs.webkit.org/show_bug.cgi?id=85643

Patch by Liam Quinn <lquinn@rim.com> on 2012-05-07
Reviewed by George Staikos.

.:

RIM PR: 151992
Added manual test for WWW-Authenticate header on a 200 response.

  • ManualTests/blackberry/http-auth-on-200.php: Added.

Source/WebCore:

RIM PR: 151992
Ignore WWW-Authenticate header if the response code is not 401.
Ignore Proxy-Authenticate header if the response code is not 407.

Manual test added to observe whether the authentication dialog appears on a 200 response with WWW-Authenticate.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::handleNotifyHeaderReceived):

07:10 Changeset [116307] by alexis.menard@openbossa.org
  • 2 edits
    4 adds in trunk/LayoutTests

Unreviewed gardening for Qt port. Updating expectation files and skipped tests which are
timing out.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0-wk2/fullscreen/full-screen-placeholder-expected.txt: Added.
  • platform/qt-5.0-wk2/fullscreen/full-screen-render-inline-expected.txt: Added.
  • platform/qt-5.0-wk2/fullscreen/parent-flow-inline-with-block-child-expected.txt: Added.
07:06 Changeset [116306] by ossy@webkit.org
  • 2 edits in trunk/Tools

Unittest fix after r116288, because now there are more than 5 hit for the 'Eric' word.
We have only 2 'Gavin', so it is a better choice than 'Eric' for unit testing.

Reviewed by Tor Arne Vestbø.

  • Scripts/webkitpy/tool/bot/irc_command_unittest.py:

(IRCCommandTest.test_whois):

06:38 Changeset [116305] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [TextPrompt] Event listeners and CSS style are not removed on detachment
https://bugs.webkit.org/show_bug.cgi?id=85789

Reviewed by Yury Semikhatsky.

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.prototype.detach):

05:58 Changeset [116304] by ossy@webkit.org
  • 8 edits
    8 deletes in trunk

Unreviewed, rolling out r116299, r116301, and r116303.
http://trac.webkit.org/changeset/116299
http://trac.webkit.org/changeset/116301
http://trac.webkit.org/changeset/116303
https://bugs.webkit.org/show_bug.cgi?id=85795

Build is still broken (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-07

Source/WebKit2:

  • qt/MainQt.cpp:

(main):

Tools:

  • DumpRenderTree/qt/DumpRenderTree.pro:
  • DumpRenderTree/qt/main.cpp:

(main):

  • QtTestPlatformPlugin/QtTestPlatformPlugin.pro: Removed.
  • QtTestPlatformPlugin/TestIntegration.cpp: Removed.
  • QtTestPlatformPlugin/TestIntegration.h: Removed.
  • QtTestPlatformPlugin/mac/TestFontDatabase.h: Removed.
  • QtTestPlatformPlugin/mac/TestFontDatabase.mm: Removed.
  • QtTestPlatformPlugin/mac/TestIntegrationMac.mm: Removed.
  • QtTestPlatformPlugin/main.cpp: Removed.
  • QtTestPlatformPlugin/testplatform.json: Removed.
  • Tools.pro:
  • WebKitTestRunner/Target.pri:
  • WebKitTestRunner/qt/main.cpp:

(main):

05:30 Changeset [116303] by kbalazs@webkit.org
  • 2 edits in trunk/Tools

Unreviewed Qt build fix.

One more try to learn how to use
const with a pointer array.

  • DumpRenderTree/qt/main.cpp:

(initializeTestPlatformPlugin):

05:30 Changeset [116302] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Icon database path may be NULL when a new path was set.
https://bugs.webkit.org/show_bug.cgi?id=82456

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2012-05-07
Reviewed by Andreas Kling.

ewk_settings_icon_database_path_set calls asynchronous method WebCore::iconDatabase().open().
There is no notification when the new path is set by WebCore.
Moreover ewk_settings_icon_database_path_set keeps the new path in a local variable.

To retrieve path to icon database ewk_settings_icon_database_path_get can be called.
It first checks flags whether icon databse is opened and enabled. There is possibility
that icon database has been set through API but it hasn't been opened by WebCore yet.
So as a result ewk_settings_icon_database_path_get returns NULL because WebCore hasn't
set an appropriate flag yet.

It may happen while icon database set/get sequences.
Information whether icon database is opened/enabled should be exposed by separate API.

  • ewk/ewk_settings.cpp:

(ewk_settings_icon_database_path_get): Skip checking whether icon database is opened, enabled.

  • ewk/ewk_settings.h:
05:15 Changeset [116301] by kbalazs@webkit.org
  • 2 edits in trunk/Tools

Unreviewed build fix after r116299.

  • DumpRenderTree/qt/main.cpp:

(initializeTestPlatformPlugin):

04:59 Changeset [116300] by alexis.menard@openbossa.org
  • 5 edits in trunk/LayoutTests

[Qt] Enable fullscreen api layout tests on WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=85616

Reviewed by Csaba Osztrogonác.

http://trac.webkit.org/changeset/116089 implements the fullscreen API for WebKit2,
we can now unskip the related tests.

  • platform/qt-4.8/Skipped:
  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt/Skipped:
04:49 Changeset [116299] by kbalazs@webkit.org
  • 8 edits
    10 adds in trunk

[Qt] Add test specific platform plugin to achieve unified layout test results
https://bugs.webkit.org/show_bug.cgi?id=80996

Reviewed by Simon Hausmann.

Source/WebKit2:

Initialize the test platform plugin before initializing
the web process if we are in a WTR run.
It is necessary to place this initialization here as we
cannot control wich platform plugin will be used after
the instantiation of the QApplication.

  • qt/MainQt.cpp:

(initializeTestPlatformPluginForWTRIfRequired):
(main):

Tools:

Added QtTestPlatformPlugin as a new project under Tools.
This is a Qt5-ish platform plugin that can be used to tweak the
platform support interfaces in order to unify layout test results.
For now it only overrides the font database on Mac and redirects
everything else to the real platform plugin. The font database it
provides mimics the way how we set up test fonts with fontconfig on Linux.
Make DumpRenderTree and WebKitTestRunner use this platform plugin.

  • DumpRenderTree/qt/DumpRenderTree.pro:
  • DumpRenderTree/qt/main.cpp:

(initializeTestPlatformPlugin):
(main):

  • QtTestPlatformPlugin/QtTestPlatformPlugin.pro: Added.
  • QtTestPlatformPlugin/TestIntegration.cpp: Added.

(TestIntegration::TestIntegration):
(TestIntegration::fontDatabase):

  • QtTestPlatformPlugin/TestIntegration.h: Added.

(TestIntegration):
(TestIntegration::hasCapability):
(TestIntegration::createPlatformPixmap):
(TestIntegration::createPlatformWindow):
(TestIntegration::createPlatformBackingStore):
(TestIntegration::createPlatformOpenGLContext):
(TestIntegration::createPlatformSharedGraphicsCache):
(TestIntegration::guiThreadEventDispatcher):
(TestIntegration::clipboard):
(TestIntegration::drag):
(TestIntegration::inputContext):
(TestIntegration::accessibility):
(TestIntegration::nativeInterface):
(TestIntegration::services):
(TestIntegration::styleHint):
(TestIntegration::platformTheme):

  • QtTestPlatformPlugin/mac/TestFontDatabase.h: Added.

(TestFontDatabase):

  • QtTestPlatformPlugin/mac/TestFontDatabase.mm: Added.

(TestFontDatabase::populateFontDatabase):

  • QtTestPlatformPlugin/mac/TestIntegrationMac.mm: Added.

(TestIntegration::fontDatabase):

  • QtTestPlatformPlugin/main.cpp: Added.

(TestIntegrationPlugin::keys):
(TestIntegrationPlugin::create):
(TestIntegrationPlugin::initialize):

  • QtTestPlatformPlugin/testplatform.json: Added.
  • Tools.pro:
  • WebKitTestRunner/Target.pri:
  • WebKitTestRunner/qt/main.cpp:

(main):

04:43 Changeset [116298] by ossy@webkit.org
  • 2 edits in trunk/Source/WebCore

Buildfix for buggy GCC
https://bugs.webkit.org/show_bug.cgi?id=85781

Reviewed by Zoltan Herczeg.

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::MarginInfo::clearMargin):

04:34 Changeset [116297] by commit-queue@webkit.org
  • 2 edits
    4 deletes in trunk/LayoutTests

[EFL][DRT] Gardening current IMAGE failures
https://bugs.webkit.org/show_bug.cgi?id=85604

Unreviewed, EFL gardening.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-05-07

  • platform/efl/fast/forms/input-placeholder-text-indent-expected.png: Removed.
  • platform/efl/fast/forms/isindex-placeholder-expected.png: Removed.
  • platform/efl/fast/forms/placeholder-with-positioned-element-expected.png: Removed.
  • platform/efl/fast/forms/textarea-placeholder-wrapping-expected.png: Removed.
  • platform/efl/test_expectations.txt:
04:26 Changeset [116296] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] media/video-poster-blocked-by-willsendrequest.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=85609

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-07
Reviewed by Simon Hausmann.

Flakiness was caused by the fact that
media/crash-closing-page-with-media-as-plugin-fallback.html and
media/video-poster-blocked-by-willsendrequest.html use the same PNG
file as poster attribute in the video tag. The PNG file gets cached
when the first test is executed and this somehow causes the second
test to fail.

The flakiness was addressed by clearing the memory and page caches
between tests.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

04:21 Changeset [116295] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, refined expectations for compositing failures + more suppressions.

  • platform/chromium/test_expectations.txt:
04:13 Changeset [116294] by eric@webkit.org
  • 2 edits in trunk/Tools

Add values for all features to Qt's features.pri
https://bugs.webkit.org/show_bug.cgi?id=85746

Reviewed by Tor Arne Vestbø.

When generate-feature-files generates features.pri it provides a value
for every possible ENABLE_. In prepration for landing generate-feature-files
it seems appropriate to add a value for all possible ENABLEs to the existing
features.pri. This lets me make sure that I'm getting them all right!

  • qmake/mkspecs/features/features.pri:
03:30 Changeset [116293] by apavlov@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: [REGRESSION] Context menu for the left Script view gutter is broken
https://bugs.webkit.org/show_bug.cgi?id=85785

Reviewed by Pavel Feldman.

Fixed remaining usages of WebInspector.save to be WebInspector.fileManager.save.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._exportAll):
(WebInspector.NetworkLogView.prototype._exportRequest):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameResourceTreeElement.prototype._appendSaveAsAction.doSave):
(WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent.doSave):

  • inspector/front-end/TextViewer.js:

(WebInspector.TextViewer.prototype._contextMenu):

03:07 Changeset [116292] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, more compositing test timeouts.

  • platform/chromium/test_expectations.txt:
02:56 Changeset [116291] by antti@apple.com
  • 29 edits
    6 adds in trunk

Share stylesheet data structures between documents
https://bugs.webkit.org/show_bug.cgi?id=85598

Source/WebCore:

Reviewed by Darin Adler.

We currently make a copy of the data structures when restoring a cached stylesheet. This patch lets us share
the data until someone uses a mutating CSSOM API to modify the sheet.

The patch implements copy-on-write for the internal style sheet data structures. If any mutating CSSOM API is
invoked, we check if the mutation is safe (there is only one client, the sheet is not cached). If not then the
internal structures are copied and any existing CSSOM objects are re-attached to the new style tree. The copied
tree is mutated while the other clients stay attached to the original tree.

Sharing can save significant amount of memory on sites with large stylesheets. For example if you have
multiple articles open on wsj.com this saves ~2.6MB per tab.

Test: http/tests/css/shared-stylesheet-mutation.html

http/tests/css/shared-stylesheet-mutation-preconstruct.html

  • css/CSSFontFaceRule.cpp:

(WebCore::CSSFontFaceRule::reattach):
(WebCore):

  • css/CSSFontFaceRule.h:

(CSSFontFaceRule):

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::insertRule):
(WebCore::CSSMediaRule::deleteRule):
(WebCore::CSSMediaRule::reattach):
(WebCore):

  • css/CSSMediaRule.h:

(CSSMediaRule):

  • css/CSSPageRule.cpp:

(WebCore::CSSPageRule::setSelectorText):
(WebCore::CSSPageRule::reattach):
(WebCore):

  • css/CSSPageRule.h:

(CSSPageRule):

  • css/CSSRule.cpp:

(WebCore::CSSRule::reattach):

After the internal stylerule tree has been copied, the existing wrappers are re-attached using recursive reattach() function.

  • css/CSSRule.h:

(WebCore):
(CSSRule):

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::setSelectorText):
(WebCore::CSSStyleRule::reattach):
(WebCore):

  • css/CSSStyleRule.h:

(CSSStyleRule):

  • css/CSSStyleSheet.cpp:

(WebCore::StyleSheetInternal::StyleSheetInternal):
(WebCore::StyleSheetInternal::isCacheable):
(WebCore::StyleSheetInternal::ruleAt):

Add ruleAt(), use it for both wrapper creation and reattaching. Remove createChildRuleCSSOMWrapper .

(WebCore):
(WebCore::StyleSheetInternal::wrapperInsertRule):
(WebCore::StyleSheetInternal::wrapperDeleteRule):

Invalidation moves to the calling wrapper.

(WebCore::StyleSheetInternal::addedToMemoryCache):
(WebCore::StyleSheetInternal::removedFromMemoryCache):
(WebCore::CSSStyleSheet::willMutateRules):

This is called whenever StyleSheetInternal is going to be mutated. It will do copy-on-write if needed.


Usually invoked by CSSStyleSheet::RuleMutation RAII type.

(WebCore::CSSStyleSheet::didMutateRules):

This is called after the mutation is complete and will trigger the style recalc in the document.

(WebCore::CSSStyleSheet::didMutate):

This is called directly after mutations that don't change StyleSheetInternal so don't require copy-on-write.

(WebCore::CSSStyleSheet::reattachChildRuleCSSOMWrappers):
(WebCore::CSSStyleSheet::setDisabled):
(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::deleteRule):

  • css/CSSStyleSheet.h:

(StyleSheetInternal):
(WebCore::StyleSheetInternal::hasOneClient):
(WebCore::StyleSheetInternal::isMutable):
(WebCore::StyleSheetInternal::setMutable):

Track mutability. Mutation is allowed only after willMutate call.

(WebCore::StyleSheetInternal::isInMemoryCache):

Track if the object is in memory cache.

(WebCore::CSSStyleSheet::clearOwnerRule):
(CSSStyleSheet):

  • css/MediaList.cpp:

(WebCore::MediaList::setMediaText):
(WebCore::MediaList::deleteMedium):
(WebCore::MediaList::appendMedium):
(WebCore::MediaList::didMutate):
(WebCore):
(WebCore::MediaList::reattach):

  • css/MediaList.h:

(MediaList):

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
(WebCore):
(WebCore::StyleRuleCSSStyleDeclaration::willMutate):
(WebCore::StyleRuleCSSStyleDeclaration::didMutate):
(WebCore::StyleRuleCSSStyleDeclaration::reattach):
(WebCore::InlineCSSStyleDeclaration::didMutate):

  • css/PropertySetCSSStyleDeclaration.h:

(WebCore::PropertySetCSSStyleDeclaration::willMutate):
(WebCore::PropertySetCSSStyleDeclaration::didMutate):
(StyleRuleCSSStyleDeclaration):

  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::setName):
(WebCore::WebKitCSSKeyframesRule::insertRule):
(WebCore::WebKitCSSKeyframesRule::deleteRule):
(WebCore::WebKitCSSKeyframesRule::reattach):
(WebCore):

  • css/WebKitCSSKeyframesRule.h:

(WebKitCSSKeyframesRule):

  • css/WebKitCSSRegionRule.cpp:

(WebCore::WebKitCSSRegionRule::reattach):

  • css/WebKitCSSRegionRule.h:

(WebKitCSSRegionRule):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::reparseStyleSheet):

  • loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::~CachedCSSStyleSheet):
(WebCore::CachedCSSStyleSheet::destroyDecodedData):
(WebCore::CachedCSSStyleSheet::restoreParsedStyleSheet):

Don't copy when restoring. It is no longer necessary.
Set the cache bit on the stylesheet.

(WebCore::CachedCSSStyleSheet::saveParsedStyleSheet):

LayoutTests:

Reviewed by Darin Adler.

Test that mutations of a shared stylesheet work as expected.

This is an http test due to cross-document security restrictions with file urls
(they can be overriden in DRT but I'd like this to work in browser too).

  • http/tests/css/resources/shared.css: Added.
  • http/tests/css/resources/shared-stylesheet-mutation.js: Added.
  • http/tests/css/shared-stylesheet-mutation-expected.txt: Added.
  • http/tests/css/shared-stylesheet-mutation-preconstruct-expected.txt: Added.
  • http/tests/css/shared-stylesheet-mutation-preconstruct.html: Added.
  • http/tests/css/shared-stylesheet-mutation.html: Added.
02:47 Changeset [116290] by kinuko@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed: the same fix in another file for chromium win build. Adding WebCore namespace to FileSystemTypes.

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::createFileSystem):
(WebKit::WebFrameImpl::createFileEntry):

02:46 Changeset [116289] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, fast/text/international/thai-{baht-space,line-breaks}.html now fail in release, too.

  • platform/chromium/test_expectations.txt:
02:31 Changeset [116288] by adam.bergkvist@ericsson.com
  • 2 edits in trunk/Tools

Added myself as a committer.

Not reviewed.

  • Scripts/webkitpy/common/config/committers.py:
02:29 Changeset [116287] by kinuko@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Not reviewed: chromium win build fix attempt; adding WebCore namespace to ambiguous type name.

  • src/WebFileSystemCallbacksImpl.cpp:

(WebKit::WebFileSystemCallbacksImpl::WebFileSystemCallbacksImpl):

02:21 Changeset [116286] by hausmann@webkit.org
  • 2 edits in trunk

[Qt] Unreviewed trivial build fix: Don't include bytearraytestdata.h in the QtWebKit
module header.

  • Source/sync.profile:
02:20 Changeset [116285] by commit-queue@webkit.org
  • 8 edits in trunk

[EFL][DRT] Implement LayoutTestController::execCommand
https://bugs.webkit.org/show_bug.cgi?id=82286

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-07
Reviewed by Antonio Gomes.

Source/WebKit/efl:

Add missing implementation execCommand and isCommandEnabled to EFL's
DumpRenderTreeSupport to execute an internal command and check if the
command is enabled.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::executeCoreCommandByName):
(DumpRenderTreeSupportEfl::isCommandEnabled):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Add missing implementation execCommand and isCommandEnabled to EFL's
LayoutTestController.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::execCommand):
(LayoutTestController::isCommandEnabled):

LayoutTests:

Unskipped test cases which rely on execCommand and
updated test expectations for failure test cases.

  • platform/efl/Skipped:
  • platform/efl/test_expectations.txt:
02:17 Changeset [116284] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, compositing/overflow/scrollbar-painting.html times out on mac & linux.

  • platform/chromium/test_expectations.txt:
01:57 Changeset [116283] by kinuko@chromium.org
  • 13 edits in trunk/Source

Cleanup: Change boolean synchronous flag argument into enum in FileSystem API code
https://bugs.webkit.org/show_bug.cgi?id=85741

Reviewed by David Levin.

Source/WebCore:

No new tests as this change has no functional effects.

  • Modules/filesystem/DOMWindowFileSystem.cpp:

(WebCore::DOMWindowFileSystem::webkitRequestFileSystem):

  • Modules/filesystem/LocalFileSystem.cpp:

(WebCore::LocalFileSystem::requestFileSystem):

  • Modules/filesystem/LocalFileSystem.h:

(LocalFileSystem):

  • Modules/filesystem/WorkerContextFileSystem.cpp:

(WebCore::WorkerContextFileSystem::webkitRequestFileSystem):
(WebCore::WorkerContextFileSystem::webkitRequestFileSystemSync):
(WebCore::WorkerContextFileSystem::webkitResolveLocalFileSystemSyncURL):

  • platform/FileSystemType.h: Added FileSystemSynchronousType enum.

Source/WebKit/chromium:

  • src/LocalFileSystemChromium.cpp:

(WebCore::openFileSystemHelper):
(WebCore::LocalFileSystem::readFileSystem):
(WebCore::LocalFileSystem::requestFileSystem):

  • src/WebFileSystemCallbacksImpl.cpp:

(WebKit::WebFileSystemCallbacksImpl::WebFileSystemCallbacksImpl):
(WebKit::WebFileSystemCallbacksImpl::didOpenFileSystem):

  • src/WebFileSystemCallbacksImpl.h:

(WebFileSystemCallbacksImpl):

  • src/WorkerAsyncFileSystemChromium.cpp:

(WebCore::WorkerAsyncFileSystemChromium::WorkerAsyncFileSystemChromium):
(WebCore::WorkerAsyncFileSystemChromium::createWorkerFileSystemCallbacksBridge):

  • src/WorkerAsyncFileSystemChromium.h:

(WebCore::WorkerAsyncFileSystemChromium::create):
(WorkerAsyncFileSystemChromium):

01:42 Changeset [116282] by antti@apple.com
  • 2 edits in trunk/Source/WebCore

Revert the previous.

Not reviewed.

Apparently r116235 was already rolled out.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::determineScope):

01:13 Changeset [116281] by antti@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION(r116235): broke a lot of tests on all chromium debug bots
https://bugs.webkit.org/show_bug.cgi?id=85773

Not reviewed.

Try to fix assert when scoped stylesheets are enabled.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::determineScope):

00:39 Changeset [116280] by kinuko@chromium.org
  • 23 edits
    1 copy in trunk/Source

Cleanup: Move FileSystem API type definitions into a separate header file
https://bugs.webkit.org/show_bug.cgi?id=85738

Reviewed by David Levin.

Move FileSystem API type definitions from AsyncFileSystem.h and
AsyncFileSystemChromium.cpp for chromium port into a single separate
header file: FileSystemType.h

By doing this we make it clearer that every filesystem type can be
found in the header file and also can save including entire
AsyncFileSystem definition just for referring type enum value.

Source/WebCore:

No new tests as this change has no visible or functional changes.

  • Modules/filesystem/DOMFileSystemBase.cpp:

(WebCore::pathToAbsolutePath):

  • Modules/filesystem/DOMWindowFileSystem.cpp:

(WebCore::DOMWindowFileSystem::webkitRequestFileSystem):
(WebCore::DOMWindowFileSystem::webkitResolveLocalFileSystemURL):
(WebCore):

  • Modules/filesystem/DOMWindowFileSystem.h:
  • Modules/filesystem/LocalFileSystem.h:

(LocalFileSystem):

  • Modules/filesystem/WorkerContextFileSystem.cpp:

(WebCore::WorkerContextFileSystem::webkitRequestFileSystem):
(WebCore::WorkerContextFileSystem::webkitRequestFileSystemSync):
(WebCore::WorkerContextFileSystem::webkitResolveLocalFileSystemURL):
(WebCore::WorkerContextFileSystem::webkitResolveLocalFileSystemSyncURL):
(WebCore):

  • Modules/filesystem/WorkerContextFileSystem.h:
  • platform/AsyncFileSystem.cpp:

(WebCore::AsyncFileSystem::isValidType):
(WebCore::AsyncFileSystem::create):
(WebCore::AsyncFileSystem::openFileSystem):

  • platform/AsyncFileSystem.h:

(AsyncFileSystem):
(WebCore::AsyncFileSystem::type):
(WebCore::AsyncFileSystem::AsyncFileSystem):

  • platform/FileSystemType.h: Added.

(WebCore):

  • platform/blackberry/AsyncFileSystemBlackBerry.cpp:

(WebCore::AsyncFileSystem::isValidType):
(WebCore::AsyncFileSystem::create):
(WebCore::AsyncFileSystem::openFileSystem):
(WebCore::AsyncFileSystem::crackFileSystemURL):
(WebCore::AsyncFileSystemBlackBerry::AsyncFileSystemBlackBerry):

  • platform/blackberry/AsyncFileSystemBlackBerry.h:

(AsyncFileSystemBlackBerry):

  • platform/gtk/AsyncFileSystemGtk.cpp:

(WebCore::AsyncFileSystem::isValidType):
(WebCore::AsyncFileSystem::create):
(WebCore::AsyncFileSystem::openFileSystem):
(WebCore::AsyncFileSystem::crackFileSystemURL):
(WebCore::AsyncFileSystemGtk::AsyncFileSystemGtk):

  • platform/gtk/AsyncFileSystemGtk.h:

(AsyncFileSystemGtk):

Source/WebKit/chromium:

  • src/AssertMatchingEnums.cpp:
  • src/AsyncFileSystemChromium.cpp:

(WebCore::AsyncFileSystem::crackFileSystemURL):
(WebCore::AsyncFileSystem::isValidType):
(WebCore::AsyncFileSystemChromium::AsyncFileSystemChromium):
(WebCore::AsyncFileSystemChromium::createIsolatedFileSystem):
(WebCore::AsyncFileSystemChromium::toURL):

  • src/AsyncFileSystemChromium.h:

(WebCore::AsyncFileSystemChromium::create):
(AsyncFileSystemChromium):

  • src/LocalFileSystemChromium.cpp:

(WebCore::openFileSystemHelper):
(WebCore::LocalFileSystem::readFileSystem):
(WebCore::LocalFileSystem::requestFileSystem):

  • src/WebFileSystemCallbacksImpl.cpp:

(WebKit::WebFileSystemCallbacksImpl::WebFileSystemCallbacksImpl):

  • src/WebFileSystemCallbacksImpl.h:

(WebFileSystemCallbacksImpl):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::createFileSystem):
(WebKit::WebFrameImpl::createFileEntry):

  • src/WorkerAsyncFileSystemChromium.cpp:

(WebCore::WorkerAsyncFileSystemChromium::WorkerAsyncFileSystemChromium):

  • src/WorkerAsyncFileSystemChromium.h:

(WebCore::WorkerAsyncFileSystemChromium::create):
(WorkerAsyncFileSystemChromium):

05/06/12:

23:52 Changeset [116279] by hayato@chromium.org
  • 2 edits in trunk/Tools

[prepare-ChangeLog] Excludes a reference file used by reftests from test files.
https://bugs.webkit.org/show_bug.cgi?id=74268

Reviewed by Ryosuke Niwa.

  • Scripts/prepare-ChangeLog:

(generateFileList):

23:45 Changeset [116278] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] New test introduced in r116255 is failing
https://bugs.webkit.org/show_bug.cgi?id=85777

Unreviewed gardening.

  • platform/qt/Skipped: Skip the failing test
23:36 WebKitGTK/WebKit2Roadmap edited by carlosgc@webkit.org
Update target version after 1.9.2 (diff)
23:05 Changeset [116277] by morrita@google.com
  • 48 edits
    2 moves in trunk

https://bugs.webkit.org/show_bug.cgi?id=85265
[Shadow DOM] ShadowTree needs a better name

Reviewed by Dimitri Glazkov.

.:

  • Source/autotools/symbols.filter: Updated exported symbol names according to the rename.

Source/WebCore:

Renamed ShadowTree to ElementShadow, The ElementShadow class is
going to be a facade of Shadow related APIs.

Following renames follow:

  • Element::shadowTree() to Element::shadow()
  • ShadowRoot::tree() to ShadowRoot::owner()
  • ShadowTree::recalcShadowTreeStyle() to ElementShadow::recalcStyle()

No new tests. Just renames.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ComposedShadowTreeWalker.cpp:

(WebCore::shadowFor):
(WebCore::shadowOfParent):
(WebCore::ComposedShadowTreeWalker::traverseChild):
(WebCore::ComposedShadowTreeWalker::traverseSiblingOrBackToInsertionPoint):
(WebCore::ComposedShadowTreeWalker::traverseParent):

  • dom/ContainerNodeAlgorithms.cpp:

(WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoDocument):
(WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoTree):
(WebCore::ChildNodeRemovalNotifier::notifyDescendantRemovedFromDocument):
(WebCore::ChildNodeRemovalNotifier::notifyDescendantRemovedFromTree):

  • dom/DOMAllInOne.cpp:
  • dom/Document.cpp:

(WebCore::Document::buildAccessKeyMap):

  • dom/Element.cpp:

(WebCore::Element::~Element):
(WebCore::Element::willRemove):
(WebCore::Element::attach):
(WebCore::Element::detach):
(WebCore::Element::recalcStyle):
(WebCore::Element::hasShadowRoot):
(WebCore::Element::shadow):
(WebCore::Element::ensureShadow):
(WebCore::Element::ensureShadowRoot):
(WebCore::Element::childrenChanged):

  • dom/Element.h:

(WebCore):
(Element):

  • dom/ElementRareData.h:

(ElementRareData):
(WebCore::ElementRareData::~ElementRareData):

  • dom/ElementShadow.cpp: Renamed from Source/WebCore/dom/ShadowTree.cpp.

(WebCore):
(WebCore::ElementShadow::ElementShadow):
(WebCore::ElementShadow::~ElementShadow):
(WebCore::validateShadowRoot):
(WebCore::ElementShadow::addShadowRoot):
(WebCore::ElementShadow::removeAllShadowRoots):
(WebCore::ElementShadow::willRemove):
(WebCore::ElementShadow::setParentTreeScope):
(WebCore::ElementShadow::attach):
(WebCore::ElementShadow::attachHost):
(WebCore::ElementShadow::detach):
(WebCore::ElementShadow::detachHost):
(WebCore::ElementShadow::insertionPointFor):
(WebCore::ElementShadow::selectionFor):
(WebCore::ElementShadow::reattach):
(WebCore::ElementShadow::childNeedsStyleRecalc):
(WebCore::ElementShadow::needsStyleRecalc):
(WebCore::ElementShadow::recalcStyle):
(WebCore::ElementShadow::needsReattachHostChildrenAndShadow):
(WebCore::ElementShadow::hostChildrenChanged):
(WebCore::ElementShadow::setNeedsReattachHostChildrenAndShadow):
(WebCore::ElementShadow::reattachHostChildrenAndShadow):

  • dom/ElementShadow.h: Renamed from Source/WebCore/dom/ShadowTree.h.

(WebCore):
(ElementShadow):
(WebCore::ElementShadow::hasShadowRoot):
(WebCore::ElementShadow::youngestShadowRoot):
(WebCore::ElementShadow::oldestShadowRoot):
(WebCore::ElementShadow::selector):
(WebCore::ElementShadow::clearNeedsReattachHostChildrenAndShadow):
(WebCore::ElementShadow::host):
(ShadowRootVector):
(WebCore::ShadowRootVector::ShadowRootVector):

  • dom/Node.cpp:

(WebCore::oldestShadowRootFor):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::NodeRenderingContext::hostChildrenChanged):

  • dom/NodeRenderingContext.h:

(WebCore):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::create):
(WebCore::ShadowRoot::owner):

  • dom/ShadowRoot.h:

(WebCore):
(ShadowRoot):

  • dom/TreeScopeAdopter.cpp:

(WebCore::shadowFor):
(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveTreeToNewDocument):
(WebCore::TreeScopeAdopter::moveShadowToNewDocument):

  • dom/TreeScopeAdopter.h:

(TreeScopeAdopter):

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::createShadowSubtree):
(WebCore::ColorInputType::shadowColorSwatch):

  • html/FileInputType.cpp:

(WebCore::FileInputType::createShadowSubtree):
(WebCore::FileInputType::multipleAttributeChanged):

  • html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::findMainSummary):

  • html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::shadowSelect):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaControls):
(WebCore::HTMLMediaElement::hasMediaControls):

  • html/HTMLSummaryElement.cpp:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::innerTextElement):
(WebCore::HTMLTextAreaElement::updatePlaceholderText):

  • html/InputType.cpp:

(WebCore::InputType::destroyShadowSubtree):

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::handleMouseDownEvent):
(WebCore::RangeInputType::createShadowSubtree):

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::createShadowSubtree):
(WebCore::TextFieldInputType::updatePlaceholderText):

  • html/ValidationMessage.cpp:

(WebCore::ValidationMessage::deleteBubbleTree):

  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::parseAttribute):

  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::attach):
(WebCore::InsertionPoint::detach):
(WebCore::InsertionPoint::distributeHostChildren):
(WebCore::InsertionPoint::clearDistribution):

  • html/shadow/InsertionPoint.h:
  • html/shadow/SliderThumbElement.cpp:

(WebCore::sliderThumbElementOf):
(WebCore::RenderSliderContainer::layout):
(WebCore::trackLimiterElementOf):

  • html/shadow/TextFieldDecorationElement.cpp:

(WebCore::getDecorationRootAndDecoratedRoot):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::unbind):
(WebCore::InspectorDOMAgent::buildObjectForNode):

  • page/FocusController.cpp:

(WebCore::FocusScope::focusScopeOf):
(WebCore::FocusScope::focusScopeOwnedByShadowHost):

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::uploadButton):

  • svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::updateReferencedText):
(WebCore::SVGTRefElement::detachTarget):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::clearResourceReferences):
(WebCore::SVGUseElement::buildShadowAndInstanceTree):
(WebCore::SVGUseElement::buildShadowTree):

  • testing/Internals.cpp:

(WebCore::Internals::ensureShadowRoot):
(WebCore::Internals::youngestShadowRoot):
(WebCore::Internals::oldestShadowRoot):
(WebCore::Internals::removeShadowRoot):

Source/WebKit2:

  • win/WebKit2.def: Updated exported symbol names according to the rename.
  • win/WebKit2CFLite.def: Updated exported symbol names according to the rename.
23:02 Changeset [116276] by caseq@chromium.org
  • 27 edits
    6 deletes in trunk

Unreviewed, rolling out r116235.
http://trac.webkit.org/changeset/116235
https://bugs.webkit.org/show_bug.cgi?id=85773

broke a lot of tests on all chromium debug bots (Requested by
caseq_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-06

Source/WebCore:

  • bindings/objc/DOMCSS.mm:
  • css/CSSFontFaceRule.cpp:
  • css/CSSFontFaceRule.h:

(CSSFontFaceRule):

  • css/CSSImportRule.cpp:
  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::insertRule):
(WebCore::CSSMediaRule::deleteRule):

  • css/CSSMediaRule.h:

(CSSMediaRule):

  • css/CSSPageRule.cpp:

(WebCore::CSSPageRule::setSelectorText):

  • css/CSSPageRule.h:

(CSSPageRule):

  • css/CSSRule.cpp:
  • css/CSSRule.h:

(CSSRule):
(WebCore::CSSRule::parserContext):

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::setSelectorText):

  • css/CSSStyleRule.h:
  • css/CSSStyleSheet.cpp:

(WebCore::StyleSheetInternal::StyleSheetInternal):
(WebCore::StyleSheetInternal::isCacheable):
(WebCore::StyleSheetInternal::createChildRuleCSSOMWrapper):
(WebCore::StyleSheetInternal::wrapperInsertRule):
(WebCore::StyleSheetInternal::wrapperDeleteRule):
(WebCore::StyleSheetInternal::styleSheetChanged):
(WebCore):
(WebCore::CSSStyleSheet::setDisabled):
(WebCore::CSSStyleSheet::item):
(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::deleteRule):

  • css/CSSStyleSheet.h:

(StyleSheetInternal):
(WebCore::StyleSheetInternal::hasCharsetRule):
(WebCore::CSSStyleSheet::styleSheetChanged):
(CSSStyleSheet):

  • css/MediaList.cpp:

(WebCore::MediaList::setMediaText):
(WebCore::MediaList::deleteMedium):
(WebCore::MediaList::appendMedium):
(WebCore::MediaList::notifyChanged):

  • css/MediaList.h:

(MediaList):

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
(WebCore::PropertySetCSSStyleDeclaration::didMutate):
(WebCore):
(WebCore::StyleRuleCSSStyleDeclaration::setNeedsStyleRecalc):
(WebCore::InlineCSSStyleDeclaration::setNeedsStyleRecalc):

  • css/PropertySetCSSStyleDeclaration.h:

(WebCore::PropertySetCSSStyleDeclaration::setNeedsStyleRecalc):
(PropertySetCSSStyleDeclaration):
(StyleRuleCSSStyleDeclaration):

  • css/StylePropertySet.cpp:
  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::setName):
(WebCore::WebKitCSSKeyframesRule::insertRule):
(WebCore::WebKitCSSKeyframesRule::deleteRule):

  • css/WebKitCSSKeyframesRule.h:

(WebKitCSSKeyframesRule):

  • css/WebKitCSSRegionRule.cpp:
  • css/WebKitCSSRegionRule.h:

(WebKitCSSRegionRule):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::reparseStyleSheet):

  • loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::~CachedCSSStyleSheet):
(WebCore::CachedCSSStyleSheet::destroyDecodedData):
(WebCore::CachedCSSStyleSheet::restoreParsedStyleSheet):
(WebCore::CachedCSSStyleSheet::saveParsedStyleSheet):

LayoutTests:

  • http/tests/css/resources/shared-stylesheet-mutation.js: Removed.
  • http/tests/css/resources/shared.css: Removed.
  • http/tests/css/shared-stylesheet-mutation-expected.txt: Removed.
  • http/tests/css/shared-stylesheet-mutation-preconstruct-expected.txt: Removed.
  • http/tests/css/shared-stylesheet-mutation-preconstruct.html: Removed.
  • http/tests/css/shared-stylesheet-mutation.html: Removed.
22:54 Changeset [116275] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

Attempt to fix the !ENABLE(INSPECTOR) build by making InspectorValues
available unconditionally. We should probably rename these classes to
JSONValues and move them into WebCore/platform.

  • inspector/InspectorValues.cpp:
  • inspector/InspectorValues.h:
22:38 Changeset [116274] by abarth@webkit.org
  • 8 edits
    4 adds in trunk

CSP violation reports should have all the fields required by the spec
https://bugs.webkit.org/show_bug.cgi?id=85682

Reviewed by Darin Adler.

Source/WebCore:

This patch updates our CSP violation reports to include all the fields
in the spec. We've discussed all these fields in the working group,
and we have fairly high confidence that these are safe to expose.

Tests: http/tests/security/contentSecurityPolicy/report-and-enforce.html

http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin.html
http/tests/security/contentSecurityPolicy/report-blocked-uri.html
http/tests/security/contentSecurityPolicy/report-only-from-header.html
http/tests/security/contentSecurityPolicy/report-only.html
http/tests/security/contentSecurityPolicy/report-uri-from-child-frame.html
http/tests/security/contentSecurityPolicy/report-uri.html

  • page/ContentSecurityPolicy.cpp:

(CSPDirectiveList):
(WebCore::CSPDirectiveList::reportViolation):
(WebCore::CSPDirectiveList::checkSourceAndReportViolation):

LayoutTests:

Update test results to show the new fields in the violation reports.
This patch also adds tests that exercise both the same-origin and the
cross-origin case for blocked-uri.

  • http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt:
  • http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin.html: Added.
  • http/tests/security/contentSecurityPolicy/report-blocked-uri-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/report-blocked-uri.html: Added.
  • http/tests/security/contentSecurityPolicy/report-only-expected.txt:
  • http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt:
  • http/tests/security/contentSecurityPolicy/report-uri-expected.txt:
  • http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt:
22:33 Changeset [116273] by kinuko@chromium.org
  • 11 edits in trunk/Source

Cleanup: FileSystem API's Entry.toURL() impl should return KURL instead of String
https://bugs.webkit.org/show_bug.cgi?id=85736

Change the return type of Entry::toURL() from String to KURL.

Reviewed by David Levin.

No new tests as this change should not have any visible impact in the javascript layer.

Source/WebCore:

  • Modules/filesystem/EntryBase.cpp:

(WebCore::EntryBase::toURL):

  • Modules/filesystem/EntryBase.h:
  • platform/AsyncFileSystem.h:
  • platform/blackberry/AsyncFileSystemBlackberry.cpp:

(AsyncFileSystemBlackberry::toURL):

  • platform/blackberry/AsyncFileSystemBlackberry.h:
  • platform/gtk/AsyncFileSystemGtk.cpp:

(AsyncFileSystemGtk::toURL):

  • platform/gtk/AsyncFileSystemGtk.h:

Souce/We/chromium:

  • src/AsyncFileSystemChromium.cpp:

(WebCore::AsyncFileSystemChromium::toURL):
String to KURL.

  • src/AsyncFileSystemChromium.h:

(AsyncFileSystemChromium):

22:24 Changeset [116272] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed expectations update for overflow-positioning.html.

  • platform/chromium/test_expectations.txt:
22:05 Changeset [116271] by hbono@chromium.org
  • 3 edits
    4 copies in branches/chromium/1084

Merge 114095 - Background width (or height) is wrong if width (or height) * zoom < 1.
https://bugs.webkit.org/show_bug.cgi?id=83350

Reviewed by Nikolas Zimmermann.

Source/WebCore:

calculateImageIntrinsicDimension will return wrong size if the calculated size is 0.
0 is used for expressing unspecfied, so the method returns the box width(height) instead.

Since CachedImage has already similar code, we moved it to IntSize and shared it.

Tests: fast/css/zoom-background-repeat-x-expected.html

fast/css/zoom-background-repeat-x.html
fast/css/zoom-background-repeat-y-expected.html
fast/css/zoom-background-repeat-y.html

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::imageSizeForRenderer):

  • platform/graphics/IntSize.h:

(IntSize):
(WebCore::IntSize::scale):
(WebCore::IntSize::clampToMinimumSize):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions):

LayoutTests:

  • fast/css/zoom-background-repeat-x-expected.html: Added.
  • fast/css/zoom-background-repeat-x.html: Added.
  • fast/css/zoom-background-repeat-y-expected.html: Added.
  • fast/css/zoom-background-repeat-y.html: Added.

TBR=shinyak@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10379031

21:41 Changeset [116270] by pilgrim@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Call currentThread through Platform.h directly
https://bugs.webkit.org/show_bug.cgi?id=85769

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::onEndTest):
(WTF::CCLayerTreeHostTest::runTest):

21:39 Changeset [116269] by haraken@chromium.org
  • 16 edits in trunk/Source/WebCore

[V8][Performance] Remove Isolate lookup from the call path
to get a cached JS wrapper object by getDOMXXXXMap().
https://bugs.webkit.org/show_bug.cgi?id=85205

Reviewed by Adam Barth.

The patch improves the performance of getting a cached JS wrapper
by getDOMXXXXMap(). For example, it improves the performance
of toV8(NodeList*) in getElementsByTagName(), getElementsByName(),
getElementsByClassName() by 7 ~ 9%.

Performance tests: https://bugs.webkit.org/attachment.cgi?id=139468

The performance test results in my Linux desktop:

getElementsByTagName : 40.76 ms => 37.52ms (+8.6%)
getElementsByName : 41.02 ms => 37.42ms (+9.6%)
getElementsByClassName : 40.32 ms => 37.68ms (+7.0%)

Unfortunately we cannot observe performance improvement in
Dromaeo/dom-query.html, which are testing getElementsByTagName(),
getElementsByName(), getElementsByClassName(). This is because
the bottleneck of these Dromaeo tests is not toV8(NodeList*) but
.length and .nodeType accesses. The patch for optimizing them
will be coming soon.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm: Modified as described above.

(GenerateHeader):
(GenerateNormalAttrGetter):
(GetDomMapFunction):
(NativeToJSValue):

  • bindings/v8/DOMData.cpp:

(WebCore::DOMData::getCurrentStore):

  • bindings/scripts/test/V8/V8Float64Array.h: Updated run-bindings-tests results.

(WebCore::V8Float64Array::wrap):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(WebCore::V8TestActiveDOMObject::wrap):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(WebCore::V8TestCustomNamedGetter::wrap):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(WebCore::V8TestEventConstructor::wrap):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::itemCallback):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(WebCore::V8TestEventTarget::wrap):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalNodeAttrGetter):

  • bindings/scripts/test/V8/V8TestInterface.h:

(WebCore::V8TestInterface::wrap):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(WebCore::V8TestMediaQueryListListener::wrap):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(WebCore::V8TestNamedConstructor::wrap):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::readOnlyTestObjAttrAttrGetter):
(WebCore::TestObjV8Internal::cachedAttribute1AttrGetter):
(WebCore::TestObjV8Internal::cachedAttribute2AttrGetter):
(WebCore::TestObjV8Internal::contentDocumentAttrGetter):
(WebCore::TestObjV8Internal::getSVGDocumentCallback):

  • bindings/scripts/test/V8/V8TestObj.h:

(WebCore::V8TestObj::wrap):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(WebCore::V8TestSerializedScriptValueInterface::wrap):

21:34 Changeset [116268] by abarth@webkit.org
  • 10 edits in trunk

Content Security Policy reports should be reported with content-type application/json, should contain all required fields
https://bugs.webkit.org/show_bug.cgi?id=61360

Reviewed by Eric Seidel.

Source/WebCore:

This patch changes ContentSecurityPolicy to use JSON format for sending
violation reports rather than wwwform-encoding. This patch aligns our
behavior with the specification and with Mozilla. A follow up patch
will update the list of fields in the report to match the spec.

  • loader/PingLoader.cpp:

(WebCore::PingLoader::reportContentSecurityPolicyViolation):

  • page/ContentSecurityPolicy.cpp:

(WebCore::CSPDirectiveList::reportViolation):

LayoutTests:

Update results to show JSON format.

  • http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt:
  • http/tests/security/contentSecurityPolicy/report-only-expected.txt:
  • http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt:
  • http/tests/security/contentSecurityPolicy/report-uri-expected.txt:
  • http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt:
  • http/tests/security/contentSecurityPolicy/resources/save-report.php:
21:15 Changeset [116267] by pilgrim@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Call cryptographicallyRandomValues through Platform.h
https://bugs.webkit.org/show_bug.cgi?id=85763

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

  • src/ChromiumOSRandomSource.cpp:

(WTF::cryptographicallyRandomValuesFromOS):

21:11 Changeset [116266] by mary.wu@torchmobile.com.cn
  • 2 edits in trunk/Tools

Add a contributor to committers.py
https://bugs.webkit.org/show_bug.cgi?id=85761

Reviewed by Unreviewed.

Add myself to committers.py contributor.

  • Scripts/webkitpy/common/config/committers.py:
21:09 Changeset [116265] by mary.wu@torchmobile.com.cn
  • 8 edits in trunk/Source

[BlackBerry] Support html5 download attribute.
https://bugs.webkit.org/show_bug.cgi?id=85044

Reviewed by Antonio Gomes.

Source/WebCore:

Pass download attribute filename to networkJob and it could be
overridden by the Content-Disposition HTTP header's filename parameter.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::initialize):

  • platform/network/blackberry/ResourceRequest.h:

(WebCore::ResourceRequest::setSuggestSaveName):
(WebCore::ResourceRequest::suggestSaveName):
(ResourceRequest):

  • platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::ResourceRequest::initializePlatformRequest):

Source/WebKit/blackberry:

If a link has download attribute, we should pass that value and be able to
save file with the name according to HTML5:
http://updates.html5rocks.com/2011/08/Downloading-resources-in-HTML5-a-download

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::load):
(BlackBerry::WebKit::WebPage::download):

  • Api/WebPage_p.h:

(WebPagePrivate):

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::startDownload):

20:43 Changeset [116264] by fpizlo@apple.com
  • 6 edits in branches/dfgopt/Source/JavaScriptCore

Truncating multiplication on integers should not OSR exit every time
https://bugs.webkit.org/show_bug.cgi?id=85752

Reviewed by Gavin Barraclough.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::mulShouldSpeculateInteger):
(Graph):
(JSC::DFG::Graph::mulImmediateShouldSpeculateInteger):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileArithMul):

20:13 Changeset [116263] by bashi@chromium.org
  • 5 edits in trunk

Disallow unquoted -webkit-font-feature-settings tags
https://bugs.webkit.org/show_bug.cgi?id=85362

Reviewed by Kent Tamura.

Source/WebCore:

Disallow unquoted tags to follow the current draft.
http://dev.w3.org/csswg/css3-fonts/#font-feature-settings-prop

No new tests. css3/font-feature-settings-parsing.html was updated.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFontFeatureTag): Accepts only 4-characters string.

LayoutTests:

  • css3/font-feature-settings-parsing-expected.txt: Updated to follow the current draft specification.
  • css3/font-feature-settings-parsing.html: Ditto.
19:53 Changeset [116262] by rakuco@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for r116260.

COMPILE_ASSERT() does not expect a string in its second parameter.

  • platform/graphics/TextRun.cpp:

(WebCore):

19:24 Changeset [116261] by rakuco@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Gardening. Skip more failing tests.

  • platform/efl/Skipped:
  • platform/efl/test_expectations.txt:
19:19 Changeset [116260] by rwlbuis@webkit.org
  • 3 edits in trunk/Source/WebCore

Shrink TextRun object size
https://bugs.webkit.org/show_bug.cgi?id=85751

Reviewed by Darin Adler.

Reorder the member variables in TextRun so it shrinks from 56 to 40 bytes on my 64-bit build. This is important
for SVG, since RenderSVGText shrinks because of this.

Also add a compile assert for the expected object size.

  • platform/graphics/TextRun.cpp:

(ExpectedTextRunSize):
(WebCore):

  • platform/graphics/TextRun.h:

(WebCore::TextRun::TextRun):
(WebCore::TextRun::direction):
(TextRun):

19:10 Changeset [116259] by keishi@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Add WebKit API to access multiple attribute of input element
https://bugs.webkit.org/show_bug.cgi?id=85355

Reviewed by Kent Tamura.

We need this to implement the datalist UI for <input type=email multiple>.

  • public/WebInputElement.h:

(WebInputElement):

  • src/WebInputElement.cpp:

(WebKit::WebInputElement::isMultiple):
(WebKit):

18:50 Changeset [116258] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk/Source

[BlackBerry] Autofill backing store implementation upstream
https://bugs.webkit.org/show_bug.cgi?id=85575

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-05-06
Reviewed by Rob Buis.

Source/WebCore:

Implemented class AutofillBackingStore which is responsible
for handling interaction with autofill database.

Replaced static function
CredentialBackingStore* CredentialBackingStore::instance()
with a helper function
CredentialBackingStore& credentialBackingStore(),
and used DEFINE_STATIC_LOCAL to construct the singleton
object.
Also removed unnecessary function close() and combined with
the destructor of class CredentialBackingStore.

Initial upstream, No new tests.

  • PlatformBlackBerry.cmake:
  • platform/network/blackberry/AutofillBackingStore.cpp: Added.

(WebCore):
(WebCore::autofillBackingStore):
(WebCore::AutofillBackingStore::AutofillBackingStore):
(WebCore::AutofillBackingStore::~AutofillBackingStore):
(WebCore::AutofillBackingStore::open):
(WebCore::AutofillBackingStore::add):
(WebCore::AutofillBackingStore::update):
(WebCore::AutofillBackingStore::contains):
(WebCore::AutofillBackingStore::get):
(WebCore::AutofillBackingStore::clear):

  • platform/network/blackberry/AutofillBackingStore.h: Added.

(WebCore):
(AutofillBackingStore):

  • platform/network/blackberry/CredentialBackingStore.cpp:

(WebCore::credentialBackingStore):
(WebCore::CredentialBackingStore::~CredentialBackingStore):

  • platform/network/blackberry/CredentialBackingStore.h:

(CredentialBackingStore):
(WebCore):

  • platform/network/blackberry/CredentialStorageBlackBerry.cpp:

(WebCore::CredentialStorage::getFromPersistentStorage):

Source/WebKit/blackberry:

Replaced calling static function CredentialBackingStore::instance()
with calling the helper function credentialBackingStore().

  • WebCoreSupport/CredentialManager.cpp:

(WebCore::CredentialManager::autofillAuthenticationChallenge):
(WebCore::CredentialManager::autofillPasswordForms):
(WebCore::CredentialManager::saveCredentialIfConfirmed):
(WebCore::CredentialManager::clearCredentials):
(WebCore::CredentialManager::clearNeverRememberSites):

18:41 Changeset [116257] by mitz@apple.com
  • 3 edits
    9 adds in trunk

.: Part of: Building and debugging WebKit in the Xcode IDE requires a lot of setup
https://bugs.webkit.org/show_bug.cgi?id=85739

Reviewed by Daniel Bates.

  • WebKit.xcworkspace: Added.
  • WebKit.xcworkspace/contents.xcworkspacedata: Added.
  • WebKit.xcworkspace/xcshareddata: Added.
  • WebKit.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings: Added.
  • WebKit.xcworkspace/xcshareddata/xcschemes: Added.
  • WebKit.xcworkspace/xcshareddata/xcschemes/All Source (target WebProcess).xcscheme: Added

this scheme, which builds all source projects and runs WebProcess with
Safari as the client executable.

  • WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme: Added

this scheme, which builds all source projects and runs Safari.

  • WebKit.xcworkspace/xcshareddata/xcschemes/All Tools.xcscheme: Added

this scheme, which builds all tools projects and runs DumpRenderTree.

Tools: Tools part of: Building and debugging WebKit in the Xcode IDE requires a lot of setup
https://bugs.webkit.org/show_bug.cgi?id=85739

Reviewed by Daniel Bates.

  • Scripts/build-webkit: Moved code that copies from WebKitLibraries to the product directory

from here...

  • Scripts/copy-webkitlibraries-to-product-directory: ...to this new script.
18:31 Changeset [116256] by kov@webkit.org
  • 2 edits in trunk

[GTK] Enable WebKit2 build by default (again)
https://bugs.webkit.org/show_bug.cgi?id=85750

  • configure.ac: enable wk2 build by default.
18:11 Changeset [116255] by morrita@google.com
  • 3 edits
    2 adds in trunk

[Shadow DOM] Node distribution should be refreshed before style recalc.
https://bugs.webkit.org/show_bug.cgi?id=85259

Reviewed by Dimitri Glazkov.

Source/WebCore:

Element::recalcStyle() calls child element's recalcStyle()
recursively, following ShadowTree::recalcShadowTreeStyle(). But
recalcShadowTreeStyle() should be called before such recursion if
necessary.

This is because style calculation and following renderer attachment
of each child element depends on up-to-date node distribution result
which is computed during the recalcShadowTreeStyle().

Test: fast/dom/shadow/shadow-dynamic-style-change-via-mutation-and-selector.html

  • dom/Element.cpp: Moved recalcShadowTreeStyle() before child traversals.

(WebCore::Element::recalcStyle):

LayoutTests:

  • fast/dom/shadow/shadow-dynamic-style-change-via-mutation-and-selector-expected.txt: Added.
  • fast/dom/shadow/shadow-dynamic-style-change-via-mutation-and-selector.html: Added.
17:53 Changeset [116254] by abarth@webkit.org
  • 9 edits
    4 adds in trunk

CSP should let sites both enforce one policy and monitor another
https://bugs.webkit.org/show_bug.cgi?id=85561

Reviewed by Eric Seidel.

Source/WebCore:

This patch lets us enforce and/or monitor multiple CSP policies.
Rather than having a single directive list, we now have a vector of
directive lists.

Tests: http/tests/security/contentSecurityPolicy/combine-multiple-policies.html

http/tests/security/contentSecurityPolicy/report-and-enforce.html

  • page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::copyStateFrom):
(WebCore::ContentSecurityPolicy::didReceiveHeader):
(WebCore::ContentSecurityPolicy::deprecatedHeader):
(WebCore::ContentSecurityPolicy::deprecatedHeaderType):

  • Even after this patch, workers aren't smart enough to enforce multiple policies. They just use the first header, like they did before. We'll need to teach workers how to enforce multiple policies in a future patch.

(WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
(WebCore::ContentSecurityPolicy::allowInlineEventHandlers):
(WebCore::ContentSecurityPolicy::allowInlineScript):
(WebCore::ContentSecurityPolicy::allowInlineStyle):
(WebCore::ContentSecurityPolicy::allowEval):
(WebCore::ContentSecurityPolicy::allowScriptFromSource):
(WebCore::ContentSecurityPolicy::allowObjectFromSource):
(WebCore::ContentSecurityPolicy::allowChildFrameFromSource):
(WebCore::ContentSecurityPolicy::allowImageFromSource):
(WebCore::ContentSecurityPolicy::allowStyleFromSource):
(WebCore::ContentSecurityPolicy::allowFontFromSource):
(WebCore::ContentSecurityPolicy::allowMediaFromSource):
(WebCore::ContentSecurityPolicy::allowConnectFromSource):

  • page/ContentSecurityPolicy.h:
  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerScriptLoader::notifyFinished):

  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::startWorkerContext):

Source/WebKit/chromium:

  • src/SharedWorkerRepository.cpp:

(WebCore::SharedWorkerScriptLoader::notifyFinished):

  • src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::startWorkerContext):

LayoutTests:

Test that we can enforce multiple policies and that we can enforce one
policy while monitoring another.

  • http/tests/security/contentSecurityPolicy/combine-multiple-policies-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/combine-multiple-policies.html: Added.
  • http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/report-and-enforce.html: Added.
17:45 Changeset [116253] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

InlineBox::setHasBadParent should be debug only
https://bugs.webkit.org/show_bug.cgi?id=85748

Patch by Rob Buis <rbuis@rim.com> on 2012-05-06
Reviewed by Eric Seidel.

Do not provide InlineBox::setHasBadParent in release builds.

  • rendering/InlineBox.h:

(InlineBox):
(WebCore):
(WebCore::InlineBox::setHasBadParent):

17:26 Changeset [116252] by aestes@apple.com
  • 2 edits in trunk/Tools

Fix the build after r116246.

  • DumpRenderTree/LayoutTestController.cpp: Remove an unused function.
17:14 Changeset [116251] by eric@webkit.org
  • 2 edits in trunk/Tools

Update several build-webkit options to match the #defines they toggle
https://bugs.webkit.org/show_bug.cgi?id=85744

Reviewed by Adam Barth.

Most notable here is fixing --3d-canvas to be --webgl these days --
the define was renamed 15 months ago!

  • Scripts/webkitperl/FeatureList.pm:
16:28 Changeset [116250] by commit-queue@webkit.org
  • 7 edits in trunk

[EFL] EFL's LayoutTestController setJavaScriptCanAccessClipboard implementation
https://bugs.webkit.org/show_bug.cgi?id=83687

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-06
Reviewed by Antonio Gomes.

Source/WebKit/efl:

  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(ewk_view_setting_scripts_can_access_clipboard_get):
(ewk_view_setting_scripts_can_access_clipboard_set):

  • ewk/ewk_view.h:

Tools:

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setJavaScriptCanAccessClipboard):

LayoutTests:

  • platform/efl/Skipped:
16:26 Changeset [116249] by eric@webkit.org
  • 3 edits in trunk/WebKitLibraries

Remove 3D_CANVAS define from vsprops files (it was renamed WEBGL many months ago)
https://bugs.webkit.org/show_bug.cgi?id=85743

Reviewed by Adam Barth.

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
15:57 Changeset [116248] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

KURL::isBlankURL would be a nicer idiom than KURL::protocolIs("about")
https://bugs.webkit.org/show_bug.cgi?id=85641

Patch by Mike West <mkwst@chromium.org> on 2012-05-06
Reviewed by Adam Barth.

  • dom/Document.cpp:

(WebCore::shouldInheritSecurityOriginFromOwner):

  • page/ContentSecurityPolicy.cpp:

(WebCore::CSPDirectiveList::allowObjectFromSource):
(WebCore::CSPDirectiveList::allowChildFrameFromSource):

  • page/PageSerializer.cpp:

(WebCore::SerializerMarkupAccumulator::appendCustomAttributes):
(WebCore::PageSerializer::serializeFrame):

  • platform/KURL.cpp:

(WebCore::KURL::isBlankURL):
(WebCore):

  • platform/KURL.h:

(KURL):
(WebCore):

15:46 Changeset [116247] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[TextureMapper] Layer images is uploaded to the GPU for each sync
https://bugs.webkit.org/show_bug.cgi?id=85727

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-05-06
Reviewed by Noam Rosenthal.

No new tests. This does not change functionality,
it only improves performance.

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::updateBackingStore): Reset the needsDisplay
and needsDisplayRect variables after uploading the layer image.

15:43 Changeset [116246] by gyuyoung.kim@samsung.com
  • 33 edits in trunk

Convert isPageBoxVisible to use Internals interface.
https://bugs.webkit.org/show_bug.cgi?id=85692

Reviewed by Darin Adler.

.:

  • Source/autotools/symbols.filter: Add isPageBoxVisible symbol filter.

Source/WebCore:

Add isPageBoxVisible functions, because it is able to work in the
cross-port way through the Internals interface.

No new tests, since we are improving here the infra-structure for testing
a specific method.

  • testing/Internals.cpp:

(WebCore):
(WebCore::Internals::isPageBoxVisible):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit/efl:

Remove isPageBoxVisible functions, because it is able to work in the
cross-port way through the Internals interface.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Source/WebKit/gtk:

Remove isPageBoxVisible functions, because it is able to work in the
cross-port way through the Internals interface.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Source/WebKit/qt:

Remove isPageBoxVisible functions, because it is able to work in the
cross-port way through the Internals interface.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Source/WebKit2:

  • win/WebKit2.def: Add isPageBoxVisible symbol filter.

Tools:

Remove isPageBoxVisible functions, because it is able to work in the
cross-port way through the Internals interface.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  • DumpRenderTree/qt/LayoutTestControllerQt.h:

(LayoutTestController):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

LayoutTests:

Call isPageBoxVisible functions from internals, because it is able to work in the
cross-port way through the Internals interface.

  • printing/page-format-data-expected.txt:
  • printing/page-format-data.html:
15:33 Changeset [116245] by tomz@codeaurora.org
  • 3 edits in trunk/Tools

sheriffbot isn't reopening patches after it lands rollouts
https://bugs.webkit.org/show_bug.cgi?id=64418

Reviewed by Adam Barth.

  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/steps/createbug.py:

(CreateBug.run):

15:19 Changeset [116244] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk

Web Inspector: "Goto Function" filtering should be less restrictive.
https://bugs.webkit.org/show_bug.cgi?id=85586

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-05-06
Reviewed by Pavel Feldman.

Added tests for generated regex.

Changes:
1) Avoid asterisks in filtering queue.
2) Optimization: do not create regexp for each item.

  • inspector/front-end/FilteredItemSelectionDialog.js:

(WebInspector.FilteredItemSelectionDialog.prototype.get _itemsLoaded):
Applied new filtering workflow.
(WebInspector.FilteredItemSelectionDialog.prototype._checkItemAt):
Removed.
(WebInspector.FilteredItemSelectionDialog.prototype._createSearchRegExp):
Removed unused "suffix" logic; changed the way regexp is composed from query.
(WebInspector.FilteredItemSelectionDialog.prototype._filterItems):
Applied new filtering workflow.
(WebInspector.FilteredItemSelectionDialog.prototype._onKeyDown):
Removed unused var.

15:12 Changeset [116243] by tkent@chromium.org
  • 7 edits in trunk/Source

Rename ICULocale to LocaleICU, part 2
https://bugs.webkit.org/show_bug.cgi?id=85695

Reviewed by Kentaro Hara.

Source/WebCore:

No behavior change

  • platform/text/LocaleICU.cpp: Rename ICULocale to LocaleICU.
  • platform/text/LocaleICU.h: ditto.

Also, update obsolete comments.

  • platform/text/LocalizedDateICU.cpp: Rename ICULocale to LocaleICU.

(WebCore::parseLocalizedDate):
(WebCore::formatLocalizedDate):
(WebCore::localizedDateFormatText):
(WebCore::monthLabels):
(WebCore::weekDayShortLabels):
(WebCore::firstDayOfWeek):

  • platform/text/LocalizedNumberICU.cpp: ditto.

(WebCore::convertToLocalizedNumber):
(WebCore::convertFromLocalizedNumber):

Source/WebKit/chromium:

  • tests/LocalizedNumberICUTest.cpp:

(testNumberIsReversible): Rename ICULocale to LocaleICU.

15:06 Changeset [116242] by enne@google.com
  • 4 edits
    1 add in trunk/Source/WebKit/chromium

[chromium] Allow WebMediaPlayerClientImpl to switch clients
https://bugs.webkit.org/show_bug.cgi?id=85093

Reviewed by James Robinson.

WebVideoFrameProviderClient has a 1:1 relationship with a
WebVideoFrameProvider. The client here is CCVideoLayerImpl and the
provider is WebMediaPlayerClientImpl. If the provider gets a new
client, then the old client needs to be informed to stop using the
provider.

If this doesn't happen, then the old client will have an unsafe
pointer to the provider, will not get informed if the provider gets
deleted, and the client will crash when it dereferences the provider
pointer trying to tell the provider that its client is going away.

Test: WebMediaPlayerClientImplTest.InitialNullVideoClient

WebMediaPlayerClientImplTest.SetAndUnsetVideoClient
WebMediaPlayerClientImplTest.DestroyProvider
WebMediaPlayerClientImplTest.SetMultipleVideoClients

  • WebKit.gypi:
  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::setVideoFrameProviderClient):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

  • tests/WebMediaPlayerClientImplTest.cpp: Added.

(WebKit):
(FakeWebMediaPlayerClientImpl):
(WebKit::FakeWebMediaPlayerClientImpl::create):
(WebKit::FakeWebMediaPlayerClientImpl::FakeWebMediaPlayerClientImpl):
(FakeVideoFrameProviderClient):
(WebKit::FakeVideoFrameProviderClient::create):
(WebKit::FakeVideoFrameProviderClient::~FakeVideoFrameProviderClient):
(WebKit::FakeVideoFrameProviderClient::didReceiveFrame):
(WebKit::FakeVideoFrameProviderClient::didUpdateMatrix):
(WebKit::FakeVideoFrameProviderClient::stopUsingProvider):
(WebKit::FakeVideoFrameProviderClient::provider):
(WebKit::FakeVideoFrameProviderClient::FakeVideoFrameProviderClient):
(WebKit::TEST):

15:05 Changeset [116241] by commit-queue@webkit.org
  • 4 edits in trunk

[BlackBerry] Enable credential persistance and auto fill
https://bugs.webkit.org/show_bug.cgi?id=85572

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-05-06
Reviewed by Rob Buis.

.:

Enable credential persistance and auto fill feature by adding
ENABLE_BLACKBERRY_CREDENTIAL_PERSIST=1.

  • Source/cmake/OptionsBlackBerry.cmake:

Source/WebKit/blackberry:

Set autofilled status of credential input fields when credential
information is auto filled by CredentialManager.
By doing this the input element will get painted with yellow background
which can notify user this input field is auto filled by the browser.

No behavior changes, so no new test.

  • WebCoreSupport/CredentialTransformData.cpp:

(WebCore::CredentialTransformData::setCredential):

15:05 Changeset [116240] by kov@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.9.2

Tagging the WebKitGTK+ 1.9.2 release.

14:19 Changeset [116239] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-06

  • DEPS:
13:20 Changeset [116238] by kevino@webkit.org
  • 6 edits in trunk/Source/WebCore

[wx] Unreviewed. Build fixes for recent trunk changes.

07:54 Changeset [116237] by caseq@chromium.org
  • 13 edits in trunk/Source

Web Inspector: take timeline frame mode out of experimental
https://bugs.webkit.org/show_bug.cgi?id=85707

Reviewed by Pavel Feldman.

Source/WebCore:

  • remove "Vertical timeline overview" experiment;
  • add supportsFrameInstrumentation capability to InspectorTimelineAgent;
  • show frame mode selector conditionally on supportsFrameInstrumentation capability.
  • inspector/Inspector.json: Add Timeline.supportsFrameInstrumentation capability;
  • inspector/InspectorClient.h: Add supportsFrameInstrumentation();

(InspectorClient):
(WebCore::InspectorClient::supportsFrameInstrumentation):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::supportsFrameInstrumentation):
(WebCore):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent): Added FrameInstrumentationSupport parameter.

  • inspector/InspectorTimelineAgent.h:

(WebCore):
(WebCore::InspectorTimelineAgent::create): ditto.
(InspectorTimelineAgent):

  • inspector/WorkerInspectorController.cpp: Updated call site for InspectorTimelineAgent::create() to indicate frame instrumentation not supported.

(WebCore::WorkerInspectorController::WorkerInspectorController):

  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings): Removed "Vertical Overview" experiment.

  • inspector/front-end/TimelineOverviewPane.js: Expose frame mode conditionally on capability, not the experiment.

(WebInspector.TimelineOverviewPane):

  • inspector/front-end/inspector.js: Added initialization for Capabilities.timelineSupportsFrameInstrumentation;

(WebInspector.doLoadedDone):

Source/WebKit/chromium:

  • exposed supportFrameInstrumentation method to InspectorClient. Client must return true iff the platform will call InspectorInstrumentation::instrumentBeginFrame() upon beginning of frame rendering;
  • src/InspectorClientImpl.cpp:

(WebKit::InspectorClientImpl::supportsFrameInstrumentation):
(WebKit):

  • src/InspectorClientImpl.h:

(InspectorClientImpl):

03:51 Changeset [116236] by antti@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix.

Not reviewed.

  • css/PropertySetCSSStyleDeclaration.cpp:
03:29 Changeset [116235] by antti@apple.com
  • 27 edits
    6 adds in trunk

Share stylesheet data structures between documents
https://bugs.webkit.org/show_bug.cgi?id=85598

Source/WebCore:

Reviewed by Darin Adler.

We currently make a copy of the data structures when restoring a cached stylesheet. This patch lets us share
the data until someone uses CSSOM to modify the sheet.

The patch implements copy-on-write for the internal style sheet data structures. If any mutation CSSOM API is
invoked, we check if the stylesheet can be safely mutated (we are the only client, it is not cached). If not
then the internal structures are copied and any existing CSSOM objects are re-attached to the new tree.

Sharing can save significant amount of memory on sites with large stylesheets. For example if you have
multiple articles open on wsj.com this saves ~2.6MB per tab.

Test: http/tests/css/shared-stylesheet-mutation.html

http/tests/css/shared-stylesheet-mutation-preconstruct.html

  • css/CSSFontFaceRule.cpp:

(WebCore::CSSFontFaceRule::reattach):
(WebCore):

  • css/CSSFontFaceRule.h:

(CSSFontFaceRule):

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::insertRule):
(WebCore::CSSMediaRule::deleteRule):
(WebCore::CSSMediaRule::reattach):
(WebCore):

  • css/CSSMediaRule.h:

(CSSMediaRule):

  • css/CSSPageRule.cpp:

(WebCore::CSSPageRule::setSelectorText):
(WebCore::CSSPageRule::reattach):
(WebCore):

  • css/CSSPageRule.h:

(CSSPageRule):

  • css/CSSRule.cpp:

(WebCore::CSSRule::reattach):

After the internal stylerule tree has been copied, the existing wrappers are re-attached using recursive reattach() function.

  • css/CSSRule.h:

(WebCore):
(CSSRule):

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::setSelectorText):
(WebCore::CSSStyleRule::reattach):
(WebCore):

  • css/CSSStyleRule.h:

(CSSStyleRule):

  • css/CSSStyleSheet.cpp:

(WebCore::StyleSheetInternal::StyleSheetInternal):
(WebCore::StyleSheetInternal::isCacheable):
(WebCore::StyleSheetInternal::ruleAt):

Add ruleAt(), use it for both wrapper creation and reattaching. Remove createChildRuleCSSOMWrapper .

(WebCore):
(WebCore::StyleSheetInternal::wrapperInsertRule):
(WebCore::StyleSheetInternal::wrapperDeleteRule):

Invalidation moves to the calling wrapper.

(WebCore::StyleSheetInternal::addedToMemoryCache):
(WebCore::StyleSheetInternal::removedFromMemoryCache):
(WebCore::CSSStyleSheet::willMutateRules):

This is called whenever StyleSheetInternal is going to be mutated. It will do copy-on-write if needed.


Usually invoked by CSSStyleSheet::RuleMutation RAII type.

(WebCore::CSSStyleSheet::didMutateRules):

This is called after the mutation is complete and will trigger the style recalc in the document.

(WebCore::CSSStyleSheet::didMutate):

This is called directly after mutations that don't change StyleSheetInternal so don't require copy-on-write.

(WebCore::CSSStyleSheet::reattachChildRuleCSSOMWrappers):
(WebCore::CSSStyleSheet::setDisabled):
(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::deleteRule):

  • css/CSSStyleSheet.h:

(StyleSheetInternal):
(WebCore::StyleSheetInternal::hasOneClient):
(WebCore::StyleSheetInternal::isMutable):
(WebCore::StyleSheetInternal::setMutable):

Track mutability. Mutation is allowed only after willMutate call.

(WebCore::StyleSheetInternal::isInMemoryCache):

Track if the object is in memory cache.

(WebCore::CSSStyleSheet::clearOwnerRule):
(CSSStyleSheet):

  • css/MediaList.cpp:

(WebCore::MediaList::setMediaText):
(WebCore::MediaList::deleteMedium):
(WebCore::MediaList::appendMedium):
(WebCore::MediaList::didMutate):
(WebCore):
(WebCore::MediaList::reattach):

  • css/MediaList.h:

(MediaList):

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
(WebCore):
(WebCore::StyleRuleCSSStyleDeclaration::willMutate):
(WebCore::StyleRuleCSSStyleDeclaration::didMutate):
(WebCore::StyleRuleCSSStyleDeclaration::reattach):
(WebCore::InlineCSSStyleDeclaration::didMutate):

  • css/PropertySetCSSStyleDeclaration.h:

(WebCore::PropertySetCSSStyleDeclaration::willMutate):
(WebCore::PropertySetCSSStyleDeclaration::didMutate):
(StyleRuleCSSStyleDeclaration):

  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::setName):
(WebCore::WebKitCSSKeyframesRule::insertRule):
(WebCore::WebKitCSSKeyframesRule::deleteRule):
(WebCore::WebKitCSSKeyframesRule::reattach):
(WebCore):

  • css/WebKitCSSKeyframesRule.h:

(WebKitCSSKeyframesRule):

  • css/WebKitCSSRegionRule.cpp:

(WebCore::WebKitCSSRegionRule::reattach):

  • css/WebKitCSSRegionRule.h:

(WebKitCSSRegionRule):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::reparseStyleSheet):

  • loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::~CachedCSSStyleSheet):
(WebCore::CachedCSSStyleSheet::destroyDecodedData):
(WebCore::CachedCSSStyleSheet::restoreParsedStyleSheet):

Don't copy when restoring. It is no longer necessary.
Set the cache bit on the stylesheet.

(WebCore::CachedCSSStyleSheet::saveParsedStyleSheet):

LayoutTests:

Reviewed by Darin Adler.

Test that mutations of a shared stylesheet work as expected.

This is an http test due to cross-document security restrictions with file urls
(they can be overriden in DRT but I'd like this to work in browser too).

  • http/tests/css/resources/shared.css: Added.
  • http/tests/css/resources/shared-stylesheet-mutation.js: Added.
  • http/tests/css/shared-stylesheet-mutation-expected.txt: Added.
  • http/tests/css/shared-stylesheet-mutation-preconstruct-expected.txt: Added.
  • http/tests/css/shared-stylesheet-mutation-preconstruct.html: Added.
  • http/tests/css/shared-stylesheet-mutation.html: Added.
00:17 Changeset [116234] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

Fix the GTK+ TextureMapper accelerated compositing build.

  • webkit/webkitwebview.cpp:

(webkit_web_view_realize): Properly access the private data
structure of the WebKitWebView.

05/05/12:

22:27 Changeset [116233] by barraclough@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Remove TrustedImm32::m_isPointer
https://bugs.webkit.org/show_bug.cgi?id=85726

Rubber stamped by Sam Weinig.

We used to rely on being able to generate code with known, fixed offsets – to do so we
would inhibit more optimal code generation for pointers. This is no longer necessary.

  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::TrustedImm32::TrustedImm32):
(TrustedImm32):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::store32):
(JSC::MacroAssemblerARM::move):
(JSC::MacroAssemblerARM::branch32):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::move):

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::add32):
(JSC::MacroAssemblerMIPS::and32):
(JSC::MacroAssemblerMIPS::mul32):
(JSC::MacroAssemblerMIPS::or32):
(JSC::MacroAssemblerMIPS::sub32):
(JSC::MacroAssemblerMIPS::store32):
(JSC::MacroAssemblerMIPS::move):

16:04 Changeset [116232] by commit-queue@webkit.org
  • 7 edits in trunk

Unreviewed, rolling out r116221.
http://trac.webkit.org/changeset/116221
https://bugs.webkit.org/show_bug.cgi?id=85722

broke builds that use -Wshorten-64-to-32 (Requested by pizlo
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-05

Source/WebCore:

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::bufferData):
(WebCore::WebGLRenderingContext::bufferSubData):
(WebCore::WebGLRenderingContext::drawElements):
(WebCore::WebGLRenderingContext::getVertexAttribOffset):
(WebCore::WebGLRenderingContext::vertexAttribPointer):

  • html/canvas/WebGLRenderingContext.h:

(WebGLRenderingContext):

  • html/canvas/WebGLRenderingContext.idl:

LayoutTests:

  • fast/canvas/webgl/index-validation-expected.txt:
  • fast/canvas/webgl/index-validation.html:
14:41 Changeset [116231] by kov@webkit.org
  • 5 edits in trunk/Source

[GTK] WebKit should properly set the input method context window location
https://bugs.webkit.org/show_bug.cgi?id=84981

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-05-05
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

  • platform/gtk/GtkInputMethodFilter.cpp:

(WebCore::GtkInputMethodFilter::setCursorRect): Add this method to plumb the
cursor rect through to the input method.

  • platform/gtk/GtkInputMethodFilter.h: Add the new method declaration.

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::paint): During painting, update the cursor rectangle
if possible.

14:38 Changeset [116230] by dino@apple.com
  • 27 edits
    3 adds in trunk

Add new Setting/Preference to disable requestAnimationFrame
https://bugs.webkit.org/show_bug.cgi?id=85693

Reviewed by Simon Fraser.

Source/WebCore:

Hook up the new WebPreference for disabling requestAnimationFrame
to Settings. This isn't disabling the feature in the typical
WebKit ENABLE() way - it's still available in the DOM, it's
just that the animations will never be serviced. This allows a client
to disable the machinery without breaking content (other than the
animations).

The new test is currently skipped on all platforms because toggling
the preference interferes with the other tests that are running
at the same time (and expect a working requestAnimationFrame).
https://bugs.webkit.org/show_bug.cgi?id=85689

Test: fast/animation/request-animation-frame-disabled.html

  • dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
(WebCore::ScriptedAnimationController::windowScreenDidChange):
(WebCore::ScriptedAnimationController::scheduleAnimation):
Check the setting before deciding to act.

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setRequestAnimationFrameEnabled):
(WebCore::Settings::requestAnimationFrameEnabled):
(Settings):

Source/WebKit/mac:

Exposes a new WebPreference: WebKitRequestAnimationFrameEnabled.
The default value is true. The majority of applications will leave
it this way.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences requestAnimationFrameEnabled]):
(-[WebPreferences setRequestAnimationFrameEnabled:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit/win:

Exposes a new WebPreference: WebKitRequestAnimationFrameEnabled.
The default value is true. The majority of applications will leave
it this way.

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::setRequestAnimationFrameEnabled):
(WebPreferences::requestAnimationFrameEnabled):

  • WebPreferences.h:

(WebPreferences):

  • WebView.cpp:

(WebView::notifyPreferencesChanged):

Source/WebKit2:

Exposes a new WebPreference: WebKitRequestAnimationFrameEnabled.
The default value is true. The majority of applications will leave
it this way.

  • Shared/WebPreferencesStore.h:

(WebKit):

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetRequestAnimationFrameEnabled):
(WKPreferencesGetRequestAnimationFrameEnabled):

  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

LayoutTests:

A new test that exercises turning the requestAnimationFrame
preference off. Unfortunately this conflicts with the parallel
tests that expect the preference to be on (as it should by default),
so the test is skipped on all platforms. It can be run in isolation.
https://bugs.webkit.org/show_bug.cgi?id=85689

  • fast/animation/request-animation-frame-disabled-expected.txt: Added.
  • fast/animation/request-animation-frame-disabled.html: Added.
  • fast/animation/script-tests/request-animation-frame-disabled.js: Added.
  • platform/chromium/test_expectations.txt:
  • platform/efl/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/Skipped:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
  • platform/win/Skipped:
  • platform/win/test_expectations.txt:
14:08 Changeset [116229] by rakuco@webkit.org
  • 2 edits in trunk/Tools

webkitpy: Use os.pathsep instead of manually finding out the path separator in NRWT.
https://bugs.webkit.org/show_bug.cgi?id=85697

Reviewed by Eric Seidel.

  • Scripts/new-run-webkit-tests: Instead of manually detecting whether

the path separator should be ':' or ';' by checking sys.platform, rely
on os.pathsep which has exactly the same information (os.pathsep is
':' for Cygwin, from what I could check in Python's sources).

14:00 Changeset [116228] by kov@webkit.org
  • 4 edits in trunk

Unreviewed preparation for 1.9.2.

  • configure.ac: bump version to 1.9.2 and bump libtool version.

Source/WebKit/gtk:

  • NEWS: changes from 1.9.1.
13:59 Changeset [116227] by kov@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, make distcheck fix.

Source/WebCore:

  • GNUmakefile.list.am: Add missing headers to the sources list.
12:38 Changeset [116226] by jonlee@apple.com
  • 3 edits in trunk/Source/WebKit2

[WK2] Incoming events may be processed out-of-order
https://bugs.webkit.org/show_bug.cgi?id=85696
<rdar://problem/11386129>

Reviewed by Maciej Stachowiak.

All messages go to a single queue that gets iterated over by dispatchMessages(). If an input
event arrives in the middle of a flood of messages, all of them will be dispatched before the
input event is dispatched.

In other words, the first dispatchMessages() call will process all of the messages in the queue,
and all subsequent dispatchMessages() calls will act as no-ops, since there is nothing in the queue.

To fix this, we rename dispatchMessages to dispatchOneMessage, and only process one message at a
time.

  • Platform/CoreIPC/Connection.h: Rename dispatchMessages() to dispatchOneMessage().
  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::enqueueIncomingMessage): Dispatch a call to dispatchOneMessage() on the
run loop.
(CoreIPC::Connection::dispatchOneMessage): Remove the while(true) loop.

10:05 Changeset [116225] by loislo@chromium.org
  • 2 edits in trunk/PerformanceTests

Web Inspector: unreviewed followup fix for the performance test after r116218.

  • inspector/heap-snapshot.html:
09:54 Changeset [116224] by rakuco@webkit.org
  • 3 edits in trunk/Tools

Unreviewed, rolling out r116223.
http://trac.webkit.org/changeset/116223
https://bugs.webkit.org/show_bug.cgi?id=85718

The bots need to set XDG_DATA_DIRS (Requested by rakuco on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-05

  • efl/jhbuildrc:
  • gtk/jhbuildrc:
09:34 Changeset [116223] by rakuco@webkit.org
  • 3 edits in trunk/Tools

[jhbuild] Do not set XDG_DATA_DIRS in jhbuildrc.
https://bugs.webkit.org/show_bug.cgi?id=85717

Reviewed by Martin Robinson.

After r116209, the XDG_DATA_DIRS environment variable is now
passed by webkitpy's layout_tests code to run-with-jhbuild, so
instead of setting a few defaults in jhbuildrc we can now rely on
the values set and really used by each system.

  • efl/jhbuildrc:
  • gtk/jhbuildrc:
08:33 Changeset [116222] by loislo@chromium.org
  • 15 edits
    1 add in trunk/Source/WebCore

Web Inspector: convert standalone functions save/append/savedURL/appendedToURL into WebInspector.FileManager object.
https://bugs.webkit.org/show_bug.cgi?id=85710

The idea is to have an object and be able to add/remove event listeners from it.

Reviewed by Yury Semikhatsky.

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/FileManager.js: Copied from Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js.

(WebInspector.FileManager):
(WebInspector.FileManager.prototype.canSave):
(WebInspector.FileManager.prototype.canAppend):
(WebInspector.FileManager.prototype.append):
(WebInspector.FileManager.prototype.appendedToURL):

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapProfileHeader.prototype.canSave):
(WebInspector.HeapProfileHeader.prototype.save):

  • inspector/front-end/InspectorFrontendHostStub.js:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
07:51 Changeset [116221] by zmo@google.com
  • 7 edits in trunk

vertexAttribPointer needs to reject large negative offsets
https://bugs.webkit.org/show_bug.cgi?id=85117

Reviewed by Kenneth Russell.

Source/WebCore:

  • html/canvas/WebGLRenderingContext.cpp: Use long long for GLsizeiptr and GLintptr

(WebCore):
(WebCore::WebGLRenderingContext::bufferData):
(WebCore::WebGLRenderingContext::bufferSubData):
(WebCore::WebGLRenderingContext::drawElements):
(WebCore::WebGLRenderingContext::getVertexAttribOffset):
(WebCore::WebGLRenderingContext::vertexAttribPointer):

  • html/canvas/WebGLRenderingContext.h: Ditto

(WebGLRenderingContext):

  • html/canvas/WebGLRenderingContext.idl: Ditto

LayoutTests:

  • fast/canvas/webgl/index-validation-expected.txt:
  • fast/canvas/webgl/index-validation.html: Add a test case for large negative offset.
05:24 Changeset [116220] by caseq@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: add separate timeline overview item for the frame mode
https://bugs.webkit.org/show_bug.cgi?id=85706

  • remove two-buttons horizontal/vertical mode switch from Timelines item of the timeline overview menu;
  • rename "Timeline" into "Events";
  • add "Frames" item;
  • replace overview sidebar icons with smaller, monochrome ones.
  • English.lproj/localizedStrings.js: Added "Frames" and "Events".
  • inspector/front-end/Images/statusbarButtonGlyphs.png: Added icon for "Memory".
  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype._showEvents):
(WebInspector.TimelineOverviewPane.prototype._showFrames):
(WebInspector.TimelineOverviewPane.prototype._showMemoryGraph):
(WebInspector.TimelineOverviewPane.prototype._setMode):

  • inspector/front-end/timelinePanel.css:

(#timeline-overview-sidebar .sidebar-tree-item):
(#timeline-overview-sidebar .sidebar-tree-item .titles.no-subtitle):
(#timeline-overview-sidebar .icon):
(.timeline-overview-sidebar-events .icon):
(.timeline-overview-sidebar-frames .icon):
(.timeline-overview-sidebar-memory .icon):

03:25 Changeset [116219] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

Not reviewed: follow up to r116216, fixing the inspector test.

  • inspector/debugger/script-extract-outline.html:
  • inspector/debugger/script-extract-outline-expected.txt:
03:23 Changeset [116218] by loislo@chromium.org
  • 8 edits in trunk

Web Inspector: save HeapSnapshot implementation.
https://bugs.webkit.org/show_bug.cgi?id=85595

HeapSnapshot specific implementation for loading was moved
from ProfilesPanel to HeapProfileHeader class.

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotView.prototype.get profileWrapper):
(WebInspector.HeapSnapshotView.prototype.get baseProfileWrapper):
(WebInspector.HeapProfileHeader):
(WebInspector.HeapProfileHeader.prototype.load.setProfileWait):
(WebInspector.HeapProfileHeader.prototype.load.done):
(WebInspector.HeapProfileHeader.prototype.load):
(WebInspector.HeapProfileHeader.prototype._saveStatusUpdate):
(WebInspector.HeapProfileHeader.prototype.pushJSONChunk):
(WebInspector.HeapProfileHeader.prototype.finishHeapSnapshot):
(WebInspector.HeapProfileHeader.prototype.canSave):
(WebInspector.HeapProfileHeader.prototype.save):

  • inspector/front-end/InspectorFrontendAPI.js:

(InspectorFrontendAPI.appendedToURL):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype._registerProfileType):
(WebInspector.ProfilesPanel.prototype._handleContextMenuEvent):
(WebInspector.ProfilesPanel.prototype.loadHeapSnapshot):
(WebInspector.ProfilesPanel.prototype._addHeapSnapshotChunk):
(WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
(WebInspector.ProfileSidebarTreeElement.prototype.set searchMatches):
(WebInspector.ProfileSidebarTreeElement.prototype.handleContextMenuEvent):

  • inspector/front-end/inspector.js:

(WebInspector.append):
(WebInspector.appendedToURL):

LayoutTests:

  • inspector/profiler/heap-snapshot-inspect-dom-wrapper.html:
  • inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest):

03:07 Changeset [116217] by pfeldman@chromium.org
  • 5 edits in trunk

Web Inspector: allow overriding the script mapping on the UI level
https://bugs.webkit.org/show_bug.cgi?id=85702

Reviewed by Yury Semikhatsky.

Source/WebCore:

This allows formatting update live locations all over the place automatically.

  • inspector/front-end/Script.js:

(WebInspector.Script.prototype.rawLocationToUILocation):
(WebInspector.Script.Location):
(WebInspector.Script.Location.prototype.update):
(WebInspector.Script.Location.prototype.dispose):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.addLiveLocation):
(WebInspector.UISourceCode.prototype.removeLiveLocation):
(WebInspector.UISourceCode.prototype.updateLiveLocations):
(WebInspector.UISourceCode.prototype.overrideLocation):

LayoutTests:

  • inspector/debugger/breakpoint-manager.html:
02:46 Changeset [116216] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: simplify the JavaScriptOutline dialog interaction.
https://bugs.webkit.org/show_bug.cgi?id=85701

Reviewed by Yury Semikhatsky.

Removed bidirectional dependency between scripts panel and outline dialog.

  • inspector/front-end/FilteredItemSelectionDialog.js:

(WebInspector.JavaScriptOutlineDialog):
(WebInspector.JavaScriptOutlineDialog.show):
(WebInspector.JavaScriptOutlineDialog.prototype.requestItems):
(WebInspector.JavaScriptOutlineDialog.prototype._didBuildOutlineChunk):
(WebInspector.JavaScriptOutlineDialog.prototype.selectItem):

  • inspector/front-end/ScriptFormatterWorker.js:
  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.addToWatch):
(WebInspector.ScriptsPanel.prototype._showJavaScriptOutlineDialog):

02:38 Changeset [116215] by ossy@webkit.org
  • 2 edits in trunk/Tools

[Qt] Buildfix for --minimal build after r116107.

Patch by Tor Arne Vestbø <tor.arne.vestbo@nokia.com> on 2012-05-05
Reviewed by Csaba Osztrogonác.

  • qmake/mkspecs/features/features.prf:
00:46 Changeset [116214] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed Gtk gardening, mark fullscreen/non-ancestor-iframe.html as
failing after it was added in r116165.

  • platform/gtk/test_expectations.txt:
00:43 Changeset [116213] by caseq@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed. Rebaseline fast/events/attribute-listener-deletion-crash.html (added in r116191).

  • platform/chromium/fast/events/attribute-listener-deletion-crash-expected.txt: Added.
00:34 Changeset [116212] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

[Gtk] GtkDriver is not required anymore after r116134
https://bugs.webkit.org/show_bug.cgi?id=85699

Reviewed by Csaba Osztrogonác.

Remove GtkDriver as it was replaced by the XvfbDriver and is
no longer needed.

  • Scripts/webkitpy/layout_tests/port/gtk.py:
00:25 Changeset [116211] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

Increase the display ID for the Xvfb process to use if pixel_tests argument
is true rather than if pixel_tests option is present. This fixes the
XvfbDriver in the same way r115825 fixed the now-redundant GtkDriver.

Rubber-stamped by Csaba Osztrogonác.

  • Scripts/webkitpy/layout_tests/port/xvfbdriver.py:

(XvfbDriver._start):

05/04/12:

23:52 Changeset [116210] by loislo@chromium.org
  • 8 edits in trunk/Source/WebCore

Web Inspector: annotate ProfilerAgent.
https://bugs.webkit.org/show_bug.cgi?id=85630

Reviewed by Pavel Feldman.

  • inspector/Inspector.json:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::createProfileHeader):
(WebCore::InspectorProfilerAgent::createSnapshotHeader):
(WebCore::InspectorProfilerAgent::getProfileHeaders):
(WebCore):
(WebCore::InspectorProfilerAgent::getProfile):

  • inspector/InspectorProfilerAgent.h:

(InspectorProfilerAgent):

  • inspector/front-end/CSSSelectorProfileView.js:
  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotProfileType.prototype.createProfile):

  • inspector/front-end/ProfileView.js:
  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype.addProfileHeader):
(WebInspector.ProfilesPanel.prototype._addHeapSnapshotChunk):
(WebInspector.ProfilerDispatcher.prototype.resetProfiles):

22:48 Changeset [116209] by rakuco@webkit.org
  • 2 edits in trunk/Tools

webkitpy: Preserve XDG_DATA_DIRS in the environment passed to ServerProcess.
https://bugs.webkit.org/show_bug.cgi?id=85694

Reviewed by Martin Robinson.

This is sort of a follow-up to r100674: $XDG_DATA_DIRS should be
preserved, as it is particularly useful for Linux/Unix
environments. As a real use case, if shared-mime-info is
installed into a non-trivial prefix, Glib and other libraries will
have trouble to properly identify mimetypes (in ResourceResponses,
for example) as the base freedesktop.org mimetype file will not be
found.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.to.setup_environ_for_server):

21:26 Changeset [116208] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening, unskip test after r116097.

The test was unskipped from Skipped, but some other commit added it to
test_expectations.txt as well...

  • platform/efl/test_expectations.txt:
21:26 Changeset [116207] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening; skip tests that depend on beginDragWithFiles.

  • platform/efl/Skipped:
20:56 Changeset [116206] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed, rebaseline after r116009.

  • platform/efl/fast/block/float/float-not-removed-from-next-sibling4-expected.txt:
20:35 Changeset [116205] by kov@webkit.org
  • 8 edits in trunk

[GTK] Simplify how libWebCoreModules is linked in, and fix WebKit2 build
https://bugs.webkit.org/show_bug.cgi?id=85691

Source/WebCore:

  • GNUmakefile.am: link libWebCoreModules into libWebCore.

Source/WebKit/gtk:

  • GNUmakefile.am: no longer link libwebkitgtk to libWebCoreModules.

Source/WebKit2:

  • GNUmakefile.am: no longer link libWebCoreModules, and remove -no-

fast-install and -no-install from link flags, since we want those
programs installed.

Tools:

  • GNUmakefile.am: no longer link libWebCoreModules to DumpRenderTree.
19:54 Changeset [116204] by tkent@chromium.org
  • 6 edits
    2 moves in trunk/Source

Rename ICULocale to LocaleICU, part 1
https://bugs.webkit.org/show_bug.cgi?id=85688

Reviewed by Kentaro Hara.

Source/WebCore:

Rename it for consistency. Our convention is Foo<Platform>.{cpp,h}.
This patch changes only file names. We'll rename ICULocale class
by a following patch.

No behavior changes.

  • WebCore.gypi:
  • platform/text/LocaleICU.cpp: Renamed from Source/WebCore/platform/text/ICULocale.cpp.
  • platform/text/LocaleICU.h: Renamed from Source/WebCore/platform/text/ICULocale.h.
  • platform/text/LocalizedDateICU.cpp: Rename ICULocale.h to LocaleICU.h.
  • platform/text/LocalizedNumberICU.cpp: ditto.

Source/WebKit/chromium:

  • tests/LocalizedNumberICUTest.cpp: Rename ICULocale.h to LocaleICU.h.
19:17 Changeset [116203] by jchaffraix@webkit.org
  • 2 edits in trunk/Source/WebCore

Leaf non self-painting layers should bail out early in RenderLayer::paintLayer
https://bugs.webkit.org/show_bug.cgi?id=85678

Reviewed by Darin Adler.

Performance optimization, no expected change in behavior.

The gist of the change is that leaf non self-painting layers don't need to be painted as their
associated RenderBoxModelObject should properly paint itself without any help.

For RenderLayer trees that have a large number of leafs nodes (like a table with a leaf RenderLayer for
each cells), not bailing out is a big overhead as it ends up doing a lot of computation for no real
painting. See http://dglazkov.github.com/performance-tests/biggrid.html for a benchmark for that. On
my machine, it reduces the paint time when scrolling to 70ms from 120ms (45% speedup).

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayer):

18:43 Changeset [116202] by rwlbuis@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove InlineBox::next()
https://bugs.webkit.org/show_bug.cgi?id=85668

Reviewed by Nikolas Zimmermann.

InlineBox::next() not needed since nextOnLine() does the same.

  • rendering/InlineBox.h:

(InlineBox):

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::setConstructed):

18:28 Changeset [116201] by crogers@google.com
  • 10 edits
    1 add in trunk

Oscillator must implement noteOn() and noteOff()
https://bugs.webkit.org/show_bug.cgi?id=85236

Reviewed by Kenneth Russell.

Source/WebCore:

Test: webaudio/oscillator-scheduling.html
to be landed separately to get proper platform baselines

  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::process):
Simplify/remove zeroing-out silence at end of buffer, since it's now handled in the base-class AudioScheduledSourceNode::updateSchedulingInfo().

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::createBufferSource):
Improve comment about ownership and dynamic-lifetime of AudioBufferSourceNode.

(WebCore::AudioContext::createOscillator):
AudioContext keeps a reference to the Oscillator and that reference is released in AudioScheduledSourceNode,
when it has finished playing.

  • Modules/webaudio/AudioScheduledSourceNode.h:
  • Modules/webaudio/AudioScheduledSourceNode.cpp:

(WebCore::AudioScheduledSourceNode::updateSchedulingInfo):
updateSchedulingInfo() is now responsible for zeroing out the very start (before a note starts)
and the very end (after note ends) of the output AudioBus. We've also simplified the number
of arguments passed to this method, because of this. It now handles playbackState transition to FINISHED_STATE.

  • Modules/webaudio/Oscillator.cpp:

(WebCore::Oscillator::Oscillator):
(WebCore::Oscillator::calculateSampleAccuratePhaseIncrements):
The frequency value needs to snap immediately to its correct value the very first time.
This bug needs to be fixed here so that the Oscillator layout scheduling test works correctly.

(WebCore::Oscillator::process):
Since Oscillator in now changing to be a AudioScheduledSourceNode, we need to call AudioScheduledSourceNode::updateSchedulingInfo()
to handle playbackState for us.

(WebCore::Oscillator::propagatesSilence):
Add scheduling logic for propagatesSilence().

(Oscillator):

  • Modules/webaudio/Oscillator.idl:

Add noteOn(), noteOff() methods and playbackState according to specification.

LayoutTests:

  • webaudio/oscillator-scheduling-expected.wav: Added.
  • webaudio/resources/oscillator-testing.js:

(generateExponentialOscillatorSweep):

18:17 Changeset [116200] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix a leak in WebProcess when it is used to launch the UI process.

Rubber-stamped by Anders Carlsson.

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain): Destory the attributes and file actions after
spawning the subprocess.

18:12 Changeset [116199] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/blackberry

[Blackberry] Implement over-scroll background image
https://bugs.webkit.org/show_bug.cgi?id=85538

Patch by Andrew Lo <anlo@rim.com> on 2012-05-04
Reviewed by Rob Buis.

Use over-scroll image when set instead of the solid colour.
Internal PR146652

  • Api/BackingStore.cpp:

(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::ensureOverScrollImage):
(BlackBerry::WebKit::BackingStorePrivate::paintDefaultBackground):

  • Api/BackingStore_p.h:

(BackingStorePrivate):

  • Api/WebSettings.cpp:

(WebKit):
(BlackBerry::WebKit::WebSettings::standardSettings):
(BlackBerry::WebKit::WebSettings::overScrollImagePath):
(BlackBerry::WebKit::WebSettings::setOverScrollImagePath):

  • Api/WebSettings.h:
17:54 Changeset [116198] by aestes@apple.com
  • 8 edits in trunk/Source/WebCore

Remove uses of ASSERT(false)
https://bugs.webkit.org/show_bug.cgi?id=85686

Reviewed by Dean Jackson.

Replace uses of ASSERT(false) with ASSERT_NOT_REACHED(). Also, in two places, there was code structured like:

if (expr) {

do something

} else {

ASSERT(false);

}

Replace this with:

ASSERT(expr);
if (!expr)

return;

do something

  • Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::deleteOrigin):
(WebCore::DatabaseTracker::doneCreatingDatabase):
(WebCore::DatabaseTracker::doneDeletingDatabase):
(WebCore::DatabaseTracker::deleteDatabase):

  • bridge/objc/objc_instance.mm:

(ObjcInstance::invokeObjcMethod):

  • bridge/objc/objc_utility.mm:

(JSC::Bindings::convertObjcValueToValue):
(JSC::Bindings::objcValueTypeForType):

  • dom/Node.cpp:

(WebCore::Node::createRenderer):

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::setIconURLForPageURLInSQLDatabase):
(WebCore::IconDatabase::setIconIDForPageURLInSQLDatabase):

  • platform/graphics/GraphicsContext3D.cpp:

(WebCore::doPacking):

  • platform/text/BidiResolver.h:

(WebCore::::createBidiRunsForLine):

17:54 Changeset [116197] by commit-queue@webkit.org
  • 7 edits
    1 move
    2 adds
    1 delete in trunk/LayoutTests

Rebaseline chromium after r116069 (bug 85031)
https://bugs.webkit.org/show_bug.cgi?id=85626

Patch by David Barr <davidbarr@chromium.org> on 2012-05-04
Reviewed by Ojan Vafai.

  • fast/block/float/016-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/float/016-expected.txt.
  • platform/chromium-linux/fast/block/float/016-expected.png:
  • platform/chromium-linux/fast/css/border-solid-single-edge-antialias-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/float/016-expected.png:
  • platform/chromium-mac-snowleopard/fast/block/float/016-expected.png:
  • platform/chromium-mac/fast/block/float/016-expected.png:
  • platform/chromium-win/fast/block/float/016-expected.png:
  • platform/chromium-win/fast/css/border-solid-single-edge-antialias-expected.png: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/block/float/016-expected.txt: Removed.
17:49 Changeset [116196] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

[CG] Minor refactor of ImageBuffer::CGImageToDataURL and its callers
https://bugs.webkit.org/show_bug.cgi?id=85280

Reviewed by Kenneth Russell.

This patch means to simplify the diff of an upcoming patch. Refactoring
here in preparation for that patch.

No new tests. No behavioral change. Covered by canvas 2d and 3d tests:

canvas/philip/tests/*toDataURL*.html
fast/canvas/webgl/premultiplyalpha-test.html

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::CGImageToDataURL): Move the invalid image (!image) test here.
The comments are about JPEG images; say that. Rename out to base64Data.
(WebCore::ImageBuffer::toDataURL): Remove the !image test.
(WebCore::ImageDataToDataURL): Move and define variables where used and
make the code flow read similarly to toDataURL. Remove the !image test.

17:38 Changeset [116195] by shawnsingh@chromium.org
  • 7 edits in trunk/Source

[chromium] Changes to layer tree structure need to be tracked properly
https://bugs.webkit.org/show_bug.cgi?id=85421

Reviewed by Adrienne Walker.

Unit test added: TreeSynchronizerTest.syncSimpleTreeAndTrackStackingOrderChange

Source/WebCore:

Earlier, we were relying on WebCore behavior that always called
setNeedsDisplay whenever the layer tree structure changed.
However, in general it is more correct to consider layer tree
changes even when things don't need repainting; for example Aura
code is encountring this bug now. This patch corrects the
compositor so that layer tree structural changes are considered
property changes, without requiring that layers needed to be
repainted.

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::insertChild):
(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::setStackingOrderChanged):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):

Source/WebKit/chromium:

  • tests/TreeSynchronizerTest.cpp:

(WebKitTests):
(WebKitTests::TEST):

17:10 Changeset [116194] by jpfau@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed; build fix after r116191.

  • bindings/js/JSEventListener.h:
17:04 Changeset [116193] by eric@webkit.org
  • 2 edits in trunk/Tools

Make capitalization and descriptions in FeatureList.pm more consistent to make easier to autogenerate
https://bugs.webkit.org/show_bug.cgi?id=85583

Reviewed by Daniel Bates.

  • Scripts/webkitperl/FeatureList.pm:
16:55 Changeset [116192] by enrica@apple.com
  • 5 edits
    2 adds in trunk

REGRESSION: Cursor jumps to the first line after deleting the last word.
https://bugs.webkit.org/show_bug.cgi?id=85334
<rdar://problem/11210059>

Reviewed by Ryosuke Niwa.

Source/WebCore:

This regression was introduced with the work to remove redundant divs.
When we decide to remove a DIV, we need to adjust the selection, if it is
expressed in terms of the node being removed. The new position was computed
using updatePositionForNodeRemoval that was not designed for the case where we
remove preserving children.
This patch adds a new method to CompositeEditCommand to do this properly.

Test: editing/deleting/delete-word-from-unstyled-div.html

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::isRemovableBlock): Code clenup.
(WebCore::CompositeEditCommand::updatePositionForNodeRemovalPreservingChildren): Added.

  • editing/CompositeEditCommand.h:
  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::removeRedundantBlocks): Uses updatePositionForNodeRemovalPreservingChildren.

LayoutTests:

  • editing/deleting/delete-word-from-unstyled-div-expected.txt: Added.
  • editing/deleting/delete-word-from-unstyled-div.html: Added.
16:42 Changeset [116191] by jpfau@apple.com
  • 3 edits
    2 adds in trunk

Prevent early EventListener deletion
https://bugs.webkit.org/show_bug.cgi?id=73970

Reviewed by Oliver Hunt.

Source/WebCore:

Test: fast/events/attribute-listener-deletion-crash.html

  • bindings/js/JSEventListener.h:

(WebCore::JSEventListener::jsFunction):

LayoutTests:

  • fast/events/attribute-listener-deletion-crash-expected.txt: Added.
  • fast/events/attribute-listener-deletion-crash.html: Added.
16:42 Changeset [116190] by tony@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] enable msvs_error_on_missing_sources at gyp time
https://bugs.webkit.org/show_bug.cgi?id=85683

Reviewed by Adam Barth.

This flag checks for missing files, which cause compile times to be
slow on Windows. Since this flag is on by default for the
build.chromium.org bots, we should add it here too so everyone can fix
these errors.

  • DEPS: Roll to a chromium version that has no missing files.
  • gyp_webkit: Add the flag.
16:34 Changeset [116189] by joepeck@webkit.org
  • 2 edits in trunk/Source/WebCore

Add "combining short stroke overlay character (u0335)" to lookalike characters blacklist.
https://bugs.webkit.org/show_bug.cgi?id=85440

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2012-05-04
Reviewed by David Kilzer.

We should add u0335 to the characters blacklist.

  • platform/mac/WebCoreNSURLExtras.mm:

(WebCore::isLookalikeCharacter):

16:31 Changeset [116188] by jer.noble@apple.com
  • 3 edits
    1 add in trunk

Flash of white when exiting full screen HTML5 video
https://bugs.webkit.org/show_bug.cgi?id=85438

.:

Reviewed by Sam Weinig.

  • ManualTests/fullscreen/full-screen-flash.html: Added.

Source/WebKit2:

Reviewed by Maciej Stachowiak.

Force a repaint before displaying the newly exited WebView window. This gives the window
a chance to seamlessly repaint before enabling screen updates.

Also, send the WebProcess the didExitFullScreen and setAnimatingFullScreen(false) messages
after swapping the WebView back into its original window. Doing otherwise seems to cause
forceRepaint to paint a white frame.

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):
(-[WKFullScreenWindowController completeFinishExitFullScreenAnimationAfterRepaint]):
(completeFinishExitFullScreenAnimationAfterRepaint):

16:11 Changeset [116187] by eric@webkit.org
  • 2 edits in trunk/Tools

Sort entries in FeaturesList.pm to make them easier to autogenerate
https://bugs.webkit.org/show_bug.cgi?id=85584

Reviewed by Daniel Bates.

No functional changes, only sorting.

  • Scripts/webkitperl/FeatureList.pm:
15:59 Changeset [116186] by commit-queue@webkit.org
  • 6 edits in trunk/Source

[chromium] Add plumbing for file display names for drag and drop
https://bugs.webkit.org/show_bug.cgi?id=85673

Patch by Satoru Takabayashi <satorux@chromium.org> on 2012-05-04
Reviewed by Darin Fisher.

Source/WebCore:

No new tests: this change itself shouldn't change existing behavior.

  • platform/chromium/ChromiumDataObject.cpp:

(WebCore::ChromiumDataObject::addFilename):

  • platform/chromium/ChromiumDataObject.h:

(ChromiumDataObject):

Source/WebKit/chromium:

  • public/platform/WebDragData.h:
  • src/WebDragData.cpp:

(WebKit::WebDragData::items):
(WebKit::WebDragData::addItem):

15:55 Changeset [116185] by leviw@chromium.org
  • 2 edits in trunk/Source/WebCore

Correct pixel snapping in RenderSVGRoot::paintReplaced
https://bugs.webkit.org/show_bug.cgi?id=85671

Reviewed by Eric Seidel.

SVG root elements are still painted on pixel boundaries, so their children should
apply transforms based on their actual painted location, not their sub-pixel
one. This corrects a clipping and painting issue where these sub-pixel units are
incorrectly applied to the graphics context.

Covered by existing tests when sub-pixel layout is enabled.

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::paintReplaced):

15:54 Changeset [116184] by lforschler@apple.com
  • 4 edits in trunk/Source

Versioning.

15:44 Changeset [116183] by lforschler@apple.com
  • 4 edits in tags/Safari-536.10.1/Source

Versioning.

15:38 Changeset [116182] by lforschler@apple.com
  • 1 copy in tags/Safari-536.10.1

New Tag.

15:25 Changeset [116181] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk/po

Updated Spanish translation
https://bugs.webkit.org/show_bug.cgi?id=83995

Patch by Daniel Mustieles <daniel.mustieles@gmail.com> on 2012-05-04
Reviewed by Gustavo Noronha Silva.

  • es.po:
15:19 Changeset [116180] by aestes@apple.com
  • 2 edits in trunk/Tools

REGRESSION (r115752): WebKit2.NewFirstVisuallyNonEmptyLayout API test times out
https://bugs.webkit.org/show_bug.cgi?id=85675

  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:

(TestWebKitAPI::TEST): Disable the test.

15:08 Changeset [116179] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit/mac

REGRESSION (r116127-r116165): 6 tests failing on Lion Debug (Tests)
https://bugs.webkit.org/show_bug.cgi?id=85674

Reviewed by Oliver Hunt.

Null check the results of core([frame DOMDocument]).

  • WebView/WebView.mm:

(-[WebView _didStartProvisionalLoadForFrame:]):

15:01 Changeset [116178] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Set the right device scale factor when creating the web page
https://bugs.webkit.org/show_bug.cgi?id=85667
<rdar://problem/11376611>

Reviewed by Oliver Hunt.

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:contextRef:pageGroupRef:]):
Set the scale factor before initializing the page, to ensure that the WebPageCreationParameters struct gets the right scale factor.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setIntrinsicDeviceScaleFactor):
This can now be called with a null drawing area. Also, remove the isValid() check since we still want to update the scale factor even if the web process has crashed.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
Set the device scale factor from the creation parameters.

14:40 Changeset [116177] by abarth@webkit.org
  • 8 edits in trunk/Source

Refactor CSP state to prepare for having both a ReportOnly and an Enforced policy
https://bugs.webkit.org/show_bug.cgi?id=85662

Reviewed by Eric Seidel.

Source/WebCore:

This patch refactors the ContentSecurityPolicy state into a separate
DirectiveList class to prepare for
https://bugs.webkit.org/show_bug.cgi?id=85561, which will cause us to
need two directive lists: one for enforcement and one for monitoring.

This patch shouldn't cause any change in behavior.

  • page/ContentSecurityPolicy.cpp:

(CSPDirectiveList):
(WebCore::CSPDirectiveList::header):
(WebCore::CSPDirectiveList::headerType):
(WebCore::CSPDirectiveList::denyIfEnforcingPolicy):
(WebCore):
(WebCore::CSPDirectiveList::CSPDirectiveList):
(WebCore::CSPDirectiveList::create):
(WebCore::CSPDirectiveList::reportViolation):
(WebCore::CSPDirectiveList::logUnrecognizedDirective):
(WebCore::CSPDirectiveList::checkEval):
(WebCore::CSPDirectiveList::operativeDirective):
(WebCore::CSPDirectiveList::checkInlineAndReportViolation):
(WebCore::CSPDirectiveList::checkEvalAndReportViolation):
(WebCore::CSPDirectiveList::checkSourceAndReportViolation):
(WebCore::CSPDirectiveList::allowJavaScriptURLs):
(WebCore::CSPDirectiveList::allowInlineEventHandlers):
(WebCore::CSPDirectiveList::allowInlineScript):
(WebCore::CSPDirectiveList::allowInlineStyle):
(WebCore::CSPDirectiveList::allowEval):
(WebCore::CSPDirectiveList::allowScriptFromSource):
(WebCore::CSPDirectiveList::allowObjectFromSource):
(WebCore::CSPDirectiveList::allowChildFrameFromSource):
(WebCore::CSPDirectiveList::allowImageFromSource):
(WebCore::CSPDirectiveList::allowStyleFromSource):
(WebCore::CSPDirectiveList::allowFontFromSource):
(WebCore::CSPDirectiveList::allowMediaFromSource):
(WebCore::CSPDirectiveList::allowConnectFromSource):
(WebCore::CSPDirectiveList::parse):
(WebCore::CSPDirectiveList::parseDirective):
(WebCore::CSPDirectiveList::parseReportURI):
(WebCore::CSPDirectiveList::createCSPDirective):
(WebCore::CSPDirectiveList::applySandboxPolicy):
(WebCore::CSPDirectiveList::addDirective):
(WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
(WebCore::ContentSecurityPolicy::~ContentSecurityPolicy):
(WebCore::ContentSecurityPolicy::copyStateFrom):
(WebCore::ContentSecurityPolicy::didReceiveHeader):
(WebCore::ContentSecurityPolicy::setOverrideAllowInlineStyle):
(WebCore::ContentSecurityPolicy::header):
(WebCore::ContentSecurityPolicy::headerType):
(WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
(WebCore::ContentSecurityPolicy::allowInlineEventHandlers):
(WebCore::ContentSecurityPolicy::allowInlineScript):
(WebCore::ContentSecurityPolicy::allowInlineStyle):
(WebCore::ContentSecurityPolicy::allowEval):
(WebCore::ContentSecurityPolicy::allowScriptFromSource):
(WebCore::ContentSecurityPolicy::allowObjectFromSource):
(WebCore::ContentSecurityPolicy::allowChildFrameFromSource):
(WebCore::ContentSecurityPolicy::allowImageFromSource):
(WebCore::ContentSecurityPolicy::allowStyleFromSource):
(WebCore::ContentSecurityPolicy::allowFontFromSource):
(WebCore::ContentSecurityPolicy::allowMediaFromSource):
(WebCore::ContentSecurityPolicy::allowConnectFromSource):

  • page/ContentSecurityPolicy.h:

(WebCore):

  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::startWorkerContext):

Source/WebKit/chromium:

Update callers to the new function name.

  • src/SharedWorkerRepository.cpp:

(WebCore::SharedWorkerScriptLoader::notifyFinished):

  • src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::startWorkerContext):

14:38 Changeset [116176] by fpizlo@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed, updating expectations.

  • platform/mac/fast/block/float/overhanging-tall-block-expected.txt:
14:34 Changeset [116175] by fpizlo@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed, checking in new expectation file.

  • platform/mac/fast/images/png-suite/test-expected.txt: Added.
14:33 Changeset [116174] by inferno@chromium.org
  • 16 edits
    2 adds in trunk

ASSERT(beforeChildAnonymousContainer->isTable()); fails in RenderBlock::addChildIgnoringAnonymousColumnBlocks.
https://bugs.webkit.org/show_bug.cgi?id=84606

Reviewed by Julien Chaffraix.

Source/WebCore:

RenderBlock::removeChild forgot to set display on the anonymous block, causing it
to display as INLINE. To prevent this kind of failure in future, we replace
createAnonymousStyle with createAnonymousStyleWithDisplay to make everyone explictly
pass display as the argument.

Test: fast/block/block-add-child-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeChild):
(WebCore::RenderBlock::createAnonymousWithParentRendererAndDisplay):
(WebCore::RenderBlock::createAnonymousColumnsWithParentRenderer):
(WebCore::RenderBlock::createAnonymousColumnSpanWithParentRenderer):

  • rendering/RenderInline.cpp:

(WebCore::updateStyleOfAnonymousBlockContinuations):
(WebCore::RenderInline::addChildIgnoringContinuation):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::propagateStyleToAnonymousChildren):

  • rendering/RenderRuby.cpp:

(WebCore::createAnonymousRubyInlineBlock):

  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::createRubyBase):
(WebCore::RenderRubyRun::staticCreateRubyRun):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::createAnonymousWithParentRenderer):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::createAnonymousWithParentRenderer):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::createAnonymousWithParentRenderer):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::createAnonymousWithParentRenderer):

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::createAlmostAnonymousBlock):

  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::createAnonymousWithParentRenderer):

  • rendering/mathml/RenderMathMLSubSup.cpp:

(WebCore::RenderMathMLSubSup::addChild):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::createAnonymousStyleWithDisplay):

  • rendering/style/RenderStyle.h:

LayoutTests:

  • fast/block/block-add-child-crash-expected.txt: Added.
  • fast/block/block-add-child-crash.html: Added.
14:30 Changeset [116173] by jer.noble@apple.com
  • 5 edits
    2 adds in trunk

Taking a visibility:hidden element full screen causes full screen window to disappear.
https://bugs.webkit.org/show_bug.cgi?id=85432

Reviewed by Maciej Stachowiak.

.:

  • ManualTests/fullscreen/full-screen-zero-width.html: Added.

Source/WebKit/mac:

When given an initial or final frame with a zero width or height, return a rect representing
the entire screen, rather than a rect with a zero or infinite size. Doing otherwise will
confuse the window server when it's instructed to scale the full screen window to that size.

  • WebView/WebFullScreenController.mm:

(windowFrameFromApparentFrames):

Source/WebKit2:

When given an initial or final frame with a zero width or height, return a rect representing
the entire screen, rather than a rect with a zero or infinite size. Doing otherwise will
confuse the window server when it's instructed to scale the full screen window to that size.

  • UIProcess/mac/WKFullScreenWindowController.mm:

(windowFrameFromApparentFrames):

14:23 Changeset [116172] by arv@chromium.org
  • 13 edits
    1 copy
    12 adds in trunk/Source/WebCore

WebKit IDL does not use exception syntax
https://bugs.webkit.org/show_bug.cgi?id=85100

Reviewed by Dimitri Glazkov.

This adds support for exception ExceptionName { ... } which currently sets a flag
on the domClass.

Binding tests updated.

  • Modules/indexeddb/IDBDatabaseException.idl:
  • Modules/webdatabase/SQLException.idl:
  • bindings/scripts/IDLParser.pm:

(ParseInterface):
(DetermineParseMode):
(ProcessSection):

  • bindings/scripts/IDLStructure.pm:
  • bindings/scripts/test/CPP/WebDOMTestException.cpp: Added.

(WebDOMTestException::WebDOMTestExceptionPrivate::WebDOMTestExceptionPrivate):
(WebDOMTestException::WebDOMTestExceptionPrivate):
(WebDOMTestException::WebDOMTestException):
(WebDOMTestException::operator=):
(WebDOMTestException::impl):
(WebDOMTestException::~WebDOMTestException):
(WebDOMTestException::name):
(toWebCore):
(toWebKit):

  • bindings/scripts/test/CPP/WebDOMTestException.h: Added.

(WebCore):
(WebDOMTestException):

  • bindings/scripts/test/GObject/WebKitDOMTestException.cpp: Added.

(WebKit):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestException):
(webkit_dom_test_exception_finalize):
(webkit_dom_test_exception_set_property):
(webkit_dom_test_exception_get_property):
(webkit_dom_test_exception_constructed):
(webkit_dom_test_exception_class_init):
(webkit_dom_test_exception_init):
(webkit_dom_test_exception_get_name):

  • bindings/scripts/test/GObject/WebKitDOMTestException.h: Added.

(_WebKitDOMTestException):
(_WebKitDOMTestExceptionClass):

  • bindings/scripts/test/GObject/WebKitDOMTestExceptionPrivate.h: Added.

(WebKit):

  • bindings/scripts/test/JS/JSTestException.cpp: Added.

(WebCore):
(WebCore::JSTestExceptionConstructor::JSTestExceptionConstructor):
(WebCore::JSTestExceptionConstructor::finishCreation):
(WebCore::JSTestExceptionConstructor::getOwnPropertySlot):
(WebCore::JSTestExceptionConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestExceptionPrototype::self):
(WebCore::JSTestException::JSTestException):
(WebCore::JSTestException::finishCreation):
(WebCore::JSTestException::createPrototype):
(WebCore::JSTestException::destroy):
(WebCore::JSTestException::~JSTestException):
(WebCore::JSTestException::getOwnPropertySlot):
(WebCore::JSTestException::getOwnPropertyDescriptor):
(WebCore::jsTestExceptionName):
(WebCore::jsTestExceptionConstructor):
(WebCore::JSTestException::getConstructor):
(WebCore::isObservable):
(WebCore::JSTestExceptionOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestExceptionOwner::finalize):
(WebCore::toJS):
(WebCore::toTestException):

  • bindings/scripts/test/JS/JSTestException.h: Added.

(WebCore):
(JSTestException):
(WebCore::JSTestException::create):
(WebCore::JSTestException::createStructure):
(WebCore::JSTestException::impl):
(WebCore::JSTestException::releaseImpl):
(WebCore::JSTestException::releaseImplIfNotNull):
(JSTestExceptionOwner):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
(JSTestExceptionPrototype):
(WebCore::JSTestExceptionPrototype::create):
(WebCore::JSTestExceptionPrototype::createStructure):
(WebCore::JSTestExceptionPrototype::JSTestExceptionPrototype):
(JSTestExceptionConstructor):
(WebCore::JSTestExceptionConstructor::create):
(WebCore::JSTestExceptionConstructor::createStructure):

  • bindings/scripts/test/ObjC/DOMTestException.h: Added.
  • bindings/scripts/test/ObjC/DOMTestException.mm: Added.

(-[DOMTestException dealloc]):
(-[DOMTestException finalize]):
(-[DOMTestException name]):
(core):
(kit):

  • bindings/scripts/test/ObjC/DOMTestExceptionInternal.h: Added.

(WebCore):

  • bindings/scripts/test/TestException.idl: Copied from Source/WebCore/xml/XPathException.idl.
  • bindings/scripts/test/V8/V8TestException.cpp: Added.

(WebCore):
(TestExceptionV8Internal):
(WebCore::TestExceptionV8Internal::V8_USE):
(WebCore::TestExceptionV8Internal::nameAttrGetter):
(WebCore::ConfigureV8TestExceptionTemplate):
(WebCore::V8TestException::GetRawTemplate):
(WebCore::V8TestException::GetTemplate):
(WebCore::V8TestException::HasInstance):
(WebCore::V8TestException::wrapSlow):
(WebCore::V8TestException::derefObject):

  • bindings/scripts/test/V8/V8TestException.h: Added.

(WebCore):
(V8TestException):
(WebCore::V8TestException::toNative):
(WebCore::V8TestException::wrap):
(WebCore::toV8):

  • dom/DOMCoreException.idl:
  • dom/EventException.idl:
  • dom/RangeException.idl:
  • fileapi/FileException.idl:
  • fileapi/OperationNotAllowedException.idl:
  • svg/SVGException.idl:
  • xml/XMLHttpRequestException.idl:
  • xml/XPathException.idl:
14:21 Changeset [116171] by rafaelw@chromium.org
  • 2 edits in trunk/Source/WebCore

V8RecursionScope not declared in V8Proxy::newInstance which causes ASSERT() failure from NPAPI
https://bugs.webkit.org/show_bug.cgi?id=85659

Reviewed by Ojan Vafai.

Added a stack-allocted V8RecursionScope to the newInstance call.

No new tests. No change in observable behavior.

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::newInstance):

14:20 Changeset [116170] by jsbell@chromium.org
  • 4 edits in trunk/Source/WebCore

IndexedDB: Remove all index metadata records when deleting an index
https://bugs.webkit.org/show_bug.cgi?id=85557

Reviewed by Tony Chang.

An assert is hit when re-loading database from backing store due to stale index
metadata entry. Do a range delete to clear all metadata entries when deleting an
index. Define metadata entries as enum and limits as consts instead of hardcoded ints.

No new tests - issue does not repro as layout test. Will land test in Chromium.

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore::getBool): Helper functions; replaces pattern of putInt()/read only lead byte.
(WebCore):
(WebCore::putBool):
(WebCore::IDBLevelDBBackingStore::getObjectStores): Skip stale data. Use enums, helpers.
(WebCore::IDBLevelDBBackingStore::createObjectStore): Use enums.
(WebCore::IDBLevelDBBackingStore::deleteObjectStore): Use enums.
(WebCore::getNewVersionNumber): Use enums.
(WebCore::IDBLevelDBBackingStore::getIndexes): Skip stale data. Use enums, helpers.
(WebCore::getNewIndexId): Use enums.
(WebCore::IDBLevelDBBackingStore::createIndex): Use enums.
(WebCore::IDBLevelDBBackingStore::deleteIndex): Delete metadata by range.

  • Modules/indexeddb/IDBLevelDBCoding.cpp:

(IDBLevelDBCoding): Add constants for metadata maximum values.
(WebCore::IDBLevelDBCoding::encodeBool):
(WebCore::IDBLevelDBCoding::decodeBool):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encodeMaxKey): Use consts.
(WebCore::IDBLevelDBCoding::IndexMetaDataKey::encodeMaxKey): Use consts.

  • Modules/indexeddb/IDBLevelDBCoding.h:

(IDBLevelDBCoding): Expose enums for metadata types.

14:19 Changeset [116169] by aestes@apple.com
  • 2 edits in trunk/LayoutTests

[Mac] IETC flexbox reference tests have pixel differences (due to embedded color profiles?)
https://bugs.webkit.org/show_bug.cgi?id=85666

  • platform/mac/Skipped: Skip the tests.
14:18 Changeset [116168] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

DFG should not Flush GetLocal's
https://bugs.webkit.org/show_bug.cgi?id=85663
<rdar://problem/11373600>

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::flushArgument):
(JSC::DFG::ByteCodeParser::handleCall):

LayoutTests:

  • fast/js/dfg-flush-get-local-expected.txt: Added.
  • fast/js/dfg-flush-get-local.html: Added.
  • fast/js/script-tests/dfg-flush-get-local.js: Added.

(foo):
(fuzz):
(bar):

14:16 Changeset [116167] by andersca@apple.com
  • 9 edits in trunk/Source/WebCore

Move markPagesForFullStyleRecalc to PageCache
https://bugs.webkit.org/show_bug.cgi?id=85664

Reviewed by Dan Bernstein.

Instead of going through all the history items in the back/forward list looking for cached pages, just iterate over the cached pages in the page.

  • history/BackForwardController.cpp:
  • history/BackForwardController.h:
  • history/HistoryItem.cpp:
  • history/HistoryItem.h:
  • history/PageCache.cpp:

(WebCore::PageCache::markPagesForFullStyleRecalc):
(WebCore):

  • history/PageCache.h:

(PageCache):

  • page/Frame.cpp:

(WebCore::Frame::setPageAndTextZoomFactors):

  • page/Page.cpp:

(WebCore::Page::setDeviceScaleFactor):
(WebCore::Page::setPagination):

14:15 Changeset [116166] by tony@chromium.org
  • 5 edits in trunk

The computed style of flex-item-align should never be auto.
https://bugs.webkit.org/show_bug.cgi?id=85656

Reviewed by Ojan Vafai.

Source/WebCore:

If the node lacks a parent and flex-item-align is auto, we should
return stretch. This was recently clarified in the spec.

New testcase in css3/flexbox/css-properties.html.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/css-properties.html:
14:00 Changeset [116165] by jer.noble@apple.com
  • 16 edits
    3 adds in trunk

Full screen will exit during a provisional load of a non-ancestor iframe.
https://bugs.webkit.org/show_bug.cgi?id=85230

Reviewed by Maciej Stachowiak .

Source/WebKit/mac:

Only exit full screen mode if the frame being loaded contains the full
screen element.

  • WebView/WebView.mm:

(-[WebView _didStartProvisionalLoadForFrame:]): Give the UIDelegate a first crack at handling the
request to close the full screen window when a provisional load occurs.

Source/WebKit2:

Only exit full screen mode if the frame being loaded contains the full
screen element:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):

Move the full screen exiting logic up into WebFrameLoaderClient in the
WebProcess:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):

Add a WebFullScreenManager "close" method & message:

  • UIProcess/WebFullScreenManagerProxy.messages.in:
  • WebProcess/FullScreen/WebFullScreenManager.cpp:

(WebKit::WebFullScreenManager::close):

  • WebProcess/FullScreen/WebFullScreenManager.h:

Add support for this new message to the WKBundlePage and client:

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp:

(WebKit::InjectedBundlePageFullScreenClient::closeFullScreen):

  • WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.h:

Tools:

Add support for the new UIDelegate webView:closeFullScreenWithListener: method:

  • DumpRenderTree/mac/UIDelegate.mm:

(-[UIDelegate webView:closeFullScreenWithListener:]):

Add support for the new closeFullScreen injected bundle method:

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::closeFullScreen):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

LayoutTests:

  • fullscreen/non-ancestor-iframe-expected.txt: Added.
  • fullscreen/non-ancestor-iframe.html: Added.
  • fullscreen/resources/empty.html: Added.
13:59 Changeset [116164] by jer.noble@apple.com
  • 4 edits
    2 adds in trunk/Source/WebKit

Move WebKitFullScreenListener into its own file.
https://bugs.webkit.org/show_bug.cgi?id=85640

Source/WebKit:

Reviewed by Maciej Stachowiak .

Pull WebKitFullScreenListener into its own file.

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

Reviewed by Maciej Stachowiak.

Move WebKitFullScreenListener into its own file, so it can be used by multiple classes.

  • WebCoreSupport/WebKitFullScreenListener.h: Added.
  • WebCoreSupport/WebKitFullScreenListener.mm: Added.

(-[WebKitFullScreenListener webkitWillEnterFullScreen]):
(-[WebKitFullScreenListener webkitDidEnterFullScreen]):
(-[WebKitFullScreenListener webkitWillExitFullScreen]):
(-[WebKitFullScreenListener webkitDidExitFullScreen]):

  • WebCoreSupport/WebChromeClient.mm:
13:54 Changeset [116163] by ojan@chromium.org
  • 2 edits in trunk/Tools

Fix test naming to be camel-case like the methods they are testing.

  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

(test):

13:50 Changeset [116162] by ojan@chromium.org
  • 3 edits in trunk/Tools

Show the results links in the embedded flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=85660

Reviewed by Adam Barth.

Turns out these links don't add much visual noise and it's annoying
to have to go to the dashboard from garden-o-matic just to view the
results for a test.

This is useful for cases where garden-o-matic doesn't properly show the
results (e.g. missing tests). If we address all those cases, then
we could easily hide the results links again if we wanted to.

  • TestResultServer/static-dashboards/flakiness_dashboard.js:

(showUpdateInfoForTest):
(htmlForIndividualTestOnAllBuildersWithResultsLinks):

  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

(test):

13:46 Changeset [116161] by dpranke@chromium.org
  • 2 edits in trunk/Tools

Revert to using chromium --test-shell mode on SL in NRWT

https://bugs.webkit.org/show_bug.cgi?id=83076

Unreviewed, build fix.

We seem to be seeing a lot more flakiness on the bot since
I switched NRWT to "DRT" mode. We'll try reverting back and
see if this helps things.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumDriver.init):

13:33 WebKitGTK/1.8.x edited by mrobinson@webkit.org
(diff)
13:28 Changeset [116160] by commit-queue@webkit.org
  • 4 edits in trunk

[soup] URL of the ResourceResponse passed to willSendRequest is incorrect
https://bugs.webkit.org/show_bug.cgi?id=85072

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-04
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Store the response message by catching the "got-headers" signal so
that it can be passed later to willSendRequest() in case of
redirection. This is required because the SoupMessage headers and URL
have already been updated once restartedCallback() is called.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore):
(WebCore::gotHeadersCallback):
(WebCore::restartedCallback):
(WebCore::sendRequestCallback):
(WebCore::startHTTPRequest):

LayoutTests:

Unskip http/tests/misc/will-send-request-returns-null-on-redirect.html
and http/tests/loading/307-after-303-after-post.html now that the
response passed to willSendRequest is correct and now that the right
redirect URL is being printed in EFL port.

Unfortunately, http/tests/loading/redirect-methods.html cannot be
unskipped yet due to bug 66873.

  • platform/efl/test_expectations.txt:
13:20 Changeset [116159] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

REGRESSION(r116134): It made 3 inspector tests fail
https://bugs.webkit.org/show_bug.cgi?id=85654

Unreviewed gardening, skip failing tests until proper fix.

  • platform/qt/Skipped:
13:14 Changeset [116158] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

[EFL] Implement layoutTestController.dumpResourceResponseMIMETypes
https://bugs.webkit.org/show_bug.cgi?id=84941

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-04
Reviewed by Martin Robinson.

Source/WebKit/efl:

Extend Ewk_Frame_Resource_Response structure to pass resource MIME type
information.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchWillSendRequest):
(WebCore::FrameLoaderClientEfl::dispatchDidReceiveResponse):

  • ewk/ewk_frame.h:

Tools:

Print MIME type detection messages in EFL's DumpRenderTree if
LayoutTestController's dumpResourceResponseMIMETypes() returns true.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::onResponseReceived):

LayoutTests:

  • platform/efl/Skipped: Unskip test cases which require MIME type

detection messages now that is is implemented in EFL port.

  • platform/efl/fast/preloader/script-expected.txt: Added. Use same

EFL expectation as in chromium and mac ports (MIME type is
"application/javascript" instead of "application/x-javascript").

13:13 Changeset [116157] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

[BlackBerry] Implement numberOfProcessorCores() for QNX
https://bugs.webkit.org/show_bug.cgi?id=85638

Patch by Jeff Rogers <jrogers@rim.com> on 2012-05-04
Reviewed by Antonio Gomes.

  • wtf/NumberOfCores.cpp:

(WTF::numberOfProcessorCores):

13:12 Changeset [116156] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Fix expectation for test after http://trac.webkit.org/changeset/116143.

  • platform/chromium/test_expectations.txt:
13:10 Changeset [116155] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

All the inspector tests are skipped on chromium-mac. We should
skip the new ones in platform/chromium as well.

  • platform/chromium/test_expectations.txt:
13:08 Changeset [116154] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Suppress yet more Chromium Mac SL timeouts; hopefully close to end
https://bugs.webkit.org/show_bug.cgi?id=83076

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
13:07 Changeset [116153] by inferno@chromium.org
  • 1 edit in branches/chromium/1084/Source/WebCore/rendering/RenderBox.cpp

Merge 115668 - Source/WebCore: Remove positioned float code.
BUG=124919
Review URL: https://chromiumcodereview.appspot.com/10368021

13:06 Changeset [116152] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[chromium] CCProxy's shouldn't try to draw if there is no layer renderer
https://bugs.webkit.org/show_bug.cgi?id=85218

Patch by Ian Vollick <vollick@chromium.org> on 2012-05-04
Reviewed by Adrienne Walker.

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal):

13:01 Changeset [116151] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, test_expectations update.
Remove media/W3C/video/events/event_order_canplay_canplaythrough.html.
The crash is not happening anymore.

Patch by Shadi Khalek <shadi@chromium.org> on 2012-05-04

  • platform/chromium/test_expectations.txt:
12:58 Changeset [116150] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Suppress more Chromium Mac SL timeouts ...
https://bugs.webkit.org/show_bug.cgi?id=83076

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
12:57 Changeset [116149] by rwlbuis@webkit.org
  • 3 edits
    35 deletes in trunk/LayoutTests

Rebaseline some SVG Snow Leopard results
https://bugs.webkit.org/show_bug.cgi?id=85637

Reviewed by Nikolas Zimmermann.

Remove batik expected pngs for Snow Leopard since the generic mac ones match.
Fix types-dom-01-b-expected.txt to expect RenderSVGEllipse.

  • platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
  • platform/mac-snowleopard/svg/batik/filters/feTile-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/filters/filterRegions-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/masking/maskRegions-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/paints/gradientLimit-expected.png:
  • platform/mac-snowleopard/svg/batik/paints/patternPreserveAspectRatioA-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/paints/patternRegionA-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/paints/patternRegions-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/paints/patternRegions-positioned-objects-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/longTextOnPath-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/smallFonts-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textAnchor-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textAnchor2-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textAnchor3-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textDecoration-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textDecoration2-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textEffect-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textEffect2-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textEffect3-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textFeatures-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textGlyphOrientationHorizontal-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textLayout-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textLayout2-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textLength-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textOnPath-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textOnPath2-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textOnPath3-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textOnPathSpaces-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textPCDATA-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textPosition-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textPosition2-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textProperties-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textProperties2-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/textStyles-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/verticalText-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/verticalTextOnPath-expected.png: Removed.
  • platform/mac-snowleopard/svg/batik/text/xmlSpace-expected.png: Removed.
12:53 Changeset [116148] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

Layout Test media/track/track-cues-pause-on-exit.html is flaky on chromium debug builds
https://bugs.webkit.org/show_bug.cgi?id=80067

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-05-04
Reviewed by Eric Carlson.

Trying a different approach, blocking on waitForEvent for the video element.

  • media/track/track-cues-pause-on-exit-expected.txt: Updated.
  • media/track/track-cues-pause-on-exit.html: Changed to use

waitForEvent and listen to exit events right after.

  • media/video-test.js: Updated waitForEvent to enable listening for

events on other elements as well.
(waitForEvent._eventCallback):
(waitForEvent):

12:46 Changeset [116147] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/1084

Merge 115343
BUG=108958
Review URL: https://chromiumcodereview.appspot.com/10368019

12:45 Changeset [116146] by commit-queue@webkit.org
  • 8 edits in trunk

[GTK] DRT needs an implementation of LayoutTestController::setDefersLoading and ::goBack
https://bugs.webkit.org/show_bug.cgi?id=85134

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-04
Reviewed by Martin Robinson.

Source/WebKit/gtk:

Add support for setDefersLoading in DumpRenderTreeSupportGtk.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::setDefersLoading):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Tools:

Add missing implementation setDefersLoading and goBack to GTK's
LayoutTestController so that the test case rely on these methods
can be enabled.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::goBack):
(LayoutTestController::setDefersLoading):

LayoutTests:

Unskip loader/navigation-while-deferring-loads.html and disable
loader/load-defer-resume-crash.html as it triggers an assertion
failure.

  • platform/gtk/test_expectations.txt:
12:44 Changeset [116145] by rwlbuis@webkit.org
  • 7 edits in trunk/Source

[BlackBerry] Rendering bmp file as text file when Content-Type:image/x-ms-bmp from apache web server.
https://bugs.webkit.org/show_bug.cgi?id=85036

Reviewed by Antonio Gomes.

Source/WebCore:

Move getNormalizedMIMEType from WebKit into MIMETypeRegistry. This way we support uncommon mime types like image/pjpeg
and image/x-ms-bmp out of the box since we map to the more common image/jpeg and image/bmp respectively.

  • platform/MIMETypeRegistry.cpp:

(WebCore::initializeSupportedImageMIMETypes):
(WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
(WebCore::MIMETypeRegistry::isSupportedImageResourceMIMEType):
(WebCore):
(WebCore::mimeTypeAssociationMap):
(WebCore::MIMETypeRegistry::getNormalizedMIMEType):

  • platform/MIMETypeRegistry.h:

(MIMETypeRegistry):

Source/WebKit/blackberry:

Move getNormalizedMIMEType into WebCore::MIMETypeRegistry.

  • Api/WebSettings.cpp:

(WebKit):
(BlackBerry::WebKit::WebSettings::isSupportedObjectMIMEType):

  • Api/WebSettings.h:
  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::createPlugin):
(WebCore::FrameLoaderClientBlackBerry::canShowMIMEType):
(WebCore::FrameLoaderClientBlackBerry::objectContentType):

12:38 Changeset [116144] by cevans@google.com
  • 3 edits in branches/chromium/1084

Merge 115763
BUG=125494
Review URL: https://chromiumcodereview.appspot.com/10377014

12:35 Changeset [116143] by aestes@apple.com
  • 2 edits in trunk/LayoutTests

REGRESSION (r116009): image no longer visible on fast/block/float/float-not-removed-from-next-sibling4.html
https://bugs.webkit.org/show_bug.cgi?id=85651

Check in failing results for platform/mac/.

  • platform/mac/fast/block/float/float-not-removed-from-next-sibling4-expected.txt:
12:25 Changeset [116142] by commit-queue@webkit.org
  • 18 edits in trunk/Source

[chromium] Revert compositor layer scrolling
https://bugs.webkit.org/show_bug.cgi?id=85644

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-05-04
Reviewed by Steve Block.

Source/WebCore:

This patch reverts the following commits because they were found to
trigger crashes. See discussion at http://code.google.com/p/chromium/issues/detail?id=124393.

[chromium] Allow scrolling non-root layers in the compositor thread
http://trac.webkit.org/changeset/114651

[chromium] Don't crash when scrolling empty layer tree
http://trac.webkit.org/changeset/114761

[chromium] Don't keep pointers to released layer tree
http://trac.webkit.org/changeset/115080

  • platform/graphics/chromium/ContentLayerChromium.cpp:
  • platform/graphics/chromium/ContentLayerChromium.h:

(ContentLayerChromium):

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(GraphicsLayerChromium):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:
  • platform/graphics/chromium/cc/CCLayerImpl.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::applyScrollAndScale):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:

(CCLayerTreeHostCommon):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::startPageScaleAnimation):
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::contentSize):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):
(WebCore::findScrollLayer):
(WebCore::CCLayerTreeHostImpl::setRootLayer):
(WebCore::CCLayerTreeHostImpl::setPageScaleFactorAndLimits):
(WebCore):
(WebCore::CCLayerTreeHostImpl::adjustScrollsForPageScaleChange):
(WebCore::CCLayerTreeHostImpl::setPageScaleDelta):
(WebCore::CCLayerTreeHostImpl::applyPageScaleDeltaToScrollLayer):
(WebCore::CCLayerTreeHostImpl::updateMaxScrollPosition):
(WebCore::CCLayerTreeHostImpl::scrollBegin):
(WebCore::CCLayerTreeHostImpl::scrollBy):
(WebCore::CCLayerTreeHostImpl::scrollEnd):
(WebCore::CCLayerTreeHostImpl::pinchGestureUpdate):
(WebCore::CCLayerTreeHostImpl::computePinchZoomDeltas):
(WebCore::CCLayerTreeHostImpl::makeScrollAndScaleSet):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):
(WebCore::CCLayerTreeHostImpl::animatePageScale):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore::CCLayerTreeHostImpl::releaseRootLayer):
(WebCore::CCLayerTreeHostImpl::scrollLayer):
(CCLayerTreeHostImpl):

Source/WebKit/chromium:

  • src/WebContentLayerImpl.cpp:
  • src/WebContentLayerImpl.h:

(WebContentLayerImpl):

  • tests/CCLayerTreeHostCommonTest.cpp:
  • tests/CCLayerTreeHostImplTest.cpp:

(WebKitTests::TEST_F):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::MockContentLayerDelegate::paintContents):

12:25 Changeset [116141] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1084

Merge 115398
BUG=124893
Review URL: https://chromiumcodereview.appspot.com/10368018

12:25 Changeset [116140] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Mark editing tests as slow.
https://bugs.webkit.org/show_bug.cgi?id=85649

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
12:15 Changeset [116139] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/1084

Merge 115646
BUG=124895

12:10 Changeset [116138] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Mark a few more tests as flaky across all macs.

Unreviewed, expectations change.

fast/loader/javascript-url-in-embed.html = TEXT PASS (Release only)
http/tests/security/sandboxed-iframe-modify-self.html = TEXT PASS
media/video-poster-blocked-by-willsendrequest.html = TEXT PASS
userscripts/user-style-all-frames.html = TEXT PASS

  • platform/chromium/test_expectations.txt:
12:05 Changeset [116137] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Fix path to external JS file that was not updated when the file
was moved in http://trac.webkit.org/changeset/116128/.

  • platform/chromium/inspector/styles/device-metrics-fit-window.html:
12:00 Changeset [116136] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Mark tests as flaky timeouts on chromium Mac 10.6
https://bugs.webkit.org/show_bug.cgi?id=83076

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
11:58 Changeset [116135] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

Fix the GTK+ debug build after the r116114.

  • WebCoreSupport/EditorClientGtk.cpp:

(WebKit::EditorClient::handleInputMethodKeyboardEvent): Update an
assertion to reflect a real method name in PlatformKeyboardEvent
and remove an unnecessary call to preventDefault() which triggered
an assertion failure higher in the call stack.

11:44 Changeset [116134] by ossy@webkit.org
  • 3 edits
    1 add in trunk/Tools

[Qt][NRWT] Run each DRT in it's own xvfb
https://bugs.webkit.org/show_bug.cgi?id=77335

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2012-05-04
Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort._driver_class):

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort._driver_class):

  • Scripts/webkitpy/layout_tests/port/xvfbdriver.py: Added.

(XvfbDriver):
(XvfbDriver._start):
(XvfbDriver._start.x_filter):
(XvfbDriver.stop):

11:42 Changeset [116133] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, marking a test added in r116127 as failing.

  • platform/gtk/test_expectations.txt:
11:38 Changeset [116132] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

CSP: Eval isn't blocked in about:blank subframes
https://bugs.webkit.org/show_bug.cgi?id=85553

Reviewed by Eric Seidel.

This patch fixes a race condition in this test. We need to wait for
the load event to ensure that the iframe has finished loading.

  • http/tests/security/contentSecurityPolicy/eval-blocked-in-about-blank-iframe.html:
11:31 Changeset [116131] by ojan@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove file that was deleted in http://trac.webkit.org/changeset/116085/.
For some reason, this was breaking the chromium build (probably a gyp bug
since chromium shouldn't be pulling in this file).

  • WebCore.gypi:
11:30 Changeset [116130] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

TiledCoreAnimationDrawingArea should handle visibility changes
https://bugs.webkit.org/show_bug.cgi?id=85645
<rdar://problem/11247192>

Reviewed by Oliver Hunt.

Replicate the visibility handling logic from DrawingAreaImpl and LayerTreeHostCAMac.

  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:

(TiledCoreAnimationDrawingAreaProxy):

  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::visibilityDidChange):
(WebKit):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::suspendPainting):
(WebKit):
(WebKit::TiledCoreAnimationDrawingArea::resumePainting):

11:28 Changeset [116129] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

fix bit packing in FillLayer on Windows
https://bugs.webkit.org/show_bug.cgi?id=85636

Reviewed by Ryosuke Niwa.

Use unsigned for all bit packed types. I manually verified that
the current uses of these member variables always assign true or false.

No new tests, adding a compile assert to verify bit packing.

  • rendering/style/FillLayer.cpp:

(SameSizeAsFillLayer): Added compile assert.
(WebCore):
(WebCore::FillLayer::FillLayer): Reorder m_sizeLength so bit packed fields are adjacent.
(WebCore::FillLayer::operator=): Ditto.

  • rendering/style/FillLayer.h:

(FillLayer): Convert bools to unsigned to match other bit packed fields.

10:57 Changeset [116128] by apavlov@chromium.org
  • 1 edit
    2 moves
    1 add in trunk/LayoutTests

Unreviewed, build fix.
Move Chromium-specific test into platform/chromium.

  • platform/chromium/inspector/styles/device-metrics-fit-window-expected.txt: Renamed from LayoutTests/inspector/styles/device-metrics-fit-window-expected.txt.
  • platform/chromium/inspector/styles/device-metrics-fit-window.html: Renamed from LayoutTests/inspector/styles/device-metrics-fit-window.html.
10:55 Changeset [116127] by tommyw@google.com
  • 11 edits
    2 adds in trunk

MediaStream API: Make PeerConnection00's API fully compliant with the draft
https://bugs.webkit.org/show_bug.cgi?id=85491

Reviewed by Adam Barth.

Source/Platform:

  • chromium/public/WebPeerConnection00HandlerClient.h:

Source/WebCore:

Mainly making the relevant API's use objects (aka Dictionaries) instead of the temporary strings,
but also making a few API's exception aware and changing the name of a flag.

Test: fast/mediastream/peerconnection-iceoptions.html

  • Modules/mediastream/PeerConnection00.cpp:

(WebCore::PeerConnection00::createMediaHints):
(WebCore::PeerConnection00::createOffer):
(WebCore):
(WebCore::PeerConnection00::createAnswer):
(WebCore::PeerConnection00::createIceOptions):
(WebCore::PeerConnection00::createDefaultIceOptions):
(WebCore::PeerConnection00::startIce):
(WebCore::PeerConnection00::addStream):
(WebCore::PeerConnection00::changeReadyState):

  • Modules/mediastream/PeerConnection00.h:

(WebCore):
(PeerConnection00):

  • Modules/mediastream/PeerConnection00.idl:
  • platform/mediastream/chromium/PeerConnection00HandlerInternal.cpp:

(WebCore::PeerConnection00HandlerInternal::startIce):

Source/WebKit/chromium:

  • src/AssertMatchingEnums.cpp:

LayoutTests:

  • fast/mediastream/peerconnection-Attributes-expected.txt:
  • fast/mediastream/peerconnection-iceoptions-expected.txt: Added.
  • fast/mediastream/peerconnection-iceoptions.html: Added.
10:52 Changeset [116126] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

Use destructuring assingment for the return values of the
port.diff_image() method call.

Rubber-stamped by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(write_test_result):

10:47 Changeset [116125] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Chromium should include MenuListPopups' and MenuListOptions' within the ax tree.
https://bugs.webkit.org/show_bug.cgi?id=85541

Patch by David Tseng <dtseng@google.com> on 2012-05-04
Reviewed by Chris Fleizach.

Covered by existing tests.
LayoutTests/accessibility/menu-list-sends-change-notification.html

  • accessibility/AccessibilityMockObject.h:

(WebCore::AccessibilityMockObject::accessibilityIsIgnored):

  • accessibility/chromium/AccessibilityObjectChromium.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

10:44 Changeset [116124] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit/mac

<rdar://problem/11312853> and https://bugs.webkit.org/show_bug.cgi?id=85635 Exception in [WebFrame loadRequest:] breaks some WebKit apps

Reviewed by Alexey Proskuryakov.

Some API clients pass in nil requests or requests with nil URLs.
In r112571 we started rewriting these URLs resulting in an exception.
Since we've supported nil requests until now, we should not try to rewrite these URLs.

  • WebView/WebFrame.mm:

(-[WebFrame loadRequest:]): Don't try to rewrite invalid URLs if they are also null.

10:44 Changeset [116123] by ojan@chromium.org
  • 2 edits in trunk/Tools

Store fewer runs by default in the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=85568

Reviewed by Dirk Pranke.

This will greatly shrink the size of the json files we load,
resulting in a much faster initial load. People rarely care
about more than 100 runs. For the cases they do, they can still click
the show all runs checkbox to show 500 runs.

  • TestResultServer/model/jsonresults.py:
10:41 Changeset [116122] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=85591

Reviewed by Martin Robinson.

Remove incorrect test expectations for tests that are lately consistently
passing on all the Gtk builders but only turned out to be passing after
the Gtk port moved from using Skipped list to test_expectations.txt.
Their proper bug entries will be handled later, after all the tests are
confirmed to still pass. If any test backfires the correct test expectation
will be renewed and bug entries refreshed with latest information.

  • platform/gtk/test_expectations.txt:
10:31 Changeset [116121] by japhet@chromium.org
  • 25 edits in trunk/Source

Don't require FrameLoaderClient to manufacture a commitData() call for empty documents.
https://bugs.webkit.org/show_bug.cgi?id=85533

Reviewed by Alexey Proskuryakov.

Source/WebKit/blackberry:

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::finishedLoading):

Source/WebKit/chromium:

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::FrameLoaderClientImpl):
(WebKit):
(WebKit::FrameLoaderClientImpl::finishedLoading):

  • src/FrameLoaderClientImpl.h:

(WebKit::FrameLoaderClientImpl::makeRepresentation):
(WebKit::FrameLoaderClientImpl::revertToProvisionalState):
(FrameLoaderClientImpl):

Source/WebKit/efl:

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::FrameLoaderClientEfl):
(WebCore):
(WebCore::FrameLoaderClientEfl::finishedLoading):

  • WebCoreSupport/FrameLoaderClientEfl.h:

(WebCore::FrameLoaderClientEfl::makeRepresentation):
(WebCore::FrameLoaderClientEfl::revertToProvisionalState):
(FrameLoaderClientEfl):

Source/WebKit/gtk:

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::FrameLoaderClient):
(WebKit):
(WebKit::FrameLoaderClient::finishedLoading):

  • WebCoreSupport/FrameLoaderClientGtk.h:

(WebKit::FrameLoaderClient::makeRepresentation):
(WebKit::FrameLoaderClient::revertToProvisionalState):
(FrameLoaderClient):

Source/WebKit/mac:

  • WebView/WebHTMLRepresentation.mm:

(-[WebHTMLRepresentation finishedLoadingWithDataSource:]): Calling commitData when finishing is no longer necessary,

as WebCore will take care of simulating the receipt of data and ensuring the requisite work gets done in the blank document case.

Source/WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::FrameLoaderClientQt):
(WebCore):
(WebCore::FrameLoaderClientQt::finishedLoading):

  • WebCoreSupport/FrameLoaderClientQt.h:

(WebCore::FrameLoaderClientQt::makeRepresentation):
(WebCore::FrameLoaderClientQt::revertToProvisionalState):
(FrameLoaderClientQt):

Source/WebKit/win:

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::finishedLoading):

Source/WebKit/wince:

  • WebCoreSupport/FrameLoaderClientWinCE.cpp:

(WebKit::FrameLoaderClientWinCE::finishedLoading):

Source/WebKit/wx:

  • WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::FrameLoaderClientWx::finishedLoading):
(WebCore::FrameLoaderClientWx::setMainDocumentError):
(WebCore::FrameLoaderClientWx::dispatchDidReceiveResponse):
(WebCore::FrameLoaderClientWx::dispatchDidFailLoading):

  • WebKitSupport/FrameLoaderClientWx.h:

(FrameLoaderClientWx):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::finishedLoading):

10:23 Changeset [116120] by leviw@chromium.org
  • 1 edit in trunk/Source/WebCore/ChangeLog

Unreviewed. Fixing ChangeLog conflict markers after 116009.

10:22 Changeset [116119] by commit-queue@webkit.org
  • 11 edits in trunk

[EFL] Frame load callbacks output is missing for redirections
https://bugs.webkit.org/show_bug.cgi?id=85173

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-04
Reviewed by Antonio Gomes.

Source/WebKit/efl:

Add a few redirection-related signals on the ewk_frame so that EFL's
DumpRenderTree can print the expected output when
LayoutTestController's dumpFrameLoadCallbacks() returns true.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchWillSendRequest):
(WebCore::FrameLoaderClientEfl::dispatchDidReceiveResponse):
(WebCore::FrameLoaderClientEfl::dispatchDidReceiveServerRedirectForProvisionalLoad):
(WebCore::FrameLoaderClientEfl::dispatchWillPerformClientRedirect):

  • ewk/ewk_frame.cpp:

(ewk_frame_redirect_provisional_load):
(ewk_frame_redirect_requested):

  • ewk/ewk_frame.h:
  • ewk/ewk_private.h:

Tools:

Catch the new ewk_frame signals to print the expected output in case
of redirections, when LayoutTestController's dumpFrameLoadCallbacks()
returns true.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onWillSendRequest):
(DumpRenderTreeChrome::onFrameCreated):
(DumpRenderTreeChrome::onFrameRedirectForProvisionalLoad):
(DumpRenderTreeChrome::onFrameRedirectRequested):
(DumpRenderTreeChrome::onResponseReceived):

  • DumpRenderTree/efl/DumpRenderTreeChrome.h:

(DumpRenderTreeChrome):

LayoutTests:

Update test_expectations.txt now that EFL's DumpRenderTree is
correctly printing frame load callbacks information in case of
redirections.

  • platform/efl/Skipped:
  • platform/efl/test_expectations.txt:
10:19 Changeset [116118] by commit-queue@webkit.org
  • 2 edits
    3 adds in trunk/LayoutTests

[EFL] [DRT] Gardening some failure cases on EFL port
https://bugs.webkit.org/show_bug.cgi?id=85605

Unreviewed, EFL gardening.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-04

  • platform/efl/fast/canvas/fillText-shadow-expected.txt: Added.
  • platform/efl/fast/dom/Window/window-lookup-precedence-expected.txt: Added.
  • platform/efl/fast/dom/Window/window-properties-performance-expected.txt: Added.
  • platform/efl/test_expectations.txt:
10:12 Changeset [116117] by danw@gnome.org
  • 2 edits in trunk/Source/WebCore
[GTK] ASSERTION FAILED: shouldLoadAsEmptyDocument(r.url())

!defersLoading() in MainResourceLoader.cpp:382

Remove a soup_session_pause_message() call that got left behind,
update the defersLoading stuff to handle this case.

https://bugs.webkit.org/show_bug.cgi?id=85159

Reviewed by Martin Robinson.

No new tests. Now passes loader/load-defer-resume-crash.html under
debug build.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::sendRequestCallback):
(WebCore::ResourceHandle::platformSetDefersLoading):

10:05 Changeset [116116] by apavlov@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: [Device Metrics] With "Fit window" option on, page contents are downscaled incorrectly
https://bugs.webkit.org/show_bug.cgi?id=85510

Reviewed by Pavel Feldman.

Source/WebKit/chromium:

Use the RenderView width rather than FrameView contents width whenever possible.
Drive-by: add protection from division-by-zero (for some weird rendering states).

Test: inspector/styles/device-metrics-fit-window.html

  • src/WebDevToolsAgentImpl.cpp:

(WebKit::DeviceMetricsSupport::ensureOriginalZoomFactor):
(WebKit::DeviceMetricsSupport::scaledEmulatedFrameSize):

LayoutTests:

  • inspector/styles/device-metrics-fit-window-expected.txt: Added.
  • inspector/styles/device-metrics-fit-window.html: Added.
09:57 Changeset [116115] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Fix up warning about missing GLib/Gio/GStreamer

We don't actually fall back.

Rubber-stamped by Csaba Osztrogonác.

09:49 Changeset [116114] by mrobinson@webkit.org
  • 11 edits
    5 adds in trunk/Source

[GTK] Rework IME handling to fix bugs and prepare for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=84556

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

No new tests. This change is already covered by a suite of keyboard
handling unit tests in WebKitGTK+. There are some changes in behavior,
but they are difficult to test without mocking out an entire GtkIMContext.

Add a struct, CompositionResults, which is used by PlatformKeyboardEvent
to package composition information with a keyboard event. Also add some logic
to PlatformKeyboardEvent to give the right information when it has composition
results.

  • GNUmakefile.list.am: Added new sources to the list.
  • platform/PlatformKeyboardEvent.h: Added a new CompositionResults member,

getter, and argument to the constructor.

  • platform/gtk/CompositionResults.h: Added.
  • platform/gtk/GtkInputMethodFilter.cpp: Added.
  • platform/gtk/GtkInputMethodFilter.h: Added.
  • platform/gtk/PlatformKeyboardEventGtk.cpp:

(WebCore::PlatformKeyboardEvent::windowsKeyCodeForGdkKeyCode): When
the key value is void return the VK_PROCESS keycode, which is the keycode
that web content expects with keystrokes that trigger composition events.
(WebCore::eventTypeForGdkKeyEvent): Abstract out this helper.
(WebCore::modifiersForGdkKeyEvent): Abstract out this helper.
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): When a PlatformKeyEvent
has composition results, use VK_PROCESS as the keycode for this event.
(WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent): When this event is
transformed into a Char event, the PlatformKeyboardEvent used for DOM keypress
events, and it has composition results clear the text members. This forces the
EventHandler code to drop the keypress event. Platform events that change the
composition states do not have corresponding keypress DOM events (only keydown
and keyup events), so this is necessary to ensure web compatibility.

Source/WebKit/gtk:

Rework input method handling logic into a class called GtkInputMethodFilter.
This filter now runs before WebCore event handling, allowing the code to more
easily fake simple compositions that should be seen as keystrokes. We can also
filter keypresses that should not go to web content at all, such as key up events
related to key down events that were filtered.

Also added is a WebViewInputMethodFilter which is a concrete implementation of
GtkInputMethodFilter. This class contains logic for actually sending events to
WebCore. In WebKit2 an implementation of GtkInputMethodFilter will send events
across the IPC channel.

  • GNUmakefile.am: Add new files to the source list.
  • WebCoreSupport/ContextMenuClientGtk.cpp:

(WebKit::inputMethodsMenuItem): Access the input method context via the filter.

  • WebCoreSupport/EditorClientGtk.cpp: Remove the tricky logic of input method

events from this class, because it's now in the GtkInputMethodFilter.
(WebKit::EditorClient::setInputMethodState): Call into the filter.
(WebKit::EditorClient::shouldBeginEditing): We no longer need to update the composition here.
This is handled by the focus in and focus out logic in the filter.
(WebKit::EditorClient::shouldEndEditing): Ditto.
(WebKit::EditorClient::respondToChangedSelection): Call into the filter now.
(WebKit::EditorClient::handleInputMethodKeyboardEvent): Added this helper which executes
any pending composition confirmation or preedit update actions as the default action of
the keydown event.
(WebKit::EditorClient::handleKeyboardEvent): Call handleInputMethodKeyboardEvent to do
any pending composition action.
(WebKit::EditorClient::handleInputMethodKeydown): Remove all the logic from this method.
Keys are filtered before they are sent to WebCore now and the actual action of input method
events happens in the keydown default action to increase compatibility with other browsers.
(WebKit::EditorClient::EditorClient): Remove context signal management.
(WebKit::EditorClient::~EditorClient): Ditto.

  • WebCoreSupport/EditorClientGtk.h:

(EditorClient): No longer has some members that tracked IME status.

  • WebCoreSupport/WebViewInputMethodFilter.cpp: Added.
  • WebCoreSupport/WebViewInputMethodFilter.h: Added.
  • webkit/webkitwebview.cpp:

(webkit_web_view_get_property): Get the context from the filter now.
(webkit_web_view_key_press_event): Just send events straight to the filter.
The filter will decide whether or not to send them to WebCore.
(webkit_web_view_key_release_event): Ditto.
(webkit_web_view_button_press_event): Use the filter to handle button press
events related to IME.
(webkit_web_view_focus_in_event): Notify the filter now.
(webkit_web_view_focus_out_event): Ditto.
(webkit_web_view_realize): The filter takes care of listening for realize now.
(webkit_web_view_init): Set the WebView widget on the filter.

  • webkit/webkitwebviewprivate.h: Change the GtkIMContext member to be a GtkInputMethodFilter member.
09:43 Changeset [116113] by jochen@chromium.org
  • 3 edits
    3 adds in trunk

Correctly update the outgoing referrer when navigating back from an history item created by pushState/replaceState
https://bugs.webkit.org/show_bug.cgi?id=85374

Reviewed by Nate Chapin.

Source/WebCore:

Test: http/tests/history/history-navigations-set-referrer.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadInSameDocument):

LayoutTests:

  • http/tests/history/history-navigations-set-referrer-expected.txt: Added.
  • http/tests/history/history-navigations-set-referrer.html: Added.
  • http/tests/history/resources/check-referrer.html: Added.
09:35 Changeset [116112] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Web Timing tests gardening
https://bugs.webkit.org/show_bug.cgi?id=85619

Unreviewed, EFL gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-04

  • platform/efl/test_expectations.txt:
09:32 Changeset [116111] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] REGRESSION: http/tests/xmlhttprequest/basic-auth-nopassword.html started to crash with newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=85632

Unreviewed gardening, skip the new _crashing_ test to paint the bot green.

  • platform/qt-5.0-wk1/Skipped:
09:32 Changeset [116110] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Clarify warning about missing GLib/Gio/GStreamer for media support

And only print it once.

Reviewed by Csaba Osztrogonác.

09:25 Changeset [116109] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] REGRESSION: 350 tests started to fail with newer Qt5-WK1
https://bugs.webkit.org/show_bug.cgi?id=85631

Unreviewed gardening, skip new failing tests to paint the bot green.

  • platform/qt-5.0-wk1/Skipped:
09:17 Changeset [116108] by ossy@webkit.org
  • 3 edits in trunk/LayoutTests

[Qt] REGRESSION: 10 tests started to fail with newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=85629

Unreviewed fix after r116106.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
09:09 Changeset [116107] by vestbo@webkit.org
  • 6 edits
    1 add in trunk

[Qt] Clean up and split features.prf into a static list of defaults

The static list of feature defaults is used as a fallback for any
feature that's not dynamically detected or overriden on the command
line (though build-webkit or passing DEFINES+= to qmake).

The static list is complete, which allows for auto-generation based
on Features.py (see bug https://bugs.webkit.org/show_bug.cgi?id=85456)

https://bugs.webkit.org/show_bug.cgi?id=85611

Reviewed by Simon Hausmann.

08:43 Changeset [116106] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] REGRESSION: 10 tests started to fail with newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=85629

Unreviewed gardening, skip new failing tests to paint the bot green.

  • platform/qt-5.0-wk2/Skipped:
08:27 Changeset [116105] by zoltan@webkit.org
  • 13 edits
    1 add in trunk

Unreviewed, rolling out r116085, r116091, and r116095.
http://trac.webkit.org/changeset/116085
http://trac.webkit.org/changeset/116091
http://trac.webkit.org/changeset/116095
https://bugs.webkit.org/show_bug.cgi?id=85628

We are not ready with dependencies on all platform yet (mac) +
problems with debug builds. (Requested by Zoltan on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-04

Source/WebCore:

  • Target.pri:
  • WebCore.pri:
  • platform/MIMETypeRegistry.cpp:

(WebCore::initializeSupportedImageMIMETypes):
(WebCore::initializeSupportedImageMIMETypesForEncoding):

  • platform/graphics/ImageSource.cpp:
  • platform/graphics/ImageSource.h:

(WebCore):

  • platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoder::create):
(WebCore):
(WebCore::ImageDecoderQt::filenameExtension):
(WebCore::ImageDecoderQt::internalHandleCurrentImage):
(WebCore::ImageDecoderQt::clearPointers):

  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageDecoder::create):

  • platform/image-decoders/ImageDecoder.h:

(WebCore::ImageFrame::getAddr):
(ImageFrame):

  • platform/image-decoders/qt/ImageFrameQt.cpp: Added.

(WebCore):
(WebCore::ImageFrame::ImageFrame):
(WebCore::ImageFrame::operator=):
(WebCore::ImageFrame::clearPixelData):
(WebCore::ImageFrame::zeroFillPixelData):
(WebCore::ImageFrame::copyBitmapData):
(WebCore::ImageFrame::setSize):
(WebCore::ImageFrame::asNewNativeImage):
(WebCore::ImageFrame::hasAlpha):
(WebCore::ImageFrame::setHasAlpha):
(WebCore::ImageFrame::setColorProfile):
(WebCore::ImageFrame::setStatus):
(WebCore::ImageFrame::setPixmap):
(WebCore::ImageFrame::width):
(WebCore::ImageFrame::height):

Source/WebKit/blackberry:

  • WebCoreSupport/AboutDataEnableFeatures.in:

Tools:

  • qmake/mkspecs/features/features.prf:
08:24 Changeset [116104] by loislo@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: eliminate temporaryProfile property from ProfilesPanel.
https://bugs.webkit.org/show_bug.cgi?id=85623

We can run different profilers at the same time therefore we have to keep temorary profile per profiler type.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/CSSSelectorProfileView.js:

(WebInspector.CSSSelectorProfileType.prototype.createView):
(WebInspector.CSSSelectorProfileType.prototype.createTemporaryProfile):
(WebInspector.CSSSelectorProfileType.prototype.createProfile):

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotProfileType.prototype.createView):
(WebInspector.HeapSnapshotProfileType.prototype.createTemporaryProfile):
(WebInspector.HeapSnapshotProfileType.prototype.createProfile):

  • inspector/front-end/ProfileView.js:

(WebInspector.CPUProfileType.prototype.startRecordingProfile):
(WebInspector.CPUProfileType.prototype.createView):
(WebInspector.CPUProfileType.prototype.createTemporaryProfile):
(WebInspector.CPUProfileType.prototype.createProfile):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfileType.prototype.createSidebarTreeElementForProfile):
(WebInspector.ProfileType.prototype.createTemporaryProfile):
(WebInspector.ProfileType.prototype.createProfile):
(WebInspector.ProfileHeader):
(WebInspector.HeapProfileHeader):
(WebInspector.ProfilesPanel.prototype.addProfileHeader):
(WebInspector.ProfilesPanel.prototype.findTemporaryProfile):
(WebInspector.ProfilesPanel.prototype._removeTemporaryProfile):
(WebInspector.ProfilesPanel.prototype._populateProfiles.populateCallback.var):
(WebInspector.ProfilesPanel.prototype._populateProfiles.populateCallback):
(WebInspector.ProfilesPanel.prototype._populateProfiles):
(WebInspector.ProfilesPanel.prototype.setRecordingProfile):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
(WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
(WebInspector.ProfilerDispatcher.prototype.addProfileHeader):

08:14 Changeset [116103] by loislo@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: [chromium] ScriptGCEvent should not be static.
https://bugs.webkit.org/show_bug.cgi?id=80788

The static members of ScriptGCEvent were moved into per isolate data structure.
Drive by fix: Sometimes the used heap size after a GC is slightly more than it was before.

Reviewed by Yury Semikhatsky.

  • bindings/v8/ScriptGCEvent.cpp:

(WebCore::ScriptGCEvent::gcPrologueCallback):
(WebCore::ScriptGCEvent::gcEpilogueCallback):

  • bindings/v8/V8Binding.h:

(WebCore::GCEventData::GCEventData):
(WebCore::GCEventData::clear):
(GCEventData):
(WebCore):
(WebCore::V8BindingPerIsolateData::gcEventData):
(V8BindingPerIsolateData):

07:52 Changeset [116102] by ossy@webkit.org
  • 8 edits
    1 copy in trunk/Source

[Qt] Update Qt bridge after changes to QMetaMethod
https://bugs.webkit.org/show_bug.cgi?id=85478

Patch by Kent Hansen <kent.hansen@nokia.com> on 2012-05-04
Reviewed by Tor Arne Vestbø.

QMetaMethod::signature() has been renamed to methodSignature() and
returns a QByteArray.

The new function QMetaMethod::name() gives direct access to a
method's name. returnType(), parameterCount(), and parameterType()
give direct access to type information.

Ported the custom QtConnectionObject meta-object to revision 7;
revision 6 and below aren't supported (and don't compile) with Qt5.

Source/WebCore:

  • Target.pri:
  • bridge/qt/qt_class.cpp:

(JSC::Bindings::QtClass::fallbackObject):

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtInstance::getPropertyNames):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::findMethodIndex):
(Bindings):
(qt_meta_stringdata_QtConnectionObject_t):
(JSC::Bindings::QtConnectionObject::qt_static_metacall):
(JSC::Bindings::QtConnectionObject::qt_metacast):
(JSC::Bindings::QtConnectionObject::qt_metacall):
(JSC::Bindings::QtConnectionObject::execute):

  • bridge/qt/qt_runtime.h:

(QtConnectionObject):

  • bridge/qt/qt_runtime_qt4.cpp: Copied from Source/WebCore/bridge/qt/qt_runtime.cpp.

(Bindings):
(QWKNoDebug):
(JSC::Bindings::QWKNoDebug::QWKNoDebug):
(JSC::Bindings::QWKNoDebug::~QWKNoDebug):
(JSC::Bindings::QWKNoDebug::operator<<):
(JSC::Bindings::operator<<):
(RuntimeConversion):
(JSC::Bindings::registerCustomType):
(JSC::Bindings::isJSUint8ClampedArray):
(JSC::Bindings::valueRealType):
(JSC::Bindings::convertValueToQVariantMap):
(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):
(JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMethod::finishCreation):
(JSC::Bindings::QtRuntimeMethod::~QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMethod::destroy):
(JSC::Bindings::QtRuntimeMethodData::~QtRuntimeMethodData):
(JSC::Bindings::QtRuntimeMethodData::finalize):
(JSC::Bindings::QtRuntimeMetaMethodData::~QtRuntimeMetaMethodData):
(JSC::Bindings::QtRuntimeConnectionMethodData::~QtRuntimeConnectionMethodData):
(QtMethodMatchType):
(JSC::Bindings::QtMethodMatchType::QtMethodMatchType):
(JSC::Bindings::QtMethodMatchType::kind):
(JSC::Bindings::QtMethodMatchType::isValid):
(JSC::Bindings::QtMethodMatchType::isVariant):
(JSC::Bindings::QtMethodMatchType::isMetaType):
(JSC::Bindings::QtMethodMatchType::isUnresolved):
(JSC::Bindings::QtMethodMatchType::isMetaEnum):
(JSC::Bindings::QtMethodMatchType::enumeratorIndex):
(JSC::Bindings::QtMethodMatchType::variant):
(JSC::Bindings::QtMethodMatchType::metaType):
(JSC::Bindings::QtMethodMatchType::metaEnum):
(JSC::Bindings::QtMethodMatchType::unresolved):
(JSC::Bindings::QtMethodMatchType::typeId):
(JSC::Bindings::QtMethodMatchType::name):
(QtMethodMatchData):
(JSC::Bindings::QtMethodMatchData::QtMethodMatchData):
(JSC::Bindings::QtMethodMatchData::isValid):
(JSC::Bindings::QtMethodMatchData::firstUnresolvedIndex):
(JSC::Bindings::indexOfMetaEnum):
(JSC::Bindings::findMethodIndex):
(JSC::Bindings::findSignalIndex):
(JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod):
(JSC::Bindings::QtRuntimeMetaMethod::finishCreation):
(JSC::Bindings::QtRuntimeMetaMethod::visitChildren):
(JSC::Bindings::QtRuntimeMetaMethod::call):
(JSC::Bindings::QtRuntimeMetaMethod::getCallData):
(JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertySlot):
(JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertyDescriptor):
(JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertyNames):
(JSC::Bindings::QtRuntimeMetaMethod::lengthGetter):
(JSC::Bindings::QtRuntimeMetaMethod::connectGetter):
(JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter):
(JSC::Bindings::QtRuntimeConnectionMethod::QtRuntimeConnectionMethod):
(JSC::Bindings::QtRuntimeConnectionMethod::finishCreation):
(JSC::Bindings::QtRuntimeConnectionMethod::call):
(JSC::Bindings::QtRuntimeConnectionMethod::getCallData):
(JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertySlot):
(JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertyDescriptor):
(JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertyNames):
(JSC::Bindings::QtRuntimeConnectionMethod::lengthGetter):
(JSC::Bindings::QtConnectionObject::QtConnectionObject):
(JSC::Bindings::QtConnectionObject::~QtConnectionObject):
(JSC::Bindings::QtConnectionObject::metaObject):
(JSC::Bindings::QtConnectionObject::qt_metacast):
(JSC::Bindings::QtConnectionObject::qt_metacall):
(JSC::Bindings::isJavaScriptFunction):
(JSC::Bindings::QtConnectionObject::execute):
(JSC::Bindings::QtConnectionObject::match):
(JSC::Bindings::QtConnectionObject::createWithInternalJSC):
(JSC::Bindings::::QtArray):
(JSC::Bindings::::~QtArray):
(JSC::Bindings::::rootObject):
(JSC::Bindings::::setValueAt):
(JSC::Bindings::::valueAt):

Source/WebKit2:

  • UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp:

(gatherAPI):

07:50 Changeset [116101] by ossy@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Don't pass viewport-create function to quick_test_main.
https://bugs.webkit.org/show_bug.cgi?id=85478

Patch by Tor Arne Vestbø <tor.arne.vestbo@nokia.com> on 2012-05-04
Reviewed by Csaba Osztrogonác.

  • UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp:

(main):

07:49 Changeset [116100] by ossy@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt] Buildfix for newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=85478

Reviewed by Tor Arne Vestbø.

  • Shared/qt/ProcessExecutablePathQt.cpp:

(WebKit::executablePath):

  • UIProcess/API/qt/qwebiconimageprovider_p.h:
07:36 Changeset [116099] by yurys@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: use single method for retrieving evaluation context in the runtime agent
https://bugs.webkit.org/show_bug.cgi?id=85621

Reviewed by Pavel Feldman.

Merged two script state retrieval methods into one. Moved Page specific logic
into PageRuntimeAgent.

  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::evaluate):

  • inspector/InspectorRuntimeAgent.h:

(InspectorRuntimeAgent):

  • inspector/PageRuntimeAgent.cpp:

(WebCore::PageRuntimeAgent::scriptStateForEval):

  • inspector/PageRuntimeAgent.h:

(PageRuntimeAgent):

  • inspector/WorkerRuntimeAgent.cpp:

(WebCore::WorkerRuntimeAgent::scriptStateForEval):

  • inspector/WorkerRuntimeAgent.h:

(WorkerRuntimeAgent):

07:33 Changeset [116098] by jochen@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r115549.
http://trac.webkit.org/changeset/115549
https://bugs.webkit.org/show_bug.cgi?id=83894

The newly added CRASH() statements are triggered too often

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::init):
(WebCore::FrameLoader::setupForReplace):
(WebCore::FrameLoader::stopAllLoaders):
(WebCore::FrameLoader::clearProvisionalLoad):
(WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):

07:32 Changeset [116097] by commit-queue@webkit.org
  • 8 edits in trunk

[EFL] LayoutTestController does not support overriding WebKitLoadSiteIconsKey
https://bugs.webkit.org/show_bug.cgi?id=85171

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-04
Reviewed by Andreas Kling.

Source/WebKit/efl:

Add a helper function to DumpRenderTreeSupportEfl to override the
"WebKitLoadSiteIconsKey" setting on the view page.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::setLoadsSiteIconsIgnoringImageLoadingSetting):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Implement support for overriding "WebKitLoadSiteIconsKey" setting in
EFL's LayoutTestController.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::overridePreference):

LayoutTests:

Unskip http/tests/misc/favicon-loads-with-icon-loading-override.html
now that EFL's LayoutTestController support overriding
WebKitLoadSiteIconsKey.

  • platform/efl/Skipped:
07:29 Changeset [116096] by commit-queue@webkit.org
  • 16 edits
    13 adds in trunk/LayoutTests

[EFL][DRT] Gardening away remaining SVG failures
https://bugs.webkit.org/show_bug.cgi?id=85600

Unreviewed, EFL gardening.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-05-04

  • platform/efl/svg/batik/filters/feTile-expected.png: Added.
  • platform/efl/svg/batik/filters/feTile-expected.txt:
  • platform/efl/svg/batik/filters/filterRegions-expected.png: Added.
  • platform/efl/svg/batik/filters/filterRegions-expected.txt:
  • platform/efl/svg/carto.net/button-expected.txt:
  • platform/efl/svg/carto.net/colourpicker-expected.txt:
  • platform/efl/svg/carto.net/slider-expected.txt:
  • platform/efl/svg/carto.net/window-expected.txt:
  • platform/efl/svg/css/stars-with-shadow-expected.txt: Added.
  • platform/efl/svg/hixie/error/014-expected.png: Added.
  • platform/efl/svg/hixie/error/014-expected.txt:
  • platform/efl/svg/hixie/perf/003-expected.png: Added.
  • platform/efl/svg/hixie/perf/003-expected.txt:
  • platform/efl/svg/hixie/shapes/path/001-expected.png: Added.
  • platform/efl/svg/hixie/shapes/path/001-expected.txt: Added.
  • platform/efl/svg/hixie/use/002-expected.png: Added.
  • platform/efl/svg/hixie/use/002-expected.txt:
  • platform/efl/svg/repaint/filter-child-repaint-expected.png: Added.
  • platform/efl/svg/repaint/filter-child-repaint-expected.txt:
  • platform/efl/svg/repaint/filter-repaint-expected.png: Added.
  • platform/efl/svg/repaint/filter-repaint-expected.txt:
  • platform/efl/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
  • platform/efl/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
  • platform/efl/svg/zoom/page/zoom-foreignObject-expected.png: Added.
  • platform/efl/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/efl/svg/zoom/text/zoom-foreignObject-expected.png: Added.
  • platform/efl/svg/zoom/text/zoom-foreignObject-expected.txt:
  • platform/efl/test_expectations.txt:
07:24 Changeset [116095] by zoltan@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Error message fix after r116091
https://bugs.webkit.org/show_bug.cgi?id=85614

Reviewed by Alexis Menard.

No new tests : error message fix.

  • WebCore.pri:
07:16 Changeset [116094] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=85591

Unreviewed, removing incorrect test expectations for tests that turned
to be passing on all the Gtk builders after moving from using Skipped
to test_expectations.txt and have the generic BUGWKGTK modifier.

  • platform/gtk/test_expectations.txt:
07:01 Changeset [116093] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, refined specifiers for unexpectedly passing tests.

  • platform/chromium/test_expectations.txt:
07:00 BuildingQtOnLinux edited by zoltan@webkit.org
(diff)
06:57 Changeset [116092] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Doesn't build with ENABLE_JIT=0
https://bugs.webkit.org/show_bug.cgi?id=85042

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-04
Reviewed by Gavin Barraclough.

  • bytecode/Operands.h:
06:50 Changeset [116091] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

[Qt] Build fix when using libpng version > 1.2.
https://bugs.webkit.org/show_bug.cgi?id=85614

Reviewed by Tor Arne Vestbø.

Don't enforce the version of libpng when passing the option to the linker.

No new tests : build fix.

  • WebCore.pri:
06:36 Changeset [116090] by rakuco@webkit.org
  • 1 edit
    3 moves in trunk/LayoutTests

[EFL] Unreviewed, fix r116067 and r116068.

Fix the names of the expectations I added in those revisions.

  • platform/efl/fast/html/details-marker-style-expected.txt: Renamed from LayoutTests/platform/efl/fast/html/details-marker-style-actual.txt.
  • platform/efl/media/media-can-play-webm-expected.txt: Renamed from LayoutTests/platform/efl/media/media-can-play-webm-actual.txt.
  • platform/efl/svg/as-image/image-respects-pageScaleFactor-expected.txt: Renamed from LayoutTests/platform/efl/svg/as-image/image-respects-pageScaleFactor-actual.txt.
06:32 Changeset [116089] by alexis.menard@openbossa.org
  • 13 edits in trunk

[Qt] Enable fullscreen API for WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=85498

Reviewed by Simon Hausmann.

Source/WebKit2:

Enable the fullscreen API for Qt port. It is only
supported on WebKit2. It adds experimental settings
to enable it and also add two experimental signals so
the API user can react when the fullscreen is requested
(e.g hide the urlbar of a browser and change the state
of the window to be fullscreen).

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qwebpreferences.cpp:

(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferences::fullScreenEnabled):
(QWebPreferences::setFullScreenEnabled):

  • UIProcess/API/qt/qwebpreferences_p.h:
  • UIProcess/API/qt/qwebpreferences_p_p.h:
  • UIProcess/WebFullScreenManagerProxy.h:

(WebKit):

  • UIProcess/qt/WebFullScreenManagerProxyQt.cpp:

(WebKit::WebFullScreenManagerProxy::enterFullScreen):
(WebKit::WebFullScreenManagerProxy::exitFullScreen):

Tools:

Enable the fullscreen API on the MiniBrowser and turn
it default on WebKit2, disable it on WK1.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):

  • MiniBrowser/qt/qml/BrowserWindow.qml:
  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.prf:
06:16 Changeset [116088] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

REGRESSION(r116008) old-run-webkit-tests broken
https://bugs.webkit.org/show_bug.cgi?id=85597

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-04
Reviewed by Simon Hausmann.

Reinstate libraryContainsSymbol.

  • Scripts/webkitperl/features.pm:

(libraryContainsSymbol):

05:53 Changeset [116087] by hausmann@webkit.org
  • 4 edits in trunk/Source

[Qt] Images are scaled badly in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=85610

Reviewed by Jocelyn Turcotte.

Source/WebCore:

Enable smooth pixmap transforms when rendering into the GraphicsSurface image.
This class is only used in WK2.

  • platform/graphics/surfaces/qt/GraphicsSurfaceQt.cpp:

(WebCore::GraphicsSurface::platformBeginPaint):

Source/WebKit2:

Enable smooth pixmap transforms for WK2 bitmaps.

  • Shared/qt/ShareableBitmapQt.cpp:

(WebKit::ShareableBitmap::createGraphicsContext):

05:19 Changeset [116086] by zoltan@webkit.org
  • 9 edits in trunk/Source/WebCore

[Qt] Remove unnecessary executeable bits after r116085

No new tests.

  • Target.pri:
  • WebCore.pri:
  • platform/graphics/ImageSource.cpp:
  • platform/graphics/ImageSource.h:
  • platform/graphics/qt/ImageDecoderQt.cpp:
  • platform/graphics/qt/ImageDecoderQt.h:
  • platform/image-decoders/ImageDecoder.cpp:
  • platform/image-decoders/ImageDecoder.h:
05:10 Changeset [116085] by zoltan@webkit.org
  • 14 edits
    1 delete in trunk

[Qt] Set WebCore imagedecoders as default and add fallback to QImageDecoder
https://bugs.webkit.org/show_bug.cgi?id=80400

Source/WebCore:

This change modifies the default ImageDecoder for Qt-port from QImageDecoder to WebCore ImageDecoder.
The new behavior is to use QImageDecoder only if WebCoreImageDecoder doesn't support the requested
image type.
The WTF_USE_QT_IMAGE_DECODER macro has been removed, since it is no longer needed.

This change adds build depedency for libpng-dev and libjpeg-dev packages, becuase PNG and JPEG imagedecoders
need not only these libraries, but their headers also. Qmake-config tests for these libraries were
introduced in r110045.

Reviewed by Simon Hausmann.

No new tests needed.

  • Target.pri: Move WebCore ImageDecoder files out of guards. Remove ImageFrameQt.cpp from sources.
  • WebCore.pri: Move WebCore ImageDecoder include paths out of guards.
  • platform/MIMETypeRegistry.cpp:

(WebCore::initializeSupportedImageMIMETypes): Add WebCore supported and Qt supported MIME types.
(WebCore::initializeSupportedImageMIMETypesForEncoding): Use Qt supported MIME types.

  • platform/graphics/ImageSource.cpp: Remove unnecessary includes.
  • platform/graphics/ImageSource.h: Remove unnecessary typedefs.

(WebCore):

  • platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoderQt::filenameExtension): Remove unnecessary semicolon.
(WebCore::ImageDecoderQt::internalHandleCurrentImage): Use QImage and ImageFrame instead of QPixmap.
(WebCore):
(WebCore::ImageFrame::asNewNativeImage): Moved here from removed ImageFrameQt.cpp.

  • platform/image-decoders/ImageDecoder.cpp: Reorganize the includes of the header.

(WebCore::ImageDecoder::create): Add platform macro guarded fallback case for QImageDecoder.

  • platform/image-decoders/ImageDecoder.h: Remove Qt-specific codes.

(WebCore::ImageFrame::getAddr): Remove Qt-specific case, since it is no longer needed.
(ImageFrame):

  • platform/image-decoders/qt/ImageFrameQt.cpp: Removed. Dead code, other code has been moved to

ImageDecoderQt.cpp.

Source/WebKit/blackberry:

Get rid off QT_IMAGE_DECODER flag.

Reviewed by Simon Hausmann.

  • WebCoreSupport/AboutDataEnableFeatures.in:

Tools:

Remove WTF_USE_QT_IMAGE_DECODER macro.

Reviewed by Simon Hausmann.

  • qmake/mkspecs/features/features.prf:
05:00 Changeset [116084] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, eval-blocked-in-about-blank-iframe.html: SLOW -> TIMEOUT

  • platform/chromium/test_expectations.txt:
03:59 Changeset [116083] by ossy@webkit.org
  • 6 edits
    1 add in trunk/LayoutTests

[Qt] Unreviewed gardening, update expected files.

  • platform/qt/Skipped: Typo fix.
  • platform/qt/fast/block/float/float-not-removed-from-next-sibling4-expected.png: Added.
  • platform/qt/fast/block/float/float-not-removed-from-next-sibling4-expected.txt:
  • platform/qt/fast/block/float/overhanging-tall-block-expected.png:
  • platform/qt/fast/block/float/overhanging-tall-block-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-device-orientation-expected.txt:
03:46 Changeset [116082] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] ietestcenter/css3/flexbox tests fail on 32 bit
https://bugs.webkit.org/show_bug.cgi?id=85596

Unreviewed gardening, skip new failing tests.

  • platform/qt/Skipped:
03:37 Changeset [116081] by noel.gordon@gmail.com
  • 2 edits
    6 adds in trunk/LayoutTests

[chromium] Unreviewed test expectations update after r116074

  • platform/chromium-mac/fast/images/png-suite/test-expected.png: Added.
  • platform/chromium-win/fast/images/png-suite/test-expected.png: Added.
  • platform/chromium/fast/images/png-suite/test-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
03:21 Changeset [116080] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, changed expectations for fast/images/png-suite/test.html from IMAGE to MISSING.

  • platform/chromium/test_expectations.txt:
03:08 Changeset [116079] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, marking http/tests/security/contentSecurityPolicy/eval-blocked-in-about-blank-iframe.html as slow.

  • platform/chromium/test_expectations.txt:
02:39 Changeset [116078] by carlosgc@webkit.org
  • 2 edits in trunk

Unreviewed, rolling out r116075.
http://trac.webkit.org/changeset/116075

WebKit2 build was broken while WebKit2 build was disabled in bots,
so nobody noticed it. Disable the WebKit2 build for now to keep
the bots green again until we find the actual commit that
broke the WebKit2 build.

  • configure.ac:
02:10 Changeset [116077] by loislo@chromium.org
  • 6 edits in trunk

Web Inspector: createRawLocationByURL is too slow if a big number of evals happen.
https://bugs.webkit.org/show_bug.cgi?id=85477

It iterates through all the _scripts even they have no url.
We can keep a separate map of scripts with url.

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel):
(WebInspector.DebuggerModel.prototype._globalObjectCleared):
(WebInspector.DebuggerModel.prototype._resetScriptsMap):
(WebInspector.DebuggerModel.prototype._parsedScriptSource):
(WebInspector.DebuggerModel.prototype.createRawLocationByURL):

LayoutTests:

  • http/tests/inspector/compiler-script-mapping.html:
  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • inspector/debugger/raw-source-code.html:
02:07 Changeset [116076] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] [DRT] fast/table/quote-text-around-iframe.html needs rebaselining
https://bugs.webkit.org/show_bug.cgi?id=85487

Unreviewed, EFL rebaseline after r115218.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-04

  • platform/efl/fast/table/quote-text-around-iframe-expected.png:
  • platform/efl/fast/table/quote-text-around-iframe-expected.txt:
01:20 Changeset [116075] by carlosgc@webkit.org
  • 2 edits in trunk

Unreviewed. Enable WebKit2 by default in configure.

This was removed in r115624 to make sure release 1.9.1 didn't have
WebKit2 enabled by default, because we are using the same library
versions for WebKit1 and WebKit2.

  • configure.ac: Enable WebKit2 by default.
00:25 Changeset [116074] by noel.gordon@gmail.com
  • 6 edits
    180 adds in trunk/LayoutTests

Add PNG image pngsuite test
https://bugs.webkit.org/show_bug.cgi?id=85567

Reviewed by Eric Seidel.

From http://www.schaik.com/pngsuite, add images from this suite and license
details. Add a layout test. Add platform exceptions (since all ports have a
different broken image).

  • fast/images/png-suite/PngSuite.LICENSE: Added.
  • fast/images/png-suite/samples/basi0g01.png: Added.
  • fast/images/png-suite/samples/basi0g02.png: Added.
  • fast/images/png-suite/samples/basi0g04.png: Added.
  • fast/images/png-suite/samples/basi0g08.png: Added.
  • fast/images/png-suite/samples/basi0g16.png: Added.
  • fast/images/png-suite/samples/basi2c08.png: Added.
  • fast/images/png-suite/samples/basi2c16.png: Added.
  • fast/images/png-suite/samples/basi3p01.png: Added.
  • fast/images/png-suite/samples/basi3p02.png: Added.
  • fast/images/png-suite/samples/basi3p04.png: Added.
  • fast/images/png-suite/samples/basi3p08.png: Added.
  • fast/images/png-suite/samples/basi4a08.png: Added.
  • fast/images/png-suite/samples/basi4a16.png: Added.
  • fast/images/png-suite/samples/basi6a08.png: Added.
  • fast/images/png-suite/samples/basi6a16.png: Added.
  • fast/images/png-suite/samples/basn0g01.png: Added.
  • fast/images/png-suite/samples/basn0g02.png: Added.
  • fast/images/png-suite/samples/basn0g04.png: Added.
  • fast/images/png-suite/samples/basn0g08.png: Added.
  • fast/images/png-suite/samples/basn0g16.png: Added.
  • fast/images/png-suite/samples/basn2c08.png: Added.
  • fast/images/png-suite/samples/basn2c16.png: Added.
  • fast/images/png-suite/samples/basn3p01.png: Added.
  • fast/images/png-suite/samples/basn3p02.png: Added.
  • fast/images/png-suite/samples/basn3p04.png: Added.
  • fast/images/png-suite/samples/basn3p08.png: Added.
  • fast/images/png-suite/samples/basn4a08.png: Added.
  • fast/images/png-suite/samples/basn4a16.png: Added.
  • fast/images/png-suite/samples/basn6a08.png: Added.
  • fast/images/png-suite/samples/basn6a16.png: Added.
  • fast/images/png-suite/samples/bgai4a08.png: Added.
  • fast/images/png-suite/samples/bgai4a16.png: Added.
  • fast/images/png-suite/samples/bgan6a08.png: Added.
  • fast/images/png-suite/samples/bgan6a16.png: Added.
  • fast/images/png-suite/samples/bgbn4a08.png: Added.
  • fast/images/png-suite/samples/bggn4a16.png: Added.
  • fast/images/png-suite/samples/bgwn6a08.png: Added.
  • fast/images/png-suite/samples/bgyn6a16.png: Added.
  • fast/images/png-suite/samples/ccwn2c08.png: Added.
  • fast/images/png-suite/samples/ccwn3p08.png: Added.
  • fast/images/png-suite/samples/cdfn2c08.png: Added.
  • fast/images/png-suite/samples/cdhn2c08.png: Added.
  • fast/images/png-suite/samples/cdsn2c08.png: Added.
  • fast/images/png-suite/samples/cdun2c08.png: Added.
  • fast/images/png-suite/samples/ch1n3p04.png: Added.
  • fast/images/png-suite/samples/ch2n3p08.png: Added.
  • fast/images/png-suite/samples/cm0n0g04.png: Added.
  • fast/images/png-suite/samples/cm7n0g04.png: Added.
  • fast/images/png-suite/samples/cm9n0g04.png: Added.
  • fast/images/png-suite/samples/cs3n2c16.png: Added.
  • fast/images/png-suite/samples/cs3n3p08.png: Added.
  • fast/images/png-suite/samples/cs5n2c08.png: Added.
  • fast/images/png-suite/samples/cs5n3p08.png: Added.
  • fast/images/png-suite/samples/cs8n2c08.png: Added.
  • fast/images/png-suite/samples/cs8n3p08.png: Added.
  • fast/images/png-suite/samples/ct0n0g04.png: Added.
  • fast/images/png-suite/samples/ct1n0g04.png: Added.
  • fast/images/png-suite/samples/cten0g04.png: Added.
  • fast/images/png-suite/samples/ctfn0g04.png: Added.
  • fast/images/png-suite/samples/ctgn0g04.png: Added.
  • fast/images/png-suite/samples/cthn0g04.png: Added.
  • fast/images/png-suite/samples/ctjn0g04.png: Added.
  • fast/images/png-suite/samples/ctzn0g04.png: Added.
  • fast/images/png-suite/samples/f00n0g08.png: Added.
  • fast/images/png-suite/samples/f00n2c08.png: Added.
  • fast/images/png-suite/samples/f01n0g08.png: Added.
  • fast/images/png-suite/samples/f01n2c08.png: Added.
  • fast/images/png-suite/samples/f02n0g08.png: Added.
  • fast/images/png-suite/samples/f02n2c08.png: Added.
  • fast/images/png-suite/samples/f03n0g08.png: Added.
  • fast/images/png-suite/samples/f03n2c08.png: Added.
  • fast/images/png-suite/samples/f04n0g08.png: Added.
  • fast/images/png-suite/samples/f04n2c08.png: Added.
  • fast/images/png-suite/samples/f99n0g04.png: Added.
  • fast/images/png-suite/samples/g03n0g16.png: Added.
  • fast/images/png-suite/samples/g03n2c08.png: Added.
  • fast/images/png-suite/samples/g03n3p04.png: Added.
  • fast/images/png-suite/samples/g04n0g16.png: Added.
  • fast/images/png-suite/samples/g04n2c08.png: Added.
  • fast/images/png-suite/samples/g04n3p04.png: Added.
  • fast/images/png-suite/samples/g05n0g16.png: Added.
  • fast/images/png-suite/samples/g05n2c08.png: Added.
  • fast/images/png-suite/samples/g05n3p04.png: Added.
  • fast/images/png-suite/samples/g07n0g16.png: Added.
  • fast/images/png-suite/samples/g07n2c08.png: Added.
  • fast/images/png-suite/samples/g07n3p04.png: Added.
  • fast/images/png-suite/samples/g10n0g16.png: Added.
  • fast/images/png-suite/samples/g10n2c08.png: Added.
  • fast/images/png-suite/samples/g10n3p04.png: Added.
  • fast/images/png-suite/samples/g25n0g16.png: Added.
  • fast/images/png-suite/samples/g25n2c08.png: Added.
  • fast/images/png-suite/samples/g25n3p04.png: Added.
  • fast/images/png-suite/samples/oi1n0g16.png: Added.
  • fast/images/png-suite/samples/oi1n2c16.png: Added.
  • fast/images/png-suite/samples/oi2n0g16.png: Added.
  • fast/images/png-suite/samples/oi2n2c16.png: Added.
  • fast/images/png-suite/samples/oi4n0g16.png: Added.
  • fast/images/png-suite/samples/oi4n2c16.png: Added.
  • fast/images/png-suite/samples/oi9n0g16.png: Added.
  • fast/images/png-suite/samples/oi9n2c16.png: Added.
  • fast/images/png-suite/samples/pp0n2c16.png: Added.
  • fast/images/png-suite/samples/pp0n6a08.png: Added.
  • fast/images/png-suite/samples/ps1n0g08.png: Added.
  • fast/images/png-suite/samples/ps1n2c16.png: Added.
  • fast/images/png-suite/samples/ps2n0g08.png: Added.
  • fast/images/png-suite/samples/ps2n2c16.png: Added.
  • fast/images/png-suite/samples/s01i3p01.png: Added.
  • fast/images/png-suite/samples/s01n3p01.png: Added.
  • fast/images/png-suite/samples/s02i3p01.png: Added.
  • fast/images/png-suite/samples/s02n3p01.png: Added.
  • fast/images/png-suite/samples/s03i3p01.png: Added.
  • fast/images/png-suite/samples/s03n3p01.png: Added.
  • fast/images/png-suite/samples/s04i3p01.png: Added.
  • fast/images/png-suite/samples/s04n3p01.png: Added.
  • fast/images/png-suite/samples/s05i3p02.png: Added.
  • fast/images/png-suite/samples/s05n3p02.png: Added.
  • fast/images/png-suite/samples/s06i3p02.png: Added.
  • fast/images/png-suite/samples/s06n3p02.png: Added.
  • fast/images/png-suite/samples/s07i3p02.png: Added.
  • fast/images/png-suite/samples/s07n3p02.png: Added.
  • fast/images/png-suite/samples/s08i3p02.png: Added.
  • fast/images/png-suite/samples/s08n3p02.png: Added.
  • fast/images/png-suite/samples/s09i3p02.png: Added.
  • fast/images/png-suite/samples/s09n3p02.png: Added.
  • fast/images/png-suite/samples/s32i3p04.png: Added.
  • fast/images/png-suite/samples/s32n3p04.png: Added.
  • fast/images/png-suite/samples/s33i3p04.png: Added.
  • fast/images/png-suite/samples/s33n3p04.png: Added.
  • fast/images/png-suite/samples/s34i3p04.png: Added.
  • fast/images/png-suite/samples/s34n3p04.png: Added.
  • fast/images/png-suite/samples/s35i3p04.png: Added.
  • fast/images/png-suite/samples/s35n3p04.png: Added.
  • fast/images/png-suite/samples/s36i3p04.png: Added.
  • fast/images/png-suite/samples/s36n3p04.png: Added.
  • fast/images/png-suite/samples/s37i3p04.png: Added.
  • fast/images/png-suite/samples/s37n3p04.png: Added.
  • fast/images/png-suite/samples/s38i3p04.png: Added.
  • fast/images/png-suite/samples/s38n3p04.png: Added.
  • fast/images/png-suite/samples/s39i3p04.png: Added.
  • fast/images/png-suite/samples/s39n3p04.png: Added.
  • fast/images/png-suite/samples/s40i3p04.png: Added.
  • fast/images/png-suite/samples/s40n3p04.png: Added.
  • fast/images/png-suite/samples/tbbn0g04.png: Added.
  • fast/images/png-suite/samples/tbbn2c16.png: Added.
  • fast/images/png-suite/samples/tbbn3p08.png: Added.
  • fast/images/png-suite/samples/tbgn2c16.png: Added.
  • fast/images/png-suite/samples/tbgn3p08.png: Added.
  • fast/images/png-suite/samples/tbrn2c08.png: Added.
  • fast/images/png-suite/samples/tbwn0g16.png: Added.
  • fast/images/png-suite/samples/tbwn3p08.png: Added.
  • fast/images/png-suite/samples/tbyn3p08.png: Added.
  • fast/images/png-suite/samples/tp0n0g08.png: Added.
  • fast/images/png-suite/samples/tp0n2c08.png: Added.
  • fast/images/png-suite/samples/tp0n3p08.png: Added.
  • fast/images/png-suite/samples/tp1n3p08.png: Added.
  • fast/images/png-suite/samples/xc1n0g08.png: Added.
  • fast/images/png-suite/samples/xc9n2c08.png: Added.
  • fast/images/png-suite/samples/xcrn0g04.png: Added.
  • fast/images/png-suite/samples/xcsn0g01.png: Added.
  • fast/images/png-suite/samples/xd0n2c08.png: Added.
  • fast/images/png-suite/samples/xd3n2c08.png: Added.
  • fast/images/png-suite/samples/xd9n2c08.png: Added.
  • fast/images/png-suite/samples/xdtn0g01.png: Added.
  • fast/images/png-suite/samples/xhdn0g08.png: Added.
  • fast/images/png-suite/samples/xlfn0g04.png: Added.
  • fast/images/png-suite/samples/xs1n0g01.png: Added.
  • fast/images/png-suite/samples/xs2n0g01.png: Added.
  • fast/images/png-suite/samples/xs4n0g01.png: Added.
  • fast/images/png-suite/samples/xs7n0g01.png: Added.
  • fast/images/png-suite/samples/z00n2c08.png: Added.
  • fast/images/png-suite/samples/z03n2c08.png: Added.
  • fast/images/png-suite/samples/z06n2c08.png: Added.
  • fast/images/png-suite/samples/z09n2c08.png: Added.
  • fast/images/png-suite/test-expected.png: Added.
  • fast/images/png-suite/test.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/efl/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/fast/images/png-suite/test-expected.png: Added.
  • platform/qt/test_expectations.txt:
  • platform/wincairo/Skipped:
Note: See TracTimeline for information about the timeline view.